File size: 5,469 Bytes
fc93158 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 | import { describe, expect, it } from "vitest";
import type { CronJob } from "../../cron/types.js";
import type { RuntimeEnv } from "../../runtime.js";
import { printCronList } from "./shared.js";
function createRuntimeLogCapture(): { logs: string[]; runtime: RuntimeEnv } {
const logs: string[] = [];
const runtime = {
log: (msg: string) => logs.push(msg),
error: () => {},
exit: () => {},
} as RuntimeEnv;
return { logs, runtime };
}
function createBaseJob(overrides: Partial<CronJob>): CronJob {
const now = Date.now();
return {
id: "job-id",
agentId: "main",
name: "Test Job",
enabled: true,
createdAtMs: now,
updatedAtMs: now,
schedule: { kind: "at", at: new Date(now + 3600000).toISOString() },
wakeMode: "next-heartbeat",
payload: { kind: "systemEvent", text: "test" },
state: { nextRunAtMs: now + 3600000 },
...overrides,
} as CronJob;
}
describe("printCronList", () => {
it("handles job with undefined sessionTarget (#9649)", () => {
const { logs, runtime } = createRuntimeLogCapture();
// Simulate a job without sessionTarget (as reported in #9649)
const jobWithUndefinedTarget = createBaseJob({
id: "test-job-id",
// sessionTarget is intentionally omitted to simulate the bug
});
// This should not throw "Cannot read properties of undefined (reading 'trim')"
expect(() => printCronList([jobWithUndefinedTarget], runtime)).not.toThrow();
// Verify output contains the job
expect(logs.length).toBeGreaterThan(1);
expect(logs.some((line) => line.includes("test-job-id"))).toBe(true);
});
it("handles job with defined sessionTarget", () => {
const { logs, runtime } = createRuntimeLogCapture();
const jobWithTarget = createBaseJob({
id: "test-job-id-2",
name: "Test Job 2",
sessionTarget: "isolated",
});
expect(() => printCronList([jobWithTarget], runtime)).not.toThrow();
expect(logs.some((line) => line.includes("isolated"))).toBe(true);
});
it("shows stagger label for cron schedules", () => {
const { logs, runtime } = createRuntimeLogCapture();
const job = createBaseJob({
id: "staggered-job",
name: "Staggered",
schedule: { kind: "cron", expr: "0 * * * *", staggerMs: 5 * 60_000 },
sessionTarget: "main",
state: {},
payload: { kind: "systemEvent", text: "tick" },
});
printCronList([job], runtime);
expect(logs.some((line) => line.includes("(stagger 5m)"))).toBe(true);
});
it("shows dash for unset agentId instead of default", () => {
const { logs, runtime } = createRuntimeLogCapture();
const job = createBaseJob({
id: "no-agent-job",
name: "No Agent",
agentId: undefined,
sessionTarget: "isolated",
payload: { kind: "agentTurn", message: "hello", model: "sonnet" },
});
printCronList([job], runtime);
// Header should say "Agent ID" not "Agent"
expect(logs[0]).toContain("Agent ID");
// Data row should show "-" for missing agentId, not "default"
const dataLine = logs[1] ?? "";
expect(dataLine).not.toContain("default");
});
it("shows Model column with payload.model for agentTurn jobs", () => {
const { logs, runtime } = createRuntimeLogCapture();
const job = createBaseJob({
id: "model-job",
name: "With Model",
agentId: "ops",
sessionTarget: "isolated",
payload: { kind: "agentTurn", message: "hello", model: "sonnet" },
});
printCronList([job], runtime);
expect(logs[0]).toContain("Model");
const dataLine = logs[1] ?? "";
expect(dataLine).toContain("sonnet");
});
it("shows dash in Model column for systemEvent jobs", () => {
const { logs, runtime } = createRuntimeLogCapture();
const job = createBaseJob({
id: "sys-event-job",
name: "System Event",
sessionTarget: "main",
payload: { kind: "systemEvent", text: "tick" },
});
printCronList([job], runtime);
expect(logs[0]).toContain("Model");
});
it("shows dash in Model column for agentTurn jobs without model override", () => {
const { logs, runtime } = createRuntimeLogCapture();
const job = createBaseJob({
id: "no-model-job",
name: "No Model",
sessionTarget: "isolated",
payload: { kind: "agentTurn", message: "hello" },
});
printCronList([job], runtime);
const dataLine = logs[1] ?? "";
expect(dataLine).not.toContain("undefined");
});
it("shows explicit agentId when set", () => {
const { logs, runtime } = createRuntimeLogCapture();
const job = createBaseJob({
id: "agent-set-job",
name: "Agent Set",
agentId: "ops",
sessionTarget: "isolated",
payload: { kind: "agentTurn", message: "hello", model: "opus" },
});
printCronList([job], runtime);
const dataLine = logs[1] ?? "";
expect(dataLine).toContain("ops");
expect(dataLine).toContain("opus");
});
it("shows exact label for cron schedules with stagger disabled", () => {
const { logs, runtime } = createRuntimeLogCapture();
const job = createBaseJob({
id: "exact-job",
name: "Exact",
schedule: { kind: "cron", expr: "0 7 * * *", staggerMs: 0 },
sessionTarget: "main",
state: {},
payload: { kind: "systemEvent", text: "tick" },
});
printCronList([job], runtime);
expect(logs.some((line) => line.includes("(exact)"))).toBe(true);
});
});
|