File size: 7,077 Bytes
fc93158 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 | import { beforeEach, describe, expect, it, vi } from "vitest";
const messageCommandMock = vi.fn(async () => {});
vi.mock("../../../commands/message.js", () => ({
messageCommand: messageCommandMock,
}));
vi.mock("../../../globals.js", () => ({
danger: (s: string) => s,
setVerbose: vi.fn(),
}));
vi.mock("../../plugin-registry.js", () => ({
ensurePluginRegistryLoaded: vi.fn(),
}));
const hasHooksMock = vi.fn((_hookName: string) => false);
const runGatewayStopMock = vi.fn(
async (_event: { reason?: string }, _ctx: Record<string, unknown>) => {},
);
const runGlobalGatewayStopSafelyMock = vi.fn(
async (params: {
event: { reason?: string };
ctx: Record<string, unknown>;
onError?: (err: unknown) => void;
}) => {
if (!hasHooksMock("gateway_stop")) {
return;
}
try {
await runGatewayStopMock(params.event, params.ctx);
} catch (err) {
params.onError?.(err);
}
},
);
vi.mock("../../../plugins/hook-runner-global.js", () => ({
runGlobalGatewayStopSafely: runGlobalGatewayStopSafelyMock,
}));
const exitMock = vi.fn((): never => {
throw new Error("exit");
});
const errorMock = vi.fn();
const runtimeMock = { log: vi.fn(), error: errorMock, exit: exitMock };
vi.mock("../../../runtime.js", () => ({
defaultRuntime: runtimeMock,
}));
vi.mock("../../deps.js", () => ({
createDefaultDeps: () => ({}),
}));
const { createMessageCliHelpers } = await import("./helpers.js");
const baseSendOptions = {
channel: "discord",
target: "123",
message: "hi",
};
function createRunMessageAction() {
const fakeCommand = { help: vi.fn() } as never;
return createMessageCliHelpers(fakeCommand, "discord").runMessageAction;
}
async function runSendAction(opts: Record<string, unknown> = {}) {
const runMessageAction = createRunMessageAction();
await expect(runMessageAction("send", { ...baseSendOptions, ...opts })).rejects.toThrow("exit");
}
function expectNoAccountFieldInPassedOptions() {
const passedOpts = (
messageCommandMock.mock.calls as unknown as Array<[Record<string, unknown>]>
)?.[0]?.[0];
expect(passedOpts).toBeTruthy();
if (!passedOpts) {
throw new Error("expected message command call");
}
expect(passedOpts).not.toHaveProperty("account");
}
describe("runMessageAction", () => {
beforeEach(() => {
vi.clearAllMocks();
messageCommandMock.mockClear().mockResolvedValue(undefined);
hasHooksMock.mockClear().mockReturnValue(false);
runGatewayStopMock.mockClear().mockResolvedValue(undefined);
runGlobalGatewayStopSafelyMock.mockClear();
exitMock.mockClear().mockImplementation((): never => {
throw new Error("exit");
});
});
it("calls exit(0) after successful message delivery", async () => {
await runSendAction();
expect(exitMock).toHaveBeenCalledOnce();
expect(exitMock).toHaveBeenCalledWith(0);
});
it("runs gateway_stop hooks before exit when registered", async () => {
hasHooksMock.mockReturnValueOnce(true);
await runSendAction();
expect(runGatewayStopMock).toHaveBeenCalledWith({ reason: "cli message action complete" }, {});
expect(exitMock).toHaveBeenCalledWith(0);
});
it("calls exit(1) when message delivery fails", async () => {
messageCommandMock.mockRejectedValueOnce(new Error("send failed"));
await runSendAction();
expect(errorMock).toHaveBeenCalledWith("Error: send failed");
expect(exitMock).toHaveBeenCalledOnce();
expect(exitMock).toHaveBeenCalledWith(1);
});
it("runs gateway_stop hooks on failure before exit(1)", async () => {
hasHooksMock.mockReturnValueOnce(true);
messageCommandMock.mockRejectedValueOnce(new Error("send failed"));
await runSendAction();
expect(runGatewayStopMock).toHaveBeenCalledWith({ reason: "cli message action complete" }, {});
expect(exitMock).toHaveBeenCalledWith(1);
});
it("logs gateway_stop failure and still exits with success code", async () => {
hasHooksMock.mockReturnValueOnce(true);
runGatewayStopMock.mockRejectedValueOnce(new Error("hook failed"));
await runSendAction();
expect(errorMock).toHaveBeenCalledWith("gateway_stop hook failed: Error: hook failed");
expect(exitMock).toHaveBeenCalledWith(0);
});
it("logs gateway_stop failure and preserves failure exit code when send fails", async () => {
hasHooksMock.mockReturnValueOnce(true);
messageCommandMock.mockRejectedValueOnce(new Error("send failed"));
runGatewayStopMock.mockRejectedValueOnce(new Error("hook failed"));
await runSendAction();
expect(errorMock).toHaveBeenNthCalledWith(1, "Error: send failed");
expect(errorMock).toHaveBeenNthCalledWith(2, "gateway_stop hook failed: Error: hook failed");
expect(exitMock).toHaveBeenCalledWith(1);
});
it("does not call exit(0) when the action throws", async () => {
messageCommandMock.mockRejectedValueOnce(new Error("boom"));
await runSendAction();
// exit should only be called once with code 1, never with 0
expect(exitMock).toHaveBeenCalledOnce();
expect(exitMock).not.toHaveBeenCalledWith(0);
});
it("does not call exit(0) if the error path returns", async () => {
messageCommandMock.mockRejectedValueOnce(new Error("boom"));
exitMock.mockClear().mockImplementation(() => undefined as never);
const runMessageAction = createRunMessageAction();
await expect(runMessageAction("send", baseSendOptions)).resolves.toBeUndefined();
expect(errorMock).toHaveBeenCalledWith("Error: boom");
expect(exitMock).toHaveBeenCalledOnce();
expect(exitMock).toHaveBeenCalledWith(1);
expect(exitMock).not.toHaveBeenCalledWith(0);
});
it("passes action and maps account to accountId", async () => {
const fakeCommand = { help: vi.fn() } as never;
const { runMessageAction } = createMessageCliHelpers(fakeCommand, "discord");
await expect(
runMessageAction("poll", {
channel: "discord",
target: "456",
account: "acct-1",
message: "hi",
}),
).rejects.toThrow("exit");
expect(messageCommandMock).toHaveBeenCalledWith(
expect.objectContaining({
action: "poll",
channel: "discord",
target: "456",
accountId: "acct-1",
message: "hi",
}),
expect.anything(),
expect.anything(),
);
// account key should be stripped in favor of accountId
expectNoAccountFieldInPassedOptions();
});
it("strips non-string account values instead of passing accountId", async () => {
const runMessageAction = createRunMessageAction();
await expect(
runMessageAction("send", {
channel: "discord",
target: "789",
account: 42,
message: "hi",
}),
).rejects.toThrow("exit");
expect(messageCommandMock).toHaveBeenCalledWith(
expect.objectContaining({
action: "send",
channel: "discord",
target: "789",
accountId: undefined,
}),
expect.anything(),
expect.anything(),
);
expectNoAccountFieldInPassedOptions();
});
});
|