File size: 8,353 Bytes
fc93158 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 | import { beforeEach, describe, expect, it } from "vitest";
import {
coerceFiniteScheduleNumber,
clearCronScheduleCacheForTest,
computeNextRunAtMs,
computePreviousRunAtMs,
getCronScheduleCacheSizeForTest,
} from "./schedule.js";
describe("cron schedule", () => {
beforeEach(() => {
clearCronScheduleCacheForTest();
});
it("computes next run for cron expression with timezone", () => {
// Saturday, Dec 13 2025 00:00:00Z
const nowMs = Date.parse("2025-12-13T00:00:00.000Z");
const next = computeNextRunAtMs(
{ kind: "cron", expr: "0 9 * * 3", tz: "America/Los_Angeles" },
nowMs,
);
// Next Wednesday at 09:00 PST -> 17:00Z
expect(next).toBe(Date.parse("2025-12-17T17:00:00.000Z"));
});
it("does not roll back year for Asia/Shanghai daily cron schedules (#30351)", () => {
// 2026-03-01 08:00:00 in Asia/Shanghai
const nowMs = Date.parse("2026-03-01T00:00:00.000Z");
const next = computeNextRunAtMs(
{ kind: "cron", expr: "0 8 * * *", tz: "Asia/Shanghai" },
nowMs,
);
// Next 08:00 local should be the following day, not a past year.
expect(next).toBe(Date.parse("2026-03-02T00:00:00.000Z"));
expect(next).toBeGreaterThan(nowMs);
expect(new Date(next ?? 0).getUTCFullYear()).toBe(2026);
});
it("throws a clear error when cron expr is missing at runtime", () => {
const nowMs = Date.parse("2025-12-13T00:00:00.000Z");
expect(() =>
computeNextRunAtMs(
{
kind: "cron",
} as unknown as { kind: "cron"; expr: string; tz?: string },
nowMs,
),
).toThrow("invalid cron schedule: expr is required");
});
it("supports legacy cron field when expr is missing", () => {
const nowMs = Date.parse("2025-12-13T00:00:00.000Z");
const next = computeNextRunAtMs(
{
kind: "cron",
cron: "0 9 * * 3",
tz: "America/Los_Angeles",
} as unknown as { kind: "cron"; expr: string; tz?: string },
nowMs,
);
expect(next).toBe(Date.parse("2025-12-17T17:00:00.000Z"));
});
it("computes next run for every schedule", () => {
const anchor = Date.parse("2025-12-13T00:00:00.000Z");
const now = anchor + 10_000;
const next = computeNextRunAtMs({ kind: "every", everyMs: 30_000, anchorMs: anchor }, now);
expect(next).toBe(anchor + 30_000);
});
it("computes next run for every schedule when anchorMs is not provided", () => {
const now = Date.parse("2025-12-13T00:00:00.000Z");
const next = computeNextRunAtMs({ kind: "every", everyMs: 30_000 }, now);
// Should return nowMs + everyMs, not nowMs (which would cause infinite loop)
expect(next).toBe(now + 30_000);
});
it("handles string-typed everyMs and anchorMs from legacy persisted data", () => {
const anchor = Date.parse("2025-12-13T00:00:00.000Z");
const now = anchor + 10_000;
const next = computeNextRunAtMs(
{
kind: "every",
everyMs: "30000" as unknown as number,
anchorMs: `${anchor}` as unknown as number,
},
now,
);
expect(next).toBe(anchor + 30_000);
});
it("returns undefined for non-numeric string everyMs", () => {
const now = Date.now();
const next = computeNextRunAtMs({ kind: "every", everyMs: "abc" as unknown as number }, now);
expect(next).toBeUndefined();
});
it("advances when now matches anchor for every schedule", () => {
const anchor = Date.parse("2025-12-13T00:00:00.000Z");
const next = computeNextRunAtMs({ kind: "every", everyMs: 30_000, anchorMs: anchor }, anchor);
expect(next).toBe(anchor + 30_000);
});
it("never returns a past timestamp for Asia/Shanghai daily schedule (#30351)", () => {
const nowMs = Date.parse("2026-03-01T00:00:00.000Z");
const next = computeNextRunAtMs(
{ kind: "cron", expr: "0 8 * * *", tz: "Asia/Shanghai" },
nowMs,
);
expect(next).toBeDefined();
expect(next!).toBeGreaterThan(nowMs);
});
it("never returns a previous run that is at-or-after now", () => {
const nowMs = Date.parse("2026-03-01T00:00:00.000Z");
const previous = computePreviousRunAtMs(
{ kind: "cron", expr: "0 8 * * *", tz: "Asia/Shanghai" },
nowMs,
);
if (previous !== undefined) {
expect(previous).toBeLessThan(nowMs);
}
});
it("reuses compiled cron evaluators for the same expression/timezone", () => {
const nowMs = Date.parse("2026-03-01T00:00:00.000Z");
expect(getCronScheduleCacheSizeForTest()).toBe(0);
const first = computeNextRunAtMs(
{ kind: "cron", expr: "0 8 * * *", tz: "Asia/Shanghai" },
nowMs,
);
const second = computeNextRunAtMs(
{ kind: "cron", expr: "0 8 * * *", tz: "Asia/Shanghai" },
nowMs + 1_000,
);
const third = computeNextRunAtMs({ kind: "cron", expr: "0 8 * * *", tz: "UTC" }, nowMs);
expect(first).toBeDefined();
expect(second).toBeDefined();
expect(third).toBeDefined();
expect(getCronScheduleCacheSizeForTest()).toBe(2);
});
describe("cron with specific seconds (6-field pattern)", () => {
// Pattern: fire at exactly second 0 of minute 0 of hour 12 every day
const dailyNoon = { kind: "cron" as const, expr: "0 0 12 * * *", tz: "UTC" };
const noonMs = Date.parse("2026-02-08T12:00:00.000Z");
it("advances past current second when nowMs is exactly at the match", () => {
// Fix #14164: must NOT return the current second — that caused infinite
// re-fires when multiple jobs triggered simultaneously.
const next = computeNextRunAtMs(dailyNoon, noonMs);
expect(next).toBe(noonMs + 86_400_000); // next day
});
it("advances past current second when nowMs is mid-second (.500) within the match", () => {
// Fix #14164: returning the current second caused rapid duplicate fires.
const next = computeNextRunAtMs(dailyNoon, noonMs + 500);
expect(next).toBe(noonMs + 86_400_000); // next day
});
it("advances past current second when nowMs is late in the matching second (.999)", () => {
const next = computeNextRunAtMs(dailyNoon, noonMs + 999);
expect(next).toBe(noonMs + 86_400_000); // next day
});
it("advances to next day once the matching second is fully past", () => {
const next = computeNextRunAtMs(dailyNoon, noonMs + 1000);
expect(next).toBe(noonMs + 86_400_000); // next day
});
it("returns today when nowMs is before the match", () => {
const next = computeNextRunAtMs(dailyNoon, noonMs - 500);
expect(next).toBe(noonMs);
});
it("advances to next day when job completes within same second it fired (#17821)", () => {
// Regression test for #17821: cron jobs that fire and complete within
// the same second (e.g., fire at 12:00:00.014, complete at 12:00:00.021)
// were getting nextRunAtMs set to the same second, causing a spin loop.
//
// Simulating: job scheduled for 12:00:00, fires at .014, completes at .021
const completedAtMs = noonMs + 21; // 12:00:00.021
const next = computeNextRunAtMs(dailyNoon, completedAtMs);
expect(next).toBe(noonMs + 86_400_000); // must be next day, NOT noonMs
});
it("advances to next day when job completes just before second boundary (#17821)", () => {
// Edge case: job completes at .999, still within the firing second
const completedAtMs = noonMs + 999; // 12:00:00.999
const next = computeNextRunAtMs(dailyNoon, completedAtMs);
expect(next).toBe(noonMs + 86_400_000); // next day
});
});
});
describe("coerceFiniteScheduleNumber", () => {
it("returns finite numbers directly", () => {
expect(coerceFiniteScheduleNumber(60_000)).toBe(60_000);
});
it("parses numeric strings", () => {
expect(coerceFiniteScheduleNumber("60000")).toBe(60_000);
expect(coerceFiniteScheduleNumber(" 60000 ")).toBe(60_000);
});
it("returns undefined for invalid inputs", () => {
expect(coerceFiniteScheduleNumber("")).toBeUndefined();
expect(coerceFiniteScheduleNumber("abc")).toBeUndefined();
expect(coerceFiniteScheduleNumber(NaN)).toBeUndefined();
expect(coerceFiniteScheduleNumber(Infinity)).toBeUndefined();
expect(coerceFiniteScheduleNumber(null)).toBeUndefined();
expect(coerceFiniteScheduleNumber(undefined)).toBeUndefined();
});
});
|