File size: 8,759 Bytes
fc93158 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 | import fs from "node:fs/promises";
import os from "node:os";
import path from "node:path";
import { CURRENT_SESSION_VERSION } from "@mariozechner/pi-coding-agent";
import { afterEach, describe, expect, it, vi } from "vitest";
import {
createActiveRun,
createChatAbortContext,
invokeChatAbortHandler,
} from "./chat.abort.test-helpers.js";
type TranscriptLine = {
message?: Record<string, unknown>;
};
const sessionEntryState = vi.hoisted(() => ({
transcriptPath: "",
sessionId: "",
}));
vi.mock("../session-utils.js", async (importOriginal) => {
const original = await importOriginal<typeof import("../session-utils.js")>();
return {
...original,
loadSessionEntry: () => ({
cfg: {},
storePath: path.join(path.dirname(sessionEntryState.transcriptPath), "sessions.json"),
entry: {
sessionId: sessionEntryState.sessionId,
sessionFile: sessionEntryState.transcriptPath,
},
canonicalKey: "main",
}),
};
});
const { chatHandlers } = await import("./chat.js");
async function writeTranscriptHeader(transcriptPath: string, sessionId: string) {
const header = {
type: "session",
version: CURRENT_SESSION_VERSION,
id: sessionId,
timestamp: new Date(0).toISOString(),
cwd: "/tmp",
};
await fs.writeFile(transcriptPath, `${JSON.stringify(header)}\n`, "utf-8");
}
async function readTranscriptLines(transcriptPath: string): Promise<TranscriptLine[]> {
const raw = await fs.readFile(transcriptPath, "utf-8");
return raw
.split(/\r?\n/)
.filter((line) => line.trim().length > 0)
.map((line) => {
try {
return JSON.parse(line) as TranscriptLine;
} catch {
return {};
}
});
}
function setMockSessionEntry(transcriptPath: string, sessionId: string) {
sessionEntryState.transcriptPath = transcriptPath;
sessionEntryState.sessionId = sessionId;
}
async function createTranscriptFixture(prefix: string) {
const dir = await fs.mkdtemp(path.join(os.tmpdir(), prefix));
const sessionId = "sess-main";
const transcriptPath = path.join(dir, `${sessionId}.jsonl`);
await writeTranscriptHeader(transcriptPath, sessionId);
setMockSessionEntry(transcriptPath, sessionId);
return { transcriptPath, sessionId };
}
afterEach(() => {
vi.restoreAllMocks();
});
describe("chat abort transcript persistence", () => {
it("persists run-scoped abort partial with rpc metadata and idempotency", async () => {
const { transcriptPath, sessionId } = await createTranscriptFixture("openclaw-chat-abort-run-");
const runId = "idem-abort-run-1";
const respond = vi.fn();
const context = createChatAbortContext({
chatAbortControllers: new Map([[runId, createActiveRun("main", { sessionId })]]),
chatRunBuffers: new Map([[runId, "Partial from run abort"]]),
chatDeltaSentAt: new Map([[runId, Date.now()]]),
removeChatRun: vi
.fn()
.mockReturnValue({ sessionKey: "main", clientRunId: "client-idem-abort-run-1" }),
agentRunSeq: new Map<string, number>([
[runId, 2],
["client-idem-abort-run-1", 3],
]),
broadcast: vi.fn(),
nodeSendToSession: vi.fn(),
logGateway: { warn: vi.fn() },
});
await invokeChatAbortHandler({
handler: chatHandlers["chat.abort"],
context,
request: { sessionKey: "main", runId },
respond,
});
const [ok1, payload1] = respond.mock.calls.at(-1) ?? [];
expect(ok1).toBe(true);
expect(payload1).toMatchObject({ aborted: true, runIds: [runId] });
context.chatAbortControllers.set(runId, createActiveRun("main", { sessionId }));
context.chatRunBuffers.set(runId, "Partial from run abort");
context.chatDeltaSentAt.set(runId, Date.now());
await invokeChatAbortHandler({
handler: chatHandlers["chat.abort"],
context,
request: { sessionKey: "main", runId },
respond,
});
const lines = await readTranscriptLines(transcriptPath);
const persisted = lines
.map((line) => line.message)
.filter(
(message): message is Record<string, unknown> =>
Boolean(message) && message?.idempotencyKey === `${runId}:assistant`,
);
expect(persisted).toHaveLength(1);
expect(persisted[0]).toMatchObject({
stopReason: "stop",
idempotencyKey: `${runId}:assistant`,
openclawAbort: {
aborted: true,
origin: "rpc",
runId,
},
});
});
it("persists session-scoped abort partials with rpc metadata", async () => {
const { transcriptPath, sessionId } = await createTranscriptFixture(
"openclaw-chat-abort-session-",
);
const respond = vi.fn();
const context = createChatAbortContext({
chatAbortControllers: new Map([
["run-a", createActiveRun("main", { sessionId })],
["run-b", createActiveRun("main", { sessionId })],
]),
chatRunBuffers: new Map([
["run-a", "Session abort partial"],
["run-b", " "],
]),
chatDeltaSentAt: new Map([
["run-a", Date.now()],
["run-b", Date.now()],
]),
});
await invokeChatAbortHandler({
handler: chatHandlers["chat.abort"],
context,
request: { sessionKey: "main" },
respond,
});
const [ok, payload] = respond.mock.calls.at(-1) ?? [];
expect(ok).toBe(true);
expect(payload).toMatchObject({ aborted: true });
expect(payload.runIds).toEqual(expect.arrayContaining(["run-a", "run-b"]));
const lines = await readTranscriptLines(transcriptPath);
const runAPersisted = lines
.map((line) => line.message)
.find((message) => message?.idempotencyKey === "run-a:assistant");
const runBPersisted = lines
.map((line) => line.message)
.find((message) => message?.idempotencyKey === "run-b:assistant");
expect(runAPersisted).toMatchObject({
idempotencyKey: "run-a:assistant",
openclawAbort: {
aborted: true,
origin: "rpc",
runId: "run-a",
},
});
expect(runBPersisted).toBeUndefined();
});
it("persists /stop partials with stop-command metadata", async () => {
const { transcriptPath, sessionId } = await createTranscriptFixture("openclaw-chat-stop-");
const respond = vi.fn();
const context = createChatAbortContext({
chatAbortControllers: new Map([["run-stop-1", createActiveRun("main", { sessionId })]]),
chatRunBuffers: new Map([["run-stop-1", "Partial from /stop"]]),
chatDeltaSentAt: new Map([["run-stop-1", Date.now()]]),
removeChatRun: vi.fn().mockReturnValue({ sessionKey: "main", clientRunId: "client-stop-1" }),
agentRunSeq: new Map<string, number>([["run-stop-1", 1]]),
dedupe: {
get: vi.fn(),
},
});
await chatHandlers["chat.send"]({
params: {
sessionKey: "main",
message: "/stop",
idempotencyKey: "idem-stop-req",
},
respond,
context: context as never,
req: {} as never,
client: null,
isWebchatConnect: () => false,
});
const [ok, payload] = respond.mock.calls.at(-1) ?? [];
expect(ok).toBe(true);
expect(payload).toMatchObject({ aborted: true, runIds: ["run-stop-1"] });
const lines = await readTranscriptLines(transcriptPath);
const persisted = lines
.map((line) => line.message)
.find((message) => message?.idempotencyKey === "run-stop-1:assistant");
expect(persisted).toMatchObject({
idempotencyKey: "run-stop-1:assistant",
openclawAbort: {
aborted: true,
origin: "stop-command",
runId: "run-stop-1",
},
});
});
it("skips run-scoped transcript persistence when partial text is blank", async () => {
const { transcriptPath, sessionId } = await createTranscriptFixture(
"openclaw-chat-abort-run-blank-",
);
const runId = "idem-abort-run-blank";
const respond = vi.fn();
const context = createChatAbortContext({
chatAbortControllers: new Map([[runId, createActiveRun("main", { sessionId })]]),
chatRunBuffers: new Map([[runId, " \n\t "]]),
chatDeltaSentAt: new Map([[runId, Date.now()]]),
});
await invokeChatAbortHandler({
handler: chatHandlers["chat.abort"],
context,
request: { sessionKey: "main", runId },
respond,
});
const [ok, payload] = respond.mock.calls.at(-1) ?? [];
expect(ok).toBe(true);
expect(payload).toMatchObject({ aborted: true, runIds: [runId] });
const lines = await readTranscriptLines(transcriptPath);
const persisted = lines
.map((line) => line.message)
.find((message) => message?.idempotencyKey === `${runId}:assistant`);
expect(persisted).toBeUndefined();
});
});
|