File size: 9,589 Bytes
fc93158 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 | import { describe, expect, it } from "vitest";
import type { OpenClawConfig } from "../config/config.js";
import {
buildIMessageInboundContext,
resolveIMessageInboundDecision,
} from "./monitor/inbound-processing.js";
import { parseIMessageNotification } from "./monitor/parse-notification.js";
import type { IMessagePayload } from "./monitor/types.js";
function baseCfg(): OpenClawConfig {
return {
channels: {
imessage: {
dmPolicy: "open",
allowFrom: ["*"],
groupPolicy: "open",
groups: { "*": { requireMention: true } },
},
},
session: { mainKey: "main" },
messages: {
groupChat: { mentionPatterns: ["@openclaw"] },
},
} as unknown as OpenClawConfig;
}
function resolve(params: {
cfg?: OpenClawConfig;
message: IMessagePayload;
storeAllowFrom?: string[];
}) {
const cfg = params.cfg ?? baseCfg();
const groupHistories = new Map();
return resolveIMessageInboundDecision({
cfg,
accountId: "default",
message: params.message,
opts: {},
messageText: (params.message.text ?? "").trim(),
bodyText: (params.message.text ?? "").trim(),
allowFrom: ["*"],
groupAllowFrom: [],
groupPolicy: cfg.channels?.imessage?.groupPolicy ?? "open",
dmPolicy: cfg.channels?.imessage?.dmPolicy ?? "pairing",
storeAllowFrom: params.storeAllowFrom ?? [],
historyLimit: 0,
groupHistories,
});
}
function resolveDispatchDecision(params: {
cfg: OpenClawConfig;
message: IMessagePayload;
groupHistories?: Parameters<typeof resolveIMessageInboundDecision>[0]["groupHistories"];
}) {
const groupHistories = params.groupHistories ?? new Map();
const decision = resolveIMessageInboundDecision({
cfg: params.cfg,
accountId: "default",
message: params.message,
opts: {},
messageText: params.message.text ?? "",
bodyText: params.message.text ?? "",
allowFrom: ["*"],
groupAllowFrom: [],
groupPolicy: "open",
dmPolicy: "open",
storeAllowFrom: [],
historyLimit: 0,
groupHistories,
});
expect(decision.kind).toBe("dispatch");
if (decision.kind !== "dispatch") {
throw new Error("expected dispatch decision");
}
return { decision, groupHistories };
}
function buildDispatchContextPayload(params: { cfg: OpenClawConfig; message: IMessagePayload }) {
const { cfg, message } = params;
const { decision, groupHistories } = resolveDispatchDecision({ cfg, message });
const { ctxPayload } = buildIMessageInboundContext({
cfg,
decision,
message,
historyLimit: 0,
groupHistories,
});
return ctxPayload;
}
describe("imessage monitor gating + envelope builders", () => {
it("parseIMessageNotification rejects malformed payloads", () => {
expect(
parseIMessageNotification({
message: { chat_id: 1, sender: { nested: "nope" } },
}),
).toBeNull();
});
it("drops group messages without mention by default", () => {
const decision = resolve({
message: {
id: 1,
chat_id: 99,
sender: "+15550001111",
is_from_me: false,
text: "hello group",
is_group: true,
},
});
expect(decision.kind).toBe("drop");
if (decision.kind !== "drop") {
throw new Error("expected drop decision");
}
expect(decision.reason).toBe("no mention");
});
it("dispatches group messages with mention and builds a group envelope", () => {
const cfg = baseCfg();
const message: IMessagePayload = {
id: 3,
chat_id: 42,
sender: "+15550002222",
is_from_me: false,
text: "@openclaw ping",
is_group: true,
chat_name: "Lobster Squad",
participants: ["+1555", "+1556"],
};
const ctxPayload = buildDispatchContextPayload({ cfg, message });
expect(ctxPayload.ChatType).toBe("group");
expect(ctxPayload.SessionKey).toBe("agent:main:imessage:group:42");
expect(String(ctxPayload.Body ?? "")).toContain("+15550002222:");
expect(String(ctxPayload.Body ?? "")).not.toContain("[from:");
expect(ctxPayload.To).toBe("chat_id:42");
});
it("includes reply-to context fields + suffix", () => {
const cfg = baseCfg();
const message: IMessagePayload = {
id: 5,
chat_id: 55,
sender: "+15550001111",
is_from_me: false,
text: "replying now",
is_group: false,
reply_to_id: 9001,
reply_to_text: "original message",
reply_to_sender: "+15559998888",
};
const ctxPayload = buildDispatchContextPayload({ cfg, message });
expect(ctxPayload.ReplyToId).toBe("9001");
expect(ctxPayload.ReplyToBody).toBe("original message");
expect(ctxPayload.ReplyToSender).toBe("+15559998888");
expect(String(ctxPayload.Body ?? "")).toContain("[Replying to +15559998888 id:9001]");
expect(String(ctxPayload.Body ?? "")).toContain("original message");
});
it("treats configured chat_id as a group session even when is_group is false", () => {
const cfg = baseCfg();
cfg.channels ??= {};
cfg.channels.imessage ??= {};
cfg.channels.imessage.groups = { "2": { requireMention: false } };
const groupHistories = new Map();
const message: IMessagePayload = {
id: 14,
chat_id: 2,
sender: "+15550001111",
is_from_me: false,
text: "hello",
is_group: false,
};
const { decision } = resolveDispatchDecision({ cfg, message, groupHistories });
expect(decision.isGroup).toBe(true);
expect(decision.route.sessionKey).toBe("agent:main:imessage:group:2");
});
it("allows group messages when requireMention is true but no mentionPatterns exist", () => {
const cfg = baseCfg();
cfg.messages ??= {};
cfg.messages.groupChat ??= {};
cfg.messages.groupChat.mentionPatterns = [];
const groupHistories = new Map();
const decision = resolveIMessageInboundDecision({
cfg,
accountId: "default",
message: {
id: 12,
chat_id: 777,
sender: "+15550001111",
is_from_me: false,
text: "hello group",
is_group: true,
},
opts: {},
messageText: "hello group",
bodyText: "hello group",
allowFrom: ["*"],
groupAllowFrom: [],
groupPolicy: "open",
dmPolicy: "open",
storeAllowFrom: [],
historyLimit: 0,
groupHistories,
});
expect(decision.kind).toBe("dispatch");
});
it("blocks group messages when imessage.groups is set without a wildcard", () => {
const cfg = baseCfg();
cfg.channels ??= {};
cfg.channels.imessage ??= {};
cfg.channels.imessage.groups = { "99": { requireMention: false } };
const groupHistories = new Map();
const decision = resolveIMessageInboundDecision({
cfg,
accountId: "default",
message: {
id: 13,
chat_id: 123,
sender: "+15550001111",
is_from_me: false,
text: "@openclaw hello",
is_group: true,
},
opts: {},
messageText: "@openclaw hello",
bodyText: "@openclaw hello",
allowFrom: ["*"],
groupAllowFrom: [],
groupPolicy: "open",
dmPolicy: "open",
storeAllowFrom: [],
historyLimit: 0,
groupHistories,
});
expect(decision.kind).toBe("drop");
});
it("honors group allowlist and ignores pairing-store senders in groups", () => {
const cfg = baseCfg();
cfg.channels ??= {};
cfg.channels.imessage ??= {};
cfg.channels.imessage.groupPolicy = "allowlist";
const groupHistories = new Map();
const denied = resolveIMessageInboundDecision({
cfg,
accountId: "default",
message: {
id: 3,
chat_id: 202,
sender: "+15550003333",
is_from_me: false,
text: "@openclaw hi",
is_group: true,
},
opts: {},
messageText: "@openclaw hi",
bodyText: "@openclaw hi",
allowFrom: ["*"],
groupAllowFrom: ["chat_id:101"],
groupPolicy: "allowlist",
dmPolicy: "pairing",
storeAllowFrom: ["+15550003333"],
historyLimit: 0,
groupHistories,
});
expect(denied.kind).toBe("drop");
const allowed = resolveIMessageInboundDecision({
cfg,
accountId: "default",
message: {
id: 33,
chat_id: 101,
sender: "+15550003333",
is_from_me: false,
text: "@openclaw ok",
is_group: true,
},
opts: {},
messageText: "@openclaw ok",
bodyText: "@openclaw ok",
allowFrom: ["*"],
groupAllowFrom: ["chat_id:101"],
groupPolicy: "allowlist",
dmPolicy: "pairing",
storeAllowFrom: ["+15550003333"],
historyLimit: 0,
groupHistories,
});
expect(allowed.kind).toBe("dispatch");
});
it("blocks group messages when groupPolicy is disabled", () => {
const cfg = baseCfg();
cfg.channels ??= {};
cfg.channels.imessage ??= {};
cfg.channels.imessage.groupPolicy = "disabled";
const groupHistories = new Map();
const decision = resolveIMessageInboundDecision({
cfg,
accountId: "default",
message: {
id: 10,
chat_id: 303,
sender: "+15550003333",
is_from_me: false,
text: "@openclaw hi",
is_group: true,
},
opts: {},
messageText: "@openclaw hi",
bodyText: "@openclaw hi",
allowFrom: ["*"],
groupAllowFrom: [],
groupPolicy: "disabled",
dmPolicy: "open",
storeAllowFrom: [],
historyLimit: 0,
groupHistories,
});
expect(decision.kind).toBe("drop");
});
});
|