File size: 6,051 Bytes
fc93158 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 | /**
* Layer 1: Hook Merger Tests for before_agent_start
*
* Validates that modelOverride and providerOverride fields are correctly
* propagated through the hook merger, including priority ordering and
* backward compatibility.
*/
import { beforeEach, describe, expect, it } from "vitest";
import { createHookRunner } from "./hooks.js";
import { addTestHook, TEST_PLUGIN_AGENT_CTX } from "./hooks.test-helpers.js";
import { createEmptyPluginRegistry, type PluginRegistry } from "./registry.js";
import type { PluginHookBeforeAgentStartResult, PluginHookRegistration } from "./types.js";
function addBeforeAgentStartHook(
registry: PluginRegistry,
pluginId: string,
handler: () => PluginHookBeforeAgentStartResult | Promise<PluginHookBeforeAgentStartResult>,
priority?: number,
) {
addTestHook({
registry,
pluginId,
hookName: "before_agent_start",
handler: handler as PluginHookRegistration["handler"],
priority,
});
}
const stubCtx = TEST_PLUGIN_AGENT_CTX;
describe("before_agent_start hook merger", () => {
let registry: PluginRegistry;
beforeEach(() => {
registry = createEmptyPluginRegistry();
});
const runWithSingleHook = async (result: PluginHookBeforeAgentStartResult, priority?: number) => {
addBeforeAgentStartHook(registry, "plugin-a", () => result, priority);
const runner = createHookRunner(registry);
return await runner.runBeforeAgentStart({ prompt: "hello" }, stubCtx);
};
const expectSingleModelOverride = async (modelOverride: string) => {
const result = await runWithSingleHook({ modelOverride });
expect(result?.modelOverride).toBe(modelOverride);
return result;
};
it("returns modelOverride from a single plugin", async () => {
await expectSingleModelOverride("llama3.3:8b");
});
it("returns providerOverride from a single plugin", async () => {
const result = await runWithSingleHook({
providerOverride: "ollama",
});
expect(result?.providerOverride).toBe("ollama");
});
it("returns both modelOverride and providerOverride together", async () => {
addBeforeAgentStartHook(registry, "plugin-a", () => ({
modelOverride: "llama3.3:8b",
providerOverride: "ollama",
}));
const runner = createHookRunner(registry);
const result = await runner.runBeforeAgentStart({ prompt: "hello" }, stubCtx);
expect(result?.modelOverride).toBe("llama3.3:8b");
expect(result?.providerOverride).toBe("ollama");
});
it("higher-priority plugin wins for modelOverride", async () => {
addBeforeAgentStartHook(registry, "low-priority", () => ({ modelOverride: "gpt-4o" }), 1);
addBeforeAgentStartHook(
registry,
"high-priority",
() => ({ modelOverride: "llama3.3:8b" }),
10,
);
const runner = createHookRunner(registry);
const result = await runner.runBeforeAgentStart({ prompt: "PII prompt" }, stubCtx);
expect(result?.modelOverride).toBe("llama3.3:8b");
});
it("lower-priority plugin does not overwrite if it returns undefined", async () => {
addBeforeAgentStartHook(
registry,
"high-priority",
() => ({ modelOverride: "llama3.3:8b", providerOverride: "ollama" }),
10,
);
addBeforeAgentStartHook(
registry,
"low-priority",
() => ({ prependContext: "some context" }),
1,
);
const runner = createHookRunner(registry);
const result = await runner.runBeforeAgentStart({ prompt: "hello" }, stubCtx);
// High-priority ran first (priority 10), low-priority ran second (priority 1).
// Low-priority didn't return modelOverride, so ?? falls back to acc's value.
expect(result?.modelOverride).toBe("llama3.3:8b");
expect(result?.providerOverride).toBe("ollama");
expect(result?.prependContext).toBe("some context");
});
it("prependContext still concatenates when modelOverride is present", async () => {
addBeforeAgentStartHook(
registry,
"plugin-a",
() => ({
prependContext: "context A",
modelOverride: "llama3.3:8b",
}),
10,
);
addBeforeAgentStartHook(
registry,
"plugin-b",
() => ({
prependContext: "context B",
}),
1,
);
const runner = createHookRunner(registry);
const result = await runner.runBeforeAgentStart({ prompt: "hello" }, stubCtx);
expect(result?.prependContext).toBe("context A\n\ncontext B");
expect(result?.modelOverride).toBe("llama3.3:8b");
});
it("backward compat: plugin returning only prependContext produces no modelOverride", async () => {
addBeforeAgentStartHook(registry, "legacy-plugin", () => ({
prependContext: "legacy context",
}));
const runner = createHookRunner(registry);
const result = await runner.runBeforeAgentStart({ prompt: "hello" }, stubCtx);
expect(result?.prependContext).toBe("legacy context");
expect(result?.modelOverride).toBeUndefined();
expect(result?.providerOverride).toBeUndefined();
});
it("modelOverride without providerOverride leaves provider undefined", async () => {
const result = await expectSingleModelOverride("llama3.3:8b");
expect(result?.providerOverride).toBeUndefined();
});
it("returns undefined when no hooks are registered", async () => {
const runner = createHookRunner(registry);
const result = await runner.runBeforeAgentStart({ prompt: "hello" }, stubCtx);
expect(result).toBeUndefined();
});
it("systemPrompt merges correctly alongside model overrides", async () => {
addBeforeAgentStartHook(registry, "plugin-a", () => ({
systemPrompt: "You are a helpful assistant",
modelOverride: "llama3.3:8b",
providerOverride: "ollama",
}));
const runner = createHookRunner(registry);
const result = await runner.runBeforeAgentStart({ prompt: "hello" }, stubCtx);
expect(result?.systemPrompt).toBe("You are a helpful assistant");
expect(result?.modelOverride).toBe("llama3.3:8b");
expect(result?.providerOverride).toBe("ollama");
});
});
|