File size: 5,594 Bytes
fc93158 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 | import type { WebClient } from "@slack/web-api";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import { installSlackBlockTestMocks } from "./blocks.test-helpers.js";
// --- Module mocks (must precede dynamic import) ---
installSlackBlockTestMocks();
const fetchWithSsrFGuard = vi.fn(
async (params: { url: string; init?: RequestInit }) =>
({
response: await fetch(params.url, params.init),
finalUrl: params.url,
release: async () => {},
}) as const,
);
vi.mock("../infra/net/fetch-guard.js", () => ({
fetchWithSsrFGuard: (...args: unknown[]) =>
fetchWithSsrFGuard(...(args as [params: { url: string; init?: RequestInit }])),
withTrustedEnvProxyGuardedFetchMode: (params: Record<string, unknown>) => ({
...params,
mode: "trusted_env_proxy",
}),
}));
vi.mock("../web/media.js", () => ({
loadWebMedia: vi.fn(async () => ({
buffer: Buffer.from("fake-image"),
contentType: "image/png",
kind: "image",
fileName: "screenshot.png",
})),
}));
const { sendMessageSlack } = await import("./send.js");
type UploadTestClient = WebClient & {
conversations: { open: ReturnType<typeof vi.fn> };
chat: { postMessage: ReturnType<typeof vi.fn> };
files: {
getUploadURLExternal: ReturnType<typeof vi.fn>;
completeUploadExternal: ReturnType<typeof vi.fn>;
};
};
function createUploadTestClient(): UploadTestClient {
return {
conversations: {
open: vi.fn(async () => ({ channel: { id: "D99RESOLVED" } })),
},
chat: {
postMessage: vi.fn(async () => ({ ts: "171234.567" })),
},
files: {
getUploadURLExternal: vi.fn(async () => ({
ok: true,
upload_url: "https://uploads.slack.test/upload",
file_id: "F001",
})),
completeUploadExternal: vi.fn(async () => ({ ok: true })),
},
} as unknown as UploadTestClient;
}
describe("sendMessageSlack file upload with user IDs", () => {
const originalFetch = globalThis.fetch;
beforeEach(() => {
globalThis.fetch = vi.fn(
async () => new Response("ok", { status: 200 }),
) as unknown as typeof fetch;
fetchWithSsrFGuard.mockClear();
});
afterEach(() => {
globalThis.fetch = originalFetch;
vi.restoreAllMocks();
});
it("resolves bare user ID to DM channel before completing upload", async () => {
const client = createUploadTestClient();
// Bare user ID — parseSlackTarget classifies this as kind="channel"
await sendMessageSlack("U2ZH3MFSR", "screenshot", {
token: "xoxb-test",
client,
mediaUrl: "/tmp/screenshot.png",
});
// Should call conversations.open to resolve user ID → DM channel
expect(client.conversations.open).toHaveBeenCalledWith({
users: "U2ZH3MFSR",
});
expect(client.files.completeUploadExternal).toHaveBeenCalledWith(
expect.objectContaining({
channel_id: "D99RESOLVED",
files: [expect.objectContaining({ id: "F001", title: "screenshot.png" })],
}),
);
});
it("resolves prefixed user ID to DM channel before completing upload", async () => {
const client = createUploadTestClient();
await sendMessageSlack("user:UABC123", "image", {
token: "xoxb-test",
client,
mediaUrl: "/tmp/photo.png",
});
expect(client.conversations.open).toHaveBeenCalledWith({
users: "UABC123",
});
expect(client.files.completeUploadExternal).toHaveBeenCalledWith(
expect.objectContaining({ channel_id: "D99RESOLVED" }),
);
});
it("sends file directly to channel without conversations.open", async () => {
const client = createUploadTestClient();
await sendMessageSlack("channel:C123CHAN", "chart", {
token: "xoxb-test",
client,
mediaUrl: "/tmp/chart.png",
});
expect(client.conversations.open).not.toHaveBeenCalled();
expect(client.files.completeUploadExternal).toHaveBeenCalledWith(
expect.objectContaining({ channel_id: "C123CHAN" }),
);
});
it("resolves mention-style user ID before file upload", async () => {
const client = createUploadTestClient();
await sendMessageSlack("<@U777TEST>", "report", {
token: "xoxb-test",
client,
mediaUrl: "/tmp/report.png",
});
expect(client.conversations.open).toHaveBeenCalledWith({
users: "U777TEST",
});
expect(client.files.completeUploadExternal).toHaveBeenCalledWith(
expect.objectContaining({ channel_id: "D99RESOLVED" }),
);
});
it("uploads bytes to the presigned URL and completes with thread+caption", async () => {
const client = createUploadTestClient();
await sendMessageSlack("channel:C123CHAN", "caption", {
token: "xoxb-test",
client,
mediaUrl: "/tmp/threaded.png",
threadTs: "171.222",
});
expect(client.files.getUploadURLExternal).toHaveBeenCalledWith({
filename: "screenshot.png",
length: Buffer.from("fake-image").length,
});
expect(globalThis.fetch).toHaveBeenCalledWith(
"https://uploads.slack.test/upload",
expect.objectContaining({
method: "POST",
}),
);
expect(fetchWithSsrFGuard).toHaveBeenCalledWith(
expect.objectContaining({
url: "https://uploads.slack.test/upload",
mode: "trusted_env_proxy",
auditContext: "slack-upload-file",
}),
);
expect(client.files.completeUploadExternal).toHaveBeenCalledWith(
expect.objectContaining({
channel_id: "C123CHAN",
initial_comment: "caption",
thread_ts: "171.222",
}),
);
});
});
|