additional tests

pytube/captions.py

@@ -114,13 +114,13 @@ class Caption:
         else:
             filename = title
 
-        filename = safe_filename(filename)
-
         if filename_prefix:
             filename = "{prefix}{filename}".format(
                 prefix=safe_filename(filename_prefix), filename=filename,
             )
 
+        filename = safe_filename(filename)
+
         filename += " ({})".format(self.code)
 
         if srt:

tests/test_captions.py

@@ -56,6 +56,18 @@ def test_download(srt):
         assert m.call_args_list[0][0][0].split("/")[-1] == "title (en).srt"
 
 
+@mock.patch("pytube.captions.Caption.generate_srt_captions")
+def test_download_with_prefix(srt):
+    m = mock_open()
+    with patch("builtins.open", m):
+        srt.return_value = ""
+        caption = Caption(
+            {"url": "url1", "name": {"simpleText": "name1"}, "languageCode": "en"}
+        )
+        caption.download("title", filename_prefix="1 ")
+        assert m.call_args_list[0][0][0].split("/")[-1] == "1 title (en).srt"
+
+
 @mock.patch("pytube.captions.Caption.xml_captions")
 def test_download_xml_and_trim_extension(xml):
     m = mock_open()
@@ -66,3 +78,10 @@ def test_download_xml_and_trim_extension(xml):
         )
         caption.download("title.xml", srt=False)
         assert m.call_args_list[0][0][0].split("/")[-1] == "title (en).xml"
+
+
+def test_repr():
+    caption = Caption(
+        {"url": "url1", "name": {"simpleText": "name1"}, "languageCode": "en"}
+    )
+    assert str(caption) == '<Caption lang="name1" code="en">'

tests/test_cli.py

@@ -79,3 +79,12 @@ def test_download_caption_with_language_not_found(youtube):
     ) as wrapped_all:
         cli.download_caption(youtube, "blah")
         wrapped_all.assert_called()
+
+
+@mock.patch("pytube.Stream")
+@mock.patch("io.BufferedWriter")
+def test_on_progress(stream, writer):
+    stream.filesize = 10
+    cli.display_progress_bar = MagicMock()
+    cli.on_progress(stream, "", writer, 7)
+    cli.display_progress_bar.assert_called_once_with(3, 10)