added test_get_highest_resolution

pytube/query.py

@@ -282,12 +282,7 @@ class StreamQuery:
             not found.
 
         """
-        return (
-            self.filter(progressive=True)
-            .order_by("resolution")
-            .asc()
-            .last()
-        )
+        return self.filter(progressive=True).order_by("resolution").asc().last()
 
     def first(self) -> Optional[Stream]:
         """Get the first :class:`Stream <Stream>` in the results.

tests/test_helpers.py

@@ -1,8 +1,11 @@
 # -*- coding: utf-8 -*-
+from unittest import mock
+
 import pytest
 
 from pytube import helpers
 from pytube.exceptions import RegexMatchError
+from pytube.helpers import deprecated
 
 
 def test_regex_search_no_match():
@@ -18,3 +21,16 @@ def test_safe_filename():
     """Unsafe characters get stripped from generated filename"""
     assert helpers.safe_filename("abc1245$$") == "abc1245"
     assert helpers.safe_filename("abc##") == "abc"
+
+
+@mock.patch("warnings.warn")
+def test_deprecated(warn):
+    @deprecated("oh no")
+    def deprecated_function():
+        return None
+    deprecated_function()
+    warn.assert_called_with(
+        "Call to deprecated function deprecated_function (oh no).",
+        category=DeprecationWarning,
+        stacklevel=2,
+    )

tests/test_query.py

@@ -132,7 +132,6 @@ def test_get_by_itag(cipher_signature):
     :class:`Stream <Stream>`.
     """
     assert cipher_signature.streams.get_by_itag(18).itag == 18
-    assert cipher_signature.streams.get_by_itag("18").itag == 18
 
 
 def test_get_by_non_existent_itag(cipher_signature):
@@ -147,6 +146,10 @@ def test_get_lowest_resolution(cipher_signature):
     assert cipher_signature.streams.get_lowest_resolution().itag == 18
 
 
+def test_get_highest_resolution(cipher_signature):
+    assert cipher_signature.streams.get_highest_resolution().itag == 18
+
+
 def test_filter_is_dash(cipher_signature):
     streams = cipher_signature.streams.filter(is_dash=False).all()
     itags = [s.itag for s in streams]