test for RegexMatchError

pytube/cipher.py

@@ -34,7 +34,7 @@ def get_initial_function_name(js: str) -> str:
        Function name from regex match
     """
 
-    pattern = [
+    function_patterns = [
         r"\b[cs]\s*&&\s*[adf]\.set\([^,]+\s*,\s*encodeURIComponent\s*\(\s*(?P<sig>[a-zA-Z0-9$]+)\(",  # noqa: E501
         r"\b[a-zA-Z0-9]+\s*&&\s*[a-zA-Z0-9]+\.set\([^,]+\s*,\s*encodeURIComponent\s*\(\s*(?P<sig>[a-zA-Z0-9$]+)\(",  # noqa: E501
         r'(?P<sig>[a-zA-Z0-9$]+)\s*=\s*function\(\s*a\s*\)\s*{\s*a\s*=\s*a\.split\(\s*""\s*\)',  # noqa: E501
@@ -49,8 +49,8 @@ def get_initial_function_name(js: str) -> str:
     ]
 
     logger.debug("finding initial function name")
-    for p in pattern:
-        regex = re.compile(p)
+    for pattern in function_patterns:
+        regex = re.compile(pattern)
         results = regex.search(js)
         if results:
             logger.debug("finished regex search, matched: {pattern}".format(pattern=p))

pytube/exceptions.py

@@ -1,6 +1,5 @@
 # -*- coding: utf-8 -*-
 """Library specific exception definitions."""
-import sys
 from typing import Union, Pattern
 
 
@@ -27,7 +26,7 @@ class RegexMatchError(ExtractError):
         :param str pattern:
             Pattern that failed to match
         """
-        super(ExtractError, self).__init__(
+        super().__init__(
             "{caller}: could not find match for {pattern}".format(
                 caller=caller, pattern=pattern
             )
@@ -48,11 +47,8 @@ class VideoUnavailable(PytubeError):
         :param str video_id:
             A YouTube video identifier.
         """
-        super(PytubeError, self).__init__(
-            "{video_id} is unavailable".format(video_id=video_id)
-        )
+        super().__init__("{video_id} is unavailable".format(video_id=video_id))
 
-        self.exc_info = sys.exc_info()
         self.video_id = video_id
 
 

tests/test_exceptions.py

@@ -1,9 +1,17 @@
 # -*- coding: utf-8 -*-
-from pytube.exceptions import VideoUnavailable
+from pytube.exceptions import VideoUnavailable, RegexMatchError
 
 
-def test_is_expected():
+def test_video_unavailable():
     try:
         raise VideoUnavailable(video_id="YLnZklYFe7E")
     except VideoUnavailable as e:
         assert e.video_id == "YLnZklYFe7E"
+        assert str(e) == "YLnZklYFe7E is unavailable"
+
+
+def test_regex_match_error():
+    try:
+        raise RegexMatchError(caller="hello", pattern="*")
+    except RegexMatchError as e:
+        assert str(e) == "hello: could not find match for *"

tests/test_extract.py

@@ -80,4 +80,4 @@ def test_mime_type_codec():
 
 def test_mime_type_codec_with_no_match_should_error():
     with pytest.raises(RegexMatchError):
-        mime_type, mime_subtype = extract.mime_type_codec("audio/webm")
+        extract.mime_type_codec("audio/webm")