added tests

pytube/cipher.py

@@ -16,7 +16,7 @@ signature and decoding it.
 
 import re
 from itertools import chain
-from typing import List
+from typing import List, Tuple
 
 from pytube.exceptions import RegexMatchError
 from pytube.helpers import regex_search, create_logger
@@ -227,7 +227,7 @@ def map_functions(js_func):
     )
 
 
-def parse_function(js_func: str):
+def parse_function(js_func: str) -> Tuple[str, int]:
     """Parse the Javascript transform function.
 
     Break a JavaScript transform function down into a two element ``tuple``
@@ -253,7 +253,8 @@ def parse_function(js_func: str):
         raise RegexMatchError(
             "regex pattern ({pattern}) had zero matches".format(pattern=pattern),
         )
-    return results.groups()
+    fn_name, fn_arg = results.groups()
+    return fn_name, int(fn_arg)
 
 
 def get_signature(js: str, ciphered_signature: str) -> str:
@@ -278,7 +279,7 @@ def get_signature(js: str, ciphered_signature: str) -> str:
 
     for js_func in transform_plan:
         name, argument = parse_function(js_func)
-        signature = transform_map[name](signature, int(argument))
+        signature = transform_map[name](signature, argument)
         logger.debug("applied transform function\n")
         # pprint.pformat(
         #     {

tests/test_cipher.py

@@ -8,3 +8,29 @@ from pytube.exceptions import RegexMatchError
 def test_map_functions():
     with pytest.raises(RegexMatchError):
         cipher.map_functions("asdf")
+
+
+def test_get_initial_function_name_with_no_match_should_error():
+    with pytest.raises(RegexMatchError):
+        cipher.get_initial_function_name("asdf")
+
+
+def test_get_transform_object_with_no_match_should_error():
+    with pytest.raises(RegexMatchError):
+        cipher.get_transform_object("asdf", var="lt")
+
+
+def test_parse_function_with_match():
+    fn_name, fn_arg = cipher.parse_function("DE.AJ(a,15)")
+    assert fn_name == "AJ"
+    assert fn_arg == 15
+
+
+def test_parse_function_with_no_match_should_error():
+    with pytest.raises(RegexMatchError):
+        cipher.parse_function("asdf")
+
+
+def test_reverse():
+    reversed_array = cipher.reverse([1, 2, 3, 4], None)
+    assert reversed_array == [4, 3, 2, 1]

tests/test_extract.py

@@ -1,5 +1,9 @@
 # -*- coding: utf-8 -*-
 """Unit tests for the :module:`extract <extract>` module."""
+import pytest
+
+from pytube.exceptions import RegexMatchError
+
 from pytube import extract
 
 
@@ -61,3 +65,19 @@ def test_get_vid_desc(cipher_signature):
         "http://weibo.com/psyoppa"
     )
     assert extract.get_vid_descr(cipher_signature.watch_html) == expected
+
+
+def test_eurl():
+    url = extract.eurl("videoid")
+    assert url == "https://youtube.googleapis.com/v/videoid"
+
+
+def test_mime_type_codec():
+    mime_type, mime_subtype = extract.mime_type_codec('audio/webm; codecs="opus"')
+    assert mime_type == "audio/webm"
+    assert mime_subtype == ["opus"]
+
+
+def test_mime_type_codec_with_no_match_should_error():
+    with pytest.raises(RegexMatchError):
+        mime_type, mime_subtype = extract.mime_type_codec("audio/webm")