FoolDev commited on
Commit
b5a3fb0
·
1 Parent(s): 0ee8836

Makefile: propagate TAG override to build.sh

Browse files

The build target declares TAG ?= janus-27b at the top of the file
(and the help block lists it among 'variables you can override on
the command line') but the recipe never actually passed it through:

build:
GGUF_PATH=$(GGUF_PATH) ./scripts/build.sh $(QUANT)

So make build TAG=janus-27b-q3 silently produced janus-27b:latest.
Combined with the matching scripts/build.sh change in the previous
commit, the override now works end-to-end via either entry point.

Verified: TAG=janus-27b-test make build QUANT=Q3_K_S correctly
created janus-27b-test:latest.

Files changed (2) hide show
  1. CHANGELOG.md +7 -0
  2. Makefile +1 -1
CHANGELOG.md CHANGED
@@ -8,6 +8,13 @@ and documentation**, not the underlying base model.
8
  ## [Unreleased]
9
 
10
  ### Fixed
 
 
 
 
 
 
 
11
  - `scripts/build.sh`: accept `TAG` as an env override (was hardcoded
12
  to `janus-27b`, silently ignoring callers that wanted a different
13
  Ollama tag — e.g. `TAG=janus-27b-q3 ./scripts/build.sh Q3_K_S`
 
8
  ## [Unreleased]
9
 
10
  ### Fixed
11
+ - `Makefile`: propagate `TAG` to `scripts/build.sh`. The build target
12
+ declares `TAG ?= janus-27b` at the top of the file (and lists it in
13
+ the help block) but didn't actually pass it through, so
14
+ `make build TAG=janus-27b-q3 QUANT=Q3_K_S` produced `janus-27b:latest`
15
+ instead of `janus-27b-q3:latest`. Combined with the matching
16
+ `scripts/build.sh` change in the previous commit, the override now
17
+ works end-to-end via either entry point.
18
  - `scripts/build.sh`: accept `TAG` as an env override (was hardcoded
19
  to `janus-27b`, silently ignoring callers that wanted a different
20
  Ollama tag — e.g. `TAG=janus-27b-q3 ./scripts/build.sh Q3_K_S`
Makefile CHANGED
@@ -37,7 +37,7 @@ ifdef GGUF_PATH
37
  endif
38
 
39
  build: ## Download GGUF (if needed) and run 'ollama create'.
40
- GGUF_PATH=$(GGUF_PATH) ./scripts/build.sh $(QUANT)
41
 
42
  smoke: ## Verify the model is reachable and round-trips.
43
  MODEL=$(MODEL) ./scripts/smoke_test.sh
 
37
  endif
38
 
39
  build: ## Download GGUF (if needed) and run 'ollama create'.
40
+ GGUF_PATH=$(GGUF_PATH) TAG=$(TAG) ./scripts/build.sh $(QUANT)
41
 
42
  smoke: ## Verify the model is reachable and round-trips.
43
  MODEL=$(MODEL) ./scripts/smoke_test.sh