Sitar118 Claude Sonnet 4.6 commited on
Commit Β·
29b4c18
1
Parent(s): 19d5f13
docs: Sprint 7 task + update paths after folder move to AI MUSIC PRODUCTION
Browse files- SYNC.md: clean rewrite β Sprint 7 task in correct section (CLAUDE CODE β ML INTERN),
removed stale Sprint 5/6 archive content, version stays v0.6.0
- SPRINT-LOG.md: added Sprint 7 entry
- MACHINE-CONTEXT.md: updated build dir path + full cmake/build commands
- CLAUDE.md: updated source path + version to v0.6.0
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- CLAUDE.md +1 -1
- MACHINE-CONTEXT.md +15 -3
- SPRINT-LOG.md +7 -0
- SYNC.md +176 -293
CLAUDE.md
CHANGED
|
@@ -123,7 +123,7 @@ pluginbridge/
|
|
| 123 |
## Build
|
| 124 |
|
| 125 |
```bash
|
| 126 |
-
cd "/Volumes/T7 Shield/Users/Aditya/pluginbridge/build"
|
| 127 |
cmake --build . --target PluginBridge_VST3 -- -j4
|
| 128 |
# Auto-installs to ~/Library/Audio/Plug-Ins/VST3/PluginBridge.vst3
|
| 129 |
```
|
|
|
|
| 123 |
## Build
|
| 124 |
|
| 125 |
```bash
|
| 126 |
+
cd "/Volumes/T7 Shield/Users/Aditya/Downloads/AI MUSIC PRODUCTION/pluginbridge/build"
|
| 127 |
cmake --build . --target PluginBridge_VST3 -- -j4
|
| 128 |
# Auto-installs to ~/Library/Audio/Plug-Ins/VST3/PluginBridge.vst3
|
| 129 |
```
|
MACHINE-CONTEXT.md
CHANGED
|
@@ -29,7 +29,7 @@
|
|
| 29 |
| System AU plugins | `/Library/Audio/Plug-Ins/Components/` |
|
| 30 |
| PluginBridge install | `~/Library/Audio/Plug-Ins/VST3/PluginBridge.vst3` |
|
| 31 |
| PluginBridge data | `~/Library/PluginBridge/` (safety_db.json, debug.log, blocklist.txt, scan.log) |
|
| 32 |
-
| Build dir | `/Volumes/T7 Shield/Users/Aditya/pluginbridge/build/` |
|
| 33 |
| Ableton log | `~/Library/Preferences/Ableton/Live 12.4/Log.txt` |
|
| 34 |
| Crash reports | `~/Library/Logs/DiagnosticReports/` |
|
| 35 |
|
|
@@ -40,9 +40,21 @@ Both `/Library/` and `~/Library/` must be checked to find all installed plugins
|
|
| 40 |
|
| 41 |
## CURRENT BUILD STATE (Last updated: 2026-05-17)
|
| 42 |
|
| 43 |
-
**Last build:** 2026-05-17
|
| 44 |
**Result:** β
Clean β `[100%] Built target PluginBridge_VST3`
|
| 45 |
-
**Build command:**
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 46 |
|
| 47 |
---
|
| 48 |
|
|
|
|
| 29 |
| System AU plugins | `/Library/Audio/Plug-Ins/Components/` |
|
| 30 |
| PluginBridge install | `~/Library/Audio/Plug-Ins/VST3/PluginBridge.vst3` |
|
| 31 |
| PluginBridge data | `~/Library/PluginBridge/` (safety_db.json, debug.log, blocklist.txt, scan.log) |
|
| 32 |
+
| Build dir | `/Volumes/T7 Shield/Users/Aditya/Downloads/AI MUSIC PRODUCTION/pluginbridge/build/` |
|
| 33 |
| Ableton log | `~/Library/Preferences/Ableton/Live 12.4/Log.txt` |
|
| 34 |
| Crash reports | `~/Library/Logs/DiagnosticReports/` |
|
| 35 |
|
|
|
|
| 40 |
|
| 41 |
## CURRENT BUILD STATE (Last updated: 2026-05-17)
|
| 42 |
|
| 43 |
+
**Last build:** 2026-05-17 (after folder move to AI MUSIC PRODUCTION)
|
| 44 |
**Result:** β
Clean β `[100%] Built target PluginBridge_VST3`
|
| 45 |
+
**Build command:**
|
| 46 |
+
```bash
|
| 47 |
+
cd "/Volumes/T7 Shield/Users/Aditya/Downloads/AI MUSIC PRODUCTION/pluginbridge/build"
|
| 48 |
+
cmake --build . --target PluginBridge_VST3 -- -j4
|
| 49 |
+
```
|
| 50 |
+
**Re-cmake needed after fresh clone:**
|
| 51 |
+
```bash
|
| 52 |
+
cd "/Volumes/T7 Shield/Users/Aditya/Downloads/AI MUSIC PRODUCTION/pluginbridge/build"
|
| 53 |
+
/opt/homebrew/lib/python3.14/site-packages/cmake/data/bin/cmake .. -G 'Unix Makefiles' \
|
| 54 |
+
-DCMAKE_C_COMPILER=/Library/Developer/CommandLineTools/usr/bin/clang \
|
| 55 |
+
-DCMAKE_CXX_COMPILER=/Library/Developer/CommandLineTools/usr/bin/clang++ \
|
| 56 |
+
-DCMAKE_OSX_SYSROOT=/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk
|
| 57 |
+
```
|
| 58 |
|
| 59 |
---
|
| 60 |
|
SPRINT-LOG.md
CHANGED
|
@@ -16,6 +16,13 @@ Full in-process hosting with safety scan. Ableton-style TreeView picker.
|
|
| 16 |
Fixes: deduplication, manufacturer names, background scan conflict, addChildComponent bug.
|
| 17 |
MCP verified end-to-end. Pro-Q 4 = 737 params via MCP.
|
| 18 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 19 |
## Sprint 6 β
(v0.6.0 β Multi-Instance + Channel Selector)
|
| 20 |
Channel name dropdown in Editor (30 items: Vocals/Drums/Bass/Keys/Synths/Strings/FX/Buses/Custom).
|
| 21 |
Auto-port via bind_to_any_port β each instance gets its own port.
|
|
|
|
| 16 |
Fixes: deduplication, manufacturer names, background scan conflict, addChildComponent bug.
|
| 17 |
MCP verified end-to-end. Pro-Q 4 = 737 params via MCP.
|
| 18 |
|
| 19 |
+
## Sprint 7 π (v0.7.0 β In-Process Param Routing)
|
| 20 |
+
Route MCP set_params/get_params/search_param through inProcessPlugin for SAFE plugins.
|
| 21 |
+
Root cause: after Sprint 5, audio+GUI use in-process instance but MCP still targets Helper's
|
| 22 |
+
hidden instance β EQ changes invisible in Pro-Q 4.
|
| 23 |
+
Fix: three param callbacks on McpServer (same pattern as getAnalysisCallback).
|
| 24 |
+
Also fixes id-vs-index bug: search_param now returns "i" (array index) not VST3 param ID.
|
| 25 |
+
|
| 26 |
## Sprint 6 β
(v0.6.0 β Multi-Instance + Channel Selector)
|
| 27 |
Channel name dropdown in Editor (30 items: Vocals/Drums/Bass/Keys/Synths/Strings/FX/Buses/Custom).
|
| 28 |
Auto-port via bind_to_any_port β each instance gets its own port.
|
SYNC.md
CHANGED
|
@@ -6,9 +6,10 @@
|
|
| 6 |
|
| 7 |
**Version:** v0.6.0
|
| 8 |
**Build:** β
Clean (2026-05-17)
|
| 9 |
-
**GUI:** β
TreeView picker + in-process createEditor() + live spectrum + channel dropdown
|
| 10 |
-
**MCP:** β
|
| 11 |
**AudioAnalyser:** β
LUFS / FFT bands / stereo width / centroid / true peak
|
|
|
|
| 12 |
|
| 13 |
---
|
| 14 |
|
|
@@ -18,306 +19,186 @@
|
|
| 18 |
> Claude Code will test on Mac and answer before you write anything.
|
| 19 |
|
| 20 |
```
|
| 21 |
-
|
|
|
|
|
|
|
|
|
|
| 22 |
|
| 23 |
-
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 24 |
|
| 25 |
βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
|
| 26 |
-
|
| 27 |
-
|
| 28 |
-
|
| 29 |
-
|
| 30 |
-
|
| 31 |
-
|
| 32 |
-
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 33 |
βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
|
| 34 |
|
| 35 |
-
ββ PART 1:
|
| 36 |
-
|
| 37 |
-
static const char* kRegistryPath = "/tmp/pluginbridge-registry.json";
|
| 38 |
-
|
| 39 |
-
ββ PART 2: New file β InstanceRegistry.h (header-only) ββββββ
|
| 40 |
-
No .cpp needed β header only. No CMakeLists change needed.
|
| 41 |
-
Place at: Source/Plugin/InstanceRegistry.h
|
| 42 |
|
| 43 |
-
|
| 44 |
-
|
| 45 |
-
|
| 46 |
-
|
| 47 |
-
void registerInstance(const std::string& channelName, int port);
|
| 48 |
|
| 49 |
-
|
| 50 |
-
|
| 51 |
|
| 52 |
-
|
| 53 |
-
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 54 |
}
|
| 55 |
|
| 56 |
-
|
| 57 |
-
Use nlohmann json (already in libs/). Use std::ofstream / std::ifstream.
|
| 58 |
-
Handle missing file gracefully (registerInstance creates it).
|
| 59 |
|
| 60 |
-
|
| 61 |
-
|
| 62 |
-
|
| 63 |
-
|
| 64 |
-
|
| 65 |
-
|
| 66 |
-
|
| 67 |
-
|
| 68 |
-
|
| 69 |
-
|
| 70 |
-
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 71 |
|
| 72 |
-
|
| 73 |
-
std::function<std::string()> channelNameCallback;
|
| 74 |
|
| 75 |
-
|
| 76 |
{
|
| 77 |
-
|
| 78 |
-
|
| 79 |
-
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 80 |
}
|
| 81 |
|
| 82 |
-
|
| 83 |
-
|
| 84 |
-
|
| 85 |
-
|
| 86 |
-
|
| 87 |
-
|
| 88 |
-
|
| 89 |
-
|
| 90 |
-
|
| 91 |
-
|
| 92 |
-
|
| 93 |
-
|
| 94 |
-
|
| 95 |
-
|
| 96 |
-
|
| 97 |
-
|
| 98 |
-
|
| 99 |
-
|
| 100 |
-
|
| 101 |
-
|
| 102 |
-
|
| 103 |
-
|
| 104 |
-
// After: mcpServer(std::make_unique<McpServer>(helper))
|
| 105 |
-
|
| 106 |
-
AFTER mcpServer->start() β register to registry:
|
| 107 |
-
InstanceRegistry::registerInstance(channelName.toStdString(), mcpServer->getPort());
|
| 108 |
-
|
| 109 |
-
ADD channelNameCallback wiring (next to getAnalysisCallback):
|
| 110 |
-
mcpServer->channelNameCallback = [this]() { return channelName.toStdString(); };
|
| 111 |
-
|
| 112 |
-
IN setChannelName():
|
| 113 |
-
channelName = name;
|
| 114 |
-
// Re-register with new name (unregister old, register new)
|
| 115 |
-
InstanceRegistry::unregisterInstance(channelName.toStdString());
|
| 116 |
-
InstanceRegistry::registerInstance(name.toStdString(), mcpServer->getPort());
|
| 117 |
-
|
| 118 |
-
IN Destructor β unregister:
|
| 119 |
-
InstanceRegistry::unregisterInstance(channelName.toStdString());
|
| 120 |
-
|
| 121 |
-
UPDATE getStateInformation β save channelName:
|
| 122 |
-
state.setProperty("channelName", channelName, nullptr);
|
| 123 |
-
|
| 124 |
-
UPDATE setStateInformation β restore channelName:
|
| 125 |
-
channelName = state.getProperty("channelName", "Unnamed").toString();
|
| 126 |
-
|
| 127 |
-
ββ PART 5: PluginBridgeEditor.h / .mm ββ (AUTHORIZED this sprint)
|
| 128 |
-
ADD to PluginBridgeEditor.h:
|
| 129 |
-
juce::ComboBox channelDropdown;
|
| 130 |
-
|
| 131 |
-
IN PluginBridgeEditor constructor (.mm):
|
| 132 |
-
Populate channelDropdown with this EXACT list using addSectionHeading() + addItem():
|
| 133 |
-
|
| 134 |
-
ββ Vocals ββ
|
| 135 |
-
Lead Vocal (id:1), Backing Vocal (id:2), Adlibs (id:3)
|
| 136 |
-
ββ Drums ββ
|
| 137 |
-
Kick (id:4), Snare (id:5), Hi-Hat (id:6), Overheads (id:7), Percussion (id:8)
|
| 138 |
-
ββ Bass ββ
|
| 139 |
-
Bass / 808 (id:9), Bass Guitar (id:10), Sub Bass (id:11), Synth Bass (id:12)
|
| 140 |
-
ββ Keys & Guitar ββ
|
| 141 |
-
Piano / Keys (id:13), Acoustic Guitar (id:14), Electric Guitar (id:15)
|
| 142 |
-
ββ Synths ββ
|
| 143 |
-
Synth Lead (id:16), Synth Pad / Pluck (id:17)
|
| 144 |
-
ββ Strings & Brass ββ
|
| 145 |
-
Strings (id:18), Brass / Woodwind (id:19), Orchestral (id:20)
|
| 146 |
-
ββ FX ββ
|
| 147 |
-
Reverb / Delay (id:21), Foley / Ambient (id:22)
|
| 148 |
-
ββ Buses ββ
|
| 149 |
-
Vocal Bus (id:23), Drum Bus (id:24), Guitar Bus (id:25), Synth Bus (id:26),
|
| 150 |
-
Music Bus (id:27), Instrument Bus (id:28), Master Bus / Mix Bus (id:29)
|
| 151 |
-
ββ Custom ββ
|
| 152 |
-
Custom... (id:30)
|
| 153 |
-
|
| 154 |
-
channelDropdown.onChange = [this]() {
|
| 155 |
-
auto text = channelDropdown.getText();
|
| 156 |
-
if (text == "Custom...") {
|
| 157 |
-
// Show AlertWindow to enter custom name
|
| 158 |
-
juce::AlertWindow::showInputBoxAsync("Channel Name", "Enter channel name:", "",
|
| 159 |
-
processorRef.getChannelName(), nullptr,
|
| 160 |
-
[this](const juce::String& result) {
|
| 161 |
-
if (result.isNotEmpty()) {
|
| 162 |
-
channelDropdown.setText(result, juce::dontSendNotification);
|
| 163 |
-
processorRef.setChannelName(result);
|
| 164 |
-
}
|
| 165 |
-
});
|
| 166 |
-
} else {
|
| 167 |
-
processorRef.setChannelName(text);
|
| 168 |
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 169 |
};
|
| 170 |
|
| 171 |
-
|
| 172 |
-
|
| 173 |
-
|
| 174 |
-
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 175 |
|
| 176 |
-
|
| 177 |
-
|
| 178 |
-
|
| 179 |
-
|
| 180 |
-
channelDropdown.setBounds(4, 4, 160, 22);
|
| 181 |
|
| 182 |
ββ SCOPE ββββββββββββββββββββββββββββββββββββββββββββββββββββ
|
| 183 |
TOUCH:
|
| 184 |
-
|
| 185 |
-
Source/Plugin/
|
| 186 |
-
Source/Plugin/
|
| 187 |
-
Source/Plugin/PluginBridgeProcessor.h / .cpp
|
| 188 |
-
Source/Plugin/PluginBridgeEditor.h / .mm β AUTHORIZED this sprint only
|
| 189 |
|
| 190 |
DO NOT TOUCH:
|
| 191 |
-
|
| 192 |
-
|
| 193 |
-
|
| 194 |
-
|
| 195 |
-
|
| 196 |
-
|
| 197 |
-
|
| 198 |
-
|
| 199 |
-
|
| 200 |
-
|
| 201 |
-
|
| 202 |
-
|
| 203 |
-
|
| 204 |
-
|
| 205 |
-
|
| 206 |
-
|
| 207 |
-
|
| 208 |
-
|
| 209 |
-
|
| 210 |
-
--- prepareToPlay() ---
|
| 211 |
-
|
| 212 |
-
The iZotope/Neutron crash concern is MOOT. Here is why:
|
| 213 |
-
iZotope plugins crash during the safety SCAN β they are marked UNSAFE in the DB
|
| 214 |
-
UNSAFE plugins never reach loadInProcessPlugin() β they use Helper-only path
|
| 215 |
-
loadInProcessPlugin() is ONLY ever called for SAFE plugins
|
| 216 |
-
Therefore: calling prepareToPlay() inside loadInProcessPlugin() is safe
|
| 217 |
-
|
| 218 |
-
currentSampleRate and currentBlockSize are ALWAYS valid when loadInProcessPlugin()
|
| 219 |
-
is called. Ableton calls our prepareToPlay() before audio starts, and users can only
|
| 220 |
-
pick a plugin after audio is running. Verified in processor code β both are stored
|
| 221 |
-
as member variables (currentSampleRate, currentBlockSize).
|
| 222 |
-
|
| 223 |
-
ADD these lines in loadInProcessPlugin(), after setBusesLayout() and before addListener():
|
| 224 |
-
|
| 225 |
-
if (currentSampleRate > 0 && currentBlockSize > 0)
|
| 226 |
-
inProcessPlugin->prepareToPlay(currentSampleRate, currentBlockSize);
|
| 227 |
-
|
| 228 |
-
--- processBlock() ---
|
| 229 |
-
|
| 230 |
-
I read the current processBlock. The MidiBuffer parameter is unnamed β you must name
|
| 231 |
-
it to pass to inProcessPlugin. Change the signature too:
|
| 232 |
-
|
| 233 |
-
// Before:
|
| 234 |
-
void PluginBridgeProcessor::processBlock(juce::AudioBuffer<float>& buffer, juce::MidiBuffer&)
|
| 235 |
-
|
| 236 |
-
// After:
|
| 237 |
-
void PluginBridgeProcessor::processBlock(juce::AudioBuffer<float>& buffer, juce::MidiBuffer& midiMessages)
|
| 238 |
-
|
| 239 |
-
Then replace the current early-return guard and shm path with this:
|
| 240 |
-
|
| 241 |
-
if (!pluginLoaded) return;
|
| 242 |
-
|
| 243 |
-
if (inProcessPlugin != nullptr)
|
| 244 |
-
{
|
| 245 |
-
// SAFE plugin β in-process handles both audio and GUI
|
| 246 |
-
inProcessPlugin->processBlock(buffer, midiMessages);
|
| 247 |
-
analyser.processBlock(buffer);
|
| 248 |
-
return;
|
| 249 |
-
}
|
| 250 |
-
|
| 251 |
-
// UNSAFE plugin β Helper via shm (existing path, unchanged)
|
| 252 |
-
if (!helper.isHelperRunning()) return;
|
| 253 |
-
auto& shm = helper.getSharedAudio();
|
| 254 |
-
if (!shm.isValid()) return;
|
| 255 |
-
// ... rest of shm path stays exactly as-is
|
| 256 |
-
|
| 257 |
-
NOTE: Keep the Helper spawn for safe plugins β still needed for MCP param IPC.
|
| 258 |
-
NOTE: Do NOT remove any PBLOG calls.
|
| 259 |
-
NOTE: Also update the declaration in PluginBridgeProcessor.h if the signature changes.
|
| 260 |
-
```
|
| 261 |
-
|
| 262 |
-
---
|
| 263 |
-
|
| 264 |
-
## CLAUDE CODE β ML INTERN
|
| 265 |
-
|
| 266 |
-
> Read this at the start of every coding session.
|
| 267 |
-
|
| 268 |
-
```
|
| 269 |
-
STATUS: TASK READY β Sprint 5
|
| 270 |
-
|
| 271 |
-
TASK: Route audio through in-process plugin for SAFE plugins (fixes spectrum analyzers)
|
| 272 |
-
|
| 273 |
-
PROBLEM (verified on Mac 2026-05-17):
|
| 274 |
-
Pro-Q 4 spectrum analyzer shows no signal inside PluginBridge.
|
| 275 |
-
Root cause: two separate plugin instances are running β
|
| 276 |
-
- Helper process instance β handles audio (but has no GUI)
|
| 277 |
-
- In-process instance β provides GUI only (but never sees audio)
|
| 278 |
-
Pro-Q 4's spectrum belongs to the in-process GUI instance, so it stays empty.
|
| 279 |
-
The AudioAnalyser MCP tool confirms audio IS flowing (returned live LUFS/FFT data).
|
| 280 |
-
|
| 281 |
-
FIX β only touch PluginBridgeProcessor.cpp (and .h if needed):
|
| 282 |
-
In processBlock(), check if a safe in-process plugin is loaded.
|
| 283 |
-
If yes β call inProcessPlugin->processBlock(buffer, midiMessages) directly.
|
| 284 |
-
If no (unsafe, Helper-only) β keep existing shm path unchanged.
|
| 285 |
-
|
| 286 |
-
Pseudocode:
|
| 287 |
-
if (inProcessPlugin != nullptr)
|
| 288 |
-
inProcessPlugin->processBlock(buffer, midiMessages);
|
| 289 |
-
else
|
| 290 |
-
// existing shm write β Helper β shm readOutput path
|
| 291 |
-
|
| 292 |
-
The in-process plugin is already loaded (loadInProcessPlugin runs for SAFE plugins).
|
| 293 |
-
You are NOT changing when it loads β only adding the audio call in processBlock.
|
| 294 |
-
|
| 295 |
-
SCOPE β only these files:
|
| 296 |
-
TOUCH: PluginBridgeProcessor.cpp (processBlock change, ~5 lines)
|
| 297 |
-
PluginBridgeProcessor.h (only if inProcessPlugin member needs exposing)
|
| 298 |
-
DO NOT TOUCH:
|
| 299 |
-
PluginBridgeEditor.mm β LOCKED
|
| 300 |
-
PluginPickerComponent.mm β LOCKED
|
| 301 |
-
HelperPluginHost.mm β LOCKED
|
| 302 |
-
HelperConnection.cpp β LOCKED
|
| 303 |
-
CMakeLists.txt β no new files, no changes needed
|
| 304 |
-
|
| 305 |
-
VERIFY before pushing:
|
| 306 |
-
- Does inProcessPlugin->processBlock() exist in JUCE AudioPluginInstance? YES β
|
| 307 |
-
it inherits from AudioProcessor which has processBlock(AudioBuffer&, MidiBuffer&)
|
| 308 |
-
- Helper still runs for safe plugins (needed for MCP param read/write via Helper IPC)
|
| 309 |
-
Do NOT remove the Helper spawn or shm path β just skip the shm audio write when
|
| 310 |
-
in-process plugin is available.
|
| 311 |
-
- Do NOT remove PBLOG calls.
|
| 312 |
-
|
| 313 |
-
EXPECTED RESULT after fix:
|
| 314 |
-
Pro-Q 4 spectrum analyzer shows live audio. EQ curve interactive.
|
| 315 |
-
get_analysis MCP tool still works (AudioAnalyser runs on same buffer).
|
| 316 |
-
|
| 317 |
-
Last (2026-05-17): Sprint 4 regression fixed. PluginBridgeEditor.mm was reverted
|
| 318 |
-
to CALayerHost (FAILED-APPROACHES #10 β never works in Ableton). Restored from
|
| 319 |
-
stash. FFT fixed (was allocating on audio thread). PluginPickerComponent.mm was
|
| 320 |
-
missing from CMakeLists.txt β added. All working now.
|
| 321 |
```
|
| 322 |
|
| 323 |
---
|
|
@@ -325,21 +206,23 @@ missing from CMakeLists.txt β added. All working now.
|
|
| 325 |
## NEXT PUSH β ML Intern fills before every push
|
| 326 |
|
| 327 |
```
|
| 328 |
-
STATUS: READY TO CODE β
|
| 329 |
|
| 330 |
-
TASK:
|
| 331 |
FILES CHANGING:
|
| 332 |
-
-
|
| 333 |
-
|
| 334 |
-
-
|
| 335 |
-
|
| 336 |
-
-
|
| 337 |
-
-
|
| 338 |
-
|
| 339 |
-
-
|
|
|
|
| 340 |
APIS USED (verified by Claude Code? y/n):
|
| 341 |
-
- inProcessPlugin->
|
| 342 |
-
-
|
|
|
|
| 343 |
```
|
| 344 |
|
| 345 |
---
|
|
@@ -347,9 +230,9 @@ APIS USED (verified by Claude Code? y/n):
|
|
| 347 |
## LAST BUILD RESULT β Claude Code fills after pull+build
|
| 348 |
|
| 349 |
```
|
| 350 |
-
Date: 2026-05-17
|
| 351 |
Commits pulled: 225322d (backend), 6b15202 (channel dropdown)
|
| 352 |
-
Build: β
Clean
|
| 353 |
-
Tests: channel dropdown β
|
| 354 |
-
Issues:
|
| 355 |
```
|
|
|
|
| 6 |
|
| 7 |
**Version:** v0.6.0
|
| 8 |
**Build:** β
Clean (2026-05-17)
|
| 9 |
+
**GUI:** β
TreeView picker + in-process createEditor() + live spectrum + channel dropdown
|
| 10 |
+
**MCP:** β
6 tools β list_plugins, list_instances, search_param, get_params, set_params, get_analysis
|
| 11 |
**AudioAnalyser:** β
LUFS / FFT bands / stereo width / centroid / true peak
|
| 12 |
+
**β οΈ KNOWN BUG:** set_params/get_params/search_param target Helper's plugin instance, NOT the in-process GUI instance β EQ changes invisible in Pro-Q 4. Sprint 7 fixes this.
|
| 13 |
|
| 14 |
---
|
| 15 |
|
|
|
|
| 19 |
> Claude Code will test on Mac and answer before you write anything.
|
| 20 |
|
| 21 |
```
|
| 22 |
+
(no pending questions)
|
| 23 |
+
```
|
| 24 |
+
|
| 25 |
+
---
|
| 26 |
|
| 27 |
+
## CLAUDE CODE β ML INTERN
|
| 28 |
+
|
| 29 |
+
> Read this at the start of every coding session.
|
| 30 |
+
|
| 31 |
+
```
|
| 32 |
+
STATUS: TASK READY β Sprint 7
|
| 33 |
+
|
| 34 |
+
TASK: Route MCP param ops through in-process plugin for SAFE plugins
|
| 35 |
+
(fix: EQ changes via MCP must appear in Pro-Q 4 / plugin GUI)
|
| 36 |
|
| 37 |
βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
|
| 38 |
+
ROOT CAUSE:
|
| 39 |
+
After Sprint 5, audio routes through inProcessPlugin.
|
| 40 |
+
But search_param / get_params / set_params still use
|
| 41 |
+
HelperConnection IPC β Helper process β Helper's plugin instance.
|
| 42 |
+
That instance has no GUI β Pro-Q 4 GUI shows inProcessPlugin's state.
|
| 43 |
+
Result: EQ changes are applied silently to a hidden instance nobody sees.
|
| 44 |
+
|
| 45 |
+
FIX ARCHITECTURE:
|
| 46 |
+
Add three param callbacks to McpServer (same pattern as
|
| 47 |
+
getAnalysisCallback and channelNameCallback already in McpServer.h).
|
| 48 |
+
Processor wires them to inProcessPlugin when SAFE plugin is loaded.
|
| 49 |
+
McpServer uses callbacks when set; falls back to Helper IPC when null.
|
| 50 |
βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
|
| 51 |
|
| 52 |
+
ββ PART 1: McpServer.h ββββββββββββββββββββββββββββββββββββββ
|
| 53 |
+
ADD three new callbacks (next to existing getAnalysisCallback):
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 54 |
|
| 55 |
+
// Param callbacks β wired to inProcessPlugin when SAFE, null when UNSAFE
|
| 56 |
+
std::function<std::string(const std::string& keyword)> searchParamCallback;
|
| 57 |
+
std::function<std::string(const std::vector<int>& ids)> getParamsCallback;
|
| 58 |
+
std::function<bool(const std::map<int,float>& values)> setParamsCallback;
|
|
|
|
| 59 |
|
| 60 |
+
ββ PART 2: McpServer.cpp β handleToolsCall() ββββββββββββββββ
|
| 61 |
+
CHANGE search_param handler (in-process first, Helper fallback):
|
| 62 |
|
| 63 |
+
else if (toolName == "search_param")
|
| 64 |
+
{
|
| 65 |
+
if (searchParamCallback)
|
| 66 |
+
{
|
| 67 |
+
resultText = searchParamCallback(args.value("keyword",""));
|
| 68 |
+
}
|
| 69 |
+
else
|
| 70 |
+
{
|
| 71 |
+
json cmd = {{"cmd","search_param"},{"keyword",args.value("keyword","")}};
|
| 72 |
+
auto resp = helper.sendCommand(cmd.dump());
|
| 73 |
+
try { auto j = json::parse(resp); resultText = j.value("ok",false) ? j["results"].dump() : "search failed"; }
|
| 74 |
+
catch (...) { resultText = "parse error"; isError = true; }
|
| 75 |
+
}
|
| 76 |
}
|
| 77 |
|
| 78 |
+
CHANGE get_params handler similarly:
|
|
|
|
|
|
|
| 79 |
|
| 80 |
+
else if (toolName == "get_params")
|
| 81 |
+
{
|
| 82 |
+
if (getParamsCallback)
|
| 83 |
+
{
|
| 84 |
+
auto idsJson = args.value("ids", json::array());
|
| 85 |
+
std::vector<int> ids;
|
| 86 |
+
for (auto& v : idsJson) ids.push_back(v.get<int>());
|
| 87 |
+
resultText = getParamsCallback(ids);
|
| 88 |
+
}
|
| 89 |
+
else
|
| 90 |
+
{
|
| 91 |
+
json cmd = {{"cmd","get_params"},{"ids",args.value("ids",json::array())}};
|
| 92 |
+
auto resp = helper.sendCommand(cmd.dump());
|
| 93 |
+
try { auto j = json::parse(resp); resultText = j.value("ok",false) ? j["values"].dump() : "get failed"; }
|
| 94 |
+
catch (...) { resultText = "parse error"; isError = true; }
|
| 95 |
+
}
|
| 96 |
+
}
|
| 97 |
|
| 98 |
+
CHANGE set_params handler similarly:
|
|
|
|
| 99 |
|
| 100 |
+
else if (toolName == "set_params")
|
| 101 |
{
|
| 102 |
+
if (setParamsCallback)
|
| 103 |
+
{
|
| 104 |
+
auto valuesJson = args.value("values", json::object());
|
| 105 |
+
std::map<int,float> values;
|
| 106 |
+
for (auto& [k,v] : valuesJson.items())
|
| 107 |
+
values[std::stoi(k)] = v.get<float>();
|
| 108 |
+
bool ok = setParamsCallback(values);
|
| 109 |
+
resultText = ok ? "ok" : "set failed";
|
| 110 |
+
if (!ok) isError = true;
|
| 111 |
+
}
|
| 112 |
+
else
|
| 113 |
+
{
|
| 114 |
+
json cmd = {{"cmd","set_params"},{"values",args.value("values",json::object())}};
|
| 115 |
+
auto resp = helper.sendCommand(cmd.dump());
|
| 116 |
+
try { auto j = json::parse(resp); resultText = j.value("ok",false) ? "ok" : "set failed"; }
|
| 117 |
+
catch (...) { resultText = "parse error"; isError = true; }
|
| 118 |
+
}
|
| 119 |
}
|
| 120 |
|
| 121 |
+
ALSO update search_param tool description in handleToolsList():
|
| 122 |
+
// Before: "Search params by keyword"
|
| 123 |
+
// After: "Search params by keyword. Returns index 'i' and current value. Use 'i' as key for set_params/get_params."
|
| 124 |
+
|
| 125 |
+
ββ PART 3: PluginBridgeProcessor.cpp β wire callbacks ββββββ
|
| 126 |
+
Call wireInProcessParamCallbacks() from loadInProcessPlugin() AFTER
|
| 127 |
+
inProcessPlugin is ready. Call clearInProcessParamCallbacks() from
|
| 128 |
+
unloadInProcessPlugin() BEFORE inProcessPlugin is cleared.
|
| 129 |
+
|
| 130 |
+
Wire searchParamCallback:
|
| 131 |
+
mcpServer->searchParamCallback = [this](const std::string& keyword) -> std::string {
|
| 132 |
+
auto& params = inProcessPlugin->getParameters();
|
| 133 |
+
json results = json::array();
|
| 134 |
+
std::string kw = keyword;
|
| 135 |
+
std::transform(kw.begin(), kw.end(), kw.begin(), ::tolower);
|
| 136 |
+
for (int i = 0; i < params.size(); ++i)
|
| 137 |
+
{
|
| 138 |
+
std::string name = params[i]->getName(128).toStdString();
|
| 139 |
+
std::string nameLow = name;
|
| 140 |
+
std::transform(nameLow.begin(), nameLow.end(), nameLow.begin(), ::tolower);
|
| 141 |
+
if (nameLow.find(kw) != std::string::npos)
|
| 142 |
+
results.push_back({{"i", i}, {"name", name}, {"value", params[i]->getValue()}});
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 143 |
}
|
| 144 |
+
return results.dump();
|
| 145 |
+
};
|
| 146 |
+
// NOTE: "i" = array index. Use this as key for set_params/get_params.
|
| 147 |
+
// This also fixes the id-vs-index bug from Sprint 6.
|
| 148 |
+
|
| 149 |
+
Wire getParamsCallback:
|
| 150 |
+
mcpServer->getParamsCallback = [this](const std::vector<int>& ids) -> std::string {
|
| 151 |
+
auto& params = inProcessPlugin->getParameters();
|
| 152 |
+
json values = json::object();
|
| 153 |
+
for (int idx : ids)
|
| 154 |
+
if (idx >= 0 && idx < params.size())
|
| 155 |
+
values[std::to_string(idx)] = params[idx]->getValue();
|
| 156 |
+
return values.dump();
|
| 157 |
};
|
| 158 |
|
| 159 |
+
Wire setParamsCallback:
|
| 160 |
+
mcpServer->setParamsCallback = [this](const std::map<int,float>& values) -> bool {
|
| 161 |
+
juce::MessageManager::callAsync([this, values]() {
|
| 162 |
+
auto& p = inProcessPlugin->getParameters();
|
| 163 |
+
for (auto& [idx, val] : values)
|
| 164 |
+
if (idx >= 0 && idx < p.size())
|
| 165 |
+
p[idx]->setValueNotifyingHost(val);
|
| 166 |
+
});
|
| 167 |
+
return true;
|
| 168 |
+
};
|
| 169 |
+
// setValueNotifyingHost β notifies plugin GUI, changes appear in Pro-Q 4 instantly.
|
| 170 |
|
| 171 |
+
Clear in clearInProcessParamCallbacks():
|
| 172 |
+
mcpServer->searchParamCallback = nullptr;
|
| 173 |
+
mcpServer->getParamsCallback = nullptr;
|
| 174 |
+
mcpServer->setParamsCallback = nullptr;
|
|
|
|
| 175 |
|
| 176 |
ββ SCOPE ββββββββββββββββββββββββββββββββββββββββββββββββββββ
|
| 177 |
TOUCH:
|
| 178 |
+
Source/Plugin/McpServer.h β add 3 callbacks
|
| 179 |
+
Source/Plugin/McpServer.cpp β use callbacks in handleToolsCall(), update description
|
| 180 |
+
Source/Plugin/PluginBridgeProcessor.cpp β wire/clear callbacks
|
|
|
|
|
|
|
| 181 |
|
| 182 |
DO NOT TOUCH:
|
| 183 |
+
PluginBridgeEditor.mm β LOCKED
|
| 184 |
+
PluginPickerComponent.mm β LOCKED
|
| 185 |
+
HelperPluginHost.mm β LOCKED
|
| 186 |
+
HelperConnection.cpp β LOCKED
|
| 187 |
+
CMakeLists.txt β no new files
|
| 188 |
+
|
| 189 |
+
ββ VERIFIED APIs (Claude Code β 2026-05-17) βββββββββββββββββ
|
| 190 |
+
inProcessPlugin->getParameters() β juce::Array<AudioProcessorParameter*> β
|
| 191 |
+
params[i]->getName(128).toStdString() β parameter name string β
|
| 192 |
+
params[i]->getValue() β float 0.0β1.0 β
|
| 193 |
+
params[i]->setValueNotifyingHost(float) β sets value + notifies GUI β
|
| 194 |
+
juce::MessageManager::callAsync(lambda) β dispatch to message thread β
|
| 195 |
+
getInProcessPlugin() on Processor β already public (PluginBridgeProcessor.h line 64) β
|
| 196 |
+
|
| 197 |
+
ββ EXPECTED RESULT ββββββββββββββββββββββββββββββββββββββββββ
|
| 198 |
+
search_param "freq" β returns in-process Pro-Q 4 params with index "i"
|
| 199 |
+
set_params {"26": 0.748} β Band 2 moves to ~4kHz in Pro-Q 4 GUI immediately
|
| 200 |
+
get_params [26] β returns current value from in-process instance
|
| 201 |
+
UNSAFE plugins: callbacks null β falls back to Helper IPC (unchanged)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 202 |
```
|
| 203 |
|
| 204 |
---
|
|
|
|
| 206 |
## NEXT PUSH β ML Intern fills before every push
|
| 207 |
|
| 208 |
```
|
| 209 |
+
STATUS: READY TO CODE β Sprint 7
|
| 210 |
|
| 211 |
+
TASK: Route MCP param ops through in-process plugin (fix EQ-invisible-in-GUI bug)
|
| 212 |
FILES CHANGING:
|
| 213 |
+
- Source/Plugin/McpServer.h
|
| 214 |
+
- Source/Plugin/McpServer.cpp
|
| 215 |
+
- Source/Plugin/PluginBridgeProcessor.cpp
|
| 216 |
+
FILES NOT TOUCHING:
|
| 217 |
+
- PluginBridgeEditor.mm β
|
| 218 |
+
- PluginPickerComponent.mm β
|
| 219 |
+
- HelperPluginHost.mm β
|
| 220 |
+
- HelperConnection.cpp β
|
| 221 |
+
NEW FILES: none
|
| 222 |
APIS USED (verified by Claude Code? y/n):
|
| 223 |
+
- inProcessPlugin->getParameters() β y
|
| 224 |
+
- params[i]->setValueNotifyingHost(v) β y
|
| 225 |
+
- juce::MessageManager::callAsync() β y
|
| 226 |
```
|
| 227 |
|
| 228 |
---
|
|
|
|
| 230 |
## LAST BUILD RESULT β Claude Code fills after pull+build
|
| 231 |
|
| 232 |
```
|
| 233 |
+
Date: 2026-05-17 (after folder move to AI MUSIC PRODUCTION)
|
| 234 |
Commits pulled: 225322d (backend), 6b15202 (channel dropdown)
|
| 235 |
+
Build: β
Clean β [100%] Built target PluginBridge_VST3
|
| 236 |
+
Tests: channel dropdown β
list_instances β
port 16620 first-instance β
|
| 237 |
+
Issues: Sprint 7 pending β EQ changes not visible in Pro-Q 4 GUI
|
| 238 |
```
|