Commit History
-
Sprint 6: wire channelName, registry, and auto-port into Processor.cpp
Verified signatureChanges from v0.5.3: 1. Constructor: McpServer(helper) — no port, auto-assigned 2. After start(): wire channelNameCallback + register to registry 3. Destructor: unregister from registry 4. New method: setChannelName() 5. getStateInformation: save channelName 6. setStateInformation: restore channelName"225322d -
Sprint 6: add channelName + setChannelName to Processor header
Verified signature0a63fb2 -
Upload Source/Plugin/McpServer.cpp
Verified signature351c5a1 -
Upload Source/Plugin/McpServer.h
Verified signaturea87020c -
Upload Source/Plugin/InstanceRegistry.h
Verified signaturea02f9a6 -
Sprint 6: Channel name dropdown + multi-instance registry + list_instances MCP tool
Verified signatureNEXT PUSH: TASK: Multi-instance support — channel naming + registry + list_instances FILES CHANGING: - Source/Shared/Constants.h (add kRegistryPath) - Source/Plugin/InstanceRegistry.h (NEW — header-only) - Source/Plugin/McpServer.h (remove port param, add channelNameCallback) - Source/Plugin/McpServer.cpp (bind_to_any_port, list_instances, channel prefix) - Source/Plugin/PluginBridgeProcessor.h (add channelName + setChannelName) - Source/Plugin/PluginBridgeProcessor.cpp (registry integration + state save/restore) - Source/Plugin/PluginBridgeEditor.h (add channelDropdown) - Source/Plugin/PluginBridgeEditor.mm (dropdown UI + onChange) — AUTHORIZED this sprint FILES NOT TOUCHING: - PluginPickerComponent.mm ✅ - HelperPluginHost.mm ✅ - HelperConnection.cpp ✅ - CMakeLists.txt ✅ (no new .cpp files) APIS USED (all verified by Claude Code): - httplib bind_to_any_port ✅ - httplib listen_after_bind ✅ - juce::ComboBox ✅ - juce…08315b0 -
Sprint 5: route audio through in-process plugin for SAFE plugins
Verified signatureNEXT PUSH: TASK: Pro-Q 4 spectrum analyzer fix — audio now flows through in-process instance FILES CHANGING: - PluginBridgeProcessor.cpp (processBlock routing + prepareToPlay in loadInProcessPlugin) FILES NOT TOUCHING: - PluginBridgeEditor.mm ✅ - PluginPickerComponent.mm ✅ - HelperPluginHost.mm ✅ - HelperConnection.cpp ✅ NEW FILES: none APIS USED: - inProcessPlugin->processBlock() — verified (AudioProcessor inheritance) - inProcessPlugin->prepareToPlay() — verified safe (only SAFE plugins reach here) Changes: 1. loadInProcessPlugin(): added prepareToPlay(currentSampleRate, currentBlockSize) after setBusesLayout(), before state restore + addListener() 2. processBlock(): named MidiBuffer param, added in-process audio path: if inProcessPlugin exists → processBlock directly (skips Helper shm) else → existing Helper shm path unchanged 3. AudioAnalyser runs on the output regardless of which path is used"2eb08b2 -
fix: restore v0.5.2 architecture + wire AudioAnalyser correctly
Sitar118 +1: Claude Sonnet 4.6- Restored PluginBridgeEditor.mm to v0.5.2 (in-process createEditor, TreeView picker) - Restored PluginBridgeProcessor.cpp to v0.5.2 (loadInProcessPlugin, safety scan, deduplication, manufacturer names, PBLOG) - Added PluginPickerComponent.mm to CMakeLists.txt (was never registered) - Wired AudioAnalyser into v0.5.2 processor (prepareToPlay, processBlock, getAnalysisCallback) - Fixed AudioAnalyser: FFT is now a stored member, not created per audio block - Updated MACHINE-CONTEXT.md: full scope rules, workflow, architecture lock, dead-end list Root cause of regression: ML Intern rewrote Editor+Processor to add AudioAnalyser, accidentally reverting to pre-v0.5.2 CALayerHost architecture (FAILED-APPROACHES #10). MACHINE-CONTEXT.md now has explicit scope rules to prevent this. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>fdc4e41 -
wire AudioAnalyser: prepareToPlay + processBlock + MCP callback (3 additions)
Verified signaturedf843ce -
Upload Source/Plugin/McpServer.cpp
Verified signature9836bb8 -
Upload Source/Plugin/McpServer.h
Verified signature9209b46 -
integrate AudioAnalyser into Processor + wire get_analysis in McpServer
Verified signatureProcessor: adds AudioAnalyser, calls processBlock after shared memory read McpServer: get_analysis now calls processor's getAnalysis() instead of returning 'silent'"abf507a -
Sprint 4: Add AudioAnalyser — LUFS, FFT bands, stereo width, centroid, true peak
Verified signatureRuns in processBlock (audio thread), stores results in atomics. MCP get_analysis reads atomics from HTTP thread — zero contention. Output format: "-14.2 LUFS | TP:-1.1 | sub:ok bass:+3 low:ok mid:ok hi:-2 brill:ok | W:0.72 | bright" Max ~60 tokens per call."f6aee3c
-
fix: replace CARemoteLayerServer with CAContext+CALayerHost for cross-process GUI
Sitar118Three bugs killed the GUI: 1. CARemoteLayerServer does not capture a hidden NSWindow's content cross-process. Replaced with CAContext (server) + CALayerHost (client) — the correct private-but-stable macOS API for cross-process layer embedding, stable from 10.10 through Sequoia. 2. NSWindow was never orderFront: — WindowServer never composited its content. Fixed: window positioned at (-32000,-32000) and orderFront: called. 3. NSMachBootstrapServer (deprecated on 13+) no longer needed. contextId (uint32_t) is sent directly over the existing IPC socket. New file: Source/Shared/PrivateCA.h — declares CAContext, CALayerHost, CGSMainConnectionID.0548359 -
fix: wire onGuiCreated callback in HelperIPC constructor to send gui_ready notification
Verified signaturedf8bc97 -
fix: call onGuiCreated callback after CARemoteLayerServer setup completes in showGui()
Verified signature9788b5f -
fix: send gui_ready notification after showGui — use callback from HelperPluginHost to IPC
Verified signatureHelperPluginHost now has onGuiCreated callback. HelperIPC sets it. When showGui() finishes creating the editor + registering the layer, it calls onGuiCreated which triggers sendGuiReady with port name + size.242769f -
fix: use setLayerPortName() instead of direct member access
Verified signaturec151d02 -
fix: add setLayerPortName() public method (layerPortName is private)
Verified signature7e3323d -
Upload Source/Plugin/Blocklist.h
Verified signature2224b8a -
remove old files replaced by .mm versions + Blocklist (now in PluginBridgeProcessor.h)
Verified signature4ca2875 -
Upload Source/Plugin/McpServer.cpp
Verified signaturea4fe44e -
Upload Source/Plugin/McpServer.h
Verified signaturee5f329d -
Upload Source/Helper/HelperIPC.cpp
Verified signature8aeb4e8 -
Upload Source/Helper/HelperIPC.h
Verified signature6c4aa19 -
Upload Source/Plugin/HelperConnection.cpp
Verified signature8335f9f -
Upload Source/Plugin/HelperConnection.h
Verified signature24a3c7f -
Upload Source/Plugin/PluginBridgeEditor.mm
Verified signature6063997 -
Upload Source/Plugin/PluginBridgeEditor.h
Verified signatured966811 -
Upload Source/Plugin/PluginBridgeProcessor.cpp
Verified signature3e55272 -
Upload Source/Plugin/PluginBridgeProcessor.h
Verified signature590be7d -
Upload Source/Helper/main.cpp
Verified signature22d14fd -
Upload Source/Helper/HelperPluginHost.mm
Verified signature0e80263 -
Upload Source/Helper/HelperPluginHost.h
Verified signatureef91ceb -
Upload Source/Shared/Constants.h
Verified signature475c9dd -
v0.4: CARemoteLayerServer architecture — crash-safe + GUI inside Ableton window
Verified signatureCOMPLETE REWRITE to proper solution: - Plugin runs in Helper process (crash-safe, like v0.2) - GUI renders in Helper via CARemoteLayerServer - PluginBridge.vst3 displays it via CARemoteLayerClient (CALayer inside its own editor) - Mach port transferred via NSMachBootstrapServer (named port per PID) - Mouse/keyboard events forwarded from host → helper via Unix socket IPC - Audio routes via shared memory (same as v0.2) This gives BOTH crash safety AND GUI inside Ableton's window (including fullscreen). Based on: Apple's CARemoteLayerServer/Client public API (macOS 10.7+) Reference: krevis/RemoteLayerDemo on GitHub"4ad264f -
fix: Blocklist path corrected to ~/Library/PluginBridge/ (where JUCE actually writes)"
Verified signatureb1feaca -
fix: findHelperBinary looks for .app bundle, not bare executable
Verified signature9e02f23 -
fix: Helper test-load — handle paths with spaces + allow message loop to run
Verified signatureBug 1: paths with spaces got split by tokenizer. Fix: join all args after --test. Bug 2: some plugins need the JUCE message loop to finish loading (VST3 validation). Fix: use a Timer to delay quit, giving the plugin time to initialize.379e9dd -
implement Helper test-load: spawns Helper before in-process load, blocks crashy plugins
Verified signatureNow loadPlugin() does: 1. Check blocklist → skip if blocked 2. Spawn PluginBridgeHelper --test '/path' → wait for exit 3. Exit code 0 → safe → load in-process 4. Exit code != 0 or crash → add to blocklist → show error → Ableton stays alive This prevents Kickstart 2 / Ozone 12 / any crashy plugin from ever crashing Ableton. The Helper takes the hit instead.767fa15 -
fix: add showingError bool to editor header
Verified signature224d9fb -
fix: replace getColour() with bool flag (Label has no getColour in JUCE 8)
Verified signaturec0c12b8 -
fix: add TestResult enum to header (was in .cpp but missing from .h)
Verified signature1066aac -
Upload Source/Helper/HelperPluginHost.cpp
Verified signatureddb115b -
Upload Source/Helper/HelperPluginHost.h
Verified signature915497a -
Upload Source/Helper/main.cpp
Verified signaturef3db0f3 -
Upload Source/Plugin/McpServer.cpp
Verified signaturebbd0e6f -
Upload Source/Plugin/McpServer.h
Verified signatureab55e95 -
Upload Source/Plugin/Blocklist.h
Verified signature377833b -
Upload Source/Plugin/PluginBridgeEditor.cpp
Verified signature01a8444