Commit History
-
fix: restore v0.5.2 architecture + wire AudioAnalyser correctly
Sitar118 +1: Claude Sonnet 4.6- Restored PluginBridgeEditor.mm to v0.5.2 (in-process createEditor, TreeView picker) - Restored PluginBridgeProcessor.cpp to v0.5.2 (loadInProcessPlugin, safety scan, deduplication, manufacturer names, PBLOG) - Added PluginPickerComponent.mm to CMakeLists.txt (was never registered) - Wired AudioAnalyser into v0.5.2 processor (prepareToPlay, processBlock, getAnalysisCallback) - Fixed AudioAnalyser: FFT is now a stored member, not created per audio block - Updated MACHINE-CONTEXT.md: full scope rules, workflow, architecture lock, dead-end list Root cause of regression: ML Intern rewrote Editor+Processor to add AudioAnalyser, accidentally reverting to pre-v0.5.2 CALayerHost architecture (FAILED-APPROACHES #10). MACHINE-CONTEXT.md now has explicit scope rules to prevent this. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>fdc4e41 -
wire AudioAnalyser: prepareToPlay + processBlock + MCP callback (3 additions)
Verified signaturedf843ce -
Upload Source/Plugin/McpServer.cpp
Verified signature9836bb8 -
Upload Source/Plugin/McpServer.h
Verified signature9209b46 -
integrate AudioAnalyser into Processor + wire get_analysis in McpServer
Verified signatureProcessor: adds AudioAnalyser, calls processBlock after shared memory read McpServer: get_analysis now calls processor's getAnalysis() instead of returning 'silent'"abf507a -
Sprint 4: Add AudioAnalyser — LUFS, FFT bands, stereo width, centroid, true peak
Verified signatureRuns in processBlock (audio thread), stores results in atomics. MCP get_analysis reads atomics from HTTP thread — zero contention. Output format: "-14.2 LUFS | TP:-1.1 | sub:ok bass:+3 low:ok mid:ok hi:-2 brill:ok | W:0.72 | bright" Max ~60 tokens per call."f6aee3c
-
fix: replace CARemoteLayerServer with CAContext+CALayerHost for cross-process GUI
Sitar118Three bugs killed the GUI: 1. CARemoteLayerServer does not capture a hidden NSWindow's content cross-process. Replaced with CAContext (server) + CALayerHost (client) — the correct private-but-stable macOS API for cross-process layer embedding, stable from 10.10 through Sequoia. 2. NSWindow was never orderFront: — WindowServer never composited its content. Fixed: window positioned at (-32000,-32000) and orderFront: called. 3. NSMachBootstrapServer (deprecated on 13+) no longer needed. contextId (uint32_t) is sent directly over the existing IPC socket. New file: Source/Shared/PrivateCA.h — declares CAContext, CALayerHost, CGSMainConnectionID.0548359 -
fix: wire onGuiCreated callback in HelperIPC constructor to send gui_ready notification
Verified signaturedf8bc97 -
fix: call onGuiCreated callback after CARemoteLayerServer setup completes in showGui()
Verified signature9788b5f -
fix: send gui_ready notification after showGui — use callback from HelperPluginHost to IPC
Verified signatureHelperPluginHost now has onGuiCreated callback. HelperIPC sets it. When showGui() finishes creating the editor + registering the layer, it calls onGuiCreated which triggers sendGuiReady with port name + size.242769f -
fix: use setLayerPortName() instead of direct member access
Verified signaturec151d02 -
fix: add setLayerPortName() public method (layerPortName is private)
Verified signature7e3323d -
Upload Source/Plugin/Blocklist.h
Verified signature2224b8a -
remove old files replaced by .mm versions + Blocklist (now in PluginBridgeProcessor.h)
Verified signature4ca2875 -
Upload Source/Plugin/McpServer.cpp
Verified signaturea4fe44e -
Upload Source/Plugin/McpServer.h
Verified signaturee5f329d -
Upload Source/Helper/HelperIPC.cpp
Verified signature8aeb4e8 -
Upload Source/Helper/HelperIPC.h
Verified signature6c4aa19 -
Upload Source/Plugin/HelperConnection.cpp
Verified signature8335f9f -
Upload Source/Plugin/HelperConnection.h
Verified signature24a3c7f -
Upload Source/Plugin/PluginBridgeEditor.mm
Verified signature6063997 -
Upload Source/Plugin/PluginBridgeEditor.h
Verified signatured966811 -
Upload Source/Plugin/PluginBridgeProcessor.cpp
Verified signature3e55272 -
Upload Source/Plugin/PluginBridgeProcessor.h
Verified signature590be7d -
Upload Source/Helper/main.cpp
Verified signature22d14fd -
Upload Source/Helper/HelperPluginHost.mm
Verified signature0e80263 -
Upload Source/Helper/HelperPluginHost.h
Verified signatureef91ceb -
Upload Source/Shared/Constants.h
Verified signature475c9dd -
v0.4: CARemoteLayerServer architecture — crash-safe + GUI inside Ableton window
Verified signatureCOMPLETE REWRITE to proper solution: - Plugin runs in Helper process (crash-safe, like v0.2) - GUI renders in Helper via CARemoteLayerServer - PluginBridge.vst3 displays it via CARemoteLayerClient (CALayer inside its own editor) - Mach port transferred via NSMachBootstrapServer (named port per PID) - Mouse/keyboard events forwarded from host → helper via Unix socket IPC - Audio routes via shared memory (same as v0.2) This gives BOTH crash safety AND GUI inside Ableton's window (including fullscreen). Based on: Apple's CARemoteLayerServer/Client public API (macOS 10.7+) Reference: krevis/RemoteLayerDemo on GitHub"4ad264f -
fix: Blocklist path corrected to ~/Library/PluginBridge/ (where JUCE actually writes)"
Verified signatureb1feaca -
fix: findHelperBinary looks for .app bundle, not bare executable
Verified signature9e02f23 -
fix: Helper test-load — handle paths with spaces + allow message loop to run
Verified signatureBug 1: paths with spaces got split by tokenizer. Fix: join all args after --test. Bug 2: some plugins need the JUCE message loop to finish loading (VST3 validation). Fix: use a Timer to delay quit, giving the plugin time to initialize.379e9dd -
implement Helper test-load: spawns Helper before in-process load, blocks crashy plugins
Verified signatureNow loadPlugin() does: 1. Check blocklist → skip if blocked 2. Spawn PluginBridgeHelper --test '/path' → wait for exit 3. Exit code 0 → safe → load in-process 4. Exit code != 0 or crash → add to blocklist → show error → Ableton stays alive This prevents Kickstart 2 / Ozone 12 / any crashy plugin from ever crashing Ableton. The Helper takes the hit instead.767fa15 -
fix: add showingError bool to editor header
Verified signature224d9fb -
fix: replace getColour() with bool flag (Label has no getColour in JUCE 8)
Verified signaturec0c12b8 -
fix: add TestResult enum to header (was in .cpp but missing from .h)
Verified signature1066aac -
Upload Source/Helper/HelperPluginHost.cpp
Verified signatureddb115b -
Upload Source/Helper/HelperPluginHost.h
Verified signature915497a -
Upload Source/Helper/main.cpp
Verified signaturef3db0f3 -
Upload Source/Plugin/McpServer.cpp
Verified signaturebbd0e6f -
Upload Source/Plugin/McpServer.h
Verified signatureab55e95 -
Upload Source/Plugin/Blocklist.h
Verified signature377833b -
Upload Source/Plugin/PluginBridgeEditor.cpp
Verified signature01a8444 -
Upload Source/Plugin/PluginBridgeEditor.h
Verified signature9f7698e -
Upload Source/Plugin/PluginBridgeProcessor.cpp
Verified signature06d413f -
NEW ARCHITECTURE: In-process hosting + Helper as safety tester + embedded GUI
Verified signatureCOMPLETE REWRITE — new approach: - Plugin loads IN-PROCESS (inside Ableton) like SnappySnap - GUI shows inside PluginBridge's own editor (no separate window) - Helper process ONLY used to test if a plugin is safe before loading - Blocklist persists to disk — unsafe plugins greyed out - Shared memory / semaphores / audio routing via IPC all removed Files changed: - Source/Plugin/PluginBridgeProcessor.h (new: in-process hosting) - Source/Plugin/PluginBridgeProcessor.cpp (new: direct processBlock) - Source/Plugin/PluginBridgeEditor.h (new: embeds plugin GUI) - Source/Plugin/PluginBridgeEditor.cpp (new: resizable, embedded editor) - Source/Plugin/McpServer.h (simplified: talks to processor directly) - Source/Plugin/McpServer.cpp (simplified: no helper dependency) - Source/Plugin/Blocklist.h (NEW: persistent blocklist) - Source/Plugin/PluginTestRunner.h (NEW: spawns helper to test-load) - Source/Plugin/PluginTestRunner.cpp (NEW) - Source/Helper/main.cpp (simplified: test mode only) - Sourc…42bb859 -
fix: restore setAlwaysOnTop(true) — fixes GUI opening in separate space in fullscreen
Verified signatureRoot cause: commit 0632681 removed setAlwaysOnTop(true) and replaced it with manual objc_msgSend level tricks. Those tricks don't keep the window in the same Space as Ableton when fullscreen. Fix: put back setAlwaysOnTop(true) + keep the X button fix (closeButtonPressed hides window instead of quitting). Removed all objc_msgSend hacks.efff31a -
revert main.cpp — remove NSApplicationActivationPolicyAccessory (this broke the fullscreen behavior)
Verified signatureThe original code had NO activation policy override. macOS was showing the Helper window in Ableton's Space by default. Adding Accessory policy caused macOS to treat it differently and put it in a separate Space. Going back to the original main.cpp that was working before the close-button fix.cb954f1 -
STOP — revert HelperPluginHost to last known working state (GUI in Helper but with original window behavior before all my 'fixes')
Verified signatureI've been making this worse. The original code worked — GUI opened inside Ableton's window. The problem started when close-button fix changed window behavior. Need to go back to what worked and make minimal close-button fix only."a904c0b -
fix: show plugin GUI in-process (inside Ableton window) not from Helper
Verified signatureROOT CAUSE: Moving GUI to Helper process broke it. macOS treats Helper as separate app → opens in different Space when fullscreen. SOLUTION: PluginBridge.vst3 (in-process) loads a GUI-only plugin instance. This instance doesn't process audio — it's only for displaying the editor. Ableton manages it as a normal plugin window (same as Pro-Q 4 native). Parameter sync: GUI instance ↔ Helper via IPC (bidirectional). - User moves knob on GUI → notify Helper → Helper updates real instance - MCP/automation changes param on Helper → notify Plugin → update GUI instance Helper no longer shows any GUI window.8ab499b