File size: 16,783 Bytes
ea39c0e | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 | use std::sync::Arc;
use std::sync::atomic::AtomicUsize;
use std::sync::atomic::Ordering;
use codex_exec_server::EnvironmentReadyInfo;
use codex_exec_server::ExecServerError;
use codex_exec_server::NoiseChannelPublicKey;
use codex_exec_server::NoiseRendezvousConnectBundle;
use codex_exec_server::NoiseRendezvousConnectProvider;
use codex_exec_server_test_support::environment_manager_without_environments;
use codex_protocol::capabilities::CapabilityRootLocation;
use codex_protocol::capabilities::SelectedCapabilityRoot;
use codex_utils_path_uri::PathUri;
use futures::FutureExt;
use futures::future::BoxFuture;
use futures::poll;
use pretty_assertions::assert_eq;
#[derive(Default)]
struct FailingNoiseConnectProvider {
calls: AtomicUsize,
}
impl FailingNoiseConnectProvider {
fn calls(&self) -> usize {
self.calls.load(Ordering::Relaxed)
}
}
impl NoiseRendezvousConnectProvider for FailingNoiseConnectProvider {
fn connect_bundle(
&self,
_: NoiseChannelPublicKey,
) -> BoxFuture<'_, Result<NoiseRendezvousConnectBundle, ExecServerError>> {
self.calls.fetch_add(1, Ordering::Relaxed);
async {
Err(ExecServerError::Protocol(
"test Noise provider called".to_string(),
))
}
.boxed()
}
}
fn ready_info(root_id: &str, environment_id: &str) -> anyhow::Result<EnvironmentReadyInfo> {
Ok(EnvironmentReadyInfo {
selected_capability_roots: vec![SelectedCapabilityRoot {
id: root_id.to_string(),
location: CapabilityRootLocation::Environment {
environment_id: environment_id.to_string(),
path: PathUri::parse("file:///plugins/root")?,
},
}],
})
}
#[tokio::test]
async fn readiness_before_materialization_creates_the_stable_environment() -> anyhow::Result<()> {
let manager = environment_manager_without_environments();
let readiness_provider = Arc::new(FailingNoiseConnectProvider::default());
let materialization_provider = Arc::new(FailingNoiseConnectProvider::default());
let selected = ready_info("selected-root", "tools")?;
let ready = manager
.report_environment_provisioning_status(
"tools".to_string(),
Ok(selected.clone()),
readiness_provider.clone(),
)?
.expect("readiness report should create the environment");
let materialized = manager.materialize_pending_noise_environment(
"tools".to_string(),
materialization_provider.clone(),
)?;
assert!(Arc::ptr_eq(&ready, &materialized));
assert_eq!(
ready.selected_capability_roots(),
selected.selected_capability_roots
);
let error = ready.wait_until_ready().await.unwrap_err();
assert!(error.to_string().contains("test Noise provider called"));
assert_eq!(readiness_provider.calls(), 1);
assert_eq!(materialization_provider.calls(), 0);
Ok(())
}
#[tokio::test]
async fn materialize_then_report_ready_reuses_the_pending_environment() -> anyhow::Result<()> {
let manager = environment_manager_without_environments();
let pending_provider = Arc::new(FailingNoiseConnectProvider::default());
let pending = manager
.materialize_pending_noise_environment("tools".to_string(), pending_provider.clone())?;
assert_eq!(pending.last_ready_info(), None);
let mut pending_readiness = Box::pin(pending.wait_until_ready());
assert!(poll!(&mut pending_readiness).is_pending());
let ready = manager
.report_environment_provisioning_status(
"tools".to_string(),
Ok(ready_info("selected-root", "tools")?),
Arc::new(FailingNoiseConnectProvider::default()),
)?
.expect("provisioning report should apply to the pending environment");
assert!(Arc::ptr_eq(&pending, &ready));
let error = pending_readiness.await.unwrap_err();
assert!(error.to_string().contains("test Noise provider called"));
assert_eq!(pending_provider.calls(), 1);
Ok(())
}
#[tokio::test]
async fn ordinary_environment_ignores_provisioning_reports() -> anyhow::Result<()> {
let manager = environment_manager_without_environments();
manager.upsert_environment(
"tools".to_string(),
"ws://127.0.0.1:1".to_string(),
Some(std::time::Duration::from_millis(1)),
)?;
let existing_environment = manager
.get_environment("tools")
.expect("existing environment");
let reported = manager.report_environment_provisioning_status(
"tools".to_string(),
Ok(ready_info("selected-root", "tools")?),
Arc::new(FailingNoiseConnectProvider::default()),
)?;
let current_environment = manager
.get_environment("tools")
.expect("current environment");
assert!(Arc::ptr_eq(&existing_environment, ¤t_environment));
assert!(reported.is_none());
assert!(existing_environment.selected_capability_roots().is_empty());
assert_eq!(existing_environment.last_ready_info(), None);
Ok(())
}
#[tokio::test]
async fn failure_before_materialization_is_reported_without_connecting() -> anyhow::Result<()> {
let manager = environment_manager_without_environments();
let provider = Arc::new(FailingNoiseConnectProvider::default());
let failed = manager
.report_environment_provisioning_status(
"tools".to_string(),
Err("provisioning failed".to_string()),
provider.clone(),
)?
.expect("failure report should create the environment");
let materialized = manager.materialize_pending_noise_environment(
"tools".to_string(),
Arc::new(FailingNoiseConnectProvider::default()),
)?;
assert!(Arc::ptr_eq(&failed, &materialized));
assert_eq!(
failed.status().await,
codex_exec_server::EnvironmentObservedStatus::Disconnected {
error: "environment unavailable: provisioning failed".to_string(),
}
);
let error = failed.wait_until_ready().await.unwrap_err();
assert!(error.to_string().ends_with("provisioning failed"));
assert!(failed.startup_finished());
assert_eq!(provider.calls(), 0);
Ok(())
}
#[tokio::test]
async fn failure_releases_the_existing_pending_environment_without_connecting() -> anyhow::Result<()>
{
let manager = environment_manager_without_environments();
let provider = Arc::new(FailingNoiseConnectProvider::default());
let pending =
manager.materialize_pending_noise_environment("tools".to_string(), provider.clone())?;
let reported = manager
.report_environment_provisioning_status(
"tools".to_string(),
Err("provisioning failed".to_string()),
provider.clone(),
)?
.expect("failure report should apply to the pending environment");
assert!(Arc::ptr_eq(&pending, &reported));
let error = pending.wait_until_ready().await.unwrap_err();
assert!(error.to_string().ends_with("provisioning failed"));
assert_eq!(provider.calls(), 0);
Ok(())
}
#[tokio::test]
async fn repeated_failure_preserves_the_first_error_until_ready() -> anyhow::Result<()> {
let manager = environment_manager_without_environments();
let provider = Arc::new(FailingNoiseConnectProvider::default());
let failed = manager
.report_environment_provisioning_status(
"tools".to_string(),
Err("first failure".to_string()),
provider.clone(),
)?
.expect("failure report should create the environment");
let repeated = manager
.report_environment_provisioning_status(
"tools".to_string(),
Err("different failure".to_string()),
provider.clone(),
)?
.expect("repeated failure should be idempotent");
assert!(Arc::ptr_eq(&failed, &repeated));
let error = failed.wait_until_ready().await.unwrap_err();
assert!(error.to_string().ends_with("first failure"));
assert_eq!(provider.calls(), 0);
let invalid_ready_error = manager
.report_environment_provisioning_status(
"tools".to_string(),
Ok(ready_info("selected-root", "other")?),
provider.clone(),
)
.unwrap_err();
assert!(matches!(invalid_ready_error, ExecServerError::Protocol(_)));
assert_eq!(
failed.wait_until_ready().await.unwrap_err().to_string(),
error.to_string()
);
assert!(failed.selected_capability_roots().is_empty());
assert_eq!(failed.last_ready_info(), None);
assert_eq!(provider.calls(), 0);
let selected = ready_info("selected-root", "tools")?;
let ready = manager
.report_environment_provisioning_status(
"tools".to_string(),
Ok(selected.clone()),
provider.clone(),
)?
.expect("successful provisioning should recover the same environment");
assert!(Arc::ptr_eq(&failed, &ready));
assert_eq!(failed.last_ready_info().as_deref(), Some(&selected));
assert_eq!(
failed.selected_capability_roots(),
selected.selected_capability_roots
);
let error = failed.wait_until_ready().await.unwrap_err();
assert!(error.to_string().contains("test Noise provider called"));
assert_eq!(provider.calls(), 1);
Ok(())
}
#[tokio::test]
async fn ready_environment_rejects_a_later_failure() -> anyhow::Result<()> {
let manager = environment_manager_without_environments();
let provider = Arc::new(FailingNoiseConnectProvider::default());
let ready = manager
.report_environment_provisioning_status(
"tools".to_string(),
Ok(ready_info("selected-root", "tools")?),
provider.clone(),
)?
.expect("ready report should create the environment");
let error = manager
.report_environment_provisioning_status(
"tools".to_string(),
Err("late failure".to_string()),
provider,
)
.unwrap_err();
assert!(error.to_string().contains("already ready"));
assert_eq!(ready.selected_capability_roots().len(), 1);
Ok(())
}
#[tokio::test]
async fn existing_environment_accepts_matching_readiness() -> anyhow::Result<()> {
let manager = environment_manager_without_environments();
let provider = Arc::new(FailingNoiseConnectProvider::default());
let ready_info = ready_info("selected-root", "tools")?;
let environment = manager
.report_environment_provisioning_status(
"tools".to_string(),
Ok(ready_info.clone()),
provider.clone(),
)?
.expect("readiness report should create the environment");
manager.report_environment_provisioning_status(
"tools".to_string(),
Ok(ready_info.clone()),
provider,
)?;
assert_eq!(
environment.selected_capability_roots(),
ready_info.selected_capability_roots
);
Ok(())
}
#[tokio::test]
async fn existing_environment_overwrites_reported_readiness() -> anyhow::Result<()> {
let manager = environment_manager_without_environments();
let provider = Arc::new(FailingNoiseConnectProvider::default());
let environment = manager
.report_environment_provisioning_status(
"tools".to_string(),
Ok(ready_info("selected-root", "tools")?),
provider.clone(),
)?
.expect("readiness report should create the environment");
let updated_ready_info = ready_info("different-root", "tools")?;
manager.report_environment_provisioning_status(
"tools".to_string(),
Ok(updated_ready_info.clone()),
provider,
)?;
assert_eq!(
environment.selected_capability_roots(),
updated_ready_info.selected_capability_roots
);
assert!(Arc::ptr_eq(
&environment,
&manager.get_environment("tools").expect("environment")
));
Ok(())
}
#[tokio::test]
async fn last_ready_info_preserves_snapshots_through_replacement_and_clear() -> anyhow::Result<()> {
let manager = environment_manager_without_environments();
let provider = Arc::new(FailingNoiseConnectProvider::default());
let selected = ready_info("selected-root", "tools")?;
let environment = manager
.report_environment_provisioning_status(
"tools".to_string(),
Ok(selected.clone()),
provider.clone(),
)?
.expect("readiness report should create the environment");
let snapshot = environment.last_ready_info();
assert_eq!(snapshot.as_deref(), Some(&selected));
for replacement in [
ready_info("different-root", "tools")?,
EnvironmentReadyInfo::default(),
] {
manager.report_environment_provisioning_status(
"tools".to_string(),
Ok(replacement.clone()),
provider.clone(),
)?;
assert_eq!(environment.last_ready_info().as_deref(), Some(&replacement));
assert_eq!(snapshot.as_deref(), Some(&selected));
}
let error = manager
.report_environment_provisioning_status(
"tools".to_string(),
Ok(ready_info("invalid-root", "other")?),
provider.clone(),
)
.unwrap_err();
assert!(matches!(error, ExecServerError::Protocol(_)));
assert_eq!(
environment.last_ready_info().as_deref(),
Some(&EnvironmentReadyInfo::default())
);
assert_eq!(provider.calls(), 0);
Ok(())
}
#[tokio::test]
async fn invalid_ready_report_fails_the_provisioning_gate() -> anyhow::Result<()> {
let manager = environment_manager_without_environments();
let provider = Arc::new(FailingNoiseConnectProvider::default());
let environment =
manager.materialize_pending_noise_environment("tools".to_string(), provider.clone())?;
let readiness = Box::pin(environment.wait_until_ready());
let error = manager
.report_environment_provisioning_status(
"tools".to_string(),
Ok(ready_info("selected-root", "other")?),
provider.clone(),
)
.unwrap_err();
assert!(matches!(error, ExecServerError::Protocol(_)));
let readiness_error = readiness.await.unwrap_err();
assert!(readiness_error.to_string().contains(&error.to_string()));
assert!(environment.selected_capability_roots().is_empty());
assert_eq!(provider.calls(), 0);
let selected = ready_info("selected-root", "tools")?;
let reported = manager
.report_environment_provisioning_status(
"tools".to_string(),
Ok(selected.clone()),
provider.clone(),
)?
.expect("a corrected ready report should recover provisioning");
assert!(Arc::ptr_eq(&environment, &reported));
assert_eq!(
environment.selected_capability_roots(),
selected.selected_capability_roots
);
assert_eq!(provider.calls(), 0);
Ok(())
}
#[tokio::test]
async fn duplicate_materialization_reuses_the_pending_environment() -> anyhow::Result<()> {
let manager = environment_manager_without_environments();
let provider = Arc::new(FailingNoiseConnectProvider::default());
let environment =
manager.materialize_pending_noise_environment("tools".to_string(), provider.clone())?;
let replacement_provider = Arc::new(FailingNoiseConnectProvider::default());
let current = manager
.materialize_pending_noise_environment("tools".to_string(), replacement_provider.clone())?;
assert!(Arc::ptr_eq(&environment, ¤t));
assert_eq!(provider.calls(), 0);
assert_eq!(replacement_provider.calls(), 0);
Ok(())
}
#[tokio::test]
async fn deferred_materialization_conflicts_with_an_existing_ordinary_environment()
-> anyhow::Result<()> {
let manager = environment_manager_without_environments();
manager.upsert_environment(
"tools".to_string(),
"ws://127.0.0.1:1".to_string(),
Some(std::time::Duration::from_millis(1)),
)?;
let existing_environment = manager.get_environment("tools").expect("environment");
let deferred_provider = Arc::new(FailingNoiseConnectProvider::default());
let error = manager
.materialize_pending_noise_environment("tools".to_string(), deferred_provider.clone())
.unwrap_err();
assert!(matches!(
error,
ExecServerError::ProvisioningModeConflict { environment_id }
if environment_id == "tools"
));
let current_environment = manager
.get_environment("tools")
.expect("ordinary environment should remain registered");
assert!(Arc::ptr_eq(&existing_environment, ¤t_environment));
assert_eq!(deferred_provider.calls(), 0);
Ok(())
}
|