File size: 6,866 Bytes
84aa3bf
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
/**
 * @license
 * Copyright 2026 Google LLC
 * SPDX-License-Identifier: Apache-2.0
 */

import {
  describe,
  it,
  expect,
  vi,
  beforeEach,
  afterEach,
  type Mocked,
} from 'vitest';
import { AcpFileSystemService } from './acpFileSystemService.js';
import type { AgentSideConnection } from '@agentclientprotocol/sdk';
import type { FileSystemService } from '@google/gemini-cli-core';
import os from 'node:os';

vi.mock('node:os', () => ({
  default: {
    homedir: vi.fn(),
  },
}));

describe('AcpFileSystemService', () => {
  let mockConnection: Mocked<AgentSideConnection>;
  let mockFallback: Mocked<FileSystemService>;
  let service: AcpFileSystemService;

  beforeEach(() => {
    mockConnection = {
      requestPermission: vi.fn(),
      sessionUpdate: vi.fn(),
      writeTextFile: vi.fn(),
      readTextFile: vi.fn(),
    } as unknown as Mocked<AgentSideConnection>;
    mockFallback = {
      readTextFile: vi.fn(),
      writeTextFile: vi.fn(),
    };
    vi.mocked(os.homedir).mockReturnValue('/home/user');
  });

  afterEach(() => {
    vi.restoreAllMocks();
  });

  describe('readTextFile', () => {
    it.each([
      {
        capability: true,
        path: '/path/to/file',
        desc: 'connection if capability exists and file is inside root',
        setup: () => {
          mockConnection.readTextFile.mockResolvedValue({ content: 'content' });
        },
        verify: () => {
          expect(mockConnection.readTextFile).toHaveBeenCalledWith({
            path: '/path/to/file',
            sessionId: 'session-1',
          });
          expect(mockFallback.readTextFile).not.toHaveBeenCalled();
        },
      },
      {
        capability: false,
        path: '/path/to/file',
        desc: 'fallback if capability missing',
        setup: () => {
          mockFallback.readTextFile.mockResolvedValue('content');
        },
        verify: () => {
          expect(mockFallback.readTextFile).toHaveBeenCalledWith(
            '/path/to/file',
          );
          expect(mockConnection.readTextFile).not.toHaveBeenCalled();
        },
      },
      {
        capability: true,
        path: '/outside/file',
        desc: 'fallback if capability exists but file is outside root',
        setup: () => {
          mockFallback.readTextFile.mockResolvedValue('content');
        },
        verify: () => {
          expect(mockFallback.readTextFile).toHaveBeenCalledWith(
            '/outside/file',
          );
          expect(mockConnection.readTextFile).not.toHaveBeenCalled();
        },
      },
      {
        capability: true,
        path: '/home/user/.gemini/tmp/file.md',
        root: '/home/user',
        desc: 'fallback if file is inside global gemini dir, even if root overlaps',
        setup: () => {
          mockFallback.readTextFile.mockResolvedValue('content');
        },
        verify: () => {
          expect(mockFallback.readTextFile).toHaveBeenCalledWith(
            '/home/user/.gemini/tmp/file.md',
          );
          expect(mockConnection.readTextFile).not.toHaveBeenCalled();
        },
      },
    ])(
      'should use $desc',
      async ({ capability, path, root, setup, verify }) => {
        service = new AcpFileSystemService(
          mockConnection,
          'session-1',
          { readTextFile: capability, writeTextFile: true },
          mockFallback,
          root || '/path/to',
        );
        setup();

        const result = await service.readTextFile(path);

        expect(result).toBe('content');
        verify();
      },
    );

    it('should throw normalized ENOENT error when readTextFile encounters "Resource not found"', async () => {
      service = new AcpFileSystemService(
        mockConnection,
        'session-1',
        { readTextFile: true, writeTextFile: true },
        mockFallback,
        '/path/to',
      );
      mockConnection.readTextFile.mockRejectedValue(
        new Error('Resource not found for document'),
      );

      await expect(
        service.readTextFile('/path/to/missing'),
      ).rejects.toMatchObject({
        code: 'ENOENT',
        message: 'Resource not found for document',
      });
    });
  });

  describe('writeTextFile', () => {
    it.each([
      {
        capability: true,
        path: '/path/to/file',
        desc: 'connection if capability exists and file is inside root',
        verify: () => {
          expect(mockConnection.writeTextFile).toHaveBeenCalledWith({
            path: '/path/to/file',
            content: 'content',
            sessionId: 'session-1',
          });
          expect(mockFallback.writeTextFile).not.toHaveBeenCalled();
        },
      },
      {
        capability: false,
        path: '/path/to/file',
        desc: 'fallback if capability missing',
        verify: () => {
          expect(mockFallback.writeTextFile).toHaveBeenCalledWith(
            '/path/to/file',
            'content',
          );
          expect(mockConnection.writeTextFile).not.toHaveBeenCalled();
        },
      },
      {
        capability: true,
        path: '/outside/file',
        desc: 'fallback if capability exists but file is outside root',
        verify: () => {
          expect(mockFallback.writeTextFile).toHaveBeenCalledWith(
            '/outside/file',
            'content',
          );
          expect(mockConnection.writeTextFile).not.toHaveBeenCalled();
        },
      },
      {
        capability: true,
        path: '/home/user/.gemini/tmp/file.md',
        root: '/home/user',
        desc: 'fallback if file is inside global gemini dir, even if root overlaps',
        verify: () => {
          expect(mockFallback.writeTextFile).toHaveBeenCalledWith(
            '/home/user/.gemini/tmp/file.md',
            'content',
          );
          expect(mockConnection.writeTextFile).not.toHaveBeenCalled();
        },
      },
    ])('should use $desc', async ({ capability, path, root, verify }) => {
      service = new AcpFileSystemService(
        mockConnection,
        'session-1',
        { writeTextFile: capability, readTextFile: true },
        mockFallback,
        root || '/path/to',
      );

      await service.writeTextFile(path, 'content');

      verify();
    });

    it('should throw normalized ENOENT error when writeTextFile encounters "Resource not found"', async () => {
      service = new AcpFileSystemService(
        mockConnection,
        'session-1',
        { readTextFile: true, writeTextFile: true },
        mockFallback,
        '/path/to',
      );
      mockConnection.writeTextFile.mockRejectedValue(
        new Error('Resource not found for directory'),
      );

      await expect(
        service.writeTextFile('/path/to/missing', 'content'),
      ).rejects.toMatchObject({
        code: 'ENOENT',
        message: 'Resource not found for directory',
      });
    });
  });
});