File size: 15,704 Bytes
84aa3bf | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 | /**
* @license
* Copyright 2025 Google LLC
* SPDX-License-Identifier: Apache-2.0
*/
import { vi, describe, it, expect, beforeEach } from 'vitest';
import type { Config } from '@google/gemini-cli-core';
// --- Mocks (hoisted) ---
const mockInitActivityLogger = vi.hoisted(() => vi.fn());
const mockAddNetworkTransport = vi.hoisted(() => vi.fn());
type Listener = (...args: unknown[]) => void;
const { MockWebSocket } = vi.hoisted(() => {
class MockWebSocket {
close = vi.fn();
url: string;
static instances: MockWebSocket[] = [];
private listeners = new Map<string, Listener[]>();
constructor(url: string) {
this.url = url;
MockWebSocket.instances.push(this);
}
on(event: string, fn: Listener) {
const fns = this.listeners.get(event) || [];
fns.push(fn);
this.listeners.set(event, fns);
return this;
}
emit(event: string, ...args: unknown[]) {
for (const fn of this.listeners.get(event) || []) {
fn(...args);
}
}
simulateOpen() {
this.emit('open');
}
simulateError() {
this.emit('error', new Error('ECONNREFUSED'));
}
}
return { MockWebSocket };
});
const mockDevToolsInstance = vi.hoisted(() => ({
start: vi.fn(),
stop: vi.fn(),
getPort: vi.fn(),
}));
const mockActivityLoggerInstance = vi.hoisted(() => ({
disableNetworkLogging: vi.fn(),
enableNetworkLogging: vi.fn(),
drainBufferedLogs: vi.fn().mockReturnValue({ network: [], console: [] }),
}));
vi.mock('./activityLogger.js', () => ({
initActivityLogger: mockInitActivityLogger,
addNetworkTransport: mockAddNetworkTransport,
ActivityLogger: {
getInstance: () => mockActivityLoggerInstance,
},
}));
const mockShouldLaunchBrowser = vi.hoisted(() => vi.fn(() => true));
const mockOpenBrowserSecurely = vi.hoisted(() =>
vi.fn(() => Promise.resolve()),
);
vi.mock('@google/gemini-cli-core', () => ({
debugLogger: {
log: vi.fn(),
debug: vi.fn(),
error: vi.fn(),
warn: vi.fn(),
},
shouldLaunchBrowser: mockShouldLaunchBrowser,
openBrowserSecurely: mockOpenBrowserSecurely,
}));
vi.mock('ws', () => ({
default: MockWebSocket,
}));
vi.mock('@google/gemini-cli-devtools', () => ({
DevTools: {
getInstance: () => mockDevToolsInstance,
},
}));
// --- Import under test (after mocks) ---
import {
setupInitialActivityLogger,
startDevToolsServer,
toggleDevToolsPanel,
resetForTesting,
} from './devtoolsService.js';
function createMockConfig(overrides: Record<string, unknown> = {}) {
return {
isInteractive: vi.fn().mockReturnValue(true),
getSessionId: vi.fn().mockReturnValue('test-session'),
getDebugMode: vi.fn().mockReturnValue(false),
storage: { getProjectTempLogsDir: vi.fn().mockReturnValue('/tmp/logs') },
...overrides,
} as unknown as Config;
}
describe('devtoolsService', () => {
beforeEach(() => {
vi.clearAllMocks();
MockWebSocket.instances = [];
resetForTesting();
delete process.env['GEMINI_CLI_ACTIVITY_LOG_TARGET'];
});
describe('setupInitialActivityLogger', () => {
it('stays in buffer mode (no probe attempted)', () => {
const config = createMockConfig();
setupInitialActivityLogger(config);
expect(mockInitActivityLogger).toHaveBeenCalledWith(config, {
mode: 'buffer',
});
expect(mockAddNetworkTransport).not.toHaveBeenCalled();
// No WebSocket probe on startup
expect(MockWebSocket.instances.length).toBe(0);
});
it('initializes in file mode when target env var is set', () => {
process.env['GEMINI_CLI_ACTIVITY_LOG_TARGET'] = '/tmp/test.jsonl';
const config = createMockConfig();
setupInitialActivityLogger(config);
expect(mockInitActivityLogger).toHaveBeenCalledWith(config, {
mode: 'file',
filePath: '/tmp/test.jsonl',
});
// No probe attempted
expect(MockWebSocket.instances.length).toBe(0);
});
it('does nothing in file mode when config.storage is missing', () => {
process.env['GEMINI_CLI_ACTIVITY_LOG_TARGET'] = '/tmp/test.jsonl';
const config = createMockConfig({ storage: undefined });
setupInitialActivityLogger(config);
expect(mockInitActivityLogger).not.toHaveBeenCalled();
expect(MockWebSocket.instances.length).toBe(0);
});
});
describe('startDevToolsServer', () => {
it('starts new server when none exists and enables logging', async () => {
const config = createMockConfig();
mockDevToolsInstance.start.mockResolvedValue('http://127.0.0.1:25417');
mockDevToolsInstance.getPort.mockReturnValue(25417);
const promise = startDevToolsServer(config);
await vi.waitFor(() => expect(MockWebSocket.instances.length).toBe(1));
MockWebSocket.instances[0].simulateError();
const url = await promise;
expect(url).toBe('http://localhost:25417');
expect(mockAddNetworkTransport).toHaveBeenCalledWith(
config,
'127.0.0.1',
25417,
expect.any(Function),
);
expect(
mockActivityLoggerInstance.enableNetworkLogging,
).toHaveBeenCalled();
});
it('connects to existing server if one is found', async () => {
const config = createMockConfig();
const promise = startDevToolsServer(config);
await vi.waitFor(() => expect(MockWebSocket.instances.length).toBe(1));
MockWebSocket.instances[0].simulateOpen();
const url = await promise;
expect(url).toBe('http://localhost:25417');
expect(mockAddNetworkTransport).toHaveBeenCalled();
expect(
mockActivityLoggerInstance.enableNetworkLogging,
).toHaveBeenCalled();
});
it('deduplicates concurrent calls (returns same promise)', async () => {
const config = createMockConfig();
mockDevToolsInstance.start.mockResolvedValue('http://127.0.0.1:25417');
mockDevToolsInstance.getPort.mockReturnValue(25417);
const promise1 = startDevToolsServer(config);
const promise2 = startDevToolsServer(config);
expect(promise1).toBe(promise2);
await vi.waitFor(() => expect(MockWebSocket.instances.length).toBe(1));
MockWebSocket.instances[0].simulateError();
const [url1, url2] = await Promise.all([promise1, promise2]);
expect(url1).toBe('http://localhost:25417');
expect(url2).toBe('http://localhost:25417');
// Only one probe + one server start
expect(mockAddNetworkTransport).toHaveBeenCalledTimes(1);
});
it('throws when DevTools server fails to start', async () => {
const config = createMockConfig();
mockDevToolsInstance.start.mockRejectedValue(
new Error('MODULE_NOT_FOUND'),
);
const promise = startDevToolsServer(config);
// Probe fails first
await vi.waitFor(() => expect(MockWebSocket.instances.length).toBe(1));
MockWebSocket.instances[0].simulateError();
await expect(promise).rejects.toThrow('MODULE_NOT_FOUND');
expect(mockAddNetworkTransport).not.toHaveBeenCalled();
});
it('allows retry after server start failure', async () => {
const config = createMockConfig();
mockDevToolsInstance.start.mockRejectedValueOnce(
new Error('MODULE_NOT_FOUND'),
);
const promise1 = startDevToolsServer(config);
// Probe fails
await vi.waitFor(() => expect(MockWebSocket.instances.length).toBe(1));
MockWebSocket.instances[0].simulateError();
await expect(promise1).rejects.toThrow('MODULE_NOT_FOUND');
// Second attempt should work (not return the cached rejected promise)
mockDevToolsInstance.start.mockResolvedValue('http://127.0.0.1:25417');
mockDevToolsInstance.getPort.mockReturnValue(25417);
const promise2 = startDevToolsServer(config);
await vi.waitFor(() => expect(MockWebSocket.instances.length).toBe(2));
MockWebSocket.instances[1].simulateError();
const url = await promise2;
expect(url).toBe('http://localhost:25417');
expect(mockAddNetworkTransport).toHaveBeenCalled();
});
it('short-circuits on second F12 after successful start', async () => {
const config = createMockConfig();
mockDevToolsInstance.start.mockResolvedValue('http://127.0.0.1:25417');
mockDevToolsInstance.getPort.mockReturnValue(25417);
const promise1 = startDevToolsServer(config);
await vi.waitFor(() => expect(MockWebSocket.instances.length).toBe(1));
MockWebSocket.instances[0].simulateError();
const url1 = await promise1;
expect(url1).toBe('http://localhost:25417');
mockAddNetworkTransport.mockClear();
mockDevToolsInstance.start.mockClear();
// Second call should short-circuit via connectedUrl
const url2 = await startDevToolsServer(config);
expect(url2).toBe('http://localhost:25417');
expect(mockAddNetworkTransport).not.toHaveBeenCalled();
expect(mockDevToolsInstance.start).not.toHaveBeenCalled();
});
it('stops own server and connects to existing when losing port race', async () => {
const config = createMockConfig();
// Server starts on a different port (lost the race)
mockDevToolsInstance.start.mockResolvedValue('http://127.0.0.1:25418');
mockDevToolsInstance.getPort.mockReturnValue(25418);
const promise = startDevToolsServer(config);
// First: probe for existing server (fails)
await vi.waitFor(() => {
expect(MockWebSocket.instances.length).toBe(1);
});
MockWebSocket.instances[0].simulateError();
// Second: after starting, probes the default port winner
await vi.waitFor(() => {
expect(MockWebSocket.instances.length).toBe(2);
});
// Winner is alive
MockWebSocket.instances[1].simulateOpen();
const url = await promise;
expect(mockDevToolsInstance.stop).toHaveBeenCalled();
expect(url).toBe('http://localhost:25417');
expect(mockAddNetworkTransport).toHaveBeenCalledWith(
config,
'127.0.0.1',
25417,
expect.any(Function),
);
});
it('keeps own server when winner is not responding', async () => {
const config = createMockConfig();
mockDevToolsInstance.start.mockResolvedValue('http://127.0.0.1:25418');
mockDevToolsInstance.getPort.mockReturnValue(25418);
const promise = startDevToolsServer(config);
// Probe for existing (fails)
await vi.waitFor(() => {
expect(MockWebSocket.instances.length).toBe(1);
});
MockWebSocket.instances[0].simulateError();
// Probe the winner (also fails)
await vi.waitFor(() => {
expect(MockWebSocket.instances.length).toBe(2);
});
MockWebSocket.instances[1].simulateError();
const url = await promise;
expect(mockDevToolsInstance.stop).not.toHaveBeenCalled();
expect(url).toBe('http://localhost:25418');
expect(mockAddNetworkTransport).toHaveBeenCalledWith(
config,
'127.0.0.1',
25418,
expect.any(Function),
);
});
});
describe('handlePromotion (via startDevToolsServer)', () => {
it('caps promotion attempts at MAX_PROMOTION_ATTEMPTS', async () => {
const config = createMockConfig();
mockDevToolsInstance.start.mockResolvedValue('http://127.0.0.1:25417');
mockDevToolsInstance.getPort.mockReturnValue(25417);
// First: set up the logger so we can grab onReconnectFailed
const promise = startDevToolsServer(config);
await vi.waitFor(() => {
expect(MockWebSocket.instances.length).toBe(1);
});
MockWebSocket.instances[0].simulateError();
await promise;
// Extract onReconnectFailed callback
const initCall = mockAddNetworkTransport.mock.calls[0];
const onReconnectFailed = initCall[3];
expect(onReconnectFailed).toBeDefined();
// Trigger promotion MAX_PROMOTION_ATTEMPTS + 1 times
// Each call should succeed (addNetworkTransport called) until cap is hit
mockAddNetworkTransport.mockClear();
await onReconnectFailed(); // attempt 1
await onReconnectFailed(); // attempt 2
await onReconnectFailed(); // attempt 3
await onReconnectFailed(); // attempt 4 — should be capped
// Only 3 calls to addNetworkTransport (capped at MAX_PROMOTION_ATTEMPTS)
expect(mockAddNetworkTransport).toHaveBeenCalledTimes(3);
});
});
describe('toggleDevToolsPanel', () => {
it('calls toggle (to close) when already open', async () => {
const config = createMockConfig();
const toggle = vi.fn();
const setOpen = vi.fn();
const promise = toggleDevToolsPanel(config, true, toggle, setOpen);
await promise;
expect(toggle).toHaveBeenCalledTimes(1);
expect(setOpen).not.toHaveBeenCalled();
});
it('does NOT call toggle or setOpen when browser opens successfully', async () => {
const config = createMockConfig();
const toggle = vi.fn();
const setOpen = vi.fn();
mockShouldLaunchBrowser.mockReturnValue(true);
mockOpenBrowserSecurely.mockResolvedValue(undefined);
mockDevToolsInstance.start.mockResolvedValue('http://127.0.0.1:25417');
mockDevToolsInstance.getPort.mockReturnValue(25417);
const promise = toggleDevToolsPanel(config, false, toggle, setOpen);
await vi.waitFor(() => expect(MockWebSocket.instances.length).toBe(1));
MockWebSocket.instances[0].simulateError();
await promise;
expect(toggle).not.toHaveBeenCalled();
expect(setOpen).not.toHaveBeenCalled();
});
it('calls setOpen when browser fails to open', async () => {
const config = createMockConfig();
const toggle = vi.fn();
const setOpen = vi.fn();
mockShouldLaunchBrowser.mockReturnValue(true);
mockOpenBrowserSecurely.mockRejectedValue(new Error('no browser'));
mockDevToolsInstance.start.mockResolvedValue('http://127.0.0.1:25417');
mockDevToolsInstance.getPort.mockReturnValue(25417);
const promise = toggleDevToolsPanel(config, false, toggle, setOpen);
await vi.waitFor(() => expect(MockWebSocket.instances.length).toBe(1));
MockWebSocket.instances[0].simulateError();
await promise;
expect(toggle).not.toHaveBeenCalled();
expect(setOpen).toHaveBeenCalledTimes(1);
});
it('calls setOpen when shouldLaunchBrowser returns false', async () => {
const config = createMockConfig();
const toggle = vi.fn();
const setOpen = vi.fn();
mockShouldLaunchBrowser.mockReturnValue(false);
mockDevToolsInstance.start.mockResolvedValue('http://127.0.0.1:25417');
mockDevToolsInstance.getPort.mockReturnValue(25417);
const promise = toggleDevToolsPanel(config, false, toggle, setOpen);
await vi.waitFor(() => expect(MockWebSocket.instances.length).toBe(1));
MockWebSocket.instances[0].simulateError();
await promise;
expect(toggle).not.toHaveBeenCalled();
expect(setOpen).toHaveBeenCalledTimes(1);
});
it('calls setOpen when DevTools server fails to start', async () => {
const config = createMockConfig();
const toggle = vi.fn();
const setOpen = vi.fn();
mockDevToolsInstance.start.mockRejectedValue(new Error('fail'));
const promise = toggleDevToolsPanel(config, false, toggle, setOpen);
await vi.waitFor(() => expect(MockWebSocket.instances.length).toBe(1));
MockWebSocket.instances[0].simulateError();
await promise;
expect(toggle).not.toHaveBeenCalled();
expect(setOpen).toHaveBeenCalledTimes(1);
});
});
});
|