File size: 6,677 Bytes
7a1ad33 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 | /**
* @license
* Copyright 2026 Google LLC
* SPDX-License-Identifier: Apache-2.0
*/
import {
describe,
it,
expect,
vi,
beforeEach,
afterEach,
type Mock,
} from 'vitest';
import { SandboxedFileSystemService } from './sandboxedFileSystemService.js';
import type {
SandboxManager,
SandboxRequest,
SandboxedCommand,
GlobalSandboxOptions,
} from './sandboxManager.js';
import { spawn, type ChildProcess } from 'node:child_process';
import { EventEmitter } from 'node:events';
import type { Writable } from 'node:stream';
import path from 'node:path';
vi.mock('node:child_process', () => ({
spawn: vi.fn(),
}));
class MockSandboxManager implements SandboxManager {
prepareCommand = vi.fn(
async (req: SandboxRequest): Promise<SandboxedCommand> => ({
program: 'sandbox.exe',
args: ['0', req.cwd, req.command, ...req.args],
env: req.env || {},
}),
);
isKnownSafeCommand(): boolean {
return false;
}
isDangerousCommand(): boolean {
return false;
}
parseDenials(): undefined {
return undefined;
}
getWorkspace(): string {
return path.resolve('/workspace');
}
getOptions(): GlobalSandboxOptions | undefined {
return {
workspace: path.resolve('/workspace'),
includeDirectories: [path.resolve('/test/cwd')],
};
}
}
describe('SandboxedFileSystemService', () => {
let sandboxManager: MockSandboxManager;
let service: SandboxedFileSystemService;
const cwd = path.resolve('/test/cwd');
beforeEach(() => {
sandboxManager = new MockSandboxManager();
service = new SandboxedFileSystemService(sandboxManager, cwd);
vi.clearAllMocks();
});
afterEach(() => {
vi.restoreAllMocks();
});
it('should read a file through the sandbox', async () => {
const mockChild = new EventEmitter() as unknown as ChildProcess;
Object.assign(mockChild, {
stdout: new EventEmitter(),
stderr: new EventEmitter(),
});
vi.mocked(spawn).mockReturnValue(mockChild);
const testFile = path.resolve('/test/cwd/file.txt');
const readPromise = service.readTextFile(testFile);
// Use setImmediate to ensure events are emitted after the promise starts executing
setImmediate(() => {
mockChild.stdout!.emit('data', Buffer.from('file content'));
mockChild.emit('close', 0);
});
const content = await readPromise;
expect(content).toBe('file content');
expect(vi.mocked(sandboxManager.prepareCommand)).toHaveBeenCalledWith(
expect.objectContaining({
command: '__read',
args: [testFile],
policy: {
allowedPaths: [testFile],
},
}),
);
expect(spawn).toHaveBeenCalledWith(
'sandbox.exe',
['0', cwd, '__read', testFile],
expect.any(Object),
);
});
it('should write a file through the sandbox', async () => {
const mockChild = new EventEmitter() as unknown as ChildProcess;
const mockStdin = new EventEmitter();
Object.assign(mockStdin, {
write: vi.fn(),
end: vi.fn(),
});
Object.assign(mockChild, {
stdin: mockStdin as unknown as Writable,
stderr: new EventEmitter(),
});
vi.mocked(spawn).mockReturnValue(mockChild);
const testFile = path.resolve('/test/cwd/file.txt');
const writePromise = service.writeTextFile(testFile, 'new content');
setImmediate(() => {
mockChild.emit('close', 0);
});
await writePromise;
expect(
(mockStdin as unknown as { write: Mock }).write,
).toHaveBeenCalledWith('new content');
expect((mockStdin as unknown as { end: Mock }).end).toHaveBeenCalled();
expect(vi.mocked(sandboxManager.prepareCommand)).toHaveBeenCalledWith(
expect.objectContaining({
command: '__write',
args: [testFile],
policy: {
allowedPaths: [testFile],
additionalPermissions: {
fileSystem: {
write: [testFile],
},
},
},
}),
);
expect(spawn).toHaveBeenCalledWith(
'sandbox.exe',
['0', cwd, '__write', testFile],
expect.any(Object),
);
});
it('should reject if sandbox command fails', async () => {
const mockChild = new EventEmitter() as unknown as ChildProcess;
Object.assign(mockChild, {
stdout: new EventEmitter(),
stderr: new EventEmitter(),
});
vi.mocked(spawn).mockReturnValue(mockChild);
const testFile = path.resolve('/test/cwd/file.txt');
const readPromise = service.readTextFile(testFile);
setImmediate(() => {
mockChild.stderr!.emit('data', Buffer.from('access denied'));
mockChild.emit('close', 1);
});
await expect(readPromise).rejects.toThrow(
`Sandbox Error: read_file failed for '${testFile}'. Exit code 1. Details: access denied`,
);
});
it('should set ENOENT code when file does not exist', async () => {
const mockChild = new EventEmitter() as unknown as ChildProcess;
Object.assign(mockChild, {
stdout: new EventEmitter(),
stderr: new EventEmitter(),
});
vi.mocked(spawn).mockReturnValue(mockChild);
const testFile = path.resolve('/test/cwd/missing.txt');
const readPromise = service.readTextFile(testFile);
setImmediate(() => {
mockChild.stderr!.emit('data', Buffer.from('No such file or directory'));
mockChild.emit('close', 1);
});
try {
await readPromise;
expect.fail('Should have rejected');
} catch (err: unknown) {
// @ts-expect-error - Checking message and code on unknown error
expect(err.message).toContain('No such file or directory');
// @ts-expect-error - Checking message and code on unknown error
expect(err.code).toBe('ENOENT');
}
});
it('should set ENOENT code when file does not exist on Windows', async () => {
const mockChild = new EventEmitter() as unknown as ChildProcess;
Object.assign(mockChild, {
stdout: new EventEmitter(),
stderr: new EventEmitter(),
});
vi.mocked(spawn).mockReturnValue(mockChild);
const testFile = path.resolve('/test/cwd/missing.txt');
const readPromise = service.readTextFile(testFile);
setImmediate(() => {
mockChild.stderr!.emit(
'data',
Buffer.from('Could not find a part of the path'),
);
mockChild.emit('close', 1);
});
try {
await readPromise;
expect.fail('Should have rejected');
} catch (err: unknown) {
const error = err as { message: string; code?: string };
expect(error.message).toContain('Could not find a part of the path');
expect(error.code).toBe('ENOENT');
}
});
});
|