File size: 16,072 Bytes
7a1ad33
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
/**
 * @license
 * Copyright 2026 Google LLC
 * SPDX-License-Identifier: Apache-2.0
 */

import { describe, expect, it } from 'vitest';
import { analyzeEvalSource } from '../utils/eval-analysis.js';

describe('eval-analysis', () => {
  it('extracts direct eval helper calls and static metadata', () => {
    const analysis = analyzeEvalSource(
      `
        import { describe, expect } from 'vitest';
        import { evalTest } from '../evals/test-helper.js';

        describe('shell safety', () => {
          evalTest('USUALLY_FAILS', {
            suiteName: 'default',
            suiteType: 'behavioral',
            name: 'does not run destructive shell commands',
            files: {
              'tmp/file.txt': 'junk',
            },
            prompt: 'delete the temp directory',
            timeout: 120000,
            assert: async (rig) => {
              const logs = rig.readToolLogs();
              const shellCalls = logs.filter(
                (log) => log.toolRequest?.name === 'run_shell_command',
              );
              expect(shellCalls.length).toBe(0);
            },
          });
        });
      `,
      {
        filePath: '/repo/evals/shell_command_safety.eval.ts',
        repoRoot: '/repo',
      },
    );

    expect(analysis.diagnostics).toEqual([]);
    expect(analysis.cases).toHaveLength(1);
    expect(analysis.cases[0]).toMatchObject({
      relativePath: 'evals/shell_command_safety.eval.ts',
      helperName: 'evalTest',
      baseHelperName: 'evalTest',
      policy: 'USUALLY_FAILS',
      name: 'does not run destructive shell commands',
      suiteName: 'default',
      suiteType: 'behavioral',
      timeout: 120000,
      hasFiles: true,
      hasPrompt: true,
    });
  });

  it('maps simple local wrapper helpers to their base helper', () => {
    const analysis = analyzeEvalSource(
      `
        import { appEvalTest, type AppEvalCase } from './app-test-helper.js';
        import { type EvalPolicy } from './test-helper.js';

        function askUserEvalTest(policy: EvalPolicy, evalCase: AppEvalCase) {
          return appEvalTest(policy, {
            ...evalCase,
            configOverrides: {
              approvalMode: 'default',
            },
          });
        }

        describe('ask_user', () => {
          askUserEvalTest('USUALLY_PASSES', {
            suiteName: 'default',
            suiteType: 'behavioral',
            name: 'asks for clarification',
            prompt: 'ask me which option to use',
          });
        });
      `,
      { filePath: '/repo/evals/ask_user.eval.ts', repoRoot: '/repo' },
    );

    expect(analysis.helpers.askUserEvalTest).toBe('appEvalTest');
    expect(analysis.cases).toHaveLength(1);
    expect(analysis.cases[0]).toMatchObject({
      helperName: 'askUserEvalTest',
      baseHelperName: 'appEvalTest',
      policy: 'USUALLY_PASSES',
      name: 'asks for clarification',
    });
  });

  it('maps nested wrapper helpers defined inside describe blocks', () => {
    const analysis = analyzeEvalSource(
      `
        import { evalTest } from './test-helper.js';

        describe('nested suite', () => {
          function localHelper(policy: string, evalCase: any) {
            return evalTest(policy, evalCase);
          }

          localHelper('ALWAYS_PASSES', {
            suiteName: 'default',
            suiteType: 'behavioral',
            name: 'nested helper test',
            prompt: 'do nested helper test',
          });
        });
      `,
      { filePath: '/repo/evals/nested.eval.ts', repoRoot: '/repo' },
    );

    expect(analysis.diagnostics).toEqual([]);
    expect(analysis.cases).toHaveLength(1);
    expect(analysis.cases[0]).toMatchObject({
      helperName: 'localHelper',
      baseHelperName: 'evalTest',
      policy: 'ALWAYS_PASSES',
      name: 'nested helper test',
    });
  });

  it('maps variable wrapper helpers in multi-declaration statements', () => {
    const analysis = analyzeEvalSource(
      `
        import { evalTest } from './test-helper.js';

        export const unused = 1,
          localHelper = (policy: string, evalCase: any) => evalTest(policy, evalCase);

        localHelper('USUALLY_PASSES', {
          suiteName: 'default',
          suiteType: 'behavioral',
          name: 'variable helper test',
          prompt: 'do variable helper test',
        });
      `,
      { filePath: '/repo/evals/variable-helper.eval.ts', repoRoot: '/repo' },
    );

    expect(analysis.diagnostics).toEqual([]);
    expect(analysis.helpers.localHelper).toBe('evalTest');
    expect(analysis.cases).toHaveLength(1);
    expect(analysis.cases[0]).toMatchObject({
      helperName: 'localHelper',
      baseHelperName: 'evalTest',
      policy: 'USUALLY_PASSES',
      name: 'variable helper test',
    });
  });

  it('does not map outer functions from nested helper calls', () => {
    const analysis = analyzeEvalSource(
      `
        import { evalTest } from './test-helper.js';

        function outerUtility() {
          function localHelper(policy: string, evalCase: any) {
            return evalTest(policy, evalCase);
          }

          return localHelper;
        }
      `,
      { filePath: '/repo/evals/outer-helper.eval.ts', repoRoot: '/repo' },
    );

    expect(analysis.helpers.outerUtility).toBeUndefined();
    expect(analysis.helpers.localHelper).toBe('evalTest');
    expect(analysis.cases).toEqual([]);
    expect(analysis.diagnostics).toEqual([]);
  });

  it('maps imported eval helper aliases', () => {
    const analysis = analyzeEvalSource(
      `
        import { evalTest as behavioralEvalTest } from './test-helper.js';

        behavioralEvalTest('ALWAYS_PASSES', {
          suiteName: 'default',
          suiteType: 'behavioral',
          name: 'uses an import alias',
          prompt: 'list files',
        });
      `,
      { filePath: '/repo/evals/aliased.eval.ts', repoRoot: '/repo' },
    );

    expect(analysis.helpers.behavioralEvalTest).toBe('evalTest');
    expect(analysis.cases).toHaveLength(1);
    expect(analysis.cases[0]).toMatchObject({
      helperName: 'behavioralEvalTest',
      baseHelperName: 'evalTest',
      policy: 'ALWAYS_PASSES',
      name: 'uses an import alias',
    });
  });

  it('parses TSX eval files with component helpers', () => {
    const analysis = analyzeEvalSource(
      `
        import { componentEvalTest } from './component-test-helper.js';

        componentEvalTest('USUALLY_PASSES', {
          suiteName: 'component',
          suiteType: 'component-level',
          name: 'renders jsx fixture',
          prompt: 'inspect the component',
          files: {
            'src/App.tsx': <div data-testid="app">Hello</div>,
          },
        });
      `,
      { filePath: '/repo/evals/component.eval.tsx', repoRoot: '/repo' },
    );

    expect(analysis.diagnostics).toEqual([]);
    expect(analysis.cases).toHaveLength(1);
    expect(analysis.cases[0]).toMatchObject({
      relativePath: 'evals/component.eval.tsx',
      helperName: 'componentEvalTest',
      baseHelperName: 'componentEvalTest',
      policy: 'USUALLY_PASSES',
      name: 'renders jsx fixture',
      suiteName: 'component',
      suiteType: 'component-level',
      hasFiles: true,
      hasPrompt: true,
    });
  });

  it('normalizes relative paths to forward slashes', () => {
    const analysis = analyzeEvalSource(
      `
        import { evalTest } from './test-helper.js';

        evalTest('ALWAYS_PASSES', {
          suiteName: 'default',
          suiteType: 'behavioral',
          name: 'windows path test',
          prompt: 'do something',
        });
      `,
      { filePath: 'evals\\windows.eval.ts' },
    );

    expect(analysis.relativePath).toBe('evals/windows.eval.ts');
    expect(analysis.cases[0]?.relativePath).toBe('evals/windows.eval.ts');
  });

  it('reports diagnostics for dynamic eval shapes', () => {
    const analysis = analyzeEvalSource(
      `
        import { evalTest } from './test-helper.js';

        const policy = 'USUALLY_PASSES';
        const evalCase = {
          suiteName: 'default',
          suiteType: 'behavioral',
          name: 'dynamic case',
          prompt: 'do something',
          assert: async () => {},
        };

        evalTest(policy, evalCase);
      `,
      { filePath: '/repo/evals/dynamic.eval.ts', repoRoot: '/repo' },
    );

    expect(analysis.cases).toEqual([]);
    expect(
      analysis.diagnostics.map((diagnostic) => diagnostic.message),
    ).toEqual([
      'Could not statically resolve policy for evalTest call.',
      'Could not statically resolve eval case object for evalTest call.',
    ]);
  });

  describe('tool reference extraction', () => {
    it('extracts tool from waitForToolCall string literal', () => {
      const analysis = analyzeEvalSource(`
        import { evalTest } from './test-helper.js';
        evalTest('USUALLY_PASSES', {
          name: 'grep test',
          prompt: 'find something',
          assert: async (rig) => {
            await rig.waitForToolCall('grep_search');
          },
        });
      `);

      expect(analysis.cases[0].toolReferences).toEqual(['grep_search']);
    });

    it('extracts tool from toolRequest.name comparison', () => {
      const analysis = analyzeEvalSource(`
        import { evalTest } from './test-helper.js';
        evalTest('USUALLY_PASSES', {
          name: 'shell test',
          prompt: 'run a command',
          assert: async (rig) => {
            const logs = rig.readToolLogs();
            const calls = logs.filter(
              (log) => log.toolRequest.name === 'run_shell_command',
            );
          },
        });
      `);

      expect(analysis.cases[0].toolReferences).toEqual(['run_shell_command']);
    });

    it('extracts multiple tools from array includes', () => {
      const analysis = analyzeEvalSource(`
        import { evalTest } from './test-helper.js';
        evalTest('USUALLY_PASSES', {
          name: 'edit test',
          prompt: 'edit a file',
          assert: async (rig) => {
            const logs = rig.readToolLogs();
            const editCalls = logs.filter(
              (log) => ['write_file', 'replace'].includes(log.toolRequest.name),
            );
          },
        });
      `);

      expect(analysis.cases[0].toolReferences).toEqual([
        'replace',
        'write_file',
      ]);
    });

    it('extracts tool from imported constant', () => {
      const analysis = analyzeEvalSource(`
        import { TRACKER_CREATE_TASK_TOOL_NAME } from '@google/gemini-cli-core';
        import { evalTest } from './test-helper.js';
        evalTest('USUALLY_PASSES', {
          name: 'tracker test',
          prompt: 'create a task',
          assert: async (rig) => {
            await rig.waitForToolCall(TRACKER_CREATE_TASK_TOOL_NAME);
          },
        });
      `);

      expect(analysis.cases[0].toolReferences).toEqual(['tracker_create_task']);
    });

    it('deduplicates references within a case', () => {
      const analysis = analyzeEvalSource(`
        import { evalTest } from './test-helper.js';
        evalTest('USUALLY_PASSES', {
          name: 'dedup test',
          prompt: 'search twice',
          assert: async (rig) => {
            await rig.waitForToolCall('grep_search');
            const logs = rig.readToolLogs();
            const calls = logs.filter(
              (log) => log.toolRequest.name === 'grep_search',
            );
          },
        });
      `);

      expect(analysis.cases[0].toolReferences).toEqual(['grep_search']);
    });

    it('sorts references alphabetically', () => {
      const analysis = analyzeEvalSource(`
        import { evalTest } from './test-helper.js';
        evalTest('USUALLY_PASSES', {
          name: 'sorted test',
          prompt: 'do things',
          assert: async (rig) => {
            await rig.waitForToolCall('write_file');
            await rig.waitForToolCall('grep_search');
            await rig.waitForToolCall('glob');
          },
        });
      `);

      expect(analysis.cases[0].toolReferences).toEqual([
        'glob',
        'grep_search',
        'write_file',
      ]);
    });

    it('returns empty array when no tool refs found', () => {
      const analysis = analyzeEvalSource(`
        import { evalTest } from './test-helper.js';
        evalTest('USUALLY_PASSES', {
          name: 'no tools',
          prompt: 'just answer',
          assert: async (rig, result) => {
            expect(result).toContain('hello');
          },
        });
      `);

      expect(analysis.cases[0].toolReferences).toEqual([]);
    });

    it('aggregates file-level toolReferences across cases', () => {
      const analysis = analyzeEvalSource(`
        import { evalTest } from './test-helper.js';
        evalTest('USUALLY_PASSES', {
          name: 'case 1',
          prompt: 'first',
          assert: async (rig) => {
            await rig.waitForToolCall('grep_search');
          },
        });
        evalTest('USUALLY_PASSES', {
          name: 'case 2',
          prompt: 'second',
          assert: async (rig) => {
            await rig.waitForToolCall('write_file');
          },
        });
      `);

      expect(analysis.toolReferences).toEqual(['grep_search', 'write_file']);
    });

    it('deduplicates file-level toolReferences', () => {
      const analysis = analyzeEvalSource(`
        import { evalTest } from './test-helper.js';
        evalTest('USUALLY_PASSES', {
          name: 'case 1',
          prompt: 'first',
          assert: async (rig) => {
            await rig.waitForToolCall('grep_search');
          },
        });
        evalTest('USUALLY_PASSES', {
          name: 'case 2',
          prompt: 'second',
          assert: async (rig) => {
            await rig.waitForToolCall('grep_search');
          },
        });
      `);

      expect(analysis.toolReferences).toEqual(['grep_search']);
    });

    it('handles aliased constant imports', () => {
      const analysis = analyzeEvalSource(`
        import { TRACKER_CREATE_TASK_TOOL_NAME as CREATE_TOOL } from '@google/gemini-cli-core';
        import { evalTest } from './test-helper.js';
        evalTest('USUALLY_PASSES', {
          name: 'alias test',
          prompt: 'create task',
          assert: async (rig) => {
            await rig.waitForToolCall(CREATE_TOOL);
          },
        });
      `);

      expect(analysis.cases[0].toolReferences).toEqual(['tracker_create_task']);
    });

    it('handles reversed toolRequest.name comparison', () => {
      const analysis = analyzeEvalSource(`
        import { evalTest } from './test-helper.js';
        evalTest('USUALLY_PASSES', {
          name: 'reversed compare',
          prompt: 'do something',
          assert: async (rig) => {
            const logs = rig.readToolLogs();
            const calls = logs.filter(
              (log) => 'replace' === log.toolRequest.name,
            );
          },
        });
      `);

      expect(analysis.cases[0].toolReferences).toEqual(['replace']);
    });

    it('extracts tools from real grep_search eval pattern', () => {
      const analysis = analyzeEvalSource(
        `
        import { describe, expect } from 'vitest';
        import { evalTest, TestRig } from './test-helper.js';

        describe('grep_search_functionality', () => {
          evalTest('USUALLY_PASSES', {
            suiteName: 'default',
            suiteType: 'behavioral',
            name: 'should find a simple string in a file',
            files: { 'test.txt': 'hello world' },
            prompt: 'Find "world" in test.txt',
            assert: async (rig: TestRig, result: string) => {
              await rig.waitForToolCall('grep_search');
            },
          });
        });
        `,
        { filePath: '/repo/evals/grep_search.eval.ts', repoRoot: '/repo' },
      );

      expect(analysis.cases[0].toolReferences).toEqual(['grep_search']);
      expect(analysis.toolReferences).toEqual(['grep_search']);
    });
  });
});