File size: 6,067 Bytes
4e23b01 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 | import { describe, expect, it, vi } from 'vitest';
import type { ApprovalHandler, ApprovalRequest, ApprovalResponse } from '#/index';
import { Session } from '#/index';
import type { SDKRpcClientBase } from '#/rpc';
describe('Session approval handler', () => {
it('registers an approval handler and returns approved responses', async () => {
const rpc = new FakeSDKRpcClient();
const session = new Session({
id: 'ses_approval_handler',
workDir: '/tmp',
rpc: rpc.asRpc(),
});
const handler = vi.fn(async (request: ApprovalRequest) => {
expect(request).toMatchObject({
toolCallId: 'tool_1',
toolName: 'Bash',
action: 'Run command',
});
return { decision: 'approved' as const, selectedLabel: 'Approve once' };
});
session.setApprovalHandler(handler);
await expect(
rpc.requestApproval(
session.id,
'main',
approvalRequest({
toolCallId: 'tool_1',
toolName: 'Bash',
action: 'Run command',
}),
),
).resolves.toEqual({ decision: 'approved', selectedLabel: 'Approve once' });
expect(handler).toHaveBeenCalledTimes(1);
});
it('sends rejected responses with feedback', async () => {
const rpc = new FakeSDKRpcClient();
const session = new Session({
id: 'ses_approval_rejected',
workDir: '/tmp',
rpc: rpc.asRpc(),
});
session.setApprovalHandler(() => ({ decision: 'rejected', feedback: 'No writes.' }));
await expect(
rpc.requestApproval(
session.id,
'main',
approvalRequest({
toolCallId: 'tool_2',
toolName: 'Write',
action: 'Write file',
}),
),
).resolves.toEqual({ decision: 'rejected', feedback: 'No writes.' });
});
it('sends session-scoped approved responses when requested', async () => {
const rpc = new FakeSDKRpcClient();
const session = new Session({
id: 'ses_approval_scope',
workDir: '/tmp',
rpc: rpc.asRpc(),
});
session.setApprovalHandler(() => ({ decision: 'approved', scope: 'session' }));
await expect(
rpc.requestApproval(
session.id,
'main',
approvalRequest({
toolCallId: 'tool_scope',
toolName: 'Bash',
action: 'Run command',
}),
),
).resolves.toEqual({ decision: 'approved', scope: 'session' });
});
it('cancels approval requests when no handler is registered', async () => {
const rpc = new FakeSDKRpcClient();
const session = new Session({
id: 'ses_approval_default',
workDir: '/tmp',
rpc: rpc.asRpc(),
});
await expect(
rpc.requestApproval(
session.id,
'main',
approvalRequest({
toolCallId: 'tool_3',
toolName: 'Bash',
action: 'Run command',
}),
),
).resolves.toEqual({
decision: 'cancelled',
feedback: 'No approval handler registered.',
});
await session.close();
expect(rpc.closeSession).toHaveBeenCalledWith({ sessionId: session.id });
});
it('cancels approval requests when the handler throws', async () => {
const rpc = new FakeSDKRpcClient();
const session = new Session({
id: 'ses_approval_throw',
workDir: '/tmp',
rpc: rpc.asRpc(),
});
session.setApprovalHandler(() => {
throw new Error('boom');
});
await expect(
rpc.requestApproval(
session.id,
'main',
approvalRequest({
toolCallId: 'tool_4',
toolName: 'Bash',
action: 'Run command',
}),
),
).resolves.toEqual({
decision: 'cancelled',
feedback: 'Approval handler failed.',
});
});
it('responds to the original subagent id', async () => {
const rpc = new FakeSDKRpcClient();
const session = new Session({
id: 'ses_approval_subagent',
workDir: '/tmp',
rpc: rpc.asRpc(),
});
const handler = vi.fn(() => ({ decision: 'approved' as const }));
session.setApprovalHandler(handler);
await expect(
rpc.requestApproval(
session.id,
'agent-1',
approvalRequest({
toolCallId: 'tool_5',
toolName: 'Read',
action: 'Read file',
}),
),
).resolves.toEqual({ decision: 'approved' });
expect(handler).toHaveBeenCalledWith(
expect.objectContaining({
sessionId: session.id,
agentId: 'agent-1',
}),
);
});
});
interface ApprovalRequestInput {
readonly toolCallId: string;
readonly toolName: string;
readonly action: string;
}
function approvalRequest(input: ApprovalRequestInput): ApprovalRequest {
return {
toolCallId: input.toolCallId,
toolName: input.toolName,
action: input.action,
display: { kind: 'generic', summary: input.action },
};
}
class FakeSDKRpcClient {
private readonly approvalHandlers = new Map<string, ApprovalHandler>();
readonly closeSession = vi.fn(async (_input: { readonly sessionId: string }) => {});
asRpc(): SDKRpcClientBase {
return this as unknown as SDKRpcClientBase;
}
setApprovalHandler(sessionId: string, handler: ApprovalHandler | undefined): void {
if (handler === undefined) {
this.approvalHandlers.delete(sessionId);
return;
}
this.approvalHandlers.set(sessionId, handler);
}
async requestApproval(
sessionId: string,
agentId: string,
request: ApprovalRequest,
): Promise<ApprovalResponse> {
const handler = this.approvalHandlers.get(sessionId);
if (handler === undefined) {
return {
decision: 'cancelled',
feedback: 'No approval handler registered.',
};
}
try {
return await handler({ ...request, sessionId, agentId } as ApprovalRequest);
} catch {
return {
decision: 'cancelled',
feedback: 'Approval handler failed.',
};
}
}
clearSessionHandlers(sessionId: string): void {
this.approvalHandlers.delete(sessionId);
}
}
|