File size: 7,855 Bytes
e249c6d | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 | // Covers guarded session-store persistence.
import path from "node:path";
import { afterEach, describe, expect, it } from "vitest";
import { useAutoCleanupTempDirTracker } from "../../../test/helpers/temp-dir.js";
import { loadSessionEntry, replaceSessionEntry } from "../../config/sessions/session-accessor.js";
import { clearSessionStoreCacheForTest } from "../../config/sessions/store-writer-state.js";
import type { SessionEntry } from "../../config/sessions/types.js";
import { persistAgentSession } from "./attempt-execution.shared.js";
const tempDirs = useAutoCleanupTempDirTracker(afterEach);
describe("persistAgentSession", () => {
const sessionKey = "agent:main:main";
it("clears stale local entries when guarded persistence sees no persisted entry", async () => {
const dir = tempDirs.make("openclaw-session-store-");
try {
const storePath = path.join(dir, "sessions.json");
const sessionStore = {
[sessionKey]: {
sessionId: "stale",
updatedAt: 1,
},
};
// A guarded write can decline persistence after rereading disk; local
// memory must be cleared too so later turns do not reuse stale entries.
const persisted = await persistAgentSession({
sessionStore,
sessionKey,
storePath,
initialEntry: sessionStore[sessionKey],
entry: {
sessionId: "stale",
updatedAt: 2,
},
shouldPersist: (entry) => Boolean(entry),
});
expect(persisted).toBeUndefined();
expect(sessionStore[sessionKey]).toBeUndefined();
} finally {
clearSessionStoreCacheForTest();
}
});
it.each([
{
name: "rename and unpin",
current: { label: "Renamed", pinnedAt: undefined },
expected: { label: "Renamed", pinnedAt: undefined },
},
{
name: "label clear and pin",
current: { label: undefined, pinnedAt: 300 },
expected: { label: undefined, pinnedAt: 300 },
},
])("preserves a concurrent $name", async ({ current, expected }) => {
const dir = tempDirs.make("openclaw-session-store-");
try {
const storePath = path.join(dir, "sessions.json");
const staleEntry: SessionEntry = {
sessionId: "session-1",
updatedAt: 100,
label: "Old label",
pinnedAt: 200,
};
const currentEntry: SessionEntry = {
...staleEntry,
...current,
updatedAt: 400,
};
if (current.label === undefined) {
delete currentEntry.label;
}
if (current.pinnedAt === undefined) {
delete currentEntry.pinnedAt;
}
await replaceSessionEntry({ sessionKey, storePath }, currentEntry);
const sessionStore = { [sessionKey]: staleEntry };
const persisted = await persistAgentSession({
sessionStore,
sessionKey,
storePath,
initialEntry: staleEntry,
entry: {
...staleEntry,
model: "gpt-5.5",
updatedAt: 250,
},
});
expect(persisted).toMatchObject({ sessionId: "session-1", model: "gpt-5.5" });
expect(persisted?.label).toBe(expected.label);
expect(persisted?.pinnedAt).toBe(expected.pinnedAt);
expect(persisted?.updatedAt).toBeGreaterThanOrEqual(currentEntry.updatedAt);
expect(sessionStore[sessionKey]).toEqual(persisted);
expect(loadSessionEntry({ sessionKey, storePath, readConsistency: "latest" })).toEqual(
persisted,
);
} finally {
clearSessionStoreCacheForTest();
}
});
it("does not restore policy fields revoked during an active turn", async () => {
const dir = tempDirs.make("openclaw-session-store-");
try {
const storePath = path.join(dir, "sessions.json");
const initialEntry: SessionEntry = {
sessionId: "session-1",
updatedAt: 100,
model: "gpt-5.4",
elevatedLevel: "full",
inheritedToolAllow: ["exec"],
sendPolicy: "allow",
};
const currentEntry: SessionEntry = {
sessionId: "session-1",
updatedAt: 400,
model: "gpt-5.4",
sendPolicy: "deny",
};
await replaceSessionEntry({ sessionKey, storePath }, currentEntry);
const sessionStore = { [sessionKey]: initialEntry };
const persisted = await persistAgentSession({
sessionStore,
sessionKey,
storePath,
initialEntry,
entry: {
...initialEntry,
model: "gpt-5.5",
updatedAt: 250,
},
});
expect(persisted).toMatchObject({
sessionId: "session-1",
model: "gpt-5.5",
sendPolicy: "deny",
updatedAt: 400,
});
expect(persisted?.elevatedLevel).toBeUndefined();
expect(persisted?.inheritedToolAllow).toBeUndefined();
expect(loadSessionEntry({ sessionKey, storePath, readConsistency: "latest" })).toEqual(
persisted,
);
} finally {
clearSessionStoreCacheForTest();
}
});
it("does not recreate a deleted persisted entry from stale local memory", async () => {
const dir = tempDirs.make("openclaw-session-store-");
try {
const storePath = path.join(dir, "sessions.json");
const staleEntry: SessionEntry = {
sessionId: "deleted-session",
updatedAt: 1,
};
const sessionStore = { [sessionKey]: staleEntry };
const persisted = await persistAgentSession({
sessionStore,
sessionKey,
storePath,
initialEntry: staleEntry,
entry: {
sessionId: "deleted-session",
updatedAt: 2,
},
});
expect(persisted).toBeUndefined();
expect(sessionStore[sessionKey]).toBeUndefined();
expect(
loadSessionEntry({ sessionKey, storePath, readConsistency: "latest" }),
).toBeUndefined();
} finally {
clearSessionStoreCacheForTest();
}
});
it("keeps rejecting repeated stale writes after clearing local memory", async () => {
const dir = tempDirs.make("openclaw-session-store-");
try {
const storePath = path.join(dir, "sessions.json");
const staleEntry: SessionEntry = {
sessionId: "deleted-session",
updatedAt: 1,
};
const sessionStore = { [sessionKey]: staleEntry };
const first = await persistAgentSession({
sessionStore,
sessionKey,
storePath,
initialEntry: staleEntry,
entry: staleEntry,
});
const second = await persistAgentSession({
sessionStore,
sessionKey,
storePath,
initialEntry: staleEntry,
entry: {
...staleEntry,
updatedAt: 2,
},
});
expect(first).toBeUndefined();
expect(second).toBeUndefined();
expect(sessionStore[sessionKey]).toBeUndefined();
expect(
loadSessionEntry({ sessionKey, storePath, readConsistency: "latest" }),
).toBeUndefined();
} finally {
clearSessionStoreCacheForTest();
}
});
it("allows an explicit create-on-missing persistence predicate", async () => {
const dir = tempDirs.make("openclaw-session-store-");
try {
const storePath = path.join(dir, "sessions.json");
const sessionStore: Record<string, SessionEntry> = {};
const entry: SessionEntry = {
sessionId: "created-session",
updatedAt: 1,
};
const persisted = await persistAgentSession({
sessionStore,
sessionKey,
storePath,
initialEntry: entry,
entry,
shouldPersist: (existing) => existing === undefined,
});
expect(persisted?.sessionId).toBe("created-session");
expect(sessionStore[sessionKey]?.sessionId).toBe("created-session");
} finally {
clearSessionStoreCacheForTest();
}
});
});
|