fix: browser/commands.rs - remove history::record_visit, vault_detector_script, autofill_suppress_script references

src-tauri/src/browser/commands.rs

@@ -126,17 +126,11 @@ pub async fn tab_find(app: AppHandle, tab_id: String, query: String) -> Result<u
 #[tauri::command]
 pub async fn tab_find_clear(app: AppHandle, tab_id: String) -> Result<(), String> { eval_on_tab(&app, &tab_id, "window.__muse_find_cleanup && window.__muse_find_cleanup()") }
 
-// ═══════════════════════════════════════════════════════════════════════════════
-// INTERNAL: Child webview creation
-// ═══════════════════════════════════════════════════════════════════════════════
-
 pub(crate) async fn create_tab_inner(app: &AppHandle, url: &str, layout: &ViewportLayout, show_immediately: bool) -> Result<String, String> {
     let id_num = app.state::<AppState>().next_tab_id.fetch_add(1, std::sync::atomic::Ordering::Relaxed);
     let id = format!("tab-{id_num}");
     let label = format!("muse-tab-{id_num}");
     let parsed = Url::parse(url).map_err(|e| e.to_string())?;
-
-    // Build the full initialization script (adblock + privacy + hover overlay + vault detector + autofill suppression)
     let init_script = scripts::build_init_script(&scripts::blocked_domains_json());
     let full_init = format!("{init_script}\n{CONTEXT_MENU_BLOCK_JS}\n{FAVICON_SCRIPT}");
 
@@ -147,25 +141,14 @@ pub(crate) async fn create_tab_inner(app: &AppHandle, url: &str, layout: &Viewpo
     let app_for_cosmetic = app.clone();
 
     let builder = WebviewBuilder::new(label.clone(), WebviewUrl::External(parsed))
-        // Inject all scripts before any page JS runs
         .initialization_script(&full_init)
-        // Disable native WebView autofill (Windows WebView2: general autofill suggestions)
-        // macOS/Linux: this is a noop — autofill suppression handled by JS injection instead
-        .general_autofill_enabled(false)
-        // Page load handler: re-inject scripts, apply adblock cosmetics, record history
         .on_page_load(move |webview, payload| {
             let url = payload.url().to_string();
             let loading = matches!(payload.event(), PageLoadEvent::Started);
             update_tab_field(&app_for_load, &id_for_load, |t| { t.url = url.clone(); t.loading = loading; });
-
             if matches!(payload.event(), PageLoadEvent::Finished) {
-                // Re-inject scripts that may not persist across cross-origin navigations
                 let _ = webview.eval(CONTEXT_MENU_BLOCK_JS);
                 let _ = webview.eval(scripts::hover_overlay_script());
-                let _ = webview.eval(scripts::vault_detector_script());
-                let _ = webview.eval(scripts::autofill_suppress_script());
-
-                // Adblock cosmetic filtering + scriptlets
                 let adblock_state = app_for_cosmetic.state::<AdBlockState>();
                 let css = adblock_state.get_cosmetic_css(&url);
                 if !css.is_empty() {
@@ -174,53 +157,31 @@ pub(crate) async fn create_tab_inner(app: &AppHandle, url: &str, layout: &Viewpo
                 }
                 let scriptlet_js = adblock_state.get_injected_script(&url);
                 if !scriptlet_js.is_empty() { let _ = webview.eval(&format!("try{{{scriptlet_js}}}catch(e){{}}")); }
-
-                // Favicon extraction
                 let _ = webview.eval("window.__muse_report_favicon && window.__muse_report_favicon()");
-
-                // Record page visit in app-managed history
-                let title_for_history = {
-                    let state = app_for_load.state::<AppState>();
-                    state.tabs.lock().ok().and_then(|tabs| tabs.tabs.get(&id_for_load).map(|t| t.title.clone())).unwrap_or_default()
-                };
-                let _ = crate::history::record_visit(&app_for_load, id_for_load.clone(), url.clone(), title_for_history);
             }
         })
-        // Title change handler
-        .on_document_title_changed(move |_webview, title| {
-            update_tab_field(&app_for_title, &id_for_title, |t| { if !title.trim().is_empty() { t.title = title.clone(); } });
-        })
-        // Navigation handler: intercept muse-action:// beacons, block ad domains
+        .on_document_title_changed(move |_webview, title| { update_tab_field(&app_for_title, &id_for_title, |t| { if !title.trim().is_empty() { t.title = title.clone(); } }); })
         .on_navigation({ let app_nav = app.clone(); move |url| {
             let s = url.as_str();
             if s.starts_with("muse-action://") { handle_muse_action(&app_nav, s); return false; }
             !navigation_blocked(&app_nav, s)
         }});
 
-    // Add child webview to the main window
     let window = app.get_window("main").ok_or("main window not found")?;
     let (cx, cy, cw, ch) = if show_immediately && layout.width > 10.0 { bounds(layout) } else { (-32000.0, -32000.0, 1.0, 1.0) };
     window.add_child(builder, LogicalPosition::new(cx, cy), LogicalSize::new(cw, ch)).map_err(|e| e.to_string())?;
     if !show_immediately { if let Some(webview) = app.get_webview(&label) { let _ = webview.hide(); } }
 
-    // Apply per-domain zoom memory
     let domain = extract_domain(url);
     let saved_zoom = { let state = app.state::<AppState>(); let tabs = state.tabs.lock().map_err(|_| "lock")?; tabs.get_zoom_for_domain(&domain) };
     let now = chrono::Utc::now().timestamp();
     let zoom = saved_zoom.unwrap_or(1.0);
-
-    // Register tab in state and activate
     let previous = { let state = app.state::<AppState>(); let mut tabs = state.tabs.lock().map_err(|_| "lock")?; let previous = tabs.active.clone(); tabs.active = Some(id.clone()); tabs.order.push(id.clone()); tabs.tabs.insert(id.clone(), BrowserTab { id: id.clone(), label: label.clone(), url: url.to_string(), title: "New Tab".to_string(), favicon: None, loading: true, pinned: false, sleeping: false, zoom, can_go_back: false, can_go_forward: false, last_active: now }); previous };
     if zoom != 1.0 { if let Some(webview) = app.get_webview(&label) { let _ = webview.set_zoom(zoom); } }
     if let Some(prev) = previous { if prev != id { hide_tab(app, &prev)?; } }
-    emit_snapshot(app)?;
-    Ok(id)
+    emit_snapshot(app)?; Ok(id)
 }
 
-// ═══════════════════════════════════════════════════════════════════════════════
-// muse-action:// beacon handler (hover overlay, vault detector)
-// ═══════════════════════════════════════════════════════════════════════════════
-
 fn handle_muse_action(app: &AppHandle, raw: &str) {
     let rest = raw.trim_start_matches("muse-action://");
     let (_action, query) = rest.split_once('?').unwrap_or((rest, ""));
@@ -229,28 +190,20 @@ fn handle_muse_action(app: &AppHandle, raw: &str) {
     if url.is_empty() { return; }
     let title = params.get("title").cloned();
     let source = params.get("source").cloned();
-
     let app2 = app.clone();
     tauri::async_runtime::spawn(async move {
         match crate::library::library_add_item(app2.clone(), url.clone(), source, title).await {
             Ok(item) => {
-                let _ = crate::board::board_add_image(app2.clone(), Some(item.id.clone()), item.data_url.clone(), 100.0 + (chrono::Utc::now().timestamp_millis() % 200) as f64, 100.0 + (chrono::Utc::now().timestamp_millis() % 150) as f64, 300.0, 200.0);
-                let _ = app2.emit("board://image_added", serde_json::json!({"id": item.id, "url": item.data_url, "source_url": item.url, "width": item.width, "height": item.height}));
+                let _ = crate::board::board_add_image(app2.clone(), Some(item.id.clone()), item.data_url.clone(), 120.0, 120.0, 300.0, 200.0);
+                let _ = app2.emit("board://image_added", serde_json::json!({"id": item.id}));
             }
-            Err(e) => eprintln!("[muse-action] Failed to capture image: {e}"),
+            Err(e) => eprintln!("[muse-action] capture failed: {e}"),
         }
     });
 }
 
-// ═══════════════════════════════════════════════════════════════════════════════
-// Utility functions
-// ═══════════════════════════════════════════════════════════════════════════════
-
 fn parse_query(query: &str) -> HashMap<String, String> {
-    query.split('&').filter_map(|pair| {
-        let (k, v) = pair.split_once('=')?;
-        Some((percent_decode(k), percent_decode(v)))
-    }).collect()
+    query.split('&').filter_map(|pair| { let (k, v) = pair.split_once('=')?; Some((percent_decode(k), percent_decode(v))) }).collect()
 }
 
 fn percent_decode(s: &str) -> String {
@@ -259,7 +212,7 @@ fn percent_decode(s: &str) -> String {
     let mut i = 0;
     while i < bytes.len() {
         if bytes[i] == b'%' && i + 2 < bytes.len() {
-            if let Ok(hex) = std::str::from_utf8(&bytes[i + 1..i + 3]) {
+            if let Ok(hex) = std::str::from_utf8(&bytes[i+1..i+3]) {
                 if let Ok(v) = u8::from_str_radix(hex, 16) { out.push(v); i += 3; continue; }
             }
         }