diff --git "a/qwen25_lora_official_rank_64_1e-05/complete_results.json" "b/qwen25_lora_official_rank_64_1e-05/complete_results.json" new file mode 100644--- /dev/null +++ "b/qwen25_lora_official_rank_64_1e-05/complete_results.json" @@ -0,0 +1,40694 @@ +{ + "test_bleu_4": 0.025012218757456756, + "test_exact_match": 0.0, + "test_rouge": { + "rouge1": 0.1449461990075428, + "rouge2": 0.02483854137090274, + "rougeL": 0.12005681860019798, + "rougeLsum": 0.12002705790871926 + }, + "test_bertscore": { + "precision": 0.8418846722900698, + "recall": 0.8452926261585152, + "f1": 0.8431558770490544 + }, + "test_meteor": 0.11083684868242893, + "raw_data": [ + { + "prediction": "I think this should be `language=java;transport=grpc` instead of `language=java,transport=grpc`", + "reference": "can we also test for `transport=rest`?" + }, + { + "prediction": "I think this should be `$this->config->get($this->mainConfig)->Index->record_batch_size`", + "reference": "If record_batch_size is not set in config.ini, this code will trigger a notice about an undefined value. I would suggest either wrapping the setPageSize() call in an `if (!empty(...)) {` check, or else providing a default value in the set call (i.e. `$config->Index->record_batch_size ?? 100`)." + }, + { + "prediction": "I don't think this is the right way to do it. The `ENV['SEGMENT_KEY']` is a string, so it will be wrapped in quotes, which is not what we want. You can use `ENV.fetch('SEGMENT_KEY')` to get the value of the environment variable without the surrounding quotes.", + "reference": "I didn't realize we were hardcoding this, thanks for moving it to an env value." + }, + { + "prediction": "I think this should be `Number.isNaN(file.data.size)` instead of `isNaN(file.data.size)` because `isNaN` is a global function and not a method of the `Number` object.", + "reference": "We are trying to support IE 10-11, so we'll need a polyfill for this one, I think." + }, + { + "prediction": "I think it would be better to use `useLocation` from `react-router-dom` instead of `useSelect` from `googlesitekit-data` to get the current URL.", + "reference": "It looks like there's a new `isNavigatingTo( url )` selector for this very purpose so let's use this here instead. This way we just need to use the one selector rather than two. Let's assign that to a similar-named variable here (e.g. `isNavigatingToPostResetURL`) rather than the prop it's used with." + }, + { + "prediction": "I think this should be `const AbsDistMat&`", + "reference": "I think im2col should only accommodate CPUMat." + }, + { + "prediction": "I think we can remove this import.", + "reference": "alpha sort the imports" + }, + { + "prediction": "(style) line over 80 characters", + "reference": "Can you explain why is this necessary? Is `snprintf()` with four integer arguments unsafe?" + }, + { + "prediction": "I think it would be better to use `api.getForegroundObject().lastDetectedKeyboardLayoutChange` instead of `getattr(api.getForegroundObject(), '_lastDetectedKeyboardLayoutChange', 0)`.", + "reference": "How likely would it be that the keyboard layout for the NVDA main thread differs from the keyboard layout of the currently focused app?" + }, + { + "prediction": "I think we can remove this now.", + "reference": "Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`)" + }, + { + "prediction": "I don't think we need to join here. `sendKeys` should be able to accept an array of strings.", + "reference": "Also update line 2205 below" + }, + { + "prediction": "I think we need to add a check here to see if shared is set to true. If it is, then we need to add the `hostPathType: Directory` to the `hostPath` section of the pod spec.", + "reference": "n_: It is a good practice to name the variable to indicate what they contain. In this case since `shared` is supposed to have boolean, calling it: `isShared` can help in the readability of the code." + }, + { + "prediction": "I think it would be better to say: \"Freezes the specified column (i.e. adds it to fixed columns). This method doesn't re-render the table, so you need to call the `render()` method afterward.\"", + "reference": "I suppose it's a false-positive error. Maybe there is a way to configure the `eslint-*` package to accept `i.e. .... lower case` syntax" + }, + { + "prediction": "I think we can remove the `string.IsNullOrEmpty(activity.ParentId)` check and just do `activity.ParentSpanId.ToHexString().Equals(\"0000000000000000\")`", + "reference": "this maynot be a perf issue, if ToHexString() is not actually allocating a string, but returns the caches string value. to be confirmed." + }, + { + "prediction": "I think it's better to use `zap.Stringer(\"image-provider\", provider.Name())` here, so we don't need to call `provider.Name()` twice.", + "reference": "`zap.String(\"image-provider\", provider.Name())` should be in a same line." + }, + { + "prediction": "Please revert this change.", + "reference": "Why this deletion?" + }, + { + "prediction": "I think this is a bug in moto. It should be `public, max-age=500`", + "reference": "This change looks unrelated to the CL description?" + }, + { + "prediction": "`DEDUP_RESUTL_CHECK` -> `DEDUP_RESULT_CHECK`", + "reference": "I'm not certain that `res`+`utl` isn't a thing." + }, + { + "prediction": "I think we need to remove this line as well.", + "reference": "This method can cause bugs. Why don't you use list of finalize statuses and then use join by comma and that will give you correct value. Use Apache Commons Lang library List list = Arrays.asList(1,2,3,4,5,6,7); String str = org.apache.commons.lang.StringUtils.join(list, \",\"); You can use it at multiple places shown in this diff." + }, + { + "prediction": "Please remove the extra whitespace here.", + "reference": "Merge with next condition" + }, + { + "prediction": "I think this should be `DeleteTaskStack` or `DeleteTaskStackInfo` to make it clear that we're deleting a stack, not just a task.", + "reference": "Maybe add it when it is used." + }, + { + "prediction": "I think this should be `{'name': 'non_exist_scanner', 'enabled': False}`", + "reference": "More clear naming: NONEXISTENT_ENABLED" + }, + { + "prediction": "I think we should use `Objects.equals` here and in other similar places.", + "reference": "why is this change necessary?" + }, + { + "prediction": "I'm not sure this is the right thing to do here. I think we should be returning `null` in this case, and let the caller deal with it.", + "reference": "make a SchemaTypeNameConverter.getTypeNameForEmptyType() and call that here." + }, + { + "prediction": "This is not the right way to get the default language. Use `Lang::getDefaultLanguage()->getLocale()` instead.", + "reference": "Use braces on your conditional structures please" + }, + { + "prediction": "`Whether to force saving the command history` -> `Whether to enable saving the command history`", + "reference": "Great God, I have a question. This \".nebula_history\" file is used to save history commands. Is there a file size limit? When the file is large, does it take a long time to start initialization (loadHistory)? How did you think about this? Thx." + }, + { + "prediction": "I think this should be `if (!isType (token, TOKEN_OPEN_PAREN)) return;`", + "reference": "Isn't this the same check as two lines above?" + }, + { + "prediction": "This should be `os.path.join(options.CA_DIR, 'mitmproxy.yaml')`", + "reference": "Don't redefine, just import the existing one in `cmdline.py`. :)" + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.", + "reference": "why not call `respond_to?(\"#{name}=\")` from the `if` line?" + }, + { + "prediction": "I think this should be `withParentEnvironmentType(ParentEnvironmentType.PASSENV)` as well.", + "reference": "This was properly set above as `.runfiles/` (with a fallback to workspace root dir) but never used past this line." + }, + { + "prediction": "I think this should be called `MvxWindowPresentationAttribute`", + "reference": "Are all these namespaces required for this attribute?" + }, + { + "prediction": "I think this should be `@logger.debug(result.stdout)` and `@logger.debug(result.stderr)`", + "reference": "Given this may be used and printed in other ways, isn't `debug` more appropriate?" + }, + { + "prediction": "I think this should return `nil` if the directory doesn't exist.", + "reference": "Looks like this is unused? Did you mean to call it when clearing the block journal?" + }, + { + "prediction": "I think we can remove this field and use `alerters` directly.", + "reference": "why named alters? how about this.alerts = alerts?" + }, + { + "prediction": "I think we need to make sure that the `sources` and `mirror` fields are only set if they are not nil.", + "reference": "not sure if this has to be here or not tbh" + }, + { + "prediction": "I think we should be more aggressive here and truncate to 50 characters. I don't think we need to worry about truncating to 50 characters in the middle of a word. If we do that, we'll end up with a topic name like `foo-bar-1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789", + "reference": "There's a better fix for this in #1741, which should replace this." + }, + { + "prediction": "Why is this change necessary?", + "reference": "Use swarm.Address not []byte as type, and construct it from actual byteslice or use swarm.NewAddress if it is constructed from hex-encoded string." + }, + { + "prediction": "I think we should use `os.RemoveAll(dir)` instead of `require.NoError(t, os.RemoveAll(dir))` here. The reason is that `require.NoError(t, os.RemoveAll(dir))` will cause the test to fail if `os.RemoveAll(dir)` returns an error, which is not what we want. We want the test to fail if `InitFSRepo(dir, config.NewDefaultConfig())` returns an error, not if `os.RemoveAll(dir)` returns an error.", + "reference": "It would be worth factoring this out to a function, but you don't have to do that here." + }, + { + "prediction": "I don't like the name `UriParser`. It's not a parser, it's a linkifier. Also, I don't like the name `linkifyUri`. It's not a linkifier, it's a linkifier for URIs.", + "reference": "There's no need for `final` in interfaces." + }, + { + "prediction": "I think this should be `Span.SetTag(Tags.Version, value);` instead of `Span.SetTag(DatadogTags.ServiceVersion, value);`", + "reference": "Isn't this case handled as a custom tag in `Span.SetTag()` below? This switch is only for special tags that actually set `Span` properties." + }, + { + "prediction": "I think this should be removed as well.", + "reference": "This shouldn't be changed." + }, + { + "prediction": "This file is not part of Invenio.", + "reference": "This one is important `2: I102 copyright year is outdated, expected 2014 but got 2012`" + }, + { + "prediction": "nit: remove empty line", + "reference": "Are these imports needed (BiConsumer and Consumer)? If they are unused imports, then precommit will fail." + }, + { + "prediction": "Style/RescueStandardError: Avoid rescuing StandardError. Use a specific exception instead.", + "reference": "Why are we catching and logging exceptions? By doing that we make it look like the job has succeeded and it will be removed from the queue - if we didn't do that then it would stay queued..." + }, + { + "prediction": "I think it would be better to return an empty array here, so that we don't have to check for `null` in the twig template.", + "reference": "If there are `@param` tags in docblock, there should be `@return` tag also. (applies for a whole file)" + }, + { + "prediction": "I think this should be \"validator\" not \"validators\" as there is only one validator per node.", + "reference": "Is the concept of validators exclusive to IBFT2? I wonder if this category should be more explicitly linked to IBFT2." + }, + { + "prediction": "I think we can remove this line as well.", + "reference": "Spotless is configured to reject star imports. Please replace with explicit imports." + }, + { + "prediction": "I think this should be `m_maxShmemPerBlock = d.template get_info();`", + "reference": "Remind me why you are using CUDA vocabulary when naming these variables." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in `DBReader.getFeeds()`. That way, you don't have to do this every time you call `DBReader.getFeeds()`, and you don't have to do this every time you call `DBReader.getFeedCounters()`. Also, if you do this in `DBReader.getFeeds()`, then you don't have to do this every time you call `DBReader.getFeeds()`, and you don't have to do this every time you call `DBReader.getFeedCounters()`. Also, if you do this in `DBReader.getFeeds()`, then you don't have to do this every time you call `DBReader.getFeeds()`, and you don't have to do this every time you call `DBReader.getFeedCounters()`. Also, if you do this in `DBReader.getFeeds()`, then you don't have to do this every time you call `DBReader.getFeeds()`, and you don't have to do this every time you call `DBReader.getFeedCounters()`. Also, if you do this in `DBReader.getFeeds()", + "reference": "Please turn the iteration order around (instead of `0...size` to `size...0`). The reason is that this sometimes skips indices when removing an item. You can therefore end up with feeds that have counter 0 and are still displayed." + }, + { + "prediction": "I think this should be `if solid_subset is not None:`", + "reference": "this is a behavior change. solid_subset=[] represents an empty pipeline where as solid_subset=None is the full pipeline" + }, + { + "prediction": "I think this should be an error, not a warning.", + "reference": "this is a breaking change, any specific reason you want to do this?" + }, + { + "prediction": "I'm not sure this is the right place to put these functions. I think they should be on the `ChainReader` interface, and the `nodeChainReader` should implement them. The `nodeChainReader` is just an implementation of the `ChainReader` interface, and it should be able to do everything that the `ChainReader` interface says it should be able to do.", + "reference": "Blocking: we still want read write separation. Node functions should absolutely not write to the chain store and the interface should reflect that. Only the syncer should have this capability in production code. It should be no problem to keep casting chainForTest to a read-write interface, or doing other function decomposition and automatic casting tricks." + }, + { + "prediction": "I think this should be `1<<31 - 1` instead of `1<<30 - 1`.", + "reference": "The PR description says the lowest on-demand request priority is `2^30`. Why the `-1` here?" + }, + { + "prediction": "I think this should be `if (creature && !creature->isRemoved() && creature->getHealth() <= 0) {`", + "reference": "checking health again? I think it is not necessary." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should only set `Ready` to `false` if we can't connect to the Typha. If we can't connect to the Typha, then we should set `Ready` to `false` and `Live` to `true`. If we can connect to the Typha, then we should set `Ready` to `true` and `Live` to `true`. If we can't connect to the Typha, then we should set `Ready` to `false` and `Live` to `true`. If we can connect to the Typha, then we should set `Ready` to `true` and `Live` to `true`. If we can't connect to the Typha, then we should set `Ready` to `false` and `Live` to `true`. If we can connect to the Typha, then we should set `Ready` to `true` and `Live` to `true`. If we can't connect to the Typha, then we should set `Ready` to `false` and `Live` to `true`. If we can connect to the Typha, then we should set `Ready` to `true` and", + "reference": "Need an `if err == nil {break}` above this line so that we don't log/sleep if the retry succeeds." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "to reiterate my point above, this class is not the actual provided Promise, but rather something a user can provide a Promise to/with. I think a name like `PromiseProvider` is more appropriate." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should only queue the dependency if it's not already queued.", + "reference": "I guess we can only call this from a post-build function, but we might need to check that this target is to be built? I guess target A depends on B which has a post build. We `plz build :B` which adds C as a dep of A. Won't we queue C to be built even though it only needs to build if A needs to be built? That's kinda why I approached this the way I did. I trust you've thought about this but would be good to understand this a bit better." + }, + { + "prediction": "I don't think this is the right way to fix this. The problem is that `select` is not implemented for `StreamSocket` objects, so we need to remove the `select` call for `StreamSocket` objects. This can be done by removing the `if arch.FREEBSD or arch.DARWIN:` line and the `inp, out, err = select(inmask,[],[], 0.05)` line, and replacing the `if len(inp) == 0 or pks in inp:` line with `if len(inp) == 0:`.", + "reference": "You should use `isinstance()` instead of comparing the class name to a string." + }, + { + "prediction": "I think this should be `if (el.nodeName.toUpperCase() === 'AUDIO' || el.nodeName.toUpperCase() === 'VIDEO') {`", + "reference": "Why should audio and video elements always return `false` for `isHidden`?" + }, + { + "prediction": "I think this should be `RegisterAppStart();`", + "reference": "This obviously won't work for all the other platforms." + }, + { + "prediction": "Please remove the extra backtick here.", + "reference": "Isn't he diamond operator Java7+?" + }, + { + "prediction": "I think it would be better to throw an `IllegalArgumentException` with a message that includes the name of the argument, e.g. `argName + \" must be greater than 0: \" + argName + \" = \" + number`.", + "reference": "Prefer adding a second `positive(String, double)` that delegates down to this three-param version. Using `null` in code is generally Not A Great Idea, and it looks ugly." + }, + { + "prediction": "I'm not sure this is the right way to do this. I think we should be able to do something like `node.Predecessors()[0].ID() + 1` to get the next node ID.", + "reference": "This pattern, where we add a new parameter without using it, often indicates to me that we've got a leaky interface or abstraction. I see this pattern _a lot_ in this patch, so wondering you have thoughts about it." + }, + { + "prediction": "I think this should be `os.IsNotExist(err) || os.IsPermission(err)`", + "reference": "This seems like an improved pattern :)" + }, + { + "prediction": "Line is too long. [82/80]
Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "`open_id_authentication` is no longer the name of the function, and it's not OpenID specific" + }, + { + "prediction": "I'm not sure this is the right thing to do. The balance is the balance of the wallet, not the balance of the account. If you have a wallet with multiple accounts, the balance of the wallet is the sum of the balances of all the accounts in the wallet.", + "reference": "This didn't require corresponding changes to the test case(s)?" + }, + { + "prediction": "I think this should be `EnvFile` instead of `env_file` to be consistent with the rest of the config.", + "reference": "A question! I think `string` totally works, but what do you think of `*string` for consistency?" + }, + { + "prediction": "I think this should be `aws.cluster.sigs.k8s.io/cluster-infrastructure-ready` and `aws.cluster.sigs.k8s.io/control-plane-ready`", + "reference": "Should this be: `aws.infrastructure.cluster.sigs.k8s.io` instead?" + }, + { + "prediction": "I think this should be `zprd` as well.", + "reference": "Not clear on why this change is correct." + }, + { + "prediction": "I think this should be `return in instanceof MappedByteBufferIndexInput;`", + "reference": "Hi Simon. Whether this should return true depends on what byte buffers are used? The same applies to ByteBufferIndexInput, actually... I don't think you can generally tell whether the ByteBuffers the input operates on come from a mmap call or from somewhere else (even direct buffers don't have to be a result of mmap)." + }, + { + "prediction": "I think this should be `padding: 'none'`", + "reference": "All stories in this file also need to have the default padding." + }, + { + "prediction": "I think this should be `sibling->parent != subsurface->parent`", + "reference": "I don't think these asserts are necessary, because `subsurface_find_sibling` already searches in the parent. Or am I missing something?" + }, + { + "prediction": "Line is too long. [81/80]
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", + "reference": "Should this be `number` instead of `id`?" + }, + { + "prediction": "I don't think this is correct. We should allow access through the Trafodion external name created for native HIVE or HBASE objects if the allowExternalTables flag is set. If the flag is not set, we should not allow access through the Trafodion external name created for native HIVE or HBASE objects.", + "reference": "I have forgotten why we thought this restriction is necessary. A user registers a Hive/HBase table with us but is not able to use the table with the registered name in DML. Will UPDATE STATs will be on the original name too (and update stats code will find out registered name and use it for Table_uid?). This was the registration concept is almost like an internal implementation idea, at some point could even be done by some utility program for all existing Hive/hBase tables, and the user need not be aware of it? I am struggling with a user would want to register a table, if they cannot use it by that name." + }, + { + "prediction": "(style) Macros with multiple statements should be enclosed in a do - while loop", + "reference": "Should most of these non-globals be static?" + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "Please do not approve PRs without tests!!!!" + }, + { + "prediction": "I'm not sure this is the right place to set the win_id. I think it would be better to set it in the `WebEnginePage` constructor.", + "reference": "Now that you handle this in `webenginetab.py` you can undo all the changes in this file." + }, + { + "prediction": "This is not the right way to do it. You should not catch exceptions in the main method. Instead, you should catch them in the `start` method and call `System.exit(1);` in the catch block.", + "reference": "I think we should log the exception to a log file instead of printing it. The current behavior (not catching the exception) should lead to an automatic print of the exception to the terminal/console." + }, + { + "prediction": "I think this should be an error, not a warning.", + "reference": "These changes to the resource helpers have some more far-reaching implications as they also affect calls made in hive-operator, I believe. It's probably OK still, though. Ideally, the resource helper would not be the one doing the logging, since it cannot know the severity, but that is well beyond something that we should tackle for this PR. I would rather have the hive-operator log warnings than have the syncsetinstance controller log errors." + }, + { + "prediction": "Why do you remove the CASCADE ?", + "reference": "do you really want to change the behavior on foreign key ?" + }, + { + "prediction": "I think this should be `if (json_array_size (batch->state_trans) > 0) { event_publish_state (batch->event, batch->state_trans); json_decref (batch->state_trans); batch->state_trans = NULL; } else { json_decref (batch->state_trans); batch->state_trans = NULL; }`", + "reference": "Looks like my bad. Thanks for fixing!" + }, + { + "prediction": "I think this should be called `replace_variables` instead of `no_replace_variables` to be consistent with the rest of the codebase.", + "reference": "I think \"Don't replace variables ...\" would be cleaner." + }, + { + "prediction": "I think this should be `param.String(default=None, allow_None=True, doc=...)`", + "reference": "Do you validate the possible strings? I've not read the code below but we should make sure if a string is supplied it is validate..." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think we want to make sure that we don't reuse the same scratch disk for multiple VMs, so I added the `w.ID()` to the scratch disk name.", + "reference": "I'd recommend using generateDataDiskName here as well -- might as well benefit from the safety that it gives to protect yourself from future changes to w.ID()." + }, + { + "prediction": "I think this should be `long` instead of `Long`.", + "reference": "qq: do we want to include anything in the name to indicate that it is a position in the manifest?" + }, + { + "prediction": "I think we can remove this now, right?", + "reference": "These logs should probably use the `LOGTAG`" + }, + { + "prediction": "I think it's better to use `github.com/mysteriumnetwork/wireguard-go/device` and `github.com/mysteriumnetwork/wireguard-go/tun` here.", + "reference": "From this, it was clear, that we are using our version of wireguard-go. And now it looks like we are using original packages which is confusing." + }, + { + "prediction": "I think it's better to keep it as `e.ToString()`.", + "reference": "Any particular reason for this? This potentially will make harder to investigate users issues" + }, + { + "prediction": "I think this should be `(Blockly.highlightedConnection_ != closestConnection && Blockly.localConnection_ != localConnection)`", + "reference": "Do you also need to check if Blockly.localConnection_ is non-null?" + }, + { + "prediction": "Style/ClassAndModuleChildren: Do not use nested modules, use nested class instead.", + "reference": "Not really a container, and it's not just about non-config data, not sure of a better description, @myronmarston ?" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "The desktop app will load this fine. on iOS I get `TypeError: undefined is not an object (evaluating '_$$_REQUIRE(_dependencyMap[8], \"stream\").Readable.Readable')` if I change it to `const Readable = require('stream').Readable;` or `const { Readable } = require('stream');` I get undefined errors from the stream on iOS: `[TypeError: stream.on is not a function. (In 'stream.on(\"data\", function (chunk) { return chunks.push(chunk); })', 'stream.on' is undefined)]` What am I missing?" + }, + { + "prediction": "Why do we need to make a copy here?", + "reference": "this is needed since the chunk feeder shares memory across calls to the pipeline. this is in order to avoid multiple allocations. this change mimics the behavior of shed and localstore, and copies the data from the call into the in-memory store" + }, + { + "prediction": "Why is this here?", + "reference": "wut. We can do this at the beginning of tests if we want right? Why are we depending on init?" + }, + { + "prediction": "I'm not sure this is the right fix. I think we need to move the `srv.mu.Unlock()` above the `if acc != nil && acc != srv.gacc` check.", + "reference": "Same trick here IMO." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to make this work.", + "reference": "Should be `@origin = element || origin || POINTER`" + }, + { + "prediction": "I think we can remove this check as we are already doing it in singleCstorSPCUpgrade and bulkCstorSPCUpgrade.", + "reference": "this example needs a fix?" + }, + { + "prediction": "I think this should be `wlr_xdg_toplevel_send_close(surface->toplevel);`", + "reference": "Is it safe to assume this surface is a toplevel?" + }, + { + "prediction": "I don't think this is the right way to clone a context. You need to create a new `projCtx_t` and then copy all the data from the old one to the new one.", + "reference": "we don't need that function" + }, + { + "prediction": "I don't think we need to add a new enum value for this. We should be able to use the existing `WINDOWS` enum value.", + "reference": "we'll also have to think about adding \"Windows Server 2014\" or whatever they come up with later." + }, + { + "prediction": "This method is not used anywhere. Can we remove it?", + "reference": "curious do we have an API to fetch an inactive flow?" + }, + { + "prediction": "I'm not sure why this was removed, but I think it should be restored.", + "reference": "This branch is not needed anymore because every `vnode` that passes through `h` in compat or core will have the `$$typeof`-property now ." + }, + { + "prediction": "I think this should be `return shouldMatchElement(getComposedParent(el));`", + "reference": "Did you mean to use `hasAttribute`? You shouldn't. This does not improve performance and it messes with the readability." + }, + { + "prediction": "This import is not needed anymore.", + "reference": "Please import modules and not classes (except for Qt stuff)." + }, + { + "prediction": "I don't think we need this method.", + "reference": "Hm... why do we have a \"DummyJavaNode\" in src/main? Looks like, this should have gone into src/test...." + }, + { + "prediction": "I think this should be `// Package v1alpha1`", + "reference": "This seems meaningless. If we cannot add any info let us remove this." + }, + { + "prediction": "I think this should be `GetPortBindings` to be consistent with the other getters.", + "reference": "Can you rename `Ports` to `PortsUnsafe`?" + }, + { + "prediction": "Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.", + "reference": "This feels like it could be moved out to your first gem!" + }, + { + "prediction": "I'm not sure this is the right thing to do here. I think we should be able to remove the `requestId` parameter from the `poll` method. The `poll` method should just return the next request in the queue. If we want to remove a specific request from the queue, we should have a separate method for that.", + "reference": "The expected behaviour for `poll` would be to match what `Deque` does, which is: > Retrieves and removes the head of the queue represented by this deque As such, you shouldn't need the `RequestId` here." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "This is super minor, but it'd be nice if this iterated over an arbitrary number of array inputs." + }, + { + "prediction": "I think you can just use `MAX_PATH` instead of `MAXIMUM_PATH` here.", + "reference": "What is the problem here? The commit message has strange wording \"readlink is defined with restrict pointers\": do you mean \"restricted\"? Is that a well-defined language term? I'm not sure what it means." + }, + { + "prediction": "I think we can remove this import.", + "reference": "Why are we not wrapping here?" + }, + { + "prediction": "`ParameterFilterData::parameter` can be `null`", + "reference": "I though that all data objects are being unified in the fashion where all default values are initialized in constructor, are not they?" + }, + { + "prediction": "100000000000000000\",\n \t\"libflux/flux-core/src/ast/transform.rs\": \"0000000000000000000000000000000000000000000000000000000000000000\",\n \t\"libflux/flux-core/src/ast/value.rs\": \"0000000000000000000000000000000000000000000000000000000000000000\",\n \t\"libflux/flux-core/src/ast/visitor.rs\": \"000000000000000000000000000000000000000000000000000000000", + "reference": "Does this file actually need to be committed to git? Having to run `make generate` is rather tedious on each PR and it conflicts easily." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we want to keep the old behavior, which is that if the user doesn't specify a credential file, we try to find one in the default locations.", + "reference": "We don't need this anymore, as Google's library handles various auth mechanisms for us. We'll be less explicit about why we're failing but we gain support for several authentication methods- swings and roundabouts!" + }, + { + "prediction": "I think this should be `default:\"/var/lib/docker-volumes\"`", + "reference": "No need to speficy attribute here. Moreover in yaml it is default to use lowercase names." + }, + { + "prediction": "I think we can remove this line.", + "reference": "In general I'm a trying to understand the reason behind this PR. Looks like if a blob (name) already exists we check if the contents are identical? In what scenarios this is not the case? When we want to publish a package/asset that has changed but still we want to use the same version?" + }, + { + "prediction": "I think we should add a user agent that includes the version of Forseti we're using.", + "reference": "Can rename `req` to be `opener`, since that is the object, and it wraps `req` internally?" + }, + { + "prediction": "`breakpoint` is a reserved keyword in Python 3.7 and later. Please rename it to something else.", + "reference": "@MichaelDCurran, thoughts on adding a breakpoint format field attribute? It seems almost app specific, but I guess it does seem odd abusing line-prefix. Is there any more generic concept here?" + }, + { + "prediction": "I think this should be `return self._execute(Command.GET_ELEMENT_RECT)['value'] if self._w3c else self.size, self.location`", + "reference": "This would return a tuple of two dictionaries. You need to combine them and return a dictionary" + }, + { + "prediction": "I think we can remove this import.", + "reference": "What do you think of moving the example to the help text of the prompt? and the prompt itself can be \"What is your application's GitHub repository URL?\"" + }, + { + "prediction": "I think this should be `1593493828000000000L` or `15934938280000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "reference": "Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs." + }, + { + "prediction": "This should be `std::distance(first, last) >= 9`", + "reference": "Nice use of std::distance. I'm a bit worried about first += 9 though." + }, + { + "prediction": "I think this should be `app.kubernetes.io/part-of: prometheus-operator`", + "reference": "Shouldn't this be `app.kubernetes.io/managed-by` as prometheus-operator manages this resource, but this resource isn't a part of prometheus-operator?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the right thing to do for now. If we don't have the `Tags.InstrumentationName` tag, then we don't know if the parent span was instrumented by this profiler or not.", + "reference": "As long as we're being extra-vigilant about NREs, should we check that `httpMethod` and `requestUri` are not null?" + }, + { + "prediction": "I think it's better to put xrc20 under `token`", + "reference": "No need to have `xrc20` alias" + }, + { + "prediction": "I'm not sure I like the name `context_cls_inst`. It's not clear to me what it means. How about `define_context_cls_inst` or `define_context_cls_instance` or something like that?", + "reference": "the naming convention I'm been adopting if `_type` for instances of these classes. So maybe `context_config_type` is a better name for this fn" + }, + { + "prediction": "I think this should be `private final Boolean gpuMining = false;`", + "reference": "Don't call it GPU mining, call it `externalMining`, here and throughout." + }, + { + "prediction": "I think this should be `imageMaxHeight` and `imageMaxWidth`", + "reference": "`within this with` typo, should be `within this width`" + }, + { + "prediction": "I don't think we need to disable openapi-gen for this field.", + "reference": "how come this is false?" + }, + { + "prediction": "I'm not sure this is the best way to do this, but it works for now.", + "reference": "How about `Object.prototype.toString`? Or using the `typeof` operator?" + }, + { + "prediction": "I think this should be `ctx context.Context` instead of `ctx context.Context, cancel context.CancelFunc`.", + "reference": "I know @jzila suggested this, but I disagree: you're really not supposed to save a context in a struct. Can you get by with just saving the `Done()` channel instead? The `ctx` should continue to be passed around explicitly." + }, + { + "prediction": "I think you can remove the `IsWindows` check here as well.", + "reference": "This check isn't right though." + }, + { + "prediction": "I think this should be `public abstract String getCodeGenVersion();`", + "reference": "maybe `toolkitVersion` instead? It doesn't necessarily have to be called that in the generated code, but in the view model classes, I think it makes it clearer that it is the version of toolkit itself." + }, + { + "prediction": "`uploadResp` -> `uploadResponse`", + "reference": "the response data was added intentionally in #612, i think we could keep the `setFileState` stuff here as a special case, at least for now" + }, + { + "prediction": "I'm not sure about this change. I don't think we want to wait until the deadline has passed. I think we want to wait until the deadline has been reached.", + "reference": "This isn't really easy to read." + }, + { + "prediction": "can you revert this change?", + "reference": "This line changed due to go formatting. Format was not there earlier." + }, + { + "prediction": "I think this should be `upstream.Without` instead of `staticUpstream.Without`.", + "reference": "The name \"Without\" in code is a little nebulous. Maybe something more descriptive like TrimPrefix or StripPrefix or WithoutPathPrefix or something like that. (Thoughts?)" + }, + { + "prediction": "I think this should be a 400, not a 403. 403 means \"you don't have permission to do this\". 400 means \"you did something wrong\".", + "reference": "is this test in the move tests? I see what you mean then - it works, but I wonder if we won't lose track that it's being tested here." + }, + { + "prediction": "This should be `map[string][]string`", + "reference": "I'm not sure if this wanted to be `json:\"tags\"` (which I'd set in my PR) or `json:\"tag\"` that someone elses PR had set. Given that the rest of the fields had their JSON field name set to the same as the struct field name, I opted for `tags`." + }, + { + "prediction": "Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.", + "reference": "since the logic here and in `Proposal` is exactly the same, do you think it makes sense for us to include it elsewhere? I am not opposed to duplicated code when it makes sense, but the reason I first identified this was that I was looking for code in NCR::WorkOrder that was not specific to Work Orders. Seems like fiscal year logic might be helpful for reporting for other clients. In that case, we'd want this scope on those client data classes as well. Might be wrong to include this in the FiscalYear mixin, but it does seem like it should be outside of Proposal and WorkOrder. Does that make sense?" + }, + { + "prediction": "I think it would be better to use `self.connection.add_timeout(5, self.connect_to_rabbitmq)` instead of `connection.add_timeout(5, self.connect_to_rabbitmq)`.", + "reference": "there is no static method as a go between -- how does this work?" + }, + { + "prediction": "Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.", + "reference": "Can you please change the name of this class to be something else?" + }, + { + "prediction": "`h2o_iovec_t *value, int coma_separator` -> `h2o_iovec_t *value, int comma_separator`", + "reference": "I think we might prefer generalizing the interface rather than creating an exception. Current design of `h2o_next_token` assumes the input to be a comma-separated list, and allows the caller to specify a different separator when parsing a nested list. As I understand, what we are trying to attain in this PR is to have a way of parsing a flat list of semicolon-separated list. Assuming that is the case, I think it would be better to change the API of the function to accept two separators (i.e. inner and outer), where for our existing use-cases `outer` would be `,`." + }, + { + "prediction": "Why do we need to remove the recycling here?", + "reference": "why not recycling? I Lru cache now recycling?" + }, + { + "prediction": "I think this should be `PaymentVersionV3`", + "reference": "Why it is now called `PaymentVersionV3`?" + }, + { + "prediction": "I don't think we need to log this at all.", + "reference": "changed for debug purpose?" + }, + { + "prediction": "I think this should be `this.exporter.SetParentProvider(parentProvider);`", + "reference": "@cijothomas I needed a way to set the Exporter.ParentProvider when the Processor's gets set. Internal to SDK though." + }, + { + "prediction": "I don't think this is the right place for this change.", + "reference": "Talking through this scenario with @srividyacb and she's wondering if there should also be a check of `(from_trunk && node_based_graph.GetEdgeData(eid).flags.road_classification.IsLinkClass())` as highways with trunk classifications can also have this scenario." + }, + { + "prediction": "Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.", + "reference": "where does `master_certname` come from?" + }, + { + "prediction": "Please add a blank line after `__all__`.", + "reference": "The line breaking is unnecessary." + }, + { + "prediction": "I think this is a bug. If you have a file like this: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 ", + "reference": "why not enable split by space here ?" + }, + { + "prediction": "(style) spaces required around that '||' (ctx:VxV)", + "reference": "Shouldn't the operator be && ?" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "My best guess is that you want to use host.name in these parts to get the name of the host ?" + }, + { + "prediction": "I think we can remove the `nodeType` field from the `Node` struct now.", + "reference": "IMO this edge case handling could remain here, just instead of overwriting the `n.nodeType`, the `makeEdgeType` method of `n` should be called, so `n.nodeType = nodeTypeEdge` -> `n.makeEdge()`" + }, + { + "prediction": "I think this should be `showAutoDownloadReport || UserPreferences.showDownloadReport()`", + "reference": "Just wondering... The two kinds of notifications are now quite different (Channel, text, maybe even icon). Would it make sense to extract the auto download notification to a new class instead of handling everything in the existing `notificationManager`? I have not checked if this will lead to a lot of code duplication, though." + }, + { + "prediction": "I think this should be `if c.ic == nil { return transport.RequestFeatures{}`", + "reference": "Do we need to put this on the Call? We only need the API communication between the Encoding and the Transports which is currently done through the Transport.Request. The Call is used by users right?" + }, + { + "prediction": "I'm not sure if this is the right place to put this, but I think it would be useful to have a `ListAPIKeys` method in the `WebAPI` interface, and then implement it in the `WebAPIImpl` struct. This way, we can call `ListAPIKeys` on the `WebAPI` interface, and it will call the `ListAPIKeys` method on the `WebAPIImpl` struct, which will call the `ListAPIKeys` method on the `WebAPIImpl` struct, which will call the `ListAPIKeys` method on the `WebAPIImpl` struct, which will call the `ListAPIKeys` method on the `WebAPIImpl` struct, which will call the `ListAPIKeys` method on the `WebAPIImpl` struct, which will call the `ListAPIKeys` method on the `WebAPIImpl` struct, which will call the `ListAPIKeys` method on the `WebAPIImpl` struct, which will call the `ListAPIKeys` method on the `WebAPIImpl` struct, which will call the `ListAPIKeys` method on the `WebAPIImpl` struct, which will call the `ListAPIKeys` method on the `Web", + "reference": "`ctx` is unused in GenerateAPIKey" + }, + { + "prediction": "I don't think this is the right thing to do here. If we can't open the DB, we should return an error and let the caller decide what to do.", + "reference": "Can you judge the type of error?" + }, + { + "prediction": "I don't think this is correct. `np.convolve(data, [0.5, 0.5], 'valid')` is equivalent to `np.convolve(data, [0.5, 0.5], 'same')[:-1]`.", + "reference": "Much simpler than a weird and confusing ``convolve`` call!" + }, + { + "prediction": "I think this is a bug in the test. I think it should be called 3 times.", + "reference": "Huh, this seems weird to me... Surely the suspenders render was called again in order to get the new `
Hello second 2
` output... Imma take a peak at these tests to understand what's going on" + }, + { + "prediction": "Align the elements of a hash literal if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Since this is just a helper function to create text, perhaps this could live in a helper? I noticed that we have a few other error/message creators in the application controller as well, but I think this type of function should be re-factored to be part of a helper." + }, + { + "prediction": "I think this should be `msg-template=[{msg_id}] {path}:{line:3d}:{column:3d}: {msg}`", + "reference": "Will this mess up parsing the messages by other editors? (vscode, vim ...)" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." + }, + { + "prediction": "I think we need to check for null here. I don't think it's possible, but I'm not 100% sure.", + "reference": "Why can the pool be null?" + }, + { + "prediction": "I don't think this is correct. Lists should not be readonly.", + "reference": "It might be good to have a note here: > work-around for issue #7562 allowing us to differentiate presentational lists from interactive lists (such as of size greater 1 and ARIA list boxes). In firefox, this is possible by the presence of a read-only state, even in content editable." + }, + { + "prediction": "This should be `protected Set> outNodes = new HashSet>();`", + "reference": "This set of changes is the one part of this that I'm not completely sure is valid. Can someone look over this to make sure I got the E's right?" + }, + { + "prediction": "I think this should be `if (pull.head.is_zero () || pull.end.is_zero ())`", + "reference": "There doesn't seem to be a reason to copy this here." + }, + { + "prediction": "I think this should be `#include \"h2o/ebpf.h\"`", + "reference": "We've avoided including h2o headers in BPF programs because it's a runtime dependency. However, IIRC, this is because h2olog was maintained in the separate repository so that h2olog did not know where h2o was installed. Now h2olog can use `H2O_ROOT`, we should add it to BCC's `cflags` in order to include h2o headers in BPF programs." + }, + { + "prediction": "I think this should be `AlertQueryURL` to be consistent with the rest of the struct.", + "reference": "I think the docstring here should include the CLI arg `--alert.query-url` just to make it clear to users which setting this uses." + }, + { + "prediction": "I'm not sure this is correct. I think we need to add the external node CIDRs to the ipset here as well.", + "reference": "Same change just above?" + }, + { + "prediction": "I think it would be better to test this with a cyrillic letter that is not \"l\".", + "reference": "Could you check the result content rather than just the number of search results please? For example with this test if the search engine suddenly starts returning \"latin n\" for both queries, we won't know about it." + }, + { + "prediction": "I'm not sure I like the name `agentlessID` here. It's not clear to me what it means. Is it an agent that doesn't do anything? Is it an agent that doesn't have a workload? Is it an agent that has a workload but doesn't use it? I think it would be better to name it something like `workloadID` or `workloadAgentID` or `workloadAgentlessID` or `workloadAgentlessAgentID` or `workloadAgentlessWorkloadID` or `workloadAgentlessWorkloadAgentID` or `workloadAgentlessWorkloadAgentlessID` or `workloadAgentlessWorkloadAgentlessAgentID` or `workloadAgentlessWorkloadAgentlessWorkloadID` or `workloadAgentlessWorkloadAgentlessWorkloadAgentID` or `workloadAgentlessWorkloadAgentlessWorkloadAgentlessID` or `workloadAgentlessWorkloadAgentlessWorkloadAgentlessAgentID` or `workloadAgentlessWorkloadAgentlessWorkloadAgentlessWorkloadID` or `workloadAgentlessWorkloadAgentlessWorkloadAgentlessWorkloadAgentID` or `workloadAgentlessWorkloadAgentlessWork", + "reference": "nit: I think that `workloadID` should suffice for this test... that's what we'd be issuing anyways" + }, + { + "prediction": "Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body end.", + "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." + }, + { + "prediction": "I don't think we should catch `NoClassDefFoundError` here. It's a runtime error, and we don't want to silently ignore it.", + "reference": "We should have a rule to detect identical catch branches" + }, + { + "prediction": "Why are these removed?", + "reference": "remove these from the targets file." + }, + { + "prediction": "why is this removed?", + "reference": "now that we have the signature in the hive messages, it might be that this must be drastically reduced, since there are limits on the protobuf reader/writers i believe" + }, + { + "prediction": "Can you update the version of `google-auth-httplib2` to `0.0.4` as well?", + "reference": "I recommend that we move this to be optional, as other users might not need it. Can you look at `OPTIONAL_PACKAGES` section, around line 68?" + }, + { + "prediction": "I think we should avoid `import java.util.*` and `import static org.assertj.core.api.Assertions.*`.", + "reference": "I usually set idea to never use wildcard import such as `import java.util.*;` Now i use setting from javaslang standard." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Layout/SpaceInsideBlockBraces: Space between { and | missing.
Layout/SpaceInsideBlockBraces: Space missing inside }.
Layout/SpaceAfterComma: Space missing after comma.
Layout/SpaceAfterComma: Space missing after comma.
Layout/SpaceAfterComma: Space missing after comma.
Layout/SpaceAfterComma: Space missing after comma.
Layout/SpaceAfterComma: Space missing after comma.
Layout/SpaceAfterComma: Space missing after comma.
Layout/SpaceAfterComma: Space missing after comma.
Layout/SpaceAfterComma: Space missing after comma.
Layout/SpaceAfterComma: Space missing after comma.
Layout/SpaceAfterComma: Space missing after comma.
Layout/SpaceAfterComma: Space missing after comma.
Layout/SpaceAfterComma: Space missing after comma.
Layout/SpaceAfterComma: Space missing after comma.
Layout/SpaceAfterComma: Space missing after comma.
Layout/SpaceAfterCom", + "reference": "Where is host['ips'] coming from?" + }, + { + "prediction": "I don't think we need this anymore.", + "reference": "oh! missed a `:` here; let me fix that; also can get rid of the intermediate variable" + }, + { + "prediction": "Use the new Ruby 1.9 hash syntax.", + "reference": "Is this necessary?" + }, + { + "prediction": "I don't think it's a good idea to put all the utils in one file. It's better to separate them into different files.", + "reference": "I'd create a different method for each render section." + }, + { + "prediction": "I think this should be `private boolean isReverted = true;`", + "reference": "Instead of storing the revert flag in the tracer is it possible to use org.hyperledger.besu.ethereum.mainnet.TransactionProcessor.Result#getRevertReason? (via org.hyperledger.besu.ethereum.transaction.TransactionSimulatorResult#getResult)? If a TX reverts without a reason do we get an empty revert reason or a revert reason with zero bytes?" + }, + { + "prediction": "I think we can remove the `readOrcSchema` parameter from the `SparkOrcReader` constructor.", + "reference": "I think this should test with and without container reuse if that is implemented in this PR. Probably just make this test parameterized." + }, + { + "prediction": "I don't think this is correct. The spec id is not always the 14th field in the manifest file. It depends on the number of fields in the manifest file.", + "reference": "These modifications allow BaseFile to translate into a SparkRow with the specID as a column" + }, + { + "prediction": "I think we can just do `return new ReadPreference(readPreference);` here. If `readPreference` is already a `ReadPreference` instance, it will be returned as is.", + "reference": "is this something we've been missing this whole time?" + }, + { + "prediction": "I think this should be `allEvents` instead of `AllEvents`", + "reference": "nit: this is a package-wide constant so better to narrow the scope like `allEventsSign`." + }, + { + "prediction": "I think you can remove the `auth_thrift = 'authentication.thrift'` line and just use `auth_cmd = ['thrift', '-r', '-I', '.','--gen', 'py', os.path.join(thrift_files_dir, 'authentication.thrift')]`", + "reference": "There seems to be some repetition. Does a local function make this code shorter overall?" + }, + { + "prediction": "I think this should be `isHydrating = true;`", + "reference": "Might be cheaper to reuse the `null` assignment of line 313 and set `isHydrating` to null instead WDYT?" + }, + { + "prediction": "nit: remove empty line", + "reference": "Revert this blank line" + }, + { + "prediction": "I think this should be `System.clearProperty(\"solr.hdfs.blockcache.blocksperbank\", \"512\");` and `System.clearProperty(\"tests.hdfs.numdatanodes\", \"1\");` instead of `System.clearProperty(\"solr.hdfs.blockcache.blocksperbank\");` and `System.clearProperty(\"tests.hdfs.numdatanodes\");`", + "reference": "This was introduced recently for the Hadoop 3 upgrade. Copy/paste error but definitely causing some of the new test failures." + }, + { + "prediction": "Metrics/LineLength: Line is too long. [101/80]", + "reference": "I think we should only need to do this for `:approve` since we are using `authenticate_user!` for all other actions and that checks for disabled client" + }, + { + "prediction": "I don't think this is a good test. If you want to test that the Content-Length header is present, you should test that it is present in the response, not that it is present in the headers of the request. You should also test that the value of the Content-Length header is correct.", + "reference": "I wonder if we should create new tests for header checks; here for instance we're mixing querystring and headers. Thoughts?" + }, + { + "prediction": "I think this should be `apply::helpers::custom_facts`", + "reference": "We should be able to add sensitive by hard-coding the parameters, same as you put into the metadata in apply_helpers." + }, + { + "prediction": "This file is empty. You can remove it.", + "reference": "Why do you think that it is necessary to create this class?" + }, + { + "prediction": "I think this should be `r.Seek(0, 0)`, not `r.Seek(start, 0)`.", + "reference": "replacing the `1` with `io.SeekCurrent` may be good here" + }, + { + "prediction": "I think this should be `jose.JSONWebKeySet` instead of `*jose.JSONWebKeySet`.", + "reference": "nit: perhaps this file would be better named `jwks_source.go` ?" + }, + { + "prediction": "I think this should be `param_override.properties` instead of `param_override.properties`.", + "reference": "It will be helpful to specify the intended priority as well for the properties within this file." + }, + { + "prediction": "I think this should be `type RunFunc = func(*exec.Cmd) ([]byte, error)` so that we don't have to import `github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/common/utils/exec` everywhere.", + "reference": "Make this private and update all the public functions to not take this argument. The variable you set below should also be private, then in the tests instead of passing the variable in to the function just update the variable. We don't want to expose the testing implementation in the public api if it can be avoided." + }, + { + "prediction": "I think this should be \"/user/trafodion/hive/tpcds/customer/customer.dat\" instead of \"/user/trafodion/hive/tpcds/customer/customer.dat\"", + "reference": "Do you now why is it a specific table name is used as a default?" + }, + { + "prediction": "I think this should be `Path.Combine(Environment.GetEnvironmentVariable(\"HOME\"), \"myagent/_work/_temp\")`", + "reference": "If all you're doing is checking for the existence of a directory as your \"temp\" directory, why does it matter what OS you're on?" + }, + { + "prediction": "I think we can remove this line now that we're using `echo` instead of `gorilla/mux`", + "reference": "nit- would be cleaner to import it once" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should only add the `Access-Control-Allow-Headers` header if the `Access-Control-Request-Headers` header is present in the request.", + "reference": "Looks like there is a closing parenthesis `)` missing here." + }, + { + "prediction": "I don't think you need the `128` here. The `str` array is already declared as `char str[128]`.", + "reference": "this one bothers me. There are many places where this one is written to for an error message and just a single callsite is changed." + }, + { + "prediction": "I don't think this is necessary, since we don't actually call `FastForwardBackoff` in this test.", + "reference": "You can put this in `kbfsOpsInit()` in you want, so we don't have to call it in every test." + }, + { + "prediction": "I think this should be `#if defined(ARM_32) && defined(DRX_COUNTER_64BIT)`", + "reference": "`ARM_32` is what clients define as an input to DR, and is not always defined internally: we use just `ARM` to mean AArch32." + }, + { + "prediction": "I think we can remove the `originalSchema` field and just use `schema` everywhere.", + "reference": "s/for use/to use for/" + }, + { + "prediction": "I think this should be `avatar_id` instead of `avatar_filename`", + "reference": "` $event->getAvatarFilename()` this function return `string` or `null`. In this place ` $event->getAvatarFilename()->getValue()` return `Fatal error `" + }, + { + "prediction": "I don't think we want to change this to Unavailable. This is not a transient error, it's a permanent one.", + "reference": "why not creating a new error type for server's own resource limit exceed error and do conversion within rpc interceptor?" + }, + { + "prediction": "I think it would be better to keep the default value as `new CompositeTextMapPropagator(new TextMapPropagator[] { new TraceContextPropagator(), new BaggagePropagator(), });`", + "reference": "Could be a timing thing here. When options are created they'll copy the ref for the current default propagator. If user sets through SDK the global propagator after that, it won't be reflected. Could leave it null here and then when it is used in instrumentation do `options.Propagator ?? Propagators.DefaultTextMapPropagator`. It would be a slight perf hit but it makes it hot-swappable." + }, + { + "prediction": "This line is not needed anymore.", + "reference": "Unrelated file. Please remove from PR." + }, + { + "prediction": "This should be `send_worker_msg(q,w,\"Access-Control-Allow-Origin: *\\n\");`", + "reference": "Careful: you only want two newlines after the final header message. (That indicates the end of headers and the start of data.)" + }, + { + "prediction": "I think this should be `flow.request.headers['Upgrade-Insecure-Requests'] = '1'`", + "reference": "This will not work on Python 3 (to which we are transitioning) because `.content` is bytes, not a str. Can you make the pattern a bytes object as well (like so: `b\"pattern\"`)?" + }, + { + "prediction": "I'm not sure about this change. I think it should be `requiredOwned: ['textbox', 'listbox', 'tree', 'grid', 'dialog'],`", + "reference": "This was to allow the tests to pass when the order of the required was different. Silly, but we don't have an easy way to check for \"equal but order doesn't matter\" in chai." + }, + { + "prediction": "I think this should be `if (CmpCommon::getDefault(HBASE_DELETE_COSTING) == DF_ON)`", + "reference": "maybe say \"returns the default cost method that returns an object of cost 1\"." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we want to allow VXLAN and IPinIP encapsulated traffic to pass through the iptables chain, but we want to drop VXLAN and IPinIP encapsulated traffic that originates in the pod.", + "reference": "I believe these rules will be enforced both (1) on egress from a local workload, and (2) on ingress **to** a local workload. Right? I understand that we definitely want (1), but do we really want to enforce (2) as well?" + }, + { + "prediction": "I think this should be `response.asString()` instead of `response.fullResponseAsJSONObject()`", + "reference": "Use `response.asJsonObject()` instead. Also, use `put()` instead of `putOpt()`, `null` as a value is fine." + }, + { + "prediction": "I'm not sure if this is the best way to test this. I think it would be better to check if the z-index is greater than 0. What do you think?", + "reference": "Are you sure? We've changed it during an introduction of the IME support." + }, + { + "prediction": "I think this should be `if (null !== $dqlFilter && !empty($dqlFilter)) {`", + "reference": "I think here we want the use of `empty()` to take care of empty strings. If you put `dql_filter: ''` in your YAML config ... this will add `->andWhere('')` and it will fail, right?" + }, + { + "prediction": "I don't think we need to return an error here. We can just log it and continue.", + "reference": "this is golang's named return, err is defined, `return` is equivalent to `return err` the current code has no problem" + }, + { + "prediction": "I don't think this is correct. It's a pointer to a #GString, not a #GString.", + "reference": "I don't think this is right; in Rust terms it's like a `&mut String`, in Java `StringBuilder` - it's not a return value from the function which is what `(out)` is for." + }, + { + "prediction": "I don't think this is correct. If `label_channels` is 3, and `labels` is [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60,", + "reference": "If the label is not binary, should we rename this function?" + }, + { + "prediction": "I don't think we need to use BeanShell for this. We can just use JMeter's built-in function `${__BeanShell(import org.apache.jmeter.services.FileServer; FileServer.getFileServer().getBaseDir();)}`", + "reference": "This is very-very bad idea because of its performance impact" + }, + { + "prediction": "I think it's better to use `sonm` instead of `github.com/sonm-io/core/proto`", + "reference": "WHY U NOT SORT IMPORTS?" + }, + { + "prediction": "I'm not sure if this is the right place for this helper, but I think it makes sense to have it in the `SignInRequestHelpers` module since it's related to the sign in request.", + "reference": "Put a comma after the last item of a multiline hash." + }, + { + "prediction": "I don't think we need to import `Dimensioned` here.", + "reference": "How come we need ``Dimensioned`` in the top-level namespace?" + }, + { + "prediction": "Please revert this change, it's unrelated to the PR.", + "reference": "excess whitespace through plugin." + }, + { + "prediction": "`std::size_t{ 0 }` -> `0`", + "reference": "What is the problem here? I feel we used this in a lot of places." + }, + { + "prediction": "I think we can remove the `for proposals, meta in zip(proposal_list, img_metas)` loop.", + "reference": "Update the docstring." + }, + { + "prediction": "I think we can remove this import.", + "reference": "delete the empty line \"github.com/pkg/errors\" should be grouped with other third party packages same for the rest" + }, + { + "prediction": "I don't think this is correct. `capabilities` should not be modified.", + "reference": "Assigning capabilities to the field here is not the best idea. Semantically this field contains the capabilities returned by the browser after session start. So here we sould better amend capabilities and return them from `init` method to pass later to `startSession` method (that will assign the capabilities returned by the browser to the field)." + }, + { + "prediction": "I think we should keep this alias for backward compatibility.", + "reference": "Is this a breaking change, or is the API private?" + }, + { + "prediction": "I think this should be `test_data = pd.read_json(\"./dumps/courseData.json\")`", + "reference": "I don't think we need this dependency in this project right now" + }, + { + "prediction": "I think this should be `knative-eventing` instead of `cloud-run-events`", + "reference": "I don't think this is necessary since `CommonLabels` is a public func and every component name is also public constant." + }, + { + "prediction": "I think this should be an array of strings, not an array of an array of strings.", + "reference": "The `_example` field should be updated to include an interpreter with an array value." + }, + { + "prediction": "I'm not sure if this is the right place to put this note, but I think it should be in the `SupportedProtocols` docstring.", + "reference": "Put this in the godoc of SupportedProtocols instead. Preferably we would just use one map though. Why not just use this one?" + }, + { + "prediction": "I think we should keep the `name` field in the `ContainerMetadata` struct. It is used in the `CronContainer.String()` method, which is used for logging. If we remove the `name` field from the `ContainerMetadata` struct, we will have to change the `CronContainer.String()` method to use the `DockerID` field instead of the `name` field. I think it is better to keep the `name` field in the `ContainerMetadata` struct and change the `CronContainer.String()` method to use the `name` field instead of the `DockerID` field.", + "reference": "I'd feel a little safer if the first argument were a string, not a *string unless there's a particular reason for making it a pointer." + }, + { + "prediction": "This import is not needed.", + "reference": "Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC." + }, + { + "prediction": "This import is not needed.", + "reference": "You can safely revert changes to this file." + }, + { + "prediction": "I think this is a typo, it should be `-1` instead of `1`", + "reference": "This deletion is unnecessary." + }, + { + "prediction": "I think it would be better to use `React.isValidElement` instead of `typeof smallImage === 'string'` to check if `smallImage` is a valid React element.", + "reference": "I'm not a huge fan of this overloading of the prop; accepting very different types of arguments for props like this can be confusing, and wasn't part of the IB. I understand wanting to import the SVG directly, but the IB suggests using `${global._googlesitekitLegacyData.admin.assetsRoot}${userInputSuccessImage}` as the `src`/`smallImage` value here. It'd be great to refactor this to accept components directly in the future, but let's do that all-at-once rather than this hybrid approach that makes the API less clear." + }, + { + "prediction": "I don't think we should be using `*` imports.", + "reference": "I've had this happen recently with IntelliJ, was this intentional?" + }, + { + "prediction": "I think you can just use `std::unordered_map` instead of `std::map` here.", + "reference": "Order(1) vs Order(logN) -- not sure it's measurable at the ~200 element size of the table. All of the published comparisons start at ~1000 elements." + }, + { + "prediction": "I think it's better to use `github.com/mysteriumnetwork/node/core/location/factory` instead of `github.com/mysteriumnetwork/node/core/location/factory/factory`", + "reference": "I don't know about this aliasing and 'factory'. Previous version was rather straightforward: `location.CreateLocationResolver`. Perhaps `location.CreateResolver` would be even better? What do we actually gain here from moving DI to a separate sub-package?" + }, + { + "prediction": "I don't think this is the right place for this function. It should be in the `Engine` class.", + "reference": "Use `UpperCamelCase` for function names" + }, + { + "prediction": "`Number(value) >= 275761 || Number(value) < 0` -> `Number(value) >= 275761 || Number(value) < -275761`", + "reference": "I'm not 100% sold on this idea but I like it in general. Nice compromise between using the 'Date' constructor where possible and falling back to the pre #5880 behavior when it makes sense. However, instead of `Number(value) < 0`, let's do `Number(value) < MIN_YEAR` because `new Date('-2017')` is perfectly valid in JS and I don't want to break the date behavior." + }, + { + "prediction": "I don't think we need to do this. We should be able to get the znode path from the `ZkStateReader`.", + "reference": "Remember to close SOLR-11877 after this" + }, + { + "prediction": "I'm not sure about this change. I don't think we want to remove the comma.", + "reference": "this change should be reverted" + }, + { + "prediction": "Why do we need this?", + "reference": "This function signature is a bit complicated, some parameters are IN type (stopLoop which is modified from outside), others are OUT (registeredEvent channel which is modified inside function) I suggest the following signature -> SubscribeToRegistrationEvent(identityAddress) returns registeredEvent chan of type (RegisteredEvent not int), Unsubscribe func(), error (in case of any error). That way caller can always cance subscription if needed and check for any errors. Also - unsubscribe function hides any internal details how subscribtion is really implemented" + }, + { + "prediction": "I don't think we need to add this here, as it is already added in the `copy` task.", + "reference": "`.wav`?! cannot we use something slightly more modern and compressed instead? :) I dunno, like `.mp3` or `.aac` or `.ogg`..." + }, + { + "prediction": "I think this should be `lua_pushboolean(L, false);`", + "reference": "Wouldn't a single signal call be enough? (without the boolean even)" + }, + { + "prediction": "Align the elements of a hash literal if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "I suspect that this whole block, which is going to be repeated a number of times, should probably be in a helper. I guess it would need to be given the object and the title and could probably figure out everything else from that?" + }, + { + "prediction": "Style/MutableConstant: Freeze mutable objects assigned to constants.", + "reference": "Should we expose this attribute in the Asciidoctor.js API ?" + }, + { + "prediction": "`get(element._1).map(v -> v.contains(element._2)).getOrElse(false)` can be simplified to `get(element._1).map(v -> v.contains(element._2)).orElse(false)`", + "reference": "I think contains on `Multimap` was broken - it should return true if one of the values is associated with the key? It that right" + }, + { + "prediction": "I think it's better to set the default value to 100.", + "reference": "delete this line" + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "Presumably we no longer need `force: true` here." + }, + { + "prediction": "I don't think you need to check for `ptr == 0` here. `ptr` is a pointer to a pointer, so `ptr == 0` will never be true.", + "reference": "HIP runtime is compiled using a C++ compiler. So comparison to both NULL as well as 0 does not make sense. Just comparing to NULL is sufficient." + }, + { + "prediction": "I'm not sure this is the best way to do this. I think it would be better to pass in the `help_url` and `feedback_url` to the mailer and then use them in the view.", + "reference": "these urls are still in `a` tags so we should probably include these links separately for a non-HTML version" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think we should do this in `addSystemAccountExports` instead. The reason is that `addSystemAccountExports` is called from `configureAccounts` and `addSystemAccountExports` is also called from `addAccountExports`. If we do this in `addSystemAccountExports`, we don't have to worry about the race condition between `configureAccounts` and `addAccountExports`.", + "reference": "That's fine though, meaning that you can send to this channel under the server lock. The internalSendLoop will pick up the change when the server lock is released (if loop is blocked trying to grab the server lock). Even the way you do it here (releasing the lock, sending, then reacquiring) does not guarantee that the internalSendLoop will have time to refresh in that interval." + }, + { + "prediction": "I think this should be prefixed with `goog:`, not `chromium:`.", + "reference": "The name `enableDownloading` implies this is a boolean capability. How about `downloadDir`?" + }, + { + "prediction": "I don't think we need to deprecate this method.", + "reference": "Found one internal team is using this method. Will coordinate with them about the migration solution." + }, + { + "prediction": "I think this should be `DD_TRACE_HTTP_SERVER_ERROR_STATUSES` and `DD_TRACE_HTTP_CLIENT_ERROR_STATUSES`", + "reference": "The field `HttpServerErrorCodes` should be called `HttpServerErrorStatuses`" + }, + { + "prediction": "I think this should be `FORSETI_V2_RULE_FILES`", + "reference": "Can you please make each of these in a separate line. It will be easier to keep them sorted, and add/remove." + }, + { + "prediction": "I think this should be `singleFilePath.isEmpty() && req.getParams().getBool(ConfigSetParams.CLEANUP, false) && !req.getParams().getBool(ConfigSetParams.OVERWRITE, false)`", + "reference": "should we error instead of silently ignoring the `cleanup` param? it defaults to `false`, so someone must have explicitly set it to `true`" + }, + { + "prediction": "I think this should be `archive.File[0].FileInfo().Name()` instead of `archive.File[0].Name`", + "reference": "There is no specific requirement that the root be called `root`, just that there is a single root directory and that it be the first entry in the zip." + }, + { + "prediction": "I think this should be `current_user && current_user.requires_profile_attention?`", + "reference": "perhaps we should encapsulate this logic in a helper method w a test?" + }, + { + "prediction": "Style/RescueStandardError: Avoid rescuing the standard exception class. Specify a more explicit exception instead of using a bare rescue clause.", + "reference": "Now that we're only using this repo as a Gem you shouldn't need to `require` an expanded local file path like below." + }, + { + "prediction": "I don't think this is correct. `granularity.between(EPOCH, timestamp)` returns a `long`, not an `Integer`.", + "reference": "This isn't necessarily a year. It may be months, days, or hours. Can we return `intValue()` directly instead?" + }, + { + "prediction": "I think we should keep this log statement. It's useful to know what's going on in the managed task.", + "reference": "this is redundant because it gets logged immediately on entering the handleContainerChange function" + }, + { + "prediction": "I think this should be `if e := \"EVENT_\" + v.Event; e == model.NotificationEventType_EVENT_DEPLOYMENT_WAIT_APPROVAL.String() {`", + "reference": "`ds.GenericDeploymentConfig.DeploymentNotification` in L128 is nullable." + }, + { + "prediction": "Why do we need this?", + "reference": "this shouldn't be exposed here - this class isn't a carriage for this - its used internally to determine if/how we can mine." + }, + { + "prediction": "I'm not sure if we want to remove these checks. I think it's good to have them in case someone passes in `null` by accident.", + "reference": "It's fine to leave these checks in. It'll make the exception come from `FirefoxDriver`, and that's probably clearer to a user." + }, + { + "prediction": "Layout/SpaceInsideBlockBraces: Space between { and | missing.
Layout/SpaceInsideBlockBraces: Space missing inside }.", + "reference": "We don't want to include the `IntegrationSpecHelper` for models...mind moving this line out of the loop to be `config.include EnvironmentSpecHelper, type: :model`?" + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to be the only way to get the tests to pass.", + "reference": "Please check the return on these." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the `add_tarball` method.", + "reference": "Do we need `==` for true?" + }, + { + "prediction": "why change the default value?", + "reference": "Changing the default value may cause BC-breaking. Suggest changing this value in config." + }, + { + "prediction": "I think this should be `int(slider_pos) - 1`", + "reference": "how does that happen?" + }, + { + "prediction": "I don't think this is needed.", + "reference": "This is gross/clever. :-)" + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "Take a look at the name of this file. Definitely copy and" + }, + { + "prediction": "I think we should not return here. We need to return the error and let the caller decide what to do with it.", + "reference": "Can you check with @mahebbar how to work this error. Should be different from 404." + }, + { + "prediction": "I think we need to keep the upper bound here.", + "reference": "Do we still need the upper bound `<3.9`?" + }, + { + "prediction": "I think this should be `realpath($input_path) === realpath(dirname(__DIR__, 3) . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'psalm') || realpath($input_path) === realpath(dirname(__DIR__, 3) . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'psalter') || realpath($input_path) === realpath(dirname(__DIR__) . DIRECTORY_SEPARATOR . 'psalm') || realpath($input_path) === realpath(dirname(__DIR__) . DIRECTORY_SEPARATOR . 'psalter') || realpath($input_path) === realpath(Phar::running(false))`", + "reference": "Does this mean `vendor/bin/psalm` is not a symlink (or whatever equivalent Windows has for symlinks) on Windows?" + }, + { + "prediction": "This file should be removed.", + "reference": "@lpabon having a separate package name `aws_test` allows to test the package as if the tester was an external package. If the test package name is the same as the package being tested, the test package can also use methods and variables not exposed to the eventual user." + }, + { + "prediction": "Why are we removing these tests?", + "reference": "The exporter should still be able to test these histogram instrument kinds, right? Is there another reason to remove these?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the transaction pool. The transaction pool is the only place that knows about pending transactions, and it's the only place that needs to simulate the effect of putting pending transactions in multiple blocks.", + "reference": "should this increment eval.Round somehow?" + }, + { + "prediction": "Line is too long. [82/80]", + "reference": "Although this change looks good. Maybe there are other inconsistent cases too?" + }, + { + "prediction": "Style/SymbolArray: Use %i or %I for an array of symbols.", + "reference": "This is a way better method name." + }, + { + "prediction": "I'm not sure if this is the right place to put this flash message, but I think it makes sense to have it in the `NewLanguageConfirmationsController` since that's the controller that handles the confirmation.", + "reference": "Prefer single-quoted strings when you don't need string interpolation or special symbols." + }, + { + "prediction": "I don't think this is necessary. If `options` is not an array, then `Array.isArray(options)` will return `false` and `options` will be an empty array.", + "reference": "I was wondering if this should allow per role specification, instead of (or in addition to) a generic \"allowed everywhere\". So you could do: `{ separator: ['aria-valuenow', 'aria-valuemin', 'aria-valuemax'] }`. You could still allow the array, and you could add a wildcard option for the \"generic\" case you've got now: `{ '*': ['always-allowed'] }`." + }, + { + "prediction": "I think this should be `wasHiveString_(FALSE)`", + "reference": "I'm confused by the name. The string was a Hive string but it isn't any longer? Why should we care? (I imagine I'll find the answer later... there is some different semantic that we want downstream...)" + }, + { + "prediction": "I'm not sure about this change. I think it's better to keep the old imports and add the new ones.", + "reference": "Could you please leave the explicit imports?" + }, + { + "prediction": "why change the import name?", + "reference": "Why need alias?" + }, + { + "prediction": "I think this should return a `tlfIDGetter` that always returns an empty `tlf.ID`.", + "reference": "Shouldn't this be a `libfs.nullIDGetter` (exported, of course)?" + }, + { + "prediction": "I don't think we need to change the error message here. The error message should be the same as the error message in the `teal` package, which is `teal: program size too large: %d > %d`.", + "reference": "I dislike the messages.go pattern; the strings are only used once and make more sense in context. The other two added reportErrorf() calls in clerk.go have inline strings." + }, + { + "prediction": "why remove these two lines?", + "reference": "Seems we don't need it anymore." + }, + { + "prediction": "Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
", + "reference": "This might cause problems with the weird way we publish Guidance and Groups in the UI. We will have to make sure that UAT is thorough." + }, + { + "prediction": "I think this should be `time.Minute` or `time.Second`", + "reference": "this default needs to be on order 1 minute, I'm not sure why we defaulted to 1 hour below..." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in the `caddyfile.go` file where the `Email` directive is parsed.", + "reference": "I figure to make `{env.*}` work, right? I can't think of any other placeholder that makes sense here" + }, + { + "prediction": "Why do you need to create a new port?", + "reference": "Why change the port from 0 to getAvailablePort()?" + }, + { + "prediction": "I don't think this is the right way to do it. We should be able to pass the timeout as a parameter to the `get_locator` method, not as an argument to the `find_element` method.", + "reference": "For me would be great don't repeat timeout sending in every get_locator call. Looks like it should be sent into LocatorsManager init. And possibly it should me non mandatory, something like that: `def __init__ (self, locators, timeout=60):`" + }, + { + "prediction": "I'm not sure if this is the best way to fix this. I think we should be able to set the project name in the `NewGlobalOpts` function, but I'm not sure how to do that. I think we should be able to set the project name in the `NewGlobalOpts` function, but I'm not sure how to do that. I think we should be able to set the project name in the `NewGlobalOpts` function, but I'm not sure how to do that. I think we should be able to set the project name in the `NewGlobalOpts` function, but I'm not sure how to do that. I think we should be able to set the project name in the `NewGlobalOpts` function, but I'm not sure how to do that. I think we should be able to set the project name in the `NewGlobalOpts` function, but I'm not sure how to do that. I think we should be able to set the project name in the `NewGlobalOpts` function, but I'm not sure how to do that. I think we should be able to set the project name in the `NewGlobalOpts` function, but I'm not sure how to do that. I think", + "reference": "I feel like since now we don't initiate the `opts.projectName` with `opts.ProjectName()`, which means `opts.projectName` and `opts.ProjectName()` they don't necessarily equal to each other, we need to also substitute all usage of `opts.ProjectName()` within `Ask()`, `Validate()`, and `Execute()` to `opts.projectName`. Otherwise if `-p` is set, `opts.ProjectName()` will get expired." + }, + { + "prediction": "I don't think we need to check for `null` here.", + "reference": "why do we thinkg that an empty string is ok to return from this method? I think the null should never be passed in here in the first place" + }, + { + "prediction": "`found` is a boolean, not an object, so you don't need to check if it's truthy. You can just do `if (found) { return; }`", + "reference": "nit: can remove this `else` since we return from the condition above." + }, + { + "prediction": "Why is this removed?", + "reference": "You missed `Write(...)`! I'm kidding ofc." + }, + { + "prediction": "I think we can remove the `present?` check here as well, since `upcoming_invoice_for` will return `nil` if `stripe_customer_id` is `nil`.", + "reference": "Was there a customer who had this set to an empty string?" + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.", + "reference": "I know we have the `reporter` spec below, but what about a unit test for this to explain reasoning behind logic? If I were going to update this decorator, I would assume it wasn't covered by tests because there is no unit test." + }, + { + "prediction": "I don't think we should add this method to the public API. It's only used internally by `RestClientRequestImpl` and `RestClientRequestImplTest`.", + "reference": "it's better to be : void attach(String name, Part part);" + }, + { + "prediction": "I think we can remove the throws IOException here as well.", + "reference": "I didn't see where the IOException can get thrown, is this just to match the V1 reader?" + }, + { + "prediction": "I don't think we need this parameter anymore.", + "reference": "We normally suppress this warning with `RDUSED_PARAM(forceRDKit)`" + }, + { + "prediction": "I think this should be `if (it == mappedPlayerGuids.end()) { return nullptr; } else { return it->second; }`", + "reference": "What if `Game::getPlayerByNameWildcard` had not been called before. It would not find a player, wouldn't it?" + }, + { + "prediction": "I think this should be \"Requires Patch\" rather than \"Patch Required\".", + "reference": "Why upper case \"R\"?" + }, + { + "prediction": "I think we can remove this function and just call `BuildRequired` directly.", + "reference": "Does this need to return an error or could it return `false, nil`?" + }, + { + "prediction": "I don't think we need to make this protected.", + "reference": "Can you not change those scopes in public API classes? This applies here and in other places -- protected changed to package-scope for source is not really an API-compatible change." + }, + { + "prediction": "I don't think this is a good idea to remove the default value. If the parameter is not set, it will be `null` which is not the same as `1`.", + "reference": "this parameter is only used in POST, please use `getRequest()->request->get('...');` Thanks" + }, + { + "prediction": "I don't think we need to validate the filename here. The filename is just the name of the file in the package, and we don't have any restrictions on what that name can be.", + "reference": "Problem number 1: Scoped packages would have a `/` character here. Changing this to `validatePackage` resolves the 403." + }, + { + "prediction": "I'm not sure this is the right thing to do. If the key is not valid, it should raise an error. If the key is valid, but the value is not, it should raise an error. If the key is valid, and the value is valid, it should not raise an error. I'm not sure what the right thing to do is, but I don't think this is the right thing to do.", + "reference": "I don't quite get why there would be key errors: ``deep_mapped`` is a clone of ``self`` and ``k`` comes from ``self.items()`` so why would the key ever be rejected?" + }, + { + "prediction": "I think this should be `if req.ChainID != 0 && _, ok := registry.Chains()[req.ChainID]; !ok {`", + "reference": "this chain ID determines only from which chain to withdraw, therefore your changes do not accomplish what you want them to accomplish. You'll need changes to `func (aps *hermesPromiseSettler) Withdraw(chainID int64, providerID identity.Identity, hermesID, beneficiary common.Address) error`. The method probably has to include two chain ids: to and from. Currently, the method internally uses: `aps.config.L1ChainID` -> the chain to withdraw to `chainID` -> the chainID that was passed as the chain that the withdrawal is originating from." + }, + { + "prediction": "I think this should be `if !sc.IsValid() && !sc.IsSampled() { return ctx }`", + "reference": "If instead we had `TraceContext.extract` return a bool value as a second return value, we could avoid the byte array comparison in `TraceID.IsValid`. Did you consider that alternative?" + }, + { + "prediction": "`paginated` should be `false` by default.", + "reference": "here shouldn't we use `depotFreeLimit`?" + }, + { + "prediction": "Line is too long. [81/80]
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer double-quoted strings unless you need single quotes in the string, e.g. to avoid extra backslashes for escaping.", + "reference": "Could we use the Rails application's secret token instead? Do we actually need our own here?" + }, + { + "prediction": "I think it's better to raise `TypeError` in this case.", + "reference": "so should be fixed here also" + }, + { + "prediction": "I think this should be `dmc->size == sizeof(dr_mcontext_t) - sizeof(dr_opmask_t) || dmc->size == sizeof(dr_mcontext_t) - 2 * sizeof(dr_opmask_t) || dmc->size == sizeof(dr_mcontext_t) - 3 * sizeof(dr_opmask_t) || dmc->size == sizeof(dr_mcontext_t) - 4 * sizeof(dr_opmask_t) || dmc->size == sizeof(dr_mcontext_t) - 5 * sizeof(dr_opmask_t) || dmc->size == sizeof(dr_mcontext_t) - 6 * sizeof(dr_opmask_t) || dmc->size == sizeof(dr_mcontext_t) - 7 * sizeof(dr_opmask_t) || dmc->size == sizeof(dr_mcontext_t) - 8 * sizeof(dr_opmask_t) || dmc->size == sizeof(dr_mcontext_t) - 9 * sizeof(dr_opmask_t) || dmc->size == sizeof(dr_mcontext_t) - 10 * sizeof(dr_opmask_t) || dmc->size == sizeof(dr_mcontext_t) - 11 * sizeof(dr_opmask_t) || dmc->size == sizeof(dr_mcontext", + "reference": "I would just remove this assert as it's going to get un-maintainable with a long list of valid sizes. Ditto below." + }, + { + "prediction": "I think this should be `/var/lib/ecs/` instead of `/var/lib/ecs`", + "reference": "`HostDataDir` is misleading. Can we rename it to something more relevant ? The constant should also be moved up and reused as necessary." + }, + { + "prediction": "I think this should be `ipsecESPOverhead = 20 + 8 + 12 = 40` (ESP header is 20 bytes, trailer is 8 bytes, padding is 12 bytes).", + "reference": "I still feel like we are double-counting the outer IP header here (once in `defaultMTUGRE` and once in `ipsecESPOverhead`) but I'm not that familiar with IPsec." + }, + { + "prediction": "I think we can remove the `where T : struct` constraint here.", + "reference": "Not sure what benefit we gain by extending BaseProcessor here, as this seems to be defining a new OnEnd method. Could we modify MeasurementItem to have all the things, and then MeasurementProcessor can be simply extending BaseProcessor (not blocking. just noting some observations in the PR :) )" + }, + { + "prediction": "I think we can remove this blank line.", + "reference": "This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards." + }, + { + "prediction": "I think this is a bit confusing. I would say \"A configured Requestlogger will not log health checks\" or \"A configured Requestlogger will not log health checks by default\".", + "reference": "This seems like a more appropriate message under `ListenAndServe`. WDYT?" + }, + { + "prediction": "Why is this not needed anymore?", + "reference": "Is this not required?" + }, + { + "prediction": "I think this should be `isset($this->entity['search']['sort']['direction']) ? $this->entity['search']['sort']['direction'] : $this->request->query->get('sortDirection')`", + "reference": "We should start thinking of an object that encapsulates this information :) we might need more arguments in the future." + }, + { + "prediction": "I think this should be \"dstStageMask-01173\" and \"srcStageMask-01174\"", + "reference": "Given that we are (conceptually) searching across multiple self-dependencies, all we can say is that we didn't have a self dependency in which *both* source and dest masks were correct. Since the spec doesn't imagine this case, the valid usage statement assume we can differentiate only wrong source from only wrong dest within a *single* self-dependency -- which we can't across multiple (at least not meaningfully)... so we always return both the source/dest VUID's if we can't find a self-dependency in with *both* are correct." + }, + { + "prediction": "I think this test should be renamed to `shouldReturnTrueWhenMiningCoordinatorExistsAndMining()`", + "reference": "rename? MiningCoordinator always exists" + }, + { + "prediction": "I think this should be `plugins.getPluginConfig(\"api\").offline_mode;`", + "reference": "Here would be the same case you don't need to call `loadConfigs`, but you would need to reread configs using `getConfig` on each getHost function call, not once per file." + }, + { + "prediction": "I'm not sure if this is the right place to put this lock, but I think we need to make sure that we don't try to delete a folder while we're in the middle of renaming it.", + "reference": "Unlocking with defer means that this lock is still held curing the call to forgetNode(), below, which I see attempts to acquire `f.mu`, which looks dangerous to me." + }, + { + "prediction": "I'm not sure why this is needed. I don't think we're using `cst` anywhere in this test.", + "reference": "Does anyone still use the cst out of this method? If not consider deleting" + }, + { + "prediction": "I think this should be `get \"/videos/vim-for-rails-developers\" => redirect(\"https://www.youtube.com/watch?v=9J2OjH8Ao_A\", permanent: true)`", + "reference": "Line is too long. [97/80]" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to be the only way to test that the `ReadTimeoutError` is caught.", + "reference": "This seems unused." + }, + { + "prediction": "I don't think we need to panic here. We can just return nil and let the caller handle it.", + "reference": "@luguanglong , Thanks for the fix, can you re-phrase it to sound better something like \"This OS version is currently un-supported by keadm\"" + }, + { + "prediction": "I think this should be `if hasattr(mol, '_fpInfo'): del mol._fpInfo`", + "reference": "should probably be called `_DeleteFpInfoAttr` because it removes it. Cleaning gives the impression it is still there. I would also move this to the end of the function `GetAtomicWeightsForFingerprint`." + }, + { + "prediction": "This should be `VUID-vkCmdBindDescriptorSets-pipelineBindPoint-00362`", + "reference": "nit, can we use `VK_PIPELINE_BIND_POINT_RAY_TRACING_KHR` here (granted it isn't else where, maybe worth fixing here or in separate PR)" + }, + { + "prediction": "Style/SymbolArray: Use %i or %I for an array of symbols.", + "reference": "This will need to be updated in the upcase-exercises repo as well." + }, + { + "prediction": "Metrics/LineLength: Line is too long. [81/80]", + "reference": "Think it's worth extracting this to `Exercise#complete?`?" + }, + { + "prediction": "Why is this removed?", + "reference": "This is still a potentially useful public method - should we remove such methods?" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think it would be better to keep the `releaseLevel()` method and have it return `ReleaseLevel.UNSET_RELEASE_LEVEL` by default. This way, if someone forgets to override `releaseLevel()` in a subclass, they'll get a compile-time error instead of a runtime error.", + "reference": "I don't understand this change, what is happening here?" + }, + { + "prediction": "I don't think this is correct. If the version is 12.0, it will be 12, but if it's 12.1, it will be 121. You need to use `int(self.obj.excelCellObject.Application.Version.split('.')[0])` instead.", + "reference": "I think its worth stating this is `versionMajor`" + }, + { + "prediction": "I think this should be `GetConsensusProtocols` to be consistent with `SetConsensusProtocols`", + "reference": "rebuild: say loads and merges" + }, + { + "prediction": "I think we can remove this import as well.", + "reference": "Why was this removed here (also in the other file)? Shouldn't we import them so that the reference in the docs below is interpreted correctly?" + }, + { + "prediction": "I don't think this change is related to this PR.", + "reference": "I'd prefer to have a blank line between the class declaration and its first member. Is it possible?" + }, + { + "prediction": "I'm not sure if this is the right thing to do. I think we should be using the `HELLO` constant from `mock.js` instead of the `HELLO` constant from `mock_36.js`. The `HELLO` constant from `mock_36.js` is not the same as the `HELLO` constant from `mock.js`. The `HELLO` constant from `mock_36.js` is the same as the `HELLO` constant from `mock_40.js`. The `HELLO` constant from `mock.js` is the same as the `HELLO` constant from `mock_32.js`. The `HELLO` constant from `mock_32.js` is the same as the `HELLO` constant from `mock_34.js`. The `HELLO` constant from `mock_34.js` is the same as the `HELLO` constant from `mock_36.js`. The `HELLO` constant from `mock_36.js` is the same as the `HELLO` constant from `mock_38.js`. The `HELLO` constant from `mock_38.js` is the same as the `HELLO`", + "reference": "Is it really LEGACY_HELLO if we are using the most up to date HELLO? Perhaps `MONGOS_HELLO` would work here?" + }, + { + "prediction": "I'm not sure this is the right thing to do. If we fail to suspend a thread, we should not try to detach it, as it may be in an inconsistent state.", + "reference": "I am afraid this is going to cause problems on Windows where it is not uncommon to have injected threads (CTRL_SHUTDOWN, CTRL_LOGOFF, etc.) we have no privileges to suspend -- and thus retrying will just fail again, and with the new \"synchall failure is fatal and should kill the process\" approach it turns what used to work for us on Windows into process death." + }, + { + "prediction": "I think this should be `--mac_installer_signing_identifier `, not `--mac_installer_signing_id `.", + "reference": "think it should only be in create_dist" + }, + { + "prediction": "I think this should be `if int(cport.HostPort) > 0 {`", + "reference": "Do you plan to support Pod spec change? Like hostPort is added/removed later after Pod creation?" + }, + { + "prediction": "`dokan.ExistingDir` is not a valid return value for `dokan.File`.", + "reference": "Is this behavior correct? It used to return `true`, which should map to `dokan.ExistingDir`. Was that previously a bug?" + }, + { + "prediction": "I think this should be `osrm-extract` instead of `osrm-datastore`.", + "reference": "What about just printing an empty list in this case? That would make the output more predictable." + }, + { + "prediction": "I think we can remove this line as well.", + "reference": "I looked and couldn't find any usage of `container` in any of the editor component files (js or hbs), so I assume this was used once and didn't get removed?" + }, + { + "prediction": "I'm not sure this is the best way to do this. I think it would be better to use the `get_search_form` filter to modify the `$form` variable, rather than setting it to an empty string and then re-locating the template.", + "reference": "I just updated a number of sites using older versions of Roots onto WP 3.6 and this little function change was required. Multiple search bars were displaying when I used the search widget in a widgetized sidebar. Updated the roots_get_search_form as seen in this change resolved it for me!" + }, + { + "prediction": "FreeProduct is not used in this file.", + "reference": "Fixes test failed in some cases" + }, + { + "prediction": "I think we can remove this one as well.", + "reference": "what's the prod url for this? just curious. @amirsaber" + }, + { + "prediction": "I think this should be `azkaban.job.ignore.jvm.args`", + "reference": "Can you please change this to azkaban.jobs.java.opts?" + }, + { + "prediction": "I don't think we need to add a space before the `sprintf` here.", + "reference": "Here is another concatenation which should be updated. Even though `Source:` and the link are essentially separate, it isn't RTL friendly. This would be another good use for `createInterpolateElement` I think so that we wouldn't need to include all of the classnames in the translation string (or extract them to a placeholder). That would allow us to use the `Link` component as well, rather than using its resulting HTML as a string which will be a pain to maintain if we were to make changes to the base `Link` component." + }, + { + "prediction": "I think we can remove the `default(CancellationToken)` here.", + "reference": "I would add an overload `GetCancelledZeroTask()` which calls `GetCancelledZeroTask(CancellationToken.None)`. This is cleaner than requiring the caller to pass `default(CancellationToken)` or `CancellationToken.None`." + }, + { + "prediction": "I think this should be `if (image.image_state && image.image_state->image() != VK_NULL_HANDLE) {`", + "reference": "Would it be equivalent to check if `chain != nullptr` below? Not suggesting a change, just curious." + }, + { + "prediction": "This should be `this->wallets.queue_work_regeneration (std::chrono::steady_clock::now () + std::chrono::seconds (1), block);`", + "reference": "Should probably do `auto this_l (shared_from_this ());` and pass/use that instead of `this`. Same a few other places. IOW, replace both `shared_from_this()` and `this` with `this_l`" + }, + { + "prediction": "I'm not sure if this is the right way to escape the single quote, but it's the only way I could get the test to pass.", + "reference": "And here. Please, use `'` for apostrophes in changed strings in this file." + }, + { + "prediction": "Why do we need to change this?", + "reference": "assignments should only be cuddled with other assignments (from `wsl`)" + }, + { + "prediction": "I think this should be `DefaultNewBlockDataVersion(c Config, holes bool) DataVer` instead of `DefaultNewBlockDataVersion(c Config, holes bool) DataVer`.", + "reference": "Please move this to `block_types.go`." + }, + { + "prediction": "I don't think we need to remove these attributes.", + "reference": "So this is not needed anymore for all attributes?" + }, + { + "prediction": "I don't think we need to include the exception in the message. It's already included in the stack trace.", + "reference": "Happy to get suggestion for better messaging here. Here's what I intended to convey: Something is wrong - the Exception is a hint to what might be the cause The impact of that - tracing wont work." + }, + { + "prediction": "I think this should be `update_listener=update_listener` instead of `update_listener=update_listener`", + "reference": "I think we can remove this function, right? (duplicate with `ses_starter.py`)" + }, + { + "prediction": "`alias` is not a pandas method, it's a spark method. I don't think we want to add it to `PandasLikeSeries`.", + "reference": "With this fix, I am not even sure we need to overwrite this function." + }, + { + "prediction": "This should be `os.getenv('QUILT_USE_TQDM', 'false').lower() == 'true'` so that it defaults to `False` if the environment variable isn't set.", + "reference": "Why not just import this from `data_transfer`? As a rule copying the same code twice is not a good idea. Also: please run `pylint` on all files in this PR." + }, + { + "prediction": "_server_port=>8140}\n+ expect(parser.parse_args(args)).to be === {:hosts_file=>hosts_path, :options_file=>nil, :type=>\"git\", :provision=>true, :preserve_hosts=>false, :root_keys=>false, :quiet=>false, :xml=>false, :color=>true, :debug=>true, :dry_run=>false, :fail_mode=>nil, :timesync=>false, :repo_proxy=>false, :add_el_extras=>false, :consoleport=>443, :pe_dir=>\"/opt/enterprise/dists\", :pe_version_file=>\"LATEST\", :pe_version_file_win=>\"LATEST-win\", :dot_fog=>\"#{home}/.fog\", :ec2_yaml=>\"config/image_templates/ec2.yaml\", :ssh=>{:config=>false, :paranoid=>false, :timeout=>300, :auth_methods=>[\"publickey\"], :port=>22, :forward_agent=>true, :keys=>[\"#{home}/.ssh/id_rsa\"], :user_known_hosts_file=>\"#{home}/.ssh/known_hosts\"}, :install=>[\"git://github.com/puppetlabs/puppet.git#1.0\",", + "reference": "You've got an absolute path here referencing your home dir :-)." + }, + { + "prediction": "I don't think this is correct. The `prefix` property is not derived from the `postfix` property, it's the other way around.", + "reference": "Maybe I should do some sorting so that these properties don't keep moving around..." + }, + { + "prediction": "Is this test still needed now that we don't have `checkMountDestination`?", + "reference": "Can we keep this test anyway, as it's part of the spec?" + }, + { + "prediction": "Please remove this empty line.", + "reference": "Can be removed" + }, + { + "prediction": "Why are you using `Config` and `Request` here?", + "reference": "It's a minor quibble I know, but I like having the imports ordered by lengt" + }, + { + "prediction": "I don't think this is the right place to set the charset. The charset should be set in the produce processor.", + "reference": "It's better to get the charset from context or other setting to let the user override it." + }, + { + "prediction": "Please revert this change.", + "reference": "this filename as well needs change" + }, + { + "prediction": "I think this should be `AccessKeyIDSecretRef` and `SecretAccessKeySecretRef`", + "reference": "I think we want to remove `omitempty` here" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think we should do this in `startContainer` and pass the `SignalHandler` to `createProcess` so that it can be used in `waitProcess` as well.", + "reference": "You cannot move this here because it breaks detach. Just call `tty.Close()` before returning the error from start" + }, + { + "prediction": "I'm not sure about this change. I think we should keep the `implicit: ['table']` here.", + "reference": "I updated only the implicit roles who needed a update for this new rule to validate." + }, + { + "prediction": "This file is generated by protoc. Please don't change it.", + "reference": "> // Code generated by protoc-gen-go. DO NOT EDIT." + }, + { + "prediction": "I think this should be `osconfig_not_supported: \"true\"`", + "reference": "minor: skipOSConfigMetadata, otherwise, the name sounds like a boolean" + }, + { + "prediction": "I don't think this is correct. If `type` is not null, then it should be validated. If it is null, then it should be set to the value of `SyndTypeUtils.getMimeTypeFromUrl(url)`.", + "reference": "~~I think lines 65-67 should be moved into this else clause after `type = ...` Else, it is a bit confusing why we check the enclose type validity a second time~~ Nevermind, will do some refactoring, myself. But thanks for \"fixing\" this!" + }, + { + "prediction": "I think we should return an error if the response status code is not 200.", + "reference": "`sessions := endpoints.SessionsDTO{}` and using only `sessions` should be simpler." + }, + { + "prediction": "I'm not sure this is the right thing to do. If the thread is exiting, we don't want to be using the app's sigstack. We should be using the app's sigstack only when the thread is not exiting. I'm not sure what the right thing to do is, but I don't think we should be using the app's sigstack when the thread is exiting.", + "reference": "These need to be in the other order to avoid crashing when dcontext == GLOBAL_DCONTEXT (==-1)" + }, + { + "prediction": "Why is this change necessary? I don't see it in the PR description.", + "reference": "Why not change the other samples?" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "Indentation is mixed up here due to spaces/tabs, I'm guessing." + }, + { + "prediction": "I think this should be `bytes_read == 0` instead of `bytes_read <= 0`", + "reference": "Should we provide a little more context in the error message? Maybe throw in something about what operation was being performed?" + }, + { + "prediction": "I think this should be `if (array_key_exists('settings', $configuration) && is_array($configuration['settings'])) {`", + "reference": "Project standard is spaces, not tabs. Please fix and then we can merge this." + }, + { + "prediction": "This should be moved to the top of the file.", + "reference": "@hgtw is there anything we're worried about with regards to using this cache? Do we want to do staged testing around expeditions before we merge? Curious your thoughts here" + }, + { + "prediction": "I think we should keep the `partFilter` parameter here. It is used in the `PartialManifest` class.", + "reference": "The purpose of this was to allow pushing filters into the manifest files if we ever use a format other than Parquet. I think overall this is a good change because we can add it back later. Just wanted to note why the unused argument was there." + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.", + "reference": "I think BSON::Decimal128 should always be serialized as Decimal128 regardless of config option." + }, + { + "prediction": "I don't think we need to require this here.", + "reference": "We should probably just move the `require 'bolt/plan_creator'` in `Bolt::CLI` to `Bolt::Application` so it will already be loaded." + }, + { + "prediction": "I'm not sure if this is the right thing to do. I think we want to run at least 1000 iterations.", + "reference": ">20 [](start = 45, length = 2) Can we override this at runtime? Maybe it should be a command line option with default." + }, + { + "prediction": "nit: remove empty line", + "reference": "can just remove it ?" + }, + { + "prediction": "I think this should be `FinishMigrateRepository` instead of `MigrateRepository`.", + "reference": "Better call it `CleanUpMirrorInfo`?" + }, + { + "prediction": "I think this should be `node.StorageProtocol.StorageProvider.Start(ctx)`", + "reference": "@shannonwells is there still something missing here?" + }, + { + "prediction": "Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.", + "reference": "This could be more indicative of what it is... e.g... `stresstest_time_limit`" + }, + { + "prediction": "Why is this being removed?", + "reference": "Shouldn't we do a `reader_payload_pool_.reset()` here?" + }, + { + "prediction": "I think this should be `BeaconEntries` instead of `DrandEntries`", + "reference": "I'd prefer the nomenclature less tightly coupled to DRAND throughout. I played with renaming the `drand` package to `beacon` but it was too much noise in this change." + }, + { + "prediction": "I think this should be `self._current_key` instead of `getattr(self, '_current_key', None)`", + "reference": "I think I would prefer you declare `self._current_key=None` in the constructor and just return `self._current_key`. That way you can prevent anyone from overwriting `current_key` without needing to use `getattr` here." + }, + { + "prediction": "I'm not sure I like the name `mode` here. It's not really a mode, it's more of a format specifier. How about `format` or `type`?", + "reference": "I guess I like the name `mode` okay. I can't think of anything better." + }, + { + "prediction": "I think this should be `if timeout == 0 {`", + "reference": "I would create a new method (NewStepWithDefaultTimeout?) for this purpose because timeout<=0 looks like a hidden logic" + }, + { + "prediction": "The max length of events list => The maximum length of the events list", + "reference": "Are these limit changes related?" + }, + { + "prediction": "This import is not used.", + "reference": "Don't you mean `import scapy.consts`?" + }, + { + "prediction": "I think this should be `model.StageStatus_STAGE_FAILURE`", + "reference": "`ctx` is unused in rollbackPrimary" + }, + { + "prediction": "I think we should keep this as `-1234` to avoid confusion with `EmptyEventTaskID` which is `0`.", + "reference": "This is not what title says." + }, + { + "prediction": "I'm not sure about the name of this interface. Maybe `RuleViolationFixer` or `RuleViolationFixStrategy` would be better?", + "reference": "a fix applies several fixes? maybe this should simply be `applyToNode`" + }, + { + "prediction": "I think this should be `fakeListOk` and `fakeListErr` instead of `fakeListfn` and `fakeListerr`", + "reference": "U1000: func `fakeGetOk` is unused (from `unused`)" + }, + { + "prediction": "I think we can remove this line.", + "reference": "Because there is a \"k8s.io/client-go/tools/cache\" below, we can sort out all the \"imports\" here." + }, + { + "prediction": "I think we can remove this line.", + "reference": "Nit should be using `goimports` to format the import statements with standard libary imports first, new line, followed by non-standard library imports." + }, + { + "prediction": "I think this should be `if len(o.PipelineSecret) > 0 {`", + "reference": "Do we not have tests for pipeline delete" + }, + { + "prediction": "I think this should be `call_check` instead of `self.call_check`.", + "reference": "Good that you mention this constraint in the docstring :)" + }, + { + "prediction": "Please remove the empty line.", + "reference": "remove this blank?" + }, + { + "prediction": "Should this be set to 0 instead of -1?", + "reference": "Partitions is misspelled 8 times in this commit, might make sense to fix the spelling for all of those." + }, + { + "prediction": "I think this should be `from qutebrowser.browser.qutescheme import QuteSchemeError`", + "reference": "Please remove this blank line - those are only used to group Python/third-party/qutebrowser imports." + }, + { + "prediction": "I think this should be `var insecure bool = false` so that the default value is `false`.", + "reference": "`insecure` is a global variable (from `gochecknoglobals`)" + }, + { + "prediction": "I think we should return `403 Forbidden` instead of `405 Method Not Allowed` here.", + "reference": "Same as above (HTTP in upper-case)" + }, + { + "prediction": "I think this should be `http://www.youtube.com/watch?v=123456` instead of `http://youtube.com/watch?v=123456`", + "reference": "This is getting repetitive maybe you could introduce an abstract test case with a `getExpectedUrl($providerReference)` method ?" + }, + { + "prediction": "I think this should be `reflect.MakeFunc`", + "reference": "I do not think returning `Value{}` is correct here. For example, `reflect.MakeFunc(...).Kind()` would return `reflect.Invalid` instead of `reflect.Func`. Therefore, I think this should panic instead." + }, + { + "prediction": "`window[nameLower] !== undefined`", + "reference": "Does this work for Custom Elements? iirc we're lacking test cases for them. /cc @andrewiggins @developit" + }, + { + "prediction": "I'm not sure this is correct. I think we need to add the external node CIDRs to the ipset here as well.", + "reference": "Same change just above?" + }, + { + "prediction": "I don't think we need to disable the rule here.", + "reference": "I suppose `apploader.js` isn't used by WebWorkers. So `self` will always be `window` here." + }, + { + "prediction": "I think we can remove this line now that we're using `select_hosts(roles: ['ssh'], platform: ['!debian-8'])`", + "reference": "Since this var is no longer defined we should remove the `if skip_targets.any?` bit below." + }, + { + "prediction": "I think this should be `if ARN_TO_LAMBDA.get(arn).qualifier_exists(qualifier):`", + "reference": "I think we should `return arn` as a fallback at the end of this function (otherwise the `['Resource']` entry below could become `None`)." + }, + { + "prediction": "I think this should be `if np.socketProtect == nil || np.pinger == nil {`", + "reference": "Why session is started at all, if you need to shut it down e.g. DI should launch noopSession" + }, + { + "prediction": "`DeleteWorkspaceFile` is a bit of a misnomer, since we're not deleting the file, we're deleting the contents of the file. Perhaps `ClearWorkspaceFile` or `ResetWorkspaceFile` would be better?", + "reference": "nit: can we rename the interface to `wsFileDeleter`" + }, + { + "prediction": "I think we should rename this to `GroupMembers` to be consistent with the rest of the codebase.", + "reference": "Why target cannot be external endpoints?" + }, + { + "prediction": "I think this should be `auto_` instead of `.auto_` to be consistent with the rest of the codebase.", + "reference": "We use a suffix \".AUTOCREATED\" for configsets, maybe we can use the same here?" + }, + { + "prediction": "I think we should keep the `OpenTelemetrySdk.Default.EnableOpenTelemetry` as it is more explicit.", + "reference": "This one won't be disposed. Should be (something like) `using var openTelemetry = OpenTelemetrySdk.EnableOpenTelemetry(` no?" + }, + { + "prediction": "This import is not needed anymore.", + "reference": "Why this is in the diff?" + }, + { + "prediction": "I think this should be `CloudBackupGroupCreate` and `CloudBackupGroupRestore` to be consistent with `CloudBackupCreate` and `CloudBackupRestore`.", + "reference": "How is status determined? When the user calls CloudBackupCreate( src_volume_id ) they can then call CloudBackupStatus( src_volume_id ) Is there something similar for this new API?" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but it seems to fix the issue for me.", + "reference": "We could pass `excessDomChildren` to `options._catchError` and only do this if an error-boundary catches the error. Not entirely sure if that's better." + }, + { + "prediction": "`array_merge(...array_values($this->getFilters()));` should be `call_user_func_array('array_merge', array_values($this->getFilters()));`", + "reference": "In php8 named parameters were introduced and now it is required to match called method parameter name when setting parameters by array destructing or call_user_func_array() etc." + }, + { + "prediction": "I'm not sure this is the right thing to do. If we don't have a valid B3 header, I think we should just return the original context.", + "reference": "If instead we had `B3.extractSingleHeader` and `B3.extract` return a bool value as a second return value, we could avoid the byte array comparison in `TraceID.IsValid`. Did you consider that alternative?" + }, + { + "prediction": "\"Erstellen und weitere hinzuf\u00fcgen\" sounds a bit weird to me. Maybe \"Erstellen und mehr hinzuf\u00fcgen\" or \"Erstellen und weitere Dateien hinzuf\u00fcgen\" would be better.", + "reference": "I think this is more of a semantic difference than a typo - `weiter hinzufgen` is like `continue adding` whereas `weitere hinzufgen` is like `add more`. I think it makes sense to change it though" + }, + { + "prediction": "I think this test should be moved to `test_records_view.py`", + "reference": "nit: 200 is superfluous" + }, + { + "prediction": "`row_timestamp` is not a reserved keyword, but `timestamp` is.", + "reference": "This is testing `unreserved keyword`" + }, + { + "prediction": "Please remove the empty line here.", + "reference": "paramsNatOrigin doesn't include sUVtoST. I would just remove that definition for now" + }, + { + "prediction": "I think this should be `q := newBlockRetrievalQueue(0, 0, newTestBlockRetrievalConfig(t, nil, nil))` instead of `q := initBlockRetrievalQueueTest(t)`", + "reference": "It feels like the test should be waiting for the prefetcher to shut down, but I don't have a great reason why other than that it might be confusing for debugging if there are still goroutines from old prefetchers lying. But I guess since `TogglePrefetcher(false)` doesn't actually set the prefetcher to nil, the queue shutdown method will still end up waiting for the shutdown to finish. If that sounds right, nevermind me." + }, + { + "prediction": "I think this should be `AWS Identity and Access Management (IAM)` instead of `AWS Identity and Access Management (AWS IAM)`.", + "reference": "AWS Identity and Access Management (IAM)" + }, + { + "prediction": "I think this should be `RESOURCE_NAME = 'cloudsql_instances'`", + "reference": "As a long term thing, would it make sense to move the resource names as keys under the requirements map?" + }, + { + "prediction": "`getAttribute` returns `null` if the attribute doesn't exist, so this should be `if (cell.getAttribute('headers') !== null) {`", + "reference": "That doesn't fix the whole problem. The issue lays in this line right here, not the one above. There are two problems with this line: 1. It finds things that aren't cells in the table 2. if it doesn't find anything, it shouldn't return empty here, but continue down to look for row/ column headers." + }, + { + "prediction": "I don't think this is correct. The resolved artifacts should be the same for all subprojects, so it should be enough to get the resolved artifacts from the root project.", + "reference": "I am pretty sure that this is infinite recursion as getAllProjects returns the project itself." + }, + { + "prediction": "I think this should be `dataLists` instead of `data-lists`.", + "reference": "Something I didn't catch before I merged this PR, is the hyphenated constant a problem? E.g. should \"data-lists\" be \"data_lists\"? @paulkaplan" + }, + { + "prediction": "I don't think this is the right way to do it. If you want to disable `sniff`, you should do it in `scapy/arch/windows/__init__.py` and not in `scapy/arch/windows/disable_sendrecv.py`.", + "reference": "Can you write the test as `if not (conf.use_winpcapy or conf.use_pcap or conf.use_dnet):`" + }, + { + "prediction": "I think we can remove this now that we're not using `@repository` as a decorator.", + "reference": "we have to include foreign assets on the repository directly because they don't belong to a job? This seems very awkward... Is this a step towards the job-less assets on the repository? Did you consider having `build_asset_job` take in a set of foreign assets instead? I suppose we would then need to subclass it to be a more special `AssetJobDefinition` that can keep track of them." + }, + { + "prediction": "I don't think this change is correct. `strncpy` will always null-terminate the destination string, even if the source string is longer than the destination string. `strcpy` will not null-terminate the destination string if the source string is longer than the destination string.", + "reference": "`-Wstringop-truncation` is a new kind of error detector introduced in GCC 8. As for this patch, these are two false-positives though." + }, + { + "prediction": "I think this should be `only one credential type may be specified per profile: source profile, credential source, credential process, web identity token, or sso`", + "reference": "Can we port this error msg to v2 too? This one is better, as it explicitly states what sources are allowed." + }, + { + "prediction": "I think we can remove this line.", + "reference": "The convention so far has been to require directly from the defining file (in this case `../../read_preference') . I think the concern has been mostly about the potential for circular dependency cycles" + }, + { + "prediction": "`color_type` -> `color_type='color'`", + "reference": "I suggest expanding dims here to simplify the formatting." + }, + { + "prediction": "I'm not sure this is the right way to do it, but it seems to work.", + "reference": "Why do you need to specify the kinto prefix here?" + }, + { + "prediction": "`!r` is the default, so you don't need to specify it.", + "reference": "The `!r` is unnecessary." + }, + { + "prediction": "I think this should be `if accountKey != \"\" || sasToken != \"\" || isMSIEnvironment {`", + "reference": "I didn't see existing tests for this `OpenBucketURL`. Not sure if it's easy to do without mocking these `opener` calls." + }, + { + "prediction": "I think this should be `public bool IsPreparerNeeded { get; set; }`", + "reference": "Should we default to `true` ?" + }, + { + "prediction": "I think we don't need to import `fsm` here.", + "reference": "File is not `goimports`-ed (from `goimports`)" + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to work.", + "reference": "Shouldn't these options also include `@babel/preset-env`? Also I see you set `babelrc` to `false`, could we rely on our existing `.babelrc` file? Feels like some duplicate configuration otherwise." + }, + { + "prediction": "I'm not sure this is the right thing to do. If the reason is an error, it will be logged as an error. If it's not an error, it will be logged as an info. I think we should always log as an error.", + "reference": "Nit: We can use `%s` since `disconnectReason` is a string." + }, + { + "prediction": "`boosting_type` should be `boosting_type='rf'` or `boosting_type='rgf'`", + "reference": "I think it's better to create a new example" + }, + { + "prediction": "I think this should be `kDepthStencilAttachmentRasterOrder` as well.", + "reference": "The stages are correct, but the more forgiving `kAttachmentRasterOrder` should be used, based on a review of the spec. That should give the same effect of suppressing the false positive conflict between the DEPTH R/W and resolve. > End-of-subpass multisample resolves are treated as color attachment writes for the purposes of synchronization. This applies to resolve operations for both color and depth/stencil attachments. That is, they are considered to execute in the VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT pipeline stage and their writes are synchronized with VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT. Synchronization between rendering within a subpass and any resolve operations at the end of the subpass occurs automatically, without need for explicit dependencies or pipeline barriers." + }, + { + "prediction": "I think this should be `'\u2013SO3H'` instead of `'--SO3H'`", + "reference": "To be consistent, I think it should actually just be a single `-`" + }, + { + "prediction": "I don't think we need to use `current_app` here. We can just use `app.config['REDIS_HOST']` and `app.config['REDIS_PORT']`.", + "reference": "this seems extraneous." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we want to test the long domain feature set with the SAN feature set, but I don't think we want to test the SAN feature set with the long domain feature set. I think we want to test the long domain feature set with the SAN feature set, but I don't think we want to test the SAN feature set with the long domain feature set. I think we want to test the long domain feature set with the SAN feature set, but I don't think we want to test the SAN feature set with the long domain feature set. I think we want to test the long domain feature set with the SAN feature set, but I don't think we want to test the SAN feature set with the long domain feature set. I think we want to test the long domain feature set with the SAN feature set, but I don't think we want to test the SAN feature set with the long domain feature set. I think we want to test the long domain feature set with the SAN feature set, but I don't think we want to test the SAN feature set with the long domain feature set. I think we want to test the long domain feature set with the SAN feature set, but I don't think", + "reference": "Ah, I see here that 'LongDomain' is defined as something that contains a subdomain segment that is `maxLengthOfDomainSegment` long (which I think is 63 characters) - I don't think any public ACME servers/Let's Encrypt's staging environment has a restriction on this? if it does, and the 'pebble' based ACME server does not, then Pebble needs modifying to also fail in these cases as it aims to replicate the ACME RFC as closely as possible" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to work for me.", + "reference": "I think you need `-y` here to prevent a user confirmation prompt" + }, + { + "prediction": "I think this should be `dynamorio_avx512_code_in_use` or `dynamorio_avx512_code_in_use` or `dynamo_avx512_code_in_use` or `dynamo_avx512_code_in_use` or `dynamo_avx512_code_in_use` or `dynamo_avx512_code_in_use` or `dynamo_avx512_code_in_use` or `dynamo_avx512_code_in_use` or `dynamo_avx512_code_in_use` or `dynamo_avx512_code_in_use` or `dynamo_avx512_code_in_use` or `dynamo_avx512_code_in_use` or `dynamo_avx512_code_in_use` or `dynamo_avx512_code_in_use` or `dynamo_avx512_code_in_use` or `dynamo_avx512_code_in_use` or `dynamo_avx512_code_in_use` or `dynamo_avx512_code_in_use` or `dynamo_avx512_code_in_use` or `d", + "reference": "Repeating: I don't think this should be a core-wide global var. This should be isolated to arch/x86 or at least arch/, maybe inside getter/setters as mentioned above." + }, + { + "prediction": "I think it would be better to use `https://repo1.maven.org/maven2/kg/apc/jmeter-plugins-manager/0.8/jmeter-plugins-manager-0.8.jar` instead of `http://search.maven.org/remotecontent?filepath=kg/apc/jmeter-plugins-manager/0.8/jmeter-plugins-manager-0.8.jar`", + "reference": "right URL is like in cmdrunner, using search.maven .org" + }, + { + "prediction": "I think we should keep this as `Uri` and add a validation that it starts with `http` or `https`.", + "reference": "The link to valid syntax is not really applicable for NET2_1, right?" + }, + { + "prediction": "I don't think we need this section.", + "reference": "Shouldn't it be more specific, like \"gcppubsub supports all UTF-8 strings\"?" + }, + { + "prediction": "Can we rename this test to `testFullReplicationFromSecondary`?", + "reference": "Everything in this class is SolrCloud-related, not legacy replication" + }, + { + "prediction": "I'm not sure if this is correct. I think we need to do something like: newval &= ~(EFLAGS_ARITH); newval |= (val & 0xff00) >> 8; if (TEST(1, val)) /* seto */ newval |= EFLAGS_OF;", + "reference": "Could just assign directly and eliminate the `newval` var." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it makes sense to have the same title format for issues and PRs.", + "reference": "... with the name of the affected package, or \"all\", followed by a colon,..." + }, + { + "prediction": "I think we can remove this line.", + "reference": "We'll want to remove this one if we make the assembly version constant." + }, + { + "prediction": "I think we should rename this to `setup_single_page_and_post_style` to make it clear that it applies to both pages and posts.", + "reference": "Can we have a single function here that uses the same subscribers and just changes meta based on context?" + }, + { + "prediction": "I think this should be \"HIP will load the kernels and setup the function symbol map when HIP_STARTUP_LOADER is enabled\"", + "reference": "where would ` static startup_kernel_loader skl;` be instantiated? if it's not instantiated anywhere should this be removed?" + }, + { + "prediction": "I'm not sure if this is the best way to do this. I think it would be better to have a single `getDroppedFiles` function that checks for the existence of `webkitGetAsEntry` and `getFilesAndDirectories` and then calls the appropriate function. That way we don't need to have a separate `webkitGetAsEntryApi`, `getFilesAndDirectoriesApi`, and `fallbackApi` function.", + "reference": "I think we should move those util functions that work with drag-drop to @uppy/utils, so they can be shared (maybe later) with drag-drop plugin? Otherwise it will continue to depend on drag-drop module." + }, + { + "prediction": "Why is this removed?", + "reference": "Migrate the spec.Labels to locator.Labels ?" + }, + { + "prediction": "I think this should be `if gotErr != tc.wantErr {`", + "reference": "The test case already existed but it never tested properly because of the conditional in the test." + }, + { + "prediction": "nit: remove empty line", + "reference": "I'm okay with this, but I don't see a lot of benefit to removing unnecessary parens. If extra parens make something more readable (like this) or clarify order of operations even when matching the default, I would say we should keep them." + }, + { + "prediction": "I don't think we need to make this volatile anymore. It's only used in `getDynamicFields()`, which is synchronized.", + "reference": "@sarowe why was this volatile? It's fishy to see this as the only volatile field." + }, + { + "prediction": "`InstanceRegistryFailedEvent` -> `InstanceRegisterFailedEvent`", + "reference": "template is not correct?" + }, + { + "prediction": "I think we can merge these two registries into one.", + "reference": "Rename the registies to `BBOX_ASSIGNERS` and `BBOX_SAMPLERS` to avoid ambiguity. There is also a registry for dataset sampler." + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "This is no longer stubbed on every test. Perhaps it should be, and should be unstubbed in the single case that it matters." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "This seems much simpler! I'm not sure I follow what you mean by the threading part... Also tests are not liking this constant. Might need a require or to fully qualify this." + }, + { + "prediction": "I think we can just remove this case. It's not used.", + "reference": "Convention is \"FIXME: i#2144\" or \"XXX: i#2144\"" + }, + { + "prediction": "I think this should be `IHttpMethodProvider` or `IHttpMethodSource` or something like that. `IHasHttpMethod` sounds like it's a property, not an interface.", + "reference": "This should probably be a property instead of a method." + }, + { + "prediction": "I think we need to set the state to `RECONCILED` only when the `CAST.version` is different from the `desired` version. If the `CAST.version` is same as the `desired` version, then we should set the state to `RECONCILING` and not `RECONCILED`.", + "reference": "do we need to consider setting the `state` as well? If so, lot of changes might be required, like, setting to 'Reconciling' in upgrade code, setting to 'error' or 'reconciled' in volumeReconciler functions." + }, + { + "prediction": "Align the elements of a hash literal if they span more than one line.", + "reference": "Line is too long. [82/80]" + }, + { + "prediction": "Please revert this file.", + "reference": "Add blank line below license header." + }, + { + "prediction": "I think we can remove the `if (ops.current() != null)` check and just use `ops.current().buildReplacement(schema, spec, baseLocation, tableProperties);`", + "reference": "I'm not clear on whether this really should be the right behavior. Basically we're saying that a replace table will keep the existing location (as opposed to using defaults). I suspect we don't have create or replace with location semantics, but this is making some assumptions that a replacement is somehow the same as the old. If we were to go with id based pathing convention, this wouldn't work. I don't think this is an issue at this point, but it might make sense to push this down to the location provider." + }, + { + "prediction": "nit: remove empty line", + "reference": "Just run a global replacement for all `executionproto`." + }, + { + "prediction": "I think we should add `options` to the `__init__` docstring as well.", + "reference": "@AutomatedTester @davehunt thoughts on a new keyword argument?" + }, + { + "prediction": "I think this should be ENOSYS.", + "reference": "Should line 47 be OPAE_ERR?" + }, + { + "prediction": "I think this should be `var zeroTime = time.Time{}`", + "reference": "Not necessary, just write `time.Time{}`" + }, + { + "prediction": "I think it would be better to have this as a percentage of the height of the tabbar, rather than a fixed number of pixels. That way, if the user changes the height of the tabbar, the size of the favicons will automatically adjust.", + "reference": "As these two strings simply get concatenated for the docs, there's a space missing after the dot here." + }, + { + "prediction": "I think this should be moved to the `BeginMethodHandler.Invoke(instance)` method.", + "reference": "What about integrations where we don't plug ourselved on OnMethodBegin?" + }, + { + "prediction": "`visibility_of_any_elements_located` -> `visibility_of_at_least_one_element_located`", + "reference": "shouldn't **call** return a boolean?" + }, + { + "prediction": "I think this should be `com.google.api.tools.framework.model.Interface`", + "reference": "ViewModel classes should not expose any classes from framework.model." + }, + { + "prediction": "I think we should keep this test, but change the expected output to `{'string_field': None}`", + "reference": "how would you feel about keeping these tests to be more explicit and having them `assert not _validate...`? or is your view that that is too duplicative of the tests in `test_evaluator.py`?" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Why do we use the `winrm_nodes` variable here and not the string `\"winrm_nodes\"` as we were using before?" + }, + { + "prediction": "Why change the copyright year?", + "reference": "why update Copyright ?" + }, + { + "prediction": "I think this should be `if (naTable->hasLobColumn() && isSampleScan() && !naTable->isHbaseTable())`", + "reference": "Does this mean we cannot update statistics with sampling on a table with LOB columns?" + }, + { + "prediction": "I think this should be called `ClearCacheOnInitialize` or something like that.", + "reference": "Look good, but I think a `[flags]` enum would be more future proof? Although i'm not sure if a flags-enum is working from the XML config. What do you think?" + }, + { + "prediction": "I think this should be `row.treeNode.state === 'expanded'` and `row.treeNode.state === 'collapsed'` instead of `row.treeNode.state === 'expanded'` and `row.treeNode.state === 'collapsed'`", + "reference": "Since I believe state will never be anything other than 'expanded' or collapse, you can rewrite this as follows: `return row.treeNode.state === 'expanded' ? 'ui-grid-icon-minus-squared' : 'ui-grid-icon-plus-squared'; `" + }, + { + "prediction": "I don't think we need to remove this.", + "reference": "the latter part can go but isn't the first part of this still sound -- that we assume \"id\"?" + }, + { + "prediction": "I don't think this is correct. You need to escape both single and double quotes.", + "reference": "Why is the escaping of @ and $ removed?" + }, + { + "prediction": "I think we can remove this interface and just use `GetRawUrl` directly.", + "reference": "Nit: `Http` is redundant in this interface's name." + }, + { + "prediction": "I think this should be done in a separate PR, as it's not directly related to this one.", + "reference": "what if I set SynchronizableEntitiesPrefix to \"a/b/c/d\" in config?" + }, + { + "prediction": "I think this should be `!isDir`", + "reference": "nit: This error message doesn't mention that the path is a directory, maybe \"Dockerfile path is a directory:%s, please provide path to file.\"" + }, + { + "prediction": "Please add your name to the top of the file.", + "reference": "This is done automatically, you can skip it next time ;)" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should just raise an error if the element is gone.", + "reference": "This is needed in `set_value` because of `:open-editor` (you could open an editor, close the tab, then close the editor). I don't think it makes any sense to have it here?" + }, + { + "prediction": "I think this should be `profiling_enabled` and `profiling_port` and `profiling_freq` to be consistent with the rest of the config.", + "reference": "Perhaps we can assume that profiling is enabled if ProfilingPort is set? And/or configure a default port and frequency, so we don't have to set three config vars every time?" + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.", + "reference": "This nil check won't correctly handle the case where forward_ssh_agent is set to false - it won't be nil but it should still not be set." + }, + { + "prediction": "Why is this needed? I don't see any changes to the code that would cause this to be needed.", + "reference": "We could avoid passing proto since threshold isn't needed." + }, + { + "prediction": "Why is this disabled?", + "reference": "This route excluding needed for reconnect only when one connection is lost and we trying to establish another. I was thinking to make 2 separate flags for killswitch and reconnect enabling. This way we can keep killswitch working, but we don't need these routes excluded." + }, + { + "prediction": "why move this line here?", + "reference": "why can this modification avoid crash?" + }, + { + "prediction": "Metrics/MethodLength: Method redirect_if_disabled has too many lines. [15/10]", + "reference": "This looks good -- signing out the user if the current user is disabled" + }, + { + "prediction": "I don't think this is correct. If you select a row header, you don't select the whole row. You select the whole row only if you select the corner header.", + "reference": "The line exceeds 120 characters." + }, + { + "prediction": "I think this should be `desc[\"php_version\"].(string)` to avoid a panic if it's not a string for some reason.", + "reference": "Let's go ahead and change \"Site\" to \"Project\", since that's the path we've chosen. One less thing to alter in the other issue." + }, + { + "prediction": "I think we should keep this. It's useful for debugging.", + "reference": "I am for this change iff we are sure the information is no longer helpful. I think this could still be valuable for certain scenarios, wbu?" + }, + { + "prediction": "I think we should use `Comparator.comparingInt` here, since we're comparing `int`s.", + "reference": "I thought we decided on using the latest active version and not the one which is max ramped up." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but I think it's the best we can do for now.", + "reference": "can we update this to a `log.Warningf`?" + }, + { + "prediction": "I'm not sure this is the right thing to do. If the container is not connected to the network, then the command will fail. I think it would be better to check if the container is connected to the network before trying to disconnect it.", + "reference": "can we get something emitted in the logs on non-zero exits to trace back to for problems like this failing on the first invocation?" + }, + { + "prediction": "`schemaMan` is not used in `AddVerticesProcessor::instance`", + "reference": "Do we need `schema manager` at here ?" + }, + { + "prediction": "I think this should be `#cgo LDFLAGS: -L${SRCDIR}/target/release -ldl -Wl,-Bstatic -lflux_parser -Wl,-Bdynamic -L${SRCDIR}/target/release -ldl -Wl,-Bstatic -lflux_parser -Wl,-Bdynamic -L${SRCDIR}/target/release -ldl -Wl,-Bstatic -lflux_parser -Wl,-Bdynamic -L${SRCDIR}/target/release -ldl -Wl,-Bstatic -lflux_parser -Wl,-Bdynamic -L${SRCDIR}/target/release -ldl -Wl,-Bstatic -lflux_parser -Wl,-Bdynamic -L${SRCDIR}/target/release -ldl -Wl,-Bstatic -lflux_parser -Wl,-Bdynamic -L${SRCDIR}/target/release -ldl -Wl,-Bstatic -lflux_parser -Wl,-Bdynamic -L${SRCDIR}/target/release -ldl -Wl,-Bstatic -lflux_parser -Wl,-Bdynamic -L${SRCDIR}/target/release -ldl -Wl,-Bstatic", + "reference": "This won't work because of the permissions on the directory when this is included as a library. But, we may be able to do this. The key would be wrapping this command with either a script or a go binary that ensures the current directory is writable. If the current directory is not writable, it would attempt to make it writable so that we could write out the produced binary. But I'm not sure if that will influence the hash that gets produced for `go.sum` since I am not sure how that is calculated. Alternatively, we can choose a place in `/usr/local` or choose a location that is writable in the go cache and use that. I'll give that a try since it might be needed for the ARM builds if we choose to only include `x86_64` precompiled binaries in the module." + }, + { + "prediction": "I think this should be `r.scope.SetReturn(values.NewValue(nil))`", + "reference": "Correct me if I'm wrong, but is this necessary? Why not just use the value returned by `interpreter.Eval` and not mess with the scope? `interpreter.Eval` will return any produced side effects. This means TableObjects as well as any value resulting from any expression statements." + }, + { + "prediction": "I think this should be `p.Spec.ServiceMetadata.Labels.Merge(config.Labels)`", + "reference": "This service is global per namespace, not per Alertmanager/Prometheus/ThanosRuler instance. So this approach won't work. But maybe I missing out something, can you describe your use case here?" + }, + { + "prediction": "I think this should be a `bool` instead of a `string`.", + "reference": "Do we need this default? Since we aren't using a sql.NullBool or *bool, an unset column will be interpreted as `false` already... We don't set a default on our other bool fields (e.g. entry admin and downstream columns)." + }, + { + "prediction": "Metrics/MethodLength: Method has too many lines. [24/20]", + "reference": "thanks for moving these over. makes more sense for them to be in the exports_helper" + }, + { + "prediction": "Please remove this empty line.", + "reference": "That import now isn't needed anymore" + }, + { + "prediction": "I think this should be `Full path to the addon file that will be installed.`", + "reference": "Can you update the `Usage` to be an absolute path as well? Something like `/path/to/firebug.xpi`" + }, + { + "prediction": "I think this should be `MvxWindowsUapAccelerometer`", + "reference": "This class is missing the `MvxPlugin` attribute" + }, + { + "prediction": "I think this should be `wxLang.LayoutDirection` instead of `wxLang.LayoutDirection`.", + "reference": "What if `wxLang` is returned `None` from `getWxLang`" + }, + { + "prediction": "Why do we need to change this?", + "reference": "Please don't do changing like this unless it _**really**_ cares. BTW. Please look around to infer our naming conventions." + }, + { + "prediction": "I think this should be `log.fine(\"Preparing test environment\");`", + "reference": "This is in test code: understanding what we're doing is important in this context." + }, + { + "prediction": "I think this should be `--miner-enabled should not be true`", + "reference": "prob should still have an example that has multiple option names even if you have to make it up. Or maybe we don't need this method?" + }, + { + "prediction": "Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.", + "reference": "I believe respond_to whitelists the formats passed to the block so if we don't want to display html, we can just remove the line format.html..." + }, + { + "prediction": "I don't think we want to print the error here.", + "reference": "stylistic nitpick: I _feel_ like we've largely shown errors like this as \"error: \" vs. \"error=\". IMO colon/space reads better." + }, + { + "prediction": "This include is not needed anymore.", + "reference": "We could put this implementation in `RTPSWriter::create_change_pool` and avoid an extra function." + }, + { + "prediction": "nit: remove the extra backtick at the end of this line.", + "reference": "should this file ends with _test.go?" + }, + { + "prediction": "I think this should be `ss = inet_pton(socket.AF_INET6, self.src)`", + "reference": "It's because of this change. `ss` was unused and it made sense in the program. However I haven't read the IPv6 RFC so I'm unsure of what it does" + }, + { + "prediction": "I think we can remove this line.", + "reference": "\"Flatten\" is a verb, so I'd probably go with `flattenedIndex` as a variable name here." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but I think it's the best we can do for now.", + "reference": "If it can only be called once, perhaps a more appropriate name is something like `setMaskables`? `addX` sounds like you can add many `X`es by calling it many times" + }, + { + "prediction": "I think we can remove the `MakePublicS3SessionForDownload` function and just use `MakeS3SessionForDownload` here.", + "reference": "Nodecfg should be downloading from a private bucket -- these shouldn't be for public consumption. In general these should be generic and expect environment to provide appropriate credentials and bucket." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get the notifications to be announced.", + "reference": "Could you please end the file with an empty line?" + }, + { + "prediction": "I think this should be `INFO` level.", + "reference": "This is an incorrect change. The dialect spoken is an important part of the handshake and should be communicated to users." + }, + { + "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to add a `Cancel()` method to the `Workflow` struct. This would allow you to cancel a running workflow without having to call `New()` again.", + "reference": "Can this be non-exported to avoid direct use? It would be a breaking change but using previous package version would work." + }, + { + "prediction": "I think this should be `return gcerrors.Code(err)` instead of `gcerrors.Code(err) == gcerrors.NotFound`.", + "reference": "Nit: this is just `return gcerrors.Code(err)`, isn't it?" + }, + { + "prediction": "I'm not sure why this was removed, but it seems like a good idea to have a timeout here.", + "reference": "I don't know where this came from, but it's not a good idea. This is actually timing out after 5 rounds, not 5 blocks. 5 consecutive null blocks won't be that uncommon. Also when testing with a short block time, this is a very short duration that can contribute to flaky tests." + }, + { + "prediction": "`with open(statePath, \"r\") as f:` -> `with open(statePath, \"rb\") as f:`", + "reference": "In Python 3 when pickling or unpickling objects, the file needs to be opened as binary so that no text encoding/decoding takes place. So for any open calls around pickle loads or dumps, the mode for reading must be rb and the mode for writing must be wb." + }, + { + "prediction": "I think we should pass `params.qstring.method` here as well, since it's used in `fetchMergedEventGroups`", + "reference": "did you remove **params.qstring.method** intentionally? if so why?" + }, + { + "prediction": "I think this should be `read.locality.task.initialize.threads` to be consistent with the other properties.", + "reference": "What is the current default? Is that inconsistent across uses and that's why this is null?" + }, + { + "prediction": "Why is this needed?", + "reference": "Why did we make this change? How come it wasn't an issue before" + }, + { + "prediction": "I think you can remove the `ASSERT_NO_FATAL_FAILURE(Init());` here.", + "reference": "Can you tighten scope by moving to of these variables? i.e. Move to ~4372?" + }, + { + "prediction": "I think this should be `dataverse.rserve.passwd` to be consistent with `dataverse.rserve.user` and `dataverse.rserve.host`.", + "reference": "Nice to see this `dataverse.rserve.password` fix rolled in." + }, + { + "prediction": "(style) line over 80 characters", + "reference": "How about the following faster alternative that doesn't need `strlen()` at all: if (*tmp_optarg == '\\0' || *endptr != '\\0') { fprintf(...) ... This would treat the bus argument as invalid if it's either empty (`tmp_optarg` points to '\\0') or invalid (`endptr` points to something other that a '\\0'). Actually, the existing code would accept an empty argument and set the bus to `0`, so if (*endptr != '\\0') { fprintf(...) ... would be enough. The check for an empty argument doesn't hurt, though." + }, + { + "prediction": "I think this should be `bcc` instead of `cc` since we don't want the user to know who else we're sending this to.", + "reference": "I could be missing something here, but the `from` and `cc` are the same. On the test email sent to gatewaycommunicator, these values are different." + }, + { + "prediction": "I think we can remove this `expect(cleanupFunction).to.be.not.called;` as well.", + "reference": "I'm honestly scared because act is now a hard requirement for useEffect which it wasn't before... This could break some tests :(" + }, + { + "prediction": "Why is this needed?", + "reference": "Could use election from `info_a.election`, or is this deliberate?" + }, + { + "prediction": "I don't think this is needed. The `getExtendedType` method is already defined in the parent class.", + "reference": "looks like this should be `return array(LegacyFormHelper::getType('form'));`" + }, + { + "prediction": "I think this should be `if (typeof opt_port === 'function') { ... }`", + "reference": "Maybe it would simpler to ignore opt_port if type !== 'number'?" + }, + { + "prediction": "I think this should be `for (var i = 0; i < categoryNames.length; i++) { name = categoryNames[i];`", + "reference": "Where was `name` being declared before?" + }, + { + "prediction": "I think this should be `appsv1.DeploymentConditionUnknown`", + "reference": "nit: use `corev1.ConditionUnknown`" + }, + { + "prediction": "I don't think this is correct. If `v.length === 24` then `v.length === 12` is also true.", + "reference": "You also need to add a similar check on line 992, there's another place where we check `length === 24`" + }, + { + "prediction": "I think we can remove the `checkState` here, as we already have a `checkState` in `getVoteProviderAfterBlock`", + "reference": "nit: can extract the voteProvider as a local variable" + }, + { + "prediction": "I think this test should be moved to `QueryEqualityTest` as it is testing the `QueryEqualityTest#assertFuncEquals` method.", + "reference": "[0] Not suggesting you change it here, but....kindof weird that there's just not an `assertFuncNotEquals`" + }, + { + "prediction": "I think this should be `addressToCheck` instead of `accountantAddress`", + "reference": "why are we passing 'registryAddress' here? We probably should construct it together with bc. Registry is not something that change?" + }, + { + "prediction": "It's like `RA.spreadPath|spreadPath`, but preserves object under property path", + "reference": "`.` at the end of the sentence" + }, + { + "prediction": "I think it's better to move this outside of the `if` statement, so that we always measure the time, even if the ping fails.", + "reference": "wouldn't it be useful to split this into an error metric for the timing?" + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "Not sure if this is good enough. Each generator will have it's own unit test anyway. Ideally, I think I'd want to test that each generator in the yml is actually a valid generator..." + }, + { + "prediction": "Why do we need to mock MintNewBlockWithActionIterator here?", + "reference": "line is 138 characters" + }, + { + "prediction": "I think this should be `func() error` instead of `func()` so that the caller can check for errors.", + "reference": "Nit: I would leave `Wire` out of the description; if you use this without wire you can still use it." + }, + { + "prediction": "I don't think this import is needed.", + "reference": "Nit: each field can be on a separate line to make it visually easier to read." + }, + { + "prediction": "I think this should be `compiler_info.json` instead of `compilation_database.json`.", + "reference": "Do we still have these files? Shouldn't we remove these?" + }, + { + "prediction": "This should be `ErrorDurationInvalid`", + "reference": "A lot of things to do with constants seemed to move since the original commit, so I stuck this here, Is there a better place for it?" + }, + { + "prediction": "I think we need to increase this to 10000.", + "reference": "is 10 too small compared to 1000? consider sync chan is unicast only (vs block chan is broadcast + unicast), i would say use 200~400 for BlockSyncChanSize my concern is that this would potentially slowdown sync speed of full-node" + }, + { + "prediction": "I'm not sure this is the right place to filter out private plans. I think it would be better to filter out private plans in `get_plan_info` so we don't have to do it in multiple places.", + "reference": "A full parse of the plan here on listing the plans will be expensive from both a computation and IO perspective." + }, + { + "prediction": "This should be in `machine_nrf52840_dk.go`.", + "reference": "These constants use the `_PIN` suffix, while the other constants don't use it. I'm not sure what is best, but I would prefer to keep this consistent. Do you have an opinion on which it should be (with or without suffix)?" + }, + { + "prediction": "I think we can make this `final` and remove the `@SuppressWarnings(\"FieldCanBeFinal\")` annotation.", + "reference": "Hmm... this feels like discovery should come first. perhaps `--discovery-dns-url`? @NicolasMassart any opinions on this or ideas on who it should be run by?" + }, + { + "prediction": "I think this should be `//go:build !ignore_autogenerated && go1.16`", + "reference": "why is this needed?" + }, + { + "prediction": "`key` is not used in this class.", + "reference": "I wonder if it'd be possible to autogenerate a key from the name within this function if one is not provided explicitly, rather than having all the callsites pass both the name and key (and usually as the same value)? Might give us a good place to implement a `name->key` function that isn't 1:1." + }, + { + "prediction": "I think this should be `TYPE_BINARY` instead of `TYPE_STRING`.", + "reference": "@adriancole I do not see a change in the thrift file. Are there unit tests verifying that this manual serialization is compatible with the native Thrift serialization done by classes generated from `.thrift` IDL file?" + }, + { + "prediction": "`strlen > PLAYER_NAME_LENGHT` -> `strlen > PLAYER_NAME_LENGTH`", + "reference": "spelling (variable name, all three changes)" + }, + { + "prediction": "`desiredUser` should be `desiredUID`", + "reference": "I believe you meant \"specify `desiredUID` and `desiredRole`\"?" + }, + { + "prediction": "I think we can remove this line.", + "reference": "Please follow the import style, move it to its similar group" + }, + { + "prediction": "I think this should be `errors.RouterUnrecognizedEncodingError(want, string(req.Encoding))`", + "reference": "Do we really need these? This is expanding on an API that we're about to do work on with the error stuff @kriskowal" + }, + { + "prediction": "I think you can remove this line as well.", + "reference": "passwordModificationTime is no longer used - did the change drop a time check that should be restored? Or should the param get dropped from the methods?" + }, + { + "prediction": "I think this should be `evt.CommandLine.Trim().Equals(commandLine.Trim(), StringComparison.OrdinalIgnoreCase)`", + "reference": "Would it break here without trim? If so, can we do trim in Startup.cs so we don't need to add this code to every parser?" + }, + { + "prediction": "I'm not sure this is the right thing to do.", + "reference": "Since we're using Logrus, probably best to use `Infof` to avoid confusion (Logrus' Printf behaves differently to the built in one)" + }, + { + "prediction": "I think we can remove this line as well.", + "reference": "Hm, this looks like a change that should go upstream as well." + }, + { + "prediction": "why remove this function?", + "reference": "let's keep ActionByActionHash and delete getActionByActionHash" + }, + { + "prediction": "I think it would be better to use `PricingGroupInterface` instead of `PricingGroup` here.", + "reference": "please use return type" + }, + { + "prediction": "I think this should be `INFO` as well.", + "reference": "This is deliberately at this level." + }, + { + "prediction": "I think you meant to remove the `as` here.", + "reference": "I'm going to go ahead and undo this change, I don't think it was intentional." + }, + { + "prediction": "nit: `current` instead of `currnent`", + "reference": "> specialised This isn't a typo in my neck of the woods" + }, + { + "prediction": "I think this should be `github.com/google/knative-gcp/test/cmd/target/storageTarget`", + "reference": "will change to `storage_target`" + }, + { + "prediction": "I think we can remove this line now.", + "reference": "This would be better as `cls.securitycenter_client`, to match what is being instantiated." + }, + { + "prediction": "I'm not sure this is the best way to do this. I think it would be better to use `ctypes.windll.kernel32.IsWow64Process` to check if the current process is 32-bit and then use `ctypes.windll.kernel32.GetSystemWow64Directory` to get the path to the SysWOW64 directory.", + "reference": "Could we have this initialization as part of the initialize method?" + }, + { + "prediction": "I don't think we need this anymore.", + "reference": "This line should be removed as editController is not used from this context anymore." + }, + { + "prediction": "I'm not sure I like the name `Transformation` here. I think `Processor` would be a better name.", + "reference": "This is correct in concept but the method signature doesn't really communicate the same thing. In other words, if the function produces an output table where is it? Its not on the function signature. Can you explain where the output table is created?" + }, + { + "prediction": "`self.init_cfg` should be `None` when `init_cfg` is `None` and `self.pretrained` should be `None` when `pretrained` is `None`.", + "reference": "For insurance, it's best not to take it directly" + }, + { + "prediction": "I don't think we need to pass `CharSequence[] value` here.", + "reference": "change 'value' to keysToSend, here and in other references in this commit. 'value' implies the user is getting the value of the element, rather than just the keys we're sending to it." + }, + { + "prediction": "I think this should be `task.SetIPAddress(taskIP)` instead of `task.SetLocalIPAddress(taskIP)`.", + "reference": "is the plan to fully migrate to boltdb and then remove the state save here?" + }, + { + "prediction": "This should be `rgb(255, 255, 255)`", + "reference": "This should be `output.colorBright`. Unless I'm missing some reason for adding a new theme variable." + }, + { + "prediction": "I don't think this is the right way to do it. The version is supposed to be the version of the software, not the version of the build system.", + "reference": "nit: I wonder if these should be moved down to where version is defined, just to keep them all in the same place." + }, + { + "prediction": "I think this should be `import javax.annotation.*;` instead of `import javax.annotation.*;\\n`", + "reference": "Is this supported by every implementation of Java (and Android)? Should it be conditional upon `gen_nullable`?" + }, + { + "prediction": "Metrics/LineLength: Line is too long. [101/80]", + "reference": "@briri Thanks! I just caught this too updating my feature branch" + }, + { + "prediction": "This should be `if len(configKey) == 0 && envpw != \"\" {`", + "reference": "I think you should move this block (and the `envpw := os.Getenv(\"RCLONE_CONFIG_PASS\")`) right to the start of the function, then we can remove the duplicate code below" + }, + { + "prediction": "I think this test should be in `RemoteNodeTest` instead of `NodeTest` since it's testing the `RemoteNode` class.", + "reference": "Is this only to set the node to draining? I think we can do that inside `Before` or something?" + }, + { + "prediction": "I think this should be `if (AzureAppServices.Metadata.IsRelevant && !string.IsNullOrEmpty(AzureAppServices.Metadata.SiteName)) { return AzureAppServices.Metadata.SiteName; }`", + "reference": "This should have been moved up above this inner `try` because the log message in the `catch` block does not apply to this." + }, + { + "prediction": "I think this should be `type PlanResult = Boltlib::Plan::Result`", + "reference": "Do we expect people to use PlanResult directly?" + }, + { + "prediction": "I think we can remove the `actualErr` variable and just return `waitErr` at the end of the function.", + "reference": "Maybe we should call this something like `errToReturn`?" + }, + { + "prediction": "why do we need to extend foundation bonus to fairbank + 1 year?", + "reference": "should calculate numEpochIn1Year = xxx and <= fairBankEpochNum+numEpochIn1Year a.foundationBonusLastEpoch just happens to be equal to 1 year now, but should not count on that" + }, + { + "prediction": "I'm not sure this is correct. The spec says that `img` is phrasing content, so it should be counted as phrasing content.", + "reference": "I wasn't sure if the content type needed to be removed from both the `default` and `usemap` objects - I'm not sure how usemap is used." + }, + { + "prediction": "I don't think you need to import struct here.", + "reference": "Duplication of line 28 Please refer your tox -e flake8 It seems that XStrField, XShortField, FieldLenField are not used" + }, + { + "prediction": "I'm not sure this is the best way to do this. I think it would be better to have a `FileModel` subclass that has a `set_filter` method that hides/shows rows based on the filter. Then you can just call `self._file_model.set_filter(self._to_complete)` in `_set_fileview_root` and `self._file_model.set_filter('')` in `_set_to_complete`.", + "reference": "I don't really understand the `self._file_model.index(path)` as parent here - you use `self._root_index` for `rowCount` above, so wouldn't the parent here need to be `self._root_index` as well?" + }, + { + "prediction": "I think this should be `int maxQueryLength = 1000000000;`", + "reference": "Do we want validation somewhere that max >= min? Or simply treat the max < min case as ignoring max?" + }, + { + "prediction": "I think this should be `AppendAsString(topFrame.ToString(), GetFormatProvider(logEvent), builder);`", + "reference": ":+1: that's a easier example :)" + }, + { + "prediction": "`findProductIdsWithBoundAttributeByAttributeId(AggregateId $id): array` -> `findProductIdsWithBoundAttributeByAttributeId(AttributeId $id): array`", + "reference": "If an external module decorates this interface, such a change will cause it to generate an error" + }, + { + "prediction": "I'm not sure this is the right thing to do here. I think we want to remove all plugins that match the pattern, not just those that match the pattern and have a period in the name.", + "reference": "Oh ha hah, FNM_PERIOD worked out nicely there. Points for co-opting a file system convention." + }, + { + "prediction": "remove this empty line", + "reference": "wrong grouping. As you can tell from the other files, we put system packages in the first group, the 3rd party packages in the second group, and our own packages in the third group." + }, + { + "prediction": "I'm not sure this is the right thing to do. If the job doesn't exist, I think we should return an error.", + "reference": "Is `o.name` always set here?" + }, + { + "prediction": "I'm not sure this is the right thing to do. The steady state dependencies are only valid if the container is in steady state. If the container is not in steady state, then the steady state dependencies may not be valid. For example, if the container is waiting for a volume to be mounted, then the steady state dependencies may not be valid until the volume is mounted. So, I think we should only check the steady state dependencies if the container is in steady state.", + "reference": "Can this line be removed, as `SteadyStateDependencies` isn't updated anywhere? Also do we need to check the `TransitionDependencySet` here?" + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.", + "reference": "`plan.present?` and `has_active_subscription?` are equivalent. We can drop this change, while leaving the one on `app/controllers/application_controller.rb`." + }, + { + "prediction": "I don't think we need to disable pylint here. We can just add `# pylint: disable=too-many-locals` to the line above.", + "reference": "No need for this, as pylint already only turns things off for this function and it's needed for the entire function." + }, + { + "prediction": "I think this should be `c.config.Namespaces.AlertmanagerConfigAllowList` instead of `c.config.Namespaces.AllowList`.", + "reference": "L171 needs to be modified too?" + }, + { + "prediction": "(style) code indent should use tabs where possible", + "reference": "Why do you compare by nodeid? Simply saying d == e should be enough. Unless we have to objects in memory with the same nodeid. If that is so, something went really wrong." + }, + { + "prediction": "Please remove the `type='RetinaNet'` here.", + "reference": "configs/pvt/retinanet_pvt_t_fpn_1x_coco.py --> configs/pvt/retinanet_pvt-t_fpn_1x_coco.py" + }, + { + "prediction": "I think this should be `json:\"desiredStatus,omitempty\"`", + "reference": "Nit, this could be json:\",omitempty\"" + }, + { + "prediction": "I think this should be `BuildRequired` and not `BuildRequired`.", + "reference": "It's kinda funny to read `s.Image.Image` I wonder why it resulted to this way. What would it take to refactor to just `s.Image`?" + }, + { + "prediction": "Why do we need this?", + "reference": "nit: I like the idea! can we instead change the tag to `integration-remote` to be more specific? I feel like it's possible for us to use the `deploy` build tag for possibly another scenario" + }, + { + "prediction": "I think this should be `ground3` instead of `ground2` and `slot4` instead of `slot3` and `ground4` instead of `ground3` and `slot5` instead of `slot4` and `ground5` instead of `ground4`", + "reference": "Copy and paste error here. Edit: Also missing commas here and in other Perl croaks between some parameters and not others." + }, + { + "prediction": "Why do we need state root here?", + "reference": "stateRoot or maybe ParentHeader would make more sense from API point of view?" + }, + { + "prediction": "I'm not sure this is the right thing to do here. I think we want to keep the notification around so that the user can still interact with it, even if they're not connected to wifi.", + "reference": "Are you sure that this is no longer needed?" + }, + { + "prediction": "I think we should keep the `SNAPSHOT_COLUMNS` as it is, and add `SCAN_COLUMNS` and `SCAN_WITH_STATS_COLUMNS` to it.", + "reference": "Would it help to use SCAN_COLUMNS as base to build SCAN_WITH_STATS_COLUMNS e.g like so `SCAN_WITHSTATS_COLUMNS = ImmutableList.builder().addAll(SCAN_COLUMNS).add(\"value_counts\",....).build()` ?" + }, + { + "prediction": "I think it's better to remove the Ping RPC and only keep the ReportStat RPC.", + "reference": "`ctx` is unused in ReportStat" + }, + { + "prediction": "This is not needed.", + "reference": "We don't want to add boost as a dependency when building the Thrift compiler. Sorry." + }, + { + "prediction": "`minSpeedChange` and `maxSpeedChange` should be `int16_t`.", + "reference": "It's not printing the range. Also I think it's useful to print a warning above stating that the minimum change is -1000." + }, + { + "prediction": "I think it's better to use `c.c.Get().Resource(clusterPath + SchedPath + \"/\" + name).Do().Unmarshal(policy)` instead of `c.c.Get().Resource(clusterPath + SchedPath + \"/\" + name).Do().Unmarshal(policy)`.", + "reference": "if name is empty will this become enumerate ? (and cause the unmarshal to fail ?)" + }, + { + "prediction": "Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.", + "reference": "How about including a flash message that explains the exercises are only available to subscribers of X plan?" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but it seems to work.", + "reference": "You should also call `e.accept()` and `return` so the key press isn't processed further (as we're leaving insert mode anyways)." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "Freeze mutable objects assigned to constants." + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "Hmm, this feels hacky. Maybe good enough if it makes the test more stable, but why is timing even an aspect here, since below it should wait for these two things anyway?" + }, + { + "prediction": "I think this should be `activity.SetTag(SemanticConventions.AttributeHttpServerIP, xForwardedFor.Split(',').First().Trim());`", + "reference": "Do we want this on by default, or an opt-in (e.g. via some config while add the instrumentation)? I guess a more general question is - what's the bar for the default vs opt-in tags." + }, + { + "prediction": "I think it's better to use `/graph/status` to avoid conflict with other handlers.", + "reference": "`status` is just one of the features, named as status is not suitable." + }, + { + "prediction": "I think this should be `if (UserPreferences.getFeedFilter() != UserPreferences.FEED_FILTER_NONE) {convertView.setEnabled(true);feedsFilteredMsg.setText(\"{md-info-outline} \" + context.getString(R.string.feed_is_filtered));Iconify.addIcons(feedsFilteredMsg);feedsFilteredMsg.setVisibility(View.VISIBLE);} else {convertView.setEnabled(false);feedsFilteredMsg.setVisibility(View.GONE);}`", + "reference": "There is an option to hide the subscriptions list from the sidebar. If it is hidden, the filter text should not be displayed." + }, + { + "prediction": "I think this should be `getBool(\"query/useCircuitBreakers\", false);`", + "reference": "I'd like for all of this to be dynamically configurable at some point, but it doesn't have to be in this PR. Can add it to the future SIP or create a separate JIRA for it, as you think would be appropriate." + }, + { + "prediction": "Why is this removed?", + "reference": "move the constructor to down the `namespace`" + }, + { + "prediction": "I think this should be a `corev1.ObjectReference` instead of a `corev1.LocalObjectReference`.", + "reference": "Nit: ending with a '.' looks consistent with the fields around it." + }, + { + "prediction": "I think this should be `s.fieldsFromJWTSvidParams(ctx, req.Id, req.Audience, req.Ttl)`", + "reference": "Audit log will not have a warning about they are using a deprecated path, is it something we must care about?" + }, + { + "prediction": "Why is this change necessary?", + "reference": "I think you also want to update the condition to add ` || impl.Visibility == TypeMemberVisibility.FamilyOrAssembly`." + }, + { + "prediction": "I think it's better to use `DepositToRewardingFundBaseGas` and `DepositToRewardingFundGasPerByte` instead of `depositToRewardingFundBaseGas` and `depositToRewardingFundGasPerByte`", + "reference": "`DepositToRewardingFundBaseGas` is a global variable (from `gochecknoglobals`)" + }, + { + "prediction": "I think this should be \"Operational \ud83d\udee0\ufe0f\"", + "reference": "What do you think of \"operations\"?? Also what do these emojis look like on Linux??" + }, + { + "prediction": "I'm not sure this is the right place to put this, but I think it would be good to have a link to the blog post about teams on the teams page.", + "reference": "I like the word \"give\" here. Feels like I'm giving a gift to my team." + }, + { + "prediction": "I don't think we need to import all of these here, just the ones that are used in the tests.", + "reference": "Is it possible to use `np.random` module instead?" + }, + { + "prediction": "I think this should be `allow_None=False`", + "reference": "``default=None`` implies ``allow_None`` so ``allow_None`` is superfluous here. As a special case, if allow_None=True (which is true by default if the parameter has a default of None when declared) then a value of None is also allowed." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's better than leaving it hardcoded to `k3s-controller`.", + "reference": "Is there anything in particular that makes setting up the downstream rolebinding(s) to `system:k3s-controller` burdensome or confusing? This changes looks fine to me but it seems a shame to alias an embedded k3s controller. If we are doing this in other places that I am not aware of then we can dismiss this concern out of hand." + }, + { + "prediction": "Please remove the empty line here.", + "reference": "File is not `goimports`-ed (from `goimports`)" + }, + { + "prediction": "I think this should be `OperatingSystem` instead of `Os`.", + "reference": "nit: all other types in this project have full names, so maybe a better name would be `OperatingSystem`?" + }, + { + "prediction": "This should be `#include `", + "reference": "Why is this needed here?" + }, + { + "prediction": "I don't think this is the right thing to do here. If the method is not a type variable resolution method, we should throw an exception.", + "reference": "mmm, why a method declaration should not have the TypeVariableResolutionCapability? Is this ok?" + }, + { + "prediction": "Why is this order changed? Is there a specific reason for it?", + "reference": "nit: any reason you swapped the ordering?" + }, + { + "prediction": "\").dispatchEvent(new CustomEvent(\"change\", {\n bubbles: !0,\n cancelable: !0\n }));\n```\nReview comment?", + "reference": "can you de-uglify at least this line?.. hard to tell what changed..." + }, + { + "prediction": "I think we can remove the `loadXDPRaw` and `loadBPF` methods from the `BPFDataplane` interface.", + "reference": "Please can you merge master in before making these changes. I just reinstated a bunch of BPF UTs. Possible that the UTs use this code." + }, + { + "prediction": "This is not a regression test, it's a test for a new feature.", + "reference": "Do you want to add additional cases for `Bla.__b()` and `self.__c()`? (Just add additional classmethods `__b` and `__c` and the calls to `__init__`)" + }, + { + "prediction": "I don't think this is the right place to do this. I think it should be done in `get_current_user_records_that_can_be_displayed`.", + "reference": "the recids is never changed after. So, it should contains the exact shown results, whatever are the rights for the user (admin or simple user, restricted collections...)" + }, + { + "prediction": "I'm not sure this is the right thing to do. If the user has provided a ContentMD5, we should use it. If they haven't, we should not override it.", + "reference": "Shouldn't the docstring mention that the MD5 checksum of `p` is computed each time and verified? Also, could there be use cases where a caller might not want such a check to happen because, eg, a blob storage solution doesn't provide MD5 verification or uses another hash algorithm such as SHA256?" + }, + { + "prediction": "I think this should be `if eventName==\"gainFocus\" and hasattr(obj, \"focusRedirect\") and obj.focusRedirect:`", + "reference": "focusRedirect is used in the powerpnt appModule. We might have to make sure that this does not break. Having said that, I really like this being handled on the events level!" + }, + { + "prediction": "nit: remove extra new line", + "reference": "You imports are out of order" + }, + { + "prediction": "Why is this public? I don't see it being used outside of this class.", + "reference": "This should not be called Flow Trigger. FlowTrigger should has its own flowTrigger job name, for instance, \"flowtrigger\"" + }, + { + "prediction": "I don't think we need to create a new package for sqlite3. We can just use `db.NewSQLBase(\"sqlite3\", cfg.SQLite3File)` directly.", + "reference": "File is not `goimports`-ed (from `goimports`)" + }, + { + "prediction": "I think this should be `#if DEBUG && !NETCOREAPP2_1`", + "reference": "Why do we need `\\n` if we already use `WriteLine`? (and `\\n` is not cross platform)" + }, + { + "prediction": "I think it would be better to have a `MetricsProtocol` enum with `PROMETHEUS` and `GRAPHITE` as values.", + "reference": "What is instrumentation name used for? I'm not seeing other classes use it, only a getter, constructor, and builder." + }, + { + "prediction": "I don't think we need to disable the warning here.", + "reference": "@kristofgazso could you review these warnings?" + }, + { + "prediction": "This file should be deleted.", + "reference": "will delete this." + }, + { + "prediction": "Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
", + "reference": "~~Indent 2 lines above~~ Disregard. My fault" + }, + { + "prediction": "Why is this change necessary? I don't see how it relates to this PR.", + "reference": "What was the bug that this is fixing?" + }, + { + "prediction": "I don't think this is the right way to do it. The `base64.b64encode` function returns a `bytes` object, not a `str` object, so you'll get a `TypeError` when you try to format it into the `Authorization` header. You should use `base64string = base64.b64encode('%s:%s' % (parsed_url.username, parsed_url.password)).decode('utf-8')` instead.", + "reference": "This will always add the authorization header to the request object. Is this the right scope for these two lines? If username/password are not defined, it will encode 'Basic :'" + }, + { + "prediction": "I think this should be `bazel-out/k8-fastbuild/testlogs/com_github_google_flatbuffers/tests/`", + "reference": "Is this always how Bazel does paths? Would it be nicer to do `-DBAZEL_TEST_DATA_PATH=../com_github_google_flatbuffers/tests/` so this string is not hardcoded in the the source?" + }, + { + "prediction": "`date_utc` added so we can be sure to get the actual date and time based upon UTC and not the client date and time based on the client machine. `date_utc` added so we can be sure to get the actual date and time based upon UTC and not the client date and time based on the client machine.", + "reference": "Not an expert of ES, so not sure of the impact here." + }, + { + "prediction": "I think this should be `if (currContext->getRoleList(numRoles, roleList, granteeList) == SUCCESS)`", + "reference": "Who deletes the memory for the granteeList? (or the roleList for that matter)" + }, + { + "prediction": "I think this should be done in the destructor of `listener` instead of the destructor of `session`. The reason is that the `listener` may be destroyed before the `session` is destroyed.", + "reference": "This loop is missing a lock on subscriptions_mutex." + }, + { + "prediction": "Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "shouldn't clearance be setting these up for us?" + }, + { + "prediction": "I'm not sure I like the name \"noOp\" - it's not clear to me what it means. How about \"noop\" or \"null\" or something like that?", + "reference": "Need to update the doc for `TelemetrySDK` and `Host` structs deleting references from removed functions." + }, + { + "prediction": "I don't think we need to remove this method. It's used in `ASTAnyTypeDeclaration#isImplicitlyFinal()` which is used in `ASTAnyTypeDeclaration#isFinal()` which is used in `ASTAnyTypeDeclaration#isExplicitlyFinal()` which is used in `ASTAnyTypeDeclaration#isFinal()` which is used in `ASTAnyTypeDeclaration#isFinal()` which is used in `ASTAnyTypeDeclaration#isFinal()` which is used in `ASTAnyTypeDeclaration#isFinal()` which is used in `ASTAnyTypeDeclaration#isFinal()` which is used in `ASTAnyTypeDeclaration#isFinal()` which is used in `ASTAnyTypeDeclaration#isFinal()` which is used in `ASTAnyTypeDeclaration#isFinal()` which is used in `ASTAnyTypeDeclaration#isFinal()` which is used in `ASTAnyTypeDeclaration#isFinal()` which is used in `ASTAnyTypeDeclaration#isFinal()` which is used in `ASTAnyTypeDeclaration#isFinal()` which is used in `ASTAnyTypeDeclaration#isFinal()` which is used in `ASTAnyTypeDeclaration#isFinal()` which is used in `ASTAnyTypeDeclaration#isFinal()` which is used in `ASTAny", + "reference": "I think we should keep that here and add a new method `isSyntacticallyFinal` that returns `super.isFinal()` (and can be used in UnnecessaryModifier). Otherwise the contract of `isFinal` is not respected" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the `scrollIfNecessary` function. That way you don't have to remember to do this everywhere you call `scrollIfNecessary`, and you don't have to remember to do this everywhere you call `scrollIfNecessary` with `enableCellEditOnFocus` set to `true`.", + "reference": "Is there a reason why we wouldn't want to check this every time? Why are we only checking for the footer and scroll bar when enableCellEditOnFocus is true?" + }, + { + "prediction": "This import is not needed anymore.", + "reference": "You need to create an API for this class. This class should follow roughly the same dependency structure than RemoteAvailableInstallersPlayOnLinuxImplementation / RemoteAvailableInstallers. Maybe we could use a inner class here?" + }, + { + "prediction": "Why do we need to update `workflow_id` here?", + "reference": "This should not be a case, right? If `run_id` is the same `workflow_id` can't be changed. Actually surprised that it is not part of a key." + }, + { + "prediction": "Why is this being disabled?", + "reference": "How would AQR work for an INSERT/SELECT of one table into another where a LOB column is being copied?" + }, + { + "prediction": "I think we can remove this line.", + "reference": "Since these are ultimately different endpoints, it would be nice if we could move them up one level and nuke the common `sds` directory in order to reduce path stutter" + }, + { + "prediction": "I'm not sure if this is the best way to check for an empty array. I think it would be better to check if `beforeChangeResult` is an array and then check if it's length is 0.", + "reference": "Please check also whether `null` occurs in the rest of `beforeChangeResult` array." + }, + { + "prediction": "I'm not sure what you mean by \"this is client side\" here. This is a filter for an outbound, which could be either a client or a server.", + "reference": "Outdated docs. There is no response, there's an ack." + }, + { + "prediction": "I think this should be `return container.Exec([]string{\"/bin/sh\", \"-c\", \"exec /bin/sh\"}`", + "reference": "I'd rather have the container process remove the FIFO after it unblocks. Then `start` can always `Exec()`, and you can catch the \"FIFO does not exist\" error and translate it to a prettier \"someone must have already started the container\"." + }, + { + "prediction": "Why do we need to check `tx == nil` here?", + "reference": "can you check if there's other similar cases to add nil-check like this?" + }, + { + "prediction": "I'm not sure this is the best way to do this. I think it would be better to raise an exception if `commonname` is too long.", + "reference": "`<= 64`? I just picked up what you said in #3981 (\"the CN field is limited to 64 characters\") but maybe there's something I don't know where the 64th character is needed (trailing dot or whatever?) Also this sounds like something that could be beautifully unit tested. Sorry for bugging you :grin:" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "I understand that this grabs a Licenses objects but what is the autocomplete method used for? What does this do in context of the auto_completes controller?" + }, + { + "prediction": "I think this method should be called `getTransactionLocationByHash` to be consistent with the other `get...ByHash` methods in this class.", + "reference": "I don't really like that way of naming methods based on their arguments. But I can see that the other method names are the same ..." + }, + { + "prediction": "This method is not used in this PR. Please remove it.", + "reference": "@sekmiller This method correctly strips the leading and trailing slashes (and also \".\" and \"-\"); But I thought the plan was also to replace any multiple slashes between nested folders with a single slash. For example, as implemented now, I can enter \"folder1///folder2\", and it gets saved and displayed like this, with the 3 slashes. I thought we wanted to sanitize it as \"folder1/folder2\"." + }, + { + "prediction": "I don't think you need the backticks here.", + "reference": "Looks like the X86 inline assembly is not happy with this type. I will update that" + }, + { + "prediction": "Line is too long. [81/80]
Use the new Ruby 1.9 hash syntax.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Tabs and a space, again." + }, + { + "prediction": "This should be `taskmanager->GetTaskName(task_id).c_str();`", + "reference": "Please just enclose if blocks with brackets; this has created issues in the past so I'd prefer we don't use them" + }, + { + "prediction": "Metrics/LineLength: Line is too long. [121/120]", + "reference": "`version` isn't need anymore because it's built into `approve_proposal_url`, yes?" + }, + { + "prediction": "This import is not used.", + "reference": "Moved to the bottom of the file. `CtrlPDU` sits on `BTLE_DATA` so let's put it after" + }, + { + "prediction": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", + "reference": "This ends up requiring the `json` gem, right? Is there any way we can do this to be implementation agnostic (e.g. to let me use `yajl-ruby` for performance reasons (or because my app already brings in a JSON library)" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should return an error if we read 0 bytes and there is no error.", + "reference": "This seems dangerous. What circumstances lead to the need for a retry? Can that happen more than once? I'm concerned that if we hit the pathological state, this could turn into a CPU spinner. I wonder if we could get the same benefit from just \"trying again\" and failing if it fails the second time." + }, + { + "prediction": "I think it would be good to have a test for this case.", + "reference": "If there is a reference to other fields or methods, please do the initialization in the constructor." + }, + { + "prediction": "I think we can remove this file since it's not being used.", + "reference": "These should be importing from `pill-container`" + }, + { + "prediction": "I think this should be `RETURNVALUE_NOTPOSSIBLE` as well.", + "reference": "Why this change? It will now only show on the bottom of the screen as white text, is it correct behaviour?" + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.", + "reference": "Does this need to allocate a string or would a nil value (indicating no header) be a better?" + }, + { + "prediction": "I don't think we need this line.", + "reference": "Nit: Past tense of `reset` is also `reset`." + }, + { + "prediction": "I think this should be `return self.config.fee_per_kb()`", + "reference": "Shouldn't this use `'n'` instead?" + }, + { + "prediction": "I think we can remove the `enumsspb.TASK_TYPE_ACTIVITY_TIMEOUT` and `enumsspb.TASK_TYPE_DECISION_TIMEOUT` now.", + "reference": "revert back to 'TASK_TYPE_ACTIVITY_TIMEOUT'" + }, + { + "prediction": "I think this should be `template void Engine::GetBlock(const std::string &, T **, const Mode);`", + "reference": "Shouldn't we prefer passing a pointer by reference T*&, since these are C++ bindings?" + }, + { + "prediction": "Why do we need to create a new `AddressGroup` for each `ClusterGroup` in the `ClusterNetworkPolicy`? Can't we just use the existing `AddressGroup` for the `ClusterGroup`?", + "reference": "nit: Personally I feel that it's cleaner to let `toAntreaPeerForCRD` to take `ingressRule` as a param instead of `ingressRule.From`. It can call `processRefCGs` inside the function and do the ipBlock/AG union within the function itself. It might not be worth the refactor though." + }, + { + "prediction": "I think this should be `apis.ReconcileInProgress`", + "reference": "Pending has been set only for SPC.. why? for other CRs as well, this need to be done.. right?" + }, + { + "prediction": "`isset($options['class']) ? $options['class'] : ''` should be `isset($options['class']) ? $options['class'] : null`", + "reference": "would use an empty string here as default and then check for emptiness in the twig template. I dont like mixing types @core23 what do you think?" + }, + { + "prediction": "I think this should be `methodInfo.requestPageTokenName().toUpperCamel()`", + "reference": "How come we need case manipulation for the nextPageToken and not for pageToken?" + }, + { + "prediction": "Trailing whitespace detected.", + "reference": "why use these rather than regular named paths?" + }, + { + "prediction": "I think this should be `OPTIONS[:global] + %w[format]`", + "reference": "Hm, I don't think the extra flags are doing any harm here, but it does seem like `--help` is the only flag you could *actually* use with this command. We might eventually want to separate those out." + }, + { + "prediction": "I'm not sure if this is the right place to put this docstring. I think it would be better to put it in the docstring of the `create_candidate_sets_for_all_users` function.", + "reference": "We should make this a docstring, so that editors are able to pick it up." + }, + { + "prediction": "This is a bit of an odd name, but I think it makes sense in the context of this spec.", + "reference": "Put a comma after the last parameter of a multiline method call." + }, + { + "prediction": "I'm not sure what this does, but it looks like it should be removed.", + "reference": "App cache size is now managed dynamically by the `WebView`. This statement has no effect in the new framework." + }, + { + "prediction": "I think this should be `=== true` instead of `=== false`", + "reference": "VirtualNode has a `hasAttr` function, any reason why you're not using it?" + }, + { + "prediction": "I don't think we need this anymore.", + "reference": "This now throws when running tests (maybe the move to java 11??). Do we want to keep it?" + }, + { + "prediction": "I think this should be `if len(sha1) > 7 && len(sha1) < 40 {`", + "reference": "We can allow 7-char SHA, does not mean we want to show with 7-char in default, please change to `if len() > 10`, then cut." + }, + { + "prediction": "`Cannot add the duplicate file %{fileName}, it already exists` -> `Cannot add the duplicate file %{fileName}: it already exists`", + "reference": "this one should also have quotes i guess :)" + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to work.", + "reference": "Using the variable on range scope `mock` in function literal (from `scopelint`)" + }, + { + "prediction": "I think this should be `return res.isWorkflow() ? accepted(json(res.getDataset())) : ok(json(res.getDataset()));`", + "reference": "does this result in a 200 when the dataset is still inprogress/publishing not yet finalized? Seems like 202 is the right code for that (as it was) and the test should be watching for a 202?" + }, + { + "prediction": "I think this should be `ORDER_BY_PATH` or `ORDER_BY_PATHS` to be consistent with the other constants in this class.", + "reference": "Previously you could only order by the field you were searching by. But for full-text search, you can search across all indexed fields, and it didn't make sense not to have a sorting. For backward compatibility, the javascript code uses indexPath as the orderPath when no orderPath is provided." + }, + { + "prediction": "I think this should be `the desired DOM structure`", + "reference": "VIM didn't like your whitespace." + }, + { + "prediction": "I think we can remove the `using System.Threading;` and `using System.Threading.Tasks;` as well.", + "reference": "Are you sure the namespace should change?" + }, + { + "prediction": "I don't think we need to return anything from this method?", + "reference": "@martijn00 I'm not sure why we're keeping the object parameter and return type since this can be done by using MvxApplication with THint set to object" + }, + { + "prediction": "`TimeType` is not a good name, it should be `DurationType` or `TimeDurationType`", + "reference": "why do we create a time type here?" + }, + { + "prediction": "I don't think you need to include the css file here. The css file is already included in the html file.", + "reference": "Does this style actually need to get loaded in all of these components?" + }, + { + "prediction": "import io.servicecomb.transport.rest.vertx.accesslog.parser.impl.DefaultAccessLogPatternParser; import io.servicecomb.transport.rest.vertx.accesslog.impl.AccessLogHandlerImpl; import io.servicecomb.transport.rest.vertx.accesslog.AccessLogConfiguration;", + "reference": "import but not used so you did not resolve compile warnings?" + }, + { + "prediction": "`armor / 2` will always be an integer, so you don't need `static_cast()` here.", + "reference": "This is so much more concise and beautiful than the previous formula" + }, + { + "prediction": "I think this should be `protected final Logger LOG = LogManager.getLogger(AcceptanceTestBase.class);`", + "reference": "Is there any reason not to have the `static` modifier for the logger? _(that would be in keeping with the reference being uppercase)_" + }, + { + "prediction": "I don't think we need this interface. We can just pass in a struct.", + "reference": "It's not about session creation config. It's about passing consumer config parameters to underlying transport - nothing to do with session itself" + }, + { + "prediction": "This is a bit of a hack, but I think it's the best we can do for now.", + "reference": "Why is there an \"enable\" in the param name? Couldn't it just be `overrideDebug`? Here are everywhere else." + }, + { + "prediction": "Layout/ExtraSpacing: Unnecessary spacing detected.
Layout/SpaceAfterComma: Space missing after comma.
Layout/SpaceInsideHashLiteralBraces: Space between { and | missing.
Layout/SpaceInsideHashLiteralBraces: Space missing before |.
Layout/SpaceInsideHashLiteralBraces: Space missing after |.
Layout/SpaceInsideHashLiteralBraces: Space missing before }.", + "reference": "`published.recently_published_first` reads a little oddly to me. Is this the same thing as `Video.published.ordered`?" + }, + { + "prediction": "`throw new Error('Unable to parse content of ' + file.originalPath)` -> `throw new Error('Unable to parse content of ' + file.originalPath + ': ' + e.message)`", + "reference": "Encountered this because I had a stray comma. Figured I'd tweak it a bit." + }, + { + "prediction": "I think this should be `Eventually(getCIDRBlockRules(felix, \"iptables-save\"), \"8s\", \"0.5s\").ShouldNot(ContainSubstring(\"cali-cidr-block\"))`", + "reference": "qq: Should this include the iptables6-save sim. to the inverse checks above?" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "im open to explicitly checking NotSet value here but json logic already handles it so kept it this way." + }, + { + "prediction": "I think this should be `#include \"Util/Lua.h\"`", + "reference": "The naming of the include file appears to be unlucky." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think it would be better to have `legend_opts` be a `dict` and not a `LegendOptions` object. Then you could just do `axis.legend(title=title, **self.legend_opts)` and it would work.", + "reference": "Bit worried about this. At minimum you should make a copy of the dict here to avoid modifying a user supplied variable." + }, + { + "prediction": "I think this should be `if err := ec2svc.PruneLaunchTemplateVersions(machinePoolScope.AWSMachinePool.Status.LaunchTemplateID, machinePoolScope.AWSMachinePool.Spec.AWSLaunchTemplate.Version); err != nil {`", + "reference": "Is it better to create one before pruning? In case creation fails we don't want to delete the previous one. We create a new one, it is tagged as latest, so the previous can be deleted. `CreateLaunchTemplateVersion` returns the version created, how about directly trying to delete the previous version? Assuming the numbering is strictly increasing." + }, + { + "prediction": "I'm not sure this is a good idea. If we want to use a generic container, we should use a `ContainerDTO` instead of a `WinePrefixContainerDTO` in the `ContainerInformationTab` constructor.", + "reference": "Do we require the specific implementation information here?" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "How about `exists?(['domain ~* ?', domain.downcase])` ?" + }, + { + "prediction": "I think this should be `c.IsSet(FlagContextTimeout)` instead of `c.GlobalIsSet(FlagContextTimeout)`.", + "reference": "Is this getting used in other places? Can we switch all the places to use the new API you added?" + }, + { + "prediction": "I don't think we need to remove this. It's not a big deal if it doesn't work on Windows, and it's a big deal if it doesn't work on other platforms.", + "reference": "This need to be checked with linux. AFAIK, we have this file in our bin directory that is a link to the system file." + }, + { + "prediction": "I don't think we need to disable the indent rule for this file.", + "reference": "Shouldn't we import `default`? I can't get here to test." + }, + { + "prediction": "`ParseResult` is not defined in this file. Did you mean to use `urlparse.ParseResult`?", + "reference": "!!!!!!!!!!!!! @graingert, does this mean that tests haven't been running???" + }, + { + "prediction": "I think we can remove the `type != null` check here.", + "reference": "I've already tried the null-coalescing operator here and got a strange error, so did this the old-fashioned way." + }, + { + "prediction": "`parentRole === 'list' || !parentRole` is equivalent to `!!parentRole`", + "reference": "This doesn't follow our spacing convention. It's also a little hard to read. Can you reformat?" + }, + { + "prediction": "nit: I think we can remove the empty line here.", + "reference": "The deploy should come before template? EDIT: I see that in other files, we put a separate line and put deploy at the end. What is the reason for this?" + }, + { + "prediction": "I think we can remove this line now.", + "reference": "Consider making a constant (e.g. `MetricStreamConfiguration.Drop`)." + }, + { + "prediction": "I think this should be `from rdkit.six.moves import xrange as _xrange`", + "reference": "same question: why not just switch this to range too?" + }, + { + "prediction": "I think this should be `if (type == Type::Unknown)`", + "reference": "@chuckatkins most places used an empty string for \"no type\", but a few used `\"unknown\"`. I've converted both cases to `Type::None`. Do you know why there was a distinction before?" + }, + { + "prediction": "I think this should be `std::min(train_data_->FeatureGroupSizesInByte(i), static_cast(num_data_))`", + "reference": "should we assert for the type for `FeatureGroupData` ? I think it should be 1-Byte type." + }, + { + "prediction": "I think this should be `np.flipud(...)`", + "reference": "As long as you are sure this is definitely correct now... :-)" + }, + { + "prediction": "I think this should be `tempBasalCancel.setText(String.format(\"%s %s\", MainApp.instance().getString(R.string.cancel), activeTemp.toStringShort()));`", + "reference": "... so that all action buttons have the same height :-)" + }, + { + "prediction": "This file is not needed anymore.", + "reference": "Use correct, alpha sorted, include order. Correct order means: 1. Header corresponding to this source (i.e. `\"LatencyTestPublisher.hpp\"`) 2. C system headers 3. C++ system headers 4. Alpha-sorted external libraries headers 5. Alpha-sorted public headers from this project 6. Alpha-sorted private headers" + }, + { + "prediction": "I'm not sure I like the name `RequestFactory`. It sounds like it's a factory for creating requests, but it's not. It's a factory for creating a function that creates requests. I think we should just call it `RequestFunc` or something like that.", + "reference": "I hate this name, open to suggestions." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in `build.StoreTargetMetadata` so that we don't have to worry about it in multiple places.", + "reference": "Does this log line work? We need Warningf or just warning without the format string." + }, + { + "prediction": "I think this should be `sdk.WithMetricsProcessors(c.MetricsProcessors...)` instead of `sdk.WithMetricsProcessors(c.MetricsProcessors)`", + "reference": "The pull controller would need similar updates." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the right thing to do. The copyright year should be the year the file was created, not the year it was last modified.", + "reference": "ignore this.. just didn't want to litter with a commit update to satisfy license plugin" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Is this definition needed since it doesn't look like it's being used anywhere?" + }, + { + "prediction": "Align the elements of a hash literal if they span more than one line.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", + "reference": "Can this condition be reworded using `if` please?" + }, + { + "prediction": "`inputs != nullptr && !inputs->hasData()` -> `!inputs->hasData()`", + "reference": "after ||, no need inputs != nullptr" + }, + { + "prediction": "I think this should be `BuildspecPath` instead of `IntegTestBuildspecPath`.", + "reference": "Is it just preference or on purpose that using slice of structs instead of slice of pointers?" + }, + { + "prediction": "I think this should be `newVNode._dom = oldDom != null ? oldDom !== oldVNode._dom ? oldDom : oldVNode._dom : null;`", + "reference": "This line always confused me anyway. Good catch!" + }, + { + "prediction": "I think this should be `j.jServer.shutdown(context.Background())`", + "reference": "Should we add `ctx` to `BlockServer.Shutdown()` for this purpose? Would be nice, but I don't care too much." + }, + { + "prediction": "This change is not related to this PR. Please revert it.", + "reference": "Duration_t at RTPS level must be serialized using fractions." + }, + { + "prediction": "I think this should be `yarpcerrors.InvalidArgumentErrorf(msgInboundDispatcherNotRunning, service)`", + "reference": "\"peer\" has its own meaning within YARPC with its own class of objects. This should probably be \"dispatcher\" too?" + }, + { + "prediction": "I think it would be better to use `self.get_ctu_dir()` instead of `self.get_xtu_dir()`.", + "reference": "I do not like this line break before `=true`. Maybe starting the list in the next line would help to reduce the indent? This way we could keep this string together." + }, + { + "prediction": "why remove this?", + "reference": "_plugins should be removed too" + }, + { + "prediction": "I think this should be `node.hasAttribute('alt') && (nn === 'img' || nn === 'input' || nn === 'area') && node.getAttribute('alt') !== '';`", + "reference": "The rule selector will not include `` and `` elements. Why not make this a new, separate rule altogether?" + }, + { + "prediction": "I don't think we need to catch `NotFoundError` here, since it's only raised by `userscripts.run_async` when `cmd` is `None`, which shouldn't happen here.", + "reference": "@The-Compiler Is this style okay or would you prefer a common userscript exception base?" + }, + { + "prediction": "I don't think this is correct. `sub_type` should be a number, not a hex string.", + "reference": "we'd need to return a MongooseBuffer here instead of the Binary. lets add the subtype option to the buffer schema type as referenced in #1000 instead." + }, + { + "prediction": "Please revert this change. It's not related to the PR.", + "reference": "Let's remove this change." + }, + { + "prediction": "I'm not sure this is the right thing to do. If you have a table with a header row, and you navigate to a cell in that header row, you don't want to announce that the cell is selected.", + "reference": "Could you split this into multiple lines?" + }, + { + "prediction": "I'm not sure if this is the best way to get the current entity URL, but it seems to work.", + "reference": "This technically works, however it may be safer to use both `getCurrentReferenceURL` and `getCurrentEntityURL` and then make this condition `currentReferenceURL === currentEntityURL`. Currently, this code only works based on the internals of `getCurrentReferenceURL`, so by checking both we would decouple that." + }, + { + "prediction": "I'm not sure about this change. I don't think we should change the format of the error message.", + "reference": "It does not recommend capitalization" + }, + { + "prediction": "Line is too long. [82/80]", + "reference": "Minor thing, but can you use 1.9 hash syntax for this?" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but it seems to be the only place where `lambda_cwd_on_host` is used.", + "reference": "I tried to follow the code structure already present." + }, + { + "prediction": "I think it would be better to use `from.getPath()` instead of `from.toPath().toString()`.", + "reference": "seems reasonable to also want to include the 'to' location?" + }, + { + "prediction": "I think this should be `resource_filename(\"nupic.core\", \"\")`", + "reference": "Please leave 1 space char between commas here and other places in this PR." + }, + { + "prediction": "I don't think this change is correct. `pthread_attr_setscope` returns an error code, not 0 on success.", + "reference": "hm is this really &&? Not ||? Was it initially correct if any of these things are not set that it needs to recreated?" + }, + { + "prediction": "I think this should be `cli.hasOption(\"cluster\")` instead of `cli.hasOption(\"cluster\")`", + "reference": "Please don't use C-style array declarations. IMO our pre-commit ought to be enhanced to not allow this" + }, + { + "prediction": "I think this should be `memcmp(p->data.bo.bytes, p1->data.bo.bytes, p->data.bo.size) == 0`", + "reference": "@rhc54 This doesn't look like a comprehensive comparison. For `PMIX_STRING` we seem to actually compare the content of the data while here we only compare meta-information which doesn't ensure that values are the same." + }, + { + "prediction": "I think this should default to `true` instead of `false`.", + "reference": "I think `bypass_frontier_confirmation` conveys the intention better (default false as well)" + }, + { + "prediction": "I think we can remove this line.", + "reference": "This looks like it goes beyond the scope of removing `BlockHeight()`, in the future please do this in a separate commit at a minimum -- separate PR is fine too." + }, + { + "prediction": "I don't think we need to pass `tab` here. We can just use `self._widget.tab` in `set_muted` and `set_recently_audible`.", + "reference": "You'll also need to adjust `FakeWebTabAudio` in `tests/helpers/stubs.py`." + }, + { + "prediction": "I think we should keep the license header here.", + "reference": "@csrwng what should we do here? This one is from origin." + }, + { + "prediction": "I don't think we need to include this file here.", + "reference": "Follow alphabetical order." + }, + { + "prediction": "I think we can remove this interface and just have `IAutomaticTracer` inherit from `ICommonTracer` and `IManualTracer`", + "reference": "As far as I can tell, these always get and set the context as an `IReadOnlyDictionary`. Can we use that here instead of `object` and get rid of the `as IReadOnlyDictionary`?" + }, + { + "prediction": "I don't think this change is correct. The `` tag is used to highlight the matched text. Without it, the matched text will not be highlighted.", + "reference": "As you only have `{}` as the format string (without anything else in it), this is the same as doing `self._doc.setHtml(html.escape(self._opt.text))`" + }, + { + "prediction": "I think this should be `azkaban.security.credential.name`", + "reference": "Where would this be configured? In azkaban.properties?" + }, + { + "prediction": "This should be `if (typeof callback === 'function') return callback(err); else return this.s.promiseLibrary.reject(err);`", + "reference": "1. Use `const` instead of `var` here. 2. Move the check to after the `if (update == null || typeof update !== 'object')`." + }, + { + "prediction": "I think this should be `#if defined(__linux__) && LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 27) && !defined(H2O_ASYNC_NOTIFY_USING_EVENTFD)`", + "reference": "Let's assume that on Linux `eventfd` is always available as a wrapper of the eventfd2 system call. It is supported since linux 2.6.27 + glibc 2.9, as well as from the ancient versions of bionic. In other words, it would be fair to argue that the pair would be available on practically all platforms that provide `pipe2`. Therefore switching from using `pipe2` to `eventfd` on linux unconditionally would not cause issues on our users." + }, + { + "prediction": "I think it would be better to initialize it in the constructor.", + "reference": "This field could be `final`." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "would be good to have a test for the case when `shutdown!` raises" + }, + { + "prediction": "I think this should be `if (CmpCommon::getDefault(HBASE_ASYNC_OPERATIONS) == DF_ON && (t == ComTdbHbaseAccess::INSERT_ || t == ComTdbHbaseAccess::UPDATE_ || t == ComTdbHbaseAccess::DELETE_)) { hbasescan_tdb->setAsyncOperations(TRUE); }`", + "reference": "Does upsert pass this check also?" + }, + { + "prediction": "I think this should be `Infof(\"patch command successful: %s\", ioStreams.Out.(*bytes.Buffer).String())`", + "reference": "Apologies reviewers, I did end up pushing another change. I was starting to request SRE-P help to get the apiserver configs from some clusters before and after when I realized I can just log the stdout from the patch command to see if anything was changed or not. Much simpler to verify if my work did or did not make changes to the config during the transition. Also got the spacing issue you mentioned @abhinavdahiya Thanks all." + }, + { + "prediction": "I think this should be `kbfsConfigName + \".DS_Store\"`", + "reference": "I'm not sure this naming is a good idea; that's the format for macOS xattr metadata files on unsupported filesystems." + }, + { + "prediction": "Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Metrics/LineLength: Line is too long. [85/80]" + }, + { + "prediction": "I think we can remove this import.", + "reference": "Please remove these imports. The project's style is to use `Assert.assertEquals` and not import static methods in general. This also caused a lot of unnecessary changes." + }, + { + "prediction": "I think this should be `FLB_ERROR` instead of `FLB_RETRY`.", + "reference": "thanks. Note that returning at this point might leak memory from the allocations above, so the PR will need to take care of that too." + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "If you really want to rename this, you'll also need to adjust the name in `__init__` and in other places it's used (`browser/commands.py`)." + }, + { + "prediction": "I'm not sure why this doesn't work, but I think it's better to use `@OneToOne` instead of `@ManyToOne` anyway.", + "reference": "As discussed at standup, I gave up on this. Calling `DeleteMapLayerMetadataCommand` felt cleaner anyway because there might be other cleanup that needs to happen. @scolapasta and @matthew-a-dunlap plan to discuss this." + }, + { + "prediction": "@deads2k @smarterclayton I think this is the root cause of the test failure. I'm not sure how to fix it though.", + "reference": "Do we need these changes? If so, can you tidy up the messages? Looks like it might have been your testing/debugging changes" + }, + { + "prediction": "I think this should be `SecretTargetLogDriver` and `SecretTargetContainer`", + "reference": "where is the default being set?" + }, + { + "prediction": "I think this should be `matches[1].start` and `matches[1].length`.", + "reference": "these changes should likely be in the next commit instead" + }, + { + "prediction": "I think we can remove this now.", + "reference": "Since you have defined this struct, I would suggest to replace all exist literal structs by this." + }, + { + "prediction": "I think this should be `false` by default.", + "reference": "The field name doesn't really capture what this option does. I think `mConfirmDiscardMessage` would be a better choice." + }, + { + "prediction": "I think this should be `is_string($media->getBinaryContent()) || $media->getBinaryContent() instanceof Symfony\\Component\\HttpFoundation\\File\\File || $media->getBinaryContent() instanceof Symfony\\Component\\HttpFoundation\\Request`", + "reference": "what if `$media->getBinaryContent() == Symfony\\Component\\HttpFoundation\\File\\File` does `is_string()` return `true`? ping @greg0ire" + }, + { + "prediction": "I think this should be `if (field.nested_flatbuffer && field.attributes.Lookup(\"nested_flatbuffer\")) {`", + "reference": "maybe rather than `bool` make this field a `StructDef *` ?" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we want to make sure that we don't enqueue blocks to be deleted until we're sure that we're going to be able to delete them. If we enqueue blocks to be deleted and then we crash before we can actually delete them, we'll end up with a bunch of blocks that we can't delete. I think the right thing to do here is to wait until we're sure that we're going to be able to delete the blocks before we enqueue them to be deleted. I think the right thing to do here is to wait until we're sure that we're going to be able to delete the blocks before we enqueue them to be deleted. If we enqueue blocks to be deleted and then we crash before we can actually delete them, we'll end up with a bunch of blocks that we can't delete. I think the right thing to do here is to wait until we're sure that we're going to be able to delete the blocks before we enqueue them to be deleted. I think the right thing to do here is to wait until we're sure that we're going to be able to delete the blocks before we enqueue them to be deleted. If we enqueue blocks to be deleted and then we crash", + "reference": "Shall we maybe put this in a `const` like `backgroundTaskTimeout`?" + }, + { + "prediction": "I think it would be better to log the exception here, so we can see if this is happening more often than we think.", + "reference": "CI is complaining about this." + }, + { + "prediction": "I think this method should be moved to the `HistoryRemovalTimeProvider` interface, so that it can be used by the `DefaultHistoryRemovalTimeProvider` as well as by the `DefaultHistoryRemovalTimeProvider`.", + "reference": "Let's only change a file if it is really necessary. Such a change does not bring much value and makes it harder to find the original commit in which the method was introduced." + }, + { + "prediction": "I think it would be better to use `sprintf('%s%s', $useLazyLoading ? 'lazy' : '', $isAttributeClassExistsAndNotEmpty ? ' ' . $attributes['class'] : '')` instead of `sprintf('%s%s', $useLazyLoading ? 'lazy' : '', $isAttributeClassExistsAndNotEmpty ? ' ' . $attributes['class'] : '')`", + "reference": "I would prefer to set up space between classes in format pattern, `%s %s` and then use `trim()` to remove unnecessary whitespaces. This will also solve stripping whitespaces from the beginning and end of a string `$attributes['class']`" + }, + { + "prediction": "`LOG(ERROR) << \"unknown setence type[\" << sentence_->getType() <<\"]\";` -> `LOG(ERROR) << \"unknown sentence type[\" << sentence_->getType() <<\"]\";`", + "reference": "when Op is illegal should return here?" + }, + { + "prediction": "Why is this removed?", + "reference": "don't we need to remove the project version from installedVersions?" + }, + { + "prediction": "I think this should be `options[:page_ranges] = Array(options[:page_ranges]) if options[:page_ranges]`", + "reference": "the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here." + }, + { + "prediction": "I'm not sure this is the right thing to do. If we have an error flushing the IP set, we want to unlock it so that we don't leave it in a locked state, but we also want to return the error to the caller so that they know something went wrong. I think the right thing to do here is to unlock the IP set and then return the error.", + "reference": "This is intended. Pls revert this." + }, + { + "prediction": "I don't think this is correct. `T::compareTo` is not serializable.", + "reference": "Something wrong with cast to `(Comparator<> & Serializable)`, need to be investigated" + }, + { + "prediction": "I think we can remove the `case 'click'` as well.", + "reference": "I think we need this. Not sure, I'll test." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we want to disable iptables on all hosts, not just google_compute.", + "reference": "I'm going to need to check if google compute requires these steps in this order, or if you can disable iptables after the fact." + }, + { + "prediction": "I think this should be `// +build !no_stage`", + "reference": "Did go change their tags with the new version?" + }, + { + "prediction": "I'm not sure this is the right thing to do here. I think we want to use the `DataStoreTrustDomainConfigSource` as the primary source of truth, and only use the `TrustDomainConfigMap` as a fallback.", + "reference": "I don't recall what we decided here in terms of which source would get priority. As written, the static configuration will overwrite datastore results." + }, + { + "prediction": "I think this should be `len(dep.Outputs()) > 0`", + "reference": "I think it should still panic for when there are no outputs; might be nice to special-case that though so the message is more explicit." + }, + { + "prediction": "I think this should be `new MetricsConfig.MetricsConfigBuilder().build()`", + "reference": "*NULL_DEREFERENCE:* object `null` is dereferenced by call to `meterSupplier(...)` at line 122." + }, + { + "prediction": "I'm not sure if this is the right thing to do. I think we should be using the `readPreference.mode` instead of `readPreference.preference`.", + "reference": "switch over to .mode" + }, + { + "prediction": "Missing space after `+`", + "reference": "I guess your IDE did some auto-fixing here" + }, + { + "prediction": "I don't think we need this import.", + "reference": "This is an unused import failing recommit still." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "I'm concerned that we're conflating multiple things here. There are 2 things that Beaker should really care about: - Network transport - i.e. `ssh` vs `winrm` - Interpreter - i.e. `bash`, `cmd`, `powershell`, etc The problem is that @cowofevil is running Bitvise SSH, and he assumed we should be setting `is_cygwin: false` in node definitions. But that doesn't really accurately convey what we care about, and since Beaker doesn't appear to track network transport apart from interpreter, we end up in a strange state. `is_cygwin: false` appears to end up setting `is_powershell?` to `true`, which IMHO is not accurate or appropriate. Bitvise templates use `ssh` (like Cygwin), but the interpreter used is `cmd`, not `powershell`." + }, + { + "prediction": "Line is too long. [81/80]
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", + "reference": "I think this is ok for now. This ties into the larger issue of the site not having a consistent method for relaying form input errors. Please make sure the focus gets set on the close button when the dialog opens." + }, + { + "prediction": "I think it would be better to use `GhostTable` and `SamplesGenerator` instead of `GhostTable` and `SamplesGenerator`", + "reference": "Should these link be removed?" + }, + { + "prediction": "I'm not sure this is the right place to add the undo functionality. I think it would be better to add it in the `close_tab` method of the `TabManager` class, which is responsible for managing the tabs. The `close_tab` method of the `TabbedBrowser` class should only be responsible for closing the tab and emitting the `tab_closed` signal.", + "reference": "Please make this a keyword-only argument by adding a `*` argument before `add_undo`." + }, + { + "prediction": "I think we can remove this now.", + "reference": "didn't quite follow what this code block is doing." + }, + { + "prediction": "I'm not sure if this is the best solution, but it's the only one I can think of right now.", + "reference": "this doesn't sound pretty... I would rather we have a proper navigation for all modes - AFAIK TV remote navigation is very similar to normal keyboard, but maybe it just uses another key codes - those should be extracted in a single file and defined there depending on context then" + }, + { + "prediction": "I think this should be `if (newProps.value !== dom._prevValue) {`", + "reference": "After diffing the children we check whether the value got out of sync, if it did we update it. We also update the `_prevValue` to prepare for the next event hitting our controlled component" + }, + { + "prediction": "I think this should be `// Package node provides the glue-code needed in order to start a Bee node.`", + "reference": "It provides a type called Node which is a fully functional bee client. This package is where the dependencies are injected. It is not just a glue-code, it is concept of node." + }, + { + "prediction": "I think this should be `None` instead of an empty string.", + "reference": "I think this will change `''` to `'%'` unconditionally, i.e. there'll be no way to set `''` anymore. This should really only be used for values which make no sense anymore." + }, + { + "prediction": "I think this should be `RowKey rowKey()` instead of `RowKey getKey()`", + "reference": "Nit: this table's row key map -> this table's row keys map" + }, + { + "prediction": "I think this should be `PJ_LOG_WARN` instead of `PJ_LOG_NONE`.", + "reference": "this change should be reverted" + }, + { + "prediction": "This should be `os.path.join(basedir, \"misc\", \"qutebrowser.appdata.xml\")`", + "reference": "I'm a bit confused about the `os.path.dirname(basedir)` here - is this just to get to the parent directory? Either way, I think I'd prefer just having this in `update_version.py` as it's not needed in qutebrowser itself." + }, + { + "prediction": "I'm not sure if this is a bug or not, but I think it should be 21.", + "reference": "Revert this change and see below why..." + }, + { + "prediction": "Why not use `lvis_v0.5_instance.py`?", + "reference": "Should not switch to `lvis_v1_instance` here because that base config uses ClassBalancedDataset to oversample the data." + }, + { + "prediction": "I think this should be `info.getMaximumSimultaneousSessions()` instead of `info.getMaximumSimultaneousSessions()`", + "reference": "This is an informational message that allows someone to read the console output and understand how the grid node is configured. Please leave." + }, + { + "prediction": "I'm not sure this is the right place for this function. I think it should be part of the `AlertManager` interface, not the `Alert` interface. The `AlertManager` is the one that knows how to handle singleton alerts, so it should be the one that raises them.", + "reference": "This doesn't make sense to me. What does RaiseSingleton mean? To me it sounds like a single object is being.. raised? Not sure." + }, + { + "prediction": "I don't think this is needed.", + "reference": "What's the benefit of having jobExecutorTests as a member variable? What do you think about making the method static? Afterall, it is a stateless method." + }, + { + "prediction": "I think this should be \"Check metadata objects and their associated blocks for errors.\"", + "reference": "This looks like it's only downloading things, not really checking their true validity. Especially for the MD object. Should we call `BareRootMetadata.IsValidAndSigned()` in `mdGet`?" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if there is a better way to do this.", + "reference": "Nikoli, I believe that this addresses your concern. One question for you or Jae-Seung is if any allocation from the clone is properly cleaned up when the vector is destroyed. I believe that it should." + }, + { + "prediction": "I think this should be `KindAwsEcsApp` to be consistent with the other kinds.", + "reference": "should be `ECSApp`" + }, + { + "prediction": "I'm not sure if this is the right thing to do. I think it would be better to raise an exception if the user tries to get the `rect` of a non-W3C element.", + "reference": "flake8 is going to fail on this having 2 lines" + }, + { + "prediction": "I think we can remove this import.", + "reference": "should we make a dir named controllers/scheduler/podchaos" + }, + { + "prediction": "I don't think we need to change this constant. It's not used anywhere outside of this package.", + "reference": "there seems to be one KeyNode in kubernetes.go of PV.. would it make sense to use it?" + }, + { + "prediction": "I think we can remove this import.", + "reference": "Im gonna be a little annoying here but did you configure your linter correctly? This empty line should not be here. Maybe go to settings and check if `goimports` is enabled?" + }, + { + "prediction": "I think this should be `case MODPRIVATECHATOUT:` instead of `case MODPRIVATECHAT:`", + "reference": "Don't think this belongs in this pr" + }, + { + "prediction": "I'm not sure if this is the best way to do this. I'm not sure if we want to copy the outbounds or not. I'm not sure if we want to wrap the outbounds or not. I'm not sure if we want to return the outbounds or not. I'm not sure if we want to return a copy of the outbounds or not. I'm not sure if we want to return a copy of the outbounds with middleware or not. I'm not sure if we want to return a copy of the outbounds with middleware or not. I'm not sure if we want to return a copy of the outbounds with middleware or not. I'm not sure if we want to return a copy of the outbounds with middleware or not. I'm not sure if we want to return a copy of the outbounds with middleware or not. I'm not sure if we want to return a copy of the outbounds with middleware or not. I'm not sure if we want to return a copy of the outbounds with middleware or not. I'm not sure if we want to return a copy of the outbounds with middleware or not. I'm not sure if we want to return a copy of the outbounds with middleware or not", + "reference": "We can assert on the existence of Outbounds through ClientConfig calls right? Since this is only for tests, do we need this function?" + }, + { + "prediction": "I don't think we need this interface anymore.", + "reference": "@martijn00 so this PR introduces a new ViewModel lifecyle method? It isn't in the PR description/any new docs" + }, + { + "prediction": "`input_img_shape` is not a good name, how about `img_shape`?", + "reference": "Are these modification duplicate? Or should we move it into base detector." + }, + { + "prediction": "I think this should be `public static byte[] dagSeed(final long block) {`", + "reference": "Since this is private and single use it should be un-wrapped inside of the two-arg dagSeed method." + }, + { + "prediction": "I think this should be `$GLOBALS['TSFE']->tmpl->setup['plugin.']['tx_solr.'], $configuration`", + "reference": "why the order change? Also for the next chunk. (I understand the result will be the same though)" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it would make more sense to have a `Returns` field in the `FuncDef` struct.", + "reference": "I wonder if this should just be a single `string`? We don't have any cases where we return different types and it would make the parser simpler to just read a single identifier." + }, + { + "prediction": "I think we can remove this method and just call `getInputFile(task.file().path().toString())` in `getInputFile(FileScanTask task)`", + "reference": "I don't think this needs to change. Can you go back to the previous implementation?" + }, + { + "prediction": "`from molecule.core import Molecule` -> `from molecule import Molecule`", + "reference": "Bump it 2 lines higher, 'c' > 'u'." + }, + { + "prediction": "Please remove the empty lines.", + "reference": "Please do not add author here" + }, + { + "prediction": "remove empty line", + "reference": "Similarly, we should be able to persist action uniformly" + }, + { + "prediction": "Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "I think i'd prefer this override to be in the test helper instead, if that's possible?" + }, + { + "prediction": "I think this should be `0755` instead of `0777`.", + "reference": "This would be better with context added via wrapping or fmt.errorf()" + }, + { + "prediction": "I think we can remove this package. It's not used anywhere.", + "reference": "What's the purpose of this file?" + }, + { + "prediction": "I'm not sure this is the right fix. If the user changes the passcode length, we want to force them to set a new passcode, but we don't want to force them to set a new passcode if they change the passcode length to the same value as before.", + "reference": "@bhariharan Why was passcode length requirement allowed to be lowered?" + }, + { + "prediction": "I think we can remove this file as well.", + "reference": "This file needs a license header, too. Sorry I didn't catch that earlier." + }, + { + "prediction": "Why do we need to pass the genesis text as a string? Can't we just pass the bytes?", + "reference": "probably don't need `[:]` why not reference into `github.com/algorand/go-algorand/daemon/algod/api/server/lib` here and skip bouncing off daemon/algod/server.go ?" + }, + { + "prediction": "Why do we need `homogen_table_builder` here? Why can't we just use `table::wrap`?", + "reference": "Why reference is converted to table?" + }, + { + "prediction": "I don't think this is correct. If the token is not 0, we should return an empty list.", + "reference": "should we implement pagination in the fake datastore so the server startup code that paginates entries for trust domain validation can be tested?" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but it seems like a good place to me.", + "reference": "What mechanism will be exposed so the caller knows they're using the vectorized version?" + }, + { + "prediction": "I don't think we should be using `notice` here, as it will show up on the next page load. We should be using `flash[:success]` instead.", + "reference": "Can we remove respond_to block its not required here" + }, + { + "prediction": "I think it's better to use `namespace dal::preview` instead of `namespace dal`", + "reference": "Do not do that even in example, we demonstrate bad practice" + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "Hm, taking a second look over this, this is why we have the object inheritance structure that we do. This could be divided up by having a custom determine_if_x86_64 in the pswindows/exec hosts and then a default method in hosts.rb. That way all the custom ps windows work is in a single location." + }, + { + "prediction": "I think we can remove the `GetAwaiter().GetResult()` calls now that we're using `async`/`await` everywhere.", + "reference": "We have to `.Complete` now because of empty/null string test cases." + }, + { + "prediction": "Metrics/LineLength: Line is too long. [81/80]", + "reference": "Is there still a way to specify no recursion?" + }, + { + "prediction": "I think this should be `ToolName` and `ToolNameURI` or something like that. `HumanReadableName` and `URISafeName` are too generic.", + "reference": "How is this name being URI safe and being used programmatically related?" + }, + { + "prediction": "I don't think we need to do this. We can just use `this.plugin.uppy.i18n` everywhere.", + "reference": "I think we have to keep this as a fallback for now, else it's a small breaking change :(" + }, + { + "prediction": "I think this test should be changed to `OpDocExtra(\"-\")` and `OpDocExtra(\"bnz\")` should be changed to `OpDocExtra(\"+\")`", + "reference": "nit: shouldn't be part of this PR." + }, + { + "prediction": "I'm not sure if this is the right thing to do here, but I think it's the right thing to do.", + "reference": "this change looks wrong to me. I think the test is trying to signal that something went wrong by throwing the `Error` here, otherwise the `catch` below will swallow it." + }, + { + "prediction": "I think this should be `if (!_layout.IsThreadAgnostic && _cachedPrevRawFileName != null && _cachedPrevRawFileName.Length == reusableBuilder.Length)`", + "reference": "I'm doubting if this should be `if (_layout.IsThreadAgnostic)`, as ThreadAgnostic stuff could be calculated on every thread. (and thus could be lazy). non-ThreadAgnostic should be calculated on the main thread." + }, + { + "prediction": "Please use `org.slf4j.LoggerFactory.getLogger(LeftListWidgetChooser.class);`", + "reference": "Please use only `Logger` instead of `org.slf4j.Logger`" + }, + { + "prediction": "I'm not sure if this is the right place to put this. I think it should be in the `process_live` function, but I'm not sure if this is the right way to do it.", + "reference": "Should this be \"no limiter drop\", since this isn't an absolutely essential activity for the stability of the network?" + }, + { + "prediction": "This should be `console.log('Account alias ' + process.argv[2] + ' deleted.');`", + "reference": "I updated many of the success messages, because most of these operations don't return data if they succeed. This meant many of the operations would print: `Success null` if the script ran successfully." + }, + { + "prediction": "I think this should be `except FileNotFoundError as fnfe:`", + "reference": "Could you simply add it to the previous clause ?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to work.", + "reference": "@joshyrobot, I think you can just use localeCompare with only the first argument and leave the other arguments out (here and all the other lines changed). It seems to do the right thing, and then we don't have to worry about these extra options." + }, + { + "prediction": "I think this should be `if (slaOptions != null && !slaOptions.isEmpty())`", + "reference": "@chengren311 : where does this logic move to?" + }, + { + "prediction": "I think this should be `if len(s.scope.ManagedMachinePool.Spec.RoleAdditionalPolicies) > 0 && !s.scope.AllowAdditionalRoles() { return ErrCannotUseAdditionalRoles }`", + "reference": "Can we have a `nil` exception check at `s.scope.ManagedMachinePool`" + }, + { + "prediction": "I'm not sure this is the right place to remove this. I think it should be removed from `Search/Base/Options.php` and `Search/Base/OptionsTest.php` as well.", + "reference": "Rather than deleting this, should you just reformat it so it's the `*` settings, so if nothing is configured in facets.ini, the existing default behavior continues to work?" + }, + { + "prediction": "This should be `str_replace(\"_\", \" \", ucfirst($property))`", + "reference": "wrap, single line" + }, + { + "prediction": "I think this should be `returnType == null || returnType.isEmpty() ? \"Void\" : returnType;`", + "reference": "always use brackets for if statements" + }, + { + "prediction": "I think we can remove the `static NUnitIntegration` class and just use `FrameworkDescription.Instance` directly in the `OnMethodBegin` and `OnMethodEnd` methods.", + "reference": "`NUnitIntegration` doesn't need to cache this anymore." + }, + { + "prediction": "I think this should be `WHEN cardinality(parts) > 2 AND lower(element_at(parts, -1)) = 'gz' THEN concat(element_at(parts, -3), '.', element_at(parts, -2), '.', element_at(parts, -1))`", + "reference": "Why did you change it to `>=` here?" + }, + { + "prediction": "I think we can remove the `else if (tableName.startsWith(\"hive.\"))` block.", + "reference": "Looks like this needs to be updated. There is no need to remove `hadoop.` if Hadoop tables don't use this code path." + }, + { + "prediction": "Layout/SpaceInsideBlockBraces: Space between { and | missing.
Layout/SpaceInsideBlockBraces: Space missing inside }.
Layout/SpaceInsideBlockBraces: Space between | and } missing.", + "reference": "This require isn't need anymore, right?" + }, + { + "prediction": "I think it's better to use `github.com/mysteriumnetwork/payments/crypto` instead of `github.com/mysteriumnetwork/payments/crypto/crypto`", + "reference": "a bit weird to see payments crypto package inside connection manager. There probably will be services not having any relation with payments that will use connection manager. Thats why probably ping-ping by itself can be useful without any relation to payments.." + }, + { + "prediction": "I don't think this is the right place to set the XML type. It should be set in the constructor of the MarcAdvanced class.", + "reference": "I like the overall idea here, but I wonder if it would be more clear to define the property in the trait, and then set it in the constructors of the classes using the trait. Alternatively, at a bare minimum, it may be a good idea to add `?? 'Bibliographic'` here, to account for the possibility of the trait being used in a class that does not define the property at all." + }, + { + "prediction": "I'm not sure this is the right place to put this constant. I think it would be better to put it in the `quic` package.", + "reference": "I would prefer to not have a magic number, but construct this value out of other constants we already have." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in `kinto/__init__.py` so that it's done for all instances of Kinto.", + "reference": "The limitation is if somebody configure another policy with the same name, but it is an edge case we can ignore I guess." + }, + { + "prediction": "I think we can remove the `hashivault` import now.", + "reference": "? The package is named `hashivault`." + }, + { + "prediction": "I think this should be `strcasecmp(value, \"lazy\") == 0 || strcasecmp(value, \"true\") == 0`", + "reference": "I don't think this should enable xwayland, because it's convenient to toggle xwayland just by setting `xwayland` to `false`" + }, + { + "prediction": "nit: remove empty line", + "reference": "Remove this line by accident?" + }, + { + "prediction": "nit: trailing whitespace", + "reference": "Calling `.stream()` on a `DomainObjectCollection` is pretty much always a bug, as it doesn't include objects added later (and encourages people to use afterEvaluate). I wonder if we should make this an error prone check?" + }, + { + "prediction": "I think this should be `if err != nil && !sigFound {`", + "reference": "Thanks for paying attention to other places this might happen. This one is particularly important; I probably never should have gotten in the habit of CheckErr(), since it does a log.Panic() explicitly, which looks like something else until you look closely. It's supposed to be used places where \"can't happen\" but Things Can Happen." + }, + { + "prediction": "I think this should be `dscp & 0x3f` to make sure we only use the lower 6 bits.", + "reference": "What is the different between nw_tos and ip_dscp? Only high 6 bits vs low 6 bits and supported version?" + }, + { + "prediction": "I think this should be `StringData = MolToCXSmiles(*mol, false);`", + "reference": "I'm assuming that asSmarts & cxSmiles == asSmarts" + }, + { + "prediction": "I think this should be `self.param = type(self.param)(self.__class__, self=self, **self.__dict__)`", + "reference": "Seems like an oversight but I don't think the super would do anything else in this case unless I'm mistaken." + }, + { + "prediction": "I think we can remove the `readonly` here since it's not used outside of the constructor.", + "reference": "Curious, do we consider this as pedantic for example code?" + }, + { + "prediction": "I don't think it's a good idea to use the entity name as the form name, because it may contain characters that are not allowed in a form name.", + "reference": "Should we convert the entity name to snake case using `Doctrine\\Common\\Inflector\\Inflector::tableize` or similar ? Should a `snaked_name` or whatever be part of the entity metadata in order to use it for form names, ids, & other html attributes ?" + }, + { + "prediction": "I think this should be `GetPublicOutboundIP` to be consistent with `GetPublicIP`", + "reference": "Should be `client.outboundIp`" + }, + { + "prediction": "This file is not related to this PR. Can you please remove it?", + "reference": "Must these `using` statements not go inside the `namespace` block?" + }, + { + "prediction": "I think we can remove the `fbo` prefix here.", + "reference": "Why? I thought the previous way was idiomatic. (Same with the `MetadataVer` stuff above.)" + }, + { + "prediction": "I think you can just return `Promise.resolve()`.", + "reference": "shouldn't we `reject` here instead?" + }, + { + "prediction": "`gasPriceUnitIOTX, err := util.StringToIOTX(action.Core.GasPrice)` -> `gasPriceUnitIOTX, err := util.StringToIOTX(action.Core.GasPrice)`", + "reference": "check err or use gasPriceUnitIOTX, _ := if we are sure action.Core.GasPrice is correct" + }, + { + "prediction": "I think we can remove the `wait` parameter here as well, since we don't use it.", + "reference": "Just curious, was wait not used at all before?" + }, + { + "prediction": "Remove this line.", + "reference": "nit: can we remove this?" + }, + { + "prediction": "I don't think this is necessary.", + "reference": "is it not a problem when one synchronized function is called by other?" + }, + { + "prediction": "I don't think we want to allow updating the `login` or `email` of an account via the admin interface.", + "reference": "We (even as admins) shouldn't override the User Preference settings like `email_master`, `email_posts`, `email_kudos`, `email_new_followers`. These all would be set by the user of their choice. Please do remove these attributes from editing//updating. Thanks!" + }, + { + "prediction": "`Este :attribute j\u00e1 est\u00e1 ligado.` -> `Este :attribute j\u00e1 foi ligado.`", + "reference": "\"Este :attribute j est anexado.\" sounds better." + }, + { + "prediction": "I don't think we need to import `frame` and `series` here.", + "reference": "This line should be repeated for every module that needs testing. One cannot rely on nosetest to automatically discover all the modules. On the bright side, there is no need to change any of the other files." + }, + { + "prediction": "I think we can remove this now.", + "reference": "This error was unused" + }, + { + "prediction": "I think this should be `CloseShardRequest struct { ShardID int32 }`", + "reference": "Personally I wish we didn't have a proto for every single little thing we do. RequestShardAction with an enum for the action type would be a lot cleaner imo, but I'm pretty sure that ship has sailed :) Just kvetching." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it works for now.", + "reference": "Does this make more sense as `trails/_trail` now?" + }, + { + "prediction": "I think this should be `getOutpostARN` to be consistent with the rest of the function names in this file.", + "reference": "synced offline. let's move this to `agent_unix.go` to make the IMDS call, since this is not supported in Windows." + }, + { + "prediction": "Align the elements of a hash literal if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer double-quoted strings unless you need single quotes in the string, e.g. to avoid extra backslashes for escaping.", + "reference": "Too much indentation here. Should match the lines above, which have four spaces." + }, + { + "prediction": "I think this test should be removed, as it is no longer valid.", + "reference": "Same here we still need this test to make sure the fallback works." + }, + { + "prediction": "I think this should be `IMvxOverridePresentationAttribute` where `T` is the type of `MvxBasePresentationAttribute`", + "reference": "I'm wondering if we can actually base this on a `IMvxPresentationAttribute` instead of the base one." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to fix the issue.", + "reference": "could we switch to `undefined` here?" + }, + { + "prediction": "I think this should be `if (shouldCleanupSyncsSoup()) { cleanupSyncsSoupIfNeeded(smartStore); }`", + "reference": "The cleanup call" + }, + { + "prediction": "I'm not sure if this is the right thing to do. I think it would be better to show the artist of the first song in the album.", + "reference": "I think \"View artist\" is a bit more standard and expected. Or even \"Go to artist\" to take the Spotify terminology as-is." + }, + { + "prediction": "I don't think we need to check if `Puppet::Pops::Types::PSensitiveType::Sensitive` is defined. If it isn't, then `unwrap_sensitive_args` won't be called.", + "reference": "It might make sense to refactor this later so that we use a Bolt-native type to hide sensitive values." + }, + { + "prediction": "This file is not needed.", + "reference": "We were trying to move away from this to force people to always run tests under py.test." + }, + { + "prediction": "I think this should be `body.append(self._get_selenium_options())` instead of `body.extend(self._get_selenium_options())` because `self._get_selenium_options()` returns a list.", + "reference": "1 - create browser specific options class: - chromeoptions - firefoxoptions - argsoptions" + }, + { + "prediction": "I think we can remove the `reset_content_length = True` line here, as it is not used anymore.", + "reference": "should be a case insensitive match though no? DOCTYPE and doctype are both widely used" + }, + { + "prediction": "Style/RedundantSelf: Redundant self detected.
Layout/SpaceAfterComma: Space missing after comma.
Layout/SpaceInsideHashLiteralBraces: Space between { and | missing.
Layout/SpaceInsideHashLiteralBraces: Space missing before |.
Layout/SpaceInsideHashLiteralBraces: Space missing after |.
Layout/SpaceInsideHashLiteralBraces: Space missing before }.
Layout/SpaceInsideHashLiteralBraces: Space missing after }.", + "reference": "We must have a `fail ParamNotFound` here for cases where `@account.nil?`." + }, + { + "prediction": "I think we can remove the `#if !NETCOREAPP` and the `#endif` here.", + "reference": "How come this change was needed?" + }, + { + "prediction": "I think these should be `ADC0_PIN`, `ADC1_PIN`, etc.", + "reference": "Why are there only 6 pins here, while below it appears to have 8 ADC inputs? Are pin 2 and 5 used for something else on this board?" + }, + { + "prediction": "I think this should be `Insert(\"secpRoot\", gsf.ssb.Matcher())` instead of `Insert(\"secpRoot\", gsf.ssb.ExploreFields(func(messagesSelector selectorbuilder.ExploreFieldsSpecBuilder) { messagesSelector.Insert(\"secpRoot\", gsf.ssb.Matcher()) }))`", + "reference": "I think we need an issue to track that chain sync omits BLS messages, and then to fix and test it!" + }, + { + "prediction": "Line is too long. [86/80]", + "reference": "what is this default about? I am not using ngrok atm so would prefer an env var." + }, + { + "prediction": "I think this should be `false` by default.", + "reference": "@Samuell1 Might be better to say \"Automatically check for plugin updates on login\"." + }, + { + "prediction": "I think we can remove this `using` statement.", + "reference": "Thanks for the additional Process helper! Can we also cache the first `Process.GetCurrentProcess()` result in a static field so we don't have to repeatedly call it? It means we would also need to dispose it when the static `_runtimeMetricsWriter` instance is disposed" + }, + { + "prediction": "I think this should be `127.0.0.1` instead of `127.0.0.0.1`", + "reference": "just wondering what is the result of breaking the logic we test here? it seems that in that case we will just not return immediately, but i'm not sure whether the test will fail?" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should be testing the behavior of `inferModulePath` when it's called with a path that doesn't contain a `go.mod` or `go.work` file. In other words, I think we should be testing the behavior of `inferModulePath` when it's called with a path that doesn't contain a `go.mod` or `go.work` file. In other words, I think we should be testing the behavior of `inferModulePath` when it's called with a path that doesn't contain a `go.mod` or `go.work` file. In other words, I think we should be testing the behavior of `inferModulePath` when it's called with a path that doesn't contain a `go.mod` or `go.work` file. In other words, I think we should be testing the behavior of `inferModulePath` when it's called with a path that doesn't contain a `go.mod` or `go.work` file. In other words, I think we should be testing the behavior of `inferModulePath` when it's called with a path that doesn't contain a `go.mod` or `go.work` file. In other", + "reference": "We should fail the test if this returns `err != nil`." + }, + { + "prediction": "I think this is a bit confusing. Why not just set `provisionFailedTerminal` to `true` if `updated` is `true` and `stopped.Status` is `hivev1.ClusterProvisionFailedTerminal`?", + "reference": "What is the drawback of not having this flag as a gating condition to report the metric?" + }, + { + "prediction": "I think this should be `os.Args[0]` instead of `os.Args[1]`", + "reference": "`getProcessName()` will be less ambiguous, since Caddy has \"apps\" that it runs internally." + }, + { + "prediction": "Is there a way to get the size of a pointer from the debugger?", + "reference": "Is there any way to not hardcode this given we know the size in bytes? The public API has the flexibility of being a Span. Should we maybe not do anything printing DML? The runtime allocates the buffer, but it's a \"scratch memory\" area, The delegate gets it passed in and they decide how to use it. Also, how is DML used if the feature is for macOS support?" + }, + { + "prediction": "Why do we need a lambda here? Why can't we just pass `req.filter_ref()` to `buildFilter`?", + "reference": "How about just override the `buildFilter`? Passing another function here is a little weird." + }, + { + "prediction": "I think this should be a boolean flag, not a string.", + "reference": "This should just be a `.Bool()` flag I think, we don't encode anything beyond y/n here. See `$(RUN_CHECK)` and `$(STOP_ON_PKG_FAIL)` for examples of how to pass those in." + }, + { + "prediction": "I think this should be `case swift::MetadataKind::Function:`", + "reference": "Is this needed?" + }, + { + "prediction": "I think this should be `value` instead of `value.concat(' value')`", + "reference": "This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted." + }, + { + "prediction": "remove empty line", + "reference": "how about moving it under L26" + }, + { + "prediction": "I'm not sure if this is the right place to put this, but I think it would be nice to have a way to clear all memoized functions at the end of a run. This would allow us to remove the `axe._memoizedFns = [];` line in `run.js`.", + "reference": "I think this needs to be tested" + }, + { + "prediction": "I'm not sure if this is the right place to put this constant, but I think it makes sense to have it here since it's related to the Trail model.", + "reference": "Style/MutableConstant: Freeze mutable objects assigned to constants." + }, + { + "prediction": "`dictLength` is not used in this class, so it can be removed.", + "reference": "Just a thought, really. If it's a bug that can be probed for (and it can be - see Adrian's repro) then it could as well be a static initialization of a supplier of Deflater instances; if we probe for a buggy JVM, we return the wrapper. If we don't we return the Deflater. This way on non-affected JVMs nothing happens and if we do use the wrapper, we know the JVM is broken." + }, + { + "prediction": "I think this should be `private static` since it's not used outside of this class.", + "reference": "Looks like this should be publicly accessible for tests in any modules?" + }, + { + "prediction": "I don't think we should change the default behavior of the `Dotenv` component. If we want to change the default behavior, we should do it in the `Dotenv` component itself.", + "reference": "Allow putenv is necessary to be able to get environment variables with `getenv`?" + }, + { + "prediction": "This is not a valid C++ code.", + "reference": "use function to check it. - don't do everything in main" + }, + { + "prediction": "I think we can remove the global_configs argument here. It's not used in the base class.", + "reference": "Sorry I'm confused. Why not kwarg this like the others?" + }, + { + "prediction": " mrm|vex|reqp,x,END_LIST},\n+ {OP_vgatherdpd,0x66389258,\"vgatherdpd\",Vvd,Hx,MVd,Hx,xx, mrm|vex|reqp,x,END_LIST},\n }, { /* vex_W_ext 69 */\n- {OP_vgatherqps,0x66389318,\"vgatherqps\",Vvs,Hx,MVq,Hx,xx, mrm|vex|reqp,x,END_LIST},\n+ {OP_vgatherqps,0x66389318,\"vgatherqps\",Vvs,Hx,MVd,Hx,xx, mrm|vex|reqp,x,END_LIST},\n {OP_vgatherqpd,0x66389358,\"vgatherqpd\",Vvd,Hx,MVq,Hx,xx, mrm|vex|reqp,x,END_LIST},\n },\n };\n```\nReview comment?", + "reference": "First, any changes here should be synchronized with instr_compute_VSIB_index(). Second, the original looks correct to me: the first letter of the opcode name suffix is the index size, while the second is the memory size. So \"vpgatherdq\" is a d-sized index and q-sized memory. The operand size we store for memory accesses is always the memory size, not the address size, and for VSIB we store a single memory element size. It looks like we have no inside-opnd_t storage of the index size: that's done by dispatch on opcode it seems. I have a bunch of notes of discussions on how to handle VSIB: we decided to bail on encoding too much inside the opnd_t I guess." + }, + { + "prediction": "I think this should be `return self.output().path`", + "reference": "Sorry for going back and forth. Adding docstring here would be very helpful for others to understand the need of this method." + }, + { + "prediction": "I think this should be `return !canSeeInvisibility() && creature->isInvisible();`", + "reference": "You introduced a bug here." + }, + { + "prediction": "I think it would be better to do this check in the constructor of `ReplacementTransformUpdater` and throw an exception if both `oldValue` and `newValue` are non-empty.", + "reference": "Should we log a warning/error if only one is specified and not the other?" + }, + { + "prediction": "I think we can just return `&pipedservice.GetLatestEventResponse{Event: nil}` here.", + "reference": "`ctx` is unused in GetLatestEvent" + }, + { + "prediction": "I think this should be `if (config.node.peering_port == 0)`", + "reference": "This looks good to me. Personally, I would have the following for maximum flexibility: * convert peering_port from uint64_t to int. * Set the default value to \"-1\" to specify the value is not set * if the value is -1 then do `config.node.peering_port = network_params.network.default_node_port` That would allow for 0 to mean, select the port number yourself and be more consistent. But I am happy with the change as is, as well." + }, + { + "prediction": "remove empty line", + "reference": "The blank line between the summary and detailed description is better to be kept." + }, + { + "prediction": "I think this should be `if a.RemoveUnusedShapes`", + "reference": "Curiously, are these indents intended or should they be aligned?" + }, + { + "prediction": "I think this should be `if not roleText or roleText == \"\":`", + "reference": "What if we changed this to this? roleText=attrs.get('roleText', lambda:getSpeechTextForProperties(reason=reason,role=role)) That will prevent the function from ever needing called in the roletext case, and removes that if." + }, + { + "prediction": "I'm not sure I follow the logic here. If `doing_detach` is true, then `get_thread_private_dcontext()` will return NULL. If `doing_detach` is false, then `get_thread_private_dcontext()` will return a valid dcontext. So I don't see why we need to check `doing_detach` before calling `get_thread_private_dcontext()`.", + "reference": "This will still result in a safe_read_tls_magic on AMD in tls_thread_preinit()." + }, + { + "prediction": "nit: remove empty line", + "reference": "Can you remove this change?" + }, + { + "prediction": "I'm not sure this is the right fix. I think we want to check `crt.IsCA` here, not `crt.KeyAlgorithm == cmapi.RSAKeyAlgorithm`.", + "reference": "Oh, was that a bug in the validation?" + }, + { + "prediction": "I think this should be `startsWith` instead of `contains`.", + "reference": "Please use the Google java code style. Basically, add more space characters like in the statements below. Next to method arguments and curly braces. This is currently not checked on CI because it is too inconsistent in the code base but I would prefer new code to be consistent." + }, + { + "prediction": "I don't think you need to delete `val1` and `val2` here.", + "reference": "Actually, I don't think we need to create object on heap." + }, + { + "prediction": "I'm not sure about this change. I don't think we want to change the generated code to use `context` instead of `golang.org/x/net/context`.", + "reference": "this is a file we copy from gRPC, sp ideally it be fixed upstream as well.." + }, + { + "prediction": "I think we can remove this import as well.", + "reference": "changes like this, just strangle guava usages to be replaced by DelayLimiter into one place" + }, + { + "prediction": "I think we can remove the backticks here as well.", + "reference": "PropTypes need to be updated accordingly here. Note that the type also needs updating, not just the case. That is, these should both expect a `PropTypes.elementType` now instead of an `element`." + }, + { + "prediction": "I think this should be `strncmp(resource_str, \"id:\", 3) != 0`", + "reference": "maybe extra paren around `strncmp(...) != 0`" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in `onNewWindowCreated` and `onWindowClosed`.", + "reference": "We should call `Windows.onResume `: - When the app is launched for the first time - When the app is resumed after being paused (home button and resume or device goes to sleep) - After a permission prompt is displayed" + }, + { + "prediction": "I think this is a typo, it should be `Comparator.comparingLong(f -> f.getEpoch())`", + "reference": "Rename to ForksSchedule? Maybe in separate PR." + }, + { + "prediction": "I don't think we need to import `kinto.core.cache.heartbeat` here.", + "reference": "Why a blank line here?" + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
", + "reference": "I have a sense that this will actually eventually change to check the actual date so that subscriptions can be deactivated in the future. But I mention that here just to keep you in the loop. We should not make that change now, because it's not needed functionality." + }, + { + "prediction": "I think this should be `if (argSpec.isOption()) {`", + "reference": "What is the reasoning for using the negation of `isOption()` instead of simply using `isPositional()` to identify a positional param?" + }, + { + "prediction": "This should be `msg.addByte(player->getVocation()->getId() != VOCATION_NONE ? 0x01 : 0x00);`", + "reference": "Why would you add those if client version min is set to 1100?" + }, + { + "prediction": "I don't think we need to change this file.", + "reference": "You can delete this, it will now need to live in `gointerfaces` package" + }, + { + "prediction": "Line is too long. [81/80]
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", + "reference": "Okay, I still don't understand why you have to add `html_safe` here, and it still seems like a very bad idea. It will allow html tags in the title, and keep Rails from escaping literal greater-than or less-than chars not intended as HTML tags. It ought to work to just let Rails do HTML-escaing as normal, without any manual `html_safe` or `strip_tags` or whatever. I am not clear on what problem you are trying to solve, why the straightfoward approach does not work." + }, + { + "prediction": "I think this should be `if (mDisplayMode == DisplayMode.MESSAGE_VIEW || mDisplayMode == DisplayMode.MESSAGE_HEADER) {`", + "reference": "What is is subject when it's not the email subject. Why are we having to do this crap? What's calling this with an empty string?" + }, + { + "prediction": "I think we should keep the default sampler as `ProbabilitySampler(defaultSamplingProbability)`.", + "reference": "Could you also remove the `defaultSamplingProbability` constant from `sampling.go`? It seems to became unused with this change." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think we need to pass in an empty `appsv1.Deployment` here, otherwise the `GenerateStrategicPatch` function will fail because it won't be able to find the `appsv1.Deployment` type.", + "reference": "can you delete the `generateDeploymentStrategicPatch` function as well?" + }, + { + "prediction": "I think this should be `LOG.info`", + "reference": "I'd keep this at `info` level..." + }, + { + "prediction": "I think we can just return `TransformResult::noTransform()` here.", + "reference": "Don't use DCHECK to debug your code if it's the regular branch you need to handle." + }, + { + "prediction": "I don't think we need to remove these methods. They are used in the `NodeFactory` to create a new `AntlrNode` from a `Node`.", + "reference": "You should return null here instead. Null is an acceptable default value for the image attribute." + }, + { + "prediction": "I'm not sure if this is the right place to catch the error. I think it should be in the `invokeCleanup` and `invokeEffect` functions.", + "reference": "react bails as well?" + }, + { + "prediction": "This constant is not used anywhere, so it can be removed.", + "reference": "Can you please tell me why you did this?" + }, + { + "prediction": "I think this should be `videoConstraints.facingMode = this.opts.facingMode ?? videoConstraints.facingMode`", + "reference": "Reading this again it should prob prefer the `videoConstraints.facingMode` value over `facingMode` if the former was already set" + }, + { + "prediction": "Align the parameters of a method call if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "There's a good bit of class-level stuff that's repeated in our various product types. Think it's worth extracting a...dare I say it...module?" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we want to be able to set the WASM ABI on the command line, but we also want to be able to set the WASM ABI in the `config.json` file. I think the right thing to do here is to set `config.Target.WasmAbi` to `config.Options.WasmAbi` only if `config.Target.WasmAbi` is empty.", + "reference": "Please do not modify the `config.Target` field, it should contain exactly what is extracted from the JSON files. Instead, you can either: * Add a getter to the `config` variable (`*compileopts.Config`), so you can simply call `config.WasmAbi()` to get the value. * Use a local variable instead. The getter would be slightly cleaner, as it matches the pattern of other configurations (`CGO_ENABLED`, `GC`, `NeedsStackObjects`, etc)." + }, + { + "prediction": "I don't think we need to defer the stop here. The transport will be stopped when the test environment is stopped.", + "reference": "The nil check is not necessary for these. Append checks both sides for nil." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should only set the attributes if they are not already set.", + "reference": "Shouldn't we instead have the SDK apply these, internally? I.e., I would expect to see the dctx entries included in the span as first-class distributed correlations, not as span attributes." + }, + { + "prediction": "I think you can just return `resources, err` here, no need to wrap it in a struct.", + "reference": "nit: rename this in proto and update impl to `Search` to avoid stutter" + }, + { + "prediction": "Why do we need this?", + "reference": "is it necessary to order by id as a second ordering? this will take place only when several new slider items are created without reordering (position is then null). Wouldn't be better to recalculate position after creating a new item? (right now items with null in position behave differently in administration and on frontend)" + }, + { + "prediction": "`claimFromRewardingFundGasPerByte` -> `ClaimFromRewardingFundGasPerByte`", + "reference": "`ClaimFromRewardingFundBaseGas` is a global variable (from `gochecknoglobals`)" + }, + { + "prediction": "I don't think this is necessary. The `NOGIL gil;` is already in the `SubstructMatch` function.", + "reference": "How about modifying the NOGIL definition so that it only does anything if the thread safety flag (RDK_BUILD_THREADSAFE_SSS) is set?" + }, + { + "prediction": "I'm not sure this is the right place for this interface. I think it would be better to have it in the `chainlink` package.", + "reference": "blockheighter would be more clear" + }, + { + "prediction": "Why do we need this function? Why not just use `std::min`?", + "reference": "This is so weird as a utility function." + }, + { + "prediction": "This is a bit of a hack, but I couldn't find a way to ignore the `ConsistentRead` field in the `dynamodb.QueryInput` and `dynamodb.ScanInput` types.", + "reference": "Why? What would happen if you did not?" + }, + { + "prediction": "I don't think this is correct. If `o` is `null`, then `((JSONObject) o).opt(pathElement)` will throw a `NullPointerException`.", + "reference": "Unrelated bugfix for NPE." + }, + { + "prediction": "I think this should be `!$propertyMetadata['canBeSet']`", + "reference": "What if some extended the `AdminController` and had a check for the old option name? Could that be a valid use case?" + }, + { + "prediction": "I think this should be `countlyCommon.API_PARTS.data.r + '/data-manager/event-segment-map'` instead of `countlyCommon.API_PARTS.data.r + '/data-manager/event-segment'`", + "reference": "This will be only available when data-manager is enabled, is there a fallback in case data manager is disabled?" + }, + { + "prediction": "I think this should be `In JavaScript you can write %s.`", + "reference": "Do you think we want to move the call to `generateWorkerServiceRecommendedActions` inside `RecommandedActions()`?" + }, + { + "prediction": "I think this should be \"VUID-vkGetQueryPoolResults-flags-02827\" and \"VUID-vkGetQueryPoolResults-flags-02828\"", + "reference": "The VUIDs in this area are not great, but I think `ValidateQueryPoolStride` should probably be skipped if the query pool was created with type `VK_QUERY_TYPE_PERFORMANCE_QUERY`. VUID-02828 might be a better fit, but again, the existing VUIDs step on each other so it requires a bit of interpretation." + }, + { + "prediction": "I don't think we need this extension method. We can just use `key.ToBigEndianByteArrayWithoutLeadingZeros()` directly.", + "reference": "Iguess you should use ToDbKey here" + }, + { + "prediction": "Why do we need to change this?", + "reference": "x.tbk is the \"index\" below, and is done in Start()" + }, + { + "prediction": "I think this should be `DD_APPINSIGHTS_INSTRUMENTATIONKEY` instead of `DD_IsAppInsight`", + "reference": "Do we already have a convention for this? If not, would we consider \"DataDog.IsAppInsights\". And then use \"DataDog.\" prefix for all this settings, environment variables etc..? Such settings are, essentially, public APIs because they may conflict with customer data. Regardless of that , AppInsights has an s at the end :)" + }, + { + "prediction": "I think it would be better to check for `ctx->log_key != NULL && ctx->time_key != NULL` instead of `if (ctx->log_key && ctx->time_key)`.", + "reference": "this assignment is not necessary if the offsetof() is used in the configmap" + }, + { + "prediction": "Why do we need to remove the account from the store?", + "reference": "I'd rather leave a TODO here at least." + }, + { + "prediction": "I think this should be `request = {\"path\": \"/mushrooms/\"}`", + "reference": "Shouldn't this be `resource`?" + }, + { + "prediction": "I think this should be `value = DataType(0);`", + "reference": "Why does this become blocking for the CPU path? Shouldn't it remain independent of the GPU path?" + }, + { + "prediction": "Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
Style/TrailingCommaInArrayLiteral: Avoid comma after the last item of an array.
Style/TrailingCommaInArrayLiteral: Avoid comma after the last item of an array.
Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
Style/TrailingCommaInArrayLiteral: Avoid comma after the last item of an array.
Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
Style/TrailingCommaInArrayLiteral: Avoid comma after the last item of an array.
Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
Style/TrailingCommaInArrayLiteral: Avoid comma after the last item of an array.
Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
Style/TrailingCommaInArrayLiteral: Avoid comma after the last item of an array.
Style/TrailingCommaInHashLiteral: Avoid comma after the", + "reference": "Do we need to change occurences where `setup` was called before?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would make more sense to do this in the `resolveReferences` function above.", + "reference": "Is this TODO still valid? Or are we going to put this somewhere else later?" + }, + { + "prediction": "I think this should be `if from_ts is None:`", + "reference": "We generally don't do parantheses in if conditions in Python. :) this could be better written as `if from_ts is None`" + }, + { + "prediction": "Why is this removed?", + "reference": "Odd that we'd set just element 299 of a 2000-byte buffer to null. But I see that this is the way it was before." + }, + { + "prediction": "I think this should be `EachPeerFunc func(peer swarm.Address, score float32) (stop, jumpToNext bool, err error)`", + "reference": "ScoreFunc is not used in this PR. Maybe to add it later when needed?" + }, + { + "prediction": "I'm not sure this is the right thing to do. If the response is a redirect, we should send the redirect to the client. If the client is a browser, it will follow the redirect. If the client is not a browser, it will not follow the redirect, and we should send the redirect to the client so that it can follow the redirect.", + "reference": "super nit: I think this might be easier to read as `requestHeadersFromResponseWriter`" + }, + { + "prediction": "Please remove the empty line.", + "reference": "Need to include \"common/base/Base.h\" in front of this line" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if there's a better way to do this.", + "reference": "Changes in this file should go into a separate PR." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we want to use double quotes here.", + "reference": "Please ensure that this will not start putting single quotes where double quotes are expected." + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to work for me. I'm not sure if this is the right way to do it, but it seems to work for me. I'm not sure if this is the right way to do it, but it seems to work for me. I'm not sure if this is the right way to do it, but it seems to work for me. I'm not sure if this is the right way to do it, but it seems to work for me. I'm not sure if this is the right way to do it, but it seems to work for me. I'm not sure if this is the right way to do it, but it seems to work for me. I'm not sure if this is the right way to do it, but it seems to work for me. I'm not sure if this is the right way to do it, but it seems to work for me. I'm not sure if this is the right way to do it, but it seems to work for me. I'm not sure if this is the right way to do it, but it seems to work for me. I'm not sure if this is the right way to do it,", + "reference": "`ProvideConfig` was changed, looks like it will not compile for windows, and should be changed too." + }, + { + "prediction": "I think this should be `models.GetUserRepositories(u.ID, true, 1, u.NumRepos)`", + "reference": "This does not look right, you're listing all private repositories.." + }, + { + "prediction": "Line is too long. [81/80]
Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "An OPTIONS request should respond from _any_ path? Seems weird to me..." + }, + { + "prediction": "I don't think we should add these fields to the media admin. The media admin is used to manage all media, not just images. If you want to add these fields to the image admin, you can do so by extending the image admin.", + "reference": "you need to add the content type" + }, + { + "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to have a `StopSubProcesses` method in the `ProcessHelper` class, and then call it from the `Stop` method of the `Tracer` class. This way, we can make sure that the sub-processes are stopped when the `Tracer` is stopped, even if the `Tracer` is stopped before the `ProcessHelper` is initialized.", + "reference": "Do we need to distinguish between these two processes? I'm thinking maybe we can have a list of processes and treat them all equally." + }, + { + "prediction": "(style) code indent should use tabs where possible", + "reference": "This is used only for out-of-line -- so yes this seems right to do for x64. Inlined is aligned separately at the end of prepare_for_clean_call(). There the ifdef is x86_64 or MACOS -- no ARM, why not? Also, please add || MACOS here to match the inlined." + }, + { + "prediction": "I'm not sure if this is correct. I think it should be `ZIPKIN_SPANS.TRACE_ID_HIGH.eq(ZIPKIN_ANNOTATIONS.TRACE_ID_HIGH).and(ZIPKIN_SPANS.TRACE_ID.eq(ZIPKIN_ANNOTATIONS.TRACE_ID)).and(ZIPKIN_SPANS.ID.eq(ZIPKIN_ANNOTATIONS.SPAN_ID))`", + "reference": "guess I'm wondering if this needs to be refactored to use Schema.joinCondition() or similar?" + }, + { + "prediction": "Style/TrailingCommaInOptionsHash: Avoid comma after the last item of a hash.", + "reference": "Does it make sense to restrict this option to `exec` only? You could add it specific to that subcommand using the `method_option`...method. There's an example of it for hosts in the `init` function." + }, + { + "prediction": "I think this should be `string.Join(\"=\", decodedPair.Split('=').Select(x => Uri.EscapeDataString(x)));`", + "reference": "This is very expensive (lots of allocations, lots of data copying). Could we do something like check IndexOf('%') and bypass if no hit?" + }, + { + "prediction": "I think this should be `client.getWorldType().contains(WorldType.DEADMAN)`", + "reference": "This should be `WorldType.isDeadmanWorld(client.getWorldType())` to be inline with the other WorldType calls." + }, + { + "prediction": "`mlvl_confids` -> `mlvl_confidences`", + "reference": "do we also need to change `mlvl_confid` -> `mlvl_confidences`>" + }, + { + "prediction": "This should be `config:\"oneof(insert,append);insert;non-zero,die-on-fail\"`", + "reference": "I feel slightly that InterfaceExclude is not a clear name - bearing in mind that our config names are, to some extent, an external API. From an external point of view, a clearer name might be IPVSInterfaces. Then it would obviously make sense for the value to be something like 'kube-ipvs0', and it would be a matter of Felix's internal implementation that we choose to exclude those interfaces from our monitoring. Alternatively, if we want to keep this at a level that is more general than just IPVS, perhaps 'UnmonitoredInterfaces'? WDYT?" + }, + { + "prediction": "`re.fullmatch` is only available in Python 3.4+", + "reference": "This should be `re.search` with a `^` anchor added to the regex, as what we want here is really any path starting with something like `E:`." + }, + { + "prediction": "I think we need to add a case for `KindEnvoyFilter` here as well.", + "reference": "Since `IsKubernetesBuiltInResource` at L69 returns false due to lack `networking.istio.io/v1alpha3` in `builtInApiVersions` within `pkg/app/piped/cloudprovider/kubernetes/resourcekey.go`, it will never reach this point." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get this test to pass.", + "reference": "Does codecov not run this test? Not sure how else it would not be covered." + }, + { + "prediction": "`multisend 'JSON_DATA'` -> `multisend JSON_DATA`", + "reference": "can we add some sample of JSON_DATA format in the usage?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's better to use `DistributedSpanContext` instead of `Active?.Span`. The reason is that `Active?.Span` can be `null` in some cases, but `DistributedSpanContext` will always have a value.", + "reference": "Using `Tracer.Instance` in here is problematic for testing It will likely cause some other tests to break I think - that's why we started passing in `IScopeManager` EDIT: I see you used `[TracerRestore]` - maybe that'll be enough!" + }, + { + "prediction": "I think this should be `projectIdVariableName` instead of `projectIdToken`", + "reference": "make all of these `static final` fields UPPER_SNAKE - they are constants." + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to work.", + "reference": "No possible chance for weird overflows here, right?" + }, + { + "prediction": "I'm not sure this is the right place to put this. I think it would make more sense to put it in the `TwoPhaseIterator` class.", + "reference": "Or we could use a Float object to more clearly show as user-settable via non-null?" + }, + { + "prediction": "Why do we need to pass `finalizedHeader` to `ForkchoiceUpdated`?", + "reference": "finalizedHeader should be saved in FinalizationManager when we have FinalizationBlockHash != Keccak.Zero" + }, + { + "prediction": "I'm not sure if this is the right place to add the scratch disk. I think we should add the scratch disk to the `AddDiskImportSteps` function and pass the scratch disk name to the `AddDiskImportSteps` function. Then we can use the scratch disk name in the `AddDiskImportSteps` function to create the scratch disk. What do you think?", + "reference": "Not using ExactName: true would remove the need for manually adding workflow ID as it would be added automatically by Daisy. E.g. 'disk-importer-2-import-ovf-7mn7h' was created from diskImporterDiskName above even though only 'disk-importer-2' was specified. ExactName: true should be used for resources that shouldn't include any temp prefix/suffix, such as disks that will be permanently attached to a created instance. Scratch disk is not one of them." + }, + { + "prediction": "I don't think we need to select the index columns here. We can just do `sdf = self._sdf.filter(expr)` and `internal = self._internal.copy(sdf=sdf, column_scols=[scol_for(sdf, col) for col in data_columns])`", + "reference": "If we support multi-index column later, we need to rename to fit the pandas' requirement." + }, + { + "prediction": "I think this should be `type JSONValue map[string]interface{}`", + "reference": "I'm not sure this is really needed. JSONValue type can be used the same as a map as far as operators go, including range. I'd leave this out for now unless there is a strong reason to keep it." + }, + { + "prediction": "I think this should be `Item::startDecaying(this);`", + "reference": "sorry for nitpicking but I would love a new line under this line" + }, + { + "prediction": "I think this should be renamed to `ChannelImplementationAddress` to be consistent with the rest of the codebase.", + "reference": "ChannelImplementation field naming is not clear, is it some kind of standard? Maybe it can be named ChannelID?" + }, + { + "prediction": "I think this should be `RemoveFiles removeFiles(String metadataLocation)`", + "reference": "Looks like there is a typo: `expireSnapshots` -> `removeFiles` or whatever name we go with." + }, + { + "prediction": "I don't think this is correct. If `currentSortOrder` is `null`, then `idxCurrentSort` will be `-1`, which is not what we want.", + "reference": "Thanks for looking into this. I think it looks a bit strange to have this check inside the for loop. Wouldn't it also work to initialize `idxCurrentSort` with 0 instead?" + }, + { + "prediction": "I don't think we need to add a new constant for this. We can just use OMNIPOD_POD_ALERTS_UPDATED.", + "reference": "Just a small ordering thing: Could you please bring `IMPORTANCE_HIGH` to the bottom and maybe even have one line between it and the Notification IDs?" + }, + { + "prediction": "I'm not sure this is the right thing to do here.", + "reference": "Should this be boost logged?" + }, + { + "prediction": "session is not used in this function, please remove it.", + "reference": "What is the reason for doing expunge here? This method is purely for converting the timestamp." + }, + { + "prediction": "I think it would be better to add the original field name as a property to the schema itself, rather than to each field. That way, we don't have to iterate over all the fields to get the original field name.", + "reference": "This calls sanitize twice if the name isn't valid." + }, + { + "prediction": "Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Is there an equivalent that'd allow zero or one?" + }, + { + "prediction": "I'm not sure this is the right place to set the object name. I think it should be set in the `repeatWith` method of the `taskExecutor`.", + "reference": "Is it possible to update/re-evaluate entire metatask object for every repeat? If we decide/need to use a repeatWith resources in let us say labelSelector(bad example) then we would have to add another logic to update those properties." + }, + { + "prediction": "Why is this change needed?", + "reference": "unnecessary conversion (from `unconvert`)" + }, + { + "prediction": "I think we can remove this line as well.", + "reference": "typo in commit message `openening`" + }, + { + "prediction": "I think this is not needed anymore.", + "reference": "User-code doesn't see the internal ADIOS headers anymore. This whole include block should just be `#include `" + }, + { + "prediction": "I think this test should be removed, as it doesn't test anything.", + "reference": "nit: I guess we can omit this (unless you had a reason to specify it)" + }, + { + "prediction": "I think this should be `c.kind == LEAF && c.leaf.remote != nil && !c.leaf.remote.Hub && !c.leaf.remote.Spoke`", + "reference": "Why is Hub public?" + }, + { + "prediction": "Why is this being removed?", + "reference": "why is this deleted?" + }, + { + "prediction": "I think this should be a link to the intro to rails tutorial, not an empty string.", + "reference": "Maybe move that into a partial" + }, + { + "prediction": "Why do we need to stop the dao here?", + "reference": "Error return value of `dao.Stop` is not checked (from `errcheck`)" + }, + { + "prediction": "I think this should be an error, not a warning.", + "reference": "util.Warning()? Easier to say." + }, + { + "prediction": "I'm not sure if this is the right place to put this, but I think it would be nice to have a log message when the trie check is done.", + "reference": "this default is kinda superfluous (although i see it was already there before PR )" + }, + { + "prediction": "I don't think this is a good idea. If you have a `NodeList` that is not attached to a `Node`, it will not be able to notify its observers when it is modified.", + "reference": "How is this related?" + }, + { + "prediction": "I'm not sure if we want to show the team plans on the individual subscription page. I think we should only show the individual plans on the individual subscription page, and the team plans on the team subscription page.", + "reference": "I'm breaking one of the rules here, it feels like the right thing to do. Open to alternative suggestions." + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "The use of `#should` was triggering an rspec depracation warning for me, which is why I switched this to the rspec 3 style." + }, + { + "prediction": "I think this should be `if(chit != m_changesForReader.end() && chit->isValid())`", + "reference": "Why are you setting the CacheChange as REQUESTED when it is not valid (it was erased from history)?" + }, + { + "prediction": "I think it's better to use `import { __ } from '@wordpress/i18n'; import { Component, Fragment } from '@wordpress/element'; import { isEmpty } from 'lodash';` than `import { __, Component, Fragment } from '@wordpress/element'; import { isEmpty } from 'lodash';`", + "reference": "`lodash` shouldn't be grouped under WordPress dependencies" + }, + { + "prediction": "I don't think we need to make this constructor public.", + "reference": "This needs to be public so that Avro can call it." + }, + { + "prediction": "I think we can remove this import as it's not used anymore.", + "reference": "`Google*` shouldn't be under External dependencies - seems like ESlint is not properly recognizing that these are aliases to internal dependencies." + }, + { + "prediction": "I think we can remove the `assert index is None` and `assert columns is None` here.", + "reference": "I think he meant the docstring in this constructor. yea we should fix" + }, + { + "prediction": "I think it would be better to have a `getResource` method that takes a `ResourceScheme` and a `String` and returns an `Optional`. That way we don't have to throw an exception if the resource doesn't exist.", + "reference": "so .. this basically follows the pattern from JapaneseTokenizer, I think. .. but somehow I don't see where we defined ResourceScheme? We're not referencing the one in kuromoji, right?" + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to work.", + "reference": "It would probably be better to do: const SecurityProtocolType Tls13 = (SecurityProtocolType)12288" + }, + { + "prediction": "I think we can remove this line as well.", + "reference": "Similar to the above, put this setting back but keep the value as `'{}'`" + }, + { + "prediction": "I think it would be good to add the `year_offset` and `year_count` to the log message.", + "reference": "As discussed in chat - we should run this function within an app context which means that we'd already have a logger configured, and a connection to timescale set up" + }, + { + "prediction": "I think we can remove the `#about .card-header` selector here, since we don't have any other `.card-header` elements on the page.", + "reference": "I'm curious about why this needed to be removed." + }, + { + "prediction": "I don't think we should import `plt` from `scapy.extlib` as it's not used in this file.", + "reference": "why did you remove `zip`? It is used!" + }, + { + "prediction": "Why do we need to pass an empty string here?", + "reference": "Is there any reason that we don't add a similar condition like `ChannelConditionTopic` to the channel?" + }, + { + "prediction": "This should be `TestVendor\\Goto`", + "reference": "before php8 \"goto\" was a reserved word and was not allowed as part of the namespace. Now test checks for validity of plugin namespace according to PSR-4" + }, + { + "prediction": "I think this should be `NewOutbound` instead of `NewSingleOutbound`.", + "reference": "nit: I'm not sure it can be addressed in this diff, but it seems odd that NewOutbound supports TLS but NewSingleOutbound does not. As a somewhat naive user I would expect the only difference between these two APIs is how peers are chosen." + }, + { + "prediction": "I think we should return the error from `res.Body.Close()` here, not the error from `o.call()`. The error from `res.Body.Close()` is more likely to be useful.", + "reference": "I would advise to enhance the test for the method `CallOneway` - we should have a test very similar to `TestCallSuccess`. We should test: - Success with response (even if it is callOneway) - Success with no response and empty payload - Errors" + }, + { + "prediction": "Remove the extra backtick here.", + "reference": "We're already matching +. Not sure why this changed." + }, + { + "prediction": "I think this should be `false` by default.", + "reference": "Please add line breaks, so the line doesn't exceed 80 chars." + }, + { + "prediction": "I don't think we need to pass `activitySource` to `HttpInListener` anymore.", + "reference": "I initially thought (inccoreclty) this is a breaking change! The public api analyzer is a gift!" + }, + { + "prediction": "I think this should be `g_ptr_array_unref`.", + "reference": "I'm not sure how this one didn't segfault before." + }, + { + "prediction": "I don't think we need to define these constants. We can just use the constants from `github.com/vishvananda/netlink`.", + "reference": "Same points as in other test file." + }, + { + "prediction": "I don't think we should be importing `java.io.*`", + "reference": "Did you run gradlew tidy? Wildcard imports shouldn't be there, hence the question." + }, + { + "prediction": "Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.", + "reference": "Put a comma after the last parameter of a multiline method call." + }, + { + "prediction": "(style) spaces required around that '=' (ctx:VxV)", + "reference": "Is this going to restrict the output to *ONLY* ports that are bound to vfio-pci? That's not what we discussed yesterday." + }, + { + "prediction": "I think this should be `if signer.Protocol() == address.ID || signer.Protocol() == address.SECP256K1 {`", + "reference": "Intention is to do the lookup here, I believe (where we can cache it). This would make the call non-pure function though. I'll confirm with lotus. ID addresses are the *only* addresses I expect to actually see here." + }, + { + "prediction": "typo: ERMFS -> EMRFS", + "reference": "electronic medical record file system (EMRFS)" + }, + { + "prediction": "I think this should be `maxrequestbody` instead of `maxrequestbody`", + "reference": "Put this higher in the list, like after \"bind\", since I guess we're considering the max request body size to be kind of a native/fundamental feature, built directly into the vhosts." + }, + { + "prediction": "I don't think we need to remove these errors. They are used in other places as well.", + "reference": "oh come on :(" + }, + { + "prediction": "I think this should be `INFO` level.", + "reference": "This is an incorrect change. The dialect spoken is an important part of the handshake and should be communicated to users." + }, + { + "prediction": "I think this should be `bool: Whether or not the authenticated user is a service account`", + "reference": "Remove as this is not needed anymore." + }, + { + "prediction": "I think this should be `-> Optional[int]`", + "reference": "This new class is for checking that #4551 works correctly with PlantUML output too." + }, + { + "prediction": "I'm not sure if this is the right place to set the usages. I think it should be set in the `certmanager` package, but I'm not sure how to do that.", + "reference": "Will this cause all certificates to be re-issued?" + }, + { + "prediction": "(style) code indent should use tabs where possible", + "reference": "I think tmp is also leaked at the end of this loop if no error cases are encountered." + }, + { + "prediction": "I think we can remove the `keyProjection.schema() != keyField.schema() ||` part of this conditional. If the `keyProjection.schema() != keyField.schema()` is true, then the `valueProjection.schema() != valueField.schema()` will also be true.", + "reference": "The previous version didn't use `keyProjection` because the entire key must be projected. If the key is a struct of multiple columns, then projecting a subset of those columns can easily introduce key collisions that aren't in the original data." + }, + { + "prediction": "`spaceId < 0` -> `spaceId == -1`", + "reference": "Why not use StatusOr ? We can't ensure spaceId is greater than zero, especially when AdHocSchemaManager is used." + }, + { + "prediction": "remove empty line", + "reference": "Does it seem we only use that as the json-rpc client? Do we have any other choice? It's a little weird." + }, + { + "prediction": ".ROLE_MENUBUTTON, controlTypes.ROLE_TREEVIEW, controlTypes.ROLE_CHECKMENUITEM, controlTypes.ROLE_RADIOMENUITEM)\n \t\t\tor (role in (controlTypes.ROLE_TABLE, controlTypes.ROLE_TABLECELL, controlTypes.ROLE_TABLEROWHEADER, controlTypes.ROLE_TABLECOLUMNHEADER) and formatConfig[\"reportTables\"])\n \t\t\tor (role in (controlTypes.ROLE_LIST, controlTypes.ROLE_LISTITEM) and not controlTypes.STATE_READONLY in states and formatConfig[\"reportLists\"])\n \t\t\tor (role in (controlTypes.ROLE_FRAME, controlTypes.ROLE_INTERNALFRAME) and formatConfig[\"reportFrames\"])\n```\nReview comment?", + "reference": "Could you split this into multiple lines?" + }, + { + "prediction": "I think we can remove this import as well.", + "reference": "Doesn't the snapshot ID start off as null? It seems like we don't need to set it here." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the right thing to do. If we don't do this, we'll end up appending to the same slice over and over again, which is not what we want.", + "reference": "I wondered why `buffer` was passed into `LookupPath`. What is happening here? Is `buffer[:0]` equivalent to `[]V4TrieEntry{}`, and hence `buffer` isn't needed any more?" + }, + { + "prediction": "I think we can just pass the state view to `NewSignatureValidator` instead of creating a new one here.", + "reference": "nit: Ideally we would would use this abstraction everywhere we need this translation. I believe it's needed in the mining worker and the storage and market connectors." + }, + { + "prediction": "can we add a check here to see if the hash is already set or not. If it is already set then we can skip this step.", + "reference": "need to fix the error message here" + }, + { + "prediction": "Why is this not fixed?", + "reference": "Unsure of how to handle this one." + }, + { + "prediction": "I think this should be `if (isKilled() && !this.flowFinished) {`", + "reference": "Will this.flowFinished verify with every finished state stated in Status.isStatusFinished method? If so, no need to verify isKilled." + }, + { + "prediction": "I don't think we need this type. We can just use `RetryPolicy` directly.", + "reference": "replace \"Child Workflow\" with \"any workflow\"" + }, + { + "prediction": "I think this should be `{{- if or .IsSymlink .IsDir}}`", + "reference": "Instead of showing the words \"symbolic link\" under the \"Size\" column, how about we introduce new icons for symbolic link to file and symbolic link to directory?" + }, + { + "prediction": "I think this should be `@param string $dateRange The range filter query string from the query URL`", + "reference": "Please add back the description of the parameter" + }, + { + "prediction": "Please revert this change.", + "reference": "Superfluous space inserted." + }, + { + "prediction": "`node.ownerSVGElement` will be `null` if `node` is not an SVG element, so we don't need the `!` here.", + "reference": "Didn't fix the problem. `href=\"\"` for SVG will still result in `undefined` getting returned by this function." + }, + { + "prediction": "I think this is a bug in the test. The bearing after should be 58, not 238. The bearing before should be 238, not 58.", + "reference": "This seems like a strange change ... I wouldn't think that a change to access tags in the profiles would result in different bearings in this tests?" + }, + { + "prediction": "I think this should be `isCaret=True`", + "reference": "As isCaret is False by default, explicitly specifying isCaret=False here is not needed, and is perhaps a little confusing. I'd prefer that anywhere in the codebase that isCaret is only ever specified if it needs to be set to true. Mirroring that of isFocus for setNavigatorObject." + }, + { + "prediction": "I think we can remove the `<< Errno::EBADF if Platform.cygwin?` line as well, since `IGNORED_ERRORS` is already frozen.", + "reference": "We can't freeze this and then add something to it in the next line. The `freeze` on line 43 is sufficient. If Rubocop flags this we need to exclude it." + }, + { + "prediction": "I'm not sure this is the right place to sort the subjects. I think it should be done in the `consolidateAutomationPolicies` function.", + "reference": "Why is this needed?" + }, + { + "prediction": "I think it's better to use `reqToken()` instead of `reqTokenAdmin()` here.", + "reference": "Why not put two other routes after this line (221)?" + }, + { + "prediction": "If `FLAGS_meta_server_addrs` is an empty string, `addrs.value().empty()` will be true.", + "reference": "If FLAGS_meta_server_addrs is not empty, in which case \"toHosts\" return empty array?" + }, + { + "prediction": "I think this should be `Settings.JSONBoolWithQuotes = DEFAULT_JSON_USE_QUOTES;`", + "reference": "There is a function to output a \"JSONBool\" string. That would be a good start for finding uses. But maybe just have a look at where we decide whether it is a numerical or not, thus wrapping quotes around its value. Then you have it all I guess." + }, + { + "prediction": "I think this is not correct. `data._kdf._sdf.sample(fraction=float(self.fraction))` returns a new `DataFrame`, so `data._kdf._internal.copy(sdf=sampled, scol=scol)` should be `sampled._internal.copy(sdf=sampled, scol=scol)`.", + "reference": "oops, it should be `data._scol` so that it respects the expression stored in Series. Let me fix it quick." + }, + { + "prediction": "Line is too long. [81/80]
Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Thanks for moving this up with the rest of the variables. Much tidier :)" + }, + { + "prediction": "I think this should be `0.00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "reference": "I think `Rate` is a more precise and concise term for `PaymentPerTime`." + }, + { + "prediction": "I think this should be `if (limit < 0 || limit < posNext)`", + "reference": "I think this should maybe be: var limit = input.IndexOfAny(new[] { '+', '-', ']' }, **posNext**); You pretty much want to ignore any sign that is before the \"M\". But, if there is a sign somewhere before the M, and also after the M, you'd want to be able to find the sign after the M, right?" + }, + { + "prediction": "Please use `ConfigQuery::checkAvailableStock()` instead of `true === ConfigQuery::checkAvailableStock()`", + "reference": "if `checkStockNotEmpty` returns a reponse, you must return it or your script will continue its execution." + }, + { + "prediction": "I think we can just use `klog` here, since we're not using any of the `klogv2` specific functionality.", + "reference": "Any specific reason for this change? klog should work correctly here." + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to work.", + "reference": "we don't mention `last_modified` here?" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "same deal about the global state maybe interfering as in ActionBrowseTagline" + }, + { + "prediction": "I think it would be better to use `Assert.Throws(() => new LruCache(maxCapacity, \"test\"));`", + "reference": "so sweet to see a test as the first thing" + }, + { + "prediction": "I think this should be `strcmp(config->http_proxy, \"\") == 0`", + "reference": "usually when HTTP_PROXY=\"\" (empty), proxy should be disabled. could you set it to NULL when it's empty string?" + }, + { + "prediction": "I think this should be `if ($settings['width'] == null && $settings['height'] == null) {`", + "reference": "Can you throw an exception if width or height are both null" + }, + { + "prediction": "I don't think we need to change this.", + "reference": "This is a breaking change. I guess these might have been intentionally exported." + }, + { + "prediction": "I think we can remove the `TableProperties.METADATA_SPLIT_SIZE` from here.", + "reference": "I don't think this is necessary. When options are used to set the split size in the Spark reader, it uses `TableProperties.SPLIT_SIZE` to pass it here. That should work for metadata tables as well, right? The situation that we need to handle in this PR is setting the default, like you had before. We just want to use a metadata split size so you can set it and not have the same split size used (by default) for both metadata and data scans." + }, + { + "prediction": "I think this should be `*` instead of `\u00d7`", + "reference": "wait a sec, shouldn't this be `'*'`?" + }, + { + "prediction": "I think this should be `varMap[\"compute_service_account\"] = fmt.Sprintf(\"projects/%s/serviceAccounts/%s\", oi.params.ProjectID, oi.params.ComputeServiceAccount)`", + "reference": "It think you'll want the var for GMI import as well: daisy_workflows/ovf_import/create_gmi.wf.json (Unfortunately there's duplication between the two :/ )" + }, + { + "prediction": "I think this should be `self._commands[\"GET_CONTEXT\"] = ('GET', '/session/$sessionId/moz/context')`", + "reference": "Nit: Group this with the other commands by moving it down one line." + }, + { + "prediction": "I think this should be `throw new ParquetDecodingException(\"could not read page in col \" + desc, e);`", + "reference": "I would like to emphasize that a user can use non-vectorized reads to handle this file so maybe something like \"Cannot perform a vectorized read of ParquetV2 File with encoding %s, disable vectorized reading with $param to read this table/file\"" + }, + { + "prediction": "I think this should be `positional=False, default=None, description=\"parameter name used to pass in parameterized value. Defaults to None, meaning use first positional parameter\"`", + "reference": "Maybe add `positional=False`. It does not need it more than the other parameters, but one must start somewhere." + }, + { + "prediction": "I don't think this is correct. `__dirname` is the directory of the file being executed, not the root of the project.", + "reference": "Since we're here, can we use a template?" + }, + { + "prediction": "I think we can remove this now that we're not using it in the Dockerfile.", + "reference": "saw you're also doing this in `test_types.py`: `spark = _spark_context()['test'].resources['spark'].resource_fn(None)` since `_spark_context()` uses `spark_session_local` won't the above break the tests?" + }, + { + "prediction": "I'm not sure I like this change. I think it would be better to keep the `Action: \"allow\"` and change the `Source` to `Selector: \"default == ''\"`. That way we don't have to change the type of the `Action` field.", + "reference": "`has(default)` i think is the preferred way of doing this" + }, + { + "prediction": "I'm not sure this is a good test. It's testing that the constructor works, not that the encoder works. I think it would be better to have a test that actually uses the encoder to do something.", + "reference": "always put a space after a comma" + }, + { + "prediction": "I'm not sure this is the best way to do this. I think it would be better to add a new method to `MediaAdapter` called `selectAllPhotosUpToFav(int position)` and call that here.", + "reference": "@angmas1 move the else up, next to the closing bracket of the if block. Also, there is no need for the braces as your else statement contains only a single line. Make your if-else block similar to the block in lines 277-280." + }, + { + "prediction": "I think we should add `options` to the `__init__` docstring as well.", + "reference": "@AutomatedTester @davehunt thoughts on a new keyword argument?" + }, + { + "prediction": "I don't think we need to change this to `Integer` since we are using `Optional` in the `NodeInfo` class.", + "reference": "This change shouldn't be necessary for this PR. Please remove it." + }, + { + "prediction": "I think we can just use `&framework.NewTestCtx(t)` here.", + "reference": "This variable is mostly unused, how about we make `NewTestCtx` return a pointer?" + }, + { + "prediction": "32 MiB is a lot of data to send in a single request. Is there a reason we can't just send the data in chunks?", + "reference": "What is the basis of this value?" + }, + { + "prediction": "This should be `#include \"gce/gce_metadata.h\"`", + "reference": "Nit: was this extra blank line added intentionally?" + }, + { + "prediction": "I think this should be `STATUS_GUARD_PAGE_VIOLATION` instead of `EXCEPTION_ILLEGAL_INSTRUCTION`.", + "reference": "nit: inconsistent spacing around =" + }, + { + "prediction": "This should be `use Symfony\\Component\\Validator\\ExecutionContextInterface as LegacyExecutionContextInterface;`", + "reference": "We still need this import" + }, + { + "prediction": "I think we can remove the `groupId` parameter from the `rewriteFiles` method in the `BinPackStrategy` class as well.", + "reference": "We are pulling this because we removed \"groupID\" state and put it into the strategy implementations" + }, + { + "prediction": "Please remove this line. It is not needed anymore.", + "reference": "Is this file actually related to PCA?" + }, + { + "prediction": "I think we should keep `isFirstAdmin` as well, since it's used in other places.", + "reference": "See above, this should probably remain `isFirstAdmin`." + }, + { + "prediction": "This is a breaking change, but I don't think it's a big deal.", + "reference": "Why the change to make it public? The expression interface has the `TypeOf` method?" + }, + { + "prediction": "I think this should be `Single_Archive_File_Rolls_Correctly`", + "reference": "don't mind the snake cases in the test names. If there are in the test cases, it's fine IMO" + }, + { + "prediction": "I think it would be better to have a separate DTO for unlocking identity, instead of using `identityRegistrationDto` for this purpose.", + "reference": "`Id` defines REST resource address and should not be in payload" + }, + { + "prediction": "`--class_wise` -> `--class-wise`", + "reference": "We can omit the underscore and just use `classwise`." + }, + { + "prediction": "This should be safe as the root category has to exist for a given context but I do not like fatal errors", + "reference": "Why not throw an exception instead then?" + }, + { + "prediction": "I think we can remove this method now.", + "reference": "Looks like this doesn't need to change. Can you revert this?" + }, + { + "prediction": "I don't think we need to import `template` here, it's only used in the `main` function.", + "reference": "please import it like `from kinto.config import template`" + }, + { + "prediction": "I don't think this change is correct. The default value should be `false`.", + "reference": "There are lots of default value changed, not sure if it break the old behavior." + }, + { + "prediction": "remove empty line", + "reference": "File is not `goimports`-ed (from `goimports`)" + }, + { + "prediction": "`addToStaticNodes` -> `addToStaticNodesList`", + "reference": "parameter should be called removeFromStaticNodes" + }, + { + "prediction": "I think this should be `override: Optional[bool] = False` so that we don't have to pass `override=False` when we don't want to override.", + "reference": "The handler will have an extra property in the marker to signal the implementation is in the provider, for the cases we want to add functionality, for example, custom implementations not in moto." + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.", + "reference": "Is this method actually being used anywhere? If not, I think we should remove it." + }, + { + "prediction": "I don't think this is correct. If the property is read-only, it should not be flattened.", + "reference": "Thanks! I somehow lost this between my far too many branchs." + }, + { + "prediction": "I don't think we need to import `FirefoxWebElement` here.", + "reference": "i think this should get put into its own file. This could start to grow :)" + }, + { + "prediction": "I think this should be `gcr.io/google_containers/pause-amd64:3.0`", + "reference": "Can you add a TODO for loading the tarball of the pause image into Docker?" + }, + { + "prediction": "Why is this removed?", + "reference": "Is there any value in setting the process to null like this?" + }, + { + "prediction": "`softmax_axis_ = this->layer_param_.softmax_param().axis(); outer_num_ = bottom[0]->count(0, softmax_axis_); inner_num_ = bottom[0]->count(softmax_axis_ + 1); CHECK_EQ(outer_num_ * inner_num_, bottom[1]->count()) << \"Number of labels must match number of predictions; \" << \"e.g., if softmax axis == 1 and prediction shape is (N, C, H, W), \" << \"label count (number of labels) must be N*H*W, \" << \"with integer values in {0, 1, ..., C-1}.\"; if (top.size() >= 2) { // softmax output top[1]->ReshapeLike(*bottom[0]);`", + "reference": "This could be a good time to add a check that the prediction and target dimensions (except channel) agree?" + }, + { + "prediction": "I think this should be `else if (instr_get_opcode(bb->instr) == OP_isb && !instr_is_mangled(bb->instr))`", + "reference": "The requirement that OP_isb is bb-final needs to be a rule for clients, just like the rule that syscalls and interrupts must be bb-final: i.e., please add it to the dr_register_bb_event() docs." + }, + { + "prediction": "I don't think this is correct. It should be: `Globalize.translate(\"ListPaging\").replace(\"{0}\", (totalRecordCount ? startIndex + 1 : 0) + \"-\" + recordsEnd).replace(\"{1}\", totalRecordCount);`", + "reference": "The translate library has a method to replace the variables." + }, + { + "prediction": "Can you add a test for `inplace=True` as well?", + "reference": "i don't think this test case is correct. in both cases inpalce=True returns nothing. We need to compare the ks. Also we probably need to make a copy of it. Otherwise you pollute the following \"ks\" because ks has been changed." + }, + { + "prediction": "I think this should be `tls.TlsHandshakeHook` instead of `tls.TlsClienthelloHook`.", + "reference": "Any proposals how to make the naming somehow include the \"completed\" idea of this hook? `TlsHandshakeCompletedHook` or similar? Or using the `...Start/End...` scheme?" + }, + { + "prediction": "Why do we need to flush here?", + "reference": "it introduces a lot of complexity to the state, can we flush straightaway or create a two level flush store where the questions are read form unflushed data?" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but I think we should be able to remove the `urlencode` from the `getUrlFromRouteCache` method as well.", + "reference": "There are two calls to getUrlFromRouteCache, but you're only urlencoding one of them. Is that intentional? Would it make more sense to do the url-encoding inside the getUrlFromRouteCache function?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the `getEditedCell` method.", + "reference": "Maybe we can use `this.instance.getCell` with `topMost` flag to get `TD` element?" + }, + { + "prediction": "Why do we need to log the error here?", + "reference": "Change this to Debug Level" + }, + { + "prediction": "`Aggregate(StackTraceUsage.None, (seed,layout) => seed | (layout?.StackTraceUsage ?? StackTraceUsage.None));` should be `Aggregate(StackTraceUsage.None, (seed,layout) => seed | (layout?.StackTraceUsage ?? StackTraceUsage.None));`", + "reference": "I refactored the Aggregate, those are hard to read" + }, + { + "prediction": "I think we should keep this test, but change it to check that the `iframe` is the error.", + "reference": "This is now done in the after method, so this test won't pass any more." + }, + { + "prediction": "Line is too long. [81/80]
Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "What was the point of creating `user_block` if you're then not going to use it ;-)" + }, + { + "prediction": "I think we can remove this file.", + "reference": "@ueshin, I thought we can remove this entire file. Does that require some more works?" + }, + { + "prediction": "`unicode(tokens.string[1:-1])`", + "reference": "Just `return tokens.string[1:-1]` is enough" + }, + { + "prediction": "Layout/SpaceInsideBlockBraces: Space between { and | missing.
Layout/SpaceInsideBlockBraces: Space missing inside }.", + "reference": "1 trailing blank lines detected." + }, + { + "prediction": "I think this should be `this.setMinWidth(Double.MAX_VALUE);`", + "reference": "Isn't this the default max width? In any case I would prefer to see these definitions in the css files." + }, + { + "prediction": "I'm not sure this is the right thing to do. If TLS is not enabled, but the server is behind a reverse proxy that terminates TLS, then this will redirect to `http://` instead of `https://`. I think we should only set `FromScheme` to `https` if `cfg.TLS.Enabled` and `cfg.TLS.RedirectToHTTPS` are both true.", + "reference": "Is this thread-safe? (If not, and if the solution is to introduce locking, let's reconsider how we do the scheme changing instead...)" + }, + { + "prediction": "I don't think we need to move `Ftrl` to the top of the list.", + "reference": "Looks like this file has tabs instead of spaces." + }, + { + "prediction": "I think this should be `if err := resource.Cleanup(); err != nil {`", + "reference": "Hmm should we clean up container resources before task resources here? or the order does not really matter here?" + }, + { + "prediction": "This line is not needed anymore.", + "reference": "Please undo this :wink:" + }, + { + "prediction": "Align the elements of a hash literal if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "thanks for adding this missing association" + }, + { + "prediction": "I think this should be `app.UseKestrelHttps(new HttpsConnectionFilterOptions { ServerCertificate = cert });`", + "reference": "Should I remove this in favor of the HttpsConnectionFilterOptions overload?" + }, + { + "prediction": "I think this should be `->fetchColumn(0)` instead of `->fetchOne()`.", + "reference": "This shode be nullable, there alway sholud be at least one status in system , if not exist that mean data problme" + }, + { + "prediction": "This is not the right way to do it. You need to add it to the `app.js` file in the `backend/assets/js` folder.", + "reference": "Spaces not tabs" + }, + { + "prediction": "`fs.readdirSync(path, {withFileTypes: true}).map(e => e.name); // From Node v10` -> `fs.readdirSync(path, {withFileTypes: true}).map(e => e.name); // From Node v10` -> `fs.readdirSync(path, {withFileTypes: true}).map(e => e.name); // From Node v10` -> `fs.readdirSync(path, {withFileTypes: true}).map(e => e.name); // From Node v10` -> `fs.readdirSync(path, {withFileTypes: true}).map(e => e.name); // From Node v10` -> `fs.readdirSync(path, {withFileTypes: true}).map(e => e.name); // From Node v10` -> `fs.readdirSync(path, {withFileTypes: true}).map(e => e.name); // From Node v10` -> `fs.readdirSync(path, {withFileTypes: true}).map(e => e.name); // From Node v10` -> `fs.readdirSync(path, {withFileTypes: true}).map(e => e.name); // From Node v10` -> `fs.readdirSync(path, {withFileTypes: true}).", + "reference": "To get the files inside a directory, please use `readDirStats()`." + }, + { + "prediction": "I think this should be `ContainerImplementationDocker` and `ContainerImplementationPlz` instead of `TestContainerDocker` and `TestContainerNone`.", + "reference": "might be worth to call these `Isolation` instead of containers here and when presented to the user -- docker/rkt , in addition to cgroups and namespaces, also provide image discovery and filesystem preparation; there's also the security context and probably 1-2 other small things" + }, + { + "prediction": "this file is empty", + "reference": "File is empty, consider removing?" + }, + { + "prediction": "I think this should be `if url in _load_auth().values():`", + "reference": "This seems to return the registry_url. The more meaningful URL is the catalog URL, which is the URL the user specifies in `quilt3.login`. The username might also be as useful here if not more useful." + }, + { + "prediction": "I think this should be `L1StandardBridgeOwnerAddress` and `L1StandardBridgeAddress` should be `L1StandardBridgeProxyAddress`", + "reference": "Was the addition of `GasPriceOracleAddress` here erroneous?" + }, + { + "prediction": "Align the elements of a hash literal if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "I believe that you are going to have to do some work here to get the env var support for these values to still work correctly, otherwise they will get stored as :department instead of host_tags[:department]." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I could get it to work.", + "reference": "How was this causing the exception?" + }, + { + "prediction": "This should be configurable and not strictly based on locale. #1027 #913", + "reference": "I still have issues with it loading Simplified Chinese by default over Japanese, since they also share characters and we're not sure if characters are different or not. As-is, this fixes Traditional Chinese and Simplified Chinese, but we're not sure if it'd still screw up Japanese text or not. I maintain that, in my opinion, Japanese should be the only script of this kind loaded by default (Because of Hiragana and Katakana, that aren't shared with any other script) and either variant of Chinese should be loaded only in their respective case." + }, + { + "prediction": "I think this should be `visitor.visitLeaf(new IntervalQuery(field, this));`", + "reference": "Isn't it better to stub AtomatonQuery and yield it here. IIRC it resolves simplest MTQ highlighting cases as nobrainer." + }, + { + "prediction": "Metrics/CyclomaticComplexity: Cyclomatic complexity for discount_percentage_vs_current_plan_annualized is too high. [7/6]", + "reference": "Line is too long. [96/80]" + }, + { + "prediction": "I think this should be `kubernetes.io/arch: amd64` or `kubernetes.io/arch: arm64`", + "reference": "My only concern with changing the node selector here is that someone else _could_ have built their own images for other platforms and set them to be used using the flag override on the controller, which in turn this change would break. Perhaps not changing the selector for acmesolver pods makes most sense, and then working on actually having support for Windows? wdyt?" + }, + { + "prediction": "I don't think we need to change this. We can keep the `Object` struct as it is and add a new struct `ObjectWithSelector` which will have `Object` and `Selector` as its fields.", + "reference": "Why do we need interface `InnerObjectWithSelector`, I searched the usage with this field, it seems nowhere use `GetSelectorSpecs()` methods provided by `InnerObjectWithSelector`" + }, + { + "prediction": "I think this should be `InitContext(MsgCtxTypeChannel)` instead of `InitContext(MsgCtxTypeChannel)`", + "reference": "Do we need this `init` here? We have already called the `InitContext` in `StartModule` directly." + }, + { + "prediction": "I think this should be called `minimize_window` to be consistent with the other window methods.", + "reference": "This `if` is not necessary" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the `input` event handler.", + "reference": "should we add a `mangle.json` mapping for this? We could reuse a property name that's only used on component or vnode objects right now, like `__s` (\"next state\")." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Please update the yard docs to indicate this new option." + }, + { + "prediction": "I think this should be `+kubebuilder:validation:MinItems=1` and `+kubebuilder:validation:MaxItems=20`", + "reference": "Can you provide an example in the godoc section on how to use this? From the implementation it looks like the AvailabilityZone field is required for example, otherwise it can fail / error, is that correct?" + }, + { + "prediction": "I'm not sure if we want to store the code version in the migration table. It seems like it would be better to store it in the `config` table.", + "reference": "It would be great if this could be captured by a test." + }, + { + "prediction": "1*time.Second),\n+\t\tESProcessorAckTimeout: dc.GetDurationProperty(dynamicconfig.WorkerESProcessorAckTimeout, 1*time.Minute),\n \t\tESProcessorMaxConcurrentBulk: dc.GetIntProperty(dynamicconfig.WorkerESProcessorMaxConcurrentBulk, 5),\n \t\tESProcessorMaxConcurrentFlush: dc.GetIntProperty(dynamicconfig.WorkerESProcessorMaxConcurrentFlush, 5),\n \t\tESProcessorMaxConcurrentRetry: dc.GetIntProperty(dynamicconfig.WorkerESProcessorMaxConcurrentRetry, 5),\n```\nReview comment?", + "reference": "1000 -> 100 maybe too much, 200 ish to 500ish maybe a good option" + }, + { + "prediction": "Why is this change necessary?", + "reference": "Any reason we need to keep this package's `ChecksumAddress` type or can we get rid of it too?" + }, + { + "prediction": "I don't think this is correct. Restart is a button, not a header.", + "reference": "Above the one that was picked was the Button* prefix, and here it's the Header* prefix. Maybe the Button prefix is more general." + }, + { + "prediction": "I think this should be `BestSuggestedHeader?.Hash ?? Head?.Hash`", + "reference": "I might prefer changing: public Block FindPendingBlock() => FindBlock(PendingHash, BlockTreeLookupOptions.None); public BlockHeader FindPendingHeader() => FindHeader(PendingHash, BlockTreeLookupOptions.None); in IBlockFinder, what do you think?" + }, + { + "prediction": "I think this should be `// +kubebuilder:pruning:PreserveUnknownFields=true`", + "reference": "This is necessary due to a bug in 4.7. Follow HIVE-1561 for getting rid of it." + }, + { + "prediction": "Style/SymbolArray: Use %i or %I for an array of symbols.", + "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." + }, + { + "prediction": "I don't think we need to include xkbcommon here.", + "reference": "Some day (tm) I will also get rid of that one. But today is not that day..." + }, + { + "prediction": "I think this should be `if (substr($localPath, -1) !== '/') { $localPath = $localPath.'/'; }`", + "reference": "Add a space between if and opening parenthesis please (i.e. `if (`)" + }, + { + "prediction": "I think we can remove the `if index is None` check and just do `scol = self._scol.alias(index)`.", + "reference": "nit: `rename` instead of `alias`?" + }, + { + "prediction": "I'm not sure if this is the right thing to do. I think we need to make sure that the root device is always mounted at `/dev/sda1`. If we skip this, then the root device will be mounted at `/dev/sdb1` which is not what we want.", + "reference": "Per AWS docs EC instances have the root mounted at /dev/sda1. This label should be skipped." + }, + { + "prediction": "Why is this removed?", + "reference": "I'm not sure it is a better way to address lose message, if wait here, edge controller cant process message, event from watching api-server will be lost yet, right?" + }, + { + "prediction": "I don't think you need the `if p.len is not None and p.value_size is not None else 0` part. If `p.len` or `p.value_size` is `None` then `p.len - p.value_size - 6` will be `None` anyway.", + "reference": "Please keep the correct alignment, it seems broken now (at least in Github). Can you reverse the test (`if p.value_size is None`)? Also, do you want `6` when `p.value_size is None` or `x + 6`? Maybe, in that case, something like `lambda p, x: x + 6 + (0 if p.value_size is None else p.value_size)` would be easier to read. Or even easier: `lambda p, x: x + 6 + (p.value_size or 0)`." + }, + { + "prediction": "I think this should be `type:\"integer\" min:\"1\" max:\"2147483647\"`", + "reference": "Can we make sure ECS service treats it as int64 as well?" + }, + { + "prediction": "This should be `super(ReadOnlyEditBox, self)._get_windowText`", + "reference": "Please follow the naming convention for variables, i.e. `windowText`." + }, + { + "prediction": "This import is not required anymore.", + "reference": "alias can be `cast`" + }, + { + "prediction": "`mmap_errors` should be a `uint64_t` as well.", + "reference": "Let's use `%zu` instead of casting to `uint64_t` and using `PRIu64`. The alternative is to change the type of `mmap_errors` to `uint64_t`, though I'd prefer not doing that because some 32-bit platforms might not provide atomic operation support for `uint64_t`." + }, + { + "prediction": "I think we should keep this as `SUGGESTION` since it's not an error, just a suggestion.", + "reference": "I recall there being a reason we had this one set only to suggeation. @carterkozak do you remember why? or is my memory getting corrupted?" + }, + { + "prediction": "I think this should be `it->first` instead of `it->second`.", + "reference": "This should now be made into `if (it->second.empty())` ?" + }, + { + "prediction": "I think this should be `if self.num_of_searches == 0:`", + "reference": "Do we need to worry about a race condition on this decrement (@The-Compiler)? I'm not sure how the python callbacks work, so this might not need to be something to worry about." + }, + { + "prediction": "I think this should be `sc := trace.SpanContextFromContext(ctx)`", + "reference": "Should these assert that the extracted `SpanContext` is remote?" + }, + { + "prediction": "This is usually allowed for RPN and single stage detectors, but not allowed in the second stage. -> This is usually allowed for RPN and single-stage detectors, but not allowed in the second stage.", + "reference": "typo: allow low quality matches." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should be passing the `Config` object to the `StartServer` function, not the `cmds.Server` object. The `Config` object has all the information we need to start the server, and the `cmds.Server` object has all the information we need to start the CLI. I think we should be passing the `Config` object to the `StartServer` function, and the `cmds.Server` object to the `StartCLI` function. That way, we can start the server and the CLI in the same process, and we can start the server and the CLI in different processes.", + "reference": "At some point we need to condense down and refactor our \"configs\" as we have too many in too many places and we're starting to get more illegible code. No change necessary but calling out for future reference." + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.", + "reference": "Can we add the `if label` conditional to this please?" + }, + { + "prediction": "I think this should be `mlflow>=1.0.0,<2.0.0`", + "reference": "@thunterdb, can we increase the minimal version to almost the latest ones? I was thinking people will mostly use the latest version of mlflow" + }, + { + "prediction": "I think it would be better to call this `isFillDataChanged` or something like that. `hasFillDataChanged` sounds like it's a boolean, but it's not.", + "reference": "If the last argument is going to be removed, why would we add it to the API docs? Shouldn't it be private for internal use?" + }, + { + "prediction": "I think we should move this to `dagster/core/execution/intermediates_manager.py`", + "reference": "`Intermediates` or `Intermediate`" + }, + { + "prediction": "I don't think this is a good idea to raise an exception in this case. If you want to check if an element is present, you should use `presence_of_element_located` or `presence_of_all_elements_located`. If you want to check if an element is visible, you should use `visibility_of_element_located` or `visibility_of_all_elements_located`. If you want to check if an element is not visible, you should use `invisibility_of_element_located` or `invisibility_of_all_elements_located`. If you want to check if an element is stale, you should use `staleness_of` or `staleness_of_all_elements_located`. If you want to check if an element is not stale, you should use `staleness_of` or `staleness_of_all_elements_located`. If you want to check if an element is not stale, you should use `staleness_of` or `staleness_of_all_elements_located`. If you want to check if an element is not stale, you should use `staleness_of` or `staleness_of_all_elements_located`. If you want to check if an element is not stale, you should use `staleness", + "reference": "This is not the right exception class. There is an InvalidSelectorException class that covers bad locators." + }, + { + "prediction": "I'm not sure this is the right thing to do. If we're bootstrapping, we want to make sure that we have the latest data. If we're not bootstrapping, we want to make sure that we have the latest data. If we're not bootstrapping, we want to make sure that we have the latest data. If we're not bootstrapping, we want to make sure that we have the latest data. If we're not bootstrapping, we want to make sure that we have the latest data. If we're not bootstrapping, we want to make sure that we have the latest data. If we're not bootstrapping, we want to make sure that we have the latest data. If we're not bootstrapping, we want to make sure that we have the latest data. If we're not bootstrapping, we want to make sure that we have the latest data. If we're not bootstrapping, we want to make sure that we have the latest data. If we're not bootstrapping, we want to make sure that we have the latest data. If we're not bootstrapping, we want to make sure that we have the latest data. If we're not boot", + "reference": "If this code isn't needed, it should be removed." + }, + { + "prediction": "I'm not sure this is the right thing to do. If the connection is stopped, we should not retry. We should just return the error and let the caller decide what to do with it.", + "reference": "Should the `doRequest` func be a method on the `connection` type instead of passing state from the type?" + }, + { + "prediction": "I'm not sure if we want to change the environment variable name here. I think we should keep it as `ECS_CLI_ENVIRONMENT_NAME` for now. We can change it later if we want to.", + "reference": "we'll probably tackle these e2e tests at the end" + }, + { + "prediction": "I think it would be good to add a test for `Dns.GetHostEntryAsync` as well.", + "reference": "what is this address pointing to? what are we measuring here? I want to have a better understanding." + }, + { + "prediction": "Should this be 4 instead of 3?", + "reference": "Would it be better to pass the dependency status as the parameter into the SQL string? In case the enum value is changed in the future, we don't need to change the code here." + }, + { + "prediction": "I don't think this is needed.", + "reference": "Hah I had `gorename` failing without this too." + }, + { + "prediction": "I think it would be better to use `Security.Instance.DdlibWafVersion?.ToString() ?? \"(none)\"` instead of `Security.Instance.DdlibWafVersion?.ToString() ?? \"(none)\"`", + "reference": "maybe prefix these with `appsec_` for consistency?" + }, + { + "prediction": "I'm not sure if we want to enable this by default. It seems like it could be useful for debugging, but I'm not sure if we want to enable it by default.", + "reference": "nit: this should be down further with the other github imports" + }, + { + "prediction": "I think this should be done before `updateCheck.initialize()`. Otherwise, if the update check fails, NVDA will still be connected to the parent console.", + "reference": "Why is this change necessary or related to the rest of the PR?" + }, + { + "prediction": "I think this should be `'- see: ' . $issue_data->link` instead of `' - see: ' . $issue_data->link`", + "reference": "Hm, I wonder if the `see:` prefix is even necessary?" + }, + { + "prediction": "This should be `remainingMinutes = Math.round(remainingMinutes);`", + "reference": "This should be translated." + }, + { + "prediction": "I don't think we need to check `num_class` and `boosting` and `metric` here, because they are not used in `Booster::ResetConfig`.", + "reference": "I originally had this PR only changing the R package, but then ran into this error > Error: [LightGBM] [Fatal] Cannot change metric during training This is thrown even if you aren't actually CHANGING `metric`. I think the change here in `c_api` is closer to the desired behavior, only throwing an error if the parameter is being changed." + }, + { + "prediction": "I'm not sure why this was changed, but I think it's better to keep it as it was before.", + "reference": "These changes are just to make cli_spec a little more readable for VS Code users, as there's a bug with the Ruby plugin's syntax highlighting when you use multi-line regex literals." + }, + { + "prediction": "I'm not sure this is the right thing to do. The global pull secret should be in the same namespace as the cluster deployment, not in the hive namespace.", + "reference": "Shouldn't the global pull secret by in the namespace of the hive-operator? It is part of the operand." + }, + { + "prediction": "I think we should use `time.sleep(1)` instead of `sleep(1)`.", + "reference": "kinesis-mock applies KINESIS_LATENCY to RegisterStreamConsumer actions so I added a sleep here." + }, + { + "prediction": "Can't upgrade meta from V1 to V3 -> Can't upgrade meta from V1 to V2 -> Can't upgrade meta from V2 to V3", + "reference": "Only V1 or V3 is return from `getMetaVersionFromKV`. So where do we call `updateMetaV2ToV3`?" + }, + { + "prediction": "I think this should be `return []catalog.Version{nodeAttestorV0{}, nodeAttestorV1{}}`", + "reference": "I think that V0 is missing here, which will prevent plugins that haven't been converted to work." + }, + { + "prediction": "I don't think we need this anymore.", + "reference": "Should we remove this?" + }, + { + "prediction": "Please remove this empty line.", + "reference": "Put on top of the import." + }, + { + "prediction": "I think this should be \"Google Analytics\"", + "reference": "See above, this shouldn't be added." + }, + { + "prediction": "I think this should be `ITEM_AMULET_OF_FURY` and `ITEM_FURY_ORNAMENT_KIT`", + "reference": "This'll likely get fixed upstream, we should let them deal with it." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `New` function of the `host` package. The `New` function of the `Service` package should not know anything about the `host` package.", + "reference": "Somehow, this field does not seems useful for the exposed package api, only for the tests. Would you consider having an unexported field in `hostFactory func(context.Context, ...libp2p.Option) (host.Host, error)` instead to be set only by a new helper function defined in export_test.go. This is just a suggestion, not a hard requirement for the PR approval." + }, + { + "prediction": "I think this should be `moment().startOf(timeDuration).add(n, timeDuration).format('x')`", + "reference": "As a first argument to these function, please pass the date that should go forward/backward. Also please clarify what is \"n\" (possible values, unit) and what is timeDuration (possible values, unit, as from your code it seems to be \"day\", \"hours\", etc. but from your example it seems to be milliseconds)." + }, + { + "prediction": "I don't think this is necessary. `setLanguage` is called in `__init__` of `appModuleHandler.py`, so it should already be set to the user's language.", + "reference": "Are you sure you really need this code here? that script will be certainly run in NVDA's main thread, and core would have already called setLanguage." + }, + { + "prediction": "Why do you change the port number here?", + "reference": "why is this changed ?" + }, + { + "prediction": "I think this is fixed now.", + "reference": "Should this be \"the new revision value\"?" + }, + { + "prediction": "`Dette feltet m\u00e5 aksepteres n\u00e5r :other er :value.` -> `Dette feltet m\u00e5 aksepteres n\u00e5r :other er lik :value.`", + "reference": "You have deleted :attribute" + }, + { + "prediction": "I think it's better to keep the original license header.", + "reference": "The license header should be updated to the Apache one." + }, + { + "prediction": "I think we can remove the `expectedOperationName` and `expectedServiceName` since they are not used in this test.", + "reference": "@zacharycmontoya Is there any way to distinguish a `SocketHttpHandler` from another `HttpMessageHandler` request?" + }, + { + "prediction": "I don't think we need these.", + "reference": "Not sure about this one -- did you check somehow?" + }, + { + "prediction": "Style/TrailingWhitespace: Trailing whitespace detected.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/Space", + "reference": "Is there a good reason to keep this at the `pe_ver_win` name now that it's per-host?" + }, + { + "prediction": "I don't think this is necessary. The `SummaryProductFragment` is created in the `onCreateView` method of the `SummaryProductFragment` class.", + "reference": "Not in the order of display : Front, Ingredient, Nutrition here (which is the right thing), Actually displayed: Front, Nutrition, Ingredients" + }, + { + "prediction": "why remove this field?", + "reference": "Why delete `StartTime`? This `StartTime` was used to avoid the PID was reused." + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.", + "reference": "My concern here, is that if the dump_puppet_log also throws then we will lose the data about the teardown_exception." + }, + { + "prediction": "Why do we need to cast to `size_t` here?", + "reference": "Should it be `int64_t`?" + }, + { + "prediction": "I think this should be 10 minutes. 5 minutes is way too short.", + "reference": "is this value related to something ?" + }, + { + "prediction": "I think it's better to return `AddTxResult` instead of `AddTxResult?`", + "reference": "Add names to tuple elements ValueTask<(Keccak? Hash, AddTxResult? AddResult)>, should they both be nullable?" + }, + { + "prediction": "I think this should be `namePiece = replaceAcronyms(namePiece);`", + "reference": "I think it might make more sense to do this in Name.upperCamel; it is the entry point for upper camel strings." + }, + { + "prediction": "Why is this cast necessary?", + "reference": "Huh? The point is that a cast isn't necessary" + }, + { + "prediction": "I think this should be `OPENEBS_IO_INSTALL_CRDS` to be consistent with `OPENEBS_IO_CREATE_DEFAULT_STORAGE_CONFIG` and `OPENEBS_IO_CREATE_DEFAULT_STORAGE_CLASS`", + "reference": "can we name it like `InstallV1Alpha1CRDs` ?" + }, + { + "prediction": "I think this should be `hive.openshift.io/hiveutil-created`", + "reference": "I need something to match when creating selectorsyncsets so added this label." + }, + { + "prediction": "Metrics/BlockNesting: Avoid more than 3 levels of block nesting.", + "reference": "Isn't `nil` the default return value from an empty `rescue` clause? If that's correct, then we could just remove the `nil` line entirely as it doesn't serve a purpose." + }, + { + "prediction": "You can remove the `# snippet-start:[s3.s3_ruby_bucket_cors.rb]` and `# snippet-end:[s3.s3_ruby_bucket_cors.rb]` lines.", + "reference": "Simple Storage **Service**" + }, + { + "prediction": "I think this should be `r.idx.Obsolete().Sub(validIndex)`", + "reference": "Wouldn't that cause the obsolete indexes to be downloaded over and over again? After all these are still stored in the repository." + }, + { + "prediction": "Align the elements of a hash literal if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "We might want to move this logic to a Plain Old Ruby Object down the road. Not a blocker." + }, + { + "prediction": "I think we can just remove this line.", + "reference": "move `this.toolbox_.position();` to just after line 1477. Context: the if statement on line 1472 checks whether this is a toolbox with categories, and if so it populates the toolbox. Positioning the toolbox is a reasonable followup to that, and means you don't need an extra if. You may also need to call `this.flyout_.position()` after line 1483, which is the equivalent for the non-category toolbox." + }, + { + "prediction": "I don't think this is necessary.", + "reference": "Should the function above be .FirstOrDefault() instead? Otherwise, why check for null and tell ReSharper to ignore the fact that it can never be null?" + }, + { + "prediction": "I don't think we should be using `plugins.dbConnection()` here. We should be using `countlyDb` from the `countly.js` file.", + "reference": "Let's not create new connection, but rather user `common.db` one" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it works for now.", + "reference": "Can this use asset_path rather than defining an image_url helper?" + }, + { + "prediction": "I think it should be `... -> String` instead of `... -> ''`", + "reference": "Hindley-Milner signatures don't use literal types. They explusively use types. It's deal with that" + }, + { + "prediction": "I think we can remove this struct and use `PolicyRule` directly.", + "reference": "Could we just extend PolicyRule with more fields? It was originally designed as the struct required by openflow client, nested structs seem not helping. And for the name of the fields, initialism should be uppercase, OFID and NPName doesn't look good, then maybe FlowID, PolicyName.." + }, + { + "prediction": "Please remove the trailing whitespace.", + "reference": "I really dislike this alignment approach, as it makes identifying individual functions quite hard, but I kept consistent with the previous style. Since no sorting was evident, I pushed it to the end of the block. Meanwhile, is this supposed to be tested or meaningfully testable somehow?" + }, + { + "prediction": "I think this is a bit confusing. I think it would be better to say that `get_steps_to_execute` updates the state of `ActiveExecution`, and without it, `is_complete` can return `True` when we're just between steps.", + "reference": "Could also consider modifying the ActiveExecution..." + }, + { + "prediction": "I think it would be better to raise a `ValueError` here.", + "reference": "Does it make sense to change that to a custom error instead of `ValueError`?" + }, + { + "prediction": "I think this should be `blk.TicketCount`", + "reference": "I guess this will need to change soon." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the right thing to do. If we don't have a `map` directive, then we don't need to do anything. If we do have a `map` directive, then we need to do the `map` before we do anything else.", + "reference": "Restore this spacing - not sure why it has to be removed?" + }, + { + "prediction": "I'm not sure if this is the right place to set these defines, but it seems to be the only way to get `fseeko()` and `stat()` to work on Windows.", + "reference": "These defines cause issues in base.h leading to failing android builds. Locale independency is now set in multiple spots, in cmake and in base.h. The base.h uses feature test macros wrong. Feature test macros can be used to indicate that a feature should be made available. They do not guarantee that it is available. On the cmake side this is done by the check symbol macros (similar to what autoconf does). On the android side not. I would suggest removing this from base.h and define locale independent in gradle. It is available since android 21 I believe. Is there a way in gradle to set locale independent only if android api >= 21?" + }, + { + "prediction": "`loopBody != getDst` -> `loopBody != getDst && !joinInput && !joinDst`", + "reference": "Why not delete these codes?" + }, + { + "prediction": "why not use `FLAGS_meta_client_retry_times` in `MetaClient::waitForMetadReady`?", + "reference": "If pull message failed after some reties, we should ensure the storaged exit, otherwise it has risk to loss data." + }, + { + "prediction": "`first` and `count` are not used in this file.", + "reference": "looks like you don't need to import first and count here anymore" + }, + { + "prediction": "can we remove this?", + "reference": "FYI, visibility task processing is local only, meaning pushing something to local ES cluster / local archival endpoint" + }, + { + "prediction": "This import is not used.", + "reference": "This import can be removed." + }, + { + "prediction": "I think this should be `strings.HasPrefix(a.Region, \"fips-\") || strings.HasSuffix(a.Region, \"-fips\") || a.Region == \"fips\"`", + "reference": "1. Nit: We can have a general helper to identify if a region is pseudo region. We might already have one somewhere. 2. Does any type of ARN support FIPS? If not, we may just move this check in arn package?" + }, + { + "prediction": "I think we can remove this exception now that we have stubbers for all of the services.", + "reference": "is this phrase completed in a next line? Or forgot to add... what?" + }, + { + "prediction": "Please remove this file.", + "reference": "`('train', 5)` and `('train', 1)` are actually the same." + }, + { + "prediction": "I think it would be better to rename this function to `getLimitInfoFloat64` to make it clear that it returns a float64.", + "reference": "Would it be too complicated to refactor `currLimit` to be an `int64`?" + }, + { + "prediction": "Style/MethodCallWithArgsParentheses: Avoid parentheses around arguments of method calls.", + "reference": "Would it be more performant to just `include ::RSpec::Core::Pending` here? /cc @myronmarston" + }, + { + "prediction": "I think it's better to use `[]string` instead of `map[string]int64`.", + "reference": "Should be podiochaos?" + }, + { + "prediction": "This is a temporary fix for #8599 and #7105. Once we upgrade to Python 3, this will no longer be necessary.", + "reference": "Is the `codecs.register(lambda name: None)` gracefully handled by codecs? The lambda is expected to return a tuple of functions (encoder, decoder, stream_reader, stream_writer) (or a CodecInfo object), according to the docs. I've only checked python's built-in help, though." + }, + { + "prediction": "I think it would be better to throw an exception here, so that the user is aware of the issue and can fix it.", + "reference": "in this case, it could be either instrument name or the view name, which could be invalid. might be better if we can offer very specific message. (not blocking this, we can add this as a follow up,if needed)" + }, + { + "prediction": "I think this should be `nameOrHandle` instead of `paramName` to be consistent with the rest of the code.", + "reference": "I'd rather just send the parameter twice than break encapsulation here. There's already precedence with webelement IDs" + }, + { + "prediction": "Please use `pretrained` instead of `pretrained= # NOQA`", + "reference": "You may put 'open-mmlab://res2net101_v1d_26w_4s' here. MMCV will be updated later." + }, + { + "prediction": "I think it would be better to have these constants in the `pagespeed-insights.js` file, since they are only used there.", + "reference": "May be worth making this more specific, to avoid potential conflicts, maybe `pagespeedDashboardWidget`? Or `webVitalsDashboardWidget`?" + }, + { + "prediction": "I'm not sure if this is the right thing to do. I think we should keep the original error message, but add our own message at the end. Something like: `Failed because: ${err.message} (AWS S3 multipart upload failed)`", + "reference": "I guess this assignment is now redundant?" + }, + { + "prediction": "I'm not sure this is the right thing to do. If the block number isn't available, we should just return an empty block number and let the caller figure out what to do with it.", + "reference": "See above note re: blockNum synchronization." + }, + { + "prediction": "I think we can remove this import now that we're using `spire_backoff` everywhere.", + "reference": "wonder if we could avoid doing named imports if we type aliased `backoff.Backoff` in the `.../agent/common/backoff` package?" + }, + { + "prediction": "nit: remove empty line", + "reference": "Or maybe put into alphabetical order with the other #includes." + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "This runs the entire duration of the program; this change is not needed." + }, + { + "prediction": "Why do we need this?", + "reference": "I don't feel well about the `ALWAYS_UPDATE` option   sounds like a workaround. I can imagine that some of the plugins want to observe all options. Maybe, in that case, we can reuse the `CONFIG_KEYS` that would return an empty array for observing all settings and `false` for disabling observing at all? I just thinking aloud - Like `CONFIG_KEYS` sounds reasonable. We could support and maintain it in the future, even after implementing the \"observability\" to the MetaManager then `ALWAYS_UPDATE` ... I don't know :)" + }, + { + "prediction": "I don't think this is a clang-format bug, it's just that clang-format doesn't understand the `#ifndef ASM_CODE_ONLY` preprocessor directive, so it doesn't know where the C code ends and the assembly code begins. So it formats the assembly code as if it were C code.", + "reference": "A \"tab difference\"? As in, there are tab characters somewhere? This disabling of clang-format for all the code here seems like overkill. Are you sure there's not some other solution? I don't really understand the problem though. Do you mean clang-format-diff?" + }, + { + "prediction": "I'm not sure about this change. I think it's better to keep the old imports and add the new ones.", + "reference": "Could you please leave the explicit imports?" + }, + { + "prediction": "I think we should throw an error here, because it means that the user has specified a method in the config that doesn't exist in the proto file.", + "reference": "Can we check for containsKey here?" + }, + { + "prediction": "I think this should be `case len(os.Args) == 2 && (os.Args[1] == \"help\" || os.Args[1] == \"-h\" || os.Args[1] == \"-help\" || os.Args[1] == \"--help\"):`", + "reference": "Exit successfully. We served the help the user wanted." + }, + { + "prediction": "I think this should be `InitialWorkingDirectory` to be consistent with the rest of the codebase.", + "reference": "Had to rename this because `InitialPackage()` already existed." + }, + { + "prediction": "I think we can just use `ENV['GSA18F_APPROVER_EMAIL'] = 'test_approver@some-dot-gov.gov'` here and not need the `old_approver_email` variable.", + "reference": "Can we put this in a different helper?" + }, + { + "prediction": "nit: extra space after `cci->num_regs_skip != 0 ||`", + "reference": "I'm not sure where your 31 comes from? I see 15 here and 2 above for pc and flags, for 17 total beyond the SIMD." + }, + { + "prediction": "This should be `@GET @Path(\"apiTermsOfUse\") public Response getTermsOfUse() { return response( req -> ok(systemConfig.getApiTermsOfUse())); }`", + "reference": "If you want, you could change this to `allowCors(response` (like in \"version\", above) to allow Cross-Origin Resource Sharing. I'm sort of wondering what's returned if no API terms of use are set." + }, + { + "prediction": "I don't think this is necessary.", + "reference": "Why do we need to override this if all we're doing is passing it up?" + }, + { + "prediction": "I think this should be FALSE, FALSE, FALSE.", + "reference": "Just wondering whether it's safe to send all CQDs to the child compiler. As this missing CQD is causing trouble, maybe some other user CQDs that now get sent could also cause the statement to fail? Also, if I have a table with a nullable unique column, should I have to set this CQD to create another table like it, or should the CREATE TABLE LIKE work without the CQD?" + }, + { + "prediction": "I think this should be `DAGSTER_EARLIEST_RELEASE = packaging.version.parse(\"0.12.4\")` so that we can use `DAGSTER_EARLIEST_RELEASE > packaging.version.parse(\"0.12.4\")` later on.", + "reference": "EARLIEST_TESTED_RELEASE might be slightly more clear" + }, + { + "prediction": "I don't think this change is correct. The `.*` at the start of the regex will match the entire line, which is not what we want. The `.*` at the end of the regex will match the entire line, which is also not what we want.", + "reference": "I think replacing `.*` with `\\s*` from after the hash makes sense, but not the rest of the changes." + }, + { + "prediction": "I think this should be `omitempty` so that we don't store the default value in the API object.", + "reference": "interesting .. did not know varint tag covered bool as well" + }, + { + "prediction": "I think this should be a `struct gkc_summary` as well.", + "reference": "Could you please elaborate the reason for not using `gkc_summary` like the values above? I ask this, because I assume what we want to collect is a histogram of event loop latency, and we use `gkc_summary` for collecting histograms." + }, + { + "prediction": "I think this should be `this.txs[t].getHash()`", + "reference": "getHash should be a public and without an `_` if used here." + }, + { + "prediction": "Why do we need this?", + "reference": "Unrelated to these changes -- we will probably want some special handling for genesis block validation." + }, + { + "prediction": "I think this should be `DiskBlockCacheFractionSetter` to be consistent with the other interfaces in this file.", + "reference": "This is probably overkill since we don't actually need to pass this specific interface anywhere, but I don't mind it!" + }, + { + "prediction": "Why do we need to add the peer to `receivedPeers` here?", + "reference": "@janos I moved this back here, to avoid having multiple add peer calls being handled. I think it's either this or a global lock across the whole function. I think this is a better approach, especially since `hive.Broadcast` is blocking . We can remove the map entry on errors if needed. LMKWYT?" + }, + { + "prediction": "Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
", + "reference": "Minor: can we put the conditional outside of the partial?" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "We need to find something more efficient than this. We can probably just check the first element and assume the type list is consistent.." + }, + { + "prediction": "I think this should be `A %s is a task which can be programmatically run, either on a schedule or via service code in response to events.`", + "reference": "How \" via service code in response to event.\"? I don't think we'll get in the no schedule option to the release. We should probably wait for some customer feedback first to make sure we're addressing different event-triggers the best way" + }, + { + "prediction": "Please revert this change.", + "reference": "Please move unrelated formatting changes to their own PR (same with the resources.py file)." + }, + { + "prediction": "I think this should be `window._state_before_fullscreen = window.windowState() & ~Qt.WindowFullScreen`", + "reference": "Make this a public attribute (remove the leading `_`) if you want to access it from the outside." + }, + { + "prediction": "This should be `if (browser && !browser.firefox) {`", + "reference": "this conditional is useless now so it should be removed" + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to be the only way to make the compiler happy.", + "reference": "`vecofstructs->size()` already returns a `uoffset_t`. So if you just change the type of `i`, you don't need any casts." + }, + { + "prediction": "I think it would be better to make this configurable via the `gapic-generator-config.yaml` file, so that we don't have to add a new command-line flag.", + "reference": "Nit: Maybe merge this with the configProto check on line 208? Don't feel that strongly though, please keep separate if you prefer." + }, + { + "prediction": "I don't think we need to check for `doc.hello` here. `doc.ismaster` should be enough.", + "reference": "I know we already did this in 4.0 so carry on, but I'm facepalming here we should've made an overrided setMessageHandler that sets ismaster to true when hello is present. Esp in 4.0 where we already have some overrides written. We can keep going here and maybe open a ticket to some effect of that solution" + }, + { + "prediction": "I think this should be `Skip to main content`", + "reference": "I believe we could use `link_to` here (although not super important). Also, we should internationalize this value. I'm not 100% sure what our process is for adding new UI strings these days (e.g. skip the specs that will fail if we add a new key to only one language, use Google Translate to translate the value for us, some other option)." + }, + { + "prediction": "This is not correct. If `result == VK_INCOMPLETE` then `*pPropertyCount` is the number of properties that were returned, not the total number of properties.", + "reference": "This was already in vkGetPhysicalDeviceDisplayProperties2KHR..." + }, + { + "prediction": "I think this should be `DockerEngineValidator` to be consistent with the rest of the codebase.", + "reference": "nit: I'd expect a public method called IsDockerEngineRunning to return a boolean yes/no, not the error message. Can we change either the return value or the name? Something like `CallDockerEngine`" + }, + { + "prediction": "I think this is too long for a type name. Can we keep it at 512?", + "reference": "If i remembered correctly, type_name is '{RESOURCE_TYPE}/{RESOURCE_NAME}', if type_name is 700 max then name cannot exceed that size" + }, + { + "prediction": "I think this should be `GetBufferIdentifier(buf, offset, size_prefixed) == file_identifier`", + "reference": "When calling functions with keyword arguments: please provide the arguments as keyword arguments, not positional arguments." + }, + { + "prediction": "`act_cfg` -> `act_cfg_`", + "reference": "We may follow the argument order: conv_cfg, norm_cfg, act_cfg." + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "`options['binary'] = WebDriver::Chrome.path` if set?" + }, + { + "prediction": "I think this should be `#include ` instead of `#include `.", + "reference": "folly library should be put on the top." + }, + { + "prediction": "I don't think this is correct. `name` should be `name.replace(/^xlink:?/, '')`.", + "reference": "Do we have to restrict this to SVG elements? I think setting namespaced attributes on normal dom elements (while not as common) is still valid, so perhaps we can save some bytes by removing the `isSvg` check?" + }, + { + "prediction": "I don't think this is correct. The `hiddenRow` hook is called with the logical row index, not the physical one.", + "reference": "Please add it to the `REMOVED_HOOKS` constant." + }, + { + "prediction": "I think we can remove this line.", + "reference": "This variable needs `.v1` at the end of it, or the tests below need it. There are some test failures as a result" + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
", + "reference": "Is this access protected so that only admins can access this route?" + }, + { + "prediction": "I don't think this change is correct. `min_x`, `min_y` and `min_distance` should be initialized to `DBL_MAX`.", + "reference": "What happens if the minimum x coord is > 0? This will incorrectly set it as zero, right?" + }, + { + "prediction": "I think this should be `if o.maxp > 0 && batchSize > o.maxp {`", + "reference": "I think you want to look at current pending + batchSize and if that is > o.maxp no?" + }, + { + "prediction": "I think this should be `span.SetStatus(codes.Error, \"internal\")`", + "reference": "Should this be `codes.Error`? `codes.Internal` was an error status before." + }, + { + "prediction": "Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "I don't think you need these lines." + }, + { + "prediction": "I think this should be `DiskLimiter`, not `diskLimiter`.", + "reference": "You didn't mean to export this, right?" + }, + { + "prediction": "I think this should be `sns-ruby-example-show-topics.rb demonstrates how to list Amazon Simple Notification Services (SNS) topics using the AWS SDK for Ruby.`", + "reference": "Simple Notification **Service** (singular)" + }, + { + "prediction": "I think this should be `egressConfig *config.EgressConfig` instead of `egressConfig *config.EgressConfig`", + "reference": "Do we still need this?" + }, + { + "prediction": "This is a debug statement that was left in by accident.", + "reference": "We do have a disconnect between the privateMarkerTransactionFactory.getSender() call and the createPrivateMarkerTransaction() call. When the plugin receives the call to create the PMT it does not know what the sender was returned by the other call. At a minimum we need to pass in the sender to the second call. I would prefer that the plugin does the locking if that is necessary. If you are using random keys you don't have to lock! Besu could signal to the plugin when a PMT was un- or successfully added to the pool using a callback. Callback could be null if this is not needed. The plugin would have to be able to get the nonce for a certain key from besu. What do you think?" + }, + { + "prediction": "I don't think this is the right translation key. I think it should be `MessageDefaultError` and not `MessageDefaultErrorMessage`.", + "reference": "This is a bit inconsistent with the `ErrorStartHourGreaterThanEnd` in the previous file. Wouldn't `ErrorDefault``fit better here?" + }, + { + "prediction": "I think it's better to keep `skipIfNetworkPolicyStatsDisabled` in `networkpolicy_stats_test.go` and `skipIfNetworkPolicyStatsEnabled` in `networkpolicy_test.go`.", + "reference": "I think it will revert the change @antoninbas did on purpose 05eee251c9c53400277def576f92d614ca234898" + }, + { + "prediction": "I think this should be `if strings.HasPrefix(ifaceName, \"wireguard.\")`", + "reference": "nit: a switch perhaps?" + }, + { + "prediction": "Line is too long. [81/80]
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or", + "reference": "Would it make sense for `opensearch_description_tag` to have default values for the title and href attributes?" + }, + { + "prediction": "I think this should be `if err != nil && err != errTLFJournalDisabled && err != io.EOF {`", + "reference": "Just noticed this while debugging -- it's unlikely to be causing issues in practice." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to be the only way to get the test to pass.", + "reference": "That seems unrelated - did that fix a random test failure you noticed while working on this issue?" + }, + { + "prediction": "I think we can simplify this to: `TableMetadata updated = base != null ? metadata.addPreviousMetadata(base.file().location(), base.lastUpdatedMillis()) : metadata;`", + "reference": "This kind of concern should be handled in the `TableMetadata` update methods. This is similar to `metadata.rollbackTo`, which not only sets the current version, but also updates the table history. I think that all of those methods should add the current object's `file.location()` to the previous metadata location list, if it is non-null. That way, the caller never needs to remember to update it." + }, + { + "prediction": "`mlvl_tensor_list = [mlvl_tensors[i][batch_id].detach() for i in range(num_levels)] if detach else [mlvl_tensors[i][batch_id] for i in range(num_levels)]`", + "reference": "We need to know why all the tensors are detached in `get_bboxed`." + }, + { + "prediction": "I think this should be `TypeSelfCallInMethod.__a` instead of `type(self).__a` since `type(self)` is not the same as `TypeSelfCallInMethod`.", + "reference": "Unrelated but shouldn't this raise `attribute-defined-outside-init`?" + }, + { + "prediction": "Can you add this to the docstring as well?", + "reference": "I would rather no have this as a `kwarg` as it encourages \"growth\" which lead to an unweildy constructor in other classes. Let's add a method or property to take care of this instead as I think it's usage is going to be quite low." + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
", + "reference": "You just changed my life :) I grew very attached to this safe nav approach when working with Groovy years ago `obj?.method`. Glad to see its now a part of Ruby!" + }, + { + "prediction": "Style/RedundantRoleAttribute: Redundant role attribute 'button' found.", + "reference": "do you mean 'clearfix' class?" + }, + { + "prediction": "This should be `@param {boolean} [options.causalConsistency=true] Enables or disables causal consistency for the session.`", + "reference": "`causalConsistency` is already defined on `SessionOptions`. We do not need to duplicate it here." + }, + { + "prediction": "I don't think it's a good idea to use `static import` for `any`, `anyString` and `eq` as it makes the code harder to read.", + "reference": "This should not be included since there are no code changes." + }, + { + "prediction": "I think this should be `c.Req.Header.Get(\"Origin\")` instead of `setting.HTTP.AccessControlAllowOrigin`", + "reference": "If all we need just response 200, then we could use `c.Status(http.StatusOK)` here." + }, + { + "prediction": "I'm not sure this is the right thing to do. If the node doesn't exist in the datastore, we should return an error, not an empty node.", + "reference": "Should be checking for error here" + }, + { + "prediction": "Why is this necessary? I don't see any changes to the `FormTabs` class that would require this.", + "reference": "Put a space between `(array)` and `$this` and I'll merge it" + }, + { + "prediction": "I think we can remove this file now.", + "reference": "You could add this to stack.go, which has similar functions (to avoid yet another small file). None of these are likely to be implemented considering what TinyGo is designed for." + }, + { + "prediction": "This class is not needed. You can just pass the `notificationId` and `content` as parameters to the methods that need them.", + "reference": "the class names `NotificationHolder` and `NotificationsHolder` are fairly difficult to quickly tell apart, particularly since they are often used close to each other" + }, + { + "prediction": "Please don't use `import *`", + "reference": "Avoid wildcard imports" + }, + { + "prediction": "This is a breaking API change. We should not do this.", + "reference": "Need to do this to unblock mockgen. The interface method needs to be public to be visible in another package. The right fix is to delete this test only interface method" + }, + { + "prediction": "I think this should be `Object.keys(items).map(k => k.toLowerCase()).indexOf('loadbalanced') !== -1`", + "reference": "same question here as I have on the other file regarding doing this check here vs L112 vs not at all" + }, + { + "prediction": "I think this should be `// +build !openbsd !plan9`", + "reference": "Adding `// +build !windows` (as a separate line) will do the same for Windows. So while you are at it we might add it as well." + }, + { + "prediction": "This is not used anymore, so it can be removed.", + "reference": "this is used as important way of mocking for unit tests, FYI" + }, + { + "prediction": "I think this should be `muted_alpha=0.5`", + "reference": "Sorry, should have been clearer, I meant adding this to the ``Histogram`` options one line above." + }, + { + "prediction": "I think this should be `C23NH2` instead of `C23NHx2`.", + "reference": "Just ignorance on my part, but what is the significance of the change from C23NHe2 to C23NHx2?" + }, + { + "prediction": "I think this should be `param.Array` instead of `param.ClassSelector`.", + "reference": "What about tuples or pandas series? Do we want to support lots of different types or force a single type?" + }, + { + "prediction": "I don't think we should remove this check. If the collection doesn't exist, we should throw an exception.", + "reference": "Small thing, without the check above this will throw a NoNodeException if the path doesn't exist. Maybe this can be wrapped in a try/catch just for the NoNodeException, so that the more user-friendly message used above can be thrown instead: `throw new KeeperException.NoNodeException(\"No collection found at path: \" + path);` Just a thought, I'm not even sure it's worth it." + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "I don't know why this worked before, but we should be explicit on not verifying that a blank string (allowed as a way to remove a url/download_url) is a valid url as it is not." + }, + { + "prediction": "I'm not sure if we want to remove the deprecation warning here. I think we should keep it for now, and remove it when we remove support for PowerShell 2 in Bolt 3.0.", + "reference": "Do we want to raise an error here instead of warning? Or would it be better to just see if Bolt happens to succeed, and let it fail on it's own if it fails? I'd lean towards raising an error, but that's different from \"removing support\"." + }, + { + "prediction": "I think this should be `self.filter_options(unfiltered) must be implemented by the transport class`", + "reference": "This is kind of confusing with the other `filter_options`." + }, + { + "prediction": "I think this should be `if _, ok := err.(OpsCantHandleFavorite); ok {`", + "reference": "Could the `deleteFromFavorites` happen when `head == nil` because it's not initialized yet somehow but not because TLF doesn't exist? I was concerned if this would make it possible in any way to have favorites seemingly deleted on a device while it's not actually happened on server." + }, + { + "prediction": "I think this should be `int64_t` instead of `Int64`.", + "reference": "It doesn't look like this particular \"rowCount\" variable is used anywhere. I suppose we could delete it. The code change is harmless though." + }, + { + "prediction": "I think this should be `if status == 204 || status == 304 {`", + "reference": "Hmm, probably we should instead write whatever `status` is returned instead of coding a special case." + }, + { + "prediction": "I think this should be `out.HttpMatch = &proto.HTTPMatch{Methods: in.HTTPMatch.Methods, Path: in.HTTPMatch.Path, Headers: in.HTTPMatch.Headers}`", + "reference": "Could using the pointer-to-struct approach here cause confusion later? We've had several problems of that kind in the past. What does it mean if the struct is non-nil but its fields are nil? Is that even allowed? (libcalico-go question) Are there any validation requirements for this new rule addition; should it only be allowed if `Protocol == TCP`, for example?" + }, + { + "prediction": "Line is too long. [82/80]
Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "why this recursive relationship definition?" + }, + { + "prediction": "I think it's better to say \"used for routing if present\" instead of \"used for routing if encoding is present\".", + "reference": "More sentence, less list please. > Encoding of the handler. This field is optional. We don't need to mention exactly what it's used for because that list can expand (as it has already in this change)." + }, + { + "prediction": "I think this should be `gocloud.dev/blob/bytes_read_total` and `gocloud.dev/blob/bytes_written_total`.", + "reference": "Not part of this PR, but should the section above say what the name of the metric is for each method?" + }, + { + "prediction": "I think we should use `ToString(\"G29\")` here.", + "reference": "there are changes that are upcoming to this section. For now, this works (to demo the usage of Gauge), and the changes to this section are coming as separate PRs." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we want to be able to kill the background process when the foreground process is killed, but I'm not sure if this is the right way to do it.", + "reference": "This is equivalent to stdout. Why not just replace stdin with stdout in `IsProcessBackground`?" + }, + { + "prediction": "I think this should be `if (p_jmsg[\"compress_method\"] != nullptr) { add_man_to_path(p_jmsg[\"compress_method\"], method); } else { add_man_to_path(\"zfp\", method); }`", + "reference": "Rather than test for nullptr, just treat the pointer as a bool, i.e. `if(p_jmsg[\"compress_method\"])`" + }, + { + "prediction": "I think this should be a warning, not an error. The user can still create the shortcut, it just won't be in a container.", + "reference": "Can we move the remaining code of this method to a new method? I don't like the `return;` here, we could try to replace it with an `if ... else ...` syntax. What do you think?" + }, + { + "prediction": "I'm not sure this is the right place to add the capability. I think it should be added in `kinto/__init__.py` in the `includeme` of the `kinto.core` package.", + "reference": "nitpick: _and collections_" + }, + { + "prediction": "`req_done` and `res_done` are not used in this PR.", + "reference": "I believe these need to be explicitly initialized in `proxy_send_prepare`" + }, + { + "prediction": "I think this should be `t0 = time.time()`, not `t0 = time.time() # Failed task start time`", + "reference": "This is unnecessary. The declaration of `t0` on line 179 is still in scope inside the `except` block." + }, + { + "prediction": "I don't think this is necessary. You can just use the `request::border` property.", + "reference": "The `border_color_`... properties don't support solid colors, not only this one. Maybe `@param solid_color` should be used instead of adding this note to every one of them?" + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to work.", + "reference": "We don't need this file, we can use the one that is in the grid-ui directory" + }, + { + "prediction": "I think this should be `if (isEmptyLine(path)) { continue; }`", + "reference": "FYI: inlined this method in the internal review." + }, + { + "prediction": "Please remove unused imports.", + "reference": "Werid, the checksum between this file and the one on branch `develop` is the same not sure why it's showing a diff" + }, + { + "prediction": "I think it would be better to use `metric.Meter.Name + \"/\" + metric.Name`", + "reference": "Prometheus doesn't have concept of Meter (like OTLP does).. Trying to see if this is a good approach to use the meter name as namespace, to avoid name collisions, when same instrument name is used across multiple instruments, from different Meter." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the `getLibraryCards()` method of the `ILS` class. That way, you don't have to worry about whether or not the auth method is Shibboleth, and you don't have to worry about whether or not the `auth_based_library_cards` config option is set.", + "reference": "The formatting of this is a bit strange; I'd suggest collapsing this back to a single line, and moving the `&&` to the beginning of the second line to meet the line length restriction." + }, + { + "prediction": "I think this should be `else if (segments != NULL && num_segments > 0)`", + "reference": "One or the other should be non-NULL. If segments is NULL, the alloc above will have size zero, which we do not allow (there's no header): it should assert in debug build. So there should be asserts that one is non-NULL at the top, and if there really needs to be some kind of defensive check down here, it should cover the alloc too." + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
", + "reference": "I'm surprised rubocop isn't picking up singe quotes?" + }, + { + "prediction": "I think we can remove this now.", + "reference": "Is this line still needed?" + }, + { + "prediction": "I don't think we should change the default heartbeat period. We should only change it if the user specifies a different value.", + "reference": "Maybe use specific values for all the watt.times fields? Even better, have a const for it at the top of the file?" + }, + { + "prediction": "I think this should be `brailleTables` or `brailleTablesList` or something like that. `tables` is too generic.", + "reference": "nit: UNICODE_BRAILLE_TABLE or something might be a better name for this. IMO, braille-patterns.cti is a terrible name. This table allows Unicode braille characters to be used anywhere to produce raw dots." + }, + { + "prediction": "I think we can remove this field now.", + "reference": "Why are we removing the option to skip machine pool generation?" + }, + { + "prediction": "I think this should be `IHttpStartLineHandler` where `TContext` is the type of the `HttpContext` that will be passed to `OnStartLine`.", + "reference": "\"Request line\" here too." + }, + { + "prediction": "I'm not sure this is the right place to put this check. I think it should be in the zone controller's event handler for `EVENT_LOOT_ZONE`.", + "reference": "Please remove this." + }, + { + "prediction": "Style/SymbolArray: Use %i or %I for an array of symbols.", + "reference": "Weird bug. Combining those joins and group calls was triggering AREL to generate the sql cache inside of will_paginate before the final call. This is a harmless workaround, but hints that will_paginate might becoming seriously deprecated." + }, + { + "prediction": "Metrics/CyclomaticComplexity: Cyclomatic complexity for allowed_tuples is too high. [7/6]", + "reference": "This can be simplified as discussed before." + }, + { + "prediction": "I'm not sure if this is the right place to put this. I think it should be in the `execute` package, but I'm not sure if it should be in the `execute/table` package or the `execute` package.", + "reference": "Does `internal` or `test` in the file name actually do anything here? Or is that just to show these functions are only for tests?" + }, + { + "prediction": "I think this should be `Transaction(hexa).serialize(false).should.equal(hexa);`", + "reference": "does this boolean indicate unsafe serialization?" + }, + { + "prediction": "This is not implemented for node.js. -> This method is not implemented for node.js.", + "reference": "Maybe rewrite to `Is only implemented for React Native`? (I assume that is the case)." + }, + { + "prediction": "I think we can remove the `if (resourcesField != null && !resourcesField.isMap())` check here, since it's already checked in the `getResourcesField` method.", + "reference": "Do we not need this in Java because Java *is* handling map responses?" + }, + { + "prediction": "I think this should be `True` by default.", + "reference": "Maybe \"For configuring which scheduler messages can be received.\"?" + }, + { + "prediction": "`$this->getMediaManager()->getEntityManager()->clear();` should be `$this->getMediaManager()->getObjectManager()->clear();`", + "reference": "It will stop working with orm, so this is not a good fix, Try using some method in a common interface" + }, + { + "prediction": "I think we need to add `Azure.Messaging.ServiceBus` here as well.", + "reference": "`s` is not necessarily the same as `sampler` - sampler could be null and this crazy lambda underneath falls back to something. So please use `s`" + }, + { + "prediction": "I don't think we need to do this. The `HttpParameterType` is only used to generate the OpenAPI spec, so we don't need to set it back to `null` after we're done with it.", + "reference": "This code is a bit confusing. Should HttpParameterType set to the original one or it is always BODY?" + }, + { + "prediction": "I'm not sure this is the right thing to do. If we're not verifying outputs, then we should not be caching them either.", + "reference": "Why did this change?" + }, + { + "prediction": "I think this should be `newProtoForTableStatus(result.Table.TableStatus)`, not `newProtoForTableStatus(result.Table.TableStatus)`.", + "reference": "nit: `status` collides with imported package named `status`" + }, + { + "prediction": "I think this should be called `IsGeneratingCatchpointFile` or `IsWritingCatchpointFileInProgress` or something like that. `IsWritingCatchpointFile` sounds like the catchpoint file has already been written.", + "reference": "\"memory pressure could be decreased\" --> \"to avoid memory pressure\"" + }, + { + "prediction": "I think you can just use `testuser['musicbrainz_id']` instead of `testuser_name` here.", + "reference": "I think it would make sense to fetch the cache values after deleting the listens and making sure they are what we expect." + }, + { + "prediction": "Why do we need to set `collapsible` to `false` here?", + "reference": "I'm thinking about covering this change with the test. Can you do that?" + }, + { + "prediction": "I'm not sure I like the idea of passing in a slice of ports here. I think it would be better to pass in a slice of `*net.UDPConn` and have the NATPinger be responsible for creating them.", + "reference": "Not sure if it's a good idea to remove stop channel. If user cancels connection how will you stop pinger?" + }, + { + "prediction": "I'm not sure if this is the right way to do it, but I think we need to make sure that the `ServerAddress` is set to the correct value for the registry we're trying to pull the image from. If we don't do this, the `docker pull` command will try to pull the image from the Docker Hub, which is not what we want. The `ServerAddress` should be the full URL of the registry, e.g. `https://index.docker.io/v1/` for the Docker Hub, or `https://myregistry.com/v1/` for a private registry.", + "reference": "Could you please add a `TODO` here that we won't need `docker.AuthConfiguration` anymore when we migrate to SDK's pull image?" + }, + { + "prediction": "I think this should be `public string[] BlobNames { get; set; }`", + "reference": "Is there a scenario were we want to get an arbitrary set of blobs that don't share a common root?" + }, + { + "prediction": "I think it would be better to have a separate test suite for this, so that we don't have to run all the tests twice.", + "reference": "Can you leave a note about why we are skipping regex tests?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think we should do this in `repo.OpenFSRepo` instead, so that we don't have to do it in two places.", + "reference": "This was the only caller of CreateRepo, so I inlined it." + }, + { + "prediction": "I think this should be `AuthMount` or `AuthMountPath` or something like that. `AuthPath` sounds too generic.", + "reference": "As this is already a child of `auth`, I think we can shorten this to `path`" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get the first visible range.", + "reference": "This call should use element, not 0 I think." + }, + { + "prediction": "I think it would be better to call this `FetchUntilEmptyPage` and `PartialPageFetchThreshold` to be consistent with the other options.", + "reference": "This is missing the definition of `fetch_until_empty_page` - it needs to go in the config section above." + }, + { + "prediction": "Line is too long. [85/80]", + "reference": "I don't think this one needs to be changed since the only previous path is already an absolute one." + }, + { + "prediction": "I think we can remove the `table.locationProvider()` here. The `newStaticTable` method already takes a `LocationProvider` as an argument, so we don't need to call `table.locationProvider()` here.", + "reference": "Since we kept the original constructor we might not need this change now." + }, + { + "prediction": "I think this should be `LOG.debug(\"Refreshed [{}] from [{}]\", fullName, metadataLocation);`", + "reference": "There is already a log in `BaseMetastoreTableOperations` for this. It has the location, but not the table name. Maybe just add table name to that one." + }, + { + "prediction": "I think it's better to use `github.com/pipe-cd/pipe/pkg/filestore` instead of `github.com/pipe-cd/pipe/pkg/filestore/minio`.", + "reference": "This should be in the last group." + }, + { + "prediction": "I think this should be moved to the `finally` block, so that we always send the statsd metrics, even if there is an exception.", + "reference": "I believe you should either remove this or rename the PR. You can't change the behavior of the tracer (even to fix a bug) in a PR named \"unit test improvements\"" + }, + { + "prediction": "I think this should be `certmanager.k8s.io/v1alpha1`", + "reference": "I've gone with this group name, however I'm open to suggestions on alternatives!" + }, + { + "prediction": "I think this should be `QUORUM` instead of `QUORUM_API`", + "reference": "should this be GOQUORUM" + }, + { + "prediction": "Why do we need to pass in `checkCoinbase` here?", + "reference": "I think checkCoinbase is not skipping checking coinbase. Instead, true-> checking num(coinbase tx) = 1, false -> checking num(coinbase tx) = 0." + }, + { + "prediction": "I think it's better to use `factory.WorkingSet` instead of `protocol.StateManager` here.", + "reference": "same here, move it out" + }, + { + "prediction": "I think this should be `#if defined(KOKKOS_ENABLE_LIBDL) || defined(KOKKOS_TOOLS_INDEPENDENT_BUILD)`", + "reference": "Can you elaborate on why you need different behavior depending on Tools being built independently or not?" + }, + { + "prediction": "Metrics/LineLength: Line is too long. [121/120]", + "reference": "because of the above if statement will requires both ex_save and guid_save to be true, this code will always return 'example answer'. This should be revised with `example_answer.present?` and `guidance.present?`" + }, + { + "prediction": "I think we should use `context.Context` instead of `golang.org/x/net/context.Context`", + "reference": "why not context from stdlib?" + }, + { + "prediction": "I think this should be `FlavorIEEECRC32OverThriftBinary`", + "reference": "Just saw this and wasn't able to hold myself from renaming :-)." + }, + { + "prediction": "`Object.keys(core.plugins)[0]` can be `undefined` if `core.plugins` is an empty object.", + "reference": "Can we keep the other assertion too? I think it's helpful to ensure that the uninstall function was called too" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "`warn_with` prefixes the message with `WARNING:`, right? So this will put `WARNING:` twice. It would be good to verify all the warnings look good after this change, given how easy it is to make a simple mistake like this :(." + }, + { + "prediction": "I think this should be 10 or 20. 6 is too short.", + "reference": "FYI In the message queue I use the term \"stamp\" to refer to the time-like mark associated with each message. It's opaque to the queue/pool and should make no difference if the stamps and age limit were converted to seconds. So this could then become `Stamper` with `CurrentStamp()` method, no reference to \"blocks\" or height etc. The wrapper struct could be `StampedMessage. The interpretation as block height is deferred to the user/constructor that hooks things up, the \"business logic\". This is just an observation, take or ignore as you wish." + }, + { + "prediction": "I don't think we need to check if the bucket exists here. If the bucket doesn't exist, we'll get a 404 when we try to get the lifecycle.", + "reference": "Can we remove the `TODO` statement here? (as this is actually fixed in this PR)" + }, + { + "prediction": "I think this should be `private DisplayPreference mDisplayPreference = DisplayPreference.DEFAULT;`", + "reference": "m prefix no longer in code style" + }, + { + "prediction": "I think this should be `return kvb.buffer.Filter(ns, c)`", + "reference": "need to filter the entities in buffer as well" + }, + { + "prediction": "This should be `de.danoeh.antennapod.core.glide.FastBlurTransformation`", + "reference": "Please add spaces before and after the equals sign" + }, + { + "prediction": "Please remove this line.", + "reference": "This file could also be cleaned up/deleted. But lets do this separately after ensuring all the event logging has been ported to the current logmxevent_traf.cpp file completely." + }, + { + "prediction": "Line 12 of `spec/rspec/core/resources/formatter_specs.rb` is expected to fail because it is marked as pending, but it passed.", + "reference": ":thinking:, the line number here is the line of the example (`example.location`), that's probably why I finally chose to display the example title because it's what can be found on this line, and saying that the error is from there is confusing. But presenting the actual failures is indeed better, so maybe we can get the failure actual line number from the exception backtrace and then output two distinct lines for failures like this one?" + }, + { + "prediction": "I think this should be called `headless` or `headless_mode` or something like that. `create_no_window` is not very descriptive.", + "reference": "We shouldn't add this as a new `kwarg` here. This should all be done on the options class" + }, + { + "prediction": "Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.", + "reference": "Should this be `OS_VOLUME_SUPPORT` to match the symbol key names?" + }, + { + "prediction": "I think this should be `static flux_msg_handler_t **handlers = NULL;`", + "reference": "In C, file scope variables are already initialized to 0 so the \"= NULL\" is redundant. Not a big deal." + }, + { + "prediction": "`getRootNode` will return `document` if `node` is not in a shadow DOM.", + "reference": "on line 40, the `relevantNode` can change and therefore the `doc` might change too for the lookup on line 43. I think this code should be moved to where the `doc` is actually being used" + }, + { + "prediction": "I think this should be `nameof(MinMilliseconds)` and `nameof(MaxMilliseconds)`.", + "reference": "nit: just to be similar to others, can you change to interpolation?" + }, + { + "prediction": "I think we should call this `IncludeRootCert` or something like that. `FullCertChain` is a bit ambiguous.", + "reference": "Would this make more sense as an option on an Issuer resource (specifically on the CA issuer) rather than as a flag? It's not ideal that we have a flag that _looks_ like it could be 'global' but is actually not IMO. Also, if Istio is reading the CSR object, is it possible for it to read the CA from the CSR itself too and append the two instead? Not sure if we ever decided whether to use annotations for this purpose @JoshVanL?" + }, + { + "prediction": "I think this should be `SERVER_TIME_F = \"%Y-%m-%dT%H:%M:%S.%f\"`", + "reference": "Because this acts as a coordination point between client and server, it should go in core.py instead of const.py (so eventually the server could use it to guarantee that it delivers dates in the expected format)." + }, + { + "prediction": "I think this should be `if apierrors.IsNotFound(errors.Cause(err)) || apierrors.IsConflict(errors.Cause(err)) {`", + "reference": "expected statement, found 'else' (and 1 more errors)" + }, + { + "prediction": "I don't think this function is used anywhere.", + "reference": "IMO this doesn't need to be in the `kbfs` repo. And I don't like setting the byte. We can always compare with the randomly generated `TlfID`." + }, + { + "prediction": "Do we need this file? I don't see it being used anywhere.", + "reference": "What's the difference from ModuleName in `pkg/apis/meta/v1alpha1/types.go`?" + }, + { + "prediction": "I think we can remove this line.", + "reference": "We shouldn't be changing this task as we are trying to break our dependency on it and switch to using the shipped version." + }, + { + "prediction": "I think this should be `cci->num_regs_skip < 2`", + "reference": "Shouldn't we have a low bar for generating out-of-line context switch, i.e., if we need save more than n (3?) simd or m (4) gprs we should go out-of-line? And it should be || instead &&. It seems the bar is still very high after this change." + }, + { + "prediction": "I think we can remove this import.", + "reference": "Should the API have a dependency on the SDK?" + }, + { + "prediction": "I think this test is still valid, but we need to make sure that we don't run it in parallel with other tests that use the same collection.", + "reference": "Is this a sometimes leaky test?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to work.", + "reference": "It should be possible to create a test case that enter the loop. That would be a good enough test case for me. Have a look at the extern type inference test cases that already exist. Since you can just pick the type variables the extern type use, you should be able to create a conflict that requires this loop to fix." + }, + { + "prediction": "`wxLang.Language` can be `None` if `wxLang` is `None`.", + "reference": "It might make sense to log this." + }, + { + "prediction": "Style/SymbolArray: Use %i or %I for an array of symbols.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.", + "reference": "Line is too long. [84/80]" + }, + { + "prediction": "I think this should be `goog:chromeOptions` instead of `\"goog:chromeOptions\"`.", + "reference": "nice touch since Google likes to change things every now and then." + }, + { + "prediction": "Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.", + "reference": "Thank you this is so much nicer than the old `Rails.configuration.branding['blah']['blah']['blah']` :)" + }, + { + "prediction": "I think this should be `BACKEND_SERVICES` to be consistent with the other resource types.", + "reference": "nit: Would you mind alpha-sorting this?" + }, + { + "prediction": "I think this should be `manifest.content() != ManifestContent.DELETE`", + "reference": "For my understanding, the DATA manifest & DELETE manifest could share the same read / write path so I think we could use the common reader+writer. Is there any other reason that we need to make them separate paths ?" + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "that change should be sufficient for avoiding the override of contact_us_url helper. The one defined at the .yml it is within a hash so no problem should arise." + }, + { + "prediction": "\"Erstellen und weitere Elemente hinzuf\u00fcgen\" would be more accurate.", + "reference": "We actually had a discussion about this exactly in #3470, some languages seem to go for one, some for the other" + }, + { + "prediction": "I think it would be better to rename this to `streamingDescriptors` to be consistent with `longRunningDescriptors`", + "reference": "Is PHP the first dynamic MVVM language with grpc streaming support?" + }, + { + "prediction": "I think this should be `if (tmpStream) { delete tmpStream; tmpStream = nullptr; }`", + "reference": "the `if` isn't necessary here; it's safe to call `delete` on `nullptr`" + }, + { + "prediction": "I think this should return a `ReturnCode_t` instead of a `bool`.", + "reference": "Change if the method's name finally changes to `clear_history` as proposed elsewhere" + }, + { + "prediction": "I think this should be `import docUtils` and `helpFile = docUtils.getDocFilePath(\"userGuide.html\")`", + "reference": "can this one also be moved to the top of the file?" + }, + { + "prediction": "GroupMembers is a list of resources selected by this group. -> GroupMembers is a list of GroupMembers selected by this group.", + "reference": "So if I understand this correctly the externalEntities should be computed and stored in GroupMember, while current code usage of GroupMemberPod will be migrated to GroupMember later?" + }, + { + "prediction": "I don't think we want to change the names of these constants.", + "reference": "Don't we have tests to change after this breaking change? probably we're not using hard coded strings in our tests when we create a `Span`?" + }, + { + "prediction": "I think this should be `os.environ.get('GOOGLE_APPLICATION_CREDENTIALS', 'bigquery-credentials.json')`", + "reference": "will this fail if the env variable doesn't exist? Is this the preferred behaviour?" + }, + { + "prediction": "I think you can just do `0.01 * self._random.getReal64(size=self._numColumns, dtype=realDType)`", + "reference": "bad line wrap" + }, + { + "prediction": "This should be `sizeof (rai::uint256_union) + sizeof (rai::uint256_union) + sizeof (bulk_pull_blocks_mode) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t) + sizeof (uint32_t", + "reference": "What does the `8` here represent? Can you give it a name?" + }, + { + "prediction": "I think this should be `os.environ.get(\"MP_API_KEY\")` so that it doesn't fail if the environment variable is not set.", + "reference": "`MPRester(os.environ[\"MP_API_KEY\"])` can be left simply as `MPRester()` and it will pick up the API key from the environment. What is the purpose of this file otherwise? Is it better suited for `dev_scripts`, or a test?" + }, + { + "prediction": "Align the parameters of a method call if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Looks like there may be more changes to this file than intended?" + }, + { + "prediction": "I don't think this is the right fix. If the message is not a map, then we should not be trying to access `body[\"message\"].(map[string]interface{})` in the next line.", + "reference": "when message type is not expected, contine to next loop instead of return to finish infinite loop" + }, + { + "prediction": "I think we can remove this line.", + "reference": "This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we want to be able to update the instance ID, but I don't think we want to be able to change the instance ID of an existing machine.", + "reference": "instanceID should stay the same for a AWSMachine?" + }, + { + "prediction": "Should this be `NO_DOWNLOAD=\"true\"`?", + "reference": "Since this is a dict don't you want `False` or do we clean that up elsewhere?" + }, + { + "prediction": "I think this should be `127.0.0.1` instead of `localhost`.", + "reference": "what's the reason you had to add the `host` argument to all `get_work` calls?" + }, + { + "prediction": "I'm not sure what you're trying to do here. The `onSuccess` method is called after the command has been executed, so you don't have access to the `Dataverse` object that was passed to the `execute` method. If you want to index the `Dataverse` object, you should do it in the `execute` method. If you want to index the `Dataset` object, you should do it in the `execute` method of the `UpdateDatasetCommand` class.", + "reference": "This will never be a dataset so we can simplify the code here" + }, + { + "prediction": "I don't think we need this constructor. It's only used in tests, and we can just use the constructor that takes all the parameters.", + "reference": "This should be moved into the PrivacyBlockProcessor instead of adding the constructor here." + }, + { + "prediction": "I think it's better to rename this package to `insightstore` instead of `insightfilestore`.", + "reference": "nit: Remove \"insightfilestore\". I think \"insightstore\" is good enough and as I see we are using that name at other places too." + }, + { + "prediction": "Metrics/BlockLength: Block has too many lines. [31/25]", + "reference": "It looks like you've removed `bisect_round_finished` but kept `bisect_round_started`. Seems a little odd that they aren't paired. Not sure if there's anything to do about that though..." + }, + { + "prediction": "I don't think this is necessary. The `set_perc` signal is connected to the `update_perc` slot, which calls `self.update()`, which in turn calls `self._update_perc()`. The `self._update_perc()` method is the one that does the actual updating of the label.", + "reference": "I'm not sure how to fix the lint and mypy warnings on this line. I could just ignore them, but I feel like the linter should know this exists." + }, + { + "prediction": "I don't think we need to change this to a string.", + "reference": "why remove `Symbol`?" + }, + { + "prediction": "I'm not sure if this is the right place to add the `\u00a3` symbol. I think it should be added to the `getPunctuationRegExp` function in the `punctuation.js` file.", + "reference": "Why are currency signs considered punctuation? They technically fall under the BMP range for Currency Symbols `\\u20A0-\\u20CF` (covered in `getUnicodeNonBmpRegExp`, which is itself a misnomer)" + }, + { + "prediction": "I don't think it's a good idea to add the maintainer in the author field. The author field should contain the name of the original author of the project, and the maintainer field should contain the name of the current maintainer of the project.", + "reference": "You have forgotten a coma `,`" + }, + { + "prediction": "`osp.join(out_dir, osp.basename(img_meta['filename']))` -> `osp.join(out_dir, img_meta['filename'])`", + "reference": "For different datasets, we may want to save the images differently. Sometimes the datasets are categorized into several subfolders, and we want to keep it when saving visualization results, and sometimes we just want to save all images in `out_dir`. An argument may be added to control the behavior." + }, + { + "prediction": "I'm not sure this is correct. If `c1 == c2` and `bb.get(ia) != '\\0'` then we should return 0, not 1.", + "reference": "if `other` could have a guaranteed `0` byte in it, this whole `if` could be removed, and above you could just add `|| c2 == '\\0'` to get the same effect?" + }, + { + "prediction": "I think this should be `boolean` instead of `Boolean`", + "reference": "nit: can this be a primitive value?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the right thing to do. If you go to `http://localhost:3000/` you'll get a 404, but if you go to `http://localhost:3000/` you'll get a 301 to `http://localhost:3000/`.", + "reference": "This maybe not what we want. If `rewrite` occurred before, `r.URL.Path` contains the result and we should use it. Otherwise `rewrite` middleware will disfunction when combining with `browser`." + }, + { + "prediction": "I'm not sure about this change. I think it's better to keep the order of the modules as they are defined in the config file.", + "reference": "Why change this?" + }, + { + "prediction": "This class is not used anymore, so it can be removed.", + "reference": "_nitpick_ Isn't it now actually NotLogFakeHttpExceptions**Error**Listener ?" + }, + { + "prediction": "I think this should be `resourceDefinition.AddProperty(\"type\", JsonSchema.CreateStringEnum(resourceType), true);` instead of `resourceDefinition.ResourceType = resourceType;`", + "reference": "Why not just look for the \"type\" property instead of creating a ResourceType property?" + }, + { + "prediction": "Why do we need to pass the chain ID here?", + "reference": "should use `bc.config.Blockchain.ChainID`" + }, + { + "prediction": "Should this be `ElasticsearchStorage.Builder#hosts(List)`?", + "reference": "this doesn't need to know about NativeClient" + }, + { + "prediction": "I don't think we need the backticks here.", + "reference": "I know we discussed if we should add in the resource_name to the hash, and I actually don't think it's required. The violation hash was recently updated (not released) to include the violated rule, so when the next release goes out, user's findings will get updated. The resource name doesn't hurt to have here, but not required." + }, + { + "prediction": "I think this should be `surface->texture->height_from_buffer = surface->texture->height / surface->current.scale;`", + "reference": "The variable name is also misleading imo. The width from the buffer comes from `wl_shm_buffer_get_width` (or a similar EGL thing), which is what gets encoded into `surface->texture->width`." + }, + { + "prediction": "I think this should be `artist_mbid` and `recording_mbid` instead of `artist_msid` and `recording_msid`.", + "reference": "Why are you using these tags to carry these msids?" + }, + { + "prediction": "`strncpy` is not null-terminating the string if the source string is longer than the destination buffer. `strcpy` does not check the length of the source string, it just copies as many bytes as the destination buffer can hold.", + "reference": "flb_strdup() should do the work here. note: use Fluent Bit memory wrappers" + }, + { + "prediction": "why do we need to use gogofaster instead of gogoprotobuf?", + "reference": "This line should be separated from the package declaration by one line as it is not the package description." + }, + { + "prediction": "Why is this change needed?", + "reference": "shadow: declaration of \"err\" shadows declaration at line 410 (from `govet`)" + }, + { + "prediction": "I think it's better to use `time.Duration` instead of `string` here.", + "reference": "Maybe next time better to make separate PR?" + }, + { + "prediction": "I think it is better to raise an error when the mask head is not used.", + "reference": "line 316 also handles this case, need to simplify the logic." + }, + { + "prediction": "I think this should be `gcsblob.OpenBucket: bucketName must not be empty`", + "reference": "We used to have a simple check for bucket and object names, we then decided to remove it and rely on the backend service to check for the name. Is there any reason to add an empty name check now?" + }, + { + "prediction": "I think this should be `std::chrono::duration_cast(max_blocking_time_point.time_since_epoch() - std::chrono::steady_clock::now().time_since_epoch())`", + "reference": "Line too long" + }, + { + "prediction": "Please add a comma at the end of the line.", + "reference": "This isn't aligned though." + }, + { + "prediction": "`PAA only supports \"with_nms=True\" now and it is mean PAAHead does not support test-time augmentation` -> `PAA only supports \"with_nms=True\" now and it means PAAHead does not support test-time augmentation`", + "reference": "it is mean -> it means PAAHead does not support test-time augmentation." + }, + { + "prediction": "This import is not used.", + "reference": "@lnielsen-cern thanks. I missed it :(" + }, + { + "prediction": "I think this should be `content-pages` instead of `content-drilldown`.", + "reference": "@tofumatt, has it been changed intentionally? It doesn't seem to be required in IB, plus we haven't had `content-drilldown` before... If it has been changed intentionally, then should we update the `AnalyticsDashboardWidget` component to be use `content-drilldown` instead of `content-pages` as well?" + }, + { + "prediction": "Please revert this change.", + "reference": "nit: don't think an extra line is needed here; as retrying is an installed library and should be grouped with the rest of the installed library." + }, + { + "prediction": "I think this should be a `bool`, not a `string`.", + "reference": "This should be a bool" + }, + { + "prediction": "I think this should be `if (swift_typebase && llvm::isa(swift_typebase))`", + "reference": "`if (llvm::dyn_cast_or_null(GetSwiftType(compiler_type).getPointer())` ?" + }, + { + "prediction": "I think we can remove the `canaryManifests = append(canaryManifests, canaryConfigMaps...)` and `canaryManifests = append(canaryManifests, canarySecrets...)` lines.", + "reference": "The `generateVariantWorkloadManifests` function below relies on the config manifests specified in Git, but it was passed with the newly created canary's manifests where their name was updated." + }, + { + "prediction": "Please remove this empty line.", + "reference": "are this docs neccesary ?" + }, + { + "prediction": "I don't think we need to make these final. They are only set once in the constructor.", + "reference": "Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC." + }, + { + "prediction": "Why is this necessary?", + "reference": "This change suppose to resolve issue #2968. `loss_weight` should be of length 2, the second entry is ignored." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to work.", + "reference": "Is there an easy way to check for conflict suffix to avoid false positives here?" + }, + { + "prediction": "I think this should be `@context.get_validated_task(opts['task'], params, run_opts)`", + "reference": "`apply_prep.run_task` also seems like it can just use `@context.run_task`" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work for now.", + "reference": "do you have any idea on how to fix it?" + }, + { + "prediction": "I think this test should be in `test_gcs.py` rather than `test_gcs_target.py`.", + "reference": "You don't need to fix this (you've done so many iterations). But for next time, you can make this into a docstring so it'll have a nicer descriptive name when the tests are running." + }, + { + "prediction": "I think this should be `return time.Now().After(eni.ExpiresAt)`", + "reference": "When does 'expiresAt' change? Do you need this?" + }, + { + "prediction": "I think you can remove the `sex` variable and just use `for (uint8_t sex = 0; sex <= 1; ++sex)`.", + "reference": "There are enums for genders + `PLAYERSEX_LAST`." + }, + { + "prediction": "I'm not sure this is the right way to calculate the cost of the zeroes and ones in the data. I think it should be something like: `zeroesCost := zeroes * 4` `onesCost := (96 + ones) * 16` `dataCost := zeroesCost + onesCost` `dataFee := int64(dataCost) * tt.dataPrice` `executionFee := uint64(tt.executionPrice) * tt.gasUsed` `expectedFee := uint64(dataFee) + executionFee` `if fee.Cmp(big.NewInt(int64(expectedFee))) != 0 { t.Errorf(\"rollup fee check failed: expected %d, got %s\", expectedFee, fee.String()) }`", + "reference": "Should this use the constants as well? Or intentionally covering the fact that the constants may change" + }, + { + "prediction": "I don't think this is correct. If `self._size` is negative, then `self.best` will be empty, so `len(self.best)` will be 0, but `self._size` will still be negative.", + "reference": "The case of a negative size (= keep all elements) was not handled in this function." + }, + { + "prediction": "I don't think we should enable infinite timeout by default. I think it should be disabled by default.", + "reference": "I think we should keep this dynamic config knob for operations purpose." + }, + { + "prediction": "I think this test should be changed to `self.assertEqual(ti.offsets, (3, 5))`", + "reference": "Was this intentional? Perhaps this could be replaced with another way to check the offsets?" + }, + { + "prediction": "I'm not sure this is the right place to put this. I think it would be better to put it in the `Deploy` stage.", + "reference": "the buckets are created via the stackset, customers don't need to provide them" + }, + { + "prediction": "Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.<", + "reference": "This doesn't have the same behavior as before. Maybe you want `reverse_merge` (and it either just works or we implement it on `Blacklight::Solr::Request`)" + }, + { + "prediction": "I think this should be `cmd \"export PATH=/usr/local/ghc/#{ghc_version}/bin:$PATH\", fold: 'ghc', retry: true`", + "reference": "This should be ` /$(ghc_find #{config[:ghc]})/ ` instead of ` /#{ghc_version}/ `, I think." + }, + { + "prediction": "I'm not sure if this is the right change. I don't think we want to change the name of the icon here. I think we want to change the name of the icon in the CSS file.", + "reference": "We should deprecate this at some point." + }, + { + "prediction": "`center_sample_radius` -> `center_sample_radius`", + "reference": "Move these two arguments before `loss_cls`." + }, + { + "prediction": "I'm not sure this is the right way to do this. I think we should be generating a new serial number every time we generate a new cert.", + "reference": "[Super NIT]: i := serialNumber if i == 0 { i = mathrand.Int63n(...) }" + }, + { + "prediction": "I think this should be `--tool-format` to be consistent with the rest of the options.", + "reference": "-f short form here collided with --force. :)" + }, + { + "prediction": "I don't think we need this test anymore.", + "reference": "I think it is better to describe in the release note that `rerender()` was removed." + }, + { + "prediction": "I don't think this is necessary.", + "reference": "We could also test this easily with `runpy.run_module`, what do you think?" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think it should be `v.Type().ConvertibleTo(reflect.TypeOf(val))` and then `v.Set(reflect.ValueOf(val).Convert(v.Type()))`", + "reference": "Is it OK to fall through if it's not assignable? I was kind of surprised when the tests passed. Maybe one of the options below ends up working? For the new tests, this panics because `**not assignable uuid.UUID to []uint8**`. `uuid.UUID` is an array, not a slice." + }, + { + "prediction": "I think we can remove the `porcelainAPI` field from the `Server` struct.", + "reference": "I know this is after the fact but imo blockAPI should be blockMiningAPI." + }, + { + "prediction": "I think we should use `self::SYSTEM_ATTRIBUTE_PREFIX` instead of `AttributeCode::SYSTEM_ATTRIBUTE_PREFIX`", + "reference": "it's just a pattern as it was. SystemAttributeCode should have it's own definition and validate by it" + }, + { + "prediction": "Why do we need this file?", + "reference": "Similar to the code block when we use prefix, maybe we can unify them to base?" + }, + { + "prediction": "I think we need to validate the duration here as well.", + "reference": "I think `Duration` is useful for this action and we shouldn't ignore it." + }, + { + "prediction": "I don't think this is correct. If `s.err` is not nil, then `len(p) - len(s.dataForWriting)` is not the number of bytes that were actually written.", + "reference": "Everything below here can be replaced with `return s.err, len(p) - len(s.dataForWriting)`." + }, + { + "prediction": "I think this should be `KOKKOS_ENABLE_IMPL_DESUL_ATOMICS && KOKKOS_ENABLE_HIP_ATOMICS`", + "reference": "Again, we can also guard `g_host_hip_lock_arrays.atomic`, can't we?" + }, + { + "prediction": "I think it's better to use `true` instead of `false` as the second argument of the `dispatch` method.", + "reference": "Variable name should start from lowercase latter" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get the test to pass.", + "reference": "Why has this timeout doubled?" + }, + { + "prediction": "I think we should keep this as 30s. If we set it to 0, we will not be able to recover from a stuck iptables lock.", + "reference": "Should IptablesPostWriteCheckIntervalSecs be set back to its previous smaller value, if use of the iptables lock is disabled?" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think it should be `self._tab.key_press(Qt.Key_Enter, modifier=Qt.NoModifier)` or `self._tab.key_press(Qt.Key_Enter, modifier=Qt.ControlModifier)` depending on whether the focused element is an input field or not.", + "reference": "You're missing a `return` here, but I'll add it :smile:" + }, + { + "prediction": "I think this should be `gles2_get_texture_in_context(wlr_texture);`", + "reference": "Can you try adding back this assertion? I'd like to assert that the texture has been created in the same context as the renderer." + }, + { + "prediction": "I think we can remove the `decode('utf-8')` here.", + "reference": "This won't work with Python 3 because it will already be a string. In that case we need to use `decode_header` from utils." + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.", + "reference": "Why is the respond_to check here?" + }, + { + "prediction": "I don't think this change is correct. I think it should be `if ($char === '\\\\' || ctype_alnum($char) || $char === '_') {`", + "reference": "@orklah are you sure it's the same as `$chars[$i]`? It looks like `$i` is changed above, after `$char` assignment." + }, + { + "prediction": "`AddVerticesProcessor::instance(kv.get(), nullptr, nullptr, nullptr);` -> `AddVerticesProcessor::instance(kv.get(), nullptr, nullptr, nullptr, nullptr);`", + "reference": "I have a question? How do I construct a indexManager for testcase?" + }, + { + "prediction": "(style) code indent should use tabs where possible (style) code indent should use tabs where possible (style) code indent should use tabs where possible (style) code indent should use tabs where possible (style) code indent should use tabs where possible (style) code indent should use tabs where possible (style) code indent should use tabs where possible (style) code indent should use tabs where possible (style) code indent should use tabs where possible (style) code indent should use tabs where possible (style) code indent should use tabs where possible (style) code indent should use tabs where possible (style) code indent should use tabs where possible (style) code indent should use tabs where possible (style) code indent should use tabs where possible (style) code indent should use tabs where possible (style) code indent should use tabs where possible (style) code indent should use tabs where possible (style) code indent should use tabs where possible (style) code indent should use tabs where possible (style) code indent should use tabs where possible (style) code indent should use tabs where possible (style) code indent should use tabs where possible (style) code indent should use tabs where possible (style) code indent should use tabs where possible (style) code indent should use", + "reference": "These checks aren't needed. See pluginmgr.c : opae_plugin_mgr_load_dflt_plugins( )." + }, + { + "prediction": "I think this should be `trim($query) === ''`", + "reference": "Please take a care about prefixing." + }, + { + "prediction": "I think we should rename this to `getOrCreateAccount` to be consistent with the other `getOrCreate` methods.", + "reference": "this line doesn't match what the rest says" + }, + { + "prediction": "Why do we need this change?", + "reference": "Since it's not working for linux, maybe leave the !linux in there as well?" + }, + { + "prediction": "I think this should be `if len(v) == 0 {`", + "reference": "Should we remove the key-value pair entirely? Same for workflows in general. We have a \"sourceExists\" method that checks if a key is there if I remember correctly." + }, + { + "prediction": "I think this should be `SoqlSyncDownTarget.addFilterForReSync(getQuery(), getModificationDateFieldName(), maxTimeStamp)`", + "reference": "Unrelated bug fix" + }, + { + "prediction": "I don't think you need to concatenate the name and version here. You should be able to pass them in as separate arguments.", + "reference": "We probably want to let the translation library handle the string replacement for these as well." + }, + { + "prediction": "I don't think we need to remove `getDBFlags()` here.", + "reference": "should combine these 2 list (list_gossip and list_db) into just one list command, and show the discrepancy between the 2 if any." + }, + { + "prediction": "Metrics/CyclomaticComplexity: Cyclomatic complexity for approve_reject? is too high. [7/6]", + "reference": "What do you think about prefixing the Policy method names with `can_`?" + }, + { + "prediction": "I'm not sure why this was changed, but I think it's better to keep it as it was before.", + "reference": "Based on the docs, credential process can return a key `SessionToken`" + }, + { + "prediction": "I think this should be `if (today.getMonth() < birthDate.getMonth() || (today.getMonth() === birthDate.getMonth() && today.getDate() < birthDate.getDate()))`", + "reference": "I think this if should be removed (see issue)" + }, + { + "prediction": "I think this should be `github.com/projectcalico/libcalico-go/lib/backend/api`", + "reference": "I would avoid importing `felix/ipsets` package because this package is the windows equivalent and should be at the same level of `felix/ipsets`. We could add linux specific dependencies into `felix/ipsets` later and it will break Windows build." + }, + { + "prediction": "This import is not needed.", + "reference": "nitpick: Please move this down to the other imports, as it's a Python stdlib import." + }, + { + "prediction": "I think this should be \"See https://gocloud.dev/howto/blob/ for getting started guides.\"", + "reference": "\"for getting started guides\" reads a bit weird, like it's missing punctuation. Maybe just \"for a tutorial\"?" + }, + { + "prediction": "I think this should be `$useCaptcha = false`", + "reference": "This looks like a dead parameter -- maybe a copy and paste error. If it's truly unused, maybe you can open a separate PR to simply delete it, and then it's one less detail to worry about here." + }, + { + "prediction": "I think we can remove the `int64` and `uint64` cases here, since they are covered by the `int` and `uint` cases.", + "reference": "Nit: Should we add support for `int` and `uint` in the `values.New()` function? That would allow us to to handle all of these types in one case. Maybe there's a good reason why we don't do that already, but I'm not sure what it is." + }, + { + "prediction": "I think this should be `final` again.", + "reference": "if you are not dealing with cache now, please revert these changes. On their own they make little sense" + }, + { + "prediction": "This is not needed.", + "reference": "Wearing my extra-douche-bag hat I would say not spaces on a blank line. Maybe at some point we could have some automated process remove these things. For now I would not bother changing it." + }, + { + "prediction": "This class is not used anymore.", + "reference": "I think it would be better to use an `ItemUpdatedEvent` like for the \"prefer streaming\" preference. We already have a ton of events that need to be handled in all list fragments that just do the same everywhere. I think we could even remove some of the existing events in the future." + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "I think we have to manually write a down for this migration." + }, + { + "prediction": "I don't think we need to do this. We can just do `sdf = _InternalFrame.attach_default_index(sdf)` and `index_map = [(SPARK_INDEX_NAME_FORMAT(0), None)]`", + "reference": "I don't think we still need this check, but I'd leave it as an assertion for now." + }, + { + "prediction": "Style/SymbolArray: Use %i or %I for an array of symbols.", + "reference": "Since this may be the case, wondering if we should call the param `updated_at_i` or something so that we don't run into a problem distinguishing them down the road?" + }, + { + "prediction": "I think this should be `appExe = Path.Combine(workingDir, appExe);`", + "reference": "wondering why we need to join the paths here; seems evt.commandLine only takes whatever appExe is" + }, + { + "prediction": "`encodeServiceName = URLEncoder.encode(StringUtils.deleteWhitespace(serviceName), \"UTF-8\");`", + "reference": "1.not format code 2.failed but still continue? 3.\"UTF-8\" can changed to java.nio.charset.StandardCharsets.UTF_8.name()" + }, + { + "prediction": "This import is unused.", + "reference": "I'm wondering if we should add this to a `utils` module in `astroid`. Porting the util to `pylint` doesn't make sense as we would need to duplicate the globals that are being used in the function, but importing from `brain` also feels weird. @Pierre-Sassoulas Do you have an opinion?" + }, + { + "prediction": "I think this should be `if (_corruptedRequest || SocketInput.RemoteIntakeFin)`", + "reference": "This seems different than what we do for corrupted request headers. I would like to determine the correct behavior and consolidate this logic." + }, + { + "prediction": "I think this should be `backend.get('resourceGroup', backend.get('group'))`", + "reference": "Please make the change in the CAI inventory, rather than changing the scanner." + }, + { + "prediction": "This class should not be abstract.", + "reference": "adding this `abstract` is a breaking API change. Even though I agree it makes perfect sense to have it, we can't break this API until PMD 7.0.0. We should revert this particular change. We could make a reminder ticket like we did with #463 for 6.0.0" + }, + { + "prediction": "Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.", + "reference": "This is following the existing convention, but I'm not sure the convention is a good one. I think it would be better to have one shared example group: - It means we don't need to add new example groups twice every time. - If the shared example group looks large, that makes it more obvious that our team models have too much shared behavior. I don't want to do anything about this right now (I'm pretty sure I can wipe out this shared example group when I change team plans), but it's good to keep in mind." + }, + { + "prediction": "I'm not sure this is the right thing to do. If the address is IPv4, then it should be checked against the IPv4 limit, not the IPv6 limit.", + "reference": "I do not think we need to do a source code change to handle this. We could set the subnetwork to default to /32 (/128 for ipv6 ipv4-mapped)" + }, + { + "prediction": "\"Remove one cookie from remote\" -> \"Remove a cookie from a remote\"", + "reference": "It looks good overall! The only issue I have is that the description string is now duplicated twice right? Once in the struct and once in the parameter string? Maybe let's pass the struct to the command so that `ostree_option_context_parse` can set it as the summary? Similar to what we do in rpm-ostree." + }, + { + "prediction": "I don't think we need to make this public.", + "reference": "This states very clearly that this is a derivative of Chrome and not Chromium. Do we need to extract an abstract `ChromiumCommandExecutor` and have both Edge and Chrome derive from that?" + }, + { + "prediction": "`type0.getType().isEnum() || type0.getType() == java.lang.Enum.class` is equivalent to `type0.getType().isEnum()`", + "reference": "it seems to me, the issue lies on `isEnum()` itself, returning false for something that is an enum. I'd rather change it there than here." + }, + { + "prediction": "I think it would be better to have a `QuteSchemeHandler.registerHandler` method that takes a name and a function and adds it to the `handlers` dictionary. This way you can use `@QuteSchemeHandler.registerHandler('foo')` instead of `@QuteSchemeHandler.addHandler('foo')`.", + "reference": "Please use `{}` instead of `dict()`" + }, + { + "prediction": "I think we can remove the `useInView` import now that we're using `useInView` from `react-intersection-observer` directly.", + "reference": "I have concerns about using this in more places before #3278 - I'll take a look at that again shortly." + }, + { + "prediction": "why do we need this test?", + "reference": "new field needs to be asserted" + }, + { + "prediction": "I think this should be `self->logIdToSend_ = self->lastLogIdSent_ + 1;`", + "reference": "when send log failed, why update the last sent log id?" + }, + { + "prediction": "I think this should be `Tuple1` instead of `Tuple0`.", + "reference": "what was the problem with the previous order? `prepend` comes conceptually before `append`, i.e. `insert before` should be before `insert after`, I think" + }, + { + "prediction": "I think we need to add this to the `BackupInfo` struct in `pkg/apis/crd/v1alpha1/backupinfo_types.go` as well.", + "reference": "Why is this necessary? Could you provide some context?" + }, + { + "prediction": "I think this should be `UTF-8` instead of `utf-8`", + "reference": "Is there a recommended quote style for attributes? I see single and double here, double further down." + }, + { + "prediction": "I think this test should be in the `Close` test block.", + "reference": "Please use an atomic bool." + }, + { + "prediction": "I think this should be in the `WebHelpers` file.", + "reference": "Consider naming this class `SpanExtensions` to follow C# conventions." + }, + { + "prediction": "I think we can remove the try-catch here as well.", + "reference": "FYI @lucaspimentel and @colin-higgins since you have already approved, I wanted to point out this required change. By fixing `FrameworkDescription` to use the correct logger, it created a cycle between these two static constructors, so I'm removing this log line and delaying it to when it's actually constructed later in the Tracer. Let me know if you find that acceptable or have any suggestions." + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.", + "reference": "Ah, so we are going to need to update node/host files for this to work?" + }, + { + "prediction": "I think this should be `FINE` instead of `FINER` or `FINEST`.", + "reference": "This code is new and not tested well. While we may drop the log level before we ship 4.0, right now this is extremely helpful to users." + }, + { + "prediction": "Line is too long. [82/80]", + "reference": "used named path (`proposals_path`) instead?" + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to work.", + "reference": "Am I misreading something, or is there a mismatched parenthesis here? Please let me know whether or not this is cause for concern -- just wanted to be totally sure before merging, since I can't test this from here. Thanks!" + }, + { + "prediction": "I think this should be `yarpcerrors.InvalidArgumentErrorf` instead of `yarpcerrors.InternalErrorf`.", + "reference": "Might we want a hook to allow emitting metrics or logs in the case of a permitted empty service header response (or similar UpdateSpanWithErr on empty service header in response if strict enforcement is desired by the caller)?" + }, + { + "prediction": "I think this should be `kwargs[\"protocol\"] = kwargs.get(\"protocol\", \"https\")`", + "reference": "if using dict.get, this could just be `kwargs.get('protocol', 'https')`" + }, + { + "prediction": "I think this should be `getGrpcStreamingApiMethodName(interfaze, method)`", + "reference": "Add docs to the new methods here" + }, + { + "prediction": "I don't think we need this anymore.", + "reference": "what does it mean enabled?" + }, + { + "prediction": "`db.execSQL(\"PRAGMA rekey = '\" + newKey + \"'\");` should be `db.execSQL(\"PRAGMA rekey = '\" + newKey + \"'\");`", + "reference": "Getting an error when calling with db.execSQL (in sqlcipher 4.3.0, pragma returns ok)." + }, + { + "prediction": "I think this should be `ctxUser.DisplayName() + \" \" + ctx.Tr(\"dashboard\")`", + "reference": "Maybe we could remove `\" \" + ctx.Tr(\"dashboard\")` completely?" + }, + { + "prediction": "I think this should be `# Copies an object from one Amazon S3 bucket to another, changing the object's server-side encryption state during the copy operation.`", + "reference": "Simple Storage **Service**" + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to work. I'm not sure if there's a more idiomatic way to do this.", + "reference": "Let's add some assertions here to ensure we don't panic. Length of results. Conditionally cast second result to error." + }, + { + "prediction": "I think this should be `TimeSpan.FromMinutes(2)` to match the default for http.sys.", + "reference": "Where did we take this default from?" + }, + { + "prediction": "I think it would be better to have `compareStartDate` and `compareEndDate` as part of a `compareDateRange` object. This way we can add more options to the `compareDateRange` object in the future without having to change the function signature.", + "reference": "Let's move these down to be after all required arguments rather than in between." + }, + { + "prediction": "I think this should be `if (_sharedStringMap != null && _sharedStringMap.Count > 0) { _sharedStringMap.Clear(); }`", + "reference": "Should we just null the Map and let the GC handle the memory? Clearing just removes items, but not capacity, so this would leave some memory on the table." + }, + { + "prediction": "I'm not sure this is the right place to put the logger. I think it should be passed to the `newHandler` function, not to the `handler` struct.", + "reference": "did you mean to delete this line?" + }, + { + "prediction": "This should be removed before merging.", + "reference": "Should we use logger instead?" + }, + { + "prediction": "Style/BooleanLiteral: Prefer true over TRUE.", + "reference": "I think it would be preferred to do `expect(helper).to be_analytics`" + }, + { + "prediction": "I'm not sure this is the right thing to do. `pd.Index` is a subclass of `list`, so this will always be true. I think you want to check for `pd.Index` first, then `list`, then `tuple`, then `str`.", + "reference": "Actually, I think it's okay to just change to `if isinstance(key, (str)) or is_list_like(key):` and `key = list(key) if is_list_like(key) else key` for simplicity for now." + }, + { + "prediction": "Why is this empty? Shouldn't it be `currRunID`?", + "reference": "If there any other tests, I would make it optional there also." + }, + { + "prediction": "Line is too long. [89/80]", + "reference": "This can be removed too, right?" + }, + { + "prediction": "This should be `account.getTransportUris().get(0)`", + "reference": "If you're going to allow people to specify multiple SMTP servers, you should also properly export/import them." + }, + { + "prediction": "I'm not sure about the naming of these metrics. I think it would be better to have something like `runtime.dotnet.aspnetcore.connections.active` and `runtime.dotnet.aspnetcore.connections.idle` instead of `runtime.dotnet.aspnetcore.connections.current` and `runtime.dotnet.aspnetcore.connections.queue_length`. What do you think?", + "reference": "nit: Can we prefix these variables with `AspNetCore`?" + }, + { + "prediction": "I think this should be `yaml::conversion` instead of `yaml::conversion -m #{modulepath}`", + "reference": "Can this also include a quick test for transpiling by name?" + }, + { + "prediction": "I think we can remove the `Sessions` field from the `NodeStatsRequest` struct as well.", + "reference": "This TODO can be removed" + }, + { + "prediction": "I think this should be `tabAccessibilityIdentifier` to be consistent with the rest of the codebase.", + "reference": "can we make tabAccessibilityIdentifier = null as default?" + }, + { + "prediction": "I think we can remove the `handleErr` call here as well, since `bsp.Shutdown` is called before `exp.Shutdown`.", + "reference": "Should we print this error?" + }, + { + "prediction": "`multi_scores.size(1) - 1` should be `int(multi_scores.size(1) - 1)`", + "reference": "For which reason do we need to convert this to int here?" + }, + { + "prediction": "I'm not sure if this is the right thing to do. I think we should return an error if the freezer isn't supported.", + "reference": "FWIW, wondering if the error is interesting here (I actually arrived at this code initially to change `supportsFreezer()` to return a `bool`" + }, + { + "prediction": "Layout/ExtraSpacing: Unnecessary spacing detected.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInside", + "reference": "Does this still need to be a partial? is the intention down the line to move back towards a conditionally different title?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think we should be able to get the registry URL from the account ID and region, so we don't need to pass it in.", + "reference": "seems like `RegistryURL` is missing? Same for a few other places that create `archer.Environment` below." + }, + { + "prediction": "This import is not used in this file. Please remove it.", + "reference": "Are these imports needed?" + }, + { + "prediction": "I think we can remove the `if` statement and just use `target.actualNode.type !== 'text'` here.", + "reference": "I think you can remove the `(isIE11 ? it.skip : it)(` above, if you're going to skip the test this way." + }, + { + "prediction": "I think this should be `Long.reverseBytes(actualChecksumIn)`.", + "reference": "IMO we should instead fix the above call to do `long actualChecksumIn = Long.reverseBytes(in.readLong());` to get the actual checksum value? This way the below error message would also be correct?" + }, + { + "prediction": "I think this should be `DeleteFiles(gopts, repo, removePacksFirst, restic.PackFile, restic.IndexFile)`", + "reference": "I think we also need something similar for `rebuild-index`?" + }, + { + "prediction": "I think this should be 50000", + "reference": "I think convention is snake case for import naming?" + }, + { + "prediction": "I think it's better to use `tableInfo.getPrimaryKey().getColumns()` instead of `tableInfo.getPrimaryKey().getIndexColumns()`.", + "reference": "i think haspk is false?" + }, + { + "prediction": "Should this be `default:\"plz-out/surefire-reports\" description:\"Directory to copy XML test results to.\"`?", + "reference": "you should add this to the cover command too (but let's have a more general convo about whether it's a flag or config option)" + }, + { + "prediction": "I think we can remove the `&metrics.ClientConfig{}` here and just pass `nil`.", + "reference": "instead of passing in pointer to empty struct, we should make it optional and support passing nil and use default cfg if it is nil." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we want to be able to hash a pandas object, so that we can use it as a key in a dictionary, for example.", + "reference": "A fair bit faster, although still not great, hence also adding a hashkey." + }, + { + "prediction": "I'm not sure if this is the right place for this partial, but I think it makes sense to have it here.", + "reference": "If we're going to leave this in here, how about we at least pull it into partial?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get the tests to pass.", + "reference": "This `context` is used correctly, there is nothing left TO DO." + }, + { + "prediction": "I think we can remove the `toArray` here as well since we're not doing anything with the docs.", + "reference": "If `docs` is an empty array there will be an error" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think we need to add `quic` to the list of supported protocols.", + "reference": "Is it really necessary to have the user specify this, or can the reverse proxy infer QUIC from the upstream's Alt-Svc headers?" + }, + { + "prediction": "Why did you remove this?", + "reference": "just remove the entire variable." + }, + { + "prediction": "I think this should be `File.expand_path(moduledir, @options[:cwd])`", + "reference": "Maybe we should put that in the option description?" + }, + { + "prediction": "I don't think we need to change this method. We can keep it as it is.", + "reference": "Why do we need to make this optional? Isn't the idea of the builder that if you don't need this value you just don't call the `keyFilePath ` method?" + }, + { + "prediction": "I think this should be `MetricsConfig.forTable(table.schema(), table.properties())`", + "reference": "Shall we do the same for ORC and Avro?" + }, + { + "prediction": "nit: remove the extra backtick", + "reference": "Should be a space between line" + }, + { + "prediction": "I think this should be `SecureRandom.GetBytes(bytes, 0, bytes.Length);`", + "reference": "if not behind interface then equally we can use SecureRandom.GetBytes directly, otherwise let us push it behind ISecureRandom so we can test with this class wherever used" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Probably will undo this change for now, as I'm just targeting Weekly Iteration in this PR." + }, + { + "prediction": "I think we can remove this now.", + "reference": "Unused parameter warning? How comes we did not catch that before? In any case please open another PR for this." + }, + { + "prediction": "`gt_bboxes_group_of` -> `gt_labels_group_of`", + "reference": "I recommend move all openimage related logic to a new function" + }, + { + "prediction": "I think we should rename this to `IsExternalCgroup` to make it more obvious that it's a boolean.", + "reference": "We shouldn't have a bool for this. If there is a path passed, then we use it. Resource may or may not be empty." + }, + { + "prediction": "Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
", + "reference": "I like how you used the count on the translate call to handle this." + }, + { + "prediction": "I think this should be done in the `prepareDismaxQueryString` method of the `DismaxSearchHandler` class.", + "reference": "Do we need to do this from the outside, or is there a spot in the handler code where we can do this automatically? (I haven't studied it closely yet... just wondering if you've already thought it through or if it's worth taking a closer look)." + }, + { + "prediction": "Please remove this file. It's not needed.", + "reference": "[Checkstyle] INFO: Using the '._' form of import should be avoided - java.util._." + }, + { + "prediction": "I think it would be better to use `cliquet.cache.dummy` and `cliquet.storage.dummy` instead of `cliquet.cache.memory` and `cliquet.storage.memory`.", + "reference": "So, why everything is in memory but the permission backend?" + }, + { + "prediction": "I don't think we need to copy the list here.", + "reference": "Are you sure it should be null and not an empty List?" + }, + { + "prediction": "Should this be `Frameworks` instead of `Framework`?", + "reference": "Unfortunately I think the assumption of \"empty\" means the default dependency section is not correct. For a project.json file the default dependencies section is a shared section between all the different target frameworks and our TargetGroup being empty may map to many different target frameworks so they aren't really equated." + }, + { + "prediction": "I think this should be `not-localhost` and `not-value` instead of `localhost` and `value`.", + "reference": "This test was verifying the wrong thing." + }, + { + "prediction": "I think this should be `util.buildMuon('brave', buildConfig, options)` so that we can pass in the buildConfig and options to the buildMuon function.", + "reference": "pls pr a name change fro muon here too separately." + }, + { + "prediction": "I think this should be `opts.spinner.Stop(\"Error creating environment!\")`", + "reference": "nit: we can use `defer opts.spinner.Stop(\"Error!\")` after l.180 to make it slightly neater" + }, + { + "prediction": "I think this should be `if (ok && TEST(VM_DELAY_READONLY, area->vm_flags) && !TEST(VM_ALLOCATED_MEM, area->vm_flags)) {`", + "reference": "This is declared in the wrong block" + }, + { + "prediction": "`msg.Header:{%v},msg.Route:{%v}` -> `msg.Header:{%+v},msg.Route:{%+v}`", + "reference": "In fact it would be useful for debug, i prefer combine them into one debug level log." + }, + { + "prediction": "I don't think we need to add the \"per session\" here.", + "reference": "We would need to localize them eventually too, just FYI" + }, + { + "prediction": "I think this should be `proto->set_name(name());`", + "reference": "It looks like the proto code needs to change the function name from set_name to set_type to be consistent." + }, + { + "prediction": "I think this should be `github.com/aws/amazon-ecs-agent/agent/ssm/factory SSMClientCreator mocks/factory_mocks.go` instead of `github.com/aws/amazon-ecs-agent/agent/ssm/factory SSMClientCreator mocks/factory_mocks.go``", + "reference": "I think we can avoid using this pattern for this use case." + }, + { + "prediction": "This should be `#if defined(_POSIX_SPAWN) && !defined(__ANDROID__)`", + "reference": "Could you please change this to `#ifndef __linux__`? That's when we use our own implementation instead of `posix_spawnp`." + }, + { + "prediction": "I don't think this is correct. If we have 10 slots and maxSessionCount is 10, then this will return false.", + "reference": "Nit: put the `&&` on the previous line so that a reader knows that there's more to the statement at a casual glance." + }, + { + "prediction": "I think this should be `string(libkbfs.TLFPathType(t))`", + "reference": "Technically the \"right\" variables to use would be the ones in `libgit/autogit_node_wrappers.go\", which define how the tlf types map to subdirs for autogit specifically. (They would have to be exported.) But this is fine too I guess, just a little dirtier." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Should there be a template or something associated with this email? Right now it's identical to `notification_for_approver`" + }, + { + "prediction": "Please remove the empty line here.", + "reference": "i hope there is some extension in phpstan for this" + }, + { + "prediction": "I don't think this is correct. If `flagSep == -1` and `morphSep == 0`, then `sep == 0` and we should return 0.", + "reference": "We don't store empty dictionary entries anymore: they bring no benefits, only trouble." + }, + { + "prediction": "I think this should be `opts_.g_cpp_std >= cpp::CPP_STD_17 && opts_.scoped_enums && IsEnum(type)`", + "reference": "Optional: This function is C++ specific and could be declared as `static`." + }, + { + "prediction": "I think this should be `getRoles(String domainName, Boolean members, Optional tagKey, Optional tagValue)`", + "reference": "we can't remove functions as that would introduce backward compatibility issues in our java client. So we should also have a function with the original arguments: ` public Roles getRoles(String domainName, Boolean members) { return getRoles(domainName, members, null, null); } ` For the Go client we don't have a wrapper so no option but to update your client code as necessary, but for java we have the wrapper thus we always maintain backward compatibility" + }, + { + "prediction": "Style/TrailingWhitespace: Trailing whitespace detected.
Layout/SpaceAfterComma: Space missing after comma.", + "reference": "I'd recommend keeping this in `warn_deprecation` and not adding an override of `warn`." + }, + { + "prediction": "I'm not sure if this is the best way to do this. I think it would be better to have a `start` script in `package.json` that runs `blitz build` and then `blitz start`", + "reference": "I think we should use a `blitz` bin instead" + }, + { + "prediction": "I think this should be `if dataset._virtual_vdims is not None:`", + "reference": "Why not make the ``derived_vdims`` flag (or similar, ``validate_vdims`` maybe?) an explicit argument to ``validate``?" + }, + { + "prediction": "I think we need to return an error here if the volume is not a Pure FA volume.", + "reference": "was it not possible to do this at the filter or porx driver layer? We typically try to avoid driver-specific things in the SDK layer" + }, + { + "prediction": "Please remove this line.", + "reference": "please update the year. it can be setup in intellij template." + }, + { + "prediction": "I think this should be `passSlf4j(\"log.trace(message, arg1, arg2);\");`", + "reference": "what's the use-case for this?" + }, + { + "prediction": "I think this should be `TypeError('as_index must be a boolean; however, got [%s]' % type(as_index))`", + "reference": "nit: `as_index must be an boolean` -> `as_index must be a boolean`" + }, + { + "prediction": "I think this should be `upgrade` instead of `update`", + "reference": "What is the goal of that method ? And what are `$currentVersion` and `$newVersion` ? Are they Thelia or Module version ? :)" + }, + { + "prediction": "I think this should be `require('../../package.json').version`", + "reference": "Is there an advantage to this vs setting `this.version` in the constructor? Cleaner this way, at the top?" + }, + { + "prediction": "Why is this needed? Is it possible for the URL to have leading/trailing whitespace?", + "reference": "Fix for URISyntaxException." + }, + { + "prediction": "I think this should be `if routeUpd.Dst == nil || routeUpd.Gw == nil {`", + "reference": "Would be good to UT this case" + }, + { + "prediction": "I don't think we should disable these rules. I think it's better to keep them enabled and fix the issues they are pointing out.", + "reference": "Why we need to add this?" + }, + { + "prediction": "Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.", + "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." + }, + { + "prediction": "I think this should be `int64` as well.", + "reference": "This is ok to change since I believe that these were added just in main and not in public release." + }, + { + "prediction": "nit: I think it would be better to have this as an optional parameter, so that we don't have to change the signature of this function.", + "reference": "Not needed in this PR, just want to make sure people think about this (maybe make an issue)? This is a lot of strings in a row. It will be hard/impossible for someone reading the code to see that everything is in the correct position. I recommend creating a struct instead of passing seven strings in a row. A similar problem exists on most of the `MakeFoo(...)` style methods in this change." + }, + { + "prediction": "I think it would be better to have a single `WriteNotifications` method that handles both `ConfigurationNotifications` and `ToolNotifications`. That way we don't have to worry about the order in which they are written.", + "reference": "_jaw drops_ I would have sworn I wrote those lines. Good catch." + }, + { + "prediction": "I think this should be `axe._memoizedFns.forEach(fn => fn.clear && fn.clear());`", + "reference": "This needs to be tested." + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "I believe you're missing the comparison after 'be'" + }, + { + "prediction": "Why do we need to return ErrNotExist here instead of ErrAlreadyDeleted?", + "reference": "move 103~105 to in front of 97?" + }, + { + "prediction": "This import is not used.", + "reference": "Lots of unnecessary imports left in this file." + }, + { + "prediction": "I don't think this is correct. The descriptor may have been updated, but the binding may not have been updated. For example, a descriptor may have been updated in a secondary command buffer, but the primary command buffer may not have been submitted yet.", + "reference": "Does this actually produce different code?" + }, + { + "prediction": "I think this should be `node.getAttribute('onfocus') === 'this.blur()'` and `node.getAttribute('onfocus').indexOf('this.blur()') > -1`", + "reference": "This should account for whitespace. Simply putting `.trim()` on the attribute value should do." + }, + { + "prediction": "I think we can remove these two lines.", + "reference": "I don't think we need these. Simpler just to put `routetable.TargetType...` inline below." + }, + { + "prediction": "I'm not sure if this is the best way to detect S3 PUT bucket object requests, but it seems to work.", + "reference": "Nested if statement. You can merge both statements nested together to create one" + }, + { + "prediction": "I think this should be `Integer.parseInt(jdkVersion.split(\"\\\\.\")[0]) >= 9`", + "reference": "Nitpick: add a space after the comma. Also, we should consider that the format of the version could change in the future so we could get something that is not a parsable integer." + }, + { + "prediction": "I think it's better to use `EXPECT_EQ(ResultCode::SUCCESSED, engine->get(\"key\", &result));` instead of `EXPECT_EQ(ResultCode::SUCCESSED, engine->get(\"key\", result));`", + "reference": "For your reference in future, I sugguest to use the `ASSERT_*` family." + }, + { + "prediction": "This should be `#include `", + "reference": "no need to import `fmt/format.h` here since the `KimInit` class is derived from `Pointers`. Any class derived from `Pointers` can assumed that `lmptype.h`, `mpi.h`, `cstddef`, `cstdio`, `string`, `utils.h` and `fmt/format.h` are already included through `pointers.h`." + }, + { + "prediction": "I think we can remove this import as we are not using it.", + "reference": "Can we have prefix of `OPENEBS_IO` e.g.: `OPENEBS_IO_INSTANCE_NAME`" + }, + { + "prediction": "I'm not sure this is the right thing to do here. I think we should be able to get the root node for a folder branch.", + "reference": "Might as well fix these bare returns by making them `return errors.New(...` directly." + }, + { + "prediction": "I think this should be `org.hyperledger.besu.datatypes.Hash.EMPTY`", + "reference": "we can use import here" + }, + { + "prediction": "I'm not sure if we want to remove this. I think it's useful to know what service is making the request.", + "reference": "thx for removing these" + }, + { + "prediction": "I think this should be `RuntimeException(String.format(\"Failed to parse failures XML: %s\", sourceReport.getAbsolutePath()), e);`", + "reference": "I snuck this one in as well as checkstyle crashing (on files from resources) caused an unfinished xml to be written, and it wasn't obvious where that XML was" + }, + { + "prediction": "I think this should be `{\"good case2\", fmt.Sprintf(\"projects/%s/zones/%s/machineTypes/%s\", testProject, testZone, testMachineType), false},`", + "reference": "How is this different than \"good case\"?" + }, + { + "prediction": "I think this should be `services []string` instead of `services string`.", + "reference": "the last parameter name should be `serviceName` as is in the implementation" + }, + { + "prediction": "I don't think this is correct. The `*` at the end of the first line is part of the javadoc, so it should not be removed.", + "reference": "@ftomassetti - okay, this is a little meh." + }, + { + "prediction": "Why not just use `errors.New(\"os: not implemented\")`?", + "reference": "Note, changed initial capitalisation of this for consistency. Can do it the other way around too if that'd be better. :wink:" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "hey, aren't we supposed to be passing in two parameters here?" + }, + { + "prediction": "I think this should be `bitcore.Unit = require('./lib/unit').Unit;`", + "reference": "please keep alphabetical ordering :)" + }, + { + "prediction": "I don't think you need this import.", + "reference": "Selenium must compile against Java 6. Revert this line." + }, + { + "prediction": "Why is this empty?", + "reference": "what is that `\"\"`, the adapterType? can you add `\"\" /* adapterType */`... in other places as well... might be cleaner if it's a pointer or some varargs at the end but don't have any strong preference.." + }, + { + "prediction": "I think this should be `if (path === '_id' || (!_this.getValue(path) && pType !== 'boolean' && pType !== 'number')) {`", + "reference": "This check is a little odd, and will still mess up with empty strings `''` because empty string is falsy. Can we change this to `|| _this.getValue(path) == null`?" + }, + { + "prediction": "I'm not sure if this is the best way to do this. I think it would be better to just check if `tabIndex` is not `null` or `undefined` and then check if `isFocusable` is `true`.", + "reference": "Just a minor suggestion: If you `parseInt` when you access the attribute then you shouldn't have to do it twice in the ternary." + }, + { + "prediction": "I think this should be `if transport == 'ssh' || transport == 'winrm'`", + "reference": "This change in particular is strange. I'm not sure why it would now be necessary. The previous default would've been true, and the default behavior without a new net-ssh version should be unchanged." + }, + { + "prediction": "I don't think we should allow null here. I think it should always be `true` or `false`.", + "reference": "Why is that? Should be redundant as the default value exists." + }, + { + "prediction": "I think we should call this `DebugSimulateDataRace` to make it clear what it does.", + "reference": "Are all fields beginning with \"Debug\" automatically `;local` ? (I guess so, but just checking.)" + }, + { + "prediction": "I think this should be `UpdateNameMapping updateNameMapping()` instead of `UpdateNameMapping updateNameMapping()`.", + "reference": "While I think it makes sense to update the mapping programmatically, I don't see much value in exposing it as part of the table API. We want to keep the Table API small, so if we can handle this by using a separate API that consumes and produces JSON, then that is preferred. Also, we may have more than one mapping in the future, so keeping this decoupled also helps out for those use cases. For now, let's build a utility class to perform these updates. We can always add this to the public API later if we choose to." + }, + { + "prediction": "Why is this change necessary?", + "reference": "We would want ssmp to wake up every 3 seconds if there are no other requests to it and do some cleanup tasks. So, it is not clear why do you want to set this to 0." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in `getLLVMRuntimeType`.", + "reference": "Is this really necessary? I would expect these types to be included with the loop below." + }, + { + "prediction": "I don't think we need to reverse the byte array here. We can just use `BitConverter.ToInt64(bytes, 0)` and `BitConverter.ToInt64(bytes, 8)`.", + "reference": "You could do span and it's magic of typecast to int for better efficiency" + }, + { + "prediction": "I think this should be `cssRule.style.transform || cssRule.style.webkitTransform || cssRule.style.mozTransform || cssRule.style.msTransform || cssRule.style.oTransform || false;`", + "reference": "Looks like you've covered `-webkit-transform`, but what about `-ms-transform`?" + }, + { + "prediction": "I'm not sure this is the right thing to do here. I think we need to keep the original behaviour of notifying on the main thread.", + "reference": "Is there something missing from the message here?" + }, + { + "prediction": "I don't think we need to expose `rpc`, `RemoteScheduler` and `RPCError` in the public API.", + "reference": "Hmm, what does this syntax mean?" + }, + { + "prediction": "I think we can remove the `callerTypeAPI` argument here, since it's only used in the `getOrCreateWorkflowExecution` function.", + "reference": "should this be callerTypeTask?" + }, + { + "prediction": "Metrics/LineLength: Line is too long. [81/80]", + "reference": "Currently update is set as @plan.editable_by?(@user.id) Which one is the correct behavior? I can see a case for only owners/co-owners to be able to set visibility, test status, and other plan details" + }, + { + "prediction": "I think it's better to have it as a property, so that it can be easily changed in the future if needed.", + "reference": "Maybe make it configurable? Or store the actual level index in DB, making this binary search obsolete?" + }, + { + "prediction": "nit: remove empty line", + "reference": "Nit: this file doesn't need to change. Can you revert this to avoid git conflicts?" + }, + { + "prediction": "I don't think we need this dependency at all. `toggleMenu` doesn't depend on anything.", + "reference": "There's no reason for this to be a callback now technically but as per our tech decision, we want all handlers to use `useCallback` now" + }, + { + "prediction": "I think we should use \"LC\" instead of \"LO\" to avoid confusion with \"Logic\".", + "reference": "This isn't strictly part of this PR, but could you move `multiSigString` from `crypto/multisig.go` into this list of `HashID` values? Now that we have other things being hashed into addresses (specifically, these new logic addresses), it's important that the hash input for multisig addrs is domain-separated from logic addresses." + }, + { + "prediction": "I think this should be in `graphite/tests/__init__.py` so that all tests have access to it.", + "reference": "nit: you could have named it just \"TestCase\" (if django's TestCase was imported differently)" + }, + { + "prediction": "I think this should be `options[:page_ranges] = Array(options[:page_ranges]) if options[:page_ranges]`", + "reference": "the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here." + }, + { + "prediction": "I think we can remove the `synthetic_value` parameter as well since it's not used.", + "reference": "All the callers of `ExtractSomeIfAny`, always pass `true` to `synthetic_value`. Can we get rid of the extra argument?" + }, + { + "prediction": "I don't think we need to log the config file.", + "reference": "Better to use the absolute path." + }, + { + "prediction": "I think this should be called `ChannelExpiryBuffer` to be consistent with the rest of the codebase.", + "reference": "this is 16 hours, is that enough?" + }, + { + "prediction": "I think this should be `if err != nil {` instead of `if *err != nil {`", + "reference": "removing boilerplate. You could also add a `StartSpan` with varargs to inline string attributes." + }, + { + "prediction": "I think we can remove this function now that we have `GetEthContext` and `GetRollupContext`", + "reference": "Can you replace these single letter variables with full names?" + }, + { + "prediction": "Should this be `public Action PrepareRequest { get; set; }`?", + "reference": "At first I wasn't sure, but now I think I'm sold on making PrepareRequest an action over adding a state object to the context." + }, + { + "prediction": "I think this should be `preg_match('/^VuFind \\d+(\\.\\d+)*$/', $newConfig['Site']['generator'])`", + "reference": "Would it be too greedy to preg_replace `VuFind (\\d+\\.?)+` with `'VuFind ' . $this->to` anywhere in the string? This would update something like 'Finna (VuFind 7.1.0)' as well. Just a thought, please disregard if you'd like to keep it as is." + }, + { + "prediction": "`getCollection` can return `null` if the collection does not exist.", + "reference": "BTW for brevity, you can remove `getZkStateReader().` here and elsewhere since ZkController has a convenience method for the cluster state." + }, + { + "prediction": "I think we can remove this line and just use `CloseableIterable.empty()` in the `ManifestGroup` constructor.", + "reference": "If there are no manifests, then entries should be `CloseableIterable.empty()`, not the manifest iterable. That doesn't need to be closeable." + }, + { + "prediction": "This test class is empty, so it can be removed.", + "reference": "this class should be named `ArrayInitializationVerbosenessTest` to work" + }, + { + "prediction": "I think it would be better to raise an error if the value is not a hash or a string. This way we don't have to check the type of the value in the `normalize_log` method.", + "reference": "Do we want to allow users to disable `console` as well? The schema currently says that it only permits a hash for `console`." + }, + { + "prediction": "I think we can remove this now.", + "reference": "It would be very helpful to describe succinctly either inline or by linking to an issue going into depth why each test is not working. If we merge like this your knowledge of what is going on is lost and other people in the code need to do a ton of reading before understanding when/how/if we should unskip." + }, + { + "prediction": "I'm not sure if this is the best way to do this. I think it would be better to have a single `useEffect` that listens to `currentDataLoaded`, `previousDataLoaded`, `currentError`, `previousError`, `currentRangeData`, `handleDataError` and `handleDataSuccess`.", + "reference": "As this is a `useEffect` this could be a cause for concern! Note that `useEffect` re-runs when a dependency changes **not** when a dependency is truthy (the previous code does look a bit like it's expecting that)" + }, + { + "prediction": "I don't think this is the right way to do this. The `finalize` function should be called when the `world_comm_ptr` goes out of scope, not when the `lbann_comm` goes out of scope.", + "reference": "Should we be doing this with `make_unique` or something?" + }, + { + "prediction": "Line is too long. [82/80]", + "reference": "we don't want to set default values for this. Since it is the actual email, we want to make sure we are always passing in the `user` and `proposal` . we have a default value of `nil` for modifier because sometimes will update a proposal via `rails console` in which case there will be no recorded modifier." + }, + { + "prediction": "This import is not needed anymore.", + "reference": "Yes this import was in the wrong place, but should ideally be in the first list of imports (among `go/build`, `go/token`, etc.). You may move it there, or just revert this change as it's actually unrelated." + }, + { + "prediction": "I don't think we should change the name of this check. It's not really about unused variables, it's about variables that are not used in a strict way.", + "reference": "It's unnecessary to duplicate the `name`." + }, + { + "prediction": "I think this should be `if ($event->getForm()->has('unlink') && true === $event->getForm()->get('unlink')->getData() && null !== $event->getForm()->get('unlink')->getData()) {`", + "reference": "this was a mistake when adding phpstan strict plugin" + }, + { + "prediction": "I'm not sure if this is the best way to handle this. I think it would be better to have a flag on the `oldVNode` to indicate that it's a placeholder.", + "reference": "Nit: I think it should be `to handle` here." + }, + { + "prediction": "Please revert this change. It's not related to the PR.", + "reference": "Please don't make unrelated changes or let your tools make unrelated changes." + }, + { + "prediction": "why change the type?", + "reference": "`numAccounts` is a global variable (from `gochecknoglobals`)" + }, + { + "prediction": "I think this should be done in `PluginManager::removePlugin()` instead of `PluginManager::uninstallPlugin()`.", + "reference": "Is the ID correctly normalized at this point?" + }, + { + "prediction": "I don't think we need this. We have `NodeInfo` in `p2p` package.", + "reference": "if 0 is a special constant meaning \"no limit\" let's make it a constant and name it correctly :)" + }, + { + "prediction": "I'm not sure if this is the right place to call `runInventory()`. I think it should be called after `setPatchPolicies(resp.PatchPolicies)`.", + "reference": "Curious about the reason behind this change" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we want to store the block in both the online store and the offline store.", + "reference": "wait, i thought the cborstore was for state tree?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in `Package._materialize()`. That way, we don't have to worry about whether or not the key is a logical key or a physical key, and we don't have to worry about whether or not the physical key is a temp file or not.", + "reference": "This logic is now duplicated here and in `_delete_temporary_files`... Maybe do it all at once - find temp files, delete them, and fix the logical keys?" + }, + { + "prediction": "I don't think this is correct. The purpose of this method is to return the type of the response. If you don't care about the response type, then you shouldn't be implementing this interface in the first place.", + "reference": "How about name it with NullResponseTypeProcessor" + }, + { + "prediction": "Why is this check needed?", + "reference": "Maybe `Log::Fatal` here? `[LightGBM] [Fatal] Check failed: feat_is_unconstrained at ...` (and kernel death in case of Jupyter Notebook) seems to be not so informative and user-friendly." + }, + { + "prediction": "`_apply` is not a good name for this method. It's not applying a transformation to the data, it's filtering the data.", + "reference": "Not sure I like the name ``_apply``. Even though ``_process`` is supposed to process elements already, how about ``_process_element`` which processes elements, *excluding* Overlays/NdOverlays." + }, + { + "prediction": "I think this should be `node-role.kubernetes.io/node`", + "reference": "Let's use this constant when ASG is created as well (currently hardcoded)." + }, + { + "prediction": "I'm not sure what you mean by \"most unique values to least unique\"", + "reference": "Oh is `bucket` actually higher cardinality than `eventname`?" + }, + { + "prediction": "This import is not needed anymore.", + "reference": "You can't rely on QtWebEngine being available - but why do you need to import this here at all?" + }, + { + "prediction": "I'm not sure if this is the best way to do this. I think it would be better to have a list of all the packages that need to be included in the build, and then have py2exe iterate over that list and include all subpackages. That way we don't have to remember to update this list every time we add a new subpackage.", + "reference": "How did you determine these - and how can we be confident that nothing is missing?" + }, + { + "prediction": "I don't think we need to have separate sections for each of these. I think we should just have a single section called \"Resources\" or something like that. What do you think?", + "reference": "What is this page going to do that is different than the products index we already have?" + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.", + "reference": "Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else." + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "Is this intended to be here? Seems it belongs to a different PR." + }, + { + "prediction": "I think we can remove the `#if !NETCORE` now that we're targeting .NET Standard 2.0.", + "reference": "These changes, while harmless, were no longer needed with newer versions of System.Console thanks to @ianhays" + }, + { + "prediction": "I think this should be `except botocore.exceptions.ClientError as e: if e.response['Error']['Code'] == 'InvalidParameterException': logger.warning('Your AWS config is missing Region information, ECSTask requires a working config.')`", + "reference": "Umm... this isn't relevant to this PR" + }, + { + "prediction": "I think this should be `0x7FFFFFFF`", + "reference": "While All make some sense here it doesn't make a lot of sense in the SkipOnFramework context. I wonder if we really need to expose anything more here. You can just blindly use 0." + }, + { + "prediction": "I think we can remove this file as it's not used anymore.", + "reference": "Actually, this is not correct. Package `cmd/bee` doe snot have any notion of commands or even libraries used for them. It is as simple as possible, just calling the function from `cmd/bee/cmd` which actually implements commands." + }, + { + "prediction": "I think we can remove the `resetNamespace: true` from the `admin` route as well.", + "reference": "This change is causing tests to fail because users sits at `/app/users`, not `/app/admin/users`" + }, + { + "prediction": "This should be `null` by default.", + "reference": "Could you provide more information on what exactly each of those three options do?" + }, + { + "prediction": "nit: extra space after `get {`", + "reference": "Why this line break?" + }, + { + "prediction": "I think we can remove this line.", + "reference": "We're importing this twice with different aliases." + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to work.", + "reference": "We should avoid adding a pandera dependency to Dagster itself." + }, + { + "prediction": "I don't think this is the right way to add a new permission. You should create a new ObjectPermission and add it to the permissions array.", + "reference": "Can be replaced with `org.jkiss.utils.ArrayUtils#add`." + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "While we're here, this line (and a few others) should be `customThreadPool.submit(() -> IOUtils.closeQuietly(overseer);` I have no idea why we're creating a collection and a stream for a single object." + }, + { + "prediction": "I think this should be `if len(p.AzureDNS.ManagedIdentityClientID) > 0 || len(p.AzureDNS.ManagedIdentityResourceID) > 0 {`", + "reference": "Should these restrictions also be reflected in the API docs?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in the `ServeHTTP` method of the `errorHandler` middleware, which is invoked after the `ServeHTTP` method of the `requestHandler` middleware.", + "reference": "What about the request headers if someone uses `request_header`? :thinking:" + }, + { + "prediction": "I think this should be `--domain-filter=%s`, not `--domain-filter=%v`. `%v` is the default format specifier for `fmt.Sprintf` and will print the string representation of the object, which is not what we want here.", + "reference": "Verify that external-dns allows setting this parameter multiple times (that it's not \"last one wins\")." + }, + { + "prediction": "This should be `etc_hosts: {'host1.example.com': '10.3.1.5'}`", + "reference": "Maybe 2 host/ip values could be used in the example?" + }, + { + "prediction": "I think it would be better to use `Tracer.Instance` instead of creating a new instance here.", + "reference": "We're only testing `RateLimiter.Allowed(Span)`, so I think we can use a mock `ITraceContext` instead of a real `Tracer` or `TraceContext`." + }, + { + "prediction": "I'm not sure this is the right place to pass the callbacks to `build_model_from_prototext`. I think it would be better to pass the callbacks to `build_trainer_from_prototext` and then pass the trainer to `build_model_from_prototext`.", + "reference": "IMO, this is the wrong way to associate a model with a trainer... Why the string when you actually have a trainer object?" + }, + { + "prediction": "Why is this change necessary?", + "reference": "Wondering if we can directly put types here & for other similar ledger_processor items like rai::block_type::state" + }, + { + "prediction": "I think it would be better to keep the progress bar here.", + "reference": "As `DeleteFiles` is not only used for prune this function deserves its own file. Maybe something like `delete_files.go` or `parallel.go`?" + }, + { + "prediction": "This should be `:attribute \u5df2\u7ecf\u5b58\u5728\u3002`", + "reference": "It should be simplified character. `` -> ``" + }, + { + "prediction": "I don't think we need to have this interface at all. We can just pass `ParallelLevels` and `VisitAccounts` as parameters to `TrieWalker.Walk` method.", + "reference": "I am pretty sure it breaks the visitor pattern, visitor should have no knowledge about the structure of what it is visiting or control over visiting mechanism" + }, + { + "prediction": "`TreeMap` should be `TreeMap`", + "reference": "'A' instead of 'An' here" + }, + { + "prediction": "I'm not sure why this was changed, but I think it should be reverted.", + "reference": "Can you flip it back (here and in other places)? It is more natural to represent \"10 seconds\" as `10 * time.Second`." + }, + { + "prediction": "I think it would be better to have a separate test for this.", + "reference": "Why was this necessary? You should just use the `dask_classifier` defined below this. With this change, you'd only be doing the local predict on arrays each time, but we want to test on all of DataFrame, Array, and sparse matrix." + }, + { + "prediction": "I think this should be `@purchaseable.github_repo_url` instead of `@purchaseable.github_url` since we have a `github_repo_url` method in the `Purchaseable` model.", + "reference": "To me, this is sort of weird to have a completely separate page for this. Can we extract the different stuff (github, videos, downloads) presentation from the top of `app/views/purchases/show.html.erb` and reuse it on this page. I worry that we'll change things with fulfillment or copy and have to change it in multiple places." + }, + { + "prediction": "This import is not needed.", + "reference": "Please revert the lines above. Not touching unrelated code keeps the git history clean." + }, + { + "prediction": "Please change the version to `2.3.0`", + "reference": "`short_version` and `version_info`" + }, + { + "prediction": "I think this should be \"status\" rather than \"stats\".", + "reference": "This is supposed to be `status`. Why did you change this?" + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to work.", + "reference": "I will change all of these at some point next week." + }, + { + "prediction": "I think we can just remove this property. It's not used anywhere.", + "reference": "I made this change because, while trying to debug, in Visual Studio, the `IntegrationSignatureTests`, this property getter was hit and interfered with my ability to complete the debugging." + }, + { + "prediction": "I think this should be `model.KubernetesResourceState_UNKNOWN` instead of `model.KubernetesResourceState_OTHER`.", + "reference": "nit: `\"Unexpected error while calculating: unable to convert %T to %T: %v\"`" + }, + { + "prediction": "I think this should be `@JsonProperty(\"applicationName\")` to be consistent with the rest of the properties.", + "reference": "I'd actually recommend not putting this in the `SampleConfig`, it's intended more for properties that are inherent of the discovery format. Add a method `getSampleAppName(String apiTypeName)` to `SampleNamer` and override it in the language specific `SampleNamer`s if needed. Then assign it in the transformer." + }, + { + "prediction": "I think this should be `convertArrayToKeyedObjectMap`", + "reference": "Do we need to export these new functions? I thought the plan going forward was to keep util imports separated to make circular imports less likely and possibly do better chunk splitting. Since only new code references these files, we can scope the import to the specific files." + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "Rails will autorequire `acts_as_editable` once it encounters the constant `ActsAsEditable`. Thus if we move `ActiveRecord::Base.send :include, ActsAsEditable` from _acts_as_editable.rb_ to this file, the require line will not be needed anymore. Instead of requiring the file ourselves, we will let Rails do it for us. This fix will also remove the need to explicitly require `acts_as_editable` in _mock_active_record_base.rb_." + }, + { + "prediction": "I think this should be `@Nullable String getUpperCamelMethodName()`", + "reference": "I think we should name this `grpcMethodName` or similar. That is what this refers to, right? The fact that it is upper camel is an implementation." + }, + { + "prediction": "(style) Macros with multiple statements should be enclosed in a do - while loop", + "reference": "What if .. appears, but not as the first character, eg \"errors/../../../../../../../../../../../\"?" + }, + { + "prediction": "Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
", + "reference": "Thanks, this should make things a bit easier for people who pick up the codebase but aren't a `curation center`" + }, + { + "prediction": "Can we remove this?", + "reference": "why not removing it?" + }, + { + "prediction": "I think this should be `--tls-disable-host-verification` instead of `--tls-disable-host-verification`", + "reference": "same nit here: maybe word as - \"disables validation of the temporal cluster's server certificate\"" + }, + { + "prediction": "I think we can remove this line.", + "reference": "Nit: other statements use all caps for SQL reserved words. Should this be `SHOW TABLES`?" + }, + { + "prediction": "I'm not sure about this change. I don't think we should treat `.` and `:` as part of an identifier.", + "reference": "Do we need this? isLuaIdentifier() is used not only in extract_next_token() but also in extract_prev_toke(). I wonder whether the change for isLuaIdentifier() has an impact on extract_prev_toke() or not. If you are not sure, keep isLuaIdentifier() as is. If you are sure, could you write your conviction to the commit log." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think we need to set the MTU to 1420 for AKS to avoid fragmentation.", + "reference": "This line should actually be: `if c.KubernetesProvider == config.ProviderAKS && c.Wireguard.EncryptHostTraffic {` because we only need to tweak the MTU like this on AKS." + }, + { + "prediction": "I think this should be \"Name of the service.\"", + "reference": "Do we need to change this flag as well?" + }, + { + "prediction": "I don't think this is the right way to do this. The `fileset.dest` is the output file of the `concat` task, not the input file of the `concat` task.", + "reference": "Including the source twice here makes the filesize jump to 432kb. Is there any way to minimize repeating it?" + }, + { + "prediction": "`nameOrHandle` -> `handleOrName`", + "reference": "This should only be sent if the driver is speaking to a W3C conformant remote, so we need an if-condition check like we have in the Python bindings." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "Only one line of code? What a simple issue!" + }, + { + "prediction": "I'm not sure if this is the right thing to do. I don't think we want to limit the number of incoming tasks, we want to limit the number of tasks that are running at the same time.", + "reference": "Conceptual question: why do history and matching need throttler at all? Shouldn't throttling to be handled on FE only?" + }, + { + "prediction": "I think this is not correct. If the internalNetworkPolicy doesn't exist, it means that the CNP has not been processed yet, so we need to process it.", + "reference": "Would this be possible: `addCNP` has already processed the CNP to an internalNP, just hasn't added this internalNP to the `internalNetworkPolicyStore`. In this case, `reprocessCNP` will skip processing this CNP and `addCNP` will just add the \"old\" internalNP to `internalNetworkPolicyStore`." + }, + { + "prediction": "Metrics/LineLength: Line is too long. [121/120]", + "reference": "Minor: you can access `current_user` in here directly - don't need to pass it in. Unless you prefer passing it explicitly?" + }, + { + "prediction": "Layout/SpaceInsideBlockBraces: Space between { and | missing.
Layout/SpaceInsideBlockBraces: Space missing inside }.", + "reference": "What is the purpose of `&` on this line?" + }, + { + "prediction": "I think this should be `^[a-zA-Z0-9]{1,20}$`", + "reference": "See above, the `isValidWebDataStreamID` implementation from before is actually correct. What we need here instead is a new `isValidMeasurementID` function." + }, + { + "prediction": "I think this should be `c.Debugf(\"Error parsing remote leafnode's INFO: %s\", err)`", + "reference": "Should be an error... it is important for the admin of the server attempting to create the leafnode connection to see the error asap." + }, + { + "prediction": "I'm not sure if this is the right place to do this, but I think it would be better to do this in the `getSpeechTextForProperties` function, so that we don't have to worry about this in the `speakObjectProperties` function, and so that we don't have to worry about this in the `getSpeechTextForProperties` function.", + "reference": "Could you split these conditions up over multiple lines please." + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to work.", + "reference": "I think we can just change this to `Split` instead of `SplitN`. I don't think we need to limit the number of parts in the tag." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "So this is actually a mistake that I introduced without realizing it, and have known would need to be fixed when we get here . The format of the ports directive is \"host:container\". We only want the host port to change, not the internal container ports. The ports variable probably needs to be a map which maps external -> internal ports." + }, + { + "prediction": "Why is this needed?", + "reference": "An alternate approach would be to always initialize shardInfo with a dummy (non-nil) value, which could protect against other uses before it's initialized (I couldn't find any though). But I can change it to do it that way instead." + }, + { + "prediction": "I think this should be `LastWriter keybase1.UID` instead of `LastWriter keybase1.UID`", + "reference": "Maybe we can just put the entire `DirEntry` in here? I can imagine it might be useful for debugging to get the block ID/refnonce, encrypted size, key gen, data version, etc. What do you think?" + }, + { + "prediction": "I don't think this is correct. If the window is maximized, it should not be maximized vertically or horizontally.", + "reference": "For the commit message: The paragraphs seem to be out of order? The `Would not work because` refers to the stuff before, but there is a `This may seem pointless, but` in-between." + }, + { + "prediction": "I don't think we should remove these from the prelude. They are very useful.", + "reference": "Why did you remove these packages from the prelude, will your new functions not work without this change?" + }, + { + "prediction": "`kvKeys = std::move(kvKeys)` -> `kvKeys = std::move(keys)`", + "reference": "We'd better reserve enough space before using kvKeys to avoid extra malloc." + }, + { + "prediction": "I think this should be `if len(hostname) > 0 { return hostname }` so that we don't return `n.Name` if `KeyNodeHostname` is an empty string.", + "reference": "would it make sense to return empty or error if label doesn't exists?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get rid of the `ENOTEMPTY` error.", + "reference": "Don't penalize everyone with 250ms delay b/c some machines have problems." + }, + { + "prediction": "I think this should be `out = fmt.Sprintf(\"%s, %s\", out, it.Value().String())`", + "reference": "Probably want a space after the second %s?" + }, + { + "prediction": "I think this should be `serviceerror.NewNotFound(archiver.ErrHistoryNotExist.Error())`", + "reference": "This seems like an internal error still?" + }, + { + "prediction": "Line is too long. [82/80]
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", + "reference": "Line is too long. [94/80]" + }, + { + "prediction": "I think it's better to use `time.Time` instead of `int64` for the creation time of the antrea-cluster-identity.", + "reference": "out of curiosity, why creating another struct to wrap it?" + }, + { + "prediction": "I think you can remove the `.c_str()` here, it's not needed.", + "reference": "discipline vs. Discipline? Not sure of which is correct. Also not sure if there is already an existing string const." + }, + { + "prediction": "I think this should be `setProtoFile(protoFile)` instead of `setAssignedProtoFile(protoFile)`.", + "reference": "I believe this will break common resources, as they are defined in a common file, but must generate classes in service-specific namespace, so using protoFile to determine package of the generated class would not work, because common_resources namespace does not match service namespace." + }, + { + "prediction": "I think this should be `0` instead of `\"0\"`.", + "reference": "How about `SPARK_DEFAULT_SERIES_NAME`?" + }, + { + "prediction": "I think this should be `commit.status-checks.total-timeout-ms` to be consistent with `commit.retry.total-timeout-ms`", + "reference": "The other properties are in `commit.status-check`, not `commit.status-checks`. Could you remove the extra `s`?" + }, + { + "prediction": "I think it would be better to skip these tests in `test/integration/authentication.spec.js` as well.", + "reference": "Side note: I'd love to see more of these fields exposed on configuration." + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "In the case of accounts generated by API clients, what name gets put for the `inviter_name` or `invited_by` record?" + }, + { + "prediction": "I don't think you need to implement getStartBlock here.", + "reference": "I think this class is only relevant for updating the QbftConfigOptions based on the transitions config, so probably not." + }, + { + "prediction": "I think it should be `TracerTimeoutExceeded` or `TracerTimeoutExceededError`", + "reference": "what is the number thrown by Geth?" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "This would still crash on malformed database connection string like \"test\"" + }, + { + "prediction": "I think we can just use `context.WithValue(ctx, \"pluginName\", name)` instead of creating a new type.", + "reference": "it is not an interface, maybe we can move to another package?" + }, + { + "prediction": "`tableMeta` -> `meta`", + "reference": "Same here. Can we use `this.instance.getSettings()` to get `tableMeta`?" + }, + { + "prediction": "I think this should be `cgroup.Resources.CpuWeight != 0 || cgroup.Resources.CpuShares != 0 || cgroup.Resources.CpuQuota != 0 || cgroup.Resources.CpuPeriod != 0 || cgroup.Resources.CpuRealtimePeriod != 0 || cgroup.Resources.CpuRealtimeRuntime != 0 || cgroup.Resources.CpuMax != \"\"`", + "reference": "Not sure whether this validation is useful." + }, + { + "prediction": "I think it would be better to move this to `prompt.py` so that it can be used by other widgets.", + "reference": "Various things to note here: - Why would `question` ever be falsey (or `None`) here, i.e. why the `if question`? - Why would `question` ever not have that attribute? You set it in `Question.__init__`, so that check does nothing at all (and generally, `hasattr()` should be avoided if possible). - Why do you want to yank `None` (what does that do?) rather than e.g. show an error if there's nothing to yank?" + }, + { + "prediction": "Please remove this print statement.", + "reference": "If this is needed for testing, you should use `pytest --log-cli-level=INFO` instead." + }, + { + "prediction": "I think we can remove `IPDetectorURL` now.", + "reference": "We should drop ipify in all places i guess" + }, + { + "prediction": "I don't think we should change the names of the consensus params. We should keep them as they are.", + "reference": "Add explanations around these variables - what do they mean, how they should be configured, etc." + }, + { + "prediction": "Metrics/MethodLength: Method communities has too many lines. [21/20]", + "reference": "One thing tho - I would really appreciate any advice on where to move this to, so that it's called on initialisation of the website." + }, + { + "prediction": "I think this should be called \"Show gathered resources\" or \"Show resources gathered\" or something like that. \"Raw resources gathered\" is a bit confusing.", + "reference": "To much tabs here (1 tab)" + }, + { + "prediction": "I think we should use `LIMIT ?1` instead of `LIMIT ?` to make it more readable.", + "reference": "This is not maintaining retention time for logs as we are deleting only 1000 entries and we might end up with huge number of rows spanning over multiple months over a period of time if the cluster generates more rows as we are restricting ourselves to delete only 24k rows/day. Like I pointed out earlier a better would be to probably run this clean up every hour with some batch_size in a loop while there are records to be deleted(i.e older than 12 weeks) and committing each batch." + }, + { + "prediction": "I think you can just use `timestamp.DurationFromSeconds(1000)` instead of `timestamp.TimeNowPtrUtcAddSeconds(1000)`", + "reference": "I don't like this helper func :-). Yeah, definitely don't like." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "Same here. This should remain unchanged. Please, add it back." + }, + { + "prediction": "I think this should be `options.ignoreUndefined = this.s.options.ignoreUndefined;`", + "reference": "@kvwalker should this method have `ignoreUndefined` supported as an `option`?" + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to be the only way to get a `sugaredLogger` from a `zap.Logger`.", + "reference": "we dont use a `sugaredlogger` anywhere else in clutch, just curious why were using it here?" + }, + { + "prediction": "Why is this line removed?", + "reference": "Not evident from looking at this diff but the queue is already being cleared four lines below." + }, + { + "prediction": "I think this should be `t.Sender == transactions.CompactCertSender` instead of `t.Sender == transactions.CompactCertSender.String()`.", + "reference": "Why is this a 'transaction' and not in the block header?" + }, + { + "prediction": "Should this be `X509Certificate` instead of `X509Certificate2`?", + "reference": "This doesn't fit the abstraction level. Should we have a property bag for extra stuff?" + }, + { + "prediction": "I'm not sure if this is the right place to put this file. I think it should be in the `docs` folder, but I'm not sure if it should be in the `docs/source` folder or the `docs/source/docs` folder.", + "reference": "Looks like it is pretty easy to miss it when adding new files under `ci`. Hopefully, this doesn't happen too often." + }, + { + "prediction": "Why is this needed? I don't think we need to wait for the p2p service to be ready here.", + "reference": "do we really need the `Ready` call if startup fails midway?" + }, + { + "prediction": "`{0, network::NetworkUtils::getAvailablePort()}` -> `{0, network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils", + "reference": "You can avoid changing the code if there are parameter defaults. right ?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think we should be using `textContent` instead of `innerText` here.", + "reference": "I wonder why the newline disappeared here? I guess we'll merge and see how SauceLabs fares across the supported browsers." + }, + { + "prediction": "This should be `atoi(sep->arg[1]) != 0`", + "reference": "I know this is legal, but I prefer we put brackets on our calls" + }, + { + "prediction": "I think this should be `AWS Identity and Access Management (IAM)` instead of `AWS Identity and Access Management (AWS IAM)`.", + "reference": "AWS Identity and Access Management (IAM)" + }, + { + "prediction": "I don't think this is the right name for this exception. I think it should be `ElementClickInterceptedException`.", + "reference": "We keep who wrote the code anonymous." + }, + { + "prediction": "I think it would be better to use `! isUndefined( decimal.value )` instead of `! isUndefined( decimal )`.", + "reference": "Two things to make the code more error-proof and simplify it: 1. To be safe, this should be: `! isUndefined( decimal ) && ! isUndefined( decimal.value )` 2. The other clause that you changed below can be combined with that since `decimal` isn't used anywhere else, and so there's no point to re-check whether it's not undefined. In other words, this should become: `! isUndefined( decimal ) && ! isUndefined( decimal.value ) && 1000 > number`, and then you can remove the `decimal = decimal.value` assignment and replace it with line 146 (assignment of `readableNumber`)." + }, + { + "prediction": "I'm not sure this is the right place for this method. I think it should be on the `Dispatcher` interface.", + "reference": "Wouldn't composite outbounds compose the transport, such that it would still be represented as a single transport?" + }, + { + "prediction": "nit: remove empty line", + "reference": "nit: there is no need for a new line here, usually we tend to put an object creation and its deferred deletion next to each other. It helps not forgetting about the cleanup." + }, + { + "prediction": "I don't think it's necessary to add a new class for this. You can just use the existing `Request` object and add a new attribute to it.", + "reference": "Feel free to use the full notation with my email address: `Maxime Steinhausser ` :smile:" + }, + { + "prediction": "Why is this removed?", + "reference": "This was unused across the codebase" + }, + { + "prediction": "I think this should be an error, not a warning.", + "reference": "Should we put in which account we were trying to look up?" + }, + { + "prediction": "I think this should be `Supported_TypeClass = [RESOURCE, IAM_POLICY, GCS_POLICY]` instead of `Supported_TypeClass = [RESOURCE, IAM_POLICY, GCS_POLICY]`", + "reference": "either SUPPORTED_TYPECLASS or supported_typeclass. Camelcase only for class names." + }, + { + "prediction": "I think this should be called `is_pinned` to be consistent with the rest of the codebase.", + "reference": "This is not going to work. You need to add a migration to the database." + }, + { + "prediction": "I'm not sure what it does either. I think it's a bit of a misnomer. It's not resuming the group playback, it's resuming the playback of the group.", + "reference": "Should these methods be renamed in this PR?" + }, + { + "prediction": "I think it would be better to throw an exception here, so that the user is aware of the issue and can fix it.", + "reference": "we need to include the `metricStreamName` which is invalid, so users know whats causing the issue." + }, + { + "prediction": "I'm not sure if this is the right thing to do. I think we should load the assembly from the given path.", + "reference": "Please run Platform tests `DiaSessionTests`." + }, + { + "prediction": "I'm not sure this is the right thing to do here. I don't think we want to log a warning every time we see an AVX-512 instruction. I think it would be better to log a warning when we first see an AVX-512 instruction, and then set a flag so that we don't log any more warnings.", + "reference": "This is debug-build-only: we want a release-build notice. SYSLOG takes the name w/o the MSG and no _STRING. Args are via events.mc specifiers." + }, + { + "prediction": "I think this should be `if (options.directConnection || options.directconnection) { return callback(new MongoParseError('directConnection not supported with SRV URI')); }`", + "reference": "is it possible to have both forms here? I was hoping we wouldn't be introducing more cases where we had to check the upper and lowercase version of URI options." + }, + { + "prediction": "I think this should be `BenchmarkInt64HistogramAdd`", + "reference": "Does the name suffix hardcode something? Not clear how changing the name fixes this." + }, + { + "prediction": "I think this should be `getQueueProcessorThreadState` instead of `isQueueProcessorActive`", + "reference": "Is undispatched same as queued? getQueuedFlows?" + }, + { + "prediction": "I think this should be `Core Site data store: connection info tests.`", + "reference": "See above, same for all similar cases below." + }, + { + "prediction": "I'm not sure why we need to append the trace logs twice here.", + "reference": "Why is this done twice?" + }, + { + "prediction": "I'm not sure if this is the right way to propagate deadline to children nodes. I think we should only propagate deadline to children nodes when the deadline of the parent node is exceeded.", + "reference": "This sync can ensure that the condition of the child node is consistent with the parent node, but I still don't understand when the child will be overwritten, and this behavior is not what we expected?" + }, + { + "prediction": "I think this should be `DEBUG_TEST_FAILURES` (plural) to be consistent with the other debug flags.", + "reference": "This was renamed to avoid any confusion with the more general case of debugging via `plz debug`" + }, + { + "prediction": "I don't think this is correct. If `val` is a `String` and `prefixLength` is greater than the length of the string, this will throw a `StringIndexOutOfBoundsException`. If `val` is a `byte[]` and `prefixLength` is greater than the length of the array, this will throw a `StringIndexOutOfBoundsException`.", + "reference": "String valStr = (String)val; valStr.substring(0, Math.min(valStr.length(), prefixLength)) Make it clean." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the code generator.", + "reference": "Sorry, this still makes no sense.. the value of any union or enum is simply a name integer constant, it has nothing to do with the `BASE_TYPE_` enum. This value should be `0`. In particular: `Every union has the NONE field, which always has value 0`." + }, + { + "prediction": "I think this should be `getServerUrl()` or something like that. `getAzkabanURL()` sounds like it returns the URL of the Azkaban server, which is not necessarily the case.", + "reference": "Looks like getAzkabanURL() is added after concrete Alerter (Emailer)::getAzkabanURL(), so that Override annotation is needed." + }, + { + "prediction": "Why do we need to convert the mask to `bool` here?", + "reference": "The above 3 lines can be written as: `mask = segms[i].astype(bool)`" + }, + { + "prediction": "I don't think we need to import this package here.", + "reference": "File is not `gofmt`-ed with `-s` (from `gofmt`)" + }, + { + "prediction": "I think this should be an info message, not an always log.", + "reference": "Thought it's good to have this logged down so that we can check the used value in the logs." + }, + { + "prediction": "I don't think we need to make this optional.", + "reference": "I don't think you can call this optional unless it's a pointer - remove this?" + }, + { + "prediction": "This is not the right place to show this message. It should be done in the `onSendAllProducts` method of the `SendAllProductsTask` class.", + "reference": "@naofum please use `isEmpty`method instead" + }, + { + "prediction": "I think this should be `auto handle = std::move(nullable_handle).get();`", + "reference": "i think this is unrelated and needs to be reverted. need to discuss at sync." + }, + { + "prediction": "I think we can remove this interface and just use `org.hyperledger.besu.plugin.data.BlockHeader` directly.", + "reference": "Are we eventually moving those type interfaces from plugin project to datatype project? If not, then we'd have a dependency from core onto plugins, which seems a little counter-intuitive to me." + }, + { + "prediction": "I think this should be `await Promise.all(result)` so that we wait for all indexes to be created before returning.", + "reference": "Love how we can finally use async/await in the codebase." + }, + { + "prediction": "I think this should default to true.", + "reference": "Very minor: this line could be moved to a more narrow scope, inside `if (!representative.decode_account (representative_text))` Other than that, LGTM" + }, + { + "prediction": "I don't think we need this field anymore.", + "reference": "when is this consumed? I'm probably missing it but I can't find it right now" + }, + { + "prediction": "I think this should be `cwa += \" rollup:\";`", + "reference": "I think we also need to add the rollupGroupExprList() to the cache key. If we rebuild the list above from a ValueIdSet on line 418 above, it is probably going to be in the same order, regardless whether it was ROLLUP(a,b) or ROLLUP(b,a)." + }, + { + "prediction": "I think we can remove this import.", + "reference": "can use `getParamTypeName` instead" + }, + { + "prediction": "I think this should be `if ($this->request->isXmlHttpRequest() && $this->request->query->has('property') && $this->request->query->has('newValue')) {`", + "reference": "Why send the parameters? They're accessible directly from `$this->request` so there's no need to inject them in the method" + }, + { + "prediction": "I think this should be `if handler == \"default\": return super().chooseFile(parent_frame, suggested_file)`", + "reference": "Tiny nit: I would prefer `not selected_file` or `len(selected_file) == 0`, as if choose_file starts returning, for example, tuples instead of lists, this won't break." + }, + { + "prediction": "I think this should be `if err != nil && !os.IsNotExist(err) {` so that we don't remove the file if it doesn't exist.", + "reference": "How will this code behave with hostnames that contain hyphens?" + }, + { + "prediction": "I think this should be `kegg = kegg.Trim().ToUpperInvariant();` so that we don't have to worry about the case of the KEGG ID.", + "reference": "I think this is redundant since \"NullForEmpty\" already calls \"Trim()\"." + }, + { + "prediction": "I think this should be `CloudBackupGroupID` to be consistent with the rest of the API.", + "reference": "Change this to IDs too?" + }, + { + "prediction": "This should be a `Set` not an `ImmutableSet` since you're adding to it later.", + "reference": "private static final, and it should be located in raidsoverlay, as it's not needed in the plugin. also the name could be a bit better, DC_SCOUT_RAIDS or similiar." + }, + { + "prediction": "(style) line over 80 characters", + "reference": "attr_value is 128 bytes?" + }, + { + "prediction": "I think it's better to use `self.method = self.method.upper() if not has_variable_pattern(self.method) else self.method` instead of `if not has_variable_pattern(self.method): self.method = self.method.upper()`", + "reference": "if it's unpredictable - why uppercase it at all?" + }, + { + "prediction": "Please remove this line.", + "reference": "Please remove all these debug prints. It doesn't look good." + }, + { + "prediction": "I think this should be `SampleChainRandomness(height *types.BlockHeight) ([]byte, error)`", + "reference": "Consumers of this interface should not be required to provide `sampleHeight`. This should be an expected consensus parameter." + }, + { + "prediction": "I think this should be `if closeTime.Before(startTime) || closeTime.Equal(startTime) {`", + "reference": "I don't believe this is the right fix. If startTime comes after closeTime, then it means some other event triggered invocation of this code path like workflow timeout. In this case we should still try to fire the cron on previous value so we should just return start the delta between startTime and closeTime immediately." + }, + { + "prediction": "I think this should be `StatusFilter *CloudBackupStatusType` so that we can distinguish between an empty filter and a filter with a value of `CloudBackupStatusTypeUnknown`.", + "reference": "Not sure if we need tag here, it is an implementation detail in portworx that isn't exposed in openstorage" + }, + { + "prediction": "The backticks are not needed here.", + "reference": "I wonder if it would be cleaner to refactor all of this similar to the SolrMarc driver, so we have a property with Summon field names associated with types, and we iterate through it in a loop... that way we don't have to repeat the loop code four times with different variable names." + }, + { + "prediction": "I think we can remove the `SolrClientCache solrClientCache = searcher.getCore().getCoreContainer().getSolrClientCache();` line and just use `searcher.getCore().getCoreContainer().getSolrClientCache()` in the `createCloudSolrStream` method.", + "reference": "Need the `solrClientCache.close();` further down in the method be removed since a shared cache is now used?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `ClusterMetadataRow` struct.", + "reference": "according to the PR (schema changes?) these 2 field should be removed?" + }, + { + "prediction": "I think we can remove the `if exp.Target.StressChaos.ContainerName != nil {` and `chaos.Spec.ContainerNames = []string{*exp.Target.StressChaos.ContainerName}`", + "reference": "Panic here if `exp.Target.StressChaos.CintainerName` is nil." + }, + { + "prediction": "I think it would be better to call this method `getFilteredIterator` or something like that. `filterIterator` sounds like it's going to filter the iterator, but it doesn't.", + "reference": "This allows for some hacks like returning an iterator that matches more docs than the scorer. I liked the previous approach that returned an iterator better." + }, + { + "prediction": "I think we should use `LOG.trace` here.", + "reference": "Aren't there already logs for this from the underlying file system implementation?" + }, + { + "prediction": "This test should be updated to reflect the new `DismaxMunge` key.", + "reference": "It would be good to have a test in here that demonstrates the new munge functionality; I can help set that up if you're not sure how." + }, + { + "prediction": "I think this should be called `max_retries_to_get_pods`", + "reference": "`retrials` isn't the word you intend. I think you mean `retries` and to that end, can the var name just be `max_retries`?" + }, + { + "prediction": "`Value in product it should contain 255 characters or less.` -> `Value in product should contain 255 characters or less.`", + "reference": "Value in product should contain 255 characters or less." + }, + { + "prediction": "Why do we need to change this?", + "reference": "line is 133 characters (from `lll`)" + }, + { + "prediction": "Style/TrailingCommaInArrayLiteral: Avoid comma after the last item of an array.", + "reference": "since we're calling the file .rspec-local, I think we should rename local_options to project_options and use local_options for .rspec-local - WDYT?" + }, + { + "prediction": "Style/MutableConstant: Freeze mutable objects assigned to constants.", + "reference": "Will we want to refactor this when we drop rsolr 1.x support?" + }, + { + "prediction": "I'm not sure this is the right thing to do, but I think it's the best we can do for now.", + "reference": "should this really be multiple IPs?" + }, + { + "prediction": "Extra backticks may cause rendering issues.", + "reference": "Hmm, is that partial used in multiple places? Maybe we can just move that file in here." + }, + { + "prediction": "This should be `go:generate mockgen.sh github.com/aws/amazon-ecs-agent/agent/async Cache mocks/async_mocks.go`", + "reference": "Should be 2014-2016" + }, + { + "prediction": "I think this should be `if (value.StartsWith(quote, StringComparison.Ordinal) && value.EndsWith(quote, StringComparison.Ordinal))`", + "reference": "Looks like my fault for sure in trying to handle international inputs regardless of locale. I think the correct fix is actually to get rid of TrySplitColumns and use ParseDsvFields instead. It is what gets used in the end, and it already has logic for dealing with quoted fields." + }, + { + "prediction": "I think this is not needed.", + "reference": "similarly here, are the these cursors not being closed when the client is closed?" + }, + { + "prediction": "I'm not sure if this is the right way to do it, but I think we need to pass the name of the policy as an argument to the function, so that we can use the same function for different policies.", + "reference": "Or maybe `func(args ...string) Policy` to make it dynamic in case of any future policy that may require more than one args." + }, + { + "prediction": "I'm not sure this is the right place to do this. It seems like it should be done in `MakeDiskBlockCacheIfNotExists`.", + "reference": "Should this happen even if the above failed?" + }, + { + "prediction": "Please revert this change. It is not required.", + "reference": "Please dont change this ." + }, + { + "prediction": "I think this should be `node.logger.try_log (boost::str (boost::format (\"Election erased for root %1%, confirmed: %2%\") % election.qualified_root.to_string () % election.confirmed ()));`", + "reference": "There is a strange $b that looks wrong." + }, + { + "prediction": "I'm not sure this is the best way to do this, but it seems to work.", + "reference": "Is it still important to have `speakEntry` here? It is checked before this value `containerContainsText` is used in the \"General\" section." + }, + { + "prediction": "I think this should be `sh.export 'PATH', '$JAVA_HOME/bin:$PATH'`", + "reference": "It is `$JAVA_HOME/bin`, not `$JAVA_HOME`, which should be added." + }, + { + "prediction": "This should be `#include `", + "reference": "Should move this to within the `#else` block as it's only used there." + }, + { + "prediction": "Why do we need to wait here?", + "reference": "is this a common rule to wait one extra second after ajax? I'm thinking about moving this extra wait into waitForAjax method." + }, + { + "prediction": "I don't think we need to unset the logger here.", + "reference": "Maybe you can correct the typo \"if\" too :)" + }, + { + "prediction": "I'm not sure this is the right place to put this. I think it should be in the `ChatService` interface, since it's related to chat.", + "reference": "I'd prefer a name less chat-specific, since later on we could have other app types that want the same behavior. Maybe `IdentifyAndAllowTrackBreaks`?" + }, + { + "prediction": "I think this should be `throw std::runtime_error(\"ERROR: mpi4py not loaded correctly\\n\"); /* Python 2.X */`", + "reference": "I think I was involved in writing that caster, but I never fully understood the `import_mpi4py` thing. Why is importing mpi4py still necessary at that point? I would think if the user is passing a communicator from python code, they must already have imported mpi4py themselves, or does that not propagate through into the wrapping layer?" + }, + { + "prediction": "I think you can remove the `defer resp.Body.Close()` here since it's already deferred in the `gzip.NewReader` call below.", + "reference": "This seems like a more interesting change. Maybe we should re-name the PR" + }, + { + "prediction": "I'm not sure if this is the right place to put these features, but I think it makes sense to have them in the same place as the other transport features.", + "reference": "Nit: implement the methods for these interfaces explicitly in this file for consistency. It can be passthrough." + }, + { + "prediction": "I think this should be `.callName(\"\")` instead of `.getCallName(\"\")`", + "reference": "Not directly related to your PR, but I think here we should create a Type enum (MAP, ARRAY, PRIMITIVE) instead of having 3 flags." + }, + { + "prediction": "I think this should be `NABoolean isFirstBatch = true;` so that the first time through the loop, the `isFirstBatch` flag is set to `true`.", + "reference": "Do you want this to be a stack variable? The work method might return at any time (example: when the parent queue fills up) and then get called again, which would cause this variable to become false again. I'm wondering if this variable should be a member instead?" + }, + { + "prediction": "schemaEdgesPrefix -> schemaEdgesKey", + "reference": "You could reserve a const space to save the extra computation." + }, + { + "prediction": "I think it would be good to have a test case for each of the following: 1. A path with no redundant segments 2. A path with redundant segments 3. A path with redundant segments at the beginning of the path 4. A path with redundant segments at the end of the path 5. A path with redundant segments in the middle of the path 6. A path with redundant segments at the beginning and end of the path 7. A path with redundant segments at the beginning and middle of the path 8. A path with redundant segments at the middle and end of the path 9. A path with redundant segments at the beginning, middle, and end of the path", + "reference": "Did you consider adding rooted paths like `C:\\ProgramData` and paths with flipped separators?" + }, + { + "prediction": "I don't think this is correct. The defer should be after the `if err != nil {` block.", + "reference": "does this line cause a panic if it is above the if condition ?" + }, + { + "prediction": "I think this enum is not necessary. You can just use the `String` values directly.", + "reference": "Maybe `LibraryDetailsPanelType` would be clearer." + }, + { + "prediction": "I think this function is unused now.", + "reference": "minor nit - add \"persist-filesystem\" and \"persist-directory\" into commit message, as its something people may search on (maybe applies to a few other commit messages)" + }, + { + "prediction": "This is not used anymore.", + "reference": "I verified offline with @jeremyg-lunarg this should be removed." + }, + { + "prediction": "I think this should be `i.Workflow.Name, \" timeout:\", i.Workflow.DefaultTimeout`", + "reference": "This should be removed? If not, typo in incldued_wf" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "Sorry for the delay on this! It looks like Circle CI isn't running tests on some of the PRs, but this doesn't look like it would work I might be missing something, but are the tests all passing locally?" + }, + { + "prediction": "I think this should be `SplitPaths` to be consistent with the other fields in the struct.", + "reference": "Do you think the godoc should mention that all delimiters will be suffixed with `/`?" + }, + { + "prediction": "I think this should be `aURL.startsWith(\"data:\") && SessionStore.get().isCurrentSessionPrivate() && !SessionStore.get().isHomeUri(aURL)`", + "reference": "what if I want to load my own, a different, data URI in Private Browsing mode? I do this often on desktop (e.g., `data:text/html,×`). admittedly, I wouldn't expect this to be done by a non-developer, but this will certainly cause a minor bug." + }, + { + "prediction": "I think this should be `long minSequenceNumber = Long.MAX_VALUE;`", + "reference": "I remember the sequence number 0 is kept for the data files for iceberg v1, so in theory the sequence number from delete files should start from 1. So setting it to 0 as the default value sounds correct." + }, + { + "prediction": "I'm not sure about this change. I think it's better to keep it as `unsigned integer` to avoid negative values.", + "reference": "For all these MYSQL queries unsigned is required. I have tested again and without unsigned these queries are failing." + }, + { + "prediction": "I think this should be `MAX_HISTORY = 200;` instead of `const MAX_HISTORY = 200;`", + "reference": "Are there tests for this? What happens when you get to limit?" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we want to default to `local` if the transport isn't set, but I don't think we want to default to `local` if the transport is set to `winrm` and the target is `localhost`.", + "reference": "Whole thing could be collapsed to `data['config']['transport'] ||= 'local' if target.name == 'localhost'`." + }, + { + "prediction": "I don't think you need to pass the intent here. You can just call `getSignKeyId()`.", + "reference": "maybe throw in `&& mServiceConnection.isBound()`, there are cases where the connection might die" + }, + { + "prediction": "I think it should be true.", + "reference": "Can we add Istanbul with this first EIP please? (or as a separate issue)" + }, + { + "prediction": "I'm not sure if this is the right thing to do. I think we should return an error if we can't get the current user.", + "reference": "I don't understand this change" + }, + { + "prediction": "I think this should be \"Invalid public key\"", + "reference": "Let's allow translators for this string to be translated: `self.show_warning(_('Invalid Public key'))`" + }, + { + "prediction": "I think this should be `if (!role && (parent.tagName.toLowerCase() !== 'form') && (parent.tagName.toLowerCase() !== 'body')) {`", + "reference": "This needs to work with `role=form` too." + }, + { + "prediction": "I think this should be `if (localConnection && localConnection.type == Blockly.OUTPUT_VALUE) {`", + "reference": "This should be before the if on line 1028, which should turn into an else if" + }, + { + "prediction": "I think this should be `[]metav1.LabelSelectorRequirement` instead of `*[]metav1.LabelSelectorRequirement`", + "reference": "Not really introduced by this PR, but I don't recall why these have to be pointers, while `PodSelector` / `NSSelector` do not. Do you know the reason?" + }, + { + "prediction": "I think this should be `sample >= r.minRTT + ackDelay`", + "reference": "Is there a reason why we are ignoring the ackDelay if it would result in a value smaller than the min? Why not `max(sample - ackDelay, minRTT)`?" + }, + { + "prediction": "Why is this internal?", + "reference": "Here's an example of how the files in the `NotYetGenerated` directory drifted out of sync from the generated files. When we made the equality comparers internal, we neglected to fix this one." + }, + { + "prediction": "I'm not sure if this is the right place to put it, but I think we should add a `can_view_guidance?` method to the `UserPolicy` and use it here.", + "reference": "nice. we should do this elsewhere too. We have a lot of repeated stuff in the policies" + }, + { + "prediction": "I think this should be `TEST_ERRORS_1(src, \"can't find declaration of 'y'\")`", + "reference": "Small formatting thing, but can you remove the space before the semicolon?" + }, + { + "prediction": "I think this should be `long remaining = InnerLoopCount * (long)_writeLenght;`", + "reference": "Not new, but nit: _writeLeng*th*." + }, + { + "prediction": "I think this should be `CheckDockerCompose` instead of `CheckDockerComposeV2`", + "reference": "Our habit is to go ahead and put a description line (or more) in front of every function, not just non-test or exported functions." + }, + { + "prediction": "nit: remove empty line", + "reference": "Remove this file from the PR" + }, + { + "prediction": "I think this should be `newName.indexOf(Blockly.Variables.CLOUD_PREFIX) == -1`", + "reference": "I think that for cloud variables, the default value in the prompt should be the variable name without the cloud prefix; this is slightly different from the scratch 2.0 behavior, but I think would ultimately lead to less confusion. Proposing code changes below:" + }, + { + "prediction": "This should be `libinput_device_config_tap_get_finger_count(libinput_dev) > 1`", + "reference": "I think I would rather fish this interface through than use it as the basis for heuristics." + }, + { + "prediction": "Remove the extra space at the end of this line.", + "reference": "Probably not worth making this line-ending change, since it is the only change to this file." + }, + { + "prediction": "I think this should be `CLIENT_ASSERT(opnd_size_in_bytes(OPSZ_CACHE_LINE) == 64, \"OPSZ_CACHE_LINE != 64\");`", + "reference": "Is this the correct place for this assert? Does this routine rely on it being 64, or was this only for testing?" + }, + { + "prediction": "I think it's better to use `github.com/sonm-io/core/proto/hardware` instead of `github.com/sonm-io/core/proto`", + "reference": "No pb please" + }, + { + "prediction": "Align the parameters of a method call if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "We need to add indexes here on both `subscriber_id` and `changeset_id` or things will quickly collapse as we build up subscribers ;-) What I would suggest is a unique index on `[:subscriber_id, :changeset_id]` which will also make duplicate entries impossible, and an ordinary index on `[:changeset_id]` for finding the subscribers to a changeset." + }, + { + "prediction": "I think this should be `github.com/openservicemesh/osm/pkg/slackbot`", + "reference": "use the context versions of everything, e.g. `PostMessageContext` and thread it through the functions. will save you a bunch of refactoring trouble later on." + }, + { + "prediction": "I don't think this change is correct. The docstring should describe what the function does, not how it does it.", + "reference": "\"not to be used elsewhere other than\"" + }, + { + "prediction": "I think this should be `.setAll(properties)` instead of `.setAll(properties).setAll(properties)`", + "reference": "Thanks for the contribution, @coolderli ! I also think the newPosDeleteWriter need the properties setting ..." + }, + { + "prediction": "Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.", + "reference": "These additions seem unrelated to this change?" + }, + { + "prediction": "I think this should be `iceberg.engine.hive.enabled` instead of `engine.hive.enabled`", + "reference": "Could we move this to a class for Hadoop configuration properties, like `org.apache.iceberg.hadoop.ConfigProperties`?" + }, + { + "prediction": "Why do we need to remove this?", + "reference": "The related statements should also be deleted." + }, + { + "prediction": "Should this be `params[\"PolicyNames\"] = None`?", + "reference": "Shouldn't this line be removed?" + }, + { + "prediction": "I think this should be `return username.upper() in bad_names` so that it's case-insensitive.", + "reference": "Just move this into `const.py`. It already has similar stuff. Also, make it uppercase since it's a const." + }, + { + "prediction": "I don't think this is necessary. `newMode` will be set to `PasscodeMode.Check` in the `else` block below.", + "reference": "Issue is that `currentMode = newMode;` is called at the end of the method. Passcode screen will come up, but since the activity thinks current mode is biometric check we don't check passcode when submitted." + }, + { + "prediction": "why change this value?", + "reference": "Need change it back?" + }, + { + "prediction": "Trailing whitespace detected.", + "reference": "Didn't we delete this file a while back because it isn't used but people think that it's a security vulnerability that it's checked in?" + }, + { + "prediction": "I think we can remove this line.", + "reference": "nit: Looks like this can be removed now" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we need to keep the default CA around, but I'm not sure if we need to keep it in the `p.CAs` map or not.", + "reference": "Can probably remove the lines above it too (L60-62), since ProvisionDefaultCA() makes sure the map isn't nil." + }, + { + "prediction": "I don't think this is necessary. `h2o_config_register_status_handler` is called only once per `conf->global`.", + "reference": "Do you think it's worth erroring out? It's likely that this is a configuration error that the user might want to know about?" + }, + { + "prediction": "I don't think this is a valid test case. The `# +1: [fixme]` line is indented by 4 spaces, but the `# +1: [fixme]`` line is indented by 8 spaces.", + "reference": "I think the functional test should not change here, this is probably a test in itself :)" + }, + { + "prediction": "I think this is not necessary, we can just call `BuildSanitizer` when we need it.", + "reference": "Why this to be a public function?" + }, + { + "prediction": "I don't think we need to disable timing here.", + "reference": "I think we can remove the timing for export env vars" + }, + { + "prediction": "I think it's better to keep the `config.EndpointSliceHandler` and `config.NodeHandler` in the `Provider` interface, and move the `Run()` and `GetServiceByIP()` to a new interface.", + "reference": "wrong import grouping" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "There is a doubled semicolon ;)" + }, + { + "prediction": "This should be `#include `", + "reference": "I'm wondering why this isn't . Seems like one would have to copy the md5.h file into the source tree somewhere for this to compile cleanly. Maybe you meant to use angle brackets instead of quotes?" + }, + { + "prediction": "`visibility_of_any_elements_located` -> `visibility_of_at_least_one_element_located`", + "reference": "shouldn't **call** return a boolean?" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but I think it would be better to do this check in the `CastSpell` function of the `NPC` class. This way, you don't have to worry about whether the caster is a client or an NPC, and you don't have to worry about whether the caster is casting a spell from the spell bar or not.", + "reference": "We don't need to cast to client here. (well, from spell gem not AA etc) We should also make sure the charm is a casted spell before calling SendSpellBarEnable." + }, + { + "prediction": "I think this should be `Column(String(256))` instead of `Column(DateTime())`", + "reference": "This is not an `id`. This should either be `invocation_time` or `invocated_at` to be consistent with what we are using elsewhere, and also to better rerflect the column's DateTime type. Also, within the context of this table, there is no idea of what `invocation` is. I know that `scanner` may not be future-proof, but we need to find something more descriptive. Perhaps one possibility is to call this `audit_time`." + }, + { + "prediction": "I think this should be called `GetDestinationAddress` or `GetRecipientAddress` or something like that. `GetReceiverAddress` sounds like it's for the receiver of the transaction, not the destination of the transaction.", + "reference": "should the 'Receiver' be the clawback address in case of clawback transaction?" + }, + { + "prediction": "I think this should be `volumeStatusOK` instead of `volumeStatusOk`", + "reference": "@ashishranjan738 -- Where are these consts used? in which pkg?" + }, + { + "prediction": "I think this should be `['Python-API.rst']`", + "reference": "The only change I would suggest is moving these lines back below the `templates_path` variable to keep the diffs smaller." + }, + { + "prediction": "I'm not sure why this change is necessary, but it seems like it should be.", + "reference": "Having it above kept the block info in the cached changes, which could end up confusing things quite a bit." + }, + { + "prediction": "I'm not sure this is the best way to do this, but it's the only way I could think of to get the `task_name` and `options[:task_options]` to the `execute_task` method.", + "reference": "If the execute_task returns an `ExecutionResult`, the passing of a block would be unnecessary. Instead, the `ExecutionResult` could be presented to the user in some standardized way (iterating over the result of each node, etc.)." + }, + { + "prediction": "Why do we need to pass a channel here?", + "reference": "Not sure why we make a new channel here. If we don't use this channel, how about creating it inside the `Connect`?" + }, + { + "prediction": "I don't think we need to do this. If the wal is rolled back, we will get E_RAFT_NO_WAL_FOUND, and then we will retry.", + "reference": "There are two question here: 1. If you only modify lastLogId, but the `iter` is not modified, I really don't know whether we can succeed. 2. We will check the if the term has changed in `replicateLogs` (if rollback really happen, the term must have been updated), so I really doubt whether the problem should be fixed in this way. Or you could describe it in more details." + }, + { + "prediction": "This should be `$step->getFormType()->getName()`", + "reference": "Hello @jDolba, I have reviewed your PR and I found one problem. `$step->getFormType()` can return `FormTypeInterface`. You cannot use interface as key for an array. Can you find some better way to fix this? Thank you." + }, + { + "prediction": "I think we can remove the `repo_gpgcheck=1` and `gpgkey=https://packages.cloud.google.com/yum/doc/rpm-package-key.gpg` lines.", + "reference": "i was confused by keyword \"inventory\" here. my understanding is this starts the osconfig-agent which covers inventory lookup and package-management(correct me if i am wrong)." + }, + { + "prediction": "I think these should be `TIMEOUTS_IMPLICIT`, `TIMEOUTS_PAGE_LOAD`, and `TIMEOUTS_SCRIPT`", + "reference": "These are really meant to be the keys in the capabilities, not the keys of values within the capabilities" + }, + { + "prediction": "I don't think we need this.", + "reference": "This breaks tests on IE because this will import an `esm` bundle. For that reason `sinon` is available as a global in our test suite and never imported. The global is aliased to the proper `es5` file." + }, + { + "prediction": "I think this should be 1.0 / 16", + "reference": "Maybe move all the Loss Recovery constants to a separate file." + }, + { + "prediction": "I'm not sure this is the right place to store the name of the disk. I think it would make more sense to store it in the `Disk` struct.", + "reference": "this field is added so that we can find disk name by device name from attachments" + }, + { + "prediction": "Please remove this empty line.", + "reference": "Unnecessary new line" + }, + { + "prediction": "I think we can remove this line as well.", + "reference": "First determine if the namespace already exists, so it's clearer that it's handling namespaces that aren't included in the `c.config.Namespaces`" + }, + { + "prediction": "I'm not sure about this change. I don't think we should remove the wrapping `div` here.", + "reference": "What changed in the styles that means we don't need this?" + }, + { + "prediction": "I think this should be `projectJsonRoot[\"frameworks\"][framework][\"dependencies\"] as JObject;`", + "reference": "This pattern should be applied to the other instance where NewtonsoftEscapeJProperty is used and you can remove the NewtonsoftEscapeJProperty method." + }, + { + "prediction": "This should be a deprecation warning, not a warning.", + "reference": "Something to mention in the next changelog/release notes. It will be good to get histogram working consistently with everything else." + }, + { + "prediction": "I think this should be `namespaces: [{{ .Volume.runNamespace }}]`", + "reference": "What does this contain? Is it PVC namespace or is it openebs?" + }, + { + "prediction": "Should this be `IHttpRequestBodyMinimumDataRateFeature`?", + "reference": "Design note: Using local concrete data types on a feature abstraction makes it hard to generalize / replace. This is tolerable so long as this remains a kestrel exclusive feature, but we'd need a different design if this were ever moved to HttpAbstractions." + }, + { + "prediction": "`R_AS_INT(data_idx)` should be `R_AS_INT(data_idx) - 1`", + "reference": "this will break R package, you should update the R files accordingly. BTW, the call state should be in the last argument." + }, + { + "prediction": "I think this should be `$media->getContext()` instead of `$mediaContext`", + "reference": "Shouldn't we throw an exception if the context is null instead ?" + }, + { + "prediction": "I think this should be `>= 1.12.0`", + "reference": "These should both be const, not var right?" + }, + { + "prediction": "`build_match_cost` -> `build_match_cost_calculator`", + "reference": "Rename the directory, match_costers -> match_costs" + }, + { + "prediction": "I think this should be `self.assertEquals(int(count), 1)`", + "reference": "I don't think this should go in the model tests, since it is done in the resource. `PaginatedDeleteTest` seems more appropriate" + }, + { + "prediction": "I think this should be `Session ID is null. Did you call quit() on the session?`", + "reference": "It would be better to just change RWD to throw IllegalStateException if you attempt to execute a command after quit (unless it's a second call to quit())" + }, + { + "prediction": "I think this should be `exporter.Controller().Stop(context.Background())`", + "reference": "Could we move this to an example test to allow the compiler to help us ensure it stays up-to-date in the future?" + }, + { + "prediction": "I think we can remove this test now that we don't support `--password` anymore.", + "reference": "Maybe we could update these to use $future and then check on stderr? that way when we deprecate stdout we can not have to delete tests." + }, + { + "prediction": "I think this should be `MinAllowedMaxFrameSize - HeaderLength`", + "reference": "Remove this since it always has to be set afterwards." + }, + { + "prediction": "I think this is a bug in the test. It should be `blockSize(20*1024)`, not `blockChangeSize(20*1024)`.", + "reference": "These two tests were causing us to use too many goroutines with `-race` using the default block change size, I think due to prefetching." + }, + { + "prediction": "I think we can remove the `now` and `requestContext` parameters from the `fetch` method in the `LeafNode` class. The `LeafNode` class is only used by the `LeafNode` class, and the `LeafNode` class doesn't use the `now` and `requestContext` parameters in the `fetch` method. So we can remove the `now` and `requestContext` parameters from the `fetch` method in the `LeafNode` class, and remove the `now` and `requestContext` parameters from the `fetch` method in the `LeafNode` class, and remove the `now` and `requestContext` parameters from the `fetch` method in the `LeafNode` class, and remove the `now` and `requestContext` parameters from the `fetch` method in the `LeafNode` class, and remove the `now` and `requestContext` parameters from the `fetch` method in the `LeafNode` class, and remove the `now` and `requestContext` parameters from the `fetch` method in the `LeafNode` class, and remove the `now` and `requestContext` parameters from the `fetch` method in the `LeafNode` class", + "reference": "Is that `try..except` block really needed? I mean, when it could fail?" + }, + { + "prediction": "I think this should be `**/suspense.test.js` so that it picks up tests in subdirectories as well.", + "reference": "If you only want to run a specific group of tests you can always use `.only` like `it.only()` or `describe.only()`. It may not speed up the globbing process as much as this change here :)" + }, + { + "prediction": "I think this should be `BATCH_SIZE_MAP = {'kinesis': (100, 10000), 'dynamodb': (100, 1000), 'sqs': (10, 10)}`", + "reference": "nit: I'd probably rename this to `BATCH_SIZE_RANGES`, to use a slightly more descriptive name." + }, + { + "prediction": "I think this should be 90 and 100 respectively.", + "reference": "aren't these the wrong way around?" + }, + { + "prediction": "I think we can remove this method as it is not used anywhere.", + "reference": "Lets call this getConfigSetService and maybe rename the field now (or later)" + }, + { + "prediction": "I think we can remove the `klogr` import here as it's not used.", + "reference": "Could / should we make these constants and give them a type?" + }, + { + "prediction": "This should be `gcp`, not `GCP`.", + "reference": "lets stick with lowercase for consistency." + }, + { + "prediction": "I think we can remove this import as well.", + "reference": "ordering of imports went wrong" + }, + { + "prediction": "I think this should be `return MetadataTableType.ALL_DATA_FILES.name();`", + "reference": "I think these can all be .name() to get the value we are looking for" + }, + { + "prediction": "I think this test is wrong. `print` is a language construct, not a function, so it doesn't have a return value.", + "reference": "Is this a good place for these test cases?" + }, + { + "prediction": "This should be removed.", + "reference": "Did you mean to leave the print statement?" + }, + { + "prediction": "This should be `new BN(500000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "reference": "I would do `new BN(Interpreter.LOCKTIME_THRESHOLD)`" + }, + { + "prediction": "I think this should be `import java.util.*;` instead of `import java.util.*;`", + "reference": "@ftomassetti I turned the tree walking algorithms into iterators so you don't have to visit every node when you only wanted a few, like for a `findFirst`." + }, + { + "prediction": "I think this should be `timerTypeToThrift(timerType)` instead of `timerTypeToThrift(timerType)`", + "reference": "Need to add type name here to be compatible with proto string representation." + }, + { + "prediction": "I think this should be `log.info`", + "reference": "This is to let people know that the tooling is doing something during a build. Please leave." + }, + { + "prediction": "I think we can remove this now that we're not using it.", + "reference": "Why is the principal changing here?" + }, + { + "prediction": "I think it would be helpful to mention that this environment variable can be used to override the domain for any Azure service, not just blob storage.", + "reference": "Naming nit: let's use `AZURE_STORAGE_` prefix for consistency with the other ones." + }, + { + "prediction": "I think this should be `this.opts.onInstall.call(this)` so that `this` is the plugin instance, not the Uppy instance. Same for `onUninstall` below.", + "reference": "I'm a bit confused. We have an actual `ProgressBar` Uppy React wrapper component that we are testing. Why do we need a mock for it?" + }, + { + "prediction": "I think we can remove this import.", + "reference": "can we use `github.com/pkg/errors`?" + }, + { + "prediction": "I'm not sure I like the name `inferredType` here. It sounds like it's the type that was inferred by the compiler, but it's actually the type that was passed in by the user. Maybe `actualType` is better?", + "reference": "I changed the name of the arguments here just to help make the code clearer." + }, + { + "prediction": "`unnecessarilly` -> `unnecessarily`", + "reference": "I think either 'avoiding calls to the function' or 'to avoid calling the function ...' would be read better." + }, + { + "prediction": "This is not safe to persist as long as `shared_attachments_` is not cleared. `shared_attachments_` is a `std::vector` of `std::shared_ptr`s, so the `std::shared_ptr`s will be destroyed when `shared_attachments_` is cleared. The `std::shared_ptr`s in `attachments_` will then point to invalid memory.", + "reference": "@sfricke-samsung -- thanks. saves a few atomic ops which is always good :) The TODO is there to track that this object is storing *both* vectors of shared_ptr and plain pointers to the same data. The shared are to ensure scope, and the plain are for backwards compatibility with existing code that consumed a plain pointer vector (and some code that still does). That should be cleaned up." + }, + { + "prediction": "I don't think we need this test anymore.", + "reference": "minor: typo (knowMetricsTypes -> knownMetricsTypes)" + }, + { + "prediction": "I don't think this is the right place to set the case-insensitivity flag. The flag should be set when the type is created, not when a constant value is created.", + "reference": "This adds a case-insensitive flag to the type in the RangeSpec, but I don't think RangeSpecs are written to handle case-insensitive comparisons. Take a look at the methods that deal with comparisons when building RangeSpecs, in file Range.cpp. So, I think you would have to do one of two things: a) disable the RangeSpec transformation for case-insensitive comparison operators (the easy way) or b) change the RangeSpec methods to handle case-insensitive comparisons." + }, + { + "prediction": "I don't think this is the right place for this method. It should be in the `TypeSolver` class.", + "reference": "I would throw an exception if the type is not solved" + }, + { + "prediction": "Why did you remove these?", + "reference": "if remove `dt.skipLoad` - then this tests will run. You probably mean opposite?" + }, + { + "prediction": "Metrics/BlockLength: Block has too many lines. [21/20]", + "reference": "I feel like we do this in a lot of places should we move that out into its own PR?" + }, + { + "prediction": "I think we can remove the `async` keyword here as well.", + "reference": "Already asked you in Matrix, but I'll do it here again so it can be discussed publicly. Why?" + }, + { + "prediction": "I think this should be `remove it and de-indent all the code inside it` instead of `remove it and de-indent all the code inside it`", + "reference": "I think here should be a comma before remove, in all the cases" + }, + { + "prediction": "I think it's better to use `getattr(context, \"bbox_roi_extractor\", None)` and `getattr(context, \"bbox_head\", None)` here.", + "reference": "Single quote is used by default in this project." + }, + { + "prediction": "Why don't we want to reconcile on spc?", + "reference": "S1023: redundant `return` statement (from `gosimple`)" + }, + { + "prediction": "I don't think we need to implement `Close` here.", + "reference": "`ctx` is unused in Close" + }, + { + "prediction": "There is no need for this class. You can throw `NotFoundHttpException` directly.", + "reference": "I'm confused. This exception is thrown when `HeurekaCategory` is not found in database. But this exception extends Http exception. Why? What has database search common with http? If the only reason is that it is the same in the whole project, then fine. But then we have even bigger problem - we don't know how to use exceptions." + }, + { + "prediction": "Please remove the empty line at the end of the file.", + "reference": "Is it necessary to add the suffix `on_head`, because it belongs to` bbox_head`?" + }, + { + "prediction": "This should be `AS_IF([test x$with_modern_grub = xyes], [AC_DEFINE([WITH_MODERN_GRUB], 1, [Define if we have a GRUB version newer than 2.02])])`", + "reference": "Hmm, I wonder if this should just be e.g. `--with-grub-2.02` instead. (Not sure Autoconf supports periods in these switches.) Today's modern GRUB is tomorrow's ancient GRUB. :) Or maybe we should be specific about the feature this is enabling, which might be safer given that each distro carries so many patches. E.g. `--without-grub-efi-16-suffixes`?" + }, + { + "prediction": "I think this should be `DeleteInstance` instead of `Delete`.", + "reference": "Add a GetSerialPortOutput method to Instance that way you don't need to access the client, also it makes the call cleaner as you don't have the odd i.Client and path.Base(i.Project), path.Base(i.Zone)" + }, + { + "prediction": "Align the elements of a hash literal if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Line is too long. [104/80]" + }, + { + "prediction": "I think this should be `expectedAssignedCDs` and `expectedRunningCDs`", + "reference": "Since CD updates (assignment & power state) are now done in this controller..." + }, + { + "prediction": "`opts && opts.conflictStack` -> `opts && opts.conflictStack && opts.conflictStack.join('\\n\\n')`", + "reference": "Hmm I'd rather not support this option going forward - it seems like a one-off just to work around this particular issue. Would it be fine to just remove the `deepStackTrace` option? The rest of the PR looks great - I love the idea of switching to sets." + }, + { + "prediction": "Metrics/MethodLength: Method run has too many lines. [16/10]", + "reference": "on the one hand I like how little this is doing. On the other hand, `inbound_mail_parser` is doing most of the work here so maybe it's not as helpful as I originally thought" + }, + { + "prediction": "I think this test should be updated to use the new `make_persistent` API.", + "reference": "This line is too long" + }, + { + "prediction": "I think this should be `logger.Error(err)` instead of `logger.Errorf(err.Error())`", + "reference": "This isn't a fatal error, we don't want to crash just because we can't set configs, we have sane defaults set" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the right thing to do. If we don't do this, we'll end up appending to the same slice over and over again, which is not what we want.", + "reference": "I wondered why `buffer` was passed into `LookupPath`. What is happening here? Is `buffer[:0]` equivalent to `[]V4TrieEntry{}`, and hence `buffer` isn't needed any more?" + }, + { + "prediction": "Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
", + "reference": "I don't really like the name of this file, especially the encoding of an implementation detail (the fact that it's a table) in the name. Can we just use `_message_body.html.erb` instead maybe?" + }, + { + "prediction": "I think it's better to use `omitempty` here, so that we don't need to set it to `false` explicitly.", + "reference": "Feel better not to expose our internal implementation in API/CRD, so no need to mention agent here. Consider: EnableLogging indicates whether or not to generate logs when rules are matched. Default to false." + }, + { + "prediction": "I think it's better to move this logic to RocksEngine::init()", + "reference": "use `NebulaKeyUtilsV3::dataVersionValue()` to replace the literal value?" + }, + { + "prediction": "I'm not sure if this is the right thing to do. I think we should raise an exception in this case.", + "reference": "No need for the `\\` here, inside parentheses whitespace is ignored by Python." + }, + { + "prediction": "I think this should be `\"\"` instead of `\"\"`.", + "reference": "This doesn't seem like the right expected result... it should be the same as the `clientCert` var defined above." + }, + { + "prediction": "I'm not sure if this is the right place to do this, but I think it would be better to do this in `wlr_surface_state_release_buffer` so that we don't have to remember to do it in every place we call `wlr_surface_state_release_buffer`.", + "reference": "need to rename this now." + }, + { + "prediction": "I think this is a bug in web3j. We should open an issue there and link it here.", + "reference": "NIT: This shouldn't be a TODO. It is just a note isn't it?" + }, + { + "prediction": "I'm not sure this is the right thing to do. If the element is orphaned, it means that it was removed from the page, so it's not possible to edit it. I think we should raise an error in this case.", + "reference": "I changed this to an error, that seems more appropriate than a warning here." + }, + { + "prediction": "Why do we need to change this?", + "reference": "This change could mute unit test failure, but it is better to update unit tests" + }, + { + "prediction": "I think this should be `notificationIdsInUse.remove(notificationId);` instead of `notificationIdsInUse.delete(notificationId);`", + "reference": "All other places that access `notificationIdsInUse` are in methods with descriptive names. We should do the same here. Maybe `markNotificationIdAsFree()`?" + }, + { + "prediction": "I think we should keep the `ErrNotFound` as it is used in other places as well.", + "reference": "keep as `ErrNotFound`, it is the same convention as in other packages" + }, + { + "prediction": "I think this should be `if (typeof domain !== \"undefined\" && domain !== \"\" && !offlineMode) {`", + "reference": "Same here, we need to call `callback` in else branch" + }, + { + "prediction": "I think this should be `certRecord.getHostName() != null ? certRecord.getHostName() : \"\";`", + "reference": "At this point we already check that the record is valid and so it could never be nulll" + }, + { + "prediction": "Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
", + "reference": "Would it not be more sensible just to move setting of the title to later in the method rather than duplicating it here?" + }, + { + "prediction": "uploadSession() should be called before loadUsersAndRoles()", + "reference": "why not do it in `reclaimExpiredSessions`? and `pushSessionToCache` can delete" + }, + { + "prediction": "Please remove the empty line at the end of the file.", + "reference": "out_channels/num_outs/type are unnecessary" + }, + { + "prediction": "I think we can remove this line.", + "reference": "You can create an issue for it and put it on the backlog so we don't forget it." + }, + { + "prediction": "I think it would be better to return an error here, so that the caller can decide what to do in this case.", + "reference": "So now we are checking twice, both here and in `weaveCIDRsFromConfig`. Not great. I suggest changing the `ok` return of `weaveCIDRsFromConfig` to a messsage (or error?) instead, which we can then log." + }, + { + "prediction": "I think this should be `pkgobj = store.create_package(owner, pkg, PackageFormat.HDF5)`", + "reference": "An alternative to setting format to the default in Package.__init__ would be to set it in create_package. I think we can assume all packages are created by create_package, but not necessarily by build_package." + }, + { + "prediction": "Why do we need this?", + "reference": "Let's add fee recipient as well." + }, + { + "prediction": "I don't think this is necessary, since the `super()` call is in the `__init__` of `_DownloadTarget`, which is called by `FileDownloadTarget`'s `__init__`.", + "reference": "No need for those with `super-init-not-called`, as pylint already only turns things off for this function and it's needed for the entire function." + }, + { + "prediction": "I think this should be `APP_NAME` to be consistent with the rest of the capabilities.", + "reference": "I think there's another spot for this in DefaultCapabilityMatcher" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "this name seems pretty vague -- thoughts on a more descriptive method name?" + }, + { + "prediction": "I think we should keep the copyright year as 2020.", + "reference": "what changed in this line?" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it's the only way I could think of to pass the `reportArgs` to the `hasData` function. If there's a better way to do it, please let me know.", + "reference": "Instead of doing this let's add another function similar to `hasZeroData` for selecting the `reportArgs` since this is all sourced from selected values. Then `hasZeroData` can use this internally, as well as the component itself. Since this function would be internal just for the purpose of avoiding duplication, we don't need to expose it on the component the same way though." + }, + { + "prediction": "I don't think we need this anymore.", + "reference": "This line was useful for auto-completion, I think it should be re-added with specifying the var name (`$exception`) and simplifying the FQCN." + }, + { + "prediction": "I'm not sure if this is the right way to do it. I think we need to wait for all goroutines to finish before closing the connection.", + "reference": "This looks like you're not collecting everything from the error channel." + }, + { + "prediction": "I think we can remove the `@plan` instance variable here and just use `checkout.plan.name` in the mailer template.", + "reference": "This currently violates the Law of Demeter. Using `checkout.plan_name` is the quick resolution." + }, + { + "prediction": "Why is this nullable?", + "reference": "is there any scenario when `$temporaryFilename` can be null?" + }, + { + "prediction": "I think we can remove this annotation, since we are not using `==` to compare `rowType` and `root` here.", + "reference": "this is for the `boolean isRoot = root == rowType` check, which seems to be on purpose, but maybe you could double check whether using ref. equality here is still wanted? Same for `SparkTypeToType`" + }, + { + "prediction": "I think this should be moved to the `roots_drag_icon_update_position` function, so that we don't have to call it twice.", + "reference": "No need to damage after `roots_drag_icon_update_position`, this is already done in `roots_drag_icon_update_position`" + }, + { + "prediction": "`device` is not used in this function, please remove it.", + "reference": "Have you tested exporting to ONNX with `device=cuda`?" + }, + { + "prediction": "I think this should be `if o.name != \"\" && o.since != 0 && o.humanStartTime != \"\" {`", + "reference": "Do we also need to validate `envName` flag then? `appName` and `envName` are used in `initLogsSvc` which are called by `svc logs` from within `Execute()`" + }, + { + "prediction": "I think this should be `Request::setTrustedHosts(['^(.+\\.)?' . preg_quote(parse_url($url, PHP_URL_HOST)) . '$']);`", + "reference": "@LukeTowers I think I would prefer that we don't force it, on the basis that: a) some people would be opting to configure their web server to protect against this kind of attack and would disable this feature in October CMS to get a small performance increase. b) it might be a bit misleading to say that `app.trustedHosts` set to `false` disables the feature entirely, just to have it be overridden here regardless." + }, + { + "prediction": "Should this be `c.cnpInformer.Informer().GetIndexer().ByIndex(ClusterGroupIndex, cg.Name)`?", + "reference": "i like that you are trying to correct the naming, but its making the PR longer :( i guess in future we can do such changes in separate PRs" + }, + { + "prediction": "I'm not sure if this is the right fix, but it seems to pass the tests.", + "reference": "Are we marking what the browser's accessibility tree says or what screen readers with those browsers say?" + }, + { + "prediction": "I don't think we need this.", + "reference": "This method should behave as intended, to block until it reads an EOF from the other side." + }, + { + "prediction": "I think it's better to use `Fail to health check repository '%s': %v` here.", + "reference": "I prefer starts with `Failed to xxx`, how about `Failed to perform health check on xxx`?" + }, + { + "prediction": "I'm not sure we want to add these tags to every span. I think we should only add them to the root span of each trace/subtrace. What do you think?", + "reference": "All these calls make me think we should refactor how traces are started and allow \"source tags\" that we initialize a trace with. I'd like to do this in a follow up." + }, + { + "prediction": "I'm not sure if this is a bug or not, but it looks like the `v1_test.go` files are being generated in the wrong directory. They should be in `internal/gen/v1/v1_test.go` and `internal/gen/v2/v2_test.go`.", + "reference": "This file shouldn't be in this PR" + }, + { + "prediction": "I think this should be `LessSpecificReturnStatement` and not `NonEmptyAssignmentToListElementChangeType`", + "reference": "This now causes `LessSpecificReturnStatement - src/somefile.php:9:32 - The type 'non-empty-list<5|string>' is more general than the declared return type 'non-empty-list' for takesList`, which seems correct to me. The type `non-empty-list<5|string>` contains the type `non-empty-list`. Thoughts?" + }, + { + "prediction": "I think this should be a debug statement.", + "reference": "Are you going to change that back?" + }, + { + "prediction": "I think this should be `ifeq (true,$(staticbuild))`", + "reference": "we have a standard format for putting these together elsewhere, it does the filter check first and errors out and then sets based on the value. i think this should be adjusted to do that. there's no logical change, just an approach change." + }, + { + "prediction": "This should be `handler: applyFuncToEachWithInput('delay', 'Please enter the number of steps to delay')`", + "reference": "Note this should be `delay` instead of `scale` here. I'll fix this in my branch." + }, + { + "prediction": "I think we can remove this line as well.", + "reference": "`on` likely still needs a bind, similar to `this.resetProgress = this.resetProgress.bind(this)` correct?" + }, + { + "prediction": "Please remove unused imports.", + "reference": "Considering the trade-off between training speed and accuracy, multi-scale training is temporarily kept. More elegant implementation will be adopted in the future." + }, + { + "prediction": "nit: remove empty line", + "reference": "Can you move this up along with the other builtin libraries?" + }, + { + "prediction": "This should be `Translators: The label of a checkbox in general settings to toggle allowing of usage stats gathering`", + "reference": "I actually think it makes sense to reposition this checkbox after the notifyForPendingUpdateCheckBox. The current order of check boxes is a bit arbitrary now." + }, + { + "prediction": "I think this should be `command:\"changes\" description:\"Calculates the difference between two different states of the build graph\" hidden:\"true\"` so that it doesn't show up in `pachctl help query`", + "reference": "Why do we have both `before` and `after`? Naively I would expect this to work as follows: `plz query changed` with no arguments compares the current working directory state to the last commit (i.e. HEAD, i.e. a noop when directly on a git commit). `plz query changed --since [reflike]` compare the current working directory state to the given reflike. So for CI I would expect to run something like `plz query changed --since @{upstream} (or origin/master I guess)`. And on merge I'd either run everything or just `plz query changed --since HEAD^` (given our workflow) - I don't think I'd ever want to do anything else. Either way I think before and after are slightly confusing terms here." + }, + { + "prediction": "I think this should be `f.server_conn.ip_address and self.re.search(f.server_conn.ip_address[0])`", + "reference": "Is there a reason why we can't use `~dst`? It feels like that could be good enough.I would like to avoid extending the filter syntax unless there's an urgent need. :)" + }, + { + "prediction": "I don't think it's a good idea to change this property. It's used in many places and changing it will break a lot of things.", + "reference": "Why local and not UTC?" + }, + { + "prediction": "I don't think this is the right fix. The problem is that the error is being generated in the wrong place. The error should be generated in the `ExSqlComp::createServer()` method, not in the `ExSqlComp::connect()` method.", + "reference": "2012 is a retryable error. Will avoiding rgenerating it here cause a difference in behavior in createServer() ?" + }, + { + "prediction": "remove this empty line", + "reference": "move to line 14 below" + }, + { + "prediction": "I think this should be \"intersects\" rather than \"crosses\".", + "reference": "the method name should match teh docs" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the right thing to do. We don't have any tests for MDv3 yet, so we need to make sure we don't accidentally break it.", + "reference": "Won't this happen automatically when we flip the default version in the config?" + }, + { + "prediction": "I think this is a bug in the test. It should be `/var/www/html/docroot` and not `/var/www/html`.", + "reference": "This would also change back to /var/www/html/docroot if we go that way." + }, + { + "prediction": "I think this should be called `hasImplicitRoleMatches` since it's not specific to Chromium.", + "reference": "This still needs to use the new option. We'll need tests for it too." + }, + { + "prediction": "I don't think this is necessary. If the name is the same as the value, NVDA will speak the name anyway.", + "reference": "We are no longer including file name in the source files." + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "no need for this. Devise provides us with `current_user` and `user_signed_in?` helpers." + }, + { + "prediction": "I think this should be `capability.getName().equals(NAME) && capability.getVersion() >= ETH66.getVersion()`", + "reference": "Would `Object.equals(capability.getName(), NAME)` would be safer, as you wouldn't have to do null checks?" + }, + { + "prediction": "Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
Layout/SpaceInsideBlockBraces: Space between { and | missing.
Layout/SpaceInsideBlockBraces: Space missing inside } {.
Layout/SpaceInsideBlockBraces: Space missing inside } {.
Layout/SpaceInsideBlockBraces: Space missing inside } {.
Layout/SpaceInsideBlockBraces: Space missing inside } {.
Layout/SpaceInsideBlockBraces: Space missing inside } {.
Layout/SpaceInsideBlockBraces: Space missing inside } {.
Layout/SpaceInsideBlockBraces: Space missing inside } {.
Layout/SpaceInsideBlockBraces: Space missing inside } {.
Layout/SpaceInsideBlockBraces: Space missing inside } {.
Layout/SpaceInsideBlockBraces: Space missing inside } {.
Layout/SpaceInsideBlockBraces: Space missing inside } {.
Layout/SpaceInsideBlockBraces: Space missing inside } {.
Layout/SpaceInsideBlockBraces: Space", + "reference": "Hmm, I wonder if we should revert #1862 instead? BTW, what failure do you get w/o this line?" + }, + { + "prediction": "I think this should be `errors.Wrapf(err, \"failed to validate 'apiURL' %s in slack config\", out.APIURL)`", + "reference": "since there are several places where we do 1) get secret key ref and 2) validate URL, maybe it's worth having a common method? it could also trim spaces as done here (but not at the other places currently)." + }, + { + "prediction": "I think this test should be updated to use `normalizeToPartialURL` instead of `extendPartialURL`.", + "reference": "TestNormalize... I would also split them" + }, + { + "prediction": "`next()` is a built-in function in Python 2, but not in Python 3. You should use `six.next()` instead.", + "reference": "All changes to this file are going to conflict with #7599. Please revert these as well. They will be addressed during the Python 3 transition." + }, + { + "prediction": "I don't think this is correct. `math/rand` is not thread safe, but `math/rand` is not used here. `rand.Intn` is used here. `rand.Intn` is not thread safe, but `rand.Intn` is not used here. `crypto/rand` is used here. `crypto/rand` is not thread safe, but `crypto/rand` is not used here. `crypto/rand` is not thread safe, but `crypto/rand` is not used here. `crypto/rand` is not thread safe, but `crypto/rand` is not used here. `crypto/rand` is not thread safe, but `crypto/rand` is not used here. `crypto/rand` is not thread safe, but `crypto/rand` is not used here. `crypto/rand` is not thread safe, but `crypto/rand` is not used here. `crypto/rand` is not thread safe, but `crypto/rand` is not used here. `crypto/rand` is not thread safe, but `crypto/rand` is not used here. `crypto/rand` is not thread safe, but `crypto/rand` is not used here. `crypto/rand` is not thread safe, but `crypto/rand` is not used here. `", + "reference": "Just thought, using spinlock (busy wait with compare and swap) that generates 2 random numbers inside rlock. We know that collisions are rare and we don't need that \"large\" write lock really but lock namely for \"rand\". Or least use a separate Lock (Mutex), namely for \"rand\" (wrap it into method). Mutex will use some sort of spinlock as well but it may use some linked list to make it more fair." + }, + { + "prediction": "I don't think we need to import the version from pylint and astroid. We can just use the `__version__` attribute from `pylint/__init__.py` and `astroid/__init__.py`.", + "reference": "Can we grab it directly from `__pkginfo__` as that is the source of truth for the version?" + }, + { + "prediction": "nit: remove empty line", + "reference": "We can revert this to reduce the diff of the PR." + }, + { + "prediction": "I think this should be `if (isCloud && protoPkg.contains(\"cloud\")) {`", + "reference": "This looks weird. `isCloud` should define if it is a cloud or no. Here it does it partially, and it can be overriden by protoPkg value (which also an argument to this function). Please make sure that isCloud completely defines the cloud thing. (i.e. it an be as straightforward as moving `protoPkg.contains(\"cloud\")` from here to the place where `assembleGoImportPath` is called." + }, + { + "prediction": "I think you can just do `if ((LobTgtFileFlags)fileflags == Lob_Append_Or_Error || (LobTgtFileFlags)fileflags == Lob_Error_Or_Create || (LobTgtFileFlags)fileflags == Lob_Append_Or_Create)`", + "reference": "Declaring fileflags to be of type LobTgtFileFlags would eliminate the need for all this casting. And would be safer. (Not a show-stopper though.)" + }, + { + "prediction": "I think this should be `finest` as well.", + "reference": "This change prevents a user understanding how their server is configured. Best to leave at `info` level." + }, + { + "prediction": "I think this should be `#if defined(SSL_set_tlsext_host_name) && OPENSSL_VERSION_NUMBER < 0x009080FFL`", + "reference": "Typically we would add something to the build system environment to differentiate this; also is there an alternative that can be used with older OpenSSL? Other folks who are committers will need to decide if it is worth supporting an older and likely quite vulnerable (to hacks) OpenSSL library." + }, + { + "prediction": "I think we should rename this to `readActiveBlockProducersByHeightTests`", + "reference": "`readActiveBlockProducersByHeightTests` is a global variable (from `gochecknoglobals`)" + }, + { + "prediction": "I don't think we need to pass `idField` to `saveRecordsToSmartStore`. We can get it from `sync.getTarget().getIdFieldName()` inside `saveRecordsToSmartStore`.", + "reference": "Falls back on `Constants.ID` if there's no custom field set." + }, + { + "prediction": "I think this should be `in.skipNBytes(this.getOffset());`", + "reference": "I believe this is what we want to rearrange: this in.skip() should not be happening here, in the open method, but in the setOffset() method itself. Because we want to be able to change that offset after the initial open. The setOffset() method will need to throw an IOException, if it's called while the InputStream is still null; or if the skip() call itself results in an IOException()" + }, + { + "prediction": "I think this should be `getMethodNameDeclaratorNode().getResultType().getChild(0) instanceof ASTPrimitiveType;`", + "reference": "In case the method is `void`, there won't be any children and `getChild(0)` throws. We'll need to check with `isVoid()` for that case. I'll update this when I merge." + }, + { + "prediction": "I think this should be `yarpc.Interceptors{requestLogInterceptor{}}`", + "reference": "If the yarpc.Interceptors wrapper will be added to any user interceptor, why not do it transitively. Can save one step for users. Same apply to filter." + }, + { + "prediction": "I think this should be `os.Rename(etcdDBDir(e.config), oldDataDir)`", + "reference": "Is there anything we should do in the event we're unable to renaming the directory?" + }, + { + "prediction": "nit: I think we can remove this line since it's not used anymore.", + "reference": "How is this env var populated? Can this be retrieved from cluster metadata?" + }, + { + "prediction": "I think this should be `SuccessfulTagInternetGateways` (plural) since we're tagging multiple gateways.", + "reference": "Should probably skip the success event here, since it could be a noop." + }, + { + "prediction": "I don't think we need to pass this to `buildChapterCards` since it's only used in `buildSceneCards` and `buildSceneCards` is only called when `item.Type === 'Series'`.", + "reference": "I added this here because people cards (which depends on cardBuilder) had this added in blurhash. Not sure when this is used though cc @JustAMan" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think we can remove this.", + "reference": "Let's keep this line in the docstring, to let end users know they shouldn't be using this directly." + }, + { + "prediction": "why remove this check?", + "reference": "can do the same for other validateXXX()" + }, + { + "prediction": "I don't think this is correct. The `const_cast` should be on the `const_cast(participant_)`, not on the `get_participant()` call.", + "reference": "Why is this necessary?" + }, + { + "prediction": "This import is not used in this file. Please remove it.", + "reference": "Please move this import upper to other similar imports" + }, + { + "prediction": "I think we can remove the `IF_ARM(ASSERT_NOT_TESTED());` now that we've run the tests.", + "reference": "Include the key word \"translated\". Otherwise the reader will find this confusing." + }, + { + "prediction": "I'm not sure if this is a good idea. I don't think we want to memoize this, as it's not a singleton. I think we want to memoize `ElasticsearchSpanStore`, which is a singleton.", + "reference": "why. is this called per request? if so this also adds a lock internally. can we not add this at the moment until analyzed as this assumption isnt carried to the several other impls. the only other consumer of this is the http api and that isnt hit often enough for specializations." + }, + { + "prediction": "I think we should use `option.hasAttr('selected')` instead of `option.actualNode.selected`.", + "reference": "I believe this means dependent checks can no longer operate on virtual nodes, which is something we've been pushing for lately. We may need to find a different way to solve this issue, as I don't think we want to cause a regression while fixing a bug." + }, + { + "prediction": "I'm not sure this is a good idea to have a `Migrator` subclassing a `Storage` class. I think it would be better to have a `Migrator` subclassing a `StorageBase` class.", + "reference": "ditto about use of `abspath`" + }, + { + "prediction": "I think this should be `Stream.rangeClosed(1, p).foldLeft(1L, (xs, x) -> xs * a);`", + "reference": "this reduces the runtime by 50 times" + }, + { + "prediction": "This file is not needed.", + "reference": "Probably best not to have an empty test...." + }, + { + "prediction": "I'm not sure this is the right thing to do. If the exception type doesn't have a no-arg constructor, this will throw an `IllegalStateException`. I think it would be better to throw an `IllegalArgumentException` in that case.", + "reference": "direct `newInstance` call is also deprecated now" + }, + { + "prediction": "I think we can remove this line.", + "reference": "We have a bit of a convention where imports are split into three blocks: first Go standard library, then imports from outside the repo, then imports from inside the repo." + }, + { + "prediction": "I think this should be `public` as it is used by `SnapshotProducerImpl`.", + "reference": "Why was this change needed?" + }, + { + "prediction": "I don't think it's a good idea to return an empty string here. It's better to raise an exception so that the user is aware that something went wrong.", + "reference": "can you use this opportunity to remove `.readlines()` useless list creation? (`addresses = [l for l in fd if l.find(\"netmask\") >= 0]`)" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Why does this check differ from `plan_ssh.rb`?" + }, + { + "prediction": "please remove the empty line here", + "reference": "File is not `goimports`-ed (from `goimports`)" + }, + { + "prediction": "Why is this removed?", + "reference": "It was @lodejard who initially suggested this pattern. I think that it had something to do about prioritizing future writes even if there was a pending write operation ready to handle the newly requested write. I'm not sure I fully understood the explanation for having up to 3 pending write requests, because only having one queued write at a time still makes sense to me. I'll talk to him about it." + }, + { + "prediction": "I think this should be `--debug_dump_online_weights` to be consistent with the rest of the options.", + "reference": "We have cli --online_weight_clear in cli.cpp" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's better than nothing.", + "reference": "So the request.Headers is a map of []string. Are you sure that the HTTP library doesn't already do this split for us?" + }, + { + "prediction": "I think this should be \"Execution stopped, crashed executor/container\" or \"Execution stopped, crashed container\" or \"Execution stopped, crashed executor\" or \"Execution stopped, crashed container\" or \"Execution stopped, crashed executor/container\" or \"Execution stopped, crashed container\" or \"Execution stopped, crashed executor\" or \"Execution stopped, crashed container\" or \"Execution stopped, crashed executor/container\" or \"Execution stopped, crashed container\" or \"Execution stopped, crashed executor\" or \"Execution stopped, crashed container\" or \"Execution stopped, crashed executor/container\" or \"Execution stopped, crashed container\" or \"Execution stopped, crashed executor\" or \"Execution stopped, crashed container\" or \"Execution stopped, crashed executor/container\" or \"Execution stopped, crashed container\" or \"Execution stopped, crashed executor\" or \"Execution stopped, crashed container\" or \"Execution stopped, crashed executor/container\" or \"Execution stopped, crashed container\" or \"Execution stopped, crashed executor\" or \"Execution stopped, crashed container\" or \"Execution stopped, crashed executor/container\" or \"Execution stopped, crashed container\" or \"Execution stopped, crashed executor\" or \"Execution stopped, crashed container\" or \"Execution stopped, crashed executor/container\" or \"Execution stopped, crashed container\" or \"Execution stopped", + "reference": "How is this message used? Can we remove the \"crashed executor/container\" part which is an implementation detail?" + }, + { + "prediction": "I think this should be `post` instead of `get`", + "reference": "Instead of building in routing for a browser-specific command, could you refactor the HttpCommandExecutor to allow arbitrary commands to be registered?" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Space after `=`." + }, + { + "prediction": "I don't think this is the right place to put the invocation context into the vertx context. It should be done in the `handle` method of the `EdgeInvocationHandler`.", + "reference": "if just need to do something after createInvocation just override and call super first is enough?" + }, + { + "prediction": "I think this should be `it_behaves_like 'a jvm build'`", + "reference": "By the way, I fixed `announce` method (missing `super` call to announce JDK version)" + }, + { + "prediction": "I don't think we need to suppress the warning here. The `contains` method of `SortedSet` takes an `Object` as parameter.", + "reference": "I'm not sure about that... This line can produce ClassCastException if Comparator do not check this." + }, + { + "prediction": "I think this should be `*BareTlfHandle`", + "reference": "There wasn't any special reason for this to return a pointer, right?" + }, + { + "prediction": "I'm not sure about this change. I think it's better to use a `HashMap` here because we don't want to block the main thread when we're trying to remove an item from the `mData` map.", + "reference": "Why the need for a `ConcurrentHashMap`?" + }, + { + "prediction": "I think this should be `if (order.by == 'title' && Setting.value('titleNaturalSort')) {`", + "reference": "New code should use strict equality `===`" + }, + { + "prediction": "I'm not sure if this is the best way to test this, but it seems to work.", + "reference": "`expect(resources['Notify[local pid]']['events'][0]['desired_value']).to match(/(\\d+)/)` seems clearer." + }, + { + "prediction": "I'm not sure this is the right thing to do, but I think it's the right thing to do for now.", + "reference": "Removed now-unneeded param." + }, + { + "prediction": "`go-filecoin bitswap` should be `go-filecoin bitswap stat`", + "reference": "(NON-blocking, this can be tracked in follow up issue) @anorth @mishmosh is the toplevel getting too crowded? Should we have a `network` grandparent command, or maybe a `stats` command?" + }, + { + "prediction": "I think this should be `Google Analytics` instead of just `Analytics`.", + "reference": "The `_x` function needs to be imported at the top of the file (in addition to `__`)" + }, + { + "prediction": "I'm not sure why this is necessary. The `propDialog.OkDialog()` call should be sufficient to close the dialog.", + "reference": "This is functionally equivalent to the code it replaces." + }, + { + "prediction": "I think this should be `ENIType` instead of `eniType`", + "reference": "can you change the field name here to \"InterfaceAssociationProtocol\"? same for the Config struct in agent/ecscni/types.go. i think it's better to keep the field name consistent between agent and acs payload" + }, + { + "prediction": "I think this should be `Widgets data store: widget tests`.", + "reference": "See above, same for the other cases." + }, + { + "prediction": "I don't think we need to suppress the unchecked warning here.", + "reference": "Shouldn't line 313 be public \\ SettableGauge\\ **settable**Gauge(String name) { ? It would also be good to call it a few times and with differnet types (Long, Integer, String) in the test as well." + }, + { + "prediction": "I don't think we need to disable the linting here.", + "reference": "I would prefer to just fix the occurences of this new check rather than disable them" + }, + { + "prediction": "I think this should be `https://news.google.com/rss?hl=en-US&gl=US&ceid=US:en`", + "reference": "The tests should be fixed in #4841, so this is no longer needed" + }, + { + "prediction": "I think we should use `Ergonode\\Core\\Infrastructure\\Exception\\SerializerException` instead of `Ergonode\\Core\\Infrastructure\\Exception\\SerializationException`", + "reference": "I think it should been in `SharedKernel` module." + }, + { + "prediction": "I think this should be `overrideNginxIngressWhitelistAnnotation`", + "reference": "Can we add some description for this field?" + }, + { + "prediction": "I don't think this is correct. `Time` and `Duration` are not the same thing. `Time` is the number of milliseconds since midnight, and `Duration` is the number of milliseconds since the epoch.", + "reference": "Should its name be Time or Duration? I can see them both." + }, + { + "prediction": "I think this is not needed. You can just pass `opts` directly to `otlpconfig.NewGRPCOption`.", + "reference": "Is this used anywhere?" + }, + { + "prediction": "I think it would be good to add a test for `Equal` as well.", + "reference": "I believe that you can use `assert` instead of `require` here and in the following lines" + }, + { + "prediction": "I'm not sure if this is the right thing to do here. I think we should return an error if the channel already exists, but I'm not sure if we want to return `ErrDuplicateChannel` or if we want to return `ErrChannelAlreadyExists`.", + "reference": "In `storagemarket.go` you used `nil` for an unwanted out parameter. Do something consistent (nil seems fine if supported)." + }, + { + "prediction": "I don't think we need to export these functions.", + "reference": "is this a new pattern we use in bee? interesting" + }, + { + "prediction": "I'm not sure this is the right thing to do. If the bucket already exists, then we should return an error, otherwise we'll end up creating a new bucket with the same name.", + "reference": "If you think this PR works, i'll clean this up before resubmitting." + }, + { + "prediction": "what is the meaning of GROUPID and ARTIFACTID?", + "reference": "are you sure you can read version by this artifactid?" + }, + { + "prediction": "I think we can remove this import now.", + "reference": "We can get rid of this import then." + }, + { + "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to have a `processGatewaySubjectSub` method in the `router` package. That way, we don't have to worry about the `router` package depending on the `gateway` package, and we don't have to worry about the `gateway` package depending on the `router` package. The `router` package should only depend on the `server` package, and the `gateway` package should only depend on the `server` package and the `router` package.", + "reference": "Should we do our own vtable?" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "This is the actual fix." + }, + { + "prediction": "I'm not sure about this change. I think we should keep it at 10 seconds. The reason is that we want to make sure that we don't miss any messages. If we set it to 60 seconds, we might miss some messages. I think we should keep it at 10 seconds. What do you think?", + "reference": "If sync has really a negative impact, this is just moving the issue from 10sec to 60sec. Wonder if you should not expose the (auto)sync params so users can decide." + }, + { + "prediction": "I'm not sure if this is the right place to add the `exactMatch` parameter. I think it would make more sense to add it to the `DecodeField` method.", + "reference": "should be called => will be called" + }, + { + "prediction": "Why do we need to change the logic here?", + "reference": "not sure whether we should do this. It may cause problem that delegates upgrade their nodes at different time, that they will have different \"last block time\", some use \"commit time\", some use \"block time\". Potential solution: Only use block time after berling, and then delete it in the next version after berling. Open to discussion." + }, + { + "prediction": "I don't think we need to delete the collection in this case. If we can't assign the replicas, we should just return an error and leave the collection as it is.", + "reference": "So one question I have is why is the error coming back from `buildReplicaPositions` not an `Assign.AssignmentException`? Is it because it is wrapped in a `SolrException` from the remote node?" + }, + { + "prediction": "`datatable.rbind(4) {` -> `dt.rbind(4) {`", + "reference": "`dt` won't work for some reason?" + }, + { + "prediction": "I think it's better to use `os.getenv(\"KOALAS_USAGE_LOGGER\", \"\") != \"\"` instead of `os.getenv(\"KOALAS_USAGE_LOGGER\", None) is not None` because `os.getenv(\"KOALAS_USAGE_LOGGER\", None)` returns `None` when the environment variable is not set.", + "reference": "Is this because \"KOALAS_USAGE_LOGGER\" can be `None` ??" + }, + { + "prediction": "Why do we need this constant?", + "reference": "I like it but maybe the better name will be EthGasPriceConstants or EthGasPriceEstimatorConstants? but Constants not Config" + }, + { + "prediction": "I think we can remove the `&dataresidency.StoreSingleton{}` here and just pass `dataresidency.StoreSingleton{}`.", + "reference": "I would inline the constructor as well" + }, + { + "prediction": "`dummyyylval` -> `dummyyylval`", + "reference": "I'm not confident about this..." + }, + { + "prediction": "This should be `v1alpha2.SchemeGroupVersion.WithKind(\"CertificateRequest\")`", + "reference": "There is also `v1alpha1.CertificateRequestKind` I think?" + }, + { + "prediction": "I think this should be `sender_gcpbroker` instead of `sender-gcpbroker`", + "reference": "Can we rename it to make it less confusing? Instead of \"sender-gcpbroker\", maybe name it to \"retryable-sender\"" + }, + { + "prediction": "I think we can remove the `value` here as it's not used in the error message.", + "reference": "So looking at the definition of the `literal()` function in this class, it seems it's possible for it to return null. I guess it's not a concern as we would get NPE on the above call at line 136 when trying to call `.to` if `literal()` returned `null` before even getting to this part that calls `literal().value()`, but something I thought I'd bring up. Perhaps something we might follow up on in another issue or possibly I just missed the workflow that makes `literal()`'s result non-null by the time this `bindLiteralOperration` is called." + }, + { + "prediction": "I think this should be `abs(nrmse.getMetric()[\"value\"] - target) < OPFMetricsTest.DELTA`", + "reference": "Why did you break the line? It looks like it is under 80 characters without the break and it is inside parens so no need for backslash anyway" + }, + { + "prediction": "I think it's better to raise an error here, so that we don't have to check for `DT_INSTALLED` in every place where `DataTable` is used.", + "reference": "@guolinke Don't you mind to rename this variable to `DATATABLE_INSTALLED`, for the consistency with other variables (for example, there are `PANDAS_INSTALLED` but not `PD_INSTALLED`). Also, `DT` is a little bit confusing: sometimes `dt` is used for `datetime`." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "We're fine with double quotes here. Just for future reference." + }, + { + "prediction": "I think we can remove this function now.", + "reference": "can we keep this around? We should make sure we can distinguish between properly wrapped errors and \"unwrapped\" errors" + }, + { + "prediction": "I think this should be `if (graphicsPipelineCI.pInputAssemblyState && graphicsPipelineCI.pInputAssemblyState->topology != VK_PRIMITIVE_TOPOLOGY_MAX_ENUM)`", + "reference": "`RecordPipelineShaderStage()` might change `topology_at_rasterizer `, according to shader code, so we should check `pInputAssemblyState `first." + }, + { + "prediction": "I think this should be `const Assets = require('./assets.js');`", + "reference": "Should we just inline the assets here? I can't think of an advantage to having them in a separate file." + }, + { + "prediction": "I think we should rename this to `detectStaleEndpoints` to make it more clear what it does.", + "reference": "detectStaleEndpoints to be more specific?" + }, + { + "prediction": "I'm not sure why this is disabled, but it looks like it should be enabled.", + "reference": "Please create a new issue for addressing this (if there isn't one already), so it doesn't get lost." + }, + { + "prediction": "I think we can remove this line.", + "reference": "Nothing was ever coming out of this channel because its already being consumed. Create a new channel here and feed it in HandleNewHead method." + }, + { + "prediction": "I think this should be `AWS Identity and Access Management (IAM)` instead of `AWS Identity and Access Management (AWS IAM)`.", + "reference": "AWS Identity and Access Management (IAM)" + }, + { + "prediction": "I think this should be `INFO` as well.", + "reference": "This is deliberately at this level." + }, + { + "prediction": "`args[2]` should be `args[1]`", + "reference": "payload entered on command line is in hex-encoded format should use same processing as in ioctl/cmd/action/actiontransfer.go" + }, + { + "prediction": "I think this is not the best way to do it. I would create a new method `getPricingGroupByDomainIdAndName` in `PricingGroupFacade` and use it here.", + "reference": "should this be kept in the `else` branch?" + }, + { + "prediction": "I think we can remove this import.", + "reference": "Why not put this below \"strings\"?" + }, + { + "prediction": "I think this should be `public int UvPipeCount => _dispatchPipes.Count;`", + "reference": "Make it `internal` if it's just for testing." + }, + { + "prediction": "I don't think this is a logical tautology.", + "reference": "What is triggering this message in this file?" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we want to wait for all the workers to finish, even if one of them throws an exception.", + "reference": "Are you sure this should be removed?" + }, + { + "prediction": "I don't think this is a good idea to have a default value here. I think it would be better to throw an exception if the proxy settings are not set.", + "reference": "What's that good for? The field is initialized in the constructor." + }, + { + "prediction": "I'm not sure this is the right thing to do. If the connection is closed by the other side, we'll get an exception when we try to close it again. I think it's better to just ignore the exception.", + "reference": "This shouldn't be necessary (same below). Do you have a traceback for me?" + }, + { + "prediction": "I think this should be `github.com/opencontainers/runc/libcontainer/log`", + "reference": "No newline needed here." + }, + { + "prediction": "I think this should be `github.com/keybase/kbfs/libkbfs/ioutil`", + "reference": "Why a separate block?" + }, + { + "prediction": "I think this should be `DR_REG_CNTVCT_EL0` instead of `DR_REG_CNTVCT`.", + "reference": "Probably better to ask @AssadHashmi or another AArch64 expert for a review rather than me -- @AssadHashmi if you could confirm that these status registers are 64-bit despite having only a few fields?" + }, + { + "prediction": "`bip44_derivation` is not used anymore, so it can be removed.", + "reference": "`purpose` and `coin_type` and `account` would mimic the BIP-0044 wording, but it's up to you." + }, + { + "prediction": "I don't think this is correct. The `Select()` method is used to set the focus to the control. The `Checked` property should be used to set the checked state of the radio button.", + "reference": "Is this the critical change? It does seem wrong to use Select() instead of Checked = true. Not sure why that would pass sometimes and not others, though." + }, + { + "prediction": "I think this should be 2048.", + "reference": "Seems a little low, but is this an installer default?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in the `configure` method of the `structlog` module.", + "reference": "Maybe we could provide our own `configure` function that includes `logger._logger = None` because I don't see a use case in kinto for using `reset_logger` besides configuring the logger." + }, + { + "prediction": "I think we should keep the ParentWeightNum and ParentWeightDenom fields, and just set ParentWeight to ParentWeightNum / ParentWeightDenom", + "reference": "This will cause the same breakage that was caused when we added Proof to Block. Be sure to let people (infra?) know ahead of time" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get the test to pass.", + "reference": "Fixed the test; @strib want to validate that this is okay? Seems to be consistent new GC behavior." + }, + { + "prediction": "I think this should be `subdoom` instead of `subdom`", + "reference": "Afaict, nothing cares" + }, + { + "prediction": "I'm not sure this is correct. If we're in minimal mode, we don't have a node cache, but we still need to re-embed the block changes.", + "reference": "I must be missing something, but why does not having a node cache imply not neededing to re-embed the block changes, in particular? Isn't it just the fact that we don't do any writes?" + }, + { + "prediction": "I think this should be `internal struct` instead of `internal readonly struct`", + "reference": "Are these changes from `class` to `struct` breaking if called from an older version of `Datadog.Trace.ClrProfiler.Managed`?" + }, + { + "prediction": "I don't think we need this import.", + "reference": "These are just aliases now" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get rid of the `&` in the title.", + "reference": "Does this mean we can remove `raw` from `_head_contents` partial?" + }, + { + "prediction": "`this.splashWindow && !this.splashWindow.isDestroyed` -> `this.splashWindow && !this.splashWindow.isDestroyed()`", + "reference": "`isDestroyed` is a function, not a property. This condition will always return false." + }, + { + "prediction": "I think this should be `Version_2_0` and `Version_2_1`", + "reference": "Why are we adding these versions?" + }, + { + "prediction": "I think this should be `str(user.user_id)` instead of `str(user)`.", + "reference": "fyi, you can do this by doing `.info(\"string %s %s\", formatparam, formatparam2)` instead of doing a string format with `\"str\" % (params)` the idea is that it'll only do the string interpolation if logging is enabled for this level, which theoretically is an optimisation, but in this case probably isn't important" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "Would this work, as a one liner? `setTimeout(window.location.reload, 5000);`" + }, + { + "prediction": "Please revert this change.", + "reference": "Can you move `crypto/tls` into the block at the top with all the other stdlib imports?" + }, + { + "prediction": "I think this should be `inferenceElement='multiStepBestPredictions'`", + "reference": "What is the motivation for this change?" + }, + { + "prediction": "I'm not sure I understand this. If the service returns no messages for some other reason, this method should return the empty slice of messages and not attempt to retry. But if there is a transient failure, this method should not retry but should return a nil slice and an error. The concrete API will take care of retry logic.", + "reference": "OK, so the concrete implementation will loop? But then it's important that this method waits for a while before it returns no messages. To be specific, a GCP implementation that set `ReturnImmediately` to true or false would both satisfy this requirement, but the first would cause busy-waiting." + }, + { + "prediction": "I think this should be `if (matchClause->path()->pathSize() != 1) {`", + "reference": "The data structure of `MatchClauseContext` may need to be redesigned." + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to work.", + "reference": "You say on the issue that something has to be receiving while the messages are being published. But here it's possible that the publish goroutine starts, and maybe even completes, before Receive is ever called." + }, + { + "prediction": "Line is too long. [81/80]
Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "how do we know that the step in question is an approval type step?" + }, + { + "prediction": "This import is not needed.", + "reference": "JMX offers normal APIs for this. I don't think you want the glassfish one." + }, + { + "prediction": "I think we should not export `io.vavr.concurrent` as it is not part of the public API.", + "reference": "Is this still Java 8 compatible? @danieldietrich do we need a separate, modularized Java 9 release also?" + }, + { + "prediction": "I don't think this is correct. If the texture is not normalized, then the address mode should be CLAMP_TO_EDGE. If the texture is normalized, then the address mode should be CLAMP_TO_EDGE or CLAMP_TO_BORDER, depending on the filter mode.", + "reference": "Should update the user input address and filter modes and pass those in fillSamplerDescriptor ?" + }, + { + "prediction": "Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.", + "reference": "This object should be in `lib/music/show.rb` and you should also wrap this object in the `Faker::Music::Show`." + }, + { + "prediction": "I think this should be `if executor.noop && task.supports_noop`", + "reference": "I think logic will have to move to bolt since the vague discussions around bolt run plan --noop is that it would just skip any tasks that don't support_noop rather than error. This is fine until we actually elaborate that though." + }, + { + "prediction": "remove empty line", + "reference": "File is not `goimports`-ed" + }, + { + "prediction": "I think this test should be removed, as it doesn't test anything.", + "reference": "why should unknown raise a 403?" + }, + { + "prediction": "`c._nextState == c.state` should be `c._nextState === c.state`", + "reference": "The true clause of your condition, can't this just be c._nextState since `assign({}, c._nextState)` is equal to returning c._nextState, or am I misunderstanding something here?" + }, + { + "prediction": "This should be `max_results_admin_api`", + "reference": "nit: align the leftmost quotes" + }, + { + "prediction": "`ClusterMembershipPort` -> `ClusterMembershipServerPort`", + "reference": "Probably \"server port\" -> \"TCP port\"" + }, + { + "prediction": "I don't think we need to change the name of the codec. We can keep it as \"Lucene80\".", + "reference": "can you use FilterCodec instead?" + }, + { + "prediction": "I think this should be called `export.pdfPageOrientation` instead of `export.pdfPageSize`.", + "reference": "I know there's only two values but I find it a bit confusing that it's true/false. Could you change it to a string enum with values \"portrait\" and \"landscape\"? Then when calling printToPdf you can just do `landscape: Setting.value('export.pdfPageOrientation') === 'landscape'`" + }, + { + "prediction": "This migration is no-op, but it forces the migration mechanism to apply it and thus write the DB schema version info", + "reference": "I think this migration should fail for MDBX if it uses old table names" + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.", + "reference": "Should this be negated? `!@options[:hosts_file].nil?` Otherwise it'll enter the `if` statement and `nil` will be passed to `HostsFileParser.parse_hosts_file`, which I'm assuming is bad." + }, + { + "prediction": "I think this should be `public static ISetupBuilder LoadConfiguration(this ISetupBuilder setupBuilder, Action configBuilder, bool applyOnReload = true)`", + "reference": "I'm doubting if adding a bool here is a good idea. Maybe it should be an option object? Otherwise it's hard to extend. But an option object is a bit strange in a fluent API? What do you think @snakefoot ?" + }, + { + "prediction": "I don't think we need to make this public. It's only used by MultiPhraseQuery.", + "reference": "This is used in o.a.l.sandbox.search.PhraseWildcardQuery." + }, + { + "prediction": "I think it's better to use `protocol.Protocol` instead of `protocol.Dock` here.", + "reference": "view should be loaded on start for both statedb and factory" + }, + { + "prediction": "I'm not sure if this is related to this PR or not, but I think we should rename this to `ReadInputTask` to be consistent with `WriteOutputTask`.", + "reference": "Why rename? Just curious..." + }, + { + "prediction": "I don't think this is the right place to set the visibility of the controls. It should be done in the `onResume()` method of the activity.", + "reference": "Is this needed? I think it calls the super function that already does that." + }, + { + "prediction": "Why do we need to repeat bboxes here?", + "reference": "This might slow down the inference time, are we sure we need to do that?" + }, + { + "prediction": "I don't think we want to do this. We don't want to add a blank import to the example.", + "reference": "This would read better if you add \"Skip code/lines\" or (exclude/hide code if you follow my earlier suggestion\")" + }, + { + "prediction": "Looks like this is a copy-paste error.", + "reference": "Looks like glassfish went a bit nuts doing a refactor" + }, + { + "prediction": "I think we need to call `ForceFlushAsync` on the exporter as well.", + "reference": "nit: allocate the list using the number of processors." + }, + { + "prediction": "nit: `initializedClasses` -> `initializedJavaClasses`", + "reference": "Was this change triggered by baseline?" + }, + { + "prediction": "I think we can get rid of the `with_commits_and_affiliates` scope now.", + "reference": "This code was doing nothing as far as I can tell and was making the SQL find nothing with the new version of Rails. Remove it unless someone can explain why it is there." + }, + { + "prediction": "This should be done in the `onCreate` method of the `ExplorerActivity` instead of the `RestExplorerApp` class.", + "reference": "Setting browser based login as the default for `RestAPIExplorer`." + }, + { + "prediction": "I think this should be `splitInfoSize * 2 * sizeof(SplitInfo)`", + "reference": "maybe we can do this in Init function?" + }, + { + "prediction": "Should we also validate the length of `request.GetNamespace()` here?", + "reference": "How about if request ID not set, service should generate a random uuid?" + }, + { + "prediction": "nit: can you remove the trailing backtick here?", + "reference": "minor: this is an opportunity for you to split these long lines into multiple lines :)" + }, + { + "prediction": "this is not a good idea, because it will catch all exceptions, not only `TaurusConfigError`", + "reference": "It would be nice to have exception dumped somewhere (debug logs, info logs)." + }, + { + "prediction": "I think this should be `MessageAs allows providers to expose provider-specific types.`", + "reference": "So I don't think this is right, as discussed on #657." + }, + { + "prediction": "I think this should be `group_id = \"{0}\"` instead of `group_id = \"{1}\"`", + "reference": "should the group_id = \"{0}\" be group_id = %s You'd still keep the {} for the group_members_{} for the tablename but make the filter clause parameterized." + }, + { + "prediction": "I don't think it's a good idea to exclude variables here. What if someone wants to use a variable as a file path?", + "reference": "Path can contain variable pattern in the middle. Also, `$` is not enough to tell if this is JMeter variable. We have correct variable detecting somewhere in our code." + }, + { + "prediction": "This should be `staticMethodOptions`", + "reference": "@bennothommo can you revert this section? It shouldn't be required." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Minor: maybe move the above to a `#fiscal_year` method?" + }, + { + "prediction": "I think this should be `os.path.join(mydir, 'data', 'build.yml')`", + "reference": "You should use the current directory instead - it's a temporary directory that will get removed when the test is done." + }, + { + "prediction": "I don't think we should be using `join` here. We should be using `wait` to wait for the thread to complete. `join` will wait for the thread to complete, but it will also wait for the thread to start, which is not what we want in this test.", + "reference": "I think we don't need synchronization here." + }, + { + "prediction": "I don't think we need to change the error message in this PR. I think it's fine to leave it as it is.", + "reference": "I don't think this should be changed since on the reactive side we don't support anonymous users." + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "Maybe this `if` should be on line 118?" + }, + { + "prediction": "I think we should keep `count` as a `metric.Number` and just convert it to an `int64` when we need it. That way we don't have to worry about overflow.", + "reference": "Cool. (I thought I had fixed this already in #812.)" + }, + { + "prediction": "I think this should be `interpreters: []`", + "reference": "I intend to do this as soon as I have tests passing." + }, + { + "prediction": "This should be `sys.stdin.read()` instead of `sys.stdin.read()`.", + "reference": "Please remove the `test_*` from the filename - otherwise pytest will try to collect tests from it." + }, + { + "prediction": "I think this should be `\"/dev/dri/card0\"` instead of `\"/dev/drm/0\"`.", + "reference": "Did you file a bug to follow up on this?" + }, + { + "prediction": "I think this should be `!batchReadsSparkSessionConf || batchReadsEnabledTableProp`", + "reference": "Looks like these 4 lines didn't actually change. Can you revert the whitespace changes here?" + }, + { + "prediction": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", + "reference": "This can't be merged with any usage of `require 'pathname'` in lib, it's not always available and we don't want false positives for people (where they don't realise they needed to requite it). Its also unnecessary, no other formatter uses it to look up failure locations. See the exception presenter etc for how we format lines." + }, + { + "prediction": "I think this should be `createLinkingDatasetResponse` instead of `publishDatasetForLinking`", + "reference": "It would be nice to fix the indentation above." + }, + { + "prediction": "`short_names='bool|null'` should be `short_names='bool'`", + "reference": "`short_names` is still optional, so `=` that indicates it has to stay there." + }, + { + "prediction": "I think this should be `appendNameOnlyAttribute(capabilities, attributePrefix+capabilityEFS)`", + "reference": "missing calling of this method" + }, + { + "prediction": "nit: I think we can remove the `archerCfn` alias and just use `archer` everywhere.", + "reference": "We could get rid of this dependency being forced on clients by changing the `StackConfiguration` interface abstraction to deal with strings instead of `cloudformation.Parameters` and `cloudformation.Tags`, and internally to the `cloudformation` package translate the input strings into the `service/cloudformation` package specific values hiding that from consumers. I don't think that should be taken on as part of this PR, but I think we should consider doing it at some point." + }, + { + "prediction": "why do we need to add action and duration here?", + "reference": "`StressChaos` does not contains a field .spec.action" + }, + { + "prediction": "I think this test case is wrong. The error message should be `InvalidScalarArgument`, not `InvalidArrayArgument`.", + "reference": "Non-int literal strings are no longer coercible to int, I think this is an improvement. Without this change it now reports `InvalidArgument`." + }, + { + "prediction": "This should be in a separate commit.", + "reference": "I this used anyplace?" + }, + { + "prediction": "I don't think this change is related to this PR. Can you revert it?", + "reference": "Why was this change required?" + }, + { + "prediction": "`missingAdminRole` -> `isMissingAdminRole`", + "reference": "I like that we have this attribute here. However, I think the way we use it right now might be confusing in the future. For example, when only camunda admin is checked, this exception will be instantiated with a message and `missingAdminRole` is `false`. I think that is counter-intuitive. I would expect this exception to have `missingAdminRole` set to `true`. With this explicit information, the exception message could now be generated inside this exception class with the text block that is currently used in the authorization manager. We could maybe generally reuse that text block then also for the case where a user is no admin and also has none of the required permissions. I haven't tried it myself but I think it would be great if we could streamline those things a bit more if we're working on it now. Let me know what you think." + }, + { + "prediction": "I think this should be `getSizePrefixedRootAsMonster(ByteBuffer _psbb, Monster obj) { ByteBuffer _bb = _psbb.slice(); _bb.order(ByteOrder.LITTLE_ENDIAN); _bb.position(4); return getRootAsMonster(_bb, obj); }`", + "reference": "Not sure why we're creating a new `ByteBuffer` here, ideally this refers to the existing one?" + }, + { + "prediction": "I think we should rename this to `generateReportDateRangeArgs` to make it more clear what it's used for.", + "reference": "Same here re: `STORE_NAME` to `MODULES_SEARCH_CONSOLE`." + }, + { + "prediction": "I think this should be `UA-999-9` instead of `UA-00000001-1`.", + "reference": "I could've sworn I got a `403` myself when I got that response locally. Is `200` what the API would send back for a `permission: false` tag?" + }, + { + "prediction": "This should be `NewIdentityManager` not `NewIdentityManager`", + "reference": "This attribute was intentionally private. - lets force usage of factory `NewIdentityManager()` - lets ramake to `NewIdentityManager(keydir string)` -> `NewIdentityManager(keystore keystoreManager)`" + }, + { + "prediction": "I think this should be 100 * time.Millisecond", + "reference": "Is this too frequent?" + }, + { + "prediction": "This is not a file extension, it's a mime type.", + "reference": "will this not make it possible to use a zip file, e.g. on other importers who do not have to support it ?" + }, + { + "prediction": "nit: trailing backtick", + "reference": "Needs to be mentioned in `__all__` below." + }, + { + "prediction": "I think this should be `is_repeat_handle_pre_extended_syscall_sigmasks`", + "reference": "What if the app's signal handler, executed at pre-syscall for epoll_pwait, executes its own epoll_pwait? For that matter: what happens natively if that happens? I would not expect the kernel to keep a stack -- does that clobber the kernel's stored pre-syscall mask?" + }, + { + "prediction": "I think it's better to say \"When available, this information is used for planning scan tasks whose boundaries are determined by these offsets. It is important that the returned list is sorted in ascending order.\"", + "reference": "Nit: missing a space. I think we should phrase the new content a little differently. \"It is important\" isn't very clear. I think it should be \"offsets will be returned in sorted order.\"" + }, + { + "prediction": "I think you can remove this line.", + "reference": "Can you remove this blank line and put the added import in sorted order (likely your editor will do this)" + }, + { + "prediction": "I think this should be `if (err != 0) { fprintf(stderr, \"[OCSP Stapling] pthread_create for ocsp_updater_thread failed. errno:%d\\n\", err); return -1; }`", + "reference": "Even if `pthread_create()` for `ocsp_updater_thread()` fails, `h2o` can continue to serve. But I'm a little worried whether `h2o` should continue to serve in this case. How about you?" + }, + { + "prediction": "I think it would be better to move these constants to the `constants.js` file, so that they can be used in other files as well.", + "reference": "I like introduction of these constants for account/container creation, but the `ACCOUNT_CHOOSE` one isn't needed I think. This should instead be an \"empty\" value (either `''` or `0`), to indicate more clearly that this field is not filled. It should be the same for choosing a container." + }, + { + "prediction": "I think this should be `Blockly.scratchBlocksUtils.compareStrings = function(str1, str2) { return str1.localeCompare(str2, undefined, { sensitivity: 'base', numeric: true }); };`", + "reference": "I noticed that passing in `[]` for the locales argument instead of 'undefined' seems to have the same effect. I think that's preferred over passing in `undefined` as a value, and unfortunately passing in `null` seems to throw an error." + }, + { + "prediction": "I think this should be `if strings.Contains(DbCfg.Host, \":\") && !strings.HasSuffix(DbCfg.Host, \"]\") && !strings.HasSuffix(DbCfg.Host, \":\")`", + "reference": "1. `0` is redundant. 2. We should save result of `strings.LastIndex(DbCfg.Host, \":\")` to a variable and reuse." + }, + { + "prediction": "I'm not sure this is the right place for this flag. I think it would be better to have it in the `ServerOptions` struct.", + "reference": "Do you envision \"new\" servers not supporting header, or is it more a way to test mix of old and new? If so, we could make it a \"private\" (non exported) option." + }, + { + "prediction": "I think this should be `failed to unmarshal session config`", + "reference": "For future reference. Try not to do refactoring in the same PR which solves some bug or implements some feature. Not to clutter reading. Do it in separate PR." + }, + { + "prediction": "I think we should keep `asset` as the flag name, and add `unit` as an alias.", + "reference": "I'm not sure about changing the flag name. unit is more accurate, but for I think for most people asset is also a fine name to use." + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to work for me.", + "reference": "Which windows gets activated? A random other window?" + }, + { + "prediction": "I think this should be `event = event.AsV03()`", + "reference": "Just to make sure, this is totally lossless? If I put a v2 there, then it gets upgraded to v3, but my function expects v2, then this is fine and nothing is lost?" + }, + { + "prediction": "I think this should be `write.watermark.field` and `write.watermark.value` instead of `write.watermark.field` and `write.watermark`.", + "reference": "In the past, we have 3 Flink streaming jobs (1 for each AWS region) writing to the same table. We need to write to 3 different watermark table properties (1 for each region). Watermark consumer then use the min value to determine the overall table watermark. A provider pattern similar to `WRITE_LOCATION_PROVIDER_IMPL` can work. A default impl could be a single property name. not sure if there is a simpler way to achieve this." + }, + { + "prediction": "I think this should be `map[keybase1.UID]keybase1.NormalizedUsername`", + "reference": "Can you change this to `ResolvedUsersMap` and build a new map with both readers/writers? That way, we get the nice side effect of not exposing the internal map of the handle, and simplifying the callers a bit." + }, + { + "prediction": "I think we can remove the `useUnifiedTopology: true` option here as well.", + "reference": "I typically try to avoid nested ternary expressions. Can we rewrite this as if statements? Worst case, can we break it out into its own function?" + }, + { + "prediction": "I think this should be `tls_start.ssl_conn.set_tlsext_host_name(tls_start.context.client.sni.encode('utf-8'))`", + "reference": "Do we still support handshakes without SNI present?" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think it should be an error, not a warning.", + "reference": "Maybe it's because I work too much on a centralized logging system but it could be great to add a \"category\" like \"attribute\", \"substitution\", \"include directive\", \"macro\", \"extension\"..." + }, + { + "prediction": "I think this should be \"it has no sense in python\"", + "reference": "it have no sense in python -> it makes no sense in python" + }, + { + "prediction": "I'm not sure this is the best way to do this. I think it would be better to have a separate pool for openvpn ports.", + "reference": "maybe just do a separate implementation of the pool for openvpn case? It's a bit confusing having two methods here." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should only close the topology if it was created in this function. If it was passed in, we should not close it.", + "reference": "how is it possible to have a `topology` that is falsey when we had to call `topology.connect` in order to get here?" + }, + { + "prediction": "Use the new Ruby 1.9 hash syntax.", + "reference": "Do we need this expectation? If we don't call this method on `PlanFinder` there's no way for the `10` to be returned. Seems somewhat redundant. What do you think?" + }, + { + "prediction": "why remove this?", + "reference": "We need to do the same for edgecore" + }, + { + "prediction": "I think we can remove the `waitHandle.WaitOne();` and just use `mockHandler.Verify(mh => mh.HandleTestRunComplete(null, null, null, null), Times.Once);`", + "reference": "This fix has nothing to do with the product change. Just a fix I am making for the test issue." + }, + { + "prediction": "I think we can remove this TODO now.", + "reference": "Don't know what should be the default. Lets keep BatchingProcessor for now. And revisit the area after beta." + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "Ah that's how it's happening, it's probably using the `require_relative` in the optimised one and that counts as a different require to the bare one." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in the `MvxSimpleTableViewSource` constructor.", + "reference": "What happens if there is no NIB/XIB with that name?" + }, + { + "prediction": "Why is this change needed?", + "reference": "this is not necessary?" + }, + { + "prediction": "nit: I think we can remove the `asmsecretres` alias here and just use `asmsecret` everywhere in this file.", + "reference": "typo: `asmsecrets \"github...`" + }, + { + "prediction": "I think this should be `return wp_json_encode( $allowed );`", + "reference": "I think that the JSON encoding should be handled by the control itself, not the sanitization function. This should only confirm that the input is correct, not reformat it" + }, + { + "prediction": "I think this should be `return i.transports`", + "reference": "Should we put a TODO here to route the http.Transport through here?" + }, + { + "prediction": "Why do we need to specify the computer name here?", + "reference": "Sorry, could you explain more about the issue? Doesn't ComputerName already default to local computer? > -ComputerName Specifies one or more Hyper-V hosts on which the virtual switch is to be configured. NetBIOS names, IP addresses, and fully qualified domain names are allowable. The default is the local computer. Use localhost or a dot (.) to specify the local computer explicitly." + }, + { + "prediction": "I think this should be `if err != nil && !allowError {`", + "reference": "`allowError` is a big vague. Does this mean the test case is asserting that an error should occur? If it means \"maybe an error can occur, and that's okay\" -- what's an example of this?" + }, + { + "prediction": "`alias.IOAddress` returns an `address.Address` not `address.Address`", + "reference": "return statements should not be cuddled if block has more than two lines (from `wsl`)" + }, + { + "prediction": "I think this should be `java.lang.reflect.NotImplementedException`", + "reference": "Why does VirtualMachineMetrics have to implement Metric?" + }, + { + "prediction": "This test should be updated to check the error returned by `m.SignVote(vote)`.", + "reference": "line is 121 characters" + }, + { + "prediction": "`name.slice(0, 2) === 'on'` is not the same as `name[0] === 'o' && name[1] === 'n'`", + "reference": "How's that linked esbench looking with slice?" + }, + { + "prediction": "I think this should be `path_parts[-1]` instead of `fn`", + "reference": "The split and join was probably done to ensure that this still works on Windows because os.path.dirname works differently depending on the os you're running under :(. It would probably be a little better to do `dirname, _, fn = path.rpartition('/')` if you want something cleaner than the split/join." + }, + { + "prediction": "I think this should be `return sessions.size();`", + "reference": "This is not the right approach. The `Distributor` maintains a model of the current state of the Grid. That model already contains the information about every active session. We don't need to modify `SessionMap` to expose it further." + }, + { + "prediction": "I think this should be `s.maybeResetTimer(time.Time{})` instead of `s.maybeResetTimer(pacingDeadline)`", + "reference": "Can you make this a member var as all the other deadlines? Then you can drop the param to resetTimer() and simplify some of the code below iiuc." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to make the tests pass.", + "reference": "I don't understand the reason for the changes from unique_ptr to ROMOL_SPTR that you made in this file. The pointers aren't being shared or used elsewhere so I don't think there's any reason to make them shared. Did I miss something?" + }, + { + "prediction": "I think this is a typo. It should be `PLUGINS` instead of `PLUGIN`.", + "reference": "why change the variable name at all?" + }, + { + "prediction": "I think this should be `if (vNode.actualNode === node || vNode.shadowId === shadowId) { return vNode; }`", + "reference": "Since I'm still trying to keep these straight in my head, can you elaborate on what problem this solves?" + }, + { + "prediction": "This should be `mAccount != null && !TextUtils.isEmpty(mAccount.getReportSpamRecipient())`", + "reference": "Prefer TextUtils.isEmpty() which handles getReportSpamRecipient() being null" + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.", + "reference": "Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else." + }, + { + "prediction": "I think this should be `d.GetValues(\"Include\")` and `d.GetValues(\"Exclude\")`", + "reference": "Do we actually use Include anywhere yet or is this just for completion?" + }, + { + "prediction": "\"Send the Referer header\" -> \"Value to send in the `Referer` header\"", + "reference": "It still bugs me this was misspelled in the standard and now the wrong spelling is the commonly used one :wink:" + }, + { + "prediction": "I think we can remove the double quotes around `paper-icon-button-light` and `btnRemovePath` as well.", + "reference": "seems we missed de-uglifying this one" + }, + { + "prediction": "I think this should be `NewWorkflowTypeUnspecified` to be consistent with the other constants.", + "reference": "i guess these types & cron / retry specific belong to a dedicated util / struct" + }, + { + "prediction": "I don't think we need to join here. `sendKeys` should be able to accept an array of strings.", + "reference": "Also update line 2205 below" + }, + { + "prediction": "I think this should be `direction: { default: \"vertical\", type: String, validator: function(value) { return value === \"vertical\" || value === \"horizontal\"; } }`", + "reference": "`direction` is referenced nowhere. Do I miss something?" + }, + { + "prediction": "I think we can remove this now that we're not using `deparam` anymore.", + "reference": "The two places this was used have been removed so we can fully remove this dependency." + }, + { + "prediction": "I think we can remove this line as well.", + "reference": "This is a duplicate generation of the same file as below." + }, + { + "prediction": "`model.cuda(gpu_ids[0])` will move the model to `gpu_ids[0]`, and `device_ids=gpu_ids` will move the model to `gpu_ids[0:cfg.gpus]`.", + "reference": "We may deprecate `gpus` if `gpu_ids` is specified." + }, + { + "prediction": "I think this should be `LOG.fine`", + "reference": "Right now this is experimental and deeply flaky. We left this at `info` to make debugging user reports a lot easier." + }, + { + "prediction": "This looks like some kind of obfuscated code. Can you remove it?", + "reference": "unnecessary spaces here are doubling the size of this otherwise extremely useful addition" + }, + { + "prediction": "I'm not sure if this is the right thing to do. I think we want to overwrite if newer, but I don't think we want to overwrite if newer if it's the same file. I think we want to overwrite if newer if it's the same file, but I don't think we want to overwrite if newer if it's the same file. I think we want to overwrite if newer if it's the same file, but I don't think we want to overwrite if newer if it's the same file. I think we want to overwrite if newer if it's the same file, but I don't think we want to overwrite if newer if it's the same file. I think we want to overwrite if newer if it's the same file, but I don't think we want to overwrite if newer if it's the same file. I think we want to overwrite if newer if it's the same file, but I don't think we want to overwrite if newer if it's the same file. I think we want to overwrite if newer if it's the same file, but I don't think we want to overwrite if newer if it's the same file. I think we want to overwrite if newer if it's the same file, but I don", + "reference": "I think we should use `FileExistsPolicy.Overwrite` instead. Files _should_ always be newer, but in the unlikely case they wouldn't be, I'm afraid some files would be overwritten and other not, leading to inconsistencies that will be hard to figure out." + }, + { + "prediction": "I think this should be `std::cout << \"test3_5\" << std::endl;`", + "reference": "this should probably be removed" + }, + { + "prediction": "I think we should keep the `\\t` here, as it makes the output easier to read.", + "reference": "Nit: I would actually prefer that pretty JSON is the default, with a flag for compressed JSON. Can we acheive that easily?" + }, + { + "prediction": "I think this should be a `map[SecurityGroupRole][]IngressRules` so that we can have multiple ingress rules for each role.", + "reference": "Will need to think about this one. `additionalIngressRules` feels a bit opaque in terms of eventual outcome." + }, + { + "prediction": "I think this should be `private static int fieldId(TypeDescription orcType) {`", + "reference": "Can we avoid making this public with the other updates?" + }, + { + "prediction": "I don't think this is correct. If you have 1000 images, and you want to resize them to 1000x1000, then you need 1000x1000x3x1000x1000 = 3000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "reference": "Why did you change this equal instead of less or equal?" + }, + { + "prediction": "I think it would be better to have a single method `getMutable(Hash rootHash, Optional blockHash)`. If `blockHash` is not present, we can just ignore it.", + "reference": "missing final for the blockHash field" + }, + { + "prediction": "Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", + "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." + }, + { + "prediction": "`expand_as` is not FP32, it's still FP16.", + "reference": "`x_float` instead of `float_x`." + }, + { + "prediction": "I don't think we need to import the css here. It should be included in the bundle already.", + "reference": "Is this for `No Babel config ...` from ESLint? If so, it will be fixed in my ES6 PR." + }, + { + "prediction": "Should this be `t.Fatal(err)`?", + "reference": "Not important, but the code used to keep checking other cases even after one of them failed, and now it's not. Fine either way for me, just noticing." + }, + { + "prediction": "I think we can remove this import.", + "reference": "I think I saw this line in last PR, you can update your base branch and rebase to avoid this. And it would be awesome if you can rebase instead of merge each time you push PR to the `moby` branch, that will make the commits history clearer." + }, + { + "prediction": "I think this should be `if (get_thread_id() != tid) {`", + "reference": "If this can change the PC of this thread, it requires handling: we can't blindly execute the syscall and lose control of the thread when the flags include CONTEXT_CONTROL. (Note that most docs imply that setting your own context this way is not supported or has undefined or unpredictable results: any idea how often that's the case, or does it generally work?) We need to handle in a similar fashion to NtContinue or setting another thread's context to ensure we retain control." + }, + { + "prediction": "I don't think we need this endpoint. We can get the total count from the first page of results.", + "reference": "@huzaifaiftikhar Changed the endpoint as suggested by Stephane in the latest commit." + }, + { + "prediction": "I'm not sure what you mean by this. Can you elaborate?", + "reference": "There's no core.Number yet. ;)" + }, + { + "prediction": "`$ mayactl snapshot revert --volname --snapname ` -> `mayactl snapshot revert --volname --snapname `", + "reference": "..., ...will be posted." + }, + { + "prediction": "I think this should be `go-filecoin show block --json`", + "reference": "Can you update this function to be `ShowHeader`? There is only one use of it at the moment in `tools/fast/series/get_head_block_height.go`." + }, + { + "prediction": "I think this should be `os.getenv('QUILT_USE_TQDM', 'true').lower() == 'true'`", + "reference": "@akarve, this disables `tqdm` by default, is it intended? Also name `QUILT_USE_TQDM` might be too specific, IMHO `QUILT_INTERACTIVE` or `QUILT_PROGRESS_BARS` or something might be better." + }, + { + "prediction": "nit: I think we can just use `time.Millisecond * waitTimeoutMillis` instead of `time.Duration(waitTimeoutMillis) * time.Millisecond`", + "reference": "unrelated but just changing for consistency with code below it" + }, + { + "prediction": "I think this should be `opts !== FORCE_RENDER && component.shouldComponentUpdate && component.shouldComponentUpdate.call(component, props, state, context) === false`", + "reference": "This will call `componentWillUpdate()` for mounts because the else clause is removed. It should only be called for updates." + }, + { + "prediction": "I think this should be `bucket: ['write', 'read']` and `history: ['write', 'read']` instead of `bucket: ['write', 'read'], history: ['write', 'read']`", + "reference": "We should add write inheritance too." + }, + { + "prediction": "I think this should be `JAVA_OPTS = os.environ.get('JAVA_OPTS', '').strip().split(' ')`", + "reference": "Please rename this to `LAMBDA_JAVA_OPTS`, and add a short description to the README." + }, + { + "prediction": "I think it's better to use `github.com/google/uuid` instead of `github.com/satori/go.uuid`.", + "reference": "Should be in the same import group." + }, + { + "prediction": "I think this should be `pkt.tls_session.tls_version or 0x0303 > 0x0200`", + "reference": "Operator precedence is very confusing here. Care to add parentheses? ` ((version or 0x0303) >= 0x0200)` Same below." + }, + { + "prediction": "This import is not needed.", + "reference": "javaparser-core has no dependencies and it should stay that way. So no log4j. And even then there would have been a preference for slf4j." + }, + { + "prediction": "I'm not sure this is the best way to do this. I think it would be better to add a new field to the `FileFormat` table to indicate whether or not a format should be re-tested. This would allow us to add new formats to the database without having to change the code. It would also allow us to remove formats from the database without having to change the code. What do you think?", + "reference": "Why not just retest all? it's not expensive (I think)." + }, + { + "prediction": "I think we can remove this file now.", + "reference": "ecr and ecr0 aren't deterministically named here. This change will just cause confusion in the git history. Could you either: a) fix this and make it deterministic b) regenerate the mock until it doesn't flip definitions for ecr and ecr0" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to work.", + "reference": "This looks like bash... does this work in ruby? Or is the idea to inject the entire script into the subsequent commands?" + }, + { + "prediction": "I think we can remove the `traceparentCollection?.First();` and just do `var traceparent = traceparentCollection.First();` and then add `if (traceparentCollection == null || traceparentCollection.Count == 0) { return SpanContext.Blank; }`", + "reference": "I don't understand why this change is in this PR?" + }, + { + "prediction": "Style/ClassAndModuleChildren: Avoid using class and module together.", + "reference": "It's a little hard to tell from the diff, but as a result of this PR, the only non-deprecated helpers are: - `has_facet_values?` (probably not long for this world) - `render_facet_partials` (perhaps part of a future component) - `render_facet_limit` (possibly obsolete once components get traction) - `facet_field_in_params` (a little tricky to deprecate at the moment) - `facet_field_presenter`" + }, + { + "prediction": "I think we can remove these lines now, right?", + "reference": "The right-hand part shouldn't use `__proto__`. Should be just `PersonObject.__proto__ = Realm.Object`." + }, + { + "prediction": "I think we should return an error here instead of panicking.", + "reference": "the == case might be legit, or not? If there is no task written since last read, but we trigger a new read, would the min == max? Or should the upper layer handle that case?" + }, + { + "prediction": "I think this should be `memcpy(new_p, p, old_size < new_size ? old_size : new_size);`", + "reference": "Good catch! But is it guaranteed that `old_size < new_size` here? If not, wouldn't we want to take `min(old_size, new_size)` as the copy length?" + }, + { + "prediction": "I think this is a false positive. The `InstallProgram` method is not hiding the `InstallProgram` method in the base class.", + "reference": "This is the only one that worries me a bit. It would be good if Brendan signed off on it." + }, + { + "prediction": "I think this should be called `isLongrunningReturnValue` to be consistent with `isLongrunningOperation`.", + "reference": "`LongRunningOperationDetailView` already has `isEmptyOperation`." + }, + { + "prediction": "I don't think this is the right way to do it. The `base64.b64encode` function returns a `bytes` object, not a `str` object, so you'll get a `TypeError` when you try to format it into the `Authorization` header. You should use `base64string = base64.b64encode('%s:%s' % (parsed_url.username, parsed_url.password)).decode('utf-8')` instead.", + "reference": "This will always add the authorization header to the request object. Is this the right scope for these two lines? If username/password are not defined, it will encode 'Basic :'" + }, + { + "prediction": "Style/SymbolArray: Use %i or %I for an array of symbols.", + "reference": "Don't think a scope adds much value for us here. Also, for future reference, you don't need to use the `self.all` it is implied. Could just be: `scope :updated_at_desc, -> { order(updated_at: :desc) }` No need to change this one now though, it works." + }, + { + "prediction": "Style/RedundantReturn: Redundant return detected.", + "reference": "I believe `Base.` is unnecessary in this case, as the class already extends `Base`." + }, + { + "prediction": "`fillWidth` and `fillHeight` don't seem to be supported by the API. `maxWidth` and `maxHeight` do.", + "reference": "Couldn't this result in images being scaled too small when the width is less than the height assuming the width is still what is being passed here?" + }, + { + "prediction": "I think it would be better to use `plugins.getConfig(\"api\", \"offline_mode\")` instead of `plugins.getConfig(\"api\").offline_mode`", + "reference": "Here also, let's not cache value on top of file, but use `plugins.getConfig(\"api\").offline_mode` directly where it is needed" + }, + { + "prediction": "I think this should be `isset($config->Catalog->shibboleth_library_cards) && $config->Catalog->shibboleth_library_cards && ($this->getAuthManager()->getAuthMethod() == 'Shibboleth')`", + "reference": "You can combine the two checks into a single `!empty()` check." + }, + { + "prediction": "I think this should be `o.MaxPayload > o.MaxPending`", + "reference": "Should we add a warning for anything over say 8M? Just suggesting that is not recommended?" + }, + { + "prediction": "I think you can remove the `codec` arg now.", + "reference": "Looks like there are no callers left of this function." + }, + { + "prediction": "I'm not sure this is the right way to do this. I think we should have a single `ExecWithTimeout` function that takes an `io.Reader` for stdin and an `io.Writer` for stdout/stderr. Then we can just pass `os.Stdin` and `os.Stdout` when we don't want to attach stdin/stdout/stderr.", + "reference": "Should there still be a ` bool` trailing `showOutput`?" + }, + { + "prediction": "remove empty line", + "reference": "Did we can change to v1" + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think it would make more sense to do this in the `catchErrorInComponent` function.", + "reference": "Can you please double check that this won't break anything?" + }, + { + "prediction": "I think it's better to pass `null` instead of `string.Empty` here.", + "reference": "optionals, shouldn't need to be stated explicitly" + }, + { + "prediction": "I don't think this is correct. 0x51303439 is version 49, not 39.", + "reference": "That seems quite low - why not just 0x5130ffff?" + }, + { + "prediction": "I don't think this is necessary.", + "reference": "Why is this needed ?" + }, + { + "prediction": "I think this should be `Bolt::Config.user_path + '.first_runs_free'` instead of `Bolt::Config.user_path + '.first_runs_free'`", + "reference": "`Bolt::Config.user_path` returns `nil` if there's no homedir, so this will still error in that case." + }, + { + "prediction": "I'm not sure if this is the right place to put this, but I think it would be nice to have a `String()` method on `CompoundMessage` so that we don't have to do this kind of thing all over the place.", + "reference": "nit: use %s for strings and %v for objects." + }, + { + "prediction": "I don't think we should remove this property. It is used in the `TTemplateParamClass::render()` method to render the `as` part of the template parameter. If we remove this property, we will have to remove the `as` part of the template parameter from the `TTemplateParamClass::render()` method as well. I think it is better to keep this property and remove the `as` part of the template parameter from the `TTemplateParamClass::render()` method.", + "reference": "Same as before, the properties already exists in parent" + }, + { + "prediction": "I don't think this will work. You need to use `datetime.datetime.now().year` instead of `datetime.datetime.now().year`", + "reference": "This fix is not quite correct. The `%s` should be replaced with `version` and the `%d` on line 39 should be replaced with `datetime.datetime.now().year`." + }, + { + "prediction": "I think this should be `strcmp(type, \"gone\") != 0 && strcmp(type, \"pause\") != 0`", + "reference": "Maybe we should only set active = false if `strcmp(type, \"pause\") == 0`?" + }, + { + "prediction": "I think this should be `options[:page_ranges] = Array(options[:page_ranges])`", + "reference": "Same here. and all others." + }, + { + "prediction": "I think this should be `github.com/keybase/stacktraces/on/SIGUSR2`", + "reference": "Intentionally committed? I'm not against it, we already have a way to get goroutines without killing the process: `/keybase/.kbfs_profiles/goroutine`." + }, + { + "prediction": "This line is not needed.", + "reference": "I think this blank line may be removed" + }, + { + "prediction": "I think it would be better to raise an error if `toggle` is True and the bookmark already exists.", + "reference": "I think this should be a keyword-only argument, i.e. do `def add(self, url, title, *, toggle=False):` and adjust the caller to do `toggle=toggle`." + }, + { + "prediction": "DevStatus should be UINT32 * instead of UINT32", + "reference": "@aimanrosli23 Judging from the commit description, I do not know why this file got changed so much. Could you help to double confirm if you do not revert the changes brought by commits: SHA-1: 643623147a1feaddd734ddd84604e1d8e9dcebee * MdeModulePkg/SdMmcPciHcDxe: Send SEND_STATUS at lower frequency SHA-1: 49accdedf956f175041040e677163b7cbb746283 * MdeModulePkg/SdMmcPciHcDxe: Hook SwitchClockFreq after SD clock start" + }, + { + "prediction": "Style/SymbolArray: Use %i or %I for an array of symbols.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.", + "reference": "How about YAML.load_file()" + }, + { + "prediction": "I think we can remove this field and just call `isInitialized()` on the `MetricsManager` instead.", + "reference": "Maybe make this `volatile` or atomic as this can be set/read from different threads? Also, separately you may want to check if some of the methods here need to be `synchronized`." + }, + { + "prediction": "I think this should be `drmgr_unregister_bb_instrumentation_event(drwrap_event_bb_instrumentation);`", + "reference": "Check the return value of the drmgr ones." + }, + { + "prediction": "I don't think we need to add `data-cfasync` here.", + "reference": "This should be `'cache'`" + }, + { + "prediction": "I think this should return a `*os.File` instead of `error`.", + "reference": "The name \"old\" might cause confusion here. After installation, the \"old\" repo is at an archived path, and the new migrated repo is at the old path. Maybe something like \"target\" or \"canonical\"?" + }, + { + "prediction": "I think this should be `command.readPreference = options.readPreference;`", + "reference": "I think this is somewhat definitive proof that this error exists in `core` rather than `native`. We are correctly resolving the `readPreference` in the previous line, but you are able to identify that eventually the command generated in `core` is not decorated with the passed `readPreference`. Did you try to solve this there already?" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but I think it's better than just unwinding to `to - 1`.", + "reference": "During genesis sync it can unwind 5M blocks?" + }, + { + "prediction": "I think we can remove this now.", + "reference": "was it caused by the removal of removeTaskQueueManager() from this test?" + }, + { + "prediction": "Line is too long. [82/80]
Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Wouldn't it just be easier to force search_session to return `with_indifferent_access`? Since you've done the hard work already, I don't think there's a problem doing it this way, but.." + }, + { + "prediction": "I think this should be `if (rp->rr_sim_misses_deadline) return false;`", + "reference": "So, such tasks that could possibly not meet the deadline will never have a chance to run? I think this is not nice behavior, especially for those projects who has sometimes some very small tasks after the big one." + }, + { + "prediction": "This should be `if (id == 0) { lua_pushnil(L); return 1; }`", + "reference": "You should add the check above this line instead. If string is empty, don't even call the function." + }, + { + "prediction": "I think this should be `LOGGER.warn(\"clientCert for item doesn't exist. Will set it to false. Item: {}\", item.toString(), ex);`", + "reference": "If clientCert attribute doesn't exist for some reason I set it to false." + }, + { + "prediction": "I think this should be `if Travis::Build.config&.ssl&.verify == false` instead of `if Travis::Build.config&.ssl&.verify == false`", + "reference": "Do we need `app_host_flags` variable? We can directly concat with `flags`. `sh.cmd curl_cmd(unless Travis::Build.config&.ssl&.verify ? flags + ' -k' : flags, location, static_file_location), cmd_opts` right?" + }, + { + "prediction": "Why is this moved here?", + "reference": "Walk should actually be completed (`onWalkCompleted`) after the event is stopped. This also makes it possible for monster to walk by smaller paths." + }, + { + "prediction": "I think this should be `len(address.Bytes()) == swarm.EncryptedReferenceSize`", + "reference": "typo in `weather` (should be `whether`)" + }, + { + "prediction": "I think this should be `--use-staging-install-media` to be consistent with the other flags.", + "reference": "Thoughts on having the URI as the param, instead of a boolean? The default value would be the normal prod image, and then your test would override with the staging image." + }, + { + "prediction": "Why is this unused? It seems like it should be used to check the return value of `fscanf`.", + "reference": "I'm surprised this is needed, but we should probably assert num_scan == 1 at least, otherwise I expect the file is pretty broken." + }, + { + "prediction": "`{0, network::NetworkUtils::getAvailablePort()}` -> `{0, network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils::getAvailablePort(), network::NetworkUtils", + "reference": "Could we set a default value for `partitions` and `{0, network::NetworkUtils::getAvailablePort()}` ?" + }, + { + "prediction": "Should this be `TimeSpan? MinimumTime { get; set; }`?", + "reference": "Needs xml docs. The API names alone don't provide enough explanation about what these mean and how to set them. Also, we should provide some validation of inputs, such as MaxTime must be > MinTime, MinimumRate must be >= 0, etc. Consider making the properties readonly and adding a constructor that does these validations." + }, + { + "prediction": "I think this should be `os.Getenv(\"TESTDATA\")` or something like that, so that we don't have to hardcode the location of the testdata directory.", + "reference": "Would it make sense to create an empty file here, perhaps in a tmp dir, instead of checking empty files into Git?" + }, + { + "prediction": "I don't think this is correct. You need to close the brackets for the `if (array_only_lengths.size() > 0)` block as well.", + "reference": "This change is due to `clang_format` and is not related to this PR." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the signal handler itself, so that we don't have to worry about it in other parts of the code, and so that we don't have to remember to do it everywhere we call `block_all_signals_except()`.", + "reference": "Why did you not add the signals to the call of block_all_signals_except() and instead baked them into the function? Ok, if you had a good reason for it, otherwise I would add it to the except list of the function call, since that's what it was meant for." + }, + { + "prediction": "I think this should be `FeedFileDownloadStatusRequesterInterface` instead of `FeedFileDownloadStatusRequester`.", + "reference": "Could this be done by mocking objects instead? I feel like this is changing too much of the actual logic just for the tests." + }, + { + "prediction": "I think this should be `private Integer contentSpecId = null;` and `private Integer content = null;` should be removed.", + "reference": "why not just use `ManifestContent` instead of `Integer`?" + }, + { + "prediction": "I think it would be better to move this check to the `IsWellFormed` method, so that we don't need to pass `releaseSpec` to the `IsWellFormed` method. Also, I think it would be better to move this check to the `IsWellFormed` method, so that we don't need to pass `releaseSpec` to the `IsWellFormed` method. Also, I think it would be better to move this check to the `IsWellFormed` method, so that we don't need to pass `releaseSpec` to the `IsWellFormed` method. Also, I think it would be better to move this check to the `IsWellFormed` method, so that we don't need to pass `releaseSpec` to the `IsWellFormed` method. Also, I think it would be better to move this check to the `IsWellFormed` method, so that we don't need to pass `releaseSpec` to the `IsWellFormed` method. Also, I think it would be better to move this check to the `IsWellFormed` method, so that we don't need to pass `releaseSpec` to the `Is", + "reference": "can we do that in TxValidator?" + }, + { + "prediction": "I don't think we need to store the service name here.", + "reference": "We definitely want some detailed and thoughtful docs being added to this type." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should always initialize the XDP state, even if XDP is not enabled. This is because we need to be able to clean up the XDP state when we stop the dataplane driver. If we don't initialize the XDP state, we won't be able to clean up the XDP state when we stop the dataplane driver, and we'll leave the XDP state in an inconsistent state.", + "reference": "We would like this code to run, even when `config.XDPEnabled` is false, so that Felix can clean up its own XDP state after a restart." + }, + { + "prediction": "`if (spaceRet.left() == ResultCode::ERR_SPACE_NOT_FOUND) { LOG(INFO) << \"Space \" << spaceId << \" does not exist, skip it.\"; return ResultCode::SUCCEEDED; }`", + "reference": "If the status is `ERR_SPACE_NOT_FOUND` why return `SUCCEEDED` ?" + }, + { + "prediction": "`reverse (bool): Reverse the order of planes in layer sequence. False for ResNet, True for Houglass. Default: False` -> `reverse (bool): Reverse the order of planes in layer sequence. False for ResNet, True for Hourglass. Default: False`", + "reference": "It is is more appropriate to use `downsample_first`. If `downsample_first=True`, the downsample block is the first block and it is used for ResNet. If `downsample_first=False`, the downsample block is the last block, which is used by Hourglass network." + }, + { + "prediction": "I think we can remove this now.", + "reference": "Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`)" + }, + { + "prediction": "I think it would be better to say \"Instead of using `exit()` or `quit()`, consider using the `sys.exit()` function.\"", + "reference": "I don't know if there are strict conventions about this, but I think the name of the warning should be the diagnosis, not the suggested course of action. In this case, that would mean changing the name of the warning to `interactive-exit` or something like that." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it is. The `CommonNameForCertificate` function is only used in one place, and that is in the `pki` package. The `pki` package is only used in the `cert-manager` package, and the `cert-manager` package is only used in the `controller` package. So, the `CommonNameForCertificate` function is only used in the `controller` package, and the `controller` package is only used in the `controller` package. So, the `CommonNameForCertificate` function is only used in the `controller` package, and the `controller` package is only used in the `controller` package. So, the `CommonNameForCertificate` function is only used in the `controller` package, and the `controller` package is only used in the `controller` package. So, the `CommonNameForCertificate` function is only used in the `controller` package, and the `controller` package is only used in the `controller` package. So, the `CommonNameForCertificate` function is only used in the `controller` package, and the `controller` package is only used in the `controller", + "reference": "If `crt.Spec.CommonName` is not set, and `cert.Subject.CommonName` *is* set, we are not correctly handling it here." + }, + { + "prediction": "I don't think this is necessary, since `cmdhistory.init()` is already called in `conftest.py`.", + "reference": "This isn't a test, so it shouldn't be named `test_init`. You could name it `cmdhistory_init` or so." + }, + { + "prediction": "I think this should be `configuration.get_config().getint(self.spark_version, \"pickle-protocol\", pickle.HIGHEST_PROTOCOL)`", + "reference": "why is this pulling from `self.spark_version` config section rather than the `spark` config section (`py-packages` appears to pull from a config section called `spark`)" + }, + { + "prediction": "I think this test is wrong. If the port is set to `RANDOM_PORT` then it should be set to a random port, not 0.", + "reference": "nit: Think it can be one line.." + }, + { + "prediction": "I think we should not use `import java.util.*;` and `import java.util.concurrent.*;`", + "reference": "please inline imports" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it is. If we're in a rootless container, we don't want to join the cgroups of the rootless container, we want to join the cgroups of the root container.", + "reference": "This check is still correct in some cases, but I guess erroring out is acceptable if someone explicitly asked for an impossible cgroup configuration (now that we could in principle nest things). I would like to see a test for this though." + }, + { + "prediction": "I think this should be `aggregates changed to operate on just a single column.`", + "reference": "Should we update integral to operate on a single column as well?" + }, + { + "prediction": "I think this should be `KOKKOS_IMPL_CUDA_SAFE_CALL(cudaMemcpyAsync(dst, src, n, cudaMemcpyDefault, instance.stream));`", + "reference": "Doesn't belong to this PR" + }, + { + "prediction": "This is a breaking API change. We need to add a new method to ECSClient and deprecate this one.", + "reference": "Just for my own understanding, does aws ecs API take this token as a new input attribute? Which version of the aws sdk? I did not find it in the official aws sdk doc." + }, + { + "prediction": "I think this should be a constant in the `AppFeatureCode` class.", + "reference": "Could we shorten this constant to maybe `FEATURE_USER_AUTH`?" + }, + { + "prediction": "I think this should be `numRekeyQueueWorkers`, since it's the number of workers in the rekey queue, not the number of rekey workers.", + "reference": "Any particular reason for 8? I feel like we could probably handle more..." + }, + { + "prediction": "Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.", + "reference": "Try to use factory association declaration for default values, so it could minimal the line length. You may write in fetch_job factory like association :repository, factory: :repository." + }, + { + "prediction": "I'm not sure this is the best way to do this, but it's the only way I could think of to add a class to the row.", + "reference": "Should the \"cancelled\" class be added regardless of the proposal's state?" + }, + { + "prediction": "nit: remove empty line", + "reference": "nit: random whitespace change, let's try to keep these out of commits unless there are other useful changes." + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "Seems kinda dangerous - what if models length is different from paths length?" + }, + { + "prediction": "I think we can remove the `prune.Mode{}` here as well.", + "reference": "set real one plz (get it from DB)." + }, + { + "prediction": "(style) line over 80 characters", + "reference": "Should this be initialized to zeroes?" + }, + { + "prediction": "I'm not sure this is the right fix. I think we should be able to get the count from the searcher even if there are no documents in the base.", + "reference": "The query is already built at this point, so I don't think this particular change actually helps wrt SOLR-10732? (and the `base.size()==0` case is already trivially optimized in `SolrIndexSearcher.numDocs(Query, DocSet)`)" + }, + { + "prediction": "Please revert this change.", + "reference": "re-add the type in the annotation here" + }, + { + "prediction": "I think we can just return `stderr.String()` here, as `err` will be `nil` if there is no error.", + "reference": "Could we simpify it as `cmd.Stderr = &bytes.Buffer{}`?" + }, + { + "prediction": "I think this should be `return now.After(cert.NotAfter)`", + "reference": "there's enough \"nots\" in here that while it's correct by my review, I'd like to see a small unit test (just passing in an expired and non-expired cert)" + }, + { + "prediction": "I think we need to update the go.mod/go.sum files as well.", + "reference": "File is not `goimports`-ed (from `goimports`)" + }, + { + "prediction": "I think this should be `1e-6` instead of `10e-6`.", + "reference": "The config option should probably have a more specific name. Also it's not for all gridded data but specifically for Images (and its subclasses)." + }, + { + "prediction": "I think this should be `onView(withText(otherTheme)).perform(click());`", + "reference": "Be careful. This is not a preference but an option in a dialog." + }, + { + "prediction": "I think this should be `deployment.Spec.Template.Labels` instead of `deployment.Labels` since we want the labels of the pods, not the labels of the deployment.", + "reference": "this will modify the incoming object, which may not be desirable in some cases. i think we should stick with the local var, override it with deployment.ClusterName if deployment.ClusterName not empty" + }, + { + "prediction": "Why is this not needed anymore?", + "reference": "Is this not required?" + }, + { + "prediction": "I think this should be `if (input.type === Blockly.INPUT_VALUE || input.type === Blockly.NEXT_STATEMENT)`", + "reference": "You're using scare quotes on these terms instead of defining them." + }, + { + "prediction": "I think this should be `>= 1.12.0`", + "reference": "These should both be const, not var right?" + }, + { + "prediction": "I don't think this is correct. The `FileOutputStream` needs to be closed after the `DefaultPropertiesPersister.store()` call.", + "reference": "Can you catch a more specific exception here? Thanks :-)" + }, + { + "prediction": "I think we should return `ctrl.Result{Requeue: true}` here.", + "reference": "This is a bug during handling the recover logic in `common chaos` controller, I fixed in this request when I found it." + }, + { + "prediction": "`score_thr=0.3` should be `score_thr=0.05`", + "reference": "During testing, we adopt the score threshold specified in the config file. Here the threshold is only used for visualization, and the variable name `score_thr` can be misleading. Renaming it to `show_score_thr` would be better." + }, + { + "prediction": "I think we can remove the `esc_url(home_url('/'));` and just use ``", + "reference": "can you make this `nav-primary` please? i'd like to roll with this since the `
    ` class is `nav`, and primary is the name of the navigation menu" + }, + { + "prediction": "I think this should be `replace(/[^a-zA-Z0-9\\-]+/g, '')` instead of `replace(/[^\\w\\-]+/g, '')` because `\\w` is equivalent to `[a-zA-Z0-9_]`.", + "reference": "@georgehrke Just out of curiosity. Couldn't you combine at least the combine the regex for '-' and '' with groups?" + }, + { + "prediction": "I think this should be `GetSwiftAnyObjectType` or `GetSwiftAnyObjectClassType` or something like that. `GetAnyObjectType` sounds like it's going to get the `AnyObject` type from the C++ runtime, not the Swift runtime.", + "reference": "I think this is objectively better than looking up the object by name. As a follow-up, I'm going to see whether we do this name-based lookup somewhere else and switch to your method." + }, + { + "prediction": "I don't think this is correct. The flyoutWidth_ is the width of the flyout, not the width of the workspace. The flyoutWidth_ is the width of the flyout, not the width of the workspace. The flyoutWidth_ is the width of the flyout, not the width of the workspace. The flyoutWidth_ is the width of the flyout, not the width of the workspace. The flyoutWidth_ is the width of the flyout, not the width of the workspace. The flyoutWidth_ is the width of the flyout, not the width of the workspace. The flyoutWidth_ is the width of the flyout, not the width of the workspace. The flyoutWidth_ is the width of the flyout, not the width of the workspace. The flyoutWidth_ is the width of the flyout, not the width of the workspace. The flyoutWidth_ is the width of the flyout, not the width of the workspace. The flyoutWidth_ is the width of the flyout, not the width of the workspace. The flyoutWidth_ is the width of the flyout, not the width of the workspace. The flyoutWidth_ is the width", + "reference": "Why are you dividing by scale in the LTR case but not the RTL case?" + }, + { + "prediction": "I think this should be `'/session/$sessionId/window/maximize'` instead of `'/session/$sessionId/window/minimize'`", + "reference": "Update after command rename" + }, + { + "prediction": "I think this should be `googlesitekit.ModuleSettingsDetails-${ moduleSlug }` instead of `googlesitekit.SettingsLegacy`.", + "reference": "I added this change to fix a bug with the legacy settings wrapper which was preventing it from working properly with the other modules" + }, + { + "prediction": "I don't think we need this constant. We can just use `2.0` in the code.", + "reference": "isn't AZKABAN_FLOW_VERSION_2_0 more explicit?" + }, + { + "prediction": "I don't think we should do nothing here. I think we should show a message to the user that the feature is not available.", + "reference": "Please don't leave an empty default" + }, + { + "prediction": "I think we can remove this empty line.", + "reference": "This isn't directly related, but the `import React from 'react';` below should be removed. We never import this directly and any modules from it we need are imported through `@wordpress/element`. This was probably added automatically at some point, but we also provide this automatically via `ProvidePlugin`." + }, + { + "prediction": "I think this should be `sh.cmd 'brew update >/dev/null', retry: true`", + "reference": "You can also use `echo: false` instead. Either is fine; I'm just pointing it out." + }, + { + "prediction": "I think this should be `base.InitializeLayout();` instead of `base.InitializeLayout();`", + "reference": "what's the reason for this moved line?" + }, + { + "prediction": "I think this should be `if (overlayText && showTitle && !isOuterFooter)`", + "reference": "I don't really follow what is happening here, but it looks like this _could_ conflict with the logic on the lines above... should this be an `else if`?" + }, + { + "prediction": "I think this should be `OrderByDescending(s => s.EndLine).FirstOrDefault(s => s.IsHidden == false);`", + "reference": "`s => s.IsHidden == false` What's the purpose of adding this?" + }, + { + "prediction": "I think this should be `optionNameClefSignerAddress` instead of `optionNameClefSignerAddress`", + "reference": "I would name this `clef-ethereum-address`. We already have a bunch of addresses in Bee, and people might wrongly think that this is yet another address" + }, + { + "prediction": "Please remove this line.", + "reference": "you can just remove this" + }, + { + "prediction": "I think we should have a separate upgrade task for SPCs.", + "reference": "I think we should avoid creating a dummy CR in the case of SPC. Please see if we can avoid this since we will not be patching anything in this CR." + }, + { + "prediction": "I think this should be `if locked_features.any? && !current_user.admin?`", + "reference": "Honestly not sure myself, but do you think it makes sense to move this conditional into the partial?" + }, + { + "prediction": "I think this should be `qutebrowser-` instead of `qutebrowser-prefix-`.", + "reference": "As discussed in IRC (just so it doesn't get lost): This probably should be `-basedir-`, not `-prefix-`" + }, + { + "prediction": "Why do we need this?", + "reference": "basepath can be absoluta path and this needs to be supported" + }, + { + "prediction": "This should be `QVariant::fromValue(std::make_pair(screen, position))`", + "reference": "Didn't get to the commit message" + }, + { + "prediction": "Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.", + "reference": "What about raising `ActionView::MissingTemplate` instead? That's what HighVoltage does." + }, + { + "prediction": "I think this should be `response_l.put (\"receivable\", balance.first.convert_to ());`", + "reference": "Is it kept for compatibility?" + }, + { + "prediction": "I think this should be `view.AccountSignerAddress(ctx, m.minerAddr)` instead of `view.AccountSignerAddress(ctx, waddr)`", + "reference": "I would find it pretty reasonable to add a MinerSigner method on the state view that puts these together." + }, + { + "prediction": "This should be 1090001", + "reference": "It's stored in `PodDBAdapter.VERSION`. I usually use the expected release version code for that change. As this will be released in AntennaPod 2.2.0, the code would be `2020000`." + }, + { + "prediction": "I think we should keep the `CQL` in the error message, since it's a CQL statement that failed to execute.", + "reference": "What about method name itself? Do we run this for SQL too?" + }, + { + "prediction": "This should be `https://login.salesforce.com` or `https://test.salesforce.com`", + "reference": "`instanceUrl` should be `cs1.salesforce.com`. `communityUrl` would be `mobilesdk.cs1.my.salesforce.com`." + }, + { + "prediction": "I think this should be `if (name && *size > 0)`", + "reference": "Let's use `if(name != nullptr)` to remove ambiguity" + }, + { + "prediction": "I don't think we need to implement this in this PR. We can do it in a follow-up PR.", + "reference": "I wonder if it would make sense to have a separate namer for metadata? Metadata files tend to be expressed in a different language from the repo language, and have mutually exclusive concepts. So, `PackageMetadataNamer`." + }, + { + "prediction": "I don't think we need to pass this in as a parameter. We can just make it a constant in the class.", + "reference": "This rule is quite specific to qbft and so I don't think it should be part of the common rules. Would rather the common bft code didn't know anything about contract based voting/validator governance." + }, + { + "prediction": "I think this should be `default Set reverse() { ... }`", + "reference": "This makes our life harder than it needs to be. A Set is unordered by definition. Please remove this method from Set and add it to SortedSet, but with no default implementation. We need to duplicate it then to LinkedHashSet but that's ok, it is the best we can do. Could you please add it also to SortedMap and LinkedHashMap? We are then able to close the original issue." + }, + { + "prediction": "`response_headers` is a dict, so you can just do `for header, value in response_headers.items():`", + "reference": "we can replace `for` with `params.update(response_headers)`" + }, + { + "prediction": "I think we can remove this now.", + "reference": "Any chance this is available in .NET Core 2.0 now?" + }, + { + "prediction": "remove empty line", + "reference": "I wonder if it's necessary to let app pass in the context. What app level context should be sent? If no, is it enough for p2p agent to compose a context with network info there?" + }, + { + "prediction": "I don't think you need to include `lbann/execution_contexts/sgd_execution_context.hpp` here.", + "reference": "Why do we need both includes here?" + }, + { + "prediction": "I think this should be `SOUP_NAME_COL + \" IS NOT NULL\"`", + "reference": "SmartStoreInspectorTest expected results in a certain order" + }, + { + "prediction": "Should this be `m_using_random_node.count(m_io_thread_pool->get_local_thread_id()) > 0`?", + "reference": "I think that you need something like `m_using_random_node.emplace(m_io_thread_pool->get_local_thread_id());`" + }, + { + "prediction": "I don't think this is the right place to add this check. This check should be done in the `isUsedLocalVarWithoutInitializer` method. The reason is that the `isUsedLocalVarWithoutInitializer` method is used in the `UnusedAssignmentRule` and in the `UnusedVariableRule`. If we add this check in the `isUsedLocalVarWithoutInitializer` method, we will be able to reuse this method in the `UnusedVariableRule` as well.", + "reference": "I don't think we need to maintain a separate set. The problem here is that the \"assignment\" that is killed for this variable is not really an assignment. If we just don't `assign` the variable with the non-existent value, it will not be reported. I pushed a fix." + }, + { + "prediction": "I think this should be `long getTargetSplitSize()`.", + "reference": "Let me know if this is too pervasive. It is currently a private method in `BaseTableScan`. It seems both `SparkBatchQueryScan` and `SparkMergeScan` need to know the scan-specific split size when planning tasks. Therefore, I made it open. Another approach is to move all the `planTasks` logic to scan implementations, but for the combine tasks by partition feature, it requires grouping scan tasks by partition first, instead of returning them in an iterator fashion. I'm not sure if this is OK. `SparkMergeScan` also seems to re-implemented its own plan tasks logic." + }, + { + "prediction": "I think this should be `tm[:maxTrace+1]` instead of `tm[1:maxTrace+1]`.", + "reference": "Not sure what is this change doing?" + }, + { + "prediction": "I'm not sure this is the right way to do this. I think it would be better to have a constant for the 90 days and use that here.", + "reference": "this is funky. either don't take` minutes` as keyword arg or take both `minutes` and `days` and pass all of them on to `timedelta`. i'm guessing you're aiming for backwards compatibility, but i don't think it's worth it given how confusing this is. atlernatively, make `mins=60*24*30` the default. and that brings me to another issue, `mins=None` is not a very useful default." + }, + { + "prediction": "I don't think we need to do this. RememberMeServices is an interface, so we don't know if it's an AbstractRememberMeServices or not.", + "reference": "Please use a tab for indentation instead of spaces." + }, + { + "prediction": "`AbstractQueue` should be renamed to `AbstractsQueue` to be consistent with `AbstractsList` and `AbstractsMap`.", + "reference": "I can't believe we didn't see this typo before :))" + }, + { + "prediction": "I think you can just use `get_logger(__name__)` here.", + "reference": "If the logger isn't used, it probably doesn't need to be added." + }, + { + "prediction": "I think this should be `document.body.appendChild(script)` instead of `document.head.appendChild(script)`.", + "reference": "These files should in `/javascript/brython`" + }, + { + "prediction": "I think we can remove the `if imageAlpha != nil` check here, since we're already checking for `imageAlpha.Deprecated.StateOverride != nil` on the next line.", + "reference": "minor, you can squash these into one `if`" + }, + { + "prediction": "Why is this change needed?", + "reference": "Used regexes to do most of this, hence different methods of string creation of UUIDs. I plan to follow up with an additional change to remove direct references to google/pborman UUID so `uuid.New()` and `uuid.NewRandom()` will instead use our `primitives.UUID`." + }, + { + "prediction": "Why is this needed? I don't think it should be.", + "reference": "Add a TODO here to revisit if this was problematic." + }, + { + "prediction": "`If true, the regression loss would be applied directly on decoded bounding boxes, meaning both the predicted boxes and regression targets are with absolute coordinates format. Default False. Note generally it should be set to `True` when using `IoULoss`, `GIoULoss`, or `DIoULoss` in the bbox head.`", + "reference": "Note generally it -> It" + }, + { + "prediction": "I think this should be `#if 0` instead of `#if 0`.", + "reference": "Is this relevant to this PR?" + }, + { + "prediction": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", + "reference": "Can we instead ensure that `opts[:run_in_parellel]` will always be a boolean? Otherwise we'll have to account for the case when it's a non-boolean value in multiple places, such as any/every other `if` statement." + }, + { + "prediction": "I think it would be better to use `HTTPSchemeKey.String(\"http\")` and `HTTPSchemeKey.String(\"https\")` here.", + "reference": "Is this just moved out of the other files? It doesn't seem like this was generated like the other files." + }, + { + "prediction": "I think this should be `IHttpContent` where `TStream` is `Stream` or `MemoryStream`.", + "reference": "I started out doing everything `async`, but it was getting in the way of debugging, so I switched back to all synchronous until I got things working. We should probably move everything back to `async` and remove the synchronous versions." + }, + { + "prediction": "I don't think we need this factory at all. We can just pass `SpecProvider` and `LogManager` to `MevBlockProducerTransactionsExecutor` constructor.", + "reference": "this looks already too complicated..." + }, + { + "prediction": "`EXPECT_EQ(ResultCode::SUCCEEDED, engine->multiPut(std::move(data)));` -> `ASSERT_EQ(ResultCode::SUCCEEDED, engine->multiPut(std::move(data)));` `EXPECT_EQ(ResultCode::SUCCEEDED, engine->compactAll());` -> `ASSERT_EQ(ResultCode::SUCCEEDED, engine->compactAll());` `fs::TempDir rootPath(\"/tmp/rocksdb_compact_test.XXXXXX\");` -> `fs::TempDir rootPath(\"/tmp/rocksdb_compact_test\");`", + "reference": "As for the testings, we better to verify the actual effects of the compaction. Of course, you could do it in future." + }, + { + "prediction": "I think it's better to use `tableMap.values().stream().filter(TiTableInfo::isView).collect(Collectors.toList())`", + "reference": "should we add a TODO here?" + }, + { + "prediction": "I think we can remove the `ErrorHandler` component now that it's been moved to the `Root` component.", + "reference": "This can be inlined below as `GoogleSitekitDashboardDetails` is an unnecessary wrapper now." + }, + { + "prediction": "nit: `histories := versionhistory.NewVersionHistories(versionHistory)` -> `histories := versionhistory.New([]byte(\"branch token\"), []*historyspb.VersionHistoryItem{ {EventId: lastWorkflowTaskStartedEventID, Version: lastWorkflowTaskStartedVersion}, })`", + "reference": "NewVHS -> NewVersionHistories this one looks better" + }, + { + "prediction": "I think this should be `@executable_path ||= binary_path(executable_path)`", + "reference": "Is this `@missing_text` ?" + }, + { + "prediction": "I think this should be `^([\\w-]+/[\\w-]+)(?:/(.+))?$`", + "reference": "Minor suggestion, but wouldn't it be cleaner to simply replace PACKAGE_NAME_FORMAT to all the optional path, then check that the path is empty in validate_package_name? We might also want a helper function to pull out the package name and sub-package path." + }, + { + "prediction": "I don't think we need to translate \"Done\" here.", + "reference": "we should have a way to insert components into a i18n string. so that we could define a translation string like `'%{filename} is being edited'`, and inject the filename `` at the right place. I imagine there must be a language where the `Editing` text should come after the file name. we can think about that later tho." + }, + { + "prediction": "(style) 'pglob.gl_pathv' may be misspelled - perhaps 'pglob.gl_pathv' ?", + "reference": "Probably want break instead of continue." + }, + { + "prediction": "Why is this change needed?", + "reference": "This was on purpose that I would set logging (NoLog=false) and a dummy logger below. The idea is to have better code coverage and test of debug/trace statements. Any reason you have removed this?" + }, + { + "prediction": "I don't understand why this change is needed.", + "reference": "does adding a `Stream.empty()` help here?" + }, + { + "prediction": "I think this should be `{'name': 'non_exist_scanner', 'enabled': False}`", + "reference": "This is not being used anymore, so can be removed." + }, + { + "prediction": "I think this should be `if len(p.ipStrings) == 0 && len(p1.ipStrings) == 0 {`", + "reference": "Is it called some where?" + }, + { + "prediction": "Why is this needed?", + "reference": "Please remove this extra blank line." + }, + { + "prediction": "I think this should be `@InputFiles` instead of `@Input`.", + "reference": "this is really the key, if you don't set this then gradle doesn't wire up the tasks that produce various files inside these configurations as inputs... I think we were just getting lucky before." + }, + { + "prediction": "I think this should be `rtest.Assert(t, !r, \"Failed to match untagged snapshot\")`", + "reference": "Sorry if I'm missing something here, but shouldn't this message be about failing to match with an *empty* selector, and/or perhaps even an empty *tag* instead of selector? The message seems a bit disconnected from what we're testing?" + }, + { + "prediction": "I think we can remove this line.", + "reference": "nit: please move these inside namespace." + }, + { + "prediction": "I think this should be `FlagPaymentsDuringSessionDebug` instead of `FlagPaymentsDuringSessionDebugMode`", + "reference": "may users try to abuse it?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think we should be using `nbb.capacity()` instead of `new_buf_size` here.", + "reference": "why is this space removed?" + }, + { + "prediction": "I think we can remove this file now.", + "reference": "Can we remove this other line now then?" + }, + { + "prediction": "I think this should be `qutebrowser/misc/cmdhistory.py`, not `qutebrowser/misc/cmdhistory.py`", + "reference": "There's a comma missing here at the end :wink:" + }, + { + "prediction": "I think we can remove this property now.", + "reference": "Why is this not required any longer?" + }, + { + "prediction": "Please remove this empty line.", + "reference": "Indentation seems a bit fucked up here. Run `go fmt`." + }, + { + "prediction": "I think it's better to return `status.Errorf(codes.InvalidArgument, \"empty filter\")` here.", + "reference": "any chance in == nil? same below" + }, + { + "prediction": "`h2o_sysfn(listen, listen_fd, H2O_SOMAXCONN)` should be `h2o_sysfn(listen, listen_fd, H2O_SOMAXCONN)`", + "reference": "We would change the source code of h2o so that certain syscalls will be invoked through the `h2o_sysfn` macro." + }, + { + "prediction": "I think this should be `SubmitError::kSemCannotBeSignalled` instead of `SubmitError::kBinaryCannotBeSignalled`.", + "reference": "the name kTimelineCannotBeSignalled is confusing. It's not that a TimelineSemphore cannot be signaled... it's the \"VK_KHR_timeline_semaphore is enabled *variant* of the \"binary cannot be signaled\" message. We should probably have a consistent naming scheme to clarify. kBinaryCannotBeSignalledAltTimeline or hide the complexity in Get*VUID functions as needed somehow (pass in the extension structure?)" + }, + { + "prediction": "I think we can remove the `percentiles` argument from the docstring.", + "reference": "Could you add a type hint? `percentiles: Optional[List[float]] = None`" + }, + { + "prediction": "Metrics/CyclomaticComplexity: Cyclomatic complexity for building_options is too high. [7/6]", + "reference": "Maybe putting ones they've used before first would be good, but this is fine for now." + }, + { + "prediction": "I think we can remove these two lines.", + "reference": "I don't think we need these. Simpler just to put `routetable.TargetType...` inline below." + }, + { + "prediction": "Metrics/BlockNesting: Avoid more than 3 levels of block nesting.", + "reference": "Why this instead of the old way?" + }, + { + "prediction": "I'm not sure if this is the right place to log this, but it seems like it would be good to know when this rule is being used.", + "reference": "Just combining the inner if/else blocks like this is what I originally meant (I didn't mean replacing all the invisible checks in the outer if, I realize that would have been a functionality change regarding the rule) This should now be equivalent to `if (RuleB(Pets, LivelikeBreakCharmOnInvis) || IsInvisible(formerpet))` (the second check for the rule being false after the `||` would be implied, anything after the `||` would only be evaluated if the rule was false)" + }, + { + "prediction": "I think this should be `strings.ReplaceAll(key, \"_\", \".\")`", + "reference": "We don't want to write this back to the definition do we? Probably just want to create a local variable for it." + }, + { + "prediction": "I think this should be moved to `onPlaybackEnded()` in `PlaybackService.java`.", + "reference": "Good catch! Could you please move this to `PlaybackService.this.onPlaybackEnded`? I think it's more clean if everything is in one single place." + }, + { + "prediction": "I'm not sure if this is the right place to call xcb_flush. I think it would be better to call it in the end of activateWithDraggable.", + "reference": "We're trying to avoid X.org specific code. So I'm not a fan of this. Can't this be achieved in display server agnostic way?" + }, + { + "prediction": "Please remove this file.", + "reference": "This class can be removed?" + }, + { + "prediction": "remove empty line", + "reference": "File is not `goimports`-ed (from `goimports`)" + }, + { + "prediction": "I'm not sure if this is the right place to put this, but I think it would be useful to have a `Logger` field on the `Config` struct. This would allow the user to pass in a custom logger, which would then be used by the dispatcher.", + "reference": "To minimize the possibility of regret, perhaps we name this `ZapLogger`." + }, + { + "prediction": "Align the elements of a hash literal if they span more than one line.
    Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "This looks a little weird, but it's a feature of the gem we're using. You can give it a symbol representing the method you want called on current_user." + }, + { + "prediction": "I think this should be `from nupic.frameworks.opf.anomaly import Anomaly`", + "reference": "`Anomaly` imported here, but not used. Please run the changed files through pylint with nupic pylint config and fix pylint findings related to your changes." + }, + { + "prediction": "I think this should be `target = target || '#target'` so that if `target` is `null` or `undefined` it will default to `#target`", + "reference": "We needed this testutils file after all" + }, + { + "prediction": "Why is this changed?", + "reference": "line is 161 characters (from `lll`)" + }, + { + "prediction": "remove the empty line", + "reference": "Please re-format/groupimport this line. You might need a little manual work." + }, + { + "prediction": "I think this should be `worker.env.ApplyWorkerCustomizations(worker.wf, worker.env.NoExternalIP)`", + "reference": "minor, you can just use `wf` instead of `worker.wf`" + }, + { + "prediction": "Please revert this change. It's not related to this PR.", + "reference": "I would suggest putting this in the resources directory with the same package as of this test class. Then you can utilize the method azkaban.utils.TestUtils#readResource to read it as string." + }, + { + "prediction": "This import is not required.", + "reference": "could not import github.com/openebs/maya/pkg/upgrade/templates (invalid package name: \"\") (from `typecheck`)" + }, + { + "prediction": "I think we can remove this test as well.", + "reference": "a official -> an official" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "I only want the proxy request for this to run for kinesalite." + }, + { + "prediction": "Please remove the extra space here.", + "reference": "White space boya?" + }, + { + "prediction": "I think this should be `*cloudformation.StackSummary` instead of `cloudformation.StackSummary`.", + "reference": "Maybe ditch these since `StackSummary` is not used anymore." + }, + { + "prediction": "why remove `label_bias`?", + "reference": "suggest to indicate the value range & meaning in docstring" + }, + { + "prediction": "Why do we need to add a trailing slash here?", + "reference": "not sure if it works with prometheus by default, otherwise we will have to add this into prometheus config also" + }, + { + "prediction": "I think this should be `r.epmm.CleanupEndPointMark(ifaceName)`", + "reference": "The rule renderer isn't meant to be stateful so probably best to move this out of here" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in the `containerd` package.", + "reference": "passing in a `nil` here just so that the tests can pass in an alternative implementation seems weird, but I don't know what the convention is for doing something like this - @briandowns?" + }, + { + "prediction": "nit: extra backtick here", + "reference": "IMO `dot` should be preferred. Remember `aXe`?" + }, + { + "prediction": "Why is this needed?", + "reference": "Not a huge deal but this will block tests, also, don't they stay open by default now?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the right thing to do. We don't really care about the history of the logs, we just want to know if there was an error or not.", + "reference": "Could you make it a local constant for now ?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the `validate` method.", + "reference": "What is this `collection_id` field here?" + }, + { + "prediction": "I don't think this is the right place to do this. I think it would be better to add a `debug_interactive` method to the `Automaton` class and call it from the `debug` method.", + "reference": "Is there a reason why we don't use logging for this?" + }, + { + "prediction": "I think it should be `DenormalizationException` instead of `DenoralizationException`", + "reference": "Exceptions should be placed in application layer -> infrastructure is aware of application - not the other way around" + }, + { + "prediction": "I don't think this is correct. The message id is `C0301`, but the message is `Line too long (1/2)`. The message id should be `C0301` and the message should be `Line too long (1/2)`.", + "reference": "IIRC issue mentioned reporting _symbolic message_ - so in this case it would be `line-too-long`." + }, + { + "prediction": "This should be `else if (id == \"feedbackable\") { return spells[spell_id].feedbackable; }`", + "reference": "Is this intended to be `spells[spell_id].reflectable` here? Edit: Should be `spells[spell_id].feedbackable`, right?" + }, + { + "prediction": "Align the parameters of a method call if they span more than one line.
    Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "How should we set this for existing teams?" + }, + { + "prediction": "I think this should be `infraID already set on cluster provision (fatal error)` to make it clear that this is a fatal error.", + "reference": "It would be nice if we could verify that this is in fact the error we expected. But that's a latent issue, something for the backlog." + }, + { + "prediction": "I think we can remove this import, as it's not used anymore.", + "reference": "I hate then some internal process specific middleware leaks into connection manager :( todo later." + }, + { + "prediction": "I think this should be `nupic.support` instead of `nupic.support.__init__`", + "reference": "Reflects where these files were moved for `pkg_resources`." + }, + { + "prediction": "I think this should be `t('admin.textReplacements.pageTitle', { defaultValue: 'Text Replacements' })`", + "reference": "This should be computed('i18n.locale'...." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the `BeforeEach` of the `Describe(\"multi-NIC scenario\")` block.", + "reference": "Can you explain to me what goes wrong here? Can the test be adjusted to set up working routing instead?" + }, + { + "prediction": "I think we can remove this import now.", + "reference": "We can get rid of this import then." + }, + { + "prediction": "I'm not sure if this is the best way to do this. I think it would be better to have a `mapEventToMetricsEvent` function that returns a `*metrics.Event` and a `mapEventToMetricsEventID` function that returns a `string` and a `*metrics.Event`.", + "reference": "Not sure how useful is unlock event." + }, + { + "prediction": "I'm not sure this is the right place to add this flag. I think it would be better to add it to the `encodeDoc` function in `memdocstore/codec.go` and pass it through to the `encodeDoc` function in `memdocstore/codec_test.go`.", + "reference": "Consider make the second argument a `encoderOptions` which includes the `lowercaseFields` just like opening a collection." + }, + { + "prediction": "I think we can remove this method and just use `TezUtil.enrichContextWithAttemptWrapper(ctx);` in `commitTask` and `commitJob`.", + "reference": "What is the value of renaming this to `ctx`? We generally prefer the longer names because they are easier to read and to type." + }, + { + "prediction": "I'm not sure about this, but I think it should be `lane_data.front().tag == TurnLaneType::uturn || lane_data.back().tag == TurnLaneType::uturn`", + "reference": "Hm. This could be a case of left-sided driving, having u-turn lanes on the right side. Good catch, but looks good to me." + }, + { + "prediction": "I think it's better to keep the name `Value` as it's more descriptive.", + "reference": "There was a [JsonPropertyName(\"success\")] here it did serialize fine for me, so I am not sure what was the matter? Also maybe uppercase?" + }, + { + "prediction": "why do we need a ReadOnlyTransactionProcessorFactory? Can't we just use ReadOnlyDbProvider with ReadOnlyTransactionProcessorFactory?", + "reference": "we can just use read env here, pretty sure" + }, + { + "prediction": "I'm not sure if this is the best place to add this hook. I think it would be better to add it in the `onAfterInit` method. The reason is that the `onAfterInit` method is called when the Handsontable instance is initialized, and the `onAfterLocalTransformStart` method is called when the selection is transformed. So, if we add the hook in the `onAfterInit` method, we can be sure that the `onAfterLocalTransformStart` method is called after the Handsontable instance is initialized.", + "reference": "Could you replace local hook with global hook `afterModifyTransformStart`?" + }, + { + "prediction": "I think this should be `self._files = {}`", + "reference": "You seem to be basing your PRs off an commit, which keeps reintroducing these changes, which makes it harder to review your PRs." + }, + { + "prediction": "I think this should be `if (typeof opt_port === 'function') { ... }`", + "reference": "Maybe it would simpler to ignore opt_port if type !== 'number'?" + }, + { + "prediction": "I think this should be `IEnumerable> Attributes { get; set; }` instead of `IDictionary Attributes { get; set; }`", + "reference": "As far as I can tell, `IDictionary` implements `IEnumerable>` so we are just making it more generic. From the issue, I understood that we want to maintain sequence/order. I believe `IEnumerable<>` won't fix the issue." + }, + { + "prediction": "I think this should be `finest` as well.", + "reference": "This change prevents a user understanding how their server is configured. Best to leave at `info` level." + }, + { + "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to have a list of all the ephemeral spec fields.", + "reference": "I will add the following to the list: - api.SpecScale - api.SpecSticky" + }, + { + "prediction": "Why is this line removed?", + "reference": "As defaultSendPort is being removed, and I don't like TODOs on examples, please remove the whole line" + }, + { + "prediction": "I think we can remove this test as well.", + "reference": "since we are now no longer expecting an input of float to return an empty string, i have removed this test case." + }, + { + "prediction": "I think this should be `Register(reg *Registry)` instead of `Register(nil)`.", + "reference": "It would be cleaner if you were to pack the name&desc in a `MetricName` and pass it to `MakeCounter`" + }, + { + "prediction": "I think we can remove this line.", + "reference": "Do you know why do we need this?" + }, + { + "prediction": "I'm not sure why this is needed, but it seems to be required for the `MvxTabBarItemPresentationAttribute` to work.", + "reference": "I guess this using is what causes the build to fail" + }, + { + "prediction": "I think this should be `pony_unregister_thread()` rather than `ponyint_unregister_thread()`.", + "reference": "I like the explicit unregister approach." + }, + { + "prediction": "I think we need to add a new type for `ExponentialHistogram` and `ExponentialHistogramWithMinMax` as well.", + "reference": "We should able to use 0x30 as summary, and make 0x80 reserved for future." + }, + { + "prediction": "I think we can remove the `HttpBypassHelper.UriContainsAnyOf(requestUri, tracer.Settings.HttpClientExcludedUrlSubstrings)` check here, since it's already checked in `PlatformStrategy.ShouldSkipClientSpan`", + "reference": "This allows strategic exclusion of http spans." + }, + { + "prediction": "I think this should be `?array $strictTextSearchFields = null`", + "reference": "why not just `string[]` instead of nullable" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to work for me. I'm not sure if this is a bug in `go list` or not.", + "reference": "How does this work? Why isn't each tag after the first picked up as a new arg/flag?" + }, + { + "prediction": "I think this should be `Datadog.AzureAppServices.ResourceId`", + "reference": "This key is actually yet to be determined. Meeting with the backend team and Garner to discuss." + }, + { + "prediction": "I think this assert should be `if (iv_state == nullptr) { ... }` instead of `assert(iv_state);`", + "reference": "Why remove the crash protection? We're just going to get a bug filed on it." + }, + { + "prediction": "I think this should be `X-Content-Type-Options` instead of `X-Content-Type-Options`.", + "reference": "Maybe be consistent and name it `FRAME_OPTIONS`." + }, + { + "prediction": "I'm not sure this is the right place to remove the orphan. I think it should be done in `Blockly.Block.prototype.dispose`.", + "reference": "This check/exception is a guard for the next few lines of code. It shouldn't be necessary now. In fact, I don't think you need the if (parentConnection.type == Blockly.INPUT_VALUE) branch at all." + }, + { + "prediction": "I think we can remove this empty line.", + "reference": "Could probably move these constants too?" + }, + { + "prediction": "I think it's better to stop the server here, as we don't want to continue with a proposal that is not working.", + "reference": "Maybe 'failed' instead of 'missing'. Also do we really need to write ticket numbers here?" + }, + { + "prediction": "This import is not needed anymore.", + "reference": "Test used to use old bouncycastle dependency which isn't needed anymore from Hadoop. Switched to use builtin Java split." + }, + { + "prediction": "I think this should be `name=v.name.decode(\"UTF-8\", errors=\"replace\")`", + "reference": "nit: I think this would be more readable as \"Some language names contain Unicode characters\"." + }, + { + "prediction": "I don't think this is needed.", + "reference": "Thanks for adding the header, but I don't think 2017 is a very accurate guess here. Could you do a quick search with git blame and change this accordingly?" + }, + { + "prediction": "I think we can remove this line.", + "reference": "Oh interesting - does web-test-runner not resolve package.json files?" + }, + { + "prediction": "I think this should be \"P\u00e4iv\u00e4m\u00e4\u00e4r\u00e4\"", + "reference": "Is there a way to derive this value from the locale itself? I feel hardcoding the prefix in the props isn't the right approach, but I'm not sure what the locale file contains exactly." + }, + { + "prediction": "This should be `component.getDerivedStateFromProps(props, component.prevState)`", + "reference": "I'd much rather see these warnings in our devtools (`debug/index.js`). Strings contribute quite a bit to our file size and moving them there would prevent bloating core." + }, + { + "prediction": "I think you can use `SmartStore.SOUP_NAME_COL`, `SmartStore.PATH_COL`, and `SmartStore.COLUMN_TYPE_COL` here.", + "reference": "Use `String.format(Locale.US, ...) to avoid the `Lint` warning." + }, + { + "prediction": "I don't think we need to add the `Namespace` field to the `PodReference` struct. The `PodReference` struct is only used in the `AppliedToGroup` struct, and the `AppliedToGroup` struct is only used in the `NetworkPolicy` struct. The `NetworkPolicy` struct already has a `Namespace` field, so we can just use that instead of adding a new `Namespace` field to the `PodReference` struct. Also, I don't think we need to add the `Namespace` field to the `ServiceReference` struct either. The `ServiceReference` struct is only used in the `AppliedToGroup` struct, and the `AppliedToGroup` struct is only used in the `NetworkPolicy` struct. The `NetworkPolicy` struct already has a `Namespace` field, so we can just use that instead of adding a new `Namespace` field to the `ServiceReference` struct. Also, I don't think we need to add the `Namespace` field to the `PodReference` struct either. The `PodReference` struct is only used in the `AppliedToGroup` struct, and the `AppliedToGroup` struct is only used in the `NetworkPolicy` struct. The `", + "reference": "nit: ServiceReference represents a reference to a v1.Service." + }, + { + "prediction": "I think this should be `[]string` instead of `*[]string`", + "reference": "since it changes to the array, how about change the name to `DeviceNames`" + }, + { + "prediction": "RuntimeTLP is a top level property supported by CAS template engine The policy specific properties are placed with RuntimeTLP as the top level property RuntimeTLP is a top level property supported by CAS template engine The policy specific properties are placed with RuntimeTLP as the top level property RuntimeTLP is a top level property supported by CAS template engine The policy specific properties are placed with RuntimeTLP as the top level property RuntimeTLP is a top level property supported by CAS template engine The policy specific properties are placed with RuntimeTLP as the top level property RuntimeTLP is a top level property supported by CAS template engine The policy specific properties are placed with RuntimeTLP as the top level property RuntimeTLP is a top level property supported by CAS template engine The policy specific properties are placed with RuntimeTLP as the top level property RuntimeTLP is a top level property supported by CAS template engine The policy specific properties are placed with RuntimeTLP as the top level property RuntimeTLP is a top level property supported by CAS template engine The policy specific properties are placed with RuntimeTLP as the top level property RuntimeTLP is a top level property supported by CAS template engine The policy specific properties are placed with RuntimeTLP as the top level property RuntimeTLP is", + "reference": "Can we avoid this. upgrade engine code should take care of this." + }, + { + "prediction": "This should be `TOKEN_EXP_DEFAULT = {'days': 90}`", + "reference": "should also be alphabetized or at least grouped and alphabetized within group" + }, + { + "prediction": "I think we can remove this now.", + "reference": "No need for this, as pylint already only turns things off for this function and it's needed for the entire function." + }, + { + "prediction": "I think this should be \"can't unmarshal count field into integer or auto scaling config\"", + "reference": "nit: can we remove \"can't\" from the error message?" + }, + { + "prediction": "This is not correct. If the status is empty, then the phase should be Pending. If the status is not empty, then the phase should be Recreate.", + "reference": "instead of modifying 'Status' which impacts the state diagram, how about using some annotations on CVR? This can probably help for our upgrade as well. Is this possible? cc: @AmitKumarDas" + }, + { + "prediction": "I don't think we need this anymore.", + "reference": "Rename this as KubernetesGPGURL - >KubernetesUbuntuGPGURL , Modify it where ever it is used." + }, + { + "prediction": "This should be `0.0001 * 100000000`", + "reference": "I'm not totally sure I like the idea of putting a default fee here, but I guess so long as we make sure to track the default fee of bitcoin core, we're good. We should really also take a look at the byte size of the transaction, and use that to determine what the fee should be. But that could also be a different PR." + }, + { + "prediction": "small>linearlinearlinearlinearlinear\n * {@linkplain javaslang.collection.Map}constlinearlinearlinearlinearlinear\n * {@linkplain javaslang.collection.Queue}constlinearlinearlinearlinearlinear\n * {@linkplain javaslang.collection.Set}constlinearlinear", + "reference": "oh yeah, `tail`, `update`, `prepend`, `append`, `subSequence`, `trim` just became effectively constant (without memory leak) :)" + }, + { + "prediction": "I think this should be `$select->where->in('list_id', (array)$list);`", + "reference": "Can you add back a deprecated `destroyLinks` method for backward compatibility? It can simply proxy `destroyResourceLinks`, and we can remove it in the next major release." + }, + { + "prediction": "I think this should be `RegisterGlobalOption(\"server\", parseServerOptions)`", + "reference": "A reminder that we should discuss whether to rename this to \"sockets\" or \"listeners\"." + }, + { + "prediction": "This is not needed.", + "reference": "Why do you need to include this using declaration?" + }, + { + "prediction": "I think this should be `for (var scan = count - 1; scan >= 0; scan--)`", + "reference": "@halter73 where is this file generated from?" + }, + { + "prediction": "I think we can remove this `#if TRUE` and the `#endif` at the end of the file.", + "reference": "What do these `#if TRUE` accomplish?" + }, + { + "prediction": "I think this should be `if (Sdk.SuppressInstrumentation && !this.handler.SupportsNullActivity) { return; }`", + "reference": "Probably a good optimization to have this, but I don't think it's strictly required. For \"legacy\" Activity flows we pass them through an ActivitySource for sampling. So the logic below should also catch these?" + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "@jessieay Intentionally moving away from passing a param?" + }, + { + "prediction": "I don't think this is correct. If there is only one name, it should be the first name. If there are two names, the first should be the first name and the second should be the last name. If there are three names, the first should be the first name, the second should be the middle name, and the third should be the last name.", + "reference": "I think you could condense this code considerably by getting rid of the initialization and foreach loop and simply saying: `$firstname = trim(implode(' ', $nameArr));` What do you think?" + }, + { + "prediction": "I think we can remove this line.", + "reference": "hmm, we actually should _add_ `'use strict'` everywhere" + }, + { + "prediction": "I think we should keep this as a warning.", + "reference": "it's not just fetching override properties here, right?" + }, + { + "prediction": "I think this should be `seelog.Infof(\"ACS Websocket connection closed for a valid reason: %s\", acsError.Error())`", + "reference": "Is it worth logging the error?" + }, + { + "prediction": "I don't think this is the right way to do this. You should be able to do `self.ns[\"key\"] = value` and it should work.", + "reference": "What's the point of this class?" + }, + { + "prediction": "I think this should be `contentType !== 'movies' && contentType !== 'mixed' && contentType !== 'tvshows'`", + "reference": "I'm being picky here, but I think I would prefer `toggle` to be kept here and just change the condition to `contentType !== 'movies' && contentType !== 'mixed'` or `!['movies', 'mixed'].includes(contentType)`." + }, + { + "prediction": "I think you can just use `os.PathSeparator` instead of `sysPath.Separator`.", + "reference": "Please put this down with the other \"github.com\" imports." + }, + { + "prediction": "I think this should be `bool push_front_preference = false`", + "reference": "Minor but probably want `push_front_preference` to have a trailing `_a` to be consistent with the other parameter" + }, + { + "prediction": "I think we can remove the `caseSensitive` parameter from the constructor and the `caseSensitive` parameter from the `rewriteNot` method. The `caseSensitive` parameter is only used in the `rewriteNot` method, so we don't need to pass it to the constructor. Also, the `caseSensitive` parameter is only used in the `rewriteNot` method, so we don't need to pass it to the constructor. Also, the `caseSensitive` parameter is only used in the `rewriteNot` method, so we don't need to pass it to the constructor. Also, the `caseSensitive` parameter is only used in the `rewriteNot` method, so we don't need to pass it to the constructor. Also, the `caseSensitive` parameter is only used in the `rewriteNot` method, so we don't need to pass it to the constructor. Also, the `caseSensitive` parameter is only used in the `rewriteNot` method, so we don't need to pass it to the constructor. Also, the `caseSensitive` parameter is only used in the `rewriteNot` method, so we don't need to pass it to the constructor. Also, the `caseSensitive` parameter is only used in", + "reference": "Nit: the formatting is a bit off. I would expect this to be 2 indentations from `this.expr = ...` but this is 8 spaces, not 4. Also, most places leave the `);` on the last line of the method arguments." + }, + { + "prediction": "I think we can remove this import.", + "reference": "Ack, @chrisdunelm snuck this class extension past me. This is not a pattern I want to have used..." + }, + { + "prediction": "I think it would be better to put this in the docstring of the `flush_endpoint_enabled` setting in `kinto/config/settings.py`.", + "reference": "nitpick: I wonder if we should name it `flush` only (?)" + }, + { + "prediction": "I think it should be \"Number of currently running deals\"", + "reference": "Why gauges, not counters?" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we need to keep the old gwHashLen and add a new gwHashLen64 for the 64 bit hash.", + "reference": "Just making a note here that this may break pre GWs between pre 2.2.0 and 2.2.0 servers. Not sure, will have to experiment/dig a bit more." + }, + { + "prediction": "I think this should be \"Pod Failure\" instead of \"Pod Failed\"", + "reference": "Shall we rename this status to CONTAINER_FAILED? ^^ cc: @sshardool" + }, + { + "prediction": "I'm not sure I like the name `Fetcher` for this interface. It's not really a fetcher, it's more of a downloader. I think `Downloader` would be a better name.", + "reference": "Thinking out loud here: I believe the only reason we need `peer.ID` as a parameter to this method is because we are not persisting blocks from pubsub (instead we are refetching them). If nodes persist the blocks they received over pubsub then I think we can guarantee peers we share a connection with (i.e. that are in the peer tracker) will always have the blocks we are fetching (else how would have we gotten the pubsub message). I imagine the concept of an `initialPeer` can go away once #2962 lands since the peers in the tracker will have the block. Although I don't think that covers the case of fetching blocks our peers have deemed semantically invalid and thus not stored..." + }, + { + "prediction": "I think this should be `https://github.com/google/cel-spec/blob/master/doc/langdef.md#standard-definitions`", + "reference": "I know it has no effect but my eyes can't help. Is that line not too long?" + }, + { + "prediction": "I think we should keep this rule. It's used to block service CIDR loops. I think we should move it to the top of the chain, so that it's the first rule that gets executed.", + "reference": "Does that mean we disable service loop prevention for packet generated by local host?" + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.", + "reference": "It seems a little odd to have both `host.is_cygwin?` *and* `host.cygwin_installed?` defined (with a possibility of having `is_cygwin?` be `true`, but `cygwin_installed?` returning `false`). Do the docs clearly explain the difference?" + }, + { + "prediction": "I think this should be `write(2, spec, outputFile, 0)`", + "reference": "Does this mean manifests will be written with the v2 schema (i.e. with sequence numbers) even though `TableMetadata` is v1 and the manifest list is written with v1? And this should work because we do a projection on read and sequence number is optional?" + }, + { + "prediction": "I think this should be `spark.sql.sources.rewrittenFileScanTaskSetId` to be consistent with the other options.", + "reference": "Should we be sharing this property key with the read? Maybe it should be belong to the file-scan-task object itself?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think we should have a separate `DebugTarget` type that is a superset of `BuildTarget` and has a `DebugFields` field. Then we can have a `DebugTargets` type that is a superset of `BuildTargets` and has a `[]DebugTarget` field. Then we can have a `DebugTargets` type that is a superset of `BuildTargets` and has a `[]DebugTarget` field. Then we can have a `DebugTargets` type that is a superset of `BuildTargets` and has a `[]DebugTarget` field. Then we can have a `DebugTargets` type that is a superset of `BuildTargets` and has a `[]DebugTarget` field. Then we can have a `DebugTargets` type that is a superset of `BuildTargets` and has a `[]DebugTarget` field. Then we can have a `DebugTargets` type that is a superset of `BuildTargets` and has a `[]DebugTarget` field. Then we can have a `DebugTargets` type that is a superset of `BuildTargets` and has a `[]DebugTarget` field. Then we can", + "reference": "Nice! Good idea to move these out of the main struct." + }, + { + "prediction": "I think this should be `if err != nil && !sigFound {`", + "reference": "Thanks for paying attention to other places this might happen. This one is particularly important; I probably never should have gotten in the habit of CheckErr(), since it does a log.Panic() explicitly, which looks like something else until you look closely. It's supposed to be used places where \"can't happen\" but Things Can Happen." + }, + { + "prediction": "I don't think we need this enum. We can just use the `type` field as a string.", + "reference": "Converting this to an enum makes it obvious that I combined things that don't really belong together. It would probably be better to create two enums `StoreType` and `TransportType` (in more appropriate locations). That also makes it necessary to have (at least) two `ServerSettings` classes. `IncomingServerSettings` and `OutgoingServerSettings`. Also, the naming is inconsistent. Maybe it would be better to make the string that is used for import/export explicit, e.g. WEBDAV(\"WebDAV\")." + }, + { + "prediction": "I think we can remove the `trim` here as it's not needed.", + "reference": "It's out of scope for this PR, but I don't find this utility's name to be particularly intuitive. It speaks to nothing of what it does. Does it create a token list? Process one? Get one? `tokenListToArray` would be nice." + }, + { + "prediction": "I think this should be `this.data('has-label', label);`", + "reference": "The message for this check used the existence of a label to determine the output, which doesn't work with the current schema. So I updated it since the data only needed to know a label was present and not what it was." + }, + { + "prediction": "I think this should be `app.ProjectId != claims.Role.ProjectId`", + "reference": "nit: \"The current project does not have requested application\"" + }, + { + "prediction": "Why do we need this constant?", + "reference": "Extend Unit test for this class" + }, + { + "prediction": "I think this should be `DD_APPSEC_EXTRA_HEADERS` to be consistent with `DD_APPSEC_IPHEADER`", + "reference": "This is this a copy / paste error from above." + }, + { + "prediction": "This file is not needed.", + "reference": "this package has to be renamed to `typeinference`" + }, + { + "prediction": "I think this should be `TestCase.assertNotEqual(user.providerType, \"anon-user\");`", + "reference": "This cancels the above null-check I guess." + }, + { + "prediction": "I think it is better to keep the old property name, and add the new property name.", + "reference": "change to timerIntervalInMillis" + }, + { + "prediction": "I think this should be \"This administrator does not belong to any roles.\"", + "reference": "`any rules` should be `any roles`" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "Why does the method need to be renamed? I would just keep the old name and update the other uses (which are only tests). That way, we can reduce code duplication." + }, + { + "prediction": "This should be `conf = keyconf.KeyConfigParser(None, None)`", + "reference": "I'm not sure if this is going to work - I think it's fine to keep them hardcoded here, as the statusbar can still show `:`, `/` and `?` even if the key is rebound." + }, + { + "prediction": "Why is this removed?", + "reference": "@tmetzke shouldn't we replace this library with the `2.12.1` instead of removing it?" + }, + { + "prediction": "I'm not sure what you mean by \"this struct needs a field which represents the size of sectors that this miner has committed\"", + "reference": "uint64 seems excessive here. Should we reduce to a uint32 @whyrusleeping ?" + }, + { + "prediction": "I think we can get rid of the `initStorageOpts` struct now.", + "reference": "Hmm, I thought this was getting used. These are used elsewhere as a cached value (in `svc deploy` it's `o.targetApp`) but I guess since storage doesn't actually need to validate that the app exists, just that there are local services, we never used it." + }, + { + "prediction": "I'm not sure this is the right thing to do. If the remote address is an IPv6 address, this will fail. I think we should only do this if the remote address is an IPv4 address.", + "reference": "To keep it simple, how would you feel about just using r.RemoteAddr? Since every request comes through here I want it to be as lean as possible. Frankly I'm OK with the port showing up in the log; maybe it'd even be useful to someone." + }, + { + "prediction": "I think we can remove the `a.hasFoundationBonusExtension()` check and just use `a.grantFoundationBonus(epochNum)` here.", + "reference": "grant bonus depends on both `admin{}` stored in statedb, and `P2Start/End` in local struct, which is kind of weird at Kamchatka height, we add the bonus Start/End epoch into `admin{}`, so it solely depends on `admin{}` stored in statedb" + }, + { + "prediction": "`f'Invalid flipping direction \"{direction}\"'`", + "reference": "Use single quote to wrap the str." + }, + { + "prediction": "Should this be `perm_getNodesAllowlist`?", + "reference": "Is the plan to rename this later?" + }, + { + "prediction": "I think this should be `if ('Email' !== $this->strategy && !in_array($this->strategy, $this->strategies)) {`", + "reference": "Is there a reason why we need a special case for Email at this point? Is the idea that other methods can turn into Email even if it's not configured as a top-level option?" + }, + { + "prediction": "I think it's better to return an error instead of panicking here.", + "reference": "This wording is a bit ambiguos, I first thought it meant the directory has no entries in it. maybe \"dir\" -> \"dir string\"?" + }, + { + "prediction": "I think this should be a `std::atomic`, not `std::atomic`.", + "reference": "Why do we need both `HPX::m_hpx_initialized` and `HPX:: m_was_initialized`?" + }, + { + "prediction": "I don't think we need to panic here. We can just return an error.", + "reference": "also check RPCName?" + }, + { + "prediction": "I don't think this import is needed.", + "reference": "Remove unused import" + }, + { + "prediction": "I'm not sure this is the right thing to do. If we're restarting, we want to make sure that the new instance is ready before we kill the old one. If we don't wait for the new instance to be ready, we might kill the old one before the new one is ready to take over.", + "reference": "I assume there will never be a scenario where justValidate is expected to be true on a restart" + }, + { + "prediction": "I don't think this is the right place to add the listener. It should be added in the `PmdExecutor.execute` method.", + "reference": "Report listeners are synchronized, even 'though the cache is thread-safe... I've not profiled it, but it may be a cause of contingency. Any better way around this? Also, do listeners **really** need to be synchronized? Can't we just make them thread-safe?" + }, + { + "prediction": "I think this should be `nil` instead of an empty string.", + "reference": "I don't think this is correct. When `compiler` is not given in `.travis.yml`, the announcement will be `--version`, which results in \"`command not found`\" (though not critical), and the cache slug will lack this information (also not critical)." + }, + { + "prediction": "I think this should be `args = [];`", + "reference": "Why do this rather than `args = []` in the function signature?" + }, + { + "prediction": "I think this should be `['puppet-agent', 'bolt']`", + "reference": "I think we probably *should* do validation of whether there is a suitable implementation if local-validation is true. I'm not sure how useful that actually is though" + }, + { + "prediction": "I don't think this is the right way to do it.", + "reference": "@StrikerRUS here may need to concat two data by col." + }, + { + "prediction": "I don't think this is the right fix. The javadoc comment should not be prefixed with a space.", + "reference": "Why the space?" + }, + { + "prediction": "Remove the extra backtick here.", + "reference": "please resolve the extra indentation" + }, + { + "prediction": "I don't think we need to check for `Id` here, since `SrmDocument` implements `IEquatable`, so `ReferenceEquals` will return `true` if the `Id` is the same.", + "reference": "More proof that this check is needed always." + }, + { + "prediction": "I don't think we need to clear the `m_al_comms` map here. It will be cleared by the destructor of the `al_comms` member variable.", + "reference": "`m_al_comms` now contains smart pointers." + }, + { + "prediction": "I don't think this is the right place to do this. This is the place where we are generating the default value for a property. If the property is an enum, we should be generating the default value for the enum, not the default value for a string.", + "reference": "Did you do a test run with the compare script? I'm nervous about what happens on all the generators..." + }, + { + "prediction": "I think it's better to return `c.nc.RemoteAddr().String()` instead of `c.nc.RemoteAddr()`.", + "reference": "For a client, we store host, as string c.host. That is what we use for monitoring and statsz. Not sure if its useful here or not. Looks like probably not." + }, + { + "prediction": "I think this test should be updated to reflect the change in the default value of `spark.sql.shuffle.partitions` from 200 to 200 in Spark 3.0.", + "reference": "This change is suspicious. Why did the number of partitions increase?" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it works for now.", + "reference": "I'm still new to this area, so please forgive what may be a stupid question: When would this be false? And do we have a test for that situation?" + }, + { + "prediction": "I don't think this is correct. The `btnCustomMoleculeColumns.Enabled = true;` line should be inside the `if (radioMolecule.Checked)` block.", + "reference": "Should there be any changes to this file at all?" + }, + { + "prediction": "I think this should be `var autoPolicy *caddytls.AutomationPolicy = caddytls.NewAutomationPolicy()`", + "reference": "The only field being used is the KeyType; Instead, we can probably just make a `keyType` variable here." + }, + { + "prediction": "I don't think this is correct. If you pass in an options object with a `credentials` property, it will be overwritten by this line.", + "reference": "This should be done by code-gen change happening in the hydra repo. I am tweaking it just to get CI into a 'passing' state" + }, + { + "prediction": "I think this should be `@param {string[]} [options.features=[]]` to make it clear that the default is an empty array.", + "reference": "Cleaned up when I originally added support for passing `screenContext` here (and later `viewContext`) but that was removed." + }, + { + "prediction": "I don't think this is correct. The first character of a C++ mangled name is always `_` and the second character is always `Z`.", + "reference": "This looks like a bunch of whitespace fixing that's unrelated. Can you revert?" + }, + { + "prediction": "Why is this removed?", + "reference": "should be removed instead" + }, + { + "prediction": "I think this should be `caseSensitiveQuery = random().nextBoolean();`", + "reference": "should use randomization ?" + }, + { + "prediction": "I think this is a bug. We should return the error here.", + "reference": "returning nil because we want to mayactl to exit with 0 status code." + }, + { + "prediction": "I think this should be `H2O_STRLIT(\"application/json; charset=utf-8\")`", + "reference": "Is this change relevant to the PR? (and I believe we should use `text/plain` considering the fact that it can be displayed using web browsers...)" + }, + { + "prediction": "This is a breaking change, but I don't think it's a big deal.", + "reference": "`[Flags]` is now auto-generated by an argument to the `EnumHint`. (The attributes happen to come out in this order. I don't think it's worth controlling the order.) #Resolved" + }, + { + "prediction": "I'm not sure this is the right place to set this flag. I think it should be set in the `New` method of `felixsyncer`, which is called in the `New` method of `felixsyncer.FelixSyncer`, which is called in the `New` method of `felixsyncer.Syncer`, which is called in the `New` method of `felixsyncer.Syncer`, which is called in the `New` method of `felixsyncer.Syncer`, which is called in the `New` method of `felixsyncer.Syncer`, which is called in the `New` method of `felixsyncer.Syncer`, which is called in the `New` method of `felixsyncer.Syncer`, which is called in the `New` method of `felixsyncer.Syncer`, which is called in the `New` method of `felixsyncer.Syncer`, which is called in the `New` method of `felixsyncer.Syncer`, which is called in the `New` method of `felixsyncer.Syncer`, which is called in the `New` method of `felixsyncer.Syncer`, which is called in the", + "reference": "I think same here - in general we don't need to use Setters / Getters since configParams isn't a public API." + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to work.", + "reference": "Why using `fmt.Sprintf` where `fmt.Sprint` would do the work (notice no `f` in function name)?" + }, + { + "prediction": "This should be `if ariaCurrent is not None:`", + "reference": "Extraneous blank line." + }, + { + "prediction": "I think this should be \"given key is not a possible signer for either Sender or AuthAddr\"", + "reference": "nit: syntax : neither -> nor" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the best we can do for now.", + "reference": "Is it safe to assume that these two keys are always present? `this[string]` will throw a `KeyNotFoundException` if they are not." + }, + { + "prediction": "I think this should be `exflow.getFlowDefinitionId() > 0 ? exflow.getFlowDefinitionId() : flowId` instead of `(exflow.getFlowDefinitionId() > 0 ? exflow.getFlowDefinitionId() : flowId)`", + "reference": "Is the `flowDefinitionId` sufficient to uniquely identify the flow or does it need to be the tuple `` ?" + }, + { + "prediction": "`DateTime::createFromInterface` should be `DateTime::createFromInterface`", + "reference": "Shouldn't it be in the reverse order? `DateTime::createFromInterface()` returns `self` and accepts `DateTimeInterface`." + }, + { + "prediction": "I think we can remove this line as well.", + "reference": "this check is now redundant. The rest of the function downwards basically does the same thing but with safer checks." + }, + { + "prediction": "This should be `alpha_reverse` not `alpha_reverse`", + "reference": "Please could you remove the useless space." + }, + { + "prediction": "I don't think this is correct. If `arc.target < 0` then `arc.target >= 0` is false.", + "reference": "What's the point of this block (and isn't it effectively dead code)?" + }, + { + "prediction": "I think we should use `Rails.application.secrets.discourse_sso_secret` instead of `ENV.fetch(\"DISCOURSE_SSO_SECRET\")`", + "reference": "Put a comma after the last parameter of a multiline method call." + }, + { + "prediction": "I think this should be `@job(version_strategy=SourceHashVersionStrategy())`", + "reference": "Newline at end of file plz" + }, + { + "prediction": "I think this should be `sigs.k8s.io/cluster-api/api/v1alpha3`", + "reference": "Can this be refactored to avoid including the aws sdk in the types that we expose? I know it's not being exposed directly through the types we expose, but I do worry that it might make it easier to accidentally do that in the future and not realize it as easily." + }, + { + "prediction": "This method is not used anymore and should be removed.", + "reference": "Hi thomas, i would propose to indicate in the name, that only the indextime is updated, otherwise somebody might think the whole items is getting updated. I would propose something like \"updateIndexTimeByItem(Item $item)\"" + }, + { + "prediction": "I don't think this is a good idea to raise an exception in this case. If you want to check if an element is present, you should use `presence_of_element_located` or `presence_of_all_elements_located`. If you want to check if an element is visible, you should use `visibility_of_element_located` or `visibility_of_all_elements_located`. If you want to check if an element is not visible, you should use `invisibility_of_element_located` or `invisibility_of_all_elements_located`. If you want to check if an element is stale, you should use `staleness_of` or `staleness_of_all_elements_located`. If you want to check if an element is not stale, you should use `staleness_of` or `staleness_of_all_elements_located`. If you want to check if an element is not stale, you should use `staleness_of` or `staleness_of_all_elements_located`. If you want to check if an element is not stale, you should use `staleness_of` or `staleness_of_all_elements_located`. If you want to check if an element is not stale, you should use `staleness", + "reference": "This is not the right exception class. There is an InvalidSelectorException class that covers bad locators." + }, + { + "prediction": "Is this needed?", + "reference": "I assume this came from format?" + }, + { + "prediction": "I would call this `clearSearchIndex` instead of `clearSolrIndex` to make it more generic.", + "reference": "I'd suggest a default value of `false` just to make sure existing tasks are ok when they get deserialized after an update to a version containing this code." + }, + { + "prediction": "I think this should be `dumpConfig().Sdump(keys)` instead of `dumpConfig().Sdump(keys)`.", + "reference": "Do we really need this? Seems like it would pollute the logs pretty badly." + }, + { + "prediction": "I think this should be `Vector.Count * Vector.Count`", + "reference": "`Vector.Count` should Jit to const when intrinsic; not sure when `Vector.IsHardwareAccelerated == false` ; however we know `readonly static int` does Jit to const." + }, + { + "prediction": "I don't think this is the right way to do it. You should use `unittest.skipIf(sqlalchemy is None, \"PostgreSQL not available\")` instead.", + "reference": "Can we use a skipIf decorator instead?" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Missing version tags" + }, + { + "prediction": "I think this should be `if path.start_with?(Bolt::Config::Modulepath::MODULES_PATH) || path.start_with?(Bolt::Config::Modulepath::PLUGINS_PATH)`", + "reference": "I think this should also filter out `validate_resolve_reference` hooks." + }, + { + "prediction": "I think we can remove this line.", + "reference": "unrelated, but required fix as metrics branch got broken with the latest main->metrics merge and conflict resolution." + }, + { + "prediction": "This file is not part of this PR, please remove it.", + "reference": "Feel free to remove this line" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it works for now.", + "reference": "~~Should this match the key updated above?~~ :+1:" + }, + { + "prediction": "I'm not sure this is the right thing to do. If the file is not closed, it will be closed by the garbage collector, which is fine. But if the file is closed by the garbage collector, the defer will not be executed, and the file will not be closed. I'm not sure if this is a problem, but I think it is better to close the file explicitly.", + "reference": "`gofmt` allows a more compact form `defer func() { _ = f.Close() }()` or just add `// nolint:errcheck` before `defer`." + }, + { + "prediction": "I'm not sure this is the right thing to do here. I think we should keep the `*types.AttoFIL` type here, and convert it to a `*big.Int` in the `porcelain` package.", + "reference": "collateral is in FIL" + }, + { + "prediction": "Why do we need to create a new channel here?", + "reference": "We should not create channel of node which are not connected." + }, + { + "prediction": "I don't think this is correct. `options.source` is not the same as `options.db`. `options.source` is the name of the database that the user authenticates against. `options.db` is the name of the database that the user is connecting to.", + "reference": "I think the docstring should say something like \"Alias for the `source` option\" or something similar." + }, + { + "prediction": "I think it would be better to have a single `otherInformation` field with a `Map` as value, where the key is the language and the value is the translated text. This way you don't need to add a new field every time you want to add a new language.", + "reference": "Please use properties without suffix `_fr` so they can work across different languages as @teolemon mentioned" + }, + { + "prediction": "I think this should be `static void destroy_request(struct st_h2o_http3client_req_t *req);`", + "reference": "Declaration here is `static` but the definition at the bottom is non-static?" + }, + { + "prediction": "I think this should be `ContentMD5 string` instead of `ContentMD5 []byte`.", + "reference": "Hi @myml, thanks for the contribution! `blob` and `blob/driver` are both in the same module, so you shouldn't need to split this change up into multiple Pull Requests. Also, I'd like to see it working, including the implementation for `s3blob` and `gcsblob` (these should be easy, just pass-through to the provider) and `fileblob` (might be trickier...), and a test in `drivertest/drivertest.go`." + }, + { + "prediction": "I'm not sure this is the right thing to do here. I think we want to assign the transport IP to the gateway interface, but I'm not sure if that's the right thing to do here. I think we want to assign the transport IP to the gateway interface, but I'm not sure if that's the right thing to do here. I think we want to assign the transport IP to the gateway interface, but I'm not sure if that's the right thing to do here. I think we want to assign the transport IP to the gateway interface, but I'm not sure if that's the right thing to do here. I think we want to assign the transport IP to the gateway interface, but I'm not sure if that's the right thing to do here. I think we want to assign the transport IP to the gateway interface, but I'm not sure if that's the right thing to do here. I think we want to assign the transport IP to the gateway interface, but I'm not sure if that's the right thing to do here. I think we want to assign the transport IP to the gateway interface, but I'm not sure if that's the right thing to do here. I think we want to assign the transport IP to the", + "reference": "Was it a bug?" + }, + { + "prediction": "I'm not sure about this change. I think it should be `attr_value['string'] is not None and attr_value['string'] == value` because `attr_value['string'] == value` can be `True` when `attr_value['string']` is `None`.", + "reference": "# `attr_value['string'] is not None` probably not required as `attr_value['string'] == value` check is already being done" + }, + { + "prediction": "I think this should be `tabbed_browser._now_focused._last_hovered_link` instead of `tabbed_browser._last_hovered_link`.", + "reference": "You're accessing private variables here - `last_hovered_link` should be public in `TabData`. As for `tabbed_browser._now_focused`, I think you can use `tabbed_browser.widget.currentWidget()` instead." + }, + { + "prediction": "Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.", + "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." + }, + { + "prediction": "This file should be deleted.", + "reference": "We should file a bug for this - we don't need the extensions class if there are no operations on the client" + }, + { + "prediction": "I think this should be `mounter.MetricsProvider = NewMetricsCsi(volumeHandle, dir, csiDriverName(driverName))` instead of `mounter.MetricsProvider = newMetricsCsi(volumeHandle, dir, csiDriverName(driverName))`", + "reference": "Is it possible to import from k8s instead of copy in? :)" + }, + { + "prediction": "I think this should be `float` as well.", + "reference": "`@param float` can be dropped here." + }, + { + "prediction": "why remove final?", + "reference": "maybe we can leave this change un-reverted." + }, + { + "prediction": "I think this should extend `AbstractJavaAccessNode` instead of `AbstractJavaNode`.", + "reference": "I wouldn't make MethodDeclarator an AccessNode, nor an Annotatable. It's the MethodDeclaration that can be annotated, and has info about the modifiers, and is already an AccessNode" + }, + { + "prediction": "I think this should be `PlayerHeadIconEvent` instead of `PlayerHeadIconChanged`", + "reference": "delete this class" + }, + { + "prediction": "I don't think this is correct. It should be `/^[1-9][0-9]+|0|[1-9]$/.test(s)`", + "reference": "Replacing `+` (1 or more) with `*` (0 or more) would've also done the trick." + }, + { + "prediction": "I don't think this is correct. The `throw()` is there for a reason.", + "reference": "I've been meaning to fix this for a while. Thanks." + }, + { + "prediction": "I'm not sure if this is a bug or expected behavior. I would expect the order to be C, B, A, but it is A, B, C.", + "reference": "This is adding multiple processor pipelines. I guess you wanted to add multiple processors to the same, single pipeline?" + }, + { + "prediction": "`str(x[0]) in \"0123456789\"` -> `x[0] in \"0123456789\"`", + "reference": "If you need str(x[0]) here, you'll probably need str(x) the line after that I suppose. Also, shouldn't we use `raw()` here instead of `str()`?" + }, + { + "prediction": "I think 3600000ms is too long. I think 1000ms is enough.", + "reference": "3.6 seconds? what does it stand for?" + }, + { + "prediction": "Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.", + "reference": "If the command fails, is stdout nil or \"\"?" + }, + { + "prediction": "I don't think we should remove the apiVersion query parameter from this test.", + "reference": "Why is api-version now removed in the generated code?" + }, + { + "prediction": "This file is not needed.", + "reference": "We may register all built-in optimizers of PyTorch here to simplify the builder." + }, + { + "prediction": "I don't think this change is necessary.", + "reference": "No need for this new variable." + }, + { + "prediction": "I think this should be `if (c._nextState==null) { c._nextState = assign({}, c.state); }`", + "reference": "doesn't this enqueue a double render or is that safeguarded somehow" + }, + { + "prediction": "I'm not sure why this is necessary, but it seems like it should be.", + "reference": "But now you may get DATA RACE reports because c.acc is sometimes changed. I wonder if we should not rework that whole sending subs through route." + }, + { + "prediction": "I don't think we need this `#ifdef ADIOS_HAVE_PHDF5` check here. The `HDF5Reader` is only available when `ADIOS_HAVE_PHDF5` is defined.", + "reference": "Use `ADIADIOS2_HAVE_HDF5`, not `ADIOS_HAVE_PHDF5`" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Would be nice to put this in a separate context named `\"with a string and a non-string\"` (since that's what it is -- it's definitely not a non-string and a string!)." + }, + { + "prediction": "Why is this change needed?", + "reference": "Should MAX_PERTABLE_ENTRY here be 10 ?" + }, + { + "prediction": "I think it would be better to make these `static readonly byte[]` instead of `static readonly ArraySegment` so that we don't have to allocate the `ArraySegment` on every request.", + "reference": "Should move these out of frame into a static class? Similar to reason phrases?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to work.", + "reference": "That means we still create `UseLane` instructions but threat them like `Suppressed`? Can we maybe change this in the pre-processing so that we will just emit `Suppress` instructions in these cases?" + }, + { + "prediction": "remove empty line", + "reference": "no need to move here, iotex-proto is outside of iotex-core and considered same as iotex-address, go-pkgs" + }, + { + "prediction": "I'm not sure this is the right place to put this test. I think it should be in a separate test program.", + "reference": "Looks like a clang-format style violation: should turn Travis red." + }, + { + "prediction": "Align the elements of a hash literal if they span more than one line.
    Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "I think we need some YARD docs here, particularly to list all the color symbols that are valid. Otherwise users will have to look at the source to discover that." + }, + { + "prediction": "I think it would be better to use `select( STORE_NAME ).getSiteInfo().propName` instead of `select( STORE_NAME ).getSiteInfo()[ propName ]`.", + "reference": "Not sure if this needs a doc block or not since it's completely internal, but for cleaning this up. (@felixarntz docs?)" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should be able to get rid of the `Wno-deprecated-declarations` warning by using the `[[deprecated]]` attribute instead of the `__attribute__((deprecated))` GCC extension.", + "reference": "The change here is to address what exactly?" + }, + { + "prediction": "I think this should be `IsMSIEnabled` or `IsMSIAvailable` or something like that. `IsMSIEnvironment` sounds like it's a property of the environment, but it's not. It's a property of the blob storage account.", + "reference": "Is this really an Option? IIUC, you compute it automatically for the URLOpener case, why would we require a user to fill it in when using the constructor? I.e., can't we drop this and use `adal.MSIAvailable` instead? If that call is expensive, cache it on `bucket`, not `Options`." + }, + { + "prediction": "I think this should be `dp_bits = new unsigned char[size / 8 + 1];` instead of `dp_bits = new unsigned char[size / 8 + 1]();`", + "reference": "Was this done automatically or by hand?" + }, + { + "prediction": "I think this should be `desired_group = child_group.name if current_group.name == child_group.name`", + "reference": "This looks like it will only work for the first child, since after that we've overridden `desired_group`. Should we have a separate variable for this?" + }, + { + "prediction": "This should be `UNASSIGNED-validation-cache-file-error`", + "reference": "Should this be a constant somewhere?" + }, + { + "prediction": "I think we can remove the `+ AssemblyInfo.PublicKey` here.", + "reference": "nit: sort alphabetically." + }, + { + "prediction": "I don't think we should use the class name as the context key. I think it would be better to use something like `org.apache.solr.handler.dataimport.JsonQueryConverter.CONTEXT_KEY`.", + "reference": "Now, It's redundant, I suppose." + }, + { + "prediction": "I think this should be `go.uber.org/yarpc/peer/peerlist/v2\".ListImplementation`.", + "reference": "nit: The format recognized by tooling is `// Deprecated: [..]` so you likely want this to be, // Deprecated: Use \"go.uber.org/yarpc/peer/peerlist/v2\".Implementation instead." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we want to know when we can't find a telemetry endpoint.", + "reference": "nit: 1. when formatting input strings, make sure to place them in quotes so we could identify white space issues. i.e. '%s' 2. If there is untyped, non-nil error, you want to log the error string as well." + }, + { + "prediction": "I think this should be `DllImport(\"Datadog.Trace.ClrProfiler.Native.dll\", EntryPoint = \"IsProfilerAttached\", CharSet = CharSet.Ansi, CallingConvention = CallingConvention.Cdecl)`", + "reference": "I believe this can be fixed with the original code if you just omit the \".dll\" file extension so it reads `[DllImport(\"Datadog.Trace.ClrProfiler.Native\")]`. On Windows it would look for `Datadog.Trace.ClrProfiler.Native.dll` and Linux/Mac it would look for `Datadog.Trace.ClrProfiler.Native.so`." + }, + { + "prediction": "I don't think we need to check for the old value here. If the old value is `false`, then the new value will be `everything`.", + "reference": "couldn't we just read the boolean as a string (I would assume that this return \"true\" or \"false\"), migrate if to its new value and keep using the same pref key?" + }, + { + "prediction": "I think this should be `static int json_input = 0;`", + "reference": "If these variables are only used in main function, move these to the beginning of that function. If there is a foreseeable reason to have them as global statics just let me know." + }, + { + "prediction": "Should this be `nameof(region)`?", + "reference": "This one was wrong." + }, + { + "prediction": "I think this should be `allAffectedNodeIDs map[NodeID]struct{}` so that we don't have to do a linear scan to check if a node is affected.", + "reference": "What happens if nodes throughout a hierarchy are modified (as they would be)? It looks like we're going to `Reset` once for each `NodeID` affected." + }, + { + "prediction": "(style) code indent should use tabs where possible", + "reference": "> Note that allocation of vmheap fails upon initializing dynamoRIO 64 on WoW64 processes. Thus, we need to pass -reachable_heap to avoid having to make this allocation. This should be solved by changing the default `vmheap_size` to be much smaller than 8GB for x64 DR inside WOW64." + }, + { + "prediction": "Align the parameters of a method call if they span more than one line.", + "reference": "Is it really worth expanding our public API for this? After all, isn't calling this the same as calling `notification.fully_formatted(...).lines`? If so, I'd rather not widen our API (and thus, increase our maintenance burden) when it's so simple to get all the lines already." + }, + { + "prediction": "I think we can remove this class now.", + "reference": "Is it necessary to keep this class around just to define this constant? Or can we place it somewhere else?" + }, + { + "prediction": "I think we should use `PolicyRef` instead of `PolicyName` and `PolicyNamespace`.", + "reference": "Question - do we cache NetworkPolicy itself? If so, here we can point to NetworkPolicy?" + }, + { + "prediction": "why remove workqueue?", + "reference": "For my view, `Register` means the process of **insert node resource to etcd through api-server**, which is called by upstream rather than here, how about changing the func name to `OnConnected`?" + }, + { + "prediction": "I don't think we need to change the name of this variable. It's already named `telemetryEnabled` and it's used to indicate whether the telemetry is enabled or not.", + "reference": "I would prefer an active verb for this property, e.g. `initializeTelemetry`. The reason is that this property refers to something the engine does once on startup. Other properties that use passive voice (e.g. `authorizationEnabled`) refer to a state of the engine during its lifetime." + }, + { + "prediction": "I think this should be `this.Methods.Any(m => m.Parameters.Any(p => p.Type == PrimaryType.TimeSpan))`", + "reference": "please use new line to maintain reasonable line width" + }, + { + "prediction": "I think this should be `if err != nil { return }` instead of `if ta == nil { return }`", + "reference": "I would skip this check or add an internal server error response." + }, + { + "prediction": "I think this should be `if (config.notarize && config.notary_user && config.notary_password) { notarize = config.notarize notary_user = config.notary_user notary_password = config.notary_password }`", + "reference": "missing `{` here (and then `}` after `notary_password = config.notary_password`); it's only going to do the first one" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we need to make sure that we don't have a `wp-config.php` file at all in this case.", + "reference": "This is odd because it's actually in our generated SiteSettingsPath, not in the SiteLocalSettingsPath (wp-config-ddev.php). Are these two files swapped somehow? I'd expect SiteSettingsPath to be wp-config.php and SiteLocalSettingsPath to be wp-config-ddev.php. BTW, I'm *way* ok with renaming that to SiteDdevSettingsPath." + }, + { + "prediction": "I think this should be `github.com/kythe/kythe/go/extractors/config/default`", + "reference": "It seems like this must necessarily be a stopgap. Can you please add a TODO(#xyz) to point to the appropriate issue?" + }, + { + "prediction": "I think this should be `if cfg.DisableKubeProxy { return nil }`", + "reference": "Is the return signature necessary since we never actually return if there is a problem (I'm referring to the call to `logrus.Fatalf`). Let's pick a pattern and stick with it." + }, + { + "prediction": "I think we can remove this eslint rule now that we're not using `JsBarcode` as a constructor anymore.", + "reference": "@btecu why is this override needed here? I'm not seeing a `new` being used here." + }, + { + "prediction": "I think this should be `c.Errorf(\"Registering leaf with account %q resulted in error: %v\", acc.Name, err)`", + "reference": "Should it not be more something like: `MaxAccountConnectionsExceeded` here?" + }, + { + "prediction": "I think this should be `assert.Equal(t, \"default\", parseAndValidate(t, \"-compute_service_account\", \"default\").ComputeServiceAccount)`", + "reference": "minor: use a non-default CE service account for testing (since default is handled in a specific way in the code)" + }, + { + "prediction": "I think we can remove this now.", + "reference": "This is how I ran the 512MiB test. It's probably too much data for a fixture, and makes for longer functional tests (although still less than a minute on my laptop)." + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.", + "reference": "So we weren't able to hide the fact that the file wasn't pre-generated and had to introduce this \"option\" to detect that?" + }, + { + "prediction": "I'm not sure if this is the right place to put this, but I think it would be useful to have a `StatusCodeToCode` map as well. This would allow us to convert an HTTP status code to a YARPC error code.", + "reference": "Agree that exporting these maps is the best tradeoff, just registering my ongoing discontent with the lack of `const` collections." + }, + { + "prediction": "I'm not sure this is the right way to do it, but it seems to work.", + "reference": "This could probably use `const` as well?" + }, + { + "prediction": "This should be `Orig` and `Tmp`.", + "reference": "it doesn't look like these need to be exported?" + }, + { + "prediction": "I think we can remove this line.", + "reference": "I think you should remove \"fmt\" here. And change `fmt.Errorf` to `errors.Errorf`." + }, + { + "prediction": "Align the parameters of a method call if they span more than one line.
    Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Here's the `resources` attribute @jferris. I'm not against renaming `Product` to `Resource`, and this one... something else." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get the finalFunc to run.", + "reference": "If the context is unused, this is equivalent to `var wg errgroup.Group`." + }, + { + "prediction": "I think this should be `HIGHLIGHT + \".fragsizeIsMinimum\"` to be consistent with `fragsize` and `fragsizeIsMinimum`.", + "reference": "very minor: I'd prefer these two added rows are switched so that fragsizeIsMinimum directly follows fragsize" + }, + { + "prediction": "I think this should be `if host in ('localhost', '127.0.0.1', '::1'):`", + "reference": "Given that 115 returns `True`, why would this be `False` here?" + }, + { + "prediction": "I think it would be better to have a separate test for this case, because it is not the same as the previous one.", + "reference": "Please move this test method just below `oauth2LoginWithOneClientConfiguredThenRedirectForAuthorization()`" + }, + { + "prediction": "This should be `PubDataparam.qos.m_liveliness.lease_duration = c_TimeInfinite;`", + "reference": "Why this new configuration?" + }, + { + "prediction": "I think we can just do `return new DataByteArray(dupe.array(), dupe.arrayOffset(), dupe.remaining());`", + "reference": "I don't think that we need to check `hasArray` here. I think the reason why this didn't previously check `hasArray` is that the array passed to `DataByteArray` must start at offset 0 and be valid through the array length, so a copy was needed in almost every case. It may be simpler to change this to use `ByteBuffers.toByteArray` and pass the result to create `DataByteArray`." + }, + { + "prediction": "Should this be `in SpanReference spanReference`?", + "reference": "`spanReference` -> `baggage`" + }, + { + "prediction": "I think this should be `/static/logo.png` instead of `/-/static/logo.png`", + "reference": "Why the `/-/verdaccio/` ?" + }, + { + "prediction": "`enableAddons` is not used in this test, so I removed it.", + "reference": "Has been waiting for a million years" + }, + { + "prediction": "typo: \"after than\" -> \"after than\"", + "reference": "Minor grammar detail: the 'than' is unnecessary" + }, + { + "prediction": "`item_top_two = self._internal._sdf.select(scol).head(2)` -> `item_top_two = self._internal._sdf.select(scol).limit(2).collect()`", + "reference": "I think you can just simply fix this line to `self[:2].to_pandas()`" + }, + { + "prediction": "I think this should be `if (debuggerAddress.match(/\\/se\\/cdp/)) {` instead of `if (debuggerAddress.match(/\\/se\\/cdp/)) {`", + "reference": "if we are returning the `ws` here when passing in `se:cdp` we can just return it straight or do we have to make a request to get the `ws` address?" + }, + { + "prediction": "I think this should be `import { registerStore } from 'googlesitekit/datastore/site';`", + "reference": "I could add a resolver for this (like above) but it seems more sensible to just change the one reference!" + }, + { + "prediction": "I think it would be better to log the difference between the actual time and the minimum time, rather than the minimum time itself.", + "reference": "not sure \"actual\" adds value - secondsSinceParent is probably closer." + }, + { + "prediction": "Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
    Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside { missing.<", + "reference": "Line is too long. [94/80]" + }, + { + "prediction": "You cannot delete any item. You should modify the existing. -> You cannot delete any item. You must modify the existing.", + "reference": "The error should be `At least :number items are required`" + }, + { + "prediction": "I think we can remove the `done` parameter from `HandleConsensusMsg` as well.", + "reference": "singleCaseSwitch: should rewrite switch statement to if statement (from `gocritic`)" + }, + { + "prediction": "I'm not sure this is a good name. I think we should just call it `KeyManager` and have it implement both `encryptionKeyGetter` and `mdDecryptionKeyGetter`.", + "reference": "Could combine this with `encryptionKeyGetter` to have a single `keyGetter` interface. I'm not sure which way is better." + }, + { + "prediction": "I think this should be deleted.", + "reference": "Is there any security issue here? If we integrate with Hive security (and I don't know if we have or not) is there some notion of re-authentication at connection time?" + }, + { + "prediction": "I think we should also remove `readConcern` from the `illegalCommandFields` array.", + "reference": "Does this mean we do not support writeConcern on `createCollection`?" + }, + { + "prediction": "I think this test should be updated to use `sid` instead of `sid.ID`", + "reference": "I guess `sid` was for `sessionID`, but now it looks strange: `sid.ID`." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think we need to allow traffic from the API server LB to the control plane and node security groups. The control plane and node security groups are used by the API server LB to route traffic to the control plane and node security groups. If we don't allow traffic from the API server LB to the control plane and node security groups, then the API server LB will not be able to route traffic to the control plane and node security groups.", + "reference": "We'll need `infrav1.SecurityGroupBastion` as well" + }, + { + "prediction": "I think this should be `if doPublicLink == nil { return \"\", errors.Errorf(\"%v doesn't support public links\", f) }`", + "reference": "This `fileName` should probably be `remote` and be relative to the Fs root as per normal rclone usage." + }, + { + "prediction": "I think this test is no longer needed.", + "reference": "That way we are back to having just one index on k_0 So we can really compare the execution times with and without re-indexing" + }, + { + "prediction": "This is not a regular expression, it's a string.", + "reference": "Expression that uses a negation pattern to exclude all characters that aren't in the expression." + }, + { + "prediction": "I think this should be `Rpc-Respond-Service-Header` instead of `Rpc-Respond-Service-Header`.", + "reference": "Similar to my suggestion for HTTP, let's remove this and use `ServiceHeader` instead." + }, + { + "prediction": "I think this should be `if commandSet == targetGlobalCommandPath || commandSet == targetLocalCommandPath {`", + "reference": "The serviceDirOnHost[0:1] was completely wrong. It wasn't just Windows, glad you got this fixed!" + }, + { + "prediction": "I think this is too long for a unit test. Can we reduce it to 100ms or 200ms? I don't think we need to wait for 15 seconds for an egress to be realized.", + "reference": "Would membership take 10+ seconds to detect the failed node?" + }, + { + "prediction": "I think this should be `RuntimeError(f'Markdown file \"{path}\" could not be loaded: {err}')`", + "reference": "hmm, in this case perhaps the whole try-except could be removed altogether? because if the file does not exist, it's already returning `None`. In any other case it should actually probably fail with the exception, no?" + }, + { + "prediction": "I think it's better to use `os.UserHomeDir()` instead of `homedir.Dir()`, because `homedir.Dir()` uses `homedir.Get()` internally, and `homedir.Get()` uses `os.UserHomeDir()` internally.", + "reference": "This function does not need to be public" + }, + { + "prediction": "I think it would be better to move the `ExistingTagNotice` component into the `ExistingTagNotice.js` file and import it into the `ExistingTagNotice.js` file.", + "reference": "Any chance we can get a CSS class for this? I know it's just in one place but feels like a dangerous precedent to set." + }, + { + "prediction": "this.Extensions.ContainsKey(\"nextLinkMethod\") should not be here.", + "reference": "> && this.Extensions.ContainsKey(\"nextMethodName\") [](start = 96, length = 48) From line 124, looks like we don't need `&& this.Extensions.ContainsKey(\"nextMethodName\")` condition or we don't need line 124 #Closed" + }, + { + "prediction": "Is this still needed?", + "reference": "Moving this code from compat to core shaves 47 bytes out of compat and only adds 6 bytes to core so I thought it was worth it." + }, + { + "prediction": "Why is this not needed for Silverlight and NETSTANDARD1_3?", + "reference": "Please use \".NET Core 3\" - i'm trying hard to use one form, and this is the one MS advices" + }, + { + "prediction": "I think this should be `case <-params.Ctx.Done(): return nil`", + "reference": "Unrelated to this change, but this is a fix for when TestDoStartCgroupInitHappyPath has a failure after the test goroutine has already exited." + }, + { + "prediction": "I think it would be better to have this in a separate file, so that it can be used by other tests as well.", + "reference": "Hmm, I'd really expect this to work, and yet it doesn't. I'll investigate later, though it might get Monday until I get the time." + }, + { + "prediction": "I think we should use `size_t` instead of `std::int64_t` here.", + "reference": "Does this changes affect process building dynamic libraries anyhow?" + }, + { + "prediction": "I don't think you need to import dot11 here.", + "reference": "Could you limit what is imported here?" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but it seems like a good place to me.", + "reference": "just to clarify - on line 1074 we update `zip_file_content` for non-local lambdas, but never store it, which means lambda never picks it up" + }, + { + "prediction": "I think we can remove this test now that we have the one below.", + "reference": "Golang naming convention is to use camel case `icmpPktWithTypeCode` Often the linter will complain" + }, + { + "prediction": "I think we can remove this line as well.", + "reference": "We can do away with assigning the response here too." + }, + { + "prediction": "I'm not sure this is the right fix. I think the problem is that the height of the viewport is being set to the height of the grid plus the height of the header, but the height of the grid is being set to the height of the viewport plus the height of the header. I think we need to set the height of the viewport to the height of the grid minus the height of the header, and then set the height of the grid to the height of the viewport plus the height of the header.", + "reference": "Bumping the newViewportHeight" + }, + { + "prediction": "I think this should be `master` instead of `secondaryy`.", + "reference": "Is this change correct? Looks like a typo and not sure this should be changed?" + }, + { + "prediction": "I think this should be `class_name = qname.rsplit('.', 1)[-1]`", + "reference": "I checked the tests coverage and strangely it look like those three lines are not covered (?!). Do you have the same result on your side ?" + }, + { + "prediction": "This file should not be changed.", + "reference": "nit: please try to avoid changing end of the file (it adds a noise to the code review, but does not provide too much value)" + }, + { + "prediction": "I don't think this is correct. If a model is only returned by a POST operation, then it is not a resource model.", + "reference": "I don't see the \"only\" part reflected in the code but maybe I'm missing it. Also, the indentation is misleading: the `.SelectMany` calls are perfectly aligned but are *not* operating on the same \"level\". I'd expect the second `SelectMany` to be on the same height as the inner `Where`, just break `pathObj => pathObj.Where` and lines won't be that long." + }, + { + "prediction": "I think this should be `kind => given_or_derived` as well.", + "reference": "It seems like most of these will never be nil, are they optional just in case?" + }, + { + "prediction": "I think we can remove the `-1` here.", + "reference": "`.addColumn(\"c1\", IntegerType.INT, true)` means `PkHandle=true`, maybe should add `.setPkHandle(true)` in line 31" + }, + { + "prediction": "`obj instanceof Number`?", + "reference": "how about `Cannot encode row key with non-integer type` directly?" + }, + { + "prediction": "I think we should rename this method to `fetchUnfinishedExecutionsByExecId` to be consistent with the other method.", + "reference": "The method names `fetchUnfinishedExecutions` and `fetchUnfinishedFlows` are too similar to each other. Would it be better to use the name `fetchUnfinishedFlowsMetadata` since you are only fetching metadata info about the flow?" + }, + { + "prediction": "I think this should be `sh.cmd 'git clone https://github.com/tmate-io/tmate.git', echo: true`", + "reference": "Note that `sudo` is not available by default on BSDs; there are a few places in the codebase here where that's explicitly worked around by using `su`." + }, + { + "prediction": "This file is not needed for this PR.", + "reference": "ultra nit: missing Oxford comma :P" + }, + { + "prediction": "I think this should be `doctest: +SKIP` instead of `doctest: +ELLIPSIS`", + "reference": "This is not supported in Spark 3.0.0-rc2 yet. I'd skip this for now." + }, + { + "prediction": "I'm not sure if this is the right place to put this, but I think it would be useful to have a `Query` method on the `Message` interface.", + "reference": "BLOCKING: Why does `Query` return an `*exec.FunctionSignature`?" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we want to keep the dirty block cache around so that we don't have to recreate it every time we reset the caches.", + "reference": "please move this down to immediately above the assignment to `c.dirtyBcache`" + }, + { + "prediction": "I think we can remove this example. It's just a copy of the one in the `runtimevar` package.", + "reference": "Don't need the `, err` part since you've already handled it." + }, + { + "prediction": "I think this should be `CHECK(k == 1);`", + "reference": "Please add two additional SECTIONs that show that this also works if the dative bond is in the reactant (reaction SMARTS `[O:1]->[H+]>>[O:1].[H+]`) or in the agents (reaction SMARTS `[O:1][H]>N->[Cu]>[O:1].[H]`)" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the `ServeHTTP` method of the `http.Handler` returned by `c.newListener`. That way, we don't have to worry about what happens if the file is deleted between the time we check for it and the time we remove it.", + "reference": "What happens if the certificate rotation fails and we are prematurely removing this file?" + }, + { + "prediction": "I think this should be `if !s.once.IsRunning() || s.p == nil {`", + "reference": "does this change belong here?" + }, + { + "prediction": "I think this should be `os.Getenv(\"PWD\")` instead of `os.Getwd()`. `os.Getwd()` returns the current working directory of the process, while `os.Getenv(\"PWD\")` returns the current working directory of the shell.", + "reference": "This returns an error" + }, + { + "prediction": "This should be `config:\"oneof(legacy,nft);legacy;local;nft\"`", + "reference": "If we think we might someday write a native nftables backend, do you think it would make sense to just use generic dataplane configuration? e.g, `dataplane = iptables | ebpf | nftables`, but for now selecting `nftables` uses iptables in nft compat mode?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think we need to make sure that the miner node has the same head as the other nodes. Otherwise, the miner node will not be able to connect to the other nodes, and the test will fail.", + "reference": "Looks like that helper function is general enough that it should reside in testhelpers" + }, + { + "prediction": "I think this should be `if app.DisableSettingsManagement || app.DisableDrushrcManagement { return nil }`", + "reference": "This isn't incorrect IMO, but I think it would be better to fix this in drupal7PostStartAction and also in drupal6PostStartAction. It seems to me like those were both somehow neglected on this. Use drupal8PostStartAction as example. Congrats on your first golang PR! Please make sure to test it manually." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "I'd like to ensure that the error message at least has some reference to the flag that is not allowed. Something like `/ERROR(.+)--hosts/` would work." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it makes more sense to say \"If you proceed without specifying public subnets, you will not be able to deploy Load Balanced Web Services in this environment.\" than \"If you proceed without public subnets, you will not be able to deploy Load Balanced Web Services in this environment.\"", + "reference": "Should we say \"specifying two public subnets\"?" + }, + { + "prediction": "I'm not sure what you're trying to say here, but it seems like you're saying that we can't change the `Sink` field because the controller doesn't understand when it would need to delete and create a new Receive Adapter with updated arguments. Is that correct? If so, I don't think that's true. The controller does understand when it would need to delete and create a new Receive Adapter with updated arguments. If the `Sink` field is changed, the controller will delete the existing Receive Adapter and create a new one with the updated `Sink` field.", + "reference": "Issue number? When? Why?" + }, + { + "prediction": "Is this import necessary?", + "reference": "You should not rely on `PitchCommand` being imported into speech. Please import it from `speech.commands`." + }, + { + "prediction": "I think we can remove the `auth_type` property from the `BaseTestIceberg` class, as it is not used anymore.", + "reference": "Is this a constant used in the Nessie project itself? If so, perhaps you might consider a follow up for adding `NessieCatalogProperties` class at some point, to help make them more clear to users looking to adopt Nessie coming from the Iceberg repo itself" + }, + { + "prediction": "I don't think we need to change this.", + "reference": "maybe we should rename: MinTaskID -> MinTaskIDExclusive, MaxTaskID -> MaxTaskIDInclusive," + }, + { + "prediction": "I think we should keep this as `nvidia` to avoid confusion with the `ecs-nvidia` runtime.", + "reference": "You may need to make this configurable if we expect people to be able to use the normal Nvidia runtime on other Linux distributions like Ubuntu or Debian." + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to work. I'm not sure if this is the right way to do it, but it seems to work. I'm not sure if this is the right way to do it, but it seems to work. I'm not sure if this is the right way to do it, but it seems to work. I'm not sure if this is the right way to do it, but it seems to work. I'm not sure if this is the right way to do it, but it seems to work. I'm not sure if this is the right way to do it, but it seems to work. I'm not sure if this is the right way to do it, but it seems to work. I'm not sure if this is the right way to do it, but it seems to work. I'm not sure if this is the right way to do it, but it seems to work. I'm not sure if this is the right way to do it, but it seems to work. I'm not sure if this is the right way to do it, but it seems to work. I'm not sure if this is the right way to do it, but it", + "reference": "Originally the DenyExport was a subscribe permission because it meant that if on this LN connection, if we deny export of \"foo\" it means that it would reject a subscription (hence subscribe permission) on \"foo\" from the other side. Now you are changing to simply not allowing this server to publish on \"foo\". I am not saying this is wrong, but we completely flip the meaning." + }, + { + "prediction": "I think this should be `TESTANY(DR_DISASM_INTEL | DR_DISASM_ATT, DYNAMO_OPTION(disasm_mask))`", + "reference": "> k1 src0 src2 -> dst s/src2/src1/ nit: k1 is actually src0 according to instr_get_src(instr, 0) which makes this a little confusing" + }, + { + "prediction": "I think this should be `dataDirStat.Mode() & 0777` instead of `dataDirStat.Mode() & 0077`", + "reference": "I believe that you meant to have the following on the second one, right ? `dataDirStat.Mode()^0077`" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the right thing to do.", + "reference": "The reason a `ByteCount` is used here, is that the H2 mapping in gQUIC requires this layer violation, which is why `CloseRemote` is not part of the public API. This layer violation will be resolved in IETF QUIC" + }, + { + "prediction": "I think you can just return `IsEffectInSpell(spell_id, SE_Invisibility) || IsEffectInSpell(spell_id, SE_Invisibility2) || IsEffectInSpell(spell_id, SE_InvisVsUndead) || IsEffectInSpell(spell_id, SE_InvisVsUndead2) || IsEffectInSpell(spell_id, SE_InvisVsAnimals);`", + "reference": "I dig the helper function!" + }, + { + "prediction": "I think this should be `// Package samples contains sample programs using the pubsub API.`", + "reference": "Please add the Copyright header." + }, + { + "prediction": "I think this import is not needed anymore.", + "reference": "Is this the best way to import `FileSystemTarget`?" + }, + { + "prediction": "I'm not sure this is the right thing to do here. I think we should be able to use `thread_id_t` here, but we need to make sure that `READ_TLS_INT_SLOT_IMM` and `WRITE_TLS_INT_SLOT_IMM` can handle 64-bit values on x86-64.", + "reference": "Wait -- os_local_state_t.tid is thread_id_t though, so we need to read a pointer-sized value via READ_TLS_SLOT_IMM, rather than changing these locals to ints. Maybe have a READ_TLS_TIDSZ_SLOT_IMM or sthg." + }, + { + "prediction": "I think it would be better to move this out of the `if` statement, so that the `ExtOut` call is always executed, even if the `GetCorDebugInterface` call fails.", + "reference": "Don't use ! in the messages because it isn't used on xplat. There is a SOSPrefix define that can be used (blank on xplat and ! on Windows). Do we really need 3 newlines?" + }, + { + "prediction": "I think this should be `DAGSTER_HOME must be an absolute path`", + "reference": "print out what we got here in the error" + }, + { + "prediction": "I think this should be `static struct jx *select_expr = NULL;`", + "reference": "Does this need to be global?" + }, + { + "prediction": "I think this should be `map(Tuple2::_2).toStream()`", + "reference": "Yep, could be simplified. Now looks like other *Map.values() impls" + }, + { + "prediction": "This should be `@Then /^I print the last api response$/`", + "reference": "This method will be for debug?" + }, + { + "prediction": "I think it would be better to have `Key(name, password string) (k *ecdsa.PrivateKey, created bool, err error)` return an error if the key does not exist.", + "reference": "// Key returns the private key for a specified name that was encrypted with the // provided password. If the private key does not exists it creates a new one // with a name and the password, and returns with `created` set to true." + }, + { + "prediction": "I think it would be better to have `PackageEntity` and `ClassEntity` inherit from `DiagramEntity` instead of `DiagramEntity` inheriting from `PackageEntity` and `ClassEntity`.", + "reference": "Adding the type hints revealed that it was necessary to distinguish between a ``PackageEntity`` and a ``ClassEntity``, because the ``ClassEntity`` has additional attributes that were dynamically added in the previous code, which confused ``mypy``." + }, + { + "prediction": "I think this should be `add_prefix` and `add_suffix`.", + "reference": "These two functions should be available now." + }, + { + "prediction": "I think this should be `errors.New(\"can't copy - source file is being updated\")`", + "reference": "`fi` is what the result of Stat is called elsewhere in this file not `finfo`" + }, + { + "prediction": "I'm not sure why this was removed. It seems like it should still work.", + "reference": "I'm confused; are we just dropping these methods without deprecation?" + }, + { + "prediction": "I think it's better to use `<< \"PartitionID: \" << folly::to(partId) << \", VertexID: \" << folly::to(edge.key.src) << \", EdgeType: \" << folly::to(edge.key.edge_type) << \", EdgeRanking: \" << folly::to(edge.key.ranking) << \", VertexID: \" << folly::to(edge.key.dst) << \", EdgeVersion: \" << folly::to(version);", + "reference": "can we use PC's time to version in Distributed Systems?" + }, + { + "prediction": "Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
    ", + "reference": "is this \"unless\" actually needed?" + }, + { + "prediction": "I think this should be `if (length <= 0) {`", + "reference": "We don't accept empty words for lookup anymore, again" + }, + { + "prediction": "I think this should be `>= 30` and `>= 50`", + "reference": "We'll have to account for CI installations being faster than local ones. Do y'all think we should leave it at < 30 green / < 50 orange | >= 50 red or lower our thresholds?" + }, + { + "prediction": "I don't think we should add this to the public API. It's not part of the W3C spec, and we don't want to encourage people to use it.", + "reference": "No need for this to be `W3C_` since there is no JWP equivalent" + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.", + "reference": "As far as I can tell, there's nothing that creates an instance of `Random` or that calls `rand` or `seed`. Am I missing it? If not, let's remove the `Random` class since we don't really need it and we can move the definitions of `shuffle` into `RSpec::Core::Ordering`. One less type :)." + }, + { + "prediction": "I think this should be `s.mu.RLock()` and `s.mu.RUnlock()`.", + "reference": "Is this ever actually used?" + }, + { + "prediction": "I think we can remove the `consensus.NewDefaultProcessor()` here and just call `consensus.ProcessTipSet` directly.", + "reference": "this section of the codebase should be noted as a candidate for caching, and as a place where multiple tipsets is making things extra tricky" + }, + { + "prediction": "I think this should be `IF_X86_ELSE(, set_stolen_reg_val(mc, (reg_t)os_get_dr_tls_base(dcontext));)`", + "reference": "Do we need to save the existing value of the stolen reg somehow?" + }, + { + "prediction": "Is there a way to get the total number of members in a group?", + "reference": "maxResults should come from FLAGS once #244 is submitted." + }, + { + "prediction": "I think we can remove the `#if NETCOREAPP` and `#endif` from this file.", + "reference": "is this wanted?" + }, + { + "prediction": "I think this should be `pytest.importorskip('linode_api4')`", + "reference": "What exception is actually happening here? AFAIK `pytest.importorskip` with just return `None` if there's nothing to import. Which means that this check'd always return `True`. `pytest.importorskip` is specifically designed to trigger skipping the current test anyway so I don't know why you would wrap it like this." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get the `POST /session/:session_id/element/:id/click` command to work. Without this header, the server returns a `400 Bad Request` response.", + "reference": "Does it send requests with urlencoded bodies anywhere? I thought it sends only json. Maybe content-type should be `application/json` by default?" + }, + { + "prediction": "I think this should be `--no-update-chromium` to be consistent with the other options.", + "reference": "I'm not sure about adding more flags here when we're trying to simplify things, I thought we were going to check for patches changes to decide if we needed to update or not?" + }, + { + "prediction": "testTransferHash and testExecutionHash are not used in this file.", + "reference": "`testExecutionPb` is a global variable (from `gochecknoglobals`)" + }, + { + "prediction": "This method is not used anymore, so we can remove it.", + "reference": "~Method is public and removing it would be a BC Break, you can deprecate it if you want.~" + }, + { + "prediction": "I think this should be `log.Debug(\"%v:\\n%s\", err, debug.Stack())`", + "reference": "this got me a little confused when reading `build.log`. The err is printed with a log.Error later on but that ends up after the stack trace." + }, + { + "prediction": "I think this should be `--rust-keep-namespaces` to be consistent with the other options.", + "reference": "Can we make these more explicitly for Rust only? It seems like JS and Go use flags with their name in them." + }, + { + "prediction": "I think this should be `u.String()` instead of just `u`.", + "reference": "Should unsupported query parameters just be ignored? I think that's more common than error out." + }, + { + "prediction": "I think this should be `Register._UNSET_NAMESPACE`", + "reference": "Actually can we avoid mentioning `Register._UNSET_NAMESPACE`. I thought of it as an implementation detail of the simpler concept of \"being unset\". Perhaps the docs become more natural if we remove the \"If called without arguments or with ...\" part and just say \"you have to call this function without arguments at the end of any file it has been used. That is to ensure blah blah\". Something like that. Just a suggestion." + }, + { + "prediction": "I'm not sure this is the best way to handle this. I think it would be better to raise an exception here and let the calling code handle it.", + "reference": "I assume it raises COMError? If so perhaps best to just catch that specifically, so as to not hide other more critical errors." + }, + { + "prediction": "This should be `github.com/abiosoft/caddy-minify`", + "reference": "Since minify can generate errors, it should at least go after the errors middleware. And you definitely don't want to be minifying after the gzip writer has closed." + }, + { + "prediction": "I'm not sure if this is the right place for this, but I think it would be good to have a `TracerProvider` interface that has a `Tracer` method. This would allow us to have different implementations of `TracerProvider` (e.g. one for testing, one for production, etc.)", + "reference": "nit: we could remove the `config` field as it is a duplicate of the `provider.config` field." + }, + { + "prediction": "I think this should be `forseti-server-allow-grpc-internal`", + "reference": "Nit: from the Internet." + }, + { + "prediction": "remove empty line", + "reference": "this is internal package, move to bottom and run 'make fmt'" + }, + { + "prediction": "Should this be `IConnectionLifetimeNotificationFeature` or `IConnectionLifetimeNotification`?", + "reference": "Why is this better than ApplicationStopping?" + }, + { + "prediction": "I think this should be `One of \"http-01\" or \"dns-01\".`", + "reference": "Maybe worth expanding that these 2 are supported by cert-manager but other values exist" + }, + { + "prediction": "I think this should be `$options['src'] = $provider->generatePublicUrl($media, $format);`", + "reference": "Why was this merged? It should have raised some questions IMO @core23 @OskarStark . It's already in 3 releases now, so we can't revert it can we? How can we fix this? Please have a look at #1065" + }, + { + "prediction": "I think this should be `if (node.jsonRpcConfiguration().getAuthenticationPublicKeyFile().isPresent())`", + "reference": "What if `node.jsonRpcConfiguration().getAuthenticationPublicKeyFile()` is empty string, would that cause a problem here?" + }, + { + "prediction": "@deads2k I'm not sure if this is the right way to do this. I'm not sure if we want to add this to the CertificateSpec or if we want to add this to the CertificateSigningRequestSpec. I'm not sure if we want to add this to the CertificateSpec or if we want to add this to the CertificateSigningRequestSpec. I'm not sure if we want to add this to the CertificateSpec or if we want to add this to the CertificateSigningRequestSpec. I'm not sure if we want to add this to the CertificateSpec or if we want to add this to the CertificateSigningRequestSpec. I'm not sure if we want to add this to the CertificateSpec or if we want to add this to the CertificateSigningRequestSpec. I'm not sure if we want to add this to the CertificateSpec or if we want to add this to the CertificateSigningRequestSpec. I'm not sure if we want to add this to the CertificateSpec or if we want to add this to the CertificateSigningRequestSpec. I'm not sure if we want to add this to the CertificateSpec or if we want to add this to the CertificateSigningRequestSpec. I'm not sure if we want to add this to the Certificate", + "reference": "The `omitempty` struct tag does not do anything for non-pointer structs. I think we may need to consider making both of these fields pointers, so that they are excluded from output when not set, and also to make it easier to compare to the zero value. That said, I'm happy to merge this now and open an issue to verify the behaviour is as we want ahead of cutting v0.6.0." + }, + { + "prediction": "I think this should be `t -> to.equals(t) ? null : t.getNext()`", + "reference": "I think this is should absolutely be `==`, as the interface cannot control the implementation of equals (and it's part of the contract of the enclosing function). Can we add this interface to the exceptions of the rule?" + }, + { + "prediction": "I'm not sure I like the idea of storing the namespace labels here. I think it would be better to store them in the `namespace` field, which is already a `*coreapi.Namespace` object. That way, we don't have to worry about whether or not the `namespace` field is nil, and we don't have to worry about whether or not the `namespace.Labels` field is nil, and we don't have to worry about whether or not the `namespace.Labels` field is empty, and we don't have to worry about whether or not the `namespace.Labels` field is a valid label set, and we don't have to worry about whether or not the `namespace.Labels` field is a valid label set, and we don't have to worry about whether or not the `namespace.Labels` field is a valid label set, and we don't have to worry about whether or not the `namespace.Labels` field is a valid label set, and we don't have to worry about whether or not the `namespace.Labels` field is a valid label set, and we don't have to worry about whether or not the `namespace.Labels` field is a valid label set, and we don't have to", + "reference": "It looks like the UID is the only other thing that we use from `namespace`, so I suggest to copy that out and lose `namespace`, so we don't have to worry about setting it to nil." + }, + { + "prediction": "I think this should be `aws/codebuild/amazonlinux2-x86_64-standard:4.0`", + "reference": "Can we define this constant in the`deploy` pkg instead? this would allow us to keep it private" + }, + { + "prediction": "I don't think this is correct. `set_current_module` should be called with the name of the module, not the path to the file.", + "reference": "I don't like this fixture name, should be a noun like `initialized_linter` ? But it's outside of the scope of this MR." + }, + { + "prediction": "I think we should pass the `settingsService` into the `ExportService` constructor and then pass it into the `JsonPrinter` constructor. This way we don't have to create a new `JsonPrinter` every time we want to export a dataset.", + "reference": "Could we keep this as a static reference (JsonPrinter.jsonAsDatasetDto(releasedVersion); and perhaps change the constructor line to just be a static set method and use that here instead? (I suspect it was the warning that 'static methods should be accessed in a static manner' from my IDE that caused me to make this change in the first place...) (I can make a PR to your branch if you want.)" + }, + { + "prediction": "I don't think we need to add `COMMAND` here. It's not a modifier key, it's a command key.", + "reference": "Keys.COMMAND seems to be an alias to Keys.META. That isn't mentioned?" + }, + { + "prediction": "I think we should rename this to `DiskBlockCacheFractionSetter` and `SyncBlockCacheFractionSetter` to be consistent with the other interfaces.", + "reference": "This should go in `ConfigLocal` (and then re-generate the mocks)." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the right thing to do. If we don't have a `release_msid` or `artist_msid` in the database, then we don't have a release or artist, so we shouldn't include it in the output.", + "reference": "Nitty but entry.get for the same thing" + }, + { + "prediction": "This is the golang entry point for runc init, executed before main() but after libcontainer/nsenter's nsexec().", + "reference": "Might not hurt to mention the function never returns (since this all ends in `execve`) so `main` never actually runs." + }, + { + "prediction": "I think it would be better to log this as an error, since it's a fatal error for Kestrel to not be able to determine this value.", + "reference": "nit: add new line after this block" + }, + { + "prediction": "I think this should be `3.25rem;` instead of `3.25rem;`", + "reference": "I believe there is some javascript that also uses this 60px number for calculations. I think I'd rather keep the number in px instead of rem to make that correspondence easier to see. If 3.25rem != 60px, can you also change the other place where `60` is used to in the JS?" + }, + { + "prediction": "I don't think we need this import anymore.", + "reference": "retrying is an installed 3rd party library just like jinja and sendgrid; perhaps try grouping all of them together?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get a `List` from an `ArrayList` or `Vector`.", + "reference": "you could always use List.listIterator with previous() and hasPrevious() to traverse all kinds of j.u.List backwards. No need for special cases for ArrayList and Vector." + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work for now.", + "reference": "remove the bitmap of index 1 from the list not the 0th one. because when we keep on undoing, it would be better if we end up with the original image rather than some randomly edited image. I am not sure whether only just removing bitmap from the list would clear memory. I think you should call bitmap.recycle before removing that bitmap from the list." + }, + { + "prediction": "This should be 2021.", + "reference": "this is a existing file so let's keep 2019" + }, + { + "prediction": "I think this should be `Integer.valueOf(type.getBitMask())`", + "reference": "can you change this instead to just `type.toString()` and then you wouldn't have to expose the getBitMask in the enum. (Alternatively you could have used `type.hashCode()` but that doesn't feel as nice)" + }, + { + "prediction": "I don't think this is correct. The ReadOnlyTrieStore should be created from the ReadOnlyDbProvider, not from the ReadOnlyTrieStore. The ReadOnlyTrieStore should be created from the ReadOnlyDbProvider, not from the ReadOnlyTrieStore. The ReadOnlyTrieStore should be created from the ReadOnlyDbProvider, not from the ReadOnlyTrieStore. The ReadOnlyTrieStore should be created from the ReadOnlyDbProvider, not from the ReadOnlyTrieStore. The ReadOnlyTrieStore should be created from the ReadOnlyDbProvider, not from the ReadOnlyTrieStore. The ReadOnlyTrieStore should be created from the ReadOnlyDbProvider, not from the ReadOnlyTrieStore. The ReadOnlyTrieStore should be created from the ReadOnlyDbProvider, not from the ReadOnlyTrieStore. The ReadOnlyTrieStore should be created from the ReadOnlyDbProvider, not from the ReadOnlyTrieStore. The ReadOnlyTrieStore should be created from the ReadOnlyDbProvider, not from the ReadOnlyTrieStore. The ReadOnlyTrieStore should be created from the ReadOnlyDbProvider, not from the ReadOnlyTrieStore. The ReadOnlyTrieStore should be created from the ReadOnlyDbProvider, not from the ReadOnlyTrieStore. The ReadOnlyTrieStore should", + "reference": "AsReadOnly() would be better here" + }, + { + "prediction": "I think it would be clearer to say that `insertions` and `newModifications` are indices into the new version of the collection, and `deletions` and `oldModifications` are indices into the old version of the collection.", + "reference": "I suggest that we use `query_based_sync` instead of `partial_sync`." + }, + { + "prediction": "Is there a way to fix this? I'd like to be able to use signed URLs for PUTs.", + "reference": "How does the user use this? By converting the type using `As` function and add the header? Maybe add an example on how." + }, + { + "prediction": "nit: `initCodeTransformer` -> `initTransformer`", + "reference": "I'm trying to understand the effects of this change. Is setting this to something other than the old default (that is, `initCodeTransformer = new InitCodeTransformer()`) generally necessary, or are we doing this only to support Python?" + }, + { + "prediction": "I'm not sure I like this change. I think it's important to be able to have a zero value key, and I think it's important to be able to have a zero value key because it makes it possible to have a zero value key, and I think it's important to be able to have a zero value key because it makes it possible to have a zero value key, and I think it's important to be able to have a zero value key because it makes it possible to have a zero value key, and I think it's important to be able to have a zero value key because it makes it possible to have a zero value key, and I think it's important to be able to have a zero value key because it makes it possible to have a zero value key, and I think it's important to be able to have a zero value key because it makes it possible to have a zero value key, and I think it's important to be able to have a zero value key because it makes it possible to have a zero value key, and I think it's important to be able to have a zero value key because it makes it possible to have a zero value key, and I think it's important to be able to have a zero value key because", + "reference": "\"Constructor\" isn't a standard term in Go or this project, although we use it informally amongst ourselves. And I think it will confuse people coming from languages like Java. So can we leave this as it was?" + }, + { + "prediction": "I think this test should be renamed to `test_ctu_on_demand_failure` as well.", + "reference": "Why do we have to change the test dir?" + }, + { + "prediction": "I think this should be `!el.hasAttribute('open')` instead of `!el.querySelector('summary')`.", + "reference": "This should test the flattened tree instead. details > summary works across shadow tree boundaries." + }, + { + "prediction": "This should be `Mvx.Resolve().GetLogFor(typeof(MvxAndroidLog))`", + "reference": "Not sure I am a big fan of these duplicated Log classes." + }, + { + "prediction": "I think this should be `Presented` and `Failed`", + "reference": "It's long-winded, but the convention is to give constants a common prefix which, see `reasonDomainVerified` ." + }, + { + "prediction": "I think this should be 10.0. 20.0 is way too far.", + "reference": "Using lanes later down, this threshold could be reduced for similar effects. Otherwise we look a bit to far." + }, + { + "prediction": "I think this should be `char *expansion; /* Directory in cache/. Only set when environemnt has been expanded.*/ int error; /* Whether the expansion had an error. 1 for yes, 0 for no. */`", + "reference": "Let's get more verbose about names. struct `wq_conda_environment`: if it can really only be used for conda. struct `wq_software_environment`: if it has potential use outside of conda." + }, + { + "prediction": "I think this should be `lastPageInPaginatedResp := true`", + "reference": "Should we set this back to `false` inside each `t.Run`? so that we can have more than one testcase that can have paginated responses" + }, + { + "prediction": "I think we can remove the `if (dataManifests == null) {` and `if (deleteManifests == null) {` lines.", + "reference": "What about using `dataManifests == null || deleteManifests == null`?" + }, + { + "prediction": "I think it would be better to pass `TOTAL_HITS_THRESHOLD` to the constructor of `GlobalHitsThresholdChecker` instead of creating a new instance of `GlobalHitsThresholdChecker` every time `newCollector()` is called.", + "reference": "The `HitsThresholdChecker` should be created once and shared within the collectors ? We also don't need to use the `GlobalHitsThresholdChecker` if the executor is null or if there is a single slice." + }, + { + "prediction": "nit: remove empty line", + "reference": "move this to below `antrea.io` import section" + }, + { + "prediction": "I don't think this is correct. This extension method can be used on any `Activity` instance, regardless of how it was created.", + "reference": "Seems likely to confuse people. What if we moved it into ActivitySourceAdapter and made it private?" + }, + { + "prediction": "I think this should be `if len(signedTx.Data()) > 0 && signedTx.Value().Cmp(common.Big0) != 0 { return errors.New(\"Cannot send transactions with value and calldata\") }`", + "reference": "gas price don't need to be a multiple cuz we support allll gas prices now" + }, + { + "prediction": "Can we rename this to `HandleClientProcessExit`?", + "reference": "We are exposing implementation details in the interface. What if there is no processes involved in an implementation of `ITestRequestSender`?" + }, + { + "prediction": "Please use `str(e)` instead of `e.message`.", + "reference": "It would be awesome not to handle the broad exception here. Instead, raise a custom exception, something like `ModelNotSetException`, from the `require_model()`, and then handle it here with a nicer message to tell the user to set the model first." + }, + { + "prediction": "This should be `Customize theme`", + "reference": "This already exists under the `theme` lang key, please remove this." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it works for now.", + "reference": "Let's add a simple inline HOC around the default export below to provide the value as a prop (no need to introduce a reusable function for this yet)." + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "I believe that you end up printing out the result of the assignment here instead of the netmask." + }, + { + "prediction": "I think it would be better to have these constants in a separate file (e.g. `constants.js`) so that they can be used in other tests as well.", + "reference": "We have to update the filename here." + }, + { + "prediction": "I think this should be `snake_case` instead of `snake_case`.", + "reference": "The `--cpp-field-case` looks like `--cpp-field-style` instead of `-case`. - 'unchanged' - leave unchanged (default); - 'upper_camel' -upper camel case; - 'lower_camel' - lower camel case." + }, + { + "prediction": "I don't think we need to do this anymore.", + "reference": "I haven't thought about this a lot yet, but if we were to try this change, we'd still need to keep the code to delete it from the `.origin` file for backcompat." + }, + { + "prediction": "I'm not sure this is the right place for these imports. I think they should be in the `org.hyperledger.besu.crypto` package.", + "reference": "In my opinion I think it is possible to add `private final` here" + }, + { + "prediction": "I'm not sure this is the right thing to do here. I think we want to jump to the `deny` label instead.", + "reference": "Feel like \"exit\" doesn't convey that the packet will be dropped. \"drop-and-exit\" or \"error-exit\" maybe?" + }, + { + "prediction": "I'm not sure this is correct. The `create` constructor of a `Main` actor must take a single `Env` parameter, but the `create` constructor of any other actor can take any number of parameters.", + "reference": "How do you feel about \"The Main actor\" instead of \"A Main actor\", while we're already here changing the message?" + }, + { + "prediction": "Should this be `zk-admin-read` or `zk-read`?", + "reference": "I cannot see that this new permission is used anywhere? And if the new zk handler is covered by `zk-read`, should not also existing `ZookeeperInfoHandler` handler implement PermissionNameProvider and declare the same permission, for consistency?" + }, + { + "prediction": "I don't think we need to add `list` here. `as_spark_type` is only called with `np.ndarray`.", + "reference": "Is this reasonable?" + }, + { + "prediction": "`TODO: Implement 'Shear', 'Sharpness' and 'Rotate' transforms` -> `TODO: Implement 'Shear', 'Sharpness' and 'Rotate' transforms`", + "reference": "We may move this TODO to Line15." + }, + { + "prediction": "Please use `ConfigQuery::checkAvailableStock()` instead of `true === ConfigQuery::checkAvailableStock()`", + "reference": "You have to verify the return type. If it's a reponse, return it. Otherwise do nothing." + }, + { + "prediction": "I don't think you need to change this line.", + "reference": "No. Keep the header include and do `extern template ...` to skip the instantiation from that compile unit. (I pushed a fix directly to your branch)" + }, + { + "prediction": "I think this should be `max({})` and `min({})` instead of `max({}())` and `min({}())`.", + "reference": "these tests are currently somewhat nonsensical. This code expands to `a, b = {}.keys` when it really should be expanding to `a, b = {}.keys()` -- though fixing this causes the test to fail so I suspect something worse is going on here that I don't quite understand?" + }, + { + "prediction": "I think this test should be renamed to something like `TestAvroNameMapping#testRenameNestedField` or something like that.", + "reference": "Why did this need to change?" + }, + { + "prediction": "I don't think we need this interface. We can just use `protocol.Transaction` as the return type of `NewTransaction`.", + "reference": "/go/pkg/mod/golang.org/x/xerrors@v0.0.0-20190410155217-1f06c39b4373/adaptor_go1_13.go:16:21: Frame not declared by package errors (from `typecheck`)" + }, + { + "prediction": "I don't think we need this constant. We can just use `ZkStateReader.CONFIGS_ZKNODE` instead.", + "reference": "Probably doesn't go here because I think it's specific to the HTTP API layer. This class is too internal to declare such a name." + }, + { + "prediction": "I think this test should be moved to `ITPrometheusMetricsHealth` since it's testing prometheus metrics.", + "reference": "in preparation of directly writing the /health endpoint one day.. we should have content checks." + }, + { + "prediction": "I'm not sure about this change. I think it's better to keep the `%s` format specifier, as it's more consistent with the rest of the codebase.", + "reference": "question (non-blocking): Is there a benefit from using `%q` instead of `%s`?" + }, + { + "prediction": "remove empty line", + "reference": "I would suggest to keep two empty lines between functions in cpp files" + }, + { + "prediction": "I think this should be `true`", + "reference": "This change causes the test to fail on both rocm-1.9.x and rocm-head." + }, + { + "prediction": "I don't think we need this interface. We can just check if the RuleViolation has a RuleViolationFixer associated with it.", + "reference": "I'd consider moving all fix related stuff to a distinct package to avoid contaminating the base package" + }, + { + "prediction": "I think this should be `os.path.join(entry['directory'], inc_dir)` instead of `os.path.join(entry['directory'], entry['directory'], inc_dir)`", + "reference": "Use `os.path.join` for path concatenation." + }, + { + "prediction": "`YolactProtonet` is not used in this file.", + "reference": "Use upper case: YOLACTHead, YOLACTProtonet, YOLACTSegmHead" + }, + { + "prediction": "I think we can remove the `&` here.", + "reference": "The driver tests should be updated to use the concrete type instead of the driver directly; right now your test coverage of the concrete type is 0%." + }, + { + "prediction": "I don't think this is the right place for this error message. It should be in the `Type::getTypeFromTree` method.", + "reference": "I would prefer the message to be more actionable. Like 'There should be no space between & and the variable name' or something similar." + }, + { + "prediction": "I don't think this is the right thing to do. I think we need to fix the antlr grammar to make sure that all children are Nodes.", + "reference": "The image attribute is not supposed to be the text of the node. I'd rather keep it separate (the previous `@Text` attribute was fine). A practical reason for that is in the future, other languages may have a way to get the text of their node, in which case that wouldn't be fetched with `getImage`, for compatibility, but probably with a `getText` method, or `getSourceCode` like in #1728. Also we *may* deprecate or otherwise put `getImage` out of use as soon as 7.0, given its contract is super loose." + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "The `[] +` seems weird to me. Why is it there?" + }, + { + "prediction": "Style/MutableConstant: Freeze mutable objects assigned to constants.
    Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside } missing.", + "reference": "Not sure if this constant is defined at the right place style-wise. Maybe move it up to before 'belongs_to' like DISCOUNT_TYPES in coupon.rb?" + }, + { + "prediction": "I think this should be `if string(k) != \"---\" && !bytes.HasPrefix(k, []byte(\"#\")) && string(k) != \"\" {`", + "reference": "What about a line with just spaces/tabs? Or a line with a couple spaces followed by a `#`?" + }, + { + "prediction": "Line is too long. [81/80]
    Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "if funder_is is not blank (L375) there is not need to check if org_id is not blank (L379) since you will never enter in the if (L374)." + }, + { + "prediction": "I think this should be `if (GetTarget() == nullptr) {`", + "reference": "Don't need this-> here." + }, + { + "prediction": "This import is not needed.", + "reference": "I'm a little concerned about relying on a private module, as they could change the implementation at some point, I'd like to have some test to validate this is working as intended." + }, + { + "prediction": "I'm not sure if this is the best way to handle this, but it seems to work for now.", + "reference": "There might other values that we don't support here (eg. `[]`). So it might be safer to check for the supported types instead (string or number)." + }, + { + "prediction": "I don't think this is the right place to do this. This is the place where we parse the query, not the place where we execute the query. I think this should be done in the planner.", + "reference": "FYI, It won't have any benefit to move from trivial types." + }, + { + "prediction": "I think this should be `secrets-ssm-environment-variables`", + "reference": "i missed these discussions- but ` \"secrets-ssm-environment-variables\"` is what was agreed upon with cp?" + }, + { + "prediction": "I think we can remove this import.", + "reference": "whats the difference between this package and `github.com/golang/protobuf` ? or did vscode just decided this was the package it wanted to used?" + }, + { + "prediction": "I don't think this is the right way to do it. The parent of this node is a `StackPane` which doesn't have a `getScene()` method. I think you need to get the parent of the `StackPane` which is a `BorderPane` and then get the parent of the `BorderPane` which is a `VBox` and then get the parent of the `VBox` which is a `SplitPane` and then get the parent of the `SplitPane` which is a `VBox` and then get the parent of the `VBox` which is a `SplitPane` and then get the parent of the `SplitPane` which is a `VBox` and then get the parent of the `VBox` which is a `SplitPane` and then get the parent of the `SplitPane` which is a `VBox` and then get the parent of the `VBox` which is a `SplitPane` and then get the parent of the `SplitPane` which is a `VBox` and then get the parent of the `VBox` which is a `SplitPane` and then get the parent of the `SplitPane` which is a `VBox` and then", + "reference": "Just asking: What does this line do? Does it add the stylesheet from the parent to the dialog?" + }, + { + "prediction": "I think this should be `scikit-learn<1.0.0; python_version < '3.7'`", + "reference": "Including the scikit-learn dependency here would pull in scikit-learn for everyone who depends on Dagster. If you put it in the setup.py under docs_snippets, we'd avoid that problem (although I think it's already there)." + }, + { + "prediction": "why remove this check?", + "reference": "Why remove this?" + }, + { + "prediction": "I think this test is no longer needed, as it's covered by `test_completion_item_focus` below.", + "reference": "Why remove this? It seems like we should keep this around as a regression test, unless we can guarantee this will never be called without a model set (does your new code guarantee that?)" + }, + { + "prediction": "I think this should be `global._googlesitekitUserData?.capabilities || {}`", + "reference": "Because this defaults to `{}` if `global._googlesitekitUserData?.permissions` is `false`-y, the checks below around `state.capabilities` always result in the `!! capabilities === true` path. This shouldn't have a default value of `{}` if there's the possibility that `global._googlesitekitUserData?.permissions` can be `undefined`/`false`/`null` legitimately." + }, + { + "prediction": "I think this should be called `debug-log-capacity` to be consistent with the other debug commands.", + "reference": "Please add a space after the comma here (generally, with arguments there's always a space after commas)." + }, + { + "prediction": "I think this should be \"cautiously\" rather than \"caution\".", + "reference": "From the context, should it say \"Flags defined in this class must be used with caution...\" ?" + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to work.", + "reference": "We don't need this file, we can use the one that is in the grid-ui directory" + }, + { + "prediction": "\"Imported key for account %s: \\\"%s\\\"\" -> \"Exported key for account %s: \\\"%s\\\"\"", + "reference": "\"Exported key for account\"?" + }, + { + "prediction": "I don't think we need this constant. We can just use `\"\\r\\n\"`.", + "reference": "Normally we use Environment.NewLine unless you really want it to always be \\r\\n" + }, + { + "prediction": "Why is this removed?", + "reference": "why did you remove `verifyHeaders`?" + }, + { + "prediction": "Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside } missing.", + "reference": "Thanks for cleaning up these deprecated calls" + }, + { + "prediction": "\"Invalid username\" and \"Invalid email\" is a bit too generic. I think it would be better to say something like \"Invalid username format\" and \"Invalid email format\".", + "reference": "@akarve this breaks error catching logic on the front end, I'll fix this. That's why I prefer to use some machine-friendly error codes that won't change frequently." + }, + { + "prediction": "I think we can remove this function as well.", + "reference": "We support process remoteQuery for Service. Why are we removing it ?" + }, + { + "prediction": "I think this should be a 500 status code, not 200.", + "reference": "This is specifically for testing?" + }, + { + "prediction": "Why is this removed?", + "reference": "I think this is related to the social stats and probably does not need to be removed." + }, + { + "prediction": "I don't think we need to disable this rule here.", + "reference": "Yep, jsdoc again .. It seems that when the plugin description is wrapped within `eslint-disable/enable` expression it's not generated at all. After adding the `@class AutoColumnSize` tag right after the `@plugin` tag the plugin appears in the docs. Please review the other plugins." + }, + { + "prediction": "I think this is a bug in the Azure SDK. I don't think we should have to do this. Can you open an issue on the Azure SDK repo?", + "reference": "This usage of the result doesn't look quite right. I would not expect the first page of values to be empty if there were multiple pages of results. This also obscures the error case when no values are returned (handled in the next `if` block) by returning a more generic error from the Azure SDK from `result.NextWithContext()`." + }, + { + "prediction": "I think this should be `if exe, err := exp.GetAddressDetails(hashStr); err == nil {`", + "reference": "unknown field AddressDetails in struct literal (from `typecheck`)" + }, + { + "prediction": "I think we can remove the `aws.NewConfig().WithRegion(region)` here and just use `session.Options{Config: aws.Config{Region: aws.String(region)}}`", + "reference": "Just noticed, are we specifically missing the addition of `SharedConfigState: session.SharedConfigEnable` ?" + }, + { + "prediction": "I think this should be `oldTimeIntensities.NumPoints - 1` instead of `newTimeIntensities.NumPoints - 1`.", + "reference": "Not sure what this is. Bad merge?" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should still return `ErrAccountResolverSameClaims` in this case.", + "reference": "I think this may be a RW lock." + }, + { + "prediction": "I'm not sure about this change. I think we want to keep the package name as `pluginhelper` so that it's clear that this is a helper package for plugins.", + "reference": "Perhaps we should tuck this away into a dedicated subdir and name it `config` or something similar? Or maybe it would be happy living in `common`?" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "Doing a select query inside of a loop like this is not ideal. We should fetch recipes once and then loop through it in memory to perform this check" + }, + { + "prediction": "`copy=True` is the default, so we don't need to specify it here.", + "reference": "too long here. (104 > 100)" + }, + { + "prediction": "I think it should be `Logger.Error($\"There is no handler registered for this message: ndm.{NdmMessageCode.GetDescription(message.PacketType)}\");`", + "reference": "Use TryGetValue instead of catching exception" + }, + { + "prediction": "Metrics/LineLength: Line is too long. [81/80]", + "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." + }, + { + "prediction": "I think this should be `static_cast(num_locators);`", + "reference": "I think this method should be either: - a static method of `RTPSWriter` to avoid a StatelessWriter redefinition of the function. - a setter in the `CacheChange_t` struct." + }, + { + "prediction": "I think this should be `Http2ErrorCode.CANCEL`", + "reference": "You add a stream back reference for trailers, and all of the sudden we have tight coupling!" + }, + { + "prediction": "I think we can remove this line.", + "reference": "I don't think we use `AspNetAmbientContext` anymore since . We can probably delete this file." + }, + { + "prediction": "I'm not sure about this change. I think it's better to keep it as it was before.", + "reference": "Please avoid committing build artifacts, as they produce unnecessary conflicts and noise." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to work.", + "reference": "this is vendored code so i would hesitate to make random changes to it" + }, + { + "prediction": "I don't think we need the `required: true` here.", + "reference": "We are using a different style for JSON tags. `ethAddress` - camalCase `referral_code` - snake_case" + }, + { + "prediction": "I think this should be `Microsoft.AspNetCore.Http.HttpContext`", + "reference": "Should this be `\"Microsoft.AspNetCore.Http.DefaultHttpContext\"`?" + }, + { + "prediction": "I think we should keep the assert here. If the array length is less than the group size, then the first element of the results array will be an empty array, which is not what we want.", + "reference": "removed asserts from `Vector` as it's stable enough and it may hinder inlining, even if turned off :/" + }, + { + "prediction": "I don't think we need to disable the lru_cache here, we just need to make sure that the MessageDefinitionStore is not created more than once. This can be done by making the MessageDefinitionStore a singleton.", + "reference": "Do we want to raise on the function or on the decorator?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the right thing to do.", + "reference": "How complex is to to replace `album_*` with `release_*` everywhere in the `Listen` class and places that use it?" + }, + { + "prediction": "I think this should be `return true` instead of `return false`.", + "reference": "You haven't changed any of the callers of `.Add` to check the return value, so we're now ignoring duplicates. Please fix that." + }, + { + "prediction": "I'm not sure if this is the right place to do this, but I think it would be better to do this in the `isHidden` function instead of `isHiddenWithCSS`. The reason is that `isHidden` is used by `isHiddenWithCSS` and `isHiddenWithCSS` is used by `isHidden`, so if we do this in `isHiddenWithCSS` we'll end up calling `isHiddenWithCSS` from `isHidden` which will call `isHidden` from `isHiddenWithCSS` which will call `isHiddenWithCSS` from `isHidden` which will call `isHidden` from `isHiddenWithCSS` which will call `isHiddenWithCSS` from `isHidden` which will call `isHidden` from `isHiddenWithCSS` which will call `isHiddenWithCSS` from `isHidden` which will call `isHidden` from `isHiddenWithCSS` which will call `isHiddenWithCSS` from `isHidden` which will call `isHidden` from `isHiddenWithCSS` which will call `isHiddenWithCSS` from `isHidden` which will call `isHidden` from `isHiddenWithCSS` which will call `", + "reference": "@straker should this not push to `vnode._cache.isHiddenWithCSS`?" + }, + { + "prediction": "I think this should be \"the runtimevar package uses to interact with the underlying runtime configuration services.\"", + "reference": "\"an interface\" in conceptual sense vs \"interfaces\" or \"set of interfaces\", referring to the Go interfaces - database/sql uses the latter, should we?" + }, + { + "prediction": "I'm not sure about this, but I think it would be better to have a single `if (status.getReason() == DownloadError.ERROR_IO_ERROR || status.getReason() == DownloadError.ERROR_CONNECTION_ERROR)`", + "reference": "This now checks nearly all errors that can occur. How about explicitly listing cases where we want it to retry? I think there are not many cases where we want that, as the many added conditions in the last years show :)" + }, + { + "prediction": "This is a bit of a hack, but I don't see a better way to do this. We need to know if we're doing a sync or not, but we don't want to pass it through all the layers.", + "reference": "Can you make this accept an action instead?" + }, + { + "prediction": "Use the new Ruby 1.9 hash syntax.", + "reference": "Tab inconsistency here (3 spaces instead of 2 spaces)" + }, + { + "prediction": "why do we need to change the init balance?", + "reference": "these change means we are changing epoch to 1 hour?" + }, + { + "prediction": "This should be `PANEL_DESCRIPTION_WIDTH = 544 * self.scaleSize`", + "reference": "Why this is defined in the middle of imports?" + }, + { + "prediction": "I don't think we need to import `importlib` here.", + "reference": "Could you move this to the original position?" + }, + { + "prediction": "I think this should be `oAndR.repo`", + "reference": "Is there a test that'd have caught this?" + }, + { + "prediction": "I think this is a bug in the generated code. It should be `&visibility.ListWorkflowExecutionsByTypeRequest{ListWorkflowExecutionsRequest: &visibility.ListWorkflowExecutionsRequest{...}}`", + "reference": "ListWorkflowExecutionsRequest <- this can be nil?" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Do we need to continue to support the old link, or is it dead dead dead?" + }, + { + "prediction": "I think it would be better to do this in the `GetDictionary` method, so that we don't have to repeat this logic in every place where we call `GetDictionary`.", + "reference": "Do we need `ConcurrentDictionary`? `Dictionary` can be safely read from multiple threads. See `GlobalTags`." + }, + { + "prediction": "I think this should be `seelog.Infof(\"Server OSFamily string: %s\", config.GetOSFamilyType())`", + "reference": "this seems like more of a Debugf statement" + }, + { + "prediction": "I think this should be `cb_state->queue_submit_functions.emplace_back` instead of `cb_state->eventUpdates.emplace_back`.", + "reference": "We're capturing cb_state non-const, but the function is const so, safe enough, but after going to reader/writer locks we're all going to have to key a careful eye on anything in this pattern." + }, + { + "prediction": "I'm not sure this is the right thing to do. If the user has provided a custom endpoint, then we should use that endpoint and not do any endpoint discovery.", + "reference": "Probably want to wrap the endpoint discovery work that follows in this `if` statement instead of returning early. This will make it easier to add additional request code generation logic in the future. e.g. if we add any code generation after the endpoint discovery block this check will cause it to be skipped." + }, + { + "prediction": "nit: remove the extra backtick", + "reference": "This test was giving a false positive because my change caused it to throw a different error that contained `createElement` when it should've been throwing this error. Caught this by looking at the code coverage and noticing that the line under the condition I changed was no longer covered lol." + }, + { + "prediction": "nit: trailing whitespace", + "reference": "I think this is added to wrong file. You wanted to add to cmd/agent/, right?" + }, + { + "prediction": "I think this should be `elementText != null && elementText.contains(text)`", + "reference": "Each `ExpectedCondition` implements `java.util.Function` These are expected to be stateless. This condition will leak previous `elementText` on the second usage, which doesn't seem ideal." + }, + { + "prediction": "I think this should be `PCIAddress` to be consistent with the rest of the codebase.", + "reference": "Could we consider a more explicit name, like `devicePciAddress`?" + }, + { + "prediction": "I don't think this is correct. If the executable name is `foo.exe` and the argument is `bar.exe` then this will match `foo.exe bar.exe` but not `foo bar.exe` or `foo.exe bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo bar.exe` or `foo", + "reference": "Why change this from a foreach? I can't see it gaining anything here and code styles shouldn't change just for the sake of it." + }, + { + "prediction": "I think this should be `$response->getRawResponse()` instead of `$response->getRawResponse()`", + "reference": "Is this supposed to be part of this PR?" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "DRY, worth extracting this method to axe.utils" + }, + { + "prediction": "I think this should be `APP_NAME` to be consistent with the rest of the capabilities.", + "reference": "I think there's another spot for this in DefaultCapabilityMatcher" + }, + { + "prediction": "I think this should be `message.error(\"Could not save key config: %s\" % e)`", + "reference": "`QtOSError` inherits `OSError`, so I don't think it's needed to list them both here." + }, + { + "prediction": "I think we can remove this now.", + "reference": "Instead of patching vendor, let's update the version of sdk-go to a more recent one that doesn't have this line." + }, + { + "prediction": "This should be `[]string{\"BUILD\", \"BUILD.bazel\"}`.", + "reference": "Don't think this should be here. The default is set somewhere else." + }, + { + "prediction": "I don't think this is the right way to do it. If the progress is less than 100, it doesn't mean that the test failed. It just means that the test is still running.", + "reference": "Not really important in this PR, but does BlazeMeter describe \"progress\" values anywhere? It might be nice to have a set of constants like `PROGRESS_DOWNLOADING_IMAGE`, `PROGRESS_BOOTING`, `PROGRESS_RUNNING_TEST`, etc in our BZA client." + }, + { + "prediction": "I think this should be `Optional sortOrderId()`. I don't think it's possible for a file to not have a sort order id, but it's possible for a file to have a sort order id of `null`.", + "reference": "nit: `

    ` after the line" + }, + { + "prediction": "I don't think we need to include the fonts in the installer.", + "reference": "Should we include the files with otf extension here, too? If not, I wonder why we do allow them in the source but we don't include them as per the setup" + }, + { + "prediction": "Why is this removed?", + "reference": "i think it's OK to leave this?" + }, + { + "prediction": "Why do we need to make this class public?", + "reference": "Does this need to be public? The only reference to `FlinkTypeVisitor` that I see in this PR is here, so I'm not sure why this is needed." + }, + { + "prediction": "I don't think we need to add extra spaces here.", + "reference": "No line at end of file warning" + }, + { + "prediction": "Why do we need a composite factory here?", + "reference": "This looks unused, shouldn't it point to inner processor in any way?" + }, + { + "prediction": "Why is this being removed?", + "reference": "There may be a few isolated cases where the FirstN node is added during preCodeGen. Please see GenPreCode.cpp RelRoot::preCodeGen(). The example given there about Order by where sort is added in optimizer, or a FirstN where the N value is to be specified with a param seem to be cases where we would add the FirstN later. Will current change cause such views to marked as updateable? This is minor and could be resolved later, if any change is necessary." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to work.", + "reference": "I think you should compose the %sClient part using the Name class, and then do the remaining composition with plain concatenation. Side question: why does the return type name look like it is a client type name?" + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it's the only way I could get the tests to pass.", + "reference": "All stories in this file also need the default padding." + }, + { + "prediction": "I think this should be `nameof(PrometheusExporterMiddlewareTests) + \".\" + nameof(PrometheusExporterMiddlewareTests.PrometheusExporterMiddlewareIntegration)`", + "reference": "Curious - what would be the actual value?" + }, + { + "prediction": "`datasets[0].PALETTE` should be `datasets[0].metainfo.get('palette')`", + "reference": "Is it necessary to record the palette in the checkpoint? Any reason?" + }, + { + "prediction": "This import is not used.", + "reference": "Not sure how to best do this without creating a new connection to the server everytime. Do this in another thread?" + }, + { + "prediction": "Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.", + "reference": "should we have a similar test for gsa18f procurements?" + }, + { + "prediction": "I think this is the only place where we need to use the hash160 of the recipient. All the other places we use the full address.", + "reference": "change `v.recipient` to address.Address, so can use `AccountState(v,recipient)`" + }, + { + "prediction": "Metrics/CyclomaticComplexity: Cyclomatic complexity for requires_approval_notice? is too high. [7/6]", + "reference": "Open to doing away with this altogether and maybe injecting this logic somehow into `requires_approval_notice?` in LinearDispatcher." + }, + { + "prediction": "I think it would be better to have a separate config item for each tracer, e.g. `Tracer1Timeout`, `Tracer2Timeout` and so on.", + "reference": "remove this and always enable tracer, just set the default timeout to something higher (20 seconds)" + }, + { + "prediction": "I think this should be `Optional`", + "reference": "Can we give this field a more descriptive name? When I use a variable named `icon` I normally expect an `Image` object." + }, + { + "prediction": "I think this should be `Targets []core.BuildLabel `positional-arg-name:\"targets\" description:\"Targets to filter\" required:\"true\"`", + "reference": "can't these just use the global `include` and `exclude` flags?" + }, + { + "prediction": "Please use `deltas.cuda()` instead of `deltas.new_tensor(stds).unsqueeze(0).cuda()`.", + "reference": "Is this still necessary?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get the Prometheus metrics to show up in the browser.", + "reference": "Interesting! Happen to catch an exception message or anything I can look into?" + }, + { + "prediction": "I'm not sure about this change. I think it's better to keep `resolve` and `error` as separate methods, since they do different things.", + "reference": "did this get moved to mpromise? I don't recall if it's in that lib or not." + }, + { + "prediction": "I think this should be `json:\"-\"` as well.", + "reference": "json objects should be `camelCase`" + }, + { + "prediction": "I think this should be `OneKiB` and `TwoHundredFiftySixMiB`", + "reference": "QuarterGiBSectorSize? SectorSize265MiB? Spelling out 256 seems overly verbose." + }, + { + "prediction": "I think we can remove this line.", + "reference": "Maybe with this change we can remove `using OpenTelemetry.Logs`." + }, + { + "prediction": "I think this should be `r.FormValue(\"ViewerRoleAsDefault\") == \"true\"`", + "reference": "Fix this name too." + }, + { + "prediction": "I don't think this is the right way to do it. If the record has no 001 field, `record_get_field_value(self.record, \"001\")` will return an empty string, and `int(record_get_field_value(self.record, \"001\"))` will raise a `ValueError`.", + "reference": "why this is an issue?" + }, + { + "prediction": "I don't think this is correct. `$this` is not the same as `self`. `self` refers to the current class, while `$this` refers to the current object.", + "reference": "The condition should be inverse?" + }, + { + "prediction": "I think this should be `public static final String AZKABAN_FLOW_VERSION_2_0 = \"2.0\";` and `public static final Double VERSION_2_0 = 2.0;`", + "reference": "this seems to be a property key name, so should it be a inside configurationkey.java?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get `zfs destroy` to work with the `-f` flag.", + "reference": "G204: Subprocess launching should be audited (from `gosec`)" + }, + { + "prediction": "I think this should be `True` by default.", + "reference": "Please add docs here. And also warn users that this mode should be avoided whenever possible, because any blocking IO will make the keep-alive-thread not run." + }, + { + "prediction": "I think this should be `Object.keys( dimensionFilters ).every( ( dimension ) => typeof dimensionFilters[ dimension ] === 'string' && dimensionFilters[ dimension ].length > 0 )`", + "reference": "We shouldn't require dimension values to be a string. They just need to be scalar values (probably we could check whether it's either a string or a number). Something more important to cover in the validation here though is to ensure that a map of `dimensionName => dimensionValue` is passed. The keys here actually need to be strings. For example someone shouldn't be able to pass an array of values." + }, + { + "prediction": "I think we can remove the `yarpc.UnaryTransportHandler` interface from the `MapRouter` struct.", + "reference": "let's do a pointer cast of nil, similar to the `MapRouter` above" + }, + { + "prediction": "I think this should be `do_action( 'neve_add_settings_to_hfg_rows', SettingsManager::get_instance(), $row_setting_id, $row_id );`", + "reference": "action should use a prefix of `hfg` rather than `neve` as we plan to bootstrap this as a standalone library. Moreover, previously filter/actions used in this library was using the same pattern." + }, + { + "prediction": "I think this should be `sslOptions.ApplicationProtocols.Add(SslApplicationProtocol.Http11);`", + "reference": "I'm halfway tempted to disable this for all https connections. Do you know of any clients that actually renegotiate for any reason?" + }, + { + "prediction": "`visibility_of_any_elements_located` -> `visibility_of_at_least_one_element_located`", + "reference": "shouldn't **call** return a boolean?" + }, + { + "prediction": "I don't think we need to add a blank import here.", + "reference": "I don't think you need the blank import here. This one uses awsdynamodb directly." + }, + { + "prediction": "I don't think this is correct. If `eqDeletes` is empty, then `isDeleted` should be `t -> true`.", + "reference": "I think this should be initialized to `null` instead of a predicate. There is no need to run an extra predicate (with an extra method dispatch for each row in a data file. That's a tight loop so we should do more work here to avoid it. Instead of using `isDeleted.or`, this should test whether `isDeleted` is `null` and either initialize `isDeleted` or call `isDeleted.or`." + }, + { + "prediction": "`args.ctu_in_memory` is a boolean, so this should be `args.ctu_in_memory and args.ctu_dir`", + "reference": "What is this and the next entry in config_handler used for?" + }, + { + "prediction": "I think this should be `&memoryPlugin{mtx: &sync.RWMutex{}}`", + "reference": "will your editor integrate `gofmt`, `goimports`, etc...?" + }, + { + "prediction": "I don't think this is necessary. If the intent extras are null, the app will crash when you try to get the serializable.", + "reference": "looks like the code is not properly formatted. for example here are some missing spaces in **if** command. please take care and reformat the code using default android formatting." + }, + { + "prediction": "I think it would be better to have a `--min-bug-path-length` and a `--max-bug-path-length` argument.", + "reference": "Please add some valid examples to help message like `\"4:10\"`, `\"4:\"`, `\":10\"`" + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "Is it only Symbols we're worried about converting? Is it not safe to just call `to_s` anyway?" + }, + { + "prediction": "I think we can remove this as well.", + "reference": "Note for those who come across this later: It was moved to `testhelpers.mining.go` so that `testhelpers.NewDaemon` and the `mining/worker_test.go` can share it." + }, + { + "prediction": "I'm not sure about this change. I think it's better to keep the `incomplete_trails` method as it is, and add a new method called `in_progress_trails` or something like that.", + "reference": "What about `sort_by(&:in_progress?)`? Maybe with a `.reverse` thrown in?" + }, + { + "prediction": "I think this should be removed from the list of flags for execution as well.", + "reference": "Flag is removed because it is only gRPC now." + }, + { + "prediction": "I think this should be `.. program:: molecule init role --role-name foo --template path` and `.. option:: molecule init role --role-name foo --template path`", + "reference": "Might be better to rephrase to: Please refer to the ``init scenario`` command in order to generate a custom ``molecule`` scenario. Since you aren't customizing the default scenario since it already exists, right?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to work. I'm not sure if there's a better way to do this.", + "reference": "Shall we merge these `if` for `path lib` and then do the `attrname` one. I'm trying to count `if`-calls and its getting late but I think we can reduce the number checks needed to get into L648 from 3 to 2 if you understand what I mean" + }, + { + "prediction": "This import is not used.", + "reference": "why depend on recovery???" + }, + { + "prediction": "Why is this change needed?", + "reference": "the done channel only aims to be closed, so `chan struct{}` is better then `chan interface{}`" + }, + { + "prediction": "I think this should be `error creating gas price oracle contract binding`", + "reference": "Do you mean to have gas_oracle changes in this PR?" + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to work.", + "reference": "Is this effectively requiring browsers support javascript?" + }, + { + "prediction": "I think this should be `SalesforceSDKManager.getInstance().isDarkTheme()` instead of `SalesforceSDKManager.getInstance().isDarkTheme(getActivity())`", + "reference": "Lowercase `boolean` - use the primitive type." + }, + { + "prediction": "Should this be a warning instead of an error? I think we want to continue uploading the rest of the items even if one of them already exists.", + "reference": "This isn't the correct logic. if allowOverride == true and !blobExists then upload. Just don't do the exist check if allowOverride is set to true." + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to work for me.", + "reference": "Can you replace these by `else if` please?" + }, + { + "prediction": "I think this should be `await expect( page ).toClick( '.mdc-select__selected-text', { text: new RegExp( fromRange, 'i' ) } );` instead of `await expect( page ).toClick( '.mdc-select__selected-text', { text: new RegExp( fromRange, 'i' ) } );`", + "reference": "Would be nice if the field had a unique class name that could be used to target it, instead of `fromRange` But doesn't seem to be a common thing in the code base." + }, + { + "prediction": "`header.id` is a string, and `reffedHeaders` is an array of strings, so you don't need to call `getAttribute('id')` here.", + "reference": "Does this code fit on one line under 80 characters? It would be more consistent with our existing style." + }, + { + "prediction": "I don't think this is correct. The CASTs in the 0.6.0 list are not fallbacks for the CASTs in the 0.7.0 list, they are fallbacks for the CASTs in the 0.6.0 list. The CASTs in the 0.7.0 list are not fallbacks for the CASTs in the 0.6.0 list. The CASTs in the 0.6.0 list are not fallbacks for the CASTs in the 0.7.0 list. The CASTs in the 0.7.0 list are not fallbacks for the CASTs in the 0.6.0 list. The CASTs in the 0.6.0 list are not fallbacks for the CASTs in the 0.7.0 list. The CASTs in the 0.7.0 list are not fallbacks for the CASTs in the 0.6.0 list. The CASTs in the 0.6.0 list are not fallbacks for the CASTs in the 0.7.0 list. The CASTs in the 0.7.0 list are not fallbacks for the CASTs", + "reference": "Not a requirement here. But i see a change in naming convention. We can rename the function to `CstorSparsePoolArtifactsFor070`." + }, + { + "prediction": "I think this should be `machine.GP11`", + "reference": "Why do you configure the UART like this? It's already configured by default." + }, + { + "prediction": "(style) Macros with complex values should be enclosed in parentheses", + "reference": "Wow. Good catch. \"This `#include` was brought to you by the department of redundancy department.\" ;)" + }, + { + "prediction": "I think this should be `github.com/jetstack/cert-manager/pkg/logs/logr`", + "reference": "Well it's actually calling `AuthorizeOrder` and this seems like a DebugLevel message to me, maybe it should be dropped entirely." + }, + { + "prediction": "I think this should be `if ((ptr == nullptr) || (bytes == 0)) return;`", + "reference": "Should this be using the `CUDA_SAFE_CALL` macro here?" + }, + { + "prediction": "I think this should be `Console.ForegroundColor = ConsoleColor.Gray;` instead of `Console.ForegroundColor = ConsoleColor.Red;`", + "reference": "What cases do you see as being valid for not having any tests to run? If a test project doesn't have any tests to run we should avoid running it at the project level." + }, + { + "prediction": "I'm not sure if this is the right place to do this, but it seems like a good place to me.", + "reference": "and is it possible that mset.mirror.msgs be nil? because if so, then you would get a panic also because of that." + }, + { + "prediction": "I think this should be `pixman_region32_copy(&state->opaque, &next->opaque);` instead of `pixman_region32_copy(&next->opaque, &next->opaque);`", + "reference": "`next->opaque` should not be cleared." + }, + { + "prediction": "I think this should be `if juc.IssuerAccount != \"\" && !acc.hasIssuer(juc.Issuer) {`", + "reference": "already what? I know what, but seems like smth. is missing in this sentence" + }, + { + "prediction": "I don't think we need to disable the button here.", + "reference": "Can you put spaces after the `{`and before the `}`" + }, + { + "prediction": "I think this should be `%(version)s` instead of `%(__version__)s`", + "reference": "We said we would put `[ ]` around the version. `[forseti-security] [v2.3.0]`" + }, + { + "prediction": "I think this should be `len(cnb) > 0 && n >= int64(cap(cnb[0]))`", + "reference": "Seems len(cnb[0]) will be the length after the write since of the *v thing we saw no?" + }, + { + "prediction": "`interface{}` is not a good type to use. Can you use a concrete type here?", + "reference": "can we make use of storagepoolclaim type rather than the generic interface{} type?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in `AddPeers` itself.", + "reference": "this should happen before the `go k.manage()`, otherwise the node will always try the bootnodes first" + }, + { + "prediction": "I think this should be `(?=[^\\\\]%[nbs])`", + "reference": "Is this actually a lint related change?" + }, + { + "prediction": "Metrics/LineLength: Line is too long. [82/80]", + "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." + }, + { + "prediction": "I think this should be `if obj is not None and not isinstance(obj, string_types) or obj == ''`", + "reference": "what does this do that str_param does not?" + }, + { + "prediction": "I think this should be `return fmt.Sprintf(\"%s/%s/%s\", prefix, api, version)`", + "reference": "For GCP we included the API name (see below) so you can distinguish between uses other than `blob` once they exist, WDYT?" + }, + { + "prediction": "I think we should just make this a hard dependency. It's not a big deal, but it makes it easier for users to know what they need to install to get this to work.", + "reference": "what would you think about doing this include on-demand within S3ObjectStore methods and then failing in a loud way?" + }, + { + "prediction": "I think this should be outside of the loop, otherwise it will break after the first iteration.", + "reference": "May be better make `stopped` atomic, then it can be just `for (auto i (node.store.latest_begin (transaction_a, next_frontier_account)), n (node.store.latest_end ()); i != n && && !stopped && elections_count < max_elections; ++i)`" + }, + { + "prediction": "`future_addEdgesAtomic` -> `future_chainAddEdges`", + "reference": "In `src/storage/InternalStorageServiceHandler.h ` file, the client in `client->future_chainAddEdges ` should be InterStorageServiceAsyncClient?" + }, + { + "prediction": "I think we should move this import to the top of the file.", + "reference": "`go.sum` needs to be updated for this. Please run `go mod tidy`" + }, + { + "prediction": "I think this should be `SecretBackendSSMParameterStore` and `SecretBackendSecretsManager` instead of `SecretBackendSSMParameterStore` and `SecretBackendSecretsManager`.", + "reference": "Not sure if this was discussed previously, but is there a specific use case in mind for having this as an API field rather than a configuration option on the controller manager? Is there a specific use case in mind where one would want to choose different backends for individual Clusters/Machines vs having it a global configuration for an instance of the infrastructure provider?" + }, + { + "prediction": "I think we should remove this line as well.", + "reference": "Same thing with the OtlpExporter" + }, + { + "prediction": "I'm not sure this is the right thing to do, but I think it's the right thing to do.", + "reference": "Should not be removed." + }, + { + "prediction": "I think we can remove the `include BeakerPuppet::InstallUtils` line here.", + "reference": "Not a blocker for anything, but should this be moved to beaker-pe? Is that ticketed anywhere?" + }, + { + "prediction": "This should be `afterInteractingWith(element, driver);`", + "reference": "this shouldn't be beforeClickOn, but rather beforeSubmit? and added to WebDriverEventListener. Since submit does not synthesize the 'click' events, this isn't accurate." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work for now.", + "reference": "this ternary operator is hiding an `if/else` within an `if/else` - any chance we could move the logic ELSEwhere? (see what I did there -- ?? :100: )" + }, + { + "prediction": "I think this should be `@deprecated` instead of `@Deprecated`.", + "reference": "Is this really internal? Or will the API be different in PMD 7.0.0? Well, the interface doesn't offer much functionality anyway..." + }, + { + "prediction": "I think this should be `multi_ragged` to distinguish it from `gridded`.", + "reference": "Does it have to be arrays? Isn't it ragged 'data' (i.e multiple elements of different lengths)?" + }, + { + "prediction": "I think this should be `ForceCleanupOnError = true` instead of `workflow.ForceCleanupOnError = true`", + "reference": "Per my understanding, this flag only impacts \"NoCleanup\" disk. If so, we may name it more clear. The reason of this ask is because I plan to add some other flag to force cleanup for other non-NoCleanup disks." + }, + { + "prediction": "I think we should keep this as `SparkStreamingWrite` since it's a subclass of `SparkBatchWrite`.", + "reference": "In my changes for `RequiresDistributionAndOrdering`, this class went away and is replaced by an inner class. I think that pattern worked well. Maybe we could do that before this one to reduce the number of changes here." + }, + { + "prediction": "I don't think this is a good idea to change the names of these attributes, as it will break compatibility with existing mods.", + "reference": "Shouldn't this be called `hp` instead of `life`?" + }, + { + "prediction": "I don't think we want to do this. This is a security risk. If you want to enable CORS, you need to set the `allowedOrigins` parameter to a comma-separated list of the origins you want to allow. If you want to allow all origins, you need to set the `allowedOrigins` parameter to `*`.", + "reference": "Because the default value of allowedOrigins is * (all origins), so it isn't necessary to set again at all." + }, + { + "prediction": "Please don't remove this empty line.", + "reference": "Undo this modification" + }, + { + "prediction": ",\"\"boolKey\"\":true,\"\"library.name\"\":\"\"CreateTestActivity\"\"}}}}]\",\n json);\n }\n \n```\nReview comment?", + "reference": "Please check my thoughts here... I changed the test to not `ToString()` attribute values. This was important to test things when `net.peer.port` was both an int or a string, but I was unsure if Zipkin supported non-string attributes." + }, + { + "prediction": "I think this should be `CameraResultType.BASE64_NO_METADATA`", + "reference": "Looks like you made changes on `CameraResultType` class, but didn't commit them. And you also have to do the changes on the types in @capacitor/core" + }, + { + "prediction": "I think we can remove the `*project` here and just use the `project` variable.", + "reference": "Can you explain the history of the bug a bit, and why this fixes it?" + }, + { + "prediction": "Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside } missing.", + "reference": "What do you think about `mentor_mail_to` or `mentor_mail_to_link` in order to match Rails' `mail_to` method, which is what this calls? I'm not sure about this suggestion..." + }, + { + "prediction": "nit: `metricPoint.Keys == null ? 0 : metricPoint.Keys.Length`", + "reference": "Looks like this will make the check in every loop. Consider extracting the null check." + }, + { + "prediction": "Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.", + "reference": "Maybe `it \"can safely be reset when there are not yet any shared example groups\"`? That's the edge case that wasn't working, right?" + }, + { + "prediction": "I think we can remove the `factory` import and just use `ssmfactory` everywhere.", + "reference": "naming: please use `asmfactory`" + }, + { + "prediction": "I'm not sure this is the right thing to do. If the output is a directory, this will break. I think we need to do something like `export OUT=\"$TMP_DIR/$OUT\" && cd \"$TMP_DIR\" && ...` but I'm not sure how to do that in a cross-platform way.", + "reference": "FYI you could use a raw string for this which removes the need for escaping the inner quotes." + }, + { + "prediction": "I think it would be better to use `pytest.mark.parametrize` instead of `@pytest.mark.parametrize` here.", + "reference": "2 blank lines here (between functions)" + }, + { + "prediction": "nit: remove the empty line", + "reference": "Nit: we try to avoid whitespace changes because they can easily cause unnecessary commit conflicts." + }, + { + "prediction": "I think this should be `substr($file_contents, $end_pos - 2, 2) === '::'`", + "reference": "As mentioned below, I'm not sure why this is only allowing refs that are tagged with `*` at the start!" + }, + { + "prediction": "I don't think we need to override equals and hashCode here, as it's just a wrapper around another repository.", + "reference": "Don't forget the {} symbols, and please use EqualsBuilder and HashcodeBuilder as possible" + }, + { + "prediction": "Why do we need a channel here? Why can't we just use `proxyBuf`?", + "reference": "Allocate buffer once outside loop." + }, + { + "prediction": "Is this test really necessary? It seems like it's testing the same thing as `network, fill_keepalive`.", + "reference": "It would be better to check that system.nodes[1]->network.port is somewhere in the target without specifying its exact position. But it is a very minor point and I have no string opinion on it just thought I'd mention it because our tests in general have too implementation detail." + }, + { + "prediction": "I don't think this is the right place for this message. I think it should be in `Access.java` where the exception is thrown.", + "reference": "Should this be in a bundle?" + }, + { + "prediction": "I don't think we need this check anymore.", + "reference": "When Activity is lost (more precisely, ExecutionContext is lost) in the HttpModule we restore the root (HttpIn) Activity. That makes this assert invalid. I tried to fix the HttpModule so that it restores the Activity that was last running, but it is impossible to retrieve do to the way ExecutionContext works. It isn't an issue to remove the assert, but it is unnerving. Any instrumentation running in IIS reliant on Activity.Current could run into trouble." + }, + { + "prediction": "I think this should be `i.net.Start()` instead of `i.net.RegisterHandlers(handlers)`", + "reference": "what was the point in moving handlers registration into a separate method?" + }, + { + "prediction": "I think this should be `if len(mplex.caches) == 0 && state.Config.Cache.RetrieveCommand != \"\" {`", + "reference": "At this point we probably want to ensure there's a store command set." + }, + { + "prediction": "`step[step.length-1] == \"'\"` should be `step[step.length-1] === \"'\"`", + "reference": "This code is way too complicated for what it does. I don't want to be a PITA, but what can you consider rewriting it in a simpler way? I'm talking about the whole `_getDerivationIndexes` function" + }, + { + "prediction": "I think it's better to throw an exception here, so that the caller can catch it and do something about it. I don't think it's a good idea to return an empty string.", + "reference": "Don't throw base exception, specify more precise type" + }, + { + "prediction": "`Inputs that to be casted` -> `Inputs that will be casted`", + "reference": "Recursive -> Recursively converted -> convert" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to work.", + "reference": "why is this object API only? I think the reason why we didn't do this before was because this code was shared with Java which doesn't have value structs." + }, + { + "prediction": "I don't think we need to change this.", + "reference": "just to confirm, so backend will deal with both old format and new format?" + }, + { + "prediction": "I think we can remove this `where T : struct, Enum` and just use `where T : Enum`", + "reference": "huh, look at that, I wasn't aware you could constrain a type by Enum" + }, + { + "prediction": "I don't think we need this one. It's the same as the one above.", + "reference": "Even though the debug parameter is effectively ignored, should this default to `false` instead of `true`?" + }, + { + "prediction": "This file is empty. Can we remove it?", + "reference": "What is the purpose of this interface? Unlike ParamDocView, it doesn't seem to be used anywhere to enable polymorphism" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `github.com/mholt/caddy/onevent/hook` package.", + "reference": "We added a library to generate a UUID for the request_id directive \"github.com/nu7hatch/gouuid\" can we uses the same one for what you want rather than add another dependency? Or if the google one is better can we remove the nu7hatch library?" + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to work.", + "reference": "Shouldn't this be `i * Interval`? You're multiplying nanos with a Duration, I'm not sure what's the result :)" + }, + { + "prediction": "I think this should be MEMPROT_READWRITE.", + "reference": "I guess it's not no-access to match Windows where guard pages are readable." + }, + { + "prediction": "Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
    Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside } missing.", + "reference": "Not a blocker, but would probably be useful to have a `scope :non_pending_approvers` on the `Proposal` model." + }, + { + "prediction": "I think this should be `GetWorkResult` or something like that. `GetWorkResponse` sounds like it's a response to a request to get work.", + "reference": "Add trailing comma" + }, + { + "prediction": "I'm not sure about this change. I don't think we want to do a graceful shutdown on SIGABRT.", + "reference": "I see someone say SIGKILL can not be caught by process. The original code here about `SIGKILL` is useless?" + }, + { + "prediction": "I think this should be `output[Setting.THEME_OLED_LIGHT] = _('OLED light');`", + "reference": "As it is a mobile only theme, please make sure the option appears only on mobile" + }, + { + "prediction": "I think it would be better to use `param.split()` instead of `param.split(\",\")`", + "reference": "Would like a docstring and type annotations here" + }, + { + "prediction": "Align the elements of a hash literal if they span more than one line.
    Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "This is an API change. Why was it made?" + }, + { + "prediction": "Can we move this to the top of the file?", + "reference": "Please move using inside namespace." + }, + { + "prediction": "I think it's better to pass `isPoS` instead of `poSEnabled`", + "reference": "shall we create some enum flags for setasmain shouldprocess and pos?" + }, + { + "prediction": "I think this should be `PuppetAgentStartupMode` instead of `PUPPET_AGENT_STARTUP_MODE`.", + "reference": "Should this `PUPPET_AGENT_STARTUP_MODE` have a corresponding yardoc change?" + }, + { + "prediction": "I don't think this is needed anymore.", + "reference": "Why not simply remove the `pytest` import now that it's not needed anymore? :wink:" + }, + { + "prediction": "This file is empty. Should it be deleted?", + "reference": "Yeah, not filled in yet." + }, + { + "prediction": "Align the elements of a multi-column form horizontally by using `

    ` instead of `
    `.", + "reference": "don't use style. Use a class instead. reducing `col-xs-12` down to 8 or 6 or whatever should do the trick" + }, + { + "prediction": "Why do we need to reload cache here?", + "reference": "should we also do `reloadCache` when database is null?" + }, + { + "prediction": "I think this should be `NOGIL gil = NOGIL();`", + "reference": "Why not just return QueryMol directly? Why require the copy?" + }, + { + "prediction": "I think this should be `os.path.join(os.path.dirname(scapy.__file__), fname)`", + "reference": "Could you add a docstring?" + }, + { + "prediction": "Layout/TrailingWhitespace: Trailing whitespace detected.", + "reference": "looks like you added newlines after blocks in a few files - I generally like newlines before/after multi-line blocks _except_ when the end the block is directly nested inside another block (eg: two `end`s next to each other) what do you think?" + }, + { + "prediction": "`hide constructor` -> `hide constructor`", + "reference": "@jlerbsc 's fix in #2918 in action - thanks! :smiling_face_with_three_hearts:" + }, + { + "prediction": "I think this should be `if zero_count and not count: raise TypeError(\"Zero_count Argument cannot exist without count!\")`", + "reference": "nitpick: Please lower-case `Zero_count` (as it's a literal argument name) and `Argument` here." + }, + { + "prediction": "I think this should be `a.Issuer == issuer` instead of `a.Name == issuer`", + "reference": "change the name of the function to match its functionality? account IsIssuing?" + }, + { + "prediction": "I think it's better to raise `ValueError('No group keys passed!')` when `len(by) == 0`.", + "reference": "for later: add docstring (can just copy paste Pandas')" + }, + { + "prediction": "I think we can remove this import.", + "reference": "nit: @sonofachamp pointed out to me that the idiomatic way is \"archermocks\" (lowercase for package names)" + }, + { + "prediction": "I don't think we need to remove the `errRouterHasNoProcedures` anymore.", + "reference": "Ugh I'm stupid, can you change this to `yarpc.InternalErrorf`?" + }, + { + "prediction": "I think we should use `table.name() + \".all_data_files\"` here as well.", + "reference": "We instantiate some metadata tables in tests so I kept the old constructor too. Won't harm if someone is using it directly too." + }, + { + "prediction": "This should be `queryOptions.perDocumentLimit != null && queryOptions.limit != null`", + "reference": "I think the better place to put this might be `lib/options/PopulateOptions.js`. That should make it easier - checking options in `populate()` can get confusing." + }, + { + "prediction": "I'm not sure about this change. I think it's better to keep the `PingTarget` method as it is, and add a new `PingTargetWithProxyPort` method. This way we don't have to change the signature of the `PingTarget` method, and we don't have to add a new parameter to the `Params` struct. What do you think?", + "reference": "Lets have simple function arguments here, because now struct `traversal.Params` started to have 2 purposes: 1. used as contract in DTO between consumer-provider 2. as function parameters for internal code calls" + }, + { + "prediction": "This file is not needed.", + "reference": "Probably best not to have an empty test...." + }, + { + "prediction": "I'm not sure this is the best way to do this. I think it would be better to have a separate partial for each testimonial. This way we can easily add more testimonials in the future without having to edit this file. Also, I think it would be better to have a separate file for each testimonial. This way we can easily add more testimonials in the future without having to edit this file. Also, I think it would be better to have a separate file for each testimonial. This way we can easily add more testimonials in the future without having to edit this file. Also, I think it would be better to have a separate file for each testimonial. This way we can easily add more testimonials in the future without having to edit this file. Also, I think it would be better to have a separate file for each testimonial. This way we can easily add more testimonials in the future without having to edit this file. Also, I think it would be better to have a separate file for each testimonial. This way we can easily add more testimonials in the future without having to edit this file. Also, I think it would be better to have a separate file for each testimonial. This way we can easily add more testimonials in the future", + "reference": "`image_tag` in the `testimonials` files?" + }, + { + "prediction": "I don't think this is correct. If this action fails, the execution is not necessarily failed.", + "reference": "I believe flow.toObject() method is throwing NPE if SLA option list (i.e. this.executionOptions.getSlaOptions()) is null or one of the value in the list (i.e. this.executionOptions.getSlaOptions()) is null. If that is the case we could fix root cause of NPE in the ExecutableFlow.toObject() method. The corresponding code to populate SLA options can be modified as follows. final List> slaOptions = Optional.ofNullable(this.executionOptions.getSlaOptions()).orElse(Collections.emptyList()).stream() .filter(Objects::nonNull) .map(slaOption -> slaOption.toObject()) .collect(Collectors.toList());" + }, + { + "prediction": "I don't think this is the right thing to do. If we don't have an icon, we shouldn't have a favicon either.", + "reference": "So I haven't tested this - but since the icon location is just directly dumped into the img _src_ attribute, won't this cause issues with Ghost blogs in a subdirectory? If I'm misunderstanding what the purpose of the default is then let me know" + }, + { + "prediction": "I think this should be `catch (std::exception &e) { std::cerr << e.what() << std::endl; result = 1; }`", + "reference": "Why swallow the exception here rather than propagate it?" + }, + { + "prediction": "I think we can remove `column_names` here. It's only used in `from_pandas` and we can just use `df.columns` there.", + "reference": "How about `column_index_names`? `column_names` sounds ambiguous." + }, + { + "prediction": "I think this should be `write.metadata.metrics.column` instead of `write.metadata.metrics.column.`", + "reference": "+1 on this. Do we want to have it as `WRITE_METRICS_MODE_COLUMN_CONF_PREFIX` to be consistent with defaults? Is there a possibility we will have `READ_METRICS_MODE_COLUMN_CONF_PREFIX`? Not sure." + }, + { + "prediction": "I think it's better to use `np.arange(1, 6)` instead of `[1, 2, 3, 4, 5]`.", + "reference": "Shall we use different inputs for `PySpark < 2.4` where `transpose` won't work with different data types." + }, + { + "prediction": "I think you can just use `from pyspark.sql import functions as F, types as T`", + "reference": "we should sort the headers like in spark: public packages, then pyspark, then internal" + }, + { + "prediction": "I don't think this is correct. If `clientTLSConfig` is not nil, then `clientTLS` should be false.", + "reference": "looks like we should drop this var from the transport options struct" + }, + { + "prediction": "I think this test should be updated to reflect the new default.", + "reference": "Ah, yeah, this is the test for the validation that I mentioned in a remark above about relaxing the validation." + }, + { + "prediction": "`inside_flags = valid_flags & (abs(anchors[:, 0::2]) < (img_w + 2 * allowed_border)) & (abs(anchors[:, 1::2]) < (img_h + 2 * allowed_border)) & (abs(anchors[:, 2::2]) < (img_w + 2 * allowed_border)) & (abs(anchors[:, 3::2]) < (img_h + 2 * allowed_border))`", + "reference": "For tensors, it is better to illustrate the shape." + }, + { + "prediction": "I think we can remove this `else` block now that we have the `else if` above it.", + "reference": "This was removed in a recent PR for the admin bar, but should have been kept. It's been restored in the other admin bar PR but I've added it here to for completeness." + }, + { + "prediction": "I think we can remove the `#if !NETCOREAPP2_1` and `#else` here and just have the `Assert.Equal(\"Microsoft.AspNetCore.Hosting.HttpRequestIn\", activity.OperationName);`", + "reference": "nit: probably swap the if condition and `if/else` and check `NETCOREAPP2_1` which looks more natural." + }, + { + "prediction": "I think we need to add a `a.mu.RUnlock()` here as well.", + "reference": "for the tag, should it be `requestor_rtt` since the other is `responder_rtt`?" + }, + { + "prediction": "I think this should be `j*2` since it's a `uint16` and not a `uint8`.", + "reference": "The one sad part of this is that is will generate a lot of overhead if you loop through a vector, since it obtains the vector every time. But with the current API there is no alternative I guess, and it is better to have the option than not." + }, + { + "prediction": "I think we can remove this import.", + "reference": "nit: there should be a newline between `types` and `go-ipfs-files`." + }, + { + "prediction": "I think this should be `var RetryAfter = &retryAfterDuration`", + "reference": "would be nice to have this as a parameter (Options), re: technical debt discussions" + }, + { + "prediction": "This import is not used.", + "reference": "complete ignorance here but is it ok to import this from `com.sun`? can it break under non-oracle JREs?" + }, + { + "prediction": "I'm not sure if this is the right place to call `OnStart`, but it seems to be the only place where we have access to both the `span` and the `span.data`.", + "reference": "Is this some way of saying that the span is going to be sampled? I'm basing this question on the condition I saw for the `OnEnd` to be called - `mustExport := s.spanContext.IsSampled() && )`. Shouldn't the condition be `s.spanContext.IsSampled()` to match the condition for calling the `OnEnd`?" + }, + { + "prediction": "This is not required as we are already updating the cvr status in line 645.", + "reference": "just calling UpdateSnapshotInfo() should be fine" + }, + { + "prediction": "I think we should keep the default value of `DefaultLogMessageRateLimit` (1000) and just set it to `0` when `DebugEnabled` is `true`.", + "reference": "Was `DefaultLogMessageRateLimit` not configurable anywhere?" + }, + { + "prediction": "I think this should be `mockDocker.EXPECT().PullImage(&pullImageOptsMatcher{\"image:latest\"}, gomock.Any()).Return( docker.ErrInactivityTimeout).Times(maximumPullRetries) // expected number of retries`", + "reference": "Please use the `assert` instead. Same below." + }, + { + "prediction": "typo \"suche\" instead of \"such as\"", + "reference": "Owww, I think I found a typo. `suche`" + }, + { + "prediction": "I'm not sure this is the right place to put this assert. I think it would be better to put it at the end of the `search` function.", + "reference": "This can happen because we could get `PhantomNodes` that are not admissible as source/target right?" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think it would be better to have a `clientSessionState` struct that embeds `qtls.ClientSessionState` and `tls.ClientSessionState`. Then you can just use `clientSessionState` instead of `qtls.ClientSessionState` and `tls.ClientSessionState` in the rest of the code.", + "reference": "Should we add a note here to file a bug if this ever happens?" + }, + { + "prediction": "I think this should be `errors.Errorf(\"benchmarks quantity overflows int64: %s\", num.String())`", + "reference": "overflow is still possible, isn't it?" + }, + { + "prediction": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", + "reference": "This seems more like a personal preference, so maybe this should be in your `~/.rspec`?" + }, + { + "prediction": "I don't think it's a good idea to use `Scapy_Exception` as a base class for `PcapTimeoutElapsed`. The latter is a subclass of `RuntimeError` and `Scapy_Exception` is a subclass of `Exception` (which is a subclass of `BaseException`). I think it would be better to use `RuntimeError` as a base class for `PcapTimeoutElapsed`.", + "reference": "To avoid a circular import between pcapdnet and automaton" + }, + { + "prediction": "This is not a workaround, this is a bug in pylint.", + "reference": "Please remove this blank line." + }, + { + "prediction": "I think this should be `s.Status.WorkloadIdentityStatus.InitWorkloadIdentityStatus()`", + "reference": "it feels that the WorkloadIdentityCondition should be added to this Status... And if you have workload identity enabled, but not working, then you can mark that condition failed, and also Mark the ready false... not entirely sure though" + }, + { + "prediction": "This should be `provokingVertexMode == VK_PROVOKING_VERTEX_MODE_LAST_VERTEX_EXT && !enabled_features.provoking_vertex_features.provokingVertexLast`", + "reference": "I think these got refactored to `LvlFindInChain` to better conform with the coding guidelines. I think MarkL left these in for backwards compatibility." + }, + { + "prediction": "nit: please remove this empty line.", + "reference": "It's fine for this PR, but in the future try to minimize unrelated changes." + }, + { + "prediction": "I think this should be `$HOME/.ansible/plugins/modules:/usr/share/ansible/plugins/modules:/etc/ansible/plugins/modules`", + "reference": "The library -> modules and filters -> filter path changes are breaking changes or?" + }, + { + "prediction": "I think we can remove this import now.", + "reference": "Can we encapsulate this check (`os.environ.get(\"TEST_TARGET\") == \"AWS_CLOUD\"`) into a small config/util function? (and also use it in `integration/conftest.py`) (I'd generally try to avoid accessing `os.environ` directly across the codebase. I'm aware that we're already doing this in a few places, but maybe we can start pulling things out - this will also help us create more systematic config/environment abstractions as we go...)" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "An `if` statement would be better here. Functions, concat and reverse are all very expensive." + }, + { + "prediction": "I think this should be `0x334394E8c891E77b1449084aaDD659920BB25247` instead of `0x334394E8c891E77b1449084aaDD659920BB25247`", + "reference": "`Log here: connect to default factory for goerli network
    `" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "nits, should add `break` to avoid redundant iterations." + }, + { + "prediction": "I think this test is not needed, as it is covered by `Eip_158_account_dont_exists_after_zero_value_transfer`", + "reference": "I think we want an exception here, there should never be a transfer to a nonexisting account." + }, + { + "prediction": "I think this should be `FINE` instead of `FINER` or `FINEST`.", + "reference": "This code is new and not tested well. While we may drop the log level before we ship 4.0, right now this is extremely helpful to users." + }, + { + "prediction": "I don't think this is a good idea to use `max(0.01, 0.1 - 0.01 * x)` as the learning rate, because the learning rate will decrease to 0.01 when `x = 9`, and then it will increase to 0.02 when `x = 10`, and then it will decrease to 0.01 when `x = 11`, and so on.", + "reference": "Can we make these asserts more strict/precise? I remember this test helped to spot the issue of inconsistent results on different platforms due to using `sort` instead of `stable_sort`." + }, + { + "prediction": "I think this should be `Pathname(executable).extname.to_sym` so it matches the keys in the `interpreters` hash.", + "reference": "I thought about adjusting for case here as well? For example `.rb,rb,.RB,.rb` would all map to ruby interpreter specified? Is that too much \"magic\"? Is there a sane workflow that someone would choose to map `.rb` to one interpreter and `.RB` to another?" + }, + { + "prediction": "I don't think we need to assert that `self` is non-NULL here, since it's not possible to call this function with a `NULL` argument.", + "reference": "In this and the one below, should we assert `self != NULL` first?" + }, + { + "prediction": "Same as above, please use `getStatusCode()` instead of `getResponse()->getStatusCode()`", + "reference": "Why this is needed?" + }, + { + "prediction": "I think this should be `return self._meta.get('user_meta', None)`", + "reference": "we already have .meta() so I don't think we want get_meta() for PackageEntry" + }, + { + "prediction": "Why do we need to pass `startTs` to `SchemaInfer`?", + "reference": "question: can we always get the startts from dagrequest?" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to be the only way to get the `propertyID` and `accountID` from the `fixtures.accountsPropertiesProfiles.properties[ 0 ]` object.", + "reference": "Nit-picking, but this can be simplified to reference `properties[ 0 ]` since that is already retrieved 2 lines above." + }, + { + "prediction": "I think this should be `@unresolved_targets.delete(target.name)`", + "reference": "This technically works because we call `get_targets` before we remove the target, so it's bound to have been resolved. But I'm not sure I would like to rely on that assumption. Should we also remove it from `@unresolved_targets` to be safe?" + }, + { + "prediction": "I think it's better to use `Optional.empty()` instead of `new Code()`.", + "reference": "So what happens if I try to get code on a EOA?" + }, + { + "prediction": "I think it would be better to move this check to `_get_values_to_unpack` and return `None` if it's not a tuple, list or named tuple.", + "reference": "Can't we return an empty list and then just compare the lengths? Thereby removing this `if`." + }, + { + "prediction": "I think this should be `passesAllRestrictions` or `passesAllRestrictionsForFile` or something like that. `passesRestrictions` is too vague.", + "reference": "Mb change it to 'doesPassRestrictions()'? Doesn't sound enough like a boolean-returning method to me." + }, + { + "prediction": "`currentIndex` and `nextIndex` don't seem to be used.", + "reference": "TODO: in fact At when used with noncurrent time should not return a next index. only latest should.." + }, + { + "prediction": "I'm not sure if this is the best way to handle this. I think it would be better to have the `Fragment` component return an array of children instead of a single `Fragment` element.", + "reference": "There are scenario's where we skip an update with a placeholder, in this case tmp returns null with render, this is not an array so we `[null]` it" + }, + { + "prediction": "I think this should be `@Unapply static Tuple2> List(List list) { return list.isEmpty() ? Tuple.of(list.head(), list.tail()) : Tuple.of(list.head(), list.tail()); }`", + "reference": "@danieldietrich, this wasn't tested so I presumed it wasn't working before either :p" + }, + { + "prediction": "This is not a typo, it's the Apache Solr extension for TYPO3 CMS.", + "reference": "Please leave two empty lines after the `use` statement" + }, + { + "prediction": "This import is not used.", + "reference": "Please move this import in the 3rd group which is for external dependencies" + }, + { + "prediction": "I think this should be `isinstance(node.get(RESERVED['file']), str) or node.get(RESERVED['file']) is None`", + "reference": "So what exactly is this fixing? The unit test is passing with or without this change." + }, + { + "prediction": "I don't think we need to make the parent dir here. The parent dir should have been created by the caller of `linkCurrentWAL`.", + "reference": "auto targetFile = fs::FileUtils::joinPath(newPath, folly::stringPrintf(\"%019ld.wal\", it->first));" + }, + { + "prediction": "I think this method should be called `ancestorSnapshotIdsBetween` or `ancestorSnapshotIdsInclusiveBetween` to make it clear that it includes the `toSnapshotId` in the result.", + "reference": "I don't see any place that checks whether the from snapshot is an ancestor of the to snapshot. That seems like a requirement for this to work correctly to me." + }, + { + "prediction": "I think this should be `$functionConfig['updateHelpText'] ?? $functionConfig['helpText'] ?? ''`", + "reference": "Other calls to getHelpText() are wrapped in an `isset()` check. Would it make sense to be consistent, and either restore that here or remove it elsewhere?" + }, + { + "prediction": "Metrics/BlockLength: Block has too many lines. [31/25]", + "reference": "Why the change? If `output_stream` is set to something non-nil, it seems odd (and potentially wrong) to overwrite it...." + }, + { + "prediction": "Use the new Ruby 1.9 hash syntax.
    Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Thinking this should have an underscore." + }, + { + "prediction": "I think this test should be updated to use the new `_get_message_state_scope` method.", + "reference": "To accommodate the change to the method being private." + }, + { + "prediction": "I think this should be `[CollectionRule(typeof(PropertiesNamesCamelCase))]` instead of `[CollectionRule(typeof(PropertiesNamesCamelCase))]`", + "reference": "Shouldn't we traverse all definitions and apply this rule over all model definitions in the doc" + }, + { + "prediction": "I think we should have a unit test for this rule.", + "reference": "Please rename this class that it ends with the suffix \"Test\" - otherwise the tests won't be executed." + }, + { + "prediction": "I think we can remove this file now that we're using `eslint-plugin-prettier`.", + "reference": "As a JS file, this should also receive our standard file header." + }, + { + "prediction": "I don't think this is correct. You need to divide by the number of nodes in the cluster, not the number of streams.", + "reference": "I take it memQuotaRatio is an \"out\" parameter at line 1810? Also, why use MIN_QUOTA in both the cases of memQuota being too low and too high? Contrast this code with RelRoot::codeGen where we set MIN_QUOTA only in the too low case." + }, + { + "prediction": "Why is this removed?", + "reference": "It looks like for newpullsubscription, we have two functions. One for pullsubscription with default, one for pullsubscription without default. If you remove setdefault here, then there is no differences between these two functions." + }, + { + "prediction": "I think this should be a `uint8` instead of a `uint32` to save space.", + "reference": "not dramatic, but why 32bits if we allow a range that is smaller than 8?" + }, + { + "prediction": "I think this should be `BeneficiaryId` instead of `BenefiterId`", + "reference": "- Use type from `service_discovery/dto/price.go` - Rename `Price` -> `Money`" + }, + { + "prediction": "I think it would be better to use `AtomicInteger::get` instead of `Function1.identity()` here.", + "reference": "one space missing at the beginning" + }, + { + "prediction": "I think this should be `PlatformVersion` instead of `Platform`", + "reference": "I worry that having `Platform` as `string` instead of `*string` would result in it getting overriden with `\"\"` if the environment manifest config doesn't specify `platform` . If it gets overridden as `\"\"`, that could be a problem for users that are not using `linux/amd64` right? If this indeed is a potential impact, could we double check in `ApplyEnv`'s unit test? Same with the `Platform` in `TaskConfig`. Sorry for not seeing this in my previous review!!!" + }, + { + "prediction": "I don't think we need to add the external API tests to this list.", + "reference": "I like the new directory `/api`, what is the thinking behind `/external`?" + }, + { + "prediction": "I think you can just do `a.signingKeys = ac.SigningKeys` here.", + "reference": "staticcheck flags this: replace with `for k := ..`" + }, + { + "prediction": "I don't think we need to wait for a response here. We just need to send the command.", + "reference": "There's already a sleep right above" + }, + { + "prediction": "I don't think this is correct. `self::` is not the same as `$this_class_name . '::'`. `self::` is relative to the current class, while `$this_class_name . '::'` is relative to the current file.", + "reference": "This feels hacky, is there a better way?" + }, + { + "prediction": "I think we can remove this try/except and just use `from ordereddict import OrderedDict`", + "reference": "Can we move this logic into the `boto.compat` module? Then it's just `from boto.compat import OrderedDict` instead. Also, this is introducing a new dependency. What about users on 2.6.x that don't have the OrderedDict module installed? We may need to fall back to an ordinary `dict` so that existing code in the wild does not break." + }, + { + "prediction": "I think this should be `Gets or sets JSON serialization settings.`", + "reference": "\"Gets the JSON serialization settings.\" would be better?" + }, + { + "prediction": "I think this should be `/file/{addr}/{path}`", + "reference": "The endpoint should be in plural `/files`." + }, + { + "prediction": "I don't think these are needed.", + "reference": "??? Why do we need to have a different API in Python? Oh, wait, I see what you did. It's to fake the namespaces. Given that I don't think the namespaces are necessary, and that less of these should be exposed anyway, I think these should go." + }, + { + "prediction": "Please remove this line.", + "reference": "I think this line is gofmt issue? @daixiang0" + }, + { + "prediction": "This is a bit of a hack, but I couldn't think of a better way to test this.", + "reference": "probably better to assert the values directly; technically you could pass this test with an implementation that always returned \"\" for the subrepo for example." + }, + { + "prediction": "Why is this changed?", + "reference": "line is 161 characters (from `lll`)" + }, + { + "prediction": "I think we can remove the `implements Serializable` from this class.", + "reference": "Are these changes needed?" + }, + { + "prediction": "I think we should keep the `HIGHEST` sensitivity modifier here, since we want to be notified of any changes to the config file.", + "reference": "It seems like reducing the sensitivity would make the test failure less likely to occur, but not fix the issue?" + }, + { + "prediction": "Why do we need this trait here ?", + "reference": "missing use statement for importing the full namespace" + }, + { + "prediction": "I think this should be `ErrInvalidAddressFormat` or something like that.", + "reference": "Generally error messages in Go shouldn't start with capital letter. I see this rule is broken in many places here. Why?" + }, + { + "prediction": "I think this test should be updated to reflect the new behavior.", + "reference": "These test checks if selection coordinates don't return negative values in that edge cases. Please revert the changes and set `autoWrapCol` and `autoWrapRow` to `false` to the Handsontable instance. This change applies to the entire Core_selection.spec.js file." + }, + { + "prediction": "I think it would be better to have `ZeroGasPrice` and `CommitAndRestoreWithZeroGasPrice` as separate flags.", + "reference": "I would prefer flag SkipGasPricingValidation" + }, + { + "prediction": "This is not thread safe. You need to lock `mutex` before accessing `blocks`.", + "reference": "could be `const &` ?" + }, + { + "prediction": "I think this should be `hideProgressOnFinish` or `hideProgressWhenFinished` or something like that. `hideProgressAfterFinish` sounds like it will hide the progress when the finish button is clicked.", + "reference": "The docs should also be updated with the new option." + }, + { + "prediction": "I think this should be `con.publish(topic, message, subject[:100])` instead of `con.publish(topic, subject[:100], message)`", + "reference": "Name is _way_ to generic for this patch to be accepted I think. Can you rename it to maybe `send_sns_notification` or something else you find suitable?" + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to work.", + "reference": "Out of the scope." + }, + { + "prediction": "This should be `thisArg = thisArg || null;`", + "reference": "I think we need an if block to check that if this API is really missing. We wouldn't want to override the browser's implementation." + }, + { + "prediction": "I think this should be `if (name && typeof name !== 'string') { editorClass = name; name = editorClass.EDITOR_TYPE; } else if (typeof name !== 'string') { editorClass = name; name = editorClass.EDITOR_TYPE; }`", + "reference": "I was wondering, things like EDITOR_TYPE, VALIDATOR_TYPE, RENDERER_TYPE are not obligatory. Therefore if the custom editor will be registered with this method, `name` will be set to `undefined`. Should we handle this scenario?" + }, + { + "prediction": "remove empty line", + "reference": "This line should not be removed, as it is not the description of the package, but a copyright header." + }, + { + "prediction": "I think this should be `Tags []string` so that we can keep track of all the tags that have been applied to the block.", + "reference": "Wouldn't it be more space efficient to make this a `byte` enum or bitfield?" + }, + { + "prediction": "I think this should be `IF NOT EXISTS` instead of `IF NOT EXISTING`", + "reference": "Flake8 doesn't like the assignment, but non-use of `e` here. I think we can just remove the try/except here for `cursor.execute(sql)`." + }, + { + "prediction": "I think this interface is not necessary. You can just use `ASTAnyTypeBodyDeclaration.class.isAssignableFrom(node.getClass())` to check if a node is a type body declaration.", + "reference": "Maybe add short example list: .... type body declarations, such as AnnotationMembers, Methods, Fields" + }, + { + "prediction": "I think these should be `TIMEOUTS_IMPLICIT`, `TIMEOUTS_PAGE_LOAD`, and `TIMEOUTS_SCRIPT`", + "reference": "These are really meant to be the keys in the capabilities, not the keys of values within the capabilities" + }, + { + "prediction": "I think this should be called `qualifiedName()` to be consistent with the rest of the API.", + "reference": "It is debatable whether we have to default this. I did this to avoid breaking custom implementations." + }, + { + "prediction": "I'm not sure about this change. I think it should be `attr_value['string'] is not None and attr_value['string'] == value` because `attr_value['string'] == value` can be `True` when `attr_value['string']` is `None`.", + "reference": "# `attr_value['string'] is not None` probably not required as `attr_value['string'] == value` check is already being done" + }, + { + "prediction": "nit: I think we can remove this line since we are not using it anymore.", + "reference": "we shouldn't need the \"addon\" rename" + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "These are covered by routing constraints." + }, + { + "prediction": "Why is this change necessary?", + "reference": "Could we use just a normal string here?" + }, + { + "prediction": "I think we can just use `typeof Symbol === 'function'` instead of `isFunction(Symbol)`.", + "reference": "`isFunction(Symbol)` triggers a `ReferenceError` if Symbol is undefined. Using `typeof Symbol === 'function'` is OK however." + }, + { + "prediction": "I don't think this is correct. If the election is not active, we should not unlock the mutex.", + "reference": "Is there an else clause (with a lock.unlock ()) missing here as well? If we think we do not need an else clause then lets add an else clause containing assert zero." + }, + { + "prediction": "I think this should be `var` instead of `[32]byte{}`", + "reference": "do we foresee `32` ever changing? (as well as its use in error checking in `clerk.go`) if \"no\" this is fine, if \"yes\" it's probably still fine" + }, + { + "prediction": "Please remove this empty line.", + "reference": "you don't need to create a enum for this, java allows you to switch on a string ;) (since java 7?)" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "This should be `modelPromises.roles = this.get('store').query('role', ...` and the promise body should just `return roles;`. This is because the `model()` hook will pause for the returned promises to be resolved before continuing so when returning `RSVP.hash` you end up with a hash containing the values returned from the promises so the controller and everything else relying on the `model` object doesn't need to worry about things being async." + }, + { + "prediction": "`nodeIsHeader` should be `node.tagName.toLowerCase() === 'header' && node.getAttribute('role') !== 'banner'`", + "reference": "This is basically a repeat of `main-is-top-level.js`. I suggest having these 3 checks point to the same evaluate file. You can change what element they test through the rule selector as well as the check.json options property. So you would have `main-is-top-level.json`, `banner-is-top-level.json` and `contentinfo-is-top-level.json` each point to `landmark-is-top-level.js`, and pass in a different `options` object which tells it what element you're trying to test." + }, + { + "prediction": "I'm not sure this is the right thing to do. If the core is null, it means we're not running in the context of a core, so we shouldn't clear the MDC.", + "reference": "Why do we need this check? setCore already handles nulls." + }, + { + "prediction": "I'm not sure if this is the right place to add `__dir__`. I think it should be added to `__getattr__` and `__getitem__` instead.", + "reference": "good catch, thanks. This is going to make the user experience much better." + }, + { + "prediction": "`Component` is not used in this file.", + "reference": "TODO: remove this unused import" + }, + { + "prediction": "I think we can remove this test now.", + "reference": "Hmm leaking the library name out in the Workload API doesn't seem great. Do we want to catch these errors and return a canned \"could not parse token\" or something instead?" + }, + { + "prediction": "`self.elif '-f build.gradle', 'gradle check', fold: 'test', retry: true`", + "reference": "I think `-f gradlew` is better for code unity" + }, + { + "prediction": "I think this should be `source.iceberg.reader.fetch-record-batch-size` instead of `source.iceberg.reader.fetch-record-batch-size`.", + "reference": "Is there precedent for this config key? What other keys are similar? The others in this file start with `table.exec.iceberg`. Is there a reason for not continuing with that convention?" + }, + { + "prediction": "This file should be reverted.", + "reference": "Can we avoid no-change changes being committed - they make it harder to distinguish actual changes from code editor changes" + }, + { + "prediction": "I think this should be \"AWS Identity and Access Management (IAM) server certificate.\"", + "reference": "AWS Identity and Access Management (IAM)" + }, + { + "prediction": "I think it's better to pass `di.IdentitySelector` to `serviceCommand` as a field, instead of using `di.IdentitySelector` as a global variable.", + "reference": "You dont use this dependency anymore" + }, + { + "prediction": "I'm not sure this is the right thing to do. We don't want to enable FTS5 by default, and we don't want to enable JSON1 by default.", + "reference": "Here is the test that checks that the sqlcipher in use was compiled with the right flags" + }, + { + "prediction": "I don't think this is correct. If `mdmLoginServers` is `null` here, it means that `runtimeConfig.getString(ConfigKey.AppServiceHosts)` returned an empty string.", + "reference": "Turns out that if the hosts are not in an `array`, an `Exception` is not thrown anymore :-( It simply returns `null`. So, we need to attempt to parse a `string` outside the `catch` block for it to work." + }, + { + "prediction": "I think this test should be removed.", + "reference": "this test only covers the happy path. what about no acceptable rest template found?" + }, + { + "prediction": "I think this should be `finer` as well.", + "reference": "Since this is in a test, I imagine that the choice of `info` level was deliberate." + }, + { + "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to have a test that verifies that the `core` package is not used in the `langserver` package. I think we can do this by running `go list -f '{{.Imports}}' ./langserver | grep core` and making sure that the output is empty.", + "reference": "this should probably be named somewhere if you want to reuse it." + }, + { + "prediction": "I think this should be `BOUND_SERVICE_ACCOUNT_SIGNING_KEY` to be consistent with the other env vars.", + "reference": "needs a rename to not include AWS" + }, + { + "prediction": "Please remove empty line.", + "reference": "Isn't sigma have `double` type?" + }, + { + "prediction": "Is this line necessary?", + "reference": "May be better use nano::keypair that generates ramdom value?" + }, + { + "prediction": "I'm not sure this is the right thing to do. If the user has set `ignoreUndefined` to `true` in their connection options, then we should respect that.", + "reference": "I think the more complete solution will save off a `ignoreUndefined` in the base class for the bulk operation (with a default of `false`), and use that for calculations. Was there a reason you didn't want to support the option from the operation level?" + }, + { + "prediction": "I think this should be `logger.e(this, \"runSync\", e);`", + "reference": "The catch (Exception e) block that follows does an updateSync, which will get a SmartStore instance (while logging out is taking place) - and then terrible things will happen - a database gets created for the outgoing user that won't be openable by the returning user causing the app to crash at logout. This is a somewhat superficial fix - SmartStore should not return an instance for an outgoing user." + }, + { + "prediction": "I think we can remove the `AnyTimes()` call here, since we're not expecting any calls to `GetConnection` in this test.", + "reference": "huh does this work without a `Return`?" + }, + { + "prediction": "Style/RescueStandardError: Avoid rescuing the standard exception class.", + "reference": "Don't think we want this line, right? (Plus \"failing\" is spelled wrong)." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in `FeedItemMenuHandler#onPrepareOptionsMenu` and check if the selected item is a local feed.", + "reference": "I think it would be more clear to have local-feed-hiding all in one place (bottom of this method?). Further up the method, there already is some code that hides the website icon, for example." + }, + { + "prediction": "I think this should be removed as well.", + "reference": "Why remove this one? It doesn't work yet, but we'll add it sooner or later." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should keep the `docstore:\"i\"` tags so that we don't have to change all the tests.", + "reference": "Why did you remove the struct tags?" + }, + { + "prediction": "I think this should be `report_info = get_bza_report_info(self.engine, self.log)`", + "reference": "Let's be neutral with tag names. Let's just have \"ReportURL\"" + }, + { + "prediction": "I think this should be `time.Date(2020, 3, 31, 5, 1, 26, 1234, time.UTC)`", + "reference": "Use an explicit time to ensure conversion is not copy-paste and wrong." + }, + { + "prediction": "I'm not sure this is the right thing to do. If the reply is an error, we want to show the error message. If the reply is an account, we want to show the account. If the reply is something else, we want to show the whole thing.", + "reference": "The logic now is to look for ``. This `` output is also not consistent with the other two functions you mentioned. Do the other two RPCs not report an error?" + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.", + "reference": "Use nested module/class definitions instead of compact style." + }, + { + "prediction": "I think this should be `t.Logf(\"Init KBFSOps\")` so that it doesn't show up in the test output if the test passes.", + "reference": "Do you think we need to keep this in, or is it just leftover personal debugging? Seems like it wouldn't be too useful most of the time, but I don't care too much if you want to keep it." + }, + { + "prediction": "`config.showPlayers() | config.showNpcs() | config.FreezeTimers() | config.Veng()` -> `config.showPlayers() || config.showNpcs() || config.FreezeTimers() || config.Veng()`", + "reference": "showNPCs is not needed" + }, + { + "prediction": "I think this should be `parameter %s already exists in region %s`", + "reference": "Docstring for public function pls" + }, + { + "prediction": "I think this should be `expectedFilteredErr2 := \"unable to parse \\\"[ { \\\\\\\"op\\\\\\\": \\\\\\\"replace\\\\\\\", \\\\\\\"path\\\\\\\": \\\\\\\"/data/foo\\\\\\\", \\\\\\\"value\\\\\\\": \\\\\\\"baz-json\\\\\\\" ]\\\": yaml: did not find expected ',' or '}'\"`", + "reference": "This should use `t.Errorf` instead. You want the second part of the test to run even when the first part fails." + }, + { + "prediction": "I think this should be `ctx.http3 != NULL && ctx.protocol_selector.ratio.http3 > 0`", + "reference": "Should this if block better be changed to `#if H2O_USE_LIBUV \\n #else ... #endif`? The reason I wonder is because that's the way the QUIC context is being initilaized at the beginning of this function. Though I would not expect practical difference between the two approaches, because ATM the only case where we create QUIC connections is when the protocol selector is set to non-zero, and because when it is set to non-zero `h2o_quiy_close_all_connections` becomes a no-op." + }, + { + "prediction": "I'm not sure if this is the right thing to do. I think we should always call `setState` so that the component re-renders. If we don't call `setState` then the component won't re-render and the new state won't be reflected in the UI.", + "reference": "`Object.is` is an ES6 feature of JS so I don't think we can use it here (or we have to change our browser support matrix or specify that an Object.is polyfill is pre-req of `preact/hooks`). Should we just do an `===` check in `preact/hooks` and provide a `Object.is` polyfill and version of `useReducer` in `preact/compat`?" + }, + { + "prediction": "I think this should be `typeof options.roles === 'string' || Array.isArray(options.roles) ? [options.roles] : [];`", + "reference": "This was a bug I picked up by using the TS interface as a guide, this seems like it was / is the intention, also is a bug in master (needs port)" + }, + { + "prediction": "I think this should be `COLLOCATED_WITH` instead of `COLOCATED_WITH` to be consistent with `WITH_COLLECTION` above.", + "reference": "It would be helpful to explicit here what this really means and assumes." + }, + { + "prediction": "I think it's better to put this variable in the `config` package, so that it can be used by other packages.", + "reference": "`ExpectedBalances` is a global variable (from `gochecknoglobals`)" + }, + { + "prediction": "Line is too long. [82/80]", + "reference": "This is another place where I'd feel more comfortable with declaring the class private. We can always make it public in the future if someone makes a case for that, but I prefer to err on the side of privateness for things like this that 99% of RSpec users won't have a reason to use." + }, + { + "prediction": "I don't think we need to pass in the issuer account here. We can just set it in the `createClient` function.", + "reference": "Feels like this should be left as is and add a new createClientWithIssuers or something like that. Avoid all the \"\"" + }, + { + "prediction": "I think this should be `if (authCallback != null) { authCallback.receivedErrorResponse(error); } else { SalesforceSDKLogger.e(TAG, \"Error received from IDP app: \" + error); }`", + "reference": "Minor unrelated bug in the IDP flow where the error wasn't getting displayed as a `Toast`." + }, + { + "prediction": "This should be `require('../../lib/error').mongoErrorContextSymbol`", + "reference": "I thought we got rid of this thing?" + }, + { + "prediction": "I don't think we need to remove the `selected_text` field. It's used in the frontend to highlight the selected text in the snippet.", + "reference": "Please convert int params as well." + }, + { + "prediction": "I think this should be `{0}:{1} {2} {3}: {4}`", + "reference": "Fixed bug in implementation. Now I can run the validator from the VS Tools menu, double-click on an output line, and navigate to the site of the issue." + }, + { + "prediction": "I think this should be `DD_TRACE_HTTP_SERVER_ERROR_STATUSES` and `DD_TRACE_HTTP_CLIENT_ERROR_STATUSES`", + "reference": "Can we rename this field to `HttpServerErrorCodes` or `HttpServerErrorStatuses`? It will contain a list of status _codes_, not a list of _errors_. (Personally I prefer \"codes\" over \"statuses\", but we can't change `DD_HTTP_SERVER_ERROR_CODES`.)" + }, + { + "prediction": "I think this should be `strcasecmp(tmp, \"true\") == 0`", + "reference": "would you please use: flb_utils_bool(...) here ?, that function wraps the on/off/true/false stuff." + }, + { + "prediction": "I think we can remove the `null` here, as it's the default value.", + "reference": "`invocationInfoTokensToRedact: null` (I really like the convention of using a named parameter whenever the value doesn't communicate the meaning, such as for literal values.)" + }, + { + "prediction": "Why do we need `async_test`? Why not just use `test`?", + "reference": "maybe renamed to `async_simple_test` if we consider supporting aug test later on?" + }, + { + "prediction": "Align the parameters of a method call if they span more than one line.
    Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "So where is default_attributes now? Is it used anywhere else still? If not, can it be removed along with any tests of it?" + }, + { + "prediction": "I think we should use `DateTimeOffset` instead of `DateTime` here.", + "reference": "We could move this to the base class and remove all these changes. What do you think?" + }, + { + "prediction": "I'm not sure if this is the best way to test this, but it seems to work.", + "reference": "While we're doing some translation work, could you extract this button text and the other static text from the view?" + }, + { + "prediction": "I don't think this is the right place to replace the tokens. The tokens should be replaced before the headers are parsed. Also, I don't think this is the right place to replace the tokens. The tokens should be replaced before the headers are parsed. Also, I don't think this is the right place to replace the tokens. The tokens should be replaced before the headers are parsed. Also, I don't think this is the right place to replace the tokens. The tokens should be replaced before the headers are parsed. Also, I don't think this is the right place to replace the tokens. The tokens should be replaced before the headers are parsed. Also, I don't think this is the right place to replace the tokens. The tokens should be replaced before the headers are parsed. Also, I don't think this is the right place to replace the tokens. The tokens should be replaced before the headers are parsed. Also, I don't think this is the right place to replace the tokens. The tokens should be replaced before the headers are parsed. Also, I don't think this is the right place to replace the tokens. The tokens should be replaced before the headers are parsed. Also, I don't think this is the right place to replace the tokens", + "reference": "Nit: Please fix indentation (note: Azkaban uses 2 spaces and not tabs)." + }, + { + "prediction": "I think this test should be updated to check that the schemaVersion is still 0.", + "reference": "This change is necessary because the schema version is ignored unless a schema is specified. I think that has always been the intent." + }, + { + "prediction": "(style) '1803' may be misspelled - perhaps '1803' ?", + "reference": "The api/docs/release.dox changelog message is missing: maybe you planned to add it once NtAllocateVirtualMemoryEx and NtMapViewOfSectionEx support is in? I would say, add it here in the same diff that raises max_supported_os_version." + }, + { + "prediction": "I think this should be `node.hasAttribute(aria) === 'false'`", + "reference": "Just do: `return node.hasAttribute('aria-hidden')`" + }, + { + "prediction": "Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.", + "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." + }, + { + "prediction": "I'm not sure this is the right way to do this. I think we should just use `Process.GetCurrentProcess().ProcessName` and `Process.GetCurrentProcess().MachineName` and `Process.GetCurrentProcess().Id`", + "reference": "Do we need `_processDataPoisoned`? Can the name or the id of the current process ever change? Or the machine name?" + }, + { + "prediction": "I think this should be done after `setupTunnelAndRunAgent` so that we don't notify systemd before the tunnel is established.", + "reference": "Did it not work out to wait until after containerd and kubelet are started?" + }, + { + "prediction": "I think this should be `ITEM_PARSE_INCREASEMANAGET`", + "reference": "variable names suggestions from me: - damageboost, ITEM_PARSE_DAMAGEBOOST, \"damage boost +x%\" - healingboost, ITEM_PARSE_HEALINGBOOST, \"healing power +y%\" - managainboost, ITEM_PARSE_MANAGAINBOOST, \"mana restoration +z%\" alternatively the other names can stay, because \"increase\" convention isn't that bad, just change mana values to: - \"increasemanarestored\", ITEM_PARSE_INCREASEMANARESTORED, \"mana restoration +z%\"" + }, + { + "prediction": "I think this should be a `tinyint(1)` instead of a `bool`.", + "reference": "Why can't this be determined by 'PARTIAL_SUCCESS' in the `status` field?" + }, + { + "prediction": "I think we should throw an exception if the id is not numeric.", + "reference": "Does it make sense to generate a Exception here? Maybe yes, because it wouldn't make sense to generate a path without the id of the media right?" + }, + { + "prediction": "This is not thread safe.", + "reference": "This should be made private." + }, + { + "prediction": "I'm not sure if this is the right place to set the baseSVIDPath. I think it should be set in the `NewAgent` function.", + "reference": "perhaps this is better modeled as a pkg-level var?" + }, + { + "prediction": "I think we can use the same MAX_NUM_LEN for both hive and spark.", + "reference": "I don't think there is a maximum scale, neither for Hive nor for Trafodion. The only condition right now is that the scale can't exceed the precision. Example of a valid scale: DECIMAL(18,18). The maximum of 6 digits applies only to TIMESTAMP columns, where we don't support resolution below microseconds." + }, + { + "prediction": "I'm not sure if this is the right place to put these.", + "reference": "`ctx` is unused in UpdateProjectStaticUser" + }, + { + "prediction": "I think this should be `https://www.googleapis.com/discovery/v1/apis/{apiName}/{apiVersion}/rest`", + "reference": "Why is this not the default, and why only for JS?" + }, + { + "prediction": "Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
    Style/TrailingCommaInArrayLiteral: Avoid comma after the last item of an array.", + "reference": "A repository has many badges so we should also add type column in scope." + }, + { + "prediction": "I think this should be `result.CodeFlows[0].Locations.ToArray().Should().Equal(new[]`", + "reference": "Now a hash set, so can't index into it." + }, + { + "prediction": "I don't think this is correct. `PSModulePath` is only set when running in PowerShell, but it's not set when running in PowerShell Core.", + "reference": "@jpogran Does this seem like a reasonable way to know if we're in powershell vs. CMD or *sh?" + }, + { + "prediction": "I think we should use `String#startsWith(String, int)` instead of `String#toLowerCase()`.", + "reference": "1.toLowerCase(Locale.US)? 2.where is accept bug fix?" + }, + { + "prediction": "I think this test should be updated to check that the `KeyError` is raised with the expected message.", + "reference": "We should still be providing something to the user in the case of a `KeyError` instead of a stack trace!?" + }, + { + "prediction": "Why do we need to get the nonce here?", + "reference": "check Lukasz's fix with NonceReserving - is that not better?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the best we can do for now.", + "reference": "Would you explain why here please? E.g. from the PR description > the renderer expects to be able to use the secondary color as the fill for a shadow." + }, + { + "prediction": "Why do we need to lock here?", + "reference": "Lock needs to go to `RecoverFromDb` instead. Here it may cause deadlocks. My convention was that un-exported functions do not lock, only exported ones (with name starting with a capital letter)" + }, + { + "prediction": "I don't think you need to override this method. The default implementation should be enough.", + "reference": "German keyboard would also be used in Austria and Switzerland, so this should have included `.at` and `.ch`." + }, + { + "prediction": "I'm not sure why this was removed, but I think it should be added back.", + "reference": "since this makes the indexer thing really only used for a single table, now, you can put in a TODO for me to cleanup and simplify this" + }, + { + "prediction": "I think this should be `NSCD_SOCKET_VOLUME_NAME` and `NSCD_SOCKET_VOLUME_MOUNT_PATH`", + "reference": "Should we have this path passed from the Azkaban properties? If this is the standard path for nscd even outside LinkedIn, then we can keep it." + }, + { + "prediction": "I'm not sure this is the right way to do this. I think we should have a flag in the stream config that says \"this is an MQTT stream\" or something like that. Then we don't have to rely on the name of the stream.", + "reference": "Could be a non-public field. `allowNoSubject`" + }, + { + "prediction": "I think this is the only place where `ForceRerun` and `ForceRebuild` are used, so I think we can remove the `ForceRebuild` flag and just use `ForceRerun` for both.", + "reference": "Don't think this is quite right - think the build one also needs an `IsOriginalTarget` (c.f. code in `src/build`)" + }, + { + "prediction": "I think this should be `@param array $targetEntityConfig` instead of `@param array $targetEntityConfig`", + "reference": "what about adding typehints instead? I don't think we need to add docblocks for every private methods." + }, + { + "prediction": "can we make this configurable?", + "reference": "Is it fine to pass the \"-o compression=on\" in the middle instead of at the end ?" + }, + { + "prediction": "I'm not sure this is the best way to do this, but it's the only way I could get it to work.", + "reference": "Probably make them all keyword arguments." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should only clear the backdrop when we're in a mobile view, and not when we're in a desktop view.", + "reference": "Why not just check the backdrop setting here as well for the time being? We can combine the code later but at least then it would be configurable if people like the backgrounds." + }, + { + "prediction": "I think this should be an error, not a warning.", + "reference": "why are we turning this one into a Warning?" + }, + { + "prediction": "`sourceIDs.size()` is already an `int`, so no need to convert it to a `String`.", + "reference": "Wouldn't it be better to use double quotes for the opening parenthesis ?" + }, + { + "prediction": "This should be `static_cast(player->blessings.to_ulong())`", + "reference": "Remove the cast" + }, + { + "prediction": "This should be 2016-2019.", + "reference": "What criteria do we use to bump the copyright years? An update to the module?" + }, + { + "prediction": "Why do we need to add `gt_semantic_seg` to `results`?", + "reference": "should we rm line 269?" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "Perhaps the code at `source/core.py:564: postNvdaStartup.notify()` should be queued instead? If we are saying the loop must have started before NVDA's startup is complete, then the `postNvdaStartup` action is incorrect." + }, + { + "prediction": "Use the new Ruby 1.9 hash syntax.
    Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Needed this for testing locally with mail view but not used for any tests. Might be nice to have some seed scripts at some point." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the transport layer.", + "reference": "wait, if we only do this for successful status codes won't we miss a whole slew of responses? We should be checking this for all codes right?" + }, + { + "prediction": "nit: I think we can remove the `new String[0]` here since it's the default value.", + "reference": "Adding in the service yaml `library.yaml` here." + }, + { + "prediction": "I think this should be `*r = *r.WithContext(...)`, not `*r = r.WithContext(...)`.", + "reference": "Why is this dereference needed?" + }, + { + "prediction": "I don't think we need to allow repo directories to be removed via `RemoveDir`. I think we should just remove the `RemoveDir` method from `tlfNode` and `repoNode`.", + "reference": "Might want to add that this only happens if you have write permissions to the folder." + }, + { + "prediction": "I think this should be `EnforceShouldRetryCheck *bool` instead of `EnforceShouldRetryCheck bool`.", + "reference": "Adding a small blurb about why someone would want to enable this flag would help clarify what it is for. Such as something about when providing a custom retry handler and how`ShouldRetry` will be handled with and without the flag enabled." + }, + { + "prediction": "Why is this change necessary?", + "reference": "assume the user will be able to register for a custom service name in future?" + }, + { + "prediction": "Remove extra blank line.", + "reference": "The extra two empty lines seem unnecessary. Please review your diffs more carefully." + }, + { + "prediction": "I think this should be `OracleAPI` instead of `OracleUSD`", + "reference": "What the reason to embed the Oracle?" + }, + { + "prediction": "Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Shouldn't this happen automatically with High Voltage?" + }, + { + "prediction": "I think this should be `context.getNamer().localVarReference(Name.from(initValue.getValue()));`", + "reference": "This is changed because we need `projectId` to be printed as `$projectId` in PHP." + }, + { + "prediction": "Align the elements of a hash literal if they span more than one line.
    Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "This title change seems more accurate to me however not sure if this will confuse users." + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "Here (and on line 158 as well), would it be more efficient to use the String end_with() method? Not tested" + }, + { + "prediction": "`change_log_capacity` -> `set_log_capacity`", + "reference": "Why are you creating a new (second) `RAMHandler` here? Is this just an oversight from deleting the previous code?" + }, + { + "prediction": "`resp_.set_code(cpp2::ErrorCode::E_EXISTED);` -> `resp_.set_code(cpp2::ErrorCode::SUCCEEDED);`", + "reference": "Move the line 27 to line 31 is better?" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but it seems like the right place to me.", + "reference": "In slack I mentioned we should only do this if the update is from some other device, to make sure our own updates don't cause issues. Maybe the revision check above is good enough to prevent this, but I just want to make sure you thought about it." + }, + { + "prediction": "Metrics/LineLength: Line is too long. [81/80]", + "reference": "I would instead explain that random is the default, but you can switch back to defined, or another ordering scheme." + }, + { + "prediction": "`elHeight <= 1` is not necessary. `elHeight === 0` is enough.", + "reference": "Is there a reason you left this at 0?" + }, + { + "prediction": "I don't think we need to do this. RememberMeServices is an interface, so we can't assume it's an AbstractRememberMeServices.", + "reference": "The value of `key` will never be `null` at this point, because `getKey()` will generate a value if it is `null`." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if there's a better way to do this.", + "reference": "NIT: You should first check if AdoNetExcludedTypes.Count is greater than 0 before calling Contains (fast-path)" + }, + { + "prediction": "Please remove this line.", + "reference": "should rearrange so as to follow import ordering." + }, + { + "prediction": "Why is this change needed?", + "reference": "what is the use case for create workflow with completed state?" + }, + { + "prediction": "This file is not needed.", + "reference": "Probably best not to have an empty test...." + }, + { + "prediction": "I think this should be `#include `", + "reference": "Missing the license" + }, + { + "prediction": "I think we should keep the cleanup timer here, even if we don't do the cleanup. This way, we don't have to worry about whether the cleanup is enabled or not, and we don't have to worry about whether the cleanup is successful or not.", + "reference": "Looks like this was previously guarded by `EnableCleanupReplicationTask` flag. Now looks like this is always needed. Just want to confirm the intention is if `GlobalNamespace` is enabled then we want run cleanupReplicationTasks in all cases?" + }, + { + "prediction": "I think this should be `#include `", + "reference": "Potentially it'll be good to remove all of them excluding \"tbb/tbb.h\" But let's do it next time" + }, + { + "prediction": "I think this should be `round(1./((high-low)/(len(vals)-1)), sys.float_info.dig - 1)`", + "reference": "I would just mention which tolerance - namely as reported by ``sys.float_info``" + }, + { + "prediction": "Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside } missing.", + "reference": ":+1: Ideally this'll become something you could pass in to the config" + }, + { + "prediction": "I think we can remove the executor_.get() here, since it's already in the .via(executor_.get()) above.", + "reference": "Should using `thenValue` to replace `then` ?" + }, + { + "prediction": "I think this should be `if (Tracer.Instance.Settings.IsIntegrationEnabled(IntegrationName))`", + "reference": "This follows the convention of each callback starting with the `IsIntegrationEnabled` check." + }, + { + "prediction": "I think we should have a single `bool isDelta` and `bool isMonotonic` instead of `isDeltaValue` and `isMonotonicValue`.", + "reference": "this is not required to be part of this PR right? (With UpDownCounter being absent in .NET, we can make this hardcoded for now, i think)" + }, + { + "prediction": "Should this be `IConnectionHandler` where `TContext` is `IConnectionContext`?", + "reference": "Add the PipeFactory here" + }, + { + "prediction": "why remove this?", + "reference": "please add `var _ impltypes.ChaosImpl = (*Delegate)(nil)`" + }, + { + "prediction": "I think this should be called `skipCleanup` or something like that. `cleanExpiredFiles` sounds like it's going to clean up the expired files, which is not what it's doing.", + "reference": "nit: is this added deliberately?" + }, + { + "prediction": "Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Given the number of tests which need this (I think I counted seven) should we maybe just install this one globally? Is there even a place to do that? Something in `test_helper` maybe?" + }, + { + "prediction": "I think this should be `maybePromise && typeof maybePromise.then === 'function' && typeof maybePromise.catch === 'function'`", + "reference": "we don't use this anymore, so we can delete it." + }, + { + "prediction": "I think this should be `fmt.Fprintln(os.Stderr, \"algoh telemetry configured from file:\", telemetryConfig.FilePath)`", + "reference": "nit: change to \"Telemetry configuration loaded from '%s'\"" + }, + { + "prediction": "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "reference": "Why did this value change?" + }, + { + "prediction": "I think this should be `knative.dev/pkg/apis/duck/v1alpha1`", + "reference": "maybe `duckpubsubv1alpha1` ?" + }, + { + "prediction": "I think this should be `manifest['name']` instead of `manifest['version']`", + "reference": "The id is not mandatory for web extensions. Could you update this to support a web extension without an id?" + }, + { + "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to have a test that verifies that we are using the correct service name and method name.", + "reference": "I actually prefer them to be defined here. Client who calls `lib` should define the args, not `lib` itself." + }, + { + "prediction": "I think this should be `defer epollConsole.Close()`", + "reference": "I think this should've been done with the `defer`-named-return trick. I'll submit a PR for it." + }, + { + "prediction": "I think this should be moved to the `if (config.websocket_config.enabled)` block below.", + "reference": "The bind address should be configurable." + }, + { + "prediction": "I think we should throw an `UnsupportedOperationException` here instead of doing nothing.", + "reference": "Maybe the empty `delete()` should be implemented as default in the interface." + }, + { + "prediction": "I think this should be `CMAKE_SOURCE_DIR \"/caffe/test/test_data/sample_data.h5\"`", + "reference": "How to ensure CMAKE_SOURCE_DIR is set correctly?" + }, + { + "prediction": "Why do we need to do this?", + "reference": "safer to make a copy of incoming *big.Int" + }, + { + "prediction": "Should this be 10 * time.Second?", + "reference": "how did we choose this value? does this hold good for Windows too?" + }, + { + "prediction": "I think this should be `// +build !criu` instead of `// +build nocriu`", + "reference": "To follow the other build tags, maybe we can call it `criu`?" + }, + { + "prediction": "Should this be `connect_timeout: 30`?", + "reference": "Should we load this from the config file too?" + }, + { + "prediction": "I don't think we need to validate this in the webhook. If the user wants to do this, they should be able to do it.", + "reference": "Can you file an issue for this?" + }, + { + "prediction": "I think this should be `this[kIsMaster] == null || this[kIsMaster] === false`", + "reference": "@nbbeeken what were the cases where `!!this[kIsMaster]` was yielding an incorrect value? we should try to cover them in the tests" + }, + { + "prediction": "I think this should be `Bolt::Util.symbolize_top_level_keys(inventory['config']['transports'])`", + "reference": "This whole function feels messy. I don't have a better idea at the moment though." + }, + { + "prediction": "I don't think this is correct. `bitmask` is a `Long` and `intValue()` returns an `int`, so this will throw a `ClassCastException` when `bitmask` is `null`.", + "reference": "should use Number instead of Long" + }, + { + "prediction": "I think this should be `influxdb.Provider` instead of `influxdb.UnimplementedProvider`.", + "reference": "Can you rename this and the file `InfluxDBProvider` and `influxdb_provider.go` respectively?" + }, + { + "prediction": "`len !== 0` is equivalent to `len`", + "reference": "This is the real culprit, as now vlen will always be a Number (and known to the compiler as such). You could probably go one step further and avoid the ToBoolean on `vchildren` as well by writing something like `vlen = (vchildren !== undefined) ? vchildren.length : 0` if that matches the contract." + }, + { + "prediction": "I think we should rename this to `noDataString`", + "reference": "missing space before `TextView`" + }, + { + "prediction": "I think this should be `ITEM_ATTRIBUTE_OPENCONTAINER` instead of `ATTR_OPENCONTAINER`", + "reference": "so this attribute is used as u8 in code, but saves as int32? Why?" + }, + { + "prediction": "I think this should be `adaptiveScalarEncoder` to match the schema.", + "reference": "can RDSE be added to the list? It has its capnp files." + }, + { + "prediction": "`client.Reader` doesn't have a `List` method, so this won't compile.", + "reference": "These functions only ever read from the API and should always be reading from a cache, so I have made that explicit by expecting a Reader here and supplying a `cache.Cache` as the client." + }, + { + "prediction": "I don't think we need to do anything special here.", + "reference": "No, we can't skip any of the mangling after the suspend point: this should follow the other mangling and undo its push." + }, + { + "prediction": "This import is not needed.", + "reference": "this is generated code.. these changes will need to be made in the code generator to have them stick." + }, + { + "prediction": "I think we can remove this line now.", + "reference": "Should we abstract this into a reusable utility so it doesn't have to get repeated in every test file needing Shadow DOM support?" + }, + { + "prediction": "I think we can remove this line.", + "reference": "Maybe we rename this to `command_monitoring.test.js` to match the directory name change? Or would you rather do that as part of the greater test cleanup? I'm fine either way." + }, + { + "prediction": "I don't think this is correct. `$options` is a string, but it's not the same as `$regex`. `$regex` is a string, but it's not the same as `$options`. `$options` and `$regex` can be used together in a `$regex` query.", + "reference": "Why is this change necessary? `handleSingle()` will cast it to a string, no?" + }, + { + "prediction": "I think this should be `default String name() { return this.getClass().getSimpleName() + \"(\" + hashCode() + \")\"; }`", + "reference": "This newly added method should be well defined, should it return `TableIdentifier` or just `String`?" + }, + { + "prediction": "I think it is better to use `ProductMultimediaRelationshipStrategy::ONE_MESSAGE` and `ProductMultimediaRelationshipStrategy::MULTIPLE_MESSAGE` instead of `self::ONE_MESSAGE` and `self::MULTIPLE_MESSAGE`", + "reference": "have a relation with a product" + }, + { + "prediction": "I think we can remove the `Expect(err).NotTo(HaveOccurred())` here as well. If the pod doesn't exist, the error will be `NotFound`.", + "reference": "I guess that there is still a window here, because the GC could happen between the `PodExist` and `Delete` calls. Would it be better instead to check `err` and allow it if it says \"pod has already been deleted\"?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to work.", + "reference": "SQLAlchemy's session management does magic to make sure that if the rollback fails you still get the original exception that caused the rollback. Also it looks nicer." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the right thing to do. We don't need to convert the action to a transfer or vote, we just need to get the nonce from the action.", + "reference": "This switch statement can be removed. Just return q.items[act.Nonce] != nil" + }, + { + "prediction": "`n == n.getParent().getChild(1)` would be enough.", + "reference": "I think `==` for nodes is more readable than equals. An equals calls looks like it could be recursing, because intuitively two nodes are equal if their subtree are the equal. But everywhere you replaced, we don't want to test whether the subtrees are structurally equal, we want to know whether they're the same. Only `==` captures this intent, using equals obscures this. Not to mention that equals may NPE and is in that sense less ergonomic. I think we should enhance the rule with a list of types for which `==` is correct. Edit: in the meantime i think we could suppress those new violations..." + }, + { + "prediction": "I think this should be `--filter` to be consistent with the other options.", + "reference": "What's the scenario for passing multiple filters?" + }, + { + "prediction": "I think we can remove the `auto log = std::get<3>(logEntry);` line and just use `std::get<3>(iter->logEntry())` below.", + "reference": "move to after check log.empty()" + }, + { + "prediction": "This import is not used in this file.", + "reference": "This line needs to be removed" + }, + { + "prediction": "I think this should be `com.google.cloud.cloudbuild.build.v1.statusChanged` instead of `google.cloud.cloudbuild.build.v1.statusChanged`", + "reference": "Can we delete such const like `CloudBuildSourceEvent` and `CloudBuildSourceBuildId` since all those are contained under schemas/v1?" + }, + { + "prediction": "This should be `github.com/openshift/hive/pkg/apis/hive/v1alpha1`", + "reference": "This is unused." + }, + { + "prediction": "I think it would be better to use `new List { new TraceContextFormat(), new BaggageFormat() }` instead of `new System.Collections.Generic.List { new TraceContextFormat(), new BaggageFormat() }`", + "reference": "Any reason not to put `using System.Collections.Generic` (guess there shouldn't be naming conflicts)?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get the player card to work.", + "reference": "Could the name of this controller just be shortened to `TwitterCardsController`? Is the `Player` there adding information?" + }, + { + "prediction": "I think this should be `if uh.Dynamic && uh.Fails >= u.MaxFails && u.MaxFails != 0 {`", + "reference": "Backends with hostnames that depend on the request are always up?" + }, + { + "prediction": "This import is not used in this file.", + "reference": "I'd rather catch those to `utils.py` and raise a simple ValueError from them. From the resource point of view, these are details of implementation" + }, + { + "prediction": "I don't think we need to remove this, it's still used in `lib/travis/build/script/python.rb` and `lib/travis/build/script/ruby.rb`.", + "reference": "make this 1.0 ? I don't think all that many people do `language: julia` without any `julia:` specifiers, but may as well keep that possible?" + }, + { + "prediction": "I think this should be `AZURE_KEYVAULT_AUTH_VIA_AZURECLI` to be consistent with the other env vars.", + "reference": "nit: `AZURE_KEYVAULT_AUTH_VIA_CLI` is defined by us, so it might be helpful to differentiate it from azure's env names. Maybe starts with `GOCDK`." + }, + { + "prediction": "I think it's better to pass `session.Storage` to `NewValidator` instead of `*session.Storage`.", + "reference": "Depend on interfaces not on structures" + }, + { + "prediction": "I think we can remove the `if (gStorageServer)` check here, since `notifyStop()` is a no-op if `gStorageServer` is `nullptr`.", + "reference": "This fix looks good. My concern, don't forget to fix metad too!" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think it's better to return an error in this case, and let the caller decide what to do.", + "reference": "Just noticed this nil context. Perhaps plumb through ctx too, or change to `Debug`?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get the `POST /session/:session_id/element/:id/click` command to work. Without this header, the server returns a `400 Bad Request` response.", + "reference": "Does it send requests with urlencoded bodies anywhere? I thought it sends only json. Maybe content-type should be `application/json` by default?" + }, + { + "prediction": "I think this should be `44.49.53.43.53.45.52.56.45.52.5F.30.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.00.0", + "reference": "Again use of `constexpr` is recomended." + }, + { + "prediction": "I think this should be `except ImportError:`", + "reference": "Minor point but I would call this ``redim_graph`` instead." + }, + { + "prediction": "I think we can remove this import.", + "reference": "As I was trying to figure out how the error messages are written out, since they are returned from `getOrCreate` and `reconcile`, it looks like we are using plain `klog` to write them out instead of using the logger from the scope above" + }, + { + "prediction": "I don't think this is correct. If we can't enable IP forwarding, we shouldn't start the service.", + "reference": "Now it's double logging, is not it? Because `service.ipForward.Enable()` logs extra `warning`" + }, + { + "prediction": "Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Whatever the decision is about the request type to use, this should only match what is needed and not the other one." + }, + { + "prediction": "I think this should be `if (localConnection && localConnection.type == Blockly.OUTPUT_VALUE) { updatePreviews = true; // Always update previews for output connections. } else if (Blockly.localConnection_ && Blockly.highlightedConnection_) { var xDiff = Blockly.localConnection_.x_ + dxy.x - Blockly.highlightedConnection_.x_; var yDiff = Blockly.localConnection_.y_ + dxy.y -", + "reference": "...and in turn, this should probably be var updatePreviews = true; if (!(localConnection && localConnection.type == Blockly.OUTPUT_VALUE) && (Blockly.localConnection_ && Blockly.highlightedConnection_)) { since the first clause is a no-op. If you want to leave it this way for clarity, that's fine too." + }, + { + "prediction": "I think this should be `find_policy_violations` to be consistent with the other scanners.", + "reference": "Please remove this TODO, since they will not apply anymore after you are done. :) Can you please remove this everywhere else in this PR?" + }, + { + "prediction": "I think this should be `datatype clashes with enum` as well.", + "reference": "This seems like an incomplete schema definition. will that have any effect on the tests?" + }, + { + "prediction": "Why do we need to check if we can load from bin file here?", + "reference": "The testing cases are failing because `SetHeader` does not only handle cases where input are from files. It also reads categorical feature indices from the config parameters (see the part outside the `if (filename != nullptr) { ... }`). Skipping `SetHeader` directly here will cause errors when we load data from numpy or pandas arrays (where `filename == nullptr`) and use categorical features. So I think we should move the the check `filename != nullptr && CheckCanLoadFromBin(filename) == \"\"` into `SetHeader`. That is, we change `if (filename != nullptr) { ... }` into `if (filename != nullptr && CheckCanLoadFromBin(filename) == \"\") { ... }`" + }, + { + "prediction": "I think we can remove the `ok` check here as well, since `err` will always be of type `*exec.ExitError` at this point.", + "reference": "I think we should change the variable name of `err` in `if err, ok := err.(*exec.ExitError); ok `, this re-assignment of `err` still affects the next `else` branch" + }, + { + "prediction": "`std::move(name)` -> `std::move(name)`", + "reference": "`Status` has identical semantics with `StatusOr`." + }, + { + "prediction": "I think this should be `/mutate/add-labels` to be consistent with the rest of the paths.", + "reference": "why is this named in a different style from other paths?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the right thing to do. If the cluster controller has not yet set the OwnerRef, then we don't want to do anything.", + "reference": "Swapped these to ensure that we aren't passing a nil cluster in to util.IsPaused" + }, + { + "prediction": "I think this should be `tuples = []platformPkgManagerTuple{{\"debian\", \"apt\"}, {\"centos\", \"yum\"}, {\"rhel\", \"yum\"}, {\"ubuntu\", \"apt\"}}`", + "reference": "I don't see pkgManager used anywhere, is there a reason we need this?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the `SolrZkClient` constructor.", + "reference": "A bit late, but I don't think this is necessary, as all callers will send absolute paths. And if you ever get a relative path, resolving it with `toAbsolutePath()` leads to it being relative to whatever CWD the app is started with, while the typical resolving of relative `instanceDir` is to resolve it relative to CoreContainer#coreRootDirectory." + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "There's an awful lot of test failures here because `localFieldPathType.schema` may not contain a `getters` array." + }, + { + "prediction": "Line is too long. [81/80]
    Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", + "reference": "Mysql allows for `||` concatenation (e.g. `firstname||' '||surname`) if you enable it: `set sql_mode=PIPES_AS_CONCAT;`. I think this check is safer though" + }, + { + "prediction": "I think we can get rid of the `goens` import now that we're using `github.com/wealdtech/go-ens/v3` directly.", + "reference": "NOTE: this is the default ENS registry address. If the ENS suite is deployed from the current builds to any chain, it will always be found at this address." + }, + { + "prediction": "Align the elements of a hash literal if they span more than one line.
    Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "I'm curious why you are using `draw` in this route file?" + }, + { + "prediction": "I think this should be `ctx.Handle(500, \"GetRawDiff\", err)`", + "reference": "Those variables are only been used once, I think we don't need to create them at all, just pass values to the `GetRawDiff` directly." + }, + { + "prediction": "I don't think we need this change.", + "reference": "I like the idea of replacing all the `#if NET461` with `#if NETFRAMEWORK`... is that worth doing now? Means fewer changes if we go to 4.7.2 at some point" + }, + { + "prediction": "I think this should be `oidcProviderName` or something like that, since it's the name of the OIDC provider, not the name of the Clutch provider.", + "reference": "to fix the docs build failure, make this const var named without the suffix `Name`" + }, + { + "prediction": "I'm not sure this is the right thing to do here. I think we should only fall through if `match` is true.", + "reference": "This bugfix also included, in case a subjectAlternativeName was present in the cert, then URIs (e.g SVID SPIFFE auth) would not have been attempted." + }, + { + "prediction": "Please add a license header to this file.", + "reference": "Same here. Feels like the wrong location." + }, + { + "prediction": "I think it would be better to just import `download_path_suggestion` here, instead of importing the whole module.", + "reference": "Please make `_path_suggestion` public (i.e. remove the `_`) in `downloads.py`." + }, + { + "prediction": "I don't think this is a good name for the flag. I think it would be better to call it something like `external-port-80-is-local-port` or `port-80-is-local-port` or `port-80-is-external-port` or `port-80-is-public-port` or `port-80-is-outside-port` or `port-80-is-wan-port` or `port-80-is-internet-port` or `port-80-is-global-port` or `port-80-is-public-port` or `port-80-is-outside-port` or `port-80-is-wan-port` or `port-80-is-internet-port` or `port-80-is-global-port` or `port-80-is-public-port` or `port-80-is-outside-port` or `port-80-is-wan-port` or `port-80-is-internet-port` or `port-80-is-global-port` or `port-80-is-public-port` or `port-80-is-outside-port` or `port-80-is-wan-port` or `port-80-is-internet-port", + "reference": "Woah, these flag names gotta get shorter. (Edit: I'll try to suggest some if needed, will think on it.)" + }, + { + "prediction": "Align the elements of a hash literal if they span more than one line.
    Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Is this the code that's supposed to use the Rails app's only when in Rails4? What's the point of the first `if app.respond_to?(:secrets)`, both the `if` and the `elsif` have the same body, is only the second one needed? If `app.config` has a `secret_key_base`, then use it, the end. Is there a need for first checking if `app.respond_to?(:secrets)`?" + }, + { + "prediction": "I think this should be `m_is_objc_enum = enum_decl->isObjC();`", + "reference": "Does this not apply to C enums on Linux?" + }, + { + "prediction": "I'm not sure this is the right place to add the label. I think it should be added in the `handleRetryableWriteError` function.", + "reference": "Should this check if the error is `RetryableWriteError` before adding the label?" + }, + { + "prediction": "I'm not sure if this is the best way to handle this. I think it would be better to use `rollup-plugin-node-resolve` and `rollup-plugin-commonjs` to resolve `get-form-data` as a CommonJS module. This way, we don't have to worry about the `.default` property.", + "reference": "Oh wow, that's one complicated require :)" + }, + { + "prediction": "`request_context.go shows how to usie context.Context with SDK requests.` -> `request_context.go shows how to use context.Context with SDK requests.`", + "reference": "do you mean how to \"use\"" + }, + { + "prediction": "I'm not sure if this is a bug or not, but it seems like `children.props.ref` should be `undefined` when `state[0] === 0` and `children.ref` should be `undefined` when `state[0] === 1`.", + "reference": "We can't really test this anymore since ref and props.ref are at the backing node level now" + }, + { + "prediction": "nit: I think we can remove this field and use `currentTask()` instead.", + "reference": "Did you intend to set this in the constructor?" + }, + { + "prediction": "I'm not sure this is the right thing to do. If the user has specified an AMI, we should use that. If the user has specified a region, we should use that. If the user has specified a region and an AMI, we should use that. If the user has specified a region and a K8s version, we should use that. If the user has specified a region, an AMI, and a K8s version, we should use that. If the user has specified a region, a K8s version, and an AMI, we should use that. If the user has specified a region, a K8s version, an AMI, and an OS, we should use that. If the user has specified a region, a K8s version, an OS, and an AMI, we should use that. If the user has specified a region, an OS, an AMI, and a K8s version, we should use that. If the user has specified a region, an OS, a K8s version, and an AMI, we should use that. If the user has specified a region, a K8s version, an OS, and an AMI, we should use", + "reference": "This looks fine as a first approach, and can we put a TODO here about ubuntu 18.04 being hardcoded?" + }, + { + "prediction": "I think this should be `#if defined(USE_OPENCV) && USE_OPENCV`", + "reference": "This isn't strictly needed since lmdb / leveldb data that is unencoded does not require OpenCV IO. I think `DataLayer` should only require lmdb / leveldb. If one tries to use encoded data without OpenCV the `DataTransformer` guards will report the dependency failure." + }, + { + "prediction": "I think this should be `hLog.WithError(err).Errorf(\"unable to apply hiveapi cluster role binding: %v\", err)`", + "reference": "Should we take out this change? This was only in there to try to brute force the start of the apiserver yesterday." + }, + { + "prediction": "Align the elements of a hash literal if they span more than one line.
    Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "I worry that this association name is a bit confusing. Yoz was asking me about the concept of completion yesterday, which is why I think of it. It wasn't clear to him exactly what it was. what about calling this a `step_completer` ? we know that a proposal has many steps, so I think that might be clearer. in the future, we also might want the rename the `approver` relation because a step is not always an approval these days." + }, + { + "prediction": "Why is this being removed?", + "reference": "Just add a to-do saying we need to add api-version in the check some time in the future when we enable the single-swagger spec mode for validation." + }, + { + "prediction": "Why do we need to set the default datasource here ?", + "reference": "@lunika Please see this. It allows us to do `Propel::getConnection()` easily, as we have only one database." + }, + { + "prediction": "`scope.Span.Tags as AspNetTags;` should be `scope.Span.Tags as AspNetTags ?? new AspNetTags();`", + "reference": "Not related to this particular cast but I wonder if we shouldn't have a cast helper that would log if null to gain visibility." + }, + { + "prediction": "I don't think we need the `incompleteSearch` field here.", + "reference": "why do we need to explicitly declare these fields?" + }, + { + "prediction": "I'm not sure this is the right way to do it. The `OAI\\Server` class has a `__construct` method that takes a `VuFind\\Search\\Results\\PluginManager` as an argument, so we should be able to inject that into the `OAI\\Server` class via the service locator.", + "reference": "Note that there are multiple OAI servers -- that's why `$serverClass` is a variable here. You'll want to fetch `$serverClass` from the service manager rather than a hard-coded value, and also set up a module.config.php for the authority record version, `VuFind\\OAI\\Server\\Auth`. Should be easy enough since it can share the same factory." + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "This is no longer needed and should be removed." + }, + { + "prediction": "I think this should be `if request == nil || len(*request) == 0 { return Options{}, nil }`", + "reference": "could use named return params here to avoid declaring the opts, and using naked returns instead." + }, + { + "prediction": " \n }\n \n```\nReview comment?", + "reference": "this is an unrelated fix. I noticed when an instagram carousel post is mixed with images and videos, the videos don't come with thumbnails, so I am adding a fallback thumbnail for this case." + }, + { + "prediction": "I'm not sure if this is the right place to put this, but I think it would be useful to have a `NewWeight` method on the `ChainReader` interface, so that we can get the weight of a tipset without having to do a state transition.", + "reference": "\"... after protocol version 1\"?" + }, + { + "prediction": "I'm not sure about this change. I don't think we want to remove the `[^:\\{\\}]` part.", + "reference": "Is there a unit test that covers this regexp? I am afraid that changing it might break things =/" + }, + { + "prediction": "I'm not sure about this change. I think we want to keep the `@` here.", + "reference": "This change is okay IMO because an `@` variable in Ruby is not a reference -- `@` variables are instance variables. Also, it's never used by the Ruby transformers." + }, + { + "prediction": "I don't think this is correct. The `{{ name }}` should be replaced by the name of the payment method, not the name of the translation key.", + "reference": "Why this change was needed? Because in `po` files it's with curly braces?" + }, + { + "prediction": " | (0x0007fff0 & off >> 2 << 5);\n+ ASSERT(off + 0x80000 < 0x100000);\n+ *pc_writable = (enc & 0xfff8001f) | (0x0007fff0 & (off >> 2 << 5));\n } else if ((enc & 0x7e000000) == 0x3c000000) { /* BL */\n- ASSERT(off + 0x8000000 < 0x10000000);\n- *pc_writable = (0x3c000000 | (0x03ffffff & off >> 2));\n+ ASSERT(off + 0x10000000 < 0x20000000);\n+ *pc_writable = (0x3c000000 | (0x03ffffff & (off >> 2)));\n }\n }\n```\nReview comment?", + "reference": "Wait -- where did this change come from? This seems unrelated to trace building and seems like it could affect basic execution, unlike the rest of this PR which is all under the off-by-default trace option. Please separate this into its own PR and probably ask @AssadHashmi to review." + }, + { + "prediction": "I think we can remove this file, it's not needed anymore.", + "reference": "seems to be redundant (mention `docusaurus` )" + }, + { + "prediction": "I think this should be `CherryPick cherryPick()`", + "reference": "Can we combine this with the Rollback API? We could still support the `rollback` method here, but combine `Rollback` and `CherryPick` into something like `ManageSnapshots`. Then we could reuse logic for enforcing checks of the current snapshot. What do you think?" + }, + { + "prediction": "(style) code indent should use tabs where possible", + "reference": "Maybe just `env_prefix`, I don't think this is referring to the WQ manager." + }, + { + "prediction": "Please revert this change.", + "reference": "Unrelated line change :)" + }, + { + "prediction": "I think we can remove this now that we're not using iptables anymore.", + "reference": "I raised an eyebrow at making `net` depend on `k8s.io`, but it seems we're already doing that." + }, + { + "prediction": "I don't think this is the right way to do it. This will replace all occurrences of \"Countly\" with the company name, which is not what we want. We want to replace only the first occurrence of \"Countly\" with the company name.", + "reference": "I think ticket meant, not applying replacement in this method, but rather applying encodeSomeHtml to each and every localization string" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the right thing to do for now.", + "reference": "ticket for the 4.0 epic?" + }, + { + "prediction": "`cfg.model.get('neck', False)` -> `cfg.model.get('neck', {})`", + "reference": "`cfg.model.get('neck')` will return None if neck does not exist, thus we can omit the default value." + }, + { + "prediction": "Align .new with Blacklight::Solr::FacetPaginator.new.", + "reference": "Trailing whitespace detected." + }, + { + "prediction": "I think this should be `CXXFlags` to be consistent with `CFlags` above.", + "reference": "I don't see why a `cxxflags` key is necessary? C flags are important in the target file because they define things like the float ABI. But these flags are also used for C++. I can't think of a reason why you would want to configure C++ flags in a target file." + }, + { + "prediction": "I think this should be `LOG(THREAD, LOG_ANNOTATIONS, 2, \"Failed to instrument annotation at \" PFX \"\\n\", *start_pc);`", + "reference": "Update year range in Copyright notice, and elsewhere too." + }, + { + "prediction": "I think this should be `AccessKeyIDSecretRef` and `SecretAccessKeySecretRef`", + "reference": "Can we update this PR to not be a breaking change? i.e. if a user specifies `accessKeyID`, it is still used. But if a user specifies `accessKeyIDSecretRef`, it takes precedence?" + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.", + "reference": "You don't actually need both tests here as \"truthiness\" means that `\"0\"` is false and hence the first test will be true..." + }, + { + "prediction": "I'm not sure if this is the best way to test this, but it's the only way I could get it to work.", + "reference": "Everything else in here is using `I18n`. Should we do that here to be consistent?" + }, + { + "prediction": "/0:tcp:2379,0.0.0.0/0:tcp:2380,0.0.0.0/0:tcp:5473,0.0.0.0/0:tcp:6443,0.0.0.0/0:tcp:6666,0.0.0.0/0:tcp:6667;die-on-fail\"`\n }\n \n func (c *Config) Validate() error {\n```\nReview comment?", + "reference": "What do you think about changing the ordering to be `::`? I think it matches the most with what we previously had so that it doesn't change too much for our users." + }, + { + "prediction": "I don't think this is correct. If `rootedAtAtom == -1` then `rootedAtAtom < 0` is true and the `static_cast(rootedAtAtom) < mol.getNumAtoms()` check will fail.", + "reference": "I'm fairly sure this precondition is always true due to the mod (%)" + }, + { + "prediction": "I think this should be `assert !seen.contains(info.info.name) : String.format(\"seen twice: %s\", info.info.name);`", + "reference": "I love seeing diffs like this one, adding a `String` message to an otherwise cryptic `assert`! It makes me realize you must have had a hellacious debugging session!" + }, + { + "prediction": "If a config file does not have version, it is assumed to be zero. All fields listed in migrate() might be changed if an actual value matches to default value from a previous version.", + "reference": "1. No logger exists to produce a message 2. Can't assume the latest version because missed version means 0." + }, + { + "prediction": "`$this->hash . ':' . $this->level` should be `$this->level . ':' . $this->hash`", + "reference": "I saw a wrong reuse of the cache between a partial analysis of a single file and a full run where errors due to lack of context on the first partial run was reported on the full run. Shouldn't we use a hash that is composer.lock + psalm.xml + command line to be safe?" + }, + { + "prediction": "`from databricks.koalas.indexes import DatetimeIndex` -> `from databricks.koalas import DatetimeIndex`", + "reference": "Could you also update it in `at_time`?" + }, + { + "prediction": "I think we can remove the `localityFallback` variable and just do `options.get(\"locality\").map(Boolean::parseBoolean).orElse(LOCALITY_WHITELIST_FS.contains(scheme));`", + "reference": "Because schema is non-final we can't just switch this to a lambda" + }, + { + "prediction": "I think this should be `MustBeRethrown(\"While resolving function '{0}' following exception occured: {1}\", functionName, exception)`", + "reference": "proposal: **always** add the exception to the end of the message. So no need to to pass exception twice (implicit and explicit). Need a lot of changes." + }, + { + "prediction": "I think it is better to set the invocation type when the event is created, rather than setting it in the event listener.", + "reference": "why? event.getInvocationType is not you want?" + }, + { + "prediction": "This should be `json:\"git_hash,omitempty\"` so that it doesn't show up in the output if it's empty.", + "reference": "nit: how about `GitSHA`?" + }, + { + "prediction": "I think this should be `#define FAIL_DIR \"makeflow.failed.%d\"`", + "reference": "If you move the other functions, this should also be moved to `makeflow_gc.h`." + }, + { + "prediction": "I think it would be better to have a `get_duration_ms` method in `track_metadata.py` that returns `duration_ms` if it exists, otherwise `duration * 1000`. Then you can just do `expire_time = get_duration_ms(listen['track_metadata']['additional_info']) // 1000`", + "reference": "This whole block bugs me. Expire_time to me suggest that an absolute time of when something happens and duration is an interval of time. While the code looks correct, it feels awkward to read." + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "Can we add `_dom` as an argument to createVNode here? I think it might be shorter (could totally be wrong!)" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done after the `popf` instruction is added to the instruction list.", + "reference": "I think that the iret handling is not yet good." + }, + { + "prediction": "I'm not sure if this is the right way to fix it, but it seems to work for me.", + "reference": "Huh, that's kinda weird. I get it, but it's unexpected to me..." + }, + { + "prediction": "I think we can remove this function as well, as it's not used anymore.", + "reference": "why is this removed? it is important when you upload from stream of unknown size" + }, + { + "prediction": "Use the new Ruby 1.9 hash syntax.
    Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Out of curiosity, why is this needed? Does it enforce what class can be assigned?" + }, + { + "prediction": "I think this should be `0777`", + "reference": "non-blocking: Now that we have a handful of statements which deal with creating a listener, it may make sense to introduce a `createListener` method or something similar" + }, + { + "prediction": "I don't think we need this property at all. We can just return `LastExecutor` from `Create` method.", + "reference": "factory should be stateless if possible, looks like much complexity added" + }, + { + "prediction": "I think this should be `return self.output().table.project_id`", + "reference": "Could you please add short description for the default value as well?" + }, + { + "prediction": "I don't think this is the right thing to do. We should return the error and let the caller decide what to do with it.", + "reference": "Leave a TODO message to say we will fix the log level in the future, once committing the block and the state become a transaction" + }, + { + "prediction": "I think this should be `write.parquet.row-group-check.max-record-count` and `write.delete.parquet.row-group-check.max-record-count`", + "reference": "this can be integer" + }, + { + "prediction": "I think this should be `font: {{ font['completion.category'] }};` instead of `font: {{ font['completion.category'] }};`", + "reference": "nitpick: Please remove the blank line here" + }, + { + "prediction": "Line is too long. [81/80]
    Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "What is this for? The only methods I can see by that name in the rails doc are generating a foreign key name from a model class name but you seem to be giving a key name as argument?" + }, + { + "prediction": "I think this should be `if (pkiAuthenticationPlugin != null && pkiAuthenticationPlugin.plugin.getMetricRegistry() == null) {`", + "reference": "Is this second check necessary? we know that just after the plugin was created its metricRegistry is null, it's set only after `initializeMetrics` has been called." + }, + { + "prediction": "I think this should be `if (player->getAccountType() < it->second.getRequiredAccountType()) { return TALKACTION_BREAK; } else if (it->second.fromLua) { if (it->second.getNeedAccess() && !player->getGroup()->access) { return TALKACTION_CONTINUE; } }`", + "reference": "shouldn't this be `return TALKACTION_BREAK;` as the player does not meet the required group access?" + }, + { + "prediction": "I think this test should be moved to `CliqueAcceptanceTest` as it is not related to mining at all.", + "reference": "does this still work if minerNode1 has already proposed a block before 2 & 3 are stopped?" + }, + { + "prediction": "I think this should be `logging.FromContext(ctx).Desugar().Error(\"Adding log line for the TestCloudLogging E2E tests\", zap.String(v1.LoggingE2EFieldName, v))`", + "reference": "I am wondering if we can either make this a feature or have a way to turn it off in production. My concern is that we might be adding more of these kind of code in the future." + }, + { + "prediction": "I think `pdf = kdf.to_pandas().stack(level=1).reset_index(level=1, drop=True)` is enough.", + "reference": "We can just use `.stack()` here? Then I guess we can reuse when supporting multi-index columns." + }, + { + "prediction": "I think we can remove this `#if NETSTANDARD2_0` and just return `true`", + "reference": "What are the possibilities here? Since we plan on supporting .net standard 2.0 from day 1, we might as well tackle that now." + }, + { + "prediction": "I think this should be \"the associated \".", + "reference": "should the parameters be called reference or context?" + }, + { + "prediction": "I think this should be `in_buffer.byteslice(index..-1)`", + "reference": "Do we need to also change `length` here (and below) to `bytesize`? Perhaps we ought to make a copy of `in_buffer` encoded as binary and then the existing algorithm should work." + }, + { + "prediction": "I think this should be `q.yank_text = suggested_filename`", + "reference": "This should be `toDisplayString()` to not contain e.g. passwords." + }, + { + "prediction": "Align the elements of a hash literal if they span more than one line.
    Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Can we just say that having a non-nil `autocomplete_path` implies that autocomplete is enabled?" + }, + { + "prediction": "I think we should keep the `gogo` import here.", + "reference": "Note that the package github.com/golang/protobuf/proto is deprecated. We're instructed to use the \"google.golang.org/protobuf/proto\" package instead. I didn't want to change it now to avoid intrusive changes whose consequences are, currently, unknown." + }, + { + "prediction": "Layout/TrailingWhitespace: Trailing whitespace detected.", + "reference": "Are these gone routes? Do we need to 301 them?" + }, + { + "prediction": "This import is not used.", + "reference": "move them to internal group of imports" + }, + { + "prediction": "Please remove this line.", + "reference": "can we rewrite this as: `ignored event '%s' for cstor pool '%s'`" + }, + { + "prediction": "Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.", + "reference": "not all client data types have an approving official (eg: 18F does not). do we still want to include the relation here?" + }, + { + "prediction": "I don't think we need to change this.", + "reference": "This change should also probably go into the corresponding method of the abstract By class?" + }, + { + "prediction": "Why is this removed?", + "reference": "why this remove?" + }, + { + "prediction": "I think this should be `io.ReadCloser` instead of `FileReader`.", + "reference": "As the test failures indicate, making this change is going to mean changing everything which currently implements this interface." + }, + { + "prediction": "I think this should be `https://forum.upcase.com` instead of `http://forum.upcase.com`", + "reference": "Do we want to redirect this to the forum or something in case people have it linked/bookmarked?" + }, + { + "prediction": "I don't think this is the right thing to do. If we don't have a name or email, we shouldn't have a background color at all.", + "reference": "@peterzimon came up with this 'NM' piece as a placeholder for New Member initials, without this the screen looks broken. It changes to normal initials calculation once email or name is entered. Lmk if you'd like to put something different here ;)" + }, + { + "prediction": "This should be `ember-data/attr` instead of `ember-data/attr`", + "reference": "@kevinansfield Would be cool if you can take a if this is the best way to add `subscriptions` info on member model. This uses the transform + separate model definition way which seemed to be the right way from other references in Admin" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should still log it, but not at the debug level. I think we should log it at the warning level, so that users are aware that they can't use the Plot class.", + "reference": "This is the common way of dealing with optional dependencies" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the right thing to do.", + "reference": "nit: we can replace all `kr` in this file with like `src`." + }, + { + "prediction": "I think this should be `readPreference.tags || readPreference.slaveOk || readPreference.slaveOkay || readPreference.secondaryOk || readPreference.secondaryPreferred || readPreference.primaryPreferred || readPreference.primary || readPreference.pri || readPreference.priPrefer || readPreference.secondary || readPreference.prefs || readPreference.preference || readPreference.pref || readPreference.slave || readPreference.slaveOk || readPreference.slaveOkay || readPreference.secondaryOk || readPreference.secondaryPreferred || readPreference.primaryPreferred || readPreference.primary || readPreference.pri || readPreference.priPrefer || readPreference.secondary || readPreference.prefs || readPreference.preference || readPreference.pref || readPreference.slave || readPreference.slaveOk || readPreference.slaveOkay || readPreference.secondaryOk || readPreference.secondaryPreferred || readPreference.primaryPreferred || readPreference.primary || readPreference.pri || readPreference.priPrefer || readPreference.secondary || readPreference.prefs || readPreference.preference || readPreference.pref || readPreference.slave || readPreference.slaveOk || readPreference.slaveOkay || readPreference.secondaryOk || readPreference.secondaryPreferred || readPreference.primaryPreferred || readPreference.primary || readPreference.pri || readPreference.priPrefer || readPreference.secondary || readPreference.prefs", + "reference": "same concern here as above" + }, + { + "prediction": "Line is too long. [101/80]", + "reference": "Thank you for this, I gather this repairs failures that I've seen in another PR." + }, + { + "prediction": "I think we can remove the `distinct` here. The `ReadManifest` already does a `distinct` on the `file_path` column.", + "reference": "This place probably makes sense to me. We can consider exposing an argument to make the dedup step optional (I am not sure it is a good idea but I want to think this through together). The dedup step we are adding is going to trigger a shuffle. Technically, we are fine in the existing expire snapshots action as it does the dedup in `except`. The question is what kind of performance impact deduplicating here will have. We only have duplicates if multiple manifests reference the same files. In `rewrite_manifests` procedure, we rewrite all manifests, meaning we produce a snapshot with new manifests where entries are old data files. Also, there are updates and deletes that may rewrite manifests. I think deduplicating here makes sense to me in all cases. Thoughts, @rdblue @flyrain @RussellSpitzer @karuppayya?" + }, + { + "prediction": "I think this should be an error, not a warning. If we can't remove the node from osdconfig, then we can't remove the node from the cluster.", + "reference": "can we move the code before deleteNodeFromDB ? this way even if the node crashes after remove config we can still re-run decommission again ?" + }, + { + "prediction": "`var_name=None` is not a good idea, because it will make the result of `df.melt()` different from the result of `df.melt(id_vars=id_vars, value_vars=value_vars, var_name='variable', value_name='value')`", + "reference": "Seems the default value of `melt`'s `var_name` at namespace.py should be changed as well." + }, + { + "prediction": "I think we can remove this TODO now that we have the integration tests in place.", + "reference": "I think botocore's serializer should already create the correct headers. However, they are currently not used in `_botocore_parser_integration_test`(line #217). Maybe we could remove the headers here and just use a fallback in the `_botocore_parser_integration_test` (i.e. use the given headers if they are set, otherwise use the headers generated by botocore's serializer)?" + }, + { + "prediction": "I don't think this is the right way to do it. We should have a `delete_singular` key in the `procedures` namespace, not a `delete_singular` key in the `messages` namespace.", + "reference": "This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted." + }, + { + "prediction": "I think this should be `opts.host` instead of `this.opts.host`", + "reference": "in case you want to rename one of the plugins when instantiating, from options?" + }, + { + "prediction": "I think this should be `ctu-func-mapping` instead of `clang-func-mapping`.", + "reference": "This default variable should be moved into a config variable, created by `package_context`, and read from `config\\package_layout.json`." + }, + { + "prediction": "`void 0 + 1` should be `void 0 + void 0 + 1` or `void 0 + void 0 + void 0 + 1` or `void 0 + void 0 + void 0 + void 0 + 1` or `void 0 + void 0 + void 0 + void 0 + void 0 + 1` or `void 0 + void 0 + void 0 + void 0 + void 0 + void 0 + 1` or `void 0 + void 0 + void 0 + void 0 + void 0 + void 0 + void 0 + 1` or `void 0 + void 0 + void 0 + void 0 + void 0 + void 0 + void 0 + void 0 + 1` or `void 0 + void 0 + void 0 + void 0 + void 0 + void 0 + void 0 + void 0 + void 0 + 1` or `void 0 + void 0 + void 0 + void 0 + void 0 + void 0 + void 0 + void", + "reference": "Can I ask you to add a new line after `const` assignment? I believe that this increases the code readability by encapsulating assignment and logic (expecting) blocks." + }, + { + "prediction": "I think this should be `#ifndef KOKKOS_IMPL_ENABLE_CUDA_HOST_INIT_CHECK`", + "reference": "So the intention is you configure with `-CMAKE_CXX_FLAGS=\"-D KOKKOS_IMPL_TURN_OFF_CUDA_HOST_INIT_CHECK\"`?" + }, + { + "prediction": "I don't think this is the right place to set the occupancy and B-factor.", + "reference": "This was a bug." + }, + { + "prediction": "I think it would be better to use `sprintf('%s%s', $useLazyLoading ? 'lazy' : '', $isAttributeClassExistsAndNotEmpty ? ' ' . $attributes['class'] : '')` instead of `sprintf('%s%s', $useLazyLoading ? 'lazy' : '', $isAttributeClassExistsAndNotEmpty ? ' ' . $attributes['class'] : '')`", + "reference": "Is OK that we don't have some placeholder?" + }, + { + "prediction": "why 2? 1 should be enough.", + "reference": "Sectorbuilder behaves differently depending on whether it's given 1 or more threads. It won't seal if only given 1." + }, + { + "prediction": "I think we can remove this import.", + "reference": "Sort of believe We should put MetricManager in constructor parameter given this case." + }, + { + "prediction": "I think we can remove the `sourceId` and `fieldId` from the `PartitionField` class. The `sourceId` is only used in the `PartitionSpec` class, and the `fieldId` is only used in the `PartitionData` class. I think we can just use the `fieldId` in the `PartitionField` class, and use the `sourceId` in the `PartitionSpec` class, and use the `fieldId` in the `PartitionData` class. This will make the `PartitionField` class simpler.", + "reference": "Do we need to check `fieldId` is larger than 1000?" + }, + { + "prediction": "I don't think this is the right place to call check_acked_status(). It should be called when the change is added to the history, not when it is removed from the history.", + "reference": "I think this should be called after the if below (the one for disable positive acks)" + }, + { + "prediction": "I think we can remove the `format.contains(\"avro\")` check and just call `listAvroPartition` here.", + "reference": "I'd like to avoid changing this method since it is public and using a URI will probably change behavior for users passing strings (String -> URI -> Path instead of String -> Path)." + }, + { + "prediction": "I think this should be `sdktesting.StashEnv()` instead of `os.Clearenv()`", + "reference": "Should these restore the stashed env after the test runs?" + }, + { + "prediction": "I think it would be better to use `scope.args.kw_defaults` instead of `scope.args.defaults`, because `scope.args.defaults` is a list of default values for positional arguments, and `scope.args.kw_defaults` is a list of default values for keyword arguments.", + "reference": "We're calculating the full list of kwargs here (even if the first element of the list would return True) so we could improve performance by using a generator line 408 in ``for default_node in all_defaults:``." + }, + { + "prediction": "nit: I think we can remove this struct and just use `accountDelta` directly.", + "reference": "Can ndelta differ depending on when the deltas are compacted? That is, when intermediate updates are dropped?" + }, + { + "prediction": "I don't think we need the extra `

    ` here.", + "reference": "Our checkstyle config likes it better when the `

    ` is before the first word of the next paragraph, and not on a blank line" + }, + { + "prediction": "I think this should be moved to the end of the function, after `cmd.Wait()`. Otherwise, if CRIU crashes, we will close the connection and runc will not be able to get the exit status of CRIU.", + "reference": "This looks to be the only place where we return early before the close below, so if the \"double close\" is bothering people, closing manually here (and removing the `defer`) could be an option" + }, + { + "prediction": "I think this should be `npm run test:js -- --watchAll=false` so that we don't have to wait for the tests to run every time we save a file.", + "reference": "This task can probably be deleted since we don't need gulp to run Jest." + }, + { + "prediction": "I don't think we need to check for `Errno::EPERM` on cygwin.", + "reference": "Doesn't this need to include `Errno::ECONNRESET` to fix the issue?" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "never heard of a qirector... what's their role again? (also should be 'for a movie')" + }, + { + "prediction": "Why do we need to check `onlyVertexProps_` here? If `onlyVertexProps_` is true, then `tagContexts_` must be empty.", + "reference": "Implement the \"collect all props for one vertex\" logic inside QueryVertexPropsProcessor" + }, + { + "prediction": "I don't think this is correct. If the stream is not at the end of the file, it means there was an error parsing the number.", + "reference": "This is to prevent parsing things like \"1.1\" as \"1\" until we implement it properly." + }, + { + "prediction": "I don't think we need to import this function. It's only used in one place in this file, and we can just call `_getCheckpointParentDir` directly there.", + "reference": "Can we change `_getCheckpointParentDir` to be a public function explicitly? It seems like something that clients of experiment runner may wish to use." + }, + { + "prediction": "This should be `Translators: This is the label for a checkbox in the Advanced settings panel.`", + "reference": "Why is a restart necessary?" + }, + { + "prediction": "I think we can remove this line as well.", + "reference": "Should setting the task runtime also go under the above if condition?" + }, + { + "prediction": "This should be `const defaultListEntriesPageSize = 50`", + "reference": "SPIRE uses the leadingLowerCase convention for unexported constants" + }, + { + "prediction": "This file should not be changed.", + "reference": "The newest JSchema code generator orders `System` usings first." + }, + { + "prediction": "I think we should use `InputFormatConfig.CASE_SENSITIVE_DEFAULT` instead of `true` here.", + "reference": "I understand that we want to have a possibility to configure the IcebergInputFormat to be case sensitive or case insensitive since it can be used by other MR jobs as well. Do we want to allow the users of Hive to shot themselves on the foot and enable case sensitivity? My first guess would be that we should not use the configuration here, just go with `false`, but if you have some specific use-case in your mind I can be easily convinced" + }, + { + "prediction": "can we move this to the end of the function?", + "reference": "Will the above call to cStorPoolAddEventHandler() get executed in the same thread as this line?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to work.", + "reference": "I don't think alloca instructions are always at the start of the entry block. I think it would be safer to check the entire entry block for alloca instructions, just in case some are not the first instruction. (Technically they can be anywhere in the function but we check in other places that this isn't possible)." + }, + { + "prediction": "I'm not sure this is the right place for these constants. I think they should be defined in the `networking` package.", + "reference": "Why isn't this 4789 (which I think is the Felix default)?" + }, + { + "prediction": "I think this should be `FailureImportOperations` and `MessageFailureImportOperations`", + "reference": "Can this be `Import operations failure`? In addition, is this the right time to change the variable names? e.g. `ReasonImportOperationsFailure`, `ReasonImportFailure`, `ReasonImportSuccessful`, `ReasonCreateResourceFailure`, `ReasonImportResourceSuccessful` Naming convention that i have assumed here is as follows: `Reason`" + }, + { + "prediction": "I don't think this is necessary, since `rbuf_ivar_id` is only used in `rb_thrift_binary_proto_read_set_end`, which is only called from `rb_thrift_binary_proto_read_set`, which is only called from `rb_thrift_binary_proto_read`, which is only called from `Thrift::BinaryProtocolAccelerated#read`, which is only called from `Thrift::BinaryProtocolAccelerated#read_set`, which is only called from `Thrift::BinaryProtocolAccelerated#read_struct_begin`, which is only called from `Thrift::BinaryProtocolAccelerated#read_struct`, which is only called from `Thrift::BinaryProtocolAccelerated#read_message_begin`, which is only called from `Thrift::BinaryProtocolAccelerated#read_message`, which is only called from `Thrift::BinaryProtocolAccelerated#read`, which is only called from `Thrift::BinaryProtocolAccelerated#read`, which is only called from `Thrift::BinaryProtocolAccelerated#read`, which is only called from `Thrift::BinaryProtocolAccelerated#read`, which is only called from `Thrift::BinaryProtocolAccelerated#read`, which is only called from `Thrift::BinaryProtocolAccelerated#read`,", + "reference": "I suspect this isn't needed because I think `rb_intern` gets marked already." + }, + { + "prediction": "I think this should be `log.fine`", + "reference": "This change is incorrect: the current log level is correct." + }, + { + "prediction": "I think this should be `VERSION_LOW_CARDINALITY_LEAFS`", + "reference": "Can you add a space before the equal sign? There are a couple other places where spaces are missing in this PR." + }, + { + "prediction": "I think we can remove the `updateList.add(flow.toUpdateObject(updateTime));` line as well.", + "reference": "Please follow the todo naming convention." + }, + { + "prediction": "I don't think we want to expose the `Ready` condition here. I think we should only expose the `CertificateIssued` condition.", + "reference": "These are no longer used and changes should instead be made directly to the files in `deploy/chart/crds` /assign @JoshVanL /unassign" + }, + { + "prediction": "`torch.cat((xy, pred_map[..., 2:4]), axis=-1)` -> `torch.cat((pred_map[..., :2], pred_map[..., 2:4]), axis=-1)`", + "reference": "Is this really necessary to work around this way? The old version works fine with me when converting to ONNX." + }, + { + "prediction": "I think this should be `errors.New(\"blob already closed\")` to be consistent with the other errors in this file.", + "reference": "Same as above: don't start error strings with a capital letter, and don't fix unneeded things in an unrelated commit ;)" + }, + { + "prediction": "Metrics/LineLength: Line is too long. [101/80]", + "reference": "Is this a testing debug statement?" + }, + { + "prediction": "I don't think we should be using `console.log` here.", + "reference": "you'll need to wrap the _whole thing_ within this async call (or refactor it so everything below is in a new temporary function). The code below this section depends on a value for `object` after the parsing occurs, but what you're doing here is kicking off a race condition where `object` is null, but _might_ parse quickly enough to assign it the parsed parts. Instead, you need to do everything that depends on the parsed object in the callback of `parse`." + }, + { + "prediction": "Why is this needed?", + "reference": "This is now going to be protecting `stopped` when it doesn't need to. If you are going to do this then can you make `stopped` non-atomic and protect it in `stop`. It's cheap to make a `unique_lock` fyi, it's just a pointer to a mutex and a `bool`. The `lk.lock ()` in the loop is superfluous so probably shouldn't have been there to begin with." + }, + { + "prediction": "This import is not used.", + "reference": "Lets not give packages names if we dont have to. If a package requires a rename, we should change the actual name while/if we can." + }, + { + "prediction": "I think this should be `if (TEST(1U << 31, enc) && TEST(1U << 15, enc))`", + "reference": "Not sure I see where this is coming from. This is a bug fix? Should be mentioned in the commit message? Same below." + }, + { + "prediction": "I think we should keep the `beforeEach` and `afterEach` here. The `beforeEach` is used to set up the database for each test, and the `afterEach` is used to clean up the database after each test. If we remove the `beforeEach` and `afterEach`, then the database will not be set up for each test, and the `afterEach` will not be used to clean up the database after each test. This will cause the tests to fail because the database will not be set up for each test, and the `afterEach` will not be used to clean up the database after each test. I think we should keep the `beforeEach` and `afterEach` here. The `beforeEach` is used to set up the database for each test, and the `afterEach` is used to clean up the database after each test. If we remove the `beforeEach` and `afterEach`, then the database will not be set up for each test, and the `afterEach` will not be used to clean up the database after each test. This will cause the tests to fail because the database will not be set up for each test, and the `afterEach` will not be used to", + "reference": "I reverted this change in the last commit, I think we should revert it here. I know this leads to confusing test output for skipped tests, but I would prefer to tackle that in a separate PR specifically focused on that problem. In fact, I think the issue might really be with the leak checker, and not how this test runner is defined. Please make a ticket for this (if it doesn't already exist) and revert this change" + }, + { + "prediction": "`normed_bbox` is not used in OpenImage Dataset.", + "reference": "Can this part be done in `dataset.get_ann_info`? Just like CocoDataset converts xywh to xyxy in `_parse_ann_info`" + }, + { + "prediction": "I think this test should be updated to use `trace.NewNoopTracerProvider()` instead of `trace.NoopProvider{}`.", + "reference": "Should we change the name of this test struct to be `testTracerProvider` as well?" + }, + { + "prediction": "remove empty line", + "reference": "\"google.golang.org/grpc\" should be together with \"go.uber.org/zap\" all \"\"github.com/iotexproject/iotex-core/*\" stay together" + }, + { + "prediction": "I'm not sure if this is the right place to inject the print script. I think it would be better to do it in `browsertab.py` so that it is done for all tabs, not just webengine tabs.", + "reference": "No need for a separate variable here - just call `utils.read_file` directly below." + }, + { + "prediction": "I think it's better to use `time.After` instead of `time.NewTimer` and `time.Until(deadline)`.", + "reference": "Thanks for the fixing, small question, Here the message just be written to the channel, will it be blocked?" + }, + { + "prediction": "I think this should be `Senders` instead of `SendersRecovery`", + "reference": "maybe we will have something like `Bodies []byte(\"bodies\")` instead of them being a number? with numbers we are making it harder to insert stages mid-process." + }, + { + "prediction": "I don't think we need to change the order of the fields here.", + "reference": "out of curiosity, why making this change? If no real reason, could you restore to avoid unnecessary changes of several generated files?" + }, + { + "prediction": "I think this should be `Disconnected` instead of `NotConnected`.", + "reference": "Could we public events if `manager.serStatus()`?" + }, + { + "prediction": "I'm not sure if this is the right place to put this error message. I think it would be better to have it in the `install` method of the `Uppy` class. That way, we can check if the `target` option is a string, and if it is, we can check if the element exists on the page. If it doesn't, we can throw an error with a message that says something like \"Invalid target option given to ${callerPluginName}. Please make sure that the element exists on the page, or that the plugin you are targeting has been installed. Check that the