diff --git "a/qwen25_0.5b_ia3_official_1e-05/complete_results.json" "b/qwen25_0.5b_ia3_official_1e-05/complete_results.json" --- "a/qwen25_0.5b_ia3_official_1e-05/complete_results.json" +++ "b/qwen25_0.5b_ia3_official_1e-05/complete_results.json" @@ -1,57 +1,57 @@ { - "test_bleu_4": 0.009579801420873146, + "test_bleu_4": 0.01224215135214152, "test_exact_match": 0.0, "test_rouge": { - "rouge1": 0.11977610030381777, - "rouge2": 0.016105454231956418, - "rougeL": 0.09664768997198948, - "rougeLsum": 0.09664191105877168 + "rouge1": 0.12928619275411635, + "rouge2": 0.01715199368655258, + "rougeL": 0.10332096836404203, + "rougeLsum": 0.10336470561126912 }, "test_bertscore": { - "precision": 0.825509941376279, - "recall": 0.8424355827234572, - "f1": 0.8333937052382001 + "precision": 0.8325258651681443, + "recall": 0.8443640767971151, + "f1": 0.8379435360238244 }, - "test_meteor": 0.10774452635583136, + "test_meteor": 0.11336907054732477, "raw_data": [ { - "prediction": "I think we can remove the `language=java,transport=grpc` parameter.", + "prediction": "I think this should be `language=java,transport=grpc` instead of `language=java`", "reference": "can we also test for `transport=rest`?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `AbstractSolrBackendFactory` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this.", "reference": "If record_batch_size is not set in config.ini, this code will trigger a notice about an undefined value. I would suggest either wrapping the setPageSize() call in an `if (!empty(...)) {` check, or else providing a default value in the set call (i.e. `$config->Index->record_batch_size ?? 100`)." }, { - "prediction": "I think this should be `window.analytics.load(<%= ENV['SEGMENT_KEY'] %>);`", + "prediction": "I think we should be using `window.analytics.load(<%= ENV['SEGMENT_KEY']%>)` instead of `window.analytics.SNIPPET_VERSION=\"2.0.8\"`.", "reference": "I didn't realize we were hardcoding this, thanks for moving it to an env value." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this", + "prediction": "I'm not sure if this is the right way to do this, but I think we should be able to use the `file.data.size` directly in the template. I think we should be able to use the `file.data.size` directly in the template. I think we should be able to use the `file.data.size` directly in the template. I think we should be able to use the `file.data.size` directly in the template. I think we should be able to use the `file.data.size` directly in the template. I think we should be able to use the `file.data.size` directly in the template. I think we should be able to use the `file.data.size` directly in the template. I think we should be able to use the `file.data.size` directly in the template. I think we should be able to use the `file.data.size` directly in the template. I think we should be able to use the `file.data.size` directly in the template. I think we should be able to use the `file.data.size` directly in the template. I think we should be able to use the `file.data.size` directly in the template. I think we should be able to use the `file.data.size", "reference": "We are trying to support IE 10-11, so we'll need a polyfill for this one, I think." }, { - "prediction": "I'm not sure what you mean by \"isNavigating\" and \"navigatingURL\" in this context. I think you meant \"isNavigating\" and \"navigateURL\" in this context.", + "prediction": "I'm not sure what you mean by \"isNavigating\" and \"navigatingURL\" in this context. Could you please provide more context?", "reference": "It looks like there's a new `isNavigatingTo( url )` selector for this very purpose so let's use this here instead. This way we just need to use the one selector rather than two. Let's assign that to a similar-named variable here (e.g. `isNavigatingToPostResetURL`) rather than the prop it's used with." }, { - "prediction": "I'm not sure what you mean by `num_channels` and `im_num_dims` in this context. Could you please clarify?", + "prediction": "I'm not sure what you mean by `num_channels` and `im_num_dims` here. Could you please clarify?", "reference": "I think im2col should only accommodate CPUMat." }, { - "prediction": "I think we should remove the `from google.cloud.forseti.notifier.notifiers.inventory_summary import InventorySummary` line.", + "prediction": "I think we can remove the `from google.cloud.forseti.notifier.notifiers.inventory_summary import InventorySummary` line.", "reference": "alpha sort the imports" }, { - "prediction": "I think this should be `sysfs_read_u32` instead of `sysfs_read_u64`.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `snprintf_s_iiii` instead of `snprintf`.", "reference": "Can you explain why is this necessary? Is `snprintf()` with four integer arguments unsafe?" }, { - "prediction": "I think this should be moved to the end of the function. It's not clear to me what the purpose of this function is. Is it to get the keyboard layout from the thread with the focus (input thread)? Or is it to get the keyboard layout from the last detected change? Or is it to get the keyboard layout from the last inputLangChange detected by NVDA on the foreground object? Or is it to get the keyboard layout from the last inputLangChange detected by NVDA's main thread? Or is it to get the keyboard layout from the last inputLangChange detected by NVDA's main thread? Or is it to get the keyboard layout from the last inputLangChange detected by NVDA's main thread? Or is it to get the keyboard layout from the last inputLangChange detected by NVDA's main thread? Or is it to get the keyboard layout from the last inputLangChange detected by NVDA's main thread? Or is it to get the keyboard layout from the last inputLangChange detected by NVDA's main thread? Or is it to get the keyboard layout from the last inputLangChange detected by NVDA's main thread? Or is it to get the keyboard layout from the last inputLangChange detected by NVDA's main thread", + "prediction": "I think this should be `if not hkl` instead of `if not hkl:`", "reference": "How likely would it be that the keyboard layout for the NVDA main thread differs from the keyboard layout of the currently focused app?" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `http.Executor` instead of `http.HttpClient` in this case.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `http.Executor` instead of `http.HttpClient` here. `http.HttpClient` is deprecated and will be removed in the future. `http.Executor` is a better choice.", "reference": "Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`)" }, { @@ -59,7 +59,7 @@ "reference": "Also update line 2205 below" }, { - "prediction": "I'm not sure what you mean by \"shared\" here. Is it referring to the shared mount value? If so, I think we should remove the `if err != nil {` block.", + "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. I think it's a good place to put it because it will be used in other places as well. I think it's a good place to put it because it will be used in other places as well. I think it's a good place to put it because it will be used in other places as well. I think it's a good place to put it because it will be used in other places as well. I think it's a good place to put it because it will be used in other places as well. I think it's a good place to put it because it will be used in other places as well. I think it's a good place to put it because it will be used in other places as well. I think it's a good place to put it because it will be used in other places as well. I think it's a good place to put it because it will be used in other places as well. I think it's a good place to put it because it will be used in other places as well. I think it's a good place to put it because it will be used in other places as well", "reference": "n_: It is a good practice to name the variable to indicate what they contain. In this case since `shared` is supposed to have boolean, calling it: `isShared` can help in the readability of the code." }, { @@ -67,7 +67,7 @@ "reference": "I suppose it's a false-positive error. Maybe there is a way to configure the `eslint-*` package to accept `i.e. .... lower case` syntax" }, { - "prediction": "I don't think we need to do this. We can just use `activity.ParentSpanId.ToHexString().Equals(\"0000000000000000\")` instead.", + "prediction": "I don't think we need to do this.", "reference": "this maynot be a perf issue, if ToHexString() is not actually allocating a string, but returns the caches string value. to be confirmed." }, { @@ -75,23 +75,23 @@ "reference": "`zap.String(\"image-provider\", provider.Name())` should be in a same line." }, { - "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to truncate a string to a maximum length of 300 characters, but you're not actually truncating the string at the end. Instead, you're using `str.length > maxLength` to check if the string is longer than 300 characters. If it is, you're returning the truncated string, but if it's not, you're returning the original string. Is this what you're trying to do?", + "prediction": "I don't think this is needed.", "reference": "Why this deletion?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `check.content_disposition` in this case. It's not clear what you're trying to do here, but I don't think it's a good idea to use `check.content_disposition` in this case. It's not clear what you're trying to do here, but I don't think it's a good idea to use `check.content_disposition` in this case. It's not clear what you're trying to do here, but I don't think it's a good idea to use `check.content_disposition` in this case. It's not clear what you're trying to do here, but I don't think it's a good idea to use `check.content_disposition` in this case. It's not clear what you're trying to do here, but I don't think it's a good idea to use `check.content_disposition` in this case. It's not clear what you're trying to do here, but I don't think it's a good idea to use `check.content_disposition` in this case. It's not clear what you're trying to do here, but I don't think it", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a test for this. I'm not sure if this is the right place to do this, but I think it's a good idea to add a test for this. I'm not sure if this is the right place to do this, but I think it's a good idea to add a test for this. I'm not sure if this is the right place to do this, but I think it's a good idea to add a test for this. I'm not sure if this is the right place to do this, but I think it's a good idea to add a test for this. I'm not sure if this is the right place to do this, but I think it's a good idea to add a test for this. I'm not sure if this is the right place to do this, but I think it's a good idea to add a test for this. I'm not sure if this is the right place to do this, but I think it's a good idea to add a test for this. I'm not sure if this is the right place to do this, but I think it's a good idea to add", "reference": "This change looks unrelated to the CL description?" }, { - "prediction": "I don't think this is a good idea. It would be better to use `qctx_` instead of `qctx_.get()`.", + "prediction": "I don't think this is a good idea.", "reference": "I'm not certain that `res`+`utl` isn't a thing." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `LEFT JOIN` here.", "reference": "This method can cause bugs. Why don't you use list of finalize statuses and then use join by comma and that will give you correct value. Use Apache Commons Lang library List list = Arrays.asList(1,2,3,4,5,6,7); String str = org.apache.commons.lang.StringUtils.join(list, \",\"); You can use it at multiple places shown in this diff." }, { - "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you", + "prediction": "I don't think we need to call `wlr_input_device_destroy` here. It's already called in `wlr_input_device_init` and `wlr_input_device_destroy`.", "reference": "Merge with next condition" }, { @@ -99,7 +99,7 @@ "reference": "Maybe add it when it is used." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a list of scanners that are enabled by default and a list of scanners that are not enabled by default. This way, we can have a list of scanners that are enabled by default and a list of scanners that are not enabled by default. This way, we can have a list of scanners that are enabled by default and a list of scanners that are not enabled by default. This way, we can have a list of scanners that are enabled by default and a list of scanners that are not enabled by default. This way, we can have a list of scanners that are enabled by default and a list of scanners that are not enabled by default. This way, we can have a list of scanners that are enabled by default and a list of scanners that are not enabled by default. This way, we can have a list of scanners that are enabled by default and a list of scanners that are not enabled by default. This way, we can have a list of scanners that are enabled by default and a list of scanners that are not enabled by default. This way, we can have a list of scanners that are enabled by default and a list of scanners that are", + "prediction": "I don't think it's necessary to add `non_exist_scanner` to the `scanners` list.", "reference": "More clear naming: NONEXISTENT_ENABLED" }, { @@ -107,55 +107,55 @@ "reference": "why is this change necessary?" }, { - "prediction": "I'm not sure what you mean by \"null response types are implemented\"", + "prediction": "@andrealin I think we should remove this hack, as it's not needed anymore.", "reference": "make a SchemaTypeNameConverter.getTypeNameForEmptyType() and call that here." }, { - "prediction": "I don't think this is necessary. I think it's better to use `Lang::getDefaultLanguage()->getLocale()` instead.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `Lang::getLanguage()` method to get the current language.", "reference": "Use braces on your conditional structures please" }, { - "prediction": "I'm not sure what you mean by \"whether to force saving the command history\". I think you meant to say \"whether or not to force saving the command history\".", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `DEFINE_bool` instead of `DEFINE_bool`.", "reference": "Great God, I have a question. This \".nebula_history\" file is used to save history commands. Is there a file size limit? When the file is large, does it take a long time to start initialization (loadHistory)? How did you think about this? Thx." }, { - "prediction": "I'm not sure what you mean by \"isType (token, TOKEN_OPEN_PAREN)\". I think you meant to say \"isType (token, TOKEN_OPEN_PAREN)\"", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a check for `isType (token, TOKEN_OPEN_PAREN)`. If it's not a `TOKEN_OPEN_PAREN` token, then it's not a `TOKEN_OPEN_PAREN` token.", "reference": "Isn't this the same check as two lines above?" }, { - "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to move it to a separate file.", + "prediction": "I'm not sure if this is the best place to put it, but I think it's a good idea to have it in the same place as the `flow_to_json` function, so that it can be called from anywhere in the codebase.", "reference": "Don't redefine, just import the existing one in `cmdline.py`. :)" }, { - "prediction": "I think this should be `responds = respond_to?(\"#{name}=\")` instead of `responds = aliased_fields.invert[name.to_s]`", + "prediction": "I'm not sure what you mean by \"responds = respond_to?\". I think you meant \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds = respond_to?\" or \"responds =", "reference": "why not call `respond_to?(\"#{name}=\")` from the `if` line?" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `CidrLauncher` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `CidrLauncher` class.", "reference": "This was properly set above as `.runfiles/` (with a fallback to workspace root dir) but never used past this line." }, { - "prediction": "I think this should be `public class MvxPagePresentationAttribute : MvxBasePresentationAttribute`", + "prediction": "I think this should be `public class MvxPagePresentationAttribute : MvxBasePresentationAttribute` instead of `public class MvxPagePresentationAttribute : MvxBasePresentationAttribute`", "reference": "Are all these namespaces required for this attribute?" }, { - "prediction": "I'm not sure if this is the best place to do this, but I think it's a good idea to log the stdout and stderr of the process.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to log the output of `stdout` and `stderr` in the `Beaker::Result` class.", "reference": "Given this may be used and printed in other ways, isn't `debug` more appropriate?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. The `clear` method should be called on the `blockDiskStore` struct, not on the `blockDiskStore` package.", + "prediction": "I think this should be `return err` instead of `return ioutil.RemoveAll(s.dir)`.", "reference": "Looks like this is unused? Did you mean to call it when clearing the block journal?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. You're setting up the `ExecutorLoader` and `ExecutorManager` objects, but then you're not using them in any way. Is there a specific reason you want to do this?", + "prediction": "I'm not sure I understand what you're trying to do here. What's the point of `executorLoader` here?", "reference": "why named alters? how about this.alerts = alerts?" }, { - "prediction": "I think this should be `if node != nil {` instead of `if node := mset.raftNode(); node != nil {`", + "prediction": "I think this should be `if node != nil { ... }` instead of `if node != nil { mset.sendCreateAdvisory() }`", "reference": "not sure if this has to be here or not tbh" }, { - "prediction": "I think we can remove the `if len(topicName) > 50` check.", + "prediction": "I think we can remove the `topicName` field from the `CreateTopic` function, as it's not used in the `newHarness` function.", "reference": "There's a better fix for this in #1741, which should replace this." }, { @@ -163,11 +163,11 @@ "reference": "Use swarm.Address not []byte as type, and construct it from actual byteslice or use swarm.NewAddress if it is constructed from hex-encoded string." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the directory is cleaned up after the test is done.", + "prediction": "I don't think we need to remove the dir here. We can just delete it after the test is done.", "reference": "It would be worth factoring this out to a function, but you don't have to do that here." }, { - "prediction": "I'm not sure what you mean by \"linkifyUri\" but I think it should be `linkifyUri(String text, int startPos, StringBuffer outputBuffer)`.", + "prediction": "I'm not sure I understand what you're trying to do here.", "reference": "There's no need for `final` in interfaces." }, { @@ -175,11 +175,11 @@ "reference": "Isn't this case handled as a custom tag in `Span.SetTag()` below? This switch is only for special tags that actually set `Span` properties." }, { - "prediction": "I'm not sure what you mean by \"when given, save the open windows even if auto_save.session is turned off\"", + "prediction": "I'm not sure what you mean by \"when given\". I think you meant to say `save=True`", "reference": "This shouldn't be changed." }, { - "prediction": "I'm not sure I understand what you mean by \"this file is part of Invenio\". Could you please provide more context?", + "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a separate file for this. It's not clear to me what the purpose of this file is, and I'm not sure if it's a good idea to have a separate file for this.", "reference": "This one is important `2: I102 copyright year is outdated, expected 2014 but got 2012`" }, { @@ -207,31 +207,31 @@ "reference": "Remind me why you are using CUDA vocabulary when naming these variables." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the feed filter is zero, and if it is, remove the feed from the feed counters.", "reference": "Please turn the iteration order around (instead of `0...size` to `size...0`). The reason is that this sometimes skips indices when removing an item. You can therefore end up with feeds that have counter 0 and are still displayed." }, { - "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to create a new pipeline with a subset of the original pipeline's solid_subset. Is this what you're trying to do? If so, I'm not sure I understand what you're trying to do here. I think you're trying to create a new pipeline with a subset of the original pipeline's solid_subset. Is this what you're trying to do? If so, I'm not sure I understand what you're trying to do here. I think you're trying to create a new pipeline with a subset of the original pipeline's solid_subset. Is this what you're trying to do? If so, I'm not sure I understand what you're trying to do here. I think you're trying to create a new pipeline with a subset of the original pipeline's solid_subset. Is this what you're trying to do? If so, I'm not sure I understand what you're trying to do here. I think you're trying to create a new pipeline with a subset of the original pipeline's solid_subset. Is this what you're trying to do? If so, I'm not sure I understand what you're trying to do here. I think you're trying to create", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to create a new pipeline with a subset of the original pipeline's solid_subset. Is that right? If so, how do you want to do that?", "reference": "this is a behavior change. solid_subset=[] represents an empty pipeline where as solid_subset=None is the full pipeline" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check to see if `CustomSettings` is null, and if it is, throw an exception.", + "prediction": "I think this should be `Logger.LogWarning` instead of `Logger.LogError`?", "reference": "this is a breaking change, any specific reason you want to do this?" }, { - "prediction": "I think we should remove the `tipSetAndState` field from the `nodeChainReader` interface.", + "prediction": "I think we can remove `GetTipSetStateRoot` and `PutTipSetAndState` from the `nodeChainReader` interface.", "reference": "Blocking: we still want read write separation. Node functions should absolutely not write to the chain store and the interface should reflect that. Only the syncer should have this capability in production code. It should be no problem to keep casting chainForTest to a read-write interface, or doing other function decomposition and automatic casting tricks." }, { - "prediction": "I think it's better to have `defaultOnDemandRequestPriority` and `lowestTriggerPrefetchPriority` in the same struct.", + "prediction": "I think we should use `defaultOnDemandRequestPriority` and `lowestTriggerPrefetchPriority` instead of `100` and `1` respectively.", "reference": "The PR description says the lowest on-demand request priority is `2^30`. Why the `-1` here?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move it to the `Player` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to move it to the `Player` class.", "reference": "checking health again? I think it is not necessary." }, { - "prediction": "I think this should be `if err != nil` instead of `if err != nil && time.Since(startTime) < 30*time.Second`", + "prediction": "I think this should be `log.WithError(err).Error(\"Failed to connect to Typha. Retrying...\")` instead of `log.WithError(err).Debug(\"Retrying to start Typha\")`.", "reference": "Need an `if err == nil {break}` above this line so that we don't log/sleep if the retry succeeds." }, { @@ -239,23 +239,23 @@ "reference": "to reiterate my point above, this class is not the actual provided Promise, but rather something a user can provide a Promise to/with. I think a name like `PromiseProvider` is more appropriate." }, { - "prediction": "I'm not sure if this is a good idea, but I think we should add this check to the `addDep` function as well. It's not clear to me why we'd want to do this, but I think it's a good idea.", + "prediction": "I'm not sure if this is needed or not, but I think it's a good idea to check if the target is still active before adding it to the queue. If it's not active, we can't add it to the queue.", "reference": "I guess we can only call this from a post-build function, but we might need to check that this target is to be built? I guess target A depends on B which has a post build. We `plz build :B` which adds C as a dep of A. Won't we queue C to be built even though it only needs to build if A needs to be built? That's kinda why I approached this the way I did. I trust you've thought about this but would be good to understand this a bit better." }, { - "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `pks.__class__.__name__ == 'StreamSocket'` to make sure we don't try to read from a non-stream socket.", "reference": "You should use `isinstance()` instead of comparing the class name to a string." }, { - "prediction": "I think this should be `if (el.nodeType === 11)` instead of `if ([`VIDEO`, `AUDIO`].includes(el.nodeName.toUpperCase()))`.", + "prediction": "I don't think we need to exclude `video` and `audio` el's.", "reference": "Why should audio and video elements always return `false` for `isHidden`?" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to register the `RootViewModel` in the constructor of the `App.xaml.cs` file. This way, the `RootViewModel` will be initialized before the `App.xaml.cs` file is loaded.", + "prediction": "I don't think we need to do this. We already have the `RootViewModel` in the `App.xaml.cs` file.", "reference": "This obviously won't work for all the other platforms." }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.", + "prediction": "I'm not sure what you're trying to do here. I don't think this is the right way to do it.", "reference": "Isn't he diamond operator Java7+?" }, { @@ -271,23 +271,23 @@ "reference": "This seems like an improved pattern :)" }, { - "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to verify the user's OpenID, but then redirect them to the OpenID provider to verify the user's OpenID again. Is that right?", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `open_id_authentication` function.", "reference": "`open_id_authentication` is no longer the name of the function, and it's not OpenID specific" }, { - "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to get the balance of the wallet, but you're also trying to get the balance of the pending transactions. I'm not sure what you're trying to do here. I think you're trying to get the balance of the wallet, but you're also trying to get the balance of the pending transactions. I'm not sure what you're trying to do here. I think you're trying to get the balance of the wallet, but you're also trying to get the balance of the pending transactions. I'm not sure what you're trying to do here. I think you're trying to get the balance of the wallet, but you're also trying to get the balance of the pending transactions. I'm not sure what you're trying to do here. I think you're trying to get the balance of the wallet, but you're also trying to get the balance of the pending transactions. I'm not sure what you're trying to do here. I think you're trying to get the balance of the wallet, but you're also trying to get the balance of the pending transactions. I'm not sure what you're trying to do here. I think you're trying to get the", + "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to add a new line to the text of the label. I think you want to do something like this: `wallet_balance_label->setText (wallet_balance_label->text () + \"\\nWallet pending: \" + wallet.format_balance (pending));`", "reference": "This didn't require corresponding changes to the test case(s)?" }, { - "prediction": "I don't think we need to add `EnvFile` to the `TaskConfig` struct. We can just use the `EnvFile` field in the `Task` struct.", + "prediction": "I'm not sure if this is the right place to add the `EnvFile` field. I think it should be in the `TaskConfig` struct, but I'm not sure if that's the right place to do it.", "reference": "A question! I think `string` totally works, but what do you think of `*string` for consistency?" }, { - "prediction": "I think we should remove the `Annotations` field from the `AWSResourceReference` struct.", + "prediction": "I think it's better to use `Annotations` instead of `Labels` in this case.", "reference": "Should this be: `aws.infrastructure.cluster.sigs.k8s.io` instead?" }, { - "prediction": "I'm not sure what you mean by \"shearing\" in this context.", + "prediction": "I'm not sure if this is correct, but I think it should be `Ef[1][2] = Ef[2][1] = 0.5 * h_rate[3]/domain->zprd;` instead of `Ef[1][2] = Ef[2][1] = 0.5 * h_rate[3]/domain->zprd;`", "reference": "Not clear on why this change is correct." }, { @@ -295,7 +295,7 @@ "reference": "Hi Simon. Whether this should return true depends on what byte buffers are used? The same applies to ByteBufferIndexInput, actually... I don't think you can generally tell whether the ByteBuffers the input operates on come from a mmap call or from somewhere else (even direct buffers don't have to be a result of mmap)." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think we need to add padding to the `Settings` component.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to add a `padding` property to the `Settings` component.", "reference": "All stories in this file also need to have the default padding." }, { @@ -303,15 +303,15 @@ "reference": "I don't think these asserts are necessary, because `subsurface_find_sibling` already searches in the parent. Or am I missing something?" }, { - "prediction": "I'm not sure what you mean by \"published\" in this context. Is it referring to when the episode is published on the site?", + "prediction": "I'm not sure what you mean by \"published\" in this context. Is this the same as \"published on\"?", "reference": "Should this be `number` instead of `id`?" }, { - "prediction": "I think this should be `if ((table) && (table->isExternalTable()))` instead of `if ((table) && (table->isExternalTable() && (! bindWA->inDDL()))).`", + "prediction": "I think this should be `if ((table) && (table->isExternalTable() && !bindWA->allowExternalTables()))`", "reference": "I have forgotten why we thought this restriction is necessary. A user registers a Hive/HBase table with us but is not able to use the table with the registered name in DML. Will UPDATE STATs will be on the original name too (and update stats code will find out registered name and use it for Table_uid?). This was the registration concept is almost like an internal implementation idea, at some point could even be done by some utility program for all existing Hive/hBase tables, and the user need not be aware of it? I am struggling with a user would want to register a table, if they cannot use it by that name." }, { - "prediction": "I think this should be `sim2app_dealloc_tx` and `app2sim_dealloc_rx` instead of `sim2app_dealloc_tx` and `app2sim_dealloc_rx`.", + "prediction": "I think this should be `sim2app_dealloc_tx` instead of `sim2app_portctrl_rsp_tx`.", "reference": "Should most of these non-globals be static?" }, { @@ -319,11 +319,11 @@ "reference": "Please do not approve PRs without tests!!!!" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `parent` instead of `win_id` in this case.", + "prediction": "I don't think this is necessary. The `parent` argument is only used to pass the `self` argument to the `WebEnginePage` constructor, so it doesn't make sense to pass it to the `WebEngineView` constructor.", "reference": "Now that you handle this in `webenginetab.py` you can undo all the changes in this file." }, { - "prediction": "I don't think this is a good idea. The `Application.launch` method is not thread-safe.", + "prediction": "I don't think we need to do this.", "reference": "I think we should log the exception to a log file instead of printing it. The current behavior (not catching the exception) should lead to an automatic print of the exception to the terminal/console." }, { @@ -331,11 +331,11 @@ "reference": "These changes to the resource helpers have some more far-reaching implications as they also affect calls made in hive-operator, I believe. It's probably OK still, though. Ideally, the resource helper would not be the one doing the logging, since it cannot know the severity, but that is well beyond something that we should tackle for this PR. I would rather have the hive-operator log warnings than have the syncsetinstance controller log errors." }, { - "prediction": "I think this should be `null` instead of `null, null`.", + "prediction": "I'm not sure what you mean by \"RESTRICT\" in this case.", "reference": "do you really want to change the behavior on foreign key ?" }, { - "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea to call `json_decref` on a `json_array`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `event_batch_destroy` as well.", "reference": "Looks like my bad. Thanks for fixing!" }, { @@ -343,7 +343,7 @@ "reference": "I think \"Don't replace variables ...\" would be cleaner." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to change the default value of the `projection` parameter to `3d` or `polar`. Is that what you're trying to do? If that's the case, then I think you should just change the default value of the `projection` parameter to `3d` or `polar`.", + "prediction": "I don't think we need to change the default value of `projection` to `None`.", "reference": "Do you validate the possible strings? I've not read the code below but we should make sure if a string is supplied it is validate..." }, { @@ -351,35 +351,35 @@ "reference": "I'd recommend using generateDataDiskName here as well -- might as well benefit from the safety that it gives to protect yourself from future changes to w.ID()." }, { - "prediction": "I think this should be `Long` instead of `Long?`?", + "prediction": "I don't think this is needed anymore. The `pos()` method should return `null` if the file was not read from a manifest.", "reference": "qq: do we want to include anything in the name to indicate that it is a position in the manifest?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `onResume` method of the `PlatformActivity` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `onPause` method.", "reference": "These logs should probably use the `LOGTAG`" }, { - "prediction": "I'm not sure what you mean by `golang.zx2c4.com/wireguard/device` and `golang.zx2c4.com/wireguard/tun`", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `wireguard.go` file, since it's related to the `wireguard-go` package.", "reference": "From this, it was clear, that we are using our version of wireguard-go. And now it looks like we are using original packages which is confusing." }, { - "prediction": "I think this should be `ErrorCodes` instead of `ErrorCodes.InternalError`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `ResultWrapper` class.", "reference": "Any particular reason for this? This potentially will make harder to investigate users issues" }, { - "prediction": "I think it's better to use `Blockly.highlightedConnection_` instead of `Blockly.highlightedConnection_ != closestConnection`.", + "prediction": "I'm not sure what you mean by \"grayed-out blocks instead of highlighting the connection\"; I think you meant to say \"grayed-out connections instead of highlighting the blocks\".", "reference": "Do you also need to check if Blockly.localConnection_ is non-null?" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bit of a misnomer to call it a \"core\" class. It's more of a \"world\" class. I think it would be more appropriate to call it a \"core\" class if you want to refer to it as such. If you want to refer to it as a \"world\" class, you could call it `World::Core` or something like that.", + "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bit of a misnomer to call it a \"core\" class. It's more of a \"world\" class. I think it would be better to call it something like \"Core::World\" or \"Core::Global\".", "reference": "Not really a container, and it's not just about non-config data, not sure of a better description, @myronmarston ?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `Readable` or `GetObjectCommand` or `ListObjectsV2Command` or `HeadObjectCommand` or `PutObjectCommand` or `DeleteObjectCommand` or `DeleteObjectsCommand` or `Buffer` or `JoplinError` or `basename` or `shim` or `require` or `./path-utils` or `./shim` or `./JoplinError` or `./require` or `./path-utils` or `./shim` or `./JoplinError` or `./require` or `./path-utils` or `./shim` or `./JoplinError` or `./require` or `./path-utils` or `./shim` or `./JoplinError` or `./require` or `./path-utils` or `./shim` or `./JoplinError` or `./require` or `./path-utils` or `./shim` or `./JoplinError` or `./require` or `./path-utils` or `./shim` or `./JoplinError`", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `s3` package.", "reference": "The desktop app will load this fine. on iOS I get `TypeError: undefined is not an object (evaluating '_$$_REQUIRE(_dependencyMap[8], \"stream\").Readable.Readable')` if I change it to `const Readable = require('stream').Readable;` or `const { Readable } = require('stream');` I get undefined errors from the stream on iOS: `[TypeError: stream.on is not a function. (In 'stream.on(\"data\", function (chunk) { return chunks.push(chunk); })', 'stream.on' is undefined)]` What am I missing?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `store` struct.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `store` struct.", "reference": "this is needed since the chunk feeder shares memory across calls to the pipeline. this is in order to avoid multiple allocations. this change mimics the behavior of shed and localstore, and copies the data from the call into the in-memory store" }, { @@ -387,79 +387,79 @@ "reference": "wut. We can do this at the beginning of tests if we want right? Why are we depending on init?" }, { - "prediction": "I think we can remove the `if acc != nil && acc != srv.gacc` check.", + "prediction": "I think we can remove the `srv.mu.Lock()` and `srv.mu.Unlock()` here.", "reference": "Same trick here IMO." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to have `element` and `origin` be `nil` in this case.", "reference": "Should be `@origin = element || origin || POINTER`" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we", + "prediction": "I don't think we need to call `singleCstorSPCUpgrade` here. I think we should call `bulkCstorSPCUpgrade` here.", "reference": "this example needs a fix?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to call `wlr_xdg_toplevel_send_close` after `wlr_xdg_surface_send_close`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to call `wlr_xdg_toplevel_send_close` after `wlr_xdg_surface_send_close`.", "reference": "Is it safe to assume this surface is a toplevel?" }, { - "prediction": "I'm not sure what you're trying to do with `pj_ctx_clone()`, but I don't think it's a good idea to clone a `projCtx`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `pj_ctx_t` struct.", "reference": "we don't need that function" }, { - "prediction": "I think it's better to use `@Override` for `family()` instead of `@Override` for `platform()`.", + "prediction": "I think it's better to use `@Override` for the `family()` method.", "reference": "we'll also have to think about adding \"Windows Server 2014\" or whatever they come up with later." }, { - "prediction": "I think this should be `fetchActiveFlowByExecId(int execId)` instead of `fetchActiveFlowByExecId(int execId) throws ExecutorManagerException`.", + "prediction": "`fetchActiveFlowByExecId` should be `fetchActiveFlowByExecId(int execId)`", "reference": "curious do we have an API to fetch an inactive flow?" }, { - "prediction": "I think it's better to use `if (obj && typeof obj === 'object' && !isValidElement(obj) && ((obj.props && obj.type) || obj.text != null)) {` instead of `if (obj && typeof obj === 'object' && !isValidElement(obj) && ((obj.props && obj.type) || obj.text != null)) {`", + "prediction": "I think this should be `if (obj && typeof obj === 'object' && !isValidElement(obj) && ((obj.props && obj.type) || obj.text != null))`", "reference": "This branch is not needed anymore because every `vnode` that passes through `h` in compat or core will have the `$$typeof`-property now ." }, { - "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `getComposedParent` instead of `node.parentNode`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `shouldMatchElement` function.", "reference": "Did you mean to use `hasAttribute`? You shouldn't. This does not improve performance and it messes with the readability." }, { - "prediction": "I'm not sure what you mean by `QEvent` and `QKeySequence` in this context. `QEvent` is a type of event, and `QKeySequence` is a type of key sequence. `QKeySequence` is used to represent a sequence of key presses, and `QEvent` is used to represent a specific type of event, such as a mouse click or a keyboard press.", + "prediction": "I don't think we need to import `QNetworkCookieJar` here.", "reference": "Please import modules and not classes (except for Qt stuff)." }, { - "prediction": "Shouldn't this be `jjtAccept(JavaParserVisitor visitor, Object data)` instead of `jjtAccept(JavaParserVisitor visitor, Object data)`?", + "prediction": "I don't think this is necessary. The `jjtAccept` method doesn't need to be overridden. If you want to override it, you can do so in the `AbstractJavaNode` class.", "reference": "Hm... why do we have a \"DummyJavaNode\" in src/main? Looks like, this should have gone into src/test...." }, { - "prediction": "I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure", + "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to add a new field to the `v1alpha1.Cas` struct, but I'm not sure if that's the best way to do it.", "reference": "This seems meaningless. If we cannot add any info let us remove this." }, { - "prediction": "I don't think this is needed.", + "prediction": "I don't think this is needed, since we already have `GetLabels` and `GetPorts` in the `Container` struct.", "reference": "Can you rename `Ports` to `PortsUnsafe`?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `Base64.urlsafe_decode64` instead of `Base64.urlsafe_encode64`.", + "prediction": "Shouldn't this be `sig: Base64.urlsafe_encode64` instead of `sig: OpenSSL::Digest::SHA256.new`?", "reference": "This feels like it could be moved out to your first gem!" }, { - "prediction": "I don't think this is a good idea. The `poll` method should return `Optional`, not `Optional`.", + "prediction": "I don't think this is necessary.", "reference": "The expected behaviour for `poll` would be to match what `Deque` does, which is: > Retrieves and removes the head of the queue represented by this deque As such, you shouldn't need the `RequestId` here." }, { - "prediction": "I think we can remove the `use strict` at the top of the file.", + "prediction": "I think this should be `return arr1.concat(arr2).filter((elem, pos, arr) => arr.indexOf(elem) === pos);`", "reference": "This is super minor, but it'd be nice if this iterated over an arbitrary number of array inputs." }, { - "prediction": "I think it's better to use `NULL_TERMINATE_BUFFER` instead of `NULL_TERMINATE_BUFFER(buf)`.", + "prediction": "I'm not sure what you mean by `NULL_TERMINATE_BUFFER(buf);` and `i = readlink(buf, buf, BUFFER_SIZE_ELEMENTS(buf));`. I think you meant `NULL_TERMINATE_BUFFER(buf);` and `i = readlink(buf, NULL_TERMINATE_BUFFER(buf), BUFFER_SIZE_ELEMENTS(buf));`.", "reference": "What is the problem here? The commit message has strange wording \"readlink is defined with restrict pointers\": do you mean \"restricted\"? Is that a well-defined language term? I'm not sure what it means." }, { - "prediction": "I'm not sure what you're trying to do with this, but it looks like you're trying to create a `NameFormatter` for Ruby. I'm not sure what you're trying to do with this, but it looks like you're trying to create a `NameFormatter` for Ruby. I'm not sure what you're trying to do with this, but it looks like you're trying to create a `NameFormatter` for Ruby. I'm not sure what you're trying to do with this, but it looks like you're trying to create a `NameFormatter` for Ruby. I'm not sure what you're trying to do with this, but it looks like you're trying to create a `NameFormatter` for Ruby. I'm not sure what you're trying to do with this, but it looks like you're trying to create a `NameFormatter` for Ruby. I'm not sure what you're trying to do with this, but it looks like you're trying to create a `NameFormatter` for Ruby. I'm not sure what you're trying to do with this, but it looks like you're trying to create a `NameFormatter` for Ruby. I'm not sure what you're trying to do with this, but it looks", + "prediction": "I don't think we need to use `ImmutableSet` here. We can just use `Set` here.", "reference": "Why are we not wrapping here?" }, { - "prediction": "I don't think this is necessary.", + "prediction": "I don't think this is needed.", "reference": "I though that all data objects are being unified in the fashion where all default values are initialized in constructor, are not they?" }, { @@ -467,19 +467,19 @@ "reference": "Does this file actually need to be committed to git? Having to run `make generate` is rather tedious on each PR and it conflicts easily." }, { - "prediction": "I think it's better to use `os.Getenv(\"GOOGLE_APPLICATION_CREDENTIALS\")` instead of `os.Getenv(\"GOOGLE_APPLICATION_CREDENTIALS\")`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the JSONKeyPath is set, and if it is, then we should use it. If not, then we should use the path from the GOOGLE_APPLICATION_CREDENTIALS environment variable.", "reference": "We don't need this anymore, as Google's library handles various auth mechanisms for us. We'll be less explicit about why we're failing but we gain support for several authentication methods- swings and roundabouts!" }, { - "prediction": "I'm not sure what you mean by \"GPUs\" in this context. Could you please clarify?", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a default value for the `Root` field in the `Volumes` map. This way, if the `socket_dir` is not set, it will default to `/var/lib/docker-volumes`.", "reference": "No need to speficy attribute here. Moreover in yaml it is default to use lowercase names." }, { - "prediction": "I don't think we need to use `Task` here. We can just use `async`/`await` here.", + "prediction": "I don't think we need to use `Task` here. We can just use `Task.Run` instead.", "reference": "In general I'm a trying to understand the reason behind this PR. Looks like if a blob (name) already exists we check if the contents are identical? In what scenarios this is not the case? When we want to publish a package/asset that has changed but still we want to use the same version?" }, { - "prediction": "I think it's better to use `urllib2.urlopen` instead of `urllib2.build_opener` and `urllib2.open` because `urllib2.build_opener` is deprecated and `urllib2.open` is deprecated as well.", + "prediction": "I think we can remove the `re.M` from the regular expression.", "reference": "Can rename `req` to be `opener`, since that is the object, and it wraps `req` internally?" }, { @@ -491,63 +491,63 @@ "reference": "This would return a tuple of two dictionaries. You need to combine them and return a dictionary" }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it would be good to add a comment here explaining what this is doing.", + "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to move it to the root of the package.", "reference": "What do you think of moving the example to the help text of the prompt? and the prompt itself can be \"What is your application's GitHub repository URL?\"" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I think this is a bit of a red herring here. We don't care about the timestamp, we just want to make sure that the span is created and that it's not null.", "reference": "Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs." }, { - "prediction": "I'm not sure what you mean by \"atomProp:\". Is it a property of the atom, or a property of the molecule? If it's a property of the molecule, then I think we should be able to parse it. If it's a property of the atom, then I don't think we should be able to parse it. I'm not sure what you mean by \"atomProp:\". Is it a property of the atom, or a property of the molecule? If it's a property of the molecule, then I think we should be able to parse it. If it's a property of the atom, then I don't think we should be able to parse it. I'm not sure what you mean by \"atomProp:\". Is it a property of the atom, or a property of the molecule? If it's a property of the molecule, then I think we should be able to parse it. If it's a property of the atom, then I don't think we should be able to parse it. I'm not sure what you mean by \"atomProp:\". Is it a property of the atom, or a property of the molecule? If it's a property of the molecule, then I think we should be able to parse", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `std::string(first, first + 9) == \"atomProp:\"` instead of `std::string(first, first + 9) == \"atomProp:\" && std::string(first + 9, last) == \"atomProp:\"`", "reference": "Nice use of std::distance. I'm a bit worried about first += 9 though." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea to add this to the `k8s-app` and `app.kubernetes.io/part-of` labels.", "reference": "Shouldn't this be `app.kubernetes.io/managed-by` as prometheus-operator manages this resource, but this resource isn't a part of prometheus-operator?" }, { - "prediction": "I'm not sure what you mean by \"don't instrument nested methods that belong to the same stacktrace\"", + "prediction": "I'm not sure I understand what you're trying to do here. Can you clarify?", "reference": "As long as we're being extra-vigilant about NREs, should we check that `httpMethod` and `requestUri` are not null?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to add a new command to the `ioctl` package, but I'm not sure if it's a good idea to do so.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add a `--help` flag to the `ioctl` command. This will allow the user to know what the command does and how to use it.", "reference": "No need to have `xrc20` alias" }, { - "prediction": "I think this should be `define_maybe_optional_selector_field` instead of `define_context_context_cls`?", + "prediction": "I think this should be `define_context_context_cls` instead of `define_maybe_optional_selector_field`.", "reference": "the naming convention I'm been adopting if `_type` for instances of these classes. So maybe `context_config_type` is a better name for this fn" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don", + "prediction": "I don't think we need to use `AbstractBlockScheduler` here. We can just use `BlockScheduler` directly.", "reference": "Don't call it GPU mining, call it `externalMining`, here and throughout." }, { - "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to set the `imageMaxWidth`, `imageMaxHeight`, and `imageQuality` options for the `media` resource. Is this what you're trying to do?", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to set the `imageMaxWidth`, `imageMaxHeight`, and `imageQuality` options for the `media` resource. I'm not sure what you're trying to do here, but it looks like you're trying to set the `imageMaxWidth`, `imageMaxHeight`, and `imageQuality` options for the `media` resource. I'm not sure what you're trying to do here, but it looks like you're trying to set the `imageMaxWidth`, `imageMaxHeight`, and `imageQuality` options for the `media` resource. I'm not sure what you're trying to do here, but it looks like you're trying to set the `imageMaxWidth`, `imageMaxHeight`, and `imageQuality` options for the `media` resource. I'm not sure what you're trying to do here, but it looks like you're trying to set the `imageMaxWidth`, `imageMaxHeight`, and `imageQuality` options for the `media` resource. I'm not sure what you're trying to do here, but it looks like you're trying to set the `imageMaxWidth`, `imageMaxHeight", "reference": "`within this with` typo, should be `within this width`" }, { - "prediction": "I think we should remove the `+k8s:openapi-gen=false` here.", + "prediction": "I think we should use `+k8s:openapi-gen=false` instead of `+k8s:openapi-gen=true`.", "reference": "how come this is false?" }, { - "prediction": "I'm not sure what you mean by `typeOf(args[i]) !== types[i]`. I think you meant to say `typeOf(args[i]) === types[i]`.", + "prediction": "I'm not sure if this is a good place to put this, but I think we should move it to `node-fetch` as well.", "reference": "How about `Object.prototype.toString`? Or using the `typeof` operator?" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new `ReporterKBPKI` with a `notifySyncBuffer` channel and a `canceler` function. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new `ReporterKBPKI` with a `notifySyncBuffer` channel and a `canceler` function. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new `ReporterKBPKI` with a `notifySyncBuffer` channel and a `canceler` function. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new `ReporterKBPKI` with a `notifySyncBuffer` channel and a `canceler` function. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new `ReporterKBPKI` with a `notifySyncBuffer` channel and a `canceler` function. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new `Reporter", + "prediction": "I'm not sure what you mean by `ctx` here. It's not used anywhere in the code.", "reference": "I know @jzila suggested this, but I disagree: you're really not supposed to save a context in a struct. Can you get by with just saving the `Done()` channel instead? The `ctx` should continue to be passed around explicitly." }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place", + "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place", "reference": "This check isn't right though." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `DynamicLangXApiView` class, since it's used by the `DynamicLangXApi` class as well.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `DynamicLangXApiView` class, since that's where the `codeGenVersion()` method is defined.", "reference": "maybe `toolkitVersion` instead? It doesn't necessarily have to be called that in the generated code, but in the view model classes, I think it makes it clearer that it is the version of toolkit itself." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way", + "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `this.uppy.emit('upload-success', file, uploadResp)` instead of `this.uppy.emit('upload-success', file, body, uploadURL)`.", "reference": "the response data was added intentionally in #612, i think we could keep the `setFileState` stuff here as a special case, at least for now" }, { @@ -559,7 +559,7 @@ "reference": "This line changed due to go formatting. Format was not there earlier." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to parse the configuration input and set up static upstreams for the proxy middleware. I'm not sure what you're trying to do here, but it looks like you're trying to parse the configuration input and set up static upstreams for the proxy middleware. I'm not sure what you're trying to do here, but it looks like you're trying to parse the configuration input and set up static upstreams for the proxy middleware. I'm not sure what you're trying to do here, but it looks like you're trying to parse the configuration input and set up static upstreams for the proxy middleware. I'm not sure what you're trying to do here, but it looks like you're trying to parse the configuration input and set up static upstreams for the proxy middleware. I'm not sure what you're trying to do here, but it looks like you're trying to parse the configuration input and set up static upstreams for the proxy middleware. I'm not sure what you're trying to do here, but it looks like you're trying to parse the configuration input and set up static upstreams for the proxy middleware. I'm not sure what you're trying to do here", + "prediction": "I don't think we need to change the type of `Upstream` in this case. We can just use `*Upstream` instead of `Upstream`.", "reference": "The name \"Without\" in code is a little nebulous. Maybe something more descriptive like TrimPrefix or StripPrefix or WithoutPathPrefix or something like that. (Thoughts?)" }, { @@ -567,7 +567,7 @@ "reference": "is this test in the move tests? I see what you mean then - it works, but I wonder if we won't lose track that it's being tested here." }, { - "prediction": "I think we should remove the `map[string]string` from the `SecurityGroups` field.", + "prediction": "I think it's better to use `map[string]string` instead of `map[string]interface{}`.", "reference": "I'm not sure if this wanted to be `json:\"tags\"` (which I'd set in my PR) or `json:\"tag\"` that someone elses PR had set. Given that the rest of the fields had their JSON field name set to the same as the struct field name, I opted for `tags`." }, { @@ -575,7 +575,7 @@ "reference": "since the logic here and in `Proposal` is exactly the same, do you think it makes sense for us to include it elsewhere? I am not opposed to duplicated code when it makes sense, but the reason I first identified this was that I was looking for code in NCR::WorkOrder that was not specific to Work Orders. Seems like fiscal year logic might be helpful for reporting for other clients. In that case, we'd want this scope on those client data classes as well. Might be wrong to include this in the FiscalYear mixin, but it does seem like it should be outside of Proposal and WorkOrder. Does that make sense?" }, { - "prediction": "I think we can remove the `static_callback` method. It's not needed anymore.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to add a timeout to the `connect_to_rabbitmq` method.", "reference": "there is no static method as a go between -- how does this work?" }, { @@ -583,15 +583,15 @@ "reference": "Can you please change the name of this class to be something else?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `h2o_iovec_t` in this way.", + "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason you're using `h2o_iovec_t` here instead of `h2o_iovec`?", "reference": "I think we might prefer generalizing the interface rather than creating an exception. Current design of `h2o_next_token` assumes the input to be a comma-separated list, and allows the caller to specify a different separator when parsing a nested list. As I understand, what we are trying to attain in this PR is to have a way of parsing a flat list of semicolon-separated list. Assuming that is the case, I think it would be better to change the API of the function to accept two separators (i.e. inner and outer), where for our existing use-cases `outer` would be `,`." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to cache the blocks and headers in a way that allows you to search for the best known block and header in O(1) time. Is this what you're trying to achieve?", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea to use `LruCache` and `LruCache`. It's not clear to me what you're trying to achieve with this change, but I think it's a bad idea to use `LruCache` and `LruCache`. It's not clear to me what you're trying to achieve with this change, but I think it's a bad idea to use `LruCache` and `LruCache`. It's not clear to me what you're trying to achieve with this change, but I think it's a bad idea to use `LruCache` and `LruCache`. It's not clear to me what you're trying to achieve with this change, but I think it's a bad idea to use `LruCache` and `LruCache`. It's not clear to me what you're trying to achieve with", "reference": "why not recycling? I Lru cache now recycling?" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `consumer` struct.", + "prediction": "I don't think we need to check for `PaymentVersionV3` here.", "reference": "Why it is now called `PaymentVersionV3`?" }, { @@ -599,43 +599,43 @@ "reference": "changed for debug purpose?" }, { - "prediction": "I don't think this is necessary. The `OnEnd` method is called by the `OnShutdown` method, so we don't need to call `base.OnShutdown(timeoutMilliseconds)` in the `OnEnd` method.", + "prediction": "I don't think this is necessary. The `OnShutdown` method is called by the `OnEnd` method, which is called by the `OnStart` method, which is called by the `OnStart` method, which is called by the `OnStart` method, which is called by the `OnStart` method, which is called by the `OnStart` method, which is called by the `OnStart` method, which is called by the `OnStart` method, which is called by the `OnStart` method, which is called by the `OnStart` method, which is called by the `OnStart` method, which is called by the `OnStart` method, which is called by the `OnStart` method, which is called by the `OnStart` method, which is called by the `OnStart` method, which is called by the `OnStart` method, which is called by the `OnStart` method, which is called by the `OnStart` method, which is called by the `OnStart` method, which is called by the `OnStart` method, which is called by the `OnStart` method, which is called by the `OnStart` method, which", "reference": "@cijothomas I needed a way to set the Exporter.ParentProvider when the Processor's gets set. Internal to SDK though." }, { - "prediction": "I think this should be `node_based_graph.GetEdgeData(eid).flags.road_classification.IsRampClass()`", + "prediction": "I think it's better to use `node_based_graph.GetEdgeData(eid).flags.road_classification.IsLinkClass()` instead of `node_based_graph.GetEdgeData(eid).flags.road_classification.IsRampClass()`", "reference": "Talking through this scenario with @srividyacb and she's wondering if there should also be a check of `(from_trunk && node_based_graph.GetEdgeData(eid).flags.road_classification.IsLinkClass())` as highways with trunk classifications can also have this scenario." }, { - "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to", + "prediction": "I'm not sure what you're trying to do here. I don't think we need to change anything here.", "reference": "where does `master_certname` come from?" }, { - "prediction": "I think it's better to keep the `__all__` list in the `__init__.py` file. This way, we don't have to worry about the `__all__` list in the `__init__.py` file.", + "prediction": "I don't think we need to add `HRNet` to the `__all__` list.", "reference": "The line breaking is unnecessary." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to load the label idx first, but then you're trying to load the rest of the data. I'm not sure what you're trying to do here. I think you're trying to load the label idx first, but then you're trying to load the rest of the data. I'm not sure what you're trying to do here. I think you're trying to load the label idx first, but then you're trying to load the rest of the data. I'm not sure what you're trying to do here. I think you're trying to load the label idx first, but then you're trying to load the rest of the data. I'm not sure what you're trying to do here. I think you're trying to load the label idx first, but then you're trying to load the rest of the data. I'm not sure what you're trying to do here. I think you're trying to load the label idx first, but then you're trying to load the rest of the data. I'm not sure what you're trying to do here. I think you're trying to load the label idx first, but then you're trying to load the rest of", + "prediction": "I'm not sure what you mean by \"first line\" here. I think you meant to say \"first line of the file\" or \"first line of the header\" or something like that.", "reference": "why not enable split by space here ?" }, { - "prediction": "I think this should be `if (value != FPGA_INTEGRATED_DEVICEID)` instead of `if (value != FPGA_DISCRETE_DEVICEID)`.", + "prediction": "I think this should be `if (value != FPGA_INTEGRATED_DEVICEID || value != FPGA_DISCRETE_DEVICEID)` instead of `if (value != FPGA_INTEGRATED_DEVICEID && value != FPGA_DISCRETE_DEVICEID)`", "reference": "Shouldn't the operator be && ?" }, { - "prediction": "I think this should be `exit_status = 0` instead of `exit_status = 1`?", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `vagrant` module.", "reference": "My best guess is that you want to use host.name in these parts to get the name of the host ?" }, { - "prediction": "I think we should remove the `make([]byte, 32)` here.", + "prediction": "I think we should remove the `if !bytes.Equal(data[offset:offset+32], make([]byte, 32))` check.", "reference": "IMO this edge case handling could remain here, just instead of overwriting the `n.nodeType`, the `makeEdgeType` method of `n` should be called, so `n.nodeType = nodeTypeEdge` -> `n.makeEdge()`" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `showAutoDownloadReport` boolean to the `DownloadService` class.", + "prediction": "I think it's better to use `UserPreferences.showDownloadReport()` instead of `UserPreferences.showAutoDownloadReport()`.", "reference": "Just wondering... The two kinds of notifications are now quite different (Channel, text, maybe even icon). Would it make sense to extract the auto download notification to a new class instead of handling everything in the existing `notificationManager`? I have not checked if this will lead to a lot of code duplication, though." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea.", + "prediction": "I don't think this is necessary. We can just use `transport.RequestFeatures` directly.", "reference": "Do we need to put this on the Call? We only need the API communication between the Encoding and the Transports which is currently done through the Transport.Request. The Call is used by users right?" }, { @@ -643,15 +643,15 @@ "reference": "`ctx` is unused in GenerateAPIKey" }, { - "prediction": "I'm not sure what you mean by \"cfg\" in this context. Could you please clarify?", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the DB is already initialized. If it is, then we can just return the existing DAO. Otherwise, we need to create a new DAO.", "reference": "Can you judge the type of error?" }, { - "prediction": "I think this should be `np.convolve(data, [0.5, 0.5], 'valid')` instead of `np.convolve(data, [0.5, 0.5], 'valid')[:-1] + np.diff(data)/2.`", + "prediction": "I think this should be `data[:-1] + np.convolve(data, [0.5, 0.5], 'valid')` instead of `data[:-1] + np.convolve(data, [0.5, 0.5], 'valid')`", "reference": "Much simpler than a weird and confusing ``convolve`` call!" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to mock `Suspender1.render` and `Suspender2.render`, but you're not actually calling them.", + "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to make sure that `Suspender1.prototype.render` and `Suspender2.prototype.render` are called at least twice.", "reference": "Huh, this seems weird to me... Surely the suspenders render was called again in order to get the new `
Hello second 2
` output... Imma take a peak at these tests to understand what's going on" }, { @@ -659,19 +659,19 @@ "reference": "Since this is just a helper function to create text, perhaps this could live in a helper? I noticed that we have a few other error/message creators in the application controller as well, but I think this type of function should be re-factored to be part of a helper." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use a template like this. It's not clear to me what you're trying to do here.", + "prediction": "I'm not sure what you mean by \"template used to format the message information\". It's not a template, it's just a string that is used to format the message information.", "reference": "Will this mess up parsing the messages by other editors? (vscode, vim ...)" }, { - "prediction": "I'm not sure why we need to set up gems in the Gemfile. We can just run `bundle install` and it will do the right thing.", + "prediction": "I'm not sure why we need to set this up, but I think it's a good idea to do so.", "reference": "Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { - "prediction": "I think we can remove the `ContinueWith` call here.", + "prediction": "I think this should be `ContinueWith((task, state) => _filteredStream.CopyToAsync(_socketInputStream, block).ContinueWith((task, state) => _filteredStream.CopyToAsync(_socketInputStream, block).ContinueWith((task, state) => _filteredStream.CopyToAsync(_socketInputStream, block).ContinueWith((task, state) => _filteredStream.CopyToAsync(_socketInputStream, block).ContinueWith((task, state) => _filteredStream.CopyToAsync(_socketInputStream, block).ContinueWith((task, state) => _filteredStream.CopyToAsync(_socketInputStream, block).ContinueWith((task, state) => _filteredStream.CopyToAsync(_socketInputStream, block).ContinueWith((task, state) => _filteredStream.CopyToAsync(_socketInputStream, block).ContinueWith((task, state) => _filteredStream.CopyToAsync(_socketInputStream, block).ContinueWith((task, state) => _filteredStream.CopyToAsync(_socketInputStream, block).ContinueWith((task, state) => _filteredStream.CopyToAsync(_socketInputStream, block).ContinueWith((task, state) => _filteredStream.CopyToAsync(_socketInputStream, block).ContinueWith((task, state) => _filteredStream.CopyToAsync(_socketInputStream, block).ContinueWith((", "reference": "Why can the pool be null?" }, { - "prediction": "I'm not sure I understand what you're trying to do with this class. It seems like you're trying to create a new class that inherits from `ia2Web.Ia2Web` and overrides the `_get_states` method to add the `readonly` state to the list of states. Is this what you're trying to do? If so, what is the purpose of this new class?", + "prediction": "I'm not sure I understand what you're trying to do here.", "reference": "It might be good to have a note here: > work-around for issue #7562 allowing us to differentiate presentational lists from interactive lists (such as of size greater 1 and ARIA list boxes). In firefox, this is possible by the presence of a read-only state, even in content editable." }, { @@ -687,47 +687,47 @@ "reference": "We've avoided including h2o headers in BPF programs because it's a runtime dependency. However, IIRC, this is because h2olog was maintained in the separate repository so that h2olog did not know where h2o was installed. Now h2olog can use `H2O_ROOT`, we should add it to BCC's `cflags` in order to include h2o headers in BPF programs." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `ThanosRulerSpec` struct.", + "prediction": "I'm not sure why we need this field. Is there a reason why we need it?", "reference": "I think the docstring here should include the CLI arg `--alert.query-url` just to make it clear to users which setting this uses." }, { - "prediction": "I think we can remove the `for` loop here, as it's not really needed.", + "prediction": "I think this should be `m.members` instead of `m.externalNodeCIDRs`?", "reference": "Same change just above?" }, { - "prediction": "I don't think this is a good idea.", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `await engine.search('l')` instead of `await engine.search('\"\u043b\"')`.", "reference": "Could you check the result content rather than just the number of search results please? For example with this test if the search engine suddenly starts returning \"latin n\" for both queries, we won't know about it." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `spiffe://example.org/` prefix for all of these domains.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `spiffe://example.org/test/id` for the `agentlessID` and the `spiffe://example.org/spire/agent/test/id` for the `agentID` and the `spiffe://example.org/spire/server` for the `serverID`.", "reference": "nit: I think that `workloadID` should suffice for this test... that's what we'd be issuing anyways" }, { - "prediction": "I'm not sure what you mean by \"creating a new mentor\"", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a new mentor, but you're not actually creating a new mentor. You're creating a new mentor, but you're not actually creating a new mentor. You're creating a new mentor, but you're not actually creating a new mentor. You're creating a new mentor, but you're not actually creating a new mentor. You're creating a new mentor, but you're not actually creating a new mentor. You're creating a new mentor, but you're not actually creating a new mentor. You're creating a new mentor, but you're not actually creating a new mentor. You're creating a new mentor, but you're not actually creating a new mentor. You're creating a new mentor, but you're not actually creating a new mentor. You're creating a new mentor, but you're not actually creating a new mentor. You're creating a new mentor, but you're not actually creating a new mentor. You're creating a new mentor, but you're not actually creating a new mentor. You're creating a new mentor, but you're not actually creating a new mentor. You're creating a new mentor, but you're not actually creating a new mentor. You're", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { - "prediction": "I think this should be moved to `ClassTypeResolver` instead of `JavaParserVisitorAdapter`.", + "prediction": "I think it's better to catch `ClassNotFoundException` and `NoClassDefFoundError` separately.", "reference": "We should have a rule to detect identical catch branches" }, { - "prediction": "I think it's a good idea to add a `RetryDelayInSeconds` property to the `PublishFlatContainer` property.", + "prediction": "I think we should remove the `RetryAttempts` and `RetryDelayInSeconds` from the `PublishFlatContainer` property.", "reference": "remove these from the targets file." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add a comment to explain what the change does.", + "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea to add it here. I'm not sure if this is the right place to add this, but I think it's a good idea to add it here. I'm not sure if this is the right place to add this, but I think it's a good idea to add it here. I'm not sure if this is the right place to add this, but I think it's a good idea to add it here. I'm not sure if this is the right place to add this, but I think it's a good idea to add it here. I'm not sure if this is the right place to add this, but I think it's a good idea to add it here. I'm not sure if this is the right place to add this, but I think it's a good idea to add it here. I'm not sure if this is the right place to add this, but I think it's a good idea to add it here. I'm not sure if this is the right place to add this, but I think it's a good idea to add it here. I'm not sure if this is the right place to add this", "reference": "now that we have the signature in the hive messages, it might be that this must be drastically reduced, since there are limits on the protobuf reader/writers i believe" }, { - "prediction": "I'm not sure why we're including `google-auth` in the `REQUIRED_PACKAGES` list. Is there a reason to include it in the `NAMESPACES_PACKAGES` list as well?", + "prediction": "I'm not sure if this is necessary, but I think we should add `google-auth-httplib2==0.0.3` to the `REQUIRED_PACKAGES` list.", "reference": "I recommend that we move this to be optional, as other users might not need it. Can you look at `OPTIONAL_PACKAGES` section, around line 68?" }, { - "prediction": "I don't think this is a good idea. The `Optional` class is not meant to be used in this way. It's meant to be used for things like `Optional.ofNullable()`, `Optional.of()`, `Optional.empty()`, `Optional.get()`, `Optional.getOrDefault()`, `Optional.ofFirst()`, `Optional.ofLast()`, `Optional.ofFirstOrEmpty()`, `Optional.ofLastOrEmpty()`, `Optional.ofFirstOrLast()`, `Optional.ofLastOrFirst()`, `Optional.ofFirstOrLastOrEmpty()`, `Optional.ofLastOrFirstOrEmpty()`, `Optional.ofFirstOrLastOrLastOrEmpty()`, `Optional.ofLastOrFirstOrLastOrEmpty()`, `Optional.ofFirstOrLastOrLastOrLastOrEmpty()`, `Optional.ofLastOrFirstOrLastOrLastOrLastOrEmpty()`, `Optional.ofLastOrFirstOrLastOrLastOrLastOrLastOrEmpty()`, `Optional.ofLastOrFirstOrLastOrLastOrLastOrLastOrLastOrEmpty()`, `Optional.ofLastOrFirstOrLastOrLastOrLastOrLastOrLastOrLastOrEmpty()`, `Optional.ofLastOrFirstOrLastOrLastOrLastOrLastOrLastOr", + "prediction": "I think we should remove the `@Serializables` annotation.", "reference": "I usually set idea to never use wildcard import such as `import java.util.*;` Now i use setting from javaslang standard." }, { - "prediction": "I think this should be `v.vm.network :private_network, ip: \\\"#{host['ip'].to_s}\\\", :netmask => \\\"#{host['netmask'] ||= \"255.255.0.0\"}\\\"`", + "prediction": "I think this should be `host['ips'].each do |ip|` instead of `host['ips'].each do |ip|`", "reference": "Where is host['ips'] coming from?" }, { @@ -735,7 +735,7 @@ "reference": "oh! missed a `:` here; let me fix that; also can get rid of the intermediate variable" }, { - "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to have the `first_name` and `last_name` fields in the `Proposal` model. If you don't need them, you can remove them from the `Proposal` model.", + "prediction": "I'm not sure what you're trying to achieve with this test, but I think it would be better to test the `display_status_text` method in the `Proposal` model.", "reference": "Is this necessary?" }, { @@ -747,23 +747,23 @@ "reference": "Instead of storing the revert flag in the tracer is it possible to use org.hyperledger.besu.ethereum.mainnet.TransactionProcessor.Result#getRevertReason? (via org.hyperledger.besu.ethereum.transaction.TransactionSimulatorResult#getResult)? If a TX reverts without a reason do we get an empty revert reason or a revert reason with zero bytes?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `createReaderFunc` here.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to create a new `SparkOrcReader` instance for each test.", "reference": "I think this should test with and without container reuse if that is implemented in this PR. Probably just make this test parameterized." }, { - "prediction": "I think this should be `if (fields.get(i).fieldId() == ManifestFile.SPEC_ID.fieldId())` instead of `if (fields.get(i).fieldId() == ManifestFile.SPEC_ID.fieldId()) { found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found = true; found", + "prediction": "I think this should be `if (fields.get(i).fieldId() == ManifestFile.SPEC_ID.fieldId()) { found = true; fromProjectionPos[i] = 14; } else { found = false; fromProjectionPos[i] = 0; }`", "reference": "These modifications allow BaseFile to translate into a SparkRow with the specID as a column" }, { - "prediction": "I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a `readPreference` property to the `ReadPreference` class, so that we can use it in the `resolveReadPreference` function.", "reference": "is this something we've been missing this whole time?" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I don't think we need to use `*` here. We can just use `allEvents` instead.", "reference": "nit: this is a package-wide constant so better to narrow the scope like `allEventsSign`." }, { - "prediction": "I think this should be `auth_thrift = os.path.join(thrift_files_dir, 'authentication.thrift')` instead of `auth_thrift = os.path.join(thrift_files_dir, 'authentication.thrift')`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.", "reference": "There seems to be some repetition. Does a local function make this code shorter overall?" }, { @@ -771,15 +771,15 @@ "reference": "Might be cheaper to reuse the `null` assignment of line 313 and set `isHydrating` to null instead WDYT?" }, { - "prediction": "I don't think this is a good idea. The `@AutoValue` annotation should be used only for auto-generated classes.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to `@AutoValue` as well.", "reference": "Revert this blank line" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to set the number of datanodes to 1, but you're also setting the block cache size to 512. I think you want to set the number of datanodes to 1 and the block cache size to 1024.", + "prediction": "I'm not sure why we need to clear the system properties here. I think we can just set them back to their default values.", "reference": "This was introduced recently for the Hadoop 3 upgrade. Copy/paste error but definitely causing some of the new test failures." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `before_action ->{authorize proposal}, only: [:show, :cancel, :cancel_form, :history]`", + "prediction": "I don't think we need to use `needs_token_on_get` in this case. I think we can just use `check_disabled_client` instead.", "reference": "I think we should only need to do this for `:approve` since we are using `authenticate_user!` for all other actions and that checks for disabled client" }, { @@ -787,7 +787,7 @@ "reference": "I wonder if we should create new tests for header checks; here for instance we're mixing querystring and headers. Thoughts?" }, { - "prediction": "I'm not sure what you're trying to achieve with this task, but I think it's a good idea to remove the `name` attribute from the task definition. It's not clear what the purpose of this task is, and it doesn't seem to be used anywhere else in the code.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `Bolt::Task.new` method to create the task.", "reference": "We should be able to add sensitive by hard-coding the parameters, same as you put into the metadata in apply_helpers." }, { @@ -795,19 +795,19 @@ "reference": "Why do you think that it is necessary to create this class?" }, { - "prediction": "I'm not sure what you mean by \"rewind stream at end\". I think you meant to say \"rewind stream at the end of the stream\".", + "prediction": "I'm not sure what you mean by `buf := make([]byte, bufsize)`. I think you meant `buf := make([]byte, 1024*1024*1024)`.", "reference": "replacing the `1` with `io.SeekCurrent` may be good here" }, { - "prediction": "I think this should be `Close` instead of `FetchKeySet` and `Close` instead of `FetchJWKS`", + "prediction": "Shouldn't this be `Close` instead of `FetchKeySet`?", "reference": "nit: perhaps this file would be better named `jwks_source.go` ?" }, { - "prediction": "I don't think this is needed anymore.", + "prediction": "I think this should be `PARAM_OVERRIDE_FILE` instead of `AZ_PLUGIN_LOAD_OVERRIDE_PROPS`?", "reference": "It will be helpful to specify the intended priority as well for the properties within this file." }, { - "prediction": "I'm not sure what you mean by \"apt is installed\". Is it possible that apt is installed, but not available on the system? In that case, it would be better to use `osinfo.Apt` instead of `osinfo.AptExists`.", + "prediction": "I'm not sure what you mean by \"apt is installed\". Is it possible that apt is installed but not available?", "reference": "Make this private and update all the public functions to not take this argument. The variable you set below should also be private, then in the tests instead of passing the variable in to the function just update the variable. We don't want to expose the testing implementation in the public api if it can be avoided." }, { @@ -815,23 +815,23 @@ "reference": "Do you now why is it a specific table name is used as a default?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a default value in case the environment variable doesn't exist.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a default value for the environment variable, so that if the user doesn't set it, it defaults to `/home/DDITAdministrator/myagent/_work/_temp`.", "reference": "If all you're doing is checking for the existence of a directory as your \"temp\" directory, why does it matter what OS you're on?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it would be better to use the `v2` version of the `generated` package instead of the `v1` version. The `v1` version is deprecated and will be removed in a future release.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `server` package.", "reference": "nit- would be cleaner to import it once" }, { - "prediction": "I think we should remove the `if 'Access-Control-Allow-Origin' not in response.headers:` line.", + "prediction": "I think it's better to use `response.headers.get('Access-Control-Allow-Headers', '')` instead of `response.headers.get('Access-Control-Allow-Headers')`.", "reference": "Looks like there is a closing parenthesis `)` missing here." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the end of the function.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check for `arg[ioffset]` to make sure it's not `NULL`.", "reference": "this one bothers me. There are many places where this one is written to for an error message and just a single callsite is changed." }, { - "prediction": "I think we can remove the `AnyTimes` call here, since it's not used anywhere else in the test.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a test for this. It's not clear to me if this is the right place to do this, but I think it would be good to add a test for this. It's not clear to me if this is the right place to do this, but I think it would be good to add a test for this. It's not clear to me if this is the right place to do this, but I think it would be good to add a test for this. It's not clear to me if this is the right place to do this, but I think it would be good to add a test for this. It's not clear to me if this is the right place to do this, but I think it would be good to add a test for this. It's not clear to me if this is the right place to do this, but I think it would be good to add a test for this. It's not clear to me if this is the right place to do this, but I think it would be good to add a test for this. It's not clear to me if this is the right place to do this, but I", "reference": "You can put this in `kbfsOpsInit()` in you want, so we don't have to call it in every test." }, { @@ -839,39 +839,39 @@ "reference": "`ARM_32` is what clients define as an input to DR, and is not always defined internally: we use just `ARM` to mean AArch32." }, { - "prediction": "I'm not sure what you mean by \"not dereferenced schema\". I think you meant to say \"not dereferenced originalSchema\".", + "prediction": "I'm not sure what you mean by \"not dereferenced schema\". I think you mean the original schema that was passed to the constructor.", "reference": "s/for use/to use for/" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get the avatar filename from the event. I'm not sure what you're trying to do here, but it looks like you're trying to get the avatar filename from the event. I'm not sure what you're trying to do here, but it looks like you're trying to get the avatar filename from the event. I'm not sure what you're trying to do here, but it looks like you're trying to get the avatar filename from the event. I'm not sure what you're trying to do here, but it looks like you're trying to get the avatar filename from the event. I'm not sure what you're trying to do here, but it looks like you're trying to get the avatar filename from the event. I'm not sure what you're trying to do here, but it looks like you're trying to get the avatar filename from the event. I'm not sure what you're trying to do here, but it looks like you're trying to get the avatar filename from the event. I'm not sure what you're trying to do here, but it looks like you're trying to get the avatar filename from the event. I'm not sure", + "prediction": "I don't think we need to use `null` for the `avatar_filename` field.", "reference": "` $event->getAvatarFilename()` this function return `string` or `null`. In this place ` $event->getAvatarFilename()->getValue()` return `Fatal error `" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `serviceerror` package, since it's an error from the `serviceerror` package.", + "prediction": "I don't think we need to change the error message here.", "reference": "why not creating a new error type for server's own resource limit exceed error and do conversion within rpc interceptor?" }, { - "prediction": "I don't think we need to use `Propagators.DefaultTextMapPropagator` here. We can use `Propagators.TextMapPropagator` instead.", + "prediction": "I don't think we need to change the default value here.", "reference": "Could be a timing thing here. When options are created they'll copy the ref for the current default propagator. If user sets through SDK the global propagator after that, it won't be reflected. Could leave it null here and then when it is used in instrumentation do `options.Propagator ?? Propagators.DefaultTextMapPropagator`. It would be a slight perf hit but it makes it hot-swappable." }, { - "prediction": "I'm not sure what you mean by \"allow exceeding balance\"", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `TransactionValidator` class, since it's not part of the `TransactionSimulator` class.", "reference": "Unrelated file. Please remove from PR." }, { - "prediction": "I'm not sure what you mean by \"other requests get raw JSON data.\" Is this the same as \"other requests get plain text data\"?", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `process_queue_status` function as well.", "reference": "Careful: you only want two newlines after the final header message. (That indicates the end of headers and the start of data.)" }, { - "prediction": "I think it's better to use `flow.request.headers.pop('Upgrade-Insecure-Requests', None)` instead of `flow.request.headers.pop('Upgrade-Insecure-Requests', None)`", + "prediction": "I think we should remove the `if` statement here, as it's not necessary.", "reference": "This will not work on Python 3 (to which we are transitioning) because `.content` is bytes, not a str. Can you make the pattern a bytes object as well (like so: `b\"pattern\"`)?" }, { - "prediction": "I'm not sure what you mean by \"not well supported\". I think it's just that it's not supported by all browsers. I think it's a good idea to make it a required attribute, but I'm not sure how to do that.", + "prediction": "I'm not sure if this is a good idea, but I think it's better to make it a required attribute.", "reference": "This was to allow the tests to pass when the order of the required was different. Silly, but we don't have an easy way to check for \"equal but order doesn't matter\" in chai." }, { - "prediction": "I'm not sure I understand what you're trying to do here.", + "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place", "reference": "maybe say \"returns the default cost method that returns an object of cost 1\"." }, { @@ -879,51 +879,51 @@ "reference": "I believe these rules will be enforced both (1) on egress from a local workload, and (2) on ingress **to** a local workload. Right? I understand that we definitely want (1), but do we really want to enforce (2) as well?" }, { - "prediction": "I think this should be `else if (response.isSuccess())` instead of `else if (!response.isSuccess())`", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check to see if the response is a 200 or 204. If it's a 200, then we should just return the response. If it's a 204, then we should just return an empty response.", "reference": "Use `response.asJsonObject()` instead. Also, use `put()` instead of `putOpt()`, `null` as a value is fine." }, { - "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `is(':visible')` in this case.", + "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to set the `z-index` of the `handsontableInputHolder` to a higher value than the `z-index` of the `handsontableInput` element, so that the `handsontableInput` element is always above the `handsontableInputHolder` element.", "reference": "Are you sure? We've changed it during an introduction of the IME support." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `null` here. If you want to use `null`, you can use `null !== $dqlFilter` instead of `null === $dqlFilter`.", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to do something like `$queryBuilder->andWhere($dqlFilter);` and then `$queryBuilder->leftJoin('entity.'.$sortFieldParts[0], $sortFieldParts[0]);` and then `$queryBuilder->andWhere($dqlFilter);` and then `$queryBuilder->leftJoin('entity.'.$sortFieldParts[0], $sortFieldParts[0]);` and then `$queryBuilder->andWhere($dqlFilter);` and then `$queryBuilder->leftJoin('entity.'.$sortFieldParts[0], $sortFieldParts[0]);` and then `$queryBuilder->andWhere($dqlFilter);` and then `$queryBuilder->leftJoin('entity.'.$sortFieldParts[0], $sortFieldParts[0]);` and then `$queryBuilder->andWhere($dqlFilter);` and then `$queryBuilder->leftJoin('entity.'.$sortFieldParts[0], $sortFieldParts[0]);` and then `$queryBuilder->andWhere($dqlFilter);` and then `$queryBuilder->leftJoin('entity.'.$sortFieldParts[0], $sortFieldParts[0]);` and then `$queryBuilder->andWhere($dqlFilter);` and then", "reference": "I think here we want the use of `empty()` to take care of empty strings. If you put `dql_filter: ''` in your YAML config ... this will add `->andWhere('')` and it will fail, right?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to use the `p2p.GetBroadcastMsg` method to get the broadcast message.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to make sure that the peerID is the same as the one in the `p2p.GetBroadcastMsg` call.", "reference": "this is golang's named return, err is defined, `return` is equivalent to `return err` the current code has no problem" }, { - "prediction": "I'm not sure I understand what you're trying to do here. I don't think you need to use `GString` here. I think you want to use `ostree_gpg_verify_result_describe` and `ostree_gpg_verify_result_get_all`.", + "prediction": "I'm not sure if this is a good place to put this, but I think it should be in the `ostree_gpg_verify_result_describe` function, since it's called by `ostree_gpg_verify_result_get_all` and `ostree_gpg_verify_result_get_all` is called by `ostree_gpg_verify_result_describe`.", "reference": "I don't think this is right; in Rust terms it's like a `&mut String`, in Java `StringBuilder` - it's not a return value from the function which is what `(out)` is for." }, { - "prediction": "I think this should be `bin_labels[inds, labels[inds] - 1] = 1` instead of `bin_labels[inds, labels[inds] - 1] = 1`", + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", "reference": "If the label is not binary, should we rename this function?" }, { - "prediction": "I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this,", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this", "reference": "This is very-very bad idea because of its performance impact" }, { - "prediction": "I'm not sure what you're trying to achieve with this code, but I think it's a good idea to add a comment explaining what the code is doing.", + "prediction": "I don't think we need to use `sync.Mutex` here. We can use `sync.RWMutex` instead.", "reference": "WHY U NOT SORT IMPORTS?" }, { - "prediction": "I think this should be `session: { email: user.email, password: user.password }` instead of `session: { email: user.email, password: user.password }`", + "prediction": "I think we should remove the `sign_in_as` method and use `sign_in` instead.", "reference": "Put a comma after the last item of a multiline hash." }, { - "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `__version__` in the `__init__.py` file. I think it's better to use `__author__` and `__author_email__` in the `__init__.py` file.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add `__all__` to the `__init__.py` file. This way, the `__init__.py` file can be used as a `requirements.txt` file, and the `__init__.py` file can be used as a `setup.py` file. This way, the `__init__.py` file can be used as a `requirements.txt` file, and the `__init__.py` file can be used as a `setup.py` file. This way, the `__init__.py` file can be used as a `requirements.txt` file, and the `__init__.py` file can be used as a `setup.py` file. This way, the `__init__.py` file can be used as a `requirements.txt` file, and the `__init__.py` file can be used as a `setup.py` file. This way, the `__init__.py` file can be used as a `requirements.txt` file, and the `__init__.py` file can be used as a `setup.py` file. This way, the `__init__.py`", "reference": "How come we need ``Dimensioned`` in the top-level namespace?" }, { - "prediction": "I'm not sure what you mean by \"highlight NPCs on-screen and/or on the minimap\". I think you meant to say \"highlight NPCs on-screen\" or \"highlight NPCs on the minimap\" or \"highlight NPCs on-screen and/or on the minimap\".", + "prediction": "I'm not sure I understand what you're trying to do with this plugin, but it looks like you're trying to highlight NPCs on-screen and/or on the minimap. I'm not sure what you're trying to do with this plugin, but it looks like you're trying to highlight NPCs on-screen and/or on the minimap. I'm not sure what you're trying to do with this plugin, but it looks like you're trying to highlight NPCs on-screen and/or on the minimap. I'm not sure what you're trying to do with this plugin, but it looks like you're trying to highlight NPCs on-screen and/or on the minimap. I'm not sure what you're trying to do with this plugin, but it looks like you're trying to highlight NPCs on-screen and/or on the minimap. I'm not sure what you're trying to do with this plugin, but it looks like you're trying to highlight NPCs on-screen and/or on the minimap. I'm not sure what you're trying to do with this plugin, but it looks like you're trying to highlight NPCs on-screen and/or on the minimap. I'm not sure what you're trying to do with this plugin, but it looks like you're trying to highlight", "reference": "excess whitespace through plugin." }, { - "prediction": "I don't think this is a good idea.", + "prediction": "I don't think we need to do this.", "reference": "What is the problem here? I feel we used this in a lot of places." }, { @@ -931,59 +931,59 @@ "reference": "Update the docstring." }, { - "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to mock the `time` package.", + "prediction": "I think we can remove the `gomock` import here, as it's not used anywhere in this file.", "reference": "delete the empty line \"github.com/pkg/errors\" should be grouped with other third party packages same for the rest" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to override the `init` method of the `RemoteWebDriver` class, but you're not actually doing anything with the `capabilities` parameter. If you want to override the `init` method of the `RemoteWebDriver` class, you should do so in the `RemoteWebDriver` class itself, not in the `init` method of the `RemoteWebDriver` class.", "reference": "Assigning capabilities to the field here is not the best idea. Semantically this field contains the capabilities returned by the browser after session start. So here we sould better amend capabilities and return them from `init` method to pass later to `startSession` method (that will assign the capabilities returned by the browser to the field)." }, { - "prediction": "I think this should be `@duration = (RSpec::Core::Time.now - @start).to_f if @start` instead of `@duration = (RSpec::Core::Time.now - @start).to_f if @start`", + "prediction": "I think we can remove the `alias_method` call here, as it's not really needed.", "reference": "Is this a breaking change, or is the API private?" }, { - "prediction": "I think this should be `test_data = pd.read_json(\"./dumps/courseData.json\"); test_data = {k: val.groupby('pk')['fields'].apply(list).apply(lambda x: x[0]).to_dict() for k, val in test_data.groupby(\"model\")}`", + "prediction": "I think this should be `test_data = {k: val.groupby('pk')['fields'].apply(list).apply(lambda x: x[0]).to_dict() for k, val in test_data.groupby(\"model\")}`", "reference": "I don't think we need this dependency in this project right now" }, { - "prediction": "I don't think we need to use `RetryName` here. We can just use `retry` as the name for the retry container.", + "prediction": "I don't think we need to use `BrokerCellLabelKey` here. We can use `BrokerSystemNamespace` instead. Also, I don't think we need to use `BrokerCellLabelKey` here. We can use `BrokerSystemNamespace` instead. Also, I don't think we need to use `BrokerCellLabelKey` here. We can use `BrokerSystemNamespace` instead.", "reference": "I don't think this is necessary since `CommonLabels` is a public func and every component name is also public constant." }, { - "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to set the job polling interval to 10 seconds, but I'm not sure what you're trying to do here. It looks like you're trying to set the job polling interval to 10 seconds, but I'm not sure what you're trying to do here. It looks like you're trying to set the job polling interval to 10 seconds, but I'm not sure what you're trying to do here. It looks like you're trying to set the job polling interval to 10 seconds, but I'm not sure what you're trying to do here. It looks like you're trying to set the job polling interval to 10 seconds, but I'm not sure what you're trying to do here. It looks like you're trying to set the job polling interval to 10 seconds, but I'm not sure what you're trying to do here. It looks like you're trying to set the job polling interval to 10 seconds, but I'm not sure what you're trying to do here. It looks like you're trying to set the job polling interval to 10 seconds, but I'm not sure what you're trying", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a default value of 10000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", "reference": "The `_example` field should be updated to include an interpreter with an array value." }, { - "prediction": "I'm not sure what you're trying to do with this, but it's not clear to me what you're trying to do with this, but it's not clear to me what you're trying to do with this, but it's not clear to me what you're trying to do with this, but it's not clear to me what you're trying to do with this, but it's not clear to me what you're trying to do with this, but it's not clear to me what you're trying to do with this, but it's not clear to me what you're trying to do with this, but it's not clear to me what you're trying to do with this, but it's not clear to me what you're trying to do with this, but it's not clear to me what you're trying to do with this, but it's not clear to me what you're trying to do with this, but it's not clear to me what you're trying to do with this, but it's not clear to me what you're trying to do with this, but it's not clear to me what you're trying to do with this, but it's not clear to me what you're trying to do with this, but it's", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to add a new protocol to the supportedProtocols map, but I'm not sure what you're trying to do with it. I think you're trying to add a new protocol to the supportedProtocols map, but I'm not sure what you're trying to do with it. I think you're trying to add a new protocol to the supportedProtocols map, but I'm not sure what you're trying to do with it. I think you're trying to add a new protocol to the supportedProtocols map, but I'm not sure what you're trying to do with it. I think you're trying to add a new protocol to the supportedProtocols map, but I'm not sure what you're trying to do with it. I think you're trying to add a new protocol to the supportedProtocols map, but I'm not sure what you're trying to do with it. I think you're trying to add a new protocol to the supportedProtocols map, but I'm not sure what you're trying to do with it. I think you're trying to add a new protocol to the supportedProtocols map, but I'm not sure what you're trying to", "reference": "Put this in the godoc of SupportedProtocols instead. Preferably we would just use one map though. Why not just use this one?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `containerMetadata` field in the `newCronContainer` function. This way, we don't need to pass the `dockerID` and `dockerGraphPath` to the `newCronContainer` function, and we don't need to pass the `name` to the `newCronContainer` function.", + "prediction": "I think it's better to use `containerStatePath` instead of `statePath` in this case.", "reference": "I'd feel a little safer if the first argument were a string, not a *string unless there's a particular reason for making it a pointer." }, { - "prediction": "I don't think this is a good idea. It's not a good idea to change the signature of a method in a way that it doesn't work anymore.", + "prediction": "I don't think this is necessary. We can just remove the `@Before` annotation.", "reference": "Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC." }, { - "prediction": "I'm not sure if this is a good place to put it, but I think we should move it to the `org.openqa.selenium.grid.graphql` package.", + "prediction": "I don't think this is necessary. The `SessionNotCreatedException` is already handled in the `SessionMap` class.", "reference": "You can safely revert changes to this file." }, { - "prediction": "I don't think this is a good idea. It's not clear to me why we would want to do this.", + "prediction": "I don't think we need to use `permute` here. We can just use `reshape` here.", "reference": "This deletion is unnecessary." }, { - "prediction": "I think we can remove the `img` tag here, as it's not needed.", + "prediction": "I think it's better to use `img` tag instead of `img` and `alt=\"\"` instead of `src={ smallImage }`", "reference": "I'm not a huge fan of this overloading of the prop; accepting very different types of arguments for props like this can be confusing, and wasn't part of the IB. I understand wanting to import the SVG directly, but the IB suggests using `${global._googlesitekitLegacyData.admin.assetsRoot}${userInputSuccessImage}` as the `src`/`smallImage` value here. It'd be great to refactor this to accept components directly in the future, but let's do that all-at-once rather than this hybrid approach that makes the API less clear." }, { - "prediction": "I don't think this is needed anymore. The `ZkController` class is now part of the `org.apache.solr.cloud` package, so we don't need to import it anymore.", + "prediction": "I don't think this is needed anymore. We can just use `HashMap` instead of `List` and `Map`.", "reference": "I've had this happen recently with IntelliJ, was this intentional?" }, { - "prediction": "I'm not sure what you mean by `size` here. Is it the size of the format in bytes? Or is it the number of bits in the format? I'm not sure what you're trying to do here.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `std::unordered_map` instead of `std::map` in this case.", "reference": "Order(1) vs Order(logN) -- not sure it's measurable at the ~200 element size of the table. All of the published comparisons start at ~1000 elements." }, { @@ -991,23 +991,23 @@ "reference": "I don't know about this aliasing and 'factory'. Previous version was rather straightforward: `location.CreateLocationResolver`. Perhaps `location.CreateResolver` would be even better? What do we actually gain here from moving DI to a separate sub-package?" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to throw an exception here. I'm not sure what you're trying to do here, but it looks like you're trying to throw an exception here. I'm not sure what you're trying to do here, but it looks like you're trying to throw an exception here. I'm not sure what you're trying to do here, but it looks like you're trying to throw an exception here. I'm not sure what you're trying to do here, but it looks like you're trying to throw an exception here. I'm not sure what you're trying to do here, but it looks like you're trying to throw an exception here. I'm not sure what you're trying to do here, but it looks like you're trying to throw an exception here. I'm not sure what you're trying to do here, but it looks like you're trying to throw an exception here. I'm not sure what you're trying to do here, but it looks like you're trying to throw an exception here. I'm not sure what you're trying to do here, but it looks like you're trying to throw an exception here. I'm not sure what you", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to throw an exception. I'm not sure what you're trying to do here, but it looks like you're trying to throw an exception. I'm not sure what you're trying to do here, but it looks like you're trying to throw an exception. I'm not sure what you're trying to do here, but it looks like you're trying to throw an exception. I'm not sure what you're trying to do here, but it looks like you're trying to throw an exception. I'm not sure what you're trying to do here, but it looks like you're trying to throw an exception. I'm not sure what you're trying to do here, but it looks like you're trying to throw an exception. I'm not sure what you're trying to do here, but it looks like you're trying to throw an exception. I'm not sure what you're trying to do here, but it looks like you're trying to throw an exception. I'm not sure what you're trying to do here, but it looks like you're trying to throw an exception. I'm not sure what you're trying to do here, but it looks like", "reference": "Use `UpperCamelCase` for function names" }, { - "prediction": "I'm not sure if this is a good idea, but I think we should be able to do something like this:\r\n\r\n```javascript\r\nSchemaDate.prototype.cast = function(value) {\r\n if (value instanceof Number || typeof value === 'number') {\r\n date = new Date(value);\r\n } else if (typeof value === 'string' && !isNaN(Number(value)) && (Number(value) >= 275761 || Number(value) < 0)) {\r\n // string representation of milliseconds take this path\r\n date = new Date(Number(value));\r\n } else if (typeof value.valueOf === 'function') {\r\n- // support for moment.js. This is also the path strings will take because strings\r\n- // have a `valueOf()`\r\n+ // support for moment.js. This is also the path string representation of years\r\n+ // will take because strings have a `valueOf()`\r\n date = new Date(value.valueOf());\r\n } else {\r\n // fallback```\r\n```\nReview comment?", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.", "reference": "I'm not 100% sold on this idea but I like it in general. Nice compromise between using the 'Date' constructor where possible and falling back to the pre #5880 behavior when it makes sense. However, instead of `Number(value) < 0`, let's do `Number(value) < MIN_YEAR` because `new Date('-2017')` is perfectly valid in JS and I don't want to break the date behavior." }, { - "prediction": "I'm not sure what you mean by \"CLUSTER_STATE is probably wrong leading to bad stateFormat\"", + "prediction": "I'm not sure if this is a good place to put it, but I think it should be in the `ClusterState` class.", "reference": "Remember to close SOLR-11877 after this" }, { - "prediction": "I think this should be `isIgnoredChar(char ch)` instead of `isIgnoredChar(char ch) && ch == ' '`", + "prediction": "I think we should remove the `Doxygen_Suppress` here.", "reference": "this change should be reverted" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a test for this.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate test for this.", "reference": "This function signature is a bit complicated, some parameters are IN type (stopLoop which is modified from outside), others are OUT (registeredEvent channel which is modified inside function) I suggest the following signature -> SubscribeToRegistrationEvent(identityAddress) returns registeredEvent chan of type (RegisteredEvent not int), Unsubscribe func(), error (in case of any error). That way caller can always cance subscription if needed and check for any errors. Also - unsubscribe function hides any internal details how subscribtion is really implemented" }, { @@ -1015,27 +1015,27 @@ "reference": "`.wav`?! cannot we use something slightly more modern and compressed instead? :) I dunno, like `.mp3` or `.aac` or `.ogg`..." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you're trying to do here, but I don't think this is the right place to do it.", "reference": "Wouldn't a single signal call be enough? (without the boolean even)" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a link to the report.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to add a link to the top of the note that says \"Report this note\" or something like that. That way, the user can click on it to report the note.", "reference": "I suspect that this whole block, which is going to be repeated a number of times, should probably be in a helper. I guess it would need to be given the object and the title and could probably figure out everything else from that?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good place to add a `attr_reader` to the `Document` class. The `attr_reader` is only used for the `Document` class itself, not for any of the other classes that inherit from it. If you want to add a `attr_reader` to the `Document` class, you should add it to the `AbstractBlock` class, not to the `Document` class itself.", + "prediction": "I'm not sure what you're trying to do here. The `path_resolver` and `converter` attributes should be read-only.", "reference": "Should we expose this attribute in the Asciidoctor.js API ?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to use `contains` on a `Tuple2`, but you're not returning a `Tuple2` from `contains`.", + "prediction": "I don't think this is a good idea. The `contains` method should return `true` if the element is present in the map, and `false` if it is not.", "reference": "I think contains on `Multimap` was broken - it should return true if one of the values is associated with the key? It that right" }, { - "prediction": "I think it's a good idea to have a default value for `timeout` and `timeoutUnit`.", + "prediction": "I think it's better to use `DEF_KV_CLIENT_CONCURRENCY` instead of `DEF_PREWRITE_CONCURRENCY`.", "reference": "delete this line" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don", + "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", "reference": "Presumably we no longer need `force: true` here." }, { @@ -1043,47 +1043,47 @@ "reference": "HIP runtime is compiled using a C++ compiler. So comparison to both NULL as well as 0 does not make sense. Just comparing to NULL is sufficient." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way", "reference": "these urls are still in `a` tags so we should probably include these links separately for a non-HTML version" }, { - "prediction": "I think this should be `if err != nil { ... }` instead of `if err == nil && s.sys != nil && acc != s.sys.account { ... }`", + "prediction": "I think this should be `if err != nil && s.sys != nil && acc != s.sys.account` instead of `if err == nil && s.sys != nil && acc != s.sys.account`", "reference": "That's fine though, meaning that you can send to this channel under the server lock. The internalSendLoop will pick up the change when the server lock is released (if loop is blocked trying to grab the server lock). Even the way you do it here (releasing the lock, sending, then reacquiring) does not guarantee that the internalSendLoop will have time to refresh in that interval." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it would be a good idea to move this into the `CapabilityType` class.", + "prediction": "I don't think we need to add this to the `CapabilityType` interface. We can just use the `hasTouchScreen` and `enableDownloading` properties directly in the `CapabilityType` interface.", "reference": "The name `enableDownloading` implies this is a boolean capability. How about `downloadDir`?" }, { - "prediction": "I don't think this is a good idea. The default validator should always be loaded.", + "prediction": "I don't think this is needed anymore.", "reference": "Found one internal team is using this method. Will coordinate with them about the migration solution." }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good idea to have this in the `TracerSettings.cs` file. It would be a good idea to have this in the `TracerSettings.cs` file. It would be a good idea to have this in the `TracerSettings.cs` file. It would be a good idea to have this in the `TracerSettings.cs` file. It would be a good idea to have this in the `TracerSettings.cs` file. It would be a good idea to have this in the `TracerSettings.cs` file. It would be a good idea to have this in the `TracerSettings.cs` file. It would be a good idea to have this in the `TracerSettings.cs` file. It would be a good idea to have this in the `TracerSettings.cs` file. It would be a good idea to have this in the `TracerSettings.cs` file. It would be a good idea to have this in the `TracerSettings.cs` file. It would be a good idea to have this in the `TracerSettings.cs` file. It would be a good idea to have this in the", + "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good idea to have a separate section in the docs for this. It would be a good idea to have a separate section in the docs for this, it would be a good idea to have a separate section in the docs for this, it would be a good idea to have a separate section in the docs for this, it would be a good idea to have a separate section in the docs for this, it would be a good idea to have a separate section in the docs for this, it would be a good idea to have a separate section in the docs for this, it would be a good idea to have a separate section in the docs for this, it would be a good idea to have a separate section in the docs for this, it would be a good idea to have a separate section in the docs for this, it would be a good idea to have a separate section in the docs for this, it would be a good idea to have a separate section in the docs for this, it would be a good idea to have a separate section in the docs for this, it would be a good idea to have a separate section in the docs for this, it", "reference": "The field `HttpServerErrorCodes` should be called `HttpServerErrorStatuses`" }, { - "prediction": "I'm not sure what you mean by `GCLOUD_MIN_VERSION` and `GCLOUD_VERSION_REGEX`. Could you please provide more context?", + "prediction": "I'm not sure if this is correct, but I think it should be `GCLOUD_MIN_VERSION = (180, 0, 0)` and `GCLOUD_VERSION_REGEX = r'Google Cloud SDK (\\d+\\.\\d+\\.\\d+)'` and `GCLOUD_ALPHA_REGEX = r'alpha.*'`", "reference": "Can you please make each of these in a separate line. It will be easier to keep them sorted, and add/remove." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to check if the file already exists in zookeeper before trying to create a new one.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check here to make sure that we don't try to create a node for a configuration that already exists in zookeeper.", "reference": "should we error instead of silently ignoring the `cleanup` param? it defaults to `false`, so someone must have explicitly set it to `true`" }, { - "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to create a new `Reader` from an existing `ReaderAt` object, but you're doing it in a way that doesn't make sense. I think you want to create a new `Reader` from an existing `ReaderAt` object, but you're doing it in a way that doesn't make sense. I think you want to create a new `Reader` from an existing `ReaderAt` object, but you're doing it in a way that doesn't make sense. I think you want to create a new `Reader` from an existing `ReaderAt` object, but you're doing it in a way that doesn't make sense. I think you want to create a new `Reader` from an existing `ReaderAt` object, but you're doing it in a way that doesn't make sense. I think you want to create a new `Reader` from an existing `ReaderAt` object, but you're doing it in a way that doesn't make sense. I think you want to create a new `Reader` from an existing `ReaderAt` object, but you're doing it in a way that doesn't make sense. I think you want", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `archive` package, since it's not part of the `archive` package.", "reference": "There is no specific requirement that the root be called `root`, just that there is a single root directory and that it be the first entry in the zip." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `shared` folder.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the header, since it's the first thing the user sees.", "reference": "perhaps we should encapsulate this logic in a helper method w a test?" }, { - "prediction": "I think this should be `require \"beaker/options/#{file}\"` instead of `require File.expand_path(File.join(File.dirname(__FILE__), 'options', file))`", + "prediction": "I think this should be `require \"beaker/options/#{file}\"` instead of `require \"beaker/options/#{file}\" unless defined?(Beaker::Options::#{file})`", "reference": "Now that we're only using this repo as a Gem you shouldn't need to `require` an expanded local file path like below." }, { - "prediction": "I think we can remove the `@Override` here, since this is just an implementation detail of the `Timestamps` enum.", + "prediction": "I think this should be `int` instead of `Integer`?", "reference": "This isn't necessarily a year. It may be months, days, or hours. Can we return `intValue()` directly instead?" }, { @@ -1091,35 +1091,35 @@ "reference": "this is redundant because it gets logged immediately on entering the handleContainerChange function" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. It's a bit of a hack, but I think it's the best way to do it.", "reference": "`ds.GenericDeploymentConfig.DeploymentNotification` in L128 is nullable." }, { - "prediction": "I don't think this is needed anymore.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `ProtocolContext` class.", "reference": "this shouldn't be exposed here - this class isn't a carriage for this - its used internally to determine if/how we can mine." }, { - "prediction": "Shouldn't this be `requireNonNull` instead of `Require.nonNull`?", + "prediction": "I think this should be `requireNonNull` instead of `Require.nonNull`.", "reference": "It's fine to leave these checks in. It'll make the exception come from `FirefoxDriver`, and that's probably clearer to a user." }, { - "prediction": "Shouldn't we also include `FeatureSpecHelper` for `feature` tests?", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to add a `FeatureSpecHelper` for each of the `:feature, :request, :model` types, but I'm not sure what you're trying to do here. I think you're trying to add a `FeatureSpecHelper` for each of the `:feature, :request, :model` types, but I'm not sure what you're trying to do here. I think you're trying to add a `FeatureSpecHelper` for each of the `:feature, :request, :model` types, but I'm not sure what you're trying to do here. I think you're trying to add a `FeatureSpecHelper` for each of the `:feature, :request, :model` types, but I'm not sure what you're trying to do here. I think you're trying to add a `FeatureSpecHelper` for each of the `:feature, :request, :model` types, but I'm not sure what you're trying to do here. I think you're trying to add a `FeatureSpecHelper` for each of the `:feature, :request, :model` types, but I'm not sure", "reference": "We don't want to include the `IntegrationSpecHelper` for models...mind moving this line out of the loop to be `config.include EnvironmentSpecHelper, type: :model`?" }, { - "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to remove the `os.Chmod(dir, 0755)` and `os.Chmod(file.Name(), 0666)` calls. I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to remove the `os.Chmod(dir, 0755)` and `os.Chmod(file.Name(), 0666)` calls. I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to remove the `os.Chmod(dir, 0755)` and `os.Chmod(file.Name(), 0666)` calls. I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to remove the `os.Chmod(dir, 0755)` and `os.Chmod(file.Name(), 0666)` calls. I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to remove the `os.Chmod", + "prediction": "I'm not sure what you mean by `dir` and `file.Name()`. I think you meant `dir` and `file.Name().String()`.", "reference": "Please check the return on these." }, { - "prediction": "I think this should be `if (uplink.config.cache) { savestream = self.local.add_tarball(name, filename); } else { savestream = uplink.add_tarball(name, filename); }`", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a `cache` option to the `add_tarball` method.", "reference": "Do we need `==` for true?" }, { - "prediction": "I think this should be 0.0001 instead of 0.0002.", + "prediction": "I don't think we need to change this.", "reference": "Changing the default value may cause BC-breaking. Suggest changing this value in config." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is the right place to do it.", + "prediction": "I think it's better to use `int(slider_pos)` instead of `int(slider_pos % len(FEE_ETA_TARGETS))` because `slider_pos % len(FEE_ETA_TARGETS)` will be `0` if `slider_pos == len(FEE_ETA_TARGETS)`.", "reference": "how does that happen?" }, { @@ -1127,19 +1127,19 @@ "reference": "This is gross/clever. :-)" }, { - "prediction": "I think it's better to use `Faker::Config.locale = 'zh-CN'` instead of `Faker::Config.locale = 'zh-CN'`", + "prediction": "I think it's better to use `require 'test_helper'` instead of `require File.expand_path(File.dirname(__FILE__) + '/test_helper.rb')`", "reference": "Take a look at the name of this file. Definitely copy and" }, { - "prediction": "I'm not sure what you mean by \"statuscode: 500\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the response is a 404 error. If it is, then we should return a 404 error.", "reference": "Can you check with @mahebbar how to work this error. Should be different from 404." }, { - "prediction": "I'm not sure what you mean by `>=3.5,<3.8`", + "prediction": "`>=3.5,<3.8` should be `>=3.5,<3.8,<3.9`", "reference": "Do we still need the upper bound `<3.9`?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the path is relative to the current working directory. If it is, then we can't use `realpath()`, so we can't use `realpath(dirname(__DIR__) . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'psalm')` or `realpath(dirname(__DIR__, 3) . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'psalm')`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `realpath($input_path) === realpath(__DIR__ . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'psalm')` and `realpath($input_path) === realpath(__DIR__ . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'psalter')`", "reference": "Does this mean `vendor/bin/psalm` is not a symlink (or whatever equivalent Windows has for symlinks) on Windows?" }, { @@ -1147,27 +1147,27 @@ "reference": "@lpabon having a separate package name `aws_test` allows to test the package as if the tester was an external package. If the test package name is the same as the package being tested, the test package can also use methods and variables not exposed to the eventual user." }, { - "prediction": "I think we can remove the `instrumentKind` field from the `exporter` struct, since it's not used in the `exporter` struct.", + "prediction": "I think we should remove the `instrumentKind` key from the map, as it's not used anywhere.", "reference": "The exporter should still be able to test these histogram instrument kinds, right? Is there another reason to remove these?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. The `Round` function is supposed to return the block's round number, but the `ResetTxnBytes` function is supposed to reset the number of bytes tracked by the BlockEvaluator to zero. What is the purpose of these two functions?", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.", "reference": "should this increment eval.Round somehow?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `Blacklight::Solr::Response` class, since it's used in the `Blacklight::Solr::Query` class as well.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `Blacklight::Solr::Response` class.", "reference": "Although this change looks good. Maybe there are other inconsistent cases too?" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to format the markdown output of the `resources` array. I'm not sure what you're trying to achieve with this, but it looks like you're trying to format the markdown output of the `resources` array. I'm not sure what you're trying to achieve with this, but it looks like you're trying to format the markdown output of the `resources` array. I'm not sure what you're trying to achieve with this, but it looks like you're trying to format the markdown output of the `resources` array. I'm not sure what you're trying to achieve with this, but it looks like you're trying to format the markdown output of the `resources` array. I'm not sure what you're trying to achieve with this, but it looks like you're trying to format the markdown output of the `resources` array. I'm not sure what you're trying to achieve with this, but it looks like you're trying to format the markdown output of the `resources` array. I'm not sure what you're trying to achieve with this, but it looks like you're trying to format the markdown output of the `resources` array.", + "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bit of a misnomer to call it a \"markdown\" helper. It's more of a \"bluecloth\" helper. I think you should call it something like \"bluecloth_markdown\" or \"markdown_bluecloth\".", "reference": "This is a way better method name." }, { - "prediction": "I'm not sure what you're trying to do here. You're redirecting to the welcome page, but you're not redirecting back to the welcome page. You're redirecting to the welcome page, but you're not redirecting back to the welcome page. You're redirecting to the welcome page, but you're not redirecting back to the welcome page. You're redirecting to the welcome page, but you're not redirecting back to the welcome page. You're redirecting to the welcome page, but you're not redirecting back to the welcome page. You're redirecting to the welcome page, but you're not redirecting back to the welcome page. You're redirecting to the welcome page, but you're not redirecting back to the welcome page. You're redirecting to the welcome page, but you're not redirecting back to the welcome page. You're redirecting to the welcome page, but you're not redirecting back to the welcome page. You're redirecting to the welcome page, but you're not redirecting back to the welcome page. You're redirecting to the welcome page, but you're not redirecting back to the welcome page. You're redirecting to the welcome page, but you're not", + "prediction": "I'm not sure what you mean by \"thanks for signing up\". I think you meant to say \"thanks for signing up for the newsletter\".", "reference": "Prefer single-quoted strings when you don't need string interpolation or special symbols." }, { - "prediction": "I don't think this is necessary. We can just use `options` directly.", + "prediction": "I don't think this is needed anymore.", "reference": "I was wondering if this should allow per role specification, instead of (or in addition to) a generic \"allowed everywhere\". So you could do: `{ separator: ['aria-valuenow', 'aria-valuemin', 'aria-valuemax'] }`. You could still allow the array, and you could add a wildcard option for the \"generic\" case you've got now: `{ '*': ['always-allowed'] }`." }, { @@ -1175,11 +1175,11 @@ "reference": "I'm confused by the name. The string was a Hive string but it isn't any longer? Why should we care? (I imagine I'll find the answer later... there is some different semantic that we want downstream...)" }, { - "prediction": "`org.openqa.selenium.remote.http.HttpHandler` is deprecated. Use `org.openqa.selenium.remote.http.HttpClient` instead.", + "prediction": "`org.openqa.selenium.remote.http.HttpClient` is deprecated. `org.openqa.selenium.remote.http.HttpHandler` is deprecated. `org.openqa.selenium.remote.http.HttpRequest` is deprecated. `org.openqa.selenium.remote.http.HttpResponse` is deprecated. `org.openqa.selenium.remote.http.TextMessage` is deprecated. `org.openqa.selenium.remote.http.WebSocket` is deprecated. `org.openqa.selenium.remote.tracing.DefaultTestTracer` is deprecated. `org.openqa.selenium.remote.tracing.Tracer` is deprecated. `org.openqa.selenium.remote.tracing.DefaultTestTracer` is deprecated. `org.openqa.selenium.remote.tracing.Tracer` is deprecated. `org.openqa.selenium.remote.tracing.DefaultTestTracer` is deprecated. `org.openqa.selenium.remote.tracing.Tracer` is deprecated. `org.openqa.selenium.remote.tracing.DefaultTestTracer` is deprecated. `org.openqa.selenium.remote.tracing.Tracer` is deprecated. `org.openqa.selenium.remote.tracing.DefaultTestTracer` is deprecated. `org.openqa.selenium.remote.tracing.Tracer` is deprecated. `org.openqa.selenium.remote.tracing.DefaultTestTracer` is deprecated. `org.openqa.selenium.remote.tracing.Tracer` is deprecated. `org.openqa.selenium.remote.tracing.DefaultTestTracer` is deprecated. `", "reference": "Could you please leave the explicit imports?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to use the `iproto` package, but you're not using it in your code. I'm not sure what you're trying to achieve with this change. It seems like you're trying to use the `iproto` package, but you're not using it in your code. I'm not sure what you're trying to achieve with this change. It seems like you're trying to use the `iproto` package, but you're not using it in your code. I'm not sure what you're trying to achieve with this change. It seems like you're trying to use the `iproto` package, but you're not using it in your code. I'm not sure what you're trying to achieve with this change. It seems like you're trying to use the `iproto` package, but you're not using it in your code. I'm not sure what you're trying to achieve with this change. It seems like you're trying to use the `iproto` package, but you're not using it in your code. I'm not sure", + "prediction": "I don't think we need to use `iproto` here. We can just use `proto` here.", "reference": "Why need alias?" }, { @@ -1187,39 +1187,39 @@ "reference": "Shouldn't this be a `libfs.nullIDGetter` (exported, of course)?" }, { - "prediction": "I'm not sure what you mean by \"too large\" here. I think we should just say \"too many arguments\" or something like that.", + "prediction": "I'm not sure if this is the best place to put this, but I think it would be good to add a comment to the `tealAppSize` and `tealLogicSigSize` messages.", "reference": "I dislike the messages.go pattern; the strings are only used once and make more sense in context. The other two added reportErrorf() calls in clerk.go have inline strings." }, { - "prediction": "I don't think we need to use `emplace` here. We can just use `push_back` here.", + "prediction": "I don't think we need to use `emplace` here, we can just use `insert` instead.", "reference": "Seems we don't need it anymore." }, { - "prediction": "I'm not sure what you mean by `if: :published?`", + "prediction": "I'm not sure what you mean by `if: :published?`. I think you meant to say `if: published?`.", "reference": "This might cause problems with the weird way we publish Guidance and Groups in the UI. We will have to make sure that UAT is thorough." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you want to use `time.Hour` here. I think you want to use `time.Minute` or `time.Second` instead.", + "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `time.Hour` here.", "reference": "this default needs to be on order 1 minute, I'm not sure why we defaulted to 1 hour below..." }, { - "prediction": "I think we can remove the `if iss.Challenges != nil && iss.Challenges.DNS != nil && iss.Challenges.DNS.ProviderRaw != nil` check.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do it here.", "reference": "I figure to make `{env.*}` work, right? I can't think of any other placeholder that makes sense here" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `setUp` method.", "reference": "Why change the port from 0 to getAvailablePort()?" }, { - "prediction": "I think we should remove the `30.0` from the `var_loc_keys[0]` and `var_loc_keys[1]`.", + "prediction": "I think it's better to use `self.loc_mng.get_locator([{'id':'Id_123',}])` instead of `self.loc_mng.get_locator([{'id':'Id_123',},30.0)`.", "reference": "For me would be great don't repeat timeout sending in every get_locator call. Looks like it should be sent into LocatorsManager init. And possibly it should me non mandatory, something like that: `def __init__ (self, locators, timeout=60):`" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a global flag for the project name. This way, we don't have to worry about the project name being overwritten by a global flag, and we don't have to worry about the project name being too long or too short.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a global flag for this.", "reference": "I feel like since now we don't initiate the `opts.projectName` with `opts.ProjectName()`, which means `opts.projectName` and `opts.ProjectName()` they don't necessarily equal to each other, we need to also substitute all usage of `opts.ProjectName()` within `Ask()`, `Validate()`, and `Execute()` to `opts.projectName`. Otherwise if `-p` is set, `opts.ProjectName()` will get expired." }, { - "prediction": "I'm not sure what you're trying to do here, but I think it's a bad idea to use `byte[]` in this way. It's not a good idea to use `byte[]` in this way. It's not a good idea to use `byte[]` in this way. It's not a good idea to use `byte[]` in this way. It's not a good idea to use `byte[]` in this way. It's not a good idea to use `byte[]` in this way. It's not a good idea to use `byte[]` in this way. It's not a good idea to use `byte[]` in this way. It's not a good idea to use `byte[]` in this way. It's not a good idea to use `byte[]` in this way. It's not a good idea to use `byte[]` in this way. It's not a good idea to use `byte[]` in this way. It's not a good idea to use `byte[]` in this way. It's not a good idea to use `byte[]` in this way. It's not a good idea to use `byte[]` in this way. It's", + "prediction": "This should be `if (bytes?.Length == 0 || bytes == null)`", "reference": "why do we thinkg that an empty string is ok to return from this method? I think the null should never be passed in here in the first place" }, { @@ -1231,19 +1231,19 @@ "reference": "You missed `Write(...)`! I'm kidding ofc." }, { - "prediction": "I'm not sure what you're trying to achieve with this code, but it looks like you're trying to update the next payment information for a subscription that has a Stripe customer ID. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to update the next payment information for a subscription that has a Stripe customer ID. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to update the next payment information for a subscription that has a Stripe customer ID. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to update the next payment information for a subscription that has a Stripe customer ID. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to update the next payment information for a subscription that has a Stripe customer ID. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to update the next payment information for a subscription that has a Stripe customer ID. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to update the next payment information for a subscription that has a Stripe", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this.", "reference": "Was there a customer who had this set to an empty string?" }, { - "prediction": "I'm not sure what you mean by \"approver_email_address(final_approver)\". Is this the same as `final_approver_email_address`?", + "prediction": "I think this should be `final_approver_email_address` instead of `approver_email_address`.", "reference": "I know we have the `reporter` spec below, but what about a unit test for this to explain reasoning behind logic? If I were going to update this decorator, I would assume it wasn't covered by tests because there is no unit test." }, { - "prediction": "I'm not sure what you mean by \"attach\" in this context. Is it something like \"attach a file to a request\"?", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `RestClientRequest` interface.", "reference": "it's better to be : void attach(String name, Part part);" }, { - "prediction": "I'm not sure if this is a good place to put this, but I think we should move it to the `DataPageV2` class.", + "prediction": "I don't think this is necessary.", "reference": "I didn't see where the IOException can get thrown, is this just to match the V1 reader?" }, { @@ -1251,15 +1251,15 @@ "reference": "We normally suppress this warning with `RDUSED_PARAM(forceRDKit)`" }, { - "prediction": "I'm not sure what you mean by \"wildcard\" in this context. Could you please clarify?", + "prediction": "I don't think this is a good idea. It would be better to check if the GUID exists in the map, and if it does, return the player.", "reference": "What if `Game::getPlayerByNameWildcard` had not been called before. It would not find a player, wouldn't it?" }, { - "prediction": "I don't think we need to bind this to `filter.containCommercialApplicationsProperty()`.", + "prediction": "I don't think we need to bind this to `filter.containRequiresPatchApplicationsProperty()` because it's already bound to `filter.containTestingApplicationsProperty()`.", "reference": "Why upper case \"R\"?" }, { - "prediction": "I think this should be `required` instead of `BuildRequired()`?", + "prediction": "I think we can remove the `if !ok` check here.", "reference": "Does this need to return an error or could it return `false, nil`?" }, { @@ -1267,15 +1267,15 @@ "reference": "Can you not change those scopes in public API classes? This applies here and in other places -- protected changed to package-scope for source is not really an API-compatible change." }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason you want to set `view_missing_traductions_only` to 1?", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to add a `view_missing_traductions_only` parameter to the translation request.", "reference": "this parameter is only used in POST, please use `getRequest()->request->get('...');` Thanks" }, { - "prediction": "I'm not sure what you mean by \"too harsh\" here. I think it's a good idea to have a `validateName` function that takes in the `package` and `filename` and returns an error if they don't match.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a `validateName` function that takes in the package name and returns a promise that resolves with the package name if it's valid, or rejects with an error message if it's not.", "reference": "Problem number 1: Scoped packages would have a `/` character here. Changing this to `validatePackage` resolves the 403." }, { - "prediction": "I think this should be `deep_mapped[k] = new_val` instead of `new_val = v.map(map_fn, specs, clone)`", + "prediction": "I think this should be `deepmap` instead of `deepmapped`?", "reference": "I don't quite get why there would be key errors: ``deep_mapped`` is a clone of ``self`` and ``k`` comes from ``self.items()`` so why would the key ever be rejected?" }, { @@ -1283,11 +1283,11 @@ "reference": "this chain ID determines only from which chain to withdraw, therefore your changes do not accomplish what you want them to accomplish. You'll need changes to `func (aps *hermesPromiseSettler) Withdraw(chainID int64, providerID identity.Identity, hermesID, beneficiary common.Address) error`. The method probably has to include two chain ids: to and from. Currently, the method internally uses: `aps.config.L1ChainID` -> the chain to withdraw to `chainID` -> the chainID that was passed as the chain that the withdrawal is originating from." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. It's a bit of a hack, but I think it's the best way to do it.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate function for this.", "reference": "If instead we had `TraceContext.extract` return a bool value as a second return value, we could avoid the byte array comparison in `TraceID.IsValid`. Did you consider that alternative?" }, { - "prediction": "I'm not sure what you mean by \"paginated\" in this context. It's not clear to me what you're trying to do here.", + "prediction": "I'm not sure what you mean by \"paginated\" in this context. I think you meant to say that this is a paginated version of the DepotChest.", "reference": "here shouldn't we use `depotFreeLimit`?" }, { @@ -1295,39 +1295,39 @@ "reference": "Could we use the Rails application's secret token instead? Do we actually need our own here?" }, { - "prediction": "I think this is a duplicate of #1248.", + "prediction": "I think it's better to use `kdf.groupby(by='a', axis=1)` instead of `kdf.groupby('a', axis=1)`.", "reference": "so should be fixed here also" }, { - "prediction": "I think this should be `if (dmc->flags != 0 && (dmc->flags & ~(DR_MC_ALL)) == 0)` instead of `if (dmc->flags != 0 && (dmc->flags & ~(DR_MC_ALL)) == 0 && (dmc->size == sizeof(dr_mcontext_t) - sizeof(dr_opmask_t)))`", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `dr_opmask_t` instead of `dr_mcontext_t` in this case.", "reference": "I would just remove this assert as it's going to get un-maintainable with a long list of valid sizes. Ditto below." }, { - "prediction": "I'm not sure what you mean by \"ReservedPortsUDP\": []uint16{SSHPort, DockerReservedPort, DockerReservedSSLPort, AgentIntrospectionPort, AgentCredentialsPort}. I think you meant to say \"ReservedPorts\": []uint16{SSHPort, DockerReservedPort, DockerReservedSSLPort, AgentIntrospectionPort, AgentCredentialsPort}.", + "prediction": "I don't think we need to change the default values here. We can just use the default values from the `dockerclient` package.", "reference": "`HostDataDir` is misleading. Can we rename it to something more relevant ? The constant should also be moved up and reused as necessary." }, { - "prediction": "I'm not sure what you mean by \"IPsec ESP can add a maximum of 38 bytes to the packet including the ESP header and trailer.\"", + "prediction": "I don't think we need to change this.", "reference": "I still feel like we are double-counting the outer IP header here (once in `defaultMTUGRE` and once in `ipsecESPOverhead`) but I'm not that familiar with IPsec." }, { - "prediction": "I think we can remove the `OnEnd` method, as it's not really needed.", + "prediction": "I think we can remove the `OnEnd` method, as it's not needed anymore.", "reference": "Not sure what benefit we gain by extending BaseProcessor here, as this seems to be defining a new OnEnd method. Could we modify MeasurementItem to have all the things, and then MeasurementProcessor can be simply extending BaseProcessor (not blocking. just noting some observations in the PR :) )" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `exec` here. I think you want to use `exec.Command` instead.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a separate package for this. It would be a good idea to have a separate package for this. It would be a good idea to have a separate package for this. It would be a good idea to have a separate package for this. It would be a good idea to have a separate package for this. It would be a good idea to have a separate package for this. It would be a good idea to have a separate package for this. It would be a good idea to have a separate package for this. It would be a good idea to have a separate package for this. It would be a good idea to have a separate package for this. It would be a good idea to have a separate package for this. It would be a good idea to have a separate package for this. It would be a good idea to have a separate package for this. It would be a good idea to have a separate package for this. It would be a good idea to have a separate package for this. It would be a good idea to have a separate package for this. It would be a good idea to have a separate package for this. It would be a good", "reference": "This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.", + "prediction": "I'm not sure what you mean by \"configured Requestlogger will not log HealthChecks.\" Could you please clarify?", "reference": "This seems like a more appropriate message under `ListenAndServe`. WDYT?" }, { - "prediction": "I think we can remove the `await server.stop()` as it's not needed anymore.", + "prediction": "I think we can remove the `await server.stop()` here.", "reference": "Is this not required?" }, { - "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here.", + "prediction": "I don't think this is a good idea.", "reference": "We should start thinking of an object that encapsulates this information :) we might need more arguments in the future." }, { @@ -1335,35 +1335,35 @@ "reference": "Given that we are (conceptually) searching across multiple self-dependencies, all we can say is that we didn't have a self dependency in which *both* source and dest masks were correct. Since the spec doesn't imagine this case, the valid usage statement assume we can differentiate only wrong source from only wrong dest within a *single* self-dependency -- which we can't across multiple (at least not meaningfully)... so we always return both the source/dest VUID's if we can't find a self-dependency in with *both* are correct." }, { - "prediction": "I'm not sure what you're trying to achieve with this test, but I think it's a bit misleading. The `verify()` method is used to verify that a method has been called, but it's not used to verify that the method was called at all. If you want to verify that the method was called, you should use `verifyCalled()` instead.", + "prediction": "I'm not sure what you mean by \"verifyNoMoreInteractions(miningCoordinator);\". I think you meant to say \"verify(miningCoordinator).isRunning();\" or \"verify(miningCoordinator).isMining();\".", "reference": "rename? MiningCoordinator always exists" }, { - "prediction": "I'm not sure what you mean by \"offline_mode\" in this context. It's not clear to me what you're trying to do with it.", + "prediction": "I'm not sure if this is the best place to put this, but I think it's a good idea to have this in a separate file.", "reference": "Here would be the same case you don't need to call `loadConfigs`, but you would need to reread configs using `getConfig` on each getHost function call, not once per file." }, { - "prediction": "I think we can remove the `d.folder.fs.renameAndDeletionLock.Lock()` and `d.folder.fs.log.CDebugf(ctx, \"Removing (Delete) dir in cleanup %s\", d.name)`.", + "prediction": "I think it's better to use `d.folder.fs.renameAndDeletionLock.Lock()` and `d.folder.fs.renameAndDeletionLock.Unlock()` instead of `d.folder.fs.renameAndDeletionLock.Lock()` and `d.folder.fs.renameAndDeletionLock.Unlock()`.", "reference": "Unlocking with defer means that this lock is still held curing the call to forgetNode(), below, which I see attempts to acquire `f.mu`, which looks dangerous to me." }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use the `mockSignerVal` in this test.", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a new tip set, but you don't have a `mockSignerVal` to pass to `sharedSetup`.", "reference": "Does anyone still use the cst out of this method? If not consider deleting" }, { - "prediction": "I'm not sure why we're redirecting to a YouTube video here, but I think it's a good idea to do so.", + "prediction": "I'm not sure why we're redirecting to a YouTube video here, but I'm not sure why we're redirecting to a YouTube video here, but I'm not sure why we're redirecting to a YouTube video here, but I'm not sure why we're redirecting to a YouTube video here, but I'm not sure why we're redirecting to a YouTube video here, but I'm not sure why we're redirecting to a YouTube video here, but I'm not sure why we're redirecting to a YouTube video here, but I'm not sure why we're redirecting to a YouTube video here, but I'm not sure why we're redirecting to a YouTube video here, but I'm not sure why we're redirecting to a YouTube video here, but I'm not sure why we're redirecting to a YouTube video here, but I'm not sure why we're redirecting to a YouTube video here, but I'm not sure why we're redirecting to a YouTube video here, but I'm not sure why we're redirecting to a YouTube video here, but I'm not sure why we're redirecting to a YouTube video here, but I'm not sure why we're redirecting to a YouTube video here, but", "reference": "Line is too long. [97/80]" }, { - "prediction": "I'm not sure what you're trying to do with this test, but I don't think it's a good idea to mock `io.BytesIO` here.", + "prediction": "I'm not sure if this is the right place to put this, but I think it would make sense to move it to `tests/test_data_transfer.py` instead of `tests/test_data_transfer.py.test_data_transfer.py`.", "reference": "This seems unused." }, { - "prediction": "I don't think this is a good idea. It's not clear what it means to be \"already running\" in this context.", + "prediction": "I don't think this is a good idea. We should not assume that the node is running k8s api-server. If it's not, we should not assume that the node is having edge controller.", "reference": "@luguanglong , Thanks for the fix, can you re-phrase it to sound better something like \"This OS version is currently un-supported by keadm\"" }, { - "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "prediction": "I think this should be `GetAtomicWeightsForFingerprint` instead of `_CleanFpInfoAttr_`", "reference": "should probably be called `_DeleteFpInfoAttr` because it removes it. Cleaning gives the impression it is still there. I would also move this to the end of the function `GetAtomicWeightsForFingerprint`." }, { @@ -1371,7 +1371,7 @@ "reference": "nit, can we use `VK_PIPELINE_BIND_POINT_RAY_TRACING_KHR` here (granted it isn't else where, maybe worth fixing here or in separate PR)" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. The `params.require(:exercise).permit(:edit_url, :summary, :title, :url)` line is a bad idea. It's not clear what you're trying to achieve with this change.", "reference": "This will need to be updated in the upcase-exercises repo as well." }, { @@ -1387,7 +1387,7 @@ "reference": "I don't understand this change, what is happening here?" }, { - "prediction": "I think this should be `if (self.obj.excelCellObject.Application.Version > \"12.0\")` instead of `if (self.obj.excelCellObject.Application.Version > \"12.0\" and self.obj.excelCellObject.Application.Version > \"11.0\")`", + "prediction": "I think this should be `if (self.obj.excelCellObject.Application.Version > \"12.0\" and self.obj.excelCellObject.Application.Version < \"13.0\"):`", "reference": "I think its worth stating this is `versionMajor`" }, { @@ -1395,7 +1395,7 @@ "reference": "rebuild: say loads and merges" }, { - "prediction": "I'm not sure what you mean by \"external dependencies\" in this context. Is this related to the `expect-puppeteer` package? If so, I'm not sure what you mean by \"external dependencies\" in this context. Is this related to the `expect-puppeteer` package? If so, I'm not sure what you mean by \"external dependencies\" in this context. Is this related to the `expect-puppeteer` package? If so, I'm not sure what you mean by \"external dependencies\" in this context. Is this related to the `expect-puppeteer` package? If so, I'm not sure what you mean by \"external dependencies\" in this context. Is this related to the `expect-puppeteer` package? If so, I'm not sure what you mean by \"external dependencies\" in this context. Is this related to the `expect-puppeteer` package? If so, I'm not sure what you mean by \"external dependencies\" in this context. Is this related to the `expect-puppeteer` package? If so, I'm not sure what you mean by \"external dependencies\" in this context. Is this related to the `expect-puppeteer` package? If so,", + "prediction": "I'm not sure what you're trying to do here. Is it possible that you're trying to assert that the element is not tracked? If so, you should be using `isNotTracked` instead of `isTracked`.", "reference": "Why was this removed here (also in the other file)? Shouldn't we import them so that the reference in the docs below is interpreted correctly?" }, { @@ -1407,47 +1407,47 @@ "reference": "Is it really LEGACY_HELLO if we are using the most up to date HELLO? Perhaps `MONGOS_HELLO` would work here?" }, { - "prediction": "Should we retry instead?", + "prediction": "I think this should be `THREAD_SYNCH_SKIP_CLIENT_THREAD` instead of `THREAD_SYNCH_SUSPEND_FAILURE_RETRY`.", "reference": "I am afraid this is going to cause problems on Windows where it is not uncommon to have injected threads (CTRL_SHUTDOWN, CTRL_LOGOFF, etc.) we have no privileges to suspend -- and thus retrying will just fail again, and with the new \"synchall failure is fatal and should kill the process\" approach it turns what used to work for us on Windows into process death." }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to keep the `--target_arch` and `--mac_installer_signing_identifier` options in the same place as the `--target_arch` and `--mac_installer_signing_identifier` options in the `--target_arch` and `--mac_installer_signing_identifier` options in the `--target_arch` and `--mac_installer_signing_identifier` options in the `--target_arch` and `--mac_installer_signing_identifier` options in the `--target_arch` and `--mac_installer_signing_identifier` options in the `--target_arch` and `--mac_installer_signing_identifier` options in the `--target_arch` and `--mac_installer_signing_identifier` options in the `--target_arch` and `--mac_installer_signing_identifier` options in the `--target_arch` and `--mac_installer_signing_identifier` options in the `--target_arch` and `--mac_installer_signing_identifier` options in the `--target_arch` and `--mac_installer_signing_identifier` options in the `--target_arch` and `--mac_installer_signing_identifier", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the top of the file.", "reference": "think it should only be in create_dist" }, { - "prediction": "I think this should be `if int(cport.HostPort) > 0 {` instead of `if int(cport.HostPort) > 0 {`", + "prediction": "I think this should be `c.portTable.AddRule(podIP, int(cport.ContainerPort))` instead of `c.portTable.AddRule(podIP, port)`.", "reference": "Do you plan to support Pod spec change? Like hostPort is added/removed later after Pod creation?" }, { - "prediction": "I'm not sure what you're trying to do here. It seems like you're trying to open a file, but you're not actually doing anything with the file. You're just trying to open the file, but you're not doing anything with it. I'm not sure what you're trying to do here. It seems like you're trying to open a file, but you're not actually doing anything with the file. You're just trying to open the file, but you're not doing anything with it. I'm not sure what you're trying to do here. It seems like you're trying to open a file, but you're not actually doing anything with the file. You're just trying to open the file, but you're not doing anything with it. I'm not sure what you're trying to do here. It seems like you're trying to open a file, but you're not actually doing anything with the file. You're just trying to open the file, but you're not doing anything with it. I'm not sure what you're trying to do here. It seems like you're trying to open a file, but you're not actually doing anything with the file. You're just trying to open the file, but you're not doing", + "prediction": "I'm not sure what you're trying to do here. I don't think this is the right way to do it.", "reference": "Is this behavior correct? It used to return `true`, which should map to `dokan.ExistingDir`. Was that previously a bug?" }, { - "prediction": "I'm not sure what you mean by \"try running osrm-datastore\". It's not clear to me what you're trying to do.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the monitor exists before trying to list the regions.", "reference": "What about just printing an empty list in this case? That would make the output more predictable." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to set `this.container` to `document.querySelector('.gh-editor-container')[0]` in this case.", "reference": "I looked and couldn't find any usage of `container` in any of the editor component files (js or hbs), so I assume this was used once and didn't get removed?" }, { - "prediction": "I'm not sure if this is necessary, but I think it's a good idea to use the `roots_get_search_form` filter to get the search form from the templates/ directory. This way, we don't have to hard-code the path to the search form in the `roots_get_search_form` filter.", + "prediction": "I'm not sure if this is necessary, but I think it's a good idea to use the `roots_get_search_form` filter.", "reference": "I just updated a number of sites using older versions of Roots onto WP 3.6 and this little function change was required. Multiple search bars were displaying when I used the search widget in a widgetized sidebar. Updated the roots_get_search_form as seen in this change resolved it for me!" }, { - "prediction": "I don't think this is needed anymore.", + "prediction": "I don't think we need to use `Thelia\\Coupon\\Type\\FreeProduct` here. We can use `Thelia\\Coupon\\FreeProduct` instead.", "reference": "Fixes test failed in some cases" }, { - "prediction": "I'm not sure if this is the right place to add this, but I think it would be a good idea to move this to the prod environment as well. I'm not sure if this is the right place to add this, but I think it would be a good idea to move this to the prod environment as well. I'm not sure if this is the right place to add this, but I think it would be a good idea to move this to the prod environment as well. I'm not sure if this is the right place to add this, but I think it would be a good idea to move this to the prod environment as well. I'm not sure if this is the right place to add this, but I think it would be a good idea to move this to the prod environment as well. I'm not sure if this is the right place to add this, but I think it would be a good idea to move this to the prod environment as well. I'm not sure if this is the right place to add this, but I think it would be a good idea to move this to the prod environment as well. I'm not sure if this is the right place to add this, but I think it would be a good idea to move", + "prediction": "I'm not sure if this is the right place to add this, but I think it would be a good idea to move this to the prod environment as well.", "reference": "what's the prod url for this? just curious. @amirsaber" }, { - "prediction": "I think this should be `AZ_PLUGIN_LOAD_OVERRIDE_PROPS` instead of `AZ_PLUGIN_LOAD_OVERRIDE`.", + "prediction": "I'm not sure if this is the right place to put this, but I think it would be a good idea to move it to the `Constants` class.", "reference": "Can you please change this to azkaban.jobs.java.opts?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to get the URL to the Analytics Module page in Site Kit Admin, but I'm not sure what you're trying to do with it. I think you're trying to get the URL to the Analytics Module page in Site Kit Admin, but I'm not sure what you're trying to do with it. I think you're trying to get the URL to the Analytics Module page in Site Kit Admin, but I'm not sure what you're trying to do with it. I think you're trying to get the URL to the Analytics Module page in Site Kit Admin, but I'm not sure what you're trying to do with it. I think you're trying to get the URL to the Analytics Module page in Site Kit Admin, but I'm not sure what you're trying to do with it. I think you're trying to get the URL to the Analytics Module page in Site Kit Admin, but I'm not sure what you're trying to do with it. I think you're trying to get the URL to the Analytics Module page in Site Kit Admin, but I'm not sure what you're trying to do with it. I think you're trying to get the URL to the", + "prediction": "I'm not sure I understand what you're trying to do here.", "reference": "Here is another concatenation which should be updated. Even though `Source:` and the link are essentially separate, it isn't RTL friendly. This would be another good use for `createInterpolateElement` I think so that we wouldn't need to include all of the classnames in the translation string (or extract them to a placeholder). That would allow us to use the `Link` component as well, rather than using its resulting HTML as a string which will be a pain to maintain if we were to make changes to the base `Link` component." }, { @@ -1455,11 +1455,11 @@ "reference": "I would add an overload `GetCancelledZeroTask()` which calls `GetCancelledZeroTask(CancellationToken.None)`. This is cleaner than requiring the caller to pass `default(CancellationToken)` or `CancellationToken.None`." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `PreCallRecordDestroySwapchainKHR` function.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `PreCallRecordDestroySwapchainKHR` as well.", "reference": "Would it be equivalent to check if `chain != nullptr` below? Not suggesting a change, just curious." }, { - "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to call `wallets.queue_wallet_action` from within `wallet::change_async`, but you're not calling it from within `wallet::change_sync`. Is that correct?", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to call `wallets.node.wallets.queue_wallet_action` with a `std::function)> const &`, but it's not clear to me what you're trying to do with this function.", "reference": "Should probably do `auto this_l (shared_from_this ());` and pass/use that instead of `this`. Same a few other places. IOW, replace both `shared_from_this()` and `this` with `this_l`" }, { @@ -1467,15 +1467,15 @@ "reference": "And here. Please, use `'` for apostrophes in changed strings in this file." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would make sense to move this to the `GasStation` struct, so that it can be used by the `GasStation` struct as well as the `SimulateExecution` function.", "reference": "assignments should only be cuddled with other assignments (from `wsl`)" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to implement the `Config` interface for `ConfigLocal`, but it's not clear what you're trying to do with the `DefaultNewBlockDataVersion` function. It's not clear what you're trying to do with the `FilesWithHolesDataVer` function. I think you're trying to implement the `Config` interface for `ConfigLocal`, but it's not clear what you're trying to do with the `DefaultNewBlockDataVersion` function. It's not clear what you're trying to do with the `FilesWithHolesDataVer` function. I think you're trying to implement the `Config` interface for `ConfigLocal`, but it's not clear what you're trying to do with the `DefaultNewBlockDataVersion` function. It's not clear what you're trying to do with the `FilesWithHolesDataVer` function. I think you're trying to implement the `Config` interface for `ConfigLocal`, but it's not clear what you're trying to do with the `DefaultNewBlockDataVersion` function. It's not clear what you're trying to do with the `FilesWithHolesDataVer` function.", + "prediction": "I'm not sure what you mean by \"DefaultNewBlockDataVersion\" is the default data version for new blocks. I think it should be the default data version for all blocks.", "reference": "Please move this to `block_types.go`." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.", + "prediction": "I don't think this is thread-safe.", "reference": "So this is not needed anymore for all attributes?" }, { @@ -1491,35 +1491,35 @@ "reference": "With this fix, I am not even sure we need to overwrite this function." }, { - "prediction": "I think we can remove the `use_tqdm` variable. It's not used anywhere in this class.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a `use_tqdm` flag in the `PackageEntry` class. I think it's a good idea to have a `use_tqdm` flag in the `Package` class as well. I'm not sure if this is a good idea, but I think it's a good idea to have a `use_tqdm` flag in the `PackageEntry` class. I think it's a good idea to have a `use_tqdm` flag in the `Package` class as well. I'm not sure if this is a good idea, but I think it's a good idea to have a `use_tqdm` flag in the `PackageEntry` class. I think it's a good idea to have a `use_tqdm` flag in the `Package` class as well. I'm not sure if this is a good idea, but I think it's a good idea to have a `use_tqdm` flag in the `PackageEntry` class. I think it's a good idea to have a `use_tqdm` flag in the `Package` class as well. I'm not sure", "reference": "Why not just import this from `data_transfer`? As a rule copying the same code twice is not a good idea. Also: please run `pylint` on all files in this PR." }, { - "prediction": "_root=>\"/opt/puppet\", :puppet_root_win=>\"none\", :puppet_root_win_win=>\"none\", :puppet_root_win_win_win=>\"none\"}\n+ expect(parser.parse_args(args)).to be === {:hosts_file=>hosts_path, :options_file=>nil, :type=>\"git\", :provision=>true, :preserve_hosts=>false, :root_keys=>false, :quiet=>false, :xml=>false, :color=>true, :debug=>true, :dry_run=>false, :fail_mode=>nil, :timesync=>false, :repo_proxy=>false, :add_el_extras=>false, :consoleport=>443, :pe_dir=>\"/opt/enterprise/dists\", :pe_version_file=>\"LATEST\", :pe_version_file_win=>\"LATEST-win\", :dot_fog=>\"#{home}/.fog\", :ec2_yaml=>\"config/image_templates/ec2.yaml\", :ssh=>{:config=>false, :paranoid=>false, :timeout=>300, :auth_methods=>[\"publickey\"], :port=>22, :forward_agent=>true, :keys=>[\"#{home}/.ssh/id_rsa\"], :user_known_hosts_file=>\"#{home", + "prediction": "_root=>\"/opt/puppet\", :puppet_root_win=>\"none\", :puppet_root_win_win=>\"none\", :puppet_root_win_win_win=>\"none\", :puppet_root_win_win_win_win=>\"none\", :puppet_root_win_win_win_win_win=>\"none\", :puppet_root_win_win_win_win_win_win=>\"none\", :puppet_root_win_win_win_win_win_win_win=>\"none\", :puppet_root_win_win_win_win_win_win_win_win=>\"none\", :puppet_root_win_win_win_win_win_win_win_win_win=>\"none\", :puppet_root_win_win_win_win_win_win_win_win_win_win=>\"none\", :puppet_root_win_win_win_win_win_win_win_win_win_win_win=>\"none\", :puppet_root_win_win_win_win_win_win_win_win_win_win_win_win=>\"none\", :puppet_root_win_win_win_win_win_win_win_win_win_win_win_win_win=>\"none\", :puppet_root_win_win_win_win_win_win_win_win_win_win_win_win_win_win=>\"none\", :puppet_root_win_win_win_win_win_win_win_win_win_win_win_win_win_win_win=>\"none\", :puppet_root_win_win_win_win_win_win_win_win_win_win_win_win_win_win_win_win=>\"none\", :", "reference": "You've got an absolute path here referencing your home dir :-)." }, { - "prediction": "I'm not sure if this is the right place to add the `prefixPropertyMetaModel` and `postfixPropertyMetaModel` to the `variableDeclarationExprMetaModel` as they are not part of the `variableDeclarationExprMetaModel.annotationsPropertyMetaModel` or `variableDeclarationExprMetaModel.modifiersPropertyMetaModel`.", + "prediction": "I don't think we need to add the `prefix` and `postfix` properties to the `variableDeclarationExprMetaModel.annotationsPropertyMetaModel` and `variableDeclarationExprMetaModel.modifiersPropertyMetaModel`.", "reference": "Maybe I should do some sorting so that these properties don't keep moving around..." }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to test here.", + "prediction": "I don't think we need to do anything here. The test is failing because it's trying to mount `/rootfs`, which is not a valid mount point.", "reference": "Can we keep this test anyway, as it's part of the spec?" }, { - "prediction": "I don't think this is a good idea. It's not a good idea to add a compiler pass to a module that doesn't use it.", + "prediction": "I think this should be `ErgonodeMailerBundle` instead of `ErgonodeMailerBundleStrategy`", "reference": "Can be removed" }, { - "prediction": "I don't think this is needed anymore. We can remove it now.", + "prediction": "I don't think this is needed anymore.", "reference": "It's a minor quibble I know, but I like having the imports ordered by lengt" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this", + "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use the `responseEx.setContentType` method to set the content type.", "reference": "It's better to get the charset from context or other setting to let the user override it." }, { - "prediction": "I'm not sure what you're trying to achieve with this code. It seems like you're trying to create a new controller for the cStorPool resources, but I'm not sure what you're trying to achieve with this code. It seems like you're trying to create a new controller for the cStorPool resources, but I'm not sure what you're trying to achieve with this code. It seems like you're trying to create a new controller for the cStorPool resources, but I'm not sure what you're trying to achieve with this code. It seems like you're trying to create a new controller for the cStorPool resources, but I'm not sure what you're trying to achieve with this code. It seems like you're trying to create a new controller for the cStorPool resources, but I'm not sure what you're trying to achieve with this code. It seems like you're trying to create a new controller for the cStorPool resources, but I'm not sure what you're trying to achieve with this code. It seems like you're trying to create a new controller for the cStorPool resources, but I'm not sure what you're trying to achieve with this code. It seems like you", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. It's a bit of a hack, but I think it's the best way to do it.", "reference": "this filename as well needs change" }, { @@ -1531,43 +1531,43 @@ "reference": "You cannot move this here because it breaks detach. Just call `tty.Close()` before returning the error from start" }, { - "prediction": "I don't think this is a good idea. The `context` property is only used in the `lookupTables.role` object, and it's not used anywhere else in the code. I think it's better to just remove it.", + "prediction": "I don't think this is necessary.", "reference": "I updated only the implicit roles who needed a update for this new rule to validate." }, { - "prediction": "I don't think we need to use `sync` here. We can just use `reflect` here.", + "prediction": "I don't think we need to use `reflect` here. We can just use `sync` here.", "reference": "> // Code generated by protoc-gen-go. DO NOT EDIT." }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be good to have this in a separate file so that it can be used by other tests.", "reference": "minor: skipOSConfigMetadata, otherwise, the name sounds like a boolean" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check for `type` here. It's possible that `type` could be `null` in this case.", + "prediction": "Shouldn't this be `if (type == null)`?", "reference": "~~I think lines 65-67 should be moved into this else clause after `type = ...` Else, it is a bit confusing why we check the enclose type validity a second time~~ Nevermind, will do some refactoring, myself. But thanks for \"fixing\" this!" }, { - "prediction": "I think this should be `endpoints.SessionsDTO` instead of `endpoints.SessionsDTO{}`.", + "prediction": "I think we can remove the `endpoints.SessionsDTO` and just return the `response.Body` directly.", "reference": "`sessions := endpoints.SessionsDTO{}` and using only `sessions` should be simpler." }, { - "prediction": "I'm not sure I understand what you're trying to do here. I think you want to make sure that the frame's uc_stack.ss_sp is not the same as the app's sigstack.ss_sp.", + "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place", "reference": "These need to be in the other order to avoid crashing when dcontext == GLOBAL_DCONTEXT (==-1)" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you want to use the `ConfigureKestrel` method here.", + "prediction": "I don't think you need to use `ConfigureKestrel` here. You can just use `UseKestrel` directly.", "reference": "Why not change the other samples?" }, { - "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `querySelector` to get the element, and then use `getAttribute` to get the attribute.", + "prediction": "I don't think we need to escape the `headers` selector here.", "reference": "Indentation is mixed up here due to spaces/tabs, I'm guessing." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in `fpga_dma_poll.c` instead of `fpga_dma_handle_poll.c`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `fpga_dma_poll.c` instead of `fpga_dma_handle.c`.", "reference": "Should we provide a little more context in the error message? Maybe throw in something about what operation was being performed?" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a `settings` key in the configuration. If you don't have a `settings` key in the configuration, then you can't use the `settings` key to get the settings from the configuration.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a default value for the `settings` key in the configuration.", "reference": "Project standard is spaces, not tabs. Please fix and then we can merge this." }, { @@ -1583,35 +1583,35 @@ "reference": "I think BSON::Decimal128 should always be serialized as Decimal128 regardless of config option." }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it would be a good idea to move this to the `bolt_spec/files` directory.", + "prediction": "I'm not sure if this is a good place to put it, but I think we should move it to the `spec` directory.", "reference": "We should probably just move the `require 'bolt/plan_creator'` in `Bolt::CLI` to `Bolt::Application` so it will already be loaded." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a `Job` with a `WarmupCount` of 1 and a `MaxTargetIterationCount` of 20. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a `Job` with a `WarmupCount` of 1 and a `MaxTargetIterationCount` of 20. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a `Job` with a `WarmupCount` of 1 and a `MaxTargetIterationCount` of 20. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a `Job` with a `WarmupCount` of 1 and a `MaxTargetIterationCount` of 20. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a `Job` with a `WarmupCount` of 1 and a `MaxTargetIterationCount` of 20. I'm not sure what you're trying to achieve with", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `DefaultConfig.Instance` in the `Benchmarks` namespace. This way, we can have a consistent `DefaultConfig.Instance` across all the benchmarks.", "reference": ">20 [](start = 45, length = 2) Can we override this at runtime? Maybe it should be a command line option with default." }, { - "prediction": "I'm not sure what you're trying to do here. Is it possible that you're trying to get the service URL from the environment variable `SERVICE_URL`? If that's the case, then I think we need to make sure that the environment variable is set before we try to get the service URL from it.", + "prediction": "I don't think this is necessary.", "reference": "can just remove it ?" }, { - "prediction": "I think this should be `if err != nil { return repo, fmt.Errorf(\"createUpdateHook: %v\", err); }`", + "prediction": "I think this should be `repo, err = FinishMigrateRepository(repo, repoPath); if err != nil { return repo, err; }`", "reference": "Better call it `CleanUpMirrorInfo`?" }, { - "prediction": "I think we should be using `node.StorageProtocol.StorageProvider.Start` instead of `node.StorageMining.Start`.", + "prediction": "I think this should be `if err := node.StorageProtocol.StorageProvider.Start(ctx); err != nil` instead of `if err := node.StorageMining.Start(ctx); err != nil`", "reference": "@shannonwells is there still something missing here?" }, { - "prediction": "I'm not sure what you're trying to achieve with this setting, but I'm not sure if it's a good idea to set it to `nil` here.", + "prediction": "I'm not sure what you mean by \"when a block passed to pending fails (as expected)\". Could you please clarify?", "reference": "This could be more indicative of what it is... e.g... `stresstest_time_limit`" }, { - "prediction": "I'm not sure what you mean by \"TopicPayloadPoolRegistry::release(reader_payload_pool_)\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to release the listener here as well.", "reference": "Shouldn't we do a `reader_payload_pool_.reset()` here?" }, { - "prediction": "I'm not sure what you mean by \"vrf proof giving this block's miner authoring rights\". Could you please clarify?", + "prediction": "I'm not sure what you mean by \"beacon entries\" and \"drand entries\". Could you please clarify?", "reference": "I'd prefer the nomenclature less tightly coupled to DRAND throughout. I played with renaming the `drand` package to `beacon` but it was too much noise in this change." }, { @@ -1619,39 +1619,39 @@ "reference": "I think I would prefer you declare `self._current_key=None` in the constructor and just return `self._current_key`. That way you can prevent anyone from overwriting `current_key` without needing to use `getattr` here." }, { - "prediction": "I think we should remove the `rawMode` and `annotationMode` from the `FromCSVOpSpec` struct.", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be a good place to put this. I'm not sure if this is a good place to put this, but I think it would be a good place to put this. I'm not sure if this is a good place to put this, but I think it would be a good place to put this. I'm not sure if this is a good place to put this, but I think it would be a good place to put this. I'm not sure if this is a good place to put this, but I think it would be a good place to put this. I'm not sure if this is a good place to put this, but I think it would be a good place to put this. I'm not sure if this is a good place to put this, but I think it would be a good place to put this. I'm not sure if this is a good place to put this, but I think it would be a good place to put this. I'm not sure if this is a good place to put this, but I think it would be a good place to put this. I'm not sure if this is a good place to put this", "reference": "I guess I like the name `mode` okay. I can't think of anything better." }, { - "prediction": "I'm not sure what you mean by \"timeout is less or equal to zero\"", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to create a step with a default timeout of 0, but if that's the case, why not just use the default timeout from the workflow?", "reference": "I would create a new method (NewStepWithDefaultTimeout?) for this purpose because timeout<=0 looks like a hidden logic" }, { - "prediction": "I don't think we need to add `limit` to the `get` method. It's not used in the `get` method.", + "prediction": "I don't think this is a good idea. It's not clear to me what the `limit` parameter is supposed to be used for. It seems like it could be used to limit the number of events returned, but I'm not sure if that's what it's supposed to be used for.", "reference": "Are these limit changes related?" }, { - "prediction": "I think this should be `from scapy.arch import *` instead of `from scapy.pton_ntop import *`?", + "prediction": "I think this should be `from scapy.arch import *` instead of `from scapy.modules.six import *`?", "reference": "Don't you mean `import scapy.consts`?" }, { - "prediction": "I think we can remove the `fmt.Sprintf` here, since it's not used anywhere else in the code.", + "prediction": "I think this is a good change, but I'm not sure if it's the best way to do it.", "reference": "`ctx` is unused in rollbackPrimary" }, { - "prediction": "I don't think we need to use `int64` for `EmptyEventTaskID` and `TransientEventID` because they are already `int32` and `int64` respectively.", + "prediction": "I don't think this is needed.", "reference": "This is not what title says." }, { - "prediction": "I think this should be `fixesToNode` instead of `applyFixesToNode`.", + "prediction": "Shouldn't this be `fixes` instead of `fixesToNode`?", "reference": "a fix applies several fixes? maybe this should simply be `applyToNode`" }, { - "prediction": "I think we can remove the `fakeGetClientset` and `fakeListOk` functions as they are no longer needed.", + "prediction": "`fakeListOk` should be `fakeGetClientset` instead of `fakeListfn`", "reference": "U1000: func `fakeGetOk` is unused (from `unused`)" }, { - "prediction": "I'm not sure why we need to import `v1` here. It's not used anywhere in the code. I think we can just import `k8s.io/client-go` instead.", + "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to have a separate file for this.", "reference": "Because there is a \"k8s.io/client-go/tools/cache\" below, we can sort out all the \"imports\" here." }, { @@ -1659,11 +1659,11 @@ "reference": "Nit should be using `goimports` to format the import statements with standard libary imports first, new line, followed by non-standard library imports." }, { - "prediction": "I think this should be `if o.PipelineSecret != \"\" {` instead of `if o.PipelineSecret != \"\" {`", + "prediction": "I think it's better to use `if o.PipelineSecret != \"\" { ... }` instead of `if o.PipelineSecret != \"\" { err := o.deleteSecret(); if err != nil { return err; } }`", "reference": "Do we not have tests for pipeline delete" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check for the version of Hadoop being used, so that we don't try to append to a file that doesn't exist.", + "prediction": "I'm not sure why we need to call `load_hadoop_cmd` here. We can just call `load_hadoop` directly.", "reference": "Good that you mention this constraint in the docstring :)" }, { @@ -1671,23 +1671,23 @@ "reference": "remove this blank?" }, { - "prediction": "I'm not sure what you mean by \"doUseSearchKey_\". Is it true that this is the same as `computedNumOfActivePartiions_`?", + "prediction": "I'm not sure what you mean by `computedNumOfActivePartiions_` - I'm not sure what you're trying to do with it.", "reference": "Partitions is misspelled 8 times in this commit, might make sense to fix the spelling for all of those." }, { - "prediction": "I don't think this is necessary.", + "prediction": "I don't think this is necessary. We can just use `qutebrowser.utils.message.error` and `qutebrowser.utils.message.warning` instead.", "reference": "Please remove this blank line - those are only used to group Python/third-party/qutebrowser imports." }, { - "prediction": "I don't think we need to add `insecure` to `actionTransferCmd` as it's not used.", + "prediction": "I don't think we need to add `insecure` to the `actionTransferCmd`", "reference": "`insecure` is a global variable (from `gochecknoglobals`)" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `http` package. It would be a good idea to add this to the `http` package as well.", + "prediction": "I don't think we need to do this, since we're already checking for `r.Proto == \"HTTP/1.1\"` and `r.Method == r.URL.Method`.", "reference": "Same as above (HTTP in upper-case)" }, { - "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to have a separate test for this. It's not clear to me if this is a good idea or not, but I think it's a good idea to have a separate test for this. It's not clear to me if this is a good idea or not, but I think it's a good idea to have a separate test for this. It's not clear to me if this is a good idea or not, but I think it's a good idea to have a separate test for this. It's not clear to me if this is a good idea or not, but I think it's a good idea to have a separate test for this. It's not clear to me if this is a good idea or not, but I think it's a good idea to have a separate test for this. It's not clear to me if this is a good idea or not, but I think it's a good idea to have a separate test for this. It's not clear to me if this is a good idea or not, but I think it's a good idea to have a separate test for this. It's not clear to me if this is a", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this.", "reference": "This is getting repetitive maybe you could introduce an abstract test case with a `getExpectedUrl($providerReference)` method ?" }, { @@ -1695,31 +1695,31 @@ "reference": "I do not think returning `Value{}` is correct here. For example, `reflect.MakeFunc(...).Kind()` would return `reflect.Invalid` instead of `reflect.Func`. Therefore, I think this should panic instead." }, { - "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `toLowerCase()` on the `name` variable.", + "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `nameLower` instead of `name` in this case. `nameLower` is more consistent with the rest of the code.", "reference": "Does this work for Custom Elements? iirc we're lacking test cases for them. /cc @andrewiggins @developit" }, { - "prediction": "I think we can remove the `for` loop here, as it's not really needed.", + "prediction": "I think this should be `m.members` instead of `m.externalNodeCIDRs`?", "reference": "Same change just above?" }, { - "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `self` in this case.", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `self` instead of `window` in this case.", "reference": "I suppose `apploader.js` isn't used by WebWorkers. So `self` will always be `window` here." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `skip_targets` variable in the `skip_test` method. This way, we don't have to repeat the `skip_targets` variable in the `test_name` method.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `skip_targets` variable in the `skip_test` block.", "reference": "Since this var is no longer defined we should remove the `if skip_targets.any?` bit below." }, { - "prediction": "I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.", "reference": "I think we should `return arn` as a fallback at the end of this function (otherwise the `['Resource']` entry below could become `None`)." }, { - "prediction": "I think we should remove the `if np.socketProtect == nil` check.", + "prediction": "I think it's better to use `close` here instead of `shutdown`.", "reference": "Why session is started at all, if you need to shut it down e.g. DI should launch noopSession" }, { - "prediction": "I'm not sure what you mean by `DeleteAll() error` and `DeleteWorkspaceFile() error`. I think you meant to say `DeleteWorkspaceFile() error` and `DeleteAll() error`.", + "prediction": "I don't think this is necessary. We can just use the `DeleteWorkspaceFile` method directly.", "reference": "nit: can we rename the interface to `wsFileDeleter`" }, { @@ -1727,47 +1727,47 @@ "reference": "Why target cannot be external endpoints?" }, { - "prediction": "I think this should be `AUTO_PREFIX` instead of `.auto_`?", + "prediction": "I'm not sure if this is the right place to add this, but I think it would be a good idea to add it to the `CollectionAdminParams` interface.", "reference": "We use a suffix \".AUTOCREATED\" for configsets, maybe we can use the same here?" }, { - "prediction": "I think we should use `OpenTelemetrySdk.Default.EnableOpenTelemetry(...)` instead of `OpenTelemetrySdk.EnableOpenTelemetry(...)`", + "prediction": "I think it's better to use `OpenTelemetrySdk.EnableOpenTelemetry()` instead of `OpenTelemetrySdk.Default.EnableOpenTelemetry()`.", "reference": "This one won't be disposed. Should be (something like) `using var openTelemetry = OpenTelemetrySdk.EnableOpenTelemetry(` no?" }, { - "prediction": "I'm not sure why we need to import `comInterfaces.UIAutomationClient` here. We can just use `UIAutomationClient` from the `comInterfaces` module.", + "prediction": "I don't think we need to import `comInterfaces.UIAutomationClient` here. We can just use `UIAutomationClient` from `comInterfaces` directly.", "reference": "Why this is in the diff?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. What is the purpose of the `CloudBackupCreate` and `CloudBackupGroupCreate` methods?", + "prediction": "I'm not sure what you're trying to do with this, but I think it's better to just use the `CloudBackupCreate` method instead.", "reference": "How is status determined? When the user calls CloudBackupCreate( src_volume_id ) they can then call CloudBackupStatus( src_volume_id ) Is there something similar for this new API?" }, { - "prediction": "I think this is a good fix, but I'm not sure if it's the best way to do it. I think it's a good idea to make sure that the `oldVNode` and `newVNode` are the same. If they are not, then we can't use `removeNode` to remove the `oldVNode` from the `excessDomChildren` array. So I think we should make sure that the `oldVNode` and `newVNode` are the same before we call `removeNode`.", + "prediction": "I think it's better to use `options._catchError` in this case instead of `options._catchError(e, newVNode, oldVNode)`.", "reference": "We could pass `excessDomChildren` to `options._catchError` and only do this if an error-boundary catches the error. Not entirely sure if that's better." }, { - "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to use `call_user_func_array` instead of `call_user_func` in this case.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `getFilters()` method.", "reference": "In php8 named parameters were introduced and now it is required to match called method parameter name when setting parameters by array destructing or call_user_func_array() etc." }, { - "prediction": "I think we can remove the `if !sc.IsValid() { return ctx; }` line.", + "prediction": "I think it's better to return `sc` here, since we don't need to check if `sc` is valid anymore.", "reference": "If instead we had `B3.extractSingleHeader` and `B3.extract` return a bool value as a second return value, we could avoid the byte array comparison in `TraceID.IsValid`. Did you consider that alternative?" }, { - "prediction": "I think it's better to use `create_and_continue` instead of `create_and_add_another`.", + "prediction": "I don't think this is a good idea. It's not clear to the user what they are trying to do when they click on the \"create and continue\" button.", "reference": "I think this is more of a semantic difference than a typo - `weiter hinzufgen` is like `continue adding` whereas `weitere hinzufgen` is like `add more`. I think it makes sense to change it though" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate test for this.", + "prediction": "I think this test should be moved to a separate test case.", "reference": "nit: 200 is superfluous" }, { - "prediction": "I think this test should be moved to `SchemaTest` instead of `SchemaTest::metaCommunication`.", + "prediction": "I think it's better to use `cpp2::ExecutionResponse` instead of `cpp2::ExecutionResult` in this case.", "reference": "This is testing `unreserved keyword`" }, { - "prediction": "I think we should remove the `nullptr` from `paramsNatOrigin` and `paramsSch` in the projection method mappings.", + "prediction": "I'm not sure if this is the right place to add this method, but I think it would be a good idea to add this method to the `Projection` class as well.", "reference": "paramsNatOrigin doesn't include sUVtoST. I would just remove that definition for now" }, { @@ -1779,15 +1779,15 @@ "reference": "AWS Identity and Access Management (IAM)" }, { - "prediction": "I'm not sure what you mean by `RESOURCE_NAME_INSTANCES` and `RESOURCE_NAME_AUTHORIZEDNETWORKS`? I think they should be `RESOURCE_NAME` and `RESOURCE_NAME_AUTHORIZEDNETWORKS` respectively.", + "prediction": "I don't think this is a good idea. We should use `cloudsql` instead of `cloudsql_instances` and `cloudsql_ipaddresses`.", "reference": "As a long term thing, would it make sense to move the resource names as keys under the requirements map?" }, { - "prediction": "I'm not sure what you mean by \"headers\" in this context. It's not clear what you're trying to do with it.", + "prediction": "I don't think this is necessary. `cell.getAttribute('headers')` will always return `true` if the table has headers.", "reference": "That doesn't fix the whole problem. The issue lays in this line right here, not the one above. There are two problems with this line: 1. It finds things that aren't cells in the table 2. if it doesn't find anything, it shouldn't return empty here, but continue down to look for row/ column headers." }, { - "prediction": "I'm not sure what you're trying to do here, but I think it's a bad idea to have a `@InputFile` annotation on a `@Input` annotation. It's not clear what you're trying to do here.", + "prediction": "I think this should be `getProject().getAllprojects().stream().flatMap(project -> BaselineVersions.getResolvedArtifacts(project).stream()).collect(Collectors.toSet());`", "reference": "I am pretty sure that this is infinite recursion as getAllProjects returns the project itself." }, { @@ -1795,27 +1795,27 @@ "reference": "Something I didn't catch before I merged this PR, is the hyphenated constant a problem? E.g. should \"data-lists\" be \"data_lists\"? @paulkaplan" }, { - "prediction": "I think this should be `if (not conf.use_winpcapy) and (not conf.use_pcap) and (not conf.use_dnet)`.", + "prediction": "I'm not sure if this is a good idea, but I don't see why it would be a problem.", "reference": "Can you write the test as `if not (conf.use_winpcapy or conf.use_pcap or conf.use_dnet):`" }, { - "prediction": "I think this should be `check.callable_param` instead of `check.callable_param(fn, \"fn\")`", + "prediction": "I think this should be `check.callable_param(fn, \"Callable[[], Any]\")` instead of `check.callable_param(fn, \"fn\")`", "reference": "we have to include foreign assets on the repository directly because they don't belong to a job? This seems very awkward... Is this a step towards the job-less assets on the repository? Did you consider having `build_asset_job` take in a set of foreign assets instead? I suppose we would then need to subclass it to be a more special `AssetJobDefinition` that can keep track of them." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `std::unique_ptr` here. It's not safe to use `std::unique_ptr` in this way.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that `deleteOnDestroy_` is set to `true` before creating the temp directory.", "reference": "`-Wstringop-truncation` is a new kind of error detector introduced in GCC 8. As for this patch, these are two false-positives though." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `awserr` package.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `awserr` package. It's a bit more specific than `awserr.ErrCodeSharedConfig`.", "reference": "Can we port this error msg to v2 too? This one is better, as it explicitly states what sources are allowed." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to mock the `readPreference` property of the `ReadPreference` object, but I'm not sure what you're trying to achieve with that.", + "prediction": "I don't think we need to use `ReadPreference` here. We can just use `defaultReadPreference`.", "reference": "The convention so far has been to require directly from the defining file (in this case `../../read_preference') . I think the concern has been mostly about the potential for circular dependency cycles" }, { - "prediction": "I don't think this is a good idea. It's not clear to me what `color_type` is supposed to do.", + "prediction": "I don't think this is a good idea. The `to_float32` parameter should be optional, and the `color_type` parameter should be required.", "reference": "I suggest expanding dims here to simplify the formatting." }, { @@ -1827,35 +1827,35 @@ "reference": "The `!r` is unnecessary." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `accountKey` and `sasToken` in `openerFromEnv` and `openerFromMSI` so that we don't have to check for `accountKey` and `sasToken` in `openerFromEnv` and `openerFromMSI` if `accountKey` and `sasToken` are not set.", + "prediction": "I'm not sure why we need to check for `accountKey != \"\"` here. I think we can just use `accountKey != \"\" || sasToken != \"\"` instead.", "reference": "I didn't see existing tests for this `OpenBucketURL`. Not sure if it's easy to do without mocking these `opener` calls." }, { - "prediction": "I'm not sure what you mean by `PreparerNeeded`. Is it true that it's always `true`? If so, I think we should remove it.", + "prediction": "I don't think this is needed. The `PreparerNeeded` property is only set when the model is not paged. If the model is paged, the `PreparerNeeded` property will always be `false`.", "reference": "Should we default to `true` ?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `consensus/fsm` package to create a state machine for a consensus protocol. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `consensus/fsm` package to create a state machine for a consensus protocol. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `consensus/fsm` package to create a state machine for a consensus protocol. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `consensus/fsm` package to create a state machine for a consensus protocol. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `consensus/fsm` package to create a state machine for a consensus protocol. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `consensus/fsm` package to create a state machine for a consensus protocol. I'm not sure what you're trying to achieve", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. The `consensus/fsm` package is not meant to be used in this way.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { - "prediction": "I'm not sure what you mean by `useBuiltIns: 'entry'` and `useBuiltIns: 'entry', corejs: 2`", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `babelrc` and `babel-preset-react` for this.", "reference": "Shouldn't these options also include `@babel/preset-env`? Also I see you set `babelrc` to `false`, could we rely on our existing `.babelrc` file? Feels like some duplicate configuration otherwise." }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to log the remote address as well. It's not clear to me why we need to log the local address, but I think it's a good idea to log the remote address as well.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this.", "reference": "Nit: We can use `%s` since `disconnectReason` is a string." }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. Is it that you're trying to train a model on a subset of the data? Or is it that you're trying to train a model on a subset of the training data? Or is it that you're trying to train a model on a subset of the test data? Or is it that you're trying to train a model on a subset of the training and test data? Or is it that you're trying to train a model on a subset of the training and test data? Or is it that you're trying to train a model on a subset of the training and test data? Or is it that you're trying to train a model on a subset of the training and test data? Or is it that you're trying to train a model on a subset of the training and test data? Or is it that you're trying to train a model on a subset of the training and test data? Or is it that you're trying to train a model on a subset of the training and test data? Or is it that you're trying to train a model on a subset of the training and test data? Or is it that you're trying to train", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `objective='regression'` and `boosting_type='rgf'` instead of `objective='regression'` and `num_leaves=31` and `learning_rate=0.05` and `n_estimators=20` because `objective='regression'` and `boosting_type='rgf'` are the same as `objective='regression'` and `num_leaves=31` and `learning_rate=0.05` and `n_estimators=20`, but `objective='regression'` and `boosting_type='rgf'` are different from `objective='regression'` and `num_leaves=31` and `learning_rate=0.05` and `n_estimators=20`.", "reference": "I think it's better to create a new example" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the same place as the `sync_color_attachment_output_color_attachment_read` and `sync_color_attachment_output_color_attachment_write` actions.", "reference": "The stages are correct, but the more forgiving `kAttachmentRasterOrder` should be used, based on a review of the spec. That should give the same effect of suppressing the false positive conflict between the DEPTH R/W and resolve. > End-of-subpass multisample resolves are treated as color attachment writes for the purposes of synchronization. This applies to resolve operations for both color and depth/stencil attachments. That is, they are considered to execute in the VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT pipeline stage and their writes are synchronized with VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT. Synchronization between rendering within a subpass and any resolve operations at the end of the subpass occurs automatically, without need for explicit dependencies or pipeline barriers." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate list of all the possible acids that can be used in the base pair.", + "prediction": "I think it's a good idea to add a `--` at the end of the list.", "reference": "To be consistent, I think it should actually just be a single `-`" }, { @@ -1875,35 +1875,35 @@ "reference": "Repeating: I don't think this should be a core-wide global var. This should be isolated to arch/x86 or at least arch/, maybe inside getter/setters as mentioned above." }, { - "prediction": "I don't think this is a good idea. It's not clear to me what the purpose of this is. It's not clear to me what the purpose of this is. It's not clear to me what the purpose of this is. It's not clear to me what the purpose of this is. It's not clear to me what the purpose of this is. It's not clear to me what the purpose of this is. It's not clear to me what the purpose of this is. It's not clear to me what the purpose of this is. It's not clear to me what the purpose of this is. It's not clear to me what the purpose of this is. It's not clear to me what the purpose of this is. It's not clear to me what the purpose of this is. It's not clear to me what the purpose of this is. It's not clear to me what the purpose of this is. It's not clear to me what the purpose of this is. It's not clear to me what the purpose of this is. It's not clear to me what the purpose of this is. It's not clear to me what the purpose of this is. It's not clear to me what the purpose of this is", + "prediction": "I don't think we need to change this. It's the same as before.", "reference": "right URL is like in cmdrunner, using search.maven .org" }, { - "prediction": "I'm not sure what you mean by this, but I think it should be `Uri` instead of `string`.", + "prediction": "I think it's better to use `string` here instead of `Uri`.", "reference": "The link to valid syntax is not really applicable for NET2_1, right?" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to escape a string, which I don't think is what you want to do.", + "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to have a separate `pubsub` package for pubsub, and a separate `pubsub` package for pubsub. This way, we don't have to import `pubsub` in `pubsub` and `pubsub` in `gcspubsub`, and we don't have to import `pubsub` in `gcspubsub` and `gcspubsub` in `gcspubsub`.", "reference": "Shouldn't it be more specific, like \"gcppubsub supports all UTF-8 strings\"?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way", + "prediction": "I think we need to make sure that the secondaries are stopped before the slaves are stopped.", "reference": "Everything in this class is SolrCloud-related, not legacy replication" }, { - "prediction": "I think this should be `if (!manager->are_flags_dead) {` instead of `if (!manager->are_flags_dead) { reg_t val = (reg_t)drbbdup_get_tls_raw_slot_val(DRBBDUP_FLAG_REG_SLOT); reg_t newval = mcontext->xflags; val = (reg_t)drbbdup_get_tls_raw_slot_val(DRBBDUP_FLAG_REG_SLOT); sahf = (val & 0xff00) >> 8; newval &= ~(EFLAGS_ARITH); newval |= sahf; if (TEST(1, val)) /* seto */ newval |= EFLAGS_OF; reg_t val = (reg_t)drbbdup_get_tls_raw_slot_val(DRBBDUP_FLAG_REG_SLOT); reg_t newval = mcontext->xflags; val = (reg_t)drbbdup_get_tls_raw_slot_val(DRBBDUP_FLAG_REG_SLOT); sahf = (val & 0xff00) >> 8; newval &= ~(EFLAGS_ARITH); newval |= sahf; if (TEST(1, val)) /* seto */ newval |= EFLAGS_OF; reg_t val = (reg_t)drbbdup_get_tls_raw", + "prediction": "I think this should be `if (!manager->are_flags_dead)` instead of `if (!manager->are_flags_dead && !manager->is_scratch_reg_dead)`.", "reference": "Could just assign directly and eliminate the `newval` var." }, { - "prediction": "I'm not sure if this is the right place to add this comment, but I think it would be good to add it here. I'm not sure if this is the right place to add this comment, but I think it would be good to add it here. I'm not sure if this is the right place to add this comment, but I think it would be good to add it here. I'm not sure if this is the right place to add this comment, but I think it would be good to add it here. I'm not sure if this is the right place to add this comment, but I think it would be good to add it here. I'm not sure if this is the right place to add this comment, but I think it would be good to add it here. I'm not sure if this is the right place to add this comment, but I think it would be good to add it here. I'm not sure if this is the right place to add this comment, but I think it would be good to add it here. I'm not sure if this is the right place to add this comment, but I think it would be good to add it here. I'm not sure if this is the right place to add this", + "prediction": "I don't think we need to change this. I think we can just use the `issueTitleRegexp` and `pullRequestTitleRegexp` here.", "reference": "... with the name of the affected package, or \"all\", followed by a colon,..." }, { - "prediction": "I think we should remove the `text => FullVersionReplace(text, \".\");` line.", + "prediction": "I'm not sure why we're doing this, but I think it's a good idea.", "reference": "We'll want to remove this one if we make the assembly version constant." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a good idea to add a `use` statement at the top of the file. This will make it easier for other developers to see that this file is part of the `Frontend` class.", "reference": "Can we have a single function here that uses the same subscribers and just changes meta based on context?" }, { @@ -1911,43 +1911,43 @@ "reference": "where would ` static startup_kernel_loader skl;` be instantiated? if it's not instantiated anywhere should this be removed?" }, { - "prediction": "I think it's better to use `getFilesAndDirectoriesApi` instead of `webkitGetAsEntryApi`.", + "prediction": "I think this should be `getFilesAndDirectories` instead of `getFilesAndDirectoriesApi`?", "reference": "I think we should move those util functions that work with drag-drop to @uppy/utils, so they can be shared (maybe later) with drag-drop plugin? Otherwise it will continue to depend on drag-drop module." }, { - "prediction": "I'm not sure what you mean by \"deep copy\" here. I think you meant to say \"make a shallow copy\"", + "prediction": "`spec.ReplicaSet` should be `spec.ReplicaSet.Nodes`", "reference": "Migrate the spec.Labels to locator.Labels ?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this.", "reference": "The test case already existed but it never tested properly because of the conditional in the test." }, { - "prediction": "I think this should be `==` instead of `equals`.", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to compare the `sourceId` and `name` fields, but that's not what this method is doing. It's comparing the `sourceId` and `name` fields of the two `PartitionField` objects. If you want to compare the `sourceId` and `name` fields of two `PartitionField` objects, you should use the `equals` method.", "reference": "I'm okay with this, but I don't see a lot of benefit to removing unnecessary parens. If extra parens make something more readable (like this) or clarify order of operations even when matching the default, I would say we should keep them." }, { - "prediction": "I don't think this is necessary. The `getDynamicFields()` method is called only once, so it's not necessary to create a new instance of `DynamicField[]` each time.", + "prediction": "I don't think this is necessary. The `getDynamicFields` method is called only once, and the `getDynamicFields` method returns a `Map`, so we don't need to create a new `Map` each time.", "reference": "@sarowe why was this volatile? It's fishy to see this as the only volatile field." }, { - "prediction": "can you add some more information about what this event is used for?", + "prediction": "can we remove the `@see` tag?", "reference": "template is not correct?" }, { - "prediction": "I think we can remove the `ASSIGNERS` and `SAMPLERS` from the imports.", + "prediction": "I don't think this is needed anymore.", "reference": "Rename the registies to `BBOX_ASSIGNERS` and `BBOX_SAMPLERS` to avoid ambiguity. There is also a registry for dataset sampler." }, { - "prediction": "I'm not sure what you're trying to do here, but I'm not sure why you're using `FakeFS.activate!` instead of just `FakeFS.activate`.", + "prediction": "I'm not sure why we need to activate the fake filesystem here. I think we can just use `vagrant up` and `vagrant destroy --force` directly.", "reference": "This is no longer stubbed on every test. Perhaps it should be, and should be unstubbed in the single case that it matters." }, { - "prediction": "I think this should be `get '/500_error' do` instead of `get '/admin/status' do`?", + "prediction": "I think we can remove the `get '/admin/status' do` as it's not needed anymore.", "reference": "This seems much simpler! I'm not sure I follow what you mean by the threading part... Also tests are not liking this constant. Might need a require or to fully qualify this." }, { - "prediction": "I'm not sure what you mean by \"fall-through: Windows only\". I think this should be `case SINGLE_STEP_EXCEPTION: sig = SIGSEGV; break;` instead.", + "prediction": "I think this should be `SIGSEGV` instead of `SIGILL`.", "reference": "Convention is \"FIXME: i#2144\" or \"XXX: i#2144\"" }, { @@ -1955,11 +1955,11 @@ "reference": "This should probably be a property instead of a method." }, { - "prediction": "I think we can remove the `state` field from the `status` field.", + "prediction": "I think we can remove the `autoUpgrade` field, as it's not needed anymore.", "reference": "do we need to consider setting the `state` as well? If so, lot of changes might be required, like, setting to 'Reconciling' in upgrade code, setting to 'error' or 'reconciled' in volumeReconciler functions." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to override the default solr processor chain, but I don't think that's what you're trying to do here. I think you're trying to override the default solr processor chain, but I don't think that's what you're trying to do here. I think you're trying to override the default solr processor chain, but I don't think that's what you're trying to do here. I think you're trying to override the default solr processor chain, but I don't think that's what you're trying to do here. I think you're trying to override the default solr processor chain, but I don't think that's what you're trying to do here. I think you're trying to override the default solr processor chain, but I don't think that's what you're trying to do here. I think you're trying to override the default solr processor chain, but I don't think that's what you're trying to do here. I think you're trying to override the default solr processor chain, but I don't think that's what you're trying to do here. I think you're trying to override the default solr processor", + "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to add more parameters to the default processor chain, but I'm not sure if that's the best way to do it. I think it would be better to keep the default processor chain as it is and just add more parameters to it.", "reference": "Line is too long. [82/80]" }, { @@ -1967,35 +1967,35 @@ "reference": "Add blank line below license header." }, { - "prediction": "I think this should be `if (orCreate)` instead of `if (ops.current() != null)`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `Catalog` class.", "reference": "I'm not clear on whether this really should be the right behavior. Basically we're saying that a replace table will keep the existing location (as opposed to using defaults). I suspect we don't have create or replace with location semantics, but this is making some assumptions that a replacement is somehow the same as the old. If we were to go with id based pathing convention, this wouldn't work. I don't think this is an issue at this point, but it might make sense to push this down to the location provider." }, { - "prediction": "I'm not sure if this is a good place to put this, but I think we should move it to `temporal-proto/replication` so that it can be used in the `replicationgen.pb.go` file.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `replicationgenpb` package.", "reference": "Just run a global replacement for all `executionproto`." }, { - "prediction": "I'm not sure I understand what you're trying to do here. What is the purpose of the `keep_alive` parameter? What is the purpose of the `file_detector` parameter? What is the purpose of the `options` parameter? What is the purpose of the `command_executor` parameter? What is the purpose of the `desired_capabilities` parameter? What is the purpose of the `browser_profile` parameter? What is the purpose of the `proxy` parameter? What is the purpose of the `keep_alive` parameter? What is the purpose of the `file_detector` parameter? What is the purpose of the `options` parameter? What is the purpose of the `command_executor` parameter? What is the purpose of the `desired_capabilities` parameter? What is the purpose of the `browser_profile` parameter? What is the purpose of the `proxy` parameter? What is the purpose of the `keep_alive` parameter? What is the purpose of the `file_detector` parameter? What is the purpose of the `options` parameter? What is the purpose of the `command_executor` parameter? What is the purpose of the `desired_capabilities` parameter? What is the purpose of the `browser_profile` parameter? What is the purpose of the `", + "prediction": "I'm not sure what you mean by \"keep_alive=False\" and \"file_detector=None\"", "reference": "@AutomatedTester @davehunt thoughts on a new keyword argument?" }, { - "prediction": "I'm not sure what you mean by \"other errors could be\". Is it possible that this error could be something else?", + "prediction": "I'm not sure what you mean by \"other errors could be\". Is it possible that this error could be caused by a bad file descriptor? If so, I think it's better to return an error code of `EBADF` instead of `EINVAL`.", "reference": "Should line 47 be OPAE_ERR?" }, { - "prediction": "I don't think we need to use `zeroTime` here. We can just use `time.Now()`.", + "prediction": "I don't think we need to use `zeroTime` here. We can use `time.Now()` instead.", "reference": "Not necessary, just write `time.Time{}`" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `tabbar-size` setting.", + "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good idea to move this to the `tabbar` section.", "reference": "As these two strings simply get concatenated for the docs, there's a space missing after the dot here." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to use the `IntegrationOptions.RecordTelemetry()` method, but you're not using it.", + "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason why you want to record the telemetry?", "reference": "What about integrations where we don't plug ourselved on OnMethodBegin?" }, { - "prediction": "I'm not sure what you mean by \"at least one element visible\". Is it possible to have more than one element on the page?", + "prediction": "I think it's better to use `__call__` here.", "reference": "shouldn't **call** return a boolean?" }, { @@ -2003,15 +2003,15 @@ "reference": "ViewModel classes should not expose any classes from framework.model." }, { - "prediction": "I think we can remove the `None` value from the error message, since it's not a valid value for the `string_field` field.", + "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to make sure that the `None` value is not passed to the `validate` function.", "reference": "how would you feel about keeping these tests to be more explicit and having them `assert not _validate...`? or is your view that that is too duplicative of the tests in `test_evaluator.py`?" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `--format` option to specify the format of the output.", "reference": "Why do we use the `winrm_nodes` variable here and not the string `\"winrm_nodes\"` as we were using before?" }, { - "prediction": "I don't think we need to change the license.", + "prediction": "I don't think we need to change this.", "reference": "why update Copyright ?" }, { @@ -2019,19 +2019,19 @@ "reference": "Does this mean we cannot update statistics with sampling on a table with LOB columns?" }, { - "prediction": "I think this should be `ClearCacheOption` instead of `OnInitialize`?", + "prediction": "I don't think this is a good idea. It would be better to have a constructor that takes a .", "reference": "Look good, but I think a `[flags]` enum would be more future proof? Although i'm not sure if a flags-enum is working from the XML config. What do you think?" }, { - "prediction": "I think it's better to use `ui-grid-icon-minus-squared` and `ui-grid-icon-plus-squared` instead of `ui-grid-icon-minus` and `ui-grid-icon-plus`.", + "prediction": "I think this should be `ui-grid-icon-plus-squared` and `ui-grid-icon-minus-squared` instead of `ui-grid-icon-minus-squared` and `ui-grid-icon-plus-squared`.", "reference": "Since I believe state will never be anything other than 'expanded' or collapse, you can rewrite this as follows: `return row.treeNode.state === 'expanded' ? 'ui-grid-icon-minus-squared' : 'ui-grid-icon-plus-squared'; `" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate class for the `SolrHttp2Client` and `SolrHttp2SolrClient` classes. The `SolrHttp2SolrClient` class would be responsible for creating the `SolrHttp2Client` and the `SolrHttp2SolrClient` class would be responsible for creating the `SolrHttp2SolrClient`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate class for the `SolrCloudHttp2Client` and `SolrCloudHttp2SolrClient`.", "reference": "the latter part can go but isn't the first part of this still sound -- that we assume \"id\"?" }, { - "prediction": "I think we can remove the `@` and `\\$` from the `replace` calls.", + "prediction": "I think it's better to use `@` and `$` instead of `@/g` and `\\$/g`.", "reference": "Why is the escaping of @ and $ removed?" }, { @@ -2039,11 +2039,11 @@ "reference": "Nit: `Http` is redundant in this interface's name." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to check if the SynchronizableEntitiesPrefix already exists before trying to create it.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for the existence of the `SynchronizableEntitiesPrefix` key in the store.", "reference": "what if I set SynchronizableEntitiesPrefix to \"a/b/c/d\" in config?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check here to make sure the project name is not empty.", + "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to check that the path is a directory before trying to list the files in it.", "reference": "nit: This error message doesn't mention that the path is a directory, maybe \"Dockerfile path is a directory:%s, please provide path to file.\"" }, { @@ -2055,27 +2055,27 @@ "reference": "This is needed in `set_value` because of `:open-editor` (you could open an editor, close the tab, then close the editor). I don't think it makes any sense to have it here?" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I don't think we need to change the default value for `profiling_enabled` and `profiling_port` to `true` and `12345` respectively. We can just set them to `true` and `12345` in the `agentConfig` struct.", "reference": "Perhaps we can assume that profiling is enabled if ProfilingPort is set? And/or configure a default port and frequency, so we don't have to set three config vars every time?" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to add a `forward_agent` option to the `Vagrant.configure(2)` block. I'm not sure what you're trying to do here, but it looks like you're trying to add a `forward_agent` option to the `Vagrant.configure(2)` block. I'm not sure what you're trying to do here, but it looks like you're trying to add a `forward_agent` option to the `Vagrant.configure(2)` block. I'm not sure what you're trying to do here, but it looks like you're trying to add a `forward_agent` option to the `Vagrant.configure(2)` block. I'm not sure what you're trying to do here, but it looks like you're trying to add a `forward_agent` option to the `Vagrant.configure(2)` block. I'm not sure what you're trying to do here, but it looks like you're trying to add a `forward_agent` option to the `Vagrant.configure(2)` block. I'm not sure what you're trying to do here, but it looks like you're trying to add a `forward_agent` option to", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to add the `forward_agent` option to the `Vagrant.configure(2)` block. I'm not sure what you're trying to do here, but it looks like you're trying to add the `forward_agent` option to the `Vagrant.configure(2)` block. I'm not sure what you're trying to do here, but it looks like you're trying to add the `forward_agent` option to the `Vagrant.configure(2)` block. I'm not sure what you're trying to do here, but it looks like you're trying to add the `forward_agent` option to the `Vagrant.configure(2)` block. I'm not sure what you're trying to do here, but it looks like you're trying to add the `forward_agent` option to the `Vagrant.configure(2)` block. I'm not sure what you're trying to do here, but it looks like you're trying to add the `forward_agent` option to the `Vagrant.configure(2)` block. I'm not sure what you're trying to do here, but it looks like you're trying to add the `forward_agent` option to", "reference": "This nil check won't correctly handle the case where forward_ssh_agent is set to false - it won't be nil but it should still not be set." }, { - "prediction": "I'm not sure I understand what you're trying to do here. Can you please provide some more context?", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `voteFilterRequestEvent` instead of `voteAcceptedEvent`.", "reference": "We could avoid passing proto since threshold isn't needed." }, { - "prediction": "I think this should be `if config.GetBool(config.FlagKeepConnectedOnFail)` instead of `if false && config.GetBool(config.FlagKeepConnectedOnFail)`.", + "prediction": "I think it's better to use `if config.GetBool(config.FlagKeepConnectedOnFail)` instead of `if false && config.GetBool(config.FlagKeepConnectedOnFail)`.", "reference": "This route excluding needed for reconnect only when one connection is lost and we trying to establish another. I was thinking to make 2 separate flags for killswitch and reconnect enabling. This way we can keep killswitch working, but we don't need these routes excluded." }, { - "prediction": "I'm not sure what you mean by \"open rocksdb on \"path\"\". I think you meant to say \"open rocksdb on \"/path/to/rocksdb\"?\"", + "prediction": "I don't think we need to reset the db here. We already have a reference to the db so we don't need to create a new one.", "reference": "why can this modification avoid crash?" }, { - "prediction": "Shouldn't this be `@account` instead of `current_user`?", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `AccountController` instead of in the `RedirectIfDisabled` module.", "reference": "This looks good -- signing out the user if the current user is disabled" }, { @@ -2083,15 +2083,15 @@ "reference": "The line exceeds 120 characters." }, { - "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to add a new row to the table, but you're also trying to add a new line to the output string. I'm not sure what you're trying to do here. It looks like you're trying to add a new row to the table, but you're also trying to add a new line to the output string. I'm not sure what you're trying to do here. It looks like you're trying to add a new row to the table, but you're also trying to add a new line to the output string. I'm not sure what you're trying to do here. It looks like you're trying to add a new row to the table, but you're also trying to add a new line to the output string. I'm not sure what you're trying to do here. It looks like you're trying to add a new row to the table, but you're also trying to add a new line to the output string. I'm not sure what you're trying to do here. It looks like you're trying to add a new row to the table, but you're also trying to add a new line to the output string. I'm not sure", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `ddevapp.RenderAppRow` function.", "reference": "Let's go ahead and change \"Site\" to \"Project\", since that's the path we've chosen. One less thing to alter in the other issue." }, { - "prediction": "I think it's better to use `fmt.Sprintf` instead of `sw.Printf` here.", + "prediction": "I think we can remove this line, as it's not needed anymore.", "reference": "I am for this change iff we are sure the information is no longer helpful. I think this could still be valuable for certain scenarios, wbu?" }, { - "prediction": "I think we can remove the `log.info(\"Flow object is null, so continue\")` line.", + "prediction": "I think we can remove the `orElseThrow` here, since the `fetchImageVersion` method returns `Optional`, and we don't want to throw an exception here.", "reference": "I thought we decided on using the latest active version and not the one which is max ramped up." }, { @@ -2099,23 +2099,23 @@ "reference": "can we update this to a `log.Warningf`?" }, { - "prediction": "I'm not sure why we need to run `docker network disconnect` when we can just use `docker network rm`?", + "prediction": "I'm not sure why we need to run `docker network disconnect` here. We can just use `docker network rm` to remove the network.", "reference": "can we get something emitted in the logs on non-zero exits to trace back to for problems like this failing on the first invocation?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to add a vertex to a space that doesn't exist, but I'm not sure what you're trying to do here. I think you're trying to add a vertex to a space that doesn't exist, but I'm not sure what you're trying to do here. I think you're trying to add a vertex to a space that doesn't exist, but I'm not sure what you're trying to do here. I think you're trying to add a vertex to a space that doesn't exist, but I'm not sure what you're trying to do here. I think you're trying to add a vertex to a space that doesn't exist, but I'm not sure what you're trying to do here. I think you're trying to add a vertex to a space that doesn't exist, but I'm not sure what you're trying to do here. I think you're trying to add a vertex to a space that doesn't exist, but I'm not sure what you're trying to do here. I think you're trying to add a vertex to a space that doesn't exist, but I'm not sure what you're trying to do here. I think you're", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate test for this.", "reference": "Do we need `schema manager` at here ?" }, { - "prediction": "I think this should be `import \"C\"` instead of `import \"unsafe\"`.", + "prediction": "I think this should be `import \"C\"` instead of `import \"unsafe\"`", "reference": "This won't work because of the permissions on the directory when this is included as a library. But, we may be able to do this. The key would be wrapping this command with either a script or a go binary that ensures the current directory is writable. If the current directory is not writable, it would attempt to make it writable so that we could write out the produced binary. But I'm not sure if that will influence the hash that gets produced for `go.sum` since I am not sure how that is calculated. Alternatively, we can choose a place in `/usr/local` or choose a location that is writable in the go cache and use that. I'll give that a try since it might be needed for the ARM builds if we choose to only include `x86_64` precompiled binaries in the module." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the return value of the `semPkg` function from the interpreter. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the return value of the `semPkg` function from the interpreter. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the return value of the `semPkg` function from the interpreter. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the return value of the `semPkg` function from the interpreter. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the return value of the `semPkg` function from the interpreter. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the return value of the `semPkg` function from the interpreter. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the return value of the `semPkg` function from", + "prediction": "I'm not sure what you're trying to do here. I don't think we need to change anything here.", "reference": "Correct me if I'm wrong, but is this necessary? Why not just use the value returned by `interpreter.Eval` and not mess with the scope? `interpreter.Eval` will return any produced side effects. This means TableObjects as well as any value resulting from any expression statements." }, { - "prediction": "I'm not sure what you mean by \"operated-alertmanager\" in this context. It's not clear to me what you're trying to do with this label.", + "prediction": "I don't think we need to merge the labels here, we can just use the labels from the config.", "reference": "This service is global per namespace, not per Alertmanager/Prometheus/ThanosRuler instance. So this approach won't work. But maybe I missing out something, can you describe your use case here?" }, { @@ -2123,39 +2123,39 @@ "reference": "Do we need this default? Since we aren't using a sql.NullBool or *bool, an unset column will be interpreted as `false` already... We don't set a default on our other bool fields (e.g. entry admin and downstream columns)." }, { - "prediction": "I'm not sure what you mean by \"display section?\". Is it something like this? `display_section?(customization, section, show_custom_sections)`?", + "prediction": "I'm not sure what you mean by \"display section?\"", "reference": "thanks for moving these over. makes more sense for them to be in the exports_helper" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to use the `STARTCHARS` string as a filter for the `LastPress` enum, but I'm not sure what you're trying to do here. I think you're trying to use the `STARTCHARS` string as a filter for the `LastPress` enum, but I'm not sure what you're trying to do here. I think you're trying to use the `STARTCHARS` string as a filter for the `LastPress` enum, but I'm not sure what you're trying to do here. I think you're trying to use the `STARTCHARS` string as a filter for the `LastPress` enum, but I'm not sure what you're trying to do here. I think you're trying to use the `STARTCHARS` string as a filter for the `LastPress` enum, but I'm not sure what you're trying to do here. I think you're trying to use the `STARTCHARS` string as a filter for the `LastPress` enum, but I'm not sure what you're trying to do here. I think you're trying to use the `STARTCHARS` string as a", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to `qutebrowser.config.parsers` so that it can be used by `qutebrowser.keyinput` and `qutebrowser.keyconf`.", "reference": "That import now isn't needed anymore" }, { - "prediction": "I'm not sure what you mean by \"full path to the addon that will be installed\"", + "prediction": "I don't think this is needed anymore.", "reference": "Can you update the `Usage` to be an absolute path as well? Something like `/path/to/firebug.xpi`" }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it's a good idea to have this in the `IMvxPlugin` interface.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `IMvxPlugin` interface, so that it can be used by other plugins as well.", "reference": "This class is missing the `MvxPlugin` attribute" }, { - "prediction": "I'm not sure what you mean by \"no longer executes callbacks while NVDA's main thread is within apopup menu or message box\". I'm not sure what you mean by \"no longer executes callbacks while NVDA's main thread is within apopup menu or message box\". I'm not sure what you mean by \"no longer executes callbacks while NVDA's main thread is within apopup menu or message box\". I'm not sure what you mean by \"no longer executes callbacks while NVDA's main thread is within apopup menu or message box\". I'm not sure what you mean by \"no longer executes callbacks while NVDA's main thread is within apopup menu or message box\". I'm not sure what you mean by \"no longer executes callbacks while NVDA's main thread is within apopup menu or message box\". I'm not sure what you mean by \"no longer executes callbacks while NVDA's main thread is within apopup menu or message box\". I'm not sure what you mean by \"no longer executes callbacks while NVDA's main thread is within apopup menu or message box\". I'm not sure what you mean by \"no longer executes callbacks while NVDA's main thread is within apopup menu or message box\". I'm not sure", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `wx.GetApp().SetTopWindow(mainFrame)` instead of `mainFrame.SetTopWindow(mainFrame)`.", "reference": "What if `wxLang` is returned `None` from `getWxLang`" }, { - "prediction": "I think it's better to use `ResultCode::SUCCEEDED` instead of `ResultCode::SUCCEEDED != ret_code`.", + "prediction": "I think it's better to use `ResultCode::SUCCEEDED` instead of `ResultCode::SUCCEEDED != ResultCode::SUCCEEDED`.", "reference": "Please don't do changing like this unless it _**really**_ cares. BTW. Please look around to infer our naming conventions." }, { - "prediction": "I think we can remove the `before` and `after` methods.", + "prediction": "I think this should be `System.setProperty(\"webdriver.remote.shorten_log_messages\", \"true\");` instead of `GlobalTestEnvironment.get().setProperty(\"webdriver.remote.shorten_log_messages\", \"true\");`", "reference": "This is in test code: understanding what we're doing is important in this context." }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is this for a specific use case? If so, please provide more context. If not, I'm not sure what you're trying to do here. Is this for a specific use case? If so, please provide more context. If not, I'm not sure what you're trying to do here. Is this for a specific use case? If so, please provide more context. If not, I'm not sure what you're trying to do here. Is this for a specific use case? If so, please provide more context. If not, I'm not sure what you're trying to do here. Is this for a specific use case? If so, please provide more context. If not, I'm not sure what you're trying to do here. Is this for a specific use case? If so, please provide more context. If not, I'm not sure what you're trying to do here. Is this for a specific use case? If so, please provide more context. If not, I'm not sure what you're trying to do here. Is this for a specific use case? If so, please provide more context. If not, I'm not sure what you", + "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason why you want to log a warning if the condition is not met?", "reference": "prob should still have an example that has multiple option names even if you have to make it up. Or maybe we don't need this method?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `render_to_string` helper for this.", + "prediction": "I don't think we need to use `render_to_string` here. I think we can just use `send_data` here.", "reference": "I believe respond_to whitelists the formats passed to the block so if we don't want to display html, we can just remove the line format.html..." }, { @@ -2163,11 +2163,11 @@ "reference": "stylistic nitpick: I _feel_ like we've largely shown errors like this as \"error: \" vs. \"error=\". IMO colon/space reads better." }, { - "prediction": "I think this should be `#include ` instead of `#include `.", + "prediction": "I think this should be `#include ` instead of `#include `.", "reference": "We could put this implementation in `RTPSWriter::create_change_pool` and avoid an extra function." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I don't think we need to use `uuid` here. We can just use `time.Time` instead.", "reference": "should this file ends with _test.go?" }, { @@ -2175,15 +2175,15 @@ "reference": "It's because of this change. `ss` was unused and it made sense in the program. However I haven't read the IPv6 RFC so I'm unsure of what it does" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.", + "prediction": "I don't think we need to flatten the index here.", "reference": "\"Flatten\" is a verb, so I'd probably go with `flattenedIndex` as a variable name here." }, { - "prediction": "I think this should be `console.log` instead of `console.error`?", + "prediction": "I don't think we need to do this. We can just use `console.log` and `console.error` instead.", "reference": "If it can only be called once, perhaps a more appropriate name is something like `setMaskables`? `addX` sounds like you can add many `X`es by calling it many times" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `s3.MakePublicS3SessionForDownload()` function.", + "prediction": "I think we should use `s3, err := s3.MakePublicS3SessionForDownload()` instead of `s3, err := s3.MakeS3SessionForDownload()`", "reference": "Nodecfg should be downloading from a private bucket -- these shouldn't be for public consumption. In general these should be generic and expect environment to provide appropriate credentials and bucket." }, { @@ -2191,27 +2191,27 @@ "reference": "Could you please end the file with an empty line?" }, { - "prediction": "I think this should be `if (result.isPresent()) {` instead of `if (result.isPresent()) { return result.get(); }`", + "prediction": "I think this should be `if (result.isPresent())` instead of `if (result.isPresent()) { ... }`", "reference": "This is an incorrect change. The dialect spoken is an important part of the handshake and should be communicated to users." }, { - "prediction": "I think we can remove the `isCanceledMx sync.Mutex` here.", + "prediction": "I'm not sure if this is the right place to put it, but I think it would make sense to put it in the `Workflow` struct.", "reference": "Can this be non-exported to avoid direct use? It would be a breaking change but using previous package version would work." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate function for `gcerrors.Unknown` and `gcerrors.NotFound`.", + "prediction": "I think we should use `gcerrors.Unknown` instead of `gcerrors.NotFound` here.", "reference": "Nit: this is just `return gcerrors.Code(err)`, isn't it?" }, { - "prediction": "I'm not sure what you mean by \"currently we will wait for at most 5 blocks to be mined before giving up\"", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.", "reference": "I don't know where this came from, but it's not a good idea. This is actually timing out after 5 rounds, not 5 blocks. 5 consecutive null blocks won't be that uncommon. Also when testing with a short block time, this is a very short duration that can contribute to flaky tests." }, { - "prediction": "I think this should be `with open(statePath, \"r\") as f:` instead of `with open(statePath, \"r\") as f:`", + "prediction": "I don't think this is necessary. We should be able to use `cPickle.load` directly.", "reference": "In Python 3 when pickling or unpickling objects, the file needs to be opened as binary so that no text encoding/decoding takes place. So for any open calls around pickle loads or dumps, the mode for reading must be rb and the mode for writing must be wb." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `params.qstring.event` and `params.qstring.method` in the `validateRead` function.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `params.qstring.method == 'GET'` to make sure we don't try to fetch the event groups when the method is `GET`.", "reference": "did you remove **params.qstring.method** intentionally? if so why?" }, { @@ -2219,11 +2219,11 @@ "reference": "What is the current default? Is that inconsistent across uses and that's why this is null?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add a check for the existence of the `App` field in the `stack.AppStackConfi` struct. If it doesn't exist, we should return an error. This way, we can ensure that the `App` field is always present, even if it's not set in the `stack.AppStackConfi` struct.", + "prediction": "I'm not sure what you mean by \"parse previous deployed stackset\". Could you please provide more context?", "reference": "Why did we make this change? How come it wasn't an issue before" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a test for this in `vkCmdBindDescriptorSets` as well.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate test for this. It's a bit more complicated than the other tests, but I think it's a good idea to have a separate test for this.", "reference": "Can you tighten scope by moving to of these variables? i.e. Move to ~4372?" }, { @@ -2235,7 +2235,7 @@ "reference": "How about the following faster alternative that doesn't need `strlen()` at all: if (*tmp_optarg == '\\0' || *endptr != '\\0') { fprintf(...) ... This would treat the bus argument as invalid if it's either empty (`tmp_optarg` points to '\\0') or invalid (`endptr` points to something other that a '\\0'). Actually, the existing code would accept an empty argument and set the bus to `0`, so if (*endptr != '\\0') { fprintf(...) ... would be enough. The check for an empty argument doesn't hurt, though." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to include the `from` and `cc` fields in the `body` field. This way, the `from` and `cc` fields will be included in the email, even if the `from` and `cc` fields are not included in the `body` field. This way, the `from` and `cc` fields will be included in the email, even if the `from` and `cc` fields are not included in the `body` field. This way, the `from` and `cc` fields will be included in the email, even if the `from` and `cc` fields are not included in the `body` field. This way, the `from` and `cc` fields will be included in the email, even if the `from` and `cc` fields are not included in the `body` field. This way, the `from` and `cc` fields will be included in the email, even if the `from` and `cc` fields are not included in the `body` field. This way, the `from` and `cc` fields will be included in", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `cc` instead of `to` in this case.", "reference": "I could be missing something here, but the `from` and `cc` are the same. On the test email sent to gatewaycommunicator, these values are different." }, { @@ -2243,7 +2243,7 @@ "reference": "I'm honestly scared because act is now a hard requirement for useEffect which it wasn't before... This could break some tests :(" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Could you please provide some more context?", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to update the difficulty of a block, but you're also trying to update the winner of that block. Is this what you're trying to do?", "reference": "Could use election from `info_a.election`, or is this deliberate?" }, { @@ -2251,11 +2251,11 @@ "reference": "looks like this should be `return array(LegacyFormHelper::getType('form'));`" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to call `portprober.findFreePort('localhost')` here.", + "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to start a server that will listen on a specific port, and then wait for it to start.", "reference": "Maybe it would simpler to ignore opt_port if type !== 'number'?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to `Blockly.ScratchBlocks.VerticalExtensions` instead of `Blockly.ScratchBlocks.VerticalExtensions.SCRATCH_EXTENSION`.", + "prediction": "Shouldn't this be `for (var i = 0, name; name = categoryNames[i]; i++)`?", "reference": "Where was `name` being declared before?" }, { @@ -2263,39 +2263,39 @@ "reference": "nit: use `corev1.ConditionUnknown`" }, { - "prediction": "I think this should be `if (typeof v === 'string' && v.length === 12)` instead of `if (typeof v === 'string' && (v.length === 12 || v.length === 24))`", + "prediction": "I think this should be `if (typeof v === 'string' && (v.length === 12 || v.length === 24))`", "reference": "You also need to add a similar check on line 992, there's another place where we check `length === 24`" }, { - "prediction": "I think this should be `validatorProvider.getVoteProviderAfterBlock(parentHeader).get().getVoteAfterBlock(parentHeader, localAddress);`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check here to make sure that the vote provider is not null.", "reference": "nit: can extract the voteProvider as a local variable" }, { - "prediction": "I'm not sure what you mean by \"expected error, functions are not equal\"", + "prediction": "I'm not sure why this test is failing, but I'm not sure how to fix it. I think it's because of the `assertFuncEquals` method, but I'm not sure how to fix it.", "reference": "[0] Not suggesting you change it here, but....kindof weird that there's just not an `assertFuncNotEquals`" }, { - "prediction": "I think we can remove the `if err != nil` here.", + "prediction": "I think we can remove the `if err != nil` here, since it's already checked in the `IsRegistered` function.", "reference": "why are we passing 'registryAddress' here? We probably should construct it together with bc. Registry is not something that change?" }, { - "prediction": "I'm not sure what you're trying to achieve with this function, but I think it's a good idea to add a docstring to it.", + "prediction": "I'm not sure what you're trying to achieve with this function, but I think it's a good idea to add a docstring to the function.", "reference": "`.` at the end of the sentence" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to do this in a single call to `streamer.Ping` instead of two separate calls to `streamer.Ping` and `streamer.PingMulti`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `checkPeers` as well.", "reference": "wouldn't it be useful to split this into an error metric for the timing?" }, { - "prediction": "I'm not sure what you mean by \"fictional character name\". It's not clear what you're trying to test here.", + "prediction": "I'm not sure what you mean by \"fictional character name\". I think you meant to say that `@tester.fictional_character_name.match(/\\w+/)` should return an empty string.", "reference": "Not sure if this is good enough. Each generator will have it's own unit test anyway. Ideally, I think I'd want to test that each generator in the yml is actually a valid generator..." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to mock the `MintNewBlockWithActionIterator` function, but you're not returning anything from it.", + "prediction": "I'm not sure what you're trying to do here. I don't think you need to mock `blockchain` in this case.", "reference": "line is 138 characters" }, { - "prediction": "I'm not sure what you mean by \"avoid global registry\". I think we should be able to have a single registry for all databases.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `Close` method to the `sql.DB` struct, so that we don't have to call `Close` every time we want to close the connection.", "reference": "Nit: I would leave `Wire` out of the description; if you use this without wire you can still use it." }, { @@ -2303,43 +2303,43 @@ "reference": "Nit: each field can be on a separate line to make it visually easier to read." }, { - "prediction": "I think we can remove the `if inp_f in ['compiler_includes.json', 'compiler_target.json', 'compiler_info.json', 'metadata.json']` check.", + "prediction": "I think we should remove the `elif inp_f in ['compiler_includes.json', 'compiler_target.json', 'compiler_info.json', 'metadata.json']` block.", "reference": "Do we still have these files? Shouldn't we remove these?" }, { - "prediction": "I think this should be `ErrorRenewBeforeInvalid` instead of `ErrorRenewBefore`.", + "prediction": "I don't think this is a good idea. It's not clear to me what the purpose of this interface is.", "reference": "A lot of things to do with constants seemed to move since the original commit, so I stuck this here, Is there a better place for it?" }, { - "prediction": "I don't think we need to change the `ActionChanSize` to 10000, since it's already set to 1000.", + "prediction": "I don't think we need to change the size of `BlockSyncChanSize` to 10000. We can just use 1000.", "reference": "is 10 too small compared to 1000? consider sync chan is unicast only (vs block chan is broadcast + unicast), i would say use 200~400 for BlockSyncChanSize my concern is that this would potentially slowdown sync speed of full-node" }, { - "prediction": "I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure", + "prediction": "I think this should be `reject { |plan| get_plan_info(plan.first)['private'] }` instead of `plans.reject { |plan| get_plan_info(plan.first)['private'] }`", "reference": "A full parse of the plan here on listing the plans will be expensive from both a computation and IO perspective." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to have this in a separate file, so that it can be used in other places as well.", + "prediction": "I don't think this is needed anymore.", "reference": "These constants use the `_PIN` suffix, while the other constants don't use it. I'm not sure what is best, but I would prefer to keep this consistent. Do you have an opinion on which it should be (with or without suffix)?" }, { - "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to make it a `CommandLineOption` instead of a `CommandLineProperty`. This way, you can use `--dns-discovery-url` in the command line and it will be available as a `CommandLineProperty` instead of a `CommandLineOption`. This way, you can use `--dns-discovery-url` in the command line and it will be available as a `CommandLineProperty` instead of a `CommandLineOption`. This way, you can use `--dns-discovery-url` in the command line and it will be available as a `CommandLineProperty` instead of a `CommandLineOption`. This way, you can use `--dns-discovery-url` in the command line and it will be available as a `CommandLineProperty` instead of a `CommandLineOption`. This way, you can use `--dns-discovery-url` in the command line and it will be available as a `CommandLineProperty` instead of a `CommandLineOption`. This way, you can use `--dns-discovery-url` in the command line and it will be available as a `CommandLineProperty` instead of a `CommandLineOption`. This way, you can use `--dns", + "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to make it a `CommandLineOption` and add a `@Required` annotation to it.", "reference": "Hmm... this feels like discovery should come first. perhaps `--discovery-dns-url`? @NicolasMassart any opinions on this or ideas on who it should be run by?" }, { - "prediction": "I'm not sure what you mean by \"ignore_autogenerated\"", + "prediction": "I'm not sure if this is a good idea, but I don't think it's a good idea to remove the `//go:build !ignore_autogenerated` line. I think it's a good idea to keep the `//go:build !ignore_autogenerated` line in place, but remove the `//go:build !ignore_autogenerated` line.", "reference": "why is this needed?" }, { - "prediction": "I think this should be `type_obj = type(self)` instead of `type_obj = type(self).__class__`", + "prediction": "I don't think this is necessary. The `__init__` method is called when an instance of this class is created, so we don't need to call `super().__init__()` in this case.", "reference": "I wonder if it'd be possible to autogenerate a key from the name within this function if one is not provided explicitly, rather than having all the callsites pass both the name and key (and usually as the same value)? Might give us a good place to implement a `name->key` function that isn't 1:1." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I think this should be `TYPE_I32` instead of `TYPE_I16`?", "reference": "@adriancole I do not see a change in the thrift file. Are there unit tests verifying that this manual serialization is compatible with the native Thrift serialization done by classes generated from `.thrift` IDL file?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.", + "prediction": "I don't think this is a good idea.", "reference": "spelling (variable name, all three changes)" }, { @@ -2347,7 +2347,7 @@ "reference": "I believe you meant \"specify `desiredUID` and `desiredRole`\"?" }, { - "prediction": "`v1` should be `v1beta1`", + "prediction": "`v1beta1` should be `v1` instead of `v1beta1`", "reference": "Please follow the import style, move it to its similar group" }, { @@ -2355,23 +2355,23 @@ "reference": "Do we really need these? This is expanding on an API that we're about to do work on with the error stuff @kriskowal" }, { - "prediction": "I'm not sure what you're trying to do here. You're creating a new instance of `PasswordData` and then calling `PasswordData.newInstance(password, String.valueOf(passwordModificationTime.getTime()), null)`. This will create a new instance of `PasswordData` with the same `password` and `passwordModificationTime` values, but without the `null` value. Is this what you're trying to do?", + "prediction": "I don't think we need to do this anymore.", "reference": "passwordModificationTime is no longer used - did the change drop a time check that should be restored? Or should the param get dropped from the methods?" }, { - "prediction": "I don't think this is a good idea. It would be better to check if the process name is the same and if the command line is the same and if the process ID is the same and if the command line is the same and if the process name is the same and if the command line is the same and if the process name is the same and if the command line is the same and if the process name is the same and if the command line is the same and if the process name is the same and if the command line is the same and if the process name is the same and if the command line is the same and if the process name is the same and if the command line is the same and if the process name is the same and if the command line is the same and if the process name is the same and if the command line is the same and if the process name is the same and if the command line is the same and if the process name is the same and if the command line is the same and if the process name is the same and if the command line is the same and if the process name is the same and if the command line is the same and if the process name is the same and if the command line is the same and", + "prediction": "I don't think this is necessary.", "reference": "Would it break here without trim? If so, can we do trim in Startup.cs so we don't need to add this code to every parser?" }, { - "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to run iptables on a running container. It's not a good idea to run iptables on a running container, as it will cause the container to crash. I'm not sure what you're trying to achieve with this test, but I'm not sure what you're trying to achieve with this test, but I'm not sure what you're trying to achieve with this test, but I'm not sure what you're trying to achieve with this test, but I'm not sure what you're trying to achieve with this test, but I'm not sure what you're trying to achieve with this test, but I'm not sure what you're trying to achieve with this test, but I'm not sure what you're trying to achieve with this test, but I'm not sure what you're trying to achieve with this test, but I'm not sure what you're trying to achieve with this test, but I'm not sure what you're trying to achieve with this test, but I'm not sure what you're trying to achieve with this test, but I'm not sure what you're trying to achieve with this test, but I'm not", + "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to run iptables on a running container. I think it would be better to run iptables on a container that is not running.", "reference": "Since we're using Logrus, probably best to use `Infof` to avoid confusion (Logrus' Printf behaves differently to the built in one)" }, { - "prediction": "I think we can remove the `shadow` attribute and just use `rect` for the width and height.", + "prediction": "I think we can remove the `shadow` attribute and just use `svgText` instead.", "reference": "Hm, this looks like a change that should go upstream as well." }, { - "prediction": "I don't think this is needed.", + "prediction": "I don't think we need to use `core.bc.Context` here. We can use `core.ctx` instead.", "reference": "let's keep ActionByActionHash and delete getActionByActionHash" }, { @@ -2379,15 +2379,15 @@ "reference": "please use return type" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to start a new instance of the `EdgeDriverService` with a log file. I'm not sure what you're trying to achieve with this, but it looks like you're trying to start a new instance of the `EdgeDriverService` with a log file. I'm not sure what you're trying to achieve with this, but it looks like you're trying to start a new instance of the `EdgeDriverService` with a log file. I'm not sure what you're trying to achieve with this, but it looks like you're trying to start a new instance of the `EdgeDriverService` with a log file. I'm not sure what you're trying to achieve with this, but it looks like you're trying to start a new instance of the `EdgeDriverService` with a log file. I'm not sure what you're trying to achieve with this, but it looks like you're trying to start a new instance of the `EdgeDriverService` with a log file. I'm not sure what you're trying to achieve with this, but it looks like you're trying to start a new instance of the `EdgeDriverService` with a", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `Runtime.getRuntime().addShutdownHook(new Thread(() -> service.stop()));` line.", "reference": "This is deliberately at this level." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to move it to the `__init__` method of the `UploadWorkerThread` class so that it can be called from the `__init__` method of the `TransferThread` class as well.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `__init__` method of the `UploadWorkerThread` class, so that it can be called from the `__init__` method of the `TransferThread` class as well.", "reference": "I'm going to go ahead and undo this change, I don't think it was intentional." }, { - "prediction": "I'm not sure what you're trying to achieve here, but I think it's a bit confusing. It's not clear what you're trying to achieve here, but I think it's a bit confusing. It's not clear what you're trying to achieve here, but I think it's a bit confusing. It's not clear what you're trying to achieve here, but I think it's a bit confusing. It's not clear what you're trying to achieve here, but I think it's a bit confusing. It's not clear what you're trying to achieve here, but I think it's a bit confusing. It's not clear what you're trying to achieve here, but I think it's a bit confusing. It's not clear what you're trying to achieve here, but I think it's a bit confusing. It's not clear what you're trying to achieve here, but I think it's a bit confusing. It's not clear what you're trying to achieve here, but I think it's a bit confusing. It's not clear what you're trying to achieve here, but I think it's a bit confusing. It's not clear what you're trying to achieve here, but I think it's a bit confusing. It's not clear", + "prediction": "I'm not sure I understand what you mean by \"on non-default AD\". Could you please provide more context?", "reference": "> specialised This isn't a typo in my neck of the woods" }, { @@ -2395,15 +2395,15 @@ "reference": "will change to `storage_target`" }, { - "prediction": "I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to mock the `SecurityCenterClient` class, but I don't think that's what you're trying to do here. I think you're trying to mock the `SecurityCenter` class, but I don't think that's what you're trying to do here. I think you're trying to mock the `SecurityCenter` class, but I don't think that's what you're trying to do here. I think you're trying to mock the `SecurityCenter` class, but I don't think that's what you're trying to do here. I think you're trying to mock the `SecurityCenter` class, but I don't think that's what you're trying to do here. I think you're trying to mock the `SecurityCenter` class, but I don't think that's what you're trying to do here. I think you're trying to mock the `SecurityCenter` class, but I don't think that's what you're trying to do here. I think you're trying to mock the `SecurityCenter` class, but I don't think that's what you're trying to do here. I think you're trying to mock the `SecurityCenter", "reference": "This would be better as `cls.securitycenter_client`, to match what is being instantiated." }, { - "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea to use `shlobj.SHGetFolderPath` to get the path to the system32 directory. It's not a good idea to use `shlobj.SHGetFolderPath` to get the path to the system32 directory. It's not a good idea to use `shlobj.SHGetFolderPath` to get the path to the system32 directory. It's not a good idea to use `shlobj.SHGetFolderPath` to get the path to the system32 directory. It's not a good idea to use `shlobj.SHGetFolderPath` to get the path to the system32 directory. It's not a good idea to use `shlobj.SHGetFolderPath` to get the path to the system32 directory. It's not a good idea to use `shlobj.SHGetFolderPath` to get the path to the system32 directory. It's not a good idea to use `shlobj.SHGetFolderPath` to get the path to the system32 directory. It's not a good idea to use `shlobj.SHGetFolderPath` to get the path to the system", + "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea to have a dictionary of processID:appModule paires. I think it's better to have a dictionary of appModule:processID paires.", "reference": "Could we have this initialization as part of the initialize method?" }, { - "prediction": "I don't think this is necessary. The `editController` is already defined in the `AbstractEditController` class.", + "prediction": "I don't think we need to use `inject.service()` here. We can just use `this` here.", "reference": "This line should be removed as editController is not used from this context anymore." }, { @@ -2411,7 +2411,7 @@ "reference": "This is correct in concept but the method signature doesn't really communicate the same thing. In other words, if the function produces an output table where is it? Its not on the function signature. Can you explain where the output table is created?" }, { - "prediction": "`self.pretrained = pretrained` should be `self.pretrained = pretrained`", + "prediction": "`self.pretrained = None` should be `self.pretrained = None`", "reference": "For insurance, it's best not to take it directly" }, { @@ -2419,19 +2419,19 @@ "reference": "change 'value' to keysToSend, here and in other references in this commit. 'value' implies the user is getting the value of the element, rather than just the keys we're sending to it." }, { - "prediction": "I think it's better to use `dockerapi.DockerContainerMetadata` instead of `dockerapi.DockerContainer`.", + "prediction": "I think we can remove the `task.SetLocalIPAddress(taskIP)` line.", "reference": "is the plan to fully migrate to boltdb and then remove the state save here?" }, { - "prediction": "I think it's better to use `themeCache_[theme] = output;` instead of `themeCache_[theme] = output.colorUrl = '#7B81FF';`", + "prediction": "I don't think we need to use `rgb(220,220,220)` for the strong text color. We can use `rgb(255,255,255)` instead.", "reference": "This should be `output.colorBright`. Unless I'm missing some reason for adding a new theme variable." }, { - "prediction": "I'm not sure what you mean by \"possible\". Is there a way to update the version from the VCS?", + "prediction": "I'm not sure why we need to update the version from the VCS, but it's not a big deal. I'll leave it as is for now.", "reference": "nit: I wonder if these should be moved down to where version is defined, just to keep them all in the same place." }, { - "prediction": "I don't think we need to add the `import java.util.*;` at the end of the file.", + "prediction": "I don't think we need to add the `import java.util.*;` line here.", "reference": "Is this supported by every implementation of Java (and Android)? Should it be conditional upon `gen_nullable`?" }, { @@ -2439,11 +2439,11 @@ "reference": "@briri Thanks! I just caught this too updating my feature branch" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `os.Getenv(\"RCLONE_CONFIG_PASS\")` instead of `os.Getenv(\"RCLONE_CONFIG_PASS\") != \"\"`.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `os.Getenv` function to get the password from the environment variable.", "reference": "I think you should move this block (and the `envpw := os.Getenv(\"RCLONE_CONFIG_PASS\")`) right to the start of the function, then we can remove the duplicate code below" }, { - "prediction": "I think this test should be moved to a separate test class.", + "prediction": "I think this test should be moved to `RemoteNodeTest` instead of `NodeTest`.", "reference": "Is this only to set the node to draining? I think we can do that inside `Before` or something?" }, { @@ -2451,23 +2451,23 @@ "reference": "This should have been moved up above this inner `try` because the log message in the `catch` block does not apply to this." }, { - "prediction": "I'm not sure what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `Bolt::TargetSpec` module.", "reference": "Do we expect people to use PlanResult directly?" }, { - "prediction": "I'm not sure what you're trying to do here. It looks like you want to wait for the condition to be true, but if it's not true, you want to retry the condition check. Is that right?", + "prediction": "I don't think we need to use wait.Err() here. We can just use wait.Err() here.", "reference": "Maybe we should call this something like `errToReturn`?" }, { - "prediction": "I'm not sure what you mean by \"extend foundation bonus from fairbank to fairbank + 1 year\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `GrantEpochReward` function.", "reference": "should calculate numEpochIn1Year = xxx and <= fairBankEpochNum+numEpochIn1Year a.foundationBonusLastEpoch just happens to be equal to 1 year now, but should not count on that" }, { - "prediction": "I'm not sure what you mean by \"spec change\" in this case. It's not a spec change, it's just a change in how browsers handle the `img` element.", + "prediction": "I'm not sure what you mean by \"spec change\" in this case. It's not a spec change, it's just a change in how the spec is written.", "reference": "I wasn't sure if the content type needed to be removed from both the `default` and `usemap` objects - I'm not sure how usemap is used." }, { - "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea to add it here.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add `XStrField` and `XShortField` to `PacketListField` as well.", "reference": "Duplication of line 28 Please refer your tox -e flake8 It seems that XStrField, XShortField, FieldLenField are not used" }, { @@ -2475,7 +2475,7 @@ "reference": "I don't really understand the `self._file_model.index(path)` as parent here - you use `self._root_index` for `rowCount` above, so wouldn't the parent here need to be `self._root_index` as well?" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a good idea to make it more clear what it does.", + "prediction": "I don't think we need to change this.", "reference": "Do we want validation somewhere that max >= min? Or simply treat the max < min case as ignoring max?" }, { @@ -2483,35 +2483,35 @@ "reference": ":+1: that's a easier example :)" }, { - "prediction": "I'm not sure what you're trying to achieve with this method, but I think it's a bit confusing. It seems like you're trying to get a list of product ids that have a specific attribute bound to them, but I'm not sure what you're trying to achieve with this method. Could you please clarify what you're trying to achieve with this method?", + "prediction": "I don't think this is needed anymore.", "reference": "If an external module decorates this interface, such a change will cause it to generate an error" }, { - "prediction": "I'm not sure what you mean by `zlistx_detach_cur()`. I think you meant `zlist_detach_cur()`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `jobtap` struct.", "reference": "Oh ha hah, FNM_PERIOD worked out nicely there. Points for co-opting a file system convention." }, { - "prediction": "I don't think we need to use `zap` here. We can just use `zap.Logger` instead.", + "prediction": "I don't think we need to use `big` here. We can just use `int64` and `uint64` instead.", "reference": "wrong grouping. As you can tell from the other files, we put system packages in the first group, the 3rd party packages in the second group, and our own packages in the third group." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for validating the job name.", + "prediction": "I think this should be `if _, err := o.configStore.GetJob(o.appName, o.name); err != nil {`", "reference": "Is `o.name` always set here?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Can you give an example of what you're trying to do?", + "prediction": "I'm not sure I understand what you're trying to do here. Can you please provide some more context?", "reference": "Can this line be removed, as `SteadyStateDependencies` isn't updated anywhere? Also do we need to check the `TransitionDependencySet` here?" }, { - "prediction": "I'm not sure what you're trying to say here. I think you're trying to say that `has_annual_plan?` and `has_active_subscription?` are mutually exclusive. Is that correct?", + "prediction": "I'm not sure what you're trying to do here. Is it possible that you're trying to call `annualized_payment` on a `Subscription` object that doesn't have an active subscription? If that's the case, then you should be able to call `annualized_payment` on a `Subscription` object that does have an active subscription, but you should be able to call `annualized_payment` on a `Subscription` object that doesn't have an active subscription, but you should be able to call `annualized_payment` on a `Subscription` object that does have an active subscription, but you should be able to call `annualized_payment` on a `Subscription` object that doesn't have an active subscription, but you should be able to call `annualized_payment` on a `Subscription` object that does have an active subscription, but you should be able to call `annualized_payment` on a `Subscription` object that doesn't have an active subscription, but you should be able to call `annualized_payment` on a `Subscription` object that does have an active subscription, but you should be able to call `annualized_payment` on a `Subscription` object that doesn't have an active subscription, but you should be able to", "reference": "`plan.present?` and `has_active_subscription?` are equivalent. We can drop this change, while leaving the one on `app/controllers/application_controller.rb`." }, { - "prediction": "I'm not sure what you mean by \"too-many-locals\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a `scope` parameter to the `Command` class, so that it can be used in the `__init__` method of the `Command` class.", "reference": "No need for this, as pylint already only turns things off for this function and it's needed for the entire function." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think we need to change anything here.", + "prediction": "I'm not sure what you mean by `AllowList` and `DenyList` here. Could you please clarify?", "reference": "L171 needs to be modified too?" }, { @@ -2523,15 +2523,15 @@ "reference": "configs/pvt/retinanet_pvt_t_fpn_1x_coco.py --> configs/pvt/retinanet_pvt-t_fpn_1x_coco.py" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to `TaskResponse` as well.", + "prediction": "I don't think we need to add `DesiredStatus` to the `TaskResponse` struct. We can just use the `DesiredStatus` field in the `MetadataResponse` struct.", "reference": "Nit, this could be json:\",omitempty\"" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.", + "prediction": "I think it's better to have a separate `BuildRequired` function for this. It's not clear to me what the `BuildRequired` function is supposed to do. It's not clear to me what the `BuildArgs` function is supposed to do. It's not clear to me what the `BuildRequired` function is supposed to do. It's not clear to me what the `BuildArgs` function is supposed to do. It's not clear to me what the `BuildRequired` function is supposed to do. It's not clear to me what the `BuildArgs` function is supposed to do. It's not clear to me what the `BuildRequired` function is supposed to do. It's not clear to me what the `BuildArgs` function is supposed to do. It's not clear to me what the `BuildRequired` function is supposed to do. It's not clear to me what the `BuildArgs` function is supposed to do. It's not clear to me what the `BuildRequired` function is supposed to do. It's not clear to me what the `BuildArgs` function is supposed to do. It's not clear to me what the `BuildRequired` function is supposed to do. It's not clear to", "reference": "It's kinda funny to read `s.Image.Image` I wonder why it resulted to this way. What would it take to refactor to just `s.Image`?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to run a test that uses the `aws-sdk` package, but it doesn't seem to be doing so. I'm not sure what you're trying to do here. I think you're trying to run a test that uses the `aws-sdk` package, but it doesn't seem to be doing so. I'm not sure what you're trying to do here. I think you're trying to run a test that uses the `aws-sdk` package, but it doesn't seem to be doing so. I'm not sure what you're trying to do here. I think you're trying to run a test that uses the `aws-sdk` package, but it doesn't seem to be doing so. I'm not sure what you're trying to do here. I think you're trying to run a test that uses the `aws-sdk` package, but it doesn't seem to be doing so. I'm not sure what you're trying to do here. I think you're trying to run a test that uses the `aws-sdk` package, but it doesn't seem to be doing so. I'm not sure what you're trying to do here. I think you're", + "prediction": "I'm not sure if this is a good idea, but I think we should remove the `+build integration` and `+build integration,deploy` from the commit message.", "reference": "nit: I like the idea! can we instead change the tag to `integration-remote` to be more specific? I feel like it's possible for us to use the `deploy` build tag for possibly another scenario" }, { @@ -2539,7 +2539,7 @@ "reference": "Copy and paste error here. Edit: Also missing commas here and in other Perl croaks between some parameters and not others." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. The `SelectTransactions` method should return an `IEnumerable`, not an `IEnumerable`.", + "prediction": "I don't think this is needed anymore.", "reference": "stateRoot or maybe ParentHeader would make more sense from API point of view?" }, { @@ -2547,63 +2547,63 @@ "reference": "Are you sure that this is no longer needed?" }, { - "prediction": "I think we should remove `LOG` from `BaseTableScan` as it is not used anywhere in the code.", + "prediction": "I think it's better to use a `List` for `SCAN_WITH_STATS_COLUMNS` instead of a `List` for `SCAN_COLUMNS`.", "reference": "Would it help to use SCAN_COLUMNS as base to build SCAN_WITH_STATS_COLUMNS e.g like so `SCAN_WITHSTATS_COLUMNS = ImmutableList.builder().addAll(SCAN_COLUMNS).add(\"value_counts\",....).build()` ?" }, { - "prediction": "I think this should be `ReportPipedMetaResponse` instead of `ReportPipedMetaRequest`.", + "prediction": "I think this should be `ReportPipedMetaResponse` instead of `ReportStatResponse`.", "reference": "`ctx` is unused in ReportStat" }, { - "prediction": "I think we can remove the `#include ` and `#include `.", + "prediction": "I don't think we need to use `std::list` here. We can just use `std::vector` and `std::map` instead.", "reference": "We don't want to add boost as a dependency when building the Thrift compiler. Sorry." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to change the default value of `duration` to 10000.", + "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to put it in the spell block, so that it can be used in other spells as well.", "reference": "It's not printing the range. Also I think it's useful to print a warning above stating that the minimum change is -1000." }, { - "prediction": "I think this should be `c.c.Get().Resource(clusterPath + SchedPath + \"/\" + name)` instead of `c.c.Get().Resource(clusterPath + SchedPath + \"/\" + name)`", + "prediction": "I think this should be `c.c.Get().Resource(clusterPath + SchedPath + \"/\" + name)`", "reference": "if name is empty will this become enumerate ? (and cause the unmarshal to fail ?)" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `link_to edit_subscription_path` instead of `link_to edit_subscription_path(options, &block)`.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `link_to` helper for this.", "reference": "How about including a flash message that explains the exercises are only available to subscribers of X plan?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason you're using `e.key() == Qt.Key_Backspace` instead of `e.key() == Qt.Key_Return`?", + "prediction": "I'm not sure I understand what you're trying to do here.", "reference": "You should also call `e.accept()` and `return` so the key press isn't processed further (as we're leaving insert mode anyways)." }, { - "prediction": "I think this should be `if ENV[\"EMAIL_RECIPIENTS\"]` instead of `if ENV[\"EMAIL_RECIPIENTS\"] && ENV[\"EMAIL_RECIPIENTS\"]`", + "prediction": "I think we should use `ENV.fetch(\"EMAIL_RECIPIENTS\")` instead of `ENV[\"EMAIL_RECIPIENTS\"]`", "reference": "Freeze mutable objects assigned to constants." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `await expect( page ).toClick( '#googlesitekit-opt-in' );` and `await expect( page ).toClick( '#googlesitekit-opt-out' );` instead of `await expect( page ).toClick( '#googlesitekit-opt-in' ); await expect( page ).toClick( '#googlesitekit-opt-out' );`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the", "reference": "Hmm, this feels hacky. Maybe good enough if it makes the test more stable, but why is timing even an aspect here, since below it should wait for these two things anyway?" }, { - "prediction": "I think we can remove the `xForwardedFor` check.", + "prediction": "I think this should be `x-forwarded-for` instead of `X-Forwarded-For`.", "reference": "Do we want this on by default, or an opt-in (e.g. via some config while add the instrumentation)? I guess a more general question is - what's the bar for the default vs opt-in tags." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to register the handler in the `main` function so that it can be called from anywhere in the code.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to register the handler in the `main` function, so that we don't have to do it in the `main` function every time we want to start the service.", "reference": "`status` is just one of the features, named as status is not suitable." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a `View.OnClickListener` to the `convertView` so that the user can click on it to toggle the visibility of the `feedsFilteredMsg` view.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea.", "reference": "There is an option to hide the subscriptions list from the sidebar. If it is hidden, the filter text should not be displayed." }, { - "prediction": "I think this should be `useCircuitBreakers` instead of `useCircuitBreakers`", + "prediction": "I think this should be `memoryCircuitBreakerThreshold` instead of `memoryCircuitBreakerThreshold`", "reference": "I'd like for all of this to be dynamically configurable at some point, but it doesn't have to be in this PR. Can add it to the future SIP or create a separate JIRA for it, as you think would be appropriate." }, { - "prediction": "I'm not sure what you mean by \"using ErrorCode = boost::system::error_code\". I think you meant to say `using ErrorCode = boost::system::error_code;`", + "prediction": "I'm not sure what you mean by \"using ErrorCode = boost::system::error_code;\". I think you meant `using ErrorCode = boost::system::error_code;`", "reference": "move the constructor to down the `namespace`" }, { - "prediction": "I think we should remove the `json:\"federatedClusterRef,omitempty\"` from the `ClusterDeploymentStatus` struct.", + "prediction": "I think we should remove the `json:\"federatedClusterRef,omitempty\"` here.", "reference": "Nit: ending with a '.' looks consistent with the fields around it." }, { @@ -2611,7 +2611,7 @@ "reference": "Audit log will not have a warning about they are using a deprecated path, is it something we must care about?" }, { - "prediction": "I'm not sure what you're trying to say here. The visibility of the implementation and the visibility of the contract should be the same.", + "prediction": "I'm not sure what you mean by \"visibility of member\". Is it the visibility of the member in the implementation, or the visibility of the member in the contract? If it's the visibility of the member in the implementation, then the visibility of the member in the contract should be the same. If it's the visibility of the member in the contract, then the visibility of the member in the implementation should be the same. I'm not sure what you mean by \"visibility of member\". Is it the visibility of the member in the implementation, or the visibility of the member in the contract? If it's the visibility of the member in the implementation, then the visibility of the member in the contract should be the same. If it's the visibility of the member in the contract, then the visibility of the member in the implementation should be the same. I'm not sure what you mean by \"visibility of member\". Is it the visibility of the member in the implementation, or the visibility of the member in the contract? If it's the visibility of the member in the implementation, then the visibility of the member in the contract should be the same. If it's the visibility of the member in the contract, then the visibility of the member in the implementation should be the", "reference": "I think you also want to update the condition to add ` || impl.Visibility == TypeMemberVisibility.FamilyOrAssembly`." }, { @@ -2619,7 +2619,7 @@ "reference": "`DepositToRewardingFundBaseGas` is a global variable (from `gochecknoglobals`)" }, { - "prediction": "I think it would be better to have a separate `Categories` field in the `Group` struct.", + "prediction": "I think it would be better to have a separate `Categories` field in the `Group` struct, so that we don't have to repeat the `Categories` field in the `Group` struct.", "reference": "What do you think of \"operations\"?? Also what do these emojis look like on Linux??" }, { @@ -2627,27 +2627,27 @@ "reference": "I like the word \"give\" here. Feels like I'm giving a gift to my team." }, { - "prediction": "I'm not sure why we're using `GridSearchCV` instead of `RandomizedSearchCV` here. It seems like `RandomizedSearchCV` would be more appropriate here.", + "prediction": "I'm not sure why we're using `GridSearchCV` instead of `RandomizedSearchCV` here. I think `RandomizedSearchCV` is more appropriate here.", "reference": "Is it possible to use `np.random` module instead?" }, { - "prediction": "I'm not sure what you mean by `allow_None=True` in this case. I think it should be `allow_None=False` or `allow_None=True` depending on what you want to do.", + "prediction": "I'm not sure what you mean by `allow_None=True` in this case. I think it should be `allow_None=False` or `allow_None=True` depending on whether you want to allow `None` values or not.", "reference": "``default=None`` implies ``allow_None`` so ``allow_None`` is superfluous here. As a special case, if allow_None=True (which is true by default if the parameter has a default of None when declared) then a value of None is also allowed." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the `system:k3s-controller` user is bound to a role in `rolebindings.yaml` or the downstream equivalent.", + "prediction": "I think this should be `runtime.ClientK3sControllerCert` and `runtime.ClientK3sControllerKey` instead of `runtime.ClientKubeProxyCert` and `runtime.ClientKubeProxyKey`.", "reference": "Is there anything in particular that makes setting up the downstream rolebinding(s) to `system:k3s-controller` burdensome or confusing? This changes looks fine to me but it seems a shame to alias an embedded k3s controller. If we are doing this in other places that I am not aware of then we can dismiss this concern out of hand." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it would be better to use the `acd` package instead of the `github.com/ncw/go-acd` package. The `github.com/ncw/go-acd` package is a fork of the `acd` package, which is a fork of the `acd` package, which is a fork of the `acd` package, which is a fork of the `acd` package, which is a fork of the `acd` package, which is a fork of the `acd` package, which is a fork of the `acd` package, which is a fork of the `acd` package, which is a fork of the `acd` package, which is a fork of the `acd` package, which is a fork of the `acd` package, which is a fork of the `acd` package, which is a fork of the `acd` package, which is a fork of the `acd` package, which is a fork of the `acd` package, which is a fork of the `acd` package, which is a fork of the `acd", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it would be better to use `github.com/ncw/rclone/fs/config/configmap` instead of `github.com/ncw/rclone/fs/config/config`.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { - "prediction": "I think we should remove the `public` keyword from the `Os` class.", + "prediction": "I think this should be `public string Name { get; set; }` instead of `public string Name { get; set; } { get; set; }`", "reference": "nit: all other types in this project have full names, so maybe a better name would be `OperatingSystem`?" }, { - "prediction": "I think this should be `#include \"GraphMol/MolTransforms/MolTransforms.h\"`.", + "prediction": "I think this should be `#include \"GraphMol/MolTransforms/MolTransforms.h\"`", "reference": "Why is this needed here?" }, { @@ -2655,35 +2655,35 @@ "reference": "mmm, why a method declaration should not have the TypeVariableResolutionCapability? Is this ok?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to pass in a `TransactionPool` and a `PrivateTransactionHandler`, but you're not passing in a `PrivacyParameters` or a `TransactionPool` or a `PrivateTransactionHandler`. You're passing in a `TransactionPool` and a `PrivateTransactionHandler`, but you're not passing in a `PrivacyParameters` or a `TransactionPool` or a `PrivateTransactionHandler`. I'm not sure what you're trying to do here. I think you're trying to pass in a `TransactionPool` and a `PrivateTransactionHandler`, but you're not passing in a `PrivacyParameters` or a `TransactionPool` or a `PrivateTransactionHandler`. You're passing in a `TransactionPool` and a `PrivateTransactionHandler`, but you're not passing in a `PrivacyParameters` or a `TransactionPool` or a `PrivateTransactionHandler`. I'm not sure what you're trying to do here. I think you're trying to pass in a `TransactionPool` and a `PrivateTransactionHandler`, but you're not passing in a `PrivacyParameters` or a `TransactionPool` or a `PrivateTransactionHandler`. You're passing in a `TransactionPool", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to pass in a `TransactionPool` and a `PrivateTransactionHandler`, but you're not passing in a `PrivacyParameters` or a `TransactionPool` or a `PrivateTransactionHandler`. I'm not sure what you're trying to do here. I think you're trying to pass in a `TransactionPool` and a `PrivateTransactionHandler`, but you're not passing in a `PrivacyParameters` or a `TransactionPool` or a `PrivateTransactionHandler`. I'm not sure what you're trying to do here. I think you're trying to pass in a `TransactionPool` and a `PrivateTransactionHandler`, but you're not passing in a `PrivacyParameters` or a `TransactionPool` or a `PrivateTransactionHandler`. I'm not sure what you're trying to do here. I think you're trying to pass in a `TransactionPool` and a `PrivateTransactionHandler`, but you're not passing in a `PrivacyParameters` or a `TransactionPool` or a `PrivateTransactionHandler`. I'm not sure what you're trying to do here. I think you're trying to pass in a `TransactionPool` and a `PrivateTransactionHandler`,", "reference": "nit: any reason you swapped the ordering?" }, { - "prediction": "\").dispatchEvent(new CustomEvent(\"change\", {\n```\nReview comment?", + "prediction": "\").dispatchEvent(new CustomEvent(\"change\", {\n })\n });\n```\nReview comment?", "reference": "can you de-uglify at least this line?.. hard to tell what changed..." }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it should be in the `BPFDataplane` package.", + "prediction": "I'm not sure if this is the best place to put this, but I think it would make sense to move it to the `bpfdataplane` package. It's a bit more general than the `bpfdataplane` package.", "reference": "Please can you merge master in before making these changes. I just reinstated a bunch of BPF UTs. Possible that the UTs use this code." }, { - "prediction": "This is a regression test for issue 4638.", + "prediction": "I think this should be `type(self).__a__` instead of `type(self).__class_var`", "reference": "Do you want to add additional cases for `Bla.__b()` and `self.__c()`? (Just add additional classmethods `__b` and `__c` and the calls to `__init__`)" }, { - "prediction": "I'm not sure what you mean by \"easy_search_form=EasySearchForm(csrf_enabled=False)\". I think you meant to say `easy_search_form=EasySearchForm(csrf_enabled=True)`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `get_current_user_records_that_can_be_displayed` function. I think it would be a good idea to move this into the `get_current_user_records_that_can_be_displayed` function. I think it would be a good idea to move this into the `get_current_user_records_that_can_be_displayed` function. I think it would be a good idea to move this into the `get_current_user_records_that_can_be_displayed` function. I think it would be a good idea to move this into the `get_current_user_records_that_can_be_displayed` function. I think it would be a good idea to move this into the `get_current_user_records_that_can_be_displayed` function. I think it would be a good idea to move this into the `get_current_user_records_that_can_be_displayed` function. I think it would be a good idea to move this into the `get_current_user_records_that_can_be_displayed` function. I think it would be a good idea to move this into the `get_current_user_records_that_can_be_displayed` function. I think it would be a good", "reference": "the recids is never changed after. So, it should contains the exact shown results, whatever are the rights for the user (admin or simple user, restricted collections...)" }, { - "prediction": "I think this should be `if len(realOpts.ContentMD5) == 0` instead of `if len(realOpts.ContentMD5) == 0 && opts != nil`", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `Bucket` struct.", "reference": "Shouldn't the docstring mention that the MD5 checksum of `p` is computed each time and verified? Also, could there be use cases where a caller might not want such a check to happen because, eg, a blob storage solution doesn't provide MD5 verification or uses another hash algorithm such as SHA256?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I'm not sure what you mean by \"allow NVDAObjects to redirect focus events to another object of their choosing\"", "reference": "focusRedirect is used in the powerpnt appModule. We might have to make sure that this does not break. Having said that, I really like this being handled on the events level!" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add a comment to explain what the change is doing.", + "prediction": "I don't think we need to use `base64` here. We can just use `string` here.", "reference": "You imports are out of order" }, { @@ -2691,7 +2691,7 @@ "reference": "This should not be called Flow Trigger. FlowTrigger should has its own flowTrigger job name, for instance, \"flowtrigger\"" }, { - "prediction": "I'm not sure what you mean by \"this is required for sqlite3 usage\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `db` package.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { @@ -2699,11 +2699,11 @@ "reference": "Why do we need `\\n` if we already use `WriteLine`? (and `\\n` is not cross platform)" }, { - "prediction": "I don't think this is a good idea. We should have a default value for `protocol` and `port` instead of hardcoding them in the constructor.", + "prediction": "I don't think we need to change the default value of `protocol` to `prometheus`.", "reference": "What is instrumentation name used for? I'm not seeing other classes use it, only a getter, constructor, and builder." }, { - "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to have an event for `Inserted` and an event for `Removed`. I think it's a good idea to have an event for `Inserted` and an event for `Removed`, but I'm not sure if it's a good idea to have an event for `Inserted` and an event for `Removed`. I think it's a good idea to have an event for `Inserted` and an event for `Removed`, but I'm not sure if it's a good idea to have an event for `Inserted` and an event for `Removed`. I think it's a good idea to have an event for `Inserted` and an event for `Removed`, but I'm not sure if it's a good idea to have an event for `Inserted` and an event for `Removed`. I think it's a good idea to have an event for `Inserted` and an event for `Removed`, but I'm not sure if it's a good idea to have an event for `Inserted` and an event for `Removed`. I think it's a good idea to have an event for `Inserted` and an event for `Removed`, but I'm not sure", + "prediction": "I'm not sure if this is a good idea, but I don't think it's a good idea to remove the `public partial class SortedPool` from the `Nethermind.TxPool.Collections` namespace. The `Nethermind.TxPool.Collections` namespace is used by the `Nethermind.TxPool` assembly, and it's not necessary to have a separate `Nethermind.TxPool.Collections.SortedPool` namespace.", "reference": "@kristofgazso could you review these warnings?" }, { @@ -2711,7 +2711,7 @@ "reference": "will delete this." }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason you want to use `class: 'button'` instead of `class: 'btn btn-primary'`?", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to create a link to the new plan purchase page for a specific plan, but I'm not sure what you're trying to do with the `class: 'button'` attribute. I think you're trying to create a link to the new plan purchase page for a specific plan, but I'm not sure what you're trying to do with the `class: 'button'` attribute. I think you're trying to create a link to the new plan purchase page for a specific plan, but I'm not sure what you're trying to do with the `class: 'button'` attribute. I think you're trying to create a link to the new plan purchase page for a specific plan, but I'm not sure what you're trying to do with the `class: 'button'` attribute. I think you're trying to create a link to the new plan purchase page for a specific plan, but I'm not sure what you're trying to do with the `class: 'button'` attribute. I think you're trying to create a link to the new plan purchase page for a specific plan, but I'm not sure what you're trying to do with", "reference": "~~Indent 2 lines above~~ Disregard. My fault" }, { @@ -2723,87 +2723,87 @@ "reference": "This will always add the authorization header to the request object. Is this the right scope for these two lines? If username/password are not defined, it will encode 'Basic :'" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to build up a serialized buffer algorithmically, but you're not using the `flatbuffers::DetachedBuffer` class. You're using `flatbuffers::DetachedBuffer` in the `CreateFlatBufferTest` function, but you're not using it in the `test_data_path` string.", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to build up a serialized buffer algorithmically, but you're not using the `flatbuffers::DetachedBuffer` class. I'm not sure what you're trying to do here, but it looks like you're trying to build up a serialized buffer algorithmically, but you're not using the `flatbuffers::DetachedBuffer` class. I'm not sure what you're trying to do here, but it looks like you're trying to build up a serialized buffer algorithmically, but you're not using the `flatbuffers::DetachedBuffer` class. I'm not sure what you're trying to do here, but it looks like you're trying to build up a serialized buffer algorithmically, but you're not using the `flatbuffers::DetachedBuffer` class. I'm not sure what you're trying to do here, but it looks like you're trying to build up a serialized buffer algorithmically, but you're not using the `flatbuffers::DetachedBuffer` class. I'm not sure what you're trying to do here, but it looks like you're trying to build up a serialized buffer algorithmically, but you're not using the `flat", "reference": "Is this always how Bazel does paths? Would it be nicer to do `-DBAZEL_TEST_DATA_PATH=../com_github_google_flatbuffers/tests/` so this string is not hardcoded in the the source?" }, { - "prediction": "I'm not sure if this is the right place to add the `date_utc` field.", + "prediction": "I'm not sure if this is the best way to do this, but I think we should add `date_utc` to the `update_id` and `target_doc_type` as well.", "reference": "Not an expert of ES, so not sure of the impact here." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `Int32 *` for `roleList` and `Int32 *` for `granteeList`.", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get the list of roles granted to the current user. I'm not sure what you're trying to do here, but it looks like you're trying to get the list of roles granted to the current user. I'm not sure what you're trying to do here, but it looks like you're trying to get the list of roles granted to the current user. I'm not sure what you're trying to do here, but it looks like you're trying to get the list of roles granted to the current user. I'm not sure what you're trying to do here, but it looks like you're trying to get the list of roles granted to the current user. I'm not sure what you're trying to do here, but it looks like you're trying to get the list of roles granted to the current user. I'm not sure what you're trying to do here, but it looks like you're trying to get the list of roles granted to the current user. I'm not sure what you're trying to do here, but it looks like you're trying to get the list of roles granted to the current user. I'm not sure what you're trying", "reference": "Who deletes the memory for the granteeList? (or the roleList for that matter)" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to decrease the number of subscriptions for a websocket session. I'm not sure what you're trying to do here, but it looks like you're trying to decrease the number of subscriptions for a websocket session. I'm not sure what you're trying to do here, but it looks like you're trying to decrease the number of subscriptions for a websocket session. I'm not sure what you're trying to do here, but it looks like you're trying to decrease the number of subscriptions for a websocket session. I'm not sure what you're trying to do here, but it looks like you're trying to decrease the number of subscriptions for a websocket session. I'm not sure what you're trying to do here, but it looks like you're trying to decrease the number of subscriptions for a websocket session. I'm not sure what you're trying to do here, but it looks like you're trying to decrease the number of subscriptions for a websocket session. I'm not sure what you're trying to do here, but it looks like you're trying to decrease the number of subscriptions for a websocket session. I'm not sure what you're trying to do here, but it looks like", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to decrease the number of subscriptions, but I don't think that's what you want to do. I think you want to increase the number of subscriptions, but I'm not sure what you're trying to do here. I think you're trying to decrease the number of subscriptions, but I don't think that's what you want to do. I think you want to increase the number of subscriptions, but I'm not sure what you're trying to do here. I think you're trying to decrease the number of subscriptions, but I don't think that's what you want to do. I think you want to increase the number of subscriptions, but I'm not sure what you're trying to do here. I think you're trying to decrease the number of subscriptions, but I don't think that's what you want to do. I think you want to increase the number of subscriptions, but I'm not sure what you're trying to do here. I think you're trying to decrease the number of subscriptions, but I don't think that's what you want to do. I think you want to increase the number of subscriptions, but I'm not sure what you're trying to do here", "reference": "This loop is missing a lock on subscriptions_mutex." }, { - "prediction": "I'm not sure what you're trying to do with the `match '/sign_in' => 'sessions#new', as: 'sign_in', via: :delete` line. I think you want to use `match '/sign_in' => 'sessions#new', as: 'sign_in', via: :delete` instead.", + "prediction": "I'm not sure what you're trying to achieve with this route, but I think it should be `match '/sign_in' => 'sessions#new', as: 'sign_in', via: :get`", "reference": "shouldn't clearance be setting these up for us?" }, { - "prediction": "I'm not sure what you mean by \"noOp\" in this context. It's not clear to me what you're trying to do with it. Is it a detector that doesn't do anything, or is it a detector that doesn't provide any resources at all? If it's the latter, then I think we should remove it. If it's the former, then I think we should keep it. I'm not sure what you're trying to do with it. Is it a detector that doesn't do anything, or is it a detector that doesn't provide any resources at all? If it's the latter, then I think we should remove it. If it's the former, then I think we should keep it. I'm not sure what you're trying to do with it. Is it a detector that doesn't do anything, or is it a detector that doesn't provide any resources at all? If it's the latter, then I think we should remove it. If it's the former, then I think we should keep it. I'm not sure what you're trying to do with it. Is it a detector that doesn't do anything, or is it a detector that doesn't provide any resources at all? If it's the latter,", + "prediction": "I'm not sure what you mean by \"noOp\" in this context. It's not clear to me what you're trying to do with it. Is it a detector that doesn't do anything, or is it a detector that just returns an empty resource? If it's the former, then I think we should remove it. If it's the latter, then I think we should keep it.", "reference": "Need to update the doc for `TelemetrySDK` and `Host` structs deleting references from removed functions." }, { - "prediction": "I think this should be `true` instead of `isNested() || isLocal()`.", + "prediction": "I think this should be `isLocal()` instead of `isNested()`.", "reference": "I think we should keep that here and add a new method `isSyntacticallyFinal` that returns `super.isFinal()` (and can be used in UnnecessaryModifier). Otherwise the contract of `isFinal` is not respected" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure the scroll position we need to see the row is more than the bottom boundary, i.e. obscured below the bottom of the self...", "reference": "Is there a reason why we wouldn't want to check this every time? Why are we only checking for the footer and scroll bar when enableCellEditOnFocus is true?" }, { - "prediction": "I don't think this is a good idea. The `RemoteAvailableInstallers` class is already injected by PlayOnLinux, so we don't need to inject it again. We can just use the `RemoteAvailableInstallers` class from PlayOnLinux directly.", + "prediction": "I don't think this is needed anymore. The `RemoteAvailableInstallers` class is now part of the `com.playonlinux.webservice` package, so we don't need to import it here.", "reference": "You need to create an API for this class. This class should follow roughly the same dependency structure than RemoteAvailableInstallersPlayOnLinuxImplementation / RemoteAvailableInstallers. Maybe we could use a inner class here?" }, { - "prediction": "I'm not sure if this is needed, but I think it's better to use `workflow_id` instead of `workflow_id` and `workflow_type_name` instead of `workflow_type_name`.", + "prediction": "I'm not sure why this is needed. I think we can just use `workflow_id` instead of `workflow_id` and `workflow_type_name` instead of `workflow_type_name`.", "reference": "This should not be a case, right? If `run_id` is the same `workflow_id` can't be changed. Actually surprised that it is not part of a key." }, { - "prediction": "I think this should be `generator->setAqrEnabled(FALSE);` instead of `generator->setAqrEnabled(FALSE); generator->setUpdAbortOnError(TRUE); generator->setUpdSavepointOnError(FALSE);`", + "prediction": "I think it's better to set the AQR to `TRUE` in the `preCodeGen` function.", "reference": "How would AQR work for an INSERT/SELECT of one table into another where a LOB column is being copied?" }, { - "prediction": "`sds_v2` and `sdssv3` should be the same as `sds_v2` and `sdssv2` respectively.", + "prediction": "`sds` and `sdsv2` should be the same as `sdsv3`.", "reference": "Since these are ultimately different endpoints, it would be nice if we could move them up one level and nuke the common `sds` directory in order to reduce path stutter" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a `beforeChangeResult` property to the `Core` object. This way, we can check if the `beforeChangeResult` is an empty array or not.", + "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a `beforeChange` function that returns a function, so that we can use `beforeChangeResult` in the `beforeChange` function.", "reference": "Please check also whether `null` occurs in the rest of `beforeChangeResult` array." }, { - "prediction": "I'm not sure what you mean by \"change the context\". I think you meant to say \"change the request\" or \"change the request context\".", + "prediction": "I'm not sure what you mean by \"change the context\" here. I think you meant to say \"change the request\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's context\" or \"change the request's", "reference": "Outdated docs. There is no response, there's an ack." }, { - "prediction": "I'm not sure what you mean by \"cannot start a container that has run and stopped\"", + "prediction": "I don't think this is a good idea. The `container.Exec()` will block until the container is ready to be started. If the container is already running, `container.Signal(libcontainer.InitContinueSignal)` will block until the container is ready to be started. If the container is stopped, `container.Signal(libcontainer.InitContinueSignal)` will block until the container is ready to be started. If the container is stopped, `container.Signal(libcontainer.InitContinueSignal)` will block until the container is ready to be started. If the container is stopped, `container.Signal(libcontainer.InitContinueSignal)` will block until the container is ready to be started. If the container is stopped, `container.Signal(libcontainer.InitContinueSignal)` will block until the container is ready to be started. If the container is stopped, `container.Signal(libcontainer.InitContinueSignal)` will block until the container is ready to be started. If the container is stopped, `container.Signal(libcontainer.InitContinueSignal)` will block until the container is ready to be started. If the container is stopped, `container.Signal(libcontainer.InitContinueSignal)` will block until the container is ready to be started. If the container is stopped, `container.Signal(libcontainer.InitContinueSignal)` will block until the container is", "reference": "I'd rather have the container process remove the FIFO after it unblocks. Then `start` can always `Exec()`, and you can catch the \"FIFO does not exist\" error and translate it to a prettier \"someone must have already started the container\"." }, { - "prediction": "I think this should be `if err != nil || tx == nil` instead of `if err != nil && tx == nil`", + "prediction": "I think this should be `if err != nil || tx == nil`", "reference": "can you check if there's other similar cases to add nil-check like this?" }, { - "prediction": "I think this should be `is_valid_commonname = commonname is not None and len(commonname) < 64` instead of `is_valid_commonname = (commonname is not None and len(commonname) < 64)`", + "prediction": "I think this should be `is_valid_commonname = commonname is not None and len(commonname) < 64`", "reference": "`<= 64`? I just picked up what you said in #3981 (\"the CN field is limited to 64 characters\") but maybe there's something I don't know where the 64th character is needed (trailing dot or whatever?) Also this sounds like something that could be beautifully unit tested. Sorry for bugging you :grin:" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I think it's better to just use `nice_name` instead of `abbreviation`.", + "prediction": "I'm not sure what you're trying to achieve with this, but I think it's better to just use `nice_name` instead of `nice_name.blank?`.", "reference": "I understand that this grabs a Licenses objects but what is the autocomplete method used for? What does this do in context of the auto_completes controller?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to get the transaction receipt for a given transaction hash, but I'm not sure what you're trying to do with the transaction receipt.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a method that returns the transaction receipt for a given transaction hash.", "reference": "I don't really like that way of naming methods based on their arguments. But I can see that the other method names are the same ..." }, { - "prediction": "I'm not sure what you're trying to do with this. It looks like you're trying to generate a key from a string, but I'm not sure what you're trying to do with it. It looks like you're trying to generate a key from a string, but I'm not sure what you're trying to do with it. It looks like you're trying to generate a key from a string, but I'm not sure what you're trying to do with it. It looks like you're trying to generate a key from a string, but I'm not sure what you're trying to do with it. It looks like you're trying to generate a key from a string, but I'm not sure what you're trying to do with it. It looks like you're trying to generate a key from a string, but I'm not sure what you're trying to do with it. It looks like you're trying to generate a key from a string, but I'm not sure what you're trying to do with it. It looks like you're trying to generate a key from a string, but I'm not sure what you're trying to do with it. It looks like you're trying to generate a key from a string, but I'm not sure", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.", "reference": "@sekmiller This method correctly strips the leading and trailing slashes (and also \".\" and \"-\"); But I thought the plan was also to replace any multiple slashes between nested folders with a single slash. For example, as implemented now, I can enter \"folder1///folder2\", and it gets saved and displayed like this, with the 3 slashes. I thought we wanted to sanitize it as \"folder1/folder2\"." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get the pid of the current process. I'm not sure what you're trying to do here, but it looks like you're trying to get the pid of the current process. I'm not sure what you're trying to do here, but it looks like you're trying to get the pid of the current process. I'm not sure what you're trying to do here, but it looks like you're trying to get the pid of the current process. I'm not sure what you're trying to do here, but it looks like you're trying to get the pid of the current process. I'm not sure what you're trying to do here, but it looks like you're trying to get the pid of the current process. I'm not sure what you're trying to do here, but it looks like you're trying to get the pid of the current process. I'm not sure what you're trying to do here, but it looks like you're trying to get the pid of the current process. I'm not sure what you're trying to do here, but it looks like you're trying to get the pid of the current process. I'm not sure", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `asm(\"movz x8, \" STRINGIFY(SYS_getpid) \";\"```. I think you should use `asm(\"movx x8, \" STRINGIFY(SYS_getpid) \";\"```.", "reference": "Looks like the X86 inline assembly is not happy with this type. I will update that" }, { @@ -2811,27 +2811,27 @@ "reference": "Tabs and a space, again." }, { - "prediction": "I'm not sure what you mean by \"clearspawntimers()\". It's not clear to me what you're trying to do here.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the `QuestManagerCurrentQuestVars` function as well.", "reference": "Please just enclose if blocks with brackets; this has created issues in the past so I'd prefer we don't use them" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `link_to` instead of `link_to` in this case. The `link_to` method is more flexible and allows you to pass in any number of arguments, whereas `link_to` only accepts a single argument. Also, the `class: 'form-button'` attribute is more specific than the `class: 'form-button'` attribute in the `link_to` method.", + "prediction": "I think we should remove the `class: 'form-button'` from the approve button.", "reference": "`version` isn't need anymore because it's built into `approve_proposal_url`, yes?" }, { - "prediction": "I think this should be `from scapy.data import MTU, DLT_BLUETOOTH_LE_LL, DLT_BLUETOOTH_LE_LL_WITH_PHDR` instead of `from scapy.data import MTU, DLT_BLUETOOTH_LE_LL, DLT_BLUETOOTH_LE_LL_WITH_PHDR`", + "prediction": "I think this should be moved to `scapy.layers.dot11` instead of `scapy.layers.ppi`.", "reference": "Moved to the bottom of the file. `CtrlPDU` sits on `BTLE_DATA` so let's put it after" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bit of a mix-up. The `include Blacklight::SolrHelper` line should be `include Blacklight::SolrHelper::HelperMethods`.", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to use `self.helper_method` in a way that doesn't make sense. I'm not sure what you're trying to do here. I think you're trying to use `self.helper_method` in a way that doesn't make sense. I'm not sure what you're trying to do here. I think you're trying to use `self.helper_method` in a way that doesn't make sense. I'm not sure what you're trying to do here. I think you're trying to use `self.helper_method` in a way that doesn't make sense. I'm not sure what you're trying to do here. I think you're trying to use `self.helper_method` in a way that doesn't make sense. I'm not sure what you're trying to do here. I think you're trying to use `self.helper_method` in a way that doesn't make sense. I'm not sure what you're trying to do here. I think you're trying to use `self.helper_method` in a way that doesn't make sense. I'm not sure what you're trying to do here. I think you're trying to use `self.helper_method` in", "reference": "This ends up requiring the `json` gem, right? Is there any way we can do this to be implementation agnostic (e.g. to let me use `yajl-ruby` for performance reasons (or because my app already brings in a JSON library)" }, { - "prediction": "I'm not sure what you're trying to do with this, but it's not clear to me what the purpose of this function is. It's not clear to me what the purpose of this function is. It's not clear to me what the purpose of this function is. It's not clear to me what the purpose of this function is. It's not clear to me what the purpose of this function is. It's not clear to me what the purpose of this function is. It's not clear to me what the purpose of this function is. It's not clear to me what the purpose of this function is. It's not clear to me what the purpose of this function is. It's not clear to me what the purpose of this function is. It's not clear to me what the purpose of this function is. It's not clear to me what the purpose of this function is. It's not clear to me what the purpose of this function is. It's not clear to me what the purpose of this function is. It's not clear to me what the purpose of this function is. It's not clear to me what the purpose of this function is. It's not clear to me what the purpose of this function is. It's not clear", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `compressor` package.", "reference": "This seems dangerous. What circumstances lead to the need for a retry? Can that happen more than once? I'm concerned that if we hit the pathological state, this could turn into a CPU spinner. I wonder if we could get the same benefit from just \"trying again\" and failing if it fails the second time." }, { - "prediction": "I'm not sure what you're trying to do here. You're creating a new `ReplacePartitions` object, but you're not setting the `startingSnapshotId` and `validateNoConflictingAppends` properties.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `validateNoConflictingAppends` method to the `BaseReplacePartitions` class.", "reference": "If there is a reference to other fields or methods, please do the initialization in the constructor." }, { @@ -2839,39 +2839,39 @@ "reference": "These should be importing from `pill-container`" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `playerRequestTrade` function.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea.", "reference": "Why this change? It will now only show on the bottom of the screen as white text, is it correct behaviour?" }, { - "prediction": "I'm not sure what you mean by `except_operations: [Rendering::HelperMethod]`", + "prediction": "I'm not sure what you mean by \"except_operations: [Rendering::HelperMethod]\"", "reference": "Does this need to allocate a string or would a nil value (indicating no header) be a better?" }, { - "prediction": "`this.constructor` should be `this.props` instead of `this.state`", + "prediction": "`this.constructor` should be `this._constructor` or `this._component` or `this.component` or `this._component` or `this.component` or `this._component` or `this.component` or `this._component` or `this.component` or `this._component` or `this.component` or `this._component` or `this.component` or `this._component` or `this.component` or `this._component` or `this.component` or `this._component` or `this.component` or `this._component` or `this.component` or `this._component` or `this.component` or `this._component` or `this.component` or `this._component` or `this.component` or `this._component` or `this.component` or `this._component` or `this.component` or `this._component` or `this.component` or `this._component` or `this.component` or `this._component` or `this.component` or `this._component` or `this.component` or `this._component` or `this.component` or `this._component` or `this.component` or `this._component` or `this.component` or `this", "reference": "Nit: Past tense of `reset` is also `reset`." }, { - "prediction": "I'm not sure what you're trying to achieve with this command. It's not clear to me what you're trying to achieve with this command.", + "prediction": "I'm not sure what you mean by \"config settings\" in this context. Is it possible that you are referring to the `config` object? If so, I think we should remove the `config` from the name of the command.", "reference": "Shouldn't this use `'n'` instead?" }, { - "prediction": "I don't think this is a good idea. It's not clear to me what this task type is for. I think it should be `enumsspb.TASK_TYPE_USER_TIMER` and `enumsspb.TASK_TYPE_ACTIVITY_TASK_TIMEOUT` instead.", + "prediction": "I don't think we need to change this, but I'm not 100% sure that this is the right way to do it.", "reference": "revert back to 'TASK_TYPE_ACTIVITY_TIMEOUT'" }, { - "prediction": "I'm not sure what you mean by \"template void Engine::GetBlock(const std::string &, T **, const Mode);\". Is this the same as \"template void Engine::GetBlock(const std::string &, std::vector &, const Mode);\"?", + "prediction": "I think it's a good idea to add a `template void Engine::Get(const std::string &, std::vector &, const Mode);` to the `template void Engine::Get(const std::string &, std::vector &, const Mode);`", "reference": "Shouldn't we prefer passing a pointer by reference T*&, since these are C++ bindings?" }, { - "prediction": "I think we can remove the `if cgExists` check here, as it's not necessary.", + "prediction": "I don't think we need to check for `cgExists` here, since we already have `ingressRule.SourceGroups` in `ingressRule`.", "reference": "nit: Personally I feel that it's cleaner to let `toAntreaPeerForCRD` to take `ingressRule` as a param instead of `ingressRule.From`. It can call `processRefCGs` inside the function and do the ipBlock/AG union within the function itself. It might not be worth the refactor though." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to update the status of the spc object to indicate that it's in the process of being updated.", + "prediction": "I'm not sure if this is the right way to do this, but I think we should be able to update the spc version without having to wait for the spc update to complete.", "reference": "Pending has been set only for SPC.. why? for other CRs as well, this need to be done.. right?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `http_build_query` function to build the query string.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.", "reference": "would use an empty string here as default and then check for emptiness in the twig template. I dont like mixing types @core23 what do you think?" }, { @@ -2883,59 +2883,59 @@ "reference": "why use these rather than regular named paths?" }, { - "prediction": "I'm not sure I understand what you're trying to do here.", + "prediction": "I don't think this is a good idea. I think it would be better to have a separate `--help` option.", "reference": "Hm, I don't think the extra flags are doing any harm here, but it does seem like `--help` is the only flag you could *actually* use with this command. We might eventually want to separate those out." }, { - "prediction": "I think we can remove the `#` from the top_artist_candidate_set_df and similar_artist_candidate_set_df.", + "prediction": "I don't think we need to use `uuid` here. We can use `str(uuid.uuid4())` instead.", "reference": "We should make this a docstring, so that editors are able to pick it up." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a test for this.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a test for this in `authed_to_access_event_fired_for` as well.", "reference": "Put a comma after the last parameter of a multiline method call." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to set the `appCacheMaxSize` and `appCacheEnabled` in the `webSettings` object.", + "prediction": "I'm not sure if this is the right place to set the app cache size. I think it's better to set the app cache size in the `webSettings` object.", "reference": "App cache size is now managed dynamically by the `WebView`. This statement has no effect in the new framework." }, { - "prediction": "I think this should be `nodeName === 'img' || nodeName === 'input' || nodeName === 'area'`", + "prediction": "I think this should be `nodeName === 'img' || nodeName === 'input' || nodeName === 'area'`.", "reference": "VirtualNode has a `hasAttr` function, any reason why you're not using it?" }, { - "prediction": "I'm not sure what you mean by \"should be called from the application\".", + "prediction": "I think this should be `assert DEFAULT == null` instead of `assert DEFAULT == null : \"HttpAccess.init should be called once per process\"`.", "reference": "This now throws when running tests (maybe the move to java 11??). Do we want to keep it?" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bad idea to use `if len(sha1) == 40 { ... }` in this case. I think it's better to use `if len(sha1) > 7 { ... }` instead.", + "prediction": "I think we can remove the `if len(sha1) == 40` check.", "reference": "We can allow 7-char SHA, does not mean we want to show with 7-char in default, please change to `if len() > 10`, then cut." }, { - "prediction": "I don't think this is a good idea. It's not clear what it means to have a duplicate file, and it's not clear what it means to have a duplicate file that already exists. It's also not clear what it means to have a duplicate file that doesn't already exist. I think it would be better to just say \"Cannot add the duplicate file %{fileName}, it already exists\".", + "prediction": "I don't think we need to change this.", "reference": "this one should also have quotes i guess :)" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to test that the `unstructured.Object.GetName()` method is called with the expected name, but I don't think that's what you're trying to test here. I think you're trying to test that the `unstruct.Object.GetName()` method is called with the expected name, but I don't think that's what you're trying to test here. I think you're trying to test that the `unstruct.Object.GetName()` method is called with the expected name, but I don't think that's what you're trying to test here. I think you're trying to test that the `unstruct.Object.GetName()` method is called with the expected name, but I don't think that's what you're trying to test here. I think you're trying to test that the `unstruct.Object.GetName()` method is called with the expected name, but I don't think that's what you're trying to test here. I think you're trying to test that the `unstruct.Object.GetName()` method is called with the expected name, but I don't think that's what you're trying to test here. I think you're trying to test that the `unstruct.Object.GetName", "reference": "Using the variable on range scope `mock` in function literal (from `scopelint`)" }, { - "prediction": "I'm not sure if this is the right place to do this.", + "prediction": "I think this should be `isWorkflow() ? accepted(json(res.getDataset())) : ok(json(res.getDataset()));`", "reference": "does this result in a 200 when the dataset is still inprogress/publishing not yet finalized? Seems like 202 is the right code for that (as it was) and the test should be watching for a 202?" }, { - "prediction": "I don't think this is needed.", + "prediction": "I don't think we need to add `ORDER_PATH` as it is not used in the plugin.", "reference": "Previously you could only order by the field you were searching by. But for full-text search, you can search across all indexed fields, and it didn't make sense not to have a sorting. For backward compatibility, the javascript code uses indexPath as the orderPath when no orderPath is provided." }, { - "prediction": "I'm not sure what you mean by `mountAll`", + "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to apply a diff to the DOM of a component. I'm not sure what you're trying to do here, but it looks like you're trying to apply a diff to the DOM of a component. I'm not sure what you're trying to do here, but it looks like you're trying to apply a diff to the DOM of a component. I'm not sure what you're trying to do here, but it looks like you're trying to apply a diff to the DOM of a component. I'm not sure what you're trying to do here, but it looks like you're trying to apply a diff to the DOM of a component. I'm not sure what you're trying to do here, but it looks like you're trying to apply a diff to the DOM of a component. I'm not sure what you're trying to do here, but it looks like you're trying to apply a diff to the DOM of a component. I'm not sure what you're trying to do here, but it looks like you're trying to apply a diff to the DOM of a component. I'm not sure what you're trying to do here, but it", "reference": "VIM didn't like your whitespace." }, { - "prediction": "I think this should be `using Datadog.Trace.ClrProfiler;` instead of `using Datadog.Trace.TestHelpers;`", + "prediction": "I'm not sure if this is a good idea, but I don't think it's a good idea to use `using Datadog.Trace.ClrProfiler;` in this case. I think we should use `using Datadog.Trace.TestHelpers;` instead.", "reference": "Are you sure the namespace should change?" }, { - "prediction": "I don't think this is a good idea. The `Startup` and `Reset` methods should be in the `ViewModelBase` class, not in the `MvvmCross.ViewModels` namespace.", + "prediction": "I'm not sure what you mean by \"Startup\" in this context. It's not clear to me what you're trying to do with this method. Is it supposed to be called when the application starts?", "reference": "@martijn00 I'm not sure why we're keeping the object parameter and return type since this can be done by using MvxApplication with THint set to object" }, { @@ -2943,23 +2943,23 @@ "reference": "why do we create a time type here?" }, { - "prediction": "I don't think we need to use `!` here.", + "prediction": "I'm not sure what you mean by \"use strict\" here. I'm not sure what you mean by \"use strict\" here. I'm not sure what you mean by \"use strict\" here. I'm not sure what you mean by \"use strict\" here. I'm not sure what you mean by \"use strict\" here. I'm not sure what you mean by \"use strict\" here. I'm not sure what you mean by \"use strict\" here. I'm not sure what you mean by \"use strict\" here. I'm not sure what you mean by \"use strict\" here. I'm not sure what you mean by \"use strict\" here. I'm not sure what you mean by \"use strict\" here. I'm not sure what you mean by \"use strict\" here. I'm not sure what you mean by \"use strict\" here. I'm not sure what you mean by \"use strict\" here. I'm not sure what you mean by \"use strict\" here. I'm not sure what you mean by \"use strict\" here. I'm not sure what you mean by \"use strict\" here. I'm not sure what you mean by \"use strict\" here. I'm not sure", "reference": "Does this style actually need to get loaded in all of these components?" }, { - "prediction": "I think we should remove the `vertx` dependency from the `VertxTLSBuilder` class.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to `io.servicecomb.transport.rest.vertx.accesslog.impl.AccessLogHandlerImpl` so that it can be used by `io.servicecomb.transport.rest.vertx.accesslog.parser.impl.DefaultAccessLogPatternParser` and `io.servicecomb.transport.rest.vertx.accesslog.parser.impl.DefaultAccessLogParser`.", "reference": "import but not used so you did not resolve compile warnings?" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to do something like this: `damage -= uniform_random(armor / 2, armor - (armor % 2 + 1));`", "reference": "This is so much more concise and beautiful than the previous formula" }, { - "prediction": "I don't think this is needed anymore.", + "prediction": "I don't think this is necessary. The `Accounts` and `AccountTransactions` are already defined in the `AcceptanceTestBase` class, so we don't need to create them again.", "reference": "Is there any reason not to have the `static` modifier for the logger? _(that would be in keeping with the reference being uppercase)_" }, { - "prediction": "I'm not sure what you mean by `GetSessionConfig() (SessionCreationConfig, error)`. Is this the same as `Start(ConnectOptions) { ... }`?", + "prediction": "I don't think this is needed anymore.", "reference": "It's not about session creation config. It's about passing consumer config parameters to underlying transport - nothing to do with session itself" }, { @@ -2967,7 +2967,7 @@ "reference": "Why is there an \"enable\" in the param name? Couldn't it just be `overrideDebug`? Here are everywhere else." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you want to use `@video.watchable` here. I think you want to use `@video.watchable.offering` instead.", + "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `current_user` in this case.", "reference": "`published.recently_published_first` reads a little oddly to me. Is this the same thing as `Video.published.ordered`?" }, { @@ -2975,23 +2975,23 @@ "reference": "Encountered this because I had a stray comma. Figured I'd tweak it a bit." }, { - "prediction": "I'm not sure I understand what you're trying to do here. I think you want to make sure that the `iptables-save` is empty before we try a test ping, but I'm not sure I understand what you're trying to do here. I think you want to make sure that the `iptables-save` is empty before we try a test ping, but I'm not sure I understand what you're trying to do here. I think you want to make sure that the `iptables-save` is empty before we try a test ping, but I'm not sure I understand what you're trying to do here. I think you want to make sure that the `iptables-save` is empty before we try a test ping, but I'm not sure I understand what you're trying to do here. I think you want to make sure that the `iptables-save` is empty before we try a test ping, but I'm not sure I understand what you're trying to do here. I think you want to make sure that the `iptables-save` is empty before we try a test ping, but I'm not sure I understand what you're trying to do here. I think you want to make sure that the `iptables-save` is empty before we try a test", + "prediction": "I'm not sure I understand what you're trying to do here. Can you clarify?", "reference": "qq: Should this include the iptables6-save sim. to the inverse checks above?" }, { - "prediction": "I think we can remove the `if utils.ZeroOrNil(leftField.Interface())` check.", + "prediction": "I think this should be `if leftField.Interface().(type) == reflect.ValueOf(right.Field(i).Interface())`", "reference": "im open to explicitly checking NotSet value here but json logic already handles it so kept it this way." }, { - "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `lua.h` in this case. I'm not sure if it's a good idea to use `lua.h` in this case. I'm not sure if it's a good idea to use `lua.h` in this case. I'm not sure if it's a good idea to use `lua.h` in this case. I'm not sure if it's a good idea to use `lua.h` in this case. I'm not sure if it's a good idea to use `lua.h` in this case. I'm not sure if it's a good idea to use `lua.h` in this case. I'm not sure if it's a good idea to use `lua.h` in this case. I'm not sure if it's a good idea to use `lua.h` in this case. I'm not sure if it's a good idea to use `lua.h` in this case. I'm not sure if it's a good idea to use `lua.h` in this case. I'm not sure if it's a good idea to use `lua.h` in this case. I'm not sure", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to include Lua.h in this file.", "reference": "The naming of the include file appears to be unlucky." }, { - "prediction": "I'm not sure I understand what you're trying to do with `self.legend_opts` here.", + "prediction": "I'm not sure I understand what you're trying to do here. Is it that you want to change the `legend_opts` passed to the `legend` method? If that's the case, why not just pass the `legend_opts` directly to the `legend` method?", "reference": "Bit worried about this. At minimum you should make a copy of the dict here to avoid modifying a user supplied variable." }, { - "prediction": "I think we should be able to do this in a single call to `ec2svc.CreateLaunchTemplateVersion`, right?", + "prediction": "I think we should be able to do this in a single call to `ec2svc.CreateLaunchTemplateVersion` and `ec2svc.PruneLaunchTemplateVersions` instead of two separate calls.", "reference": "Is it better to create one before pruning? In case creation fails we don't want to delete the previous one. We create a new one, it is tagged as latest, so the previous can be deleted. `CreateLaunchTemplateVersion` returns the version created, how about directly trying to delete the previous version? Assuming the numbering is strictly increasing." }, { @@ -3003,23 +3003,23 @@ "reference": "How about `exists?(['domain ~* ?', domain.downcase])` ?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure", + "prediction": "I'm not sure I understand what you're trying to do here.", "reference": "Is this getting used in other places? Can we switch all the places to use the new API you added?" }, { - "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to set the user agent as this boinc client & version.", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `curl_easy_setopt(curlEasy, CURLOPT_SSL_VERIFYPEER, 1L);` instead of `curl_easy_setopt(curlEasy, CURLOPT_SSL_VERIFYPEER, FALSE);`", "reference": "This need to be checked with linux. AFAIK, we have this file in our bin directory that is a link to the system file." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `viewContainer` class.", + "prediction": "I don't think we need to use `__plugin__` here. We can just use the `data-controller` attribute directly.", "reference": "Shouldn't we import `default`? I can't get here to test." }, { - "prediction": "I don't think this is a good idea. We should use `os.path.join` instead of `os.path.expanduser` here.", + "prediction": "I don't think this is a good idea.", "reference": "!!!!!!!!!!!!! @graingert, does this mean that tests haven't been running???" }, { - "prediction": "I don't think we need to do anything here.", + "prediction": "I think this should be `if (type != null && type.Equals(RunToolSettingValueTypeReservedKeyword)) { /* do nothing */ }` instead of `if (type.Equals(\"passThrough\")) { /* do nothing */ }`", "reference": "I've already tried the null-coalescing operator here and got a strange error, so did this the old-fashioned way." }, { @@ -3027,7 +3027,7 @@ "reference": "This doesn't follow our spacing convention. It's also a little hard to read. Can you reformat?" }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it's a good idea to have a `pipelineCfnTemplatePath` in the `deploy` package.", + "prediction": "I think it's better to use `template.CfnPipeline` instead of `cloudformation.CfnPipeline`", "reference": "The deploy should come before template? EDIT: I see that in other files, we put a separate line and put deploy at the end. What is the reason for this?" }, { @@ -3039,115 +3039,115 @@ "reference": "same question: why not just switch this to range too?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not", + "prediction": "I think this should be `if (type == Type::None)` instead of `if (type == \"unknown\")`.", "reference": "@chuckatkins most places used an empty string for \"no type\", but a few used `\"unknown\"`. I've converted both cases to `Type::None`. Do you know why there was a distinction before?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to copy the data to the GPU in the first place, and then copy it back to the CPU in the second place. This way, we don't need to copy the data back and forth between the CPU and the GPU.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `copyDenseFeature` function.", "reference": "should we assert for the type for `FeatureGroupData` ? I think it should be 1-Byte type." }, { - "prediction": "I think we can remove the `flat=False` argument from the `dimension_values` test.", + "prediction": "I think this should be `self.assertEqual(cube.dimension_values('unknown', flat=False), np.flipud(np.array([[ 0, 4, 8], [ 1, 5, 9], [ 2, 6, 10], [ 3, 7, 11]], dtype=np.int32).T))`", "reference": "As long as you are sure this is definitely correct now... :-)" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `onCreateView` method, so that we don't have to do this in the `onCreate` method.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.", "reference": "... so that all action buttons have the same height :-)" }, { - "prediction": "I think we can remove the `#include ` and `#include `. The `DataWriter` and `DataWriterListener` are defined in `fastdds/dds/publisher/DataWriter.hpp` and `fastdds/dds/publisher/DataWriterListener.hpp`.", + "prediction": "I think we should remove the `#include ` and `#include ` from the `fastdds/dds/publisher/DataWriter.hpp` and `fastdds/dds/publisher/DataWriterListener.hpp` files.", "reference": "Use correct, alpha sorted, include order. Correct order means: 1. Header corresponding to this source (i.e. `\"LatencyTestPublisher.hpp\"`) 2. C system headers 3. C++ system headers 4. Alpha-sorted external libraries headers 5. Alpha-sorted public headers from this project 6. Alpha-sorted private headers" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a `RequestFactory` function that takes a `transport.Request` and returns a `*http.Request`, but I'm not sure what you're trying to do with the `*http.Request` returned by that function.", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a `RequestFactory` function that takes a `transport.Request` and returns a `*http.Request` and an error. I'm not sure what you're trying to do here, but it looks like you're trying to create a `RequestFactory` function that takes a `transport.Request` and returns a `*http.Request` and an error. I'm not sure what you're trying to do here, but it looks like you're trying to create a `RequestFactory` function that takes a `transport.Request` and returns a `*http.Request` and an error. I'm not sure what you're trying to do here, but it looks like you're trying to create a `RequestFactory` function that takes a `transport.Request` and returns a `*http.Request` and an error. I'm not sure what you're trying to do here, but it looks like you're trying to create a `RequestFactory` function that takes a `transport.Request` and returns a `*http.Request` and an error. I'm not sure what you're trying to do here, but it looks like you're trying to create a `RequestFactory`", "reference": "I hate this name, open to suggestions." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would make sense to do this in the same place as `retrieveTargetMetadataFromCache`.", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to store the results in the cache, but then you're trying to retrieve them from the cache. Is that right?", "reference": "Does this log line work? We need Warningf or just warning without the format string." }, { - "prediction": "I'm not sure what you mean by \"processors\" in this context. I think you meant to say \"metrics processors\" or \"metrics processors\".", + "prediction": "I'm not sure what you mean by `exporter` and `metricsProcessors` in this context. Could you please clarify?", "reference": "The pull controller would need similar updates." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a comment here explaining why this change was made.", + "prediction": "I don't think this is a good idea. It's not clear to me what the problem is here.", "reference": "ignore this.. just didn't want to litter with a commit update to satisfy license plugin" }, { - "prediction": "I'm not sure what you're trying to do here, but I think it's better to use `on host, \"curl -o #{dest} #{link}\"` instead of `on host, \"curl -O #{dest} #{link}\"`", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `on` block.", "reference": "Is this definition needed since it doesn't look like it's being used anywhere?" }, { - "prediction": "I think this should be `default_proc = lambda { self.class.name }` instead of `default_proc = lambda { self.discriminator_key }`", + "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bad idea to have `discriminator_key` in the `Mongoid` module. It's not a good idea to have a `discriminator_key` in the `Mongoid` module, and it's not a good idea to have a `discriminator_key` in the `Mongoid` module, and it's not a good idea to have a `discriminator_key` in the `Mongoid` module, and it's not a good idea to have a `discriminator_key` in the `Mongoid` module, and it's not a good idea to have a `discriminator_key` in the `Mongoid` module, and it's not a good idea to have a `discriminator_key` in the `Mongoid` module, and it's not a good idea to have a `discriminator_key` in the `Mongoid` module, and it's not a good idea to have a `discriminator_key` in the `Mongoid` module, and it's not a good idea to have a `discriminator_key` in the `Mongoid` module, and it's not", "reference": "Can this condition be reworded using `if` please?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `setupEdgeKeysFromRef` function, since it's called by the `setupEdgeKeysFromRef` function.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do it in the `setupEdgeKeysFromRef` function.", "reference": "after ||, no need inputs != nullptr" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a `PipelineStage` struct with a `LocalApplications` field, but I'm not sure what you're trying to do with it. I think you're trying to create a `PipelineStage` struct with a `LocalApplications` field, but I'm not sure what you're trying to do with it. I think you're trying to create a `PipelineStage` struct with a `LocalApplications` field, but I'm not sure what you're trying to do with it. I think you're trying to create a `PipelineStage` struct with a `LocalApplications` field, but I'm not sure what you're trying to do with it. I think you're trying to create a `PipelineStage` struct with a `LocalApplications` field, but I'm not sure what you're trying to do with it. I think you're trying to create a `PipelineStage` struct with a `LocalApplications` field, but I'm not sure what you're trying to do with it. I think you're trying to create a `PipelineStage` struct with a `LocalApplications` field, but I'm not sure what you're trying to do with it", + "prediction": "I'm not sure if this is the right place to put this, but I think it would make sense to put it in the `PipelineStage` struct.", "reference": "Is it just preference or on purpose that using slice of structs instead of slice of pointers?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `diff` function.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `updateChildren` function.", "reference": "This line always confused me anyway. Good catch!" }, { - "prediction": "I'm not sure what you mean by \"shutdown\" in this context. I think you meant to say \"shutdown\" in this context.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `Shutdown` method.", "reference": "Should we add `ctx` to `BlockServer.Shutdown()` for this purpose? Would be nice, but I don't care too much." }, { - "prediction": "I'm not sure what you mean by \"this->length\" and \"this->nanosec\"", + "prediction": "I think it's better to use `CDRMessage::addInt32` instead of `CDRMessage::addUInt32`", "reference": "Duration_t at RTPS level must be serialized using fractions." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `yarpcerrors` package, since it's used in the `NotRunningInboundError` function. Is this the right place to put it?", + "prediction": "I'm not sure if this should be in the same file as the `NotRunningInboundError` function, or if it should be in a separate file. I think it makes more sense to have it in the same file as the `NotRunningInboundError` function, but I'm not sure if that's a good idea.", "reference": "\"peer\" has its own meaning within YARPC with its own class of objects. This should probably be \"dispatcher\" too?" }, { - "prediction": "I think we should remove the `-analyzer-config` from the `analyzer_cmd` list.", + "prediction": "I think it's better to use `-Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -analyzer-config -Xclang -", "reference": "I do not like this line break before `=true`. Maybe starting the list in the next line would help to reduce the indent? This way we could keep this string together." }, { - "prediction": "I don't think it's necessary to use `sync.Once` here. We can just use `sync.Mutex` instead.", + "prediction": "I don't think it's necessary to use `sync.Once` here. We can just use `sync.Mutex` here.", "reference": "_plugins should be removed too" }, { - "prediction": "I think this should be `node.hasAttribute('alt')` instead of `node.hasAttribute('alt') && (nn === 'img' || nn === 'input' || nn === 'area')`", + "prediction": "I think this should be `node.hasAttribute('alt') && (nn === 'img' || nn === 'input' || nn === 'area' || node.getAttribute('alt') === '')`", "reference": "The rule selector will not include `` and `` elements. Why not make this a new, separate rule altogether?" }, { - "prediction": "I think this should be `userscripts.run_async(tab, cmd, *args, win_id=self._win_id, env=env, verbose=verbose)`", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `command-dispatcher` module, since that's where `userscripts.run_async` is defined.", "reference": "@The-Compiler Is this style okay or would you prefer a common userscript exception base?" }, { - "prediction": "I think this should be `null === value` instead of `null !== value`.", + "prediction": "I think this should be `sub_type` instead of `sub_type || 0x00`", "reference": "we'd need to return a MongooseBuffer here instead of the Binary. lets add the subtype option to the buffer schema type as referenced in #1000 instead." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the `selector` is a valid JavaScript object.", "reference": "Let's remove this change." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to say that if the state is \"not selected\" and the reason is \"change\" or \"focus\", then the state should be \"not checked\" and the reason should be \"not selected\". Is that what you're trying to do here? If so, I'm not sure what you're trying to do here. I think you're trying to say that if the state is \"not selected\" and the reason is \"change\" or \"focus\", then the state should be \"not checked\" and the reason should be \"not selected\". Is that what you're trying to do here? If so, I'm not sure what you're trying to do here. I think you're trying to say that if the state is \"not selected\" and the reason is \"change\" or \"focus\", then the state should be \"not checked\" and the reason should be \"not selected\". Is that what you're trying to do here? If so, I'm not sure what you're trying to do here. I think you're trying to say that if the state is \"not selected\" and the reason is \"change\" or \"focus\", then the state should be \"not", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to remove the \"not checked\" state from the list of states that can be selected, but I'm not sure what you're trying to do with the `STATE_HALFCHECKED` state. I think you're trying to remove the \"not checked\" state from the list of states that can be selected, but I'm not sure what you're trying to do with the `STATE_HALFCHECKED` state. I think you're trying to remove the \"not checked\" state from the list of states that can be selected, but I'm not sure what you're trying to do with the `STATE_HALFCHECKED` state. I think you're trying to remove the \"not checked\" state from the list of states that can be selected, but I'm not sure what you're trying to do with the `STATE_HALFCHECKED` state. I think you're trying to remove the \"not checked\" state from the list of states that can be selected, but I'm not sure what you're trying to do with the `STATE_HALFCHECKED` state. I think you're trying to remove the \"not checked\" state from the list of", "reference": "Could you split this into multiple lines?" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to use the `useSelect` hook from `googlesitekit-data` to get the URL of the current entity. However, the `useSelect` hook doesn't seem to be available in the current version of `googlesitekit-data`. I'm not sure what you're trying to do here, but it looks like you're trying to use the `useSelect` hook from `googlesitekit-data` to get the URL of the current entity. However, the `useSelect` hook doesn't seem to be available in the current version of `googlesitekit-data`. I'm not sure what you're trying to do here, but it looks like you're trying to use the `useSelect` hook from `googlesitekit-data` to get the URL of the current entity. However, the `useSelect` hook doesn't seem to be available in the current version of `googlesitekit-data`. I'm not sure what you're trying to do here, but it looks like you're trying to use the `useSelect` hook from `googlesitekit-data` to get the URL of the current entity.", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to use the `useSelect` hook from `googlesitekit-data` to get the URL of the current entity. However, the `useSelect` hook is only available in the `googlesitekit/datastore/site` module, not in the `googlesitekit/datastore/site/constants` module. This means that you can't use `useSelect` to get the URL of the current entity in the `googlesitekit/datastore/site/constants` module.", "reference": "This technically works, however it may be safer to use both `getCurrentReferenceURL` and `getCurrentEntityURL` and then make this condition `currentReferenceURL === currentEntityURL`. Currently, this code only works based on the internals of `getCurrentReferenceURL`, so by checking both we would decouple that." }, { - "prediction": "I don't think we need to use `fmt.Sprintf` here. We can just use `respMsg` directly.", + "prediction": "I don't think we need to use `fmt.Sprintf` here. We can just use `resp.StatusCode` and `string(body)` directly.", "reference": "It does not recommend capitalization" }, { - "prediction": "I'm not sure what you're trying to achieve with this scenario, but I'm not sure if it's a good idea to use `sign_in_as_subscriber` here.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a test for this.", "reference": "Minor thing, but can you use 1.9 hash syntax for this?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `lambda_cwd_on_host` variable in the `LambdaExecutorReuseContainers` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a `lambda_cwd_on_host` variable in the `LambdaExecutorReuseContainers` class.", "reference": "I tried to follow the code structure already present." }, { @@ -3155,31 +3155,31 @@ "reference": "seems reasonable to also want to include the 'to' location?" }, { - "prediction": "I think this should be `type('obj', (object,), {'installDir' : os.environ['NUPIC']})` instead of `type('obj', (object,), {'installDir' : resource_filename(\"nupic\",\"\")})`", + "prediction": "I think this should be `type('obj', (object,), {'installDir' : os.environ['NUPIC']})`", "reference": "Please leave 1 space char between commas here and other places in this PR." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you mean by `PTHREAD_CREATE_DETACHED`. I think it's just `PTHREAD_CREATE_JOINABLE`.", "reference": "hm is this really &&? Not ||? Was it initially correct if any of these things are not set that it needs to recreated?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to do this with a single line of code. I think we should be able to do this with a single line of code. I think we should be able to do this with a single line of code. I think we should be able to do this with a single line of code. I think we should be able to do this with a single line of code. I think we should be able to do this with a single line of code. I think we should be able to do this with a single line of code. I think we should be able to do this with a single line of code. I think we should be able to do this with a single line of code. I think we should be able to do this with a single line of code. I think we should be able to do this with a single line of code. I think we should be able to do this with a single line of code. I think we should be able to do this with a single line of code. I think we should be able to do this with a single line of code. I think we should be able to do this with a single line of code. I", + "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to do this in a single line.", "reference": "Please don't use C-style array declarations. IMO our pre-commit ought to be enhanced to not allow this" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a `pmix_compressed_string_cmp` function that does the same thing as `pmix_string_cmp` but for compressed strings.", + "prediction": "I think this should be `if (p->data.bo.size != p1->data.bo.size)` instead of `if (p->data.bo.size != p1->data.bo.size)`", "reference": "@rhc54 This doesn't look like a comprehensive comparison. For `PMIX_STRING` we seem to actually compare the content of the data while here we only compare meta-information which doesn't ensure that values are the same." }, { - "prediction": "I'm not sure what you mean by \"confirmed frontiers\" in this context. Could you please clarify?", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `confirmed_frontiers` in `bootstrap` as well.", "reference": "I think `bypass_frontier_confirmation` conveys the intention better (default false as well)" }, { - "prediction": "I'm not sure what you're trying to achieve with this test, but I think it's a bit of a red herring. I think you're trying to test that the `Address` struct has a `hash` field, but that's not the case here. I think you're trying to test that the `Address` struct has a `hash` field, but that's not the case here. I think you're trying to test that the `Address` struct has a `hash` field, but that's not the case here. I think you're trying to test that the `Address` struct has a `hash` field, but that's not the case here. I think you're trying to test that the `Address` struct has a `hash` field, but that's not the case here. I think you're trying to test that the `Address` struct has a `hash` field, but that's not the case here. I think you're trying to test that the `Address` struct has a `hash` field, but that's not the case here. I think you're trying to test that the `Address` struct has a `hash` field, but that's not the case here. I think you're trying", + "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to have a separate test for this.", "reference": "This looks like it goes beyond the scope of removing `BlockHeight()`, in the future please do this in a separate commit at a minimum -- separate PR is fine too." }, { - "prediction": "I'm not sure what you mean by `self._tab` here. Is it a reference to `self`? Or is it a reference to `self._tab`?", + "prediction": "I don't think this is necessary. `self._tab` is a reference to the tab, so it's not necessary to create a new instance of `AbstractAudio` for each tab.", "reference": "You'll also need to adjust `FakeWebTabAudio` in `tests/helpers/stubs.py`." }, { @@ -3187,7 +3187,7 @@ "reference": "@csrwng what should we do here? This one is from origin." }, { - "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to include `LocaleContext.h` in this file.", + "prediction": "I don't think we need to include `LocaleContext.h` in this file.", "reference": "Follow alphabetical order." }, { @@ -3203,7 +3203,7 @@ "reference": "Where would this be configured? In azkaban.properties?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check for `update` before calling `checkForAtomicOperators`, so that we don't have to check for `update` every time.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check for `update` before calling `checkForAtomicOperators`, so that we don't have to check for `update` every time we call `checkForAtomicOperators`.", "reference": "1. Use `const` instead of `var` here. 2. Move the check to after the `if (update == null || typeof update !== 'object')`." }, { @@ -3223,11 +3223,11 @@ "reference": "Does upsert pass this check also?" }, { - "prediction": "I'm not sure what you're trying to do here, but I'm not sure if this is the right way to do it. It's not clear what you're trying to do here, but I'm not sure if this is the right way to do it. It's not clear what you're trying to do here, but I'm not sure if this is the right way to do it. It's not clear what you're trying to do here, but I'm not sure if this is the right way to do it. It's not clear what you're trying to do here, but I'm not sure if this is the right way to do it. It's not clear what you're trying to do here, but I'm not sure if this is the right way to do it. It's not clear what you're trying to do here, but I'm not sure if this is the right way to do it. It's not clear what you're trying to do here, but I'm not sure if this is the right way to do it. It's not clear what you're trying to do here, but I'm not sure if this is the right way to do it. It's not clear what you're trying to do here, but", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `ioStreams.ErrOut.(*bytes.Buffer).String()` instead of `ioStreams.ErrOut.(*bytes.Buffer).String()`. This is because `ioStreams.ErrOut.(*bytes.Buffer).String()` will return a `string`, but `ioStreams.ErrOut.(*bytes.Buffer).String()` will return a `*bytes.Buffer`.", "reference": "Apologies reviewers, I did end up pushing another change. I was starting to request SRE-P help to get the apiserver configs from some clusters before and after when I realized I can just log the stdout from the patch command to see if anything was changed or not. Much simpler to verify if my work did or did not make changes to the config during the transition. Also got the spacing issue you mentioned @abhinavdahiya Thanks all." }, { - "prediction": "I'm not sure what you mean by `kbfsDeletedReposDir = \".kbfs_deleted_repos\"`. Is this intended to be used in the future?", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a `kbfs_deleted_repos_dir` in the root of the repo. This way, we can keep track of deleted repos in the root of the repo, rather than in the `kbfs_deleted_repos` directory in the `kbfs_repo` directory.", "reference": "I'm not sure this naming is a good idea; that's the format for macOS xattr metadata files on unsupported filesystems." }, { @@ -3235,15 +3235,15 @@ "reference": "Metrics/LineLength: Line is too long. [85/80]" }, { - "prediction": "I'm not sure if this is a good place to put this, but I think we should move it to the `org.apache.iceberg.relocated.com.google.common.collect.Lists` package, since it's not part of the `org.apache.iceberg` package.", + "prediction": "I'm not sure if this is a good place to put this, but I think we should move it to the `org.apache.iceberg.relocated.com.google.common.collect.Lists` package, since it's not in the `org.apache.iceberg` package.", "reference": "Please remove these imports. The project's style is to use `Assert.assertEquals` and not import static methods in general. This also caused a lot of unnecessary changes." }, { - "prediction": "I'm not sure what you mean by \"proxy host\". Could you please clarify?", + "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to add a check here to make sure the proxy is not null.", "reference": "thanks. Note that returning at this point might leak memory from the allocations above, so the PR will need to take care of that too." }, { - "prediction": "I think this should be `self.setWindowState(self.window_state_before_fullscreen)` instead of `self.setWindowState(self.state_before_fullscreen)`.", + "prediction": "I think this should be `if config.val.content.desktop_fullscreen` instead of `if self.config_state_before_fullscreen`.", "reference": "If you really want to rename this, you'll also need to adjust the name in `__init__` and in other places it's used (`browser/commands.py`)." }, { @@ -3251,15 +3251,15 @@ "reference": "As discussed at standup, I gave up on this. Calling `DeleteMapLayerMetadataCommand` felt cleaner anyway because there might be other cleanup that needs to happen. @scolapasta and @matthew-a-dunlap plan to discuss this." }, { - "prediction": "I'm not sure what you mean by \"unexpected difference between actions\" here. Is it possible that `objExp.GetObject()` and `objAct.GetObject()` are not the same?", + "prediction": "I'm not sure what you mean by \"unexpected difference between actions: %s\", could you please provide more context?", "reference": "Do we need these changes? If so, can you tidy up the messages? Looks like it might have been your testing/debugging changes" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a good idea to have a `SecretTargetLogDriver` field in the `DockerConfig` struct.", + "prediction": "I don't think we need to change the default value of `SecretTargetLogDriver` to `CONTAINER`.", "reference": "where is the default being set?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that `vStringNCopyS` is called before `initTagEntry`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the `vStringNCopyS` function is called before the `initTagEntry` function.", "reference": "these changes should likely be in the next commit instead" }, { @@ -3267,43 +3267,43 @@ "reference": "Since you have defined this struct, I would suggest to replace all exist literal structs by this." }, { - "prediction": "I don't think this is necessary.", + "prediction": "I don't think this is needed anymore.", "reference": "The field name doesn't really capture what this option does. I think `mConfirmDiscardMessage` would be a better choice." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to make sure that the binary content is a string.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check here to make sure the file is a valid file before trying to convert it to a File.", "reference": "what if `$media->getBinaryContent() == Symfony\\Component\\HttpFoundation\\File\\File` does `is_string()` return `true`? ping @greg0ire" }, { - "prediction": "I think it's better to use `MakeCamel` instead of `WrapInNameSpace` here.", + "prediction": "I think this should be `MakeCamel(field.name, lang_.first_camel_upper)` instead of `MakeCamel(field.name, lang_.first_camel_upper) + \"As\" + nested_type_name`", "reference": "maybe rather than `bool` make this field a `StructDef *` ?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason why you'd want to do this?", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to do something like `enqueueBlocksToDeleteAfterShortDelay(toDelete blocksToDelete) { fbm.blocksToDeleteChan <- toDelete; }` but I'm not sure what you're trying to do with `blocksToDeleteWaitGroup.Add(1)` and `time.AfterFunc(10*time.Millisecond, ...).Add(1)`.", "reference": "Shall we maybe put this in a `const` like `backgroundTaskTimeout`?" }, { - "prediction": "I'm not sure what you're trying to do here, but I'm not sure if this is the right way to handle this.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check here to see if the listener was stopped. If it was, we can just ignore the exception.", "reference": "CI is complaining about this." }, { - "prediction": "I'm not sure what you're trying to achieve with this method, but it looks like you're trying to determine the removal time for a process instance based on its history time to live. I'm not sure what you're trying to achieve with this method, but it looks like you're trying to determine the removal time for a process instance based on its history time to live. I'm not sure what you're trying to achieve with this method, but it looks like you're trying to determine the removal time for a process instance based on its history time to live. I'm not sure what you're trying to achieve with this method, but it looks like you're trying to determine the removal time for a process instance based on its history time to live. I'm not sure what you're trying to achieve with this method, but it looks like you're trying to determine the removal time for a process instance based on its history time to live. I'm not sure what you're trying to achieve with this method, but it looks like you're trying to determine the removal time for a process instance based on its history time to live. I'm not sure what you're trying to achieve with this method, but it looks like you're trying to determine the removal time for a", + "prediction": "I don't think this is a good idea. We should be able to determine the time to live from the process definition.", "reference": "Let's only change a file if it is really necessary. Such a change does not bring much value and makes it harder to find the original commit in which the method was introduced." }, { - "prediction": "I don't think it's necessary to add `class` attribute to `image.html.twig` if it's already defined in the `image.html.twig` file.", + "prediction": "I don't think we need to use `sprintf` here. We can just use `str_replace` here.", "reference": "I would prefer to set up space between classes in format pattern, `%s %s` and then use `trim()` to remove unnecessary whitespaces. This will also solve stripping whitespaces from the beginning and end of a string `$attributes['class']`" }, { - "prediction": "I don't think this is a good idea. We should always check if the graph space is available before trying to use it.", + "prediction": "I don't think we need to check if the graph space is chosen or not. If the graph space is not chosen, we should not execute the job.", "reference": "when Op is illegal should return here?" }, { - "prediction": "I think this should be `if (installedVersions.containsKey(versionKey))` instead of `if (installedVersions.remove(versionKey))`.", + "prediction": "I think it's better to remove the `installedVersions.remove(versionKey);` line.", "reference": "don't we need to remove the project version from installedVersions?" }, { - "prediction": "I'm not sure what you're trying to do with `@bridge.send_command(cmd: cmd, params: params)`, but I don't think that's the right way to do it. You should be using `bridge.send_command(cmd: cmd, params: params)` instead.", + "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don", "reference": "the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here." }, { @@ -3311,7 +3311,7 @@ "reference": "This is intended. Pls revert this." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a `RedBlackTree` from an `Iterable` of `T` objects. I'm not sure what you're trying to do here, but it looks like you're trying to create a `RedBlackTree` from an `Iterable` of `T` objects. I'm not sure what you're trying to do here, but it looks like you're trying to create a `RedBlackTree` from an `Iterable` of `T` objects. I'm not sure what you're trying to do here, but it looks like you're trying to create a `RedBlackTree` from an `Iterable` of `T` objects. I'm not sure what you're trying to do here, but it looks like you're trying to create a `RedBlackTree` from an `Iterable` of `T` objects. I'm not sure what you're trying to do here, but it looks like you're trying to create a `RedBlackTree` from an `Iterable` of `T` objects. I'm not sure what you're trying to do here, but it looks like you're trying to create a `RedBlackTree` from", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to remove the `@SuppressWarnings(\"unchecked\")` from this method.", "reference": "Something wrong with cast to `(Comparator<> & Serializable)`, need to be investigated" }, { @@ -3319,27 +3319,27 @@ "reference": "I think we need this. Not sure, I'll test." }, { - "prediction": "I think this should be `disable_iptables` instead of `disable_se_linux`?", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `beaker.rb` file as well.", "reference": "I'm going to need to check if google compute requires these steps in this order, or if you can disable iptables after the fact." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I think we should remove the `+build !no_stage` line. It's not clear what you're trying to achieve with this.", + "prediction": "I'm not sure if this is the right place for this change, but I think we should move it to the `charts` package. I think it's a good idea to move it to the `charts` package so that it can be used by other packages as well. This way, we don't have to worry about moving it to the `charts` package.", "reference": "Did go change their tags with the new version?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to create a new bundle manager that uses a trust domain config map and a data store trust domain config source, but I'm not sure how you're going to get the trust domain config map and the data store trust domain config source to work together.", + "prediction": "I think we should use `s.config.Federation.FederatesWith` instead of `s.config.Federation.Federates`.", "reference": "I don't recall what we decided here in terms of which source would get priority. As written, the static configuration will overwrite datastore results." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `checkAndReplaceSequence` function.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that we don't have multiple outputs for the same label.", "reference": "I think it should still panic for when there are no outputs; might be nice to special-case that though so the message is more explicit." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a `MetricRegistry.MetricSupplier counterSupplier;` but then you're not using it anywhere.", + "prediction": "I don't think this is needed anymore.", "reference": "*NULL_DEREFERENCE:* object `null` is dereferenced by call to `meterSupplier(...)` at line 122." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `finalCmd.$readPreference` section.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `readPreference` object.", "reference": "switch over to .mode" }, { @@ -3351,67 +3351,67 @@ "reference": "This is an unused import failing recommit still." }, { - "prediction": "I think this should be moved to the end of the script.", + "prediction": "I think this should be moved to the end of the block, since it's the only place where `host` is used.", "reference": "I'm concerned that we're conflating multiple things here. There are 2 things that Beaker should really care about: - Network transport - i.e. `ssh` vs `winrm` - Interpreter - i.e. `bash`, `cmd`, `powershell`, etc The problem is that @cowofevil is running Bitvise SSH, and he assumed we should be setting `is_cygwin: false` in node definitions. But that doesn't really accurately convey what we care about, and since Beaker doesn't appear to track network transport apart from interpreter, we end up in a strange state. `is_cygwin: false` appears to end up setting `is_powershell?` to `true`, which IMHO is not accurate or appropriate. Bitvise templates use `ssh` (like Cygwin), but the interpreter used is `cmd`, not `powershell`." }, { - "prediction": "I'm not sure what you mean by \"missing fields\" in this context. It's not clear to me what you're trying to do here.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `role=\"dialog\"` instead of the `aria-label` attribute.", "reference": "I think this is ok for now. This ties into the larger issue of the site not having a consistent method for relaying form input errors. Please make sure the focus gets set on the close button when the dialog opens." }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a `samplingRatio` option to the `AutoColumnSize` plugin.", "reference": "Should these link be removed?" }, { - "prediction": "I don't think we need to add `add_undo=True` to the close_tab method.", + "prediction": "I don't think we need to add `add_undo=True` here.", "reference": "Please make this a keyword-only argument by adding a `*` argument before `add_undo`." }, { - "prediction": "I think we should remove the `{{- end }}` from the `eventMsgs` list.", + "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to create a new `eventstream.Message` object, but you're not actually using it anywhere in the code.", "reference": "didn't quite follow what this code block is doing." }, { - "prediction": "I don't think this is a good idea.", + "prediction": "I think this should be `if (!currentVisibleMenu && 32 === e.keyCode)` instead of `if (!currentVisibleMenu && 32 === e.keyCode) { return void showOsd(); }`", "reference": "this doesn't sound pretty... I would rather we have a proper navigation for all modes - AFAIK TV remote navigation is very similar to normal keyboard, but maybe it just uses another key codes - those should be extracted in a single file and defined there depending on context then" }, { - "prediction": "I think this should be `if ('value' in newProps && dom._isControlled)` instead of `if ('value' in newProps && dom._isControlled)`.", + "prediction": "I think it's better to use `oldProps.checked` and `newProps.checked` instead of `oldProps.value` and `newProps.value`.", "reference": "After diffing the children we check whether the value got out of sync, if it did we update it. We also update the `_prevValue` to prepare for the next event hitting our controlled component" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to create a node that can be started from the command line, but I'm not sure if that's the best way to do it.", + "prediction": "I'm not sure what you mean by \"use of this source code is governed by a BSD-style license that can be found in the LICENSE file.\"", "reference": "It provides a type called Node which is a fully functional bee client. This package is where the dependencies are injected. It is not just a glue-code, it is concept of node." }, { - "prediction": "I'm not sure what you're trying to achieve with this signal. It's not clear to me what it's used for. It's not clear to me what you're trying to achieve with this signal. It's not clear to me what you're trying to achieve with this signal. It's not clear to me what you're trying to achieve with this signal. It's not clear to me what you're trying to achieve with this signal. It's not clear to me what you're trying to achieve with this signal. It's not clear to me what you're trying to achieve with this signal. It's not clear to me what you're trying to achieve with this signal. It's not clear to me what you're trying to achieve with this signal. It's not clear to me what you're trying to achieve with this signal. It's not clear to me what you're trying to achieve with this signal. It's not clear to me what you're trying to achieve with this signal. It's not clear to me what you're trying to achieve with this signal. It's not clear to me what you're trying to achieve with this signal. It's not clear to me what you're trying to achieve with this signal. It's not clear to me", + "prediction": "I'm not sure what you mean by \"no-3rdparty\"", "reference": "I think this will change `''` to `'%'` unconditionally, i.e. there'll be no way to set `''` anymore. This should really only be used for values which make no sense anymore." }, { - "prediction": "I think this is a bad idea. We don't want to expose the row key to the outside world. We want to expose the row key to the outside world so that we can use it in other parts of the system. If we expose the row key to the outside world, then we can't use it in other parts of the system. We can't use it in other parts of the system because we don't want to expose the row key to the outside world. We can't use it in other parts of the system because we don't want to expose the row key to the outside world. We can't use it in other parts of the system because we don't want to expose the row key to the outside world. We can't use it in other parts of the system because we don't want to expose the row key to the outside world. We can't use it in other parts of the system because we don't want to expose the row key to the outside world. We can't use it in other parts of the system because we don't want to expose the row key to the outside world. We can't use it in other parts of the system because we don't want to expose the row key to the outside world. We can't use", + "prediction": "I don't think this is needed anymore.", "reference": "Nit: this table's row key map -> this table's row keys map" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a default value for `pj_ctx::debug_level` and `pj_ctx::logger`. This way, if you don't want to use `pj_stderr_logger`, you can just set `pj_ctx::debug_level` to `PJ_LOG_NONE` and `pj_ctx::logger` to `pj_stderr_logger`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have this in `pj_context.h` instead of `pj_ctx.h`.", "reference": "this change should be reverted" }, { - "prediction": "I think this should be `appdata_path = os.path.join(os.path.dirname(basedir), \"misc\", \"qutebrowser.appdata.xml\")`", + "prediction": "I'm not sure if this is the right place to put this, but I think it should go in the `misc` directory.", "reference": "I'm a bit confused about the `os.path.dirname(basedir)` here - is this just to get to the parent directory? Either way, I think I'd prefer just having this in `update_version.py` as it's not needed in qutebrowser itself." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `errors.New` here.", + "prediction": "I'm not sure why this test is failing, but I'm not sure how to fix it.", "reference": "Revert this change and see below why..." }, { - "prediction": "I don't think this is a good idea. It's not clear to me what the point of this is.", + "prediction": "I don't think we need to add the `lvis_v1_instance.py` to the `base_` list.", "reference": "Should not switch to `lvis_v1_instance` here because that base config uses ClassBalancedDataset to oversample the data." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure I understand what you're trying to do here.", "reference": "This is an informational message that allows someone to read the console output and understand how the grid node is configured. Please leave." }, { - "prediction": "I think this should be `error` instead of `nil`.", + "prediction": "I'm not sure what you mean by \"raise a singleton alert\". Is it possible to raise a single instance of an alert? If so, how would you do that?", "reference": "This doesn't make sense to me. What does RaiseSingleton mean? To me it sounds like a single object is being.. raised? Not sure." }, { @@ -3419,15 +3419,15 @@ "reference": "What's the benefit of having jobExecutorTests as a member variable? What do you think about making the method static? Afterall, it is a stateless method." }, { - "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to add a `check` subcommand to the `dump` command, but I'm not sure what you're trying to achieve with it.", + "prediction": "I don't think this is a good idea. The `check` subcommand doesn't need to be a subcommand of the `dump` subcommand. The `check` subcommand should be a subcommand of the `dump` subcommand, and the `dump` subcommand should be a subcommand of the `check` subcommand. The `check` subcommand should be a subcommand of the `dump` subcommand, and the `dump` subcommand should be a subcommand of the `check` subcommand. The `check` subcommand should be a subcommand of the `dump` subcommand, and the `dump` subcommand should be a subcommand of the `check` subcommand. The `check` subcommand should be a subcommand of the `dump` subcommand, and the `dump` subcommand should be a subcommand of the `check` subcommand. The `check` subcommand should be a subcommand of the `dump` subcommand, and the `dump` subcommand should be a subcommand of the `check` subcommand. The `check` subcommand should be a subcommand of the `dump` subcommand, and the `dump` subcommand should be a", "reference": "This looks like it's only downloading things, not really checking their true validity. Especially for the MD object. Should we call `BareRootMetadata.IsValidAndSigned()` in `mdGet`?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `setup` function.", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be good to have this in a separate file.", "reference": "Nikoli, I believe that this addresses your concern. One question for you or Jae-Seung is if any allocation from the clone is properly cleaned up when the vector is destroyed. I believe that it should." }, { - "prediction": "I think we can remove `KindSealedSecret` as it's not used anywhere.", + "prediction": "I think we can remove `KindEcsApp` and `KindSealedSecret` as they are not used anywhere.", "reference": "should be `ECSApp`" }, { @@ -3435,35 +3435,35 @@ "reference": "flake8 is going to fail on this having 2 lines" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to create a new type of error, but I'm not sure if that's what you're trying to achieve. If you're trying to create a new type of error, I'd suggest creating a new type of error and using it in your code. If you're trying to create a new type of error, I'd suggest creating a new type of error and using it in your code. If you're trying to create a new type of error, I'd suggest creating a new type of error and using it in your code. If you're trying to create a new type of error, I'd suggest creating a new type of error and using it in your code. If you're trying to create a new type of error, I'd suggest creating a new type of error and using it in your code. If you're trying to create a new type of error, I'd suggest creating a new type of error and using it in your code. If you're trying to create a new type of error, I'd suggest creating a new type of error and using it in your code. If you're trying to", + "prediction": "`errors.New` should be `errors.Errorf`", "reference": "should we make a dir named controllers/scheduler/podchaos" }, { - "prediction": "I'm not sure what you mean by \"based on the hostname\". Could you please provide more context?", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `provisioner.go` file. It seems like this is the only place where the `KeyNode` and `KeyNodeHostname` are used.", "reference": "there seems to be one KeyNode in kubernetes.go of PV.. would it make sense to use it?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it would be better to use the `clio` context.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it would be better to just use the `clio` context.", "reference": "Im gonna be a little annoying here but did you configure your linter correctly? This empty line should not be here. Maybe go to settings and check if `goimports` is enabled?" }, { - "prediction": "I don't think this is a good idea. I think it's better to have a separate plugin for each type of chat.", + "prediction": "I think it's better to use `case` instead of `case FRIENDSCHAT` and `case PRIVATECHATOUT`.", "reference": "Don't think this belongs in this pr" }, { - "prediction": "I'm not sure what you mean by \"directly passed into encoding-specific RPC clients\". Is it something like `encoding/json` or `encoding/xml`?", + "prediction": "I'm not sure what you mean by \"directly passed into encoding-specific RPC clients\". I think you meant to say that the configuration is passed to the client directly.", "reference": "We can assert on the existence of Outbounds through ClientConfig calls right? Since this is only for tests, do we need this function?" }, { - "prediction": "I think it's better to keep the syntax in the `IMvxViewModelResult` interface.", + "prediction": "I think we can remove the `IMvxViewModelResult` interface. It's not needed anymore.", "reference": "@martijn00 so this PR introduces a new ViewModel lifecyle method? It isn't in the PR description/any new docs" }, { - "prediction": "I'm not sure what you mean by \"batched image size information may be useful\"", + "prediction": "I think we can remove the `input_img_shape` from the `forward_train` function.", "reference": "Are these modification duplicate? Or should we move it into base detector." }, { - "prediction": "I think this should be `if (Long.compareUnsigned(block, EPOCH_LENGTH) >= 0)` instead of `if (Long.compareUnsigned(block, EPOCH_LENGTH) >= 0)`", + "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `MessageDigest` here. You can just use `MessageDigest.getInstance(\"SHA-256\")`.", "reference": "Since this is private and single use it should be un-wrapped inside of the two-arg dagSeed method." }, { @@ -3471,31 +3471,31 @@ "reference": "why the order change? Also for the next chunk. (I understand the result will be the same though)" }, { - "prediction": "I'm not sure what you mean by \"internal targets that can only be called using keyword arguments\"", + "prediction": "I'm not sure what you're trying to say here. I think you're trying to say that the `Returns` field is optional, and that the `IsPrivate` field is optional as well. Is that correct?", "reference": "I wonder if this should just be a single `string`? We don't have any cases where we return different types and it would make the parser simpler to just read a single identifier." }, { - "prediction": "I think this should be `getInputFile(String location)` instead of `getInputFile(FileScanTask task)`.", + "prediction": "I don't think this is necessary.", "reference": "I don't think this needs to change. Can you go back to the previous implementation?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change. It seems like you're trying to create a new class called `Commands` that inherits from the `Molecule` class. However, I'm not sure what you're trying to achieve with this change. It seems like you're trying to create a new class called `Commands` that inherits from the `Molecule` class, but I'm not sure what you're trying to achieve with this change. It seems like you're trying to create a new class called `Commands` that inherits from the `Molecule` class, but I'm not sure what you're trying to achieve with this change. It seems like you're trying to create a new class called `Commands` that inherits from the `Molecule` class, but I'm not sure what you're trying to achieve with this change. It seems like you're trying to create a new class called `Commands` that inherits from the `Molecule` class, but I'm not sure what you're trying to achieve with this change. It seems like you're trying to create a new class called `Commands` that inherits from the `Molecule` class, but I'm not sure what you're trying to achieve with this change. It", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea to mix `Molecule` and `Provisioners` in the same module.", "reference": "Bump it 2 lines higher, 'c' > 'u'." }, { - "prediction": "I think this should be `#include \"vesoft/parser/AstTypes.h\"` instead of `#include \"parser/AstTypes.h\"`.", + "prediction": "I think we can remove the `#include \"parser/AstTypes.h\"`.", "reference": "Please do not add author here" }, { - "prediction": "`action` is not a package name, so it should be `import \"github.com/iotexproject/iotex-core/action\"`", + "prediction": "`action` should be `action.Action` instead of `action.Action`", "reference": "Similarly, we should be able to persist action uniformly" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I'm not sure why you'd want to do this. If you want to prevent caching, you can do so by setting `config.cache_classes = false` in `config/environments/production.rb` or `config/environments/development.rb` or `config/environments/production.rb` or `config/environments/development.rb` or `config/environments/production.rb` or `config/environments/development.rb` or `config/environments/production.rb` or `config/environments/development.rb` or `config/environments/production.rb` or `config/environments/development.rb` or `config/environments/production.rb` or `config/environments/development.rb` or `config/environments/production.rb` or `config/environments/development.rb` or `config/environments/production.rb` or `config/environments/development.rb` or `config/environments/production.rb` or `config/environments/development.rb` or `config/environments/production.rb` or `config/environments/development.rb` or `config/environments/production.rb` or `config/environments/development.rb` or `config/environments/production.rb` or `config", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to set the `expires_in` option on the `ConditionalGet` class, but you're not actually using it.", "reference": "I think i'd prefer this override to be in the test helper instead, if that's possible?" }, { - "prediction": "I think this should be `if err != nil { return err; }` instead of `if err != nil { return err; }`", + "prediction": "I think this should be `os.MkdirAll(fullPathDir, 0755)` instead of `os.Mkdir(fullPathDir, 0755)`.", "reference": "This would be better with context added via wrapping or fmt.errorf()" }, { @@ -3503,35 +3503,35 @@ "reference": "What's the purpose of this file?" }, { - "prediction": "I'm not sure if this is the right place to set the passcode length, but I think it's a good idea to set it when the user changes their passcode.", + "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place", "reference": "@bhariharan Why was passcode length requirement allowed to be lowered?" }, { - "prediction": "I'm not sure what you're trying to achieve with this code. It looks like you're trying to create a new bucket and upload some files to it, but I'm not sure what you're trying to achieve with this code. Could you please provide more context or explain what you're trying to achieve with this code?", + "prediction": "I'm not sure what you're trying to do with this flag, but it looks like you're trying to use the `aws` package in a way that doesn't make sense. I'm not sure what you're trying to do with this flag, but it looks like you're trying to use the `aws` package in a way that doesn't make sense. I'm not sure what you're trying to do with this flag, but it looks like you're trying to use the `aws` package in a way that doesn't make sense. I'm not sure what you're trying to do with this flag, but it looks like you're trying to use the `aws` package in a way that doesn't make sense. I'm not sure what you're trying to do with this flag, but it looks like you're trying to use the `aws` package in a way that doesn't make sense. I'm not sure what you're trying to do with this flag, but it looks like you're trying to use the `aws` package in a way that doesn't make sense. I'm not sure what you're trying to do with this flag, but it looks like you're trying to use the `aws` package in a way that doesn't", "reference": "This file needs a license header, too. Sorry I didn't catch that earlier." }, { - "prediction": "I think this should be `string(genesisText[:])` instead of `string(genesisText)`.", + "prediction": "I think it's better to use `string(genesisText[:])` instead of `string(genesisText)`.", "reference": "probably don't need `[:]` why not reference into `github.com/algorand/go-algorand/daemon/algod/api/server/lib` here and skip bouncing off daemon/algod/server.go ?" }, { - "prediction": "I think this should be `te::abs_error` instead of `la::l_inf_norm`?", + "prediction": "I think this should be `te::abs_error` instead of `la::l_inf_norm`.", "reference": "Why reference is converted to table?" }, { - "prediction": "I don't think we need to do pagination here, we can just return the first page of entries.", + "prediction": "I don't think we need to do pagination here, we can just return a single page of entries.", "reference": "should we implement pagination in the fake datastore so the server startup code that paginates entries for trust domain validation can be tested?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.", + "prediction": "I'm not sure what you mean by `f.Vectorized != nil`. I think you meant to say `f.Vectorized != nil`.", "reference": "What mechanism will be exposed so the caller knows they're using the vectorized version?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in a separate controller.", + "prediction": "Shouldn't this be `flash: { success: t('.success') }`?", "reference": "Can we remove respond_to block its not required here" }, { - "prediction": "I'm not sure what you mean by \"symmetic\" here. Is it referring to the fact that the graph is undirected?", + "prediction": "I'm not sure what you mean by \"symmetic\" here. Is it referring to the fact that the graph is undirected? If so, I think we need to change the name of this function to something like \"compute_jaccard_similarity_coefficients\" or something like that.", "reference": "Do not do that even in example, we demonstrate bad practice" }, { @@ -3539,19 +3539,19 @@ "reference": "Hm, taking a second look over this, this is why we have the object inheritance structure that we do. This could be divided up by having a custom determine_if_x86_64 in the pswindows/exec hosts and then a default method in hosts.rb. That way all the custom ps windows work is in a single location." }, { - "prediction": "I think this should be `writerBuffer.FlushAsync().GetAwaiter().GetResult();` instead of `writerBuffer.FlushAsync().GetAwaiter().GetResult();`", + "prediction": "I think this should be `writer.FlushAsync().GetAwaiter().GetResult();` instead of `pipeWriter.FlushAsync().GetAwaiter().GetResult();`", "reference": "We have to `.Complete` now because of empty/null string test cases." }, { - "prediction": "I think we can remove the `if dry_run` check, since it's not really needed.", + "prediction": "I think this should be `options[:recursive]` instead of `options[:recursive] = File.directory?(source) if options[:recursive].nil?`", "reference": "Is there still a way to specify no recursion?" }, { - "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea to have a `Tool` struct with a `HumanReadableName` and a `URISafeName` field.", + "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a good idea to have a `tool` field in the `EnvironmentSettings` struct. This way, you can have a `tool` field in the `EnvironmentSettings` struct, and then you can have a `tool` field in the `Tool` struct, and then you can have a `tool` field in the `EnvironmentSettings` struct, and so on.", "reference": "How is this name being URI safe and being used programmatically related?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `ProviderView` class.", + "prediction": "I don't think we need to do this.", "reference": "I think we have to keep this as a fallback for now, else it's a small breaking change :(" }, { @@ -3559,15 +3559,15 @@ "reference": "nit: shouldn't be part of this PR." }, { - "prediction": "I think this test should be moved to a separate test file.", + "prediction": "I think this test should be moved to a separate file, since it's not related to the `CursorAsyncIterator` tests.", "reference": "this change looks wrong to me. I think the test is trying to signal that something went wrong by throwing the `Error` here, otherwise the `catch` below will swallow it." }, { - "prediction": "I think this should be `if (_layout.IsThreadAgnostic)` instead of `if (!_layout.IsThreadAgnostic)`.", + "prediction": "I'm not sure what you're trying to do here. I don't think we need to do anything here.", "reference": "I'm doubting if this should be `if (_layout.IsThreadAgnostic)`, as ThreadAgnostic stuff could be calculated on every thread. (and thus could be lazy). non-ThreadAgnostic should be calculated on the main thread." }, { - "prediction": "I don't think you need to use `org.slf4j.Logger` here. You can just use `org.slf4j.LoggerFactory.getLogger(LeftListWidgetChooser.class)`.", + "prediction": "I don't think we need to use `org.slf4j.Logger` here. We can just use `org.slf4j.LoggerFactory.getLogger(LeftListWidgetChooser.class)`.", "reference": "Please use only `Logger` instead of `org.slf4j.Logger`" }, { @@ -3575,7 +3575,7 @@ "reference": "Should this be \"no limiter drop\", since this isn't an absolutely essential activity for the stability of the network?" }, { - "prediction": "I'm not sure if this is the right way to do this, but it looks like you're trying to delete the account alias from the AWS console. Is there a better way to do this?", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `process.argv[2]` to get the account alias name.", "reference": "I updated many of the success messages, because most of these operations don't return data if they succeed. This meant many of the operations would print: `Success null` if the script ran successfully." }, { @@ -3583,15 +3583,15 @@ "reference": "Could you simply add it to the previous clause ?" }, { - "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `localeCompare` instead of `localeCompare` in this case. `localeCompare` is more robust and doesn't throw an error if the strings don't match.", + "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `localeCompare` instead of `localeCompare` in this case. `localeCompare` is more robust.", "reference": "@joshyrobot, I think you can just use localeCompare with only the first argument and leave the other arguments out (here and all the other lines changed). It seems to do the right thing, and then we don't have to worry about these extra options." }, { - "prediction": "I think it's better to use `executeFlow` instead of `submitExecutableFlow` in this case.", + "prediction": "I don't think we need to do this. The `executeFlow` method is called by the `submitExecutableFlow` method, so we don't need to call it here.", "reference": "@chengren311 : where does this logic move to?" }, { - "prediction": "I think this should be `if len(s.scope.ManagedMachinePool.Spec.RoleAdditionalPolicies) > 0` instead of `if !s.scope.AllowAdditionalRoles()`.", + "prediction": "I think we can remove the `if !s.scope.AllowAdditionalRoles()` check here.", "reference": "Can we have a `nil` exception check at `s.scope.ManagedMachinePool`" }, { @@ -3599,7 +3599,7 @@ "reference": "Rather than deleting this, should you just reformat it so it's the `*` settings, so if nothing is configured in facets.ini, the existing default behavior continues to work?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `#type` and `#title` on the same line.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a label for this property.", "reference": "wrap, single line" }, { @@ -3607,103 +3607,103 @@ "reference": "always use brackets for if statements" }, { - "prediction": "I think we can remove the `Vendors.Serilog.ILogger` and `FrameworkDescription.Instance` from the `NUnitIntegration` class.", + "prediction": "I think it's better to use `FrameworkDescription.Instance` instead of `FrameworkDescription.Create()`.", "reference": "`NUnitIntegration` doesn't need to cache this anymore." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `element_at` instead of `split` here.", + "prediction": "I think we can remove the `element_at` function here, since it's not used anywhere else in the code.", "reference": "Why did you change it to `>=` here?" }, { - "prediction": "I think this should be `tableName.replaceFirst(\"(hadoop\\\\.)|(hive\\\\.)\", \"\") + \".\" + type` instead of `tableName.replaceFirst(\"(hadoop\\\\.)|(hive\\\\.)\", \"\") + \"#\" + type`.", + "prediction": "I don't think we need to drop the logical name for Spark 2.4.", "reference": "Looks like this needs to be updated. There is no need to remove `hadoop.` if Hadoop tables don't use this code path." }, { - "prediction": "I'm not sure what you're trying to achieve with this. It's not clear to me what you're trying to do with the `require 'digest'` line. It's not clear to me what you're trying to achieve with this. It's not clear to me what you're trying to achieve with this. It's not clear to me what you're trying to achieve with this. It's not clear to me what you're trying to achieve with this. It's not clear to me what you're trying to achieve with this. It's not clear to me what you're trying to achieve with this. It's not clear to me what you're trying to achieve with this. It's not clear to me what you're trying to achieve with this. It's not clear to me what you're trying to achieve with this. It's not clear to me what you're trying to achieve with this. It's not clear to me what you're trying to achieve with this. It's not clear to me what you're trying to achieve with this. It's not clear to me what you're trying to achieve with this. It's not clear to me what you're trying to achieve with this. It's not clear to me what you're trying to", + "prediction": "I'm not sure what you mean by this, but I think it's a good idea to remove the `require 'fileutils'` line from the `Core` module, since it's not used anywhere else in the code.", "reference": "This require isn't need anymore, right?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea.", "reference": "a bit weird to see payments crypto package inside connection manager. There probably will be services not having any relation with payments that will use connection manager. Thats why probably ping-ping by itself can be useful without any relation to payments.." }, { - "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to add a `type` attribute to the `record` element.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add this to `MarcAdvancedTrait` as well.", "reference": "I like the overall idea here, but I wonder if it would be more clear to define the property in the trait, and then set it in the constructors of the classes using the trait. Alternatively, at a bare minimum, it may be a good idea to add `?? 'Bibliographic'` here, to account for the possibility of the trait being used in a class that does not define the property at all." }, { - "prediction": "I don't think we need to change this.", + "prediction": "I think it's a good idea to make this a constant, so that we don't need to change it in the future.", "reference": "I would prefer to not have a magic number, but construct this value out of other constants we already have." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to add a new authentication policy to the pyramid_multiauth module. I'm not sure what you're trying to do here, but it looks like you're trying to add a new authentication policy to the pyramid_multiauth module. I'm not sure what you're trying to do here, but it looks like you're trying to add a new authentication policy to the pyramid_multiauth module. I'm not sure what you're trying to do here, but it looks like you're trying to add a new authentication policy to the pyramid_multiauth module. I'm not sure what you're trying to do here, but it looks like you're trying to add a new authentication policy to the pyramid_multiauth module. I'm not sure what you're trying to do here, but it looks like you're trying to add a new authentication policy to the pyramid_multiauth module. I'm not sure what you're trying to do here, but it looks like you're trying to add a new authentication policy to the pyramid_multiauth module. I'm not sure what you're trying to do here, but it looks like you're trying to add a new authentication policy", + "prediction": "I'm not sure what you mean by \"very basic authentication sessions\"", "reference": "The limitation is if somebody configure another policy with the same name, but it is an edge case we can ignore I guess." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don", + "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a separate package for this.", "reference": "? The package is named `hashivault`." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to change the default value of `config->xwayland_lazy` to `true`.", + "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to have this in the `config.ini` file.", "reference": "I don't think this should enable xwayland, because it's convenient to toggle xwayland just by setting `xwayland` to `false`" }, { - "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `fakeaggregatorclientset` in this case. It's not clear to me what the purpose of this clientset is, and I'm not sure if it's a good idea to use it in this case. I'm not sure if it's a good idea to use `fakeaggregatorclientset` in this case. It's not clear to me what the purpose of this clientset is, and I'm not sure if it's a good idea to use it in this case. I'm not sure if it's a good idea to use `fakeaggregatorclientset` in this case. It's not clear to me what the purpose of this clientset is, and I'm not sure if it's a good idea to use it in this case. I'm not sure if it's a good idea to use `fakeaggregatorclientset` in this case. It's not clear to me what the purpose of this clientset is, and I'm not sure if it's a good idea to use it in this case. I'm not sure if it's a good idea to use `fakeaggregatorclientset` in", + "prediction": "I'm not sure why we need to use `fakeaggregatorclientset` instead of `fakeclientset`.", "reference": "Remove this line by accident?" }, { - "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to have it in a separate file. It's not a big deal, but I think it's a good idea to have it in a separate file. It's not a big deal, but I think it's a good idea to have it in a separate file. It's not a big deal, but I think it's a good idea to have it in a separate file. It's not a big deal, but I think it's a good idea to have it in a separate file. It's not a big deal, but I think it's a good idea to have it in a separate file. It's not a big deal, but I think it's a good idea to have it in a separate file. It's not a big deal, but I think it's a good idea to have it in a separate file. It's not a big deal, but I think it's a good idea to have it in a separate file. It's not a big deal, but I think it's a good idea to have it in a separate file. It's not a big deal, but I think it's a good idea to have it in", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be a good idea to add a `@Retention` annotation to this class so that it can be used as a dependency in other plugins.", "reference": "Calling `.stream()` on a `DomainObjectCollection` is pretty much always a bug, as it doesn't include objects added later (and encourages people to use afterEvaluate). I wonder if we should make this an error prone check?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check here to make sure the file exists before trying to read it.", + "prediction": "I think this should be `if err != nil { return err; }` instead of `if err != nil { return err; }`", "reference": "Thanks for paying attention to other places this might happen. This one is particularly important; I probably never should have gotten in the habit of CheckErr(), since it does a log.Panic() explicitly, which looks like something else until you look closely. It's supposed to be used places where \"can't happen\" but Things Can Happen." }, { - "prediction": "I think it's better to use `fmt.Sprintf(\"%d\", value)` instead of `fmt.Sprintf(\"nw_tos=%d\", value<<2)`.", + "prediction": "I don't think we need to add this to the `ofFlowBuilder` struct. We can just add it to the `matchers` slice.", "reference": "What is the different between nw_tos and ip_dscp? Only high 6 bits vs low 6 bits and supported version?" }, { - "prediction": "I think this should be `if (!cxSmiles)` instead of `if (!asSmarts)`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `makeMolText` as well.", "reference": "I'm assuming that asSmarts & cxSmiles == asSmarts" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `__setstate__` method to `LabelledData` so that we don't have to call `super().__setstate__()` every time we want to unpickle a `LabelledData` instance.", + "prediction": "I'm not sure I understand what you mean by \"super's setstate not called\"?", "reference": "Seems like an oversight but I don't think the super would do anything else in this case unless I'm mistaken." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to start a sample server and a sample client, but you're not using the `Start` method properly.", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to start a sample server and a sample client, but you don't have a `SampleServer` or `SampleClient` instance.", "reference": "Curious, do we consider this as pedantic for example code?" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use the `JavierEguiluz\\\\Bundle\\\\EasyAdminBundle\\\\Form\\\\Type\\\\EasyAdminFormType` instead of `JavierEguiluz\\\\EasyAdminBundle\\\\Form\\\\Type\\\\EasyAdminFormType`.", + "prediction": "I don't think this is a good idea. I think it's better to use the same name for the form type and the entity name.", "reference": "Should we convert the entity name to snake case using `Doctrine\\Common\\Inflector\\Inflector::tableize` or similar ? Should a `snaked_name` or whatever be part of the entity metadata in order to use it for form names, ids, & other html attributes ?" }, { - "prediction": "I think we should remove the `outboundIp` field from the `clientFake` struct.", + "prediction": "I think we can remove the `outboundIp` field from the `clientFake` struct.", "reference": "Should be `client.outboundIp`" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I don't think it's a good idea to change the `LayoutRenderer` class to inherit from `System.IO.StreamWriter` or `System.IO.TextWriter`. The `LayoutRenderer` class is not intended to be used as a base class for other classes, and changing it to inherit from `System.IO.StreamWriter` or `System.IO.TextWriter` could lead to unexpected behavior. It's better to create a new class that inherits from `System.IO.StreamWriter` or `System.IO.TextWriter` and override the `Write` and `WriteLine` methods to achieve the desired functionality.", + "prediction": "I don't think this should be here. It's in the `NLog.UnitTests.LayoutRenderers` namespace.", "reference": "Must these `using` statements not go inside the `namespace` block?" }, { - "prediction": "I'm not sure what you mean by \"fboHead\" and \"fboBlock\" in this context. I think you meant \"fboHead\" and \"fboBlock\" in this context. I'm not sure what you mean by \"fboHead\" and \"fboBlock\" in this context. I think you meant \"fboHead\" and \"fboBlock\" in this context. I'm not sure what you mean by \"fboHead\" and \"fboBlock\" in this context. I think you meant \"fboHead\" and \"fboBlock\" in this context. I'm not sure what you mean by \"fboHead\" and \"fboBlock\" in this context. I think you meant \"fboHead\" and \"fboBlock\" in this context. I'm not sure what you mean by \"fboHead\" and \"fboBlock\" in this context. I think you meant \"fboHead\" and \"fboBlock\" in this context. I'm not sure what you mean by \"fboHead\" and \"fboBlock\" in this context. I think you meant \"fboHead\" and \"fboBlock\" in this context. I'm not sure", + "prediction": "I think it's better to use `fboHead` and `fboBlock` instead of `fboMDWriter` and `fboHead`/`fboBlock`.", "reference": "Why? I thought the previous way was idiomatic. (Same with the `MetadataVer` stuff above.)" }, { - "prediction": "I don't think we need to use `Promise` here. We can just use `resolve` and `reject` directly.", + "prediction": "I don't think this is needed anymore.", "reference": "shouldn't we `reject` here instead?" }, { - "prediction": "I'm not sure what you mean by `senderAddress.String()`. I think it should be `senderAddress.String()`, right?", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `printActionProto` function as well.", "reference": "check err or use gasPriceUnitIOTX, _ := if we are sure action.Core.GasPrice is correct" }, { - "prediction": "I'm not sure what you're trying to do here, but I think it's a bad idea to use `rawVal` in this way. It's not clear to me what you're trying to do here, but I think it's a bad idea to use `rawVal` in this way. It's not clear to me what you're trying to do here, but I think it's a bad idea to use `rawVal` in this way. It's not clear to me what you're trying to do here, but I think it's a bad idea to use `rawVal` in this way. It's not clear to me what you're trying to do here, but I think it's a bad idea to use `rawVal` in this way. It's not clear to me what you're trying to do here, but I think it's a bad idea to use `rawVal` in this way. It's not clear to me what you're trying to do here, but I think it's a bad idea to use `rawVal` in this way. It's not clear to me what you're trying to do here, but I think it's a bad idea to use `rawVal` in this way. It's", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the variable is set before we try to use it.", "reference": "Just curious, was wait not used at all before?" }, { - "prediction": "I'm not sure what you mean by `strings` in this context. Could you please clarify?", + "prediction": "I don't think we need to use `shlex` here. We can just use `strings` here.", "reference": "nit: can we remove this?" }, { @@ -3711,7 +3711,7 @@ "reference": "is it not a problem when one synchronized function is called by other?" }, { - "prediction": "Shouldn't the `email_kudos` and `email_new_followers` be in the `email_kudos` and `email_new_followers`?", + "prediction": "Shouldn't this be `:email_master` instead of `:email_master`?", "reference": "We (even as admins) shouldn't override the User Preference settings like `email_master`, `email_posts`, `email_kudos`, `email_new_followers`. These all would be set by the user of their choice. Please do remove these attributes from editing//updating. Thanks!" }, { @@ -3723,27 +3723,27 @@ "reference": "This line should be repeated for every module that needs testing. One cannot rely on nosetest to automatically discover all the modules. On the bright side, there is no need to change any of the other files." }, { - "prediction": "I think this should be `lastIssueTimeMu.Lock()` instead of `lastIssueTimeMu.LockAndUnlock()`.", + "prediction": "I think this should be `lastIssueTimeMu.Lock()` and `lastIssueTimeMu.Unlock()` instead of `lastIssueTimeMu.Lock()` and `lastIssueTimeMu.Unlock()`.", "reference": "This error was unused" }, { - "prediction": "I'm not sure what this is for, but it looks like it could be used to add tasks to a shard. I'm not sure if this is the right place to put it though.", + "prediction": "I'm not sure what this is for, but it looks like it could be used to add tasks to a shard. I'm not sure if it's a good idea to do this.", "reference": "Personally I wish we didn't have a proto for every single little thing we do. RequestShardAction with an enum for the action type would be a lot cleaner imo, but I'm pretty sure that ship has sailed :) Just kvetching." }, { - "prediction": "I think this should be `render \"trails/incomplete_trail\", trail: trail` instead of `render \"trails/incomplete_trail\", trail: trail %>`", + "prediction": "I think it's better to use `if trail.complete?` instead of `if trail.complete? && trail.completed?`", "reference": "Does this make more sense as `trails/_trail` now?" }, { - "prediction": "I'm not sure what you mean by \"backfilled\" in this context. It's not clear to me what you're trying to do here.", + "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place", "reference": "synced offline. let's move this to `agent_unix.go` to make the IMDS call, since this is not supported in Windows." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to add a mapping for `py_install` or `py_prep`.", + "prediction": "I'm not sure what you're trying to achieve with this mapping, but I think it would be better to have a separate mapping for `py_install` and `py_prep`.", "reference": "Too much indentation here. Should match the lines above, which have four spaces." }, { - "prediction": "I'm not sure what you mean by \"can't use the CH algorithm with MLD data\"", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use the corech algorithm with MLD data.", "reference": "Same here we still need this test to make sure the fallback works." }, { @@ -3751,15 +3751,15 @@ "reference": "I'm wondering if we can actually base this on a `IMvxPresentationAttribute` instead of the base one." }, { - "prediction": "I think this should be `if ((r = vnode._children)) {` instead of `if ((r = vnode._children) {`", + "prediction": "I'm not sure if this is the right place to do this, but I think it makes sense to do it here.", "reference": "could we switch to `undefined` here?" }, { - "prediction": "I'm not sure what you mean by \"setupSyncsSoupIfNeeded\" and \"cleanupSyncsSoupIfNeeded\"", + "prediction": "I'm not sure what you're trying to do here. I don't think we need to do anything here. The `setupSyncsSoupIfNeeded` and `cleanupSyncsSoupIfNeeded` methods are only called when the `SyncManager` is created, so I don't think we need to call them here.", "reference": "The cleanup call" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Can you clarify?", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `options` object here.", "reference": "I think \"View artist\" is a bit more standard and expected. Or even \"Go to artist\" to take the Spotify terminology as-is." }, { @@ -3771,27 +3771,27 @@ "reference": "We were trying to move away from this to force people to always run tests under py.test." }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `self._get_selenium_options()` and `self._get_firefox_options()` instead of `self._get_selenium_options()` and `self._get_firefox_options()` + `self._get_firefox_profile()` + `[self._get_firefox_webdriver()]`.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `self._get_selenium_options()` and `self._get_firefox_options()` instead of `self._get_selenium_options()` and `self._get_firefox_options()` + `self._get_firefox_profile()` + `[self._get_firefox_webdriver()]`.", "reference": "1 - create browser specific options class: - chromeoptions - firefoxoptions - argsoptions" }, { - "prediction": "I think this should be `if 'text/html' in response.headers.get('Content-Type', '')` instead of `if 'text/html' in response.headers.get('Content-Type', '') and not response_content_str.startswith('isInvisible()`. If you want to check if the creature is visible, you can just do `!creature->isInvisible()`.", "reference": "You introduced a bug here." }, { @@ -3891,19 +3891,19 @@ "reference": "Should we log a warning/error if only one is specified and not the other?" }, { - "prediction": "I think we can remove the `*pipedservice.ReportApplicationLiveStateEventsResponse` and just return the `*pipedservice.GetLatestEventResponse` instead.", + "prediction": "I think we can remove the `*pipedservice.GetLatestEventResponse` here.", "reference": "`ctx` is unused in GetLatestEvent" }, { - "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to set the default peering port for the network. Is that correct? If so, how do you want to handle the case where the user hasn't specified a port in the config?", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to set the default port for the node, but I'm not sure if that's what you're trying to do here.", "reference": "This looks good to me. Personally, I would have the following for maximum flexibility: * convert peering_port from uint64_t to int. * Set the default value to \"-1\" to specify the value is not set * if the value is -1 then do `config.node.peering_port = network_params.network.default_node_port` That would allow for 0 to mean, select the port number yourself and be more consistent. But I am happy with the change as is, as well." }, { - "prediction": "I'm not sure what you mean by \"flip the image (if needed)\". I think you meant to say \"flip the image horizontally\" or \"flip the image vertically\" or \"flip the image upside down\" or \"flip the image backwards\" or \"flip the image forwards\" or \"flip the image left to right\" or \"flip the image right to left\" or \"flip the image up to down\" or \"flip the image down to up\" or \"flip the image left to right\" or \"flip the image right to left\" or \"flip the image up to down\" or \"flip the image left to right\" or \"flip the image right to left\" or \"flip the image up to down\" or \"flip the image left to right\" or \"flip the image right to left\" or \"flip the image up to down\" or \"flip the image left to right\" or \"flip the image right to left\" or \"flip the image up to down\" or \"flip the image left to right\" or \"flip the image right to left\" or \"flip the image up to down\" or \"flip the image left to right\" or \"flip the image right to left\" or \"flip the image up to down\" or", + "prediction": "I don't think we need to add `__all__` to this class. It's already in the `__init__.py` file.", "reference": "The blank line between the summary and detailed description is better to be kept." }, { - "prediction": "I think we should remove the `NoRemoveUnusedShapes` check.", + "prediction": "I think we should remove the `a.NoRemoveUnusedShapes` check.", "reference": "Curiously, are these indents intended or should they be aligned?" }, { @@ -3911,7 +3911,7 @@ "reference": "What if we changed this to this? roleText=attrs.get('roleText', lambda:getSpeechTextForProperties(reason=reason,role=role)) That will prevent the function from ever needing called in the roletext case, and removes that if." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think we need to use `safe_read_tls_magic` here.", + "prediction": "I'm not sure what you're trying to say here. I think you're trying to say that we don't need the thread's private dcontext anymore here at this point.", "reference": "This will still result in a safe_read_tls_magic on AMD in tls_thread_preinit()." }, { @@ -3923,23 +3923,23 @@ "reference": "Oh, was that a bug in the validation?" }, { - "prediction": "I don't think we need to remove the feed URL from the feed URL in order to subscribe to the actual feed URL.", + "prediction": "I don't think we need to remove this line, as it's only used in the case where the feed URL contains \"subscribeonandroid.com\"", "reference": "Please use the Google java code style. Basically, add more space characters like in the statements below. Next to method arguments and curly braces. This is currently not checked on CI because it is too inconsistent in the code base but I would prefer new code to be consistent." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a test for this in `UpdateEdgeTest` as well.", + "prediction": "I don't think we need to delete the `sourcePropExp` here.", "reference": "Actually, I don't think we need to create object on heap." }, { - "prediction": "I think it's better to use `\\\"golang.org/x/net/context\\\"` instead of `\\\"golang.org/x/net/context\\\"`.", + "prediction": "I think we should remove the `\\\"golang.org/x/net/context\\\"` and `\\\"google.golang.org/grpc\\\"` from the `vars` list.", "reference": "this is a file we copy from gRPC, sp ideally it be fixed upstream as well.." }, { - "prediction": "I don't think we need to use `com.google.common.cache.CacheBuilderSpec` here. We can use `com.google.common.cache.CacheBuilder` directly.", + "prediction": "I don't think this is necessary. The `CacheBuilderSpec` is not used anywhere in this code.", "reference": "changes like this, just strangle guava usages to be replaced by DelayLimiter into one place" }, { - "prediction": "I don't think we need to add `header` and `footer` to the `Widget` class. We can just use `Header` and `Footer` directly in the `Widget` class.", + "prediction": "I don't think we need to do this. We can just use the `header` and `footer` props directly in the `Widget` component.", "reference": "PropTypes need to be updated accordingly here. Note that the type also needs updating, not just the case. That is, these should both expect a `PropTypes.elementType` now instead of an `element`." }, { @@ -3947,51 +3947,51 @@ "reference": "maybe extra paren around `strncmp(...) != 0`" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `TrayListener` class as well.", "reference": "We should call `Windows.onResume `: - When the app is launched for the first time - When the app is resumed after being paused (home button and resume or device goes to sleep) - After a permission prompt is displayed" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a `BftForksSchedule` that takes a `C` object and returns a `NavigableSet` of `ForkSpec`. I'm not sure what you're trying to do here, but it looks like you're trying to create a `BftForksSchedule` that takes a `C` object and returns a `NavigableSet` of `ForkSpec`. I'm not sure what you're trying to do here, but it looks like you're trying to create a `BftForksSchedule` that takes a `C` object and returns a `NavigableSet` of `ForkSpec`. I'm not sure what you're trying to do here, but it looks like you're trying to create a `BftForksSchedule` that takes a `C` object and returns a `NavigableSet` of `ForkSpec`. I'm not sure what you're trying to do here, but it looks like you're trying to create a `BftForksSchedule` that takes a `C` object and returns a `NavigableSet` of `Fork", + "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `NavigableSet` here. You can just use `TreeSet` directly.", "reference": "Rename to ForksSchedule? Maybe in separate PR." }, { - "prediction": "I'm not sure I understand what you're trying to do with this test. It's not clear to me what you're trying to test here.", + "prediction": "I'm not sure if this is the right place for this test, but I think we should move it to the `kinto.core.cache` module.", "reference": "Why a blank line here?" }, { - "prediction": "I'm not sure what you mean by \"deactivated_on\"", + "prediction": "I'm not sure what you mean by \"deactivated_on\". Is it the time when the subscription was deactivated, or the time when the user unsubscribed?", "reference": "I have a sense that this will actually eventually change to check the actual date so that subscriptions can be deactivated in the future. But I mention that here just to keep you in the loop. We should not make that change now, because it's not needed functionality." }, { - "prediction": "I think this should be `Optional` instead of `Optional`.", + "prediction": "I think this should be `Optional` instead of `Optional`.", "reference": "What is the reasoning for using the negation of `isOption()` instead of simply using `isPositional()` to identify a positional param?" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the end of the function.", + "prediction": "I think this should be `msg.addByte(player->getVocation()->getId() != VOCATION_NONE ? 0x01 : 0x00);` instead of `msg.addByte(player->getVocation()->getId() != VOCATION_NONE ? 0x01 : 0x00); // prey data`", "reference": "Why would you add those if client version min is set to 1100?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `sync` package to implement a `sync.Mutex` in Go. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `sync` package to implement a `sync.Mutex` in Go. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `sync` package to implement a `sync.Mutex` in Go. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `sync` package to implement a `sync.Mutex` in Go. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `sync` package to implement a `sync.Mutex` in Go. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `sync` package to implement a `sync.Mutex` in Go. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `sync` package", + "prediction": "I don't think we need to change anything here, but I'm not 100% sure that this is the right place to do it.", "reference": "You can delete this, it will now need to live in `gointerfaces` package" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you're trying to do here. I don't think you want to use `render_link_rel_alternates` here. I think you want to use `link_to` instead.", "reference": "Okay, I still don't understand why you have to add `html_safe` here, and it still seems like a very bad idea. It will allow html tags in the title, and keep Rails from escaping literal greater-than or less-than chars not intended as HTML tags. It ought to work to just let Rails do HTML-escaing as normal, without any manual `html_safe` or `strip_tags` or whatever. I am not clear on what problem you are trying to solve, why the straightfoward approach does not work." }, { - "prediction": "Shouldn't this be `mActionBarSubject.showSubjectInMessageHeader();` instead of `mActionBarSubject.setText(subject);`?", + "prediction": "Shouldn't this be `if (mDisplayMode == DisplayMode.MESSAGE_VIEW)`?", "reference": "What is is subject when it's not the email subject. Why are we having to do this crap? What's calling this with an empty string?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think we should move this to the `DefaultSampler` struct. It's not clear to me what the `DefaultSampler` struct is supposed to do here.", + "prediction": "I don't think we need to change `DefaultMaxAttributesPerSpan` and `DefaultMaxEventsPerSpan` to `DefaultMaxAttributesPerSpan` and `DefaultMaxEventsPerSpan` respectively. I think we can just use `DefaultMaxAttributesPerSpan` and `DefaultMaxEventsPerSpan`.", "reference": "Could you also remove the `defaultSamplingProbability` constant from `sampling.go`? It seems to became unused with this change." }, { - "prediction": "I think we can remove the `if err != nil` here.", + "prediction": "I think we can remove the `if err != nil` here, since it's already checked by the `if err != nil` in the `patchBytes, err := generateDeploymentStrategicPatch(oldDeployment, newDeployment)` line.", "reference": "can you delete the `generateDeploymentStrategicPatch` function as well?" }, { - "prediction": "I'm not sure if this is the best way to do this, but it seems to work for me.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `context.createSocket(SocketType.SUB)` instead of `context.createSocket(SocketType.PUB)`. This is because `context.createSocket(SocketType.PUB)` will create a socket that will be used for both PUB and SUB, which is not what we want here.", "reference": "I'd keep this at `info` level..." }, { @@ -3999,67 +3999,67 @@ "reference": "Don't use DCHECK to debug your code if it's the regular branch you need to handle." }, { - "prediction": "I think this should be `throw new UnsupportedOperationException(\"Out of scope for antlr current implementations\");` instead of `throw new UnsupportedOperationException(\"Out of scope for antlr current implementations\");`", + "prediction": "I think this should be moved to the `Node` interface, since it's not specific to `AntlrNode`.", "reference": "You should return null here instead. Null is an acceptable default value for the image attribute." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `useEffect` hook, since the `afterPaintEffects` array will be updated by the `useEffect` hook.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move it to the `useEffect` hook.", "reference": "react bails as well?" }, { - "prediction": "I don't think it's necessary to add `ROLE_ADMIN_AS_CUSTOMER` to the list of roles.", + "prediction": "I think it's better to use `const ROLE_ADMIN` instead of `const ROLE_ADMIN_AS_CUSTOMER` and `const ROLE_LOGGED_CUSTOMER`.", "reference": "Can you please tell me why you did this?" }, { - "prediction": "I'm not sure what you mean by `this.opts.videoConstraints ?? {}`", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way", "reference": "Reading this again it should prob prefer the `videoConstraints.facingMode` value over `facingMode` if the former was already set" }, { - "prediction": "I'm not sure what you mean by \"uniqueness: true\"", + "prediction": "I don't think we need to extend `FriendlyId` here. We can just use `friendly_id` directly.", "reference": "There's a good bit of class-level stuff that's repeated in our various product types. Think it's worth extracting a...dare I say it...module?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to use the `wasm-abi=generic` flag to disable this behaviour.", + "prediction": "I think we should be able to use -wasm-abi=generic to disable this behaviour, but I don't think we should be able to use -wasm-abi=js to disable this behaviour.", "reference": "Please do not modify the `config.Target` field, it should contain exactly what is extracted from the JSON files. Instead, you can either: * Add a getter to the `config` variable (`*compileopts.Config`), so you can simply call `config.WasmAbi()` to get the value. * Use a local variable instead. The getter would be slightly cleaner, as it matches the pattern of other configurations (`CGO_ENABLED`, `GC`, `NeedsStackObjects`, etc)." }, { - "prediction": "I'm not sure if this is a good idea, but I think we should be able to start the transport before we start the router, so that we don't have to wait for the router to start before we can start the transport.", + "prediction": "I don't think this is a good idea. We should use `net.ListenTCP` instead of `net.Listen(\"tcp\", \"127.0.0.1:0\")`.", "reference": "The nil check is not necessary for these. Append checks both sides for nil." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to add an event to the span, but you're not actually adding the event to the span. I think you want to do something like this: `span.AddEvent(ctx, \"handling this...\")`", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `trace.WithAttributes(...)` instead of `trace.WithAttributes(attrs...)`. This is because `trace.WithAttributes(attrs...)` is a shorthand for `trace.WithAttributes(..., attrs...)`, which is more concise and easier to read. Also, `trace.WithAttributes(..., attrs...)` is more explicit about what the `attrs...` are and what they are used for.", "reference": "Shouldn't we instead have the SDK apply these, internally? I.e., I would expect to see the dctx entries included in the span as first-class distributed correlations, not as span attributes." }, { - "prediction": "I think this should be `errors.New(\"not implemented\")` instead of `errors.New(\"not implemented\")`", + "prediction": "I think this should be `errors.New(\"not found\")` instead of `errors.New(\"not implemented\")`.", "reference": "nit: rename this in proto and update impl to `Search` to avoid stutter" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `orderBy` method to order by the `position` field.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way", "reference": "is it necessary to order by id as a second ordering? this will take place only when several new slider items are created without reordering (position is then null). Wouldn't be better to recalculate position after creating a new item? (right now items with null in position behave differently in administration and on frontend)" }, { - "prediction": "Shouldn't this be `ClaimFromRewardingFundBaseGas` instead of `ClaimFromRewardingFundGasPerByte`?", + "prediction": "I don't think this is needed.", "reference": "`ClaimFromRewardingFundBaseGas` is a global variable (from `gochecknoglobals`)" }, { - "prediction": "I think this should be moved to the `SubstructMatch` class, since it's not really part of the `SubstructMatch` class.", + "prediction": "I think this should be `SubstructMatch(mol, query, matches, true, useChirality, useQueryQueryMatches);`", "reference": "How about modifying the NOGIL definition so that it only does anything if the thread safety flag (RDK_BUILD_THREADSAFE_SSS) is set?" }, { - "prediction": "Shouldn't this be `uint64` instead of `int64`?", + "prediction": "I don't think this is necessary.", "reference": "blockheighter would be more clear" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `OptimizerUtils` namespace.", + "prediction": "I think it's better to use `std::swap(a, b)` instead of `std::swap(a, b); std::swap(b, a);`", "reference": "This is so weird as a utility function." }, { - "prediction": "I'm not sure what you mean by \"Ignores the ConsistentRead field from both QueryInput and ScanInput.\"", + "prediction": "I'm not sure why we need to ignore the ConsistentRead field here. I think we can just ignore the ConsistentRead field from both QueryInput and ScanInput.", "reference": "Why? What would happen if you did not?" }, { - "prediction": "I think this should be `if (o != null)` instead of `if (o != null && o instanceof JSONObject)`", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to check if the object is null before trying to get the value.", "reference": "Unrelated bugfix for NPE." }, { @@ -4067,7 +4067,7 @@ "reference": "What if some extended the `AdminController` and had a check for the old option name? Could that be a valid use case?" }, { - "prediction": "I'm not sure what you're trying to do with this, but it looks like you're trying to make a call to the `data-manager/event-segment` endpoint, but you're not using the `dataType` option. You should be using `dataType: 'json'` instead of `dataType: \"json\"`.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `fetchSegmentMap` method to fetch the segment map data, and then use the `fetchRefreshSelectedEventsData` method to fetch the selected events data. This way, we can ensure that the segment map data is always up to date, and that the selected events data is always up to date as well.", "reference": "This will be only available when data-manager is enabled, is there a fallback in case data manager is disabled?" }, { @@ -4075,15 +4075,15 @@ "reference": "Do you think we want to move the call to `generateWorkerServiceRecommendedActions` inside `RecommandedActions()`?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this check to the `vkGetQueryPoolResults` function.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `vkGetQueryPoolResults` as well.", "reference": "The VUIDs in this area are not great, but I think `ValidateQueryPoolStride` should probably be skipped if the query pool was created with type `VK_QUERY_TYPE_PERFORMANCE_QUERY`. VUID-02828 might be a better fit, but again, the existing VUIDs step on each other so it requires a bit of interpretation." }, { - "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `Nethermind.Store` namespace, so that it can be used by other parts of Nethermind.", "reference": "Iguess you should use ToDbKey here" }, { - "prediction": "I'm not sure what you mean by \"counting index does not exist yet\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `blockIndexer.go` instead of `blockIndexerImpl.go`.", "reference": "x.tbk is the \"index\" below, and is done in Start()" }, { @@ -4091,15 +4091,15 @@ "reference": "Do we already have a convention for this? If not, would we consider \"DataDog.IsAppInsights\". And then use \"DataDog.\" prefix for all this settings, environment variables etc..? Such settings are, essentially, public APIs because they may conflict with customer data. Regardless of that , AppInsights has an s at the end :)" }, { - "prediction": "I think this should be `if (ctx->log_key && ctx->time_key)` instead of `if (ctx->log_key && ctx->time_key && ctx->time_key_format == DEFAULT_TIME_KEY_FORMAT)`", + "prediction": "I don't think we need to use `flb_plg_error` here. We can just use `ctx->log_key` and `ctx->time_key` directly.", "reference": "this assignment is not necessary if the offsetof() is used in the configmap" }, { - "prediction": "I'm not sure what you mean by \"if balance.Cmp(big.NewInt(0)) == 0\". I think it should be \"if balance.Cmp(big.NewInt(0)) < 0\".", + "prediction": "I don't think we need to delete the account from the store if the account balance is cleared.", "reference": "I'd rather leave a TODO here at least." }, { - "prediction": "I'm not sure what you mean by \"body is transmitted during a redirect\". I think you meant that the body of the response is sent along with the redirect.", + "prediction": "I'm not sure what you mean by \"body is transmitted during a redirect\". I think you meant \"body is transmitted during a request\".", "reference": "Shouldn't this be `resource`?" }, { @@ -4111,7 +4111,7 @@ "reference": "Do we need to change occurences where `setup` was called before?" }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to have a separate function for this.", + "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to add a new shape type to the API. Is this what you're trying to do? If so, how do you intend to use this new shape type?", "reference": "Is this TODO still valid? Or are we going to put this somewhere else later?" }, { @@ -4119,51 +4119,51 @@ "reference": "We generally don't do parantheses in if conditions in Python. :) this could be better written as `if from_ts is None`" }, { - "prediction": "I think this should be `map = HbaseTM_process_request_regions_info();` instead of `HashMapArray* map = HbaseTM_process_request_regions_info();`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `tm_process_req_requestregioninfo` function, since it is called by the `tm_process_req_requestregioninfo` function.", "reference": "Odd that we'd set just element 299 of a 2000-byte buffer to null. But I see that this is the way it was before." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it would be a good idea to move it to a separate file.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `PeerAdder` interface. It seems like it could be useful for other components as well.", "reference": "ScoreFunc is not used in this PR. Maybe to add it later when needed?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do it here.", "reference": "super nit: I think this might be easier to read as `requestHeadersFromResponseWriter`" }, { - "prediction": "I don't think we need to include `` and `` here. They are not used anywhere.", + "prediction": "I don't think we need to use `std::thread` here. We can just use `std::this_thread::get_id()` and `std::this_thread::get_id() + 1` to get the id of the current thread.", "reference": "Need to include \"common/base/Base.h\" in front of this line" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `getRole` or `matches` or `nativeElementType` or `nativeTextMethods` or `getElementSpec` or `getRole` or `matches` or `nativeElementType` or `nativeTextMethods` or `getElementSpec` or `getRole` or `matches` or `nativeElementType` or `nativeTextMethods` or `getElementSpec` or `getRole` or `matches` or `nativeElementType` or `nativeTextMethods` or `getElementSpec` or `getRole` or `matches` or `nativeElementType` or `nativeTextMethods` or `getElementSpec` or `getRole` or `matches` or `nativeElementType` or `nativeTextMethods` or `getElementSpec` or `getRole` or `matches` or `nativeElementType` or `nativeTextMethods` or `getElementSpec` or `getRole` or `matches` or `nativeElementType` or `nativeTextMethods` or `getElementSpec` or `getRole` or `matches` or `nativeElementType` or `nativeTextMethods` or `getElementSpec` or `get", + "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", "reference": "Changes in this file should go into a separate PR." }, { - "prediction": "I think we can remove the `@Override` here.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `@Override` for this method.", "reference": "Please ensure that this will not start putting single quotes where double quotes are expected." }, { - "prediction": "I'm not sure what you mean by \"ProvideConfig\" but I think it should be `ProvideConfig` instead of `ProvideConfigPublic`.", + "prediction": "I don't think we need to use `json.Unmarshal` here. We can just use `json.RawMessage` directly.", "reference": "`ProvideConfig` was changed, looks like it will not compile for windows, and should be changed too." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have", + "prediction": "I don't think this is a good idea. I think it's better to use `github.com/gogits/go-gogs-client`'s `ListMyRepos` function.", "reference": "This does not look right, you're listing all private repositories.." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. I think you want to use the `xss_options_request` helper in `application#xss_options_request` instead of `application#xss_options_request` in `errors#token_authentication_error`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to `application_controller.rb` instead of `application_routes.rb`.", "reference": "An OPTIONS request should respond from _any_ path? Seems weird to me..." }, { - "prediction": "I don't think we need to add `width` and `height` to the `MediaAdmin` class.", + "prediction": "I don't think we need to add `width` and `height` to the `Media` model.", "reference": "you need to add the content type" }, { - "prediction": "I'm not sure what you mean by \"failed to halt the sub-process stats agent\"", + "prediction": "I'm not sure if this is the best place to do this, but I think it's a good idea to have a `StopSubProcesses` method in the `TraceAgentMonitor` class. This way, we can ensure that the `StopSubProcesses` method is called when the `StopSubProcesses` method is called on the `TraceAgentMonitor` instance.", "reference": "Do we need to distinguish between these two processes? I'm thinking maybe we can have a list of processes and treat them all equally." }, { - "prediction": "I think this should be 16 byte aligned on ARM and x64, not 16 byte aligned on AArch64.", + "prediction": "I think this should be `#if defined(AARCH64) || defined(X64)` instead of `#if defined(AARCH64) || defined(X64)`.", "reference": "This is used only for out-of-line -- so yes this seems right to do for x64. Inlined is aligned separately at the end of prepare_for_clean_call(). There the ifdef is x86_64 or MACOS -- no ARM, why not? Also, please add || MACOS here to match the inlined." }, { @@ -4171,11 +4171,11 @@ "reference": "guess I'm wondering if this needs to be refactored to use Schema.joinCondition() or similar?" }, { - "prediction": "I'm not sure what you mean by \"needed now for feature parity for beaker 3.x\"", + "prediction": "I'm not sure what you mean by \"needed now for feature parity for beaker 3.x\". I'm not sure what you mean by \"needed now for feature parity for beaker 3.x\". I'm not sure what you mean by \"needed now for feature parity for beaker 3.x\". I'm not sure what you mean by \"needed now for feature parity for beaker 3.x\". I'm not sure what you mean by \"needed now for feature parity for beaker 3.x\". I'm not sure what you mean by \"needed now for feature parity for beaker 3.x\". I'm not sure what you mean by \"needed now for feature parity for beaker 3.x\". I'm not sure what you mean by \"needed now for feature parity for beaker 3.x\". I'm not sure what you mean by \"needed now for feature parity for beaker 3.x\". I'm not sure what you mean by \"needed now for feature parity for beaker 3.x\". I'm not sure what you mean by \"needed now for feature parity for beaker 3.x\". I'm not sure what you mean by \"needed now for feature parity for beaker 3.x\". I'm not sure", "reference": "Does it make sense to restrict this option to `exec` only? You could add it specific to that subcommand using the `method_option`...method. There's an example of it for hosts in the `init` function." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. It's not clear to me that this is the right place to do this, but I think it would be a good place to do this. It's not clear to me that this is the right place to do this, but I think it would be a good place to do this. It's not clear to me that this is the right place to do this, but I think it would be a good place to do this. It's not clear to me that this is the right place to do this, but I think it would be a good place to do this. It's not clear to me that this is the right place to do this, but I think it would be a good place to do this. It's not clear to me that this is the right place to do this, but I think it would be a good place to do this. It's not clear to me that this is the right place to do this, but I think it would be a good place to do this. It's not clear to me that this is the right place to do this, but I think it would be a good place to", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `Uri.EscapeDataString` to escape any special characters in the `Name` and `Value` fields.", "reference": "This is very expensive (lots of allocations, lots of data copying). Could we do something like check IndexOf('%') and bypass if no hit?" }, { @@ -4183,55 +4183,55 @@ "reference": "This should be `WorldType.isDeadmanWorld(client.getWorldType())` to be inline with the other WorldType calls." }, { - "prediction": "`mlvl_confids` should be `mlvl_confidences`", + "prediction": "`mlvl_confids.append(confidences)` should be `mlvl_confids.append(confidences.contiguous())`", "reference": "do we also need to change `mlvl_confid` -> `mlvl_confidences`>" }, { - "prediction": "I'm not sure what you mean by \"oneof(insert,append)\". I think it should be \"oneof(insert,append,drop)\" or \"oneof(insert,append,drop,non-zero,die-on-fail)\".", + "prediction": "I'm not sure what you mean by \"oneof(insert,append)\". I think it should be \"oneof(insert,append,drop)\"", "reference": "I feel slightly that InterfaceExclude is not a clear name - bearing in mind that our config names are, to some extent, an external API. From an external point of view, a clearer name might be IPVSInterfaces. Then it would obviously make sense for the value to be something like 'kube-ipvs0', and it would be a matter of Felix's internal implementation that we choose to exclude those interfaces from our monitoring. Alternatively, if we want to keep this at a level that is more general than just IPVS, perhaps 'UnmonitoredInterfaces'? WDYT?" }, { - "prediction": "I think this should be `if re.match(r'[A-Z]:[^\\\\]', path, re.IGNORECASE)` instead of `if re.fullmatch(r'[A-Z]:[^\\\\]', path, re.IGNORECASE)`.", + "prediction": "I don't think this is a good idea. I think it's better to use `os.path.expanduser` instead of `os.path.expanddrive`.", "reference": "This should be `re.search` with a `^` anchor added to the regex, as what we want here is really any path starting with something like `E:`." }, { - "prediction": "I think we should be able to determine the health of a virtual service based on the health of the virtual service itself, and the health of the virtual service's destination rules.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate function for determining the health of a virtual service. This way, we don't have to worry about the health of a virtual service if we don't need it.", "reference": "Since `IsKubernetesBuiltInResource` at L69 returns false due to lack `networking.istio.io/v1alpha3` in `builtInApiVersions` within `pkg/app/piped/cloudprovider/kubernetes/resourcekey.go`, it will never reach this point." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.", + "prediction": "I'm not sure I understand what you're trying to do here. You're creating a new `processor` object and passing it to a `controller` object, but you're not using the returned `processor` object. Is this what you're trying to do?", "reference": "Does codecov not run this test? Not sure how else it would not be covered." }, { - "prediction": "I'm not sure what you mean by \"JSON_DATA\" in this context. It's not clear to me what you're trying to do with it.", + "prediction": "I don't think we need to use `cobra.ExactArgs(1)` here. We can just use `cobra.ExactArgs(1)`, which is the same as `cobra.ExactArgs(0)`.", "reference": "can we add some sample of JSON_DATA format in the usage?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `Span` class.", "reference": "Using `Tracer.Instance` in here is problematic for testing It will likely cause some other tests to break I think - that's why we started passing in `IScopeManager` EDIT: I see you used `[TracerRestore]` - maybe that'll be enough!" }, { - "prediction": "I think this should be `projectIdVariableName` instead of `projectIdToken`?", + "prediction": "I think this should be `projectIdVariableName` and `projectIdToken` instead of `projectId` and `randomValueToken`.", "reference": "make all of these `static final` fields UPPER_SNAKE - they are constants." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be better to do this in the `AffectMagicalDamage` function.", "reference": "No possible chance for weird overflows here, right?" }, { - "prediction": "Shouldn't this be `DocIdSetIterator disi;` instead of `DocIdSetIterator disi = new DocIdSetIterator(readerContext);`?", + "prediction": "I don't think this should be here. It should be in the `ValueSourceScorer` constructor.", "reference": "Or we could use a Float object to more clearly show as user-settable via non-null?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to call `ForkchoiceUpdated` twice.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `forkchoiceUpdated` event handler.", "reference": "finalizedHeader should be saved in FinalizationManager when we have FinalizationBlockHash != Keccak.Zero" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a scratch disk for each data disk, but I'm not sure what you're trying to do here. I think you're trying to create a scratch disk for each data disk, but I'm not sure what you're trying to do here. I think you're trying to create a scratch disk for each data disk, but I'm not sure what you're trying to do here. I think you're trying to create a scratch disk for each data disk, but I'm not sure what you're trying to do here. I think you're trying to create a scratch disk for each data disk, but I'm not sure what you're trying to do here. I think you're trying to create a scratch disk for each data disk, but I'm not sure what you're trying to do here. I think you're trying to create a scratch disk for each data disk, but I'm not sure what you're trying to do here. I think you're trying to create a scratch disk for each data disk, but I'm not sure what you're trying to do here. I think you're trying to create a scratch disk for each data disk, but I'm not sure", + "prediction": "I'm not sure what you mean by `scratchDiskDiskName`. Is it the same as `diskImporter-scratch-%s-%v`?", "reference": "Not using ExactName: true would remove the need for manually adding workflow ID as it would be added automatically by Daisy. E.g. 'disk-importer-2-import-ovf-7mn7h' was created from diskImporterDiskName above even though only 'disk-importer-2' was specified. ExactName: true should be used for resources that shouldn't include any temp prefix/suffix, such as disks that will be permanently attached to a created instance. Scratch disk is not one of them." }, { - "prediction": "I'm not sure if this is the right way to do this, but I think we should be able to do this in one line.", + "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `self._internal` instead of `self._sdf` in this case.", "reference": "If we support multi-index column later, we need to rename to fit the pandas' requirement." }, { @@ -4239,19 +4239,19 @@ "reference": "I'm not sure this is really needed. JSONValue type can be used the same as a map as far as operators go, including range. I'd leave this out for now unless there is a strong reason to keep it." }, { - "prediction": "I'm not sure what you mean by \"startDecaying\" in this context. It's not clear to me what you're trying to do here.", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to call `startDecaying` on every item in `itemlist`. I'm not sure what you're trying to do here, but it looks like you're trying to call `startDecaying` on every item in `itemlist`. I'm not sure what you're trying to do here, but it looks like you're trying to call `startDecaying` on every item in `itemlist`. I'm not sure what you're trying to do here, but it looks like you're trying to call `startDecaying` on every item in `itemlist`. I'm not sure what you're trying to do here, but it looks like you're trying to call `startDecaying` on every item in `itemlist`. I'm not sure what you're trying to do here, but it looks like you're trying to call `startDecaying` on every item in `itemlist`. I'm not sure what you're trying to do here, but it looks like you're trying to call `startDecaying` on every item in `itemlist`. I'm not sure what you're trying to do here, but it looks like you're", "reference": "sorry for nitpicking but I would love a new line under this line" }, { - "prediction": "`AccountantID` should be `AccountantID string` instead of `AccountantID string`", + "prediction": "I'm not sure what you mean by `AccountantID` and `ChannelImplementation`. Could you please clarify?", "reference": "ChannelImplementation field naming is not clear, is it some kind of standard? Maybe it can be named ChannelID?" }, { - "prediction": "I think this should be `default RemoveFiles removeFiles(String metadataLocation)` instead of `default ExpireSnapshots removeFiles(String metadataLocation)`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `ActionsProvider` interface.", "reference": "Looks like there is a typo: `expireSnapshots` -> `removeFiles` or whatever name we go with." }, { - "prediction": "I don't think this is necessary.", + "prediction": "I don't think you need to change this line.", "reference": "Thanks for looking into this. I think it looks a bit strange to have this check inside the for loop. Wouldn't it also work to initialize `idxCurrentSort` with 0 instead?" }, { @@ -4259,15 +4259,15 @@ "reference": "Just a small ordering thing: Could you please bring `IMPORTANCE_HIGH` to the bottom and maybe even have one line between it and the Notification IDs?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in `MolOps::Kekulize` instead of `MolOps::KekulizeMol`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `MolOps::Kekulize` function.", "reference": "Should this be boost logged?" }, { - "prediction": "I don't think we need to use `session` here. We can just use the `created_at_datetime` directly.", + "prediction": "I don't think we need to use `session` here. We can just use `Violation` object directly.", "reference": "What is the reason for doing expunge here? This method is purely for converting the timestamp." }, { - "prediction": "I think this should be `fieldSchemas.get(i)` instead of `fieldSchemas.get(i + 1)`.", + "prediction": "I think this should be `if (!isValid)` instead of `if (!isValid ? origFieldName : sanitize(origFieldName))`", "reference": "This calls sanitize twice if the name isn't valid." }, { @@ -4275,39 +4275,39 @@ "reference": "Is there an equivalent that'd allow zero or one?" }, { - "prediction": "I think this should be `v1alpha1.CurrentRepeatResourceLITP` instead of `string(v1alpha1.ListItemsTLP)`.", + "prediction": "I think we can remove the `v1alpha1.CurrentRepeatResourceLITP` here.", "reference": "Is it possible to update/re-evaluate entire metatask object for every repeat? If we decide/need to use a repeatWith resources in let us say labelSelector(bad example) then we would have to add another logic to update those properties." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `terminal.ReadPassword` to get the private key. You can just use `syscall.Stdin` directly to read the password.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `syscall.Stdin` instead of `syscall.Stdout`.", "reference": "unnecessary conversion (from `unconvert`)" }, { - "prediction": "I'm not sure what you mean by \"universe_size\" and \"kvsname\" in this context. I'm not sure what you mean by \"pmi_fd\" and \"pmi_rank\" in this context. I'm not sure what you mean by \"pmi_size\" in this context. I'm not sure what you mean by \"result\" in this context. I'm not sure what you mean by \"universe_size\" and \"kvsname\" in this context. I'm not sure what you mean by \"val\" in this context. I'm not sure what you mean by \"pmi_fd\" and \"pmi_rank\" in this context. I'm not sure what you mean by \"pmi_size\" in this context. I'm not sure what you mean by \"result\" in this context. I'm not sure what you mean by \"universe_size\" and \"kvsname\" in this context. I'm not sure what you mean by \"kvsname\" in this context. I'm not sure what you mean by \"val\" in this context. I'm not sure what you mean by \"pmi_fd\" and \"pmi_rank\" in this context. I'm not sure what you mean", + "prediction": "I think this should be `pmi_fd` instead of `pmi_fd[16]`.", "reference": "typo in commit message `openening`" }, { - "prediction": "I think this should be `#include \"adios2.h\"` instead of `#include \"adios2/engine/hdf5/HDF5ReaderP.h\"`.", + "prediction": "I think this should be `#include ` instead of `#include \"adios2.h\"`.", "reference": "User-code doesn't see the internal ADIOS headers anymore. This whole include block should just be `#include `" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to test that the user can only see their own buckets, but I'm not sure what you're trying to test here.", + "prediction": "I'm not sure I understand what you're trying to do here.", "reference": "nit: I guess we can omit this (unless you had a reason to specify it)" }, { - "prediction": "I think this should be `if c.leaf.remote != nil && !c.leaf.remote.Hub` instead of `if c.leaf.remote != nil && !c.leaf.remote.Hub`", + "prediction": "I think it's better to return `false` here, since we don't know if the leaf node is a hub or not.", "reference": "Why is Hub public?" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I think we should remove the `appendENITrunkingCapabilities` and `appendDockerDependentCapabilities` calls.", + "prediction": "I'm not sure what you mean by \"appendENITrunkingCapabilities\" and \"appendDockerDependentCapabilities\"", "reference": "why is this deleted?" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to add a `prerequisite` link to the top of the page. I'm not sure what you're trying to do here, but it looks like you're trying to add a `prerequisite` link to the top of the page. I'm not sure what you're trying to do here, but it looks like you're trying to add a `prerequisite` link to the top of the page. I'm not sure what you're trying to do here, but it looks like you're trying to add a `prerequisite` link to the top of the page. I'm not sure what you're trying to do here, but it looks like you're trying to add a `prerequisite` link to the top of the page. I'm not sure what you're trying to do here, but it looks like you're trying to add a `prerequisite` link to the top of the page. I'm not sure what you're trying to do here, but it looks like you're trying to add a `prerequisite` link to the top of the page. I'm not sure what you're trying to do here, but it looks like you're", + "prediction": "I'm not sure what you mean by \"have you done the Intro to Rails tutorial?\"", "reference": "Maybe move that into a partial" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use a temporary file in this way.", "reference": "Error return value of `dao.Stop` is not checked (from `errcheck`)" }, { @@ -4315,15 +4315,15 @@ "reference": "util.Warning()? Easier to say." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `select` here.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `hasState` here. It's not clear to me if this is the right place to do this, but I think it would be good to add a check for `hasState` here. It's not clear to me if this is the right place to do this, but I think it would be good to add a check for `hasState` here. It's not clear to me if this is the right place to do this, but I think it would be good to add a check for `hasState` here. It's not clear to me if this is the right place to do this, but I think it would be good to add a check for `hasState` here. It's not clear to me if this is the right place to do this, but I think it would be good to add a check for `hasState` here. It's not clear to me if this is the right place to do this, but I think it would be good to add a check for `hasState` here. It's not clear to me if this is the right place to do this, but I think it", "reference": "this default is kinda superfluous (although i see it was already there before PR )" }, { - "prediction": "I don't think this is necessary. The `parentNode` field is not used anywhere in the code, so it can be removed.", + "prediction": "I don't think this is necessary.", "reference": "How is this related?" }, { - "prediction": "I don't think this is necessary. The `@team_plans` should be the same as the `@plans` in the `new` action.", + "prediction": "I don't think this is necessary. We can just use `@team_plans = TeamPlan.featured.ordered` instead of `@team_plans = TeamPlan.featured.active.ordered`", "reference": "I'm breaking one of the rules here, it feels like the right thing to do. Open to alternative suggestions." }, { @@ -4331,11 +4331,11 @@ "reference": "The use of `#should` was triggering an rspec depracation warning for me, which is why I switched this to the rspec 3 style." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I don't think it's a good idea.", "reference": "Why are you setting the CacheChange as REQUESTED when it is not valid (it was erased from history)?" }, { - "prediction": "I'm not sure what you're trying to do with this, but it looks like you're trying to use `isEmpty` in a way that doesn't make sense. I'm not sure what you're trying to do with this, but it looks like you're trying to use `isEmpty` in a way that doesn't make sense. I'm not sure what you're trying to do with this, but it looks like you're trying to use `isEmpty` in a way that doesn't make sense. I'm not sure what you're trying to do with this, but it looks like you're trying to use `isEmpty` in a way that doesn't make sense. I'm not sure what you're trying to do with this, but it looks like you're trying to use `isEmpty` in a way that doesn't make sense. I'm not sure what you're trying to do with this, but it looks like you're trying to use `isEmpty` in a way that doesn't make sense. I'm not sure what you're trying to do with this, but it looks like you're trying to use `isEmpty` in a way that doesn't make sense. I'm not sure what you're trying to do with this, but it looks like you", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a `data-testid` to the `AnalyticsDashboardWidgetTopLevel` component so that it can be used in the `AnalyticsDashboardWidget` component as well.", "reference": "`lodash` shouldn't be grouped under WordPress dependencies" }, { @@ -4343,7 +4343,7 @@ "reference": "This needs to be public so that Avro can call it." }, { - "prediction": "`isUndefined` and `isNull` are deprecated. Use `isUndefined` and `isNull` instead of `isUndefined` and `isNull` instead of `isUndefined` and `isNull` instead of `isUndefined` and `isNull` instead of `isUndefined` and `isNull` instead of `isUndefined` and `isNull` instead of `isUndefined` and `isNull` instead of `isUndefined` and `isNull` instead of `isUndefined` and `isNull` instead of `isUndefined` and `isNull` instead of `isUndefined` and `isNull` instead of `isUndefined` and `isNull` instead of `isUndefined` and `isNull` instead of `isUndefined` and `isNull` instead of `isUndefined` and `isNull` instead of `isUndefined` and `isNull` instead of `isUndefined` and `isNull` instead of `isUndefined` and `isNull` instead of `isUndefined` and `isNull` instead of `isUndefined` and `isNull` instead of `isUndefined` and `isNull` instead of `isUndefined` and `isNull` instead of `", + "prediction": "I don't think we need to use `isUndefined` or `isNull` in this case.", "reference": "`Google*` shouldn't be under External dependencies - seems like ESlint is not properly recognizing that these are aliases to internal dependencies." }, { @@ -4351,31 +4351,31 @@ "reference": "I think he meant the docstring in this constructor. yea we should fix" }, { - "prediction": "I think we should remove the `switch` statement here, as it's not really needed.", + "prediction": "I think we should remove the `switch` statement here.", "reference": "so .. this basically follows the pattern from JapaneseTokenizer, I think. .. but somehow I don't see where we defined ResourceScheme? We're not referencing the one in kuromoji, right?" }, { - "prediction": "I think this should be `SecurityProtocolType.Tls12` instead of `Tls13`?", + "prediction": "I think this should be `ServicePointManager.SecurityProtocol = SecurityProtocolType.Tls11 | SecurityProtocolType.Tls12 | Tls13;`", "reference": "It would probably be better to do: const SecurityProtocolType Tls13 = (SecurityProtocolType)12288" }, { - "prediction": "I'm not sure what you're trying to do with this, but it looks like you're trying to update the `value` property of the `labs` object. I think you meant to update the `value` property of the `labs` object, not the `created_at` and `updated_at` properties. Also, I'm not sure what you're trying to do with this, but it looks like you're trying to update the `value` property of the `labs` object. I think you meant to update the `value` property of the `labs` object, not the `created_at` and `updated_at` properties. Also, I'm not sure what you're trying to do with this, but it looks like you're trying to update the `value` property of the `labs` object. I think you meant to update the `value` property of the `labs` object, not the `created_at` and `updated_at` properties. Also, I'm not sure what you're trying to do with this, but it looks like you're trying to update the `value` property of the `labs` object. I think you meant to update the `value` property of the `labs` object, not the `", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to update the `created_at` and `updated_at` fields, but I don't think you want to do that. You want to update the `created_by` and `updated_by` fields, right?", "reference": "Similar to the above, put this setting back but keep the value as `'{}'`" }, { - "prediction": "I'm not sure what you're trying to achieve with this code, but it looks like you're trying to refresh the continuous aggregates for the year 2021. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to refresh the continuous aggregates for the year 2021. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to refresh the continuous aggregates for the year 2021. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to refresh the continuous aggregates for the year 2021. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to refresh the continuous aggregates for the year 2021. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to refresh the continuous aggregates for the year 2021. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to refresh the continuous aggregates for the year 2021. I'm not sure what you're trying to achieve with", + "prediction": "I think we can remove the `init_db_connection` call here, as it's not needed anymore.", "reference": "As discussed in chat - we should run this function within an app context which means that we'd already have a logger configured, and a connection to timescale set up" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a `data-target` attribute to the `#about-content` div.", + "prediction": "I don't think this is needed anymore.", "reference": "I'm curious about why this needed to be removed." }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. Is it possible that you're trying to do something like this:\r\n\r\n```python\r\nfrom scapy.config import conf\r\nfrom scapy.base_classes import BasePacket,BasePacketList\r\nfrom scapy.utils import do_graph,hexdump,make_table,make_lined_table,make_tex_table,get_temp_file\r\n\r\nfrom scapy.consts import plt, MATPLOTLIB_INLINED, MATPLOTLIB_DEFAULT_PLOT_KARGS\r\nfrom scapy.extlib import plt, MATPLOTLIB_INLINED, MATPLOTLIB_DEFAULT_PLOT_KARGS\r\nfrom functools import reduce\r\nimport scapy.modules.six as six\r\nfrom scapy.modules.six.moves import filter, range, zip\r\n\r\nfrom scapy.base_classes import BasePacket,BasePacketList\r\nfrom scapy.utils import do_graph,hexdump,make_table,make_lined_table,make_tex_table,get_temp_file\r\n\r\nfrom scapy.consts import plt, MATPLOTLIB_INLINED, MATPLOTLIB_DEFAULT_PLOT_KARGS\r\nfrom scapy.extlib import plt, MATPLOTLIB_INLINED, MATP", + "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. Is it that you want to use `plt` in your code? If so, I think it's better to use `matplotlib` instead.", "reference": "why did you remove `zip`? It is used!" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `BrokerStatus` struct, so that it can be used in other places as well.", + "prediction": "I think this should be `MarkTopicReady` instead of `MarkTopicUnknown`?", "reference": "Is there any reason that we don't add a similar condition like `ChannelConditionTopic` to the channel?" }, { @@ -4383,51 +4383,51 @@ "reference": "before php8 \"goto\" was a reserved word and was not allowed as part of the namespace. Now test checks for validity of plugin namespace according to PSR-4" }, { - "prediction": "I think this should be `newSingleOutbound(t, address, options...)` instead of `newSingleOutbound(t, address, options...OutboundOption)`.", + "prediction": "I think it's better to use `newSingleOutbound` instead of `newSingleOutboundWithTLS`.", "reference": "nit: I'm not sure it can be addressed in this diff, but it seems odd that NewOutbound supports TLS but NewSingleOutbound does not. As a somewhat naive user I would expect the only difference between these two APIs is how peers are chosen." }, { - "prediction": "I think this should be `return nil, yarpcerrors.InvalidArgumentErrorf(\"request for http oneway outbound was nil\")` instead of `return nil, yarpcerrors.InvalidArgumentErrorf(\"request for http oneway outbound was nil\")`", + "prediction": "I'm not sure why we need to close the response body here. I think we can just return the response body directly.", "reference": "I would advise to enhance the test for the method `CallOneway` - we should have a test very similar to `TestCallSuccess`. We should test: - Success with response (even if it is callOneway) - Success with no response and empty payload - Errors" }, { - "prediction": "I'm not sure what you're trying to achieve with this pattern, but I think it's a good idea to use a regular expression to validate email addresses. This way, you don't have to worry about escaping special characters and you can easily modify the regular expression if you need to.", + "prediction": "I don't think we need to change the regex here.", "reference": "We're already matching +. Not sure why this changed." }, { - "prediction": "I'm not sure what you mean by \"sonata.classification.manager.category\". Is this the same as \"sonata.classification.manager.category_manager\"?", + "prediction": "I don't think this is needed anymore. The `category_manager` should be set to `null` if you want to define your own category manager.", "reference": "Please add line breaks, so the line doesn't exceed 80 chars." }, { - "prediction": "I think this should be `null` instead of `new HttpInListener(\"Microsoft.AspNetCore\", options, activitySource)`.", + "prediction": "I think we should remove the `null` from the `HttpInListener` constructor argument.", "reference": "I initially thought (inccoreclty) this is a breaking change! The public api analyzer is a gift!" }, { - "prediction": "`g_hash_table_new_full` should be `g_hash_table_new_with_hash`", + "prediction": "`g_hash_table_new_full (g_str_hash, g_str_equal, g_free, (GDestroyNotify)g_ptr_array_unref);` should be `g_hash_table_new_full (g_str_hash, g_str_equal, g_free, g_free);`", "reference": "I'm not sure how this one didn't segfault before." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a test that uses the `kubeIPVSEnabled` variable, but it's not clear what you're trying to do with it.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `Config{}` here. It's not clear what you're trying to do here.", "reference": "Same points as in other test file." }, { - "prediction": "I think this should be `CharsetDecoder` instead of `Charset`", + "prediction": "I think this should be `java.nio.charset.StandardCharsets.UTF_8` instead of `java.nio.charset.StandardCharsets.UTF_16LE`.", "reference": "Did you run gradlew tidy? Wildcard imports shouldn't be there, hence the question." }, { - "prediction": "I'm not sure what you mean by \"decorates its component\". It's not a component, it's a Trail.", + "prediction": "I'm not sure what you mean by \"decorates its component\". It's just an instance of `TrailWithProgress`, right?", "reference": "Put a comma after the last parameter of a multiline method call." }, { - "prediction": "I think this should be `FPGA_IFC_DFL` instead of `FPGA_IFC_ALL`.", + "prediction": "I think this should be `res = fpgaPropertiesSetInterface(*filter, FPGA_IFC_DFL);` instead of `res = fpgaPropertiesSetInterface(*filter, FPGA_IFC_DFL); ON_FPGAINFO_ERR_GOTO(res, out, \"setting type to FPGA_IFC_DFL\");`", "reference": "Is this going to restrict the output to *ONLY* ports that are bound to vfio-pci? That's not what we discussed yesterday." }, { - "prediction": "I'm not sure what you're trying to do here, but I think it's a bit of a red herring.", + "prediction": "I'm not sure what you're trying to do with this, but I think it's a bit of a red herring. The `VerifySignature` function is used to verify that the signature is valid, but it doesn't actually do anything with the signature itself. It just checks that the signature is valid and that the signer has the right to sign the data.", "reference": "Intention is to do the lookup here, I believe (where we can cache it). This would make the call non-pure function though. I'll confirm with lotus. ID addresses are the *only* addresses I expect to actually see here." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to run the EMRFS command as a job step on an EMR cluster, but I'm not sure what you're trying to do here. I think you're trying to run the EMRFS command as a job step on an EMR cluster, but I'm not sure what you're trying to do here. I think you're trying to run the EMRFS command as a job step on an EMR cluster, but I'm not sure what you're trying to do here. I think you're trying to run the EMRFS command as a job step on an EMR cluster, but I'm not sure what you're trying to do here. I think you're trying to run the EMRFS command as a job step on an EMR cluster, but I'm not sure what you're trying to do here. I think you're trying to run the EMRFS command as a job step on an EMR cluster, but I'm not sure what you're trying to do here. I think you're trying to run the EMRFS command as a job step on an EMR cluster, but I'm not sure what you're trying to do here", + "prediction": "I'm not sure what you mean by \"SSH to run the commands manually\". Is it possible to run EMRFS commands from the command line?", "reference": "electronic medical record file system (EMRFS)" }, { @@ -4435,15 +4435,15 @@ "reference": "Put this higher in the list, like after \"bind\", since I guess we're considering the max request body size to be kind of a native/fundamental feature, built directly into the vhosts." }, { - "prediction": "I think we can remove the `ErrImageForbidden` and `ErrMinerNotFound` from the `ErrDealNotFound` and `ErrTaskNotFound` messages.", + "prediction": "I think we can remove the `ErrImageForbidden` and `ErrMinerNotFound` here.", "reference": "oh come on :(" }, { - "prediction": "I think this should be `if (result.isPresent()) {` instead of `if (result.isPresent()) { return result.get(); }`", + "prediction": "I think this should be `if (result.isPresent())` instead of `if (result.isPresent()) { ... }`", "reference": "This is an incorrect change. The dialect spoken is an important part of the handshake and should be communicated to users." }, { - "prediction": "I think this should be `str: str` instead of `str: GCP project id` and `str: GCP Authenticated user` instead of `str: GCP Authenticated user`.", + "prediction": "I think it's better to use `utils.run_command` instead of `subprocess.run` here.", "reference": "Remove as this is not needed anymore." }, { @@ -4451,43 +4451,43 @@ "reference": "This new class is for checking that #4551 works correctly with PlantUML output too." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to add a `defaultIssuerGroup` field to the `Issuer` struct. This will allow us to specify the default issuer group when creating a new `Issuer`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `certs` field of the `Issuer` struct.", "reference": "Will this cause all certificates to be re-issued?" }, { - "prediction": "I think it's better to use `tmp` instead of `metric_name` in this case.", + "prediction": "I don't think we need to free tmp here.", "reference": "I think tmp is also leaked at the end of this loop if no error cases are encountered." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check here to make sure that the schema of the element is the same as the schema of the array.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to make sure that the schema of the element is the same as the schema of the array.", "reference": "The previous version didn't use `keyProjection` because the entire key must be projected. If the key is a struct of multiple columns, then projecting a subset of those columns can easily introduce key collisions that aren't in the original data." }, { - "prediction": "I think we can remove the `if (!status.ok())` here.", + "prediction": "I don't think we need to do this.", "reference": "Why not use StatusOr ? We can't ensure spaceId is greater than zero, especially when AdHocSchemaManager is used." }, { - "prediction": "`jrpc` is not used in this PR, so we can remove it.", + "prediction": "`jrpc` is not used anywhere in this PR, so I think it's safe to remove it.", "reference": "Does it seem we only use that as the json-rpc client? Do we have any other choice? It's a little weird." }, { - "prediction": ".ROLE_MENUBUTTON, controlTypes.ROLE_TREEVIEW, controlTypes.ROLE_CHECKMENUITEM, controlTypes.ROLE_RADIOMENUITEM)\n \t\t):\n \t\t\treturn self.PRESCAT_LAYOUT\n \n```\nReview comment?", + "prediction": ".ROLE_MENUBUTTON, controlTypes.ROLE_TREEVIEW, controlTypes.ROLE_CHECKMENUITEM, controlTypes.ROLE_RADIOMENUITEM)\n \t\t):\n \t\t\t# This is just layout as far as the user is concerned.\n \t\t\treturn self.PRESCAT_LAYOUT\n \n```\nReview comment?", "reference": "Could you split this into multiple lines?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but it looks like you're trying to create a `CloseableIterable` from a `CloseableIterable` and a `List` of `CloseableIterable`s. Is this what you're trying to achieve with this change?", + "prediction": "`ImmutableMap` should be `ImmutableMap.Builder` instead of `ImmutableMap`.", "reference": "Doesn't the snapshot ID start off as null? It seems like we don't need to set it here." }, { - "prediction": "I'm not sure what you're trying to achieve with this. It seems like you're trying to do a longest prefix match on the trie, but I'm not sure what you're trying to achieve with this.", + "prediction": "I'm not sure I understand what you're trying to do here. The `lookupPath` function returns a slice of `V4TrieEntry`s, but the `root.lookupPath` function returns a slice of `V4TrieEntry`s. What is the difference between the two?", "reference": "I wondered why `buffer` was passed into `LookupPath`. What is happening here? Is `buffer[:0]` equivalent to `[]V4TrieEntry{}`, and hence `buffer` isn't needed any more?" }, { - "prediction": "I'm not sure what you mean by `stateView` and `sigValidator` here. Could you please clarify?", + "prediction": "I'm not sure if this is the right place to do this, but I think it would make sense to do this in the state view.", "reference": "nit: Ideally we would would use this abstraction everywhere we need this translation. I believe it's needed in the mining worker and the storage and market connectors." }, { - "prediction": "I think it's better to use `UpdateHash` instead of `common.CalculateHash` in this case.", + "prediction": "I think we should remove the `if GetHash(cStorPoolGot) == \"\"` check.", "reference": "need to fix the error message here" }, { @@ -4495,7 +4495,7 @@ "reference": "Unsure of how to handle this one." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `FlowRunner` class.", + "prediction": "I think it's better to use `isKilled()` instead of `isFinished()`.", "reference": "Will this.flowFinished verify with every finished state stated in Status.isStatusFinished method? If so, no need to verify isKilled." }, { @@ -4503,15 +4503,15 @@ "reference": "replace \"Child Workflow\" with \"any workflow\"" }, { - "prediction": "I think it's better to use `{{- if .IsSymlink -}}` instead of `{{- if .IsDir -}}`.", + "prediction": "I think it's better to use `{{- if .IsSymlink }}` instead of `{{- if .IsDir }}`.", "reference": "Instead of showing the words \"symbolic link\" under the \"Size\" column, how about we introduce new icons for symbolic link to file and symbolic link to directory?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the `DateRange` class as well.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a method to the `DateRange` class that takes a `SolrDateRange` object and returns a `SolrDateRange` object. This way, we can use the `SolrDateRange` object directly in the `decodeFilter` method, and we don't need to create a new `SolrDateRange` object every time we call `decodeFilter`.", "reference": "Please add back the description of the parameter" }, { - "prediction": "I don't think we need to use `this` here.", + "prediction": "I don't think this is necessary. The `completerPanel` should be in the `graphite` panel.", "reference": "Superfluous space inserted." }, { @@ -4519,11 +4519,11 @@ "reference": "Didn't fix the problem. `href=\"\"` for SVG will still result in `undefined` getting returned by this function." }, { - "prediction": "I'm not sure what you're trying to achieve with this test case. It seems like you're trying to test the `bearing_before` and `bearing_after` properties of the `Route` object, but I'm not sure what you're trying to achieve with this test case. Could you please provide more context or clarify what you're trying to achieve with this test case?", + "prediction": "I'm not sure I understand what you're trying to do with this test case. It seems like you're trying to test that the `bearing_before` and `bearing_after` fields are correctly set when the `type` is `depart`, but I'm not sure if that's what you're trying to test here.", "reference": "This seems like a strange change ... I wouldn't think that a change to access tags in the profiles would result in different bearings in this tests?" }, { - "prediction": "I think it's a good idea to move the review cursor to the end of the focus object. This way, the focus object will always be at the end of the focus object, and the cursor will always be at the end of the focus object.", + "prediction": "I think it's a good idea to move the review cursor to the end of the focus object. This way, the cursor will always be at the end of the focus object, regardless of whether the focus object is in the middle or at the end.", "reference": "As isCaret is False by default, explicitly specifying isCaret=False here is not needed, and is perhaps a little confusing. I'd prefer that anywhere in the codebase that isCaret is only ever specified if it needs to be set to true. Mirroring that of isFocus for setNavigatorObject." }, { @@ -4539,19 +4539,19 @@ "reference": "Why not put two other routes after this line (221)?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a new `metaClient_` object and pass it to `metaClient_->init()`, but I don't think that's what you want to do.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that `metaClient_` is not `nullptr` before calling `metaClient_->init()`.", "reference": "If FLAGS_meta_server_addrs is not empty, in which case \"toHosts\" return empty array?" }, { - "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to set the `JSONBoolWithQuotes` property of the `Settings` object to `true`. Is that what you're trying to do?", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be better to put it in a separate file.", "reference": "There is a function to output a \"JSONBool\" string. That would be a good start for finding uses. But maybe just have a look at where we decide whether it is a numerical or not, thus wrapping quotes around its value. Then you have it all I guess." }, { - "prediction": "I think this should be `data._kdf._internal.copy(sdf=sampled)` instead of `data._kdf._internal.copy(sdf=sampled, scol=scol)`.", + "prediction": "I think this should be `data._kdf._internal.copy(sdf=sampled, scol=scol)` instead of `data._kdf._internal.copy(sdf=sampled).to_pandas()`.", "reference": "oops, it should be `data._scol` so that it respects the expression stored in Series. Let me fix it quick." }, { - "prediction": "I'm not sure what you mean by \"test plans are set to private visibility by default\"", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `administerable_by?` method to check if the user has the ability to view the plan. This way, we don't need to check if the user has the ability to view the plan, and we don't need to check if the user has the ability to view the plan, and we don't need to check if the user has the ability to view the plan, and we don't need to check if the user has the ability to view the plan, and we don't need to check if the user has the ability to view the plan, and we don't need to check if the user has the ability to view the plan, and we don't need to check if the user has the ability to view the plan, and we don't need to check if the user has the ability to view the plan, and we don't need to check if the user has the ability to view the plan, and we don't need to check if the user has the ability to view the plan, and we don't need to check if the user has the ability to view the plan, and we don't need to check if the user", "reference": "Thanks for moving this up with the rest of the variables. Much tidier :)" }, { @@ -4559,75 +4559,75 @@ "reference": "I think `Rate` is a more precise and concise term for `PaymentPerTime`." }, { - "prediction": "I think this should be `if (limit < 0)` instead of `if (limit < posNext)`.", + "prediction": "I'm not sure what you mean by \"is it because description starts with a label, or because + mode is implied?\" I'm not sure what you mean by \"is it because description starts with a label, or because + mode is implied?\" I'm not sure what you mean by \"is it because description starts with a label, or because + mode is implied?\" I'm not sure what you mean by \"is it because description starts with a label, or because + mode is implied?\" I'm not sure what you mean by \"is it because description starts with a label, or because + mode is implied?\" I'm not sure what you mean by \"is it because description starts with a label, or because + mode is implied?\" I'm not sure what you mean by \"is it because description starts with a label, or because + mode is implied?\" I'm not sure what you mean by \"is it because description starts with a label, or because + mode is implied?\" I'm not sure what you mean by \"is it because description starts with a label, or because + mode is implied?\" I'm not sure what you mean by \"is it because description starts with a label, or because + mode is implied?\" I'm not sure what you", "reference": "I think this should maybe be: var limit = input.IndexOfAny(new[] { '+', '-', ']' }, **posNext**); You pretty much want to ignore any sign that is before the \"M\". But, if there is a sign somewhere before the M, and also after the M, you'd want to be able to find the sign after the M, right?" }, { - "prediction": "I think it's better to use `ConfigQuery::checkAvailableStock()` instead of `ConfigQuery::checkAvailableStock()` in this case.", + "prediction": "I think it's better to use `ConfigQuery::checkAvailableStock()` instead of `ConfigQuery::checkAvailableStock()`", "reference": "if `checkStockNotEmpty` returns a reponse, you must return it or your script will continue its execution." }, { - "prediction": "I'm not sure if this is a good idea, but I think we should use `klogv2` instead of `klog`.", + "prediction": "I'm not sure if this is a good place to put it, but I think we should move it to `k8s.io/klog/v2` so that we can use the `klogv2` package in other places as well.", "reference": "Any specific reason for this change? klog should work correctly here." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to update the `last_modified` field of the record with the same `id`, `parent_id`, and `collection_id` as the record being updated. I'm not sure what you're trying to do here, but it looks like you're trying to update the `last_modified` field of the record with the same `id`, `parent_id`, and `collection_id` as the record being updated. I'm not sure what you're trying to do here, but it looks like you're trying to update the `last_modified` field of the record with the same `id`, `parent_id`, and `collection_id` as the record being updated. I'm not sure what you're trying to do here, but it looks like you're trying to update the `last_modified` field of the record with the same `id`, `parent_id`, and `collection_id` as the record being updated. I'm not sure what you're trying to do here, but it looks like you're trying to update the `last_modified` field of the record with the same `id`, `parent_id`, and `collection_id` as the record being updated. I", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to update the `last_modified` field, but you're also trying to update the `last_modified` field with the `last_modified` field from the previous record. I think you want to update the `last_modified` field with the `last_modified` field from the current record.", "reference": "we don't mention `last_modified` here?" }, { - "prediction": "I'm not sure what you're trying to do with this, but it looks like you're trying to use `hyperx` to create a custom icon. I'm not sure what you're trying to do with this, but it looks like you're trying to use `hyperx` to create a custom icon. I'm not sure what you're trying to do with this, but it looks like you're trying to use `hyperx` to create a custom icon. I'm not sure what you're trying to do with this, but it looks like you're trying to use `hyperx` to create a custom icon. I'm not sure what you're trying to do with this, but it looks like you're trying to use `hyperx` to create a custom icon. I'm not sure what you're trying to do with this, but it looks like you're trying to use `hyperx` to create a custom icon. I'm not sure what you're trying to do with this, but it looks like you're trying to use `hyperx` to create a custom icon. I'm not sure what you're trying to do with this, but it looks like you're trying to use `hyperx` to create a custom icon.", + "prediction": "I think we should use `localIcon` instead of `hyperx` here.", "reference": "same deal about the global state maybe interfering as in ActionBrowseTagline" }, { - "prediction": "I'm not sure what you mean by \"wrong capacity number at constructor\"", + "prediction": "I'm not sure what you mean by \"wrong capacity number at constructor\". I'm not sure what you mean by \"wrong capacity number at constructor\". I'm not sure what you mean by \"wrong capacity number at constructor\". I'm not sure what you mean by \"wrong capacity number at constructor\". I'm not sure what you mean by \"wrong capacity number at constructor\". I'm not sure what you mean by \"wrong capacity number at constructor\". I'm not sure what you mean by \"wrong capacity number at constructor\". I'm not sure what you mean by \"wrong capacity number at constructor\". I'm not sure what you mean by \"wrong capacity number at constructor\". I'm not sure what you mean by \"wrong capacity number at constructor\". I'm not sure what you mean by \"wrong capacity number at constructor\". I'm not sure what you mean by \"wrong capacity number at constructor\". I'm not sure what you mean by \"wrong capacity number at constructor\". I'm not sure what you mean by \"wrong capacity number at constructor\". I'm not sure what you mean by \"wrong capacity number at constructor\". I'm not sure what you mean by \"wrong capacity number at constructor\". I'm not sure what you mean by \"wrong capacity number at constructor\". I", "reference": "so sweet to see a test as the first thing" }, { - "prediction": "I think this should be `config->http_proxy` instead of `config->http_proxy = getenv(\"HTTP_PROXY\");`", + "prediction": "I think it's better to set `config->http_proxy` to `NULL` if it's not set in the environment.", "reference": "usually when HTTP_PROXY=\"\" (empty), proxy should be disabled. could you set it to NULL when it's empty string?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do it.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `computeBox` method, since it's the only place where the `width` and `height` settings are used.", "reference": "Can you throw an exception if width or height are both null" }, { - "prediction": "I'm not sure what you're trying to achieve with this. It's not clear what you're trying to achieve with this. It's not clear what you're trying to achieve with this. It's not clear what you're trying to achieve with this. It's not clear what you're trying to achieve with this. It's not clear what you're trying to achieve with this. It's not clear what you're trying to achieve with this. It's not clear what you're trying to achieve with this. It's not clear what you're trying to achieve with this. It's not clear what you're trying to achieve with this. It's not clear what you're trying to achieve with this. It's not clear what you're trying to achieve with this. It's not clear what you're trying to achieve with this. It's not clear what you're trying to achieve with this. It's not clear what you're trying to achieve with this. It's not clear what you're trying to achieve with this. It's not clear what you're trying to achieve with this. It's not clear what you're trying to achieve with this. It's not clear what you're trying to achieve with this. It's not clear what you're trying to", + "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a separate `HTTPSchemeKey` for `http` and `https` so that we don't have to use `HTTPSchemeKey.String(\"http\")` and `HTTPSchemeKey.String(\"https\")` everywhere.", "reference": "This is a breaking change. I guess these might have been intentionally exported." }, { - "prediction": "`splitSize` should be `splitSize` instead of `splitSize`", + "prediction": "I don't think we need to do this.", "reference": "I don't think this is necessary. When options are used to set the split size in the Spark reader, it uses `TableProperties.SPLIT_SIZE` to pass it here. That should work for metadata tables as well, right? The situation that we need to handle in this PR is setting the default, like you had before. We just want to use a metadata split size so you can set it and not have the same split size used (by default) for both metadata and data scans." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think we need to change anything.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to add a new operator to the `operators` map. If you want to add a new operator, you should add it to the `operators` map in the `main.go` file.", "reference": "wait a sec, shouldn't this be `'*'`?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `buildDaisyVars` function, since it's called by the `buildDaisy` function.", + "prediction": "I don't think we need to do this. We can just use `oi.params.MachineImageName` and `oi.params.InstanceNames` in the `buildDaisyVars` function.", "reference": "It think you'll want the var for GMI import as well: daisy_workflows/ovf_import/create_gmi.wf.json (Unfortunately there's duplication between the two :/ )" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a `GET_CONTEXT` command to the `RemoteConnection` class. This way, we don't have to create a separate `FirefoxRemoteConnection` class for the `GET_CONTEXT` command, and we don't have to create a separate `FirefoxRemoteConnection` class for the `SET_CONTEXT` command. This way, we can have a single `FirefoxRemoteConnection` class that can be used for both `GET_CONTEXT` and `SET_CONTEXT` commands, and we can have a single `FirefoxRemoteConnection` class that can be used for both `GET_CONTEXT` and `ELEMENT_GET_ANONYMOUS_CHILDREN` commands.", + "prediction": "I don't think this is a good idea. The `GET_CONTEXT` and `ELEMENT_GET_ANONYMOUS_CHILDREN` commands should be in the `commands.py` file, not in the `RemoteConnection.py` file.", "reference": "Nit: Group this with the other commands by moving it down one line." }, { - "prediction": "I think this should be `null` instead of `DictionaryDecodeMode.NONE`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the `DictionaryDecodeMode` is set to `DictionaryDecodeMode.NONE` in this case. This is because the `DictionaryDecodeMode` is used to determine how the dictionary is decoded. If the `DictionaryDecodeMode` is set to `DictionaryDecodeMode.NONE`, then the dictionary will not be decoded, which is what we want here.", "reference": "I would like to emphasize that a user can use non-vectorized reads to handle this file so maybe something like \"Cannot perform a vectorized read of ParquetV2 File with encoding %s, disable vectorized reading with $param to read this table/file\"" }, { - "prediction": "I'm not sure if this is the right place to put it, but I think it should be in the `__init__` method of the `RangeBase` class.", + "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to have a `param_name` parameter in the `RangeBase` class. This way, you can pass in a `param_name` parameter when creating a `RangeBase` instance, and it will be used to pass in the parameterized value for the `param_name` parameter in the `RangeBase` class. This way, you don't have to pass in the `param_name` parameter every time you create a `RangeBase` instance, and it will be consistent across all the `RangeBase` instances created from the same `RangeBase` class.", "reference": "Maybe add `positional=False`. It does not need it more than the other parameters, but one must start somewhere." }, { - "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `rsWithPrimaryPath` and `rsWithoutPrimaryPath` for this test.", + "prediction": "I'm not sure if this is the right place to put this test, but I think it would be good to have a test for this case as well.", "reference": "Since we're here, can we use a template?" }, { - "prediction": "I'm not sure if this is a good idea or not, but I think it's worth a try. I don't think it's a good idea to have a long runtime delay before each containerized solid executes. I think it's better to have a short runtime delay before each containerized solid executes. I think it's better to have a short runtime delay before each containerized solid executes. I think it's better to have a short runtime delay before each containerized solid executes. I think it's better to have a short runtime delay before each containerized solid executes. I think it's better to have a short runtime delay before each containerized solid executes. I think it's better to have a short runtime delay before each containerized solid executes. I think it's better to have a short runtime delay before each containerized solid executes. I think it's better to have a short runtime delay before each containerized solid executes. I think it's better to have a short runtime delay before each containerized solid executes. I think it's better to have a short runtime delay before each containerized solid executes. I think it's better to have a short runtime delay before each containerized solid executes. I think it's better to have a short runtime delay before each container", + "prediction": "I'm not sure if this is a good idea or not. I don't think we need to do this.", "reference": "saw you're also doing this in `test_types.py`: `spark = _spark_context()['test'].resources['spark'].resource_fn(None)` since `_spark_context()` uses `spark_session_local` won't the above break the tests?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a profile with a selector of `default == ''` and an action of `allow`, but I'm not sure what you're trying to achieve with that.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `api.EntityRuleSelector` for the `default == ''` case.", "reference": "`has(default)` i think is the preferred way of doing this" }, { @@ -4635,11 +4635,11 @@ "reference": "always put a space after a comma" }, { - "prediction": "I'm not sure what you mean by \"selectAllPhotosUpToFav\" and \"selectAllPhotosUpTo\"", + "prediction": "I don't think this is needed anymore.", "reference": "@angmas1 move the else up, next to the closing bracket of the if block. Also, there is no need for the braces as your else statement contains only a single line. Make your if-else block similar to the block in lines 277-280." }, { - "prediction": "I'm not sure I understand what you're trying to do here. What is the purpose of the `keep_alive` parameter? What is the purpose of the `file_detector` parameter? What is the purpose of the `options` parameter? What is the purpose of the `command_executor` parameter? What is the purpose of the `desired_capabilities` parameter? What is the purpose of the `browser_profile` parameter? What is the purpose of the `proxy` parameter? What is the purpose of the `keep_alive` parameter? What is the purpose of the `file_detector` parameter? What is the purpose of the `options` parameter? What is the purpose of the `command_executor` parameter? What is the purpose of the `desired_capabilities` parameter? What is the purpose of the `browser_profile` parameter? What is the purpose of the `proxy` parameter? What is the purpose of the `keep_alive` parameter? What is the purpose of the `file_detector` parameter? What is the purpose of the `options` parameter? What is the purpose of the `command_executor` parameter? What is the purpose of the `desired_capabilities` parameter? What is the purpose of the `browser_profile` parameter? What is the purpose of the `", + "prediction": "I'm not sure what you mean by \"keep_alive=False\" and \"file_detector=None\"", "reference": "@AutomatedTester @davehunt thoughts on a new keyword argument?" }, { @@ -4647,11 +4647,11 @@ "reference": "This change shouldn't be necessary for this PR. Please remove it." }, { - "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to", + "prediction": "I'm not sure what you're trying to do here, but I think it's a bad idea to use `framework.NewTestCtx(t)` in this case.", "reference": "This variable is mostly unused, how about we make `NewTestCtx` return a pointer?" }, { - "prediction": "I think we can remove the `maxPayloadLen` constant, since it's not used anywhere else in the code.", + "prediction": "I think we can remove the `maxPayloadLen` constant. It's not used anywhere in the code.", "reference": "What is the basis of this value?" }, { @@ -4663,11 +4663,11 @@ "reference": "nit: inconsistent spacing around =" }, { - "prediction": "I'm not sure if this is the right place to add this, but I think it should be in Sonata\\MediaBundle\\Model\\MediaInterface.", + "prediction": "I don't think this is needed anymore.", "reference": "We still need this import" }, { - "prediction": "I'm not sure what you mean by \"throwing an `UnsupportedOperationException`\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `TableTestBase` class, so that it can be used by other tests as well.", "reference": "We are pulling this because we removed \"groupID\" state and put it into the strategy implementations" }, { @@ -4675,15 +4675,15 @@ "reference": "Is this file actually related to PCA?" }, { - "prediction": "I'm not sure what you're trying to achieve with this config, but I think it's a good idea to remove the `isFirstAdmin` and `isOwner` fields.", + "prediction": "I don't think we need to add `isFirstAdmin` to the config.", "reference": "See above, this should probably remain `isFirstAdmin`." }, { - "prediction": "I think this should be `MonoType` instead of `MonoType`", + "prediction": "I think this should be `MonoArrayExpression` instead of `MonoType`.", "reference": "Why the change to make it public? The expression interface has the `TypeOf` method?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `Rolls` property on the `Target` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a separate unit test.", "reference": "don't mind the snake cases in the test names. If there are in the test cases, it's fine IMO" }, { @@ -4691,7 +4691,7 @@ "reference": "`Id` defines REST resource address and should not be in payload" }, { - "prediction": "I don't think this is a good idea. We should be able to use `--class_wise` in the same way as `--top_k` and `--top_p`.", + "prediction": "I don't think we need to use `args.class_wise` here.", "reference": "We can omit the underscore and just use `classwise`." }, { @@ -4699,83 +4699,83 @@ "reference": "Why not throw an exception instead then?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to move this into the `InputFile` class.", + "prediction": "I don't think this is necessary.", "reference": "Looks like this doesn't need to change. Can you revert this?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to keep the `template` variable in the `config.py` file. This way, we can use the `template` variable in the `pserve` command.", + "prediction": "I'm not sure if this is a good place to put it, but I think we should move it to the top of the file.", "reference": "please import it like `from kinto.config import template`" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make this configurable.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.", "reference": "There are lots of default value changed, not sure if it break the old behavior." }, { - "prediction": "`peerstore` is not used in this PR, so we can safely remove it.", + "prediction": "`peerstore` is not used anywhere in this PR, so it should be removed. Also, I don't think we need to use `google.golang.org/grpc` for this PR.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate module for adding/removing peers.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a separate module, so that it can be used by other modules as well.", "reference": "parameter should be called removeFromStaticNodes" }, { - "prediction": "I don't think we need to add `override` to the decorator.", + "prediction": "I don't think we need to change anything here.", "reference": "The handler will have an extra property in the marker to signal the implementation is in the provider, for the cases we want to add functionality, for example, custom implementations not in moto." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you're trying to achieve with this method, but I think it's a bad idea to have a `deactivate` and `activate` method in the `Subscription` class. It's better to have a `deactivate` method in the `Notifier` class and a `activate` method in the `Subscription` class.", "reference": "Is this method actually being used anywhere? If not, I think we should remove it." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to flatten the type of the parameter, but I'm not sure what you're trying to do here. I think you're trying to flatten the type of the parameter, but I'm not sure what you're trying to do here. I think you're trying to flatten the type of the parameter, but I'm not sure what you're trying to do here. I think you're trying to flatten the type of the parameter, but I'm not sure what you're trying to do here. I think you're trying to flatten the type of the parameter, but I'm not sure what you're trying to do here. I think you're trying to flatten the type of the parameter, but I'm not sure what you're trying to do here. I think you're trying to flatten the type of the parameter, but I'm not sure what you're trying to do here. I think you're trying to flatten the type of the parameter, but I'm not sure what you're trying to do here. I think you're trying to flatten the type of the parameter, but I'm not sure what you're trying to do here. I think you're trying to flatten the type of", + "prediction": "I think this should be `bodyParameterType.ComposedProperties.Count(p => !p.IsConstant && !p.IsReadOnly) <= Settings.Instance.PayloadFlatteningThreshold`", "reference": "Thanks! I somehow lost this between my far too many branchs." }, { - "prediction": "I don't think we need to change the `__init__` method of `RemoteWebDriver` to `__init__` of `FirefoxRemoteConnection` because the `__init__` method of `RemoteWebDriver` is already defined in `__init__` of `FirefoxRemoteConnection`.", + "prediction": "I don't think we need to change the `__init__` method of `RemoteWebDriver` to `__init__` of `FirefoxRemoteConnection`.", "reference": "i think this should get put into its own file. This could start to grow :)" }, { - "prediction": "I'm not sure what you mean by `pauseContainerImage` and `pauseContainerName`. I think you meant `pauseContainerImage` and `pauseContainerName`.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `Task` struct, since it's used in both `Task` and `TaskOverride` structs.", "reference": "Can you add a TODO for loading the tarball of the pause image into Docker?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `ProcessJob` class, so that it can be used in other places as well.", + "prediction": "I'm not sure what you mean by \"unsuccessfully\"", "reference": "Is there any value in setting the process to null like this?" }, { - "prediction": "I'm not sure if this is a good place to put this, but I think we should move this to `SoftmaxWithLossLayer::Reshape` as well.", + "prediction": "I'm not sure if this is a good place to put this, but I think we should move it to the `SoftmaxWithLossLayer::Reshape` function.", "reference": "This could be a good time to add a check that the prediction and target dimensions (except channel) agree?" }, { - "prediction": "I'm not sure what you mean by \"i#1314\"", + "prediction": "I think this should be `else if (instr_get_opcode(bb->instr) == OP_getsec)` instead of `else if (instr_get_opcode(bb->instr) == OP_isb)`.", "reference": "The requirement that OP_isb is bb-final needs to be a rule for clients, just like the rule that syscalls and interrupts must be bb-final: i.e., please add it to the dr_register_bb_event() docs." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `Globalize.translate` function here.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `Globalize.translate` here.", "reference": "The translate library has a method to replace the variables." }, { - "prediction": "I think this test should be moved to `test_series` instead of `test_series_fillna`.", + "prediction": "I think we can remove this test as it's not needed anymore.", "reference": "i don't think this test case is correct. in both cases inpalce=True returns nothing. We need to compare the ks. Also we probably need to make a copy of it. Otherwise you pollute the following \"ks\" because ks has been changed." }, { - "prediction": "I think this should be `contextlib.redirect_stderr(f)` instead of `contextlib.redirect_stdout(f)`.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `contextlib.redirect_stdout` in this way.", "reference": "Any proposals how to make the naming somehow include the \"completed\" idea of this hook? `TlsHandshakeCompletedHook` or similar? Or using the `...Start/End...` scheme?" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to update the `FullSyncBlocksDownloaded` and `FullSyncBlocksKnown` fields in the `SyncReport` object. I'm not sure what you're trying to achieve with this, but it looks like you're trying to update the `FullSyncBlocksDownloaded` and `FullSyncBlocksKnown` fields in the `SyncReport` object. I'm not sure what you're trying to achieve with this, but it looks like you're trying to update the `FullSyncBlocksDownloaded` and `FullSyncBlocksKnown` fields in the `SyncReport` object. I'm not sure what you're trying to achieve with this, but it looks like you're trying to update the `FullSyncBlocksDownloaded` and `FullSyncBlocksKnown` fields in the `SyncReport` object. I'm not sure what you're trying to achieve with this, but it looks like you're trying to update the `FullSyncBlocksDownloaded` and `FullSyncBlocksKnown` fields in the `SyncReport` object. I'm not sure what you're trying to achieve with this, but it looks like you're trying to update the `FullSync", + "prediction": "I think this should be `if (headersSynced > 0)` instead of `if (headersSynced > 0 && _syncReport.FullSyncBlocksDownloaded.Update(_blockTree.BestSuggestedHeader?.Number ?? 0);`", "reference": "it introduces a lot of complexity to the state, can we flush straightaway or create a two level flush store where the questions are read form unflushed data?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is it possible that you're trying to do something like this: `JSTree::url('collection', $node->id);`?", + "prediction": "I'm not sure I understand what you're trying to do here, but I think it's a bit confusing. I think you're trying to do something like this: `JSTree::getUrlFromRouteCache('collection', $node->id)`, but I don't think that's what you're trying to do. I think you're trying to do something like this: `JSTree::getUrlFromRouteCache('record', $node->id)`, but I don't think that's what you're trying to do. I think you're trying to do something like this: `JSTree::getUrlFromRouteCache('collection', $node->id)`, but I don't think that's what you're trying to do. I think you're trying to do something like this: `JSTree::getUrlFromRouteCache('record', $node->id)`, but I don't think that's what you're trying to do. I think you're trying to do something like this: `JSTree::getUrlFromRouteCache('collection', $node->id)`, but I don't think that's what you're trying to do. I think you're trying to do something like this: `JSTree::getUrlFrom", "reference": "There are two calls to getUrlFromRouteCache, but you're only urlencoding one of them. Is that intentional? Would it make more sense to do the url-encoding inside the getUrlFromRouteCache function?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good place to do this.", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `this.activeEditor.row` and `this.activeEditor.col` instead of `this.activeEditor.row` and `this.activeEditor.col` and `this.activeEditor.originalValue` and `this.activeEditor.cellProperties`.", "reference": "Maybe we can use `this.instance.getCell` with `topMost` flag to get `TD` element?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `actpool` struct.", + "prediction": "I don't think we need to return an error here.", "reference": "Change this to Debug Level" }, { @@ -4783,11 +4783,11 @@ "reference": "I refactored the Aggregate, those are hard to read" }, { - "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `checkEvaluate.apply(checkContext, checkArgs);` instead of `checkEvaluate.apply(checkContext, checkArgs); checkEvaluate.apply(checkContext, checkArgs); checkEvaluate.apply(checkContext, checkArgs); checkEvaluate.apply(checkContext, checkArgs); checkEvaluate.apply(checkContext, checkArgs); checkEvaluate.apply(checkContext, checkArgs); checkEvaluate.apply(checkContext, checkArgs); checkEvaluate.apply(checkContext, checkArgs); checkEvaluate.apply(checkContext, checkArgs); checkEvaluate.apply(checkContext, checkArgs); checkEvaluate.apply(checkContext, checkArgs); checkEvaluate.apply(checkContext, checkArgs); checkEvaluate.apply(checkContext, checkArgs); checkEvaluate.apply(checkContext, checkArgs); checkEvaluate.apply(checkContext, checkArgs); checkEvaluate.apply(checkContext, checkArgs); checkEvaluate.apply(checkContext, checkArgs); checkEvaluate.apply(checkContext, checkArgs); checkEvaluate.apply(checkContext, checkArgs); checkEvaluate.apply(checkContext, checkArgs); checkEvaluate.apply(checkContext, checkArgs); checkEvaluate.apply(checkContext, checkArgs); checkEvaluate.apply(checkContext, checkArgs); checkEvaluate.apply(checkContext, checkArgs); checkEvaluate", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this.", "reference": "This is now done in the after method, so this test won't pass any more." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you're trying to do here, but I think it's a bit confusing. If you want to check if the user has been banned, you should use `@user.banned?` instead of `@user.blocks.active.exists?`.", "reference": "What was the point of creating `user_block` if you're then not going to use it ;-)" }, { @@ -4795,87 +4795,87 @@ "reference": "@ueshin, I thought we can remove this entire file. Does that require some more works?" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to convert a string to a float, but you're not handling the case where the string is a boolean. If you want to convert a string to a float, you should use `float(tokens.string)`. If you want to convert a boolean to a string, you should use `unicode(tokens.string)`.", + "prediction": "I'm not sure I understand what you're trying to do here. I think you want something like this: `return unicode(tokens.string)[1:-1]` or `return str(tokens.string)[1:-1]` or `return unicode(tokens.string)[1:-1]` or `return unicode(tokens.string)[1:-1]` or `return unicode(tokens.string)[1:-1]` or `return unicode(tokens.string)[1:-1]` or `return unicode(tokens.string)[1:-1]` or `return unicode(tokens.string)[1:-1]` or `return unicode(tokens.string)[1:-1]` or `return unicode(tokens.string)[1:-1]` or `return unicode(tokens.string)[1:-1]` or `return unicode(tokens.string)[1:-1]` or `return unicode(tokens.string)[1:-1]` or `return unicode(tokens.string)[1:-1]` or `return unicode(tokens.string)[1:-1]` or `return unicode(tokens.string)[1:-1]` or `return unicode(tokens.string)[1:-1]` or `return unicode(tokens.string)[1:-1]` or `return unicode(tokens.string)[1:-1]` or `return unicode(tokens.string)[", "reference": "Just `return tokens.string[1:-1]` is enough" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to show all the questions in a quiz, but you're only showing the questions that are associated with the current quiz.", + "prediction": "I don't think this is necessary. The `show` resource is already defined in the `quizzes` resource, so we don't need to define it again.", "reference": "1 trailing blank lines detected." }, { - "prediction": "Shouldn't this be `Double.MAX_VALUE` instead of `Double.MAX_VALUE`?", + "prediction": "Shouldn't this be `Double.MAX_VALUE` instead of `Double.MAX_VALUE + 1000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", "reference": "Isn't this the default max width? In any case I would prefer to see these definitions in the css files." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think we need to do anything here.", + "prediction": "I don't think we need to do this. The `httpserver.GetConfig` function returns a `httpserver.Config` struct, which has a `Scheme` field, so we can just use that.", "reference": "Is this thread-safe? (If not, and if the solution is to introduce locking, let's reconsider how we do the scheme changing instead...)" }, { - "prediction": "I'm not sure what you're trying to achieve with `kfold_random` but I don't think this is a good idea.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to `datatable.lib._datatable` as well.", "reference": "Looks like this file has tabs instead of spaces." }, { - "prediction": "I'm not sure if this is the best place to do this, but I think it's a good idea to do this in the `deleteTask` method.", + "prediction": "I think this should be `if execcmd.IsExecEnabledTask(task) {` instead of `if execcmd.IsExecEnabledTask(task) {`", "reference": "Hmm should we clean up container resources before task resources here? or the order does not really matter here?" }, { - "prediction": "I think this should be `quteproc.send_cmd(':download-cancel --all')` instead of `quteproc.send_cmd(':download-cancel --all')`", + "prediction": "I think we can remove the `@bdd.given(\"I clean old downloads\")` here.", "reference": "Please undo this :wink:" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to generate a client_id and client_secret based on the client_id and client_secret being nil. I'm not sure what you're trying to achieve with this, but it looks like you're trying to generate a client_id and client_secret based on the client_id and client_secret being nil. I'm not sure what you're trying to achieve with this, but it looks like you're trying to generate a client_id and client_secret based on the client_id and client_secret being nil. I'm not sure what you're trying to achieve with this, but it looks like you're trying to generate a client_id and client_secret based on the client_id and client_secret being nil. I'm not sure what you're trying to achieve with this, but it looks like you're trying to generate a client_id and client_secret based on the client_id and client_secret being nil. I'm not sure what you're trying to achieve with this, but it looks like you're trying to generate a client_id and client_secret based on the client_id and client_secret being nil. I'm not sure what you're trying to achieve with this, but it looks like you're trying to generate", + "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bad idea to use `Proc.new { |c| c.client_id.blank? || c.client_secret.blank? }` in this case. The `blank?` method returns `true` if the value is `nil` or `false` if the value is not `nil`. If the value is `nil`, the `blank?` method will return `true`. If the value is `false`, the `blank?` method will return `false`. If the value is `true`, the `blank?` method will return `false`. If the value is `false`, the `blank?` method will return `false`. If the value is `true`, the `blank?` method will return `true`. If the value is `false`, the `blank?` method will return `false`. If the value is `nil`, the `blank?` method will return `true`. If the value is `false`, the `blank?` method will return `false`. If the value is `true`, the `blank?` method will return `true`. If the value is `false`, the `blank?` method will return `false`.", "reference": "thanks for adding this missing association" }, { - "prediction": "Shouldn't this be `UseKestrelHttps` instead of `UseKestrelHttps(new HttpsConnectionFilterOptions { ServerCertificate = cert });`?", + "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `UseKestrelHttps` method on an `IApplicationBuilder` that already has a `KestrelServerInformation` attached to it. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `UseKestrelHttps` method on an `IApplicationBuilder` that already has a `KestrelServerInformation` attached to it. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `UseKestrelHttps` method on an `IApplicationBuilder` that already has a `KestrelServerInformation` attached to it. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `UseKestrelHttps` method on an `IApplicationBuilder` that already has a `KestrelServerInformation` attached to it. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `UseKestrelHttps` method on an `IApplicationBuilder` that already has a `KestrelServerInformation`", "reference": "Should I remove this in favor of the HttpsConnectionFilterOptions overload?" }, { - "prediction": "I think this should be `self::STATUS_TABLE` instead of `DbalStatusQuery::STATUS_TABLE`.", + "prediction": "I don't think this is needed anymore.", "reference": "This shode be nullable, there alway sholud be at least one status in system , if not exist that mean data problme" }, { - "prediction": "I think this should be in the `auth` controller, not in the `Auth` class.", + "prediction": "I don't think we need to add the JS file to unistall SW.", "reference": "Spaces not tabs" }, { - "prediction": "I'm not sure what you mean by \"always overwrite destination\". I think you mean that if the destination already exists, you should delete it and create a new one.", + "prediction": "I'm not sure what you mean by `fs.readdirSync(path, {withFileTypes: true}).map(e => e.name); // From Node v10`", "reference": "To get the files inside a directory, please use `readDirStats()`." }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it's a good idea to have a `TestContainerDocker` and a `TestContainerNone` in the `Configuration` struct.", + "prediction": "I think this should be `ContainerImplementation` instead of `ContainerImplementationNone` and `ContainerImplementationDocker` instead of `ContainerImplementationDocker` and `ContainerImplementationPlz` instead of `ContainerImplementationPlz`.", "reference": "might be worth to call these `Isolation` instead of containers here and when presented to the user -- docker/rkt , in addition to cgroups and namespaces, also provide image discovery and filesystem preparation; there's also the security context and probably 1-2 other small things" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's better to have a separate package for the `batchstore` package. It's not clear to me what the purpose of the `batchstore` package is, and I don't think it makes sense to have a separate package for the `batchstore` package.", + "prediction": "I don't think this is necessary.", "reference": "File is empty, consider removing?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `get_registry_url()` instead of `get_registry_url()` and `get_registry_url()` instead of `get_registry_url()`. This is because `get_registry_url()` will return the same value for both `get_registry_url()` and `get_registry_url()`, and `get_registry_url()` will return the same value for both `get_registry_url()` and `get_registry_url()`. This is because `get_registry_url()` will return the same value for both `get_registry_url()` and `get_registry_url()`, and `get_registry_url()` will return the same value for both `get_registry_url()` and `get_registry_url()`. This is because `get_registry_url()` will return the same value for both `get_registry_url()` and `get_registry_url()`, and `get_registry_url()` will return the same value for both `get_registry_url()` and `get_registry_url()`. This is because `get_registry_url()` will return the same value for both `get_registry_url()` and `get_registry_url()`, and `get_registry_url()` will return the same value for both `get_registry_url()` and `get_registry_url", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `canonical_name` field in the `QuiltProvider` class.", "reference": "This seems to return the registry_url. The more meaningful URL is the catalog URL, which is the URL the user specifies in `quilt3.login`. The username might also be as useful here if not more useful." }, { - "prediction": "I'm not sure what you mean by \"turns on checking of state for L2 gas price\". I think you meant to say \"turns off checking of state for L2 gas price\" or \"does not check state for L2 gas price\".", + "prediction": "I'm not sure what you mean by \"turns on checking of state for L2 gas price\". I think you mean that you want to check the state of the L2 gas price, but I'm not sure what you mean by \"turns on checking of state for L2 gas price\". I think you mean that you want to check the state of the L2 gas price, but I'm not sure what you mean by \"turns on checking of state for L2 gas price\". I think you mean that you want to check the state of the L2 gas price, but I'm not sure what you mean by \"turns on checking of state for L2 gas price\". I think you mean that you want to check the state of the L2 gas price, but I'm not sure what you mean by \"turns on checking of state for L2 gas price\". I think you mean that you want to check the state of the L2 gas price, but I'm not sure what you mean by \"turns on checking of state for L2 gas price\". I think you mean that you want to check the state of the L2 gas price, but I'm not sure what you mean by \"turns on checking of state for", "reference": "Was the addition of `GasPriceOracleAddress` here erroneous?" }, { - "prediction": "I'm not sure what you mean by `:host_tags` and `:created_by` in this context. I think you meant `:project`, `:department`, and `:created_by` in this context.", + "prediction": "I'm not sure what you mean by \"unknown\" in this case. I think it should be `:unknown` instead of `:unknown`", "reference": "I believe that you are going to have to do some work here to get the env var support for these values to still work correctly, otherwise they will get stored as :department instead of host_tags[:department]." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.", "reference": "How was this causing the exception?" }, { - "prediction": "I'm not sure if this is a good place to put this, but I think we should move it to `connectionManager.js` so that it can be used by other parts of Jellyfin.", + "prediction": "I'm not sure if this is the best place to do this, but I think it's a good idea to make sure that the translations are loaded in the first place, so that we don't have to load them every time we need to use them.", "reference": "I still have issues with it loading Simplified Chinese by default over Japanese, since they also share characters and we're not sure if characters are different or not. As-is, this fixes Traditional Chinese and Simplified Chinese, but we're not sure if it'd still screw up Japanese text or not. I maintain that, in my opinion, Japanese should be the only script of this kind loaded by default (Because of Hiragana and Katakana, that aren't shared with any other script) and either variant of Chinese should be loaded only in their respective case." }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a `@Override` to the `visitLeaf` method. This way, we don't have to worry about adding a `@Override` to the `visit` method, and we don't have to worry about adding a `@Override` to the `visit` method, and we don't have to worry about adding a `@Override` to the `visit` method, and we don't have to worry about adding a `@Override` to the `visit` method, and we don't have to worry about adding a `@Override` to the `visit` method, and we don't have to worry about adding a `@Override` to the `visit` method, and we don't have to worry about adding a `@Override` to the `visit` method, and we don't have to worry about adding a `@Override` to the `visit` method, and we don't have to worry about adding a `@Override` to the `visit` method, and we don't have to worry about adding a `@Override` to the `visit` method, and we don't have to worry about adding a", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be better to move it to `IntervalsSource` instead of `MultiTermIntervalsSource`.", "reference": "Isn't it better to stub AtomatonQuery and yield it here. IIRC it resolves simplest MTQ highlighting cases as nobrainer." }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason why you want to round the result of `round(0)` to 0?", + "prediction": "I think this should be `@discounted_plan.price_in_dollars` instead of `@discounted_plan.price`", "reference": "Line is too long. [96/80]" }, { @@ -4883,15 +4883,15 @@ "reference": "My only concern with changing the node selector here is that someone else _could_ have built their own images for other platforms and set them to be used using the flag override on the controller, which in turn this change would break. Perhaps not changing the selector for acmesolver pods makes most sense, and then working on actually having support for Windows? wdyt?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to add a new field to the `v1alpha1.Object` struct, but I'm not sure if that's the best way to do it.", + "prediction": "I don't think we need to add `Selector` to `v1alpha1.Object`", "reference": "Why do we need interface `InnerObjectWithSelector`, I searched the usage with this field, it seems nowhere use `GetSelectorSpecs()` methods provided by `InnerObjectWithSelector`" }, { - "prediction": "I don't think we need to do this. We can just use the `MsgCtxTypeChannel` directly.", + "prediction": "I don't think we need to do this, since we already have `MsgCtxTypeChannel` in the `init` function.", "reference": "Do we need this `init` here? We have already called the `InitContext` in `StartModule` directly." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `execute` method of the `WebDriver` class.", "reference": "This `if` is not necessary" }, { @@ -4899,31 +4899,31 @@ "reference": "should we add a `mangle.json` mapping for this? We could reuse a property name that's only used on component or vnode objects right now, like `__s` (\"next state\")." }, { - "prediction": "I'm not sure what this is for. It's not clear what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does. I'm not sure what it does", + "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place", "reference": "Please update the yard docs to indicate this new option." }, { - "prediction": "I think we can remove the `Subnets` field since it's not used in the spec.", + "prediction": "I'm not sure what you mean by \"Subnets specifies the subnets that should be used by the load balancer\"", "reference": "Can you provide an example in the godoc section on how to use this? From the implementation it looks like the AvailabilityZone field is required for example, otherwise it can fail / error, is that correct?" }, { - "prediction": "I think this should be `sqlError.Wrap(err)` instead of `sqlError.Wrap(err.Error())`?", + "prediction": "I think this should be `sqlError.Wrap(err)` instead of `sqlError.Wrap(err, err)`?", "reference": "It would be great if this could be captured by a test." }, { - "prediction": "1*time.Second),\n+\t\tESProcessorAckTimeout: dc.GetDurationProperty(dynamicconfig.WorkerESProcessorAckTimeout, 1*time.Minute),\n \t\tESIndexMaxResultWindow: dc.GetIntProperty(dynamicconfig.FrontendESIndexMaxResultWindow, 10000),\n \t\tIndexerConcurrency: dc.GetIntProperty(dynamicconfig.WorkerIndexerConcurrency, 100),\n \t\tESProcessorNumOfWorkers: dc.GetIntProperty(dynamicconfig.WorkerESProcessorNumOfWorkers, 1),\n```\nReview comment?", + "prediction": "1*time.Second),\n+\t\tESProcessorAckTimeout: dc.GetDurationProperty(dynamicconfig.WorkerESProcessorAckTimeout, 1*time.Minute),\n \t}\n \n \treturn config\n```\nReview comment?", "reference": "1000 -> 100 maybe too much, 200 ish to 500ish maybe a good option" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `ChecksumAddress` struct that implements the `encoding.TextMarshaler` interface.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.", "reference": "Any reason we need to keep this package's `ChecksumAddress` type or can we get rid of it too?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `getIconUrl()` method to get the icon URL for the restart button.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `getIconUrl()` method to get the icon for the restart button.", "reference": "Above the one that was picked was the Button* prefix, and here it's the Header* prefix. Maybe the Button prefix is more general." }, { - "prediction": "I'm not sure what you mean by \"BestSuggestedHeader\". Is that the same as `Head`?", + "prediction": "I'm not sure what you mean by \"FindBlock\" in this context. It's not clear to me what you're trying to do with this method.", "reference": "I might prefer changing: public Block FindPendingBlock() => FindBlock(PendingHash, BlockTreeLookupOptions.None); public BlockHeader FindPendingHeader() => FindHeader(PendingHash, BlockTreeLookupOptions.None); in IBlockFinder, what do you think?" }, { @@ -4931,15 +4931,15 @@ "reference": "This is necessary due to a bug in 4.7. Follow HIVE-1561 for getting rid of it." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right way to do it.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to have `has_many :exercises, source_type: 'Exercise'` and `has_many :products, source_type: 'Product'` in the same model.", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { - "prediction": "I'm not sure what you mean by \"XStringToKeysym()\" and \"XKeysymToString()\". These functions are not part of the X11 library. They are part of the XKB library, which is not part of the X11 library. I'm not sure what you are trying to achieve with these functions.", + "prediction": "I'm not sure if this is a good place to put this, but I think it should be moved to `xkbcommon/xkbcommon.h` so that it can be used by `xkbcommon/xkbcommon.c` and `xkbcommon/xkbcommon.c` can be used by `xkbcommon/xkbcommon.c` and `xkbcommon/xkbcommon.c` can be used by `xkbcommon/xkbcommon.c` and `xkbcommon/xkbcommon.c` can be used by `xkbcommon/xkbcommon.c` and `xkbcommon/xkbcommon.c` can be used by `xkbcommon/xkbcommon.c` and `xkbcommon/xkbcommon.c` can be used by `xkbcommon/xkbcommon.c` and `xkbcommon/xkbcommon.c` can be used by `xkbcommon/xkbcommon.c` and `xkbcommon/xkbcommon.c` can be used by `xkbcommon/xkbcommon.c` and `xkbcommon/xkbcommon.c` can be used by `xkbcommon/xkbcommon.c` and `xkbcommon/xkbcommon.c` can be used by `xkbcommon/xkbcommon.c` and `", "reference": "Some day (tm) I will also get rid of that one. But today is not that day..." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to do something like this:\n\n```php\n$assets = array_map(function($asset) use ($localPath) {\n if (substr($asset, 0, 1) === '@') return $asset;\n return $localPath.$asset;\n}, $assets);\n\n$rewritePath = File::localToPublic(dirname($destination));\n```\n\nBut I'm not sure what you're trying to do here. I think you're trying to do something like this:\n\n```php\n$assets = array_map(function($asset) use ($localPath) {\n if (substr($asset, 0, 1) === '@') return $asset;\n return $localPath.$asset;\n}, $assets);\n\n$rewritePath = File::localToPublic(dirname($destination));\n```\n\nBut I'm not sure what you're trying to do here. I think you're trying to do something like this:\n\n```php\n$assets = array_map(function($asset) use ($localPath) {\n if (substr($asset, 0, 1) === '@') return $asset;\n return $localPath.$asset;\n}, $assets);\n\n$rewritePath = File", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `prepareAssets` method.", "reference": "Add a space between if and opening parenthesis please (i.e. `if (`)" }, { @@ -4947,23 +4947,23 @@ "reference": "nit: `rename` instead of `alias`?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think we need to change anything here.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the device name starts with `sda` or `sdb` or `sdc` or `sdd` or `sde` or `sdf` or `sdg` or `sdh` or `sdi` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh` or `sdh", "reference": "Per AWS docs EC instances have the root mounted at /dev/sda1. This label should be skipped." }, { - "prediction": "I'm not sure what you mean by \"default\" in this case. Is it possible that the channel is closed before the message is dispatched?", + "prediction": "I think it's a good idea to have a `default` case in the `select` block, so that if the channel is empty, we don't do anything.", "reference": "I'm not sure it is a better way to address lose message, if wait here, edge controller cant process message, event from watching api-server will be lost yet, right?" }, { - "prediction": "I think we can remove the `XStrLenField` for the `optional_name` field.", + "prediction": "I think it's better to use `XStrLenField` for the `optional_name` field instead of `XStrLenField` for the `value_size` field.", "reference": "Please keep the correct alignment, it seems broken now (at least in Github). Can you reverse the test (`if p.value_size is None`)? Also, do you want `6` when `p.value_size is None` or `x + 6`? Maybe, in that case, something like `lambda p, x: x + 6 + (0 if p.value_size is None else p.value_size)` would be easier to read. Or even easier: `lambda p, x: x + 6 + (p.value_size or 0)`." }, { - "prediction": "I think we should remove `type:\"list\"` from `StartTimeout` and `StopTimeout`.", + "prediction": "I think we should remove the `type:\"list\"` from `StartTimeout` and `StopTimeout`.", "reference": "Can we make sure ECS service treats it as int64 as well?" }, { - "prediction": "I think we should remove the `ReadOnlyEditBox` class from the `UIA` module.", + "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to get the text of a read-only edit box. I'm not sure what you're trying to do here, but it looks like you're trying to get the text of a read-only edit box. I'm not sure what you're trying to do here, but it looks like you're trying to get the text of a read-only edit box. I'm not sure what you're trying to do here, but it looks like you're trying to get the text of a read-only edit box. I'm not sure what you're trying to do here, but it looks like you're trying to get the text of a read-only edit box. I'm not sure what you're trying to do here, but it looks like you're trying to get the text of a read-only edit box. I'm not sure what you're trying to do here, but it looks like you're trying to get the text of a read-only edit box. I'm not sure what you're trying to do here, but it looks like you're trying to get the text of a read-only edit box. I'm not sure what you're trying to do here, but it", "reference": "Please follow the naming convention for variables, i.e. `windowText`." }, { @@ -4971,23 +4971,23 @@ "reference": "alias can be `cast`" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `h2o_iovec_t` struct, since it's used in the `h2o_iovec_t.h` header file.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `h2o_iovec_t.h` instead of `h2o_globalconf_t.h`.", "reference": "Let's use `%zu` instead of casting to `uint64_t` and using `PRIu64`. The alternative is to change the type of `mmap_errors` to `uint64_t`, though I'd prefer not doing that because some 32-bit platforms might not provide atomic operation support for `uint64_t`." }, { - "prediction": "I'm not sure if this is a bug or a feature. I think it's a feature, but I'm not sure if it's a bug.", + "prediction": "I'm not sure I understand what you're trying to do here. Is this something you'd like to add to the `BugPattern` class? If so, I'd be happy to review it. Otherwise, I'm not sure I understand what you're trying to do here. Is this something you'd like to add to the `BugPattern` class? If so, I'd be happy to review it. Otherwise, I'm not sure I understand what you're trying to do here. Is this something you'd like to add to the `BugPattern` class? If so, I'd be happy to review it. Otherwise, I'm not sure I understand what you're trying to do here. Is this something you'd like to add to the `BugPattern` class? If so, I'd be happy to review it. Otherwise, I'm not sure I understand what you're trying to do here. Is this something you'd like to add to the `BugPattern` class? If so, I'd be happy to review it. Otherwise, I'm not sure I understand what you're trying to do here. Is this something you'd like to add to the `BugPattern` class? If so, I'd be happy to review it.", "reference": "I recall there being a reason we had this one set only to suggeation. @carterkozak do you remember why? or is my memory getting corrupted?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `flatbuffers::StripExtension` function to strip the extension from the file name.", "reference": "This should now be made into `if (it->second.empty())` ?" }, { - "prediction": "I'm not sure what you mean by `debug.qflags_key()`, but I think you're right that it's not a good idea to call `debug.qflags_key()` directly. It's better to use `debug.qflags()` instead.", + "prediction": "I'm not sure what you mean by `debug.qflags_key`", "reference": "Do we need to worry about a race condition on this decrement (@The-Compiler)? I'm not sure how the python callbacks work, so this might not need to be something to worry about." }, { - "prediction": "I'm not sure what you mean by \"sanity check\" here. It's not a sanity check, it's a sanity test. I'm not sure what you mean by \"real propagators\" here. It's not a sanity check, it's a sanity test. I'm not sure what you mean by \"real propagators\" here. It's not a sanity check, it's a sanity test. I'm not sure what you mean by \"real propagators\" here. It's not a sanity check, it's a sanity test. I'm not sure what you mean by \"real propagators\" here. It's not a sanity check, it's a sanity test. I'm not sure what you mean by \"real propagators\" here. It's not a sanity check, it's a sanity test. I'm not sure what you mean by \"real propagators\" here. It's not a sanity check, it's a sanity test. I'm not sure what you mean by \"real propagators\" here. It's not a sanity check, it's a sanity test. I'm not sure what you mean by \"real propagators\" here. It's not a sanity check, it's a sanity test. I'm not sure", + "prediction": "I'm not sure what you mean by \"sanity check\" here. It's not a sanity check, it's a sanity test.", "reference": "Should these assert that the extracted `SpanContext` is remote?" }, { @@ -4995,19 +4995,19 @@ "reference": "typo: allow low quality matches." }, { - "prediction": "I'm not sure what you mean by \"setupDataDirAndChdir\"", + "prediction": "I'm not sure what you mean by \"setupDataDirAndChdir\". I think you meant to call `SetupDataDirAndChdir` instead.", "reference": "At some point we need to condense down and refactor our \"configs\" as we have too many in too many places and we're starting to get more illegible code. No change necessary but calling out for future reference." }, { - "prediction": "I'm not sure I understand what you're trying to do here. The `aria-hidden` attribute is only set when the element is hidden, so I don't see why you'd want to set it to `true` when the element is not hidden.", + "prediction": "I think this should be `class: classes, \"aria-hidden\": (true if aria_hidden)`, not `class: classes, \"aria-hidden\": (true if aria_hidden)`.", "reference": "Can we add the `if label` conditional to this please?" }, { - "prediction": "I don't think we need `mlflow>=0.2.0` as it's already in `pyspark>=2.4.0` and `pyspark>=3.0.0`", + "prediction": "I don't think we need `mlflow>=0.2.0` as it's already in the `pyspark>=2.4.0` dependency.", "reference": "@thunterdb, can we increase the minimal version to almost the latest ones? I was thinking people will mostly use the latest version of mlflow" }, { - "prediction": "I think it's better to use `beforeAutofill` instead of `afterAutofill`.", + "prediction": "I'm not sure I understand what you're trying to do here, but I think we should remove the `beforeAutofill` hook.", "reference": "If the last argument is going to be removed, why would we add it to the API docs? Shouldn't it be private for internal use?" }, { @@ -5015,39 +5015,39 @@ "reference": "`Intermediates` or `Intermediate`" }, { - "prediction": "I think this should be `is_displayed()` instead of `is_visible()`.", + "prediction": "I'm not sure what you mean by \"Invalid locator\". Is it because the element is not visible?", "reference": "This is not the right exception class. There is an InvalidSelectorException class that covers bad locators." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a flag to the `bootstrap` function that allows you to specify whether or not you want to read the data from the datastore or not.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a flag to indicate if we should use the datastore or the etcd.", "reference": "If this code isn't needed, it should be removed." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `doRequest` function here.", + "prediction": "I'm not sure if this is the right way to do this, but I think we should be able to do this in a single function.", "reference": "Should the `doRequest` func be a method on the `connection` type instead of passing state from the type?" }, { - "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use the same name for the environment and the project.", + "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to have a separate variable for the project name, so that we don't have to hardcode it.", "reference": "we'll probably tackle these e2e tests at the end" }, { - "prediction": "I think we can remove the `Dns.GetHostEntry` and `Dns.GetHostName` calls.", + "prediction": "I think this should be `GetHostEntry` instead of `GetHostName`?", "reference": "what is this address pointing to? what are we measuring here? I want to have a better understanding." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way", + "prediction": "I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this,", "reference": "Would it be better to pass the dependency status as the parameter into the SQL string? In case the enum value is changed in the future, we don't need to change the code here." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to add a new function to the `libdokan` package, but I'm not sure if that's the best way to go about it.", + "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", "reference": "Hah I had `gorename` failing without this too." }, { - "prediction": "I think we can remove the `libddwaf_version` from the `rules_file_path` property.", + "prediction": "I think we should remove the `null` value for `libddwaf_version`.", "reference": "maybe prefix these with `appsec_` for consistency?" }, { - "prediction": "I'm not sure why we're using `trace` here, but I think it's a good idea to use it.", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be a good idea to move this to `github.com/spiffe/spire/pkg/agent/endpoints`.", "reference": "nit: this should be down further with the other github imports" }, { @@ -5055,15 +5055,15 @@ "reference": "Why is this change necessary or related to the rest of the PR?" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the end of the class.", + "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason why you want to use the `link` property of the `IssueData` object?", "reference": "Hm, I wonder if the `see:` prefix is even necessary?" }, { - "prediction": "I'm not sure what you're trying to do with this, but it looks like you're trying to get the number of remaining minutes from the `PlaybackPositionTicks` property of the item. I'm not sure what you're trying to do with this, but it looks like you're trying to get the number of remaining minutes from the `PlaybackPositionTicks` property of the item. I'm not sure what you're trying to do with this, but it looks like you're trying to get the number of remaining minutes from the `PlaybackPositionTicks` property of the item. I'm not sure what you're trying to do with this, but it looks like you're trying to get the number of remaining minutes from the `PlaybackPositionTicks` property of the item. I'm not sure what you're trying to do with this, but it looks like you're trying to get the number of remaining minutes from the `PlaybackPositionTicks` property of the item. I'm not sure what you're trying to do with this, but it looks like you're trying to get the number of remaining minutes from the `PlaybackPositionTicks` property of the item. I'm not sure what you're trying to do with this, but it looks like you're trying to get", + "prediction": "I think this should be `item.UserData?.PlaybackPositionTicks` instead of `item.UserData?.PlaybackPositionTicksTicks`.", "reference": "This should be translated." }, { - "prediction": "I don't think this is a good idea. We should not be changing the config during training. We should only change the config if we have a reason to do so. If we don't have a reason to change the config, we should not change the config at all.", + "prediction": "I don't think we need to check for `boosting` and `metric` here. We can just check for `boosting` and `metric` in `CheckDatasetResetConfig`.", "reference": "I originally had this PR only changing the R package, but then ran into this error > Error: [LightGBM] [Fatal] Cannot change metric during training This is thrown even if you aren't actually CHANGING `metric`. I think the change here in `c_api` is closer to the desired behavior, only throwing an error if the parameter is being changed." }, { @@ -5071,15 +5071,15 @@ "reference": "These changes are just to make cli_spec a little more readable for VS Code users, as there's a bug with the Ruby plugin's syntax highlighting when you use multi-line regex literals." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the global pull secret exists before trying to load it.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the global pull secret exists before trying to load it. If it doesn't exist, we can just return an empty string.", "reference": "Shouldn't the global pull secret by in the namespace of the hive-operator? It is part of the operand." }, { - "prediction": "I'm not sure what you mean by \"boto3 converts the timestamp to datetime\"", + "prediction": "I'm not sure what you mean by \"boto3 converts the timestamp to datetime\". I think you meant to say `response['Consumer']['ConsumerCreationTimestamp'] == datetime.datetime(2020, 1, 1, 0, 0, 0, 0, tzinfo=tz.tzutc())`", "reference": "kinesis-mock applies KINESIS_LATENCY to RegisterStreamConsumer actions so I added a sleep here." }, { - "prediction": "I don't think this is a good idea. We should not upgrade the meta version if it is already V2. We should only upgrade it if it is V3 or higher.", + "prediction": "I don't think we need to update the meta version in this case. We can just set the meta version in the kv store.", "reference": "Only V1 or V3 is return from `getMetaVersionFromKV`. So where do we call `updateMetaV2ToV3`?" }, { @@ -5087,11 +5087,11 @@ "reference": "I think that V0 is missing here, which will prevent plugins that haven't been converted to work." }, { - "prediction": "I don't think this is needed anymore.", + "prediction": "I don't think we need to do this.", "reference": "Should we remove this?" }, { - "prediction": "I'm not sure what you're trying to do with this, but it looks like you're trying to create a new `containerDescriptor` struct, but you don't have a `containerDescriptor` struct defined anywhere in this file.", + "prediction": "I don't think we need to change anything in this file. The only thing that needs to be changed is the `container` struct.", "reference": "Put on top of the import." }, { @@ -5099,7 +5099,7 @@ "reference": "See above, this shouldn't be added." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new item to the `ItemMapping` enum. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new item to the `ItemMapping` enum. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new item to the `ItemMapping` enum. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new item to the `ItemMapping` enum. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new item to the `ItemMapping` enum. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new item to the `ItemMapping` enum. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new item to the `ItemMapping` enum. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new item", + "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a separate enum for `ITEM_ANGUISH_ORNAMENT_KIT` and `ITEM_FURY_ORNAMENT_KIT` instead of having a separate enum for `ITEM_ANGUISH_ORNAMENT_KIT` and `ITEM_FURY_ORNAMENT_KIT` and `ITEM_AMULET_OF_FURY` and `ITEM_FURY_ORNAMENT_KIT` and `ITEM_AMULET_OF_FURY`.", "reference": "This'll likely get fixed upstream, we should let them deal with it." }, { @@ -5115,11 +5115,11 @@ "reference": "Are you sure you really need this code here? that script will be certainly run in NVDA's main thread, and core would have already called setLanguage." }, { - "prediction": "I think we can remove the `v1.RestartPolicyOnFailure` from the `IsAppDeployed` check.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this.", "reference": "why is this changed ?" }, { - "prediction": "I'm not sure I understand what you're trying to do here.", + "prediction": "I don't think we need to test that doc's revision field is updated.", "reference": "Should this be \"the new revision value\"?" }, { @@ -5127,11 +5127,11 @@ "reference": "You have deleted :attribute" }, { - "prediction": "I don't think this is a good idea. It's not clear to me what the problem is here.", + "prediction": "I don't think we need to change the license.", "reference": "The license header should be updated to the Apache one." }, { - "prediction": "I think we can remove the `expectedOperationName` and `expectedServiceName` as they are not used in this test.", + "prediction": "I think this should be `expectedOperationName` and `expectedServiceName` instead of `expectedSpanCount` and `expectedOperationName`.", "reference": "@zacharycmontoya Is there any way to distinguish a `SocketHttpHandler` from another `HttpMessageHandler` request?" }, { @@ -5139,11 +5139,11 @@ "reference": "Not sure about this one -- did you check somehow?" }, { - "prediction": "I think this should be merged with #1248.", + "prediction": "I think this should be `@options['puppet_ver']` and `@options['facter_ver']` instead of `@options['puppet_ver_win']` and `@options['facter_ver_win']`.", "reference": "Is there a good reason to keep this at the `pe_ver_win` name now that it's per-host?" }, { - "prediction": "I don't think this is a good idea. We should use `getSupportFragmentManager()` instead of `getSupportFragmentManager()`.", + "prediction": "I don't think you need to add the `summaryProductFragment` to the adapter.", "reference": "Not in the order of display : Front, Ingredient, Nutrition here (which is the right thing), Actually displayed: Front, Nutrition, Ingredients" }, { @@ -5151,23 +5151,23 @@ "reference": "Why delete `StartTime`? This `StartTime` was used to avoid the PID was reused." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `before_teardown` hook.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to move it to the `before` block of the `teardown` block.", "reference": "My concern here, is that if the dump_puppet_log also throws then we will lose the data about the teardown_exception." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `daal::detail::integral_cast` to convert the `size_t` values to `int` values.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `dal::detail::integral_cast` here. This is because `dal::detail::integral_cast` is more efficient than `dal::detail::integral_cast`.", "reference": "Should it be `int64_t`?" }, { - "prediction": "I'm not sure what you mean by `MAX_OMMER_DEPTH`. I think it's the maximum depth of the Merkle tree that you want to solve.", + "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to move it to `PoWSolver` instead of `PoWSolverJob` since it's not used in `PoWSolverJob`.", "reference": "is this value related to something ?" }, { - "prediction": "I'm not sure what you mean by \"SendTransaction\" and \"AddTxResult\". Could you please provide more context?", + "prediction": "I'm not sure what you're trying to achieve here. The `SendTransaction` method doesn't return a value, it just returns a `ValueTask`. I think you want to return a `ValueTask<(Keccak?, AddTxResult?)>`, but I'm not sure what you're trying to achieve here.", "reference": "Add names to tuple elements ValueTask<(Keccak? Hash, AddTxResult? AddResult)>, should they both be nullable?" }, { - "prediction": "I think it's better to use `replaceAcronyms` instead of `replaceAcronymsWithUnderscores` in this case.", + "prediction": "I'm not sure what you mean by \"replaceAcronyms\"", "reference": "I think it might make more sense to do this in Name.upperCamel; it is the entry point for upper camel strings." }, { @@ -5175,67 +5175,67 @@ "reference": "Huh? The point is that a cast isn't necessary" }, { - "prediction": "I'm not sure what the point of this is, but I think it should be `InstallCRD menv.ENVKey = \"OPENEBS_IO_INSTALL_CRD\"` instead of `InstallCRD menv.ENVKey = \"OPENEBS_IO_CREATE_DEFAULT_STORAGE_CONFIG\"`", + "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to have this in the same place as `CreateDefaultStorageConfig` and `InstallCRD`.", "reference": "can we name it like `InstallV1Alpha1CRDs` ?" }, { - "prediction": "`hiveutil-created` should be `hive.openshift.io/hiveutil-created` instead of `hive.openshift.io/hiveutil-created`", + "prediction": "I don't think we need to add this label to the `hiveutil-created` annotation.", "reference": "I need something to match when creating selectorsyncsets so added this label." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get the last line of a file. I'm not sure what you're trying to do here, but it looks like you're trying to get the last line of a file. I'm not sure what you're trying to do here, but it looks like you're trying to get the last line of a file. I'm not sure what you're trying to do here, but it looks like you're trying to get the last line of a file. I'm not sure what you're trying to do here, but it looks like you're trying to get the last line of a file. I'm not sure what you're trying to do here, but it looks like you're trying to get the last line of a file. I'm not sure what you're trying to do here, but it looks like you're trying to get the last line of a file. I'm not sure what you're trying to do here, but it looks like you're trying to get the last line of a file. I'm not sure what you're trying to do here, but it looks like you're trying to get the last line of a file. I'm not sure", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate function for this.", "reference": "Isn't `nil` the default return value from an empty `rescue` clause? If that's correct, then we could just remove the `nil` line entirely as it doesn't serve a purpose." }, { - "prediction": "I'm not sure what you're trying to accomplish with this code, but it looks like you're trying to add a CORS configuration to an Amazon S3 bucket. I'm not sure what you're trying to accomplish with this code, but it looks like you're trying to add a CORS configuration to an Amazon S3 bucket. I'm not sure what you're trying to accomplish with this code, but it looks like you're trying to add a CORS configuration to an Amazon S3 bucket. I'm not sure what you're trying to accomplish with this code, but it looks like you're trying to add a CORS configuration to an Amazon S3 bucket. I'm not sure what you're trying to accomplish with this code, but it looks like you're trying to add a CORS configuration to an Amazon S3 bucket. I'm not sure what you're trying to accomplish with this code, but it looks like you're trying to add a CORS configuration to an Amazon S3 bucket. I'm not sure what you're trying to accomplish with this code, but it looks like you're trying to add a CORS configuration to an Amazon S3 bucket. I'm not sure what you're trying to accomplish with this code, but it looks like you're trying to add a CORS", + "prediction": "I'm not sure if this is the right place to add a cross-origin resource sharing (CORS) configuration to an Amazon S3 bucket.", "reference": "Simple Storage **Service**" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `PrepareCache` function as well.", + "prediction": "I think we can remove the `validIndex.Sub(r.idx.Obsolete())` line as well.", "reference": "Wouldn't that cause the obsolete indexes to be downloaded over and over again? After all these are still stored in the repository." }, { - "prediction": "I think this should be `if !message.blank?` instead of `if !message.blank?`", + "prediction": "I think this should be `if !message.blank?` instead of `if !message.blank? && !message.empty?`", "reference": "We might want to move this logic to a Plain Old Ruby Object down the road. Not a blocker." }, { - "prediction": "I'm not sure what you mean by \"positioning\" the toolbox. It's not a position, it's a position relative to the tree.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a `toolbox_` property on the `Blockly.WorkspaceSvg` object.", "reference": "move `this.toolbox_.position();` to just after line 1477. Context: the if statement on line 1472 checks whether this is a toolbox with categories, and if so it populates the toolbox. Positioning the toolbox is a reasonable followup to that, and means you don't need an extra if. You may also need to call `this.flyout_.position()` after line 1483, which is the equivalent for the non-category toolbox." }, { - "prediction": "I'm not sure what you're trying to achieve with this code, but it looks like you're trying to get a list of all the proteins in a given peptide group. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to get a list of all the proteins in a given peptide group. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to get a list of all the proteins in a given peptide group. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to get a list of all the proteins in a given peptide group. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to get a list of all the proteins in a given peptide group. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to get a list of all the proteins in a given peptide group. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to get a list of all the proteins in a given peptide group. I'm not sure what you're trying to achieve with", + "prediction": "I'm not sure if this is the best place to put this, but I think it's a good place to put it. I'm not sure if this is the best place to put it, but I think it's a good place to put it. I'm not sure if this is the best place to put it, but I think it's a good place to put it. I'm not sure if this is the best place to put it, but I think it's a good place to put it. I'm not sure if this is the best place to put it, but I think it's a good place to put it. I'm not sure if this is the best place to put it, but I think it's a good place to put it. I'm not sure if this is the best place to put it, but I think it's a good place to put it. I'm not sure if this is the best place to put it, but I think it's a good place to put it. I'm not sure if this is the best place to put it, but I think it's a good place to put it. I'm not sure if this is the best place to put it, but I think it's a good place", "reference": "Should the function above be .FirstOrDefault() instead? Otherwise, why check for null and tell ReSharper to ignore the fact that it can never be null?" }, { - "prediction": "I'm not sure what you're trying to do with this, but I'm not sure if it's a good idea to use `fetch` in this way. It's not a good idea to use `fetch` in this way. It's not a good idea to use `fetch` in this way. It's not a good idea to use `fetch` in this way. It's not a good idea to use `fetch` in this way. It's not a good idea to use `fetch` in this way. It's not a good idea to use `fetch` in this way. It's not a good idea to use `fetch` in this way. It's not a good idea to use `fetch` in this way. It's not a good idea to use `fetch` in this way. It's not a good idea to use `fetch` in this way. It's not a good idea to use `fetch` in this way. It's not a good idea to use `fetch` in this way. It's not a good idea to use `fetch` in this way. It's not a good idea to use `fetch` in this way. It's not a good idea to use `fetch` in this", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to use the `fetch` API to fetch data from a remote server. I'm not sure what you're trying to do here, but it looks like you're trying to use the `fetch` API to fetch data from a remote server. I'm not sure what you're trying to do here, but it looks like you're trying to use the `fetch` API to fetch data from a remote server. I'm not sure what you're trying to do here, but it looks like you're trying to use the `fetch` API to fetch data from a remote server. I'm not sure what you're trying to do here, but it looks like you're trying to use the `fetch` API to fetch data from a remote server. I'm not sure what you're trying to do here, but it looks like you're trying to use the `fetch` API to fetch data from a remote server. I'm not sure what you're trying to do here, but it looks like you're trying to use the `fetch` API to fetch data from a remote server. I'm not sure what you're trying to do here, but it looks like you're", "reference": "Let's not create new connection, but rather user `common.db` one" }, { - "prediction": "I think this should be `image_url('learn/learn-ralph.png')` instead of `image_path('learn/learn-ralph.png')`", + "prediction": "I think this should be `image_url('learn/learn-ralph.png')` instead of `image_url('learn/learn-ralph.png')`", "reference": "Can this use asset_path rather than defining an image_url helper?" }, { - "prediction": "This is not a function, it's a function that returns an empty string.", + "prediction": "I think this should be `always('')` instead of `always('') => ''`", "reference": "Hindley-Milner signatures don't use literal types. They explusively use types. It's deal with that" }, { - "prediction": "I think this should be `PolicyRule` instead of `OFPolicyRule`?", + "prediction": "I think it's better to have a separate struct for `PolicyRule` and `OFPolicyRule` instead of mixing them together.", "reference": "Could we just extend PolicyRule with more fields? It was originally designed as the struct required by openflow client, nested structs seem not helping. And for the name of the fields, initialism should be uppercase, OFID and NPName doesn't look good, then maybe FlowID, PolicyName.." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `functions.php` file as well. It would be a good idea to also add this to the `functions.php` file as well. It would be a good idea to also add this to the `functions.php` file as well. It would be a good idea to also add this to the `functions.php` file as well. It would be a good idea to also add this to the `functions.php` file as well. It would be a good idea to also add this to the `functions.php` file as well. It would be a good idea to also add this to the `functions.php` file as well. It would be a good idea to also add this to the `functions.php` file as well. It would be a good idea to also add this to the `functions.php` file as well. It would be a good idea to also add this to the `functions.php` file as well. It would be a good idea to also add this to the `functions.php` file as well. It would be a good idea to also add this to the `functions.php` file as well. It", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `functions.php` file as well. This way, we don't have to do this every time we want to use a function.", "reference": "I really dislike this alignment approach, as it makes identifying individual functions quite hard, but I kept consistent with the previous style. Since no sorting was evident, I pushed it to the end of the block. Meanwhile, is this supposed to be tested or meaningfully testable somehow?" }, { - "prediction": "I'm not sure what you mean by \"Order of events is important here\"", + "prediction": "I'm not sure what you mean by \"Order of events is important here\". I think it's more important that the order in which we call `handle_event`, `get_steps_to_execute`, and `is_complete` is important.", "reference": "Could also consider modifying the ActiveExecution..." }, { - "prediction": "I think this should be `safe_infer(value)` instead of `safe_infer(inferred)`?", + "prediction": "I think this should be `safe_infer` instead of `safe_infer_value`?", "reference": "Does it make sense to change that to a custom error instead of `ValueError`?" }, { - "prediction": "I'm not sure what you mean by \"missing final protocol design on if/how to determine the nominal power\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.", "reference": "I guess this will need to change soon." }, { @@ -5243,23 +5243,23 @@ "reference": "Restore this spacing - not sure why it has to be removed?" }, { - "prediction": "I don't think this is necessary. We can just use `#if defined(_WIN32)` instead of `#if defined(_POSIX_C_SOURCE)`.", + "prediction": "I don't think this is necessary. We can just use `#include ` and `#include `. I don't think this is necessary. We can just use `#include ` and `#include `. I don't think this is necessary. We can just use `#include ` and `#include `. I don't think this is necessary. We can just use `#include ` and `#include `. I don't think this is necessary. We can just use `#include ` and `#include `. I don't think this is necessary. We can just use `#include ` and `#include `. I don't think this is necessary. We can just use `#include ` and `#include `. I don't think this is necessary. We can just use `#include ` and `#include `. I don't think this is necessary. We can just use `#include <", "reference": "These defines cause issues in base.h leading to failing android builds. Locale independency is now set in multiple spots, in cmake and in base.h. The base.h uses feature test macros wrong. Feature test macros can be used to indicate that a feature should be made available. They do not guarantee that it is available. On the cmake side this is done by the check symbol macros (similar to what autoconf does). On the android side not. I would suggest removing this from base.h and define locale independent in gradle. It is available since android 21 I believe. Is there a way in gradle to set locale independent only if android api >= 21?" }, { - "prediction": "I'm not sure if this is the best place to do this, but I think it's a good idea to do this in the `Project::make` function.", + "prediction": "I'm not sure if this is the best place to do this, but I think it's a good place to do this.", "reference": "Why not delete these codes?" }, { - "prediction": "I don't think this is a good idea. We should use `metaClient_->waitForMetadReady()` instead of `metaClient_->waitForMetadReady(FLAGS_meta_client_retry_times)`.", + "prediction": "I don't think this is a good idea. We should wait for `metaClient_->waitForMetadReady()` to return `true` before starting the server.", "reference": "If pull message failed after some reties, we should ensure the storaged exit, otherwise it has risk to loss data." }, { - "prediction": "I think we can remove `from datatable import f, stype, ltype, first, count` and just use `f`, `stype`, `ltype`, `first`, and `count` directly.", + "prediction": "I think we can remove `from datatable import f, stype, ltype, first, count` and just use `from datatable import f, ltype, first, count`", "reference": "looks like you don't need to import first and count here anymore" }, { - "prediction": "I think we should remove the `if len(tasks) > 0` check.", + "prediction": "I think we can remove the `if len(tasks) > 0` check here.", "reference": "FYI, visibility task processing is local only, meaning pushing something to local ES cluster / local archival endpoint" }, { @@ -5271,11 +5271,11 @@ "reference": "1. Nit: We can have a general helper to identify if a region is pseudo region. We might already have one somewhere. 2. Does any type of ARN support FIPS? If not, we may just move this check in arn package?" }, { - "prediction": "I'm not sure what you mean by \"stubber factory not implemented\". It's not a stubber factory, it's a stubber class.", + "prediction": "I'm not sure if this is a good idea, but I think it's better to have a separate stubber factory than to have a stubber factory that depends on another stubber factory.", "reference": "is this phrase completed in a next line? Or forgot to add... what?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `total_epochs` parameter in the `default_runtime.py` file. This way, we can set the `total_epochs` in the `train.py` file, and it will be used in the `default_runtime.py` file as well.", + "prediction": "I don't think this is necessary.", "reference": "`('train', 5)` and `('train', 1)` are actually the same." }, { @@ -5287,7 +5287,7 @@ "reference": "Would it be more performant to just `include ::RSpec::Core::Pending` here? /cc @myronmarston" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `map[string]int64` for the `Instances` field. You can just use `map[string]int64` for the `ChaosStatus` field.", + "prediction": "I don't think we need this field. It's not used anywhere.", "reference": "Should be podiochaos?" }, { @@ -5295,27 +5295,27 @@ "reference": "Is the `codecs.register(lambda name: None)` gracefully handled by codecs? The lambda is expected to return a tuple of functions (encoder, decoder, stream_reader, stream_writer) (or a CodecInfo object), according to the docs. I've only checked python's built-in help, though." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check here to make sure that the instrument name is valid before adding it to the list of instrument names.", + "prediction": "I don't think this is a good idea. We should always check if the instrument name is valid before adding it to the metric stream names.", "reference": "in this case, it could be either instrument name or the view name, which could be invalid. might be better if we can offer very specific message. (not blocking this, we can add this as a follow up,if needed)" }, { - "prediction": "I think this should be `setParameter('name', nameOrHandle)` instead of `setParameter(paramName, nameOrHandle)`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would make sense to move it to the `execute` method of the `WebDriver` class.", "reference": "I'd rather just send the parameter twice than break encapsulation here. There's already precedence with webelement IDs" }, { - "prediction": "I don't think this is a good idea. We should use `backbone=dict(backbone=dict(type='Res2Net', depth=101, scale=4, base_width=26))` instead of `backbone=dict(backbone=dict(type='Res2Net', depth=101, scale=4, base_width=26))`", + "prediction": "I don't think we need to change the `pretrained` to `pretrained_26w_4s_mmdetv2-f0a600f9.pth` because the `pretrained_26w_4s_mmdetv2-f0a600f9.pth` is the same as `pretrained_26w_4s_mmdetv2-f0a600f9.pth`.", "reference": "You may put 'open-mmlab://res2net101_v1d_26w_4s' here. MMCV will be updated later." }, { - "prediction": "I think we should use `STRATEGY_MOBILE` and `DATA_SRC_LAB` instead of `STRATEGY_DESKTOP` and `DATA_SRC_FIELD`.", + "prediction": "I think it's better to use `data-source` instead of `data-source-lab`.", "reference": "May be worth making this more specific, to avoid potential conflicts, maybe `pagespeedDashboardWidget`? Or `webVitalsDashboardWidget`?" }, { - "prediction": "I'm not sure what you're trying to do with this, but I think it's a bad idea to use `this.uppy.emit('upload-error', file, err)` in this context. It's not clear what you're trying to do with this, but I think it's a bad idea to use `this.uppy.emit('upload-error', file, err)` in this context. It's not clear what you're trying to do with this, but I think it's a bad idea to use `this.uppy.emit('upload-error', file, err)` in this context. It's not clear what you're trying to do with this, but I think it's a bad idea to use `this.uppy.emit('upload-error', file, err)` in this context. It's not clear what you're trying to do with this, but I think it's a bad idea to use `this.uppy.emit('upload-error', file, err)` in this context. It's not clear what you're trying to do with this, but I think it's a bad idea to use `this.uppy.emit('upload-error', file, err)` in this context. It's not clear what you're trying to do with this, but I think", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this", "reference": "I guess this assignment is now redundant?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the blockNum is synced with the blockNum of the block that the RPC was forwarded to.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the blockNum is synced with the blockNum of the block that the RPC was called on.", "reference": "See above note re: blockNum synchronization." }, { @@ -5323,11 +5323,11 @@ "reference": "wonder if we could avoid doing named imports if we type aliased `backoff.Backoff` in the `.../agent/common/backoff` package?" }, { - "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to use the `disassemble` function to disassemble an instruction. However, the `disassemble` function is not defined anywhere in the codebase. It seems like you're trying to use it in a way that doesn't make sense or isn't part of the codebase.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to add a new instruction to the instruction set, but I'm not sure if that's the best way to go about it. It's possible that there are better ways to achieve the same goal.", "reference": "Or maybe put into alphabetical order with the other #includes." }, { - "prediction": "I'm not sure what you're trying to achieve with this code. It looks like you're trying to watch a file for changes, but I'm not sure what you're trying to achieve with this code. Could you please provide more context or explain what you're trying to achieve with this code?", + "prediction": "I don't think we need to use a ticker here. We can just use a goroutine to poll the file.", "reference": "This runs the entire duration of the program; this change is not needed." }, { @@ -5335,19 +5335,19 @@ "reference": "I don't feel well about the `ALWAYS_UPDATE` option   sounds like a workaround. I can imagine that some of the plugins want to observe all options. Maybe, in that case, we can reuse the `CONFIG_KEYS` that would return an empty array for observing all settings and `false` for disabling observing at all? I just thinking aloud - Like `CONFIG_KEYS` sounds reasonable. We could support and maintain it in the future, even after implementing the \"observability\" to the MetaManager then `ALWAYS_UPDATE` ... I don't know :)" }, { - "prediction": "I'm not sure what you mean by \"bug is fixed\" here. I'm not sure if this is a bug or not. I'm not sure if this is a bug or not. I'm not sure if this is a bug or not. I'm not sure if this is a bug or not. I'm not sure if this is a bug or not. I'm not sure if this is a bug or not. I'm not sure if this is a bug or not. I'm not sure if this is a bug or not. I'm not sure if this is a bug or not. I'm not sure if this is a bug or not. I'm not sure if this is a bug or not. I'm not sure if this is a bug or not. I'm not sure if this is a bug or not. I'm not sure if this is a bug or not. I'm not sure if this is a bug or not. I'm not sure if this is a bug or not. I'm not sure if this is a bug or not. I'm not sure if this is a bug or not. I'm not sure if this is a bug or not. I'm not sure if this is a bug or not. I", + "prediction": "I'm not sure if this is a good idea, but I don't think it's a big deal. I'm not sure if this is a good idea, but I don't think it's a big deal. I'm not sure if this is a good idea, but I don't think it's a big deal. I'm not sure if this is a good idea, but I don't think it's a big deal. I'm not sure if this is a good idea, but I don't think it's a big deal. I'm not sure if this is a good idea, but I don't think it's a big deal. I'm not sure if this is a good idea, but I don't think it's a big deal. I'm not sure if this is a good idea, but I don't think it's a big deal. I'm not sure if this is a good idea, but I don't think it's a big deal. I'm not sure if this is a good idea, but I don't think it's a big deal. I'm not sure if this is a good idea, but I don't think it's a big deal. I'm not sure if this is a good idea, but I don", "reference": "A \"tab difference\"? As in, there are tab characters somewhere? This disabling of clang-format for all the code here seems like overkill. Are you sure there's not some other solution? I don't really understand the problem though. Do you mean clang-format-diff?" }, { - "prediction": "`org.openqa.selenium.remote.http.HttpHandler` is deprecated. Use `org.openqa.selenium.remote.http.HttpClient` instead.", + "prediction": "`org.openqa.selenium.remote.http.HttpClient` is deprecated. `org.openqa.selenium.remote.http.HttpHandler` is deprecated. `org.openqa.selenium.remote.http.HttpRequest` is deprecated. `org.openqa.selenium.remote.http.HttpResponse` is deprecated. `org.openqa.selenium.remote.http.TextMessage` is deprecated. `org.openqa.selenium.remote.http.WebSocket` is deprecated. `org.openqa.selenium.remote.tracing.DefaultTestTracer` is deprecated. `org.openqa.selenium.remote.tracing.Tracer` is deprecated. `org.openqa.selenium.remote.tracing.DefaultTestTracer` is deprecated. `org.openqa.selenium.remote.tracing.Tracer` is deprecated. `org.openqa.selenium.remote.tracing.DefaultTestTracer` is deprecated. `org.openqa.selenium.remote.tracing.Tracer` is deprecated. `org.openqa.selenium.remote.tracing.DefaultTestTracer` is deprecated. `org.openqa.selenium.remote.tracing.Tracer` is deprecated. `org.openqa.selenium.remote.tracing.DefaultTestTracer` is deprecated. `org.openqa.selenium.remote.tracing.Tracer` is deprecated. `org.openqa.selenium.remote.tracing.DefaultTestTracer` is deprecated. `org.openqa.selenium.remote.tracing.Tracer` is deprecated. `org.openqa.selenium.remote.tracing.DefaultTestTracer` is deprecated. `", "reference": "Could you please leave the explicit imports?" }, { - "prediction": "I don't think this is necessary. We can just use `methodConfigMap` directly.", + "prediction": "I think it's better to use `if (methodConfigMap.containsKey(methodConfigProto.getName()))` instead of `if (methodConfigMap.get(methodConfigProto.getName()) == null)`", "reference": "Can we check for containsKey here?" }, { - "prediction": "I don't think we need to use `os.Args[1] == \"gen\"` in this case.", + "prediction": "I don't think we need to do this, we can just use `os.Args[1] == \"gen\"` and `os.Args[1] == \"show\"`.", "reference": "Exit successfully. We served the help the user wanted." }, { @@ -5355,15 +5355,15 @@ "reference": "Had to rename this because `InitialPackage()` already existed." }, { - "prediction": "I think this is a good idea, but I'm not sure if it's the best way to do it. I think it's a good idea to use the `with_18f_procurement_env_variables` helper, but I'm not sure if it's the best way to do it. I think it's a good idea to use the `with_18f_procurement_env_variables` helper, but I'm not sure if it's the best way to do it. I think it's a good idea to use the `with_18f_procurement_env_variables` helper, but I'm not sure if it's the best way to do it. I think it's a good idea to use the `with_18f_procurement_env_variables` helper, but I'm not sure if it's the best way to do it. I think it's a good idea to use the `with_18f_procurement_env_variables` helper, but I'm not sure if it's the best way to do it. I think it's a good idea to use the `with_18f_procurement_env_variables` helper, but I'm not sure if it's the best way to do it. I think it's a", + "prediction": "I'm not sure if this is a good idea or not, but I think it would be a good idea to make sure that the `with_18f_procurement_env_variables` method is called before the `with_18f_procurement_env_variables(setup_vars)` method.", "reference": "Can we put this in a different helper?" }, { - "prediction": "I'm not sure if this is correct, but I think it should be `dstack_offs += 15 * XSP_SZ` instead of `dstack_offs += 15 * XSP_SZ + 15 * XSP_SZ`.", + "prediction": "I'm not sure if this is a good idea, but I think we should make it 8-byte aligned instead of 16-byte aligned.", "reference": "I'm not sure where your 31 comes from? I see 15 here and 2 above for pc and flags, for 17 total beyond the SIMD." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I think we should remove the `@GET` annotation from the `getTermsOfUse` method.", + "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good idea to move it to the `api` endpoint.", "reference": "If you want, you could change this to `allowCors(response` (like in \"version\", above) to allow Cross-Origin Resource Sharing. I'm sort of wondering what's returned if no API terms of use are set." }, { @@ -5375,15 +5375,15 @@ "reference": "Just wondering whether it's safe to send all CQDs to the child compiler. As this missing CQD is causing trouble, maybe some other user CQDs that now get sent could also cause the statement to fail? Also, if I have a table with a nullable unique column, should I have to set this CQD to create another table like it, or should the CREATE TABLE LIKE work without the CQD?" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to have this in a separate file, so that it can be reused in other tests.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `DAGSTER_FROM_SOURCE` and `DAGSTER_EARLIEST_RELEASE` environment variable.", "reference": "EARLIEST_TESTED_RELEASE might be slightly more clear" }, { - "prediction": "I'm not sure what you're trying to achieve with this regex, but I think it's a good idea to use `re.IGNORECASE` in this case.", + "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea.", "reference": "I think replacing `.*` with `\\s*` from after the hash makes sense, but not the rest of the changes." }, { - "prediction": "I'm not sure what you mean by `EnableLogging` here. Is it something to do with enabling logging? If so, I'm not sure I understand what you're trying to do here.", + "prediction": "I'm not sure if this is the right place to add this, but I think it would be good to add it to the `NetworkPolicyRule` struct as well.", "reference": "interesting .. did not know varint tag covered bool as well" }, { @@ -5391,19 +5391,19 @@ "reference": "Could you please elaborate the reason for not using `gkc_summary` like the values above? I ask this, because I assume what we want to collect is a histogram of event loop latency, and we use `gkc_summary` for collecting histograms." }, { - "prediction": "I think this should be `return this.txs.map(t => t._getHash());`", + "prediction": "I think it's better to use `this.txs[t].hash()` instead of `this.txs[t]._getHash()`.", "reference": "getHash should be a public and without an `_` if used here." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `ValidateBlock` function.", + "prediction": "I'm not sure why we need to validate genesisblock here.", "reference": "Unrelated to these changes -- we will probably want some special handling for genesis block validation." }, { - "prediction": "I think we can remove the `clockGetter` interface and just use the `Clock()` method in `diskBlockCacheSetter` and `diskBlockCacheFractionSetter`.", + "prediction": "I think this should be `SetDiskBlockCacheFraction(float64, float64)` instead of `SetDiskBlockCacheFraction(float64, float64, float64)`.", "reference": "This is probably overkill since we don't actually need to pass this specific interface anywhere, but I don't mind it!" }, { - "prediction": "I'm not sure what you're trying to achieve with this code. It seems like you're trying to add a peer to the list of connected peers, but you're also trying to add a peer to the list of received peers. Is this what you're trying to achieve? If so, what's the purpose of this code?", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add the `d.receivedPeers[addr.ByteString()] = struct{}{};` line to the `AddPeer` function.", "reference": "@janos I moved this back here, to avoid having multiple add peer calls being handled. I think it's either this or a global lock across the whole function. I think this is a better approach, especially since `hive.Broadcast` is blocking . We can remove the map entry on errors if needed. LMKWYT?" }, { @@ -5415,47 +5415,47 @@ "reference": "We need to find something more efficient than this. We can probably just check the first element and assume the type list is consistent.." }, { - "prediction": "I'm not sure I understand what you mean by this. Is this the same as `fmtJobInitType`? If so, why is it called `fmtJobInitTypeHelp`? Is this the same as `fmtJobInitType`? If so, why is it called `fmtJobInitTypeHelp`? Is this the same as `fmtJobInitType`? If so, why is it called `fmtJobInitTypeHelp`? Is this the same as `fmtJobInitType`? If so, why is it called `fmtJobInitTypeHelp`? Is this the same as `fmtJobInitType`? If so, why is it called `fmtJobInitTypeHelp`? Is this the same as `fmtJobInitType`? If so, why is it called `fmtJobInitTypeHelp`? Is this the same as `fmtJobInitType`? If so, why is it called `fmtJobInitTypeHelp`? Is this the same as `fmtJobInitType`? If so, why is it called `fmtJobInitTypeHelp`? Is this the same as `fmtJobInitType`? If so, why is it called `fmtJobInitTypeHelp`? Is", + "prediction": "I'm not sure what you mean by this, but I think it's better to use `fmtJobInitType` instead of `fmtJobInitTypeHelp`.", "reference": "How \" via service code in response to event.\"? I don't think we'll get in the no schedule option to the release. We should probably wait for some customer feedback first to make sure we're addressing different event-triggers the best way" }, { - "prediction": "I think this should be `PER_YIELD = 1024` instead of `PER_YIELD = 1024`", + "prediction": "I don't think we need to change this.", "reference": "Please move unrelated formatting changes to their own PR (same with the resources.py file)." }, { - "prediction": "I think this should be `self._tabbed_browser.window().setWindowState(window._state_before_fullscreen & ~Qt.WindowFullScreen)` instead of `self._tabbed_browser.window().setWindowState(window._state_before_fullscreen & ~Qt.WindowFullScreen)`", + "prediction": "I think it's better to use `self._tabbed_browser.window().showNormal()` instead of `window.setWindowState(window._state_before_fullscreen & ~Qt.WindowFullScreen)`.", "reference": "Make this a public attribute (remove the leading `_`) if you want to access it from the outside." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I don't think it's a good idea to add `emby-select-withcolor` to the `emby-select` class. I think it's better to use `emby-select-with-color` instead.", + "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use the `this` keyword here. It makes the code more readable.", "reference": "this conditional is useless now so it should be removed" }, { - "prediction": "I think this should be `auto left = vecofstructs->Get(i);` instead of `auto left = vecofstructs->Get(static_cast(i));`", + "prediction": "I'm not sure what you mean by \"not filled in monster_test.bfbs\". I think you meant to say that `vecofstructs` is not filled in `monster_test.bfbs`.", "reference": "`vecofstructs->size()` already returns a `uoffset_t`. So if you just change the type of `i`, you don't need any casts." }, { - "prediction": "@andrealin I'm not sure what you mean by \"expose command-line option for toggling proto annotations parsing.\" Is there a way to do that?", + "prediction": "I think this should be `if (configProto == null)` instead of `if (configProto == null) {`", "reference": "Nit: Maybe merge this with the configProto check on line 208? Don't feel that strongly though, please keep separate if you prefer." }, { - "prediction": "I'm not sure what you mean by \"master\" in this context. Is it referring to the `master` field in the `doc` object? If so, I'm not sure what you mean by \"master\" in this context. Is it referring to the `master` field in the `doc` object? If so, I'm not sure what you mean by \"master\" in this context. Is it referring to the `master` field in the `doc` object? If so, I'm not sure what you mean by \"master\" in this context. Is it referring to the `master` field in the `doc` object? If so, I'm not sure what you mean by \"master\" in this context. Is it referring to the `master` field in the `doc` object? If so, I'm not sure what you mean by \"master\" in this context. Is it referring to the `master` field in the `doc` object? If so, I'm not sure what you mean by \"master\" in this context. Is it referring to the `master` field in the `doc` object? If so, I'm not sure what you mean by \"master\" in this context. Is it referring", + "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to make sure that the `ismaster` and `insert` fields are always set to `true` for the `master` and `insert` fields, respectively.", "reference": "I know we already did this in 4.0 so carry on, but I'm facepalming here we should've made an overrided setMessageHandler that sets ismaster to true when hello is present. Esp in 4.0 where we already have some overrides written. We can keep going here and maybe open a ticket to some effect of that solution" }, { - "prediction": "I'm not sure what you mean by \"Skip to first result\". I think you meant to say \"Skip to last result\".", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `data-turbolinks=\"false\"` on the `#documents` link.", "reference": "I believe we could use `link_to` here (although not super important). Also, we should internationalize this value. I'm not 100% sure what our process is for adding new UI strings these days (e.g. skip the specs that will fail if we add a new key to only one language, use Google Translate to translate the value for us, some other option)." }, { - "prediction": "I think it's better to use `if (result == VK_SUCCESS)` instead of `if ((result == VK_SUCCESS || result == VK_INCOMPLETE) && pProperties)`", + "prediction": "I think it's better to use `if (result == VK_SUCCESS || result == VK_INCOMPLETE)` instead of `if (result == VK_SUCCESS && pProperties)`", "reference": "This was already in vkGetPhysicalDeviceDisplayProperties2KHR..." }, { - "prediction": "I think this should be `IsDockerEngineRunning()` instead of `IsDockerEngineRunning() (string, error)`.", + "prediction": "I think this should be `IsDockerEngineRunning` instead of `IsDockerEngineValidating`", "reference": "nit: I'd expect a public method called IsDockerEngineRunning to return a boolean yes/no, not the error message. Can we change either the return value or the name? Something like `CallDockerEngine`" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `get_string_by_dialect` function to get the dialect name from the `dialect` attribute of the `dbengine` object. This way, we don't need to call `get_string_by_dialect` every time we want to get the dialect name.", + "prediction": "`get_string_by_dialect(dbengine.dialect.name, 512)` should be `get_string_by_dialect(dbengine.dialect.name, 700)`", "reference": "If i remembered correctly, type_name is '{RESOURCE_TYPE}/{RESOURCE_NAME}', if type_name is 700 max then name cannot exceed that size" }, { @@ -5467,59 +5467,59 @@ "reference": "We may follow the argument order: conv_cfg, norm_cfg, act_cfg." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to have a `chrome_options` method.", "reference": "`options['binary'] = WebDriver::Chrome.path` if set?" }, { - "prediction": "I'm not sure why we need to include `folly/ssl/Init.h` here. It's not used anywhere in this file.", + "prediction": "I think this should be `#include ` instead of `#include `.", "reference": "folly library should be put on the top." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is the right place to do it.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.", "reference": "Do we have to restrict this to SVG elements? I think setting namespaced attributes on normal dom elements (while not as common) is still valid, so perhaps we can save some bytes by removing the `isSvg` check?" }, { - "prediction": "I'm not sure what you're trying to do with this, but I think it's a bit of a red herring. The `hiddenRow` hook is used to determine whether a row is hidden or not, but it's not used to determine whether a row is visible or not. If you want to determine whether a row is visible or not, you should use the `visibleRow` hook instead.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a `hiddenRow` hook in the `DataProvider` class. This way, we don't need to call `this.hot.runHooks('hiddenRow', row);` every time we want to check if a row is hidden.", "reference": "Please add it to the `REMOVED_HOOKS` constant." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `shadowSupport` in this case.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `shadowSupport` in this case.", "reference": "This variable needs `.v1` at the end of it, or the tests below need it. There are some test failures as a result" }, { - "prediction": "I'm not sure what you mean by `Account::Access.new(@account).spam!`", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this method in the `Account` model.", "reference": "Is this access protected so that only admins can access this route?" }, { - "prediction": "I'm not sure what you mean by \"reference\" in this context.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `wlr_output_layout_closest_point` instead of `wlr_output_layout_output_closest_point`.", "reference": "What happens if the minimum x coord is > 0? This will incorrectly set it as zero, right?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to set the `noWait` flag to `true` in the `waitingRequest` struct, but you're not actually using that flag in the `processNextMsgReq` function. Is that what you're trying to do? If that's the case, I think you should remove the `noWait` flag from the `waitingRequest` struct and set it to `false` in the `processNextMsgReq` function.", + "prediction": "I'm not sure what you mean by \"In case we have to queue up this request.\"", "reference": "I think you want to look at current pending + batchSize and if that is > o.maxp no?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `SetStatus` method to set the status of the span. This way, we don't need to call `SetStatus` every time we want to change the status of a span.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `SetStatus` method to set the status of the span. This way, we don't need to call the `SetStatus` method every time we want to set the status of the span.", "reference": "Should this be `codes.Error`? `codes.Internal` was an error status before." }, { - "prediction": "I don't think this is necessary. I think we can just use `@account` instead of `@account.project_core.used`", + "prediction": "I don't think this is necessary.", "reference": "I don't think you need these lines." }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason you want to do this?", + "prediction": "I'm not sure I understand what you're trying to do here.", "reference": "You didn't mean to export this, right?" }, { - "prediction": "I'm not sure what you're trying to achieve with this example, but it looks like you're trying to list all the SNS topics in a specific region. Is that correct?", + "prediction": "I'm not sure what you mean by \"AWS SDK for JavaScript (v3)\". Is that the same as the AWS SDK for Ruby?", "reference": "Simple Notification **Service** (singular)" }, { - "prediction": "I don't think we need to change the `egressConfig` field. It's just a pointer to the `config.EgressConfig` struct.", + "prediction": "I don't think we need to use `sync.RWMutex` here. We can use `sync.Mutex` instead.", "reference": "Do we still need this?" }, { - "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here. If you want to send a transaction, you should use the `sendRawTransaction` method. If you want to create a private marker transaction, you should use the `createPrivateMarkerTransaction` method.", + "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.", "reference": "We do have a disconnect between the privateMarkerTransactionFactory.getSender() call and the createPrivateMarkerTransaction() call. When the plugin receives the call to create the PMT it does not know what the sender was returned by the other call. At a minimum we need to pass in the sender to the second call. I would prefer that the plugin does the locking if that is necessary. If you are using random keys you don't have to lock! Besu could signal to the plugin when a PMT was un- or successfully added to the pool using a callback. Callback could be null if this is not needed. The plugin would have to be able to get the nonce for a certain key from besu. What do you think?" }, { @@ -5527,7 +5527,7 @@ "reference": "This is a bit inconsistent with the `ErrorStartHourGreaterThanEnd` in the previous file. Wouldn't `ErrorDefault``fit better here?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for NetworkPolicyStats disabled.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate test for this.", "reference": "I think it will revert the change @antoninbas did on purpose 05eee251c9c53400277def576f92d614ca234898" }, { @@ -5539,15 +5539,15 @@ "reference": "Would it make sense for `opensearch_description_tag` to have default values for the title and href attributes?" }, { - "prediction": "I think this should be `if err != nil && err != errTLFJournalDisabled`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `mStatus` and `start` and `stop` to make sure we don't try to get a range that doesn't exist.", "reference": "Just noticed this while debugging -- it's unlikely to be causing issues in practice." }, { - "prediction": "I'm not sure what you mean by `timeout: 750`", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a timeout of 750ms to the `waitForNavigation` call.", "reference": "That seems unrelated - did that fix a random test failure you noticed while working on this issue?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `doCommit` method.", + "prediction": "I think we should be able to call `doCommit` on a `null` `TableMetadata`, but I'm not sure if that's a good idea.", "reference": "This kind of concern should be handled in the `TableMetadata` update methods. This is similar to `metadata.rollbackTo`, which not only sets the current version, but also updates the table history. I think that all of those methods should add the current object's `file.location()` to the previous metadata location list, if it is non-null. That way, the caller never needs to remember to update it." }, { @@ -5559,35 +5559,35 @@ "reference": "Unrelated but shouldn't this raise `attribute-defined-outside-init`?" }, { - "prediction": "I'm not sure I understand what you're trying to do here, but I think we should remove the `create_no_window=False` argument.", + "prediction": "I'm not sure what you mean by `create_no_window=False`", "reference": "I would rather no have this as a `kwarg` as it encourages \"growth\" which lead to an unweildy constructor in other classes. Let's add a method or property to take care of this instead as I think it's usage is going to be quite low." }, { - "prediction": "I don't think this is needed anymore.", + "prediction": "I don't think we need to move this to the `Plan` model as `num_answered_questions(plan=nil)` is already in the `Phase` model.", "reference": "You just changed my life :) I grew very attached to this safe nav approach when working with Groovy years ago `obj?.method`. Glad to see its now a part of Ruby!" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `class: \"form-group clear-fix\"` class for the submit button. This will make it easier for the user to click the submit button without having to scroll down to the bottom of the page.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `class: \"form-group clear-fix\"` for the submit button. This will make it easier for the user to click the submit button without having to scroll down to the bottom of the page.", "reference": "do you mean 'clearfix' class?" }, { - "prediction": "I'm not sure what you mean by `options.causalConsistency=true`", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a `causalConsistency` option to the `startSession` method. This way, you can control whether the session is causal-consistent or not.", "reference": "`causalConsistency` is already defined on `SessionOptions`. We do not need to duplicate it here." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don", + "prediction": "I don't think this is a good idea. The `anyString` and `any` arguments are used in the same way, so they should be the same. Also, I don't think this is a good idea. The `anyString` and `any` arguments are used in the same way, so they should be the same. Also, I don't think this is a good idea. The `anyString` and `any` arguments are used in the same way, so they should be the same. Also, I don't think this is a good idea. The `anyString` and `any` arguments are used in the same way, so they should be the same. Also, I don't think this is a good idea. The `anyString` and `any` arguments are used in the same way, so they should be the same. Also, I don't think this is a good idea. The `anyString` and `any` arguments are used in the same way, so they should be the same. Also, I don't think this is a good idea. The `anyString` and `any` arguments are used in the same way, so they should be the same. Also, I don't think", "reference": "This should not be included since there are no code changes." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to set the `Access-Control-Allow-Origin` header for browser-based git clients. This way, the browser will be able to determine whether the request is coming from a trusted origin or not.", + "prediction": "I think we can remove the `if c.Req.Method == \"OPTIONS\" { ... }` line.", "reference": "If all we need just response 200, then we could use `c.Status(http.StatusOK)` here." }, { - "prediction": "I think it's better to use `client.Get(ctx, model.ResourceKey{Kind: apiv2.KindNode, Name: hostname, Namespace: \"\"})` instead of `client.Get(ctx, model.ResourceKey{Kind: apiv2.KindNode, Name: hostname, Namespace: \"\"})`", + "prediction": "I think this should be `client.Get(ctx, model.ResourceKey{Kind: apiv2.KindNode, Name: hostname, Namespace: \"\"})`", "reference": "Should be checking for error here" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `FormTabs::SECTION_OUTSIDE` class instead of the `FormTabs` class. The `FormTabs::SECTION_OUTSIDE` class has a lot more functionality than the `FormTabs` class, so I think it's a good idea to use it.", + "prediction": "I don't think we need to do this.", "reference": "Put a space between `(array)` and `$this` and I'll merge it" }, { @@ -5599,19 +5599,19 @@ "reference": "the class names `NotificationHolder` and `NotificationsHolder` are fairly difficult to quickly tell apart, particularly since they are often used close to each other" }, { - "prediction": "I don't think this is needed anymore. I think we can remove the `@Singleton` annotation and just use `@Inject` instead.", + "prediction": "I don't think this is needed anymore.", "reference": "Avoid wildcard imports" }, { - "prediction": "I'm not sure what you're trying to do with `GetContractState` and `SetContractState`, but it seems like you want to be able to get the state of a contract at a specific height, and also to be able to get a list of candidates for that contract at a specific height. Is that correct?", + "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to get the number of candidates for a given height, but you're not using the `CandidatesByHeight(uint64)` function. I'm not sure what you're trying to do here, but it seems like you're trying to get the number of candidates for a given height, but you're not using the `CandidatesByHeight(uint64)` function. I'm not sure what you're trying to do here, but it seems like you're trying to get the number of candidates for a given height, but you're not using the `CandidatesByHeight(uint64)` function. I'm not sure what you're trying to do here, but it seems like you're trying to get the number of candidates for a given height, but you're not using the `CandidatesByHeight(uint64)` function. I'm not sure what you're trying to do here, but it seems like you're trying to get the number of candidates for a given height, but you're not using the `CandidatesByHeight(uint64)` function. I'm not sure what you're trying to do here, but it seems like you're trying to get the number of candidates for", "reference": "Need to do this to unblock mockgen. The interface method needs to be public to be visible in another package. The right fix is to delete this test only interface method" }, { - "prediction": "I'm not sure what you mean by \"authSource\" and \"replicaSet\"", + "prediction": "I'm not sure if this is the right way to do this, but I think we should be able to do this in one line.", "reference": "same question here as I have on the other file regarding doing this check here vs L112 vs not at all" }, { - "prediction": "I don't think this is necessary.", + "prediction": "I don't think this is needed anymore.", "reference": "Adding `// +build !windows` (as a separate line) will do the same for Windows. So while you are at it we might add it as well." }, { @@ -5619,7 +5619,7 @@ "reference": "this is used as important way of mocking for unit tests, FYI" }, { - "prediction": "I think it's better to use `line_color` and `fill_color` instead of `color` and `alpha` in `Options('style', muted_alpha=0.2)`.", + "prediction": "I'm not sure what you're trying to do with `muted_alpha` and `line_color` in `Distribution` and `ErrorBars` options. I think you should use `alpha` and `line_color` instead of `muted_alpha` and `color`.", "reference": "Sorry, should have been clearer, I meant adding this to the ``Histogram`` options one line above." }, { @@ -5627,19 +5627,19 @@ "reference": "Just ignorance on my part, but what is the significance of the change from C23NHe2 to C23NHx2?" }, { - "prediction": "I'm not sure what you mean by \"explicit set of bin edges\" in the docstring. I think you meant \"a list of bin edges\".", + "prediction": "I think we can remove the `default` argument from `bin_range` and `bins` and just use `None` for them.", "reference": "What about tuples or pandas series? Do we want to support lots of different types or force a single type?" }, { - "prediction": "I think we can remove the `null` check in the `if (data == null)` line.", + "prediction": "I'm not sure if this is the best way to do this, but it seems to work for me.", "reference": "Small thing, without the check above this will throw a NoNodeException if the path doesn't exist. Maybe this can be wrapped in a try/catch just for the NoNodeException, so that the more user-friendly message used above can be thrown instead: `throw new KeeperException.NoNodeException(\"No collection found at path: \" + path);` Just a thought, I'm not even sure it's worth it." }, { - "prediction": "I'm not sure what you mean by \"allow_blank: true\" in this case. I think you meant to use `allow_blank: false` instead.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a validation for the `url_name` field.", "reference": "I don't know why this worked before, but we should be explicit on not verifying that a blank string (allowed as a way to remove a url/download_url) is a valid url as it is not." }, { - "prediction": "I think this should be a warning message, not a deprecation warning.", + "prediction": "I think this should be a warning, not a deprecation warning.", "reference": "Do we want to raise an error here instead of warning? Or would it be better to just see if Bolt happens to succeed, and let it fail on it's own if it fails? I'd lean towards raising an error, but that's different from \"removing support\"." }, { @@ -5647,7 +5647,7 @@ "reference": "This is kind of confusing with the other `filter_options`." }, { - "prediction": "I'm not sure what you mean by \"falling through to going directly via Favorites.\" I think you're right, but I'm not sure how to explain it.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check here to make sure the user is logged in before trying to delete a favorite.", "reference": "Could the `deleteFromFavorites` happen when `head == nil` because it's not initialized yet somehow but not because TLF doesn't exist? I was concerned if this would make it possible in any way to have favorites seemingly deleted on a device while it's not actually happened on server." }, { @@ -5655,55 +5655,55 @@ "reference": "It doesn't look like this particular \"rowCount\" variable is used anywhere. I suppose we could delete it. The code change is harmless though." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `ServeHTTP` function.", + "prediction": "I think it's better to return 204 if the status is 204, and 404 if the status is 404.", "reference": "Hmm, probably we should instead write whatever `status` is returned instead of coding a special case." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to do this.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to change the return type of a function that is private to the protobuf package.", "reference": "Could using the pointer-to-struct approach here cause confusion later? We've had several problems of that kind in the past. What does it mean if the struct is non-nil but its fields are nil? Is that even allowed? (libcalico-go question) Are there any validation requirements for this new rule addition; should it only be allowed if `Protocol == TCP`, for example?" }, { - "prediction": "I'm not sure what you mean by \"we do not use rolify gem (e.g.) but declare relationship like any other.\"", + "prediction": "I don't think this is a good idea. The `has_many :observers, through: :observers, source: :user` should be `has_many :observers, through: :observers, source: :user, foreign_key: 'user_id'`.", "reference": "why this recursive relationship definition?" }, { - "prediction": "I'm not sure what you mean by \"optional\" in this case. If you want to use it for introspection, you can just use it. If you don't want to use it for introspection, you can just leave it empty.", + "prediction": "I'm not sure I understand what you're trying to do here, but I think it's a bit confusing. The `HandlerSpec` field is just a pointer to a `HandlerSpec` struct, and the `Encoding` field is just a pointer to a `Encoding` struct. The `HandlerSpec` field is just a pointer to a `HandlerSpec` struct, and the `Encoding` field is just a pointer to a `Encoding` struct. The `HandlerSpec` field is just a pointer to a `HandlerSpec` struct, and the `Encoding` field is just a pointer to a `Encoding` struct. The `HandlerSpec` field is just a pointer to a `HandlerSpec` struct, and the `Encoding` field is just a pointer to a `Encoding` struct. The `HandlerSpec` field is just a pointer to a `HandlerSpec` struct, and the `Encoding` field is just a pointer to a `Encoding` struct. The `HandlerSpec` field is just a pointer to a `HandlerSpec` struct, and the `Encoding` field is just a pointer to a `Encoding` struct. The `HandlerSpec` field is just a pointer to a `HandlerSpec` struct, and the `Encoding`", "reference": "More sentence, less list please. > Encoding of the handler. This field is optional. We don't need to mention exactly what it's used for because that list can expand (as it has already in this change)." }, { - "prediction": "I'm not sure what you mean by `gocloud.dev/blob/bytes_read` and `gocloud.dev/blob/bytes_written`. Could you please provide more context?", + "prediction": "I'm not sure if this is the right place to add this, but I think it would be good to add it to the `gocloud.dev/trace` and `gocloud.dev/metrics` directories.", "reference": "Not part of this PR, but should the section above say what the name of the metric is for each method?" }, { - "prediction": "I think we can remove the `break` here, as it's not necessary.", + "prediction": "I think we should be able to do this in one line, right? `valueDisplay = (metric as IGaugeMetric)?.LastValue?.ToString();`", "reference": "there are changes that are upcoming to this section. For now, this works (to demo the usage of Gauge), and the changes to this section are coming as separate PRs." }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason why you want to ignore all messages?", + "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. If you want to run a process in the background, you should use the `RunInBackground` method.", "reference": "This is equivalent to stdout. Why not just replace stdin with stdout in `IsProcessBackground`?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is the right place to do it.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add it to the `DataMan` class, since it's used by `DataMan::add_stream` and `DataMan::add_man_to_path`.", "reference": "Rather than test for nullptr, just treat the pointer as a bool, i.e. `if(p_jmsg[\"compress_method\"])`" }, { - "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this.", "reference": "Can we move the remaining code of this method to a new method? I don't like the `return;` here, we could try to replace it with an `if ... else ...` syntax. What do you think?" }, { - "prediction": "I think this should be `for_resources=('bucket', 'group', 'collection', 'record')` instead of `('bucket', 'group', 'collection', 'record')`", + "prediction": "I think we should remove `for_resources=('bucket', 'group', 'collection', 'record')` and add `for_resources=('bucket', 'group', 'collection', 'record', 'resource')`", "reference": "nitpick: _and collections_" }, { - "prediction": "I'm not sure what you mean by \"set if an error happened while fetching the body so that we can propagate the error\"", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a `req_done` and a `res_done` flag in the `rp_ws_upgrade_info_t` struct.", "reference": "I believe these need to be explicitly initialized in `proxy_send_prepare`" }, { - "prediction": "I think this should be `t0 = time.time()` instead of `t0 = time.time() # Failed task start time`", + "prediction": "I think it's better to use `os.getpid()` and `time.time()` instead of `os.getpid()` and `time.time()`.", "reference": "This is unnecessary. The declaration of `t0` on line 179 is still in scope inside the `except` block." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in `request::border` instead of `request::border_color_marked`.", + "prediction": "I don't think this is a good idea. The border color should be the same as the border color of the parent element.", "reference": "The `border_color_`... properties don't support solid colors, not only this one. Maybe `@param solid_color` should be used instead of adding this note to every one of them?" }, { @@ -5711,27 +5711,27 @@ "reference": "We don't need this file, we can use the one that is in the grid-ui directory" }, { - "prediction": "I think this should be `if (path.endsWith(\"/\"))` instead of `if (path.endsWith(\"/\")) { continue; }`", + "prediction": "I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this,", "reference": "FYI: inlined this method in the internal review." }, { - "prediction": "I don't think we need to import `org.apache.commons.lang3.time.DateUtils` here.", + "prediction": "I don't think this is necessary. The `Feed` class is already defined in `org.apache.commons.lang3.tuple.Tuple2` and `org.apache.commons.lang3.tuple.Tuple3` and `org.apache.commons.lang3.tuple.Tuple4` and `org.apache.commons.lang3.tuple.Tuple5` and `org.apache.commons.lang3.tuple.Tuple6` and `org.apache.commons.lang3.tuple.Tuple7` and `org.apache.commons.lang3.tuple.Tuple8` and `org.apache.commons.lang3.tuple.Tuple9` and `org.apache.commons.lang3.tuple.Tuple10` and `org.apache.commons.lang3.tuple.Tuple11` and `org.apache.commons.lang3.tuple.Tuple12` and `org.apache.commons.lang3.tuple.Tuple13` and `org.apache.commons.lang3.tuple.Tuple14` and `org.apache.commons.lang3.tuple.Tuple15` and `org.apache.commons.lang3.tuple.Tuple16` and `org.apache.commons.lang3.tuple.Tuple17` and `org.apache.commons.lang3.tuple.Tuple18` and `org.apache.commons.lang3.tuple.T", "reference": "Werid, the checksum between this file and the one on branch `develop` is the same not sure why it's showing a diff" }, { - "prediction": "I think this should be `metric.Meter.Name + metric.Name` instead of `metric.Name + metric.Meter.Name`", + "prediction": "I'm not sure what you're trying to achieve with this change, but it looks like you're trying to add a `MeterName` field to the `PrometheusMetricBuilder` class. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to add a `MeterName` field to the `PrometheusMetricBuilder` class. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to add a `MeterName` field to the `PrometheusMetricBuilder` class. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to add a `MeterName` field to the `PrometheusMetricBuilder` class. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to add a `MeterName` field to the `PrometheusMetricBuilder` class. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to add a `MeterName` field to the `PrometheusMetricBuilder` class. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to", "reference": "Prometheus doesn't have concept of Meter (like OTLP does).. Trying to see if this is a good approach to use the meter name as namespace, to avoid name collisions, when same instrument name is used across multiple instruments, from different Meter." }, { - "prediction": "I'm not sure what you mean by \"allowConnectingCards\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `getLoginDrivers` method of the `LibraryCardsController` class.", "reference": "The formatting of this is a bit strange; I'd suggest collapsing this back to a single line, and moving the `&&` to the beginning of the second line to meet the line length restriction." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `memcpy` instead of `copy->segments = segments;`.", "reference": "One or the other should be non-NULL. If segments is NULL, the alloc above will have size zero, which we do not allow (there's no header): it should assert in debug build. So there should be asserts that one is non-NULL at the top, and if there really needs to be some kind of defensive check down here, it should cover the alloc too." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a new user with the email address from the `email_address` field in the `extra` hash, but I'm not sure what you're trying to do with the `first_name` and `last_name` fields in the `extra` hash.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this method in the `User` model, since it will be called by the `create` and `update` methods of the `User` model.", "reference": "I'm surprised rubocop isn't picking up singe quotes?" }, { @@ -5739,11 +5739,11 @@ "reference": "Is this line still needed?" }, { - "prediction": "I'm not sure what you mean by \"throughputController.bytesPerPeriod\" and \"throughputController.periodMillisecs\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `createSedPEndpoints` method.", "reference": "Maybe use specific values for all the watt.times fields? Even better, have a const for it at the top of the file?" }, { - "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a separate file for the braille table names and information.", + "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to have a `braille-tables` subdirectory in the `liblouis` directory. This would allow us to have a `braille-tables.cti` file that contains the braille table information.", "reference": "nit: UNICODE_BRAILLE_TABLE or something might be a better name for this. IMO, braille-patterns.cti is a terrible name. This table allows Unicode braille characters to be used anywhere to produce raw dots." }, { @@ -5751,19 +5751,19 @@ "reference": "Why are we removing the option to skip machine pool generation?" }, { - "prediction": "I think this should be `OnStartLine` instead of `OnStartLineHandler`?", + "prediction": "Shouldn't this be `OnStartLine` instead of `OnStartLineHandler`?", "reference": "\"Request line\" here too." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the player is in the same zone as the loot item.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea.", "reference": "Please remove this." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right way to do it.", + "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `paginate_by_sql` instead of `paginate`.", "reference": "Weird bug. Combining those joins and group calls was triggering AREL to generate the sql cache inside of will_paginate before the final call. This is a harmless workaround, but hints that will_paginate might becoming seriously deprecated." }, { - "prediction": "I think this should be `tuples` instead of `analysis_sloc_set.allowed_tuples`.", + "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all the allowed tuples for a given analysis. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all the allowed tuples for a given analysis. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all the allowed tuples for a given analysis. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all the allowed tuples for a given analysis. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all the allowed tuples for a given analysis. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all the allowed tuples for a given analysis. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all the allowed tuples for a given analysis. I'm not sure what you're trying to achieve with this, but it looks like you", "reference": "This can be simplified as discussed before." }, { @@ -5771,7 +5771,7 @@ "reference": "Does `internal` or `test` in the file name actually do anything here? Or is that just to show these functions are only for tests?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to serialize a hexa string and then check that it matches the hexa string that was passed in. Is that what you're trying to do here?", + "prediction": "I'm not sure what you're trying to do here, but I think it's a bad idea to use `serialize(true)` in this case.", "reference": "does this boolean indicate unsafe serialization?" }, { @@ -5779,11 +5779,11 @@ "reference": "Maybe rewrite to `Is only implemented for React Native`? (I assume that is the case)." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `PageStreamingTransformer` class.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `PageStreamingTransformer` class, since it's used in both `PageStreamingTransformer` and `ProtoPageStreamingTransformer`.", "reference": "Do we not need this in Java because Java *is* handling map responses?" }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to have a `__all__` list in the `Task` class, so that we don't have to import `__all__` every time we want to use this class.", + "prediction": "I'm not sure what you mean by \"when falsy, this tasks does not accept any message\". Is this the case when `self.accepted_messages` is `False`?", "reference": "Maybe \"For configuring which scheduler messages can be received.\"?" }, { @@ -5791,15 +5791,15 @@ "reference": "It will stop working with orm, so this is not a good fix, Try using some method in a common interface" }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good place to put it. I'm not sure if this is the best place to put it, but I think it would be a good place to put it. I'm not sure if this is the best place to put it, but I think it would be a good place to put it. I'm not sure if this is the best place to put it, but I think it would be a good place to put it. I'm not sure if this is the best place to put it, but I think it would be a good place to put it. I'm not sure if this is the best place to put it, but I think it would be a good place to put it. I'm not sure if this is the best place to put it, but I think it would be a good place to put it. I'm not sure if this is the best place to put it, but I think it would be a good place to put it. I'm not sure if this is the best place to put it, but I think it would be a good place to put it. I'm not sure if this is the best place to put it", + "prediction": "I'm not sure if this is the right place to put this, but I think it would make sense to move it to the `DiagnosticSourceSubscriber` class.", "reference": "`s` is not necessarily the same as `sampler` - sampler could be null and this crazy lambda underneath falls back to something. So please use `s`" }, { - "prediction": "I think it's better to use `SwaggerUtils.addDefinitions(swagger, parameterGenerator.getGenericType());` instead of `SwaggerUtils.addDefinitions(swagger, parameterGenerator.getGenericType(), parameterGenerator.getHttpParameterType());`", + "prediction": "I don't think we need to add the `null` here.", "reference": "This code is a bit confusing. Should HttpParameterType set to the original one or it is always BODY?" }, { - "prediction": "I think this should be `if err != nil { return metadata, response.Result, err; }` instead of `if err := c.verifyActionResult(target, command, digest, response.Result, false, isTest); err != nil { return metadata, response.Result, err; }`", + "prediction": "I think this should be `if err != nil { return metadata, response.Result, err; }` instead of `if err != nil { return nil, response.Result, err; }`", "reference": "Why did this change?" }, { @@ -5807,15 +5807,15 @@ "reference": "nit: `status` collides with imported package named `status`" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Can you clarify?", + "prediction": "I'm not sure I understand what you're trying to do here.", "reference": "\"memory pressure could be decreased\" --> \"to avoid memory pressure\"" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use the `to_ts` parameter in the `fetch_listens` method. The `to_ts` parameter is only used for the `fetch_listens` method, not for the `delete_listens` method. If you want to delete the listens, you should use the `delete_listens` method instead.", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to delete the listens from the database, but I'm not sure what you're trying to do with the `min_ts` and `max_ts` values.", "reference": "I think it would make sense to fetch the cache values after deleting the listens and making sure they are what we expect." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to make the `collapsible` property of the `headerStateManager` state map to `false` when the `collapsibleColumns` array is empty.", + "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `this.headerStateManager.mergeStateWith(collapsibleColumns);` instead of `this.headerStateManager.mapState(() => { return { collapsible: false }; });`", "reference": "I'm thinking about covering this change with the test. Can you do that?" }, { @@ -5823,23 +5823,23 @@ "reference": "Not sure if it's a good idea to remove stop channel. If user cancels connection how will you stop pinger?" }, { - "prediction": "I think we should remove the `authData` parameter from the `getAuthdata` function.", + "prediction": "I think we can remove the `if err != nil` here.", "reference": "Could you please add a `TODO` here that we won't need `docker.AuthConfiguration` anymore when we migrate to SDK's pull image?" }, { - "prediction": "I think this should be `public ITaskItem[] BlobNames { get; set; }` instead of `public ITaskItem[] BlobNames { get; set; }`", + "prediction": "I don't think this is necessary. The `BlobNames` property is not used in the `ExecuteAsync` method, so it can be removed.", "reference": "Is there a scenario were we want to get an arbitrary set of blobs that don't share a common root?" }, { - "prediction": "I'm not sure what you mean by \"type=regex\"", + "prediction": "I'm not sure what you mean by \"type=regex\" in this context. I think you meant to say \"type=regex\" in the `generateTopologyTests` function.", "reference": "Can you leave a note about why we are skipping regex tests?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to make sure the repo is closed before closing the repo.", + "prediction": "I think this should be `if err != nil { return err; }` instead of `if err != nil { return err; }`", "reference": "This was the only caller of CreateRepo, so I inlined it." }, { - "prediction": "I don't think we need this field, it's not used anywhere.", + "prediction": "I don't think we need this field.", "reference": "As this is already a child of `auth`, I think we can shorten this to `path`" }, { @@ -5847,15 +5847,15 @@ "reference": "This call should use element, not 0 I think." }, { - "prediction": "I don't think this is a good idea. It's not clear what the purpose of this option is, and it's not clear what the default value should be. It's also not clear what the purpose of this option is, and it's not clear what the default value should be. It's not clear what the purpose of this option is, and it's not clear what the default value should be. It's not clear what the purpose of this option is, and it's not clear what the default value should be. It's not clear what the purpose of this option is, and it's not clear what the default value should be. It's not clear what the purpose of this option is, and it's not clear what the default value should be. It's not clear what the purpose of this option is, and it's not clear what the default value should be. It's not clear what the purpose of this option is, and it's not clear what the default value should be. It's not clear what the purpose of this option is, and it's not clear what the default value should be. It's not clear what the purpose of this option is, and it's not clear what the default value should be. It's not clear what", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `Fs` struct.", "reference": "This is missing the definition of `fetch_until_empty_page` - it needs to go in the config section above." }, { - "prediction": "I think this should be `unless File.exist?(File.expand_path(path))` instead of `unless File.exist?(path)`", + "prediction": "I think it's better to use `File.expand_path` instead of `File.expand_path?(path)`.", "reference": "I don't think this one needs to be changed since the only previous path is already an absolute one." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the table is a static table. If it is, then we can just use the static table. Otherwise, we need to create a new static table.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this", "reference": "Since we kept the original constructor we might not need this change now." }, { @@ -5863,15 +5863,15 @@ "reference": "There is already a log in `BaseMetastoreTableOperations` for this. It has the location, but not the table name. Maybe just add table name to that one." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it would be better to use `github.com/pipe-cd/pipe/pkg/filestore/minio` instead of `github.com/pipe-cd/pipe/pkg/filestore/minio.minio`.", + "prediction": "I'm not sure if this is a good place to put this, but I think we should move it to `github.com/pipe-cd/pipe/pkg/filestore/minio` so that we don't have to update the `minio` package in `github.com/pipe-cd/pipe/pkg/filestore` when we update `github.com/pipe-cd/pipe/pkg/filestore/minio`.", "reference": "This should be in the last group." }, { - "prediction": "I think we can remove the `Send` call here, since we're not using the statsd client anymore.", + "prediction": "I think we can remove the call to `Send` here, since we're already sending the traces to the agent.", "reference": "I believe you should either remove this or rename the PR. You can't change the behavior of the tracer (even to fix a bug) in a PR named \"unit test improvements\"" }, { - "prediction": "I think we should remove the `+k8s:deepcopy-gen=package,register` and `+k8s:conversion-gen=github.com/munnerz/cert-manager/pkg/apis/certmanager` labels.", + "prediction": "I think we should remove the `+k8s:deepcopy-gen=package,register` and `+k8s:conversion-gen=github.com/munnerz/cert-manager/pkg/apis/certmanager/pkg/apis/certmanager` labels.", "reference": "I've gone with this group name, however I'm open to suggestions on alternatives!" }, { @@ -5879,11 +5879,11 @@ "reference": "should this be GOQUORUM" }, { - "prediction": "I don't think we need to change the return type of this function.", + "prediction": "I'm not sure what you mean by \"checkCoinbase\"", "reference": "I think checkCoinbase is not skipping checking coinbase. Instead, true-> checking num(coinbase tx) = 1, false -> checking num(coinbase tx) = 0." }, { - "prediction": "I'm not sure what you mean by \"context.Context\" in this context. It's not a context. It's a mock context.", + "prediction": "I don't think we need to use `gomock.NewContext` here. We can just use `gomock.NewMockContext` instead.", "reference": "same here, move it out" }, { @@ -5891,15 +5891,15 @@ "reference": "Can you elaborate on why you need different behavior depending on Tools being built independently or not?" }, { - "prediction": "I'm not sure what you mean by \"example answer and guidance\" but I think it's better to just say \"example answer\" and \"guidance\".", + "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use the `@question` variable here.", "reference": "because of the above if statement will requires both ex_save and guid_save to be true, this code will always return 'example answer'. This should be revised with `example_answer.present?` and `guidance.present?`" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add a comment to explain what this change does.", + "prediction": "I don't think we need to use `context` here. We can use `context.Background()` instead.", "reference": "why not context from stdlib?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea to change the `Flavor` to `FlavorIEEECRC32OverThriftBinary` and `FlavorIEEECRC32OverProto3Binary` to `FlavorIEEECRC32OverThriftBinary` and `FlavorIEEECRC32OverProto3Binary` respectively.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add a comment to the function to explain what it does.", "reference": "Just saw this and wasn't able to hold myself from renaming :-)." }, { @@ -5907,39 +5907,39 @@ "reference": "Can we keep the other assertion too? I think it's helpful to ensure that the uninstall function was called too" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `shared_examples_for` block.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `shared_examples_for` block as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `shared_examples_for` block as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `shared_examples_for` block as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `shared_examples_for` block as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `shared_examples_for` block as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `shared_examples_for` block as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `shared_examples_for` block as well. I'm not sure", "reference": "`warn_with` prefixes the message with `WARNING:`, right? So this will put `WARNING:` twice. It would be good to verify all the warnings look good after this change, given how easy it is to make a simple mistake like this :(." }, { - "prediction": "I'm not sure what you mean by \"de-duplicated\" here. I think it means that we don't have duplicate messages in the pool.", + "prediction": "I'm not sure what you mean by \"de-duplicated\" here. It's not clear to me what you're trying to achieve.", "reference": "FYI In the message queue I use the term \"stamp\" to refer to the time-like mark associated with each message. It's opaque to the queue/pool and should make no difference if the stamps and age limit were converted to seconds. So this could then become `Stamper` with `CurrentStamp()` method, no reference to \"blocks\" or height etc. The wrapper struct could be `StampedMessage. The interpretation as block height is deferred to the user/constructor that hooks things up, the \"business logic\". This is just an observation, take or ignore as you wish." }, { - "prediction": "I don't think we need to check if the bucket actually exists. We can just return a 200 if the bucket doesn't exist.", + "prediction": "I don't think we need to check if the bucket actually exists here.", "reference": "Can we remove the `TODO` statement here? (as this is actually fixed in this PR)" }, { - "prediction": "I don't think we need to add `mMaxPushFolders` to the `Account` class. It's not used anywhere in the code.", + "prediction": "`mSortType` should be `SortType` instead of `SortType`", "reference": "m prefix no longer in code style" }, { - "prediction": "I'm not sure what you mean by \"failed to delete %x in %s\". I think you meant to say \"failed to delete %s in %s\".", + "prediction": "I think this should be `b.Lock()` and `b.Unlock()` instead of `b.Lock()` and `b.Unlock()`.", "reference": "need to filter the entities in buffer as well" }, { - "prediction": "I don't think this is a good idea. It's not clear to me what the purpose of this class is, and I don't think it's a good idea to have it in the `android.graphics.BitmapTransformation` class.", + "prediction": "I think we should remove the `private static final String ID=\"de.danoeh.antennapod.core.glide.FastBlurTransformation\";` line.", "reference": "Please add spaces before and after the equals sign" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think we need to include `common/evl_sqlog_eventnum.h`.", + "prediction": "I'm not sure why we need to include `common/evl_sqlog_eventnum.h` here. I think we can just include `common/evl_sqlog_eventnum.h` in `sq_sql_eventids.h` and `common/evl_sqlog_eventnum.h` in `common/sql.info_event.pb.h` and `common/sql.info_event.pb.h` in `common/sql.error_event.pb.h`.", "reference": "This file could also be cleaned up/deleted. But lets do this separately after ensuring all the event logging has been ported to the current logmxevent_traf.cpp file completely." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should go in the `spec/core` directory.", + "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to move it to `spec_helper.rb` so that it can be used by other specs.", "reference": ":thinking:, the line number here is the line of the example (`example.location`), that's probably why I finally chose to display the example title because it's what can be found on this line, and saying that the error is from there is confusing. But presenting the actual failures is indeed better, so maybe we can get the failure actual line number from the exception backtrace and then output two distinct lines for failures like this one?" }, { - "prediction": "I don't think it's necessary to create a new instance of chrome driver in this case. We can just use the existing one.", + "prediction": "I don't think it's necessary to create a new instance of chrome driver here. We can just use the existing one.", "reference": "We shouldn't add this as a new `kwarg` here. This should all be done on the options class" }, { @@ -5947,7 +5947,7 @@ "reference": "Should this be `OS_VOLUME_SUPPORT` to match the symbol key names?" }, { - "prediction": "I'm not sure what you're trying to do with this. It looks like you're trying to add a new handler to the `handlers` array, but I don't think that's what you're trying to do. It looks like you're trying to add a new handler to the `handlers` array, but I don't think that's what you're trying to do. It looks like you're trying to add a new handler to the `handlers` array, but I don't think that's what you're trying to do. It looks like you're trying to add a new handler to the `handlers` array, but I don't think that's what you're trying to do. It looks like you're trying to add a new handler to the `handlers` array, but I don't think that's what you're trying to do. It looks like you're trying to add a new handler to the `handlers` array, but I don't think that's what you're trying to do. It looks like you're trying to add a new handler to the `handlers` array, but I don't think that's what you're trying to do. It looks like you're trying to add a new handler to the `handlers` array, but", + "prediction": "I'm not sure if this is a good idea, but I don't think it's a good idea to have `handlers` be a pointer to an array of pointers to `flux_msg_handler_t`. I think it's better to have it be an array of pointers to `flux_msg_handler_t`.", "reference": "In C, file scope variables are already initialized to 0 so the \"= NULL\" is redundant. Not a big deal." }, { @@ -5955,47 +5955,47 @@ "reference": "on line 40, the `relevantNode` can change and therefore the `doc` might change too for the lookup on line 43. I think this code should be moved to where the `doc` is actually being used" }, { - "prediction": "I'm not sure what you mean by \"milliseconds must be between {0} and {1}\"", + "prediction": "I'm not sure what you mean by \"milliseconds must be between {0} and {1}\". I think it should be \"milliseconds must be between 0 and 1000000\".", "reference": "nit: just to be similar to others, can you change to interpolation?" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to make this a field in the `ControllerOptions` struct.", + "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea to add it to the `ControllerOptions` struct.", "reference": "Would this make more sense as an option on an Issuer resource (specifically on the CA issuer) rather than as a flag? It's not ideal that we have a flag that _looks_ like it could be 'global' but is actually not IMO. Also, if Istio is reading the CSR object, is it possible for it to read the CA from the CSR itself too and append the two instead? Not sure if we ever decided whether to use annotations for this purpose @JoshVanL?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don", + "prediction": "I don't think we need to change this.", "reference": "Because this acts as a coordination point between client and server, it should go in core.py instead of const.py (so eventually the server could use it to guarantee that it delivers dates in the expected format)." }, { - "prediction": "I think this should be `if err != nil && apierrors.IsNotFound(errors.Cause(err)) {`", + "prediction": "I think it's better to use `errors.Cause(err)` instead of `apierrors.IsNotFound(errors.Cause(err))`", "reference": "expected statement, found 'else' (and 1 more errors)" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a fake TLF ID that can be used to create a fake TLF ID with `FakeIDByte`. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a fake TLF ID that can be used to create a fake TLF ID with `FakeIDByte`. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a fake TLF ID that can be used to create a fake TLF ID with `FakeIDByte`. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a fake TLF ID that can be used to create a fake TLF ID with `FakeIDByte`. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a fake TLF ID that can be used to create a fake TLF ID with `FakeIDByte`. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a fake TLF ID that can be used to create a fake T", + "prediction": "I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this,", "reference": "IMO this doesn't need to be in the `kbfs` repo. And I don't like setting the byte. We can always compare with the randomly generated `TlfID`." }, { - "prediction": "I think this should be `DeviceControllerModuleName` instead of `DeviceControllerModuleName`", + "prediction": "I think this should be `DeviceControllerModuleName` and `CloudHubControllerModuleName` instead of `DeviceControllerModuleName` and `CloudHubControllerModuleName`.", "reference": "What's the difference from ModuleName in `pkg/apis/meta/v1alpha1/types.go`?" }, { - "prediction": "I don't think this is a good idea. It's not a good idea to use `System.Reflection.PortableExecutable` and `System.Reflection.Metadata` in the same namespace. It's not a good idea to use `System.Reflection.Metadata` in the same namespace as `System.Reflection.PortableExecutable`. It's not a good idea to use `System.Reflection.PortableExecutable` in the same namespace as `System.Reflection.Metadata`. It's not a good idea to use `System.Reflection.Metadata` in the same namespace as `System.Reflection.PortableExecutable`. It's not a good idea to use `System.Reflection.PortableExecutable` in the same namespace as `System.Reflection.Metadata`. It's not a good idea to use `System.Reflection.PortableExecutable` in the same namespace as `System.Reflection.Metadata`. It's not a good idea to use `System.Reflection.PortableExecutable` in the same namespace as `System.Reflection.Metadata`. It's not a good idea to use `System.Reflection.PortableExecutable` in the same namespace as `System.Reflection.Metadata`. It's not a good idea to use `System.Reflection.PortableExecutable` in the same namespace as `System.Reflection.Metadata`. It's not a good idea to use `System.Reflection.PortableExecutable` in the same namespace as", + "prediction": "I don't think we need to change this line. It's just a warning.", "reference": "We shouldn't be changing this task as we are trying to break our dependency on it and switch to using the shipped version." }, { - "prediction": "I think this should be in `arch/x86/clean_call_opt.c` instead of `arch/x86/clean_call.c`.", + "prediction": "I think this should be in `arch/x86/clean_call.c` instead of `arch/x86/clean_call_opt.c`.", "reference": "Shouldn't we have a low bar for generating out-of-line context switch, i.e., if we need save more than n (3?) simd or m (4) gprs we should go out-of-line? And it should be || instead &&. It seems the bar is still very high after this change." }, { - "prediction": "I'm not sure what you mean by \"forwarding implementation of metric.Provider\". Could you please provide more context?", + "prediction": "I don't think we need to use the `instrumentation` package here. We can just use the `otel/instrumentation` package.", "reference": "Should the API have a dependency on the SDK?" }, { - "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to skip this test.", + "prediction": "I'm not sure if this is the right place to add this test, but I think it's worth adding it.", "reference": "Is this a sometimes leaky test?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to do something like this:\r\n\r\n```go\r\nfunc (v ConstraintGenerator) typeOf(n Node) (PolyType, error) {\r\n ftv := n.ExternType.freeVars(nil)\r\n subst := make(Substitution, len(ftv))\r\n for _, tv := range ftv {\r\n subst[tv] = v.cs.f.Fresh()\r\n }\r\n t := subst.ApplyType(n.ExternType)\r\n // Check if this type knows about its kind constraints\r\n return t, nil\r\n}\r\n```", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a fresh variable for each kind constraint. I think you should be able to do this with a single fresh variable, but I'm not sure what you're trying to do here. Could you explain what you're trying to do here?", "reference": "It should be possible to create a test case that enter the loop. That would be a good enough test case for me. Have a look at the extern type inference test cases that already exist. Since you can just pick the type variables the extern type use, you should be able to create a conflict that requires this loop to fix." }, { @@ -6015,27 +6015,27 @@ "reference": "Thank you this is so much nicer than the old `Rails.configuration.branding['blah']['blah']['blah']` :)" }, { - "prediction": "I think we should add `BACKEND_SERVICE` to `RESOURCE_TYPE` instead of `BACKEND_SERVICE` to `RESOURCE_TYPE`", + "prediction": "I'm not sure if this is the right place to put this, but I think it would be a good idea to move it to the `resource` module.", "reference": "nit: Would you mind alpha-sorting this?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check here to make sure that the manifest is actually a delete manifest. If it's not a delete manifest, then we shouldn't be trying to read it.", + "prediction": "I think this should be moved to the `ManifestReader` class.", "reference": "For my understanding, the DATA manifest & DELETE manifest could share the same read / write path so I think we could use the common reader+writer. Is there any other reason that we need to make them separate paths ?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `contact_us_url` instead of `contact_us` in this case.", + "prediction": "I'm not sure if this is the right place to put it, but I think it should be in the `contact_us_url` variable.", "reference": "that change should be sufficient for avoiding the override of contact_us_url helper. The one defined at the .yml it is within a hash so no problem should arise." }, { - "prediction": "I think it's better to use `create_and_add_another` instead of `create_and_continue`.", + "prediction": "I don't think this is a good idea. It's not clear to the user what they are trying to do when they click on the \"create and continue\" button.", "reference": "We actually had a discussion about this exactly in #3470, some languages seem to go for one, some for the other" }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good idea to move it to the `DynamicLangXApiView` class. This way, we don't have to repeat this code in all of the `DynamicLangXApiView` subclasses.", + "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good idea to move it to the `DynamicLangXApiView` class.", "reference": "Is PHP the first dynamic MVVM language with grpc streaming support?" }, { - "prediction": "I'm not sure what you mean by \"Bad input file\". Is it because the file doesn't exist? Or is it because the file isn't a valid .mol file?", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to check that the stream is not null before trying to delete it.", "reference": "the `if` isn't necessary here; it's safe to call `delete` on `nullptr`" }, { @@ -6043,43 +6043,43 @@ "reference": "Change if the method's name finally changes to `clear_history` as proposed elsewhere" }, { - "prediction": "I'm not sure what you're trying to do with this, but I think it's a bit of a red herring. It's not clear what you're trying to do with this, but I think it's a bit of a red herring. It's not clear what you're trying to do with this, but I think it's a bit of a red herring. It's not clear what you're trying to do with this, but I think it's a bit of a red herring. It's not clear what you're trying to do with this, but I think it's a bit of a red herring. It's not clear what you're trying to do with this, but I think it's a bit of a red herring. It's not clear what you're trying to do with this, but I think it's a bit of a red herring. It's not clear what you're trying to do with this, but I think it's a bit of a red herring. It's not clear what you're trying to do with this, but I think it's a bit of a red herring. It's not clear what you're trying to do with this, but I think it's a bit of a", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be good to have a separate file for the user guide.", "reference": "can this one also be moved to the top of the file?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do that.", + "prediction": "I'm not sure what you mean by \"GroupMembers is a list of resources selected by this group.\"", "reference": "So if I understand this correctly the externalEntities should be computed and stored in GroupMember, while current code usage of GroupMemberPod will be migrated to GroupMember later?" }, { - "prediction": "I think we should use `ServiceName` and `ResourceName` instead of `Service` and `Resource`.", + "prediction": "I think we should use `ServiceName` and `ResourceName` instead of `service.name` and `resource.name`.", "reference": "Don't we have tests to change after this breaking change? probably we're not using hard coded strings in our tests when we create a `Span`?" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `os.environ['GOOGLE_APPLICATION_CREDENTIALS']` instead of hardcoding the path to the credentials file.", + "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to hardcode the path to the credentials file. I think it would be better to use the environment variable `GOOGLE_APPLICATION_CREDENTIALS` instead of hardcoding the path to the credentials file.", "reference": "will this fail if the env variable doesn't exist? Is this the preferred behaviour?" }, { - "prediction": "I think this should be `numpy.array([self._random.getReal64() for i in xrange(self._numColumns)])` instead of `numpy.array([self._random.getReal64() for i in xrange(self._numColumns)]) for i in xrange(self._numColumns)`", + "prediction": "I think it's better to use `numpy.random.uniform` instead of `numpy.random.get_real64` here.", "reference": "bad line wrap" }, { - "prediction": "I'm not sure I understand what you're trying to do here, but I think we should be able to do this with a single `boost::asio::async_read_until` call.", + "prediction": "I'm not sure I understand what you're trying to do here, but I think we should remove the `bulk_pull_blocks_mode` from the `receive_bulk_pull_blocks_action` callback.", "reference": "What does the `8` here represent? Can you give it a name?" }, { - "prediction": "I think we can remove the `os.environ[\"MP_API_KEY\"]` and just use the `MP_API_KEY` from the environment.", + "prediction": "I think it's better to use `os.environ[\"MP_API_KEY\"]` instead of `os.environ[\"MP_API_KEY\"]` in this case.", "reference": "`MPRester(os.environ[\"MP_API_KEY\"])` can be left simply as `MPRester()` and it will pick up the API key from the environment. What is the purpose of this file otherwise? Is it better suited for `dev_scripts`, or a test?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to add a new column to the table, but you're doing it in a way that doesn't make sense. Can you explain what you're trying to do here?", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to add a new column to the table, but you're doing it in a way that doesn't make sense. For example, you're trying to add a new column to the `announcements` table, but you're doing it in a way that doesn't make sense. For example, you're trying to add a new column to the `announcements` table, but you're doing it in a way that doesn't make sense. For example, you're trying to add a new column to the `announcements` table, but you're doing it in a way that doesn't make sense. For example, you're trying to add a new column to the `announcements` table, but you're doing it in a way that doesn't make sense. For example, you're trying to add a new column to the `announcements` table, but you're doing it in a way that doesn't make sense. For example, you're trying to add a new column to the `announcements` table, but you're doing it in a way that doesn't make sense. For example, you're trying to add a new column to the `announcements` table", "reference": "Looks like there may be more changes to this file than intended?" }, { - "prediction": "I think we can remove the `if !ok` check here.", + "prediction": "I don't think we need to do this anymore.", "reference": "when message type is not expected, contine to next loop instead of return to finish infinite loop" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don", + "prediction": "I'm not sure if this is a good idea, but I think we should add a test for this.", "reference": "This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards." }, { @@ -6087,19 +6087,19 @@ "reference": "instanceID should stay the same for a AWSMachine?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to set NO_DOWNLOAD to false.", + "prediction": "I don't think this is needed anymore.", "reference": "Since this is a dict don't you want `False` or do we clean that up elsewhere?" }, { - "prediction": "I'm not sure what you mean by \"DEBUG = True\" in this context. I think it's more likely that you meant to use `DEBUG = True` in the `__init__` method of the `CentralPlannerScheduler` class, not in the `__init__` method of the `CentralPlannerTest` class.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `CentralPlannerScheduler` class.", "reference": "what's the reason you had to add the `host` argument to all `get_work` calls?" }, { - "prediction": "I'm not sure if this is a good idea, but I think we should be able to do this in a more generic way. For example, we could do something like this:\n\n```kotlin\n @Override\n public Map> getRequiredPermissions() {\n Map> requiredPermissions = new HashMap<>();\n for (Dataset dataset : ctxt.dataverses().index((Dataverse) r, true)) {\n requiredPermissions.put(dataset.getName(), dataset.getRequiredPermissions());\n }\n return requiredPermissions;\n }\n```\n\nThis would allow us to do something like this:\n\n```kotlin\n @Override\n public Map> getRequiredPermissions() {\n Map> requiredPermissions = new HashMap<>();\n for (Dataset dataset : ctxt.dataverses().index((Dataverse) r, true)) {\n requiredPermissions.put(dataset.getName(), dataset.getRequiredPermissions());\n }\n return requiredPermissions;\n }\n```\n\nThis would allow us to do something like this:\n\n```kotlin\n @Override\n public Map> getRequiredPermissions() {\n Map> requiredPermissions = new HashMap<>();\n for (", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check to see if the dataset is an instance of Dataset, and if it is, then add the permission to the required permissions map.", "reference": "This will never be a dataset so we can simplify the code here" }, { - "prediction": "I don't think this is necessary.", + "prediction": "I don't think we need to call `skipZeroBlockRewards` here.", "reference": "This should be moved into the PrivacyBlockProcessor instead of adding the constructor here." }, { @@ -6111,27 +6111,27 @@ "reference": "It looks like you've removed `bisect_round_finished` but kept `bisect_round_started`. Seems a little odd that they aren't paired. Not sure if there's anything to do about that though..." }, { - "prediction": "I think this should be `throttle_set` instead of `-1`.", + "prediction": "I think this should be `throttle_set` instead of `throttle_set(-1)`.", "reference": "I'm not sure how to fix the lint and mypy warnings on this line. I could just ignore them, but I feel like the linter should know this exists." }, { - "prediction": "I'm not sure what you mean by \"skip session\" in this context. It's not clear to me what you're trying to do with this symbol.", + "prediction": "I don't think this is needed.", "reference": "why remove `Symbol`?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is this for a regular expression or something else? I'm not sure I understand what you're trying to do here. Is this for a regular expression or something else? I'm not sure I understand what you're trying to do here. Is this for a regular expression or something else? I'm not sure I understand what you're trying to do here. Is this for a regular expression or something else? I'm not sure I understand what you're trying to do here. Is this for a regular expression or something else? I'm not sure I understand what you're trying to do here. Is this for a regular expression or something else? I'm not sure I understand what you're trying to do here. Is this for a regular expression or something else? I'm not sure I understand what you're trying to do here. Is this for a regular expression or something else? I'm not sure I understand what you're trying to do here. Is this for a regular expression or something else? I'm not sure I understand what you're trying to do here. Is this for a regular expression or something else? I'm not sure I understand what you're trying to do here. Is this", + "prediction": "I'm not sure what you're trying to achieve with this, but I think it's better to just use `/\\u2000-\\u206F\\u2E00-\\u2E7F\\\\'!\"#$%&()*+,\\-.\\/:;<=>?@\\[\\]^_`{|}~\u00b1]/g`", "reference": "Why are currency signs considered punctuation? They technically fall under the BMP range for Currency Symbols `\\u20A0-\\u20CF` (covered in `getUnicodeNonBmpRegExp`, which is itself a misnomer)" }, { - "prediction": "I don't think it's necessary to add `maintainer` to the `setup()` function.", + "prediction": "I don't think it's necessary to add `maintainer` and `author` to the `setup.py` file.", "reference": "You have forgotten a coma `,`" }, { - "prediction": "`img_show` should be `img` instead of `mmcv.imresize(img_show, (ori_w, ori_h))`", + "prediction": "`img_show` should be `img`", "reference": "For different datasets, we may want to save the images differently. Sometimes the datasets are categorized into several subfolders, and we want to keep it when saving visualization results, and sometimes we just want to save all images in `out_dir`. An argument may be added to control the behavior." }, { - "prediction": "I think this should be `if (c1 == c2)` instead of `if (c1 == c2 && bb.get(ia) == '\\0')`", + "prediction": "I think this should be `if (c1 == c2)` instead of `if (c1 == c2 && bb.get(ia) == '\\0')`.", "reference": "if `other` could have a guaranteed `0` byte in it, this whole `if` could be removed, and above you could just add `|| c2 == '\\0'` to get the same effect?" }, { @@ -6139,63 +6139,63 @@ "reference": "nit: can this be a primitive value?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `ServeListing` function as well.", + "prediction": "I think this should be `if u.Path[len(u.Path)-1] != '/'` instead of `if u.Path[len(u.Path)-1] != '/'`", "reference": "This maybe not what we want. If `rewrite` occurred before, `r.URL.Path` contains the result and we should use it. Otherwise `rewrite` middleware will disfunction when combining with `browser`." }, { - "prediction": "I think this should be `except BaseException:` instead of `except exception:`.", + "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a separate `reporters` list in the `__init__` method of the `Engine` class. This way, we don't have to worry about the order of the modules in the `reporters` list, and we don't have to worry about the order of the modules in the `provisioning` and `aggregator` lists.", "reference": "Why change this?" }, { - "prediction": "I don't think this is a good idea. The `ErrorListener` is supposed to log errors, not fake them. If you want to log fake errors, you should use the `LoggerInterface` instead.", + "prediction": "I don't think you need to use `LoggerInterface` here. You can just use `ErrorListener` directly.", "reference": "_nitpick_ Isn't it now actually NotLogFakeHttpExceptions**Error**Listener ?" }, { - "prediction": "I think this should be `JsonSchema.CreateStringEnum` instead of `JsonSchema.CreateStringEnumEnum`.", + "prediction": "I think this should be `JsonSchema.CreateStringEnum(resourceType)` instead of `JsonSchema.CreateStringEnum(resourceType, true)`.", "reference": "Why not just look for the \"type\" property instead of creating a ResourceType property?" }, { - "prediction": "I'm not sure what you mean by `Tip: tip` and `ChainID: config.ChainID()`. Could you please clarify?", + "prediction": "I don't think we need to use `Tip` here. We can just use `TipInfo` instead.", "reference": "should use `bc.config.Blockchain.ChainID`" }, { - "prediction": "I think we should use `hosts` instead of `hostsList` in this case. `hostsList` is deprecated.", + "prediction": "I think we should use `hosts` instead of `hostsList` here.", "reference": "this doesn't need to know about NativeClient" }, { - "prediction": "I'm not sure what you mean by `rule_name` and `resource_name` in this case. Could you please provide more context?", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get the name of the rule that caused the violation. If you want to get the name of the resource that caused the violation, you'll need to get the `resource_data` and `resource_name` fields from the violation object.", "reference": "I know we discussed if we should add in the resource_name to the hash, and I actually don't think it's required. The violation hash was recently updated (not released) to include the violated rule, so when the next release goes out, user's findings will get updated. The resource name doesn't hurt to have here, but not required." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in `wl_surface_destroy` as well.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `wl_surface_destroy` as well.", "reference": "The variable name is also misleading imo. The width from the buffer comes from `wl_shm_buffer_get_width` (or a similar EGL thing), which is what gets encoded into `surface->texture->width`." }, { - "prediction": "I'm not sure what you mean by `artist_msid` and `recording_msid` in this context. Could you please clarify?", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `self.artist_msid` and `self.recording_msid` instead of `self.artist_msid` and `self.recording_msid`.", "reference": "Why are you using these tags to carry these msids?" }, { - "prediction": "I think this should be `flb_free(*s_val);` instead of `flb_sds_destroy(tmp);`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be better to do this in `flb_config_get_property` as well.", "reference": "flb_strdup() should do the work here. note: use Fluent Bit memory wrappers" }, { - "prediction": "I think this should be `pb/retrieval.proto` instead of `pb/retrieval.proto`.", + "prediction": "I think this should be `protoc -I . -I $(go list -f '{{ .Dir }}' -m github.com/gogo/protobuf)/protobuf --gogofaster_out=. retrieval.proto`", "reference": "This line should be separated from the package declaration by one line as it is not the package description." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate test for this. I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate test for this. I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate test for this. I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate test for this. I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate test for this. I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate test for this. I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate test for this. I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate test for this. I'm not sure if this is the right place to do this, but I", + "prediction": "I think we can remove the `require.NoError(t, err)` in the last line of the test.", "reference": "shadow: declaration of \"err\" shadows declaration at line 410 (from `govet`)" }, { - "prediction": "I think it's better to use `time.Duration` instead of `time.Time` for the `Until` field.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `since` and `until` field in the `DurationConfig` struct.", "reference": "Maybe next time better to make separate PR?" }, { - "prediction": "I don't think this is a good idea.", + "prediction": "I don't think this is necessary. We can just use `torch.onnx.is_in_onnx_export()` instead.", "reference": "line 316 also handles this case, need to simplify the logic." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check to make sure the bucket name is not empty before trying to open it.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check here to make sure that the bucket name is not empty. If it is empty, we should return an error.", "reference": "We used to have a simple check for bucket and object names, we then decided to remove it and rely on the backend service to check for the name. Is there any reason to add an empty name check now?" }, { @@ -6203,27 +6203,27 @@ "reference": "Line too long" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don", + "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a list of all the effects that can be cast by a spell, rather than a list of effects that can be cast by a spell.", "reference": "This isn't aligned though." }, { - "prediction": "I don't think we need to change the docstring here. It's the same as before.", + "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to add a docstring for this function.", "reference": "it is mean -> it means PAAHead does not support test-time augmentation." }, { - "prediction": "I think this should be `from invenio.legacy.bibdocfile.config import CFG_BIBDOCFILE_ICON_SUBFORMAT_RE, CFG_BIBDOCFILE_DEFAULT_ICON_SUBFORMAT` instead of `from invenio.legacy.bibdocfile.api import BIBCATALOG_SYSTEM, CFG_BIBDOCFILE_ICON_SUBFORMAT_RE, CFG_BIBDOCFILE_DEFAULT_ICON_SUBFORMAT`", + "prediction": "I think this should be `invenio.legacy.bibdocfile.config` instead of `invenio.legacy.bibdocfile.api`", "reference": "@lnielsen-cern thanks. I missed it :(" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a `serviceURL` prop to the `AnalyticsAdSenseDashboardWidgetTopPagesTable` component.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a `serviceURL` prop to the `AnalyticsAdSenseDashboardWidgetTopPagesTable` component.", "reference": "@tofumatt, has it been changed intentionally? It doesn't seem to be required in IB, plus we haven't had `content-drilldown` before... If it has been changed intentionally, then should we update the `AnalyticsDashboardWidget` component to be use `content-drilldown` instead of `content-pages` as well?" }, { - "prediction": "I'm not sure what you mean by this, but it looks like you're trying to use the `retrying` module to retry the `google.cloud.security.common.gcp_api._supported_apis` module. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `retrying` module to retry the `google.cloud.security.common.gcp_api._supported_apis` module. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `retrying` module to retry the `google.cloud.security.common.gcp_api._supported_apis` module. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `retrying` module to retry the `google.cloud.security.common.gcp_api._supported_apis` module. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `retrying` module to retry the `google.cloud.security.common.gcp_api._supported_apis` module. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `retrying` module to", + "prediction": "I don't think this is necessary. We can just use `google.cloud.security.common.gcp_api._supported_apis.SUPPORTED_APIS` directly.", "reference": "nit: don't think an extra line is needed here; as retrying is an installed library and should be grouped with the rest of the installed library." }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to make this optional. If you want to use the admin APIs, you can set this to `true`. If you don't want to use the admin APIs, you can set this to `false`. I'm not sure if this is a good idea, but I think it's a good idea to make this optional. If you want to use the admin APIs, you can set this to `true`. If you don't want to use the admin APIs, you can set this to `false`. I'm not sure if this is a good idea, but I think it's a good idea to make this optional. If you want to use the admin APIs, you can set this to `true`. If you don't want to use the admin APIs, you can set this to `false`. I'm not sure if this is a good idea, but I think it's a good idea to make this optional. If you want to use the admin APIs, you can set this to `true`. If you don't want to use the admin APIs, you can set this to `false`. I'm not sure if this is a good idea, but I think it's", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to make this optional. If you want to use the admin APIs, you can set this to `true`. If you don't want to use the admin APIs, you can set this to `false`.", "reference": "This should be a bool" }, { @@ -6231,7 +6231,7 @@ "reference": "`if (llvm::dyn_cast_or_null(GetSwiftType(compiler_type).getPointer())` ?" }, { - "prediction": "I'm not sure what you mean by \"duplicate manifest\" in this context. Could you please clarify?", + "prediction": "I'm not sure I understand what you're trying to do here. Can you give an example of what you're trying to do?", "reference": "The `generateVariantWorkloadManifests` function below relies on the config manifests specified in Git, but it was passed with the newly created canary's manifests where their name was updated." }, { @@ -6239,7 +6239,7 @@ "reference": "are this docs neccesary ?" }, { - "prediction": "I don't think you need to use `final` for `browserStartCommand` and `browserURL`.", + "prediction": "I don't think this is needed anymore.", "reference": "Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC." }, { @@ -6251,27 +6251,27 @@ "reference": "Is there an easy way to check for conflict suffix to avoid false positives here?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to move this into the `puppet_library` module.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to move this to the `puppet_library` module.", "reference": "`apply_prep.run_task` also seems like it can just use `@context.run_task`" }, { - "prediction": "I'm not sure what you mean by \"Wait for all sections to load\"", + "prediction": "I'm not sure what you mean by \"Wait for all sections to load\". I think it's more accurate to say \"Wait for all sections to be loaded\" or \"Wait for all pages to be loaded\".", "reference": "do you have any idea on how to fix it?" }, { - "prediction": "I think this is a bit of a red herring here. I'm not sure what you're trying to do with this test, but I think it's a bit of a red herring here. I'm not sure what you're trying to do with this test, but I think it's a bit of a red herring here. I'm not sure what you're trying to do with this test, but I think it's a bit of a red herring here. I'm not sure what you're trying to do with this test, but I think it's a bit of a red herring here. I'm not sure what you're trying to do with this test, but I think it's a bit of a red herring here. I'm not sure what you're trying to do with this test, but I think it's a bit of a red herring here. I'm not sure what you're trying to do with this test, but I think it's a bit of a red herring here. I'm not sure what you're trying to do with this test, but I think it's a bit of a red herring here. I'm not sure what you're trying to do with this test, but I think it's", + "prediction": "I think this test is a bit misleading. I think we should test that `tgt.close()` is called only once, not multiple times.", "reference": "You don't need to fix this (you've done so many iterations). But for next time, you can make this into a docstring so it'll have a nicer descriptive name when the tests are running." }, { - "prediction": "I think we can remove the `guard` here.", + "prediction": "I think we can remove the `guard` here, since it's not used anywhere else.", "reference": "When does 'expiresAt' change? Do you need this?" }, { - "prediction": "I think this should be `for (const Outfit& outfit : outfits[sex])` instead of `for (uint8_t sex = 0; sex <= 1; sex++)`", + "prediction": "I think it's better to return `nullptr` instead of `Outfit*` in this case.", "reference": "There are enums for genders + `PLAYERSEX_LAST`." }, { - "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to calculate the rollup fee based on the gas used and the execution price, but I'm not sure what you're trying to do with the `zeroes` and `ones` variables. Can you please clarify what you're trying to do with these variables?", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this.", "reference": "Should this use the constants as well? Or intentionally covering the fact that the constants may change" }, { @@ -6279,27 +6279,27 @@ "reference": "The case of a negative size (= keep all elements) was not handled in this function." }, { - "prediction": "I think this should be `system.maxWorkflowTaskTimeout` instead of `system.maxWorkflowTaskTimeout`", + "prediction": "I don't think we need to add `system.enableInfiniteTimeout` here.", "reference": "I think we should keep this dynamic config knob for operations purpose." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `move` on `textInfos.UNIT_CHARACTER`.", + "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use the `offsets` attribute of the `textInfo` object to get the offsets of the text.", "reference": "Was this intentional? Perhaps this could be replaced with another way to check the offsets?" }, { - "prediction": "I'm not sure what you mean by \"ArtifactBuckets?\"", + "prediction": "I'm not sure what you mean by \"ArtifactBuckets?\" in this context. Could you please provide more context?", "reference": "the buckets are created via the stackset, customers don't need to provide them" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to execute a search query against solr, but you're not sending the query to solr. You're sending the query to blacklight, but you're not sending it to solr. Is this what you're trying to do?", + "prediction": "I'm not sure what you mean by \"execute a search query against solr\". I think you meant to say `send_and_receive blacklight_config.solr_path, { qt: blacklight_config.qt }.merge(params)`.", "reference": "This doesn't have the same behavior as before. Maybe you want `reverse_merge` (and it either just works or we implement it on `Blacklight::Solr::Request`)" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's possible that you're trying to run `cabal update` in a non-interactive environment, but I'm not sure what you're trying to do here.", + "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to run `cabal update` in a Travis build. I'm not sure if it's a good idea to run `cabal update` in a Travis build. I'm not sure if it's a good idea to run `cabal update` in a Travis build. I'm not sure if it's a good idea to run `cabal update` in a Travis build. I'm not sure if it's a good idea to run `cabal update` in a Travis build. I'm not sure if it's a good idea to run `cabal update` in a Travis build. I'm not sure if it's a good idea to run `cabal update` in a Travis build. I'm not sure if it's a good idea to run `cabal update` in a Travis build. I'm not sure if it's a good idea to run `cabal update` in a Travis build. I'm not sure if it's a good idea to run `cabal update` in a Travis build. I'm not sure if it's a good idea to run `cabal update` in a Travis build. I'm", "reference": "This should be ` /$(ghc_find #{config[:ghc]})/ ` instead of ` /#{ghc_version}/ `, I think." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `browser` module, since it's not related to the `appSettings` module.", + "prediction": "I'm not sure if this is the right place to put this, but I think it would make sense to put it in the `browser` module, since it's used in both `android` and `chrome` contexts.", "reference": "We should deprecate this at some point." }, { @@ -6307,59 +6307,59 @@ "reference": "Move these two arguments before `loss_cls`." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to generate a self-signed certificate using the CA that was used to generate the server certificate. Is this what you're trying to do? If so, what's the purpose of the `ca *tls.Certificate` parameter?", + "prediction": "I don't think we need to use `mathrand.Int63n` here. We can just use `mathrand.Int64n` and `mathrand.Float64n` instead.", "reference": "[Super NIT]: i := serialNumber if i == 0 { i = mathrand.Int63n(...) }" }, { - "prediction": "I'm not sure what you mean by \"tool format\" in this context. It's not clear to me what you're trying to do with this option.", + "prediction": "I think this should be `tool` instead of `toolformat`.", "reference": "-f short form here collided with --force. :)" }, { - "prediction": "I'm not sure what you mean by \"rerender\" in this context.", + "prediction": "I'm not sure what you mean by `rerender`. It's not a function, it's an object.", "reference": "I think it is better to describe in the release note that `rerender()` was removed." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to run a Python script that uses the `pathod` and `mitmproxy` libraries. I'm not sure what you're trying to achieve with this, but it looks like you're trying to run a Python script that uses the `pathod` and `mitmproxy` libraries. I'm not sure what you're trying to achieve with this, but it looks like you're trying to run a Python script that uses the `pathod` and `mitmproxy` libraries. I'm not sure what you're trying to achieve with this, but it looks like you're trying to run a Python script that uses the `pathod` and `mitmproxy` libraries. I'm not sure what you're trying to achieve with this, but it looks like you're trying to run a Python script that uses the `pathod` and `mitmproxy` libraries. I'm not sure what you're trying to achieve with this, but it looks like you're trying to run a Python script that uses the `pathod` and `mitmproxy` libraries. I'm not sure what you're trying to achieve with this, but it looks", + "prediction": "I think this should be `if __name__ == \"__main__\":` instead of `if __name__ == \"__main__\": # pragma: no cover`", "reference": "We could also test this easily with `runpy.run_module`, what do you think?" }, { - "prediction": "I think this should be `if v.Type().AssignableTo(reflect.TypeOf(val))` instead of `if v.Type().AssignableTo(reflect.TypeOf(val))`", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a check for `reflect.ValueOf(val) == reflect.ValueOf(val)` to make sure we don't try to set a value that doesn't match the type of the value.", "reference": "Is it OK to fall through if it's not assignable? I was kind of surprised when the tests passed. Maybe one of the options below ends up working? For the new tests, this panics because `**not assignable uuid.UUID to []uint8**`. `uuid.UUID` is an array, not a slice." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think we need to change anything here.", + "prediction": "I'm not sure what you mean by \"blockpAPI\" and \"retrievalAPI\" in this context. Could you please clarify?", "reference": "I know this is after the fact but imo blockAPI should be blockMiningAPI." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate pattern for the system attribute prefix.", + "prediction": "I think this should be `self::SYSTEM_ATTRIBUTE_PATTERN` instead of `self::SYSTEM_ATTRIBUTE_PREFIX`.", "reference": "it's just a pattern as it was. SystemAttributeCode should have it's own definition and validate by it" }, { - "prediction": "I think we can remove the `cpp2::LookUpIndexRequest` parameter.", + "prediction": "I think it's better to use `cpp2::LookUpEdgeIndexRequest` instead of `cpp2::LookUpIndexRequest` because `cpp2::LookUpIndexRequest` is more specific than `cpp2::LookUpEdgeIndexRequest` and `cpp2::LookUpEdgeIndexRequest` is more specific than `cpp2::LookUpIndexRequest`.", "reference": "Similar to the code block when we use prefix, maybe we can unify them to base?" }, { - "prediction": "I think we can remove the `ValidatePodchaosSchedulerError` here.", + "prediction": "I think this should be `ValidatePodchaosSchedulerError` instead of `ValidatePodchaosScheduler`", "reference": "I think `Duration` is useful for this action and we shouldn't ignore it." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `Write` method.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that we don't accidentally write past the end of the buffer.", "reference": "Everything below here can be replaced with `return s.err, len(p) - len(s.dataForWriting)`." }, { - "prediction": "I'm not sure what you mean by \"atomic\" in this context. It's not clear to me what you're trying to do here.", + "prediction": "I think it's better to use `HIP_SAFE_CALL(hipMalloc(...))` instead of `HIP_SAFE_CALL(hipMalloc(&g_host_hip_lock_arrays.atomic, ...))`.", "reference": "Again, we can also guard `g_host_hip_lock_arrays.atomic`, can't we?" }, { - "prediction": "I'm not sure if this is the best place to do this, but I think it's a good idea to add a check here to make sure that the `ImportProductAttributesValueCommand` is actually a valid command before dispatching it.", + "prediction": "I don't think we need to do this anymore.", "reference": "Variable name should start from lowercase latter" }, { - "prediction": "I don't think this is a good idea. It's not clear to me what the purpose of this test is. Is it to make sure that the certificate is issued correctly? Or is it to make sure that the certificate is not issued at all? Or is it to make sure that the certificate is issued with the correct CA and private key? Or is it to make sure that the certificate is not issued with the correct CA and private key? Or is it to make sure that the certificate is not issued with the correct CA and private key? Or is it to make sure that the certificate is not issued with the correct CA and private key? Or is it to make sure that the certificate is not issued with the correct CA and private key? Or is it to make sure that the certificate is not issued with the correct CA and private key? Or is it to make sure that the certificate is not issued with the correct CA and private key? Or is it to make sure that the certificate is not issued with the correct CA and private key? Or is it to make sure that the certificate is not issued with the correct CA and private key? Or is it to make sure that the certificate is not issued with the correct CA and private key? Or is it to make sure", + "prediction": "I don't think we need to use `context.WithTimeout` here. We can use `context.WithDeadline` instead.", "reference": "Why has this timeout doubled?" }, { - "prediction": "I'm not sure if this is a good idea, but I think we should have a default of 30 seconds for the iptables lock timeout, and 50 milliseconds for the ipset refresh interval.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to set the `IptablesLockTimeoutSecs` and `IptablesLockProbeIntervalMillis` to 0.", "reference": "Should IptablesPostWriteCheckIntervalSecs be set back to its previous smaller value, if use of the iptables lock is disabled?" }, { @@ -6367,99 +6367,99 @@ "reference": "You're missing a `return` here, but I'll add it :smile:" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the texture is in the correct state before calling `gles2_get_texture` and `gles2_get_shader`. This way, we can make sure that the texture is in the correct state before calling `gles2_get_texture` and `gles2_get_shader`, and we can make sure that the texture is in the correct state after calling `gles2_get_texture` and `gles2_get_shader`. I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the texture is in the correct state before calling `gles2_get_texture` and `gles2_get_shader`. This way, we can make sure that the texture is in the correct state before calling `gles2_get_texture` and `gles2_get_shader`, and we can make sure that the texture is in the correct state after calling `gles2_get_texture` and `gles2_get_shader`. I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the texture is in the correct state before calling `gles2_get_texture` and `gles", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the `wlr_gles2_texture` struct.", "reference": "Can you try adding back this assertion? I'd like to assert that the texture has been created in the same context as the renderer." }, { - "prediction": "I'm not sure what you mean by \"write\" and \"create\" in this context. Could you please clarify?", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check to see if the targetted record already exists, and return \"write\" if it does, \"create\" otherwise.", "reference": "This won't work with Python 3 because it will already be a string. In that case we need to use `decode_header` from utils." }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place", + "prediction": "I think this should be `if self.respond_to?(:_clear_types)` instead of `if self.respond_to?(:_clear_types if self.respond_to?(:_clear_types))`", "reference": "Why is the respond_to check here?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right way to do it.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do it here, since it will be used in other places as well.", "reference": "@orklah are you sure it's the same as `$chars[$i]`? It looks like `$i` is changed above, after `$char` assignment." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `cpp2::AddVerticesRequest` here. It's not clear what you're trying to do with this request. If you want to add vertices to a space, you should use `cpp2::AddVerticesRequestWithSpaceId` instead.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `AddVerticesProcessor` class.", "reference": "I have a question? How do I construct a indexManager for testcase?" }, { - "prediction": "I'm not sure if this is a good place to put this, but I think we should move it to `xfpga_api.h` so that it can be used in other places as well.", + "prediction": "I think this should be `dlsym(adapter->plugin.dl_handle, \"xfpga_fpgaOpen\")` and `dlsym(adapter->plugin.dl_handle, \"xfpga_fpgaClose\")`", "reference": "These checks aren't needed. See pluginmgr.c : opae_plugin_mgr_load_dflt_plugins( )." }, { - "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea to return `false` in this case.", + "prediction": "I don't think this is needed anymore.", "reference": "Please take a care about prefixing." }, { - "prediction": "I'm not sure I understand what you're trying to do with this method. It seems like you're trying to create a new account, but then you're trying to retrieve an existing account. Is this what you're trying to do? If so, what's the purpose of this method?", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a method like this in the `WorldUpdater` interface, so that we don't have to call `getOrCreateSenderAccount(address)` every time we want to retrieve an account for a sender of a transaction.", "reference": "this line doesn't match what the rest says" }, { - "prediction": "I don't think this is a good idea.", + "prediction": "I don't think we need to change anything here.", "reference": "Since it's not working for linux, maybe leave the !linux in there as well?" }, { - "prediction": "I think this should be `if _, ok := s.w.Sources[k]; ok {` instead of `if v == \"\" {`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the source already exists in the workflow. If it does, then we can just return an error. If it doesn't, then we can add the source to the workflow.", "reference": "Should we remove the key-value pair entirely? Same for workflows in general. We have a \"sourceExists\" method that checks if a key is there if I remember correctly." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `SyncManager` class, so that we don't have to call `sendSync` every time we want to run a query.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's the right way to do it.", "reference": "Unrelated bug fix" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason you want to change the title of the notification?", + "prediction": "I don't think we need to use `replace` here, we can just use `replace` directly.", "reference": "We probably want to let the translation library handle the string replacement for these as well." }, { - "prediction": "I don't think we need to add this flag to the `list_db` command. The `list_db` command should be able to list all the members of the cluster, so we don't need to add this flag to the `list_db` command. We can remove this flag from the `list_db` command and add it to the `list_members` command.", + "prediction": "I don't think we need this flag. It's not used anywhere.", "reference": "should combine these 2 list (list_gossip and list_db) into just one list command, and show the discrepancy between the 2 if any." }, { - "prediction": "I'm not sure what you mean by \"approve_reject?\"", + "prediction": "I think this should be `include?` instead of `include?`", "reference": "What do you think about prefixing the Policy method names with `can_`?" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to use the `AWS_CREDENTIAL_RESPONSE_ACCESS_KEY`, `AWS_CREDENTIAL_RESPONSE_SECRET_KEY`, `AWS_HTTP_RESPONSE_ACCESS_KEY`, `AWS_HTTP_RESPONSE_SECRET_KEY`, `AWS_HTTP_RESPONSE_TOKEN`, and `AWS_HTTP_RESPONSE_EXPIRATION` variables. I'm not sure what you're trying to do here, but it looks like you're trying to use the `AWS_CREDENTIAL_RESPONSE_ACCESS_KEY`, `AWS_CREDENTIAL_RESPONSE_SECRET_KEY`, `AWS_HTTP_RESPONSE_ACCESS_KEY`, `AWS_HTTP_RESPONSE_SECRET_KEY`, `AWS_HTTP_RESPONSE_TOKEN`, and `AWS_HTTP_RESPONSE_EXPIRATION` variables. I'm not sure what you're trying to do here, but it looks like you're trying to use the `AWS_CREDENTIAL_RESPONSE_ACCESS_KEY`, `AWS_CREDENTIAL_RESPONSE_SECRET_KEY`, `AWS_HTTP_RESPONSE_ACCESS_KEY`, `AWS_HTTP_RESPONSE_SECRET_KEY`, `AWS_HTTP_RESPONSE_TOKEN`, and `AWS_HTTP_RESPONSE_EXPIRATION` variables. I'm not sure what you're trying to do here, but it looks like you're trying to use the `AWS_CREDENTIAL_RESPONSE_ACCESS_KEY`, `AWS_CREDENTIAL_RESPONSE_SECRET_KEY`, `AWS_HTTP_RESPONSE_ACCESS_KEY`, `AWS_HTTP_RESPONSE_SECRET_KEY`,", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to use the `AWS_CREDENTIAL_RESPONSE_ACCESS_KEY`, `AWS_CREDENTIAL_RESPONSE_SECRET_KEY`, `AWS_CREDENTIAL_RESPONSE_EXPIRATION`, and `AWS_HTTP_RESPONSE_ACCESS_KEY`, `AWS_HTTP_RESPONSE_SECRET_KEY`, `AWS_HTTP_RESPONSE_TOKEN`, and `AWS_HTTP_RESPONSE_EXPIRATION` variables. I'm not sure what you're trying to do here, but it looks like you're trying to use the `AWS_CREDENTIAL_RESPONSE_ACCESS_KEY`, `AWS_CREDENTIAL_RESPONSE_SECRET_KEY`, `AWS_CREDENTIAL_RESPONSE_EXPIRATION`, and `AWS_HTTP_RESPONSE_ACCESS_KEY`, `AWS_HTTP_RESPONSE_SECRET_KEY`, `AWS_HTTP_RESPONSE_TOKEN`, and `AWS_HTTP_RESPONSE_EXPIRATION` variables. I'm not sure what you're trying to do here, but it looks like you're trying to use the `AWS_CREDENTIAL_RESPONSE_ACCESS_KEY`, `AWS_CREDENTIAL_RESPONSE_SECRET_KEY`, `AWS_CREDENTIAL_RESPONSE_EXPIRATION`, and `AWS_HTTP_RESPONSE_ACCESS_KEY`, `AWS_HTTP_RESPONSE_SECRET_KEY`, `AWS_HTTP_RESPONSE_TOKEN`, and `AWS_HTTP_RESPONSE_EXPIRATION` variables. I'm not sure what you're trying to do here, but it looks like you're trying to use the `AWS_C", "reference": "Based on the docs, credential process can return a key `SessionToken`" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get the current date and time, and then compare it to the birth date. I'm not sure what you're trying to do here, but it looks like you're trying to get the current date and time, and then compare it to the birth date. I'm not sure what you're trying to do here, but it looks like you're trying to get the current date and time, and then compare it to the birth date. I'm not sure what you're trying to do here, but it looks like you're trying to get the current date and time, and then compare it to the birth date. I'm not sure what you're trying to do here, but it looks like you're trying to get the current date and time, and then compare it to the birth date. I'm not sure what you're trying to do here, but it looks like you're trying to get the current date and time, and then compare it to the birth date. I'm not sure what you're trying to do here, but it looks like you're trying to get the current date and time, and then compare it to the birth date. I'm not sure", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to set the date to today's date, and then subtract the birth date from it. I'm not sure what you're trying to do here, but it looks like you're trying to set the date to today's date, and then subtract the birth date from it. I'm not sure what you're trying to do here, but it looks like you're trying to set the date to today's date, and then subtract the birth date from it. I'm not sure what you're trying to do here, but it looks like you're trying to set the date to today's date, and then subtract the birth date from it. I'm not sure what you're trying to do here, but it looks like you're trying to set the date to today's date, and then subtract the birth date from it. I'm not sure what you're trying to do here, but it looks like you're trying to set the date to today's date, and then subtract the birth date from it. I'm not sure what you're trying to do here, but it looks like you're trying to set the date to today's date, and then subtract the birth date", "reference": "I think this if should be removed (see issue)" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add a comment to explain what this change does.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure it's a good idea.", "reference": "I would avoid importing `felix/ipsets` package because this package is the windows equivalent and should be at the same level of `felix/ipsets`. We could add linux specific dependencies into `felix/ipsets` later and it will break Windows build." }, { - "prediction": "I don't think we need to import `os` here. It's already imported in the `__init__.py` file.", + "prediction": "I don't think we need to import `os` here. It's already imported in `asciidoc_generator.py`.", "reference": "nitpick: Please move this down to the other imports, as it's a Python stdlib import." }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific use case you have in mind? If so, please provide more details.", + "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason why you'd want to use this package?", "reference": "\"for getting started guides\" reads a bit weird, like it's missing punctuation. Maybe just \"for a tutorial\"?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to make this a private method. It's a bit of a hack, but I think it's the best way to do this.", + "prediction": "I don't think it's necessary to use `false` for `urc` and `uc`.", "reference": "This looks like a dead parameter -- maybe a copy and paste error. If it's truly unused, maybe you can open a separate PR to simply delete it, and then it's one less detail to worry about here." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think we need to change the type of `row[i]` to `values.NewTime(values.ConvertTime(col))`.", + "prediction": "I'm not sure if this is the best way to go about this, but I think it's a good idea to use `values.NewInt` and `values.NewTime` instead of `values.NewInt64` and `values.NewTime64` because `values.NewInt64` and `values.NewTime64` are more specific than `values.NewInt` and `values.NewTime`. I'm not sure if this is the best way to go about this, but I think it's a good idea to use `values.NewInt` and `values.NewTime` instead of `values.NewInt64` and `values.NewTime64` because `values.NewInt64` and `values.NewTime64` are more specific than `values.NewInt` and `values.NewTime`. I'm not sure if this is the best way to go about this, but I think it's a good idea to use `values.NewInt` and `values.NewTime` instead of `values.NewInt64` and `values.NewTime64` because `values.NewInt64` and `values.NewTime64` are more specific than `values.NewInt` and `values.NewTime`. I'm not sure", "reference": "Nit: Should we add support for `int` and `uint` in the `values.New()` function? That would allow us to to handle all of these types in one case. Maybe there's a good reason why we don't do that already, but I'm not sure what it is." }, { - "prediction": "I'm not sure what you mean by \"cache friendly\" here.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `RuleViolation` class.", "reference": "if you are not dealing with cache now, please revert these changes. On their own they make little sense" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to add a method to the containing class or interface, but it's not there. I'm not sure what you're trying to do here, but it looks like you're trying to add a method to the containing class or interface, but it's not there. I'm not sure what you're trying to do here, but it looks like you're trying to add a method to the containing class or interface, but it's not there. I'm not sure what you're trying to do here, but it looks like you're trying to add a method to the containing class or interface, but it's not there. I'm not sure what you're trying to do here, but it looks like you're trying to add a method to the containing class or interface, but it's not there. I'm not sure what you're trying to do here, but it looks like you're trying to add a method to the containing class or interface, but it's not there. I'm not sure what you're trying to do here, but it looks like you're trying to add a method to the containing class or interface, but it's not there. I'm not sure", "reference": "Wearing my extra-douche-bag hat I would say not spaces on a blank line. Maybe at some point we could have some automated process remove these things. For now I would not bother changing it." }, { - "prediction": "I think this should be `public static final class ShowRemainTimeUpdateEvent {}`", + "prediction": "Shouldn't this be `public static ShowRemainTimeUpdateEvent`?", "reference": "I think it would be better to use an `ItemUpdatedEvent` like for the \"prefer streaming\" preference. We already have a ton of events that need to be handled in all list fragments that just do the same everywhere. I think we could even remove some of the existing events in the future." }, { @@ -6467,15 +6467,15 @@ "reference": "I think we have to manually write a down for this migration." }, { - "prediction": "I don't think this is a good idea. It's not clear what the purpose of this check is. I think we can remove it.", + "prediction": "I don't think this is a good idea. It's not clear to me why we would want to do this.", "reference": "I don't think we still need this check, but I'd leave it as an assertion for now." }, { - "prediction": "I'm not sure what you mean by \"may be replaced with paper-trail or similar at some point\"", + "prediction": "I'm not sure what you're trying to do with this, but I think it's a bad idea to have `self.updated_at.to_i` instead of `self.updated_at` in the `version` method.", "reference": "Since this may be the case, wondering if we should call the param `updated_at_i` or something so that we don't run into a problem distinguishing them down the road?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you want to merge the files into the trace file. I think you want to create a new trace file with the same name as the original trace file, but with a different extension.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a separate method, so that we don't have to call this method every time we want to run a test.", "reference": "wondering why we need to join the paths here; seems evt.commandLine only takes whatever appExe is" }, { @@ -6483,11 +6483,11 @@ "reference": "1.not format code 2.failed but still continue? 3.\"UTF-8\" can changed to java.nio.charset.StandardCharsets.UTF_8.name()" }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to have a separate file for this, so that we don't have to worry about it being in the wrong place.", + "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. Is it that you want to create a new class that inherits from `astroid.brain.brain_dataclasses.BrainDataClasses`? If so, I think you should just inherit from `astroid.brain.brain_dataclasses.BrainDataClasses` directly.", "reference": "I'm wondering if we should add this to a `utils` module in `astroid`. Porting the util to `pylint` doesn't make sense as we would need to duplicate the globals that are being used in the function, but importing from `brain` also feels weird. @Pierre-Sassoulas Do you have an opinion?" }, { - "prediction": "I'm not sure what you're trying to achieve with this code, but it looks like you're trying to stop the request processing, but you're not waiting for the `TakeMessageHeaders` call to complete. I think you need to wait for the `TakeMessageHeaders` call to complete before continuing with the rest of the code.", + "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do it.", "reference": "This seems different than what we do for corrupted request headers. I would like to determine the correct behavior and consolidate this logic." }, { @@ -6495,11 +6495,11 @@ "reference": "Please make the change in the CAI inventory, rather than changing the scanner." }, { - "prediction": "I'm not sure what you're trying to achieve here. The `AbstractJspNode` is just a base class for all JSP nodes. It's not clear what you're trying to do with this class.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. The `AbstractJspNode` is a base class for all `JspNode` classes. If you want to extend `AbstractJspNode`, then you need to extend `AbstractNode` as well. If you want to extend `AbstractNode`, then you need to extend `AbstractJspNode` as well.", "reference": "adding this `abstract` is a breaking API change. Even though I agree it makes perfect sense to have it, we can't break this API until PMD 7.0.0. We should revert this particular change. We could make a reminder ticket like we did with #463 for 6.0.0" }, { - "prediction": "I'm not sure what you mean by \"only includes active plans\"", + "prediction": "I'm not sure what you mean by \"only includes active plans\". I think you meant to say \"only includes plans that are active\" or something like that.", "reference": "This is following the existing convention, but I'm not sure the convention is a good one. I think it would be better to have one shared example group: - It means we don't need to add new example groups twice every time. - If the shared example group looks large, that makes it more obvious that our team models have too much shared behavior. I don't want to do anything about this right now (I'm pretty sure I can wipe out this shared example group when I change team plans), but it's good to keep in mind." }, { @@ -6507,11 +6507,11 @@ "reference": "I do not think we need to do a source code change to handle this. We could set the subnetwork to default to /32 (/128 for ipv6 ipv4-mapped)" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a `--delete` option to the `ostree` command.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to use `ostree_repo_delete_cookie` instead of `ostree_option_context_parse`.", "reference": "It looks good overall! The only issue I have is that the description string is now duplicated twice right? Once in the struct and once in the parameter string? Maybe let's pass the struct to the command so that `ostree_option_context_parse` can set it as the summary? Similar to what we do in rpm-ostree." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new class that extends `DriverCommandExecutor` and override the `executeCommand` method to return a new instance of `ChromeDriverCommandExecutor`. Is this what you're trying to do?", + "prediction": "I don't think we need to use `ImmutableMap` here. We can just use a `Map`.", "reference": "This states very clearly that this is a derivative of Chrome and not Chromium. Do we need to extract an abstract `ChromiumCommandExecutor` and have both Edge and Chrome derive from that?" }, { @@ -6519,31 +6519,31 @@ "reference": "it seems to me, the issue lies on `isEnum()` itself, returning false for something that is an enum. I'd rather change it there than here." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.", + "prediction": "I'm not sure I understand what you're trying to do here.", "reference": "Please use `{}` instead of `dict()`" }, { - "prediction": "I'm not sure what you're trying to do with this prop, but I think it's a bad idea to use `useInView` in this case.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to use `useRef` instead of `useImperativeHandle` in this case.", "reference": "I have concerns about using this in more places before #3278 - I'll take a look at that again shortly." }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.", + "prediction": "I don't think we need to do this. We can just use the `Receipt` struct directly.", "reference": "new field needs to be asserted" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `Host` class, so that it can be used by other classes as well.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that `self->lastLogIdSent_` is set before `self->noMoreRequestCV_.notify_all()`.", "reference": "when send log failed, why update the last sent log id?" }, { - "prediction": "`prepend` and `append` should be the same method.", + "prediction": "`prepend` and `append` should be `public Tuple1 prepend(T value)` and `public Tuple1 append(T value)`", "reference": "what was the problem with the previous order? `prepend` comes conceptually before `append`, i.e. `insert before` should be before `insert after`, I think" }, { - "prediction": "I think we can remove the `map[string]string` here.", + "prediction": "I'm not sure if this is the right place to put it, but I think it should be in the `BackupInfo` struct.", "reference": "Why is this necessary? Could you provide some context?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to add a `style` attribute to the `` tag, but I don't think that's what you're trying to do here.", + "prediction": "I don't think we need to change the `style type='text/css'>` to `style='text/css'` in this case.", "reference": "Is there a recommended quote style for attributes? I see single and double here, double further down." }, { @@ -6559,43 +6559,43 @@ "reference": "FYI @lucaspimentel and @colin-higgins since you have already approved, I wanted to point out this required change. By fixing `FrameworkDescription` to use the correct logger, it created a cycle between these two static constructors, so I'm removing this log line and delaying it to when it's actually constructed later in the Tracer. Let me know if you find that acceptable or have any suggestions." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", "reference": "Ah, so we are going to need to update node/host files for this to work?" }, { - "prediction": "I think we can remove the `Function` from the constructor.", + "prediction": "I don't think this is necessary.", "reference": "This code is new and not tested well. While we may drop the log level before we ship 4.0, right now this is extremely helpful to users." }, { - "prediction": "I'm not sure what you mean by \"current_user == observation.user\" in this context. I think you meant to say \"current_user == self.observation.user\".", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `ObservationsController` so that it can be used by other controllers as well.", "reference": "used named path (`proposals_path`) instead?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `item_view` table instead of the `bib_record_item_record_link` table. The `item_view` table has the `is_suppressed` field, which is `false` by default, so we don't need to check for that.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `pg_query_params` for this query.", "reference": "Am I misreading something, or is there a mismatched parenthesis here? Please let me know whether or not this is cause for concern -- just wanted to be totally sure before merging, since I can't test this from here. Thanks!" }, { - "prediction": "I think we can remove this line, as it's not used anymore.", + "prediction": "I think it's better to use `transport.UpdateSpanWithErr` instead of `transport.UpdateSpanWithErrWithErr` here.", "reference": "Might we want a hook to allow emitting metrics or logs in the case of a permitted empty service header response (or similar UpdateSpanWithErr on empty service header in response if strict enforcement is desired by the caller)?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to set the protocol to `https`, but you're not passing it to the `Filesystem` constructor, so it defaults to `http`. Is this what you're trying to do?", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `kwargs.get(\"protocol\", \"https\")` instead of `kwargs.get(\"protocol\") or \"https\"`. This way, if `kwargs.get(\"protocol\")` is `None`, then `kwargs.get(\"protocol\") or \"https\"` will be `None` as well.", "reference": "if using dict.get, this could just be `kwargs.get('protocol', 'https')`" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a method that returns the name of a variable to hold a value for the given proto message field (such as a flattened parameter). This way, we don't have to create a new method every time we want to get the name of a variable to hold a value for the given proto message field (such as a flattened parameter).", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a method that returns the name of a variable to hold a value for the given proto message field (such as a flattened parameter).", "reference": "Add docs to the new methods here" }, { - "prediction": "I think this should be `ShouldPrune(in long currentMemory)` instead of `ShouldPrune(in long currentMemory, in long memoryLimit)`?", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a `MemoryLimit` property to the `Nethermind.Trie.Pruning` class.", "reference": "what does it mean enabled?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `onUpgrade` method of the `DBOpenHelper` class.", "reference": "Getting an error when calling with db.execSQL (in sqlcipher 4.3.0, pragma returns ok)." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this", + "prediction": "I don't think we need to use the `isP` variable here. We can just use `ctx.User.IsAuthenticated()` instead.", "reference": "Maybe we could remove `\" \" + ctx.Tr(\"dashboard\")` completely?" }, { @@ -6603,55 +6603,55 @@ "reference": "Simple Storage **Service**" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a new struct that implements the `jsonHandler` interface, but you're not using the `jsonHandler2` struct to do so.", + "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to have a separate struct for the handler.", "reference": "Let's add some assertions here to ensure we don't panic. Length of results. Conditionally cast second result to error." }, { - "prediction": "I think this should be `KeepAliveTimeout` instead of `KeepAliveTimeout`", + "prediction": "I think this should be a property, not a static field.", "reference": "Where did we take this default from?" }, { - "prediction": "I think it's a good idea to remove the `options.compareStartDate` and `options.compareEndDate` parameters.", + "prediction": "I think it's better to use `options.startDate` and `options.endDate` instead of `options.compareStartDate` and `options.compareEndDate`.", "reference": "Let's move these down to be after all required arguments rather than in between." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to clear the `sharedStringMap` here.", "reference": "Should we just null the Map and let the GC handle the memory? Clearing just removes items, but not capacity, so this would leave some memory on the table." }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use the same logger for all handlers.", + "prediction": "I don't think we need to use `newHandler` here. We can just use `newHandler(i, i.t.options.logger)`.", "reference": "did you mean to delete this line?" }, { - "prediction": "I'm not sure what you mean by \"getDataverseException Compound: \" and \"getDataverseException Regular: \" in this case. I'm not sure what you mean by \"getDataverseException Regular: \" in this case. I'm not sure what you mean by \"getDataverseException Regular: \" in this case. I'm not sure what you mean by \"getDataverseException Regular: \" in this case. I'm not sure what you mean by \"getDataverseException Regular: \" in this case. I'm not sure what you mean by \"getDataverseException Regular: \" in this case. I'm not sure what you mean by \"getDataverseException Regular: \" in this case. I'm not sure what you mean by \"getDataverseException Regular: \" in this case. I'm not sure what you mean by \"getDataverseException Regular: \" in this case. I'm not sure what you mean by \"getDataverseException Regular: \" in this case. I'm not sure what you mean by \"getDataverseException Regular: \" in this case. I'm not sure what you mean by \"getDataverseException Regular: \" in this case. I'm not sure what you mean", + "prediction": "I'm not sure what you mean by \"getDataverseException Compound: \" and \"getDataverseException Regular: \" I'm not sure what you mean by \"getDataverseException Regular: \" I'm not sure what you mean by \"getDataverseException Regular: \" I'm not sure what you mean by \"getDataverseException Regular: \" I'm not sure what you mean by \"getDataverseException Regular: \" I'm not sure what you mean by \"getDataverseException Regular: \" I'm not sure what you mean by \"getDataverseException Regular: \" I'm not sure what you mean by \"getDataverseException Regular: \" I'm not sure what you mean by \"getDataverseException Regular: \" I'm not sure what you mean by \"getDataverseException Regular: \" I'm not sure what you mean by \"getDataverseException Regular: \" I'm not sure what you mean by \"getDataverseException Regular: \" I'm not sure what you mean by \"getDataverseException Regular: \" I'm not sure what you mean by \"getDataverseException Regular: \" I'm not sure what you mean by \"getDataverseException Regular: \" I'm not sure what you mean", "reference": "Should we use logger instead?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to test that `analytics?` returns `true` when `ENV['ANALYTICS']` is present, but I don't think that's what you're trying to test here.", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to test that `analytics?` returns `true` when `ENV['ANALYTICS']` is present, but it's not. I think you're trying to test that `analytics?` returns `false` when `ENV['ANALYTICS']` is not present, but it's not.", "reference": "I think it would be preferred to do `expect(helper).to be_analytics`" }, { - "prediction": "I think this should be `if isinstance(key, (str, tuple, list, pd.Index)):`", + "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here. If you want to do something like `df.loc[:, key]` then you should use `loc[:, key]` instead of `df.loc[:, key]`. If you want to do something like `df.loc[:, key]` then you should use `loc[:, key]` instead of `df.loc[:, key]`.", "reference": "Actually, I think it's okay to just change to `if isinstance(key, (str)) or is_list_like(key):` and `key = list(key) if is_list_like(key) else key` for simplicity for now." }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to make sure that the `RunId` is always set to an empty string. This way, we don't have to worry about the case where the `RunId` is set to a non-empty string.", + "prediction": "I don't think we need to do this.", "reference": "If there any other tests, I would make it optional there also." }, { - "prediction": "I'm not sure what you're trying to achieve with this route, but it looks like you're trying to route to the `show` action of the `Workshops::Pages` controller. I'm not sure what you're trying to achieve with this route, but it looks like you're trying to route to the `show` action of the `Workshops::Pages` controller. I'm not sure what you're trying to achieve with this route, but it looks like you're trying to route to the `show` action of the `Workshops::Pages` controller. I'm not sure what you're trying to achieve with this route, but it looks like you're trying to route to the `show` action of the `Workshops::Pages` controller. I'm not sure what you're trying to achieve with this route, but it looks like you're trying to route to the `show` action of the `Workshops::Pages` controller. I'm not sure what you're trying to achieve with this route, but it looks like you're trying to route to the `show` action of the `Workshops::Pages` controller. I'm not sure what you're trying to achieve with this route, but it looks like you're trying to", + "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to have a separate route for `my-accounts` and `watch`.", "reference": "This can be removed too, right?" }, { - "prediction": "I'm not sure what you're trying to do here, but I'm not sure if this is the right place to do this.", + "prediction": "I'm not sure what you're trying to do here, but I don't think this is the right place to do it.", "reference": "If you're going to allow people to specify multiple SMTP servers, you should also properly export/import them." }, { - "prediction": "I think we can remove the `CurrentRequests` and `FailedRequests` fields.", + "prediction": "I think we should remove the `CurrentRequests` and `FailedRequests` fields.", "reference": "nit: Can we prefix these variables with `AspNetCore`?" }, { - "prediction": "I think we can remove the `ssh: true` as it's not necessary.", + "prediction": "I think this should be a test for `yaml::convert` instead of `yaml::plan`?", "reference": "Can this also include a quick test for transpiling by name?" }, { @@ -6663,11 +6663,11 @@ "reference": "can we make tabAccessibilityIdentifier = null as default?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that we're shutting down the exporter before we shutdown the processor.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `context.Background()` instead of `context.WithValue()` in this case.", "reference": "Should we print this error?" }, { - "prediction": "I think this should be `bboxes = multi_bboxes.view(multi_scores.size(0), -1, 4)`", + "prediction": "I think this should be `num_classes = multi_scores.size(1) - 1` instead of `num_classes = int(multi_scores.size(1) - 1)`", "reference": "For which reason do we need to convert this to int here?" }, { @@ -6675,7 +6675,7 @@ "reference": "FWIW, wondering if the error is interesting here (I actually arrived at this code initially to change `supportsFreezer()` to return a `bool`" }, { - "prediction": "I think it's better to use `fa fa-exclamation-circle` instead of `fa fa-exclamation-circle fa-rotate-180`", + "prediction": "I don't think we need to use `fa` here. We can just use `icon` instead.", "reference": "Does this still need to be a partial? is the intention down the line to move back towards a conditionally different title?" }, { @@ -6683,35 +6683,35 @@ "reference": "seems like `RegistryURL` is missing? Same for a few other places that create `archer.Environment` below." }, { - "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `logging` in this way. It's not a good idea to use `logging` in this way. It's not a good idea to use `logging` in this way. It's not a good idea to use `logging` in this way. It's not a good idea to use `logging` in this way. It's not a good idea to use `logging` in this way. It's not a good idea to use `logging` in this way. It's not a good idea to use `logging` in this way. It's not a good idea to use `logging` in this way. It's not a good idea to use `logging` in this way. It's not a good idea to use `logging` in this way. It's not a good idea to use `logging` in this way. It's not a good idea to use `logging` in this way. It's not a good idea to use `logging` in this way. It's not a good idea to use `logging` in this way. It's not a good idea to use `logging` in this way.", + "prediction": "`logging` is already imported from `pyparsing`, so we don't need to import it again.", "reference": "Are these imports needed?" }, { - "prediction": "I'm not sure what you mean by \"ignore fallback inputs\". I'm not sure what you mean by \"ignore fallback inputs\". I'm not sure what you mean by \"ignore fallback inputs\". I'm not sure what you mean by \"ignore fallback inputs\". I'm not sure what you mean by \"ignore fallback inputs\". I'm not sure what you mean by \"ignore fallback inputs\". I'm not sure what you mean by \"ignore fallback inputs\". I'm not sure what you mean by \"ignore fallback inputs\". I'm not sure what you mean by \"ignore fallback inputs\". I'm not sure what you mean by \"ignore fallback inputs\". I'm not sure what you mean by \"ignore fallback inputs\". I'm not sure what you mean by \"ignore fallback inputs\". I'm not sure what you mean by \"ignore fallback inputs\". I'm not sure what you mean by \"ignore fallback inputs\". I'm not sure what you mean by \"ignore fallback inputs\". I'm not sure what you mean by \"ignore fallback inputs\". I'm not sure what you mean by \"ignore fallback inputs\". I'm not sure what you mean by \"ignore fallback inputs\". I'm not sure what you mean by \"ignore fallback inputs\". I'm not sure what you mean by \"", + "prediction": "I'm not sure what you mean by \"ignore fallback inputs\" but I think it's a good idea to add a test for this.", "reference": "I think you can remove the `(isIE11 ? it.skip : it)(` above, if you're going to skip the test this way." }, { - "prediction": "I think this should be `out.writeLong(checksum);` instead of `out.writeLong(actualChecksumIn);`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to check the checksum of the original file before copying it to the destination. This way we can make sure that the checksum of the original file is the same as the checksum of the copied file.", "reference": "IMO we should instead fix the above call to do `long actualChecksumIn = Long.reverseBytes(in.readLong());` to get the actual checksum value? This way the below error message would also be correct?" }, { - "prediction": "I think we can remove the `if len(repackPacks) != 0` check here.", + "prediction": "I think we should be able to do this in a single call to `DeleteFiles` instead of two separate calls to `DeleteFiles` and `DeleteIndexFiles`.", "reference": "I think we also need something similar for `rebuild-index`?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure", + "prediction": "I'm not sure I understand what you're trying to do here. What do you mean by `defaultBundleEndpointPort = 443`?", "reference": "I think convention is snake case for import naming?" }, { - "prediction": "I think it's better to use `tableInfo.getPrimaryKey().getIndexColumns()` instead of `tableInfo.getColumn(col.getName()).toProto(tableInfo)`.", + "prediction": "I think this should be `if (!tableInfo.isCommonHandle()) { indexScanBuilder.addColumns(handleColumn); } else { for (TiIndexColumn col : tableInfo.getPrimaryKey().getIndexColumns()) { indexScanBuilder.addColumns(tableInfo.getColumn(col.getName()).toProto(tableInfo)); } }`", "reference": "i think haspk is false?" }, { - "prediction": "I'm not sure what you mean by \"does not work with all test types\". I'm not sure what you mean by \"does not work with all test types\". I'm not sure what you mean by \"does not work with all test types\". I'm not sure what you mean by \"does not work with all test types\". I'm not sure what you mean by \"does not work with all test types\". I'm not sure what you mean by \"does not work with all test types\". I'm not sure what you mean by \"does not work with all test types\". I'm not sure what you mean by \"does not work with all test types\". I'm not sure what you mean by \"does not work with all test types\". I'm not sure what you mean by \"does not work with all test types\". I'm not sure what you mean by \"does not work with all test types\". I'm not sure what you mean by \"does not work with all test types\". I'm not sure what you mean by \"does not work with all test types\". I'm not sure what you mean by \"does not work with all test types\". I'm not sure what you mean by \"does not work with all test types\". I", + "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to pass in a directory to the `surefire-reports` command. I'm not sure if that's what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're", "reference": "you should add this to the cover command too (but let's have a more general convo about whether it's a flag or config option)" }, { - "prediction": "I think we should use `metrics.NewClient(&metrics.ClientConfig{}, scope, metrics.HistoryArchiverScope)` instead of `metrics.NewClient(scope, metrics.HistoryArchiverScope)`.", + "prediction": "I think we should remove the `metrics.NewClient(&metrics.ClientConfig{}, scope, metrics.HistoryArchiverScope)` line.", "reference": "instead of passing in pointer to empty struct, we should make it optional and support passing nil and use default cfg if it is nil." }, { @@ -6719,43 +6719,43 @@ "reference": "A fair bit faster, although still not great, hence also adding a hashkey." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way", + "prediction": "I think it's better to use `progress` instead of `numerical-progress` in this case.", "reference": "If we're going to leave this in here, how about we at least pull it into partial?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `context.WithTimeout` in this case. It's not clear what you're trying to do here, but I don't think it's a good idea to use `context.WithTimeout` in this case. It's not clear what you're trying to do here, but I don't think it's a good idea to use `context.WithTimeout` in this case. It's not clear what you're trying to do here, but I don't think it's a good idea to use `context.WithTimeout` in this case. It's not clear what you're trying to do here, but I don't think it's a good idea to use `context.WithTimeout` in this case. It's not clear what you're trying to do here, but I don't think it's a good idea to use `context.WithTimeout` in this case. It's not clear what you're trying to do here, but I don't think it's a good idea to use `context.WithTimeout` in this case. It's not clear what you're trying to do here, but I don't think it's a good idea to use `", + "prediction": "I'm not sure what you mean by \"prerun\" here. I think you meant to say \"test.prerun\" or something like that.", "reference": "This `context` is used correctly, there is nothing left TO DO." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `aggregate` method.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `toArray` instead of `toArray` and `forEach` instead of `forEach` in this case.", "reference": "If `docs` is an empty array there will be an error" }, { - "prediction": "I'm not sure what you mean by `quic:`, but I think it should be `quic://` instead of `quic:`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.", "reference": "Is it really necessary to have the user specify this, or can the reverse proxy infer QUIC from the upstream's Alt-Svc headers?" }, { - "prediction": "I'm not sure what you mean by \"http2/5.1/8\" in this context. Is this a typo?", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to add a `Skip` property to the `H2SpecTestCase` class. This way, we can add a `Skip` property to the `H2SpecTestCase` class, and then we can add a `Skip` property to the `H2SpecCommands` class, and then we can add a `Skip` property to the `H2SpecCommands` class, and then we can add a `Skip` property to the `H2SpecCommands` class, and then we can add a `Skip` property to the `H2SpecCommands` class, and then we can add a `Skip` property to the `H2SpecCommands` class, and then we can add a `Skip` property to the `H2SpecCommands` class, and then we can add a `Skip` property to the `H2SpecCommands` class, and then we can add a `Skip` property to the `H2SpecCommands` class, and then we can add a `Skip` property to the `H2SpecCommands` class, and then we can add a `Skip` property to the `H2Spec", "reference": "just remove the entire variable." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `--modulepath` option to `load_config` as well. This way, you can specify the path to a directory containing modules, and Boltdir will load the config from that directory instead of the current working directory.", + "prediction": "I'm not sure I understand what you're trying to do with this option. It seems like you're trying to specify the path to a file that contains a list of modules, but I'm not sure what you're trying to do with this option.", "reference": "Maybe we should put that in the option description?" }, { - "prediction": "I think we can remove the `keyFilePath` parameter from the `keyFilePath` method. It's not needed anymore.", + "prediction": "I think we can remove the `keyFilePath` parameter and just use `keyFilePath = Optional.of(keyFilePath)`.", "reference": "Why do we need to make this optional? Isn't the idea of the builder that if you don't need this value you just don't call the `keyFilePath ` method?" }, { - "prediction": "I think we can remove the `MetricsConfig.forTable(table)` line.", + "prediction": "I think we can remove the `MetricsConfig.forTable(table)` call here.", "reference": "Shall we do the same for ORC and Avro?" }, { - "prediction": "I think this should be `using` instead of `using namespace`.", + "prediction": "I think this should be `using Microsoft.VisualStudio.TestPlatform.ObjectModel.Navigation;` instead of `using Microsoft.VisualStudio.TestPlatform.ObjectModel.Navigation;`", "reference": "Should be a space between line" }, { - "prediction": "I think this should be `byte[] bytes = new byte[32];` instead of `byte[] bytes = new byte[32];`", + "prediction": "I don't think this is needed anymore.", "reference": "if not behind interface then equally we can use SecureRandom.GetBytes directly, otherwise let us push it behind ISecureRandom so we can test with this class wherever used" }, { @@ -6763,7 +6763,7 @@ "reference": "Probably will undo this change for now, as I'm just targeting Weekly Iteration in this PR." }, { - "prediction": "I'm not sure what you mean by `candidate_value_map`. Is it a map of `size_t` to `Kokkos::Tools::Experimental::SetOrRange`? If so, I'm not sure what you mean by `std::unordered_map`. Is it a map of `size_t` to `Kokkos::Tools::Experimental::SetOrRange`? If so, I'm not sure what you mean by `std::unordered_map`. Is it a map of `size_t` to `Kokkos::Tools::Experimental::SetOrRange`? If so, I'm not sure what you mean by `std::unordered_map`. Is it a map of `size_t` to `Kokkos::Tools::Experimental::SetOrRange`? If so, I'm not sure what you mean by `std::unordered_map`. Is it a map of `size_t` to `Kokkos::Tools::Experimental::SetOrRange`", + "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place", "reference": "Unused parameter warning? How comes we did not catch that before? In any case please open another PR for this." }, { @@ -6771,43 +6771,43 @@ "reference": "I recommend move all openimage related logic to a new function" }, { - "prediction": "I'm not sure what you're trying to do with this field, but I think we should remove it.", + "prediction": "I think we should remove the `ExternalCgroup` field, as it's not really needed.", "reference": "We shouldn't have a bool for this. If there is a path passed, then we use it. Resource may or may not be empty." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `textilize` method to format the text.", "reference": "I like how you used the count on the translate call to handle this." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `QueryBuilder` class as well.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this.", "reference": "Do we need to do this from the outside, or is there a spot in the handler code where we can do this automatically? (I haven't studied it closely yet... just wondering if you've already thought it through or if it's worth taking a closer look)." }, { - "prediction": "Shouldn't this be `public static void sputnikTest()`?", + "prediction": "Shouldn't this be `public static void sputnikTest();`?", "reference": "[Checkstyle] INFO: Using the '._' form of import should be avoided - java.util._." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `cliquet.support.DEFAULT_SETTINGS` here.", + "prediction": "I'm not sure what you mean by `cliquet.permission_backend` is `cliquet.permission.redis`. I think it should be `cliquet.permission.redis` instead.", "reference": "So, why everything is in memory but the permission backend?" }, { - "prediction": "I'm not sure I understand what you're trying to do here, but I think you're trying to do something like this: `setupUi.showBrowseStep(message, textToShow, new File(directory), new ArrayList(allowedExtensions));`", + "prediction": "I'm not sure I understand what you're trying to do here. Is it that you want the user to be able to browse for a file in the specified directory? If that's the case, then I think this is the right way to do it. If not, then I don't think this is the right way to do it.", "reference": "Are you sure it should be null and not an empty List?" }, { - "prediction": "I think this should be `Frameworks` instead of `AdditionalDependencies`.", + "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to have a separate section for this.", "reference": "Unfortunately I think the assumption of \"empty\" means the default dependency section is not correct. For a project.json file the default dependencies section is a shared section between all the different target frameworks and our TargetGroup being empty may map to many different target frameworks so they aren't really equated." }, { - "prediction": "I'm not sure what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear", + "prediction": "I don't think we need to check for `host` and `custom` here. We should only check for `host` and `custom` if they are present in the headers.", "reference": "This test was verifying the wrong thing." }, { - "prediction": "I think it's better to use `util.buildMuon('brave')` instead of `util.buildMuon()`.", + "prediction": "I think it's better to use `util.buildBrave()` instead of `util.buildMuon()`.", "reference": "pls pr a name change fro muon here too separately." }, { - "prediction": "I think this should be `if err := opts.envStore.CreateEnvironment(&env); err != nil { ... }` instead of `if err := opts.envStore.CreateEnvironment(&env); err != nil { ... }`", + "prediction": "I think this should be `if err != nil { ... }` instead of `if err := opts.envStore.CreateEnvironment(&env); err != nil { ... }`", "reference": "nit: we can use `defer opts.spinner.Stop(\"Error!\")` after l.180 to make it slightly neater" }, { @@ -6815,19 +6815,19 @@ "reference": "This is declared in the wrong block" }, { - "prediction": "I think it's better to use `sync.WaitGroup` instead of `klog.Warningf` in this case.", + "prediction": "I think it's better to use `sync.WaitGroup` instead of `klog.Warningf` here.", "reference": "In fact it would be useful for debug, i prefer combine them into one debug level log." }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to achieve with this. Is it that you want to show the number of new crash occurences? Or is it that you want to show the number of fatal crashes per session? Or is it that you want to show the number of fatal crashes per session and the number of new crash occurences? Or is it that you want to show the number of new crash occurences and the number of fatal crashes per session? Or is it that you want to show the number of new crash occurences and the number of fatal crashes per session? Or is it that you want to show the number of new crash occurences and the number of fatal crashes per session? Or is it that you want to show the number of new crash occurences and the number of fatal crashes per session? Or is it that you want to show the number of new crash occurences and the number of fatal crashes per session? Or is it that you want to show the number of new crash occurences and the number of fatal crashes per session? Or is it that you want to show the number of new crash occurences and the number of fatal crashes per session", + "prediction": "I don't think we need to change the condition here.", "reference": "We would need to localize them eventually too, just FYI" }, { - "prediction": "I don't think this is necessary.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this.", "reference": "It looks like the proto code needs to change the function name from set_name to set_type to be consistent." }, { - "prediction": "I think we should remove the `go run` command.", + "prediction": "I'm not sure if this is a good idea, but I'm not sure if we want to use the `mockgen` tool to generate mocks for the `SSMClientCreator` interface.", "reference": "I think we can avoid using this pattern for this use case." }, { @@ -6835,31 +6835,31 @@ "reference": "Could you please change this to `#ifndef __linux__`? That's when we use our own implementation instead of `posix_spawnp`." }, { - "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to check if the node has a free slot that supports the given capabilities. Is this what you're trying to do?", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to check if the node has a free slot that supports the given capabilities. If it does, you want to return the number of free slots. If it doesn't, you want to return the maximum number of slots that the node can support.", "reference": "Nit: put the `&&` on the previous line so that a reader knows that there's more to the statement at a casual glance." }, { - "prediction": "I think this should be `libkbfs` instead of `libkbfs.PrivatePathType` and `libkbfs.PublicPathType`.", + "prediction": "I think this should be `libkbfs.PrivatePathType` and `libkbfs.PublicPathType` instead of `libkbfs.SingleTeamPathType` and `libkbfs.PrivatePathType`.", "reference": "Technically the \"right\" variables to use would be the ones in `libgit/autogit_node_wrappers.go\", which define how the tlf types map to subdirs for autogit specifically. (They would have to be exported.) But this is fine too I guess, just a little dirtier." }, { - "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to send a notification to the approver of a proposal that has been removed from the system. Is there a specific reason you want to do this, or is this just a placeholder for something else?", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to send a proposal email to the approver of a proposal that has already been approved.", "reference": "Should there be a template or something associated with this email? Right now it's identical to `notification_for_approver`" }, { - "prediction": "I'm not sure what you're trying to achieve with this query. It seems like you're trying to select all items from the `SliderItem` table where the `domainId` is equal to the `selectedDomainId`, but I'm not sure what you're trying to achieve with this query. Could you please provide more context or clarify what you're trying to achieve with this query?", + "prediction": "I don't think you need to use `select` here. You can just use `from` and `where` directly.", "reference": "i hope there is some extension in phpstan for this" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right way to do it.", + "prediction": "I don't think this is necessary.", "reference": "We don't store empty dictionary entries anymore: they bring no benefits, only trouble." }, { - "prediction": "I think this should be a comment, not a function.", + "prediction": "I think this should be moved to the end of the file.", "reference": "Optional: This function is C++ specific and could be declared as `static`." }, { - "prediction": "I think it's better to use `client.getRoles(domainName, members, tagKey, tagValue)` instead of `client.getRoles(domainName, members)` and `client.getRoles(domainName, members, tagKey, tagValue)` instead of `client.getRoles(domainName, members, tagKey, tagValue)`.", + "prediction": "I think it's better to use `client.getRoles(domainName, members, tagKey, tagValue);` instead of `client.getRoles(domainName, members, tagKey, tagValue);`", "reference": "we can't remove functions as that would introduce backward compatibility issues in our java client. So we should also have a function with the original arguments: ` public Roles getRoles(String domainName, Boolean members) { return getRoles(domainName, members, null, null); } ` For the Go client we don't have a wrapper so no option but to update your client code as necessary, but for java we have the wrapper thus we always maintain backward compatibility" }, { @@ -6867,39 +6867,39 @@ "reference": "I'd recommend keeping this in `warn_deprecation` and not adding an override of `warn`." }, { - "prediction": "I think this should be `require(blitzPath);` instead of `process.argv.push(blitzPath, 'start');`", + "prediction": "I think this should be `require(blitzPath, 'start')` instead of `require(blitzPath, 'start');`", "reference": "I think we should use a `blitz` bin instead" }, { - "prediction": "I'm not sure what you mean by \"following columns\". Could you please clarify?", + "prediction": "I think this should be `dataset.dimensions(label='name')` instead of `dataset.dimensions('key', label='name')`", "reference": "Why not make the ``derived_vdims`` flag (or similar, ``validate_vdims`` maybe?) an explicit argument to ``validate``?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this check to the `Create` method.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to make sure the snapshot is owned by the user that created it. If it's not, we can't do anything with it.", "reference": "was it not possible to do this at the filter or porx driver layer? We typically try to avoid driver-specific things in the SDK layer" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason you want to change this class?", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a new class that extends the `User` class, but I don't think that's what you're trying to do. I think you're trying to create a new class that extends the `User` class, but I don't think that's what you're trying to do. I think you're trying to create a new class that extends the `User` class, but I don't think that's what you're trying to do. I think you're trying to create a new class that extends the `User` class, but I don't think that's what you're trying to do. I think you're trying to create a new class that extends the `User` class, but I don't think that's what you're trying to do. I think you're trying to create a new class that extends the `User` class, but I don't think that's what you're trying to do. I think you're trying to create a new class that extends the `User` class, but I don't think that's what you're trying to do. I think you're trying to create a new class that extends the `User` class, but I", "reference": "please update the year. it can be setup in intellij template." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this.", + "prediction": "I'm not sure if this is a good idea or not, but I think it would be better to have a separate test for `log.trace` and `log.debug` in the `Slf4jTest` class.", "reference": "what's the use-case for this?" }, { - "prediction": "I think this should be `if not isinstance(df_or_s, DataFrame)` instead of `if not isinstance(df_or_s, DataFrame):`", + "prediction": "I think this should be `if isinstance(df_or_s, DataFrame)` instead of `if not isinstance(df_or_s, DataFrame)`.", "reference": "nit: `as_index must be an boolean` -> `as_index must be a boolean`" }, { - "prediction": "I'm not sure what you mean by \"update\" in this context. It's not clear to me what you're trying to do with this method. Is it supposed to update the current version of the module, or is it supposed to update the new version of the module? If it's supposed to update the current version of the module, then I'm not sure what you're trying to do with this method. Is it supposed to update the new version of the module, or is it supposed to update the current version of the module? If it's supposed to update the current version of the module, then I'm not sure what you're trying to do with this method. Is it supposed to update the new version of the module, or is it supposed to update the current version of the module? If it's supposed to update the current version of the module, then I'm not sure what you're trying to do with this method. Is it supposed to update the new version of the module, or is it supposed to update the current version of the module? If it's supposed to update the current version of the module, then I'm not sure what you're trying to do with this method. Is it supposed to update the new version of the module, or", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `BaseModuleInterface` class.", "reference": "What is the goal of that method ? And what are `$currentVersion` and `$newVersion` ? Are they Thelia or Module version ? :)" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right way to do it.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a `version` property to the `Plugin` class.", "reference": "Is there an advantage to this vs setting `this.version` in the constructor? Cleaner this way, at the top?" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use the `loginUrl` instead of `loginServerUrl` in the `OAuthWebviewHelper` class. The `loginUrl` is the URL of the login page, while the `loginServerUrl` is the URL of the server where the login page is located.", + "prediction": "I don't think this is a good idea. The login url should be set by the user, not SalesforceSDKManager.", "reference": "Fix for URISyntaxException." }, { @@ -6907,35 +6907,35 @@ "reference": "Would be good to UT this case" }, { - "prediction": "I think we can remove `import/no-extraneous-dependencies` and `import/no-unresolved` as they are not needed anymore.", + "prediction": "I don't think we need `import/no-extraneous-dependencies` and `import/no-unresolved` anymore.", "reference": "Why we need to add this?" }, { - "prediction": "I'm not sure what you're trying to do here. It's not clear what you're trying to do with the `get :index` and `get :show` calls. Can you clarify what you're trying to do with these calls?", + "prediction": "I'm not sure what you mean by \"users are not authenticated\". I think you meant to say \"users are not logged in\".", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { - "prediction": "I'm not sure if this is the right place to put it, but I think it should be in the `ClusterInfo` struct as well.", + "prediction": "I don't think we need this field. It's not used anywhere.", "reference": "This is ok to change since I believe that these were added just in main and not in public release." }, { - "prediction": "I think this should be `kngcptesting.WithCloudAuditLogsSourceServiceAccount` instead of `kngcptesting.WithCloudAuditLogsSourceServiceName`", + "prediction": "I don't think we need to use `kngcptesting.WithCloudAuditLogsSourceServiceName(serviceName)` here.", "reference": "Not needed in this PR, just want to make sure people think about this (maybe make an issue)? This is a lot of strings in a row. It will be hard/impossible for someone reading the code to see that everything is in the correct position. I recommend creating a struct instead of passing seven strings in a row. A similar problem exists on most of the `MakeFoo(...)` style methods in this change." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea.", + "prediction": "I think this should be `if (_run?.Invocation?.StartTime != null)` instead of `if (_run?.Invocation?.StartTime != new DateTime())`", "reference": "_jaw drops_ I would have sworn I wrote those lines. Good catch." }, { - "prediction": "I'm not sure what you mean by \"cleans up after resolve/reject\"", + "prediction": "I don't think we need to do this. We can just remove the `axe._memoizedFns` and `axe._cache` from the `axe` object.", "reference": "This needs to be tested." }, { - "prediction": "I think this should be a test for `valid?` instead of `validates?`", + "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea.", "reference": "I believe you're missing the comparison after 'be'" }, { - "prediction": "I think we should add a check for `errors.Cause(err) == ErrAlreadyDeleted` in `Put` and `Get`.", + "prediction": "`errors.Cause(err) == ErrNotExist` should be `errors.Cause(err) == ErrNotExist`", "reference": "move 103~105 to in front of 97?" }, { @@ -6943,7 +6943,7 @@ "reference": "Lots of unnecessary imports left in this file." }, { - "prediction": "I'm not sure what you mean by \"Can't validate the descriptor because it may not have been updated.\"", + "prediction": "I'm not sure what you mean by \"can't validate the descriptor because it may not have been updated.\"", "reference": "Does this actually produce different code?" }, { @@ -6951,7 +6951,7 @@ "reference": "This should account for whitespace. Simply putting `.trim()` on the attribute value should do." }, { - "prediction": "I'm not sure what you mean by \"noencTarget\" and \"bhTarget\" in this context. Could you please clarify?", + "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea. The `noencTarget` and `bhTarget` should be the same as the `blackHoleProto` and `blackHoleProto` respectively.", "reference": "I don't think we need these. Simpler just to put `routetable.TargetType...` inline below." }, { @@ -6963,31 +6963,31 @@ "reference": "Nitpick: add a space after the comma. Also, we should consider that the format of the version could change in the future so we could get something that is not a parsable integer." }, { - "prediction": "I think we should use `std::string_view` instead of `std::string` in this case.", + "prediction": "I think it's better to use `std::string_view` instead of `std::string` in this case.", "reference": "For your reference in future, I sugguest to use the `ASSERT_*` family." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to include `fmt/format.h` here.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `#include \"fmt/format.h\"` in this file. This is because `fmt/format.h` is a header file that is used by the `fmt` library, which is used by the `fmt/format.h` header file, which is used by the `fmt/format.h` header file, which is used by the `fmt/format.h` header file, which is used by the `fmt/format.h` header file, which is used by the `fmt/format.h` header file, which is used by the `fmt/format.h` header file, which is used by the `fmt/format.h` header file, which is used by the `fmt/format.h` header file, which is used by the `fmt/format.h` header file, which is used by the `fmt/format.h` header file, which is used by the `fmt/format.h` header file, which is used by the `fmt/format.h` header file, which is used by the `fmt/format.h` header file, which is used by the `fmt/format.h` header file, which is used by the `fmt/format.h` header file, which is used by the `", "reference": "no need to import `fmt/format.h` here since the `KimInit` class is derived from `Pointers`. Any class derived from `Pointers` can assumed that `lmptype.h`, `mpi.h`, `cstddef`, `cstdio`, `string`, `utils.h` and `fmt/format.h` are already included through `pointers.h`." }, { - "prediction": "I'm not sure what you mean by this, but I think it's a good idea to remove the `os` package from this file. It's not used anywhere else in the codebase.", + "prediction": "I'm not sure if this is a good place to put this, but I think we should move it to the `openebs.io/upgrade/v1alpha1` namespace.", "reference": "Can we have prefix of `OPENEBS_IO` e.g.: `OPENEBS_IO_INSTANCE_NAME`" }, { - "prediction": "I think this should be `errors.New(\"GetRootNode is not supported by folderBranchOps\")` instead of `errors.New(\"GetOrCreateRootNode is not supported by folderBranchOps\")`", + "prediction": "I think this should be `errors.New(\"GetRootNode is not supported by folderBranchOps\")`", "reference": "Might as well fix these bare returns by making them `return errors.New(...` directly." }, { - "prediction": "I think this should be `org.hyperledger.besu.datatypes.Code` instead of `org.hyperledger.besu.datatypes.Hash`", + "prediction": "I think we should remove the `apparentValue` field.", "reference": "we can use import here" }, { - "prediction": "I don't think we need to change the `Caller` here.", + "prediction": "I don't think we need to do this.", "reference": "thx for removing these" }, { - "prediction": "I think this should be `throw new RuntimeException(String.format(\"Failed to parse failures XML: %s\", sourceReport), e);` instead of `throw new RuntimeException(String.format(\"Failed to parse failures XML: %s\", sourceReport));`", + "prediction": "I think this should be `throw new RuntimeException(String.format(\"Failed to parse failures XML: %s\", sourceReport), e);`", "reference": "I snuck this one in as well as checkstyle crashing (on files from resources) caused an unfinished xml to be written, and it wasn't obvious where that XML was" }, { @@ -6999,79 +6999,79 @@ "reference": "the last parameter name should be `serviceName` as is in the implementation" }, { - "prediction": "I'm not sure what you mean by \"line1\\n line2 *\\n * line3\". Is this the same as \"line1\\n line2\" or \"line1\\n line2 *\\n * line3\"?", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `@Override` annotation on the `JavadocComment` to make sure that the `JavadocComment` is not modified by the `@Override` annotation.", "reference": "@ftomassetti - okay, this is a little meh." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to use the `notImplemented` error to indicate that an operation is not supported. But I don't think that's what you want to do. I think you're trying to use the `ErrUnsupported` error to indicate that an operation is not supported. But I don't think that's what you want to do. I think you're trying to use the `notImplemented` error to indicate that an operation is not supported. But I don't think that's what you want to do. I think you're trying to use the `ErrUnsupported` error to indicate that an operation is not supported. But I don't think that's what you want to do. I think you're trying to use the `notImplemented` error to indicate that an operation is not supported. But I don't think that's what you want to do. I think you're trying to use the `ErrUnsupported` error to indicate that an operation is not supported. But I don't think that's what you want to do. I think you're trying to use the `notImplemented` error to indicate that an operation is not supported. But I don't think that's what you want to do", + "prediction": "I'm not sure what you're trying to do here. I think we should just use `errors.New` instead of `notImplemented` in this case.", "reference": "Note, changed initial capitalisation of this for consistency. Can do it the other way around too if that'd be better. :wink:" }, { - "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `typeof window` instead of `typeof window === \"object\" ? window : this`.", + "prediction": "I don't think this is a good idea. The `typeof` operator is used to check if a variable is an object or not. If it is an object, it will return `true`. If it is not an object, it will return `false`. If it is a string, it will return `false`. If it is a number, it will return `false`. If it is a boolean, it will return `false`. If it is a null, it will return `false`. If it is a undefined, it will return `false`. If it is a function, it will return `false`. If it is a string, it will return `false`. If it is a number, it will return `false`. If it is a boolean, it will return `false`. If it is a null, it will return `false`. If it is a undefined, it will return `false`. If it is a function, it will return `false`. If it is a string, it will return `false`. If it is a number, it will return `false`. If it is a boolean, it will return `false`. If it is a null, it will return `false`. If it is a undefined, it will return `false", "reference": "hey, aren't we supposed to be passing in two parameters here?" }, { - "prediction": "I think this should be `require('./lib/bip32')` instead of `require('./lib/encoding/bip32')`", + "prediction": "I think this should be `require('./lib/bip32')` instead of `require('./lib/encoding/bip32')`.", "reference": "please keep alphabetical ordering :)" }, { - "prediction": "I think this should be `import java.nio.charset.StandardCharsets;` instead of `import java.nio.charset.StandardCharsets;`", + "prediction": "I think this should be `java.nio.charset.StandardCharsets.UTF_8` instead of `java.nio.charset.StandardCharsets.ISO_8859_1`.", "reference": "Selenium must compile against Java 6. Revert this line." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to create a new PullSubscription in the same namespace as the old one. This way, we don't have to create a new PullSubscription in the same namespace as the old one, and we don't have to worry about the old PullSubscription being deleted before the new one is created.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `ReconcilePullSubscription` function, so that we don't have to call it again and again.", "reference": "what is that `\"\"`, the adapterType? can you add `\"\" /* adapterType */`... in other places as well... might be cleaner if it's a pointer or some varargs at the end but don't have any strong preference.." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `__dirty` method.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good place to do this.", "reference": "This check is a little odd, and will still mess up with empty strings `''` because empty string is falsy. Can we change this to `|| _this.getValue(path) == null`?" }, { - "prediction": "I think this should be `isFocusable` instead of `isFocusable && tabIndex >= 0`.", + "prediction": "I think this should be `isFocusable` instead of `isFocusable && tabIndex >= 0`", "reference": "Just a minor suggestion: If you `parseInt` when you access the attribute then you shouldn't have to do it twice in the ternary." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have the `body[:target]['host-key-check']` set to `false` if the `transport` is `ssh`. This is because the `host-key-check` option is only set to `true` if the `transport` is `ssh`. If the `transport` is not `ssh`, then the `host-key-check` option should be `false`.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `JSON.generate` here.", "reference": "This change in particular is strange. I'm not sure why it would now be necessary. The previous default would've been true, and the default behavior without a new net-ssh version should be unchanged." }, { - "prediction": "I'm not sure what you're trying to do with this, but I think it's a bad idea to set this to `true` in a `BatchActionFormModel` instance. If you set it to `true`, the form will not be validated, and the user will not be able to submit the form. If you set it to `false`, the form will be validated, but the user will still be able to submit the form.", + "prediction": "I don't think this is needed.", "reference": "Why is that? Should be redundant as the default value exists." }, { - "prediction": "I think we should remove the `DebugSimulateDataRace` option. It's not used anywhere.", + "prediction": "I don't think this is a good idea.", "reference": "Are all fields beginning with \"Debug\" automatically `;local` ? (I guess so, but just checking.)" }, { - "prediction": "I think it's better to use `UpdateNameMapping` instead of `UpdateProperties` because `UpdateNameMapping` is more specific.", + "prediction": "I don't think we need to do this. The `updateNameMapping` is just a convenience method for creating a new `UpdateNameMapping` object. We don't need to create a new `UpdateNameMapping` object here. We can just use the existing `UpdateNameMapping` object that was created by the `updateSchema` method.", "reference": "While I think it makes sense to update the mapping programmatically, I don't see much value in exposing it as part of the table API. We want to keep the Table API small, so if we can handle this by using a separate API that consumes and produces JSON, then that is preferred. Also, we may have more than one mapping in the future, so keeping this decoupled also helps out for those use cases. For now, let's build a utility class to perform these updates. We can always add this to the public API later if we choose to." }, { - "prediction": "I'm not sure what you mean by \"waitOnAll(getStatsMergeTimeout())\". I think you meant \"waitOnAll(getStatsMergeTimeout())\" or \"waitOnAll(getStatsMergeTimeout())\" or \"waitOnAll(getStatsMergeTimeout())\" or \"waitOnAll(getStatsMergeTimeout())\" or \"waitOnAll(getStatsMergeTimeout())\" or \"waitOnAll(getStatsMergeTimeout())\" or \"waitOnAll(getStatsMergeTimeout())\" or \"waitOnAll(getStatsMergeTimeout())\" or \"waitOnAll(getStatsMergeTimeout())\" or \"waitOnAll(getStatsMergeTimeout())\" or \"waitOnAll(getStatsMergeTimeout())\" or \"waitOnAll(getStatsMergeTimeout())\" or \"waitOnAll(getStatsMergeTimeout())\" or \"waitOnAll(getStatsMergeTimeout())\" or \"waitOnAll(getStatsMergeTimeout())\" or \"waitOnAll(getStatsMergeTimeout())\" or \"waitOnAll(getStatsMergeTimeout())\" or \"waitOnAll(getStatsMergeTimeout())\" or \"waitOnAll(getStatsMergeTimeout())\" or \"waitOnAll(getStatsMergeTimeout())\" or \"waitOnAll(getStatsMergeTimeout())\" or \"waitOn", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're waiting on all the connections to finish, and then you're waiting on all of them to finish. I'm not sure what you're trying to do here, but it looks like you're waiting on all the connections to finish, and then you're waiting on all of them to finish. I'm not sure what you're trying to do here, but it looks like you're waiting on all the connections to finish, and then you're waiting on all of them to finish. I'm not sure what you're trying to do here, but it looks like you're waiting on all the connections to finish, and then you're waiting on all of them to finish. I'm not sure what you're trying to do here, but it looks like you're waiting on all the connections to finish, and then you're waiting on all of them to finish. I'm not sure what you're trying to do here, but it looks like you're waiting on all the connections to finish, and then you're waiting on all of them to finish. I'm not sure what you're trying to do here, but it looks like you're waiting on all the connections to finish, and then", "reference": "We would want ssmp to wake up every 3 seconds if there are no other requests to it and do some cleanup tasks. So, it is not clear why do you want to set this to 0." }, { - "prediction": "I'm not sure what you mean by \"lazily\" here. I think we should be able to do this in a single pass.", + "prediction": "I'm not sure I understand what you mean by \"lazily create runtime types\".", "reference": "Is this really necessary? I would expect these types to be included with the loop below." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `BitConverter.IsLittleEndian` here. You can just use `BitConverter.IsLittleEndian = false;` instead.", + "prediction": "`BitConverter.IsLittleEndian` should be `BitConverter.IsBigEndian`", "reference": "You could do span and it's magic of typecast to int for better efficiency" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to check if the transform style exists before trying to apply it to the element.", + "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to check if the transform style exists before trying to apply it to the element.", "reference": "Looks like you've covered `-webkit-transform`, but what about `-ms-transform`?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `OnCollectionChanged` event handler.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the `OnItemsSourceCollectionChanged` event handler.", "reference": "Is there something missing from the message here?" }, { - "prediction": "I think it's a good idea to have a `__all__` list in the `__init__.py` file. This way, we don't have to worry about having a `__all__` list in the `__init__.py` file.", + "prediction": "I think it's a good idea to have a `__all__` list in the `__init__.py` file. This way, we don't have to worry about the `__all__` list in the `__init__.py` file, and we don't have to worry about the `__all__` list in the `__init__.py` file, and we don't have to worry about the `__all__` list in the `__init__.py` file, and we don't have to worry about the `__all__` list in the `__init__.py` file, and we don't have to worry about the `__all__` list in the `__init__.py` file, and we don't have to worry about the `__all__` list in the `__init__.py` file, and we don't have to worry about the `__all__` list in the `__init__.py` file, and we don't have to worry about the `__all__` list in the `__init__.py` file, and we don't have to worry about the `__all__` list in the `__init__.py` file, and we don", "reference": "Hmm, what does this syntax mean?" }, { - "prediction": "I'm not sure what you mean by \"for get workflow execution context, with valid run id\"", + "prediction": "I don't think this is a good idea. We should be able to get the workflow execution context from the history cache.", "reference": "should this be callerTypeTask?" }, { @@ -7079,63 +7079,63 @@ "reference": "Currently update is set as @plan.editable_by?(@user.id) Which one is the correct behavior? I can see a case for only owners/co-owners to be able to set visibility, test status, and other plan details" }, { - "prediction": "I'm not sure what you're trying to achieve with this limit, but I think it's a good idea to have a limit on the number of blocks that can be loaded into the database at once.", + "prediction": "I don't think we need to change this.", "reference": "Maybe make it configurable? Or store the actual level index in DB, making this binary search obsolete?" }, { - "prediction": "I'm not sure what you mean by \"metadata only, location was already deleted\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the table is deleted before the catalog drops it.", "reference": "Nit: this file doesn't need to change. Can you revert this to avoid git conflicts?" }, { - "prediction": "I'm not sure what you mean by \"toggle menu\" in this context. It's not clear to me what you're trying to do here.", + "prediction": "I don't think we need to use the `children` prop here. We can just use the `handleMenuSelected` function directly.", "reference": "There's no reason for this to be a callback now technically but as per our tech decision, we want all handlers to use `useCallback` now" }, { - "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea to add this to the list of `HashID`s. I'm not sure if this is the right place to add this, but I think it's a good idea to add this to the list of `HashID`s. I'm not sure if this is the right place to add this, but I think it's a good idea to add this to the list of `HashID`s. I'm not sure if this is the right place to add this, but I think it's a good idea to add this to the list of `HashID`s. I'm not sure if this is the right place to add this, but I think it's a good idea to add this to the list of `HashID`s. I'm not sure if this is the right place to add this, but I think it's a good idea to add this to the list of `HashID`s. I'm not sure if this is the right place to add this, but I think it's a good idea to add this to the list of `HashID`s. I'm not sure if this is the right place to add this, but I think it", + "prediction": "I think it's better to use `HashID` instead of `StringID` for `HashID`.", "reference": "This isn't strictly part of this PR, but could you move `multiSigString` from `crypto/multisig.go` into this list of `HashID` values? Now that we have other things being hashed into addresses (specifically, these new logic addresses), it's important that the hash input for multisig addrs is domain-separated from logic addresses." }, { - "prediction": "I don't think this is necessary.", + "prediction": "I think this should be `stop_worker_pool` instead of `stop_pool`", "reference": "nit: you could have named it just \"TestCase\" (if django's TestCase was imported differently)" }, { - "prediction": "I'm not sure what you're trying to do with `@bridge.send_command(cmd: cmd, params: params)`, but I don't think that's the right way to do it. You should be using `bridge.send_command(cmd: cmd, params: params)` instead.", + "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don", "reference": "the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here." }, { - "prediction": "I think this should be `bool` instead of `lldb::eNoDynamicValues`?", + "prediction": "I think this should be `bool` instead of `lldb::eNoDynamicValues`.", "reference": "All the callers of `ExtractSomeIfAny`, always pass `true` to `synthetic_value`. Can we get rid of the extra argument?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `cfg` variable in the `main` function. This way, we don't need to pass the `cfg` variable to the `main` function every time we run the script.", + "prediction": "I don't think we need to log the config file here. We can just use `cfg` directly.", "reference": "Better to use the absolute path." }, { - "prediction": "I don't think we need to change `ChannelExpiryBuffer` and `ChannelExpiryInterval`.", + "prediction": "I don't think we need to change `ChannelExpiryBuffer` and `ChannelExpiryInterval` to `2000` and `1000` respectively.", "reference": "this is 16 hours, is that enough?" }, { - "prediction": "I think we can remove the `if *err != nil` check.", + "prediction": "I think we can remove the `trace.StringAttribute` here, since it's not used anywhere.", "reference": "removing boilerplate. You could also add a `StartSpan` with varargs to inline string attributes." }, { - "prediction": "I'm not sure what you mean by `v` here. It's not used anywhere in the code.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.", "reference": "Can you replace these single letter variables with full names?" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `ConnectionFilterContext` class.", + "prediction": "I'm not sure if this is the best place to put this, but I think it would make sense to move this into the `ConnectionFilter` class.", "reference": "At first I wasn't sure, but now I think I'm sold on making PrepareRequest an action over adding a state object to the context." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to update the generator if it is default value.", + "prediction": "I'm not sure if this is the best place to do this, but I think it's a good idea to update the generator if it contains a version number.", "reference": "Would it be too greedy to preg_replace `VuFind (\\d+\\.?)+` with `'VuFind ' . $this->to` anywhere in the string? This would update something like 'Finna (VuFind 7.1.0)' as well. Just a thought, please disregard if you'd like to keep it as is." }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it's a good idea to move this into the `ZkSolrResourceLoader` class, since it's not really part of the `ManagedResourceStorage` class.", + "prediction": "I think this should be `getZkStateReader().getClusterState().getCollection(collection).getConfigName();`", "reference": "BTW for brevity, you can remove `getZkStateReader().` here and elsewhere since ZkController has a convenience method for the cluster state." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `Iterable` instead of `CloseableIterable` here.", "reference": "If there are no manifests, then entries should be `CloseableIterable.empty()`, not the manifest iterable. That doesn't need to be closeable." }, { @@ -7143,15 +7143,15 @@ "reference": "this class should be named `ArrayInitializationVerbosenessTest` to work" }, { - "prediction": "I think this should be `next unless val == 'disable'` instead of `next if val == 'disable'`.", + "prediction": "I think this should be `unless val.is_a?(Hash)` instead of `unless val == 'disable'`.", "reference": "Do we want to allow users to disable `console` as well? The schema currently says that it only permits a hash for `console`." }, { - "prediction": "I'm not sure what you mean by \"not working\" here. Is it because it's not supported in the current version of the node?", + "prediction": "I'm not sure what you mean by \"not working\" here. Is it because it doesn't work in the integration test, or is it because it doesn't work in the real world?", "reference": "It would be very helpful to describe succinctly either inline or by linking to an issue going into depth why each test is not working. If we merge like this your knowledge of what is going on is lost and other people in the code need to do a ton of reading before understanding when/how/if we should unskip." }, { - "prediction": "I think we can remove the `currentDataLoaded` and `previousDataLoaded` checks.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `handleDataError` and a `handleDataSuccess` function that will be called after the data has been fetched.", "reference": "As this is a `useEffect` this could be a cause for concern! Note that `useEffect` re-runs when a dependency changes **not** when a dependency is truthy (the previous code does look a bit like it's expecting that)" }, { @@ -7159,11 +7159,11 @@ "reference": "Should we be doing this with `make_unique` or something?" }, { - "prediction": "I'm not sure what you mean by \"ideal data to consume\", but I think it's a good idea to have a `proposal_updated_no_action_required` method in the `ProposalMailer` class, so that we don't have to call this method every time we want to update a proposal.", + "prediction": "I'm not sure what you mean by \"ideal data\" here, but I think it's a good idea to use the `@changes` hash to store the changes made to the proposal. This way, we can track which changes have been made and when they were made, which can be useful for debugging and tracking the history of the proposal.", "reference": "we don't want to set default values for this. Since it is the actual email, we want to make sure we are always passing in the `user` and `proposal` . we have a default value of `nil` for modifier because sometimes will update a proposal via `rails console` in which case there will be no recorded modifier." }, { - "prediction": "I don't think we need to use `go/parser` here. We can use `go/build` instead.", + "prediction": "I don't think this is necessary. We can just use the `go/parser` package directly.", "reference": "Yes this import was in the wrong place, but should ideally be in the first list of imports (among `go/build`, `go/token`, etc.). You may move it there, or just revert this change as it's actually unrelated." }, { @@ -7171,15 +7171,15 @@ "reference": "It's unnecessary to duplicate the `name`." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. If you want to do this in the `onSubmit` event, you could do something like this: `if ($event->getForm()->has('unlink') && null !== $event->getForm()->get('unlink')->getData()) { $event->setData(null); } else if ($event->getForm()->has('unlink') && true === $event->getForm()->get('unlink')->getData()) { $event->setData(null); } else { $event->setData(null); }`", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `FormEvents::SUBMIT` event handler.", "reference": "this was a mistake when adding phpstan strict plugin" }, { - "prediction": "I think it's a good idea to add a check for `oldVNode._dom == oldDom` in this case.", + "prediction": "I think it's better to use `oldVNode._dom == oldDom` instead of `oldVNode._dom == oldDom && oldDom.parentNode != parentDom`.", "reference": "Nit: I think it should be `to handle` here." }, { - "prediction": "I'm not sure what you mean by \"IMAP search results will usually need to be downloaded before viewing\"", + "prediction": "I'm not sure what you mean by \"IMAP search results will usually need to be downloaded before viewing.\" Is there a reason for this?", "reference": "Please don't make unrelated changes or let your tools make unrelated changes." }, { @@ -7187,31 +7187,31 @@ "reference": "`numAccounts` is a global variable (from `gochecknoglobals`)" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `PluginManager::removePlugin()`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to remove the plugin from our internal container when the plugin is removed from the system.", "reference": "Is the ID correctly normalized at this point?" }, { - "prediction": "I think this should be `p2p.NodeInfo` instead of `p2p.NodeInfoInfo`?", + "prediction": "I think this should be `p2p.NodeInfo` instead of `p2p.NodeInfoList`.", "reference": "if 0 is a special constant meaning \"no limit\" let's make it a constant and name it correctly :)" }, { - "prediction": "I don't think it's necessary to set `setOsConfig` here. It's only used in the `runInventory` function, so it shouldn't be set in the `run` function.", + "prediction": "I don't think it's necessary to set `setOsConfig(resp)` here. I think it's better to set `setPatchPolicies(resp.PatchPolicies)` and then set `setOsConfig(resp)` after that.", "reference": "Curious about the reason behind this change" }, { - "prediction": "I think this should be `node.cborStore.Put` instead of `node.OnlineStore.Put`?", + "prediction": "I think this should be `blkCid, err := node.cborStore.Put(ctx, b)` instead of `blkCid, err := node.OnlineStore.Put(ctx, b)`?", "reference": "wait, i thought the cborstore was for state tree?" }, { - "prediction": "I think this should be `temp_file_logical_keys = [lk for lk, entry in self.walk() if physical_key_is_temp_file(entry.physical_keys[0])]` instead of `temp_file_logical_keys = [lk for lk, entry in self.walk() if physical_key_is_temp_file(entry.physical_keys[0]) and pathlib.Path(parse_file_url(urlparse(pk))).parent == APP_DIR_TEMPFILE_DIR]`", + "prediction": "I think this should be `temp_file_logical_keys = [lk for lk, entry in self.walk() if physical_key_is_temp_file(entry.physical_keys[0])]`", "reference": "This logic is now duplicated here and in `_delete_temporary_files`... Maybe do it all at once - find temp files, delete them, and fix the logical keys?" }, { - "prediction": "I don't think this is necessary. We can just use `null` as the default response type.", + "prediction": "I don't think this is necessary. The `getResponseType()` method is not used anywhere in this class.", "reference": "How about name it with NullResponseTypeProcessor" }, { - "prediction": "I'm not sure what you mean by `feat_is_unconstrained`. Is it true that `feat_is_unconstrained` is `true` only if `config_.monotone_constraints[i] == 0` and `config_.monotone_constraints.size() == 0`?", + "prediction": "I'm not sure what you mean by \"unconstrained\" in this context. I think you mean \"unconstrained\" in the sense that it is not constrained by monotone constraints.", "reference": "Maybe `Log::Fatal` here? `[LightGBM] [Fatal] Check failed: feat_is_unconstrained at ...` (and kernel death in case of Jupyter Notebook) seems to be not so informative and user-friendly." }, { @@ -7219,31 +7219,31 @@ "reference": "Not sure I like the name ``_apply``. Even though ``_process`` is supposed to process elements already, how about ``_process_element`` which processes elements, *excluding* Overlays/NdOverlays." }, { - "prediction": "I don't think we need to use `NodeRoleTagValue` here. We can use `NodeRoleTagKey` instead.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a `ClusterTagKey` for the `ClusterTagKey` and `NodeRoleTagKey` for the `NodeRoleTagKey`. This way, we can use the same `ClusterTagKey` and `NodeRoleTagKey` for the `ClusterTagKey` and `NodeRoleTagKey` for the `ClusterTagKey` and `NodeRoleTagKey` for the `ClusterTagKey` and `NodeRoleTagKey` for the `ClusterTagKey` and `NodeRoleTagKey` for the `ClusterTagKey` and `NodeRoleTagKey` for the `ClusterTagKey` and `NodeRoleTagKey` for the `ClusterTagKey` and `NodeRoleTagKey` for the `ClusterTagKey` and `NodeRoleTagKey` for the `ClusterTagKey` and `NodeRoleTagKey` for the `ClusterTagKey` and `NodeRoleTagKey` for the `ClusterTagKey` and `NodeRoleTagKey` for the `ClusterTagKey` and `NodeRoleTagKey` for the `ClusterTagKey` and `NodeRoleTagKey` for the `ClusterTag", "reference": "Let's use this constant when ASG is created as well (currently hardcoded)." }, { - "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea.", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a table that has the same structure as the `named_packages` table, but with a `GROUP BY` clause. I think you want to create a table that has the same structure as the `named_packages` table, but with a `GROUP BY` clause. I think you want to create a table that has the same structure as the `named_packages` table, but with a `GROUP BY` clause. I think you want to create a table that has the same structure as the `named_packages` table, but with a `GROUP BY` clause. I think you want to create a table that has the same structure as the `named_packages` table, but with a `GROUP BY` clause. I think you want to create a table that has the same structure as the `named_packages` table, but with a `GROUP BY` clause. I think you want to create a table that has the same structure as the `named_packages` table, but with a `GROUP BY` clause. I think you want to create a table that has the same structure as the `named_packages` table, but with a `GROUP BY` clause. I think you", "reference": "Oh is `bucket` actually higher cardinality than `eventname`?" }, { - "prediction": "I don't think we need to import `QWebEngineProfile` in `qutebrowser.browser.qutebrowser` because it's already imported in `qutebrowser.utils`", + "prediction": "I don't think we need to import `QWebEngineProfile` here.", "reference": "You can't rely on QtWebEngine being available - but why do you need to import this here at all?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to list all the subpackages explicitly in the `packages` list. This will make it easier for users to install the package without having to know which subpackages are included.", + "prediction": "I'm not sure if this is a good idea, but I think it's better to have a separate `NVDAObjects` package.", "reference": "How did you determine these - and how can we be confident that nothing is missing?" }, { - "prediction": "I don't think this is a good idea. It would be better to have a list of all the workshops, videos, and books.", + "prediction": "I don't think this is necessary.", "reference": "What is this page going to do that is different than the products index we already have?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `Selenium::Firefox` module.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate method for this. It's not clear to me that this is the right place to do this.", "reference": "Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to add a `script` option to the `Deploy` class, but you're not actually using it. I think you're trying to add a `script` option to the `Deploy` class, but you're not actually using it. I think you're trying to add a `script` option to the `Deploy` class, but you're not actually using it. I think you're trying to add a `script` option to the `Deploy` class, but you're not actually using it. I think you're trying to add a `script` option to the `Deploy` class, but you're not actually using it. I think you're trying to add a `script` option to the `Deploy` class, but you're not actually using it. I think you're trying to add a `script` option to the `Deploy` class, but you're not actually using it. I think you're trying to add a `script` option to the `Deploy` class, but you're not actually using it. I think you're trying to add a `script` option to the `Deploy` class, but you're not actually using it. I", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a default value for `script` in the `Addons::Deploy` class. This way, if the user doesn't specify a `script`, the default value will be used.", "reference": "Is this intended to be here? Seems it belongs to a different PR." }, { @@ -7251,7 +7251,7 @@ "reference": "These changes, while harmless, were no longer needed with newer versions of System.Console thanks to @ianhays" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to have this in a separate file.", + "prediction": "I think it's better to raise an exception here, so that the user knows that they need to install boto3 to be able to use ECSTasks.", "reference": "Umm... this isn't relevant to this PR" }, { @@ -7259,15 +7259,15 @@ "reference": "While All make some sense here it doesn't make a lot of sense in the SkipOnFramework context. I wonder if we really need to expose anything more here. You can just blindly use 0." }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it's a good idea to have a separate package for the viper-cobra commands.", + "prediction": "I'm not sure if this is a good idea, but I think it's better to have a separate package for the viper-cobra commands.", "reference": "Actually, this is not correct. Package `cmd/bee` doe snot have any notion of commands or even libraries used for them. It is as simple as possible, just calling the function from `cmd/bee/cmd` which actually implements commands." }, { - "prediction": "I don't think you need to do this. You can just use `this.route('users', { path: '/' });`", + "prediction": "I don't think you need to do this. You can just use `this.route('users', { path: '/users' });`", "reference": "This change is causing tests to fail because users sits at `/app/users`, not `/app/admin/users`" }, { - "prediction": "I'm not sure what you mean by \"same-site\". I think you meant to say \"same-origin\".", + "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea to add it here.", "reference": "Could you provide more information on what exactly each of those three options do?" }, { @@ -7275,19 +7275,19 @@ "reference": "Why this line break?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but it looks like you're trying to add a new API version to the `apiextensions` package. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to add a new API version to the `apiextensions` package. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to add a new API version to the `apiextensions` package. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to add a new API version to the `apiextensions` package. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to add a new API version to the `apiextensions` package. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to add a new API version to the `apiextensions` package. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to add a new API version to the `apiextensions` package. I'm not sure what you're trying to achieve with", + "prediction": "`apiextensionsv1` should be `apiextensionsv1beta1`", "reference": "We're importing this twice with different aliases." }, { - "prediction": "I'm not sure if this is necessary, but I think it's better to use `pytest-cov>=2.10.1` instead of `pytest-cov==2.10.1` because `pytest-cov==2.10.1` is not compatible with `pytest-cov>=2.10.1`.", + "prediction": "I'm not sure if this is necessary, but I think it's better to use `>=3.0.5` instead of `>=4.3.21` for `pandera`.", "reference": "We should avoid adding a pandera dependency to Dagster itself." }, { - "prediction": "I think we should remove the `if (permit) { ... }` block, as it's not necessary.", + "prediction": "I think we should remove the `if (permit) { ... }` block.", "reference": "Can be replaced with `org.jkiss.utils.ArrayUtils#add`." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to close all of the `IOUtils.closeQuietly` calls in parallel. Is that what you're trying to do?", + "prediction": "I think we can remove the `IOUtils::closeQuietly` call here.", "reference": "While we're here, this line (and a few others) should be `customThreadPool.submit(() -> IOUtils.closeQuietly(overseer);` I have no idea why we're creating a collection and a stream for a single object." }, { @@ -7295,15 +7295,15 @@ "reference": "Should these restrictions also be reflected in the API docs?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. It's not clear to me if this is the right place to do this, but I think it would be a good place to do this. It's not clear to me if this is the right place to do this, but I think it would be a good place to do this. It's not clear to me if this is the right place to do this, but I think it would be a good place to do this. It's not clear to me if this is the right place to do this, but I think it would be a good place to do this. It's not clear to me if this is the right place to do this, but I think it would be a good place to do this. It's not clear to me if this is the right place to do this, but I think it would be a good place to do this. It's not clear to me if this is the right place to do this, but I think it would be a good place to do this. It's not clear to me if this is the right place to do this, but I think it would be a good place to", + "prediction": "I'm not sure why we need to restore the original request before invoking the error handler chain. I think we can just pass the original request directly to the error handler.", "reference": "What about the request headers if someone uses `request_header`? :thinking:" }, { - "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to make sure that the `--provider=aws` flag is passed to the `deployExternalDNS` function. This way, we can ensure that the `--provider` flag is always passed to the `deployExternalDNS` function, even if the `--provider` flag is not passed to the `deployExternalDNS` function. This way, we can ensure that the `--provider` flag is always passed to the `deployExternalDNS` function, even if the `--provider` flag is not passed to the `deployExternalDNS` function. This way, we can ensure that the `--provider` flag is always passed to the `deployExternalDNS` function, even if the `--provider` flag is not passed to the `deployExternalDNS` function. This way, we can ensure that the `--provider` flag is always passed to the `deployExternalDNS` function, even if the `--provider` flag is not passed to the `deployExternalDNS` function. This way, we can ensure that the `--provider` flag is always passed to the `deployExternalDNS` function, even if the `--provider", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `fmt.Sprintf` here.", "reference": "Verify that external-dns allows setting this parameter multiple times (that it's not \"last one wins\")." }, { - "prediction": "I'm not sure what you mean by \"nofile:262144:262144\"", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to set up a network with `foo` and `bar`, but you're not specifying the IP addresses for those networks. I'm not sure what you're trying to do here, but it looks like you're trying to set up a network with `foo` and `bar`, but you're not specifying the IP addresses for those networks. I'm not sure what you're trying to do here, but it looks like you're trying to set up a network with `foo` and `bar`, but you're not specifying the IP addresses for those networks. I'm not sure what you're trying to do here, but it looks like you're trying to set up a network with `foo` and `bar`, but you're not specifying the IP addresses for those networks. I'm not sure what you're trying to do here, but it looks like you're trying to set up a network with `foo` and `bar`, but you're not specifying the IP addresses for those networks. I'm not sure what you're trying to do here, but it looks like you're trying to set up a network with `foo` and `bar`, but you're not", "reference": "Maybe 2 host/ip values could be used in the example?" }, { @@ -7311,15 +7311,15 @@ "reference": "We're only testing `RateLimiter.Allowed(Span)`, so I think we can use a mock `ITraceContext` instead of a real `Tracer` or `TraceContext`." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate function for creating the tarball.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for creating the tarball.", "reference": "IMO, this is the wrong way to associate a model with a trainer... Why the string when you actually have a trainer object?" }, { - "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to check if a block exists in the ledger, and if it does, you want to see if it's the same block as the one being processed.", + "prediction": "I'm not sure I understand what you're trying to do here.", "reference": "Wondering if we can directly put types here & for other similar ledger_processor items like rai::block_type::state" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `pruneRepository` function.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in a separate function, so that we don't have to call it multiple times.", "reference": "As `DeleteFiles` is not only used for prune this function deserves its own file. Maybe something like `delete_files.go` or `parallel.go`?" }, { @@ -7327,7 +7327,7 @@ "reference": "It should be simplified character. `` -> ``" }, { - "prediction": "I'm not sure what you mean by `ParallelLevels => -1`. I think you meant to say `ParallelLevels => 0`.", + "prediction": "I think this should be `TrieNode` instead of `TrieNode`.", "reference": "I am pretty sure it breaks the visitor pattern, visitor should have no knowledge about the structure of what it is visiting or control over visiting mechanism" }, { @@ -7335,11 +7335,11 @@ "reference": "'A' instead of 'An' here" }, { - "prediction": "I'm not sure if this is a good idea or not, but I think it's better to use `DefaultTimeout` and `DefaultLongPollTimeout` instead of `DefaultTimeout * time.Second` and `DefaultLongPollTimeout * time.Minute * 3`.", + "prediction": "`DefaultTimeout` and `DefaultLongPollTimeout` should be `time.Duration` instead of `time.Time`", "reference": "Can you flip it back (here and in other places)? It is more natural to represent \"10 seconds\" as `10 * time.Second`." }, { - "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here. Is it that you want to train a classifier on the data? Or is it that you want to use the data to train a classifier? Or is it that you want to train a classifier on the data? Or is it that you want to use the data to train a classifier? Or is it that you want to train a classifier on the data? Or is it that you want to use the data to train a classifier? Or is it that you want to train a classifier on the data? Or is it that you want to use the data to train a classifier? Or is it that you want to train a classifier on the data? Or is it that you want to use the data to train a classifier? Or is it that you want to train a classifier on the data? Or is it that you want to use the data to train a classifier? Or is it that you want to train a classifier on the data? Or is it that you want to use the data to train a classifier? Or is it that you want to train a classifier on the data? Or is it that you want to use the data to train a classifier? Or is it", + "prediction": "I don't think this is a good idea.", "reference": "Why was this necessary? You should just use the `dask_classifier` defined below this. With this change, you'd only be doing the local predict on arrays each time, but we want to test on all of DataFrame, Array, and sparse matrix." }, { @@ -7351,11 +7351,11 @@ "reference": "Please revert the lines above. Not touching unrelated code keeps the git history clean." }, { - "prediction": "I think we should use `__version__ = '2.3.0'` instead of `__version__ = '2.3.0rc0'`.", + "prediction": "I don't think this is needed anymore.", "reference": "`short_version` and `version_info`" }, { - "prediction": "I think we can remove the `Task` field from the `TaskStateChange` struct.", + "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason for this change?", "reference": "This is supposed to be `status`. Why did you change this?" }, { @@ -7363,15 +7363,15 @@ "reference": "I will change all of these at some point next week." }, { - "prediction": "I think this should be `TargetAssembly` instead of `TargetAssemblies`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a `TargetAssemblies` property on the `TargetAssemblyInfo` class, so that we don't have to call `TargetAssembly` every time we want to get the `TargetAssemblies` property.", "reference": "I made this change because, while trying to debug, in Visual Studio, the `IntegrationSignatureTests`, this property getter was hit and interfered with my ability to complete the debugging." }, { - "prediction": "I think it's better to use `scheme.Scheme.Convert` to convert `obj` to `d` instead of `obj` to `d` and `err` to `d`.", + "prediction": "I think it's better to use `scheme.Scheme.Convert` to convert the object to `appsv1.Deployment` and then use `scheme.Scheme.Convert` again to convert it to `model.KubernetesResourceState`.", "reference": "nit: `\"Unexpected error while calculating: unable to convert %T to %T: %v\"`" }, { - "prediction": "I think this should be `@JsonProperty(\"appName\")` instead of `@JsonProperty(\"packagePrefix\")`.", + "prediction": "I think we should remove the `@JsonProperty(\"appName\")` from the `SampleConfig` class.", "reference": "I'd actually recommend not putting this in the `SampleConfig`, it's intended more for properties that are inherent of the discovery format. Add a method `getSampleAppName(String apiTypeName)` to `SampleNamer` and override it in the language specific `SampleNamer`s if needed. Then assign it in the transformer." }, { @@ -7383,7 +7383,7 @@ "reference": "Rails will autorequire `acts_as_editable` once it encounters the constant `ActsAsEditable`. Thus if we move `ActiveRecord::Base.send :include, ActsAsEditable` from _acts_as_editable.rb_ to this file, the require line will not be needed anymore. Instead of requiring the file ourselves, we will let Rails do it for us. This fix will also remove the need to explicitly require `acts_as_editable` in _mock_active_record_base.rb_." }, { - "prediction": "I think we should remove the `@Nullable` from `upperCamelMethodName()`.", + "prediction": "I think we should remove the `@Nullable` from the `upperCamelMethodName()` method.", "reference": "I think we should name this `grpcMethodName` or similar. That is what this refers to, right? The fact that it is upper camel is an implementation." }, { @@ -7391,47 +7391,47 @@ "reference": "What if .. appears, but not as the first character, eg \"errors/../../../../../../../../../../../\"?" }, { - "prediction": "I'm not sure what you mean by \"owned by a guidance group\"", + "prediction": "I'm not sure what you mean by \"owned by a guidance group\". I think you meant \"owned by a guidance group\".", "reference": "Thanks, this should make things a bit easier for people who pick up the codebase but aren't a `curation center`" }, { - "prediction": "I think this should be `public static final int MAX_FORM_CONTENT_SIZE = 10 * 1024 * 1024;` instead of `private static final int MAX_FORM_CONTENT_SIZE = 10 * 1024 * 1024;`", + "prediction": "I don't think this is needed anymore.", "reference": "why not removing it?" }, { - "prediction": "I think we should remove the `FlagTLSEnableHostVerification` and `FlagTLSDisableHostVerification` as they are no longer needed.", + "prediction": "I think this flag should be `FlagTLSServerName` instead of `FlagTLSEnableHostVerification`.", "reference": "same nit here: maybe word as - \"disables validation of the temporal cluster's server certificate\"" }, { - "prediction": "I'm not sure what you're trying to achieve with this test, but I think it's a bit misleading. I think you're trying to test that the catalog name is the same as the current catalog, and that the catalog name is the same as the configured default namespace. If that's the case, then the test should pass. If not, then the test should fail.", + "prediction": "I'm not sure what you mean by \"configured default namespace\". I think you meant \"configured default database\" or \"configured default tablespace\" or something like that.", "reference": "Nit: other statements use all caps for SQL reserved words. Should this be `SHOW TABLES`?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate function for `is_a_code_line` and `isLuaIdentifier` so that we don't have to do this in the `extract_next_token` function. I think it would be a good idea to have a separate function for `is_a_code_line` and `isLuaIdentifier` so that we don't have to do this in the `extract_next_token` function. I think it would be a good idea to have a separate function for `is_a_code_line` and `isLuaIdentifier` so that we don't have to do this in the `extract_next_token` function. I think it would be a good idea to have a separate function for `is_a_code_line` and `isLuaIdentifier` so that we don't have to do this in the `extract_next_token` function. I think it would be a good idea to have a separate function for `is_a_code_line` and `isLuaIdentifier` so that we don't have to do this in the `extract_next_token` function. I think it would be a good idea to have a separate function for `is_a_code_line` and", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check to see if the next token is an identifier, and if it is, then set the `name` variable to the identifier.", "reference": "Do we need this? isLuaIdentifier() is used not only in extract_next_token() but also in extract_prev_toke(). I wonder whether the change for isLuaIdentifier() has an impact on extract_prev_toke() or not. If you are not sure, keep isLuaIdentifier() as is. If you are sure, could you write your conviction to the commit log." }, { - "prediction": "I'm not sure what you mean by \"fragment packets at 1400 bytes\". I think you meant to say \"fragment packets at 1500 bytes\".", + "prediction": "I'm not sure what you mean by \"underlying network stack\". I think it's referring to the underlying network stack of the Kubernetes provider, not the underlying network stack of the VM.", "reference": "This line should actually be: `if c.KubernetesProvider == config.ProviderAKS && c.Wireguard.EncryptHostTraffic {` because we only need to tweak the MTU like this on AKS." }, { - "prediction": "I think we should remove `svcFlagDescription` and `envFlagDescription` as they are not used.", + "prediction": "I don't think this is a good idea. The `svc` and `pipeline` flags should be the same as the `app` and `env` flags, respectively.", "reference": "Do we need to change this flag as well?" }, { - "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "prediction": "I think it's better to use `grunt.file.write` instead of `grunt.file.write(fileset.dest, 'exports.source = ' + JSON.stringify(source) + ';');`", "reference": "Including the source twice here makes the filesize jump to 432kb. Is there any way to minimize repeating it?" }, { - "prediction": "I think this should be `setParameter('handle', nameOrHandle)` instead of `setParameter('name', nameOrHandle)`.", + "prediction": "I think it's better to use `setParameter('handle', nameOrHandle)` instead of `setParameter('name', nameOrHandle)`.", "reference": "This should only be sent if the driver is speaking to a W3C conformant remote, so we need an if-condition check like we have in the Python bindings." }, { - "prediction": "I think we should merge the `plan_vars` and `target_vars` into the `topscope_vars` variable.", + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", "reference": "Only one line of code? What a simple issue!" }, { - "prediction": "I'm not sure I understand what you're trying to do here. The `rateLimiter` is just a rate limiter, it's not a rate limiter that limits the number of requests per second. It's a rate limiter that limits the number of requests per minute.", + "prediction": "I'm not sure I understand what you're trying to do here. The `rateLimiter` is just a rate limiter that will be used to limit the number of requests that can be made in a given time period.", "reference": "Conceptual question: why do history and matching need throttler at all? Shouldn't throttling to be handled on FE only?" }, { @@ -7443,27 +7443,27 @@ "reference": "Minor: you can access `current_user` in here directly - don't need to pass it in. Unless you prefer passing it explicitly?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.", + "prediction": "I think this should be `attributes = attributes.with_indifferent_access.sort do |a, b| a[0].to_i <=> b[0].to_i`", "reference": "What is the purpose of `&` on this line?" }, { - "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `/\\d+/.test( webDataStreamID );` instead of `typeof webDataStreamID === 'string' && /\\d+/.test( webDataStreamID );`. I'm not sure if it's a good idea to use `/\\d+/.test( webDataStreamID );` instead of `typeof webDataStreamID === 'string' && /^[a-zA-Z0-9]+$/.test( webDataStreamID );`. I'm not sure if it's a good idea to use `/\\d+/.test( webDataStreamID );` instead of `typeof webDataStreamID === 'string' && /^[a-zA-Z0-9]+$/.test( webDataStreamID );`. I'm not sure if it's a good idea to use `/\\d+/.test( webDataStreamID );` instead of `typeof webDataStreamID === 'string' && /\\d+/.test( webDataStreamID );`. I'm not sure if it's a good idea to use `/\\d+/.test( webDataStreamID );` instead of `typeof webDataStreamID === 'string' && /^[a-zA-Z0-9]+$/.test", + "prediction": "I think this should be `/\\d+/.test( webDataStreamID )` instead of `/\\d+/.test( webDataStreamID );`", "reference": "See above, the `isValidWebDataStreamID` implementation from before is actually correct. What we need here instead is a new `isValidMeasurementID` function." }, { - "prediction": "I think it's better to return nil in this case, since we don't want to close the connection here.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check for `c.flags.isSet(infoReceived)`. If it's not set, then we don't need to do anything. If it is set, then we need to do something.", "reference": "Should be an error... it is important for the admin of the server attempting to create the leafnode connection to see the error asap." }, { - "prediction": "I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place", + "prediction": "I'm not sure if this is the best place to do this, but I think it's a good place to do this. The reason is that we don't want to change the `selected` state of an object if only one item is selected. If we do this now, we'll end up changing the `selected` state of an object if only one item is selected, which is not what we want.", "reference": "Could you split these conditions up over multiple lines please." }, { - "prediction": "I think this should be `len(parts) == 3` instead of `len(parts) == 2`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.", "reference": "I think we can just change this to `Split` instead of `SplitN`. I don't think we need to limit the number of parts in the tag." }, { - "prediction": "I'm not sure if this is a good idea or not, but I think it's better to use `{{ range $port := .ports }}{{ $port }}:{{ $port }} {{ end }}` instead of `{{ range $port := .ports }}{{ $port }}:{{ $port }} {{ end }}`", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `{{ range $port := .ports }}- {{ $port }}:{{ $port }} {{ end }}` instead of `{{ range $port := .ports }}- {{ $port }}:{{ $port }} {{ end }}`", "reference": "So this is actually a mistake that I introduced without realizing it, and have known would need to be fixed when we get here . The format of the ports directive is \"host:container\". We only want the host port to change, not the internal container ports. The ports variable probably needs to be a map which maps external -> internal ports." }, { @@ -7471,11 +7471,11 @@ "reference": "An alternate approach would be to always initialize shardInfo with a dummy (non-nil) value, which could protect against other uses before it's initialized (I couldn't find any though). But I can change it to do it that way instead." }, { - "prediction": "I think this should be `keybase1.NodeMetadata` instead of `keybase1.UID`.", + "prediction": "I think we can remove the `NodeMetadata` struct and just use the `keybase1.UID` struct instead.", "reference": "Maybe we can just put the entire `DirEntry` in here? I can imagine it might be useful for debugging to get the block ID/refnonce, encrypted size, key gen, data version, etc. What do you think?" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to `ewmh_client.h` so that it can be used by `ewmh_client.c` and `ewmh_client_update.h`.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `ewmh_client_update_hints` function.", "reference": "For the commit message: The paragraphs seem to be out of order? The `Would not work because` refers to the stuff before, but there is a `This may seem pointless, but` in-between." }, { @@ -7483,7 +7483,7 @@ "reference": "Why did you remove these packages from the prelude, will your new functions not work without this change?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `asyncProcess` function.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to `asyncProcess` as well.", "reference": "We'd better reserve enough space before using kvKeys to avoid extra malloc." }, { @@ -7491,47 +7491,47 @@ "reference": "would it make sense to return empty or error if label doesn't exists?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a timeout for the `attemptRm` function. This way, if the `attemptRm` function takes too long to run, it will be retried.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `setTimeout` here.", "reference": "Don't penalize everyone with 250ms delay b/c some machines have problems." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to get rid of the `fmt.Sprintf(\"%s %s\", out, it.Value().String())` line, but I'm not sure what you're trying to do with it.", + "prediction": "I'm not sure if this is the right way to do this, but I think we should be able to do this in one line.", "reference": "Probably want a space after the second %s?" }, { - "prediction": "I think this should be `if !exists { return nil, serviceerror.NewInvalidArgument(archiver.ErrHistoryNotExist.Error()) }` instead of `if !exists { return nil, serviceerror.NewInvalidArgument(archiver.ErrHistoryNotExist.Error()) }`", + "prediction": "I think this should be `serviceerror.NewInvalidArgument(archiver.ErrHistoryNotExist.Error())` instead of `serviceerror.NewUnavailable(err.Error())`", "reference": "This seems like an internal error still?" }, { - "prediction": "I'm not sure what you're trying to achieve with this test, but I think it's a bit misleading. The `FakeStripe` object is used to simulate the creation of a Stripe token, but it's not used to actually charge the customer's account. If you want to simulate the creation of a Stripe token, you should use `FakeStripe.create` or `FakeStripe.create!` instead.", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to mock the `FakeStripe` class, but I'm not sure what you're trying to do with it. I think you're trying to mock the `FakeStripe` class, but I'm not sure what you're trying to do with it. I think you're trying to mock the `FakeStripe` class, but I'm not sure what you're trying to do with it. I think you're trying to mock the `FakeStripe` class, but I'm not sure what you're trying to do with it. I think you're trying to mock the `FakeStripe` class, but I'm not sure what you're trying to do with it. I think you're trying to mock the `FakeStripe` class, but I'm not sure what you're trying to do with it. I think you're trying to mock the `FakeStripe` class, but I'm not sure what you're trying to do with it. I think you're trying to mock the `FakeStripe` class, but I'm not sure what you're trying to do with it. I think you're trying to mock the `FakeStripe` class, but I'm not sure what", "reference": "Line is too long. [94/80]" }, { - "prediction": "I'm not sure what you mean by \"as provided by the user or generated by the Antrea Controller\". Could you please clarify?", + "prediction": "I'm not sure I understand what you're trying to do here. The `Get` method should return a `ClusterIdentity` and a `time.Time`, not a `uuid.UUID` and a `time.Time`.", "reference": "out of curiosity, why creating another struct to wrap it?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea.", + "prediction": "I'm not sure I understand what you're trying to do here.", "reference": "discipline vs. Discipline? Not sure of which is correct. Also not sure if there is already an existing string const." }, { - "prediction": "I think we should remove the `build()` method. It's not needed anymore.", + "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to do this in one line.", "reference": "I believe this will break common resources, as they are defined in a common file, but must generate classes in service-specific namespace, so using protoFile to determine package of the generated class would not work, because common_resources namespace does not match service namespace." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a column with a default value of 0, but that doesn't make sense. I'm not sure what you're trying to do here. I think you're trying to create a column with a default value of 0, but that doesn't make sense. I'm not sure what you're trying to do here. I think you're trying to create a column with a default value of 0, but that doesn't make sense. I'm not sure what you're trying to do here. I think you're trying to create a column with a default value of 0, but that doesn't make sense. I'm not sure what you're trying to do here. I think you're trying to create a column with a default value of 0, but that doesn't make sense. I'm not sure what you're trying to do here. I think you're trying to create a column with a default value of 0, but that doesn't make sense. I'm not sure what you're trying to do here. I think you're trying to create a column with a default value of 0, but that doesn't make sense. I'm not sure", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `__natural_order__` as a column name.", "reference": "How about `SPARK_DEFAULT_SERIES_NAME`?" }, { - "prediction": "I think we can remove the `MANIFEST_TARGET_SIZE_BYTES` from the list of properties. It's not used anywhere in the code.", + "prediction": "I think we can remove the `MANIFEST_TARGET_SIZE_BYTES` from the `TableProperties` class, since it's not used anywhere.", "reference": "The other properties are in `commit.status-check`, not `commit.status-checks`. Could you remove the extra `s`?" }, { - "prediction": "I think this should be `if (configuration.usingUnifiedTopology())` instead of `if (configuration.usingUnifiedTopology()) { return this.skip(); }`", + "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to skip this test.", "reference": "Side note: I'd love to see more of these fields exposed on configuration." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.", "reference": "In the case of accounts generated by API clients, what name gets put for the `inviter_name` or `invited_by` record?" }, { @@ -7539,11 +7539,11 @@ "reference": "I think this class is only relevant for updating the QbftConfigOptions based on the transitions config, so probably not." }, { - "prediction": "I'm not sure what this is for, but it looks like it should be `ExecutionError` and `TracerTimeout` instead of `ExecutionError` and `TracerTimeout`.", + "prediction": "I think this should be 32017 instead of 32016.", "reference": "what is the number thrown by Geth?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `apiMongoDb` and `frontendMongoDb` in the `checkDatabaseConfigMatch` function. This way, we can make sure that `apiMongoDb` and `frontendMongoDb` are the same for both `apiConfig` and `frontendConfig`, and that `apiMongoHost` and `frontendMongoHost` are the same for both `apiConfig` and `frontendConfig`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good place to do this. I think it's a good idea to make sure that the `apiConfig` and `frontendConfig` are in the same format, so that we don't have to worry about the order of the parts.", "reference": "This would still crash on malformed database connection string like \"test\"" }, { @@ -7551,71 +7551,71 @@ "reference": "it is not an interface, maybe we can move to another package?" }, { - "prediction": "I'm not sure what you mean by `priv` and `tableMeta` in this context. Could you please provide more context?", + "prediction": "I don't understand what you mean by this. What do you want me to do with it?", "reference": "Same here. Can we use `this.instance.getSettings()` to get `tableMeta`?" }, { - "prediction": "I think this should be `if cgroup.Resources.CpuWeight != 0 || cgroup.Resources.CpuMax != \"\"`", + "prediction": "I think we should remove the `if cgroup.Resources.CpuWeight != 0 || cgroup.Resources.CpuMax != \"\"` check.", "reference": "Not sure whether this validation is useful." }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to have this in the `PromptContainer` class, since it's used in the `prompt_yank` method.", + "prediction": "I'm not sure I understand what you're trying to do here, but I think we should remove the `@cmdutils.register` decorator.", "reference": "Various things to note here: - Why would `question` ever be falsey (or `None`) here, i.e. why the `if question`? - Why would `question` ever not have that attribute? You set it in `Question.__init__`, so that check does nothing at all (and generally, `hasattr()` should be avoided if possible). - Why do you want to yank `None` (what does that do?) rather than e.g. show an error if there's nothing to yank?" }, { - "prediction": "I don't think this is necessary.", + "prediction": "I don't think we need to do this.", "reference": "If this is needed for testing, you should use `pytest --log-cli-level=INFO` instead." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `DefaultNodeOptions` struct, since it's used by the `DefaultNode` struct as well.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to `metadata.Testnet2Definition` instead of `metadata.Testnet2Definition.EtherClientRPC`.", "reference": "We should drop ipify in all places i guess" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `ConsensusParams` struct.", + "prediction": "I don't think we need to change the default value of `AgreementFilterTimeoutPeriod0SmallLambdas` to `time.Duration(0)`. We can just set it to `time.Duration(0)`.", "reference": "Add explanations around these variables - what do they mean, how they should be configured, etc." }, { - "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea to call `OsmCommunityIndex::LocalChapter.add_to_i18n` on app init.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to call this method on app init.", "reference": "One thing tho - I would really appreciate any advice on where to move this to, so that it's called on initialisation of the website." }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to have this in the config file. I'm not sure if this is a good place to put this, but I think it's a good idea to have this in the config file. I'm not sure if this is a good place to put this, but I think it's a good idea to have this in the config file. I'm not sure if this is a good place to put this, but I think it's a good idea to have this in the config file. I'm not sure if this is a good place to put this, but I think it's a good idea to have this in the config file. I'm not sure if this is a good place to put this, but I think it's a good idea to have this in the config file. I'm not sure if this is a good place to put this, but I think it's a good idea to have this in the config file. I'm not sure if this is a good place to put this, but I think it's a good idea to have this in the config file. I'm not sure if this is a good place to put this, but I", + "prediction": "I think this should be `@ConfigItem(position = 21, keyName = \"displayResources\", name = \"Show raw resources gathered\", description = \"Displays how much of each resource you have gathered.\", titleSection = \"resources\")`", "reference": "To much tabs here (1 tab)" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think we should be able to do this in a single query.", + "prediction": "I don't think this is the right place to do this. I think it should be done in the `ExecutionLogsDao` class.", "reference": "This is not maintaining retention time for logs as we are deleting only 1000 entries and we might end up with huge number of rows spanning over multiple months over a period of time if the cluster generates more rows as we are restricting ourselves to delete only 24k rows/day. Like I pointed out earlier a better would be to probably run this clean up every hour with some batch_size in a loop while there are records to be deleted(i.e older than 12 weeks) and committing each batch." }, { - "prediction": "I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure", + "prediction": "I'm not sure I understand what you're trying to do here. I don't think you need to override the workflow retry policy.", "reference": "I don't like this helper func :-). Yeah, definitely don't like." }, { - "prediction": "I don't think this is a good idea. It would be better to use `request.respond( { status: 200, body: JSON.stringify( {} ) } );` instead of `request.respond( { status: 200 } );`", + "prediction": "I don't think we need to do anything here.", "reference": "Same here. This should remain unchanged. Please, add it back." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to make this a property of the `topology` object, so that it can be used in the `initializeUnorderedBulkOp` method.", + "prediction": "I think we should remove the `ignoreUndefined` option from the `initializeUnorderedBulkOp` method.", "reference": "@kvwalker should this method have `ignoreUndefined` supported as an `option`?" }, { - "prediction": "I think we can remove the `sugaredLogger` here, since it's not used anywhere else.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate logger for the transformer, so that we don't have to use the same logger for both the transformer and the service.", "reference": "we dont use a `sugaredlogger` anywhere else in clutch, just curious why were using it here?" }, { - "prediction": "I think this should be `events = list(OrderedDict([(event.event_name, event) for event in self._queue]).values())`", + "prediction": "I'm not sure what you mean by \"unique event types in the queue\". Could you please clarify?", "reference": "Not evident from looking at this diff but the queue is already being cleared four lines below." }, { - "prediction": "I think this should be `if len(txgroup) == 1` instead of `if len(txgroup) == 0`", + "prediction": "I think this should be `if len(txgroup) == 1 { ... }` instead of `if len(txgroup) == 1 { t.Fee.IsZero() }`", "reference": "Why is this a 'transaction' and not in the block header?" }, { - "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to have the `Connection` property of the `ConnectionFilterContext` be a `Stream` instead of a `Stream` and `X509Certificate2` instead of a `X509Certificate2`. This is because the `Connection` property of the `ConnectionFilterContext` can be null, and the `X509Certificate2` property of the `ConnectionFilterContext` can be null as well.", + "prediction": "I'm not sure if this is a good idea or not. I think it's better to use `Stream` instead of `X509Certificate2` because `X509Certificate2` doesn't have a `CertificateThumbprint` property.", "reference": "This doesn't fit the abstraction level. Should we have a property bag for extra stuff?" }, { - "prediction": "I don't think we need to sort the files here. We already have them in the right order.", + "prediction": "I don't think we need to add this to the list of files.", "reference": "Looks like it is pretty easy to miss it when adding new files under `ci`. Hopefully, this doesn't happen too often." }, { @@ -7623,19 +7623,19 @@ "reference": "do we really need the `Ready` call if startup fails midway?" }, { - "prediction": "I'm not sure what you're trying to do with this test, but I'm not sure if it's a good idea to use `network::NetworkUtils::getAvailablePort()` here.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to `kvstore::kvstore` so that it can be used by `kvstore::kvstore::kvstore` and `kvstore::kvstore::kvstore::kvstore`.", "reference": "You can avoid changing the code if there are parameter defaults. right ?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `expect(...).to.equal(...).to.have.been.called(...).to.have.been.calledTwice` in this case. I think it's better to use `expect(...).to.have.property(...).to.have.been.called(...).to.have.been.calledTwice` instead.", "reference": "I wonder why the newline disappeared here? I guess we'll merge and see how SauceLabs fares across the supported browsers." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `world_repop` variable in the `command_reloadworld` function. This way, we can use it in the `command_corpsefix` function as well.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a separate function.", "reference": "I know this is legal, but I prefer we put brackets on our calls" }, { - "prediction": "I'm not sure what you're trying to achieve with this code snippet. It looks like you're trying to delete an AWS IAM server certificate, but I'm not sure what you're trying to achieve with this code snippet. Could you please provide more context or explain what you're trying to achieve with this code snippet?", + "prediction": "I'm not sure what you're trying to achieve with this snippet. It looks like you're trying to delete an IAM server certificate, but I'm not sure what you're trying to achieve with this snippet. It looks like you're trying to delete an IAM server certificate, but I'm not sure what you're trying to achieve with this snippet. It looks like you're trying to delete an IAM server certificate, but I'm not sure what you're trying to achieve with this snippet. It looks like you're trying to delete an IAM server certificate, but I'm not sure what you're trying to achieve with this snippet. It looks like you're trying to delete an IAM server certificate, but I'm not sure what you're trying to achieve with this snippet. It looks like you're trying to delete an IAM server certificate, but I'm not sure what you're trying to achieve with this snippet. It looks like you're trying to delete an IAM server certificate, but I'm not sure what you're trying to achieve with this snippet. It looks like you're trying to delete an IAM server certificate, but I'm not sure what you're trying to achieve with this snippet. It looks like you're trying to delete an IAM server certificate, but I'm not sure", "reference": "AWS Identity and Access Management (IAM)" }, { @@ -7643,15 +7643,15 @@ "reference": "We keep who wrote the code anonymous." }, { - "prediction": "I'm not sure I understand what you're trying to do here.", + "prediction": "I don't think we need to check for `isUndefined` in this case. We can just use `Number.isInteger` here.", "reference": "Two things to make the code more error-proof and simplify it: 1. To be safe, this should be: `! isUndefined( decimal ) && ! isUndefined( decimal.value )` 2. The other clause that you changed below can be combined with that since `decimal` isn't used anywhere else, and so there's no point to re-check whether it's not undefined. In other words, this should become: `! isUndefined( decimal ) && ! isUndefined( decimal.value ) && 1000 > number`, and then you can remove the `decimal = decimal.value` assignment and replace it with line 146 (assignment of `readableNumber`)." }, { - "prediction": "I think we should remove the `[]Transport` from the `Outbound` interface, as it's not really needed.", + "prediction": "I'm not sure what you mean by \"composite outbounds may use multiple transport protocols\". Could you please clarify?", "reference": "Wouldn't composite outbounds compose the transport, such that it would still be represented as a single transport?" }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. Is it that you want to create a new alertmanager instance in each namespace? Or is it that you want to create a new alertmanager instance in all namespaces? I'm not sure what you're trying to do here.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to create a namespace in the middle of a test. I think it's better to create a namespace at the start of the test and then delete it when the test is done.", "reference": "nit: there is no need for a new line here, usually we tend to put an object creation and its deferred deletion next to each other. It helps not forgetting about the cleanup." }, { @@ -7659,7 +7659,7 @@ "reference": "Feel free to use the full notation with my email address: `Maxime Steinhausser ` :smile:" }, { - "prediction": "I'm not sure what you're trying to achieve with this flag, but I think it's a good idea to remove it. It's not used anywhere in the code, and I don't think it's necessary to keep it around.", + "prediction": "I'm not sure what this is for, but it looks like it could be used in a way that is not allowed by the spec. I'm not sure if this is intentional or not, but I think it's important to be aware of it.", "reference": "This was unused across the codebase" }, { @@ -7671,31 +7671,31 @@ "reference": "either SUPPORTED_TYPECLASS or supported_typeclass. Camelcase only for class names." }, { - "prediction": "I'm not sure if this is a good idea, but I think it's better to have `pinned` as a separate column than to have `pinned` and `todo_completed` in the same column.", + "prediction": "I don't think we need to add `pinned` to the `notes` table.", "reference": "This is not going to work. You need to add a migration to the database." }, { - "prediction": "I think we should rename this method to something like `resumeGroupPlayback` instead of `resumeGroupPlayback`", + "prediction": "I think we should rename this method to `resumeGroupPlayback` instead of `resumeGroupPlaybackCore`.", "reference": "Should these methods be renamed in this PR?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check to see if the instrument name is valid before adding it to the `metricStreamNames` dictionary. This way, we don't accidentally add an invalid instrument name to the dictionary, which could cause issues down the line.", + "prediction": "I don't think we need to do this.", "reference": "we need to include the `metricStreamName` which is invalid, so users know whats causing the issue." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but it seems like you're trying to load the assembly into the load context and then query for a reference to find the types and cache the symbol information. I'm not sure what you're trying to achieve with this change, but it seems like you're trying to load the assembly into the load context and then query for a reference to find the types and cache the symbol information. I'm not sure what you're trying to achieve with this change, but it seems like you're trying to load the assembly into the load context and then query for a reference to find the types and cache the symbol information. I'm not sure what you're trying to achieve with this change, but it seems like you're trying to load the assembly into the load context and then query for a reference to find the types and cache the symbol information. I'm not sure what you're trying to achieve with this change, but it seems like you're trying to load the assembly into the load context and then query for a reference to find the types and cache the symbol information. I'm not sure what you're trying to achieve with this change, but it seems like you're trying to load the assembly into the load context and then", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea to load the assembly into the load context and then query for a reference to find the types and cache the symbol information. It's better to load the assembly directly into the load context and then query for a reference to find the types and cache the symbol information.", "reference": "Please run Platform tests `DiaSessionTests`." }, { - "prediction": "I think this should be `if (is_evex)` instead of `if (di->is_evex)`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check here to make sure we don't try to use a string that doesn't exist. I'm not sure if this is the right place to do this, but I think it's a good idea to add a check here to make sure we don't try to use a string that doesn't exist. I'm not sure if this is the right place to do this, but I think it's a good idea to add a check here to make sure we don't try to use a string that doesn't exist. I'm not sure if this is the right place to do this, but I think it's a good idea to add a check here to make sure we don't try to use a string that doesn't exist. I'm not sure if this is the right place to do this, but I think it's a good idea to add a check here to make sure we don't try to use a string that doesn't exist. I'm not sure if this is the right place to do this, but I think it's a good idea to add a check here to make sure we don't try to use a string that doesn't", "reference": "This is debug-build-only: we want a release-build notice. SYSLOG takes the name w/o the MSG and no _STRING. Args are via events.mc specifiers." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to parse a SRV URI, but it seems like you're trying to parse a URI that doesn't have a hostname, domain name, or TLD. I'm not sure what you're trying to do here. I think you're trying to parse a SRV URI, but it seems like you're trying to parse a URI that doesn't have a hostname, domain name, or TLD. I'm not sure what you're trying to do here. I think you're trying to parse a SRV URI, but it seems like you're trying to parse a URI that doesn't have a hostname, domain name, or TLD. I'm not sure what you're trying to do here. I think you're trying to parse a SRV URI, but it seems like you're trying to parse a URI that doesn't have a hostname, domain name, or TLD. I'm not sure what you're trying to do here. I think you're trying to parse a SRV URI, but it seems like you're trying to parse a URI that doesn't have a hostname, domain name, or TLD. I'm not sure what you're trying to do here", + "prediction": "I'm not sure if this is the right place to do this, but I think it should be in the `parseSrvConnectionString` function.", "reference": "is it possible to have both forms here? I was hoping we wouldn't be introducing more cases where we had to check the upper and lowercase version of URI options." }, { - "prediction": "I think we can remove the `name` argument from the `BenchmarkInt64HistogramAdd` test.", + "prediction": "I think we can remove the `name` argument and just use `name` as the name of the histogram.", "reference": "Does the name suffix hardcode something? Not clear how changing the name fixes this." }, { @@ -7703,11 +7703,11 @@ "reference": "Is undispatched same as queued? getQueuedFlows?" }, { - "prediction": "I'm not sure what you're trying to do with this test, but I don't think it's necessary.", + "prediction": "I'm not sure what you mean by \"connection info tests.\" Could you please clarify?", "reference": "See above, same for all similar cases below." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this. I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this. I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this. I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this. I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this. I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this. I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this. I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this. I'm not sure if this is the right place to do this, but I think it would be good to have a", + "prediction": "I'm not sure I understand what you're trying to do here. Can you please provide more context? I'm not sure I understand what you're trying to do here. Can you please provide more context? I'm not sure I understand what you're trying to do here. Can you please provide more context? I'm not sure I understand what you're trying to do here. Can you please provide more context? I'm not sure I understand what you're trying to do here. Can you please provide more context? I'm not sure I understand what you're trying to do here. Can you please provide more context? I'm not sure I understand what you're trying to do here. Can you please provide more context? I'm not sure I understand what you're trying to do here. Can you please provide more context? I'm not sure I understand what you're trying to do here. Can you please provide more context? I'm not sure I understand what you're trying to do here. Can you please provide more context? I'm not sure I understand what you're trying to do here. Can you please provide more context? I'm not sure I understand what you're trying to do here. Can you please provide more context? I'm not sure", "reference": "Why is this done twice?" }, { @@ -7715,23 +7715,23 @@ "reference": "This sync can ensure that the condition of the child node is consistent with the parent node, but I still don't understand when the child will be overwritten, and this behavior is not what we expected?" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `TestEnvironment` function.", + "prediction": "I'm not sure if this is a good idea or not, but I think it would be better to use `state.DebugTests` and `state.DebugFailingTests` instead of `state.DebugTests` and `state.DebugFailingTests`.", "reference": "This was renamed to avoid any confusion with the more general case of debugging via `plz debug`" }, { - "prediction": "I think this should be `String` instead of `byte[]`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `String` class.", "reference": "String valStr = (String)val; valStr.substring(0, Math.min(valStr.length(), prefixLength)) Make it clean." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check here to make sure we don't have a union with an empty enum.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check here to make sure that we don't have an empty union.", "reference": "Sorry, this still makes no sense.. the value of any union or enum is simply a name integer constant, it has nothing to do with the `BASE_TYPE_` enum. This value should be `0`. In particular: `Every union has the NONE field, which always has value 0`." }, { - "prediction": "I'm not sure what you're trying to achieve with this method, but I think it's a bad idea to expose the `getAzkabanURL()` method in the `Alerter` interface. It's a private method that should be exposed in the `Alerter` class.", + "prediction": "I'm not sure what you mean by \"alert on failed executor health check\". Could you please provide more context?", "reference": "Looks like getAzkabanURL() is added after concrete Alerter (Emailer)::getAzkabanURL(), so that Override annotation is needed." }, { - "prediction": "I think this should be `img[mask] = img[mask] * 0.5 + color_mask * 0.5` instead of `img[mask] = img[mask] * 0.5 + color_mask * 0.5`", + "prediction": "I don't think this is necessary.", "reference": "The above 3 lines can be written as: `mask = segms[i].astype(bool)`" }, { @@ -7739,7 +7739,7 @@ "reference": "File is not `gofmt`-ed with `-s` (from `gofmt`)" }, { - "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to log the port number here.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `start` function.", "reference": "Thought it's good to have this logged down so that we can check the used value in the logs." }, { @@ -7751,27 +7751,27 @@ "reference": "@naofum please use `isEmpty`method instead" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `addModuleSet` function.", + "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to add a new module to the compile layer, but it's not being added to the module set. I think you want to add the module to the module set, but you're not doing that.", "reference": "i think this is unrelated and needs to be reverted. need to discuss at sync." }, { - "prediction": "Shouldn't `parentHash` be `Optional` instead of `Optional>`?", + "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a good idea to add a `parentHash` field to the `ProcessableBlockHeader` class.", "reference": "Are we eventually moving those type interfaces from plugin project to datatype project? If not, then we'd have a dependency from core onto plugins, which seems a little counter-intuitive to me." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to switch to a different database using the same connection pool. Is this what you're trying to do? If so, what's the purpose of the `syncIndexes` method?", + "prediction": "I don't think we need to do this. We can just use `this.connection` instead.", "reference": "Love how we can finally use async/await in the codebase." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `wallet_representative_set` function.", + "prediction": "I don't think this is necessary.", "reference": "Very minor: this line could be moved to a more narrow scope, inside `if (!representative.decode_account (representative_text))` Other than that, LGTM" }, { - "prediction": "I think it's better to use `uint32` for `StatusFlag` instead of `uint16`.", + "prediction": "I don't think we need this field, it's not used anywhere. We can remove it.", "reference": "when is this consumed? I'm probably missing it but I can't find it right now" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `generateCacheKey` method.", + "prediction": "I think it's better to use `isRollup()` instead of `grpExpr->isRollup()`.", "reference": "I think we also need to add the rollupGroupExprList() to the cache key. If we rebuild the list above from a ValueIdSet on line 418 above, it is probably going to be in the same order, regardless whether it was ROLLUP(a,b) or ROLLUP(b,a)." }, { @@ -7779,35 +7779,35 @@ "reference": "can use `getParamTypeName` instead" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `create` method of the `EntityName\\EditForm` class.", + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", "reference": "Why send the parameters? They're accessible directly from `$this->request` so there's no need to inject them in the method" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this method in the `QWebPage` class, since it's called by the `QWebPage`'s `chooseFiles` method.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in a separate file.", "reference": "Tiny nit: I would prefer `not selected_file` or `len(selected_file) == 0`, as if choose_file starts returning, for example, tuples instead of lists, this won't break." }, { - "prediction": "I don't think we need to remove the name file if a duplicate node name is used.", + "prediction": "I think this should be `if err != nil {` instead of `if err != nil { err = errors.New(\"Failed to join etcd cluster due to duplicate node names, please use unique node name for the server\") }`", "reference": "How will this code behave with hostnames that contain hyphens?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check to see if the molecule id keys are empty. If they are, then we should return an empty MoleculeAccessionNumbers.", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get rid of the `MoleculeAccessionNumbers` class, but you're still trying to use it. I'm not sure what you're trying to do here, but it looks like you're trying to get rid of the `MoleculeAccessionNumbers` class, but you're still trying to use it. I'm not sure what you're trying to do here, but it looks like you're trying to get rid of the `MoleculeAccessionNumbers` class, but you're still trying to use it. I'm not sure what you're trying to do here, but it looks like you're trying to get rid of the `MoleculeAccessionNumbers` class, but you're still trying to use it. I'm not sure what you're trying to do here, but it looks like you're trying to get rid of the `MoleculeAccessionNumbers` class, but you're still trying to use it. I'm not sure what you're trying to do here, but it looks like you're trying to get rid of the `MoleculeAccessionNumbers` class, but you're still trying to use it. I'm not sure", "reference": "I think this is redundant since \"NullForEmpty\" already calls \"Trim()\"." }, { - "prediction": "I'm not sure what you mean by \"names of the tasks performing this group backup\". Could you please clarify?", + "prediction": "I think it's better to have `CloudBackupGroupCreateResponse.GroupCloudBackupID` and `CloudBackupGroupCreateResponse.GroupCloudBackupName` instead of `CloudBackupGroupCreateResponse.GroupCloudBackupID` and `CloudBackupGroupCreateResponse.GroupCloudBackupName`.", "reference": "Change this to IDs too?" }, { - "prediction": "I think we should remove the `list_of_DC_SCOUT_RAIDS` from the `RaidsPlugin` class.", + "prediction": "I think we should remove the `list_of_DC_SCOUT_RAIDS` from the `layoutWhitelist` list.", "reference": "private static final, and it should be located in raidsoverlay, as it's not needed in the plugin. also the name could be a bit better, DC_SCOUT_RAIDS or similiar." }, { - "prediction": "I think this should be `fscanf(file, \"%127s\", attr_value);` instead of `fscanf(file, \"%127s\", attr_value)`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `parse_perf_attributes` function.", "reference": "attr_value is 128 bytes?" }, { - "prediction": "I don't think we need to add `method` to join dicts/lists from scenario/request level. We can just use `self.config.get(\"method\", \"GET\").upper()`.", + "prediction": "I don't think we need to check for `has_variable_pattern` here.", "reference": "if it's unpredictable - why uppercase it at all?" }, { @@ -7815,11 +7815,11 @@ "reference": "Please remove all these debug prints. It doesn't look good." }, { - "prediction": "I think this should be `sampleChainRandomness` instead of `sampleChainRandomness(sampleHeight *types.BlockHeight)`.", + "prediction": "I'm not sure what you mean by `sampleHeight * types.BlockHeight`. I think you meant `sampleHeight * blockHeight`.", "reference": "Consumers of this interface should not be required to provide `sampleHeight`. This should be an expected consensus parameter." }, { - "prediction": "I think we can remove the `if closeTime.Before(startTime) {` line.", + "prediction": "I don't think we need to use `time.UTC` here. We can just use `time.Now()` instead.", "reference": "I don't believe this is the right fix. If startTime comes after closeTime, then it means some other event triggered invocation of this code path like workflow timeout. In this case we should still try to fire the cron on previous value so we should just return start the delta between startTime and closeTime immediately." }, { @@ -7831,7 +7831,7 @@ "reference": "I wonder if it would be cleaner to refactor all of this similar to the SolrMarc driver, so we have a property with Summon field names associated with types, and we iterate through it in a loop... that way we don't have to repeat the loop code four times with different variable names." }, { - "prediction": "I'm not sure what you're trying to do here. You're creating a new `SolrClientCache` and then using it to create a `TupleStream`, but you're not using the `TupleStream` in any way.", + "prediction": "I don't think we need to use `createCloudSolrStream` here. We can just use `getCoreContainer().getSolrClientCache().getSolrStream()`", "reference": "Need the `solrClientCache.close();` further down in the method be removed since a shared cache is now used?" }, { @@ -7839,43 +7839,43 @@ "reference": "according to the PR (schema changes?) these 2 field should be removed?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. It's a bit of a hack, but I think it's the best way to do this.", + "prediction": "I think it's better to use `exp.Target.StressChaos.ContainerNames` instead of `exp.Target.StressChaos.ContainerName`.", "reference": "Panic here if `exp.Target.StressChaos.CintainerName` is nil." }, { - "prediction": "I think this should be `DocIdSetIterator` instead of `DocIdSetIteratorIterator`.", + "prediction": "I think it's better to use `DocIdSetIterator` instead of `DocIdSet` here.", "reference": "This allows for some hacks like returning an iterator that matches more docs than the scorer. I liked the previous approach that returned an iterator better." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think we need to do anything here.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in `IcebergInputFormat` instead of `InputFormat`.", "reference": "Aren't there already logs for this from the underlying file system implementation?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. The `CustomMunge` array should be an array of arrays, not an array of strings.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to change the `DismaxHandler` to `dismax` here.", "reference": "It would be good to have a test in here that demonstrates the new munge functionality; I can help set that up if you're not sure how." }, { - "prediction": "I'm not sure if this is a good idea, but I think it's better to use luigi.OptionalParameter instead of luigi.IntParameter.", + "prediction": "I don't think we need to change the default value of `max_retrials_to_get_pods` to 0.", "reference": "`retrials` isn't the word you intend. I think you mean `retries` and to that end, can the var name just be `max_retries`?" }, { - "prediction": "I think this should be `required` instead of `required_if`.", + "prediction": "I don't think we need to change the help text here. It's the same as before.", "reference": "Value in product should contain 255 characters or less." }, { - "prediction": "I think we can remove the `if timeout > minTimeout { ... }` block.", + "prediction": "I think it's better to use `time.Duration` for `netTimeout` and `time.Duration` for `idealHeight` instead of `time.Second` and `time.Duration` for `netTimeout` and `time.Duration` for `idealHeight`.", "reference": "line is 133 characters (from `lll`)" }, { - "prediction": "I'm not sure what you're trying to do here, but I think it's a bad idea to use `global_options` and `local_options` in this way. I think it would be better to use `global` and `local` instead.", + "prediction": "I'm not sure what you're trying to do here, but I think it's better to just use `global_options` and `local_options` instead of `custom_options` and `personal_options`.", "reference": "since we're calling the file .rspec-local, I think we should rename local_options to project_options and use local_options for .rspec-local - WDYT?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. The `connection_config.merge(adapter: connection_config[:http_adapter])` is a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. The `connection_config.merge(adapter: connection_config[:http_adapter])` is a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. The `connection_config.merge(adapter: connection_config[:http_adapter])` is a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. The `connection_config.merge(adapter: connection_config[:http_adapter])` is a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. The `connection_config.merge(adapter: connection_config[:http_adapter])` is a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. The `connection_config.merge(adapter: connection_config[:http_adapter])` is a bad idea. It's not clear", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. The `connection_config.merge(adapter: connection_config[:http_adapter])` doesn't make sense.", "reference": "Will we want to refactor this when we drop rsolr 1.x support?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate function for this.", "reference": "should this really be multiple IPs?" }, { @@ -7883,23 +7883,23 @@ "reference": "Hmm, is that partial used in multiple places? Maybe we can just move that file in here." }, { - "prediction": "I think we should remove the `go:generate mockgen.sh` line.", + "prediction": "I'm not sure what you mean by \"go:generate mockgen.sh\"", "reference": "Should be 2014-2016" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to get the type of a string that starts and ends with a double quote. I'm not sure what you're trying to do here. I think you're trying to get the type of a string that starts and ends with a double quote. I'm not sure what you're trying to do here. I think you're trying to get the type of a string that starts and ends with a double quote. I'm not sure what you're trying to do here. I think you're trying to get the type of a string that starts and ends with a double quote. I'm not sure what you're trying to do here. I think you're trying to get the type of a string that starts and ends with a double quote. I'm not sure what you're trying to do here. I think you're trying to get the type of a string that starts and ends with a double quote. I'm not sure what you're trying to do here. I think you're trying to get the type of a string that starts and ends with a double quote. I'm not sure what you're trying to do here. I think you're trying to get the type of a string that", + "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.", "reference": "Looks like my fault for sure in trying to handle international inputs regardless of locale. I think the correct fix is actually to get rid of TrySplitColumns and use ParseDsvFields instead. It is what gets used in the end, and it already has logic for dealing with quoted fields." }, { - "prediction": "I think we can remove the `client.close()` call here as well.", + "prediction": "I think it's better to close the cursors first, and then close the client.", "reference": "similarly here, are the these cursors not being closed when the client is closed?" }, { - "prediction": "I don't think we need to change the `Policy` type here. We can just use the `Policy` type from the `policy` package.", + "prediction": "I don't think this is necessary. We can just use `make(map[string]func(string) Policy)` instead of `make(map[string]func() Policy)`.", "reference": "Or maybe `func(args ...string) Policy` to make it dynamic in case of any future policy that may require more than one args." }, { - "prediction": "I think this should be `session` instead of `sessionInfo`?", + "prediction": "I think this should be `if err != nil { ... }` instead of `if err != nil { log.CWarningf(ctx, \"Failed to enable existing journals: %v\", err) }`.", "reference": "Should this happen even if the above failed?" }, { @@ -7915,15 +7915,15 @@ "reference": "Is it still important to have `speakEntry` here? It is checked before this value `containerContainsText` is used in the \"General\" section." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think it's a good idea to export `JAVA_HOME` in Travis. It's not a good idea to export `JAVA_HOME` in Travis. It's not a good idea to export `JAVA_HOME` in Travis. It's not a good idea to export `JAVA_HOME` in Travis. It's not a good idea to export `JAVA_HOME` in Travis. It's not a good idea to export `JAVA_HOME` in Travis. It's not a good idea to export `JAVA_HOME` in Travis. It's not a good idea to export `JAVA_HOME` in Travis. It's not a good idea to export `JAVA_HOME` in Travis. It's not a good idea to export `JAVA_HOME` in Travis. It's not a good idea to export `JAVA_HOME` in Travis. It's not a good idea to export `JAVA_HOME` in Travis. It's not a good idea to export `JAVA_HOME` in Travis. It's not a good idea to export `JAVA_HOME` in Travis. It's not a good idea to export `JAVA_HOME` in Travis. It's not a good idea to export `JAVA_HOME` in Travis. It", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to add the `JAVA_HOME` variable to the `PATH` environment variable, but I'm not sure if that's what you're trying to do here.", "reference": "It is `$JAVA_HOME/bin`, not `$JAVA_HOME`, which should be added." }, { - "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to generate a random UUID, but you're not actually using the `generate_uuid` function. I'm not sure what you're trying to do here. It looks like you're trying to generate a random UUID, but you're not actually using the `generate_uuid` function. I'm not sure what you're trying to do here. It looks like you're trying to generate a random UUID, but you're not actually using the `generate_uuid` function. I'm not sure what you're trying to do here. It looks like you're trying to generate a random UUID, but you're not actually using the `generate_uuid` function. I'm not sure what you're trying to do here. It looks like you're trying to generate a random UUID, but you're not actually using the `generate_uuid` function. I'm not sure what you're trying to do here. It looks like you're trying to generate a random UUID, but you're not actually using the `generate_uuid` function. I'm not sure what you're trying to do here. It looks like you're trying to generate a random UUID, but you're not actually using the `generate_uuid", + "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to generate a random UUID, but you're not actually using the generated UUID in any way. I'm not sure what you're trying to do here. It looks like you're trying to generate a random UUID, but you're not actually using the generated UUID in any way. I'm not sure what you're trying to do here. It looks like you're trying to generate a random UUID, but you're not actually using the generated UUID in any way. I'm not sure what you're trying to do here. It looks like you're trying to generate a random UUID, but you're not actually using the generated UUID in any way. I'm not sure what you're trying to do here. It looks like you're trying to generate a random UUID, but you're not actually using the generated UUID in any way. I'm not sure what you're trying to do here. It looks like you're trying to generate a random UUID, but you're not actually using the generated UUID in any way. I'm not sure what you're trying to do here. It looks like you're trying to generate a random UUID, but you're not actually using the generated UUID in", "reference": "Should move this to within the `#else` block as it's only used there." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `ProductListPage` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `ProductListPage` class as well.", "reference": "is this a common rule to wait one extra second after ajax? I'm thinking about moving this extra wait into waitForAjax method." }, { @@ -7931,35 +7931,35 @@ "reference": "Maybe you can correct the typo \"if\" too :)" }, { - "prediction": "I'm not sure what you mean by \"if you have the UID for a user and don't require Identify to\"", + "prediction": "I'm not sure if this is a good idea, but I think we should be able to do this in the same way as `IdentifyForChat`.", "reference": "I'd prefer a name less chat-specific, since later on we could have other app types that want the same behavior. Maybe `IdentifyAndAllowTrackBreaks`?" }, { - "prediction": "I think this should be `PyMPIComm_Get` instead of `PyMPIComm_Get_ptr()`.", + "prediction": "I think this should be `if (PyMPIComm_Get(src.ptr()) == nullptr)` instead of `MPI_Comm *mpiCommPtr = PyMPIComm_Get(src.ptr());`", "reference": "I think I was involved in writing that caster, but I never fully understood the `import_mpi4py` thing. Why is importing mpi4py still necessary at that point? I would think if the user is passing a communicator from python code, they must already have imported mpi4py themselves, or does that not propagate through into the wrapping layer?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to check the status code of the response, and if it's not 200, then it's not an error.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `httpCache` struct.", "reference": "This seems like a more interesting change. Maybe we should re-name the PR" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to add a new feature to the `TransportConnection` interface, but I don't think that's what you're trying to do here. I think you're trying to add a new feature to the `TransportConnection` interface, but I don't think that's what you're trying to do here. I think you're trying to add a new feature to the `TransportConnection` interface, but I don't think that's what you're trying to do here. I think you're trying to add a new feature to the `TransportConnection` interface, but I don't think that's what you're trying to do here. I think you're trying to add a new feature to the `TransportConnection` interface, but I don't think that's what you're trying to do here. I think you're trying to add a new feature to the `TransportConnection` interface, but I don't think that's what you're trying to do here. I think you're trying to add a new feature to the `TransportConnection` interface, but I don't think that's what you're trying to do here. I think you're trying to add a new feature to the `", "reference": "Nit: implement the methods for these interfaces explicitly in this file for consistency. It can be passthrough." }, { - "prediction": "I think we should remove the `isMap` and `isArray` fields.", + "prediction": "I think this should be `isMap` instead of `isMap(false)`.", "reference": "Not directly related to your PR, but I think here we should create a Type enum (MAP, ARRAY, PRIMITIVE) instead of having 3 flags." }, { - "prediction": "I'm not sure what you mean by \"NABoolean isFirstBatch = false\"", + "prediction": "I'm not sure what you mean by \"NABoolean\" here.", "reference": "Do you want this to be a stack variable? The work method might return at any time (example: when the parent queue fills up) and then get called again, which would cause this variable to become false again. I'm wondering if this variable should be a member instead?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to get the schema edge key for a given space and edge type, but I'm not sure what you're trying to do with the `schemaEdgesPrefix` function.", + "prediction": "I'm not sure if this is a good place to put this, but I think we should move it to `MetaServiceUtils.cpp` instead of `MetaServiceUtils.h`.", "reference": "You could reserve a const space to save the extra computation." }, { - "prediction": "I think we can remove the redundant segment here.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `System.IO.Path.Combine` method to combine the two paths.", "reference": "Did you consider adding rooted paths like `C:\\ProgramData` and paths with flipped separators?" }, { @@ -7967,19 +7967,19 @@ "reference": "does this line cause a panic if it is above the if condition ?" }, { - "prediction": "Shouldn't this be `public enum LibraryDetailsPanels { ... }`?", + "prediction": "I think this should be `public enum LibraryDetailsPanels { ShortcutDetails, ShortcutCreation, ShortcutEditing, Closed; }`", "reference": "Maybe `LibraryDetailsPanelType` would be clearer." }, { - "prediction": "I'm not sure if this is a good idea, but I think it's better to have `create_dummyattrs` be a static function, and then call it from `create_rundir` and `create_broker_rundir` instead of having it be a member function of `runlevel_t`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a `create_dummyattrs` function that takes a `flux_t *h` and a `uint32_t rank` and a `uint32_t size` and returns a `flux_t *h` and a `uint32_t rank` and a `uint32_t size`.", "reference": "minor nit - add \"persist-filesystem\" and \"persist-directory\" into commit message, as its something people may search on (maybe applies to a few other commit messages)" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `queue_flags` in `CheckStageMaskQueueCompatibility` to make sure that `queue_flags` is not `VK_QUEUE_GRAPHICS_BIT` or `VK_QUEUE_COMPUTE_BIT` or `VK_QUEUE_TRANSFER_BIT`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `queue_flags == VK_QUEUE_GRAPHICS_BIT` and `queue_flags == VK_QUEUE_COMPUTE_BIT` and `queue_flags == VK_QUEUE_TRANSFER_BIT` in `CheckStageMaskQueueCompatibility`.", "reference": "I verified offline with @jeremyg-lunarg this should be removed." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to log the name of the workflow and the default timeout.", "reference": "This should be removed? If not, typo in incldued_wf" }, { @@ -7987,31 +7987,31 @@ "reference": "Sorry for the delay on this! It looks like Circle CI isn't running tests on some of the PRs, but this doesn't look like it would work I might be missing something, but are the tests all passing locally?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think we need to change anything here.", + "prediction": "I'm not sure what you're trying to do with this field, but I think we should remove it. It's not used anywhere in the code.", "reference": "Do you think the godoc should mention that all delimiters will be suffixed with `/`?" }, { - "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to check if the URL starts with \"data:\". If it does, then it's private, and we should redirect to the private browsing URI.", "reference": "what if I want to load my own, a different, data URI in Private Browsing mode? I do this often on desktop (e.g., `data:text/html,×`). admittedly, I wouldn't expect this to be done by a non-developer, but this will certainly cause a minor bug." }, { - "prediction": "I don't think this is necessary. The `deleteManifests` field is not used in the `Builder` class. It's only used in the `DeleteFileIndex` class. So I think we can remove it.", + "prediction": "I don't think we need to add `minSequenceNumber` to `DeleteFileIndex.Builder`.", "reference": "I remember the sequence number 0 is kept for the data files for iceberg v1, so in theory the sequence number from delete files should start from 1. So setting it to 0 as the default value sounds correct." }, { - "prediction": "I'm not sure if this is a good idea or not, but I think it's better to have a separate method for this.", + "prediction": "I think this should be `iv.state` instead of `iv.state_id`?", "reference": "For all these MYSQL queries unsigned is required. I have tested again and without unsigned these queries are failing." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I don't think this is necessary. We can just use `stateUtils.defaultState` instead.", "reference": "Are there tests for this? What happens when you get to limit?" }, { - "prediction": "I think this should be `data['config']['transport']` instead of `data['config']['transport'] = 'local'`", + "prediction": "I think this should be `if target.name == 'localhost'` instead of `if target.name == 'localhost' && data['config']['transport'] == 'local'`", "reference": "Whole thing could be collapsed to `data['config']['transport'] ||= 'local' if target.name == 'localhost'`." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to bind to the service in the `bindServiceAndGetSignKeyId` method.", + "prediction": "I don't think we need to bind to the service here.", "reference": "maybe throw in `&& mServiceConnection.isBound()`, there are cases where the connection might die" }, { @@ -8023,7 +8023,7 @@ "reference": "I don't understand this change" }, { - "prediction": "I'm not sure what you mean by \"Invalid Public key\". It's not a public key, it's a private key. The public key is used to encrypt the private key, and the private key is used to decrypt the public key. If the public key is invalid, then the private key is invalid, and vice versa.", + "prediction": "I'm not sure what you mean by \"Invalid Public key\". Is it because the public key is invalid?", "reference": "Let's allow translators for this string to be translated: `self.show_warning(_('Invalid Public key'))`" }, { @@ -8031,15 +8031,15 @@ "reference": "This needs to work with `role=form` too." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to update the preview for the output connection.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to call `updatePreviews` in the `handleDragFree_` method.", "reference": "This should be before the if on line 1028, which should turn into an else if" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a new ClusterNetworkPolicy, but you don't have a ClusterNetworkPolicy in your spec.", + "prediction": "I think we can remove the `if b.Spec.Ingress == nil` here.", "reference": "Not really introduced by this PR, but I don't recall why these have to be pointers, while `PodSelector` / `NSSelector` do not. Do you know the reason?" }, { - "prediction": "I think we can remove the `if sample > ackDelay { ... }` check.", + "prediction": "I think this should be `if sample > ackDelay { ... }` instead of `if sample > r.minRTT { ... }`", "reference": "Is there a reason why we are ignoring the ackDelay if it would result in a value smaller than the min? Why not `max(sample - ackDelay, minRTT)`?" }, { @@ -8047,35 +8047,35 @@ "reference": "Here's an example of how the files in the `NotYetGenerated` directory drifted out of sync from the generated files. When we made the equality comparers internal, we neglected to fix this one." }, { - "prediction": "I think it's a good idea to make this a class method, so that it can be used like `GuidancePolicy.admin_index?` or `GuidancePolicy.index?`.", + "prediction": "I think this should be `user.can_modify_guidance? && guidance.in_group_belonging_to?(user.org_id)`", "reference": "nice. we should do this elsewhere too. We have a lot of repeated stuff in the policies" }, { - "prediction": "I think this is a duplicate of #1188.", + "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a separate test for this.", "reference": "Small formatting thing, but can you remove the space before the semicolon?" }, { - "prediction": "I'm not sure what you're trying to do here. The `InnerLoopCount * _writeLenght` should be `InnerLoopCount * _writeLenght + 1` or `InnerLoopCount * _writeLenght - 1` depending on how you want to handle the case where `_writeLenght` is 0.", + "prediction": "I'm not sure what you mean by `long remaining = InnerLoopCount * _writeLenght;`. I think you meant `int remaining = InnerLoopCount * _writeLenght;`", "reference": "Not new, but nit: _writeLeng*th*." }, { - "prediction": "I'm not sure what you're trying to do here, but I think it's a bad idea to use `asrt.New(t)` in this case.", + "prediction": "I don't think we need to test `CheckDockerCompose` here, since it's already covered by `TestComposeCmd`.", "reference": "Our habit is to go ahead and put a description line (or more) in front of every function, not just non-test or exported functions." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `require` here.", + "prediction": "I don't think we need to use `require` for this test.", "reference": "Remove this file from the PR" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a `validate` function to `Blockly.Variables.renameVariable` so that we don't have to call `validate` every time we call `renameVariable`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `validate` function in the `Blockly.Variables` class. This way, we don't have to call `validate` every time we want to rename a variable.", "reference": "I think that for cloud variables, the default value in the prompt should be the variable name without the cloud prefix; this is slightly different from the scratch 2.0 behavior, but I think would ultimately lead to less confusion. Proposing code changes below:" }, { - "prediction": "I'm not sure what you mean by \"libinput_device_config_tap_get_finger_count\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the libinput device config is valid before calling `libinput_device_config_tap_get_finger_count()`.", "reference": "I think I would rather fish this interface through than use it as the basis for heuristics." }, { - "prediction": "I'm not sure what you mean by `TargetType` in this context. It's not clear to me what you're trying to do with this property.", + "prediction": "I'm not sure if this is the right place to put this, but I think it would make sense to move it to the `TargetType` class.", "reference": "Probably not worth making this line-ending change, since it is the only change to this file." }, { @@ -8083,39 +8083,39 @@ "reference": "Is this the correct place for this assert? Does this routine rely on it being 64, or was this only for testing?" }, { - "prediction": "I'm not sure what you're trying to achieve here. I think you're trying to get the GPU info, but I don't think that's what you're trying to do here. I'm not sure what you're trying to achieve here. I think you're trying to get the GPU info, but I don't think that's what you're trying to do here. I'm not sure what you're trying to achieve here. I think you're trying to get the GPU info, but I don't think that's what you're trying to do here. I'm not sure what you're trying to achieve here. I think you're trying to get the GPU info, but I don't think that's what you're trying to do here. I'm not sure what you're trying to achieve here. I think you're trying to get the GPU info, but I don't think that's what you're trying to do here. I'm not sure what you're trying to achieve here. I think you're trying to get the GPU info, but I don't think that's what you're trying to do here. I'm not sure what you're trying to achieve here. I think you're trying to get the GPU info, but I don't think", + "prediction": "I'm not sure what you mean by this, but I think it's a good idea to have a separate package for this.", "reference": "No pb please" }, { - "prediction": "I'm not sure if this is the best way to do this, but it seems to work for me.", + "prediction": "I'm not sure if this is the best way to go about this, but I think it's a good idea to add a foreign key to the `changesets_subscribers` table that references the `changeset_id` column in the `changesets` table. This way, we can ensure that the `subscriber_id` and `changeset_id` columns in the `changesets_subscribers` table refer to the correct `subscriber_id` and `changeset_id` columns in the `changesets` table. This way, we can ensure that the `subscriber_id` and `changeset_id` columns in the `changesets_subscribers` table refer to the correct `subscriber_id` and `changeset_id` columns in the `changesets` table. This way, we can ensure that the `subscriber_id` and `changeset_id` columns in the `changesets_subscribers` table refer to the correct `subscriber_id` and `changeset_id` columns in the `changesets` table. This way, we can ensure that the `subscriber_id` and `changeset_id` columns in the `changesets_subscribers` table refer to the correct `subscriber_id` and `changeset_id` columns in the `changesets`", "reference": "We need to add indexes here on both `subscriber_id` and `changeset_id` or things will quickly collapse as we build up subscribers ;-) What I would suggest is a unique index on `[:subscriber_id, :changeset_id]` which will also make duplicate entries impossible, and an ordinary index on `[:changeset_id]` for finding the subscribers to a changeset." }, { - "prediction": "I think this should be `client.PostMessage(channel, slack.MsgOptionText(message, true))` instead of `client.PostMessage(channel, slack.MsgOptionText(message, false))`", + "prediction": "I think this should be `client.PostMessage(channel, slack.MsgOptionText(message, true))`", "reference": "use the context versions of everything, e.g. `PostMessageContext` and thread it through the functions. will save you a bunch of refactoring trouble later on." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. The `__implements__` attribute is only set if the object is an instance of a class, so it's not clear what you're trying to achieve with this change.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it would be better to make the `implements` method return `bool` and not `Union[Type[\"Interface\"], Tuple[Type[\"Interface\"], ...]]`.", "reference": "\"not to be used elsewhere other than\"" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. It's a bit of a hack, but I think it's the best way to do this.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to make this a method in `SparkAppenderFactory` instead of a constructor.", "reference": "Thanks for the contribution, @coolderli ! I also think the newPosDeleteWriter need the properties setting ..." }, { - "prediction": "I think this should be `add_index :subscriptions, [:user_id, :team_id, :plan_id, :plan_type]`", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate migration for this.", "reference": "These additions seem unrelated to this change?" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `TableProperties` class, since it's a property of the `Table` class.", + "prediction": "I don't think we need to add this to the `TableProperties` class. We can just add it to the `IcebergProperties` class.", "reference": "Could we move this to a class for Hadoop configuration properties, like `org.apache.iceberg.hadoop.ConfigProperties`?" }, { - "prediction": "I think it's better to use `if err != nil { ... }` instead of `if !manageFlag { ... }`", + "prediction": "I think this should be `if err != nil { r.Log.Error(err, \"failed to archive experiment\") }` instead of `if err != nil { r.Log.Error(err, \"failed to archive experiment\") } else { r.Log.Error(err, \"failed to archive experiment\") }`", "reference": "The related statements should also be deleted." }, { - "prediction": "I think it's better to use `self.build_list_params(params, policies, 'PolicyNames.member.%d')` instead of `self.build_list_params(params, policies, 'PolicyNames.member.%d')`", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `ELBConnection` class as well.", "reference": "Shouldn't this line be removed?" }, { @@ -8123,7 +8123,7 @@ "reference": "Just move this into `const.py`. It already has similar stuff. Also, make it uppercase since it's a const." }, { - "prediction": "I think this should be `newMode = PasscodeMode.Check;` instead of `newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode.Check; newMode = PasscodeMode", + "prediction": "I don't think this is necessary.", "reference": "Issue is that `currentMode = newMode;` is called at the end of the method. Passcode screen will come up, but since the activity thinks current mode is biometric check we don't check passcode when submitted." }, { @@ -8131,11 +8131,11 @@ "reference": "Need change it back?" }, { - "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to hardcode the secret_key_base in the config file. I think it's a good idea to hardcode the secret_key_base in the config file, but I'm not sure if it's a good idea to hardcode the secret_key_base in the config file. I think it's a good idea to hardcode the secret_key_base in the config file, but I'm not sure if it's a good idea to hardcode the secret_key_base in the config file. I think it's a good idea to hardcode the secret_key_base in the config file, but I'm not sure if it's a good idea to hardcode the secret_key_base in the config file. I think it's a good idea to hardcode the secret_key_base in the config file, but I'm not sure if it's a good idea to hardcode the secret_key_base in the config file. I think it's a good idea to hardcode the secret_key_base in the config file, but I'm not sure if it's a good idea to hardcode the secret_key_base in the config file. I think it's a good idea to hardcode the secret", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate file for the secret key.", "reference": "Didn't we delete this file a while back because it isn't used but people think that it's a security vulnerability that it's checked in?" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `JsonExtensionMethods` instead of `JsonExtensions` in this case. `JsonExtensionMethods` is more flexible and allows you to extend the functionality of `JsonExtensions` without having to modify the `JsonExtensions` class itself.", + "prediction": "I'm not sure if this is the right place to add this extension method, but I think it's a good idea to add this extension method to the `JsonExtensions` class.", "reference": "nit: Looks like this can be removed now" }, { @@ -8147,15 +8147,15 @@ "reference": "Do you think it's worth erroring out? It's likely that this is a configuration error that the user might want to know about?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.", + "prediction": "I don't think this is a good idea. I think it's better to use `#` instead of `+1:`.", "reference": "I think the functional test should not change here, this is probably a test in itself :)" }, { - "prediction": "I don't think we need this. It's not used anywhere in the code.", + "prediction": "I don't think this is necessary. We can just use `bluemonday.UGCPolicy().AllowAttrs(\"class\").Matching(regexp.MustCompile(`[\\p{L}\\p{N}\\s\\-_',:\\[\\]!\\./\\\\\\(\\)&]*`)).OnElements(\"code\")`", "reference": "Why this to be a public function?" }, { - "prediction": "I'm not sure what you mean by `log: false` and `timing: false`", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `set` method for setting environment variables, and a `echo` method for printing them out.", "reference": "I think we can remove the timing for export env vars" }, { @@ -8163,15 +8163,15 @@ "reference": "wrong import grouping" }, { - "prediction": "I don't think this is necessary.", + "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to put it in the `onSharedPreferenceChanged` method, since it's called by the `onSharedPreferenceChanged` method of the `SharedPreferences.OnSharedPreferenceChangeListener` interface.", "reference": "There is a doubled semicolon ;)" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to include `openssl/md5.h` or `openssl/sha.h`.", + "prediction": "I'm not sure what you mean by this, but I don't think it's a good idea to use `#include `. The SHA-1 and SHA-256 functions are defined in `openssl/sha.h` and `openssl/sha256.h`, respectively. If you want to use SHA-256, you should use `#include `.", "reference": "I'm wondering why this isn't . Seems like one would have to copy the md5.h file into the source tree somewhere for this to compile cleanly. Maybe you meant to use angle brackets instead of quotes?" }, { - "prediction": "I'm not sure what you mean by \"at least one element visible\". Is it possible to have more than one element on the page?", + "prediction": "I think it's better to use `__call__` here.", "reference": "shouldn't **call** return a boolean?" }, { @@ -8179,31 +8179,31 @@ "reference": "We don't need to cast to client here. (well, from spell gem not AA etc) We should also make sure the charm is a casted spell before calling SendSpellBarEnable." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should go in the `inventory` table.", "reference": "This is not an `id`. This should either be `invocation_time` or `invocated_at` to be consistent with what we are using elsewhere, and also to better rerflect the column's DateTime type. Also, within the context of this table, there is no idea of what `invocation` is. I know that `scanner` may not be future-proof, but we need to find something more descriptive. Perhaps one possibility is to call this `audit_time`." }, { - "prediction": "I don't think we need to change this function.", + "prediction": "I don't think we need to change this.", "reference": "should the 'Receiver' be the clawback address in case of clawback transaction?" }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to achieve with this command. It's not clear to me what you're trying to achieve with this command. It's not clear to me what you're trying to achieve with this command. It's not clear to me what you're trying to achieve with this command. It's not clear to me what you're trying to achieve with this command. It's not clear to me what you're trying to achieve with this command. It's not clear to me what you're trying to achieve with this command. It's not clear to me what you're trying to achieve with this command. It's not clear to me what you're trying to achieve with this command. It's not clear to me what you're trying to achieve with this command. It's not clear to me what you're trying to achieve with this command. It's not clear to me what you're trying to achieve with this command. It's not clear to me what you're trying to achieve with this command. It's not clear to me what you're trying to achieve with this command. It's not clear to me what you're trying to achieve with this command. It's not clear to me", + "prediction": "I don't think we need to use the `controllerStatusOk` and `volumeStatusOk` here. We can just use the `controllerStatus` and `volumeStatus` here.", "reference": "@ashishranjan738 -- Where are these consts used? in which pkg?" }, { - "prediction": "I'm not sure what you mean by `:toctree: pythonapi/`", + "prediction": "I don't think we need to add `pythonapi/` to the `autosummary_generate` list.", "reference": "The only change I would suggest is moving these lines back below the `templates_path` variable to keep the diffs smaller." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to make this a part of the `folderBranchOps` struct, so that we don't have to do this every time we want to update the `folderBranchOps` struct.", + "prediction": "I think we can remove the `changes.Info = info` line, since it's not used anymore.", "reference": "Having it above kept the block info in the cached changes, which could end up confusing things quite a bit." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way", + "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to use the `execute_task` method to do this.", "reference": "If the execute_task returns an `ExecutionResult`, the passing of a block would be unnecessary. Instead, the `ExecutionResult` could be presented to the user in some standardized way (iterating over the result of each node, etc.)." }, { - "prediction": "I think we should use `make(chan struct{}, 1)` instead of `make(chan struct{})` here.", + "prediction": "I think this should be `if err := c.bridge.Connect(maxRetryForOFSwitch, make(chan struct{})); err != nil {`", "reference": "Not sure why we make a new channel here. If we don't use this channel, how about creating it inside the `Connect`?" }, { @@ -8211,51 +8211,51 @@ "reference": "There are two question here: 1. If you only modify lastLogId, but the `iter` is not modified, I really don't know whether we can succeed. 2. We will check the if the term has changed in `replicateLogs` (if rollback really happen, the term must have been updated), so I really doubt whether the problem should be fixed in this way. Or you could describe it in more details." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `FormFlow` class as well. I think it would be a good idea to do this in the `FormFlow` class as well. I think it would be a good idea to do this in the `FormFlow` class as well. I think it would be a good idea to do this in the `FormFlow` class as well. I think it would be a good idea to do this in the `FormFlow` class as well. I think it would be a good idea to do this in the `FormFlow` class as well. I think it would be a good idea to do this in the `FormFlow` class as well. I think it would be a good idea to do this in the `FormFlow` class as well. I think it would be a good idea to do this in the `FormFlow` class as well. I think it would be a good idea to do this in the `FormFlow` class as well. I think it would be a good idea to do this in the `FormFlow` class as well. I think it would be a good idea to do", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `FormFlow` class as well. I think it would be a good idea to do this in the `FormFlow` class as well. I think it would be a good idea to do this in the `FormFlow` class as well. I think it would be a good idea to do this in the `FormFlow` class as well. I think it would be a good idea to do this in the `FormFlow` class as well. I think it would be a good idea to do this in the `FormFlow` class as well. I think it would be a good idea to do this in the `FormFlow` class as well. I think it would be a good idea to do this in the `FormFlow` class as well. I think it would be a good idea to do this in the `FormFlow` class as well. I think it would be a good idea to do this in the `FormFlow` class as well. I think it would be a good idea to do this in the `FormFlow` class as well. I think it would be a good idea to do this in", "reference": "Hello @jDolba, I have reviewed your PR and I found one problem. `$step->getFormType()` can return `FormTypeInterface`. You cannot use interface as key for an array. Can you find some better way to fix this? Thank you." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I don't think we need to do this for EL6, right?", "reference": "i was confused by keyword \"inventory\" here. my understanding is this starts the osconfig-agent which covers inventory lookup and package-management(correct me if i am wrong)." }, { - "prediction": "I think we can remove `TIMEOUTS` and `IMPLICIT_TIMEOUT` from the `CapabilityType` interface.", + "prediction": "I don't think we need to add this to the `CapabilityType` interface.", "reference": "These are really meant to be the keys in the capabilities, not the keys of values within the capabilities" }, { - "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `setupScratch` and `teardown` in the same file. I'm not sure if it's a good idea to use `setupScratch` and `teardown` in the same file. I'm not sure if it's a good idea to use `setupScratch` and `teardown` in the same file. I'm not sure if it's a good idea to use `setupScratch` and `teardown` in the same file. I'm not sure if it's a good idea to use `setupScratch` and `teardown` in the same file. I'm not sure if it's a good idea to use `setupScratch` and `teardown` in the same file. I'm not sure if it's a good idea to use `setupScratch` and `teardown` in the same file. I'm not sure if it's a good idea to use `setupScratch` and `teardown` in the same file. I'm not sure if it's a good idea to use `setupScratch` and `teardown` in the same file. I", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to move this to `setupScratch` and `teardown` so that it can be used in other tests.", "reference": "This breaks tests on IE because this will import an `esm` bundle. For that reason `sinon` is available as a global in our test suite and never imported. The global is aliased to the proper `es5` file." }, { - "prediction": "I think this should be `maxRTOTimeout` instead of `maxRTOTime`", + "prediction": "I think it's better to use `time.Duration` for `minRTOTimeout` and `maxRTOTimeout` instead of `time.Millisecond` and `time.Second`.", "reference": "Maybe move all the Loss Recovery constants to a separate file." }, { - "prediction": "I'm not sure what you mean by \"mode\" in this context. It's not clear to me what you're trying to do with this field.", + "prediction": "I don't think we need to change the `diskName` field.", "reference": "this field is added so that we can find disk name by device name from attachments" }, { - "prediction": "I don't think this should be here. It's not part of the K9 API.", + "prediction": "I don't think this is needed anymore.", "reference": "Unnecessary new line" }, { - "prediction": "I think we can remove the `if !configs.IsNamespaceSupported(nsType) { ... }` block.", + "prediction": "I think it's better to use `if _, ok := state.NamespacePaths[nsType]; ok` instead of `if !configs.IsNamespaceSupported(nsType) { ... }`", "reference": "First determine if the namespace already exists, so it's clearer that it's handling namespaces that aren't included in the `c.config.Namespaces`" }, { - "prediction": "I don't think we need to use `render` here. We can just use `<%= render %>` in this case.", + "prediction": "I don't think we need to use `render` here. We can just use `<%= render %>` directly.", "reference": "What changed in the styles that means we don't need this?" }, { - "prediction": "I think this should be `GetFrameworkDependencies` instead of `GetFrameworkDependenciesSection`?", + "prediction": "I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way", "reference": "This pattern should be applied to the other instance where NewtonsoftEscapeJProperty is used and you can remove the NewtonsoftEscapeJProperty method." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a warning to the `__init__` method. It's not clear to me if this is the right place to do this, but I think it would be a good idea to add a warning to the `__init__` method. It's not clear to me if this is the right place to do this, but I think it would be a good idea to add a warning to the `__init__` method. It's not clear to me if this is the right place to do this, but I think it would be a good idea to add a warning to the `__init__` method. It's not clear to me if this is the right place to do this, but I think it would be a good idea to add a warning to the `__init__` method. It's not clear to me if this is the right place to do this, but I think it would be a good idea to add a warning to the `__init__` method. It's not clear to me if this is the right place to do this, but I think it would be a good idea to add a warning to", + "prediction": "I think we should remove the `edges` parameter from the `__init__` method.", "reference": "Something to mention in the next changelog/release notes. It will be good to get histogram working consistently with everything else." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to add a `kubernetes.io/hostname` value to the `values.yaml` file. I'm not sure what you're trying to do here, but it looks like you're trying to add a `kubernetes.io/hostname` value to the `values.yaml` file. I'm not sure what you're trying to do here, but it looks like you're trying to add a `kubernetes.io/hostname` value to the `values.yaml` file. I'm not sure what you're trying to do here, but it looks like you're trying to add a `kubernetes.io/hostname` value to the `values.yaml` file. I'm not sure what you're trying to do here, but it looks like you're trying to add a `kubernetes.io/hostname` value to the `values.yaml` file. I'm not sure what you're trying to do here, but it looks like you're trying to add a `kubernetes.io/hostname` value to the `values.yaml` file. I'm not sure what you're trying to do here, but it looks like you're trying to add a `kubernetes.io/hostname", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to add a `kubernetes.io/hostname` value to the `values.yaml` file, but you're also trying to add a `kubernetes.io/namespace` value to the `values.yaml` file. I'm not sure what you're trying to do here, but it looks like you're trying to add a `kubernetes.io/hostname` value to the `values.yaml` file, but you're also trying to add a `kubernetes.io/namespace` value to the `values.yaml` file. I'm not sure what you're trying to do here, but it looks like you're trying to add a `kubernetes.io/hostname` value to the `values.yaml` file, but you're also trying to add a `kubernetes.io/namespace` value to the `values.yaml` file. I'm not sure what you're trying to do here, but it looks like you're trying to add a `kubernetes.io/hostname` value to the `values.yaml` file, but you're also trying to add a `kubernetes.io/namespace` value to the `values.yaml` file. I'm not sure what you're trying", "reference": "What does this contain? Is it PVC namespace or is it openebs?" }, { @@ -8263,23 +8263,23 @@ "reference": "Design note: Using local concrete data types on a feature abstraction makes it hard to generalize / replace. This is tolerable so long as this remains a kestrel exclusive feature, but we'd need a different design if this were ever moved to HttpAbstractions." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `LGBM_BoosterGetEvalNames` as well.", + "prediction": "I'm not sure if this is a good place to put this, but I think we should move it to `LGBM_BoosterGetEvalNames_R` as well.", "reference": "this will break R package, you should update the R files accordingly. BTW, the call state should be in the last argument." }, { - "prediction": "I don't think this is necessary. We can just use `MediaProviderInterface::getFormatNamesByContext($media->getContext())` instead.", + "prediction": "I don't think we need to do this.", "reference": "Shouldn't we throw an exception if the context is null instead ?" }, { - "prediction": "I'm not sure if this is a good idea or not, but I think it would be better to have a separate `DockerComposeVersionConstraint` and `DockerVersionConstraint` for the `DockerCompose` and `Docker` versions, respectively.", + "prediction": "I'm not sure if this is a good idea or not, but I think it's better to use `DockerComposeVersionConstraint` instead of `DockerVersionConstraint`.", "reference": "These should both be const, not var right?" }, { - "prediction": "I think this should be `build_from_cfg` instead of `build_from_cfg_cfg`.", + "prediction": "I think this should be `build_from_cfg` instead of `build_from_cfg_cfg`", "reference": "Rename the directory, match_costers -> match_costs" }, { - "prediction": "I'm not sure what you mean by \"Total-Records\" in this case. Is it the total number of records in the collection, or the number of records that can be deleted in the collection?", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the best way to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the best way to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the best way to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the best way to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the best way to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the best way to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the best way to do this, but I think it's a good idea to have a separate test for this. It's", "reference": "I don't think this should go in the model tests, since it is done in the resource. `PaginatedDeleteTest` seems more appropriate" }, { @@ -8287,39 +8287,39 @@ "reference": "It would be better to just change RWD to throw IllegalStateException if you attempt to execute a command after quit (unless it's a second call to quit())" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this", + "prediction": "I'm not sure if this is the best way to do this, but I think it's the right way to do this.", "reference": "Could we move this to an example test to allow the compiler to help us ensure it stays up-to-date in the future?" }, { - "prediction": "I'm not sure what you mean by \"prompts the user for password if not specified\"", + "prediction": "I don't think this is a good idea. I think it's better to use `allow_any_instance_of` instead of `allow(STDIN).to receive(:noecho)` and `allow(STDOUT).to receive(:print).with('Please enter your password: ')` and `allow(STDOUT).to receive(:puts)`. I think it's better to use `allow_any_instance_of` instead of `allow(STDIN).to receive(:noecho)` and `allow(STDOUT).to receive(:print).with('Please enter your password: ')`. I think it's better to use `allow_any_instance_of` instead of `allow(STDIN).to receive(:noecho)` and `allow(STDOUT).to receive(:print).with('Please enter your password: ')`. I think it's better to use `allow_any_instance_of` instead of `allow(STDIN).to receive(:noecho)` and `allow(STDOUT).to receive(:print).with('Please enter your password: ')`. I think it's better to use `allow_any_instance_of` instead of `allow(STDIN).to receive(:noecho)` and `allow(STDOUT).to receive(:print).with('Please enter your password: ')`. I think it's", "reference": "Maybe we could update these to use $future and then check on stderr? that way when we deprecate stdout we can not have to delete tests." }, { - "prediction": "I'm not sure what you mean by `MinAllowedMaxFrameSize` and `_maxFrameSize`. I think you meant `MaxAllowedMaxFrameSize` and `_maxFrameSize`.", + "prediction": "I think this should be `MinAllowedMaxFrameSize` instead of `MinAllowedMaxFrameSize - HeaderLength`", "reference": "Remove this since it always has to be set afterwards." }, { - "prediction": "I'm not sure I understand what you're trying to do with this test case. It seems like you're trying to write a multiblock file that is unmerged and has conflicts, but you're not using the `blockChangeSize` parameter. Is this the case?", + "prediction": "I'm not sure what you mean by `as(alice, ...)`", "reference": "These two tests were causing us to use too many goroutines with `-race` using the default block change size, I think due to prefetching." }, { - "prediction": "I think this should be `self.reader.fetch` instead of `self.reader.fetch(startTime, endTime)`.", + "prediction": "I think this should be `self.reader.fetch(startTime, endTime, now=None, requestContext=None)` instead of `self.reader.fetch(startTime, endTime)`", "reference": "Is that `try..except` block really needed? I mean, when it could fail?" }, { - "prediction": "I'm not sure what you mean by \"suspense.test.js\"", + "prediction": "I don't think you need to add `suspense.test.js` to the list of watched files.", "reference": "If you only want to run a specific group of tests you can always use `.only` like `it.only()` or `describe.only()`. It may not speed up the globbing process as much as this change here :)" }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good idea to add a `default_batch_size` parameter to the `Lambdas` class. This would allow us to specify a default value for the batch size when creating a new Lambda function. This would make it easier to handle cases where the batch size is not specified when creating a new Lambda function.", + "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good idea to have a `default_batch_size` parameter that defaults to 10000.", "reference": "nit: I'd probably rename this to `BATCH_SIZE_RANGES`, to use a slightly more descriptive name." }, { - "prediction": "I'm not sure if this is a good idea, but I'm not sure if we want to do this.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `MenuEntrySwapperPlugin` class as well.", "reference": "aren't these the wrong way around?" }, { - "prediction": "I don't think this is needed anymore. The `getCoreConfigService` method is now in `ConfigSetService` and the `getHostName` method is now in `CoreContainer`.", + "prediction": "I don't think this is needed anymore. The `getCoreConfigService` method is now in the `ConfigSetService` class.", "reference": "Lets call this getConfigSetService and maybe rename the field now (or later)" }, { @@ -8327,27 +8327,27 @@ "reference": "Could / should we make these constants and give them a type?" }, { - "prediction": "I'm not sure what the point of this is, but I think it should be `platformUnknown` instead of `unknown platform`.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `platformUnknown` value for the `platformUnknown` field.", "reference": "lets stick with lowercase for consistency." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a good idea to make it more clear what it does.", + "prediction": "I'm not sure what you mean by \"final state\" here. I think it's more accurate to say \"final state\" means that the ACME state is \"final\" in the sense that it has not changed since it was created.", "reference": "ordering of imports went wrong" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `TableScan` class.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `tableType` field in the `TableScan` class.", "reference": "I think these can all be .name() to get the value we are looking for" }, { - "prediction": "I'm not sure what you mean by \"too few arguments\" in this case. I think you meant \"too many arguments\" or \"too few arguments\".", + "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a separate test for `printOnlyString` and `printReturns1`.", "reference": "Is this a good place for these test cases?" }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. Is it possible that you're trying to get the value of a specific attribute from the response data? If so, why not just use `response_data[response_name]` instead of `response_data[response_name][attr_name]`?", + "prediction": "I don't think it's necessary to print the response data here.", "reference": "Did you mean to leave the print statement?" }, { - "prediction": "I think this should be 1000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "prediction": "I think it's better to use `BN` for `LOCKTIME_THRESHOLD_BN` instead of `BN(500000000)`.", "reference": "I would do `new BN(Interpreter.LOCKTIME_THRESHOLD)`" }, { @@ -8355,7 +8355,7 @@ "reference": "@ftomassetti I turned the tree walking algorithms into iterators so you don't have to visit every node when you only wanted a few, like for a `findFirst`." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a function that takes a `timertype` and returns a `reason` string, but I'm not sure what you're trying to do with the `reason` string. I think you're trying to create a function that takes a `timertype` and returns a `reason` string, but I'm not sure what you're trying to do with the `reason` string. I think you're trying to create a function that takes a `timertype` and returns a `reason` string, but I'm not sure what you're trying to do with the `reason` string. I think you're trying to create a function that takes a `timertype` and returns a `reason` string, but I'm not sure what you're trying to do with the `reason` string. I think you're trying to create a function that takes a `timertype` and returns a `reason` string, but I'm not sure what you're trying to do with the `reason` string. I think you're trying to create a function that takes a `timertype` and returns a `reason` string, but I'm not sure what you're trying to", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a new field to the `Timers` struct to store the reason for the timeout. This way, we don't have to do this in the `timerTypeToReason` function, and we don't have to do this in the `timerTypeFromThrift` function. We could also add a new field to the `Timers` struct to store the reason for the timeout, but I think it would be a good idea to add a new field to the `Timers` struct to store the reason for the timeout. This way, we don't have to do this in the `timerTypeToReason` function, and we don't have to do this in the `timerTypeFromThrift` function. We could also add a new field to the `Timers` struct to store the reason for the timeout, but I think it would be a good idea to add a new field to the `Timers` struct to store the reason for the timeout. This way, we don't have to do this in the `timerTypeToReason` function, and we don't have to do this in the `timerType", "reference": "Need to add type name here to be compatible with proto string representation." }, { @@ -8363,35 +8363,35 @@ "reference": "This is to let people know that the tooling is doing something during a build. Please leave." }, { - "prediction": "I think it's better to use `minimalist_record` instead of `MINIMALIST_RECORD`?", + "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to have a separate `MINIMALIST_GROUP` and `MINIMALIST_RECORD` in the `MINIMALIST_COLLECTION` dictionary.", "reference": "Why is the principal changing here?" }, { - "prediction": "I'm not sure what you mean by \"customize the URL opener\". I think you meant to say \"customize the URL format\".", + "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", "reference": "Naming nit: let's use `AZURE_STORAGE_` prefix for consistency with the other ones." }, { - "prediction": "I think this should be `this.uppy` instead of `this.uppy.opts`?", + "prediction": "I think this should be `uppy` instead of `uppy`.", "reference": "I'm a bit confused. We have an actual `ProgressBar` Uppy React wrapper component that we are testing. Why do we need a mock for it?" }, { - "prediction": "I think this should be `v1alpha1` instead of `v1alpha1alpha1`?", + "prediction": "I don't think this is necessary. We can just use `v1alpha1` instead of `v1alpha1alpha1`.", "reference": "can we use `github.com/pkg/errors`?" }, { - "prediction": "I'm not sure what you're trying to do with this, but I think it's a good idea to add a comment to explain what it does.", + "prediction": "I think this should be `if in.Nature() == semantic.Invalid {`", "reference": "I changed the name of the arguments here just to help make the code clearer." }, { - "prediction": "I'm not sure I understand what you're trying to do here. What is the purpose of the `allowing` keyword?", + "prediction": "I'm not sure I understand what you're trying to do here. Can you give an example of what you're trying to do?", "reference": "I think either 'avoiding calls to the function' or 'to avoid calling the function ...' would be read better." }, { - "prediction": "I think this should be `attachments_` instead of `shared_attachments_`.", + "prediction": "I'm not sure if this is a good idea or not, but I think it's better to use `std::vector` instead of `std::shared_ptr` in this case.", "reference": "@sfricke-samsung -- thanks. saves a few atomic ops which is always good :) The TODO is there to track that this object is storing *both* vectors of shared_ptr and plain pointers to the same data. The shared are to ensure scope, and the plain are for backwards compatibility with existing code that consumed a plain pointer vector (and some code that still does). That should be cleaned up." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to use the `Nethermind.Monitoring.Metrics` namespace, but you're not using it in your tests. I'm not sure what you're trying to achieve with this change. It seems like you're trying to use the `Nethermind.Monitoring.Metrics` namespace, but you're not using it in your tests. I'm not sure what you're trying to achieve with this change. It seems like you're trying to use the `Nethermind.Monitoring.Metrics` namespace, but you're not using it in your tests. I'm not sure what you're trying to achieve with this change. It seems like you're trying to use the `Nethermind.Monitoring.Metrics` namespace, but you're not using it in your tests. I'm not sure what you're trying to achieve with this change. It seems like you're trying to use the `Nethermind.Monitoring.Metrics` namespace, but you're not using it in your tests. I'm not sure what you're trying to achieve with this change. It seems like you're", + "prediction": "I think this should be `using Nethermind.Monitoring.Metrics;` instead of `using Nethermind.Monitoring.Config;`", "reference": "minor: typo (knowMetricsTypes -> knownMetricsTypes)" }, { @@ -8407,7 +8407,7 @@ "reference": "if remove `dt.skipLoad` - then this tests will run. You probably mean opposite?" }, { - "prediction": "I think this should be `end` instead of `Time.now - start`.", + "prediction": "I think this should be `end` instead of `Time.now - start`", "reference": "I feel like we do this in a lot of places should we move that out into its own PR?" }, { @@ -8415,47 +8415,47 @@ "reference": "Already asked you in Matrix, but I'll do it here again so it can be discussed publicly. Why?" }, { - "prediction": "I don't think it's necessary to remove it.", + "prediction": "I don't think we need to remove it.", "reference": "I think here should be a comma before remove, in all the cases" }, { - "prediction": "I'm not sure what you mean by \"stages\" in this context. Is it referring to the number of stages in the model?", + "prediction": "I don't think this is necessary. I think it's better to have `self.bbox_roi_extractor = context.bbox_roi_extractor` and `self.bbox_head = context.bbox_head` in the `__init__` method.", "reference": "Single quote is used by default in this project." }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason why you want to reconcile on spc?", + "prediction": "I think it's better to use `c.enqueueSpc(newSpc)` instead of `c.recorder.Event(spc, corev1.EventTypeWarning, \"Update\", message)`.", "reference": "S1023: redundant `return` statement (from `gosimple`)" }, { - "prediction": "I don't think we need to close the webhook.", + "prediction": "I'm not sure what you mean by \"Close\" in this context. It's not clear to me what you're trying to do here.", "reference": "`ctx` is unused in Close" }, { - "prediction": "I think this should be `HeurekaCategoryNotFoundException` instead of `HeurekaCategoryNotFoundException`", + "prediction": "Shouldn't this be `HeurekaCategoryNotFoundException` instead of `HeurekaCategoryNotFoundException`?", "reference": "I'm confused. This exception is thrown when `HeurekaCategory` is not found in database. But this exception extends Http exception. Why? What has database search common with http? If the only reason is that it is the same in the whole project, then fine. But then we have even bigger problem - we don't know how to use exceptions." }, { - "prediction": "I don't think this is a good idea. It's not clear to me why we would want to do this.", + "prediction": "I don't think this is a good idea. It's not clear to me why we would want to use `dcn` with `stage_with_dcn=(False, True, True, True)`. It's not clear to me why we would want to use `dcn` with `stage_with_dcn=(False, True, True, True)`. It's not clear to me why we would want to use `dcn` with `stage_with_dcn=(False, True, True, True)`. It's not clear to me why we would want to use `dcn` with `stage_with_dcn=(False, True, True, True)`. It's not clear to me why we would want to use `dcn` with `stage_with_dcn=(False, True, True, True)`. It's not clear to me why we would want to use `dcn` with `stage_with_dcn=(False, True, True, True)`. It's not clear to me why we would want to use `dcn` with `stage_with_dcn=(False, True, True, True)`. It's not clear to me why we would want to use `dcn` with `stage_with_dcn", "reference": "Is it necessary to add the suffix `on_head`, because it belongs to` bbox_head`?" }, { - "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `test x$with_modern_grub = xyes` here. I think it's better to use `test x$with_modern_grub = xyes && AC_DEFINE([WITH_MODERN_GRUB], 1, [Define if we have a GRUB version newer than 2.02])` instead.", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `AS_IF` here.", "reference": "Hmm, I wonder if this should just be e.g. `--with-grub-2.02` instead. (Not sure Autoconf supports periods in these switches.) Today's modern GRUB is tomorrow's ancient GRUB. :) Or maybe we should be specific about the feature this is enabling, which might be safer given that each distro carries so many patches. E.g. `--without-grub-efi-16-suffixes`?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you want to delete the instance. You want to delete the project and zone.", + "prediction": "I think it's better to use `if err != nil { ... }` instead of `if err != nil { return err; }`", "reference": "Add a GetSerialPortOutput method to Instance that way you don't need to access the client, also it makes the call cleaner as you don't have the odd i.Client and path.Base(i.Project), path.Base(i.Zone)" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate route for the `ios-on-rails` and `geocoding-on-rails` routes. This way, we can have a separate route for the `ios-on-rails` route and a separate route for the `geocoding-on-rails` route. This way, we can have a separate route for the `ios-on-rails` route and a separate route for the `geocoding-on-rails` route. This way, we can have a separate route for the `ios-on-rails` route and a separate route for the `geocoding-on-rails` route. This way, we can have a separate route for the `ios-on-rails` route and a separate route for the `geocoding-on-rails` route. This way, we can have a separate route for the `ios-on-rails` route and a separate route for the `geocoding-on-rails` route. This way, we can have a separate route for the `ios-on-rails` route and a separate route for the `geocoding-on-rails` route. This way, we can have", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate route for this. I think it would be a good idea to have a separate route for this. I think it would be a good idea to have a separate route for this. I think it would be a good idea to have a separate route for this. I think it would be a good idea to have a separate route for this. I think it would be a good idea to have a separate route for this. I think it would be a good idea to have a separate route for this. I think it would be a good idea to have a separate route for this. I think it would be a good idea to have a separate route for this. I think it would be a good idea to have a separate route for this. I think it would be a good idea to have a separate route for this. I think it would be a good idea to have a separate route for this. I think it would be a good idea to have a separate route for this. I think it would be a good idea to have a separate route for this. I think it would be a good idea to have a separate route for this. I think", "reference": "Line is too long. [104/80]" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `map[string]string` for this. It's not clear what you're trying to do here, but I don't think it's a good idea to use `map[string]string` for this. It's not clear what you're trying to do here, but I don't think it's a good idea to use `map[string]string` for this. It's not clear what you're trying to do here, but I don't think it's a good idea to use `map[string]string` for this. It's not clear what you're trying to do here, but I don't think it's a good idea to use `map[string]string` for this. It's not clear what you're trying to do here, but I don't think it's a good idea to use `map[string]string` for this. It's not clear what you're trying to do here, but I don't think it's a good idea to use `map[string]string` for this. It's not clear what you're trying to do here, but I don't think it's a good idea to use `map[string]string` for this.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `map[string]string` here. It's not clear to me what you're trying to do here.", "reference": "Since CD updates (assignment & power state) are now done in this controller..." }, { - "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to create a custom error that will be thrown when a document is validated multiple times in parallel. Is this what you're trying to do? If so, how do you want to handle this error? Do you want to log it, throw it, or do something else?", + "prediction": "I'm not sure I understand what you're trying to do here. Can you please provide some more context?", "reference": "Hmm I'd rather not support this option going forward - it seems like a one-off just to work around this particular issue. Would it be fine to just remove the `deepStackTrace` option? The rest of the PR looks great - I love the idea of switching to sets." }, { @@ -8463,55 +8463,55 @@ "reference": "on the one hand I like how little this is doing. On the other hand, `inbound_mail_parser` is doing most of the work here so maybe it's not as helpful as I originally thought" }, { - "prediction": "I think we can remove the `eprosima::fastrtps::rtps::RTPSWriterPublishMode::ASYNCHRONOUS_WRITER` in favor of `eprosima::fastrtps::rtps::RTPSWriterPublishMode::ASYNC_WRITER`.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to make sure that the writer is initialized before the reader is initialized.", "reference": "This line is too long" }, { - "prediction": "I'm not sure what you mean by \"this sets up the patching system to run in the background\"", + "prediction": "I'm not sure what you mean by \"this sets up the patching system to run in the background.\" I think you meant to say \"this sets up the patching system to run in the foreground.\"", "reference": "This isn't a fatal error, we don't want to crash just because we can't set configs, we have sane defaults set" }, { - "prediction": "I'm not sure what you're trying to achieve with this. It seems like you're trying to do a longest prefix match on the trie, but I'm not sure what you're trying to achieve with this.", + "prediction": "I'm not sure I understand what you're trying to do here. The `lookupPath` function returns a slice of `V4TrieEntry`s, but the `root.lookupPath` function returns a slice of `V4TrieEntry`s. What is the difference between the two?", "reference": "I wondered why `buffer` was passed into `LookupPath`. What is happening here? Is `buffer[:0]` equivalent to `[]V4TrieEntry{}`, and hence `buffer` isn't needed any more?" }, { - "prediction": "I think it's better to use `:target => \"_blank\"` instead of `:target => \"_self\"`.", + "prediction": "I think we should remove the `:target => \"_blank\"` from the `link_to` call.", "reference": "I don't really like the name of this file, especially the encoding of an implementation detail (the fact that it's a table) in the name. Can we just use `_message_body.html.erb` instead maybe?" }, { - "prediction": "I think we can remove the `EnableLogging` field, as it's not used anywhere.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `NetworkPolicyRule` struct.", "reference": "Feel better not to expose our internal implementation in API/CRD, so no need to mention agent here. Consider: EnableLogging indicates whether or not to generate logs when rules are matched. Default to false." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check here to make sure we're not trying to open a file that doesn't exist.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check here to make sure we don't try to open a file that doesn't exist.", "reference": "use `NebulaKeyUtilsV3::dataVersionValue()` to replace the literal value?" }, { - "prediction": "I think this should be `if path is not None:` instead of `if path is not None and os.path.exists(path):`", + "prediction": "I think this should be `if path is not None and os.path.exists(path):`", "reference": "No need for the `\\` here, inside parentheses whitespace is ignored by Python." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I think it's better to use `eqp31wM9il1n+guTNyxJd+FzVAH+hCZE5K+tCgVDdVFUlDEHHbS/wqb2PSIoouLV` instead of `eqp31wM9il1n+guTNyxJd+FzVAH+hCZE5K+tCgVDdVFUlDEHHbS/wqb2PSIoouLV+guTNyxJd+FzVAH+hCZE5K+tCgVDdVFUlDEHHbS/wqb2PSIoouLV+guTNyxJd+FzVAH+hCZE5K+tCgVDdVFUlDEHHbS/wqb2PSIoouLV+guTNyxJd+FzVAH+hCZE5K+tCgVDdVFUlDEHHbS/wqb2PSIoouLV+guTNyxJd+FzVAH+hCZE5K+tCgVDdVFUlDEHHbS/wqb2PSIoouLV+guTNyxJd+FzVAH+hCZE5K+tCgVDdVFUlDEHHbS", "reference": "This doesn't seem like the right expected result... it should be the same as the `clientCert` var defined above." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `wlr_surface_commit_pending` instead of `wlr_surface_flush_damage`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would make sense to do this in `wlr_surface_state_release_buffer` as well.", "reference": "need to rename this now." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to remove the `usingRecursiveComparison()` call.", + "prediction": "I'm not sure why we need to ignore these fields. I think we can just ignore them.", "reference": "NIT: This shouldn't be a TODO. It is just a note isn't it?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `webelem` module.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check here to see if the element is orphaned. If it is, then we should raise a `webelem.OrphanedError` instead of a `webelem.Error`.", "reference": "I changed this to an error, that seems more appropriate than a warning here." }, { - "prediction": "I think this should be `for _, l := range receipt.Logs` instead of `for _, l := range receipt.Logs`", + "prediction": "I think this should be `if l.IsEvmTransfer() {` instead of `if !l.IsEvmTransfer() {`", "reference": "This change could mute unit test failure, but it is better to update unit tests" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is the right place to do it.", + "prediction": "I don't think we need to delete the `notificationIdsInUse` here. It's only used in the `createNotificationHolder` method.", "reference": "All other places that access `notificationIdsInUse` are in methods with descriptive names. We should do the same here. Maybe `markNotificationIdAsFree()`?" }, { @@ -8523,7 +8523,7 @@ "reference": "Same here, we need to call `callback` in else branch" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.", "reference": "At this point we already check that the record is valid and so it could never be nulll" }, { @@ -8531,43 +8531,43 @@ "reference": "Would it not be more sensible just to move setting of the title to later in the method rather than duplicating it here?" }, { - "prediction": "I don't think we need to call `uploadSession` here. It's already called in `MetaClient::heartBeatThreadFunc()`.", + "prediction": "I don't think we need to call `uploadSession` here. It's already done in `loadUsersAndRoles`.", "reference": "why not do it in `reclaimExpiredSessions`? and `pushSessionToCache` can delete" }, { - "prediction": "I don't think this is a good idea. It's not clear to me what the purpose of this is. I think it should be something like `backbone=dict(type='RegNet', out_indices=(0, 1, 2, 3), frozen_stages=1, norm_cfg=dict(type='BN', requires_grad=True), norm_eval=True, style='pytorch')`", + "prediction": "I don't think this is a good idea.", "reference": "out_channels/num_outs/type are unnecessary" }, { - "prediction": "I'm not sure what you're trying to do here, but I'm not sure if this is a good idea.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a test for `Object.keys` and `Object.values` as well.", "reference": "You can create an issue for it and put it on the backlog so we don't forget it." }, { - "prediction": "I think this should be `container.HostConfig.NetworkMode` instead of `networkMode(container.HostConfig)`.", + "prediction": "I think this should be `container.NetworkMode` instead of `container.HostConfig.NetworkMode`?", "reference": "So now we are checking twice, both here and in `weaveCIDRsFromConfig`. Not great. I suggest changing the `ok` return of `weaveCIDRsFromConfig` to a messsage (or error?) instead, which we can then log." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `store` module.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `install` function.", "reference": "An alternative to setting format to the default in Package.__init__ would be to set it in create_package. I think we can assume all packages are created by create_package, but not necessarily by build_package." }, { - "prediction": "I think we can remove the `ProposeBlockCh` since it's not used in the `MiningState` struct.", + "prediction": "I don't think this is necessary. The `ProposeBlockCh` is only used for proposing a new block, so it's not necessary to have a separate channel for it.", "reference": "Let's add fee recipient as well." }, { - "prediction": "I think this should be `filename` instead of `self.filename`.", + "prediction": "I think this should be `self.filename` instead of `self.filename = os.path.basename(self.filename)`.", "reference": "No need for those with `super-init-not-called`, as pylint already only turns things off for this function and it's needed for the entire function." }, { - "prediction": "I think this should be `ACCEPT_SSL_CERTS` instead of `acceptSslCerts`.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `CapabilityType` interface.", "reference": "I think there's another spot for this in DefaultCapabilityMatcher" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `step_text_for_user` method. I think it's a good idea to do this in the `step_text_for_user` method. I think it's a good idea to do this in the `step_text_for_user` method. I think it's a good idea to do this in the `step_text_for_user` method. I think it's a good idea to do this in the `step_text_for_user` method. I think it's a good idea to do this in the `step_text_for_user` method. I think it's a good idea to do this in the `step_text_for_user` method. I think it's a good idea to do this in the `step_text_for_user` method. I think it's a good idea to do this in the `step_text_for_user` method. I think it's a good idea to do this in the `step_text_for_user` method. I think it's a good idea to do this in the `step_text_for_user` method. I think it's a good idea to do this in the `step_text_for_user` method. I", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to move this into the `Approval` class.", "reference": "this name seems pretty vague -- thoughts on a more descriptive method name?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add a docstring to the `MeterFactory` class. This will make it easier for other developers to understand what the class does and how to use it.", + "prediction": "I don't think this is a good idea. The `MeterFactory` class should be a singleton, not a factory.", "reference": "what changed in this line?" }, { @@ -8575,71 +8575,71 @@ "reference": "Instead of doing this let's add another function similar to `hasZeroData` for selecting the `reportArgs` since this is all sourced from selected values. Then `hasZeroData` can use this internally, as well as the component itself. Since this function would be internal just for the purpose of avoiding duplication, we don't need to expose it on the component the same way though." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to get the class name of the exception, but you're not using the `get_class()` method on the exception object.", + "prediction": "I'm not sure what you're trying to do here, but I don't think this is the right place to do it.", "reference": "This line was useful for auto-completion, I think it should be re-added with specifying the var name (`$exception`) and simplifying the FQCN." }, { - "prediction": "I think this should be `io.Copy(conn, backendConn)` instead of `io.Copy(backendConn, conn)`.", + "prediction": "I'm not sure if this is the best way to do this, but I think we can use `io.Copy` to write to the `conn` and `io.Copy` to read from the `conn` instead of `io.Copy` to write to the `backendConn` and `io.Copy` to read from the `backendConn`.", "reference": "This looks like you're not collecting everything from the error channel." }, { - "prediction": "I'm not sure what you mean by \"subject\"", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way", "reference": "This currently violates the Law of Demeter. Using `checkout.plan_name` is the quick resolution." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `null` for the `temporaryFilename` parameter.", + "prediction": "I don't think this is necessary.", "reference": "is there any scenario when `$temporaryFilename` can be null?" }, { - "prediction": "I don't think this is a good idea. The `@SuppressWarnings(\"ReferenceEquality\")` should be on the `visit(RowType)` method, not the `visit(RowType)` method.", + "prediction": "I don't think this is necessary.", "reference": "this is for the `boolean isRoot = root == rowType` check, which seems to be on purpose, but maybe you could double check whether using ref. equality here is still wanted? Same for `SparkTypeToType`" }, { - "prediction": "I'm not sure this is the right place to do this. I think it should be in `roots_drag_icon_update_position` and `roots_drag_icon_damage_whole`.", + "prediction": "I'm not sure if this is the right place to do this.", "reference": "No need to damage after `roots_drag_icon_update_position`, this is already done in `roots_drag_icon_update_position`" }, { - "prediction": "I'm not sure what you mean by `device=torch.device('cpu')` in this context. I think you meant to say `device=torch.device('cuda:0')` or `device=torch.device('cuda:0')`.", + "prediction": "I don't think it's necessary to pass `device=torch.device('cpu')` to `preprocess_example_input`.", "reference": "Have you tested exporting to ONNX with `device=cuda`?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to make sure that the job name is not empty. If it is empty, we should return an error.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to make sure that the job name is not empty.", "reference": "Do we also need to validate `envName` flag then? `appName` and `envName` are used in `initLogsSvc` which are called by `svc logs` from within `Execute()`" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add this to the `AuthController` as well.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add this to `auth.php` as well. I'm not sure if this is the right place to do this, but I think it would be a good idea to add this to `auth.php` as well. I'm not sure if this is the right place to do this, but I think it would be a good idea to add this to `auth.php` as well. I'm not sure if this is the right place to do this, but I think it would be a good idea to add this to `auth.php` as well. I'm not sure if this is the right place to do this, but I think it would be a good idea to add this to `auth.php` as well. I'm not sure if this is the right place to do this, but I think it would be a good idea to add this to `auth.php` as well. I'm not sure if this is the right place to do this, but I think it would be a good idea to add this to `auth.php` as well. I'm not sure if this is the right place to do this, but I think it", "reference": "@LukeTowers I think I would prefer that we don't force it, on the basis that: a) some people would be opting to configure their web server to protect against this kind of attack and would disable this feature in October CMS to get a small performance increase. b) it might be a bit misleading to say that `app.trustedHosts` set to `false` disables the feature entirely, just to have it be overridden here regardless." }, { - "prediction": "I think we can remove the `if err != nil` here.", + "prediction": "I'm not sure if this is the right place to trigger the CNP updates. I think it's better to trigger the CNP updates when the ClusterGroup is created or updated.", "reference": "i like that you are trying to correct the naming, but its making the PR longer :( i guess in future we can do such changes in separate PRs" }, { - "prediction": "I think this is a duplicate of https://github.com/axejs/axe.js/pull/1438", + "prediction": "I think it's better to use `axe.testUtils.flatTreeSetup` instead of `axe.testUtils.flatTreeSetup(fixture)`.", "reference": "Are we marking what the browser's accessibility tree says or what screen readers with those browsers say?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to do something like this:\r\n\r\n```go\r\nfunc (s *stream) FullClose() error {\r\n\treturn s.Close()\r\n}\r\n```\r\n\r\nIs that what you want to do?", + "prediction": "I'm not sure what you mean by `record` here. It's not clear to me what you're trying to do with it.", "reference": "This method should behave as intended, to block until it reads an EOF from the other side." }, { - "prediction": "I don't think this is a good idea. We should be able to fail the health check if it fails, but we shouldn't be able to fail the health check if it succeeds.", + "prediction": "I don't think this is a good idea. It's not clear what the error message should be. I think it should be something like: \"Health check failed on repository '%s': %v\", repoPath, err.", "reference": "I prefer starts with `Failed to xxx`, how about `Failed to perform health check on xxx`?" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `OnTraceStart` method.", "reference": "All these calls make me think we should refactor how traces are started and allow \"source tags\" that we initialize a trace with. I'd like to do this in a follow up." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea to have a `v1_test` package in the `flux` package. The `v1_test` package should only be used for testing the `v1` package, not the `flux` package itself.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I don't think it's a good idea.", "reference": "This file shouldn't be in this PR" }, { - "prediction": "I'm not sure what you mean by \"nonEmptyAssignmentToListElementChangeType\"", + "prediction": "I'm not sure what you mean by \"Skipped nonEmptyAssignmentToListElementChangeType\"", "reference": "This now causes `LessSpecificReturnStatement - src/somefile.php:9:32 - The type 'non-empty-list<5|string>' is more general than the declared return type 'non-empty-list' for takesList`, which seems correct to me. The type `non-empty-list<5|string>` contains the type `non-empty-list`. Thoughts?" }, { - "prediction": "I think this should be `sendResponse` instead of `sendRequest`.", + "prediction": "Shouldn't this be `sendRequest` instead of `sendRequestPrivateTransaction`?", "reference": "Are you going to change that back?" }, { @@ -8647,35 +8647,35 @@ "reference": "we have a standard format for putting these together elsewhere, it does the filter check first and errors out and then sets based on the value. i think this should be adjusted to do that. there's no logical change, just an approach change." }, { - "prediction": "I'm not sure what you mean by \"wrap counter\" here. I think you meant to say \"wrapping counter\" or something like that.", + "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good idea to move it to the top of the menu.", "reference": "Note this should be `delay` instead of `scale` here. I'll fix this in my branch." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to do something like this: `uppy.upload.on('error', function(e) { console.log(e); });` but I'm not sure what you're trying to do here. I think you're trying to do something like this: `uppy.upload.on('error', function(e) { console.log(e); });` but I'm not sure what you're trying to do here. I think you're trying to do something like this: `uppy.upload.on('error', function(e) { console.log(e); });` but I'm not sure what you're trying to do here. I think you're trying to do something like this: `uppy.upload.on('error', function(e) { console.log(e); });` but I'm not sure what you're trying to do here. I think you're trying to do something like this: `uppy.upload.on('error', function(e) { console.log(e); });` but I'm not sure what you're trying to do here. I think you're trying to do something like this: `uppy.upload.on('error', function(e) { console.log(e); });` but I'm not sure what you're trying to do", + "prediction": "`this.emit = this.emitter.emit.bind(this.emitter)` should be `this.emit = this.emitter.emit.bind(this)`", "reference": "`on` likely still needs a bind, similar to `this.resetProgress = this.resetProgress.bind(this)` correct?" }, { - "prediction": "`get_dist_info` should be `dist.get_world_size()`, `dist.get_rank()`, `dist.get_world_size()`, `dist.get_rank()`, `dist.get_world_size()`, `dist.get_rank()`, `dist.get_world_size()`, `dist.get_rank()`, `dist.get_world_size()`, `dist.get_rank()`, `dist.get_world_size()`, `dist.get_rank()`, `dist.get_world_size()`, `dist.get_rank()`, `dist.get_world_size()`, `dist.get_rank()`, `dist.get_world_size()`, `dist.get_rank()`, `dist.get_world_size()`, `dist.get_rank()`, `dist.get_world_size()`, `dist.get_rank()`, `dist.get_world_size()`, `dist.get_rank()`, `dist.get_world_size()`, `dist.get_rank()`, `dist.get_world_size()`, `dist.get_rank()`, `dist.get_world_size()`, `dist.get_rank()`, `dist.get_world_size()`, `dist.get_rank()`, `dist.get_world_size()`, `dist.get_rank()`, `dist.get_world_size()`, `dist.get_rank()`, `dist.get_world_size()`, `dist.get_rank()`, `dist", + "prediction": "`get_dist_info` should be `dist.get_world_size()`", "reference": "Considering the trade-off between training speed and accuracy, multi-scale training is temporarily kept. More elegant implementation will be adopted in the future." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add a comment to explain what it does.", + "prediction": "`seelog` is not used anywhere in this file, so I don't think it's necessary to import it.", "reference": "Can you move this up along with the other builtin libraries?" }, { - "prediction": "I think this should be `item=self.notifyForPendingUpdateCheckBox = wx.CheckBox(self, label=_(\"Notify for &pending update on startup\"))`", + "prediction": "I think it's better to use `self.notifyForPendingUpdateCheckBox.SetValue(config.conf[\"update\"][\"notifyForPendingUpdate\"])` instead of `item.SetValue(config.conf[\"update\"][\"notifyForPendingUpdate\"])`", "reference": "I actually think it makes sense to reposition this checkbox after the notifyForPendingUpdateCheckBox. The current order of check boxes is a bit arbitrary now." }, { - "prediction": "I'm not sure I understand what you're trying to do with the `Changes` struct. It seems like you're trying to calculate the difference between two different states of the build graph, but I'm not sure what you're trying to do with the `Args` field. Could you provide more context or clarify what you're trying to achieve with this `Changes` struct?", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a `--before` and `--after` option for the `changes` command. This way, we don't have to specify the `--before` and `--after` options every time we run the `changes` command. We could also add a `--no-checkout` option to the `changes` command, which would allow us to run the `changes` command without checking out any files.", "reference": "Why do we have both `before` and `after`? Naively I would expect this to work as follows: `plz query changed` with no arguments compares the current working directory state to the last commit (i.e. HEAD, i.e. a noop when directly on a git commit). `plz query changed --since [reflike]` compare the current working directory state to the given reflike. So for CI I would expect to run something like `plz query changed --since @{upstream} (or origin/master I guess)`. And on merge I'd either run everything or just `plz query changed --since HEAD^` (given our workflow) - I don't think I'd ever want to do anything else. Either way I think before and after are slightly confusing terms here." }, { - "prediction": "I think it's a good idea to add a `help` option to the `FDst` class, so that the user can see what it does.", + "prediction": "I think it's better to use `re.search` here, since we don't need to check if `f.server_conn` is not `None`.", "reference": "Is there a reason why we can't use `~dst`? It feels like that could be good enough.I would like to avoid extending the filter syntax unless there's an urgent need. :)" }, { - "prediction": "`Timestamp` is a `DateTime`, not a `DateTimeOffset` or `UnixTime`.", + "prediction": "I'm not sure what you mean by `TimestampDate` and `TimestampLocalDateTime`. I think you meant `TimestampDate` and `TimestampLocalDateTime` instead.", "reference": "Why local and not UTC?" }, { @@ -8683,19 +8683,19 @@ "reference": "2012 is a retryable error. Will avoiding rgenerating it here cause a difference in behavior in createServer() ?" }, { - "prediction": "I don't think we need to use `sort` here. We can just use `sort.Ints` here.", + "prediction": "I don't think this is needed anymore. I think we can remove it.", "reference": "move to line 14 below" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is the right place to do it.", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to check if the rectangle intersects with a triangle. I think you want to check if the rectangle intersects with the triangle, not the other way around.", "reference": "the method name should match teh docs" }, { - "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to create a new RMD for the given name, but I'm not sure what you're trying to do with it. I think you're trying to create a new RMD for the given name, but I'm not sure what you're trying to do with it. I think you're trying to create a new RMD for the given name, but I'm not sure what you're trying to do with it. I think you're trying to create a new RMD for the given name, but I'm not sure what you're trying to do with it. I think you're trying to create a new RMD for the given name, but I'm not sure what you're trying to do with it. I think you're trying to create a new RMD for the given name, but I'm not sure what you're trying to do with it. I think you're trying to create a new RMD for the given name, but I'm not sure what you're trying to do with it. I think you're trying to create a new RMD for the given name, but I'm not sure what you're trying to do with it. I think", + "prediction": "I'm not sure if this is the right place to do this, but I think it should be in the `makeInitialRootMetadata` function.", "reference": "Won't this happen automatically when we flip the default version in the config?" }, { - "prediction": "I'm not sure what you're trying to do here, but I think it's a bad idea to use `testcommon.CaptureStdOut()` in this case.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure the output of the command is captured in the `stdout` variable.", "reference": "This would also change back to /var/www/html/docroot if we go that way." }, { @@ -8707,11 +8707,11 @@ "reference": "We are no longer including file name in the source files." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to set the current user, but I don't think that's what you want to do. I think what you want to do is set the current user, but I don't think that's what you want to do. I'm not sure what you're trying to do here. I think you're trying to set the current user, but I don't think that's what you want to do. I think what you want to do is set the current user, but I don't think that's what you want to do. I'm not sure what you're trying to do here. I think you're trying to set the current user, but I don't think that's what you want to do. I think what you want to do is set the current user, but I don't think that's what you want to do. I'm not sure what you're trying to do here. I think you're trying to set the current user, but I don't think that's what you want to do. I think what you want to do is set the current user, but I don't think that's what you want to do. I'm not sure what you're trying", + "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bad idea to override `before_filter :set_current_user` in this way. It's not clear to me what you're trying to achieve with this.", "reference": "no need for this. Devise provides us with `current_user` and `user_signed_in?` helpers." }, { - "prediction": "I think it's a good idea to add a `V66` constant to the `EthProtocol` class. This way we don't need to check for `V65` in the `isEth66Compatible` method.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `V66Compatible` method to the `EthProtocol` class.", "reference": "Would `Object.equals(capability.getName(), NAME)` would be safer, as you wouldn't have to do null checks?" }, { @@ -8719,55 +8719,55 @@ "reference": "Hmm, I wonder if we should revert #1862 instead? BTW, what failure do you get w/o this line?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check for the existence of the APIURL key in the slack config.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to validate the URL before using it.", "reference": "since there are several places where we do 1) get secret key ref and 2) validate URL, maybe it's worth having a common method? it could also trim spaces as done here (but not at the other places currently)." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for `extendPartialURL` and `normalizeToPartialURL`.", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to extend the partial URL, but you're not using the `extendPartialURL` function, so I'm not sure what you're trying to do here.", "reference": "TestNormalize... I would also split them" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to move this to the `readObjects` function.", + "prediction": "I don't think we need to use `next()` here. We can just use `indexGen.next()` directly.", "reference": "All changes to this file are going to conflict with #7599. Please revert these as well. They will be addressed during the Python 3 transition." }, { - "prediction": "I'm not sure what you mean by \"not thread safe\" in this context. I think you're right that it's not thread safe, but I'm not sure what you mean by \"not thread safe\" in this context. I think you're right that it's not thread safe, but I'm not sure what you mean by \"not thread safe\" in this context. I think you're right that it's not thread safe, but I'm not sure what you mean by \"not thread safe\" in this context. I think you're right that it's not thread safe, but I'm not sure what you mean by \"not thread safe\" in this context. I think you're right that it's not thread safe, but I'm not sure what you mean by \"not thread safe\" in this context. I think you're right that it's not thread safe, but I'm not sure what you mean by \"not thread safe\" in this context. I think you're right that it's not thread safe, but I'm not sure what you mean by \"not thread safe\" in this context. I think you're right that it's not thread safe, but I'm not sure what you mean by \"not thread safe\" in this context", + "prediction": "I'm not sure why we need a lock here. It's not thread safe.", "reference": "Just thought, using spinlock (busy wait with compare and swap) that generates 2 random numbers inside rlock. We know that collisions are rare and we don't need that \"large\" write lock really but lock namely for \"rand\". Or least use a separate Lock (Mutex), namely for \"rand\" (wrap it into method). Mutex will use some sort of spinlock as well but it may use some linked list to make it more fair." }, { - "prediction": "I'm not sure what you mean by \"allow stopping after the first semicolon/hash encountered\", but I think it's a good idea to add this to the `__init__.py` file of the `pylint` package.", + "prediction": "I'm not sure what you mean by \"allow stopping after the first semicolon/hash encountered\", but I think it's important to note that this is a breaking change.", "reference": "Can we grab it directly from `__pkginfo__` as that is the source of truth for the version?" }, { - "prediction": "I don't think this is necessary. The `DataFetchingEnvironment` is already available in the `DataFetcher` class.", + "prediction": "I don't think this is necessary. The `DataFetchingEnvironment` is just a wrapper for the `DataFetcher`, so it's not necessary to have a separate `DataFetchingEnvironment` class.", "reference": "We can revert this to reduce the diff of the PR." }, { - "prediction": "I think this should be `if (isCloud)` instead of `if (isCloud || protoPkg.contains(\"cloud\"))`", + "prediction": "I think this should be `goPkg = goPkg.replaceFirst(\"cloud\\\\/\", \"\");`", "reference": "This looks weird. `isCloud` should define if it is a cloud or no. Here it does it partially, and it can be overriden by protoPkg value (which also an argument to this function). Please make sure that isCloud completely defines the cloud thing. (i.e. it an be as straightforward as moving `protoPkg.contains(\"cloud\")` from here to the place where `assembleGoImportPath` is called." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the file already exists before trying to open it for writing.", "reference": "Declaring fileflags to be of type LobTgtFileFlags would eliminate the need for all this casting. And would be safer. (Not a show-stopper though.)" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a `DockerOptions` constructor that takes a `List` as an argument. This way, you can pass in a list of `DockerSessionFactory` objects and they will be used to create the `DockerSessionFactory` instances.", "reference": "This change prevents a user understanding how their server is configured. Best to leave at `info` level." }, { - "prediction": "I think this should be `SSL_set_tlsext_host_name(ssl_, getHost().c_str());` instead of `SSL_set_tlsext_host_name(ssl_, getHost().c_str()); #if defined(SSL_set_tlsext_host_name) // set the SNI hostname`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to set the SNI hostname in the `SSL_set_tlsext_host_name()` function.", "reference": "Typically we would add something to the build system environment to differentiate this; also is there an alternative that can be used with older OpenSSL? Other folks who are committers will need to decide if it is worth supporting an older and likely quite vulnerable (to hacks) OpenSSL library." }, { - "prediction": "I'm not sure what you're trying to do with this test, but I don't think it's a good idea.", + "prediction": "I don't think this is a good idea. It's not clear to me what the purpose of this test is. I think it should be something like `readActiveBlockProducersByHeightTests = []struct { protocolID string, protocolType string }{}`", "reference": "`readActiveBlockProducersByHeightTests` is a global variable (from `gochecknoglobals`)" }, { - "prediction": "I think this should be `saveRecordsToSmartStore(soupName, records, mergeMode, idField);` instead of `saveRecordsToSmartStore(soupName, records, mergeMode);`", + "prediction": "I'm not sure I understand what you're trying to do here. You're saving the records to the smartstore, but you're not updating the sync state. What you're trying to do is update the sync state, but you're not saving the records to the smartstore. Is this what you're trying to do?", "reference": "Falls back on `Constants.ID` if there's no custom field set." }, { - "prediction": "I'm not sure what you mean by \"we don't particularly care what the reason why we have failed to access the file was.\"", + "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", "reference": "I believe this is what we want to rearrange: this in.skip() should not be happening here, in the open method, but in the setOffset() method itself. Because we want to be able to change that offset after the initial open. The setOffset() method will need to throw an IOException, if it's called while the InputStream is still null; or if the skip() call itself results in an IOException()" }, { @@ -8775,31 +8775,31 @@ "reference": "In case the method is `void`, there won't be any children and `getChild(0)` throws. We'll need to check with `isVoid()` for that case. I'll update this when I merge." }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. If you want to log requests, you should do it in the handler. If you want to intercept requests, you should do it in the handler. If you want to intercept responses, you should do it in the handler. If you want to intercept responses, you should do it in the handler. If you want to intercept responses, you should do it in the handler. If you want to intercept responses, you should do it in the handler. If you want to intercept responses, you should do it in the handler. If you want to intercept responses, you should do it in the handler. If you want to intercept responses, you should do it in the handler. If you want to intercept responses, you should do it in the handler. If you want to intercept responses, you should do it in the handler. If you want to intercept responses, you should do it in the handler. If you want to intercept responses, you should do it in the handler. If you want to intercept responses, you should do it in the handler. If you want to intercept responses, you should do it in the handler. If you want to intercept responses,", + "prediction": "I don't think this is necessary.", "reference": "If the yarpc.Interceptors wrapper will be added to any user interceptor, why not do it transitively. Can save one step for users. Same apply to filter." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to move the data directory to a temp path.", + "prediction": "I think this should be `if err := e.removePeer(ctx, e.name, e.address, false); err != nil { ... }`", "reference": "Is there anything we should do in the event we're unable to renaming the directory?" }, { - "prediction": "I think we can remove the `logging.NewConfigFromMap(nil)`.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.", "reference": "How is this env var populated? Can this be retrieved from cluster metadata?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to log the error here.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to log the error here.", "reference": "Should probably skip the success event here, since it could be a noop." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to set the `imageBlurhashes` property of the `item.ImageBlurHashes` array to the value of the `item.ImageBlurHashes` property of the `item` object passed to the `chaptercardbuilder.buildChapterCards` function. Is this what you're trying to achieve?", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea to use `imageBlurhashes` in the `buildChapterCards` function. I think it's better to use `item.ImageBlurHashes` directly in the `buildChapterCards` function.", "reference": "I added this here because people cards (which depends on cardBuilder) had this added in blurhash. Not sure when this is used though cc @JustAMan" }, { - "prediction": "I'm not sure what you mean by \"empty string\" in this context. I think you meant to say that it returns the default from the URLOpener.Decoder, or BytesDecoder if URLOpener.Decoder is nil (which is true if you're not using a driver package).", + "prediction": "I'm not sure what you mean by \"empty string\"", "reference": "Let's keep this line in the docstring, to let end users know they shouldn't be using this directly." }, { - "prediction": "I don't think we need to check the gas price here. It's already checked in the `validateCreateStake` function.", + "prediction": "I don't think we need to check the gas price here, since it's already checked in `validateCreateStake` and `validateUnstake`.", "reference": "can do the same for other validateXXX()" }, { @@ -8807,7 +8807,7 @@ "reference": "Why is this necessary?" }, { - "prediction": "I think this should be `os.path.join(curr_path, '../python-package/')` instead of `os.path.join(curr_path, '../python-package/')`", + "prediction": "I'm not sure what you mean by `os.path.join(curr_path, '../python-package/')`. Is this the same as `os.path.join(curr_path, 'python-package/')`?", "reference": "Please move this import upper to other similar imports" }, { @@ -8815,23 +8815,23 @@ "reference": "Include the key word \"translated\". Otherwise the reader will find this confusing." }, { - "prediction": "I think this should be `@Memoized` instead of `@Memoized // Memoized to reduce garbage as this is effectively a singleton.`", + "prediction": "I'm not sure if this is a good idea, but I think we should memoize this method as well. We don't need to memoize the index templates, but we do need to memoize the span store. If we memoize the span store, then we'll need to memoize the index templates as well.", "reference": "why. is this called per request? if so this also adds a lock internally. can we not add this at the moment until analyzed as this assumption isnt carried to the several other impls. the only other consumer of this is the http api and that isnt hit often enough for specializations." }, { - "prediction": "I'm not sure what you mean by \"browser automatically selects the first option\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if `selectedOptions.length` is greater than 0, and if so, remove the `hasAttr('selected')` from the `selectedOptions` array.", "reference": "I believe this means dependent checks can no longer operate on virtual nodes, which is something we've been pushing for lately. We may need to find a different way to solve this issue, as I don't think we want to cause a regression while fixing a bug." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to add a `__init__` method to `StorageBase` and `Migrator` so that we don't have to call `super().__init__()` every time we create an instance of these classes.", + "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good idea to have a `__init__.py` file in the same directory as the `Storage` class. That way, we can have a `__init__.py` file in the same directory as the `Storage` class, and we can have a `__init__.py` file in the same directory as the `Storage` class, and we can have a `__init__.py` file in the same directory as the `Storage` class, and we can have a `__init__.py` file in the same directory as the `Storage` class, and we can have a `__init__.py` file in the same directory as the `Storage` class, and we can have a `__init__.py` file in the same directory as the `Storage` class, and we can have a `__init__.py` file in the same directory as the `Storage` class, and we can have a `__init__.py` file in the same directory as the `Storage` class, and we can have a `__init__.py` file in the same directory as the `Storage` class, and we can", "reference": "ditto about use of `abspath`" }, { - "prediction": "I think we can remove `isEvenlyDivisibleByAllNumbersFrom1To(max, val)` and replace it with `isEvenlyDivisibleByAllNumbersFrom1To(val, max)`.", + "prediction": "I'm not sure what you're trying to achieve with this code, but it looks like you're trying to find the smallest positive number that can be evenly divided by all numbers from 1 to `max` (inclusive). Is this what you're trying to do?", "reference": "this reduces the runtime by 50 times" }, { - "prediction": "I think this should be `org.openqa.grid.distributor.remote.RemoteDistributorTest` instead of `org.openqa.selenium.grid.distributor.remote.RemoteDistributorTest`", + "prediction": "I think this should be `RemoteDistributorTest.class` instead of `org.openqa.selenium.grid.distributor.remote.RemoteDistributorTest.class`", "reference": "Probably best not to have an empty test...." }, { @@ -8839,11 +8839,11 @@ "reference": "direct `newInstance` call is also deprecated now" }, { - "prediction": "I'm not sure what you mean by this, but I think we need to add the `netlink` package to the list of required packages for this to work.", + "prediction": "I'm not sure what you mean by this, but it looks like we need to add the `netlink` package to the list of required packages.", "reference": "We have a bit of a convention where imports are split into three blocks: first Go standard library, then imports from outside the repo, then imports from inside the repo." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the summary of the previous snapshot, and then update the totals for the current snapshot. Is this what you're trying to do?", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to update the `summary` method in the `SnapshotProducer` class.", "reference": "Why was this change needed?" }, { @@ -8851,35 +8851,35 @@ "reference": "can you use this opportunity to remove `.readlines()` useless list creation? (`addresses = [l for l in fd if l.find(\"netmask\") >= 0]`)" }, { - "prediction": "I think it's better to use `assert_match` instead of `assert_match!` in this case. `assert_match!` will fail if there is no match. `assert_match` will fail if there is no match at all. `assert_match` will fail if there is no match at all. `assert_match` will fail if there is no match at all. `assert_match` will fail if there is no match at all. `assert_match` will fail if there is no match at all. `assert_match` will fail if there is no match at all. `assert_match` will fail if there is no match at all. `assert_match` will fail if there is no match at all. `assert_match` will fail if there is no match at all. `assert_match` will fail if there is no match at all. `assert_match` will fail if there is no match at all. `assert_match` will fail if there is no match at all. `assert_match` will fail if there is no match at all. `assert_match` will fail if there is no match at all. `assert_match` will fail if there is no match at all. `assert_match` will fail if there is no match", + "prediction": "I think it's better to use `message = \"The plan was expected to mention the host #{node.hostname} with _output\"` instead of `message = \"The plan was expceted to mention the host #{node.hostname} with _output\"`", "reference": "Why does this check differ from `plan_ssh.rb`?" }, { - "prediction": "`zap` is not used in this PR, so we don't need to use it.", + "prediction": "`zap` is not used anywhere in this PR, so we can safely remove it.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I think this should be 64 instead of 32.", "reference": "It was @lodejard who initially suggested this pattern. I think that it had something to do about prioritizing future writes even if there was a pending write operation ready to handle the newly requested write. I'm not sure I fully understood the explanation for having up to 3 pending write requests, because only having one queued write at a time still makes sense to me. I'll talk to him about it." }, { - "prediction": "I don't think this is a good idea. It's not clear to me what the purpose of this option is. I think we should remove it.", + "prediction": "I don't think this is a good idea. It's not clear what it does, and I don't think it's a good idea to change the default value of `debug_dump_representatives` to `false`.", "reference": "We have cli --online_weight_clear in cli.cpp" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `HTTPClient` struct.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `HTTPClientIPKey` struct, so that we don't have to do this in the `HTTPRouteKey` struct as well.", "reference": "So the request.Headers is a map of []string. Are you sure that the HTTP library doesn't already do this split for us?" }, { - "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here.", + "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. Is it that you want to return a string that describes the current state of the execution, or is it that you want to return a string that describes the current state of the dispatcher? If it's the former, then I think you should be returning a string that describes the current state of the dispatcher. If it's the latter, then I think you should be returning a string that describes the current state of the dispatcher and the current state of the execution.", "reference": "How is this message used? Can we remove the \"crashed executor/container\" part which is an implementation detail?" }, { - "prediction": "I'm not sure if this is the right place to put it, but I think it should be in the `HttpCommandExecutor` class, not in the `CommandExecutor` class. The `HttpCommandExecutor` class is the base class for all command executors, so it should have access to the `nameToUrl` object.", + "prediction": "I'm not sure if this is the right place to put it, but I think it should be in the `HttpCommandExecutor` class.", "reference": "Instead of building in routing for a browser-specific command, could you refactor the HttpCommandExecutor to allow arbitrary commands to be registered?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a link to download the video, so that the user doesn't have to go to the purchase page to download the video.", + "prediction": "I think we can remove the `purchase: @purchase` from the `video-headline` because it's not needed.", "reference": "Space after `=`." }, { @@ -8887,15 +8887,15 @@ "reference": "if just need to do something after createInvocation just override and call super first is enough?" }, { - "prediction": "I'm not sure what you mean by \"sets TRAVIS_SCALA_VERSION\" in this case. I think you meant to say `should set TRAVIS_SCALA_VERSION`, right?", + "prediction": "I'm not sure what you mean by \"sets TRAVIS_SCALA_VERSION\". I think you meant to set `TRAVIS_SCALA_VERSION` to `2.10.0`.", "reference": "By the way, I fixed `announce` method (missing `super` call to announce JDK version)" }, { - "prediction": "I'm not sure what you mean by `contains(Object element)`. Is this the same as `contains(T element)`? If so, why do you think it should be `contains(Object element)`?", + "prediction": "I don't think this is necessary. The `contains` method is already checked in the `TreeSet` constructor.", "reference": "I'm not sure about that... This line can produce ClassCastException if Comparator do not check this." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.", + "prediction": "I'm not sure what you mean by \"server-side\" here. Is it referring to the server side of the key server, or the client side of the key server? If it's the server side of the key server, then I think you're right. If it's the client side of the key server, then I'm not sure what you mean by \"server-side\" here. Is it referring to the server side of the key server, or the client side of the key server? If it's the server side of the key server, then I think you're right. If it's the client side of the key server, then I'm not sure what you mean by \"server-side\" here. Is it referring to the server side of the key server, or the client side of the key server? If it's the server side of the key server, then I think you're right. If it's the client side of the key server, then I'm not sure what you mean by \"server-side\" here. Is it referring to the server side of the key server, or the client side of the key server? If it's the server side of the key server, then I think you're right. If it's the client side of the", "reference": "There wasn't any special reason for this to return a pointer, right?" }, { @@ -8903,47 +8903,47 @@ "reference": "Why the need for a `ConcurrentHashMap`?" }, { - "prediction": "I think we can remove the `if (typeof aProp === 'string') aProp = aProp.toLowerCase();` line.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way", "reference": "New code should use strict equality `===`" }, { - "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to test that the `Notify[local pid]` and `Notify[remote pid]` resources are defined in the `basic::defer` plan, but they are not defined in the `plan run basic::defer` plan. Is that correct?", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `raise` here. It's not clear what you're trying to do here, but I don't think it's a good idea to use `raise` here. It's not clear what you're trying to do here, but I don't think it's a good idea to use `raise` here. It's not clear what you're trying to do here, but I don't think it's a good idea to use `raise` here. It's not clear what you're trying to do here, but I don't think it's a good idea to use `raise` here. It's not clear what you're trying to do here, but I don't think it's a good idea to use `raise` here. It's not clear what you're trying to do here, but I don't think it's a good idea to use `raise` here. It's not clear what you're trying to do here, but I don't think it's a good idea to use `raise` here. It's not clear what you're trying to do here, but I don't think it's a good idea to use", "reference": "`expect(resources['Notify[local pid]']['events'][0]['desired_value']).to match(/(\\d+)/)` seems clearer." }, { - "prediction": "I think we can remove the `config` and `ctx` here, since they are not used anymore.", + "prediction": "I think it's better to use `context.WithCancel` instead of `context.CancelFunc` in this case.", "reference": "Removed now-unneeded param." }, { - "prediction": "`go-filecoin bitswap` should be `go-filecoin bitswap`", + "prediction": "`go-filecoin bitswap` should be `go-filecoin bitswap` instead of `go-filecoin bitswap`", "reference": "(NON-blocking, this can be tracked in follow up issue) @anorth @mishmosh is the toplevel getting too crowded? Should we have a `network` grandparent command, or maybe a `stats` command?" }, { - "prediction": "I'm not sure if this is the right place for this, but I think it would be good to have a `footerCtaLabel` for the `footerCtaLink` as well.", + "prediction": "I'm not sure if this is the right place for this, but I think it would be good to add a `footerCtaLabel` to the `footerCtaLink` as well. I think it would be good to have a `footerCtaLabel` for the `footerCtaLink` and a `footerCtaLabel` for the `footerCtaLink` as well.", "reference": "The `_x` function needs to be imported at the top of the file (in addition to `__`)" }, { - "prediction": "I think this should be `propDialog.OkDialog()` instead of `propDialog.SetQValueTo(0.003f)`.", + "prediction": "I think this should be `propDialog.OkDialog()` instead of `propDialog.SetQValueTo(0.003f);`", "reference": "This is functionally equivalent to the code it replaces." }, { - "prediction": "I think it's better to use `string` for `ENIType` instead of `string` for `ENIType` and `string` for `IPV4Addresses` and `string` for `IPV6Addresses`.", + "prediction": "I think it's better to use `string` for `ENIType` and `string` for `IPV4Addresses` and `string` for `IPV6Addresses` instead of `string` for `ENIType` and `string` for `IPV4Addresses` and `string` for `IPV6Addresses` instead of `string` for `ENIType` and `string` for `IPV4Addresses` and `string` for `IPV6Addresses` instead of `string` for `ENIType` and `string` for `IPV4Addresses` and `string` for `IPV6Addresses` instead of `string` for `ENIType` and `string` for `IPV4Addresses` and `string` for `IPV6Addresses` instead of `string` for `ENIType` and `string` for `IPV4Addresses` and `string` for `IPV6Addresses` instead of `string` for `ENIType` and `string` for `IPV4Addresses` and `string` for `IPV6Addresses` instead of `string` for `ENIType` and `string` for `IPV4", "reference": "can you change the field name here to \"InterfaceAssociationProtocol\"? same for the Config struct in agent/ecscni/types.go. i think it's better to keep the field name consistent between agent and acs payload" }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.", + "prediction": "I'm not sure if this is a good place to put this, but I think we should move it to the `tests` directory.", "reference": "See above, same for the other cases." }, { - "prediction": "I think this should be `getOrAdd` instead of `getOrAdd(String name, MetricSupplier metricSupplier)`.", + "prediction": "I'm not sure I understand what you're trying to do with this method. Is it that you want to create a new gauge with the same name, or do you want to replace an existing gauge with the same name? If you want to replace an existing gauge with the same name, you should use the `replace` method. If you want to create a new gauge with the same name, you should use the `getOrAdd` method.", "reference": "Shouldn't line 313 be public \\ SettableGauge\\ **settable**Gauge(String name) { ? It would also be good to call it a few times and with differnet types (Long, Integer, String) in the test as well." }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason you want to do this?", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this.", "reference": "I would prefer to just fix the occurences of this new check rather than disable them" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a new feed item and then add it to a list of feed items. I'm not sure what you're trying to do here, but it looks like you're trying to create a new feed item and then add it to a list of feed items. I'm not sure what you're trying to do here, but it looks like you're trying to create a new feed item and then add it to a list of feed items. I'm not sure what you're trying to do here, but it looks like you're trying to create a new feed item and then add it to a list of feed items. I'm not sure what you're trying to do here, but it looks like you're trying to create a new feed item and then add it to a list of feed items. I'm not sure what you're trying to do here, but it looks like you're trying to create a new feed item and then add it to a list of feed items. I'm not sure what you're trying to do here, but it looks like you're trying to create a new feed item and then add it to a list of feed items. I'm not sure", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate method for this.", "reference": "The tests should be fixed in #4841, so this is no longer needed" }, { @@ -8951,35 +8951,35 @@ "reference": "I think it should been in `SharedKernel` module." }, { - "prediction": "I'm not sure what you mean by \"overrideNginxIngressWhitelistAnnotation\"", + "prediction": "I don't think we need this field. It's not used anywhere in the spec.", "reference": "Can we add some description for this field?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a map of `Expression` to `DataType`, but I don't think that's what you're trying to do here. I think you're trying to create a map of `DataType` to `Expression`, but I don't think that's what you're trying to do here. I think you're trying to create a map of `Expression` to `DataType`, but I don't think that's what you're trying to do here. I think you're trying to create a map of `DataType` to `Expression`, but I don't think that's what you're trying to do here. I think you're trying to create a map of `Expression` to `DataType`, but I don't think that's what you're trying to do here. I think you're trying to create a map of `DataType` to `Expression`, but I don't think that's what you're trying to do here. I think you're trying to create a map of `Expression` to `DataType`, but I don't think that's what you're trying to do here. I think you're trying to create a map of `DataType` to `Expression`, but I don", + "prediction": "I don't think this is necessary. We don't need to map `TimestampType` to `TimeType` and `DurationType` to `DurationType`. We can just use `TimeType` and `DurationType` directly.", "reference": "Should its name be Time or Duration? I can see them both." }, { - "prediction": "I'm not sure what you mean by \"retrying batches in case of export failure using an exponential backoff.\" Could you please provide more context?", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `applyGRPCOption` method to apply the GRPC options to the config. This way, we don't need to create a new `otlpconfig.GRPCOption` object for each option we want to apply.", "reference": "Is this used anywhere?" }, { - "prediction": "I'm not sure what you're trying to do with this test, but I don't think it's a good idea.", + "prediction": "I'm not sure what you mean by \"empty\" in this case. I think you meant to say that it should return an empty resource.", "reference": "I believe that you can use `assert` instead of `require` here and in the following lines" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. It's a bit of a hack, but I think it would be a good place to do this.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the payment channel already exists. If it does, then we can just return an error. If it doesn't, then we can create the payment channel.", "reference": "In `storagemarket.go` you used `nil` for an unwanted out parameter. Do something consistent (nil seems fine if supported)." }, { - "prediction": "I think we can remove `padBytesLeft` and `isPotential` as they are not used anymore.", + "prediction": "I'm not sure if this is a good idea or not. I think it's a good idea, but I'm not sure if it's the best way to do it. I'm not sure if it's a good idea or not. I think it's a good idea, but I'm not sure if it's the best way to do it. I'm not sure if it's a good idea or not. I think it's a good idea, but I'm not sure if it's the best way to do it. I'm not sure if it's a good idea or not. I think it's a good idea, but I'm not sure if it's the best way to do it. I'm not sure if it's a good idea or not. I think it's a good idea, but I'm not sure if it's the best way to do it. I'm not sure if it's a good idea or not. I think it's a good idea, but I'm not sure if it's the best way to do it. I'm not sure if it's a good idea or not. I think it's a good idea, but I'm not sure if it's the best way to do it. I'm not sure", "reference": "is this a new pattern we use in bee? interesting" }, { - "prediction": "I think this should be `if err, ok := err.(*s3.Error); !ok { ... }`", + "prediction": "I think this should be `if err != nil { return err; }` instead of `if err, ok := err.(*s3.Error); ok { return err; }`", "reference": "If you think this PR works, i'll clean this up before resubmitting." }, { - "prediction": "I think we can remove `GROUPID` and `ARTIFACTID` from the `Const` class.", + "prediction": "I think it's better to use `GROUPID` instead of `INSTANCE_PUBKEY_PRO`.", "reference": "are you sure you can read version by this artifactid?" }, { @@ -8987,43 +8987,43 @@ "reference": "We can get rid of this import then." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to do this in a single line.", + "prediction": "I think it's better to use `switch c.typ { case CLIENT, ROUTER, GATEWAY }` instead of `switch c.typ == CLIENT, ROUTER, GATEWAY`", "reference": "Should we do our own vtable?" }, { - "prediction": "I think this should be `config.roadie.url_options = config.action_mailer.default_url_options` instead of `config.roadie.url_options = config.action_mailer.default_url_options`", + "prediction": "I think this should be `config.autoload_paths << Rails.root.join('lib')` instead of `config.roadie.url_options = config.action_mailer.default_url_options`", "reference": "This is the actual fix." }, { - "prediction": "I'm not sure what you mean by \"coalesceMinimum\". Is it the minimum number of messages that need to be coalesced to trigger a flush?", + "prediction": "I'm not sure what you mean by \"coalesceMinimum\". I think you meant to say `coalesceMinimum = 16 * 1024 * 1024`.", "reference": "If sync has really a negative impact, this is just moving the issue from 10sec to 60sec. Wonder if you should not expose the (auto)sync params so users can decide." }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason you want to use `DecodeMap` here?", + "prediction": "I'm not sure what you mean by \"exact match\" here. I think you mean \"exact match\" in the sense that the field name should match the name of the field in the struct.", "reference": "should be called => will be called" }, { - "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here.", + "prediction": "I don't think we need to do anything here.", "reference": "not sure whether we should do this. It may cause problem that delegates upgrade their nodes at different time, that they will have different \"last block time\", some use \"commit time\", some use \"block time\". Potential solution: Only use block time after berling, and then delete it in the next version after berling. Open to discussion." }, { - "prediction": "I'm not sure if this is the right place to call `deleteCollection`, but I think it's the right place to call `deleteCollection`.", + "prediction": "I'm not sure if this is the right place to call `deleteCollection`, but I think it makes more sense to call `deleteCollection` after the `buildReplicaPositions` call.", "reference": "So one question I have is why is the error coming back from `buildReplicaPositions` not an `Assign.AssignmentException`? Is it because it is wrapped in a `SolrException` from the remote node?" }, { - "prediction": "I think this should be `assert re.search(r\"} # \\d+(?:\\.\\d+)?(?:[eE][+-]?\\d+)? s \\(failed\\)\", logger.msg)` instead of `assert re.search(r\"} # \\d+(?:\\.\\d+)?(?:[eE][+-]?\\d+)? s\", logger.msg)`", + "prediction": "I think we can remove the `assert re.search(r\"} # \\d+(?:\\.\\d+)?(?:[eE][+-]?\\d+)? s \\(failed\\)\", logger.msg)` line.", "reference": "`dt` won't work for some reason?" }, { - "prediction": "I'm not sure why we're using `os.getenv(\"KOALAS_USAGE_LOGGER\", None)` here. Is there a good reason why we'd want to use `os.getenv(\"KOALAS_USAGE_LOGGER\", \"\") != \"\"` here?", + "prediction": "I'm not sure if this is the right way to do this, but I think we should use `os.getenv(\"KOALAS_USAGE_LOGGER\", \"\")` instead of `os.getenv(\"KOALAS_USAGE_LOGGER\", None)`.", "reference": "Is this because \"KOALAS_USAGE_LOGGER\" can be `None` ??" }, { - "prediction": "I think this should be `public static readonly int _maxGasPrice = 500;` instead of `public static readonly UInt256 _maxGasPrice = 500;`", + "prediction": "I don't think this is needed anymore.", "reference": "I like it but maybe the better name will be EthGasPriceConstants or EthGasPriceEstimatorConstants? but Constants not Config" }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. If you want to create a new controller, you should create a new `Controller` object and pass it to the `NewController` function. If you want to create a new constructor, you should create a new `Constructor` object and pass it to the `NewConstructor` function.", "reference": "I would inline the constructor as well" }, { @@ -9031,19 +9031,19 @@ "reference": "I'm not confident about this..." }, { - "prediction": "I think this should be `v1alpha1.SchemeGroupVersion.WithKind(\"CertificateRequest\")` instead of `v1alpha1.SchemeGroupVersion.WithKind(\"CertificateRequest\")`", + "prediction": "I think this should be `v1alpha1.SchemeGroupVersion.WithKind(\"CertificateRequest\")` instead of `v1alpha1.SchemeGroupVersion.WithKind(\"CertificateRequest\")`.", "reference": "There is also `v1alpha1.CertificateRequestKind` I think?" }, { - "prediction": "I don't think we need to use the `baseJob` function here. We can just use the `SenderJob` and `BrokerSenderJob` functions directly.", + "prediction": "I don't think we need to do this.", "reference": "Can we rename it to make it less confusing? Instead of \"sender-gcpbroker\", maybe name it to \"retryable-sender\"" }, { - "prediction": "I'm not sure what you mean by \"literal().value().getClass().getName()\". Could you please provide more context?", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `Literal` class.", "reference": "So looking at the definition of the `literal()` function in this class, it seems it's possible for it to return null. I guess it's not a concern as we would get NPE on the above call at line 136 when trying to call `.to` if `literal()` returned `null` before even getting to this part that calls `literal().value()`, but something I thought I'd bring up. Perhaps something we might follow up on in another issue or possibly I just missed the workflow that makes `literal()`'s result non-null by the time this `bindLiteralOperration` is called." }, { - "prediction": "I'm not sure why this is here, but I think it should be moved to the end of the file.", + "prediction": "I think this should be `window` instead of `windowed`?", "reference": "Why did you break the line? It looks like it is under 80 characters without the break and it is inside parens so no need for backslash anyway" }, { @@ -9051,7 +9051,7 @@ "reference": "@guolinke Don't you mind to rename this variable to `DATATABLE_INSTALLED`, for the consistency with other variables (for example, there are `PANDAS_INSTALLED` but not `PD_INSTALLED`). Also, `DT` is a little bit confusing: sometimes `dt` is used for `datetime`." }, { - "prediction": "I think we should remove the `format_caller(example.location)` line, as it's not really necessary.", + "prediction": "I think this is a bit redundant. I think we should just use `@output.puts` here.", "reference": "We're fine with double quotes here. Just for future reference." }, { @@ -9059,7 +9059,7 @@ "reference": "can we keep this around? We should make sure we can distinguish between properly wrapped errors and \"unwrapped\" errors" }, { - "prediction": "I think this should be `if (graphicsPipelineCI.pInputAssemblyState)` instead of `if (graphicsPipelineCI.pInputAssemblyState && graphicsPipelineCI.pInputAssemblyState->topology)`", + "prediction": "I think this should be `if (graphicsPipelineCI.pInputAssemblyState)` instead of `if (graphicsPipelineCI.pInputAssemblyState)`.", "reference": "`RecordPipelineShaderStage()` might change `topology_at_rasterizer `, according to shader code, so we should check `pInputAssemblyState `first." }, { @@ -9067,31 +9067,31 @@ "reference": "Should we just inline the assets here? I can't think of an advantage to having them in a separate file." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `updateEndpoints` function.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `endpoints.go` instead of `endpointsChangesTracker.go`.", "reference": "detectStaleEndpoints to be more specific?" }, { - "prediction": "I'm not sure what you mean by `pySp.getRandomSP()`. Is this the same as `cppSp.getRandomSP()`?", + "prediction": "I'm not sure what you mean by `pySp.getRandomSP()`. Is this the same as `cppSp.getRandomSP()`, or is it something else?", "reference": "Please create a new issue for addressing this (if there isn't one already), so it doesn't get lost." }, { - "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to create a channel that will be used by the `PostGen` function, but I'm not sure what you're trying to do with it. Could you please explain what you're trying to do with this channel?", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to create a channel that will be used by the `PostGen` function, but it's not clear to me what you're trying to do with this channel. I think you're trying to create a channel that will be used by the `PostGen` function, but it's not clear to me what you're trying to do with this channel. I think you're trying to create a channel that will be used by the `PostGen` function, but it's not clear to me what you're trying to do with this channel. I think you're trying to create a channel that will be used by the `PostGen` function, but it's not clear to me what you're trying to do with this channel. I think you're trying to create a channel that will be used by the `PostGen` function, but it's not clear to me what you're trying to do with this channel. I think you're trying to create a channel that will be used by the `PostGen` function, but it's not clear to me what you're trying to do with this channel. I think you're trying to create a channel that will be used by", "reference": "Nothing was ever coming out of this channel because its already being consumed. Create a new channel here and feed it in HandleNewHead method." }, { - "prediction": "I'm not sure what you're trying to achieve with this snippet. It looks like you're trying to get the details for an AWS IAM policy, but I'm not sure what you're trying to achieve with this snippet. It looks like you're trying to get the details for an AWS IAM policy, but I'm not sure what you're trying to achieve with this snippet. It looks like you're trying to get the details for an AWS IAM policy, but I'm not sure what you're trying to achieve with this snippet. It looks like you're trying to get the details for an AWS IAM policy, but I'm not sure what you're trying to achieve with this snippet. It looks like you're trying to get the details for an AWS IAM policy, but I'm not sure what you're trying to achieve with this snippet. It looks like you're trying to get the details for an AWS IAM policy, but I'm not sure what you're trying to achieve with this snippet. It looks like you're trying to get the details for an AWS IAM policy, but I'm not sure what you're trying to achieve with this snippet. It looks like you're trying to get the details for an AWS IAM policy, but I'm not sure what you're trying", + "prediction": "I'm not sure what you're trying to achieve with this snippet, but it looks like you're trying to get the details for an AWS IAM policy. I'm not sure what you're trying to achieve with this snippet, but it looks like you're trying to get the details for an AWS IAM policy. I'm not sure what you're trying to achieve with this snippet, but it looks like you're trying to get the details for an AWS IAM policy. I'm not sure what you're trying to achieve with this snippet, but it looks like you're trying to get the details for an AWS IAM policy. I'm not sure what you're trying to achieve with this snippet, but it looks like you're trying to get the details for an AWS IAM policy. I'm not sure what you're trying to achieve with this snippet, but it looks like you're trying to get the details for an AWS IAM policy. I'm not sure what you're trying to achieve with this snippet, but it looks like you're trying to get the details for an AWS IAM policy. I'm not sure what you're trying to achieve with this snippet, but it looks like you're trying to get the details for an AWS IAM policy. I'm not sure what you're trying", "reference": "AWS Identity and Access Management (IAM)" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to start a new instance of the `EdgeDriverService` with a log file. I'm not sure what you're trying to achieve with this, but it looks like you're trying to start a new instance of the `EdgeDriverService` with a log file. I'm not sure what you're trying to achieve with this, but it looks like you're trying to start a new instance of the `EdgeDriverService` with a log file. I'm not sure what you're trying to achieve with this, but it looks like you're trying to start a new instance of the `EdgeDriverService` with a log file. I'm not sure what you're trying to achieve with this, but it looks like you're trying to start a new instance of the `EdgeDriverService` with a log file. I'm not sure what you're trying to achieve with this, but it looks like you're trying to start a new instance of the `EdgeDriverService` with a log file. I'm not sure what you're trying to achieve with this, but it looks like you're trying to start a new instance of the `EdgeDriverService` with a", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `Runtime.getRuntime().addShutdownHook(new Thread(() -> service.stop()));` line.", "reference": "This is deliberately at this level." }, { - "prediction": "I think we should use `hex.DecodeString` instead of `make([]byte, 2*len([]byte(args[2])))`", + "prediction": "`hex.DecodeString` returns a slice of bytes, not a slice of `[]byte`", "reference": "payload entered on command line is in hex-encoded format should use same processing as in ioctl/cmd/action/actiontransfer.go" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to create the demo pricing group first and then add it to the fixture.", + "prediction": "I don't think this is necessary.", "reference": "should this be kept in the `else` branch?" }, { @@ -9107,11 +9107,11 @@ "reference": "What is triggering this message in this file?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to close the `pool` after the `map_async` is done.", + "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to use the `pool.map_async` function to run the `check` function in parallel with the `analyzed_actions` list. However, the `pool.map_async` function returns a `Future` object, which is not what you want here. Instead, you should use the `pool.map` function to run the `check` function in parallel with the `analyzed_actions` list, and then use the `get` method to wait for the results.", "reference": "Are you sure this should be removed?" }, { - "prediction": "I don't think this is necessary. The `ProxySettings` constructor takes `true` as the second argument, so we don't need to pass it.", + "prediction": "I don't think this is needed anymore.", "reference": "What's that good for? The field is initialized in the constructor." }, { @@ -9123,55 +9123,55 @@ "reference": "No newline needed here." }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it should be in the same package as `kbfscodec` and `kbfscrypto`. I'm not sure if it's a good place to put this, but I think it should be in the same package as `kbfscodec` and `kbfscrypto`. I'm not sure if it's a good place to put this, but I think it should be in the same package as `kbfscodec` and `kbfscrypto`. I'm not sure if it's a good place to put this, but I think it should be in the same package as `kbfscodec` and `kbfscrypto`. I'm not sure if it's a good place to put this, but I think it should be in the same package as `kbfscodec` and `kbfscrypto`. I'm not sure if it's a good place to put this, but I think it should be in the same package as `kbfscodec` and `kbfscrypto`. I'm not sure if it's a good place to put this, but I think it should be in the same package as `kbfscodec` and `kbfscrypto`. I'm not sure", + "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to have a separate package for this. I'm not sure if this is a good place to put this, but I think it's a good idea to have a separate package for this. I'm not sure if this is a good place to put this, but I think it's a good idea to have a separate package for this. I'm not sure if this is a good place to put this, but I think it's a good idea to have a separate package for this. I'm not sure if this is a good place to put this, but I think it's a good idea to have a separate package for this. I'm not sure if this is a good place to put this, but I think it's a good idea to have a separate package for this. I'm not sure if this is a good place to put this, but I think it's a good idea to have a separate package for this. I'm not sure if this is a good place to put this, but I think it's a good idea to have a separate package for this. I'm not sure if this is a good place to put this, but I", "reference": "Why a separate block?" }, { - "prediction": "I think this should be `if (reg == DR_REG_TPIDRURW || reg == DR_REG_TPIDRURO)` instead of `if (reg == DR_REG_TPIDRURW || reg == DR_REG_TPIDRURO)`", + "prediction": "I'm not sure if this is a good idea, but I think it's better to return `OPSZ_NA` in this case. I don't think it's a good idea to return `OPSZ_SCALABLE` in this case, because it's not clear if this is a 32-bit register or a 64-bit register.", "reference": "Probably better to ask @AssadHashmi or another AArch64 expert for a review rather than me -- @AssadHashmi if you could confirm that these status registers are 64-bit despite having only a few fields?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to do anything like this.", + "prediction": "I'm not sure what you mean by `t = seed_type(seed)`. I think you meant to say `t = seed_type(seed, passphrase)`.", "reference": "`purpose` and `coin_type` and `account` would mimic the BIP-0044 wording, but it's up to you." }, { - "prediction": "I think this should be `rbQValueCustom.Select();` instead of `rbQValueCustom.Checked = true;`", + "prediction": "I think this should be `rbQValue01.Checked = true;` instead of `rbQValueCustom.Checked = true;`", "reference": "Is this the critical change? It does seem wrong to use Select() instead of Checked = true. Not sure why that would pass sometimes and not others, though." }, { - "prediction": "I think we can remove the `numCPUs` and `numCoresPerSocket` fields from the `MachinePool` struct. We can also remove the `OSDisk` field from the `MachinePool` struct.", + "prediction": "I think we can remove this line. It's not used anywhere in the code.", "reference": "Seems a little low, but is this an installer default?" }, { - "prediction": "I think this should be `six.text_type(value)` instead of `six.text_type(value)`", + "prediction": "I think this is just a hack to work around a bug in structlog. I don't think it's a good idea to do this.", "reference": "Maybe we could provide our own `configure` function that includes `logger._logger = None` because I don't see a use case in kinto for using `reset_logger` besides configuring the logger." }, { - "prediction": "I'm not sure what you're trying to achieve with this field, but I think we should remove it.", + "prediction": "I'm not sure what you mean by \"aggregate chain weight of the parent set\". Is it the sum of the weights of the parents?", "reference": "This will cause the same breakage that was caused when we added Proof to Block. Be sure to let people (infra?) know ahead of time" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `runtime.GC()` in this way. It's not a good idea to use `runtime.GC()` in this way. It's not a good idea to use `runtime.GC()` in this way. It's not a good idea to use `runtime.GC()` in this way. It's not a good idea to use `runtime.GC()` in this way. It's not a good idea to use `runtime.GC()` in this way. It's not a good idea to use `runtime.GC()` in this way. It's not a good idea to use `runtime.GC()` in this way. It's not a good idea to use `runtime.GC()` in this way. It's not a good idea to use `runtime.GC()` in this way. It's not a good idea to use `runtime.GC()` in this way. It's not a good idea to use `runtime.GC()` in this way. It's not a good idea to use `runtime.GC()` in this way. It's not a good idea to use `runtime.GC()` in this way. It's", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `runtime.GC()` in this way.", "reference": "Fixed the test; @strib want to validate that this is okay? Seems to be consistent new GC behavior." }, { - "prediction": "I'm not sure what you're trying to achieve with this test case. It seems like you're trying to validate that the `subdomain` field is present in the JSON account, but it's not. I think you're trying to validate that the `subdomain` field is present in the JSON account, but it's not. I think you're trying to validate that the `subdomain` field is present in the JSON account, but it's not. I think you're trying to validate that the `subdomain` field is present in the JSON account, but it's not. I think you're trying to validate that the `subdomain` field is present in the JSON account, but it's not. I think you're trying to validate that the `subdomain` field is present in the JSON account, but it's not. I think you're trying to validate that the `subdomain` field is present in the JSON account, but it's not. I think you're trying to validate that the `subdomain` field is present in the JSON account, but it's not. I think you're trying to validate that the `subdomain` field is present in the JSON account, but it's not. I think you're trying to", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to change the `subdomain` field to `subdom` in this case.", "reference": "Afaict, nothing cares" }, { - "prediction": "I think this should be moved to `reembedBlockChanges` instead of `reembedBlockChangesWithKeys`?", + "prediction": "I think we can remove the `pmd` and `rmdWithKeys` from the `reembedBlockChanges` function, since we don't need them in minimal mode.", "reference": "I must be missing something, but why does not having a node cache imply not neededing to re-embed the block changes, in particular? Isn't it just the fact that we don't do any writes?" }, { - "prediction": "I don't think this is necessary. The `NameValueCollection` class already has a `Add` method that does the same thing as the `Add` method in `System.Collections.Specialized.NameValueCollection`.", + "prediction": "I don't think this is necessary. The `NameValueCollection` class already has a `Add` method that does exactly what you want.", "reference": "Are these changes from `class` to `struct` breaking if called from an older version of `Datadog.Trace.ClrProfiler.Managed`?" }, { - "prediction": "I think this should be `List` instead of `List>`.", + "prediction": "I don't think this is needed anymore.", "reference": "These are just aliases now" }, { - "prediction": "I'm not sure what you're trying to achieve with this. It looks like you're trying to add a link to the \"All Videos\" page, but you're not using the `html_safe` method on the `← All Videos` link. I'm not sure what you're trying to achieve with this. It looks like you're trying to add a link to the \"All Videos\" page, but you're not using the `html_safe` method on the `← All Videos` link. I'm not sure what you're trying to achieve with this. It looks like you're trying to add a link to the \"All Videos\" page, but you're not using the `html_safe` method on the `← All Videos` link. I'm not sure what you're trying to achieve with this. It looks like you're trying to add a link to the \"All Videos\" page, but you're not using the `html_safe` method on the `← All Videos` link. I'm not sure what you're trying to achieve with this. It looks like you're trying to add a link to the \"All Videos\" page, but you're not using the `html_safe", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to use the `html_safe` method to escape the back link, but I don't think that's what you're trying to do. I think you're trying to use the `html_safe` method to escape the back link, but I don't think that's what you're trying to do. I think you're trying to use the `html_safe` method to escape the back link, but I don't think that's what you're trying to do. I think you're trying to use the `html_safe` method to escape the back link, but I don't think that's what you're trying to do. I think you're trying to use the `html_safe` method to escape the back link, but I don't think that's what you're trying to do. I think you're trying to use the `html_safe` method to escape the back link, but I don't think that's what you're trying to do. I think you're trying to use the `html_safe` method to escape the back link, but I don't think that's what you're trying to do. I think you're trying to use the `html_safe` method", "reference": "Does this mean we can remove `raw` from `_head_contents` partial?" }, { @@ -9179,11 +9179,11 @@ "reference": "`isDestroyed` is a function, not a property. This condition will always return false." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all known API versions. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all known API versions. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all known API versions. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all known API versions. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all known API versions. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all known API versions. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all known API versions. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all known API versions. I'm not sure what you're trying to achieve with this, but it looks", + "prediction": "I'm not sure what you mean by \"we know about\" here. I think it's more accurate to say \"we know about all of the known API versions\" or \"we know about all of the known API versions that we have access to\".", "reference": "Why are we adding these versions?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way", "reference": "fyi, you can do this by doing `.info(\"string %s %s\", formatparam, formatparam2)` instead of doing a string format with `\"str\" % (params)` the idea is that it'll only do the string interpolation if logging is enabled for this level, which theoretically is an optimisation, but in this case probably isn't important" }, { @@ -9191,31 +9191,31 @@ "reference": "Would this work, as a one liner? `setTimeout(window.location.reload, 5000);`" }, { - "prediction": "I'm not sure what you're trying to achieve with this code. It looks like you're trying to create a TLS connection to an Amazon ECS agent, but I'm not sure what you're trying to achieve with this code. Could you please provide more context or explain what you're trying to achieve with this code?", + "prediction": "I'm not sure what you mean by this, but it looks like you're trying to use the `tls` package to create a secure connection to the agent. However, I'm not sure what you're trying to achieve with this code. Could you please provide more context or explain what you're trying to accomplish with this code?", "reference": "Can you move `crypto/tls` into the block at the top with all the other stdlib imports?" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `anomalyScore` metric, which seems to be the same as the `multiStepBestPredictions` metric. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `anomalyScore` metric, which seems to be the same as the `multiStepBestPredictions` metric. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `anomalyScore` metric, which seems to be the same as the `multiStepBestPredictions` metric. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `anomalyScore` metric, which seems to be the same as the `multiStepBestPredictions` metric. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `anomalyScore` metric, which seems to be the same as the `multiStepBestPredictions` metric. I'm not sure what you're trying to achieve with this, but it looks like you're trying to", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `anomalyScore` metric here.", "reference": "What is the motivation for this change?" }, { - "prediction": "I think we can remove the `if no messages are available yet, it must block until there is at least one, or the context is done` part.", + "prediction": "I'm not sure what you mean by \"transient failure\" here. Is it something like a network error?", "reference": "OK, so the concrete implementation will loop? But then it's important that this method waits for a while before it returns no messages. To be specific, a GCP implementation that set `ReturnImmediately` to true or false would both satisfy this requirement, but the first would cause busy-waiting." }, { - "prediction": "I'm not sure what you mean by \"multi paths not supported.\" I think it's just that you can't have more than 1 path in a match clause.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this.", "reference": "The data structure of `MatchClauseContext` may need to be redesigned." }, { - "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to send a bunch of messages to a channel and then receive them back. Is this what you're trying to do? If so, how are you sending the messages and how are you receiving them?", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to compare two sets of messages, but I'm not sure what you're trying to compare them to.", "reference": "You say on the issue that something has to be receiving while the messages are being published. But here it's possible that the publish goroutine starts, and maybe even completes, before Receive is ever called." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `proposal` model.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do it here.", "reference": "how do we know that the step in question is an approval type step?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea to add a `@ThreadSafe` annotation to a class that is not intended to be used in a thread-safe manner.", + "prediction": "I don't think this is necessary. The `ManagedObject` class is not used anywhere in the code. It's just there for the sake of completeness.", "reference": "JMX offers normal APIs for this. I don't think you want the glassfish one." }, { @@ -9223,7 +9223,7 @@ "reference": "Is this still Java 8 compatible? @danieldietrich do we need a separate, modularized Java 9 release also?" }, { - "prediction": "I'm not sure if this is correct, but I think it should be `samplerDescriptor.filter_mode = HSA_EXT_SAMPLER_FILTER_MODE_LINEAR;` and `samplerDescriptor.address_mode = HSA_EXT_SAMPLER_ADDRESSING_MODE_CLAMP_TO_EDGE;`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `hipCreateImageObject` as well.", "reference": "Should update the user input address and filter modes and pass those in fillSamplerDescriptor ?" }, { @@ -9231,39 +9231,39 @@ "reference": "This object should be in `lib/music/show.rb` and you should also wrap this object in the `Faker::Music::Show`." }, { - "prediction": "I think this should be `if task.supports_noop` instead of `if task.supports_noop && task.supports_noop?`", + "prediction": "I think this should be `if task.supports_noop` instead of `if task.supports_noop && use_args['_noop'] = true`", "reference": "I think logic will have to move to bolt since the vague discussions around bolt run plan --noop is that it would just skip any tasks that don't support_noop rather than error. This is fine until we actually elaborate that though." }, { - "prediction": "I don't think this is necessary. We can just use `types.Address` instead of `address.Address`.", + "prediction": "I don't think this is necessary. `types.Address` already has a `ToString` method.", "reference": "File is not `goimports`-ed" }, { - "prediction": "I'm not sure I understand what you're trying to do with this test. It's not clear to me what you're trying to test here.", + "prediction": "I think we can remove the `headers=self.headers` in this test.", "reference": "why should unknown raise a 403?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `pre-render` lifecycle method.", "reference": "The true clause of your condition, can't this just be c._nextState since `assign({}, c._nextState)` is equal to returning c._nextState, or am I misunderstanding something here?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. The `max_results_admin_api` should be set to 100000, not 500. Also, the `max_admin_api_calls_per_day` should be set to 150000, not 100000.", + "prediction": "I'm not sure what you mean by `max_results_admin_api`. Is it related to the number of results returned by the Admin SDK list() method?", "reference": "nit: align the leftmost quotes" }, { - "prediction": "I think we can remove the `EnablePrometheusMetrics` field since it's not used anymore.", + "prediction": "I think we can remove the `EnablePrometheusMetrics` field, as it's not used anywhere.", "reference": "Probably \"server port\" -> \"TCP port\"" }, { - "prediction": "I think this should be `this.storedFieldsFormat = new Lucene50StoredFieldsFormat(Objects.requireNonNull(mode));` instead of `this.storedFieldsFormat = new Lucene50StoredFieldsFormat(Objects.requireNonNull(mode));`", + "prediction": "I think this should be `this.storedFieldsFormat = new Lucene80StoredFieldsFormat(Objects.requireNonNull(mode));`", "reference": "can you use FilterCodec instead?" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `Settings` model.", + "prediction": "I'm not sure if this is the best place to put this, but I think it would be good to have a separate setting for this.", "reference": "I know there's only two values but I find it a bit confusing that it's true/false. Could you change it to a string enum with values \"portrait\" and \"landscape\"? Then when calling printToPdf you can just do `landscape: Setting.value('export.pdfPageOrientation') === 'landscape'`" }, { - "prediction": "I think we should remove the `CommitProgress` handler from the `db_schema_version2` migration.", + "prediction": "I think we should remove the `up` function from this migration, as it's no-op.", "reference": "I think this migration should fail for MDBX if it uses old table names" }, { @@ -9271,23 +9271,23 @@ "reference": "Should this be negated? `!@options[:hosts_file].nil?` Otherwise it'll enter the `if` statement and `nil` will be passed to `HostsFileParser.parse_hosts_file`, which I'm assuming is bad." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have this in a separate class, so that we don't have to call this method every time we want to load a config.", + "prediction": "I think this should be `LoadConfiguration` instead of `LoadConfigurationBuilder`?", "reference": "I'm doubting if adding a bool here is a good idea. Maybe it should be an option object? Otherwise it's hard to extend. But an option object is a bit strange in a fluent API? What do you think @snakefoot ?" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bad idea to extend `PostingsEnum` here. It would be better to create a new enum class for this purpose.", + "prediction": "I don't think this is needed anymore.", "reference": "This is used in o.a.l.sandbox.search.PhraseWildcardQuery." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea to have a `protocolView` in the `StateDB` struct. It's not used anywhere in the code, and it's not necessary to have a `protocolView` in the `StateDB` struct. I think it would be better to have a separate `StateDBProtocol` struct that has a `protocolView` field, and then use that in the `StateDB` struct.", "reference": "view should be loaded on start for both statedb and factory" }, { - "prediction": "I don't think this is necessary. We can remove the `Task` from the `ConnectionFilterContext` now.", + "prediction": "I don't think this is needed anymore.", "reference": "Why rename? Just curious..." }, { - "prediction": "I don't think we need to use `super.onStopTrackingTouch(seekBar);` here, since `onStopTrackingTouch(seekBar)` is already called in `onStartTrackingTouch(seekBar);`", + "prediction": "I don't think we need to use `super.onStopTrackingTouch(seekBar);` here, since `onStopTrackingTouch(seekBar)` is called by `onStartTrackingTouch(seekBar);`", "reference": "Is this needed? I think it calls the super function that already does that." }, { @@ -9295,15 +9295,15 @@ "reference": "This might slow down the inference time, are we sure we need to do that?" }, { - "prediction": "I'm not sure what you mean by `PRAGMA(gocloud.dev): Skip until next blank line.`. I think you meant to say `PRAGMA(gocloud.dev): Add a blank import: _ \"gocloud.dev/mysql/awsmysql\"`.", + "prediction": "I'm not sure if this is a good idea, but I think it's better to have a blank import at the top of the file.", "reference": "This would read better if you add \"Skip code/lines\" or (exclude/hide code if you follow my earlier suggestion\")" }, { - "prediction": "I think this should be `getStorageIO` instead of `getStorageIO`", + "prediction": "I think this should be `getStorageIO()` instead of `getStorageIO()`.", "reference": "Looks like glassfish went a bit nuts doing a refactor" }, { - "prediction": "I think this is a good idea, but I'm not sure if it's the best way to do it. It's not clear to me what the `ForceFlushAsync` method is supposed to do, and it's not clear to me what the `Task.WhenAll` method is supposed to do. It's not clear to me what the `ForceFlushAsync` method is supposed to do, and it's not clear to me what the `Task.WhenAll` method is supposed to do. It's not clear to me what the `ForceFlushAsync` method is supposed to do, and it's not clear to me what the `Task.WhenAll` method is supposed to do. It's not clear to me what the `ForceFlushAsync` method is supposed to do, and it's not clear to me what the `Task.WhenAll` method is supposed to do. It's not clear to me what the `ForceFlushAsync` method is supposed to do, and it's not clear to me what the `Task.WhenAll` method is supposed to do. It's not clear to me what the `ForceFlushAsync` method is supposed to do, and it's not clear to me what the `Task.WhenAll` method is supposed to do", + "prediction": "I think this is a good idea, but I'm not sure if it's the best way to do it. I think it's better to have a separate `FlushAsync` method that takes a `Task` as a parameter. That way, you don't have to call `FlushAsync` multiple times.", "reference": "nit: allocate the list using the number of processors." }, { @@ -9311,11 +9311,11 @@ "reference": "Was this change triggered by baseline?" }, { - "prediction": "I think we can remove the `with_commits_and_affiliates` method.", + "prediction": "I think we can remove the `with_commits_and_affiliates` method and just use the `with_thirty_day_commit_count` method.", "reference": "This code was doing nothing as far as I can tell and was making the SQL find nothing with the new version of Rails. Remove it unless someone can explain why it is there." }, { - "prediction": "I'm not sure what you mean by \"un-comment the line below to enable push notifications in this app.\"", + "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to enable push notifications in this app. I'm not sure if this is a good idea or not, but I think it's a good idea to enable push notifications in this app. I'm not sure if this is a good idea or not, but I think it's a good idea to enable push notifications in this app. I'm not sure if this is a good idea or not, but I think it's a good idea to enable push notifications in this app. I'm not sure if this is a good idea or not, but I think it's a good idea to enable push notifications in this app. I'm not sure if this is a good idea or not, but I think it's a good idea to enable push notifications in this app. I'm not sure if this is a good idea or not, but I think it's a good idea to enable push notifications in this app. I'm not sure if this is a good idea or not, but I think it's a good idea to enable push notifications in this app. I'm not sure if this is a good idea or not, but I think it's a good idea to enable push", "reference": "Setting browser based login as the default for `RestAPIExplorer`." }, { @@ -9323,43 +9323,43 @@ "reference": "maybe we can do this in Init function?" }, { - "prediction": "I don't think we need to validate the request ID here. It's already checked in the `validateExecution` function.", + "prediction": "I don't think we need to check for `request.GetRequestId() == \"\"` in this case, since it's already checked in the `validateExecution` function.", "reference": "How about if request ID not set, service should generate a random uuid?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a test for this.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's important to make sure that the `performUpdateHandler` function is called with the correct arguments, and that the `performUpdateHandler` function is called with the correct arguments, and that the `performUpdateHandler` function is called with the correct arguments, and that the `performUpdateHandler` function is called with the correct arguments, and that the `performUpdateHandler` function is called with the correct arguments, and that the `performUpdateHandler` function is called with the correct arguments, and that the `performUpdateHandler` function is called with the correct arguments, and that the `performUpdateHandler` function is called with the correct arguments, and that the `performUpdateHandler` function is called with the correct arguments, and that the `performUpdateHandler` function is called with the correct arguments, and that the `performUpdateHandler` function is called with the correct arguments, and that the `performUpdateHandler` function is called with the correct arguments, and that the `performUpdateHandler` function is called with the correct arguments, and that the `performUpdateHandler` function is called with the correct arguments, and that the `performUpdateHandler` function is", "reference": "minor: this is an opportunity for you to split these long lines into multiple lines :)" }, { - "prediction": "I don't think this is a good idea.", + "prediction": "I don't think we need to raise an exception here. We can just return an empty list.", "reference": "It would be nice to have exception dumped somewhere (debug logs, info logs)." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bit of a misnomer to call it a \"provider-specific type\". It's more like a \"provider-specific message type\".", + "prediction": "I'm not sure what you mean by \"provider-specific types\". Is there a specific provider that you want to expose? If so, please let me know and I'll update the docs accordingly. Otherwise, I'm not sure what you mean by \"provider-specific types\". Is there a specific provider that you want to expose? If so, please let me know and I'll update the docs accordingly. Otherwise, I'm not sure what you mean by \"provider-specific types\". Is there a specific provider that you want to expose? If so, please let me know and I'll update the docs accordingly. Otherwise, I'm not sure what you mean by \"provider-specific types\". Is there a specific provider that you want to expose? If so, please let me know and I'll update the docs accordingly. Otherwise, I'm not sure what you mean by \"provider-specific types\". Is there a specific provider that you want to expose? If so, please let me know and I'll update the docs accordingly. Otherwise, I'm not sure what you mean by \"provider-specific types\". Is there a specific provider that you want to expose? If so, please let me know and I'll update the docs accordingly. Otherwise, I'm not sure what you mean by \"provider", "reference": "So I don't think this is right, as discussed on #657." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get a list of all users in a specific group. I'm not sure what you're trying to do here, but it looks like you're trying to get a list of all users in a specific group. I'm not sure what you're trying to do here, but it looks like you're trying to get a list of all users in a specific group. I'm not sure what you're trying to do here, but it looks like you're trying to get a list of all users in a specific group. I'm not sure what you're trying to do here, but it looks like you're trying to get a list of all users in a specific group. I'm not sure what you're trying to do here, but it looks like you're trying to get a list of all users in a specific group. I'm not sure what you're trying to do here, but it looks like you're trying to get a list of all users in a specific group. I'm not sure what you're trying to do here, but it looks like you're trying to get a list of all users in a specific group. I'm not sure what you're trying", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get a list of all users in a group. I think you want to get a list of all members in a group, right? If that's the case, you can use the `group_members_{0}` and `group_members_{1}` queries to get the list of users and members in a group, respectively.", "reference": "should the group_id = \"{0}\" be group_id = %s You'd still keep the {} for the group_members_{} for the tablename but make the filter clause parameterized." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check for `file_dict.get(\"path\", path_exc)` to make sure that `path_exc` is not `None` and that `file_dict.get(\"path\", path_exc)` is not `None` as well.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if `file_dict.get(\"path\", path_exc)` is `None`. If it is, then we should raise an exception.", "reference": "Path can contain variable pattern in the middle. Also, `$` is not enough to tell if this is JMeter variable. We have correct variable detecting somewhere in our code." }, { - "prediction": "I don't think this is a good idea. It would be better to have a `static` method in the `FormHelper` class. This would make it easier to add new methods to the `FormHelper` class without having to modify the `FormTestModel` class. It would also make it easier to add new methods to the `FormTestModel` class without having to modify the `FormHelper` class.", + "prediction": "I don't think this is necessary. The `static` and `method` options are already defined in the `FormTestModel` class, so we don't need to add them to the `FormHelper` class.", "reference": "@bennothommo can you revert this section? It shouldn't be required." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to do something like this: `total_price = total_price + 100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", "reference": "Minor: maybe move the above to a `#fiscal_year` method?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this.", + "prediction": "I think this test should be moved to a separate test case.", "reference": "You should use the current directory instead - it's a temporary directory that will get removed when the test is done." }, { - "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `Thread.sleep()` to wait for the thread to finish. This way, we don't have to wait for the thread to finish, and we don't have to worry about race conditions.", + "prediction": "I think we can remove the `thread.join()` here, since the `onExecutionEvent` method is called synchronously.", "reference": "I think we don't need synchronization here." }, { @@ -9371,23 +9371,23 @@ "reference": "Maybe this `if` should be on line 118?" }, { - "prediction": "I think we can remove the `float64` from the `bucketCounts` field.", + "prediction": "I'm not sure what you're trying to do here. I don't think we need to change the `bucketCounts` field at all.", "reference": "Cool. (I thought I had fixed this already in #812.)" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to have a `service-url` in the `TRANSPORT_SPECIFIC_DEFAULTS` hash. I think it's better to have a `service-url` in the `TRANSPORT_OPTIONS` hash.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to have `service-url` in the `TRANSPORT_SPECIFIC_DEFAULTS` hash. I think it's better to have `service-url` in the `TRANSPORT_OPTIONS` hash.", "reference": "I intend to do this as soon as I have tests passing." }, { - "prediction": "I think this should be `with open(os.environ['QUTE_FIFO'], 'wb') as fifo: fifo.write(b':message-info \"stdin closed\"\\n')`", + "prediction": "I don't think this is necessary. We can just use `sys.stdin.close()` instead of `sys.stdin.read()`.", "reference": "Please remove the `test_*` from the filename - otherwise pytest will try to collect tests from it." }, { - "prediction": "I think this should be `if (!en)` instead of `if (!udev_enumerate_new(session->udev))`", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `udev_enumerate_new` instead of `udev_enumerate_new_fd` in this case. `udev_enumerate_new_fd` doesn't return anything, but `udev_enumerate_new` does. `udev_enumerate_new_fd` is only used for testing, so I think it's better to use `udev_enumerate_new` in this case.", "reference": "Did you file a bug to follow up on this?" }, { - "prediction": "I think this should be `TableProperties.PARQUET_VECTORIZATION_ENABLED_DEFAULT` instead of `TableProperties.PARQUET_VECTORIZATION_ENABLED`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that `batchReadsEnabled` is set to `false` if `batchReadsSparkSessionConf` is `false` or `true` if `batchReadsEnabledTableProp` is `false` or `true` if `batchReadsEnabledTableProp` is `false` or `true` if `batchReadsEnabledTableProp` is `false` or `true` if `batchReadsEnabledTableProp` is `false` or `true` if `batchReadsEnabledTableProp` is `false` or `true` if `batchReadsEnabledTableProp` is `false` or `true` if `batchReadsEnabledTableProp` is `false` or `true` if `batchReadsEnabledTableProp` is `false` or `true` if `batchReadsEnabledTableProp` is `false` or `true` if `batchReadsEnabledTableProp` is `false` or `true` if `batchReadsEnabledTableProp` is `false` or `true` if `batchReadsEnabledTableProp` is `false` or", "reference": "Looks like these 4 lines didn't actually change. Can you revert the whitespace changes here?" }, { @@ -9399,59 +9399,59 @@ "reference": "It would be nice to fix the indentation above." }, { - "prediction": "I'm not sure what you mean by `short_names` being `bool|null`. I think you meant to say `short_names` is `bool` and `binary` is `null`.", + "prediction": "I don't think this is needed anymore.", "reference": "`short_names` is still optional, so `=` that indicates it has to stay there." }, { - "prediction": "I think we can remove the `attributePrefix` from the `appendFirelensFluentbitCapabilities` and `appendEFSCapabilities` functions.", + "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to use the `appendNameOnlyAttribute` function here.", "reference": "missing calling of this method" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's the best way to do it. It's a bit of a hack, and I'm not sure if it's the best way to do it. I'm not sure if it's the best way to do it. I'm not sure if it's the best way to do it. I'm not sure if it's the best way to do it. I'm not sure if it's the best way to do it. I'm not sure if it's the best way to do it. I'm not sure if it's the best way to do it. I'm not sure if it's the best way to do it. I'm not sure if it's the best way to do it. I'm not sure if it's the best way to do it. I'm not sure if it's the best way to do it. I'm not sure if it's the best way to do it. I'm not sure if it's the best way to do it. I'm not sure if it's the best way to do it. I'm not sure if it's the best way to do it. I'm not sure if it's the", + "prediction": "I think we can remove the `github.com/aws/amazon-ecs-cli-v2/internal/pkg/deploy/cloudformation` package and just use `github.com/aws/aws-sdk-go/service/cloudformation`", "reference": "We could get rid of this dependency being forced on clients by changing the `StackConfiguration` interface abstraction to deal with strings instead of `cloudformation.Parameters` and `cloudformation.Tags`, and internally to the `cloudformation` package translate the input strings into the `service/cloudformation` package specific values hiding that from consumers. I don't think that should be taken on as part of this PR, but I think we should consider doing it at some point." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to add a `duration` column to the stresschaos object, but I'm not sure what you're trying to do with it. I think you're trying to add a `duration` column to the stresschaos object, but I'm not sure what you're trying to do with it. I think you're trying to add a `duration` column to the stresschaos object, but I'm not sure what you're trying to do with it. I think you're trying to add a `duration` column to the stresschaos object, but I'm not sure what you're trying to do with it. I think you're trying to add a `duration` column to the stresschaos object, but I'm not sure what you're trying to do with it. I think you're trying to add a `duration` column to the stresschaos object, but I'm not sure what you're trying to do with it. I think you're trying to add a `duration` column to the stresschaos object, but I'm not sure what you're trying to do with it. I think you're trying to add a `duration` column to", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `chaos-mesh` package.", "reference": "`StressChaos` does not contains a field .spec.action" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here,", + "prediction": "I'm not sure what you mean by \"different TKeyedArray\" here. Could you please clarify?", "reference": "Non-int literal strings are no longer coercible to int, I think this is an improvement. Without this change it now reports `InvalidArgument`." }, { - "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to use the `MessageIdFilter` class to filter messages based on a filter string. However, the `MessageIdFilter` class doesn't seem to have a `filter_string` member variable, so I'm not sure what you're trying to do with it. Could you please provide more context or clarify your question?", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `const char *` for the `filter_string` argument.", "reference": "I this used anyplace?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think we need to change anything here.", + "prediction": "I'm not sure what you mean by \"max worker threads\" in this context. Is it the number of worker threads that are allowed to run at the same time, or is it the number of threads that are allowed to run at the same time? If it's the number of threads allowed to run at the same time, then I think we need to change the `maxWorkerThreads` to `maxWorkerThreads(8)`. If it's the number of worker threads that are allowed to run at the same time, then I think we need to change the `maxWorkerThreads` to `maxWorkerThreads(3)`.", "reference": "Why was this change required?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I don't think this is a good idea. The `missingAdminRole` property should be a boolean, not a `List`.", "reference": "I like that we have this attribute here. However, I think the way we use it right now might be confusing in the future. For example, when only camunda admin is checked, this exception will be instantiated with a message and `missingAdminRole` is `false`. I think that is counter-intuitive. I would expect this exception to have `missingAdminRole` set to `true`. With this explicit information, the exception message could now be generated inside this exception class with the text block that is currently used in the authorization manager. We could maybe generally reuse that text block then also for the case where a user is no admin and also has none of the required permissions. I haven't tried it myself but I think it would be great if we could streamline those things a bit more if we're working on it now. Let me know what you think." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `__assign` here. I think you want to use `__init` here.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `__init` method in the `Monster` class. This way, we don't have to call `MonsterBufferHasIdentifier` every time we create a `Monster` object.", "reference": "Not sure why we're creating a new `ByteBuffer` here, ideally this refers to the existing one?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `Data` component.", + "prediction": "I don't think we need to use `generateDateRangeArgs` here. We can just use `getNoDataComponent` and `getDataErrorComponent` directly.", "reference": "Same here re: `STORE_NAME` to `MODULES_SEARCH_CONSOLE`." }, { - "prediction": "I don't think we need to use the existing tag here, we can just use the default one.", + "prediction": "I don't think we need to use the existing tag for this test.", "reference": "I could've sworn I got a `403` myself when I got that response locally. Is `200` what the API would send back for a `permission: false` tag?" }, { - "prediction": "I think we can remove `NewIdentityManager(keydir string)` and just use `NewIdentityManager()` instead.", + "prediction": "I think we can remove the `NewIdentityManager(keydir string)` function and just use the `NewIdentityManager()` function in the `identityManager` struct.", "reference": "This attribute was intentionally private. - lets force usage of factory `NewIdentityManager()` - lets ramake to `NewIdentityManager(keydir string)` -> `NewIdentityManager(keystore keystoreManager)`" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a default value for `maxConnectRetries` and `connectRetryDelay` so that we don't have to specify them every time we create a new `Inbound` instance.", "reference": "Is this too frequent?" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new class that extends the `UploadModel` class and adds a new property called `fileExtension`. However, there are a few issues with your code:\n\n 1. You're trying to extend the `UploadModel` class, but the `UploadModel` class doesn't have a `fileExtension` property.\n 2. You're trying to add a new property called `fileExtension` to the `UploadModel` class, but the `UploadModel` class doesn't have a `fileExtension` property.\n 3. You're trying to extend the `UploadModel` class, but the `UploadModel` class doesn't have a `fileExtension` property.\n 4. You're trying to add a new property called `fileExtension` to the `UploadModel` class, but the `UploadModel` class doesn't have a `fileExtension` property.\n 5. You're trying to extend the `UploadModel` class, but the `UploadModel` class doesn't have a `fileExtension` property.\n 6. You're trying to add a new property called `fileExtension` to the", + "prediction": "I don't think we need to change this.", "reference": "will this not make it possible to use a zip file, e.g. on other importers who do not have to support it ?" }, { @@ -9459,15 +9459,15 @@ "reference": "Needs to be mentioned in `__all__` below." }, { - "prediction": "I think this should be `is_repeat_handle_pre_extended_syscall_sigmasks(dcontext)` instead of `is_repeat_handle_pre_extended_syscall_sigmasks(dcontext, kernel_sigset_t *sigmask, size_t sizemask)`.", + "prediction": "I think this should be `is_repeat_handle_pre_extended_syscall_sigmasks` instead of `is_repeat_handle_pre_extended_syscall_sigmasks_sigmasks`.", "reference": "What if the app's signal handler, executed at pre-syscall for epoll_pwait, executes its own epoll_pwait? For that matter: what happens natively if that happens? I would not expect the kernel to keep a stack -- does that clobber the kernel's stored pre-syscall mask?" }, { - "prediction": "I'm not sure what you mean by \"when available, this information is used for planning scan tasks whose boundaries are determined by these offsets.\"", + "prediction": "I'm not sure if this is the right place to put this, but I think we should put it in the `DataFile` interface.", "reference": "Nit: missing a space. I think we should phrase the new content a little differently. \"It is important\" isn't very clear. I think it should be \"offsets will be returned in sorted order.\"" }, { - "prediction": "I'm not sure what you're trying to achieve with this code. It looks like you're trying to encode and decode JSON data, but I'm not sure what you're trying to achieve with this code. Could you please provide more context or explain what you're trying to achieve with this code?", + "prediction": "I don't think we need to use `json` here. We can just use `base64` and `hex` for now.", "reference": "Can you remove this blank line and put the added import in sorted order (likely your editor will do this)" }, { @@ -9479,67 +9479,67 @@ "reference": "I like introduction of these constants for account/container creation, but the `ACCOUNT_CHOOSE` one isn't needed I think. This should instead be an \"empty\" value (either `''` or `0`), to indicate more clearly that this field is not filled. It should be the same for choosing a container." }, { - "prediction": "I think this should be `localeCompare` instead of `localeCompare`", + "prediction": "I think this should be `undefined` instead of `null`.", "reference": "I noticed that passing in `[]` for the locales argument instead of 'undefined' seems to have the same effect. I think that's preferred over passing in `undefined` as a value, and unfortunately passing in `null` seems to throw an error." }, { - "prediction": "I'm not sure what you mean by \"looks like a unix socket\". I think you meant to say \"looks like a unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like a unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like", + "prediction": "I'm not sure what you mean by \"looks like a unix socket\". I think you meant to say \"looks like a unix socket\" or \"looks like a Unix socket\" or \"looks like a Unix socket\" or \"looks like a unix socket\" or \"looks like a unix socket\" or \"looks like a unix socket\" or \"looks like a unix socket\" or \"looks like a unix socket\" or \"looks like a unix socket\" or \"looks like a unix socket\" or \"looks like a unix socket\" or \"looks like a unix socket\" or \"looks like a unix socket\" or \"looks like a unix socket\" or \"looks like a unix socket\" or \"looks like a unix socket\" or \"looks like a unix socket\" or \"looks like a unix socket\" or \"looks like a unix socket\" or \"looks like a unix socket\" or \"looks like a unix socket\" or \"looks like a unix socket\" or \"looks like a unix socket\" or \"looks like a unix socket\" or \"looks like a unix socket\" or \"looks like a unix socket\" or \"looks like a unix socket\" or \"looks like a unix socket\" or \"looks like a unix socket\" or \"looks like", "reference": "1. `0` is redundant. 2. We should save result of `strings.LastIndex(DbCfg.Host, \":\")` to a variable and reuse." }, { - "prediction": "I don't think we need to add `DisableShortFirstPing` to the `Options` struct.", + "prediction": "I think we should remove `NoHeaderSupport` as it is not used anywhere.", "reference": "Do you envision \"new\" servers not supporting header, or is it more a way to test mix of old and new? If so, we could make it a \"private\" (non exported) option." }, { - "prediction": "I'm not sure what you mean by \"failed to unmarshal connection config\". I think you meant to say \"failed to unmarshal session config\".", + "prediction": "I'm not sure if this is the right place to do this, but I think we should probably move this to the `connection` package.", "reference": "For future reference. Try not to do refactoring in the same PR which solves some bug or implements some feature. Not to clutter reading. Do it in separate PR." }, { - "prediction": "I'm not sure what you're trying to achieve with this flag. It's not clear what it's used for. I'm not sure what you're trying to achieve with this flag. It's not clear what you're trying to achieve with this flag. I'm not sure what you're trying to achieve with this flag. I'm not sure what you're trying to achieve with this flag. I'm not sure what you're trying to achieve with this flag. I'm not sure what you're trying to achieve with this flag. I'm not sure what you're trying to achieve with this flag. I'm not sure what you're trying to achieve with this flag. I'm not sure what you're trying to achieve with this flag. I'm not sure what you're trying to achieve with this flag. I'm not sure what you're trying to achieve with this flag. I'm not sure what you're trying to achieve with this flag. I'm not sure what you're trying to achieve with this flag. I'm not sure what you're trying to achieve with this flag. I'm not sure what you're trying to achieve with this flag. I'm not sure what you're trying to achieve with this flag. I'm not sure what you're trying", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate flag for the asset unit name, so that we don't have to use `assetUnitName` in `infoAssetCmd.Flags().StringVar(&assetUnitName, \"unit\", \"\", \"Unit name of the asset to look up\")`.", "reference": "I'm not sure about changing the flag name. unit is more accurate, but for I think for most people asset is also a fine name to use." }, { - "prediction": "I think this should be `if getConsoleWindow.Find() == nil && showWindow.Find() == nil {`", + "prediction": "I think this should be `if getConsoleWindow.Find() == nil && showWindow.Find() == nil` instead of `if getConsoleWindow.Find() == nil && showWindow.Find() == nil && getConsoleWindow.Call() == nil && showWindow.Call() == nil`", "reference": "Which windows gets activated? A random other window?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to upgrade to the latest version of cloudevents. It's not clear to me if this is the right place to do this, but I think it's a good idea to upgrade to the latest version of cloudevents. It's not clear to me if this is the right place to do this, but I think it's a good idea to upgrade to the latest version of cloudevents. It's not clear to me if this is the right place to do this, but I think it's a good idea to upgrade to the latest version of cloudevents. It's not clear to me if this is the right place to do this, but I think it's a good idea to upgrade to the latest version of cloudevents. It's not clear to me if this is the right place to do this, but I think it's a good idea to upgrade to the latest version of cloudevents. It's not clear to me if this is the right place to do this, but I think it's a good idea to upgrade to the latest version of cloudevents. It's not clear to me", + "prediction": "I think this should be `if _, r, err := a.outbound.Send(ctx, event); err != nil {` instead of `if _, r, err := a.outbound.Send(ctx, event); err != nil {`", "reference": "Just to make sure, this is totally lossless? If I put a v2 there, then it gets upgraded to v3, but my function expects v2, then this is fine and nothing is lost?" }, { - "prediction": "I think it's better to use `default` for `MERGE_CARDINALITY_CHECK_ENABLED` and `MERGE_CARDINALITY_CHECK_ENABLED_DEFAULT` instead of `true` and `false`.", + "prediction": "I think it's better to use `default` for `MERGE_CARDINALITY_CHECK_ENABLED` and `default` for `WATERMARK_VALUE` instead of `MERGE_CARDINALITY_CHECK_ENABLED_DEFAULT` and `WATERMARK_VALUE_DEFAULT`.", "reference": "In the past, we have 3 Flink streaming jobs (1 for each AWS region) writing to the same table. We need to write to 3 different watermark table properties (1 for each region). Watermark consumer then use the min value to determine the overall table watermark. A provider pattern similar to `WRITE_LOCATION_PROVIDER_IMPL` can work. A default impl could be a single property name. not sure if there is a simpler way to achieve this." }, { - "prediction": "I'm not sure I understand what you're trying to do here.", + "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do it.", "reference": "Can you change this to `ResolvedUsersMap` and build a new map with both readers/writers? That way, we get the nice side effect of not exposing the internal map of the handle, and simplifying the callers a bit." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `useUnifiedTopology: true` in the `MongoClient.connect` call.", + "prediction": "I'm not sure if this is the right way to do this, but I think we should use the `options.cryptdConnectionString` instead of `mongoClient.s.options.cryptdConnectionString`.", "reference": "I typically try to avoid nested ternary expressions. Can we rewrite this as if statements? Worst case, can we break it out into its own function?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to set the host name in the TLS context.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to set the host name in the `tlsext_host_name` field of the `tlsext_host_name` field of the `tlsext_host_name` field of the `tlsext_host_name` field of the `tlsext_host_name` field of the `tlsext_host_name` field of the `tlsext_host_name` field of the `tlsext_host_name` field of the `tlsext_host_name` field of the `tlsext_host_name` field of the `tlsext_host_name` field of the `tlsext_host_name` field of the `tlsext_host_name` field of the `tlsext_host_name` field of the `tlsext_host_name` field of the `tlsext_host_name` field of the `tlsext_host_name` field of the `tlsext_host_name` field of the `tlsext_host_name` field of the `tlsext_host_name` field of the `tlsext_host_name` field of the `tlsext_host_name` field of the `tlsext_host_name`", "reference": "Do we still support handshakes without SNI present?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to `Substitutors` instead of `Substitutors::Substitutors`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this", "reference": "Maybe it's because I work too much on a centralized logging system but it could be great to add a \"category\" like \"attribute\", \"substitution\", \"include directive\", \"macro\", \"extension\"..." }, { - "prediction": "I think it's better to use `replace` instead of `replace(\" \", \"\")` and `replace(\"*\", \"\")` because `replace(\" \", \"\")` is faster than `replace(\"*\", \"\")`.", + "prediction": "I don't think it's necessary to remove the \"*\" from the name.", "reference": "it have no sense in python -> it makes no sense in python" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a pool that will provide ports from 40000-50000, but then you're trying to open a port on port 40000, which is not allowed.", + "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do with this port pool. If you want to create a port pool that will provide ports from range 40000-50000, you should create a `Pool` struct that has a `start` and `capacity` field, and a `Acquire` method that returns a `Port` and an error.", "reference": "maybe just do a separate implementation of the pool for openvpn case? It's a bit confusing having two methods here." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to close the connection to the MongoDB server, but you're not closing the connection to the topology server.", "reference": "how is it possible to have a `topology` that is falsey when we had to call `topology.connect` in order to get here?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the `current_churn` is set in the `PlanFinder` before calling `get :show, format: :json, sku: 'sku'`. This way, we can make sure that the `current_churn` is set to the correct value before trying to get the churn for the requested plan.", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to mock the `where` method of `PlanFinder`, but I'm not sure what you're trying to do with it.", "reference": "Do we need this expectation? If we don't call this method on `PlanFinder` there's no way for the `10` to be returned. Seems somewhat redundant. What do you think?" }, { @@ -9547,19 +9547,19 @@ "reference": "We need to do the same for edgecore" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I think we can remove the `WaitOne` call here.", "reference": "This fix has nothing to do with the product change. Just a fix I am making for the test issue." }, { - "prediction": "I think this should be `if (this.Exporter != null)` instead of `if (this.Exporter != null && this.Exporter != this.Exporter)`.", + "prediction": "I think this should be `if (this.Exporter != null)` instead of `else if (this.Exporter != null)`.", "reference": "Don't know what should be the default. Lets keep BatchingProcessor for now. And revisit the area after beta." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this. I think you should be using `RSpec::Core::ReentrantMutex` instead.", + "prediction": "I'm not sure what you're trying to achieve with this, but I don't think it's a good idea to have a `Core` module in the `RSpec` namespace.", "reference": "Ah that's how it's happening, it's probably using the `require_relative` in the optimised one and that counts as a different require to the bare one." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to register a nib for a cell reuse, but you're not actually using it.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this", "reference": "What happens if there is no NIB/XIB with that name?" }, { @@ -9567,23 +9567,23 @@ "reference": "this is not necessary?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add a comment to explain what this change does.", + "prediction": "I'm not sure if this is a good idea, but I think we should have a separate package for `asmsecretres` and `ssmsecretres` so that we don't have to import them everywhere.", "reference": "typo: `asmsecrets \"github...`" }, { - "prediction": "I think it's better to use `json_encode` instead of `json_decode` in this case.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place", "reference": "I think that the JSON encoding should be handled by the control itself, not the sanitization function. This should only confirm that the input is correct, not reformat it" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.", + "prediction": "I'm not sure if this is the best place to do this, but I think it's a good place to do this.", "reference": "Should we put a TODO here to route the http.Transport through here?" }, { - "prediction": "I think we can remove the `cmd` variable and just do `cmd := fmt.Sprintf(\"Get-VMSwitch -Name %s | Set-VMSwitch -AllowManagementOS $false \", networkName)`", + "prediction": "I think we can remove the `cmd` variable and just do `cmd := fmt.Sprintf(\"Get-VMSwitch -ComputerName $(hostname) -Name %s | Set-VMSwitch -AllowManagementOS $false \", networkName)`", "reference": "Sorry, could you explain more about the issue? Doesn't ComputerName already default to local computer? > -ComputerName Specifies one or more Hyper-V hosts on which the virtual switch is to be configured. NetBIOS names, IP addresses, and fully qualified domain names are allowable. The default is the local computer. Use localhost or a dot (.) to specify the local computer explicitly." }, { - "prediction": "I think it's better to use `fmt.Sprintf` instead of `%v` in this case.", + "prediction": "I think it's better to use `fmt.Sprintf` here instead of `%v`.", "reference": "`allowError` is a big vague. Does this mean the test case is asserting that an error should occur? If it means \"maybe an error can occur, and that's okay\" -- what's an example of this?" }, { @@ -9591,31 +9591,31 @@ "reference": "return statements should not be cuddled if block has more than two lines (from `wsl`)" }, { - "prediction": "I think this should be `volatile` instead of `final`.", + "prediction": "I think this should be `volatile long` instead of `volatile long[]`.", "reference": "Why does VirtualMachineMetrics have to implement Metric?" }, { - "prediction": "I'm not sure why this test is failing. I'm not sure if it's because of the `accountManager.Remove` call or the `accountManager.SignVote` call. I'm not sure if it's because of the `accountManager.Remove` call or the `accountManager.SignVote` call. I'm not sure if it's because of the `accountManager.Remove` call or the `accountManager.SignVote` call. I'm not sure if it's because of the `accountManager.Remove` call or the `accountManager.SignVote` call. I'm not sure if it's because of the `accountManager.Remove` call or the `accountManager.SignVote` call. I'm not sure if it's because of the `accountManager.Remove` call or the `accountManager.SignVote` call. I'm not sure if it's because of the `accountManager.Remove` call or the `accountManager.SignVote` call. I'm not sure if it's because of the `accountManager.Remove` call or the `accountManager.SignVote` call. I'm not sure if it's because of the `accountManager.Remove` call or the `accountManager.SignVote` call. I'm not sure if it's because of the `account", + "prediction": "I don't think this is necessary.", "reference": "line is 121 characters" }, { - "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to change the `name` property of the DOM element, but you're doing it in a way that doesn't make sense. I'm not sure what you're trying to do here. It looks like you're trying to change the `name` property of the DOM element, but you're doing it in a way that doesn't make sense. I'm not sure what you're trying to do here. It looks like you're trying to change the `name` property of the DOM element, but you're doing it in a way that doesn't make sense. I'm not sure what you're trying to do here. It looks like you're trying to change the `name` property of the DOM element, but you're doing it in a way that doesn't make sense. I'm not sure what you're trying to do here. It looks like you're trying to change the `name` property of the DOM element, but you're doing it in a way that doesn't make sense. I'm not sure what you're trying to do here. It looks like you're trying to change the `name` property of the DOM element, but you're doing it in", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `toLowerCase` here. `name.slice(0, 2) === 'on'` is not the same as `name[0] === 'o' && name[1] === 'n'`, so I think it's better to use `toLowerCase` here.", "reference": "How's that linked esbench looking with slice?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to call `self.conn.sendcmd` here. It's not a good idea to call `self.conn.sendcmd` here. It's not a good idea to call `self.conn.sendcmd` here. It's not a good idea to call `self.conn.sendcmd` here. It's not a good idea to call `self.conn.sendcmd` here. It's not a good idea to call `self.conn.sendcmd` here. It's not a good idea to call `self.conn.sendcmd` here. It's not a good idea to call `self.conn.sendcmd` here. It's not a good idea to call `self.conn.sendcmd` here. It's not a good idea to call `self.conn.sendcmd` here. It's not a good idea to call `self.conn.sendcmd` here. It's not a good idea to call `self.conn.sendcmd` here. It's not a good idea to call `self.conn.sendcmd` here. It's not a good idea to call `self.conn.sendcmd` here. It's not a good idea to call `self.conn.sendcmd` here.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a separate method.", "reference": "The split and join was probably done to ensure that this still works on Windows because os.path.dirname works differently depending on the os you're running under :(. It would probably be a little better to do `dirname, _, fn = path.rpartition('/')` if you want something cleaner than the split/join." }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a `getCount()` method to the `SessionMap` class.", + "prediction": "I don't think this is needed anymore.", "reference": "This is not the right approach. The `Distributor` maintains a model of the current state of the Grid. That model already contains the information about every active session. We don't need to modify `SessionMap` to expose it further." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `time.Time{}` for `pacingDeadline`.", + "prediction": "I'm not sure what you mean by \"pacing deadline\". I think you meant to say `s.maybeResetTimer(time.Time{})`", "reference": "Can you make this a member var as all the other deadlines? Then you can drop the param to resetTimer() and simplify some of the code below iiuc." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `std::unique_ptr` for the `ROMOL_SPTR` and `ROMOL_SPTR` for the `ROMOL_SPTR`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `canonicalize` function.", "reference": "I don't understand the reason for the changes from unique_ptr to ROMOL_SPTR that you made in this file. The pointers aren't being shared or used elsewhere so I don't think there's any reason to make them shared. Did I miss something?" }, { @@ -9623,31 +9623,31 @@ "reference": "why change the variable name at all?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to get the actual node from the tree, and then compare it to the node passed in. But I don't think that's what you're trying to do. I think you're trying to get the actual node from the tree, and then compare it to the node passed in. But I don't think that's what you're trying to do. I think you're trying to get the actual node from the tree, and then compare it to the node passed in. But I don't think that's what you're trying to do. I think you're trying to get the actual node from the tree, and then compare it to the node passed in. But I don't think that's what you're trying to do. I think you're trying to get the actual node from the tree, and then compare it to the node passed in. But I don't think that's what you're trying to do. I think you're trying to get the actual node from the tree, and then compare it to the node passed in. But I don't think that's what you're trying to do. I think you're trying to get the actual node from the tree, and then", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to get the actual node from the tree, but then you're trying to get the node from the tree, which doesn't make sense.", "reference": "Since I'm still trying to keep these straight in my head, can you elaborate on what problem this solves?" }, { - "prediction": "I'm not sure what you mean by \"disable the delete button after it's tapped (to try to prevent\"). I'm not sure what you mean by \"disable the delete button after it's tapped (to try to prevent\"). I'm not sure what you mean by \"disable the delete button after it's tapped (to try to prevent\"). I'm not sure what you mean by \"disable the delete button after it's tapped (to try to prevent\"). I'm not sure what you mean by \"disable the delete button after it's tapped (to try to prevent\"). I'm not sure what you mean by \"disable the delete button after it's tapped (to try to prevent\"). I'm not sure what you mean by \"disable the delete button after it's tapped (to try to prevent\"). I'm not sure what you mean by \"disable the delete button after it's tapped (to try to prevent\"). I'm not sure what you mean by \"disable the delete button after it's tapped (to try to prevent\"). I'm not sure what you mean by \"disable the delete button after it's tapped (to try to prevent\"). I'm not sure what you mean by \"disable the delete button after it's tapped (to try to prevent\"). I'm not", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to check if the message is spam before deleting it. If the message is spam, then we should not delete it.", "reference": "Prefer TextUtils.isEmpty() which handles getReportSpamRecipient() being null" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `Selenium::Firefox` module.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate method for this. It's not clear to me that this is the right place to do this.", "reference": "Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `Package` class.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `GetTargetFramework` method to get the target framework.", "reference": "Do we actually use Include anywhere yet or is this just for completion?" }, { - "prediction": "I think we should remove the `none_ok=True` from `Referer-header` and `user-agent`.", + "prediction": "I'm not sure if this is the right place to put this. I think we should put it in the `settings.py` file, but I'm not sure if that's the best place to put it.", "reference": "It still bugs me this was misspelled in the standard and now the wrong spelling is the commonly used one :wink:" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `page` object, so that it can be used in the `getFolderHtml` function.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this", "reference": "seems we missed de-uglifying this one" }, { - "prediction": "I think we can remove the `NewWorkflowUnspecified` and `NewWorkflowCron` from the `NewWorkflowType` enum.", + "prediction": "I think this should be `NewWorkflowType` instead of `NewWorkflowUnspecified`.", "reference": "i guess these types & cron / retry specific belong to a dedicated util / struct" }, { @@ -9655,7 +9655,7 @@ "reference": "Also update line 2205 below" }, { - "prediction": "I'm not sure what you mean by \"disabled\" in this context. It's not clear what you're trying to do with this property.", + "prediction": "I don't think we need to change the default value of `direction` to `vertical`.", "reference": "`direction` is referenced nowhere. Do I miss something?" }, { @@ -9663,59 +9663,59 @@ "reference": "The two places this was used have been removed so we can fully remove this dependency." }, { - "prediction": "I'm not sure what you mean by \"go:generate dbgen -i agree.sql -p agreement -n agree -o agreeInstall.go\". Is this the same as `dbgen -i agree.sql -p agreement -n agree -o agreeInstall.go`?", + "prediction": "I don't think we need to use `go:generate` here. We can just use `dbgen` directly.", "reference": "This is a duplicate generation of the same file as below." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `device_ids=range(cfg.gpus)` instead of `range(cfg.gpus) if cfg.gpu_ids is None else cfg.gpu_ids`.", + "prediction": "`gpu_ids` should be `cfg.gpus`, not `cfg.gpu_ids`", "reference": "We may deprecate `gpus` if `gpu_ids` is specified." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this.", + "prediction": "I don't think we need to do this. We can just use the `sendText` method to send the serialized object.", "reference": "Right now this is experimental and deeply flaky. We left this at `info` to make debugging user reports a lot easier." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to do something like this:\n\n```js\nvar a = 1;\nvar b = 2;\nvar c = 3;\nvar d = 4;\nvar e = 5;\nvar f = 6;\nvar g = 7;\nvar h = 8;\nvar i = 9;\nvar j = 10;\nvar k = 11;\nvar l = 12;\nvar m = 13;\nvar n = 14;\nvar o = 15;\nvar p = 16;\nvar q = 17;\nvar r = 18;\nvar s = 19;\nvar t = 20;\nvar u = 21;\nvar v = 22;\nvar w = 23;\nvar x = 24;\nvar y = 25;\nvar z = 26;\nvar a = 1;\nvar b = 2;\nvar c = 3;\nvar d = 4;\nvar e = 5;\nvar f = 6;\nvar g = 7;\nvar h = 8;\nvar i = 9;\nvar", + "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.", "reference": "unnecessary spaces here are doubling the size of this otherwise extremely useful addition" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `CopyDirectoryRecursively` method, since it's called by the `CopyDirectoryRecursively` method.", + "prediction": "I'm not sure if this is the best way to do this, but it seems to work for me.", "reference": "I think we should use `FileExistsPolicy.Overwrite` instead. Files _should_ always be newer, but in the unlikely case they wouldn't be, I'm afraid some files would be overwritten and other not, leading to inconsistencies that will be hard to figure out." }, { - "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you", + "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.", "reference": "this should probably be removed" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `json.MarshalIndent` here. It's not clear what you're trying to do here, but I don't think it's a good idea to use `json.MarshalIndent` here. It's not clear what you're trying to do here, but I don't think it's a good idea to use `json.MarshalIndent` here. It's not clear what you're trying to do here, but I don't think it's a good idea to use `json.MarshalIndent` here. It's not clear what you're trying to do here, but I don't think it's a good idea to use `json.MarshalIndent` here. It's not clear what you're trying to do here, but I don't think it's a good idea to use `json.MarshalIndent` here. It's not clear what you're trying to do here, but I don't think it's a good idea to use `json.MarshalIndent` here. It's not clear what you're trying to do here, but I don't think it's a good idea to use `json.MarshalIndent` here. It's not clear what you're trying", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `json.MarshalIndent` here. I think you should use `json.Marshal` instead.", "reference": "Nit: I would actually prefer that pretty JSON is the default, with a flag for compressed JSON. Can we acheive that easily?" }, { - "prediction": "I'm not sure what you mean by \"additional ingress rules to add to the security group rules created for that role\"", + "prediction": "I'm not sure what you're trying to achieve with this field, but I think it should be `map[SecurityGroupRole]string` instead of `map[SecurityGroupRole]SecurityGroupRole`.", "reference": "Will need to think about this one. `additionalIngressRules` feels a bit opaque in terms of eventual outcome." }, { - "prediction": "I think this should be `Integer.parseInt(idStr)` instead of `Integer::parseInt`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to make sure the type is a `TypeDescription` and not just a `String` or `Integer`.", "reference": "Can we avoid making this public with the other updates?" }, { - "prediction": "I don't think this is a good idea. We should check that the size of `datum_num` is equal to the size of `transformed_blob->num()`.", + "prediction": "I don't think we need to check the size of `datum_num` and `num` here.", "reference": "Why did you change this equal instead of less or equal?" }, { - "prediction": "I think this should be `Optional` instead of `Optional`.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `WorldState` interface.", "reference": "missing final for the blockHash field" }, { - "prediction": "I'm not sure what you mean by \"include\" in this case. I think you meant to say \"include FactoryGirl::Syntax::Methods\" or \"include FactoryBot::Syntax::Methods\".", + "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to include `FactoryBot::Syntax::Methods` in the `RSpec.configure` block. This way, we can use `FactoryBot::Syntax::Methods` in our tests without having to include `FactoryBot::Syntax::Methods` in the `RSpec.configure` block.", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { - "prediction": "I think we can remove the `float_x` and `norm` in the forward pass.", + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", "reference": "`x_float` instead of `float_x`." }, { - "prediction": "`import Swiper from 'swiper/swiper-bundle.esm';` should be `import Swiper from 'swiper/swiper-bundle';`", + "prediction": "`Swiper` should be imported as `Swiper` instead of `SwiperBundle`", "reference": "Is this for `No Babel config ...` from ESLint? If so, it will be fixed in my ES6 PR." }, { @@ -9727,11 +9727,11 @@ "reference": "I think I saw this line in last PR, you can update your base branch and rebase to avoid this. And it would be awesome if you can rebase instead of merge each time you push PR to the `moby` branch, that will make the commits history clearer." }, { - "prediction": "I think this should be `if (intercept_asynch_for_thread(tid, false/*no unknown threads*/)) {` instead of `if (get_thread_id() == tid) {`", + "prediction": "I think this should be `if (intercept_asynch_for_thread(tid, false/*no unknown threads*/)) {` instead of `if (intercept_asynch_for_thread(tid, false/*no unknown threads*/)) { if (get_thread_id() == tid) { /* Simple case when called on own thread. */ return execute_syscall; } }`", "reference": "If this can change the PC of this thread, it requires handling: we can't blindly execute the syscall and lose control of the thread when the flags include CONTEXT_CONTROL. (Note that most docs imply that setting your own context this way is not supported or has undefined or unpredictable results: any idea how often that's the case, or does it generally work?) We need to handle in a similar fashion to NtContinue or setting another thread's context to ensure we retain control." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the total number of products in the database. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the total number of products in the database. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the total number of products in the database. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the total number of products in the database. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the total number of products in the database. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the total number of products in the database. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the total number of products in the database. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the total number of products in the database. I'm not sure what you're trying", + "prediction": "I think we should remove the call to `@GET(\"/.json\")` as it's not needed.", "reference": "@huzaifaiftikhar Changed the endpoint as suggested by Stephane in the latest commit." }, { @@ -9739,55 +9739,55 @@ "reference": "There's no core.Number yet. ;)" }, { - "prediction": "I don't think this is a good name for this command. It's not clear what it does.", + "prediction": "I don't think we need to add a `--volname` option to the `snapshotrevert` command. The `--snapname` option is used to specify the snapshot to roll back to.", "reference": "..., ...will be posted." }, { - "prediction": "I think this should be `err := f.RunCmdJSONWithStdin(ctx, nil, &out, \"go-filecoin\", \"show\", \"header\", sRef); err != nil`", + "prediction": "I'm not sure if this is the right way to do this, but I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we should be able to do this in a single command. I think we", "reference": "Can you update this function to be `ShowHeader`? There is only one use of it at the moment in `tools/fast/series/get_head_block_height.go`." }, { - "prediction": "I'm not sure what you mean by `DISABLE_TQDM = os.getenv('QUILT_USE_TQDM', '').lower() != 'true'`. I think you meant to say `os.getenv('QUILT_USE_TQDM', '').lower() == 'true'`.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in `config.py` instead of `config_template.py`.", "reference": "@akarve, this disables `tqdm` by default, is it intended? Also name `QUILT_USE_TQDM` might be too specific, IMHO `QUILT_INTERACTIVE` or `QUILT_PROGRESS_BARS` or something might be better." }, { - "prediction": "I think we can remove the `time.Millisecond` from `waitTimeoutMillis` and just use `waitTimeoutMillis * time.Millisecond` instead.", + "prediction": "I think we can remove the `time.Millisecond` from `waitTimeoutMillis` and just use `waitTimeoutMillis * 1000`", "reference": "unrelated but just changing for consistency with code below it" }, { - "prediction": "I don't think this is necessary. We can just use `component.shouldComponentUpdate` and `component.componentWillUpdate` instead.", + "prediction": "I don't think this is necessary.", "reference": "This will call `componentWillUpdate()` for mounts because the else clause is removed. It should only be called for updates." }, { - "prediction": "I don't think we need to add `history` to `PERMISSIONS_INHERITANCE_TREE` as it is already covered by `history` in `PERMISSIONS_INHERITANCE_TREE`.", + "prediction": "I don't think we need to add `history` to the `read` permission.", "reference": "We should add write inheritance too." }, { - "prediction": "I'm not sure what the point of this is, but I think it's a good idea to remove the `os.environ.get('JAVA_OPTS', '').strip()` line.", + "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to have this in a separate file.", "reference": "Please rename this to `LAMBDA_JAVA_OPTS`, and add a short description to the README." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to add a new field to the `AnalysisResult` struct, but I'm not sure if that's the best way to go about it.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `applicationlivestatestore` package.", "reference": "Should be in the same import group." }, { - "prediction": "I think this should be `if remain == b\"\":` instead of `if remain == b\"\":`", + "prediction": "I think this should be `if pkt.tls_session.tls_version > 0x0200 and pkt.type == 23:`", "reference": "Operator precedence is very confusing here. Care to add parentheses? ` ((version or 0x0303) >= 0x0200)` Same below." }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do with this code.", + "prediction": "I don't think this is a good idea. It would be better to create a new class that extends `AbstractSyntaxTree` instead of creating a new class that extends `AbstractSyntaxTreeParser`.", "reference": "javaparser-core has no dependencies and it should stay that way. So no log4j. And even then there would have been a preference for slf4j." }, { - "prediction": "I think we should add this to the list of formats that we need to re-test.", + "prediction": "I think we should add this to the list of formats to retest.", "reference": "Why not just retest all? it's not expensive (I think)." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea.", + "prediction": "I think we can remove the `ecr0` package as it's not used in this PR.", "reference": "ecr and ecr0 aren't deterministically named here. This change will just cause confusion in the git history. Could you either: a) fix this and make it deterministic b) regenerate the mock until it doesn't flip definitions for ecr and ecr0" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `sudo` here.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `sudo` to install `gdebi-core` and `gdebi` to install `r-#{r_version}_1_amd64.deb` and `R-#{r_version}-$(lsb_release -cs).xz`.", "reference": "This looks like bash... does this work in ruby? Or is the idea to inject the entire script into the subsequent commands?" }, { @@ -9795,27 +9795,27 @@ "reference": "I don't understand why this change is in this PR?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to `Blacklight::FacetsHelper` instead of `Blacklight::FacetsHelperBehavior`.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to remove the `self.deprecation_horizon = 'blacklight 8.0'` line from the `extend Deprecation` line.", "reference": "It's a little hard to tell from the diff, but as a result of this PR, the only non-deprecated helpers are: - `has_facet_values?` (probably not long for this world) - `render_facet_partials` (perhaps part of a future component) - `render_facet_limit` (possibly obsolete once components get traction) - `facet_field_in_params` (a little tricky to deprecate at the moment) - `facet_field_presenter`" }, { - "prediction": "I'm not sure what you mean by \"doesn't work on JSC on Android\". I'm not sure what you mean by \"doesn't work on JSC on Android\". I'm not sure what you mean by \"doesn't work on JSC on Android\". I'm not sure what you mean by \"doesn't work on JSC on Android\". I'm not sure what you mean by \"doesn't work on JSC on Android\". I'm not sure what you mean by \"doesn't work on JSC on Android\". I'm not sure what you mean by \"doesn't work on JSC on Android\". I'm not sure what you mean by \"doesn't work on JSC on Android\". I'm not sure what you mean by \"doesn't work on JSC on Android\". I'm not sure what you mean by \"doesn't work on JSC on Android\". I'm not sure what you mean by \"doesn't work on JSC on Android\". I'm not sure what you mean by \"doesn't work on JSC on Android\". I'm not sure what you mean by \"doesn't work on JSC on Android\". I'm not sure what you mean by \"doesn't work on JSC on Android\". I'm not sure", + "prediction": "I don't think we need to do this.", "reference": "The right-hand part shouldn't use `__proto__`. Should be just `PersonObject.__proto__ = Realm.Object`." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think we need to change anything here.", + "prediction": "I'm not sure what you mean by `request.MinTaskID >= request.MaxTaskID`. I think you meant to say `request.MinTaskID <= request.MaxTaskID`.", "reference": "the == case might be legit, or not? If there is no task written since last read, but we trigger a new read, would the min == max? Or should the upper layer handle that case?" }, { - "prediction": "I think this should be `memcpy(new_p, p, old_size);` instead of `memcpy(new_p, p, new_size);`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be better to do this in the `pool_alloc_size` function.", "reference": "Good catch! But is it guaranteed that `old_size < new_size` here? If not, wouldn't we want to take `min(old_size, new_size)` as the copy length?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `ToolCollection` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `InstallToolPackage` method.", "reference": "This is the only one that worries me a bit. It would be good if Brendan signed off on it." }, { - "prediction": "I don't think this is necessary. The `OptionalArrayMethodView` is already a `Builder`, so we don't need to create a new one.", + "prediction": "I think this should be `hasLongrunningReturnValue()` instead of `hasLongrunningOperation()`.", "reference": "`LongRunningOperationDetailView` already has `isEmptyOperation`." }, { @@ -9823,11 +9823,11 @@ "reference": "This will always add the authorization header to the request object. Is this the right scope for these two lines? If username/password are not defined, it will encode 'Basic :'" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don", + "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear to me what you're trying to do here.", "reference": "Don't think a scope adds much value for us here. Also, for future reference, you don't need to use the `self.all` it is implied. Could just be: `scope :updated_at_desc, -> { order(updated_at: :desc) }` No need to change this one now though, it works." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to generate a random number between 0 and 9, but only if the first digit is not zero. Is that correct?", + "prediction": "I'm not sure what you're trying to achieve here. I'm not sure what you're trying to achieve here. I'm not sure what you're trying to achieve here. I'm not sure what you're trying to achieve here. I'm not sure what you're trying to achieve here. I'm not sure what you're trying to achieve here. I'm not sure what you're trying to achieve here. I'm not sure what you're trying to achieve here. I'm not sure what you're trying to achieve here. I'm not sure what you're trying to achieve here. I'm not sure what you're trying to achieve here. I'm not sure what you're trying to achieve here. I'm not sure what you're trying to achieve here. I'm not sure what you're trying to achieve here. I'm not sure what you're trying to achieve here. I'm not sure what you're trying to achieve here. I'm not sure what you're trying to achieve here. I'm not sure what you're trying to achieve here. I'm not sure what you're trying to achieve here. I'm not sure what you're trying to achieve here. I'm not sure what you're trying to achieve here. I'm not sure", "reference": "I believe `Base.` is unnecessary in this case, as the class already extends `Base`." }, { @@ -9835,23 +9835,23 @@ "reference": "Couldn't this result in images being scaled too small when the width is less than the height assuming the width is still what is being passed here?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `versionInfo` object in the `reportsInstance` object. This way, we don't have to hardcode the `versionInfo` object in the `reportsInstance` object, and we don't have to hardcode the `versionInfo` object in the `reportsInstance` object.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `common` module.", "reference": "Here also, let's not cache value on top of file, but use `plugins.getConfig(\"api\").offline_mode` directly where it is needed" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to check if the library cards are available before trying to get the login drivers. This way, if the library cards are not available, we don't try to get the login drivers, and if the login drivers are not available, we don't try to get the library cards. I think this is a good way to make sure that we don't try to get the login drivers when the library cards are not available, and we don't try to get the library cards when the login drivers are not available. I think this is a good way to make sure that we don't try to get the login drivers when the library cards are not available, and we don't try to get the library cards when the login drivers are not available. I think this is a good way to make sure that we don't try to get the login drivers when the library cards are not available, and we don't try to get the library cards when the login drivers are not available. I think this is a good way to make sure that we don't try to get the login drivers when the library cards are not available, and we don't try to get the library cards when the", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the `LibraryCardsController` as well. I think it would be good to have this in the `LibraryCardsController` as well. I think it would be good to have this in the `LibraryCardsController` as well. I think it would be good to have this in the `LibraryCardsController` as well. I think it would be good to have this in the `LibraryCardsController` as well. I think it would be good to have this in the `LibraryCardsController` as well. I think it would be good to have this in the `LibraryCardsController` as well. I think it would be good to have this in the `LibraryCardsController` as well. I think it would be good to have this in the `LibraryCardsController` as well. I think it would be good to have this in the `LibraryCardsController` as well. I think it would be good to have this in the `LibraryCardsController` as well. I think it would be good to have this in the `LibraryCardsController` as well. I think it would be good to have this in the `Library", "reference": "You can combine the two checks into a single `!empty()` check." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check for `max_pending` and `max_payload` in the `validateTrustedOperators` function. This way, we can make sure that the `max_pending` and `max_payload` values are within the allowed range.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `max_pending` and `max_payload` in `validateTrustedOperators` as well.", "reference": "Should we add a warning for anything over say 8M? Just suggesting that is not recommended?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to have a `checkMDPerms` function in the `keybase1` package. It would be better to have a separate `checkMDPerms` function in the `keybase1` package that takes in the `mergedMasterHead` and the `currentUID` and returns a boolean and an error.", + "prediction": "I'm not sure if this is a good place to put it, but I think we should move it to the `checkMDPerms` function.", "reference": "Looks like there are no callers left of this function." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a default timeout of 10 minutes, so that if the user doesn't specify a timeout, it defaults to 10 minutes. I'm not sure if this is the best way to do this, but I think it's a good idea to have a default timeout of 10 minutes, so that if the user doesn't specify a timeout, it defaults to 10 minutes. I'm not sure if this is the best way to do this, but I think it's a good idea to have a default timeout of 10 minutes, so that if the user doesn't specify a timeout, it defaults to 10 minutes. I'm not sure if this is the best way to do this, but I think it's a good idea to have a default timeout of 10 minutes, so that if the user doesn't specify a timeout, it defaults to 10 minutes. I'm not sure if this is the best way to do this, but I think it's a good idea to have a default timeout of 10 minutes, so that if the user doesn't specify a timeout, it defaults to ", "reference": "Should there still be a ` bool` trailing `showOutput`?" }, { @@ -9859,27 +9859,27 @@ "reference": "Did we can change to v1" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `diffChildren` function.", + "prediction": "I'm not sure if this is needed, but I think it's a good idea to make sure that the `mounts` object is not an empty array. If it is, we'll get an error when we try to traverse upwards through the `mounts` object.", "reference": "Can you please double check that this won't break anything?" }, { - "prediction": "I'm not sure what you're trying to do here. The `RpcEndpoint.IPC` is not used anywhere in the code. It's just a placeholder for the `IpcSocketsHandler` which is not used anywhere in the code. It's just a placeholder for the `IpcSocketsHandler` which is not used anywhere in the code. It's just a placeholder for the `IpcSocketsHandler` which is not used anywhere in the code. It's just a placeholder for the `IpcSocketsHandler` which is not used anywhere in the code. It's just a placeholder for the `IpcSocketsHandler` which is not used anywhere in the code. It's just a placeholder for the `IpcSocketsHandler` which is not used anywhere in the code. It's just a placeholder for the `IpcSocketsHandler` which is not used anywhere in the code. It's just a placeholder for the `IpcSocketsHandler` which is not used anywhere in the code. It's just a placeholder for the `IpcSocketsHandler` which is not used anywhere in the code. It's just a placeholder for the `IpcSocketsHandler` which is not used anywhere in the code", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to pass a `null` value to the `IpcSocketsHandler` constructor. This is not allowed, so I'm not sure what you're trying to do here, but it looks like you're trying to pass a `null` value to the `IpcSocketsHandler` constructor. This is not allowed, so I'm not sure what you're trying to do here, but it looks like you're trying to pass a `null` value to the `IpcSocketsHandler` constructor. This is not allowed, so I'm not sure what you're trying to do here, but it looks like you're trying to pass a `null` value to the `IpcSocketsHandler` constructor. This is not allowed, so I'm not sure what you're trying to do here, but it looks like you're trying to pass a `null` value to the `IpcSocketsHandler` constructor. This is not allowed, so I'm not sure what you're trying to do here, but it looks like you're trying to pass a `null` value to the `IpcSocketsHandler` constructor. This is not allowed", "reference": "optionals, shouldn't need to be stated explicitly" }, { - "prediction": "I think it's better to use `gquicVersion0 + 3*0x100 + 0x7` instead of `gquicVersion0 + 3*0x100 + 0x7 + 0x100 + 0x100 + 0x100 + 0x100 + 0x100 + 0x100 + 0x100 + 0x100 + 0x100 + 0x100 + 0x100 + 0x100 + 0x100 + 0x100 + 0x100 + 0x100 + 0x100 + 0x100 + 0x100 + 0x100 + 0x100 + 0x100 + 0x100 + 0x100 + 0x100 + 0x100 + 0x100 + 0x100 + 0x100 + 0", + "prediction": "I think we should use `maxGquicVersion` instead of `gquicVersion0 + 3*0x100 + 0x7 + 0x100 + 0x7 + 0x100 + 0x7 + 0x100 + 0x7 + 0x100 + 0x7 + 0x100 + 0x7 + 0x100 + 0x7 + 0x100 + 0x7 + 0x100 + 0x7 + 0x100 + 0x7 + 0x100 + 0x7 + 0x100 + 0x7 + 0x100 + 0x7 + 0x100 + 0x7 + 0x100 + 0x7 + 0x100 + 0x7 + 0x100 + 0x7 + 0x100 + 0x7 + 0x100 + 0x7 + 0x10", "reference": "That seems quite low - why not just 0x5130ffff?" }, { - "prediction": "I think this should be `self.parsed` instead of `self.parsed[3]`", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a `__repr__` method to `Net` as well.", "reference": "Why is this needed ?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to have `first_runs_free` in the `Bolt::Config` module. I think it's better to have it in the `Bolt::User` module.", + "prediction": "I'm not sure what you're trying to do with this, but I think it's a bad idea to have `first_runs_free` in the `Bolt::Config` module. I think it's better to have it in the `Bolt::User` module.", "reference": "`Bolt::Config.user_path` returns `nil` if there's no homedir, so this will still error in that case." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to do something like this:\n```\nif a.t() == ignore || a.t() == disconnect {\n return fmt.Sprintf(\"%v: %5v\", a.t().String(), a.Err)\n}\n```\nBut I'm not sure what you're trying to do here. I think you're trying to do something like this:\n```\nif a.t() == ignore || a.t() == disconnect {\n return fmt.Sprintf(\"%v: %5v\", a.t().String(), a.Err)\n}\n```\nBut I'm not sure what you're trying to do here. I think you're trying to do something like this:\n```\nif a.t() == ignore || a.t() == disconnect {\n return fmt.Sprintf(\"%v: %5v\", a.t().String(), a.Err)\n}\n```\nBut I'm not sure what you're trying to do here. I think you're trying to do something like this:\n```\nif a.t() == ignore || a.t() == disconnect {\n return fmt.Sprintf(\"%v: %5v\", a.t().String(), a.Err)\n}\n```\nBut I'm not sure what you're trying to do here.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `Tag` field in the `ProposalPayload` struct. This way, we don't need to check for `a.Tag == protocol.ProposalPayloadTag` in the `String` method.", "reference": "nit: use %s for strings and %v for objects." }, { @@ -9887,15 +9887,15 @@ "reference": "Same as before, the properties already exists in parent" }, { - "prediction": "I don't think this is a good idea. It would be better to use the `nuget_str` variable directly in the `nuget_str = nuget_str.replace('rc', '-rc')` line. I think it would be better to use the `nuget_str` variable directly in the `nuget_str = nuget_str.replace('rc', '-rc')` line. I think it would be better to use the `nuget_str` variable directly in the `nuget_str = nuget_str.replace('rc', '-rc')` line. I think it would be better to use the `nuget_str` variable directly in the `nuget_str = nuget_str.replace('rc', '-rc')` line. I think it would be better to use the `nuget_str` variable directly in the `nuget_str = nuget_str.replace('rc', '-rc')` line. I think it would be better to use the `nuget_str` variable directly in the `nuget_str = nuget_str.replace('rc', '-rc')` line. I think it would be better to use the `nuget_str` variable directly in the `nuget_str = nuget_str.replace('rc', '-rc", + "prediction": "I don't think we need to use the `datetime.datetime.now().year` here. We can just use the current year.", "reference": "This fix is not quite correct. The `%s` should be replaced with `version` and the `%d` on line 39 should be replaced with `datetime.datetime.now().year`." }, { - "prediction": "I'm not sure what you mean by \"gone\"", + "prediction": "I think this should be `if (major == DRM_MAJOR && strcmp(type, \"gone\") != 0)` instead of `if (major == DRM_MAJOR && strcmp(type, \"gone\") != 0)`.", "reference": "Maybe we should only set active = false if `strcmp(type, \"pause\") == 0`?" }, { - "prediction": "I think this should be `print_page` instead of `bridge.print_page`?", + "prediction": "I think this should be `print_page` instead of `print_page!`", "reference": "Same here. and all others." }, { @@ -9907,11 +9907,11 @@ "reference": "I think this blank line may be removed" }, { - "prediction": "I'm not sure what you mean by \"remove the bookmark instead of raising an error if it already exists\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a `remove` method to the `UrlMarkManager` class.", "reference": "I think this should be a keyword-only argument, i.e. do `def add(self, url, title, *, toggle=False):` and adjust the caller to do `toggle=toggle`." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I don't think we need to do this. I think we can just use the `EmmcSwitchBusWidth` function to set the bus width.", "reference": "@aimanrosli23 Judging from the commit description, I do not know why this file got changed so much. Could you help to double confirm if you do not revert the changes brought by commits: SHA-1: 643623147a1feaddd734ddd84604e1d8e9dcebee * MdeModulePkg/SdMmcPciHcDxe: Send SEND_STATUS at lower frequency SHA-1: 49accdedf956f175041040e677163b7cbb746283 * MdeModulePkg/SdMmcPciHcDxe: Hook SwitchClockFreq after SD clock start" }, { @@ -9919,23 +9919,23 @@ "reference": "How about YAML.load_file()" }, { - "prediction": "I'm not sure what you mean by `isInitialized = false;`", + "prediction": "I think we should remove the `isInitialized` field, as it's not used anywhere.", "reference": "Maybe make this `volatile` or atomic as this can be set/read from different threads? Also, separately you may want to check if some of the methods here need to be `synchronized`." }, { - "prediction": "I think this should be `drmgr_unregister_module_unload_event(drwrap_event_module_unload);` instead of `drmgr_unregister_module_unload_event(drwrap_event_module_unload);`", + "prediction": "I think this should be `drmgr_unregister_module_unload_event(drwrap_event_module_unload);` instead of `drmgr_unregister_module_unload_event(drwrap_event_module_unload); drmgr_unregister_module_unload_event(drwrap_event_module_unload); drmgr_unregister_module_unload_event(drwrap_event_module_unload); drmgr_unregister_module_unload_event(drwrap_event_module_unload); drmgr_unregister_module_unload_event(drwrap_event_module_unload); drmgr_unregister_module_unload_event(drwrap_event_module_unload); drmgr_unregister_module_unload_event(drwrap_event_module_unload); drmgr_unregister_module_unload_event(drwrap_event_module_unload); drmgr_unregister_module_unload_event(drwrap_event_module_unload); drmgr_unregister_module_unload_event(drwrap_event_module_unload); drmgr_unregister_module_unload_event(drwrap_event_module_unload); drmgr_unregister_module_unload_event(drwrap_event_module_unload); drmgr_unregister_module_unload_event(drwrap_event_module_unload); drmgr_unregister_module_unload_event(drwrap_event_module_unload); drmgr_unregister_module_unload_event(drwrap_event_module_unload); drmgr_unregister_module_unload_event(drwrap_event_module_unload); drmgr_unregister_module_unload_event(dr", "reference": "Check the return value of the drmgr ones." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `data-cfasync` attribute.", + "prediction": "I don't think we need to do this.", "reference": "This should be `'cache'`" }, { - "prediction": "I'm not sure what you're trying to do with this. It's not clear what you're trying to do with the `MakeNewRepo` method.", + "prediction": "I'm not sure what you mean by \"read/write permissions\" here. I think you meant \"read and write permissions\".", "reference": "The name \"old\" might cause confusion here. After installation, the \"old\" repo is at an archived path, and the new migrated repo is at the old path. Maybe something like \"target\" or \"canonical\"?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the `readPreference` is the same as the `db` and `collection` in the `options` object.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a `readPreference` property to the `Collection` class.", "reference": "I think this is somewhat definitive proof that this error exists in `core` rather than `native`. We are correctly resolving the `readPreference` in the previous line, but you are able to identify that eventually the command generated in `core` is not decorated with the passed `readPreference`. Did you try to solve this there already?" }, { @@ -9943,51 +9943,51 @@ "reference": "During genesis sync it can unwind 5M blocks?" }, { - "prediction": "I'm not sure if this is a race condition, but I'm not sure how to test it. I think it's a race condition, but I'm not sure how to test it. I think it's a race condition, but I'm not sure how to test it. I think it's a race condition, but I'm not sure how to test it. I think it's a race condition, but I'm not sure how to test it. I think it's a race condition, but I'm not sure how to test it. I think it's a race condition, but I'm not sure how to test it. I think it's a race condition, but I'm not sure how to test it. I think it's a race condition, but I'm not sure how to test it. I think it's a race condition, but I'm not sure how to test it. I think it's a race condition, but I'm not sure how to test it. I think it's a race condition, but I'm not sure how to test it. I think it's a race condition, but I'm not sure how to test it. I think it's a race condition, but I'm not sure how to test it. I", + "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea to add it to the test suite. It's not a race condition, it's just that we don't want to wait too long for 0 throttling cases. I'm not sure if this is the right place to add this, but I think it's a good idea to add it to the test suite. It's not a race condition, it's just that we don't want to wait too long for 0 throttling cases. I'm not sure if this is the right place to add this, but I think it's a good idea to add it to the test suite. It's not a race condition, it's just that we don't want to wait too long for 0 throttling cases. I'm not sure if this is the right place to add this, but I think it's a good idea to add it to the test suite. It's not a race condition, it's just that we don't want to wait too long for 0 throttling cases. I'm not sure if this is the right place to add this, but I think it's a good idea to add it to the test suite. It's", "reference": "was it caused by the removal of removeTaskQueueManager() from this test?" }, { - "prediction": "I'm not sure what you mean by `search_session['counter']` and `search_session['total']`. I think you meant `search_session[:counter]` and `search_session[:total]`.", + "prediction": "I'm not sure what you mean by `search_session['counter']` and `search_session['total']`", "reference": "Wouldn't it just be easier to force search_session to return `with_indifferent_access`? Since you've done the hard work already, I don't think there's a problem doing it this way, but.." }, { - "prediction": "I think this should be `if (rp->uses_gpu()) {` instead of `if (gpu_suspend_reason) return false;`", + "prediction": "I think this should be `if (rp->uses_gpu())` instead of `if (rp->rr_sim_misses_deadline)`.", "reference": "So, such tasks that could possibly not meet the deadline will never have a chance to run? I think this is not nice behavior, especially for those projects who has sometimes some very small tasks after the big one." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `ItemType` class.", "reference": "You should add the check above this line instead. If string is empty, don't even call the function." }, { - "prediction": "I think this should be `item.getBoolean(KEY_CLIENT_CERT)` instead of `item.getBoolean(KEY_CLIENT_CERT)`.", + "prediction": "I think this should be `item.getString(KEY_CLIENT_CERT)` instead of `item.getBoolean(KEY_CLIENT_CERT)`.", "reference": "If clientCert attribute doesn't exist for some reason I set it to false." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `sh.if` here.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `curl_cmd` function that takes a list of flags and a location, and then calls `sh.cmd curl_cmd` with that list of flags and location.", "reference": "Do we need `app_host_flags` variable? We can directly concat with `flags`. `sh.cmd curl_cmd(unless Travis::Build.config&.ssl&.verify ? flags + ' -k' : flags, location, static_file_location), cmd_opts` right?" }, { - "prediction": "I'm not sure what you're trying to achieve with this code, but I think it's a bad idea to call `stopEventWalk()` in the `onWalk()` function.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to call `stopEventWalk()` in the `onWalk()` function.", "reference": "Walk should actually be completed (`onWalkCompleted`) after the event is stopped. This also makes it possible for monster to walk by smaller paths." }, { - "prediction": "I'm not sure what you're trying to achieve with this code. It seems like you're trying to get the size of the root chunk, but I'm not sure what you're trying to achieve with this code. It seems like you're trying to get the size of the root chunk, but I'm not sure what you're trying to achieve with this code. It seems like you're trying to get the size of the root chunk, but I'm not sure what you're trying to achieve with this code. It seems like you're trying to get the size of the root chunk, but I'm not sure what you're trying to achieve with this code. It seems like you're trying to get the size of the root chunk, but I'm not sure what you're trying to achieve with this code. It seems like you're trying to get the size of the root chunk, but I'm not sure what you're trying to achieve with this code. It seems like you're trying to get the size of the root chunk, but I'm not sure what you're trying to achieve with this code. It seems like you're trying to get the size of the root chunk, but I'm not sure what you're trying to achieve with this code. It seems", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `get` method.", "reference": "typo in `weather` (should be `whether`)" }, { - "prediction": "This flag is for testing only. Set to true to upgrade with staging windows install media. This flag is for testing only. Set to true to upgrade with staging windows install media. This flag is for testing only. Set to true to upgrade with staging windows install media. This flag is for testing only. Set to true to upgrade with staging windows install media. This flag is for testing only. Set to true to upgrade with staging windows install media. This flag is for testing only. Set to true to upgrade with staging windows install media. This flag is for testing only. Set to true to upgrade with staging windows install media. This flag is for testing only. Set to true to upgrade with staging windows install media. This flag is for testing only. Set to true to upgrade with staging windows install media. This flag is for testing only. Set to true to upgrade with staging windows install media. This flag is for testing only. Set to true to upgrade with staging windows install media. This flag is for testing only. Set to true to upgrade with staging windows install media. This flag is for testing only. Set to true to upgrade with staging windows install media. This flag is for testing only. Set to true to upgrade with staging windows install media. This flag is for", + "prediction": "This flag is for testing only. Set to true to upgrade with staging windows install media.", "reference": "Thoughts on having the URI as the param, instead of a boolean? The default value would be the normal prod image, and then your test would override with the staging image." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `fscanf` to read the number of pairs. You can just use `fgets` to read the number of pairs and then use `fscanf` to read the number of pairs.", + "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.", "reference": "I'm surprised this is needed, but we should probably assert num_scan == 1 at least, otherwise I expect the file is pretty broken." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `network::NetworkUtils::getAvailablePort()` here.", + "prediction": "I'm not sure if this is the right place to put this test, but I think we should move it to `kvstore::kvstore_test` so that it can be used in `kvstore::kvstore_test::kvstore_test` and `kvstore::kvstore_test::kvstore_test::kvstore_test` and `kvstore::kvstore_test::kvstore_test::kvstore_test` and `kvstore::kvstore_test::kvstore_test::kvstore_test` and `kvstore::kvstore_test::kvstore_test::kvstore_test` and `kvstore::kvstore_test::kvstore_test::kvstore_test` and `kvstore::kvstore_test::kvstore_test::kvstore_test` and `kvstore::kvstore_test::kvstore_test::kvstore_test` and `kvstore::kvstore_test::kvstore_test::kvstore_test` and `kvstore::kvstore_test::kvstore_test::kvstore_test` and `kvstore::kvstore_test::kvstore_test::kvstore_test` and `kvstore::kvstore_test::kvstore_test::kvstore_test` and `kvstore::kvstore_test::kvstore_test::kvstore_test` and `", "reference": "Could we set a default value for `partitions` and `{0, network::NetworkUtils::getAvailablePort()}` ?" }, { - "prediction": "I think this should be `double` instead of `double?`.", + "prediction": "Should this be an enum?", "reference": "Needs xml docs. The API names alone don't provide enough explanation about what these mean and how to set them. Also, we should provide some validation of inputs, such as MaxTime must be > MinTime, MinimumRate must be >= 0, etc. Consider making the properties readonly and adding a constructor that does these validations." }, { @@ -9995,11 +9995,11 @@ "reference": "Would it make sense to create an empty file here, perhaps in a tmp dir, instead of checking empty files into Git?" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to do something like this:\r\n\r\n```\r\nfor (size_t i = 0; i < array_lengths.size(); ++i) {\r\n code += \"}\";\r\n for (size_t j = 0; j < array_only_lengths.size(); ++j) {\r\n code += \"}\";\r\n }\r\n}\r\n```", + "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea. The `array_only_lengths` and `array_lengths` variables are not used anywhere in the code, so I don't think it's necessary to include them in the generated code.", "reference": "This change is due to `clang_format` and is not related to this PR." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in `sigprocmask` as well.", + "prediction": "I'm not sure if this is a good idea, but I don't think we need to block SIGSEGV and SIGBUS.", "reference": "Why did you not add the signals to the call of block_all_signals_except() and instead baked them into the function? Ok, if you had a good reason for it, otherwise I would add it to the except list of the function call, since that's what it was meant for." }, { @@ -10007,7 +10007,7 @@ "reference": "Could this be done by mocking objects instead? I feel like this is changing too much of the actual logic just for the tests." }, { - "prediction": "I don't think we need to add a `Long addedSnapshotId = null;` to the `ManifestFileBean` class. The `ManifestFile` class already has a `Long addedSnapshotId = null;` in the `ManifestFile` class.", + "prediction": "I don't think this is needed.", "reference": "why not just use `ManifestContent` instead of `Integer`?" }, { @@ -10015,43 +10015,43 @@ "reference": "can we do that in TxValidator?" }, { - "prediction": "I'm not sure what you mean by \"encapsulates outbound types for a service\". Could you please clarify?", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `Outbounds` struct, since it's the same as the `UnaryOutbound` and `OnewayOutbound` structs.", "reference": "We definitely want some detailed and thoughtful docs being added to this type." }, { - "prediction": "I'm not sure what you're trying to do here. It's not clear what `config.XDPEnabled` is supposed to do.", + "prediction": "I think this should be `if !config.XDPEnabled && dp.xdpState == nil {`", "reference": "We would like this code to run, even when `config.XDPEnabled` is false, so that Felix can clean up its own XDP state after a restart." }, { - "prediction": "I think we should remove the `namespace` from the `DEFINE_` macro.", + "prediction": "I think it's better to use `if (spaceRet.left() == ResultCode::ERR_SPACE_NOT_FOUND)` instead of `if (!ok(s))`.", "reference": "If the status is `ERR_SPACE_NOT_FOUND` why return `SUCCEEDED` ?" }, { - "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here.", + "prediction": "I don't think this is a good idea.", "reference": "It is is more appropriate to use `downsample_first`. If `downsample_first=True`, the downsample block is the first block and it is used for ResNet. If `downsample_first=False`, the downsample block is the last block, which is used by Hourglass network." }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `http.Executor` instead of `http.HttpClient` in this case.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `http.Executor` instead of `http.HttpClient` here. `http.HttpClient` is deprecated and will be removed in the future. `http.Executor` is a better choice.", "reference": "Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`)" }, { - "prediction": "I'm not sure I understand what you're trying to do here. I don't think you want to use sys.exit(). I think you want to use sys.exit(0) or sys.exit(1) or sys.exit(2) or sys.exit(3) or sys.exit(4) or sys.exit(5) or sys.exit(6) or sys.exit(7) or sys.exit(8) or sys.exit(9) or sys.exit(10) or sys.exit(11) or sys.exit(12) or sys.exit(13) or sys.exit(14) or sys.exit(15) or sys.exit(16) or sys.exit(17) or sys.exit(18) or sys.exit(19) or sys.exit(20) or sys.exit(21) or sys.exit(22) or sys.exit(23) or sys.exit(24) or sys.exit(25) or sys.exit(26) or sys.exit(27) or sys.exit(28) or sys.exit(29) or sys.exit(30) or sys.exit(31) or sys.exit(32) or sys.exit(3", + "prediction": "I'm not sure what you mean by \"sys.exit\" or \"sys.exit()\". It's not clear to me what you're trying to do here.", "reference": "I don't know if there are strict conventions about this, but I think the name of the warning should be the diagnosis, not the suggested course of action. In this case, that would mean changing the name of the warning to `interactive-exit` or something like that." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for validating the common name, so that we don't have to do this every time we want to validate the common name.", + "prediction": "I think this should be `cert.Subject.CommonName` instead of `crt.Spec.CommonName`?", "reference": "If `crt.Spec.CommonName` is not set, and `cert.Subject.CommonName` *is* set, we are not correctly handling it here." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.", + "prediction": "I don't think we need to use `usertypes` in this test.", "reference": "This isn't a test, so it shouldn't be named `test_init`. You could name it `cmdhistory_init` or so." }, { - "prediction": "I'm not sure what you mean by \"pickle-protocol\" in this context. Is it the protocol used to serialize and deserialize the pickle files? If so, I'm not sure what you mean by \"pickle-protocol\" in this context. Is it the protocol used to serialize and deserialize the pickle files? If so, I'm not sure what you mean by \"pickle-protocol\" in this context. Is it the protocol used to serialize and deserialize the pickle files? If so, I'm not sure what you mean by \"pickle-protocol\" in this context. Is it the protocol used to serialize and deserialize the pickle files? If so, I'm not sure what you mean by \"pickle-protocol\" in this context. Is it the protocol used to serialize and deserialize the pickle files? If so, I'm not sure what you mean by \"pickle-protocol\" in this context. Is it the protocol used to serialize and deserialize the pickle files? If so, I'm not sure what you mean by \"pickle-protocol\" in this context. Is it the protocol used to serialize and deserialize the pickle files? If so, I'm not sure what you mean by \"pickle-protocol\" in this context. Is it the protocol used to serialize and", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `pickle_protocol` property to the `PySparkTask` class.", "reference": "why is this pulling from `self.spark_version` config section rather than the `spark` config section (`py-packages` appears to pull from a config section called `spark`)" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to change the default value of the `Port` field in the `Options` struct. If you want to change the default value of the `Port` field in the `Options` struct, you should do it in the `Options` struct itself, not in the `Options_RandomPort` function.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to change the default value of `Port` to `0` here.", "reference": "nit: Think it can be one line.." }, { @@ -10059,11 +10059,11 @@ "reference": "please inline imports" }, { - "prediction": "I'm not sure what you mean by \"we can't join cgroups if we're in a rootless container\"", + "prediction": "I think this should be `if len(p.cgroupPaths) > 0 {` instead of `if !p.config.Rootless && len(p.cgroupPaths) > 0 {`", "reference": "This check is still correct in some cases, but I guess erroring out is acceptable if someone explicitly asked for an impossible cgroup configuration (now that we could in principle nest things). I would like to see a test for this though." }, { - "prediction": "I think this is a duplicate of https://github.com/influxdata/flux/issues/1000, but I don't think it's a duplicate of https://github.com/influxdata/flux/issues/855.", + "prediction": "I'm not sure if this is the right place to add this, but I think it would be good to add it to the `querytest` package as well.", "reference": "Should we update integral to operate on a single column as well?" }, { @@ -10071,59 +10071,59 @@ "reference": "Doesn't belong to this PR" }, { - "prediction": "I think this should be `SubmitTaskStateChange` instead of `SubmitTaskStateChangeStateChange`.", + "prediction": "I think this should be `RegisterContainerInstance` and `SubmitTaskStateChange` should be `RegisterContainerInstance` and `SubmitTaskStateChange` respectively.", "reference": "Just for my own understanding, does aws ecs API take this token as a new input attribute? Which version of the aws sdk? I did not find it in the official aws sdk doc." }, { - "prediction": "I think this should be `SF_APP_FEATURE_CODE_USER_AUTH` instead of `SF_APP_FEATURE_CODE_USER_AUTH_USER_AUTH`.", + "prediction": "I think it's better to use `String` instead of `StringBuffer` here. `StringBuffer` is not thread-safe.", "reference": "Could we shorten this constant to maybe `FEATURE_USER_AUTH`?" }, { - "prediction": "I think this should be `numRekeyWorkers` instead of `numRekeyWorkers = 8`", + "prediction": "I don't think this is necessary. We can just use the default number of workers.", "reference": "Any particular reason for 8? I feel like we could probably handle more..." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the job is deleted when the user is logged out.", "reference": "Try to use factory association declaration for default values, so it could minimal the line length. You may write in fetch_job factory like association :repository, factory: :repository." }, { - "prediction": "I don't think this is a good idea.", + "prediction": "I don't think we need to change this.", "reference": "Should the \"cancelled\" class be added regardless of the proposal's state?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to set up an event emitter, but I'm not sure what you're trying to do here. I think you're trying to set up an event emitter, but I'm not sure what you're trying to do here. I think you're trying to set up an event emitter, but I'm not sure what you're trying to do here. I think you're trying to set up an event emitter, but I'm not sure what you're trying to do here. I think you're trying to set up an event emitter, but I'm not sure what you're trying to do here. I think you're trying to set up an event emitter, but I'm not sure what you're trying to do here. I think you're trying to set up an event emitter, but I'm not sure what you're trying to do here. I think you're trying to set up an event emitter, but I'm not sure what you're trying to do here. I think you're trying to set up an event emitter, but I'm not sure what you're trying to do here. I think you're trying to set up an event emitter, but I'm not sure what you", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a `MongoClient` constructor that takes `options` as an argument. This way, we don't have to pass `options` every time we create a new `MongoClient` instance.", "reference": "nit: random whitespace change, let's try to keep these out of commits unless there are other useful changes." }, { - "prediction": "I think it's a good idea to add a check to see if the model is a string, and if so, split it into an array of strings.", + "prediction": "I'm not sure I understand what you're trying to do here. You're creating a new `PopulateOptions` object for each path in the `paths` array. Then you're passing that object to the `PopulateOptions` constructor, which expects a single `PopulateOptions` object. Is this what you're trying to do?", "reference": "Seems kinda dangerous - what if models length is different from paths length?" }, { - "prediction": "I'm not sure if this is the best place to do this, but I think it's a good place to do this.", + "prediction": "I'm not sure if this is the best place to do this, but I think it's a good idea to do this in the `StageSenders` struct.", "reference": "set real one plz (get it from DB)." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the `uafu_irq_buf` is large enough to hold the `uafu_irq` struct.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that `uafu_irq_buf` is large enough to hold the `uafu_irq` struct.", "reference": "Should this be initialized to zeroes?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `searcher` class.", + "prediction": "I think this should be `if (q == null || fcontext.base.size() == 0)` instead of `if (q == null && fcontext.base.size() == 0)`.", "reference": "The query is already built at this point, so I don't think this particular change actually helps wrt SOLR-10732? (and the `base.size()==0` case is already trivially optimized in `SolrIndexSearcher.numDocs(Query, DocSet)`)" }, { - "prediction": "I don't think this is a good idea. The `WorldPoint` class is not part of the `net.runelite.api` package. It's part of the `net.runelite.api.coords` package, which is not part of the `net.runelite.api` package.", + "prediction": "I don't think this is needed anymore.", "reference": "re-add the type in the annotation here" }, { - "prediction": "I'm not sure what you mean by \"latestReleaseData, err := cmd.Output() if err != nil\". I think it should be \"latestReleaseData, err := cmd.Run() if err != nil\".", + "prediction": "I don't think we need to use `fmt.Errorf` here. We can just use `errors.New` here.", "reference": "Could we simpify it as `cmd.Stderr = &bytes.Buffer{}`?" }, { - "prediction": "I think this should be `X509Expired` instead of `ShouldRotateX509`.", + "prediction": "I think it's better to return `true` if the JWT is expired, and `false` if it's not.", "reference": "there's enough \"nots\" in here that while it's correct by my review, I'd like to see a small unit test (just passing in an expired and non-expired cert)" }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it's a good idea to move it to the `isotope/convert/pkg/graph` package.", + "prediction": "I'm not sure if this is the right place to add this, but I think it would be good to add it to `isotope/convert/pkg/graph/svc` as well.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { @@ -10131,7 +10131,7 @@ "reference": "The config option should probably have a more specific name. Also it's not for all gridded data but specifically for Images (and its subclasses)." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a test for this in `UserPreferencesTest` as well.", "reference": "Be careful. This is not a preference but an option in a dialog." }, { @@ -10139,51 +10139,51 @@ "reference": "this will modify the incoming object, which may not be desirable in some cases. i think we should stick with the local var, override it with deployment.ClusterName if deployment.ClusterName not empty" }, { - "prediction": "I think we can remove the `await server.stop()` as it's not needed anymore.", + "prediction": "I think we can remove the `await server.stop()` here.", "reference": "Is this not required?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `initInputShape` method.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `initSvg` method.", "reference": "You're using scare quotes on these terms instead of defining them." }, { - "prediction": "I'm not sure if this is a good idea or not, but I think it would be better to have a separate `DockerComposeVersionConstraint` and `DockerVersionConstraint` for the `DockerCompose` and `Docker` versions, respectively.", + "prediction": "I'm not sure if this is a good idea or not, but I think it's better to use `DockerComposeVersionConstraint` instead of `DockerVersionConstraint`.", "reference": "These should both be const, not var right?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `SettingsManager` class, so that it can be called from anywhere in the application.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use a `try-with-resources` block to ensure that the `FileOutputStream` is closed after the `DefaultPropertiesPersister` is closed.", "reference": "Can you catch a more specific exception here? Thanks :-)" }, { - "prediction": "I'm not sure what you mean by \"start failure action\". I think you meant to say \"start recovery action\" or something like that.", + "prediction": "I don't think this is necessary.", "reference": "This is a bug during handling the recover logic in `common chaos` controller, I fixed in this request when I found it." }, { - "prediction": "`score_thr` should be `score_thr=0.3` instead of `score_thr=0.3`", + "prediction": "`score_thr=0.3` should be `score_thr=0.3`", "reference": "During testing, we adopt the score threshold specified in the config file. Here the threshold is only used for visualization, and the variable name `score_thr` can be misleading. Renaming it to `show_score_thr` would be better." }, { - "prediction": "I don't think you need to use `has_nav_menu('primary_navigation')` here. You can just use `has_nav_menu('primary_navigation')` directly.", + "prediction": "I don't think you need to use `has_nav_menu` here. You can use `is_nav_menu` instead.", "reference": "can you make this `nav-primary` please? i'd like to roll with this since the `
    ` class is `nav`, and primary is the name of the navigation menu" }, { - "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to get the public URL for the calendar, but I don't think that's what you're trying to do.", + "prediction": "I don't think we need to do this.", "reference": "@georgehrke Just out of curiosity. Couldn't you combine at least the combine the regex for '-' and '' with groups?" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get the type of an object at a given address, but it's failing. I'm not sure what you're trying to do here, but it looks like you're trying to get the type of an object at a given address, but it's failing. I'm not sure what you're trying to do here, but it looks like you're trying to get the type of an object at a given address, but it's failing. I'm not sure what you're trying to do here, but it looks like you're trying to get the type of an object at a given address, but it's failing. I'm not sure what you're trying to do here, but it looks like you're trying to get the type of an object at a given address, but it's failing. I'm not sure what you're trying to do here, but it looks like you're trying to get the type of an object at a given address, but it's failing. I'm not sure what you're trying to do here, but it looks like you're trying to get the type of an object at a given address, but it's failing. I'm not sure", + "prediction": "I'm not sure what you mean by \"anyObject_type\" in this context. I think you meant \"ast_ctx->GetAnyObjectType()\".", "reference": "I think this is objectively better than looking up the object by name. As a follow-up, I'm going to see whether we do this name-based lookup somewhere else and switch to your method." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to move it to `FlyoutExtensionCategoryHeader` as well.", + "prediction": "I don't think this is needed.", "reference": "Why are you dividing by scale in the LTR case but not the RTL case?" }, { - "prediction": "I'm not sure if this is the right place to add this command, but I think it's a good idea to add it to the list of commands that can be used to minimize the window.", + "prediction": "I'm not sure if this is the right place to add this command. I think it should be in `Command.W3C_MINIMIZE_WINDOW` and `Command.W3C_MAXIMIZE_WINDOW`.", "reference": "Update after command rename" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `googlesitekit.ModuleSettingsDetails-${ moduleSlug }` filter name for the `googlesitekit.SettingsLegacy` filter. This is because the `googlesitekit.ModuleSettingsDetails-${ moduleSlug }` filter name is the same as the `googlesitekit.SettingsLegacy-${ moduleSlug }` filter name, and the `googlesitekit.SettingsLegacy-${ moduleSlug }` filter name is the same as the `googlesitekit.ModuleSettingsDetails-${ moduleSlug }` filter name. This way, the `googlesitekit.ModuleSettingsDetails-${ moduleSlug }` filter name will always be used for the `googlesitekit.SettingsLegacy` filter, and the `googlesitekit.SettingsLegacy-${ moduleSlug }` filter name will always be used for the `googlesitekit.ModuleSettingsDetails-${ moduleSlug }` filter. This way, the `googlesitekit.ModuleSettingsDetails-${ moduleSlug }` filter name will always be used for the `googlesitekit.SettingsLegacy` filter, and the `googlesitekit.SettingsLegacy-${ moduleSlug }` filter name will always be used for", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `googlesitekit.ModuleSettingsDetails-${ moduleSlug }` filter name for the `googlesitekit.SettingsLegacy` filter. This is because the `googlesitekit.ModuleSettingsDetails-${ moduleSlug }` filter name is the same as the `googlesitekit.SettingsLegacy-${ moduleSlug }` filter name, and the `googlesitekit.SettingsLegacy-${ moduleSlug }` filter name is the same as the `googlesitekit.ModuleSettingsDetails-${ moduleSlug }` filter name. This way, the `googlesitekit.ModuleSettingsDetails-${ moduleSlug }` filter name will be used for both the `googlesitekit.SettingsLegacy` and `googlesitekit.ModuleSettingsDetails-${ moduleSlug }` filters, and the `googlesitekit.SettingsLegacy-${ moduleSlug }` filter name will be used for both the `googlesitekit.SettingsLegacy` and `googlesitekit.ModuleSettingsDetails-${ moduleSlug }` filters, and the `googlesitekit.ModuleSettingsDetails-${ moduleSlug }` filter name will be used for both the `googlesitekit.SettingsLegacy` and `", "reference": "I added this change to fix a bug with the legacy settings wrapper which was preventing it from working properly with the other modules" }, { @@ -10195,19 +10195,19 @@ "reference": "Please don't leave an empty default" }, { - "prediction": "I'm not sure what you mean by \"See the License for the specific language governing permissions and limitations under the License.\"", + "prediction": "I'm not sure if this is the right place to put it, but I think it's a good idea to add it to the `@wordpress/core` package.", "reference": "This isn't directly related, but the `import React from 'react';` below should be removed. We never import this directly and any modules from it we need are imported through `@wordpress/element`. This was probably added automatically at some point, but we also provide this automatically via `ProvidePlugin`." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to run `brew update` and `brew upgrade` before running `brew install` to make sure we're on the latest stable version of R.", + "prediction": "I'm not sure if this is a good idea or not, but I think it would be better to use `brew install` instead of `brew update` and then `brew install` again.", "reference": "You can also use `echo: false` instead. Either is fine; I'm just pointing it out." }, { - "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here.", + "prediction": "I don't think this is a good idea.", "reference": "what's the reason for this moved line?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to move this to `getCardTextLines` so that it can be used by `getCardText` as well.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `getCardTextLines` function.", "reference": "I don't really follow what is happening here, but it looks like this _could_ conflict with the logic on the lines above... should this be an `else if`?" }, { @@ -10215,27 +10215,27 @@ "reference": "`s => s.IsHidden == false` What's the purpose of adding this?" }, { - "prediction": "I don't think we need to add `optionNameClefSignerAddress` to the list of options. It's already defined in `optionNameClefSignerEnable` and `optionNameClefSignerAddress` is just an alias for `optionNameClefSignerEnable`.", + "prediction": "I don't think it's necessary to use `optionNameClefSignerAddress` and `optionNameClefSignerAddress` for the same reason as `optionNameClefSignerAddress` and `optionNameClefSignerAddress` for `optionNameClefSignerAddress` and `optionNameClefSignerAddress` for `optionNameClefSignerAddress` and `optionNameClefSignerAddress` for `optionNameClefSignerAddress` and `optionNameClefSignerAddress` for `optionNameClefSignerAddress` and `optionNameClefSignerAddress` for `optionNameClefSignerAddress` and `optionNameClefSignerAddress` for `optionNameClefSignerAddress` and `optionNameClefSignerAddress` for `optionNameClefSignerAddress` and `optionNameClefSignerAddress` for `optionNameClefSignerAddress` and `optionNameClefSignerAddress` for `optionNameClefSignerAddress` and `optionNameClefSignerAddress` for `optionNameClefSignerAddress` and `optionNameClefSignerAddress` for `optionName", "reference": "I would name this `clef-ethereum-address`. We already have a bunch of addresses in Bee, and people might wrongly think that this is yet another address" }, { - "prediction": "I think this should be `rdDepictor.Compute2DCoords(m)` instead of `rdDepictor.Compute2DCoords(m)`.", + "prediction": "I don't think this is a good idea. It would be better to have a separate test for this.", "reference": "you can just remove this" }, { - "prediction": "I don't think we need to do this, we can just use the `upgrade-cstor-pool-` and `upgrade-cstor-volume-` for now.", + "prediction": "I don't think we need to do this, we can just use the `storagePoolClaim` and `cstorVolume` for now.", "reference": "I think we should avoid creating a dummy CR in the case of SPC. Please see if we can avoid this since we will not be patching anything in this CR." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate page for locked features.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate page for locked features, so that the user doesn't have to go to the locked_features page every time they want to see a locked feature.", "reference": "Honestly not sure myself, but do you think it makes sense to move this conditional into the partial?" }, { - "prediction": "I'm not sure what you mean by `prefix='qutebrowser-prefix-'` in the `args.basedir` line. I think it should be `prefix='qutebrowser-prefix'`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `main.py` file.", "reference": "As discussed in IRC (just so it doesn't get lost): This probably should be `-basedir-`, not `-prefix-`" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `DbOnTheRocks` class.", + "prediction": "I'm not sure if this is the best place to put it, but I think it's a good idea to have a `DbOnTheRocks` constructor that takes a `DbConfig` and a `LogManager` as parameters. This way, you don't need to call `DbOnTheRocks(string basePath, string dbPath, IDbConfig dbConfig, ILogManager logManager = null)` every time you create a new `DbOnTheRocks` instance.", "reference": "basepath can be absoluta path and this needs to be supported" }, { @@ -10243,31 +10243,31 @@ "reference": "Didn't get to the commit message" }, { - "prediction": "I think this should be `raise ActiveRecord::RecordNotFound` instead of `raise ActiveRecord::RecordNotFound`", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `show` action for the `DesignForDevelopersResourcesController` so that the user doesn't have to go to the `/design_for_developers_resources/show` URL to see the resource.", "reference": "What about raising `ActionView::MissingTemplate` instead? That's what HighVoltage does." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `nano::json_handler::account_balance` instead of `nano::json_handler::account_balance_pending`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `account_balance` handler.", "reference": "Is it kept for compatibility?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to make sure the miner address is valid before trying to get the miner control addresses.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check to see if the miner address exists before trying to get the miner control addresses.", "reference": "I would find it pretty reasonable to add a MinerSigner method on the state view that puts these together." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `onUpgrade` method of the `PodDBAdapter` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `onUpgrade` method of the `PodDBAdapter` class.", "reference": "It's stored in `PodDBAdapter.VERSION`. I usually use the expected release version code for that change. As this will be released in AntennaPod 2.2.0, the code would be `2020000`." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `fmt.Errorf` function to format the error message. This way, the user will be able to see the exact error message they are getting.", + "prediction": "I don't think we need to use `replaceAllString` here. We can use `replaceString` instead.", "reference": "What about method name itself? Do we run this for SQL too?" }, { - "prediction": "I think this should be `instanceUrl = \"https://mobilesdk.cs1.my.salesforce.com\";` instead of `instanceUrl = \"https://cs1.salesforce.com\";`", + "prediction": "I think this should be `instanceUrl = \"https://mobilesdk.cs1.my.salesforce.com\";`", "reference": "`instanceUrl` should be `cs1.salesforce.com`. `communityUrl` would be `mobilesdk.cs1.my.salesforce.com`." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `adios2::core::VariableBase` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `adios2::core::VariableBase` class.", "reference": "Let's use `if(name != nullptr)` to remove ambiguity" }, { @@ -10275,15 +10275,15 @@ "reference": "I wonder if it would make sense to have a separate namer for metadata? Metadata files tend to be expressed in a different language from the repo language, and have mutually exclusive concepts. So, `PackageMetadataNamer`." }, { - "prediction": "Shouldn't this be `extraDataValidatorsAndVoteMustBeEmpty` instead of `extraDataValidatorsAndVoteMustBeEmpty`?", + "prediction": "I don't think we need to do anything here.", "reference": "This rule is quite specific to qbft and so I don't think it should be part of the common rules. Would rather the common bft code didn't know anything about contract based voting/validator governance." }, { - "prediction": "I think this should be `LinkedHashSet` instead of `SortedSet`?", + "prediction": "I think this should be `LinkedSet` instead of `LinkedHashSet` because `LinkedSet` is a subclass of `LinkedHashSet` and `LinkedHashSet` is a subclass of `SortedSet` and `SortedSet` is a subclass of `Set` and `Set` is a subclass of `VavrSet` and `VavrSet` is a subclass of `Set` and `Set` is a subclass of `VavrSet` and `VavrSet` is a subclass of `Set` and `Set` is a subclass of `VavrSet` and `VavrSet` is a subclass of `Set` and `Set` is a subclass of `VavrSet` and `VavrSet` is a subclass of `Set` and `Set` is a subclass of `VavrSet` and `VavrSet` is a subclass of `Set` and `Set` is a subclass of `VavrSet` and `VavrSet` is a subclass of `Set` and `Set` is a subclass of `VavrSet` and `VavrSet` is a subclass of `Set` and `Set` is a subclass of `VavrSet` and `VavrSet` is a", "reference": "This makes our life harder than it needs to be. A Set is unordered by definition. Please remove this method from Set and add it to SortedSet, but with no default implementation. We need to duplicate it then to LinkedHashSet but that's ok, it is the best we can do. Could you please add it also to SortedMap and LinkedHashMap? We are then able to close the original issue." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `build_base_http_request` method.", + "prediction": "I think we should remove the `headers` argument from the `build_base_http_request` method.", "reference": "we can replace `for` with `params.update(response_headers)`" }, { @@ -10295,11 +10295,11 @@ "reference": "I wonder if it's necessary to let app pass in the context. What app level context should be sent? If no, is it enough for p2p agent to compose a context with network info there?" }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place to put this. I'm not sure if this is a good place to put this, but I think it's a good place", + "prediction": "I'm not sure why we need to include `lbann/execution_contexts/sgd_execution_context.hpp` and `lbann/execution_contexts/sgd_execution_context.hpp` here. I think we can just include `lbann/execution_contexts/sgd_execution_context.hpp` and `lbann/execution_contexts/sgd_execution_context.hpp` in `lbann/layers/io/input_layer.hpp`.", "reference": "Why do we need both includes here?" }, { - "prediction": "I'm not sure if this is a good idea or not, but I think it would be better to use `cursor.getString(1)` instead of `cursor.getString(0)`.", + "prediction": "I think you should use `cursor.getString(0)` instead of `cursor.getString(1)`.", "reference": "SmartStoreInspectorTest expected results in a certain order" }, { @@ -10307,63 +10307,63 @@ "reference": "I think that you need something like `m_using_random_node.emplace(m_io_thread_pool->get_local_thread_id());`" }, { - "prediction": "I'm not sure what you mean by \"isIgnorablePrefixIncrement\" and \"isUsedLocalVarWithoutInitializer\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `isUsedLocalVarWithoutInitializer` to the `isIgnorablePrefixIncrement` method.", "reference": "I don't think we need to maintain a separate set. The problem here is that the \"assignment\" that is killed for this variable is not really an assignment. If we just don't `assign` the variable with the non-existent value, it will not be reported. I pushed a fix." }, { - "prediction": "I'm not sure what you mean by \"target split size\". Is it the size of the target table? Or the size of the target partition?", + "prediction": "I don't think this is needed anymore.", "reference": "Let me know if this is too pervasive. It is currently a private method in `BaseTableScan`. It seems both `SparkBatchQueryScan` and `SparkMergeScan` need to know the scan-specific split size when planning tasks. Therefore, I made it open. Another approach is to move all the `planTasks` logic to scan implementations, but for the combine tasks by partition feature, it requires grouping scan tasks by partition first, instead of returning them in an iterator fashion. I'm not sure if this is OK. `SparkMergeScan` also seems to re-implemented its own plan tasks logic." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to add a newline to the end of the trace message. I'm not sure what you're trying to do here, but it looks like you're trying to add a newline to the end of the trace message. I'm not sure what you're trying to do here, but it looks like you're trying to add a newline to the end of the trace message. I'm not sure what you're trying to do here, but it looks like you're trying to add a newline to the end of the trace message. I'm not sure what you're trying to do here, but it looks like you're trying to add a newline to the end of the trace message. I'm not sure what you're trying to do here, but it looks like you're trying to add a newline to the end of the trace message. I'm not sure what you're trying to do here, but it looks like you're trying to add a newline to the end of the trace message. I'm not sure what you're trying to do here, but it looks like you're trying to add a newline to the end of the trace message. I'm not sure what you're trying", + "prediction": "I think we can remove the `fmt.Sprintf` here.", "reference": "Not sure what is this change doing?" }, { - "prediction": "I think this should be `exp` instead of `exp=None`.", + "prediction": "I think this should be `exp` instead of `exp=None`?", "reference": "this is funky. either don't take` minutes` as keyword arg or take both `minutes` and `days` and pass all of them on to `timedelta`. i'm guessing you're aiming for backwards compatibility, but i don't think it's worth it given how confusing this is. atlernatively, make `mins=60*24*30` the default. and that brings me to another issue, `mins=None` is not a very useful default." }, { - "prediction": "I'm not sure what you mean by \"key == null\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the key is null, and if so, set it to the default value.", "reference": "Please use a tab for indentation instead of spaces." }, { - "prediction": "I don't think this is a good idea. The `@SuppressWarnings(\"deprecation\")` should be on the `AbstractQueue>` instead of the `Queue`.", + "prediction": "Shouldn't this be `@SuppressWarnings(\"deprecation\")` instead of `@SuppressWarnings(\"deprecation\")`?", "reference": "I can't believe we didn't see this typo before :))" }, { - "prediction": "I'm not sure if this is the right place to put it, but I think we should move it to `google.cloud.forseti.services.inventory.base.crawler.CrawlerConfig`.", + "prediction": "I don't think we need to use `log_util.get_logger(__name__)` here. We can just use `logging.getLogger(__name__)` instead.", "reference": "If the logger isn't used, it probably doesn't need to be added." }, { - "prediction": "I think this should be `document.head.appendChild(script)` instead of `document.head.appendChild(script.type = 'text/javascript')`", + "prediction": "I don't think this is necessary. We can just use `window.onload` instead.", "reference": "These files should in `/javascript/brython`" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it", + "prediction": "I think this should be `if imageAlpha != nil && len(imageAlpha.RolloutOverride.DefaultRolloutTime) > 0 { return true; }`", "reference": "minor, you can squash these into one `if`" }, { - "prediction": "I'm not sure what you're trying to do here. It seems like you're trying to register a namespace task with a global namespace, but you're not actually doing anything with it.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `string` type for the `id` and `name` fields. The `string` type is more flexible than the `UUID` type.", "reference": "Used regexes to do most of this, hence different methods of string creation of UUIDs. I plan to follow up with an additional change to remove direct references to google/pborman UUID so `uuid.New()` and `uuid.NewRandom()` will instead use our `primitives.UUID`." }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to remove the `if (GraphSummary.IsHandleCreated && !GraphSummary.Disposing)` check.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to move this into the `GraphSummary` class, so that we don't have to do this in the `GraphSummary` constructor.", "reference": "Add a TODO here to revisit if this was problematic." }, { - "prediction": "I don't think we need to change the default value of `reg_decoded_bbox` to `False` in the `AnchorHead` class. We can just set it to `True` in the `SSDHead` class.", + "prediction": "I don't think we need to change the default value of `reg_decoded_bbox` to `False`.", "reference": "Note generally it -> It" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a check for `type == \"directed_acyclic_graph_model\"` in the `new_directed_acyclic_graph_model` function.", + "prediction": "I'm not sure if this is a good idea, but I don't think we need to do this.", "reference": "Is this relevant to this PR?" }, { - "prediction": "I think this should be `if block_hosts.length > 0` instead of `if block_hosts.is_a? Array`.", + "prediction": "I'm not sure I understand what you're trying to do here. The `block_on` method is used to run a block of code in a separate thread. It's not clear what you're trying to do with `opts[:run_in_parallel] == true`.", "reference": "Can we instead ensure that `opts[:run_in_parellel]` will always be a boolean? Otherwise we'll have to account for the case when it's a non-boolean value in multiple places, such as any/every other `if` statement." }, { - "prediction": "I think we should use `net.Dial` instead of `net.Dialer` here.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use the same name as the OpenTelemetry specification. It's not clear to me why we would want to use a different name for the OpenTelemetry specification.", "reference": "Is this just moved out of the other files? It doesn't seem like this was generated like the other files." }, { @@ -10371,23 +10371,23 @@ "reference": "I started out doing everything `async`, but it was getting in the way of debugging, so I switched back to all synchronous until I got things working. We should probably move everything back to `async` and remove the synchronous versions." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.", + "prediction": "I'm not sure if this is the best place to put it, but I think it's a good idea to have it in the `BlockProducerEnvFactory.cs` file.", "reference": "this looks already too complicated..." }, { - "prediction": "I think this test should be moved to a separate test file.", + "prediction": "I think this test should be moved to a separate file, since it's not related to RocksDB.", "reference": "As for the testings, we better to verify the actual effects of the compaction. Of course, you could do it in future." }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.", + "prediction": "I don't think we need to remove the `isView` check here.", "reference": "should we add a TODO here?" }, { - "prediction": "I think we should use `Root` instead of `DashboardDetailsApp` here.", + "prediction": "I think it's better to use `Root` instead of `ErrorHandler` here.", "reference": "This can be inlined below as `GoogleSitekitDashboardDetails` is an unnecessary wrapper now." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think we need to use the `versionhistory.NewVersionHistories` function here. We can just use `versionhistory.NewVHS(versionHistory)` directly.", + "prediction": "I'm not sure what you're trying to do here, but I don't think we need to do that.", "reference": "NewVHS -> NewVersionHistories this one looks better" }, { @@ -10395,7 +10395,7 @@ "reference": "Is this `@missing_text` ?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don", + "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", "reference": "Minor suggestion, but wouldn't it be cleaner to simply replace PACKAGE_NAME_FORMAT to all the optional path, then check that the path is empty in validate_package_name? We might also want a helper function to pull out the package name and sub-package path." }, { @@ -10403,31 +10403,31 @@ "reference": "we should have a way to insert components into a i18n string. so that we could define a translation string like `'%{filename} is being edited'`, and inject the filename `` at the right place. I imagine there must be a language where the `Editing` text should come after the file name. we can think about that later tho." }, { - "prediction": "I think this should be `if (!pglob.gl_pathv[0])` instead of `if (!pglob.gl_pathv)`", + "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to use `pglob.gl_pathc` and `pglob.gl_pathv`, but you're not using them correctly. You should be using `pglob.gl_pathc` to get the number of paths and `pglob.gl_pathv` to get the paths themselves.", "reference": "Probably want break instead of continue." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think it's a good idea to set `o.NoLog` to `true` in this case. I think it's a good idea to set it to `false` in this case.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a default value for `o.StoreDir` in the `Options` struct. This way, if the user doesn't provide a value for `o.StoreDir`, the default value will be used.", "reference": "This was on purpose that I would set logging (NoLog=false) and a dummy logger below. The idea is to have better code coverage and test of debug/trace statements. Any reason you have removed this?" }, { - "prediction": "I think we can remove the `findFirst` call here, since we already have a `Stream` in the `prefixStream` variable.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the type is a String, and if it is, then we want to use the `toString` method to convert it to a String.", "reference": "does adding a `Stream.empty()` help here?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a list of scanners that are enabled by default, and a list of scanners that are not enabled by default. This way, we don't have to worry about accidentally enabling a scanner that we don't want to.", + "prediction": "I don't think this is a good idea. I think it's better to have a list of scanners that are enabled by default and a list of scanners that are not enabled by default. This way you can have a list of scanners that are enabled by default and a list of scanners that are not enabled by default.", "reference": "This is not being used anymore, so can be removed." }, { - "prediction": "I'm not sure what you mean by \"same IP strings\" in this context. Could you please clarify?", + "prediction": "I think this should be `if len(p.ipStrings) == 0 && len(p1.ipStrings) == 0 { return true; }`", "reference": "Is it called some where?" }, { - "prediction": "I don't think we need to use `_` here. We can just use `fmt` instead.", + "prediction": "I don't think we need to use `_` here, we can just use `k8s.io/client-go/third_party/forked/golang/template` and `k8s.io/client-go/util/jsonpath`", "reference": "Please remove this extra blank line." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to move it to the `@InputFiles` annotation so that it can be used in other tasks as well.", + "prediction": "I'm not sure if this is the best place to put this, but I think it would make sense to move it to the `@InputFiles` annotation so that it can be used in other tasks as well.", "reference": "this is really the key, if you don't set this then gradle doesn't wire up the tasks that produce various files inside these configurations as inputs... I think we were just getting lucky before." }, { @@ -10435,19 +10435,19 @@ "reference": "Sorry if I'm missing something here, but shouldn't this message be about failing to match with an *empty* selector, and/or perhaps even an empty *tag* instead of selector? The message seems a bit disconnected from what we're testing?" }, { - "prediction": "I think this should be `using Microsoft.TestPlatform.VsTestConsole.TranslationLayer.Payloads` instead of `using Microsoft.TestPlatform.VsTestConsole.TranslationLayer.Payloads`", + "prediction": "I don't think this is necessary.", "reference": "nit: please move these inside namespace." }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it's a good idea to have this in the `flag` package. It's a bit more specific than the `flag` package, but I think it's a good idea to have this in the `flag` package as well.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `flag` package as well.", "reference": "may users try to abuse it?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. The `new_buf_size` should be the same as the `old_buf_size`, and the `nbb.position(new_buf_size - old_buf_size)` should be the same as the `nbb.capacity() - old_buf_size`.", + "prediction": "I'm not sure I understand what you're trying to do here. The `new_buf_size` should be the same as the `old_buf_size`, right?", "reference": "why is this space removed?" }, { - "prediction": "I think we should remove the `go:build !windows` comment.", + "prediction": "I think this should be `+build windows` instead of `+build !windows`", "reference": "Can we remove this other line now then?" }, { @@ -10455,19 +10455,19 @@ "reference": "There's a comma missing here at the end :wink:" }, { - "prediction": "I think we should remove the `PublishFlatContainer` and `Overwrite` fields.", + "prediction": "I think this should be `public bool PublishFlatContainer { get; set; }` instead of `public ITaskItem[] ItemsToPush { get; set; }`", "reference": "Why is this not required any longer?" }, { - "prediction": "I don't think we need to use `paginater` here. We can just use `gogs`'s built-in pagination.", + "prediction": "I don't think we need to use `paginater` here.", "reference": "Indentation seems a bit fucked up here. Run `go fmt`." }, { - "prediction": "I'm not sure what you're trying to do here. I think you want to be able to pass in a filter, but if you don't have one, you should return an error.", + "prediction": "I'm not sure what you mean by \"empty filter\". I think you meant to say that the filter is nil.", "reference": "any chance in == nil? same below" }, { - "prediction": "I think this should be `listen(listen_fd, H2O_SOMAXCONN)` instead of `listen(listen_fd, H2O_SOMAXCONN)`.", + "prediction": "I think it's better to use `h2o_sysfn(bind, listen_fd, (void *)sa, sizeof(*sa))` instead of `h2o_sysfn(bind, listen_fd, (void *)sa, sizeof(*sa)) == -1`", "reference": "We would change the source code of h2o so that certain syscalls will be invoked through the `h2o_sysfn` macro." }, { @@ -10475,35 +10475,35 @@ "reference": "the name kTimelineCannotBeSignalled is confusing. It's not that a TimelineSemphore cannot be signaled... it's the \"VK_KHR_timeline_semaphore is enabled *variant* of the \"binary cannot be signaled\" message. We should probably have a consistent naming scheme to clarify. kBinaryCannotBeSignalledAltTimeline or hide the complexity in Get*VUID functions as needed somehow (pass in the extension structure?)" }, { - "prediction": "I'm not sure I understand what you're trying to do here. What do you mean by \"describe\"?", + "prediction": "I'm not sure what you mean by \"include\" and \"exclude\". I think you mean \"include\" and \"exclude\" in the sense that you want to include only the columns that you want to include, and exclude the columns that you don't want to include.", "reference": "Could you add a type hint? `percentiles: Optional[List[float]] = None`" }, { - "prediction": "I'm not sure what you're trying to do here, but I think it's a bit of a mix-up. The `approver_options` method should be called `approver_options`, not `approver_options_options`.", + "prediction": "I'm not sure what you're trying to achieve with this, but I think it would be better to just use `Ncr::WorkOrder.where.not(building_number: nil)` instead of `custom + Ncr::BUILDING_NUMBERS`.", "reference": "Maybe putting ones they've used before first would be good, but this is fine for now." }, { - "prediction": "I'm not sure what you mean by \"noencTarget\" and \"bhTarget\" in this context. Could you please clarify?", + "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea. The `noencTarget` and `bhTarget` should be the same as the `blackHoleProto` and `blackHoleProto` respectively.", "reference": "I don't think we need these. Simpler just to put `routetable.TargetType...` inline below." }, { - "prediction": "I'm not sure what you mean by \"dynamic dispatch for selection\" but I think we should be able to do this with a single line of code.", + "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to do this with a single line of code.", "reference": "Why this instead of the old way?" }, { - "prediction": "I'm not sure if this is a good place to do this, but I think it's a good idea to check if `this` is invisible to `other` before calling `BuffFadeByEffect(SE_Charm)`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do it here.", "reference": "Just combining the inner if/else blocks like this is what I originally meant (I didn't mean replacing all the invisible checks in the outer if, I realize that would have been a functionality change regarding the rule) This should now be equivalent to `if (RuleB(Pets, LivelikeBreakCharmOnInvis) || IsInvisible(formerpet))` (the second check for the rule being false after the `||` would be implied, anything after the `||` would only be evaluated if the rule was false)" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this. It's not clear to me how this is going to be used in the future.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.", "reference": "We don't want to write this back to the definition do we? Probably just want to create a local variable for it." }, { - "prediction": "I'm not sure what you mean by \"clearCurrentlyPlayingTemporaryPlaybackSpeed\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to `MediaBrowserServiceCompat` as well.", "reference": "Good catch! Could you please move this to `PlaybackService.this.onPlaybackEnded`? I think it's more clean if everything is in one single place." }, { - "prediction": "I'm not sure what you mean by \"in progress to allow drop it into an app\". It's not clear to me what you're trying to do here.", + "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.", "reference": "We're trying to avoid X.org specific code. So I'm not a fan of this. Can't this be achieved in display server agnostic way?" }, { @@ -10511,19 +10511,19 @@ "reference": "This class can be removed?" }, { - "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to add it to the `prometheus` package as well.", + "prediction": "I don't think we need to use `grpc_prometheus` here. We can just use `prometheus` instead.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { - "prediction": "I'm not sure what you mean by \"export this when we're ready to deploy a branch in demo-yarpc-go\"", + "prediction": "I'm not sure if this is the right place to add this, but it seems like it would be a good place to add this. I'm not sure if this is the right place to add this, but it seems like it would be a good place to add this. I'm not sure if this is the right place to add this, but it seems like it would be a good place to add this. I'm not sure if this is the right place to add this, but it seems like it would be a good place to add this. I'm not sure if this is the right place to add this, but it seems like it would be a good place to add this. I'm not sure if this is the right place to add this, but it seems like it would be a good place to add this. I'm not sure if this is the right place to add this, but it seems like it would be a good place to add this. I'm not sure if this is the right place to add this, but it seems like it would be a good place to add this. I'm not sure if this is the right place to add this, but it seems like it would be a good place to add this. I'm not sure", "reference": "To minimize the possibility of regret, perhaps we name this `ZapLogger`." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `Proc.new` here. You can just use `Proc.new { |current_user| ... }` and it will work.", + "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `Proc.new` here. You can just use `Proc.new { |current_user| current_user.company_name }`.", "reference": "This looks a little weird, but it's a feature of the gem we're using. You can give it a symbol representing the method you want called on current_user." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to use the `Anomaly` class from the `nupic.algorithms.anomaly` module to replace the `$XXXXXXXX` tokens in the `description.py` file with desired values. Is this what you're trying to do? If so, please let me know and I'll be happy to help further.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea.", "reference": "`Anomaly` imported here, but not used. Please run the changed files through pylint with nupic pylint config and fix pylint findings related to your changes." }, { @@ -10535,35 +10535,35 @@ "reference": "line is 161 characters (from `lll`)" }, { - "prediction": "I'm not sure if this is a good place to put it, but I think we should move it to the `controllerutils` package.", + "prediction": "I don't think we need to use `logr` here, we can just use `log` instead.", "reference": "Please re-format/groupimport this line. You might need a little manual work." }, { - "prediction": "I think it's better to use `daisy_utils.UpdateAllInstanceNoExternalIP` instead of `daisy_utils.UpdateInstanceNoExternalIP` in this case.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have this in `daisy.Workflow` as well, so that we don't have to do this in `daisy.Workflow` every time we create a new `DaisyWorker` instance.", "reference": "minor, you can just use `wf` instead of `worker.wf`" }, { - "prediction": "I think this is not a good idea. We should use `String` instead of `InputStream` and `InputStreamReader` here.", + "prediction": "I think this should be a test for `getJsonBodyForSingleMapObject` instead of `getJsonBodyForSingleMapObject` and `getJsonBodyForSingleMapObject` instead of `getJsonBodyForSingleMapObject` and `getJsonBodyForSingleMapObject` instead of `getJsonBodyForSingleMapObject` and `getJsonBodyForSingleMapObject` instead of `getJsonBodyForSingleMapObject` and `getJsonBodyForSingleMapObject` instead of `getJsonBodyForSingleMapObject` and `getJsonBodyForSingleMapObject` instead of `getJsonBodyForSingleMapObject` and `getJsonBodyForSingleMapObject` instead of `getJsonBodyForSingleMapObject` and `getJsonBodyForSingleMapObject` instead of `getJsonBodyForSingleMapObject` and `getJsonBodyForSingleMapObject` instead of `getJsonBodyForSingleMapObject` and `getJsonBodyForSingleMapObject` instead of `getJsonBodyForSingleMapObject` and `getJsonBodyForSingleMapObject` instead of `getJsonBodyForSingleMapObject` and `getJsonBodyForSingleMapObject` instead of `getJsonBodyForSingle", "reference": "I would suggest putting this in the resources directory with the same package as of this test class. Then you can utilize the method azkaban.utils.TestUtils#readResource to read it as string." }, { - "prediction": "I'm not sure what you mean by this, but I think it's a good idea to remove the `github.com/openebs/maya/pkg/errors/v1alpha1` package.", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be good to have a separate file for this.", "reference": "could not import github.com/openebs/maya/pkg/upgrade/templates (invalid package name: \"\") (from `typecheck`)" }, { - "prediction": "I'm not sure what you're trying to say here, but I don't think it's a good idea to add tests at that time.", + "prediction": "I'm not sure if this is the right place to add this test, but I think it's a good idea.", "reference": "a official -> an official" }, { - "prediction": "I'm not sure if this is the right place to add this, but I think it would be good to add it to `proxy_listener.py` instead of `proxy_listener_kinesis.py` since it's not related to the `proxy_listener_kinesis` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to `kinesis.py` instead of `proxy_listener.py`.", "reference": "I only want the proxy request for this to run for kinesalite." }, { - "prediction": "I'm not sure what you mean by \"focus\" and \"onBlur\" and \"onFocus\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `focus` and `blur` event handler for the `DatePicker` component.", "reference": "White space boya?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to get the underlying struct from the AWS SDK, but I'm not sure what you're trying to do with it. I think you're trying to get the underlying struct from the AWS SDK, but I'm not sure what you're trying to do with it. I think you're trying to get the underlying struct from the AWS SDK, but I'm not sure what you're trying to do with it. I think you're trying to get the underlying struct from the AWS SDK, but I'm not sure what you're trying to do with it. I think you're trying to get the underlying struct from the AWS SDK, but I'm not sure what you're trying to do with it. I think you're trying to get the underlying struct from the AWS SDK, but I'm not sure what you're trying to do with it. I think you're trying to get the underlying struct from the AWS SDK, but I'm not sure what you're trying to do with it. I think you're trying to get the underlying struct from the AWS SDK, but I'm not sure what you're trying to do with it. I think you're trying to get the underlying struct from the", + "prediction": "I'm not sure what you're trying to achieve with this change, but it looks like you're trying to get the underlying struct from the AWS SDK. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to get the underlying struct from the AWS SDK. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to get the underlying struct from the AWS SDK. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to get the underlying struct from the AWS SDK. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to get the underlying struct from the AWS SDK. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to get the underlying struct from the AWS SDK. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to get the underlying struct from the AWS SDK. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to get the underlying struct from the AWS SDK. I'm not sure what you're trying", "reference": "Maybe ditch these since `StackSummary` is not used anymore." }, { @@ -10571,35 +10571,35 @@ "reference": "suggest to indicate the value range & meaning in docstring" }, { - "prediction": "I don't think this is a good idea. It's not clear to me what the purpose of this endpoint is. I think it's better to have a separate endpoint for metrics.", + "prediction": "I don't think this is a good idea. It's not clear to me what the purpose of this endpoint is. I think it should be something like `http://localhost:9501/v1/metrics` or `http://localhost:9501/metrics` or something like that.", "reference": "not sure if it works with prometheus by default, otherwise we will have to add this into prometheus config also" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `WorkloadDispatchChains` method.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would make sense to move this into the `WorkloadDispatchChains` method.", "reference": "The rule renderer isn't meant to be stateful so probably best to move this out of here" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `findNvidiaContainerRuntimes` here. You can just use `privRegistries.Registry()`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `setupContainerdConfig` function as well. I think it's a good idea to add this to the `setupContainerdConfig` function as well. I think it's a good idea to add this to the `setupContainerdConfig` function as well. I think it's a good idea to add this to the `setupContainerdConfig` function as well. I think it's a good idea to add this to the `setupContainerdConfig` function as well. I think it's a good idea to add this to the `setupContainerdConfig` function as well. I think it's a good idea to add this to the `setupContainerdConfig` function as well. I think it's a good idea to add this to the `setupContainerdConfig` function as well. I think it's a good idea to add this to the `setupContainerdConfig` function as well. I think it's a good idea to add this to the `setupContainerdConfig` function as well. I think it's a good idea to add this to the `setupContainerdConfig` function as well", "reference": "passing in a `nil` here just so that the tests can pass in an alternative implementation seems weird, but I don't know what the convention is for doing something like this - @briandowns?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `dotRegex` or `doTRegex` here.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `require('html-entities').AllHtmlEntities` here.", "reference": "IMO `dot` should be preferred. Remember `aXe`?" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bad idea to use `Console.ReadKey()` in this case. It's not a good idea to use `Console.ReadKey()` when you don't need to wait for the user to press a key.", + "prediction": "I don't think this is a good idea. It would be better to use `Console.ReadLine()` instead of `Console.ReadKey()`.", "reference": "Not a huge deal but this will block tests, also, don't they stay open by default now?" }, { - "prediction": "I'm not sure what you mean by `cfg.SessionGUID == \"\"`", + "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a log buffer with a depth of 2. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a log buffer with a depth of 2. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a log buffer with a depth of 2. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a log buffer with a depth of 2. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a log buffer with a depth of 2. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a log buffer with a depth of 2. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a log buffer with a depth of 2. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a log buffer with a depth of 2.", "reference": "Could you make it a local constant for now ?" }, { - "prediction": "I think we can remove the `has_invalid_value` check here.", + "prediction": "I think it's better to use `isinstance(value, int)` instead of `isinstance(value, int) and isinstance(value, int)`.", "reference": "What is this `collection_id` field here?" }, { - "prediction": "I think this should be `log_interactive` instead of `log_interactive.debug`?", + "prediction": "I think this should be `log_interactive.debug` instead of `log_interactive.debug_interactive`?", "reference": "Is there a reason why we don't use logging for this?" }, { @@ -10607,35 +10607,35 @@ "reference": "Exceptions should be placed in application layer -> infrastructure is aware of application - not the other way around" }, { - "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to test that the `message-id` field is included in the JSON output, but I don't think that's what you're trying to do here. It looks like you're trying to test that the `message` field is included in the JSON output, but I don't think that's what you're trying to do here. It looks like you're trying to test that the `message-id` field is included in the JSON output, but I don't think that's what you're trying to do here. It looks like you're trying to test that the `message` field is included in the JSON output, but I don't think that's what you're trying to do here. It looks like you're trying to test that the `message-id` field is included in the JSON output, but I don't think that's what you're trying to do here. It looks like you're trying to test that the `message` field is included in the JSON output, but I don't think that's what you're trying to do here. It looks like you're trying to test that the `message-id` field is included in the JSON output, but I don", + "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here.", "reference": "IIRC issue mentioned reporting _symbolic message_ - so in this case it would be `line-too-long`." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should go in the `spell` struct.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `spell` struct.", "reference": "Is this intended to be `spells[spell_id].reflectable` here? Edit: Should be `spells[spell_id].feedbackable`, right?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a new migration.", + "prediction": "Shouldn't this be `change_column_null` instead of `remove_column`?", "reference": "How should we set this for existing teams?" }, { - "prediction": "I'm not sure if this is the best way to test this, but I think it's a good idea to make sure that the `testClusterDeployment` and `testClusterProvisionWithInfraIDSet` tests pass before running the `testInstallManager` test.", + "prediction": "I'm not sure if this is the right place to add this check, but I think it's important to make sure that we don't accidentally create a cluster with an already set infraID. I think we should add this check in the `testClusterProvisionWithInfraIDSet` test, but I'm not sure if that's the best place to do it.", "reference": "It would be nice if we could verify that this is in fact the error we expected. But that's a latent issue, something for the backlog." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to remove the `state` middleware from the `openvpn/middlewares/state` package, as it's not needed anymore.", + "prediction": "I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place", "reference": "I hate then some internal process specific middleware leaks into connection manager :( todo later." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `nupic` package.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to move this to the `nupic` package, since it's a dependency of `nupic.bindings` and `nupic.support` and `nupic.support.__init__` are in `nupic.bindings` and `nupic.support` respectively. I'm not sure if this is the right place to do this, but I think it's a good idea to move this to the `nupic` package, since it's a dependency of `nupic.bindings` and `nupic.support` and `nupic.support.__init__` are in `nupic.bindings` and `nupic.support` respectively. I'm not sure if this is the right place to do this, but I think it's a good idea to move this to the `nupic` package, since it's a dependency of `nupic.bindings` and `nupic.support` and `nupic.support.__init__` are in `nupic.bindings` and `nupic.support` respectively. I'm not sure if this is the right place", "reference": "Reflects where these files were moved for `pkg_resources`." }, { - "prediction": "I'm not sure what you mean by `computed('i18n', () => { ... });`", + "prediction": "I don't think we need to use `computed` here. We can just use `t('admin.textReplacements.pageTitle')` directly.", "reference": "This should be computed('i18n.locale'...." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to set the RPF check to 2 in the test.", "reference": "Can you explain to me what goes wrong here? Can the test be adjusted to set up working routing instead?" }, { @@ -10643,19 +10643,19 @@ "reference": "We can get rid of this import then." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to send a metric to the morqa client, but I don't think that's what you want to do.", + "prediction": "I don't think this is a good idea. It would be better to have a `mapEventToMetric` function that returns a `metrics.Event` and a `metrics.Metric` instead of a `mapEventToMetric` function that returns a `metrics.Event` and a `metrics.Metric`.", "reference": "Not sure how useful is unlock event." }, { - "prediction": "I think we can remove the `lowercaseFields` argument. It's not used anywhere.", + "prediction": "I think it's better to use `map[string]interface{}` instead of `map[string]interface{lowercaseFields: lowercaseFields}`.", "reference": "Consider make the second argument a `encoderOptions` which includes the `lowercaseFields` just like opening a collection." }, { - "prediction": "I think we can remove the `TezUtil.enrichContextWithAttemptWrapper` call here.", + "prediction": "I think this should be `TezUtil.enrichContextWithAttemptWrapper(TaskAttemptContext)` instead of `TezUtil.enrichContextWithAttemptWrapper(TaskAttemptID)`.", "reference": "What is the value of renaming this to `ctx`? We generally prefer the longer names because they are easier to read and to type." }, { - "prediction": "I think this should be `if (lane_data.front().tag == TurnLaneType::uturn)` instead of `if (lane_data.back().tag == TurnLaneType::uturn)`.", + "prediction": "I think this should be `if (lane_data.front().tag == TurnLaneType::uturn)` instead of `if (lane_data.back().tag == TurnLaneType::uturn)`", "reference": "Hm. This could be a case of left-sided driving, having u-turn lanes on the right side. Good catch, but looks good to me." }, { @@ -10663,7 +10663,7 @@ "reference": "There was a [JsonPropertyName(\"success\")] here it did serialize fine for me, so I am not sure what was the matter? Also maybe uppercase?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.", + "prediction": "I'm not sure what you're trying to do here. You're creating a new `IAuRaValidatorProcessor` and passing it to the `CreateValidatorProcessor` method, but you're not using it.", "reference": "we can just use read env here, pretty sure" }, { @@ -10671,23 +10671,23 @@ "reference": "Could you replace local hook with global hook `afterModifyTransformStart`?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `clear` method to the `Archive` class.", + "prediction": "I think this should be `self._files.clear()` instead of `self._files.clear()`", "reference": "You seem to be basing your PRs off an commit, which keeps reintroducing these changes, which makes it harder to review your PRs." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to call `portprober.findFreePort('localhost')` here.", + "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to start a server that will listen on a specific port, and then wait for it to start.", "reference": "Maybe it would simpler to ignore opt_port if type !== 'number'?" }, { - "prediction": "I think this should be `public IEnumerable> Attributes { get; set; }` instead of `public IDictionary Attributes { get; set; }`", + "prediction": "I don't think this should be a property. It should be an attribute.", "reference": "As far as I can tell, `IDictionary` implements `IEnumerable>` so we are just making it more generic. From the issue, I understood that we want to maintain sequence/order. I believe `IEnumerable<>` won't fix the issue." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a `DockerOptions` constructor that takes a `List` as an argument. This way, you can pass in a list of `DockerSessionFactory` objects and they will be used to create the `DockerSessionFactory` instances.", "reference": "This change prevents a user understanding how their server is configured. Best to leave at `info` level." }, { - "prediction": "I think it's better to use `api.SpecPriorityAlias` instead of `ephemeralDenyList`.", + "prediction": "I don't think this is necessary. I think we can just use `api.SpecPriority` and `api.SpecPriorityAlias` instead.", "reference": "I will add the following to the list: - api.SpecScale - api.SpecSticky" }, { @@ -10695,11 +10695,11 @@ "reference": "As defaultSendPort is being removed, and I don't like TODOs on examples, please remove the whole line" }, { - "prediction": "I think we can remove the `new int[1]` from the `array` test.", + "prediction": "I think it's better to use `new int[0]` instead of `new int[1]` in this case.", "reference": "since we are now no longer expecting an input of float to return an empty string, i have removed this test case." }, { - "prediction": "I'm not sure what you mean by \"default/specific registry\"", + "prediction": "I don't think we need to do this. We can just use the default registry.", "reference": "It would be cleaner if you were to pack the name&desc in a `MetricName` and pass it to `MakeCounter`" }, { @@ -10707,15 +10707,15 @@ "reference": "Do you know why do we need this?" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's better to have a separate view controller for each platform. This way, you can have a single view controller that can be used on both iOS and Android.", + "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a separate class for the `View` and `Presenter` classes. This way, we can have a single `View` class that can be used by both the `Presenter` and the `View` classes.", "reference": "I guess this using is what causes the build to fail" }, { - "prediction": "I'm not sure what you mean by \"close(b->wakeup)\". Is this the same as `ponyint_messageq_destroy(&b->q);`?", + "prediction": "I'm not sure what you mean by \"close(b->wakeup)\". I think you meant to say `ponyint_messageq_destroy(&b->q);`", "reference": "I like the explicit unregister approach." }, { - "prediction": "I think we can remove the `0x04` from the `Point kind` field.", + "prediction": "I think we can remove the `0x80: Summary (reserved)` and `0x70: ExponentialHistogramWithMinMax (reserved)`.", "reference": "We should able to use 0x30 as summary, and make 0x80 reserved for future." }, { @@ -10723,7 +10723,7 @@ "reference": "This allows strategic exclusion of http spans." }, { - "prediction": "I'm not sure what you're trying to do here. You're setting the `appliedFilters` to an empty array, but you're not using it anywhere.", + "prediction": "I'm not sure what you mean by `appliedFilters` and `strictTextSearchFields`.", "reference": "why not just `string[]` instead of nullable" }, { @@ -10731,19 +10731,19 @@ "reference": "How does this work? Why isn't each tag after the first picked up as a new arg/flag?" }, { - "prediction": "I think this should be `AzureAppServicesResourceId` instead of `AzureAppServicesResourceID`.", + "prediction": "I think this should be `AzureAppServicesResourceId` instead of `AzureAppServicesResourceId`.", "reference": "This key is actually yet to be determined. Meeting with the backend team and Garner to discuss." }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check here to make sure that the image view is valid before trying to use it.", "reference": "Why remove the crash protection? We're just going to get a bug filed on it." }, { - "prediction": "I don't think we need to add `X-Frame-Options` and `X-XSS-Protection` to the `HEADERS` object. They are already included in the `X-Content-Type-Options` and `Content-Security-Policy` headers.", + "prediction": "I think it's better to use `X-Frame-Options` and `X-XSS-Protection` instead of `X-Frame-Options` and `X-XSS-Protection`", "reference": "Maybe be consistent and name it `FRAME_OPTIONS`." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to reattach the orphan block at the end of the newly inserted block, but I don't think that's what you want to do. I think you want to reattach the orphan block at the end of the newly inserted block, but I don't think that's what you want to do. I think you want to reattach the orphan block at the end of the newly inserted block, but I don't think that's what you want to do. I think you want to reattach the orphan block at the end of the newly inserted block, but I don't think that's what you want to do. I think you want to reattach the orphan block at the end of the newly inserted block, but I don't think that's what you want to do. I think you want to reattach the orphan block at the end of the newly inserted block, but I don't think that's what you want to do. I think you want to reattach the orphan block at the end of the newly inserted block, but I don't think that's what you want to do. I think you want to reattach the orphan block at the end of the newly inserted block,", + "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", "reference": "This check/exception is a guard for the next few lines of code. It shouldn't be necessary now. In fact, I don't think you need the if (parentConnection.type == Blockly.INPUT_VALUE) branch at all." }, { @@ -10755,19 +10755,19 @@ "reference": "Maybe 'failed' instead of 'missing'. Also do we really need to write ticket numbers here?" }, { - "prediction": "I'm not sure what you mean by \"use up to 60 words\"", + "prediction": "I don't think this is necessary. The `TransformerFactory` is already available in the `org.apache.solr.response.transform` package, so we don't need to import it here.", "reference": "Test used to use old bouncycastle dependency which isn't needed anymore from Hadoop. Switched to use builtin Java split." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `VoiceInfo` class that has a `name` and a `language` property.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `VoiceInfo` class that can be used to create a `VoiceInfo` object from a `Voice` object. This way, we don't have to create a `VoiceInfo` object every time we want to create a `VoiceInfo` object from a `Voice` object.", "reference": "nit: I think this would be more readable as \"Some language names contain Unicode characters\"." }, { - "prediction": "I think this should be `import _winreg` instead of `import _winreg`", + "prediction": "I don't think this should be here. It should be in the NVDAHelper.py file.", "reference": "Thanks for adding the header, but I don't think 2017 is a very accurate guess here. Could you do a quick search with git blame and change this accordingly?" }, { - "prediction": "I think we should use `createContext` from `@types/react` instead of `createContext` from `@types/react-dom` because `createContext` from `@types/react-dom` is deprecated and `createContext` from `@types/react` is still supported.", + "prediction": "I don't think we need to use `createContext` in this case. We can just use `createContext` directly.", "reference": "Oh interesting - does web-test-runner not resolve package.json files?" }, { @@ -10775,35 +10775,35 @@ "reference": "Is there a way to derive this value from the locale itself? I feel hardcoding the prefix in the props isn't the right approach, but I'm not sure what the locale file contains exactly." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `componentWillReceiveProps` callback.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `componentWillReceiveProps` callback.", "reference": "I'd much rather see these warnings in our devtools (`debug/index.js`). Strings contribute quite a bit to our file size and moving them there would prevent bloating core." }, { - "prediction": "I'm not sure what you're trying to do with this query, but I think it's a bad idea to use `String.format` here. It's a bad idea to use `String.format` here. It's a bad idea to use `String.format` here. It's a bad idea to use `String.format` here. It's a bad idea to use `String.format` here. It's a bad idea to use `String.format` here. It's a bad idea to use `String.format` here. It's a bad idea to use `String.format` here. It's a bad idea to use `String.format` here. It's a bad idea to use `String.format` here. It's a bad idea to use `String.format` here. It's a bad idea to use `String.format` here. It's a bad idea to use `String.format` here. It's a bad idea to use `String.format` here. It's a bad idea to use `String.format` here. It's a bad idea to use `String.format` here. It's a bad idea to use `String.format` here. It's a bad idea to use `String.format` here. It's a bad idea", + "prediction": "I don't think we need to use `String.format` here, we can just use `String.format(\"%s from %s\", SmartStore.SOUP_NAME_COL, SmartStore.SOUP_ATTRS_TABLE)`", "reference": "Use `String.format(Locale.US, ...) to avoid the `Lint` warning." }, { - "prediction": "I think we can remove the `ServiceReference` struct and just use `PodReference` instead.", + "prediction": "I think we can remove the `ServiceReference` struct and just use `PodReference.Name` and `PodReference.Namespace` instead.", "reference": "nit: ServiceReference represents a reference to a v1.Service." }, { - "prediction": "I think we can remove the `DeviceName` field, as it's not used in the spec.", + "prediction": "I don't think we need this field. It's not used anywhere in the spec.", "reference": "since it changes to the array, how about change the name to `DeviceNames`" }, { - "prediction": "I think we should remove `RuntimeTLP` from the list of top level properties.", + "prediction": "I don't think this is a good idea. It's not clear to me what the purpose of `RuntimeTLP` is. I think it's better to have a separate `RuntimeTLP` property for the runtime specific properties.", "reference": "Can we avoid this. upgrade engine code should take care of this." }, { - "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to have a default value for the `TOKEN_EXP_DEFAULT` dictionary. I think it's a good idea to have a default value for the `TOKEN_EXP_DEFAULT` dictionary. I think it's a good idea to have a default value for the `TOKEN_EXP_DEFAULT` dictionary. I think it's a good idea to have a default value for the `TOKEN_EXP_DEFAULT` dictionary. I think it's a good idea to have a default value for the `TOKEN_EXP_DEFAULT` dictionary. I think it's a good idea to have a default value for the `TOKEN_EXP_DEFAULT` dictionary. I think it's a good idea to have a default value for the `TOKEN_EXP_DEFAULT` dictionary. I think it's a good idea to have a default value for the `TOKEN_EXP_DEFAULT` dictionary. I think it's a good idea to have a default value for the `TOKEN_EXP_DEFAULT` dictionary. I think it's a good idea to have a default value for the `TOKEN_EXP_DEFAULT` dictionary. I think it's a good idea to have a default value for the `TOKEN_EXP_DEFAULT` dictionary. I think it's a good idea to have a default", + "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a good idea to have a default value for the `TOKEN_EXP_DEFAULT` key.", "reference": "should also be alphabetized or at least grouped and alphabetized within group" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason you're doing this?", + "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason you want to use `ssl` here?", "reference": "No need for this, as pylint already only turns things off for this function and it's needed for the entire function." }, { - "prediction": "I think this should be `errUnmarshalCountOpts = errors.New(\"can't unmarshal count field into task count or auto scaling config\")` instead of `errUnmarshalBuildOpts = errors.New(\"can't unmarshal build field into string or compose-style map\")`", + "prediction": "I'm not sure if this is a good place to put this, but I think we should move it to the `dockerfile` package.", "reference": "nit: can we remove \"can't\" from the error message?" }, { @@ -10811,99 +10811,99 @@ "reference": "instead of modifying 'Status' which impacts the state diagram, how about using some annotations on CVR? This can probably help for our upgrade as well. Is this possible? cc: @AmitKumarDas" }, { - "prediction": "`KubernetesGpgkey` should be `KubernetesGPGURL` and `KubernetesBaseurl` should be `KubernetesDownloadURL`", + "prediction": "`KubernetesGpgkey` should be `KubernetesGPGURL` and `KubernetesDownloadURL` should be `KubernetesDownloadURL`", "reference": "Rename this as KubernetesGPGURL - >KubernetesUbuntuGPGURL , Modify it where ever it is used." }, { - "prediction": "I'm not sure what you're trying to do with this, but it looks like you're trying to create a `TransactionIn` object from a `Buffer` object. I'm not sure what you're trying to do with this, but it looks like you're trying to create a `TransactionIn` object from a `Buffer` object. I'm not sure what you're trying to do with this, but it looks like you're trying to create a `TransactionIn` object from a `Buffer` object. I'm not sure what you're trying to do with this, but it looks like you're trying to create a `TransactionIn` object from a `Buffer` object. I'm not sure what you're trying to do with this, but it looks like you're trying to create a `TransactionIn` object from a `Buffer` object. I'm not sure what you're trying to do with this, but it looks like you're trying to create a `TransactionIn` object from a `Buffer` object. I'm not sure what you're trying to do with this, but it looks like you're trying to create a `TransactionIn` object from a `Buffer` object. I'm not sure what you're trying to do with", + "prediction": "I don't think this is needed.", "reference": "I'm not totally sure I like the idea of putting a default fee here, but I guess so long as we make sure to track the default fee of bitcoin core, we're good. We should really also take a look at the byte size of the transaction, and use that to determine what the fee should be. But that could also be a different PR." }, { - "prediction": "small>linearconstlinearlinearlinear\n * {@linkplain javaslang.collection.Iterator}constconst————\n * {@linkplain javaslang.collection.Map}constlinearconstlinearlinearlinear\n```\nReview comment?", + "prediction": "small>linearconstlinearlinearlinear\n * {@linkplain javaslang.collection.Map}constlinearconstlinearlinearlinear\n * {@linkplain javaslang.collection.Set}constlinearconstlinearlinearlinear\n```\nReview comment?", "reference": "oh yeah, `tail`, `update`, `prepend`, `append`, `subSequence`, `trim` just became effectively constant (without memory leak) :)" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to remove all the links from the resource. I think you should be able to do this by using the `where` method with an array of resource IDs.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.", "reference": "Can you add back a deprecated `destroyLinks` method for backward compatibility? It can simply proxy `destroyResourceLinks`, and we can remove it in the next major release." }, { - "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to make this a global option, so that it can be used in other places as well. This way, we don't have to add this option every time we create a new caddyfile.", + "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to make this a global option, so that it can be used in other places as well.", "reference": "A reminder that we should discuss whether to rename this to \"sockets\" or \"listeners\"." }, { - "prediction": "I'm not sure what you mean by \"RTPSParticipantAttributes\". Is it something like `RTPSParticipantAttributes`? If so, I think we should rename it to `RTPSParticipantAttributes` as well.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `rtps` namespace, since it's a part of the `RTPSParticipant` class.", "reference": "Why do you need to include this using declaration?" }, { - "prediction": "I think this should be `for (var scan = 0; scan < count; ++scan)` instead of `for (var scan = 0; scan != count; ++scan)`", + "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", "reference": "@halter73 where is this file generated from?" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's better to have a separate file for the `MongoDB` class.", + "prediction": "I don't think this is a good idea. It would be better to have a separate class for this.", "reference": "What do these `#if TRUE` accomplish?" }, { - "prediction": "I think this should be `if (!this.handler.SupportsNullActivity && Activity.Current == null)` instead of `if (!this.handler.SupportsNullActivity && Activity.Current == null)`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the `InstrumentationEventSource` class.", "reference": "Probably a good optimization to have this, but I don't think it's strictly required. For \"legacy\" Activity flows we pass them through an ActivitySource for sampling. So the logic below should also catch these?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to use the `proposal_url` helper to get the URL for the proposal, but then you're trying to use the `feedback_url` helper to get the URL for the feedback form. I think you want to use the `proposal_url` helper to get the URL for the proposal, but then you want to use the `feedback_url` helper to get the URL for the feedback form.", + "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `proposal_url` instead of `proposal_url(@proposal)`.", "reference": "@jessieay Intentionally moving away from passing a param?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `array_pop()` here.", "reference": "I think you could condense this code considerably by getting rid of the initialization and foreach loop and simply saying: `$firstname = trim(implode(' ', $nameArr));` What do you think?" }, { - "prediction": "I don't think this is necessary. `process.env.npm_config_user_agent` is already defined in the global scope.", + "prediction": "`process.env.npm_config_user_agent` should be `process.env.npm_config_user_agent || ''`", "reference": "hmm, we actually should _add_ `'use strict'` everywhere" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check to see if the property is null before trying to parse it.", + "prediction": "I think this should be `if (properties == null || properties.isEmpty())`", "reference": "it's not just fetching override properties here, right?" }, { - "prediction": "Shouldn't this be `shouldReconnectWithoutBackoff` instead of `shouldReconnectWithoutBackoff(acsError)`?", + "prediction": "Shouldn't this be `if shouldReconnectWithoutBackoff(acsError) {` instead of `if shouldReconnectWithoutBackoff(acsError) { seelog.Info(\"ACS Websocket connection closed for a valid reason\") seelog.Info(\"ACS Websocket connection closed for a valid reason\") seelog.Info(\"ACS Websocket connection closed for a valid reason\") seelog.Info(\"ACS Websocket connection closed for a valid reason\") seelog.Info(\"ACS Websocket connection closed for a valid reason\") seelog.Info(\"ACS Websocket connection closed for a valid reason\") seelog.Info(\"ACS Websocket connection closed for a valid reason\") seelog.Info(\"ACS Websocket connection closed for a valid reason\") seelog.Info(\"ACS Websocket connection closed for a valid reason\") seelog.Info(\"ACS Websocket connection closed for a valid reason\") seelog.Info(\"ACS Websocket connection closed for a valid reason\") seelog.Info(\"ACS Websocket connection closed for a valid reason\") seelog.Info(\"ACS Websocket connection closed for a valid reason\") seelog.Info(\"ACS Websocket connection closed for a valid reason\") seelog.Info(\"ACS Websocket connection closed for a valid reason\") seelog.Info(\"ACS Websocket connection closed for a valid", "reference": "Is it worth logging the error?" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a class that inherits from `watchdog.observers.polling.PollingObserver` and `watchdog.events.WatchEvent`. I'm not sure what you're trying to do here, but it looks like you're trying to create a class that inherits from `watchdog.observers.polling.PollingObserver` and `watchdog.events.WatchEvent`. I'm not sure what you're trying to do here, but it looks like you're trying to create a class that inherits from `watchdog.observers.polling.PollingObserver` and `watchdog.events.WatchEvent`. I'm not sure what you're trying to do here, but it looks like you're trying to create a class that inherits from `watchdog.observers.polling.PollingObserver` and `watchdog.events.WatchEvent`. I'm not sure what you're trying to do here, but it looks like you're trying to create a class that inherits from `watchdog.observers.polling.PollingObserver` and `watchdog.events.WatchEvent`. I'm not sure what you're trying to do here, but it looks like you're trying to create", + "prediction": "I don't think this is needed.", "reference": "What's the point of this class?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add the `hide` class to the `chkAutomaticallyAddToCollectionContainer` and `chkAutomaticallyAddToCollectionContainer` to the `chkEnableEmbeddedEpisodeInfosContainer` as well. This way, if the user clicks on the `chkAutomaticallyAddToCollectionContainer`, the `chkAutomaticallyAddToCollectionContainer` will be hidden and the `chkEnableEmbeddedEpisodeInfosContainer` will be shown.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add the `hide` class to the `chkAutomaticallyAddToCollectionContainer` when the `contentType` is `movies` or `mixed` and remove it when the `contentType` is `movies` or `mixed` and `contentType` is not `movies` or `mixed`.", "reference": "I'm being picky here, but I think I would prefer `toggle` to be kept here and just change the condition to `contentType !== 'movies' && contentType !== 'mixed'` or `!['movies', 'mixed'].includes(contentType)`." }, { - "prediction": "I don't think we need to use `sysPath` here. We can use `os.Path` instead.", + "prediction": "I don't think we need to use `sysPath` here. We can just use `os.Path` instead.", "reference": "Please put this down with the other \"github.com\" imports." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `push_front_preference` in `nano::block_processor::add`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a `push_front_preference` parameter to `add` as well.", "reference": "Minor but probably want `push_front_preference` to have a trailing `_a` to be consistent with the other parameter" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason why you want to use `Projections.inclusive` instead of `Projections.inclusive(spec).project(rowFilter)`?", + "prediction": "I think we should be able to do this in a single expression, but I'm not sure how to do it.", "reference": "Nit: the formatting is a bit off. I would expect this to be 2 indentations from `this.expr = ...` but this is 8 spaces, not 4. Also, most places leave the `);` on the last line of the method arguments." }, { - "prediction": "I don't think we need to add `@Override` to the `StaticLangApiMethodTransformer` class. It's already overridden in `ApiMethodTransformer` class.", + "prediction": "I don't think we need to add `@ApiMethodTransformer` to `StaticLangApiMethodTransformer` because it's already defined in `com.google.api.codegen.transformer.StaticLangApiMethodTransformer`", "reference": "Ack, @chrisdunelm snuck this class extension past me. This is not a pattern I want to have used..." }, { - "prediction": "I think this should be `config.scan(\"kinto.views\", **kwargs)` instead of `config.scan(\"kinto.views\", **kwargs, ignore='kinto.views.flush')`", + "prediction": "I think this should be `config.add_api_capability` instead of `config.add_api_capability(url=\"http://kinto.readthedocs.org/en/latest/configuration/settings.html#activating-the-flush-endpoint\")`", "reference": "nitpick: I wonder if we should name it `flush` only (?)" }, { - "prediction": "I think we can remove the `tasksGauge` and `dealsGauge` from the `init` function.", + "prediction": "I think it's better to use `prometheus.NewCounter` instead of `prometheus.NewGauge`.", "reference": "Why gauges, not counters?" }, { - "prediction": "`gwHashLen` should be `gwHashLen + 1` instead of `gwHashLen + 2`", + "prediction": "I think it's better to use `sysHashLen` instead of `gwHashLen`.", "reference": "Just making a note here that this may break pre GWs between pre 2.2.0 and 2.2.0 servers. Not sure, will have to experiment/dig a bit more." }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.", + "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here.", "reference": "Shall we rename this status to CONTAINER_FAILED? ^^ cc: @sshardool" }, { @@ -10911,67 +10911,67 @@ "reference": "Thinking out loud here: I believe the only reason we need `peer.ID` as a parameter to this method is because we are not persisting blocks from pubsub (instead we are refetching them). If nodes persist the blocks they received over pubsub then I think we can guarantee peers we share a connection with (i.e. that are in the peer tracker) will always have the blocks we are fetching (else how would have we gotten the pubsub message). I imagine the concept of an `initialPeer` can go away once #2962 lands since the peers in the tracker will have the block. Although I don't think that covers the case of fetching blocks our peers have deemed semantically invalid and thus not stored..." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I don't think it's a good idea.", + "prediction": "I'm not sure what you're trying to achieve with this, but it's not clear to me that this is the right way to do it. It's not clear to me that this is the right way to do it. It's not clear to me that this is the right way to do it. It's not clear to me that this is the right way to do it. It's not clear to me that this is the right way to do it. It's not clear to me that this is the right way to do it. It's not clear to me that this is the right way to do it. It's not clear to me that this is the right way to do it. It's not clear to me that this is the right way to do it. It's not clear to me that this is the right way to do it. It's not clear to me that this is the right way to do it. It's not clear to me that this is the right way to do it. It's not clear to me that this is the right way to do it. It's not clear to me that this is the right way to do it. It's not clear to me that this is the right way to do it. It's", "reference": "I know it has no effect but my eyes can't help. Is that line not too long?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate rule for this. It's not clear to me why we'd want to jump to a chain for a blocking service CIDR loop, but I think it's a good idea to have a separate rule for this.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a separate rule for this. It's not clear to me why we'd want to jump to a chain for a blocking service CIDR loop.", "reference": "Does that mean we disable service loop prevention for packet generated by local host?" }, { - "prediction": "I think this should be `if host['platform'] =~ /windows/` instead of `if host['platform'] =~ /windows/ and not host.is_cygwin?`", + "prediction": "I think this should be `raise RuntimeError, \"cygwin is not installed on #{host}\" if host.cygwin_installed?`", "reference": "It seems a little odd to have both `host.is_cygwin?` *and* `host.cygwin_installed?` defined (with a possibility of having `is_cygwin?` be `true`, but `cygwin_installed?` returning `false`). Do the docs clearly explain the difference?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason you want to use a v2 writer?", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to write a manifest file with a sequence number that is inherited from the parent manifest, but you're also trying to write a manifest file with a sequence number that is not inherited from the parent manifest. Is that what you're trying to do?", "reference": "Does this mean manifests will be written with the v2 schema (i.e. with sequence numbers) even though `TableMetadata` is v1 and the manifest list is written with v1? And this should work because we do a projection on read and sequence number is optional?" }, { - "prediction": "I think this should be `REWRITTEN_FILE_SCAN_TASK_ID` instead of `REWRITTEN_FILE_SCAN_TASK_SET_ID`", + "prediction": "I think this should be `REWRITTEN_FILE_SCAN_TASK_ID` instead of `REWRITTEN_FILE_SCAN_TASK_SET_ID`.", "reference": "Should we be sharing this property key with the read? Maybe it should be belong to the file-scan-task object itself?" }, { - "prediction": "I'm not sure what you mean by \"named debug tools\" in this context. Could you please clarify?", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to have a `DebugFields` struct in the `BuildTarget` struct. The `DebugFields` struct should be a separate struct, and the `BuildTarget` struct should have a `DebugFields` field that is a pointer to the `DebugFields` struct. This way, you can have a `DebugFields` field in the `BuildTarget` struct, and the `DebugFields` field in the `BuildTarget` struct will be a pointer to the `DebugFields` field in the `BuildTarget` struct.", "reference": "Nice! Good idea to move these out of the main struct." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check here to make sure the file exists before trying to read it.", + "prediction": "I think this should be `if err != nil { return err; }` instead of `if err != nil { return err; }`", "reference": "Thanks for paying attention to other places this might happen. This one is particularly important; I probably never should have gotten in the habit of CheckErr(), since it does a log.Panic() explicitly, which looks like something else until you look closely. It's supposed to be used places where \"can't happen\" but Things Can Happen." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get the name of the store or transport type (e.g. \"IMAP\") from the `ServerSettings` object. Is this what you're trying to do? If so, what is the purpose of the `Type` enum?", + "prediction": "I don't think this is a good name for this field. It's not clear what it's used for, and it's not clear what it should be used for. I would suggest renaming it to something like \"storeType\" or \"transportType\".", "reference": "Converting this to an enum makes it obvious that I combined things that don't really belong together. It would probably be better to create two enums `StoreType` and `TransportType` (in more appropriate locations). That also makes it necessary to have (at least) two `ServerSettings` classes. `IncomingServerSettings` and `OutgoingServerSettings`. Also, the naming is inconsistent. Maybe it would be better to make the string that is used for import/export explicit, e.g. WEBDAV(\"WebDAV\")." }, { - "prediction": "I think this should be `trim()` instead of `trim().replace()`.", + "prediction": "I think this should be `trim()` instead of `trim().replace()`", "reference": "It's out of scope for this PR, but I don't find this utility's name to be particularly intuitive. It speaks to nothing of what it does. Does it create a token list? Process one? Get one? `tokenListToArray` would be nice." }, { - "prediction": "I think this should be `if (nodeName === 'INPUT' && type === 'submit' || type === 'reset')`", + "prediction": "I think this should be `if (nodeName === 'INPUT' && type === 'submit' || type === 'reset' && label !== null)`", "reference": "The message for this check used the existence of a label to determine the output, which doesn't work with the current schema. So I updated it since the data only needed to know a label was present and not what it was." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to do this in a single request.", + "prediction": "I think this should be `if app.ProjectId != claims.Role.ProjectId {` instead of `if app.ProjectId != claims.Role.ProjectId {`", "reference": "nit: \"The current project does not have requested application\"" }, { - "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here.", + "prediction": "I don't think we need to change the pattern here.", "reference": "Extend Unit test for this class" }, { - "prediction": "I think this should be `AppSecExtraHeaders` instead of `AppSecCustomIpHeader`.", + "prediction": "I think this should be `AppSecCustomIpHeader` and `AppSecExtraHeaders` instead of `AppSecRules` and `AppSecCustomIpHeader` and `AppSecExtraHeaders`.", "reference": "This is this a copy / paste error from above." }, { - "prediction": "I'm not sure what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me", + "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.", "reference": "this package has to be renamed to `typeinference`" }, { - "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `TestCase.assertNotNull` here. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `TestCase.assertNotNull` here. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `TestCase.assertNotNull` here. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `TestCase.assertNotNull` here. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `TestCase.assertNotNull` here. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `TestCase.assertNotNull` here. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `TestCase.assertNotNull` here. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea", + "prediction": "I think it's better to use `await app.logIn(credentials);` instead of `app.logIn(credentials);`", "reference": "This cancels the above null-check I guess." }, { - "prediction": "I think this should be `RPOP_SERVER_EXPIRED_IN_SECONDS` instead of `RPOP_SERVER_EXPIRED_IN_SECONDS`", + "prediction": "I think this should be `RPOP_TIMER_INTERVAL_IN_MILLIS` instead of `RPOP_SERVER_EXPIRED_IN_SECONDS`.", "reference": "change to timerIntervalInMillis" }, { @@ -10979,27 +10979,27 @@ "reference": "`any rules` should be `any roles`" }, { - "prediction": "I think this should be `feedItemFilter.filter(DBReader.getRecentlyPublishedEpisodes((page - 1) * EPISODES_PER_PAGE, EPISODES_PER_PAGE));`", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `filter` instead of `filtering` in the `loadMoreData` method.", "reference": "Why does the method need to be renamed? I would just keep the old name and update the other uses (which are only tests). That way, we can reduce code duplication." }, { - "prediction": "I think this should be `STARTCHARS = conf.get_bindings_for('normal').keys()` instead of `STARTCHARS = conf.get_bindings_for('normal').keys()`", + "prediction": "I think we can remove the `STARTCHARS` variable and just use `STARTCHARS` directly in the `keyconf` parser.", "reference": "I'm not sure if this is going to work - I think it's fine to keep them hardcoded here, as the statusbar can still show `:`, `/` and `?` even if the key is rebound." }, { - "prediction": "I'm not sure what you mean by \"addAsLibraries(resolver.resolve(\"org.codehaus.jackson:jackson-jaxrs:1.6.5\").withTransitivity().asFile()).addAsLibraries(resolver.addDependencies(...))\".", + "prediction": "I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if this is the best way to do this, but it", "reference": "@tmetzke shouldn't we replace this library with the `2.12.1` instead of removing it?" }, { - "prediction": "I'm not sure what you mean by \"this struct needs a field which represents the size of sectors that this miner has committed\"", + "prediction": "I'm not sure what you mean by \"this struct needs a field which represents the size of sectors that this miner has committed.\"", "reference": "uint64 seems excessive here. Should we reduce to a uint32 @whyrusleeping ?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. It's not clear to me what `wsSelector` is supposed to do, and it's not clear to me what `app` is supposed to do. It's not clear to me what `sel` is supposed to do, and it's not clear to me what `store` is supposed to do, and it's not clear to me what `ws` is supposed to do, and it's not clear to me what `store` is supposed to do, and it's not clear to me what `ws` is supposed to do, and it's not clear to me what `ws` is supposed to do, and it's not clear to me what `ws` is supposed to do, and it's not clear to me what `ws` is supposed to do, and it's not clear to me what `ws` is supposed to do, and it's not clear to me what `ws` is supposed to do, and it's not clear to me what `ws` is supposed to do, and it's not clear to me what `ws` is supposed to do, and it's not clear to me what `ws", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to make this a `*config.Application` instead of a `*config.Application` and a `*config.Application` instead of a `*config.Application` and a `*config.Application` instead of a `*config.Application` and a `*config.Application` instead of a `*config.Application` and a `*config.Application` instead of a `*config.Application` and a `*config.Application` instead of a `*config.Application` and a `*config.Application` instead of a `*config.Application` and a `*config.Application` instead of a `*config.Application` and a `*config.Application` instead of a `*config.Application` and a `*config.Application` instead of a `*config.Application` and a `*config.Application` instead of a `*config.Application` and a `*config.Application` instead of a `*config.Application` and a `*config.Application` instead of a `*config.Application` and a `*config.Application` instead of a `*config.Application` and a `*config.Application` instead of a `*config.Application` and a `*config.Application` instead of a", "reference": "Hmm, I thought this was getting used. These are used elsewhere as a cached value (in `svc deploy` it's `o.targetApp`) but I guess since storage doesn't actually need to validate that the app exists, just that there are local services, we never used it." }, { - "prediction": "I think we can remove the `net.SplitHostPort` call here.", + "prediction": "I think we can remove the `remoteHost` variable and just use `r.RemoteAddr` in the `ServeHTTP` function.", "reference": "To keep it simple, how would you feel about just using r.RemoteAddr? Since every request comes through here I want it to be as lean as possible. Frankly I'm OK with the port showing up in the log; maybe it'd even be useful to someone." }, { @@ -11007,19 +11007,19 @@ "reference": "grant bonus depends on both `admin{}` stored in statedb, and `P2Start/End` in local struct, which is kind of weird at Kamchatka height, we add the bonus Start/End epoch into `admin{}`, so it solely depends on `admin{}` stored in statedb" }, { - "prediction": "I think this should be `raise ValueError('Invalid flipping direction \"{}\"'.format(direction))` instead of `raise ValueError(f'Invalid flipping direction \"{direction}\"')`", + "prediction": "I'm not sure what you mean by \"Invalid flipping direction\"", "reference": "Use single quote to wrap the str." }, { - "prediction": "I think this should be `PERMISSIONING_NOT_ENABLED(-32000, \"Node/Account whitelisting has not been enabled\")` instead of `PERMISSIONING_NOT_ENABLED(-32000, \"The permissioning whitelist configuration file is out of sync. The changes have been applied, but not persisted to disk\")`", + "prediction": "I think this should be `PERMISSIONING_NOT_ENABLED(-32000, \"Node/Account whitelisting has not been enabled\")`", "reference": "Is the plan to rename this later?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check here to make sure that the strategy is valid before using it.", + "prediction": "Shouldn't this be `in_array($this->strategy, $this->strategies)`?", "reference": "Is there a reason why we need a special case for Email at this point? Is the idea that other methods can turn into Email even if it's not configured as a top-level option?" }, { - "prediction": "I'm not sure what you mean by \"unexpectedly empty\" here. Is it possible that `dir` is an empty slice?", + "prediction": "I'm not sure what you mean by \"unexpectedly empty\" here. Is it possible that `dir` is an empty slice? If that's the case, I think we should just return an error here.", "reference": "This wording is a bit ambiguos, I first thought it meant the directory has no entries in it. maybe \"dir\" -> \"dir string\"?" }, { @@ -11027,7 +11027,7 @@ "reference": "Why do we need both `HPX::m_hpx_initialized` and `HPX:: m_was_initialized`?" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I think we can remove the `if info.RPCAddress == \"\"` check.", "reference": "also check RPCName?" }, { @@ -11035,27 +11035,27 @@ "reference": "Remove unused import" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `restartFds` field in the `Instance` struct, so that we don't have to do this every time we start a new instance.", + "prediction": "I'm not sure I understand what you're trying to do here. You're starting a new instance, but then you're trying to restart it with a new caddyfile. Is this what you're trying to do? If so, why are you using `restartFds` here?", "reference": "I assume there will never be a scenario where justValidate is expected to be true on a restart" }, { - "prediction": "I'm not sure what you mean by \"multithreaded support is available\". Could you please clarify?", + "prediction": "I'm not sure what you mean by \"multithreaded support is available\". I think it's just that the analysis cache is listening for analysis results, so we don't need to worry about multithreaded support.", "reference": "Report listeners are synchronized, even 'though the cache is thread-safe... I've not profiled it, but it may be a cause of contingency. Any better way around this? Also, do listeners **really** need to be synchronized? Can't we just make them thread-safe?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I think this should be `compiler: 'gcc'` instead of `compiler: ''`.", "reference": "I don't think this is correct. When `compiler` is not given in `.travis.yml`, the announcement will be `--version`, which results in \"`command not found`\" (though not critical), and the cache slug will lack this information (also not critical)." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `EJSON.stringify` instead of `JSON.stringify` here. `EJSON.stringify` is more robust and doesn't have the same performance issues as `JSON.stringify`.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `EJSON.stringify` instead of `JSON.stringify` here. `EJSON.stringify` is a little more efficient than `JSON.stringify`.", "reference": "Why do this rather than `args = []` in the function signature?" }, { - "prediction": "I'm not sure what you mean by \"provided features\" in this context. What do you mean by \"puppet-agent\"?", + "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you", "reference": "I think we probably *should* do validation of whether there is a suitable implementation if local-validation is true. I'm not sure how useful that actually is though" }, { - "prediction": "I'm not sure what you mean by \"concat two dataset\"", + "prediction": "I don't think we need to do anything here.", "reference": "@StrikerRUS here may need to concat two data by col." }, { @@ -11063,15 +11063,15 @@ "reference": "Why the space?" }, { - "prediction": "I don't think this is needed. The `@ConfigTitleSection` annotation is only used to specify the title of a section in the config file. It doesn't affect the actual content of the section. If you want to add a title to a section, you can use the `@ConfigTitle` annotation instead.", + "prediction": "I don't think this is needed.", "reference": "please resolve the extra indentation" }, { - "prediction": "I'm not sure what you're trying to do here. Is it possible that you're trying to do something like this: `document.Settings.PeptideSettings.Libraries = previous.Settings.PeptideSettings.Libraries; document.Settings.MeasuredResults = previous.Settings.MeasuredResults; document.Id = previous.Id;`?", + "prediction": "I think this should be `!ReferenceEquals(document.Settings.PeptideSettings.Libraries, previous.Settings.PeptideSettings.Libraries)` instead of `!ReferenceEquals(document.Settings.PeptideSettings.Libraries, previous.Settings.PeptideSettings.Libraries)`", "reference": "More proof that this check is needed always." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to clean up the `al_comms` map. I'm not sure what you're trying to do here, but it looks like you're trying to clean up the `al_comms` map. I'm not sure what you're trying to do here, but it looks like you're trying to clean up the `al_comms` map. I'm not sure what you're trying to do here, but it looks like you're trying to clean up the `al_comms` map. I'm not sure what you're trying to do here, but it looks like you're trying to clean up the `al_comms` map. I'm not sure what you're trying to do here, but it looks like you're trying to clean up the `al_comms` map. I'm not sure what you're trying to do here, but it looks like you're trying to clean up the `al_comms` map. I'm not sure what you're trying to do here, but it looks like you're trying to clean up the `al_comms` map. I'm not sure what you're trying to do here, but it looks like", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to call `delete` on the `al_comms` map here as well.", "reference": "`m_al_comms` now contains smart pointers." }, { @@ -11079,19 +11079,19 @@ "reference": "Did you do a test run with the compare script? I'm nervous about what happens on all the generators..." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the `client.go` file as well.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `client.go` file.", "reference": "For a client, we store host, as string c.host. That is what we use for monitoring and statsz. Not sure if its useful here or not. Looks like probably not." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to change the number of partitions in the `load` method. The number of partitions in the `load` method should be the same as the number of partitions in the `createTable` method. If the number of partitions in the `load` method is different from the number of partitions in the `createTable` method, then the number of partitions in the `load` method will not match the number of partitions in the `createTable` method.", + "prediction": "I'm not sure what you're trying to do here. I don't think we need to change the number of partitions here.", "reference": "This change is suspicious. Why did the number of partitions increase?" }, { - "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea.", + "prediction": "I'm not sure what you're trying to achieve with this, but I'm not sure if this is the right place to do it.", "reference": "I'm still new to this area, so please forgive what may be a stupid question: When would this be false? And do we have a test for that situation?" }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it's a good idea to have this in a separate file.", + "prediction": "I'm not sure if this is the best place to put this, but I think it's a good idea to move it to the `UpdateMoleculeType` method.", "reference": "Should there be any changes to this file at all?" }, { @@ -11099,7 +11099,7 @@ "reference": "The only field being used is the KeyType; Instead, we can probably just make a `keyType` variable here." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to pass in a `credentials` object to the `super_` method, but you're not actually passing in a `credentials` object to the `super_` method. You should be passing in a `credentials` object to the `super_` method, but you're not actually passing in a `credentials` object to the `super_` method. You should be passing in a `credentials` object to the `super_` method, but you're not actually passing in a `credentials` object to the `super_` method. You should be passing in a `credentials` object to the `super_` method, but you're not actually passing in a `credentials` object to the `super_` method. You should be passing in a `credentials` object to the `super_` method, but you're not actually passing in a `credentials` object to the `super_` method. You should be passing in a `credentials` object to the `super_` method, but you're not actually passing in a `credentials` object to the `super_` method. You should be passing in a `credentials` object to", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `super_` method to `SwaggerPetstore` so that it can be used in the `super_` method of `SwaggerPetstoreOptions` and `SwaggerPetstoreRequestOptions` as well.", "reference": "This should be done by code-gen change happening in the hydra repo. I am tweaking it just to get CI into a 'passing' state" }, { @@ -11111,7 +11111,7 @@ "reference": "This looks like a bunch of whitespace fixing that's unrelated. Can you revert?" }, { - "prediction": "I don't think you need to add `new Doctrine\\Bundle\\FixturesBundle\\DoctrineFixturesBundle()` here.", + "prediction": "I don't think we need to add `Doctrine\\Bundle\\FixturesBundle` here. It's already included in `Doctrine\\Bundle\\DoctrineBundle`.", "reference": "should be removed instead" }, { @@ -11119,27 +11119,27 @@ "reference": "should use randomization ?" }, { - "prediction": "I don't think we need to use `mapiserver.GetURL()+VolumeAPIPath+c.volName` here. We can just use `VolumeAPIPath+c.volName` directly.", + "prediction": "I don't think we need to use `mapiserver.GetURL()+VolumeAPIPath+c.volName` here. We can just use `VolumeAPIPath+c.volName`.", "reference": "returning nil because we want to mayactl to exit with 0 status code." }, { - "prediction": "I'm not sure what you mean by \"no-cache, no-store\" in this context. I think you meant to say \"no-cache\" or \"no-store\".", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `send_response` function as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `send_response` function as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `send_response` function as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `send_response` function as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `send_response` function as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `send_response` function as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `send_response` function as well. I'm not sure if this is the right place to", "reference": "Is this change relevant to the PR? (and I believe we should use `text/plain` considering the fact that it can be displayed using web browsers...)" }, { - "prediction": "I think this should be `SuppressedInBaseline` instead of `SuppressedInSource`?", + "prediction": "I think this should be `SuppressedInBaseline` instead of `SuppressedInSource`.", "reference": "`[Flags]` is now auto-generated by an argument to the `EnumHint`. (The attributes happen to come out in this order. I don't think it's worth controlling the order.) #Resolved" }, { - "prediction": "I think we can remove the `log.WithField(\"syncer\", syncer).Info(\"Created Syncer\")` line.", + "prediction": "I think this should be `syncer` instead of `syncerToValidator`.", "reference": "I think same here - in general we don't need to use Setters / Getters since configParams isn't a public API." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to use the `AssembleString` function to assemble a string from a program hash and data. I'm not sure what you're trying to do here, but it looks like you're trying to use the `AssembleString` function to assemble a string from a program hash and data. I'm not sure what you're trying to do here, but it looks like you're trying to use the `AssembleString` function to assemble a string from a program hash and data. I'm not sure what you're trying to do here, but it looks like you're trying to use the `AssembleString` function to assemble a string from a program hash and data. I'm not sure what you're trying to do here, but it looks like you're trying to use the `AssembleString` function to assemble a string from a program hash and data. I'm not sure what you're trying to do here, but it looks like you're trying to use the `AssembleString` function to assemble a string from a program hash and data. I'm not sure what you're trying to do here, but it looks like you're trying to use the", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way", "reference": "Why using `fmt.Sprintf` where `fmt.Sprint` would do the work (notice no `f` in function name)?" }, { - "prediction": "I don't think this should be in the `textInfos.offs` field. It should be in the `textInfos` field.", + "prediction": "I don't think this is necessary. The `ariaCurrent` attribute is already set to the value of the `IAccessible2::attribute_current` attribute, so we don't need to set it again.", "reference": "Extraneous blank line." }, { @@ -11151,19 +11151,19 @@ "reference": "Is it safe to assume that these two keys are always present? `this[string]` will throw a `KeyNotFoundException` if they are not." }, { - "prediction": "I think this should be `maxConcurrentRuns` instead of `maxConcurrentRunsPerFlowMap`.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `ExecutorManager` class, since it's not part of the `ExecutionController` class.", "reference": "Is the `flowDefinitionId` sufficient to uniquely identify the flow or does it need to be the tuple `` ?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have `DateTime::createFromInterface` return a `DateTimeInterface` instead of a `DateTimeImmutable`. This way, you can use `DateTime::fromInterface` to create a `DateTimeImmutable` from a `DateTimeInterface` and vice versa.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to make `DateTime::createFromInterface` return a `DateTimeInterface` instead of a `DateTime` object. That way, you can use `DateTime::fromInterface` to create a `DateTimeInterface` from a `DateTime` object, and you can use `DateTime::fromInterface` to create a `DateTime` object from a `DateTimeInterface` object.", "reference": "Shouldn't it be in the reverse order? `DateTime::createFromInterface()` returns `self` and accepts `DateTimeInterface`." }, { - "prediction": "I don't think we need to check if the file type is set in the file object.", + "prediction": "I don't think this is necessary. We can just use `getFileNameAndExtension(file.name).extension` instead.", "reference": "this check is now redundant. The rest of the function downwards basically does the same thing but with safer checks." }, { - "prediction": "`alpha` and `alpha-reverse` should be the same, but `alpha_reverse` should be the same as `alpha-reverse`", + "prediction": "`alpha_reverse` and `alpha_reverse` are the same, so we can just use `alpha_reverse` instead of `alpha_reverse`", "reference": "Please could you remove the useless space." }, { @@ -11171,7 +11171,7 @@ "reference": "What's the point of this block (and isn't it effectively dead code)?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the `discourse/sso` gem.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the `discourse/sessions_controller.rb` as well.", "reference": "Put a comma after the last parameter of a multiline method call." }, { @@ -11179,19 +11179,19 @@ "reference": "Newline at end of file plz" }, { - "prediction": "I don't think we need to change this. It's just a typo.", + "prediction": "I don't think we need to use `reflect` here. We can just use `map[string]string` here.", "reference": "Can this be refactored to avoid including the aws sdk in the types that we expose? I know it's not being exposed directly through the types we expose, but I do worry that it might make it easier to accidentally do that in the future and not realize it as easily." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `tx_solr_indexqueue` table.", + "prediction": "I'm not sure if this is the best place to do this, but I think it's a good idea to have this in the `updateIndexQueueByItem` method, since it will be called by the `updateIndexQueue` method.", "reference": "Hi thomas, i would propose to indicate in the name, that only the indextime is updated, otherwise somebody might think the whole items is getting updated. I would propose something like \"updateIndexTimeByItem(Item $item)\"" }, { - "prediction": "I think this should be `is_displayed()` instead of `is_visible()`.", + "prediction": "I'm not sure what you mean by \"Invalid locator\". Is it because the element is not visible?", "reference": "This is not the right exception class. There is an InvalidSelectorException class that covers bad locators." }, { - "prediction": "I'm not sure why we need to include `Kokkos_CudaSpace` here. It's not used anywhere in this file.", + "prediction": "I think this should be `#include ` instead of `#include `.", "reference": "I assume this came from format?" }, { @@ -11199,11 +11199,11 @@ "reference": "I'd suggest a default value of `false` just to make sure existing tasks are ok when they get deserialized after an update to a version containing this code." }, { - "prediction": "I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place", + "prediction": "I think we can remove the `dumpConfig().Sdump(keys)` call here.", "reference": "Do we really need this? Seems like it would pollute the logs pretty badly." }, { - "prediction": "I don't think we need to use `Vector.Count` here. We can just use `Vector.Length` instead.", + "prediction": "I don't think this is needed anymore.", "reference": "`Vector.Count` should Jit to const when intrinsic; not sure when `Vector.IsHardwareAccelerated == false` ; however we know `readonly static int` does Jit to const." }, { @@ -11211,11 +11211,11 @@ "reference": "Can we use a skipIf decorator instead?" }, { - "prediction": "I'm not sure what you mean by \"warn_for_deprecated_arguments\"", + "prediction": "I'm not sure what you mean by `NOT_GIVEN` here. I think you meant to say `digits: 10`", "reference": "Missing version tags" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to do anything like this. The `print_plugin_list` method is used to print out a list of plugins, and the `print_plan_info` method is used to print out the plan info. I don't think you need to do anything like this. The `print_plugin_list` method is used to print out a list of plugins, and the `print_plan_info` method is used to print out the plan info. I don't think you need to do anything like this. The `print_plugin_list` method is used to print out a list of plugins, and the `print_plan_info` method is used to print out the plan info. I don't think you need to do anything like this. The `print_plugin_list` method is used to print out a list of plugins, and the `print_plan_info` method is used to print out the plan info. I don't think you need to do anything like this. The `print_plugin_list` method is used to print out a list of plugins, and the `print_plan_info` method is used to print out the plan info. I don't think you need to do anything like this. The `", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate method for this.", "reference": "I think this should also filter out `validate_resolve_reference` hooks." }, { @@ -11227,19 +11227,19 @@ "reference": "Feel free to remove this line" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to click on the \"Upcase Membership\" call to action in the header, but I don't think that's what you want to do. I think you want to click on the \"Upcase Membership\" call to action in the settings page.", "reference": "~~Should this match the key updated above?~~ :+1:" }, { - "prediction": "I'm not sure what you mean by \"could not open exclusion tagfile: %v\"", + "prediction": "I don't think we need to close the file here. It's already closed in the defer.", "reference": "`gofmt` allows a more compact form `defer func() { _ = f.Close() }()` or just add `// nolint:errcheck` before `defer`." }, { - "prediction": "I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to create a miner with a specific pledge and collateral, but you don't want to use the `miner create` command to do that. Instead, you want to use the `miner create` command to create a miner with a specific pledge and collateral, but you don't want to use the `miner create` command to do that.", "reference": "collateral is in FIL" }, { - "prediction": "I don't think this is a good idea. We should be able to get the channel from the channel pool, not from the channel itself.", + "prediction": "I don't think we need to check if the channel is already loaded or not. If the channel is not loaded, we should create a new channel. If the channel is already loaded, we should use the existing channel.", "reference": "We should not create channel of node which are not connected." }, { @@ -11251,11 +11251,11 @@ "reference": "Please use properties without suffix `_fr` so they can work across different languages as @teolemon mentioned" }, { - "prediction": "I'm not sure what you mean by \"start_request\" and \"end_request\" in this context. What do they do?", + "prediction": "I'm not sure if this is the right place to do this, but I think it would make sense to move this to the `st_h2o_http3client_req_t` struct.", "reference": "Declaration here is `static` but the definition at the bottom is non-static?" }, { - "prediction": "I think we should remove the `map[string]string` field, as it's not really needed.", + "prediction": "I think we should remove the `ContentMD5` field since it's not used anymore.", "reference": "Hi @myml, thanks for the contribution! `blob` and `blob/driver` are both in the same module, so you shouldn't need to split this change up into multiple Pull Requests. Also, I'd like to see it working, including the implementation for `s3blob` and `gcsblob` (these should be easy, just pass-through to the provider) and `fileblob` (might be trickier...), and a test in `drivertest/drivertest.go`." }, { @@ -11263,19 +11263,19 @@ "reference": "Was it a bug?" }, { - "prediction": "I think we can remove the `if isinstance(attr_value, dict) and 'string' in attr_value and attr_value['string'] is not None and attr_value['string'] == value:` check.", + "prediction": "I think we can remove the `if isinstance(attr_value, dict) and 'string' in attr_value and attr_value['string'] is not None and attr_value['string'] == value` check.", "reference": "# `attr_value['string'] is not None` probably not required as `attr_value['string'] == value` check is already being done" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to modify the `tabbed_browser._now_focused._last_hovered_link` variable, but I'm not sure what you're trying to do with it.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `tabbed_browser._now_focused._last_hovered_link` variable.", "reference": "You're accessing private variables here - `last_hovered_link` should be public in `TabData`. As for `tabbed_browser._now_focused`, I think you can use `tabbed_browser.widget.currentWidget()` instead." }, { - "prediction": "I think this should be `to: @invitation.email` instead of `to: @invitation.email`", + "prediction": "I think we should remove the `to: @invitation.email` line.", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { - "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to add this to the `Microsoft.Azure.TestUrlExtensions` namespace. I think it's a good idea to add this to the `Microsoft.Azure.TestUrlExtensions` namespace. I think it's a good idea to add this to the `Microsoft.Azure.TestUrlExtensions` namespace. I think it's a good idea to add this to the `Microsoft.Azure.TestUrlExtensions` namespace. I think it's a good idea to add this to the `Microsoft.Azure.TestUrlExtensions` namespace. I think it's a good idea to add this to the `Microsoft.Azure.TestUrlExtensions` namespace. I think it's a good idea to add this to the `Microsoft.Azure.TestUrlExtensions` namespace. I think it's a good idea to add this to the `Microsoft.Azure.TestUrlExtensions` namespace. I think it's a good idea to add this to the `Microsoft.Azure.TestUrlExtensions` namespace. I think it's a good idea to add this to the `Microsoft.Azure.TestUrlExtensions` namespace. I think it's a good idea to add this to the `Microsoft.Azure.TestUrlExtensions` namespace. I think it's a good idea to add this to", + "prediction": "I think this should be `using System.Linq;` instead of `using System.Collections.Generic;`", "reference": "We should file a bug for this - we don't need the extensions class if there are no operations on the client" }, { @@ -11283,15 +11283,15 @@ "reference": "Is it possible to import from k8s instead of copy in? :)" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `ProjectCacheProvider` class, so that it can be used by other providers as well.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `ProjectCacheProvider::processSuccessfulRun` method, so that it can be used by other providers as well.", "reference": "`@param float` can be dropped here." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear to me what you're trying to do here. I don't think this is a good idea. It's not clear to me what you're trying to do here. I don't think this is a good idea. It's not clear to me what you're trying to do here. I don't think this is a good idea. It's not clear to me what you're trying to do here. I don't think this is a good idea. It's not clear to me what you're trying to do here. I don't think this is a good idea. It's not clear to me what you're trying to do here. I don't think this is a good idea. It's not clear to me what you're trying to do here. I don't think this is a good idea. It's not clear to me what you're trying to do here. I don't think this is a good idea. It's not clear to me what you're trying to do here. I don't think this is a good idea. It's not clear to me what you're trying to do here. I don't think", + "prediction": "I don't think this is needed anymore.", "reference": "maybe we can leave this change un-reverted." }, { - "prediction": "This should be `public` instead of `private`.", + "prediction": "I don't think this is necessary. The `id` field is not used anywhere in the AST.", "reference": "I wouldn't make MethodDeclarator an AccessNode, nor an Annotatable. It's the MethodDeclaration that can be annotated, and has info about the modifiers, and is already an AccessNode" }, { @@ -11299,15 +11299,15 @@ "reference": "delete this class" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to change the default value of `countlyView` from `true` to `false` in this way.", + "prediction": "I'm not sure if this is the right place for this change, but I think it's a good idea to add a check for `s` to see if it's a number. If it's not a number, then it's not a valid number, so we should return `false`.", "reference": "Replacing `+` (1 or more) with `*` (0 or more) would've also done the trick." }, { - "prediction": "I think this should be `throw()` instead of `throw()`.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to close the writer if it's still open. I think it's a good idea to close the writer if it's still open. I think it's a good idea to close the writer if it's still open. I think it's a good idea to close the writer if it's still open. I think it's a good idea to close the writer if it's still open. I think it's a good idea to close the writer if it's still open. I think it's a good idea to close the writer if it's still open. I think it's a good idea to close the writer if it's still open. I think it's a good idea to close the writer if it's still open. I think it's a good idea to close the writer if it's still open. I think it's a good idea to close the writer if it's still open. I think it's a good idea to close the writer if it's still open. I think it's a good idea to close the writer if it's still open. I think it's a good idea to close the writer if it's still open. I think it's a good", "reference": "I've been meaning to fix this for a while. Thanks." }, { - "prediction": "I'm not sure what you mean by \"MyActivityProcessor(C).OnEnd is not called\"", + "prediction": "I'm not sure if this is a bug or a feature. If it's a bug, I think we should fix it. If it's a feature, I don't think it's a good idea.", "reference": "This is adding multiple processor pipelines. I guess you wanted to add multiple processors to the same, single pipeline?" }, { @@ -11315,83 +11315,83 @@ "reference": "If you need str(x[0]) here, you'll probably need str(x) the line after that I suppose. Also, shouldn't we use `raw()` here instead of `str()`?" }, { - "prediction": "I think it's better to use `AtomicLong` instead of `long` for `DEFAULT_BATCH_WRITE_LOCK_TTL` because `AtomicLong` is thread-safe.", + "prediction": "I don't think we need to change the default value of `DEFAULT_BATCH_WRITE_LOCK_TTL` to 3600000.", "reference": "3.6 seconds? what does it stand for?" }, { - "prediction": "I think this should be moved to `Beaker::Host` instead of `Beaker::Facter`?", + "prediction": "I think this should be moved to the `facter` method in the `Beaker::Host` class.", "reference": "If the command fails, is stdout nil or \"\"?" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `AutoRestValidationTestService` interface.", + "prediction": "I think this should be `@GET` instead of `@Path`?", "reference": "Why is api-version now removed in the generated code?" }, { - "prediction": "I don't think this is necessary.", + "prediction": "I don't think this is needed anymore.", "reference": "We may register all built-in optimizers of PyTorch here to simplify the builder." }, { - "prediction": "I think this should be `for (auto &it = ns->components.begin(); it != ns->components.end(); ++it)`", + "prediction": "I think this should be moved to the `BaseGenerator` constructor.", "reference": "No need for this new variable." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `pre-render` lifecycle method.", "reference": "doesn't this enqueue a double render or is that safeguarded somehow" }, { - "prediction": "I'm not sure what you mean by \"break\" here. I think you meant to say \"for c := range a.clients { if c.acc == a { break } }\"", + "prediction": "I don't think we need to break out of the for loop here. We already have `c = a.clients[0]` in the for loop, so we don't need to break out of it.", "reference": "But now you may get DATA RACE reports because c.acc is sometimes changed. I wonder if we should not rework that whole sending subs through route." }, { - "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here. If you want to use the HDF5 library, you should use the `HDF5Reader` class. If you want to use the `HDF5Writer` class, you should use the `HDF5Writer` class. If you want to use the `HDF5File` class, you should use the `HDF5File` class. If you want to use the `HDF5FileWriter` class, you should use the `HDF5FileWriter` class. If you want to use the `HDF5FileReader` class, you should use the `HDF5FileReader` class. If you want to use the `HDF5FileReader` class, you should use the `HDF5FileReader` class. If you want to use the `HDF5FileReader` class, you should use the `HDF5FileReader` class. If you want to use the `HDF5FileReader` class, you should use the `HDF5FileReader` class. If you want to use the `HDF5FileReader` class, you should use the `", + "prediction": "I don't think this is a good idea.", "reference": "Use `ADIADIOS2_HAVE_HDF5`, not `ADIOS_HAVE_PHDF5`" }, { - "prediction": "I'm not sure what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear", + "prediction": "I'm not sure what you're trying to do here. I don't think you want to use `group_value_for` here. I think you want to use `group_value_for_object` instead.", "reference": "Would be nice to put this in a separate context named `\"with a string and a non-string\"` (since that's what it is -- it's definitely not a non-string and a string!)." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think we need to change anything here.", + "prediction": "I think it's better to have `MAX_MEASSTATS_ENTRY` and `MAX_PERTABLE_ENTRY` be the same.", "reference": "Should MAX_PERTABLE_ENTRY here be 10 ?" }, { - "prediction": "I think we should remove the `FrameRequestHeaders` class and replace it with a `RequestHeaders` class.", + "prediction": "I think we should remove the `FrameRequestHeaders` class. It's not needed anymore.", "reference": "Should move these out of frame into a static class? Similar to reason phrases?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `last_valid_instruction` in this case.", "reference": "That means we still create `UseLane` instructions but threat them like `Suppressed`? Can we maybe change this in the pre-processing so that we will just emit `Suppress` instructions in these cases?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure", + "prediction": "I don't think we need to change this, but I'm not 100% sure that this is the right place to do it.", "reference": "no need to move here, iotex-proto is outside of iotex-core and considered same as iotex-address, go-pkgs" }, { - "prediction": "I think this should be `check_stack_alignment();` instead of `check_stack_alignment()`.", + "prediction": "I think this should be `for (int i = 0; i < 50; ++i)` instead of `for (int i = 0; i != 50; ++i)`.", "reference": "Looks like a clang-format style violation: should turn Travis red." }, { - "prediction": "I'm not sure what you're trying to do here, but I'm not sure if this is the best way to do it.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to allow users to configure their own success/pending/failure colors.", "reference": "I think we need some YARD docs here, particularly to list all the color symbols that are valid. Otherwise users will have to look at the source to discover that." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `getSiteInfoProperty` function that can be used to get the value of a site info property.", + "prediction": "I don't think this is necessary. The `getSiteInfoProperty` function is already defined in the `Data` module, so we don't need to create a new one.", "reference": "Not sure if this needs a doc block or not since it's completely internal, but for cleaning this up. (@felixarntz docs?)" }, { - "prediction": "I think we can remove `-Wno-deprecated-declarations` and `-Wstrict-aliasing` as they are not needed.", + "prediction": "I think we should remove `-Wno-deprecated-declarations` and `-Wstrict-aliasing` as they are not needed anymore.", "reference": "The change here is to address what exactly?" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `Options` struct.", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be good to have this in the `Options` struct as well.", "reference": "Is this really an Option? IIUC, you compute it automatically for the URLOpener case, why would we require a user to fill it in when using the constructor? I.e., can't we drop this and use `adal.MSIAvailable` instead? If that call is expensive, cache it on `bucket`, not `Options`." }, { - "prediction": "I'm not sure what you mean by `dp_bits = 0;` and `dp_bits = nullptr;`", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `nullptr` for `dp_bits`.", "reference": "Was this done automatically or by hand?" }, { - "prediction": "I think this should be `current_group.name == desired_group` instead of `current_group.name == desired_group`", + "prediction": "I think this should be `current_group.groups.each do |child_group|` instead of `desired_group = child_group.name if current_group.name == desired_group`", "reference": "This looks like it will only work for the first child, since after that we've overridden `desired_group`. Should we have a separate variable for this?" }, { @@ -11399,15 +11399,15 @@ "reference": "Should this be a constant somewhere?" }, { - "prediction": "I think this should be `assembly: InternalsVisibleTo(\"OpenTelemetry.Instrumentation.Http\" + AssemblyInfo.MoqPublicKey)` instead of `assembly: InternalsVisibleTo(\"OpenTelemetry.Instrumentation.Http\" + AssemblyInfo.PublicKey)`.", + "prediction": "I think this should be `assembly: InternalsVisibleTo(\"OpenTelemetry.Instrumentation.Http\" + AssemblyInfo.PublicKey)`", "reference": "nit: sort alphabetically." }, { - "prediction": "I don't think this is necessary. The `paramsPrefix` is already defined in the `JsonQueryConverter` class, so we don't need to define it again.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `paramsPrefix` field to the `JsonQueryConverter` class. This would allow us to use the `paramsPrefix` in the `toLocalParams` method.", "reference": "Now, It's redundant, I suppose." }, { - "prediction": "I think we should remove the `Implementation` field from the `List` interface. It's not needed anymore.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to keep this in sync with the other implementations. I'm not sure if this is a good idea, but I think it's a good idea to keep this in sync with the other implementations. I'm not sure if this is a good idea, but I think it's a good idea to keep this in sync with the other implementations. I'm not sure if this is a good idea, but I think it's a good idea to keep this in sync with the other implementations. I'm not sure if this is a good idea, but I think it's a good idea to keep this in sync with the other implementations. I'm not sure if this is a good idea, but I think it's a good idea to keep this in sync with the other implementations. I'm not sure if this is a good idea, but I think it's a good idea to keep this in sync with the other implementations. I'm not sure if this is a good idea, but I think it's a good idea to keep this in sync with the other implementations. I'm not sure if this is a good idea, but I think it's a good idea to keep this in sync", "reference": "nit: The format recognized by tooling is `// Deprecated: [..]` so you likely want this to be, // Deprecated: Use \"go.uber.org/yarpc/peer/peerlist/v2\".Implementation instead." }, { @@ -11419,11 +11419,11 @@ "reference": "I believe this can be fixed with the original code if you just omit the \".dll\" file extension so it reads `[DllImport(\"Datadog.Trace.ClrProfiler.Native\")]`. On Windows it would look for `Datadog.Trace.ClrProfiler.Native.dll` and Linux/Mac it would look for `Datadog.Trace.ClrProfiler.Native.so`." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `UserPreferences` class as well. I think it would be a good idea to add this to the `UserPreferences` class as well. I think it would be a good idea to add this to the `UserPreferences` class as well. I think it would be a good idea to add this to the `UserPreferences` class as well. I think it would be a good idea to add this to the `UserPreferences` class as well. I think it would be a good idea to add this to the `UserPreferences` class as well. I think it would be a good idea to add this to the `UserPreferences` class as well. I think it would be a good idea to add this to the `UserPreferences` class as well. I think it would be a good idea to add this to the `UserPreferences` class as well. I think it would be a good idea to add this to the `UserPreferences` class as well. I think it would be a good idea to add this to the `UserPreferences` class as well. I think it would be a good idea to add this", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `UserPreferences` class.", "reference": "couldn't we just read the boolean as a string (I would assume that this return \"true\" or \"false\"), migrate if to its new value and keep using the same pref key?" }, { - "prediction": "I don't think this is necessary. We can just use `json_input = 1` and `jx_input = 1` instead of `json_input = 0` and `jx_input = 0`.", + "prediction": "I don't think this is necessary.", "reference": "If these variables are only used in main function, move these to the beginning of that function. If there is a foreseeable reason to have them as global statics just let me know." }, { @@ -11431,43 +11431,43 @@ "reference": "This one was wrong." }, { - "prediction": "I'm not sure I understand what you mean by \"likely due to previously-unresolved assertions becoming resolved\". Could you give an example?", + "prediction": "I'm not sure I understand what you're trying to do here.", "reference": "What happens if nodes throughout a hierarchy are modified (as they would be)? It looks like we're going to `Reset` once for each `NodeID` affected." }, { - "prediction": "I'm not sure what you mean by \"maximum size for switch code\"", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to generate a jump to a hook function, but you're not passing the hook location to the function.", "reference": "> Note that allocation of vmheap fails upon initializing dynamoRIO 64 on WoW64 processes. Thus, we need to pass -reachable_heap to avoid having to make this allocation. This should be solved by changing the default `vmheap_size` to be much smaller than 8GB for x64 DR inside WOW64." }, { - "prediction": "I think this should be `@exception_presenter.fully_formatted_lines(failure_number, colorizer)` instead of `@exception_presenter.fully_formatted(failure_number, colorizer)`.", + "prediction": "I think this should be `fully_formatted` instead of `fully_formatted_lines`.", "reference": "Is it really worth expanding our public API for this? After all, isn't calling this the same as calling `notification.fully_formatted(...).lines`? If so, I'd rather not widen our API (and thus, increase our maintenance burden) when it's so simple to get all the lines already." }, { - "prediction": "I think this should be `public interface Generator { ... }` instead of `public interface Generator { ... }`", + "prediction": "I think this should be `public interface Generator { ... }` instead of `public interface Generator { ... }`.", "reference": "Is it necessary to keep this class around just to define this constant? Or can we place it somewhere else?" }, { - "prediction": "I'm not sure what you mean by \"troubleshooting purpose\" in this context. Is it related to logging and CLI?", + "prediction": "I don't think we need to use `hashRule` here. We can just use `rule.Name` and `rule.PolicyName` instead.", "reference": "Question - do we cache NetworkPolicy itself? If so, here we can point to NetworkPolicy?" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to `k8s.io/client-go/util/workqueue` so that it can be used by `k8s.io/client-go/tools/cache` and `k8s.io/client-go/tools/clientcmd` as well.", + "prediction": "I don't think we need to use `workqueue` here. We can just use `sync.Mutex` and `sync.WaitGroup` instead.", "reference": "For my view, `Register` means the process of **insert node resource to etcd through api-server**, which is called by upstream rather than here, how about changing the func name to `OnConnected`?" }, { - "prediction": "I think it's a good idea to have a default value for `telemetryEndpoint` in the `ProcessEngineConfigurationImpl` class.", + "prediction": "I think it's better to have a `telemetryInitialized` field in the `ProcessEngineConfigurationImpl` class, so that it can be checked in the `ProcessEngineConfiguration` class.", "reference": "I would prefer an active verb for this property, e.g. `initializeTelemetry`. The reason is that this property refers to something the engine does once on startup. Other properties that use passive voice (e.g. `authorizationEnabled`) refer to a state of the engine during its lifetime." }, { - "prediction": "I think this should be `public bool ContainsTimeSpan => this.Methods.Any(m => m.Parameters.Any(p => p.Type == PrimaryType.TimeSpan));`", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to `Microsoft.Rest.Generator.NodeJS` as well.", "reference": "please use new line to maintain reasonable line width" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add the tag to the context.", + "prediction": "I don't think this is necessary.", "reference": "I would skip this check or add an internal server error response." }, { - "prediction": "I don't think we need to update `config.notarize` and `config.notary_user` and `config.notary_password` in this case. We can just use `config.buildConfig.notarize` and `config.buildConfig.notary_user` and `config.buildConfig.notary_password`.", + "prediction": "`config.notarize` and `config.notary_user` and `config.notary_password` should be `config.notarize` and `config.notaryUser` and `config.notaryPassword` respectively.", "reference": "missing `{` here (and then `}` after `notary_password = config.notary_password`); it's only going to do the first one" }, { @@ -11475,15 +11475,15 @@ "reference": "This is odd because it's actually in our generated SiteSettingsPath, not in the SiteLocalSettingsPath (wp-config-ddev.php). Are these two files swapped somehow? I'd expect SiteSettingsPath to be wp-config.php and SiteLocalSettingsPath to be wp-config-ddev.php. BTW, I'm *way* ok with renaming that to SiteDdevSettingsPath." }, { - "prediction": "I'm not sure what you're trying to do with this file, but I think it's a good idea to rename it to `kythe-extraction-config` instead of `kythe-extraction-config-go`.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to `kythe/config.go` so that it can be used by `kythe/extractor.go` and `kythe/extractor_test.go` as well.", "reference": "It seems like this must necessarily be a stopgap. Can you please add a TODO(#xyz) to point to the appropriate issue?" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use the same name for the two functions.", "reference": "Is the return signature necessary since we never actually return if there is a problem (I'm referring to the call to `logrus.Fatalf`). Let's pick a pattern and stick with it." }, { - "prediction": "I'm not sure what you mean by \"new-cap\". I'm not sure what you mean by \"new-cap\". I'm not sure what you mean by \"new-cap\". I'm not sure what you mean by \"new-cap\". I'm not sure what you mean by \"new-cap\". I'm not sure what you mean by \"new-cap\". I'm not sure what you mean by \"new-cap\". I'm not sure what you mean by \"new-cap\". I'm not sure what you mean by \"new-cap\". I'm not sure what you mean by \"new-cap\". I'm not sure what you mean by \"new-cap\". I'm not sure what you mean by \"new-cap\". I'm not sure what you mean by \"new-cap\". I'm not sure what you mean by \"new-cap\". I'm not sure what you mean by \"new-cap\". I'm not sure what you mean by \"new-cap\". I'm not sure what you mean by \"new-cap\". I'm not sure what you mean by \"new-cap\". I'm not sure what you mean by \"new-cap\". I'm not sure what you mean by \"new-cap\". I'm not sure what you mean by \"new-cap\". I'm not sure", + "prediction": "I don't think we need to use `new-cap` here. We can just use `Ember.$(document).JsBarcode(id, { width: 1, height: 20 })`", "reference": "@btecu why is this override needed here? I'm not seeing a `new` being used here." }, { @@ -11491,15 +11491,15 @@ "reference": "Should it not be more something like: `MaxAccountConnectionsExceeded` here?" }, { - "prediction": "I'm not sure I understand what you're trying to do with this test case. It seems like you're trying to validate that the `-disable_gcs_logging` flag is set to `false` or `true` based on the value of the `-compute_service_account` flag, but you're not actually using the `parseAndValidate` function to do so.", + "prediction": "I'm not sure why this test is failing, but I think it should be fixed.", "reference": "minor: use a non-default CE service account for testing (since default is handled in a specific way in the code)" }, { - "prediction": "I think we can remove the `presealPath` and just use `genesis-sectors` instead.", + "prediction": "I'm not sure if this is a good idea or not, but I think it would be better to use `time.Now()` instead of `time.Unix()`.", "reference": "This is how I ran the 512MiB test. It's probably too much data for a fixture, and makes for longer functional tests (although still less than a minute on my laptop)." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to set the `@options[:hosts_file]` in the `resolve_symlinks!` method, but you're not actually setting it in the `resolve_symlinks` method.", + "prediction": "I'm not sure what you're trying to do here, but I think it's a bad idea to use `File.realpath` in this way.", "reference": "So we weren't able to hide the fact that the file wasn't pre-generated and had to introduce this \"option\" to detect that?" }, { @@ -11515,7 +11515,7 @@ "reference": "it doesn't look like these need to be exported?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think we need to change anything here.", + "prediction": "I don't think we need to use `fmt.Println` here. We can just use `fmt.Println` in the `main` function.", "reference": "I think you should remove \"fmt\" here. And change `fmt.Errorf` to `errors.Errorf`." }, { @@ -11523,11 +11523,11 @@ "reference": "Here's the `resources` attribute @jferris. I'm not against renaming `Product` to `Resource`, and this one... something else." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not", + "prediction": "I'm not sure what you mean by \"FinalFunc is always run, regardless of any other previous errors.\"", "reference": "If the context is unused, this is equivalent to `var wg errgroup.Group`." }, { - "prediction": "I'm not sure what this is for, but it looks like it could be used to set the `fragAlignRatio` and `fragsizeIsMinimum` in the `HighlightParams` class. I'm not sure if this is a good idea, but I'll leave it here for now.", + "prediction": "I'm not sure what this is for, but I think it should be `REGEX` instead of `REGEXISMINIMUM`.", "reference": "very minor: I'd prefer these two added rows are switched so that fragsizeIsMinimum directly follows fragsize" }, { @@ -11535,11 +11535,11 @@ "reference": "Given that 115 returns `True`, why would this be `False` here?" }, { - "prediction": "I'm not sure what you mean by \"redirect default login page\". I think you meant to say \"redirect login page\".", + "prediction": "I'm not sure what you mean by \"redirect default login page\". I think you're asking for a redirect to the default login page, but I'm not sure what you mean by \"redirect default login page\". I think you're asking for a redirect to the default login page, but I'm not sure what you mean by \"redirect default login page\". I think you're asking for a redirect to the default login page, but I'm not sure what you mean by \"redirect default login page\". I think you're asking for a redirect to the default login page, but I'm not sure what you mean by \"redirect default login page\". I think you're asking for a redirect to the default login page, but I'm not sure what you mean by \"redirect default login page\". I think you're asking for a redirect to the default login page, but I'm not sure what you mean by \"redirect default login page\". I think you're asking for a redirect to the default login page, but I'm not sure what you mean by \"redirect default login page\". I think you're asking for a redirect to the default login page, but I'm not sure what you mean by \"redirect default login page\". I think you're asking for a redirect to the", "reference": "Please move this test method just below `oauth2LoginWithOneClientConfiguredThenRedirectForAuthorization()`" }, { - "prediction": "I think it's better to use `c_TimeInfinite` instead of `Duration_t(1, 0)`.", + "prediction": "I think we can remove the `qos.m_liveliness.lease_duration` and `qos.m_liveliness.announcement_period` fields.", "reference": "Why this new configuration?" }, { @@ -11547,19 +11547,19 @@ "reference": "I don't think that we need to check `hasArray` here. I think the reason why this didn't previously check `hasArray` is that the array passed to `DataByteArray` must start at offset 0 and be valid through the array length, so a copy was needed in almost every case. It may be simpler to change this to use `ByteBuffers.toByteArray` and pass the result to create `DataByteArray`." }, { - "prediction": "I think we can remove the `T` parameter from the `Add` method. It's not needed anymore.", + "prediction": "I think we can remove the `T` parameter from the `Add` method, since it's not used anywhere.", "reference": "`spanReference` -> `baggage`" }, { - "prediction": "I'm not sure what you're trying to achieve with this route, but it looks like you're trying to get the logo from the `web.logo` environment variable. If you want to get the logo from the `verdaccio.logo` environment variable, you'll need to change the route to something like `/-/verdaccio/logo` or `/-/verdaccio/verdaccio-logo.png`.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `verdaccio` folder in the root of the app.", "reference": "Why the `/-/verdaccio/` ?" }, { - "prediction": "I'm not sure what you mean by \"enableAddons\" in this context. It's not clear what you're trying to do here.", + "prediction": "I don't think we need to add the `enableAddons` flag to the `pushAddonsTemplateToS3Bucket` function. We can just use the `enableAddons` flag in the `pushAddonsTemplateToS3Bucket` function.", "reference": "Has been waiting for a million years" }, { - "prediction": "I'm not sure if this is the right place to add this message, but I think it's a good idea to add this message to the `Number` and `String` messages as well.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `min` and `max` field in the `msg` object.", "reference": "Minor grammar detail: the 'than' is unnecessary" }, { @@ -11571,11 +11571,11 @@ "reference": "if we are returning the `ws` here when passing in `se:cdp` we can just return it straight or do we have to make a request to get the `ws` address?" }, { - "prediction": "I'm not sure what you mean by \"internal dependencies\", but I think this is the right place to register the `Data` store.", + "prediction": "I'm not sure why we need to register the store here. It's already in the `googlesitekit/datastore/site.js` file. Is there a reason why we need to register it here?", "reference": "I could add a resolver for this (like above) but it seems more sensible to just change the one reference!" }, { - "prediction": "I think we can remove the `minimumSecondsSinceParent` parameter from the `validateHeaderSufficientlyAheadOfParent` method.", + "prediction": "I think we can remove the `minimumSecondsSinceParent` field from the `validateHeaderSufficientlyAheadOfParent` method.", "reference": "not sure \"actual\" adds value - secondsSinceParent is probably closer." }, { @@ -11583,19 +11583,19 @@ "reference": "Line is too long. [94/80]" }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.", + "prediction": "I don't think this is a good idea. It's not clear to the user what they should do if they don't want to delete an item. I think it would be better to have a message like \"You cannot delete any item. You should modify the existing\" in the repeater.", "reference": "The error should be `At least :number items are required`" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to move this into the `HandleConsensusMsg` function.", + "prediction": "I think this should be `switch cMsg.(type)` instead of `switch msg.(type)`.", "reference": "singleCaseSwitch: should rewrite switch statement to if statement (from `gocritic`)" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don", + "prediction": "I think this should be `encryptionKeyGetter` instead of `mdDecryptionKeyGetter`?", "reference": "Could combine this with `encryptionKeyGetter` to have a single `keyGetter` interface. I'm not sure which way is better." }, { - "prediction": "I'm not sure what you mean by \"HBaseClient_JNI::deleteInstance();\". Is this the same as HiveClient_JNI::deleteInstance();?", + "prediction": "I'm not sure why we need to call HiveClient_JNI::deleteInstance() here. I think we can just call HiveClient_JNI::deleteInstance() directly.", "reference": "Is there any security issue here? If we integrate with Hive security (and I don't know if we have or not) is there some notion of re-authentication at connection time?" }, { @@ -11603,39 +11603,39 @@ "reference": "Does this mean we do not support writeConcern on `createCollection`?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for `RequestSessionDestroy` to make sure that the `sid` is valid.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for `RequestSessionDestroy` to make sure that we don't accidentally destroy a session that we don't want to destroy.", "reference": "I guess `sid` was for `sessionID`, but now it looks strange: `sid.ID`." }, { - "prediction": "I'm not sure what you mean by `anyIPv4CidrBlock`", + "prediction": "I don't think we need to do this. We can just use the `SourceSecurityGroupIDs` field in the `SecurityGroupIngressRule` struct.", "reference": "We'll need `infrav1.SecurityGroupBastion` as well" }, { - "prediction": "I think it's a good idea to make this a public API, but I'm not sure how to do that without breaking backwards compatibility.", + "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea to add it to the `fs` package.", "reference": "This `fileName` should probably be `remote` and be relative to the Fs root as per normal rclone usage." }, { - "prediction": "I don't think this is a good idea. It would be better to add a test that does the same thing, but without the re-indexing.", + "prediction": "I don't think we need to do this.", "reference": "That way we are back to having just one index on k_0 So we can really compare the execution times with and without re-indexing" }, { - "prediction": "I don't think this is necessary.", + "prediction": "I don't think this is necessary. The `specialCharacters` string is already defined in the `AttachmentFileDownloadCallback` class.", "reference": "Expression that uses a negation pattern to exclude all characters that aren't in the expression." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should go in the `Request` struct.", + "prediction": "I'm not sure if this is the right place to add this header. I think it should be added to the `Request` header.", "reference": "Similar to my suggestion for HTTP, let's remove this and use `ServiceHeader` instead." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `targetGlobalCommandPath` variable in the `addCustomCommands` function. This way, we don't have to hardcode the `commandSet` variable in the `addCustomCommands` function, and we can use the `targetGlobalCommandPath` variable in the `addCustomCommands` function to set the `commandSet` variable to `targetGlobalCommandPath`. This way, we can avoid hardcoding the `commandSet` variable in the `addCustomCommands` function, and we can use the `targetGlobalCommandPath` variable in the `addCustomCommands` function to set the `commandSet` variable to `targetGlobalCommandPath`. This way, we can avoid hardcoding the `commandSet` variable in the `addCustomCommands` function, and we can use the `targetGlobalCommandPath` variable in the `addCustomCommands` function to set the `commandSet` variable to `targetGlobalCommandPath`. This way, we can avoid hardcoding the `commandSet` variable in the `addCustomCommands` function, and we can use the `targetGlobalCommandPath` variable in the `add", + "prediction": "I don't think we need to do this, we can just use the `targetGlobalCommandPath` for now.", "reference": "The serviceDirOnHost[0:1] was completely wrong. It wasn't just Windows, glad you got this fixed!" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate test for this. I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate test for this. I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate test for this. I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate test for this. I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate test for this. I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate test for this. I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate test for this. I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate test for this. I'm not sure if this is the best way to do this, but I", + "prediction": "I'm not sure if this is a bug or a feature. I think it's a bug, but I'm not sure how to fix it.", "reference": "Would membership take 10+ seconds to detect the failed node?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `try`/`except` block to catch any exceptions that may occur.", + "prediction": "I'm not sure if this is the best place to do this, but I think it's a good place to do this. It's a bit of a hack, but I think it's the best way to do it.", "reference": "hmm, in this case perhaps the whole try-except could be removed altogether? because if the file does not exist, it's already returning `None`. In any other case it should actually probably fail with the exception, no?" }, { @@ -11643,63 +11643,63 @@ "reference": "This function does not need to be public" }, { - "prediction": "I'm not sure if this is the right place to put it, but I think it's a good idea to have it in the `AccountSelect` component.", + "prediction": "I'm not sure if this is the right place to put it, but I think it would be good to put it in the `AccountSelect` component.", "reference": "Any chance we can get a CSS class for this? I know it's just in one place but feels like a dangerous precedent to set." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to get the next link method from the pageable extension, but I'm not sure what you're trying to do here. I think you're trying to get the next link method from the pageable extension, but I'm not sure what you're trying to do here. I think you're trying to get the next link method from the pageable extension, but I'm not sure what you're trying to do here. I think you're trying to get the next link method from the pageable extension, but I'm not sure what you're trying to do here. I think you're trying to get the next link method from the pageable extension, but I'm not sure what you're trying to do here. I think you're trying to get the next link method from the pageable extension, but I'm not sure what you're trying to do here. I think you're trying to get the next link method from the pageable extension, but I'm not sure what you're trying to do here. I think you're trying to get the next link method from the pageable extension, but I'm not sure what you're trying to do here. I think you're", + "prediction": "I'm not sure if this is the best place to put this, but I think it would be good to have this in a separate file, so that we don't have to update it every time we add a new pageable extension.", "reference": "> && this.Extensions.ContainsKey(\"nextMethodName\") [](start = 96, length = 48) From line 124, looks like we don't need `&& this.Extensions.ContainsKey(\"nextMethodName\")` condition or we don't need line 124 #Closed" }, { - "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "prediction": "I think it's better to use `forwardRef` instead of `vnode.ref` in this case.", "reference": "Moving this code from compat to core shaves 47 bytes out of compat and only adds 6 bytes to core so I thought it was worth it." }, { - "prediction": "I'm not sure what you mean by \"use base dir of current process\". Is it possible to use the base dir of the current process? If so, how do I do that?", + "prediction": "I don't think this is needed anymore.", "reference": "Please use \".NET Core 3\" - i'm trying hard to use one form, and this is the one MS advices" }, { - "prediction": "I think it's better to use `time.Sleep` here, instead of `params.Ctx.Done()`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to log the error in `StartSession` as well. This way, we can see if the error is related to the `StartSession` function itself, or if it's related to the `TelemetrySessionParams` or `statsEngine` parameters.", "reference": "Unrelated to this change, but this is a fix for when TestDoStartCgroupInitHappyPath has a failure after the test goroutine has already exited." }, { - "prediction": "I'm not sure what you mean by \"scrolled\" and \"not scrolled\" in this context. I think you meant to use `check_scrolled` and `check_not_scrolled` instead of `check_scrolled_bdd` and `check_not_scrolled_bdd`.", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be good to have a separate file for this.", "reference": "Hmm, I'd really expect this to work, and yet it doesn't. I'll investigate later, though it might get Monday until I get the time." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `std::int64_t` in this case. It's not clear what you're trying to do here, but I don't think it's a good idea to use `std::int64_t` in this case. It's not clear what you're trying to do here, but I don't think it's a good idea to use `std::int64_t` in this case. It's not clear what you're trying to do here, but I don't think it's a good idea to use `std::int64_t` in this case. It's not clear what you're trying to do here, but I don't think it's a good idea to use `std::int64_t` in this case. It's not clear what you're trying to do here, but I don't think it's a good idea to use `std::int64_t` in this case. It's not clear what you're trying to do here, but I don't think it's a good idea to use `std::int64_t` in this case. It's not clear", + "prediction": "I think this should be `for (size_t i = 0; i < support_indices.get_count() - 1; i++)`", "reference": "Does this changes affect process building dynamic libraries anyhow?" }, { - "prediction": "I don't think we need to import `scapy.modules.six.moves` here. We can just use `six.moves` directly.", + "prediction": "I don't think this is necessary. The `PPIGenericFldHdr` is already defined in the `scapy.layers.dot11` module.", "reference": "Could you limit what is imported here?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is it that you want to override the lambda code archive with a fresh one? Or is it that you want to update the lambda code archive with a fresh one? If it's the latter, then I'm not sure I understand what you're trying to do here. Is it that you want to override the lambda code archive with a fresh one? Or is it that you want to update the lambda code archive with a fresh one? If it's the latter, then I'm not sure I understand what you're trying to do here. Is it that you want to override the lambda code archive with a fresh one? Or is it that you want to update the lambda code archive with a fresh one? If it's the latter, then I'm not sure I understand what you're trying to do here. Is it that you want to override the lambda code archive with a fresh one? Or is it that you want to update the lambda code archive with a fresh one? If it's the latter, then I'm not sure I understand what you're trying to do here. Is it that you want to override the lambda code archive with a fresh one? Or is it that you want to update the lambda", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to set the lambda code archive path in the `do_set_function_code` function as well. This way, we don't have to do this every time we want to set the lambda code archive path.", "reference": "just to clarify - on line 1074 we update `zip_file_content` for non-local lambdas, but never store it, which means lambda never picks it up" }, { - "prediction": "I'm not sure what you mean by \"no tiers\" in this case.", + "prediction": "I'm not sure what you mean by \"tests of actions and flow control.\" What do you mean by that?", "reference": "Golang naming convention is to use camel case `icmpPktWithTypeCode` Often the linter will complain" }, { - "prediction": "I think this should be `if (response.StatusCode != 200)` instead of `if (response.StatusCode != HttpStatusCode.OK && response.StatusCode != HttpStatusCode.Accepted)`.", + "prediction": "I think we can remove the `using (var response = await client.SendAsync(request).ConfigureAwait(false));` line.", "reference": "We can do away with assigning the response here too." }, { - "prediction": "I'm not sure if this is the best way to do this, but it seems to work for me.", + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", "reference": "Bumping the newViewportHeight" }, { - "prediction": "I'm not sure what you mean by \"properly serialized\" here. It's not clear to me what you mean by \"properly serialized\" in this context.", + "prediction": "I'm not sure what you mean by \"properly serialized\" here. It's not clear to me what you're referring to.", "reference": "Is this change correct? Looks like a typo and not sure this should be changed?" }, { - "prediction": "I don't think this is a good idea. We should use `astroid.load_module_from_name` to load the module, not `astroid.modutils.load_module_from_name` to load the module.", + "prediction": "I don't think this is a good idea. We should use `astroid` to load the module, not `astroid.modutils.load_module_from_name`.", "reference": "I checked the tests coverage and strangely it look like those three lines are not covered (?!). Do you have the same result on your side ?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not", + "prediction": "I think this should be `using System;` instead of `using System.MathBenchmarks;`", "reference": "nit: please try to avoid changing end of the file (it adds a noise to the code review, but does not provide too much value)" }, { @@ -11707,11 +11707,11 @@ "reference": "I don't see the \"only\" part reflected in the code but maybe I'm missing it. Also, the indentation is misleading: the `.SelectMany` calls are perfectly aligned but are *not* operating on the same \"level\". I'd expect the second `SelectMany` to be on the same height as the inner `Where`, just break `pathObj => pathObj.Where` and lines won't be that long." }, { - "prediction": "I think we should remove the `kind` argument from the `plugin_hooks` type.", + "prediction": "I think we should remove the `kind => given_or_derived` from the `plugin_hooks` and `resources` arrays.", "reference": "It seems like most of these will never be nil, are they optional just in case?" }, { - "prediction": "I'm not sure what you mean by `-1` here. I think you meant to use `null` here.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me if this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me if this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me if this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me if this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me if this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me if this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me if this is the right place to do this, but I think it's a good idea to have a separate test for this. It's", "reference": "`.addColumn(\"c1\", IntegerType.INT, true)` means `PkHandle=true`, maybe should add `.setPkHandle(true)` in line 31" }, { @@ -11723,11 +11723,11 @@ "reference": "The method names `fetchUnfinishedExecutions` and `fetchUnfinishedFlows` are too similar to each other. Would it be better to use the name `fetchUnfinishedFlowsMetadata` since you are only fetching metadata info about the flow?" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to set up the debug environment. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set up the debug environment. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set up the debug environment. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set up the debug environment. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set up the debug environment. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set up the debug environment. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set up the debug environment. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set up the debug environment. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set up the debug environment. I'm not sure what you're trying to achieve with this,", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do it here.", "reference": "Note that `sudo` is not available by default on BSDs; there are a few places in the codebase here where that's explicitly worked around by using `su`." }, { - "prediction": "I think this should be `Answer = 42` instead of `const Answer = 42`", + "prediction": "I'm not sure if this is the best way to go about this, but I think it's a good idea to have a separate package for this.", "reference": "ultra nit: missing Oxford comma :P" }, { @@ -11735,23 +11735,23 @@ "reference": "This is not supported in Spark 3.0.0-rc2 yet. I'd skip this for now." }, { - "prediction": "I'm not sure what you mean by \"like sending and awaiting mined ones\"", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `types` package, since it's used in both `types.SignedMessage` and `types.AttoFIL`.", "reference": "BLOCKING: Why does `Query` return an `*exec.FunctionSignature`?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to reset the block cache to 10000 entries, but you're also trying to reset the dirty block cache to 10000 entries. I think you're trying to reset the block cache to 10000 entries, but you're also trying to reset the dirty block cache to 10000 entries. I think you're trying to reset the block cache to 10000 entries, but you're also trying to reset the dirty block cache to 10000 entries. I think you're trying to reset the block cache to 10000 entries, but you're also trying to reset the dirty block cache to 10000 entries. I think you're trying to reset the block cache to 10000 entries, but you're also trying to reset the dirty block cache to 10000 entries. I think you're trying to reset the block cache to 10000 entries, but you're also trying to reset the dirty block cache to 10000 entries. I think you're trying to reset the block cache", + "prediction": "I think this should be 10000 instead of 10000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", "reference": "please move this down to immediately above the assignment to `c.dirtyBcache`" }, { - "prediction": "I think we can remove the `if err != nil` check here.", + "prediction": "I think we can remove the `if err != nil` here.", "reference": "Don't need the `, err` part since you've already handled it." }, { - "prediction": "I'm not sure what you mean by \"Rxn Smart Processing with Dative Bond\"", + "prediction": "I'm not sure if this is the right place to add this test, but I think it would be good to add it to the test suite.", "reference": "Please add two additional SECTIONs that show that this also works if the dative bond is in the reactant (reaction SMARTS `[O:1]->[H+]>>[O:1].[H+]`) or in the agents (reaction SMARTS `[O:1][H]>N->[Cu]>[O:1].[H]`)" }, { - "prediction": "I'm not sure if this is the right place to do this, but it seems like it should be in the `tls` package. I'm not sure if this is the right place to do this, but it seems like it should be in the `tls` package. I'm not sure if this is the right place to do this, but it seems like it should be in the `tls` package. I'm not sure if this is the right place to do this, but it seems like it should be in the `tls` package. I'm not sure if this is the right place to do this, but it seems like it should be in the `tls` package. I'm not sure if this is the right place to do this, but it seems like it should be in the `tls` package. I'm not sure if this is the right place to do this, but it seems like it should be in the `tls` package. I'm not sure if this is the right place to do this, but it seems like it should be in the `tls` package. I'm not sure if this is the right place to do this, but it seems like it should be in the `tls` package. I'm not sure", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate file for the dynamic listener.", "reference": "What happens if the certificate rotation fails and we are prematurely removing this file?" }, { @@ -11759,19 +11759,19 @@ "reference": "does this change belong here?" }, { - "prediction": "I'm not sure what you mean by `os.Getwd()`. Is this the same as `os.Getwd()`, or is it something else?", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `os.Getwd()` function to get the current working directory, and then use `os.Cwd()` to get the current working directory.", "reference": "This returns an error" }, { - "prediction": "I'm not sure if this is a good idea or not, but I think we should add this to libcalico-go.", + "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea to add this to libcalico-go.", "reference": "If we think we might someday write a native nftables backend, do you think it would make sense to just use generic dataplane configuration? e.g, `dataplane = iptables | ebpf | nftables`, but for now selecting `nftables` uses iptables in nft compat mode?" }, { - "prediction": "I think we can remove the `baseTS` variable and just use `headTipSetAndState.TipSet` instead.", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get the tip set and state from the tip set and state of the miner node, and then compare it to the tip set and state of the test node. I'm not sure what you're trying to do here, but it looks like you're trying to get the tip set and state from the tip set and state of the miner node, and then compare it to the tip set and state of the test node. I'm not sure what you're trying to do here, but it looks like you're trying to get the tip set and state from the tip set and state of the miner node, and then compare it to the tip set and state of the test node. I'm not sure what you're trying to do here, but it looks like you're trying to get the tip set and state from the tip set and state of the miner node, and then compare it to the tip set and state of the test node. I'm not sure what you're trying to do here, but it looks like you're trying to get the tip set and state from the tip set and state of the miner node, and then compare it to the tip set and state of", "reference": "Looks like that helper function is general enough that it should reside in testhelpers" }, { - "prediction": "I think this should be `fileutil.FgrepStringInFile` instead of `fileutil.FgrepStringInFileInDir`.", + "prediction": "I think this should be `fileutil.FgrepStringInFile(filePath, DdevFileSignature)` instead of `fileutil.FgrepStringInFile(filePath, DdevFileSignature)`", "reference": "This isn't incorrect IMO, but I think it would be better to fix this in drupal7PostStartAction and also in drupal6PostStartAction. It seems to me like those were both somehow neglected on this. Use drupal8PostStartAction as example. Congrats on your first golang PR! Please make sure to test it manually." }, { @@ -11779,19 +11779,19 @@ "reference": "I'd like to ensure that the error message at least has some reference to the flag that is not allowed. Something like `/ERROR(.+)--hosts/` would work." }, { - "prediction": "I'm not sure if this is the best way to handle this, but I think it's a good idea to return an error if the user doesn't specify public subnets. If they do, we can still deploy Load Balanced Web Services in this environment, but if they don't, we won't be able to deploy Load Balanced Web Services in this environment. I'm not sure if this is the best way to handle this, but I think it's a good idea to return an error if the user doesn't specify public subnets. If they do, we can still deploy Load Balanced Web Services in this environment, but if they don't, we won't be able to deploy Load Balanced Web Services in this environment. I'm not sure if this is the best way to handle this, but I think it's a good idea to return an error if the user doesn't specify public subnets. If they do, we can still deploy Load Balanced Web Services in this environment, but if they don't, we won't be able to deploy Load Balanced Web Services in this environment. I'm not sure if this is the best way to handle this, but I think it's a good idea to return an error if the user doesn't specify public subnets. If", + "prediction": "I'm not sure if this is the best way to handle this, but I think it's better to return an error here.", "reference": "Should we say \"specifying two public subnets\"?" }, { - "prediction": "I'm not sure what you mean by \"relaxing it slightly\" here. I think it's a good idea to make it more explicit, but I'm not sure how to do that without breaking backwards compatibility.", + "prediction": "I'm not sure what you mean by \"relaxing it slightly\" here. I think it's a good idea to make it more explicit that we don't want to relax it.", "reference": "Issue number? When? Why?" }, { - "prediction": "I don't think this is necessary. We can just use `speech.speak` instead of `speech.recognize` and `speech.recognize_google`.", + "prediction": "I don't think this is necessary. The `__init__` method of `speech.SpeechRecognizer` is called when the object is created, so it's not necessary to call it explicitly.", "reference": "You should not rely on `PitchCommand` being imported into speech. Please import it from `speech.commands`." }, { - "prediction": "I think this should be `CatalogProperties.WAREHOUSE_LOCATION` instead of `CatalogProperties.URI`", + "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `CatalogProperties.WAREHOUSE_LOCATION` instead of `CatalogProperties.URI` in this case.", "reference": "Is this a constant used in the Nessie project itself? If so, perhaps you might consider a follow up for adding `NessieCatalogProperties` class at some point, to help make them more clear to users looking to adopt Nessie coming from the Iceberg repo itself" }, { @@ -11799,7 +11799,7 @@ "reference": "maybe we should rename: MinTaskID -> MinTaskIDExclusive, MaxTaskID -> MaxTaskIDInclusive," }, { - "prediction": "I'm not sure if this is the right place to change this, but I think it's a good idea to make sure that the `NVIDIA_VISIBLE_DEVICES` environment variable is set before the `NVIDIA_RUNTIME` environment variable is set. This way, if the `NVIDIA_RUNTIME` environment variable is set, the `NVIDIA_VISIBLE_DEVICES` environment variable will be ignored.", + "prediction": "I'm not sure if this is the right place to change this, but I think it would be a good idea to make sure that the `NVIDIA_VISIBLE_DEVICES` env var is always set to `nvidia`, and that the `NVIDIA_RUNTIME` env var is always set to `ecs-nvidia`. This way, we don't have to worry about the `NVIDIA_VISIBLE_DEVICES` env var being set to `nvidia`, and we don't have to worry about the `NVIDIA_RUNTIME` env var being set to `ecs-nvidia`. I think it would be a good idea to make sure that the `NVIDIA_VISIBLE_DEVICES` env var is always set to `nvidia`, and that the `NVIDIA_RUNTIME` env var is always set to `ecs-nvidia`. This way, we don't have to worry about the `NVIDIA_VISIBLE_DEVICES` env var being set to `nvidia`, and we don't have to worry about the `NVIDIA_RUNTIME` env var being set to `ecs-nvidia`. I think it would be a good idea to make sure that the `NVIDIA_VISIBLE_DEVICES` env var is always set to `nvidia`, and that the `NVIDIA_RUNTIME` env var is always set to `ecs", "reference": "You may need to make this configurable if we expect people to be able to use the normal Nvidia runtime on other Linux distributions like Ubuntu or Debian." }, { @@ -11811,15 +11811,15 @@ "reference": "> k1 src0 src2 -> dst s/src2/src1/ nit: k1 is actually src0 according to instr_get_src(instr, 0) which makes this a little confusing" }, { - "prediction": "I'm not sure what you mean by \"too permissive\". I think it means that the permissions are too permissive, but I'm not sure what you mean by \"too permissive\" in this context.", + "prediction": "I'm not sure what you mean by \"too permissive\"", "reference": "I believe that you meant to have the following on the second one, right ? `dataDirStat.Mode()^0077`" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a `CloseRemote` method to the `stream` struct. This way, we don't need to call `AddStreamFrame` every time we want to close a remote stream.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would make sense to move this to the `CloseRemote` method.", "reference": "The reason a `ByteCount` is used here, is that the H2 mapping in gQUIC requires this layer violation, which is why `CloseRemote` is not part of the public API. This layer violation will be resolved in IETF QUIC" }, { - "prediction": "I'm not sure what you mean by \"IsEffectInSpell(spell_id, SE_InvisVsAnimals)\"", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be good to have a separate function for this.", "reference": "I dig the helper function!" }, { @@ -11827,7 +11827,7 @@ "reference": "Please add the Copyright header." }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to have this in a separate file.", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be good to have a separate file for this. It's a bit of a hack, but I think it's a good idea to have a separate file for this. I'm not sure if this is a good place to put this, but I think it would be good to have a separate file for this. I'm not sure if this is a good place to put this, but I think it would be good to have a separate file for this. I'm not sure if this is a good place to put this, but I think it would be good to have a separate file for this. I'm not sure if this is a good place to put this, but I think it would be good to have a separate file for this. I'm not sure if this is a good place to put this, but I think it would be good to have a separate file for this. I'm not sure if this is a good place to put this, but I think it would be good to have a separate file for this. I'm not sure if this is a good place to put this, but I think it would be good to have a separate file for this.", "reference": "Is this the best way to import `FileSystemTarget`?" }, { @@ -11835,43 +11835,43 @@ "reference": "Wait -- os_local_state_t.tid is thread_id_t though, so we need to read a pointer-sized value via READ_TLS_SLOT_IMM, rather than changing these locals to ints. Maybe have a READ_TLS_TIDSZ_SLOT_IMM or sthg." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you mean by \"ICorDebug interface cannot be constructed\"", "reference": "Don't use ! in the messages because it isn't used on xplat. There is a SOSPrefix define that can be used (blank on xplat and ! on Windows). Do we really need 3 newlines?" }, { - "prediction": "I think this should be `os.path.expanduser` instead of `os.path.expandabs`?", + "prediction": "I think this should be `os.path.expanduser` instead of `os.path.expandvars`?", "reference": "print out what we got here in the error" }, { - "prediction": "I think this should be `struct jx *jx_eval_null(struct jx_operator *op, struct jx *left, struct jx *right);`", + "prediction": "I think this should be `struct jx *jx_check_errors(struct jx_operator *op, struct jx *left, struct jx *right);`", "reference": "Does this need to be global?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to use the `map` method on a `Tuple2` instead of the `map` method on a `Tuple`.", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to do something like this:\r\n\r\n```java\r\npublic final class TreeMap implements SortedMap, Serializable {\r\n @Override\r\n public Seq values() {\r\n return iterator().map(Tuple2::_2).toStream();\r\n }\r\n\r\n // -- Object```\nReview comment?", "reference": "Yep, could be simplified. Now looks like other *Map.values() impls" }, { - "prediction": "I don't think we need to do this anymore.", + "prediction": "I don't think we need to do this.", "reference": "This method will be for debug?" }, { - "prediction": "I think it's better to have a separate package for `ecdsa.PrivateKey` and `ecdsa.PrivateKeySet` instead of `ecdsa.PrivateKey` and `ecdsa.PrivateKeySet`.", + "prediction": "I think it's better to have a separate package for `ecdsa.PrivateKey` and `ecdsa.PrivateKeySet` instead of having a separate package for `ecdsa.PrivateKey` and `ecdsa.PrivateKeySet` and `ecdsa.PrivateKey` and `ecdsa.PrivateKeySet` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey` and `ecdsa.PrivateKey", "reference": "// Key returns the private key for a specified name that was encrypted with the // provided password. If the private key does not exists it creates a new one // with a name and the password, and returns with `created` set to true." }, { - "prediction": "I'm not sure what you're trying to do here. Is it possible that you're trying to create a `PackageEntity` from a `ClassEntity`? If so, I'm not sure what you're trying to do here. Is it possible that you're trying to create a `PackageEntity` from a `ClassEntity`? If so, I'm not sure what you're trying to do here. Is it possible that you're trying to create a `PackageEntity` from a `ClassEntity`? If so, I'm not sure what you're trying to do here. Is it possible that you're trying to create a `PackageEntity` from a `ClassEntity`? If so, I'm not sure what you're trying to do here. Is it possible that you're trying to create a `PackageEntity` from a `ClassEntity`? If so, I'm not sure what you're trying to do here. Is it possible that you're trying to create a `PackageEntity` from a `ClassEntity`? If so, I'm not sure what you're trying to do here. Is it possible that you're trying to create a `PackageEntity` from a `ClassEntity`? If so, I'm not sure", + "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a separate class for `PackageEntity` and `ClassEntity` instead of having them in the `DiagramEntity` class.", "reference": "Adding the type hints revealed that it was necessary to distinguish between a ``PackageEntity`` and a ``ClassEntity``, because the ``ClassEntity`` has additional attributes that were dynamically added in the previous code, which confused ``mypy``." }, { - "prediction": "I think we should remove the `unsupported_property` and `unsupported_function` decorators.", + "prediction": "I think we should remove `unsupported_property` and `unsupported_function` from the docstring.", "reference": "These two functions should be available now." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to copy the contents of the file into the `p` slice. I think you're trying to copy the contents of the file into the `p` slice, but you're not checking if the source file has the same size and modification time as the destination file. I'm not sure what you're trying to do here, but it looks like you're trying to copy the contents of the file into the `p` slice. I think you're trying to copy the contents of the file into the `p` slice, but you're not checking if the source file has the same size and modification time as the destination file. I'm not sure what you're trying to do here, but it looks like you're trying to copy the contents of the file into the `p` slice. I think you're trying to copy the contents of the file into the `p` slice, but you're not checking if the source file has the same size and modification time as the destination file. I'm not sure what you're trying to do here, but it looks like you're trying to copy the contents of the file into the `p` slice. I think you're", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to read from a file that has already been closed. I'm not sure what you're trying to do here, but it looks like you're trying to read from a file that has already been closed. I'm not sure what you're trying to do here, but it looks like you're trying to read from a file that has already been closed. I'm not sure what you're trying to do here, but it looks like you're trying to read from a file that has already been closed. I'm not sure what you're trying to do here, but it looks like you're trying to read from a file that has already been closed. I'm not sure what you're trying to do here, but it looks like you're trying to read from a file that has already been closed. I'm not sure what you're trying to do here, but it looks like you're trying to read from a file that has already been closed. I'm not sure what you're trying to do here, but it looks like you're trying to read from a file that has already been closed. I'm not sure what you're trying to do here, but it looks like", "reference": "`fi` is what the result of Stat is called elsewhere in this file not `finfo`" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to do something like this:\n```\na: 1, b: 1, c: 3\n```\n\nAnd then you're trying to reorder it to be like this:\n```\na: 1, c: 3, b: 1\n```\n\nIs that what you're trying to do?", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to do something like `subject.sort_by { |k, v| [v, k] }` but I don't think that's what you want.", "reference": "I'm confused; are we just dropping these methods without deprecation?" }, { @@ -11879,19 +11879,19 @@ "reference": "can we use PC's time to version in Distributed Systems?" }, { - "prediction": "I think it's better to use `c.user` instead of `c.user_full_name` in this case.", + "prediction": "I think it's better to use `c.user` instead of `c.user_full_name`", "reference": "is this \"unless\" actually needed?" }, { - "prediction": "I don't think this is necessary. I think it's better to have a `List` instead of a `List`. It's more clear that you're using a `List` and not a `List`.", + "prediction": "I don't think this is necessary. I think it's better to have a `List` in the `RootProcessor` class.", "reference": "We don't accept empty words for lookup anymore, again" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a good idea to remove the `fs.readFileSync` call and just use `yarnOut` directly.", + "prediction": "I think it's better to use `process.exit(1)` instead of `process.exit(0)`.", "reference": "We'll have to account for CI installations being faster than local ones. Do y'all think we should leave it at < 30 green / < 50 orange | >= 50 red or lower our thresholds?" }, { - "prediction": "I think this should be `W3C_MAXIMIZE_WINDOW` instead of `w3cMaximizeWindow`", + "prediction": "I don't think this is a good idea. It's not clear what the purpose of `w3cMinimizeWindow` and `w3cMaximizeWindow` is. It's not clear what the purpose of `setScriptTimeout` is. It's not clear what the purpose of `setTimeouts` is. It's not clear what the purpose of `executeAsyncScript` is. It's not clear what the purpose of `setTimeouts` is. It's not clear what the purpose of `w3cMinimizeWindow` is. It's not clear what the purpose of `w3cMaximizeWindow` is. It's not clear what the purpose of `windowMaximize` is. It's not clear what the purpose of `windowMaximize` is. It's not clear what the purpose of `windowMaximize` is. It's not clear what the purpose of `windowMaximize` is. It's not clear what the purpose of `windowMaximize` is. It's not clear what the purpose of `windowMaximize` is. It's not clear what the purpose of `windowMaximize` is. It's not clear what the purpose of `windowMaximize` is. It's not clear", "reference": "No need for this to be `W3C_` since there is no JWP equivalent" }, { @@ -11899,19 +11899,19 @@ "reference": "As far as I can tell, there's nothing that creates an instance of `Random` or that calls `rand` or `seed`. Am I missing it? If not, let's remove the `Random` class since we don't really need it and we can move the definitions of `shuffle` into `RSpec::Core::Ordering`. One less type :)." }, { - "prediction": "I think this should be `return s.listener.Addr().(*net.TCPAddr)` instead of `return s.listener.Addr().(*net.TCPAddr)`", + "prediction": "I think this should be `return s.listener.Addr().(*net.TCPAddr)`", "reference": "Is this ever actually used?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `NewDefaultProcessor` function to create a new instance of `consensus.ProcessTipSet` instead of creating a new instance of `consensus.ProcessTipSet` and passing it to the `NewDefaultProcessor` function.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would make sense to move it to `consensus.ProcessTipSet` as well.", "reference": "this section of the codebase should be noted as a candidate for caching, and as a place where multiple tipsets is making things extra tricky" }, { - "prediction": "I think this is a good idea, but I don't think it's necessary.", + "prediction": "I think this should be moved to the end of the function.", "reference": "Do we need to save the existing value of the stolen reg somehow?" }, { - "prediction": "I think we can remove the `maxResults` from the `list` method.", + "prediction": "I think this should be `maxResults=1000` instead of `maxResults=500`?", "reference": "maxResults should come from FLAGS once #244 is submitted." }, { @@ -11923,19 +11923,19 @@ "reference": "What exception is actually happening here? AFAIK `pytest.importorskip` with just return `None` if there's nothing to import. Which means that this check'd always return `True`. `pytest.importorskip` is specifically designed to trigger skipping the current test anyway so I don't know why you would wrap it like this." }, { - "prediction": "I don't think we need to change the default headers.", + "prediction": "I don't think this is necessary.", "reference": "Does it send requests with urlencoded bodies anywhere? I thought it sends only json. Maybe content-type should be `application/json` by default?" }, { - "prediction": "I think this should be `--ignore-chromium` instead of `--ignore-chromium`", + "prediction": "I'm not sure if this is the right place to add this option, but I think it's a good idea to add it to the list of available options.", "reference": "I'm not sure about adding more flags here when we're trying to simplify things, I thought we were going to check for patches changes to decide if we needed to update or not?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think we need to change anything here.", + "prediction": "I'm not sure if this is correct, but I think it should be `big.NewInt(testutil.TestGasPriceInt64)` instead of `big.NewInt(testutil.TestGasPriceInt64)`.", "reference": "`testExecutionPb` is a global variable (from `gochecknoglobals`)" }, { - "prediction": "I'm not sure what you're trying to achieve with this method, but I think it should be removed.", + "prediction": "I don't think we need this method anymore.", "reference": "~Method is public and removing it would be a BC Break, you can deprecate it if you want.~" }, { @@ -11943,51 +11943,51 @@ "reference": "this got me a little confused when reading `build.log`. The err is printed with a log.Error later on but that ends up after the stack trace." }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it's a good idea to add it to the README.", + "prediction": "I'm not sure if this is the best place to put this, but I think it's a good idea to add it to the `--keep-namespaces` option as well.", "reference": "Can we make these more explicitly for Rust only? It seems like JS and Go use flags with their name in them." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to open a bucket from a file:// URL. I'm not sure what you're trying to do here, but it looks like you're trying to open a bucket from a file:// URL. I'm not sure what you're trying to do here, but it looks like you're trying to open a bucket from a file:// URL. I'm not sure what you're trying to do here, but it looks like you're trying to open a bucket from a file:// URL. I'm not sure what you're trying to do here, but it looks like you're trying to open a bucket from a file:// URL. I'm not sure what you're trying to do here, but it looks like you're trying to open a bucket from a file:// URL. I'm not sure what you're trying to do here, but it looks like you're trying to open a bucket from a file:// URL. I'm not sure what you're trying to do here, but it looks like you're trying to open a bucket from a file:// URL. I'm not sure what you're trying to do here, but it looks like you're trying to open a bucket from", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check to see if the bucket exists before trying to open it.", "reference": "Should unsupported query parameters just be ignored? I think that's more common than error out." }, { - "prediction": "I think it's a good idea to have a default value for ``task_namespace`` so that we don't have to specify it every time we want to change the namespace of a task.", + "prediction": "I don't think this is a good idea. I think it's better to set the namespace in the file where the namespace is set to avoid unintentionally setting namespace on tasks outside of the scope of the current file.", "reference": "Actually can we avoid mentioning `Register._UNSET_NAMESPACE`. I thought of it as an implementation detail of the simpler concept of \"being unset\". Perhaps the docs become more natural if we remove the \"If called without arguments or with ...\" part and just say \"you have to call this function without arguments at the end of any file it has been used. That is to ensure blah blah\". Something like that. Just a suggestion." }, { - "prediction": "I think this should be `if not self.includeCurrent and isFirst and ((self.direction==\"next\" and itemRange.start<=self.rangeObj.start) or (self.direction==\"previous\" and itemRange.end>self.rangeObj.end)):`", + "prediction": "I think this should be `if not self.includeCurrent and isFirst and ((self.direction==\"next\" and itemRange.start<=self.rangeObj.start) or (self.direction==\"previous\" and itemRange.end>self.rangeObj.end))`", "reference": "I assume it raises COMError? If so perhaps best to just catch that specifically, so as to not hide other more critical errors." }, { - "prediction": "I don't think we need to add `minify` to the list.", + "prediction": "I don't think we need to add `minify` to the list of directives. It's already included in the `caddy-minify` package.", "reference": "Since minify can generate errors, it should at least go after the errors middleware. And you definitely don't want to be minifying after the gzip writer has closed." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you", + "prediction": "I'm not sure what you mean by `t` being configured with a `SpanRecorder`. I think you meant to say that `t` is configured with a `TracerProvider`.", "reference": "nit: we could remove the `config` field as it is a duplicate of the `provider.config` field." }, { - "prediction": "I think this should be `forseti-server-allow-grpc-internal` instead of `forseti-server-allow-grpc`.", + "prediction": "I think it's better to use `forseti-server-allow-grpc-internal` instead of `forseti-server-allow-grpc`.", "reference": "Nit: from the Internet." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add a comment to explain what this change does.", + "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea to add it to the `ioctl/config` package.", "reference": "this is internal package, move to bottom and run 'make fmt'" }, { - "prediction": "I think this is a bad idea. The `ConnectionClosing` property should be a `bool` instead of a `CancellationToken`.", + "prediction": "I think this should be `IConnectionLifetimeNotificationFeature` instead of `IConnectionLifetimeNotification`.", "reference": "Why is this better than ApplicationStopping?" }, { - "prediction": "I'm not sure what you mean by \"one of\" here. Can you clarify?", + "prediction": "I think this should be `ACMEChallengeType` instead of `ACMEChallenge`.", "reference": "Maybe worth expanding that these 2 are supported by cert-manager but other values exist" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `MediaExtension` class as well.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a helper for this, so that we don't have to do this every time we want to render a thumbnail.", "reference": "Why was this merged? It should have raised some questions IMO @core23 @OskarStark . It's already in 3 releases now, so we can't revert it can we? How can we fix this? Please have a look at #1065" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `ProcessBesuNodeRunner` class, not in the `BesuNodeRunner` class. The `ProcessBesuNodeRunner` class is responsible for running the Besu node, and the `BesuNodeRunner` class is responsible for starting the Besu node.", + "prediction": "I'm not sure if this is a good idea or not, but I think it would be better to use `--rpc-http-authentication-credentials-file` and `--rpc-http-authentication-public-key-file` instead of `--rpc-http-authentication-credentials-file` and `--rpc-http-authentication-public-key-file`.", "reference": "What if `node.jsonRpcConfiguration().getAuthenticationPublicKeyFile()` is empty string, would that cause a problem here?" }, { @@ -11995,7 +11995,7 @@ "reference": "The `omitempty` struct tag does not do anything for non-pointer structs. I think we may need to consider making both of these fields pointers, so that they are excluded from output when not set, and also to make it easier to compare to the zero value. That said, I'm happy to merge this now and open an issue to verify the behaviour is as we want ahead of cutting v0.6.0." }, { - "prediction": "I think this should be `t.equals(to)` instead of `t == to`.", + "prediction": "I'm not sure I understand what you're trying to do here. Is it that `from` and `t` are the same object, and `t.equals(to)` returns `false`? If that's the case, why are you using `IteratorUtil.generate(from, t -> t.equals(to) ? null : t.getNext());` instead of `IteratorUtil.generate(from, t -> t == to ? null : t.getNext());`?", "reference": "I think this is should absolutely be `==`, as the interface cannot control the implementation of equals (and it's part of the contract of the enclosing function). Can we add this interface to the exceptions of the rule?" }, { @@ -12003,15 +12003,15 @@ "reference": "It looks like the UID is the only other thing that we use from `namespace`, so I suggest to copy that out and lose `namespace`, so we don't have to worry about setting it to nil." }, { - "prediction": "I don't think we need to change the default image, it's already set to `aws/codebuild/amazonlinux2-x86_64-standard:3.0`", + "prediction": "I don't think we need to use `aws/codebuild/amazonlinux2-x86_64-standard:3.0` here. We can use `aws/codebuild/amazonlinux2-x86_64:3.0` instead.", "reference": "Can we define this constant in the`deploy` pkg instead? this would allow us to keep it private" }, { - "prediction": "I think this should be `linter.set_current_module(\"toto\", \"mydir/toto\")` instead of `linter.set_current_module(\"toto\", \"mydir/toto\", \"mydir/toto\")`", + "prediction": "I don't think this is a good idea. We should be able to set the current module at any time.", "reference": "I don't like this fixture name, should be a noun like `initialized_linter` ? But it's outside of the scope of this MR." }, { - "prediction": "I don't think we need to check the :ExcludeEmailFromExport setting in this case.", + "prediction": "I don't think we need to pass settingsService into the JsonPrinter constructor.", "reference": "Could we keep this as a static reference (JsonPrinter.jsonAsDatasetDto(releasedVersion); and perhaps change the constructor line to just be a static set method and use that here instead? (I suspect it was the warning that 'static methods should be accessed in a static manner' from my IDE that caused me to make this change in the first place...) (I can make a PR to your branch if you want.)" }, { @@ -12019,7 +12019,7 @@ "reference": "Keys.COMMAND seems to be an alias to Keys.META. That isn't mentioned?" }, { - "prediction": "I think we can remove `clockGetter` and `syncBlockCacheFractionSetter` as they are not used anymore.", + "prediction": "I think we can remove the `clockGetter` interface and just use the `clockGetter` type in `diskBlockCacheSetter` and `syncBlockCacheFractionSetter`.", "reference": "This should go in `ConfigLocal` (and then re-generate the mocks)." }, { @@ -12027,31 +12027,31 @@ "reference": "Nitty but entry.get for the same thing" }, { - "prediction": "I think this should be `runtime.GOMAXPROCS(1)` instead of `runtime.LockOSThread()`.", + "prediction": "I think we should be able to do this in `main` as well, but I'm not 100% sure that's the right way to do it.", "reference": "Might not hurt to mention the function never returns (since this all ends in `execve`) so `main` never actually runs." }, { - "prediction": "I think we should remove the `if (!Constants.EADDRINUSE.HasValue)` line.", + "prediction": "I think this should be `if (!Constants.ECONNRESET.HasValue)` instead of `if (!Constants.EADDRINUSE.HasValue)`.", "reference": "nit: add new line after this block" }, { - "prediction": "I think we should remove the `user-select` and `moz-user-select` from the `scratchCategoryMenu` class.", + "prediction": "I think we should remove the `user-select` and `moz-user-select` because they are not needed anymore.", "reference": "I believe there is some javascript that also uses this 60px number for calculations. I think I'd rather keep the number in px instead of rem to make that correspondence easier to see. If 3.25rem != 60px, can you also change the other place where `60` is used to in the JS?" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `sendgrid` module, since `sendgrid` depends on `jinja2` and `jinja2` depends on `jinja2`.", + "prediction": "`sendgrid` should be `sendgrid.helpers.sendgrid.SendGridAPIClient` instead of `sendgrid.sendgrid.SendGridAPIClient`", "reference": "retrying is an installed 3rd party library just like jinja and sendgrid; perhaps try grouping all of them together?" }, { - "prediction": "I think this should be `if (elements instanceof ArrayList || elements instanceof Vector)` instead of `if (elements instanceof ArrayList)`", + "prediction": "I think this should be `ArrayList` instead of `java.util.List`.", "reference": "you could always use List.listIterator with previous() and hasPrevious() to traverse all kinds of j.u.List backwards. No need for special cases for ArrayList and Vector." }, { - "prediction": "I don't think this is a good idea.", + "prediction": "I don't think we need to do this.", "reference": "remove the bitmap of index 1 from the list not the 0th one. because when we keep on undoing, it would be better if we end up with the original image rather than some randomly edited image. I am not sure whether only just removing bitmap from the list would clear memory. I think you should call bitmap.recycle before removing that bitmap from the list." }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to add a comment here explaining what this is for.", + "prediction": "I don't think this is necessary.", "reference": "this is a existing file so let's keep 2019" }, { @@ -12063,47 +12063,47 @@ "reference": "AsReadOnly() would be better here" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to make sure that `changes` is a dictionary, not an object.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `sync` method to the `Collection` class. This would allow you to call `sync` on a collection and it would return a promise that resolves to the result of calling the `sync` method on the collection.", "reference": "I suggest that we use `query_based_sync` instead of `partial_sync`." }, { - "prediction": "I'm not sure what you're trying to say here. I think you're trying to say that the `OpenBucket` method is not fully portable, and that it will not work unless the request includes a `x-ms-blob-type` header set to `\"BlockBlob\"`. Is that what you're trying to say?", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `azureblob.OpenBucket` instead of `azureblob.OpenBucketWithSas`.", "reference": "How does the user use this? By converting the type using `As` function and add the header? Maybe add an example on how." }, { - "prediction": "I'm not sure what you mean by \"LongRunningTransformer\" in this context. It's not a transformer, it's a class.", + "prediction": "I don't think we need to use `OptionalArrayMethodView` here. We can just use `ArrayMethodView` instead.", "reference": "I'm trying to understand the effects of this change. Is setting this to something other than the old default (that is, `initCodeTransformer = new InitCodeTransformer()`) generally necessary, or are we doing this only to support Python?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is it that you want to get the key from a document? If that's the case, why not just use the `Get` method of the `Document` struct?", + "prediction": "I'm not sure I understand what you're trying to do here. Is this for a specific driver? If so, what's the purpose of the `nil` argument? If not, what's the purpose of the `nil` argument?", "reference": "\"Constructor\" isn't a standard term in Go or this project, although we use it informally amongst ourselves. And I think it will confuse people coming from languages like Java. So can we leave this as it was?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `__set_up_test_dir` method to set up the test directory. This way, we don't need to call `self.__set_up_test_dir` every time we run the tests.", + "prediction": "I'm not sure I understand what you're trying to do with this test. It's not clear to me what you're trying to do with this test. It's not clear to me what you're trying to do with this test. It's not clear to me what you're trying to do with this test. It's not clear to me what you're trying to do with this test. It's not clear to me what you're trying to do with this test. It's not clear to me what you're trying to do with this test. It's not clear to me what you're trying to do with this test. It's not clear to me what you're trying to do with this test. It's not clear to me what you're trying to do with this test. It's not clear to me what you're trying to do with this test. It's not clear to me what you're trying to do with this test. It's not clear to me what you're trying to do with this test. It's not clear to me what you're trying to do with this test. It's not clear to me what you're trying to do with this test. It's not clear to me what you're trying to do with this test.", "reference": "Why do we have to change the test dir?" }, { - "prediction": "I think it's better to return `true` for `TEXTAREA`, `SELECT`, `SUMMARY` and `DETAILS` instead of `false`.", + "prediction": "I think it's better to use `el.querySelector('summary')` instead of `el.querySelector('summary') && !el.querySelector('summary')`", "reference": "This should test the flattened tree instead. details > summary works across shadow tree boundaries." }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it should be in the `MvxAndroidLog` namespace.", + "prediction": "I think this should be `MvxAndroidLog.Instance` instead of `MvxAndroidLog`", "reference": "Not sure I am a big fan of these duplicated Log classes." }, { - "prediction": "I'm not sure I understand what you're trying to do here. What's the purpose of the `CleanUpError`, `PresentError`, `Presented`, and `Failed` types?", + "prediction": "I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place", "reference": "It's long-winded, but the convention is to give constants a common prefix which, see `reasonDomainVerified` ." }, { - "prediction": "I'm not sure what you're trying to achieve with this value, but I think it's a good value to use for the `LOOKAHEAD_DISTANCE_WITHOUT_LANES` constant.", + "prediction": "I'm not sure what you're trying to achieve with this, but I think it would be better to just use `LOOKAHEAD_DISTANCE_WITHOUT_LANES` instead of `FAR_LOOKAHEAD_DISTANCE`.", "reference": "Using lanes later down, this threshold could be reduced for similar effects. Otherwise we look a bit to far." }, { - "prediction": "I'm not sure what you mean by \"in single shot mode, immediately quit when disconnected.\"", + "prediction": "I'm not sure what you mean by \"in single shot mode, immediately quit when disconnected.\" I think you meant to say \"in single shot mode, don't immediately quit when disconnected.\"", "reference": "Let's get more verbose about names. struct `wq_conda_environment`: if it can really only be used for conda. struct `wq_software_environment`: if it has potential use outside of conda." }, { - "prediction": "I'm not sure what you're trying to achieve with this test case. It's not clear what you're trying to do with the `lastPageInPaginatedResp` variable.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to mock the `ssm.GetParametersByPath` function.", "reference": "Should we set this back to `false` inside each `t.Run`? so that we can have more than one testcase that can have paginated responses" }, { @@ -12111,7 +12111,7 @@ "reference": "What about using `dataManifests == null || deleteManifests == null`?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a `TopScoreDocCollector` with a `GlobalHitsThresholdChecker`, but I'm not sure what you're trying to achieve with that.", + "prediction": "I'm not sure what you mean by `new GlobalHitsThresholdChecker(TOTAL_HITS_THRESHOLD)`. I think you meant `new GlobalHitsThresholdChecker(TOTAL_HITS_THRESHOLD, true)`?", "reference": "The `HitsThresholdChecker` should be created once and shared within the collectors ? We also don't need to use the `GlobalHitsThresholdChecker` if the executor is null or if there is a single slice." }, { @@ -12119,7 +12119,7 @@ "reference": "move this to below `antrea.io` import section" }, { - "prediction": "I'm not sure what you mean by \"older means that predate . instances that were created via older means that predate . instances that were created via older means that predate .", "reference": "Seems likely to confuse people. What if we moved it into ActivitySourceAdapter and made it private?" }, { @@ -12127,11 +12127,11 @@ "reference": "gas price don't need to be a multiple cuz we support allll gas prices now" }, { - "prediction": "I'm not sure what you mean by \"handle client process exit\"", + "prediction": "I'm not sure what you mean by \"handle client process exit\".", "reference": "We are exposing implementation details in the interface. What if there is no processes involved in an implementation of `ITestRequestSender`?" }, { - "prediction": "I think this should be `except Exception as e:` instead of `except Exception as e: # pylint: disable=broad-except`", + "prediction": "I don't think this is a good idea.", "reference": "It would be awesome not to handle the broad exception here. Instead, raise a custom exception, something like `ModelNotSetException`, from the `require_model()`, and then handle it here with a nicer message to tell the user to set the model first." }, { @@ -12139,27 +12139,27 @@ "reference": "This already exists under the `theme` lang key, please remove this." }, { - "prediction": "I'm not sure what you're trying to achieve with this component. It looks like you're trying to create a component that uses the Google Site Kit wizard, but it doesn't seem to be doing anything useful. Is there something specific you'd like to add or modify about this component?", + "prediction": "I'm not sure what you mean by \"this component doesn't use hooks and thus can't access the feature flags, so we don't render the HelpMenu here.\"", "reference": "Let's add a simple inline HOC around the default export below to provide the value as a prop (no need to introduce a reusable function for this yet)." }, { - "prediction": "I think this should be `v.vm.network :private_network, ip: \\\"#{host['ip'].to_s}\\\", :netmask => \\\"#{host['netmask'] ||= \"255.255.0.0\"}\\\"`", + "prediction": "I think this should be `:netmask => \"#{host['netmask'] ||= \"255.255.0.0\"}\"`.", "reference": "I believe that you end up printing out the result of the assignment here instead of the netmask." }, { - "prediction": "I think we can remove the `PORT_SERVER_1` and `PORT_SERVER_2` from the `PORT_SERVER_1` and `PORT_SERVER_2` in the `CREDENTIALS` object.", + "prediction": "I think we can remove the `PORT_SERVER_1` and `PORT_SERVER_2` from the `PORT_SERVER_1` and `PORT_SERVER_2` in the `PORT_SERVER_1` and `PORT_SERVER_2` in the `PORT_SERVER_1` and `PORT_SERVER_2` in the `PORT_SERVER_1` and `PORT_SERVER_2` in the `PORT_SERVER_1` and `PORT_SERVER_2` in the `PORT_SERVER_1` and `PORT_SERVER_2` in the `PORT_SERVER_1` and `PORT_SERVER_2` in the `PORT_SERVER_1` and `PORT_SERVER_2` in the `PORT_SERVER_1` and `PORT_SERVER_2` in the `PORT_SERVER_1` and `PORT_SERVER_2` in the `PORT_SERVER_1` and `PORT_SERVER_2` in the `PORT_SERVER_1` and `PORT_SERVER_2` in the `PORT_SERVER_1` and `PORT_SERVER_2` in the `PORT_SERVER_1` and `PORT_SERVER_2` in the `PORT_SERVER_1` and `PORT_SERVER_2` in the `PORT_SERVER_1` and `PORT_SERVER", "reference": "We have to update the filename here." }, { - "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to change the behavior of `FlatCompiler::GetUsageString` so that it doesn't construct custom string types by passing `std::string` from `Flatbuffers`, but instead uses `char* + length` to construct them. Is that correct?", + "prediction": "I'm not sure what you're trying to achieve with this option, but I think it should be removed.", "reference": "The `--cpp-field-case` looks like `--cpp-field-style` instead of `-case`. - 'unchanged' - leave unchanged (default); - 'upper_camel' -upper camel case; - 'lower_camel' - lower camel case." }, { - "prediction": "I'm not sure what you mean by \"GCancellable parameter is not used.\"", + "prediction": "I'm not sure if this is a good idea, but I think it would be better to remove the `origin_changed` flag from `ot_admin_builtin_upgrade`.", "reference": "I haven't thought about this a lot yet, but if we were to try this change, we'd still need to keep the code to delete it from the `.origin` file for backcompat." }, { - "prediction": "I think this should be `import org.hyperledger.besu.crypto.SeCP256K1;`", + "prediction": "I think this should be `import org.hyperledger.besu.crypto.KeyPairSecurityModule;` instead of `import org.hyperledger.besu.crypto.KeyPairSecurityModule;import org.hyperledger.besu.crypto.NodeKey;import org.hyperledger.besu.crypto.SECP256K1;`", "reference": "In my opinion I think it is possible to add `private final` here" }, { @@ -12167,15 +12167,15 @@ "reference": "Feel like \"exit\" doesn't convey that the packet will be dropped. \"drop-and-exit\" or \"error-exit\" maybe?" }, { - "prediction": "I think this should be `if (ast_childcount(params) == 1)` instead of `if (ast_childcount(params) != 1)`.", + "prediction": "I think this should be `if (ast_childcount(params) != 0)` instead of `if (ast_childcount(params) != 1)`.", "reference": "How do you feel about \"The Main actor\" instead of \"A Main actor\", while we're already here changing the message?" }, { - "prediction": "I don't think we need to add `ZK_READ_PERM(\"zk-read\", null)` to the list.", + "prediction": "I think we should remove the `null` from `core-edit-perm` and `zk-read-perm`.", "reference": "I cannot see that this new permission is used anywhere? And if the new zk handler is covered by `zk-read`, should not also existing `ZookeeperInfoHandler` handler implement PermissionNameProvider and declare the same permission, for consistency?" }, { - "prediction": "I think this should be `isinstance(tpe, (list, np.ndarray))` instead of `isinstance(tpe, (list, np.ndarray,))`", + "prediction": "I think this should be `if hasattr(tpe, \"__origin__\") and issubclass(tpe.__origin__, list)`", "reference": "Is this reasonable?" }, { @@ -12183,15 +12183,15 @@ "reference": "We may move this TODO to Line15." }, { - "prediction": "I think it's better to use `ConfigQuery::checkAvailableStock()` instead of `ConfigQuery::checkAvailableStock()` in this case.", + "prediction": "I think we can remove the `if(true === ConfigQuery::checkAvailableStock())` line.", "reference": "You have to verify the return type. If it's a reponse, return it. Otherwise do nothing." }, { - "prediction": "I'm not sure what you mean by \"how often to loop through the K dimension with each team\". I think you meant to say \"how many times to loop through the K dimension with each team\".", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a separate file.", "reference": "No. Keep the header include and do `extern template ...` to skip the instantiation from that compile unit. (I pushed a fix directly to your branch)" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a list of all the functions that we want to test. Then we can just iterate over that list and check each one.", "reference": "these tests are currently somewhat nonsensical. This code expands to `a, b = {}.keys` when it really should be expanding to `a, b = {}.keys()` -- though fixing this causes the test to fail so I suspect something worse is going on here that I don't quite understand?" }, { @@ -12199,51 +12199,51 @@ "reference": "Why did this need to change?" }, { - "prediction": "Shouldn't this be `NewBranchTransaction`?", + "prediction": "Shouldn't this be `func NewBranchDB() *BranchDB`?", "reference": "/go/pkg/mod/golang.org/x/xerrors@v0.0.0-20190410155217-1f06c39b4373/adaptor_go1_13.go:16:21: Frame not declared by package errors (from `typecheck`)" }, { - "prediction": "I think this should be `ZkStateReader` instead of `ZkStateReaderImpl`?", + "prediction": "I think it's better to use `@ConfigurationProperties` instead of `@PropertySource` in this case.", "reference": "Probably doesn't go here because I think it's specific to the HTTP API layer. This class is too internal to declare such a name." }, { - "prediction": "I'm not sure what you mean by \"ensure we don't track health in prometheus\"", + "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to make sure that the health check is always successful.", "reference": "in preparation of directly writing the /health endpoint one day.. we should have content checks." }, { - "prediction": "I'm not sure what you mean by \"NoIDByPrefixError\" is returned by Find() when no ID for a given prefix. I think you meant \"NoIDByPrefixError\" is returned by Find() when no ID is found for a given prefix.", + "prediction": "I'm not sure what you mean by \"prefix\" in this case. I think you meant to say \"prefix\" in the error message.", "reference": "question (non-blocking): Is there a benefit from using `%q` instead of `%s`?" }, { - "prediction": "I don't think this is necessary. We can just use `std::to_string(replicaFactor)` and `std::to_string(partsNum)`.", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to get the space name from the space ID, but I'm not sure what you're trying to do with the space name.", "reference": "I would suggest to keep two empty lines between functions in cpp files" }, { - "prediction": "I'm not sure what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not", + "prediction": "I'm not sure what you mean by \"sending a marker to to null stream may synchronize the otherStream\". I think you meant to say \"sending a marker to the otherStream may synchronize the otherStream\".", "reference": "This change causes the test to fail on both rocm-1.9.x and rocm-head." }, { - "prediction": "I think this should be `Class` instead of `Class`.", + "prediction": "Shouldn't this be `Class` instead of `Class`?", "reference": "I'd consider moving all fix related stuff to a distinct package to avoid contaminating the base package" }, { - "prediction": "I think we should remove the `action.original_command` and `action.analyzer_options` from the `parse_compile_commands_json` function. The `action.original_command` should be the original command, and the `action.analyzer_options` should be the options passed to the original command. The `action.lang` and `action.target` should be the same as the original command.", + "prediction": "I think this should be `action.analyzer_options = compile_opts` instead of `action.analyzer_options = compile_opts[i] = '-I' + os.path.join(entry['directory'], inc_dir)`", "reference": "Use `os.path.join` for path concatenation." }, { - "prediction": "`CornerHead` and `PISARetinaHead` should be in the same package.", + "prediction": "`CornerHead` and `PISARetinaHead` are deprecated.", "reference": "Use upper case: YOLACTHead, YOLACTProtonet, YOLACTSegmHead" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a new crypter with a different key ID than the one used in the original crypter. Is that correct? If so, how do you plan to use this new crypter?", + "prediction": "I don't think we need to change the `keyID` here. We can just use the `projectID` and `location` directly.", "reference": "The driver tests should be updated to use the concrete type instead of the driver directly; right now your test coverage of the concrete type is 0%." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `MethodTree` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check here to make sure that the type is valid before trying to parse it.", "reference": "I would prefer the message to be more actionable. Like 'There should be no space between & and the variable name' or something similar." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `getChildren()` method to `AntlrBaseNode` that returns a `List` instead of a `List`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a method that returns a `Node` that can be used in the `jjtGetChild` method. This way, we don't have to check if the child is a `Node` every time we call `jjtGetChild`, and we don't have to check if the child is a `Node` every time we call `jjtGetChild` in the `jjtGetChild` method.", "reference": "The image attribute is not supposed to be the text of the node. I'd rather keep it separate (the previous `@Text` attribute was fine). A practical reason for that is in the future, other languages may have a way to get the text of their node, in which case that wouldn't be fetched with `getImage`, for compatibility, but probably with a `getText` method, or `getSourceCode` like in #1728. Also we *may* deprecate or otherwise put `getImage` out of use as soon as 7.0, given its contract is super loose." }, { @@ -12251,23 +12251,23 @@ "reference": "The `[] +` seems weird to me. Why is it there?" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you're trying to do here.", "reference": "Not sure if this constant is defined at the right place style-wise. Maybe move it up to before 'belongs_to' like DISCOUNT_TYPES in coupon.rb?" }, { - "prediction": "I think we can remove the `bufio.NewReaderSize` and just use `reader` instead.", + "prediction": "I think we can remove the `reader` and just use `in` instead.", "reference": "What about a line with just spaces/tabs? Or a line with a couple spaces followed by a `#`?" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `Template` model.", "reference": "if funder_is is not blank (L375) there is not need to check if org_id is not blank (L379) since you will never enter in the if (L374)." }, { - "prediction": "I think this should be `if (GetTarget() == this) {` instead of `if (GetTarget() == this) { this->MessageString(Chat::TooFarAway, TRY_ATTACKING_SOMEONE); auto_fire = false; return; }`", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea.", "reference": "Don't need this-> here." }, { - "prediction": "I think we can remove the `from google.auth.compute_engine._metadata import _metadata` line.", + "prediction": "I think this should be `from google.cloud.forseti.common.util import _metadata` instead of `from google.auth.compute_engine import _metadata`", "reference": "I'm a little concerned about relying on a private module, as they could change the implementation at some point, I'd like to have some test to validate this is working as intended." }, { @@ -12275,23 +12275,23 @@ "reference": "There might other values that we don't support here (eg. `[]`). So it might be safer to check for the supported types instead (string or number)." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `prepareFrom` function.", + "prediction": "I think this should be `if (expr->isFunCallExpression())` instead of `if (*(funcExpr->name()) == \"near\")`", "reference": "FYI, It won't have any benefit to move from trivial types." }, { - "prediction": "I'm not sure what you mean by \"secrets-ssm-environment-variables\"", + "prediction": "I'm not sure what you mean by \"secrets-ssm-environment-variables\". I think it should be `secrets-ssm-environment-variables` instead.", "reference": "i missed these discussions- but ` \"secrets-ssm-environment-variables\"` is what was agreed upon with cp?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure it's a good idea.", + "prediction": "I think we can remove the `github.com/lyft/clutch/backend/middleware/timeouts` dependency.", "reference": "whats the difference between this package and `github.com/golang/protobuf` ? or did vscode just decided this was the package it wanted to used?" }, { - "prediction": "I don't think this is a good idea. It's not a good idea to create a new instance of `AddRepositoryDialog` every time the user clicks on the button.", + "prediction": "I don't think this is necessary.", "reference": "Just asking: What does this line do? Does it add the stylesheet from the parent to the dialog?" }, { - "prediction": "I think we should remove `scikit-learn<1.0.0` as it is not supported anymore.", + "prediction": "I'm not sure if this is necessary, but I think it's better to use `pytest-xdist==2.1.0` and `responses==0.10.*` instead of `pytest-xdist==2.1.0` and `responses==0.10.*` and `scikit-learn<1.0.0` and `snapshottest==0.6.0` and `tox==3.14.2` and `tox-pip-version==0.0.7`.", "reference": "Including the scikit-learn dependency here would pull in scikit-learn for everyone who depends on Dagster. If you put it in the setup.py under docs_snippets, we'd avoid that problem (although I think it's already there)." }, { @@ -12299,11 +12299,11 @@ "reference": "Why remove this?" }, { - "prediction": "I'm not sure what you mean by \"Regression test for issue #1722\"", + "prediction": "I'm not sure I understand what you're trying to do here. Is this a regression test for #1722? If so, I'm not sure I understand what you're trying to do here. Is this a regression test for #1722? If so, I'm not sure I understand what you're trying to do here. Is this a regression test for #1722? If so, I'm not sure I understand what you're trying to do here. Is this a regression test for #1722? If so, I'm not sure I understand what you're trying to do here. Is this a regression test for #1722? If so, I'm not sure I understand what you're trying to do here. Is this a regression test for #1722? If so, I'm not sure I understand what you're trying to do here. Is this a regression test for #1722? If so, I'm not sure I understand what you're trying to do here. Is this a regression test for #1722? If so, I'm not sure I understand what you're trying to do here. Is this a regression test for #172", "reference": "Why remove this? It seems like we should keep this around as a regression test, unless we can guarantee this will never be called without a model set (does your new code guarantee that?)" }, { - "prediction": "I'm not sure what you mean by `global._googlesitekitUserData?.permissions || {}`. It seems like you're trying to get the `permissions` object from `global._googlesitekitUserData`, but you're not actually using it.", + "prediction": "I don't think we need to do this.", "reference": "Because this defaults to `{}` if `global._googlesitekitUserData?.permissions` is `false`-y, the checks below around `state.capabilities` always result in the `!! capabilities === true` path. This shouldn't have a default value of `{}` if there's the possibility that `global._googlesitekitUserData?.permissions` can be `undefined`/`false`/`null` legitimately." }, { @@ -12319,15 +12319,15 @@ "reference": "We don't need this file, we can use the one that is in the grid-ui directory" }, { - "prediction": "I think it's better to use `errorNameAlreadyTaken` instead of `infoNoAccounts`.", + "prediction": "I think we should use `errorNameAlreadyTaken` instead of `errorNameTaken` for consistency.", "reference": "\"Exported key for account\"?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `L10N` attribute on the `CRLF` constant.", + "prediction": "I don't think this is a good idea.", "reference": "Normally we use Environment.NewLine unless you really want it to always be \\r\\n" }, { - "prediction": "I'm not sure what you mean by \"always returning an error for any uncles as this consensus mechanism doesn't permit uncles.\"", + "prediction": "I'm not sure I understand what you're trying to do here.", "reference": "why did you remove `verifyHeaders`?" }, { @@ -12343,23 +12343,23 @@ "reference": "We support process remoteQuery for Service. Why are we removing it ?" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to disable the error page generation in Sinatra. I'm not sure what you're trying to achieve with this, but it looks like you're trying to disable the error page generation in Sinatra. I'm not sure what you're trying to achieve with this, but it looks like you're trying to disable the error page generation in Sinatra. I'm not sure what you're trying to achieve with this, but it looks like you're trying to disable the error page generation in Sinatra. I'm not sure what you're trying to achieve with this, but it looks like you're trying to disable the error page generation in Sinatra. I'm not sure what you're trying to achieve with this, but it looks like you're trying to disable the error page generation in Sinatra. I'm not sure what you're trying to achieve with this, but it looks like you're trying to disable the error page generation in Sinatra. I'm not sure what you're trying to achieve with this, but it looks like you're trying to disable the error page generation in Sinatra. I'm not sure what you're trying to achieve with this, but it looks like you're trying to disable the error", + "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to disable Sinatra's error page generation by setting `set :show_exceptions, false` in your `config/environments/production.rb` file. Is this what you're trying to do?", "reference": "This is specifically for testing?" }, { - "prediction": "I'm not sure if this is the right place to do this.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in a separate file.", "reference": "I think this is related to the social stats and probably does not need to be removed." }, { - "prediction": "I'm not sure what you're trying to achieve with this plugin, but I think it's a good idea to add a `description` property to the plugin so that it's easier to understand what it does.", + "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea.", "reference": "Yep, jsdoc again .. It seems that when the plugin description is wrapped within `eslint-disable/enable` expression it's not generated at all. After adding the `@class AutoColumnSize` tag right after the `@plugin` tag the plugin appears in the docs. Please review the other plugins." }, { - "prediction": "I think we can remove the `if len(values) == 0` check here.", + "prediction": "I think we can remove the `if len(values) == 0` check.", "reference": "This usage of the result doesn't look quite right. I would not expect the first page of values to be empty if there were multiple pages of results. This also obscures the error case when no values are returned (handled in the next `if` block) by returning a more generic error from the Azure SDK from `result.NextWithContext()`." }, { - "prediction": "I think this should be `if exe, err := exp.GetAddressDetails(hashStr); err == nil {`", + "prediction": "I think it's better to return `explorer.GetBlkOrActResponse{AddressDetails: &exe}` instead of `explorer.GetBlkOrActResponse{Execution: &exe}`.", "reference": "unknown field AddressDetails in struct literal (from `typecheck`)" }, { @@ -12367,23 +12367,23 @@ "reference": "Just noticed, are we specifically missing the addition of `SharedConfigState: session.SharedConfigEnable` ?" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get the index of the nearest time point to the current time. I think you want to get the index of the nearest time point to the current time, not the index of the nearest time point to the previous time point.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `oldTimeIntensities == null` to make sure we don't try to access a null value.", "reference": "Not sure what this is. Bad merge?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to check if the account claims are the same as the one we're trying to update. If they are the same, we can just return an error. If they are different, we need to update the account claims and return an error.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to check if the account claims are the same as the one we're trying to update. If they are, we can just return an error. If they are not, we can update the account claims and then return an error.", "reference": "I think this may be a RW lock." }, { - "prediction": "I don't think this is necessary. I think we can just use `bytes.NewBuffer` instead.", + "prediction": "I don't think we need to change the package name here.", "reference": "Perhaps we should tuck this away into a dedicated subdir and name it `config` or something similar? Or maybe it would be happy living in `common`?" }, { - "prediction": "I'm not sure what you're trying to do here, but I'm not sure if this is the right way to do it.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to check if we need to learn it before sending them the recipe..", "reference": "Doing a select query inside of a loop like this is not ideal. We should fetch recipes once and then loop through it in memory to perform this check" }, { - "prediction": "I think this should be `result = np.asarray(self.to_pandas()._values, dtype=dtype)` instead of `result = np.asarray(self.to_pandas()._values, dtype=dtype)`", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `copy=True` here. It's not clear to me why you'd want to use `copy=False` here.", "reference": "too long here. (104 > 100)" }, { @@ -12391,11 +12391,11 @@ "reference": "Use TryGetValue instead of catching exception" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a test for this scenario as well.", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it would be a good place to put it. I'm not sure if this is a good place to put this, but I think it would be a good place to put it. I'm not sure if this is a good place to put this, but I think it would be a good place to put it. I'm not sure if this is a good place to put this, but I think it would be a good place to put it. I'm not sure if this is a good place to put this, but I think it would be a good place to put it. I'm not sure if this is a good place to put this, but I think it would be a good place to put it. I'm not sure if this is a good place to put this, but I think it would be a good place to put it. I'm not sure if this is a good place to put this, but I think it would be a good place to put it. I'm not sure if this is a good place to put this, but I think it would be a good place to put it. I'm not sure if this is a good place to put this", + "prediction": "I think this should be `static_cast(num_locators);` instead of `static_cast(change);`", "reference": "I think this method should be either: - a static method of `RTPSWriter` to avoid a StatelessWriter redefinition of the function. - a setter in the `CacheChange_t` struct." }, { @@ -12403,7 +12403,7 @@ "reference": "You add a stream back reference for trailers, and all of the sudden we have tight coupling!" }, { - "prediction": "I'm not sure what you're trying to achieve with this code. It looks like you're trying to add a new extension method to the `Trace` class, but I'm not sure what you're trying to achieve with this code. Can you please provide more context or explain what you're trying to achieve with this code?", + "prediction": "I think this should be `using System.Collections.Concurrent;` instead of `using System.Collections.Generic;`", "reference": "I don't think we use `AspNetAmbientContext` anymore since . We can probably delete this file." }, { @@ -12411,7 +12411,7 @@ "reference": "Please avoid committing build artifacts, as they produce unnecessary conflicts and noise." }, { - "prediction": "I think this should be `if hasattr(x, \"__call__\")` instead of `if name in self.__unwrap_methods`", + "prediction": "I think this should be `if hasattr(x, \"__call__\")` instead of `if hasattr(x, \"__call__\"):`.", "reference": "this is vendored code so i would hesitate to make random changes to it" }, { @@ -12419,7 +12419,7 @@ "reference": "We are using a different style for JSON tags. `ethAddress` - camalCase `referral_code` - snake_case" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the `HttpContext` from the request context. I think you're trying to get the `HttpContext` from the `Request` object, but I'm not sure what you're trying to achieve with this. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the `HttpContext` from the `Request` object, but I'm not sure what you're trying to achieve with this. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the `HttpContext` from the `Request` object, but I'm not sure what you're trying to achieve with this. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the `HttpContext` from the `Request` object, but I'm not sure what you're trying to achieve with this. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the `HttpContext` from the `Request` object, but I'm not sure what you're trying to achieve with this. I'm not sure what", + "prediction": "I'm not sure if this is the right place to put this, but I think it would be a good idea to make this a part of the class.", "reference": "Should this be `\"Microsoft.AspNetCore.Http.DefaultHttpContext\"`?" }, { @@ -12427,15 +12427,15 @@ "reference": "removed asserts from `Vector` as it's stable enough and it may hinder inlining, even if turned off :/" }, { - "prediction": "I'm not sure if this is a good idea, but I think it would be a good idea to add a `get_message_definitions` method to the `MessageDefinitionStore` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `get_message_definitions` method to the `MessageDefinitionStore` class. This way, we don't have to call `get_message_definitions` every time we want to get a message definition.", "reference": "Do we want to raise on the function or on the decorator?" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get the `recording_msid` and `album_msid` from the `track_metadata` object. I'm not sure what you're trying to do here, but it looks like you're trying to get the `recording_msid` and `album_msid` from the `track_metadata` object. I'm not sure what you're trying to do here, but it looks like you're trying to get the `recording_msid` and `album_msid` from the `track_metadata` object. I'm not sure what you're trying to do here, but it looks like you're trying to get the `recording_msid` and `album_msid` from the `track_metadata` object. I'm not sure what you're trying to do here, but it looks like you're trying to get the `recording_msid` and `album_msid` from the `track_metadata` object. I'm not sure what you're trying to do here, but it looks like you're trying to get the `recording_msid` and `album_msid` from the `track_metadata` object. I'm not sure", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `TrackMetadata` class.", "reference": "How complex is to to replace `album_*` with `release_*` everywhere in the `Listen` class and places that use it?" }, { - "prediction": "I'm not sure what you're trying to do with this, but it looks like you're trying to add a namespace to the list of namespaces in the current namespace. I'm not sure what you're trying to do with this, but it looks like you're trying to add a namespace to the list of namespaces in the current namespace. I'm not sure what you're trying to do with this, but it looks like you're trying to add a namespace to the list of namespaces in the current namespace. I'm not sure what you're trying to do with this, but it looks like you're trying to add a namespace to the list of namespaces in the current namespace. I'm not sure what you're trying to do with this, but it looks like you're trying to add a namespace to the list of namespaces in the current namespace. I'm not sure what you're trying to do with this, but it looks like you're trying to add a namespace to the list of namespaces in the current namespace. I'm not sure what you're trying to do with this, but it looks like you're trying to add a namespace to the list of namespaces in the current namespace. I'm not sure what you're trying to do with this, but it looks like you", + "prediction": "I'm not sure if this is the best way to do this, but it seems to work for me.", "reference": "You haven't changed any of the callers of `.Add` to check the return value, so we're now ignoring duplicates. Please fix that." }, { @@ -12443,27 +12443,27 @@ "reference": "@straker should this not push to `vnode._cache.isHiddenWithCSS`?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add a comment to explain the purpose of this change.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's unnecessary.", "reference": "\"an interface\" in conceptual sense vs \"interfaces\" or \"set of interfaces\", referring to the Go interfaces - database/sql uses the latter, should we?" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to move it to the `DownloadService` class, since it's not part of the `Service` class.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `DownloadService` class.", "reference": "This now checks nearly all errors that can occur. How about explicitly listing cases where we want it to retry? I think there are not many cases where we want that, as the many added conditions in the last years show :)" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you're trying to do with this, but I think it's a bad idea to use `doSync` here.", "reference": "Can you make this accept an action instead?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a video download product and then create a screenshot of that product. But I'm not sure what you're trying to do here. I think you're trying to create a video download product and then create a screenshot of that product. But I'm not sure what you're trying to do here. I think you're trying to create a video download product and then create a screenshot of that product. But I'm not sure what you're trying to do here. I think you're trying to create a video download product and then create a screenshot of that product. But I'm not sure what you're trying to do here. I think you're trying to create a video download product and then create a screenshot of that product. But I'm not sure what you're trying to do here. I think you're trying to create a video download product and then create a screenshot of that product. But I'm not sure what you're trying to do here. I think you're trying to create a video download product and then create a screenshot of that product. But I'm not sure what you're trying to do here. I think you're trying to create a video download product and then", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a video download product and then create a screenshot of that product. Is that what you're trying to do? I'm not sure what you're trying to do here. I think you're trying to create a video download product and then create a screenshot of that product. Is that what you're trying to do? I'm not sure what you're trying to do here. I think you're trying to create a video download product and then create a screenshot of that product. Is that what you're trying to do? I'm not sure what you're trying to do here. I think you're trying to create a video download product and then create a screenshot of that product. Is that what you're trying to do? I'm not sure what you're trying to do here. I think you're trying to create a video download product and then create a screenshot of that product. Is that what you're trying to do? I'm not sure what you're trying to do here. I think you're trying to create a video download product and then create a screenshot of that product. Is that what you're trying to do? I'm not sure what you're trying to do", "reference": "Tab inconsistency here (3 spaces instead of 2 spaces)" }, { - "prediction": "I think we can remove `InitBalanceStr` and `EpochRewardStr` and just use `FoundationBonusStr` and `FoundationBonusLastEpoch`.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `InitBalanceStr` and `EpochRewardStr` for the `InitBalance` and `EpochReward` fields. This way, the `InitBalance` and `EpochReward` fields will always have the same value, regardless of the `InitBalanceStr` and `EpochRewardStr` values.", "reference": "these change means we are changing epoch to 1 hour?" }, { - "prediction": "I'm not sure what you mean by \"ensure self.scaleSize is used to adjust for OS scaling adjustments.\" Is that a typo? I'm not sure what you mean by \"self.scaleSize is used to adjust for OS scaling adjustments.\" Is that a typo? I'm not sure what you mean by \"self.scaleSize is used to adjust for OS scaling adjustments.\" Is that a typo? I'm not sure what you mean by \"self.scaleSize is used to adjust for OS scaling adjustments.\" Is that a typo? I'm not sure what you mean by \"self.scaleSize is used to adjust for OS scaling adjustments.\" Is that a typo? I'm not sure what you mean by \"self.scaleSize is used to adjust for OS scaling adjustments.\" Is that a typo? I'm not sure what you mean by \"self.scaleSize is used to adjust for OS scaling adjustments.\" Is that a typo? I'm not sure what you mean by \"self.scaleSize is used to adjust for OS scaling adjustments.\" Is that a typo? I'm not sure what you mean by \"self.scaleSize is used to adjust for OS scaling adjustments.\" Is that a typo? I'm not sure what you mean by \"self.scaleSize is used to adjust for OS scaling adjustments.\"", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `self.scaleSize` to adjust for OS scaling adjustments.", "reference": "Why this is defined in the middle of imports?" }, { @@ -12471,7 +12471,7 @@ "reference": "Could you move this to the original position?" }, { - "prediction": "I'm not sure what you mean by \"owner\" in this context. Is it the owner of the repository, or the owner of the pipeline?", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. It's a bit of a hack, but I think it's the best way to do it.", "reference": "Is there a test that'd have caught this?" }, { @@ -12479,23 +12479,23 @@ "reference": "ListWorkflowExecutionsRequest <- this can be nil?" }, { - "prediction": "I'm not sure what you're trying to achieve with this. It's not clear to me what you're trying to do with `forgeapi.puppetlabs.com` and `forge.puppetlabs.com`. Could you please provide more context?", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to make this a class method, so that we don't have to call it every time we want to stub a host.", "reference": "Do we need to continue to support the old link, or is it dead dead dead?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the `GlobalTags` and `HeaderTags` are not null before using them.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good place to do this, since we're using the `GetDictionary` method to populate the `HeaderTags` dictionary.", "reference": "Do we need `ConcurrentDictionary`? `Dictionary` can be safely read from multiple threads. See `GlobalTags`." }, { - "prediction": "I think it's better to use `aws.String` here instead of `aws.String(config.OSType)`.", + "prediction": "I think it's better to use `aws.String()` instead of `config.OSType` here.", "reference": "this seems like more of a Debugf statement" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `validate_concurrent_barrier_at_submit` function so that it can be called from the `validate_concurrent_barrier_at_submit` function as well.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would make sense to move it to the `validate_concurrent_barrier_at_submit` function.", "reference": "We're capturing cb_state non-const, but the function is const so, safe enough, but after going to reader/writer locks we're all going to have to key a careful eye on anything in this pattern." }, { - "prediction": "I'm not sure what you mean by \"skip endpoint discovery workflow\". Is it that we don't want to do endpoint discovery for this test case?", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have the endpoint cache in the `discovererDescribeEndpoints` struct. This way, we don't need to call `discovererDescribeEndpoints` every time we run the test.", "reference": "Probably want to wrap the endpoint discovery work that follows in this `if` statement instead of returning early. This will make it easier to add additional request code generation logic in the future. e.g. if we add any code generation after the endpoint discovery block this check will cause it to be skipped." }, { @@ -12503,11 +12503,11 @@ "reference": "This test was giving a false positive because my change caused it to throw a different error that contained `createElement` when it should've been throwing this error. Caught this by looking at the code coverage and noticing that the line under the condition I changed was no longer covered lol." }, { - "prediction": "I'm not sure what you mean by \"registerServiceforOS\"", + "prediction": "I'm not sure if this is a good idea, but I think it's better to have a separate function for this.", "reference": "I think this is added to wrong file. You wanted to add to cmd/agent/, right?" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to add a check that the element is not null.", + "prediction": "I don't think we need to use `StaleElementReferenceException` here. We can just use `NoSuchElementException` instead.", "reference": "Each `ExpectedCondition` implements `java.util.Function` These are expected to be stateless. This condition will leak previous `elementText` on the second usage, which doesn't seem ideal." }, { @@ -12519,91 +12519,91 @@ "reference": "Why change this from a foreach? I can't see it gaining anything here and code styles shouldn't change just for the sake of it." }, { - "prediction": "I think this should be `simplexml_load_string($response->getRawResponse());`", + "prediction": "I think this should be `simplexml_load_string($response->getRawResponse());` instead of `simplexml_load_file($solrconfigXmlUrl);`", "reference": "Is this supposed to be part of this PR?" }, { - "prediction": "I don't think this is needed.", + "prediction": "I don't think we need to change `getIsHidden` to `isHidden` here.", "reference": "DRY, worth extracting this method to axe.utils" }, { - "prediction": "I think this should be `ACCEPT_SSL_CERTS` instead of `acceptSslCerts`.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `CapabilityType` interface.", "reference": "I think there's another spot for this in DefaultCapabilityMatcher" }, { - "prediction": "I think this should be `with qtutils.savefile_open(self._configfile, encoding='utf-8') as f:` instead of `with qtutils.savefile_open(self._configfile, encoding='utf-8') as f:`", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `qtutils.savefile_open` instead of `open`.", "reference": "`QtOSError` inherits `OSError`, so I don't think it's needed to list them both here." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to change the type of `m.Data` from `[]byte` to `[]interface{}`.", + "prediction": "I don't think we need to do this.", "reference": "Instead of patching vendor, let's update the version of sdk-go to a more recent one that doesn't have this line." }, { - "prediction": "I think we can remove the `Parse.BuildFileName` since it's not used anymore.", + "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea to add it to the config.", "reference": "Don't think this should be here. The default is set somewhere else." }, { - "prediction": "I think it's a good idea to remove the `if not self._last_status:` line.", + "prediction": "I think it's better to use `if not self._last_status:` instead of `if not self._last_status:`", "reference": "Not really important in this PR, but does BlazeMeter describe \"progress\" values anywhere? It might be nice to have a set of constants like `PROGRESS_DOWNLOADING_IMAGE`, `PROGRESS_BOOTING`, `PROGRESS_RUNNING_TEST`, etc in our BZA client." }, { - "prediction": "I'm not sure I understand what you mean by \"more efficiently when they share the same sort order id\".", + "prediction": "I don't think this is needed.", "reference": "nit: `

    ` after the line" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's better to have a separate directory for each of these files.", + "prediction": "I'm not sure if this is a good idea or not, but I think it would be better to have a separate list of all the files that need to be installed. This way, we don't have to worry about the order in which the files are installed, and we don't have to worry about the order in which the files are installed.", "reference": "Should we include the files with otf extension here, too? If not, I wonder why we do allow them in the source but we don't include them as per the setup" }, { - "prediction": "I don't think we need to use `map[hash.Hash256]bool` here. We can just use `map[hash.Hash256]bool` directly.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `map[hash.Hash256]bool` here.", "reference": "i think it's OK to leave this?" }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. Is this for a specific use case? If so, please provide more context.", + "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. Is this for a specific use case? If so, what is it? If not, why do you think this is a bad idea?", "reference": "Does this need to be public? The only reference to `FlinkTypeVisitor` that I see in this PR is here, so I'm not sure why this is needed." }, { - "prediction": "I don't think this is a good idea. It would be better to have a separate dialog for exiting NVDA.", + "prediction": "I don't think it's necessary to have the `Alt plus d` in the `Quit dialog` text.", "reference": "No line at end of file warning" }, { - "prediction": "I don't think this is necessary. The `BlockTracerFactory` is not used anywhere in this class.", + "prediction": "I don't think this is needed. The `BlockTracerFactory` is already defined in the `OneTimeChainProcessor` class.", "reference": "This looks unused, shouldn't it point to inner processor in any way?" }, { - "prediction": "I think this should be `if (child(0)->castToRelExpr()->getOperatorType() == REL_FIRST_N)` instead of `if ((child(0)->castToRelExpr()->getOperatorType() == REL_FIRST_N) && (child(0)->child(0)))`", + "prediction": "I think this should be `if (child(0)->castToRelExpr()->getOperatorType() == REL_FIRST_N)`", "reference": "There may be a few isolated cases where the FirstN node is added during preCodeGen. Please see GenPreCode.cpp RelRoot::preCodeGen(). The example given there about Order by where sort is added in optimizer, or a FirstN where the N value is to be specified with a param seem to be cases where we would add the FirstN later. Will current change cause such views to marked as updateable? This is minor and could be resolved later, if any change is necessary." }, { - "prediction": "I think we can remove the `getGrpcClientTypeName` method, as it's not needed anymore.", + "prediction": "I think we can remove the `getGrpcClientTypeName` method and replace it with the `getGrpcClientTypeName` method in the `GrpcClient` class.", "reference": "I think you should compose the %sClient part using the Name class, and then do the remaining composition with plain concatenation. Side question: why does the return type name look like it is a client type name?" }, { - "prediction": "I think we should remove the `padding: 0` from the `WithTestRegistry` component.", + "prediction": "I think we can remove the `freezeFetch` call here.", "reference": "All stories in this file also need the default padding." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate test for this.", + "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to test here. If you want to test that PrometheusExporterMiddleware works, you should test it in the `PrometheusExporterMiddlewareTests.cs` file.", "reference": "Curious - what would be the actual value?" }, { - "prediction": "I don't think it's necessary to add `CLASSES` to `model.CLASSES` in this case. We can just use `datasets[0].CLASSES` instead.", + "prediction": "I don't think it's necessary to add `CLASSES` to the `meta` dictionary, since it's already defined in `datasets[0].CLASSES`", "reference": "Is it necessary to record the palette in the checkpoint? Any reason?" }, { - "prediction": "I don't think we need to use `socketio` here. We can just use `listenbrainz.webserver.views.api_tools.FollowDispatcher` directly.", + "prediction": "I don't think we need to use `socketio` here. We can just use `pika` here.", "reference": "Not sure how to best do this without creating a new connection to the server everytime. Do this in another thread?" }, { - "prediction": "I'm not sure what you're trying to do here. It's not clear what you're trying to do with the `organization` method.", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to test that the `organization` method returns the correct value. But I don't think that's what you're trying to test here.", "reference": "should we have a similar test for gsa18f procurements?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you want to make sure that the sender and the recipient are the same, but I'm not sure what you're trying to do here. I think you want to make sure that the sender and the recipient are the same, but I'm not sure what you're trying to do here. I think you want to make sure that the sender and the recipient are the same, but I'm not sure what you're trying to do here. I think you want to make sure that the sender and the recipient are the same, but I'm not sure what you're trying to do here. I think you want to make sure that the sender and the recipient are the same, but I'm not sure what you're trying to do here. I think you want to make sure that the sender and the recipient are the same, but I'm not sure what you're trying to do here. I think you want to make sure that the sender and the recipient are the same, but I'm not sure what you're trying to do here. I think you want to make sure that the sender and the recipient are the same, but I'm not sure what you're trying to do here. I think you want", + "prediction": "I'm not sure what you're trying to achieve with this test, but I think it's a bit misleading. The `accountutil.AccountStateByHash160` function returns an `accountutil.AccountStateByHash160` struct, which is a pointer to an `accountutil.AccountState` struct. The `accountutil.AccountState` struct is a pointer to an `accountutil.AccountState` struct, which is a pointer to an `accountutil.AccountState` struct. The `accountutil.AccountState` struct is a pointer to an `accountutil.AccountState` struct, which is a pointer to an `accountutil.AccountState` struct. The `accountutil.AccountState` struct is a pointer to an `accountutil.AccountState` struct, which is a pointer to an `accountutil.AccountState` struct. The `accountutil.AccountState` struct is a pointer to an `accountutil.AccountState` struct, which is a pointer to an `accountutil.AccountState` struct. The `accountutil.AccountState` struct is a pointer to an `accountutil.AccountState` struct, which is a pointer to an `accountutil.AccountState` struct. The `accountutil.AccountState` struct is a pointer to an `accountutil", "reference": "change `v.recipient` to address.Address, so can use `AccountState(v,recipient)`" }, { - "prediction": "I think this should be `order('position DESC')` instead of `order('position ASC')`.", + "prediction": "I think this should be `approval.cart_approvals.approved.order('position ASC').last == approval`", "reference": "Open to doing away with this altogether and maybe injecting this logic somehow into `requires_approval_notice?` in LinearDispatcher." }, { @@ -12611,15 +12611,15 @@ "reference": "remove this and always enable tracer, just set the default timeout to something higher (20 seconds)" }, { - "prediction": "I don't think this is needed. The `requiresPatch` field should be optional.", + "prediction": "I don't think this is needed. The `requiresPatch` and `free` fields should be optional.", "reference": "Can we give this field a more descriptive name? When I use a variable named `icon` I normally expect an `Image` object." }, { - "prediction": "I'm not sure what you're trying to achieve with this command. It seems like you're trying to filter targets based on labels, but I'm not sure what you're trying to achieve with this command. Could you please provide more context or clarify your requirements?", + "prediction": "I'm not sure what you mean by \"include labels\" and \"exclude labels\". I think you meant \"include targets\" and \"exclude targets\".", "reference": "can't these just use the global `include` and `exclude` flags?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.", + "prediction": "I don't think this is a good idea. The `rois` is a tensor of shape `(batch_size, num_rois, 4)`, and the `deltas` is a tensor of shape `(batch_size, num_rois, 4)`. I think it would be better to have `rois` and `deltas` have the same shape.", "reference": "Is this still necessary?" }, { @@ -12627,23 +12627,23 @@ "reference": "Interesting! Happen to catch an exception message or anything I can look into?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to add a listener to both `err` and `complete` at the same time. If you want to add a listener to both `err` and `complete` at the same time, you can do it like this:\n\n```js\npromise.addBack(function (err, args...) {\n if (err) return handleError(err);\n this.on('error', handleError);\n this.on('complete', handleError);\n});\n```\n\nThis way, you only add a listener to `err` and `complete` at the same time, and you don't have to worry about adding a listener to both at the same time.", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to add a function as a listener to both `err` and `complete`. I think you're trying to do something like this:\n\n```js\npromise.addBack(function (err, args...) {\n if (err) return handleError(err);\n if (complete) {\n complete.apply(this, args);\n }\n});\n```\n\nBut I'm not sure what you're trying to do here, but it looks like you're trying to add a function as a listener to both `err` and `complete`. I think you're trying to do something like this:\n\n```js\npromise.addBack(function (err, args...) {\n if (err) return handleError(err);\n if (complete) {\n complete.apply(this, args);\n }\n});\n```\n\nBut I'm not sure what you're trying to do here, but it looks like you're trying to add a function as a listener to both `err` and `complete`. I think you're trying to do something like this:\n\n```js\npromise.addBack(function (err, args...) {\n if (err) return handleError(err);\n if (complete) {\n complete.apply(this, args);\n ", "reference": "did this get moved to mpromise? I don't recall if it's in that lib or not." }, { - "prediction": "I don't think it's necessary to have `LocalPort` and `RemotePort` in the `ServiceConfig` struct.", + "prediction": "I don't think it's necessary to have `LocalPort` and `RemotePort` for NAT hole punching.", "reference": "json objects should be `camelCase`" }, { - "prediction": "I think this should be `TwoHundredFiftySixMiBSectorSize` instead of `TwoHundredFiftySixMiBSectorSize`", + "prediction": "I think this should be `TwoHundredFiftySixMiBSectorSize` instead of `TWO_HUNDRED_FIFTY_SIX_MiBSectorSize`", "reference": "QuarterGiBSectorSize? SectorSize265MiB? Spelling out 256 seems overly verbose." }, { - "prediction": "I don't think we need to use `using System.Linq;` in this case.", + "prediction": "I don't think we need to use `using System.Linq;` here.", "reference": "Maybe with this change we can remove `using OpenTelemetry.Logs`." }, { - "prediction": "I think we can remove the `if id == \"\"` check.", + "prediction": "I don't think we need to check for `sharedSSOName` and `ViewerRoleAsDefault` here. We can just check for `sharedSSOName == \"\"` and `ViewerRoleAsDefault == \"on\"`.", "reference": "Fix this name too." }, { @@ -12651,7 +12651,7 @@ "reference": "why this is an issue?" }, { - "prediction": "I think it's a good idea to add a `static` flag to the `allow_self` field.", + "prediction": "I think this should be `bool $allow_self = true` instead of `bool $allow_self = false`.", "reference": "The condition should be inverse?" }, { @@ -12659,7 +12659,7 @@ "reference": "this seems to be a property key name, so should it be a inside configurationkey.java?" }, { - "prediction": "I'm not sure what you mean by \"execute command here\". Is this the same as `exec.Command(bin.BASH, \"-c\", v.Command).CombinedOutput()`? If so, why do you need to call `exec.Command(bin.BASH, \"-c\", v.Command).CombinedOutput()`?", + "prediction": "I don't think we need to use `exec.Command` here. We can just use `exec.Command(\"zfs\", \"-c\", v.Command)`.", "reference": "G204: Subprocess launching should be audited (from `gosec`)" }, { @@ -12683,15 +12683,15 @@ "reference": "I'm halfway tempted to disable this for all https connections. Do you know of any clients that actually renegotiate for any reason?" }, { - "prediction": "I'm not sure what you mean by \"at least one element visible\". Is it possible to have more than one element on the page?", + "prediction": "I think it's better to use `__call__` here.", "reference": "shouldn't **call** return a boolean?" }, { - "prediction": "I think it's better to use `import _ \"gocloud.dev/docstore/awsdynamodb\"` instead of `PRAGMA(gocloud.dev): Package this example for gocloud.dev.`", + "prediction": "I think it's better to use `import \"gocloud.dev/docstore/awsdynamodb\"` instead of `import _ \"gocloud.dev/docstore/awsdynamodb\"`.", "reference": "I don't think you need the blank import here. This one uses awsdynamodb directly." }, { - "prediction": "I think we can remove the `Maps.newHashMap()` and `Multimaps.newMultimap(Maps.newHashMap(), Lists::newArrayList)` calls.", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a predicate that will only match records that are in the delete set. If that's the case, you should be able to use `isInDeleteSets` instead of `isDeleted` in the `buildEqDeletePredicate` method.", "reference": "I think this should be initialized to `null` instead of a predicate. There is no need to run an extra predicate (with an extra method dispatch for each row in a data file. That's a tight loop so we should do more work here to avoid it. Instead of using `isDeleted.or`, this should test whether `isDeleted` is `null` and either initialize `isDeleted` or call `isDeleted.or`." }, { @@ -12699,7 +12699,7 @@ "reference": "What is this and the next entry in config_handler used for?" }, { - "prediction": "I think we can remove the `NewEmpty` function as it's not needed anymore.", + "prediction": "I think this is a good idea, but I don't think it's necessary to have a `NewEmpty` function.", "reference": "will your editor integrate `gofmt`, `goimports`, etc...?" }, { @@ -12707,15 +12707,15 @@ "reference": "looks like the code is not properly formatted. for example here are some missing spaces in **if** command. please take care and reformat the code using default android formatting." }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a `--bug-path-length` argument to the `--add-filtering` command.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `--bug-path-length` option.", "reference": "Please add some valid examples to help message like `\"4:10\"`, `\"4:\"`, `\":10\"`" }, { - "prediction": "I'm not sure what you're trying to do here, but I think it's a bad idea to use `to_s` on a symbol.", + "prediction": "I'm not sure what you're trying to do here, but I think this is a bad idea. It's not clear what you're trying to do here, but I think this is a bad idea. It's not clear what you're trying to do here, but I think this is a bad idea. It's not clear what you're trying to do here, but I think this is a bad idea. It's not clear what you're trying to do here, but I think this is a bad idea. It's not clear what you're trying to do here, but I think this is a bad idea. It's not clear what you're trying to do here, but I think this is a bad idea. It's not clear what you're trying to do here, but I think this is a bad idea. It's not clear what you're trying to do here, but I think this is a bad idea. It's not clear what you're trying to do here, but I think this is a bad idea. It's not clear what you're trying to do here, but I think this is a bad idea. It's not clear what you're trying to do here, but I think this is a bad idea. It's not clear", "reference": "Is it only Symbols we're worried about converting? Is it not safe to just call `to_s` anyway?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's unnecessary.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use the same `time.Duration` for both `BlockTimeTest` and `MineDelayTest` so that we don't have to change the value of `BlockTimeTest` when we change the value of `MineDelayTest`.", "reference": "Note for those who come across this later: It was moved to `testhelpers.mining.go` so that `testhelpers.NewDaemon` and the `mining/worker_test.go` can share it." }, { @@ -12723,23 +12723,23 @@ "reference": "What about `sort_by(&:in_progress?)`? Maybe with a `.reverse` thrown in?" }, { - "prediction": "I don't think we need to add `grpc` to the `flagsForExecution` list.", + "prediction": "I don't think we need to add `grpc` to the list of flags for execution.", "reference": "Flag is removed because it is only gRPC now." }, { - "prediction": "I'm not sure what you're trying to achieve with this command, but it looks like you're trying to create a new role using a cookiecutter template. Is this what you're looking for?", + "prediction": "I'm not sure what you're trying to achieve with this command. It seems like you're trying to initialize a role using a local cookiecutter template, but I'm not sure what you're trying to achieve with this command. Could you please provide more context or clarify what you're trying to achieve with this command?", "reference": "Might be better to rephrase to: Please refer to the ``init scenario`` command in order to generate a custom ``molecule`` scenario. Since you aren't customizing the default scenario since it already exists, right?" }, { - "prediction": "I think this should be `elif open_module == \"pathlib\"` instead of `elif open_module == \"pathlib\" and node.func.attrname == \"write_text\"`", + "prediction": "I think this should be `encoding_arg = utils.get_argument_from_call(node, position=3, keyword=\"encoding\")` instead of `encoding_arg = utils.get_argument_from_call(node, position=3, keyword=\"encoding\")`", "reference": "Shall we merge these `if` for `path lib` and then do the `attrname` one. I'm trying to count `if`-calls and its getting late but I think we can reduce the number checks needed to get into L648 from 3 to 2 if you understand what I mean" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to have this in a separate file, so that it's easier to see what's going on.", + "prediction": "I'm not sure if this is a good place to put it, but I think we should move it to the `storage` package.", "reference": "why depend on recovery???" }, { - "prediction": "I don't think we need to close the done channel, since it's closed by the `doneChan := make(chan interface{})` statement.", + "prediction": "I don't think we need to close the done channel.", "reference": "the done channel only aims to be closed, so `chan struct{}` is better then `chan interface{}`" }, { @@ -12747,31 +12747,31 @@ "reference": "Do you mean to have gas_oracle changes in this PR?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `turbo-stream` for this kind of thing.", + "prediction": "I don't think we need to use `turbo-stream` here. We can just use `render` directly.", "reference": "Is this effectively requiring browsers support javascript?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to set the style of the dialog based on the theme of the activity.", + "prediction": "I don't think we need to do this.", "reference": "Lowercase `boolean` - use the primitive type." }, { - "prediction": "I think this should be `if (!blobExists)` instead of `if (blobExists)`?", + "prediction": "I think this should be `if (blobExists)` instead of `if (blobExists == false)`.", "reference": "This isn't the correct logic. if allowOverride == true and !blobExists then upload. Just don't do the exist check if allowOverride is set to true." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `read_surface_net_wm_state` function.", + "prediction": "I think it's better to use `if (atom[i] == xwm->atoms[_NET_WM_STATE_MAXIMIZED_VERT])` instead of `if (atom[i] == xwm->atoms[_NET_WM_STATE_MAXIMIZED_VERT]) { xsurface->maximized_vert = true; }`", "reference": "Can you replace these by `else if` please?" }, { - "prediction": "I think this should be `await expect( page ).toClick( '.mdc-select__selected-text', { text: new RegExp( fromRange, 'i' ) } );`", + "prediction": "I think this should be `new RegExp( toRange, 'i' )` instead of `new RegExp( fromRange, 'i' )`", "reference": "Would be nice if the field had a unique class name that could be used to target it, instead of `fromRange` But doesn't seem to be a common thing in the code base." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the header is already in the refedHeaders array. If it is, then we don't need to add it to the refedHeaders array. If it is not, then we need to add it to the refedHeaders array.", + "prediction": "I don't think we need to do this. The `referredHeaders` array is just a list of all the headers that have a `ref` attribute, so we don't need to do anything with it.", "reference": "Does this code fit on one line under 80 characters? It would be more consistent with our existing style." }, { - "prediction": "I think we can remove the `OpenEBSCRDArtifactsFor070` and `JivaVolumeArtifactsFor070` from the list.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `ArtifactList` struct.", "reference": "Not a requirement here. But i see a change in naming convention. We can rename the function to `CstorSparsePoolArtifactsFor070`." }, { @@ -12779,11 +12779,11 @@ "reference": "Why do you configure the UART like this? It's already configured by default." }, { - "prediction": "I'm not sure why we need to include `intel-fpga.h` here. It's only used in `intel-fpga.c` and `intel-fpga.h`, so it shouldn't be included here.", + "prediction": "I'm not sure why we need to include `intel-fpga.h` here. It's only used in `intel-fpga.c` and `intel-fpga.h`, so I don't think we need to include it here.", "reference": "Wow. Good catch. \"This `#include` was brought to you by the department of redundancy department.\" ;)" }, { - "prediction": "I'm not sure if this is a good idea, but I think we should use the `acme` package in the `cert-manager` package.", + "prediction": "I'm not sure if this is a good place to put it, but I think we should move it to the `acme` package.", "reference": "Well it's actually calling `AuthorizeOrder` and this seems like a DebugLevel message to me, maybe it should be dropped entirely." }, { @@ -12795,27 +12795,27 @@ "reference": "What cases do you see as being valid for not having any tests to run? If a test project doesn't have any tests to run we should avoid running it at the project level." }, { - "prediction": "I think this should be `if mset.mirror == nil { ... }` instead of `if mset.mirror == nil { mset.mu.Unlock() }`", + "prediction": "I think this should be `if mset.mirror != nil { ... }` instead of `if mset.mirror == nil { ... }`", "reference": "and is it possible that mset.mirror.msgs be nil? because if so, then you would get a panic also because of that." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `wlr_surface_destroy` function.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `wlr_surface_destroy` function.", "reference": "`next->opaque` should not be cleared." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to check if the account has an issuer first. If it doesn't have one, then the account is not trusted by the operator.", "reference": "already what? I know what, but seems like smth. is missing in this sentence" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `update` method instead of `replaceWith`.", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to update the activity card with the current events. I'm not sure what you're trying to do here, but it looks like you're trying to update the activity card with the current events. I'm not sure what you're trying to do here, but it looks like you're trying to update the activity card with the current events. I'm not sure what you're trying to do here, but it looks like you're trying to update the activity card with the current events. I'm not sure what you're trying to do here, but it looks like you're trying to update the activity card with the current events. I'm not sure what you're trying to do here, but it looks like you're trying to update the activity card with the current events. I'm not sure what you're trying to do here, but it looks like you're trying to update the activity card with the current events. I'm not sure what you're trying to do here, but it looks like you're trying to update the activity card with the current events. I'm not sure what you're trying to do here, but it looks like you're trying to update the activity card", "reference": "Can you put spaces after the `{`and before the `}`" }, { - "prediction": "I think this should be `__version__` instead of `__version__`", + "prediction": "I think we should use `__version__` instead of `__version__` here.", "reference": "We said we would put `[ ]` around the version. `[forseti-security] [v2.3.0]`" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.", + "prediction": "I'm not sure what you're trying to do here, but I don't think this is the right place to do it.", "reference": "Seems len(cnb[0]) will be the length after the write since of the *v thing we saw no?" }, { @@ -12823,23 +12823,23 @@ "reference": "can we make use of storagepoolclaim type rather than the generic interface{} type?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think we need to do anything here.", + "prediction": "I don't think we need to do this. The `k.AddPeers(k.previouslyConnected()...)` should be enough.", "reference": "this should happen before the `go k.manage()`, otherwise the node will always try the bootnodes first" }, { - "prediction": "I think we can remove the `trim` call here.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `createAllInputs_` function.", "reference": "Is this actually a lint related change?" }, { - "prediction": "I think this should be `Blacklight::Document::CacheKey` instead of `Blacklight::Document::CacheKey`", + "prediction": "I'm not sure if this is a good idea, but I think it would be good to have a `Blacklight::Document::CacheKey` class. It would allow you to create a `Blacklight::Document::CacheKey` from a `Blacklight::Document` object.", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { - "prediction": "I think this should be `bool_param(obj, param_name)` instead of `bool_param(obj, param_name, default=None)`.", + "prediction": "I think this should be `opt_nonempty_str_param` instead of `opt_str_param`?", "reference": "what does this do that str_param does not?" }, { - "prediction": "I think this should be `fmt.Sprintf(\"%s/%s/%s\", prefix, api, version)` instead of `fmt.Sprintf(\"%s/%s\", prefix, api, version)`.", + "prediction": "I think we should use `fmt.Sprintf(\"%s/%s/%s\", prefix, api, version)` instead of `fmt.Sprintf(\"%s/%s\", prefix, api, version)`.", "reference": "For GCP we included the API name (see below) so you can distinguish between uses other than `blob` once they exist, WDYT?" }, { @@ -12847,39 +12847,39 @@ "reference": "what would you think about doing this include on-demand within S3ObjectStore methods and then failing in a loud way?" }, { - "prediction": "I'm not sure what you mean by \"confirmed\" in this context. I think you mean \"confirmed\" in the sense of \"confirmed by the network\" or \"confirmed by the node\".", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to make sure that we don't try to confirm a transaction that has already been confirmed by another node.", "reference": "May be better make `stopped` atomic, then it can be just `for (auto i (node.store.latest_begin (transaction_a, next_frontier_account)), n (node.store.latest_end ()); i != n && && !stopped && elections_count < max_elections; ++i)`" }, { - "prediction": "I'm not sure I understand what you're trying to do here. The `future_chainAddEdges` is just a wrapper around the `future_addEdges` function, so I don't see why you'd want to use it here.", + "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to use `cpp2::future_chainAddEdges` instead of `cpp2::future_addEdges`. I think you want to use `cpp2::future_chainAddEdges` instead of `cpp2::future_addEdges`.", "reference": "In `src/storage/InternalStorageServiceHandler.h ` file, the client in `client->future_chainAddEdges ` should be InterStorageServiceAsyncClient?" }, { - "prediction": "I'm not sure if this is a good place to put it, but I think we should move it to `monitoringv1` as well. It seems like it could be used by both `monitoringv1` and `monitoringv1beta1`.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to create a namespace labeler for the `monitoringv1` API, but I'm not sure if that's what you're trying to achieve.", "reference": "`go.sum` needs to be updated for this. Please run `go mod tidy`" }, { - "prediction": "I think it's better to use `SecretBackendSSMParameterStore` and `SecretBackendSecretsManager` instead of `MachineFinalizer` and `AWSMachineSpec`.", + "prediction": "I'm not sure what you mean by \"unique identifier as specified by the cloud provider\"", "reference": "Not sure if this was discussed previously, but is there a specific use case in mind for having this as an API field rather than a configuration option on the controller manager? Is there a specific use case in mind where one would want to choose different backends for individual Clusters/Machines vs having it a global configuration for an instance of the infrastructure provider?" }, { - "prediction": "I think we can remove the `OtlpMetricsExporter` and `PeriodicExportingMetricReader` from the `OpenTelemetry.Metrics` namespace.", + "prediction": "I think we can remove the `OtlpMetricsExporter` and `PeriodicExportingMetricReader` as they are not used anymore.", "reference": "Same thing with the OtlpExporter" }, { - "prediction": "I think it's a good idea to add a `case JX_OP_CALL: return \"(\";` for the `JX_OP_CALL` operator. I think it's a good idea to add a `case JX_OP_CALL: return \"(\";` for the `JX_OP_CALL` operator. I think it's a good idea to add a `case JX_OP_CALL: return \"(\";` for the `JX_OP_CALL` operator. I think it's a good idea to add a `case JX_OP_CALL: return \"(\";` for the `JX_OP_CALL` operator. I think it's a good idea to add a `case JX_OP_CALL: return \"(\";` for the `JX_OP_CALL` operator. I think it's a good idea to add a `case JX_OP_CALL: return \"(\";` for the `JX_OP_CALL` operator. I think it's a good idea to add a `case JX_OP_CALL: return \"(\";` for the `JX_OP_CALL` operator. I think it's a good idea to add a `case JX_OP_CALL: return \"(\";` for the `JX_OP_CALL` operator. I think it's a good idea to", + "prediction": "I think it's better to use `jx_print_subexpr` instead of `jx_operator_string` here.", "reference": "Should not be removed." }, { - "prediction": "I think this should be `include DSL::InstallUtils::PEDefaults` instead of `include DSL::InstallUtils::PEDefaults`.", + "prediction": "I'm not sure if this is the right place to put this, but I think it would make sense to move it to `beaker/dsl/install_utils/pe_defaults.rb` instead of `beaker/dsl/install_utils/puppet_utils.rb`.", "reference": "Not a blocker for anything, but should this be moved to beaker-pe? Is that ticketed anywhere?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `beforeClickOn` and `afterClickOn` methods, so that we don't have to do this in the `beforeClickOn` and `afterClickOn` methods.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move it to the `beforeClickOn` method.", "reference": "this shouldn't be beforeClickOn, but rather beforeSubmit? and added to WebDriverEventListener. Since submit does not synthesize the 'click' events, this isn't accurate." }, { - "prediction": "I think this should be `self.approving_official ? self.approving_official.email_address : self.system_approver_emails.first`", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it would be better to just use `self.approving_official.email_address` instead of `self.system_approver_emails.first`.", "reference": "this ternary operator is hiding an `if/else` within an `if/else` - any chance we could move the logic ELSEwhere? (see what I did there -- ?? :100: )" }, { @@ -12891,7 +12891,7 @@ "reference": "Does it have to be arrays? Isn't it ragged 'data' (i.e multiple elements of different lengths)?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the workflow is cleaned up after the import is done. This way, we don't have to worry about the workflow being left around after the import is done.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the workflow is properly cleaned up after it's done. I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the workflow is properly cleaned up after it's done. I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the workflow is properly cleaned up after it's done. I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the workflow is properly cleaned up after it's done. I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the workflow is properly cleaned up after it's done. I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the workflow is properly cleaned up after it's done. I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the workflow is properly cleaned up after it", "reference": "Per my understanding, this flag only impacts \"NoCleanup\" disk. If so, we may name it more clear. The reason of this ask is because I plan to add some other flag to force cleanup for other non-NoCleanup disks." }, { @@ -12899,23 +12899,23 @@ "reference": "In my changes for `RequiresDistributionAndOrdering`, this class went away and is replaced by an inner class. I think that pattern worked well. Maybe we could do that before this one to reduce the number of changes here." }, { - "prediction": "I don't think we need to change the order of the attributes.", + "prediction": "I don't think this is a good idea.", "reference": "Shouldn't this be called `hp` instead of `life`?" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to set the `allowedOrigins` and `allowedMethods` parameters for the `CrossOriginFilter` in the `addFilter` method. I'm not sure what you're trying to do here, but it looks like you're trying to set the `allowedOrigins` and `allowedMethods` parameters for the `CrossOriginFilter` in the `addFilter` method. I'm not sure what you're trying to do here, but it looks like you're trying to set the `allowedOrigins` and `allowedMethods` parameters for the `CrossOriginFilter` in the `addFilter` method. I'm not sure what you're trying to do here, but it looks like you're trying to set the `allowedOrigins` and `allowedMethods` parameters for the `CrossOriginFilter` in the `addFilter` method. I'm not sure what you're trying to do here, but it looks like you're trying to set the `allowedOrigins` and `allowedMethods` parameters for the `CrossOriginFilter` in the `addFilter` method. I'm not sure what you're trying to do here, but it looks like", + "prediction": "I don't think we need to add the `allowedOrigins` and `allowedMethods` parameters to the `CrossOriginFilter`.", "reference": "Because the default value of allowedOrigins is * (all origins), so it isn't necessary to set again at all." }, { - "prediction": "I'm not sure what you're trying to achieve with this change. It seems like you're trying to reload the game, but you're not actually doing anything with the `reload` function.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to remove the `return true;` at the end of the function.", "reference": "Undo this modification" }, { - "prediction": ",\"\"boolKey\"\":true,\"\"library.name\"\":\"\"CreateTestActivity\"\"}}}}]\",\n traceId);\n```\nReview comment?", + "prediction": ",\"\"boolKey\"\":\"\"True\"\",\"\"library.name\"\":\"\"CreateTestActivity\"\"}}}}]\",\n \"expected\": \"[{{\"\"traceId\"\":\"\"12345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234", "reference": "Please check my thoughts here... I changed the test to not `ToString()` attribute values. This was important to test things when `net.peer.port` was both an int or a string, but I was unsure if Zipkin supported non-string attributes." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `Base64Utils` class, since it's not in the `Camera` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to move this to the `Base64Utils` class so that it can be used in other places as well.", "reference": "Looks like you made changes on `CameraResultType` class, but didn't commit them. And you also have to do the changes on the types in @capacitor/core" }, { @@ -12927,11 +12927,11 @@ "reference": "What do you think about `mentor_mail_to` or `mentor_mail_to_link` in order to match Rails' `mail_to` method, which is what this calls? I'm not sure about this suggestion..." }, { - "prediction": "I don't think this is a good idea. It's not clear to me what the purpose of this is.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `MetricPoint` class.", "reference": "Looks like this will make the check in every loop. Consider extracting the null check." }, { - "prediction": "I'm not sure what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear", + "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", "reference": "Maybe `it \"can safely be reset when there are not yet any shared example groups\"`? That's the edge case that wasn't working, right?" }, { @@ -12939,35 +12939,35 @@ "reference": "naming: please use `asmfactory`" }, { - "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to do this. I'm not sure if this is a good idea, but I'm not sure if this is a good idea, but I'm not sure if this is a good idea, but I'm not sure if this is a good idea, but I'm not sure if this is a good idea, but I'm not sure if this is a good idea, but I'm not sure if this is a good idea, but I'm not sure if this is a good idea, but I'm not sure if this is a good idea, but I'm not sure if this is a good idea, but I'm not sure if this is a good idea, but I'm not sure if this is a good idea, but I'm not sure if this is a good idea, but I'm not sure if this is a good idea, but I'm not sure if this is a good idea, but I'm not sure if this is a good idea, but I'm not sure if this is a good idea, but I'm not sure if this is a good idea, but I'm not sure if this is a good idea, but I'm", + "prediction": "I'm not sure why we're doing this, but I think it's a good idea. I'm not sure why we're doing this, but I think it's a good idea. I'm not sure why we're doing this, but I think it's a good idea. I'm not sure why we're doing this, but I think it's a good idea. I'm not sure why we're doing this, but I think it's a good idea. I'm not sure why we're doing this, but I think it's a good idea. I'm not sure why we're doing this, but I think it's a good idea. I'm not sure why we're doing this, but I think it's a good idea. I'm not sure why we're doing this, but I think it's a good idea. I'm not sure why we're doing this, but I think it's a good idea. I'm not sure why we're doing this, but I think it's a good idea. I'm not sure why we're doing this, but I think it's a good idea. I'm not sure why we're doing this, but I think it's a good idea. I'm not sure why we're doing this", "reference": "FYI you could use a raw string for this which removes the need for escaping the inner quotes." }, { - "prediction": "I'm not sure I understand what you're trying to do with this test. It seems like you're trying to test that `is_special_key` returns `True` when the key is a special key, and `False` otherwise. Is this what you're trying to test?", + "prediction": "I'm not sure I understand what you're trying to do with this test. It seems like you're trying to test that `is_special_key` returns `True` when the key is a special key, and `False` when it's not a special key. Is this what you're trying to test?", "reference": "2 blank lines here (between functions)" }, { - "prediction": "I'm not sure what you mean by \"replace files must fail if any of the deleted paths is missing and cannot be deleted\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if any of the deleted paths is missing and cannot be deleted.", "reference": "Nit: we try to avoid whitespace changes because they can easily cause unnecessary commit conflicts." }, { - "prediction": "I think this should be `if ($offset < $start_pos)` instead of `if ($offset < $start_pos || $possible_reference[0] !== '*')`", + "prediction": "I think this should be `if ($offset - $end_pos === 0)` instead of `if ($offset - $end_pos === 2 && substr($file_contents, $end_pos, 2) === '::')`", "reference": "As mentioned below, I'm not sure why this is only allowing refs that are tagged with `*` at the start!" }, { - "prediction": "I think this should be `@Override` instead of `@Deprecated`.", + "prediction": "I think it's a good idea to add a `@Override` to `equals` and `hashCode` methods.", "reference": "Don't forget the {} symbols, and please use EqualsBuilder and HashcodeBuilder as possible" }, { - "prediction": "I think we can remove the `make(chan string)` and just use `conn` directly.", + "prediction": "I think it's better to use `net.DialUDP` instead of `net.ListenUDP` in this case.", "reference": "Allocate buffer once outside loop." }, { - "prediction": "I think this test should be moved to `network` instead of `filter`.", + "prediction": "I think this test should be moved to a separate test.", "reference": "It would be better to check that system.nodes[1]->network.port is somewhere in the target without specifying its exact position. But it is a very minor point and I have no string opinion on it just thought I'd mention it because our tests in general have too implementation detail." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to move it to the `Access` class.", + "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to move it to the `Access.java` file.", "reference": "Should this be in a bundle?" }, { @@ -12975,31 +12975,31 @@ "reference": "When Activity is lost (more precisely, ExecutionContext is lost) in the HttpModule we restore the root (HttpIn) Activity. That makes this assert invalid. I tried to fix the HttpModule so that it restores the Activity that was last running, but it is impossible to retrieve do to the way ExecutionContext works. It isn't an issue to remove the assert, but it is unnerving. Any instrumentation running in IIS reliant on Activity.Current could run into trouble." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `network` package.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `net` package.", "reference": "what was the point in moving handlers registration into a separate method?" }, { - "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea.", + "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea to add it to the `newCmdCache` function as well.", "reference": "At this point we probably want to ensure there's a store command set." }, { - "prediction": "I think it's a good idea to add a check for `isHardened` here. It's not clear to me why we would want to do this, but I think it's a good idea.", + "prediction": "I think it's better to use `parseInt(step)` instead of `+step` and `NaN` instead of `step[step.length-1] == \"'\".", "reference": "This code is way too complicated for what it does. I don't want to be a PITA, but what can you consider rewriting it in a simpler way? I'm talking about the whole `_getDerivationIndexes` function" }, { - "prediction": "I'm not sure what you mean by \"should not be in hex\"", + "prediction": "I'm not sure what you mean by \"should not be in hex\". I think you meant to say \"should not be in base64\" or \"should not be in base64url\" or \"should not be in base64urldecode\" or \"should not be in base64urldecodehex\" or \"should not be in base64urldecodehexbase64\" or \"should not be in base64urldecodehexbase64url\" or \"should not be in base64urldecodehexbase64urldecode\" or \"should not be in base64urldecodehexbase64urldecodehex\" or \"should not be in base64urldecodehexbase64urldecodehexbase64\" or \"should not be in base64urldecodehexbase64urldecodehexbase64url\" or \"should not be in base64urldecodehexbase64urldecodehexbase64urldecode\" or \"should not be in base64urldecodehexbase64urldecodehexbase64urldecodehex\" or \"should not be in base64urldecodehexbase64urldecodehexbase64urldecodehexbase6", "reference": "Don't throw base exception, specify more precise type" }, { - "prediction": "I think this should be `src_type` and `dst_type` instead of `src_type` and `dst_type`", + "prediction": "I don't think this is necessary. We can just do `torch.tensor(inputs, dtype=dst_type, device=inputs.device)` instead.", "reference": "Recursive -> Recursively converted -> convert" }, { - "prediction": "I think this should be `if (has_no_struct_fields || opts.generate_object_based_api && num_fields && num_fields < 127)`", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be good to add a check for `num_fields < 127` to make sure we don't generate a table constructor with more than 127 fields.", "reference": "why is this object API only? I think the reason why we didn't do this before was because this code was shared with Java which doesn't have value structs." }, { - "prediction": "I think we can remove the `sendCredentialsURLParameterName` from the query.", + "prediction": "I think we can remove the `sendCredentialsURLParameterName` and just use `sendCredentialsURL` instead.", "reference": "just to confirm, so backend will deal with both old format and new format?" }, { @@ -13007,7 +13007,7 @@ "reference": "huh, look at that, I wasn't aware you could constrain a type by Enum" }, { - "prediction": "I'm not sure what you mean by \"non-MPI\" here. I think you mean \"non-mpi\". Is that correct?", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `adios2::py11::MPI4PY_Comm` constructor.", "reference": "Even though the debug parameter is effectively ignored, should this default to `false` instead of `true`?" }, { @@ -13015,7 +13015,7 @@ "reference": "What is the purpose of this interface? Unlike ParamDocView, it doesn't seem to be used anywhere to enable polymorphism" }, { - "prediction": "I'm not sure what you're trying to do with this, but I think it's a bit of a red herring. The `onevent/hook` package is used for hooking into caddy's event handling, but it's not related to the `startupshutdown` package. It's possible that you're trying to use this package in a different way, but I'm not sure what you're trying to achieve with it.", + "prediction": "I don't think we need to use `onevent/hook` here. We can just use `caddy/onevent/hook` directly.", "reference": "We added a library to generate a UUID for the request_id directive \"github.com/nu7hatch/gouuid\" can we uses the same one for what you want rather than add another dependency? Or if the google one is better can we remove the nu7hatch library?" }, { @@ -13023,11 +13023,11 @@ "reference": "Shouldn't this be `i * Interval`? You're multiplying nanos with a Duration, I'm not sure what's the result :)" }, { - "prediction": "I think this should be `if (!DYNAMO_OPTION(guard_pages))` instead of `if (!DYNAMO_OPTION(guard_pages) && !DYNAMO_OPTION(guard_pages))`", + "prediction": "I think this should be `if (!DYNAMO_OPTION(guard_pages))` instead of `if (!DYNAMO_OPTION(guard_pages) && !DYNAMO_OPTION(guard_pages))`.", "reference": "I guess it's not no-access to match Windows where guard pages are readable." }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is it that you want to remove the approvers from the proposal? If that's the case, then why are you removing them from `self.proposal.approvals.non_pending.map(&:user) - approvers`? Is it that you want to remove the approvers from the proposal? If that's the case, then why are you removing them from `self.proposal.approvals.non_pending.map(&:user) - approvers`? Is it that you want to remove the approvers from the proposal? If that's the case, then why are you removing them from `self.proposal.approvals.non_pending.map(&:user) - approvers`? Is it that you want to remove the approvers from the proposal? If that's the case, then why are you removing them from `self.proposal.approvals.non_pending.map(&:user) - approvers`? Is it that you want to remove the approvers from the proposal? If that's the case, then why are you removing them from `self.proposal.approvals.non_pending.map(&:user) - approvers`? Is it that you want to remove the approvers from the proposal? If that's", + "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to remove the approvers from the proposal, but you're not actually removing them from the `self.proposal.approvals.non_pending` array.", "reference": "Not a blocker, but would probably be useful to have a `scope :non_pending_approvers` on the `Proposal` model." }, { @@ -13035,27 +13035,27 @@ "reference": "Add trailing comma" }, { - "prediction": "I'm not sure what you mean by \"GracefulShutdown\"", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `syscall.SIGKILL` instead of `syscall.SIGKILL` in this case.", "reference": "I see someone say SIGKILL can not be caught by process. The original code here about `SIGKILL` is useless?" }, { - "prediction": "I don't think this is a good idea. I think it's better to have a `theme` field in the `Setting` model.", + "prediction": "I don't think this is necessary.", "reference": "As it is a mobile only theme, please make sure the option appears only on mobile" }, { - "prediction": "I think we can remove the `if value < 0:` check.", + "prediction": "I think we can remove the `if not param:` check here.", "reference": "Would like a docstring and type annotations here" }, { - "prediction": "I don't think this is a good idea. It would be better to use `self.shard_key_fields = []` instead of `self.shard_key_fields = {}`.", + "prediction": "I don't think this is necessary. We can just use `self.class.shard_key_fields` instead.", "reference": "This is an API change. Why was it made?" }, { - "prediction": "I think this should be `using Microsoft.VisualStudio.TestPlatform.CoreUtilities.Tracing;` instead of `using Microsoft.VisualStudio.TestPlatform.CoreUtilities.Tracing;`", + "prediction": "I don't think this is needed anymore.", "reference": "Please move using inside namespace." }, { - "prediction": "I'm not sure what you mean by \"this is just to make sure that we do not fall into this trap when creating tests\"", + "prediction": "I'm not sure what you mean by \"this is just to make sure that we do not fall into this trap when creating tests\", but I'm not sure what you mean by \"this is just to make sure that we do not fall into this trap when creating tests\", but I'm not sure what you mean by \"this is just to make sure that we do not fall into this trap when creating tests\", but I'm not sure what you mean by \"this is just to make sure that we do not fall into this trap when creating tests\", but I'm not sure what you mean by \"this is just to make sure that we do not fall into this trap when creating tests\", but I'm not sure what you mean by \"this is just to make sure that we do not fall into this trap when creating tests\", but I'm not sure what you mean by \"this is just to make sure that we do not fall into this trap when creating tests\", but I'm not sure what you mean by \"this is just to make sure that we do not fall into this trap when creating tests\", but I'm not sure what you mean by \"this is just to make sure that we do not fall into this trap when creating tests\", but I'm not sure", "reference": "shall we create some enum flags for setasmain shouldprocess and pos?" }, { @@ -13063,7 +13063,7 @@ "reference": "Should this `PUPPET_AGENT_STARTUP_MODE` have a corresponding yardoc change?" }, { - "prediction": "I'm not sure if this is a bug or a feature request, but I think it should be a feature request.", + "prediction": "I'm not sure if this is a bug or a feature request, but I think it would be good to add a test for caret mode.", "reference": "Why not simply remove the `pytest` import now that it's not needed anymore? :wink:" }, { @@ -13075,11 +13075,11 @@ "reference": "don't use style. Use a class instead. reducing `col-xs-12` down to 8 or 6 or whatever should do the trick" }, { - "prediction": "I don't think we need to reload the cache here. We can just check if the table exists and return it if it does.", + "prediction": "I don't think we need to reload the cache here. We can just check if the table exists.", "reference": "should we also do `reloadCache` when database is null?" }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate function for this.", "reference": "Why not just return QueryMol directly? Why require the copy?" }, { @@ -13087,7 +13087,7 @@ "reference": "Could you add a docstring?" }, { - "prediction": "I'm not sure what you mean by \"display_search_ui?\"", + "prediction": "I think this should be `current_user && client_model && !client_disabled?` instead of `current_user && current_user.client_model && !client_disabled?`", "reference": "looks like you added newlines after blocks in a few files - I generally like newlines before/after multi-line blocks _except_ when the end the block is directly nested inside another block (eg: two `end`s next to each other) what do you think?" }, { @@ -13095,47 +13095,47 @@ "reference": "@jlerbsc 's fix in #2918 in action - thanks! :smiling_face_with_three_hearts:" }, { - "prediction": "I think this should be `self.zero_count = count` instead of `self.zero_count = not count`", + "prediction": "I think this should be `self.zero_count = zero_count` instead of `self.zero_count = not count`", "reference": "nitpick: Please lower-case `Zero_count` (as it's a literal argument name) and `Argument` here." }, { - "prediction": "I'm not sure what you mean by \"same issuer\"", + "prediction": "I don't think this is necessary.", "reference": "change the name of the function to match its functionality? account IsIssuing?" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a docstring to `groupby` and `toPandas` to explain what they do.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `GroupBy` object that can be passed to `toPandas()`. This way, we don't have to create a `GroupBy` object every time we call `toPandas()`, and we don't have to create a `GroupBy` object every time we call `toPandas()`.", "reference": "for later: add docstring (can just copy paste Pandas')" }, { - "prediction": "I'm not sure why we need to mock `archerMocks` here. It's not used anywhere in this test.", + "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to mock `archerMocks` here. I think it's better to mock `climocks` here.", "reference": "nit: @sonofachamp pointed out to me that the idiomatic way is \"archermocks\" (lowercase for package names)" }, { - "prediction": "I don't think this is necessary.", + "prediction": "I think we can remove the `*Inbound` here, since it's not used anywhere.", "reference": "Ugh I'm stupid, can you change this to `yarpc.InternalErrorf`?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a new table with the name `all_data_files` but you're not actually creating a new instance of `AllDataFilesTable`. You're just creating a new instance of `AllDataFilesTable` with the same `TableOperations` and `Table` passed in.", + "prediction": "I think this should be `@Override` instead of `@Deprecated`.", "reference": "We instantiate some metadata tables in tests so I kept the old constructor too. Won't harm if someone is using it directly too." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to check if `limit` and `perDocumentLimit` are both set. If they are, we should throw an error. If not, we can just use `limit` and `perDocumentLimit` as-is.", + "prediction": "I think this should be `if (queryOptions.limit != null && queryOptions.perDocumentLimit != null)`", "reference": "I think the better place to put this might be `lib/options/PopulateOptions.js`. That should make it easier - checking options in `populate()` can get confusing." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `NATPinger` package.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `NATPinger` struct.", "reference": "Lets have simple function arguments here, because now struct `traversal.Params` started to have 2 purposes: 1. used as contract in DTO between consumer-provider 2. as function parameters for internal code calls" }, { - "prediction": "I think this should be `org.openqa.grid.distributor.remote.RemoteDistributorTest` instead of `org.openqa.selenium.grid.distributor.remote.RemoteDistributorTest`", + "prediction": "I think this should be `RemoteDistributorTest.class` instead of `org.openqa.selenium.grid.distributor.remote.RemoteDistributorTest.class`", "reference": "Probably best not to have an empty test...." }, { - "prediction": "I'm not sure what you mean by \"the most valuable part for me was how I was able to dissect \"upcase\" app and see how it was built\"", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a link to the repo.", "reference": "`image_tag` in the `testimonials` files?" }, { - "prediction": "I think we should use a common method to transform stringData to data.", + "prediction": "I don't think we need to use `JSONUtils` here. We can just use `String` directly.", "reference": "I believe flow.toObject() method is throwing NPE if SLA option list (i.e. this.executionOptions.getSlaOptions()) is null or one of the value in the list (i.e. this.executionOptions.getSlaOptions()) is null. If that is the case we could fix root cause of NPE in the ExecutableFlow.toObject() method. The corresponding code to populate SLA options can be modified as follows. final List> slaOptions = Optional.ofNullable(this.executionOptions.getSlaOptions()).orElse(Collections.emptyList()).stream() .filter(Objects::nonNull) .map(slaOption -> slaOption.toObject()) .collect(Collectors.toList());" }, { @@ -13143,19 +13143,19 @@ "reference": "So I haven't tested this - but since the icon location is just directly dumped into the img _src_ attribute, won't this cause issues with Ghost blogs in a subdirectory? If I'm misunderstanding what the purpose of the default is then let me know" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to add a comment here explaining why this is necessary.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that `RUN_ALL_TESTS()` returns a non-zero value. If it returns zero, it means that the tests failed. If it returns a non-zero value, it means that the tests succeeded.", "reference": "Why swallow the exception here rather than propagate it?" }, { - "prediction": "`column_names` and `column_index` should be `List[Tuple[str]]` instead of `Optional[List[Tuple[str]]]`", + "prediction": "`column_names` and `column_index` should be `Optional[List[Tuple[str]]]` and `Optional[List[Tuple[str]]]` respectively.", "reference": "How about `column_index_names`? `column_names` sounds ambiguous." }, { - "prediction": "I think this should be `DEFAULT_WRITE_METRICS_MODE` instead of `DEFAULT_WRITE_METRICS_MODE_DEFAULT`.", + "prediction": "I don't think we need to change the default value of `METRICS_MODE_COLUMN_CONF_PREFIX` to `write.metadata.metrics.column.`", "reference": "+1 on this. Do we want to have it as `WRITE_METRICS_MODE_COLUMN_CONF_PREFIX` to be consistent with defaults? Is there a possibility we will have `READ_METRICS_MODE_COLUMN_CONF_PREFIX`? Not sure." }, { - "prediction": "I think we can remove the `list(\"ABC\")` in this case.", + "prediction": "I'm not sure what you mean by \"cumprod\" in this context. It's not clear to me what you're trying to do here.", "reference": "Shall we use different inputs for `PySpark < 2.4` where `transpose` won't work with different data types." }, { @@ -13163,67 +13163,67 @@ "reference": "we should sort the headers like in spark: public packages, then pyspark, then internal" }, { - "prediction": "I think this should be `grpc.WithTransportCredentials(credentials.NewClientTLSFromCert(nil, \"\"))` instead of `grpc.WithTransportCredentials(credentials.NewClientTLSFromCert(nil, \"\"))`", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `grpc.WithInsecure()` instead of `grpc.WithTransportCredentials()` here. This is because `grpc.WithInsecure()` is the same as `grpc.WithTransportCredentials()`, and `grpc.WithTransportCredentials()` is the same as `grpc.WithClientTLSConfig()`, which is the same as `grpc.WithInsecure()`.", "reference": "looks like we should drop this var from the transport options struct" }, { - "prediction": "I'm not sure what you mean by \"default renewBefore is bigger than the set duration\". I think you meant to say \"default renewBefore is smaller than the set duration\".", + "prediction": "I don't think we need to test this case, since it's already covered by `default renewBefore is bigger than the set duration`.", "reference": "Ah, yeah, this is the test for the validation that I mentioned in a remark above about relaxing the validation." }, { - "prediction": "I'm not sure what you mean by `img_h` and `img_w`? I'm not sure what you mean by `img_h` and `img_w`? I'm not sure what you mean by `img_h` and `img_w`? I'm not sure what you mean by `img_h` and `img_w`? I'm not sure what you mean by `img_h` and `img_w`? I'm not sure what you mean by `img_h` and `img_w`? I'm not sure what you mean by `img_h` and `img_w`? I'm not sure what you mean by `img_h` and `img_w`? I'm not sure what you mean by `img_h` and `img_w`? I'm not sure what you mean by `img_h` and `img_w`? I'm not sure what you mean by `img_h` and `img_w`? I'm not sure what you mean by `img_h` and `img_w`? I'm not sure what you mean by `img_h` and `img_w`? I'm not sure what you mean by `img_h` and `img_w`? I'm not sure", + "prediction": "I don't think this is necessary.", "reference": "For tensors, it is better to illustrate the shape." }, { - "prediction": "I think we can remove the `else if ( request.url().match( 'google-site-kit/v1/data/' ) )` line.", + "prediction": "I think it's better to use `request.respond` instead of `request.respondWith` in this case.", "reference": "This was removed in a recent PR for the admin bar, but should have been kept. It's been restored in the other admin bar PR but I've added it here to for completeness." }, { - "prediction": "I'm not sure if this is the right place to add this, but I think we should add it to `Instrumentation.AspNetCore.Tests` as well. I'm not sure if this is the right place to add this, but I think we should add it to `Instrumentation.AspNetCore.Tests` as well. I'm not sure if this is the right place to add this, but I think we should add it to `Instrumentation.AspNetCore.Tests` as well. I'm not sure if this is the right place to add this, but I think we should add it to `Instrumentation.AspNetCore.Tests` as well. I'm not sure if this is the right place to add this, but I think we should add it to `Instrumentation.AspNetCore.Tests` as well. I'm not sure if this is the right place to add this, but I think we should add it to `Instrumentation.AspNetCore.Tests` as well. I'm not sure if this is the right place to add this, but I think we should add it to `Instrumentation.AspNetCore.Tests` as well. I'm not sure if this is the right place to add this, but I think we should add it to `Instrumentation.AspNetCore.Tests` as well. I'm not sure if this is the", + "prediction": "I'm not sure if this is the right place to add this check, but I think it's important to make sure that the Activity is created by the Instrumentation, not by the ASP.NET Core runtime.", "reference": "nit: probably swap the if condition and `if/else` and check `NETCOREAPP2_1` which looks more natural." }, { - "prediction": "I'm not sure if this is a good place to put this, but I think we should move it to the `Account` struct, since it's not related to the `Account` struct itself.", + "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place", "reference": "for the tag, should it be `requestor_rtt` since the other is `responder_rtt`?" }, { - "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to change the color of the monster. I'm not sure what you're trying to do here, but it looks like you're trying to change the color of the monster. I'm not sure what you're trying to do here, but it looks like you're trying to change the color of the monster. I'm not sure what you're trying to do here, but it looks like you're trying to change the color of the monster. I'm not sure what you're trying to do here, but it looks like you're trying to change the color of the monster. I'm not sure what you're trying to do here, but it looks like you're trying to change the color of the monster. I'm not sure what you're trying to do here, but it looks like you're trying to change the color of the monster. I'm not sure what you're trying to do here, but it looks like you're trying to change the color of the monster. I'm not sure what you're trying to do here, but it looks like you're trying to change the color of the monster. I'm not sure what you're trying to do here", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be good to add a comment explaining what this function does.", "reference": "The one sad part of this is that is will generate a lot of overhead if you loop through a vector, since it obtains the vector every time. But with the current API there is no alternative I guess, and it is better to have the option than not." }, { - "prediction": "I think we can remove the `require` and `assert` here. We don't need to use them here.", + "prediction": "I'm not sure what you're trying to do with this, but I don't think it's necessary.", "reference": "nit: there should be a newline between `types` and `go-ipfs-files`." }, { - "prediction": "I don't think this is needed anymore.", + "prediction": "I think we can remove the `&retryAfterDuration` here, since it's not used anywhere else.", "reference": "would be nice to have this as a parameter (Options), re: technical debt discussions" }, { - "prediction": "I don't think this is a good idea. The `DesignerRoot` class is not part of the `org.apache.commons.lang3.ArrayUtils` package. It's part of the `net.sourceforge.pmd.util.fxdesigner.app.DesignerRoot` package.", + "prediction": "I don't think this should be here. It's in the `org.apache.commons.lang3.ArrayUtils` package. I think it should be moved to `org.apache.commons.lang3.ArrayUtils` in the `org.apache.commons.lang3` package.", "reference": "complete ignorance here but is it ok to import this from `com.sun`? can it break under non-oracle JREs?" }, { - "prediction": "I think we can remove the `startExecutionTracerTask` call here.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to `startExecutionTracerTask` as well, so that we don't have to do this every time we start a new execution task.", "reference": "Is this some way of saying that the span is going to be sampled? I'm basing this question on the condition I saw for the `OnEnd` to be called - `mustExport := s.spanContext.IsSampled() && )`. Shouldn't the condition be `s.spanContext.IsSampled()` to match the condition for calling the `OnEnd`?" }, { - "prediction": "I think we can remove the `volumereplica.GetAndUpdateSnapshotInfo` call here.", + "prediction": "I think we can remove the `if err != nil` here.", "reference": "just calling UpdateSnapshotInfo() should be fine" }, { - "prediction": "I think this should be `DefaultLogMessageRateLimit` instead of `DefaultLogMessageRateLimitEnabled`.", + "prediction": "I think this should be `GlobalSettings.Source.DebugEnabled` instead of `GlobalSettings.Source.DebugEnabled ? 0 : DefaultLogMessageRateLimit`.", "reference": "Was `DefaultLogMessageRateLimit` not configurable anywhere?" }, { - "prediction": "I think this test should be moved to a separate test suite.", + "prediction": "I think this test should be moved to `testPullImageInactivityTimeout` instead of `testPullImageGlobalTimeout`.", "reference": "Please use the `assert` instead. Same below." }, { - "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here.", + "prediction": "I don't think we need to change this.", "reference": "Owww, I think I found a typo. `suche`" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to use the `reverse_segment_id` to get the `source_phantom` from the `source_phantom` heap. I'm not sure what you're trying to do here, but it looks like you're trying to use the `reverse_segment_id` to get the `source_phantom` from the `source_phantom` heap. I'm not sure what you're trying to do here, but it looks like you're trying to use the `reverse_segment_id` to get the `source_phantom` from the `source_phantom` heap. I'm not sure what you're trying to do here, but it looks like you're trying to use the `reverse_segment_id` to get the `source_phantom` from the `source_phantom` heap. I'm not sure what you're trying to do here, but it looks like you're trying to use the `reverse_segment_id` to get the `source_phantom` from the `source_phantom` heap. I'm not sure what you're trying to do here, but it looks like you're trying to use the `reverse_segment_id` to get the `source_phantom` from", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `boost::optional` here.", "reference": "This can happen because we could get `PhantomNodes` that are not admissible as source/target right?" }, { @@ -13231,23 +13231,23 @@ "reference": "Should we add a note here to file a bug if this ever happens?" }, { - "prediction": "I don't think this is necessary. We can just use `api.marketContract.GetBenchmarksQuantity` directly.", + "prediction": "I don't think this is necessary. We can just use `api.marketContract.GetBenchmarksQuantity()` instead of `api.marketContract.GetBenchmarksQuantity(getCallOptions(ctx))`.", "reference": "overflow is still possible, isn't it?" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I'm not sure if this is the best way to do it.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `config.infer_base_class_for_anonymous_controllers = false` to the `config` block. I think it would be a good idea to make sure that the `config.infer_base_class_for_anonymous_controllers` is set to `false` in the `config` block.", "reference": "This seems more like a personal preference, so maybe this should be in your `~/.rspec`?" }, { - "prediction": "I think this should be `from scapy.error import Scapy_Exception` instead of `from scapy.arch.pcapdnet import PcapTimeoutElapsed`", + "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a `scapy.error.ScapyException` instead of a `scapy.arch.pcapdnet.PcapTimeoutElapsed`.", "reference": "To avoid a circular import between pcapdnet and automaton" }, { - "prediction": "I think this should be `if tab.data.viewing_source` instead of `if tab.data.viewing_source:`.", + "prediction": "I think this should be `if not tab.data.viewing_source` instead of `if tab.data.viewing_source`.", "reference": "Please remove this blank line." }, { - "prediction": "I don't think we need to use `InitWorkloadIdentityStatus` here. We can just use `InitWorkloadIdentityStatus` in the `ReconcileKind` function.", + "prediction": "I don't think we need to use `InitWorkloadIdentityStatus` here. We can just use the `InitWorkloadIdentityStatus` from `v1alpha1.WorkloadIdentityStatus`.", "reference": "it feels that the WorkloadIdentityCondition should be added to this Status... And if you have workload identity enabled, but not working, then you can mark that condition failed, and also Mark the ready false... not entirely sure though" }, { @@ -13255,39 +13255,39 @@ "reference": "I think these got refactored to `LvlFindInChain` to better conform with the coding guidelines. I think MarkL left these in for backwards compatibility." }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a docstring to this function.", + "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.", "reference": "It's fine for this PR, but in the future try to minimize unrelated changes." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you're trying to do here. I don't think you need to pass anything to the provisioner.", "reference": "The library -> modules and filters -> filter path changes are breaking changes or?" }, { - "prediction": "I don't think we need to import `botocore.config` here. We can just use `botocore` directly.", + "prediction": "I don't think we need to use `botocore.config` here. We can just use `boto3.config` instead.", "reference": "Can we encapsulate this check (`os.environ.get(\"TEST_TARGET\") == \"AWS_CLOUD\"`) into a small config/util function? (and also use it in `integration/conftest.py`) (I'd generally try to avoid accessing `os.environ` directly across the codebase. I'm aware that we're already doing this in a few places, but maybe we can start pulling things out - this will also help us create more systematic config/environment abstractions as we go...)" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check to see if `child` is `null` or `undefined` and if so, remove it from the stack. This way, we don't have to worry about pushing `null` or `undefined` onto the stack.", + "prediction": "I don't think this is necessary.", "reference": "An `if` statement would be better here. Functions, concat and reverse are all very expensive." }, { - "prediction": "I'm not sure if this is a good idea, but I think it's better to just return the canonical address.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.", "reference": "`Log here: connect to default factory for goerli network

    `" }, { - "prediction": "I think we can remove the `if e == model.NotificationEventType_EVENT_DEPLOYMENT_WAIT_APPROVAL.String()` check.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate function for this. It would be nice to be able to do something like `ds.GenericDeploymentConfig.DeploymentNotification.Mentions[0].Slack` or `ds.GenericDeploymentConfig.DeploymentNotification.Mentions[len(ds.GenericDeploymentConfig.DeploymentNotification.Mentions)-1].Slack`.", "reference": "nits, should add `break` to avoid redundant iterations." }, { - "prediction": "I'm not sure what you're trying to do with this test, but I think it's a bad idea. It's not clear what you're trying to do with this test, but I think it's a bad idea. It's not clear what you're trying to do with this test, but I think it's a bad idea. It's not clear what you're trying to do with this test, but I think it's a bad idea. It's not clear what you're trying to do with this test, but I think it's a bad idea. It's not clear what you're trying to do with this test, but I think it's a bad idea. It's not clear what you're trying to do with this test, but I think it's a bad idea. It's not clear what you're trying to do with this test, but I think it's a bad idea. It's not clear what you're trying to do with this test, but I think it's a bad idea. It's not clear what you're trying to do with this test, but I think it's a bad idea. It's not clear what you're trying to do with this test, but I think it's a bad idea. It's not", + "prediction": "I'm not sure what you mean by \"touch zero value system account is not deleted\". I think you meant to say \"touch zero value system account is deleted\".", "reference": "I think we want an exception here, there should never be a transfer to a nonexisting account." }, { - "prediction": "I think we can remove the `Function` from the constructor.", + "prediction": "I don't think this is necessary.", "reference": "This code is new and not tested well. While we may drop the log level before we ship 4.0, right now this is extremely helpful to users." }, { - "prediction": "I'm not sure what you mean by `max(0.01, 0.1 - 0.01 * x)`. I think you meant `max(0.1, 0.01 - 0.01 * x)`.", + "prediction": "I don't think this is a good idea. It's not clear to me why we would want to do this. I'm not sure why we would want to do this. I'm not sure why we would want to do this. I'm not sure why we would want to do this. I'm not sure why we would want to do this. I'm not sure why we would want to do this. I'm not sure why we would want to do this. I'm not sure why we would want to do this. I'm not sure why we would want to do this. I'm not sure why we would want to do this. I'm not sure why we would want to do this. I'm not sure why we would want to do this. I'm not sure why we would want to do this. I'm not sure why we would want to do this. I'm not sure why we would want to do this. I'm not sure why we would want to do this. I'm not sure why we would want to do this. I'm not sure why we would want to do this. I'm not sure why we would want to do this. I'm not sure why we would want to do this. I'm not sure", "reference": "Can we make these asserts more strict/precise? I remember this test helped to spot the issue of inconsistent results on different platforms due to using `sort` instead of `stable_sort`." }, { @@ -13299,23 +13299,23 @@ "reference": "In this and the one below, should we assert `self != NULL` first?" }, { - "prediction": "I'm not sure what you mean by \"invalid action\" here. I think it's more accurate to say that it should return a 404 error.", + "prediction": "I'm not sure if this is the right place for this test, but I think it should be here.", "reference": "Why this is needed?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to get the user_meta from the PackageEntry, but then you're trying to get the user_meta from the PackageEntry, which doesn't make sense. I think you want to get the user_meta from the PackageEntry, but then you're trying to get the user_meta from the PackageEntry, which doesn't make sense. I think you want to get the user_meta from the PackageEntry, but then you're trying to get the user_meta from the PackageEntry, which doesn't make sense. I think you want to get the user_meta from the PackageEntry, but then you're trying to get the user_meta from the PackageEntry, which doesn't make sense. I think you want to get the user_meta from the PackageEntry, but then you're trying to get the user_meta from the PackageEntry, which doesn't make sense. I think you want to get the user_meta from the PackageEntry, but then you're trying to get the user_meta from the PackageEntry, which doesn't make sense. I think you want to get the user_meta from the PackageEntry, but then you're trying to get the user_meta from the PackageEntry, which doesn't make", + "prediction": "I'm not sure if this is a good idea, but I think we should be able to get the user_meta from the PackageEntry directly, so we don't need to call this method.", "reference": "we already have .meta() so I don't think we want get_meta() for PackageEntry" }, { - "prediction": "I'm not sure what you mean by `schemaInfer.getTypes().toArray(new DataType[0])`", + "prediction": "I'm not sure what you mean by `schemaInfer.getTypes().toArray(new DataType[0]);`", "reference": "question: can we always get the startts from dagrequest?" }, { - "prediction": "I'm not sure what you mean by \"click the label to expose the elements in the menu.\" I think you meant to say \"click the label to select the elements in the menu.\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `AccountSelect` component.", "reference": "Nit-picking, but this can be simplified to reference `properties[ 0 ]` since that is already retrieved 2 lines above." }, { - "prediction": "I think we can remove the `@unresolved_targets` and `@resolved_targets` variables.", + "prediction": "I think we can remove the `@unresolved_targets` and `@resolved_targets` variables, as they are not needed anymore.", "reference": "This technically works because we call `get_targets` before we remove the target, so it's bound to have been resolved. But I'm not sure I would like to rely on that assumption. Should we also remove it from `@unresolved_targets` to be safe?" }, { @@ -13323,31 +13323,31 @@ "reference": "So what happens if I try to get code on a EOA?" }, { - "prediction": "I think this should be `if len(targets) != len(values)` instead of `if any(isinstance(target, nodes.Starred) for target in targets):`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this.", "reference": "Can't we return an empty list and then just compare the lengths? Thereby removing this `if`." }, { - "prediction": "I'm not sure what you mean by \"superfocus\" in this context. I think you meant to say \"superfocus\" in this context.", + "prediction": "I'm not sure what you're trying to do here. I'm not sure if you're trying to throttle the `addFile` or `removeFile` calls, or if you're trying to throttle the `pauseResume` call. I'm not sure what you're trying to do here. I'm not sure if you're trying to throttle the `addFile` or `removeFile` calls, or if you're trying to throttle the `pauseResume` call. I'm not sure what you're trying to do here. I'm not sure if you're trying to throttle the `addFile` or `removeFile` calls, or if you're trying to throttle the `pauseResume` call. I'm not sure what you're trying to do here. I'm not sure if you're trying to throttle the `addFile` or `removeFile` calls, or if you're trying to throttle the `pauseResume` call. I'm not sure what you're trying to do here. I'm not sure if you're trying to throttle the `addFile` or `removeFile` calls, or if you're trying to throttle the `pauseResume` call. I'm not sure what you're trying to do here. I'm not sure", "reference": "Mb change it to 'doesPassRestrictions()'? Doesn't sound enough like a boolean-returning method to me." }, { - "prediction": "I'm not sure I understand what you're trying to do here. Could you please provide some more context?", + "prediction": "I'm not sure what you're trying to achieve here. I think you want to be able to get a chunk from a feed, but you want to be able to get the index of the next chunk in the feed. I think you want to be able to get a chunk from a feed, but you want to be able to get the index of the next chunk in the feed. I think you want to be able to get a chunk from a feed, but you want to be able to get the index of the next chunk in the feed. I think you want to be able to get a chunk from a feed, but you want to be able to get the index of the next chunk in the feed. I think you want to be able to get a chunk from a feed, but you want to be able to get the index of the next chunk in the feed. I think you want to be able to get a chunk from a feed, but you want to be able to get the index of the next chunk in the feed. I think you want to be able to get a chunk from a feed, but you want to be able to get the index of the next chunk in the feed. I think you want to be able to get a chunk from a", "reference": "TODO: in fact At when used with noncurrent time should not return a next index. only latest should.." }, { - "prediction": "I'm not sure what you mean by `isTopLevelFragment` here. I think it should be `isTopLevelFragment && tmp.key == null`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good place to do this.", "reference": "There are scenario's where we skip an update with a placeholder, in this case tmp returns null with render, this is not an array so we `[null]` it" }, { - "prediction": "I think we can remove the `@Unapply` annotation from `Stream(Stream.Cons cons) { return Tuple.of(cons.head(), cons.tail()); }`", + "prediction": "I think we can remove the `@Unapply` annotation from `List` and `Stream` as they are already `@Unapply` in `ListCons` and `StreamCons` respectively.", "reference": "@danieldietrich, this wasn't tested so I presumed it wasn't working before either :p" }, { - "prediction": "I'm not sure what you're trying to do here, but I think you're mixing up the Facet class and the Facet trait. The Facet trait is used to create a Facet object, while the Facet class is used to create a Facet instance.", + "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to have a separate file for this, so that it can be reused in other parts of the application.", "reference": "Please leave two empty lines after the `use` statement" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think we need to change anything here.", + "prediction": "I don't think we need to use `os/exec` here. We can use `exec.Command` instead.", "reference": "Please move this import in the 3rd group which is for external dependencies" }, { @@ -13355,35 +13355,35 @@ "reference": "So what exactly is this fixing? The unit test is passing with or without this change." }, { - "prediction": "I don't think this is a good idea. We should use `fs::FileUtils::makeDir` instead of `folly::stringPrintf`.", + "prediction": "I don't think we need to use `fs::FileUtils::makeDir` here. We can just use `fs::exists` and `fs::create` directly.", "reference": "auto targetFile = fs::FileUtils::joinPath(newPath, folly::stringPrintf(\"%019ld.wal\", it->first));" }, { - "prediction": "I think this should be `ancestorIds(Snapshot snapshot, Function lookup)` instead of `ancestorIds(table.snapshot(toSnapshotId), snapshotId -> snapshotId != fromSnapshotId ? table.snapshot(snapshotId) : null)`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to make sure that `fromSnapshotId` is an ancestor of `toSnapshotId`.", "reference": "I don't see any place that checks whether the from snapshot is an ancestor of the to snapshot. That seems like a requirement for this to work correctly to me." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate method to get the help text.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `getHelpText` method, since it will be called by the `getHelpText` method in the `TranslatorAwareInterface` and `LoggerAwareInterface` classes.", "reference": "Other calls to getHelpText() are wrapped in an `isset()` check. Would it make sense to be consistent, and either restore that here or remove it elsewhere?" }, { - "prediction": "I'm not sure what you're trying to do here. The `@configuration` variable is not used anywhere in the code. It's only used in the `configure` method of the `World` class. I think you meant to use `@configuration` in the `configure` method of the `World` class.", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to set the output stream to `stdout` and then call `@world.announce_filters` but I'm not sure what you're trying to do here.", "reference": "Why the change? If `output_stream` is set to something non-nil, it seems odd (and potentially wrong) to overwrite it...." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if this is the right place to make this change. If you can provide more context, I'll be happy to help.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's the right thing to do.", "reference": "Thinking this should have an underscore." }, { - "prediction": "I think this is a bit misleading. The `msg_state_scope` is not the same as the `msg_state_confidence`. The `msg_state_confidence` is the same as the `msg_state_confidence` for all scopes. The `msg_state_scope` is the same as the `msg_state_scope` for all scopes. The `msg_state_scope` is the same as the `msg_state_scope` for all scopes. The `msg_state_scope` is the same as the `msg_state_scope` for all scopes. The `msg_state_scope` is the same as the `msg_state_scope` for all scopes. The `msg_state_scope` is the same as the `msg_state_scope` for all scopes. The `msg_state_scope` is the same as the `msg_state_scope` for all scopes. The `msg_state_scope` is the same as the `msg_state_scope` for all scopes. The `msg_state_scope` is the same as the `msg_state_scope` for all scopes. The `msg_state_scope` is the same as the `msg_state_scope` for all scopes. The `msg_state_scope` is the same as the `msg_state_scope` for all scopes. The `msg_state_scope` is the", + "prediction": "I think this is a bit confusing. `msg_state_scope` and `msg_state_confidence` are two different things. `msg_state_confidence` is the confidence of the message. `msg_state_scope` is the scope of the message.", "reference": "To accommodate the change to the method being private." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to add a new property to the `Paths` dictionary, but I don't think that's what you want to do. I think you're trying to add a new property to the `PropertiesNamesCamelCase` collection, but I don't think that's what you want to do either. I think you're trying to add a new property to the `Paths` dictionary, but I don't think that's what you want to do either. I think you're trying to add a new property to the `PropertiesNamesCamelCase` collection, but I don't think that's what you want to do either. I think you're trying to add a new property to the `Paths` dictionary, but I don't think that's what you want to do either. I think you're trying to add a new property to the `PropertiesNamesCamelCase` collection, but I don't think that's what you want to do either. I think you're trying to add a new property to the `Paths` dictionary, but I don't think that's what you want to do either. I think you're trying to add a new property to the `PropertiesNamesCam", + "prediction": "I don't think this is a good name for this property. I think it's better to name it something like `Properties` or something like that.", "reference": "Shouldn't we traverse all definitions and apply this rule over all model definitions in the doc" }, { - "prediction": "I'm not sure what you mean by \"no additional unit tests\" here. I think you meant to say \"no additional tests\" or \"no additional unit tests\".", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to remove the `@Rule` annotation from `MutableStaticState` since it's not really a rule at all.", "reference": "Please rename this class that it ends with the suffix \"Test\" - otherwise the tests won't be executed." }, { @@ -13395,7 +13395,7 @@ "reference": "I take it memQuotaRatio is an \"out\" parameter at line 1810? Also, why use MIN_QUOTA in both the cases of memQuota being too low and too high? Contrast this code with RelRoot::codeGen where we set MIN_QUOTA only in the too low case." }, { - "prediction": "I think it's a good idea to have a default value for `gcpauthtesthelper.ContextWithDefaults()`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a default value for `gcpauthtesthelper.ContextWithDefaults()` so that we don't have to call it every time we create a new `PullSubscription` instance.", "reference": "It looks like for newpullsubscription, we have two functions. One for pullsubscription with default, one for pullsubscription without default. If you remove setdefault here, then there is no differences between these two functions." }, { @@ -13407,27 +13407,27 @@ "reference": "- Use type from `service_discovery/dto/price.go` - Rename `Price` -> `Money`" }, { - "prediction": "I think we can remove the `Function1` from the `bimap` method, as it's not needed.", + "prediction": "I think it's better to use `bimap` instead of `bimap` and `Function1` instead of `Function2`.", "reference": "one space missing at the beginning" }, { - "prediction": "I think we can remove the `Platform` field since it's not used in the manifest.", + "prediction": "I think we should remove the `yaml` field from `AppRunnerInstanceConfig` as it's not used.", "reference": "I worry that having `Platform` as `string` instead of `*string` would result in it getting overriden with `\"\"` if the environment manifest config doesn't specify `platform` . If it gets overridden as `\"\"`, that could be a problem for users that are not using `linux/amd64` right? If this indeed is a potential impact, could we double check in `ApplyEnv`'s unit test? Same with the `Platform` in `TaskConfig`. Sorry for not seeing this in my previous review!!!" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you're trying to do here. I don't think this is the right way to do it.", "reference": "I like the new directory `/api`, what is the thinking behind `/external`?" }, { - "prediction": "I think it's better to use `sort.Slice` instead of `append` and `sort.Strings` in this case.", + "prediction": "I think this should be `if len(a.signingKeys) != len(old.signingKeys) && len(a.signingKeys) != len(old.signingKeys)`", "reference": "staticcheck flags this: replace with `for k := ..`" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `time.sleep(0.05)` instead of `time.sleep(0.001)`. This is because `time.sleep(0.001)` will cause the program to hang indefinitely, while `time.sleep(0.05)` will cause the program to hang for a very short amount of time.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to make sure that `GMLAN_InitDiagnostics` is called before `GMLAN_EnableProgrammingMode` and `GMLAN_DisableProgrammingMode` are called. This way, the `GMLAN_InitDiagnostics` function will be called before the `GMLAN_EnableProgrammingMode` and `GMLAN_DisableProgrammingMode` functions are called, and the `GMLAN_EnableProgrammingMode` and `GMLAN_DisableProgrammingMode` functions will be called after the `GMLAN_InitDiagnostics` function is called.", "reference": "There's already a sleep right above" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do it here.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if it's a method call or a static call. If it's a method call, then we need to add it to the array. If it's a static call, then we don't need to add it to the array.", "reference": "This feels hacky, is there a better way?" }, { @@ -13435,7 +13435,7 @@ "reference": "Can we move this logic into the `boto.compat` module? Then it's just `from boto.compat import OrderedDict` instead. Also, this is introducing a new dependency. What about users on 2.6.x that don't have the OrderedDict module installed? We may need to fall back to an ordinary `dict` so that existing code in the wild does not break." }, { - "prediction": "I don't think we need to do this.", + "prediction": "I don't think we need to use `SerializationSettings` and `DeserializationSettings` here. We can just use `JsonSerializerSettings` and `JsonConverterSettings` instead.", "reference": "\"Gets the JSON serialization settings.\" would be better?" }, { @@ -13443,7 +13443,7 @@ "reference": "The endpoint should be in plural `/files`." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to change the definition of `AtomGetPDBResidueInfo` to `AtomGetPDBResidueInfoMDLDummy` and `AtomGetPDBResidueInfoDaylightDummy`. This would make it impossible to use `AtomGetPDBResidueInfoMDLDummy` and `AtomGetPDBResidueInfoDaylightDummy` in the same way that `AtomGetPDBResidueInfo` is used.", "reference": "??? Why do we need to have a different API in Python? Oh, wait, I see what you did. It's to fake the namespaces. Given that I don't think the namespaces are necessary, and that less of these should be exposed anyway, I think these should go." }, { @@ -13451,11 +13451,11 @@ "reference": "I think this line is gofmt issue? @daixiang0" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to have a separate test for this. It would be better to have a separate test for `parseBuildLabelParts` and `TestParseBuildLabelParts`.", + "prediction": "I'm not sure I understand what you're trying to do here. You're trying to test the `parseBuildLabelParts` function, but you're not actually using it in your tests. You're trying to test the `subrepoLabel` function, but you're not actually using it in your tests either.", "reference": "probably better to assert the values directly; technically you could pass this test with an implementation that always returned \"\" for the subrepo for example." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate function for this, so that we don't have to call it multiple times.", + "prediction": "I'm not sure if this is the right place to do this, but I think we should move this to `addTestingTsfBlocks` so that we don't have to call it again and again.", "reference": "line is 161 characters (from `lll`)" }, { @@ -13463,31 +13463,31 @@ "reference": "Are these changes needed?" }, { - "prediction": "I think it's better to use `Files.newWatchService()` instead of `Files.createWatchService()`.", + "prediction": "I don't think we need to do this, we can just add the config file to the map directly.", "reference": "It seems like reducing the sensitivity would make the test failure less likely to occur, but not fix the issue?" }, { - "prediction": "I think this should be `use Thelia\\Model\\Tools\\I18nTimestampableTrait` instead of `use Thelia\\Model\\Tools\\I18nTimestampableTrait;`", + "prediction": "I think this should be `use Thelia\\Model\\Tools\\I18nTimestampableTrait;` instead of `use Thelia\\Model\\Tools\\I18nTimestampableTrait;`", "reference": "missing use statement for importing the full namespace" }, { - "prediction": "I'm not sure what you mean by \"incorrect address format\"", + "prediction": "I don't think this is a good idea. It would be better to have a separate error type for this.", "reference": "Generally error messages in Go shouldn't start with capital letter. I see this rule is broken in many places here. Why?" }, { - "prediction": "I'm not sure what you mean by \"out of bounds\" in this case. I think you meant \"out of bounds\" in the sense that it's not in the range `[0, 100]`.", + "prediction": "I'm not sure what you mean by \"out of bounds\" here. I think you meant \"out of bounds\" in the sense that it's not in the range `[0, 10000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", "reference": "These test checks if selection coordinates don't return negative values in that edge cases. Please revert the changes and set `autoWrapCol` and `autoWrapRow` to `false` to the Handsontable instance. This change applies to the entire Core_selection.spec.js file." }, { - "prediction": "I don't think this is a good idea. It would be better to use `CommitAndRestoreWithZeroGasPrice` instead of `ZeroGasPrice`.", + "prediction": "I don't think this is necessary. We can just use `CommitAndRestoreWithZeroGasPrice` instead of `ZeroGasPrice`.", "reference": "I would prefer flag SkipGasPricingValidation" }, { - "prediction": "I think this should be `std::unique_lock action_lock (action_mutex);` instead of `std::unique_lock lock (action_mutex);`", + "prediction": "I think this should be `std::lock_guard` instead of `std::unique_lock`.", "reference": "could be `const &` ?" }, { - "prediction": "I don't think we need to add `hideProgressAfterFinish: false` to the `defaultTabIcon` property.", + "prediction": "`hideProgressAfterFinish` should be `hideProgressAfterFinish: true`", "reference": "The docs should also be updated with the new option." }, { @@ -13495,35 +13495,35 @@ "reference": "Name is _way_ to generic for this patch to be accepted I think. Can you rename it to maybe `send_sns_notification` or something else you find suitable?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `context.Background()` instead of `context.WithValue()` here. This is because `context.WithValue()` is used to set a value in the context, and `context.Background()` is used to set a value in the context when the context is created.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to use the same logger for both the `cfg` and `cfg.Eth` contexts.", "reference": "Out of the scope." }, { - "prediction": "I think this should be `thisArg` instead of `window`.", + "prediction": "I think this should be `for (var i = 0; i < this.length; i++)` instead of `for (var i = 0; i < this.length; i++) { callback.call(thisArg, this[i], i, this); }`", "reference": "I think we need an if block to check that if this API is really missing. We wouldn't want to override the browser's implementation." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `name` property to the `RegisteredEditor` class.", + "prediction": "I don't think this is needed anymore.", "reference": "I was wondering, things like EDITOR_TYPE, VALIDATOR_TYPE, RENDERER_TYPE are not obligatory. Therefore if the custom editor will be registered with this method, `name` will be set to `undefined`. Should we handle this scenario?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but it looks like you're trying to remove the `p2p` package from the `p2p` directory. Is that correct?", + "prediction": "I don't think we need to change anything here.", "reference": "This line should not be removed, as it is not the description of the package, but a copyright header." }, { - "prediction": "I'm not sure what you mean by \"the last tag with which the block was marked\"", + "prediction": "I'm not sure what you mean by \"whether the block's triggered prefetches are complete\"", "reference": "Wouldn't it be more space efficient to make this a `byte` enum or bitfield?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `marker_table` in the `PostgresTarget` class. This will allow us to use the `marker_table` in the `PostgresTarget` class and the `marker_table` in the `PostgresTarget` class and the `marker_table` in the `PostgresTarget` class and the `marker_table` in the `PostgresTarget` class and the `marker_table` in the `PostgresTarget` class and the `marker_table` in the `PostgresTarget` class and the `marker_table` in the `PostgresTarget` class and the `marker_table` in the `PostgresTarget` class and the `marker_table` in the `PostgresTarget` class and the `marker_table` in the `PostgresTarget` class and the `marker_table` in the `PostgresTarget` class and the `marker_table` in the `PostgresTarget` class and the `marker_table` in the `PostgresTarget` class and the `marker_table` in the `PostgresTarget` class and the `marker_table` in the `PostgresTarget` class and the `", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `marker_table` in the `PostgresTarget` class. This way, we don't need to create a `marker_table` every time we create a new `PostgresTarget` instance.", "reference": "Flake8 doesn't like the assignment, but non-use of `e` here. I think we can just remove the try/except here for `cursor.execute(sql)`." }, { - "prediction": "Shouldn't this be `public interface ASTAnyTypeBodyDeclaration {}`?", + "prediction": "I think this should be `public interface ASTAnyTypeBodyDeclaration {}` instead of `public interface ASTAnyTypeBodyDeclaration extends JavaNode {}`", "reference": "Maybe add short example list: .... type body declarations, such as AnnotationMembers, Methods, Fields" }, { - "prediction": "I think we can remove `TIMEOUTS` and `IMPLICIT_TIMEOUT` from the `CapabilityType` interface.", + "prediction": "I don't think we need to add this to the `CapabilityType` interface.", "reference": "These are really meant to be the keys in the capabilities, not the keys of values within the capabilities" }, { @@ -13531,23 +13531,23 @@ "reference": "It is debatable whether we have to default this. I did this to avoid breaking custom implementations." }, { - "prediction": "I think we can remove the `if isinstance(attr_value, dict) and 'string' in attr_value and attr_value['string'] is not None and attr_value['string'] == value:` check.", + "prediction": "I think we can remove the `if isinstance(attr_value, dict) and 'string' in attr_value and attr_value['string'] is not None and attr_value['string'] == value` check.", "reference": "# `attr_value['string'] is not None` probably not required as `attr_value['string'] == value` check is already being done" }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good idea to move it to the `aws` package.", + "prediction": "I'm not sure if this is a good place to put it, but I think we should move it to `github.com/aws/amazon-ecs-cli-v2/internal/pkg/addons`.", "reference": "we shouldn't need the \"addon\" rename" }, { - "prediction": "Shouldn't this be `@decks = Deck.all` instead of `@decks = Deck.all`?", + "prediction": "Shouldn't this be `before_filter :must_be_admin, only: [:index, :show]` instead of `only: [:index, :show]`?", "reference": "These are covered by routing constraints." }, { - "prediction": "I think we can remove the `aws.StringSlice` since it's just a slice of strings. We can also remove the `[]string` since it's just a slice of strings. We can also remove the `[]interface{}` since it's just a slice of interfaces.", + "prediction": "I think this should be `aws.StringSlice([]string{*instanceID})` instead of `aws.StringSlice([]string{*instanceID})`", "reference": "Could we use just a normal string here?" }, { - "prediction": "I don't think this is necessary. `Symbol.iterator` is a built-in function, so we don't need to check for it. We can just use `typeof Symbol.iterator === 'function'`.", + "prediction": "I don't think this is necessary. `Symbol.iterator` is a built-in function, so we don't need to check for it.", "reference": "`isFunction(Symbol)` triggers a `ReferenceError` if Symbol is undefined. Using `typeof Symbol === 'function'` is OK however." }, { @@ -13555,35 +13555,35 @@ "reference": "Is there an else clause (with a lock.unlock ()) missing here as well? If we think we do not need an else clause then lets add an else clause containing assert zero." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate function for this. It would be nice to be able to do this in a single place, but I'm not sure if that's the best way to do it.", "reference": "do we foresee `32` ever changing? (as well as its use in error checking in `clerk.go`) if \"no\" this is fine, if \"yes\" it's probably still fine" }, { - "prediction": "I think this should be `public static Class getDescribedInterface()` instead of `public Class getDescribedInterface()`.", + "prediction": "I think this should be `public static Class getDescribedInterface() { return Rotatable.class; }`", "reference": "you don't need to create a enum for this, java allows you to switch on a string ;) (since java 7?)" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `AuthenticatedRoute` as well.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.", "reference": "This should be `modelPromises.roles = this.get('store').query('role', ...` and the promise body should just `return roles;`. This is because the `model()` hook will pause for the returned promises to be resolved before continuing so when returning `RSVP.hash` you end up with a hash containing the values returned from the promises so the controller and everything else relying on the `model` object doesn't need to worry about things being async." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I'm not sure if this is the best way to go about it. It's not clear to me what you're trying to achieve with this, but I'm not sure if this is the best way to go about it. It's not clear to me what you're trying to achieve with this, but I'm not sure if this is the best way to go about it. It's not clear to me what you're trying to achieve with this, but I'm not sure if this is the best way to go about it. It's not clear to me what you're trying to achieve with this, but I'm not sure if this is the best way to go about it. It's not clear to me what you're trying to achieve with this, but I'm not sure if this is the best way to go about it. It's not clear to me what you're trying to achieve with this, but I'm not sure if this is the best way to go about it. It's not clear to me what you're trying to achieve with this, but I'm not sure if this is the best way to go about it. It's not clear to me what you're trying", + "prediction": "I'm not sure if this is the best way to do this, but it seems to work for me.", "reference": "This is basically a repeat of `main-is-top-level.js`. I suggest having these 3 checks point to the same evaluate file. You can change what element they test through the rule selector as well as the check.json options property. So you would have `main-is-top-level.json`, `banner-is-top-level.json` and `contentinfo-is-top-level.json` each point to `landmark-is-top-level.js`, and pass in a different `options` object which tells it what element you're trying to test." }, { - "prediction": "Shouldn't this be `invokeListeners` instead of `invokeListeners(pkgInfo);`?", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `packagesUpdated` method.", "reference": "Why do we need this check? setCore already handles nulls." }, { - "prediction": "I think this should be `setattr(target_type, \"__getattr__\", inject_type.__getattr__)` instead of `setattr(target_type, \"__getattr__\", inject_type.__getattr__)`", + "prediction": "I think it's better to use `__getattr__` and `__getitem__` instead of `__getattr__` and `__getitem__` because `__getattr__` and `__getitem__` are more specific than `__getattr__` and `__getitem__`.", "reference": "good catch, thanks. This is going to make the user experience much better." }, { - "prediction": "I think this should be `import { Component, options } from 'preact'` instead of `import { options } from 'preact'`", + "prediction": "I don't think this is needed anymore.", "reference": "TODO: remove this unused import" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `validateJWTSVID` test.", + "prediction": "I'm not sure if this is the right place for this test. I think it should be in the test that validates the JWS token.", "reference": "Hmm leaking the library name out in the Workload API doesn't seem great. Do we want to catch these errors and return a canned \"could not parse token\" or something instead?" }, { @@ -13591,7 +13591,7 @@ "reference": "I think `-f gradlew` is better for code unity" }, { - "prediction": "I think this should be `intType()`, not `intType().intType()`.", + "prediction": "I think this should be `intType()` instead of `intType().intType()`.", "reference": "Is there precedent for this config key? What other keys are similar? The others in this file start with `table.exec.iceberg`. Is there a reason for not continuing with that convention?" }, { @@ -13603,31 +13603,31 @@ "reference": "AWS Identity and Access Management (IAM)" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have the `errorChannel` be a channel that can be closed when the command is done.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `tequilapi` package.", "reference": "You dont use this dependency anymore" }, { - "prediction": "I don't think this is a good idea. I think we want to make sure that the compile options are set before we run the tests. If we don't do that, we'll end up with a bunch of tests that fail because the compile options are not set.", + "prediction": "I don't think this is a good idea. I think it would be better to add a flag to the compile options that tells the compiler whether to use FTS4, FTS3, FTS5, or JSON1.", "reference": "Here is the test that checks that the sqlcipher in use was compiled with the right flags" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check to make sure the array is not null before trying to read it.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to check for nulls first.", "reference": "Turns out that if the hosts are not in an `array`, an `Exception` is not thrown anymore :-( It simply returns `null`. So, we need to attempt to parse a `string` outside the `catch` block for it to work." }, { - "prediction": "I don't think this is a good idea. The `RestTemplateBuilder` should be used to create a `RestTemplate` instance, not to create a `RestTemplateBuilder` instance.", + "prediction": "I don't think we need to change the `@Test` annotation here. The `@Test` annotation is used to mark a method as a test method. It is not used to mark a class as a test class. If you want to mark a class as a test class, you should use the `@RunWith(SpringRunner.class)` annotation.", "reference": "this test only covers the happy path. what about no acceptable rest template found?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `Distributor` class.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `getUri()` method of the `Session` object to get the `Uri` of the session.", "reference": "Since this is in a test, I imagine that the choice of `info` level was deliberate." }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. Is it that you want to use the `lsp` package to test the `langserver` package? Or is it that you want to use the `langserver` package to test the `lsp` package? I'm not sure what you're trying to do here. Is it that you want to use the `lsp` package to test the `langserver` package? Or is it that you want to use the `langserver` package to test the `lsp` package? I'm not sure what you're trying to do here. Is it that you want to use the `lsp` package to test the `langserver` package? Or is it that you want to use the `langserver` package to test the `lsp` package? I'm not sure what you're trying to do here. Is it that you want to use the `lsp` package to test the `langserver` package? Or is it that you want to use the `langserver` package to test the `lsp` package? I'm not sure what you're trying to do here. Is it that you", + "prediction": "I don't think we need to change this, but I'm not 100% sure it's the right thing to do.", "reference": "this should probably be named somewhere if you want to reuse it." }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use the same environment variable for both `install` and `installmanager` so that we don't have to change the `installmanager` pod's environment variable.", + "prediction": "I think this should be `BoundServiceAccountSigningKeyFile` instead of `BoundServiceAccountSigningKeyEnvVar`.", "reference": "needs a rename to not include AWS" }, { @@ -13635,7 +13635,7 @@ "reference": "Isn't sigma have `double` type?" }, { - "prediction": "I think we can remove the `nano::pub_key` and `nano::deterministic_key` here.", + "prediction": "I think this should be `auto pub = nano::pub_key (prv);` instead of `auto pub (nano::pub_key (prv));`", "reference": "May be better use nano::keypair that generates ramdom value?" }, { @@ -13643,11 +13643,11 @@ "reference": "I think the more complete solution will save off a `ignoreUndefined` in the base class for the bulk operation (with a default of `false`), and use that for calculations. Was there a reason you didn't want to support the option from the operation level?" }, { - "prediction": "I'm not sure what you mean by \"let the logout go through\" - I think you're confusing this with the \"logout\" in the `logout` method.", + "prediction": "I'm not sure what you mean by \"let the logout go through\" - I think you meant to say \"do not do anything\".", "reference": "The catch (Exception e) block that follows does an updateSync, which will get a SmartStore instance (while logging out is taking place) - and then terrible things will happen - a database gets created for the outgoing user that won't be openable by the returning user causing the app to crash at logout. This is a somewhat superficial fix - SmartStore should not return an instance for an outgoing user." }, { - "prediction": "I think we can remove the `m.EXPECT().GetConnection(gomock.Any()).AnyTimes()` call, as it's not necessary.", + "prediction": "I'm not sure what you're trying to do here, but I'm not sure if this is the right way to go about it.", "reference": "huh does this work without a `Return`?" }, { @@ -13655,7 +13655,7 @@ "reference": "Don't think we want this line, right? (Plus \"failing\" is spelled wrong)." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `FeedItemMenuHandler` class.", + "prediction": "I'm not sure I understand what you're trying to do here. Is it that you want to remove the item from the feed, or is it that you want to share the item? If it's the latter, then I think we should just remove the item from the feed. If it's the former, then I think we should just share the item.", "reference": "I think it would be more clear to have local-feed-hiding all in one place (bottom of this method?). Further up the method, there already is some code that hides the website icon, for example." }, { @@ -13663,15 +13663,15 @@ "reference": "Why remove this one? It doesn't work yet, but we'll add it sooner or later." }, { - "prediction": "I think we can remove the `docstore:\"i\"` and `docstore:\"u\"` fields.", + "prediction": "I think we should remove the `docstore:\"i\"` and `docstore:\"u\"` fields.", "reference": "Why did you remove the struct tags?" }, { - "prediction": "I think we should remove the `if report_info` check, as it's not necessary.", + "prediction": "I think it's better to use `self.log.info` instead of `self.log.info(\"Dumping final status as XML: %s\", filename)`.", "reference": "Let's be neutral with tag names. Let's just have \"ReportURL\"" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a span data object that has a `Start` and `End` field, but the `Start` field is set to `time.Now()` and the `End` field is set to `time.Unix(1585674086, 1234)`. I think you want to set the `Start` field to `time.Unix(1585674086, 0)` and the `End` field to `time.Unix(1585674086, 1234)`.", + "prediction": "I'm not sure what you mean by \"full test of span data transform.\" Could you please provide more context?", "reference": "Use an explicit time to ensure conversion is not copy-paste and wrong." }, { @@ -13679,15 +13679,15 @@ "reference": "The logic now is to look for ``. This `` output is also not consistent with the other two functions you mentioned. Do the other two RPCs not report an error?" }, { - "prediction": "I think we can remove the `find_show` method and just use `show` instead.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `find_show` method in the `Api::V1::ShowsController` as well.", "reference": "Use nested module/class definitions instead of compact style." }, { - "prediction": "I think we can remove the `t.Log(\"Init KBFSOps\")` line.", + "prediction": "I think this should be `t.Log(\"Init KBFSOps\")` instead of `t.Log(\"Init KBFSOps\")`", "reference": "Do you think we need to keep this in, or is it just leftover personal debugging? Seems like it wouldn't be too useful most of the time, but I don't care too much if you want to keep it." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the config.", + "prediction": "I'm not sure I understand what you're trying to do here.", "reference": "showNPCs is not needed" }, { @@ -13695,15 +13695,15 @@ "reference": "Docstring for public function pls" }, { - "prediction": "I'm not sure why this test is failing, but I'm not sure how to fix it.", + "prediction": "I'm not sure why this test is failing, but I don't think it's related to this PR. I think it's related to https://github.com/openshift/origin/pull/12864.", "reference": "This should use `t.Errorf` instead. You want the second part of the test to run even when the first part fails." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a check for `ctx.protocol_selector.ratio.http3 > 0` before calling `h2o_quic_close_all_connections()`. This way, we don't have to worry about the case where `ctx.protocol_selector.ratio.http3` is 0.", "reference": "Should this if block better be changed to `#if H2O_USE_LIBUV \\n #else ... #endif`? The reason I wonder is because that's the way the QUIC context is being initilaized at the beginning of this function. Though I would not expect practical difference between the two approaches, because ATM the only case where we create QUIC connections is when the protocol selector is set to non-zero, and because when it is set to non-zero `h2o_quiy_close_all_connections` becomes a no-op." }, { - "prediction": "I think we can remove the `hookState._value[0] = reducer(hookState._value[0], action);` line.", + "prediction": "I'm not sure I understand what you're trying to do here. What is `hookState._value[0]`? What is `hookState._component.setState({})` doing here?", "reference": "`Object.is` is an ES6 feature of JS so I don't think we can use it here (or we have to change our browser support matrix or specify that an Object.is polyfill is pre-req of `preact/hooks`). Should we just do an `===` check in `preact/hooks` and provide a `Object.is` polyfill and version of `useReducer` in `preact/compat`?" }, { @@ -13711,11 +13711,11 @@ "reference": "This was a bug I picked up by using the TS interface as a guide, this seems like it was / is the intention, also is a bug in master (needs port)" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to have this in the `CollectionAdminParams` class, so that it can be used in other places as well.", + "prediction": "I don't think this is needed anymore.", "reference": "It would be helpful to explicit here what this really means and assumes." }, { - "prediction": "I'm not sure what you mean by \"load key pairs from key pair path and construct addresses\". Could you please provide more context?", + "prediction": "I don't think this is necessary. We already have the expected balances in the `ExpectedBalances` map.", "reference": "`ExpectedBalances` is a global variable (from `gochecknoglobals`)" }, { @@ -13727,39 +13727,39 @@ "reference": "Feels like this should be left as is and add a new createClientWithIssuers or something like that. Avoid all the \"\"" }, { - "prediction": "I think we should remove the `if (authCallback != null) { authCallback.receivedErrorResponse(error); }` line.", + "prediction": "I think this should be `if (authCallback != null)` instead of `if (authCallback != null && authCallback.receivedErrorResponse(error))`", "reference": "Minor unrelated bug in the IDP flow where the error wasn't getting displayed as a `Toast`." }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it's a good idea to have a `mongoErrorContextSymbol` in the `mongoError` module. This will allow us to use `mongoErrorContextSymbol` in the `mongoErrorContextSymbol` module as well.", + "prediction": "I don't think we need to use `mongoErrorContextSymbol` here. We can just use `MongoError` and `MongoNetworkError` directly.", "reference": "I thought we got rid of this thing?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use the `TaintNodeData` class for this purpose.", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a `TaintNodeData` object from a `TaintNode` object. I think you want to create a `TaintNodeData` object from a `TaintNode` object, but I'm not sure what you're trying to do with the `entry_path_type` and `entry_path_description` fields.", "reference": "Please convert int params as well." }, { - "prediction": "I think this should be `lastComponent.Region` instead of `lastComponent.Region.FormatForVisualStudio()`.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `SarifDriver.cs` file, since it's not part of the `SarifDriver.Sdk` namespace.", "reference": "Fixed bug in implementation. Now I can run the validator from the VS Tools menu, double-click on an output line, and navigate to the site of the issue." }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good idea to have this in the `TracerSettings.cs` file. It would be a good idea to have this in the `TracerSettings.cs` file. It would be a good idea to have this in the `TracerSettings.cs` file. It would be a good idea to have this in the `TracerSettings.cs` file. It would be a good idea to have this in the `TracerSettings.cs` file. It would be a good idea to have this in the `TracerSettings.cs` file. It would be a good idea to have this in the `TracerSettings.cs` file. It would be a good idea to have this in the `TracerSettings.cs` file. It would be a good idea to have this in the `TracerSettings.cs` file. It would be a good idea to have this in the `TracerSettings.cs` file. It would be a good idea to have this in the `TracerSettings.cs` file. It would be a good idea to have this in the `TracerSettings.cs` file. It would be a good idea to have this in the", + "prediction": "I think this should be `TracerSettings.HttpServerErrors` and `TracerSettings.HttpClientErrors` instead of `TracerSettings.HttpServerErrorStatuses` and `TracerSettings.HttpClientErrorStatuses`.", "reference": "Can we rename this field to `HttpServerErrorCodes` or `HttpServerErrorStatuses`? It will contain a list of status _codes_, not a list of _errors_. (Personally I prefer \"codes\" over \"statuses\", but we can't change `DD_HTTP_SERVER_ERROR_CODES`.)" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to check if we have a cursor in our database before we try to seek to the head of the journal.", + "prediction": "I'm not sure if this is the best place to do this, but I think it's a good idea to do this in the `flb_input_get_property` function.", "reference": "would you please use: flb_utils_bool(...) here ?, that function wraps the on/off/true/false stuff." }, { - "prediction": "I think this should be `null` instead of `Prerelease`?", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in a separate file, so that we don't have to re-run it every time we add a new target.", "reference": "`invocationInfoTokensToRedact: null` (I really like the convention of using a named parameter whenever the value doesn't communicate the meaning, such as for literal values.)" }, { - "prediction": "I don't think this is a good idea. The `async_test` method should be in the `BaseDetector` class, not in the `Detector` class. The `async_test` method should be in the `BaseDetector` class, not in the `Detector` class. The `async_test` method should be in the `BaseDetector` class, not in the `Detector` class. The `async_test` method should be in the `BaseDetector` class, not in the `Detector` class. The `async_test` method should be in the `BaseDetector` class, not in the `Detector` class. The `async_test` method should be in the `BaseDetector` class, not in the `Detector` class. The `async_test` method should be in the `BaseDetector` class, not in the `Detector` class. The `async_test` method should be in the `BaseDetector` class, not in the `Detector` class. The `async_test` method should be in the `BaseDetector` class, not in the `Detector` class. The `async_test` method should be in the `BaseDetector` class, not in the `Detector` class. The `async_test` method", + "prediction": "I don't think this is a good idea. The `async_test` method should be in the `BaseDetector` class, not in the `Detector` class. The `simple_test` method should be in the `Detector` class, not in the `BaseDetector` class.", "reference": "maybe renamed to `async_simple_test` if we consider supporting aug test later on?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to set `@attributes` to `default_attributes` and then call `process` on it, but I'm not sure what you're trying to do there.", + "prediction": "I'm not sure what you're trying to achieve with this method, but it looks like you're trying to set the `new_record` attribute to `true` and then call `identify` on the document. I'm not sure what you're trying to achieve with this method, but it looks like you're trying to set the `new_record` attribute to `true` and then call `identify` on the document. I'm not sure what you're trying to achieve with this method, but it looks like you're trying to set the `new_record` attribute to `true` and then call `identify` on the document. I'm not sure what you're trying to achieve with this method, but it looks like you're trying to set the `new_record` attribute to `true` and then call `identify` on the document. I'm not sure what you're trying to achieve with this method, but it looks like you're trying to set the `new_record` attribute to `true` and then call `identify` on the document. I'm not sure what you're trying to achieve with this method, but it looks like you're trying to set the `new_record` attribute to `true` and then call `identify` on the", "reference": "So where is default_attributes now? Is it used anywhere else still? If not, can it be removed along with any tests of it?" }, { @@ -13779,47 +13779,47 @@ "reference": "This change is necessary because the schema version is ignored unless a schema is specified. I think that has always been the intent." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in `dr_get_os_version_ex` as well. It's not clear to me if this is the right place to do this, but I think it would be good to have this in `dr_get_os_version_ex` as well. It's not clear to me if this is the right place to do this, but I think it would be good to have this in `dr_get_os_version_ex` as well. It's not clear to me if this is the right place to do this, but I think it would be good to have this in `dr_get_os_version_ex` as well. It's not clear to me if this is the right place to do this, but I think it would be good to have this in `dr_get_os_version_ex` as well. It's not clear to me if this is the right place to do this, but I think it would be good to have this in `dr_get_os_version_ex` as well. It's not clear to me if this is the right place to do this, but I think it would be good to have this in `dr_get_os_version_ex` as well", + "prediction": "I think we should use `DR_WINDOWS_VERSION_10_1803` instead of `DR_WINDOWS_VERSION_10_1803` here.", "reference": "The api/docs/release.dox changelog message is missing: maybe you planned to add it once NtAllocateVirtualMemoryEx and NtMapViewOfSectionEx support is in? I would say, add it here in the same diff that raises max_supported_os_version." }, { - "prediction": "I think this should be `if (node && node.getAttribute(aria)) { return false; }` instead of `if (node && node.hasAttribute(aria)) { return false; }`", + "prediction": "I think this should be `if (node && node.getAttribute(aria))` instead of `if (node && node.getAttribute(aria)) { return false; }`", "reference": "Just do: `return node.hasAttribute('aria-hidden')`" }, { - "prediction": "I'm not sure what you're trying to do here. Can you please explain what you're trying to achieve?", + "prediction": "I'm not sure what you're trying to do here. Can you please explain what you're trying to do?", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { - "prediction": "I think we should remove the `private static` from the `domainMetadata` class. It's not really needed.", + "prediction": "I think we should remove the `private static` from this class, as it's not really needed.", "reference": "Do we need `_processDataPoisoned`? Can the name or the id of the current process ever change? Or the machine name?" }, { - "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `os.Unsetenv(\"NOTIFY_SOCKET\")` in this case. I think it's better to use `os.Setenv(\"NOTIFY_SOCKET\", notifySocket)` instead.", + "prediction": "I'm not sure if this is a good idea, but I think we should use `os.Setenv(\"NOTIFY_SOCKET\", notifySocket)` instead of `os.Setenv(\"NOTIFY_SOCKET\", notifySocket)`.", "reference": "Did it not work out to wait until after containerd and kubelet are started?" }, { - "prediction": "I'm not sure what you mean by \"increasedamage\" and \"increasehealing\". I think you meant \"increaseddamage\" and \"increasehealing\".", + "prediction": "I don't think this is a good idea. I think it's better to have a separate `ItemParseAttributes_t` for each of these.", "reference": "variable names suggestions from me: - damageboost, ITEM_PARSE_DAMAGEBOOST, \"damage boost +x%\" - healingboost, ITEM_PARSE_HEALINGBOOST, \"healing power +y%\" - managainboost, ITEM_PARSE_MANAGAINBOOST, \"mana restoration +z%\" alternatively the other names can stay, because \"increase\" convention isn't that bad, just change mana values to: - \"increasemanarestored\", ITEM_PARSE_INCREASEMANARESTORED, \"mana restoration +z%\"" }, { - "prediction": "I'm not sure what you mean by \"has_all_data\" in this context.", + "prediction": "I'm not sure if this is a good idea, but I think we should have a default value for `has_all_data` as well.", "reference": "Why can't this be determined by 'PARTIAL_SUCCESS' in the `status` field?" }, { - "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way", "reference": "Does it make sense to generate a Exception here? Maybe yes, because it wouldn't make sense to generate a path without the id of the media right?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to create an instance of `SalesforceTLSSocketFactory` and then pass it to `SSLSocketFactory`. You can just use `SSLSocketFactory.getInstance(\"TLS\")` directly.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `SSLContext` class, so that we don't have to create a new `SSLSocketFactory` every time we create a new `SSLContext`.", "reference": "This should be made private." }, { - "prediction": "I'm not sure what you're trying to do here. The `BaseSVIDPath` is just the path to the base SVID file, and it's not used anywhere in the code. It's just a placeholder for the path to the base SVID file. If you want to use it, you can just set it to the path to the base SVID file, like this:\n```go\na.BaseSVIDPath = \"/path/to/your/base/svid\"\n```\nThis will set the `BaseSVIDPath` to `/path/to/your/base/svid`, which is the path to the base SVID file.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `BaseSVIDPath` field in the `Agent` struct.", "reference": "perhaps this is better modeled as a pkg-level var?" }, { - "prediction": "I think we can remove `#define MAX_PRECISION_ALLOWED 18` and `#define MAX_PRECISION_ALLOWED 38` as they are not used.", + "prediction": "I think it's better to use `MAX_PRECISION_ALLOWED` and `MAX_NUM_LEN` instead of `MAX_PRECISION_ALLOWED` and `HIVE_MAX_PRECISION_ALLOWED`.", "reference": "I don't think there is a maximum scale, neither for Hive nor for Trafodion. The only condition right now is that the scale can't exceed the precision. Example of a valid scale: DECIMAL(18,18). The maximum of 6 digits applies only to TIMESTAMP columns, where we don't support resolution below microseconds." }, { @@ -13827,19 +13827,19 @@ "reference": "`ctx` is unused in UpdateProjectStaticUser" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `JSTypeNameGenerator` class, since it's used in the `getDiscoveryDocUrl` method.", + "prediction": "I think this should be `getDiscoveryDocUrl(String apiName, String apiVersion)` instead of `getDiscoveryDocUrl(String apiName, String apiVersion, String format)`", "reference": "Why is this not the default, and why only for JS?" }, { - "prediction": "Shouldn't this be `repository` instead of `repository_id`?", + "prediction": "Shouldn't this be `validates :url, presence: true, uniqueness: { scope: :project_id }`?", "reference": "A repository has many badges so we should also add type column in scope." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `CodeFlows` property of the `CodeFlows` class.", "reference": "Now a hash set, so can't index into it." }, { - "prediction": "I think this should be `SymbolizeKeys` instead of `symbolize_top_level_keys`.", + "prediction": "I think this should be `SymbolizeTopLevelKeys` instead of `symbolize_top_level_keys`.", "reference": "@jpogran Does this seem like a reasonable way to know if we're in powershell vs. CMD or *sh?" }, { @@ -13847,35 +13847,35 @@ "reference": "1.toLowerCase(Locale.US)? 2.where is accept bug fix?" }, { - "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `assert_called_once_with` here. It's not clear to me if this is the right way to do this, but I think it's a good idea to use `assert_called_once_with` here. It's not clear to me if this is the right way to do this, but I think it's a good idea to use `assert_called_once_with` here. It's not clear to me if this is the right way to do this, but I think it's a good idea to use `assert_called_once_with` here. It's not clear to me if this is the right way to do this, but I think it's a good idea to use `assert_called_once_with` here. It's not clear to me if this is the right way to do this, but I think it's a good idea to use `assert_called_once_with` here. It's not clear to me if this is the right way to do this, but I think it's a good idea to use `assert_called_once_with` here. It's not clear to me if this is the right way to do this, but I think it", + "prediction": "I'm not sure if this is the right place to put this, but I think it would make sense to move it to `test_execute_with_custom_readme_content`.", "reference": "We should still be providing something to the user in the case of a `KeyError` instead of a stack trace!?" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get the nonce of the onBehalfOf contract. I think you should be using the `GetNonceAsync` method to get the nonce of the onBehalfOf contract.", "reference": "check Lukasz's fix with NonceReserving - is that not better?" }, { - "prediction": "I think this should be `this.colour_ = colour;` instead of `this.colour_ = colour; this.sourceBlock_.setColour(colour, this.sourceBlock_.getColourSecondary(), this.sourceBlock_.getColourTertiary());`", + "prediction": "I think it's better to set the primary, secondary and tertiary colour to `this.colour_` instead of `this.sourceBlock_.getColourSecondary()`, `this.sourceBlock_.getColourTertiary()` and `this.colour_`.", "reference": "Would you explain why here please? E.g. from the PR description > the renderer expects to be able to use the secondary color as the fill for a shadow." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bad idea to lock the `hd.lock.RLock()` and `hd.lock.RUnlock()` in the same function.", + "prediction": "I think this should be `if link, ok := hd.links[linkHash]; ok {` instead of `if link, ok := hd.links[linkHash]; ok {`", "reference": "Lock needs to go to `RecoverFromDb` instead. Here it may cause deadlocks. My convention was that un-exported functions do not lock, only exported ones (with name starting with a capital letter)" }, { - "prediction": "I don't think this is necessary.", + "prediction": "I don't think this is needed anymore.", "reference": "German keyboard would also be used in Austria and Switzerland, so this should have included `.at` and `.ch`." }, { - "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to have a separate `Indexer.Factory` for each bucket.", + "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to have a separate `Indexer.Factory` for each index type.", "reference": "since this makes the indexer thing really only used for a single table, now, you can put in a TODO for me to cleanup and simplify this" }, { - "prediction": "I'm not sure what you're trying to do with this, but it looks like you're trying to create a new `ContainerizedImpl` class that extends `KubernetesContainerizedImpl` and adds a new `HostPathType` and `NSCD_SOCKET_VOLUME_NAME` to the `ContainerizedImpl` class. I'm not sure what you're trying to do with this, but it looks like you're trying to create a new `ContainerizedImpl` class that extends `KubernetesContainerizedImpl` and adds a new `HostPathType` and `NSCD_SOCKET_VOLUME_NAME` to the `ContainerizedImpl` class. I'm not sure what you're trying to do with this, but it looks like you're trying to create a new `ContainerizedImpl` class that extends `KubernetesContainerizedImpl` and adds a new `HostPathType` and `NSCD_SOCKET_VOLUME_NAME` to the `ContainerizedImpl` class. I'm not sure what you're trying to do with this, but it looks like you're trying to create a new `ContainerizedImpl` class that extends `KubernetesContainerizedImpl` and adds a new `HostPathType` and `NSCD_SOCKET_VOLUME_NAME` to the `Containerized", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `KubernetesContainerizedImpl` class.", "reference": "Should we have this path passed from the Azkaban properties? If this is the standard path for nscd even outside LinkedIn, then we can keep it." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `mqttStreamName` in the `addStreamWithStore` function.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the stream name is the same as `mqttStreamName`. If it is, then we should use the MQTT store. Otherwise, we should use the default store.", "reference": "Could be a non-public field. `allowNoSubject`" }, { @@ -13891,35 +13891,35 @@ "reference": "Is it fine to pass the \"-o compression=on\" in the middle instead of at the end ?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `load_config` option to the `Bolt::TRANSPORTS` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `load_config` option to `Bolt::TRANSPORTS` so that we don't have to call `load_config` every time we create a new `Bolt::TRANSPORT` instance.", "reference": "Probably make them all keyword arguments." }, { - "prediction": "I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place", + "prediction": "I'm not sure if this is the best place to do this, but I think it's a good place to do this.", "reference": "Why not just check the backdrop setting here as well for the time being? We can combine the code later but at least then it would be configurable if people like the backgrounds." }, { - "prediction": "I think this should be `public override bool IsCamelCase => true;` instead of `public override Category Severity => Category.Error;`", + "prediction": "I don't think this is a good idea. I think it's better to have a separate property for this.", "reference": "why are we turning this one into a Warning?" }, { - "prediction": "I'm not sure what you mean by \"separate files\", but I think it should be \"separated files\" or \"separately\".", + "prediction": "I'm not sure I understand what you're trying to do here.", "reference": "Wouldn't it be better to use double quotes for the opening parenthesis ?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `savePlayer` method, since it's the only place where the player's `blessings` are stored.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `to_ulong()` function to convert the `uint32_t` to a `uint64_t` and then use the `to_string()` function to convert the `uint64_t` to a `std::string`.", "reference": "Remove the cast" }, { - "prediction": "I'm not sure if this is the right place for this change, but I think it's a good idea to add a comment explaining the purpose of this change.", + "prediction": "I'm not sure if this is the right place for this change, but I think we should move it to the top of the file.", "reference": "What criteria do we use to bump the copyright years? An update to the module?" }, { - "prediction": "I don't think this is a good idea. It's not clear to me why we would want to do this.", + "prediction": "I don't think this is a good idea.", "reference": "should we rm line 269?" }, { - "prediction": "I think this should be `queueHandler.queueFunction(queueHandler.eventQueue, lambda: setattr(self, '_isNvdaStartupComplete', True))` instead of `queueHandler.queueFunction(queueHandler.eventQueue, lambda: setattr(self, '_isNvdaStartupComplete', True))`", + "prediction": "I think this should be `queueHandler.queueFunction(queueHandler.eventQueue, lambda: setattr(self, '_isNvdaStartupComplete', True))`", "reference": "Perhaps the code at `source/core.py:564: postNvdaStartup.notify()` should be queued instead? If we are saying the loop must have started before NVDA's startup is complete, then the `postNvdaStartup` action is incorrect." }, { @@ -13927,23 +13927,23 @@ "reference": "Needed this for testing locally with mail view but not used for any tests. Might be nice to have some seed scripts at some point." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `Transport` struct as well.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to move this into the `Transport` struct. It's not clear to me why we need to do this in the `Outbound` struct.", "reference": "wait, if we only do this for successful status codes won't we miss a whole slew of responses? We should be checking this for all codes right?" }, { - "prediction": "I think this should be `model = CodegenTestUtil.readModel(testDataLocator, tempDir, protoFiles, new String[0]);`", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `test/src/main/java/com/google/protobuf/io/printer/PrinterTest.java` file.", "reference": "Adding in the service yaml `library.yaml` here." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the upstream middleware, so that the upstream middleware knows about the authenticated user.", "reference": "Why is this dereference needed?" }, { - "prediction": "I'm not sure I understand what you're trying to do with this. Is it possible to have a `readonlyNode` and a `repoNode` in the same directory? If so, how do you know which one to use?", + "prediction": "I'm not sure I understand what you're trying to do here. Is it that you want to create a `readonlyNode` and a `repoNode` at the same time? If that's the case, why not just use `readonlyNode` and `repoNode`?", "reference": "Might want to add that this only happens if you have write permissions to the folder." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a good idea to add a `ShouldRetry` field to the `EndpointResolver` struct.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have the `ShouldRetry` field set to `true` by default. This way, if the request is not retryable, the request will be retried anyway.", "reference": "Adding a small blurb about why someone would want to enable this flag would help clarify what it is for. Such as something about when providing a custom retry handler and how`ShouldRetry` will be handled with and without the flag enabled." }, { @@ -13951,7 +13951,7 @@ "reference": "assume the user will be able to register for a custom service name in future?" }, { - "prediction": "I think this should be `using pwiz.Skyline.Util;` instead of `using pwiz.Skyline.Util;`", + "prediction": "I don't think this should be here. It should be in `pwiz.Skyline.Util`.", "reference": "The extra two empty lines seem unnecessary. Please review your diffs more carefully." }, { @@ -13959,7 +13959,7 @@ "reference": "What the reason to embed the Oracle?" }, { - "prediction": "I'm not sure what you're trying to achieve with this route, but it looks like you're trying to create a new topic in the \"new-topics\" page. I'm not sure what you're trying to achieve with this route, but it looks like you're trying to create a new topic in the \"new-topics\" page. I'm not sure what you're trying to achieve with this route, but it looks like you're trying to create a new topic in the \"new-topics\" page. I'm not sure what you're trying to achieve with this route, but it looks like you're trying to create a new topic in the \"new-topics\" page. I'm not sure what you're trying to achieve with this route, but it looks like you're trying to create a new topic in the \"new-topics\" page. I'm not sure what you're trying to achieve with this route, but it looks like you're trying to create a new topic in the \"new-topics\" page. I'm not sure what you're trying to achieve with this route, but it looks like you're trying to create a new topic in the \"new-topics\" page. I'm not sure what you're trying to achieve with", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate route for the new-topics page. I think it would be a good idea to have a separate route for the new-topics page. I think it would be a good idea to have a separate route for the new-topics page. I think it would be a good idea to have a separate route for the new-topics page. I think it would be a good idea to have a separate route for the new-topics page. I think it would be a good idea to have a separate route for the new-topics page. I think it would be a good idea to have a separate route for the new-topics page. I think it would be a good idea to have a separate route for the new-topics page. I think it would be a good idea to have a separate route for the new-topics page. I think it would be a good idea to have a separate route for the new-topics page. I think it would be a good idea to have a separate route for the new-topics page. I think it would be a good idea to have a separate route for the new-topics page. I think", "reference": "Shouldn't this happen automatically with High Voltage?" }, { @@ -13967,43 +13967,43 @@ "reference": "This is changed because we need `projectId` to be printed as `$projectId` in PHP." }, { - "prediction": "I'm not sure what you mean by \"template customisation history\". Is this the same as \"template history\"?", + "prediction": "I don't think we need to add the `class: \"btn btn-primary\"` here.", "reference": "This title change seems more accurate to me however not sure if this will confuse users." }, { - "prediction": "I'm not sure what you're trying to achieve with this regex, but I think it's a good idea to use it. It's a good way to check if the value is a Wikipedia URL.", + "prediction": "I'm not sure what you're trying to do with this regex, but I think it's a bit too restrictive. It's possible to have a URL like `http://en.wikipedia.org/wiki/Full%20URL` and still be able to match `http://en.wikipedia.org/wiki/Full%20URL`.", "reference": "Here (and on line 158 as well), would it be more efficient to use the String end_with() method? Not tested" }, { - "prediction": "I don't think this is a good idea.", + "prediction": "I don't think this is necessary.", "reference": "Why are you creating a new (second) `RAMHandler` here? Is this just an oversight from deleting the previous code?" }, { - "prediction": "`if (req.get_if_not_exists())` should be `if (!req.get_if_not_exists())`", + "prediction": "I don't think this is a good idea. If you want to check if the index already exists, you should use `getEdgeIndexID` instead of `getEdgeIndexIDIfNotExists`.", "reference": "Move the line 27 to line 31 is better?" }, { - "prediction": "I think this should be `if len(appliedRevs) > 0 {` instead of `if rmd.IsRekeySet() {`", + "prediction": "I think we should remove the `if rmd.IsRekeySet() { ... }` block.", "reference": "In slack I mentioned we should only do this if the update is from some other device, to make sure our own updates don't cause issues. Maybe the revision check above is good enough to prevent this, but I just want to make sure you thought about it." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to run specs in a random order, but I'm not sure what you're trying to do with the `--seed` option. I'm not sure what you're trying to do here. I think you're trying to run specs in a random order, but I'm not sure what you're trying to do with the `--seed` option. I'm not sure what you're trying to do here. I think you're trying to run specs in a random order, but I'm not sure what you're trying to do with the `--seed` option. I'm not sure what you're trying to do here. I think you're trying to run specs in a random order, but I'm not sure what you're trying to do with the `--seed` option. I'm not sure what you're trying to do here. I think you're trying to run specs in a random order, but I'm not sure what you're trying to do with the `--seed` option. I'm not sure what you're trying to do here. I think you're trying to run specs in a random order, but I'm not sure what you're trying to do", "reference": "I would instead explain that random is the default, but you can switch back to defined, or another ordering scheme." }, { - "prediction": "I think it's better to use `style.getPropertyValue('height') === 0` instead of `parseInt(style.getPropertyValue('height')) === 0`.", + "prediction": "I think this should be `if (!screenReader && (isClipped(style) || style.getPropertyValue('opacity') === '0' || (getScroll(el) && parseInt(style.getPropertyValue('height')) === 0) || (style.getPropertyValue('position') === 'absolute' && elHeight <= 1 && style.getPropertyValue('overflow') === 'hidden'))) { return false; }`", "reference": "Is there a reason you left this at 0?" }, { - "prediction": "I'm not sure what you mean by \"key == null\"", + "prediction": "I don't think this is necessary. The `HttpSecurityBuilder` has a `getRememberMeServices()` method that returns the `RememberMeServices` object.", "reference": "The value of `key` will never be `null` at this point, because `getKey()` will generate a value if it is `null`." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to create a new scope for this trace, so that we don't have to create a new scope every time we create a new trace.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `DbType` property to the `TraceScope` class.", "reference": "NIT: You should first check if AdoNetExcludedTypes.Count is greater than 0 before calling Contains (fast-path)" }, { - "prediction": "I don't think this is necessary. We can just use `resource.Quantity` instead of `resource.Float64` in this case.", + "prediction": "I don't think this is necessary. We can just use `resource.Quantity` instead of `resource.Quantity` in this case.", "reference": "should rearrange so as to follow import ordering." }, { @@ -14011,27 +14011,27 @@ "reference": "what is the use case for create workflow with completed state?" }, { - "prediction": "I think this should be `org.openqa.grid.distributor.remote.RemoteDistributorTest` instead of `org.openqa.selenium.grid.distributor.remote.RemoteDistributorTest`", + "prediction": "I think this should be `RemoteDistributorTest.class` instead of `org.openqa.selenium.grid.distributor.remote.RemoteDistributorTest.class`", "reference": "Probably best not to have an empty test...." }, { - "prediction": "I think we can remove the `Kokkos::Tools::finalize()`.", + "prediction": "I think this is a good change, but I'm not sure if it's the best way to do it.", "reference": "Missing the license" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this.", "reference": "Looks like this was previously guarded by `EnableCleanupReplicationTask` flag. Now looks like this is always needed. Just want to confirm the intention is if `GlobalNamespace` is enabled then we want run cleanupReplicationTasks in all cases?" }, { - "prediction": "I think we can remove the `#include ` and `#include `.", + "prediction": "I think we should remove `#include ` and `#include `.", "reference": "Potentially it'll be good to remove all of them excluding \"tbb/tbb.h\" But let's do it next time" }, { - "prediction": "I think this should be `low`, `high`, `density`, and `invert` instead of `low`, `high`, `invert`, and `density`.", + "prediction": "I think this should be `if not density:` instead of `if vals[0] > vals[1]:`", "reference": "I would just mention which tolerance - namely as reported by ``sys.float_info``" }, { - "prediction": "I'm not sure what you're trying to do here. The `@approved_data` should be `@approved_data = self.listing.approved.alter_query{ |rel| rel.limit(@CLOSED_PROPOSAL_LIMIT) }`", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea.", "reference": ":+1: Ideally this'll become something you could pass in to the config" }, { @@ -14039,35 +14039,35 @@ "reference": "Should using `thenValue` to replace `then` ?" }, { - "prediction": "I'm not sure what you mean by \"integration disabled\". Is it possible that this is just a typo?", + "prediction": "I'm not sure what you mean by \"integration disabled\". Is it possible that this is because the `OnError` method is called from a different thread than the `OnTrace` method? If so, we should make sure that the `OnError` method is called from the same thread as the `OnTrace` method.", "reference": "This follows the convention of each callback starting with the `IsIntegrationEnabled` check." }, { - "prediction": "I'm not sure what you mean by `isDeltaValue` and `isMonotonicValue`. I think you meant `isDeltaValue` and `isMonotonicValue`", + "prediction": "I don't think this is necessary.", "reference": "this is not required to be part of this PR right? (With UpDownCounter being absent in .NET, we can make this hardcoded for now, i think)" }, { - "prediction": "I think this should be `OnConnection(IConnectionInformation connectionInfo, IScheduler inputWriterScheduler, IScheduler outputReaderScheduler)`", + "prediction": "I think this should be `public interface IConnectionHandler` instead of `public interface IConnectionHandler`", "reference": "Add the PipeFactory here" }, { - "prediction": "I don't think this is a good idea. It would be better to have a separate implementation of the `callAccordingToAction` method.", + "prediction": "I don't think we need to change the type of `implVal` to `reflect.ValueOf(i.impl)`. We can just use `reflect.ValueOf(i.impl)`.", "reference": "please add `var _ impltypes.ChaosImpl = (*Delegate)(nil)`" }, { - "prediction": "I'm not sure I understand what you're trying to achieve with this method. It seems like you're trying to expire snapshots without any cleanup of underlying manifest or data files, but I'm not sure if that's what you're trying to achieve with this method.", + "prediction": "I'm not sure I understand what you're trying to do here.", "reference": "nit: is this added deliberately?" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to stub out the `get` request to `http://api.hostip.info/country.php?ip=0.0.0.0`, but it's not working.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `stub_request` here.", "reference": "Given the number of tests which need this (I think I counted seven) should we maybe just install this one globally? Is there even a place to do that? Something in `test_helper` maybe?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `filterOptions` function.", + "prediction": "I think this should be `isPromise` instead of `isPromiseLike`", "reference": "we don't use this anymore, so we can delete it." }, { - "prediction": "I think we can remove the `logging.TelemetryOverride(*telemetryOverride)` line and just use `logging.EnableTelemetry()` instead.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate file for the telemetry config.", "reference": "nit: change to \"Telemetry configuration loaded from '%s'\"" }, { @@ -14075,11 +14075,11 @@ "reference": "Why did this value change?" }, { - "prediction": "I'm not sure if this is a good idea. I think we should use `duckv1alpha1` instead of `duckv1`.", + "prediction": "I'm not sure what you mean by this. I think it's just a typo.", "reference": "maybe `duckpubsubv1alpha1` ?" }, { - "prediction": "I think this should be `manifest` instead of `manifest.json`?", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to parse the manifest.json file and extract the `id`, `version`, and `name` from it. I'm not sure what you're trying to do here, but it looks like you're trying to parse the manifest.json file and extract the `id`, `version`, and `name` from it. I'm not sure what you're trying to do here, but it looks like you're trying to parse the manifest.json file and extract the `id`, `version`, and `name` from it. I'm not sure what you're trying to do here, but it looks like you're trying to parse the manifest.json file and extract the `id`, `version`, and `name` from it. I'm not sure what you're trying to do here, but it looks like you're trying to parse the manifest.json file and extract the `id`, `version`, and `name` from it. I'm not sure what you're trying to do here, but it looks like you're trying to parse the manifest.json file and extract the `id`, `version`, and `name` from it. I'm not sure what you're trying to do", "reference": "The id is not mandatory for web extensions. Could you update this to support a web extension without an id?" }, { @@ -14091,7 +14091,7 @@ "reference": "I think this should've been done with the `defer`-named-return trick. I'll submit a PR for it." }, { - "prediction": "I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the websocket server is running before we try to connect to it. This way, if the websocket server is not running, we won't try to connect to it.", "reference": "The bind address should be configurable." }, { @@ -14099,7 +14099,7 @@ "reference": "Maybe the empty `delete()` should be implemented as default in the interface." }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.", + "prediction": "I don't think this is a good idea. It's not clear to me what the purpose of this file is, and it's not clear to me what the purpose of this file is, and it's not clear to me what the purpose of this file is, and it's not clear to me what the purpose of this file is, and it's not clear to me what the purpose of this file is, and it's not clear to me what the purpose of this file is, and it's not clear to me what the purpose of this file is, and it's not clear to me what the purpose of this file is, and it's not clear to me what the purpose of this file is, and it's not clear to me what the purpose of this file is, and it's not clear to me what the purpose of this file is, and it's not clear to me what the purpose of this file is, and it's not clear to me what the purpose of this file is, and it's not clear to me what the purpose of this file is, and it's not clear to me what the purpose of this file is, and it's not clear to me what the purpose of this file is, and it's not clear to me", "reference": "How to ensure CMAKE_SOURCE_DIR is set correctly?" }, { @@ -14107,7 +14107,7 @@ "reference": "safer to make a copy of incoming *big.Int" }, { - "prediction": "I don't think we need to set this to `10 * time.Minute` as it's already set to `10 * time.Minute` by default. We can just set it to `10 * time.Second` instead.", + "prediction": "I don't think we need to change `ListImagesTimeout` to `10 * time.Minute` because it's already set to `10 * time.Minute` by default.", "reference": "how did we choose this value? does this hold good for Windows too?" }, { @@ -14115,19 +14115,19 @@ "reference": "To follow the other build tags, maybe we can call it `criu`?" }, { - "prediction": "I'm not sure what you mean by \"connect_timeout\". Is it the timeout for the connection to the server? If so, it should be set to 10 seconds. Otherwise, it should be set to 30 seconds.", + "prediction": "I'm not sure what you mean by `insecure` and `password` in the `TRANSPORT_DEFAULTS` block. I think `insecure` should be `false` and `password` should be `true`.", "reference": "Should we load this from the config file too?" }, { - "prediction": "I don't think this is a good idea. It's not clear to me why we would want to do this. I'm not sure if it's a good idea to do this, but I don't think it's a good idea to do this.", + "prediction": "I don't think we need to do this.", "reference": "Can you file an issue for this?" }, { - "prediction": "I'm not sure what you mean by `this[kIsMaster] == null`. I think you meant to say `this[kIsMaster] === null`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `this[kIsMaster] == null` in the `beforeHandshake` callback.", "reference": "@nbbeeken what were the cases where `!!this[kIsMaster]` was yielding an incorrect value? we should try to cover them in the tests" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do it.", + "prediction": "I think this should be `Bolt::Util.symbolize_top_level_keys` instead of `Bolt::Util.symbolize_top_level_keys(inventory['config']['transports'])`", "reference": "This whole function feels messy. I don't have a better idea at the moment though." }, { @@ -14135,11 +14135,11 @@ "reference": "should use Number instead of Long" }, { - "prediction": "I think this should be `func (m *MockProvider) WriterFor(ctx context.Context, conf influxdb.Config) (influxdb.Writer, error)`", + "prediction": "I think this should be `func (m *MockProvider) WriterForFn(ctx context.Context, conf influxdb.Config) (influxdb.Writer, error)`", "reference": "Can you rename this and the file `InfluxDBProvider` and `influxdb_provider.go` respectively?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `vchildren` in this case.", + "prediction": "I'm not sure what you mean by `len !== 0` here. I think you meant to say `len > 0`.", "reference": "This is the real culprit, as now vlen will always be a Number (and known to the compiler as such). You could probably go one step further and avoid the ToBoolean on `vchildren` as well by writing something like `vlen = (vchildren !== undefined) ? vchildren.length : 0` if that matches the contract." }, { @@ -14151,15 +14151,15 @@ "reference": "so this attribute is used as u8 in code, but saves as int32? Why?" }, { - "prediction": "I'm not sure what you mean by \"Map class to Cap'n Proto schema union attribute\". Could you please provide more context?", + "prediction": "I don't think we need to change this, but I'm not 100% sure that this is the right way to do it.", "reference": "can RDSE be added to the list? It has its capnp files." }, { - "prediction": "I'm not sure I understand what you're trying to do here. You're trying to create a `certificateToInjectableFunc` that maps from certificates to the given type of injectable, but you're not using the `buildCertToInjectableFunc` function anywhere. Is this what you're trying to do?", + "prediction": "I'm not sure I understand what you're trying to do here. You're trying to create a `certificateToInjectableFunc` that maps from certificates to the given type of injectable, but I don't think that's what you're trying to do. You're trying to create a `certificateToInjectableFunc` that maps from certificates to the given type of injectable, but I don't think that's what you're trying to do. You're trying to create a `certificateToInjectableFunc` that maps from certificates to the given type of injectable, but I don't think that's what you're trying to do. You're trying to create a `certificateToInjectableFunc` that maps from certificates to the given type of injectable, but I don't think that's what you're trying to do. You're trying to create a `certificateToInjectableFunc` that maps from certificates to the given type of injectable, but I don't think that's what you're trying to do. You're trying to create a `certificateToInjectableFunc` that maps from certificates to the given type of injectable, but I don't think that's what you're trying to do. You're trying to create a `certificate", "reference": "These functions only ever read from the API and should always be reading from a cache, so I have made that explicit by expecting a Reader here and supplying a `cache.Cache` as the client." }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to set the translation_mangling_epilogue to true.", + "prediction": "I'm not sure if this is a good idea, but I think it's better to do this in the `check_return_handle_call` function.", "reference": "No, we can't skip any of the mangling after the suspend point: this should follow the other mangling and undo its push." }, { @@ -14167,79 +14167,79 @@ "reference": "this is generated code.. these changes will need to be made in the code generator to have them stick." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `document.body.attachShadow` in this case.", + "prediction": "I'm not sure what you mean by `data` in this context. I think you meant to say `data: function (d) { ... }` or `data: function (d) { return d; }`?", "reference": "Should we abstract this into a reusable utility so it doesn't have to get repeated in every test file needing Shadow DOM support?" }, { - "prediction": "I don't think this is necessary. We can just use the `loadSpecTests` function directly.", + "prediction": "I don't think we need to change this, but I'm not 100% sure about this one.", "reference": "Maybe we rename this to `command_monitoring.test.js` to match the directory name change? Or would you rather do that as part of the greater test cleanup? I'm fine either way." }, { - "prediction": "I think it's better to use `String` here instead of `String[]`?", + "prediction": "`String` is not a valid type for `$options` in this case.", "reference": "Why is this change necessary? `handleSingle()` will cast it to a string, no?" }, { - "prediction": "I'm not sure what you mean by \"return the name of this table.\"", + "prediction": "I don't think this is needed anymore.", "reference": "This newly added method should be well defined, should it return `TableIdentifier` or just `String`?" }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. Is it that you want to add a message to the `ProductMultimediaRelationshipStrategy`? Or is it that you want to add a message to the `RelationshipStrategyInterface`? If the first is the case, then I think it's better to just add a message to the `RelationshipStrategyInterface`. If the second is the case, then I think it's better to just add a message to the `ProductMultimediaRelationshipStrategy`.", + "prediction": "I don't think this is needed.", "reference": "have a relation with a product" }, { - "prediction": "I think we can remove the `if k8sInfra.PodExist(\"default\", name)` check.", + "prediction": "I think it's better to use `k8sInfra.K8sClient.CoreV1().Pods(\"default\").Delete(name, &metav1.DeleteOptions{})` instead of `k8sInfra.K8sClient.CoreV1().Pods(\"default\").Delete(name, &metav1.DeleteOptions{})`", "reference": "I guess that there is still a window here, because the GC could happen between the `PodExist` and `Delete` calls. Would it be better instead to check `err` and allow it if it says \"pod has already been deleted\"?" }, { - "prediction": "I think we can remove the `with session.transaction:` and `session.commit()`.", + "prediction": "I think this should be `session.commit()` instead of `session.rollback()`.", "reference": "SQLAlchemy's session management does magic to make sure that if the rollback fails you still get the original exception that caused the rollback. Also it looks nicer." }, { - "prediction": "I think it's a good idea to add a check for `act.GetTransfer()` and `act.GetVote()` to make sure we don't try to convert an action that doesn't have a `Transfer` or `Vote` field.", + "prediction": "I think we can remove the `if act.GetTransfer() != nil` check.", "reference": "This switch statement can be removed. Just return q.items[act.Nonce] != nil" }, { - "prediction": "I'm not sure what you mean by \"it is the second child of a ForStatement\"", + "prediction": "I'm not sure I understand what you're trying to do here. Is it that you want to avoid allocating an object for each iteration of a `for-each` loop?", "reference": "I think `==` for nodes is more readable than equals. An equals calls looks like it could be recursing, because intuitively two nodes are equal if their subtree are the equal. But everywhere you replaced, we don't want to test whether the subtrees are structurally equal, we want to know whether they're the same. Only `==` captures this intent, using equals obscures this. Not to mention that equals may NPE and is in that sense less ergonomic. I think we should enhance the rule with a list of types for which `==` is correct. Edit: in the meantime i think we could suppress those new violations..." }, { - "prediction": "I'm not sure what you mean by \"filtering by name using glob pattern(s)\". Could you please provide more context?", + "prediction": "I don't think this is a good idea. It's not clear to me what the purpose of this option is.", "reference": "What's the scenario for passing multiple filters?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `iter->valid()`, so that we don't crash if we don't have a valid iterator.", + "prediction": "I don't think we need to do this. The `logEntry` is a `std::vector` of `std::tuple`. We can just use `std::get<0>()` and `std::get<1>()` to get the `logId` and `logTerm` from the `logEntry`.", "reference": "move to after check log.empty()" }, { - "prediction": "I'm not sure what you mean by \"web interface\" here. Is this the same as \"web interface\" in the rest of the code?", + "prediction": "I don't think this is necessary.", "reference": "This line needs to be removed" }, { - "prediction": "I think this should be `CloudBuildSourceBuildStatus` instead of `CloudBuildSourceBuildId`?", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `cloudbuild` package.", "reference": "Can we delete such const like `CloudBuildSourceEvent` and `CloudBuildSourceBuildId` since all those are contained under schemas/v1?" }, { - "prediction": "I think this should be `Name string = \"vsphere\"` instead of `Name string = \"vsphere\"`.", + "prediction": "I think this should be `+k8s:deepcopy-gen=package,register` instead of `+k8s:conversion-gen=github.com/openshift/hive/pkg/apis/hive`", "reference": "This is unused." }, { - "prediction": "I think this should be a property, not a method.", + "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to use the `CompositePropagator` to create a new instance of `ITextFormat` and pass it to the `SetHttpFlavor` method. I'm not sure what you're trying to do here, but it seems like you're trying to use the `CompositePropagator` to create a new instance of `ITextFormat` and pass it to the `SetHttpFlavor` method. I'm not sure what you're trying to do here, but it seems like you're trying to use the `CompositePropagator` to create a new instance of `ITextFormat` and pass it to the `SetHttpFlavor` method. I'm not sure what you're trying to do here, but it seems like you're trying to use the `CompositePropagator` to create a new instance of `ITextFormat` and pass it to the `SetHttpFlavor` method. I'm not sure what you're trying to do here, but it seems like you're trying to use the `CompositePropagator` to create a new instance of `ITextFormat` and pass it to the `SetHttpFl", "reference": "Any reason not to put `using System.Collections.Generic` (guess there shouldn't be naming conflicts)?" }, { - "prediction": "I think this should be `response.headers.delete(\"X-Frame-Options\")` instead of `response.headers.delete(\"X-Frame-Options\")`", + "prediction": "I think this should be `@video = Video.find(params[:video_id])` instead of `response.headers.delete(\"X-Frame-Options\")`", "reference": "Could the name of this controller just be shortened to `TwitterCardsController`? Is the `Player` there adding information?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to add a `Dynamic` field to the `UpstreamHost` struct. This will allow us to determine if the upstream is dynamic or not.", + "prediction": "I don't think we need to check for `uh.Fails >= u.MaxFails` here, since it's already checked by `uh.Unhealthy` and `uh.Fails >= u.MaxFails`.", "reference": "Backends with hostnames that depend on the request are always up?" }, { - "prediction": "I don't think this is a good idea. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me", + "prediction": "I don't think this is necessary. `colander` has a `JsonPatchException` which is a subclass of `pyramid.exceptions.PyramidException` and `pyramid.exceptions.JSONPointerException` which is a subclass of `pyramid.exceptions.PyramidException`.", "reference": "I'd rather catch those to `utils.py` and raise a simple ValueError from them. From the resource point of view, these are details of implementation" }, { - "prediction": "I don't think this is necessary. We can just use `julia` instead of `julia:release`.", + "prediction": "I don't think this is necessary. We can just use `julia` as the default.", "reference": "make this 1.0 ? I don't think all that many people do `language: julia` without any `julia:` specifiers, but may as well keep that possible?" }, { @@ -14247,35 +14247,35 @@ "reference": "nit: `AZURE_KEYVAULT_AUTH_VIA_CLI` is defined by us, so it might be helpful to differentiate it from azure's env names. Maybe starts with `GOCDK`." }, { - "prediction": "`sessionManager` should be `sessionManager` instead of `sessionManagerManager`", + "prediction": "I don't think we need to use `make(map[session.SessionID]int)`, we can just use `make(map[int]session.SessionID)`.", "reference": "Depend on interfaces not on structures" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `storage_server.c` file, since it's not in the `storage_server.h` header file.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the storage server's `stop` method.", "reference": "This fix looks good. My concern, don't forget to fix metad too!" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `makeMDJournalWithIDJournal` function as well. It's not clear to me why we need to do this in the `makeMDJournalWithIDJournal` function.", + "prediction": "I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place", "reference": "Just noticed this nil context. Perhaps plumb through ctx too, or change to `Debug`?" }, { - "prediction": "I don't think we need to change the default headers.", + "prediction": "I don't think this is necessary.", "reference": "Does it send requests with urlencoded bodies anywhere? I thought it sends only json. Maybe content-type should be `application/json` by default?" }, { - "prediction": "I think this should be `c_EntityId_RTPSParticipant` instead of `c_EntityId_RTPSParticipant`.", + "prediction": "I think it's better to use `guidPrefix` instead of `c_EntityId_RTPSParticipant` in this case.", "reference": "Again use of `constexpr` is recomended." }, { - "prediction": "I'm not sure what you're trying to achieve with this extension, but I think it's a good idea to add a docstring to it.", + "prediction": "I'm not sure if this is a good idea, but I think it would be a good idea to add a `layout` argument to the `redim` utility, so that you can specify the layout algorithm to use.", "reference": "Minor point but I would call this ``redim_graph`` instead." }, { - "prediction": "I'm not sure if this is the best place to put this, but I think we should move it to `cluster-api/pkg/controller/noderefutil` so that it can be used by `cluster-api/pkg/controller/noderefutil` and `cluster-api/pkg/controller/noderefutil/noderefutil` as well.", + "prediction": "I'm not sure if this is a good place to put it, but I think we should move it to `cluster-api/pkg/controller/noderefutil` so that it can be used by `cluster-api/pkg/controller/noderefutil` and `cluster-api/pkg/controller/noderefutil/controller` as well.", "reference": "As I was trying to figure out how the error messages are written out, since they are returned from `getOrCreate` and `reconcile`, it looks like we are using plain `klog` to write them out instead of using the logger from the scope above" }, { - "prediction": "I'm not sure if this is the best place to do this, but I think it's a good place to do this.", + "prediction": "I don't think we need to do anything here.", "reference": "Now it's double logging, is not it? Because `service.ipForward.Enable()` logs extra `warning`" }, { @@ -14283,15 +14283,15 @@ "reference": "Whatever the decision is about the request type to use, this should only match what is needed and not the other one." }, { - "prediction": "I'm not sure what you mean by \"always update previews for output connections.\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do it in the `handleDragFree_` method.", "reference": "...and in turn, this should probably be var updatePreviews = true; if (!(localConnection && localConnection.type == Blockly.OUTPUT_VALUE) && (Blockly.localConnection_ && Blockly.highlightedConnection_)) { since the first clause is a no-op. If you want to leave it this way for clarity, that's fine too." }, { - "prediction": "I'm not sure I understand what you're trying to do here. Can you please provide some more context?", + "prediction": "I'm not sure what you mean by `force_rebuild=False` here. Is it because you want to rebuild the rule book? If that's the case, I'm not sure I understand what you're trying to do here.", "reference": "Please remove this TODO, since they will not apply anymore after you are done. :) Can you please remove this everywhere else in this PR?" }, { - "prediction": "I'm not sure what you mean by \"clashes with datatype\" in this case. I think you meant \"clashes with enum\" or \"clashes with union\" or \"clashes with namespace\" or \"clashes with table\" or \"clashes with struct\" or \"clashes with union\" or \"clashes with namespace\" or \"clashes with table\" or \"clashes with struct\" or \"clashes with union\" or \"clashes with namespace\" or \"clashes with table\" or \"clashes with struct\" or \"clashes with union\" or \"clashes with namespace\" or \"clashes with table\" or \"clashes with struct\" or \"clashes with union\" or \"clashes with namespace\" or \"clashes with table\" or \"clashes with struct\" or \"clashes with union\" or \"clashes with namespace\" or \"clashes with table\" or \"clashes with struct\" or \"clashes with union\" or \"clashes with namespace\" or \"clashes with table\" or \"clashes with struct\" or \"clashes with union\" or \"clashes with namespace\" or \"clashes with table\" or \"clashes with struct\" or \"clashes", + "prediction": "I'm not sure what you mean by \"clashes with datatype\". I think you meant \"clashes with enum\" or \"clashes with namespace\".", "reference": "This seems like an incomplete schema definition. will that have any effect on the tests?" }, { @@ -14299,47 +14299,47 @@ "reference": "The testing cases are failing because `SetHeader` does not only handle cases where input are from files. It also reads categorical feature indices from the config parameters (see the part outside the `if (filename != nullptr) { ... }`). Skipping `SetHeader` directly here will cause errors when we load data from numpy or pandas arrays (where `filename == nullptr`) and use categorical features. So I think we should move the the check `filename != nullptr && CheckCanLoadFromBin(filename) == \"\"` into `SetHeader`. That is, we change `if (filename != nullptr) { ... }` into `if (filename != nullptr && CheckCanLoadFromBin(filename) == \"\") { ... }`" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `process` package.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.", "reference": "I think we should change the variable name of `err` in `if err, ok := err.(*exec.ExitError); ok `, this re-assignment of `err` still affects the next `else` branch" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to `MetaClient.cpp` instead of `MetaClient.h` because `MetaClient.h` is a header file and `MetaClient.cpp` is a source file. Also, I think we should move this to `MetaClient.cpp` because `MetaClient.h` is a header file and `MetaClient.cpp` is a source file. Also, I think we should move this to `MetaClient.cpp` because `MetaClient.h` is a header file and `MetaClient.cpp` is a source file. Also, I think we should move this to `MetaClient.cpp` because `MetaClient.h` is a header file and `MetaClient.cpp` is a source file. Also, I think we should move this to `MetaClient.cpp` because `MetaClient.h` is a header file and `MetaClient.cpp` is a source file. Also, I think we should move this to `MetaClient.cpp` because `MetaClient.h` is a header file and `MetaClient.cpp` is a source file. Also, I think we should move this to `MetaClient.cpp` because `MetaClient.h` is a header file and `", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to `MetaClient::listSpaces` so that we don't have to call `getResponse` every time we call `addHosts`.", "reference": "`Status` has identical semantics with `StatusOr`." }, { - "prediction": "I don't think we need to add this to the list of allowed paths. I think we should remove it from the list of allowed paths.", + "prediction": "I'm not sure if this is a good idea, but I think we should add this to the list of allowed paths.", "reference": "why is this named in a different style from other paths?" }, { - "prediction": "I think we can remove the `if cluster == nil` check.", + "prediction": "I think we can remove the `if cluster == nil` check here.", "reference": "Swapped these to ensure that we aren't passing a nil cluster in to util.IsPaused" }, { - "prediction": "I don't think it's necessary to have a separate package for this. We can just use the same package for all of them.", + "prediction": "I don't think we need to change this. It's just a list of tuples.", "reference": "I don't see pkgManager used anywhere, is there a reason we need this?" }, { - "prediction": "I'm not sure what you're trying to do here. The `instanceDir` is just the path to the instance directory. It's not used anywhere else in the code.", + "prediction": "I think this should be `instanceDir.toFile()` instead of `instanceDir.toAbsolutePath()`.", "reference": "A bit late, but I don't think this is necessary, as all callers will send absolute paths. And if you ever get a relative path, resolving it with `toAbsolutePath()` leads to it being relative to whatever CWD the app is started with, while the typical resolving of relative `instanceDir` is to resolve it relative to CoreContainer#coreRootDirectory." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get the `getters` from the `localFieldPathType` object, but you're not using the `getters` property of the `localFieldPathType` object. I'm not sure what you're trying to do here, but it looks like you're trying to get the `getters` from the `localFieldPathType` object, but you're not using the `getters` property of the `localFieldPathType` object. I'm not sure what you're trying to do here, but it looks like you're trying to get the `getters` from the `localFieldPathType` object, but you're not using the `getters` property of the `localFieldPathType` object. I'm not sure what you're trying to do here, but it looks like you're trying to get the `getters` from the `localFieldPathType` object, but you're not using the `getters` property of the `localFieldPathType` object. I'm not sure what you're trying to do here, but it looks like you're trying to get the `getters` from the", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the `getModelsMapForPopulate` function, so that we don't have to do this every time we want to populate a model.", "reference": "There's an awful lot of test failures here because `localFieldPathType.schema` may not contain a `getters` array." }, { - "prediction": "I think this should be `if ActiveRecord::Base.connection.adapter_name == \"Mysql2\"` instead of `if ActiveRecord::Base.connection.adapter_name == \"Mysql2\"`.", + "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `eval` here. If you want to use `eval`, you can do something like this:\n\n```ruby\nclass User < ActiveRecord::Base\n scope :search, -> (term) {\n search_pattern = \"%#{term}%\"\n- where(\"firstname LIKE ? OR surname LIKE ? OR email LIKE ?\", search_pattern, search_pattern, search_pattern)\n+ # MySQL does not support standard string concatenation and since concat_ws or concat functions do\n+ # not exist for sqlite, we have to come up with this conditional\n+ if ActiveRecord::Base.connection.adapter_name == \"Mysql2\"\n+ where(\"concat_ws(' ', firstname, surname) LIKE ? OR email LIKE ?\", search_pattern, search_pattern)\n+ else\n+ where(\"firstname || ' ' || surname LIKE ? OR email LIKE ?\", search_pattern, search_pattern)\n+ end\n }\n # EVALUATE CLASS AND INSTANCE METHODS BELOW\nend\n```\n\nBut I'm not sure what you're trying to do here. I don't think you need to use `eval` here. If you want to use `eval`, you can do something like this", "reference": "Mysql allows for `||` concatenation (e.g. `firstname||' '||surname`) if you enable it: `set sql_mode=PIPES_AS_CONCAT;`. I think this check is safer though" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to use the `bind` package, but you're not using it in your code. I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to use the `bind` package, but you're not using it in your code. I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to use the `bind` package, but you're not using it in your code. I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to use the `bind` package, but you're not using it in your code. I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to use the `bind` package, but you're not using it in your code. I'm not sure what you", + "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would", "reference": "NOTE: this is the default ENS registry address. If the ENS suite is deployed from the current builds to any chain, it will always be found at this address." }, { - "prediction": "I don't think we need to do this. We can just use `draw :videos` instead of `draw :vanity`", + "prediction": "I don't think we need to do this. We already have a `draw :videos` in the `Upcase::Application.routes.draw` block.", "reference": "I'm curious why you are using `draw` in this route file?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this.", + "prediction": "I don't think we need to panic here.", "reference": "Those variables are only been used once, I think we don't need to create them at all, just pass values to the `GetRawDiff` directly." }, { @@ -14347,43 +14347,43 @@ "reference": "I like the idea of replacing all the `#if NET461` with `#if NETFRAMEWORK`... is that worth doing now? Means fewer changes if we go to 4.7.2 at some point" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `oidc` package to create a new `oidc.Provider` object. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `oidc` package to create a new `oidc.Provider` object. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `oidc` package to create a new `oidc.Provider` object. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `oidc` package to create a new `oidc.Provider` object. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `oidc` package to create a new `oidc.Provider` object. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `oidc` package to create a new `oidc.Provider` object. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use", + "prediction": "I'm not sure if this is a good idea, but I think we should use `oidc.Provider` instead of `oidc.IDTokenVerifier` in this case.", "reference": "to fix the docs build failure, make this const var named without the suffix `Name`" }, { - "prediction": "I'm not sure what you mean by \"fallthrough\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate function for this, so that we don't have to call it multiple times.", "reference": "This bugfix also included, in case a subjectAlternativeName was present in the cert, then URIs (e.g SVID SPIFFE auth) would not have been attempted." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a `FileProviderInterface` that can be used to create a `File` from a `Uri`. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a `FileProviderInterface` that can be used to create a `File` from a `Uri`. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a `FileProviderInterface` that can be used to create a `File` from a `Uri`. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a `FileProviderInterface` that can be used to create a `File` from a `Uri`. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a `FileProviderInterface` that can be used to create a `File` from a `Uri`. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a `FileProviderInterface` that can be used to create a `File` from a `", + "prediction": "I'm not sure what you mean by \"createProvidedFile() throws IOException\". Is this the same as `createFile() throws IOException`?", "reference": "Same here. Feels like the wrong location." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to have a `CommandDispatcher` in the `qutebrowser.misc` module. It's not a good idea to have a `CommandDispatcher` in the `qutebrowser.misc` module. It's not a good idea to have a `CommandDispatcher` in the `qutebrowser.misc` module. It's not a good idea to have a `CommandDispatcher` in the `qutebrowser.misc` module. It's not a good idea to have a `CommandDispatcher` in the `qutebrowser.misc` module. It's not a good idea to have a `CommandDispatcher` in the `qutebrowser.misc` module. It's not a good idea to have a `CommandDispatcher` in the `qutebrowser.misc` module. It's not a good idea to have a `CommandDispatcher` in the `qutebrowser.misc` module. It's not a good idea to have a `CommandDispatcher` in the `qutebrowser.misc` module. It's not a good idea to have a `CommandDispatcher` in the `qutebrowser.misc` module. It's not a good idea to have a `", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be a good idea to move it to the `qutebrowser.misc` module, since it's a bit more general than `editor` and `guiprocess`.", "reference": "Please make `_path_suggestion` public (i.e. remove the `_`) in `downloads.py`." }, { - "prediction": "I'm not sure what the point of this flag is. I don't see it being used anywhere in the code.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `caddy` package.", "reference": "Woah, these flag names gotta get shorter. (Edit: I'll try to suggest some if needed, will think on it.)" }, { - "prediction": "I'm not sure what you're trying to achieve with this initializer, but I think it's a bad idea. The initializer should be in the `config` module, not in the `Blacklight` module.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a default value for `Blacklight.secret_key_base` in `config/initializers/blacklight.secret_key.rb`.", "reference": "Is this the code that's supposed to use the Rails app's only when in Rails4? What's the point of the first `if app.respond_to?(:secrets)`, both the `if` and the `elsif` have the same body, is only the second one needed? If `app.config` has a `secret_key_base`, then use it, the end. Is there a need for first checking if `app.respond_to?(:secrets)`?" }, { - "prediction": "I'm not sure what you mean by \"m_nopayload_elems_bitmask = %s\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a `enum_decl->isObjC()`, so that we don't have to check for `enum_decl->isObjC()` every time we call `Dump()`.", "reference": "Does this not apply to C enums on Linux?" }, { - "prediction": "I think this should be `if (supportsRetryableWrites(server) && !inActiveTransaction(session, cmd))` instead of `if (supportsRetryableWrites(server) && !inActiveTransaction(session, cmd)) { err.addErrorLabel('RetryableWriteError'); }`", + "prediction": "I think this should be `if (supportsRetryableWrites(server) && !inActiveTransaction(session, cmd))`", "reference": "Should this check if the error is `RetryableWriteError` before adding the label?" }, { - "prediction": "I'm not sure what you're trying to do here, but I think we should just use `getFormData` from `get-form-data` package.", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get the `FormData` object from the `getFormData` module. If you're using Rollup, you should be able to use `require('get-form-data').default` instead of `require('get-form-data').default || require('get-form-data')`.", "reference": "Oh wow, that's one complicated require :)" }, { - "prediction": "I'm not sure what you're trying to do with this snippet, but I'm not sure what you're trying to do with this snippet, but I'm not sure what you're trying to do with this snippet, but I'm not sure what you're trying to do with this snippet, but I'm not sure what you're trying to do with this snippet, but I'm not sure what you're trying to do with this snippet, but I'm not sure what you're trying to do with this snippet, but I'm not sure what you're trying to do with this snippet, but I'm not sure what you're trying to do with this snippet, but I'm not sure what you're trying to do with this snippet, but I'm not sure what you're trying to do with this snippet, but I'm not sure what you're trying to do with this snippet, but I'm not sure what you're trying to do with this snippet, but I'm not sure what you're trying to do with this snippet, but I'm not sure what you're trying to do with this snippet, but I'm not sure what you're trying to do with this snippet, but I'm not sure what you're trying to do with this snippet, but I", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `context` package.", "reference": "do you mean how to \"use\"" }, { @@ -14391,11 +14391,11 @@ "reference": "We can't really test this anymore since ref and props.ref are at the backing node level now" }, { - "prediction": "I don't think this is necessary. The `FileScanTask` can be passed directly to the `CloseableIterator` constructor.", + "prediction": "I don't think this is necessary. The `FileScanTask` can be passed directly to the `BaseDataReader` constructor.", "reference": "Did you intend to set this in the constructor?" }, { - "prediction": "I'm not sure what you mean by \"defaultAMI\" in this context. I think you meant to say \"defaultAMILookup\".", + "prediction": "I'm not sure what you mean by \"default to the first private available\". I think you meant to say \"default to the first public available\" or \"default to the first private available\".", "reference": "This looks fine as a first approach, and can we put a TODO here about ubuntu 18.04 being hardcoded?" }, { @@ -14403,31 +14403,31 @@ "reference": "This isn't strictly needed since lmdb / leveldb data that is unencoded does not require OpenCV IO. I think `DataLayer` should only require lmdb / leveldb. If one tries to use encoded data without OpenCV the `DataTransformer` guards will report the dependency failure." }, { - "prediction": "I think it's better to use `hLog.WithError(err).Error(\"unable to apply hiveapi cluster role binding\")` instead of `hLog.WithError(err).Error(\"unable to apply hiveapi cluster role binding\")`", + "prediction": "I think this should be `util.ApplyAsset(h, \"config/apiserver/hiveapi-cluster-role-binding.yaml\", hLog)` instead of `util.ApplyAsset(h, \"config/apiserver/hiveapi-cluster-role-binding.yaml\", hLog)`", "reference": "Should we take out this change? This was only in there to try to brute force the start of the apiserver yesterday." }, { - "prediction": "I'm not sure what you mean by \"has_many :completers, through: :individual_steps, source: :completer\". Is this supposed to be `has_many :completers, through: :individual_steps, source: :completer` or `has_many :completers, through: :individual_steps, foreign_key: :completer_id, source: :completer`?", + "prediction": "I'm not sure what you mean by \"has_many :completers, through: :individual_steps, source: :completer\". I think you meant to say \"has_many :completers, through: :individual_steps, source: :completer\".", "reference": "I worry that this association name is a bit confusing. Yoz was asking me about the concept of completion yesterday, which is why I think of it. It wasn't clear to him exactly what it was. what about calling this a `step_completer` ? we know that a proposal has many steps, so I think that might be clearer. in the future, we also might want the rename the `approver` relation because a step is not always an approval these days." }, { - "prediction": "I don't think this is a good name for this rule. It's not clear to me what it's supposed to do.", + "prediction": "I don't think this is a good name for this rule. It's not clear what it does, and it doesn't seem to be used anywhere else in the code. I would suggest renaming it to something like \"SubscriptionId\" or \"ApiVersion\" instead.", "reference": "Just add a to-do saying we need to add api-version in the check some time in the future when we enable the single-swagger spec mode for validation." }, { - "prediction": "I don't think this is needed anymore.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to set the default datasource to `thelia` here.", "reference": "@lunika Please see this. It allows us to do `Propel::getConnection()` easily, as we have only one database." }, { - "prediction": "I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this", "reference": "Not related to this particular cast but I wonder if we shouldn't have a cast helper that would log if null to gain visibility." }, { - "prediction": "I'm not sure what you're trying to do with this, but it looks like you're trying to get a list of files from a Google Drive. I'm not sure what you're trying to do with this, but it looks like you're trying to get a list of files from a Google Drive. I'm not sure what you're trying to do with this, but it looks like you're trying to get a list of files from a Google Drive. I'm not sure what you're trying to do with this, but it looks like you're trying to get a list of files from a Google Drive. I'm not sure what you're trying to do with this, but it looks like you're trying to get a list of files from a Google Drive. I'm not sure what you're trying to do with this, but it looks like you're trying to get a list of files from a Google Drive. I'm not sure what you're trying to do with this, but it looks like you're trying to get a list of files from a Google Drive. I'm not sure what you're trying to do with this, but it looks like you're trying to get a list of files from a Google Drive. I'm not sure what you're trying", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `nextPageToken` and `incompleteSearch` fields.", "reference": "why do we need to explicitly declare these fields?" }, { - "prediction": "I'm not sure if this is the best way to do this, but it seems to work for now.", + "prediction": "I don't think we need to use `VuFind\\Db\\Table\\PluginManager` here. We can just use `VuFind\\Record\\Loader` and `VuFind\\Search\\Results\\PluginManager`.", "reference": "Note that there are multiple OAI servers -- that's why `$serverClass` is a variable here. You'll want to fetch `$serverClass` from the service manager rather than a hard-coded value, and also set up a module.config.php for the authority record version, `VuFind\\OAI\\Server\\Auth`. Should be easy enough since it can share the same factory." }, { @@ -14435,7 +14435,7 @@ "reference": "This is no longer needed and should be removed." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `ParseJSONOptions` function to the `Options` struct, so that we don't have to do this in the `ParseFlags` function.", + "prediction": "I don't think we need to do this.", "reference": "could use named return params here to avoid declaring the opts, and using naked returns instead." }, { @@ -14443,19 +14443,19 @@ "reference": "this is an unrelated fix. I noticed when an instagram carousel post is mixed with images and videos, the videos don't come with thumbnails, so I am adding a fallback thumbnail for this case." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don", + "prediction": "I'm not sure I understand what you're trying to do here. Can you explain a bit more?", "reference": "\"... after protocol version 1\"?" }, { - "prediction": "I think it's a good idea to add a docstring to `mib_re_strings` and `mib_re_comments` to explain what they do.", + "prediction": "I think it's a good idea to add a docstring to this function.", "reference": "Is there a unit test that covers this regexp? I am afraid that changing it might break things =/" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to make this method private. It's not a good idea to expose this method to the public API.", + "prediction": "I think this should be `@` instead of `@`.", "reference": "This change is okay IMO because an `@` variable in Ruby is not a reference -- `@` variables are instance variables. Also, it's never used by the Ruby transformers." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `PaymentImageUploadCest` as well.", "reference": "Why this change was needed? Because in `po` files it's with curly braces?" }, { @@ -14463,19 +14463,19 @@ "reference": "Wait -- where did this change come from? This seems unrelated to trace building and seems like it could affect basic execution, unlike the rest of this PR which is all under the off-by-default trace option. Please separate this into its own PR and probably ask @AssadHashmi to review." }, { - "prediction": "I think this should be `@docusaurus/core/lib/babel/preset` instead of `@docusaurus/core/lib/babel/presets`", + "prediction": "I think this should be `@docusaurus/core/lib/babel/preset` instead of `@docusaurus/core/lib/babel`", "reference": "seems to be redundant (mention `docusaurus` )" }, { - "prediction": "I'm not sure what you mean by \"create a new transaction API to commit multiple table operations at once.\" I think you meant to say \"create a new transaction to commit multiple table operations at once.\"", + "prediction": "I'm not sure what you're trying to achieve with this method, but I think it's a bad idea to expose this method.", "reference": "Can we combine this with the Rollback API? We could still support the `rollback` method here, but combine `Rollback` and `CherryPick` into something like `ManageSnapshots`. Then we could reuse logic for enforcing checks of the current snapshot. What do you think?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to use the `gen_guid()` function to generate a unique identifier for your application. However, the `gen_guid()` function is not defined in the code you provided, so I'm not sure what you're trying to do with it.", "reference": "Maybe just `env_prefix`, I don't think this is referring to the WQ manager." }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to have a `SearchPreferenceResultListener` in the `AutoDownloadPreferencesFragment` as well.", + "prediction": "I don't think this is necessary.", "reference": "Unrelated line change :)" }, { @@ -14487,27 +14487,27 @@ "reference": "I think ticket meant, not applying replacement in this method, but rather applying encodeSomeHtml to each and every localization string" }, { - "prediction": "I think this should be `error instanceof MongoParseError || error == null`", + "prediction": "I think this should be `MongoParseError` instead of `MongoError`?", "reference": "ticket for the 4.0 epic?" }, { - "prediction": "I don't think it's necessary to use `cfg.model.neck.rfp_backbone.pretrained = None` in this case, since `cfg.model.neck.rfp_backbone` is already `None` in this case.", + "prediction": "I don't think it's necessary to use `cfg.model.neck.rfp_backbone.pretrained = None` in this case, since `cfg.model.neck.rfp_backbone.pretrained` will be `False` anyway.", "reference": "`cfg.model.get('neck')` will return None if neck does not exist, thus we can omit the default value." }, { - "prediction": "I'm not sure if this is the right way to do this, but I think we should use `Blacklight::Solr::FacetPaginator` instead of `Blacklight::Solr::Facet`.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way", "reference": "Trailing whitespace detected." }, { - "prediction": "I think we should remove the `LinkerScript` field as it's not used anymore.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `Target` struct as well.", "reference": "I don't see why a `cxxflags` key is necessary? C flags are important in the target file because they define things like the float ABI. But these flags are also used for C++. I can't think of a reason why you would want to configure C++ flags in a target file." }, { - "prediction": "I'm not sure what you mean by \"next pc now\". I think you meant to say \"next pc\".", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `instrument_annotation` as well.", "reference": "Update year range in Copyright notice, and elsewhere too." }, { - "prediction": "I think we should remove the `AccessKeyIDSecretRef` and `SecretAccessKeySecretRef` fields.", + "prediction": "I think we should remove the `SecretAccessKeySecretRef` from the `ACMEIssuerDNS01ProviderRoute53` struct.", "reference": "Can we update this PR to not be a breaking change? i.e. if a user specifies `accessKeyID`, it is still used. But if a user specifies `accessKeyIDSecretRef`, it takes precedence?" }, { @@ -14515,11 +14515,11 @@ "reference": "You don't actually need both tests here as \"truthiness\" means that `\"0\"` is false and hence the first test will be true..." }, { - "prediction": "I'm not sure what you're trying to achieve with this test, but I think it would be better to use `click_link` instead of `click_button` in this case.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this.", "reference": "Everything else in here is using `I18n`. Should we do that here to be consistent?" }, { - "prediction": "/0:tcp:2379,0.0.0.0/0:tcp:2380,0.0.0.0/0:tcp:5473,0.0.0.0/0:tcp:6443,0.0.0.0/0:tcp:6666,0.0.0.0/0:tcp:6667;die-on-fail\"`\n }\n \n func (c *Config) validate() error {\n```\nReview comment?", + "prediction": "/0:tcp:2379,0.0.0.0/0:tcp:2380,0.0.0.0/0:tcp:5473,0.0.0.0/0:tcp:6443,0.0.0.0/0:tcp:6666,0.0.0.0/0:tcp:6667;die-on-fail\"`\n }\n```\nReview comment?", "reference": "What do you think about changing the ordering to be `::`? I think it matches the most with what we previously had so that it doesn't change too much for our users." }, { @@ -14527,43 +14527,43 @@ "reference": "I'm fairly sure this precondition is always true due to the mod (%)" }, { - "prediction": "I'm not sure what you mean by \"seen twice\" in this context. Is it possible that you are referring to the `SegmentCommitInfo` class? If so, I think we should remove the `noDups` method from the `ReaderPool` class.", + "prediction": "I think this should be `assert !seen.contains(info.info.name);`", "reference": "I love seeing diffs like this one, adding a `String` message to an otherwise cryptic `assert`! It makes me realize you must have had a hellacious debugging session!" }, { - "prediction": "I think it's better to use `if` instead of `if` and `else if` in this case.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `migrate()` function.", "reference": "1. No logger exists to produce a message 2. Can't assume the latest version because missed version means 0." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `computeHash` method to compute the hash of the config file, and then use that hash to create a new config object. This way, we don't have to compute the hash every time we want to create a new config object.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `computeHash` method to compute the hash of the config file, and then use that hash to create a new config object. This way, we don't have to compute the hash every time we want to create a new config object, and we don't have to compute the hash every time we want to read a config file.", "reference": "I saw a wrong reuse of the cache between a partial analysis of a single file and a full run where errors due to lack of context on the first partial run was reported on the full run. Shouldn't we use a hash that is composer.lock + psalm.xml + command line to be safe?" }, { - "prediction": "I think this should be `if not isinstance(self.index, DatetimeIndex)` instead of `if not isinstance(self.index, ks.DatetimeIndex)`.", + "prediction": "I think this should be `if axis != 0:` instead of `if not isinstance(self.index, DatetimeIndex):`", "reference": "Could you also update it in `at_time`?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check to see if the scheme is in the `LOCALITY_WHITELIST_FS` list, and if it is, set `this.localityPreferred` to `true`. If it is not in the list, set `this.localityPreferred` to `false`.", + "prediction": "I think this should be `else if` instead of `else`.", "reference": "Because schema is non-final we can't just switch this to a lambda" }, { - "prediction": "I think this should be `if (exception.MustBeRethrown(\"While resolving function '{0}' follwing exception occured: {1}\", functionName, exception))`", + "prediction": "I think this should be `if (exception.MustBeRethrown(\"While resolving function '{0}' following exception occured: {1}\", functionName, exception))`", "reference": "proposal: **always** add the exception to the end of the message. So no need to to pass exception twice (implicit and explicit). Need a lot of changes." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `InvocationStartProcessingEvent` class.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's the best way to do this.", "reference": "why? event.getInvocationType is not you want?" }, { - "prediction": "I think we should remove the `git_hash` field as it is not used.", + "prediction": "I don't think we need this field. It's not used anywhere. I think we can remove it.", "reference": "nit: how about `GitSHA`?" }, { - "prediction": "I'm not sure what you mean by `FAIL_DIR`. Is it a directory name? Or is it a file name? If it's a file name, then it should be `makeflow.failed.%d`. If it's a directory name, then it should be `makeflow.failed.%d`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `makeflow.failed` directory that we can use to keep track of failed builds.", "reference": "If you move the other functions, this should also be moved to `makeflow_gc.h`." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think we should move this to the `play_now.py` file.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to move this to the `play_now.py` file.", "reference": "This whole block bugs me. Expire_time to me suggest that an absolute time of when something happens and duration is an interval of time. While the code looks correct, it feels awkward to read." }, { @@ -14571,27 +14571,27 @@ "reference": "Can we add `_dom` as an argument to createVNode here? I think it might be shorter (could totally be wrong!)" }, { - "prediction": "I'm not sure what you mean by \"in x64 mode\". I think this is only relevant in x86 mode.", + "prediction": "I think this should be `mangle_single_step(dcontext, ilist, popf);` instead of `mangle_single_step(dcontext, ilist, popf); PRE(ilist, instr, popf);`", "reference": "I think that the iret handling is not yet good." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a `TabBar` with a `Tab` that contains a `TabBar` with a `Tab` that contains a `TabBar` with a `Tab` that contains a `TabBar` with a `Tab` that contains a `TabBar` with a `Tab` that contains a `TabBar` with a `Tab` that contains a `TabBar` with a `Tab` that contains a `TabBar` with a `Tab` that contains a `TabBar` with a `Tab` that contains a `TabBar` with a `Tab` that contains a `TabBar` with a `Tab` that contains a `TabBar` with a `Tab` that contains a `TabBar` with a `Tab` that contains a `TabBar` with a `Tab` that contains a `TabBar` with a `Tab` that contains a `TabBar` with a `Tab` that contains a `TabBar` with a `Tab` that contains a `TabBar` with a `Tab` that contains a `TabBar` with a `Tab` that contains a `TabBar` with", + "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to have a default value for the `icon` prop, so that we don't have to pass it in every time we want to use the `TabBar` component.", "reference": "Huh, that's kinda weird. I get it, but it's unexpected to me..." }, { - "prediction": "I think we can remove the `atomic.LoadInt64(&t.Seen)` and `atomic.LoadInt64(&t.Total)`.", + "prediction": "I think we should remove the `total` field from the `Status` function.", "reference": "why is this removed? it is important when you upload from stream of unknown size" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I think we should remove the `has_one :proposal, through: :approval` line.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's unnecessary. The `has_one :approval` relationship is already implied by the `belongs_to :approval` relationship, so we don't need to add it again.", "reference": "Out of curiosity, why is this needed? Does it enforce what class can be assigned?" }, { - "prediction": "I think this should be `a.config.ErrorCh <- a.grpcServer.Serve(listener)` instead of `a.config.ErrorCh <- a.grpcServer.Serve(listener)`.", + "prediction": "I think it's better to use `os.Chmod` to change the permissions of the file.", "reference": "non-blocking: Now that we have a handful of statements which deal with creating a listener, it may make sense to introduce a `createListener` method or something similar" }, { - "prediction": "I'm not sure what you mean by \"LastExecutor\" in this context. It's not clear to me what you're trying to do with it.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have the `LastExecutor` be a property of the `MevBlockProductionTransactionsExecutor` class.", "reference": "factory should be stateless if possible, looks like much complexity added" }, { @@ -14599,15 +14599,15 @@ "reference": "Could you please add short description for the default value as well?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `CommitStateChanges` function.", "reference": "Leave a TODO message to say we will fix the log level in the future, once committing the block and the state become a transaction" }, { - "prediction": "I think it's better to have a `PARQUET_ROW_GROUP_CHECK_MIN_RECORD_COUNT_DEFAULT` and `PARQUET_ROW_GROUP_CHECK_MAX_RECORD_COUNT_DEFAULT` instead of `PARQUET_ROW_GROUP_CHECK_MIN_RECORD_COUNT` and `PARQUET_ROW_GROUP_CHECK_MAX_RECORD_COUNT`.", + "prediction": "I think we should remove the default value for `AVRO_COMPRESSION_DEFAULT` as it is not used anywhere.", "reference": "this can be integer" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to change the `border-bottom` of the `QTreeView::item:selected` and `QTreeView::item:selected:hover` to the same color as the `QTreeView::item:selected`.", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `QTreeView::item:selected` and `QTreeView::item:selected:hover` instead of `{{ color['completion.category.border.top'] }}` and `{{ color['completion.category.border.bottom'] }}`.", "reference": "nitpick: Please remove the blank line here" }, { @@ -14615,11 +14615,11 @@ "reference": "What is this for? The only methods I can see by that name in the rails doc are generating a foreign key name from a model class name but you seem to be giving a key name as argument?" }, { - "prediction": "I don't think we need to do this.", + "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to have a check for duplicate core names in the `checkForDuplicateCoreNames` method. This way, if the core name is already in use, we don't create a new one.", "reference": "Is this second check necessary? we know that just after the plugin was created its metricRegistry is null, it's set only after `initializeMetrics` has been called." }, { - "prediction": "I'm not sure what you mean by \"executeSay\" in this context. It's not clear to me what it's supposed to do.", + "prediction": "I'm not sure what you mean by \"executeSay\" in this context. It's not clear to me what it does.", "reference": "shouldn't this be `return TALKACTION_BREAK;` as the player does not meet the required group access?" }, { @@ -14627,11 +14627,11 @@ "reference": "does this still work if minerNode1 has already proposed a block before 2 & 3 are stopped?" }, { - "prediction": "I think we can remove the `logging.FromContext(ctx).Desugar().Error(\"Adding log line for the TestCloudLogging E2E tests\", zap.String(v1.LoggingE2EFieldName, v))` line, as it's not necessary.", + "prediction": "I think we can remove the `logging.FromContext(ctx).Desugar().Error` line, as it's not necessary.", "reference": "I am wondering if we can either make this a feature or have a way to turn it off in production. My concern is that we might be adding more of these kind of code in the future." }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.", + "prediction": "I don't think this is a good idea.", "reference": "We can just use `.stack()` here? Then I guess we can reuse when supporting multi-index columns." }, { @@ -14639,7 +14639,7 @@ "reference": "What are the possibilities here? Since we plan on supporting .net standard 2.0 from day 1, we might as well tackle that now." }, { - "prediction": "I think this method should be named `Add` instead of `AddInSpan`.", + "prediction": "I think this should be `SpanReference` instead of `SpanContext`.", "reference": "should the parameters be called reference or context?" }, { @@ -14647,15 +14647,15 @@ "reference": "Do we need to also change `length` here (and below) to `bytesize`? Perhaps we ought to make a copy of `in_buffer` encoded as binary and then the existing algorithm should work." }, { - "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `q.yank_text = url.toString()` instead of `q.yank_text = url.toString().toString()`.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to have a `yank_text` property on a `Prompt` object. I think it's better to have a `yank_text` property on a `Text` object.", "reference": "This should be `toDisplayString()` to not contain e.g. passwords." }, { - "prediction": "I think we can remove the `config.autocomplete_enabled` and `config.autocomplete_path` from the controller.", + "prediction": "I don't think this is necessary. We can just use `config.autocomplete_enabled = true` instead of `config.autocomplete_path = 'suggest'`.", "reference": "Can we just say that having a non-nil `autocomplete_path` implies that autocomplete is enabled?" }, { - "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to have it in the same file as `caddyfile` so that we don't have to change it every time we update `caddyfile`.", + "prediction": "`proto` is not a package, it's a type. `caddyconfig/caddyfile` is a struct. `caddyfile` is a struct. `caddyfile` is a struct. `caddyfile` is a struct. `caddyfile` is a struct. `caddyfile` is a struct. `caddyfile` is a struct. `caddyfile` is a struct. `caddyfile` is a struct. `caddyfile` is a struct. `caddyfile` is a struct. `caddyfile` is a struct. `caddyfile` is a struct. `caddyfile` is a struct. `caddyfile` is a struct. `caddyfile` is a struct. `caddyfile` is a struct. `caddyfile` is a struct. `caddyfile` is a struct. `caddyfile` is a struct. `caddyfile` is a struct. `caddyfile` is a struct. `caddyfile` is a struct. `caddyfile` is a struct. `caddyfile` is a struct. `caddyfile` is a struct. `caddyfile` is", "reference": "Note that the package github.com/golang/protobuf/proto is deprecated. We're instructed to use the \"google.golang.org/protobuf/proto\" package instead. I didn't want to change it now to avoid intrusive changes whose consequences are, currently, unknown." }, { @@ -14663,51 +14663,51 @@ "reference": "Are these gone routes? Do we need to 301 them?" }, { - "prediction": "I'm not sure what you're trying to achieve with this code, but it looks like you're trying to parse a JSON string into a `v1beta1.NetworkPolicy` object. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to parse a JSON string into a `v1beta1.NetworkPolicy` object. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to parse a JSON string into a `v1beta1.NetworkPolicy` object. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to parse a JSON string into a `v1beta1.NetworkPolicy` object. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to parse a JSON string into a `v1beta1.NetworkPolicy` object. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to parse a JSON string into a `v1beta1.NetworkPolicy` object. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to parse a JSON string into a", + "prediction": "I'm not sure if this is a good place to put it, but I think we should move it to `networking/v1beta1/networkpolicy` so that it can be used by other controllers as well.", "reference": "move them to internal group of imports" }, { - "prediction": "I don't think this is a good idea. It's not clear to me what the error message is supposed to be. It's not clear to me what the error message is supposed to be. It's not clear to me what the error message is supposed to be. It's not clear to me what the error message is supposed to be. It's not clear to me what the error message is supposed to be. It's not clear to me what the error message is supposed to be. It's not clear to me what the error message is supposed to be. It's not clear to me what the error message is supposed to be. It's not clear to me what the error message is supposed to be. It's not clear to me what the error message is supposed to be. It's not clear to me what the error message is supposed to be. It's not clear to me what the error message is supposed to be. It's not clear to me what the error message is supposed to be. It's not clear to me what the error message is supposed to be. It's not clear to me what the error message is supposed to be. It's not clear to me what the error message is supposed to be. It's not clear to me", + "prediction": "I'm not sure what you mean by \"please handle\" here. It's not clear to me what you're trying to do here. Is it that you want to handle the event in the `cStorPoolEventHandler` function? Or is it that you want to handle the event in the `cStorPoolController` function?", "reference": "can we rewrite this as: `ignored event '%s' for cstor pool '%s'`" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I'm not sure if this is the best way to go about it. It's not clear what you're trying to achieve with this, but I'm not sure if this is the best way to go about it. It's not clear what you're trying to achieve with this, but I'm not sure if this is the best way to go about it. It's not clear what you're trying to achieve with this, but I'm not sure if this is the best way to go about it. It's not clear what you're trying to achieve with this, but I'm not sure if this is the best way to go about it. It's not clear what you're trying to achieve with this, but I'm not sure if this is the best way to go about it. It's not clear what you're trying to achieve with this, but I'm not sure if this is the best way to go about it. It's not clear what you're trying to achieve with this, but I'm not sure if this is the best way to go about it. It's not clear what you're trying to achieve with this, but I'm not sure if this is the best way", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. The `purchase_amount_column_name` should be `:purchase_amount`, not `:amount`.", "reference": "not all client data types have an approving official (eg: 18F does not). do we still want to include the relation here?" }, { - "prediction": "I'm not sure what you're trying to achieve with this method. Is it possible that you're trying to get a list of all elements that match the given `By`? If that's the case, you can use the `findElements` method to get a list of all elements that match the given `By` and then convert it to a list of `WebElement` objects.", + "prediction": "I'm not sure what you're trying to do with this method, but it looks like you're trying to get a list of all the elements that match the given `By` and return them as a list of `T` objects, where `T` is the type of the `WebElement` returned by the `findElements` method. Is this what you're trying to do?", "reference": "This change should also probably go into the corresponding method of the abstract By class?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the `config.url_prefix` is the same as the `config.base_url` in this case.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to move this to the `config` object.", "reference": "why this remove?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you want to use `os.Open` here. You want to use `os.OpenFile` instead.", + "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.", "reference": "As the test failures indicate, making this change is going to mean changing everything which currently implements this interface." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to redirect the user to a different URL. I'm not sure what you're trying to do here, but it looks like you're trying to redirect the user to a different URL. I'm not sure what you're trying to do here, but it looks like you're trying to redirect the user to a different URL. I'm not sure what you're trying to do here, but it looks like you're trying to redirect the user to a different URL. I'm not sure what you're trying to do here, but it looks like you're trying to redirect the user to a different URL. I'm not sure what you're trying to do here, but it looks like you're trying to redirect the user to a different URL. I'm not sure what you're trying to do here, but it looks like you're trying to redirect the user to a different URL. I'm not sure what you're trying to do here, but it looks like you're trying to redirect the user to a different URL. I'm not sure what you're trying to do here, but it looks like you're trying to redirect the user to a different URL. I'm not sure", + "prediction": "I'm not sure why we're redirecting to `http://forum.upcase.com` instead of `http://forum.upcase.com:8080`.", "reference": "Do we want to redirect this to the forum or something in case people have it linked/bookmarked?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to use `stringToHslColor` instead of `stringToHsl`.", + "prediction": "I don't think we need to use `stringToHslColor` here. We can just use `color` directly.", "reference": "@peterzimon came up with this 'NM' piece as a placeholder for New Member initials, without this the screen looks broken. It changes to normal initials calculation once email or name is entered. Lmk if you'd like to put something different here ;)" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a `createdAt` property to the `Member` model.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `attr('moment-utc')` instead of `attr('moment-utc')` and `attr('member-subscription')` instead of `attr('member-subscription')`. This is because `attr('member-subscription')` is a member of `attr('member-subscription')`, which is a member of `attr('member-subscription')`, which is a member of `attr('member-subscription')`, which is a member of `attr('member-subscription')`, which is a member of `attr('member-subscription')`, which is a member of `attr('member-subscription')`, which is a member of `attr('member-subscription')`, which is a member of `attr('member-subscription')`, which is a member of `attr('member-subscription')`, which is a member of `attr('member-subscription')`, which is a member of `attr('member-subscription')`, which is a member of `attr('member-subscription')`, which is a member of `attr('member-subscription')`, which is a member of `attr('member-subscription')`, which is a", "reference": "@kevinansfield Would be cool if you can take a if this is the best way to add `subscriptions` info on member model. This uses the transform + separate model definition way which seemed to be the right way from other references in Admin" }, { - "prediction": "I think we can remove the `try`/`except` block here.", + "prediction": "I think we can remove this line, since we're not using `matplotlib` anymore.", "reference": "This is the common way of dealing with optional dependencies" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to use the `ReadyDependencyStatus` field at all.", + "prediction": "I don't think we need to do this. We can just use the `Ready` field in the `Source` struct.", "reference": "nit: we can replace all `kr` in this file with like `src`." }, { - "prediction": "I'm not sure what you mean by `mode && typeof mode === 'string'`. I think you meant `typeof readPreference === 'string'`.", + "prediction": "I don't think this is a good idea. It's not clear what `mode` is supposed to be.", "reference": "same concern here as above" }, { @@ -14715,11 +14715,11 @@ "reference": "Thank you for this, I gather this repairs failures that I've seen in another PR." }, { - "prediction": "I'm not sure what you mean by \"avoid adaptive execution combining tasks\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate method for reading the manifest files.", "reference": "This place probably makes sense to me. We can consider exposing an argument to make the dedup step optional (I am not sure it is a good idea but I want to think this through together). The dedup step we are adding is going to trigger a shuffle. Technically, we are fine in the existing expire snapshots action as it does the dedup in `except`. The question is what kind of performance impact deduplicating here will have. We only have duplicates if multiple manifests reference the same files. In `rewrite_manifests` procedure, we rewrite all manifests, meaning we produce a snapshot with new manifests where entries are old data files. Also, there are updates and deletes that may rewrite manifests. I think deduplicating here makes sense to me in all cases. Thoughts, @rdblue @flyrain @RussellSpitzer @karuppayya?" }, { - "prediction": "I think we should remove the `osdconfig` part of this function. It's not needed anymore.", + "prediction": "I think we should remove the `osdconfig` check here, as it's not necessary.", "reference": "can we move the code before deleteNodeFromDB ? this way even if the node crashes after remove config we can still re-run decommission again ?" }, { @@ -14727,11 +14727,11 @@ "reference": "Seems the default value of `melt`'s `var_name` at namespace.py should be changed as well." }, { - "prediction": "I'm not sure what you're trying to do with this test, but I think it's a bad idea to use the `botocore` library in this way. It's not a good idea to use the `botocore` library in this way. It's not a good idea to use the `botocore` library in this way. It's not a good idea to use the `botocore` library in this way. It's not a good idea to use the `botocore` library in this way. It's not a good idea to use the `botocore` library in this way. It's not a good idea to use the `botocore` library in this way. It's not a good idea to use the `botocore` library in this way. It's not a good idea to use the `botocore` library in this way. It's not a good idea to use the `botocore` library in this way. It's not a good idea to use the `botocore` library in this way. It's not a good idea to use the `botocore` library in this way. It's not a good idea to use the `botoc", + "prediction": "I'm not sure I understand what you're trying to do with this test. It seems like you're trying to create a botocore integration test, but I'm not sure what you're trying to test. Could you please provide more context or explain what you're trying to achieve with this test?", "reference": "I think botocore's serializer should already create the correct headers. However, they are currently not used in `_botocore_parser_integration_test`(line #217). Maybe we could remove the headers here and just use a fallback in the `_botocore_parser_integration_test` (i.e. use the given headers if they are set, otherwise use the headers generated by botocore's serializer)?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `updateButtonAction` and `updateButtonText` instead of `closeModalOnConfirm` and `confirmAction`.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it", "reference": "This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted." }, { @@ -14739,35 +14739,35 @@ "reference": "in case you want to rename one of the plugins when instantiating, from options?" }, { - "prediction": "I don't think this is needed anymore.", + "prediction": "I don't think this is necessary. We can just use `OrderedCheckersAction` directly.", "reference": "This default variable should be moved into a config variable, created by `package_context`, and read from `config\\package_layout.json`." }, { - "prediction": "I'm not sure what you mean by \"should calculate the number of columns based on a default width, when the width returned from the function is not a number\". I think you meant to say \"should calculate the number of columns based on a default width, when the width returned from the function is a number\".", + "prediction": "I'm not sure what you mean by \"when the width returned from the function is not a number\". I think you meant \"when the width returned from the function is less than 1000\".", "reference": "Can I ask you to add a new line after `const` assignment? I believe that this increases the code readability by encapsulating assignment and logic (expecting) blocks." }, { - "prediction": "I don't think this is necessary.", + "prediction": "I don't think we need to do this, since we're not using `HostSpace::execution_space::is_initialized()`, so we don't need to check for it.", "reference": "So the intention is you configure with `-CMAKE_CXX_FLAGS=\"-D KOKKOS_IMPL_TURN_OFF_CUDA_HOST_INIT_CHECK\"`?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `getAtomWithIdx` method.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `AtomPDBResidueInfo` class.", "reference": "This was a bug." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `isAttributeClassExistsAndNotEmpty` method to check if the class attribute exists and is not empty. This way, we don't have to check if the class attribute exists and is not empty every time we render the template.", + "prediction": "I don't think it's necessary to add the `class` attribute to the `src` attribute.", "reference": "Is OK that we don't have some placeholder?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `WorkerThreads` field to specify the number of worker threads that should be used for mining.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have the worker threads be the same as the miner threads.", "reference": "Sectorbuilder behaves differently depending on whether it's given 1 or more threads. It won't seal if only given 1." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `Meter` class from the `azkaban.metrics` package. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `Meter` class from the `azkaban.metrics` package. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `Meter` class from the `azkaban.metrics` package. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `Meter` class from the `azkaban.metrics` package. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `Meter` class from the `azkaban.metrics` package. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `Meter` class from the `azkaban.metrics` package. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `Meter` class from the `azkaban.metrics", + "prediction": "I don't think we need to use `ServiceProvider` here. We can just use `MeterRegistry` here.", "reference": "Sort of believe We should put MetricManager in constructor parameter given this case." }, { - "prediction": "I think we should remove the `sourceId` and `fieldId` fields.", + "prediction": "I think we can remove the `sourceId` and `fieldId` fields.", "reference": "Do we need to check `fieldId` is larger than 1000?" }, { @@ -14775,43 +14775,43 @@ "reference": "I think this should be called after the if below (the one for disable positive acks)" }, { - "prediction": "I think this should be `metricsConfig` instead of `metricsConfig`", + "prediction": "I don't think we need to add `metricsConfig` to `listAvroPartition`.", "reference": "I'd like to avoid changing this method since it is public and using a URI will probably change behavior for users passing strings (String -> URI -> Path instead of String -> Path)." }, { - "prediction": "I'm not sure what you mean by `os.Clearenv()`. I think you meant to call `os.Setenv(\"AWS_SHARED_CREDENTIALS_FILE\", \"example.ini\")` instead.", + "prediction": "I'm not sure why we need to stash the env here. We can just use `os.Getenv(\"AWS_SHARED_CREDENTIALS_FILE\")` and `os.Getenv(\"AWS_ACCESS_KEY_ID\")` and `os.Getenv(\"AWS_SECRET_ACCESS_KEY\")`.", "reference": "Should these restore the stashed env after the test runs?" }, { - "prediction": "I think this should be `for default_node in default_node.nodes_of_class(nodes.Name)` instead of `for d in scope.args.kw_defaults if d is not None`", + "prediction": "I think it's better to use `isinstance(scope, (nodes.FunctionDef, nodes.Lambda))` instead of `isinstance(scope, (nodes.FunctionDef, nodes.Lambda)) + [d for d in scope.args.kw_defaults if d is not None]`", "reference": "We're calculating the full list of kwargs here (even if the first element of the list would return True) so we could improve performance by using a generator line 408 in ``for default_node in all_defaults:``." }, { - "prediction": "I think this should be `accountDeltaCount` instead of `accountDelta`.", + "prediction": "I'm not sure what you mean by \"exclusively for consistency checking\". I think it's more like we want to make sure that all the pending changes were written and that there are no outstanding writes missing.", "reference": "Can ndelta differ depending on when the deltas are compacted? That is, when intermediate updates are dropped?" }, { - "prediction": "I'm not sure what you mean by \"need a \"xpath\" property value in order to function.\"", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `XPathRuleQuery` class, since that's where the `XPathRuleQuery` is defined.", "reference": "Our checkstyle config likes it better when the `

    ` is before the first word of the next paragraph, and not on a blank line" }, { - "prediction": "I'm not sure what you mean by \"we close criuServer so that even if CRIU crashes or unexpectedly exits, runc will not hang.\"", + "prediction": "I'm not sure why we need to close the criuServer here. I think we can just wait for the process to exit.", "reference": "This looks to be the only place where we return early before the close below, so if the \"double close\" is bothering people, closing manually here (and removing the `defer`) could be an option" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `execSync` to run the tests.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `execSync` method to execute the `npm run test:js` command. This way, we don't have to worry about the output of the `npm run test:js` command, and we don't have to worry about the output of the `node-qunit-phantomjs ./tests/qunit/index.html` command. We just need to make sure that the output of the `node-qunit-phantomjs ./tests/qunit/index.html` command is the same as the output of the `npm run test:js` command, and then we can use the `execSync` method to execute the `npm run test:js` command.", "reference": "This task can probably be deleted since we don't need gulp to run Jest." }, { - "prediction": "I think it's a good idea to add `timeout` and `interval` to the `initialize` method.", + "prediction": "I think it's better to have `NOT_CONNECTED_ERRORS` as an array of `Errno` objects instead of `Errno::ECONNREFUSED` and `Errno::ENOTCONN`.", "reference": "Doesn't this need to include `Errno::ECONNRESET` to fix the issue?" }, { - "prediction": "I think this should be `fetch('movie.director')` instead of `fetch('movie.quote')`", + "prediction": "I think it's better to use `fetch!` instead of `fetch` in this case.", "reference": "never heard of a qirector... what's their role again? (also should be 'for a movie')" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `onlyVertexProps_` in the `collectVertexProps` function.", "reference": "Implement the \"collect all props for one vertex\" logic inside QueryVertexPropsProcessor" }, { @@ -14819,23 +14819,23 @@ "reference": "This is to prevent parsing things like \"1.1\" as \"1\" until we implement it properly." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in `nupic.frameworks.opf.experiment_runner.py` instead of `nupic.frameworks.opf.experiment_runner.py`.", + "prediction": "I'm not sure if this is a good place to put this, but I think we should move it to the `nupic.frameworks.opf.experiment_runner` module. It's a bit more general than the `nupic.frameworks.opf.experiment_runner` module.", "reference": "Can we change `_getCheckpointParentDir` to be a public function explicitly? It seems like something that clients of experiment runner may wish to use." }, { - "prediction": "I think this should be `label = _(\"Use UI Automation to access the Windows Console (restart NVDA for changes to take effect)\")` instead of `label = _(\"Use UI Automation to access the Windows Console (restart NVDA for changes to take effect)\")`", + "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to put it in the `AdvancedPanelControls` class, so that it can be used in other places as well.", "reference": "Why is a restart necessary?" }, { - "prediction": "I think it's better to use `cfg.External.Enabled()` instead of `!cfg.External.Enabled()` in this case.", + "prediction": "I think it's better to use `cfg.External.Enabled()` instead of `cfg.External` in this case.", "reference": "Should setting the task runtime also go under the above if condition?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to use the `isDNSLabel` regular expression to check if a label is a DNS label, but I'm not sure what you're trying to do with that regular expression. I'm not sure what you're trying to do here. I think you're trying to use the `isDNSLabel` regular expression to check if a label is a DNS label, but I'm not sure what you're trying to do with that regular expression. I'm not sure what you're trying to do here. I think you're trying to use the `isDNSLabel` regular expression to check if a label is a DNS label, but I'm not sure what you're trying to do with that regular expression. I'm not sure what you're trying to do here. I think you're trying to use the `isDNSLabel` regular expression to check if a label is a DNS label, but I'm not sure what you're trying to do with that regular expression. I'm not sure what you're trying to do here. I think you're trying to use the `isDNSLabel` regular expression to check if a label is a DNS label, but I'm not sure what you", + "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to have a default value of 50 for the `defaultListEntriesPageSize` field.", "reference": "SPIRE uses the leadingLowerCase convention for unexported constants" }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it should go in the `Sarif` namespace.", + "prediction": "I think this should be `using Newtonsoft.Json;` instead of `using System.Runtime.Serialization;`", "reference": "The newest JSchema code generator orders `System` usings first." }, { @@ -14843,39 +14843,39 @@ "reference": "I understand that we want to have a possibility to configure the IcebergInputFormat to be case sensitive or case insensitive since it can be used by other MR jobs as well. Do we want to allow the users of Hive to shot themselves on the foot and enable case sensitivity? My first guess would be that we should not use the configuration here, just go with `false`, but if you have some specific use-case in your mind I can be easily convinced" }, { - "prediction": "I don't think we need to do this. The `common.SyncResources.Mux.Lock()` and `common.SyncResources.Mux.Unlock()` are redundant.", + "prediction": "I don't think we need to do this.", "reference": "Will the above call to cStorPoolAddEventHandler() get executed in the same thread as this line?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason why you want to turn this into a coroutine?", + "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason you want to lower this function into a coroutine?", "reference": "I don't think alloca instructions are always at the start of the entry block. I think it would be safer to check the entire entry block for alloca instructions, just in case some are not the first instruction. (Technically they can be anywhere in the function but we check in other places that this isn't possible)." }, { - "prediction": "I think we can remove the `ifaces` field from the `chainsForIfaces` function, since it's not used anywhere else.", + "prediction": "I'm not sure if this is a good place to put it, but I think it should be in the `ifaces` struct.", "reference": "Why isn't this 4789 (which I think is the Felix default)?" }, { - "prediction": "I think it's better to use `MessageResourceImported` instead of `MessageResourceFailCreate` and `MessageResourceImported` instead of `MessageResourceImported`.", + "prediction": "I think it's better to have `FailureImported` and `FailureImportOperations` as separate events.", "reference": "Can this be `Import operations failure`? In addition, is this the right time to change the variable names? e.g. `ReasonImportOperationsFailure`, `ReasonImportFailure`, `ReasonImportSuccessful`, `ReasonCreateResourceFailure`, `ReasonImportResourceSuccessful` Naming convention that i have assumed here is as follows: `Reason`" }, { - "prediction": "I think this should be `rbuf_ivar_id = rb_intern(\"@rbuf_ivar_id\");` instead of `rbuf_ivar_id = rb_intern(\"@rbuf\");`", + "prediction": "I think this should be `rbuf_ivar_id = rb_intern(\"@rbuf\");` instead of `rb_global_variable(&rbuf_ivar_id);`", "reference": "I suspect this isn't needed because I think `rb_intern` gets marked already." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `finest` or `log.finest` here.", "reference": "This change is incorrect: the current log level is correct." }, { - "prediction": "I'm not sure what you mean by \"how many bytes each docs takes in the fixed-width offline format\". I think you meant to say \"how many bytes each leaf takes in the fixed-width offline format\".", + "prediction": "I'm not sure if this is the right place to add this, but I think it would be good to add it to the `BKDReader` class as well.", "reference": "Can you add a space before the equal sign? There are a couple other places where spaces are missing in this PR." }, { - "prediction": "I think we should remove `flow.getUpdateTime() >= updateTime` here.", + "prediction": "I think we should remove `flow.getUpdateTime() >= updateTime` since it will be synced between web server and executor.", "reference": "Please follow the todo naming convention." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to add `+k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object` to the `+k8s:openapi-gen=true` line.", + "prediction": "I'm not sure what you mean by `+k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object`. I think you meant `+k8s:deepcopy-gen:interfaces=k8s.io/api/core/v1`?", "reference": "These are no longer used and changes should instead be made directly to the files in `deploy/chart/crds` /assign @JoshVanL /unassign" }, { @@ -14883,7 +14883,7 @@ "reference": "Is this really necessary to work around this way? The old version works fine with me when converting to ONNX." }, { - "prediction": "I think this should be `errors.New(\"Blob already closed\")` instead of `errors.New(\"blob already closed\")`", + "prediction": "I think this should be `if bb.final { return 0, errors.New(\"Blob already closed\") }`", "reference": "Same as above: don't start error strings with a capital letter, and don't fix unneeded things in an unrelated commit ;)" }, { @@ -14891,19 +14891,19 @@ "reference": "Is this a testing debug statement?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `createUnifiedOptions` function.", "reference": "you'll need to wrap the _whole thing_ within this async call (or refactor it so everything below is in a new temporary function). The code below this section depends on a value for `object` after the parsing occurs, but what you're doing here is kicking off a race condition where `object` is null, but _might_ parse quickly enough to assign it the parsed parts. Instead, you need to do everything that depends on the parsed object in the callback of `parse`." }, { - "prediction": "I don't think we need to use `std::unique_lock lk (mutex);` here. We can just use `std::unique_lock lk;`.", + "prediction": "I don't think we need to use `std::unique_lock lk (mutex);` here. We can use `std::unique_lock lk (mutex); lk.lock(); lk.unlock();` instead.", "reference": "This is now going to be protecting `stopped` when it doesn't need to. If you are going to do this then can you make `stopped` non-atomic and protect it in `stop`. It's cheap to make a `unique_lock` fyi, it's just a pointer to a mutex and a `bool`. The `lk.lock ()` in the loop is superfluous so probably shouldn't have been there to begin with." }, { - "prediction": "`remote_config` should be `remoteConfig` instead of `remote_config`", + "prediction": "`remote_config` should be `remoteConfig`", "reference": "Lets not give packages names if we dont have to. If a package requires a rename, we should change the actual name while/if we can." }, { - "prediction": "I think this should be `if (!TEST(1U << 31, enc) && TEST(1U << 15, enc))` instead of `if (!TEST(1U << 31, enc) && TEST(1U << 15, enc) && TEST(1U << 16, enc))`", + "prediction": "I think this should be `if (!TEST(1U << 31, enc) && TEST(1U << 15, enc))` instead of `if (!TEST(1U << 31, enc) && TEST(1U << 15, enc)) && TEST(1U << 16, enc)`", "reference": "Not sure I see where this is coming from. This is a bug fix? Should be mentioned in the commit message? Same below." }, { @@ -14915,23 +14915,23 @@ "reference": "Can this part be done in `dataset.get_ann_info`? Just like CocoDataset converts xywh to xyxy in `_parse_ann_info`" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `global.SetTracerProvider` instead of `global.SetTraceProvider` in this case.", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `global.SetTracerProvider` and `global.SetTraceProvider` instead of `global.SetTracerProvider` and `global.SetTraceProvider` because `global.SetTracerProvider` and `global.SetTraceProvider` can be called multiple times, while `global.SetTracerProvider` and `global.SetTraceProvider` can only be called once.", "reference": "Should we change the name of this test struct to be `testTracerProvider` as well?" }, { - "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea to add it to the `testutil` package.", + "prediction": "I'm not sure if this is a good place to put it, but I think we should move it to the `testutil` package.", "reference": "\"google.golang.org/grpc\" should be together with \"go.uber.org/zap\" all \"\"github.com/iotexproject/iotex-core/*\" stay together" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in `WebEngineTab` as well.", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be good to move it to the `webengine.py` file.", "reference": "No need for a separate variable here - just call `utils.read_file` directly below." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the channel is closed when the timer is stopped.", + "prediction": "I don't think we need to use `channel <- message` here. We can just use `channel <- model.Message{}`.", "reference": "Thanks for the fixing, small question, Here the message just be written to the channel, will it be blocked?" }, { - "prediction": "I don't think we need to change the order of these stages.", + "prediction": "I don't think this is a good idea. It's not clear to me what the difference is between `Headers` and `Bodies`, and I don't think it's clear to me what the difference is between `Headers` and `Execution` and `HashCheck`.", "reference": "maybe we will have something like `Bodies []byte(\"bodies\")` instead of them being a number? with numbers we are making it harder to insert stages mid-process." }, { @@ -14939,19 +14939,19 @@ "reference": "out of curiosity, why making this change? If no real reason, could you restore to avoid unnecessary changes of several generated files?" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a good idea to remove the `manager.eventPublisher.Publish(StateEventTopic, StateEvent{...})` line.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to make sure that the connection is closed when the event is published. This way, we don't have to wait for the connection to be closed before the event is published.", "reference": "Could we public events if `manager.serStatus()`?" }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to throw an error here. It's not clear to the user what they should do if they try to install a plugin that doesn't exist on the page.", + "prediction": "I'm not sure if this is the right place to throw an error here, but I think it would be good to throw an error here. It's not clear to me if this is the right place to throw an error here, but I think it would be good to throw an error here. It's not clear to me if this is the right place to throw an error here, but I think it would be good to throw an error here. It's not clear to me if this is the right place to throw an error here, but I think it would be good to throw an error here. It's not clear to me if this is the right place to throw an error here, but I think it would be good to throw an error here. It's not clear to me if this is the right place to throw an error here, but I think it would be good to throw an error here. It's not clear to me if this is the right place to throw an error here, but I think it would be good to throw an error here. It's not clear to me if this is the right place to throw an error here, but I think it would be good to throw an error here. It's not clear to me if this is the", "reference": "could be misread as ``, maybe something redundant but very clear like \"before the closing `` tag\"?" }, { - "prediction": "I think this should be `await` instead of `return Task.CompletedTask`.", + "prediction": "I think we can remove the `using` block here, since we're not using the `Response.Body` anymore.", "reference": "This test is specifically checking behavior on sync I/O (note there are tests with Write in the name, and other tests with WriteAsync). Enable sync I/O here." }, { - "prediction": "I think this should be `weekly_update` instead of `weekly_update`", + "prediction": "I think this should be `WeeklyIterationDripMailer` instead of `WeeklyIterationDripMailerPreview`", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { @@ -14963,19 +14963,19 @@ "reference": "This seems like an improved pattern :)" }, { - "prediction": "I'm not sure what you mean by \"snakebite\". I'm not sure what you mean by \"snakebite\". I'm not sure what you mean by \"snakebite\". I'm not sure what you mean by \"snakebite\". I'm not sure what you mean by \"snakebite\". I'm not sure what you mean by \"snakebite\". I'm not sure what you mean by \"snakebite\". I'm not sure what you mean by \"snakebite\". I'm not sure what you mean by \"snakebite\". I'm not sure what you mean by \"snakebite\". I'm not sure what you mean by \"snakebite\". I'm not sure what you mean by \"snakebite\". I'm not sure what you mean by \"snakebite\". I'm not sure what you mean by \"snakebite\". I'm not sure what you mean by \"snakebite\". I'm not sure what you mean by \"snakebite\". I'm not sure what you mean by \"snakebite\". I'm not sure what you mean by \"snakebite\". I'm not sure what you mean by \"snakebite\". I'm not sure what you mean by \"snakebite\". I'm not sure what you mean by \"snakebite\". I'm not sure", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `snakebite` module here, since it's a bit easier to use than `configuration.get_config().get(\"hadoop\", \"version\", \"cdh4\").lower()`.", "reference": "I think it would be better to have a separate configuration option for specifying which HDFS interaction layer to use instead of using the existing hadoop version option. I think there are still cases where things might have to rely on Hadoop version for other things, and overwriting that information with \"snakebite\" would make that difficult. The existing hadoop version option could still be used to distinguish the different HDFS CLI flavours." }, { - "prediction": "I think this should be `pal.list_tasks` instead of `pal.list_tasks(filter_content: true)`.", + "prediction": "I think this should be in `list_tasks` instead of `list_tasks_by_filter`.", "reference": "Why are we filtering content twice? It seems like just filtering it in PAL should work." }, { - "prediction": "I'm not sure what you mean by \"expand the statuses provided here to be more specific in case the\"", + "prediction": "I don't think we need to expand the statuses to be more specific. We can just use `ACCOUNT_STATUS_NONE`, `ACCOUNT_STATUS_MULTIPLE`, `ACCOUNT_STATUS_DISAPPROVED`, `ACCOUNT_STATUS_GRAYLISTED`, `ACCOUNT_STATUS_APPROVED`, and `ACCOUNT_STATUS_NO_CLIENT`.", "reference": "These should probably move to `constants.js`" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. The `ManagedObject` class is not part of the `org.apache.http.client.methods` package. It's part of the `org.apache.http.impl.client` package, which is not part of the `org.apache.http.client.methods` package. I think it's a good idea to remove the `ManagedObject` class from the `org.apache.http.client.methods` package, as it's not part of the `org.apache.http.client.methods` package.", + "prediction": "I don't think this is necessary. The `ManagedObject` class is not used anywhere in this code, so we can remove it.", "reference": "Again, you don't want to depend on glassfish." }, { @@ -14983,67 +14983,67 @@ "reference": "it should be `Faker::Space.launch_vehicle`, otherwise it will crash" }, { - "prediction": "I think this should be `if (this.ArchiveNumbering == ArchiveNumberingMode.Date && this.ArchiveEvery != FileArchivePeriod.None)` instead of `if (this.ArchiveNumbering == ArchiveNumberingMode.Date && this.ArchiveEvery != FileArchivePeriod.None && this.ArchiveEvery != FileArchivePeriod.None)`", + "prediction": "I think this should be `if (this.ArchiveNumbering == ArchiveNumberingMode.Date && this.ArchiveEvery != FileArchivePeriod.None)`", "reference": "Isn't it quite expensive to check whether the file exists on every write?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `webdriver.http.XhrClient` instead of `webdriver.http.CorsClient` in this case.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in `webdriver.http.XhrClient`", "reference": "Please hide this behind a flag and add a setter function to the builder." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `deleteAll` method in the `cloudBackup` struct. This way, we don't need to create a new `cloudBackupDeleteAll` method in the `cloudBackup` struct, and we don't need to create a new `cloudBackupDelete` method in the `cloudBackup` struct. This way, we don't need to create a new `cloudBackupDeleteAll` method in the `cloudBackup` struct, and we don't need to create a new `cloudBackupDelete` method in the `cloudBackup` struct. This way, we don't need to create a new `cloudBackupDeleteAll` method in the `cloudBackup` struct, and we don't need to create a new `cloudBackupDelete` method in the `cloudBackup` struct. This way, we don't need to create a new `cloudBackupDeleteAll` method in the `cloudBackup` struct, and we don't need to create a new `cloudBackupDelete` method in the `cloudBackup` struct. This way, we don't need to create a new `cloudBackupDeleteAll` method in the `cloud", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `deleteAll` method in the `cloudBackup` struct.", "reference": "old api should be deprecated if we don't intend on using it anymore. Again this should happen through swagger api and then removed from next release. We should also release not this as a breaking change. (same with all the other cloudsnap api renames." }, { - "prediction": "I think we can remove the `log.warn` here.", + "prediction": "I think it's better to use `log.warn` instead of `log.error` in this case.", "reference": "so strange...... canTcpListen is to detect, if this transport can init when customers deployed vertx and servlet rest transport, we must detect which one will be used only both of them refused to init is a problem. we have already print that......" }, { - "prediction": "This should be `SELECT COUNT(*)` instead of `SELECT count(*)`", + "prediction": "I don't think this is needed anymore.", "reference": "Did you mean for this to be `FORM`, instead of `FROM`?" }, { - "prediction": "I think we can remove the `UncompressedUserData` field, as it's not used anywhere.", + "prediction": "I think we should remove the `UncompressedUserData` field, as it's not used anywhere.", "reference": "What are your thoughts on the long term solution for the naming of this variable? Do you think we should revert the logic when we are ready to make the next set of breaking API changes?" }, { - "prediction": "I think this should be `if fail_on_error && !success` instead of `if fail_on_error && !success && exit $?exitstatus`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `spec_helper.rb` file.", "reference": "There's a syntax error on this line." }, { - "prediction": "I think this should be `result = fpgaObjectRead64(port_error_object, &value, 0);` instead of `result = fpgaObjectRead64(port_error_object, &value, 0);`", + "prediction": "I think this should be `result = fpgaObjectRead64(port_error_object, &value, 0);` instead of `result = fpgaObjectRead64(port_error_object, &value, 0); if (result != FPGA_OK) { return result; } goto out;`", "reference": "You lose the value of `result` when you `goto out`" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `onScroll_` event handler.", + "prediction": "I think it's better to use `this.ratio_ == undefined ? 0 : this.ratio_` instead of `this.ratio_ == undefined ? 0 : this.ratio_ == 0 ? 0 : this.ratio_`.", "reference": "Just a style thing, why not `this.ratio_ || 0`?" }, { - "prediction": "I'm not sure what you mean by `getMaskedIp(ipNet)`. Is this the same as `FromNetIP(ipNet.IP)`, or is it something else?", + "prediction": "I think this should be `FromNetIP` instead of `getMaskedIp`?", "reference": "I think the stdlib's `net.IP` has a `Mask()` method, does that do what we need?" }, { - "prediction": "I don't think this is a good idea. It would be better to use `replace` instead of `replacer`.", + "prediction": "I don't think we need to do this.", "reference": "Why does substitute need to be public? Are we allowing/encouraging variable usage when using Daisy as a library?" }, { - "prediction": "I think this should be `self._tab` instead of `self`?", + "prediction": "I think this should be `self._tab.key_press(Qt.Key_Return)` instead of `self._tab.key_press(Qt.Key_Enter)`.", "reference": "We should probably use ctrl-enter if `tab` is given, just like in `follow_selected`?" }, { - "prediction": "I'm not sure what you're trying to achieve with this code, but I think it's a bit confusing. It looks like you're trying to create a dispatcher and a membership monitor, but then you're trying to create a new `params.RPCFactory`, which doesn't make sense. I think you want to create a new `params.RPCFactory` and then create a new `params.MembershipFactory`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to `params.RPCFactory.CreateDispatcher()` and `params.RPCFactory.CreateTChannelDispatcher()` so that we don't have to call `params.RPCFactory.CreateDispatcher()` every time we want to create a new dispatcher.", "reference": "This file looks like anti pattern `ServiceLocator` and lucky it's not used anywhere. Can I remove it? (in separate PR)." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this.", + "prediction": "I think this should be `getDownloadSizeNumeric` instead of `getDownloadSize`", "reference": "we can just have this method call the next, passing in the file metadatas (deduplication of logic)" }, { - "prediction": "I think this should be in `TabBar` instead of `TabBarStyle`?", + "prediction": "I think this should be in `tabbed_browser` instead of `objreg`?", "reference": "What happens here if you send the `wheelEvent` directly to the `tabbed_browser` and let it take care of propagating it to its children (i.e. the focused tab)? If that works, I guess that'd be cleaner." }, { - "prediction": "I think this should be in the same file as the rest of the code. It's not clear to me what the purpose of this function is.", + "prediction": "I don't think we need to do this.", "reference": "it seems python 2 don't support `end=''`. @StrikerRUS @henry0312 any better solution? or we drop the support of python 2?" }, { @@ -15051,39 +15051,39 @@ "reference": "This test already exists in the object_tracker layer." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get the privacy parameters from the private state. I'm not sure what you're trying to do here, but it looks like you're trying to get the privacy parameters from the private state. I'm not sure what you're trying to do here, but it looks like you're trying to get the privacy parameters from the private state. I'm not sure what you're trying to do here, but it looks like you're trying to get the privacy parameters from the private state. I'm not sure what you're trying to do here, but it looks like you're trying to get the privacy parameters from the private state. I'm not sure what you're trying to do here, but it looks like you're trying to get the privacy parameters from the private state. I'm not sure what you're trying to do here, but it looks like you're trying to get the privacy parameters from the private state. I'm not sure what you're trying to do here, but it looks like you're trying to get the privacy parameters from the private state. I'm not sure what you're trying to do here, but it looks like you're trying to get the privacy parameters", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the `EthGetCode` class as well, since it's used in the `EthGetCode` and `EthGetCodeByBlockHash` methods.", "reference": "Same here, can we presume if `privacyParameters` is set we need goQuorum handling? Or is there a goQuorum sub option in `privacyParametes`?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.", + "prediction": "I don't think we need to do this.", "reference": "The addition of delete files in `newManifests` far above the addition of data files threw me a bit. Is it intentional to ensure the delete files are at the front of the list?" }, { - "prediction": "I think this should be `raise ValidationError.new(\"Groups must be an Array\", nil)` instead of `raise ValidationError.new(\"Groups must be an Array\", nil) unless groups.is_a?(Array)`.", + "prediction": "I'm not sure what you mean by \"groups must be an Array\". I think you meant to say \"groups must be an Array of Groups\".", "reference": "Interesting. The call to `Array(groups)` below this would seem to indicate this doesn't _have_ to be an array. I think the problem is actually that passing a hash to `Array()` actually converts the hash to an array of key/value pairs rather than wrapping it in an array. So maybe `Array(groups)` should be `groups = [groups] unless groups.is_a?(Array)`." }, { - "prediction": "I think this should be `MAX_SNAPSHOT_AGE_MS` instead of `MAX_SNAPSHOT_AGE_MS_DEFAULT`?", + "prediction": "I don't think we need to change the default value of `MAX_SNAPSHOT_AGE_MS` to `5 * 24 * 60 * 60 * 1000`.", "reference": "This is not a particularly good default but we need it to keep the old behavior." }, { - "prediction": "I'm not sure I understand what you're trying to do here. Can you please provide some more context?", + "prediction": "I'm not sure what you're trying to achieve with this test. It seems like you're trying to call `PBTestActor.ParamsNotZero` with a condition, but it's not working as expected. Could you please provide more details on what you're trying to achieve with this test?", "reference": "We have other tests to assert all properties of a condition are valid. It's enough to assert the condition is not nil here." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `opsv1alpha1` package.", + "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to have this in the same file as the rest of the code.", "reference": "shouldn't the import be renamed `crdv1alpha1` by convention? It seems that you took care of renaming everywhere else..." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to merge the two config files, but you're not doing anything with the merged config file.", + "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a `pauseContainerTarballPath` and a `pauseContainerTag` in the config file.", "reference": "nit: Can Linux-specific paths be moved to a conditionally-compiled file for Linux?" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a `getCount()` method to the `SessionMap` class.", + "prediction": "I don't think this is needed anymore.", "reference": "This is not the right approach. The `Distributor` maintains a model of the current state of the Grid. That model already contains the information about every active session. We don't need to modify `SessionMap` to expose it further." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate function for handling the `for-push` case.", + "prediction": "I think this should be `if len(args) == 1 && args[0] == \"for-push\"`", "reference": "Git doc seems to suggest `for-push` is a optimization. Do we have a plan/ticket for treating them differently?" }, { @@ -15091,11 +15091,11 @@ "reference": "This not necessary since you moved the layers to `contrib/`." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to set the log level for the console, but I'm not sure what you're trying to do here. I think you're trying to set the log level for the console, but I'm not sure what you're trying to do here. I think you're trying to set the log level for the console, but I'm not sure what you're trying to do here. I think you're trying to set the log level for the console, but I'm not sure what you're trying to do here. I think you're trying to set the log level for the console, but I'm not sure what you're trying to do here. I think you're trying to set the log level for the console, but I'm not sure what you're trying to do here. I think you're trying to set the log level for the console, but I'm not sure what you're trying to do here. I think you're trying to set the log level for the console, but I'm not sure what you're trying to do here. I think you're trying to set the log level for the console, but I'm not sure what you're trying to do here. I", + "prediction": "I don't think this is a good idea. I think it should be `--log-level` instead of `--log-level LEVEL`.", "reference": "I think this also needs to be removed from `resources/bolt_bash_completion.sh`, `rakelib/pwsh.rake`, `lib/bolt_spec/plans.rb`, and `lib/bolt/config/options.rb`." }, { - "prediction": "I'm not sure what you mean by \"must_respond_with :redirect\" in this case. I think it should be `must_respond_with :success` instead.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate controller for password resets, so that we don't have to duplicate the logic in the `create` action.", "reference": "I fixed this today with a direct push to master. My build was failing otherwise." }, { @@ -15107,7 +15107,7 @@ "reference": "Not needed, please remove." }, { - "prediction": "I think this should be `if (!h2o_url_compare_hosts(loc_parsed.host, match->host, match->host_is_unix_path))` instead of `if (!h2o_lcstris(loc_parsed.host.base, loc_parsed.host.len, match->host.base, match->host.len))`", + "prediction": "I think this should be `if (!h2o_url_compare_hosts(loc_parsed.host, match->host, match->host_is_unix_path))` instead of `if (!h2o_url_compare_hosts(loc_parsed.host.base, loc_parsed.host.len, match->host.base, match->host.len))`", "reference": "Shouldn't the logic be: * the result is a mismatch if either is a unix path but the other is not * if both are unix paths, then perform case-sensitive comparison * if both are not unix paths, then perform case-insensitive comparison" }, { @@ -15115,23 +15115,23 @@ "reference": "This is just rearranging it alphabetically" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a test for this. It's not clear to me why we'd want to do this, but I think it's a good idea to add a test for this.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a docstring for this test.", "reference": "I think this disables it for the rest of the file - you should be able to use it inside of the function instead." }, { - "prediction": "I don't think we need to change the `MediaInterface` to `MediaInterface|int|string` in this case. We can just use `MediaInterface` and `MediaInterface|int|string` in both cases.", + "prediction": "I don't think this is needed.", "reference": "this could receive the MediaInterface directly or an identifier, it is correct to type it with int|string? or just use mixed?" }, { - "prediction": "I think it's better to use `comparators.length` instead of `comparators.length - 1` in `leafValue(int docID)`.", + "prediction": "I think it's better to use `comparators.length` instead of `comparators.length - 1`.", "reference": "Why not return `Object[]`?" }, { - "prediction": "I think we should remove the `null` check for `length` and `sequenceNumber` in `GenericManifestFile`.", + "prediction": "I think it's better to use `Long` instead of `Integer` for `deletedRowsCount` and `deletedRowsCount` because `deletedRowsCount` can be negative.", "reference": "Looks like we are trying to match the new ordering of fields in `ManifestFile`. Earlier, we co-located `...FilesCount` with `...RowsCount` to match the ordering of methods in `ManifestFile` and args in constructors. Is this change intentional?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to remove the monster from the game, but you're also trying to add a new monster to the game. Is this what you're trying to do? If so, I think you should remove the monster from the game first, and then add the new monster to the game.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to `Monster::onThinkAttack` as well.", "reference": "You're already setting drop loot to false just above." }, { @@ -15139,19 +15139,19 @@ "reference": "`once` is very generic and doesn't specify it's purpose - `closeOnce`?" }, { - "prediction": "I think we can remove the `getTableBasePath` method, as it's not needed anymore.", + "prediction": "I don't think this is necessary.", "reference": "Why did this need to change from `private`? Oh for the test below. And this is only a test class too." }, { - "prediction": "Shouldn't this be `require 'test_helper'` instead of `require 'test_helper'`?", + "prediction": "Shouldn't this be `require 'test_helper'`?", "reference": "Should test the `has?` method here" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in a separate test.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check for the presence of the `Save Search` button.", "reference": "I think you want to be asserting/clicking $saveLink, not $link." }, { - "prediction": "I don't think we need to add `target_name` to the `asset_sensor` definition.", + "prediction": "I don't think we need to add `target_name` to the `sensor` and `asset_sensor` functions.", "reference": "We don't have `target_name` on `@sensor` - why introduce it for `@asset_sensor`? If we do want to introduce it everywhere, can we just call it `job_name` to avoid introducing a new term?" }, { @@ -15159,23 +15159,23 @@ "reference": "Missing copyright header (+other new files)." }, { - "prediction": "I think this should be `StringType$.MODULE$` instead of `StringType$.MODULE$`", + "prediction": "I think this should be `StringType$.MODULE$` instead of `StringType$.MODULE$.MODULE$`", "reference": "Could we do the flag check here as well to check whether or not we have enabled the \"Handle without timezone\" flag here as well? We may be using this not on the read path (like in the migrate/snapshot code) and it would be good to catch it here as well and make sure users know what is happening." }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it would be a good idea to move this to a separate file. It's a bit of a duplicate of the `PipelineFailureSensorContext` class, but I think it would be a good idea to have it in a separate file.", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be good to add a docstring to this function.", "reference": "why is the file named `pipeline_definition_definition_sensor`?" }, { - "prediction": "I think this should be `if not conf[\"SQLALCHEMY_TIMESCALE_URI\"]:` instead of `if not conf[\"SQLALCHEMY_TIMESCALE_URI\"]:`.", + "prediction": "I think this should be `if not conf[\"SQLALCHEMY_TIMESCALE_URI\"]:`", "reference": "None not needed, can just be `return`. not important for this release" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to remove the `{{.RecaptchaSiteKey}}` from the template.", + "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to have it in the top page template.", "reference": "I think it's missing closing `

    ` tags in line 108 and 109 unless they don't matter..." }, { - "prediction": "I think this should be `true` instead of `false`.", + "prediction": "I think this should be `false` by default.", "reference": "So it seems that loading a script file from the classpath needs to be enabled explicitly now since this is `false` by default. Is it possible to enable this via the YAML config file in a Camunda Platform Run distribution?" }, { @@ -15183,11 +15183,11 @@ "reference": "can we delete any code in the provider implementation? i imagine the entire thing is unused now?" }, { - "prediction": "I'm not sure why this is deprecated. It's not used anymore. I think we should just remove it.", + "prediction": "I'm not sure why this is deprecated. It's not used anymore.", "reference": "I suggest we remove all these unused functions. I don't expect any external projects to be importing packages from `cert-manager/test/...`" }, { - "prediction": "I think we can remove the `if (request->size() >= 0)` check.", + "prediction": "I think this should be `m_AggregatedMetadataMutex.lock()` and `m_AggregatedMetadataMutex.unlock()` instead of `m_AggregatedMetadataMutex.lock()` and `m_AggregatedMetadataMutex.unlock()`.", "reference": "Looks like the template argument doesn't resolve by default so you need `std::lock_guard lck`" }, { @@ -15195,35 +15195,35 @@ "reference": "Are we removing this public method? Could it be useful to someone? Maybe we could implement it once in Node using the metamodel" }, { - "prediction": "I think this should be `self == self.class.popular` instead of `self == self.class.popular`", + "prediction": "I'm not sure what you mean by \"includes_exercises?\"", "reference": "I think this method is unused now?" }, { - "prediction": "I think this should be `controllerQuerier := querier.NewControllerQuerier(networkPolicyController, o.config.APIPort)` instead of `controllerQuerier := querier.NewControllerQuerier(networkPolicyController, cnpInformer, anpInformer)`", + "prediction": "I think it's better to use `controllerQuerier` instead of `endpointQuerier` in this case.", "reference": "I know we discussed this before and decided to reuse the AntreaPolicy gate. But do you think realization status will introduce much overhead or not?" }, { - "prediction": "I think it's a good idea to make this a constant, so we don't have to change it every time we add a new controller.", + "prediction": "I think it's better to use `RunEdgecore` and `RunEdgeSite` instead of `RunController` and `RunEdgecore`.", "reference": "please add a blank line at the end of this file. Applicable to similar cases below" }, { - "prediction": "I'm not sure what you mean by \"fixUpHost\" here. I think you meant to say `pendingRequest.configuration.remoteHost = pendingConfiguration.remoteHost;` or `pendingRequest.configuration.host = pendingConfiguration.host;`?", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the remote host is valid. If the remote host is not valid, then the request will fail.", "reference": "This is not really needed, the line added in `GridNodeConfiguration.java` is what really fixes the `remoteHost` regression." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the joinQuery class. The joinQuery class is the base class for all join queries, so it would make sense to move this logic to the joinQuery class.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `joinQuery` class.", "reference": "filterCache can be null" }, { - "prediction": "I don't think we need to use `sync.RWMutex` here. We can use `sync.Mutex` instead.", + "prediction": "I don't think we need to use `sync.Mutex` here. We can use `sync.RWMutex` instead.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to return `SET_PARAM_CMD_FAIL_RSP` in this case.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the parameter name is actually a server loopback mode parameter. If it isn't, then we can just return SET_PARAM_CMD_FAIL_RSP. I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the parameter name is actually a server loopback mode parameter. If it isn't, then we can just return SET_PARAM_CMD_FAIL_RSP. I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the parameter name is actually a server loopback mode parameter. If it isn't, then we can just return SET_PARAM_CMD_FAIL_RSP. I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the parameter name is actually a server loopback mode parameter. If it isn't, then we can just return SET_PARAM_CMD_FAIL_RSP. I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the parameter name is", "reference": "If strstr returns NULL, the check on 378 won't fire, because param_name will be at least SET_PARAM_CMD_LEN." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check that the number of work items per group is a multiple of the vector size.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to check for overflow here. I'm not sure if this is a good idea, but I think it's a good idea to check for overflow here. I'm not sure if this is a good idea, but I think it's a good idea to check for overflow here. I'm not sure if this is a good idea, but I think it's a good idea to check for overflow here. I'm not sure if this is a good idea, but I think it's a good idea to check for overflow here. I'm not sure if this is a good idea, but I think it's a good idea to check for overflow here. I'm not sure if this is a good idea, but I think it's a good idea to check for overflow here. I'm not sure if this is a good idea, but I think it's a good idea to check for overflow here. I'm not sure if this is a good idea, but I think it's a good idea to check for overflow here. I'm not sure if this is a good idea, but I think it's a good idea to check for overflow here. I'm not sure if this", "reference": "Does this change affect the performance of other algorithms, except KMeans?" }, { @@ -15231,31 +15231,31 @@ "reference": "What do these changes have to do with the request ID?" }, { - "prediction": "I think we can remove the `static const int TEAM_SIZE = 16;` since it's not used anywhere.", + "prediction": "I think we can remove the `static const int TEAM_SIZE = 16;` line.", "reference": "I'm kind of surprised this doesn't require `typename`?" }, { - "prediction": "I don't think we need to use `logging` package here. We can just use `log` package instead.", + "prediction": "I don't think we need to use `logging` package here. We can use `github.com/algorand/go-algorand/logging` instead.", "reference": "nit: move this one down." }, { - "prediction": "I'm not sure what you're trying to say here. Is it that the `group` parameter should be a string, or should it be a `BoxWhisker` object?", + "prediction": "I don't think this is a good idea. The `group` parameter should be a string, not a `param.String` object.", "reference": "maybe 'standard Tukey boxplot definition' if it is standard? Otherwise sounds like it is just *a* definition for boxplots..." }, { - "prediction": "I'm not sure if this is a good idea, but I think it's better to have a `git-version` variable than a `gitVersion` variable.", + "prediction": "I'm not sure if this is a good idea, but I think it's better to have a `gitVersion` field in the `gitattributes` file than to have a `gitVersion` field in the `gitattributes` file and a `gitCommit` field in the `gitattributes` file.", "reference": "I feel we should not fix this." }, { - "prediction": "I think this should be `#include ` instead of `#include `.", + "prediction": "I think this should be `#include `.", "reference": "I think these are not necessary" }, { - "prediction": "I'm not sure if this is the right place to remove this flag, but I think it's a good idea to remove it. It's not clear to me why it was there in the first place, and I don't think it's a good idea to keep it.", + "prediction": "I'm not sure if this is the right place to remove this flag, but I think it's a good idea to remove it. It's not clear to me why we would want to re-analyze the same translation unit if Cross-TU analysis failed.", "reference": "Please update the user guide too." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good place to do this.", "reference": "If you use `compact('name', 'code')` here, you'll get an associative array, which might make the rest of the code more readable (instead of using hard-coded 0/1 indexes)." }, { @@ -15263,7 +15263,7 @@ "reference": "Should it be 2011-14 instead ;-)" }, { - "prediction": "I'm not sure what you're trying to do here. The `MaxIdleConnections` setting is only used for the `sql.DB` connection pool, not the `client` connection pool. If you want to set the `MaxIdleConnections` for the `client` connection pool, you should do that in the `New` function, not in the `NewClient` function.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to set the `MaxIdleConnections` in the `New` function as well. This way, if the `MaxIdleConnections` is set in the `New` function, it will override the `MaxIdleConnections` in the `client` function.", "reference": "I want to write some type of test for this but there are not Getter methods to assert this value. I tried to extract the value via the stats that are exposed without luck." }, { @@ -15271,19 +15271,19 @@ "reference": "This needs to take the group id, not the gsuite id." }, { - "prediction": "I'm not sure what you mean by \"empty result\" in this context. It's not clear to me what you're trying to do with it.", + "prediction": "I'm not sure if this is the right place to add this, but I think it would be good to add it to the `SarifConverter.cs` file as well.", "reference": "These should use the constants defined in JsonTests.cs" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a default value for the `data` property.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `google-site-kit` component.", "reference": "Kind of unrelated to this PR, but let's update this to `getDataErrorComponent( 'search-console', error.message, false, false, false, error )` so that everything is passed as expected." }, { - "prediction": "`self.file_client` should be `self.file_client = None` instead of `self.file_client = None`", + "prediction": "I don't think we need to call `mmcv.FileClient` here. We can just use `self.file_client` directly.", "reference": ":obj:\\`dataset\\` cannot be correctly rendered" }, { - "prediction": "I'm not sure what you're trying to achieve with this method, but it looks like you're trying to return the user's login/identifier. I'm not sure what you're trying to achieve with this method, but it looks like you're trying to return the user's login/identifier. I'm not sure what you're trying to achieve with this method, but it looks like you're trying to return the user's login/identifier. I'm not sure what you're trying to achieve with this method, but it looks like you're trying to return the user's login/identifier. I'm not sure what you're trying to achieve with this method, but it looks like you're trying to return the user's login/identifier. I'm not sure what you're trying to achieve with this method, but it looks like you're trying to return the user's login/identifier. I'm not sure what you're trying to achieve with this method, but it looks like you're trying to return the user's login/identifier. I'm not sure what you're trying to achieve with this method, but it looks like you're trying to return the user's login/identifier. I'm not sure what you're trying to achieve with this method, but it", + "prediction": "I'm not sure what you mean by \"user-displayable login/identifier\". Is it something like a username or something else?", "reference": "I think `email` is something we get from devise, and I think the goal of putting it in the generator was not to tie others to that particular implementation?" }, { @@ -15291,11 +15291,11 @@ "reference": "If the span producers pushing to the queue do so faster than the this can drain, it will cause this to hang. I'm guessing we can update the `enqueue` method to check if the `stopCh` is closed and not send any more spans while this flushes what has already been pushed." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a method to `GalleryInterface` that returns the `GalleryItems` collection.", + "prediction": "I don't think you need to use `clear` here. `addGalleryItem` already clears the collection.", "reference": "Not sure about that, an array is iterable right? But if I pass array, that clear method wont work" }, { - "prediction": "I think we can remove the `iface` package as it's not used anywhere in this test suite.", + "prediction": "I'm not sure if this is a good place to put it, but I think we should move it to the `testing` package.", "reference": "make sure the config changes stuck. are there any invalid config values? maybe write tests around empty `trust_domain`, negative/missing `ttl`, invalid `key_size`, etc..." }, { @@ -15303,87 +15303,87 @@ "reference": "Why are you changing this?" }, { - "prediction": "I'm not sure what you mean by \"one letter followed by 7 numbers\"", + "prediction": "I don't think this is necessary.", "reference": "@phirefly Can we look at a list of RWAs, or ask someone to double-check that this format is correct? Otherwise :shipit:" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add this option to the `SparkWriteOptions` class as well. This way, if you want to use a different distribution mode, you can do so without having to modify the `Spark3BinPackStrategy` class.", + "prediction": "I think we should use `writeMaxFileSize()` instead of `writeMaxFileSizeBytes()`.", "reference": "Still request a local sort for bin-packing based on the defined table sort order." }, { - "prediction": "I think we can remove the `users` argument and just pass the list of users to the `request_candidate_sets` function.", + "prediction": "I don't think we need to use `parse_list` here. We can just use `users` directly.", "reference": "As with the other PR, user name is better." }, { - "prediction": "I think it's better to use `s.metrics` instead of `s.chequebook.AvailableBalance`.", + "prediction": "I think it's better to use `s.chequebook.AvailableBalance` instead of `s.chequebook.AvailableBalance.Int64()`.", "reference": "a peer's accounting lock is held during `Pay`. we should avoid adding additional blockchain calls here if possible." }, { - "prediction": "I'm not sure if this is a good idea, but I think we should remove it.", + "prediction": "I'm not sure what you mean by \"developer edition\" of the Node.JS SDK for Realm. I think it's just the Node.JS SDK for Realm, right?", "reference": "Maybe wording could be improved. Is this \"not enabled\" or it is \"not available\". Not sure about that." }, { - "prediction": "I don't think we need to use `conditionalBranchesEvaluated` here. We can just use `node.Status.Phase == corev1.PodFailed || node.Status.Phase == corev1.PodSucceeded`.", + "prediction": "I don't think we need to do this, we can just use the `conditionalBranchesEvaluated` function to check if the branch is evaluated or not.", "reference": "I looked at the new `conditionalBranchesEvaluated` function and it looks like the part added is a duplicate of the line above?" }, { - "prediction": "I'm not sure what you're trying to do with this file, but I don't think it's necessary.", + "prediction": "I'm not sure what you mean by \"presence of this file indicates the block has been successfully flushed\"", "reference": "can you put this flag in `blockRefInfo` instead? It would be a shame to add one more file per block, especially since we've run into inode limits. I guess `blockRefInfo` should maybe then be renamed to `blockInfo` or something. But we're stuck with the filename." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `cfg.IP` field to store the IP address, and the `cfg.Port` field to store the port number. This way, we don't need to check for `cfg.IP == nil` and `cfg.Port == 0` in the `Parse` function.", + "prediction": "I think it's better to use `cfg.IP` and `cfg.Port` instead of `*cfg.IP` and `*cfg.Port`.", "reference": "Shouldn't we keep other parameters if only IP is empty? Or maybe return an error if it's a mandatory argument?" }, { - "prediction": "I think this should be `ndmap = MultiDimensionalMapping(self.init_items_1D_list, kdims=[self.dim1, self.dim2])`", + "prediction": "I think this should be `self.assertEqual(redimmed.kdims, [Dimension('Integer', type=int), Dimension('floatdim', type=float)])` instead of `self.assertEqual(redimmed.kdims, [Dimension('Integer'), Dimension('floatdim')])`", "reference": "Was this just wrong before? The names indicated types but type wasn't specified. I guess the tests passed as comparison worked with ``type=None``?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is the right place to do this.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `icebergColOpt.isPresent()` to make sure we don't try to use a non-existent `icebergColOpt`.", "reference": "icebergCol.name() is the unqualified column name" }, { - "prediction": "I'm not sure what you mean by \"insufficient_data_actions\" and \"ok_actions\"", + "prediction": "I don't think we need to add the `alarm_actions` and `insufficient_data_actions` to the `MetricAlarm` class.", "reference": "It's generally a bad idea to use mutable types like lists as default values for parameters. Lots of strange, difficult to debug side effects can occur. I see that there was already one example of this prior to this commit which probably explains why it seemed innocuous to add more but I'm going to rework this before committing to master." }, { - "prediction": "I don't think we need to add `eslint-config-prettier` to the list of `prettier` rules. The `@typescript-eslint` rule is already included in `eslint-config-prettier`.", + "prediction": "I don't think you need to add `eslint-config-prettier` to the list.", "reference": "We run prettier as an eslint plugin, so this harmful" }, { - "prediction": "I think this should be `m_DynType` instead of `m_DynType_ptr`", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a `HelloWorldPublisher` with a `DynamicType` that is `nullptr`, but I don't think that's what you're trying to do.", "reference": "Check if the TypeDescriptor and MemberDescriptor includes are necessary" }, { - "prediction": "I don't think we need to change anything in this file. I think we can just remove the `k8s.io/apimachinery/pkg/api/errors` package.", + "prediction": "I think we can remove the `k8s.io/apimachinery/pkg/api/errors` package as it's not needed anymore.", "reference": "delete the empty line here." }, { - "prediction": "I'm not sure what you mean by \"unsets scheduled_for_deactivation_on\"", + "prediction": "I don't think this is a good idea. I think it's better to have a `scheduled_for_deactivation_on` attribute on the `Subscription` model.", "reference": "Line is too long. [89/80]" }, { - "prediction": "I don't think this is necessary.", + "prediction": "I don't think this is needed.", "reference": "You don't need to expose this method to do what you want. There are already public addNewGetMapping, addNewPostMapping, and addNewDeleteMapping methods." }, { - "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea.", + "prediction": "I'm not sure what you mean by \"body not written\" but I think this test is failing because the `Content-Length` header is not being set.", "reference": "This test passes in `dev`. Why wouldn't this work?" }, { - "prediction": "I think this should be `import os` instead of `import datetime`?", + "prediction": "I'm not sure what you mean by `os` here. It's not a Python package, it's an OS module.", "reference": "ARN -> Amazon Resource Number (ARN)" }, { - "prediction": "I think we can remove the `services.AddSingleton(new KestrelTestLoggerFactory(testLogger));` line.", + "prediction": "I think this should be `services.AddSingleton(new KestrelTestLoggerFactory(testLogger));`", "reference": "Why not use the overload that takes an instance?" }, { - "prediction": "I don't think we need to use grpc here. We can just use `ioctl` directly.", + "prediction": "I don't think we need to use `grpc` here. We can just use `ioctl` for now.", "reference": "`Blockchian` is a misspelling of `Blockchain` (from `misspell`)" }, { - "prediction": "I don't think this is necessary. The `lock` is only used to ensure that we don't try to modify the `GPUIDs` array while iterating over it. If we don't have a `lock`, we can just iterate over the `GPUIDs` array without worrying about race conditions.", + "prediction": "I don't think this is necessary. The `lock` is only used in the `NewNvidiaGPUManager` function. It's not used anywhere else in the code.", "reference": "`agent/gpu/nvidia_gpu_manager_unix.go:47: struct field lock has json tag but is not exported`" }, { @@ -15395,27 +15395,27 @@ "reference": "Would this mean that podMonitorSelectors suffer from the same issue if they are the only configuration set?" }, { - "prediction": "I'm not sure what you mean by \"disabled applications should not be included in the response\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.", "reference": "`ctx` is unused in GetEnvironment" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `FileUI` class, so that it can be used in other places as well.", + "prediction": "I'm not sure if this is the right place to do this.", "reference": "We usually use OkDialog()" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think we should put it in the `DefaultCommandValues` class.", + "prediction": "I don't think this is a good idea. It's not clear to me why we would want to do this, and it's not clear to me why we would want to do this in the first place. I'm not sure if this is a good idea, but I'm not sure why we would want to do this. I'm not sure if this is a good idea, but I'm not sure why we would want to do this. I'm not sure if this is a good idea, but I'm not sure why we would want to do this. I'm not sure if this is a good idea, but I'm not sure why we would want to do this. I'm not sure if this is a good idea, but I'm not sure why we would want to do this. I'm not sure if this is a good idea, but I'm not sure why we would want to do this. I'm not sure if this is a good idea, but I'm not sure why we would want to do this. I'm not sure if this is a good idea, but I'm not sure why we would want to do this. I'm not sure if this is a good idea, but I'm not sure why we would want to", "reference": "could we please change that to something that indicates that this feature is not \"production\" ready!" }, { - "prediction": "I don't think this is a good idea. We should use `pretrained='imagenet'` instead of `pretrained='swin_small_224_b16x64_300e_imagenet_20210615_110219-7f9d988b.pth'`", + "prediction": "I don't think we need to change the `pretrained` in the `model` section.", "reference": "swim -> swin. Other configs and file names also should be modified." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it seems like you're trying to get a list of all the project ids that are enabled for bigquery. I'm not sure what you're trying to achieve with this, but it seems like you're trying to get a list of all the project ids that are enabled for bigquery. I'm not sure what you're trying to achieve with this, but it seems like you're trying to get a list of all the project ids that are enabled for bigquery. I'm not sure what you're trying to achieve with this, but it seems like you're trying to get a list of all the project ids that are enabled for bigquery. I'm not sure what you're trying to achieve with this, but it seems like you're trying to get a list of all the project ids that are enabled for bigquery. I'm not sure what you're trying to achieve with this, but it seems like you're trying to get a list of all the project ids that are enabled for bigquery. I'm not sure what you're trying to achieve with this, but it seems like you're trying to get a list of all the project ids that are enabled for bigquery. I'm not sure", + "prediction": "I think this should be `get_project_ids` instead of `get_bigquery_projectids`", "reference": "nit: arg description for \"key\"?" }, { - "prediction": "I think we can remove the `*TLF` from the `Handle` and `Opener` interfaces.", + "prediction": "I think it's better to use `*TLF` instead of `(*TLF)` here. `*TLF` is more explicit.", "reference": "If we don't have a `dir` yet, we wouldn't need to do a sync right? If so, perhaps we can just `getStoredDir()` like `Attr()`?" }, { @@ -15423,15 +15423,15 @@ "reference": "I still don't seem to fully understand this. Why are we testing the host if DR_HOST_NOT_TARGET is not set?" }, { - "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to use the `storerMock` and `statestoreMock` here.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate test for the `fileDownloadResource` and `fileUploadResource` methods.", "reference": "in the current implementation, both schemes are supported (you can call either `/bzz` or `/v1/bzz`). i would suggest to keep it this way" }, { - "prediction": "I think we can remove the `if` statement here. It's not necessary.", + "prediction": "I think it's better to use `error.details` instead of `error.message` in this case.", "reference": "hmm, I think we can just do `new Error(assembly.error)` and that should set `error.message` correctly too. I don't know why it was done this way with a separate `.message` assignment before :sweat_smile: Should we do `error.assembly = assembly` so the template editor can access it that way, rather than parsing `error.details`?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do it here.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `access` field.", "reference": "This should never be empty. The access field always needs a value of at least `c:0` or `r:0`" }, { @@ -15439,7 +15439,7 @@ "reference": "Another question is, do we want to call `os.Getenv()` every time we parse a file? That seems a lot." }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is this for a specific use case? If so, please provide more context.", + "prediction": "I'm not sure what you're trying to achieve with this method, but it looks like you're trying to create a new instance of `Tuple` by appending or prepending an element to an existing `Tuple`. Is this what you're trying to do? If so, please provide more context and I'll be happy to help.", "reference": "minor: please rename all occurrences of `A` to `T`. please also rename `v` to `value`." }, { @@ -15451,39 +15451,39 @@ "reference": "can you change this instead to just `type.toString()` and then you wouldn't have to expose the getBitMask in the enum. (Alternatively you could have used `type.hashCode()` but that doesn't feel as nice)" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to plot the importance of each feature. I think you want to plot the importance of each split, so I think you should be using `lgb.plot_importance` instead of `lgb.plot_importance_split`.", + "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. If you want to plot the importance of each feature, you should use `lgb.plot_importance(gbm0, title='t @importance_type@', xlabel='x @importance_type@', ylabel='y @importance_type@')` instead.", "reference": "I'm confused by these tests. Shouldn't the template string `@importance_type@` have been replaced with the actual value of `importance_type`?" }, { - "prediction": "I think we should remove the `byte` from the name of the key, since it's not used anymore.", + "prediction": "I think we should use `NewKeeper` instead of `NewKeeperByteKey` here.", "reference": "Let's keep using NewKeeper so that it got covered by tests." }, { - "prediction": "I think we should remove the `BlobDeleteManager` and `BlobDeleteProcessor` as they are no longer needed.", + "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to move it to `solr-core/src/main/java/org/apache/solr/store/`.", "reference": "I only see new imports. Is there any functional change in this file?" }, { - "prediction": "I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place", + "prediction": "I think we can remove the `if raCtx.BlockHeight == 1` check here.", "reference": "ineffectual assignment to `err` (from `ineffassign`)" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `http.Executor` instead of `http.HttpClient` in this case.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `http.Executor` instead of `http.HttpClient` here. `http.HttpClient` is deprecated and will be removed in the future. `http.Executor` is a better choice.", "reference": "Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`)" }, { - "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to have a separate function for `LogWarningMsg` and `LogErrorMsg` so that we don't have to call `rdBase.LogWarningMsg` and `rdBase.LogErrorMsg` every time we want to log a warning or error message.", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `warnings.warn` instead of `rdBase.LogWarningMsg` and `rdBase.LogErrorMsg`.", "reference": "Make sure the old logging functions still work, but add deprecation warnings (unfortunately Python suppresses deprecation warnings by default, so I'm not sure if anyone'll notice)." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a test for this in the `TelemetryHelper` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this.", "reference": "Not directly related to the topic of this ticket: I think this API design is a bit confusing. To disable delemetry, I would write `managementService.enableTelemetry(false)` which is not intuitive to read. Maybe `toggleTelemetry` instead of `enableTelemetry` is more clear." }, { - "prediction": "I'm not sure if this is the best place to do this, but I think it's a good idea to capture the location of the `region` in the `CaptureAnnotatedCodeLocationCollections` method.", + "prediction": "I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place", "reference": "Again I suggest returning `AnnotatedCodeLocation[][]`." }, { - "prediction": "I'm not sure what you mean by `IsNotFound(err)`. I think you meant to say `IsNotFound(err.Error())`?", + "prediction": "I'm not sure if this is the right place to do this, but I think we should be able to do this in the `describeVpcInternetGateways` function.", "reference": "We should probably require an increased verbosity to output for anything below the cluster itself to avoid spamming the logs. It would also be good to give additional context as to what we are attempting to reconcile since the controller has multiple workers." }, { @@ -15491,23 +15491,23 @@ "reference": "Not needed anymore" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check here to make sure that we're not trying to enable CallTarget state by ref when it's already enabled. If it's already enabled, then we should not try to enable it again. If it's not enabled, then we should not try to enable it at all.", + "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to enable this by default. If you don't want to do this, you can disable it by setting `EnableCallTargetStateByRef` to `false` in the configuration file.", "reference": "Am I right in thinking this completely avoids the situation where `enable_calltarget_state_by_ref` is `true`, but the managed integrations don't expect a by ref argument? For example, if there's an exception here, that seems like a fatal problem, as we would have a mismatch for jit rewriting? We should disable instrumentation entirely in that case shouldn't we? i.e. if this (or the existing `EnableByRefInstrumentation`) calls fail, should we bail out of this method entirely as we can't safely instrument?" }, { - "prediction": "I don't think this is a good idea. It's not clear to me what it means to be an \"instance\" of a resource type. I think it should be something like `{{ .Name }}` or `{{ .Type }}` or `{{ .Kind }}` or `{{ .Name }}` or `{{ .Type }}` or `{{ .Kind }}` or `{{ .Name }}` or `{{ .Type }}` or `{{ .Kind }}` or `{{ .Name }}` or `{{ .Type }}` or `{{ .Kind }}` or `{{ .Name }}` or `{{ .Type }}` or `{{ .Kind }}` or `{{ .Name }}` or `{{ .Type }}` or `{{ .Kind }}` or `{{ .Name }}` or `{{ .Type }}` or `{{ .Kind }}` or `{{ .Name }}` or `{{ .Type }}` or `{{ .Kind }}` or `{{ .Name }}` or `{{ .Type }}` or `{{ .Kind }}` or `{{ .Name }}` or `{{ .Type }}` or `{{ .Kind }}` or `{{ .Name }}` or `{{", + "prediction": "I don't think this is a good idea. It's not clear to me what the `{{- range .KnownTypes }}` part is doing.", "reference": "nit: spaces seem off" }, { - "prediction": "I'm not sure what you mean by \"bottleneck\" here. It's not a bottleneck in terms of speed, but it's a bottleneck in terms of memory usage.", + "prediction": "I'm not sure what the bottleneck is here, but I'm not sure how to fix it. I'm not sure what the bottleneck is here, but I'm not sure how to fix it. I'm not sure what the bottleneck is here, but I'm not sure how to fix it. I'm not sure what the bottleneck is here, but I'm not sure how to fix it. I'm not sure what the bottleneck is here, but I'm not sure how to fix it. I'm not sure what the bottleneck is here, but I'm not sure how to fix it. I'm not sure what the bottleneck is here, but I'm not sure how to fix it. I'm not sure what the bottleneck is here, but I'm not sure how to fix it. I'm not sure what the bottleneck is here, but I'm not sure how to fix it. I'm not sure what the bottleneck is here, but I'm not sure how to fix it. I'm not sure what the bottleneck is here, but I'm not sure how to fix it. I'm not sure what the bottleneck is here, but I'm not sure how to fix it. I'm not sure what the bottleneck is here, but I'm not sure how", "reference": "shouldn't the em parameter be called ec?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `append` method to add the keys to the `trustedKeys` slice. This way, we don't have to worry about the order of the keys in the slice.", "reference": "Please change this to use o.DidSign(o) as implements this logic without performing any of these checks that duplicate something that JWT can do correctly. If the JWT deserialized properly, and DidSign returns true, the JWT was signed by one of the listed operator keys." }, { - "prediction": "Shouldn't this be `FeedItem` instead of `FeedItem`?", + "prediction": "I think this should be `Comparable` instead of `Comparator`.", "reference": "Talking about style, IMO extracting either `getComponent()` or `getPubDate()` to variables would make this line easier to read." }, { @@ -15515,19 +15515,19 @@ "reference": "package header missing" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to move it to the `componentDidUpdate` handler.", + "prediction": "I think this should be `return component._childDidSuspend(error, newVNode._component, oldVNode && oldVNode._hydrateDom && oldVNode._hydrating);`", "reference": "Just a thought (doesn't change the output or anything) - do you think we'll ever want to access the other properties of `oldVNode` from within `_childDidSuspend`? If so we could pass `oldVNode` here and then check these properties in the _childDidSuspend implementation. I don't have strong feelings either way, just occurred to me." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add this to the PHPCR documentation.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to make this a PHPCR trait.", "reference": "We should be configuring the base paths somewhere.." }, { - "prediction": "I'm not sure what you mean by `strides=[8, 16, 32, 64, 100, 300]` and `max_sizes=None`?", + "prediction": "I don't think this is a good idea. The `min_sizes` and `max_sizes` should be set at the same time.", "reference": "May also need to test the normal functionality with min/max_sizes" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think we need to change anything here.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea to use `https://ethereum1.mysterium.network/` and `https://main-light.eth.linkpool.io/` for the same reason that we don't want to use `https://ethereum1.mysterium.network/` and `https://main-light.eth.linkpool.io/` for the same reason that we don't want to use `https://ethereum1.mysterium.network/` and `https://main-light.eth.linkpool.io/` for the same reason that we don't want to use `https://ethereum1.mysterium.network/` and `https://main-light.eth.linkpool.io/` for the same reason that we don't want to use `https://ethereum1.mysterium.network/` and `https://main-light.eth.linkpool.io/` for the same reason that we don't want to use `https://ethereum1.mysterium.network/` and `https://main-light.eth.linkpool.io/` for the same reason that we don't want to use `https://ethereum1.mysterium.network/` and `https://main-light.eth.linkpool.io/` for the same reason that", "reference": "We can remove this one. It's just a random one I got for free for testing." }, { @@ -15535,75 +15535,75 @@ "reference": "File is not `goimports`-ed (from `goimports`)" }, { - "prediction": "I'm not sure what you're trying to do here, but I think it's better to use `data-acquirer-id` instead of `data-acquirer-id=\"Local\"`.", + "prediction": "I don't think we need to use `data-acquirer-id=\"Local\"` here. We can just use `data-acquirer=\"Local\"`.", "reference": "(maybe this should be MyDevice or just removed entirely?)" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have the task handler send an empty task when the task is not found in the payload.", + "prediction": "I'm not sure why we need to send an empty task here.", "reference": "Can you do a nil check here, as the task isn't always nil here?" }, { - "prediction": "I'm not sure what you mean by \"isDataZeroForReporting\" and \"getTopPagesReportDataDefaults\". Could you please provide more context or clarify your question?", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the `AnalyticsDashboardWidgetPopularPagesTable` component.", "reference": "`lodash` shouldn't be grouped under WordPress dependencies" }, { - "prediction": "2444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444", + "prediction": "4244444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444444", "reference": "Does order matter? Should we sort by enode key to make duplication checking easier?" }, { - "prediction": "I'm not sure what you mean by `auth.GetDatabase().(nosql.DB)`. I think you meant to say `auth.GetDatabase().(*nosql.DB)`.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `auth` instead of `auth.GetDatabase().(nosql.DB)`.", "reference": "Can you explain this too? This seems to go beyond linting." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to test that the `spellcheck` attribute is set to `false` when the `input` element is replaced by a `Comp` component.", + "prediction": "I'm not sure what you mean by \"should remove orphaned elements replaced by Components\". I think you meant to say \"should not remove orphaned elements replaced by Components\" or \"should not replace orphaned elements with Components\".", "reference": "I just moved this into the render.js UT file since this test doesn't actually use an components" }, { - "prediction": "I'm not sure what you mean by \"prompt about whether to do an import after config.\" Could you please clarify?", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have the `CreateSettingsFile` method in the `ddevapp` package, so that we don't have to call it every time we want to create a settings file.", "reference": "We do have to capture and check the err here right? I don't think we need to capture the location of the file though for this context." }, { - "prediction": "I think we should use `logging.getLogger('listenbrainz.listenstore.InfluxListenStore')` instead of `logging.getLogger('listenbrainz.listenstore.InfluxListenStore')`", + "prediction": "I think we should use `logging.getLogger('listenbrainz.listenstore')` instead of `logging.getLogger('listenbrainz.listenstore').addHandler(RotatingFileHandler('listenbrainz.listenstore.log', maxBytes=1000000, backupCount=10))`", "reference": "an unused import" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to add a new tag to a cert file. I'm not sure what you're trying to do here, but it looks like you're trying to add a new tag to a cert file. I'm not sure what you're trying to do here, but it looks like you're trying to add a new tag to a cert file. I'm not sure what you're trying to do here, but it looks like you're trying to add a new tag to a cert file. I'm not sure what you're trying to do here, but it looks like you're trying to add a new tag to a cert file. I'm not sure what you're trying to do here, but it looks like you're trying to add a new tag to a cert file. I'm not sure what you're trying to do here, but it looks like you're trying to add a new tag to a cert file. I'm not sure what you're trying to do here, but it looks like you're trying to add a new tag to a cert file. I'm not sure what you're trying to do here, but it looks like you're trying to add a new tag", + "prediction": "I'm not sure what you're trying to say here. I think you're trying to say that the `tlsCertTags` field is a map of strings, and that the value of `certFilename` is a string, and that the value of `tlsCertTags[certFilename]` is a string, and that the value of `tlsCertTags[certFilename]` is a string, and that the value of `tlsCertTags[certFilename]` is a string, and that the value of `tlsCertTags[certFilename]` is a string, and that the value of `tlsCertTags[certFilename]` is a string, and that the value of `tlsCertTags[certFilename]` is a string, and that the value of `tlsCertTags[certFilename]` is a string, and that the value of `tlsCertTags[certFilename]` is a string, and that the value of `tlsCertTags[certFilename]` is a string, and that the value of `tlsCertTags[certFilename]` is a string, and that the value of `tlsCertTags[certFilename]` is a string, and that the value of `tlsCertTags[certFilename", "reference": "If this value doesn't exist (do an `, ok := ...` check), we should initialize and store it" }, { - "prediction": "I think this should be `Number.MIN_SAFE_INTEGER` instead of `Number.MIN_SAFE_INTEGER || -(2 ** 53) - 1`", + "prediction": "I think this should be `Number.MIN_SAFE_INTEGER || -(2 ** 53) - 1` instead of `or(Number.MIN_SAFE_INTEGER, -(2 ** 53) - 1)`.", "reference": "Would use parenthesis to explicitly state the associations of operands ```js const MAX_SAFE_INTEGER = Number.MAX_SAFE_INTEGER || (-(2 ** 53) - 1)" }, { - "prediction": "I think this should be `super(Serial, self).__init__(self._ser._port_handle, onReceive)` instead of `super(Serial, self).__init__(self._ser.hComPort, onReceive)`.", + "prediction": "I think it's better to use `self._ser._port_handle` instead of `self._ser.hComPort`.", "reference": "This handle is now private to pyserial, but if there is no public function to retrieve it I guess this is the best we can do." }, { - "prediction": "I'm not sure if this is a good idea, but I think it would be better to use `wlr_xdg_surface_schedule_configure` instead of `wlr_xdg_surface_set_maximized` and `wlr_xdg_surface_set_fullscreen`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `wlr_xdg_surface_schedule_configure` as well.", "reference": "This function is what **the compositor** calls when it wants to fullscreen a client, not what the client calls." }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. Is it that you want to create 6 traceflows? If so, why not just create 6 traceflows?", + "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. If you want to create a traceflow between two nodes, you should create a traceflow between the two nodes. If you want to create a traceflow between a node and a service, you should create a traceflow between the node and the service. If you want to create a traceflow between a node and a pod, you should create a traceflow between the node and the pod.", "reference": "s/not existed Pod/non-existing Pod" }, { - "prediction": "I'm not sure what you mean by `svcDescriber` and `ecsSvcDescriber` in this context. Could you please clarify?", + "prediction": "I'm not sure if this is the best place to put this, but I think it would be good to have a separate `ecsSvcDescriber` and `cwSvcDescriber` for this.", "reference": "Why did we not leave this as just `svcDescriber`?" }, { - "prediction": "`select_data` should be `select_group_members`", + "prediction": "`select_data` should be `select_data_for_groups`", "reference": "nit: I think we've been (in)consistent in leaving a blank line here." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `__repr__` in this case.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to make the `inventory_data` column nullable.", "reference": "Maybe we can change it to a more generic name like source_id." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use a channel for this. It's not a good idea to use a channel for this. It's not a good idea to use a channel for this. It's not a good idea to use a channel for this. It's not a good idea to use a channel for this. It's not a good idea to use a channel for this. It's not a good idea to use a channel for this. It's not a good idea to use a channel for this. It's not a good idea to use a channel for this. It's not a good idea to use a channel for this. It's not a good idea to use a channel for this. It's not a good idea to use a channel for this. It's not a good idea to use a channel for this. It's not a good idea to use a channel for this. It's not a good idea to use a channel for this. It's not a good idea to use a channel for this. It's not a good idea to use a channel for this. It's not a good idea to use a channel for this. It's not a good idea", + "prediction": "I'm not sure if this is the right way to do this, but I think we should be able to do this in a single test.", "reference": "What's the theory on why this could fix the hang? It seems like the call to `GetRootNodeForTest` will always need to call into the crypto object before returning an error, and so it should block on that `c` receive, after which the test immediately drains `errCh`. So I don't quite see how buffering would help..." }, { - "prediction": "I think this should be `opnd_create_reg((TEST(PREFIX_VEX_L, di->prefixes) && expand_subreg_size(opsize) != OPSZ_16) ? ((TEST(PREFIX_VEX_L, di->prefixes) && expand_subreg_size(opsize) != OPSZ_16) ? ((TEST(PREFIX_VEX_L, di->prefixes) && expand_subreg_size(opsize) != OPSZ_16) ? ((TEST(PREFIX_VEX_L, di->prefixes) && expand_subreg_size(opsize) != OPSZ_16) ? ((TEST(PREFIX_VEX_L, di->prefixes) && expand_subreg_size(opsize) != OPSZ_16) ? ((TEST(PREFIX_VEX_L, di->prefixes) && expand_subreg_size(opsize) != OPSZ_16) ? ((TEST(PREFIX_VEX_L, di->prefixes) && expand_subreg_size(opsize) != OPSZ_16) ? ((TEST(PREFIX_VEX_L, di->prefixes) && expand_subreg_size(opsize) != OPSZ_16) ? ((TEST(PREFIX_VEX_L, di->prefixes) &&", + "prediction": "I think this should be `TEST(PREFIX_EVEX_VV, di->prefixes)` instead of `TEST(PREFIX_EVEX_VV, di->prefixes) && expand_subreg_size(opsize) != OPSZ_16`.", "reference": "Maybe add an assert in arch_init or somewhere?" }, { @@ -15611,15 +15611,15 @@ "reference": "I wonder what does this `// nolint` ignore? And what are the standards that you choose which error to fix and which to ignore?" }, { - "prediction": "I'm not sure what you mean by \"no change\" in this case. It's not like we're trying to reload the core, we're just trying to update the alias manager.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `ZkController` class, since it's the only place where the `ZkStateReader` is used. I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `ZkController` class, since it's the only place where the `ZkStateReader` is used. I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `ZkController` class, since it's the only place where the `ZkStateReader` is used. I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `ZkController` class, since it's the only place where the `ZkStateReader` is used. I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `ZkController` class, since it's the only place where the `ZkStateReader", "reference": "what about the line below, forceUpdateCollection?" }, { - "prediction": "I think this should be `cmd_line_array = [env_string, prepend_commands, cmd, options_string, args_string, append_command]` instead of `cmd_line_array = [env_string, prepend_commands, cmd, options_string, args_string, append_command]`", + "prediction": "I think it's better to use `cmd_line_array` instead of `cmd_line_array.compact.reject( &:empty? ).join( ' ' )`", "reference": "Doesn't this go in the opposite direction of #1051 / #1062 by putting platform-specific logic back into this module?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `global` instead of `window` for this kind of stuff.", + "prediction": "I think it's better to use `response.authenticated` and `response.grantedScopes` instead of `response.isAuthenticated` and `response.requiredScopes`.", "reference": "I think this is the only line in JS legacy code that should be updated based on the renaming. `global.googlesitekit.setup.isAuthenticated = response.authenticated;` would be sufficient to keep the old name for the legacy JS data (which will be phased out in the long term) while supporting the new name in the API route. All updates to the JS components above wouldn't be necessary." }, { @@ -15627,11 +15627,11 @@ "reference": "Technically, this would allow `pingWaitTime` to be `false`. I don't know if it matters here." }, { - "prediction": "I'm not sure what you mean by \"put_record_header\" in this case. Is it the same as \"describe_stream_summary_header\" in this case? If so, I'm not sure what you're trying to do here.", + "prediction": "I'm not sure what you mean by \"put_record_header\" in this case. I think it should be \"describe_stream_summary_header\" or something like that.", "reference": "I only want the proxy request for this to run for kinesalite. So this just returns true if the KINESIS_PROVIDER is kinesis-mock" }, { - "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a `__init__.py` file in the same directory as this file.", + "prediction": "I think this should be `from copy import deepcopy` instead of `from copy import copy`", "reference": "Please add your name to the list of copyright holders." }, { @@ -15639,31 +15639,31 @@ "reference": "Maybe maxRetryTimes should be bigger than 2. Return Max(maxRestryTime, 2)?" }, { - "prediction": "I'm not sure what you mean by `repoName += \".wiki\"```, but I think it should be `repoName = repoName + \".wiki\"`", + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", "reference": "Call `userName` is good enough, `signedUserName` is narrowing the actual usage of this method." }, { - "prediction": "I'm not sure what you're trying to do with this, but I'm not sure if it's a good idea to do this. It's a bit of a hack, and I'm not sure if it's a good idea to do this. I'm not sure what you're trying to do with this, but I'm not sure if it's a good idea to do this. I'm not sure what you're trying to do with this, but I'm not sure if it's a good idea to do this. I'm not sure what you're trying to do with this, but I'm not sure if it's a good idea to do this. I'm not sure what you're trying to do with this, but I'm not sure if it's a good idea to do this. I'm not sure what you're trying to do with this, but I'm not sure if it's a good idea to do this. I'm not sure what you're trying to do with this, but I'm not sure if it's a good idea to do this. I'm not sure what you're trying to do with this, but I'm not sure if it's a good idea to do this. I'm not sure what you're trying to", + "prediction": "I'm not sure what you're trying to do with this, but I think it's a bad idea to use `AppDomain.CurrentDomain.ProcessExit` and `AppDomain.CurrentDomain.UnhandledException` in this way.", "reference": "How would you feel about a static method to express intent?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `AddString` method instead of the `AddString` method in this case. The `AddString` method is used to add a string value to the log object, while the `AddUint16` method is used to add a uint16 value to the log object. The `AddUint16` method is used to add a uint16 value to the log object, while the `AddString` method is used to add a string value to the log object. The `AddString` method is used to add a string value to the log object, while the `AddUint16` method is used to add a uint16 value to the log object. The `AddString` method is used to add a string value to the log object, while the `AddUint16` method is used to add a uint16 value to the log object. The `AddString` method is used to add a string value to the log object, while the `AddUint16` method is used to add a uint16 value to the log object. The `AddString` method is used to", + "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to remove the `if len(t.PeerCertificates) > 0` check.", "reference": "Do we know for sure that no other code changed its value? (Maybe some weird testing use case or something) Why not just use the actual value instead of risk lying?" }, { - "prediction": "I don't think this is necessary.", + "prediction": "I don't think we need to include the license header in the install scripts.", "reference": "the partInstall.go isn't an auto-generated file, and the part.sql doesn't exists either." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `GetAll` method to the `TTLCache` struct.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `cache` package, since it's used by both the `TTLCache` and the `cache` package.", "reference": "`k` is unused in PutHash" }, { - "prediction": "I'm not sure what you're trying to do with this method, but it looks like you're trying to copy the contents of an input stream to an output stream. I'm not sure what you're trying to do with this method, but it looks like you're trying to copy the contents of an input stream to an output stream. I'm not sure what you're trying to do with this method, but it looks like you're trying to copy the contents of an input stream to an output stream. I'm not sure what you're trying to do with this method, but it looks like you're trying to copy the contents of an input stream to an output stream. I'm not sure what you're trying to do with this method, but it looks like you're trying to copy the contents of an input stream to an output stream. I'm not sure what you're trying to do with this method, but it looks like you're trying to copy the contents of an input stream to an output stream. I'm not sure what you're trying to do with this method, but it looks like you're trying to copy the contents of an input stream to an output stream. I'm not sure what you're trying to do with this method, but it looks like", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a separate class.", "reference": "Use IOUtils instead" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `newIdentity` field in the `idmFake` struct. This way, we don't need to create a new `idmFake` struct every time we want to create a fake identity manager.", + "prediction": "I think we can remove the `existingIdentities` field from the `NewIdentityManagerFake` function. It's not needed anymore.", "reference": "It's not related to the line of code, but I don't know how to write it in a more proper place. Looks like `e2e/myst-provider/db/myst.db` should be in `.gitignore` file and should not be commited." }, { @@ -15671,7 +15671,7 @@ "reference": "nice touch since Google likes to change things every now and then." }, { - "prediction": "I think it's a good idea to add a check to make sure the circuit breaker manager is not null before using it.", + "prediction": "I think it's a good idea to add a check here to make sure the circuit breaker manager is not null, and if it is null, throw an exception.", "reference": "Make `CircuitBreakerManager` implement `PluginInfoInitialized`" }, { @@ -15679,91 +15679,91 @@ "reference": "This is extra awkward, QVariant.convert() takes a QMetaType which takes the value of a QMetaType.Type." }, { - "prediction": "I think we should remove the `ctx` field from the Writer struct. It's not needed anymore.", + "prediction": "I think we can remove the `ctx` field from the Writer struct. It's not used anywhere in the code.", "reference": "Nit: finished -> finish, \"done passing it\" -> \"passed it\"." }, { - "prediction": "I think this should be `if ENV['S3_BUCKET_NAME'] && ENV['S3_ACCESS_KEY_ID'] && ENV['S3_SECRET_ACCESS_KEY']` instead of `if ENV['S3_BUCKET_NAME'] && ENV['S3_ACCESS_KEY_ID'] && ENV['S3_SECRET_ACCESS_KEY']`", + "prediction": "I think this should be `if ENV['S3_BUCKET_NAME'] && ENV['S3_ACCESS_KEY_ID'] && ENV['S3_SECRET_ACCESS_KEY']` instead of `if ENV['S3_BUCKET_NAME'] && ENV['S3_ACCESS_KEY_ID'] && ENV['S3_SECRET_ACCESS_KEY'] && ENV['S3_PERMISSIONS']`", "reference": "Maybe mention that it will be saved to the filesystem otherwise?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.", "reference": "Probably cleaner and more general to do this: string,Format(\"Column {0}\", i+1) That way if the local language has a convention like \"3 column, this is\" it still works." }, { - "prediction": "I think we should add a check for `accountNonceMap` and `accountNonceMap` to `action.ClassifyActions` as well.", + "prediction": "Shouldn't we also check the balance of the account?", "reference": "This can be uniformed too" }, { - "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea to have a `WithAddPeersErr` function. It's not clear to me what you're trying to do with it.", + "prediction": "I'm not sure what you mean by `WithAddPeersErr(err error) Option`", "reference": "It looks to me that this does not have to be exported." }, { - "prediction": "I think this should be `configProto.getLanguageSettings().getLanguage()` instead of `configProto.getLanguageSettings().build()`.", + "prediction": "I don't think this is needed anymore.", "reference": "It looks like this is only used in order to extract the snippet file names from GapicProviderFactory. I wonder if it would be better expose the snippet file names directly, without exposing a test-only function in non-test code." }, { - "prediction": "I don't think this is needed.", + "prediction": "I don't think this is needed anymore.", "reference": "Another question: this is being removed, but I don't see a corresponding removal if it being called? Was it never used (or am I just missing it)? (is it related to what was in the onclick that got removed, i.e. was that supposed to call this and not something in the backing bean?)" }, { - "prediction": "I think we can remove the `if !apiutil.CertificateRequestHasApproved(cr)` check.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check to see if the certificate request has an Approved condition. If it doesn't have one, we should return an error with the message \"CertificateRequest does not have an Approved condition\".", "reference": "Suggestion: `.. does not have an Approved condition set to true`" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to make sure that the `delete_files_before_test` flag is set to `False` before the test is run.", + "prediction": "I don't think this is necessary.", "reference": "I would say that client class should have default of False and Cloud prov should enable deleting." }, { - "prediction": "I'm not sure what you mean by this, but I think we should remove the `using System;` at the top of the file.", + "prediction": "I don't think this is necessary.", "reference": "Did this remove the BOM or something?" }, { - "prediction": "I'm not sure if this is the right place to add this rule, but I think it's a good idea.", + "prediction": "I'm not sure I understand what you're trying to do here.", "reference": "This makes the BlockHeaderValidator mutable, and IMHO should not be done. Note we have a builder that has the exact same method, so instead of mutating a produced BlockHeaderValidator we should hook into wherever the builder is being created." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a global variable for this.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a `playWaveFileAsync` function that does the same thing as `playWaveFile` but with async support.", "reference": "May be add information about parameters to the doc string while at it?" }, { - "prediction": "I don't think this is a good idea. It's not clear to me what this method is supposed to do. It's not clear to me what this method is supposed to do. It's not clear to me what this method is supposed to do. It's not clear to me what this method is supposed to do. It's not clear to me what this method is supposed to do. It's not clear to me what this method is supposed to do. It's not clear to me what this method is supposed to do. It's not clear to me what this method is supposed to do. It's not clear to me what this method is supposed to do. It's not clear to me what this method is supposed to do. It's not clear to me what this method is supposed to do. It's not clear to me what this method is supposed to do. It's not clear to me what this method is supposed to do. It's not clear to me what this method is supposed to do. It's not clear to me what this method is supposed to do. It's not clear to me what this method is supposed to do. It's not clear to me what this method is supposed to do. It's not clear to me what this", + "prediction": "I think we should remove `LEGACY` from `priv_getTransactionCountLegacy` and `priv_getTransactionCount`", "reference": "Naming of this sounds a bit awkward. Perhaps priv_legacy_getTransactionCount or priv_legacyGetTransactionCount?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `vkGetDeviceMemoryUsage` function.", + "prediction": "I think this should be `obj.type == kVulkanObjectTypeImage` instead of `obj.type == kVulkanObjectTypeMemory`.", "reference": "This one should probably be added to the list in #24 . It's possibly indicative of an issue, but there isn't a VUID for it." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `project` and `network` variables in the `build_network_url` function. This way, the `project` and `network` variables can be passed to the `build_network_url` function, and the `project` and `network` variables can be used in the `build_network_url` function. This way, the `project` and `network` variables can be passed to the `build_network_url` function, and the `project` and `network` variables can be used in the `build_network_url` function. This way, the `project` and `network` variables can be passed to the `build_network_url` function, and the `project` and `network` variables can be used in the `build_network_url` function. This way, the `project` and `network` variables can be passed to the `build_network_url` function, and the `project` and `network` variables can be used in the `build_network_url` function. This way, the `project` and `network` variables can be passed to the `build_network_url` function, and the `project` and", + "prediction": "I'm not sure if this is the best place to put this, but I think it would make sense to move it to the `compute` module.", "reference": "Why this indentation change? Seems the original indentation would be fine, and leaves more room." }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is it that you want to add an item to the data? If that's the case, then I think this is the right place to do it. If not, then I don't think this is the right place to do it.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to make sure that the key matches the number of dimensions. If it doesn't, we should raise an error.", "reference": "Would be nice to know what the `update` argument does in the docstring." }, { - "prediction": "I think this should be `start_log` instead of `start_log`", + "prediction": "I think this should be `start_log` instead of `start_log` and `end_log` instead of `end_log`.", "reference": "I think we can just use `io.BytesIO` here." }, { - "prediction": "I'm not sure what you mean by \"User-Agent\" and \"sig\" in this context. Could you please clarify?", + "prediction": "I don't think we need to do this, we can just use the same `http.Client` for both Azure and GCP.", "reference": "This ensures that the User-Agent header matches during replay." }, { - "prediction": "I'm not sure what this is for, but I think it should be `XDDui1__(USTAT_MIN_ROWCOUNT_FOR_LOW_SAMPLE, \"1000000\")` instead of `XDDui1__(USTAT_MIN_ROWCOUNT_FOR_LOW_SAMPLE, \"1000000\")`", + "prediction": "I'm not sure if this is the right place to put this. I think it should be in `XDDpct__(USTAT_OBSOLETE_PERCENT_ROWCOUNT, 15)`, but I'm not sure if that's the right place to put it.", "reference": "What units are used for this default?" }, { - "prediction": "I think this should be `id` instead of `id` and `distance` instead of `distance`.", + "prediction": "I don't think we need to add `Newtonsoft.Json.JsonProperty(\"distance\")` to the `AbilityT` class.", "reference": "I am wondering if it makes sense to make this a flag to `flatc` rather than a preprocessor flag, since this is generated code, it would make more sense to simply omit this code completely if the flag is not specified" }, { - "prediction": "I don't think this is necessary.", + "prediction": "I'm not sure what you mean by \"multiple-tabs\" and \"multiple-downloads\". I think you meant \"multiple tabs\" and \"multiple downloads\".", "reference": "Doesn't this change the behavior (edit: oh, I see, never mind)." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add this to the `travis.yml` as well.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add this to the `travis.yml` file as well.", "reference": "I think you need a `do` at the end of this line." }, { @@ -15771,39 +15771,39 @@ "reference": "Not passing in a `:params` key here." }, { - "prediction": "I think it's better to use `if err != nil { ... }` instead of `if err != nil { logger.WithError(err).Log(controllerutils.LogLevel(err), \"could not set claim for ClusterDeployment\") return reconcile.Result{}, err }`", + "prediction": "I think it's better to use `controllerutils.LogLevel` to log the level of the error instead of `controllerutils.LogLevel(err, \"could not set claim for ClusterDeployment\")`", "reference": "Feels like this should be an option and not the default. Leaving them running would give you immediate response to claims, which might be what some people would want. Hibernation is AWS only right now and probably other clouds will just disregard the setting but arguably validation should be rejecting attempts to create / update powerstate on gcp/azure/etc. I'd pitch we put this onto the pool spec and make you opt in." }, { - "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea to add this to the `IntegrationTestHelpers.cs` file as well.", + "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to remove the `if NETCOREAPP3_0 || NETCOREAPP3_1 || NET5_0 || NET6_0` condition.", "reference": "I think I saw somewhere that it has been fixed and that you can use #NETCOREAPP3_0_OR_GREATER but I may be wrong." }, { - "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to activate the roll-DPoS consensus, but I'm not sure what you're trying to do with the `Builder` struct. Could you please explain what you're trying to do with the `Builder` struct?", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate builder for RollDPoS so that we don't have to use the same builder for both `RollDPoS` and `RollDPoSBuilder`.", "reference": "what's the second part for?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate test for this.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the best way to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the best way to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the best way to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the best way to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the best way to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the best way to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the best way to do this, but I think it's a good idea to have a separate test for this. It's", "reference": "It's not clear to me what the \"super\" test above is for. As far as I can see, the test runs a spellcheck for \"super\" but then uses \"fob\" as the index into suggestions, which will never find an entry." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to use the `logfilter` package to filter log messages, but I'm not sure if that's the best way to do it. It's possible that you're trying to use the `log` package to filter log messages, but I'm not sure if that's the best way to do it.", + "prediction": "I'm not sure if this is a good place to put it, but I think it should be in the `ioctl` package.", "reference": "revert this file change" }, { - "prediction": "I'm not sure what you mean by \"E1102 should be disabled from line 1 to 6 while E1101 from line 5 to 6\"", + "prediction": "I don't think we need to disable pylint here.", "reference": "I think this is the most elegant way to allow us to still fail on `I`." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `addcslashes` function to escape the wildcards before using them in the query.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `addcslashes` function to escape the wildcards.", "reference": "Wouldn't it be better to use a sql `IN ( :exact_value )` ?" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.", "reference": "So far this is not working as expected... working to further investigate WinRM protocol and the gems behavior." }, { - "prediction": "I think this should be `if isinstance(request, HTTPRequest)` instead of `isinstance(request, HTTPRequest)`.", + "prediction": "I think this should be `for request in self.scenario.get_requests()` instead of `for request in self.get_requests()`.", "reference": "So now there're two ways to get requests: `ScenarioExecutor.get_requests()` and `Scenario.get_requests()`. To avoid confusion we should probably make `Scenario.get_requests()` method private, or hide it in some other way." }, { @@ -15819,11 +15819,11 @@ "reference": "@codepoet2017390 You have already initialized this ArrayList in the onPreExecute method then why do it here too?" }, { - "prediction": "I think this should be `with_feature 'RESTRICT_ACCESS'` instead of `with_feature 'RESTRICT_ACCESS' do`", + "prediction": "I think we can remove the `with_feature 'RESTRICT_ACCESS'` block.", "reference": "This covers the `RESTRICT_ACCESS=true` x non-gsa pair, but we probably want to test the three other permutations: (`RA=true`, gsa), (`RA=false`, non-gsa), (`RA=false`, gsa)" }, { - "prediction": "I'm not sure what you mean by \"focusTimeout\" in this context. It's not used anywhere in this code.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea.", "reference": "Please don't do this - if you want to disable code permanently delete the code, if you need to disable it to test don't commit. Such sections are very poorly highlighted during review and can cause unspotted issues slipping through the process..." }, { @@ -15831,23 +15831,23 @@ "reference": "I'm starting too feel we have too much abstraction and too many interfaces here. But this method is definitely the most confusing IMO. For one, it's called \"Get*\" but it does not return anything... I don't have a good understanding of what's going on anymore, so it's hard for me to suggest an alternative, but it's pretty clear to me that this interface needs to be rethought. An interface where all the parameters are themselves arbitrary objects (`interface{}`), whose actual type depends on the specific interface implementation, is not a helpful abstraction" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. The `SessionId` class is not part of the `org.openqa.selenium.devtools.target.model` package. It's part of the `org.openqa.selenium.remote.http` package, which is not part of the `org.openqa.selenium.devtools.target.model` package.", + "prediction": "`org.openqa.selenium.devtools.target.model.SessionId` should be `org.openqa.selenium.remote.http.SessionId`", "reference": "It fills me with endless sadness that we can't use Selenium's own `SessionId` here." }, { - "prediction": "I think we can remove the call to `zkClient.getSolrZooKeeper().sync(ALIASES, null, null);` since we already have the latest version.", + "prediction": "I think this should be `if (stat.getVersion() > aliases.getZNodeVersion())` instead of `if (stat.getVersion() <= aliases.getZNodeVersion())`.", "reference": "Interesting. So you've found that it's faster to request only the \"Stat\" without the data so long as this is the typical path?" }, { - "prediction": "I think this is a duplicate of https://github.com/influxdata/flux/pull/855, but I don't think it's a duplicate of https://github.com/influxdata/flux/pull/535.", + "prediction": "I think this is a duplicate of https://github.com/influxdata/flux/pull/1002", "reference": "Is this a future fix? I thought the local identifier scope and the package issue were the same one." }, { - "prediction": "I think this should be `self._isApplicationObject(obj)` instead of `if obj.role==controlTypes.ROLE_APPLICATION:`", + "prediction": "I think this should be `controlTypes.ROLE_APPLICATION` instead of `controlTypes.ROLE_DIALOG`.", "reference": "Not super important, but this line could be split up." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to call `h2o_context_destroy` on the `h2o_context_t` before calling `h2o_context_dispose` on the `h2o_context_t`. This is because the `h2o_context_destroy` function will call `h2o_context_dispose` on the `h2o_context_t`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to call `h2o_multithread_unregister_receiver` and `h2o_multithread_destroy_queue` before calling `h2o_context_dispose`.", "reference": "Maybe we should better call the dispose function without checking the value of `item.data` (since the dispose function is setup before `data` is set up)." }, { @@ -15855,19 +15855,19 @@ "reference": "Why set to GPU, is it CPU?" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to set the `pageTitle` to the title of the current day. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set the `pageTitle` to the title of the current day. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set the `pageTitle` to the title of the current day. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set the `pageTitle` to the title of the current day. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set the `pageTitle` to the title of the current day. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set the `pageTitle` to the title of the current day. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set the `pageTitle` to the title of the current day. I'm not sure what you're trying to achieve with this, but it looks like you", + "prediction": "I don't think we need to use `computed('i18n', () => { ... })` here. We can just use `computed('i18n', () => { return t('appointments.todayTitle') })`.", "reference": "This should be `computed('i18n.locale'....`" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to have a `Done` channel in the middle of the `newSession` function. I think it's better to have a separate channel for the `done` channel.", + "prediction": "I don't think this is necessary. The `done` and `Done` channels are not used anywhere in the code, so they can be removed.", "reference": "can we not expose the channel directly? or at least expose it as a read only channel?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to add `pkg-config` to the `PKG_CHECK_VAR` list. It's not necessary, and it might cause problems if you try to use `pkg-config` in the future. Also, it's not clear what you're trying to do with `pkg-config` in the first place.", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `AC_MSG_ERROR` here.", "reference": "Can we add a `--with-bashcompdir` here to override this? I'd like to be able to do unprivileged builds." }, { - "prediction": "I think this should be `command.CreateSnapshot` and `command.DestroySnapshot` instead of `command.CreateSnapshot` and `command.DestroySnapshot`.", + "prediction": "I think this should be `command.CreateSnapshot` and `command.DestroySnapshot` instead of `command.CreateSnapshotDelete` and `command.DestroySnapshotDelete`.", "reference": "We will be removing this maya/volume package completely. Do not use this." }, { @@ -15875,7 +15875,7 @@ "reference": "Why you think that `model_ptr` will be `nullptr` when memory allocation is failed? I think `new daal_knn::Model(column_count)` would throw `std::bad_alloc` if `operator new` is not overloaded. Is it overloaded by DAAL in the way it simply returns `nullptr` in case of bad allocation?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have the `collateral` argument be optional. If the user doesn't specify a collateral amount, the miner will not be able to commit any more sectors.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have the `collateral` argument be optional. If the user doesn't provide a value, the miner will not be able to commit any more sectors.", "reference": "Where does this 0.001 come from? Is this from the network collateral cost function, which happens to be hardcoded right now? I think it's going to rot very quickly: it depends on sector size and (probably) block height." }, { @@ -15883,7 +15883,7 @@ "reference": "Please update the license header in each source file. For more information see: #2697" }, { - "prediction": "I'm not sure what you're trying to do with `opt_proxy` and `retries`.", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to call `sendRequest` with `onOk`, `onError`, `opt_data`, and `opt_proxy` as arguments. I'm not sure what you're trying to do here, but it looks like you're trying to call `sendRequest` with `onOk`, `onError`, `opt_data`, and `opt_proxy` as arguments. I'm not sure what you're trying to do here, but it looks like you're trying to call `sendRequest` with `onOk`, `onError`, `opt_data`, and `opt_proxy` as arguments. I'm not sure what you're trying to do here, but it looks like you're trying to call `sendRequest` with `onOk`, `onError`, `opt_data`, and `opt_proxy` as arguments. I'm not sure what you're trying to do here, but it looks like you're trying to call `sendRequest` with `onOk`, `onError`, `opt_data`, and `opt_proxy` as arguments. I'm not sure what you're trying to do here, but it looks like you're trying to call `sendRequest` with", "reference": "!numbers -> numbers" }, { @@ -15891,15 +15891,15 @@ "reference": "so we don't have universal rules afterwards? In that case I'd remove this entirely (and maybe some places where it's used get cleaner) since we shouldn't ever add a universal rule. Not only because it's way simpler in TS, I'm also just super skeptical about \"universal\". In case of this rule, even control characters may have their place in Swaggers, e.g. in `examples` sections where you can have raw response bodies where control characters are perfectly valid." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `childProcess.spawn` with `options.stdio` set to `ignore`.", + "prediction": "I'm not sure what you mean by \"this process should not wait on the spawned child\"", "reference": "You're welcome to surface this option through the API, but I'm not going to make this the default behavior." }, { - "prediction": "I think it's better to use `path.Join` instead of `filepath.Abs` here.", + "prediction": "I think we can remove the `if !ok { ... }` block.", "reference": "Just a thought that any further extensions of `buildBinaryFor` signature could be done as `buildBinaryFor(..., opts... BuildOptions)` for better readability." }, { - "prediction": "I think we can remove the `InMemoryMetricExporter` and `InMemoryMetricExporterOptions` and just use the `MetricExporter` and `MetricExporterOptions` instead.", + "prediction": "I think this should be `builder.AddMetricReader(new PeriodicExportingMetricReader(exporter, options.MetricExportIntervalMilliseconds));`", "reference": "I'll fix the InMemoryExporter right after this PR lands" }, { @@ -15907,15 +15907,15 @@ "reference": "Good call, none of these are technically invalid" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `Executes` method.", + "prediction": "I think this should be `msbuild /property:Configuration=${{matrix.configuration}} /property:Platform=${{matrix.platform}} dd-continuous-profiler-dotnet\\src\\ProfilerEngine\\Datadog.AutoInstrumentation.Profiler.Native.Windows\\Datadog.AutoInstrumentation.Profiler.Native.Windows.WithTests.proj`", "reference": "this one should be updated too" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `Invocation` class.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way", "reference": "maybe need to add microserviceId too." }, { - "prediction": "I'm not sure if this is a good idea, but I think it's better to have a separate docstring for the missing-param-doc and missing-type-doc.", + "prediction": "I'm not sure if this is a good idea, but I think it would be good to add a test for this.", "reference": "I'm curious, do you create this commit at the very end by rebasing and taking the value you had after moving everything ?" }, { @@ -15923,23 +15923,23 @@ "reference": "It's no longer possible to use `modifyRow` to trim rows and that's ok to use TrimRows instead. But I think we should move this test to TrimRows plugin tests as `trimRows` setting is not a part of the `core`." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have this in the `h2o_configurator_command.h` file.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check for `assert_is_extension(cmd, node) == 0` to make sure we don't try to set a default extension that doesn't exist.", "reference": "The function seems to either return \"default\" or return the extension stripping the preceding dot. Does the fact mean that we can no longer register `.default` as an extension?" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `Container` struct.", + "prediction": "I think we should remove the `ImageDigest` field, since it's not used in the task definition.", "reference": "this may require a statefile version update" }, { - "prediction": "I'm not sure what you're trying to do with this class, but I think it should be renamed to something like `CsvFileReader` or `CsvFileReaderInterface`.", + "prediction": "I'm not sure if this is a good idea, but I think we should use `SplFileObject::fgetcsv()` instead of `SplFileObject::fgetcsv()`.", "reference": "I like when `@deprecated` contains how to resolve it - eg. \"use `SplFileObject::fgetcsv()` instead\". The information in upgrade notes is usefull only during upgrade." }, { - "prediction": "I think we can remove the `google.golang.org/api/compute/v1` and `google.golang.org/api/dns/v1` imports.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea.", "reference": "Nice to see that your local environment is up-to-date now for these changes." }, { - "prediction": "I'm not sure if this is the best place to do this, but I think it's a good idea to have a `countlySidebar` object that contains the `countlySidebar/getSelectedMenuItem` and `countlySidebar/updateSelectedMenuItem` methods. This way, we don't have to call `countlySidebar/getSelectedMenuItem` and `countlySidebar/updateSelectedMenuItem` every time we want to update the sidebar.", + "prediction": "I don't think we need to do this.", "reference": "Instead of setting it to null, i think lets set it to {}" }, { @@ -15947,35 +15947,35 @@ "reference": "We should bump this before releasing and remove all legacy fields that are safe to do so. Since we cannot have multiple versions anyway there's little value in walking around with the \"alpha\" stamp." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you're trying to do here. The `AC_PROG_AWK` macro is used to check for the availability of the `awk` program, but it doesn't seem to be used anywhere else in the code. I'm not sure what you're trying to do here. The `AC_PROG_AWK` macro is used to check for the availability of the `awk` program, but it doesn't seem to be used anywhere else in the code. I'm not sure what you're trying to do here. The `AC_PROG_AWK` macro is used to check for the availability of the `awk` program, but it doesn't seem to be used anywhere else in the code. I'm not sure what you're trying to do here. The `AC_PROG_AWK` macro is used to check for the availability of the `awk` program, but it doesn't seem to be used anywhere else in the code. I'm not sure what you're trying to do here. The `AC_PROG_AWK` macro is used to check for the availability of the `awk` program, but it doesn't seem to be used anywhere else in the code. I'm not sure what you're trying to do here", "reference": "I might suggest a different name for the `DEEPBIND` config.h macro. Perhaps `FLUX_DEEPBIND` to give a hint in the code that we're using a locally provided define." }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would be a good idea to have a separate file for this. It would", + "prediction": "I think we should remove the `518 bytes of a gzipped FileDescriptorProto``` from the `fileDescriptor_62eed357eb71de0e` byte array.", "reference": "Code generated by protoc-gen-go. **DO NOT EDIT.**. The correct way to fix `deprecated` in this file may be updating the protoc / protobuf / grpc and regenerate this file." }, { - "prediction": "I'm not sure what you're trying to say here. I think you're trying to remove the `@Deprecation` annotation, but I'm not sure what you're trying to do with it.", + "prediction": "I don't think this is a good idea. The `@Deprecation` annotation should be used only for deprecated APIs.", "reference": "We should make sure that we cover the testcases in a new unit test class." }, { - "prediction": "I think we should use `unsafe.Sizeof` instead of `C.get_max_user_bytes_per_staged_sector`", + "prediction": "I think this should be `unsafe.Sizeof(C.get_max_user_bytes_per_staged_sector((*C.ConfiguredStore)(unsafe.Pointer(scfg))))`", "reference": "Is this only used in test code? Is there future utility in it for production code? If not, it would be nice if this could be moved into a test package. I'm not sure how hard that would be. CC @laser" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. The `config.WebhookLabel` and `config.APIServiceLabel` should be set in the `init` function, not in the `setConfig` function. This is because the `init` function is called before the `setConfig` function is called, and the `init` function is responsible for setting up the `config` object.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `Plugin` struct, since it's used by other plugins as well.", "reference": "Super curious how you noticed this, as SPIRE itself currently only configures once...?" }, { - "prediction": "I'm not sure what you mean by \"endpoint does not exist on this server\". Is it possible that the endpoint you're trying to access doesn't exist?", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `@ResponseBody` annotation on the `ResponseEntity` to make it easier for the client to parse the response.", "reference": "This `startsWith` seems a bit brittle because in the code base we'll occasionally spell it \"DataFile\"." }, { - "prediction": "I think this is too big. I think it's better to set it to 1000000 or 10000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "prediction": "I think this should be 9999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999", "reference": "if it keeps reconnecting for too long, how should we get alerted?" }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to set the keepalive status to 0, so that we don't have to worry about it being set to 1 in the future.", "reference": "it's better to use single name style in one name." }, { @@ -15983,15 +15983,15 @@ "reference": "As defaultSendPort is being removed, and I don't like TODOs on examples, please remove the whole line" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check here to make sure that we don't try to update a project that already has DNS delegation enabled.", + "prediction": "I think we should be able to do this in a single line.", "reference": "Should we return `nil` when `err == errChangeSetEmpty` instead of calling l.103 `WaitUntilStackUpdateCompleteWithContext`?" }, { - "prediction": "I think we can remove the `ord` field from the `VectorWriter` class, as it is not used anywhere in the code.", + "prediction": "I think this should be `ord` instead of `ordBase`?", "reference": "Hmmm I thought spotless would wrap this line, but it doesn't seem to complain about it" }, { - "prediction": "I think we should remove the `Selector` field from the SpiffeIDSpec struct.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `SpiffeIDSpec` struct.", "reference": "I think this will require updating the api version. we are planning to do this anyways, so perhaps we can lump this in so we don't have to update too many times?" }, { @@ -15999,7 +15999,7 @@ "reference": "revert this for parity" }, { - "prediction": "I'm not sure what this is for. It looks like it's just a bunch of `#define`s, but I'm not sure what they're used for.", + "prediction": "I don't think we need to change this.", "reference": "INCR_BATCH and DECR_BATCH could be exposed as tuneable command line options but that might be too low level to expose. I think keeping private for now where \"in the know\" folks could use to try and tune makes sense. These values were choosen mostly \"at random\" and have worked out for us thus far." }, { @@ -16007,15 +16007,15 @@ "reference": "Currently this isn't very clean because we have to re-use some of the predefined parser types - the demo uses WRITER_U_CTAGS but there should be some support for custom writer type." }, { - "prediction": "I think we can remove the `puts` here. It's not really necessary.", + "prediction": "I don't think we need to use `puts` here. We can just print the response body directly.", "reference": "I think this was left it accidentally :)" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it's not clear to me why you'd want to do this. It's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. The `NEWUTS` and `NEWIPC` namespace types are not used in any way in the current codebase, so it would be better to keep them out of the `NamespaceTypes` slice.", "reference": "Can you finish re-ordering this list to match the one that was deleted?" }, { - "prediction": "I think we can remove the `if exp.Target.StressChaos.ContainerName != nil` check.", + "prediction": "I think we can remove the `containerName` field from the stresschaos spec.", "reference": "Do we need to check if `exp.Target.StressChaos` is `nil`?" }, { @@ -16023,7 +16023,7 @@ "reference": "AWS Identity and Access Management (IAM)" }, { - "prediction": "I think we can remove the `cstor-volume-create-puttargetservice-default` task.", + "prediction": "I think we can remove the `default` from `cstor-volume-create-listcstorpoolcr-default` and `cstor-volume-create-listclonecstorvolumereplicacr-default`", "reference": "not calling this is going to impact current functionality which depends on PVC.. let us still call this and set the values to default as 'none' (or empty) by handling the error from 'get' operation" }, { @@ -16035,11 +16035,11 @@ "reference": "No need to create a dir for transformer. Simply move transformer.py into mmdet/models/utils/" }, { - "prediction": "I don't think we need to do this.", + "prediction": "I don't think this is necessary.", "reference": "Can't you just add `SelectSubscriptionActivity` directly to the manifest instead of opening `MainActivity` that then starts it?" }, { - "prediction": "I'm not sure if this is the right place to add this flag, but I think it's a good idea to add it to the spec.", + "prediction": "I'm not sure if this is the right place to put this, but I think it would be a good idea to move this to the `main.go` file, so that it can be used by `main.go` as well.", "reference": "Maybe say \"the spec's %check section\" so it's clearer what we mean." }, { @@ -16051,15 +16051,15 @@ "reference": "ClockIpLpi2c4.Enable() is required. The same change is required for enablePeripheralClocks()." }, { - "prediction": "I think we can remove the `Sha` field, as it's not used anywhere in the spec.", + "prediction": "I'm not sure if this is a good idea, but I think we should have a `Sha` field in the `PrometheusSpec` struct as well.", "reference": "nit: this should be `SHA` since it is an acronym for `Secure Hash Algorithm`, no?" }, { - "prediction": "I'm not sure if this is the right way to do this, but I think we should be able to use `Intl.DateTimeFormat` to get the current time zone.", + "prediction": "I don't think we need to use `Intl.DateTimeFormat().resolvedOptions()` here. We can just use `jstz.determine()` here.", "reference": "Not sure if Intl can be defined but not `Intl.DateTimeFormat`. Both seem to have the same percentage on CanIUse." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate function for this. It's", + "prediction": "I think we can remove the `if stgType == \"hostpath\"` check.", "reference": "PTAL, looks like the order of PVC & PV is reversed for different storage-engine types, for Jiva/CStor the args sent to sendEventOrIgnore are `PV, PVCName`." }, { @@ -16067,31 +16067,31 @@ "reference": "Remove the trailing white space" }, { - "prediction": "I'm not sure what you mean by \"incompatible\" here. I think it means that `mmcv >= mmcv_minimum_version` and `mmcv <= mmcv_maximum_version` are both true, but `mmcv > mmcv_minimum_version` and `mmcv < mmcv_maximum_version` are both false.", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `>=` and `<=` instead of `==` and `<` and `>`. This is because `>=` and `<=` are more specific than `==` and `<` and `>`.", "reference": "No need to modify this." }, { - "prediction": "I think this should be `if comp.Protocol().Name != \"dnsaddr\"` instead of `comp.Protocol().Name != \"dnsaddr\"`.", + "prediction": "I'm not sure if this is a good idea, but I think we should be able to use `ma.Multiaddr` directly in the `Discover` function, so we don't need to use `ma.Multiaddr` in the `f` function.", "reference": "would be nice at some point to clean this signature up... not relevant for this PR" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a good idea to add a `type` field to the `fieldConfiguration` array. This will allow the backend to display the content of the field as a string, which might be useful for certain use cases.", + "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason you want to set the `type` to `text` for a virtual field?", "reference": "Here, is it `null` because it is `null` in `$fieldConfiguration`, or because it has been set to `null` above in the `array_replace` ? If it doesn't exists at all in `$fieldConfiguration`, I think you should add `type => 'text'` above in the `array_replace`." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I think this should be `if (node instanceof ClassOrInterfaceDeclaration)` instead of `if (node instanceof ClassOrInterfaceDeclaration && ((ClassOrInterfaceDeclaration) node).getFullyQualifiedName().get().equals(className))`", "reference": "I was thinking about this for #2928 too, which also uses `endsWith`... Presumably `SomeOtherObject` would match `endsWith(\"Object\")`, meaning that something more sophisticated like splitting it then iterating right to left would be needed in order to do this robustly?" }, { - "prediction": "I think this should be `exporterType` instead of `ExporterType`.", + "prediction": "I think we should remove the `DefaultMaxPayloadSizeInBytes` property.", "reference": "I think this name is a bit confusing because if you asked someone what type of exporter they were using they would probably say Zipkin or Jaeger, etc. How about `ProcessorType` with `Simple` and `Batch` definitions?" }, { - "prediction": "I'm not sure what you mean by \"EnablePiped\" and \"RecreatePipedKey\". Could you please clarify?", + "prediction": "I think this should be `nil` instead of `&webservice.RecreatePipedKeyResponse{}`.", "reference": "`req` is unused in RecreatePipedKey" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is it possible that you're trying to use the `__()` function in a way that doesn't make sense? I'm not sure what you're trying to do here. Is it possible that you're trying to use the `__()` function in a way that doesn't make sense? I'm not sure what you're trying to do here. Is it possible that you're trying to use the `__()` function in a way that doesn't make sense? I'm not sure what you're trying to do here. Is it possible that you're trying to use the `__()` function in a way that doesn't make sense? I'm not sure what you're trying to do here. Is it possible that you're trying to use the `__()` function in a way that doesn't make sense? I'm not sure what you're trying to do here. Is it possible that you're trying to use the `__()` function in a way that doesn't make sense? I'm not sure what you're trying to do here. Is it possible that you're trying to use the `__()` function in a way that doesn't make sense? I'm not sure what you're trying to", + "prediction": "I'm not sure I understand what you're trying to do here. Is it that you want to show a message to the user that they need to place the AdSense code? If that's the case, then I think we should just remove the AdSense code from the site.", "reference": "The \"Adsense\" term needs to be capitalized - I just noticed this was wrong through ACs and IB, so not a problem of the PR itself really. I'll quickly fix it." }, { @@ -16099,7 +16099,7 @@ "reference": "do which methods need to be registered? is it basically just the ones that are directly referenced in ParDo calls? (The Beam GoDoc doesn't say anything about it. :/ )" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.", + "prediction": "I don't think this is necessary.", "reference": "@bmckinney does this mean that the bibtex citation will be available via API?" }, { @@ -16107,11 +16107,11 @@ "reference": "We should probably tag the cliquet-fxa version as well." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to parse an IPv4 address. I'm not sure what you're trying to do here, but it looks like you're trying to parse an IPv4 address. I'm not sure what you're trying to do here, but it looks like you're trying to parse an IPv4 address. I'm not sure what you're trying to do here, but it looks like you're trying to parse an IPv4 address. I'm not sure what you're trying to do here, but it looks like you're trying to parse an IPv4 address. I'm not sure what you're trying to do here, but it looks like you're trying to parse an IPv4 address. I'm not sure what you're trying to do here, but it looks like you're trying to parse an IPv4 address. I'm not sure what you're trying to do here, but it looks like you're trying to parse an IPv4 address. I'm not sure what you're trying to do here, but it looks like you're trying to parse an IPv4 address. I'm not sure what you're trying to do here, but it looks like you're trying to parse an", + "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", "reference": "IIRC we need to use memset, because an empty brace is not C99 comformant, and because we cannot use `{0}` because how the struct is organized is not defined in POSIX (the initializer cannot be `{0}` if the first property of the struct is a struct)." }, { - "prediction": "I'm not sure what you mean by \"cannot be set with any other selector.\"", + "prediction": "I'm not sure if this is a good idea, but I think we should add a `ServiceAccount` field to the `NetworkPolicyPeer` struct.", "reference": "Will we be adding this to `AppliedTo` as well? If not, any reason why not?" }, { @@ -16119,39 +16119,39 @@ "reference": "Just a note that this feels weird being on the base NVDAObject rather than IAccessible, but right now, I understand that's how it has to be because we fire MSAA caret events on the focus object regardless of whether it's IAccessible. I think we should consider restricting these caret events to focus objects that are IAccessible subclasses in future, but that change is probably too risky for this PR. CC @MichaelDCurran for his thoughts." }, { - "prediction": "I don't think we need to use `null` for the `payment_detail` field.", + "prediction": "I don't think we need to use `null` for the `payment_detail` field. We can use `null` for the `payment_detail` field as well.", "reference": "This change and other similar ones should not be part of this commit. This commit is about adding a ImageUploadType not fixing controllers and stuff." }, { - "prediction": "I'm not sure what you mean by \"should account scope, even with wc for now, but later on\"", + "prediction": "I'm not sure what you mean by \"should account scope, even with wc for now, but later on we can then shard as needed.\" I'm not sure what you mean by \"should account scope, even with wc for now, but later on we can then shard as needed.\" I'm not sure what you mean by \"should account scope, even with wc for now, but later on we can then shard as needed.\" I'm not sure what you mean by \"should account scope, even with wc for now, but later on we can then shard as needed.\" I'm not sure what you mean by \"should account scope, even with wc for now, but later on we can then shard as needed.\" I'm not sure what you mean by \"should account scope, even with wc for now, but later on we can then shard as needed.\" I'm not sure what you mean by \"should account scope, even with wc for now, but later on we can then shard as needed.\" I'm not sure what you mean by \"should account scope, even with wc for now, but later on we can then shard as needed.\" I'm not sure what you mean by \"should account scope, even with wc for now, but later on we can", "reference": "I am a bit confused about PING here. Ping is implied and it overlaps with \"$SYS.REQ.ACCOUNT.%s.%s\" where the last token is what is requested (CONNZ) and the one before is the requested account id." }, { - "prediction": "I think we should remove the `if err := req.QueryOption(api.OptCatalogSubFolder, subfolder).QueryOption(api.OptCatalogMaxDepth, maxDepth).Do().Unmarshal(&catalog); err != nil` line.", + "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to do this with a single call to `v.c.Get().Resource`.", "reference": "nit: use the OptSubFolder constants. Also in the client you are using \"maxdepth\" but in the server the constant for \"depth\" is being used." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `resolveConf` here.", + "prediction": "I'm not sure what you mean by `data` and `htpasswd` in this context. I think you meant `storage` and `htpasswd` in this context.", "reference": "I also moved this to `/verdaccio/storage` since it's written in runtime, and the approach here is to make the configuration by default read-only." }, { - "prediction": "I think this should be `@returns {Stream|Promise}` instead of `@returns {Stream|gax.EventEmitter}`.", + "prediction": "I think we should remove the `@returns {Stream|gax.EventEmitter}` from the `@returns {Stream|Promise}`.", "reference": "nit: s/has cancel method/has a cancel method" }, { - "prediction": "Shouldn't it be `first_quiz` instead of `first_question`?", + "prediction": "Shouldn't this be `first_quiz` instead of `first_question`?", "reference": "Useless assignment to variable - `second_quiz`. Use `_` or `_second_quiz` as a variable name to indicate that it won't be used." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new gzip writer. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new gzip writer. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new gzip writer. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new gzip writer. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new gzip writer. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new gzip writer. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new gzip writer. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new gzip writer. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new gzip writer. I'm not sure what you're trying to achieve with this,", + "prediction": "I'm not sure what you mean by \"Suffix\" here. Is it supposed to be the file extension? Or is it supposed to be something else? I'm not sure what you mean by \"Suffix\" here. Is it supposed to be the file extension? Or is it supposed to be something else? I'm not sure what you mean by \"Suffix\" here. Is it supposed to be the file extension? Or is it supposed to be something else? I'm not sure what you mean by \"Suffix\" here. Is it supposed to be the file extension? Or is it supposed to be something else? I'm not sure what you mean by \"Suffix\" here. Is it supposed to be the file extension? Or is it supposed to be something else? I'm not sure what you mean by \"Suffix\" here. Is it supposed to be the file extension? Or is it supposed to be something else? I'm not sure what you mean by \"Suffix\" here. Is it supposed to be the file extension? Or is it supposed to be something else? I'm not sure what you mean by \"Suffix\" here. Is it supposed to be the file extension? Or is it supposed to be something else? I'm not sure what you mean by", "reference": "Is this still needed since there's the `GzipPrecompressed` type?" }, { - "prediction": "I don't think this is a good idea. It's not clear to me what the problem is here.", + "prediction": "I don't think this is a good idea. It's not clear to me what the problem is here. Is it that we don't have a way to specify the number of categories? Or is it that we don't have a way to get the number of categories? Or is it that we don't have a way to set the number of categories? Or is it that we don't have a way to get the number of categories? Or is it that we don't have a way to set the number of categories? Or is it that we don't have a way to get the number of categories? Or is it that we don't have a way to set the number of categories? Or is it that we don't have a way to get the number of categories? Or is it that we don't have a way to set the number of categories? Or is it that we don't have a way to get the number of categories? Or is it that we don't have a way to set the number of categories? Or is it that we don't have a way to get the number of categories? Or is it that we don't have a way to set the number of categories? Or is it that we don't have a way to get the number", "reference": "this is spelled wrong and also not used so remove it" }, { - "prediction": "I'm not sure what you mean by \"unique equals and hashcode\"", + "prediction": "I'm not sure if this is a good idea, but I think it would be a good idea to add a method to `ServerWebExchangeMatchers` that takes a `ServerWebExchangeMatcher` and returns a `ServerWebExchangeMatcher` that matches any exchange.", "reference": "It might be right here that's the issue ^" }, { @@ -16159,7 +16159,7 @@ "reference": "@danieldietrich let's leave existing extension. Here we just mark `keyComparator()` with `@Deprecated` annotation" }, { - "prediction": "I think this should be `#include ` instead of `#include `.", + "prediction": "I think this should be `#include ` instead of `#include `.", "reference": "This breaks CI. I am not sure why you need to include io.h in this file especially on linux." }, { @@ -16167,19 +16167,19 @@ "reference": "this seems equivalent" }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good place to put this in the config file. I'm not sure if this is the best place to put this in the config file. I'm not sure if this is the best place to put this in the config file. I'm not sure if this is the best place to put this in the config file. I'm not sure if this is the best place to put this in the config file. I'm not sure if this is the best place to put this in the config file. I'm not sure if this is the best place to put this in the config file. I'm not sure if this is the best place to put this in the config file. I'm not sure if this is the best place to put this in the config file. I'm not sure if this is the best place to put this in the config file. I'm not sure if this is the best place to put this in the config file. I'm not sure if this is the best place to put this in the config file. I'm not sure if this is the best place to put this in the config file. I'm not sure if this is the best", + "prediction": "I'm not sure if this is the best place to put this, but I think it would be good to add a comment explaining what this is for.", "reference": "change size to 50MB criticial, 10MB warn... change count to 50k critical, 5k warn..." }, { - "prediction": "I think we can remove the `for` loop in this case. We don't need to iterate over the `pivotFacetResponsesFromShard` list. We only need to iterate over the `pivotFacetResponseFromShard` list.", + "prediction": "I think we should remove the `for` loop here, as it's not necessary.", "reference": "This has nothing to do with master/slave replication. Is this something we want to change too? If so, I guess this is an aggregation?" }, { - "prediction": "I think this should be `pid = fork { run_specs(run_descriptor) }` instead of `pid = fork { run_specs(run_descriptor) } # We don't use Process.waitpid here as it was causing bisects to block due to the file descriptor limit on OSX / Linux. We need to detach the process to avoid having zombie process and consume slot in the kernel process table.`", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `Process.waitpid(pid, 0)` instead of `Process.waitpid(pid, 1)`.", "reference": "Maybe it makes sense to mention that those zombies are not forever, but only up to the moment when the parent process exits? Is that correct according to your observations, @benoittgt ? Please disregard this note if zombies remain after." }, { - "prediction": "I'm not sure what you're trying to do with this, but it seems like you're trying to start the moto server, but then you're trying to start the specific service mocking, which basically starts the service backend. I'm not sure what you're trying to do with this, but it seems like you're trying to start the moto server, but then you're trying to start the specific service mocking, which basically starts the service backend. I'm not sure what you're trying to do with this, but it seems like you're trying to start the moto server, but then you're trying to start the specific service mocking, which basically starts the service backend. I'm not sure what you're trying to do with this, but it seems like you're trying to start the moto server, but then you're trying to start the specific service mocking, which basically starts the service backend. I'm not sure what you're trying to do with this, but it seems like you're trying to start the moto server, but then you're trying to start the specific service mocking, which basically starts the service backend. I'm not sure what you're trying to do with this, but it seems like you're trying to start the moto server, but then you're trying", + "prediction": "I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place", "reference": "moto mock setup needs to happen before boto usage." }, { @@ -16187,11 +16187,11 @@ "reference": "`hasattr(cb, 'first_metric_only') and cb.first_metric_only` -> `getattr(cb, 'first_metric_only', False)`" }, { - "prediction": "I think this is a good idea, but I'm not sure if it's the best way to do it. It's a bit of a hack, but I think it's the best way to do it.", + "prediction": "I think this should be `func newStreamHandler(handle func(ServerStream) error)` instead of `func handle func(ServerStream) error`", "reference": "no newline for function" }, { - "prediction": "I'm not sure what you mean by \"scale <= 0\". I think you meant to say \"scale >= 0\".", + "prediction": "I'm not sure what you mean by \"scale <= 0\". I think you meant to say \"scale >= 0\" or \"scale > 0\".", "reference": "This makes me feel icky. We could also go the route of making `wlr_output.scale` a double instead of a float, but that would be a more widely reaching change." }, { @@ -16199,59 +16199,59 @@ "reference": "Again, would be awesome if you could remove the tabs in these 3-4 lines as well." }, { - "prediction": "I think we can remove the `if (!step.ref.empty())` and `if (!step.pronunciation.empty())` checks.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to `util::json::Object::values` instead of `util::json::Object::values[\"name\"]` and `util::json::Object::values[\"pronunciation\"]`.", "reference": "You're moving multiple times from `step.name`; you're not allowed to do that. Instead you have to copy the `step.name` string and (if you want to) move once at the very last." }, { - "prediction": "I don't think this is a good idea. The user should be able to select a calendar.", + "prediction": "I don't think this is a good idea.", "reference": "What about `may not end`? @jancborchardt" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check to see if the user is in the approver list before trying to approve the stage. If they are not in the approver list, we should return a 403 error.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the user is in the approver list. If they are not, we should return a 403.", "reference": "If you think about it, the status should be PermissionDenied?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to modify the `__init__` method of the `MappingJobQueue` class. The `__init__` method should only be called once when the class is instantiated.", + "prediction": "I'm not sure what you mean by `stats[\"listen_count\"]` and `stats[\"listen_count\"] / stats[\"listen_count\"] * 100.0`", "reference": "Calculation looks good but don't know what format etc grafana expects this to be in." }, { - "prediction": "I think this test should be moved to `test_docker_client.py` instead of `test_run_with_additional_arguments_add_host.py`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a test for the `--add-host` flag to the `run_container` method.", "reference": "nit: We could use the `to_str(..)` util here. (let's not bother changing for this PR.. )" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to add a new field to the `TaskList` struct, but I'm not sure if that's the best way to go about it. I think it would be more appropriate to add a new field to the `TaskList` struct, and then update the `TaskList` struct in the `tasklist.pb.go` file to reflect the new field.", + "prediction": "I'm not sure what you're trying to do here. I don't think we need to change anything here.", "reference": "Can you rename alias to `executiongenpb`. The rule is package+\"pb\" for `temporal-proto` and package+\"genpb\" for server protos." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add a docstring to this function.", + "prediction": "I'm not sure what you mean by \"copyqr\" here. I think you meant to say \"copyqr := make([]*subscription, len(qr))\" or \"copyqr := make([]*subscription, len(qr))\".", "reference": "Any noticeable performance hit? Any other way to avoid the allocation and copy even of the array?" }, { - "prediction": "I'm not sure what you're trying to do here. The `readLastByte` function should be called after `readByte` is called, and the `readByte` function should be called before `readLastByte` is called.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. The `readLastByte` function should only be called when `readByte` is called, and the `readByte` function should only be called when `readLastByte` is called. This way, the `readLastByte` function will only be called when `readByte` is called, and the `readByte` function will only be called when `readLastByte` is called. This way, the `readLastByte` function will only be called when `readByte` is called, and the `readByte` function will only be called when `readLastByte` is called. This way, the `readLastByte` function will only be called when `readByte` is called, and the `readByte` function will only be called when `readLastByte` is called. This way, the `readLastByte` function will only be called when `readByte` is called, and the `readByte` function will only be called when `readLastByte` is called. This way, the `readLastByte` function will only be called when `readByte` is called, and the `read", "reference": "What if you remove this line entirely from here?" }, { - "prediction": "I'm not sure what you mean by `self.add_extra_convs == 'on_output'`. I think you meant to say `self.add_extra_convs == 'on_input'`.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to add the extra_convs_on_inputs flag to the FPN class.", "reference": "`on_lateral` can also be implemented" }, { - "prediction": "I'm not sure what you're trying to do here. I think you want to update the empty imageView with the image from the feed, but I'm not sure what you're trying to do here. I think you want to update the empty imageView with the image from the feed, but I'm not sure what you're trying to do here. I think you want to update the empty imageView with the image from the feed, but I'm not sure what you're trying to do here. I think you want to update the empty imageView with the image from the feed, but I'm not sure what you're trying to do here. I think you want to update the empty imageView with the image from the feed, but I'm not sure what you're trying to do here. I think you want to update the empty imageView with the image from the feed, but I'm not sure what you're trying to do here. I think you want to update the empty imageView with the image from the feed, but I'm not sure what you're trying to do here. I think you want to update the empty imageView with the image from the feed, but I'm not sure what you're trying to do here. I think you want to update the empty imageView with the image", + "prediction": "I'm not sure what you mean by \"empty imageView with the image from the feed\". I think you meant to say \"empty imageView with the image from the feed URL\".", "reference": "Please add a space between `if` and `(`." }, { - "prediction": "I'm not sure what this is for, but it looks like it could be used to determine if the pool is online or not.", + "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to have a `PoolAddEventHandled` field in the `zpool` struct. It would be useful to know if the pool has been created or imported.", "reference": "This statuses might have been better off with some custom status type. However, good for now." }, { - "prediction": "I think this should be `if ipNet, ok := addr.(*net.IPNet); ok` instead of `if ipNet, ok := addr.(*net.IP); ok`", + "prediction": "I think we can remove the `if ipNet.IP.IsGlobalUnicast()` check.", "reference": "Thanks for catching the bug. Here your change lets `v4IPNet` and `v6IPNet` take the first IPv4/IPv6 address in `addrList`. Maybe choose the last one also works and makes code simpler? What's your idea? @tnqn" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `UserResource` class, so that it can be used in other places as well.", + "prediction": "I think we can remove the `record_id` from the `detail_dict` and just use `record_id` in the response.", "reference": "nitpick: you can name this variable just `details`" }, { - "prediction": "I think this should be `installJadeParser` instead of `installJadeParser (const langType language)`", + "prediction": "I think this should be `static const char* extensions[] = { \"jade\", NULL };` instead of `static const char* extensions[] = { \"jade\", NULL };`", "reference": "The character class in the regex should probably be \"[a-zA-Z0-9_]\"." }, { @@ -16259,11 +16259,11 @@ "reference": "Please also increment `Settings.VERSION` and update `AccountSettings`." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bad idea to use `time.Sleep` to wait for the interface to be ready. It's better to use `time.After` to wait for the interface to be ready, and then use `time.Sleep` to wait for it to be ready.", + "prediction": "I'm not sure what you mean by \"set by the Makefile\". I think you meant to say \"set by the Makefile\"", "reference": "I think this should just say \"build \". And when builddate wasn't set, e.g. somebody built weave with 'go build' or some other way, this should return \"unknown\"." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `withJobGroupInfo` method to create the `JobGroupInfo` object. This way, we don't have to create the `JobGroupInfo` object in the `execute` method, and we don't have to create the `JobGroupInfo` object in the `doExecute` method. This way, we can reuse the `JobGroupInfo` object in the `execute` method, and we can reuse the `JobGroupInfo` object in the `doExecute` method. This way, we can reuse the `JobGroupInfo` object in the `execute` method, and we can reuse the `JobGroupInfo` object in the `doExecute` method. This way, we can reuse the `JobGroupInfo` object in the `execute` method, and we can reuse the `JobGroupInfo` object in the `doExecute` method. This way, we can reuse the `JobGroupInfo` object in the `execute` method, and we can reuse the `JobGroupInfo` object in the `doExecute` method. This way, we can reuse the `JobGroupInfo` object", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use a `JobGroupInfo` for this. The `JobGroupInfo` can be used to get information about the job group, and the `execute` method can be used to execute the job.", "reference": "Can we move this into a separate var and call it `desc` like below?" }, { @@ -16271,7 +16271,7 @@ "reference": "why RpcSchema need this annotations?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this.", + "prediction": "I think this should be `if s.sys != nil && s.sys.replies != nil {` instead of `if s.sys != nil && s.sys.replies != nil {`", "reference": "Not sure it makes sense to send the reply if we did not delete from the map, but I guess it does not hurt.." }, { @@ -16279,15 +16279,15 @@ "reference": "Most of these variables can be moved after `return` or to the body of `if` statement." }, { - "prediction": "I think we can remove the last one, as it's not really a privacy multi-tenancy error.", + "prediction": "I think it's better to have a single error code for all of these.", "reference": "nit: Is this actually just a http \"unauthorised\" response? Or is that too vague? If this is the right way to go ... is \"token\" the right word\" Or do we want to say something else?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it would be better to just use `config.boltdir.path` instead of `config.puppetdb`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `Bolt::PuppetDB::Client` class.", "reference": "We check for `$future` in PuppetDB::Config, so this won't change behavior if you don't have `future` set." }, { - "prediction": "I'm not sure I understand what you're trying to do here. You're trying to create a `DataFrameGroupBy` object from a `DataFrame` and a list of column names, but you're not passing the column names to the `DataFrameGroupBy` constructor. Is this what you're trying to do? If so, what's the purpose of the `as_index` parameter?", + "prediction": "I'm not sure what you mean by `df_or_s._kdf` here. I think it should be `df_or_s._kdf._kdf` or `df_or_s._kdf._kdf._kdf` or something like that.", "reference": "I think you should remove `if isinstance(by, str):`,. We also should fix the error message `raise ValueError('Not a valid index: TODO')` to match with pandas'" }, { @@ -16295,11 +16295,11 @@ "reference": "Curious - do we want this to be `OTel.GrpcHandler.Request`? For example, if someone is debugging a crash dump, they would get some hint that it was added by OpenTelemetry." }, { - "prediction": "I think this should be a `CommitStateUnknownException` instead of a `CommitStateUnknownException` as well.", + "prediction": "I think this should be `throw new CommitStateUnknownException();` instead of `throw a CommitStateUnknownException;`", "reference": "nit: unnecessary `

    `" }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. If you want to use the HDF5 library, you should use the `HDF5Reader` class, not the `HDF5` class.", + "prediction": "I don't think this is a good idea. We need to check if we have a HDF5 library, and if not, throw an error.", "reference": "Should just be `#ifdef ADIOS2_HAVE_HDF5`" }, { @@ -16307,31 +16307,31 @@ "reference": "FYI: I deployed a stack with multiple lengths for the stack name and resource id to cloudformation, to see how it truncates the parts for the final FunctionName" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think we need to use the `i` variable here. We can just use `w.Store.ListServices(i.AppDomain)` to get the list of services in the domain.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to make sure that the `healthCheck` and `appDomain` are set in the manifest, and that the `appDomain` is the same as the `appDomain` in the `ServiceProps` struct.", "reference": "Did we not use this field @_@" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `buildArgs` method of the `Config` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the `android_key_password` and `android_key_alias` are set before calling `getNPMConfig` in the `buildArgs` method.", "reference": "shouldn't this be `android_keystore_name`?" }, { - "prediction": "I'm not sure what you mean by this, but I think it's a good idea to add a comment to this line to explain what it's doing. It's not clear to me what the purpose of this line is.", + "prediction": "I'm not sure if this is a good idea, but I think we should be able to do this in one line.", "reference": "Double check the issuers package too :)" }, { - "prediction": "I think we should rename this to `Continue` and `Return` instead of `Continue -> continue loop to next consumer` and `Return -> return and thereby break the loop`.", + "prediction": "I think this should be `Return` instead of `Continue`?", "reference": "This is out of date right? Now that `_is_first_level_self_reference` uses it as well? Perhaps we should make the docstring more general and not refer to method names that could change." }, { - "prediction": "I'm not sure what you mean by \"can't extend the names since ns cannot be created with more than 63 characters\"", + "prediction": "I don't think we need to extend the names here.", "reference": "This test alone takes around 10-12 minutes to run. It has 20 subtests each of which takes around one minute. We should see if we there are redundant subtests that we can remove, or look for a way to optimize them." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `Object.keys(newProps)` instead of `Object.keys(newProps).sort()`.", + "prediction": "I think this should be `for (let i = 0; i < keys.length; i++)` instead of `for (let i = 0; i < keys.length; i++) {`", "reference": "Good call, we need to keep that check :+1:" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. The `ParseRequestLine` and `ParseHeaders` methods don't actually parse the request line or headers, they just read them into a `ReadOnlySequence`. If you want to parse the request line and headers, you should use the `ParseRequestLine` and `ParseHeaders` methods directly.", + "prediction": "I'm not sure what you mean by \"ParseRequestLine(TRequestHandler handler, ref BufferReader reader)\". I think you meant to say `ParseRequestLine(TRequestHandler handler, in ReadOnlySequence buffer, out SequencePosition consumed, out SequencePosition examined, out int consumedBytes);`", "reference": "Should the interface have 2 `ParseHeaders` methods?" }, { @@ -16347,15 +16347,15 @@ "reference": "Just delete it, `embedding_rpn_head` is not a `Detector` which should have `show_result`." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `GetTag` method to get the `HttpMethod`, `HttpRequestHeadersHost` and `HttpUrl` from the `Span` object.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `GetTag` method to get the value of the tag, and then use the `ToString` method to convert it to a string.", "reference": "Where do we _get_ tag values? edit: I mean, where are these `GetFoo()` methods called from? It just seems weird to me that we are getting tag values from spans. I thought we only ever _set_ tags on spans." }, { - "prediction": "I'm not sure what you mean by \"kzip with %v encoding\". Is this the same as \"kzip\" or is it something else? If it's the same as \"kzip\", then I think we should just use \"kzip\" instead of \"kzip with %v\". If it's something else, then I'm not sure what you mean by this.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `log.Printf` to log the size of the kzip file.", "reference": "This seems like log spam. Maybe expose the encoding as a method and log at the point of interest?" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I think it's better to use `0xc023` instead of `0x8021` for `P-CSCF IPv4 Address Request`.", "reference": "I looked up that one, and it seems correct: Authentification is French, Authentication seems to be correct" }, { @@ -16363,55 +16363,55 @@ "reference": "Can we print a more human-friendly warning here, saying that plotting won't work or something along those lines?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I'm not sure what you mean by `HTTPMessage = http.Message`. It seems like you're trying to create a new class that inherits from `http.Message`, but I don't think that's what you want to do.", "reference": "@mhils didn't we try to get rid of these (now empty) wrapper classes?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add a comment to explain what this change does.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure it's a good idea.", "reference": "I would avoid importing `felix/ipsets` package because this package is the windows equivalent and should be at the same level of `felix/ipsets`. We could add linux specific dependencies into `felix/ipsets` later and it will break Windows build." }, { - "prediction": "I'm not sure if this is the right place to register a table. I think it should be in the `Catalog` class.", + "prediction": "I think this should be `registerTable(TableIdentifier identifier, String metadataFileLocation)` instead of `Table registerTable(TableIdentifier identifier, String metadataFileLocation)`.", "reference": "Maybe, `import` would be a better name." }, { - "prediction": "I think this should be `PARAMETER_MAX_RESULTS` instead of `PARAMETER_PAGE_SIZE`.", + "prediction": "I think it's better to use `PARAMETER_MAX_RESULTS` and `PARAMETER_PAGE_SIZE` instead of `PARAMETER_PAGE_TOKEN` and `PARAMETER_NEXT_PAGE_TOKEN`.", "reference": "Wouldn't we want `PARAMETER_MAX_RESULTS` in here as well? (I might be miunderstanding how this is used)" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to ensure that the system roles have been created before running the tests. I'm not sure what you're trying to achieve with this, but it looks like you're trying to ensure that the system roles have been created before running the tests. I'm not sure what you're trying to achieve with this, but it looks like you're trying to ensure that the system roles have been created before running the tests. I'm not sure what you're trying to achieve with this, but it looks like you're trying to ensure that the system roles have been created before running the tests. I'm not sure what you're trying to achieve with this, but it looks like you're trying to ensure that the system roles have been created before running the tests. I'm not sure what you're trying to achieve with this, but it looks like you're trying to ensure that the system roles have been created before running the tests. I'm not sure what you're trying to achieve with this, but it looks like you're trying to ensure that the system roles have been created before running the tests. I'm not sure what you're trying to achieve with this, but it looks like you", + "prediction": "I'm not sure what you're trying to achieve with this, but I'm not sure why you'd want to use `before(:suite)` here.", "reference": "We can re-use the config in our tests." }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to move this into the `pkg-config` section of the `configure.ac` file. I think it's a good idea to move this into the `pkg-config` section of the `configure.ac` file. I think it's a good idea to move this into the `pkg-config` section of the `configure.ac` file. I think it's a good idea to move this into the `pkg-config` section of the `configure.ac` file. I think it's a good idea to move this into the `pkg-config` section of the `configure.ac` file. I think it's a good idea to move this into the `pkg-config` section of the `configure.ac` file. I think it's a good idea to move this into the `pkg-config` section of the `configure.ac` file. I think it's a good idea to move this into the `pkg-config` section of the `configure.ac` file. I think it's a good idea to move this into the `pkg-config` section of the `configure.ac` file. I think it's a good idea to move this into the `pkg-config`", + "prediction": "I'm not sure why we need to do this, but I think it's a good idea. I'm not sure why we need to do this, but I think it's a good idea. I'm not sure why we need to do this, but I think it's a good idea. I'm not sure why we need to do this, but I think it's a good idea. I'm not sure why we need to do this, but I think it's a good idea. I'm not sure why we need to do this, but I think it's a good idea. I'm not sure why we need to do this, but I think it's a good idea. I'm not sure why we need to do this, but I think it's a good idea. I'm not sure why we need to do this, but I think it's a good idea. I'm not sure why we need to do this, but I think it's a good idea. I'm not sure why we need to do this, but I think it's a good idea. I'm not sure why we need to do this, but I think it's a good idea. I'm not sure why we need to do this, but I think it's", "reference": "Wouldn't we have the same issue with the internal libevent? IIRC, the integration is pretty close to an exact duplicate. Or does the libevent m4 code already take that into account when setting this variable? PMIx _requires_ libevent, so it isn't like pmix_libevent_support can be anything other than 1. I'm okay with leaving this question for separate resolution - just wondering why we don't have the same issue here." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check for `info.looksLikeChrome()` and `info.looksLikeChromeOniOS()`. This way, we don't need to check for `info.looksLikeEdge()`.", + "prediction": "I'm not sure if this is the right place to add this check, but I think it's worth it to make sure we don't miss any edge cases.", "reference": "The actual User-Agent string uses \"CriOS\" not \"CRiOS\"" }, { - "prediction": "I'm not sure what you're trying to do here. I think you want to be able to call `StartBatch` and `CommitBatch` on the `IKeyValueStoreWithBatching` interface, but not on the `IKeyValueStore` interface.", + "prediction": "I don't think this is needed anymore.", "reference": "Unused code deletion. Is that a desired thing? No implementation of this actually used this indexer, so removing it seemed reasonable (and was suggested by the compiler). Maybe this had an indexer so plugins could use it? This change is definitely pushing the limits of what is appropriate in a \"cleanup\" as it is changing public API surface area." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to dump the logs of the puppet server, but you're also trying to dump the logs of the puppet server, but you're also trying to dump the logs of the puppet server, but you're also trying to dump the logs of the puppet server, but you're also trying to dump the logs of the puppet server, but you're also trying to dump the logs of the puppet server, but you're also trying to dump the logs of the puppet server, but you're also trying to dump the logs of the puppet server, but you're also trying to dump the logs of the puppet server, but you're also trying to dump the logs of the puppet server, but you're also trying to dump the logs of the puppet server, but you're also trying to dump the logs of the puppet server, but you're also trying to dump the logs of the puppet server, but you're also trying to dump the logs of the puppet server, but you're also trying to dump the logs of the puppet server, but you're also trying to dump the logs of the puppet server, but you're also trying to dump the logs of the puppet server, but you're also", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a `before` block, so that we don't have to call `dump_puppet_log` every time we run a test.", "reference": "We'd lose the data here from the original teardown_exception and only get the dump_exception - I fear that that could make the actual error difficult to track if it cascades." }, { - "prediction": "I think it's better to use `diffProps` instead of `diffChildren` in this case.", + "prediction": "I think it's better to use `isSvg` in this case.", "reference": "At this point in `diff()` we should know if we're dealing with a `component` or a native `html` element. We can reuse that information in this if-statement here :+1:" }, { - "prediction": "I'm not sure what you mean by `a.foundationBonusP2StartEpoch` and `a.foundationBonusP2EndEpoch`", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `GrantEpochReward` function as well.", "reference": "somewhere in reward protocol, we need to do if epoch is Fairbank { a.foundationBonusP2StartEpoch = genesis.xxx a.foundationBonusP2EndEpoch = genesis.yyy p.state(sm, adminKey, &a) } that is to write the 2 new values at Fairbank height then this logic can follow" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to drop and recreate the CloudAssetInventory table.", + "prediction": "I'm not sure why we need to drop and recreate the table here. I think we can just drop the table and recreate it.", "reference": "Dropping and recreating would delete all t he previous records, are they any important?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to make sure the paths exist before trying to access them.", + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", "reference": "While it is technically OK to use `m.GetPaths()` here, and it's a mock code so it doesn't really matter, I'd still like to have `m.Path(\"devices\")` used here, because since commit 714c91e9f73a1512808476eb532b4aa36bbb7530 we're not supposed to use GetPaths() for anything other than state save/restore." }, { @@ -16419,15 +16419,15 @@ "reference": "Let's be consistent everywhere: either \"Disable\"/\"Enable\" or \"Disabled\"/\"Enabled\". I'm voting for the latter.:)" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `DefaultCommandValues` class so that it can be used by other commands as well.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `DefaultCommandValues` class, since it's not part of the `DefaultCommand` class.", "reference": "this works and is the smallest possible change but we could definitely fail earlier" }, { - "prediction": "I'm not sure if this is a good idea or not, but I think we should remove the `!arm64` constraint.", + "prediction": "I think this should be `arm64` instead of `!arm64`.", "reference": "Should not have snuck in here right? This is a golang 1.17 feature, wii definitely want to update these" }, { - "prediction": "I'm not sure what you're trying to do with this. I think you're trying to force an update to the notes list when the app state changes, but I'm not sure what you're trying to do with this. I think you're trying to force an update to the notes list when the app state changes, but I'm not sure what you're trying to do with this. I think you're trying to force an update to the notes list when the app state changes, but I'm not sure what you're trying to do with this. I think you're trying to force an update to the notes list when the app state changes, but I'm not sure what you're trying to do with this. I think you're trying to force an update to the notes list when the app state changes, but I'm not sure what you're trying to do with this. I think you're trying to force an update to the notes list when the app state changes, but I'm not sure what you're trying to do with this. I think you're trying to force an update to the notes list when the app state changes, but I'm not sure what you're trying to do with this. I think you're trying to force an update to the notes", + "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.", "reference": "Could you explain the logic with prevFolderId?" }, { @@ -16443,11 +16443,11 @@ "reference": "We should probably make a unique_ptr typedef in ROMol.h and start using that liberally." }, { - "prediction": "I think it's a good idea to have a default value for this, so that if the user doesn't specify it, it defaults to `true`.", + "prediction": "I think it's better to use `autoInsertRow: false` instead of `fillHandle: true`.", "reference": "Can you add missing asterisk?" }, { - "prediction": "I think this should be `toLowerCamelAndDigits()` instead of `toUpperCamelAndDigits()`.", + "prediction": "I'm not sure what you're trying to achieve with this method, but it looks like you're trying to capitalize the first letter of each word in a camelCase string. If that's the case, you can use the `capitalizeDigitsAfterNumbers` method to achieve that.", "reference": "late to the party, but I bet it meant to be `capitalizeLettersAfterNumbers` :)" }, { @@ -16455,19 +16455,19 @@ "reference": "The Activity is recreated on configuration changes and the value of the field is lost. So, e.g. pressing 'send' once will display the error message. If you rotate the device and press 'send' again, the message will show another time. Use `onSaveInstanceState()` and `onRetainInstanceState()` to save and restore the value of the field." }, { - "prediction": "I think it's better to create a new context and pass it to the `setOpts` method. This way, we don't have to create a new context every time we want to apply the new options.", + "prediction": "I think it's better to create a new context and pass it to `setOpts` instead of using `reloadContext`.", "reference": "Looks like a \"find and replace\" unintended change here" }, { - "prediction": "I think this should be `if (not self.learningMode) and (self._sfdr.getIterationLearnNum() == 0):`", + "prediction": "I think this should be `self._sfdr.stripUnlearnedColumns(outputVector)` instead of `self._sfdr.compute(inputVector, self.learningMode, outputVector, False)`.", "reference": "haven't we got rid off `randomSP` recently? (I think `not learn` implied that)" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to add a new field to the `ChaosInstance` struct, but I'm not sure if that's the best way to do it.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it would be better to use `string(in.GetStatus().Experiment.Phase)` instead of `string(in.GetStatus().Experiment.Phase).Experiment.Phase`.", "reference": "Why we need use `in.GetStatus()` function here? Can we use `in.Status.xxxx` directly?" }, { - "prediction": "I'm not sure what you mean by \"lack of error is by intention to force cache invalidation as though it has renewed\"", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to force the cache invalidation, but I don't think that's what you want to do. If you want to force the cache invalidation, you need to call `cert.Config.RenewCert(allowPrompts)` and then call `cert.Config.CacheInvalid()` to force the cache invalidation.", "reference": "@cretz Just a thought: what if another renewal process updates the certificate between the beginning of this for loop (above on line 67) and actually calling RenewCert? Even though we have a read lock on the certCache, something else could have renewed it by now, and finished, which would cause this certificate to be renewed twice. Could you double-check my thinking here and see if that's a plausible 'race' condition? I wonder if the lock needs to be put over this whole function. (It's still early here; I could be wrong...)" }, { @@ -16475,11 +16475,11 @@ "reference": "We don't need this for the PInvoke?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate function for this. It would be nice to be able to do something like `ds.GenericDeploymentConfig.DeploymentNotification.Mentions = []string{event.String()}` instead of `ds.GenericDeploymentConfig.DeploymentNotification.Mentions = []string{event.String(), event.String()}`.", + "prediction": "I don't think we need to do this, we can just use `ds.GenericDeploymentConfig.DeploymentNotification.Mentions[0].Slack`", "reference": "nits, I think add a log (using s.logger) to show why does this return with no error is better." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the piped belongs to the project. If it doesn't, we should return a 404 error.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if `pid` is `nil` or `projectID` is `nil`. If it's `nil`, we should return an error. If it's not `nil`, we should return an error if `pid` is not equal to `projectID`. If it's `nil`, we should return an error if `pid` is not equal to `projectID`. If it's `nil`, we should return an error if `pid` is not equal to `projectID`. If it's `nil`, we should return an error if `pid` is not equal to `projectID`. If it's `nil`, we should return an error if `pid` is not equal to `projectID`. If it's `nil`, we should return an error if `pid` is not equal to `projectID`. If it's `nil`, we should return an error if `pid` is not equal to `projectID`. If it's `nil`, we should return an error if `pid` is not equal to `projectID`. If it's `nil`, we should return an error if `pid`", "reference": "Btw, It would be nice if we have some tests for those validation functions." }, { @@ -16487,55 +16487,55 @@ "reference": "Should this be called something that indicates its function, rather than its content? validationMessagePrefix, or similar?" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a separate file for this.", + "prediction": "I don't think this is necessary.", "reference": "Please remove this line" }, { - "prediction": "I'm not sure what you mean by \"Not run the daemon\". I think you meant to say \"Don't run the client\".", + "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to add this option to the command line parser. I think it's a good idea to add this option to the command line parser. I think it's a good idea to add this option to the command line parser. I think it's a good idea to add this option to the command line parser. I think it's a good idea to add this option to the command line parser. I think it's a good idea to add this option to the command line parser. I think it's a good idea to add this option to the command line parser. I think it's a good idea to add this option to the command line parser. I think it's a good idea to add this option to the command line parser. I think it's a good idea to add this option to the command line parser. I think it's a good idea to add this option to the command line parser. I think it's a good idea to add this option to the command line parser. I think it's a good idea to add this option to the command line parser. I think it's a good idea to add this option to the command line parser. I think it's", "reference": "You could change the name of the command line switch too. Short options are typically one character after hyphen. wxWidgets' command line parser seems to handle `-nd` without confusing it with `-n` or `-d` but I'm not sure if that's by design or by accident. I'd remove the short option. `--no-daemon` is with hyphen but the rest of Manager and client uses underscore. Please change that." }, { - "prediction": "I'm not sure if this is the right place to add this flag, but I think it's a good idea to add it.", + "prediction": "I'm not sure if this is the right place to add this flag, but I think it's a good idea to add it to the `fs.Config` struct.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { - "prediction": "I'm not sure what you mean by \"tdnf error (will continue if the only errors are toybox conflicts)\". I think you meant \"tdnf error (will continue if the only errors are package conflicts)\".", + "prediction": "I'm not sure what you mean by \"tdnf error (will continue if the only errors are toybox conflicts)\". I think you meant \"tdnf error (will continue if the only errors are package conflicts)\" or \"tdnf error (will continue if the only errors are package conflicts)\"?", "reference": "Why are we mentioning toybox in this message? AND it still says \"tdnf error\". What's the actual error? Should it be resolved instead of flagged?" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `MongoStream` test.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a `MongoStreamClosedError` to the `MongoStream` class.", "reference": "You can remove these if they've been resolved in NODE-3405 and this isn't depending on it" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `class` attribute on the `h4` tag.", + "prediction": "I don't think we need to use the `class='pull-right'` class here. We can just use `class='btn btn-default'` instead.", "reference": "don't need the class here if its empty" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `computed('i18n', () => { return t('appointments.searchTitle'); })` instead of `computed('i18n', () => { return t('appointments.searchTitle'); })`.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `computed('i18n', () => { return t('appointments.searchTitle'); })` instead of `computed('i18n', () => { return t('appointments.searchTitle'); })`", "reference": "This should be computed('i18n.locale'...." }, { - "prediction": "I think this should be `if status['status']['state'] == 'DONE'` instead of `if status['status'].get('errorResult')`.", + "prediction": "I think we can remove the `if status['status']['state'] == 'DONE'` check.", "reference": "Please add return and return type description to docstring of this method." }, { - "prediction": "I think this should be `@contributor` instead of `@project.best_analysis_id`.", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to find a contributor based on the `id` of the contribution. I'm not sure what you're trying to do here, but it looks like you're trying to find a contributor based on the `id` of the contribution. I'm not sure what you're trying to do here, but it looks like you're trying to find a contributor based on the `id` of the contribution. I'm not sure what you're trying to do here, but it looks like you're trying to find a contributor based on the `id` of the contribution. I'm not sure what you're trying to do here, but it looks like you're trying to find a contributor based on the `id` of the contribution. I'm not sure what you're trying to do here, but it looks like you're trying to find a contributor based on the `id` of the contribution. I'm not sure what you're trying to do here, but it looks like you're trying to find a contributor based on the `id` of the contribution. I'm not sure what you're trying to do here, but it looks like you're trying to find a contributor based on", "reference": "What does 1 << 32 do? In irb typing this yields 4294967296. I didn't find the append operator in Numeric or Integer." }, { - "prediction": "I'm not sure what you're trying to do here. The `succeeded?` method should be called on the `example` object, not on the `RSpec::CoreExample` class itself.", + "prediction": "I'm not sure what you're trying to do here. The `succeeded?` method is just a convenience method for getting the success status of the example.", "reference": "We generally use metadata for this sort of thing, indeed there is a `metadata[:execution_result]`." }, { - "prediction": "I think this should be `element.dimension_values(1)` instead of `element.dimension_values(0)`.", + "prediction": "I think this should be `self._stream_data = True` instead of `self._stream_data = False`", "reference": "This was very confusing until I realized this might refer to the *bokeh* use of the word 'streaming'." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to lock the map.", + "prediction": "I don't think we need to use a mutex here. We can just use a lock on `tasksToEvents` and `tasksToEventsLock`.", "reference": "Can you rename this as `tasksToContainerStates` ? If you do that, you can rename the lock as well" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to get the first account in the list, but you're returning `null`.", + "prediction": "I'm not sure if this is a good place to put it, but I think we should move it to the `AccountManager` class, since it's not related to the `UserAccountManager` class.", "reference": "Fixing `lint` warnings that have existed for a while." }, { @@ -16543,7 +16543,7 @@ "reference": "An iterator **of {\\@code n} sequential elements,** where each element ~are~ **is the** given {\\@code element}." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to get rid of the `IntegrationIds.AdoNet` constant. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get rid of the `IntegrationIds.AdoNet` constant. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get rid of the `IntegrationIds.AdoNet` constant. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get rid of the `IntegrationIds.AdoNet` constant. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get rid of the `IntegrationIds.AdoNet` constant. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get rid of the `IntegrationIds.AdoNet` constant. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get rid of the `IntegrationIds.AdoNet` constant. I'm not sure what you're trying to achieve with this, but it looks like you", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use the same name as the `IntegrationIds` struct.", "reference": "If all of the `SqlCommandIntegrationName` values are the same, can we just remove it from `IAdoNetClientData` entirely and put the constant there?" }, { @@ -16551,35 +16551,35 @@ "reference": "Maybe regroup this import with the other cert-manager packages." }, { - "prediction": "I think it's a good idea to have a default value for `R.style.Theme_AntennaPod_Dark_NoTitle` and `R.style.Theme_AntennaPod_TrueBlack_NoTitle`.", + "prediction": "I don't think we need to do this.", "reference": "There are spaces missing ;) Just have a look at the code style of the `if` statement above" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function to do this.", + "prediction": "I'm not sure if this is the best place to do this, but I think it's a good place to do this. I think it's a good place to do this, but I'm not sure if this is the best place to do this. I think it's a good place to do this, but I'm not sure if this is the best place to do this. I think it's a good place to do this, but I'm not sure if this is the best place to do this. I think it's a good place to do this, but I'm not sure if this is the best place to do this. I think it's a good place to do this, but I'm not sure if this is the best place to do this. I think it's a good place to do this, but I'm not sure if this is the best place to do this. I think it's a good place to do this, but I'm not sure if this is the best place to do this. I think it's a good place to do this, but I'm not sure if this is the best place to do this. I think it's a good place to do this, but I'm not sure if this is the best place", "reference": "We should pass the size limit as a parameter to Drain so that we don't take messages out of the pool and then drop them. It's ok to merge as is, I will file an issue." }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place", + "prediction": "I think this should be `len = (int)(nxt_pc - pc) + AARCH64_INSTR_SIZE;`", "reference": "Patch lists are used in many places so this is going to break other updates. This should just be a local change in emit_special_ibl_xfer() to pass the second-to-last instruction instead of the last instruction." }, { - "prediction": "I think it's better to use `R\"%%%` instead of `R\"%%%\"`", + "prediction": "I think it's better to use a `const char *` for the `test_genesis_data` instead of a `char const *`.", "reference": "@argakiig previous work was above live threshold, causing the high difficulty to bleed into other blocks when genesis open was processed in tests." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to remove the discount percentage and discount title from the products table, but I'm not sure what you're trying to do with the `:discount_percentage` and `:discount_title` columns. I'm not sure what you're trying to do with the `:discount_percentage` and `:discount_title` columns. I'm not sure what you're trying to do with the `:discount_percentage` and `:discount_title` columns. I'm not sure what you're trying to do with the `:discount_percentage` and `:discount_title` columns. I'm not sure what you're trying to do with the `:discount_percentage` and `:discount_title` columns. I'm not sure what you're trying to do with the `:discount_percentage` and `:discount_title` columns. I'm not sure what you're trying to do with the `:discount_percentage` and `:discount_title` columns. I'm not sure what you're trying to do with the `:discount_percentage` and `:discount_title` columns. I'm not sure what you're trying to do with the `:discount_percentage` and `:discount_title` columns.", + "prediction": "I don't think we need to remove discount percentage and discount title from products. I think we can just remove discount_percentage and discount_title from products.", "reference": "Metrics/LineLength: Line is too long. [89/80]" }, { - "prediction": "I don't think we need this field. It's not used anywhere in the code.", + "prediction": "I don't think this is necessary.", "reference": "Please also extend the config tests now to include the new field." }, { - "prediction": "I don't think this is a good idea. It would be better to use the `JsonAttribute` class instead of the `JsonLayout` class. The `JsonLayout` class is just a wrapper for the `JsonAttribute` class, so it would be better to use the `JsonAttribute` class instead of the `JsonLayout` class.", + "prediction": "I don't think this is a good idea. I think it's better to use `JsonAttribute` instead of `JsonLayout`.", "reference": "I think it's wise to keep the behavior backwards-compatible (so `false` as default)" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don", + "prediction": "I don't think this is necessary.", "reference": "We don't need this line, do we?" }, { @@ -16587,27 +16587,27 @@ "reference": "I don't know if we've actually had this problem on Upcase. I'd lean towards having a blank file unless (like on robots) we see multiple errors per week from this crawler." }, { - "prediction": "I think it's better to use `wlr_render_quad` instead of `wlr_render_colored_quad`.", + "prediction": "I think this should be `color[0] = 0.09804; color[1] = 0.09804; color[2] = 0.43921;` instead of `color[0] = 0.2; color[1] = 0.2; color[2] = 0.43921;`", "reference": "I'm not good at picking colors, if anyone else has a preference." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `refreshFolders` method in the `FoldersScreenUtils` class.", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be good to move it to the top of the file.", "reference": "Note that even if you cancel the timer, the refreshFolders function might still be running since it's async. Could that be a problem for the test units? One big issue I had with tests is they sometimes would work and sometimes fail randomly, and that's because there are still code running in the background. One example was the ItemChange class, which saves data asynchronously. So I've implemented a waitForAllSaved(), which can be used for test units, to make sure nothing is running once the test ends. So just wondering if we might end up with this issue here." }, { - "prediction": "I think we can remove the `await` from the `it` statement.", + "prediction": "I think this should be `if (diagnostics.length === 0)` instead of `if (diagnostics.length !== 0)`.", "reference": "can we make this something more descriptive? like... types should compile? I'm still not sure exactly what this is testing... this says \"Exported types\" - but what does tsd actually look at?" }, { - "prediction": "I think we should remove `Arrays.asList(request.getResources()).contains(\"android.webkit.resource.VIDEO_CAPTURE\")` as it's not necessary.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `onPermissionRequest` method.", "reference": "this method is need for full screen video button to appear in players" }, { - "prediction": "I think we should use `*uint64` instead of `*int64` here.", + "prediction": "I don't understand what you mean by \"increment\" in this context.", "reference": "Why is this a pointer?" }, { - "prediction": "I don't think this is a good idea.", + "prediction": "I don't think we need to change the type here.", "reference": "nit: Space after comma" }, { @@ -16615,15 +16615,15 @@ "reference": "A similar field is already define in `scapy/layers/bluetooth.py`. Can you merge both definitions ?" }, { - "prediction": "I think we can remove the `std::strtok` call here.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `std::strtok` here instead of `std::strtok_r`.", "reference": "`std::strtok` isn't necessary. The `std::string::find_first_of` is better C++ alternative to `std::strtok`. For example, see `CheckedError Parser::ParseEnumFromString` method." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to have a `raw_line_number` field in the `DocblockTypeLocation` class.", + "prediction": "I'm not sure what you're trying to do here. The `raw_line_number` property is not used anywhere in this class. It's only used in the `__construct` method. I think you should remove it.", "reference": "This property is already declared in a parent with the same visibility/type/value. This one is redundant." }, { - "prediction": "I think this should be `sstdout, sstderr = sys.stdout, sys.stderr` instead of `sys.stdout, sys.stderr = sys.stdout, sys.stderr`", + "prediction": "I think this should be `flush` instead of `pass`", "reference": "This is required, otherwise multiprocessing will (for some reason) crash" }, { @@ -16631,15 +16631,15 @@ "reference": "Please put in a separate line-separated block" }, { - "prediction": "I'm not sure what you mean by \"Disconnect error: %s\"", + "prediction": "I don't think this is a good idea. We should be able to kill the server from the command line.", "reference": "Should error be eaten? If so, not clear why" }, { - "prediction": "I think this should be `if self.on_collection and self.resource_name == 'bucket'` instead of `if self.on_collection and self.resource_name == 'bucket' and self.force_empty_list`", + "prediction": "I think we should remove the `force_empty_list` argument. It's not needed anymore.", "reference": "This attribute is not defined if the condition is not met. Instead, you could define another RouteFactory (e.g. `BucketRouteFactory` with a class attribute like `allow_empty_list`)" }, { - "prediction": "I think we can remove the `WithClusterPoolReference` since it's not used anymore.", + "prediction": "I think we can remove the `WithClusterPoolReference` option as it's not needed anymore.", "reference": "Can we use the existing `InstalledTimestamp` function?" }, { @@ -16647,19 +16647,19 @@ "reference": "weird naming: `is` but `fields` (plural or singular ?) . If the method checks if the fragment has an invalid value, then \"hasInvalidValue\" or \"containsInvalidValue\" is fine no ?" }, { - "prediction": "I think this should be `db_conn = webserver.timescale_connection` instead of `webserver.timescale_connection._ts`", + "prediction": "I think this should be `webserver.timescale_connection` instead of `webserver.timescale_connection._ts`", "reference": "Does this mean that `listenbrainz.org/user/iliekcomputers` will start getting 404s?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to keep the `search_params_logic` in the `CatalogController` and not in the `Blacklight::Catalog` module.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this logic into the `CatalogController.search_params_logic` method. This way, we don't have to duplicate the logic in the `CatalogController.search_params_logic` method, and we can keep the logic in the `CatalogController.search_params_logic` method.", "reference": "Line is too long. [82/80]" }, { - "prediction": "I'm not sure what you mean by \"can filters\" in this context. Can you clarify?", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `async_select_unrequired = False` instead of `async_select_unrequired = True` in this case.", "reference": "That's a strange name =)" }, { - "prediction": "I'm not sure what you mean by \"custom templates\" in this context. I think you meant to say \"custom templates\" in the context of the `mail.body.encoded` string.", + "prediction": "I'm not sure what you're trying to do here. I don't think you want to use `mail.body.encoded` here. I think you want to use `mail.body.to_s` instead.", "reference": "Thoughts on this? I'm not crazy about the brittleness of this but haven't found a good way to test more generically that a specific (custom) template has been rendered." }, { @@ -16667,23 +16667,23 @@ "reference": "Have we reached binding-level agreement on the `subscribe` terminology? My only concern is that it doesn't seem descriptive enough and may be confused with subscribing for notifications." }, { - "prediction": "I think we can remove the `if l.SpanContext.IsValid()` check.", + "prediction": "I think it's better to use `if l != nil { ... }` instead of `if l != nil { s.addLink(l) }`", "reference": "would it not be safer to move this condition to the `addLink` method?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to explicitly flush the response body to the client before copying the streaming data. This way, the client will know that the response body is ready to be consumed.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's important to flush the response body before closing it.", "reference": "I think this might read better: > some apps need the response headers before starting to stream content with http2, so it's important to explicitly flush the headers to the client before streaming the data." }, { - "prediction": "I think this should be `PartitionSpec` instead of `StructLike`.", + "prediction": "I don't think this is needed. The `PartitionSpec` is the same as the `FileScanTask`'s `spec()`, so we don't need to create a new `PartitionSpec` here.", "reference": "What does this return if there is no partition? I think that we should consider adding a struct type that describes this tuple. That way, we can use an empty struct for unpartitioned and a non-empty struct for tasks that are combined by partition. We could also support more combinations, like combining across day partitions by not across bucket partitions or similar." }, { - "prediction": "I think this should be `libkbfs.NoSuchNameError` instead of `libkb.RepoDoesntExistError`?", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate error type for this case.", "reference": "Also, it might be worth returning this for the above lookup on `kbfsRepoDir` as well, which could happen if someone tries to delete a repo in a TLF that has never had any repos at all." }, { - "prediction": "I think we can remove this flag now, as it's not used anymore.", + "prediction": "I think we can remove this flag and use the `tequilapi.allowed-hostnames` flag instead.", "reference": "Can this be `Hidden: true` as we already have a bunch of flags that are printed on `--help` and this seems like an average person should not care about it." }, { @@ -16691,27 +16691,27 @@ "reference": "Wouldn't this set $strictVariables = true when Config::get returns false?" }, { - "prediction": "I don't think this is a good idea. The `DocumentBuilderFactory` should be replaced with `DocumentBuilder` and the `DocumentBuilder` should be replaced with `org.w3c.dom.Document`.", + "prediction": "I don't think this is a good idea. It's not a good idea to change the `org.xml.sax.InputSource` to `org.xml.sax.InputSource` and then change the `org.xml.sax.ErrorHandler` to `org.xml.sax.ErrorHandler` and then change the `org.xml.sax.ErrorHandler` to `org.xml.sax.ErrorHandler` and then change the `org.xml.sax.ErrorHandler` to `org.xml.sax.ErrorHandler` and then change the `org.xml.sax.ErrorHandler` to `org.xml.sax.ErrorHandler` and then change the `org.xml.sax.ErrorHandler` to `org.xml.sax.ErrorHandler` and then change the `org.xml.sax.ErrorHandler` to `org.xml.sax.ErrorHandler` and then change the `org.xml.sax.ErrorHandler` to `org.xml.sax.ErrorHandler` and then change the `org.xml.sax.ErrorHandler` to `org.xml.sax.ErrorHandler` and then change the `org.xml.sax.ErrorHandler` to `org.xml.sax.ErrorHandler` and then change the `org.xml.sax.ErrorHandler` to `org.xml.sax.ErrorHandler` and then change the `org.xml.sax.ErrorHandler` to `org.xml.sax.ErrorHandler` and then change the `org.xml.sax.ErrorHandler` to `", "reference": "was this meant to be checked in?" }, { - "prediction": "I'm not sure what the point of this is, but I think it's a good idea to have a default value for `DEFAULT_RTT_MEASUREMENT_INTERVAL` so that we don't have to specify it every time we want to measure RTT.", + "prediction": "I think it's a good idea to have a default value for `DEFAULT_RTT_MEASUREMENT_INTERVAL` instead of hardcoding it to `time.Hour`.", "reference": "check spaces after const name..." }, { - "prediction": "I think it's better to use `appendNameOnlyAttribute` instead of `appendNameOnlyAttributeWithPrefix` in this case.", + "prediction": "I think it's better to use `agent.resourceFields.NvidiaGPUManager.GetDriverVersion()` instead of `agent.resourceFields.NvidiaGPUManager.GetDriverVersionInfix()`.", "reference": "If the GPU setting is enabled, resourceFields.NvidiaGPUManager will be nil, right?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a `--help` option to the `run_command` and `run_script` commands.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `file_exist?` method to check for the existence of the script.", "reference": "We should probably verify that it's readable too" }, { - "prediction": "I think this should be `readerMoved = false;` instead of `readerMoved = true;`", + "prediction": "I think this should be `string value = xmlReader.ReadElementContentAsString();` instead of `string value = xmlReader.ReadElementContentAsString(); throw new InvalidDataException(\"Expected key value before dictionary data.\");` I think this should be `string value = xmlReader.ReadElementContentAsString();` instead of `string value = xmlReader.ReadElementContentAsString(); throw new InvalidDataException(\"Expected key value before dictionary data.\");` I think this should be `string value = xmlReader.ReadElementContentAsString();` instead of `string value = xmlReader.ReadElementContentAsString(); throw new InvalidDataException(\"Expected key value before dictionary data.\");` I think this should be `string value = xmlReader.ReadElementContentAsString();` instead of `string value = xmlReader.ReadElementContentAsString(); throw new InvalidDataException(\"Expected key value before dictionary data.\");` I think this should be `string value = xmlReader.ReadElementContentAsString();` instead of `string value = xmlReader.ReadElementContentAsString(); throw new InvalidDataException(\"Expected key value before dictionary data.\");` I think this should be `string value = xmlReader.ReadElementContentAsString();` instead of `string value = xmlReader.ReadElementContentAsString(); throw new InvalidDataException(\"", "reference": "See, here's an example where you removed the variable but kept the call, which makes sense." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `FeedParserTask` class, so that it can be used in other places as well.", + "prediction": "I think we should remove the `request.isInitiatedByUser()` call here.", "reference": "Please use `request.getTitle()` instead of `feed.getHumanReadableIdentifier()`: In this case, `feed` does not have a human readable title yet" }, { @@ -16727,11 +16727,11 @@ "reference": "Is this case purely hypothetical or did it solve an issue that occurred in your testing? I'm trying to understand this change a little better" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to do this in a single call to `putReplicationTaskToDLQ` instead of two separate calls to `putReplicationTaskToDLQ` and `putReplicationTaskToDLQ`. This way we don't need to call `putReplicationTaskToDLQ` twice.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `instanceTag` instead of the `shardID` in the `putReplicationTaskToDLQ` method.", "reference": "Use instead `convert.Int32ToString` that was added in #762 for this purpose." }, { - "prediction": "I think this should be `contains` instead of `add`.", + "prediction": "I think we should remove the `contains` method. It's not needed anymore.", "reference": "If key is present, tree.put(k,v) needs to return a new instance for Maps and the same instance for Sets. Therefore we currently perform an additional 'contains' check for Sets. A future optimization may add an additional flag `replace` to the backing HAMT.put() / RedBlackTree.insert() methods. Sets set it to replace=false, Maps set it to replace=true. But for now this solution is working for us." }, { @@ -16739,7 +16739,7 @@ "reference": "This is a regression test for code I found while working on this." }, { - "prediction": "I think this should be `ret = json_extract_path_text(&rltStr, op_data[1], 1, op_data[2]);` instead of `ret = json_extract_path_text(&rltStr, op_data[1], 1, op_data[2]);`", + "prediction": "I think we should use `json_extract_path_text` instead of `trimFillerSpaces` here.", "reference": "I'm wondering if we need to delete jsonStr and jsonAttr after the json_extract_path_text call to avoid unnecessary heap pressure. Though if json_extract_path_text itself does new's on the same heap, we'd get heap fragmentation. Another approach would be to allocate these on the stack instead, avoiding both concerns: char jsonStr[len1+1]; char jsonAttr[len2+1]; ..." }, { @@ -16747,39 +16747,39 @@ "reference": "Does it come as `str`?" }, { - "prediction": "I don't think you need to add `||` here.", + "prediction": "I don't think you need to add `i <= allergens.size() - 1` here. You can just do `for (int i = 0; i < allergens.size() - 1; i++)`.", "reference": "This should actually read as the following `for (int i = 0; i < allergens.size(); i++)`" }, { - "prediction": "I'm not sure what you mean by `semantic.Bool`", + "prediction": "I'm not sure what you mean by `semantic.Bool`. I think it should be `bool` instead of `semantic`.", "reference": "This is so useful and safety, I want to propose making AppendBool, AppendInt, etc. all private functions, and forcing us to use AppendValue(j, values.New(false)), etc." }, { - "prediction": "I'm not sure what you mean by \"argsChanged\" in this context. It's not clear to me what you're trying to do here.", + "prediction": "I'm not sure if this is a good place to put it, but I think it would be better to move it to `useImperativeHandle`'s `ref.current` property.", "reference": "Really, really small nit I believe there's 3x tabs in here? And should it be just 2x?" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the AWS S3 Transfer Acceleration section.", + "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea to add it to the AWS S3 Transfer Acceleration section.", "reference": "Perhaps note that rclone can't do this yet?" }, { - "prediction": "I think this should be `RoundTripper` instead of `http3.RoundTripper`.", + "prediction": "I think this should be `net/http3.RoundTripper` instead of `http3.RoundTripper`.", "reference": "You probably don't need to set an empty config here." }, { - "prediction": "I think this should be `util.datetime_types` instead of `cftime_types`", + "prediction": "I think this should be `cftime._cftime.DatetimeNoLeap` instead of `cftime._cftime.DatetimeProlepticGregorian`", "reference": "I think you are missing `cftime.DatetimeAllLeap` here. That said, all of these are subclasses of `cftime.datetime`, so I think you could get away with just using `cftime.datetime` here, rather than enumerating all of the different subclasses (since `cftime_types` is only used for instance checks)." }, { - "prediction": "I don't think we need to use `CasPoolKey` here. We can just use `CStorPoolClusterCPK` and `CStorPoolInstanceCPK`.", + "prediction": "I think it's better to use `CStorPoolInstanceCPK` and `PredecessorBlockDeviceCPK` instead of `CStorPoolClusterCPK` and `PredecessorBlockDeviceCPK`.", "reference": "don't we need to set this label on pool pods? I don't see them being set" }, { - "prediction": "I'm not sure what you mean by \"not implemented for CPU\". It's not that the method is not implemented for CPU, it's that it's not implemented for GPU.", + "prediction": "I'm not sure if this is the right place to throw an error here, but I think it's a good idea to throw an error here, since the method is not implemented for CPU.", "reference": "can remove, it isn't reachable." }, { - "prediction": "I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure", + "prediction": "I'm not sure what you're trying to do here. I don't think this is the right way to do it.", "reference": "`expect(cancellation).to be_can_downgrade_instead` would be preferred :rainbow: :rainbow:" }, { @@ -16787,11 +16787,11 @@ "reference": "Gross. The OS should timeout writes for completely unresponsive clients to begin with. Long term, the better solution is to enforce a minimum minimum data rate for responses. This might require a way to cancel LibuvAwaitables, but it definitely not OK to immediately kill the socket and any ongoing writes just because the request processing loop completed. You could consider doing that after some kind of timeout, but at that point you might as well just enforce a minimum rate." }, { - "prediction": "I think this should be `std::uniform_int_distribution dist(0, 1);` instead of `std::uniform_int_distribution dist(0, 100);`", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to call `get_fast_generator()` here.", "reference": "If this is not used, we should just delete the line." }, { - "prediction": "I'm not sure what you mean by \"transporting shell-style streams\". I think you meant to say \"executing shell-style streams\".", + "prediction": "I'm not sure what you mean by \"transporting shell-style streams\". I think you meant to say \"executing shell-style streams\" or \"executing shell commands\".", "reference": "Are there other callers to this function. How will they be impacted." }, { @@ -16799,7 +16799,7 @@ "reference": "Let's be consistent. The majority of boto code does not use relative imports. Let's just stick to the existing standard of \"from boto.package.subpackage import Thing\"." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to add a `--p2p-enabled` option to the Besu command. This will allow the user to disable P2P within Besu if they want to.", + "prediction": "I'm not sure if this is the right place to put this, but I think it would be a good idea to add a `--p2p-enabled` option to Besu.", "reference": "Suggestion: specify `arity` for this option." }, { @@ -16807,7 +16807,7 @@ "reference": "This is a parameter available for the matplotlib backend IIRC. In which case, it is good to see this support added to the Bokeh backend." }, { - "prediction": "I think this should be `validateHexAndReturnZeroPrefix` instead of `validateHexAndReturnZeroPrefixAndReturnZeroPrefix`", + "prediction": "I think this should be `if (length > 32) throw new IllegalArgumentException(\"traceId.length > 32\");`", "reference": "trim has performance impact and this is the lowest level library... seems the trim if occurs should happen in the UI or Query controller instead.." }, { @@ -16815,15 +16815,15 @@ "reference": "Probably also needed for the `http.client.FOUND` below?" }, { - "prediction": "I think it's better to use `--es6-js-export` instead of `--go-namespace` and `--go-import` because `--es6-js-export` is more specific than `--go-namespace` and `--go-import`.", + "prediction": "I think it's better to use `--es6-js-export` and `--go-import` instead of `--no-js-exports` and `--es6-js-export` and `--go-import`.", "reference": "Can you also add this to Compiler.md ?" }, { - "prediction": "I'm not sure what you're trying to do with `opt_proxy` and `retries`.", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to call `sendRequest` with `onOk`, `onError`, `opt_data`, and `opt_proxy` as arguments. I'm not sure what you're trying to do here, but it looks like you're trying to call `sendRequest` with `onOk`, `onError`, `opt_data`, and `opt_proxy` as arguments. I'm not sure what you're trying to do here, but it looks like you're trying to call `sendRequest` with `onOk`, `onError`, `opt_data`, and `opt_proxy` as arguments. I'm not sure what you're trying to do here, but it looks like you're trying to call `sendRequest` with `onOk`, `onError`, `opt_data`, and `opt_proxy` as arguments. I'm not sure what you're trying to do here, but it looks like you're trying to call `sendRequest` with `onOk`, `onError`, `opt_data`, and `opt_proxy` as arguments. I'm not sure what you're trying to do here, but it looks like you're trying to call `sendRequest` with", "reference": "!numbers -> numbers" }, { - "prediction": "I'm not sure what you mean by \"baseline test\". It's not a test, it's an example. I'm not sure what you mean by \"baseline test\". It's not a test, it's an example. I'm not sure what you mean by \"baseline test\". It's not a test, it's an example. I'm not sure what you mean by \"baseline test\". It's not a test, it's an example. I'm not sure what you mean by \"baseline test\". It's not a test, it's an example. I'm not sure what you mean by \"baseline test\". It's not a test, it's an example. I'm not sure what you mean by \"baseline test\". It's not a test, it's an example. I'm not sure what you mean by \"baseline test\". It's not a test, it's an example. I'm not sure what you mean by \"baseline test\". It's not a test, it's an example. I'm not sure what you mean by \"baseline test\". It's not a test, it's an example. I'm not sure what you mean by \"baseline test\". It's not a test, it's an example. I'm not", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check to see if the package name is in the correct format. If it is not, then we should throw an exception.", "reference": "This description doesn't seem quite right for the longrunning case - `longrunning` isn't an orgname." }, { @@ -16831,27 +16831,27 @@ "reference": "maybe give it a more descriptive name, e.g. `competitiveFilter`" }, { - "prediction": "Shouldn't this be `issuerConfig.getHttpsJwksUrls()` instead of `issuerConfig.usesHttpsJwk()`?", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add this to the `JWKSResolver` class as well.", "reference": "This occurrence of \"master\" is unrelated to master/slave replication. Maybe simply remove the word \"master\" or replace it with \"reference\" but \"primary\" doesn't really make sense." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add a comment explaining what the change does.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a `miners` field to the `miner` struct.", "reference": "BLOCKING: This is a problem. We shouldn't be introducing new dependencies on proofs into actors. The miner has some dependencies that should be removed (#2555). This could be accomplished either by moving `proofs.Mode` to `types.ProofsMode` or by forgoing a new type altogether and replacing it with a boolean. The later would have the additional advantage of reducing the number of types we have to export through ABI. I get why `proofs.Mode` has value as a type over a boolean, but I'm not sure it's worth it here." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check to see if there are any messages that don't have a messageId.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to add a check to see if `ids` is empty. If it is, then we can just return early.", "reference": "We probably want to log the fact that a `MessageId` was not present in the response. In addition the `RequestID` from `request.Request` should be included in the message so that the user is aware of the issue." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `id` and `webPropertyId` in the `setupRegistryWithExistingTag` function. This way, we don't need to pass the `accountId` to the `setupRegistry` function, and we can use the `id` and `webPropertyId` directly in the `setupRegistryWithExistingTag` function.", "reference": "It feels a bit strange to re-assign that here, as that line itself has no context on why it's reassigned. I'd prefer if we could pass `{ propertyID: webPropertyId }` below instead (that's how we do that elsewhere too). This also applies to other similar re-assignments below - let's rather pass the values within the objects as applicable, since then there is more clear context on why this \"rename\" / \"reassignment\" is necessary (because of an object expecting specific properties)." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to include the `countly.compare.models.js` in the `frontend/express/public/core/user-management/javascripts/countly.compare.models.js` as well.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to include the `countly.compare.models.js` and `countly.overview.models.js` in the `frontend/express/public/core/user-management/javascripts/countly.models.js` and `frontend/express/public/core/user-management/javascripts/countly.overview.models.js` files.", "reference": "remove this in the new pr aswell when moving compare to plugins as discussed." }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. It's not a bad place to put it, but I'm not sure if this is a good place to put it. It's not a bad place to put it, but I'm not sure if this is a good place to put it. It's not a bad place to put it, but I'm not sure if this is a good place to put it. It's not a bad place to put it, but I'm not sure if this is a good place to put it. It's not a bad place to put it, but I'm not sure if this is a good place to put it. It's not a bad place to put it, but I'm not sure if this is a good place to put it. It's not a bad place to put it, but I'm not sure if this is a good place to put it. It's not a bad place to put it, but I'm not sure if this is a good place to put it. It's not a bad place to put it, but I'm not sure if this is a good place to put it. It's not a bad", + "prediction": "I don't think we need to check for `inputs` here, since it's already checked in `YieldClauseWrapper::prepare`.", "reference": "check varHolder is nullptr is redundant, ExecutionContext ensure" }, { @@ -16859,35 +16859,35 @@ "reference": "Make these frozen constants?" }, { - "prediction": "I think it's better to use `message.replace('<', '<')` and `message.replace('>', '>')` instead of `message.replace('<', '<')` and `message.replace('>', '>')`.", + "prediction": "I don't think this is necessary.", "reference": "Please use something like html.escape() to ensure that the text is totally safe to include within html. < is not enough." }, { - "prediction": "I'm not sure what you mean by \"maxSelects\" in this context. Is it the maximum number of peers that can be selected?", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use a channel of size 2.", "reference": "why is a buffered channel larger than 1 needed here? the separate goroutines can just try to write to the channel with a select-default block, and then it is not needed. i find the current implementation a bit convoluted, maybe we could simplify it a bit? not sure why it is needed for example to communicate an empty result. these patterns can be simplified using waitgroups" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new column to your schema. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new column to your schema. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new column to your schema. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new column to your schema. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new column to your schema. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new column to your schema. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new column to your schema. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new column to your schema. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new", + "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", "reference": "There seem to be more changes in here than I'd expect (mostly `limit: 255` additions)." }, { - "prediction": "I think we can remove the `TraceStateKeyVendorMaxLength` and `TraceStateKeyTenentMaxLength` as they are not used.", + "prediction": "I think this should be `TraceStateKeyVendorMaxLength` and `TraceStateKeyTenentMaxLength` instead of `TraceStateKeyMaxLength` and `TraceStateKeyTenentMaxLength`.", "reference": "I'm not sure, but I think it's `Tenant`" }, { - "prediction": "I'm not sure I understand what you're trying to do here. What is the purpose of the `allowOptionalMappings` parameter?", + "prediction": "I think this should be `Dictionary` instead of `IDictionary`.", "reference": "Not sure if it's an issue, but this is a breaking change in a public API. Maybe we should add as an overload without optional parameter instead and delegate the existing call to this one?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `transport` field in the `Outbound` struct. This way, we don't need to create a new struct every time we want to use the `Outbound` struct.", + "prediction": "I think it's better to use `o.chooser` instead of `o.chooser.Start` in this case.", "reference": "as opposed to exposing the chooser function and increasing our API exposure for the purpose of tests, can we move the HTTP transport config test into this package?" }, { - "prediction": "I think this should be `if (drmModeObjectSetProperty(conn->fd, conn->id, conn->props.dpms, level) < 0)` instead of `if (drmModeObjectSetProperty(drm->fd, conn->id, conn->props.dpms, level) < 0)`", + "prediction": "I think this should be `conn->props.dpms` instead of `conn->props.dpms`", "reference": "This is using the legacy DRM interface. DPMS levels have been removed from the atomic interface IIRC. Should we handle DPMS levels at all?" }, { - "prediction": "I think we can remove the `watch` field from the `potentiallyConfirmedWatches` function. It's not needed anymore.", + "prediction": "I think we can remove the `watch` field from the `potentiallyConfirmedWatches` function.", "reference": "I think this was correct before. The nonce passed in here is the nonce at a block (which is the next nonce not yet used, e.g. 0 if the account was never used, 1 if only the tx with nonce 0 has been sent). So if the in-block nonce is 12, then a transaction with nonce 12 cannot have been included yet." }, { @@ -16895,15 +16895,15 @@ "reference": "Please name the file ShareExtension.js, as you import it under this name (also could you convert it to TypeScript please?)" }, { - "prediction": "`tlsInsecure` should be `false` instead of `tls_insecure`", + "prediction": "I think it's better to use `tlsInsecure` instead of `tlsInsecure` in this case.", "reference": "Not sure if we need it, but if we set it, be sure to add `,omitempty`." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the length of a QUIC packet, but you're not actually using the `GetLength` method on the `PublicHeader` struct. I think you want to use the `GetLength` method on the `Raw` field of the `PublicHeader` struct, but I'm not sure what you're trying to achieve with this. Could you please provide more context on what you're trying to achieve with this?", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `quic` package.", "reference": "It's the whole `PublicHeader` that will change soon, and we should state that here, not in the member functions. If Jana's proposal for a new header is accepted, we might also want to rename the fields here. For example, there won't be a dedicated version flag anymore, so a more appropriate name might be `ContainsVersion` instead of `VersionFlag`." }, { - "prediction": "I'm not sure what you're trying to do here. The `indexOf` method returns the index of the first occurrence of the specified element in the sequence, or -1 if the element is not found. If you want to return the index of the last occurrence of the specified element, you can use the `lastIndexOf` method instead.", + "prediction": "I don't think this is necessary. The `indexOf` method in `IndexedSeq` already returns the index of the first occurrence of `element` in the sequence.", "reference": "I think `element` can stay of type `Character` because `Character` is a final class. The we do not need the cast in the line below." }, { @@ -16911,23 +16911,23 @@ "reference": "Not sure, if we should do it the other way round. If you ask be in the middle of the night, whether Interface should return true as \"isInterface\" and what Annotation would return. I'd tell you, Annotations should return false.... I want to say, on first glance, I'd say, it's easier to have \"isInterface\" and \"isAnnotation\" rather than \"isInterface\", \"isAnnotation\" and \"isRegularInterface\"... But I see, we also have \"isRegularClass\".... We still have the possibility to change the semantics of those APIs in PMD 7 *Update:* Or in other words: What is less surprising? That isInterface returns true for annotations or that it returns false?" }, { - "prediction": "I'm not sure what you mean by `terminate_after`. Is it something to do with the `terminate_after` parameter in the `search` action? If so, I'm not sure I understand what you're trying to do with it.", + "prediction": "I'm not sure what you mean by `terminate_after`. Is it something like `terminate_after=10`? I'm not sure what you mean by `terminate_after`. Is it something like `terminate_after=10`? I'm not sure what you mean by `terminate_after`. Is it something like `terminate_after=10`? I'm not sure what you mean by `terminate_after`. Is it something like `terminate_after=10`? I'm not sure what you mean by `terminate_after`. Is it something like `terminate_after=10`? I'm not sure what you mean by `terminate_after`. Is it something like `terminate_after=10`? I'm not sure what you mean by `terminate_after`. Is it something like `terminate_after=10`? I'm not sure what you mean by `terminate_after`. Is it something like `terminate_after=10`? I'm not sure what you mean by `terminate_after`. Is it something like `terminate_after=10`? I'm not sure what you mean by `terminate_after`. Is it something like `terminate_after=10`? I'm not sure what you mean by `terminate_after`. Is it something like", "reference": "This will potentially skip package results. Do we really want that?" }, { - "prediction": "I think we should remove the `CUDA_ERROR_NOT_PERMITTED` and `CUDA_ERROR_COOPERATIVE_LAUNCH_TOO_LARGE` from the list.", + "prediction": "I think this should be `CUDA_ERROR_NOT_PERMITTED` instead of `CUDA_ERROR_LAUNCH_FAILED`?", "reference": "Please remove `HIP_UNSUPPORTED`" }, { - "prediction": "I'm not sure what you mean by \"NewMutableStateStats\"", + "prediction": "I don't think this is needed.", "reference": "if this is a \"Status\" type then the variable name \"Stats\" (which implies \"statistics\") seems wrong (or at least confusing to me)" }, { - "prediction": "I'm not sure what you mean by \"leaked insecure key\". It's not an insecure key, it's a key that was leaked in the past.", + "prediction": "I don't think we need to change the `exportKeystorePath` to `/var/lib/sonm/worker_keystore`.", "reference": "maybe will be better to put it into the default worker's config rather than hardcoding the address?" }, { - "prediction": "I think this test is failing because the `skip` and `limit` options are not being passed to the `find` method.", + "prediction": "I think this test should be moved to the `shouldNotMutateUserOptions` test, since it's not related to the `shouldNotMutateUser` test.", "reference": "It seems like this is not meant to test the option failure, but rather that `raw` can be set. This may be a superfluous test now, and we might want to delete it." }, { @@ -16939,7 +16939,7 @@ "reference": "mmm I followed the convention of this collection. It has Add, Remove, RemoveAll, so All sounds reasonable. Else It would likely be AddPeer, RemovePeer, RemovePeers and Peers." }, { - "prediction": "I think this should be `getByIds` instead of `getByUuid`.", + "prediction": "I don't think we need this method anymore.", "reference": "_nitpick_ I'm thinking about whether this method should be in the previous commit or not. I know it's not yet used there, but in theory, neither do UUID itself." }, { @@ -16947,15 +16947,15 @@ "reference": "\"break\" is right? You skip the line 768." }, { - "prediction": "I'm not sure what you mean by `current_user.admin?` but I think it's better to use `current_user.admin?` instead of `current_user.admin? == true`.", + "prediction": "I'm not sure what you mean by \"you are not authorized to access that page\"", "reference": "Can this use the route helper instead?" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a `Server` struct that has a `Handler` and a `te` trace exporter. I'm not sure what you're trying to do here, but it looks like you're trying to create a `Server` struct that has a `Handler` and a `te` trace exporter. I'm not sure what you're trying to do here, but it looks like you're trying to create a `Server` struct that has a `Handler` and a `te` trace exporter. I'm not sure what you're trying to do here, but it looks like you're trying to create a `Server` struct that has a `Handler` and a `te` trace exporter. I'm not sure what you're trying to do here, but it looks like you're trying to create a `Server` struct that has a `Handler` and a `te` trace exporter. I'm not sure what you're trying to do here, but it looks like you're trying to create a `Server` struct that has a `Handler` and a `te` trace exporter. I'm not sure what you're trying to do here, but it looks like", + "prediction": "I'm not sure what you mean by \"zero value\" here. It's not a server, it's a handler.", "reference": "Why is this field exported and others aren't?" }, { - "prediction": "I'm not sure what you're trying to do with this file, but it looks like you're trying to add a new test file to the `test/functional` directory. I'm not sure what you're trying to do with this file, but it looks like you're trying to add a new test file to the `test/functional` directory. I'm not sure what you're trying to do with this file, but it looks like you're trying to add a new test file to the `test/functional` directory. I'm not sure what you're trying to do with this file, but it looks like you're trying to add a new test file to the `test/functional` directory. I'm not sure what you're trying to do with this file, but it looks like you're trying to add a new test file to the `test/functional` directory. I'm not sure what you're trying to do with this file, but it looks like you're trying to add a new test file to the `test/functional` directory. I'm not sure what you're trying to do with this file, but it looks like you're trying to add a new test file to the `test/functional` directory. I'm not sure", + "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do with this file.", "reference": "should we rename this like `mongodb_srv_tests.js`?" }, { @@ -16963,39 +16963,39 @@ "reference": "This should still have a value when there is no page title, e.g. just `__( 'Search Traffic Summary', 'google-site-kit' )`." }, { - "prediction": "I think this should be 3, not 2.", + "prediction": "I think this should be `MIN_NUM_SUB_SHARDS = 1` instead of `MIN_NUM_SUB_SHARDS = 2`.", "reference": "Oops.. meant to link to SplitOp here. I'll clean up in my next commit" }, { - "prediction": "I don't think this is needed anymore. We can just use `MaterialDialog.show()` instead.", + "prediction": "I don't think this is needed anymore.", "reference": "Remove these unnecessary imports that you've added." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `UrlType` enum in the `qutebrowser.utils.usertypes` module. This will make it easier to add new types in the future.", + "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea to add it to the `UrlType` enum. I think it's a good idea to add it to the `UrlType` enum. I think it's a good idea to add it to the `UrlType` enum. I think it's a good idea to add it to the `UrlType` enum. I think it's a good idea to add it to the `UrlType` enum. I think it's a good idea to add it to the `UrlType` enum. I think it's a good idea to add it to the `UrlType` enum. I think it's a good idea to add it to the `UrlType` enum. I think it's a good idea to add it to the `UrlType` enum. I think it's a good idea to add it to the `UrlType` enum. I think it's a good idea to add it to the `UrlType` enum. I think it's a good idea to add it to the `UrlType` enum. I think it's a good idea to add it to the `UrlType` enum. I think it's a good idea", "reference": "That space shouldn't be here :wink: This lead to an exception whenever a page with an error was loaded, e.g. an inexistent host - I just fixed that :smile:" }, { - "prediction": "I think this should be `self.remote_ip` and `self.remote_port` instead of `self.local_ip` and `self.local_port`.", + "prediction": "I think it's better to use `self.remote_ip` and `self.remote_port` instead of `self.local_ip` and `self.local_port`.", "reference": "It seems this is not the way to fix issue #505." }, { - "prediction": "I think this should be `weight_reduce_loss` instead of `weight_reduce_loss_with_pos_weight`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `forward` method of the `nn.Module` class.", "reference": "Please take a look at the docstring of `F.binary_cross_entropy_with_logits`. `weight` should be a tensor that matches the input tensor shape. It is Not the class-aware weight. `pos_weight` should be a vector with a length equal to the number of classes." }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it would be good to have a separate test suite for gcloud tests. I think it would be good to have a separate test suite for gcloud tests. I think it would be good to have a separate test suite for gcloud tests. I think it would be good to have a separate test suite for gcloud tests. I think it would be good to have a separate test suite for gcloud tests. I think it would be good to have a separate test suite for gcloud tests. I think it would be good to have a separate test suite for gcloud tests. I think it would be good to have a separate test suite for gcloud tests. I think it would be good to have a separate test suite for gcloud tests. I think it would be good to have a separate test suite for gcloud tests. I think it would be good to have a separate test suite for gcloud tests. I think it would be good to have a separate test suite for gcloud tests. I think it would be good to have a separate test suite for gcloud tests. I think it would be good to have a separate test suite for gcloud tests. I think it", + "prediction": "I don't think we need to change the order of these tests.", "reference": "Same here, merge with an existing test." }, { - "prediction": "I'm not sure what this is for, but it looks like it's a slot initialization template. I'm not sure what it's for, but it looks like it's a slot initialization template. I'm not sure what it's for, but it looks like it's a slot initialization template. I'm not sure what it's for, but it looks like it's a slot initialization template. I'm not sure what it's for, but it looks like it's a slot initialization template. I'm not sure what it's for, but it looks like it's a slot initialization template. I'm not sure what it's for, but it looks like it's a slot initialization template. I'm not sure what it's for, but it looks like it's a slot initialization template. I'm not sure what it's for, but it looks like it's a slot initialization template. I'm not sure what it's for, but it looks like it's a slot initialization template. I'm not sure what it's for, but it looks like it's a slot initialization template. I'm not sure what it's for, but it looks like it's a slot initialization template. I'm not sure what it's for, but it looks like it's a", + "prediction": "I don't think this is a good idea. I think it's better to have a slot init template for each slot. This way, we can have a slot init template for each slot, and we can have a slot init template for each slot, and we can have a slot init template for each slot, and we can have a slot init template for each slot, and we can have a slot init template for each slot, and we can have a slot init template for each slot, and we can have a slot init template for each slot, and we can have a slot init template for each slot, and we can have a slot init template for each slot, and we can have a slot init template for each slot, and we can have a slot init template for each slot, and we can have a slot init template for each slot, and we can have a slot init template for each slot, and we can have a slot init template for each slot, and we can have a slot init template for each slot, and we can have a slot init template for each slot, and we can have a slot init template for each slot, and we can have a slot init template for each slot, and we can have a slot init template for each slot, and", "reference": "@aimanrosli23 Could you help to confirm if you do not revert the change in below commit: SHA-1: 643623147a1feaddd734ddd84604e1d8e9dcebee * MdeModulePkg/SdMmcPciHcDxe: Send SEND_STATUS at lower frequency" }, { - "prediction": "I'm not sure what you mean by \"hasIds\" in this context. It's not clear to me what you're trying to do with this method.", + "prediction": "I think this should be `hasIds` instead of `hasId`s.", "reference": "Can we do this without a breaking API change? What about adding a different name to convert directly to a Schema?" }, { - "prediction": "I don't think we need to use `bluebird` here, we can just use `require('bluebird')` instead.", + "prediction": "I don't think we need to use `bluebird` here. We can just use `Promise` here.", "reference": "Why do we need to pull bluebird in here?" }, { @@ -17003,15 +17003,15 @@ "reference": "If *two* threads successfully download the same project into two different temp dirs, and one of them successfully renames one to its final destination, the `if`on line 102 will be false _in the other thread_, and it would leave its temp dir behind." }, { - "prediction": "I think we can remove the `h2o_linklist_t target_link;` since it's not used.", + "prediction": "I think we should remove the `target` field from the `pool_entry_t` struct.", "reference": "I would appreciate it if you could rename `link` to `all_link` so that the roles of the two links (the other is `target_link`) become clearer." }, { - "prediction": "I think we can remove the `smi.create_ConfigProfileTriggerCommand(t1, True, expectedToBecomeIndex=1)` and `smi.create_ConfigProfileTriggerCommand(t2, True, expectedToBecomeIndex=2)` tests.", + "prediction": "I think it's better to use `smi.create_ConfigProfileTriggerCommand(t1, True)` and `smi.create_ConfigProfileTriggerCommand(t2, True)` instead of `smi.create_ConfigProfileTriggerCommand(t1, True, expectedToBecomeIndex=1)` and `smi.create_ConfigProfileTriggerCommand(t2, True, expectedToBecomeIndex=2)`.", "reference": "Is there a reason not to use `smi.create_expectedIndex` here (and in other places)? The `smi.create_expectedIndex` function will also check to make sure that you don't accidentally skip or duplicate any indexes. With the goal of avoiding errors in the test. It does mean that you have to be diligent with how the expected indexes are created, which can be annoying too. My logic was that it is better to be annoyed by constraints during development time than to find out some time later that the test didn't do what I thought." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a Stripe customer for the user who created the checkout. Is that correct?", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the customer is created with the correct email address, and that the email address is the same as the one that was used to create the checkout.", "reference": "Put a comma after the last parameter of a multiline method call." }, { @@ -17019,27 +17019,27 @@ "reference": "I don't know if we even need this parameter." }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.", + "prediction": "I'm not sure I understand what you're trying to do here. Is this a test for `argparse` or `argparse.ArgumentParser`?", "reference": "What is the new result of this file if we keep it the same than before? It's just to picture easily what changed in this MR :) (thinking is hard)" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `await` here.", + "prediction": "I think this should be `await reader.ReadToEndAsync()` instead of `await reader.ReadToEnd()`.", "reference": "This needs to be synchronous for the timeout to work." }, { - "prediction": "I think we can remove the `<%= purchaseable.workshop.announcement.message %>` line.", + "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to put it at the bottom of the page.", "reference": "Can you break this onto multiple lines?" }, { - "prediction": "I'm not sure what you mean by \"no\" in this case. I think you meant to say \"no, no\" or \"no, no, no\" or \"no, no, no, no\" or \"no, no, no, no, no\" or \"no, no, no, no, no, no\" or \"no, no, no, no, no, no, no\" or \"no, no, no, no, no, no, no, no\" or \"no, no, no, no, no, no, no, no, no\" or \"no, no, no, no, no, no, no, no, no\" or \"no, no, no, no, no, no, no, no, no, no\" or \"no, no, no, no, no, no, no, no, no, no, no\" or \"no, no, no, no, no, no, no, no, no, no, no, no\" or \"no, no, no, no, no, no, no, no, no, no, no, no, no\" or \"no, no, no, no, no,", + "prediction": "I think we should remove the `no` and `x` from `EXT_SIMD8` and `EXT_SIMD5`.", "reference": "OK, it looks like all children have bit 4 set, but it doesn't really matter at this split point: just informative, nothing reads it." }, { - "prediction": "I think we should remove the `LinkToParentDomain` field.", + "prediction": "I think we should remove the `aws` field from the spec, as it's not used anywhere.", "reference": "Sorry for the very basic question but why do we still have a DNSZone CRD in light of the DNSEndpoint, I don't fully understand the differences." }, { - "prediction": "I'm not sure what you're trying to achieve with this test, but I think it would be better to test that the number of unique sessions stored is the same as the number of sessions created.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a test for this in `session/session_test.go` as well.", "reference": "Looks like loop with overhead. You can: - create SID - test private function `sessionIsUnique()`" }, { @@ -17047,11 +17047,11 @@ "reference": "In my opinion, it would be better to have two separate settings. One that stores if sorting is enabled and one that stores the order. That allows to toggle automatic sort without having to re-select the order." }, { - "prediction": "I think we can remove the `import \"github.com/spiffe/sri/control_plane/cli\"` line and just use `import \"github.com/spiffe/sri/control_plane/cli\"`.", + "prediction": "I think we can remove the `os.Args` argument and just use `os.Args[0]` instead.", "reference": "/me can't wait to rename this repo :)" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a good idea to have a `group` function that takes an array of objects and returns an array of objects.", + "prediction": "I don't think we need to use `makeLazyLoader` here, we can just use `loaders` directly.", "reference": "nit: maybe call these `loadCollection()/loadDb()`" }, { @@ -17059,35 +17059,35 @@ "reference": "Did you consider just do `return Task is an external data dependency and data does not exist (yet?).'`? Less `None`'s and `ifs`." }, { - "prediction": "I think it's better to use `render partial: 'bookmarks/refworks'` and `render partial: 'bookmarks/endnote'` instead of `render :partial => 'bookmarks/refworks', :locals => {:documents=>@document_list}` and `render :partial => 'bookmarks/endnote', :locals => {:documents=>@document_list}`.", + "prediction": "I think this should be `endnote_catalog_path` instead of `endnote_catalog_path(:sort=>params[:sort], :per_page=>params[:per_page], :id => @bookmarks.collect {|doc| doc.document_id}, :format => 'endnote')`", "reference": "Some day, we really need to make these toolbars pluggable.." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `WebEnginePage` class, since it's not really part of the `QWebEnginePage` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to `QWebEnginePage` instead of `QWebEnginePage.SavePage`.", "reference": "This should be `pygment=False` like in `browsertab.py`" }, { - "prediction": "I'm not sure what you mean by \"pushing us over the max\". I think it means that the max number of clients that can be connected to the server is reached, and the new client is added to the list of clients that can be connected to the server. Is that what you mean?", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to add a new client to the list of clients, but you're also trying to increase the max number of clients. Is this what you're trying to do? I'm not sure I understand what you're trying to do here. I think you're trying to add a new client to the list of clients, but you're also trying to increase the max number of clients. Is this what you're trying to do? I'm not sure I understand what you're trying to do here. I think you're trying to add a new client to the list of clients, but you're also trying to increase the max number of clients. Is this what you're trying to do? I'm not sure I understand what you're trying to do here. I think you're trying to add a new client to the list of clients, but you're also trying to increase the max number of clients. Is this what you're trying to do? I'm not sure I understand what you're trying to do here. I think you're trying to add a new client to the list of clients, but you're also trying to increase the max number of clients. Is this what you're", "reference": "Should this be moved down (or up) to under the client lock instead of server lock?" }, { - "prediction": "I'm not sure what you mean by `result = FPGA_INVALID_PARAM;`. I think you meant to say `result = FPGA_OK;`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to move this to `xfpga_fpgaGetMetricsByIndex` as well.", "reference": "Why are we removing this?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to do something like this:\n\n```\nclass Cart < ActiveRecord::Base\n has_many :items\n has_many :orders, through: :items\n has_many :payments, through: :orders\n has_many :transactions, through: :payments\n has_many :order_items, through: :items\n has_many :order_lines, through: :order_items\n has_many :order_items, through: :items\n has_many :order_lines, through: :order_items\n has_many :order_items, through: :items\n has_many :order_lines, through: :order_items\n has_many :order_items, through: :items\n has_many :order_lines, through: :order_items\n has_many :order_items, through: :items\n has_many :order_lines, through: :order_items\n has_many :order_items, through: :items\n has_many :order_lines, through: :order_items\n has_many :order_items, through: :items\n has_many :order_lines, through: :order_items\n has_many :order_items, through: :", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to do something like this:\n\n```\nclass Cart < ApplicationRecord\n belongs_to :user\n has_many :items, dependent: :destroy\n accepts_nested_attributes_for :items, allow_destroy: true\n accepts_nested_attributes_for :user, allow_destroy: true\n accepts_nested_attributes_for :cart_items, allow_destroy: true\nend\n```\n\nBut I'm not sure what you're trying to do here. I think you're trying to do something like this:\n\n```\nclass Cart < ApplicationRecord\n belongs_to :user\n has_many :items, dependent: :destroy\n accepts_nested_attributes_for :items, allow_destroy: true\n accepts_nested_attributes_for :user, allow_destroy: true\n accepts_nested_attributes_for :cart_items, allow_destroy: true\nend\n```\n\nBut I'm not sure what you're trying to do here. I think you're trying to do something like this:\n\n```\nclass Cart < ApplicationRecord\n belongs_to :user\n has_many :items, dependent: :destroy\n accepts_nested_attributes_for :items, allow_destroy: true\n accepts_nested_attributes_for :user, allow_destroy: true", "reference": "What do you think about using `self.id` ?" }, { - "prediction": "I think this should be `if err != nil` instead of `if err != nil && retry < 10`", + "prediction": "I think it's better to use `log.WithError(err).Warn(\"Retrying to start Typha\")` instead of `log.WithError(err).Fatal(\"Failed to connect to Typha\")`", "reference": "Please log once here at Error level \"Failed to connect to Typha, will retry...\"" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea to bump the version number in this way.", "reference": "Can you revert this change? The `VERSION` value will be updated after maintainer determines the version at release." }, { - "prediction": "I'm not sure if this is the best place to put this, but I think we should move it to the `ServiceDescription` class.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `ServiceDescription` class, since it's used in both `ServiceDescription` and `ServiceDefinition` classes.", "reference": "It could be better if we use the up case letter to specify the constant string name. Such as QUALIFIED_SERVICE_NAME_KEY can let the user know it's a constant string." }, { @@ -17095,7 +17095,7 @@ "reference": "This should be `@configuration.failure_exit_code`, we don't want to hard code 1." }, { - "prediction": "I think this should be `referencesVariables()` instead of `referencesVariables()`.", + "prediction": "I think this should be `false` instead of `true`.", "reference": "Changed per review in Blockly." }, { @@ -17103,7 +17103,7 @@ "reference": "Hi @wenyingd . so what's the original dst MAC of the reply packet from kube-proxy?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason you want to exclude too few public methods?", + "prediction": "I'm not sure I understand what you're trying to do here, but I think it's better to use `exclude-too-few-public-methods` instead of `exclude-too-few-public-methods` and `exclude-too-few-public-methods` instead of `exclude-too-few-public-methods` and `exclude-too-few-public-methods` instead of `exclude-too-few-public-methods` and `exclude-too-few-public-methods` instead of `exclude-too-few-public-methods` and `exclude-too-few-public-methods` instead of `exclude-too-few-public-methods` and `exclude-too-few-public-methods` instead of `exclude-too-few-public-methods` and `exclude-too-few-public-methods` instead of `exclude-too-few-public-methods` and `exclude-too-few-public-methods` instead of `exclude-too-few-public-methods` and `exclude-too-few-public-methods` instead of `exclude-too-few-public-methods` and `exclude-too-few-public-methods` instead of `exclude-too-few-public-methods` and `exclude-too-few-public-methods` instead of `exclude-too-few-public-methods` and `exclude-too", "reference": "Note: I wasn't sure what the right wording would be for this, so I used existing language from elsewhere in the codebase." }, { @@ -17111,19 +17111,19 @@ "reference": "Docstring for `platform`." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to restore the console to a state where it can't be used anymore. Is that what you're trying to do?", + "prediction": "I'm not sure what you mean by \"error restoring console to functional state\". I think you meant to say \"error restoring console to non-functional state\".", "reference": "This should be called before any `os.Exit` otherwise it could still mess up things." }, { - "prediction": "I don't think you need to change the `names` array. It's already defined in the `Color` class.", + "prediction": "I don't think you need to change the `names` array.", "reference": "shouldn't this be `short` ?" }, { - "prediction": "I don't think we need to add the capacity here.", + "prediction": "I don't think this is necessary.", "reference": "Can you please paste the output of `volume list` command which will show capacity of a openebs volume." }, { - "prediction": "I think this should be `if (metric == null)` instead of `if (metric instanceof MetricRegistry)`.", + "prediction": "I think this should be `if (metric == null) { throw new IllegalArgumentException(\"metric variable must not be null !!!\"); }` instead of `if (metric == null) { throw new IllegalArgumentException(\"metric variable must not be null !!!\"); }`", "reference": "I'd make this a `throw new NullPointerException(\"metric == null\");` instead" }, { @@ -17131,31 +17131,31 @@ "reference": "Include should be order lexicographically." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to set the min passcode length in the keychain.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's the best way to do this.", "reference": "We need to pass in the Activity context here, so that LoginActivity is used, and so that LoginActivity can get onActivityResult from the PasscodeActivity. Without this, the application context is used, and we don't get a callback when the passcode is done." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to hide the order of points of non-trackable traces for privacy. It's not clear to me if this is the best way to do this, but I think it's a good idea to hide the order of points of non-trackable traces for privacy. It's not clear to me if this is the best way to do this, but I think it's a good idea to hide the order of points of non-trackable traces for privacy. It's not clear to me if this is the best way to do this, but I think it's a good idea to hide the order of points of non-trackable traces for privacy. It's not clear to me if this is the best way to do this, but I think it's a good idea to hide the order of points of non-trackable traces for privacy. It's not clear to me if this is the best way to do this, but I think it's a good idea to hide the order of points of non-trackable traces for privacy. It's not clear to me if this is the best way to do this, but I think it's a good idea to hide the order of points", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to hide the order of points of non-trackable traces for privacy.", "reference": "Can you move these to the top please, for consistency with other models - normally we put scopes immediately after the associations at the top of the model. As to names I agree with @gravitystorm that these names may be confusing but I'm not sure the ones I suggested are perfect either so I'm not really sure what's best. The goal of my names was just to separate point which could be ordered (as `ordered`) from those which can't (as `unordered`) but I realise that may not be very clear from the names." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to remove the queue item when the item is marked as played.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `MediaBrowserServiceCompat` instead of `PlaybackService` because `MediaBrowserServiceCompat` doesn't have access to `FeedPreferences` and `FeedPreferences` doesn't have access to `FeedItem` and `FeedItem` doesn't have access to `DBWriter` and `DBWriter` doesn't have access to `FeedItem` and `FeedItem` doesn't have access to `DBWriter` and `DBWriter` doesn't have access to `FeedItem` and `FeedItem` doesn't have access to `DBWriter` and `DBWriter` doesn't have access to `FeedItem` and `FeedItem` doesn't have access to `DBWriter` and `DBWriter` doesn't have access to `FeedItem` and `FeedItem` doesn't have access to `DBWriter` and `DBWriter` doesn't have access to `FeedItem` and `FeedItem` doesn't have access to `DBWriter` and `DBWriter` doesn't have access to `FeedItem` and `FeedItem` doesn't have access to `DBWriter` and `DBWriter` doesn't", "reference": "Looks like the episode should also not be deleted when repeating" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it would be better to use the `caddyhttp/httpserver` package instead of the `caddy/caddyhttp/httpserver` package.", + "prediction": "I don't think this is necessary. We don't need to use the `httpserver` package here. We can just use the built-in `http` package.", "reference": "I feel like goimports would move this import line by the other non-std packages... can you double-check that? Run goimports or set up your editor to run it on save. :+1:" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to have a `chrome_options` method.", "reference": "`options['binary'] = WebDriver::Chrome.path` if set?" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to set up a SQLite3 database for the `explorer` app. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set up a SQLite3 database for the `explorer` app. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set up a SQLite3 database for the `explorer` app. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set up a SQLite3 database for the `explorer` app. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set up a SQLite3 database for the `explorer` app. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set up a SQLite3 database for the `explorer` app. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set up a SQLite3 database for the `explorer` app. I'm not sure what you're trying to achieve with", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a default SQLite3 file.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { - "prediction": "I think this should be `internal HttpProtocols _protocols = HttpProtocols.Http1;` instead of `internal const string Http2ExperimentSwitch = \"Switch.Microsoft.AspNetCore.Server.Kestrel.Experimental.Http2\";`", + "prediction": "I think this should be `internal HttpProtocols _protocols = HttpProtocols.Http1;` instead of `internal HttpProtocols _protocols = HttpProtocols.Http2;`", "reference": "Nit: Supported -> Enabled." }, { @@ -17175,15 +17175,15 @@ "reference": "the original code ignores \\Draft and \\Recent, whereas your change will not. what this matters, i'm not sure." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to stall the writes that come as part of the sync call, but I'm not sure what you're trying to do here. I think you're trying to stall the writes that come as part of the sync call, but I'm not sure what you're trying to do here. I think you're trying to stall the writes that come as part of the sync call, but I'm not sure what you're trying to do here. I think you're trying to stall the writes that come as part of the sync call, but I'm not sure what you're trying to do here. I think you're trying to stall the writes that come as part of the sync call, but I'm not sure what you're trying to do here. I think you're trying to stall the writes that come as part of the sync call, but I'm not sure what you're trying to do here. I think you're trying to stall the writes that come as part of the sync call, but I'm not sure what you're trying to do here. I think you're trying to stall the writes that come as part of the sync call, but I'm not sure what you're trying", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate test for this. It's", "reference": "Why was this necessary?" }, { - "prediction": "I'm not sure what you mean by \"to force rerunning tests for a target\". I think you meant to say \"to rerun tests for a target\".", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `--rerun` flag that will force the tests to be rerun even if they fail.", "reference": "Can you also do this for Cover?" }, { - "prediction": "I think this should be `if (subresourceRange.aspectMask & VK_IMAGE_ASPECT_COLOR_BIT)` instead of `if (subresourceRange.aspectMask & (VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_PLANE_0_BIT | VK_IMAGE_ASPECT_PLANE_1_BIT | VK_IMAGE_ASPECT_PLANE_2_BIT))`", + "prediction": "I think this should be `if (subresourceRange.aspectMask & VK_IMAGE_ASPECT_COLOR_BIT)` instead of `if (subresourceRange.aspectMask & (VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_PLANE_0_BIT | VK_IMAGE_ASPECT_PLANE_1_BIT | VK_IMAGE_ASPECT_PLANE_2_BIT))`.", "reference": "So I tried adding this VU a long time ago, thought it would be this simple of a check, but turns out there were other validation in the way for getting here in `ValidateImageAspectMask` I assume that is what is failing CI here, realized it would require some more refactoring" }, { @@ -17191,7 +17191,7 @@ "reference": "This method is not needed for postgresql, by default sum function omits null values so we can remove this file" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `systemdsystemgeneratordir=$($PKG_CONFIG --variable=systemdsystemgeneratordir systemd)`. It's not clear what you're trying to do here, but I don't think it's a good idea to use `systemdsystemgeneratordir=$($PKG_CONFIG --variable=systemdsystemgeneratordir systemd)`. It's not clear what you're trying to do here, but I don't think it's a good idea to use `systemdsystemgeneratordir=$($PKG_CONFIG --variable=systemdsystemgeneratordir systemd)`. It's not clear what you're trying to do here, but I don't think it's a good idea to use `systemdsystemgeneratordir=$($PKG_CONFIG --variable=systemdsystemgeneratordir systemd)`. It's not clear what you're trying to do here, but I don't think it's a good idea to use `systemdsystemgeneratordir=$($PKG_CONFIG --variable=systemdsystemgeneratordir systemd)`. It's not clear what you're trying to do here", + "prediction": "I'm not sure what you mean by `systemdsystemgeneratordir=$($PKG_CONFIG --variable=systemdsystemgeneratordir systemd)`. I think it should be `systemdsystemgeneratordir=$($PKG_CONFIG --variable=systemdsystemgeneratordir)`.", "reference": "Can you provide a `--with-systemdsystemgeneratordir` option here? So that I can do unprivileged installs without completely turning off systemd. I can add it as a follow-up PR too." }, { @@ -17199,71 +17199,71 @@ "reference": "`classification` is misspelled" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear to me what you're trying to do here. I don't think this is a good idea. It's not clear to me what you're trying to do here. I don't think this is a good idea. It's not clear to me what you're trying to do here. I don't think this is a good idea. It's not clear to me what you're trying to do here. I don't think this is a good idea. It's not clear to me what you're trying to do here. I don't think this is a good idea. It's not clear to me what you're trying to do here. I don't think this is a good idea. It's not clear to me what you're trying to do here. I don't think this is a good idea. It's not clear to me what you're trying to do here. I don't think this is a good idea. It's not clear to me what you're trying to do here. I don't think this is a good idea. It's not clear to me what you're trying to do here. I don't think", + "prediction": "I'm not sure I understand what you're trying to do here. Is it that you want to use the `initCode` of the first sample in the `methodSampleViews` list? If that's the case, why not just use the `initCode` of the first sample in the `methodSampleViews` list, and not the `methodInitCode` of the first sample in the `methodSampleViews` list? I'm not sure I understand what you're trying to do here. Is it that you want to use the `initCode` of the first sample in the `methodSampleViews` list? If that's the case, why not just use the `initCode` of the first sample in the `methodSampleViews` list, and not the `methodInitCode` of the first sample in the `methodSampleViews` list? I'm not sure I understand what you're trying to do here. Is it that you want to use the `initCode` of the first sample in the `methodSampleViews` list? If that's the case, why not just use the `initCode` of the first sample in the `methodSampleViews` list, and not the `methodInitCode` of the first sample in", "reference": "Can you change this to `sampleInitCode`?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to add a `startTs` field to the `TiDAGRequest` object, but I don't think that's what you're trying to do.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a `startTs` property to the `TiDAGRequest` class.", "reference": "I added a startTs information in `TiDagRequest` output. Not really sure if it is useful? @zhexuany" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you mean by `width = parseInt(frame.node.getAttribute('width'), 10);` and `height = parseInt(frame.node.getAttribute('height'), 10);`", "reference": "This prevents margin/border/padding CSS from affecting the width/height (otherwise in Chrome a width and height of 1 would result in a rect size of 5x5)." }, { - "prediction": "I'm not sure what you mean by `skip_authorization` in this context. I think you meant to use `skip_authorization!` or `skip_authorization(false)`?", + "prediction": "I'm not sure what you mean by `skip_authorization` in this context. I think you meant to use `skip_pundit_authorization` or `skip_pundit_authenticity_check` instead.", "reference": "prefer to just add this to the `verify_authorized` exception list above since we're already making exceptions." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right way to do it.", + "prediction": "I don't think we need to do this.", "reference": "was there a reason to not loop over parent classes here?" }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it would make sense to move it to the `UserSession` mixin, since it's a bit more specific to the `UserSession` mixin.", + "prediction": "I'm not sure if this is the right place to add this, but I think it would be good to add it to the AuthenticatedRouteMixin as well.", "reference": "@billybonks Why move `import Ember from 'ember';` to the top?" }, { - "prediction": "I'm not sure what you mean by \"pending\" and \"actionable\" in this context. I'm not sure what you mean by \"approved\" and \"rejected\" in this context. I'm not sure what you mean by \"pending\" and \"actionable\" in this context. I'm not sure what you mean by \"approved\" and \"rejected\" in this context. I'm not sure what you mean by \"pending\" and \"actionable\" in this context. I'm not sure what you mean by \"approved\" and \"rejected\" in this context. I'm not sure what you mean by \"pending\" and \"actionable\" in this context. I'm not sure what you mean by \"approved\" and \"rejected\" in this context. I'm not sure what you mean by \"pending\" and \"actionable\" in this context. I'm not sure what you mean by \"approved\" and \"rejected\" in this context. I'm not sure what you mean by \"pending\" and \"actionable\" in this context. I'm not sure what you mean by \"approved\" and \"rejected\" in this context. I'm not sure what you mean by \"pending\" and \"actionable\" in this context. I'm", + "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a separate workflow for approvals. I think it would be better to have a separate workflow for approvals. I think it would be better to have a separate workflow for approvals. I think it would be better to have a separate workflow for approvals. I think it would be better to have a separate workflow for approvals. I think it would be better to have a separate workflow for approvals. I think it would be better to have a separate workflow for approvals. I think it would be better to have a separate workflow for approvals. I think it would be better to have a separate workflow for approvals. I think it would be better to have a separate workflow for approvals. I think it would be better to have a separate workflow for approvals. I think it would be better to have a separate workflow for approvals. I think it would be better to have a separate workflow for approvals. I think it would be better to have a separate workflow for approvals. I think it would be better to have a separate workflow for approvals. I think it would be better to have a separate workflow for approvals. I think it would be better to have a separate workflow for approvals. I think it would be better", "reference": "Everything's so simple (a `ThreeStateWorkflow`) until it isn't :smirk:" }, { - "prediction": "I think we can remove the `vdims` argument from the test, since it's not used in this test.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to make sure that the `vdims` argument is passed to the `Contours` constructor.", "reference": "I don't quite understand where the NaNs come from..." }, { - "prediction": "I'm not sure what you mean by `allowMultiConnsPerHost`. Is it true that you don't want to allow more than one connection per host?", + "prediction": "I don't think we need to change the `MsgLogsCleaningInterval` to `2 * time.Second` because it's already set to `2 * time.Second` in the `LoadTestConfig` function.", "reference": "File is not `goimports`-ed" }, { - "prediction": "I think it's better to use `//_please:wheel_resolver` instead of `//_please:please_wheel_resolver`.", + "prediction": "I think it's better to use `//_please:please_go_embed` instead of `//_please:please_go`?", "reference": "I wonder if we should look at moving the Python stuff to a plugin and doing this there rather than adding to core plz at this point?" }, { - "prediction": "I'm not sure what you mean by \"inventory-file\". Could you please provide more context?", + "prediction": "I'm not sure what you mean by \"inventory-file\" in this context. Could you please clarify?", "reference": "This is the actual bug fix. I prob should have broken this out into two PRs." }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason for this change?", + "prediction": "I'm not sure I understand what you're trying to do here. Can you please provide more context?", "reference": "I am not sure if we need this, we already have DifficultyBombDelays" }, { - "prediction": "I think this is a bit of a red herring. The `delaySource` and `linkedSource` should be disposed of when the `token` is disposed of, right?", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to call `Dispose` on `delaySource` and `linkedSource` here.", "reference": "move to finally - I can see at least one return that would omit it, also any exception and so on" }, { - "prediction": "I'm not sure what you mean by \"delegate address\" in this context. Could you please clarify?", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to `genesis.go` or something like that.", "reference": "remove `genesisConfig.GravityChainStartHeight == 0`" }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it's a good idea to move it to the `vendor/autoload.php` file.", + "prediction": "I'm not sure if this is the best place to put it, but I think it's a good idea to move it to the `vendor/autoload.php` file.", "reference": "this might kill whole application if `var-dumper` will not be installed. What about two separate file_exists conditions (monorepo/project)?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `CreateSettingsFile` function.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have the `CreateSettingsFile` function return a `bool` so that the user can decide if they want to do an import or not.", "reference": "Hrm. Maybe this isn't the correct spot to run this? Because it errors if the app type doesn't support settings. But we want to check that before running it." }, { - "prediction": "I'm not sure what you're trying to do here, but I think it's better to just use `pretty_list` instead of `pretty_routes` in this case.", + "prediction": "I don't think we need to add a space between the header and the list.", "reference": "Why are you changing this name ?" }, { @@ -17275,23 +17275,23 @@ "reference": "I like this style of doing things better than having super big conditional without explanation. Even though I know this won't be re-used it's nice to have a function if only for clarity." }, { - "prediction": "I'm not sure what you're trying to do here. It looks like you want to decrement the group level, but I'm not sure what you're trying to do here. It looks like you want to decrement the group level, but I'm not sure what you're trying to do here. It looks like you want to decrement the group level, but I'm not sure what you're trying to do here. It looks like you want to decrement the group level, but I'm not sure what you're trying to do here. It looks like you want to decrement the group level, but I'm not sure what you're trying to do here. It looks like you want to decrement the group level, but I'm not sure what you're trying to do here. It looks like you want to decrement the group level, but I'm not sure what you're trying to do here. It looks like you want to decrement the group level, but I'm not sure what you're trying to do here. It looks like you want to decrement the group level, but I'm not sure what you're trying to do here. It looks like you want to decrement the group level, but I'm not sure what you're trying to do here. It looks like you", + "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", "reference": "Our preference here is to either have inline statements e.g. `@group_level -= 1 if @group_level > 0` but stylistically here I think `return @group_level if @group_level == 0` might be nicer. As it stands however our rubocop is picking this up as a fail :(" }, { - "prediction": "I'm not sure why this is failing in Spark 3.0.0, but I'm not sure how to fix it in Spark 3.0.0.", + "prediction": "I think this should be `@Ignore` instead of `@IgnoreForSpark3`", "reference": "Spark3 Is supported in OSS Iceberg, Do you mean this particular function is not supported in Spark3? If so I think we should have a more clear reason why" }, { - "prediction": "I think this should be `with open(os.path.abspath(notebook_path), \"rb\") as f:`", + "prediction": "I think this should be `os.path.abspath(notebook_path)` instead of `os.path.abspath(os.path.abspath(notebook_path))`", "reference": "something about the arbitrary file access part here makes me nervous. Can we keep the `if not path.endswith(\".ipynb\")` check from before here as well? Just imagining a weird attack scenario where somebody somehow uses this to get access to confidental files or something" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don", + "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. I think we should just use `Blacklight::Solr::SearchBuilder` instead.", "reference": "I wonder if we should push this and the search_params_logic into the blacklight config." }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `testing.T` instead of `testing.F` here. `testing.F` is used for unit tests, and `testing.T` is used for integration tests. `testing.F` is used for unit tests, and `testing.T` is used for integration tests. `testing.F` is used for unit tests, and `testing.T` is used for integration tests. `testing.F` is used for unit tests, and `testing.T` is used for integration tests. `testing.F` is used for unit tests, and `testing.T` is used for integration tests. `testing.F` is used for unit tests, and `testing.T` is used for integration tests. `testing.F` is used for unit tests, and `testing.T` is used for integration tests. `testing.F` is used for unit tests, and `testing.T` is used for integration tests. `testing.F` is used for unit tests, and `testing.T` is used for integration tests. `testing.F` is used for unit tests, and `testing.T` is used for integration tests. `testing.F` is used for unit tests, and `testing", + "prediction": "I don't think we need to use `context.Background()` here. We can just use `gomock.NewController(t)`.", "reference": "don't need this line, since it is not tested here?" }, { @@ -17299,35 +17299,35 @@ "reference": "I wonder if adding this new param in the middle of the param list might screw up some existing code that is depending on the old parameter order. Might be better to add it to the end of the parameter list?" }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it's a good idea to add it to the `errorProneOptions` in the `Project` class. This way, we don't have to add it to the `errorProneOptions` in the `BaselineErrorProne` class, and we don't have to add it to the `errorProneOptions` in the `Project` class. This way, we don't have to add it to the `errorProneOptions` in the `Project` class, and we don't have to add it to the `errorProneOptions` in the `Project` class. This way, we don't have to add it to the `errorProneOptions` in the `Project` class, and we don't have to add it to the `errorProneOptions` in the `Project` class. This way, we don't have to add it to the `errorProneOptions` in the `Project` class, and we don't have to add it to the `errorProneOptions` in the `Project` class. This way, we don't have to add it to the `errorProneOptions` in the", + "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good idea to move this into the `Project` class, so that it can be used in other places as well.", "reference": "I wonder if this absolute path is gonna affect the build-cache relocatability of these compile tasks??" }, { - "prediction": "I'm not sure what you're trying to say here. I think you're trying to say that the `readPreference` and `readConcern` should be set in the options, not in the `CommandOperationV2` class.", + "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", "reference": "possible bug if `fullResponse` is false" }, { - "prediction": "I don't think we need to use `re` in this case. We can just use `ascii_lowercase` instead.", + "prediction": "I don't think we need to import `ascii_lowercase` here. It's not used anywhere in the code.", "reference": "nitpick: Please only `import string` here and use `string.ascii_lowercase` - I really like to see what module stuff is coming from without looking at the imports." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to log out the user from the database. I'm not sure what you're trying to do here, but it looks like you're trying to log out the user from the database. I'm not sure what you're trying to do here, but it looks like you're trying to log out the user from the database. I'm not sure what you're trying to do here, but it looks like you're trying to log out the user from the database. I'm not sure what you're trying to do here, but it looks like you're trying to log out the user from the database. I'm not sure what you're trying to do here, but it looks like you're trying to log out the user from the database. I'm not sure what you're trying to do here, but it looks like you're trying to log out the user from the database. I'm not sure what you're trying to do here, but it looks like you're trying to log out the user from the database. I'm not sure what you're trying to do here, but it looks like you're trying to log out the user from the database. I'm not sure", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to log out the user and then close the database connection. Is this what you're trying to do?", "reference": "nitpick: the only reason we have a catch for every one of these promises is because the test isn't properly chaining promises (returning them within each `then`). We could reduce the `catch` with `console.dir` to a single instance if that was done" }, { - "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `std::string` as the type of the `encoded` variable. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `std::string` as the type of the `encoded` variable. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `std::string` as the type of the `encoded` variable. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `std::string` as the type of the `encoded` variable. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `std::string` as the type of the `encoded` variable. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `std::string` as the type of the `encoded` variable. It's not clear", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this.", "reference": "why do this?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `__toString()` method to `MediaLibrary` so that it can be used as a `var_dump()`, `print_r()`, etc.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to `System\\Classes\\MediaLibrary` as well. This way, we don't have to change anything in `Cms\\Classes\\MediaLibrary` and we don't have to change anything in `System\\Classes\\MediaLibrary`.", "reference": "For consistency, would it not be best to also replace the first class name? `traceLog('Class ' . static::class . ' has been deprecated, use ' . SystemMediaLibrary::class . ' instead.')`" }, { - "prediction": "I think we can remove the `EnableAdminApi` field, as it's not used anywhere in the spec.", + "prediction": "I think it's better to use the `EnableAdminApi` field in the `PrometheusConfig` struct.", "reference": "this should be `EnabledAdminAPI` and the json string should then be `enableAdminAPI`" }, { - "prediction": "I'm not sure what you're trying to achieve with this code. It looks like you're trying to create a simple web server that listens on port 5000 and serves static files from the `static` directory. However, there are a few issues with this code:\n\n1. The `safely_import_config()` function is not defined anywhere in the code.\n2. The `run_simple()` function is not defined anywhere in the code.\n3. The `os` module is not imported anywhere in the code.\n4. The `click` module is not imported anywhere in the code.\n5. The `webserver` module is not imported anywhere in the code.\n6. The `os` module is not imported anywhere in the code.\n7. The `click` module is not imported anywhere in the code.\n8. The `webserver` module is not imported anywhere in the code.\n9. The `os` module is not imported anywhere in the code.\n10. The `click` module is not imported anywhere in the code.\n11. The `webserver` module is not imported anywhere in the code.\n12. The `os` module is not imported anywhere in the code.\n13. The `click` module", + "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `safely_import_config` here. It seems like it could be used in other places as well. I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `safely_import_config` here. It seems like it could be used in other places as well. I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `safely_import_config` here. It seems like it could be used in other places as well. I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `safely_import_config` here. It seems like it could be used in other places as well. I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `safely_import_config` here. It seems like it could be used in other places as well. I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `s", "reference": "Noticed some missing imports in manage.py so thought I'd add them" }, { @@ -17335,23 +17335,23 @@ "reference": "as a future improvement, maybe we should just change `ForAllFlowRecordsDo` so that `updateOrSendFlowRecord` uses a flow record pointer instead of a copy of stored flow record. This whole code is executed with the lock any way." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bit of a misnomer to call it a \"literal string\". It's more like a \"string literal\" or a \"literal string\" depending on how you want to use it.", + "prediction": "I'm not sure what you're trying to achieve with this, but I think it's better to use `String.format` instead.", "reference": "I am not sure what GitHub wants to tell me with this icon here :)" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `BOOST_AUTO_TEST_CASE` in this way.", + "prediction": "I'm not sure if this is correct, but I think it should be: `BOOST_CHECK_EQUAL(result_1->x, reference_1.x);` and `BOOST_CHECK_EQUAL(result_1->y, reference_1.y);`", "reference": "can we also check for smaller zoom levels returning valid error codes?" }, { - "prediction": "I don't think this is necessary. We can just use `Console.WriteLine(message);` in the `LogHeader1` and `LogHeader2` methods.", + "prediction": "I don't think this is necessary. We can just use `Console.WriteLine(message);` instead of `Console.WriteLine($\"***{message}***\");` and `Console.WriteLine($\"=============== {message} ================ \");`", "reference": "1) These names are not great, doesn't help explain what they do. 2) Instead of methods like this that hard code some number of = and *, why not a method that takes the string, defaults to a char to surround with, and a width? 3) Do we really even need headers like this in the output? Maybe we ditch them." }, { - "prediction": "I think it's better to use `expect(hot.getActiveEditor().htEditor.getSelected()).toEqual([[11, 0, 11, 0]])` instead of `expect(hot.getActiveEditor().htEditor.getSelected()).toEqual([[0, 0, 0, 0]])`", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `expect(...).toEqual(...)` in this case.", "reference": "The autocomplete editor shouldn't change its own behavior, I assume that `autoWrapCol` and `autoWrapRow` options should be set to `false` in handsontable editor." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a comment here explaining why we're doing this. I'm not sure if this is the right place to do this, but I think it would be a good idea to add a comment here explaining why we're doing this. I'm not sure if this is the right place to do this, but I think it would be a good idea to add a comment here explaining why we're doing this. I'm not sure if this is the right place to do this, but I think it would be a good idea to add a comment here explaining why we're doing this. I'm not sure if this is the right place to do this, but I think it would be a good idea to add a comment here explaining why we're doing this. I'm not sure if this is the right place to do this, but I think it would be a good idea to add a comment here explaining why we're doing this. I'm not sure if this is the right place to do this, but I think it would be a good idea to add a comment here explaining why we're doing this. I'm not sure if this is the right place to", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the", "reference": "out of curiosity, with IPv6 introduced, why there's no change to the expected output of openflow in the test?" }, { @@ -17359,11 +17359,11 @@ "reference": "nit: grammar: instruction" }, { - "prediction": "I don't think this is necessary. The `DataFetchingEnvironment` is already available in the `DataFetcher` class.", + "prediction": "I don't think this is necessary. The `DataFetchingEnvironment` is just a wrapper for the `DataFetcher`, so it's not necessary to have a separate `DataFetchingEnvironment` class.", "reference": "We can revert this to reduce the diff of the PR." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a new reconcile.Reconciler, but you're not passing it to the `newReconciler` function. Is this what you're trying to do? If so, what's the purpose of the `newReconciler` function? What's the purpose of the `ReconcileHiveConfig` struct? What's the purpose of the `Add` function? What's the purpose of the `newReconciler` function? What's the purpose of the `Add` function? What's the purpose of the `newReconciler` function? What's the purpose of the `Add` function? What's the purpose of the `newReconciler` function? What's the purpose of the `Add` function? What's the purpose of the `newReconciler` function? What's the purpose of the `Add` function? What's the purpose of the `newReconciler` function? What's the purpose of the `Add` function? What's the purpose of the `newReconciler` function? What's the purpose of the `Add` function? What's the purpose of the `newReconciler", + "prediction": "I'm not sure what you mean by \"new reconcile.Reconciler\" in this context. I think you meant to say \"new reconcile.ReconcilerWithClient\" or \"new reconcile.ReconcilerWithScheme\" or \"new reconcile.ReconcilerWithRestConfig\" or \"new reconcile.ReconcilerWithMgr\" or \"new reconcile.ReconcilerWithConfig\" or \"new reconcile.ReconcilerWithScheme\" or \"new reconcile.ReconcilerWithRestConfig\" or \"new reconcile.ReconcilerWithMgr\" or \"new reconcile.ReconcilerWithConfig\" or \"new reconcile.ReconcilerWithScheme\" or \"new reconcile.ReconcilerWithRestConfig\" or \"new reconcile.ReconcilerWithMgr\" or \"new reconcile.ReconcilerWithConfig\" or \"new reconcile.ReconcilerWithScheme\" or \"new reconcile.ReconcilerWithRestConfig\" or \"new reconcile.ReconcilerWithMgr\" or \"new reconcile.ReconcilerWithConfig\" or \"new reconcile.ReconcilerWithScheme\" or \"new reconcile.ReconcilerWithRestConfig\" or \"new reconcile.ReconcilerWithMgr\" or \"new reconcile.ReconcilerWithConfig\" or \"new reconcile.ReconcilerWithScheme\" or \"", "reference": "i think this missed the reconciler to callsite change" }, { @@ -17371,7 +17371,7 @@ "reference": "Please reuse `getClientConfigPath`." }, { - "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `require` to import the `matcher` module, and then use `require` again to import the `suite` module. This way, we don't have to import the `matcher` module twice, and we don't have to import the `suite` module twice. I'm not sure if this is the right way to do this, but I think it's a good idea to use `require` to import the `matcher` module, and then use `require` again to import the `suite` module. This way, we don't have to import the `matcher` module twice, and we don't have to import the `suite` module twice. I'm not sure if this is the right way to do this, but I think it's a good idea to use `require` to import the `matcher` module, and then use `require` again to import the `suite` module. This way, we don't have to import the `matcher` module twice, and we don't have to import the `suite` module twice. I'm not sure if this is the right way to do this, but I", + "prediction": "I think we should use `require('../../tools/spec-runner/matcher').default` instead of `require('../../functional/spec-runner/matcher').default`.", "reference": "Should we use the shared chai-addon.js file here? Actually we should consolidate any `chai.use` calls, I see 20 instances, quick win?" }, { @@ -17379,7 +17379,7 @@ "reference": "Maybe move _agreedCapabilities and _availableCapabilities from List to SortedSet ? We could order them by code and then by version already." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to update the starting sequence, but I'm not sure what you're trying to do here. I think you're trying to update the starting sequence, but I'm not sure what you're trying to do here. I think you're trying to update the starting sequence, but I'm not sure what you're trying to do here. I think you're trying to update the starting sequence, but I'm not sure what you're trying to do here. I think you're trying to update the starting sequence, but I'm not sure what you're trying to do here. I think you're trying to update the starting sequence, but I'm not sure what you're trying to do here. I think you're trying to update the starting sequence, but I'm not sure what you're trying to do here. I think you're trying to update the starting sequence, but I'm not sure what you're trying to do here. I think you're trying to update the starting sequence, but I'm not sure what you're trying to do here. I think you're trying to update the starting sequence, but I'm not sure what you're trying to do here. I think you're", + "prediction": "I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure", "reference": "I see the `+1` issue, but we used to check if `o.lss != nil` and we don't anymore, so we are sure that it won't be nil here, right?" }, { @@ -17387,7 +17387,7 @@ "reference": "why is the `send` needed?" }, { - "prediction": "I think this should be `if bboxes.shape[0] == 0:` instead of `if bboxes.shape[0] == 0:`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `bbox2result` as well. It's not clear to me why we would want to do this in `bbox2result` and not in `bbox2label`.", "reference": "Is this necessary? If so, we need to update the docstring." }, { @@ -17395,15 +17395,15 @@ "reference": "Checking for actionable here instead of grabbing the first pending approval. I tested this with proposal ID 265 on staging." }, { - "prediction": "I'm not sure what you mean by `self._qtbot.waitSignal(self.got_result, timeout=2000)`", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `self._qtbot.waitSignal(self.got_result, timeout=2000)` instead of `self._qtbot.waitSignal(self.got_result, timeout=1000)`. This is because `timeout=1000` means that the test will run for 1000ms, and `timeout=2000` means that the test will run for 2000ms. If the test takes longer than 2000ms, the test will fail.", "reference": "I made this change because I wasn't getting printouts of the 'result' value when the assert was inlined for some reason. I think it's related to creating new CallbackCheckers maybe?" }, { - "prediction": "I think this should be `ParseStartLine` instead of `ParseStartLine`.", + "prediction": "I think this should be `ParseStartLine(T handler, ReadableBuffer buffer, out ReadCursor consumed, out ReadCursor examined)` instead of `ParseStartLine(T handler, ReadableBuffer buffer, out ReadCursor consumed, out ReadCursor examined) where T : IHttpStartLineHandler`.", "reference": "nit: the correct name is \"request line\", so let's use the right one here :)" }, { - "prediction": "I'm not sure why we're using `os.environ['CATALOG_URL']` instead of `os.environ['CATALOG_HOST']`.", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `os.environ['CATALOG_URL']` instead of `os.environ.get('CATALOG_URL')`.", "reference": "This should now use `[]`, so it crashes if the var is missing" }, { @@ -17411,7 +17411,7 @@ "reference": "you could use `bpf_map_update_elem` with `BPF_EXIST`" }, { - "prediction": "I think this should be `throw new UncheckedIOException(\"Failed to create output stream for location: \" + uri(), e);`", + "prediction": "I'm not sure if this is the right place to throw an exception here, but I think it's a good idea to throw an exception here.", "reference": "thanks for noticing this! But I think we should not have it in this PR." }, { @@ -17419,95 +17419,95 @@ "reference": "A few things: - This may not serialize because I think the property for the sequence number on an input is `.sequenceNumber`. - There should be tests to cover these statements - Indentation is incorrect (should be two spaces, as similar to the statements above)" }, { - "prediction": "I think we can remove the `if data_format not in cls.supported_data_formats` check.", + "prediction": "I think we can remove the `if data_format not in cls.supported_data_formats` line.", "reference": "If this is a base method that could be used by others, should you hardcode 'GCS uploader' here?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be a good place to put it. I'm not sure if this is a good place to put it, but I think it would be a good place to put it. I'm not sure if this is a good place to put it, but I think it would be a good place to put it. I'm not sure if this is a good place to put it, but I think it would be a good place to put it. I'm not sure if this is a good place to put it, but I think it would be a good place to put it. I'm not sure if this is a good place to put it, but I think it would be a good place to put it. I'm not sure if this is a good place to put it, but I think it would be a good place to put it. I'm not sure if this is a good place to put it, but I think it would be a good place to put it. I'm not sure if this is a good place to put it, but I think it would be a good place to put it. I'm not sure if this is a good place to put it", "reference": "just a little thing: let's introduce a `final int bound = length - back.length();` that saves us calculating the bound each time checking the loop condition." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate handler for each of these routes.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate handler for each of these routes, so that we don't have to worry about the order in which the handlers are called.", "reference": "I think that this should be a POST method, as it changes the state. Get requests should not change the state. With different method, I would suggest to have the handler under `\"/settlements/{peer}\"` path." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don", + "prediction": "I'm not sure what you mean by \"sequencer mode\" here. I think you meant \"sync mode\".", "reference": "This is the default value?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add a `__version__` attribute to the `cliquet` module. This will make it easier to track the version of the library.", + "prediction": "I'm not sure if this is a good place to put it, but I think we should move it to `cliquet/__init__.py` instead of `cliquet/__init__.pyi` because `cliquet/__init__.pyi` is used by `cliquet/__init__.py` and `cliquet/__init__.pyi` is used by `cliquet/__init__.py` and `cliquet/__init__.pyi`.", "reference": "The spaces are actually legitimate here: in python, you: - first import standard library modules (hint: time is one) - then import 3rd party library modules - then import the modules from you project (here kinto). Between each block you need an empty line." }, { - "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea. It's not clear what you're trying to do with this, but I don't think it's a good idea. It's not clear what you're trying to do with this, but I don't think it's a good idea. It's not clear what you're trying to do with this, but I don't think it's a good idea. It's not clear what you're trying to do with this, but I don't think it's a good idea. It's not clear what you're trying to do with this, but I don't think it's a good idea. It's not clear what you're trying to do with this, but I don't think it's a good idea. It's not clear what you're trying to do with this, but I don't think it's a good idea. It's not clear what you're trying to do with this, but I don't think it's a good idea. It's not clear what you're trying to do with this, but I don't think it's a good idea. It's not clear what you're trying to do with this, but I don", + "prediction": "I'm not sure what you're trying to do here, but I don't think this is the right place to do it. It should be done in `PackageInfo`'s `MarkedSource` method.", "reference": "Haha, whoa, I'm not sure how I let that one go by. :)" }, { - "prediction": "I think we should return \".md\" for \"text/markdown\" as well as other extensions in MimeTypeDetectionByFileExtension.properties", + "prediction": "I'm not sure what you mean by \"other extensions in MimeTypeDetectionByFileExtension.properties\". Could you please provide more context?", "reference": "FWIW: We have FileUtil.generateOriginalExtension for tabular files but it uses a hardcoded list rather than the properties file." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think we should put it in the `KubernetesProvider` struct.", + "prediction": "I'm not sure if this is the right place to add this, but I think we should add it to the `KubernetesProvider` struct as well.", "reference": "I would consider extracting this logic in to a helper function to make it a bit more readable, but that's just my opinion." }, { - "prediction": "I think we should remove the `DebugSimulateDataRace` option. It's not used anywhere.", + "prediction": "I don't think this is a good idea.", "reference": "Are all fields beginning with \"Debug\" automatically `;local` ? (I guess so, but just checking.)" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a `__init__` method to `EvalHook` and `DistEvalHook` so that we don't have to call `__init__` every time we create an instance of these classes.", + "prediction": "I don't think this is a deprecation warning. It's just a warning that `eval_hook` is deprecated.", "reference": "We should let this module inherits from the EvalHook supported in MMCV, and only override the `__init__` function by adding the warnings. The other functions can use those in MMCV." }, { - "prediction": "I think we should remove the `getDataSource().getSQLDialect().getQuotedIdentifier(roleName, false, true)` part.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. It's not clear to me if this is the right place to do this, but I think it would be a good place to do this. It's not clear to me if this is the right place to do this, but I think it would be a good place to do this. It's not clear to me if this is the right place to do this, but I think it would be a good place to do this. It's not clear to me if this is the right place to do this, but I think it would be a good place to do this. It's not clear to me if this is the right place to do this, but I think it would be a good place to do this. It's not clear to me if this is the right place to do this, but I think it would be a good place to do this. It's not clear to me if this is the right place to do this, but I think it would be a good place to do this. It's not clear to me if this is the right place to do this, but I think it would be a good place to", "reference": "Let's use prepared statements here instead" }, { - "prediction": "I'm not sure what you're trying to achieve with this code. It looks like you're trying to add a button component to the `Global` story, but I'm not sure what you're trying to achieve with this code. Could you please provide more context or explain what you're trying to achieve with this code?", + "prediction": "I don't think we need to add a button component to this story.", "reference": "Just leaving this in one place but thanks so much for re-organising all these imports." }, { - "prediction": "I'm not sure what you're trying to achieve with this. It looks like you're trying to create a list of instrumentation functions, but I'm not sure what you're trying to achieve with this. Can you please explain what you're trying to achieve with this list of instrumentation functions?", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to use the `FUNCTION` macro in a way that doesn't make sense.", "reference": "Ditto, here and below" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate function for this.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `typeof vnode.props[key] === 'function'` before trying to call `vnode.props[key]`.", "reference": "Let's move the check outside the `for`-loop so that we don't have to do it for every prop. If we change it to check for `vnode.type === 'string'` we can automatically skip checking text nodes which don't have props" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to have `style_opts` in a generic element plot.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to have the `finalize_hooks` and `hooks` parameters in the `GenericElementPlot` class. It's better to have them in the `BokehPlot` class and pass them to the `BokehPlot.__init__` method.", "reference": "Seems like the docstring here should simply be \"Deprecated; use `hooks` instead.\"." }, { - "prediction": "I don't think we need to use `ContextCompat.getColor()` here. We can just use `R.color.highlight_dark` or `R.color.highlight_trueblack` directly.", + "prediction": "I don't think we need to use `ContextCompat.getColor` here. We can just use `R.color.highlight_dark` or `R.color.highlight_trueblack` directly.", "reference": "It would be nice to have an `attr` in `styles.xml` for this, so we don't need the same `if` statement in multiple places" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a unique index on the `user_id` and `workshop_id` columns in the `teachers` table. This will ensure that each teacher can only be associated with one workshop and one user at a time.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to add a unique index on the `user_id` and `workshop_id` columns in the `teachers` table. This way, we can ensure that a teacher can only be associated with one workshop and one user at a time.", "reference": "How about `null: false` on these two lines? Also `t.timestamps null: false`?" }, { - "prediction": "I'm not sure what you mean by \"this probably happened when using embedded metastore or doesn't create transactional meta table\"", + "prediction": "I think this should be `throw new RuntimeException(String.format(\"Metastore operation failed for %s.%s\", database, tableName), e);`", "reference": "This recommendation isn't very helpful because it isn't clear what \"the metastore\" is. How about this instead: \"To fix this, use an alternative metastore\"." }, { - "prediction": "I'm not sure what you're trying to do here. Is it possible that you're trying to get the next numeric suffix that makes desiredName unique? If that's the case, then I'm not sure what you're trying to do here. Is it possible that you're trying to get the next numeric suffix that makes desiredName unique? If that's the case, then I'm not sure what you're trying to do here. Is it possible that you're trying to get the next numeric suffix that makes desiredName unique? If that's the case, then I'm not sure what you're trying to do here. Is it possible that you're trying to get the next numeric suffix that makes desiredName unique? If that's the case, then I'm not sure what you're trying to do here. Is it possible that you're trying to get the next numeric suffix that makes desiredName unique? If that's the case, then I'm not sure what you're trying to do here. Is it possible that you're trying to get the next numeric suffix that makes desiredName unique? If that's the case, then I'm not sure what you're trying to do here. Is it possible that you're trying to get the next numeric suffix that makes desired", + "prediction": "I don't think we need this.", "reference": "The `SymbolTable` deals only with symbols, I think we can just call this `isUsed` here." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `webdriver.http.XhrClient` instead of `webdriver.http.CorsClient` in this case.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in `webdriver.http.XhrClient`", "reference": "Please hide this behind a flag and add a setter function to the builder." }, { - "prediction": "I think we should remove the `if assoc.get(\"Main\")` check.", + "prediction": "I think we can remove the `AssociationId` from the `disassociate_route_table` call.", "reference": "Just a side-node, no need to change it here: The term \"recent\" might be confusing at a later point in time." }, { - "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `Object.keys(val1)` instead of `Object.keys(val1 !== undefined ? val1.keys() : Object.keys(val1))`.", + "prediction": "I don't think this is necessary. We can just use `val1[key] === val2[key]` instead.", "reference": "When can it be undefined? Wouldn't that be a bug?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea to add a `@ThreadSafe` annotation to a class that is not intended to be used in a thread-safe manner.", + "prediction": "I don't think this is necessary. The `ManagedObject` class is not used anywhere in the code. It's just there for the sake of completeness.", "reference": "JMX offers normal APIs for this. I don't think you want the glassfish one." }, { @@ -17515,15 +17515,15 @@ "reference": "Could you remove `,' at the end?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to call `portprober.findFreePort('localhost')` here.", + "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to start a server that will listen on a specific port, and then wait for it to start.", "reference": "Maybe it would simpler to ignore opt_port if type !== 'number'?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Can you please provide some more context?", + "prediction": "I'm not sure what you mean by \"effective address\" here. Is it the address of the account whose AccountDetail this is? Or is it the address of the account whose AccountData this is? I'm not sure what you mean by \"effective address\" here. Is it the address of the account whose AccountDetail this is? Or is it the address of the account whose AccountData this is? I'm not sure what you mean by \"effective address\" here. Is it the address of the account whose AccountDetail this is? Or is it the address of the account whose AccountData this is? I'm not sure what you mean by \"effective address\" here. Is it the address of the account whose AccountDetail this is? Or is it the address of the account whose AccountData this is? I'm not sure what you mean by \"effective address\" here. Is it the address of the account whose AccountDetail this is? Or is it the address of the account whose AccountData this is? I'm not sure what you mean by \"effective address\" here. Is it the address of the account whose AccountDetail this is? Or is it the address of the account whose AccountData this is? I'm not sure what you mean by \"effective", "reference": "do you want to rename the codec tag here too?" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `DriverCommand` interface.", + "prediction": "I think this should be `GET_CAST_ISSUE_MESSAGE` instead of `GET_CAST_SINK_ISSUE_MESSAGE`.", "reference": "These command names are specific to Chromium-based browsers. Please move to `ChromiumDriverCommand`" }, { @@ -17531,51 +17531,51 @@ "reference": "Hm.. should we auto-patch? I am less sure on this yet as `percentile_approx` seems a Spark function and auto-patching it in Koalas seems a bit counterintuitive." }, { - "prediction": "I think this is not a good idea. It's not clear to me what you are trying to do here.", + "prediction": "I don't think you need to do that. The `ServiceContainerTestCase` is just a wrapper around the `ServiceContainer` class, so you don't need to override it.", "reference": "I found domain use in `AllFeedsTest::getAllFeedExportCreationData` and class AllFeedsTest is descendant of `FunctionalTestCase`. I think so we can rewrite this too.." }, { - "prediction": "I think it's better to use `ListStateDescriptor>>` instead of `ListStateDescriptor`. `ListStateDescriptor` is not thread-safe, while `ListStateDescriptor>>` is.", + "prediction": "I think it's better to use `ListStateDescriptor>>` instead of `ListStateDescriptor`. `ListStateDescriptor` is not thread-safe. `ListStateDescriptor>>` is thread-safe. `ListStateDescriptor>>` is thread-safe. `ListStateDescriptor>>` is thread-safe. `ListStateDescriptor>>` is thread-safe. `ListStateDescriptor>>` is thread-safe. `ListStateDescriptor>>` is thread-safe. `ListStateDescriptor>>` is thread-safe. `ListStateDescriptor>>` is thread-safe. `ListStateDescriptor>>` is thread-safe. `ListStateDescriptor>>` is thread-safe. `ListStateDescriptor>>` is thread-safe. `ListStateDescriptor>>` is thread-safe", "reference": "I am wondering if it is better to consolidate all committer checkpoint states into a single structure, e.g. Pojo class or Avro record which are Flink supported state types for schema evolution." }, { - "prediction": "I'm not sure I understand what you're trying to do here, but I think you're trying to do something like this:\r\n\r\n def _filter_signals(self, signal, log_signal, tab, *args):\r\n \"\"\"Filter signals and trigger TabbedBrowser signals if needed.\r\n\r\n Triggers signal if the original signal was sent from the _current_ tab.\r\n \"\"\"\r\n- return functools.partial(self._filter_signals, signal, tab)\r\n+ log_signal = debug.signal_name(signal) not in self.BLACKLIST\r\n+ return functools.partial(self._filter_signals, signal, log_signal, tab)\r\n \r\n- def _filter_signals(self, signal, log_signal, tab, *args):\r\n+ def _filter_signals(self, signal, log_signal, tab, *args):\r\n \"\"\"Filter signals and trigger TabbedBrowser signals if needed.\r\n\r\n Triggers signal if the original signal was sent from the _current_ tab.\r\n \"\"\"\r\n+ log_signal = debug.signal_name(signal) not in self.BLACKLIST\r\n+ return functools.partial(self._filter_signals, signal, log_signal, tab, *args)\r\n```\nReview comment?", + "prediction": "I'm not sure I understand what you're trying to do here. Can you give an example of what you're trying to do? I'm not sure I understand what you're trying to do here. Can you give an example of what you're trying to do? I'm not sure I understand what you're trying to do here. Can you give an example of what you're trying to do?", "reference": "I assume this is a performance optimization to only check this once when creating the signal filter? While you're at it, maybe make `BLACKLIST` a set instead?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way", + "prediction": "I don't think this is needed anymore.", "reference": "Please use async/await and try/catch" }, { - "prediction": "I think we can remove the `MakeCamel` here.", + "prediction": "I think it's better to use `MakeCamel` instead of `WrapInNameSpace` here.", "reference": "Like I said, this code looks incorrect. Why is it still looking up the attribute? Why is it getting the type from `nested->type.struct_def` instead of `field.nested_flatbuffer`? Are you running `generate_code.sh`, because I think `nested->type.struct_def` would be null?" }, { - "prediction": "I'm not sure what you mean by \"push descriptor extension not supported, push descriptor cases skipped.\" Could you please clarify?", + "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to add a comment here explaining why we're doing this.", "reference": "Actually, I'm not sure why lines 1663-1668 are here. Looks like Push descriptors aren't used in the test at all. @ziga-lunarg?" }, { - "prediction": "`@property` should be `@property` instead of `@property {%s}`.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this", "reference": "Don't we still want to check it it's a keyword?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to add a link to the image, but you're not using the `image_with_border` class. I'm not sure what you're trying to do here. I think you're trying to add a link to the image, but you're not using the `image_with_border` class. I'm not sure what you're trying to do here. I think you're trying to add a link to the image, but you're not using the `image_with_border` class. I'm not sure what you're trying to do here. I think you're trying to add a link to the image, but you're not using the `image_with_border` class. I'm not sure what you're trying to do here. I think you're trying to add a link to the image, but you're not using the `image_with_border` class. I'm not sure what you're trying to do here. I think you're trying to add a link to the image, but you're not using the `image_with_border` class. I'm not sure what you're trying to do here. I think you're trying to add a link to the image, but you're", + "prediction": "I think we should remove the `class: \"image-with-border\"`.", "reference": "this can just me `link_text` :tomato:" }, { - "prediction": "I think this test should be moved to a separate test suite.", + "prediction": "I think this test should be moved to a separate test.", "reference": "What if the Series contains null values?" }, { - "prediction": "I think this should be `Uri = TestAnalysisTarget.CreateUriForJsonSerialization()` instead of `Uri = TestAnalysisTarget.CreateUriForJsonSerialization()`.", + "prediction": "I think we should remove the `Uri` from the `PhysicalLocationComponent` and just use the `Uri` from the `PhysicalLocation` component.", "reference": "Every place you see a change like this, it's because `PhysicalLocation` is now its own object, not an array of `PhysicalLocationComponent` objects. The `Uri` is the key into the `FileInfo` dictionary." }, { - "prediction": "`sklearn.mixture` is not available in Python 3.5+ so we should use `sklearn.mixture.GaussianMixture` instead of `sklearn.mixture.SklearnMixture`.", + "prediction": "I think this should be `EPS = 1e-12` instead of `eps = 1e-12`", "reference": "Like in atss_head" }, { - "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to increase the fee per byte by a factor of `pool.expFeeFactor` for each block that is pending in the pool. Is that correct?", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to set the `feeThresholdMultiplier` based on the number of pending whole blocks in the pool, but I'm not sure if that's what you're trying to do.", "reference": "nit : I think it would be better to have the multiplier being calculated along with `pool.numPendingWholeBlocks`, so that we could always multiply the feePerByte with that multiplier. Not only that it would be faster, but it would also have constant time. btw - Correct me if I'm wrong, but with this change, you're practically rolling back your previous change while making it `pool.expFeeFactor` adjustable, right ?" }, { @@ -17583,35 +17583,35 @@ "reference": "Is there a reason we _wouldn't_ want to do this? A bit of a security hole :grimacing:" }, { - "prediction": "Shouldn't this be `Yaml.load(FileInputStream projectSpecFile)`?", + "prediction": "Shouldn't this be `import java.io.File;` instead of `import java.io.FileInputStream;`?", "reference": "Please add a copyright notice to all new files. Is there a tool to check and auto update copyright notices?" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `UserType` class, since it's related to the `User` model.", + "prediction": "I don't think we need to change the `label` here, since it's the same as the `label` of the `Email` type.", "reference": "A new translation dump should be made after this change (removing the \"Email\" message)" }, { - "prediction": "I think this should be `if (node !== null)` instead of `if (node === null)`.", + "prediction": "I think this should be `if (node === null)` instead of `if (node === undefined)`.", "reference": "CI is failing saying `expected [TypeError: null is not an object (evaluating 'implicitNodes(role).map')] to equal null`." }, { - "prediction": "I'm not sure what you mean by \"reapplying innerHTML when __html property of dangerouslySetInnerHTML attr remains unchanged\"", + "prediction": "I'm not sure what you mean by `__html` here. It's not a prop of `dangerouslySetInnerHTML`, it's a prop of `ref`.", "reference": "@JoviDeCroock I replaced the refs here with simple assignments." }, { - "prediction": "I'm not sure what you mean by \"default connection pool size (5)\".", + "prediction": "I don't think we need to expose this for testing.", "reference": "nit: Could we use VisibleForTesting annotation here?" }, { - "prediction": "I'm not sure what you're trying to say here. I think you're trying to test that the `posts_count` is equal to `1` and that the `created_at` is sorted in descending order. But I don't think that's what you're trying to test here. I think you're trying to test that the `posts_count` is equal to `1` and that the `created_at` is sorted in descending order. But I don't think that's what you're trying to test here. I think you're trying to test that the `posts_count` is equal to `1` and that the `created_at` is sorted in descending order. But I don't think that's what you're trying to test here. I think you're trying to test that the `posts_count` is equal to `1` and that the `created_at` is sorted in descending order. But I don't think that's what you're trying to test here. I think you're trying to test that the `posts_count` is equal to `1` and that the `created_at` is sorted in descending order. But I don't think that's what you're trying to test here. I think you're trying to test that the", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to test that `posts_count` is equal to `1` for posts that are not answered, but I don't think that's what you're trying to test here.", "reference": "Can we create some post records to assert sort_by" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `handshakeService.Handle` function.", "reference": "is this necessary?" }, { - "prediction": "I think we should remove the `private` from the `Filters` list.", + "prediction": "I think this should be `public List> Filters { get; private set; } = new List>();`", "reference": "What is the purpose of this? It seems like it is used to indicate whether there is a filter on a span. But what filter? Could there eventually be multiple filters per span? Just not understanding." }, { @@ -17619,23 +17619,23 @@ "reference": "using a certain type instead of using string directly." }, { - "prediction": "I'm not sure what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea.", "reference": "fix trailing ," }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a link to the map in the trace view. This way, users can see the map even if they don't want to view the trace.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `:mlat` and `:mlon` params to get the latitude and longitude of the map.", "reference": "I've fixed it for this change but for future reference there's no point doing string substitution for a single value like that - it will just slow things down. Just use `:mlat => trace.latitude` etc instead." }, { - "prediction": "I don't think we need to use `ProductAssert` here. We can use `AttributeAssert` instead.", + "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good idea to move this into the `ProductAttribute` class.", "reference": "The form no logger needs validation?" }, { - "prediction": "I think this should be `if (metricsToExport != null && metricsToExport.Metrics.Count > 0)` instead of `if (metricsToExport != null)`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if there are any metrics to export, and if there are, add them to the `Batch`.", "reference": "there'd be more changes in the area, when we implement \"clean-up\" of aggregators if no new updates. (i think we currently send metricitem to exporters with zero as value)" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to add permissions to a bucket that doesn't exist.", + "prediction": "I'm not sure what you mean by \"can be added on collections\". I think you meant to say \"can be added on buckets\".", "reference": "Usually we only keep the assertions that are relevant to the specification (ie. the test title). For example, the test on the values of id and details is not properly relevant for the spec _collections are isolated by bucket_. I suggest that you only keep the assertions regarding `details` in dedicated tests similar to `test_unknown_collection_raises_404` from `test_views_records.py`, but for each of bucket, group, collection and record in the other `test_views_` files." }, { @@ -17643,7 +17643,7 @@ "reference": "The test sources are ok though, you don't need to remove those changes" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think we need to change anything here.", + "prediction": "`width * 2` should be `width * 3`", "reference": "`maxWidth: width * 2,` Potentially, this will be the same as `getImageUrl`: 80px or 500px. I can't verify this - need for normal LiveTV tuner." }, { @@ -17651,11 +17651,11 @@ "reference": "Not really related to this issue but should we use fuzzy search here as well (like for apps)?" }, { - "prediction": "I'm not sure I understand what you're trying to do with the `forceQR` command. Is it supposed to append a fake quota reclamation record to the folder history? If so, I'm not sure I understand what you're trying to do with the `forceQR` command. Is it supposed to append a fake quota reclamation record to the folder history? If so, I'm not sure I understand what you're trying to do with the `forceQR` command. Is it supposed to append a fake quota reclamation record to the folder history? If so, I'm not sure I understand what you're trying to do with the `forceQR` command. Is it supposed to append a fake quota reclamation record to the folder history? If so, I'm not sure I understand what you're trying to do with the `forceQR` command. Is it supposed to append a fake quota reclamation record to the folder history? If so, I'm not sure I understand what you're trying to do with the `forceQR` command. Is it supposed to append a fake quota reclamation record to the folder history? If so, I'm not sure I understand what you're trying to do with the `forceQR` command. Is it", + "prediction": "I'm not sure if this is the best place to put it, but I think we should move it to the top of the file.", "reference": "isn't the usual capitalization for subcommands force-qr? (don't care too much about it)" }, { - "prediction": "I'm not sure what you mean by \"constant types known at compile time to allow native-image behavior to match hotspot\"", + "prediction": "I'm not sure if this is the right place to add this check, but I think it would be good to add this check to the `java.lang.reflect.Proxy` class.", "reference": "Do you know how many repos have hit this?" }, { @@ -17663,31 +17663,31 @@ "reference": "I'll be interested to see if our gettext rake tasks will pick up on this text to translate" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `LuaScriptInterface` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the `LuaScriptInterface` class as well.", "reference": "I think you need to change line 928 value from 6 to 7 too, since now table will have 7 values" }, { - "prediction": "I think this test is a bit misleading. It should be `assert set(f2.names) == {\"cat\", \"dog\", \"mouse\", \"dog\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse", + "prediction": "I think this test is a bit misleading. It should be `assert set(f2.names) == {\"cat\", \"dog\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse\", \"mouse", "reference": "Does `f0[::-1, :]` mean all the rows taken in a reverse order?" }, { - "prediction": "I'm not sure what you're trying to say here.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to make sure that we don't break anything. I think it's a good idea to make sure that we don't break anything. I think it's a good idea to make sure that we don't break anything. I think it's a good idea to make sure that we don't break anything. I think it's a good idea to make sure that we don't break anything. I think it's a good idea to make sure that we don't break anything. I think it's a good idea to make sure that we don't break anything. I think it's a good idea to make sure that we don't break anything. I think it's a good idea to make sure that we don't break anything. I think it's a good idea to make sure that we don't break anything. I think it's a good idea to make sure that we don't break anything. I think it's a good idea to make sure that we don't break anything. I think it's a good idea to make sure that we don't break anything. I think it's a good idea to make sure that we don't break anything. I think it's a good", "reference": "Looks like there are strange characters here." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to pause the experiment, but you're not actually pausing the experiment, you're pausing the controller. If you want to pause the controller, you need to pause the controller first.", + "prediction": "I don't think we need to do this.", "reference": "It is better to have a check to ensure the format is valid." }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good idea to add a `next` parameter to the `MethodTemplateModel` constructor, so that the caller can decide whether or not to use the `NextAlreadyDefined` property.", + "prediction": "I'm not sure if this is the best place to put this, but I think it would make sense to put it in the `MethodTemplateModel` constructor.", "reference": "How about `nextAlreadyDefined` variable name in method signature?" }, { - "prediction": "I'm not sure what you're trying to achieve with this test, but I think it's a bit misleading. The number of calls to the payload should be the same as the number of calls to the payload from the client, right?", + "prediction": "I don't think we need to change the number of calls here.", "reference": "In older SDK versions the data converter was called 3 times but now it is 2. This is because logic was changed deep in the interceptor chains on when values are serialized and encoded and such. Previously we invoked the data converter on results _even if there was an error_ (and most of the time they were nil). Now we don't do such a thing, resulting in fewer calls." }, { - "prediction": "I think we should remove the `gcp` package from the `main` package. It's not used anywhere in the code.", + "prediction": "I'm not sure why we need to load the gcp plugin here. It's only required to authenticate against GKE clusters.", "reference": "formatting... can this import go next to the other sources ones?" }, { @@ -17695,23 +17695,23 @@ "reference": "I don't understand why anyone would pass 0? If you don't want to attach to an existing process you just wouldn't pass -attach. I would remove that sentence and make 0 an invalid argument." }, { - "prediction": "I don't think we need to use `volatile` here. We can just use `const` here.", + "prediction": "I don't think this is necessary. The `s_current_reduce_size` is only used in `s_current_reduce` and `s_current_reduce_size` is only used in `s_current_reduce` and `s_current_reduce_size` is only used in `s_current_reduce` and `s_current_reduce_size` is only used in `s_current_reduce` and `s_current_reduce_size` is only used in `s_current_reduce` and `s_current_reduce_size` is only used in `s_current_reduce` and `s_current_reduce_size` is only used in `s_current_reduce` and `s_current_reduce_size` is only used in `s_current_reduce` and `s_current_reduce_size` is only used in `s_current_reduce` and `s_current_reduce_size` is only used in `s_current_reduce` and `s_current_reduce_size` is only used in `s_current_reduce` and `s_current_reduce_size` is only used in `s_current_reduce` and `s_current_reduce_size` is only used in `s_current_reduce` and `s_current_reduce_size` is only used in `s_current_reduce` and `s_current_reduce_size` is only used in `s_current_reduce` and `s_current_reduce_size` is", "reference": "This change is responsible for #2775" }, { - "prediction": "I'm not sure what you mean by \"exception_type:CustomException1\" and \"exception_type:CustomException2\". Could you please provide more context?", + "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.", "reference": "Should we add this to the other \"never\" verification in lines 71-73 above, too?" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's better to use `self.dao.iter_cai_assets` instead of `list(self.dao.iter_cai_assets(...))`.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `self.session` instead of `self._session` in this case.", "reference": "Fixed this since it no longer needed to be switched from a generator to a list, this was missed when I cleaned up the dataset code in an earlier PR." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure I understand what you're trying to do here.", "reference": "This is an informational message that allows someone to read the console output and understand how the grid node is configured. Please leave." }, { - "prediction": "I think this should be `name_id` instead of `name_id_id`?", + "prediction": "I think this should be `WHERE name_id IN (#{name_id.to_i})` instead of `WHERE name_id IN (#{name_id.to_i}) OR name_id IN (#{name_id.to_i})`", "reference": "Can we convert this to an arel as below ContributorFact .joins(:project).where(projects: { id: project_id}) .where('name_id = ? or name_id in (?)', name_id, AnalysisAlias.select(:preferred_name_id) .joins(:project) .where(commit_name_id: name_id) )" }, { @@ -17719,15 +17719,15 @@ "reference": "Does this cause issues if you have lots of load on the machine? Having a global variable for this seems like a bad idea IMO." }, { - "prediction": "I think this should be `if (privacyPublicKeyFile() != null)` instead of `if (privacyPublicKeyFile() != null)`", + "prediction": "I think this should be `if (privacyPublicKeyFile() != null)` instead of `if (privacyPublicKeyFile() != null) {`", "reference": "We probably don't need to print the msg with e.getMessage(). It will be printed by the logger since we are passing the exception as a parameter." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to patch `Testinfra._get_tests` here.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to make sure that the `molecule.verifier.testinfra.Testinfra._get_tests` function is called before the tests are run.", "reference": "Can we get a test with multiple directories as per the initial example?" }, { - "prediction": "I think we can remove the `if obj and obj.role == controlTypes.ROLE_STATUSBAR:` line.", + "prediction": "I think this should be `obj = getDesktopObject().objectFromPoint(left, bottom)` instead of `obj = getDesktopObject().objectFromPoint(left, bottom - 1)`.", "reference": "I assume this is because you were seeing cases where left was a negative number? When?" }, { @@ -17735,23 +17735,23 @@ "reference": "this is undoing recent changes for increased consistency of include file statements. please restore to the original." }, { - "prediction": "I'm not sure what you mean by \"PreferBuiltInConcurrentKeySet\" and \"PreferCollectionTransform\"", + "prediction": "I'm not sure if this is the right place to add these checks, but I think it's a good idea to add them.", "reference": "If these are applied in order, should `LambdaMethoReference` come after `OptionalOrElseMethodInvocation`" }, { - "prediction": "I'm not sure what you're trying to do here, but I think it's a bad idea to have a `Dictionary>` in the `SarifDocument` class. It's not clear what you're trying to do here.", + "prediction": "I'm not sure what you're trying to do here, but I don't think this is the right place to do it.", "reference": "Why this rename?" }, { - "prediction": "I think this should be `if mock_main and sys.version_info < (3, 3)` instead of `if mock_main and sys.version_info < (3, 3)`.", + "prediction": "I think this should be `if mock_main and sys.version_info < (3, 3):`", "reference": "Why do we do this check here? `sys.version_info` cannot be less than 3.3 as pylint does not support older versions. I think we should avoid popping `__main__` altogether." }, { - "prediction": "I'm not sure if this is the right place to add the `--verbose` and `--debug` options. The `--verbose` and `--debug` options should be added to the `serv_cmd` function, not to the `pg_db_config` dictionary.", + "prediction": "I'm not sure why we need to add `--verbose` to `server_cmd` here. It's already there in the `serv_cmd` function. Is there a reason to add it here?", "reference": "This can be removed too." }, { - "prediction": "I think this should be `if head != nil && head.MD.CheckValidSuccessorForServer(md.config.Crypto(), &rmds.MD)`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `md.config.Crypto()`, and if it returns `nil` then we should return an error.", "reference": "I'm a little worried about the new extra calls to `MakeMdId`, since in most local-server KBFS profiles, hashing is the biggest CPU user, and not re-using the value calculated by the client will result in even more hashing. That said, I understand why you did it this way, and I don't have a concrete suggestion on how to make it better. Just something to keep in mind; plus it might be worth comparing the test speed before and after this change to make sure it didn't slow things down too much." }, { @@ -17759,7 +17759,7 @@ "reference": "`lodash` shouldn't be grouped under WordPress dependencies" }, { - "prediction": "I don't think this is a good idea. It's not clear to me what this is supposed to do.", + "prediction": "I don't think we need to change this.", "reference": "Just curious, but how did you work out that Aleksey Sadovoy, Peter Vgner and Joseph Lee contributed to this file? Did you look at the repository history?" }, { @@ -17775,19 +17775,19 @@ "reference": "This command rolls back the volume data to the specified snapshot. Once the roll back to snapshot is successful, all the data changes made after the snapshot was taken will be post. This command should be used cautiously and only when there is an issue with the current state of the data." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to make sure that the `containerId` is the same as the `containerId` in the `awslogsLogGroupName` string.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to make sure that the `containerId` matches the `containerId` in the `awslogsLogGroupName` string.", "reference": "should this be a separate/new functional test?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I'm not sure what you're trying to achieve here. I think you're trying to test that the query cache is working correctly when the batch size is set. But I'm not sure what you're trying to achieve here. I think you're trying to test that the query cache is working correctly when the batch size is set. But I'm not sure what you're trying to achieve here. I think you're trying to test that the query cache is working correctly when the batch size is set. But I'm not sure what you're trying to achieve here. I think you're trying to test that the query cache is working correctly when the batch size is set. But I'm not sure what you're trying to achieve here. I think you're trying to test that the query cache is working correctly when the batch size is set. But I'm not sure what you're trying to achieve here. I think you're trying to test that the query cache is working correctly when the batch size is set. But I'm not sure what you're trying to achieve here. I think you're trying to test that the query cache is working correctly when the batch size is set. But I'm not sure what you're trying to achieve here. I think you're trying to", "reference": "Can these also assert at least the length of arrays returned and ideally contents?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a default value for `param_visibilities` if it's not set.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the `__init__` method of the `Task` class, so that we don't have to do this in the `__init__` method of the `Scheduler` class.", "reference": "`hasattr(task, 'param_visibilities')` is more concise with the same effect, but either one works." }, { - "prediction": "I'm not sure I understand what you're trying to say here. Is there a specific reason for this change?", + "prediction": "I'm not sure I understand what you're trying to say here. Is this a bug in Python 2 or Python 3? If it's a bug in Python 2, then I'm not sure I understand what you're trying to say here. If it's a bug in Python 3, then I'm not sure I understand what you're trying to say here. Is this a bug in Python 2 or Python 3? If it's a bug in Python 2, then I'm not sure I understand what you're trying to say here. If it's a bug in Python 3, then I'm not sure I understand what you're trying to say here. Is this a bug in Python 2 or Python 3? If it's a bug in Python 2, then I'm not sure I understand what you're trying to say here. If it's a bug in Python 3, then I'm not sure I understand what you're trying to say here. Is this a bug in Python 2 or Python 3? If it's a bug in Python 2, then I'm not sure I understand what you're trying to say here. If it's a bug in Python 3, then I'm not sure", "reference": "I would hedge this a little, maybe `Positional arguments appear to be out of order`. After all, it's just a guess." }, { @@ -17795,27 +17795,27 @@ "reference": "you can directly call show() method from **SnackBarHandler.show(coordinatorLayout, getString(no_account_signed_in)).show();** no need to create an extra object and then call the show method." }, { - "prediction": "I think we can remove the `int32_t` from the `ipFromHostAddr` function.", + "prediction": "I think we can remove the `if (!hostsString.empty())` here.", "reference": "concatHosts may be a better func name to explain this?" }, { - "prediction": "I think this should be `RA.stubString` instead of `RA.stubString(1, 2, 3)`.", + "prediction": "I think this should be `always('')` instead of `always('') => ''`", "reference": "A function that returns empty string." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if `filename` is empty. If it is, then we should just return an error.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `state.Config.FeatureFlags.RemovePleasings` to make sure we don't try to parse a file that doesn't exist.", "reference": "If it's not the root package, or if it is the root package but we don't add the psudo :pleasings rule there, print an error." }, { - "prediction": "I'm not sure what you mean by this, but I think it's a good idea to add a comment at the top of the file to explain the purpose of this code.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use the `metav1` package here. I think it's a good idea to use the `metav1` package here. I think it's a good idea to use the `metav1` package here. I think it's a good idea to use the `metav1` package here. I think it's a good idea to use the `metav1` package here. I think it's a good idea to use the `metav1` package here. I think it's a good idea to use the `metav1` package here. I think it's a good idea to use the `metav1` package here. I think it's a good idea to use the `metav1` package here. I think it's a good idea to use the `metav1` package here. I think it's a good idea to use the `metav1` package here. I think it's a good idea to use the `metav1` package here. I think it's a good idea to use the `metav1` package here. I think it's a good idea to use the", "reference": "can delete this line" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in `get_minibatch_index_vector` as well.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `get_minibatch_index_vector` function.", "reference": "Will it still be an issue if all the models use the same data set?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `WidgetsController` class, so that it can be used by other controllers as well.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to move this to `WidgetsController` instead of `WidgetsController#handle_xml_format`.", "reference": "How does this controller_name method work? Does this method grab the context of the url request? Wouldn't this always result in 'widget'?" }, { @@ -17823,15 +17823,15 @@ "reference": "Let's get rid of these for the final version and if you get rid of the macro I left last time I'd be more than grateful." }, { - "prediction": "I don't think we need to use `Integer.MAX_VALUE - 3` for `DELETE_MARK`.", + "prediction": "I don't think we need to change this.", "reference": "Instead of `DELETE_MARK`, how about `IS_DELETED`? I don't think that \"mark\" is clear enough to describe what this is. Similarly, I think the docs should be \"Whether the row has been deleted\". There's no need to include \"delete mark\" because that's identifying something that is not defined (this column is _deleted and \"mark\" is not introduced), and \"or not\" is unnecessary because it is implied by \"whether\"." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way", + "prediction": "I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way", "reference": "Does it make sense to have this very thin wrapper that only calls `create_dependencies`? And maybe having `create_dependencies` return a set would be better than convert here?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `h2o_iovec_t` for this purpose.", + "prediction": "I think this should be `size_t num_parts = 4;` instead of `size_t num_parts = 0;`", "reference": "How about renaming `escape` to `use_path_normalized` or something to better indicate that it is a selection between `path` and `path_normalized`?" }, { @@ -17839,39 +17839,39 @@ "reference": "Interface members are always `static final` right?" }, { - "prediction": "I think this should be `unsafe.Sizeof` instead of `unsafe.Sizeof(size)`.", + "prediction": "I think this should be `unsafe.Sizeof` instead of `unsafe.Sizeof(uint64)`.", "reference": "It seems to me that this could be in the runtime_nintendoswitch.go file, or is there a reason to keep it separate?" }, { - "prediction": "I think it's better to have a separate function for this, so that we don't have to call it multiple times.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to call `swift::performSILLinking(sil_module.get());` after the `swift::performSILLinking(sil_module.get());` in the previous line. This way, we don't need to call `swift::performSILLinking(sil_module.get());` again.", "reference": "I was actually looking at this code over the weekend and wondering whether we were trying to link here. I assume it's been cargo culted from something else in the compiler." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `data-toggle` attribute on the checkbox.", + "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use the `data-toggle` attribute on the `checkbox` element.", "reference": "nice extraction of the form for being used at new/edit. We should have more of these" }, { - "prediction": "I'm not sure what you mean by \"s1, s2, s3, s4, s5, s6\". I think you meant \"s1, s2, s3, s4, s5, s6, s7, s8, s9, s10, s11, s12, s13, s14, s15, s16, s17, s18, s19, s20, s21, s22, s23, s24, s25, s26, s27, s28, s29, s30, s31, s32, s33, s34, s35, s36, s37, s38, s39, s40, s41, s42, s43, s44, s45, s46, s47, s48, s49, s50, s51, s52, s53, s54, s55, s56, s57, s58, s", + "prediction": "I'm not sure what you mean by \"format\" in this context. Is it the way the potential is written out?", "reference": "Are the coefficients the actual bug fix?" }, { - "prediction": "I think this should be `except (psycopg2.ProgrammingError, psycopg2.IntegrityError) as e:`", + "prediction": "I think this should be `if e.pgcode in [psycopg2.errorcodes.DUPLICATE_TABLE, psycopg2.errorcodes.UNIQUE_VIOLATION]` instead of `if e.pgcode == psycopg2.errorcodes.DUPLICATE_TABLE`", "reference": "Why are the error code options in a list and not a tuple?" }, { - "prediction": "I think it's a good idea to add a test for the `Project` and `Folder` classes.", + "prediction": "I'm not sure if this is the best way to test this, but I think it would be good to add a test for this.", "reference": "Need alignment with the preceding line." }, { - "prediction": "I don't think this is a good idea. We should use `GenesisConfigFile.getMainnetConfigOptions()` instead of `GenesisConfigFile.mainnet().getConfigOptions()`.", + "prediction": "I'm not sure if this is a good idea, but I think it would be better to use the `GenesisConfigFile.getMainnetConfigOptions()` instead of `GenesisConfigFile.mainnet().getConfigOptions()`.", "reference": "Changing from a static method to a constant is inessential to Type Transactions and has a long reach, adding many unneeded files and diff lines." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you want to use `TreeSet` here. You want to use `TreeMap` instead.", + "prediction": "I'm not sure if this is a good idea, but I think it would be a good idea to add a method to `TreeSet` that takes a `Comparator` and returns a `TreeSet` that is sorted by the given comparator.", "reference": "There is one caveat: javaslang.collection.Iterator is Iterable. With Iterator it does not work. Let's revert this line. Does this happen elsewhere, too? I will double-check the code..." }, { - "prediction": "I'm not sure what you mean by \"whitespaces\" in this context. I think you meant to say \"whitespaces=True\" instead of \"whitespaces=False\".", + "prediction": "I don't think whitespaces is needed here.", "reference": "Why change the default value of `is_diff`?" }, { @@ -17879,11 +17879,11 @@ "reference": "I think tacking on `,<7` would be a wise precaution in case of future incompatible changes in tenacity." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a method to `GalleryManagerInterface` that does this.", + "prediction": "I think this should be `null` instead of `?`", "reference": "I don't think is necessary to remove the return type" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check to make sure that the client secret is not null before trying to decrypt it with the passcode.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check to see if the client secret is null, and if it is, throw an exception.", "reference": "Also added this check, since client secret is not used except in the IP bypass scenario." }, { @@ -17891,11 +17891,11 @@ "reference": "That's unrelated, but shouldn't there also be a call to `setInternalWebPropertyID`, making it empty, for this case? Otherwise, when selecting to create a new property, any previous internal web property ID will still be in state, potentially causing problems." }, { - "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea.", + "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to run this test. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to run this test. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to run this test. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to run this test. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to run this test. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to run this test. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to run this test. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to run this test. It's not clear what you're trying to achieve with this test, but I", "reference": "I wonder if we should trigger a PHP error and ensure it ends up in the log?" }, { - "prediction": "I'm not sure what you're trying to do with this test, but I'm not sure if it's a good idea.", + "prediction": "I'm not sure what you mean by \"this test is off\"", "reference": "The `move_topic` action be a `post` request since it changes the state of the object." }, { @@ -17907,15 +17907,15 @@ "reference": "Noticing this is really just the same as cart_notification_email. Would be nice to be able to view custom templates. I may update this with some set up that will make viewing specific custom emails easily." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a new collection with the same name as the existing one, but with a different path. Is that what you're trying to do?", + "prediction": "I don't think this is needed.", "reference": "please don't use wildcard imports" }, { - "prediction": "I'm not sure what you mean by `sourceDataReference = null;`", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `sourceDataReference` instead of `sourceData` in this case.", "reference": "Should we even fix this test? IMO it should be refactored to check that values are recalculated after `setSourceDataAtCell` and `setSourceDataAtRowProp` calls. This will be the correct way to alter the data since now and we're not testing this use case." }, { - "prediction": "I'm not sure what you mean by \"remember the last used directory\". I think you meant to say `last_used_directory = None`", + "prediction": "I don't think this is needed anymore.", "reference": "I'm not sure if this is standard practice, but I would prefer to leave this initialization here, if only to show that such a variable exists in this file (instead of inferring it from the globals). It can also cause weird issues if, for example, `init` isn't run before other methods." }, { @@ -17923,59 +17923,59 @@ "reference": "This isn't how you throw an exception in C++. I'd suggest you take a look elsewhere in the RDKit C++ codebase and see how ValueError exceptions are thrown. Hint: there's a function called `throw_value_error()` that you may find useful." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to verify that the block was updated in the ledger, but I'm not sure what you're trying to do here. I think you're trying to verify that the block was updated in the ledger, but I'm not sure what you're trying to do here. I think you're trying to verify that the block was updated in the ledger, but I'm not sure what you're trying to do here. I think you're trying to verify that the block was updated in the ledger, but I'm not sure what you're trying to do here. I think you're trying to verify that the block was updated in the ledger, but I'm not sure what you're trying to do here. I think you're trying to verify that the block was updated in the ledger, but I'm not sure what you're trying to do here. I think you're trying to verify that the block was updated in the ledger, but I'm not sure what you're trying to do here. I think you're trying to verify that the block was updated in the ledger, but I'm not sure what you're trying to do here. I think you're trying to verify that the block was updated", + "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", "reference": "Was changing this to a write transaction required?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a `PaymentVoucher` struct with a `Params` field, but I'm not sure what you're trying to do with it. I think you're trying to create a `PaymentVoucher` struct with a `Params` field, but I'm not sure what you're trying to do with it. I think you're trying to create a `PaymentVoucher` struct with a `Params` field, but I'm not sure what you're trying to do with it. I think you're trying to create a `PaymentVoucher` struct with a `Params` field, but I'm not sure what you're trying to do with it. I think you're trying to create a `PaymentVoucher` struct with a `Params` field, but I'm not sure what you're trying to do with it. I think you're trying to create a `PaymentVoucher` struct with a `Params` field, but I'm not sure what you're trying to do with it. I think you're trying to create a `PaymentVoucher` struct with a `Params` field, but I'm not sure what you're trying to do with it", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a `PaymentVoucher` that can be transferred off-chain but guarantees a future payment. Is this what you're trying to do? If so, I'm not sure what you're trying to do here. I think you're trying to create a `PaymentVoucher` that can be transferred off-chain but guarantees a future payment. Is this what you're trying to do? If so, I'm not sure what you're trying to do here. I think you're trying to create a `PaymentVoucher` that can be transferred off-chain but guarantees a future payment. Is this what you're trying to do? If so, I'm not sure what you're trying to do here. I think you're trying to create a `PaymentVoucher` that can be transferred off-chain but guarantees a future payment. Is this what you're trying to do? If so, I'm not sure what you're trying to do here. I think you're trying to create a `PaymentVoucher` that can be transferred off-chain but guarantees a future payment. Is this what you're trying to do? If so, I'm not sure what you're trying to do here", "reference": "nit: I think \"They\"?" }, { - "prediction": "I think this should be `ValidatorRegistryLimit = 1_099_511_627_776` instead of `ValidatorRegistryLimit = 1_099_511_627_776`", + "prediction": "I think this should be `ValidatorRegistryLimit = 1099511627776`", "reference": "is it a result of some multiplication or some other meaningful number? would be nice to display as a power of something or the mult" }, { - "prediction": "I'm not sure what you're trying to do here, but I think it's a bit of a mix-up. `ALL_FEATURES` should be `GENERIC_FEATURES + LICENSEABLE_FEATURES + FULFILLABLE_FEATURES`, not `GENERIC_FEATURES + LICENSEABLE_FEATURES + FULFILLABLE_FEATURES`.", + "prediction": "I'm not sure I understand what you're trying to do here. The `ALL_FEATURES` variable is a list of all the features that are available, and the `GENERIC_FEATURES` variable is a list of all the features that are available by default. If you want to add more features to the `ALL_FEATURES` variable, do you mean to add them to the `GENERIC_FEATURES` variable, or do you mean to add them to the `ALL_FEATURES` variable? If you mean to add them to the `GENERIC_FEATURES` variable, then I'm not sure I understand what you're trying to do here. If you mean to add them to the `ALL_FEATURES` variable, then I'm not sure I understand what you're trying to do here.", "reference": "I think this class is a good example of where Payload could significantly improve things. I'm okay with this class as it stands. If you merge this in, I'd like to have a go at refactoring it after introducing Payload." }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good idea to move this to a separate file, so that it can be tested separately.", + "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to add a test for this in the `colander` test suite.", "reference": "Just a small tip: I think you don't need to include pytest here. You can run tests using: - `pytest tests/path/to/my/test` under the virtualenv to run a single test. - `pytest tests/` under the virtualenv to run all the tests. - `make tests` to run all the tests for all python versions, like travis do. Hope this helps! :)" }, { - "prediction": "I'm not sure what you're trying to do with this. It seems like you're trying to create a reference to an object, but I'm not sure what you're trying to do with it.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `__repr__` method for this class.", "reference": "Might be worth sorting the replacement items so this is deterministic." }, { - "prediction": "I don't think we need to use `default:\"true\"` for `ClusterScoped` as it's already `true` by default.", + "prediction": "I don't think we need to use `default:\"true\"` for `ClusterScoped`.", "reference": "Should we set the default `TargetNamespace ` to `chaos-testing`? I noticed that the installation script defaults to chaos-testing." }, { - "prediction": "I think this should be `await Task.Yield();` instead of `await Task.Yield();`", + "prediction": "I don't think this is a good idea. It's not a good idea to use `await Task.Yield();` in a `try-catch` block. It's not a good idea to use `await Task.Yield();` in a `try-catch` block. It's not a good idea to use `await Task.Yield();` in a `try-catch` block. It's not a good idea to use `await Task.Yield();` in a `try-catch` block. It's not a good idea to use `await Task.Yield();` in a `try-catch` block. It's not a good idea to use `await Task.Yield();` in a `try-catch` block. It's not a good idea to use `await Task.Yield();` in a `try-catch` block. It's not a good idea to use `await Task.Yield();` in a `try-catch` block. It's not a good idea to use `await Task.Yield();` in a `try-catch` block. It's not a good idea to use `await Task.Yield();` in a `try-catch` block. It's not a good idea", "reference": "Why was this `Task.Yield` removed? It was added in purpose." }, { - "prediction": "I'm not sure what you mean by `requiredFieldConfigs` and `optionalFieldConfigs` here. I think they should be `requiredFieldConfigs` and `optionalFieldConfigs` respectively.", + "prediction": "I don't think we need to change the `requiredFieldConfigs` here. The `requiredFieldConfigs` should be the same as the `requiredFieldConfigs` in the `MethodConfig` class.", "reference": "You'll also want to do this below, for the `optionalFieldConfigs`. See `GapicMethodConfig.java:180`." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `prepareOver` function.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this", "reference": "We'd better use \"spaceId\" as variable name here. Because i can't figure out the really type for \"space\" at the first glimpse due to \"auto\" used." }, { - "prediction": "I think we can remove the `RootDirectory` from the `BuildDataDirectory` and `WindowsTracerHomeZip` paths.", + "prediction": "I think it's better to use `RootDirectory / \"packages\" / \"libsqreen.1.1.2.2\"` instead of `RootDirectory / \"packages\" / \"libsqreen.1.1.2.2.1.1.2.2.1.1.2.2.1.1.2.2.1.1.2.2.1.1.2.2.1.1.2.2.1.1.2.2.1.1.2.2.1.1.2.2.1.1.2.2.1.1.2.2.1.1.2.2.1.1.2.2.1.1.2.2.1.1.2.2.1.1.2.2.1.1.2.2.1.1.2.2.1.1.2.2.1.1.2.2.1.1.2.2.1.1.2.2.1.1.2.2.1.1.2.2.1.1.2.2.1.1.2", "reference": "I assume we have a package reference somewhere that pulls down the nuget package?" }, { - "prediction": "I think this should be `if err != nil { s.Errorf(\"Error setting up internal tracking for %s: %v\", subject, err) }` instead of `s.Errorf(\"Error setting up internal tracking for %s: %v\", subject, err)`", + "prediction": "I think this should be `if err != nil { s.Errorf(\"Error setting up internal tracking for %s: %v\", subject, err) }`", "reference": "But why introduce publish on `accConnsEventSubjNew` subject if we never subscribe on that subject. What is the plan then? Replace subscription on \"old\" with \"new\" at one point? Not sure about all that.." }, { - "prediction": "I think this should be `fpga_token fme_token = NULL;` instead of `fpga_token fme_token;`", + "prediction": "I think it's better to use `fpga_token_t` instead of `fpga_token` in this case.", "reference": "can we use `nullptr` for consistency?" }, { - "prediction": "I don't think this is necessary. The `routersByDomainId` array should be an array of `\\Shopsys\\FrameworkBundle\\Component\\Router\\DomainRouter` objects.", + "prediction": "I don't think this is needed anymore.", "reference": "strange, for templating\\EngineBundle it was `\\Symfony\\Bundle\\FrameworkBundle\\`" }, { @@ -17983,23 +17983,23 @@ "reference": "But if we're on the merge deployment, and the next one is the booted deployment, we'll still be inserting between the merge and booted deployment, right? It seems like we would need e.g. `met_merge` and `met_booted` vars to keep track." }, { - "prediction": "I think this should be `return axe.utils.tokenList(virtualNode.attr('role')).filter(role => !axe.commons.aria.isValidRole(role, { allowAbstract: true })).length > 0`", + "prediction": "I think this should be `return axe.utils.tokenList(virtualNode.attr('role')).filter(role => !axe.commons.aria.isValidRole(role, {allowAbstract: true})).length > 0`", "reference": "Can you put the output of this into data, and list which roles are invalid? Same thing with abstract role. I know that's not strictly part of this PR, but it'd make the messaging about this a bunch better." }, { - "prediction": "I think this should be `this.ibftTwo` instead of `this.ibftTwo = ibftTwo`", + "prediction": "I think this should be `final Map proposers;` instead of `final Map proposers; final Map proposers;`", "reference": "rename ibftTwo arg to bft" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to `Blacklight::SearchContext` so that it can be used in other places as well.", + "prediction": "I think this should be `if agent_is_crawler? || skip_session_tracking?` instead of `if params[:search_context].present?`", "reference": "Should we go ahead and push `agent_is_crawler?` into the `skip_session_tracking?` method?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check for the existence of the proposal file.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check to see if the file exists before trying to load the annotations.", "reference": "How about we raise a warning here and simply change to use self.data_infos = self.load_annotations(self.ann_file)" }, { - "prediction": "I think this should be `time.sleep(1)` instead of `time.sleep(0.1)`.", + "prediction": "I think we should remove the `import time` and `import nvwave` from the synthDrivers/_espeak.py file. The `time` and `nvwave` modules are not used in the synthDrivers/_espeak.py file.", "reference": "Please remove this line to comply with the standard for copyright headers." }, { @@ -18007,79 +18007,79 @@ "reference": "seems incorrect - for 5 validators it will tell that 3 is enough to seal and you need 4 2/3 * 5 is 3.3" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to use the `Caffeine` class to cache the results of a `List` of `Map` objects, but I'm not sure what you're trying to do with the `List` of `Map` objects. I think you're trying to use the `Caffeine` class to cache the results of a `List` of `Map` objects, but I'm not sure what you're trying to do with the `List` of `Map` objects. I think you're trying to use the `Caffeine` class to cache the results of a `List` of `Map` objects, but I'm not sure what you're trying to do with the `List` of `Map` objects. I think you're trying to use the `Caffeine` class to cache the results of a `List` of `Map` objects, but I'm not sure what you're trying to do with the `List` of `Map` objects. I think you're trying to use the `Caffeine` class to cache the results of a `List` of `Map` objects, but I'm not sure what you're trying to do", + "prediction": "I'm not sure if this is a good place to put this, but I think we should move it to the `org.apache.iceberg.hive` package, since it's not part of the `org.apache.iceberg` package. Also, I think we should move it to the `org.apache.iceberg.hive` package, since it's not part of the `org.apache.iceberg` package. Also, I think we should move it to the `org.apache.iceberg.hive` package, since it's not part of the `org.apache.iceberg` package. Also, I think we should move it to the `org.apache.iceberg.hive` package, since it's not part of the `org.apache.iceberg` package. Also, I think we should move it to the `org.apache.iceberg.hive` package, since it's not part of the `org.apache.iceberg` package. Also, I think we should move it to the `org.apache.iceberg.hive` package, since it's not part of the `org.apache.iceberg` package. Also, I think we should move it to the `org.apache.iceberg.hive` package,", "reference": "Nit: please remove unnecessary whitespace changes." }, { - "prediction": "I think we should rename this to `resource_` instead of `resource`.", + "prediction": "I think we should rename this field to `resource_` instead of `resource`.", "reference": "Is this captured in a test?" }, { - "prediction": "Shouldn't this be `ScorerLeafCollector` instead of `ScorerLeafCollectorLeafCollector`?", + "prediction": "Shouldn't this be `ScorerLeafCollector` instead of `ScorerLeafCollector`?", "reference": "This is used in o.a.l.sandbox.search.LargeNumHitsTopDocsCollector." }, { - "prediction": "I don't think we need to set `lr_config` here. We can just use `lr_policy='step'` and `lr_config=dict(step=[8, 11])`.", + "prediction": "`lr_config = dict(policy='step', warmup='linear', warmup_iters=500, warmup_ratio=1.0 / 3, step=[8, 11])`", "reference": "We may also do the same for `schedule_2x.py` and `schedule_20e.py`." }, { - "prediction": "I'm not sure what you mean by \"has_and_belongs_to_many\"", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a `diary_entries_subscriptions` table with a foreign key to `diary_entries` and a foreign key to `diary_entries_subscribers`.", "reference": "Should foreign key here be something like `diary_entry_id`? Or above, in `diary_entry.rb`, it should be `diary_entry_id`?" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `initiatedChildExecutionsInSession` map.", + "prediction": "I don't think this is necessary.", "reference": "session is a new term. Should we call more like currentCommandBatch or something else?" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a new namespace with a unique ID, but you're also trying to create a namespace with a unique ID that already exists.", + "prediction": "I'm not sure what you mean by `namespacepb.NamespaceStatus_Registered`. Is that the same as `namespacepb.NamespaceStatus_Enabled`?", "reference": "Will go fmt before squash." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right way to do it.", + "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.", "reference": "Setting this to `true` means that it will always get merged in. The way merging is done here is that if a value is its zero value (`false` for `bool`), the value is considered unchanged. In order for this to work, you'll need to change this to be a `*bool` type instead." }, { - "prediction": "I'm not sure if this is the right place to put this. I think we should put it in the `MiningConfig` struct, but I'm not sure if that's the best place to put it.", + "prediction": "I'm not sure if this is the right place to put it. I think we should put it in the `MiningConfig` struct, but I'm not sure if that's the right place to put it.", "reference": "It was decided that blockSignerAddress is not only redundant (use the miner owner public key instead which is already stored), but does not belong in config." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you want to use `jsonschema==3.*` in your `setup.py` file. I think you want to use `jsonschema>=3.0.0` instead.", + "prediction": "I'm not sure what you mean by \"pyarrow\" in the extras_require. I think it should be `pyarrow>=1.0.0`", "reference": "are we not asking for trouble here by not pinning this? or does 3.* imply all of the draft versions we'd try to validate?" }, { - "prediction": "I'm not sure what you mean by \"temporalImp=\"tm_py\" here is a temporary placeholder value until C++ TM is finished, at which point it should be changed to \"cpp\"", + "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to change the value of `temporalImp` to `cpp` in this test.", "reference": "No, we want to compare `tm_py` and `tm_cpp` in this test." }, { - "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea to add it to the docs.", + "prediction": "I don't think we need to change this.", "reference": "Let me know if we'd rather have this as an env variable." }, { - "prediction": "I don't think we need to use `fmt.Sprintf` here. We can just use `namespace` and `serviceAccountName` directly in the `NewVaultServiceAccountRole` function.", + "prediction": "I don't think we need to use `fmt.Sprintf` here. We can just use `namespace` and `serviceAccountName` directly.", "reference": "question: what is happening here?" }, { - "prediction": "I don't think this is necessary. The `emptyWithNull` method is already defined in the `AbstractSet` class, so we don't need to define it again.", + "prediction": "I don't think this is necessary. The `emptyWithNull` method is already defined in the `AbstractSet` class.", "reference": "\\[Checkstyle\\] ERROR: 'protected' modifier out of order with the JLS suggestions\\." }, { - "prediction": "I'm not sure what you mean by \"not included as part of the YAML tests\". I think it's just that we don't want to include them in the YAML tests.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this. I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this. I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this. I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this. I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this. I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this. I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this. I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this. I'm not sure if this is the", "reference": "Can we use EJSON from bson here? and in doing so avoid bringing in the deprecated `mongodb-extjson` lib `const { EJSON } = require('bson')`" }, { - "prediction": "I'm not sure what you're trying to do with the `tick_format` parameter. It's not clear what it's supposed to do. Is it supposed to be used to format the tick labels, or is it supposed to be used to format the tick marks? If it's supposed to be used to format the tick labels, then I'm not sure what you're trying to do with it. If it's supposed to be used to format the tick marks, then I'm not sure what you're trying to do with it.", + "prediction": "I don't think this is a good idea. I think it's better to use the `tick_format` parameter to control the formatting of the tick labels.", "reference": "So this parameter is now deprecated?" }, { - "prediction": "I'm not sure what you mean by \"registered for current thread\". I think it's more like \"registered with current thread\" or something like that.", + "prediction": "I'm not sure what you mean by \"registered for current thread\". I think it's more like \"registered with current thread\".", "reference": "Actually, it looks like HAVE_RSEQ is only used to determine whether the rseq.h header is around, which then only determines whether the regression test is built: it does not affect whether the core handles an application using rseq. The core rseq mangling code and all the code in rseq_linux.c is always enabled. I believe the idea is that we want DR built on one machine to work on as many others as possible, rather than requiring a custom build for every variant of kernel feature or whatnot. What is the top-level problem being solved here? If it requires disabling or enabling the core handling rseq, probably a separate option should be put in place and maybe HAVE_RSEQ renamed to make it clearer what its consequences are." }, { - "prediction": "I don't think this is necessary. We can just use the `uuid` package for UUIDs.", + "prediction": "I don't think this is necessary.", "reference": "I don't see a corresponding call to freeSelectorSet... am I missing something?" }, { - "prediction": "I'm not sure what you mean by \"without an auth origin\"", + "prediction": "I'm not sure what you mean by \"without an auth origin\". I think you meant to say \"without an authorization origin\" or \"without an auth origin\".", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { @@ -18087,7 +18087,7 @@ "reference": "Is this part of spec?" }, { - "prediction": "I think this should be `wait_for_event(dr_app_started, 0);` instead of `wait_for_event(dr_app_started, 1);`", + "prediction": "I think this should be `wait_for_event(dynamo_thread_started, 0)` instead of `wait_for_event(dr_app_started, 0)`.", "reference": "Hmm, do we need to do this for Windows too? It won't have this private loader TLS issue but it will run DR code in a separate thread before DR init is fully done which I think violates some assumptions. For Windows we would move this wait from win32/os.c to win32/callback.s intercept_new_thread where it checks whether it's a client thread right before calling dynamo_thread_init. If you do not want to deal with Windows you could bail on my suggestion and leave the issue open (or maybe file a new issue) for Windows, or if you want to put the suggested core/win32/ change in place and your new test passes on Appveyor we could then claim to have fully solved this related issue too for all platforms." }, { @@ -18095,51 +18095,51 @@ "reference": "We can remove this function and use `lambda_function_name(..)` in this file instead." }, { - "prediction": "I don't think we need to change anything here.", + "prediction": "I don't think we need to use `NewNoopTransport` here.", "reference": "nitpick: `ApplicationVersion` could be `AppVersion`. It's smaller but gives the same understanding for purposes of the field." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check to see if the response is not nil before returning it.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the `PollWorkflowTaskQueueResponse` struct as well, so that we don't have to do this in the `PollWorkflowTaskQueue` handler.", "reference": "nit: maybe prefer `resp = &workflowservice.PollWorkflowTaskQueueResponse{}` over adding another function exit points especially for non-error cases?" }, { - "prediction": "I'm not sure what you mean by \"client_options[:read].is_a?(Symbol)\"", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.", "reference": "Do we specifically need to keep the read preference as a symbol for use elsewhere? If not, I think it would be cleaner to just modify the options before caching them in the `client_options` method so that we don't do this check every time. If we do need it a a symbol elsewhere, I'd suggest either putting `return @client if @client` at the top of the method (and changing the assignment below from `||=` to `=`) or moving this within the parenthetical block in the last assignment so that we don't repeat this work." }, { - "prediction": "I don't think this is a good idea. The `facingMode` should be set to `user` and `preferredMimeType` should be set to `image/jpeg`, `image/png`, `image/gif`, `video/mp4`, `video/quicktime`, `video/avi`, `video/mpeg`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime`, `video/quicktime", + "prediction": "I don't think we need to merge the default options with the ones set by user.", "reference": "Since this is for video only, should it be called `preferredVideoMimeType`? If we add it for pictures later, it will likely need to be a different option." }, { - "prediction": "I'm not sure what you're trying to do with this, but I think it's a bad idea to use `VkImageSubresourceLayoutMap::LayoutEntry` in this way. It's not clear to me what you're trying to do with this, but I think it's a bad idea to use `VkImageSubresourceLayoutMap::LayoutEntry` in this way. It's not clear to me what you're trying to do with this, but I think it's a bad idea to use `VkImageSubresourceLayoutMap::LayoutEntry` in this way. It's not clear to me what you're trying to do with this, but I think it's a bad idea to use `VkImageSubresourceLayoutMap::LayoutEntry` in this way. It's not clear to me what you're trying to do with this, but I think it's a bad idea to use `VkImageSubresourceLayoutMap::LayoutEntry` in this way. It's not clear to me what you're trying to do with this, but I think it's a bad idea to use `VkImageSubresourceLayoutMap::LayoutEntry` in this way. It's not clear to me what you're trying to do with this, but I think", + "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea to use `VkImageSubresourceLayoutMap::LayoutEntry` in this way. It's not clear to me what you're trying to do with this, but I don't think it's a good idea to use `VkImageSubresourceLayoutMap::LayoutEntry` in this way. It's not clear to me what you're trying to do with this, but I don't think it's a good idea to use `VkImageSubresourceLayoutMap::LayoutEntry` in this way. It's not clear to me what you're trying to do with this, but I don't think it's a good idea to use `VkImageSubresourceLayoutMap::LayoutEntry` in this way. It's not clear to me what you're trying to do with this, but I don't think it's a good idea to use `VkImageSubresourceLayoutMap::LayoutEntry` in this way. It's not clear to me what you're trying to do with this, but I don't think it's a good idea to use `VkImageSubresourceLayoutMap::LayoutEntry` in this way. It's not clear to me", "reference": "That doesn't make sense. LayoutEntry doesn't match the generator concept." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this.", + "prediction": "I'm not sure what you mean by \"mockError\" here. It's not an error, it's a mock error.", "reference": "I think the customer visible strings should be \"Service\" instead of \"Svc\" to make it obvious to them" }, { - "prediction": "I think we should remove the `execute.as.user` property. It's not needed anymore.", + "prediction": "I think we should remove the `execute.as.user` option.", "reference": "Explain why this property is necessary?" }, { - "prediction": "I don't think we need to log the receipt to the stateDB.", + "prediction": "I'm not sure what you mean by \"log receipt to stateDB\"", "reference": "It should accept executions as the input" }, { - "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here. If you want to do something like `tensor2imgs(img_tensor, **img_metas[0]['img_norm_cfg'])` then you should use `torchvision`'s `img2tensor` function instead.", + "prediction": "I think this should be `batch_size == 1` instead of `len(result) == 1`", "reference": "Is this limitation necessary?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a `SelfSignedIssuer` with a `SelfSignedIssuer` as a child of the `VaultIssuer`. Is that what you're trying to do? If so, I'm not sure what you're trying to do here. I think you're trying to create a `SelfSignedIssuer` with a `SelfSignedIssuer` as a child of the `VaultIssuer`. Is that what you're trying to do? If so, I'm not sure what you're trying to do here. I think you're trying to create a `SelfSignedIssuer` with a `SelfSignedIssuer` as a child of the `VaultIssuer`. Is that what you're trying to do? If so, I'm not sure what you're trying to do here. I think you're trying to create a `SelfSignedIssuer` with a `SelfSignedIssuer` as a child of the `VaultIssuer`. Is that what you're trying to do? If so, I'm not sure what you're trying to do here. I think you're trying to create a `SelfSignedIssuer` with a `SelfSignedIssuer` as a child of the `VaultIssuer`. Is that what", + "prediction": "I don't think this is necessary. We can just use the same config for all issuers.", "reference": ":question: Should there be validation to ensure that only one of these attributes is used?" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the backend class.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's the best way to do this.", "reference": "I would recommend using Psr\\Container\\ContainerInterface here instead of Interop\\Container\\ContainerInterface; both currently work, but the Interop version is deprecated and will eventually be removed, so using the Psr version will save us time in the future." }, { - "prediction": "I'm not sure what you're trying to do here, but I think it's a bad idea to use `testcommon.CaptureStdOut()` in this case.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure the output of the command is captured in the `stdout` variable.", "reference": "This would also change back to /var/www/html/docroot if we go that way." }, { @@ -18147,11 +18147,11 @@ "reference": "Does this need to be public? Can't one of the helper functions below pass the data? If it really needs to be public, could it be write-protected?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate function for creating the storage API.", + "prediction": "I don't think we need to use `nd.StorageProtocol.StorageClient` here. We can just use `nd.StorageProtocol.StorageProvider` and `nd.PieceManager` directly.", "reference": "Thanks. Now that you've improved this we should just init and expose the StorageAPI on the node, like the other.s" }, { - "prediction": "I don't think this is a good idea. It's not clear what you're trying to do with this key. If you want to get rid of the prefix, you can use `toRawKey(prefixNext(value))` instead. If you want to get rid of the rid, you can use `toRawKey(prefixNext(value, 0))` instead.", + "prediction": "I don't think we need this. We can just use `toRawKey(prefixNext(value + 1))` instead.", "reference": "it will be better if you can provide some examples" }, { @@ -18159,15 +18159,15 @@ "reference": "\"return type\" and \"response type\" have never really been contrasted before, and it's unclear what their meaning is here. Could you clarify?" }, { - "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea to import `shlex` in this way. It's not a good idea to import `subprocess` in this way. It's not a good idea to import `sys` in this way. It's not a good idea to import `traceback` in this way. It's not a good idea to import `subprocess` in this way. It's not a good idea to import `shlex` in this way. It's not a good idea to import `sys` in this way. It's not a good idea to import `traceback` in this way. It's not a good idea to import `subprocess` in this way. It's not a good idea to import `shlex` in this way. It's not a good idea to import `sys` in this way. It's not a good idea to import `traceback` in this way. It's not a good idea to import `subprocess` in this way. It's not a good idea to import `shlex` in this way. It's not a good idea to import `sys` in this way. It's not", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to move this into a separate file, so that it can be used in other places.", "reference": "Import order has been violated here." }, { - "prediction": "I'm not sure what you mean by \"dragons\" in this context.", + "prediction": "I'm not sure what you mean by \"dragons\" here. I think it's just a typo.", "reference": "Are you suggesting deleting the concept of message querying from plumbing (sounds like more trouble than its worth) or suggesting deleting the snapshot based implementation?" }, { - "prediction": "I don't think we need to use `types.Labels` here. We can just use `joinOptions.Labels` instead.", + "prediction": "I don't think we need to use `types.Labels` here. We can use `joinOptions.Labels` directly.", "reference": "I recommend using StringSliceVarP to resolve the label flag, like `-l key1=value1,key2=value2`. What do you think?" }, { @@ -18183,51 +18183,51 @@ "reference": "heads up @JunTaoLuo" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to move it to the `MoveNext` method of the `System.Runtime.CompilerServices.AsyncTaskMethodBuilder` class. This way, we don't need to check if the method is `System.Runtime.CompilerServices.AsyncTaskMethodBuilder` or `System.Runtime.CompilerServices.AsyncTaskMethodBuilder<>` in the `MoveNext` method, but only in the `MoveNext` method of the `System.Runtime.CompilerServices.AsyncTaskMethodBuilder` class. This way, we don't need to check if the method is `System.Runtime.CompilerServices.AsyncTaskMethodBuilder` or `System.Runtime.CompilerServices.AsyncTaskMethodBuilder<>` in the `MoveNext` method, but only in the `MoveNext` method of the `System.Runtime.CompilerServices.AsyncTaskMethodBuilder` class. This way, we don't need to check if the method is `System.Runtime.CompilerServices.AsyncTaskMethodBuilder` or `System.Runtime.CompilerServices.AsyncTaskMethodBuilder<>` in the `MoveNext` method, but only in the `MoveNext` method of the `System.Runtime.CompilerServices.AsyncTaskMethodBuilder` class. This way, we don't need to check if the method is `System.Runtime.CompilerServices.AsyncTaskMethodBuilder` or `System.Runtime.CompilerServices.AsyncTaskMethodBuilder<>` in", + "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to move it to the `MoveNext` method of the `System.Runtime.CompilerServices.AsyncTaskMethodBuilder` class. This way, we don't need to check if the method is `System.Runtime.CompilerServices.AsyncTaskMethodBuilder` or `System.Runtime.CompilerServices.AsyncTaskMethodBuilder<>` in the `MoveNext` method. We can just check if the method is `System.Runtime.CompilerServices.AsyncTaskMethodBuilder` or `System.Runtime.CompilerServices.AsyncTaskMethodBuilder<>` in the `MoveNext` method of the `System.Runtime.CompilerServices.AsyncTaskMethodBuilder` class. This way, we don't need to check if the method is `System.Runtime.CompilerServices.AsyncTaskMethodBuilder` or `System.Runtime.CompilerServices.AsyncTaskMethodBuilder<>` in the `MoveNext` method of the `System.Runtime.CompilerServices.AsyncTaskMethodBuilder` class. This way, we don't need to check if the method is `System.Runtime.CompilerServices.AsyncTaskMethodBuilder` or `System.Runtime.CompilerServices.AsyncTaskMethodBuilder<>` in the `MoveNext` method of the `System.Runtime.CompilerServices.AsyncTaskMethodBuilder` class. This way, we don't need to check if the method is `System.Runtime.CompilerServices.AsyncTaskMethodBuilder` or `System.Runtime.CompilerServices.AsyncTaskMethod", "reference": ".GetMethod() cannot return null now, correct?" }, { - "prediction": "I don't think we need to add the `iconOsdIcon` class to the `iconOsdProgressInner` class.", + "prediction": "I don't think we need to add the `iconOsdIcon` class to the `iconOsdProgressInner` element.", "reference": "Same thing here, I think the proper fix is elsewhere." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do it here.", + "prediction": "I think this should be `if (retcode < 0)` instead of `if ((retcode < 0) && ((errno == ENOENT) || (errno == EAGAIN)))`", "reference": "errno is a global variable that might be set by any system library call. It is dangerous to rely on it except right after the system call where it is set. But in this code, it looks like the library call is buried inside ExpLOBInterfaceSelectCursor. It would be safer if the latter function saved errno after whatever system library call it calls, and returns that as an \"out\" parameter, which this code could then check." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `__repr__` method that returns the full path to the package. This way, we don't have to call `self._package.get_path()` every time we want to print the package.", "reference": "`hasattr` is kinda terrible; just append extra info in the subclass." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `datetime` module to get the current date and time, rather than using `datetime.datetime.now()`. This is because `datetime.datetime.now()` returns a `datetime.datetime` object, which is a subclass of `datetime.date` and `datetime.time` objects, and `datetime.date` and `datetime.time` objects don't have a `strftime` method, so we can't use `strftime` to format the date and time.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a default value of 0.00 for the 'seconds' option.", "reference": "Fair warning, the way that exception block is written won't work in python3 Python 3.2.3 (default, Jun 8 2012, 05:36:09) [GCC 4.7.0 20120507 (Red Hat 4.7.0-5)] on linux2 Type \"help\", \"copyright\", \"credits\" or \"license\" for more information. > > > try: > > > ... raise ValueError(\"foo\") > > > ... except ValueError,e: > > > File \"\", line 3 > > > except ValueError, e: > > > ^ > > > SyntaxError: invalid syntax" }, { - "prediction": "I think we should remove the `root_password` from the `ssh` object.", + "prediction": "I think this should be `root_password` instead of `root_password`", "reference": "This only updates the metadata and not the actual thing you are trying to solve for the docker hypervisor." }, { - "prediction": "I think we should remove the `// import \"go.opentelemetry.io/otel/internal/debug\"` comment.", + "prediction": "I don't think this is needed anymore. We can remove it now.", "reference": "should this package be internal? don't we want to use it e.g. in go-contrib?" }, { - "prediction": "I think we should make the docstring look more like blob.Bucket.", + "prediction": "I think it's better to use `map[string]interface{}` instead of `map[string]int`.", "reference": "Just curious, why did you make this change?" }, { - "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `F.collect_set` here. It's not clear to me what the purpose of this function is, and I'm not sure if it's a good idea to use `F.collect_set` here. It's not clear to me what the purpose of this function is, and I'm not sure if it's a good idea to use `F.collect_set` here. It's not clear to me what the purpose of this function is, and I'm not sure if it's a good idea to use `F.collect_set` here. It's not clear to me what the purpose of this function is, and I'm not sure if it's a good idea to use `F.collect_set` here. It's not clear to me what the purpose of this function is, and I'm not sure if it's a good idea to use `F.collect_set` here. It's not clear to me what the purpose of this function is, and I'm not sure if it's a good idea to use `F.collect_set` here. It's not clear to me what the purpose of this function is, and I'm not sure if it", + "prediction": "I'm not sure what you mean by `kdf._internal.spark_column_for(label)`. Could you please provide more context?", "reference": "Can you handle error cases such as `pd.get_dummies(pdf, prefix={\"A\": \"foo\"})`?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to set the `hostConfig.NetworkMode` to `host` in the `StartAgent` function. This way, the `docker run` command will use the host network mode instead of the default `host` network mode.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to set the `hostConfig.NetworkMode` to `host` in the `StartAgent` function. This way, the `docker run` command will use the `host` network mode by default.", "reference": "Where is this environment variable being set?" }, { - "prediction": "I don't think this is a good name for this class. It's not clear what it does, and it's not clear what it's used for.", + "prediction": "I think it's better to use `__module__` instead of `__name__`.", "reference": "`module_class ` is already a class and `type(module_class)` always returns ``" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `BaseFileWriterFactory` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to `org.apache.spark.sql.execution.datasources.orc.OrcFileWriter`.", "reference": "Nit: The lambda can be replaced with a method reference: `SparkOrcWriter::new` I think." }, { @@ -18239,7 +18239,7 @@ "reference": "How do we manage updates to this view down the road?" }, { - "prediction": "I don't think this is necessary. The `DataFetchingEnvironment` is already available in the `DataFetcher` class.", + "prediction": "I don't think this is necessary. The `DataFetchingEnvironment` is just a wrapper for the `DataFetcher`, so it's not necessary to have a separate `DataFetchingEnvironment` class.", "reference": "We can revert this to reduce the diff of the PR." }, { @@ -18251,39 +18251,39 @@ "reference": "not sure I follow why all this goes away?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `quteproc.send_cmd(':insert-text {clipboard}')` instead of `quteproc.send_cmd(':debug-set-fake-clipboard \"{}\"'.format(input_text))` because `quteproc.send_cmd(':debug-set-fake-clipboard \"{}\"'.format(input_text))` doesn't work if the clipboard is empty.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way", "reference": "Is this `{clipboard}` or `{primary}`, as the deprecation message for `:paste-primary` says?" }, { - "prediction": "I'm not sure if this is the right place to add this flag, but I think it's a good idea to add it to the OpenVPN CLI.", + "prediction": "I'm not sure if this is the right place to add this flag, but I think it's a good idea to add this flag to the OpenVPN CLI.", "reference": "Human unreadable. IMHO user should input MYST value: 0.0006 @chompomonim, opinions?" }, { - "prediction": "I think this should be `table` instead of `self.table`?", + "prediction": "I think this should be `if role in (controlTypes.ROLE_TABLEROW,controlTypes.ROLE_TABLECOLUMN,controlTypes.ROLE_TABLECELL) and (not config.conf[\"documentFormatting\"][\"reportTables\"] or not config.conf[\"documentFormatting\"][\"reportTableCellCoords\"]):`", "reference": "May be you could elaborate on why you removed this? I see some of this logic has been moved to ia2Web, but couldn't there be cases outside ia2Web (i.e. UIA) in which case ROLE_TABLEROW and ROLE_TABLECOLUMN are mapped to objects, in which case these objects will be of presentation type content erroneously?" }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it would be good to have a separate function for this.", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be better to have a separate function for this.", "reference": "This is not consistent. Either rename the first to `tradePlayerItem` (which is ugly) or the second to `partnerTradeItem` (:+1:)" }, { - "prediction": "I don't think this is necessary. We can just use `go get -u github.com/xeipuuv/gojsonschema` instead of `go get -u github.com/alecthomas/gometalinter` and `go get -u github.com/stretchr/testify`.", + "prediction": "I don't think we need to install `go get -u github.com/xeipuuv/gojsonschema` as it's already installed by default.", "reference": "is there a reason we don't want to gx this dependency?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a function that does this, so that we don't have to do it every time we want to get the model name.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to remove the `strip_vendor` function, since it's not used anywhere else in the code.", "reference": "I'd suggest to add \"ATI \" and \"Intel(R) \" to this list" }, { - "prediction": "I don't think this is a good idea. It's not clear to the user what they should do if they have a plugin that they don't want to install.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it", "reference": "This is using a different lang key, we should switch it to using the new key and remove the old key if it is no longer used." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `regexp` package for this kind of pattern matching.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate regex for `api.SpecNodes` and `api.SpecParent` so that we don't have to worry about the order in which they appear in the spec.", "reference": "shouldn't this work? nodesRegex = regexp.MustCompile(api.SpecNodes + \"=(('[0-9A-Za-z,_-]+')|([0-9A-Za-z_-]+)),?\")" }, { - "prediction": "I think this should be `encrypt_salt` instead of `assign_activation_code_to_random_hash`?", + "prediction": "I think this should be `encrypt_salt` instead of `assign_activation_code_to_random_hash`", "reference": "You mentioned this change was prompted because the `before_create` action was actually a defect. This will be done only for a new record; why is `before_validation`, which will be called repeatedly as accounts get updated and saved, correct whereas `before_create` is not? It looks like one would want to assign and activation code, etc., only once." }, { @@ -18291,11 +18291,11 @@ "reference": "What's the rationale for a default setting to not use a GlobalSamplingRate of 1? I don't know much about the sampling rate stuff" }, { - "prediction": "I'm not sure what you're trying to do with this, but it looks like you're trying to set the `puppetbindir` variable to the path of the `Program Files (x86)/Puppet Labs/Puppet Enterprise/bin` directory. I'm not sure what you're trying to do with this, but it looks like you're trying to set the `puppetbindir` variable to the path of the `Program Files (x86)/Puppet Labs/Puppet Enterprise/bin` directory. I'm not sure what you're trying to do with this, but it looks like you're trying to set the `puppetbindir` variable to the path of the `Program Files (x86)/Puppet Labs/Puppet Enterprise/bin` directory. I'm not sure what you're trying to do with this, but it looks like you're trying to set the `puppetbindir` variable to the path of the `Program Files (x86)/Puppet Labs/Puppet Enterprise/bin` directory. I'm not sure what you're trying to do with this, but it looks like you're trying to set the `puppetbindir` variable to the path of the `Program Files (x86)/P", + "prediction": "I'm not sure if this is the right place to change this, but I think it's a good idea to make sure that the path separator is the same on both systems.", "reference": "Don't we know if it's 64 by this point? Do we have to test for the directory on every call, or can't we just split the value based on the platform?" }, { - "prediction": "I don't think this is needed.", + "prediction": "I don't think we need to add this to the `NoteListUtils` class. We can just add it to the `NoteList` class.", "reference": "It's not async" }, { @@ -18303,7 +18303,7 @@ "reference": "Maybe we could add some use of `exporterOptions` in this example, otherwise the proper code would replace this variable name with an underscore?" }, { - "prediction": "I don't think this is a good idea. I think it's better to use `on` instead of `everykey`.", + "prediction": "I don't think this is a good idea.", "reference": "Maybe would be better to rename it to \"onEveryKey\" or \"fireOnEveryKey\"." }, { @@ -18311,51 +18311,51 @@ "reference": "if we're switching to calling FileDownloadHelper, we can just call that directly from the xhtml (see line 357 for example) and then remove this method completely. This is because the other thing it does is check PrivateURLUser, but the FileDownloadHelper method already does that. (and while we're at it, we can remove the method from FileUtil as this is the only place that method is called)" }, { - "prediction": "I'm not sure what you mean by \"no method config for method '\" + fullName + \"'\"", + "prediction": "I don't think this is necessary. The `getMethodConfigMap()` method returns a `Map`, so we don't need to call `getMethodConfigMap().get(methodSimpleName)`.", "reference": "is `fullName` still required as a parameter?" }, { - "prediction": "I'm not sure what you mean by \"bound legacy RC support\". I think this is the same as \"bound RC support\".", + "prediction": "I'm not sure what you mean by \"bound legacy RC support\". I think it's just that the `Routable` class has a `getActiveSessions()` method, which is called by the `Routable` constructor.", "reference": "This informational message is important to users. Please leave." }, { - "prediction": "I'm not sure what you mean by \"configure this based on user input or service Type needs?\". I think we should just leave it as is.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `true` for `PublicLoadBalancer` and `true` for `ToolsAccountPrincipalARN` instead of `true` for `PublicLoadBalancer` and `false` for `ToolsAccountPrincipalARN`.", "reference": "Why do we want to remove this one? Are we planning to substitute it?" }, { - "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to have a separate test for `IsAgentBanned` to make sure it's working as expected.", + "prediction": "I'm not sure why we need to use `WithDetails` in this case. We can just use the `IsAgentBanned` method directly.", "reference": "We may create an issue to track this so we don't forget?" }, { - "prediction": "I don't think this is a good idea. The `before_action :store_location` should be in the `ApplicationController` itself, not in `ApplicationHelper`.", + "prediction": "I'm not sure what you mean by \"protect_from_forgery with: :exception\"", "reference": "This file has the executable bit set." }, { - "prediction": "I think this should be `maxParallelUpdateGC` instead of `maxParallelUpdateGC > 0`", + "prediction": "I think it's better to use `defaultCapacity` instead of `maxParallelUpdateGC` here.", "reference": "Improve the formatting of the message `.Infof(\"setting db capacity to: %v\", db.capacity)` There is a space before `:` and this way it is easier to see the formatting." }, { - "prediction": "I think we can remove the `lock_guard` here, since it's not used anywhere else.", + "prediction": "I think this should be `RTPSDomain::m_RTPSParticipant` instead of `RTPSDomain::m_RTPSParticipants`.", "reference": "This lock cannot be released here, as it is protecting m_RTPSParticipants and the participant reference." }, { - "prediction": "I'm not sure what you mean by \"discriminator criteria\" in this context. I think you're talking about the `discriminator` field in the model, but I'm not sure what you mean by \"discriminator criteria\" in this context. I think you're talking about the `discriminator` field in the model, but I'm not sure what you mean by \"discriminator criteria\" in this context. I think you're talking about the `discriminator` field in the model, but I'm not sure what you mean by \"discriminator criteria\" in this context. I think you're talking about the `discriminator` field in the model, but I'm not sure what you mean by \"discriminator criteria\" in this context. I think you're talking about the `discriminator` field in the model, but I'm not sure what you mean by \"discriminator criteria\" in this context. I think you're talking about the `discriminator` field in the model, but I'm not sure what you mean by \"discriminator criteria\" in this context. I think you're talking about the `discriminator` field in the model, but I'm not sure what you mean by \"discriminator criteria\" in this context. I", + "prediction": "I think this should be `this._castError = null;` instead of `this._castError = null;`", "reference": "we'll need this in `_findAndModify` too" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to set the default value of the spinner to the default value of the db name.", + "prediction": "I don't think this is necessary.", "reference": "This is the fix for the crash. The function to create the intent to launch this activity requires `dbName`, so it has to be set to `null`. In such cases, the value for `dbName` will be set to `null` and cause issues throughout this activity. This adds a default value if the explicitly assigned value in `null`." }, { - "prediction": "I'm not sure what you mean by \"recent Word 365 releases\". I'm not sure what you mean by \"Control+Backspace\". I'm not sure what you mean by \"NVDA\". I'm not sure what you mean by \"delete back word\". I'm not sure what you mean by \"edit functions\". I'm not sure what you mean by \"Control+Backspace\". I'm not sure what you mean by \"braille\". I'm not sure what you mean by \"Microsoft Word\". I'm not sure what you mean by \"Microsoft Word\". I'm not sure what you mean by \"Microsoft Word\". I'm not sure what you mean by \"Microsoft Word\". I'm not sure what you mean by \"Microsoft Word\". I'm not sure what you mean by \"Microsoft Word\". I'm not sure what you mean by \"Microsoft Word\". I'm not sure what you mean by \"Microsoft Word\". I'm not sure what you mean by \"Microsoft Word\". I'm not sure what you mean by \"Microsoft Word\". I'm not sure what you mean by \"Microsoft Word\". I'm not sure what you mean by \"Microsoft Word\". I'm not sure what you mean by \"Microsoft Word\". I'm not sure what you", + "prediction": "I'm not sure what you mean by \"recent Word 365 releases\". I'm not aware of any such releases.", "reference": "Shouldn't we also trigger vision update here, so that if someone has caret highlighting enabled the correct character is highlighted?" }, { - "prediction": "I think this should be `context.getProductConfig().getPackageName()` instead of `context.getNamer().getLocalPackageName()`.", + "prediction": "I'm not sure if this is the right place to do this.", "reference": "Woah, how does this change, which includes semicolons, result in the baseline change? Are the semicolon chars just part of the internal representation of the import type?" }, { - "prediction": "I think this should be `f'\"{self._runNVDAFilePath}\"'` instead of `f'\"{self._runNVDAFilePath}\"'`", + "prediction": "I think it's better to use `pyw` instead of `pyw37-32` in this case. `pyw37-32` is not supported anymore.", "reference": "Can't you just use runnvda.bat here?" }, { @@ -18367,19 +18367,19 @@ "reference": "is type a free string too?" }, { - "prediction": "I'm not sure what you mean by `onnx_io='tmp.onnx'`. Is that the name of the output file? If so, I'm not sure what you mean by `onnx_io='tmp.onnx'`. Is that the name of the output file? If so, I'm not sure what you mean by `onnx_io='tmp.onnx'`. Is that the name of the output file? If so, I'm not sure what you mean by `onnx_io='tmp.onnx'`. Is that the name of the output file? If so, I'm not sure what you mean by `onnx_io='tmp.onnx'`. Is that the name of the output file? If so, I'm not sure what you mean by `onnx_io='tmp.onnx'`. Is that the name of the output file? If so, I'm not sure what you mean by `onnx_io='tmp.onnx'`. Is that the name of the output file? If so, I'm not sure what you mean by `onnx_io='tmp.onnx'`. Is that the name of the output file? If so, I'm not sure what you mean by `onnx_io='tmp.onnx", + "prediction": "I don't think this is a good idea. We should use `torch.onnx.export` to export the model to ONNX format.", "reference": "here input could be a normal function or an instance of torch.nn.Module." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `nix-instantiate` to get the version of `lib.nixpkgsVersion`. You can just use `lib.nixpkgsVersion` directly.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate script for this. I think it would be better to have a separate script for `nix-instantiate` and `nix-env` so that we don't have to run both of them in the same script.", "reference": "Example output: \"19.03.git.a7f4a860d0c\" At some point `nixpkgsVersion` was renamed to `version` since someone may use an old channel we fallback to `nixpkgsVersion` for backwards compatibility." }, { - "prediction": "I don't think we need to do this.", + "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to have it in the `LanguageTreeReadAction` as well.", "reference": "Class import is therefore redundant I guess :)" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to move it to the `error` section of the error messages.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `error` section of the error messages.", "reference": "If parsing fails, don't act as no IP specified. Error out." }, { @@ -18387,27 +18387,27 @@ "reference": "... here the semicolon wanted to run away from the enum ;)" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `getCommitVersion` method to get the last commit version.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use a `NamedList` for the `slave` and `secondary` config.", "reference": "Note that this is in the context of SolrCloud, so \"secondary\" doesn't apply and should be instead follower" }, { - "prediction": "I'm not sure what you mean by \"can't get changesets by closed-ness and user\". I think you meant \"can't get changesets by closed-ness\".", + "prediction": "I don't think this is a good idea. We should be able to query for changesets by closed-ness and user.", "reference": "This one is a query parameter and probably really should be ID and in fact I'm mystified as to how this is working because the controller code definitely wants a number for that parameter so the test framework must be converting it back to an ID as best I can tell." }, { - "prediction": "I think we should be able to do this in a single pass, but I'm not 100% sure how to do it.", + "prediction": "I think this should be `if (isHiveTable())` instead of `if (isHiveTable() && isHiveTable())`.", "reference": "Need to ensure this is set to TRU for LOB datatype access too not just for hive ." }, { - "prediction": "I think this should be `self._scol` instead of `self._scol_`.", + "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason you want to pass `sfun` to `reduce_for_stat_function`?", "reference": "You're using the Sphinx docstring style here (maybe because it's the default in PyCharm?). Instead, you should use the NumPy style (that you've also used in other places) to be more consistent with the rest of the project." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a `StartLocalhost` method to the `KestrelServer` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a `StartLocalhost` method to the `KestrelServer` class.", "reference": "Don't really need this since the rest of the method will no-op but it's also safe to return early." }, { - "prediction": "I'm not sure what you mean by \"use up to 60 words\"", + "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to have this in the header file. It's not a big deal, but I think it's a good idea to have this in the header file. It's not a big deal, but I think it's a good idea to have this in the header file. It's not a big deal, but I think it's a good idea to have this in the header file. It's not a big deal, but I think it's a good idea to have this in the header file. It's not a big deal, but I think it's a good idea to have this in the header file. It's not a big deal, but I think it's a good idea to have this in the header file. It's not a big deal, but I think it's a good idea to have this in the header file. It's not a big deal, but I think it's a good idea to have this in the header file. It's not a big deal, but I think it's a good idea to have this in the header file. It's not a big deal, but I think it's a good idea to have this in", "reference": "Don't use relative paths. src directory is already on the include search path" }, { @@ -18415,7 +18415,7 @@ "reference": "this file can be removed" }, { - "prediction": "I'm not sure what you mean by `@RequestAttribute(name = \"name\", required = false) String name)`", + "prediction": "I don't think we need to do this.", "reference": "Do we have test cases that name is null?" }, { @@ -18427,7 +18427,7 @@ "reference": "We really, really want to catch _everything_ here. It is safe to leave `azkabanEventReporter` set to null." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `diffChildren` function. I think it's a good idea to do this in the `diffChildren` function. I think it's a good idea to do this in the `diffChildren` function. I think it's a good idea to do this in the `diffChildren` function. I think it's a good idea to do this in the `diffChildren` function. I think it's a good idea to do this in the `diffChildren` function. I think it's a good idea to do this in the `diffChildren` function. I think it's a good idea to do this in the `diffChildren` function. I think it's a good idea to do this in the `diffChildren` function. I think it's a good idea to do this in the `diffChildren` function. I think it's a good idea to do this in the `diffChildren` function. I think it's a good idea to do this in the `diffChildren` function. I think it's a good idea to do this in the `diffChildren` function. I think it's a good idea", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to remove the last child of the `newParentVNode` from the `parentDom` and append it to the `parentDom` instead of the `newParentVNode`. Is this what you're trying to do?", "reference": "Can't we add the check here?" }, { @@ -18435,43 +18435,43 @@ "reference": "body is being used here for the first time without every being populated. This will error. To run tests do `./go clean test_py` and that will run the Firefox tests" }, { - "prediction": "I think we can remove the `*SecretEncryption` field, since it's not used anywhere.", + "prediction": "I don't think we need this field. It's not used anywhere in the spec.", "reference": "Tell me if you have a better field name for this." }, { - "prediction": "I think we can remove this line, as it's not needed anymore.", + "prediction": "I think it's better to use `||` instead of `&&` here.", "reference": "FYI, I have a branch I started to improve this. Nuke can read the target frameworks from the project files, so we don't have to do this mess. Ran into some other issues so it didn't take priority" }, { - "prediction": "I think this should be `while (nbrIdx != endNbrs)` instead of `while (nbrIdx != endNbrs)`.", + "prediction": "I'm not sure I understand what you're trying to do here. You're iterating over the neighbors of the given atom, and then you're iterating over the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of the neighbors of", "reference": "This is just `mol->atomNeightors()`, is it?" }, { - "prediction": "I'm not sure I understand what you're trying to do here.", + "prediction": "I'm not sure I understand what you're trying to do here. The `infer_kernel_gpu` is just a wrapper for the `infer_kernel` kernel. It's not clear what you're trying to do with the `infer_kernel_gpu` kernel.", "reference": "This alias is just for a single occurrence. Maybe it ins't necessary?" }, { - "prediction": "I think we should remove the `default` keyword here.", + "prediction": "I think it's better to use `return false;` and `return true;` instead of `return false;` and `return true;`", "reference": "You can delete this `NONE` case." }, { - "prediction": "I'm not sure what you mean by \"unintentional\" here. I think it's more accurate to say that this is a bug in the implementation of `vkGetPhysicalDeviceProperties2KHR` and `vkGetPhysicalDeviceQueueFamilyProperties2KHR` (which are used by `vkCreateRenderPassKHR` and `vkCreateRenderPass2KHR` respectively).", + "prediction": "I'm not sure what you mean by \"unintentional\" here. I think it's more accurate to say that this is a bug in the implementation of `vkGetPhysicalDeviceProperties2KHR` and `vkGetPhysicalDeviceQueueFamilyProperties2KHR` (which are called `vkGetPhysicalDeviceProperties2KHR` and `vkGetPhysicalDeviceQueueFamilyProperties2KHR` in Vulkan 1.3).", "reference": "@cnorthrop -- here is a test with a name change. Is this going to affect your internal CI?" }, { - "prediction": "I don't think this is necessary. The `sendCommandForDownloadChromeHeadLess` command is already defined in the `ChromeDriverCommand` class, so we don't need to create a new one.", + "prediction": "I don't think this is necessary. The `sendCommandForDownloadChromeHeadLess` command can be found in `src/main/java/com/google/chromedriver/commands/ChromeDriverCommand.java`", "reference": "Nit: `Headless` is one word, not two, and so doesn't need camelcasing in this way." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have the `parallel_scheduling` and `parallel_scheduling_processes` parameters be optional. This way, if you don't want to use multiprocessing, you can just set them to `None`.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a default value for `parallel_scheduling_processes` that is the number of available CPUs.", "reference": "I think this will cause a warning, can you set the default to zero (`0`)?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add a comment to explain what this change does.", + "prediction": "I don't think we need to change this.", "reference": "confusing naming. Identity from \"id\" package :/ why we need alias here? (and in other imports)" }, { - "prediction": "I'm not sure what this is for, but I think it should be removed.", + "prediction": "I'm not sure if this is a good idea, but I think it's better to have a `keyhint-blacklist` setting than a `show-keyhints` setting. I think it's better to have a `keyhint-blacklist` setting than a `show-keyhints` setting. I think it's better to have a `keyhint-blacklist` setting than a `show-keyhints` setting. I think it's better to have a `keyhint-blacklist` setting than a `show-keyhints` setting. I think it's better to have a `keyhint-blacklist` setting than a `show-keyhints` setting. I think it's better to have a `keyhint-blacklist` setting than a `show-keyhints` setting. I think it's better to have a `keyhint-blacklist` setting than a `show-keyhints` setting. I think it's better to have a `keyhint-blacklist` setting than a `show-keyhints` setting. I think it's better to have a `keyhint-blacklist` setting than a `show-keyhints` setting. I think it's better to have a `keyhint-blacklist` setting than a `show-keyhints` setting. I think it's", "reference": "It'd be nice to fix up existing configs with the change - that'd mean adding the option to `RENAMED_OPTIONS` in `config.py` and adding something like `_get_value_transformer({'true': '', 'false': '*'})` to `CHANGED_OPTIONS`. I think I never tried adding an option to both, but it should work." }, { @@ -18479,19 +18479,19 @@ "reference": "Perhaps use the new `.keys()` method here instead?" }, { - "prediction": "I'm not sure what you mean by `diff.WithIgnoreAddingMapKeys()`. I think you meant to say `diff.WithIgnoreAddingMapKeysAndNumericString()`.", + "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to use `diff.WithIgnoreAddingMapKeys()` and `diff.WithCompareNumberAndNumericString()` without having to do `diff.WithIgnoreAddingMapKeys()`, `diff.WithCompareNumberAndNumericString()`, `diff.WithEquateEmpty()`, `diff.WithIgnoreAddingMapKeys()`, `diff.WithCompareNumberAndNumericString()`, `diff.WithEquateEmpty()`, `diff.WithIgnoreAddingMapKeys()`, `diff.WithCompareNumberAndNumericString()`, `diff.WithEquateEmpty()`, `diff.WithIgnoreAddingMapKeys()`, `diff.WithCompareNumberAndNumericString()`, `diff.WithEquateEmpty()`, `diff.WithIgnoreAddingMapKeys()`, `diff.WithCompareNumberAndNumericString()`, `diff.WithEquateEmpty()`, `diff.WithIgnoreAddingMapKeys()`, `diff.WithCompareNumberAndNumericString()`, `diff.WithEquateEmpty()`, `diff.WithIgnoreAddingMapKeys()`, `diff.WithCompareNumberAndNumericString()`, `diff.WithEquateEmpty()`, `diff.WithIgnoreAddingMapKeys()`, `diff.WithCompareNumberAndNumericString()`, `diff.With", "reference": "We don't need this option because plan-preview is comparing between 2 commits, not using the live state." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a good idea to have a `@current_test_info` hash in the `step` method, so that you can access it from anywhere in the code.", + "prediction": "I think this should be `@options[:current_test_info]` instead of `@options[:current_test_info] ||= {}`.", "reference": "I'm not sure about putting this in the options. I would see it living in an object and then being queried on through a class - a more object oriented, ruby solution." }, { - "prediction": "I think we can remove the `if len(card.HwmonPath) == 0` check.", + "prediction": "I think we should remove the `if len(card.HwmonPath) == 0` check.", "reference": "So `Status` returns metrics?" }, { - "prediction": "I'm not sure what you mean by \"outside_committers\"", + "prediction": "I don't think this is necessary. We can just use `@organization.outside_projects(page: 1, per_page: 20)` instead.", "reference": "Can we make a generic method say, `set_infographic_view` and in that method we can check the 4 values (outside_committers, portfolio_projects, outside_projects, affiliated_committers) and check against params[:action] and params[:view] and then trigger the respective method dynamically as it takes the standard argument(s) for all the four methods. What do you think?" }, { @@ -18499,7 +18499,7 @@ "reference": "Why would this be called to copy a non-Date object?" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to align the buffer to 4 bytes. This way, we don't need to use `native.PutUint32` to set the value to 0 or 1. We can use `native.PutUint32` to set the value to 0 and `native.PutUint32` to set the value to 1. This way, we don't need to use `native.PutUint32` to set the value to 0 or 1. We can use `native.PutUint32` to set the value to 0 and `native.PutUint32` to set the value to 1. This way, we don't need to use `native.PutUint32` to set the value to 0 or 1. We can use `native.PutUint32` to set the value to 0 and `native.PutUint32` to set the value to 1. This way, we don't need to use `native.PutUint32` to set the value to 0 or 1. We can use `native.PutUint32` to set the value to 0 and `native.Put", + "prediction": "I think it's better to use `native.PutUint32` instead of `native.PutUint16` in this case.", "reference": "This alignment issue had not appear because no multiple `Boolmsg`s had been serialized at once." }, { @@ -18507,23 +18507,23 @@ "reference": "Why are we not implementing a BooleanDefaultFalse struct and replacing all of these config vars that default to false with that? Are \"default false\" config vars not affected by this bug?" }, { - "prediction": "I don't think this is a good idea. The user should be able to set the access level of the role, not the other way around.", + "prediction": "I don't think we need to do this.", "reference": "Replaced this method with a ruby idiomatic setter." }, { - "prediction": "I'm not sure what you're trying to achieve with this change. It's not clear what you're trying to achieve with this change. It's not clear what you're trying to achieve with this change. It's not clear what you're trying to achieve with this change. It's not clear what you're trying to achieve with this change. It's not clear what you're trying to achieve with this change. It's not clear what you're trying to achieve with this change. It's not clear what you're trying to achieve with this change. It's not clear what you're trying to achieve with this change. It's not clear what you're trying to achieve with this change. It's not clear what you're trying to achieve with this change. It's not clear what you're trying to achieve with this change. It's not clear what you're trying to achieve with this change. It's not clear what you're trying to achieve with this change. It's not clear what you're trying to achieve with this change. It's not clear what you're trying to achieve with this change. It's not clear what you're trying to achieve with this change. It's not clear what you're trying to achieve with this change. It's not clear", + "prediction": "I don't think this is necessary.", "reference": "wrong place hehe" }, { - "prediction": "I think this should be `sudo service mysql restart` instead of `ls /var/run/mysqld/mysqld.sock >& /dev/null`", + "prediction": "I think this should be `sudo service mysqld restart` instead of `ls /var/run/mysqld/mysqld.sock >& /dev/null`", "reference": "Can this be `test -e /var/run/mysqld/mysqld.sock` instead of `ls`? Using `ls` for noninteractive stuff is a recipe for sadness, IMHO. /cc @tianon" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to add a `has_many :client_data, polymorphic: true` to the `Proposal` model, but I don't think that's what you're trying to do. I think you're trying to add a `has_many :client_data, polymorphic: true, dependent: :destroy` to the `Proposal` model, but I don't think that's what you're trying to do. I think you're trying to add a `has_many :client_data, polymorphic: true, dependent: :destroy` to the `Proposal` model, but I don't think that's what you're trying to do. I think you're trying to add a `has_many :client_data, polymorphic: true, dependent: :destroy` to the `Proposal` model, but I don't think that's what you're trying to do. I think you're trying to add a `has_many :client_data, polymorphic: true, dependent: :destroy` to the `Proposal` model, but I don't think that's what you're trying to do. I think you're trying to add a `has_many :client_data, polymorphic: true", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to add a `client_data` field to the `Proposal` model, but I don't think that's what you're trying to do here. I think you're trying to add a `client_data` field to the `Proposal::ClientData` model, but I don't think that's what you're trying to do here. I think you're trying to add a `client_data` field to the `Proposal::ClientData` model, but I don't think that's what you're trying to do here. I think you're trying to add a `client_data` field to the `Proposal::ClientData` model, but I don't think that's what you're trying to do here. I think you're trying to add a `client_data` field to the `Proposal::ClientData` model, but I don't think that's what you're trying to do here. I think you're trying to add a `client_data` field to the `Proposal::ClientData` model, but I don't think that's what you're trying to do here. I think you're trying to add a `client_data` field to the `Proposal::Client", "reference": "Are these `dependent: destroy` attributes intended to implement cascading deletes? I had assumed they were added because of the `paranoia` gem, but since that is no longer part of this PR, are they here as a best practice?" }, { - "prediction": "I think this should be `if (stream->tunnel != NULL)` instead of `if (stream->tunnel == NULL)`", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. The `tunnel->destroy(tunnel);` should be `tunnel->close(tunnel);`", "reference": "This approach would work only if there's a guarantee that the stream does not get freed before `establish_tunnel` is called, even though it _may_ enter CLOSE_WAIT state (at which point `stream->tunnel` is set to NULL). I do not think that assumption holds. Hence the alternate approach." }, { @@ -18531,31 +18531,31 @@ "reference": "Did you mean to remove the periods here while newly adding to other locations?" }, { - "prediction": "I'm not sure what you're trying to do here, but I think we should be able to do this in one line.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `blockPutState` as well.", "reference": "the check can now be `if newLen < 0`" }, { - "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to move it to the `k8s.io/client-go/kubernetes` package.", + "prediction": "I'm not sure if this is a good place to put it, but I think we should move it to `k8s.io/client-go/kubernetes` and `k8s.io/client-go/plugin/pkg/client/auth/gcp`.", "reference": "If we're going to clean up this package, can we also remove those two `_` imports that appear to serve no purpose? (FWIW, they're also in the manager package too...)" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a `std::unique_ptr` from a `const std::uint8_t` pointer. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a `std::unique_ptr` from a `const std::uint8_t` pointer. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a `std::unique_ptr` from a `const std::uint8_t` pointer. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a `std::unique_ptr` from a `const std::uint8_t` pointer. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a `std::unique_ptr` from a `const std::uint8_t` pointer. I'm not sure what you're trying to achieve with this, but it looks like you're trying to", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to `MMFFAromCollection.cpp` instead of `MMFFAromCollection.h`.", "reference": "Won't this leak like a sieve? The caller can't delete this as one is a unique_ptr and one is not." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `version` field to the `data` object.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do it here.", "reference": "form => from" }, { - "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea to add this to the `PropertySource` interface.", + "prediction": "I'm not sure if this is the right place to add this, but I think it would be good to add it to the `PropertySource` interface.", "reference": "Ok, we can't switch it now, because the properties are a field of the interface Rule - which makes it public API. Maybe we should remove it here in the (Java) API in 7.0.0? The only API left would be, when using a rule and setting the properties in the ruleset xml. There the type doesn't matter - since the String is then automatically converted into a Pattern." }, { - "prediction": "I'm not sure what you mean by \"hasErrors\" here, but I think it should be \"hasWarnings\" or \"hasWarningsAndErrors\" or something like that.", + "prediction": "I don't think this is a good idea.", "reference": "Pass in null here, instead of a value? Maaaaybe we should add an overload for `GapicProductConfig.create` that matches the original signature and passes through null? I don't feel strongly about that though, so happy to leave asis if you prefer." }, { - "prediction": "I think this should be `new String(word.chars, 0, word.offset + breakPos) + endChars + beginChars + word.subSequence(breakPos + replacement.length(), word.length);`", + "prediction": "I think this should be `endChars` and `beginChars` instead of `end` and `begin`.", "reference": "Include all compounds parts from the very beginning for the case check to work later" }, { @@ -18563,19 +18563,19 @@ "reference": "if the user specifies a url scheme on the cli this is going to cause problems, no?" }, { - "prediction": "I think we should use `dom.getWindowSize().innerWidth * 0.5` instead of `dom.getWindowSize().innerWidth * 0.25`", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to set the width of the overlayPlayButton to 50% of the window size. This way, the overlayPlayButton will always be in the middle of the screen, regardless of the size of the window.", "reference": "How about that `scaleFactor`?" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get the type of the result of an arithmetic operation, but you're not actually doing anything with the result. I think you want to use the `getNumericalType()` method to get the type of the result of an arithmetic operation, but I'm not sure what you're trying to do with the result of the operation.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the `NonDivArithmeticOpAnalyzer` class.", "reference": "`assert(is_int($result));` would be preferable I think, even if we know it can't ever be false" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason you want to use the `getQuantifiedProductsIndexedByItemId()` method instead of the `getQuantifiedProducts()` method?", + "prediction": "I don't think we need to do this.", "reference": "I'm unfortunately unable to review whether you've changed everything that used to use cartIds" }, { - "prediction": "I think this should be `@VisibleForTesting` instead of `@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting`/`@VisibleForTesting", + "prediction": "I don't think this is needed anymore.", "reference": "Please don't touch unrelated files to keep the git history clean" }, { @@ -18583,31 +18583,31 @@ "reference": "Per our style guide, I don't think we indent `private` keyword. Would you mind fixing that?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.", + "prediction": "I don't think we need to use `torch.max` here. We can use `torch.gather` instead.", "reference": "Will this change the input `heatmap`? Is this behavior expected or not?" }, { - "prediction": "I'm not sure what you mean by \"isDigit\" and \"isLetter\" in this context. I think you meant \"isDigit\" and \"isLetterAny\" in this context.", + "prediction": "I don't think we need to do this. The `isDigit` and `isLetter` functions are already defined in the `strings` package, so we don't need to register them again.", "reference": "If I'm reading this right, this changes the parameter name so it'd constitute a breaking change :cold_sweat: Are we missing a test that should have been failing up until now?" }, { - "prediction": "Please remove the `@Autowired` from the class definition.", + "prediction": "This should be `@Autowired(required = true)` instead of `@Autowired(required = false)`.", "reference": "Need copyright/license info." }, { - "prediction": "I'm not sure what you mean by `admissionv1beta1` and `admissionv1beta1beta1`. I think you meant `admissionv1beta1` and `admissionv1beta1beta1`.", + "prediction": "I don't think we need to use `metav1` here. `admissionv1beta1` is the same as `admissionv1beta1.k8s.io`.", "reference": "Is this `info log` necessary? If it is not useful, can you consider deleting it?" }, { - "prediction": "I think this is not a good idea. We should always use `V0` and `RCLONE_ENCRYPT_V1` instead of `V1` and `RCLONE_ENCRYPT_V1`.", + "prediction": "I think this should be `assert.Error(t, err)` instead of `assert.NoError(t, err)`.", "reference": "Unrelated change, but seems to be the correct purpose of the test." }, { - "prediction": "I'm not sure what you mean by \"restrictions\" in this context. It's not clear to me what you're trying to do with it.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a unique `id` for each `input` element.", "reference": "Should it be `'uppy-input-`?" }, { - "prediction": "I think this should be `if (1)` instead of `if (true)`.", + "prediction": "I think this should be `if (0)` instead of `if (1)`.", "reference": "what's the reasoning to keep these always true or dead-code blocks?" }, { @@ -18619,11 +18619,11 @@ "reference": "I suggest that we rely on `--controllers='*,gateway-shim'` for now, and we can then move from `--controllers='*,gateway-shim'` to automatically enabling the Gateway API support on startup using the discovery API in 1.6 or 1.7, what do you think? Note that the logic I wrote in e5436df521015057e77de3fe02c174ea8a863b93 should also use this `GatewaySolverEnabled` flag I think." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a good idea to add a comment to explain what this code does. It's not clear to me what you're trying to achieve with this, but I think it's a good idea to add a comment to explain what this code does. It's not clear to me what you're trying to achieve with this, but I think it's a good idea to add a comment to explain what this code does. It's not clear to me what you're trying to achieve with this, but I think it's a good idea to add a comment to explain what this code does. It's not clear to me what you're trying to achieve with this, but I think it's a good idea to add a comment to explain what this code does. It's not clear to me what you're trying to achieve with this, but I think it's a good idea to add a comment to explain what this code does. It's not clear to me what you're trying to achieve with this, but I think it's a good idea to add a comment to explain what this code does. It's not clear to me what you're trying to achieve with this, but I think it's", + "prediction": "I'm not sure what you mean by \"vertx\" here. Could you please provide more context?", "reference": "I moved the instantiation of the signature algorithm here, to execute it before the native libraries are configured. Otherwise the wrong signature algorithm could be configured in a future release when more than one is supported in Besu." }, { - "prediction": "I'm not sure I understand what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add this to the `astroid` package. I don't think it's a good idea to add this to the `pylint` package.", "reference": "Why remove this?" }, { @@ -18635,7 +18635,7 @@ "reference": "Why not `ebpf::BPF bpf;`? Assuming that the instance is not huge, I do not think there is a good reason to use a pointer when it can be retained as a value." }, { - "prediction": "I'm not sure if this is a good idea, but I think we should have a separate package for this. It would be a good idea to have a `certmanager` package that contains all the common code for the `certmanager` and `certmanagerv1` packages. Then we could have a `certmanagerv1` package that contains all the common code for the `certmanagerv1` and `certmanagerv1beta1` packages. Then we could have a `certmanagerv1beta1` package that contains all the common code for the `certmanagerv1beta1` and `certmanagerv1beta2` packages. Then we could have a `certmanagerv1beta2` package that contains all the common code for the `certmanagerv1beta2` and `certmanagerv1beta3` packages. Then we could have a `certmanagerv1beta3` package that contains all the common code for the `certmanagerv1beta3` and `certmanagerv1beta4` packages. Then we could have a `certmanagerv1beta4` package that contains all the common code for the `certmanagerv1beta4` and `certmanagerv1beta5", + "prediction": "I don't think we need to use `apiutil` here. We can just use `github.com/jetstack/cert-manager/pkg/apis/certmanager/v1` directly.", "reference": "nit: move to last block" }, { @@ -18643,15 +18643,15 @@ "reference": "nit: I'm under the impression that `log` is the convention for golang, and that the `er` suffix is usually reserved for interfaces" }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it should be in the `DbProviderFactory` class.", + "prediction": "I'm not sure if this is the best place to put this, but I think it would be good to have this in the `DbProviderFactory.cs` file as well.", "reference": "Why is IsolationLevel fully qualified? System.Data is already in scope? What do I miss?" }, { - "prediction": "Shouldn't this be `*SealedEnvelope` instead of just `SealedEnvelope`?", + "prediction": "Shouldn't this be `*SealedEnvelope` instead of `SealedEnvelope`?", "reference": "do we still need SanityCheck()? seems they all return nil now" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get the closest document over the container. I think you're trying to get the closest document over the root element, but you're not using the `rootElement` property correctly.", + "prediction": "I'm not sure what you're trying to do with this, but I think it's a bad idea to use `this.rootElement` in this context. It's not clear what you're trying to do with it. If you want to get the nearest document over the root element, you should use `this.rootElement` directly. If you want to get the nearest element over the root element, you should use `this.rootElement.children[0]` or `this.rootElement.children[1]` depending on how you want to handle the case where the root element has no children.", "reference": "What I am missing in this PR, and I think we discussed that on the weekly meeting, is that all the code snippets that advise using `loadData` should be changed to one of the two new methods. Otherwise we send confusing mixed signals by promoting `loadData` everywhere in the guides. `loadData` is not deprecated, but is legacy." }, { @@ -18659,11 +18659,11 @@ "reference": "Line is too long. [100/80]" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `runBackup` function as well.", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be good to add a comment here that explains why we're doing this. I'm not sure if this is a good place to put this, but I think it would be good to add a comment here that explains why we're doing this. I'm not sure if this is a good place to put this, but I think it would be good to add a comment here that explains why we're doing this. I'm not sure if this is a good place to put this, but I think it would be good to add a comment here that explains why we're doing this. I'm not sure if this is a good place to put this, but I think it would be good to add a comment here that explains why we're doing this. I'm not sure if this is a good place to put this, but I think it would be good to add a comment here that explains why we're doing this. I'm not sure if this is a good place to put this, but I think it would be good to add a comment here that explains why we're doing this. I'm not sure if this is a good place to put this, but I think it", "reference": "I suggest \"no parent snapshot found, will read all data\\n\"." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure if you're trying to use `XmlLoggingConfiguration` or `XmlLoggingConfiguration.CreateFromXmlString`. I'm not sure what you're trying to do here. I'm not sure if you're trying to use `XmlLoggingConfiguration` or `XmlLoggingConfiguration.CreateFromXmlString`. I'm not sure what you're trying to do here. I'm not sure if you're trying to use `XmlLoggingConfiguration` or `XmlLoggingConfiguration.CreateFromXmlString`. I'm not sure what you're trying to do here. I'm not sure if you're trying to use `XmlLoggingConfiguration` or `XmlLoggingConfiguration.CreateFromXmlString`. I'm not sure what you're trying to do here. I'm not sure if you're trying to use `XmlLoggingConfiguration` or `XmlLoggingConfiguration.CreateFromXmlString`. I'm not sure what you're trying to do here. I'm not sure if you're trying to use `XmlLoggingConfiguration` or `XmlLoggingConfiguration.CreateFromXmlString`. I'm not sure what you're trying to do here. I'm not sure if you're trying to use `XmlLoggingConfiguration` or `XmlLoggingConfiguration.CreateFrom", + "prediction": "I'm not sure what you mean by \"throwExceptions = true\" in this case. I think you meant to say \"throwExceptions = false\".", "reference": "`LogManager.ThrowExceptions = true` has very special meaning when unit-testing. Why the change to `LogFactory.ThrowExceptions = true` and enabling after the config-load?" }, { @@ -18671,15 +18671,15 @@ "reference": "It should be return \"''\"; I will fix it" }, { - "prediction": "I think it's better to use `assertEquals(\"buz\", d.getImage());` instead of `assertEquals(\"buz\", d.getImage()); assertEquals(\"ArrayList\", ((TypedNameDeclaration) d).getTypeImage());`", + "prediction": "I think we can remove the `assertEquals(\"ArrayList\", ((TypedNameDeclaration) entry.getKey()).getTypeImage());` line.", "reference": "This is wrong, should be `entry.getValue()`" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the same place as the `kubeAPIServerNamedCerts` template, so that we don't have to change it every time we update the `kubeAPIServerNamedCerts` template. I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the same place as the `kubeAPIServerNamedCerts` template, so that we don't have to change it every time we update the `kubeAPIServerNamedCerts` template. I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the same place as the `kubeAPIServerNamedCerts` template, so that we don't have to change it every time we update the `kubeAPIServerNamedCerts` template. I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the same place as the `kubeAPIServerNamedCerts` template, so that we don't have to change it", "reference": "nit: why can't we combine the two add operations into one so that we add `{\"nameCertificates\": []}` to `/spec/servingCerts` ?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is it that you want to increment the segment lookup data? If that's the case, why not just use the segment lookup data directly?", + "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `holder` here. I think you want to use `sos_segment_lookup_data` instead.", "reference": "These whitespace only changes make it very difficult to review this change. Is there any way you could separate just the code changes into one PR and the whitespace only fixes into another? Or are they sufficiently merged together at this point? Chrome is having a real tough time rendering these large diffs." }, { @@ -18687,19 +18687,19 @@ "reference": "why does this suddenly need a config ref" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `watched: false` for the `custom-elements-es5-adapter.js` and `polyfills.js` files.", + "prediction": "I think we should be able to load it via CDN, but I'm not sure how to do that.", "reference": "Unfortunately, I couldn't find a way to get karma to conditionally load stuff from a CDN, so I had to include it." }, { - "prediction": "I think it's better to use `exclude` instead of `exclude_from` in this case. `exclude_from` is used when you want to exclude a specific function from the list of functions to be excluded. `exclude` is used when you want to exclude all functions from the list of functions to be excluded. `exclude_from` is used when you want to exclude a specific function from the list of functions to be excluded. `exclude` is used when you want to exclude all functions from the list of functions to be excluded.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a list of all the functions that we want to exclude. This way, we don't have to worry about forgetting to add a function to the exclude list when we add a new one.", "reference": "Those functions are not currently wrapped, so I don't think it is necessary to exclude them (at least for now)." }, { - "prediction": "I'm not sure what you mean by \"coercing *time.Timer into stoppable implicitly if we write it out like so.\"", + "prediction": "I'm not sure I understand what you're trying to do here. I think you want `afterFunc` to be a `stoppable` function that takes a `clock.Clock` and a `time.Duration` and returns a `stoppable` function that takes a `time.Duration` and returns a `stoppable` function that takes a `time.Duration` and returns a `stoppable` function that takes a `time.Duration` and returns a `stoppable` function that takes a `time.Duration` and returns a `stoppable` function that takes a `time.Duration` and returns a `stoppable` function that takes a `time.Duration` and returns a `stoppable` function that takes a `time.Duration` and returns a `stoppable` function that takes a `time.Duration` and returns a `stoppable` function that takes a `time.Duration` and returns a `stoppable` function that takes a `time.Duration` and returns a `stoppable` function that takes a `time.Duration` and returns a `stoppable` function that takes a `time.Duration` and returns a `stoppable` function that takes a `time.Duration` and returns a `", "reference": "Nit: since this is now a private function rather than a variable, would it make sense to move it after the public functions in this file for readability?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to set the colour of the `QPen` to the same colour as the `QColor` passed to `setColour()`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be better to do this in the `MolDraw2DQt` constructor.", "reference": "I'm assuming that MolDraw2Qt drops the alpha channel?" }, { @@ -18707,35 +18707,35 @@ "reference": "the code looks good to me, but I just wonder if it is a real use case: (de)serializing a single integer." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to remove the @ mark from the formula, but I'm not sure what you're trying to do with the @ mark in the first place.", + "prediction": "I don't think this is necessary.", "reference": "Pls remove the print statements. Also, you do not need the if statement." }, { - "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to escape the string value in this way.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `sqs_responses.py` file.", "reference": "Thanks for this fix @eltone ! Wondering if we should make this a bit more resilient to upstream changes, e.g., via a regex replacement. Not critical, though - we can pick that up in a follow-up PR.. Thanks" }, { - "prediction": "I think we can remove `elastic.SetRetrier(retrier)` since it's not used anymore.", + "prediction": "I don't think we need to do this, we can just use `elastic.NewClient(elastic.SetRetrier(retrier))`", "reference": "Should this be instead a configurable option?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `CreateDisk` method to create the disk, and then use the `GetDisk` method to get the disk. This way, we don't have to worry about creating the disk, and we don't have to worry about getting the disk.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if we have a source snapshot. If we don't have a source snapshot, we can fall back to pd-standard. If we do have a source snapshot, we can fall back to pd-standard as well.", "reference": "unit test needs an update?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to use the `authProvider` to get the `authToken` from the `authProvider`, but I'm not sure what you're trying to do with that.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a `provider` property on the `Provider` class.", "reference": "I realised that this is not used anywhere" }, { - "prediction": "I think this should be `case <-stopCh` instead of `case <-stopCh: close(sigChan)`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `watcher.go` file.", "reference": "why add the default branch? this may cause there exist multiple configWatchers that notify the eventsCh at the same time?" }, { - "prediction": "I'm not sure what you mean by \"ignore endpoint number 0\"", + "prediction": "I'm not sure what you mean by \"ignore endpoint number 0 (setup)\". I think you're referring to the `setEPINTENCLR(0, sam.USB_DEVICE_EPINTENCLR_STALL1)` line.", "reference": "This line appears to have caused the regression. What is it supposed to be doing?" }, { - "prediction": "I think we can remove the `if isinstance(attr_value, dict) and 'string' in attr_value and attr_value['string'] is not None and attr_value['string'] == value:` check.", + "prediction": "I think we can remove the `if isinstance(attr_value, dict) and 'string' in attr_value and attr_value['string'] is not None and attr_value['string'] == value` check.", "reference": "# `attr_value['string'] is not None` probably not required as `attr_value['string'] == value` check is already being done" }, { @@ -18743,15 +18743,15 @@ "reference": "@alanwest I noticed this while changing the code. I think we _might_ run into some race condition - if a scraper happens to hit the HTTP server before we could add the reader, what would happen (I guess we will hit exception, which turns into HTTP 500)? I haven't looked into the HTTP server logic. I think it _might_ be OKAY. A better version could be - we only start the HTTP server once the exporter/reader are fully ready and both are hooked up to the provider." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `WaitForExit` and not `WaitForExitAsync` because `WaitForExitAsync` will throw an exception if the process doesn't exit.", + "prediction": "I think we can remove the `if (!process.WaitForExit(5000))` line.", "reference": "As for Owin, I think we should exclude this URL in `IsNotServerLifeCheck` too?" }, { - "prediction": "I think this should be `Func` instead of `Func`.", + "prediction": "I think this should be `public Func HttpClientFactory { get; set; }` instead of `public Func HttpClientFactory { get; set; }`", "reference": "Does it make sense to just fold these options back into the exporter options? My thinking is that this option is unlike the processor/metric reader options in that it actually is about the exporter itself." }, { - "prediction": "I think it's better to remove the `|` at the end of the first line.", + "prediction": "I don't think we need to change this.", "reference": "here is `:seconds` missing" }, { @@ -18759,51 +18759,51 @@ "reference": "change of name is not needed" }, { - "prediction": "I think this is a bug. The `name` property should be `None` instead of `NoneType`.", + "prediction": "I think this is a bug. The `name` property should be `None` when `name` is `None` and `name` should not be `None` when `name` is not `None`.", "reference": "Hm .. so this case doesn't work anymore?" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's better to use `QProcess.exec_()` instead of `QProcess.startDetached()`. `startDetached()` returns a `QProcess.StartDetached` object, which can be used to check if the process is still running. `exec_()` returns a `QProcess.Executable` object, which can be used to check if the process is still running.", + "prediction": "I think this should be `from PyQt5.QtCore import pyqtSignal, pyqtSlot, QObject, QProcess, QFileSystemWatcher`", "reference": "Please indent this so it lines up with the `(`" }, { - "prediction": "I'm not sure if this is needed or not, but I think it's good to have this in there. I'm not sure if this is needed or not, but I think it's good to have this in there. I'm not sure if this is needed or not, but I think it's good to have this in there. I'm not sure if this is needed or not, but I think it's good to have this in there. I'm not sure if this is needed or not, but I think it's good to have this in there. I'm not sure if this is needed or not, but I think it's good to have this in there. I'm not sure if this is needed or not, but I think it's good to have this in there. I'm not sure if this is needed or not, but I think it's good to have this in there. I'm not sure if this is needed or not, but I think it's good to have this in there. I'm not sure if this is needed or not, but I think it's good to have this in there. I'm not sure if this is needed or not, but I think it's good to have this in there. I'm not", + "prediction": "I'm not sure if this is needed or not, but I'd like to make sure that the plugin is loaded before the main script is loaded.", "reference": "We should still register the script. Just not enqueue it." }, { - "prediction": "I think this should be a method, not a block.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to `attribute_changed?` and `attribute_change?` so that we don't have to call `attribute_changed?` every time we call `attribute_change?` or `attribute_change!`.", "reference": "I think this can stay as a method. And we can write our own attribute_change(name) as required." }, { - "prediction": "I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the `OnBindViewHolder` method is called before the `OnCreateViewHolder` method is called.", "reference": "@alexshikov @Cheesebaron I might be missing something but isn't the viewType parameter here the actual layout resource id? Why would the GetItemLayoutId method need to be called again? On line 127, the exact same method is called except this time passing in the index of the object in the backing data source, which makes sense - the template selector can return the layout id based on the index of the item in the list." }, { - "prediction": "I'm not sure what you're trying to do here. Is this for a specific use case? If so, please provide more context.", + "prediction": "I'm not sure what you're trying to do here. Is there a specific reason you want to use `self.project_id` and `self.dataset_id` instead of `self.project_id` and `self.dataset.dataset_id`?", "reference": "Can you change this to use `.format()`?" }, { - "prediction": "I think we can remove the `if dropEncap && r.Config.DropVXLANPacketsFromWorkloads` check.", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to add a rule to drop VXLAN packets originating in pods, but I'm not sure what you're trying to do with the `DropIPIPPacketsFromWorkloads` flag. Could you please clarify what you're trying to do here?", "reference": "Maybe the parameter should be consulted higher up the stack so that we only set dropEncap if we're rendering a workload egress chain and the flag is set?" }, { - "prediction": "I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure", + "prediction": "I'm not sure what you're trying to say here. I think you're trying to say that the `SectorBuilder` is no longer in use, but I'm not sure what you mean by \"SectorBuilder metadata will not be deleted when Close is called\". I think you're trying to say that the `SectorBuilder` is no longer in use, but I'm not sure what you mean by \"SectorBuilder metadata will not be deleted when Close is called\". I think you're trying to say that the `SectorBuilder` is no longer in use, but I'm not sure what you mean by \"SectorBuilder metadata will not be deleted when Close is called\". I think you're trying to say that the `SectorBuilder` is no longer in use, but I'm not sure what you mean by \"SectorBuilder metadata will not be deleted when Close is called\". I think you're trying to say that the `SectorBuilder` is no longer in use, but I'm not sure what you mean by \"SectorBuilder metadata will not be deleted when Close is called\". I think you're trying to say that the `SectorBuilder` is no longer in use, but I'm not sure what you mean by \"SectorBuilder metadata will not be deleted when Close is", "reference": "new casing is less ELiTE" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to `wlr_renderer_blit_dmabuf` and `wlr_renderer_renderbuffer_from_image`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in `wlr_renderer_blit_dmabuf` as well.", "reference": "This leaks EGL/GL implementation details into the generic renderer interface." }, { - "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea to have a `doc_path` in the `DeployConditionError` class. I think it's better to have a `doc_path` in the `DeployConfigError` class.", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a new class that inherits from `Travis::DeployConditionError` and `Travis::AptSourcesConfigError`. Is this what you're trying to do?", "reference": "Maybe add *key* i.e. `\"The \\\\`deploy.on\\\\` key should be a hash (dictionary).`" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way", + "prediction": "I'm not sure if this is the best way to do it, but I think it's a good idea to use the `Color` class instead of the `String` class.", "reference": "its be good also change $code na $id, actual name is misleading and that was probably actual error generator" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to sort the recent listens by time. I'm not sure what you're trying to achieve with this, but it looks like you're trying to sort the recent listens by time. I'm not sure what you're trying to achieve with this, but it looks like you're trying to sort the recent listens by time. I'm not sure what you're trying to achieve with this, but it looks like you're trying to sort the recent listens by time. I'm not sure what you're trying to achieve with this, but it looks like you're trying to sort the recent listens by time. I'm not sure what you're trying to achieve with this, but it looks like you're trying to sort the recent listens by time. I'm not sure what you're trying to achieve with this, but it looks like you're trying to sort the recent listens by time. I'm not sure what you're trying to achieve with this, but it looks like you're trying to sort the recent listens by time. I'm not sure what you're trying to achieve with this, but it looks like you're trying to sort the recent listens by time. I'm not sure", + "prediction": "I think it's a good idea to have a `RECENT_LISTENS_KEY` and `RECENT_LISTENS_MAX` in the `RedisListenStore` class.", "reference": "I changed the name of the key, to make deployment easier." }, { @@ -18811,39 +18811,39 @@ "reference": "isn't this going to be true by default? if yes, then let's have the env var named `ECS_DISABLE_SPOT_INSTANCE_DRAINING` and have default as false." }, { - "prediction": "I think we can remove the `from __future__ import unicode_literals` line.", + "prediction": "I think this should be `from __future__ import unicode_literals` instead of `from __future__ import unicode_literals, unicode_literals`", "reference": "Do you think we might need this anywhere else in HoloViews?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `getDisplayPlayMethod` function, since it's used in both `getDisplayPlayMethod` and `getTranscodePlayMethod`.", "reference": "@MrTimscampi don't we want to remove this term entirely? Might as well do it now if that's the case." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to use the `asciidoctor` command to translate an AsciiDoc source file into the backend output format (e.g., HTML 5, DocBook 4.5, etc.) and then write the translated output to a file with the basename of the source file and the appropriate extension. Is this what you're trying to do?", + "prediction": "I'm not sure I understand what you're trying to do here. What is the output format that you want to use?", "reference": "I have followed the convention of `cp`" }, { - "prediction": "I don't think we need to change `flags` in `mysqli::begin_transaction` to `flags` in `mysqli::commit`.", + "prediction": "I don't think we need to change the `flags` value for `mysqli::commit` and `mysqli::begin_transaction`.", "reference": "The docs say it's `false|null`" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to set the trip time to 5s, but I'm not sure what you're trying to do here. I think you're trying to set the trip time to 5s, but I'm not sure what you're trying to do here. I think you're trying to set the trip time to 5s, but I'm not sure what you're trying to do here. I think you're trying to set the trip time to 5s, but I'm not sure what you're trying to do here. I think you're trying to set the trip time to 5s, but I'm not sure what you're trying to do here. I think you're trying to set the trip time to 5s, but I'm not sure what you're trying to do here. I think you're trying to set the trip time to 5s, but I'm not sure what you're trying to do here. I think you're trying to set the trip time to 5s, but I'm not sure what you're trying to do here. I think you're trying to set the trip time to 5s, but I'm not sure", + "prediction": "I think it's better to use a single field for the `Type` and `TripTime` instead of two separate fields.", "reference": "Thinking on it more, I actually really like your idea to rename `type` to `factor`." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `shouldBlockNetworkData` property to the `MessageWebView` class. This way, we can make sure that the `shouldBlockNetworkData` property is set to `true` only if the `shouldBlockNetworkData` property is set to `true` in the `MessageWebView` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `shouldBlockNetworkData` property to the `MessageWebView` class. This way, we can make sure that the `shouldBlockNetworkData` property is set to `true` only when the `shouldBlockNetworkData` property is set to `true` and `shouldBlockNetworkData` is not set to `false`.", "reference": "This error message is redundant. All of this information is included in the stack trace. In general it's a good idea to avoid using method names in error messages. Chances are the method will be renamed at some point, but the string won't be updated accordingly. Then you'll end up with a very confusing error message. I suggest changing the message to: \"Failed to unblock network loads. Missing INTERNET permission?\"" }, { - "prediction": "I'm not sure what you're trying to achieve with this code. It's not clear to me what you're trying to achieve with this code. It's not clear to me what you're trying to achieve with this code. It's not clear to me what you're trying to achieve with this code. It's not clear to me what you're trying to achieve with this code. It's not clear to me what you're trying to achieve with this code. It's not clear to me what you're trying to achieve with this code. It's not clear to me what you're trying to achieve with this code. It's not clear to me what you're trying to achieve with this code. It's not clear to me what you're trying to achieve with this code. It's not clear to me what you're trying to achieve with this code. It's not clear to me what you're trying to achieve with this code. It's not clear to me what you're trying to achieve with this code. It's not clear to me what you're trying to achieve with this code. It's not clear to me what you're trying to achieve with this code. It's not clear to me what you're trying to achieve with this code. It's", + "prediction": "I'm not sure what you're trying to achieve with this. It seems like you're trying to use the SHGetFolderPath function to get the path of a special folder, but you're not using it to get the path of a regular folder.", "reference": "Feel free to add your own name while at it." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.", + "prediction": "I don't think it's necessary to have a `signer` field in the `ActionCmd` struct. We can just use the `signer` field from the `AccountCmd` struct.", "reference": "`signer` is a global variable (from `gochecknoglobals`)" }, { - "prediction": "I'm not sure what you're trying to do with this method, but I think it should be removed.", + "prediction": "I think this should be `normalized_key` instead of `localized_key`?", "reference": "shouldn't this be `&& opts[:localize]` (i.e. both nil and false skip localization?)" }, { @@ -18851,15 +18851,15 @@ "reference": "This can also be removed." }, { - "prediction": "I'm not sure what you mean by `const char *key, const char *ns, const char *target`", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to `flux_kvs_txn_put_raw` and `flux_kvs_txn_symlink`.", "reference": "Not critical but \"common\" is not that helpful in the commit title. Maybe go with \"libkvs/txn:\" for this one?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `settings.py` file as well. I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `settings.py` file as well. I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `settings.py` file as well. I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `settings.py` file as well. I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `settings.py` file as well. I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `settings.py` file as well. I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `settings.py` file as well. I'm not sure if this is the right place to", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `YamlConfig` class, since it will be used by other classes as well.", "reference": "It's been a while, but I just noticed this was wrong: It migrated `True` to `when-searching` (so people with `scrolling.bar = True` suddenly didn't have scrollbars anymore) and `False` to never. Instead, it should migrate `True` to `always` (no behavior change) and `False` to `when-searching` (so people notice the new feature). I fixed this in cc0f5fc6d400e12833ba729049e31d16cf836d53." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `os.path.realpath` instead of `os.path.expanduser` here. This is because `os.path.expanduser` will expand the user's home directory, which is not what we want here. `os.path.realpath` will only expand the current user's home directory, which is what we want here.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `os.path.realpath` instead of `os.path.expanduser`.", "reference": ".decode(sys.getfilesystemencoding()) will be better. Although I think rrdtool should accept bytes.." }, { @@ -18867,19 +18867,19 @@ "reference": "An interface call per header might be more expensive than we want to pay. Do we really need this to be abstracted? I think a parser abstraction makes sense, but it seems to me like a separate abstraction for handling headers (one by one) might be an overkill." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `Write` method to the `TargetWithFilterChain` class that takes a `TargetWithFilterChain` and a `LogEventInfo` as parameters. This would allow us to pass in the `TargetWithFilterChain` and `LogEventInfo` to the `TargetWithFilterChain` constructor, which would allow us to pass in the `TargetWithFilterChain` and `LogEventInfo` to the `TargetWithFilterChain` constructor, which would allow us to pass in the `TargetWithFilterChain` and `LogEventInfo` to the `TargetWithFilterChain` constructor, which would allow us to pass in the `TargetWithFilterChain` and `LogEventInfo` to the `TargetWithFilterChain` constructor, which would allow us to pass in the `TargetWithFilterChain` and `LogEventInfo` to the `TargetWithFilterChain` constructor, which would allow us to pass in the `TargetWithFilterChain` and `LogEventInfo` to the `TargetWithFilterChain` constructor, which would allow us to pass in the `TargetWithFilterChain` and `LogEvent", + "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place", "reference": "Resharper annotations, always +1" }, { - "prediction": "I don't think we need to mark the flag as hidden.", + "prediction": "I don't think we need to mark it as hidden.", "reference": "same here, CryptoSm2 won't be changed once command is compiled" }, { - "prediction": "I don't think this is needed anymore.", + "prediction": "I don't think we need to use `runOnUiThread` here.", "reference": "Loading the login page after the certificate has been loaded. Views can only be loaded from UI thread." }, { - "prediction": "I think this should be `if err != nil { ... }` instead of `if err != nil { err := c(config); if err != nil { ... } }`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.", "reference": "Technically it doesn't belong here; let me remove it." }, { @@ -18895,63 +18895,63 @@ "reference": "FYI This will go the other way, with nil being the correct value for \"no params\"" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to add to the `nonPeptideKeySet` if it's already in the `PeptideLibraryKey[]` array.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to add to `nonPeptideKeySet` if it's already been added to `PeptideLibraryKey[] thisKeysWithUnmodSeq`. If you want to add to `PeptideLibraryKey[] thisKeysWithUnmodSeq`, you should do that in the `PeptideLibraryKey` constructor.", "reference": "Is this necessary? Are there duplicates in your LibKeyIndex?" }, { - "prediction": "I'm not sure what you're trying to do here. It seems like you're trying to mock the `Next` method of the `MockActionIterator` struct, but you're not actually doing that. You're just calling the `Next` method of the `MockActionIterator` struct, which is not what you want to do.", + "prediction": "I don't think we need to call `m.ctrl.T` here. We can just use `m.ctrl` directly.", "reference": "Why will the gomock files be regenerated? It seems to be irrelevant" }, { - "prediction": "I'm not sure what you mean by `make(chan *model.ReportableCommand, 1)`. I think you meant to say `make(chan *model.ReportableCommand)`.", + "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason you want to use `make(chan *model.ReportableCommand, 1)` instead of `make(chan *model.ReportableCommand, 0)`?", "reference": "I'm very curious about why using buffered-channel. Is there something wrong to use an unbuffered channel with zero capacity?" }, { - "prediction": "I'm not sure what you're trying to do here. Is it possible that you're trying to run a task that doesn't exist? I'm not sure what you're trying to do here. Is it possible that you're trying to run a task that doesn't exist? I'm not sure what you're trying to do here. Is it possible that you're trying to run a task that doesn't exist? I'm not sure what you're trying to do here. Is it possible that you're trying to run a task that doesn't exist? I'm not sure what you're trying to do here. Is it possible that you're trying to run a task that doesn't exist? I'm not sure what you're trying to do here. Is it possible that you're trying to run a task that doesn't exist? I'm not sure what you're trying to do here. Is it possible that you're trying to run a task that doesn't exist? I'm not sure what you're trying to do here. Is it possible that you're trying to run a task that doesn't exist? I'm not sure what you're trying to do here. Is it possible that you're trying to run a task that doesn't exist? I'm not sure", + "prediction": "I'm not sure what you mean by \"See the License for the specific language governing permissions and limitations under the License.\"", "reference": "It seems like you accidentally pulled some unrelated changes to util_test into this." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add a comment to explain what this change does.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea.", "reference": "do not toucm NDM please - there will be lots of conflicts" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not clear what you're trying to achieve with this change, but I think it's a bad idea. It's not", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to change the `toString()` method of `IndexableField` to `toInstant().toString()`.", "reference": "This looks legitimate - Would cause a classCastException. But have we ever seen it in the wild?" }, { - "prediction": "I'm not sure what you mean by `setup-show: True`? I'm not sure what you're trying to do here.", + "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to have a `setup-show` option for the `testinfra` test.", "reference": "This looks out of scope for this particular PR." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I think it's better to use `leafDefaultFirstPingInterval` instead of `leafFirstPingInterval` in this case.", "reference": "Don't need () if only one." }, { - "prediction": "`mailUser` and `mailPassword` should be `String` instead of `java.lang.String`", + "prediction": "`mailUser` and `mailPassword` should be `String` instead of `String`", "reference": "Why not have mailPort as int since your are already parsing while calling t.connect ?" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's better to use `>=3.0` instead of `<3.0` in the `install_requires` list.", + "prediction": "I'm not sure if this is the right place to add this, but I think it would be a good idea to add it to `requirements.txt` as well.", "reference": "In the future, do not remove these trailing commas as they have the purpose of making append-diffs easier to read. :)" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.", + "prediction": "I think this should be `isset($this->fields['lccn'])` instead of `isset($this->fields['lccn']) ? $this->fields['lccn'] : ''`", "reference": "Was this added by accident? It doesn't seem related to Syndetics, and I don't think it should be necessary in core VuFind (but maybe it's related to one of your local customizations)." }, { - "prediction": "I don't think we need to add `AllowUnauthenticatedVerifiers` to the `Config` struct. It's already there in the `Attestor` struct.", + "prediction": "I don't think we need to change the `AllowUnauthenticatedVerifiers` field. It's already set to `false` by default.", "reference": "i know the ergonomics are a little nicer with map[string]bool, but I prefer map[string]struct{} for sets for a few reasons: 1 - optimized storage (not very relevant here) 2 - don't have to think about the conditions where the key exists in the map or if the value could somehow be false" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to have a `Server` type.", + "prediction": "I don't think we need to add `NumServices` to the `Server` struct. It's already defined in the `Worker` struct.", "reference": "This is very unclear what Server means. We need a better name, maybe ServerExtension?" }, { - "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea.", + "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to run this test. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to run this test. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to run this test. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to run this test. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to run this test. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to run this test. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to run this test. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to run this test. It's not clear what you're trying to achieve with this test, but I", "reference": "I wonder if we should trigger a PHP error and ensure it ends up in the log?" }, { - "prediction": "I think this should be `replace(/&/g, '&')` instead of `replace(/&/g, '&')`", + "prediction": "I think this should be `replace(/&/g, '&')` instead of `replace(/&/g, '&')`.", "reference": "Hmmm not sure about this. Is it fine @ar2rsawseen?" }, { @@ -18959,11 +18959,11 @@ "reference": "Why do you prefer `go` over `run`?" }, { - "prediction": "I'm not sure what you're trying to do here. Is it possible that you're trying to mock the `ReceiveMessageAsync` method of the `CommunicationManager`? I'm not sure what you're trying to do here. Is it possible that you're trying to mock the `ReceiveMessageAsync` method of the `CommunicationManager`? I'm not sure what you're trying to do here. Is it possible that you're trying to mock the `ReceiveMessageAsync` method of the `CommunicationManager`? I'm not sure what you're trying to do here. Is it possible that you're trying to mock the `ReceiveMessageAsync` method of the `CommunicationManager`? I'm not sure what you're trying to do here. Is it possible that you're trying to mock the `ReceiveMessageAsync` method of the `CommunicationManager`? I'm not sure what you're trying to do here. Is it possible that you're trying to mock the `ReceiveMessageAsync` method of the `CommunicationManager`? I'm not sure what you're trying to do here. Is it possible that you're trying to mock the `ReceiveMessageAsync` method of the `CommunicationManager`? I'm not sure what you're trying to do here", + "prediction": "I think this should be `message2` instead of `message1`?", "reference": "Unintentional, please remove" }, { - "prediction": "I'm not sure what you're trying to achieve with this code, but it looks like you're trying to add the user to the mailing list and the GitHub team. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to add the user to the mailing list and the GitHub team. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to add the user to the mailing list and the GitHub team. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to add the user to the mailing list and the GitHub team. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to add the user to the mailing list and the GitHub team. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to add the user to the mailing list and the GitHub team. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to add the user to the mailing list and the GitHub team. I'm not sure what you're trying to achieve with this code, but it looks like", + "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a good idea to add a `deactivated_on` column to the `subscriptions` table.", "reference": "What was the reason behind moving this?" }, { @@ -18971,15 +18971,15 @@ "reference": "Did you mean to put that `join` after the `map` rather than inside it? Also should it be `safe_join` or is interpolating it into an `_html` resource going to have much the same effect>" }, { - "prediction": "I think we should remove the `readonly` from `isInTransaction` and `isClosed`.", + "prediction": "I think we should add a `closed` property to the `Realm` class, so that we can check if the Realm is closed or not.", "reference": "`Indicates if this Realm has been closed.`?" }, { - "prediction": "I think this should be `convert_objects` instead of `convert`", + "prediction": "I think we should remove `cov` and `corr` from the list of unsupported functions.", "reference": "how is this change adding corr to Series? Do all the methods that are added to Frame automatically get added to Series?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this, so that we don't have to call it multiple times.", + "prediction": "`builtin.Actors` should be `syncer.Actors`", "reference": "Just a heads up for anyone else reviewing this, this logic and all the repetitions of it should be greatly simplified by subsequent work relating to issue #2552." }, { @@ -18987,15 +18987,15 @@ "reference": "@billwert I have kept the `1000` InvocationsPerIteration, but do note this is very small for the small types." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to have a `Command` class that extends `misc.MinimalLineEditMixin` and `misc.CommandLineEdit`. The `Command` class should be a subclass of `misc.Command`, not a subclass of `misc.MinimalLineEditMixin` and `misc.CommandLineEdit`.", "reference": "Unrelated whitespace change." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right way to do it.", + "prediction": "I think this should be `std::unique_ptr writeTransaction;` instead of `std::unique_ptr writeTransaction = std::make_unique (environment, nullptr, true);`", "reference": "Slight formatting issue here. There should be a space after the asterisk." }, { - "prediction": "I'm not sure what you mean by \"isHidden\" in this context. It's not clear what you're trying to do with this function.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to check if the node is an element first. If it is, then we can use `isHidden` on it.", "reference": "Slight preference for declaring variables inline rather than at the top of the function. That way you can use const for both of these." }, { @@ -19007,7 +19007,7 @@ "reference": "Nit: unified names between geth and contracts" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason why you want to use `serverState` instead of `clientState`?", + "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", "reference": "Necessary? Could you just use DefaultBuildState here?" }, { @@ -19015,23 +19015,23 @@ "reference": "linked hashmap retains order" }, { - "prediction": "I think this should be `if (drmSetClientCap(backend->fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1)) {`", + "prediction": "I'm not sure if this is a good place to put this, but I think it should be in `backend/drm-util.h` instead of `backend/drm/drm-util.h`.", "reference": "And the old names for these variables made more sense imo." }, { - "prediction": "I think we can remove the `if` statement here.", + "prediction": "I think we can remove the `range` check here.", "reference": "Are you sure this change is correct?" }, { - "prediction": "I'm not sure if this is a bug or a feature. I think it's a bug, but I'm not sure how to fix it. I think it's a feature, but I'm not sure how to fix it.", + "prediction": "I'm not sure if this is a bug or a feature. I think it's a bug, but I'm not sure how to fix it. I'm not sure if this is a bug or a feature. I think it's a bug, but I'm not sure how to fix it. I'm not sure if this is a bug or a feature. I think it's a bug, but I'm not sure how to fix it. I'm not sure if this is a bug or a feature. I think it's a bug, but I'm not sure how to fix it. I'm not sure if this is a bug or a feature. I think it's a bug, but I'm not sure how to fix it. I'm not sure if this is a bug or a feature. I think it's a bug, but I'm not sure how to fix it. I'm not sure if this is a bug or a feature. I think it's a bug, but I'm not sure how to fix it. I'm not sure if this is a bug or a feature. I think it's a bug, but I'm not sure how to fix it. I'm not sure if this is a bug or a feature. I think it", "reference": "The previously linked bug does not apply anymore? If so, this is LGTM!" }, { - "prediction": "I'm not sure what you're trying to do with this test, but I don't think it's a good idea to fail over in this way.", + "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to test here.", "reference": "Why are we renaming all of the tests?" }, { - "prediction": "I'm not sure what you mean by \"RFC2136 nameserver missing\"", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `strings.TrimSpace` function to remove any leading or trailing whitespace from the input string.", "reference": "Instead of having this logic, would it make sense to require *users* to encompass the specified IPv6 address within `[` and `]`? Why the magic handling here?" }, { @@ -19039,7 +19039,7 @@ "reference": "Why not also replace this one with calls to `GetProp`?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right way to do it.", + "prediction": "I think this should be `if (self.numWinners > 0) and (self.numWinners < (inputPattern > 0).sum())`", "reference": "Still need to remove trailing spaces on this line" }, { @@ -19051,11 +19051,11 @@ "reference": "I found ~10 more instances of this typo. we can fix those in subsequent PRs." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a separate file, so that it can be reused in other places.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to `init.go` instead of `main.go`.", "reference": "How about making metricNamespace an option, and by default it's the same as `component`? e.g.m Init(component, WithMetricNamespace(\"trigger\"))" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `NodeJSSampleMethodToViewTransformer` class, so that it can be used in other places as well.", + "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to get the page token from the response, and then use it to get the next page token from the request. Is this what you're trying to do? If so, how are you getting the page token from the response, and how are you getting the request page token from the request?", "reference": "Just checking: no need for case manipulation?" }, { @@ -19067,15 +19067,15 @@ "reference": "> i#4670 signl-interrupted special ibl xfer frag: Unlink if signal pending nit: This looks like one of many commits with the text before the colon. nit: On the long side: 56 or 60 chars is what some views show Spelling error." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `flb_pipe_r` function as well. It's not clear to me if this is the right place to do this, but I think it's a good idea to do this in the `flb_pipe_r` function as well. It's not clear to me if this is the right place to do this, but I think it's a good idea to do this in the `flb_pipe_r` function as well. It's not clear to me if this is the right place to do this, but I think it's a good idea to do this in the `flb_pipe_r` function as well. It's not clear to me if this is the right place to do this, but I think it's a good idea to do this in the `flb_pipe_r` function as well. It's not clear to me if this is the right place to do this, but I think it's a good idea to do this in the `flb_pipe_r` function as well. It's not clear to me if this is the right place to do this, but I think it's a good idea", "reference": "Should we need to invoke pthread_cancel ?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `postUserDomain` method in the `UserDomainResource` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the `postUserDomain` method as well. It's not clear to me if this is the right place to do this, but I think it would be good to have this in the `postUserDomain` method as well. It's not clear to me if this is the right place to do this, but I think it would be good to have this in the `postUserDomain` method as well. It's not clear to me if this is the right place to do this, but I think it would be good to have this in the `postUserDomain` method as well. It's not clear to me if this is the right place to do this, but I think it would be good to have this in the `postUserDomain` method as well. It's not clear to me if this is the right place to do this, but I think it would be good to have this in the `postUserDomain` method as well. It's not clear to me if this is the right place to do this, but I think it would be good to have this in the `postUserDomain` method as well", "reference": "this is auto generated file so no changes are allowed here" }, { - "prediction": "I think this should be `if (!node.querySelectorAll(':not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not", + "prediction": "I think this should be `!node.querySelectorAll(':not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([disabled]):not([", "reference": "All buttons are submit buttons, except if they are `type=reset` or `type=button`. I suggest you do an exclude of those, rather than only include `button[type=submit]`." }, { @@ -19083,7 +19083,7 @@ "reference": "can you please make this multi line, this version is hard to read." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `HorizontalFlyout` constructor, so that it can be used in other places as well.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `setMetrics_` method.", "reference": "For consistency, it's best to either always use strict equality (`===`) or loose equality (`==`) in `typeof` checks, and to not mix them." }, { @@ -19099,27 +19099,27 @@ "reference": "This is the only \"extra\" change here." }, { - "prediction": "Shouldn't this be `bypassBLSSignatureCheck` instead of `allowHighNonce`?", + "prediction": "I don't think this is necessary.", "reference": "Please TODO and link to an issue for changing this." }, { - "prediction": "I think it's better to use `addMore` instead of `addBulkFilesFailed`?", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `en_US.strings` object here.", "reference": "Can we make the script output trailing commas?" }, { - "prediction": "I think we should remove the `widgets` from the `featureFlags` object.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate file for this.", "reference": "This file should get a file header" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to include `BufferFlusher.h` in this file.", + "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to move this to the `kvstore/wal` namespace. It's a bit more consistent with the rest of the code.", "reference": "maybe we need process the os error more safely and friendly when open file failed, because this error is very common when cpu has a high pressure, crash directly is danger." }, { - "prediction": "I don't think this is necessary. We can just use `big.NewInt(0)` here.", + "prediction": "I don't think this is necessary.", "reference": "we need to pay attention not to use this flag everywhere." }, { - "prediction": "I think we should use `uint32` for `GroupIDType` and `MeterIDType` instead of `uint8` and `uint32`.", + "prediction": "I think we should use `uint32` for `TableIDType` and `uint8` for `GroupIDType` and `uint32` for `MeterIDType`.", "reference": "curious about this change, since it is not mentioned in the commit message and now we have `uint8` all over the place" }, { @@ -19131,19 +19131,19 @@ "reference": "oh. didn't know we store this stage progress." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to get a list of all Unicode characters that are not in the `unicodeNonBmpRegExp` but I'm not sure what you're trying to do here.", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a regular expression that matches all Unicode non-BMP characters, but I don't think that's what you're trying to do.", "reference": "Going with definition from here: > Does Unicode have private-use characters? > A: Yes. There are three ranges of private-use characters in the standard. The main range in the BMP is U+E000..U+F8FF, containing 6,400 private-use characters. That range is often referred to as the Private Use Area (PUA). But there are also two large ranges of supplementary private-use characters, consisting of most of the code points on Planes 15 and 16: U+F0000..U+FFFFD and U+100000..U+10FFFD. Together those ranges allocate another 131,068 private-use characters. Altogether, then, there are 137,468 private-use characters in Unicode. It looks like we are only ignoring ones in BMP and not the supplementary private-use characters. Shouldn't we consider the supplementary ones too?" }, { - "prediction": "I'm not sure what you're trying to achieve here. I think you're trying to get the type of the return value of the function, but you're not using the `returnType` property of the `FunctionCallReturnTypeFetcher` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate type for `TInt` and `TPositiveInt` so that we don't have to worry about whether we're dealing with a `TInt` or a `TPositiveInt`.", "reference": "This change is un-tested and requires testing" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a default value for the `comms` parameter. This way, if the user doesn't specify a value, it will default to `default`.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a default value for `comms` so that if the user doesn't specify it, it defaults to `default` instead of `ipywidgets` or `vscode`. I'm not sure if this is the best way to do this, but I think it's a good idea to have a default value for `comms` so that if the user doesn't specify it, it defaults to `default` instead of `ipywidgets` or `vscode`. I'm not sure if this is the best way to do this, but I think it's a good idea to have a default value for `comms` so that if the user doesn't specify it, it defaults to `default` instead of `ipywidgets` or `vscode`. I'm not sure if this is the best way to do this, but I think it's a good idea to have a default value for `comms` so that if the user doesn't specify it, it defaults to `default` instead of `ipywidgets` or `vscode`. I'm not sure if this is the best way to do this, but I think it's a", "reference": "Should the docstring mention the vscode option?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. It's a bit of a hack, but I think it's the best way to do this.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to add a `packageType` field to the `PackageMetadata` class. This will allow us to easily determine if a package is a gRPC package or a proto package, for example.", "reference": "ISTM that since `artman` know the \"real\" value of the GAPIC config name, it should pass that value to toolkit, rather than toolkit guessing the name based on a heuristic. Then again, I don't know what this value actually does for Java codegen..." }, { @@ -19151,35 +19151,35 @@ "reference": "Please back out the import changes in files you haven't touched. I think these happen if you run goimports without having the vendor directory populated" }, { - "prediction": "I'm not sure what you mean by `Action write, T state`. I think you meant `Action write, T state` or `Action write, T state`.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to have `WriteAsync` and `FlushAsync` in the same class.", "reference": "Should this be `ISocketOutput where T : struct`?" }, { - "prediction": "I'm not sure what you mean by \"return this snapshot's sequence number, or 0 if the table has no snapshot yet.\" I think you meant to say \"return this Snapshot's sequence number, or 0 if the table has no snapshot yet.\"", + "prediction": "I'm not sure if this is the best place to put this, but I think we should move it to the `Snapshot` interface, since it's not really part of the `Snapshot` class itself.", "reference": "In which case will this actually return 0? If there is no snapshot, then there is no `Snapshot` object, right?" }, { - "prediction": "I'm not sure what you mean by `CLASSES` being a tuple of str.", + "prediction": "I don't think we need to add a comma here.", "reference": "This part of code is valuable and necessary. Can we move it to another place for a more clear logic and only check it once? For example, move it to line 133 before delving into each module." }, { - "prediction": "I'm not sure what you mean by `psycopg2-binary<2.9`", + "prediction": "I think we should remove `psycopg2-binary<2.9` and `psycopg2-binary>=2.9`", "reference": "Are we at all worried that changing pins will cause release hiccups? I think we've decided that relaxing pins should be safe but adding pins has caused us build issues in the past - so I think we're fine?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think we need to change this.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to `swarm/entry.go` instead of `swarm/section.go`.", "reference": "could you please explain a bit where these numbers come from? for example: why is there no `swarm.EncryptedSectionSize`?" }, { - "prediction": "I don't think we need to close the reader here.", + "prediction": "I'm not sure if this is the right place to do this. I think we should move this to the `Blob` struct.", "reference": "s/object content/blob object/ (for consistency with the `Size` docs)" }, { - "prediction": "I think this is a bit of a red herring here. We don't need to check for `compileClasspath` in this case, since we're not using it anyway.", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to exclude the JUnit4 dependency from compilation, but you're also trying to exclude the Spock dependency from compilation. Is that correct? If so, how do you want to handle this?", "reference": "Rather than deleting this entirely, could we just emit it as a `warn` or `info` log line?" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new ACME client that will be used to obtain a single certificate for a specific domain name. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new ACME client that will be used to obtain a single certificate for a specific domain name. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new ACME client that will be used to obtain a single certificate for a specific domain name. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new ACME client that will be used to obtain a single certificate for a specific domain name. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new ACME client that will be used to obtain a single certificate for a specific domain name. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new ACME client that will be used to obtain a single certificate for a specific domain name. I'm not sure", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to get the CA from the config, and then use that CA to obtain the certificate. I think you should be able to use the CA to obtain the certificate, and then use the CA to obtain the certificate. I'm not sure what you're trying to do here. I think you're trying to get the CA from the config, and then use that CA to obtain the certificate. I think you should be able to use the CA to obtain the certificate, and then use the CA to obtain the certificate. I'm not sure what you're trying to do here. I think you're trying to get the CA from the config, and then use that CA to obtain the certificate. I think you should be able to use the CA to obtain the certificate, and then use the CA to obtain the certificate. I'm not sure what you're trying to do here. I think you're trying to get the CA from the config, and then use that CA to obtain the certificate. I think you should be able to use the CA to obtain the certificate, and then use the CA to obtain the certificate. I'm not sure what you're trying to do here. I think you're", "reference": "Is there a chance of this being a BC break of somekind? I.e. what if an old instance of Caddy is running in a cluster with a newer one?" }, { @@ -19187,23 +19187,23 @@ "reference": "Thanks for this... is this the only place where the rollback is needed? Are there others?" }, { - "prediction": "I'm not sure what you mean by \"zero fields\" in this case. I think you meant to say that the `BlockSig` field is `crypto.SigTypeSecp256k1` and the `BLSAggregateSig` field is `crypto.SigTypeBLS`.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate test for the `BlockSig` field.", "reference": "Should this also be a pointer? What happens if there are no BLS messages? I guess that's what this test is exercising, and Lotus also uses a non-pointer here." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function to do this, so that we don't have to do this in the `actionToWrites` function.", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to get rid of the `if pc == nil {` check, but I'm not sure what you're trying to do with the `if perr != nil {` check. Could you please explain what you're trying to achieve with these two checks?", "reference": "This was definitely a subtle bug right here." }, { - "prediction": "I'm not sure what you're trying to do with this method, but I think it's a bad idea to call `fetch_email_responses` directly from the `GithubApi` class. It's better to call `fetch_email_responses` in the `GithubApi` class and pass it to the `secondary_emails` method.", + "prediction": "I'm not sure what you mean by `fetch_email_responses` and `secondary_emails`. Could you please provide more context?", "reference": "If this method gets all the emails, it should be named appropriately. **all_emails** or just **emails**." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `testutil.RandomPort()` function to generate a random port for the bootnode.", + "prediction": "I'm not sure I understand what you're trying to do here. Is it that you want to create a new bootnode with a specific port? Or is it that you want to create a new bootnode with a random port? I'm not sure what you're trying to do here. Is it that you want to create a new bootnode with a specific port? Or is it that you want to create a new bootnode with a random port? I'm not sure what you're trying to do here. Is it that you want to create a new bootnode with a specific port? Or is it that you want to create a new bootnode with a random port? I'm not sure what you're trying to do here. Is it that you want to create a new bootnode with a specific port? Or is it that you want to create a new bootnode with a random port? I'm not sure what you're trying to do here. Is it that you want to create a new bootnode with a specific port? Or is it that you want to create a new bootnode with a random port? I'm not sure what you're trying to do here. Is it that you want to create a new bootnode with a specific port? Or", "reference": "Can we still random, but if we randomly get a port is used before, we randomly pick again?" }, { - "prediction": "I'm not sure I understand what you're trying to do here, but I think we should remove the `create_no_window=False` argument.", + "prediction": "I'm not sure what you mean by `create_no_window=False`", "reference": "I would rather no have this as a `kwarg` as it encourages \"growth\" which lead to an unweildy constructor in other classes. Let's add a method or property to take care of this instead as I think it's usage is going to be quite low." }, { @@ -19211,11 +19211,11 @@ "reference": "what if a purchaser is also an approver? or would that not happen?" }, { - "prediction": "I'm not sure what you mean by \"total - fee < dust_threshold(network)\". I think you meant to say \"total - fee < dust_threshold(network) * 100000000\".", + "prediction": "I'm not sure what you mean by \"total - fee < dust_threshold(network)\". I think it's the same as \"total - fee < 1000000000000000000\"", "reference": "Not sure why this change. You forgot to handle the case where the user has dynamic fees disabled and there are no fee estimates available. He should be able to sweep none-the-less (as he is using static fees anyway). The line with `config.fee_per_kb()` below, that you have deleted, handled that." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to use the `GetTopLevelCondition` method to get the top level condition.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `AuditLogsSourceStatus` struct, since it's used by the `AuditLogsSource` struct as well.", "reference": "sorry, I wasn't familiar with this TopLevelCondition... What it would be in this case? The AuditsLogReady condition?" }, { @@ -19223,11 +19223,11 @@ "reference": "Where does the `alloc` field get set?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to do something like this: `runQueryPostgres(db, &queryOpts{table: \"users\", selectAs: \"email\", count: 1})`", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this", "reference": "looks expensive to do it on each query" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is this for a specific use case? If so, please provide more details.", + "prediction": "I think we should use `nupic.datafiles` instead of `nupic.datafiles/extra/nyctaxi/nyc_taxi.csv`", "reference": "@rhyolight -- but weren't we supposed to be standardizing on using underscores in file names (versus camelcase)?" }, { @@ -19239,11 +19239,11 @@ "reference": "The styling/wording here probably needs some thought. It's more of a placeholder." }, { - "prediction": "I don't think this is necessary. The `password_resets` resource should be the same as the `password_resets` resource in the `password_reset` resource. The `password_resets` resource should be the same as the `password_resets` resource in the `password_reset` resource. The `password_resets` resource should be the same as the `password_resets` resource in the `password_reset` resource. The `password_resets` resource should be the same as the `password_resets` resource in the `password_reset` resource. The `password_resets` resource should be the same as the `password_resets` resource in the `password_reset` resource. The `password_resets` resource should be the same as the `password_resets` resource in the `password_reset` resource. The `password_resets` resource should be the same as the `password_resets` resource in the `password_reset` resource. The `password_resets` resource should be the same as the `password_resets` resource in the `password_reset` resource. The `password_resets` resource should be the same as the `password_resets` resource in the `password_reset` resource. The `password_resets", + "prediction": "I don't think this is necessary. The `password_resets` route is already defined in the `password_resets_controller.rb` file, so we don't need to create a new one.", "reference": "Using a plural route helps in detecting the path automatically for `= form_for @password_reset`." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `utils` package.", + "prediction": "`inspect` is not a function, it's a method. `inspect` is a method of the `util` module. `inspect` is not a function, it's a method of the `util` module. `inspect` is not a function, it's a method of the `util` module. `inspect` is not a function, it's a method of the `util` module. `inspect` is not a function, it's a method of the `util` module. `inspect` is not a function, it's a method of the `util` module. `inspect` is not a function, it's a method of the `util` module. `inspect` is not a function, it's a method of the `util` module. `inspect` is not a function, it's a method of the `util` module. `inspect` is not a function, it's a method of the `util` module. `inspect` is not a function, it's a method of the `util` module. `inspect` is not a function, it's a method of the `util` module. `inspect` is not a function, it's a method of the `util` module. `inspect", "reference": "Is `metadata` required on all tests? I actually just removed the metadata field entirely from a few tests in my PR." }, { @@ -19251,31 +19251,31 @@ "reference": "seems reasonable to also want to include the 'to' location?" }, { - "prediction": "I think this should be `Runtime.getRuntime().removeShutdownHook(shutdownHook);` instead of `Runtime.getRuntime().removeShutdownHook(shutdownHook); Runtime.getRuntime().removeShutdownHook(shutdownHook); Runtime.getRuntime().removeShutdownHook(shutdownHook); Runtime.getRuntime().removeShutdownHook(shutdownHook); Runtime.getRuntime().removeShutdownHook(shutdownHook); Runtime.getRuntime().removeShutdownHook(shutdownHook); Runtime.getRuntime().removeShutdownHook(shutdownHook); Runtime.getRuntime().removeShutdownHook(shutdownHook); Runtime.getRuntime().removeShutdownHook(shutdownHook); Runtime.getRuntime().removeShutdownHook(shutdownHook); Runtime.getRuntime().removeShutdownHook(shutdownHook); Runtime.getRuntime().removeShutdownHook(shutdownHook); Runtime.getRuntime().removeShutdownHook(shutdownHook); Runtime.getRuntime().removeShutdownHook(shutdownHook); Runtime.getRuntime().removeShutdownHook(shutdownHook); Runtime.getRuntime().removeShutdownHook(shutdownHook); Runtime.getRuntime().removeShutdownHook(shutdownHook); Runtime.getRuntime().removeShutdownHook(shutdownHook); Runtime.getRuntime().removeShutdownHook(shutdownHook); Runtime.getRuntime().removeShutdownHook(shutdownHook); Runtime.getRuntime().removeShutdownHook(shutdownHook); Runtime.getRuntime().removeShutdownHook(shutdownHook); Runtime.getRuntime().removeShutdownHook(shutdownHook); Runtime.getRuntime().removeShutdownHook", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a `shutdownHook` in the `TemporaryFilesystem` class, so that we don't have to call `Runtime.getRuntime().removeShutdownHook(shutdownHook);` every time we want to delete the base directory.", "reference": "I don't think we need to necessarily check if that returned true or not, we should just remove the shutdown hook. Since nothing would check or do anything with this flag anyways." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it should be done in the `createVolumeOperation` function. It's not clear to me why we need to do this in the `updateCVCObj` function.", + "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. I think it's a good place to put it. I think it's a good place to put it. I think it's a good place to put it. I think it's a good place to put it. I think it's a good place to put it. I think it's a good place to put it. I think it's a good place to put it. I think it's a good place to put it. I think it's a good place to put it. I think it's a good place to put it. I think it's a good place to put it. I think it's a good place to put it. I think it's a good place to put it. I think it's a good place to put it. I think it's a good place to put it. I think it's a good place to put it. I think it's a good place to put it. I think it's a good place to put it. I think it's a good place to put it. I think it's a good place to put it. I think it's a good place to put it", "reference": "Better to push getting policy details into a func we can reuse later." }, { - "prediction": "I'm not sure what you mean by \"nothing to do\" in this case.", + "prediction": "I don't think we need to do anything here. The `Call` function is just a wrapper around the `Start` and `Stop` functions, so we don't need to do anything here.", "reference": "optional: while there's nothing to do, a good way to catch bugs (where we use an outbound without calling `Start`) might be to have this outbound verify that `Start` is called before `Call` or `Stop`" }, { - "prediction": "I'm not sure if this is the right place to put it, but I think we should move it to the `cluster` package.", + "prediction": "I'm not sure if this is a good place to put it, but I think we should move it to the `cluster` package.", "reference": "Not a blocker by any means, but I think there is value in keeping the local imports in a separate group." }, { - "prediction": "I think this is a bug, not a feature.", + "prediction": "I'm not sure why this test is failing, but I think it should be fixed.", "reference": "nit - I would test the error message as well. For panic, you might need to see if the stack contains the error message, instead of equaling." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a new slice of `WaitForInstancesStopped` or `WaitForInstancesSignal` based on the values in the `raw` slice. Is this what you're trying to do? If so, I'm not sure what you're trying to do here, but it looks like you're trying to create a new slice of `WaitForInstancesStopped` or `WaitForInstancesSignal` based on the values in the `raw` slice. Is this what you're trying to do? If so, I'm not sure what you're trying to do here, but it looks like you're trying to create a new slice of `WaitForInstancesStopped` or `WaitForInstancesSignal` based on the values in the `raw` slice. Is this what you're trying to do? If so, I'm not sure what you're trying to do here, but it looks like you're trying to create a new slice of `WaitForInstancesStopped` or `WaitForInstancesSignal` based on the values in the `raw` slice. Is this what you're trying to do? If so, I'm not sure what you're trying to do here,", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a new slice of `WaitForInstancesStopped` or `WaitForInstancesSignal` based on the values in the `raw` slice. I'm not sure what you're trying to do here, but it looks like you're trying to create a new slice of `WaitForInstancesStopped` or `WaitForInstancesSignal` based on the values in the `raw` slice. I'm not sure what you're trying to do here, but it looks like you're trying to create a new slice of `WaitForInstancesStopped` or `WaitForInstancesSignal` based on the values in the `raw` slice. I'm not sure what you're trying to do here, but it looks like you're trying to create a new slice of `WaitForInstancesStopped` or `WaitForInstancesSignal` based on the values in the `raw` slice. I'm not sure what you're trying to do here, but it looks like you're trying to create a new slice of `WaitForInstancesStopped` or `WaitForInstancesSignal` based on the values in the `raw` slice. I'm not sure what you're trying to do here", "reference": "Didn't we have specific logic for handling slices vs structs?" }, { - "prediction": "I'm not sure what you mean by \"auto inject saylinks\". I think you meant to say \"auto inject say\" or \"auto inject saylinks\".", + "prediction": "I'm not sure if this is the right place to do this.", "reference": "`c_str()` is not needed." }, { @@ -19283,27 +19283,27 @@ "reference": "The handler will be installed twice if you don't remove the below one." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `getEpochLengthActivationBlock()` method to the `EthashConfigOptions` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a `getEpochLengthActivationBlock` method to the `EthashConfigOptions` class as well. This would allow us to set the `epochlengthactivation` in the `EthashConfigOptions` class, and then use that value in the `getEpochLengthActivationBlock` method of the `EthashConfigOptions` class.", "reference": "How about putting `epochLength` (or something like that) in place of `a` just to make it easier to read" }, { - "prediction": "I think we should remove the `log.Warning` here, since it's just a small usability message to help with the migration from v15 to v16. We should probably remove this after a grace period.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `build.go` file as well.", "reference": "Wouldn't this still fire afterwards if you created one called `pleasings`? or am I missing something?" }, { - "prediction": "I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a `kbp_record` field in the `Root` struct. This would allow us to store the `kbp_record` in the `Root` struct, and then we could use that to look up the `kbp_record` in the `Root` struct.", "reference": "I don't love this syntax; it doesn't match anything we're currently doing and it's not obvious. Why isn't this `/keybase/private/jzila,kb_bot/.kbfs_autogit/public/jzila/kbp.git`?" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a new `Queue` from an existing `Queue`, but you're not using the `Tuple2` or `Tuple` types. Is this what you're trying to do? If so, what's the purpose of the `Tuple2` and `Tuple` types?", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `@Override` to the `zipWith` method, so that we don't have to do this in the `zip` method.", "reference": "Does a type-hint work instead of casting? `return ofAll(toList(). zipWith(that, mapper));` (Probably not, just a question.)" }, { - "prediction": "I think we can remove the `currentSnapshotId` and `previousSnapshotId` from the `snapshotLog` list.", + "prediction": "I'm not sure if this is the right place to put this, but I think it would make sense to move it to the `TestTableMetadata` class.", "reference": "Are these required?" }, { - "prediction": "I think this is a good idea, but I'm not sure if we want to change it on reload. If we do, we'll need to change `c.mcl` to `MAX_CONTROL_LINE_SIZE` as well.", + "prediction": "I think we should set this to 0 if we don't want to change it on reload.", "reference": "This is consistent for all clients that we will check yes? Seems like we should just use the singleton, maybe pass it to the parse function or since clients have a server pointer set it at server start and just access that way without locks?" }, { @@ -19311,19 +19311,19 @@ "reference": "Note that this is a bug, that should be fixed on master. `DECIMAL_LITERAL` cannot match any token, because it's declared with a `#`." }, { - "prediction": "I think we can remove the `sync/atomic` import here, since it's not used anywhere else in this file.", + "prediction": "I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `nuid` package to generate a unique ID for each connection to the Nats server. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `nuid` package to generate a unique ID for each connection to the Nats server. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `nuid` package to generate a unique ID for each connection to the Nats server. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `nuid` package to generate a unique ID for each connection to the Nats server. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `nuid` package to generate a unique ID for each connection to the Nats server. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `nuid` package to generate a unique ID for each connection to the Nats", "reference": "Don't need extra line here." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to modify the `ReleaseSpec` in this way.", + "prediction": "I'm not sure what you mean by \"change in test after the modification to how the ReleaseSpec is delivered to the virtual machine\"", "reference": "For the first look, this change is strange. Were we passing these tests before?" }, { - "prediction": "I think we can remove the `if err != nil` check here.", + "prediction": "I think we can remove the `matchProcess` function and just use `strings.Contains` to check if the process name is the same as the app name.", "reference": "On Windows, doesn't `os.Args[0]` include the `.exe`? What if you run the program like `caddy.exe`?" }, { - "prediction": "I think we can remove the `ConsumeConfig` and `ProvideConfig` functions.", + "prediction": "I think we can remove the `ConsumeConfig` and `ProvideConfig` methods.", "reference": "I don't see anywhere where `ServiceConfiguration` interface implementation would return any kind of error. Not sure if its needed, but we could ALWAYS return a valid 'pseudo' configuration without possibility of error." }, { @@ -19331,11 +19331,11 @@ "reference": "Do we actually want to split on `\\r`? I thought that the \"newline sequence\" was only `\\r\\n` on windows." }, { - "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to write a type spec for a list or a set, but you're not using the `write_type_spec_object` function. Is this what you're trying to do?", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to write the type spec for a list or a set, but you're not using the `write_type_spec_object` function. Is this what you're trying to do?", "reference": "Nit: these lines are duplicated from above. They can be refactored by setting etype in a conditional and putting 282 and 283 below that." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `os.Exit(0)` in this case.", "reference": "I would do an s.Notice(\"Initiating Shutdown...\") then after Shutdown() do the original Server Exiting." }, { @@ -19343,23 +19343,23 @@ "reference": "Not sure with how many seconds on average are we dealing with but maybe it's better to have hh:mm:ss format in logs - you can make it with `TimeSpan.FromSeconds(seconds).ToString()`" }, { - "prediction": "I'm not sure if this is the right place to add this check, but I think it's a good idea to add this check to the `validateUpdate` function as well.", + "prediction": "I think this should be `if newObject.Spec.Platform.Azure != nil { ... }` instead of `if mp.Platform.AWS == nil { ... }`", "reference": "Why is this required? The user should be able to omit it and use the defaults." }, { - "prediction": "I think this should be `self.shapeCheckBox.SetValue(config.conf[\"mouse\"][\"reportMouseShapeChanges\"])` instead of `config.conf[\"mouse\"][\"reportMouseShapeChanges\"] = self.shapeCheckBox.IsChecked()`", + "prediction": "I think this should be `self.shapeCheckBox.SetValue(config.conf[\"mouse\"][\"reportMouseShapeChanges\"])` and `self.mouseTrackingCheckBox.SetValue(config.conf[\"mouse\"][\"enableMouseTracking\"])`", "reference": "I don't think the naming of this setting conveys what it does. Maybe something like \"Ignore mouse movement triggered by other applications\"" }, { - "prediction": "I think this should be `this.FailedToReachCollector(string, Exception ex)` instead of `this.FailedToReachCollector(Uri, Exception ex)`.", + "prediction": "I think this should be `this.FailedToReachCollector` instead of `this.FailedToReachCollector(ex.ToInvariantString());`", "reference": "Didn't went with backwards compatibility since it's still in beta" }, { - "prediction": "I'm not sure what you mean by \"minCuts\" and \"maxCuts\"", + "prediction": "I'm not sure what you mean by \"invalid value for bondsToCut\"", "reference": "Perhaps bondsToCut must be None or non empty." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to use the `line` chart type, but you're passing in a `data` object instead of a `chartOptions` object. I'm not sure what you're trying to do here, but it looks like you're trying to use the `line` chart type, but you're passing in a `data` object instead of a `chartOptions` object. I'm not sure what you're trying to do here, but it looks like you're trying to use the `line` chart type, but you're passing in a `data` object instead of a `chartOptions` object. I'm not sure what you're trying to do here, but it looks like you're trying to use the `line` chart type, but you're passing in a `data` object instead of a `chartOptions` object. I'm not sure what you're trying to do here, but it looks like you're trying to use the `line` chart type, but you're passing in a `data` object instead of a `chartOptions` object. I'm not sure what you're trying to do here, but it looks like you're trying to use", "reference": "See above, we could avoid adding that (same applies below)." }, { @@ -19367,43 +19367,43 @@ "reference": "should use Number instead of Long" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", "reference": "Should the rest of the file be updated to use `expect` or should this test use the same format as the rest of the tests?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to update the DNS zone status now that we have the zoneID. This way we don't have to wait for the zoneID to be set before we can update the status.", + "prediction": "I think we should be able to do this in a single call to `a.ModifyStatus()`, but I'm not sure how to do it.", "reference": "How would you feel about a different approach where the `DeleteAWSRecordSets` gets passed the zone ID and zone name rather than the `DNSZone`?" }, { - "prediction": "I'm not sure what you mean by `random.randint(2)`. I think you meant `random.uniform(0, 1) > 0.5`", + "prediction": "I don't think this is a good idea.", "reference": "it seems `random.uniform(0, 1)` similar to `random.randint(2)`, all have 1/2 probabilities." }, { - "prediction": "I think we can remove the `if isinstance(items[i-1], dict)` check.", + "prediction": "I think we can remove the `if isinstance(v, dict)` check here.", "reference": "Added to support EBS volume creation, used like this: blockDeviceMap = [] blockDeviceMap.append( {'DeviceName':'/dev/sdc', 'VirtualName' : 'ephemeral0'}) blockDeviceMap.append( {'DeviceName':'/dev/sdh', 'Ebs': {'VolumeSize' : '100'} })" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bit of a red herring. The `signer` variable is just a pointer to the `mockedSigner` struct, and it's not used anywhere else in the code. If you want to test the `Sign` method, you should use the `signer.Sign` method directly.", + "prediction": "I think we can remove the testMysteriumApiUrl here, since it's not used anywhere.", "reference": "We shouldn't depend that url is `mysterium` - it can be just `testRequestURL`. Also, `URL` has to be upper-case." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `vkGetPhysicalDeviceImageFormatProperties2` as well.", + "prediction": "I think this should be `PreCallValidateGetPhysicalDeviceImageFormatProperties2` instead of `PreCallValidateGetPhysicalDeviceImageFormatProperties2(instance_data->report_data, pImageFormatInfo, pImageFormatProperties);`", "reference": "We could delay this look-up now and only do it in the non-skip case. I suspect this is true for (almost) all of the top-level refactored functions." }, { - "prediction": "I think we can remove the `std::string` from `schemaTagsPrefix` since it's not used anywhere.", + "prediction": "I think it's better to use `std::string_view` instead of `std::string` here.", "reference": "Typically, to be simple, we could reserve a const length space." }, { - "prediction": "I think this should be `from .builder import Builder` instead of `from .reader import *`", + "prediction": "I don't think this is needed anymore.", "reference": "Need to add a license and copyright header to each file." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to add a hidden field for the coupon ID. I'm not sure what you're trying to do here, but it looks like you're trying to add a hidden field for the coupon ID. I'm not sure what you're trying to do here, but it looks like you're trying to add a hidden field for the coupon ID. I'm not sure what you're trying to do here, but it looks like you're trying to add a hidden field for the coupon ID. I'm not sure what you're trying to do here, but it looks like you're trying to add a hidden field for the coupon ID. I'm not sure what you're trying to do here, but it looks like you're trying to add a hidden field for the coupon ID. I'm not sure what you're trying to do here, but it looks like you're trying to add a hidden field for the coupon ID. I'm not sure what you're trying to do here, but it looks like you're trying to add a hidden field for the coupon ID. I'm not sure what you're trying to do here, but it looks like you're trying to add a hidden field", + "prediction": "I'm not sure what you mean by \"signing out\" here. I think you meant to say \"signing in\" or \"signing out\".", "reference": "If I'm not mistaken, this line is now outside of the `if signed_out?` block, right? Any concerns about that? Seems odd that we wouldn't accept coupons for signed in users, but I want to make sure we understand the ramifications of this change." }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to make the `getDataSource()` method `@NotNull` and `@Override`.", + "prediction": "I think this should be `@Nullable` instead of `@NotNull`.", "reference": "Please remove the unused import of DBPDataSource." }, { @@ -19411,19 +19411,19 @@ "reference": "I think you should add some extra message here saying it was originally sent as an error, for diagnosability." }, { - "prediction": "I think it's better to use `std::numeric_limits::max()` instead of `std::numeric_limits::max() - 1`.", + "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. If you want to compare the number of bits in a vector, you should compare the number of elements in the vector, not the number of bits in the vector. Also, I don't think this is a good idea. It's not clear to me what you're trying to do here. If you want to compare the number of bits in a vector, you should compare the number of elements in the vector, not the number of bits in the vector. Also, I don't think this is a good idea. It's not clear to me what you're trying to do here. If you want to compare the number of bits in a vector, you should compare the number of elements in the vector, not the number of bits in the vector. Also, I don't think this is a good idea. It's not clear to me what you're trying to do here. If you want to compare the number of bits in a vector, you should compare the number of elements in the vector, not the number of bits in the vector. Also, I don't think this is a good idea. It's not clear to me what you're trying", "reference": "I believe that all the changes in this file are not valid for v1.2 of the Avalon toolkit." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `updateRole` method of the `Role` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `mergeOriginalRoleAndMetaRoleAttributes` method.", "reference": "we cannot change the behavior of the processRole - that method is used in lots of places. this call must be done only in the method where templates are being handled." }, { - "prediction": "I'm not sure if this is the best place to put it, but I think it's a good idea to have it in the same place as `hostExecDepsDir` and `ecsAgentExecDepsDir`.", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be a good idea to have a separate file for the container log config file, so that we don't have to worry about it being in the wrong place. I'm not sure if this is a good place to put this, but I think it would be a good idea to have a separate file for the container log config file, so that we don't have to worry about it being in the wrong place. I'm not sure if this is a good place to put this, but I think it would be a good idea to have a separate file for the container log config file, so that we don't have to worry about it being in the wrong place. I'm not sure if this is a good place to put this, but I think it would be a good idea to have a separate file for the container log config file, so that we don't have to worry about it being in the wrong place. I'm not sure if this is a good place to put this, but I think it would be a good idea to have a separate file for the container log config file, so that we don't have to worry about it being in the wrong place. I", "reference": "I think we probably want to follow the same naming convention that we do with `execAgentConfigFileNameTemplate` (using the SHA in the name of the file). This file might be confgurable in the future and when that happens we will be ready. Plus it's pretty much the same code that we already use for the config file." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `send_resource_update` function, since it's the only place where the `total_resources->time_left` is set.", + "prediction": "I think this should be `if(manual_wall_time_option != 0)` instead of `if(manual_wall_time_option != 0 && time(0) == 0)`", "reference": "If following above, this would be: end_time = time(0) + manual_wall_time_option, which is simpler. Also, make the check manual_wall_time_option > 0, otherwise negative times would terminate the worker right away." }, { @@ -19431,11 +19431,11 @@ "reference": "If we aren't using `errors.Is` we don't need the `Unwrap` as we have `Cause` which is what pkg/errors uses." }, { - "prediction": "`log` is not used anywhere in this file, so we can safely remove it.", + "prediction": "`log` should be `klog` instead of `klog`", "reference": "redundant empty line" }, { - "prediction": "I'm not sure if this is a good place to put it, but I think it's a good place to put it.", + "prediction": "I'm not sure if this is a good place to put it, but I think it would be better to put it in the config file.", "reference": "The config.lua.dist still shows `houseAccountOwner`" }, { @@ -19443,43 +19443,43 @@ "reference": "I think we can leave this import and use non FQNs in the code." }, { - "prediction": "I think this should be `setParameter('name', nameOrHandle)` instead of `setParameter(paramName, nameOrHandle)`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would make sense to move it to the `execute` method of the `WebDriver` class.", "reference": "I'd rather just send the parameter twice than break encapsulation here. There's already precedence with webelement IDs" }, { - "prediction": "I think this should be `await PushAsync(items, allowOverwrite);` instead of `await PushAsync(items.ToList(), allowOverwrite);`", + "prediction": "I think this should be `await PushAsync(items.ToList(), allowOverwrite);`", "reference": "We should probably exit early if there are no items in the list." }, { - "prediction": "I'm not sure what you mean by \"missing-param-doc\" and \"missing-type-doc\"", + "prediction": "I don't think this is a good idea. It's not clear what the docstring is supposed to say. It's not clear what the docstring is supposed to say. It's not clear what the docstring is supposed to say. It's not clear what the docstring is supposed to say. It's not clear what the docstring is supposed to say. It's not clear what the docstring is supposed to say. It's not clear what the docstring is supposed to say. It's not clear what the docstring is supposed to say. It's not clear what the docstring is supposed to say. It's not clear what the docstring is supposed to say. It's not clear what the docstring is supposed to say. It's not clear what the docstring is supposed to say. It's not clear what the docstring is supposed to say. It's not clear what the docstring is supposed to say. It's not clear what the docstring is supposed to say. It's not clear what the docstring is supposed to say. It's not clear what the docstring is supposed to say. It's not clear what the docstring is supposed to say. It's not clear what the docstring is supposed to say", "reference": "As we can't use old names we should warn in whats new for 2.12 that this can happen." }, { - "prediction": "I'm not sure what you mean by \"testbincover\" in this context. It's not clear to me what you're trying to do with this test.", + "prediction": "I'm not sure if this is the right place to run tests, but I think it's a good idea to run the tests in the `bincover` package.", "reference": "good job finding this package, I hope it's actively maintained" }, { - "prediction": "I don't think we need to unset the environment variables. We can just use `getenv` to get the value of `CUDA_VISIBLE_DEVICES` and `HIP_VISIBLE_DEVICES`.", + "prediction": "I don't think we need to unset the environment variables here. We can just use `getenv` to get the value of `CUDA_VISIBLE_DEVICES` and `HIP_VISIBLE_DEVICES` from the command line.", "reference": "same changes as in hipEnvVar.cpp" }, { - "prediction": "I think this should be `#include ` instead of `#include `.", + "prediction": "I don't think we need to include `libinput.h` in this file.", "reference": "NULL check should be before this line" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to check if the player is in a pvp world first, and if so, set the world point to the player's world location. This way, if the player is not in a pvp world, the location will be set to the player's world location, and if the player is in a pvp world, the location will be set to the player's pvp world location. This way, if the player is not in a pvp world, the location will be set to the player's world location, and if the player is in a pvp world, the location will be set to the player's pvp world location. This way, if the player is not in a pvp world, the location will be set to the player's world location, and if the player is in a pvp world, the location will be set to the player's pvp world location. This way, if the player is not in a pvp world, the location will be set to the player's world location, and if the player is in a pvp world, the location will be set to the player's pvp world location. This way", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to check if the player is in a pvp world first. If they are, then we should set the world point to be the player's world location. If they are not, then we should set the world point to be the player's world location.", "reference": "Seems like client.getlocalplayer is being called a lot, would it be worth it to do final Player player = client.getlocalplayer?" }, { - "prediction": "I think this should be `if (getOperand(i)->getNullFlag())` instead of `if (getOperand(i)->getNullFlag() && (!op_data[i]))`", + "prediction": "I think we should move the null value to the end of the operand list, not the first one.", "reference": "this change is not correct. 3-valued boolean logic requires that comparison of null to another value during intermediate operations should make the result null and not false. The place where null becomes false is at the very end of that expression. As an example, with the changed logic, this expression will return incorrect result. select * from t where not (a = 1); if a is null, the where predicate will become true which is incorrect. With the original 3-valued result, the where pred will become false and not return any result." }, { - "prediction": "I'm not sure what you mean by \"emptyValue\" in this context. It's not clear to me what you're trying to do with it.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a default value for the `Detected-Locale` header, so that we don't have to check for it every time we get a response.", "reference": "This can already be done with `{>Detected-Locale}`, why make another way to do it?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check to see if the selected files are restricted.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.", "reference": "These changes just match the logic update in the next method that was done previously - to assure the whole set of files is valid rather than that there is at least one that would be changed." }, { @@ -19487,15 +19487,15 @@ "reference": "Why setting the status to Continue as at the end it is written OK? Status should be written only once." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `main.go` as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `main.go` as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `main.go` as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `main.go` as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `main.go` as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `main.go` as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `main.go` as well. I'm not sure if this is the right place to do this, but I think it", + "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to run the `paramcache` command before running the `proofs/bin/paramcache` command. This way, the `paramcache` command will be executed before the `proofs/bin/paramcache` command, and the `paramcache` command will be executed before the `proofs/bin/paramcache` command. This way, the `paramcache` command will be executed before the `proofs/bin/paramcache` command, and the `paramcache` command will be executed before the `proofs/bin/paramcache` command. This way, the `paramcache` command will be executed before the `proofs/bin/paramcache` command, and the `paramcache` command will be executed before the `proofs/bin/paramcache` command. This way, the `paramcache` command will be executed before the `proofs/bin/paramcache` command, and the `paramcache` command will be executed before the `proofs/bin/paramcache` command. This way, the `paramcache` command will be executed before the `proofs/bin/paramcache` command, and the `paramcache`", "reference": "Howdy! You'll want to do this same thing (replace `hydrateParamCache` with `proofs/bin/paramcache` and then do the copy) in `smartdeps`, too." }, { - "prediction": "I don't think we need to add a `--volname` to the help text, since it's the same as the `--snapname` in the help text.", + "prediction": "I don't think we need to add a `helpText` field to the `CmdSnaphotCreateOptions` struct. We can just use the `helpText` field of the `CmdCreateOptions` struct.", "reference": "nit : Remove the extra lines" }, { - "prediction": "I don't think this is necessary. We can just use the default values.", + "prediction": "I don't think this is necessary.", "reference": "Instead of adding a new option, I wonder if we could decide on a port that would disable listening. For instance, port set to 0 means that we use default port 4222. Setting to -1 means that we let OS pick a random free port. We could say anything negative lower than -1 (say -2) means disabled? You don't have to update the PR for that, just wondering if that would be better or not and let's see what others think." }, { @@ -19503,27 +19503,27 @@ "reference": "Should we add some default case if non of the above return some analyzer name? Something like `unknown analyzer`?" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you're trying to do here. I don't think you want to change `min_alpha` to `min_length`. I think you want to change `min_alpha` to `min_length - 1` and `max_length` to `max_length + 1`.", "reference": "Nvm. The original version is best... *hides from the angry rubocop*" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to marshal the request body into a buffer, but you're not actually marshaling the request body into a buffer.", + "prediction": "I think we can remove the `defer cleanup()` here, since it's not used anywhere.", "reference": "we can drop this and use the returned body above, right?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `dpl_install_command` method.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to `dpl_install_command` so that it can be used by `dpl_install` and `dpl_uninstall` as well.", "reference": "Is echoing enabled on purpose here or it's a remainder of your tests?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to run a command on a list of targets, but you're not passing any options to the `run_command` method. Is this what you're trying to do? If that's the case, I'm not sure I understand what you're trying to do here. I think you're trying to run a command on a list of targets, but you're not passing any options to the `run_command` method. Is this what you're trying to do? If that's the case, I'm not sure I understand what you're trying to do here. I think you're trying to run a command on a list of targets, but you're not passing any options to the `run_command` method. Is this what you're trying to do? If that's the case, I'm not sure I understand what you're trying to do here. I think you're trying to run a command on a list of targets, but you're not passing any options to the `run_command` method. Is this what you're trying to do? If that's the case, I'm not sure I understand what you're trying to do here. I think you're trying to", + "prediction": "I'm not sure I understand what you're trying to do here. What is the purpose of the `@logger.notice` line? What is the purpose of the `@logger.info` line? What is the purpose of the `@logger.info(\"Starting command run '#{command}' on #{targets.map(&:uri)}\")` line? What is the purpose of the `@logger.info(\"Starting command run '#{command}' on #{targets.map(&:uri)}\")` line? What is the purpose of the `@logger.info(\"Starting command run '#{command}' on #{targets.map(&:uri)}\")` line? What is the purpose of the `@logger.info(\"Starting command run '#{command}' on #{targets.map(&:uri)}\")` line? What is the purpose of the `@logger.info(\"Starting command run '#{command}' on #{targets.map(&:uri)}\")` line? What is the purpose of the `@logger.info(\"Starting command run '#{command}' on #{targets.map(&:uri)}\")` line? What is the purpose of the `@logger.info(\"Starting command run '#{command}' on #{targets.map(&:uri)}\")` line? What is the purpose of the `@logger.info(\"Starting command run '#{command}' on #{targets", "reference": "I think this should just be worked into the next message and follow the verbosity of it." }, { - "prediction": "I'm not sure if this is the right place for this, but I think it should be in the `selectors` object.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `selectors` object.", "reference": "This also needs to be reverted." }, { - "prediction": "I don't think we need to use `switch` here, we can just use `if` and `else if` instead.", + "prediction": "I don't think this is needed.", "reference": "`FromCommand` seems to fit better, since with my suggestion below, all pauses will raise a signal on `needPause`. Also maybe the format `journalPauseConflict` and `journalPauseCommand` is better, since the journal isn't necessarily paused yet once we raise a pause signal." }, { @@ -19531,11 +19531,11 @@ "reference": "This is fix from another PR #120." }, { - "prediction": "I think this should be `subtypes = ['array', 'dask']` instead of `subtypes = ['dataframe', 'dictionary', 'array', 'dask']`", + "prediction": "I think it's better to have `subtypes` be a list of strings, and `multi` be a boolean. This way, we don't need to check for `kdims` and `vdims` in `MultiInterface.init()`.", "reference": "I *think* it makes sense to try the more general dictionary (i.e standard python literals) format first. Might be other implications I haven't figured out yet. Then again, ``MultiInterface`` is pretty new so it probably doesn't matter wrt backwards compatibility." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add it to the `Sonata\\MediaBundle\\Command\\FixMediaContextCommand` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `Sonata\\MediaBundle\\Command\\FixMediaContextCommand` class.", "reference": "lol that variable name" }, { @@ -19543,111 +19543,111 @@ "reference": "Upper case is reserved for our versions of top-level chains i.e. the `FORWARD` chain jumps to `cali-FORWARD`." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `receive` function.", + "prediction": "I'm not sure what you mean by \"disable work generation if 'work' option is provided\". I think you meant to say \"disable work generation if 'work' option is not provided\".", "reference": "json_handler::receive () has already started a read tx that can be used here right?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to mock the `global._googlesitekitBaseData` object. This way, we can make sure that the `isWP5.0+` flag is set to `true`.", + "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `fetchMock.postOnce` in this case. I think it's better to use `fetchMock.getOnce` or `fetchMock.getOnceAsync` instead.", "reference": "We should add the definition to `.storybook/config.js` as well." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.", "reference": "I don't believe this is correct. Consider the query, \"select a from t1x where not(b = 0 and c = 0)\". When B and C are both null, both equal predicates evaluate to null, and the AND evaluates to null. The NOT then also evaluates to null. The WHERE clause should treat the result of the NOT as false. But with this fix, the result of the AND will be false, making the NOT true. There needs to be three cases here for ITM_AND: If the first operand is false, then the AND is false. If the first operand is true, then the result is the second operand. If the first operand is null, then if the second operand is false, the result is false otherwise the result is null. Similar logic needs to be added to the ITM_OR case." }, { - "prediction": "I think this should be `offset + bound` instead of `offset + bound / 2`.", + "prediction": "I think this should be `i = Arrays.binarySearch(docs, i + 1, length, target);` instead of `i = Arrays.binarySearch(docs, offset + bound / 2, Math.min(offset + bound, length), target);`", "reference": "`bound/2` is generally the previous bound that we tested, except when `bound` is equal to 1. It won't break in that case since callers are not supposed to call advance on a target that is lte the current doc ID, but this might still make room for bugs?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to pass in a read preference, so we don't have to pass it in every time we call this function.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a `readPreference` option to the `Admin` class.", "reference": "Can we remove `raw`, `fullResult`, and `serializeFunctions`?" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place", "reference": "[Nit] I don't have a proposed suggestion, but security seems too generic of a name here." }, { - "prediction": "I think this should be `util.run('ninja', ['-C', config.outputDir, 'create_dist'], cmdOptions)` instead of `util.run('gn', ['gen', config.outputDir, '--args=\"' + args + '\"'], cmdOptions)`.", + "prediction": "I think it's better to use `config.outputDir` instead of `config.outputDir` in the `createDist` function.", "reference": "do we need to force a buildConfig here? I know it's in muon, but that might actually be making things harder for people" }, { - "prediction": "I'm not sure what you mean by \"too far away\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that if the target is the same as the player, the message is sent to the player.", "reference": "Shouldn't need this-> here." }, { - "prediction": "I think we can remove the `import torch` at the top of the file.", + "prediction": "I don't think this is necessary.", "reference": "Why delete this?" }, { - "prediction": "I'm not sure what you mean by \"as soon as possible\" here. I think you mean \"as soon as possible in the future\" or \"as soon as possible in the current context\".", + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", "reference": "This line is here to be compatible with the current way `refs` work, right?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a default value for `number_to_currency` if `value` is `nil` or `false`.", + "prediction": "I think it's better to use `number_to_currency` instead of `number` in this case.", "reference": "Hmm, I wonder if we can safely assume all decimals should be displayed as $$...ok for now I suppose." }, { - "prediction": "I think this should be a test for `current_examples` instead of `current_example`?", + "prediction": "I think this is a good idea, but I'm not sure how to test it. I think we should test that the current example is set to the example that is currently running, but I'm not sure how to do that.", "reference": "Good spec :). Very clear and easy to see what it's doing." }, { - "prediction": "I think we should move this to a new controller, so that we don't have to call it in every controller.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to move this out of the controller and into the view.", "reference": "Shouldn't we need to sanitize the `params[:filter]` from a defined expected values?" }, { - "prediction": "I'm not sure what you mean by \"up to 51. 1 seconds with exponential backoff.\" Is that the same as \"up to 51. 2 seconds with exponential backoff\"?", + "prediction": "I'm not sure what you mean by \"up to 51.1 seconds with exponential backoff.\" I think you meant \"up to 51 seconds with exponential backoff.\"", "reference": "Should we bite the bullet and poll for the full 5 minutes that AWS recommends? If we do that, we'll probably want to leave some kind of breadcrumb in the event log to let users know why it's taking so long to launch." }, { - "prediction": "I think this should be `@FunctionalInterface` instead of `@FunctionalClass`.", + "prediction": "I don't think this is necessary. We can just remove it.", "reference": "Guava changed `Objects` -> `MoreObjects`" }, { - "prediction": "I'm not sure what you're trying to achieve with this mock, but I think it's a bit misleading. It's not a mock of the `MetadataManager` type, but a mock of the `PersistenceManager` type. If you want to mock the `PersistenceManager` type, you should use the `PersistenceManagerMock` type instead.", + "prediction": "I don't think we need this mock here. We already have a mock of the `PersistenceManager` in `temporal/common/persistence/persistence_test.go`.", "reference": "All these hand generated mocks can be deleted. I think we already moved everything to gomocks." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.", + "prediction": "I'm not sure what you're trying to do here. Is it possible that you're trying to do something like this:\r\n\r\n```javascript\r\nDocument.prototype.equals = function (doc) {\r\n return this.get('_id') === doc.get('_id');\r\n};\r\n```\r\n\r\nAnd then you're trying to do something like this:\r\n\r\n```javascript\r\nif (this.equals(doc)) {\r\n // do something\r\n}\r\n```\r\n\r\nIs that what you're trying to do?", "reference": "what about string/number etc _ids? this will fail." }, { - "prediction": "I'm not sure what you mean by \"unexpected annotations\" in this case. I think you meant to say \"unexpected labels\" in this case.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this.", "reference": "Looks like the test had a bug prior to this." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to set the default protocol client to `joplin` in `process.env.JOPLIN_PROTOCOL_CLIENT` so that we don't have to do this every time we start a new instance of Joplin.", + "prediction": "I'm not sure if this is the best place to do this, but I think it's a good idea to set the default protocol client to `joplin` when the `--debug` flag is used. This way, the user will be able to use `joplin://` to connect to the Joplin server, even if they don't have the `joplin` package installed.", "reference": "Should start with joplin://x-callback-url/. Also maybe create a helper function to check if a url is valid?" }, { - "prediction": "I think it's better to use `created_at` and `updated_at` instead of `created_by` and `updated_by`.", + "prediction": "I don't think this is a good idea. The `created_at` and `updated_at` fields should be `created_at` and `updated_at`, not `created_by` and `updated_by`. Also, the `created_by` and `updated_by` fields should be `created_by_id` and `updated_by_id`, not `created_by_id` and `updated_by_id`.", "reference": "PR works great. Just out of curiosity: why all the id changes?" }, { - "prediction": "I think we can remove the `backoff_base` and `backoff_cap` from the `flb_config` struct. The `backoff_base` and `backoff_cap` are not used in the `flb_config` struct, so we can remove them.", + "prediction": "I think we can remove the `backoff_base` and `backoff_cap` from the `flb_config` struct. The `backoff_base` and `backoff_cap` are not used in the `flb_service_config` struct.", "reference": "config map first value is wrong, it aims to define the \"value type\", that value will lead to an undefined behavior." }, { - "prediction": "I'm not sure what you mean by \"unescaped when they are passed back as blob keys during List\". I think you meant to say \"unescaped when they are passed back as blob keys during Get\".", + "prediction": "I'm not sure what you mean by \"unescaped\" here. I think it's more accurate to say that filenames are unescaped when they are passed back as blob keys during List, and filenames are escaped when they are passed back as blob keys during List.", "reference": "This doesn't make sense. The thing being constructed is a blob.Bucket. \"Constructing\" the pointer is trivial." }, { - "prediction": "I don't think we need to import `PyLinter` here. It's already imported in `pylint.testutils.checker_test_case`.", + "prediction": "I don't think we need to use `functools.partial` here. We can just use `functools.partial(optparse.OptionParser)` instead.", "reference": "Outch. A configuration/parsing refactor is on the radar but this seems more pressing." }, { - "prediction": "I'm not sure what you're trying to do here. You're using `computed` to get the `startDateLabel` from the `membersStats` object, but you're not using it anywhere else in the component. If you want to get the `startDateLabel` from the `membersStats` object, you can just use `membersStats.startDateLabel`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `startDateLabel` computed property that returns the current date minus the number of days in the selected range.", "reference": "Unfortunately this won't work when the \"All time\" range is chosen because `memberStats.days` will be `\"all-time\"` and not a number. What you could do instead is to use `memberStats.stats` as the dependent key and use `Object.keys(memberStats.stats.total_on_date)[0]` to grab the first date in the range and build the label from there." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have the user click on the \"Complete\" button in the video trail, so that the user can see the progress of the video.", "reference": "Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.", "reference": "We need this left in as `axe.configure` is for the top-level page `axe` and we still need to configure the axe script inside the iframe as well (so both have to be configured)," }, { - "prediction": "I'm not sure what you mean by \"get or post type\" but I think it's better to use \"get\" or \"post\" instead of \"get\" and \"post\" in this case.", + "prediction": "I'm not sure what you mean by \"what kind of change implementing this rule can cause.\" I think you mean \"what kind of change can cause this rule to be violated?\"", "reference": "is this rule serviceimpacting? I'm thinking it's mostly around the modeling of pageable in the swagger, thoughts?" }, { @@ -19659,39 +19659,39 @@ "reference": "We should probably ask here if `dict` contains a key with the appropiate value, and leave a trace in case it doesn't, to make it easier to debug for developers." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `:level` as a key in the `:ssh` hash. I think it's better to use `:level` as a key in the `:ssh` hash, and then use `:level` as a value in the `:ssh` hash.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to have `homedir_file` and `subcommand_file` in the same scope.", "reference": "this should only be indented 2 spaces" }, { - "prediction": "I'm not sure what you mean by `awstesting.SprintExpectActual`", + "prediction": "I'm not sure if this is the right way to do this, but I think we should use `reflect.DeepEqual` instead of `sprintExpectActual` here.", "reference": "Nit, these Err not nils should be `t.Fatalf` not error. We want to the test to stop if this error occurs." }, { - "prediction": "I don't think we need to add `downloadOriginalTracker` to the list of `configureToolsByFileId`.", + "prediction": "I don't think this is necessary. We can remove the `downloadOriginalTracker` field.", "reference": "shouldn't every `Boolean` in this pr be `boolean`?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `execute` method of the `WebDriver` class.", "reference": "This `if` is not necessary" }, { - "prediction": "I think we should remove the `GenericParameterTask` and `ObjectTask` as they are not used anywhere.", + "prediction": "I think this should be `System.Action` instead of `System.Threading.Tasks.Action`?", "reference": "Are you using this anywhere? (I couldn't find it.)" }, { - "prediction": "I think we can remove the `endTime` argument from the `recordStepTime` function.", + "prediction": "I think we should move this to the `stepImpl` function.", "reference": "Can be inlined" }, { - "prediction": "I'm not sure what you mean by \"users are not authenticated\". Is it possible that the user is not logged in? If that's the case, the user should be redirected to the login page.", + "prediction": "I'm not sure what you mean by \"users are not authenticated\". I think you meant to say \"users are not logged in\" or \"users are not authenticated\".", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { - "prediction": "I don't think this is necessary.", + "prediction": "I don't think this is needed anymore.", "reference": "Please use `kinto.core.utils.json`" }, { - "prediction": "I think we can remove the `if addr.PortRangeSize() != 1` check.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check here to see if the upstream is already in the cache. If it is, we can just return an error. If it is not, we can create the host and add it to the cache. This way, we don't have to worry about the case where the upstream is already in the cache.", "reference": "Since we're returning the error with the same content, we don't need to log it here; it will get bubbled up and emitted that way." }, { @@ -19699,11 +19699,11 @@ "reference": "What happens if someone import `typing` and thus uses `@typing.final` instead?" }, { - "prediction": "I think we should remove the `>=` from `pytest-benchmark>=3.1`", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `pytest>=3.1` and `pytest-cov>=2.4` instead of `pytest>=3.1` and `pytest-cov>=2.4` because `pytest-cov>=2.4` is not compatible with `pytest>=3.1` and `pytest-cov>=2.4` is not compatible with `pytest>=3.1` and `pytest-cov>=2.4` is not compatible with `pytest>=3.1` and `pytest-cov>=2.4` is not compatible with `pytest>=3.1` and `pytest-cov>=2.4` is not compatible with `pytest>=3.1` and `pytest-cov>=2.4` is not compatible with `pytest>=3.1` and `pytest-cov>=2.4` is not compatible with `pytest>=3.1` and `pytest-cov>=2.4` is not compatible with `pytest>=3.1` and `pytest-cov>=2.4` is not compatible with `pytest>=3.1` and `pytest-cov>=2", "reference": "Better remove this dependency altogether" }, { - "prediction": "I think this should be `extern __thread h2o_buffer_prototype_t h2o__http2client_wbuf_buffer_prototype;` instead of `extern h2o_buffer_prototype_t h2o__http2client_wbuf_buffer_prototype;`", + "prediction": "I think this should be `extern __thread h2o_buffer_prototype_t h2o__http2client_wbuf_buffer_prototype;`", "reference": "Could you please move the declaration to httpclient.h? I think we have a consistent pattern in declaring global variables in header files." }, { @@ -19711,55 +19711,55 @@ "reference": "We will also need to add this to the spec." }, { - "prediction": "I'm not sure I understand what you're trying to do here. Can you give an example of what you're trying to do?", + "prediction": "I'm not sure I understand what you're trying to do here. Can you explain a bit more?", "reference": "In startEvaluator, we have the paysetHint; we should use it to preinitialize the state delta allocation. The number of transactions and the deltas are typically growing in a linear fashion, so preallocating twice as much in the array initializer would be a good idea." }, { - "prediction": "Shouldn't this be `List` instead of `List`?", + "prediction": "I don't think this is a good idea. It would be better to have a method that returns the element by the value of the \"id\" attribute.", "reference": "we shouldn't add a bunch of static initializers 'everywhere' in the code. Probably just one would be good, during the construction of the 'RemoteWebDriver' class." }, { - "prediction": "I think this should be a `Benchmark` instead of a `BenchmarkCategory`, right?", + "prediction": "I think this should be `public static string SerializeObjectProperty() => JsonSerializer.Serialize(new { Prop = (object)_value });` instead of `public static string SerializeObjectProperty() => JsonSerializer.Serialize(new { Prop = (object)_value });`", "reference": "Would it be possible to move the creation of the `new { Prop = (object)_value }` out of the benchmark? In the current version, the benchmark includes the cost of creating and serializing the object, while if possible it should be the cost of serialization only." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `Translation\\PlatformAdapter\\Loco\\Bridge\\Symfony\\TranslationAdapterLocoBundle::class` in the `Translation\\PlatformAdapter\\Loco\\Bridge\\Symfony\\TranslationAdapterLocoBundle::class` in the `Translation\\PlatformAdapter\\Loco\\Bridge\\Symfony\\TranslationAdapterLocoBundle::class` in the `Translation\\PlatformAdapter\\Loco\\Bridge\\Symfony\\TranslationAdapterLocoBundle::class` in the `Translation\\PlatformAdapter\\Loco\\Bridge\\Symfony\\TranslationAdapterLocoBundle::class` in the `Translation\\PlatformAdapter\\Loco\\Bridge\\Symfony\\TranslationAdapterLocoBundle::class` in the `Translation\\PlatformAdapter\\Loco\\Bridge\\Symfony\\TranslationAdapterLocoBundle::class` in the `Translation\\PlatformAdapter\\Loco\\Bridge\\Symfony\\TranslationAdapterLocoBundle::class` in the `Translation\\PlatformAdapter\\Loco\\Bridge\\Symfony\\TranslationAdapterLocoBundle::class` in the `Translation\\PlatformAdapter\\Loco\\Bridge\\Symfony\\TranslationAdapterLocoBundle::class` in the `Translation\\PlatformAdapter\\Loco\\Bridge\\Symfony", + "prediction": "I'm not sure if this is the best way to do this, but it seems to work for now.", "reference": "only dev and local" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to remove the reserved column from the table, but I'm not sure what you're trying to do here. I think you're trying to remove the reserved column from the table, but I'm not sure what you're trying to do here. I think you're trying to remove the reserved column from the table, but I'm not sure what you're trying to do here. I think you're trying to remove the reserved column from the table, but I'm not sure what you're trying to do here. I think you're trying to remove the reserved column from the table, but I'm not sure what you're trying to do here. I think you're trying to remove the reserved column from the table, but I'm not sure what you're trying to do here. I think you're trying to remove the reserved column from the table, but I'm not sure what you're trying to do here. I think you're trying to remove the reserved column from the table, but I'm not sure what you're trying to do here. I think you're trying to remove the reserved column from the table, but I'm not sure what you're trying to do here. I", + "prediction": "I don't think we need to do this.", "reference": "This should not be nullable, instead it should be `->default(0);`" }, { - "prediction": "Shouldn't `columns` be a `List` instead of `ImmutableList`?", + "prediction": "`columns` is a `List`, not a `List`.", "reference": "What about `selectedColumns`? I believe it is frequently used throughout the project." }, { - "prediction": "I don't think this is a good idea. The `synonymBoostByPayload` is only used when the `enableGraphQueries` is set to `true`. If `enableGraphQueries` is set to `false`, then the `synonymBoostByPayload` should be `false` as well.", + "prediction": "I'm not sure what you're trying to do here. I think you want to set the synonymBoostByPayload to true, but I'm not sure what you're trying to do here. I think you want to set the synonymBoostByPayload to true, but I'm not sure what you're trying to do here. I think you want to set the synonymBoostByPayload to true, but I'm not sure what you're trying to do here. I think you want to set the synonymBoostByPayload to true, but I'm not sure what you're trying to do here. I think you want to set the synonymBoostByPayload to true, but I'm not sure what you're trying to do here. I think you want to set the synonymBoostByPayload to true, but I'm not sure what you're trying to do here. I think you want to set the synonymBoostByPayload to true, but I'm not sure what you're trying to do here. I think you want to set the synonymBoostByPayload to true, but I'm not sure what you're trying to do here. I think you want to set the synonymBoostByPayload to true, but I'm not sure what you're trying to do here. I", "reference": "I thought we switched the approach from a payload to boost attribute? Besides; it's not clear we need this toggle at all since the user could arrange for this behavior simply by having the new DelimitedBoost filter thing in the chain." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you want to use `self[:platform] =~ /cisco-5/` to check if the platform is Cisco-5. I think you want to use `self[:platform] =~ /cisco-5/` to check if the platform is Cisco-5. I think you want to use `self[:platform] =~ /cisco-5/` to check if the platform is Cisco-5. I think you want to use `self[:platform] =~ /cisco-5/` to check if the platform is Cisco-5. I think you want to use `self[:platform] =~ /cisco-5/` to check if the platform is Cisco-5. I think you want to use `self[:platform] =~ /cisco-5/` to check if the platform is Cisco-5. I think you want to use `self[:platform] =~ /cisco-5/` to check if the platform is Cisco-5. I think you want to use `self[:platform] =~ /cisco-5/` to check if the platform is Cisco-5. I think you want to use `self[:platform", + "prediction": "I think we can remove the `if self[:platform] =~ /cisco-5/` line.", "reference": "the previous code used 'export' when platform is cisco-5, presumably because 'env' cannot be used to load variables? I have no idea if that's the case but this env vs export logic is not here" }, { - "prediction": "I think it's better to use `SecretARN` and `SecretPrefix` instead of `SecretCount` and `SecretARN`.", + "prediction": "I'm not sure if this is the right place to put it, but I think it should be in the `CloudInit` struct.", "reference": "I'm wondering if we need to add some type of validation here that the SecretCount != 0... Or do we think it would be valid to have a SecretCount of 0?" }, { - "prediction": "I'm not sure what you mean by \"slaveOk\" and \"secondaryOk\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me if this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me if this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me if this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me if this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me if this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me if this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me if this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me if this is the", "reference": "This test is being skipped. I unskipped it, and it failed in the same way for both `slaveOk: false` and `secondaryOk: false`. I'm not sure how else to test this broken test." }, { - "prediction": "I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `OutboundCall` struct.", "reference": "I don't believe that we need a pointer to an interface for the `to` side of this since we're just assigning a value to the to field." }, { - "prediction": "I'm not sure what you mean by `times < 0`", + "prediction": "I'm not sure I understand what you're trying to do here, but I think you're trying to do something like this:\r\n\r\n```python\r\n@cmdutils.register(maxsplit=1, no_cmd_split=True, no_replace_variables=True)\r\n@cmdutils.argument('count', count=True)\r\ndef repeat(times: int, command, win_id, count=None):\r\n \"\"\"Repeat a given command.\r\n \r\n Args:\r\n times: How many times to repeat.\r\n command: The command to run, with optional args.\r\n \"\"\"\r\n if count is not None:\r\n times *= count\r\n if times < 0:\r\n raise cmdexc.CommandError(\"A negative count doesn't make sense.\")\r\n commandrunner = runners.CommandRunner(win_id)\r\n for _ in range(times):\r\n commandrunner.run(command)\r\n```", "reference": "No blank line after the docstring." }, { - "prediction": "I'm not sure what you're trying to do with this test, but I think it's a bit of a red herring. It's not clear what you're trying to do with this test, but I think it's a bit of a red herring. It's not clear what you're trying to do with this test, but I think it's a bit of a red herring. It's not clear what you're trying to do with this test, but I think it's a bit of a red herring. It's not clear what you're trying to do with this test, but I think it's a bit of a red herring. It's not clear what you're trying to do with this test, but I think it's a bit of a red herring. It's not clear what you're trying to do with this test, but I think it's a bit of a red herring. It's not clear what you're trying to do with this test, but I think it's a bit of a red herring. It's not clear what you're trying to do with this test, but I think it's a bit of a red herring. It's not clear what you're trying to do with this test", + "prediction": "I don't think we need to use `os/exec` here. We can just use `os.File` and `os.OpenFile`.", "reference": "nit: move this to the group below." }, { @@ -19767,31 +19767,31 @@ "reference": "This is fine, but maybe we should change the variable name to \"bufferSize_as_uint\"? Or \"...uint32\"?" }, { - "prediction": "I think this should be `if term_info['suggestion'].first.is_a?(Hash)` instead of `if term_info['suggestion'].first.is_a?(Hash) or suggestions.index(\"correctlySpelled\")`", + "prediction": "I'm not sure what you mean by \"extended results\". I think you meant to say \"non-extended results\".", "reference": "Use snake_case for variable names." }, { - "prediction": "I'm not sure what you mean by \"run this test only if we can read Thermo's raw files```. I'm not sure what you mean by \"run this test only if we can read Thermo's raw files```. I'm not sure what you mean by \"run this test only if we can read Thermo's raw files```. I'm not sure what you mean by \"run this test only if we can read Thermo's raw files```. I'm not sure what you mean by \"run this test only if we can read Thermo's raw files```. I'm not sure what you mean by \"run this test only if we can read Thermo's raw files```. I'm not sure what you mean by \"run this test only if we can read Thermo's raw files```. I'm not sure what you mean by \"run this test only if we can read Thermo's raw files```. I'm not sure what you mean by \"run this test only if we can read Thermo's raw files```. I'm not sure what you mean by \"run this test only if we can read Thermo's raw files```. I'm not sure what you mean by \"run this test only if we can", + "prediction": "I'm not sure what you mean by \"run this test only if we can read Thermo's raw files\"", "reference": "Obviously, don't merge this to master." }, { - "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to mock the `exit_early` method to return a specific exit code (42 in this case) and then call `reporter.exit_early` with that exit code. Is this what you're trying to do? If so, what's the purpose of the `exit_early` method in the first place and how does it relate to the `report` method?", + "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not", "reference": "Nearly there! This should assert on the output, take the result of \"start\" and \"finish\" as an example :)" }, { - "prediction": "I think this should be `s.grabQueue(maxMessages)` instead of `s.grabQueue()`.", + "prediction": "I think this should be `for len(ms) > 0` instead of `for len(ms) != 0`.", "reference": "This loop is going to burn CPU if len(s.q) == 0. Maybe a small sleep?" }, { - "prediction": "I don't think we need to change this.", + "prediction": "I don't think we need to use `HashMap` here. We can use `List` instead.", "reference": "can you give a reason why session should be contained in RegionManager?" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a separate test for when the signature is empty. This way we can make sure that the signature is not empty before we extract the signer ID.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this.", "reference": "You are comparing two signerIDs here, error message should be \"Signers should match\"" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place", "reference": "Who's acquiring this lock for writes?" }, { @@ -19799,39 +19799,39 @@ "reference": "This throws a linter error, don't use object creation for side effects. I feel like it's kinda messed up that the errors are thrown by the constructor and not that the constructor will throw them" }, { - "prediction": "I think this should be `create(:trail)` instead of `create(:trail, topic: create(:topic, name: \"A\"))`?", + "prediction": "I'm not sure what you mean by \"showing completed trails for a user\". I think you meant to say \"showing trails completed for a user\".", "reference": "Should there be a `trail.topic_name` method so we don't annoy Demeter?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.", + "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to do this with a single call to `build_package` instead of calling `build_package` multiple times for each Yaml file.", "reference": "instead of passing \"None\" it would be more readable to create a constant e.g. TEAM_PUBLIC = None and then call build_package(TEAM_PUBLIC, ...)" }, { - "prediction": "I'm not sure what you mean by \"show all errors\". What do you mean by `error_reporting(-1);`?", + "prediction": "I don't think this is necessary.", "reference": "Would it make sense to include this file via composer files-autoloading instead?" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to add a check that the element is not null.", + "prediction": "I don't think we need to use `StaleElementReferenceException` here. We can just use `NoSuchElementException` instead.", "reference": "Each `ExpectedCondition` implements `java.util.Function` These are expected to be stateless. This condition will leak previous `elementText` on the second usage, which doesn't seem ideal." }, { - "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `sqlmock` for testing. It's not a good idea to use `sqlmock` for testing, because it's not a good idea to use `sqlmock` for testing, because it's not a good idea to use `sqlmock` for testing, because it's not a good idea to use `sqlmock` for testing, because it's not a good idea to use `sqlmock` for testing, because it's not a good idea to use `sqlmock` for testing, because it's not a good idea to use `sqlmock` for testing, because it's not a good idea to use `sqlmock` for testing, because it's not a good idea to use `sqlmock` for testing, because it's not a good idea to use `sqlmock` for testing, because it's not a good idea to use `sqlmock` for testing, because it's not a good idea to use `sqlmock` for testing, because it's not a good idea to use `sqlmock` for testing, because it's not a good idea to use `sqlmock` for testing", + "prediction": "I'm not sure what you're trying to achieve with this test, but I think it's a bit confusing. I think you're trying to mock the `sqlmock` package, but I don't think that's what you're trying to do here. I think you're trying to mock the `plan` package, but I don't think that's what you're trying to do here. I think you're trying to mock the `sqlmock` package, but I don't think that's what you're trying to do here. I think you're trying to mock the `plan` package, but I don't think that's what you're trying to do here. I think you're trying to mock the `sqlmock` package, but I don't think that's what you're trying to do here. I think you're trying to mock the `plan` package, but I don't think that's what you're trying to do here. I think you're trying to mock the `sqlmock` package, but I don't think that's what you're trying to do here. I think you're trying to mock the `plan` package, but I don't think that's what you're trying to do here. I think you're trying", "reference": "Extra newline here. Thanks for moving it under the `testing` import though. This just needs to be grouped with the other imports below it." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to set the content transfer encoding to \"quoted-printable\" and then set the header to \"8bit\". Is that what you're trying to do?", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to set the `Content-Transfer-Encoding` to `quoted-printable` if the body has a `Content-Type` of `text/plain` or `text/html`. If the body has a `Content-Type` of `application/x-www-form-urlencoded` or `multipart/form-data`, then we should set the `Content-Transfer-Encoding` to `8bit`.", "reference": "Should we ignore case when doing the comparison?" }, { - "prediction": "I'm not sure if this is a good idea, but I think it would be better to use `wl_display_get_backend()` instead of `wl_display_get_backend_x11()`.", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `wl_display_get_backend` instead of `wl_display_get_backend_x11`.", "reference": "The same `ifdef` should apply to `#include ` line 14" }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it's a good idea to move this into the `BeforeAction` method.", + "prediction": "I'm not sure if this is the right place to do this, but I think we should move this to the `BeforeAction` method.", "reference": "We're instrumenting a static method, so there's no instance in this case. `diagnosticSource` is the first argument." }, { - "prediction": "I don't think this is needed anymore.", + "prediction": "I think we should remove the `isHighPriority` field.", "reference": "I feel like this belongs in `RecipientPresenter` (which should really be `MetadataPresenter`), but I suppose having it next to requestReadReceipt makes sense as well. feel free to leave as is." }, { @@ -19839,23 +19839,23 @@ "reference": "Let's go back to 1.4.0 until the release is being prepared." }, { - "prediction": "I'm not sure what you mean by \"we also need access to the params in post_system_call\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that `dcontext->sys_param0` and `dcontext->sys_param1` are set before `post_system_call` is called.", "reference": "I would avoid the term \"errno\" as it implies the glibc variable. Use error_code or status or something." }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use the same name for the channel and the handler.", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to create a new handler for the channel, but you want to use the existing handlers. Is that correct? If so, what's the purpose of the `handler{existing, h}`?", "reference": "@abhinav @kriskowal what do you think about putting the handler on `d`?" }, { - "prediction": "I'm not sure what you mean by `ExcludeLargerThan` and `StdinFilename`. I think you meant `ExcludeLargerThan` and `Stdin`.", + "prediction": "I don't think we need `ExcludeLargerThan` here.", "reference": "Why `restic.TagLists` and no `restic.TagList` ? Because I'm using `restic.TagList` here and using `restic.TagLists` is a lot of changes" }, { - "prediction": "I'm not sure I understand what you mean by \"ensure the timer and context do not end simultaneously\". Is it that the context is cancelled before the timer ends?", + "prediction": "I'm not sure I understand what you mean by \"ensure the timer and context do not end simultaneously\".", "reference": "An hour seems a significant amount of time to wait for within a test, does it need to be that long?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a connection to a gRPC server, but you're not using the `tlsClientConfig` parameter. If you want to create a connection to a gRPC server, you need to use the `tlsClientConfig` parameter. If you want to create a connection to a gRPC client, you don't need to use the `tlsClientConfig` parameter, but you do need to use the `tlsClientConfig` parameter.", + "prediction": "I'm not sure what you mean by `false` in this case. I think it should be `true`.", "reference": "Nit: (newish to golang, don't hesitate to tell me I'm wrong here, but ...) I'd have written this code, just for readability: keepAlive := false return d.dial(hostName, tlsClientConfig, keepAlive) ... or even return d.dial(hostName, tlsClientConfig, false) // keepAlive=false Personally I think Golang should have included named args; I think it's one of the things python got right." }, { @@ -19863,7 +19863,7 @@ "reference": "I don't think it would cause any version conflict, but I'd feel safer if you declared it last, so that the numerical id of the existing integrations don't change" }, { - "prediction": "I think this should be `apiutil.CertificateRequestHasInvalidRequest(req)` instead of `apiutil.CertificateRequestHasInvalidRequest`", + "prediction": "I think we should remove the `apiutil.CertificateRequestHasInvalidRequest` case.", "reference": "Can we provide some more useful actionable info here? `fmt.Sprintf(\"The certificate request could not be completed due to invalid request options: %s\", req.Status.Conditions[InvalidRequestCondition].Message)`" }, { @@ -19871,47 +19871,47 @@ "reference": "yeah, can change to 8545" }, { - "prediction": "I'm not sure if this is the right place to put it, but I think it should be in the `BatchActionRepositoryInterface` class.", + "prediction": "I don't think you need to use `CachedUser` here. `User` should be enough.", "reference": "As far as I can see you're not rollbacking transaction anywhere. This could potentially cause further issues(and very hard to debug ones) with not synchronized transactions between message handling. Is the transaction required in this place anyway? You seem only to be fetching data here. ack method is performing some updates so it makes sense" }, { - "prediction": "I don't think this is needed anymore. We can remove it now.", + "prediction": "I don't think we need this component. It's not used anywhere.", "reference": "What's the meaning of null URIEndpointObject?" }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it would be a good idea to add a `logging.config.dictConfig` call to the top of the file. This way, we don't have to do this every time we run the script.", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `logging.config.dictConfig` instead of `logging.config.fileConfig` because `logging.config.fileConfig` is deprecated and `logging.config.dictConfig` is the recommended way to configure logging.", "reference": "Why did you remove the time? It can be useful if some actions are ran in jobs?" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `github.com/t3rm1n4l/go-mega` instead of `github.com/t3rm1n4l/go-mega/mega`", + "prediction": "I'm not sure if this is a good idea, but I think it would be better to use the `mega` package instead of `github.com/t3rm1n4l/go-mega`", "reference": "File is not `goimports`-ed (from `goimports`)" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a binding for the `BasicToken` contract. I think you want to create a binding for the `BasicToken` contract, but I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a binding for the `BasicToken` contract. I think you want to create a binding for the `BasicToken` contract, but I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a binding for the `BasicToken` contract. I think you want to create a binding for the `BasicToken` contract, but I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a binding for the `BasicToken` contract. I think you want to create a binding for the `BasicToken` contract, but I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a binding for the `BasicToken` contract. I think you want to create a binding for the `BasicToken` contract, but I'm not sure what you're trying to achieve with", + "prediction": "I'm not sure what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's", "reference": "What the reason to change imports?" }, { - "prediction": "I'm not sure what you mean by \"got exception: org.apache.thrift.transport.TTransportException\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `HiveMetaStoreClient` class.", "reference": "Nit: continuation indents are 2 indents / 4 spaces." }, { - "prediction": "I think we can remove the `if parsed_url.netloc` check, as it's not necessary.", + "prediction": "I think it's better to use `JMX._string_prop(\"HTTPSampler.port\", parsed_url.port)` instead of `JMX._string_prop(\"HTTPSampler.port\", parsed_url.netloc)`.", "reference": "You can use `netloc.rsplit(\":\")` for that." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the config file exists before trying to read it. This way, if the config file doesn't exist, we don't try to read it and just return an error.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to log the error here.", "reference": "nits, I don't get the point of this change" }, { - "prediction": "I think this should be `errorPrefix` and `warningPrefix` instead of `errorPrefix` and `warningPrefix`.", + "prediction": "I think this should be `errorPrefix = \"\u2718 Error!\"`", "reference": "`warningPrefix` looks the same on both platforms, we could move it up to `log.go`." }, { - "prediction": "I think we can remove the `Tracer` field since it's not used in the `Filter` and `Interceptors` fields.", + "prediction": "I'm not sure what you mean by \"interceptors\" in this context. Could you please clarify?", "reference": "What's the motivation behind switching to plural here? I think we want singular cc @abhinav" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but I don't think this is the right place to do it.", + "prediction": "I don't think we need to wrap the error in a `wrapError` struct. We can just return the error directly.", "reference": "What do you think about renaming this method `FromErrorAndCode(code Code, err error) *Status`? One of the benefits is that it will be consistent with the naming of `func FromError(err error) *Status {` which does something almost similar." }, { @@ -19923,11 +19923,11 @@ "reference": "I'm still not convinced dropping Chrome logs is the right thing to do, but if you insist" }, { - "prediction": "I'm not sure what you mean by \"Unable to get the name\"", + "prediction": "I'm not sure what you mean by \"Unable to get the name\". Is it because it's not a `String`?", "reference": "It would be helpful to include some reasoning here. With the reflection model, it is often the case that names are not available." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to set the log level to `DEBUG` in this case, so we can see what's going on.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to set the log destination to `stderr` as well.", "reference": "Instead of setting this here, why not have the flag call in the init function set `caddy.LogDestination` directly, and switch on that?" }, { @@ -19935,35 +19935,35 @@ "reference": "This belongs under \"WordPress dependencies\"." }, { - "prediction": "I think this should be `using Datadog.Trace.ClrProfiler.IntegrationTests.Elasticsearch5Tests;` instead of `using Datadog.Trace.ClrProfiler.IntegrationTests;`", + "prediction": "I think this should be `using Datadog.Trace.TestHelpers;` instead of `using Datadog.Trace.ClrProfiler.IntegrationTests;`", "reference": "Was there an issue on `net452`?" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `Write` method.", + "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to put it in the `WriteOutParameterInitializations` method.", "reference": "Another option is to always write it without quotes. I always have to use SR. And why not?" }, { - "prediction": "I'm not sure what you mean by `propType` being `PropTypes.oneOfType`. I think you meant `propType` to be `PropTypes.number` or `PropTypes.string`.", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `deepmerge` instead of `propType`.", "reference": "This should use the `merge` function added in #473 instead of introducing a new dependency" }, { - "prediction": "I think this should be `for (uint32_t i = 0; i < pCreateInfo->descriptorUpdateEntryCount; ++i)` instead of `for (const auto &binding : layout->GetBindings())`.", + "prediction": "I'm not sure if this is the right place to add this check, but I think it's a good idea.", "reference": "Shouldn't this say \"a binding with descriptor type VK_DESCRIPTOR_TYPE_MUTABLE_VALVE\"" }, { - "prediction": "I'm not sure what you mean by \"tool interface\". It's not a tool interface, it's a tool role. I'm not sure what you mean by \"tool interface\". It's not a tool interface, it's a tool role. I'm not sure what you mean by \"tool interface\". It's not a tool interface, it's a tool role. I'm not sure what you mean by \"tool interface\". It's not a tool interface, it's a tool role. I'm not sure what you mean by \"tool interface\". It's not a tool interface, it's a tool role. I'm not sure what you mean by \"tool interface\". It's not a tool interface, it's a tool role. I'm not sure what you mean by \"tool interface\". It's not a tool interface, it's a tool role. I'm not sure what you mean by \"tool interface\". It's not a tool interface, it's a tool role. I'm not sure what you mean by \"tool interface\". It's not a tool interface, it's a tool role. I'm not sure what you mean by \"tool interface\". It's not a tool interface, it's a tool role. I'm not sure what you", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to `wlr_tablet_tool_v2.c` instead of `wlr_tablet_tool_v2_grab_interface.c`.", "reference": "This variable name should probably contain `grab`" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to set the default funder to \"H2020\" but you're not using it anywhere in the code.", + "prediction": "I'm not sure what you're trying to do with this, but it looks like you're trying to set the default funder to \"H2020\", but you're also trying to set the default funder to \"H2020\" twice. I'm not sure what you're trying to do with this, but it looks like you're trying to set the default funder to \"H2020\", but you're also trying to set the default funder to \"H2020\" twice. I'm not sure what you're trying to do with this, but it looks like you're trying to set the default funder to \"H2020\", but you're also trying to set the default funder to \"H2020\" twice. I'm not sure what you're trying to do with this, but it looks like you're trying to set the default funder to \"H2020\", but you're also trying to set the default funder to \"H2020\" twice. I'm not sure what you're trying to do with this, but it looks like you're trying to set the default funder to \"H2020\", but you", "reference": "Which initializer should we be using for open_aire? The one in `external_apis` or this one in `initializers`?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `routing` package to create a routing table for a peer. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `routing` package to create a routing table for a peer. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `routing` package to create a routing table for a peer. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `routing` package to create a routing table for a peer. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `routing` package to create a routing table for a peer. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `routing` package to create a routing table for a peer. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `routing` package to create a routing table for", + "prediction": "I'm not sure if this is a good idea, but I think it would be better to use `peerstore` and `routing` instead of `libp2p-peerstore` and `libp2p-routing`.", "reference": "remove todo on line 28?" }, { - "prediction": "I don't think this is a good idea. It's not clear to me why we would want to do this. I think it's better to just use `backbone=dict(backbone=dict(type='ResNeXt', depth=101, groups=64, base_width=4, num_stages=4, out_indices=(0, 1, 2, 3), frozen_stages=1, norm_cfg=dict(type='BN', requires_grad=True), style='pytorch'))`", + "prediction": "why do we need to use `out_indices=(0, 1, 2, 3)`?", "reference": "clean unnecessary arguments." }, { @@ -19971,15 +19971,15 @@ "reference": "Could the name of the status be confusing to users? It says the execution stopped but is it a temporary stop? Will it continue to run at some point? To me the name does not suggest a final status but a transition one. WDYT @sshardool @jakhani @djaiswal83 @aditya1105" }, { - "prediction": "I'm not sure what you're trying to achieve with this change. It seems like you're trying to create a new `DockerProvisioner` class that inherits from the `provisioners.DockerProvisioner` class. However, the `provisioners.DockerProvisioner` class is already defined in the `molecule.provisioners` module, so you don't need to create a new class for this purpose.", + "prediction": "I think this should be `from molecule.provisioners import DockerProvisioner` instead of `from molecule.Provisioners import DockerProvisioner`", "reference": "Since we created a Provisioners directory, can we do the same with the tests, and follow the same structure as the code?" }, { - "prediction": "I think we can remove `mapSizeStr` and just use `mapSize` instead.", + "prediction": "I think we should remove the `sentryAddr` and `coreAddr` fields.", "reference": "We don't need that one anymore?" }, { - "prediction": "I'm not sure what you're trying to achieve with this code. It looks like you're trying to create a custom renderer for the `graphite.render.attime` module, but I'm not sure what you're trying to achieve with this code. It looks like you're trying to create a custom renderer for the `graphite.render.attime` module, but I'm not sure what you're trying to achieve with this code. It looks like you're trying to create a custom renderer for the `graphite.render.attime` module, but I'm not sure what you're trying to achieve with this code. It looks like you're trying to create a custom renderer for the `graphite.render.attime` module, but I'm not sure what you're trying to achieve with this code. It looks like you're trying to create a custom renderer for the `graphite.render.attime` module, but I'm not sure what you're trying to achieve with this code. It looks like you're trying to create a custom renderer for the `graphite.render.attime` module, but I'm not sure what you're trying to achieve with this code. It looks like you're trying to create a custom renderer for the `graphite.render.attime`", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be a good idea to move it to the `graphite.render` module. It's a bit of a mess, but I think it would be a good idea to keep it separate from the rest of the code.", "reference": "Since we're determining the local node's host info in the `Store()` init, we need to import the `STORE` object here. Is this OK, or should I be determining the host info earlier. (When parsing settings?)" }, { @@ -19991,39 +19991,39 @@ "reference": "can we localise these? not sure if we have easy access to a translator instance from `generic-provider-views`" }, { - "prediction": "I think this is a typo. `usb_STRING_PRODUCT` and `usb_STRING_MANUFACTURER` should be `usb_STRING_PRODUCT_STRING` and `usb_STRING_MANUFACTURER_STRING` respectively.", + "prediction": "I think we should use `usb_STRING_PRODUCT` and `usb_STRING_MANUFACTURER` instead of `usb_STRING_PRODUCT` and `usb_STRING_MANUFACTURER`.", "reference": "This is the VID from Adafruit. Doesn't Particle have a different VID? (CC @suda)." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to truncate the scope string.", + "prediction": "I'm not sure what you mean by `scope->buffer[old_len] = '\\0';`", "reference": "The function is only used once, and this body is now only 1 call with the same args (e.g. basically an alias for `vStringTruncate`), it could probably be simply removed. But if you wanna keep the naming for clarity, it also sounds reasonable." }, { - "prediction": "I think this should be a warning, not an error.", + "prediction": "I think it's better to use `fmt.Errorf` instead of `fmt.Sprintf` here.", "reference": "please change to `could not connect to peer: %s`. it is not relevant to say \"from kademlia\" in a warning" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to convert a timestamp to a `DateTime` and then to a `TimeUtils::rmDateTimeStrMs` string. I'm not sure what you're trying to do here, but it looks like you're trying to convert a timestamp to a `DateTime` and then to a `TimeUtils::rmDateTimeStrMs` string. I'm not sure what you're trying to do here, but it looks like you're trying to convert a timestamp to a `DateTime` and then to a `TimeUtils::rmDateTimeStrMs` string. I'm not sure what you're trying to do here, but it looks like you're trying to convert a timestamp to a `DateTime` and then to a `TimeUtils::rmDateTimeStrMs` string. I'm not sure what you're trying to do here, but it looks like you're trying to convert a timestamp to a `DateTime` and then to a `TimeUtils::rmDateTimeStrMs` string. I'm not sure what you're trying to do here, but it looks like you're trying to convert a timestamp to a `DateTime` and then to a `TimeUtils::rmDateTimeStrMs`", + "prediction": "I don't think we need to do this.", "reference": "Why need to remove this? Datetime has microseconds in fact." }, { - "prediction": "I think it's better to use `x509.MarshalECPrivateKey` instead of `x509.MarshalPKCS1PrivateKey`", + "prediction": "I think it's better to use `x509.MarshalECPrivateKey` instead of `x509.MarshalPKCS1PrivateKey`.", "reference": "What's up with this, isn't it nil? Why not use the real T value from the test function? @elcore @wmark" }, { - "prediction": "I'm not sure what you mean by \"psalm-mutation-free\"", + "prediction": "I'm not sure if this is a good idea, but I don't think it's a good idea to return `false` here. If you want to return `false`, you should return `null` instead of `false`.", "reference": "this feels weird" }, { - "prediction": "I think it's a good idea to add a `PREMERGE` enum as well.", + "prediction": "I think it's better to have a `NetworkName` enum and a `NetworkType` enum, and then have a `Network` enum that is a combination of the two.", "reference": "I don't think this is the type of network we should be putting in our named networks." }, { - "prediction": "I'm not sure what you mean by \"starting fetch_data\" but I think it should be \"fetching data\".", + "prediction": "I don't think we need to open the debug file here.", "reference": "debug? I suspect this will be removed before merge?" }, { - "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to", + "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here. If you want to test the `writeConcernMax` option, you should use the `writeConcern` option instead of `writeConcernMax`.", "reference": "should this be here twice?" }, { @@ -20035,63 +20035,63 @@ "reference": "This isn't something you introduced in your changes, but the change makes more obvious to me that this test would be better as a unit test of some kind (probably a controller test). Testing a 404 is an edge case that probably doesn't need to be tested with all components in integration." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a `Supplier` from a `Class>`, but that doesn't make sense. You can't create a `Supplier` from a `Class>`. You can only create a `Supplier` from a `Supplier` or a `Class>`. If you want to create a `Supplier` from a `Class>`, you need to create a `Supplier` from a `Class>` and then create a `Supplier` from a `Supplier`.", + "prediction": "I don't think this is a good idea. The `Supplier` is not a `Class>`, it's a `Supplier`. The `Class>` is not a `Supplier`, it's a `Supplier>>`.", "reference": "We chose `info` in the test code for obvious reasons. Changing to `finest` makes debugging harder and noisier." }, { - "prediction": "I'm not sure what you're trying to do here. You're setting `id` to `remoteHost.getHost() + \":\" + remoteHost.getPort()`, but then you're assigning `id` to `id = \"http://\" + remoteHost.getHost() + \":\" + remoteHost.getPort();` which doesn't make sense.", + "prediction": "I'm not sure if this is the best way to do this, but it seems to work for me.", "reference": "any reason you're assigning to the local variable 'id' too?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to import `molecule.validators` or `vagrant` here.", + "prediction": "I think this should be `from subprocess import CalledProcessError` instead of `from subprocess import CalledProcessError`", "reference": "Need to fix this import :)" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a test for the `GetActor` method.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the", "reference": "sorry these tests suck so much we are working to kill them" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to call `updateTimeDisplay` from the `releaseCurrentPlayer` method.", "reference": "Why not adjust `currentTime` to be in ms directly?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in `instr_is_reg_spill_or_restore_ex` as well.", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to check if the instruction is a reg spill/restore, and if so, if it's a reg spill/restore that is not a mcontext base load. Is that correct?", "reference": "> restore, we find the matching spill for that restore which uses the same slot nit: Two separate sentences: separate with `.` or something besides `,`." }, { - "prediction": "I'm not sure what you mean by \"use badger db\". I think you meant to say `UseBadgerDB: true`", + "prediction": "I'm not sure if this is a good idea, but I think we should remove the `UseBadgerDB` field.", "reference": "this flag not used" }, { - "prediction": "I'm not sure what you're trying to do here. The `expiration_date` is a string, not a date, so I'm not sure what you're trying to do with it.", + "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.", "reference": "I don't think `?? null` works here... that's to ensure PHP doesn't throw an \"undefined\" error about `$profile->expirationDate`, but now the code is assuming that `$profile->expirationDate` will be set. Might be cleaner to do: 
     $expiration = isset($profile->expirationDate) ? $this->dateConverter->convertToDisplayDate(\"Y-m-d H:i\", $profile->expirationDate) : null;
    And then assigning the `$expiration` value in the return array..." }, { - "prediction": "I don't think it's necessary to use `Vue.config.productionTip = false` in this case. We can just use `Vue.config.productionTip = true` instead.", + "prediction": "I don't think it's necessary to use `Vue.config.productionTip = false` in this case.", "reference": "An ENV should be used? Are you sure that the Vue examples are built in the production mode?" }, { - "prediction": "I think we should remove the `skip` and `status` fields from the `NodeResult` struct.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `dbt` module.", "reference": "Nit: this should actually always be float since we convert it before we construct the namedtuple." }, { - "prediction": "I don't think we need to check if the file type is `DIRECTORY` here. It's already checked by `FileUtils::fileType(path.c_str()) == FileType::NOTEXIST`.", + "prediction": "I don't think it's necessary to check if the file type is a directory. If it's not a directory, then it's not a file.", "reference": "The result of `FileUtils::fileType` could be saved, instead of calling twice." }, { - "prediction": "I'm not sure if this is a good place to put this, but I think we should move it to the `MediaProviderInterface` abstract class.", + "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a `doTransform` method in the `MediaProviderInterface` class. This way, we don't need to call `doTransform` every time we want to transform a media.", "reference": "Can you log the exception ?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in `http_client.c` instead of `http_server.c`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `http_client` struct.", "reference": "since this debug message is inside a plugin code, it should use flb_plg_debug(ctx->ins, \"...\"), on this case don't need the component prefix since the API will put it there automatically" }, { - "prediction": "I don't think this is needed anymore. The `Timestamp` class has been removed from the `java.sql.Timestamp` class in Java 8.", + "prediction": "I don't think this is needed anymore.", "reference": "I also took advantage of the changes to change the Timestamps used in this notification from \"java.sql.Timestamp\" to \"com.yahoo.rdl.Timestamp\"." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add a comment to explain what this change does.", + "prediction": "`BrokerReconnectWait` should be `time.Second` instead of `1 * time.Second`", "reference": "It would be nice all these tweaks to be configurable from cmd line, with sensible defaults" }, { @@ -20099,75 +20099,75 @@ "reference": "Why do we need this `check_same_thead` to be false? I feel a bit uncomfortable about this." }, { - "prediction": "I'm not sure what you're trying to do with this test, but I'm not sure if it's a good idea. It's not clear what you're trying to do with this test, but I'm not sure if it's a good idea. It's not clear what you're trying to do with this test, but I'm not sure if it's a good idea. It's not clear what you're trying to do with this test, but I'm not sure if it's a good idea. It's not clear what you're trying to do with this test, but I'm not sure if it's a good idea. It's not clear what you're trying to do with this test, but I'm not sure if it's a good idea. It's not clear what you're trying to do with this test, but I'm not sure if it's a good idea. It's not clear what you're trying to do with this test, but I'm not sure if it's a good idea. It's not clear what you're trying to do with this test, but I'm not sure if it's a good idea. It's not clear what you're trying to do with this test, but I'm not sure if it's", + "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.", "reference": "We should probably test with constructors which aren't in the schema, and functions which aren't constructors." }, { - "prediction": "I think it's better to use `arg_label` and `arg_logical_size` instead of `arg_alloc_size` and `arg_logical_size`.", + "prediction": "I think this should be `const size_t arg_alloc_size` instead of `const size_t arg_logical_size`.", "reference": "this call doesn't work doesn't? I mean there doesn't seem to be an 2 argument allocate overload. Maybe arg_logical_size should just be defaulted to the arg_alloc_size thing. Or we should just report out physical allocation size instead of logical." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to set the `privatebindir` to `/opt/puppetlabs/puppet/bin` instead of `/opt/puppet/bin`. I think you meant to set `privatebindir` to `/opt/puppet/bin` instead of `/opt/puppetlabs/puppet/bin`.", + "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to set the `privatebindir` to `/opt/puppetlabs/puppet/bin`, which is not a valid path. It should be `/opt/puppet/bin`, not `/opt/puppetlabs/puppet/bin`.", "reference": "This winds up flipping the desired values. Looks like I gave you a bum steer @kevpl" }, { - "prediction": "I don't think we need to use `zap.Fields` here. We can just use `zap.String` directly.", + "prediction": "I don't think it's necessary to use `zap.String` here. `zap.Fields` will do the same thing as `zap.String`.", "reference": "nit: let's call our address ioAddr from now on" }, { - "prediction": "I'm not sure what you mean by \"Implicit layer\". It's not an implicit layer, it's an explicit layer. I'm not sure what you mean by \"Ignore such calls\". It's not an implicit layer, it's an explicit layer. I'm not sure what you mean by \"Ignore such calls\". It's not an implicit layer, it's an explicit layer. I'm not sure what you mean by \"Ignore such calls\". It's not an implicit layer, it's an explicit layer. I'm not sure what you mean by \"Ignore such calls\". It's not an implicit layer, it's an explicit layer. I'm not sure what you mean by \"Ignore such calls\". It's not an implicit layer, it's an explicit layer. I'm not sure what you mean by \"Ignore such calls\". It's not an implicit layer, it's an explicit layer. I'm not sure what you mean by \"Ignore such calls\". It's not an implicit layer, it's an explicit layer. I'm not sure what you mean by \"Ignore such calls\". It's not an implicit layer, it's an explicit layer. I'm not sure what you mean by \"Ignore such calls\". It's not an implicit layer, it's an", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a check here. If the call returns 0 for maxBoundDescriptorSets, then we can't do anything about it, so we should just return 0 here.", "reference": "You're killing this \"else\" case here which currently flags an error when maxBoundDescriptorSets == 0." }, { - "prediction": "I'm not sure I understand what you're trying to do here. I don't think this is the right place to do this.", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to remove the null checksums from the list of supported refs, but I'm not sure if that's what you're trying to do or not.", "reference": "Nitpick: I'd append `_cb` to the function name here to mark it as a callback. Otherwise it looks a bit like this will do the entire job of removing null checksum refs from a hash table." }, { - "prediction": "I'm not sure what you mean by \"isNotView\"", + "prediction": "I don't think this is a good idea. The `isNotView` method should return `true` if the table is not a view and `false` if it is a view.", "reference": "or you can use `filter(x => !x.isView)`" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to get the bootstrap key from the storage, but I'm not sure what you're trying to do with it. I think you're trying to get the bootstrap key from the storage, but I'm not sure what you're trying to do with it. I think you're trying to get the bootstrap key from the storage, but I'm not sure what you're trying to do with it. I think you're trying to get the bootstrap key from the storage, but I'm not sure what you're trying to do with it. I think you're trying to get the bootstrap key from the storage, but I'm not sure what you're trying to do with it. I think you're trying to get the bootstrap key from the storage, but I'm not sure what you're trying to do with it. I think you're trying to get the bootstrap key from the storage, but I'm not sure what you're trying to do with it. I think you're trying to get the bootstrap key from the storage, but I'm not sure what you're trying to do with it. I think you're trying to get the bootstrap key from the storage, but I'm not sure what", + "prediction": "I don't think we need to use `bytes.NewBuffer` here. We can just use `bytes.Buffer` here.", "reference": "Instead of NewBuffer on the line above, do NewReader to avoid having to wrap later." }, { - "prediction": "I don't think it's necessary to call `self.call(modified_src, dst, *asciidoc_args)` here.", + "prediction": "I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place", "reference": "No need for this, as pylint already only turns things off for this function and it's needed for the entire function." }, { - "prediction": "I'm not sure what you mean by \"groupTxBytes + groupTxBytes > eval.proto.MaxTxnBytesPerBlock\". I think you meant to say \"groupTxBytes + groupTxBytes + groupTxBytes > eval.proto.MaxTxnBytesPerBlock\".", + "prediction": "I'm not sure what you mean by \"groupTxBytes\". Is it the number of bytes in the serialized txib? Or is it the number of bytes in the serialized txib and the serialized txid?", "reference": "extra brownie points ( overall solution ): we've currently triple-encoding the payset - 1. we encode it to calculate the block size. 2. we encode it to calculate the commit hash ( either via flat, or as Merkle tree ). 3. we encode it as a whole for the purpose of preparing the proposal ( I know that this isn't always the case, but this case happens to be on the critical path ). Caching the encoded data of the *first* block could help us repeating the process." }, { - "prediction": "I think this should be a test for `Mongoid::Errors::MongoidError::RESTRICT_ERROR_MSG` instead.", + "prediction": "I think this should be `Mongoid::Errors::MongoidError::RESTRICT_ERROR_MSG` instead of `Mongoid::Association::Depending::RESTRICT_ERROR_MSG`.", "reference": "This assertion should use the actual expanded string, so that it is clear what the message produced looks like. Right now one has to run the code to determine what the message is." }, { - "prediction": "I'm not sure what you mean by this, but I think it's a good idea to remove the `fmt` import. It's not used anywhere else in the code.", + "prediction": "I don't think this is necessary. We can just use `errors.New` instead of `fmt.Errorf` in this case.", "reference": "similar here for imports, these should be consolidated (and also consolidated with the grouping below)" }, { - "prediction": "I don't think this is a good idea. We should use `mmcv.FileClient` directly.", + "prediction": "I don't think it's necessary to pass `self.file_client_args` to `load_bboxes`.", "reference": "Maybe there is no need to modify it. Because if you don't use the mask, it won't be initialized." }, { - "prediction": "I think we can remove the `%` from the annotationKey, since it's not used anywhere else in the code.", + "prediction": "I think we should remove the `%` from the annotationKey, since it's not used anywhere.", "reference": "Is there a reason we wouldn't want the trailing `%`? I'm guessing that without the trailing `%` it will just do a strict match vs a partial prefix right?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to include `safe_string.h` or `getopt.h` or `stdint.h` or `errno.h` or `sys/stat.h` or `safe_string.h` or `getopt.h` or `stdint.h` or `errno.h` or `sys/stat.h` or `safe_string.h` or `getopt.h` or `stdint.h` or `errno.h` or `sys/stat.h` or `safe_string.h` or `getopt.h` or `stdint.h` or `errno.h` or `sys/stat.h` or `safe_string.h` or `getopt.h` or `stdint.h` or `errno.h` or `sys/stat.h` or `safe_string.h` or `getopt.h` or `stdint.h` or `errno.h` or `sys/stat.h` or `safe_string.h` or `getopt.h` or `stdint.h` or `errno.h` or `sys/stat.h` or `safe_string.h` or `getopt.h` or `stdint.h` or `errno.h` or `sys/stat.h` or `safe_string.h` or `getopt.h` or", + "prediction": "I don't think we need to include `safe_string.h` in this file.", "reference": "Please update the DMA test app in AFU repo once this gets approved." }, { - "prediction": "I don't think it's necessary to persist the `SeoSettingFacade::SEO_TITLE_ADD_ON` value.", + "prediction": "I don't think it's necessary to persist the `SeoSettingFacade::SEO_TITLE_ADD_ON` here.", "reference": "There should be a migration for that as well to reflect the change on in-production instances" }, { - "prediction": "I think we should use the default AZs here instead of hardcoding them.", + "prediction": "I think it's better to use `\"\"` here instead of `\"\"` and `\"\"` here instead of `\"\"`.", "reference": "Why does it have to be `\"\"` instead of an empty string" }, { - "prediction": "I think this should be `unless pending` instead of `unless RSpec.configuration.dry_run`?", + "prediction": "I'm not sure what you mean by \"dry run\" here. I think you meant to say \"dry run\" here.", "reference": "This is very strongly opinionated so feel free to disagree with me better, but as conditionals get more complex I like turn them into ifs instead of unlesses. What do you think?" }, { @@ -20179,11 +20179,11 @@ "reference": "We shouldn't use the `&.` syntax here, since we expect that `executor` will never be `nil`. For the functions that _can_ be called from apply / without an executor, `&.` is still appropriate." }, { - "prediction": "I'm not sure what you mean by \"throw new RuntimeException(feature)\"; it's not a runtime exception, it's a compile-time error.", + "prediction": "I'm not sure what you mean by \"throw new RuntimeException(feature)\"; I think you meant to say \"throw new UnsupportedOperationException(feature)\"", "reference": "Why the switch from period to colon?" }, { - "prediction": "I'm not sure if this is a good idea or not, but I think it would be better to use the `os.Getenv` function to get the value of the environment variable, rather than using `strconv.Atoi` to convert the string to an integer.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have this in a separate config file, so that we don't have to update it every time we add a new environment variable.", "reference": "Can you just fix the warning instead? It's actually important for this to have a default of `\"\"` as the subsequent merges with `DefaultConfig()` and `fileConfig()` need to work. If you make this not `\"\"`, you break the assumptions of `Merge()`." }, { @@ -20191,7 +20191,7 @@ "reference": "let us not add this" }, { - "prediction": "I'm not sure what you mean by \"not all cgroup manager implementations support changing the ownership\"", + "prediction": "I'm not sure what you mean by \"not all cgroup manager implementations support changing the ownership.\"", "reference": "Is there a need for group as well? crun sets both." }, { @@ -20199,27 +20199,27 @@ "reference": "@cijothomas This build-up pattern was really confusing. It looks like internally ActivityProcessor is intended to be chained but there is nothing in the abstract class that enforces it. We never set a \"Next\" or make sure that the chain is called. Probably need to do some more work in this area?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Can you give an example of what you're trying to do?", + "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea to use `pre()` on `save` and `findOneAndUpdate`.", "reference": "`this.getFilter()` won't work on `pre('save')`. Perhaps make this `toySchema.pre(['updateOne', 'findOneAndUpdate'])`?" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I think this is a bit of a red herring here. We don't care about the timestamp, we just want to make sure that the span is created and that it's not null.", "reference": "Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs." }, { - "prediction": "I think it's better to use `await shutdownReq.ShutdownAsync(_socket);` instead of `await shutdownReq.ShutdownAsync(_socket);`", + "prediction": "I think it's better to use `UvShutdownReq` and `UvShutdownResult` instead of `UvConnectionWriteFin` and `UvConnectionWroteFin`.", "reference": "I think this is the only place where we use `UvShutdownReq`. Can we remove the type altogether? Or do you prefer to keep it around?" }, { - "prediction": "I think this should be `InsecureSkipVerify` instead of `InsecureSkipVerify:true`", + "prediction": "I think we should use `InsecureSkipVerify: false` instead of `InsecureSkipVerify: true`", "reference": "I think we can get this to work by passing in the root ca cert fixture that upstream ca is using" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you're trying to do here. I don't think we need to use `mktime` to get the current year. We can just use `tm.tm_year` and `tm.tm_mon` to get the current year and month.", "reference": "Just occurred to me to ask: is the condor log date in localtime or UTC?" }, { - "prediction": "I'm not sure what you're trying to do with this, but it looks like you're trying to get the raw value of a varbit. I'm not sure what you're trying to do with this, but I'm not sure what you're trying to do with this, but I'm not sure what you're trying to do with this, but I'm not sure what you're trying to do with this, but I'm not sure what you're trying to do with this, but I'm not sure what you're trying to do with this, but I'm not sure what you're trying to do with this, but I'm not sure what you're trying to do with this, but I'm not sure what you're trying to do with this, but I'm not sure what you're trying to do with this, but I'm not sure what you're trying to do with this, but I'm not sure what you're trying to do with this, but I'm not sure what you're trying to do with this, but I'm not sure what you're trying to do with this, but I'm not sure what you're trying to do with this, but I'm not sure what you're trying to do with this, but I'm", + "prediction": "I'm not sure what you mean by \"current location of Sulliuscep tree.\"", "reference": "Can you remove the sculliscep varbits from here too?" }, { @@ -20227,19 +20227,19 @@ "reference": "I understand that it is a common practice in this script to add indexes this way but why don't we check index existence before adding it? I'm not very familiar with MySql but it's can be done easily in MSSQL and I'm pretty sure that there is a way to do the same here." }, { - "prediction": "I don't think this is a good idea.", + "prediction": "I don't think this is necessary. The `create_pause` method is already defined in the `InputDevice` class, so we don't need to create a new one.", "reference": "we should probably deprecate (and display a warning) the misspelled keyword arg here rather than removing it... and then add the new one. This changes a public API and will break any code that is currently using the misspelled version." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `h2o_mruby__new_str` function, since it's called by `h2o_mruby__new` and `h2o_mruby__new` are called by `h2o_mruby__new_exc` and `h2o_mruby__new_exc` are called by `h2o_mruby__new_exc` and `h2o_mruby__new_exc` are called by `h2o_mruby__new_exc` and `h2o_mruby__new_exc` are called by `h2o_mruby__new_exc` and `h2o_mruby__new_exc` are called by `h2o_mruby__new_exc` and `h2o_mruby__new_exc` are called by `h2o_mruby__new_exc` and `h2o_mruby__new_exc` are called by `h2o_mruby__new_exc` and `h2o_mruby__new_exc` are called by `h2o_mruby__new_exc` and `h2o_mruby__new_exc`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to `h2o_mruby__new_str` instead of `h2o_mruby__abort_exc`.", "reference": "Should we do something like `h2o__fatal(file, line, \"fatal error: %s, %s\\n\", mess, RSTRING_PTR(...))` here?" }, { - "prediction": "I'm not sure if this is a flaky test or not, but I think we should skip it.", + "prediction": "I'm not sure if this is a flaky test or not, but I think it should be skipped.", "reference": "is this one all platforms?" }, { - "prediction": "I'm not sure what you mean by \"not found\" in this case. I think it should be \"Not Found\" instead of \"not found\".", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `jsonhttptest` package.", "reference": "why capitals grr?" }, { @@ -20247,19 +20247,19 @@ "reference": "Surely all the above should go into `common`." }, { - "prediction": "I'm not sure I understand what you're trying to do with this test case. It looks like you're trying to test that the `caret_position` is set correctly when the caret is at the start of the text. However, I'm not sure what the `result` is supposed to be. Could you please provide more context or clarify what you're trying to achieve with this test case?", + "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to have a `caret_position` field in the test fixture. I think it's better to have a `caret_position` field in the test fixture, and then use it in the test.", "reference": "This is an unrelated change, but was failing CI... probably introduced in master." }, { - "prediction": "I'm not sure what you mean by \"useQueryQueryMatches\"", + "prediction": "I'm not sure what you mean by \"useQueryQueryMatches\" in this context. I think you meant \"useChirality\" or \"useQueryQueryMatches\"", "reference": "This piece isn't backwards compatible, but it's enough of an edge case that I think it's unlikely to be a problem." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to limit the number of messages in a single Publish RPC, but I'm not sure what you're trying to do here. I think you're trying to limit the number of messages in a single Publish RPC, but I'm not sure what you're trying to do here. I think you're trying to limit the number of messages in a single Publish RPC, but I'm not sure what you're trying to do here. I think you're trying to limit the number of messages in a single Publish RPC, but I'm not sure what you're trying to do here. I think you're trying to limit the number of messages in a single Publish RPC, but I'm not sure what you're trying to do here. I think you're trying to limit the number of messages in a single Publish RPC, but I'm not sure what you're trying to do here. I think you're trying to limit the number of messages in a single Publish RPC, but I'm not sure what you're trying to do here. I think you're trying to limit the number of messages in a single Publish RPC, but I'm not sure what you're trying to do here. I think you're", + "prediction": "I'm not sure if this is the right place to change this, but I think it would be a good idea to set this to 100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", "reference": "MB is presumably 1024 * 1024." }, { - "prediction": "I'm not sure what you mean by \"internal dependencies\" in this context. It's not a dependency of `DashboardSplashMain`, it's a dependency of `DashboardSplashMain` and `DashboardSplashMain` is a dependency of `DashboardSplashMain` and `DashboardSplashMain` is a dependency of `DashboardSplashMain` and `DashboardSplashMain` is a dependency of `DashboardSplashMain` and `DashboardSplashMain` is a dependency of `DashboardSplashMain` and `DashboardSplashMain` is a dependency of `DashboardSplashMain` and `DashboardSplashMain` is a dependency of `DashboardSplashMain` and `DashboardSplashMain` is a dependency of `DashboardSplashMain` and `DashboardSplashMain` is a dependency of `DashboardSplashMain` and `DashboardSplashMain` is a dependency of `DashboardSplashMain` and `DashboardSplashMain` is a dependency of `DashboardSplashMain` and `DashboardSplashMain` is a dependency of `DashboardSplashMain` and `DashboardSplashMain` is a dependency of `DashboardSplashMain` and `DashboardSplashMain` is a dependency of `DashboardSplashMain` and `DashboardSplashMain` is a dependency of `DashboardSplashMain` and `DashboardSplashMain` is a dependency", + "prediction": "I'm not sure if this is the right place to add this, but I think it would be good to add it to the `DashboardSplashMain` component as well.", "reference": "Didn't we extract this logic to a `react-features` helper?" }, { @@ -20271,23 +20271,23 @@ "reference": "Not your immediate problem, but having everything depend on a package that has the config for everything else is ick. Can you move the MessagePoolConfig here and reverse the dependency?" }, { - "prediction": "I'm not sure what you mean by \"enter key will send ACTION_DOWN and ACTION_UP both events out\"", + "prediction": "I don't think we need to wait for the enter key to be pressed. The enter key will send ACTION_DOWN and ACTION_UP both events out, so we don't need to wait for it to be pressed.", "reference": "recently, IME_ACTION_GO action can trigger key_down and key_up event successfully, so we don't need to send enter key separately as before, otherwise will trigger it twice and cause to enter empty passcode, which cause test failed." }, { - "prediction": "I think this should be `checkExprDepth` instead of `checkExprDepthFilter`", + "prediction": "I don't think we need to check the depth of the filter. It's already checked by the `checkExprDepth` function.", "reference": "It seems that you only need to do this `checkExprDepth()` inside `deduceExprType()`. So you don't have to add this check everywhere." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think we should move this to the `MailCreatorTest` class.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `mail-creator-test` unit test.", "reference": "why split into two lines?" }, { - "prediction": "I think this should be `private static final int PARTITION_DATA_ID_START = 1000;` instead of `private static final int PARTITION_DATA_ID_START = 1000;`", + "prediction": "I don't think we need to change this.", "reference": "Does this need to be public or can it be package-private?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a button that says \"Edit\" in the top right corner of the file card.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `showEditButton` prop that will be passed down to the `FileCard` component.", "reference": "Questionable way of looping through editors and calling `canEditFile` to show the edit button. Is there a better way?" }, { @@ -20295,7 +20295,7 @@ "reference": "`that is null` doesn't sound very useful to me. Could we rename `that` to `target` or something less context dependent :)?" }, { - "prediction": "I'm not sure what you're trying to do here. Is there a specific reason you want to do this?", + "prediction": "I'm not sure if this is a good idea, but I don't think it's a good idea to call `print` on the `self.molecule` object. It's not a good idea to call `print` on the `self.molecule._print_valid_platforms()` and `self.molecule._print_valid_providers()` methods.", "reference": "Just to be consistent, can we use the print function `print()` instead of the keyword. Same goes for line 437." }, { @@ -20303,7 +20303,7 @@ "reference": "Having to pass in `price` and `limit` is pretty common. Do we want to have this be another argument, maybe a combined structure that can be used for every action that requires it?" }, { - "prediction": "I think we should remove the `src` from the `stop` event.", + "prediction": "I think we should remove the `src` prop from the `stop` event.", "reference": "Could you move it after `stop`?" }, { @@ -20311,63 +20311,63 @@ "reference": "The variable `method` seems not used. Maybe we can remove the parameter `bodyParamName` and generate it by invoking `ParamUtils.generateBodyParameterName(method)` ?" }, { - "prediction": "I think this should be moved to a separate test class.", + "prediction": "I think this should be `private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());` instead of `private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());`", "reference": "I don't think this should be here?" }, { - "prediction": "I'm not sure I understand what you're trying to do with this change. Is it that you want to add a new method to the `SyscallsImpl` interface? Or is it that you want to add a new method to the `SyscallsStateView` interface? Or is it that you want to add a new method to the `SyscallsState` interface? Or is it that you want to add a new method to the `Syscalls` interface? Or is it that you want to add a new method to the `Syscalls` interface? Or is it that you want to add a new method to the `Syscalls` interface? Or is it that you want to add a new method to the `Syscalls` interface? Or is it that you want to add a new method to the `Syscalls` interface? Or is it that you want to add a new method to the `Syscalls` interface? Or is it that you want to add a new method to the `Syscalls` interface? Or is it that you want to add a new method to the `Syscalls` interface? Or is it that you want to add a new method to the `Syscalls` interface? Or is it that you want to add a", + "prediction": "I don't think we need to change this. It's the same as the previous version.", "reference": "Either I'm missing something or specs actors should remove this call cc @anorth" }, { - "prediction": "I think we can remove the `Print` call here, as it's not needed.", + "prediction": "I think we can remove the `new String('-', resultWidth)` line.", "reference": "Please undo all these changes as they are white-space only." }, { - "prediction": "I'm not sure I understand what you're trying to do here.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `CountryField::FORMAT_ISO_3166_ALPHA3 === $countryCodeFormat ? $countryCode : 'UNKNOWN'` check to see if the country code is a valid ISO 3166-1 alpha-3 code.", "reference": "You forgot an optimization? `$countries = CountryField::FORMAT_ISO_3166_ALPHA3 === $countryCodeFormat ? Countries::getAlpha3Names() : $countriesAlpha2;`" }, { - "prediction": "I think this should be `if optdict.get(\"type\", None) == \"py_version\"` instead of `if optdict.get(\"type\", None) == \"py_version\"`.", + "prediction": "I think this should be `value = \"current Python interpreter version (e.g., '3.8')\"` instead of `value = \".\".join(str(item) for item in value)`.", "reference": "Shouldn't this also return the current value specified by the user? At least that's what the docstring says and what the previous version did." }, { - "prediction": "I'm not sure if this is the right place for this, but I think it should be in the `listens` view.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to add a `time_range` parameter to this function. It would allow the user to specify how many days they want to search.", "reference": "> the time range the listen search the time range of the listen search?" }, { - "prediction": "I think this should be `if (ZMM_ENABLED())` instead of `if (ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED() && ZMM_ENABLED", + "prediction": "I think this should be `if (ZMM_ENABLED())` instead of `if (ZMM_ENABLED() && ZMM_ENABLED())`", "reference": "This snprintf, etc. needs to all be inside the DO_ONCE: all this overhead happening on every single decode is likely a huge performance hit." }, { - "prediction": "I'm not sure what you mean by `--conn_retries `. I think you meant `--advertise_retries `.", + "prediction": "I'm not sure what you're trying to do with this option. I think it should be `--conn_retries `.", "reference": "would call it connect_retries" }, { - "prediction": "I think this is not a good idea. We should not use `repr` here. Instead, we should use `str` or `repr` depending on the type of the object.", + "prediction": "I think this is not a good idea, because it will fail on Python 2.7.", "reference": "Why are we using `repr`?" }, { - "prediction": "I think this should be `bind(ZMSImplFactory.getZmsInstance()).to(ZMSHandler.class);` instead of `bind(new ZMSImpl()).to(ZMSHandler.class);`", + "prediction": "I think it's better to use `bind(ZMSHandler.class)` instead of `bind(new ZMSImpl()).to(ZMSHandler.class)`.", "reference": "I use the same zms instance to check authentication in swagger endpoints. Same thing in ZTS." }, { - "prediction": "I think it's a good idea to set this to `false` so that we don't have to rely on the binary file to change user in the test case.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to set `execute.as.user` to `false` so that we don't have to rely on the binary file to change user in the test case. I'm not sure if this is a good idea, but I think it's a good idea to set `execute.as.user` to `false` so that we don't have to rely on the binary file to change user in the test case. I'm not sure if this is a good idea, but I think it's a good idea to set `execute.as.user` to `false` so that we don't have to rely on the binary file to change user in the test case. I'm not sure if this is a good idea, but I think it's a good idea to set `execute.as.user` to `false` so that we don't have to rely on the binary file to change user in the test case. I'm not sure if this is a good idea, but I think it's a good idea to set `execute.as.user` to `false` so that we don't have to rely on the binary file to change user in the test case. I'm not sure if this", "reference": "Consider consolidating the common code in a common setup method in tests?" }, { - "prediction": "I think this should be `PositiveNumber` instead of `PositiveInteger`?", + "prediction": "I don't think this is necessary. The `ImmutableEthProtocolConfiguration` is just a wrapper around the `PositiveNumber` class, so we don't need to create a new class for it.", "reference": "q: do you need to run the annotation processor over EthProtocolConfiguration prior to writing this file? (i.e.to ensure ImmutableEthProtcolConfiguration exists)? Does Auto-import etc. still work in the IDE?" }, { - "prediction": "Shouldn't this be `getNicknameFor` instead of `getFullNameFor`?", + "prediction": "Shouldn't this be `getNicknameFor(DiscoveryField type)` instead of `getNicknameFor(Schema type)`?", "reference": "What is the motivation for switching from `Schema` to `DiscoveryField` everywhere?" }, { - "prediction": "I think we should remove `containerMetadataEnabled` and `dataDirOnHost` as they are not needed.", + "prediction": "I think we can remove the `if len(errs) > 0` check here.", "reference": "What happens when ECS Init/whatever's starting the Agent mounts some other directory as Agent's data directory (`-v /tmp:/data`) sets `ECS_HOST_DATA_DIR` to `\"/var/lib/ecs\"` It doesn't seem like a strong enough abstraction to be dependent on Agent configuration options to expect `ECS_HOST_DATA_DIR` to be the same as whatever's being mounted as `/data` on the host. My main concern is the late-binding/asynchronous failures this could lead to if the wrong host mount was specified. Wondering if there are better alternatives here. Can we at the very least inspect the Agent container and check if `ECS_HOST_DATA_DIR` is mounted? If the answer is that we'll revisit the validation here at some latter stage, that's fine too. But, I want us to be aware of potential failures here." }, { - "prediction": "I'm not sure what you're trying to say here. Is it that `has_xcb_errors` should be `\u2714` and `has_dbus` should be `\u2718`? Or is it that `has_xcb_errors` should be `\u2718` and `has_dbus` should be `\u2714`? I'm not sure what you're trying to say here. Is it that `has_xcb_errors` should be `\u2714` and `has_dbus` should be `\u2718`? Or is it that `has_xcb_errors` should be `\u2718` and `has_dbus` should be `\u2714`? I'm not sure what you're trying to say here. Is it that `has_xcb_errors` should be `\u2714` and `has_dbus` should be `\u2718`? Or is it that `has_xcb_errors` should be `\u2718` and `has_dbus` should be `\u2714`? I'm not sure what you're trying to say here. Is it that `has_xcb_errors` should be `\u2714` and `has_dbus` should be `\u2718`? Or is it that `has_xcb_errors` should be `\u2718` and `has_dbus` should be", + "prediction": "I'm not sure if this is a good place to put this, but I think we should add it to the `eprint_version` function, since it's used in the `eprint_version` function as well.", "reference": "btw that's obviously out of scope of this PR but since i noticed this line here it reminded me a thing: on some systems i've noticed the font didn't had those characters, so it was just a square or empty space and sometimes they're just a bit shifted in position (if font doesn't have them and using from fallback font which have incompatible dimensions of characters) how do you think is it worth creating an issue to discuss/address it or it could just waste time on bikeshedding?" }, { @@ -20375,15 +20375,15 @@ "reference": "alias is not needed" }, { - "prediction": "I'm not sure what you mean by \"redirect stdout and stderr to separate files\". I think you meant to say \"redirect stdout and stderr to the same file\".", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a separate pid file for each process. This way, we don't have to worry about multiple processes trying to use the same pid file, and we don't have to worry about multiple processes trying to write to the same log file.", "reference": "Do we need to include the path?" }, { - "prediction": "I think it's better to use `compactSizeMin` and `compactNumMin` instead of `compactInterval` and `compactSizeMin`/`compactNumMin`.", + "prediction": "`compactNumMin` should be `compactSizeMin * 1024 * 1024` instead of `compactSizeMin * 1024 * 1024 * 1024`", "reference": "During our zoom and working on this, I said that I believe it was set to 64MB, not 32MB, but the diff shows that I was wrong. So we could change it back to 32MB." }, { - "prediction": "Shouldn't this be `Init(string, ...interface{}) error` instead of `Init(string, ...interface{}) error`?", + "prediction": "I think this should be `Init` instead of `InitString`?", "reference": "Here I thought you always insisted on ` log \"github.com/Sirupsen/logrus\" ` :) I might do a PR that just globally switches that out wherever we have log." }, { @@ -20391,11 +20391,11 @@ "reference": "We maintain that each (logical) key generation has the same set of device keys, so no need to plumb through `keyGen`." }, { - "prediction": "I'm not sure why we're using `>=` here. I think we should use `<=` instead.", + "prediction": "I don't think we need to add `mypy>=0.501, <0.502` to `setup.py` as it's already included in `flake8>=3.2.1, <3.4` and `rstcheck>=2.2, <4.0`", "reference": "Please use `from unittest import mock` instead of this package." }, { - "prediction": "I think this should be `this._pipeline` instead of `this._pipelineCollection`.", + "prediction": "I think this should be `this._pipeline` instead of `this._model.collection.aggregate(this._pipeline, this.options || {})`.", "reference": "Should be `if (this.options && this.options.cursor) {`. Options may be undefined. Also, going forward, mongoose will always use curly braces around if blocks." }, { @@ -20407,11 +20407,11 @@ "reference": "Maybe we should have a Debug.Assert for when `Slab != null` to ensure that we are always returning the block (in our tests at least)." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `vnode` object, so that we don't have to do this every time we create a new vnode.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a default value for `props.value` if it's not set.", "reference": "Okay sorry about this I was really confused on how to support uncontrolled in this case, so what we want to do is apply `defaultValue` when `props.value` is falsy but not undefined, right? In the case of us seeing it is controlled (value & onChange present) we apply defaultValue to `props.value` (and delete props.defaultValue) In the case of uncontrolled we shouldn't enter this branch at all and go for full native dom behavior" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in a separate file, so that it can be used in other places as well.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `SearchConsoleDashboardWidget` component.", "reference": "`lodash` shouldn't be grouped under WordPress dependencies" }, { @@ -20419,27 +20419,27 @@ "reference": "The latest yaml in openebs/master has changed to name=admission-webhook. cc: @prateekpandey14" }, { - "prediction": "I'm not sure what you're trying to accomplish with this code. It looks like you're trying to send a message to an SNS topic using the AWS SDK for JavaScript (v3) and the AWS SDK for Ruby (v3). However, I'm not sure what you're trying to accomplish with this code. It looks like you're trying to send a message to an SNS topic using the AWS SDK for JavaScript (v3) and the AWS SDK for Ruby (v3), but I'm not sure what you're trying to accomplish with this code. It looks like you're trying to send a message to an SNS topic using the AWS SDK for JavaScript (v3) and the AWS SDK for Ruby (v3), but I'm not sure what you're trying to accomplish with this code. It looks like you're trying to send a message to an SNS topic using the AWS SDK for JavaScript (v3) and the AWS SDK for Ruby (v3), but I'm not sure what you're trying to accomplish with this code. It looks like you're trying to send a message to an SNS topic using the AWS SDK for JavaScript (v3) and the AWS SDK for Ruby (v3), but I'm not sure what", + "prediction": "I'm not sure what you're trying to accomplish with this code. It looks like you're trying to send a message to an SNS topic using the AWS SDK for JavaScript (v3) and the AWS SDK for Ruby (v3). However, I'm not sure what you're trying to accomplish with this code. Can you please provide more information about what you're trying to accomplish with this code?", "reference": "using **an** Amazon Simple... Simple Notification **Service** (singular)" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check for the size of the result string.", + "prediction": "I think this should be `if (1 || expected != result)` instead of `if (1 || expected != result)`.", "reference": "Probably don't intend for this `1 ||` to still be here" }, { - "prediction": "I'm not sure if this is correct, but I think it should be `VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT_KHR` instead of `VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_VALVE`.", + "prediction": "I'm not sure if this is the right place to add this check, but I think it would be good to add this check in the `vkCreateDescriptorSetLayoutKHR` function as well.", "reference": "Looks like this is failing to compile on Windows (VS 2015 I think)." }, { - "prediction": "I'm not sure I understand what you're trying to do here. Can you please provide some more context?", + "prediction": "I'm not sure I understand what you're trying to do here. Can you give an example of what you're trying to do?", "reference": "nit: call the arg something simple like `f` to avoid repeating \"beforeQuery\"." }, { - "prediction": "I think we can remove the `systemGuestRoleName` from the `correlation.RegisterGlobalHook()`.", + "prediction": "I think this should be `systemGuestRoleName` instead of `system.guest`", "reference": "do you think this should be `osd/auth` as a pkg to make it more unique and void conflicts with other `auth` packages?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.", + "prediction": "I'm not sure what you're trying to do here. I don't think you need to use the `ResXResourceReader` here. You can just use the `Message` property directly.", "reference": "Why are you passing out the Message?" }, { @@ -20447,63 +20447,63 @@ "reference": "Yikes, this was a bug :grimacing:" }, { - "prediction": "I'm not sure if this is a good idea or not, but I think it's better to use `h.Manager.Subscribe` instead of `h.Manager.NewSubscriber` because `h.Manager.Subscribe` returns a channel that will be closed when `h.Manager` is closed. `h.Manager.NewSubscriber` returns a channel that will be closed when `h.Manager` is closed.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `NewSubscriber` method instead of the `New` method. The `NewSubscriber` method is more explicit about what it's doing, and the `New` method is less explicit about what it's doing. I think it's a good idea to use the `NewSubscriber` method instead of the `New` method. The `NewSubscriber` method is more explicit about what it's doing, and the `New` method is less explicit about what it's doing. I think it's a good idea to use the `NewSubscriber` method instead of the `New` method. The `NewSubscriber` method is more explicit about what it's doing, and the `New` method is less explicit about what it's doing. I think it's a good idea to use the `NewSubscriber` method instead of the `New` method. The `NewSubscriber` method is more explicit about what it's doing, and the `New` method is less explicit about what it's doing. I think it's a good idea to use the `NewSubscriber` method instead of the `New` method. The `NewSubscriber` method", "reference": "I am not sure which one of these is considered idiomatic go... maybe @azdagron has an opinion here? /me prefers the verb since it's shorter. I guess I don't care _too_ much, but it would be good to get some general agreement so we are all following the same conventions" }, { - "prediction": "I don't think it's necessary to call `exec.Command(\"open\", tmpFilePath).Run()` in this case. We can just use `exec.Command(\"sequelpro\", tmpFilePath).Run()`.", + "prediction": "I don't think it's necessary to call `exec.Command(\"open\", tmpFilePath).Run()` in this case.", "reference": "Please check this for error and emit appropriate debugging information. I know this was pre-existing code, but we just have to fix things like this as we go." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate function for this. It's", + "prediction": "I think we can remove the `nil` check here.", "reference": "This seems unrelated, should be a separate PR." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea to include the `mt2203_batch_impl.h` header file in the `algorithms/engines/mt2203/mt2203.h` header file.", + "prediction": "I don't think we need to include this. It's not used anywhere in the code.", "reference": "Never use relative includes, prefer full path" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to have `count=False` and `zero_count=True` at the same time. I think it's better to have `count=False` and `zero_count=False` instead.", + "prediction": "I'm not sure what you mean by \"Zero_count Argument cannot exist without count!\"", "reference": "This should fit on the line above without going over the 79-char limit, no?" }, { - "prediction": "I'm not sure what you mean by \"stubs\" in this context. I'm not sure what you mean by \"stubs\" in this context. I'm not sure what you mean by \"stubs\" in this context. I'm not sure what you mean by \"stubs\" in this context. I'm not sure what you mean by \"stubs\" in this context. I'm not sure what you mean by \"stubs\" in this context. I'm not sure what you mean by \"stubs\" in this context. I'm not sure what you mean by \"stubs\" in this context. I'm not sure what you mean by \"stubs\" in this context. I'm not sure what you mean by \"stubs\" in this context. I'm not sure what you mean by \"stubs\" in this context. I'm not sure what you mean by \"stubs\" in this context. I'm not sure what you mean by \"stubs\" in this context. I'm not sure what you mean by \"stubs\" in this context. I'm not sure what you mean by \"stubs\" in this context. I'm not sure what you mean by \"stubs\" in this context.", + "prediction": "I'm not sure if this is the right way to do this, but I think we should be able to stub the `signed_in?` method in the controller, so we don't need to stub the `current_user_with` method in the test.", "reference": "Is this related to the other contents of this pull request?" }, { - "prediction": "I'm not sure what you mean by `AutoscalingOpts` and `AutoscalingExtraParams`", + "prediction": "I think we should remove the `AddonsExtraParams` field.", "reference": "Should this be `*string`?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don", + "prediction": "I'm not sure if this is a good idea, but I think we should have a default profile that allows all ingress and egress, in the absence of any Policy.", "reference": "In the old code here there was no Source Selector, but CreateDefaultProfile will specify a Source Selector of `\"\"`. Is that equivalent?" }, { - "prediction": "I think we should remove the `caller(0)[2]` here.", + "prediction": "I think this should be `caller(0)[2]` instead of `caller.find { |line| line !~ %r{/lib/rspec/(core|mocks|expectations|matchers|rails)/} }`", "reference": "We should pick this across for all our deprecation specs" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it would be a good idea to move this to the `kind` package.", + "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good idea to move this into the `kind` package.", "reference": "Longer term, I think it could be valuable to move this to cluster-api, and then other repos could take advantage of this as well." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a comment here explaining why we're doing this.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `externalClient.EnsureBinary(\"test-connection\")` to ensure that the binary is available before we try to connect to it. I'm not sure if this is the best way to do this, but I think it's a good idea to use the `externalClient.EnsureBinary(\"test-connection\")` to ensure that the binary is available before we try to connect to it. I'm not sure if this is the best way to do this, but I think it's a good idea to use the `externalClient.EnsureBinary(\"test-connection\")` to ensure that the binary is available before we try to connect to it. I'm not sure if this is the best way to do this, but I think it's a good idea to use the `externalClient.EnsureBinary(\"test-connection\")` to ensure that the binary is available before we try to connect to it. I'm not sure if this is the best way to do this, but I think it's a good idea to use the `externalClient.EnsureBinary(\"test-connection\")` to ensure that the binary is available before we try to", "reference": "Is this a related change?" }, { - "prediction": "I think it's better to use `scope.MachineStatus.InstanceState = &instanceDescription.State` instead of `scope.MachineStatus.State = &instanceDescription.State`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to make sure that the state of the load balancer is in sync with the state of the machine.", "reference": "Given that this is repeated, can we do it outside here and the Create call, what do you think about moving it outside?" }, { - "prediction": "I think we can remove `changesLen > 1 ? this.getSelected() : [[changes[0][0], changes[0][1]]]` and just use `changes[0][0]` and `changes[0][1]` instead.", + "prediction": "I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place", "reference": "Changing `prop`=>`col` by reference? I think you can prepare map `prop`=>`col` in L51." }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it's a good idea to add it to the `--bfbs-builtin-attrs` option as well.", + "prediction": "I don't think this is a good name for this option. I would suggest `--bfbs-builtin-attrs` or `--bfbs-builtin-attrs=1` instead of `--bfbs-builtin-attrs 1`.", "reference": "I hate to ask, but can we make this flag shorter so it lines up? :(" }, { - "prediction": "I don't think we need to use `unstructured.Unstructured` in this case. We can just use `apiextensions.Unstructured` instead.", + "prediction": "I don't think we need to use `unstructured.Unstructured` here. We can use `apiextensions.Unstructured` instead.", "reference": "Note to reviewers: latent, dedup import" }, { @@ -20511,7 +20511,7 @@ "reference": "Seems this func is no more needed after your refactoring." }, { - "prediction": "I think we can remove the `Tuple.of(\"^io\\\\.usethesource\", \"Steindorfer persistent @ \")` line.", + "prediction": "I think we can remove the `@` from the `io.usethesource` and `io.usethesource` from `io.usethesource`", "reference": "already added (see several rows below)" }, { @@ -20519,39 +20519,39 @@ "reference": "nit: a switch perhaps?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `common.FailureReasonSizeExceedsLimit` constant.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.", "reference": "Great you caught this. Super critical to not retry these errors." }, { - "prediction": "I'm not sure what you mean by \"nuking setting odd instance paths\". I'm not sure what you mean by \"nuking setting odd instance paths\". I'm not sure what you mean by \"nuking setting odd instance paths\". I'm not sure what you mean by \"nuking setting odd instance paths\". I'm not sure what you mean by \"nuking setting odd instance paths\". I'm not sure what you mean by \"nuking setting odd instance paths\". I'm not sure what you mean by \"nuking setting odd instance paths\". I'm not sure what you mean by \"nuking setting odd instance paths\". I'm not sure what you mean by \"nuking setting odd instance paths\". I'm not sure what you mean by \"nuking setting odd instance paths\". I'm not sure what you mean by \"nuking setting odd instance paths\". I'm not sure what you mean by \"nuking setting odd instance paths\". I'm not sure what you mean by \"nuking setting odd instance paths\". I'm not sure what you mean by \"nuking setting odd instance paths\". I'm not sure what you mean by \"nuking setting odd instance paths\". I", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to remove the `instanceDir` parameter from the `CoreAdminOperation` interface. The `instanceDir` parameter is only used by the `CoreContainer` class, which is not part of the `CoreAdminOperation` interface. It would be better to remove it from the `CoreAdminOperation` interface and add it to the `CoreContainer` class.", "reference": "Just a little change to make the var effectively final, which is clearer." }, { - "prediction": "I think it's better to use `human.format_address` instead of `human.format_address(sc.ip_address)`", + "prediction": "I think it's better to use `human.format_address` instead of `human.format_address(sc.ip_address)`.", "reference": "Using `\"{}\".format(...)` is a bit beside the point..." }, { - "prediction": "I'm not sure what you mean by \"coucou\" in this case.", + "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `json.dumps` instead of `json.loads` in this case.", "reference": "I think these should remain as they are." }, { - "prediction": "I think this should be `EtcHostsPath` instead of `EtcHostsPath_SOLARIS`.", + "prediction": "I think we should remove the `@@additional_pkgs = []` line.", "reference": "Let's just call this PERF_PACKAGES and have them in the same format as WINDOWS/SLES/DEBIAN_PACKAGES constants - since it is only a single package and, as written, you'd have to update the code to add more package names anyway. Might as well be consistent with the rest of the code." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `getDeviceIndex_from_TaskIndex` function.", + "prediction": "I think this should be `if (validDeviceIndex(DeviceIndex))` instead of `if (validTaskIndex(TaskIndex))`", "reference": "We don't have a `getPluginIDfromTaskIndex` function? I think it should be implemented in Globals/Plugins.h / .cpp" }, { - "prediction": "I think it's better to use `CommonParams.FL` instead of `rb.req.getSchema().getUniqueKeyField().getName()`.", + "prediction": "I think this should be `sreq.params.set(CommonParams.FL, rb.req.getSchema().getUniqueKeyField().getName());` instead of `sreq.params.set(CommonParams.FL, rb.req.getSchema().getUniqueKeyField().getName()); rb.req.getSchema().getUniqueKeyField().getName();`", "reference": "@shalinmangar If lazy field loading isn't enabled, I don't think this actually changes the behavior of `SolrIndexSearcher`, since it was previously ignoring the fields list anyway. What it _should_ do is allow certain distributed queries, like the ones in `DistribJoinFromCollectionTest`, to co-exist with `SolrIndexSearcher#doc()` respecting the `fields` set instead of just discarding it." }, { - "prediction": "I'm not sure what you mean by `DDEV_SITENAME` in the template. I think it should be `DDEV_SITENAME` instead.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `DDEV_SITENAME` variable in the `DDEV_SITENAME` variable in the `DDEV_SITENAME` variable in the `DDEV_SITENAME` variable in the `DDEV_SITENAME` variable in the `DDEV_SITENAME` variable in the `DDEV_SITENAME` variable in the `DDEV_SITENAME` variable in the `DDEV_SITENAME` variable in the `DDEV_SITENAME` variable in the `DDEV_SITENAME` variable in the `DDEV_SITENAME` variable in the `DDEV_SITENAME` variable in the `DDEV_SITENAME` variable in the `DDEV_SITENAME` variable in the `DDEV_SITENAME` variable in the `DDEV_SITENAME` variable in the `DDEV_SITENAME` variable in the `DDEV_SITENAME` variable in the `DDEV_SITENAME` variable in the `DDEV_SITENAME` variable in the `DDEV_SITENAME` variable in the `DDEV_SITENAME` variable in the `", "reference": "Should we be using version 3 now?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `findLockFiles()` method to get the lock files.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure the config file is valid before trying to load it.", "reference": "Would be better to throw a more specific exception, but for now it will do." }, { @@ -20559,35 +20559,35 @@ "reference": "We should not replace Wei with a type that is shared across multiple units. We need this as `Wei` for type and unit safety." }, { - "prediction": "I think this should be `os.IsNotExist(err)` instead of `os.IsNotExist(err)`.", + "prediction": "I think this should be `if os.IsNotExist(err)` instead of `if os.IsNotExist(err)`.", "reference": "I'm pretty sure this should emit a util.Warning*(), since we're skipping by here and never hitting anything that will give them a warning about what's happened." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to load the built-in rules first, so that we don't have to load them again when we need to use them later.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `GetParserWithBuiltins` function to load the builtins.", "reference": "This function isn't useful? it's just a clone of GetParserWithBuiltins?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `validateCircuitBreakerThresholds` method to the `SolrConfig` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think we should move it to the `SolrConfig` class, since it's not part of the `SolrConfig` class itself.", "reference": "I'm not sure if the boolean flags should always contain `is`, also I generally hate too long names... ;) we already know this is a section for circuit breakers, so the name doesn't have to repeat all of it. How about `cpuBreakerEnabled`, `memoryBreakerEnabled` etc?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. You want to add a rewrite that replaces one set of deletes with another that contains the same deleted rows.", + "prediction": "I'm not sure what you mean by \"cannot be null or empty\"", "reference": "Before we start the replacing equality deletes with position deletes, I think we need to refactor the RewriteFiles API to adjust more cases: 1. Rewrite data files and remove all the delete rows. The files to delete will be a set of data files and a set of delete files, and the files to add will be a set of data files. 2. Replace equality deletes with position deletes, the files to delete will be a set of equality delete files (we will need to ensure that all delete files are equality delete files ? ) , the files to add will be a set of position delete files. 3. Merging small delete files into a bigger delete files. The files to delete will be a set of equality/position delete files, the files to add will be a set of equality/position delete files." }, { - "prediction": "I'm not sure what you mean by \"it's important that we don't use ActionView::Helpers::CacheHelper#cache here\". I'm not sure what you mean by \"it's important that we don't use ActionView::Helpers::CacheHelper#cache here\". I'm not sure what you mean by \"it's important that we don't use ActionView::Helpers::CacheHelper#cache here\". I'm not sure what you mean by \"it's important that we don't use ActionView::Helpers::CacheHelper#cache here\". I'm not sure what you mean by \"it's important that we don't use ActionView::Helpers::CacheHelper#cache here\". I'm not sure what you mean by \"it's important that we don't use ActionView::Helpers::CacheHelper#cache here\". I'm not sure what you mean by \"it's important that we don't use ActionView::Helpers::CacheHelper#cache here\". I'm not sure what you mean by \"it's important that we don't use ActionView::Helpers::CacheHelper#cache here\". I'm not sure what you mean by \"it's important that we don't use ActionView::Helpers::CacheHelper#cache here\". I'm not sure", + "prediction": "I'm not sure I understand what you're trying to do here. You're trying to get the name of the application from an i18n string, but you're not using ActionView::Helpers::CacheHelper#cache here. I'm not sure what you're trying to do here. You're trying to get the name of the application from an i18n string, but you're not using ActionView::Helpers::CacheHelper#cache here. I'm not sure what you're trying to do here. You're trying to get the name of the application from an i18n string, but you're not using ActionView::Helpers::CacheHelper#cache here. I'm not sure what you're trying to do here. You're trying to get the name of the application from an i18n string, but you're not using ActionView::Helpers::CacheHelper#cache here. I'm not sure what you're trying to do here. You're trying to get the name of the application from an i18n string, but you're not using ActionView::Helpers::CacheHelper#cache here. I'm not sure what you're trying to do here. You're trying to get the name of the application from an", "reference": "Layout/TrailingWhitespace: Trailing whitespace detected." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `LibraryManager` class, so that it can be used by other parts of the application.", + "prediction": "I don't think we need to do this.", "reference": "Is it possible that the shortcuts list is empty?" }, { - "prediction": "I think we can remove the `if err != nil` here, since it's already checked by `errors.Cause(err) == context.Canceled`", + "prediction": "I think this should be `if err != nil { return errors.Fatal(\"unable to save snapshot: %v\", err); }`", "reference": "This just changes the error message from `unable to save snapshot: [...] context canceled` to `canceled`." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right way to do it.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.", "reference": "maybe it's better to remove HttpHeaders.CONTENT_LENGTH after the loop" }, { @@ -20599,15 +20599,15 @@ "reference": "Is this the same copy of the rules file from above? If so, can just use the copy from above, and this can be dropped." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate handler for the ENI attach message.", + "prediction": "I don't think we need to do this.", "reference": "Please break this into multiple lines." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `SpanContextPropagator.cs` file.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add this to `SpanContextPropagator.cs` as well. I think it would be a good idea to add this to `SpanContextPropagator.cs` as well. I think it would be a good idea to add this to `SpanContextPropagator.cs` as well. I think it would be a good idea to add this to `SpanContextPropagator.cs` as well. I think it would be a good idea to add this to `SpanContextPropagator.cs` as well. I think it would be a good idea to add this to `SpanContextPropagator.cs` as well. I think it would be a good idea to add this to `SpanContextPropagator.cs` as well. I think it would be a good idea to add this to `SpanContextPropagator.cs` as well. I think it would be a good idea to add this to `SpanContextPropagator.cs` as well. I think it would be a good idea to add this to `SpanContextPropagator.cs` as well. I think it would be a good idea to add this", "reference": "Shouldn't this new line replace the few lines above?" }, { - "prediction": "I think this should be `universe.SystemTime()` instead of `transformations.SystemTime()`.", + "prediction": "I think this should be `transformations.UniverseSystemTime()` instead of `universe.SystemTime()`.", "reference": "Perhaps this belongs in universe?" }, { @@ -20615,27 +20615,27 @@ "reference": "there is a `kEpsilon` you can use directly." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add a comment to explain what it does.", + "prediction": "I don't think we need to add `awserrors` to this package. We already have `awserrors` in `cloud/awserrors` package.", "reference": "This should be grouped with the below imports, and the two separate groups of imports below should likely also be grouped together" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `DescriptorSet` class, since it's the only place where the `VkDescriptorSetLayout` can be destroyed.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check to see if the descriptor set is destroyed before trying to call `vkUpdateDescriptorSets()`. If the descriptor set is destroyed, we can't call `vkUpdateDescriptorSets()`, and we can't call `vkDestroyDescriptorSetLayout()`.", "reference": "It looks like this error_code field is used to return a string to the caller, not just a const input string to be consumed as in the rest of this PR? If so, my personal preference would be to leave it as a std::string* instead of a reference; I don't know offhand what the VL coding style dictates." }, { - "prediction": "I think we can remove the `static` keyword here, as it's not used anywhere else in the code.", + "prediction": "I don't think we need to use `static` here. We can just use `const` here.", "reference": "If return by value, then why bother to make it `static`?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `version` function that takes a `win_id` and returns a `QUrl` to the version page. This way, we don't have to call `openurl` every time we want to see the version page.", + "prediction": "I think this should be `tabbed_browser.openurl(QUrl('qute://version'), newtab=True)` instead of `tabbed_browser.openurl(QUrl('qute://version'), newtab=True)`", "reference": "You'll need to add docs for the argument, see e.g. the `debug_log_filter` docstring above." }, { - "prediction": "I don't think we need to use `semconv` here. We can just use `sem` instead.", + "prediction": "`sdktrace` and `tracesdk` should be in the same package.", "reference": "`sdktrace` or `tracesdk`, pick one." }, { - "prediction": "I'm not sure what you're trying to do with this, but I think it's a bit of a red herring. It's not clear to me what you're trying to do with this.", + "prediction": "I'm not sure what you're trying to do here. I don't think we need to do anything here.", "reference": "can we return null instead?" }, { @@ -20643,67 +20643,67 @@ "reference": "You mean XXX and \"we should\" or \"NYI\" or sthg. Maybe put it on the ifdef line." }, { - "prediction": "I think we can remove the `map[string][]int64` from the `SingleImageImportLoggable` struct.", + "prediction": "I think it's better to use `map[string][]int64` for `int64s` instead of `map[string][]int64` for `sourceSizeGb` and `targetSizeGb`.", "reference": "minor: can be in-lined in return" }, { - "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to include the message in the deprecation stream, but you're not actually doing anything with it. I think you meant to do something like this: `deprecation_stream << \"this message\\n\"`.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to include the message in the deprecation stream. I think it's a good idea to include the message in the deprecation stream. I think it's a good idea to include the message in the deprecation stream. I think it's a good idea to include the message in the deprecation stream. I think it's a good idea to include the message in the deprecation stream. I think it's a good idea to include the message in the deprecation stream. I think it's a good idea to include the message in the deprecation stream. I think it's a good idea to include the message in the deprecation stream. I think it's a good idea to include the message in the deprecation stream. I think it's a good idea to include the message in the deprecation stream. I think it's a good idea to include the message in the deprecation stream. I think it's a good idea to include the message in the deprecation stream. I think it's a good idea to include the message in the deprecation stream. I think it's a good idea to include the message in the deprecation stream. I think it's a good", "reference": "why the additional \"\\n\"?" }, { - "prediction": "I think this should be `if err != nil { ... }` instead of `if err := f(s.first); err != nil { ... }`", + "prediction": "I think this should be `if err := f(s.first); err != nil { ... }` instead of `if err := f(s.first); err != nil { ... }`", "reference": "This seems to be a big omission. If the first buffer reports an error, stream seems to just discard it." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `blockListeners` variable in the `MakeFull` function. This way, we don't need to create a new `ledger.BlockListener` for each `node` in the `MakeFull` function.", + "prediction": "I don't think we need to change the `blockListeners` array here. The `node` block listener is already added to the `blockListeners` array, so we don't need to add it again.", "reference": "Maybe move this one down too?" }, { - "prediction": "I'm not sure what you're trying to do with this, but I think it's a bad idea.", + "prediction": "I think we can remove the `_log` reference here, as it's not used anywhere in this class.", "reference": "We do this in lots of places I'm starting to notice...typically you'd avoid taking concrete dependencies, but we also avoid package dependencies as well which makes sense (i.e. not using an IoC, etc.). Any reason we don't implement some form of poor-man's DI and/or a simple factory instead of new-ing things up everywhere. This may be a simple example (as I'm guessing this is likely the only place this is ever or ever will be used), but separating them doesn't take any more time/effort either really." }, { - "prediction": "I'm not sure what you mean by `newErr` here. It's not clear to me what you're trying to do with it.", + "prediction": "I don't think this is needed.", "reference": "What if formatPrefix doesn't include a space? Will the resulting error have e.Error() stuck at the end without any space?" }, { - "prediction": "I'm not sure what you mean by \"use of this source code is governed by a BSD-style license that can be found in the LICENSE file.\"", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. The pushsync protocol is designed to be used by the client, not the server. If you want to use the pushsync protocol with the server, you need to implement the pushsync protocol yourself.", "reference": "that doesn't say a lot to me. Can you please be more specific on the function of pushsync?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this check to the pipeline creation function.", + "prediction": "I'm not sure if this is the right place to add this check, but I think it's a good idea.", "reference": "> subpass uses a depth/stencil attachment in renderPass with a read-only layout for the depth aspect Assume - VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_STENCIL_ATTACHMENT_OPTIMAL - VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_OPTIMAL count as well seems there is a `NormalizeDepthImageLayout` for this" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason you want to use `WIDGET_AREA_STYLES.BOXES` instead of `WIDGET_AREA_STYLES.COMPOSITE`? I'm not sure I understand what you're trying to do here. Is there a reason you want to use `WIDGET_AREA_STYLES.BOXES` instead of `WIDGET_AREA_STYLES.COMPOSITE`? I'm not sure I understand what you're trying to do here. Is there a reason you want to use `WIDGET_AREA_STYLES.BOXES` instead of `WIDGET_AREA_STYLES.COMPOSITE`? I'm not sure I understand what you're trying to do here. Is there a reason you want to use `WIDGET_AREA_STYLES.BOXES` instead of `WIDGET_AREA_STYLES.COMPOSITE`? I'm not sure I understand what you're trying to do here. Is there a reason you want to use `WIDGET_AREA_STYLES.BOXES` instead of `WIDGET_AREA_STYLES.COMPOSITE`? I'm not sure I understand what you're trying to do here. Is there a reason you want to use `WIDGET_AREA_STYLES.BOXES` instead of `W", + "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to add a new widget to the dashboard, but I'm not sure what you're trying to do with it.", "reference": "This shouldn't be altered, you probably meant to update `AREA_PAGE_DASHBOARD_ALL_TRAFFIC` further below :)" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `docker_client.py` as well.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `dict` instead of `list` for the `docker_path` keys.", "reference": "what does this change do exactly?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason why you want to wrap the network into an agreement.Network? If so, please provide more context.", + "prediction": "I'm not sure what you mean by `net` in this context. I think you meant `network` instead.", "reference": "What's the purpose of this `backgroundCtx` field?" }, { - "prediction": "I'm not sure what you mean by \"account data\" in this context. Could you please provide some more context?", + "prediction": "I think this should be 1024 instead of 1024 * 1024.", "reference": "non contract incarnation" }, { - "prediction": "I think this should be `except TypeError` instead of `except TypeError:`.", + "prediction": "I think we can remove the `except TypeError` check here.", "reference": "I would recommend to leave out `None` because None is already the default." }, { - "prediction": "I'm not sure what you mean by \"disconnecting from peer: %s\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `processHelloMessage` function.", "reference": "Should the \"bad hello message\" case above also disconnect?" }, { - "prediction": "I think this should be `public static boolean fragmentEnabled = false;` and `public static boolean fragmentVisible = false;` instead of `protected static boolean fragmentEnabled = false;` and `protected static boolean fragmentVisible = false;`.", + "prediction": "I'm not sure what you mean by \"fragmentEnabled\" and \"fragmentVisible\". Could you please clarify?", "reference": "Shouldn't this be in the child and not in the base plugin? Wouldn't having it here enable all derived plugins at once?" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a `--example-matches STRING` option to the parser, so that we don't have to use `Regexp.escape` every time we want to run an example.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `--example-matches` option.", "reference": "Should probably say REGEX or PATTERN rather than string." }, { @@ -20711,7 +20711,7 @@ "reference": "I felt we don't need to set it that strict, like if somehow pubsub happens to allow extra 20 bytes for metadata, this test won't work. We would suggest to use 11MB instead." }, { - "prediction": "I'm not sure what you mean by \"allow to autocomplete multiple values for OneToMany and ManyToMany associations\"", + "prediction": "I'm not sure I understand what you're trying to do here. Can you explain?", "reference": "In theory `isset($metadata['associationType'])` is `false` if the linked field is not an association field, isn't?" }, { @@ -20719,31 +20719,31 @@ "reference": "@tute the only thing I needed to enable this like as `password` is not in default flow anymore I think." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you mean by \"allAuthenticatedUsers\" in this case. I'm not sure what you mean by \"allAuthenticatedUsers\" in this case. I'm not sure what you mean by \"allAuthenticatedUsers\" in this case. I'm not sure what you mean by \"allAuthenticatedUsers\" in this case. I'm not sure what you mean by \"allAuthenticatedUsers\" in this case. I'm not sure what you mean by \"allAuthenticatedUsers\" in this case. I'm not sure what you mean by \"allAuthenticatedUsers\" in this case. I'm not sure what you mean by \"allAuthenticatedUsers\" in this case. I'm not sure what you mean by \"allAuthenticatedUsers\" in this case. I'm not sure what you mean by \"allAuthenticatedUsers\" in this case. I'm not sure what you mean by \"allAuthenticatedUsers\" in this case. I'm not sure what you mean by \"allAuthenticatedUsers\" in this case. I'm not sure what you mean by \"allAuthenticatedUsers\" in this case. I'm not sure what you mean by \"allAuthenticatedUsers\" in this case. I'm not sure what you mean by \"allAuthenticatedUsers\" in this case. I", "reference": "nit: to be consistent with `self.members`, please move this up one line, so that it's closer to `allUsers`? You will need to update your test reference." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a `--verbose` flag to the `runGClient` function. This way, if you run `runGClient` with `--verbose`, it will print out more information about what it's doing.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `--verbose` flag for the `runGClient` function. This way, if you run `runGClient` with `--verbose`, you'll get verbose output about what's going on.", "reference": "we might as well just access `config.gClientVerbose` directly here. If any other options are passed to `gclientSync` or `gclientRunhooks` then the verbose option will be lost the way it's used now" }, { - "prediction": "I don't think it's necessary to have `log_events` and `log_requests` in the `log` section. I think it's better to have `log` and `log_events` in the `log` section.", + "prediction": "I don't think it's necessary to add `logging` to the menu description. It's already there.", "reference": "Change the key to `default_tab` instead and I'll merge this" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a helper method.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `templates` method.", "reference": "we still can end up passing a blank org_id to the scope method if for any reason the params is not present..." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check to see if the value is a String, and if it is a String, then we want to use the toString() method to convert it to a StringValue.", + "prediction": "I think this should be `if (value == null)` instead of `if (value == null)`.", "reference": "I think yes, this makes sense to expose this. +1" }, { - "prediction": "I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this,", + "prediction": "I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if this is the best way to do this, but it", "reference": "let us put the sample yaml snippet i.e. maya api server deployment that makes use of this env & value" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to test that messages are distributed across multiple threads. I'm not sure what you're trying to do here, but it looks like you're trying to test that messages are distributed across multiple threads. I'm not sure what you're trying to do here, but it looks like you're trying to test that messages are distributed across multiple threads. I'm not sure what you're trying to do here, but it looks like you're trying to test that messages are distributed across multiple threads. I'm not sure what you're trying to do here, but it looks like you're trying to test that messages are distributed across multiple threads. I'm not sure what you're trying to do here, but it looks like you're trying to test that messages are distributed across multiple threads. I'm not sure what you're trying to do here, but it looks like you're trying to test that messages are distributed across multiple threads. I'm not sure what you're trying to do here, but it looks like you're trying to test that messages are distributed across multiple threads. I'm not sure what you're trying to do here, but it looks like you're trying to test that messages are", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this.", "reference": "What changed to cause this?" }, { @@ -20751,7 +20751,7 @@ "reference": "Repeating big interface in many places shows smtg is wrong with design" }, { - "prediction": "I think this should be `render json: Chart.new(@account).commits_by_project` instead of `render json: Chart.new(@account).commits_by_language(params[:scope])`", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to move this to `charts#commits_by_project` and `charts#commits_by_language` instead of `charts#commits_history` and `charts#commits_by_project` and `charts#commits_by_language` because `charts#commits_by_project` and `charts#commits_by_language` will be called by `charts#commits_history` and `charts#commits_by_project` and `charts#commits_by_language` will be called by `charts#commits_history` and `charts#commits_by_project` and `charts#commits_by_language` will be called by `charts#commits_history` and `charts#commits_by_project` and `charts#commits_by_language` will be called by `charts#commits_history` and `charts#commits_by_project` and `charts#commits_by_language` will be called by `charts#commits_history` and `charts#commits_by_project` and `charts#commits_by_language` will be called by `charts#commits_history` and `charts#commits_by_project` and `charts", "reference": "Inheriting from `AccountsController` to get access to the `redirect_if_disabled` filter." }, { @@ -20759,19 +20759,19 @@ "reference": "Simple Storage **Service**" }, { - "prediction": "I think this should be `return 1;` instead of `return 0;`", + "prediction": "I think this should be `public static void B.FUNC3(Class arg)` instead of `public static void B.FUNC3(Class arg) { return; }`", "reference": "Enter at the end of the file! :-D (and at the end of lines ;-) )" }, { - "prediction": "I think this should be `scheduled_for_deactivation_on` instead of `scheduled_for_cancellation_on`?", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be better to do this in a separate migration.", "reference": "Put a comma after the last parameter of a multiline method call." }, { - "prediction": "I think this should be `for _, succ := range newRoot.Successors() {` instead of `for _, succ := range newRoot.Successors() { if succ == root { continue } }`", + "prediction": "I think we can remove the `if succ == root { continue }` line.", "reference": "Don't you want to place this check before you add `succ` to `newSucc`?" }, { - "prediction": "I don't think this is needed anymore.", + "prediction": "I don't think this is a good idea. The `EnumMap` is not thread-safe, so you need to use `HashMap` instead. Also, the `Future` is not thread-safe, so you need to use `Callable` instead.", "reference": "Commit 676eeeab10884456a5f70ce708a8aa5116ecbaf7 contains a lot of unrelated code style changes. Please get rid of these." }, { @@ -20779,31 +20779,31 @@ "reference": "Well this sucks, I wish you'd mentioned you were using a private API, perhaps we could have made a public one with better guarantees before `0.12.6` was released." }, { - "prediction": "I think we can remove the `&pendingHeap` here.", + "prediction": "I think we can remove the `&pendingHeap` here, since it's not used anywhere.", "reference": "Consider instead moving this into an _test file so it's public but only usable in tests." }, { - "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to log the actual state of the volumes after each iteration of the loop. This way, we can see if the state transition was successful or not, and if it was successful, we can log the actual state of the volumes. This way, we can also see if the state transition was successful or not, and if it was successful, we can log the actual state of the volumes. This way, we can also see if the state transition was successful or not, and if it was successful, we can log the actual state of the volumes. This way, we can also see if the state transition was successful or not, and if it was successful, we can log the actual state of the volumes. This way, we can also see if the state transition was successful or not, and if it was successful, we can log the actual state of the volumes. This way, we can also see if the state transition was successful or not, and if it was successful, we can log the actual state of the volumes. This way, we can also see if the state transition was successful or not, and if it was successful, we can log the actual state", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to log the actual state of the volumes after each iteration of the loop. This way we can see if the state transition was successful or not, and if it was successful, we can log the actual state of the volumes.", "reference": "Any reason why we want to remove this code ? It helps debugging AWS ebs attach issues. Ideally yes a library should have minimal logging, but there is no way we can track long running AWS attach calls." }, { - "prediction": "I'm not sure what you mean by `tstzrange` here. Is it something like `tstzrange(start, end, '[]')` or something else?", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `tstzrange` for the `scheduled_end_time` and `execution_time` fields.", "reference": "nit: indentation doesn't match (unfortunately i don't know of a way to automatically lint these sql statements with how we're using them currently)" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to call `setup_profiler` in the `setup` block, but it's not being called there. It's being called in the `setup_default` block, so I'm not sure what you're trying to do here. I think you're trying to call `setup_profiler` in the `setup` block, but it's not being called there. It's being called in the `setup_default` block, so I'm not sure what you're trying to do here. I think you're trying to call `setup_profiler` in the `setup` block, but it's not being called there. It's being called in the `setup_default` block, so I'm not sure what you're trying to do here. I think you're trying to call `setup_profiler` in the `setup` block, but it's not being called there. It's being called in the `setup_default` block, so I'm not sure what you're trying to do here. I think you're trying to call `setup_profiler` in the `setup` block, but it's not being called there. It's being called in the `setup_default", + "prediction": "I think we can remove the `setup_profiler` call here, since it's only called once per test.", "reference": "Should we remove the other `setup_profiler` call site and just let this be the one call site for it, since, AFAIK, the other one is no longer necessary with this? Also, can we make `setup_profiler` private?" }, { - "prediction": "I think we should remove the `GlobalOpts` as it's not needed anymore.", + "prediction": "I'm not sure if this is a good idea, but I think we should remove the `GlobalOpts: NewGlobalOpts()`.", "reference": "Are there any other templates where this command needs to be added, or were those issues specific to storage requiring us to enable a new command group?" }, { - "prediction": "I think this should be `if config != nil {` instead of `if config != nil { return errors.New(\"cannot patch and load seccomp filter without runc seccomp support\") }`", + "prediction": "I think this should be `if config != nil { return errors.New(\"cannot patch and load seccomp filter without runc seccomp support\") }`", "reference": "perhaps file can be removed altogether (trying to avoid an empty package for these build tags)" }, { - "prediction": "I'm not sure what you mean by \"be careful\" here. I'm not sure what you mean by \"be careful\" here. I'm not sure what you mean by \"be careful\" here. I'm not sure what you mean by \"be careful\" here. I'm not sure what you mean by \"be careful\" here. I'm not sure what you mean by \"be careful\" here. I'm not sure what you mean by \"be careful\" here. I'm not sure what you mean by \"be careful\" here. I'm not sure what you mean by \"be careful\" here. I'm not sure what you mean by \"be careful\" here. I'm not sure what you mean by \"be careful\" here. I'm not sure what you mean by \"be careful\" here. I'm not sure what you mean by \"be careful\" here. I'm not sure what you mean by \"be careful\" here. I'm not sure what you mean by \"be careful\" here. I'm not sure what you mean by \"be careful\" here. I'm not sure what you mean by \"be careful\" here. I'm not sure what you mean by \"be careful\" here. I'm not sure", + "prediction": "I'm not sure what you mean by \"be careful\" here. I'm not sure if it's safe to assume that `get_ldr_module_64` will return `NULL` if it can't find the module. I'm not sure if it's safe to assume that `get_ldr_module_64` will return `NULL` if it can't find the module. I'm not sure if it's safe to assume that `get_ldr_module_64` will return `NULL` if it can't find the module. I'm not sure if it's safe to assume that `get_ldr_module_64` will return `NULL` if it can't find the module. I'm not sure if it's safe to assume that `get_ldr_module_64` will return `NULL` if it can't find the module. I'm not sure if it's safe to assume that `get_ldr_module_64` will return `NULL` if it can't find the module. I'm not sure if it's safe to assume that `get_ldr_module_64` will return `NULL` if it can't find the module. I'm not sure if it's safe to assume that", "reference": "NULL change, could you move that out too?" }, { @@ -20811,19 +20811,19 @@ "reference": "A brief explanation about this func is required." }, { - "prediction": "I'm not sure what you're trying to do with this, but I'm not sure if this is the right place to do it.", + "prediction": "I'm not sure if this is the right place to add this warning, but I think it would be good to add it to the `MergedCellsCollection` class.", "reference": "Could you add description for below static function?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think we need to change anything here.", + "prediction": "I'm not sure what you mean by \"we already got the first block in the previous step.\" Could you please clarify?", "reference": "Since this is only counting the failed attempts, can you call it failedAttemptsCount or retryCount instead of attemptsCount?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bit of a red herring. It's not clear what you're trying to achieve with this change, but I think it's a bit of a red herring. It's not clear what you're trying to achieve with this change, but I think it's a bit of a red herring. It's not clear what you're trying to achieve with this change, but I think it's a bit of a red herring. It's not clear what you're trying to achieve with this change, but I think it's a bit of a red herring. It's not clear what you're trying to achieve with this change, but I think it's a bit of a red herring. It's not clear what you're trying to achieve with this change, but I think it's a bit of a red herring. It's not clear what you're trying to achieve with this change, but I think it's a bit of a red herring. It's not clear what you're trying to achieve with this change, but I think it's a bit of a red herring. It's not clear what you're trying to achieve with this change", + "prediction": "I think we can remove the `os` import here, since it's not used anywhere.", "reference": "I don't think this will work." }, { - "prediction": "I'm not sure what you mean by \"ParseHeaders\" and \"ParseRequestLine\"", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `HttpParser.cs` file.", "reference": "Since http2 is coming do we want to call this something more specific?" }, { @@ -20831,15 +20831,15 @@ "reference": "I don't think we want to revert the accessibility issues the tool caught, do we?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `RequestTracker` struct.", "reference": "I prefer naming this rateLimitedRemoteHost This can be local host but reads remote Host Is Non Local." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `type._lastDomChild !== undefined && type._lastDomChild !== null` to make sure we don't try to use `type._lastDomChild` if it's `null` or `undefined`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `type._lastDomChild !== undefined && type._lastDomChild !== null` and `type._lastDomChild !== undefined && type._lastDomChild !== null && type._lastDomChild !== null && type._lastDomChild !== null && type._lastDomChild !== null && type._lastDomChild !== null && type._lastDomChild !== null && type._lastDomChild !== null && type._lastDomChild !== null && type._lastDomChild !== null && type._lastDomChild !== null && type._lastDomChild !== null && type._lastDomChild !== null && type._lastDomChild !== null && type._lastDomChild !== null && type._lastDomChild !== null && type._lastDomChild !== null && type._lastDomChild !== null && type._lastDomChild !== null && type._lastDomChild !== null && type._lastDomChild !== null && type._lastDomChild !== null && type._lastDomChild !== null && type._lastDomChild !== null && type._lastDomChild !== null && type._lastDomChild !== null && type._last", "reference": "Hmm I think I might've messed up this condition here... Need to look more at it" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to pass in a `dict` to `package_stats`, but it's not a `dict`. I think you meant to pass in a `list` of `dict`s, but I'm not sure what you're trying to do with that.", + "prediction": "I'm not sure if this is a good idea, but I think we should make sure that `package_stats` is a `dict` and not a `NoneType`.", "reference": "This also makes the exception to be raised on non-dict falsy values which I think was expected." }, { @@ -20847,27 +20847,27 @@ "reference": "Is this correct? The auto indexing behavior caused problems fixed in a recently merged PR..." }, { - "prediction": "`twine>=1.6.5, <1.9` is not compatible with `twine>=1.6.5, <1.10`", + "prediction": "I don't think `twine>=1.6.5, <1.10` is a good enough version for `pysftp==0.2.8`.", "reference": "Hmm, didn't we just find out that 1.6 *does NOT* work? We should bump the minimum as well." }, { - "prediction": "I'm not sure this is the right place to do this.", + "prediction": "Shouldn't this be `assert` instead of `release_assert_internal`?", "reference": "Will calling `abort()` cause problems for our test suite?" }, { - "prediction": "I think this should be `if(!expr_object(options, astp))` instead of `if(!expr_object(options, ast))`", + "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a separate function for `expr_object` and `expr_lambdas` instead of duplicating the code here.", "reference": "for my own edificaton, what's this?" }, { - "prediction": "I think this should be `if ws != nil {` instead of `if ws != nil {`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the current working set is the same as the one being committed. If it is, we can just return without doing anything. If it is not, we need to update the current working set to match the one being committed.", "reference": "make it harmless to commit ws == nil" }, { - "prediction": "I'm not sure if this is the best way to do this, but it seems to work for me.", + "prediction": "I'm not sure I understand what you're trying to do here. I think you want something like this: `\\$\\(dir (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w+), (\\w", "reference": "Hmmmm, I'm not sure I like these becoming a replacement any build rule has access to. It seems like if it were used in an actual build rule it would only be doing bad things. Can we just use `filepath.Abs` on the returned path in run_step.go?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to make this a part of the yarpc package, so that it can be used by other packages as well.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it", "reference": "That's actually not as bad as I thought it was going to be." }, { @@ -20875,15 +20875,15 @@ "reference": "Hmm, I'm surprised if we don't already have a \"find all unpublished datasets\" method but I don't really know. Maybe @scolapasta knows." }, { - "prediction": "I'm not sure if this is the right place to add this, but I think it would be a good idea to add it to the list of things that should be fixed in Python 3. I'm not sure if this is the right place to add it to the list of things that should be fixed in Python 3. I'm not sure if this is the right place to add it to the list of things that should be fixed in Python 3. I'm not sure if this is the right place to add it to the list of things that should be fixed in Python 3.", + "prediction": "I'm not sure if this is the right place to add this, but I think it would be good to add it to the list of things to check for Python 3.", "reference": "The checks in this file are disabled by default since they are meant for Python 3 porting, and this one does not have to do with Python 3 porting at all." }, { - "prediction": "I think this should be `MinResponseDataRate` instead of `MinDataRate`.", + "prediction": "I think this should be `MinDataRate` instead of `MinDataRateInBytes/Second`.", "reference": "I would change \"should be sent\" to \"must be received\"." }, { - "prediction": "I think we should remove the `+` sign here. It's not necessary.", + "prediction": "I think we should remove the `+` sign here.", "reference": "Please put it in following way : `// DeleteStoragePool receives StoragePoolClaim delete event and calls the required handlers to delete other pool related resources.`" }, { @@ -20891,19 +20891,19 @@ "reference": "It's better to use servicecomb now." }, { - "prediction": "I don't think you need to change anything here.", + "prediction": "I don't think we need to change the `defaultRenewBeforeExpiryDuration` here.", "reference": "Make the flag derived default available in the readiness controller" }, { - "prediction": "I'm not sure I understand what you're trying to do with this test case. It seems like you're trying to test the `syncset pause` annotation, but it's not clear to me what you're trying to achieve with this test case. Could you please provide more details on what you're trying to achieve with this test case?", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in `syncset_test.go` instead of `sync_test.go` because `syncset_test.go` is a separate file.", "reference": "Confirmed this test fails when the fix is reverted" }, { - "prediction": "I don't think we need to check for empty filepath here.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to check for the existence of the file before trying to create the archive.", "reference": "This method is still possible insecure as it may archive not only logs files. I suggest to filter file names to ensure that they start with `.mysterium-log*`." }, { - "prediction": "I don't think this is a good idea. It's not clear to me why we would want to do this.", + "prediction": "I don't think it's necessary to add `self.conv_offset.weight.data.zero_()` here. It should be `self.conv_offset.weight.data.zero_()` and `self.conv_offset.bias.data.zero_()`.", "reference": "DCN should not be able to use `init_cfg`." }, { @@ -20911,75 +20911,75 @@ "reference": "It is a bit weird to see a message like \"something must be valid\"." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to set the `loggingOptions` in the `standalone` class. This way, we don't have to do this in the `CliCommand` class.", + "prediction": "I think it's better to use `log.info(\"Using tracer: \" + tracer);` instead of `LOG.finest(\"Using tracer: \" + tracer);`", "reference": "Again. This is part of the start up of the server, and the diagnostics are helpful." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this. I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this. I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this. I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this. I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this. I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this. I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this. I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this. I'm not sure if this is the", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate test for this. I think it would be a good idea to have a separate test for the `--no-manual` option as well, but I'm not sure if this is the right place to do this.", "reference": "I think you need a `,` at the end of the line?" }, { - "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here. Is it possible that you're trying to create a `DbEntityOperation` from a `DbOperation`? If so, you should be able to use the `DbEntityOperation` constructor to create a `DbEntityOperation` from a `DbOperation`.", + "prediction": "I don't think this is a good idea. We should be able to create a new operation with the same name as the existing one, but with a different state.", "reference": "Please avoid wildcard imports." }, { - "prediction": "I think we can remove the `client.Timeout = TimeSpan.FromMinutes(5);` as it's not needed.", + "prediction": "I think this should be `client.Timeout = TimeSpan.FromMinutes(5);` instead of `client.Timeout = TimeSpan.FromMinutes(100);`", "reference": "Did we consider making the timeout an argument to the build task? Would amke it easer to configure in the future: change a build property vs. rebuilding the DLL." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the `nodeIP` is set before we try to create the `egressController` and `egressInformer` so that we don't try to create an `egressController` that doesn't have an `egressInformer`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check here to make sure that the IP address is valid.", "reference": "dumb question: the commit message talks about dual-stack support but it seems that in a dual-stack cluster, Egress will only support the IPv4 address family?" }, { - "prediction": "I think this should be `self.tls[server].set_tlsext_host_name(server.sni)` instead of `self.tls[server].set_tlsext_host_name(server.sni.encode(\"idna\"))`", + "prediction": "I think this should be `self.tls[server].set_tlsext_host_name(server.sni.encode(\"idna\"))` instead of `self.tls[server].set_tlsext_host_name(server.sni.encode(\"idna\"))`", "reference": "Do you want to cherry-pick these separately and get them merged already or keep it in here? Both is fine with me!" }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to achieve with this test.", + "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a separate test for `suggest` performance.", "reference": "Hmm what are these magical constant numbers? And why does this change mean they should increase?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason you want to change the version number?", + "prediction": "I'm not sure why we're using `__version__` instead of `__version__ = '2.8.0-dev'`", "reference": "This change shouldn't be included with this push. Shouldn't push version changes with a pull-request." }, { - "prediction": "I'm not sure what you mean by \"black-hole requests on resource exhausted errors\"", + "prediction": "I'm not sure what you mean by \"black-hole requests on resource exhausted errors\". I think it's more accurate to say that the client will not receive an error, but will instead receive a response with a status code of 503 (Service Unavailable) or 502 (Bad Gateway) or 504 (Gateway Timeout) or 500 (Internal Server Error) or 503 (Service Unavailable) or 502 (Bad Gateway) or 504 (Gateway Timeout) or 500 (Internal Server Error) or 503 (Service Unavailable) or 502 (Bad Gateway) or 504 (Gateway Timeout) or 500 (Internal Server Error) or 503 (Service Unavailable) or 502 (Bad Gateway) or 504 (Gateway Timeout) or 500 (Internal Server Error) or 503 (Service Unavailable) or 502 (Bad Gateway) or 504 (Gateway Timeout) or 500 (Internal Server Error) or 503 (Service Unavailable) or 502 (Bad Gateway) or 5", "reference": "nit: let's move this right under where we create the `responseWriter`, before `h.callHandler`" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `upgrade_v14_to_v15` function, since it's called by `upgrade_v14_to_v15` and `upgrade_v14_to_v15` is called by `upgrade_v14_to_v15` and `upgrade_v14_to_v15` is called by `upgrade_v14_to_v15` and `upgrade_v14_to_v15` is called by `upgrade_v14_to_v15` and `upgrade_v14_to_v15` is called by `upgrade_v14_to_v15` and `upgrade_v14_to_v15` is called by `upgrade_v14_to_v15` and `upgrade_v14_to_v15` is called by `upgrade_v14_to_v15` and `upgrade_v14_to_v15` is called by `upgrade_v14_to_v15` and `upgrade_v14_to_v15` is called by `upgrade_v14_to_v15` and `upgrade_v14_to_v1", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `upgrade_v14_to_v15` function, since it's called by the `upgrade_v14_to_v15` function in `upgrade_v14_to_v15.cpp` and `upgrade_v14_to_v15.h`.", "reference": "The way it was implemented, needed to pass the template values. Please check whether we want this." }, { - "prediction": "I'm not sure what you mean by \"advertise and allow filecoin network traffic to be relayed through this node\"", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to `daemonCmd.Run` so that we don't have to call `daemonRun` every time we want to run the daemon.", "reference": "Just FYI we need this to align with `builtin.EpochDurationSeconds` from specs-actors or the state machine computations will be off. We'll need to turn this into a config option and follow the same monkey patching paths as the min miner size, seal proof types etc. The EpochDurationSeconds is currently a `const` so can't do it yet tho." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right way to do it.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `__future__.print_function()` instead of `print_function()`.", "reference": "Is this import needed?" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you want to use `provideSiteInfo` here. I think you want to use `provideSiteInfo` in the `WithTestRegistry` component.", + "prediction": "I'm not sure what you mean by \"URL Search Widget\". It's not a widget, it's a component.", "reference": "Dashboard stories also need to have the default padding." }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good place to put this in the `RewriteDataFiles` class.", + "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good place to put it in the `RewriteDataFiles` class.", "reference": "Is there a reason why we wouldn't use this as the default?" }, { - "prediction": "I think this is a race condition, we should address it in the future.", + "prediction": "I think this is a race condition. I think we should use `LockUtils::tagLock()` instead of `LockUtils::edgeLock()`.", "reference": "if there is an tag of the same name?" }, { - "prediction": "I don't think this is necessary. We can just use `exec.Command` instead of `exec.Cmd`.", + "prediction": "I don't think this is necessary. We can just use `exec.LookPath` to get the path to the executable.", "reference": "I'd add `// +build go1.10` to prevent from accidentally compiling with older Go." }, { - "prediction": "I'm not sure what you mean by `unique_iterator` in this context. It's not clear to me what you're trying to do with it.", + "prediction": "I think this should be `get_overlay_spec` instead of `get_overlay_spec`", "reference": "Not sure how this import relates to the PR but seems like a good idea anyway..." }, { - "prediction": "I don't think this is needed. The `ResetFactoryDefaultPreference` is only used in the constructor, so it's not needed here.", + "prediction": "I don't think this is needed. The `ResetFactoryDefaultPreference` is only used in the constructor, so it shouldn't be included in the `SettingsStruct_tmpl` class.", "reference": "Hmm this is strange, why should the SettingsStruct import something from `WebServer` ? If that's really needed, then we must move stuff as it makes no sense to have some code related to viewing things included in a settings struct. It should be the other way around." }, { @@ -20995,39 +20995,39 @@ "reference": "I don't understand why this function is needed ? Can't you just pass the information when the `DocComparator` is created in the SortField ?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `MailChimpJob` class, so that it can be used in other jobs as well.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `MailChimpJob` class, so that it can be used by other jobs as well.", "reference": "This rescue is repeated exactly in `app/jobs/mailchimp_removal_job.rb`. Could we extract a method and pull it up into `MailChimpJob` for reuse?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that `options.headers` is not `undefined` before calling `xhr.getResponseHeader('content-type')` and `xhr.getResponseHeader('content-type')` is not `undefined` before calling `xhr.getResponseHeader('content-type')` and `xhr.getResponseHeader('content-type')` is not `undefined` before calling `xhr.getResponseHeader('content-type')` and `xhr.getResponseHeader('content-type')` is not `undefined` before calling `xhr.getResponseHeader('content-type')` and `xhr.getResponseHeader('content-type')` is not `undefined` before calling `xhr.getResponseHeader('content-type')` and `xhr.getResponseHeader('content-type')` is not `undefined` before calling `xhr.getResponseHeader('content-type')` and `xhr.getResponseHeader('content-type')` is not `undefined` before calling `xhr.getResponseHeader('content-type')` and `xhr.getResponseHeader('content-type')` is not `undefined` before calling `xhr.getResponseHeader('content-type')` and `xhr.getResponseHeader('content-type')` is not `undefined` before calling `xhr.getResponseHeader('content-type')` and `", + "prediction": "I don't think this is necessary. We can just use `xhr.response` here.", "reference": "It's not directly related to this PR, but it would be nice to flow the original error as we're going to print that if the promise is rejected and it'll be more informative than the vague `Network request failed`. Also, I'm not a js dev, so maybe I'm wrong, but throwing a TypeError feels a bit odd." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to check if the Xwayland binary is available before trying to exec it.", + "prediction": "I'm not sure if this is the best place to do this, but I think it's a good idea to check for `Xwayland` before calling `execvp`.", "reference": "Can we print a debug message when this is used? Since it's a debugging variable, I wouldn't want users to have issues because of a left-over env." }, { - "prediction": "I think it's better to use `require('raw-loader!design-system-react/components/pill/__examples__/base.jsx')` instead of `require('raw-loader!design-system-react/components/pill/__examples__/base.jsx')`", + "prediction": "I think it's better to use `require('raw-loader!design-system-react/components/pill/__examples__/base.jsx')` instead of `require('raw-loader!design-system-react/components/pill/__examples__/base.jsx')!design-system-react/components/pill/__examples__/base.jsx`", "reference": "Should we have an avatar, truncate, etc examples, too?" }, { - "prediction": "I think this should be `strides` instead of `strides = unsupported_property('strides', deprecated=True)`.", + "prediction": "I think this should be `unsupported_property('strides', deprecated=True)` instead of `unsupported_property('strides')`", "reference": "could you add this to `docs/source/reference/indexing.rst` ?" }, { - "prediction": "I think this should be `from rdkit.VLib.Node import VLibNode` instead of `from rdkit import six`", + "prediction": "I think this should be `from rdkit.VLib.Node import FilterNode` instead of `from rdkit import six`", "reference": "Why the change from rdkit.six to six?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `renderView` function.", + "prediction": "I'm not sure if this is the best place to do this, but I think it's a good idea to do this in the `renderView` function.", "reference": "Looking good, let's just move this inside the `if` to avoid doing the extra work if we don't need it." }, { - "prediction": "I'm not sure what you mean by \"create new batch to execute\"", + "prediction": "I don't think this is the right place to do this. I think it should be in the `Bulk` test.", "reference": "I think we should change this to an instanceOf check for MongoBatchReExecutionError" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a separate `converter` field in the `ProfileDecoder` struct. This way, we can have a separate `converter` field in the `ProfileDecoder` struct, and we can have a separate `converter` field in the `ProfileDecoder` struct, and we can have a separate `converter` field in the `ProfileDecoder` struct, and we can have a separate `converter` field in the `ProfileDecoder` struct, and we can have a separate `converter` field in the `ProfileDecoder` struct, and we can have a separate `converter` field in the `ProfileDecoder` struct, and we can have a separate `converter` field in the `ProfileDecoder` struct, and we can have a separate `converter` field in the `ProfileDecoder` struct, and we can have a separate `converter` field in the `ProfileDecoder` struct, and we can have a separate `converter` field in the `ProfileDecoder` struct, and we can have a separate `converter` field in the `ProfileDecoder` struct, and we can have a separate `converter` field in the `ProfileDecoder` struct, and we can", + "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a separate `ProfileDecoder` struct that implements the `conversion.Converter` interface. This way, we can have a single `conversion.Converter` that can be used by both the `ProfileDecoder` and the `Dispatcher`.", "reference": "Required by the libcalico-go changes" }, { @@ -21035,7 +21035,7 @@ "reference": "Explain why we don't reuse the corresponding server error locally?" }, { - "prediction": "I'm not sure what you mean by \"even though MyData currently screens any deaccessioned info out\"", + "prediction": "I'm not sure if this is the right place to add the date_to_display_on_card attribute, but I think it's a good idea to do so.", "reference": "@JayanthyChengan This change is still missing (and should be last one!): change this line to call getDateToDisplayOnCard(), that way the logic is in only one place (that method)." }, { @@ -21043,27 +21043,27 @@ "reference": "What was wrong with more concrete error?" }, { - "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "prediction": "I'm not sure if this is needed, but I think it's a good idea to check if the page slug exists before adding it to the body class.", "reference": "can you replace the tabs with 2 spaces please to match the rest of the project?" }, { - "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to create a `IntegralOpSpec` with a `TimeSrc` and `TimeDst` field, but I'm not sure what you're trying to do with those fields.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `AggregateConfig` struct.", "reference": "Why are we adding it to the integral function?" }, { - "prediction": "I think this should be `msg.ReplayWindow = uint8(state.ReplayWindow)` instead of `msg.ReplayWindow = uint32(state.ReplayWindow)`", + "prediction": "I think this should be `nl.Swap32(uint32(state.Spi))` instead of `nl.Swap32(uint32(state.Spi))`", "reference": "Same for this file" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a method to the `FileAppender` class that does this.", + "prediction": "I don't think this is necessary. We can just use `GetFileCharacteristics` and `GetLastWriteTime` directly.", "reference": "Looks good! But why it's still a out parameter? We can refactor the whole tree because it's internal?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to call `wlr_seat_keyboard_notify_enter` on the view before calling `seat->has_focus = true`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `wlr_seat_keyboard_notify_enter` callback.", "reference": "probably better to use `wlr_seat_keyboard_end_grab()`." }, { - "prediction": "I'm not sure what you mean by \"unprotected transactions allowed\". I think you meant to say \"unprotected transactions are not allowed\".", + "prediction": "I'm not sure what you mean by \"unprotected transactions allowed\"", "reference": "Such a large test impact for such a little 3 line change ;)" }, { @@ -21071,27 +21071,27 @@ "reference": "Is the `cascade` necessary? It should work also without the casdade, because Payments are always already persisted when use cases with them. If it doesn't work, please tell me the reason. It is as same in Transport." }, { - "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea to add it to the list of non-invariant property types. I'm not sure if this is the right place to add it to the list of non-invariant property types. I'm not sure if this is the right place to add it to the list of non-invariant property types. I'm not sure if this is the right place to add it to the list of non-invariant property types. I'm not sure if this is the right place to add it to the list of non-invariant property types. I'm not sure if this is the right place to add it to the list of non-invariant property types. I'm not sure if this is the right place to add it to the list of non-invariant property types. I'm not sure if this is the right place to add it to the list of non-invariant property types. I'm not sure if this is the right place to add it to the list of non-invariant property types. I'm not sure if this is the right place to add it to the list of non-invariant property types. I'm not sure if this is the right place to add it to", + "prediction": "Shouldn't this be `235159` instead of `235158`?", "reference": "This is not very short. I'm not sure sure if there's a system for assigning shortcodes to issues." }, { - "prediction": "I'm not sure what this annotation is for, but I think it should be `certmanager.k8s.io/edit-in-place` instead of `certmanager.k8s.io/edit-in-placeAnnotation`.", + "prediction": "I'm not sure what this annotation is for, but it looks like it could be used to override the issuer specified on the created Certificate resource. I'm not sure if that's a good idea or not.", "reference": "We should probably prefix this with `acme-http01` to bring it in-line with other annotations, e.g. `certmanager.k8s.io/acme-http01-edit-in-place`. It's quite wordy, but it *is* more specific (and I'd hope more obvious to the user what it is for?)" }, { - "prediction": "I'm not sure what you mean by \"getCommonPluginLoadProps()\". It's not a method of `JobTypeManager`, it's a property of `JobTypeManager`.", + "prediction": "I'm not sure if this is the best place to put this, but I think it would be good to have this in the `JobTypeManager` class, so that it can be used in other places as well.", "reference": "No need to add this file change for this PR. Please remove it." }, { - "prediction": "I'm not sure what you're trying to achieve with this rule. It's not clear to me what you're trying to achieve with this rule. It's not clear to me what you're trying to achieve with this rule. It's not clear to me what you're trying to achieve with this rule. It's not clear to me what you're trying to achieve with this rule. It's not clear to me what you're trying to achieve with this rule. It's not clear to me what you're trying to achieve with this rule. It's not clear to me what you're trying to achieve with this rule. It's not clear to me what you're trying to achieve with this rule. It's not clear to me what you're trying to achieve with this rule. It's not clear to me what you're trying to achieve with this rule. It's not clear to me what you're trying to achieve with this rule. It's not clear to me what you're trying to achieve with this rule. It's not clear to me what you're trying to achieve with this rule. It's not clear to me what you're trying to achieve with this rule. It's not clear to me what you're trying to achieve with this rule. It's", + "prediction": "I don't think we need to change this.", "reference": "this extra dot at the end is causing a couple tests to fail on Travis" }, { - "prediction": "This is a bit of a hack, but I think it's a good idea. It's a bit of a hack, but I think it's a good idea. It's a bit of a hack, but I think it's a good idea. It's a bit of a hack, but I think it's a good idea. It's a bit of a hack, but I think it's a good idea. It's a bit of a hack, but I think it's a good idea. It's a bit of a hack, but I think it's a good idea. It's a bit of a hack, but I think it's a good idea. It's a bit of a hack, but I think it's a good idea. It's a bit of a hack, but I think it's a good idea. It's a bit of a hack, but I think it's a good idea. It's a bit of a hack, but I think it's a good idea. It's a bit of a hack, but I think it's a good idea. It's a bit of a hack, but I think it's a good idea. It's a bit of a hack, but I think it's a good idea. It", + "prediction": "This is a bit of a hack, but I don't think it's a big deal.", "reference": "Did you try using `global` with a regular integer ?" }, { - "prediction": "I think this should be `static_assert(sizeof(extractor::NodeBasedEdge) == 20, ...` instead of `static_assert(sizeof(extractor::NodeBasedEdge) == 24, ...`", + "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to change the type of `extractor::NodeBasedEdge` and `extractor::EdgeBasedEdge` to `extractor::EdgeBasedEdge` and `extractor::EdgeBasedEdge` respectively.", "reference": "windows size might be off" }, { @@ -21099,19 +21099,19 @@ "reference": "This should still be guarded with an `#ifdef` since the DataMan code will only be supported for shared lib builds." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `@hash[:funder]` section.", + "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to put it in the `@hash` object so that it can be used in other parts of the template. I'm not sure if this is the right place to put this, but I think it would be good to put it in the `@hash` object so that it can be used in other parts of the template. I'm not sure if this is the right place to put this, but I think it would be good to put it in the `@hash` object so that it can be used in other parts of the template. I'm not sure if this is the right place to put this, but I think it would be good to put it in the `@hash` object so that it can be used in other parts of the template. I'm not sure if this is the right place to put this, but I think it would be good to put it in the `@hash` object so that it can be used in other parts of the template. I'm not sure if this is the right place to put this, but I think it would be good to put it in the `@hash` object so that it can be", "reference": "thanks for cleaning up these old length checks" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `manifests` field in the `Executor` struct. This way, we don't need to pass the `manifests` field to the `applyManifests` function, and we don't need to pass the `manifests` field to the `addBuiltinAnnontations` function.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to log the namespace here as well.", "reference": "What will be logged when the `Input.Namespace` was not specified?" }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it would be a good idea to make it a public static class, so that it can be used by JCommander.", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be a good idea to make it a public static class as well, so that it can be used by other classes that need to use it.", "reference": "I wouldn't expose this until the feature is ready. We are most likely to cut releases while still in development" }, { - "prediction": "I'm not sure what you mean by `require('emoji-regex')` and `require('aria-query')`. I think you meant to use `require('emoji-regex-text')` and `require('aria-query-text')`.", + "prediction": "`require('emoji-regex')` should be `require('emoji-regex-text')`", "reference": "I don't think we should pull aria-query into axe-core at this point. There's a much simpler fix for this. Please don't overthink it." }, { @@ -21119,7 +21119,7 @@ "reference": "@ejsmith What if instead of making these two methods public we made it a partial class and moved them to a separate file so that file could be part of the include list? I bring it up just because I don't think it is a very nice API that was ever intended to be public? I think they are only called by a couple of other very internal-y spots. /cc @reyang" }, { - "prediction": "I'm not sure if this is the best way to do this, but it seems to work for me.", + "prediction": "I think this should be `actions.add(killAct);` instead of `actions.add(killAct);`", "reference": "would be good to turn these into constants." }, { @@ -21127,7 +21127,7 @@ "reference": "Seems like it should be `generated by Wire` here and in the SUT?" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `false` as the second argument to `c.ProposeDeal`.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `TestStorageProtocolBasic` test.", "reference": "I know the main cases show up in the daemon test already but a little bit more unit test coverage would be nice and probably not too annoying to set up. Ideas: 1. Verify that the string \"no duplicates\" is in the LastDuplicate field when we propose a new deal. 2. Verify that proposing a duplicate deal fails when the duplicates boolean is set false. 3. Start out in a state with more than 1 duplicates. Verify that the LastDuplicate field is set to the last duplicate when we propose with a true duplicates bool." }, { @@ -21135,15 +21135,15 @@ "reference": "`Timeout.Infinite` is actually `-1`. Here the correct message can be taken from Line:67." }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. Is it that you want to use the `Extensions` namespace? If so, why not just use `using NLog.Extensions;`? If not, why not just use `using NLog.Common;`?", + "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. Is it that you want to use the `Extensions` namespace? If so, why not just use `using NLog.Extensions;` instead of `using NLog.Common;`? If not, I'm not sure what you're trying to do here.", "reference": "I think we need `#if !SILVERLIGHT` here and at the test." }, { - "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to have it in a separate file, so that it can be used in other places as well.", + "prediction": "I don't think this is needed anymore.", "reference": "Can you change this import to the apache dependency? I didn't even know that jgit contains such a method..." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `GenerateServiceAccountName` function to generate the service account name, and then use that name in the `MakeServiceAccount` function.", + "prediction": "I don't think we need to use `GenerateServiceAccountName` here. We can just use `gServiceAccount` and `clusterName` directly.", "reference": "Four strings in a row makes me nervous, can we use an arguments struct instead? Or reuse the struct I recommend in the reconciler." }, { @@ -21151,7 +21151,7 @@ "reference": "should work with no options, if my suggestion is accepted. JSON is the one that gets weird since a JSON object appended to a JSON object isn't valid JSON." }, { - "prediction": "I'm not sure what you mean by \"indeterminate file size\"", + "prediction": "I'm not sure what you mean by \"check streaming\" here. I think you meant to say \"check uploadxs\".", "reference": "I presume this isn't some special term..." }, { @@ -21163,75 +21163,75 @@ "reference": "Why are we calling these as annotations? I guess this is an old type that we are re-using. But lets make it a point to avoid once we feel that this design/code is not good." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.", + "prediction": "I think this should be `Future future = new RestClientSender(invocation).send();`", "reference": "`invocation.getInvocationStageTrace().startSend()` is inside `RestClientSender.send`" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `validate` function.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good place to do this. I think we want to make sure that the gas price is lower than the min gas price, and if it's not, we want to reject the action.", "reference": "use \"actionHash\" to be consistent with other places" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason you want to do this? If so, please provide more context.", + "prediction": "I'm not sure I understand what you're trying to do here. What is the purpose of the `BasicPropertyDescriptorFactory`?", "reference": "Can we derive `Class` by looking at one of the label choices, if at least one is always provided? Given these are immutable, a real-world case for an empty enumerations eludes me." }, { - "prediction": "I'm not sure if this is the right place to add this test, but I think it should be.", + "prediction": "I'm not sure if this is the right place to add this test, but I think it's important to have a test that verifies that `vk::CreateSamplerYcbcrConversion` returns a valid `VkSamplerYcbcrConversion` object.", "reference": "I am now confused here, the spec says > If format is VK_FORMAT_UNDEFINED, all members of samplerYcbcrConversionComponents must be the identity swizzle. The spec also says > samplerYcbcrConversionComponents is the component swizzle that **should** be used in VkSamplerYcbcrConversionCreateInfo. so you are allowed to set the swizzle to anything I want, so I guess this is valid usage here... but now I am more curious if I have an external format does it not have to follow any component swizzle rules and can be anything regardless of the `ycbcrModel`? (I guess really a question for @critsec and is not a blocking concern for the scope of this PR)" }, { - "prediction": "I think this should be `if app.SiteStatus() != platform.SiteRunning { ... }` instead of `if app.SiteStatus() != \"running\" { ... }`", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `app.SiteStatus()` method to check if the app is running locally.", "reference": "I'd say the error should be an error, not instructions to the user. So error would be something like \"site should be running and is not\"" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to mock the `SNSBackend.get()` method, but I don't think that's what you're trying to do here.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this.", "reference": "Thanks for this PR @pinzon ! Rather than resetting the `sms_messages` list, can we fix the assertion in line 902 - rather than asserting `len` equality, we should assert that all expected messages are contained in the list. (In this case the phone numbers should be reasonably random, and ideally we should not have duplicates across different tests). We're planning to introduce test parallelization in the near future, and this will help us avoiding undesired side-effects. Thanks" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to use the `time` package for time-related stuff.", + "prediction": "`stats_dto` should be `stats` instead of `stats_dto`", "reference": "Some weird blocks formation again." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a machine set with 3 replicas, but you're not actually creating a machine set with 3 replicas. You're creating a machine set with 3 replicas, but you're not actually creating a machine set with 3 replicas.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `map[string]int64` syntax for the `expectedMachineSetReplicas` field.", "reference": "This is worrisome." }, { - "prediction": "I think we should remove the `request` argument from the `FilesystemTrimStop` method.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `api` package, since it's not related to the `api` package at all.", "reference": "nit try rephrasing to something like \" AutoFilesystemTrimUsage returns the volume usage and trimmable space of locally mounted pxd volumes\"" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to set `puppetbindir` to `/opt/puppetlabs/agent/bin` and `puppetconfdir` to `/etc/puppetlabs/agent/config`. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set `puppetbindir` to `/opt/puppetlabs/agent/bin` and `puppetconfdir` to `/etc/puppetlabs/agent/config`. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set `puppetbindir` to `/opt/puppetlabs/agent/bin` and `puppetconfdir` to `/etc/puppetlabs/agent/config`. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set `puppetbindir` to `/opt/puppetlabs/agent/bin` and `puppetconfdir` to `/etc/puppetlabs/agent/config`. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set `puppetbindir` to `/opt/puppetlabs/agent", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `puppetserver` section of the `puppet.conf` file.", "reference": "currently the puppet-agent package doesn't symlink files into /opt/puppetlabs/bin. Also many puppet acceptance tests that execute on Unix assume puppetbindir is a single directory (windows doesn't have this issue). So I think if we want to unblock testing, this should just be changed to `h['puppetbindir'] = '/opt/puppetlabs/puppet/bin`" }, { - "prediction": "I'm not sure what you're trying to do with this, but it looks like you're trying to use `Ember.computed.alias` to alias a computed property of the `pouchDBService.configDB` object. I'm not sure what you're trying to do with this, but it looks like you're trying to use `Ember.computed.alias` to alias a computed property of the `pouchDBService.configDB` object. I'm not sure what you're trying to do with this, but it looks like you're trying to use `Ember.computed.alias` to alias a computed property of the `pouchDBService.configDB` object. I'm not sure what you're trying to do with this, but it looks like you're trying to use `Ember.computed.alias` to alias a computed property of the `pouchDBService.configDB` object. I'm not sure what you're trying to do with this, but it looks like you're trying to use `Ember.computed.alias` to alias a computed property of the `pouchDBService.configDB` object. I'm not sure what you're trying to do with this, but it looks like you're trying to use `Ember.com", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a `configDB` property in the adapter, so that it can be used by other adapters as well.", "reference": "any point in keeping this here ?" }, { - "prediction": "I don't think we need to check for `CaseSensitive` here, since it's already checked in the `Merge` function.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `CaseSensitive` and `CaseInsensitive` instead of `CaseSensitive` and `CaseInsensitive` respectively. This is because `CaseSensitive` and `CaseInsensitive` are mutually exclusive. If you use `CaseSensitive` and `CaseInsensitive`, then you can't use `CaseSensitive` and `CaseInsensitive` at the same time. If you use `CaseSensitive` and `CaseInsensitive`, then you can't use `CaseSensitive` and `CaseInsensitive` at the same time.", "reference": "I don't think we need this check. Instead `Entries.merge` should check that its argument is correctly sorted (in addition to the existing pre/post check on the method receiver)." }, { - "prediction": "I think this should be `#include \"engine/routing_algorithms/routing_base_ch.hpp\"` instead of `#include \"engine/routing_algorithms/routing_base_offline.hpp\"`.", + "prediction": "I think this should be `#include \"routing/routing_base_ch.hpp\"` instead of `#include \"engine/routing_algorithms/routing_base_ch.hpp\"`.", "reference": "This is not really good to mix different code bases. @TheMarex I understand the point about placing code into cpp file, but we still need to move templated version into an impl header, remove references to offline code here and keep template instantiations in a cpp file to avoid rebuild. So offline code could instantiate own implementations using private impl headers. Otherwise we again make wrong dependencies into OSRM code and block changes in separate projects." }, { - "prediction": "I'm not sure what you mean by \"change already removed from history\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the `onParticipantDiscovery` callback, so that we don't have to do this in the `onNewCacheChangeAdded` callback. I'm not sure if this is the right place to do this, but I think it would be good to have this in the `onParticipantDiscovery` callback, so that we don't have to do this in the `onNewCacheChangeAdded` callback. I'm not sure if this is the right place to do this, but I think it would be good to have this in the `onParticipantDiscovery` callback, so that we don't have to do this in the `onNewCacheChangeAdded` callback. I'm not sure if this is the right place to do this, but I think it would be good to have this in the `onParticipantDiscovery` callback, so that we don't have to do this in the `onNewCacheChangeAdded` callback. I'm not sure if this is the right place to do this, but I think it would be good to have this in the `onParticipantDiscovery` callback, so that we don't have to do this in the", "reference": "Then, where is it removed?" }, { - "prediction": "I'm not sure I understand what you're trying to do with this test case. It seems like you're trying to make sure that the `CaseSensitivePath` is set to `true` and that the `CaseSensitive` field is set to `true` as well. However, I'm not sure what you're trying to achieve with this test case. Could you please provide more context or clarify your question?", + "prediction": "I'm not sure I understand what you're trying to do with this test case. It seems like you're trying to test that the trie is case sensitive, but you're not actually using the `CaseSensitivePath` flag in your test case. If you want to test that the trie is case sensitive, you should use the `CaseSensitivePath` flag in your test case.", "reference": "The tests are not run concurrently? (I don't know. Better check.)" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to set the `fontSize` in the `showEditor_` method. This way, we don't have to do it in the constructor.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to set the `fontSize` to the `Blockly.FieldTextInput.FONTSIZE` in the `showEditor_` method.", "reference": "Regardless of scale?" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's better to have a separate `algod` and `goal` package. The `algod` package would be responsible for the logic of the `algod` daemon, and the `goal` package would be responsible for the logic of the `goal` daemon. The `algod` and `goal` packages would be able to communicate with each other, and the `algod` package would be able to communicate with the `goal` package.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a separate package for this, so that we don't have to import it in the algod package.", "reference": "Nit: should not we hide them from printing out?" }, { - "prediction": "`img` is not in the list of keys, should be `keys=['img', 'gt']`", + "prediction": "I don't think it's necessary to use `dict(type='DefaultFormatBundle')` here. We can just use `dict(type='DefaultFormatBundle', keys=['img'])` instead.", "reference": "What is the reason to modify those things? I noticed it breaks the examples using `asyncio`" }, { @@ -21239,7 +21239,7 @@ "reference": "WHOOOOOOOPS! so this is a wire protocol breaking change. I deployed a dev version of yarpc 1.9 to demo-yarpc-go and it caused bad request errors because it couldn't determine the procedure anymore. (in coordination with yarpc-prober)" }, { - "prediction": "I think we can remove the `wtimeout` and `wtimeoutMS` keys from the `WriteConcern` class.", + "prediction": "I'm not sure what you're trying to achieve with this class, but I think it's a good idea to add a `toString` method to it. This will make it easier to compare WriteConcern objects.", "reference": "if we keep this, can we stick to our convention of using UPPER_CASE for constants? Otherwise this looks like a floating variable to me." }, { @@ -21247,23 +21247,23 @@ "reference": "You probably don't want to assume that `self.underlayer` has a `seq` attribute." }, { - "prediction": "I'm not sure I understand what you're trying to do here. I don't think you want to create a separate translator instance for this helper, since it configures different language/locale than the core shared instance. I think you want to create a separate translator instance for this helper, since it configures different language/locale than the core shared instance. I think you want to create a separate translator instance for this helper, since it configures different language/locale than the core shared instance. I think you want to create a separate translator instance for this helper, since it configures different language/locale than the core shared instance. I think you want to create a separate translator instance for this helper, since it configures different language/locale than the core shared instance. I think you want to create a separate translator instance for this helper, since it configures different language/locale than the core shared instance. I think you want to create a separate translator instance for this helper, since it configures different language/locale than the core shared instance. I think you want to create a separate translator instance for this helper, since it configures different language/locale than the core shared instance. I think you want to create a separate translator instance for this helper, since it configures different language/locale than the core", + "prediction": "I'm not sure I understand what you're trying to do here. You're creating a new translator instance, but you're not passing it to the factory.", "reference": "This apparently breaks the language selection." }, { - "prediction": "I think this should be `execute(\"ALTER TABLE tags MODIFY name VARCHAR(255) CHARACTER SET utf8 COLLATE utf8_bin;\")`", + "prediction": "I think this should be `if ActsAsTaggableOn::Utils.using_mysql?` instead of `if ActsAsTaggableOn::Utils.using_mysql? && ActsAsTaggableOn::Utils.using_mysql?`", "reference": "since we're not using mysql, do we need this migration?" }, { - "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to have this in a separate file so that it can be easily updated in the future. I'm not sure if it's a good idea to have this in a separate file, but I think it's a good idea to have this in a separate file so that it can be easily updated in the future. I'm not sure if it's a good idea to have this in a separate file, but I think it's a good idea to have this in a separate file so that it can be easily updated in the future. I'm not sure if it's a good idea to have this in a separate file, but I think it's a good idea to have this in a separate file so that it can be easily updated in the future. I'm not sure if it's a good idea to have this in a separate file, but I think it's a good idea to have this in a separate file so that it can be easily updated in the future. I'm not sure if it's a good idea to have this in a separate file, but I think it's a good idea to have this in a separate file so that it can be easily updated", + "prediction": "I'm not sure if this is a good place to put this, but I think it would be a good idea to have this in a separate file, so that it can be easily updated in the future.", "reference": "i'm not sure about htis naming here. both the word partition and adjustment are very ambiguous and it's not clear what it does. i would maybe go for something less generic and more concrete like `GOV_CLOUD_SUPPORT`" }, { - "prediction": "I don't think this is needed.", + "prediction": "I don't think this is necessary. The `fetchUnfinishedFlows` and `fetchUnfinishedExecutions` methods should be implemented in the `ExecutorLoader` class, not in the `MockExecutorLoader` class.", "reference": "unfinishedFlows might not be the same as activeFlows. Will it cause confusion here?" }, { - "prediction": "I think we can remove the `if err != nil` check here.", + "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to create a *runtimevar.Variable from a URL, and then watch for changes to that variable. Is this what you're trying to do?", "reference": "Same, remove the error handling." }, { @@ -21271,11 +21271,11 @@ "reference": "We should not change this at this time." }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", "reference": "We may also update the docstring in the AnchorGenerator's arguments at around line 15." }, { - "prediction": "I'm not sure what you mean by \"duplicates existing barrier submitted in this batch from command buffer %s.\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do it here.", "reference": "FormatHandle isn't current typesafe w.r.t. requiring *VULKAN* handles... so this slipped through." }, { @@ -21287,19 +21287,19 @@ "reference": "Throw an exception instead" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right way to do it.", + "prediction": "I'm not sure what you're trying to do here. I don't think you want to use `template` here. I think you want to use `org2` here.", "reference": "we shouldn't need the `FactoryBot.` in these. Ok to leave for now since all of these specs have them. Can clean up later" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the uploads path for a file. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the uploads path for a file. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the uploads path for a file. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the uploads path for a file. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the uploads path for a file. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the uploads path for a file. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the uploads path for a file. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the uploads path for a file. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the uploads", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a URL that points to the uploads directory, but you're not actually doing anything with it. You're just creating a URL that points to the uploads directory, which is not what you want.", "reference": "Isn't the better option to actually do `$this->getDisk()->url($uploadsPath)` without changing the filesystems config? Not sure why you think that change is required but it's definitely not getting merged." }, { - "prediction": "I think this should be `if itemmethod.parent.name not in SEQUENCE_TYPES` instead of `if itemmethod.parent.frame().name not in SEQUENCE_TYPES`.", + "prediction": "I'm not sure what you mean by `not isinstance(itemmethod, nodes.FunctionDef)`. I think you meant to say `not isinstance(itemmethod, nodes.FunctionDef) or itemmethod.root().name != \"builtins\"`.", "reference": "Not sure if we need this. It's not tested because it only guards against a new conditional definition of a dunder method in a built-in package. I am fine with leaving it out." }, { - "prediction": "I think this should be `using Microsoft.DotNet.Build.Common.Desktop;` instead of `using Microsoft.DotNet.Build.Common.Desktop;`", + "prediction": "I think this should be `using Microsoft.DotNet.Build.Tasks.Feed.Desktop;` instead of `using Microsoft.DotNet.Build.Common.Desktop;`", "reference": "Is this the only task in this library? If so this is good, if not then we should do it for each task." }, { @@ -21311,27 +21311,27 @@ "reference": "Not needed anymore" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is this for a specific use case or something else?", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to expose the ping-pong protocol here. It's not a good idea to expose the ping-pong protocol here. It's not a good idea to expose the ping-pong protocol here. It's not a good idea to expose the ping-pong protocol here. It's not a good idea to expose the ping-pong protocol here. It's not a good idea to expose the ping-pong protocol here. It's not a good idea to expose the ping-pong protocol here. It's not a good idea to expose the ping-pong protocol here. It's not a good idea to expose the ping-pong protocol here. It's not a good idea to expose the ping-pong protocol here. It's not a good idea to expose the ping-pong protocol here. It's not a good idea to expose the ping-pong protocol here. It's not a good idea to expose the ping-pong protocol here. It's not a good idea to expose the ping-pong protocol here. It's not a good idea to expose the ping-pong protocol here. It's not a good idea to expose the ping-pong protocol here.", "reference": "Please not abbreviations" }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it's a good idea to have a separate handler for `aws.IsReaderSeekable(r.Body)`.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would make sense to move this to the `core` package. It seems like the `ValidateResponseHandler` and `AfterRetryHandler` could be moved to the `core` package as well.", "reference": "This shouldn't get stomped over on line 207" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I'm not sure what you mean by \"zero indexed\" here. I think it means that the index starts at 0.", "reference": "are they not 1-indexed?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add a check for `lastTime.CheckTimestamp` and `lastTime.Timestamp` here. This way, we can ensure that the settlement time is not too close to the current time.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check that the current time is not the same as the last time the settlement was settled.", "reference": "I know that previously this check was here but @ralph-pichler replaced it with the `CheckTimestamp` field stating that checking against `Timestamp` was incorrect. @ralph-pichler can you elaborate?" }, { - "prediction": "I think we should use `__version__` instead of `__version__` here. `__version__` is the version string of the package, while `__version__` is the version string of the module. `__version__` is the version string of the package, while `__version__` is the version string of the module. `__version__` is the version string of the package, while `__version__` is the version string of the module. `__version__` is the version string of the package, while `__version__` is the version string of the module. `__version__` is the version string of the package, while `__version__` is the version string of the module. `__version__` is the version string of the package, while `__version__` is the version string of the module. `__version__` is the version string of the package, while `__version__` is the version string of the module. `__version__` is the version string of the package, while `__version__` is the version string of the module. `__version__` is the version string of the package, while `__version__` is the", + "prediction": "I think we should use `__version__` instead of `__version__` here. `__version__` is the version string, while `__version__` is the version number. `__version__` is the version string, while `__version__` is the version number. `__version__` is the version string, while `__version__` is the version number. `__version__` is the version string, while `__version__` is the version number. `__version__` is the version string, while `__version__` is the version number. `__version__` is the version string, while `__version__` is the version number. `__version__` is the version string, while `__version__` is the version number. `__version__` is the version string, while `__version__` is the version number. `__version__` is the version string, while `__version__` is the version number. `__version__` is the version string, while `__version__` is the version number. `__version__` is the version string, while `__version__` is the version number. `__version__` is", "reference": "`short_version = __version__`" }, { - "prediction": "I'm not sure what you're trying to accomplish with this snippet. It looks like you're trying to update the status of an access key for an IAM user, but I'm not sure what you're trying to accomplish with this snippet. It looks like you're trying to update the status of an access key for an IAM user, but I'm not sure what you're trying to accomplish with this snippet. It looks like you're trying to update the status of an access key for an IAM user, but I'm not sure what you're trying to accomplish with this snippet. It looks like you're trying to update the status of an access key for an IAM user, but I'm not sure what you're trying to accomplish with this snippet. It looks like you're trying to update the status of an access key for an IAM user, but I'm not sure what you're trying to accomplish with this snippet. It looks like you're trying to update the status of an access key for an IAM user, but I'm not sure what you're trying to accomplish with this snippet. It looks like you're trying to update the status of an access key for an IAM user, but I'm not sure what you're trying to accomplish with this snippet. It looks like you", + "prediction": "I'm not sure what you're trying to achieve with this snippet. It looks like you're trying to update the status of an access key for an IAM user, but I'm not sure what you're trying to achieve with this snippet. It looks like you're trying to update the status of an access key for an IAM user, but I'm not sure what you're trying to achieve with this snippet. It looks like you're trying to update the status of an access key for an IAM user, but I'm not sure what you're trying to achieve with this snippet. It looks like you're trying to update the status of an access key for an IAM user, but I'm not sure what you're trying to achieve with this snippet. It looks like you're trying to update the status of an access key for an IAM user, but I'm not sure what you're trying to achieve with this snippet. It looks like you're trying to update the status of an access key for an IAM user, but I'm not sure what you're trying to achieve with this snippet. It looks like you're trying to update the status of an access key for an IAM user, but I'm not sure what you're trying to achieve with this snippet. It looks like you", "reference": "AWS Identity and Access Management (IAM)" }, { @@ -21339,7 +21339,7 @@ "reference": "Required for the SparkDataFile SerDe" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate function to check if the base class is a generic type, and if it is, disable dynamic types for it.", + "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to disable dynamic types for base classes.", "reference": "Do you want to make this an assertion instead?" }, { @@ -21347,7 +21347,7 @@ "reference": "When updating the copyright, we tend to cover previous years, not just the current. So, if we started the file in 2015, we'd update to say 2015-2016. I'm not sure if there's a legal requirement surrounding this, but it's the convention we and many others have adopted for code." }, { - "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to set the initial head of the folder branch to be the same as the master branch, but I don't think that's what you want to do. I think you want to set the initial head of the folder branch to be the same as the master branch, but you want to set the initial head of the folder branch to be the same as the master branch, but you want to set the initial head of the folder branch to be the same as the master branch, but you want to set the initial head of the folder branch to be the same as the master branch, but you want to set the initial head of the folder branch to be the same as the master branch, but you want to set the initial head of the folder branch to be the same as the master branch, but you want to set the initial head of the folder branch to be the same as the master branch, but you want to set the initial head of the folder branch to be the same as the master branch, but you want to set the initial head of the folder branch to be the same as the master branch, but you want to set the initial head of the folder branch to be the same", + "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to add a check here to make sure that we don't try to set the initial head if it's already been set.", "reference": "Wait, so it looks like this function is called _every_ time we fetch the root node, i.e. we do an MD head fetch every time we fetch the root node? Not for this PR, but it seems like we should make that unnecessary, since this function only ever does anything when head is `nil`, i.e. the first time. Maybe add a TODO?" }, { @@ -21355,55 +21355,55 @@ "reference": "Why are you changing this?" }, { - "prediction": "I think we should be able to do this in a single line, right?", + "prediction": "I think it's better to use `*config` instead of `config` in this case.", "reference": "`json.RawMessage` is a `[]byte`, which is already a pointer. Why do we need to have pointer here if we just reading this value?" }, { - "prediction": "I'm not sure what you mean by \"Antrea CNI 0.3.1\". Is this the same as \"Antrea CNI 0.3.0\" or \"Antrea CNI 0.3.1\"?", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `cni_version.All` value for the `version.GetFullVersionWithRuntimeInfo()` call.", "reference": "should we actually switch to `All` or just add `0.4.0` explicitly to the list of supported CNI versions? What is a new CNI version is released?" }, { - "prediction": "I'm not sure if this is the right place to add this, but I think it would be a good idea to add this to the `notifier` module.", + "prediction": "I don't think we need to use `resource_util` here.", "reference": "pylint might complain that this isn't alphasorted?" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to disable the `NetworkService` feature. I'm not sure what you're trying to do here, but it looks like you're trying to disable the `NetworkService` feature. I'm not sure what you're trying to do here, but it looks like you're trying to disable the `NetworkService` feature. I'm not sure what you're trying to do here, but it looks like you're trying to disable the `NetworkService` feature. I'm not sure what you're trying to do here, but it looks like you're trying to disable the `NetworkService` feature. I'm not sure what you're trying to do here, but it looks like you're trying to disable the `NetworkService` feature. I'm not sure what you're trying to do here, but it looks like you're trying to disable the `NetworkService` feature. I'm not sure what you're trying to do here, but it looks like you're trying to disable the `NetworkService` feature. I'm not sure what you're trying to do here, but it looks like you're trying to disable the `NetworkService` feature. I'm not sure", + "prediction": "I don't think this is necessary. I think we can just use `--disable-gpu` and `--ignore-certificate-errors` instead.", "reference": "It seems that NetworkService is behind a feature flag because it's still experimental. If we see new issues, we should look at flipping this back off." }, { - "prediction": "I think we can remove the `map[string]ContainerStatus` and just use `ContainerStatusNone` and `ContainerStatusUnknown` instead.", + "prediction": "I think it's better to use `map[string]TaskStatus` instead of `map[string]ContainerStatus`.", "reference": "I think it makes more sense to have this be a method on TaskStatus. Also, nit, Backend, not BackEnd." }, { - "prediction": "I'm not sure what you mean by `impl_get_instance_id() const noexcept`. It's not a member function of `HIPInternal`, it's a member function of `Kokkos::Experimental::HIP` which is a member of `Kokkos::Experimental`.", + "prediction": "I think this should be `impl_get_instance_id()` instead of `impl_get_instance_id() const`", "reference": "Could you please elaborate on why you need all this magic here? In which cases do you want the same id to be returned? Does this work the same way for all backends?" }, { - "prediction": "I don't think we need to change the `ConfigDir` field. We can just use the `ConfigDir` field from the `Config` struct.", + "prediction": "I don't think we need to add `logrus.FieldLogger` to the `Config` struct.", "reference": "nit: `PluginConfigs` feels a little better" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to stop the probe server, but you're not actually stopping the probe server. I think you meant to call `probeSvr.Stop(ctx)` instead of `probeSvr.Stop()`.", + "prediction": "I don't think we need to stop the server here.", "reference": "think we need to find out the root-cause and fix, instead of just removing `NoError`? it erred b/c `context canceled`, so call this before context cancelled is the right fix" }, { - "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to get a block from the disk block cache and put it into the block server cache. I'm not sure what you're trying to do here, but it looks like you're trying to get a block from the disk block cache and put it into the block server cache. I'm not sure what you're trying to do here, but it looks like you're trying to get a block from the disk block cache and put it into the block server cache. I'm not sure what you're trying to do here, but it looks like you're trying to get a block from the disk block cache and put it into the block server cache. I'm not sure what you're trying to do here, but it looks like you're trying to get a block from the disk block cache and put it into the block server cache. I'm not sure what you're trying to do here, but it looks like you're trying to get a block from the disk block cache and put it into the block server cache. I'm not sure what you're trying to do here, but it looks like you're trying to get a block from the disk block cache and put it into", + "prediction": "I think it's better to call `Put` in a separate goroutine to avoid blocking the `Get`.", "reference": "Please expand \"later behavior\". Presumably something to do with the prefetch logic?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.", + "prediction": "I think we should be able to return a swarm.ZeroAddress here as well.", "reference": "The `response` variable is not used, it can be removed, also the fmt.Errorf." }, { - "prediction": "I think this should be `if (value == null) return true;` instead of `if (value == null) return true; if (value.Length == 0) return true; return String.IsNullOrEmpty(value.Trim());`", + "prediction": "I think this should be `if (value == null)` instead of `if (value == null && value.Length == 0 && value.Trim().Length == 0)`.", "reference": "Do you find this really easier to read?" }, { - "prediction": "I'm not sure if this is the right place to do this.", + "prediction": "I think this should be `if (forceGroupByAgg) { GroupByAggNodeAdded = TRUE; }` instead of `if (forceGroupByAggAggNodeAdded) { GroupByAggNodeAdded = TRUE; }`", "reference": "A small nit: This variable should start with a lower case letter." }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it would make sense to move this into the `PageStreamingDescriptorView` class.", + "prediction": "I'm not sure if this is the best place to put this, but I think it would make sense to move it to the `PageStreamingDescriptorView` class.", "reference": "Where is this used for Node?" }, { @@ -21411,11 +21411,11 @@ "reference": "Is `` really easier to understand than `` for CLI user? For me, `identity` seems like a concept we use publicly, and `id` is just an internal shortcut for it." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to create a new `internalGroupKeyFunc` for each `ClusterGroup` that we want to add. This way, we don't have to worry about adding a new `internalGroupKeyFunc` for each `ClusterGroup` that we want to add, and we don't have to worry about adding a new `internalGroupKeyFunc` for each `ClusterGroup` that we don't want to add.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `processClusterGroup` function.", "reference": "nit.. `if` .. `else` for logging probably can be avoided.. maybe only log that an internal group was created for cluster group" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it would be better to use the new `config` package.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add a comment to explain what it does.", "reference": "There's a lot of changed tests -- but no new tests. You need unit and integration tests for this." }, { @@ -21423,11 +21423,11 @@ "reference": "WithMessage what gas limit is?" }, { - "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to add a `skip` to this test.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a `skip` to this test.", "reference": "Why are these skipped?" }, { - "prediction": "I don't think we need this field. It's not used anywhere. We can remove it.", + "prediction": "I don't think we need this field. It's not used anywhere in the spec.", "reference": "We'd better add the `json:\"metaServer,omitempty\"` here" }, { @@ -21435,11 +21435,11 @@ "reference": "So... when we want to install mitmproxy with pinned dependencies, we first install all pinned dependencies, and then in a second step install mitmproxy as editable, making sure that no additional dependencies are sneaking in." }, { - "prediction": "I'm not sure what you mean by \"rewriteEnvVars\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the environment variables are set before we try to execute the command.", "reference": "not sure how this got in master, but the linter is unhappy about it so I fixed it here" }, { - "prediction": "I'm not sure if this is the right place to add this backoff window, but I think it's a good idea to increase it to 5 min.", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to increase the backoff window to 5 minutes.", "reference": "No need for this TODO anymore, right?" }, { @@ -21447,47 +21447,47 @@ "reference": "I would assign the key you're looking for into a variable first, and then use it in the comparisons." }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason you want to remove the plugin from our internal container?", + "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to remove the plugin from the internal container. Is that correct? If so, I'm not sure what you're trying to do here, but it looks like you're trying to remove the plugin from the internal container. Is that correct? If so, I'm not sure what you're trying to do here, but it looks like you're trying to remove the plugin from the internal container. Is that correct? If so, I'm not sure what you're trying to do here, but it looks like you're trying to remove the plugin from the internal container. Is that correct? If so, I'm not sure what you're trying to do here, but it looks like you're trying to remove the plugin from the internal container. Is that correct? If so, I'm not sure what you're trying to do here, but it looks like you're trying to remove the plugin from the internal container. Is that correct? If so, I'm not sure what you're trying to do here, but it looks like you're trying to remove the plugin from the internal container. Is that correct? If so, I'm not sure what you're trying to", "reference": "Would be better to normalize it at the start of the method to pass through to all the other calls" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `FormWidgetBase` class, so that it can be used by other widgets as well.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the parent form as well.", "reference": "This can't exist here either because the code editor can be used on other models than CMS templates. You could probably implement this as a `hint` property (so `hint: cms::lang.cms_object.safe_mode_enabled`) on the codeeditor formwidget instead though and I'd be fine with that." }, { - "prediction": "I think this should be `unit` instead of `textInfos.UNIT_LINE`?", + "prediction": "I don't think this is a good idea.", "reference": "This line is unnecessary." }, { - "prediction": "I think this should be `LLDB_LOG(GetLogIfAllCategoriesSet(LIBLLDB_LOG_API), \"Recording {0}: {1}\", id, m_pretty_func);` instead of `LLDB_LOG(GetLogIfAllCategoriesSet(LIBLLDB_LOG_API), \"Recording {0}: {1}\", id, m_pretty_func);`", + "prediction": "I think this should be `LLDB_LOG(GetLogIfAllCategoriesSet(LIBLLDB_LOG_API), \"Recording {0}: {1}\", id, m_pretty_func);`", "reference": "How did this compile in the first place? Is there a matching declaration in a header that should be removed too?" }, { - "prediction": "I'm not sure what you mean by \"failed to create string:\"", + "prediction": "I think this should be `h2o_mruby_assert(mrb);` instead of `h2o_mruby__abort_exc(mrb, \"h2o_mruby_new_str:failed to create string:\", file, line);`", "reference": "Please remove the colon at the end, and merge the PR once the CI succeeds. Thank you for the PR." }, { - "prediction": "I think we can remove the `go-bindata` dependency, as it's not needed anymore.", + "prediction": "I'm not sure why we need to use `_` here. We can just use `github.com/jteeuwen/go-bindata/go-bindata` instead.", "reference": "whoops. this should be protoc-gen-doc, since that is the only bit left that is built out-of-tree (everything else is either downloaded or built via modules already depended on by spire's go.mod)" }, { - "prediction": "I think this should be `report(EventType eventType, Map metadata);` instead of `report(EventType eventType, Map metadata);`", + "prediction": "I think this should be `public interface AzkabanEventReporter` instead of `public abstract interface AzkabanEventReporter`.", "reference": "The convention is to use

    see the google style guide and use checkstyle to check. You can change it later." }, { - "prediction": "I think it's a good idea to add a `__getitem__` method to the `ListElement` class so that we can use `list[0]` or `list[1]` or `list[2]` instead of `list[0]`, `list[1]`, and `list[2]` respectively.", + "prediction": "I think it's a good idea to add a `__getitem__` method to the `ListElement` class, so that you can use `list[0]`, `list[1]`, etc. instead of `self[0]`, `self[1]`, etc.", "reference": "Using non-keyword args after the keyword arg (parent-self) will cause a SyntaxError." }, { - "prediction": "I think we can remove the `send` call here.", + "prediction": "I think we can remove the `send` call here, as it's not needed.", "reference": "I think you'll want to add some YARD docs to this method to get the PR approved" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason you want to store the result in `self->out_variant`?", + "prediction": "I'm not sure if this is the right place to do this, but I think it would make sense to do this in `ostree_repo_query_object_storage_size` as well.", "reference": "Hmm, AFAICT `*out_variant` isn't explicitly set to `NULL` in the `ENOENT` case." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `createTLSConfig` function to create the `tlsConfig` and then pass it to the `sdkclient.NewClient` function. This way, we don't have to create the `tlsConfig` every time we call `sdkclient.NewClient`, and we can reuse the same `tlsConfig` across multiple calls to `sdkclient.NewClient`.", + "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to create the TLS config in the same place as we create the SDK client, so that we don't have to do it twice.", "reference": "Nit: \"Failed to configure TLS for SDK client\"?" }, { @@ -21495,19 +21495,19 @@ "reference": "please update your branch to the latest `master`. This change was already made in #4359" }, { - "prediction": "I don't think we need to use `time.Sleep` here. We can use `time.After` instead.", + "prediction": "I don't think we need to use `time.Sleep` here. We can just use `time.After` instead.", "reference": "This line should be formatted" }, { - "prediction": "I'm not sure what the point of this option is. It's not clear to me what it does, and I'm not sure if it's a good idea to have it.", + "prediction": "I'm not sure if this is a good idea, but I think we should add a `--block_processor_batch_size` option to the `bootstrap` command.", "reference": "\"default 65536\" Not sure if it's important to state, but block_processor_full_size has a different default for fast_bootstrap." }, { - "prediction": "I think this should be `public int HashCacheSize { get; set; } = 512 * 1024;` instead of `public uint FutureNonceRetention { get; set; } = 16;`", + "prediction": "I think this should be `public int HashCacheSize { get; set; } = 512 * 1024;` instead of `public long? GasLimit { get; set; } = null;`", "reference": "remove unnecessary whitespace changes" }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `asyncVerifyContext` struct.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `txnpool.go` file, since it's not part of the `txnpool` package.", "reference": "Are these conditions covered elsewhere ?" }, { @@ -21515,11 +21515,11 @@ "reference": "the above check (by transitivity) checked for `in_data.name_id == out_data.name_id && in_data.name_id != EMPTY_NAME_ID && out_data.name_id != EMPTY_NAME_ID`. The final check of `out_data.name_id != EMPTY_NAME_ID` is missing now." }, { - "prediction": "I think this should be `if (!event_handle)` instead of `if (!event_handle) {`", + "prediction": "I think this should be `if (!event_handle)` instead of `if (!event_handle) { ... }`", "reference": "The event handle is being passed by reference, so the dereference on 591 is actually correct. To follow the convention that variables be declared before executable statements, please change the code to the following: struct _fpga_event_handle *_eh; fpga_result result = FPGA_OK; int err = 0; if (!event_handle) { return FPGA_INVALID_PARAM; } _eh = (struct _fpga_event_handle *) *event_handle;" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's better to use `map_matching` instead of `map` in the `named_mutex` class.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to `server/data_structures/datafacade_base.hpp` so that it can be used by `server/data_structures/shared_barriers.hpp` and `server/data_structures/internal_datafacade.hpp` as well.", "reference": "reorder includes to be alphabetically ordered" }, { @@ -21527,23 +21527,23 @@ "reference": "Rename `need_unmap` to `unmap`." }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it would be good to have this in a separate file. It's not a big deal, but I think it would be nice to have this in a separate file.", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `chaosctl` package, since it's used by both `iochaos` and `networkchaos` and `stresschaos`.", "reference": "In line 28, it has been declared twice, so removing `cm` should not impact, can you explain me little bit? :)" }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a new `Service`, but you're not using the `acquireTopologyCacheLock` and `startTopologyCache` methods. Is this what you're trying to do?", + "prediction": "I'm not sure what you mean by \"acquireTopologyCacheLock\" and \"startTopologyCache\"", "reference": "i don't think these unexported functions belong on the public interface, they can exist solely on the struct." }, { - "prediction": "I'm not sure what you mean by \"subdirectives are themselves treated as directives\". I think you mean \"subdirectives are themselves treated as directives, from which a subroute is built\".", + "prediction": "I'm not sure what you mean by \"subdirectives\". I think you meant \"subroute\".", "reference": "I'm not entirely clear on why this is necessary?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the session file exists before trying to write to it.", + "prediction": "I don't think this is a good idea. We should use `utils.get_temp_file(keep=True)` instead of `cast(str, utils.get_temp_file(keep=True))`", "reference": "Why do we need to cast to `str` here?" }, { - "prediction": "I'm not sure what you mean by \"testAppConfigurationInitialisation() throws TimeoutException\"", + "prediction": "I don't think this is a good idea. The `@Ignore` annotation should be used for tests that don't need to be run.", "reference": "The ignore import above should be unused now and can be removed." }, { @@ -21555,51 +21555,51 @@ "reference": "initialization of available ram is here" }, { - "prediction": "I think we should remove the `if (this.sourceBlock_.editable_ && this.sourceBlock_.type === 'math_number')` check.", + "prediction": "I think it's better to use `if (this.sourceBlock_.editable_ && this.sourceBlock_.type === 'math_number') { text += '\\u200E'; } else { text = '\\u202B' + text + '\\u202C'; }` instead of `if (this.sourceBlock_.RTL) { text += '\\u200F'; } else { text = '\\u202B' + text + '\\u202C'; }`", "reference": "Can have negative numbers with the '-' on the right (`10-`) by just using line 610." }, { - "prediction": "I'm not sure what you mean by \"no associated resources\". Is it possible to delete an IAM user that has no associated resources?", + "prediction": "I'm not sure what you mean by \"no associated resources\". Is it possible to delete a user that has no associated resources?", "reference": "AWS Identity and Access Management (IAM)" }, { - "prediction": "I think we can remove the `if len(check_commands) == 0` check.", + "prediction": "I'm not sure what you're trying to do here, but I don't think this is the right place to do it.", "reference": "Shouldn't we use store a message which indicates that there was no available checker command? By the way how is it possible that metadata.json doesn't contain the checker command? Maybe this was the case in the earlier versions?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. Is it that you want to return `true` if the line matches an exclusion pattern, and `false` if it doesn't?", + "prediction": "I think this should be `@exclusion_patterns` instead of `DEFAULT_EXCLUSION_PATTERNS.dup`", "reference": "Given that this is a boolean predicate, maybe it should be `full_backtrace?`." }, { - "prediction": "I'm not sure what you're trying to achieve with this code, but it looks like you're trying to use the `ldap` library to connect to an LDAP server and perform some operations. However, there are a few issues with the code that need to be addressed:\n\n * The `traceback` module is not available in Python 3.x, so you'll need to use the `traceback` module from Python 3.x.\n * The `ldap` module is not available in Python 3.x, so you'll need to use the `ldap` module from Python 3.x.\n * The `settings` module is not available in Python 3.x, so you'll need to use the `settings` module from Python 3.x.\n * The `User` class is not available in Python 3.x, so you'll need to use the `User` class from Python 3.x.\n * The `User` class is not available in Python 3.x, so you'll need to use the `User` class from Python 3.x.\n * The `User` class is not available in Python 3.x, so you'll need to use the `User` class from Python 3.x.\n ", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `ldap` instead of `ldap3` in this case. `ldap3` is a fork of `ldap` and it's not maintained anymore.", "reference": "Just curious why the blank line here?" }, { - "prediction": "I don't think this is necessary. We can just use `__version__` instead.", + "prediction": "I think this should be `from netlib.version import *` instead of `from mitmproxy.version import *`", "reference": "I like the idea, but we don't want a dependency on mitmproxy in pathod." }, { - "prediction": "I think we can remove the `lock` here.", + "prediction": "I think we should remove the `get` and `set` methods, since they're not needed anymore.", "reference": "Why not adding this to the interface and keep passing the interface (as the interface is internal I don't get why you're not adding it there)" }, { - "prediction": "I don't think this is a good idea. The `astroid` module is not a standard library module, so it's not a good idea to import it in the `astroid` module.", + "prediction": "I'm not sure if this is a good idea, but I think it's better to use `astroid` instead of `astroid.const` for `PY310_PLUS`.", "reference": "`PY310` should probably be imported from `pylint.const`" }, { - "prediction": "I think we can remove the `asInt64Slice` method since it's not needed anymore.", + "prediction": "I think this should be `strconv.ParseBool` instead of `strconv.ParseInt`.", "reference": "Can we propagate this error up the stack?" }, { - "prediction": "I think this should be `te::abs_error` instead of `la::l_inf_norm`.", + "prediction": "I think this should be `te::abs_error` instead of `te::get_tolerance`.", "reference": "Why reference is converted to table?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `roots_desktop` struct.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `roots_desktop` struct. I think it's a good idea to add this to the `roots_desktop` struct. I think it's a good idea to add this to the `roots_desktop` struct. I think it's a good idea to add this to the `roots_desktop` struct. I think it's a good idea to add this to the `roots_desktop` struct. I think it's a good idea to add this to the `roots_desktop` struct. I think it's a good idea to add this to the `roots_desktop` struct. I think it's a good idea to add this to the `roots_desktop` struct. I think it's a good idea to add this to the `roots_desktop` struct. I think it's a good idea to add this to the `roots_desktop` struct. I think it's a good idea to add this to the `roots_desktop` struct. I think it's a good idea to add this to the `roots_desktop` struct. I think it's a good idea to add this to the `", "reference": "You shouldn't use assert for runtime errors." }, { - "prediction": "I think it's better to use `vendor/form-attr-polyfill.min.js` instead of `vendor/form-attr-polyfill.js`", + "prediction": "I don't think this is necessary, since we already have `form-attr-polyfill.js` in `vendor/form-attr-polyfill.js`", "reference": "Does this really belong in the vendor directory if you wrote it? At very least, should it get its own repo somewhere in addition to being dropped here?" }, { @@ -21611,11 +21611,11 @@ "reference": "Can we remove the argument from this message? A message will include a line number already that points to the place in the code that has the problem. I think we can remove it." }, { - "prediction": "I think this should be `ResponseMininumDataRateNotSatisfied(string connectionId, string traceIdentifier)` instead of `ResponseMininumDataRateNotSatisfied(string connectionId, string traceIdentifier, Rate rate)`", + "prediction": "I think this should be `ResponseMininumDataRateNotSatisfied(string connectionId, string traceIdentifier)`", "reference": "This whole class is now a mix of virtual and non-virtual. I tried to see what would happen if I made everything non-virtual in dev, and the build still passes. It turns out that none of the other methods actually need to be virtual. Can you make *all* the logging methods either virtual or not for consistency? Thanks." }, { - "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to have a flag for the URL of the my.mysterium.network API. This way, we don't have to specify it every time we want to use the API.", + "prediction": "I'm not sure if this is a good idea or not, but I think it's better to have a separate flag for `mmn-address` and `broker-address` instead of having both in the same flag.", "reference": "This looks a bit cryptic to me, and also it contains a dash. How about `mymysterium.url`?" }, { @@ -21627,27 +21627,27 @@ "reference": "Here's the object model change. `CodeFlows` is a set of objects of type `CodeFlow`, rather than a list of list of `AnnotatedCodeLocation`. Exactly parallel with `Stacks`." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I'm not sure what you mean by this, but I think it's a good idea to remove the `BAN_PUBLIC_USERS` variable from the `config.py` file. It's not used anywhere else in the code, and it's not necessary to have it in the `config.py` file.", "reference": "Sorry, one more thing... You should use `app.config` instead of importing it directly. See the code below." }, { - "prediction": "I'm not sure I understand what you're trying to do here.", + "prediction": "I'm not sure if this is the best place to do this, but I think it's a good idea to have a `close` method in the `VectorizedReader` class.", "reference": "This was correct before; \"setup\" is a noun and \"set up\" is the verb form." }, { - "prediction": "I don't think we need to set the account here. We already have the account in the response.", + "prediction": "I don't think we need to set the account here.", "reference": "What's the reason for this change here? I didn't see it mentioned in the PR and it's a bit of a confusing param name" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `index` object.", + "prediction": "I think this should be `this.storage.config.localList.get().map( function( package ){ return { ref: package, score: 1 }; } )` instead of `this.index.search(q)`.", "reference": "I wonder why ~ and not a wildcard instead?" }, { - "prediction": "`if(beanCls == null) { return; }`", + "prediction": "\u4e3a\u4ec0\u4e48\u662fnull\uff0c\u800c\u4e0d\u662fbeanCls.getSuperclass()\u5462\uff1f", "reference": "when will this happened? if happened, just ignore it Silently?" }, { - "prediction": "I think we can remove the `set(TableProperties.MANIFEST_TARGET_SIZE_BYTES, \"12850\")` line.", + "prediction": "I think we can remove the `TableProperties.MANIFEST_MIN_MERGE_COUNT` and `TableProperties.MANIFEST_TARGET_SIZE_BYTES` from the test.", "reference": "3x the smaller size would be around 17k, and we need it to be at least about 13k, which is 2x the larger size. I'd probably set this to 15k to split the difference and hopefully avoid needing to update this again as tests change. This is minor, though." }, { @@ -21659,23 +21659,23 @@ "reference": "Can you please add open source disclaimer?" }, { - "prediction": "I think we can remove the `wireError` field from the `Response` struct, since it's not used in the `Handle` function.", + "prediction": "I think we can remove the `if appErr != nil` check.", "reference": "I dont want to do composite keys on purpose to verify at compile time if the message is completely filled out appropriately @sectioneight" }, { - "prediction": "I'm not sure if this is a good idea, but I think it's better to use `chain` and `svr.cfg.Genesis.KamchatkaBlockHeight` instead of `chain` and `svr.cfg.Genesis.KamchatkaBlockHeight`.", + "prediction": "I don't think we need to use `times(2)` here. We can just use `times(1)` and `times(2)` in the `chain.EXPECT().TipHeight().Return(uint64(4)).Times(2)` line.", "reference": "don't need this line, since it is not tested in api_test?" }, { - "prediction": "I think we can remove CRDRetryInterval and just use CRDRetryInterval instead.", + "prediction": "`CRDRetryInterval` should be `CRDRetryInterval`", "reference": "Does this mean the list operation is done for all the namespaces? How to list the volume replicas per namespace?" }, { - "prediction": "I don't think this is a good idea. It's not clear what `nms_op` is supposed to do.", + "prediction": "I don't think this is a good idea. We can just use `bboxes` and `inds` directly.", "reference": "I suggest adding `class_agnostic` as an argument of `batched_nms()`, with the default value False." }, { - "prediction": "I think it's better to use `NestedField` for `DELETE_FILE_POS` and `DELETE_FILE_ROW_FIELD_NAME` for `DELETE_FILE_ROW_FIELD_ID` and `DELETE_FILE_ROW_DOC` instead of `NestedField` for `DELETE_FILE_POS` and `DELETE_FILE_ROW_FIELD_NAME` for `DELETE_FILE_ROW_FIELD_ID` and `DELETE_FILE_ROW_DOC` instead of `NestedField` for `DELETE_FILE_POS` and `DELETE_FILE_ROW_FIELD_NAME` for `DELETE_FILE_ROW_FIELD_ID` and `DELETE_FILE_ROW_DOC` instead of `NestedField` for `DELETE_FILE_POS` and `DELETE_FILE_ROW_FIELD_NAME` for `DELETE_FILE_ROW_FIELD_ID` and `DELETE_FILE_ROW_DOC` instead of `NestedField` for `DELETE_FILE_POS` and `DELETE_FILE_ROW_FIELD_NAME` for `DELETE_FILE_ROW_FIELD_ID` and `DELETE_FILE_ROW_DOC` instead of `NestedField` for `DELETE_FILE_POS` and `DELETE_FILE_ROW_FIELD_NAME` for `DELETE_FILE_ROW_FIELD_ID` and `DELETE_FILE_ROW_DOC` instead of `NestedField` for `DELETE_FILE_POS` and `DELETE_FILE_ROW_FIELD_NAME` for `DELETE_FILE_ROW_FIELD_ID` and `DELETE_FILE_ROW_DOC` instead of `NestedField`", + "prediction": "I think it's better to use `deleteFileRowField` instead of `deleteFileRowFieldName` and `deleteFileRowFieldId` because `deleteFileRowFieldName` is a reserved word.", "reference": "@rdblue, did we not add the name on purpose?" }, { @@ -21683,15 +21683,15 @@ "reference": "Why is this now public?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `Blacklight::SearchContext` class.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to move this to `Blacklight::SearchContext` so that we don't have to call `setup_next_and_previous_documents_for_search` every time we call `setup_search_session`.", "reference": "I guess we should backport some deprecation for this?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in a separate file, so that we don't have to re-run it every time we want to update the profile paths.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate method for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate method for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate method for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate method for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate method for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate method for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate method for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate method for this. It's", "reference": "Moving this code inside the last case statement doesn't seem right. Why are we defining `name` and `is_relative` variables there if we aren't using them anywhere?" }, { - "prediction": "I think we can remove the `DR_REGARG` and `REGARG_PARTIAL` as they are not used anymore.", + "prediction": "I think we can remove the `REG_XMM6` and `REG_YMM6` from the definition of `REGARG_PARTIAL` and `REGARG`.", "reference": "I would say just change REGARG: no need for a separate thing." }, { @@ -21703,51 +21703,51 @@ "reference": "This doesn't look like it has as much coverage of the recursive code as it once did." }, { - "prediction": "I'm not sure what you mean by \"security groups sets the security groups used by the load balancer\". I think you meant to say \"security groups sets the security groups used by the load balancer\".", + "prediction": "I'm not sure what you mean by \"security groups\" in this context. Is it the same as the `SecurityGroups` field in the `AWS::EC2::Instance` resource?", "reference": "Do we actually expect users to provide more information here than possibly a SecurityGroup ID? If not, then this should probably use a new type, otherwise users might be confused by what options would be respected/ignored when used in this context." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It's not clear to me what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not", + "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don", "reference": "This seems like a new dependency on rometools. Do we need it?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `pull` method in the `Docker` class. This way, we can have a `pull` method in the `Docker` class, and we can have a `push` method in the `Docker` class, and we can have a `pull` method in the `Docker` class, and we can have a `push` method in the `Docker` class, and we can have a `pull` method in the `Docker` class, and we can have a `push` method in the `Docker` class, and we can have a `pull` method in the `Docker` class, and we can have a `push` method in the `Docker` class, and we can have a `pull` method in the `Docker` class, and we can have a `push` method in the `Docker` class, and we can have a `pull` method in the `Docker` class, and we can have a `push` method in the `Docker` class, and we can have a `pull` method in the `D", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `DockerClient` class.", "reference": "Waiting for the pull takes a long time. This message informs the user that at least one of the images being pulled is available. Please leave." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to use the `test` package to create a test suite, but I'm not sure if that's the best way to go about it. It's possible that you're trying to use the `test` package to create a test suite, but I'm not sure if that's the best way to go about it. It's possible that you're trying to use the `test` package to create a test suite, but I'm not sure if that's the best way to go about it. It's possible that you're trying to use the `test` package to create a test suite, but I'm not sure if that's the best way to go about it. It's possible that you're trying to use the `test` package to create a test suite, but I'm not sure if that's the best way to go about it. It's possible that you're trying to use the `test` package to create a test suite, but I'm not sure if that's the best way to go about it. It's possible that you're trying to use the `test` package to", + "prediction": "I'm not sure if this is the right place to put this, but I think it would be a good idea to move this to the `test` package so that it can be used by other tests in the `test` package.", "reference": "I can not think in a good use for it, but may we allow a way to setup a fake with a hook for logs? this fake is special, and we may need access to some of thoe logs, at the same time it may be an overkill because we dont want to test \"sql\" implementation but results.. but we can create some tests with end to end logs in some scenaries, What do you think about it?" }, { - "prediction": "I think this should be `if(!value_env && !strcmp(name, RESOURCES_CORES))` instead of `if(!value_env && !strcmp(name, RESOURCES_CORES)) && !dag_variable_add_value(name, d->default_category->mf_variables, 0, \"1\");`", + "prediction": "I think it's better to use `d->default_category->mf_variables` instead of `d->default_category->mf_variables[0]`", "reference": "I don't think you should be changing the dag unilaterally at parse time. If cores isn't specified, then it isn't specified." }, { - "prediction": "I'm not sure I understand what you're trying to say here. Could you please provide more context?", + "prediction": "I'm not sure I understand what you're trying to say here. Can you give an example of what you're trying to do?", "reference": "Instead of just \"See SubscriberOptions....\", say something like \"Use ... to choose between the two.\"" }, { - "prediction": "I think this should be `f.write( \"{}\\t{}\\n\".format(mol.GetProp(\"_Name\"),Chem.MolToSmiles( mol )))`", + "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea to open a file like this.", "reference": "Use with statement for `f`" }, { - "prediction": "I think this is a duplicate of PR #1816.", + "prediction": "I think this should be fixed in the PR #1816.", "reference": "It's a small style point, but could you remove the \"extra\" space before the colon that precedes the return type? This would make it more closely match the prevailing style in these tests and in the standard libraries." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to move this to the `MDOps` package.", + "prediction": "I don't think we need to change anything here.", "reference": "seems clunky to me to have an `MDOps` interface method that some implementations don't implement. Perhaps define a separate interface, like, `BranchResolver`, and then callers that have an `MDOps` object can check via type assertion?" }, { - "prediction": "I'm not sure what you're trying to achieve with this method. Is it possible that you're trying to get a list of all elements that match the given `By`? If that's the case, you can use the `findElements` method to get a list of all elements that match the given `By` and then convert it to a list of `WebElement` objects.", + "prediction": "I'm not sure what you're trying to do with this method, but it looks like you're trying to get a list of all the elements that match the given `By` and return them as a list of `T` objects, where `T` is the type of the `WebElement` returned by the `findElements` method. Is this what you're trying to do?", "reference": "This change should also probably go into the corresponding method of the abstract By class?" }, { - "prediction": "I don't think this is necessary. We can just use `byteutil` directly.", + "prediction": "`byteutil` should be `byte` instead of `byteutil` because `byteutil` is a package and `byte` is a type.", "reference": "File is not `gofmt`-ed with `-s` (from `gofmt`)" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if it's the right place to do this, but I think it would be a good place to do this. I'm not sure if it's the right place to do this, but I think it would be a good place to do this. I'm not sure if it's the right place to do this, but I think it would be a good place to do this. I'm not sure if it's the right place to do this, but I think it would be a good place to do this. I'm not sure if it's the right place to do this, but I think it would be a good place to do this. I'm not sure if it's the right place to do this, but I think it would be a good place to do this. I'm not sure if it's the right place to do this, but I think it would be a good place to do this. I'm not sure if it's the right place to do this, but I think it would be a good place to do this. I'm not sure if it's the right place to do this", "reference": "This is likely to return an error value if the client fails to read the response we write, which is why I chose to ignore this error." }, { @@ -21755,15 +21755,15 @@ "reference": "this method is not used" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to update the load status after a page finished loading.", + "prediction": "I think it's better to use `self.url().scheme()` instead of `self.url().scheme() == 'https'`.", "reference": "Right now it's a bit unclear that this needs to be called explicitly by the implementing class. If, for example, there's another backend, it won't get this update unless we add the same function as webkit. Could you either add a note to this docstring explaining that this needs to be called, or find some way to automatically trigger this so the webkit override isn't needed (and some override passed on webengine)." }, { - "prediction": "I'm not sure what you mean by \"must drop\" here. I think you meant to say \"must not drop\" or \"must not match\".", + "prediction": "I'm not sure what you mean by \"must drop\" here. I think you meant to say \"must not drop\".", "reference": "Why this change (test name still says \"must pass with metadata\")?" }, { - "prediction": "I think this should be `force_187_p371` instead of `force_187_p372`?", + "prediction": "I'm not sure what you mean by `force_187_p371`", "reference": "Another nitpick: parens around the arg pretty please" }, { @@ -21775,7 +21775,7 @@ "reference": "Oh, I guess I mentioned/pressed this point in the other issue, that this should probably go into the httpserver package. In fact, so should the const above this (URLPathCtxKey). These are specific to the HTTP server." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think you need to do anything here.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.", "reference": "Not added by you, but we don't really need the '5' here.." }, { @@ -21783,11 +21783,11 @@ "reference": "The vendor prefix is still being used on Chromium based browsers like Edge Chromium and Chrome. Did you mean to remove this?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to make this a part of the `EmulateScript` class, so that we don't have to do this every time we create a new `EmulateScript` instance.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make this a class method, so that we don't have to call it every time we want to emulate a gesture.", "reference": "I don't think this is needed anymore?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate helper function for this.", + "prediction": "I'm not sure if this is a good place to do this, but I think it's a good place to do this. I'm not sure if this is a good place to do this, but I think it's a good place to do this. I'm not sure if this is a good place to do this, but I think it's a good place to do this. I'm not sure if this is a good place to do this, but I think it's a good place to do this. I'm not sure if this is a good place to do this, but I think it's a good place to do this. I'm not sure if this is a good place to do this, but I think it's a good place to do this. I'm not sure if this is a good place to do this, but I think it's a good place to do this. I'm not sure if this is a good place to do this, but I think it's a good place to do this. I'm not sure if this is a good place to do this, but I think it's a good place to do this. I'm not sure if this is a good place to do this, but I think it's a good place", "reference": "This is the only occurrence I see in the code where we now need to convert from a boolean protobuf wrapper to a boolean pointer. This felt a little cumbersome here; should we consider moving it somewhere else as a helper function?" }, { @@ -21799,19 +21799,19 @@ "reference": "This could be the cleanest looking check we've got. Great job Jey." }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is the right way to do it.", + "prediction": "I don't think this is necessary.", "reference": "Who invited yoda? In all seriousness though, wouldn't an `if (empty())` be better here?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `dom` module.", + "prediction": "I think this should be `window.location.href = 'index.html';` instead of `require(['appRouter'], function(appRouter) { appRouter.showDirect('/'); });`", "reference": "You can use `appRouter.goHome` to do this (It's defined in site.js), it's less hacky than overriding the href." }, { - "prediction": "I don't think this is a good idea. It's possible that the partId could be the same as the partId of the previous part.", + "prediction": "I don't think we need to remove the part from the engine here. It's already removed from the partIds list.", "reference": "When could this happen?" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to send a POST request with a JSON body, but the response is not 200 or 202.", + "prediction": "I'm not sure what you're trying to do here, but I don't think this is the right place to do it.", "reference": "I assume this was removed because it was redundant? and conflicted with the now dynamic contentType? Edit: Oh I see it being set was moved to the `PostSegmentAsync` call." }, { @@ -21819,39 +21819,39 @@ "reference": "Here is a newline missing" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `travis.yml` file.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `R-4.0-branch.pkg` and a `R-4.1-branch.pkg` in the `mac` directory.", "reference": "Did you mean to make this http rather than https?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea to change the `name` property of a `Button` object.", + "prediction": "I don't think this is necessary.", "reference": "The updated copyright header should be: # Copyright (C) 2006-2018 NV Access Limited, yourname" }, { - "prediction": "I don't think we need to use `null` for `worstStatusCode`.", + "prediction": "I don't think we need to use `null` for `worstStatusCode` because it will always be `null` in this case.", "reference": "wow :+1: , i do not even know how this test works." }, { - "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to have this in the `MvxPlugin.cs` file as well.", + "prediction": "I think it's better to use `MvxPlugin` instead of `IMvxPlugin` in this case. `IMvxPlugin` doesn't have a `Load` method. `MvxPlugin` has a `Load` method. `MvxPlugin` also has a `Unload` method.", "reference": "File should be renamed `PlugIn` -> `Plugin`" }, { - "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to have a separate test for this.", + "prediction": "I'm not sure what you mean by this, but I think it's a good idea to remove the `net` package from this file. It's not used anywhere else in the codebase, and it's not necessary for this test.", "reference": "I scanned the new test cases quickly. Do we have one for an egressIPPool with multiple different IP ranges?" }, { - "prediction": "I'm not sure what you're trying to do with this method, but I think it should be removed.", + "prediction": "I don't think we need to do this.", "reference": "you can use a different name, like `maybe_activate` or `is_active` without `component` in the method name as this is used in the class name. E.g: `$component->should_component_be_active` is using twice the `component` word" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think this is the right place to do it.", + "prediction": "I don't think we need to do this.", "reference": "I think this might not be a complete enough check: what if `options` is `null`/`undefined`?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `flash` element in the page that says \"Now masquerading as #{email}\" when the user clicks on the \"Masquerade\" button.", + "prediction": "I think this should be a test for `flash` instead of `have_flash`?", "reference": "Useless assignment to variable - `user`." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `sh.cmd` instead of `sh.echo` in this case. `sh.echo` is a bit more verbose, and `sh.cmd` is a bit more concise.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `sh.cmd` here.", "reference": "I think we would want to keep `-O` instead. I wonder how this worked before, though." }, { @@ -21859,7 +21859,7 @@ "reference": "another alternate option which doesn't have the risk of too many entries (when user keeps providing keys in different order) Have the dictionary as before If tagKeys lookup fail, sort and lookup again. If fails, insert both original tagKeys and its sorted one to the dictionary. So that we only store atmost 2 entries per key set. And we only do a single lookup in hotpath, as opposed to 2 look ups." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to update the symbol table in the `updateSymbols` method.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to update the symbol table when the plan node is updated.", "reference": "if (out != nullptr)" }, { @@ -21867,19 +21867,19 @@ "reference": "In the listenstore you catch the exception and then pass it on via Raise. However, here you do not catch the exception. You should catch the exception, but since this is a minor aspect of this page, perhaps show an error message when the count cannot be loaded in time. Then the rest of the page can still be rendered, rather than failing the whole page." }, { - "prediction": "I don't think this is needed anymore.", + "prediction": "I don't think we need to add a `new_undo` argument to this method.", "reference": "wouldn't it be simpler to just add `or transfer` here? That way the more complicated set of conditionals down below don't have to get more clauses." }, { - "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea to add this to the `google.cloud.forseti.common.gcp_api` package.", + "prediction": "I think this should be `from google.cloud.forseti.common.gcp_api._base_repository import _base_repository` instead of `from google.cloud.forseti.common.gcp_api import _base_repository`", "reference": "ditto; please fix everywhere" }, { - "prediction": "I'm not sure what the point of this is, but I think it's a good idea to add a `--help` flag to the `fsi` command.", + "prediction": "I'm not sure if this is the best place to put this, but I think it's a good idea to have it in the `fsi` section.", "reference": "Can you break this line into two parts - the first line makes the option help text for `--sftp-server` and its too long! `Specifies the path or command to run a sftp server on the remote host. The subsystem option is ignored when sftp_server is defined.`" }, { - "prediction": "I'm not sure what you mean by \"always_enters_loop\"", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that this is the right place to do this. I think it's a good idea to make sure that this is the right place to do this. I think it's a good idea to make sure that this is the right place to do this. I think it's a good idea to make sure that this is the right place to do this. I think it's a good idea to make sure that this is the right place to do this. I think it's a good idea to make sure that this is the right place to do this. I think it's a good idea to make sure that this is the right place to do this. I think it's a good idea to make sure that this is the right place to do this. I think it's a good idea to make sure that this is the right place to do this. I think it's a good idea to make sure that this is the right place to do this. I think it's a good idea to make sure that this is the right place to do this. I think it's a good idea to make sure that this is the right place to do this. I", "reference": "I reverted that one in a previous PR because of a CI failure but it was actually unrelated" }, { @@ -21899,15 +21899,15 @@ "reference": "Please remove the prints, even though this code will be trashed." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it would be better to use `github.com/projectcalico/felix/dataplane/linux` and `github.com/projectcalico/felix/dataplane/external` instead of `github.com/projectcalico/felix/dataplane/linux` and `github.com/projectcalico/felix/dataplane/external/linux`.", + "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good idea to move it to the `ifacemonitor` package.", "reference": "Not sure if you added deliberately but I've seen these popping up; is goimports adding them?" }, { - "prediction": "I think we can remove the `dst.Spec.NetworkSpec.SecurityGroupOverrides` and `dst.Spec.NetworkSpec.TagSecurityGroups` fields.", + "prediction": "I'm not sure if this is the best place to do this, but I think it's a good idea to make sure that the `SecurityGroupOverrides` and `TagSecurityGroups` fields are set to the same values as the `SecurityGroup` and `TagSecurityGroup` fields.", "reference": "I think we might need some special handling for `Spec.ControlPlaneLoadBalancer.SecurityGroups`, it looks like we are currently only handling the case that `Spec.ControlPlaneLoadBalancer` is nil." }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `pretrained` keyword argument in the `model` dictionary.", + "prediction": "`norm_eval` should be `norm_eval=False` instead of `norm_eval=True`", "reference": "Is this from a third-party library?" }, { @@ -21915,23 +21915,23 @@ "reference": "Please put the `el.tabIndex > -1` in the first part of the expression. The matcher will run on every node on the page, so we should put the fastest part first." }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good idea to move this to the `services` package.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate package for this.", "reference": "`identity` is unused now, is it for future usage?" }, { - "prediction": "I'm not sure what you're trying to do here. I think you want to wrap the response in a `Sensitive` data type, but I'm not sure how to do that. Can you explain what you're trying to do here?", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `unwrap` function to get the raw value of the `Sensitive` data type.", "reference": "This would have assisted me a lot! I am on the \"functions\" page more than any other page in the docs" }, { - "prediction": "I think it's better to remove the `b'c__main__'` and just use `c__main__` instead.", + "prediction": "I don't think this is a good idea. It would be better to use `__file__` instead of `os.path.basename(sys.argv[0]).rsplit('.', 1)[0]`.", "reference": "I think it's better we keep `(` and encode with default encoding (utf-8)." }, { - "prediction": "I'm not sure what you mean by \"necessary\" here. It's not clear to me why this is necessary.", + "prediction": "I'm not sure what you mean by \"necessary\" here. I don't think it's necessary to do this.", "reference": "this is gonna be different in an IDE vs from gradlew??" }, { - "prediction": "I think this is a good idea, but I'm not sure if it's the best way to do it. It would be nice if we had a way to specify the syntax that we want to use, so that we don't have to do this every time we run Spork.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the syntax is set back to the original value after the tests are run.", "reference": "Do we not already have something for isolating syntax?" }, { @@ -21939,19 +21939,19 @@ "reference": "1: D100 Docstring missing 4: I102 copyright year is outdated, expected 2014 but got 2012 158: D103 Docstring missing 168: D101 Docstring missing 170: D102 Docstring missing 180: D102 Docstring missing 187: D102 Docstring missing" }, { - "prediction": "I'm not sure what you mean by \"Denies uploads of objects without server-side AWS KMS encryption to an Amazon S3 bucket.\"", + "prediction": "I'm not sure what you mean by \"Denies uploads of objects without server-side AWS KMS encryption to an Amazon S3 bucket.\" Is this the same as \"Denies uploads of objects without server-side AWS KMS encryption to an Amazon S3 bucket?\"", "reference": "how **to** deny" }, { - "prediction": "I think this should be `Http2ExperimentSwitch` and `Http1AndHttp2ExperimentSwitch` instead of `Switch.Microsoft.AspNetCore.Server.Kestrel.Experiential.Http2` and `Switch.Microsoft.AspNetCore.Server.Kestrel.Experiential.Http1AndHttp2`.", + "prediction": "I don't think this is needed.", "reference": "The only beef I have with this is that it's app domain global." }, { - "prediction": "I think this should be `if err = tc.SetKeepAlivePeriod(3 * time.Minute); err != nil {`", + "prediction": "I think this should be `if runtime.GOOS != \"openbsd\"` instead of `if runtime.GOOS != \"openbsd\"`.", "reference": "Can you link to the GitHub issue and/or PR so that it is easy for future readers to find out more about this?" }, { - "prediction": "I think this should be `if (pAllocateInfo)` instead of `if (pAllocateInfo->pNext)`.", + "prediction": "I think this should be `if (chained_prio_struct && (chained_prio_struct->priority < 0.0f || chained_prio_struct->priority > 1.0f))`", "reference": "Typical to report the value found as well as the valid bounds." }, { @@ -21959,7 +21959,7 @@ "reference": "maybe we want 0 as a default value?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `GetAccountResponse` struct as well.", "reference": "can we get height from sf at very beginning of the function and use that as height of the block?" }, { @@ -21967,27 +21967,27 @@ "reference": "Does this have to be public and in the primary namespace?" }, { - "prediction": "I think this should be `fbo.headLock.Lock(lState)` instead of `fbo.headLock.Unlock(lState)`.", + "prediction": "I think this should be `fbo.log.CDebugf` instead of `fbo.log.CDebugf(ctx, \"Head was already set, aborting\")`", "reference": "I'm a bit confused. Doesn't `mdWriterLock` already synchronizes calls to this function?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `BaseVideoProvider` class as well.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `MediaInterface` class.", "reference": "Does it make sense to generate a dailyMotion url without the video reference? It does not to me, but can we throw an exception here?" }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add a comment to explain what this change does.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add a comment to explain what the change is doing.", "reference": "Why the separation of imports here?" }, { - "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to evaluate the source code, but I'm not sure what you're trying to do with it. It looks like you're trying to evaluate the source code, but I'm not sure what you're trying to do with it. It looks like you're trying to evaluate the source code, but I'm not sure what you're trying to do with it. It looks like you're trying to evaluate the source code, but I'm not sure what you're trying to do with it. It looks like you're trying to evaluate the source code, but I'm not sure what you're trying to do with it. It looks like you're trying to evaluate the source code, but I'm not sure what you're trying to do with it. It looks like you're trying to evaluate the source code, but I'm not sure what you're trying to do with it. It looks like you're trying to evaluate the source code, but I'm not sure what you're trying to do with it. It looks like you're trying to evaluate the source code, but I'm not sure what you're trying to do with it. It looks like you're trying to evaluate the source", + "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to evaluate the source code, but I'm not sure what you're trying to do with it.", "reference": "Random extra newline." }, { - "prediction": "I think it's a good idea to add a check for `isElFocusable` instead of using `dom.isFocusable(el)`.", + "prediction": "I think it's better to return `false` if the node is not focusable, instead of returning an empty array.", "reference": "No need for this variable." }, { - "prediction": "I think this should be `log.js.debug` instead of `log.js.debug()`.", + "prediction": "I think this should be `return ret.replace('\\n', '
    ')` instead of `ret = ret.replace('\\n', '
    ')`", "reference": "Why not use `msg` directly below?" }, { @@ -21995,23 +21995,23 @@ "reference": "I think other places changed to use `Deque` instead of suppressing the warning." }, { - "prediction": "I'm not sure what you're trying to achieve with this change, but it looks like you're trying to remove the `std::vector` and `std::pair` from the `std::ranges::erase` function. Is that what you're trying to do?", + "prediction": "I think this should be `#include ` instead of `#include `.", "reference": "missing: utility, cstddef also: vector is already included in the header (interface requires vectors as in/out types)" }, { - "prediction": "I don't think this is necessary.", + "prediction": "I don't think we need to do this.", "reference": "I'm not sure this is necessary in the config here, as Jest would be setting the global `fetchMock = ''`. See below." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the hashcode of the folder name, and then add that to the hashcode of the message. Is that what you're trying to do?", + "prediction": "I think this should be `result = MULTIPLIER * result + mFolder.getName().hashCode() + mUid.hashCode();`", "reference": "Can `mFolder == null` happen during regular operations? Or is it only so we can be lazy in tests?" }, { - "prediction": "I think this should be `add_column :users, :preferred_email_format, :string, :null => false, :default => \"multipart\"`", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a migration for this.", "reference": "I'd suggest using the actual MIME types here - so `text/plain` and `multipart/alternative` or does that cause problems with what postgres allows for enumeration names? If so then maybe just replace the slash with an underscore?" }, { - "prediction": "I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure", + "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to do this in a single API call.", "reference": "Ohh. `TeamName` is actually a \"friendly\" name displayed in the Catalog - not the name used in the CLI. So I guess we'll need a new variable here. (That is, this is going to be mainly a `quilt.yaml` change. You won't need the `.lower()`, though.)" }, { @@ -22023,19 +22023,19 @@ "reference": "With the current code, it not work if `EnableCatchupFromArchiveServers` is disabled. to fix it: in getDNSAddrs, change the predicate to `if wn.config.EnableCatchupFromArchiveServers || wn.config. EnableCatchupFromArchiveServers {` and in the catchup/service.go and catchup/catchpointService.go, use the `PeersPhonebookArchivers` only when `wn.config.EnableCatchupFromArchiveServers` is enabled." }, { - "prediction": "I'm not sure I understand what you're trying to do here. The `rootNode` is just a pointer to the root node of the merged branch, and the `mergedChains.mostRecentMD.data.Dir.BlockPointer` is just a pointer to the block pointer of the most recent MD in the merged branch. What do you want to do with this?", + "prediction": "I think this is unnecessary. We don't need the `rootNode` here. We can just use the `mergedChains.mostRecentMD.data.Dir.BlockPointer` directly.", "reference": "Why not make `SearchForNodes` do a `GetOrCreate` for the root node? (Not advocating for it, but just wondering if there's another reason than avoiding having to pass in the path.)" }, { - "prediction": "I'm not sure what you're trying to achieve with this code, but it looks like you're trying to start a `P2PNetwork` using the `rlpxAgent` and then start a `DnsDaemon` using the `dnsPeers` field of the `DefaultP2PNetwork` class. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to start a `P2PNetwork` using the `rlpxAgent` and then start a `DnsDaemon` using the `dnsPeers` field of the `DefaultP2PNetwork` class. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to start a `P2PNetwork` using the `rlpxAgent` and then start a `DnsDaemon` using the `dnsPeers` field of the `DefaultP2PNetwork` class. I'm not sure what you're trying to achieve with this code, but it looks like you're trying to start a `P2PNetwork` using the `rlpxAgent` and then start a `DnsDaemon` using the `dnsPeers` field of the `DefaultP2P", + "prediction": "I'm not sure what you're trying to do here. You're starting the `P2PNetwork` but not starting the `DnsDaemon` which is supposed to be started by the `P2PNetwork`.", "reference": ":+1: amazing that this has been missing since it was originally implemented" }, { - "prediction": "I think this should be `getLength()` instead of `getRawDataSize()`.", + "prediction": "I'm not sure if this is a good idea, but I think we should be able to get the length of the file without closing the file. I'm not sure if this is a good idea, but I think we should be able to get the length of the file without closing the file. I'm not sure if this is a good idea, but I think we should be able to get the length of the file without closing the file. I'm not sure if this is a good idea, but I think we should be able to get the length of the file without closing the file. I'm not sure if this is a good idea, but I think we should be able to get the length of the file without closing the file. I'm not sure if this is a good idea, but I think we should be able to get the length of the file without closing the file. I'm not sure if this is a good idea, but I think we should be able to get the length of the file without closing the file. I'm not sure if this is a good idea, but I think we should be able to get the length of the file without closing the file. I'm not sure if this is a good idea, but I think we should", "reference": "Just want to note here that although we do check `length` while writing to choose whether to close and start a new file, that doesn't happen for ORC already so it is fine to use a FS call in this method." }, { - "prediction": "I don't think this is necessary.", + "prediction": "I think this should be `==` instead of `!=`.", "reference": "nit: I feel multiple `if (...) { return ... }` is more readable than `if ... else ...`." }, { @@ -22043,39 +22043,39 @@ "reference": "This is needed for us to work in IDE UTs" }, { - "prediction": "I'm not sure what you mean by \"starred_only\". I think you meant to say `starred` instead of `starred_only`.", + "prediction": "I don't think we need to add `starred_only` to the list of available options.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { - "prediction": "I think we can remove the `user` and `role` fields from the `label` field in the `DisableSecOpt` function. The `user` and `role` fields can be removed from the `label` field in the `label` field in the `DisableSecOpt` function.", + "prediction": "I think we should remove the `user` and `role` fields from the `label` field.", "reference": "this `label=` is docker specific, while here in libcontainer there shouldn't be any mention to docker. `DisableSecOpt` and `DupSecOpt` should just deal with `disable,role,type,level`. Both CRI-O and docker should just pass `disable,role,type.level` stuff and not `label=...`." }, { - "prediction": "I don't think we need to change the `recurse` flag.", + "prediction": "I'm not sure what you mean by \"recurse into the listing.\"", "reference": "You need to declare variable `recurse` above, same place as `localTime`." }, { - "prediction": "I think this should be `xdensity` and `ydensity` instead of `xdensity` and `ydensity=element.xdensity` and `ydensity=element.ydensity`.", + "prediction": "I'm not sure what you mean by `xdensity` and `ydensity` here.", "reference": "Why does `clone` not already copy `xdensity` and `ydensity` from what it is cloning?" }, { - "prediction": "I'm not sure what you're trying to do here. Is it possible that you're trying to add a `MeterSource` to the `meterSources` array? If that's the case, then you need to add a `MeterSource` to the `meterSources` array. Otherwise, you need to add a `MeterSource` to the `meterSources` array and then remove the `MeterSource` from the `meterSources` array.", + "prediction": "I'm not sure what you mean by \"no meter was added to the sdk.\" Could you please clarify?", "reference": "Curious - do we do the same for traces (when no ActivitySource / legacy source are added)? (and why we want to do it for metrics?)" }, { - "prediction": "I think this should be `BaseClkFreq` instead of `BaseClkFreqMHz`?", + "prediction": "I think this should be `BaseClkFreq` instead of `BaseClkFreqMHz`.", "reference": "@aimanrosli23 For the changes in file SdMmcPciHci.c, please make sure that you do not revert the changes made by the below commits: SHA-1: 49accdedf956f175041040e677163b7cbb746283 * MdeModulePkg/SdMmcPciHcDxe: Hook SwitchClockFreq after SD clock start SHA-1: c67617f3c677c342efde780e229f841f4e0f6c7e * MdeModulePkg/SdMmcPciHcDxe: Add retries for sync commands SHA-1: 6d387610855ee27b49cb720de29ed809ea59dadc * MdeModulePkg/SdMmcPciHcDxe: Read response on command completion SHA-1: 63fd7f389874081ea37452b1f" }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to have `webelem.Group.all` in the tests.", + "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `webelem.Group.all` in this case.", "reference": "You'll also need to add `webelem.Group.all` everywhere as that matches as well" }, { - "prediction": "I think this should be `if ($(\"input:radio[name='ncr_proposal[expense_type]']:checked\").val() == 'BA80') {` instead of `if ($(\"input:radio[name='ncr_proposal[expense_type]']:checked\").val() == 'BA80') { $('#ncr_proposal_RWA_number').attr('disabled', false); } else { $('#ncr_proposal_RWA_number').attr('disabled', true); }`", + "prediction": "I think this should be `if ($(\"input:radio[name='ncr_proposal[expense_type]']:checked\").val() == 'BA80') {`", "reference": "Does this need to be an ERB template?" }, { - "prediction": "I think this should be a separate package, so that it can be used by other packages that want to use it.", + "prediction": "I think this should be a separate package, so that we don't have to import it here.", "reference": "do we want to register this in the mock server for testing?" }, { @@ -22087,11 +22087,11 @@ "reference": "The docstring of this context_manager should be updated. As now ``sort=False`` is valid, it should just say it disables sorting regardless of whether the NdMapping has ``sort=True`` or ``sort=False``. I also think the line 'Should only be used if values are guaranteed to be sorted before or after the operation is performed.' should just say something else - maybe just that the initial ordering (whatever it is) should be preserved?" }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to spy on the `Receiver.prototype` and `Receiver` objects, but you're not actually doing anything with them. I think you want to do something like this:\n\n```javascript\nspyAll(Receiver.prototype);\nspyAll(Receiver);\n```\n\nThis will spy on the `Receiver.prototype` and `Receiver` objects, but you'll need to do something with them.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `Receiver` class.", "reference": "This tests failed unless I swapped the order here. Perhaps some new class transform broke the old form?" }, { - "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea to use `get_free_tcp_port()` here.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate class for this.", "reference": "extract the port and set to `debug_java_port`" }, { @@ -22103,59 +22103,59 @@ "reference": "`ctx` is unused in EnablePiped" }, { - "prediction": "I think this should be `self.authenticated = authenticated` instead of `self.authenticated = authenticated`", + "prediction": "I think we should remove the `user` and `authenticated` fields from the `__init__` method.", "reference": "Why do we have both a list of valid sessions and an instance variable if a session is destroyed?" }, { - "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to update the `committedUpTo` field in the `accountUpdates` struct, but I'm not sure what you're trying to do with the `flushcount` map. Can you explain what you're trying to do with this map?", + "prediction": "I'm not sure if this is a good place to put this, but I think we should move it to the `accountUpdates` struct.", "reference": "nit : I think that it would be \"cleaner\" to set the `flushcount` to nil in case of an error nice catch ;-)" }, { - "prediction": "I think this is a bad idea. The `NullRepository` is not a repository, it's just a class that implements the `RepositoryType` interface. If you want to use it as a repository, you need to implement the `RepositoryType#fetchInstallableApplications()` method.", + "prediction": "I think this test should be moved to `org.phoenicis.repository.repositoryTypes.TestNullRepository`", "reference": "You may want to use assertNull" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I think this is a bit of a red herring here. We don't care about the timestamp, we just want to make sure that the span is created and that it's not null.", "reference": "Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs." }, { - "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to create a new `wlr_output` structure, but you're not actually using it. I'm not sure what you're trying to do here. It looks like you're trying to create a new `wlr_output` structure, but you're not actually using it. I'm not sure what you're trying to do here. It looks like you're trying to create a new `wlr_output` structure, but you're not actually using it. I'm not sure what you're trying to do here. It looks like you're trying to create a new `wlr_output` structure, but you're not actually using it. I'm not sure what you're trying to do here. It looks like you're trying to create a new `wlr_output` structure, but you're not actually using it. I'm not sure what you're trying to do here. It looks like you're trying to create a new `wlr_output` structure, but you're not actually using it. I'm not sure what you're trying to do here. It looks like you're trying to create a new `wlr_output` structure, but you're not actually", + "prediction": "I'm not sure if this is a good idea, but I don't think it's a bad idea to use `strncpy` here. I think it's a good idea to use `strncpy` here, but I'm not sure if it's a good idea to use `strncpy` here. I think it's a good idea to use `strncpy` here, but I'm not sure if it's a good idea to use `strncpy` here. I think it's a good idea to use `strncpy` here, but I'm not sure if it's a good idea to use `strncpy` here. I think it's a good idea to use `strncpy` here, but I'm not sure if it's a good idea to use `strncpy` here. I think it's a good idea to use `strncpy` here, but I'm not sure if it's a good idea to use `strncpy` here. I think it's a good idea to use `strncpy` here, but I'm not sure if it's a good idea to use `strncpy` here. I think it's a good idea to use `strncpy` here, but I'm not sure if it's", "reference": "Why did you remove this?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `mapPort` function to map the port to the protocol and the port to the publisher. This way, we don't need to create a new channel for each mapping.", + "prediction": "I think it's better to use `log.Infof` instead of `log.Info` in this case.", "reference": "Why we need another error printouts? We already have it inside addMapping.." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do it here.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the shader code.", "reference": "This LGTM, but I'm curious if this fixed a specific error you were hitting?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. It's a bit of a hack, but it works.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.", "reference": "Actually we rely on this functionality in cgroup v2, where the subsystem is empty." }, { - "prediction": "I think we should use `go.opentelemetry.io/api/registry` instead of `go.opentelemetry.io/api/core`", + "prediction": "I think we should use `go.opentelemetry.io/api/core` instead of `go.opentelemetry.io/api/registry`", "reference": "suggestion: use `core` package name" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a docstring for this function.", + "prediction": "I'm not sure what the point of this is.", "reference": "I think we can entirely remove this `limit` parameter for now to be consistent with other APIs." }, { - "prediction": "I think this should be `start_moto_server('resource-groups', port, name='Resource Groups Tagging API', asynchronous=asynchronous, update_listener=update_listener)`", + "prediction": "I think this should be `start_moto_server('resource-groups-tagging-api', port, name='Resource Groups Tagging API', asynchronous=asynchronous, update_listener=update_listener)`", "reference": "nit: `Resource Groups Tagging API` -> `Resource Groups API`" }, { - "prediction": "I'm not sure what you're trying to achieve with this code. It looks like you're trying to create a new ECR repository, but I'm not sure what you're trying to achieve with this code. Could you please provide more context or explain what you're trying to achieve with this code?", + "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea to use the `base64` package in this case. It's not a good idea to use the base64 package in this case. It's not a good idea to use the base64 package in this case. It's not a good idea to use the base64 package in this case. It's not a good idea to use the base64 package in this case. It's not a good idea to use the base64 package in this case. It's not a good idea to use the base64 package in this case. It's not a good idea to use the base64 package in this case. It's not a good idea to use the base64 package in this case. It's not a good idea to use the base64 package in this case. It's not a good idea to use the base64 package in this case. It's not a good idea to use the base64 package in this case. It's not a good idea to use the base64 package in this case. It's not a good idea to use the base64 package in this case", "reference": "This type of list + delete always make me a bit uneasy but guess there's no atomic way to do this...... Could you put a todo to retry the \"ClearRepository + delete repo\" flow a few times? Basically, imagine a new image is added right after we call `ListImages`, then `DeleteImages` will not delete that newly added image. Then the delete repo call will fail" }, { - "prediction": "I'm not sure what you mean by \"use strict\" in this context.", + "prediction": "I don't think we need to use `scope` in this case.", "reference": "You can remove this since ES6 modules are strict by default. And thanks for contributing to the Jellyfin Project." }, { - "prediction": "60610161565b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b6000", + "prediction": "8b565b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f35b60006000f3", "reference": "Why did eip1559 go from a list (0xf9020280.....) to a wrapped string (0xb902060ff9020280...) and not just concatenation (0x0ff9020280...)? implementation detail or is this how it sits on the wire now?" }, { @@ -22163,39 +22163,39 @@ "reference": "@wallyqs Since on Windows it would be `\\` instead of `/` I just look at the suffix past `configs/`. Let me know if that's ok or not." }, { - "prediction": "I think we can remove the `nil` here.", + "prediction": "I think we should remove the `nil` here.", "reference": "nit: Remove this assignment because it is not necessary." }, { - "prediction": "I'm not sure if this is a good idea, but I think we should be able to use `ot_fd_readall_or_mmap` here.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `ot_file_mapat_bytes` function.", "reference": "This seems like a common enough pattern to offer an equivalent wrapper in `ot-fs-util.c`, no?" }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it's a good idea to have this in the `onCreateOptionsMenu` method, so that it can be toggled by the user.", + "prediction": "I don't think this is necessary.", "reference": "Wouldn't this crash the app if the user is currently listening to a stream?" }, { - "prediction": "I'm not sure what you're trying to do here, but I think we should be able to do this with a single call to `listContainerRoot` instead.", + "prediction": "I'm not sure what you're trying to do here, but I think we should be able to do this with a single call to `listContainerRoot`.", "reference": "This looks like an unrelated change? What is it for?" }, { - "prediction": "I think this should be `atomic.LoadInt64(&d.used)` instead of `atomic.LoadInt32(&d.used)`.", + "prediction": "I think this should be `atomic.LoadInt64(&d.used) != 0` instead of `atomic.LoadInt32(&d.used) != 0`", "reference": "Wait, what is this doing? Is this a way to create methods that are only accessible from tests?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check here to make sure that the namespace is valid before trying to list the metadata.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `canList` in the `list` method.", "reference": "Is it more reasonable to return some errors here, such as returning error codes (403 and so on?) ?" }, { - "prediction": "I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place", + "prediction": "I'm not sure if this is a good place to put it, but I think it would be good to make it a property of the `VNode` class, so that it can be accessed from the `VNode` constructor.", "reference": "Thinking out loud... would `_nextDom` be a better name for this?" }, { - "prediction": "I think we can remove the `return` from the first message, since it's not used anywhere else in the test.", + "prediction": "I think it's better to have a separate test for `return` and `if not` instead of having two separate tests for `return` and `if not` in the same test.", "reference": "Turns out the unittests also had a false positive." }, { - "prediction": "I think we can remove this method as it's not needed anymore.", + "prediction": "I think this should be `CreateDoubleCounter(string name, bool monotonic = true)` instead of `CreateInt64Counter(string name, bool monotonic = true)`.", "reference": "I think these method names would be clearer if written as \"Create a {type} counter|gauge|measure with given name\". eg \"Create a int64 counter with given name\" \"Create a double gauge with given name\"" }, { @@ -22207,7 +22207,7 @@ "reference": "It would be nice to have an equivalent of this call on `DataWriterImpl::enable`" }, { - "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a block that is running, but I don't think that's what you're trying to do here. I think you're trying to create a block that is in the process of being deployed, but I don't think that's what you're trying to do here. I think you're trying to create a block that is running, but I don't think that's what you're trying to do here. I think you're trying to create a block that is in the process of being deployed, but I don't think that's what you're trying to do here. I think you're trying to create a block that is running, but I don't think that's what you're trying to do here. I think you're trying to create a block that is in the process of being deployed, but I don't think that's what you're trying to do here. I think you're trying to create a block that is running, but I don't think that's what you're trying to do here. I think you're trying to create a block that is in the process of being deployed, but I don't think that's what you're trying to do here.", "reference": "Isn't this PENDING?" }, { @@ -22215,59 +22215,59 @@ "reference": "minor detail, why aim to sanitize title if tile is empty (in some cases)? worth adding an && to check for that." }, { - "prediction": "I think we should remove the `QuerySpec` from `ParentChildrenSyncTargetHelper` as it's not needed anymore.", + "prediction": "I think this should be `RelationshipType` instead of `ParentChildrenSyncTargetHelper.RelationshipType`.", "reference": "Code shared by ParentChildrenSyncDownTarget and ParentChildrenSyncUpTarget moved to ParentChildrenSyncTargetHelper" }, { - "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.", + "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. The `available_slots` variable is only set when the `sequential` setting is set to `False`. If the `sequential` setting is set to `True`, then the `available_slots` variable will be set to `sys.maxsize`, which is not what you want.", "reference": "The bug is not about the priority , But we use 2 config items CAPACITY and SEQUENTIAL to control 1 action: thoughput. If 'sequential' is given to 'False' as default in configfile and then I use 'capacity' to 10 in my test.yml , the 'capacity' 's priority should be higher than default 'sequential'. So, I suggest we use only one 'capacity', it is enough. '1' is sequential, more than 1 is capacity, None is sys.maxsize." }, { - "prediction": "I'm not sure what you mean by \"integrate test\" here. I'm not sure what you mean by \"integrate test\" here. I'm not sure what you mean by \"integrate test\" here. I'm not sure what you mean by \"integrate test\" here. I'm not sure what you mean by \"integrate test\" here. I'm not sure what you mean by \"integrate test\" here. I'm not sure what you mean by \"integrate test\" here. I'm not sure what you mean by \"integrate test\" here. I'm not sure what you mean by \"integrate test\" here. I'm not sure what you mean by \"integrate test\" here. I'm not sure what you mean by \"integrate test\" here. I'm not sure what you mean by \"integrate test\" here. I'm not sure what you mean by \"integrate test\" here. I'm not sure what you mean by \"integrate test\" here. I'm not sure what you mean by \"integrate test\" here. I'm not sure what you mean by \"integrate test\" here. I'm not sure what you mean by \"integrate test\" here. I", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `tf.IntegrationTest` decorator.", "reference": "I don't know if I'd call any of these FAST tests integration tests. They are unit tests for FAST. They use a mock plugin which doesn't actually start any external processes, etc." }, { - "prediction": "I don't think we need to change this, but I'm not 100% sure that this is the best way to do it.", + "prediction": "I don't think we need to use `mver.GetVersion()` here. We can just use `version` directly.", "reference": "Can you provide corresponding UT for this." }, { - "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `transporttest` here. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `transporttest` here. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `transporttest` here. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `transporttest` here. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `transporttest` here. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `transporttest` here. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `transporttest` here. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea", + "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to use the `transporttest` package to test the `transport` package, but I'm not sure what you're trying to achieve with this change. It seems like you're trying to use the `transporttest` package to test the `transport` package, but I'm not sure what you're trying to achieve with this change. It seems like you're trying to use the `transporttest` package to test the `transport` package, but I'm not sure what you're trying to achieve with this change. It seems like you're trying to use the `transporttest` package to test the `transport` package, but I'm not sure what you're trying to achieve with this change. It seems like you're trying to use the `transporttest` package to test the `transport` package, but I'm not sure what you're trying to achieve with this change. It seems like you're trying to use the `transporttest` package to test the `transport` package, but I'm not sure what you're trying to achieve with this change. It seems like you're trying to use", "reference": "nit: this should be below the yarpc group" }, { - "prediction": "I don't think this is a good idea. The `prometheus.AlreadyRegisteredError` should be a `prometheus.UnknownError` instead of a `prometheus.AlreadyRegisteredError`.", + "prediction": "I don't think we need to register the label names here.", "reference": "singleCaseSwitch: should rewrite switch statement to if statement (from `gocritic`)" }, { - "prediction": "I think this should be `if err != nil` instead of `if err != nil && retry < 10`", + "prediction": "I think it's better to use `log.WithError(err).Warn(\"Retrying to start Typha\")` instead of `log.WithError(err).Fatal(\"Failed to connect to Typha\")`", "reference": "Please log once here at Error level \"Failed to connect to Typha, will retry...\"" }, { - "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to have a separate test for this.", + "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `false` for `runBpfUnitTest` instead of `true` for `runBpfUnitTest`.", "reference": "Do we need the forXDP parameter in runBpfUnitTest? If not, I think better to revert in order to save a few changes." }, { - "prediction": "I think we can remove the `ascii_letters` and `string.digits` from the `__call__` method.", + "prediction": "I think this should be `ascii_letters + string.digits` instead of `ascii_letters + string.digits + '-_'`", "reference": "So we fix it only for kinto and not for all cliquet resources?" }, { - "prediction": "`byteutil` is not a package, it's just a package name. It should be `github.com/iotexproject/iotex-core/pkg/util/byteutil` instead of `github.com/iotexproject/iotex-core/pkg/util/byteutil`", + "prediction": "`byteutil` is not a package, it's just a package name. `byteutil` should be `github.com/iotexproject/iotex-core/pkg/util/byteutil`", "reference": "No empty line between" }, { - "prediction": "I think we can remove the `if err != nil` check here.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the root directory is set up before we try to create the logs.", "reference": "We have `ResolveRootfs` in `libcontainer/utils` so maybe use that one here?" }, { - "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good idea to have a separate test for this.", + "prediction": "I'm not sure if this is the right place for this test, but I think it should be here.", "reference": "Just curious, do we have positive test covered somewhere?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea.", + "prediction": "I think it's better to use `roots_surface->pending_move_resize_configure_serial == 0` instead of `roots_surface->pending_move_resize_configure_serial == 0 && serial > 0`.", "reference": "Style error, put a space between `if` and `(`" }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it seems like you're trying to disable the SDK's behavior of prefixing request endpoint hosts with modeled information. Is this what you're trying to achieve?", + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `Config` struct, since it's used in both `NewConfig` and `NewEndpointConfig`.", "reference": "It's a bit odd to have a \"disable\" boolean, though it looks like you already do that for a few other flags." }, { @@ -22275,11 +22275,11 @@ "reference": "Why did you pick two hours for this?" }, { - "prediction": "I'm not sure what you mean by \"enter password for new key: \" and \"enter password again: \"", + "prediction": "I'm not sure what you mean by \"enter password for new key: \" and \"enter password again: \" in this context. I'm not sure what you mean by \"enter password (new): \" and \"enter password (again): \" in this context. I'm not sure what you mean by \"enter password (new): \" and \"enter password (again): \" in this context. I'm not sure what you mean by \"enter password (new): \" and \"enter password (again): \" in this context. I'm not sure what you mean by \"enter password (new): \" and \"enter password (again): \" in this context. I'm not sure what you mean by \"enter password (new): \" and \"enter password (again): \" in this context. I'm not sure what you mean by \"enter password (new): \" and \"enter password (again): \" in this context. I'm not sure what you mean by \"enter password (new): \" and \"enter password (again): \" in this context. I'm not sure what you mean by \"enter password (new): \" and \"enter password (again): \" in this context. I'm not sure what you mean by \"enter password (new", "reference": "What about \"enter new password\"? That would be a bit more consistent to the `ReadPasswordTwice` usage in cmd_init." }, { - "prediction": "`winVersion` should be `import winVersion` instead of `from winVersion import winVersion`", + "prediction": "I'm not sure why we need to import `winVersion` here. It's not used anywhere in the code.", "reference": "Another redundant import" }, { @@ -22291,7 +22291,7 @@ "reference": "What is the difference between GraphType and graph_type. Naming should be more accurate." }, { - "prediction": "I don't think you need to use `@var` here. You can just use `$this->em` instead.", + "prediction": "I don't think you need to use `use Shopsys\\FrameworkBundle\\Model\\Product\\Product;` in this case.", "reference": "hmmm in docblock of contructor it is EntityManagerInterface....maybe it should be that way.... :confused:" }, { @@ -22299,15 +22299,15 @@ "reference": "I'm curious why you went the route of adding a new method name for this. Given that you it would be possible to just have an an overload of `GetPos()`, and that this change breaks existing code, I wonder why you chose to go this way." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get the current status of a subscription. I'm not sure what you're trying to do here, but it looks like you're trying to get the current status of a subscription. I'm not sure what you're trying to do here, but it looks like you're trying to get the current status of a subscription. I'm not sure what you're trying to do here, but it looks like you're trying to get the current status of a subscription. I'm not sure what you're trying to do here, but it looks like you're trying to get the current status of a subscription. I'm not sure what you're trying to do here, but it looks like you're trying to get the current status of a subscription. I'm not sure what you're trying to do here, but it looks like you're trying to get the current status of a subscription. I'm not sure what you're trying to do here, but it looks like you're trying to get the current status of a subscription. I'm not sure what you're trying to do here, but it looks like you're trying to get the current status of a subscription. I'm not sure", + "prediction": "I'm not sure what you're trying to do here. I don't think this is the right way to do it.", "reference": "Does this need to change `'active'` to `'Active'` and that? Or is that done in CSS or something?" }, { - "prediction": "I'm not sure what you mean by \"excess streams will be refused\". Is this the same as \"excess streams will be dropped\"?", + "prediction": "I think this should be `MaxAllowedMaxFrameSize` instead of `MaxAllowedMaxFrameSize = 16 * 1024 * 1024 - 1`", "reference": "Why are these constants public? They should also be listed above members." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to check the v value if this is a private transaction. If it's not a private transaction, then we don't need to check the v value.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this.", "reference": "This TODO isn't related to this change. We should remove it." }, { @@ -22315,11 +22315,11 @@ "reference": "`FieldMetrics` is parameterized, but this is a bare reference. Could you update it? I think it should be `FieldMetrics` since the metrics are not necessarily for the written value type, `D`." }, { - "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a MeterProvider, but you're not actually using it.", + "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea to add this to the `MeterProviderBuilder` so that it can be used by any library that wants to use OpenTelemetry metrics.", "reference": "@cijothomas do we want this to be `Set` or `Add`?" }, { - "prediction": "I'm not sure what you mean by \"Buffer Responses\" in this context. It's not clear to me what you're trying to do here.", + "prediction": "I don't think this is needed anymore.", "reference": "Why are we dropping GasCap?" }, { @@ -22327,23 +22327,23 @@ "reference": "should we end the text with a .?" }, { - "prediction": "I think this should be `check_should_be_protected` instead of `check_should_be_protected(DATASEC_RARELY_PROT)`.", + "prediction": "I think this should be `if (dcontext->go_native && wherewasi == DR_WHERE_DISPATCH)` instead of `if (dcontext->go_native && wherewasi == DR_WHERE_DISPATCH)`", "reference": "Could this instead keep the `go_native` and add to it \"or the last exit was the special reset exit\"?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a button in the dialog that allows the user to save the current settings and then close the dialog. This way, the user doesn't have to worry about saving the settings again when they come back to the dialog.", + "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to call `accept()` here.", "reference": "Oh, I missed this one: The other instances of `this` you've added as lambda contexts aren't really needed, although they're harmless. However, in the above connection, the missing context is `panel`, not `this`. Please correct it! Clazy may show warnings about lambda contexts (I don't use Clazy) but, if so, that's a problem in clazy: it isn't smart enough to know about them." }, { - "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to use `__del__` instead of `__init__` in this case. `__init__` is called when the object is created, and `__del__` is called when the object is destroyed. `__init__` is called when the object is created, and `__del__` is called when the object is destroyed. `__init__` is called when the object is created, and `__del__` is called when the object is destroyed. `__init__` is called when the object is created, and `__del__` is called when the object is destroyed. `__init__` is called when the object is created, and `__del__` is called when the object is destroyed. `__init__` is called when the object is created, and `__del__` is called when the object is destroyed. `__init__` is called when the object is created, and `__del__` is called when the object is destroyed. `__init__` is called when the object is created, and `__del__` is called when the object is destroyed. `", + "prediction": "I don't think this is a good idea. The `__del__` method is called when the object is garbage collected, and it's not a good idea to stop the process.", "reference": "can we add a try / except around this to make it more stable? I like the idea of any mistakenly un-quit drivers closing down after the process is quit (the java server does this... also i forget to do driver.quit often when i use the command line repl :) )" }, { - "prediction": "I think we should be able to use `json.NewDecoder(r.Body).Decode(statusReq)` instead of `json.NewDecoder(r.Body).Decode(statusReq); err := json.NewDecoder(r.Body).Decode(statusReq); err != nil`", + "prediction": "I think we should use `json.NewDecoder(r.Body).Decode(statusReq)` instead of `json.NewDecoder(r.Body).Decode(statusReq); err := json.NewDecoder(r.Body).Decode(statusReq); err != nil`", "reference": "when would this happen? backward compatibility?" }, { - "prediction": "I think this should be `node.tagName.toLowerCase()` instead of `node.tagName.toLowerCase()`.", + "prediction": "I think this should be `if (node.tagName)` instead of `if (node.namespaceURI === 'http://www.w3.org/1999/xhtml')`", "reference": "I'm not sure what the value of this is. So far we've solved this by always doing `tagName.toUpperCase()` for everything. I think we should stick with this." }, { @@ -22351,11 +22351,11 @@ "reference": "This command displays available snapshots on a volume." }, { - "prediction": "I'm not sure I understand what you're trying to do here. What is the purpose of the `spb` and `stpb` types?", + "prediction": "I'm not sure what you're trying to do here. I think you're trying to use the `spb` and `stpb` types in a way that doesn't make sense, but I'm not sure what you're trying to do with the `spb` and `stpb` types. I'm not sure what you're trying to do with the `spb` and `stpb` types. I'm not sure what you're trying to do with the `spb` and `stpb` types. I'm not sure what you're trying to do with the `spb` and `stpb` types. I'm not sure what you're trying to do with the `spb` and `stpb` types. I'm not sure what you're trying to do with the `spb` and `stpb` types. I'm not sure what you're trying to do with the `spb` and `stpb` types. I'm not sure what you're trying to do with the `spb` and `stpb` types. I'm not sure what you're trying to do with the `spb` and `stpb` types. I'm not sure what you're trying to", "reference": "`spb` is the standard package name we use for this proto." }, { - "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to change the context of the caller to the specified window. I'm not sure what you're trying to do here, but it looks like you're trying to change the context of the caller to the specified window. I'm not sure what you're trying to do here, but it looks like you're trying to change the context of the caller to the specified window. I'm not sure what you're trying to do here, but it looks like you're trying to change the context of the caller to the specified window. I'm not sure what you're trying to do here, but it looks like you're trying to change the context of the caller to the specified window. I'm not sure what you're trying to do here, but it looks like you're trying to change the context of the caller to the specified window. I'm not sure what you're trying to do here, but it looks like you're trying to change the context of the caller to the specified window. I'm not sure what you're trying to do here, but it looks like you're trying to change the context of the caller to the specified window. I'm not sure what you're trying", + "prediction": "I'm not sure if this is the right place to do this, but I think it would make sense to have a `switchToWindow` method in the `CommandProcessor` class, and then call it from the `execute` method.", "reference": "/javascript/firefox-driver is the Selenium implementation of a WebDriver for Firefox. Since it generally isn't W3C compatible, it shouldn't change. We can just drop this change." }, { @@ -22367,39 +22367,39 @@ "reference": "Based on the assumption that when `EnablePulls` is `true`, `CanEnablePulls` must be `true` as well, then this `if` check is redundant. Actually... we have `AllowsPulls` now... why not use that?" }, { - "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. Is it that you're trying to get the flow name from the project name? Or is it that you're trying to get the project name from the flow name? Or is it that you're trying to get the flow name from the project name? Or is it that you're trying to get the project name from the flow name? Or is it that you're trying to get the flow name from the project name? Or is it that you're trying to get the project name from the flow name? Or is it that you're trying to get the flow name from the project name? Or is it that you're trying to get the project name from the flow name? Or is it that you're trying to get the flow name from the project name? Or is it that you're trying to get the project name from the flow name? Or is it that you're trying to get the flow name from the project name? Or is it that you're trying to get the project name from the flow name? Or is it that you're trying to get the flow name from the project name? Or is it that you're trying to get the project name", + "prediction": "I don't think we need to do this.", "reference": "I am not sure why the API requires both project name and project ID as inputs. Wouldn't it introduce more opportunities for clients to make mistakes?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `proposal` model, so that it can be used in other parts of the system as well.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `flash.now[:warning]` instead of the `flash[:warning]` in this case.", "reference": "I believe this was happening for several different flash messages - should we add `now` to all flash messages? (there might be a downside to doing that, but I am not sure what it would be)" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `KernelExceptionListener` class.", + "prediction": "I don't think this is needed anymore.", "reference": "There is no docblock on the parent method. Also, not related, but I forgot to typehint the `$templating` constructor argument above." }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the", + "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a check for arm64 builds in the deb.sury.org package.", "reference": "Silly me. This shouldn't be done in the tests, but instead in the actual definition of ValidPHPVersions on arm64. Same with Mysql and MariaDB." }, { - "prediction": "I'm not sure what you mean by \"intersects\" in this case.", + "prediction": "I'm not sure what you mean by \"intersects\" in this case. I think you meant to say that the query intersects the bounding box of the triangle.", "reference": "Shouldn't this work as well for Disjoint?" }, { - "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I think it would be a good place to do this. I think it would be a good place to do this. I think it would be a good place to do this. I think it would be a good place to do this. I think it would be a good place to do this. I think it would be a good place to do this. I think it would be a good place to do this. I think it would be a good place to do this. I think it would be a good place to do this. I think it would be a good place to do this. I think it would be a good place to do this. I think it would be a good place to do this. I think it would be a good place to do this. I think it would be a good place to do this. I think it would be a good place to do this. I think it would be a good place to do this. I think it would be a good place to do this. I think it would be a good place to do this. I think it would be a good place to do this. I", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `updateOrderStatus` method.", "reference": "You've not updated the `o.Status.Reason = fmt.Sprintf(\"Failed to retrieve Order resource: %v\", err)` line below here when you changed this, so here we are checking `errUpdate` but will print the contents of `err` instead." }, { - "prediction": "I think it's a good idea to add `timeout` and `interval` to the `initialize` method.", + "prediction": "I think it's better to have `NOT_CONNECTED_ERRORS` as an array of `Errno` objects instead of `Errno::ECONNREFUSED` and `Errno::ENOTCONN`.", "reference": "Doesn't this need to include `Errno::ECONNRESET` to fix the issue?" }, { - "prediction": "I think this should be `azkaban.project_cache_size_percentage_of_disk` instead of `azkaban.project_cache_size_percentage_of_disk_of_disk`.", + "prediction": "I think this should be `AZKABAN_PROJECT_CACHE_SIZE_PERCENTAGE` and `AZKABAN_PROJECT_CACHE_THROTTLE_PERCENTAGE`", "reference": "Please consider keeping the config key in one line as it will help in case someone is looking at how this config is used. public static final String PROJECT_CACHE_THROTTLE_PERCENTAGE = \"azkaban.project_cache_throttle_percentage\";" }, { - "prediction": "I think we should remove the `*common.Empty` from `RegisterToken` as it's not used anywhere.", + "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `DataStore` interface.", "reference": "This is a hard one, naming-wise... `ListPowerSelectorEntries` is logical given `ListSelectorEntries`. Another option could be `ListMatchingEntries` or even `FindMatchingEntries`. :shrug:" }, { @@ -22407,7 +22407,7 @@ "reference": "This should be called `Uint` or `Uint32` or simply using our `Uint64` type instead. All of our numbers have varint encoding. It's not inherently a varint." }, { - "prediction": "I'm not sure if this is a good idea, but I think it would be a good idea to add a `pygment` argument to the `view_source` command.", + "prediction": "I don't think this is a good idea. I think it's better to use the `pygmentize` command to do this.", "reference": "No need for this when you don't need to customize anything about the argument." }, { @@ -22423,23 +22423,23 @@ "reference": "Mention that it only applies to Windows. This is kind of implied, but better to be explicit." }, { - "prediction": "I don't think this is a good idea. It's not clear to me what the purpose of this test is. It's not clear to me what the purpose of this test is. It's not clear to me what the purpose of this test is. It's not clear to me what the purpose of this test is. It's not clear to me what the purpose of this test is. It's not clear to me what the purpose of this test is. It's not clear to me what the purpose of this test is. It's not clear to me what the purpose of this test is. It's not clear to me what the purpose of this test is. It's not clear to me what the purpose of this test is. It's not clear to me what the purpose of this test is. It's not clear to me what the purpose of this test is. It's not clear to me what the purpose of this test is. It's not clear to me what the purpose of this test is. It's not clear to me what the purpose of this test is. It's not clear to me what the purpose of this test is. It's not clear to me what the purpose of this test is. It's not clear to me what the", + "prediction": "I don't think we need to use `uint64(10)` for `autoStake`.", "reference": "again: it is a bad practice to have some global parameters with such common names for unit test purpose." }, { - "prediction": "I don't think you need to use `__construct` here. You can just use `Shopware6Connector::__construct(Configurator $configurator)`.", + "prediction": "I don't think this is necessary. The `expiresAt` property should be a `DateTimeInterface` and not a `DateTime` object.", "reference": "Should we use `\\DateTimeInterface` or `DateTimeInterface` and declaration of `DateTimeInterface` in `use`?" }, { - "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the task stack name as the name of the stack. That way, we don't have to worry about the name of the task stack.", + "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it", "reference": "What do you think of moving this stack related constant to the `stack` pkg?" }, { - "prediction": "I think we can remove the `proto.SupportRekeying` check here.", + "prediction": "I think this should be `if s.AuthAddr != basics.Address{` instead of `if s.Txn.Src() == zeroAddress {`", "reference": "Hm, I guess that you're doing this here since `WellFormed` is on a `transactions.Transaction` and not a `transactions.SignedTxn`, but quickly grepping through our code, it looks like we always a `SignedTxn` around when calling `WellFormed` (except maybe some tests?)... this doesn't have to happen here, but maybe we should update that in a separate PR since this really feels like a `WellFormed` check." }, { - "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to use the `WithTestRegistry` decorator to wrap the `` component in a `WithTestRegistry` component. However, there are a few issues with this approach:\n\n1. The `` component is not being wrapped in a `WithTestRegistry` component.\n2. The `WithTestRegistry` decorator is not being used to wrap the `` component.\n3. The `WithTestRegistry` decorator is not being used to wrap the `WithTestRegistry` component.\n4. The `WithTestRegistry` decorator is not being used to wrap the `WithTestRegistry` component.\n5. The `WithTestRegistry` decorator is not being used to wrap the `WithTestRegistry` component.\n6. The `WithTestRegistry` decorator is not being used to wrap the `WithTestRegistry` component.\n7. The `WithTestRegistry` decorator is not being used to wrap the `WithTestRegistry` component.\n8. The `WithTestRegistry` decorator is not being used to wrap the `WithTestRegistry` component.\n9. The `WithTestRegistry` decorator is not being", + "prediction": "I'm not sure what you mean by \"padding\" here. I think you meant to say `padding: 10px;`", "reference": "This story also needs the default padding." }, { @@ -22447,11 +22447,11 @@ "reference": "Hmm why did we remove the randomness about which (confusingly) different exception to throw here? This randomness was (is?) useful to help test that Lucene indeed catches `FNFE` and `NSFE` interchangeably." }, { - "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `glnx_opendirat` here.", + "prediction": "I'm not sure if this is the right place to do this, but I think it would be better to do this in `ostree_repo_list_collection_refs` instead of `ostree_repo_list_collection_refs_iter`.", "reference": "Hm, so before in that case `current_collection_id` looks like it was actually an uninitialized pointer. It seems weird to me that the tests pass both ways. I haven't looked closely at the tests - is there something wrong there that causes this to spuriously pass before?" }, { - "prediction": "I don't think this is a good idea. I think it should be `K_UNDEFINED` instead of `KEYWORD_NONE`.", + "prediction": "I don't think we need to change `K_UNDEFINED` to `KEYWORD_NONE` in this case.", "reference": "s it the best way to tag \"foo\" of \"`define foo ...\" with constant kind? Introducing \"d/definition\" kind and tagging the \"foo\" with the definition kind is an alternative way. Using the unified kind \"constant\" in many areas reduces the information that client tools get from a tags file. In my experience, it is better to tag different things with different kinds. If ctags hides the differences, and just reports various language objects as \"constant,\" in some cases, a client tool must parse the raw .sv source file for distinguishing whether a given tag is \"`define\"'ed or not. IMHO, ctags should not be too smart. Instead, ctags should be stupid; it should report what it sees in source input files as-is to client tools that will do something smart." }, { @@ -22459,7 +22459,7 @@ "reference": "is this a breaking change? If I'm not mistaken, this is translating a user-provided `wtimeout` in the connection string into `wTimeoutMS`" }, { - "prediction": "I think this should be `print(event)` instead of `print('{}'.format(json.dumps(event)))`", + "prediction": "I don't think we need to do this. We can just use the `event` object directly.", "reference": "Can we rename this file to `lambda_echo.py`, to be more descriptive and in line with the other files in this directory? (all files in this folder are lambda functions, after all)" }, { @@ -22467,35 +22467,35 @@ "reference": "why not do it like this ? 

     const ( Kill Action = iota Errno Trap Allow Trace ) 
    "
     },
     {
-      "prediction": "I think this should be `lock(this)` instead of `for (int i = 0; i < this.appenders.Length; ++i)`.",
+      "prediction": "I don't think we need to lock here.",
       "reference": "lock(this) is a bad practise, since you lock the entire instance. cosider: var appenderCache = xxxx. lock(appenderCache) { Thread.Sleep(TimeSpan.FromHours(5)); } while inside AppenderCache instance lock(this) { is blocked 5 hours. } Its always better to make a class private lock objects."
     },
     {
-      "prediction": "I'm not sure what you mean by this, but I think it's a good idea to use the `WithEncoding` method to specify the encoding for the `ClientConfig` and `grpcClientConn`.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `NewContextWrapper` for the `grpcheader.NewContextWrapper` and `grpcheader.NewContextWrapper().WithCaller(serviceName + \"-client\").WithService(serviceName).WithEncoding(\"proto\")` instead of `grpcheader.NewContextWrapper().WithCaller(serviceName + \"-client\").WithService(serviceName).WithEncoding(\"proto\")`.",
       "reference": "should we use the constant above?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `os_get_file_size_by_handle` function.",
+      "prediction": "I think this should be `ASSERT(result && \"bad file handle?\");` instead of `ASSERT(res && \"bad file handle?\");`",
       "reference": "I think something like `size_res` would be more descriptive."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to move this to the `Bolt::Event` class.",
       "reference": "Oh lol so this was...really more of a bug?"
     },
     {
-      "prediction": "I think this should be `PlatformTaskEx.FromResult(object result)` instead of `PlatformTaskEx.FromResult(object result)`?",
+      "prediction": "I think this should be `PlatformTaskEx.FromResult(object result)` instead of `PlatformTaskEx.FromResult(object result)`",
       "reference": "Well, it is providing a platform neutral way of calling Task or TaskEx. We could just call it PlatformTask."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a `wlr_xwayland` object from a pointer to a `wlr_xwayland_server` structure. I'm not sure what you're trying to do here, but it looks like you're trying to create a `wlr_xwayland` object from a pointer to a `wlr_xwayland_server` structure. I'm not sure what you're trying to do here, but it looks like you're trying to create a `wlr_xwayland` object from a pointer to a `wlr_xwayland_server` structure. I'm not sure what you're trying to do here, but it looks like you're trying to create a `wlr_xwayland` object from a pointer to a `wlr_xwayland_server` structure. I'm not sure what you're trying to do here, but it looks like you're trying to create a `wlr_xwayland` object from a pointer to a `wlr_xwayland_server` structure. I'm not sure what you're trying to do here, but it looks like you're trying to create a `wlr_xwayland` object from",
+      "prediction": "I think this should be `if (xwayland->server == NULL)` instead of `if (xwayland->server == NULL) { free(xwayland->server); }`",
       "reference": "Typo: this should free `xwayland` instead"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this code. It looks like you're trying to generate a random ping-pong sequence, but I'm not sure what you're trying to achieve with this code. Could you please provide more context or explain what you're trying to achieve with this code?",
+      "prediction": "I don't think we need to use `math/rand` here. We can use `crypto/rand` instead. Also, I don't think we need to use `hex` here. We can use `crypto/rand` instead. Also, I don't think we need to use `math/rand` here. We can use `crypto/rand` instead. Also, I don't think we need to use `hex` here. We can use `crypto/rand` instead. Also, I don't think we need to use `math/rand` here. We can use `crypto/rand` instead. Also, I don't think we need to use `hex` here. We can use `crypto/rand` instead. Also, I don't think we need to use `math/rand` here. We can use `crypto/rand` instead. Also, I don't think we need to use `hex` here. We can use `crypto/rand` instead. Also, I don't think we need to use `math/rand` here. We can use `crypto/rand` instead. Also, I don't think we need to use `hex` here. We can use `crypto/rand` instead. Also, I don't think we need to use `math/rand",
       "reference": "Is it ok to use \"math/rand\" instead of \"crypto/rand\" here? Do we need to protect this ID somehow?"
     },
     {
-      "prediction": "`logxi` should be `log` instead of `logxi`",
+      "prediction": "`logxi` should be `log` instead of `logxi` because `logxi` is an alias for `log`",
       "reference": "Why did we have `logxi` in the first place? Maybe it makes sense to remove it from `glide.lock? It will safe us in the future from using logger which is not working."
     },
     {
@@ -22503,7 +22503,7 @@
       "reference": "Is there a reason to use `getUNF()` and `UNF` in the same block?"
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear what you're trying to test here. I'm not sure what you're trying to test here. I'm not sure what you're trying to test here. I'm not sure what you're trying to test here. I'm not sure what you're trying to test here. I'm not sure what you're trying to test here. I'm not sure what you're trying to test here. I'm not sure what you're trying to test here. I'm not sure what you're trying to test here. I'm not sure what you're trying to test here. I'm not sure what you're trying to test here. I'm not sure what you're trying to test here. I'm not sure what you're trying to test here. I'm not sure what you're trying to test here. I'm not sure what you're trying to test here. I'm not sure what you're trying to test here. I'm not sure what you're trying to test here. I'm not sure what you're trying to test here. I'm not sure what you're trying to test here. I'm not sure what you're trying to test here. I'm not sure what you",
+      "prediction": "I don't think this is a good idea. We should be able to use `ast.RegexMatchOperator` instead of `ast.RegexOperator` in this case.",
       "reference": "Again this seems odd that megacheck cares"
     },
     {
@@ -22515,47 +22515,47 @@
       "reference": "I looks like we can make `allowOptionalMappings` non-optional since we have another overload without it. (I thought this generated a compiler warning, but maybe it's just R#)"
     },
     {
-      "prediction": "I don't think it's necessary to specify `init_cfg` here, since `conv_cfg` and `norm_cfg` are already defined in the `BaseModule` class.",
+      "prediction": "I don't think we need to specify `init_cfg` here. We can just use `None` here.",
       "reference": "` per scale.` -> ` per scale.` need to clean the unnecessary blank space"
     },
     {
-      "prediction": "I'm not sure what you mean by \"L: 421\". I think you meant \"L: 100000\".",
+      "prediction": "I'm not sure what you mean by \"L: 421\". I think you meant \"L: 100000\" or \"L: 1000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
       "reference": "there's no import for Export"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to register the node API and the registration API with the TCP and UDS servers. I'm not sure what you're trying to do here, but it looks like you're trying to register the node API and the registration API with the TCP and UDS servers. I'm not sure what you're trying to do here, but it looks like you're trying to register the node API and the registration API with the TCP and UDS servers. I'm not sure what you're trying to do here, but it looks like you're trying to register the node API and the registration API with the TCP and UDS servers. I'm not sure what you're trying to do here, but it looks like you're trying to register the node API and the registration API with the TCP and UDS servers. I'm not sure what you're trying to do here, but it looks like you're trying to register the node API and the registration API with the TCP and UDS servers. I'm not sure what you're trying to do here, but it looks like you're trying to register the node API and the registration API with the TCP and UDS servers. I'm not sure",
+      "prediction": "I'm not sure I understand what you mean by \"registerNodeAPI\" and \"registerRegistrationAPI\". Could you please provide more context?",
       "reference": "i don't think we want/need to make the node API available over UDS"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to get the article by its ID, but you're not using the `getById` or `findById` methods. I think you're trying to get the article by its ID, but you're not using the `getById` or `findById` methods. I think you're trying to get the article by its ID, but you're not using the `getById` or `findById` methods. I think you're trying to get the article by its ID, but you're not using the `getById` or `findById` methods. I think you're trying to get the article by its ID, but you're not using the `getById` or `findById` methods. I think you're trying to get the article by its ID, but you're not using the `getById` or `findById` methods. I think you're trying to get the article by its ID, but you're not using the `getById` or `findById` methods. I think you're trying to get the article by its ID, but you're not using the `getById` or `findById` methods. I think you're trying to get the article by its ID",
+      "prediction": "I don't think this is necessary.",
       "reference": "How about to skip if and returning null and return a result of `ArticleFacade::findById` directly?"
     },
     {
-      "prediction": "I think this should be `push.apply(this, arguments)` instead of `Array.prototype.push.apply(this, arguments)`.",
+      "prediction": "I think this should be `push.apply(this, arguments)` instead of `push.apply(this, Array.prototype.map.apply(this, arguments))`.",
       "reference": "I think this change is currently unnecessary. I like the idea of `map()`, `filter()`, etc. returning vanilla JavaScript arrays rather than mongoose arrays, but I think that's a bit too heavy of a change for a patch release. I think that all we need for this release is the `if (!parent || parent.$__.populated == null) return;` change."
     },
     {
-      "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to add a `version` method to the `Travis` class. This way, we can use `version` as a way to get the current version of the `Travis` class.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `version` method in the `Travis` module.",
       "reference": "how about \"unknown\" instead of \"fafafaf\"?"
     },
     {
-      "prediction": "Shouldn't this be `func ActorGetSignature(ctx context.Context, actorAddr address.Address, method string) (_ *exec.FunctionSignature, err error)`, not `func ActorGetSignature(ctx context.Context, actorAddr address.Address, method string) (_ *exec.FunctionSignature, err error)`?",
+      "prediction": "Shouldn't this be `func ActorGetSignature(ctx context.Context, actorAddr address.Address, method string) (_ *exec.FunctionSignature, err error)`, or should it be `func ActorGetSignature(ctx context.Context, actorAddr address.Address, method string, signature *exec.FunctionSignature) (_ *exec.FunctionSignature, err error)`?",
       "reference": "nit: do we gain anything from naming the output error `err` in this definition?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"foreign element\". Is it something like a `div` or `span` that is not part of the DOM tree?",
+      "prediction": "I think it's better to call `blur` on `document.activeElement` instead of `document.activeElement.blur()`.",
       "reference": "This can happen with any dialog. Maybe the best place to add this change would be the dialog component instead."
     },
     {
-      "prediction": "I'm not sure what you mean by \"Enable JSON logs\" in this context. I think you meant to say \"Enable JSON logging\" or something like that.",
+      "prediction": "I'm not sure what you mean by `dumpEnvOutputOnFail`? I think you meant to say `dumpEnvOutputOnFail(t, env.Processes())`",
       "reference": "Should this be `TearDown` since it now calls this method? Something I would like to see is, on test failure don't teardown completely instead leave the FAST repo in place with the stderr and stdout files and direct the user to that location. What do you think?"
     },
     {
-      "prediction": "I think this should be `MetricNegLogLikelihood` instead of `MetricNegLogLikelihoodMetric`.",
+      "prediction": "I think this should be `MetricMulti` instead of `MetricNegLogLikelihood`.",
       "reference": "There's not particular reason to use a short name. Can we use a more descriptive name for the metric? Perhaps \"negativeLogLikelihood\"?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check for `isType (token, TOKEN_OPEN_PAREN)` in the `skipArgumentList` function. This way, we don't need to check for `isType (token, TOKEN_EOF)` in the `skipArgumentList` function.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `isType (token, TOKEN_OPEN_PAREN)` and `isType (token, TOKEN_CLOSE_PAREN)`. This way, we don't need to check for `isType (token, TOKEN_EOF)` in the `skipArgumentList` function.",
       "reference": "not handling in case of `repr` makes the behavior probably a little too unpredictable. Is there a reason not to, apart missing stuff in the `repr`? Does it lead to some problem?"
     },
     {
@@ -22563,39 +22563,39 @@
       "reference": "Remove the finally?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think this is the right way to do it. You should be able to use `FindFirstFile` and `FindNextFile` to check for the existence of a file.",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `WCHAR*` instead of `TCHAR*` in this case.",
       "reference": "Build on AArch64 fails because WCHAR is not defined."
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear to me what the purpose of this test is. Is it to make sure that the `rdws-template` command works? Or is it to make sure that the `rdws-manifest` and `rdws-stack` commands work?",
+      "prediction": "I don't think this is a good idea. It's not clear what `envName` is supposed to be used for, and it's not clear what `manifestFileName` and `stackTemplateFileName` are supposed to be used for. It's also not clear what `envName` is supposed to be used for. It's not clear what `manifestFileName` and `stackTemplateFileName` are supposed to be used for. It's also not clear what `envName` is supposed to be used for. It's not clear what `manifestFileName` and `stackTemplateFileName` are supposed to be used for. It's also not clear what `envName` is supposed to be used for. It's not clear what `manifestFileName` and `stackTemplateFileName` are supposed to be used for. It's also not clear what `envName` is supposed to be used for. It's not clear what `manifestFileName` and `stackTemplateFileName` are supposed to be used for. It's also not clear what `envName` is supposed to be used for. It's not clear what `manifestFileName` and `stackTemplateFileName` are supposed to be used for. It's also not clear what `envName` is supposed",
       "reference": "Do we use this const?"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a `SetAnnotations` method to the `CertificateRequestModifier` struct.",
+      "prediction": "I'm not sure if this is a good idea, but I think it's better to use `SetAnnotations` instead of `SetAnnotationsMap` in this case.",
       "reference": "I think this may need to be `SetCertificateRequestAnnotations` as it returns a `CertificateRequestModifier`"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a good idea to have a `User::Identifier` class that can be used to get a `UserIdentifier` for a given scheme.",
+      "prediction": "I think this should be `UserIdentifier` instead of `UserIdentifierScheme`?",
       "reference": "it would likely be better to do this in the Identifier.by_scheme_name method itself."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but I think it's better to use the `created_at` and `changed_at` fields instead of the `created` and `changed` fields.",
+      "prediction": "I don't think we need to do this. The `created` and `changed` fields are the same, so we don't need to sort by either of them.",
       "reference": "@janette looking at this test code, I'm pretty sure that it's going to give a false positive. Where is it actually checking the contents of the first four datasets against expected values? All the assertion at the end of the test seems to check is that at least four datasets exist."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
+      "prediction": "I don't think we need to add `app` to the `outputPaths` since it's already defined in the `ember-cli-build.js` file.",
       "reference": "Would this break things if Ghost is run in a subdirectory or no?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `proposal_update_recorder.rb` file.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this",
       "reference": "maybe switch the order in order to make this a positive assertion instead of a negative one? i.e. `if key =~ /id/` first."
     },
     {
-      "prediction": "I'm not sure what you mean by \"Expected Conditions\" in this context. What do you mean by \"Canned\" and \"General\" in this context?",
+      "prediction": "I'm not sure what you mean by \"Expected Conditions\" in this context. What do you mean by \"Expected Conditions\" in this context?",
       "reference": "Is this an oversight for some code in the body?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to set the `state` in the `onActivityResult` instead of doing it in the `onSaveInstanceState` method.",
+      "prediction": "I don't think we need to do this.",
       "reference": "Reason for adding this? I couldn't find where you are retrieving it back."
     },
     {
@@ -22603,27 +22603,27 @@
       "reference": "Can we expect adequate information emitted to the log in case either requiring preloads.rb or doing the requires in preloads.rb fails? If the answer is yes, I think we can merge this PR right away."
     },
     {
-      "prediction": "I think this should be `PagesController` instead of `PagesController < HighVoltage::PagesController`",
+      "prediction": "I don't think this is necessary. The `PagesController` is already defined in `app/controllers/application_controller.rb`, so we don't need to create a new one.",
       "reference": "How about a `app/views/layouts/pages.html.erb` layout that contains the HTML head, body, wrappers and yield's the `new-topics` template into it? I think we might be able to delete the `app/controllers/pages_controller.rb` file at that point."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea.",
+      "prediction": "I think it's better to use `this.$__.selected` instead of `this.$__.selected == null`.",
       "reference": "This is a coarse solution. This check is helpful, but you should also add a check in `$__version()` to avoid calling `isSelected()` if `key === false`"
     },
     {
-      "prediction": "I think we should remove the `model.ApplicationGitPath` and `model.DeploymentTrigger` fields as they are not used anymore.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `Deployment` struct.",
       "reference": "Passing only needed data to make it can be reused by `planpreview` package where there is no deployment data."
     },
     {
-      "prediction": "I'm not sure what you mean by \"deep copy\" in this context. I think you meant to say \"clone\" instead.",
+      "prediction": "I'm not sure what you mean by \"deep copy\" here. I think you meant to say \"clone\" or something like that.",
       "reference": "Could we rename those to `CustomClientAuthentication` (same for Router) to remove ambiguity between Authentication and Authorization (permissions)?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"ShowPlatformHost\". Is it supposed to be `ShowPlatformHost(Type hostViewModel)`?",
+      "prediction": "Shouldn't `IMvxFormsViewPresenter` inherit from `IMvxAttributeViewPresenter`?",
       "reference": "Is the name \"IMvxFormsViewPresenter\" too close to \"IMvxFormsPagePresenter\"? Perhaps something like \"IMvxFormsNativeViewPresenter\" or \"IMvxFormsPlatformViewPresenter\" or inline with Forms naming \"IMvxFormsOnPlatformViewPresenter\""
     },
     {
-      "prediction": "I'm not sure what you mean by \"simple\" in this context. I think you meant to say that `child` is either a string or a number.",
+      "prediction": "I'm not sure if this is the best way to do this, but it seems to work.",
       "reference": "`typeof child != 'boolean'` maybe?"
     },
     {
@@ -22631,15 +22631,15 @@
       "reference": "Why && changed to || ?"
     },
     {
-      "prediction": "I think this should be `NewIDAddress(2)` instead of `NewIDAddress(4)`.",
+      "prediction": "I don't think we need to use `NewIDAddress(2)` here. We can just use `NewIDAddress(4)`.",
       "reference": "nit: not a big deal right now but spec assigns ID 0 to InitAddress"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to change the context of the caller to the specified window. I'm not sure what you're trying to do here, but it looks like you're trying to change the context of the caller to the specified window. I'm not sure what you're trying to do here, but it looks like you're trying to change the context of the caller to the specified window. I'm not sure what you're trying to do here, but it looks like you're trying to change the context of the caller to the specified window. I'm not sure what you're trying to do here, but it looks like you're trying to change the context of the caller to the specified window. I'm not sure what you're trying to do here, but it looks like you're trying to change the context of the caller to the specified window. I'm not sure what you're trying to do here, but it looks like you're trying to change the context of the caller to the specified window. I'm not sure what you're trying to do here, but it looks like you're trying to change the context of the caller to the specified window. I'm not sure what you're trying",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would make sense to have a `switchToWindow` method in the `CommandProcessor` class, and then call it from the `execute` method.",
       "reference": "/javascript/firefox-driver is the Selenium implementation of a WebDriver for Firefox. Since it generally isn't W3C compatible, it shouldn't change. We can just drop this change."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to call this method from the `QWebView`'s constructor.",
+      "prediction": "I'm not sure if this is the best place to do this, but I think it's a good idea to call this method from the `zoom` method of the `QWebView` class. This way, we don't have to call this method every time we want to zoom in/out.",
       "reference": "There are various places where `setZoomFactor` is used but `fuzzyval` isn't set: - `__init__` and `on_config_changed` (should be okay as `init_neighborlist` gets called which essentially does the same) - `zoom` (calls `zoom_perc` with `fuzzyval=False`), which is used by `:zoom-in` and `:zoom-out`. Are you sure this won't break those calls? (Yes, I know there should be tests for this - I'm working on that.) Other existing places probably should get simplified."
     },
     {
@@ -22647,15 +22647,15 @@
       "reference": "Is there a benefit to keeping this in RefinementSettings? Or could we move it into its own class in TestUtil?"
     },
     {
-      "prediction": "I think it's a good idea to have `Ready` and `Results` return a channel, so that we don't have to worry about closing the channel when we're done with it.",
+      "prediction": "I think it's better to use `map[string]Result` instead of `map[string]Result{}`.",
       "reference": "I would have expected the Ready method to need to change to be a `<-chan Result` instead of a `<-chan map[string]Result`. The difference being that now the Ready channel can produce more than one set of results. In fact the name Ready is inaccurate now since its not about the query being ready but just a mechanism to deliver results. If this should be a follow up PR that is fine, lets create an issue for it."
     },
     {
-      "prediction": "I don't think this is a good idea. It would be better to use `fetchAllActiveProjects()` instead.",
+      "prediction": "I don't think this is needed.",
       "reference": "why? what if we want to access those methods outside of azkaban-common?"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new `ConsensusRpcModule` and `EngineRpcModule` based on a `ManualTimestamper` and a `SingleReleaseSpecProvider`. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new `ConsensusRpcModule` and `EngineRpcModule` based on a `ManualTimestamper` and a `SingleReleaseSpecProvider`. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new `ConsensusRpcModule` and `EngineRpcModule` based on a `ManualTimestamper` and a `SingleReleaseSpecProvider`. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new `ConsensusRpcModule` and `EngineRpcModule` based on a `ManualTimestamper` and a `SingleReleaseSpecProvider`. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new `ConsensusRpcModule` and `EngineRpcModule` based on a `",
+      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don",
       "reference": "Rename file too"
     },
     {
@@ -22667,7 +22667,7 @@
       "reference": "Why is the `final` being removed here?"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I'll leave it here for now.",
+      "prediction": "I'm not sure if this is a good idea, but I think it's better to have a separate header file for easylogging++. I think it's better to have a separate header file for easylogging++. I think it's better to have a separate header file for easylogging++. I think it's better to have a separate header file for easylogging++. I think it's better to have a separate header file for easylogging++. I think it's better to have a separate header file for easylogging++. I think it's better to have a separate header file for easylogging++. I think it's better to have a separate header file for easylogging++. I think it's better to have a separate header file for easylogging++. I think it's better to have a separate header file for easylogging++. I think it's better to have a separate header file for easylogging++. I think it's better to have a separate header file for easylogging++. I think it's better to have a separate header file for easylogging++. I think it's better to have a separate header file for easylogging++. I think it's better to have a separate header file for easylogging++. I think it's better to have a separate header file for easylogging++. I think it's",
       "reference": "Maybe let's take this opportunity to change easylogging to a git submodule?"
     },
     {
@@ -22675,15 +22675,15 @@
       "reference": "Should we just be generous and elide all extra whitespace? `strings.TrimSpace`"
     },
     {
-      "prediction": "I don't think this is needed anymore.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to move it to the `SalesforceSDKManager` class, since it's not part of the `SalesforceSDK` package.",
       "reference": "This is an inaccurate API that has outlived it's purpose. We can't make the determination of phone (vs) tablet, with a 7\" screen in the mix. Also, with the advent of fragments, this API means very little now. It's not being used anywhere, since we switched to `ActionBar`."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. Is it that you want to log the version of the plugin? Or is it that you want to log the version of the plugin and the version of the plugin that was used to build the plugin? Or is it that you want to log the version of the plugin, the version of the plugin that was used to build the plugin, and the version of the plugin that was used to build the plugin? Or is it that you want to log the version of the plugin, the version of the plugin that was used to build the plugin, the version of the plugin that was used to build the plugin, and the version of the plugin that was used to build the plugin? Or is it that you want to log the version of the plugin, the version of the plugin that was used to build the plugin, the version of the plugin that was used to build the plugin, the version of the plugin that was used to build the plugin, and the version of the plugin that was used to build the plugin? Or is it that you want to log the version of the plugin, the version of the plugin that was used to build the plugin, the version of the plugin that was used to build the plugin,",
+      "prediction": "I think it's better to use `log.info(version())` instead of `log.finest(version())`.",
       "reference": "This change means that users can't easily see which version of the selenium server they're using. This is `info` level information."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the code expires after a certain amount of time.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this.",
       "reference": "You should just use `with patch(...):`, so it unpatches it automatically. Also, much simpler."
     },
     {
@@ -22691,19 +22691,19 @@
       "reference": "This didn't use to work for me. Are you sure that returns the correct instance from startup?"
     },
     {
-      "prediction": "I think it's a good idea to have a `MethodCallExpr` constructor that takes an `Expression` and a `String` for the method name.",
+      "prediction": "I think we should remove the `null` check here.",
       "reference": "Looks good. Eventually we could remove some of these constructors, but for now adding these two seems the way to go"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `ast.literal_eval` here. You can just use `ast.literal_eval(bwolist)` directly.",
+      "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea to use `ast.literal_eval` here.",
       "reference": "@jalavik should be have somewhere enum/list/registry of possible tags?"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason you want to call `list_findings` with `source_id`?",
+      "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to use the `findings` object to get the `violation_data` from the `violation_data` field of the `source_properties` object. This way we don't need to call `get` on the `source_properties` object to get the `violation_data` field. I'm not sure if this is the best way to do this, but I think we should be able to use the `findings` object to get the `violation_data` from the `violation_data` field of the `source_properties` object. This way we don't need to call `get` on the `source_properties` object to get the `violation_data` field. I'm not sure if this is the best way to do this, but I think we should be able to use the `findings` object to get the `violation_data` from the `violation_data` field of the `source_properties` object. This way we don't need to call `get` on the `source_properties` object to get the `violation_data` field. I'm not sure if this is the best way to do this",
       "reference": "why is this pylint disable needed?"
     },
     {
-      "prediction": "I'm not sure what you mean by `POLICY_LIBRARY_SYNC_ENABLED = 'false'`. Is this something you want to do?",
+      "prediction": "I don't think we need to use `POLICY_LIBRARY_SYNC_ENABLED = 'false'` here.",
       "reference": "The new sync feature is only being supported from within Terraform. Installations using the deprecated method will have this feature disabled."
     },
     {
@@ -22715,15 +22715,15 @@
       "reference": "I would make this level 1 or 2."
     },
     {
-      "prediction": "I think this should be `v.vm.provider :vmware_fusion do |v|\\n` instead of `v.vm.provider :vmware_fusion do |v|\\n  v.vmx['memsize'] = '#{options['vagrant_memsize'] ||= '1024'}'\\nend\\n`",
+      "prediction": "I think this should be `v.vm.provider :vmware_fusion do |v|` instead of `v.vm.provider :vmware_fusion do |v|\\n`",
       "reference": "Is that path in a variable anyway? Not a big fan of hard coding it here."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add some comments to the code to make it easier for others to understand what the code is doing.",
+      "prediction": "`errors.New` is not a valid error type. It should be `errors.Error` or `errors.UnexpectedError` instead.",
       "reference": "nit: Move `IdentityTemplateLabel` to be under `IdentityTemplate` to match the struct in config_crd.go"
     },
     {
-      "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to have a `backend` attribute in the `Analytics` class. This way, we can use the `backend` attribute in the `Analytics` class, and we can also use the `backend` attribute in the `AnalyticsHelper` class. This way, we don't have to repeat the `backend` attribute in the `Analytics` and `AnalyticsHelper` classes.",
+      "prediction": "I think it's better to use `self.backend = AnalyticsRuby` instead of `self.backend = AnalyticsRuby.new`",
       "reference": "Not necessarily related to this PR, but don't you think having a centralized place for all interactions with analytics might make this into a very big class? Is that something that you don't worry about until it happens?"
     },
     {
@@ -22735,47 +22735,47 @@
       "reference": "If we are going to add config to specify the maximum message pool size, we should probably also add a parameter for the maximum nonce gap and pass it into the `IngestionValidator`. This could be done in this PR or added as an issue."
     },
     {
-      "prediction": "I think this should be `List>` instead of `Map`.",
+      "prediction": "I think this should be `List>` instead of `List>`.",
       "reference": "please inline imports"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think we should have a default of 30 seconds for the iptables lock timeout, and 50 milliseconds for the ipset refresh interval.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to set the `IptablesLockTimeoutSecs` and `IptablesLockProbeIntervalMillis` to 0.",
       "reference": "Should IptablesPostWriteCheckIntervalSecs be set back to its previous smaller value, if use of the iptables lock is disabled?"
     },
     {
-      "prediction": "I think this should be `if (currentVersionIndex == existingDatabaseVersions.length - 1) return existingDatabaseVersions[existingDatabaseVersions.length - 1];`",
+      "prediction": "I think this should be `if (currentVersionIndex < 0) throw new Error('Unknown profile version. Most likely this is an old version of Joplin, while the profile was created by a newer version. Please upgrade Joplin at https://joplinapp.org and try again.');`",
       "reference": "Please use packageInfo here instead. As it is used in `app.js`."
     },
     {
-      "prediction": "I'm not sure what you mean by \"maybe the file doesn't exist\"",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to check if the file exists before trying to read it. If it doesn't exist, we can't use the cache.",
       "reference": "this seems unrelated to the rest of the PR, although related to the original report"
     },
     {
-      "prediction": "I don't think we need to check for non-null default in this case.",
+      "prediction": "I think this should be `if (colVID.isAddedColumnWithNonNullDefault())` instead of `if (NOT hbaseLookupPred)`.",
       "reference": "Would a check for added columns with non-null default be sufficient for aligned format?"
     },
     {
-      "prediction": "This flag is not used anywhere in the code, so I don't think we need to add it to the docs.",
+      "prediction": "This flag is not used anywhere in the code, so I don't think we need to add it to the flag list.",
       "reference": "Is this PR implementing compute service account for OVF import as well? I thought it's only image/one-step import? Btw, OVF importer uses \"-\" instead of \"_\" in flags (should be `compute-service-account`)."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `@Route` annotation to define the route for this endpoint.",
+      "prediction": "`collection` should be `collection_id` and `product` should be `product_id`",
       "reference": "Why change to element ?? in whole application use plural convention ??"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `target=\"_blank\"` attribute to open the link in a new tab. This way, if the user clicks on the link, they will open it in a new tab.",
       "reference": "Tiniest nit but this can be `tabindex={-1}`, `width={11}`, `height={11}`"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it would be good to add a test for this. It's not clear to me if this is a good idea, but I think it would be good to add a test for this. It's not clear to me if this is a good idea, but I think it would be good to add a test for this. It's not clear to me if this is a good idea, but I think it would be good to add a test for this. It's not clear to me if this is a good idea, but I think it would be good to add a test for this. It's not clear to me if this is a good idea, but I think it would be good to add a test for this. It's not clear to me if this is a good idea, but I think it would be good to add a test for this. It's not clear to me if this is a good idea, but I think it would be good to add a test for this. It's not clear to me if this is a good idea, but I think it would be good to add a test for this. It's not clear to me if this is a good idea, but I",
+      "prediction": "I think this should be fixed in the next release of NumPy.",
       "reference": "Unrelated to this PR, we should remove this exception. We now require `numpy`."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `SubWorkflow` struct, so that we don't have to do this every time we want to create a new sub workflow.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.",
       "reference": "Is the loop over vars and adding them to the subworkflow below in this file needed, since it's already done by NewSubWorkflowFromFile?"
     },
     {
-      "prediction": "I think this should be `if starts_on.year != ends_on.year` instead of `if starts_on.month != ends_on.month`",
+      "prediction": "I think this should be `if starts_on.year != ends_on.year && starts_on.month != ends_on.month` instead of `if starts_on.year != ends_on.year`",
       "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping."
     },
     {
@@ -22783,19 +22783,19 @@
       "reference": "Having to write this util makes me think that maybe we should have kept the csv_input stuff. I don't know."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. The `newBlockRetrievalQueue` function is not used anywhere in the code. It's just a helper function that creates a new `blockRetrievalQueue`.",
+      "prediction": "I'm not sure I understand what you're trying to do here. The `newBlockRetrievalQueue` function returns a new `blockRetrievalQueue` object, which is then passed to the `newBlockOpsStandard` function. What is the purpose of the `newBlockRetrievalQueue` function in this context?",
       "reference": "Passing in and saving a reference to the `BlockCache` at init time is going to break if something calls `config.ResetCaches()`, because it replaces the `BlockCache` instance completely. This happens on user logout or by a manual write to `.kbfs_reset_caches`. So you probably want to give it the whole `config`, or maybe just the `config.BlockCache` function pointer."
     },
     {
-      "prediction": "I think this should be `if err == multistream.ErrNotSupported || err == multistream.ErrIncorrectVersion` instead of `if st != nil { ... }`",
+      "prediction": "I think this should be `if err == multistream.ErrNotSupported || err == multistream.ErrIncorrectVersion` instead of `if err == multistream.ErrNotSupported || err == multistream.ErrIncorrectVersion || err == multistream.ErrIncorrectVersion`",
       "reference": "I am not sure this could happen. st should be nil if the error happens. If it does happen, we could also do st.Reset(), since it is an erroureous state so it closes both sides of the stream."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a separate file, so that we don't have to include it in every file that uses it.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a separate file.",
       "reference": "I'm guessing this was just added for debugging? Should probably remove it so we aren't modifying 3rd party libs."
     },
     {
-      "prediction": "I think this should be `result.is_a?(Bolt::ErrorResult) ? 'failure' : 'success'` instead of `result.success? ? 'success' : 'failure'`.",
+      "prediction": "I think this should be `result.is_a?(Bolt::ErrorResult) ? 'failure' : 'success'` instead of `result.is_a?(Bolt::ErrorResult) ? 'failure' : 'success'`",
       "reference": "This seems reversed... if `success?` is true, wouldn't we use `success`?"
     },
     {
@@ -22803,15 +22803,15 @@
       "reference": "This seemed like the easiest way to allow log level checks, it will require an update to the vendors tool, to ignore that file on update."
     },
     {
-      "prediction": "I'm not sure what you mean by \"not logged in\". I think you meant to say \"not logged in as the current user\".",
+      "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to have this in the header, since it's the first thing the user sees when they load the page.",
       "reference": "Should we disallow entry authors to unsubscribe to their entries?"
     },
     {
-      "prediction": "I don't think this is a good idea.",
+      "prediction": "I don't think we need to change this.",
       "reference": "2016 should be 2017."
     },
     {
-      "prediction": "I think it's better to use `if (microservice.getInstance().getEnvironment().equalsIgnoreCase(\"development\")) {` instead of `if (curSchemaSumary == null || microservice.getInstance().getEnvironment().equalsIgnoreCase(\"development\")) {`",
+      "prediction": "I don't think we need to check if the environment is \"development\" here. We should only check if the environment is \"production\" or \"development\".",
       "reference": "boolean exists = (existSchema != null) && (existSchema .getSummary() != null);"
     },
     {
@@ -22819,35 +22819,35 @@
       "reference": "It does not look idiomatic."
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `github.com/google/go-cmp/cmp/cmpopts` here. I think we should use `github.com/influxdata/flux/dependencies/dependenciestest` instead.",
+      "prediction": "I'm not sure why we need to import the builtins here. I think we can just use the builtins directly in the tests.",
       "reference": "Generally, we do not use newlines between project imports, we only separate them from the stdlib imports"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to `mediaPlayer.js` as well. It would be nice to have a way to set the `skipBackLength` and `skipForwardLength` in `mediaPlayer.js` as well.",
+      "prediction": "I don't think we need to add `hide` class to fullscreen button.",
       "reference": "can this long line be wrapped?"
     },
     {
-      "prediction": "I think this should be `W0143` instead of `W0142`.",
+      "prediction": "I think this is a duplicate of W0143.",
       "reference": "I'd use the same message that I suggested in the release changelog."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create an array of Mongoose documents. I'm not sure what you're trying to do here, but it looks like you're trying to create an array of Mongoose documents. I'm not sure what you're trying to do here, but it looks like you're trying to create an array of Mongoose documents. I'm not sure what you're trying to do here, but it looks like you're trying to create an array of Mongoose documents. I'm not sure what you're trying to do here, but it looks like you're trying to create an array of Mongoose documents. I'm not sure what you're trying to do here, but it looks like you're trying to create an array of Mongoose documents. I'm not sure what you're trying to do here, but it looks like you're trying to create an array of Mongoose documents. I'm not sure what you're trying to do here, but it looks like you're trying to create an array of Mongoose documents. I'm not sure what you're trying to do here, but it looks like you're trying to create an array of Mongoose documents. I'm not sure",
+      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create an array of documents from an array of documents. Is that what you're trying to do?",
       "reference": "Keep semi-colons at end of function defs please"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into `CommandOperationV1` as well. It's not clear to me why we need this in `CommandOperationV2` at all.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `readConcern` and `writeConcern` property to the `CommandOperationV2` class.",
       "reference": "A little skeptical of `explain` being here. Why is this now a property of all commands?"
     },
     {
-      "prediction": "I'm not sure if this is a good place to put this, but I think we should move it to the `Microsoft.TestPlatform.Extensions.TrxLogger.ObjectModel` namespace, since it's not a part of the `Microsoft.TestPlatform.Extensions.TrxLogger` namespace.",
+      "prediction": "I think this should be `Microsoft.TestPlatform.Extensions.TrxLogger.ObjectModel` instead of `Microsoft.TestPlatform.Extensions.TrxLogger.ObjectModel`",
       "reference": "License copied two times!!"
     },
     {
-      "prediction": "I'm not sure what you mean by `matcher='path'`",
+      "prediction": "I don't think this is a good name for this class. It's not clear what it does, and I don't think it's a good name for this class.",
       "reference": "... their **superclass**"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to set this in the `Beaker::Config` class, so that it can be used in the `Beaker::Command` and `Beaker::Client` classes as well.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to set the default value for `master-start-curl-retries` to `0` here. It's not clear to me if this is the right place to do this, but I think it's a good idea to set the default value for `master-start-curl-retries` to `0` here. It's not clear to me if this is the right place to do this, but I think it's a good idea to set the default value for `master-start-curl-retries` to `0` here. It's not clear to me if this is the right place to do this, but I think it's a good idea to set the default value for `master-start-curl-retries` to `0` here. It's not clear to me if this is the right place to do this, but I think it's a good idea to set the default value for `master-start-curl-retries` to `0` here. It's not clear to me if this is the right place to do this, but I think it's a good idea to set the default value for `master-start-curl-retries`",
       "reference": "I'm not sure if this is the right thing to be doing here. It seems like there should be a more systemic fix instead of this patch."
     },
     {
@@ -22855,7 +22855,7 @@
       "reference": "Not sure why these are up here   can we move these down to be part of the `@return` tag instead? This is what we usually do   (e.g. `getCurrentEntityURL`)"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `to_semantic_values` method.",
       "reference": "Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning."
     },
     {
@@ -22863,87 +22863,87 @@
       "reference": "We keep who wrote the code anonymous."
     },
     {
-      "prediction": "I think we can remove the `log.Info(MYSTERIUM_API_LOG_PREFIX, \"Node stats sent: \", nodeKey)` line.",
+      "prediction": "I think we can remove the `log.Info` as it's not used anywhere.",
       "reference": "Mention something in logs, that fake registration was used e.g. `Fake identity registered`"
     },
     {
-      "prediction": "I think it's a good idea to add a `PROPERTY_CREATE` property to the `registry` object, so that we don't have to check for `PROFILE_CREATE` in the `PROPERTY_CREATE` case.",
+      "prediction": "I think it's better to use `registry.dispatch( STORE_NAME ).setPropertyID( propertyID );` instead of `registry.dispatch( STORE_NAME ).setProfileID( PROFILE_CREATE );`",
       "reference": "I think it would make sense to also set `internalWebPropertyID` to `''` here. Otherwise, it might keep its previous value (let's say a property was selected before, but then the user chooses \"Create new property\"), but since it always should depend on `propertyID`, that would be incorrect."
     },
     {
-      "prediction": "I'm not sure what you mean by \"bad\" valences. I think this is a bug in `MolOps::addHs()`, not in `MolToSmiles()`, so I don't think this is a bug in `MolOps::addHs()`.",
+      "prediction": "I'm not sure if this is a bug or a feature. I think it's a bug, but I'm not sure if it's a feature or not.",
       "reference": "It might be reasonable to add a check that sanitization still fails here."
     },
     {
-      "prediction": "I think we can remove the `this.node.getAttempt()` call here, since it's not used anywhere else in the code.",
+      "prediction": "I think it's better to use `this.node.getAttempt()` instead of `this.node.getAttempt() > 0`",
       "reference": "Why not use attemptNo instead of another call to getAttempt? Even better, consider using a private method to calculate this string. This logic is in two places."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bit of a mix-up. I think you're trying to do something like this:\n\n```ruby\nhas_many :links, -> { where(deleted: false) }, as: :target\n```\n\nBut I don't think that's what you're trying to achieve. I think you're trying to do something like this:\n\n```ruby\nhas_many :links, -> { where(\"links.deleted = 'f'\") }, as: :target\n```\n\nBut I don't think that's what you're trying to achieve. I think you're trying to do something like this:\n\n```ruby\nhas_many :links, -> { where(\"links.deleted = 'f'\") }, as: :target\n```\n\nBut I don't think that's what you're trying to achieve. I think you're trying to do something like this:\n\n```ruby\nhas_many :links, -> { where(\"links.deleted = 'f'\") }, as: :target\n```\n\nBut I don't think that's what you're trying to achieve. I think you're trying to do something like this:\n\n```ruby\nhas_many :links, -> { where(\"links.deleted =",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have the `has_many :analysis_summaries, through: :analyses` in the `ProjectAssociations` module. I think it's a good idea to have the `has_many :analysis_summaries, through: :analyses` in the `ProjectAssociations` module. I think it's a good idea to have the `has_many :analysis_summaries, through: :analyses` in the `ProjectAssociations` module. I think it's a good idea to have the `has_many :analysis_summaries, through: :analyses` in the `ProjectAssociations` module. I think it's a good idea to have the `has_many :analysis_summaries, through: :analyses` in the `ProjectAssociations` module. I think it's a good idea to have the `has_many :analysis_summaries, through: :analyses` in the `ProjectAssociations` module. I think it's a good idea to have the `has_many :analysis_summaries, through: :analyses` in the `ProjectAssociations` module. I think it's a good idea to have the `has_many",
       "reference": "Yuck. Rails bug."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a good idea to add a `__repr__` method to the `Packet` class. This will allow you to print the packet in a more readable format.",
+      "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bad idea to have a `__class__` attribute in a `Packet` class. It's not a good idea to have a `__class__` attribute in a `Packet` class. It's not a good idea to have a `__class__` attribute in a `Packet` class. It's not a good idea to have a `__class__` attribute in a `Packet` class. It's not a good idea to have a `__class__` attribute in a `Packet` class. It's not a good idea to have a `__class__` attribute in a `Packet` class. It's not a good idea to have a `__class__` attribute in a `Packet` class. It's not a good idea to have a `__class__` attribute in a `Packet` class. It's not a good idea to have a `__class__` attribute in a `Packet` class. It's not a good idea to have a `__class__` attribute in a `Packet` class. It's not a good idea to have a `__class__` attribute in a `Packet` class",
       "reference": "It's useally a common practice to not use `l` as a variable (we have disabled this test in scapy because our code has tons, but it would have PEP8 failed otherwise), but it would be better not to create any. In general, single letter variables are not liked that much. Especially with windows where the fonts make 1=l How about `lay` ?"
     },
     {
-      "prediction": "I think we can remove the `http.Flusher` here, since we're not using it anymore.",
+      "prediction": "I think we should use `w.Header().Set(SwarmTagUidHeader, fmt.Sprint(tag.Uid))` instead of `w.Header().Set(SwarmTagUidHeader, fmt.Sprint(tag.Uid))`",
       "reference": "DRY these 5 lines into a function call, no?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but it seems to work for me.",
+      "prediction": "I think we can remove the `logger.Log` call here.",
       "reference": "should we be trying to close here? or just return directly @fabxc ? same goes for `stopc`..."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to test that the BA61 tier1 team approver is used for BA60 and BA61 requests, but I'm not sure what you're trying to test here.",
+      "prediction": "I'm not sure what you're trying to achieve here. I think you're trying to test that the BA61 tier1 team approver is used for BA60 and BA61 requests, but I'm not sure what you're trying to achieve here. I think you're trying to test that the BA61 tier1 team approver is used for BA60 and BA61 requests, but I'm not sure what you're trying to achieve here. I think you're trying to test that the BA61 tier1 team approver is used for BA60 and BA61 requests, but I'm not sure what you're trying to achieve here. I think you're trying to test that the BA61 tier1 team approver is used for BA60 and BA61 requests, but I'm not sure what you're trying to achieve here. I think you're trying to test that the BA61 tier1 team approver is used for BA60 and BA61 requests, but I'm not sure what you're trying to achieve here. I think you're trying to test that the BA61 tier1 team approver is used for BA60 and BA61 requests, but I'm not sure",
       "reference": "just re-ordered for clarity"
     },
     {
-      "prediction": "I'm not sure what you mean by \"error: 404\". Is it a 404 error on the M_API server, or a 404 error on the client?",
+      "prediction": "I'm not sure what you mean by \"error: 404\". I think you meant \"statuscode: 404\".",
       "reference": "Can you fix this also to print what is the IP address used to connect. Rename --> \"M_API server\" to maya apiservice"
     },
     {
-      "prediction": "I think we should use `internal/bytealg.IndexByteString` instead of `internal/bytealg.IndexByte`.",
+      "prediction": "I think this should be `internal/bytealg.IndexByteString` instead of `internal/bytealg.IndexByte`.",
       "reference": "This fails on Go 1.11 because `indexByte` is already defined in strings_go111.go. I would suggest simply renaming one of the two, for example you could rename the other one to `strings_indexByte` (that will be one of the things we'll drop when we drop Go 1.11 support so it's better to make that one look ugly instead of the function that we will likely keep for a longer time)."
     },
     {
-      "prediction": "I think it's better to use `@level` instead of `{0}`.",
+      "prediction": "I think we can remove the `@level` from the `CreateParameter(1)` and `CreateParameter(2)`.",
       "reference": "Now `dbType=' MockDbType.int32 '` is correctly interpreted and the value is rendered as an integer instead of a string; hence no more double quotes."
     },
     {
-      "prediction": "Shouldn't this be `CommentContentChangedEvent` instead of `CommentContentChanged`?",
+      "prediction": "I'm not sure I understand what you're trying to do here. Is it that you want to change the content of an existing comment? If that's the case, then you should be able to use the `changeContent` method to change the content of an existing comment. If you want to create a new comment with a different content, then you should be able to use the `changeContent` method to change the content of a new comment. If you want to change the content of a comment that already exists, then you should be able to use the `changeContent` method to change the content of a comment that already exists.",
       "reference": "typo in `$contend`"
     },
     {
-      "prediction": "I don't think we need to change the `TableOperations` to `TableOperations` because the `TableOperations` is the same as `TableOperations`.",
+      "prediction": "I don't think we need to change anything here.",
       "reference": "Nit: empty line"
     },
     {
-      "prediction": "I think this should be `if ops, ok := fs.ops[fb]; !ok {`",
+      "prediction": "I think this should be `if ops, ok := fs.ops[fb]; ok {`",
       "reference": "I figured this was more fool-proof than trying to plumb the error up from everywhere."
     },
     {
-      "prediction": "I think we can remove the `atomic.LoadInt32(&c.srv.logging.debug)` and `atomic.LoadInt32(&c.srv.logging.trace)`.",
+      "prediction": "I think it's better to use `atomic.LoadInt32(&c.srv.logging.debug)` and `atomic.LoadInt32(&c.srv.logging.trace)` instead of `atomic.LoadInt32(&debug)` and `atomic.LoadInt32(&trace)`.",
       "reference": "We know debug and trace as globals exist and are defaulted to 0. In this instance we need to know that c is non- nil, srv is non-nil and logging is non-nil before we can trust this statement not to panic."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea to set the `AppRoot` directly in the `NewApp` function. It's better to set the `AppRoot` in the `DdevApp` struct and then use it in the `NewApp` function.",
+      "prediction": "I'm not sure what you mean by `app.GetConfigPath(\"config.yaml\")`. It seems like you're trying to get the path to the config file, but I'm not sure what you're trying to do with it.",
       "reference": "Good removal here for two reasons: we're redeclaring `app.ConfigPath` immediately below without having used the initial value, and `app.GetConfigPath()` will build the value using the same process as in this line anyway."
     },
     {
-      "prediction": "I think we can remove `ConfigurationArgumentProcessor` and `ParentProcessIdArgumentProcessor` as they are not needed anymore.",
+      "prediction": "I think we should remove `ConfigurationArgumentProcessor` and `ParentProcessIdArgumentProcessor` as they are not needed anymore.",
       "reference": "Should BuildBase be removed?"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to have a separate test for this. I'm not sure if it's a good idea to have a separate test for this. I'm not sure if it's a good idea to have a separate test for this. I'm not sure if it's a good idea to have a separate test for this. I'm not sure if it's a good idea to have a separate test for this. I'm not sure if it's a good idea to have a separate test for this. I'm not sure if it's a good idea to have a separate test for this. I'm not sure if it's a good idea to have a separate test for this. I'm not sure if it's a good idea to have a separate test for this. I'm not sure if it's a good idea to have a separate test for this. I'm not sure if it's a good idea to have a separate test for this. I'm not sure if it's a good idea to have a separate test for this. I'm not sure if it's a good idea to have a separate test for this. I'm not sure if it's a good idea",
+      "prediction": "I'm not sure if this is a good place to put this, but I think it should be in the `internal_test` package.",
       "reference": "this was a bad Goland auto-import that I missed in the previous PR. Thanks to @rkowalick and @acruikshank for catching it"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think we need to remove the `QueryAtom` in this case.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `RWMol` in this case.",
       "reference": "Good catch here. Reading the code, it actually seems kind of dumb that `replaceAtom` needs to copy the atom it's passed. Ah well, we're more or less stuck with that."
     },
     {
-      "prediction": "I'm not sure I understand what you mean by `output->impl->set_gamma`. Could you please provide more context?",
+      "prediction": "I'm not sure if this is a good idea, but I think it's better to use `wlr_signal_emit_safe` instead of `wlr_signal_emit` in this case. `wlr_signal_emit_safe` is more explicit about what it's doing.",
       "reference": "What's the reason for adding the output pointer here? I'd expect it to be derivable from the actual handler that's called."
     },
     {
@@ -22955,7 +22955,7 @@
       "reference": "should use Number instead of Long"
     },
     {
-      "prediction": "I think this should be `if err != ErrMaxPayload && err != ErrAuthorization` instead of `if err != ErrMaxPayload && err != ErrAuthorization`",
+      "prediction": "I think this should be `if err != nil {` instead of `if err != ErrMaxPayload && err != ErrAuthorization`",
       "reference": "We had the checks for those two errors for a reason, why do we not need them anymore?"
     },
     {
@@ -22963,7 +22963,7 @@
       "reference": "Why didn't you just switch to `range` here too?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure the bucket name is valid before creating the bucket.",
+      "prediction": "I think this should be `if client != nil` instead of `if opts != nil`",
       "reference": "I don't even think `nil` should be allowed, since it uses global state to get the client."
     },
     {
@@ -22971,31 +22971,31 @@
       "reference": "You somehow got a change from `master` into your branch again, in e6d2167085688264e5ee6a81cfd2a7a8f10ded13. While it's not something terribly bad (as it will be fine after merging), it's kind of confusing, and I have no idea how it happens :laughing: Are you trying to update changes from `master` while working on your branch somehow? How do you do that?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to call `queue_scan_one_metadata_object` here.",
+      "prediction": "I'm not sure I understand what you're trying to do here, but I think you're trying to do something like this:\r\n\r\n    if (delta_from_revision && g_str_equal (delta_from_revision, to_revision)) {\r\n        /* This is similar to the below, except we *might* use the previous\r\n         * commit, or we might do a scratch delta first.\r\n         */\r\n-      initiate_delta_request (pull_data, delta_from_revision ?: NULL, to_revision, ref);\r\n+      if (!(delta_from_revision && g_str_equal (delta_from_revision, to_revision)))\r\n+        initiate_delta_request (pull_data, delta_from_revision ?: NULL, to_revision, ref);\r\n+      else\r\n+        queue_scan_one_metadata_object (pull_data, to_revision, OSTREE_OBJECT_TYPE_COMMIT, NULL, 0, ref);\r\n    } else {\r\n        /* This is similar to the below, except we *might* use the previous\r\n         * commit, or we might do a scratch delta first.\r\n```\nReview comment?",
       "reference": "Minor, can we drop the leading `!` and just swap the if and the else blocks?"
     },
     {
-      "prediction": "`bbox_feats.shape[0] > 0` is mean the number of proposal is not 0. `bbox_feats.shape[-2:] != bbox_feats.shape[-2:]` should be `bbox_feats.shape[-1] != bbox_feats.shape[-2:]`",
+      "prediction": "`bbox_feats.shape[0] > 0 is mean the number of proposal is not 0.`",
       "reference": "`bbox_feats.shape[0] > 0` requires the number of proposal is not 0."
     },
     {
-      "prediction": "I don't think this is necessary.",
+      "prediction": "I don't think this is necessary. The `componentWillUnmount` event is fired when the component is unmounted, so we don't need to do anything here.",
       "reference": "Just FYI, I had to remove this unused import because Travis/`npm run lint` were complaining."
     },
     {
-      "prediction": "I'm not sure why we need to include `fmt/format.h` here. It's not used anywhere in the code.",
+      "prediction": "I'm not sure why we need to include `fmt/format.h` here. It's not used anywhere in this file.",
       "reference": "format.h is not a system header but bundled with LAMMPS. This should be `#include \"fmt/format.h\"`"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `BKDWriter` class.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `visitDocValuesNoCardinality` method.",
       "reference": "could we always call visitDocValuesWithCardinality? It seems to include the version check already?"
     },
     {
-      "prediction": "I think this should be `throw new GridConfigurationException(\"No port was specified in -hub parameter. Example - http://\"+hub+\":4444/grid/register\");`",
+      "prediction": "I'm not sure what you mean by \"no port was specified in -hub parameter\". Is it possible that you meant to say \"no port was specified in -port parameter\"?",
       "reference": "I think if they _don't_ specify a port, we should assume grid default (which is 4444)"
     },
     {
-      "prediction": "I'm not sure what you mean by `TautomerCatalogParams` and `TautomerCatalog`. I think you meant `TautomerCatalogParams` and `TautomerCatalog`.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `TautomerCatalogParams` class to create the `TautomerCatalog` object, and then use that to create the `TautomerEnumerator` object. This way, we can use the `TautomerCatalogParams` class to create the `TautomerCatalog` object, and then use that to create the `TautomerEnumerator` object. This way, we can use the `TautomerCatalogParams` class to create the `TautomerCatalog` object, and then use that to create the `TautomerEnumerator` object. This way, we can use the `TautomerCatalogParams` class to create the `TautomerCatalog` object, and then use that to create the `TautomerEnumerator` object. This way, we can use the `TautomerCatalogParams` class to create the `TautomerCatalog` object, and then use that to create the `TautomerEnumerator` object. This way, we can use the `TautomerCatalogParams` class to create the `TautomerCatalog` object, and then use that to create the",
       "reference": "This looks to be a breaking change. I know it will affect some of my code that uses the Tautomer enumerator."
     },
     {
@@ -23003,7 +23003,7 @@
       "reference": "Perhaps remove this line"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `removeHs` function.",
       "reference": "Ah, missed this one. Sorry: you don't need to test the atomic number here. that's taken care of above on line 683."
     },
     {
@@ -23015,15 +23015,15 @@
       "reference": "This 32 could go away too."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to use the `pageSpeedLink` and `pageSpeedLabel` props in a way that doesn't make sense. I'm not sure what you're trying to do here, but it looks like you're trying to use the `pageSpeedLink` and `pageSpeedLabel` props in a way that doesn't make sense. I'm not sure what you're trying to do here, but it looks like you're trying to use the `pageSpeedLink` and `pageSpeedLabel` props in a way that doesn't make sense. I'm not sure what you're trying to do here, but it looks like you're trying to use the `pageSpeedLink` and `pageSpeedLabel` props in a way that doesn't make sense. I'm not sure what you're trying to do here, but it looks like you're trying to use the `pageSpeedLink` and `pageSpeedLabel` props in a way that doesn't make sense. I'm not sure what you're trying to do here, but it looks like you're trying to use the `pageSpeedLink` and `pageSpeedLabel` props in a way that doesn't make",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think this is the right place to do it.",
       "reference": "These props should be less specifically named since the component is generic, for example `anchorLink`, `anchorLinkLabel`."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to delete an EC2 instance, but you don't want to delete it, you just want to scale the controller deployment to 1. Is that correct?",
+      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to delete an EC2 instance that is already in the state of \"terminated\" or \"shutting down\". Is that correct? If that's the case, how do you know that the instance is in the state of \"terminated\" or \"shutting down\"? I'm not sure I understand what you're trying to do here. I think you're trying to delete an EC2 instance that is already in the state of \"terminated\" or \"shutting down\". Is that correct? If that's the case, how do you know that the instance is in the state of \"terminated\" or \"shutting down\"? I'm not sure I understand what you're trying to do here. I think you're trying to delete an EC2 instance that is already in the state of \"terminated\" or \"shutting down\". Is that correct? If that's the case, how do you know that the instance is in the state of \"terminated\" or \"shutting down\"? I'm not sure I understand what you're trying to do here. I think you're trying to delete an EC2 instance that is already in the state of \"terminated\" or \"shutting down",
       "reference": "In the future, it'd be great if we can separate commits or PRs that aren't in the same scope"
     },
     {
-      "prediction": "I think this should be moved to the `__init__` method of the `ScriptableType` class.",
+      "prediction": "I think this should be `copy()` instead of `copy()[:]`.",
       "reference": "can you define the string format on a different line, so it can be named, and so that it does not have to be constructed twice?"
     },
     {
@@ -23031,23 +23031,23 @@
       "reference": "Can we write a unit test for this."
     },
     {
-      "prediction": "I think this should be `self._set_load_status(usertypes.LoadStatus.success)` instead of `self._set_load_status(usertypes.LoadStatus.success_https)`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `load_finished` slot.",
       "reference": "Same as above, use `.delete('_autosave')`, not the command handler."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `InputFileBlockHolder` class, so that we don't have to do this in the `BatchDataReader` class.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `InputFile` class.",
       "reference": "It isn't necessary to check whether there are projected ID columns. The code is shorter if the values are available by default, even if they aren't used. This fixes the problem where there are constants to add (like `_file`) but no identity partition values are projected."
     },
     {
-      "prediction": "I'm not sure if this is the right place to add this command, but I think it's a good idea to add it to the list of commands that can be used to minimize the window.",
+      "prediction": "I'm not sure if this is the right place to add this command. I think it should be in `Command.W3C_MINIMIZE_WINDOW` and `Command.W3C_MAXIMIZE_WINDOW`.",
       "reference": "Update after command rename"
     },
     {
-      "prediction": "I think this should be `ASTAnyTypeDeclaration` instead of `ASTArrayInitializer`?",
+      "prediction": "I'm not sure if this is a good place to put this, but I think we should move it to the bestpractices package.",
       "reference": "@KroArtem This is the Checkstyle violation. This import should be grouped with other `net.sourceforge.pmd` imports below, in alphabetical order"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.",
+      "prediction": "I'm not sure what you're trying to do here. I don't think we need to do anything here.",
       "reference": "File is not `goimports`-ed (from `goimports`)"
     },
     {
@@ -23055,15 +23055,15 @@
       "reference": "This change seems unrelated to copying email addresses to the clipboard. Please limit the scope of pull requests as much as possible."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure the keymap is valid before trying to send it to the client.",
+      "prediction": "I think this should be `mmap` instead of `mmap`",
       "reference": "I'm assuming that there isn't a way for us to skip sending an fd here (-1?), and that we're allocating this fd just to send a legal but useless value across?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"InboundConfig configures a gRPC Inbound.\" Could you please clarify?",
+      "prediction": "I'm not sure if this is a good place to put it, but I think it should be in the `TransportSpec` struct.",
       "reference": "might be good for the units (bytes?) to be in the variable name."
     },
     {
-      "prediction": "I think this should be `root to: \"upcase#show\"` instead of `root to: \"marketing#show\"`?",
+      "prediction": "I'm not sure what you're trying to do here. I think you're trying to change the URL to `upcase://marketing`, but I don't think that's what you want to do. I think you want to change the URL to `upcase://upcase`, but I don't think that's what you want to do either. I think you want to change the URL to `upcase://upcase`, but I don't think that's what you want to do either. I think you want to change the URL to `upcase://upcase`, but I don't think that's what you want to do either. I think you want to change the URL to `upcase://upcase`, but I don't think that's what you want to do either. I think you want to change the URL to `upcase://upcase`, but I don't think that's what you want to do either. I think you want to change the URL to `upcase://upcase`, but I don't think that's what you want to do either. I think you want to change the URL to `upcase://upcase`, but I don't think that's what you want to do either. I think you want to",
       "reference": "Metrics/BlockLength: Block has too many lines. [166/25]"
     },
     {
@@ -23075,55 +23075,55 @@
       "reference": "These empty lines can be kept."
     },
     {
-      "prediction": "I think we can remove this test now, since it's not really relevant to the question.",
+      "prediction": "I think we can remove this test as it's not needed anymore.",
       "reference": "For some reason these tests started failing due to an extra `NEWLINE` returned from `h.query()`. Have not tried to check whether this may be a problem for real templates or not, just fixed the failing tests. Anyone with an opinion here?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to inject a trace context into a span, but I'm not sure what you're trying to do with that trace context.",
+      "prediction": "I'm not sure if this is a good place to put this, but I think it would be better to have a separate `traceCtxRegExp` for the `traceCtx` and `traceCtxRegExp` for the `traceCtx` and `traceCtxRegExp` for the `traceCtx` and `traceCtxRegExp` for the `traceCtx` and `traceCtxRegExp` for the `traceCtx` and `traceCtxRegExp` for the `traceCtx` and `traceCtxRegExp` for the `traceCtx` and `traceCtxRegExp` for the `traceCtx` and `traceCtxRegExp` for the `traceCtx` and `traceCtxRegExp` for the `traceCtx` and `traceCtxRegExp` for the `traceCtx` and `traceCtxRegExp` for the `traceCtx` and `traceCtxRegExp` for the `traceCtx` and `traceCtxRegExp` for the `traceCtx` and `traceCtxRegExp` for the `traceCtx` and `traceCtxRegExp` for the `traceCtx` and `traceCtxRegExp` for the `traceCtx` and `traceCtxRegExp` for the `traceCtx` and `traceCtxRegExp` for the `traceCtx` and `traceCtx",
       "reference": "It is better to have a method than a var."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `maxConcurrentActivityExecutionSize` and `maxConcurrentWorkflowTaskExecutionSize` as constants. This way, we don't have to worry about changing these values in the future.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `maxConcurrentActivityExecutionSize` and `maxConcurrentWorkflowTaskExecutionSize` constants.",
       "reference": "concurrent poller won't be larger than concurrent execution. Jump from 2 -> 16 seems aggressive. I suggest to use 8. Ideally, this should be dynamic config. :)"
     },
     {
-      "prediction": "I don't think this is a good idea. The `pretrained='torchvision://resnet101'` should be `pretrained='torchvision/resnet101'` or `pretrained='torchvision.resnet101'` or `pretrained='torchvision.resnet101'` or `pretrained='torchvision.resnet101'` or `pretrained='torchvision.resnet101'` or `pretrained='torchvision.resnet101'` or `pretrained='torchvision.resnet101'` or `pretrained='torchvision.resnet101'` or `pretrained='torchvision.resnet101'` or `pretrained='torchvision.resnet101'` or `pretrained='torchvision.resnet101'` or `pretrained='torchvision.resnet101'` or `pretrained='torchvision.resnet101'` or `pretrained='torchvision.resnet101'` or `pretrained='torchvision.resnet101'` or `pretrained='torchvision.resnet101'` or `pretrained='torch",
+      "prediction": "I don't think this is necessary. The `pretrained='torchvision://resnet101'` should be in the `base_` list.",
       "reference": "List is redundant."
     },
     {
-      "prediction": "Shouldn't the `resetPasswordUri` be `Uri.parse(getString(R.string.website) + \"cgi/reset_password.pl\")`?",
+      "prediction": "I don't think we need to call `super.onCreate(savedInstanceState);` in this case.",
       "reference": "Please use a string resource here rather than the hardcoded string \"user\". This allows the app to be multilingual."
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `github.com/openebs/CITF/citf_options` here.",
+      "prediction": "I'm not sure why we need to use `github.com/openebs/CITF/citf_options` here. We can just use `github.com/openebs/openebs.io/v1alpha1/citf_options` instead.",
       "reference": "@aswathkk Why did we remove this import? I guess we are using it."
     },
     {
-      "prediction": "I'm not sure what you mean by \"GracefulStop\"",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `ShutdownHandler` as well.",
       "reference": "Why? I thought this is for graceful shutdown."
     },
     {
-      "prediction": "I think we can remove the `unless` block here.",
+      "prediction": "I think we can remove the `if` block here, since we're not using the `stdout` and `stderr` fields.",
       "reference": "Can `result.stdout` or `result.stderr` be nil?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"defaults to -1 if no line number can be parsed.\"",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check here to make sure that the line number is valid. If it is not, then we should just return -1.",
       "reference": "@mprobst Looks like the `isStdLib` function has been removed in the latest Python plugin. Any thoughts on how to handle this? The new version doesn't seem to have any relevant alternatives."
     },
     {
-      "prediction": "I'm not sure what you mean by \"MaxIPSetSize\". Is it the maximum number of IP sets that can be created? Or is it the maximum number of IP sets that can be in use at any given time?",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a `MaxIPSetSize` field to the `Config` struct. This will allow the user to specify the maximum number of IP sets they want to use.",
       "reference": "How can there be a configured max ipset size? Surely we need to write ipsets with however many members are implied by the Calico datastore?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to move it to the `IncidentStatuses` controller.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to move this to `IncidentStatusesController` instead.",
       "reference": "This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted."
     },
     {
-      "prediction": "I think this should be `throw new UnsupportedOperationException(this.getClass().getName() + \" does not implement \" + this.getClass().getCanonicalName());`",
+      "prediction": "I think this should be `throw new UnsupportedOperationException(this.getClass().getName() + \" does not implement \" + this.getClass().getName());`",
       "reference": "why not be consistent with `isNull` and `notNull` and return null?"
     },
     {
-      "prediction": "I don't think we need to add the `imageWithPortAndHealthcheck` struct here. We can just use the `image` struct.",
+      "prediction": "I don't think we need this field. It's not used anywhere in the spec.",
       "reference": "Did we forget to remove this field?"
     },
     {
@@ -23131,7 +23131,7 @@
       "reference": "What if there is no element?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it should be in `buildActionMutex.Lock()` and `c.buildActionMutex.Unlock()`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a `buildActionMutex.Lock()` and a `buildActionMutex.Unlock()` in the `buildAction` function.",
       "reference": "I think you need to be careful to honour isTest and stamp here."
     },
     {
@@ -23139,23 +23139,23 @@
       "reference": "why zero value for `arrayType` for the default value of the optional args?"
     },
     {
-      "prediction": "I don't think this is a good idea. I think it's better to use `post('options.value.' . $scope->scopeName)` instead of `post('options.value.' . $scope->scopeName) ?: null`",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `clear` option for the filter.",
       "reference": "@robinbonnes ~~Would you mind putting the array key and value on a new line - it makes it more readable as an array.~~ Never mind, see discussion below."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `logLevel` in this case. You can just use `fmt.Println` to print out the values.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to add a comment explaining the purpose of this variable.",
       "reference": "I've never seen us do this anywhere else - why here? Why not `address, meshAddress string`?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think you want to use `computeIfAbsent` here. I think you want to use `computeIfPresent` instead.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `computeIfAbsent` here.",
       "reference": "I think it's necessary only for the earlier \"dynamic\" approach. I suppose it's not necessary in the eager one."
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to make sure that the `getBackendConfig()` method returns the same value as the `getBackendConfig()` method in the `Configurator` class. This way, the `Configurator` class will always return the same value, even if the `getBackendConfig()` method is called multiple times.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "Same here than [there](#r26168925)"
     },
     {
-      "prediction": "I think this should be `if (builder.id != null)` instead of `if (builder.id != null && builder.id.matches(\"^[a-zA-Z0-9_]+$\"))`",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to remove the `null` check.",
       "reference": "Again we should think about moving this pattern to a static final field"
     },
     {
@@ -23163,23 +23163,23 @@
       "reference": "haven't been implemented the `__constructor` for `NormalizerConfigPass` ?"
     },
     {
-      "prediction": "I think we can remove the `__repr__` method since it's not used in the `Collect` class.",
+      "prediction": "I think this should be `results` instead of `results.items()`.",
       "reference": "Docstring is missing."
     },
     {
-      "prediction": "I'm not sure what you mean by \"delete event\" in this context. I think you meant to say `delete event;`",
+      "prediction": "I'm not sure what you mean by \"delete event\". I think you meant to delete `event` here.",
       "reference": "I don't see the reason of this return as it will stop loading in half because an error, thats bad imo. Or you load it all and report errors or you load nothing and terminate, the first is as it always was so I wouldn't change that."
     },
     {
-      "prediction": "I'm not sure what you mean by \"not implemented\" here. I'm not sure what you mean by \"not implemented\" here. I'm not sure what you mean by \"not implemented\" here. I'm not sure what you mean by \"not implemented\" here. I'm not sure what you mean by \"not implemented\" here. I'm not sure what you mean by \"not implemented\" here. I'm not sure what you mean by \"not implemented\" here. I'm not sure what you mean by \"not implemented\" here. I'm not sure what you mean by \"not implemented\" here. I'm not sure what you mean by \"not implemented\" here. I'm not sure what you mean by \"not implemented\" here. I'm not sure what you mean by \"not implemented\" here. I'm not sure what you mean by \"not implemented\" here. I'm not sure what you mean by \"not implemented\" here. I'm not sure what you mean by \"not implemented\" here. I'm not sure what you mean by \"not implemented\" here. I'm not sure what you mean by \"not implemented\" here. I'm not sure what you mean by \"not implemented\" here. I'm not sure",
+      "prediction": "I think this should be `func (m *Mock) AddPeers(ctx context.Context, addr ...swarm.Address) error`",
       "reference": "change from AddPeer to AddPeers added a space in some occurrences"
     },
     {
-      "prediction": "I don't think this is a good idea. It's not a good idea to change the signature of a method in a way that it doesn't work anymore.",
+      "prediction": "I don't think this is necessary. We can just remove the `@Before` annotation.",
       "reference": "Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC."
     },
     {
-      "prediction": "I think we should use `NewIPTableRules()` instead of `NewiptablesRules()`.",
+      "prediction": "I think we should use `NewIPTableRules` instead of `NewiptablesRules` here.",
       "reference": "Do you remove \"s\" from \"iptables\" to IPTable\" on purpose? I feel it should be \"IPTablesRules\"."
     },
     {
@@ -23187,15 +23187,15 @@
       "reference": "nit: not your problem - but I wonder if this should have been a \"ConstantResponseRpc\" - which takes a name and a value .... maybe a more reusable concept."
     },
     {
-      "prediction": "I think it's better to use `otel.GetMeterProvider().Meter` instead of `otel.GetMeterProvider().Meter(name)`.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `GetMeterProvider` method to get the `MeterProvider` instance, and then use the `Meter` method to get the `Meter` instance.",
       "reference": "These changes have been resolved upstream. We can revert changes to this file when synced."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. Can you give an example of what you're trying to do?",
+      "prediction": "I'm not sure I understand what you're trying to do here. What is the purpose of the `value` argument?",
       "reference": "The description predates this diff but I think we can come up with something more grounded."
     },
     {
-      "prediction": "I think we can remove the `Kind` and `APIVersion` fields from the `SnapshotAPISpec` struct.",
+      "prediction": "I don't think we need to change the `Kind` and `APIVersion` in the `VolumeSnapshotAPISpec` struct. The `Kind` and `APIVersion` are already defined in the `VolumeAPISpec` struct, so we don't need to change them.",
       "reference": "Let the Kind, APIVersion & Metadata follow the rules followed by Volume. What is the reason for a change for snapshot struct ?"
     },
     {
@@ -23203,7 +23203,7 @@
       "reference": "seems that we did not strong depend servo no need to keep it? change to another one?"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to change the name of the thread in the `scoped_io_thread_name_change` class. I think it would be better to keep the name of the thread the same.",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to change the name of this class to something like `io_thread_name_change` instead of `scoped_io_thread_name_change`.",
       "reference": "Looks like this used to be UB before with an empty blocks and then calling `.second` on the `.front()`. Did it ever crash though?"
     },
     {
@@ -23211,23 +23211,23 @@
       "reference": "Sorry about the code churn here, reworking this use normal loops and async await made debugging far more straight forward. For example, if configuring the fail point fails you find out when stepping over that line vs having to look for the ultimate catch clause that handled it."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `util.buildArgsToString(config.buildArgs())` instead of `util.buildArgsToString(config.buildArgs().toString())`.",
+      "prediction": "I think we should remove the `--args` option from the `buildArgsToString` function.",
       "reference": "this is wrong and should be reverted"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `main` function as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `main` function as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `main` function as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `main` function as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `main` function as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `main` function as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `main` function as well. I'm not sure if this is the right place to do this, but I think it",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `main` function as well.",
       "reference": "I think you'll need to add an import for runtime, before you can merge this PR. (Presumably it was already there for something else when you were working on this, but has since disappeared.)"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a separate class for `SyncManager` and `SyncState`. This way, we can have a single `SyncManager` class that can be used by both `SyncState` and `SyncManager`.",
+      "prediction": "I don't think this is a good idea. The `@LargeTest` annotation is meant to be used for tests that are too large to fit in a single JUnit test class. It's not meant to be used for tests that are too small to fit in a single JUnit test class.",
       "reference": "Unrelated typo fix."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `context.Value` to get the value of the remote user.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `RemoteUserCtxKey` in the `replacer` struct.",
       "reference": "I don't think we need an empty value here; any middleware that wants a default value for empty placeholders will pass in what that value should be."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to use the `--storybook-host` flag in the `docker-compose.yml` file, so that we can use the same `--storybook-host` flag in both the `docker-compose.yml` file and the `docker-compose.yml` file.",
+      "prediction": "I'm not sure if this is a good idea, but I think it would be better to use the `--docker` flag in the `backstop` command, so that we don't have to pass the `--docker` flag every time we run the `backstop` command.",
       "reference": "Why was this changed?"
     },
     {
@@ -23235,19 +23235,19 @@
       "reference": "Compared to using traditional enums, I suggest to use `Status` or `StatusOr`, since they are more expressive and informative. Besides, isolating the definitions of error code of individual modules from the ones of the RPC interface is a good practice, isn't it?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to have the `attributes` hash in the `initialize` method. The `attributes` hash should only be used in the `save` method, not in the `initialize` method.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure the email is unique.",
       "reference": "Use the return of the conditional for variable assignment and comparison."
     },
     {
-      "prediction": "I think this should be `AnyKey` instead of `typing.AnyKey`?",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "just realised... This breaks things since there is not selenium types module, is there a PR for this?"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `bytes.Buffer` in this case. It seems like you're trying to write a test that uses a `bytes.Buffer` to capture the output of a function that returns a `bytes.Buffer`. However, I'm not sure if this is the best approach.",
+      "prediction": "I don't think we need to use `bytes.Buffer` here. We can just use `bytes.NewBuffer` instead.",
       "reference": "move to line 23 below"
     },
     {
-      "prediction": "I'm not sure what you mean by \"showLockActivity\"",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I think it's a good way to do this, but I'm not sure if this is the best way to do this. I think it's a good way to do this, but I'm not sure if this is the best way to do this. I think it's a good way to do this, but I'm not sure if this is the best way to do this. I think it's a good way to do this, but I'm not sure if this is the best way to do this. I think it's a good way to do this, but I'm not sure if this is the best way to do this. I think it's a good way to do this, but I'm not sure if this is the best way to do this. I think it's a good way to do this, but I'm not sure if this is the best way to do this. I think it's a good way to do this, but I'm not sure if this is the best way to do this. I think it's a good way to do this, but I'm not sure if this is the best way",
       "reference": "the first problem i found in the passcode change flow is that these two lines were happening in 'lock()' but not in 'showLockActivity' which is what the passcode change flow calls. I've just moved them to happen in that method."
     },
     {
@@ -23255,19 +23255,19 @@
       "reference": "Doing this adds the actual resources themselves to the dictionary. I think for now, there's no way to know what the resource config provided may be, as we don't permit resource config on `build_solid_context`, so this part can be omitted."
     },
     {
-      "prediction": "I think this should be `make_resubscription` instead of `make_resubscription`",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a separate controller, so that we don't have to call `current_user` in the `make_resubscription` method.",
       "reference": "1 trailing blank lines detected."
     },
     {
-      "prediction": "I think we can remove the `node_require` calls here. We don't need the `node_require` calls for the `uuid-sync-tests` and `pv-tests` tests.",
+      "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to have this in a separate file.",
       "reference": "I would personally prefer a filename without an abbreviation, a newcomer to the project wouldn't be able to translate \"pv\" to \"partition-value\"."
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to remove the `IMvxBundle` parameter from the `CallBundleMethod` method. The `IMvxBundle` parameter is only used when the `IMvxBundle` is passed to the `CallBundleMethod` method. If you don't pass a `IMvxBundle` to the `CallBundleMethod` method, you don't need the `IMvxBundle` parameter at all. So I think it's a good idea to remove the `IMvxBundle` parameter from the `CallBundleMethod` method and just pass the `IMvxBundle` to the `CallBundleMethod` method.",
+      "prediction": "I don't think this is necessary. We can just use `IMvxBundle` instead of `IMvxBundleBundle` in this case.",
       "reference": "This check looks odd to me. I can't quite grok it. Why is it needed now? What's changed?"
     },
     {
-      "prediction": "I think it's better to use `s.EnableJetStream(&cfg)` instead of `s.Noticef(\"Can't start JetStream: %v\", err)`.",
+      "prediction": "I think it's better to use `s.EnableJetStream(&cfg)` instead of `s.EnableJetStream(cfg)`.",
       "reference": "This change is needed because otherwise the path was being changed from `path/store/jetstream` to `path/store/` and files stored differently after re-enabling."
     },
     {
@@ -23275,15 +23275,15 @@
       "reference": "is this necessary? doesn't `client.close()` imply all sessions will be ended?"
     },
     {
-      "prediction": "I don't think we need to use `time` here. We can just use `time.Now()` instead.",
+      "prediction": "I don't think this is necessary. We can just use `net.Dialer.Dial` instead of `net.Dialer.Dial`.",
       "reference": "Extra line, it's not needed here."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to load the `puppetlabs_spec_helper/module_spec_helper` module, but you're not actually using it in your code. I'm not sure what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not sure what you're trying to achieve with this change, but I'm not",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to load the `puppetlabs_spec_helper/module_spec_helper.rb` file in the `Puppetlabs::Spec::Helper` module. This way we can use the `load_puppet` method in the `Puppetlabs::Spec::Helper` module to load the `puppetlabs_spec_helper.rb` file.",
       "reference": "Is this OK to add in the spec helper? I need to call `Bolt::PAL.load_puppet` so that I can use the new `Bolt::PAL::Issues` module when verifying that plans forbid functions."
     },
     {
-      "prediction": "I don't think this is necessary.",
+      "prediction": "I don't think this is necessary. `CharSeq#mapChars` already returns a new `CharSeq`, so we don't need to create a new one.",
       "reference": "or is it `i < length - back.length()`? `\"12345\".padTo(10, 'a')` should be `12345aaaaa`"
     },
     {
@@ -23291,15 +23291,15 @@
       "reference": "custom_imports -> custom_hooks"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to remove the `` tags from the question text. Is that what you're trying to do? If so, you could just remove the `` tags from the question text, like this: `
    <%= raw question[:text][0].gsub(/(\\s||<\\/td>| )*(<\\/tr>|)/,\"\") %>
    `",
+      "prediction": "I think this should be `if question[:text].present? && question[:text][0].present?` instead of `if question[:text].present? && question[:text][0].present? && question[:text].present? && question[:text][0].present?`",
       "reference": "I don't get why are we baking new hash structures to represent phases, sections, questions. We are not only loosing the references defined in models but also we have to figure out keys and values for this newly structures."
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to make sure that we can read the file even if we don't have a preloaded index. If we don't have a preloaded index, we can't read the file, so we need to make sure that we can read the file even if we don't have a preloaded index. If we don't have a preloaded index, we can't read the file, so we need to make sure that we can read the file even if we don't have a preloaded index. If we don't have a preloaded index, we can't read the file, so we need to make sure that we can read the file even if we don't have a preloaded index. If we don't have a preloaded index, we can't read the file, so we need to make sure that we can read the file even if we don't have a preloaded index. If we don't have a preloaded index, we can't read the file, so we need to make sure that we can read the file even if we don't have a preloaded index. If we don't have a preloaded index, we can't read the file,",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to make sure that the directory is open before opening the index input.",
       "reference": "It's somewhat confusing that the `preload` parameter shadows the instance variable; maybe rename the instance variable to `globalPreload` or `preloadDefault` or so to prevent future confusion?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"inline\" in this case. I think you meant to say \"inline\" in the `ImageConfig` field.",
+      "prediction": "I'm not sure if this is the best place to put this, but I think it would be good to have a `name` field in the `ScheduledJobConfig` struct.",
       "reference": "Are we setting these values anywhere?"
     },
     {
@@ -23307,15 +23307,15 @@
       "reference": "This has to be in front of all other includes"
     },
     {
-      "prediction": "I think this should be `if (pStart->getTotalDegree() < 3 || pEnd->getTotalDegree() < 3)` instead of `if (pStart->getTotalDegree() < 3 || pEnd->getTotalDegree() < 3) { pBond->setStereo(Bond::BondStereo::STEREONONE); }`",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be better to do this in the `updateStereoBonds` function.",
       "reference": "These changes make sense to me. @ricrogz : you wrote (I think ) the original version of this as part of #2553 Do you see any reason to not make the change?"
     },
     {
-      "prediction": "I don't think this is necessary. The `self.location.pathname` is the same as `window.location.pathname`, so we can just use that.",
+      "prediction": "I don't think this is necessary. The `window.self.location.pathname` is the same as `self.location.pathname`.",
       "reference": "`window.self === window`"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to make sure that `svcInitPublisherPrompt` and `svcInitPublisherHelpPrompt` are not empty strings.",
+      "prediction": "I'm not sure if this is the right place for this test. I think we should move it to `svc_init_test.go` or something like that.",
       "reference": "maybe we should keep one test case for ErrFileNotExists and update only one file for ErrWorkspaceNotFound?"
     },
     {
@@ -23327,43 +23327,43 @@
       "reference": "Isn't this a false positive? Why are we reporting `unused-variable` on a `del` operation with a `undefined-variable`."
     },
     {
-      "prediction": "I think it's better to use `log.Info` instead of `log.Info(mysteriumAPILogPrefix, \"Session stats sent: \", sessionId)`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `SendSessionStats` method to the `mysterium` package.",
       "reference": "Is it correct that `SessionDto` should be here?"
     },
     {
-      "prediction": "I don't think we need to use `fmt.Sprintf` here. We can just do `fmt.Sprintf(\"meter=%d,pktps,band=type=drop,rate=%d\", meterId, rate)`.",
+      "prediction": "I don't think we need to do this. We can just use `c.RunOfctlCmd(\"dump-ports-desc\")` instead.",
       "reference": "sorry I missed this earlier. We no longer use ovs-ofctl for flow programming AFAIK, why not add this support to ofnet / libOpenflow?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `core` asset bundle.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `cache` option in the `addJs` method. This way, we don't have to specify the `cache` option every time we call `addJs`.",
       "reference": "Make this consistent with the other definition please `'false'` vs `false`"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to run the cleanup handlers before exiting.",
+      "prediction": "I'm not sure I understand what you're trying to do here. Is it that you want to run the cleanup handlers and then terminate the process with the given exit code? If that's the case, why not just call `RunCleanupHandlers()` and then `os.Exit(0)`?",
       "reference": "I think this is a good way to do it. :+1:"
     },
     {
-      "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to have a `go-homedir` function in `github.com/mitchellh/go-homedir` so that we don't have to do this every time we want to use `go-homedir` in our code.",
+      "prediction": "I'm not sure if this is a good place to put it, but I think we should move it to `github.com/mitchellh/go-homedir` so that it can be used by `github.com/mitchellh/go-homedir` as well.",
       "reference": "Why this is needed?"
     },
     {
-      "prediction": "I think we can remove the `ovsDatapathType` check and just use `ovsDatapathType == ovsconfig.OVSDatapathSystem`.",
+      "prediction": "`ovsctlClient := ovsctl.NewClient(nodeConfig.OVSBridge)` should be `ovsctlClient := ovsctl.NewClient(nodeConfig.OVSDatapath)`",
       "reference": "Can we define this directly in the function `NewConnTrackOvsAppCtl` instead of passing this as an argument?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"unparam\"",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have",
       "reference": "False positives are annoying..."
     },
     {
-      "prediction": "Should this be `public` instead of `private`?",
+      "prediction": "I think this should be `public function generateSuffix(string $name, int $iterationIndex, string $suffix): string`",
       "reference": "Is the infrastructure layer an appropriate one? I don't think so tbh, more like an application, or even a domain one."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to use the `PowerOfTwoToHighByte` method to get the number of bytes in a `MemoryPoolBlock`. I'm not sure what you're trying to do here. It looks like you're trying to use the `PowerOfTwoToHighByte` method to get the number of bytes in a `MemoryPoolBlock`. I'm not sure what you're trying to do here. It looks like you're trying to use the `PowerOfTwoToHighByte` method to get the number of bytes in a `MemoryPoolBlock`. I'm not sure what you're trying to do here. It looks like you're trying to use the `PowerOfTwoToHighByte` method to get the number of bytes in a `MemoryPoolBlock`. I'm not sure what you're trying to do here. It looks like you're trying to use the `PowerOfTwoToHighByte` method to get the number of bytes in a `MemoryPoolBlock`. I'm not sure what you're trying to do here. It looks like you're trying to use the `PowerOfTwoToHighByte` method to get the number of bytes in a `MemoryPool",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "Why is this required to turn the static readonlies into jitted const? Is this a bug in the jitter?"
     },
     {
-      "prediction": "I think we can remove the `traceback.format_exception_only` call.",
+      "prediction": "I think we should remove the `cls_name` field from the `SerializableErrorInfo` namedtuple.",
       "reference": "feel free to make this a \"typed\" named tuple (overriding __new__) if you are feeling frisky"
     },
     {
@@ -23371,7 +23371,7 @@
       "reference": "Would use parenthesis to explicitly state the associations of operands ```js const MAX_SAFE_INTEGER = Number.MAX_SAFE_INTEGER || ((2 ** 53) - 1)"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `diff.WithIgnoreAddingMapKeys()` and `diff.WithCompareNumberAndNumericString()` instead of `diff.WithEquateEmpty()` and `diff.WithIgnoreAddingMapKeys()`. This is because `diff.WithIgnoreAddingMapKeys()` will ignore adding map keys, and `diff.WithCompareNumberAndNumericString()` will ignore comparing numbers and numeric strings.",
+      "prediction": "`diff.WithIgnoreAddingMapKeys()` should be `diff.WithIgnoreAddingMapKeys()`, not `diff.WithIgnoreAddingMapKeysMapKeys()`.",
       "reference": "The bug was caused by this order change in the last refactoring."
     },
     {
@@ -23383,43 +23383,43 @@
       "reference": "No need to add this fun. Using RunnableActionsBuilder#AddActions instead"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be better to move this into `core` or `utils` or something like that.",
       "reference": "I don't think it's possible to do this for hooks"
     },
     {
-      "prediction": "I don't think this is a good idea.",
+      "prediction": "I don't think this is a good idea. We should be able to do this in a single `wait` call.",
       "reference": "wait(1ms) when sec=0. wait(0ms) waits forever so that's why this is better."
     },
     {
-      "prediction": "I think this should be `so_reuseport` instead of `so_reuseport_fds`.",
+      "prediction": "I think we should remove the `H2O_VECTOR(int) reuseport_fds;` line.",
       "reference": "Do we need `domain` and `so_reuseport` now that we open new sockets immediately after calling `add_listener`?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to close the connections associated with this client. I'm not sure what you're trying to do here, but it looks like you're trying to close the connections associated with this client. I'm not sure what you're trying to do here, but it looks like you're trying to close the connections associated with this client. I'm not sure what you're trying to do here, but it looks like you're trying to close the connections associated with this client. I'm not sure what you're trying to do here, but it looks like you're trying to close the connections associated with this client. I'm not sure what you're trying to do here, but it looks like you're trying to close the connections associated with this client. I'm not sure what you're trying to do here, but it looks like you're trying to close the connections associated with this client. I'm not sure what you're trying to do here, but it looks like you're trying to close the connections associated with this client. I'm not sure what you're trying to do here, but it looks like you're trying to close the connections associated with this client. I'm not sure",
+      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a new `HttpClient` instance and then close it, but you're not closing the connections associated with this client.",
       "reference": "The formatting seems different from the rest of the code"
     },
     {
-      "prediction": "I think we can remove the `if len(zoneStrs) < 2` check.",
+      "prediction": "I think this should be `fmt.Errorf(\"%v is not a valid zone\", zone)` instead of `fmt.Errorf(\"zone is empty. Can't determine region\")`",
       "reference": "What about calling this package \"parameters\"? utils\\parameters are utils related to parameters."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. You're trying to generate a slug based on the name of the topic, but you're also trying to generate a slug based on the name of the topic, but you're also trying to generate a slug based on the name of the topic, but you're also trying to generate a slug based on the name of the topic, but you're also trying to generate a slug based on the name of the topic, but you're also trying to generate a slug based on the name of the topic, but you're also trying to generate a slug based on the name of the topic, but you're also trying to generate a slug based on the name of the topic, but you're also trying to generate a slug based on the name of the topic, but you're also trying to generate a slug based on the name of the topic, but you're also trying to generate a slug based on the name of the topic, but you're also trying to generate a slug based on the name of the topic, but you're also trying to generate a slug based on the name of the topic, but you're also trying to generate a slug based on the name of the topic, but you're also trying to",
+      "prediction": "I'm not sure what you mean by \"stripped, url encoded slug\". Is this the same as the `slug` attribute?",
       "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this command. It's not clear what it does or what it's supposed to do. I'm not sure if it's supposed to output the node's public key to a file, or if it's supposed to output the node's public key to standard output. I'm not sure if it's supposed to output the node's public key to a file, or if it's supposed to output the node's public key to standard output. I'm not sure if it's supposed to output the node's public key to a file, or if it's supposed to output the node's public key to standard output. I'm not sure if it's supposed to output the node's public key to a file, or if it's supposed to output the node's public key to standard output. I'm not sure if it's supposed to output the node's public key to a file, or if it's supposed to output the node's public key to standard output. I'm not sure if it's supposed to output the node's public key to a file, or if it's supposed to output the node's public key to standard output. I'm not sure if it's supposed to output the node's public key to a",
+      "prediction": "I think we should remove the `--to=` option from the help message, as it's not really needed.",
       "reference": "what is the actual difference here?"
     },
     {
-      "prediction": "I don't think we need to check for null here.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to check if the registrationId contains a query parameter. If it does, then we need to split the query string into an array of strings.",
       "reference": "Parsing URLs is hard. Any fixes should avoid manually parsing the URL."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to change the value of `@group_level` based on the value of `@group_level > 0 ? @group_level - 1 : @group_level`. Is this what you're trying to do?",
+      "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It's not clear what you're trying to achieve with this change, but I'm not sure if it's a good idea. It's not clear what you're trying to achieve with this change, but I'm not sure if it's a good idea. It's not clear what you're trying to achieve with this change, but I'm not sure if it's a good idea. It's not clear what you're trying to achieve with this change, but I'm not sure if it's a good idea. It's not clear what you're trying to achieve with this change, but I'm not sure if it's a good idea. It's not clear what you're trying to achieve with this change, but I'm not sure if it's a good idea. It's not clear what you're trying to achieve with this change, but I'm not sure if it's a good idea. It's not clear what you're trying to achieve with this change, but I'm not sure if it's a good idea. It's not clear what you're trying to achieve with this change, but I'm not sure if it's",
       "reference": "This is a private api, it doesn't need to return anything so `@group_level -= 1 if @group_level > 0` is preferred."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in `NativeHashedStorageHandler::NativeHashedStorageHandler` instead of `NativeHashedStorageHandler::NativeHashedStorageHandler::NativeHashedStorageHandler`.",
+      "prediction": "I'm not sure if this is a good place to put this, but I think it would be good to move it to `NativeHashedStorageHandler::NativeHashedStorageHandler` as well.",
       "reference": ".GetValueOr(0) ... but really, shouldn't m_value_strife also be optional?"
     },
     {
@@ -23427,11 +23427,11 @@
       "reference": "Working around a possible limitation in the JSDoc plugin's typescript syntax checking. This means the same thing"
     },
     {
-      "prediction": "I think this should be `private ArraySegment _buffer;` instead of `private ArraySegment _buffer; private Queue _reads = new Queue();`",
+      "prediction": "I don't think this is necessary. The `ReadOperation` is just a reference to the `FrameContext` and the `FrameContext` is just a reference to the `MessageBodyExchanger`. The `ReadOperation` is just a reference to the `FrameContext` and the `FrameContext` is just a reference to the `MessageBodyExchanger`. The `ReadOperation` is just a reference to the `FrameContext` and the `FrameContext` is just a reference to the `MessageBodyExchanger`. The `ReadOperation` is just a reference to the `FrameContext` and the `FrameContext` is just a reference to the `MessageBodyExchanger`. The `ReadOperation` is just a reference to the `FrameContext` and the `FrameContext` is just a reference to the `MessageBodyExchanger`. The `ReadOperation` is just a reference to the `FrameContext` and the `FrameContext` is just a reference to the `MessageBodyExchanger`. The `ReadOperation` is just a reference to the `FrameContext` and the `FrameContext` is just a reference to the `MessageBodyExchanger`. The `ReadOperation` is just a reference to the `FrameContext` and the",
       "reference": "Should be readonly"
     },
     {
-      "prediction": "I think this should be `from rdkit.six.moves import cPickle` instead of `from rdkit.six.moves import cPickle  # @UnresolvedImport`",
+      "prediction": "I don't think we need to import `cPickle` here. We can just use `pickle` from `rdkit.six.moves import cPickle` instead.",
       "reference": "I'm not going to stop accepting the PR, but I really hate these artifacts getting dropped in the Python code just to stop things like coverage checkers and linters from complaining."
     },
     {
@@ -23439,47 +23439,47 @@
       "reference": "FYI modifying an existing file generally doesn't invalidate the copyright date. The date here is when the copy right _begins_, so moving it later is arguably misleading-it still applies. Not a big deal, just something I've seen a few times in passing."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to set the `allowedOrigins` and `allowedMethods` parameters for the `CrossOriginFilter` in the `addFilter` method. I'm not sure what you're trying to do here, but it looks like you're trying to set the `allowedOrigins` and `allowedMethods` parameters for the `CrossOriginFilter` in the `addFilter` method. I'm not sure what you're trying to do here, but it looks like you're trying to set the `allowedOrigins` and `allowedMethods` parameters for the `CrossOriginFilter` in the `addFilter` method. I'm not sure what you're trying to do here, but it looks like you're trying to set the `allowedOrigins` and `allowedMethods` parameters for the `CrossOriginFilter` in the `addFilter` method. I'm not sure what you're trying to do here, but it looks like you're trying to set the `allowedOrigins` and `allowedMethods` parameters for the `CrossOriginFilter` in the `addFilter` method. I'm not sure what you're trying to do here, but it looks like",
+      "prediction": "I don't think we need to add the `allowedOrigins` and `allowedMethods` parameters to the `CrossOriginFilter`.",
       "reference": "Because the default value of allowedOrigins is * (all origins), so it isn't necessary to set again at all."
     },
     {
-      "prediction": "I think this should be `if (!isValidateNamespace(namespace)) {` instead of `if (!isValidateNamespace(namespace)) { throw new NoSuchNamespaceException(\"Namespace does not exist: %s\", namespace); }`",
+      "prediction": "I don't think we need to check for `null` here. It's already checked in the `isValidateNamespace` method.",
       "reference": "Style: indentation should be 4 spaces (2 indents) from the start of `Preconditions`."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `FormBuilder` class.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a separate method.",
       "reference": "I don't know why I suggested a html attribute at first (my bad), or maybe you think it makes sense. Otherwise, what about a simple class ?"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a good idea to make this configurable. It would be nice to be able to set it to something other than \"public\" or \"organisationally_visible\".",
+      "prediction": "I'm not sure what you're trying to achieve with this, but I think it's better to just use `config.tracker_root = \"UoE\"` instead of `config.tracker_root = \"UoE\"`",
       "reference": "Probably want something more generic here like 'DMPRoadmap' so that other installations aren't using UoE by default."
     },
     {
-      "prediction": "I think this should be `throw` instead of `MustBeRethrown`.",
+      "prediction": "I think this should be `throw;` instead of `throw exception.MustBeRethrown();`",
       "reference": "Must this not change to `MustBeRethrownImmediately`?"
     },
     {
-      "prediction": "I don't think we need to use `opsv1alpha1.Traceflow` here. We can use `opsv1beta1.Traceflow` instead.",
+      "prediction": "I don't think we need to change the `lastTf` struct. It's just a pointer to the `opsv1alpha1.Traceflow` struct, so we don't need to change it.",
       "reference": "Can it be pointer?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `beforeunload` event handler as well.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `refreshAuthentication` function, since it's called by the `refreshAuthentication` function.",
       "reference": "Not related to this issue but this condition seems weak."
     },
     {
-      "prediction": "I'm not sure if this is the best place to put this, but I think it's a good place to put it. I'm not sure if this is the best place to put it, but I think it's a good place to put it. I'm not sure if this is the best place to put it, but I think it's a good place to put it. I'm not sure if this is the best place to put it, but I think it's a good place to put it. I'm not sure if this is the best place to put it, but I think it's a good place to put it. I'm not sure if this is the best place to put it, but I think it's a good place to put it. I'm not sure if this is the best place to put it, but I think it's a good place to put it. I'm not sure if this is the best place to put it, but I think it's a good place to put it. I'm not sure if this is the best place to put it, but I think it's a good place to put it. I'm not sure if this is the best place to put it, but I think it's a good place",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in `MarcReaderTrait::getMarcRecord()`, so that we don't have to do this in `MarcReaderTrait::getMarcRecord()`, which is called by `MarcReaderTrait::getMarcRecord()`, which is called by `MarcReaderTrait::getMarcRecord()`, which is called by `MarcReaderTrait::getMarcRecord()`, which is called by `MarcReaderTrait::getMarcRecord()`, which is called by `MarcReaderTrait::getMarcRecord()`, which is called by `MarcReaderTrait::getMarcRecord()`, which is called by `MarcReaderTrait::getMarcRecord()`, which is called by `MarcReaderTrait::getMarcRecord()`, which is called by `MarcReaderTrait::getMarcRecord()`, which is called by `MarcReaderTrait::getMarcRecord()`, which is called by `MarcReaderTrait::getMarcRecord()`, which is called by `MarcReaderTrait::getMarcRecord()`, which is called by `MarcReaderTrait::getMarcRecord()`, which is called by `MarcReaderTrait::getMarcRecord()`, which is called by",
       "reference": "I think this might be a little more readable in two lines as: 
     $preferredMarcField = $this->mainConfig->Record->preferredMarcField ?? 'fullrecord'; $marc = trim($this->fields[$preferredMarcField] ?? $this->fields['fullrecord']); 
    "
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do with `np` and `NumpyRequiredForThisFeature` in this context. Could you provide more context or clarify what you're trying to achieve?",
+      "prediction": "I'm not sure if this is a good place to put this, but I think it would be a good idea to move this into the `flatbuffers` module, since it's not part of the `flatbuffers-python-api` package.",
       "reference": "does this still allow this file to be used with Python installations that don't have numpy?"
     },
     {
-      "prediction": "I think this should be `goPkg = goPkg.replaceFirst(\"\\\\/v([a-z1-9]+);\", \"\\\\/apiv$1;\")`",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way",
       "reference": "what about 0? Version probably can' start with 0, but v10 is theoretically possible."
     },
     {
-      "prediction": "I think this should be `IsPathRooted(string path)` instead of `IsPathRootedPath(string path)`.",
+      "prediction": "I think this should be `Path.IsPathRooted(string path)` instead of `Path.IsPathRooted(string source)`.",
       "reference": "Usually we consider APIs that have filesystem interactions to be part of IFileHelper, this would allow us to inject a testable implementation easily. `Path.IsRootedPath` doesn't access the file system. It is string comparison I believe."
     },
     {
@@ -23491,47 +23491,47 @@
       "reference": "Nice catch ! I don't think I would have caught that, did you search the whole code base for pre-existing functions ?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"incorrect cluster region label\". I think you meant to say \"incorrect cluster region name\" or \"incorrect cluster region label\".",
+      "prediction": "I'm not sure if this is the right way to do this, but I think we should be able to do this in a single test. If we can't do this in a single test, we should be able to do it in a separate test.",
       "reference": "Remove this line."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea.",
       "reference": "This is no longer called in any of our unit tests, right?"
     },
     {
-      "prediction": "I think it's better to use `v1beta1.TierPriority` instead of `v1beta1.TierPriority`",
+      "prediction": "I think it's better to use `tierPriority` instead of `tierPriority * uint32`",
       "reference": "I think typically K8s APIs will use `int32` and not `uint32`. I think we should keep it consistent with the rule `Priority` above. I believe that the rationale for using `int32` in general is: * some programming languages don't have native support for unsigned integers * it's easier to catch sign errors with signed integers, depending on the programming language (it it's negative, it's clearly an error but if it's a very large number, it could be normal or it could be a negative number overflow)"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a new migration.",
+      "prediction": "I think this should be `add_column :plans, :start_date, :datetime` and `add_column :plans, :end_date, :datetime` instead of `add_column :plans, :grant_id, :integer, index: true` and `add_column :plans, :start_date, :datetime` and `add_column :plans, :end_date, :datetime`",
       "reference": "If you end up changing grant to an association, this may need to change to a reference to enforce the foreign_key `add_reference :plans, :grant`"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `winImageSVG` prop instead of the `WinImageSVG` prop. This is because the `WinImageSVG` prop is only used when the `format` prop is set to `small`. If the `format` prop is not set, then the `WinImageSVG` prop will not be used at all.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `winImageSVG` prop instead of the `WinImageSVG` prop. This is because the `WinImageSVG` prop is only used when the `winImage` prop is not defined. If the `winImage` prop is defined, then the `WinImageSVG` prop is not needed.",
       "reference": "This won't work because `notification` comes from an API response here. I think this would be the same as the change to `Alert` where it would get `SmallSunSVG`."
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think we should set `ECS_ENABLE_CONTAINER_METADATA` and `ECS_HOST_DATA_DIR` to `false` so that we don't accidentally set them to `true` in the future.",
+      "prediction": "I think it's better to use `os.Setenv(\"ECS_HOST_DATA_DIR\", \"/etc/ecs/\")` instead of `os.Setenv(\"ECS_HOST_DATA_DIR\", \"/etc/ecs/\").defer os.Unsetenv(\"ECS_HOST_DATA_DIR\")`",
       "reference": "This is not checked below?"
     },
     {
-      "prediction": "I think it's better to use a slice of map[string]string instead of a slice of map[string]interface{}`",
+      "prediction": "I think we can remove the `if err != nil` check here.",
       "reference": "Will this ever return a \"Stack does not exist\" error? Should we handle it silently here rather than making higher level packages do error checking?"
     },
     {
-      "prediction": "I think we can remove `from .data_transfer import copy_file` and `from .search_util import search_api` as they are not used anymore.",
+      "prediction": "I think we should remove the `from .data_transfer import *` line, as it's not used anywhere.",
       "reference": "minor: at this scale, one import per line reads better"
     },
     {
-      "prediction": "I think this should be `default: []` instead of `default: \"{\\\"org\\\":[]}\"`",
+      "prediction": "I think this should be `t.string` instead of `t.text`.",
       "reference": "Should remove the default templates as well."
     },
     {
-      "prediction": "I don't think we need to use `node-sass` here. We can just use `node-sass` in `webpack.prod.js` and `node-sass` in `webpack.dev.js`.",
+      "prediction": "I don't think we need to use `node-sass` here. We can just use `require('node-sass')` instead.",
       "reference": "Why not `let`?"
     },
     {
-      "prediction": "I think we can remove the `EnableAutoConfiguration.ENABLED_OVERRIDE_PROPERTY + \"=false\"` line.",
+      "prediction": "I'm not sure if this is a good idea or not, but I think it would be a good idea to remove the `EnableAutoConfiguration.ENABLED_OVERRIDE_PROPERTY + \"=false\"` line.",
       "reference": "ns -> DNS My first reading was this is referring to System.nanoTime and thought hrm?"
     },
     {
@@ -23539,35 +23539,35 @@
       "reference": "is there a reason not to remove the param now? I think the serdes will still work?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.",
+      "prediction": "I don't think this is a good idea. We should be able to set the `upper_bound` and `lower_bound` directly in the `bst` object.",
       "reference": "`places=2` seems to be very poor comparison. Do you have any thoughts why is it fail with more strict checks?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `fetchProjectByName` method in the `ProjectManager` class. This way, we don't have to call `fetchProjectByName` every time we want to fetch a project, and we don't have to call `fetchProjectByName` every time we want to add a project to the cache.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the project already exists in the cache, and if not, fetch it from the DB.",
       "reference": "should we make level debug? Also just FYI, with debug level, we can add more detailed logging for better debuggability without concerning overwhelming logging message"
     },
     {
-      "prediction": "I think this should be `dtype = GetNTAReal()` instead of `dtype = GetNTAReal()`?",
+      "prediction": "I think this should be `dtype = GetNTAReal()` instead of `dtype = GetNTAReal()`",
       "reference": "I needed to add this import for Sphinx to inspect C++ runtime objects properly. This should be the only code change in this PR."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here, but I think we should be able to use the `ResourceChanged` event for this.",
+      "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason you want to use `ResourceChanged` and `ACTIONS` instead of just using `ResourceChanged` and `ACTIONS`?",
       "reference": "Changes in this file aren't related to the PR, are they? You took the opportunity to change the group deletion to using the subscriber too?"
     },
     {
-      "prediction": "I don't think this is needed.",
+      "prediction": "I'm not sure if this is a good place to put this, but I think it would be a good place to put it. It's not a big deal, but I think it would be a good place to put it.",
       "reference": "I'd probably move this into `MetricsConfig` as a private method. Seems like we only use it there."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `subcommand` keyword argument in the `lint` function.",
+      "prediction": "I don't think this is a good idea. The `subcommand` argument should be passed to the `lint` function, not the `args` argument.",
       "reference": "Not clear here what you mean with this list"
     },
     {
-      "prediction": "I think this should be `@SuppressWarnings(\"checkstyle:InnerAssignment\")` instead of `@SuppressWarnings(\"checkstyle:InnerAssignment\")`",
+      "prediction": "I think this should be `@SuppressWarnings(\"checkstyle:InnerAssignment\")` instead of `@SuppressWarnings(\"checkstyle:InnerAssignment\") @SuppressWarnings(\"checkstyle:InnerAssignment\")`",
       "reference": "Curious, is there a way we can get around this without suppressing?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think we need to do anything here.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `CreateProposal` function.",
       "reference": "I don't think we this field in session, it's a serial number for proposal but not unique index itself"
     },
     {
@@ -23579,19 +23579,19 @@
       "reference": "Same here: Empty line before and no `Internal dependencies` docblock (mandatory anyway once #217 lands)."
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `main.go` file, since it's used by the `main` function.",
+      "prediction": "I don't think we need to change the default value of `config-file-name` to `.pipe.yaml`.",
       "reference": "sorry, the default value for this field is no longer allowed?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I'm not sure if this is the right place to do this.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.",
       "reference": "Why does this work? I'd've expected that an admin could create a file anywhere."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `sh.cmd` instead of `sh.cmd` in this case. `sh.cmd` is more consistent with the rest of the `sh` module.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `sh.cmd` instead of `sh.cmd!` in this case.",
       "reference": "falling back to `x64` seems like a really bad idea given that the VS templates default to x86 these days."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a separate test case.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the `default_comm` is the same as the one used in the previous test.",
       "reference": "Bit surprised by this. I would have thought either you want to set it for both mpl and bokeh...or alternatively it was only ever meant for bokeh and was always wrong?"
     },
     {
@@ -23599,15 +23599,15 @@
       "reference": "Check modname instead, but only if it's a ImportFrom."
     },
     {
-      "prediction": "I think we can remove the `write.metadata.delete-after-commit.enabled` and `write.metadata.delete-after-commit` from the `TableProperties` class. We can also remove the `write.metadata.compression-codec` from the `TableProperties` class. We can also remove the `write.metadata.previous-log-max-count` from the `TableProperties` class. We can also remove the `write.metadata.delete-after-commit.enabled` and `write.metadata.delete-after-commit` from the `TableProperties` class. We can also remove the `write.metadata.compression-codec` from the `TableProperties` class. We can also remove the `write.metadata.previous-log-max-count` from the `TableProperties` class. We can also remove the `write.metadata.delete-after-commit.enabled` and `write.metadata.delete-after-commit` from the `TableProperties` class. We can also remove the `write.metadata.compression-codec` from the `TableProperties` class. We can also remove the `write.metadata.previous-log-max-count` from the `TableProperties` class. We can also remove the `write.metadata.delete-after-commit.enabled` and `write.metadata.delete-after-commit` from the `TableProperties` class. We can also remove the `write.metadata.compression-codec`",
+      "prediction": "I think this should be `write.metadata.delete-after-commit.enabled` instead of `write.metadata.delete-after-commit.enabled`",
       "reference": "How about `write.metadata.previous-versions-max`? No need to refer to these as a log."
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `config.filter_run_excluding windows: true unless ENV['BOLT_WINDOWS']` instead of `config.filter_run_excluding windows: true unless ENV['APPVEYOR_AGENTS']`.",
+      "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea to add this to the `config/environments/production.rb` file as well.",
       "reference": "We generally do this via tags in the Rakefile, not separate environment variables."
     },
     {
-      "prediction": "I'm not sure if this is the right place to add this command, but I think it's a good idea to add it to the list of commands that can be used to minimize the window.",
+      "prediction": "I'm not sure if this is the right place to add this command. I think it should be in `Command.W3C_MINIMIZE_WINDOW` and `Command.W3C_MAXIMIZE_WINDOW`.",
       "reference": "Update after command rename"
     },
     {
@@ -23615,115 +23615,115 @@
       "reference": "`if X not in Y:`"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to set the metastore URI to the metastore URI of the metastore.",
       "reference": "Do we know why the pool is exhausted? In the past, we had a few leaks in the Spark catalog code which led to this. It can be also a valid use case too if we simply need a larger pool."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
+      "prediction": "I'm not sure what you're trying to do here. I don't think we need to change this.",
       "reference": "Logging in Bolt still seems to be a little messy. I think this is more correct than what I had before, but made sure I wouldn't overwrite an existing level. And if console logging gets more options, both debug and verbose need to be fixed here."
     },
     {
-      "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `boost::beast::http::field::host` instead of `boost::beast::http::field::host_name`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check to see if the address is a valid IPv6 address.",
       "reference": "This could be simplified (if including  is fine): `auto address_string = boost::algorithm::erase_first_copy (address.to_string (), \"::ffff:\");`"
     },
     {
-      "prediction": "I think this should be `Proxy` instead of `proxy`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check here to make sure that the proxy is not null before trying to register it.",
       "reference": "This is wildly unhelpful to users --- they need to know when a proxy has been registered."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to use the `friendly_id` gem, but you're not using it correctly. You're trying to use `friendly_id` in the `friendly_id` block, but you're not using the `friendly_id` gem in the `friendly_id` block. I think you're trying to use the `friendly_id` gem in the `friendly_id` block, but you're not using the `friendly_id` gem in the `friendly_id` block. I think you're trying to use the `friendly_id` gem in the `friendly_id` block, but you're not using the `friendly_id` gem in the `friendly_id` block. I think you're trying to use the `friendly_id` gem in the `friendly_id` block, but you're not using the `friendly_id` gem in the `friendly_id` block. I think you're trying to use the `friendly_id` gem in the `friendly_id` block, but you're not using the `friendly_id` gem in the `friendly_id` block. I think you're trying to use the `friendly_id` gem in the `friendly_id` block, but you're not using",
+      "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to have a `friendly_id` for this model.",
       "reference": "Why do we need `do_not_validate_attachment_file_type` is we're doing it in the previous line?"
     },
     {
-      "prediction": "I don't think this is a good idea. It's not a good idea to load the login page in the `AccountAuthenticatorActivity`. It's better to load the login page in the `LoginActivity`.",
+      "prediction": "I don't think we need to do this.",
       "reference": "Loading login page right away only for the regular use case."
     },
     {
-      "prediction": "I think this should be `IS_DIMENSIONAL` instead of `IS_NON_DIMENSIONAL`.",
+      "prediction": "I think this should be `IS_NON_DIMENSIONAL: /acit|ex(?:s|g|n|p|$)|rph|ows|mnc|ntw|ine[ch]|zoo|^ord/i`",
       "reference": "IIRC this flag disables re-rendering entirely (`s/recursively //`)"
     },
     {
-      "prediction": "I'm not sure what you mean by \"noHomeButtonHeader\"",
+      "prediction": "I don't think we need to do this.",
       "reference": "Did you test this redirect? @thornbill mentioned it might need `web` at the front, but if this works fine I'd rather leave it this way."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `Assert.Equal` here.",
+      "prediction": "I'm not sure what you're trying to achieve with this test, but I don't think it's a good idea to use `Assert.Equal` in this case. It's not a good idea to use `Assert.Equal` in this case. It's not a good idea to use `Assert.Equal` in this case. It's not a good idea to use `Assert.Equal` in this case. It's not a good idea to use `Assert.Equal` in this case. It's not a good idea to use `Assert.Equal` in this case. It's not a good idea to use `Assert.Equal` in this case. It's not a good idea to use `Assert.Equal` in this case. It's not a good idea to use `Assert.Equal` in this case. It's not a good idea to use `Assert.Equal` in this case. It's not a good idea to use `Assert.Equal` in this case. It's not a good idea to use `Assert.Equal` in this case. It's not a good idea to use `Assert.Equal` in this case. It's not a good idea to use `Assert.Equal` in this case. It's not a good idea to use `Assert.Equal` in this",
       "reference": "FYI, this returned `StringValues` which is a value type (aka can never be null)."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a runtime call to `hashmapMake` that takes an `llvm.Value` and an `llvm.ConstInt` as arguments. However, the `hashmapMake` function doesn't take an `llvm.ConstInt` as an argument. It takes an `llvm.Value` and an `llvm.ConstInt` as arguments. I'm not sure what you're trying to do here, but it looks like you're trying to create a runtime call to `hashmapMake` that takes an `llvm.Value` and an `llvm.ConstInt` as arguments. However, the `hashmapMake` function doesn't take an `llvm.ConstInt` as an argument. It takes an `llvm.Value` and an `llvm.ConstInt` as arguments. I'm not sure what you're trying to do here, but it looks like you're trying to create a runtime call to `hashmapMake` that takes an `llvm.Value` and an `llvm.ConstInt` as arguments. However, the `hashmapMake` function doesn't take an `llvm.ConstInt` as an argument. It takes an `llvm.Value`",
+      "prediction": "I'm not sure what you mean by \"reserve\" in this context. It's not clear to me what you're trying to do here.",
       "reference": "Oh no, that's a bug."
     },
     {
-      "prediction": "I don't think this is necessary.",
+      "prediction": "I don't think we need this field. It's not used anywhere.",
       "reference": "Let's leave a note in CHANGES to replace this with an error metadata struct or interface, unless it would be less effort overall to take a run at it in this change."
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this property, but I think we should remove it.",
+      "prediction": "I'm not sure if this is a good idea, but I think it would be a good idea to add a `mapTo` property to the `Object` class. It would allow us to have different naming convention in Javascript than what is being used in the file itself. Reading and writing properties must be done using the public key for the property. Queries can be done using both the public and the mapped property name.",
       "reference": "The changelog entry does a better job of explaining how this is used than this description. In particular, this says that you need to set `mapTo` if the underlying name is different, but not that `mapTo` *is* the underlying name."
     },
     {
-      "prediction": "I'm not sure if this is a good idea or not, but I think it would be better to use `sql` instead of `go-sqlite3` in this case.",
+      "prediction": "I'm not sure if this is a good idea or not, but I think it would be better to use `sql` instead of `sqlite3` in the future.",
       "reference": "These imports will probably need to be refactored so they aren't here. That applies for all of the database drivers. The reason for this is because we sometimes want a driver to be available and sometimes we don't. When we include this library in our cloud offering, the sqlite3 connector needs to be gone because it's a security vulnerability and there's no use case for it in a cloud environment. But for flux itself, I can see how sqlite3 would be really useful and so I like this change. But this import needs to only exist within the tests and within the `cmd/flux` package. It cannot be here."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think this is the right way to do it.",
+      "prediction": "I'm not sure if this is the best way to do this, but it seems to work.",
       "reference": "We can use `getQualifiedKeyName` here instead. I will update."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate `archiveTypes` array for each mime type.",
+      "prediction": "I don't think this is a good idea. I think it should be `archiveTypes.indexOf(fileTypeSpecific) !== -1` instead of `archiveTypes.indexOf(fileTypeGeneral) !== -1`.",
       "reference": "Could you clarifty why some of those are removed?"
     },
     {
-      "prediction": "I think this should be `nil` instead of `status.Error(codes.Unimplemented, \"\")`",
+      "prediction": "I think this should be `nil, status.Error(codes.Unimplemented, \"\")` instead of `nil, status.Error(codes.Unimplemented, \"\")`",
       "reference": "`ctx` is unused in ListDeploymentConfigTemplates"
     },
     {
-      "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use the `data-toggle=\"tooltip\"` attribute here. I'm not sure if this is the right way to do this, but I think it's a good idea to use the `data-toggle=\"tooltip\"` attribute here. I'm not sure if this is the right way to do this, but I think it's a good idea to use the `data-toggle=\"tooltip\"` attribute here. I'm not sure if this is the right way to do this, but I think it's a good idea to use the `data-toggle=\"tooltip\"` attribute here. I'm not sure if this is the right way to do this, but I think it's a good idea to use the `data-toggle=\"tooltip\"` attribute here. I'm not sure if this is the right way to do this, but I think it's a good idea to use the `data-toggle=\"tooltip\"` attribute here. I'm not sure if this is the right way to do this, but I think it's a good idea to use the `data-toggle=\"tooltip\"` attribute here. I'm not sure if this is the right way to do this, but I think it",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `data-toggle=\"tooltip\"` attribute here.",
       "reference": "nice to see the usage of block for a more readable link name"
     },
     {
-      "prediction": "I think this should be `MPI_MAX_ERROR_STRING` instead of `MPI_MAX_ERROR_STRING`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to check for `MPI_MAX_ERROR_STRING` and `MPI_MAX_ERROR_STRING_LEN` before using `snprintf`.",
       "reference": "Can these use `static_cast` instead? Other than that, it's fine."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don",
+      "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a `__init__.py` file in the same directory as the `app.py` file. That way, we don't have to worry about the `__init__.py` file being in the same directory as the `app.py` file, and we don't have to worry about the `app.py` file being in the same directory as the `__init__.py` file.",
       "reference": "This output is only present when `DEBUG=True`. Does it really bother so much?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `nano::wallet::receive_confirmed` instead of `nano::wallet::search_pending`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `receive_confirmed` function, since it will be called from the `receive_confirmed` function.",
       "reference": "I think it should pass wallet transaction as well, otherwise there will be 2 wallet read transactions in 1 threads (next in scan_receivable)"
     },
     {
-      "prediction": "I think this should be `if (mmffVdWParamsIAtom && mmffVdWParamsJAtom)` instead of `if (mmffVdWParamsIAtom && mmffVdWParamsJAtom)`",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be better to do this in `MMFF::Utils::calcUnscaledVdWWellDepth`.",
       "reference": "RDKit::Utils is now in the namespace for localeswitcer... We could change it to something else."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason why you want to do this?",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to make sure that `columns` and `method` have the same length. If they don't, we should raise an error.",
       "reference": "@itholic, can we fix it in `_normalize_keyword_aggregation`?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `DOWNGRADED_PLAN` field in the `Subscription` model.",
+      "prediction": "I'm not sure what you're trying to do here. I think you're trying to add a new column to the `subscription` table, but I'm not sure what you're trying to do with it.",
       "reference": "It seems like we have the main plan in the database but the downgrade plan in the code. Probably okay for now, but as our thinking of how downgrades/plans develops we may want to consolidate."
     },
     {
-      "prediction": "Shouldn't this be `List` instead of `List`?",
+      "prediction": "I don't think this is a good idea. It would be better to have a method that returns the element by the value of the \"id\" attribute.",
       "reference": "we shouldn't add a bunch of static initializers 'everywhere' in the code. Probably just one would be good, during the construction of the 'RemoteWebDriver' class."
     },
     {
-      "prediction": "I don't think this is necessary. The `optionNameClefSignerEnable` and `optionNameClefSignerEndpoint` are already defined in the package.",
+      "prediction": "I don't think this is necessary.",
       "reference": "do we need both flags? maybe infer that `clef-signer-enabled` whenever `clef-signer-endpoint` is defined?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but it seems to work for me.",
+      "prediction": "I don't think we need to use `identity-obj-proxy` here. We can just use `identity-obj-proxy` from `identity-obj-proxy` package.",
       "reference": "Do we need this? I didn't see css files (only scss)."
     },
     {
-      "prediction": "I think this should be `settings.REMOTE_EXCLUDE_LOCAL` instead of `settings.REMOTE_EXCLUDE_LOCAL or not is_local_interface(host)`.",
+      "prediction": "I think we should remove `settings.REMOTE_EXCLUDE_LOCAL` from the `remote_stores` list.",
       "reference": "This feels like a weird `if not ... or not` to me. Can you talk out the intent here?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate controller for annual billing notifications.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate controller for annual billing notifications.",
       "reference": "Align the parameters of a method call if they span more than one line."
     },
     {
@@ -23731,7 +23731,7 @@
       "reference": "`@package *` can be removed as well."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't see any platform-specific use cases in the code.",
+      "prediction": "I'm not sure what you're trying to do here, but I think it's a bad idea to use `platforms` as a variable name. I'd suggest renaming it to something like `platforms` or `supported_platforms`.",
       "reference": "@ScottGarman is there a reason that `redhat_fips` needs to be a beaker platform? Why can't it be another platform that beaker just understands as `redhat`?"
     },
     {
@@ -23739,59 +23739,59 @@
       "reference": "Where is the other place?"
     },
     {
-      "prediction": "I don't think it's necessary to have a `__getitem__` method in this class.",
+      "prediction": "I don't think it's necessary to have a `UserList` in this case. We can just use a `list` here.",
       "reference": "Are you subclassing from `UserList` instead of `list` to satisfy some constraint of Jython? My main concern here is that this is a subtle breaking change to the API because `UserList` is not a subclass of `list`. This has the unfortunate side effect of breaking any user that is using `isinstance` checks to see if a `ResultSet` is a `list`."
     },
     {
-      "prediction": "I think it's better to have a separate `AvatarHelper` class for this.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the `AvatarHelper` class, so that it can be used in other places as well.",
       "reference": "We can DRY the above three functions"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. What is the purpose of the `Supplier>>` and the `BiConsumer>, Tuple2>`? What is the purpose of the `BinaryOperator>>`? What is the purpose of the `Function>, HashMap>`? What is the purpose of the `Collector.of(supplier, accumulator, combiner, finisher)`? What is the purpose of the `HashMap::ofEntries`?",
+      "prediction": "I'm not sure I understand what you're trying to do here. What is the purpose of the `Supplier>>` and `BiConsumer>, Tuple2>`? What is the purpose of the `ArrayList::add` and `ArrayList::addAll` methods? What is the purpose of the `HashMap::ofEntries` method? What is the purpose of the `Supplier>>`, `BiConsumer>, Tuple2>`, `ArrayList::add`, `ArrayList::addAll`, `HashMap::ofEntries`, and `HashMap::ofEntries`?",
       "reference": "Only no good is good code. Nice that you were able to remove all this duplicate stuff!"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bad idea to use `@Override` on a method that doesn't actually override anything. If you want to override a method, you should use `@Override` on the method that you want to override, not on the class that you want to override it on.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it would be a good idea to move this into the `RetrySettings` class.",
       "reference": "Looking at the code, it seems very odd that this method even exists in the SurfaceNamer, since it is only implemented and used in the PhpSurfaceNamer, and in fact the RetrySettings class name is hardcoded elsewhere. WDYT of just removing this method from SurfaceNamer and PhpSurfaceNamer?"
     },
     {
-      "prediction": "I'm not sure I understand what you mean by \"Save an arbitrary byte slice and return the reference byte slice representation.\"",
+      "prediction": "I'm not sure I understand what you're trying to do here. What is the purpose of `Save` and `Loader` here?",
       "reference": "these interfaces are defined twice. we should use only one and have it in `storage` package maybe"
     },
     {
-      "prediction": "I don't think we need to use global variables here. We can just use `self` instead of `global` in the `__init__` method.",
+      "prediction": "I don't think we need to use `globalModelsStorage` here. We can just use `globalModels` in the `Model` class.",
       "reference": "This is the wrong context for usage of `global` keyword. It need only be used inside functions."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is the right way to do it.",
+      "prediction": "I think this should be `if (targetType.isAssignableFrom(child.getClass()))` instead of `if (child.getClass() == targetType)`",
       "reference": "this change should be described in the changelog. I'll update it when merging if nothing else arises."
     },
     {
-      "prediction": "I think we can remove `CreateDispatcherForGRPCOutbound` as it's not used.",
+      "prediction": "I think we can remove `CreateDispatcherForGRPCOutbound` as it's not needed anymore.",
       "reference": "Just to stay consistent with naming let's call it CreateGRPCDispatcherForOutbound. Also rename 'CreateDispatcherForOutbound' to 'CreateTChannelDispatcherForOutbound'"
     },
     {
-      "prediction": "I think we can remove the `findImage` method and just use the `createImage` method instead.",
+      "prediction": "I'm not sure if this is the best way to do this, but it seems to work for me.",
       "reference": "This will always need to be displayed to users."
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a `safe_subn` method to the `re` module. This way, we don't have to worry about the actual encoding of the string.",
+      "prediction": "I'm not sure if this is a good idea, but I think it's better than the previous one.",
       "reference": "This looks very much like `repr` now (we miss 127 though) - maybe just do `repr(x)` + strip outer parantheses?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"VisibilityTime\" in this context. Is it the time when the task is visible to the user?",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this",
       "reference": "I don't see this field is set in task_generator.go. worth to double check if we put the timestamp when creating replication tasks."
     },
     {
-      "prediction": "I think this should be `if (self.isNotified())` instead of `if (self.s.state === Cursor.CLOSED || self.isDead())`",
+      "prediction": "I think we should remove the `if (self.isNotified())` check.",
       "reference": "nit: I prefer the space before and after this check to make it very easy to scan when reading through code"
     },
     {
-      "prediction": "I think we can remove the `try-catch` block here.",
+      "prediction": "I think this is a good idea, but I'm not sure if it's the best way to do it.",
       "reference": "should users also do a triple-flush?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I think we should remove the `U` and `C` fields from the struct.",
+      "prediction": "I'm not sure what you mean by \"complex64\". It's not a real type, it's just the name of the type. I think you meant \"float64\" or \"float32\" or \"int64\" or \"int32\" or \"int16\" or \"int8\" or \"uint8\" or \"uint16\" or \"uint32\" or \"uint64\" or \"float16\" or \"float32\" or \"float64\" or \"int16\" or \"int32\" or \"int64\" or \"uint16\" or \"uint32\" or \"uint64\" or \"float32\" or \"float64\" or \"float16\" or \"float24\" or \"float32\" or \"float64\" or \"float16\" or \"float24\" or \"float32\" or \"float64\" or \"float16\" or \"float24\" or \"float32\" or \"float64\" or \"float16\" or \"float24\" or \"float32\" or \"float64\" or \"float1",
       "reference": "What is the implication of removing these from the test? I thought the idea was to have all types supported by `docstore` here, and do things in the drivers to make them support them (e.g., list of size 2 for complex). If you're removing them because firestore doesn't have native support, then we're going to end up only testing the intersection of all types supported by all drivers; we need a better way."
     },
     {
@@ -23799,7 +23799,7 @@
       "reference": "Let's also adjust the somewhat weird type signature here as well. This probably should be `typing.Any` instead of `str` in the last line if we intend to support ints."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to remove the `func() { _ = os.RemoveAll(dir) }` line.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to make this a separate test.",
       "reference": "The body can just be `os.RemoveAll(dir)`"
     },
     {
@@ -23807,87 +23807,87 @@
       "reference": "Is this covered by regression tests? Also you might make a patch onto refactor branch."
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea to remove the action parameter from the request.",
+      "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea to remove the action parameter from a request.",
       "reference": "This is maybe more of an admin request? WDYT?"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. What's the purpose of the `toMap` method?",
+      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.",
       "reference": "Here I thought of `toHashMap` and later add `toTreeMap`. But I start to see, what you may have in mind. Alternatively we could provide a `toMap` and `toSortedMap`, which is great, too. On the other hand is always good to be as specific as possible. What do you think?"
     },
     {
-      "prediction": "I think we can remove the `localProjectAppNames` and `projectEnvironments` fields.",
+      "prediction": "I don't think we need to use `localProjectAppNames` here. We can just use `projectApplications` and `projectEnvironments` instead.",
       "reference": "maybe localProjectAppNames? Just a thought."
     },
     {
-      "prediction": "I think we can remove the `height` and `width` variables.",
+      "prediction": "I don't think we need to do this. The height of the block should be the same as the height of the next block, and the width should be the same as the width of the next block.",
       "reference": "This isn't new, but getHeightWidth is now defined in block_svg.js, block_render_svg_horizontal.js, and block_render_svg_vertical.js. One of these should be unnecessary."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `fixture.WaitForAllTxnsToConfirm` in this case.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this.",
       "reference": "I can't see any reason why this would fix a failure in `a.True(confirmed, \"txgroup\")`. We might have an issue elsewhere, but increasing the wait time wouldn't help."
     },
     {
-      "prediction": "I think we can remove the `:acceptable_exit_codes => [0,1]` from the `@logger.perf_output` call.",
+      "prediction": "I think we can remove the `if host['platform'] =~ PERF_START_PLATFORMS # SLES doesn't need this step` line.",
       "reference": "This section needs to be modified; crontab format differs between OS releases (Debian and CentOS, at least)."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `PipelineRun` class.",
+      "prediction": "I think this should be `check.inst_param(pipeline_run, \"pipeline_run\", PipelineRun)`",
       "reference": "if we think this is likely to be augmented with a additional 'run coordination' features or configuration in the future, we could make it an object of some kind instead (or an enum, if we think there may be other resume modes in the future besides just on/off). Just imagining 6 months in the future, it would be unfortunate if there were 7 new args here as the feature gets more complex"
     },
     {
-      "prediction": "I think we should remove `affine_grid` and `context_block` as they are not used anymore.",
+      "prediction": "I think this should be `from .affine_grid_generator import affine_grid` instead of `from .affine_grid_generator import affine_grid`",
       "reference": "`affine_grid` and `grid_sample` are currently unused. We may remove it from `ops/__init__.py` to speedup the loading of mmdet."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
+      "prediction": "I'm not sure if this is the right place to put it, but I think we should put it in `clientConfig` instead of `config`.",
       "reference": "Is there a reason why you need to support negative `AttackTimeout`? Why not just throw an error?"
     },
     {
-      "prediction": "`is_list_like` and `is_dict_like` should be `isinstance` instead of `isinstance`",
+      "prediction": "`is_list_like` and `is_dict_like` should be `is_sequence_like` and `is_sequence_like` respectively.",
       "reference": "nit: an unnecessary change?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you want to close the stream when the user is done with the response, but I'm not sure what you're trying to do here. I think you want to close the stream when the user is done with the response, but I'm not sure what you're trying to do here. I think you want to close the stream when the user is done with the response, but I'm not sure what you're trying to do here. I think you want to close the stream when the user is done with the response, but I'm not sure what you're trying to do here. I think you want to close the stream when the user is done with the response, but I'm not sure what you're trying to do here. I think you want to close the stream when the user is done with the response, but I'm not sure what you're trying to do here. I think you want to close the stream when the user is done with the response, but I'm not sure what you're trying to do here. I think you want to close the stream when the user is done with the response, but I'm not sure what you're trying to do here. I think you want",
+      "prediction": "I don't think we need to close the channel here. We can just close it when we're done with the response.",
       "reference": "Is trailer parsing something we have to do in this PR? It would be really helpful to separate stuff like this into smaller, self-contained PRs."
     },
     {
-      "prediction": "I think this should be `@logger.debug \"Deleting volume #{vol.name} for OpenStack host #{vm.name}\"` instead of `@logger.debug \"Deleting volume #{vol.name} for OpenStack host #{vm.name}\"`",
+      "prediction": "I think this should be `@logger.debug \"Deleting volume #{vol.name} for OpenStack host #{vm.name}\"`",
       "reference": "Any chance of a wait-forever situation here? Is there a reasonable timeout?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `worker.Start` method.",
+      "prediction": "I think this is a good idea, but I'm not sure if we need to rollback the blockchain first.",
       "reference": "line is 165 characters"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have the namespace v2 cache refreshed before the namespace v1 cache is refreshed. This way, we don't have to wait for the namespace v2 cache to be refreshed before the namespace v1 cache is refreshed, and we don't have to wait for the namespace v1 cache to be refreshed before the namespace v2 cache is refreshed. This way, we don't have to wait for the namespace v2 cache to be refreshed before the namespace v1 cache is refreshed, and we don't have to wait for the namespace v1 cache to be refreshed before the namespace v2 cache is refreshed. This way, we don't have to wait for the namespace v2 cache to be refreshed before the namespace v1 cache is refreshed, and we don't have to wait for the namespace v1 cache to be refreshed before the namespace v2 cache is refreshed. This way, we don't have to wait for the namespace v2 cache to be refreshed before the namespace v1 cache is refreshed, and we don't have to wait for the namespace v1 cache to be refreshed before the namespace v2 cache is refreshed. This way, we don't have to wait",
+      "prediction": "I'm not sure why we need to wait for the namespace cache refresh to be sure that our namespaces are loaded. I think we can just wait for the namespace cache v2 refresh to be sure that our namespaces are loaded.",
       "reference": "is this for cross DC case?"
     },
     {
-      "prediction": "I don't think we need to add `*/*.so` to `package_data` as it's already included in the `mmdet.ops` package.",
+      "prediction": "I don't think it's necessary to add `*/*.so` to `package_data` as it's already in the `mmdet.ops` directory.",
       "reference": "Remove this line."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to remove the `vpx` and `vorbis` entries from the `TranscodingProfiles` array. This is because `vpx` and `vorbis` are not supported by the current browsers.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a `vpx` entry to the `TranscodingProfiles` array. This is because `vpx` and `vorbis` are the same codec, but `vorbis` is used for `opus` and `opus` is used for `vpx`. I'm not sure if this is the right place to do this, but I think it would be good to add a `vpx` entry to the `TranscodingProfiles` array. This is because `vpx` and `vorbis` are the same codec, but `vorbis` is used for `opus` and `opus` is used for `vpx`. I'm not sure if this is the right place to do this, but I think it would be good to add a `vpx` entry to the `TranscodingProfiles` array. This is because `vpx` and `vorbis` are the same codec, but `vorbis` is used for `opus` and `opus` is used for `vpx`. I'm not sure if this is the right place to do this, but I think it would",
       "reference": "Maybe it would make sense to use `webmVideoCodecs` here and just append `vpx`. I'm not sure if av1 is currently supported when transcoding to webm though. It looks like it can be included in the mp4 transcoding profile now."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think this is the right place to do it. It's not clear to me what you're trying to do here, but I don't think this is the right place to do it. It's not clear to me what you're trying to do here, but I don't think this is the right place to do it. It's not clear to me what you're trying to do here, but I don't think this is the right place to do it. It's not clear to me what you're trying to do here, but I don't think this is the right place to do it. It's not clear to me what you're trying to do here, but I don't think this is the right place to do it. It's not clear to me what you're trying to do here, but I don't think this is the right place to do it. It's not clear to me what you're trying to do here, but I don't think this is the right place to do it. It's not clear to me what you're trying to do here, but I don't think this is the right place to do it. It's not clear to me",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to have a `StatsValuesFactory` with a `DocValuesStats` as a parent class. I think it would be better to have a `StatsValuesFactory` with a `DocValuesStats` as a child class, and a `DocValuesStats` as a parent class.",
       "reference": "Interestingly, this has nothing to do with replication, no clue what this means here"
     },
     {
-      "prediction": "I think this should be `fs, err = libgit.GetOrCreateRepoAndID(ctx, r.config, r.h, r.repo, r.uniqID);`",
+      "prediction": "I think this should be `if err != nil { return nil, nil, err; }` instead of `if err != nil { return nil, nil, err; }`",
       "reference": "Is that because we don't provide a UI for these?"
     },
     {
-      "prediction": "I'm not sure if this is the best place to put this, but I think it would be good to have a separate file for this.",
+      "prediction": "I'm not sure if this is a good place to put it, but I think we should move it to the `mock` package.",
       "reference": "Standard is either to use `HappyPath` (CamelCase) or `happy path` (lowercase sentence). I usually prefer the latter."
     },
     {
-      "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place",
+      "prediction": "I'm not sure if this is a good idea, but I think it's better to use `cfg` directly in the test.",
       "reference": "instead of using blkMemDao, we could generate a blockMemDao, and then use it as the second parameter."
     },
     {
-      "prediction": "I don't think this is necessary. The `calculateDurationInMs` function is not used anywhere in the code. It's only used in the `eachAsync` function. I think we can remove it.",
+      "prediction": "I don't think this is necessary. The `calculateDurationInMs` function is not used anywhere in the code. I think we can remove it.",
       "reference": "nit(2/10): `topology && topology.description != null`;"
     },
     {
@@ -23895,23 +23895,23 @@
       "reference": "why the space? I may not know all the style conventions."
     },
     {
-      "prediction": "I'm not sure what you mean by \"shadow DOM pass\"",
+      "prediction": "I think this is a duplicate of https://github.com/DefinitelyTyped/DefinitelyTyped/pull/15388",
       "reference": "Should be \"should fail if the **dt element** has a parent 
     with a changed role\""
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to set this to `true` in the `config/environments/production.rb` file as well.",
+      "prediction": "I'm not sure if this is a good idea, but I don't see why we need to serve static assets. I think we can just use the `serve_static_assets` option in `config/environments/production.rb` instead.",
       "reference": "Just to be clear: 1. This is required for compression, right? 2. This won't actually result in our dynos serving the assets, since they'll be served via the CDN, correct?"
     },
     {
-      "prediction": "I think this should be `save($entity, $context = null, $providerName = null)`",
+      "prediction": "I don't think we need to change the signature of the save method.",
       "reference": "not sure about removing this ping @Soullivaneuh"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to keep the `scheduled_for_deactivation?` method in the `User` class, since it's not a method of the `Subscription` class.",
+      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to keep the `scheduled_for_deactivation?` method in sync with the `scheduled_for_deactivation_on` method. This way, if the `scheduled_for_deactivation?` method returns `nil`, the `scheduled_for_deactivation_on` method will also return `nil`.",
       "reference": "Put a comma after the last parameter of a multiline method call."
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `TestInstanceExists` test as well.",
+      "prediction": "I'm not sure what you mean by \"did not expect error: %v\" in this case. I think you meant to say \"did not expect error: %s\"",
       "reference": "If instance could not be found when the provider id is set, `findInstance()` returns `ErrInstanceNotFoundByID` error. So that during reconcileNormal(), we don't create a new instance. In `reconcileDelete()`, when ErrInstanceNotFoundByID is seen, deletion continues to clean up even if the instance is gone (may be manually deleted)."
     },
     {
@@ -23919,27 +23919,27 @@
       "reference": "I would recommend making this a Tuple<ReplicateValue, IColllection<object>> You only need to convert things to strings if you need to persist them in Settings or something. If they only need to live for the life of dialog, you can keep everything as objects. You can use \"null\" for the ReplicateValue for when they have not chosen a property."
     },
     {
-      "prediction": "I don't think this is a good idea. It would be better to have a separate array for each event type. Also, it would be better to have a separate array for each event type. Also, it would be better to have a separate array for each event type. Also, it would be better to have a separate array for each event type. Also, it would be better to have a separate array for each event type. Also, it would be better to have a separate array for each event type. Also, it would be better to have a separate array for each event type. Also, it would be better to have a separate array for each event type. Also, it would be better to have a separate array for each event type. Also, it would be better to have a separate array for each event type. Also, it would be better to have a separate array for each event type. Also, it would be better to have a separate array for each event type. Also, it would be better to have a separate array for each event type. Also, it would be better to have a separate array for each event type. Also, it would be better to have a separate array for each event type. Also, it would be better to have",
+      "prediction": "I don't think you need to change anything here.",
       "reference": "I think there is no point providing action key here, as it will be called specifically, rather than randomly"
     },
     {
-      "prediction": "I think we can remove the `FrameworkDescription.Instance` and just use `FrameworkDescription.Create()` instead.",
+      "prediction": "I think this should be `FrameworkDescription.Instance` instead of `FrameworkDescription.Create()`.",
       "reference": "`XUnitIntegration` doesn't need to cache this anymore."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.",
+      "prediction": "I don't think we need to add this to the list of ignored files. I think we can just add it to the list of ignored files for the `awesomerc.lua` file as well.",
       "reference": "Can we have something line `# noqa` there instead? I think it's fine like this though."
     },
     {
-      "prediction": "I think this should be a `safe` check, not a `secure` check.",
+      "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.",
       "reference": "this variable is used in both branches so I've decided to declare it above"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but it seems to work for me.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to set the flags in the `startActivityForResult` method.",
       "reference": "`setFlags()` overwrites the previous flag, we should be using `addFlags()` to append flags."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `isNameChanged` flag to determine if we need to refresh the mirror.",
       "reference": "Need `return` after this."
     },
     {
@@ -23951,59 +23951,59 @@
       "reference": "This change is unhelpful: it precludes users from knowing which ports are being used for what purpose within the system."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think you want to use `User.find_or_create_by` here. I think you want to use `User.find_by` and `User.find_or_create_by`.",
+      "prediction": "I'm not sure what you're trying to do here, but I think it's a bad idea to use `session[:user]` in this way. It's not a good idea to use `session[:user]['email']` in this way. It's not a good idea to use `session[:user]` in this way. It's not a good idea to use `session[:user]['email']` in this way. It's not a good idea to use `session[:user]` in this way. It's not a good idea to use `session[:user]['email']` in this way. It's not a good idea to use `session[:user]` in this way. It's not a good idea to use `session[:user]['email']` in this way. It's not a good idea to use `session[:user]` in this way. It's not a good idea to use `session[:user]['email']` in this way. It's not a good idea to use `session[:user]` in this way. It's not a good idea to use `session[:user]['email']` in this way. It's not a good idea to use `session[:user]`",
       "reference": "Whoa, we weren't doing this before?? Derp."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to create a copy of the original flow, but you're also trying to create a copy of the new flow. I think you want to create a copy of the new flow, but you're also trying to create a copy of the original flow. I think you want to create a copy of the new flow, but you're also trying to create a copy of the original flow. I think you want to create a copy of the new flow, but you're also trying to create a copy of the original flow. I think you want to create a copy of the new flow, but you're also trying to create a copy of the original flow. I think you want to create a copy of the new flow, but you're also trying to create a copy of the original flow. I think you want to create a copy of the new flow, but you're also trying to create a copy of the original flow. I think you want to create a copy of the new flow, but you're also trying to create a copy of the original flow. I think you want to create a copy of the new flow, but you're also trying to create a copy of the original",
+      "prediction": "I'm not sure if this is a good idea, but I think it's better to use `CopyToBuilder` instead of `CopyToNewFlow` in this case.",
       "reference": "I'm surprised we didn't go with something like `flow := f.Flow.Copy()` to take care of all the fields at once, but as long as it works it's good enough for me"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. It's not clear what `config.XDPEnabled` is supposed to do.",
+      "prediction": "I think this should be `if !config.XDPEnabled && dp.xdpState == nil {`",
       "reference": "We would like this code to run, even when `config.XDPEnabled` is false, so that Felix can clean up its own XDP state after a restart."
     },
     {
-      "prediction": "I don't think this is necessary. The `ASTAnnotationTypeDeclaration` should be a subclass of `ASTAnyTypeDeclaration` instead of `AbstractJavaAccessTypeNode`.",
+      "prediction": "I don't think this is necessary. The `ASTAnnotationTypeDeclaration` should be a subclass of `ASTAnyTypeDeclaration`, not `AbstractJavaAccessTypeNode`.",
       "reference": "I'd declare this field `qualifiedName` private to hide it. Unless it really needs to be modified from somewhere else... (e.g. unit tests..), but then, we should find a solution, where this field can stay private."
     },
     {
-      "prediction": "I think this should be `http2PseudoHeaders` instead of `http2AuthorityPseudoHeader`?",
+      "prediction": "I think this should be `http2PseudoHeaders` instead of `http2AuthorityPseudoHeader`.",
       "reference": "is this exhaustive? or rather, any psudo header started with `:` is un-parsable/invalid in HTTP/1 right?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `withSession` in this way. It's not a good idea to use `withSession` in this way. It's not a good idea to use `withSession` in this way. It's not a good idea to use `withSession` in this way. It's not a good idea to use `withSession` in this way. It's not a good idea to use `withSession` in this way. It's not a good idea to use `withSession` in this way. It's not a good idea to use `withSession` in this way. It's not a good idea to use `withSession` in this way. It's not a good idea to use `withSession` in this way. It's not a good idea to use `withSession` in this way. It's not a good idea to use `withSession` in this way. It's not a good idea to use `withSession` in this way. It's not a good idea to use `withSession` in this way. It's not a good idea to use `withSession` in this way.",
+      "prediction": "I'm not sure what you're trying to do here, but I think it's a bad idea to use `withSession` in this way.",
       "reference": "Is this change implying something or just seems fit b/c regardless of outcome the sessions should still be length 1?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this, but I think it's a bit of a red herring. It's not clear to me what you're trying to do with this code.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think we should be able to do this in the `GeneratorBuilderUtil.createLanguageProvider` method.",
       "reference": "Maybe throw an exception if there is more than one, so that discovering the lack of support is easier when someone tries to use it down the road."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate route for this.",
+      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a new language confirmation page. I'm not sure what you're trying to do here, but it looks like you're trying to create a new language confirmation page. I'm not sure what you're trying to do here, but it looks like you're trying to create a new language confirmation page. I'm not sure what you're trying to do here, but it looks like you're trying to create a new language confirmation page. I'm not sure what you're trying to do here, but it looks like you're trying to create a new language confirmation page. I'm not sure what you're trying to do here, but it looks like you're trying to create a new language confirmation page. I'm not sure what you're trying to do here, but it looks like you're trying to create a new language confirmation page. I'm not sure what you're trying to do here, but it looks like you're trying to create a new language confirmation page. I'm not sure what you're trying to do here, but it looks like you're trying to create a new language confirmation page. I'm not sure what you're trying to do here, but",
       "reference": "Prefer single-quoted strings when you don't need string interpolation or special symbols."
     },
     {
-      "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to have a default value for `os.Getenv(\"TRAVIS_OS_NAME\")` so that we don't have to check for `os.Getenv(\"TRAVIS_OS_NAME\") == \"\"` every time we call `RunTestsDependingOnDocker()`.",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a flag to the test runner that allows you to run tests depending on whether or not Docker is available on the system.",
       "reference": "I feel the name of this function could be better, conveying it's a predicate. Something like `HasDockerTestEnvironment` or `CanRunLocalServerTests`, etc."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `grpc.NewClientStream` function to create the stream, and then use the `ClientStream.SendMsg` function to send messages to the stream. This way, we don't need to create a new `ClientStream` object every time we want to send a message to the stream, and we can reuse the same `ClientStream` object for multiple calls to `ClientStream.SendMsg`.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `grpc.NewClientStream` function to create a new stream, and then use the `grpc.NewClientStream` function to create a new client for that stream. This way, we don't need to create a new client for each call to `Store` or `Retrieve`, and we can reuse the same client for multiple calls to `Store` and `Retrieve`. This is more efficient than creating a new client for each call to `Store` and `Retrieve`, and it also allows us to reuse the same client for multiple calls to `Store` and `Retrieve` without having to create a new client for each call to `Store` and `Retrieve`.",
       "reference": "This seems unrelated to your PR, how did this end up in here?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the `UserDetailsManager` does not throw an exception if the `username` is not found in the `users` map. This way, the `UserDetailsManager` will not throw an exception if the `username` is not found in the `users` map, but it will throw an exception if the `username` is not found in the `users` map. This way, the `UserDetailsManager` will not throw an exception if the `username` is not found in the `users` map, but it will throw an exception if the `username` is not found in the `users` map. This way, the `UserDetailsManager` will not throw an exception if the `username` is not found in the `users` map, but it will throw an exception if the `username` is not found in the `users` map. This way, the `UserDetailsManager` will not throw an exception if the `username` is not found in the `users` map, but it will throw an exception if the `username` is not found in the `users` map. This way, the",
+      "prediction": "I don't think we need to do this.",
       "reference": "Is `username` expected to be case insensitive?"
     },
     {
-      "prediction": "I think we should remove the `test/identityset` package. It's not needed anymore.",
+      "prediction": "I don't think we need to use the `test/identityset` package for this test. We can just use the `identityset` package directly.",
       "reference": "File is not `gofmt`-ed with `-s` (from `gofmt`)"
     },
     {
-      "prediction": "I'm not sure if this is a good idea or not, but I think it's better to use `@Deprecation` instead of `@Deprecated` in this case.",
+      "prediction": "I'm not sure if this is a good idea or not, but I think we should remove the `@Deprecated` annotation here.",
       "reference": "Is there any point to the deprecation? If someone was using these APIs, can they continue to do so in any meaningful fashion now that you've disconnected them from the PMD internals? Normally \"compiles but doesn't work\" is considered a bug."
     },
     {
-      "prediction": "I'm not sure what you mean by \"resize_completion\" and \"selection_changed\" in this context. What do they do?",
+      "prediction": "I don't think this is necessary. The `selection_changed` signal is already emitted by the `QTreeView` subclass.",
       "reference": "You can remove the `QItemSelection` import in this file now."
     },
     {
@@ -24011,19 +24011,19 @@
       "reference": "Use `std::shared_lock` and `std::try_to_lock_t`. BTW. Why we fail on contention?"
     },
     {
-      "prediction": "I don't think we need to add `resolve: { extensions: [\"\", \".jsx\", \".js\"] }`",
+      "prediction": "I don't think we need to add `extensions: [\"\", \".jsx\", \".js\"]` to the `resolve` option.",
       "reference": "Not sure what this actually does, but do you need to add `\"\"` here? Or does `[\".jsx\", \".js\"]` work too?"
     },
     {
-      "prediction": "`address` is not used anywhere in this code, so it should be removed.",
+      "prediction": "`address` is not used anywhere in this file, so I think we can remove it.",
       "reference": "let's group imports in the order: std third party first party"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. Can you explain?",
+      "prediction": "I'm not sure what you mean by `null, null, null`",
       "reference": "So the tests run only when the db exists? Else everything passes?"
     },
     {
-      "prediction": "Shouldn't this be `io.Closer` instead of `io.Writer`?",
+      "prediction": "I think this should be `io.WriteCloser` instead of `io.Writer`.",
       "reference": "`Remove` is unclear. It seems the point is to allow the `FifoByteSink` to delete the underlying file. There seems to be an implicit contract that consumers of this interface call `Remove` after `Close` without necessarily understanding what `Remove` does. I get that it's a little awkward to have `FifoByteSink` delete the file in `Close`. It would probably be best to just remove this from the interface, since `AddSink` is working with an actual `FifoByteSink`. I would rename it in `FifoByteSync` to `DeleteFile` or `Cleanup` or something that's makes it more clear what's being removed."
     },
     {
@@ -24031,7 +24031,7 @@
       "reference": "Mentioned elsewhere but repeating again: would be nice to have units (ideally `Size *Bytes`)."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
+      "prediction": "I'm not sure I understand what you're trying to do here. You're trying to install modules from a `Puppetfile`, but you're not resolving them. What you're trying to do is install modules from a `Puppetfile`, but you're not resolving them. What you're trying to do is install modules from a `Puppetfile`, but you're not resolving them. What you're trying to do is install modules from a `Puppetfile`, but you're not resolving them. What you're trying to do is install modules from a `Puppetfile`, but you're not resolving them. What you're trying to do is install modules from a `Puppetfile`, but you're not resolving them. What you're trying to do is install modules from a `Puppetfile`, but you're not resolving them. What you're trying to do is install modules from a `Puppetfile`, but you're not resolving them. What you're trying to do is install modules from a `Puppetfile`, but you're not resolving them. What you're trying to do is install modules from a `Puppetfile`, but you're not resolving them. What you're trying to do is install modules from a `Puppetfile",
       "reference": "I think a test in `spec/integration` might help keep this file a bit more manageable, especially since we're just checking file contents and errors. But basically the same idea!"
     },
     {
@@ -24039,23 +24039,23 @@
       "reference": "This spec can be modified, giving you extra strength (Check this fetch key doesn't work and therefore returns `nil`)"
     },
     {
-      "prediction": "I think this should be `instr->label_cb` instead of `instr->label_cb == NULL`.",
+      "prediction": "I don't think we need to do this.",
       "reference": "So this means that we can remove a callback via instr_set_label_callback(). Maybe consider adding another API function for removal, and add a new assert here such that cb != NULL?"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason why you want to remove the copyright information?",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to add it to the footer.",
       "reference": "why are we using an instance variable instead of accessing the visibility method?"
     },
     {
-      "prediction": "I think we can remove the `nolint:gosec` here.",
+      "prediction": "I'm not sure if this is a good idea, but I think it's better to use `net.Resolver.PreferGo` instead of `net.Resolver.Dialer.PreferGo`.",
       "reference": "Ok. Can we just disable this linter?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a test database, but I'm not sure what you're trying to do here. I think you're trying to create a test database, but I'm not sure what you're trying to do here. I think you're trying to create a test database, but I'm not sure what you're trying to do here. I think you're trying to create a test database, but I'm not sure what you're trying to do here. I think you're trying to create a test database, but I'm not sure what you're trying to do here. I think you're trying to create a test database, but I'm not sure what you're trying to do here. I think you're trying to create a test database, but I'm not sure what you're trying to do here. I think you're trying to create a test database, but I'm not sure what you're trying to do here. I think you're trying to create a test database, but I'm not sure what you're trying to do here. I think you're trying to create a test database, but I'm not sure what you're trying to do here. I think you're",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a separate directory for the test data. This way, we can have a separate directory for the test data, and we can have a separate directory for the admin data. This way, we can have a separate directory for the test data, and we can have a separate directory for the admin data. This way, we can have a separate directory for the test data, and we can have a separate directory for the admin data. This way, we can have a separate directory for the test data, and we can have a separate directory for the admin data. This way, we can have a separate directory for the test data, and we can have a separate directory for the admin data. This way, we can have a separate directory for the test data, and we can have a separate directory for the admin data. This way, we can have a separate directory for the test data, and we can have a separate directory for the admin data. This way, we can have a separate directory for the test data, and we can have a separate directory for the admin data. This way, we can have a separate directory for the test data, and we can have a",
       "reference": "this is `test_data` and all other instances are `testdata` - does this change affect any test files, or are there actually no directories called `test_data` in the repo? (I just checked, it seems like there aren't...)"
     },
     {
-      "prediction": "I think we can remove the `getBaseSObjectPath()` method as it's not used anywhere.",
+      "prediction": "I think it's better to use `getBasePath()` instead of `getBaseConnectPath()` and `getBaseSObjectPath()`.",
       "reference": "Fixing `lint` warnings that have existed for a while."
     },
     {
@@ -24063,91 +24063,91 @@
       "reference": "Better to rename this to CASDefaultCstorSparsePool."
     },
     {
-      "prediction": "I'm not sure what you mean by \"close\" here. It's not a method of the `S3FileIO` class, it's a method of the `AwsClientFactory` class.",
+      "prediction": "I think this should be `client().close()` instead of `client().close();`",
       "reference": "Since we'e not 100% sure if `close` will be called more than once, should we set `client` to `null` or add an `AtomicBoolean closed` that will then handle the idempotency issue?"
     },
     {
-      "prediction": "I'm not sure what you mean by `first_second_same_name` here. It's not clear to me what you're trying to do here.",
+      "prediction": "I'm not sure what you mean by `second_intersection_data.name_id != EMPTY_NAMEID && first_intersection_data.name_id != EMPTY_NAMEID && first_second_same_name`",
       "reference": "And here - what happens if name id is invalid"
     },
     {
-      "prediction": "I think this should be `echo` instead of `echo $query`.",
+      "prediction": "Shouldn't this be `echo $query->getRawOutput();`?",
       "reference": "__toString() is not a part of QueryInterface"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a `__repr__` method to the `DataFrame` class. This will make it easier to understand what's going on under the hood when you print a `DataFrame` to the console.",
+      "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place",
       "reference": "nit: Could you add an empty line between `import datetime` (built-in library block) and `import numpy as np` (third-party library block)?"
     },
     {
-      "prediction": "I think this should be `CONV_NUMERIC_LITERAL` instead of `API_DRIVER`.",
+      "prediction": "I think this should be `CUDA_ERROR_NOT_PERMITTED` instead of `CUDA_ERROR_NOT_PERMITTED`.",
       "reference": "Please remove `HIP_UNSUPPORTED`"
     },
     {
-      "prediction": "I think it's better to use `sprintf` instead of `ngettext` here.",
+      "prediction": "I don't think we need to use `sprintf` here. We can just use `dateRange.match(/last-(\\d+)-days/)[1]` to get the number of days.",
       "reference": "Having boolean parameters to change function behavior is not a good practice because it violates the principle of functions being responsible for a single task, so the need for this indicates we need to split something out of here instead. We can introduce a function like `getCurrentDateRangeDayCount` or similar, which does this."
     },
     {
-      "prediction": "I think we can remove the `await server.stop()` as it's not needed anymore.",
+      "prediction": "I think we can remove the `await server.stop()` here.",
       "reference": "Is this not required?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to do something like this: `account.SetState(hash.PKHash, hash.Hash32B, hash.Hash32B)`. Is that what you're trying to do?",
+      "prediction": "I'm not sure I understand what you're trying to do here. Could you explain a bit more?",
       "reference": "savedStates is for confirmed states, not needed in working set"
     },
     {
-      "prediction": "I don't think we need to do this.",
+      "prediction": "I don't think this is necessary. We can just use `wireguard` as the service type.",
       "reference": "Why should we move it into `bootstrap.go` file?"
     },
     {
-      "prediction": "I'm not sure what you mean by `fontSizes` and `measures` here. Could you please clarify?",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate `fontSizes` array for `font-size` and `font-size-sm` and `font-size-md` and `font-size-lg` and `font-size-xl` and `font-size-2xl` and `font-size-3xl` and `font-size-4xl` and `font-size-5xl` and `font-size-6xl` and `font-size-7xl` and `font-size-8xl` and `font-size-9xl` and `font-size-10xl` and `font-size-11xl` and `font-size-12xl` and `font-size-13xl` and `font-size-14xl` and `font-size-15xl` and `font-size-16xl` and `font-size-17xl` and `font-size-18xl` and `font-size-19xl` and `font-size-20xl` and `font-size-21xl` and `font-size-22xl` and `font-size-23xl` and `font-size-2",
       "reference": "In the next major version, I plan on changing the em-unit breakpoints to be pixel values to keep everything consistent. Would be great to handle this with pixels as well, but still allow em-units to be defined with a string"
     },
     {
-      "prediction": "I think this should be `fields['index'] = str(idx + 1).rjust(2)` instead of `fields['index'] = idx + 1`",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `self.tabBar()` method in the `TabWidget` class, so that we don't have to call `self.tabBar()` every time we want to get the `TabBar` object.",
       "reference": "I don't think this will actually align the indexes, if you have > 100 tabs, the tabs over 100 will be misaligned. In addition with less than 10 tabs, there will be a pointless space."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `buildCanonicalHeaders` function.",
+      "prediction": "I'm not sure I understand what you're trying to do here. Is it possible that you're trying to get the canonical headers from the request? If so, why are you using `v4.Request.Header[http.CanonicalHeaderKey(k)]` instead of just `v4.Request.Header[k]`?",
       "reference": "hrm, unsigned headers now won't be included."
     },
     {
-      "prediction": "I'm not sure what you mean by \"255\" and \"256\". I think you meant \"255\" and \"254\".",
+      "prediction": "I think it's a good idea to add a check for `strlen($value) < 256` in the `isValid` method.",
       "reference": "what if `$value = ' ' `?"
     },
     {
-      "prediction": "I think we can remove the `if` statement here, as it's not necessary.",
+      "prediction": "I think we can remove the `if (Iterables.size(files) == 0)` check.",
       "reference": "What about using `!files.hasNext` instead? I'm not sure we want to assume that the iterable can be consumed multiple times. Plus there's no need to consume the entire iterable just to check whether it is empty."
     },
     {
-      "prediction": "I'm not sure what you mean by \"hasParent\" in this context. It's not clear what you're trying to do here.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `Container` class.",
       "reference": "I think we could add bool addArticle here defaulted to false like its done in item class so std::string Container::getName(bool addArticle /* = false*/) const { and pass that variable to getNameDescription call"
     },
     {
-      "prediction": "Shouldn't this be `super.onStartNestedScroll(..., target, axes, type)`?",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to move it to `CoordinatorLayout`'s `onStartNestedScroll` method.",
       "reference": "What if a library function on the outside still calls the old method? It is then no longer blocked properly. Have you tested the change?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"no memory or disk space; FIXME bail out gracefully\"",
+      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to use `h2o_iovec_reserve` to reserve memory for the `h2o_buffer_reserve` function, but you're not actually using the `h2o_buffer_reserve` function. I'm not sure what you're trying to do here, but it looks like you're trying to use `h2o_iovec_reserve` to reserve memory for the `h2o_buffer_reserve` function, but you're not actually using the `h2o_buffer_reserve` function. I'm not sure what you're trying to do here, but it looks like you're trying to use `h2o_iovec_reserve` to reserve memory for the `h2o_buffer_reserve` function, but you're not actually using the `h2o_buffer_reserve` function. I'm not sure what you're trying to do here, but it looks like you're trying to use `h2o_iovec_reserve` to reserve memory for the `h2o_buffer_reserve` function, but you're not actually using the `h2o_buffer_reserve` function. I'm not sure what you're trying to do here, but it looks like you're trying to",
       "reference": "@i110 Do you have an idea on how we should propagate errors that occur in this block? The error condition happens when i) `h2o_buffer_reserve` fails to allocate space (happens in master as well), or ii) `fill_cb` returns an error (unique to this PR)."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I think you're mixing up the `to_email` and `date` variables.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `Time.now.utc` in this case.",
       "reference": "Does this mean the times will show up in emails as UTC?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to set the `cmap` to `dflt_cmap` for the `Rectangles` and `Segments` options, but not for the `Ellipse` and `Polygons` options.",
+      "prediction": "I don't think this is a good idea. The `cmap` argument should be passed to the `Options` constructor, not to the `Options` class itself.",
       "reference": "What's the motivation for having one of these be a cycle and the other be a fixed color?"
     },
     {
-      "prediction": "I don't think this is a good idea. It looks like it will be hard to read. I think it's better to use `Console.WriteLine(line.TrimStart())` instead of `Console.WriteLine($\"| {line.TrimStart()}|\")`.",
+      "prediction": "I don't think this is a good idea. It looks like you're trying to split the table into multiple lines, but you're not actually splitting the table into multiple lines. Instead, you're splitting the table into multiple lines by using the `Split` method with a `StringSplitOptions.RemoveEmptyEntries` argument. This will cause the table to be split into multiple lines, but it will also cause the table to be split into multiple lines, which is not what you want. Instead, you should be splitting the table into multiple lines by using the `Split` method with a `StringSplitOptions.RemoveEmptyEntries` argument, like this: `table.ToMarkdown().Split(Environment.NewLine, StringSplitOptions.RemoveEmptyEntries)`.",
       "reference": "What will be an empty entry now?"
     },
     {
-      "prediction": "I think this should be `this.hot.isRtl() ? 'right' : 'left'` instead of `this.hot.isRtl() ? 'right' : 'left'`",
+      "prediction": "I don't think we need to do anything here.",
       "reference": "Can I ask you to add jsdoc tag that would mark the prop as `@private`?"
     },
     {
-      "prediction": "I think this should be `if err != nil { return false; }` instead of `if err != nil { return true; }`",
+      "prediction": "I think this should be `os.IsDir` instead of `IsDirectory`",
       "reference": "Do you need this? Don't think you use it?"
     },
     {
@@ -24159,15 +24159,15 @@
       "reference": "nit: can be removed before merging..."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `$(...).appendTo('body')` in this case.",
       "reference": "Maybe a single quote would be compatible with airbnb style."
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a `getCount()` method to the `SessionMap` class.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "This is not the right approach. The `Distributor` maintains a model of the current state of the Grid. That model already contains the information about every active session. We don't need to modify `SessionMap` to expose it further."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `//` as a comment separator. It's not clear what you're trying to do here.",
+      "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here. I'm not sure if it's a good idea to have comments in the middle of a function.",
       "reference": "@Marwes @wolffcm This is the file where I made a change the the expected output. Its a little bit weird, but I think that the final output makes sense for the most part."
     },
     {
@@ -24175,7 +24175,7 @@
       "reference": "I think we probably need a util.Warning() here."
     },
     {
-      "prediction": "I think this should be `get_package_registry` instead of `get_package_registry_v1`?",
+      "prediction": "I think this should be `get_from_config('default_local_registry') if path is None else fix_url(path)` instead of `get_from_config('default_local_registry') if path is None else fix_url(path)`",
       "reference": "Let's make have a signature that's consistent with `PhysicalKey.from_path`. Users should also have access to PhysicalKey since that class is part of the API (e.g., `Package.resolve_hash`)."
     },
     {
@@ -24187,15 +24187,15 @@
       "reference": "I'd rephrase it as `Simplify chained comparison between the operands`."
     },
     {
-      "prediction": "I'm not sure what you mean by \"onlyForFirstDomain\"",
+      "prediction": "I think this should be `if ($onlyForFirstDomain)` instead of `if ($onlyForFirstDomain = false)`.",
       "reference": "so in the performance data fixtures, there will be references for the second domain only?"
     },
     {
-      "prediction": "I think this should be `Proxy` instead of `proxy`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check here to make sure that the proxy is not null before trying to register it.",
       "reference": "This is wildly unhelpful to users --- they need to know when a proxy has been registered."
     },
     {
-      "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use the `headers` attribute of the `Request` object to get the value of the `Host` header. This way, we don't have to check for the existence of `:authority` in the `headers` attribute.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do it here.",
       "reference": "If there is no authority header (i.e. someone intentionally deleted it), I would argue we probably don't want a Host header in the replay either. How about we only add it if it exists, and do nothing otherwise?"
     },
     {
@@ -24203,31 +24203,31 @@
       "reference": "is there any unit test that can be updated to verify this?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"Initialize Return values\"",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to call `lua_pcall` here.",
       "reference": "exiting at this point is leaking memory, take a look at the valgrind output. the sbuffer must be destroyed."
     },
     {
-      "prediction": "I think this should be `not poppler` instead of `not poppler installed`",
+      "prediction": "I think this should be `poppler` instead of `--poppler`",
       "reference": "i think you want a different flag and help like `--ffmpeg` or something; and you need to mark any tests you want skipped"
     },
     {
-      "prediction": "I'm not sure what you mean by this, but it looks like you're trying to add a new field to the `AuditEvent` struct in the `v1alpha1` package. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to add a new field to the `AuditEvent` struct in the `v1alpha1` package. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to add a new field to the `AuditEvent` struct in the `v1alpha1` package. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to add a new field to the `AuditEvent` struct in the `v1alpha1` package. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to add a new field to the `AuditEvent` struct in the `v1alpha1` package. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to add a new field to the `AuditEvent` struct in the `v1alpha1` package. I'm",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to move it to the `events` package.",
       "reference": "this needed to change? or it was just some formatting thing?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `--logging` option to set the logging level.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `--logging` parameter to set the logging level.",
       "reference": "What's the advantage of doing it this way over, say, changing the `.circleci/config.yaml` to have `TRACE` as the `root.log.level`?"
     },
     {
-      "prediction": "I don't think this is needed.",
+      "prediction": "I don't think we need to add `project_number` to the `fetch_bigquery_iam_policy` method.",
       "reference": "typo: if -> of"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a separate function, so that we don't have to call this function every time we want to convert Markdown to HTML.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way",
       "reference": "It'll be interesting to see who or what this breaks..."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.",
+      "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `finest` or `log.finest` here.",
       "reference": "This change is incorrect: the current log level is correct."
     },
     {
@@ -24235,15 +24235,15 @@
       "reference": "There are few cases like this where default logger is used from CLI/db tools. I would copy `NewTestLogger` to `NewCLILogger` and use it everywhere in CLI. In future these two might be different."
     },
     {
-      "prediction": "I'm not sure what you mean by \"cannot pass null or empty values to constructor\"",
+      "prediction": "I think this should be `nullSafeValue(Object value)` instead of `nullSafeValue(String value)`.",
       "reference": "While it provides re-use, this method does not make sense in `AbstractAuthenticationToken` because it knows nothing of a hash key. Instead, we should move this to a private method within each subclass."
     },
     {
-      "prediction": "I think this should be `for x in values` instead of `for rule in pagination_rules`",
+      "prediction": "I think it's better to use `values()` instead of `values()`, since `values()` returns a list of tuples, not a dictionary.",
       "reference": "index by memory address? I realize I don't understand why we don't just build a list :)"
     },
     {
-      "prediction": "I think this should be `@user_bp.route(\"/lastfmscraper/.js\")` instead of `@user_bp.route(\"/lastfmscraper/.js\")`",
+      "prediction": "I don't think this is necessary. We can just use `user_bp.route(\"/lastfmscraper/.js\")` without the `@crossdomain()` and `@user_bp.route(\"/lastfmscraper/.js\")`",
       "reference": "Not part of this commit, but we thought that this may not be a good place for this url, as it is in the `/user/` namespace (effectively preventing us having a user called `lastfmscraper`, however rare it may be)"
     },
     {
@@ -24251,55 +24251,55 @@
       "reference": "Does not appear to be used."
     },
     {
-      "prediction": "I think this is a bit of a hack. I think we should be able to do this with the `execute_powershell_script_on` method.",
+      "prediction": "I think we can remove the `execute_powershell_script_on(bolt, bolt_command)` line.",
       "reference": "I think this starts a new `powershell.exe` interpreter each time, which is pretty slow to run a single command. Can we just do `on(bolt, \"cmd /c #{bolt_command}\")`? /cc @Iristyle"
     },
     {
-      "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `link_to` instead of `link_to` in this case.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `collection?` method to check if the collection is available.",
       "reference": "Can we add a `collection?` method to the `VideoPage` so we don't violate Law of Demeter here?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `BufferedReader` instead of `StringBuffer` here.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use a `BufferedReader` to read from the log file.",
       "reference": "Deleting unused code."
     },
     {
-      "prediction": "I think this should be `assign_and_sample` instead of `assign_and_sample_and_bbox2delta`?",
+      "prediction": "I think this should be `assign_and_sample` instead of `assign_and_sample`",
       "reference": "`PseudoSampler` can also be imported from `..bbox`"
     },
     {
-      "prediction": "I don't think we need to use `protocol` package here. We can just use `github.com/algorand/go-algorand/protocol` directly.",
+      "prediction": "I don't think this is necessary.",
       "reference": "Could you move this import to where the other `github.com/algorand/go-algorand` imports are?"
     },
     {
-      "prediction": "I don't think this is a good idea. It would be better to have a list of all the layers that can be loaded by default.",
+      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
       "reference": "I'd rather not activate this protocol by default for now, unless there is a good reason for that."
     },
     {
-      "prediction": "I'm not sure if this is a good place to put this, but I think it would be good to have a separate file for this.",
+      "prediction": "I'm not sure if this is a good place to put this, but I think it would be good to have a `__init__.py` file in the `google.cloud.forseti.services.inventory.storage` package.",
       "reference": "Remove these 2 blank lines."
     },
     {
-      "prediction": "I'm not sure what you mean by \"aa\"",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `validateTx` function.",
       "reference": "Want to remove this?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"init registration\" here. Is this something you'd like to see in the docs?",
+      "prediction": "I don't think we need to register the postgres dialect here. We can just use the default postgres dialect.",
       "reference": "is this a golint requirement? huh. mixed feelings :)"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this test, but I think it's a bit misleading. The `matches` method is used to check if the password matches the encoded password. If you want to check if the encoded password matches the original password, you should use the `equals` method instead.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `BCryptPasswordEncoder.BCRYPT_VERSION_2B` and `BCryptPasswordEncoder.BCRYPT_VERSION_2Y` in the same class.",
       "reference": "Generally with these tests please split up these tests so that there is a different test for each method"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `lazy_pull_flush` function as well. This way, we don't have to call `lazy_pull_flush` every time we want to add a new pull.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a `lazy_pull_flush` method to the `bootstrap_attempt` class. This would allow us to flush the `lazy_pulls` and `lazy_max_pull_blocks` in a single call.",
       "reference": "Should something use the lock passed in?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you're trying to do here, but I think it's a bit of a red herring. I'm not sure what you",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `systemd`_ init system to simulate a real machine. The `systemd`_ init system has a number of advantages over the `systemd`_ init system. For example, it allows you to use the `systemd`_ init system to simulate a real machine, and it also allows you to use the `systemd`_ init system to simulate a real machine with the `systemd`_ init system, and it also allows you to use the `systemd`_ init system to simulate a real machine with the `systemd`_ init system, and it also allows you to use the `systemd`_ init system to simulate a real machine with the `systemd`_ init system, and it also allows you to use the `systemd`_ init system to simulate a real machine with the `systemd`_ init system, and it also allows you to use the `systemd`_ init system to simulate a real machine with the `systemd`_ init system, and it also allows you to use the `systemd`_ init system to simulate a real machine with the `",
       "reference": "Is this dependant on some version of Docker? Do we need to include both or `volumes` is deprecated (or just wrong!?)?"
     },
     {
-      "prediction": "I think it's better to use `if (leader != null && leader.getState() == State.ACTIVE && zkShardTerms.getHighestTerm() == zkShardTerms.getTerm(leader.getName()))` instead of `if (leader != null && leader.getState() == State.ACTIVE)`.",
+      "prediction": "I think this should be `if (leader != null && leader.getState() == State.ACTIVE && zkShardTerms.getHighestTerm() == zkShardTerms.getTerm(leader.getName()) && zkShardTerms.getTerm(leader.getName()) == zkShardTerms.getTerm(slice.getName()))`",
       "reference": "I know this is not new code, but should we change `leader.getState() == State.ACTIVE` to `leader.isActive(liveNodes)`?"
     },
     {
@@ -24311,15 +24311,15 @@
       "reference": "A blank line at the very end of each file should eliminate the \"No EOF\" warning we see above"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason you want to do this?",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate error type for `WorkflowExecutionAlreadyStartedError` and `CurrentWorkflowConditionFailedError` and `WorkflowConditionFailedError`.",
       "reference": "These would both be more robust with `errors.As` so that we could safely chain errors."
     },
     {
-      "prediction": "I think this should be `if (valobj_typename.startswith(\"_TtCs23_ContiguousArrayStorage\") || valobj_typename.startswith(\"_TtCs23_ContiguousArrayStorage\") || valobj_typename.startswith(\"Swift._ContiguousArrayStorage\"))`",
+      "prediction": "I think this should be `valobj_typename.startswith(\"_TtCs23_ContiguousArrayStorage\")`",
       "reference": "This is checking the same condition twice?"
     },
     {
-      "prediction": "I think this should be `if ((El::mpi::Size(c) > 4 && local_size <= 8192) || (El::mpi::Size(c) >= 16 && local_size <= 32768))` instead of `if ((El::mpi::Size(c) > 4 && local_size <= 8192) || (El::mpi::Size(c) >= 16 && local_size <= 32768)) || (El::mpi::Size(c) > 4 && local_size <= 8192) || (El::mpi::Size(c) >= 16 && local_size <= 32768))`",
+      "prediction": "I think this should be `if (m.GetLocalDevice() == El::Device::GPU)` instead of `if (m.GetLocalDevice() == El::Device::CPU)`.",
       "reference": "Aren't we able to handle the case where we have MPI-CUDA without NCCL, even if it's suboptimal?"
     },
     {
@@ -24327,11 +24327,11 @@
       "reference": "Wouldn't we want to namespace this `AA` or something similar"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this check to the `loadSharedConfig` function.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check here to see if the user has explicitly specified an AWS_PROFILE, and if not, then we should allow the shared config file to fail to load since the user has already provided credentials, and nothing else is required to be read from the shared config file.",
       "reference": "This probably should look beyond envConfig, and include `aws.Config.Credentials` as well."
     },
     {
-      "prediction": "I'm not sure if this is the best place to put this, but I think it's a good idea to add a `NotEnoughBalanceFilter` to the `FilterPipeline` so that it can be used to filter out transactions that don't have enough balance to be included in the pool.",
+      "prediction": "I'm not sure if this is the right place to add this filter, but I think it would be good to add it to the `NotEnoughBalanceFilter` and `TooExpensiveTxFilter` as well.",
       "reference": "How does this filter differ from TooExpensiveTxFilter?"
     },
     {
@@ -24343,11 +24343,11 @@
       "reference": "we might consider hard throwing when name is None since that is explicitly not working right now and then linking to issue in the exception error message"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this class, but it looks like you're trying to use the `@Entity` annotation to define a class that extends `Serializable`. However, the `@Entity` annotation is typically used to define an entity class, not a class that extends `Serializable`. If you want to use the `@Entity` annotation to define a class that extends `Serializable`, you should use the `@Entity` annotation on the class itself, not on the class that extends `Serializable`.",
+      "prediction": "I'm not sure what you're trying to achieve with this query, but it looks like you're trying to use a native query to get the value of a property from the database. However, there are a few issues with the query that need to be addressed:\n\n1. The `@Query` annotation should be used with the `@NamedNativeQueries` annotation.\n2. The `@Query` annotation should be used with the `@NamedQueries` annotation.\n3. The `@Query` annotation should be used with the `@NamedQueries` annotation.\n4. The `@Query` annotation should be used with the `@NamedQueries` annotation.\n5. The `@Query` annotation should be used with the `@NamedQueries` annotation.\n6. The `@Query` annotation should be used with the `@NamedQueries` annotation.\n7. The `@Query` annotation should be used with the `@NamedQueries` annotation.\n8. The `@Query` annotation should be used with the `@NamedQueries` annotation.\n9. The `@Query` annotation should be used with the `@NamedQueries` annotation.\n10. The `@Query` annotation should be used with the `@NamedQueries` annotation.\n1",
       "reference": "Just noticed this - why \"like\" and not straight \"=\""
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I think we should remove the `travis_vars` from the test.",
+      "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to make sure that the `env` object has the right number of `key` and `value` attributes.",
       "reference": "is this a new test? if yes, isn't it better to check for each env var is present, and the value, instead of a count?"
     },
     {
@@ -24359,15 +24359,15 @@
       "reference": "You should re-stringify it here with `QUrl.FullyEncoded`."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to decrypt the payload using the private key, the prepended ephemeral public key for el-Gamal, and the topic as salt. Is this what you're trying to do?",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this.",
       "reference": "i'm not sure why the quit channel is needed in this context"
     },
     {
-      "prediction": "I'm not sure what you mean by `args.CPULimit` here. Is it something like `args.CPURequest`?",
+      "prediction": "I'm not sure what you mean by `args.CPULimit` here. I think it should be `args.CPURequest`, right?",
       "reference": "When `args.MemoryLimit` is empty, will `MustParse` panic?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to queue a resync. I'm not sure what you're trying to do here, but it looks like you're trying to queue a resync. I'm not sure what you're trying to do here, but it looks like you're trying to queue a resync. I'm not sure what you're trying to do here, but it looks like you're trying to queue a resync. I'm not sure what you're trying to do here, but it looks like you're trying to queue a resync. I'm not sure what you're trying to do here, but it looks like you're trying to queue a resync. I'm not sure what you're trying to do here, but it looks like you're trying to queue a resync. I'm not sure what you're trying to do here, but it looks like you're trying to queue a resync. I'm not sure what you're trying to do here, but it looks like you're trying to queue a resync. I'm not sure what you're trying to do here, but it looks like you're trying to queue a resync. I'm not sure what you",
+      "prediction": "I'm not sure why we need to queue a resync here. We don't need to wait for the resync to complete before applying the changes.",
       "reference": "How soon after this will Apply() be called? It would be a shame if there was still a significant delay before a missing or superfluous route was corrected."
     },
     {
@@ -24375,23 +24375,23 @@
       "reference": "I add a `idx` property, and it is only use for benchmark `heap.Remove`, is it acceptable?"
     },
     {
-      "prediction": "I don't think we need to change this.",
+      "prediction": "I don't think this is necessary.",
       "reference": "daemonic t got inserted."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
+      "prediction": "I'm not sure what you mean by \"original genesis file with --genesis-file\"",
       "reference": "This edit is non-essential."
     },
     {
-      "prediction": "I don't think this is necessary. We can just use `parent.parentNode` instead.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "Might be safer to ponyfill this?"
     },
     {
-      "prediction": "I don't think we need to check if the directory already exists, since we're creating it anyway.",
+      "prediction": "I don't think we need to do this.",
       "reference": "why was this join not necessary before?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to set the timeout to infinity, so that we don't have to wait for the query to complete before checking the results.",
+      "prediction": "I think this is a bit silly, since we don't need to check the validity of the result, we just want to make sure that the query completes in a reasonable amount of time. Is there a reason why we need to check the validity of the result here?",
       "reference": "Here we compare to the expected call count 3. Because 3 TermsEnum are created: it is a PrefixQuery and there is one TermsEnum created for AutomatonQuery.intersect() (the next call timeout check is skipped once), then 2 TermsEnum created for the 2 matching terms \"one\" and \"ones\"). Would it be clearer to have a separate test method? We could index more docs, for example 50 with a prefix-generated term (e.g. \"term\"+increment). There would be a PrefixQuery for \"term\", the same test code, and we would test the TIMEOUT_CHECK_SAMPLING: - 1 TermsEnum for Automaton.intersect(), and the next calls would be sampled (50/TIMEOUT_CHECK_SAMPLING=3) => call count +4 - 1 TermsEnum for each enumerated term => call count +50 We could verify call count = 54 (instead of 101 without sampling)"
     },
     {
@@ -24399,19 +24399,19 @@
       "reference": "Add `--format` as an option. Does it make sense to have all display options available? Also need to add `--inventoryfile` and possibly the global_config_options."
     },
     {
-      "prediction": "I don't think we need to change this.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "Any thoughts on making this false by default? My suggestion is make this opt-in. Storing exception is somewhat expensive, so lets do this only if users opt-in"
     },
     {
-      "prediction": "I think this should be `try`/`catch` instead of `try`/`on`/`catch`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to move it to the `onSuccess` method.",
       "reference": "usually I do either ` IOException|RuntimeException` or if doing Throwable, use propagateIfFatal"
     },
     {
-      "prediction": "I think this should be a `Callable` instead of a `Callable[UniformNdMapping]`?",
+      "prediction": "I think this should be `Callable` instead of `Callable[Callable]`?",
       "reference": "Wondering whether it should be `self.clone`, or `other.clone` or maybe a new `DynamicMap` declaration entirely. I see this is in the condition where `other` is a `DynamicMap`but is this definitely right in terms of `kdims`? I need to think about it more..."
     },
     {
-      "prediction": "I don't think this is a good name for this class. It's not clear to me what it is used for.",
+      "prediction": "I don't think this is a good name for this class. It's not clear to me what it is used for. I would suggest renaming it to something like \"SolrComponent\" or \"SolrGroup\" or something.",
       "reference": "I chose a new category because over time I'd like to add metrics also for Authorization plugins and Auditlog plugins (all components registered in security.json). An alternative could have been `CONTAINER` I guess?"
     },
     {
@@ -24423,7 +24423,7 @@
       "reference": "PHPCR-ODM does not allow blank aliases.."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `ModifiableSolrParams` instead of the `SolrParams` directly.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `HttpSolrClient` class.",
       "reference": "This seems trivial to forge. Can we tie this into the authentication code paths somehow so that we can really trust that the request is coming from a server instead of just some application claiming to be a server?"
     },
     {
@@ -24431,11 +24431,11 @@
       "reference": "Why are you including ``?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to create a message queue for the health check.",
+      "prediction": "I think it's better to use `mk_mq_create` to create a message queue, and then use `mk_mq_open` to open the message queue.",
       "reference": "So previously health check was consuming from the normal metrics queue, now we duplicate the data to a new queue? I feel like there should be more changes to ensure the health check handler reads from the new queue? @DrewZhang13"
     },
     {
-      "prediction": "I think we can remove the last two lines.",
+      "prediction": "I don't think this is necessary.",
       "reference": "Yep, looks right; your new selector _should_ disqualify the rule from being XDP accelerated."
     },
     {
@@ -24447,23 +24447,23 @@
       "reference": "remove 3.8+ f-string format to allow use in google colab"
     },
     {
-      "prediction": "I'm not sure what you mean by \"fragile\" here. I think it's just that the alignment of xstate depends on the alignment of the special allocator's blocks.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to make sure that the alignment of `xstate` is the same as the alignment of the `kernel_xstate_t` struct.",
       "reference": "Should we assert that xstate is aligned here?"
     },
     {
-      "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to use the `@LuceneTestCase.SuppressCodecs` annotation for these tests.",
+      "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to have this in the `TestCloudJSONFacetJoinDomain` and `TestCloudJSONFacetRefinement` tests. I'm not sure if this is a good idea to have this in the `TestCloudJSONFacetJoinDomain` and `TestCloudJSONFacetRefinement` tests. I'm not sure if this is a good idea to have this in the `TestCloudJSONFacetJoinDomain` and `TestCloudJSONFacetRefinement` tests. I'm not sure if this is a good idea to have this in the `TestCloudJSONFacetJoinDomain` and `TestCloudJSONFacetRefinement` tests. I'm not sure if this is a good idea to have this in the `TestCloudJSONFacetJoinDomain` and `TestCloudJSONFacetRefinement` tests. I'm not sure if this is a good idea to have this in the `TestCloudJSONFacetJoinDomain` and `TestCloudJSONFacetRefinement` tests. I'm not sure if this is a good idea to have this in the `TestCloudJSONFacetJoinDomain` and `TestCloud",
       "reference": "any particular reason for suppressing this change?"
     },
     {
-      "prediction": "I think we can remove the `DIFFICULTY_BOMB_REMOVED` and `BYZANTIUM` from the `MainnetDifficultyCalculators` class.",
+      "prediction": "I'm not sure I understand what you're trying to do here. The `BYZANTIUM` calculator is supposed to calculate the difficulty of a Byzantium block, but it's not doing that. It's supposed to calculate the difficulty of a regular block, but it's not doing that either. I'm not sure what you're trying to do here. The `BYZANTIUM` calculator is supposed to calculate the difficulty of a Byzantium block, but it's not doing that. It's supposed to calculate the difficulty of a regular block, but it's not doing that either. I'm not sure what you're trying to do here. The `BYZANTIUM` calculator is supposed to calculate the difficulty of a Byzantium block, but it's not doing that. It's supposed to calculate the difficulty of a regular block, but it's not doing that either. I'm not sure what you're trying to do here. The `BYZANTIUM` calculator is supposed to calculate the difficulty of a Byzantium block, but it's not doing that. It's supposed to calculate the difficulty of a regular block, but it's not doing that either. I'm not sure what you're trying to do here. The `BYZANTIUM",
       "reference": "Hot take: could this instead become `NO_DIFFICULTY_BOMB` and have` HOMESTEAD` wrap it? So this comes first then homestad with the bomb adjustment, making no difficulty the base case?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a new variable that will be used to store a blob. I'm not sure what you're trying to do here, but it looks like you're trying to create a new variable that will be used to store a blob. I'm not sure what you're trying to do here, but it looks like you're trying to create a new variable that will be used to store a blob. I'm not sure what you're trying to do here, but it looks like you're trying to create a new variable that will be used to store a blob. I'm not sure what you're trying to do here, but it looks like you're trying to create a new variable that will be used to store a blob. I'm not sure what you're trying to do here, but it looks like you're trying to create a new variable that will be used to store a blob. I'm not sure what you're trying to do here, but it looks like you're trying to create a new variable that will be used to store a blob. I'm not sure what you're trying to do here, but it looks like you're trying to create a new variable that",
+      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to pass a URL to `blob.OpenBucket`, but you're not using `runtimevar.BytesDecoder` or `runtimevar.DecoderByName` to decode the URL.",
       "reference": "I suggest to use a scheme like \"blobvar\". \"blob\" would potentially collide if we have another API that use the blob package as a driver."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think this is the right place to do it.",
+      "prediction": "I think we can remove the `to_ts` field from the `fetch_listens` function.",
       "reference": "This assumes that the user has at least one listen, it should have a guard around it, because this won't always be the case"
     },
     {
@@ -24471,19 +24471,19 @@
       "reference": "Seems like a lot of unintended changes. Are your line break settings causing these?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `conda-forge` instead of `anaconda-forge` here.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `conda-forge` channel for `r-pkgdown` and `r-roxygen2`.",
       "reference": "@StrikerRUS what if we just removed build numbers and did `r-pkgdown=1.3.0`? Won't we have to fix this again if the RTD build machines change?"
     },
     {
-      "prediction": "I'm not sure what you're trying to say here. Is this a bug report or a feature request? If it's a bug report, please describe the problem. If it's a feature request, please describe the feature you'd like to add.",
+      "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to change the name of this file. I'm not sure if this is a good idea, but I'm not sure if it's a good idea to change the name of this file. I'm not sure if this is a good idea, but I'm not sure if this is a good idea to change the name of this file. I'm not sure if this is a good idea, but I'm not sure if this is a good idea to change the name of this file. I'm not sure if this is a good idea, but I'm not sure if this is a good idea to change the name of this file. I'm not sure if this is a good idea, but I'm not sure if this is a good idea to change the name of this file. I'm not sure if this is a good idea, but I'm not sure if this is a good idea to change the name of this file. I'm not sure if this is a good idea, but I'm not sure if this is a good idea to change the name of this file. I'm not sure if this is a good idea, but I'm not sure",
       "reference": "I'm not arguing with it, but how did you decide to make this change?"
     },
     {
-      "prediction": "I don't think this is a good idea. It would be better to have a `__init__.py` file in the root of the project.",
+      "prediction": "I don't think this is necessary.",
       "reference": "1: D400 First line should end with '.', not 'd' 4: I102 copyright year is outdated, expected 2014 but got 2012 25:29: E126 continuation line over-indented for hanging indent 31: D103 Docstring missing 40: D103 Docstring missing 57: D103 Docstring missing 68: D103 Docstring missing 101: D103 Docstring missing 115: D401 First line should be imperative: 'Call', not 'Calls' 115: D400 First line should end with '.', not 't' 134: D400 First line should end with '.', not 'e' 134: D205 Blank line missing between one-line summary and description"
     },
     {
-      "prediction": "I think this should be `Server` instead of `ACMEIssuer`?",
+      "prediction": "I think this should be `acme` instead of `ACME`.",
       "reference": "Explain that this must match the `CommonName` of the first (or is it last?) certificate in the chain, where the first certificate is the chain root CA and the last certificate is the leaf certificate."
     },
     {
@@ -24491,31 +24491,31 @@
       "reference": "do we really need this behavour to be configurable?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `array` module.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a separate file.",
       "reference": "Hmm interesting. Do the tests check out on this?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this, but it looks like you're trying to create a PoW solver that can be used to calculate the number of blocks that need to be mined in order to reach a certain block height. I'm not sure what you're trying to do with this, but it looks like you're trying to create a PoW solver that can be used to calculate the number of blocks that need to be mined in order to reach a certain block height. I'm not sure what you're trying to do with this, but it looks like you're trying to create a PoW solver that can be used to calculate the number of blocks that need to be mined in order to reach a certain block height. I'm not sure what you're trying to do with this, but it looks like you're trying to create a PoW solver that can be used to calculate the number of blocks that need to be mined in order to reach a certain block height. I'm not sure what you're trying to do with this, but it looks like you're trying to create a PoW solver that can be used to calculate the number of blocks that need to be mined in order to reach a certain block height. I'm not sure what you",
+      "prediction": "I'm not sure what you mean by `MAX_OMMER_DEPTH`. I think it should be 10000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
       "reference": "For another PR, another `--X` candidate."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to keep the `Release` and `Settings` in the `GettingStarted` section.",
+      "prediction": "I don't think it's necessary to have a `Release` in the `Getting Started` section.",
       "reference": "Do we need to add this constant for `group_windows.go`? Otherwise, I believe the build will fail on windows. Also what do you think of adding the emoji   at the end? The windows one could be plain."
     },
     {
-      "prediction": "I don't think this is necessary.",
+      "prediction": "I don't think this should be here. It should be in the `xpath` package.",
       "reference": "this is a junit 3 import, not a junit 4"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a test for the case where we don't have any syncsets, but we do have a HibernationActuator.",
+      "prediction": "I'm not sure I understand what you're trying to do here. I think you want to make sure that the `ClusterSync` is created before the `HibernationController` is started, but I'm not sure how to do that.",
       "reference": "shouldn't there be a reque expected here?"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bad idea. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe. It's not thread-safe.",
+      "prediction": "I don't think this should be a public property. It's only used for thread agnostic layouts.",
       "reference": "I prefer to make it `protected set`. What do you think?"
     },
     {
-      "prediction": "I'm not sure what you mean by `JetStreamMaxMemory` and `JetStreamMaxStore`. I think you meant `JetStreamMaxMemory` and `JetStreamMaxStore`",
+      "prediction": "I don't think we need to change the default value of `JetStreamMaxMemory` and `JetStreamMaxStore`.",
       "reference": "Maybe rename this to JetStreamStoreDir?"
     },
     {
@@ -24523,7 +24523,7 @@
       "reference": "You can start by logging out the error"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. The `FallbackGasPrice` property is not used anywhere in the code. It's only used in the `GetMinimumGasPrice` method, which is not part of the `FallbackGasPrice` property.",
+      "prediction": "I'm not sure what you're trying to do here. The `FallbackGasPrice` is just the fallback gas price, which is the gas price that would be used if there is no base fee per gas. If you want to get the base fee per gas, you should use `GetBaseFeePerGas` instead of `GetMinimumGasPrice`.",
       "reference": "In general, what is the reason for the fallback price to be public? If it is public, why does it take baseFeePerGas instead of a block header?"
     },
     {
@@ -24531,35 +24531,35 @@
       "reference": "follow-up of #2002"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is the right way to do it.",
+      "prediction": "I don't think we need to do this. The `tableScanThreadPool` is already set in the constructor, so we don't need to set it again.",
       "reference": "could you give some explanations of what problem do you want to solve by this change, and how/why it works?"
     },
     {
-      "prediction": "I think we should remove the `private readonly IXunitTestCase _testCase;` from the `SkippedTestCase` class.",
+      "prediction": "I think we can remove the `_skippedReason` field, as it's not used anywhere.",
       "reference": "LongLivedMarshalByRefObject exists in both the netstandard and netfx xunit?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with `@bridge.send_command(cmd: cmd, params: params)`, but I don't think that's the right way to do it. You should be using `bridge.send_command(cmd: cmd, params: params)` instead.",
+      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don",
       "reference": "the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here."
     },
     {
-      "prediction": "I'm not sure if this is the right place to add the `addDeathSig` function, but I think it's a good idea to have it here.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to add the `addDeathSig` function to the `containerd` package. I think it would be a good idea to have the `addDeathSig` function in the `containerd` package so that it can be used by the `containerd` package.",
       "reference": "Testing on linux with this change, containerd no longer stops when k3s stops."
     },
     {
-      "prediction": "I think this should be `allowConnectionWindowIncrease` instead of `AllowConnectionWindowIncrease`.",
+      "prediction": "I think this should be `AllowConnectionWindowIncrease` instead of `AllowConnectionWindowIncreaseFunc`.",
       "reference": "Maybe [u]int64 to be consistent with other byte-valued vars in this struct?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a link to \"New Request\" for NCR users.",
+      "prediction": "I think we should only show to NCR people.",
       "reference": "This brings up the question... do we need to start assigning users to the different use cases in some way? We don't want this link to show up for Ric, for example."
     },
     {
-      "prediction": "I think this is unnecessary. We don't need `prefetch_free_` and `prefetch_full_` anymore. We can just use `prefetch_current_` now.",
+      "prediction": "I think it's a good idea to make `prefetch_free_` and `prefetch_full_` public.",
       "reference": "Unless I'm misunderstanding something, this should just be `prefetch_(param.data_param().prefetch())`, no? That should just use the default value if there's no explicit `data_param` or `data_param.prefetch` set, removing the need to also duplicate and hardcode `PREFETCH_COUNT`."
     },
     {
-      "prediction": "I'm not sure what you mean by \"unknown transaction type\". I think it's just that we don't know what kind of transaction we're dealing with.",
+      "prediction": "I don't think this is a good idea. It would be better to have a separate function for `paymentTxEncode` and `keyregTxEncode`.",
       "reference": "nit : move this into a default clause in the previous switch statement."
     },
     {
@@ -24567,27 +24567,27 @@
       "reference": "It should be return \"''\"; I will fix it"
     },
     {
-      "prediction": "I think it's better to use `LeaderID` instead of `LeaderEndpoints` in the `LeadershipEvent` struct.",
+      "prediction": "I think it's better to use `LeaderID` instead of `LeaderEndpoints` in this case.",
       "reference": "Go standard linter hates `Id`s and likes `ID`s, please do not resist."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `git_fetch_ref` command that does the same thing as `git fetch origin +#{data.ref}:`.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `assert: true, timeout: :git_fetch_ref, fold: \"git.#{next_git_fold_number}\"` instead of `assert: true, timeout: :git_fetch_ref, fold: \"git.#{next_git_fold_number}\", retry: true`",
       "reference": "I don't think retrying here is as useful, since `git-checkout` doesn't access the network AFAIK, and if it fails once it's probably going to fail all three times."
     },
     {
-      "prediction": "I'm not sure what you mean by \"RenewalTime\" in this context. Is it the time when the certificate will be renewed, or the time when the certificate will expire?",
+      "prediction": "I don't think this is necessary. We can just use the `RenewalTime` field in the `v1.Certificate` struct.",
       "reference": "Fixing this typo caused a build failure in `cmd/ctl/pkg/status/certificate/certificate_test.go:238` Could you also update it there?"
     },
     {
-      "prediction": "I don't think this is a good idea. The `extension` field is not used anywhere in the packet, so it's not a good idea to have it in the `fields_desc` list. I think it's better to have it in the `fields` list.",
+      "prediction": "I'm not sure what you mean by \"extension condition\". Is it something like `pkt.extension == 31`?",
       "reference": "Please note that adding this will import `extension_condition` in the entire scapy (as you are located in a layer). You might want to move this inside the RTP class ? Would be better i think"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a `--fail-fast` option in the `RSpec::Core::Parser` class.",
+      "prediction": "I'm not sure I understand what you're trying to do here. Can you explain a bit more?",
       "reference": "This will need updating, as I'm not sure we'll want to turn on random ordering if they've specified a seed for programmatic use."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `privload_insert` function.",
+      "prediction": "I'm not sure if this is a good place to put this, but I think it should be in the `privmod_static` array.",
       "reference": "Are you sure these are all client libs? This seems fragile: if we later load sthg else early this will break. Seems best to have some kind of sanity check: at least add an assert in the current location where this is set."
     },
     {
@@ -24595,35 +24595,35 @@
       "reference": "Picking nits here, but as a Dictionary already is a collection of KeyValuePairs there's undoubtably a way to code this that doesn't involve constructing any new ones."
     },
     {
-      "prediction": "I think this should be `import static org.camunda.bpm.model.cmmn.impl.CmmnModelConstants.CMMN11_NS`",
+      "prediction": "I think this should be `org.camunda.bpm.model.cmmn.impl.CmmnParserImpl` instead of `org.camunda.bpm.model.cmmn.impl.CmmnParser`.",
       "reference": "As Miklas stated, please avoid wildcard imports."
     },
     {
-      "prediction": "I don't think this is necessary. The `server` function returns an object with `app` and `companionOptions`, so we don't need the `module.exports` here.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "Maybe change it to `module.exports = server` ? Becase there's nothing else to export here"
     },
     {
-      "prediction": "I'm not sure if this is a good place to put this, but I think it should be in the `testing` package, since it's part of the `testing/v1` package.",
+      "prediction": "I'm not sure if this is a good place to put this, but I think it should be in the `testing` package.",
       "reference": "This may be an automated change, but the import seems to fit better where it was previously."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `window.analytics` object instead of the `window.analytics` variable.",
+      "prediction": "I'm not sure if this is the best way to do this, but it seems to work.",
       "reference": "Might we want to separate including this snippet and sending the data for signed in users into different partials?"
     },
     {
-      "prediction": "I'm not sure if this is the best place to put this, but I think it would be good to have this in a separate file.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to `PeerAdder` and `ClosestPeerer` instead of `ClosestPeer` and `EachPeerer`.",
       "reference": "closest to the address"
     },
     {
-      "prediction": "I'm not sure if this is the right place to add this comment, but I think it would be good to add it to the `AutoRowSize` plugin documentation.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to add a note to the `AutoRowSize` plugin that it is disabled by default, and that you can enable it by setting the `autoRowSize` option to `true` (or `false` if you want to disable it).",
       "reference": "It should be much more clear for end-user"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a regex that will match a quoted string with a double quote character in the middle of the string. I'm not sure what you're trying to do here, but it looks like you're trying to create a regex that will match a quoted string with a double quote character in the middle of the string. I'm not sure what you're trying to do here, but it looks like you're trying to create a regex that will match a quoted string with a double quote character in the middle of the string. I'm not sure what you're trying to do here, but it looks like you're trying to create a regex that will match a quoted string with a double quote character in the middle of the string. I'm not sure what you're trying to do here, but it looks like you're trying to create a regex that will match a quoted string with a double quote character in the middle of the string. I'm not sure what you're trying to do here, but it looks like you're trying to create a regex that will match a quoted string with a double quote character in the middle of the string. I'm not sure what you're trying to do",
+      "prediction": "I'm not sure what you mean by `MSGS = {  # pylint: disable=consider-using-namedtuple` `MSGS = {  # pylint: disable=consider-using-namedtuple` `MSGS = {  # pylint: disable=consider-using-namedtuple` `MSGS = {  # pylint: disable=consider-using-namedtuple` `MSGS = {  # pylint: disable=consider-using-namedtuple` `MSGS = {  # pylint: disable=consider-using-namedtuple` `MSGS = {  # pylint: disable=consider-using-namedtuple` `MSGS = {  # pylint: disable=consider-using-namedtuple` `MSGS = {  # pylint: disable=consider-using-namedtuple` `MSGS = {  # pylint: disable=consider-using-namedtuple` `MSGS = {  # pylint: disable=consider-using-namedtuple` `MSGS = {  # pylint: disable=consider-using-namedtuple` `MSGS = {  # pylint: disable=consider-using-namedtuple` `MSGS = {  # pylint: disable=consider-using-namedtuple` `MSGS = {  # pylint: disable",
       "reference": "Isn't this an example that this will be prone to false positives ? We had nothing to fix in the codebase (And I think there is dict that could be named tuple in the MessageStore/MessageIdStore), but we have a false positives on our checkers."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for `NewRangeReader` and `Attributes` to make sure that the tests are independent of each other.",
+      "prediction": "I'm not sure if this is the right way to do this, but I think we should be able to do this with a single call to `NewRangeReader` instead of multiple calls to `NewRangeReader` and `Attributes`.",
       "reference": "We control `octest`, so it shouldn't be necessary to provide struct literal keys. This is a case of vet being too picky."
     },
     {
@@ -24639,63 +24639,63 @@
       "reference": "This would return a tuple of two dictionaries. You need to combine them and return a dictionary"
     },
     {
-      "prediction": "I think this should be `raise NotImplementedError` instead of `raise NotImplementedError()`.",
+      "prediction": "I think this should be `__call__` instead of `__repr__`.",
       "reference": "Why not always forward it to `_data`?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `login_required` decorator.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `login_required` decorator, so that it's only called when the user is logged in.",
       "reference": "there are tests that use `client.get` which will fail now"
     },
     {
-      "prediction": "I think this should be `if errors.Cause(err).(type) == libkbfs.WriteAccessError` instead of `if errors.Cause(err).(type) == libkbfs.WriteAccessError`",
+      "prediction": "I'm not sure what you mean by \"this doesn't matter\" in this case.",
       "reference": "Whoa, TIL about this syntax."
     },
     {
-      "prediction": "I think we can remove the `errorInfo` field from the `fakeHandler` struct, since it's not used in the `Handle` method.",
+      "prediction": "I think we can remove the `errorInfo` field from the `fakeHandler` struct, as it's not used anywhere.",
       "reference": "This is a smell. When is this valid? Perhaps this should be `nil, nil, ErrNoResponse` or some such. While it is usually invalid to have neither a return value or error, we rarely check for the case in other idiomatic Go. Nothing wrong with extra defenses here, but think about it."
     },
     {
-      "prediction": "I don't think this is a good idea. We should use `data.train` and `data.val` instead of `data.train_classes` and `data.val_classes`.",
+      "prediction": "I don't think this is a good idea. We should use `data.train` and `data.val` instead of `train` and `val`.",
       "reference": "This URL is outdated, add a `TODO` to fix it."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to set the `chainID` and `nonce` fields in the `envelope` struct, but you're also trying to set the `chainID` and `nonce` fields in the `ActionCore` struct. I think you want to set the `chainID` and `nonce` fields in the `ActionCore` struct, but you're trying to set the `chainID` and `nonce` fields in the `envelope` struct. I think you want to set the `chainID` and `nonce` fields in the `envelope` struct, but you're trying to set the `chainID` and `nonce` fields in the `ActionCore` struct. I think you want to set the `chainID` and `nonce` fields in the `ActionCore` struct, but you're trying to set the `chainID` and `nonce` fields in the `envelope` struct. I think you want to set the `chainID` and `nonce` fields in the `envelope` struct, but you're trying to set the `chainID` and `nonce` fields in the `ActionCore` struct.",
+      "prediction": "I don't think we need to change `chainID` to `chainID` in this case.",
       "reference": "`ChainID()` is a getter method, move up to `Nonce()`"
     },
     {
-      "prediction": "I think it's better to use `getScheduledFlowTriggerJobs()` instead of `getScheduledFlowTriggerJobs()` and `getScheduledFlowTriggerJobs()` instead of `getScheduledFlowTriggerJobs()` and `getScheduledFlowTriggerJobs()` instead of `getScheduledFlowTriggerJobs()` and `getScheduledFlowTriggerJobs()` instead of `getScheduledFlowTriggerJobs()` and `getScheduledFlowTriggerJobs()` instead of `getScheduledFlowTriggerJobs()` and `getScheduledFlowTriggerJobs()` instead of `getScheduledFlowTriggerJobs()` and `getScheduledFlowTriggerJobs()` instead of `getScheduledFlowTriggerJobs()` and `getScheduledFlowTriggerJobs()` instead of `getScheduledFlowTriggerJobs()` and `getScheduledFlowTriggerJobs()` instead of `getScheduledFlowTriggerJobs()` and `getScheduledFlowTriggerJobs()` instead of `getScheduledFlowTriggerJobs()` and `getScheduledFlowTriggerJobs()` instead of `getScheduledFlowTriggerJobs()` and `getScheduledFlowTriggerJobs()` instead of `getScheduledFlowTriggerJobs()` and `getScheduledFlowTriggerJobs()` instead of `getScheduledFlowTriggerJobs()` and `getScheduledFlowTriggerJobs()` instead of `getScheduledFlowTriggerJobs()` and `getScheduledFlowTriggerJobs()` instead of `get",
+      "prediction": "I think it's better to use `isPaused` and `flow.isLocked` instead of `isPaused` and `quartzTriggers.isEmpty()`.",
       "reference": "If this condition is not met, shall we just throw the exception rather than logging it? @li-ygerchikov Your thoughts?"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think we should add `ruamel.yaml` to the `REQUIRED_PACKAGES` list.",
+      "prediction": "I'm not sure if this is a good idea or not, but I think it would be a good idea to add `ruamel.yaml` to the `REQUIRED_PACKAGES` list. This is because `ruamel.yaml` is a dependency of `simple-crypt` and `simple-crypt` is a dependency of `parameterized`. If we don't add it to the `REQUIRED_PACKAGES` list, then `simple-crypt` and `parameterized` won't be able to use `ruamel.yaml`.",
       "reference": "nit: alpha-sort `ruamel.yaml` in this list please"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to create a plan with a split size that is not positive, but I'm not sure what you're trying to do with the `openFileCost` and `lookback` parameters. Could you please explain what you're trying to achieve with these parameters?",
+      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to create a plan with a split size that is not positive, but I'm not sure what you're trying to do with the `openFileCost` and `lookback` parameters.",
       "reference": "Remove this because we already added it in another pr"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `File` class instead of `FileInputStream` and `FileOutputStream`.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to check if the icon file exists before trying to copy it.",
       "reference": "Can we maybe move the `File` creation to a new method? I mean both changes look equal to me with the difference of two parts, which could be specified using two input parameters."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I think we should remove the `allow_blank: true, length: { minimum: 0, maximum: 255 }` from the `access_token` validation.",
+      "prediction": "I'm not sure what you mean by \"allow_blank: true\" in this case. I think it should be `allow_blank: false` or `blank: true` instead.",
       "reference": "I think we want to require the association with the user...?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"byteme\"",
+      "prediction": "I'm not sure if this is the correct way to determine a signed messages size on chain.",
       "reference": "I am unsure the below implementation is correct, but need this method to not panic else it borks the chain-validation tests."
     },
     {
-      "prediction": "I think we can remove `from collections import Iterable` and `from collections import OrderedDict` as they are not needed.",
+      "prediction": "I think we can remove the `from collections import Iterable` line.",
       "reference": "nit: no need this change anymore."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to add the source to the flow graph. I'm not sure what you're trying to do here, but it looks like you're trying to add the source to the flow graph. I'm not sure what you're trying to do here, but it looks like you're trying to add the source to the flow graph. I'm not sure what you're trying to do here, but it looks like you're trying to add the source to the flow graph. I'm not sure what you're trying to do here, but it looks like you're trying to add the source to the flow graph. I'm not sure what you're trying to do here, but it looks like you're trying to add the source to the flow graph. I'm not sure what you're trying to do here, but it looks like you're trying to add the source to the flow graph. I'm not sure what you're trying to do here, but it looks like you're trying to add the source to the flow graph. I'm not sure what you're trying to do here, but it looks like you're trying to add the source to the flow graph. I'm not sure",
+      "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason you want to add the source to the taint flow graph? If so, please provide more context and I'll be happy to help.",
       "reference": "This isn't really that closely related to everything else in this PR, but I'm pretty sure it's a correct change. I'm not familiar enough with the taint feature to know how to test it, but I worry that without this change some of the taint stuff might mess up the `parent_nodes` for a reference."
     },
     {
-      "prediction": "I don't think this is necessary. The `List` and `Vector` classes are already defined in the `javaslang.collection` package, so we don't need to import them here.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "[Checkstyle] ERROR: Unused import - javaslang.collection.Stream."
     },
     {
@@ -24703,7 +24703,7 @@
       "reference": "The numbers were changed since now _root_ is also added to the doc, increasing the field count by 1."
     },
     {
-      "prediction": "I think this should be `if ($variable_atomic_type instanceof TTemplateParamClass)` instead of `if ($variable_atomic_type instanceof TTemplateParamClass)`.",
+      "prediction": "I think this should be `if ($variable_atomic_type instanceof TTemplateParamClass)` instead of `if ($variable_atomic_type instanceof TTemplateParamClass && $function_call_arg->value->items[1]->value->value instanceof TTemplateParamClass)`.",
       "reference": "TTemplateParamClass is handled above with the same content in the conditional"
     },
     {
@@ -24711,15 +24711,15 @@
       "reference": "Do we need to add `theme` here?"
     },
     {
-      "prediction": "I think we should remove the `Subnets` field, as it's not used anywhere.",
+      "prediction": "I think we can remove the `InternetGatewayID` field.",
       "reference": "i think you have to regen the api stuff, `make generate`"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this. It looks like you're trying to generate a signature for a message using the SECP256K1 curve, but you're not actually using the SECP256K1 curve at all. Instead, you're generating a signature for a message using a different curve, such as Curve25519, and then normalizing the signature to match the SECP256K1 curve. Is this what you're trying to achieve?",
+      "prediction": "I'm not sure what you're trying to achieve here. The `normaliseSignature` method returns a `Signature` object, but the `SECP256K1` class does not have a `normaliseSignature` method. Is there a specific reason you want to use this method?",
       "reference": "DataHash shouldn't be needed here"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way",
       "reference": "`info` was chosen deliberately to mirror the old behaviour that users expected."
     },
     {
@@ -24727,19 +24727,19 @@
       "reference": "For some reason, Safari handles ember arrays differently than Chrome/Firefox. To get around that, we cast the ember array to a regular array to verify the deep equal. (Note: I tried wrapping the expected value in an emberA - which would look like `expect(someEmberArray).to.deep.equal(emberA(['a', 'b']));` but that didn't work either)"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to have a `NullabilityHolder` in a `VectorHolder`.",
       "reference": "`icebergType` indicates the corresponding iceberg type of the `FieldVector` `originalIcebergType` indicates what the real type we will read from the `FieldVector`. For example, the parquet int backed decimal, the `icebergType` should be integer, `originalIcebergType` is decimal. I intend to only keep the `originalIcebergType`, but listening to your ideas."
     },
     {
-      "prediction": "I'm not sure what you mean by `**storage.ObjectHandle, *storage.Writer``",
+      "prediction": "`**storage.ObjectHandle, *storage.Writer` should be `**storage.ObjectHandle, *storage.Writer, *storage.ObjectAttrs`",
       "reference": "The double (and thus triple as seen below) pointer gives me pause. I could imagine providing some larger API surface to smooth it out, but it's likely not worth it."
     },
     {
-      "prediction": "I'm not sure what you mean by \"ValidationErrors should be instances of Error\". I think you meant \"MongooseError should be instances of Error\".",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this.",
       "reference": "The test name as written was grammatically correct, but now it isn't. Both 'MongooseError' and 'instance' should be both singular or both plural."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to make sure that the database name is always set to the default if it is not set in the bundle.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `onCreate` method, so that we don't have to call it every time the activity is created.",
       "reference": "SmartStoreInspectorTest was throwing a NPE here"
     },
     {
@@ -24747,7 +24747,7 @@
       "reference": "We prefer line wrapping that keeps arguments to the same method aligned rather than aligning arguments to different levels. Here, the lambda to create an `InternalRecordWrapper` is an argument to `transform`, but it is aligned with `deleteSchema.asStruct()` that is an argument to the outer `toEqualitySet` call. Instead, can you add a newline for each argument to `toEqualitySet`? If the line with the lambda is too long, then you can also add a newline for it that it indented from the start of the line with `transform`, so it is clear that it is an argument to `transform` and not `toEqualitySet`."
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `sessionStats` object, since it's an array of objects.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to have this in the `sessionStats` object as well.",
       "reference": "I think it would be a good idea to wrap this in an if like the stats above, just in case."
     },
     {
@@ -24755,11 +24755,11 @@
       "reference": "@angmas1 just make one more change here too. Move the else line to the line above it, where the if block ends and remove the braces like in line 280."
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. I'm not sure if you're trying to create a new cgroup, or if you're trying to update an existing one. If you're trying to create a new cgroup, then I think you should be using `apply` instead of `join`. If you're trying to update an existing cgroup, then I think you should be using `apply` instead of `join`.",
+      "prediction": "I don't think we need to do this.",
       "reference": "Looks like the actual rename is missing in this commit edit: Arf, nevermind, I was at the wrong commit"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check for `this.opts.getAssemblyOptions === defaultOptions.getAssemblyOptions` before calling `AssemblyOptions.validateParams`. This way, if `this.opts.getAssemblyOptions === defaultOptions.getAssemblyOptions` is true, we don't try to validate the params, and if `this.opts.getAssemblyOptions === defaultOptions.getAssemblyOptions` is false, we don't try to validate the params either.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check for `this.opts.getAssemblyOptions === defaultOptions.getAssemblyOptions` to make sure we don't do this if we don't have a custom `getAssemblyOptions` option.",
       "reference": "I'm a little stuck understanding, how would this result in an error when `this.opts.params` is not set? It will just not do `AssemblyOptions.validateParams(this.opts.params)`"
     },
     {
@@ -24767,11 +24767,11 @@
       "reference": "networkVarPattern (etc) then?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I think we should be able to do this without cloning the example group.",
+      "prediction": "I'm not sure why we need to clone the example group here. I think we can just create a new example group with the new metadata.",
       "reference": "I think it makes sense to do `metadata[:block].clone`, as thats what `new_metadata` is, but somehow it's missing the block from its clone."
     },
     {
-      "prediction": "I'm not sure what you mean by this, but I think it's a good idea to add a `getFilePath()` method to `ClosureAnalyzer` that returns the full path of the closure file.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a `getClosureId` method to the ClosureAnalyzer class. This would allow the ClosureAnalyzer class to be used as a base class for other analyzers.",
       "reference": "Just realized this should be fixed instead of changing here. Concatenating int should still result in lowercase string."
     },
     {
@@ -24779,7 +24779,7 @@
       "reference": "For Se 3.x we shouldn't need to specify `marionette: true`? I'll see if I can figure out where this is getting used that it might be necessary here."
     },
     {
-      "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place",
+      "prediction": "I don't think we need to do this.",
       "reference": "This should be renamed to `chain.Store`. It was named `DefaultStore` as an alternative to `StoreImpl`, which is the (bad) Java convention."
     },
     {
@@ -24791,27 +24791,27 @@
       "reference": "typo: \"be hold\" -> \"be held\""
     },
     {
-      "prediction": "I think this should be `get; set;` instead of `get => long.MaxValue;` and `set => 1;`",
+      "prediction": "I think this should be `long?` instead of `long`?",
       "reference": "I do not think we should have any logic inside the null storage. 1 has a very specific magical meaning. We should either return null here or long.maxValue."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the",
       "reference": "Why did this change?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to move this to `PlansController#show` instead of `PlansController#edit`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to move this into the `PlansController` so that it can be used by other controllers as well.",
       "reference": "Removed this method. Doesn't seem to be used in the code, and the variable set here doesn't seem to be used in the views."
     },
     {
-      "prediction": "I don't think this is a good idea. The `PropertyBagDictionary` constructor should not take a `PropertyBagDictionary` as a parameter. It should take a `PropertyBagDictionary` and a `PolicyName` as parameters.",
+      "prediction": "I think this should be `PropertyBagDictionary(PropertyBagDictionary initializer = null)` instead of `PropertyBagDictionary(PropertyBagDictionary initializer = null, PropertyBagDictionary initializer2 = null)`.",
       "reference": "Remove the initializers (\"`= null`\") from both parameters. Remember that that's why we added the overloads: to ensure that all languages could have the convenience of the abbreviated argument lists (not all languages understand default parameters)."
     },
     {
-      "prediction": "I think this should be `ElementType` instead of `ElementType() semantic.MonoType`?",
+      "prediction": "I think this should be `ValueVector` instead of `Vector`.",
       "reference": "I think you can just remove most of these attributes outside of `ElementType()`. Instead, this should expose the arrow array. We're not going to use these methods anyway."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to do something like this:\n\n```js\nconst Component = () => {\n  return (\n    
    \n      
    Hello
    \n    
    \n  );\n}\n```\n\nIs this what you're trying to achieve?",
+      "prediction": "I think it's better to use `props` directly in the `diff` function.",
       "reference": "Thinking this should be `removeNode()` exported from `dom/index.js`. Thoughts?"
     },
     {
@@ -24819,39 +24819,39 @@
       "reference": "Does this need to be saved in the state file? Or are we recomputing when the task is read from the state file?"
     },
     {
-      "prediction": "I think we can remove the `if st.NumMatches > 0` check here.",
+      "prediction": "I'm not sure if this is a good place to put it, but I think we should move it to the `SublistStats` struct.",
       "reference": "Looks like `s.inserts` and `s.removes` are updated under sublist's lock, so I don't think you need atomic for those 2."
     },
     {
-      "prediction": "I think this should be `wifiStatus &= ~ESPEASY_WIFI_GOT_IP;` instead of `wifiStatus &= ~ESPEASY_WIFI_SERVICES_INITIALIZED;`",
+      "prediction": "I think it's better to set the wifiStatus to ESPEASY_WIFI_GOT_IP and ESPEASY_WIFI_SERVICES_INITIALIZED at the same time.",
       "reference": "@TD-er use bitRead/bitWrite macros, do you use here inversed logic?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this, but it looks like you're using `fetch-mock-jest` to mock the `fetch` API, but you're not using it to mock the `apiFetch` API. I'm not sure what you're trying to do with this, but it looks like you're using `fetch-mock-jest` to mock the `fetch` API, but you're not using it to mock the `apiFetch` API. I'm not sure what you're trying to do with this, but it looks like you're using `fetch-mock-jest` to mock the `fetch` API, but you're not using it to mock the `apiFetch` API. I'm not sure what you're trying to do with this, but it looks like you're using `fetch-mock-jest` to mock the `fetch` API, but you're not using it to mock the `apiFetch` API. I'm not sure what you're trying to do with this, but it looks like you're using `fetch-mock-jest` to mock the `fetch` API, but you're not using it to mock the `apiFetch` API. I'm not sure what you",
+      "prediction": "I'm not sure what you're trying to do with this, but it looks like you're using `fetch-mock-jest` to mock the `fetch` API, but you're not using it to mock the `fetch-mock` API. I'm not sure what you're trying to do with this, but it looks like you're using `fetch-mock-jest` to mock the `fetch` API, but you're not using it to mock the `fetch-mock` API. I'm not sure what you're trying to do with this, but it looks like you're using `fetch-mock-jest` to mock the `fetch` API, but you're not using it to mock the `fetch-mock` API. I'm not sure what you're trying to do with this, but it looks like you're using `fetch-mock-jest` to mock the `fetch` API, but you're not using it to mock the `fetch-mock` API. I'm not sure what you're trying to do with this, but it looks like you're using `fetch-mock-jest` to mock the `fetch` API, but you're not using it to mock the `fetch-mock` API. I",
       "reference": "The previous `fetch` mock was exposed globally before - can we do the same with `fetchMock` so we don't need to import it in every file?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.",
+      "prediction": "I think this should be `if (context.EndStreamReceived)` instead of `if (!context.ExpectData)`",
       "reference": "Is ExpectData still used anywhere?"
     },
     {
-      "prediction": "I think it's better to use `~!` and `~.` instead of `~!` and `~!.`",
+      "prediction": "I think it's better to use `r'\\w(?:\\w|\\.[^\\.]*)'` instead of `r'\\w(?:\\w|\\.[^\\.]*)'`",
       "reference": "Do you want to allow the character `.` or any character? Because inside a regex `.` means any character, if you want to authorize `.` then you need to add `\\.` ."
     },
     {
-      "prediction": "I think we can remove this test as it's not relevant to the rest of the tests.",
+      "prediction": "I'm not sure if this is the right way to do this, but I think we should be able to do this in a single test.",
       "reference": "`eachAsync()` should pass a doc, not an array of docs, to the callback. This would be a massive breaking change."
     },
     {
-      "prediction": "I think this should be `klog.V(4).Infof(\"message: %s process successfully\", msg.GetID())` instead of `klog.V(4).Info(\"message: %s process successfully\", msg.GetID())`",
+      "prediction": "I think it's better to use `klog.Warning` instead of `klog.Warningf`.",
       "reference": "please start log with caps letters"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to use the visual_website_optimizer gem, but it's not included in this gem. I think you're trying to use the visual_website_optimizer gem, but it's not included in this gem. I think you're trying to use the visual_website_optimizer gem, but it's not included in this gem. I think you're trying to use the visual_website_optimizer gem, but it's not included in this gem. I think you're trying to use the visual_website_optimizer gem, but it's not included in this gem. I think you're trying to use the visual_website_optimizer gem, but it's not included in this gem. I think you're trying to use the visual_website_optimizer gem, but it's not included in this gem. I think you're trying to use the visual_website_optimizer gem, but it's not included in this gem. I think you're trying to use the visual_website_optimizer gem, but it's not included in this gem. I think you're trying to use the visual_website_optimizer gem, but it's not included in this gem. I think you're trying to use the visual_website_optimizer gem, but it's not included in this gem. I think",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `visual_website_optimizer` gem for this kind of thing.",
       "reference": "Is this where we want it in relation to the other scripts?"
     },
     {
-      "prediction": "I don't think this is a good idea. The `countlyView.extend` method is used to extend the `countlyView` class, so it's not a good idea to extend the `countlyView` class.",
+      "prediction": "I don't think this is a good name for this feature. I think it's better to name it something like \"reporting\" or something like that.",
       "reference": "Please wrap this variable within a self invoking anonymous function. (function(){ FEATURE_NAME = \"reports\"; //and rest of the js goes here. })();"
     },
     {
@@ -24863,19 +24863,19 @@
       "reference": "no need for custom errors in tests unless the tests are intended to mock a specific sort of error"
     },
     {
-      "prediction": "I think we should remove `NvidiaGPUScalarResourceName` and `EdgeNodeRoleLabelKey` as they are not used anymore.",
+      "prediction": "I think it's better to use `nvidia.com/gpu` instead of `nvidia.com/gpu-status`",
       "reference": "This const has already existed in the code, no need to define a new one"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `logging` package.",
+      "prediction": "I'm not sure if this is the best place to do this, but I think it's a good idea to log the error in the `reportErrorf` function as well.",
       "reference": "Would Errorf be better than Warnf?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but it seems to work.",
+      "prediction": "I don't think we need to do this anymore.",
       "reference": "A good candidate for StringBuilder? Also make sure to add white space around the operators (`path + \"/\" + file`)"
     },
     {
-      "prediction": "I think this should be `uploadFlowFile(int projectId, int projectVersion, int flowVersion, File flowFile)` instead of `uploadFlowFile(int projectId, int projectVersion, int flowVersion, File flowFile)`",
+      "prediction": "I think this should be `uploadFlowFile` instead of `uploadFlowFile(int projectId, int projectVersion, int flowVersion, File flowFile)`",
       "reference": "Can we have the same argument order as `getUploadedFlowFile`?"
     },
     {
@@ -24883,7 +24883,7 @@
       "reference": "this dynamic config should still be valid, i.e. operator should have the ability to control each individual task queue just in case"
     },
     {
-      "prediction": "I think this should be `scrollIntoView()` instead of `scrollIntoView()`",
+      "prediction": "I think this should be `scrollIntoView` instead of `scrollIntoView()`?",
       "reference": "Should these cases be logged? `if not obj` used to be"
     },
     {
@@ -24891,7 +24891,7 @@
       "reference": "Is it OK to assume that keys.gnupg.net has the new key?"
     },
     {
-      "prediction": "I'm not sure if this is a good idea or not, but I'm not sure if we want to add this flag to all FileSystem subclasses. If we do, then we should also add this flag to all FileSystem subclasses that don't implement this method.",
+      "prediction": "I'm not sure if this is a good place to put this, but I think we should add a docstring for this method.",
       "reference": "A note for however is curious. I think these two notes add negative value only. In general we want people to implement this method (in particular after this patch). If we leave these old (and currently mis-rendered) notes, file system implementors might not implement this method referring to this."
     },
     {
@@ -24899,11 +24899,11 @@
       "reference": "Comparators (or functions in general) cannot be compared for equality. Therefore `PriorityQueue.of(comparator, ...)` always has to return a new instance."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
+      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. The `@pool` variable is shared between the `@noop`, `@run_as`, and `@notifier` methods. If you want to share the `@pool` variable between these methods, you should create a new instance of `Concurrent::ThreadPoolExecutor` for each of these methods.",
       "reference": "It's a little surprising that CachedThreadPool overrides the max_threads argument. This makes sense as a solution though."
     },
     {
-      "prediction": "I think it's better to use `reduce_loss` function instead of `weight_reduce_loss` in this case.",
+      "prediction": "I don't think this is necessary.",
       "reference": "```python # if avg_factor is not specified, just reduce the loss if avg_factor is None: loss = reduce_loss(loss, reduction) else: # if reduction is mean, then average the loss by avg_factor if reduction == 'mean': loss = loss.sum() / avg_factor # if reduction is 'none', then do nothing, otherwise raise an error elif reduction != 'none': raise ValueError('avg_factor can not be used with reduction=\"sum\"')"
     },
     {
@@ -24911,63 +24911,63 @@
       "reference": "`padding` should be 0 instead. Actually you can just remove padding and dilation to use default values."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea.",
       "reference": "$balance is initialized to 0 above in line 1428 and then assigned in line 1437. If we're no longer manipulating that value, is there a reason to use a variable at all? It might make the overall code less confusing to make some changes there."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `self.plot_to_base64` in this way.",
+      "prediction": "I think this test is a bit misleading. The `plot` method of the `SeriesPlot` class returns a `matplotlib.axes.Axes` object, not a `matplotlib.figure.Figure` object. The `plot` method of the `SeriesPlot` class returns a `matplotlib.axes.Axes` object, not a `matplotlib.figure.Figure` object. The `plot` method of the `SeriesPlot` class returns a `matplotlib.axes.Axes` object, not a `matplotlib.figure.Figure` object. The `plot` method of the `SeriesPlot` class returns a `matplotlib.axes.Axes` object, not a `matplotlib.figure.Figure` object. The `plot` method of the `SeriesPlot` class returns a `matplotlib.axes.Axes` object, not a `matplotlib.figure.Figure` object. The `plot` method of the `SeriesPlot` class returns a `matplotlib.axes.Axes` object, not a `matplotlib.figure.Figure` object. The `plot` method of the `SeriesPlot` class returns a `matplotlib.axes.Axes` object, not a `matplotlib.figure.Figure` object. The `plot` method of the `SeriesPlot` class returns a `matplotlib.axes.Axes` object, not",
       "reference": "Why do we need to explicitly use keyword arguments?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"the build result will be logged in build/build_step.go\"",
+      "prediction": "I don't think we need to log the build result in this case. The build result will be logged in build/build_step.go.",
       "reference": "Might still want to log this as `TargetBuilding` but with a slightly different message?"
     },
     {
-      "prediction": "I think this should be `for (byte i = 0; i < VARS_PER_TASK; ++i) {` instead of `for (byte i = 0; i < VARS_PER_TASK; ++i) { txt[i] = std::move(other.txt[i]); vPin[i] = other.vPin[i]; }`",
+      "prediction": "I think this should be `= std::move(other)` instead of `= std::move(other)`.",
       "reference": "ref. above, this also can be omitted in case `txt = std::move(other.txt);` could work (or copy), consider `std::array;`? or a custom object implementing `Object& operator=(Object&&) noexcept;'"
     },
     {
-      "prediction": "I'm not sure what you mean by \"too much code in the try clause\". I think it's more like \"too much code in the body of the try clause\".",
+      "prediction": "I think this is a bit of a red herring. The `For` and `While` nodes are already checked by the checker, so we don't need to add this check here.",
       "reference": "Well done, we forget that one apparentely."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to convert a dask array to a numpy array, but you're not using the `compute()` method. I'm not sure what you're trying to do here, but it looks like you're trying to convert a dask array to a numpy array, but you're not using the `compute()` method. I'm not sure what you're trying to do here, but it looks like you're trying to convert a dask array to a numpy array, but you're not using the `compute()` method. I'm not sure what you're trying to do here, but it looks like you're trying to convert a dask array to a numpy array, but you're not using the `compute()` method. I'm not sure what you're trying to do here, but it looks like you're trying to convert a dask array to a numpy array, but you're not using the `compute()` method. I'm not sure what you're trying to do here, but it looks like you're trying to convert a dask array to a numpy array, but you're not using the `compute()` method. I'm not sure what you're trying to do",
+      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to convert a dask array to a numpy array, but you're returning a value instead of an array holding a single value. Is this what you're trying to do?",
       "reference": "Guess it isn't used. The dask thing was just a prototype so removing it is probably the right thing to do."
     },
     {
-      "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to add a docstring to this function. It's not clear to me what this function is doing.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in a separate file, so that it can be unit tested. I'm not sure if this is the right place to do this, but I think it's a good idea to have this in a separate file, so that it can be unit tested. I'm not sure if this is the right place to do this, but I think it's a good idea to have this in a separate file, so that it can be unit tested. I'm not sure if this is the right place to do this, but I think it's a good idea to have this in a separate file, so that it can be unit tested. I'm not sure if this is the right place to do this, but I think it's a good idea to have this in a separate file, so that it can be unit tested. I'm not sure if this is the right place to do this, but I think it's a good idea to have this in a separate file, so that it can be unit tested. I'm not sure if this is the right place to do this, but I think it's a good idea to have this in a separate",
       "reference": "This code is correct, but it's a bit confusing to see how (e.g., without the if startswith(\".') the or below would break.) I think it will be clearer for the long run if you refactor this just a bit. CONTENT_INDEX_EXTS (all caps) looks like a constant, but is now being set by the environment. Instead, replace the reference to CONTENT_INDEX_EXTS in index.py with a simple call to a method \"get_content_index_exts\" (or similar). Then you can write all the logic into one clean function."
     },
     {
-      "prediction": "I think we can remove `ZMS_PROP_ENABLE_PRINCIPAL_STATE_UPDATER` and `ZMS_PROP_PRINCIPAL_STATE_UPDATER_DISABLE_TIMER` from the `ZMSConsts` class.",
+      "prediction": "I think it's better to use `ZMS_PROP_ENABLE_PRINCIPAL_STATE_UPDATER` and `ZMS_PROP_PRINCIPAL_STATE_UPDATER_DISABLE_TIMER` instead of `ZMS_PROP_ENABLE_PRINCIPAL_STATE_UPDATER` and `ZMS_PROP_PRINCIPAL_STATE_UPDATER_FREQUENCY`.",
       "reference": "please update the zms conf file to have a small description of these options since by default feature is off and must be enabled"
     },
     {
-      "prediction": "I'm not sure what you mean by \"mutually exclusive\" here. Is it possible to have both `lazy` and `waitForThumbnailsBeforeUpload` set to `true` at the same time?",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to make sure that the `waitForThumbnailsBeforeUpload` option is only set to `true` if the `lazy` option is also set to `true`.",
       "reference": "Should be `this.opts` instead of `defaultOptions`"
     },
     {
-      "prediction": "I think this should be `const pkgName = module.exports.name;` instead of `const pkgName = module.exports.name;`",
+      "prediction": "`assert` is not needed here. `_.isString(pkgName)` is enough.",
       "reference": "You can reuse `USERS` above as well."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. Can you give an example of what you're trying to do?",
+      "prediction": "I'm not sure I understand what you're trying to do here.",
       "reference": "Whoa, was this opto breaking something? I guess if this final path is filtered out, we still need the queue? Have you run the suggest benchmarks to see if removing this opto hurt performance?"
     },
     {
-      "prediction": "I think this should be `List.ofAll` instead of `Stream.ofAll`.",
+      "prediction": "I think this is unnecessary. `List.ofAll` and `Stream.ofAll` are the same thing.",
       "reference": "I'm not sure about this, please check the usages. It's only used currently to reverse it, maybe we should eliminate this method completely instead."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this method in the `AbstractActionController` class.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the `AbstractActionController` as well.",
       "reference": "Since this is only used in the MyResearchController, does it need to be placed at the AbstractBase level?"
     },
     {
-      "prediction": "I think we can remove the `json:\"phaseSelector,omitempty\"` from the `SelectorSpec` struct.",
+      "prediction": "I think it's better to have a `PhaseSelector` and a `PodPhaseSelector` in the same struct.",
       "reference": "why `PhaseSelector` ?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don",
+      "prediction": "I'm not sure what you're trying to do with this field, but I think we should remove it.",
       "reference": "Does` AllowlistedModules` have the same meaning of `WhitelistedModules`?"
     },
     {
@@ -24975,7 +24975,7 @@
       "reference": "I missed the $preserve_keys=true case when adding this to Phan. For psalm, two separate signatures may make sense"
     },
     {
-      "prediction": "I don't think we need to use `vertxTLSBuilder` here. We can just use `vertxTLSBuilder` from `org.apache.servicecomb.foundation.ssl.SSLOptionFactory`.",
+      "prediction": "I don't think we need to use `ClientConnectedEvent` here. We can use `VertxTLSBuilder` directly.",
       "reference": "TcpServer will be created for each HighwayServerVerticle instance so the counter number in server is not correct."
     },
     {
@@ -24991,51 +24991,51 @@
       "reference": "I dont see a reason to print URI for `Target`. we do not expose that in inventory v1"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to make the `Bool` and `List` fields `*bool` and `*List` instead of `*int` and `*Dict`.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `*struct` for the `Bool` and `List` fields, and `*int` for the `Int` field. This way, we don't have to worry about whether the underlying type is `bool` or `int`, and we don't have to worry about whether the underlying type is `*int` or `*struct{Int int}`.",
       "reference": "Do we still need this?"
     },
     {
-      "prediction": "I'm not sure what this is for, but it looks like it could be used as a way to pass in an anonymous client ID. I'm not sure if this is a good idea, but I'll leave it for now.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `Gclient` struct, since it's used by both `Gclient` and `Application` structs.",
       "reference": "`campaignSource` is unused (from `structcheck`)"
     },
     {
-      "prediction": "I think this should be `PROP_ERROR_PRONE_APPLY` and `PROP_REFASTER_APPLY` instead of `PROP_ERROR_PRONE_APPLY` and `PROP_REFASTER_APPLY`.",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a separate version of the error-prone plugin that is compatible with the baseline error-prone plugin. This way, we don't have to worry about breaking backwards compatibility with the baseline error-prone plugin. I'm not sure if this is a good idea, but I think it's a good idea to have a separate version of the error-prone plugin that is compatible with the baseline error-prone plugin. This way, we don't have to worry about breaking backwards compatibility with the baseline error-prone plugin. I'm not sure if this is a good idea, but I think it's a good idea to have a separate version of the error-prone plugin that is compatible with the baseline error-prone plugin. This way, we don't have to worry about breaking backwards compatibility with the baseline error-prone plugin. I'm not sure if this is a good idea, but I think it's a good idea to have a separate version of the error-prone plugin that is compatible with the baseline error-prone plugin. This way, we don't have to worry about breaking backwards compatibility with the baseline error-prone plugin. I'm not sure if this is a",
       "reference": "we should discuss how to not hard-code this version"
     },
     {
-      "prediction": "I'm not sure what you mean by `maxAwaitTimeMS` and `startAfter` in the `CHANGE_STREAM_OPTIONS` array. Could you please clarify?",
+      "prediction": "I'm not sure if this is the right place for this, but I think we should move it to the `core` module.",
       "reference": "do we have a doclet for this event?"
     },
     {
-      "prediction": "I think this should be `require('segfault-handler')` instead of `node_require('segfault-handler')`",
+      "prediction": "I think this should be `require('segfault-handler').registerHandler(\"crash.log\");`",
       "reference": "Why don't we want to catch segfaults by default?"
     },
     {
-      "prediction": "I don't think we need to dispose of the requestUri here.",
+      "prediction": "I don't think we need to dispose of this object here.",
       "reference": "You could probably dispose request & content if you `await` the SendAsync."
     },
     {
-      "prediction": "I'm not sure what you mean by \"this should pass and run fine\"",
+      "prediction": "I'm not sure what you mean by \"this should pass and run fine\". It's not clear to me what you're trying to test here.",
       "reference": "why is this test case here? this file is for testing functionalities in utils.py"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `User` model.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a separate controller.",
       "reference": "why do we have an env var for this? not sure why we'd want to suppress welcome emails but not any others"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that we don't get a bad expression here.",
+      "prediction": "I think this should be `loc := p.loc(pos, pos+token.Pos(len(lit)))` instead of `loc := p.loc(pos, pos+token.Pos(len(lit)))`",
       "reference": "drop the todo?"
     },
     {
-      "prediction": "Shouldn't this be `if (!IsDoorOpen() || (open_type == 58))`?",
+      "prediction": "Shouldn't this be `if (open_type == 58)` instead of `if (!disable_timer)`?",
       "reference": "Maybe use { } here like we are most other places now."
     },
     {
-      "prediction": "I think this should be `partitionType` instead of `partitionType.fields().get(pos).type()`.",
+      "prediction": "I think this should be `partitionType` instead of `schema`.",
       "reference": "I want to get PartitionData field type, I don't know how to get it in other way."
     },
     {
-      "prediction": "I'm not sure I understand what you mean by \"specific creatable\" and \"specific creatable type\". Could you please provide more context?",
+      "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you want to be able to call `GetEx` with `ctype` and `cidx` and get the `AccountData` with `ctype` and `cidx` and `withPendingRewards` set to `true`. Is that what you're trying to do?",
       "reference": "I think that a single `Get` method would be preferable, that would have the following parameters: Get(addr basics.Address, withPendingRewards bool, cidx basics.CreatableIndex, ctype basics.CreatableType) where we ignore cidx of -1, and adding support for ctype of \"AssetParams\" or something like that. (i.e. so that this Get call would be good for asset holding/asset params and applications )"
     },
     {
@@ -25043,15 +25043,15 @@
       "reference": "This can handle the '\\\\' problem, but if (not possible) the user define '\\\\' as null, this logic will break. So here, it should be to compare the whole HIVE_DEFAULT_NULL_STRING, and make sure length is equal, as I understand. \\N is NULL, but \\NA is not NULL, what will happen if there is \\NAA ?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check for `@user.id == @record.user_id || role.client_admin? || @user.admin?` in the `can_destroy!` method.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `ObservationPolicy` class.",
       "reference": "Hmm, I would think that anyone who can edit the request should be able to delete the observation, in case they accidentally add the wrong person or something."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to get a list of templates that are publicly visible, but I'm not sure what you're trying to do here. I think you're trying to get a list of templates that are publicly visible, but I'm not sure what you're trying to do here. I think you're trying to get a list of templates that are publicly visible, but I'm not sure what you're trying to do here. I think you're trying to get a list of templates that are publicly visible, but I'm not sure what you're trying to do here. I think you're trying to get a list of templates that are publicly visible, but I'm not sure what you're trying to do here. I think you're trying to get a list of templates that are publicly visible, but I'm not sure what you're trying to do here. I think you're trying to get a list of templates that are publicly visible, but I'm not sure what you're trying to do here. I think you're trying to get a list of templates that are publicly visible, but I'm not sure what you're trying to do here. I think you're trying to get a list of templates that",
+      "prediction": "I'm not sure what you're trying to do here, but I think it's a bad idea to use `template_ids.flatten` here.",
       "reference": "I know we are doing this other places already. It would be good to refactor this and the paginable publicly_visible so that we are DRY. Can wait until after MVP though when we do general cleanup"
     },
     {
-      "prediction": "I'm not sure what you mean by \"weakly ordered arches\", but I think it's important to note that this is not the same as \"weakly ordered\" in the context of the IBL.",
+      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to do something like this:\n\n```\nstate->table_space.table[table->branch_type].hash_mask = table->hash_mask;\nstate->table_space.table[table->branch_type].lookuptable = table->lookuptable;\n```\n\nIs that what you're trying to do?",
       "reference": "I think this should read \"is always observed before\" or \"is never observed after\"."
     },
     {
@@ -25059,35 +25059,35 @@
       "reference": "You might consider adding yourself as an author of the class."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `freopen` in this way.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.",
       "reference": "If this fails, then 'stderr' is not a valid file handler anymore, and then any further 'write' operations will fail. Maybe some handling of such situation should be added here?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
+      "prediction": "I think this is a bit of a red herring here. We don't care about the timestamp, we just want to make sure that the span is created and that it's not null.",
       "reference": "Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to create a hex string of the length of the value, and then append the value to it. I'm not sure what you're trying to do here. It looks like you're trying to create a hex string of the length of the value, and then append the value to it. I'm not sure what you're trying to do here. It looks like you're trying to create a hex string of the length of the value, and then append the value to it. I'm not sure what you're trying to do here. It looks like you're trying to create a hex string of the length of the value, and then append the value to it. I'm not sure what you're trying to do here. It looks like you're trying to create a hex string of the length of the value, and then append the value to it. I'm not sure what you're trying to do here. It looks like you're trying to create a hex string of the length of the value, and then append the value to it. I'm not sure what you're trying to do here. It looks like you're trying to create a hex string of the length of the",
+      "prediction": "I don't think this is necessary.",
       "reference": "I think your indentation is wrong here."
     },
     {
-      "prediction": "I'm not sure what you mean by \"useNodeResourceUpdates\"",
+      "prediction": "I don't think we need to use `set.Set` for `nodeToCIDRs` as it's just a map of string to set.",
       "reference": "UT spotted that we weren't marking routes dirty when they targeted at Node and that node's IP changed. e.g., the case where a WEP appears in the syncer before the corresponding node does, so we don't know the node's IP. I added a new map to track the CIDRs for each node so that when the node IP changes we can mark those CIDRs dirty. Right now it's only used for the \"WorkloadIPs\" scenario. Need to decide if the same issue applies in the \"CalicoIPAM' case. I suspect it might. It looks like we have some logic present to detect when our own node IP changes, but we don't seem to handle when a remote node's IP changes."
     },
     {
-      "prediction": "I think this should be `require_relative '../../vendored/require_vendored'` instead of `require_relative '../../vendored/require_vendored'`",
+      "prediction": "I'm not sure if this is the best place to put this, but I think it's a good idea to move it to the `vendored/require_vendored.rb` file so that it can be included in the `vendored/require_vendored.rb` file as well.",
       "reference": "Given this will 'pause' bolt for a few seconds on older rubies, perhaps emit a debug message saying \"Warming up OpenSSL\" or something to that effect"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `__init__` method of the `Package` class so that it can be used in the `__init__` method of other classes as well.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a `__init__` method to the `Package` class so that it can be used to create a new `Package` object.",
       "reference": "Initializing _format to None, but asserting that it's not None later, seems unnecessarily fragile. We shouldn't architect the package class to rely on classes or methods that use it (e.g., build). Let's at least set the format to the default in case we don't create all packages through build.py."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this method. Is it possible that you're trying to get a list of all elements that match the given `By`? If that's the case, you can use the `findElements` method to get a list of all elements that match the given `By` and then convert it to a list of `WebElement` objects.",
+      "prediction": "I'm not sure what you're trying to do with this method, but it looks like you're trying to get a list of all the elements that match the given `By` and return them as a list of `T` objects, where `T` is the type of the `WebElement` returned by the `findElements` method. Is this what you're trying to do?",
       "reference": "This change should also probably go into the corresponding method of the abstract By class?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to add this, but I think it should be in the `CodeIssue` class.",
+      "prediction": "Shouldn't this be `304` instead of `303`? `304` is the same as `301`, but `304` is the same as `301` and `301` is the same as `302` and `302` is the same as `301` and `301` is the same as `301` and `301` is the same as `301` and `301` is the same as `301` and `301` is the same as `301` and `301` is the same as `301` and `301` is the same as `301` and `301` is the same as `301` and `301` is the same as `301` and `301` is the same as `301` and `301` is the same as `301` and `301` is the same as `301` and `301` is the same as `301",
       "reference": "Should this be set to something else?"
     },
     {
@@ -25095,31 +25095,31 @@
       "reference": "Whats up with this? It looks like this is rendered on purchases/new for subscribers, so it would result in a dead end?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure",
+      "prediction": "I think this should be `if not new_id in Store.custom_options(backend=backend)`",
       "reference": "Glad to see this generalized to support the backend argument."
     },
     {
-      "prediction": "I think this should be `status.Error(codes.Unimplemented, \"not yet implemented\")` instead of `status.Error(codes.Unimplemented, \"not yet implemented\")`",
+      "prediction": "I think this should be moved to the `webapi` package.",
       "reference": "`ctx` is unused in ListDeploymentChains"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think we should be able to do this in the same place as `getMentionedAccounts` and `getMentionedDeployments`.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to move it to a separate file, so that it can be reused in other places.",
       "reference": "I'd say the format like `\"xxx: %w\"` is more convention when wrapping an error basically. You refered to anything like this?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"defaultDialTimeout is intentionally short so that connections timeout within the testTimeout defined above\". I think you meant to say that `learnerMaxStallTime` is intentionally short so that connections timeout within the testTimeout defined above.",
+      "prediction": "I think it's a good idea to make this a constant, so that we don't have to change it every time we add a new test.",
       "reference": "This seems relatively high, is it the recommended value from the etcd folks? Or is this debugging cruft?"
     },
     {
-      "prediction": "I think we should remove the `PeerTrackerAttestor` struct and just use `PeerTrackerAttestorAttestor` instead.",
+      "prediction": "I'm not sure if this is a good place to put this, but it seems like it could be used in the future, so I'm not sure if it's a good place to put it.",
       "reference": "This requires updating the name in the `endpoints` tests, please run `make test`."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `std::vector toHosts(const std::string& peersStr)`.",
+      "prediction": "I don't think this is a good idea. We should have a separate service for this.",
       "reference": "LOG(FATAL) means coredump, LOG(ERROR) is better here."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to change the context of the caller to the specified window. I'm not sure what you're trying to do here, but it looks like you're trying to change the context of the caller to the specified window. I'm not sure what you're trying to do here, but it looks like you're trying to change the context of the caller to the specified window. I'm not sure what you're trying to do here, but it looks like you're trying to change the context of the caller to the specified window. I'm not sure what you're trying to do here, but it looks like you're trying to change the context of the caller to the specified window. I'm not sure what you're trying to do here, but it looks like you're trying to change the context of the caller to the specified window. I'm not sure what you're trying to do here, but it looks like you're trying to change the context of the caller to the specified window. I'm not sure what you're trying to do here, but it looks like you're trying to change the context of the caller to the specified window. I'm not sure what you're trying",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would make sense to have a `switchToWindow` method in the `CommandProcessor` class, and then call it from the `execute` method.",
       "reference": "/javascript/firefox-driver is the Selenium implementation of a WebDriver for Firefox. Since it generally isn't W3C compatible, it shouldn't change. We can just drop this change."
     },
     {
@@ -25127,19 +25127,19 @@
       "reference": "It's a bit weird to have `svc.go` to include a `ScheduledJobType`...should we rename this file?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `package.json` as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `package.json` as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `package.json` as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `package.json` as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `package.json` as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `package.json` as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `package.json` as well. I'm not sure if this is the right place to do this, but I think it",
+      "prediction": "I don't think we need to change the default file permissions.",
       "reference": "For some reason `protoc` doesn't copy license header from `proto` files to generated code. But this code will never be checked in, so it is ok."
     },
     {
-      "prediction": "I think we should remove the `if (trList2.size() > 0 && trList2.get(0).pumpId == 0) { // don't update existing record if it has a pumpId }` line.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `getDaoTemporaryBasal()` method.",
       "reference": "I don't know what the implications of this change are for pumps other than the insight but i would add `|| trList2.get(0).pumpId == temporaryBasal.pumpId` in case we see the same pump event again, in order to not duplicate it in the database."
     },
     {
-      "prediction": "I'm not sure what you mean by \"checksumAddress\" is a representation of the short address with a checksum",
+      "prediction": "I think we can remove the `shortAddress` field, as it's not used anywhere.",
       "reference": "is there anything still referencing `checksumAddress` or can we just delete it?"
     },
     {
-      "prediction": "I think this should be `hivev1.InstallLaunchErrorCondition` instead of `hivev1.ProvisionFailedCondition`.",
+      "prediction": "I think it's better to use `hivev1.RequirementsMetCondition` instead of `hivev1.ProvisionFailedCondition`.",
       "reference": "The reason I didn't suggest it before is because I didn't want alerts for every tried - but not updated provision, but I can see a value in it from OSD perspective"
     },
     {
@@ -25147,7 +25147,7 @@
       "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to add a nil key to the list of keys that should be written. I'm not sure what you're trying to do here, but it looks like you're trying to add a nil key to the list of keys that should be written. I'm not sure what you're trying to do here, but it looks like you're trying to add a nil key to the list of keys that should be written. I'm not sure what you're trying to do here, but it looks like you're trying to add a nil key to the list of keys that should be written. I'm not sure what you're trying to do here, but it looks like you're trying to add a nil key to the list of keys that should be written. I'm not sure what you're trying to do here, but it looks like you're trying to add a nil key to the list of keys that should be written. I'm not sure what you're trying to do here, but it looks like you're trying to add a nil key to the list of keys that should be written. I'm not sure what you're trying to do here, but it looks like you're",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a `nilkeys` slice to the `beforeGets` slice, so that we can check for nil keys in the `beforeGets` slice.",
       "reference": "I believe Key is not necessarily nil, it could be empty string. Probably better check a.Kind == Create"
     },
     {
@@ -25155,71 +25155,71 @@
       "reference": "This is only used for headers and therefore isn't used."
     },
     {
-      "prediction": "I don't think this is needed anymore.",
+      "prediction": "I'm not sure if this is a good place to put it, but I think we should move it to the `ProviderCommand` struct.",
       "reference": "Wouldn't it make sense to add a files_import_command and a db_import_command, which could be empty? I guess that leads to potential backward-compatibility problems, but it's worth thinking about. Perhaps add an import-api version to solve that? Overall, I think the actual db import logic and files import logic should be moved into the yaml file. What you you think of that?"
     },
     {
-      "prediction": "I think we should remove the `BaseNode` field from the `FluxTestPackages` struct.",
+      "prediction": "I think this should be `Package: csv_test` instead of `Package: csv_test`",
       "reference": "Why do we have this here? I'm not concerned about it really, just curious."
     },
     {
-      "prediction": "I think we can remove `DeleteAction` and add `SetBytesAction` and `SetUintAction` instead.",
+      "prediction": "I don't think we need to change this. It's the same as before.",
       "reference": "@justicz Why are these switched here?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I'm not sure if this is the right way to do it.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `expect(response.status).to eq(200)` in this case.",
       "reference": "Maybe verify that an anchor was created -- that the markdown was processed?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. The `TwoPhaseIteratorAsDocIdSetIterator` constructor takes a `TwoPhaseIterator` as an argument, but the `TwoPhaseIteratorAsDocIdSetIterator` class doesn't have a `TwoPhaseIterator` constructor. Is this a bug or am I missing something?",
+      "prediction": "I think this should be `this.approximation = twoPhaseIterator.approximation;` instead of `this.approximation = twoPhaseIterator.approximation;`",
       "reference": "Is this just a minor improvement or is it necessary? If just some minor improvement, I recommend you don't touch Lucene in a Solr PR."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `close` method to the `ReadOnlyPDClient` interface.",
+      "prediction": "I think it's better to use `TiSession` instead of `TiClientSession` here.",
       "reference": "why delete this method?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to add this, but I think it would be a good idea to add this to the `SampleImportTransformer` class.",
+      "prediction": "I think we can remove the `importSectionTransformer` from this class. It's not needed anymore.",
       "reference": "Does this transform only the `MethodContext`, or also the `OutputContext`? (Looking at the other files, I gather it's the latter.) Might be helpful to mention that here."
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in `appModuleHandler.py` instead of `NVDAObjects.py`.",
+      "prediction": "I think this should be `StatusBarTimes` instead of `StatusBarTimesElapsed` and `StatusBarTimesTotal` instead of `StatusBarTimesElapsedTotal`.",
       "reference": "Could you please clean-up this line while at it?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `ServiceAccount` field in the `PubSubSpec` struct.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `ServiceAccount` field.",
       "reference": "no need to use a pointer. Just string and check for != \"\""
     },
     {
-      "prediction": "I think it's better to use `SSLOptionFactory.createSSLOptionFactory(SSL_KEY, null)` instead of `SSLOptionFactory.createSSLOptionFactory(null, SSL_KEY)`.",
+      "prediction": "I think this should be `SSLOptionFactory.createSSLOptionFactory(SSL_KEY, null)` instead of `SSLOptionFactory.createSSLOptionFactory(null, SSL_KEY)`.",
       "reference": "this means h2 mode? but how h2c can work?"
     },
     {
-      "prediction": "I don't think this is a good idea. It would be better to have a separate module for this.",
+      "prediction": "I don't think we need to change the name of the module.",
       "reference": "This line should not be there"
     },
     {
-      "prediction": "I'm not sure what you mean by \"underlying DB instance\"",
+      "prediction": "I don't think this is necessary.",
       "reference": "why do we need lock here? if needed, then we also need to lock in Start()?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to add a task to the dispatcher that will be called when the player receives a ping back from the server. This way, the player will be notified when they receive a ping back from the server, and the dispatcher will be notified when the player has received a ping back from the server. This way, the player will be notified when they receive a ping back from the server, and the dispatcher will be notified when the player has received a ping back from the server. This way, the player will be notified when they receive a ping back from the server, and the dispatcher will be notified when the player has received a ping back from the server. This way, the player will be notified when they receive a ping back from the server, and the dispatcher will be notified when the player has received a ping back from the server. This way, the player will be notified when they receive a ping back from the server, and the dispatcher will be notified when the player has received a ping back from the server. This way, the player will be notified when they receive a ping back from the server, and the dispatcher will be notified when the player has received a ping back",
+      "prediction": "I'm not sure if this is a good idea, but I don't think it's a good idea to call `addGameTask` from `Game::playerExecuteParsePacketEvent` because it will be called from `Game::playerExecuteParsePacketEvent` and `Game::playerReceivePingBack` will be called from `Game::playerExecuteParsePacketEvent` as well.",
       "reference": "this should be on default-switch, uhm? else you will handle twice (c++ and lua). I'm just saying..."
     },
     {
-      "prediction": "I think this should be `AddView` instead of `AddMetricStreamConfiguration`?",
+      "prediction": "I think this should be `AddView(instrumentName: \"*\", new MetricStreamConfiguration() { Aggregation = Aggregation.Drop })`",
       "reference": "unrelated minor fix"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to disable strict SSL by setting `npm config set strict-ssl false`. I'm not sure what you're trying to achieve with this, but it looks like you're trying to disable strict SSL by setting `npm config set strict-ssl false`. I'm not sure what you're trying to achieve with this, but it looks like you're trying to disable strict SSL by setting `npm config set strict-ssl false`. I'm not sure what you're trying to achieve with this, but it looks like you're trying to disable strict SSL by setting `npm config set strict-ssl false`. I'm not sure what you're trying to achieve with this, but it looks like you're trying to disable strict SSL by setting `npm config set strict-ssl false`. I'm not sure what you're trying to achieve with this, but it looks like you're trying to disable strict SSL by setting `npm config set strict-ssl false`. I'm not sure what you're trying to achieve with this, but it looks like you're trying to disable strict SSL by setting `npm config set strict-ssl false`. I'm not sure what you're trying to achieve with",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `setup` method.",
       "reference": "can you add `, echo: false` to the end of this as well. I don't think we need to echo this to the log. You might need to update the spec as well."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `replace` on a `Headers` object. It's not clear what you're trying to do here.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `replace` here. It's not clear what you're trying to do here, but I don't think it's a good idea to use `replace` here. It's not clear what you're trying to do here, but I don't think it's a good idea to use `replace` here. It's not clear what you're trying to do here, but I don't think it's a good idea to use `replace` here. It's not clear what you're trying to do here, but I don't think it's a good idea to use `replace` here. It's not clear what you're trying to do here, but I don't think it's a good idea to use `replace` here. It's not clear what you're trying to do here, but I don't think it's a good idea to use `replace` here. It's not clear what you're trying to do here, but I don't think it's a good idea to use `replace` here. It's not clear what you're trying to do here, but I don't think it's a good idea to use",
       "reference": "This test does not really verify that we're doing the correct thing now, is it? It seems to pass with and without the patch."
     },
     {
-      "prediction": "I think this should be `log.FinishWithErr` instead of `log.FinishWithErrWithErr`",
+      "prediction": "I think we can remove the `log.SetTag(ctx, \"block\", b)` line.",
       "reference": "should just be able to defer the call directly here too"
     },
     {
@@ -25227,35 +25227,35 @@
       "reference": "Is this a magic number? I assume this makes it look better."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `Send` method.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function to do this, so that we don't have to do this in the `Send` function.",
       "reference": "Would welcome a stringification method on big.Int in specs-actors"
     },
     {
-      "prediction": "I'm not sure what you mean by \"PersistBlockLevelInfo(blockHeight uint64)\". I think you meant to say \"PersistLevelInfo(blockHeight uint64)\" or \"PersistLevelInfo(uint64)\"?",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `action` package.",
       "reference": "PersistBlockLevelInfo -> UpdateBlockLevelInfo"
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear to me why we would want to do this. I think we could just use `retinanet_pvt_t_fpn_1x_coco.py` instead of `retinanet_pvt_t_fpn_1x_coco_1x.py`.",
+      "prediction": "I don't think this is a good idea. It's not clear to me why we would want to do this.",
       "reference": "Type is redundant since it is inherited."
     },
     {
-      "prediction": "I don't think this is needed anymore.",
+      "prediction": "I think we should remove the `isNotView()` method.",
       "reference": "better use `!isView()` so that we don't need to modify multiple lines in future."
     },
     {
-      "prediction": "I think this should be `attr_accessor` instead of `attr_writer`?",
+      "prediction": "I think this should be `attr_accessor :configuration, :world` instead of `attr_writer :configuration, :world`.",
       "reference": "I know you don't usually open up the singleton class, but I was getting a `private method called` error when trying to use `self.attr_writer` - any idea?"
     },
     {
-      "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place",
+      "prediction": "I think this should be `if (item.Type === 'Program' || item.Type === 'Timer' || item.Type === 'SeriesTimer' || item.Type === 'CollectionFolder' || item.Type === 'UserView' || item.Type === 'Channel' || item.Type === 'Season' || item.Type === 'Studio')`",
       "reference": "There's no need to create a new variable here, the other checks just use the item type directly."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think you want to use `where` here. I think you want to use `joins` here.",
+      "prediction": "I think this should be `where product_type: 'workshop'` instead of `where product_type: 'workshop'`",
       "reference": "Any other possible names? Feels like going with \"workshop\" for this product_type could increase the confusion between course/workshop in the codebase."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think we should move this to `fetchGetURLChannelsStore.actions.fetchGetURLChannels` instead of `fetchGetURLChannelsStore.actions.fetchGetURLChannels( accountID, clientID )`.",
+      "prediction": "I think it's better to use `yield fetchGetURLChannelsStore.actions.fetchGetURLChannels( accountID, clientID )` instead of `yield fetchGetURLChannelsStore.actions.fetchGetURLChannels( accountID, clientID );`",
       "reference": "@eugene-manuilov Isn't this already taken care of by `fetchGetURLChannels` via `createFetchStore`? Why is the extra `receiveError` call needed here? (This was already in the IB, but just struck me while reviewing here.)"
     },
     {
@@ -25263,11 +25263,11 @@
       "reference": "nit: should go before `grpc`?"
     },
     {
-      "prediction": "I don't think we need to use `make(chan struct{})` here. We can just use `context.WithCancel` directly.",
+      "prediction": "I'm not sure what you mean by `cancel := make(chan struct{})`. I think you meant `cancel := make(chan struct{}, 1)`.",
       "reference": "Why not using the Cancel? I thought cancelling a \"parent\" context would cascade to \"children\" contexts, cancelling them as well. In short, how does cancel work?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"pass multimedia types through\", but I think it's important to note that the MIME type of a file is not the same as the MIME type of the file itself. The MIME type of a file is the MIME type of the file's contents, not the MIME type of the file itself. For example, the MIME type of a PDF file is \"application/pdf\", but the MIME type of the PDF file itself is \"application/x-pdf\".",
+      "prediction": "I'm not sure I understand what you're trying to do here. What do you mean by \"reject anything containing javascript/xml/html\" and \"anything textual as text/plain\"?",
       "reference": "Could you explain why we default to binary now? It seems it's safer to default to text to avoid stuff getting executed or parsed by browsers accidentally. If we need to add support for particular types, we can add them explicitly right?"
     },
     {
@@ -25275,7 +25275,7 @@
       "reference": "Bit worried about the prefix since this seem to be being used for non-Openstack data too (host endpoints). Should we just leave host endpoint status at the old path (or remove it since AIFAIK, it's not used anywhere)?"
     },
     {
-      "prediction": "I think it's better to have a separate `Pattern` for `TIMECODE_LINK` and `TIMECODE_REGEX` instead of having two separate `Pattern` objects.",
+      "prediction": "I think it's better to use a regular expression for this.",
       "reference": "This might be a silly question, but what happens to files with durations > 24 hours?"
     },
     {
@@ -25287,35 +25287,35 @@
       "reference": "I think we also need to add `name:` to the bolt-project.yaml files in `spec/fixtures/projects`."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. What is the purpose of the `getUnmergedMDUpdates` function? Is it supposed to return a slice of the unmerged MDs for this TLF's current unmerged branch and unmerged branch, between the merge point for the branch and the current head? Or is it supposed to return a slice of the unmerged MDs for this TLF's current branch and unmerged branch, between the merge point for the branch and the current head?",
+      "prediction": "I'm not sure I understand what you're trying to do here. You're trying to get the unmerged MDs for the current branch and the merge point for the branch, but then you're trying to get the unmerged MDs for the current branch and the merge point for the branch, but then you're trying to get the unmerged MDs for the current branch and the merge point for the branch, but then you're trying to get the unmerged MDs for the current branch and the merge point for the branch, but then you're trying to get the unmerged MDs for the current branch and the merge point for the branch, but then you're trying to get the unmerged MDs for the current branch and the merge point for the branch, but then you're trying to get the unmerged MDs for the current branch and the merge point for the branch, but then you're trying to get the unmerged MDs for the current branch and the merge point for the branch, but then you're trying to get the unmerged MDs for the current branch and the merge point for the branch, but then you're trying to get the unmerged MDs for the current branch and the merge point for the branch, but then you're",
       "reference": "worth mentioning the same warning here as in `md_util.go`, I think."
     },
     {
-      "prediction": "I think this should be `if err != nil || nodeList.Items == nil || len(nodeList.Items) == 0` instead of `if err != nil && nodeList.Items == nil || len(nodeList.Items) == 0`.",
+      "prediction": "I think it's better to use `if err != nil || nodeList.Items == nil || len(nodeList.Items) == 0` instead of `if err != nil && nodeList.Items == nil || len(nodeList.Items) == 0`.",
       "reference": "Do we need both the checks, for `Items` not nil and `len(Items)`"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don",
+      "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new column to the `test_client_requests` table. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new column to the `test_client_requests` table. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new column to the `test_client_requests` table. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new column to the `test_client_requests` table. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new column to the `test_client_requests` table. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new column to the `test_client_requests` table. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new column to the `test_client_requests` table. I'm not sure what you're trying to achieve with this, but it looks like you",
       "reference": "Do you know what this is coming from? It keeps getting deleted/created @nickbristow"
     },
     {
-      "prediction": "I think we can remove `BASE_NAMESPACE` and `WAREHOUSE_LOCATION` from `ICEBERG_CATALOG_TYPE_HIVE` and `ICEBERG_CATALOG_TYPE_HADOOP`.",
+      "prediction": "I think we should remove `BASE_NAMESPACE` and `WAREHOUSE_LOCATION` from `ICEBERG_CATALOG_TYPE_HIVE` and `ICEBERG_CATALOG_TYPE_HADOOP`.",
       "reference": "Nit: leaving these in place would have reduce the number of files that this needed to touch, and avoided a possible problem removing public fields. I don't think it's worth blocking for this change, but we like to keep patches as small as possible by not breaking references like these."
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `persistEntity` instead of `prePersistEntity` for the following reasons:\r\n\r\n  1. `prePersistEntity` is deprecated since EasyAdmin 1.x and will be removed in 2.0 version. Use `persistEntity` instead.\r\n  2. `prePersistEntity` is only called when the entity is being created, while `persistEntity` is called when the entity is being updated or deleted.\r\n  3. `prePersistEntity` is only called when the entity is being created, while `persistEntity` is called when the entity is being updated or deleted.\r\n  4. `prePersistEntity` is only called when the entity is being created, while `persistEntity` is called when the entity is being updated or deleted.\r\n  5. `prePersistEntity` is only called when the entity is being created, while `persistEntity` is called when the entity is being updated or deleted.\r\n  6. `prePersistEntity` is only called when the entity is being created, while `persistEntity` is called when the entity is being updated or deleted.\r\n  7. `prePersistEntity`",
+      "prediction": "I don't think this is a good idea. I think we should use `persistEntity` instead of `prePersistEntity`.",
       "reference": "`The %s is deprecated...` -> `The %s method is deprecated...`"
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `blockchain` package.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to specs-actors.",
       "reference": "No, it wouldn't go there because that code won't reference or enforce it. Here is ok for now."
     },
     {
-      "prediction": "I think we should remove the `new Collection()` from the `TestRunCompleteEventArgs`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `TestRunCompleteEventArgs` class, so that we don't have to create a new `TestRunCompleteEventArgs` every time we want to log a test run complete event.",
       "reference": "How will we show that test run aborted (because of a crash) if we don't set aborted to true?"
     },
     {
-      "prediction": "I think this should be `private static readonly int MinAllocBufferSize = KestrelMemoryPool.MinimumSegmentSize / 2;` instead of `private static readonly int MinAllocBufferSize = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? KestrelMemoryPool.MinimumSegmentSize / 2 : 2048;`",
+      "prediction": "I think this should be `RuntimeInformation.IsOSPlatform(OSPlatform.Windows)` instead of `RuntimeInformation.IsOSPlatform(OSPlatform.Linux)`.",
       "reference": "Nit: Might as well make this same change to AdaptedPipeline."
     },
     {
@@ -25323,31 +25323,31 @@
       "reference": "Just to clarify: I see that only the hive2 withZone object inspector is changed. Does that mean that the predicate pushdown problem only occurred on hive2?"
     },
     {
-      "prediction": "Shouldn't `NAME_REGEX` be `NAME_REGEX = %r{\\A[a-z][a-z0-9_]*[-/](?[a-z][a-z0-9_]*)\\z}.freeze`?",
+      "prediction": "Shouldn't this be `NAME_REGEX` instead of `NAME_REGEXP`?",
       "reference": "Based on username requirements for forge.puppet.com - only letters and digits permitted."
     },
     {
-      "prediction": "I think this should be `if (this.struct.size() != that.struct.size())` instead of `if (len != that.struct.size())`.",
+      "prediction": "I think this should be `if (this.struct.size() != that.struct.size()) { return false; }`",
       "reference": "Was this removed to ignore the extra columns coming from the file projection?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
+      "prediction": "I'm not sure what you're trying to do with this change. I think we should just remove the `+build !windows` line.",
       "reference": "Please can you pull out the shared function into a shared file? I think that'd be pretty easy to do for this module. I think you could: - pull out a function `configureSyslog` that is implemented on Linux, but stubbed on Windows - pull out a function `openLogFile` that is implemented differently on each - share everything else"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but it seems like you're trying to create a new `AWSEmailProvider` and then use it to create a new `EmailNotificationService`. Is that what you're trying to do?",
+      "prediction": "I think we should use `AWSEmailProvider` instead of `AWSEmptyEmailProvider`.",
       "reference": "Instead of hardcoding the AWSEmailProvider here, it should come from properties, so that it can be replaced with another EmailProvider for ZMS vs ZTS"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `require_relative` here. It makes the code a bit more readable.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `login` and `password` variables in the `Account` model, rather than hard-coding them in the `login` and `password` variables in the `Account` model.",
       "reference": "+1 for creating this script to help people get boot strapped"
     },
     {
-      "prediction": "I think this should be `IS_NON_DIMENSIONAL: /acit|ex(?:s|g|n|p|$)|rph|ows|mnc|ntw|ine[ch]|zoo|^ord/i`",
+      "prediction": "I think it's better to use `isNonDimensional` instead of `IS_NON_DIMENSIONAL`.",
       "reference": "Do you need the prefix?"
     },
     {
-      "prediction": "I think this should be `retcode = deleteFromTextTable(&cliInterface, objUID, ComTextType::COM_OBJECT_COMMENT_TEXT, 0);` instead of `retcode = deleteFromTextTable(&cliInterface, objUID, ComTextType::COM_OBJECT_COMMENT_TEXT, 0);`",
+      "prediction": "I think this should be `deleteFromTextTable` instead of `deleteFromCommentTable`?",
       "reference": "if retcode is < 0, it should return -1 indicating an error."
     },
     {
@@ -25359,11 +25359,11 @@
       "reference": "Is this equivalent in JavaScript?"
     },
     {
-      "prediction": "I think it's better to use `NEBULA_SUCCESS` instead of `NEBULA_OK` in this case. `NEBULA_OK` is used to indicate that the operation was successful, while `NEBULA_SUCCESS` is used to indicate that the operation was successful and there were no errors.",
+      "prediction": "I don't think we need to do this.",
       "reference": "get/list operation is not schema change, it is supposed to use VLOG"
     },
     {
-      "prediction": "I think this should be `new ReadOnlySpan>(tags)` instead of `new ReadOnlySpan>(tags);`",
+      "prediction": "I'm not sure I understand what you're trying to do here. The `ReadOnlySpan>` is just a way to get a span of `KeyValuePair` from a span of `KeyValuePair`. It's not a span of `KeyValuePair`, it's a span of `KeyValuePair`.",
       "reference": "we'll need to delete this whole file, right?"
     },
     {
@@ -25371,75 +25371,75 @@
       "reference": "\"this table hasn't mutated within this transaction\" may sound like implying that if this transaction contains table mutation changes, `refresh` may have impact, which I think is not true? I guess what you were saying was if other transactions committed to this table successfully when this transaction is half way through, refresh in this transaction will still return the same state as when this transaction begins."
     },
     {
-      "prediction": "I think it's better to use `KeyUsage` instead of `KeyID` in this case. `KeyID` is used to identify a single key, while `KeyUsage` is used to identify a set of keys. `KeyID` is used to identify a single key, while `KeyUsage` is used to identify a set of keys. `KeyID` is used to identify a single key, while `KeyUsage` is used to identify a set of keys. `KeyID` is used to identify a single key, while `KeyUsage` is used to identify a set of keys. `KeyID` is used to identify a single key, while `KeyUsage` is used to identify a set of keys. `KeyID` is used to identify a single key, while `KeyUsage` is used to identify a set of keys. `KeyID` is used to identify a single key, while `KeyUsage` is used to identify a set of keys. `KeyID` is used to identify a single key, while `KeyUsage` is used to identify a set of keys. `KeyID` is used to identify a single key, while `KeyUsage` is used to identify a set of keys. `",
+      "prediction": "I'm not sure why we need this annotation key. It's not used anywhere in the spec.",
       "reference": "Can we move these into some kind of experimental API group? I don't think we want to call them `v1` just yet :)"
     },
     {
-      "prediction": "I'm not sure what you mean by \"Sort order: Number ASC\". Is that the same as \"Order: Number ASC\"? I'm not sure what you mean by \"Sort order: Number ASC\". Is that the same as \"Order: Number ASC\"? I'm not sure what you mean by \"Sort order: Number ASC\". Is that the same as \"Order: Number ASC\"? I'm not sure what you mean by \"Sort order: Number ASC\". Is that the same as \"Order: Number ASC\"? I'm not sure what you mean by \"Sort order: Number ASC\". Is that the same as \"Order: Number ASC\"? I'm not sure what you mean by \"Sort order: Number ASC\". Is that the same as \"Order: Number ASC\"? I'm not sure what you mean by \"Sort order: Number ASC\". Is that the same as \"Order: Number ASC\"? I'm not sure what you mean by \"Sort order: Number ASC\". Is that the same as \"Order: Number ASC\"? I'm not sure what you mean by \"Sort order: Number ASC\". Is that the same as \"Order: Number ASC\"? I'm not sure what you mean by \"Sort order: Number ASC\". Is that the same as \"Order",
+      "prediction": "I'm not sure what you're trying to do here, but I think it's better to just use `number: :asc` instead of `default_scope { order(number: :asc) }`.",
       "reference": "I think this makes a lot of sense but we may want to highlight the change for people doing UAT in case the ordering of sections is off anywhere when customizing or using the drag-drop feature"
     },
     {
-      "prediction": "I think this should be `document.head.appendChild(script)` instead of `document.head.appendChild(script.type = 'text/javascript')`",
+      "prediction": "I don't think this is necessary. We can just use `window.onload` instead.",
       "reference": "These files should in `/javascript/brython`"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.",
       "reference": "I'm not sure this is the right fix - I'd be more happy with a `continue`. That way, we don't enter the code at the bottom of the run loop (e.g. sending packets). Keep in mind that this error here may be triggered by a peer doing something security-relevant, so I don't think we should do much more work other than sending the close frame."
     },
     {
-      "prediction": "I'm not sure what you mean by \"for(auto&& w : m_weights) { w->load_from_save(latest, weight_list); }\". Is this the same as `m->reload_weights(active_ckpt_dir, weight_list);`?",
+      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to load the weights that appear in the `weight_list` from the `active_ckpt_dir`, but I'm not sure if that's what you're trying to do or not.",
       "reference": "Can we fix this, or is it going to stay broken."
     },
     {
-      "prediction": "I think we should remove the `@attr('postgres')` here.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `Postgres` class.",
       "reference": "Is there a reason to remove this attr?"
     },
     {
-      "prediction": "I think it's better to use `const` instead of `string` in this case. `string` is just an alias for `interface{}`.",
+      "prediction": "I think it's better to use `const` instead of `string` here.",
       "reference": "log message should be started with upper-case word."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with `bufSize` and `MinSize`, but I don't think it's a good idea to change the default buffer size to 512KiB.",
+      "prediction": "I don't think we need to change `MinSize` and `MaxSize` to `KiB` and `MiB` respectively. `KiB` and `MiB` are just different ways of expressing the same value.",
       "reference": "I guess this is not needed anymore now?"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason you want to use `h2o_iovec_t *name` and `h2o_iovec_t *value` instead of `h2o_iovec_t *name` and `h2o_iovec_t *value_len`?",
+      "prediction": "I think this should be `h2o_header_t *slot;` instead of `h2o_header_t *slot; h2o_header_t *slot;`",
       "reference": "I think I would prefer retaining the argument. It's true that we are not using it now, but it's harmless, it's good to have a constructor function that accepts all the field values as arguments. Performance-wise, it does not matter."
     },
     {
-      "prediction": "I think this should be `newBlock = Blockly.Xml.domToBlock(xmlBlock, this.startWorkspace_)` instead of `newBlock = Blockly.Xml.domToBlock(xmlBlock, this.startWorkspace_)`",
+      "prediction": "I think this should be `this.startWorkspace_` instead of `this.targetWorkspace_`.",
       "reference": "Is this a different fix?"
     },
     {
-      "prediction": "I don't think we need to use `SetNS` here. We can use `SetContext` instead.",
+      "prediction": "I don't think we need to use `SetNS(pid, bpm.MountNS)` here. We can just use `SetMountNS(pid, bpm.MountNS)`.",
       "reference": "Why not add a `EnterNS` filed instead of `WithoutNS`?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a test that uses the `kubeIPVSEnabled` variable, but it's not clear what you're trying to do with it.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `Config{}` here. It's not clear what you're trying to do here.",
       "reference": "Same points as in other test file."
     },
     {
-      "prediction": "I think this should be `if (validTaskIndex(taskIndex))` instead of `if (validTaskIndex(taskIndex)) && (validTaskIndex(taskIndex))`",
+      "prediction": "I think it's better to use `bitRead` and `bitWrite` instead of `bitSet` and `bitClear` in this case. `bitSet` and `bitClear` are used to set or clear a bit. `bitRead` and `bitWrite` are used to read or write a bit. `bitRead` and `bitSet` are used to read or write a bit. `bitRead` and `bitClear` are used to read or write a bit. `bitRead` and `bitSet` are used to read or write a bit. `bitRead` and `bitClear` are used to read or write a bit. `bitRead` and `bitSet` are used to read or write a bit. `bitRead` and `bitSet` are used to read or write a bit. `bitRead` and `bitSet` are used to read or write a bit. `bitRead` and `bitSet` are used to read or write a bit. `bitRead` and `bitSet` are used to read or write a bit. `bitRead` and `bitSet` are used to read or write a bit. `bitRead` and `bitSet`",
       "reference": "I have a PR pending, can you change this bit index to `16`?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the type is a class or interface. If it is a class or interface, then we need to create a `ResolvedReferenceType` for it. If it is not a class or interface, then we don't need to create a `ResolvedReferenceType` for it.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the type is a class or interface. If it is a class or interface, then we need to create a `ResolvedReferenceType` for it. If it is not a class or interface, then we don't need to create a `ResolvedReferenceType` for it, and we can just create a `ResolvedReferenceType` for the `classOrInterfaceType.toString()`.",
       "reference": "we should probably have some utility class for this sort of things"
     },
     {
-      "prediction": "I'm not sure what you mean by \"inconsistent returns\" here. It's not clear to me what you're trying to test here.",
+      "prediction": "I don't think this is a good idea. It's not a good idea to test inconsistent return values. It's not a good idea to test inconsistent return values. It's not a good idea to test inconsistent return values. It's not a good idea to test inconsistent return values. It's not a good idea to test inconsistent return values. It's not a good idea to test inconsistent return values. It's not a good idea to test inconsistent return values. It's not a good idea to test inconsistent return values. It's not a good idea to test inconsistent return values. It's not a good idea to test inconsistent return values. It's not a good idea to test inconsistent return values. It's not a good idea to test inconsistent return values. It's not a good idea to test inconsistent return values. It's not a good idea to test inconsistent return values. It's not a good idea to test inconsistent return values. It's not a good idea to test inconsistent return values. It's not a good idea to test inconsistent return values. It's not a good idea to test inconsistent return values. It's not a good idea to test inconsistent return values. It's not a good idea to test inconsistent return values. It's not a good idea",
       "reference": "Curious that I'm not seeing any occurrence of the new error check in this file. Why was it disabled?"
     },
     {
-      "prediction": "I think it's better to use the `exists` method to check if the Realm already exists on disk.",
+      "prediction": "I think it's better to use `exists` instead of `existsSync` because `existsSync` will throw an error if the file doesn't exist.",
       "reference": "does it return something?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"zeroData\" in this context. It's not clear to me what you're trying to do here.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `DataErrorComponent` as well.",
       "reference": "This function is also called in various Site Kit module components, where the error object (here `data`) also needs to be passed, otherwise the link to fix the issue won't appear."
     },
     {
-      "prediction": "I'm not sure what you mean by \"human-readable\" identifier. Is it something like \"123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a `DescribeIdentifier` method in the `Revision` interface, so that we don't have to call it every time we want to get the identifier of a revision.",
       "reference": "super nit: `revision string` (the passed value might not be a SHA hash)."
     },
     {
@@ -25447,39 +25447,39 @@
       "reference": "@snakefoot why is internal needed?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the same `ConnectionOptions` for both `PublicClient` and `LocalClient` so that we don't have to pass the same options over and over again.",
+      "prediction": "`DisableHealthCheck: true` should be `DisableHealthCheck: false`",
       "reference": "Why were we disabling health checks before?"
     },
     {
-      "prediction": "I think we should remove the `recursive=True` argument from `glob.glob()`.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `os.path.normpath` to make sure we don't accidentally include the root of the directory in the list of excluded files.",
       "reference": "did `conftest.py` actually show up for you? `test_files` should never contain it..."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea.",
+      "prediction": "I think this should be a warning, not an error.",
       "reference": "Should this be a ! on line 565? I would have expected the condition to be similar to line 564. If I am wrong please excuse my mistake."
     },
     {
-      "prediction": "I think this should be `if (oldVersion < 1070296) {` instead of `if (oldVersion < 1070296) { db.execSQL(\"ALTER TABLE \" + PodDBAdapter.TABLE_NAME_FEEDS + \" ADD COLUMN \" + PodDBAdapter.KEY_FEED_VOLUME_REDUCTION + \" INTEGER DEFAULT 0\"); }`",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be better to do this in the `onUpgrade` method of the `PodDBAdapter` class.",
       "reference": "Please change to `1070400`. I promise to look into this PR in more detail before the 1.7.4 release ;)"
     },
     {
-      "prediction": "I don't think we need to change the signature of `struct` to `struct(LogicalType fStruct, GroupType struct, List> fieldWriters)`.",
+      "prediction": "I don't think we need to change this.",
       "reference": "Can we change to use `LogicalType.getChildren`?"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this test, but I think it's a bit misleading. It's not clear what you're trying to test here. It's not clear what you're trying to test here. It's not clear what you're trying to test here. It's not clear what you're trying to test here. It's not clear what you're trying to test here. It's not clear what you're trying to test here. It's not clear what you're trying to test here. It's not clear what you're trying to test here. It's not clear what you're trying to test here. It's not clear what you're trying to test here. It's not clear what you're trying to test here. It's not clear what you're trying to test here. It's not clear what you're trying to test here. It's not clear what you're trying to test here. It's not clear what you're trying to test here. It's not clear what you're trying to test here. It's not clear what you're trying to test here. It's not clear what you're trying to test here. It's not clear what you're trying to test here. It's not clear what",
+      "prediction": "I'm not sure what you're trying to achieve with this test, but I think it's a bit misleading. It's not clear what you're trying to test here. If you want to test that the payment method is set on the purchase, you should test that the `payment_method` attribute is set on the `Purchase` object. If you want to test that the comments are set on the purchase, you should test that the `comments` attribute is set on the `Purchase` object.",
       "reference": "I'm confused as to how these are both passing."
     },
     {
-      "prediction": "I think it's better to use `link_to` instead of `content_tag` in this case.",
+      "prediction": "I think this should be `link_to` instead of `link_to`",
       "reference": "Prefer single-quoted strings when you don't need string interpolation or special symbols."
     },
     {
-      "prediction": "I don't think this is needed.",
+      "prediction": "I don't think we need to change this. The `seoH1s` property is just an array of strings, so we don't need to change it. The `descriptions` property is just an array of strings, so we don't need to change it either.",
       "reference": "there is `\"` sign in commit message and colon. can you rename also `descrition` to plural `descriptions` and add there `$` ?"
     },
     {
-      "prediction": "I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place",
+      "prediction": "I'm not sure if this is the best place to do this, but I think it's a good place to do this. I think it's a good place to do this. I think it's a good place to do this. I think it's a good place to do this. I think it's a good place to do this. I think it's a good place to do this. I think it's a good place to do this. I think it's a good place to do this. I think it's a good place to do this. I think it's a good place to do this. I think it's a good place to do this. I think it's a good place to do this. I think it's a good place to do this. I think it's a good place to do this. I think it's a good place to do this. I think it's a good place to do this. I think it's a good place to do this. I think it's a good place to do this. I think it's a good place to do this. I think it's a good place to do this. I think it's a good place to do this. I think it's a good place to do this",
       "reference": "timerNoUserLatency is not being used?"
     },
     {
@@ -25487,39 +25487,39 @@
       "reference": "@lmazuel - I've made a couple of minor changes to serialization.py, if you could do a quick review :) They should not be breaking, and I doubt are used by the existing clients so may not need a new release yet. Effectively it's a change to support default/constant date and datetime values by allowing strings to passed in instead of date or datetime objects. The strings would need to already be in the correct ISO formatting that the request will serialize to. Let me know if you think this is okay."
     },
     {
-      "prediction": ">\", true, true, structuralModificationType);\n             AssertEx.DeserializeNoError(\"\", true, true, structuralModificationType);\n             AssertEx.DeserializeNoError(\"\", true, true, structuralModificationType);\n             AssertEx.DeserializeNoError(\"\", true, true, structuralModificationType);\n```\nReview comment?",
+      "prediction": ">\", true, true, structuralModificationType);\n             AssertEx.DeserializeNoError(\"\", true, true, structuralModificationType);\n             AssertEx.DeserializeNoError(\"\", true, true, structuralModificationType);\n             AssertEx.DeserializeNoError(\"\", true, true, structuralModificationType);\n```\nReview comment?",
       "reference": "Why change the name in the XML?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to call `clear_other_organisation` in the `after_update` callback. I think you should call it in the `before_update` callback instead.",
+      "prediction": "I'm not sure what you mean by `if: :org_id_changed?, unless: :can_change_org?`",
       "reference": "This is much cleaner. makes it easier to tell what happens on a save."
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear to me why we would want to use `contains` instead of `not_in`.",
+      "prediction": "I don't think this is a good idea. It's not clear to me what the difference is between `datastore.OperatorNotEqual` and `datastore.OperatorNotIn`.",
       "reference": "Could you add return error unsupported operator here"
     },
     {
-      "prediction": "I think this should be `import javaslang.collection.Stream.Cons;` instead of `import javaslang.collection.Stream.Empty;`",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "(Mhh, we seem to use different formatters - we should unify them. I like the wildcards)"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to do this in a single line.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `namespace` field in the `DescribeTaskQueueRequest` so that we can use it in the `Namespace` field of the `TaskQueue` struct.",
       "reference": "Should `kind` be a command line parameter also?"
     },
     {
-      "prediction": "I think this should be `transaction.AccessList` instead of `transaction.AccessList is null ? null : AccessListItemForRpc.FromAccessList(transaction.AccessList);`",
+      "prediction": "I'm not sure what you mean by `transaction.AccessList is null ? null : AccessListItemForRpc.FromAccessList(transaction.AccessList);`. I think you meant to say `transaction.AccessList is null ? null : AccessListItemForRpc.FromAccessList(transaction.AccessList);`",
       "reference": "can we have it inside FromAccessList?"
     },
     {
-      "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good idea to have this in a separate file.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `rawRequestPaths` map.",
       "reference": "Why not embed filterASCII in this function?"
     },
     {
-      "prediction": "I think it's better to do this in the `selectExecutorAndDispatchFlow` method instead of in the `selectExecutorAndDispatchFlow` method. The `selectExecutorAndDispatchFlow` method is called from the `selectExecutorAndDispatchFlow` method, so it's more likely that the `selectExecutorAndDispatchFlow` method will be called before the `selectExecutorAndDispatchFlow` method. Also, the `selectExecutorAndDispatchFlow` method is called from the `selectExecutorAndDispatchFlow` method, so it's more likely that the `selectExecutorAndDispatchFlow` method will be called before the `selectExecutorAndDispatchFlow` method. Also, the `selectExecutorAndDispatchFlow` method is called from the `selectExecutorAndDispatchFlow` method, so it's more likely that the `selectExecutorAndDispatchFlow` method will be called before the `selectExecutorAndDispatchFlow` method. Also, the `selectExecutorAndDispatchFlow` method is called from the `selectExecutorAndDispatchFlow` method, so it's more likely that the `selectExecutorAndDispatchFlow` method will be called before the `selectExecutorAndDispatchFlow` method. Also, the `selectExecutorAndDispatchFlow` method is called from the",
+      "prediction": "I think it's better to do this in the `selectExecutorAndDispatchFlow` method instead of in the `selectExecutorAndDispatchFlow` and `selectExecutorAndDispatchFlow` methods.",
       "reference": "I am curious, shouldn't \"currentContinuousFlowProcessed++;\" be added right after line 1873? otherwise we will count 1 extra when a exflow wakes up from the sleep section,.even though it hasn't been assigned"
     },
     {
-      "prediction": "I don't think we need to use `isinstance` here. We can just use `issubclass` here.",
+      "prediction": "I don't think this is necessary. We can just use `configtypes.BaseType` for now.",
       "reference": "You can probably move this up after the `._Numeric` line."
     },
     {
@@ -25531,35 +25531,35 @@
       "reference": "Do we need indices for this table?"
     },
     {
-      "prediction": "I think this should be `process_data` instead of `fuzz_process_data`.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to have `process_data` return `FLB_HTTP_MORE`. If you want to return `FLB_HTTP_MORE`, then you should also return `FLB_HTTP_MORE` from `check_connection` and `fuzz_check_connection` as well.",
       "reference": "what about making this function static inline to avoid the extra declaration ?"
     },
     {
-      "prediction": "I don't think we need to change `LastTableID` to `TableIDType` here.",
+      "prediction": "I think this should be `uint64` instead of `uint32`?",
       "reference": "I forget the difference between type definition with \"=\" and without \"=\" again, but can we unify the style? I believe the difference doesn't apply to TableIDType and GroupIDType whatever it is?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not clear what you're trying to do here, but I don't think this is a good idea. It's not",
+      "prediction": "I'm not sure what you mean by \"will always be 1.0\". I think you meant to say \"will be 1.0\".",
       "reference": "would be `DEPRECATED Percentage of the graph (in vertices) to contract [0..1]` better?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `DriverCommand` interface.",
+      "prediction": "I think this should be `GET_CAST_ISSUE_MESSAGE` instead of `GET_CAST_SINK_ISSUE_MESSAGE`.",
       "reference": "These command names are specific to Chromium-based browsers. Please move to `ChromiumDriverCommand`"
     },
     {
-      "prediction": "I think this should be `foreach (var tag in resource.Attributes)` instead of `foreach (var label in resource.Attributes)`.",
+      "prediction": "I don't think we need to use `null` for `serviceName` and `tags` here. We can use `string.Empty` instead.",
       "reference": "if we won't use, should we remove this?"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to get rid of the `MvvmCross.Platforms.Android.Views` namespace from the `ViewNamespaceAbbreviations` dictionary. Is that what you're trying to do?",
+      "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bad idea. It's not clear what you're trying to achieve with this, but I think it's a bad idea. It's not clear what you're trying to achieve with this, but I think it's a bad idea. It's not clear what you're trying to achieve with this, but I think it's a bad idea. It's not clear what you're trying to achieve with this, but I think it's a bad idea. It's not clear what you're trying to achieve with this, but I think it's a bad idea. It's not clear what you're trying to achieve with this, but I think it's a bad idea. It's not clear what you're trying to achieve with this, but I think it's a bad idea. It's not clear what you're trying to achieve with this, but I think it's a bad idea. It's not clear what you're trying to achieve with this, but I think it's a bad idea. It's not clear what you're trying to achieve with this, but I think it's a bad idea. It's not clear what you're trying to achieve with this, but",
       "reference": "Having 2 items with the same key (Mvx) won't work in a dictionary"
     },
     {
-      "prediction": "Shouldn't this be `flash[:notice]` instead of `flash[:notice] = \"The coupon code you supplied is not valid.\"`?",
+      "prediction": "Shouldn't this be `flash[:notice] = \"The coupon code you supplied is not valid.\"` instead of `flash[:notice] = \"The coupon code you supplied is not valid.\"`?",
       "reference": "@cpytel how does the flow work right now? I expect to go to the sign up as customer page after putting in my code, but it goes to the longer landing page?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `snprintf` here.",
       "reference": "`event_msg` has the same size (1024) as a `message`. Maybe should be increased to 2048 instead? Then this `\"[error] %.512s\", message` could be changed to this: `\"[error] %.*s\", sizeof(message), message`"
     },
     {
@@ -25567,51 +25567,51 @@
       "reference": "Nit: unnecessary whitespace change."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `exec.Command` method to create a new `exec.Cmd` object, and then pass that to the `exec.Command` method. This way, we don't have to create a new `exec.Cmd` object every time we want to run a command.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `exec.Command` method to create a new `exec.Cmd` object, and then pass that to the `exec.Command` method. This way, we don't have to create a new `exec.Cmd` object every time we want to run a command, and we can reuse the same `exec.Cmd` object for multiple `exec.Command` calls.",
       "reference": "Hit a flake here where I think there may have been some output to stderr that got mixed in with the output from Stdout. Hence switching to `Output()`, which does also capture stderr as `err.Stderr`"
     },
     {
-      "prediction": "I think this should be `if (label >= 0 && label < m_num_labels)` instead of `if (label >= 0 && label < m_num_labels)`",
+      "prediction": "I think this should be `if (label >= 0 && label < m_num_labels)` instead of `if (label >= 0 && label < m_num_labels) { Y.Set(label, mb_idx, 1); }`",
       "reference": "I would use static_cast(0) and static_cast(m_num_labels) just in case."
     },
     {
-      "prediction": "I think this should be `lowerCasedDomain` instead of `lowerDomainInResource`",
+      "prediction": "I think this should be `lowerCasedDomain = resource.substring(0, delimiterIndex).toLowerCase() + resource.substring(delimiterIndex);`",
       "reference": "Even if we want to keep in original case - domain will be lower-cased."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to rename the column to `trail_map` instead of `body_html`. This is because `body_html` is a string, while `trail_map` is a hash.",
+      "prediction": "I'm not sure if this is the right way to do this, but I think it would be better to rename the column to `trail_map_html` instead of `trail_map`.",
       "reference": "Based on discussion with Chad it feels like trail_map_json could be a good column name."
     },
     {
-      "prediction": "I don't think this is a good idea. I think it's better to have a `superuser` field in the `User` model, so that we can check if the user is a superuser or not.",
+      "prediction": "I don't think we need to change the default value of `1` to `0` in this case.",
       "reference": "This array should be logic-less, just the language string (without `Lang::get()`) should appear. Then `trans()` is [or should be] used when the balloon selector renders the values."
     },
     {
-      "prediction": "I'm not sure what you mean by \"run puppet one more time to configure mcollective\". I think you meant to say \"run puppet one last time to configure mcollective\".",
+      "prediction": "I'm not sure what you mean by \"run puppet one more time to configure mcollective\". I think you meant to say \"run puppet one more time to configure mcollective\" or \"run puppet one more time to configure mcollective\" or \"run puppet one more time to configure mcollective\" or \"run puppet one more time to configure mcollective\" or \"run puppet one more time to configure mcollective\" or \"run puppet one more time to configure mcollective\" or \"run puppet one more time to configure mcollective\" or \"run puppet one more time to configure mcollective\" or \"run puppet one more time to configure mcollective\" or \"run puppet one more time to configure mcollective\" or \"run puppet one more time to configure mcollective\" or \"run puppet one more time to configure mcollective\" or \"run puppet one more time to configure mcollective\" or \"run puppet one more time to configure mcollective\" or \"run puppet one more time to configure mcollective\" or \"run puppet one more time to configure mcollective\" or \"run puppet one more time to configure mcollective\" or \"run puppet one more time to configure m",
       "reference": "This looks like it runs both pre 3.0 rake tasks and 3 rake tasks, and since pre 3.0 we didn't use bundler, my guess is it will fail then."
     },
     {
-      "prediction": "I'm not sure what you mean by \"atm we can't use the systemd device support because of two missing things\"",
+      "prediction": "I'm not sure what you mean by \"atm we can't use the systemd device support because of two missing things\". I think you're right, but I'm not sure what you mean by \"atm we can't use the systemd device support because of two missing things\". I think you're right, but I'm not sure what you mean by \"atm we can't use the systemd device support because of two missing things\". I think you're right, but I'm not sure what you mean by \"atm we can't use the systemd device support because of two missing things\". I think you're right, but I'm not sure what you mean by \"atm we can't use the systemd device support because of two missing things\". I think you're right, but I'm not sure what you mean by \"atm we can't use the systemd device support because of two missing things\". I think you're right, but I'm not sure what you mean by \"atm we can't use the systemd device support because of two missing things\". I think you're right, but I'm not sure what you mean by \"atm we can't use the systemd device support because of two missing things\". I think you're right, but",
       "reference": "I'm not sure the replacement is a good idea, and as I said in #336 , this \"parent-name.scope\" is not a good idea in the first place, specially when we support assigning a slice as the parent, so we should change this, WDYT?"
     },
     {
-      "prediction": "I think this should be `if err = kv.Commit(batchForBlock); err != nil { ... }` instead of `if err = kv.WriteBatch(batchForBlock); err != nil { ... }`",
+      "prediction": "I think this should be `if err = kv.Commit(batchForBlock); err != nil { ... }`",
       "reference": "sloppyReassign: re-assignment to `err` can be replaced with `err := kv.WriteBatch(batchForBlock)` (from `gocritic`)"
     },
     {
-      "prediction": "I think this should be `CompletableFuture future = new CompletableFuture<>();` instead of `CompletableFuture future = new CompletableFuture<>();`",
+      "prediction": "I think we can remove the `CompletableFuture future = new CompletableFuture<>();` and replace it with `CompletableFuture future = new CompletableFuture<>(); future.complete(null);`",
       "reference": "using factory method. return CompletableFuture.completedFuture"
     },
     {
-      "prediction": "I'm not sure if this is the right place for this, but I think it should be in the `AnalyticsDashboardWidgetTopPagesTable` component.",
+      "prediction": "I'm not sure if this is the right place to add the `footerCtaLabel` and `footerCtaLink` here.",
       "reference": "The `_x` function needs to be imported at the top of the file (in addition to `__`)"
     },
     {
-      "prediction": "I think it's better to use `*ofctrl.Flow` instead of `ofctrl.Flow` in this case.",
+      "prediction": "I don't think we need to add `ofctrl.Flow` here. It's already defined in the `ofctrl` package.",
       "reference": "this looks like the only controversial change potentially. @MatthewHinton56 Could let us know why you made this change (which `go vet` warning was triggered)? @wenyingd could you take a look and let us know if you're okay with this change?"
     },
     {
-      "prediction": "I don't think this is needed anymore.",
+      "prediction": "I don't think this is needed. The `AreaCVToolbar` is a `UserControl` and the `AreaCVToolbar` is a `GraphSummaryToolbar` which is a `UserControl`.",
       "reference": "This seems like left-over debugging code. I think I fixed this to no longer be necessary, switching to UserControl for the designer."
     },
     {
@@ -25619,35 +25619,35 @@
       "reference": "As we're currently not applying any logic in the proxy listener, I guess we can simply remove this file (and remove the `listener` argument from the `register_plugin(..)` call above)."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to add a timestamp to the `Proof` field, but I'm not sure what you're trying to do with the `Proof` field in the first place. Could you please clarify what you're trying to do with the `Proof` field?",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `types.Uint64(time.Now().Unix())` to generate a timestamp.",
       "reference": "Isn't the point of the clock module to encapsulate access to `time.Now()`? Coming later?"
     },
     {
-      "prediction": "I'm not sure what the point of this is, but I think it should be removed.",
+      "prediction": "I think it's better to use `time.Duration` for `time.Second` and `time.Duration` for `time.Minute` and `time.Hour` instead of `time.Duration` for `time.Second` and `time.Duration` for `time.Minute` and `time.Hour`.",
       "reference": "as before - if you've set this, you should be able to get rid of the `os.Setenv(\"ALGOSMALLLAMBDAMSEC\", \"500\")`. make sure that the various tests still takes have the same execution time."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if it's the best way to do this, but I think it's a good way to do it. I'm not sure if it's the best way to do this, but I think it's a good way to do it. I'm not sure if it's the best way to do this, but I think it's a good way to do it. I'm not sure if it's the best way to do this, but I think it's a good way to do it. I'm not sure if it's the best way to do this, but I think it's a good way to do it. I'm not sure if it's the best way to do this, but I think it's a good way to do it. I'm not sure if it's the best way to do this, but I think it's a good way to do it. I'm not sure if it's the best way to do this, but I think it's a good way to do it. I'm not sure if it's the best way to do this, but I think it's a good way",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way",
       "reference": "Pretty sure the single quotes here should be double quotes, single quotes are not expanded by the shell."
     },
     {
-      "prediction": "I'm not sure what you mean by `compileTimeConstant` here. It's not a compile-time constant, it's a runtime constant. I think you meant to say `compileTimeConstant` here.",
+      "prediction": "I don't think this is a good idea. It would be better to have a separate test for `compileTimeConstant` and `localConstant` in the `ValidateConstantMessageTests` class.",
       "reference": "these are not really constants, right?"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's better to use `six.moves` instead of `six` in this case. `six.moves` is more up-to-date than `six`.",
+      "prediction": "I don't think this is necessary.",
       "reference": "import below copyright statement"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to send a receipt email to the user who received the invoice, but I'm not sure what you're trying to do here. I think you're trying to send a receipt email to the user who received the invoice, but I'm not sure what you're trying to do here. I think you're trying to send a receipt email to the user who received the invoice, but I'm not sure what you're trying to do here. I think you're trying to send a receipt email to the user who received the invoice, but I'm not sure what you're trying to do here. I think you're trying to send a receipt email to the user who received the invoice, but I'm not sure what you're trying to do here. I think you're trying to send a receipt email to the user who received the invoice, but I'm not sure what you're trying to do here. I think you're trying to send a receipt email to the user who received the invoice, but I'm not sure what you're trying to do here. I think you're trying to send a receipt email to the user who received the invoice, but I'm not sure what you're trying",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to make sure that the email is sent to the right people.",
       "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `getTwigValue()` method to the `Field` class. This would allow us to get the value of the field in a way that is compatible with the Twig templating engine.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "`if (is_string($value) && $this->getDefinition()->get('allow_html')) {`"
     },
     {
-      "prediction": "I think this should be `Debug.Assert(key != null, $\"{nameof(key)} must not be null\")` instead of `Debug.Assert(key != null, $\"{nameof(key)} must not be null\")`",
+      "prediction": "I think this should be `Debug.Assert(key != null, $\"{nameof(key)} must not be null\")`",
       "reference": "I think we have the same problem here - if folks called the `public void Add` with a `null` key, we need to use `Guard`."
     },
     {
@@ -25655,7 +25655,7 @@
       "reference": "I thought that the main was in catch_qt.cpp?"
     },
     {
-      "prediction": "I don't think you need to add `binding` to the `ActivityFullScreenImageBinding` class.",
+      "prediction": "I don't think we need to change the `TYPE_IMAGE` list here. It's already defined in the `ActivityFullScreenImageBinding` class.",
       "reference": "I would rename the field to IMAGE_TYPES and make it an array. I don't think we need list operations. Also, if possible, I would move the field to the ApiFields class. What do you think?"
     },
     {
@@ -25663,23 +25663,23 @@
       "reference": "I'd prefer to timeout on this, but I know it's not a pattern that is being followed"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to read the vector values from a simple text format. I'm not sure what you're trying to do here, but it looks like you're trying to read the vector values from a simple text format. I'm not sure what you're trying to do here, but it looks like you're trying to read the vector values from a simple text format. I'm not sure what you're trying to do here, but it looks like you're trying to read the vector values from a simple text format. I'm not sure what you're trying to do here, but it looks like you're trying to read the vector values from a simple text format. I'm not sure what you're trying to do here, but it looks like you're trying to read the vector values from a simple text format. I'm not sure what you're trying to do here, but it looks like you're trying to read the vector values from a simple text format. I'm not sure what you're trying to do here, but it looks like you're trying to read the vector values from a simple text format. I'm not sure what you're trying to do here, but it looks like",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate class for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate class for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate class for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate class for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate class for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate class for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate class for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have",
       "reference": "hmm let's not use * imports please"
     },
     {
-      "prediction": "I'm not sure if this is the right place to put it, but I think we should put it in the `k8sAlertmanager` section of the `alertmanager.yaml` file.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think we should put it in the `alertmanager.yaml` file.",
       "reference": "is this configuration key already exist in prometheus ?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I'm not sure if this is a good idea.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to change the default language for diary entries.",
       "reference": "As @gravitystorm said new tests need to be using factories, not fixtures."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to escape the backslash, but I don't think that's what you're trying to do here.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `std::string` instead of `std::string_view` here. `std::string_view` is not thread-safe, and `std::string` is not thread-safe either. `std::string_view` is thread-safe, but `std::string` is not. `std::string_view` is not thread-safe, and `std::string` is not thread-safe either. `std::string_view` is not thread-safe, and `std::string` is not thread-safe either. `std::string_view` is not thread-safe, and `std::string` is not thread-safe either. `std::string_view` is not thread-safe, and `std::string` is not thread-safe either. `std::string_view` is not thread-safe, and `std::string` is not thread-safe either. `std::string_view` is not thread-safe, and `std::string` is not thread-safe either. `std::string_view` is not thread-safe, and `std::string` is not thread-safe either. `std::string_view` is not thread-safe, and `std",
       "reference": "You can replace IP by hostname."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this. It's not clear to me if this is the right place to do this, but I think it would be good to have a separate function for this. It's not clear to me if this is the right place to do this, but I think it would be good to have a separate function for this. It's not clear to me if this is the right place to do this, but I think it would be good to have a separate function for this. It's not clear to me if this is the right place to do this, but I think it would be good to have a separate function for this. It's not clear to me if this is the right place to do this, but I think it would be good to have a separate function for this. It's not clear to me if this is the right place to do this, but I think it would be good to have a separate function for this. It's not clear to me if this is the right place to do this, but I think it would be good to have a separate function for this. It's not clear to me if this is the",
+      "prediction": "I'm not sure if this is the best way to do this, but it seems to work.",
       "reference": "This should say \"why\" NVDA should do things in this order."
     },
     {
@@ -25687,23 +25687,23 @@
       "reference": "nit these will get changed back during next release."
     },
     {
-      "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to add a comment here explaining what this is for.",
+      "prediction": "I'm not sure if this is a good place to put it, but I think we should move it to the `api` package as well.",
       "reference": "it is actually not needed to make the member public. the build tags can also set a package scoped variable."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to get the `icon` from the `ContentExtension` object, but you're not using it anywhere in your code.",
+      "prediction": "I'm not sure what you're trying to do here. I think you're trying to get the icon from the content extension, but I don't think that's what you're trying to do here. I think you're trying to get the icon from the content extension, but I don't think that's what you're trying to do here. I think you're trying to get the icon from the content extension, but I don't think that's what you're trying to do here. I think you're trying to get the icon from the content extension, but I don't think that's what you're trying to do here. I think you're trying to get the icon from the content extension, but I don't think that's what you're trying to do here. I think you're trying to get the icon from the content extension, but I don't think that's what you're trying to do here. I think you're trying to get the icon from the content extension, but I don't think that's what you're trying to do here. I think you're trying to get the icon from the content extension, but I don't think that's what you're trying to do here. I think you're trying to get the icon from the content",
       "reference": "We already have a method for it 'icon' => $content->getIcon()"
     },
     {
-      "prediction": "I don't think we need to use `s3iface` here. We can just use `s3` directly.",
+      "prediction": "I don't think we need to use `context.Context` here. We can just use `context.Background()` instead.",
       "reference": "Instead of importing `golang.org/x/net/context` The SDK should use `aws.BackgroundContext()` instead of `context.Background()`"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a `Media` class that extends `Sonata\\MediaBundle\\Model\\MediaInterface` instead of having a `Media` class that extends `Sonata\\MediaBundle\\Model\\MediaInterface` and `Sonata\\MediaBundle\\Model\\MediaInterface` extends `Sonata\\MediaBundle\\Model\\MediaInterface` and `Sonata\\MediaBundle\\Model\\MediaInterface` extends `Sonata\\MediaBundle\\Model\\MediaInterface` and `Sonata\\MediaBundle\\Model\\MediaInterface` extends `Sonata\\MediaBundle\\Model\\MediaInterface` and `Sonata\\MediaBundle\\Model\\MediaInterface` extends `Sonata\\MediaBundle\\Model\\MediaInterface` and `Sonata\\MediaBundle\\Model\\MediaInterface` extends `Sonata\\MediaBundle\\Model\\MediaInterface` and `Sonata\\MediaBundle\\Model\\MediaInterface` extends `Sonata\\MediaBundle\\Model\\MediaInterface` and `Sonata\\MediaBundle\\Model\\MediaInterface` extends `Sonata\\MediaBundle\\Model\\MediaInterface` and `Sonata\\MediaBundle\\Model\\MediaInterface` extends `Sonata\\MediaBundle\\Model\\MediaInterface` and `Sonata\\",
+      "prediction": "I don't think this is a good idea. It would be better to create a new controller for this action and have it return a `Sonata\\MediaBundle\\Entity\\MediaInterface` instead of a `Sonata\\MediaBundle\\Entity\\Media`.",
       "reference": "I think this is an agnostic change for the ORM right? Why was it doing this? - this does not work on PHPCR-ODM as the `id` is not a field - although I guess it could be mapped as such."
     },
     {
-      "prediction": "I don't think this is necessary. The `included_in_current_users_plan?` method is already defined in the `Topic` model, so we don't need to define it again in the `ApplicationController`.",
+      "prediction": "I don't think this is necessary. The `included_in_current_users_plan?` method is already defined in the `Topic` model.",
       "reference": "I'm not 100% sure, but I think this should be `explorable`. If not, I think `explorable` can be removed entirely."
     },
     {
@@ -25711,7 +25711,7 @@
       "reference": "Note to self: Why was this not originally not using `stderrbytes`?"
     },
     {
-      "prediction": "I don't think this is necessary. We can just use `std::filesystem::directory_iterator` and `std::filesystem::is_directory` to check if the directory exists.",
+      "prediction": "I don't think this is necessary. The `rename` function is used to rename a file, not a directory. If you want to rename a directory, you need to use the `rename` function with the `-r` option.",
       "reference": "Is betterLOG_IF(ERROR, status != 0) ?"
     },
     {
@@ -25719,19 +25719,19 @@
       "reference": "I wouldn't call it default too."
     },
     {
-      "prediction": "I think this should be `import { browser } from 'browser';` instead of `import browser from 'browser';`",
+      "prediction": "I think it's better to use `import { browser } from 'browser';` instead of `import browser from 'browser';`",
       "reference": "Why disable the rule for this file?"
     },
     {
-      "prediction": "I'm not sure what you mean by `onClick: PropTypes.func`. It's not a function, it's a prop.",
+      "prediction": "I don't think we need to add `external` to the `onClick` prop.",
       "reference": "Thanks for adding this :+1:. Could you please move it to go after the `ctaLink` prop?"
     },
     {
-      "prediction": "I think this should be `Current` instead of `Current!`",
+      "prediction": "I think this should be `Current` instead of `Current!`?",
       "reference": "The other way around Current can be null."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate `mail_templates` menu item for each type of email template.",
+      "prediction": "I don't think we need to add the `edit_template` link to the `mail_templates` menu.",
       "reference": "why does it have to be here? Due to breadcrumb navigation?"
     },
     {
@@ -25739,7 +25739,7 @@
       "reference": "I fear moving this to some common func. We are swallowing the error here. This might be ok in UT but not in actual source code."
     },
     {
-      "prediction": "I'm not sure what you mean by \"conflicting message symbol\". I think you meant to say \"duplicate-keyword-arg\".",
+      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to add a message with a duplicate keyword argument, but it's already defined. I think you want to add a message with a duplicate keyword argument, but it's not defined. I think you want to add a message with a duplicate keyword argument, but it's not defined. I think you want to add a message with a duplicate keyword argument, but it's not defined. I think you want to add a message with a duplicate keyword argument, but it's not defined. I think you want to add a message with a duplicate keyword argument, but it's not defined. I think you want to add a message with a duplicate keyword argument, but it's not defined. I think you want to add a message with a duplicate keyword argument, but it's not defined. I think you want to add a message with a duplicate keyword argument, but it's not defined. I think you want to add a message with a duplicate keyword argument, but it's not defined. I think you want to add a message with a duplicate keyword argument, but it's not defined. I think you want to add a message with a duplicate keyword argument, but it's not defined. I",
       "reference": "Please don't use \\ as a line continuation. Do an implicit string join instead with parens: ``` (\"Message ...\" \"and ...\")"
     },
     {
@@ -25751,7 +25751,7 @@
       "reference": "I think if we can provide a more convenient method to add configs . e.g. public static void addConfig(String k, Object v)"
     },
     {
-      "prediction": "I think we can remove the `action.GasLimit+100` from the test.",
+      "prediction": "I think it's better to use `action.GasLimit+100` instead of `action.GasLimit+100, big.NewInt(10), []byte{}`.",
       "reference": "line is 165 characters"
     },
     {
@@ -25759,19 +25759,19 @@
       "reference": "Please add a copyright notice. Also, could you tell me please why do we need this empty provider here?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check for `privacyController.isGroupAdditionTransaction(privateTransaction)`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check here to make sure we don't try to add a privacy group to an enclave that doesn't have one.",
       "reference": "I feel like this would be easier to read if we join the two if's together: `if (maybePrivacyGroup.isEmpty() && !privacyController.isGroupAdditionTransaction(privateTransaction))`"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `onUpgrade` method of the `SQLiteOpenHelper` class. This way, we don't have to call `loadSoupBlobAsString` every time we upgrade the database.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to make sure the soup blob is not null before trying to load it.",
       "reference": "Tests are failing because the exception type is NullPointException here if the soupBlob is deleted (so instead of a mal-format json, it's a null)"
     },
     {
-      "prediction": "I'm not sure what you're trying to say here. I think you're trying to say that you can't drag an input to an output, but you can drag an output to an input. Is that what you're trying to say? If that's the case, I'm not sure what you're trying to say here. I think you're trying to say that you can't drag an input to an output, but you can drag an output to an input. Is that what you're trying to say? If that's the case, I'm not sure what you're trying to say here. I think you're trying to say that you can't drag an input to an output, but you can drag an output to an input. Is that what you're trying to say? If that's the case, I'm not sure what you're trying to say here. I think you're trying to say that you can't drag an input to an output, but you can drag an output to an input. Is that what you're trying to say? If that's the case, I'm not sure what you're trying to say here. I think you're trying to say that you can't drag an input to an output, but you can drag an output",
+      "prediction": "I'm not sure what you mean by \"already connected\" in this context. I think you meant to say \"already connected to an output\" or \"already connected to an input\".",
       "reference": "Glad we fixed this as well. Blockly is going to be left as-is for this case, right?"
     },
     {
-      "prediction": "I think this should be `@Deprecated` instead of `@Deprecated(deprecatedIn = \"Mobile SDK 7.0\")`.",
+      "prediction": "I think this should be `@deprecated` instead of `@Deprecated`.",
       "reference": "I had accidentally deprecated this class. This is meant to stick around. Only `SalesforceObjectType` goes away."
     },
     {
@@ -25779,31 +25779,31 @@
       "reference": "`hex(i)[2:]` is trying to do the same thing above. what is `i` in your malformed case?"
     },
     {
-      "prediction": "I think it's better to use `val` instead of `String val` in the `writeXML` method.",
+      "prediction": "Shouldn't this be `shouldEscape` instead of `shouldEscapeIsTrue`?",
       "reference": "I think this change is redundant; see the previously defined method \"writeUnescapedXML\"."
     },
     {
-      "prediction": "I think we can remove the `CommitmentLength` field from the `types.Commitments` struct.",
+      "prediction": "I think this should be `CommitmentLength` instead of `CommitmentLengthBytes`?",
       "reference": "Ah now I have at least some idea what these are for."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. You're setting the schema, but you're not actually using it.",
+      "prediction": "I think this should be `public void setSchema(Schema fileSchema)` instead of `public void setSchema(Schema schema)`?",
       "reference": "I believe in previous PRs @mccheah frequently used `fileSchema` -> `newFileSchema` type of renames to avoid hiding fields in builders. Would it make sense to make it consistent?"
     },
     {
-      "prediction": "I think we can remove the `cancelable` here, since it's only used in the `startConnection` function. We don't need to cancel the connection in the `Connect` function.",
+      "prediction": "I think we can remove the `cancelable` here, as it's not used anywhere else in the code.",
       "reference": "Do we really need separate error in manager if utils.ErrRequestCancelled is the only error which indicates cancelation ?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to set the `temporalImp` to `tm_cpp`, but then you're trying to use `spNumActivePerInhArea` instead of `spNumActivePerInhArea`. I think you want to use `spNumActivePerInhArea` instead of `spNumActivePerInhArea` here.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `temporalImp` parameter in the `ModelParams` class. This way, we can have a `temporalImp` parameter in the `ModelParams` class, and we can have a `temporalImp` parameter in the `ModelParams` class, and we can have a `temporalImp` parameter in the `ModelParams` class, and we can have a `temporalImp` parameter in the `ModelParams` class, and we can have a `temporalImp` parameter in the `ModelParams` class, and we can have a `temporalImp` parameter in the `ModelParams` class, and we can have a `temporalImp` parameter in the `ModelParams` class, and we can have a `temporalImp` parameter in the `ModelParams` class, and we can have a `temporalImp` parameter in the `ModelParams` class, and we can have a `temporalImp` parameter in the `ModelParams` class, and we can have a `temporalImp` parameter in the `ModelParams` class, and we can have a `",
       "reference": "Leave as `cpp` since that still gives better results."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `logger.WithValues` function to pass in the values that we want to pass in to the predicate.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `logger.WithValues` function to pass in the values for the `predicate` and `objectNew` and `metaNew` to the `predicate.Funcs` function. This way, we don't have to pass in the `predicate` and `objectNew` to the `predicate.Funcs` function, and we don't have to pass in the `predicate` and `metaNew` to the `predicate.Funcs` function. This way, we can use the `logger.WithValues` function to pass in the values for the `predicate` and `objectNew` and `metaNew` to the `predicate.Funcs` function. This way, we can use the `logger.WithValues` function to pass in the values for the `predicate` and `objectNew` and `metaNew` to the `predicate.Funcs` function. This way, we can use the `logger.WithValues` function to pass in the values for the `predicate` and `objectNew` and `metaNew` to the `predicate.Funcs` function. This way, we can use the `logger.WithValues` function to pass in",
       "reference": "temp change so the predicate can be used by the `exp` package"
     },
     {
-      "prediction": "I think this should be `if self.vkCode in self.TOGGLE_KEYS:` instead of `if self.vkCode in self.TOGGLE_KEYS:`",
+      "prediction": "I think this should be `self.vkCode in self.TOGGLE_KEYS` instead of `self.vkCode in self.TOGGLE_KEYS`",
       "reference": "Just as a tiny clarification, this isn't affected in any way by \"speak typed characters\". That is, \"caps lock on\", etc. is always spoken, even if speak typed characters is off."
     },
     {
@@ -25811,19 +25811,19 @@
       "reference": "@dgoodwin Will it cause an issue when the issue get fixed in OLM?"
     },
     {
-      "prediction": "I think we should remove `ForceProcessing` and `DoNotVerifyNonce` as they are not needed anymore.",
+      "prediction": "I think this should be 256 instead of 511.",
       "reference": "This option is now unnecessary"
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. I'm not sure if you're trying to create a new bucket, or if you're trying to delete an existing bucket. If you're trying to create a new bucket, you should be using the `NewBucket` function. If you're trying to delete an existing bucket, you should be using the `DeleteBucket` function. If you're not sure what you're trying to do, it's probably best to ask for clarification.",
+      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. I'm not sure if you're trying to create a new bucket, or if you're trying to delete an existing bucket. If you're trying to create a new bucket, then you should be using the `NewBucket` function, not the `NewBucketSubdir` function. If you're trying to delete an existing bucket, then you should be using the `DeleteBucket` function, not the `DeleteBucketSubdir` function.",
       "reference": "Don't jump down to the unexported interface: just set the content type to `\"application/octet-stream\"` explicitly when creating the `Writer`."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `Accountable` class, since it's not part of the `BufferedUpdates` class.",
       "reference": "Instead of counting this here on clear, can we use a second counter for the deleteTerms next to `bytesUsed`? This would be great. It doesn't need to be thread safe IMO"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I think it's a bit confusing. I'm not sure what you're trying to do here, but I think it's a bit confusing. I'm not sure what you're trying to do here, but I think it's a bit confusing. I'm not sure what you're trying to do here, but I think it's a bit confusing. I'm not sure what you're trying to do here, but I think it's a bit confusing. I'm not sure what you're trying to do here, but I think it's a bit confusing. I'm not sure what you're trying to do here, but I think it's a bit confusing. I'm not sure what you're trying to do here, but I think it's a bit confusing. I'm not sure what you're trying to do here, but I think it's a bit confusing. I'm not sure what you're trying to do here, but I think it's a bit confusing. I'm not sure what you're trying to do here, but I think it's a bit confusing. I'm not sure what you're trying to do here, but I think it's a bit confusing. I'm not sure",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to have a `password_confirmation` field in the `backend_users` table. The `password_confirmation` field should only be used to validate the `password` field, not to validate the `password_confirmation` field. If you want to validate the `password_confirmation` field, you should add it to the `backend_users` table, and then add a `password_confirmation` field to the `backend_users` table.",
       "reference": "@daftspunk @bennothommo I wonder if we need to go as deep as detecting what the default varchar length is with a special character to be parsed by the validation trait since we've introduced the config for it."
     },
     {
@@ -25831,27 +25831,27 @@
       "reference": "Also update line 2205 below"
     },
     {
-      "prediction": "I don't think this is a good idea.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "Typo, should read `firstTimeEmptySubject`"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason you want to do this, or is this just a placeholder for something else?",
+      "prediction": "I'm not sure I understand what you're trying to do here. What is the purpose of the `Handler` interface? What is the purpose of the `ResponseWriter` interface? What is the purpose of the `context.Context`? What is the purpose of the `context.Context`? What is the purpose of the `context.Context`? What is the purpose of the `context.Context`? What is the purpose of the `context.Context`? What is the purpose of the `context.Context`? What is the purpose of the `context.Context`? What is the purpose of the `context.Context`? What is the purpose of the `context.Context`? What is the purpose of the `context.Context`? What is the purpose of the `context.Context`? What is the purpose of the `context.Context`? What is the purpose of the `context.Context`? What is the purpose of the `context.Context`? What is the purpose of the `context.Context`? What is the purpose of the `context.Context`? What is the purpose of the `context.Context`? What is the purpose of the `context.Context`? What is the purpose of the `context.Context`? What is the purpose of the `context.Context`",
       "reference": "The more I see this the more I think the transport layer _should_ actually refer to this as `UnaryHandler`."
     },
     {
-      "prediction": "I'm not sure what you mean by \"forcing the connection to close\". It's not clear to me what you're trying to do here.",
+      "prediction": "I'm not sure what you're trying to do here, but I'm not sure if this is the right place to do it.",
       "reference": "The `warn` message here seems to indicate that the forced closure of the SSH connection should raise an error; is that getting swallowed up somewhere and not raising?"
     },
     {
-      "prediction": "I think this should be `self._lineedit = LineEdit(self)` instead of `self._lineedit = LineEdit(self._init_texts(question))`",
+      "prediction": "I think it's better to have `self._expands_user = True` instead of `self._expands_user = False`",
       "reference": "I wonder if this is a fitting name. Why \"expands user\"? Wouldn't be `user_expanded` or so be more fitting?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `get isFocusable` method in the `virtualDOMfromNode` function. This way, we don't have to call `axe.utils.isHidden` every time we want to check if a node is focusable.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `virtualDOMfromNode` as well.",
       "reference": "I see what you are doing here, but to stay with the `getter/setter` pattern, should we introduce `set isHidden(value)` & `get isHidden()` which them maintains `_isHidden` with in `vNodeCache`. This will avoid what looks like accessing an internal property like `_isHidden` from `axe.utils.isHidden` & keeps things neat."
     },
     {
-      "prediction": "I think it's better to use `CSharpAliasMode.MessagesOnly` instead of `CSharpAliasMode.SamplesOnly` in this case.",
+      "prediction": "I think it's better to use `CSharpAliasMode.SamplesOnly` instead of `CSharpAliasMode.MessagesOnly`.",
       "reference": "nit: for consistency, have this line and the previous formatted similarly"
     },
     {
@@ -25859,7 +25859,7 @@
       "reference": "As before, shouldn't mention these as being orion options I don't think. Perhaps just enclaveKeyStoreFile etc."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to log the response to the console so we can see what's going on.",
       "reference": "What's the thinking here? Only logging when the test has not ended yet?"
     },
     {
@@ -25867,15 +25867,15 @@
       "reference": "@HyukjinKwon @ueshin (cc @itholic @charlesdong1991 ) Not sure if this is the right implementation ..."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `url.protocol` in the `parse` function.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check for `url.protocol` here.",
       "reference": "Do we want to add any specific error on how the url is malformed?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `appendLogsInternal` function.",
+      "prediction": "I don't think this is necessary.",
       "reference": "why NOT self->lastLogIdSent_ = self->logIdToSend_"
     },
     {
-      "prediction": "I think it's better to use `corev1.ConditionTrue` instead of `hivev1.ProvisionedProvisionedReason` in this case.",
+      "prediction": "I think it's better to use `corev1.ConditionTrue` instead of `hivev1.ProvisionedCondition` in this case.",
       "reference": "Shouldn't this be in the above `if` block where we are setting the installedtimestamp to ensure this only happens for already installed (and/or adopted) clusters?"
     },
     {
@@ -25883,15 +25883,15 @@
       "reference": "This seems like another unrelated change I've done in `master`."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. It's not clear what you're trying to do with `config.formatters` and `config.formatters.first.output.path`.",
+      "prediction": "I'm not sure what you're trying to do here. I think you're trying to add a new formatter to the list of available formatters, but you're not actually changing the list of available formatters. You're just adding a new formatter to the list of available formatters, but you're not actually changing the list of available formatters.",
       "reference": "Would be good to have another context `\"when a duplicate formatter exists for a different output target\"` that shows that it keeps both. As this stands, the specs could pass w/o the `formatter.output == new_formatter.output` check."
     },
     {
-      "prediction": "I think this should be `Kokkos::Impl::throw_runtime_exception` instead of `Kokkos::Impl::throw_runtime_exception_msg`.",
+      "prediction": "I think this should be `const void* const` instead of `const void*`.",
       "reference": "Why not just remove? The CUDA one has been around for while. This one has not been part of any release (?)"
     },
     {
-      "prediction": "I'm not sure what this is for, but I think it should be `mFirstContentfulPaint` instead of `mFirstContentFulPaint`.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "nit: `Contentful` is the word used in the GV API, without the uppercase in F"
     },
     {
@@ -25903,35 +25903,35 @@
       "reference": "We no longer have karma output in the test file so these selectors were now unique and the target didn't need a child selector. Updated to force non-unique nodes"
     },
     {
-      "prediction": "I think it's better to have a link to the mentor's profile instead of a link to the mentor's avatar.",
+      "prediction": "I think we should remove the `<% content_for :additional_header_links do %>` line.",
       "reference": "This moved from a partial to not being in a partial. How about cleaning this view up further by moving it back into a partial?"
     },
     {
-      "prediction": "I'm not sure what you mean by `recieveUpdates`. Is it true that `recieveUpdates` is true by default? If so, I don't think it's a good idea to set it to `true` here.",
+      "prediction": "I don't think we need to use `cache.DeltaFIFOOptions` here. We can just use `cache.DeletionHandlingMetaNamespaceKeyFunc` here.",
       "reference": "add some form of docs in docstring or on :74 for what the effect is"
     },
     {
-      "prediction": "I think we can remove `from kinto.core.utils import COMPARISON, find_nested_value, json` as it's not used in the rest of the code.",
+      "prediction": "I think this should be `from kinto.core.utils import COMPARISON, find_nested_value` instead of `from kinto.core.utils import COMPARISON, find_nested_value, json`",
       "reference": "Couldn't you import `json` from `kinto.core.utils` here too?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.",
+      "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to add this to the spec file. I'm not sure if this is a good idea or not, but I think it's a good idea to add this to the spec file. I'm not sure if this is a good idea or not, but I think it's a good idea to add this to the spec file. I'm not sure if this is a good idea or not, but I think it's a good idea to add this to the spec file. I'm not sure if this is a good idea or not, but I think it's a good idea to add this to the spec file. I'm not sure if this is a good idea or not, but I think it's a good idea to add this to the spec file. I'm not sure if this is a good idea or not, but I think it's a good idea to add this to the spec file. I'm not sure if this is a good idea or not, but I think it's a good idea to add this to the spec file. I'm not sure if this is a good idea or not, but I think it's a good idea to add this",
       "reference": "Minor: Hmmm...is it worth setting this explicitly for the tests that it affects?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the destructor.",
+      "prediction": "I think we should remove the `std::lock_guard guard;` from the destructor.",
       "reference": "This was added to fix a race condition and you are reverting it here, right?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate function for this.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate function for this, so that we don't have to call it multiple times.",
       "reference": "Could you add some extra text here, so that it reads \"eth_coinbase function is not available, please use --private.api.addr option instead of --chaindata option\", so that it is clear that the function can work, but different options"
     },
     {
-      "prediction": "I think this should be `find('#ncr_work_order_expense_type_ba80').click` instead of `find('#ncr_work_order_expense_type_ba60').click`",
+      "prediction": "I think we can remove the `login_as` call here.",
       "reference": "`new_ncr_work_order_path` ? (I've been slowly moving specs over to that way of calling paths)"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
+      "prediction": "I'm not sure what you're trying to do here. I think you're trying to remove the `application/x-shockwave-flash` MIME type from all requests and responses. Is that what you're trying to do?",
       "reference": "Should flash be included in the patterns too? It currently isn't."
     },
     {
@@ -25943,11 +25943,11 @@
       "reference": "(ignore this. testing a codeflow bug)"
     },
     {
-      "prediction": "I think we should remove the `tlsDisableHostVerification` flag, as it's not needed anymore.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `main.go` file, since it's used in both `main.go` and `buildCLIOptions.go`.",
       "reference": "[Nit] can you change the Usage wording to indicate that the flag is used to opt-out of server certificate verification? (e.g. \"disables validation of the Cassandra cluster's server certificate.\")"
     },
     {
-      "prediction": "`MergeById` is not used anywhere in this code, so I don't think we need to change it.",
+      "prediction": "`MergeById` is not used anywhere in this code, so I think we can safely remove it.",
       "reference": "Sorry :) Would be really helpful to integrate something like Eclipse Code Formatter, so it will fail if the code style is broken (the same as eslint fails on the frontend) I use IntelliJ IDEA and their vision of imports is a bit different :)"
     },
     {
@@ -25955,27 +25955,27 @@
       "reference": "this will still fail on systemd"
     },
     {
-      "prediction": "I'm not sure what you mean by \"type(body) == bytes\". I think it should be `type(body) == str` or `type(body) == bytes`.",
+      "prediction": "I think it's better to use `response.read()` instead of `response.read().decode('utf-8')`",
       "reference": "The convention in most of the codebase is to use `if isinstance(body, bytes):` instead."
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to show the completion in the context menu, even if it's not the last item in the list. This way, the user can quickly see what they're looking for, even if they don't know the name of the class or module they're looking for.",
+      "prediction": "I'm not sure I understand what you're trying to do here. Is it possible that you're trying to add a menu item to the context menu? If that's the case, I'm not sure I understand what you're trying to do here. Is it possible that you're trying to add a menu item to the context menu? If that's the case, I'm not sure I understand what you're trying to do here. Is it possible that you're trying to add a menu item to the context menu? If that's the case, I'm not sure I understand what you're trying to do here. Is it possible that you're trying to add a menu item to the context menu? If that's the case, I'm not sure I understand what you're trying to do here. Is it possible that you're trying to add a menu item to the context menu? If that's the case, I'm not sure I understand what you're trying to do here. Is it possible that you're trying to add a menu item to the context menu? If that's the case, I'm not sure I understand what you're trying to do here. Is it possible that you're trying to add a menu item to the context menu? If that's",
       "reference": "I think this would be better as: `label = comp.rsplit('.', 1)[-1]`"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `@SuppressWarnings(\"unchecked\")` here.",
+      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. I'm not sure if you're trying to create a `GeneratedResult` from a `RubyGapicContext`, or if you're trying to create a `GeneratedResult` from a `RubyGapicContext` and a `RubySnippetSet`. If you're trying to create a `GeneratedResult` from a `RubyGapicContext` and a `RubySnippetSet`, I think it would be better to create a `GeneratedResult` from a `RubySnippetSet` and a `RubyGapicContext`.",
       "reference": "We have been creating a language-level context interface for each language instead of parameterizing the generate function."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to generate a UUID from the media context and the media ID. I'm not sure what you're trying to achieve with this, but it looks like you're trying to generate a UUID from the media context and the media ID. I'm not sure what you're trying to achieve with this, but it looks like you're trying to generate a UUID from the media context and the media ID. I'm not sure what you're trying to achieve with this, but it looks like you're trying to generate a UUID from the media context and the media ID. I'm not sure what you're trying to achieve with this, but it looks like you're trying to generate a UUID from the media context and the media ID. I'm not sure what you're trying to achieve with this, but it looks like you're trying to generate a UUID from the media context and the media ID. I'm not sure what you're trying to achieve with this, but it looks like you're trying to generate a UUID from the media context and the media ID. I'm not sure what you're trying to achieve with this, but it looks like you're trying to generate a UUID from",
+      "prediction": "I'm not sure if this is a good idea, but I think it's better to use `sprintf` instead of concatenating strings.",
       "reference": "Same thing about context here."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to make sure that the namespace is not already in the namespace cache. If it is, then we can't continue as a new workflow.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the namespace entry exists, and if it doesn't, we should create it.",
       "reference": "there is a function to get namespace entry from mutable state directly"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `transport_data_get` here. You can just use `transport_data` directly.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a `transport_data_get` method in the `Bolt::Inventory` class.",
       "reference": "The `Transport::Config` objects don't serialize properly. We probably want to just turn them into hashes at this point."
     },
     {
@@ -25987,31 +25987,31 @@
       "reference": "If this is needed, should we check that the configured `uri` isn't already equal to the value of the metastore URI configured via `spark.hadoop.hive.metastore.uris` or any of the other ways of setting it. This would be a breaking change for people who have `uri` configured on the SparkSessionCatalog and have it correctly set (which I believe should be everybody as `uri` is currently required if I'm not mistaken)."
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think we should be able to do this in one line.",
+      "prediction": "I think this should be `if content_type and content_type.startswith(\"multipart/form-data\")` instead of `if content_type and content_type.startswith(\"multipart/form-data\")`",
       "reference": "see above - this is only used to select the correct view, we don't need to handle the boundary information here."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to do this in a single test.",
+      "prediction": "I don't think we need to add the CA certificate here. It's already added in the `gen.AddCertificateRequestAnnotations` call.",
       "reference": "These tests use a self-signed cert so the CA *is* the cert. I considered making a proper chain to use in the tests, but wasn't sure it was necessary to test here, since we test it in the E2E tests anyway."
     },
     {
-      "prediction": "I think this should be `if (oldProps !== newProps)` instead of `if (oldProps !== newProps && excessDomChildren != null)`",
+      "prediction": "I think it's better to do this in the `diffElementNodes` function instead of here.",
       "reference": "We could, maybe, just directly do `excessDomChildren[excessDomChildren.indexOf(dom)] = null;`. Would this improve the size in any way? This will end-up with a property on the `excessDomChildren[\"-1\"]` but maybe we could live with that?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a service.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move it to the `gridUtil` service.",
       "reference": "this looks like it may be something that needs additional refactoring"
     },
     {
-      "prediction": "I think this should be `yielder.iter()` instead of `yielder`",
+      "prediction": "I think this should be `yielder.iter()` instead of `yielder.iter().iter()`.",
       "reference": "Nit: Remove whitespace (and below)"
     },
     {
-      "prediction": "I don't think this is a good idea. It would be better to have a separate `error_open_zip` message.",
+      "prediction": "I don't think we need to change this. It's the same as before.",
       "reference": "\"Failed opening\" or \"Failed to open\"."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do it here. I'm not sure if this is the right place to do this, but I think it's a good idea to do it here. I'm not sure if this is the right place to do this, but I think it's a good idea to do it here. I'm not sure if this is the right place to do this, but I think it's a good idea to do it here. I'm not sure if this is the right place to do this, but I think it's a good idea to do it here. I'm not sure if this is the right place to do this, but I think it's a good idea to do it here. I'm not sure if this is the right place to do this, but I think it's a good idea to do it here. I'm not sure if this is the right place to do this, but I think it's a good idea to do it here. I'm not sure if this is the right place to do this, but I think it's a good idea to do it here. I'm not sure if this is the right place to do this",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `d.Disk.SizeGb == 0` before doing this.",
       "reference": "and -> or"
     },
     {
@@ -26023,15 +26023,15 @@
       "reference": "I don't think this belongs here. If the application can take a local_ip as input, the application should take care of it, not in this common library"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to disable the database layer here.",
       "reference": "@DanHarrin please add a `return true` at the bottom of this method, as the docblock indicates a boolean return value."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a `TermScorer` class that implements the `Scorer` interface and has a `PostingsEnum`, `ImpactsEnum`, and `DocIdSetIterator`. Is this what you're trying to achieve?",
+      "prediction": "I'm not sure what you mean by \"DocIdSetIterator\". It's not a `DocIdSetIterator`, it's a `DocIdSet` iterator.",
       "reference": "This is used in o.a.l.sandbox.search.BM25FQuery."
     },
     {
-      "prediction": "I'm not sure what you mean by \"intersects\" in this context.",
+      "prediction": "I'm not sure what you mean by \"intersects\" in this case.",
       "reference": "Shouldn't this work as well for Disjoint?"
     },
     {
@@ -26039,35 +26039,35 @@
       "reference": "Same here. This was included to quiet the test for the 3D descriptors. As we removed them, this exception handling is no longer required"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to use the `lbann::data_store::data_store_jag` class, but I'm not sure what you're trying to achieve with this change. It seems like you're trying to use the `lbann::data_store::data_store_jag` class, but I'm not sure what you're trying to achieve with this change. It seems like you're trying to use the `lbann::data_store::data_store_jag` class, but I'm not sure what you're trying to achieve with this change. It seems like you're trying to use the `lbann::data_store::data_store_jag` class, but I'm not sure what you're trying to achieve with this change. It seems like you're trying to use the `lbann::data_store::data_store_jag` class, but I'm not sure what you're trying to achieve with this change. It seems like you're trying to use the `lbann::data_store::data_store_jag` class, but I'm not sure what you're trying to achieve with this change. It seems",
+      "prediction": "I think this should be `#include \"lbann/data_store/data_store_jag.hpp\"`.",
       "reference": "Why do you need to load a specific data reader in lbann_library?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `EthereumStep` class, so that it can be used in the `EthereumRunner` class.",
+      "prediction": "I think we can remove the `default;` here, as it's not used anywhere.",
       "reference": "why not ValueTask?"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to get rid of the `installerImage` field in the `ReconcileClusterDeployment` struct, but I'm not sure what you're trying to do with it. I think you're trying to get rid of the `installerImage` field in the `ReconcileClusterDeployment` struct, but I'm not sure what you're trying to do with it. I think you're trying to get rid of the `installerImage` field in the `ReconcileClusterDeployment` struct, but I'm not sure what you're trying to do with it. I think you're trying to get rid of the `installerImage` field in the `ReconcileClusterDeployment` struct, but I'm not sure what you're trying to do with it. I think you're trying to get rid of the `installerImage` field in the `ReconcileClusterDeployment` struct, but I'm not sure what you're trying to do with it. I think you're trying to get rid of the `installerImage` field in the `ReconcileClusterDeployment` struct, but I'm not sure what you're trying to do with it. I think",
+      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to get rid of the `installerImage` field from the request, but you're still using it in the `resolveInstallerImage` function. Is this what you're trying to do?",
       "reference": "I'm nervous about this line, I don't want to go regenerate a bunch of imageset jobs for clusters that are old, already installed, but don't have a CLIImage set (which they wouldn't because they're old) Adding the Installed guard is meant to address this. Otherwise this *should* recreate the imageset job due to the code in this function that deletes the job if it's finished. (but we don't have our images set due to this clause)"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a new `BaseTable` from a `TableMetadata`, but you're not using the `TableMetadata` to create a new `BaseTable`. I think you're trying to create a new `BaseTable` from a `TableMetadata`, but you're not using the `TableMetadata` to create a new `BaseTable`. I think you're trying to create a new `BaseTable` from a `TableMetadata`, but you're not using the `TableMetadata` to create a new `BaseTable`. I think you're trying to create a new `BaseTable` from a `TableMetadata`, but you're not using the `TableMetadata` to create a new `BaseTable`. I think you're trying to create a new `BaseTable` from a `TableMetadata`, but you're not using the `TableMetadata` to create a new `BaseTable`. I think you're trying to create a new `BaseTable` from a `TableMetadata`, but you're not using the `TableMetadata` to create a new `BaseTable`. I think you're trying to create a new `BaseTable` from a `TableMetadata`, but you're",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `TableMetadata` class that can be used to create a `BaseTable` from a `TableMetadata` and a `Location`.",
       "reference": "Is it necessary to change this file? Doesn't `tableMetadata` call `newTableMetadata`?"
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.",
+      "prediction": "I don't think this is a good idea. It's not clear to me why we would want to do this, and it's not clear to me why we would want to do this, and it's not clear to me why we would want to do this, and it's not clear to me why we would want to do this, and it's not clear to me why we would want to do this, and it's not clear to me why we would want to do this, and it's not clear to me why we would want to do this, and it's not clear to me why we would want to do this, and it's not clear to me why we would want to do this, and it's not clear to me why we would want to do this, and it's not clear to me why we would want to do this, and it's not clear to me why we would want to do this, and it's not clear to me why we would want to do this, and it's not clear to me why we would want to do this, and it's not clear to me why we would want to do this, and it's not clear to me why we would want to do this, and it's not clear to me",
       "reference": "I think that I have a better proposal for this test - improve it so that it would know how to read the list of SupportedProtocolVersions and dynamically use these. The motivation here is that I expect to have another network version soon, and this test seems to be a good test case for that."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all the tables in a namespace. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all the tables in a namespace. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all the tables in a namespace. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all the tables in a namespace. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all the tables in a namespace. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all the tables in a namespace. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all the tables in a namespace. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all the tables in a namespace.",
+      "prediction": "I'm not sure I understand what you're trying to do here. Can you please provide some more context?",
       "reference": "What is the purpose of this debug message? I'm not sure how it would help."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `extutil` package from the `kythe.io/kythe/go/extractors/bazel` package. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `extutil` package from the `kythe.io/kythe/go/extractors/bazel` package. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `extutil` package from the `kythe.io/kythe/go/extractors/bazel` package. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `extutil` package from the `kythe.io/kythe/go/extractors/bazel` package. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use the `extutil` package from the `kythe.io/kythe/go/extractors/bazel` package. I'm not sure what you're trying to achieve with this change, but it looks like you're trying",
+      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. The `extutil` package is not meant to be used in this way. It's meant to be used in the context of the `extutil` package, which is meant to be used in the context of the `extutil` package, which is meant to be used in the context of the `extutil` package, which is meant to be used in the context of the `extutil` package, which is meant to be used in the context of the `extutil` package, which is meant to be used in the context of the `extutil` package, which is meant to be used in the context of the `extutil` package, which is meant to be used in the context of the `extutil` package, which is meant to be used in the context of the `extutil` package, which is meant to be used in the context of the `extutil` package, which is meant to be used in the context of the `extutil` package, which is meant to be used in the context of the `extutil` package, which is meant to be used in the context of the `ext",
       "reference": "Is there a corresponding BUILD dependency to prune?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to make a PUT request to a URL that doesn't have a `Content-Type` header. I'm not sure what you're trying to do here, but it looks like you're trying to make a PUT request to a URL that doesn't have a `Content-Type` header. I'm not sure what you're trying to do here, but it looks like you're trying to make a PUT request to a URL that doesn't have a `Content-Type` header. I'm not sure what you're trying to do here, but it looks like you're trying to make a PUT request to a URL that doesn't have a `Content-Type` header. I'm not sure what you're trying to do here, but it looks like you're trying to make a PUT request to a URL that doesn't have a `Content-Type` header. I'm not sure what you're trying to do here, but it looks like you're trying to make a PUT request to a URL that doesn't have a `Content-Type` header. I'm not sure what you're trying to do here, but it looks like you're trying to make a PUT request to a URL that",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this.",
       "reference": "The \"good\" and \"bad\" descriptions confused me a bit. Maybe `allowedContentType` and `disallowedContentType`? Not sure if that's better."
     },
     {
@@ -26075,47 +26075,47 @@
       "reference": "It would be better to just change RWD to throw IllegalStateException if you attempt to execute a command after quit (unless it's a second call to quit())"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me if this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me if this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me if this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me if this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me if this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me if this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me if this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me if this is the",
       "reference": "You may want to have a look at `func checkClusterFormed(t *testing.T, servers ...*Server)` in this file that I created some time ago. It will timeout at 5 seconds, but will return as soon as cluster is ready."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `push_cb` function.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in `flux_respond_error` instead of `flux_respond`.",
       "reference": "I see a few places where this blob of code is required due to the removal of `errnum` parameter from `flux_respond` -- trading 2 lines of code for 8. The improvement to the function seems like a good idea, but I wonder if we need a convenience macro or function to do it the old way? You went through and made all the changes, was it overall a net win?"
     },
     {
-      "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to move this to a separate file, so that it can be used in other places as well.",
+      "prediction": "I'm not sure if this is a good place to put this, but I think it would be good to have it in a separate file.",
       "reference": "I know it's not related to your change, but it's a bit odd that this import uses a relative path rather than the ones setup by webpack. Might be nice to change this one in case we refactor those paths in the future; this one wouldn't get caught in any kind of find+replace."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `newSchedule` variable that holds a reference to the `schedule` that was just created. This way, we don't need to create a new `schedule` object every time we want to execute a new schedule.",
+      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to create a new `Schedule` object and pass it to the `ExecuteSchedule` function, but the `ExecuteSchedule` function doesn't take a `Schedule` object as an argument. Is this what you're trying to do? If so, how do you plan to pass the `Schedule` object to the `ExecuteSchedule` function?",
       "reference": "Good catch, and if we don't declare the newSchedule here, will the last schedule be executed in multi goroutine?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to get a list of all the projects in the solution that don't have a target framework, but I'm not sure what you're trying to do with the `includeSecurity` parameter.",
+      "prediction": "I don't think this is necessary. We can just use `TryGetTargetFrameworks()` instead of `TryGetTargetFrameworksAsync()`.",
       "reference": "`project` should never be null here, unless we have projects that aren't in the solution? Which we shouldn't have"
     },
     {
-      "prediction": "I think we can remove the `#include \"extractor/restriction_map.hpp\"` and `#include \"extractor/restriction_compressor.hpp\"`.",
+      "prediction": "I think we can remove the `#include \"util/dynamic_graph.hpp\"` and `#include \"util/node_based_graph.hpp\"`.",
       "reference": "Simple `for` loop instead of `for_each` would help here by making it more readable."
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea to change the `thread_role_name_string` in this way.",
+      "prediction": "I'm not sure if this is the right place for this, but I think it would be good to add a comment here explaining that this is just a placeholder for the name of the thread role.",
       "reference": "Looks like this falls through, should break."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. The `ManifestListWriter` is supposed to be used to write a list of manifest files to a file. It's not supposed to be used to write a single manifest file to a file.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a `@Override` to the `ManifestListWriter` class so that it can be used in the `ManifestFile` class as well.",
       "reference": "Let's default manifest lists and manifests to overwrite. These use UUID-based file names and should never conflict."
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a `showSpeechViewerAtStartup` option in the `speechView` section.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `keyboard` section, since it's related to the keyboard settings.",
       "reference": "Please rename [speechView] to [speechViewer]."
     },
     {
-      "prediction": "I think we can remove the `InUsermode` and `InKernelmode` fields.",
+      "prediction": "I think it's better to have a separate field for the kernel mode usage.",
       "reference": "I would use shorter yet still descriptive names, e.g. `KernelPerCpu` and `UserPerCpu`."
     },
     {
-      "prediction": "I'm not sure what you mean by `check_user_can_edit_record(user_info, recID)`. I think it should be `check_user_can_edit_record(user_info, recID, can_edit_record=True)`",
+      "prediction": "I don't think this is necessary.",
       "reference": "if we are seeking for the content of only one field from metadata, no need to check whether a user could edit record or not"
     },
     {
@@ -26123,23 +26123,23 @@
       "reference": "Should this be camelCase to match the above commands? I am not the expert here so maybe Lucas or David can chime in."
     },
     {
-      "prediction": "I think we can remove the `span.SetTag(Tags.Language, TracerConstants.Language)` line.",
+      "prediction": "I think this should be `span.SetTag(Tags.Language, TracerConstants.Language);` instead of `span.SetTag(Tags.Language, TracerConstants.Language);`",
       "reference": "This is also missing in CreateScopeFromExecuteAsync. Can you add that there too?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"CEST$\", but I think it's a typo. It should be `CEST` instead of `CEST$`.",
+      "prediction": "I'm not sure what you mean by \"CEST$\", but I think it should be `+02:00` instead of `+0200`.",
       "reference": "I hope that this does not break anything... Probably needs detailed beta tests."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. What is the purpose of the `assign_files_or_directories_to_run` method? What is the purpose of the `config.start_time` variable? What is the purpose of the `files_to_run` method? What is the purpose of the `post_processing` method? What is the purpose of the `start_time` variable? What is the purpose of the `start_time` variable? What is the purpose of the `start_time` variable? What is the purpose of the `start_time` variable? What is the purpose of the `start_time` variable? What is the purpose of the `start_time` variable? What is the purpose of the `start_time` variable? What is the purpose of the `start_time` variable? What is the purpose of the `start_time` variable? What is the purpose of the `start_time` variable? What is the purpose of the `start_time` variable? What is the purpose of the `start_time` variable? What is the purpose of the `start_time` variable? What is the purpose of the `start_time` variable? What is the purpose of the `start_time` variable? What is the purpose of the `",
+      "prediction": "I'm not sure what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear",
       "reference": "@JonRowe in what scenario do you see this being manually set?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do it.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in `nano::block_processor::process_live` instead of in `nano::block_processor::process_block`.",
       "reference": "I think the work \"trigger\" makes more sense than \"check\" because this is taking an action based on status."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to put this in the `AuthHandlerBoot` class as well.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `AuthHandlerBoot` class, since it's the only place where the `RSAKeypair4Auth` instance is created.",
       "reference": "add a configuration , default put public key in Microservice, if the configuration is set, then put in Instance."
     },
     {
@@ -26151,15 +26151,15 @@
       "reference": "With the introduction of the enum(s) the constants in the store classes should be removed."
     },
     {
-      "prediction": "I think we should drop the `if (ip_header->ihl > 5) { ... }` check.",
+      "prediction": "I think this should be `if (ip_header->ihl > 5)` instead of `if (ip_header->ihl > 4)`.",
       "reference": "I would say `!= 5`; A packet with <5 would be malformed."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a new integrator with the same selector and exporter, but with a different stateful. Is that what you're trying to do? If so, I'm not sure what you're trying to do here. I think you're trying to create a new integrator with the same selector and exporter, but with a different stateful. Is that what you're trying to do? If so, I'm not sure what you're trying to do here. I think you're trying to create a new integrator with the same selector and exporter, but with a different stateful. Is that what you're trying to do? If so, I'm not sure what you're trying to do here. I think you're trying to create a new integrator with the same selector and exporter, but with a different stateful. Is that what you're trying to do? If so, I'm not sure what you're trying to do here. I think you're trying to create a new integrator with the same selector and exporter, but with a different stateful. Is that what you're trying to do? If so, I'm not sure what you're trying to do here",
+      "prediction": "I'm not sure what you mean by `simple.New` and `simple.WithResource`. I'm not sure what you mean by `simple.New` and `simple.WithResource`. I'm not sure what you mean by `simple.New` and `simple.WithResource`. I'm not sure what you mean by `simple.New` and `simple.WithResource`. I'm not sure what you mean by `simple.New` and `simple.WithResource`. I'm not sure what you mean by `simple.New` and `simple.WithResource`. I'm not sure what you mean by `simple.New` and `simple.WithResource`. I'm not sure what you mean by `simple.New` and `simple.WithResource`. I'm not sure what you mean by `simple.New` and `simple.WithResource`. I'm not sure what you mean by `simple.New` and `simple.WithResource`. I'm not sure what you mean by `simple.New` and `simple.WithResource`. I'm not sure what you mean by `simple.New` and `simple.WithResource`. I'm not sure what you mean by `simple.New` and `simple.WithResource`. I'm not sure what you mean by `simple.New` and `simple.WithResource`. I'm not sure",
       "reference": "I think you missed removing `Stateful` from `push/config.go`"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to update the `UpdateReadMetrics` and `UpdateWriteMetrics` methods in the `Nethermind.Db.Databases` namespace. This way, we don't have to update the `UpdateReadMetrics` and `UpdateWriteMetrics` methods in the `Nethermind.Db` namespace.",
+      "prediction": "I think this should be `internal` instead of `protected`.",
       "reference": "why would you make it internal? if so then at least protected internal"
     },
     {
@@ -26167,75 +26167,75 @@
       "reference": "We should check if the response (`d`) contains bar as response, screw the log. :smile:"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in `GPUTreeLearner::AllocateGPUMemory` as well.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `GPUTreeLearner::AllocateGPUMemory` function.",
       "reference": "@Laurae2 good call. This is the only one I found (with `git grep transfered`)"
     },
     {
-      "prediction": "I think this should be `node.statement(future=True)` instead of `node.statement(future=True) not in node.frame().body`",
+      "prediction": "I'm not sure what you mean by \"break but don't emit message if postponed evaluation is enabled\"",
       "reference": "I don't understand how this work, could you explain ?"
     },
     {
-      "prediction": "I think this should be `MCTX_NUM_SIMD_SLOTS` instead of `NUM_SIMD_REGS`.",
+      "prediction": "I think it's better to use `memset` instead of `memset` here.",
       "reference": "The abbreviation for \"context\" used extensively inside DR is \"cxt\", not \"ctx\", so s/MCTX/MCXT/."
     },
     {
-      "prediction": "I don't think we need to change anything here.",
+      "prediction": "I don't think we need to change this.",
       "reference": "here is `:seconds` missing again"
     },
     {
-      "prediction": "I don't think you need to add `null` to the `authenticationAlgorithm` field.",
+      "prediction": "I don't think this is needed anymore. The `authenticationAlgorithm` should be set to `null` and the `timeoutSec` and `maxActiveConnections` should be set to 0.",
       "reference": "initializing to null makes me uncomfortable. let's have a default value"
     },
     {
-      "prediction": "I think this should be `else if (pathStart == -1)` instead of `else if (ch == BytePercentage)`.",
+      "prediction": "I'm not sure what you mean by \"Empty path is illegal\". Is this a bug in Kestrel?",
       "reference": "This is the `GET % HTTP/1.1` scenario right?"
     },
     {
-      "prediction": "I don't think this is necessary. We can just use `BackendAuth::check()` instead of `BackendAuth::isGranted()`.",
+      "prediction": "I don't think this is necessary. We can just use `BackendAuth::checkUser()` instead of `BackendAuth::isUserLoggedIn()`.",
       "reference": "No need to use the fully qualified path the BackendAuth facade, just `use BackendAuth` is fine."
     },
     {
-      "prediction": "I'm not sure what you mean by `nano::epoch::epoch_0`. I think it should be `nano::epoch::epoch_1` or `nano::epoch::epoch_2` or something like that.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would make sense to move this to the `nano::block` class, since it's not a member of the `nano::send_block` class.",
       "reference": "Because it's similar for send/open/change/receive types, then probably it can be just common `nano::epoch nano::block::epoch () const` with override for state_block (like nano::block::link (), account (), representative ())"
     },
     {
-      "prediction": "I don't think this is necessary. We can just use `webviewApiPromises_` directly.",
+      "prediction": "I don't think we need to use `webviewApiPromises_` here. We can just use `webviewApi` directly.",
       "reference": "Please give a more descriptive name and add a command to explain what it does."
     },
     {
-      "prediction": "I think it's better to use `prefMobileUpdateAllowed` instead of `prefMobileUpdate`",
+      "prediction": "I don't think it's necessary to have a `PREF_MOBILE_UPDATE` in the `UserPreferences` class. I think it's better to have a `PREF_MOBILE_UPDATE_ALLOWED` and a `PREF_MOBILE_UPDATE` in the `UserPreferences` class.",
       "reference": "we can never get rid of this..."
     },
     {
-      "prediction": "I think we can remove the `[]string{\"controller\", \"method\", \"resource\", \"remote\", \"status\"}` from the `metricKubeClientRequestSeconds` prometheus metric.",
+      "prediction": "I don't think we need to change this.",
       "reference": "what is the effect of changing these buckets in existing data that is available in the monitoring system? if there are any existing dashboards that use previous histogram buckets they are probably going to be wrong ot invalid? also any reason why we chose these specific values?"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this flag, but I think it's a bad idea.",
+      "prediction": "I think this should be `sanitize-tchannel` instead of `sanitize-tchannel`",
       "reference": "This won't work. For the flag to be passed to the plugin, it should be passed as part of the --plugin argument. --plugin \"yarpc --sanitize-tchannel\""
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to make this a public API, so that we can use it in the future.",
+      "prediction": "I'm not sure if this is the best place to put this, but I think it would make sense to move it to `LGBM_BoosterGetNumFeatures` and `LGBM_BoosterSetNumFeatures`.",
       "reference": "@shiyu1994 @StrikerRUS what do you think about this addition to `c_api.cpp`? I think it's a really useful addition to be able to get this type of information from the `Booster`, but I want more opinions since `c_api` is the main public API for the library."
     },
     {
-      "prediction": "I'm not sure what you mean by \"initialize\" here. It's not clear to me what you're trying to do with this function.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function to initialize the accountUpdates struct.",
       "reference": "rename Round -> requestedRound and DbRound -> dbRound. we don't need to export the fields here, only the error struct."
     },
     {
-      "prediction": "I'm not sure if this is the right way to do this, but I think we should be able to do this in a single test. If we can't do this in a single test, we should be able to do it in a separate test.",
+      "prediction": "I'm not sure if this is the right way to do this, but I think we should be able to do this in a single test. I'm not sure if we should be able to do this in a single test. I'm not sure if we should be able to do this in a single test. I'm not sure if we should be able to do this in a single test. I'm not sure if we should be able to do this in a single test. I'm not sure if we should be able to do this in a single test. I'm not sure if we should be able to do this in a single test. I'm not sure if we should be able to do this in a single test. I'm not sure if we should be able to do this in a single test. I'm not sure if we should be able to do this in a single test. I'm not sure if we should be able to do this in a single test. I'm not sure if we should be able to do this in a single test. I'm not sure if we should be able to do this in a single test. I'm not sure if we should be able to do this in a single test. I'm not sure if we",
       "reference": "This expected value should probably be what you literally expect, otherwise there's a chance getClusterRegion is doing something wrong and the test wouldn't catch it because it's being run for both expected and actual."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this code, but I think it's a bad idea to use `tls` in this context. It's not a good idea to use `tls` in this context. It's not a good idea to use `tls` in this context. It's not a good idea to use `tls` in this context. It's not a good idea to use `tls` in this context. It's not a good idea to use `tls` in this context. It's not a good idea to use `tls` in this context. It's not a good idea to use `tls` in this context. It's not a good idea to use `tls` in this context. It's not a good idea to use `tls` in this context. It's not a good idea to use `tls` in this context. It's not a good idea to use `tls` in this context. It's not a good idea to use `tls` in this context. It's not a good idea to use `tls` in this context. It's not a good idea to use `tls` in this context. It's not a good idea to use `tls` in this context.",
+      "prediction": "I don't think we need to use `x509` here. We can just use `base64` here.",
       "reference": "TODO: update unit tests to exercise base64-inline path"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have this in the `Preferences` class, so that we don't have to call this method every time we want to change the auto-flattr settings.",
+      "prediction": "I don't think we need to do this.",
       "reference": "this method knows too much - it is kind of a strange side effect I'd prefer if we had separate method for acknowledging that the onboarding was done and should not be shown again"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's better to use `ALTER TABLE ... ADD COLUMN ...` instead of `ALTER TABLE ... ADD COLUMN ...`.",
+      "prediction": "I don't think we need to do this.",
       "reference": "Do we need to increase the DB version? Also, should probably be a constant, no?"
     },
     {
@@ -26243,7 +26243,7 @@
       "reference": "We could utilize the new isZero method in this if-statement, right?"
     },
     {
-      "prediction": "I think we should use `logger.NewNull()` instead of `logger.NewTestLogger(t)`.",
+      "prediction": "I'm not sure I understand what you're trying to do here. The `makeTestBlockOpsConfig` function is supposed to create a new `testBlockOpsConfig` object, but it seems to be returning an empty `testBlockOpsConfig` object instead. Is there a specific reason for this?",
       "reference": "should probably have config have a `t` or a `logger.NewTestLogger(t)`, and return the latter"
     },
     {
@@ -26251,47 +26251,47 @@
       "reference": "Does this not do the same thing as `copy`? I thought that `copy` just did an elementwise assignment, but maybe I was wrong."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check to make sure that `flatteningConfigsFromGapicConfig` and `flatteningConfigsFromProtoFile` are not null.",
+      "prediction": "I think it's better to use `ImmutableMap.copyOf` instead of `ImmutableList.copyOf` here. `ImmutableMap.copyOf` is more efficient than `ImmutableList.copyOf` in this case.",
       "reference": "Here we are merging the configs from proto annotations and gapic config. But in other places in this PR we are using the new enum to pick one or the other, right? Or is that not the correct way to think about this?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
+      "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to have a default value for the `Port` option. If you don't specify a port, it defaults to `8080`.",
       "reference": "not related to this change?"
     },
     {
-      "prediction": "I'm not sure why we need to check for `ANDROID_NDK_HOME` here. We can just use `process.env[\"ANDROID_NDK\"]` and `process.env[\"ANDROID_NDK_HOME\"]`.",
+      "prediction": "I'm not sure why we need to use `process.env[\"ANDROID_NDK\"]` instead of `process.env[\"ANDROID_NDK_HOME\"]`.",
       "reference": "Why is this needed?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
+      "prediction": "I'm not sure what you mean by \"calculatedStepSpeed <= 0\". I think you meant to say \"calculatedStepSpeed >= 0\".",
       "reference": "This one could be replaced with a `std::max`, no?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `Selenium::Firefox` module.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate method for this. It's not clear to me that this is the right place to do this.",
       "reference": "Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.",
+      "prediction": "I'm not sure if this is the best way to do this, but it seems to work.",
       "reference": "Please use strict type comparisons (`===`), not loose type comparisons."
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's better to return `false` in this case than to return `null`.",
+      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.",
       "reference": "The filter parameters are a bit confusing. I understand that one of them has to be set, but what takes precedence if a from/to is set and the hash as well? Should that fail?"
     },
     {
-      "prediction": "I don't think we need to include `cstdio` and `tuple` here.",
+      "prediction": "I'm not sure why we need to include `cstdio` and `tuple` here. We can just use `std::string` and `std::tuple` instead.",
       "reference": "Is that necessary?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me",
+      "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `org_letters.each` here. You can just use `org_letters.include?(\"7\")` and it will return `true` or `false` depending on whether `7` is in `org_letters` or not.",
       "reference": "yess so much easier to read in order like this!"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this rule chain. It looks like you're trying to make sure that the test suite is run with the correct naming convention, but I'm not sure what you're trying to achieve with this rule chain. It looks like you're trying to make sure that the test suite is run with the correct naming convention, but I'm not sure what you're trying to achieve with this rule chain. It looks like you're trying to make sure that the test suite is run with the correct naming convention, but I'm not sure what you're trying to achieve with this rule chain. It looks like you're trying to make sure that the test suite is run with the correct naming convention, but I'm not sure what you're trying to achieve with this rule chain. It looks like you're trying to make sure that the test suite is run with the correct naming convention, but I'm not sure what you're trying to achieve with this rule chain. It looks like you're trying to make sure that the test suite is run with the correct naming convention, but I'm not sure what you're trying to achieve with this rule chain. It looks like you're trying to make sure that the test suite is run with the correct naming",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `RuleChain` class.",
       "reference": "question: would this convention automatically and always apply to all classes derived from `LuceneTestCase` including any non-`org.apache` name spaces or would it be possible to opt-out (without an exclusion list) somehow for custom code that might perhaps have chosen a different convention?"
     },
     {
-      "prediction": "I think it's a good idea to have a default value for `MIN_PASSCODE_LENGTH` instead of hardcoding it to 6.",
+      "prediction": "I think this should be `MIN_PASSCODE_LENGTH = 4` instead of `MIN_PASSCODE_LENGTH = 6`",
       "reference": "Also found this bug, where we were setting the min passcode length to 6, but the min length for a connected app is 4. This can cause problems when the app is force closed or the shared pref is removed."
     },
     {
@@ -26299,15 +26299,15 @@
       "reference": "Why was this change necessary?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this, but I think it's a bad idea to have a `Logger` in the `Host` class. The `Logger` should be in the `Selenium Distributor` class, not the `Host` class.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "I kind of did this deliberately, so everything from the distributor appears in the same set of logs."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to add a `seq` field to the packet, but you're not actually doing anything with it. I'm not sure what you're trying to do here, but it looks like you're trying to add a `seq` field to the packet, but you're not actually doing anything with it. I'm not sure what you're trying to do here, but it looks like you're trying to add a `seq` field to the packet, but you're not actually doing anything with it. I'm not sure what you're trying to do here, but it looks like you're trying to add a `seq` field to the packet, but you're not actually doing anything with it. I'm not sure what you're trying to do here, but it looks like you're trying to add a `seq` field to the packet, but you're not actually doing anything with it. I'm not sure what you're trying to do here, but it looks like you're trying to add a `seq` field to the packet, but you're not actually doing anything with it. I'm not sure what you're trying to do here, but it looks like",
+      "prediction": "I think this should be `metadata[\"seq\"] = pkt[TCP].seq + 1` instead of `metadata[\"seq\"] = pkt[TCP].seq`",
       "reference": "We already have a `seq = pkt[TCP].seq` so you can just re-use it."
     },
     {
-      "prediction": "`Instant` and `LocalDate` are immutable, but `LocalDateTime` and `OffsetDateTime` are not.",
+      "prediction": "`Instant` is not a `LocalDate` or `LocalTime` or `LocalDateTime` or `OffsetDateTime` or `ZonedDateTime`.",
       "reference": "We avoid wildcard imports because it isn't clear where symbols are coming from and there is potential for collision. Could you roll back this change? (As well as the additional newline, we don't use breaks in imports either.)"
     },
     {
@@ -26319,7 +26319,7 @@
       "reference": "Do you test for file existence simply to reduce the warning message that may occur using the include? Also - I think the practice used in BOINC is to go ahead and use include_once even though it isn't strictly necessary in this case."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to add a `duration` column to the spec, but I don't think that's what you're trying to do here. I think you're trying to add a `duration` column to the spec, but I don't think that's what you're trying to do here. I think you're trying to add a `duration` column to the spec, but I don't think that's what you're trying to do here. I think you're trying to add a `duration` column to the spec, but I don't think that's what you're trying to do here. I think you're trying to add a `duration` column to the spec, but I don't think that's what you're trying to do here. I think you're trying to add a `duration` column to the spec, but I don't think that's what you're trying to do here. I think you're trying to add a `duration` column to the spec, but I don't think that's what you're trying to do here. I think you're trying to add a `duration` column to the spec, but I don't think that's what you're trying",
+      "prediction": "I'm not sure what you mean by \"action\" and \"duration\" in this context. Could you please clarify?",
       "reference": "`TimeChaos` does not contains a field .spec.action"
     },
     {
@@ -26327,23 +26327,23 @@
       "reference": "You need to override where possible in rs-api"
     },
     {
-      "prediction": "I think we can remove the `Dictionary AdditionalData { get; set; } = new Dictionary();` line.",
+      "prediction": "I think we should remove the `Dictionary AdditionalData { get; set; }` and just use `AdditionalData` instead.",
       "reference": "Should this have an add/update/etc pattern? What happens if I need to change some set of data? May be better to just let the callsite manipulate the dictionary."
     },
     {
-      "prediction": "I'm not sure what you mean by \"return an attribute with the requested name\"",
+      "prediction": "I don't think we need to override this method.",
       "reference": "I don't think this should be added to PyRegion. Adding it here requires that every region have an \"algorithm\" which may not always make sense and the return value type will be different in every case. But fine to use the same name in the regions where we choose to implement it as a convention if that makes the API more discoverable."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to log the error.",
+      "prediction": "I'm not sure this is the right place to do this, but I think it's a good idea to log the error.",
       "reference": "Returning here bypasses all the health check and load balancing features."
     },
     {
-      "prediction": "I think we should remove the `//` at the top of the file.",
+      "prediction": "I'm not sure if this is the right place for this change. I think we should move this to a separate PR.",
       "reference": "Should revert this copyright change, when the file isn't changing in any other way."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to check if the file already exists before trying to write to it.",
+      "prediction": "I don't think we need to check for `dir != \"\"` in this case. If the directory doesn't exist, it will be created anyway.",
       "reference": "Interesting that filepath.Dir(\"thing\") returns \".\" whereas this returns \"\""
     },
     {
@@ -26351,19 +26351,19 @@
       "reference": "Nice, I did not know about that"
     },
     {
-      "prediction": "I think this should be `std::unordered_map>>>`.",
+      "prediction": "I think this should be `std::unordered_map>>>`",
       "reference": "Since the lock is have moved outside of this function, I think it would be simpler and efficient to just return a ref to the std::vector? That way, we don't need to make a new copy on read and we won't actually need a write operation."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to use the `ReadState` method to get the block identifier, and then use that to create the `ReadStateResponse` object.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `readStateHeight` to make sure we don't try to read a state that doesn't exist. I'm not sure if this is the right place to do this, but I think it would be good to add a check for `readStateHeight` to make sure we don't try to read a state that doesn't exist. I'm not sure if this is the right place to do this, but I think it would be good to add a check for `readStateHeight` to make sure we don't try to read a state that doesn't exist. I'm not sure if this is the right place to do this, but I think it would be good to add a check for `readStateHeight` to make sure we don't try to read a state that doesn't exist. I'm not sure if this is the right place to do this, but I think it would be good to add a check for `readStateHeight` to make sure we don't try to read a state that doesn't exist. I'm not sure if this is the right place to do this, but I think it would be good",
       "reference": "also fetch block hash of this height and return hash"
     },
     {
-      "prediction": "I think this should be `var clientRequestContent = new StringContent(RequestContent, Encoding.UTF8, \"text/plain\");`",
+      "prediction": "I think this should be `var clientRequestContent = new StringContent(RequestContent, Encoding.UTF8, \"application/json\");`",
       "reference": "Why do we need this in this sample app and not the others?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to extend `AutoCloseable` and `TraceContext` in this way. It's not clear what you're trying to do here, but I don't think it's a good idea to extend `AutoCloseable` and `TraceContext` in this way. It's not clear what you're trying to do here, but I don't think it's a good idea to extend `AutoCloseable` and `TraceContext` in this way. It's not clear what you're trying to do here, but I don't think it's a good idea to extend `AutoCloseable` and `TraceContext` in this way. It's not clear what you're trying to do here, but I don't think it's a good idea to extend `AutoCloseable` and `TraceContext` in this way. It's not clear what you're trying to do here, but I don't think it's a good idea to extend `AutoCloseable` and `TraceContext` in this way. It's not clear what you're trying to do here, but I don't think it's a good idea to extend `AutoCloseable",
+      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to add a `Status` to the `Span` object. I'm not sure what you're trying to do here, but it looks like you're trying to add a `Status` to the `Span` object. I'm not sure what you're trying to do here, but it looks like you're trying to add a `Status` to the `Span` object. I'm not sure what you're trying to do here, but it looks like you're trying to add a `Status` to the `Span` object. I'm not sure what you're trying to do here, but it looks like you're trying to add a `Status` to the `Span` object. I'm not sure what you're trying to do here, but it looks like you're trying to add a `Status` to the `Span` object. I'm not sure what you're trying to do here, but it looks like you're trying to add a `Status` to the `Span` object. I'm not sure what you're trying to do here, but it looks like you're trying to add a `Status` to the `Span` object.",
       "reference": "We don't need this additional method."
     },
     {
@@ -26371,15 +26371,15 @@
       "reference": "Shouldn't this return code conditionally? The above line seems like an error occurred."
     },
     {
-      "prediction": "I think it's better to use `string(apis.TypeDiskCPV)` instead of `string(apis.TypeSparseCPV)`.",
+      "prediction": "I think it's better to use `string(apis.TypeDiskCPV)` and `string(apis.TypeSparseCPV)` instead of `string(apis.TypeDiskCPV)` and `string(apis.TypeSparseCPV)`.",
       "reference": "What is the need to use string as key? Can we use the apis type as the key?"
     },
     {
-      "prediction": "I don't think this is a good idea. The `duration` parameter is not used anywhere in the code. It's just a placeholder for the duration of the message. If you want to use it, you should pass it as a parameter to the `info` function.",
+      "prediction": "I don't think we need to add `duration` to the `info` state.",
       "reference": "how about a default parameter instead?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this logic into the `ClusterInstallRef` struct, so that it can be used by the `ClusterProvisioner` as well.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check here to see if we have a cluster install ref, and if so, skip the creation of the ClusterProvision.",
       "reference": "i don't think we need to add duplicate check for clusterinstallref here, the function already assumes that it was invoked for clusterprovision"
     },
     {
@@ -26387,63 +26387,63 @@
       "reference": "\\`bbox_feats.shape[0] > 0\\` requires the number of proposal is not 0."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this.",
+      "prediction": "I think we should use `metadataTableName` instead of `table.name()` here.",
       "reference": "Same here. Any way to fit on one line?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check to see if the log is a set. If it is, then we should set the single register to the value of the single register.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to make sure we don't write to a log that has already been committed.",
       "reference": "using folly::to is better ?"
     },
     {
-      "prediction": "I think it's better to have a `SiteSpecificQuirks` class, rather than a `ProfileSetter` class.",
+      "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to have it in a separate file.",
       "reference": "I'm guessing this is unintended?"
     },
     {
-      "prediction": "I think we can remove `this.startAtOperationTime` and `maxWireVersion(this.server) >= 7` in this case.",
+      "prediction": "I think we can remove the `maxWireVersion` check here.",
       "reference": "This looks a little suspicious to me, can you explain what's going on here?"
     },
     {
-      "prediction": "I think this should be `if ENV['FORCE_USER_ID']` instead of `if ENV['FORCE_USER_ID'] && session[:user] && session[:user]['email']`",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `User` model, so that we don't have to call `find_or_create_by` every time we want to sign in a user.",
       "reference": "Can you talk about this? I'm not sure I follow why this is necessary."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think this is the right place to do it.",
+      "prediction": "I don't think we need to do this.",
       "reference": "Is there really a need for this 'simple' layout? Is there a reason you can't use 'lightbox'? The only difference seems to be that the lightbox layout includes Piwik/Google Analytics tracking and simple does not. If tracking needs to be disabled for some reason, perhaps there is a way to do that without creating a whole new layout."
     },
     {
-      "prediction": "I think this should be `true` instead of `false`.",
+      "prediction": "Shouldn't this be `true` instead of `false`?",
       "reference": "Can you say what exception will be thrown in that case (or add an `@throws`, below)?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"required\" and \"optional\" in this context. What do you mean by \"version 2.5 or greater\" and \"version 2.7 or greater\"?",
+      "prediction": "I think this should be `if major != 2 or minor < 6:`",
       "reference": "Is this meant to be \"2.7\" or \"2.6\". The two lines in this commit don't agree with one another. Looks like everything else in this PR is \"2.6\" and that seems sensible."
     },
     {
-      "prediction": "I think this should be `from nupic.data.generators.pattern_machine import ConsecutivePatternMachine` instead of `from nupic.data.pattern_machine import ConsecutivePatternMachine`",
+      "prediction": "I think we can remove the `from nupic.data.generators.pattern_machine` import statement.",
       "reference": "Should we put these tests in a `generators` directory?"
     },
     {
-      "prediction": "I think we can remove the `const` from `b1` and `b2` in this case.",
+      "prediction": "I think we can remove the `const` from `b1` and `b2` here.",
       "reference": "I think that it makes more sense to keep these with the standard definition of non-zero is true and zero is false."
     },
     {
-      "prediction": "I think we can remove the `self.authn_type` and `self.effective_principals` from the `DummyRequest` class.",
+      "prediction": "I think this should be `self.authn_type = 'basicauth'` instead of `self.authn_type = 'basicauth'`",
       "reference": "Any idea why you want to change the behavior here? Is there a security risk not to have the prefix in the principal here."
     },
     {
-      "prediction": "`mockDBcache` should be `mockDBcache *MockDirtyBlockCache`",
+      "prediction": "`mockDBcache` should be `mockDBcache *MockDirtyBlockCache` instead of `mockDBcache *MockDirtyBlockCache`",
       "reference": "this reads like \"mock database cache\", maybe a clearer name"
     },
     {
-      "prediction": "`logf` should be `log` instead of `logf`.",
+      "prediction": "`logf` should be `log` or `logr`.",
       "reference": "Nit: move this with the other CM imports."
     },
     {
-      "prediction": "I don't think you need to use `Symfony\\Component\\HttpFoundation\\BinaryFileResponse` in this case. You can use `Symfony\\Component\\HttpFoundation\\StreamedResponse` instead.",
+      "prediction": "I don't think we need to use `Symfony\\Component\\HttpFoundation\\BinaryFileResponse` here. We can use `Symfony\\Component\\HttpFoundation\\StreamedResponse` instead.",
       "reference": "This change should be mentioned in the CM"
     },
     {
-      "prediction": "I think this should be `SpanContext` instead of `ISpanContext`?",
+      "prediction": "I think this should be `SpanContext` instead of `ISpanContext`.",
       "reference": "Do we really want a new type, or can we just use `SpanContext`? The `ISpanContext` interface is read-only, but there's nothing stopping users from casting this to `SpanContext` and modifying it."
     },
     {
@@ -26451,7 +26451,7 @@
       "reference": "Should we define a const like NETFRAMEWORK or NETFULL which will be set for NET452 NET461 and anything like NET47 etc in future?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this, but I think it's a bit of a red herring. It's not clear to me what you're trying to do with `ProvingPeriodBlocks` and `GracePeriodBlocks`. If you can clarify what you're trying to do with these values, I'll be happy to help.",
+      "prediction": "I'm not sure why we need this, but I think we should remove it. It's not used anywhere in the code.",
       "reference": "maybe start an issue to capture params that we need final values for and link to it here?"
     },
     {
@@ -26459,15 +26459,15 @@
       "reference": "Can we instead do the check in find_instance_group_by_url() ? if we return None when group is not found, it will hit the next if statement (if not instance_group) and continue as expected, in this case we don't need to add 3 separate if statements"
     },
     {
-      "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `SafeParse` here.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to move it to the `DateUtil` class. It seems like it could be used in other places as well.",
       "reference": "on my android \".a.m\" and \".p.m\" is used add `||` here to support both variants"
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `VkImageCreateInfo` struct, since it's not part of the `VkImageViewCreateInfo` struct.",
+      "prediction": "I'm not sure if this is the right place to add this check, but I think it's a good idea to add this check to the `VkImageCreateFlags` struct.",
       "reference": "`!FormatIsMultiplane(image_format)` will always be true at this point due to the test on line 4639."
     },
     {
-      "prediction": "`CachedAccessor` is not available in Spark 2.4.0, so we can't use it here.",
+      "prediction": "`CachedAccessor` is not available in Spark 2.4.0.",
       "reference": "Maybe inline the CachedAccessor code? Is it similar to our lazy property? If yes, can we reconcile the two?"
     },
     {
@@ -26479,7 +26479,7 @@
       "reference": "Potential NPE? `hasMedia && selectedItem...`"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. What is the purpose of the `snapshot` and `iops` parameters?",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a `create_volume` method in the `EC2Connection` class.",
       "reference": "PEP-8/consistency with the rest of the code."
     },
     {
@@ -26495,55 +26495,55 @@
       "reference": "So this will only be executed when it is true. I'm not sure that makes it always usable. Why not make the afterAction, `Action` and always call it, with the result as parameter."
     },
     {
-      "prediction": "I'm not sure what you mean by \"resolve_name\" in this context. It's not clear what you're trying to do here.",
+      "prediction": "I don't think we need to do this.",
       "reference": "Tim, please add { } to this 'if'."
     },
     {
-      "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to have a default value for `DefaultPort` and `DefaultHost` so that we don't have to specify them every time we want to run the tests.",
+      "prediction": "I don't think we need to use `DefaultPort` and `DefaultHost` in this case. We can just use `DefaultPort` and `DefaultHost` as default values.",
       "reference": "Suggest moving to `enable.go` since thats only place used."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to test that `agent_facts[0]` is a number, but it's not.",
+      "prediction": "I think we can remove the `match /^\\w+\\./` and `match /^\\d+\\.\\d+\\.\\d+$/` tests.",
       "reference": "This changed when I rebuilt my docker container. Not quite sure why, but might have to do with what my host network configuration looks like when it's rebuilt."
     },
     {
-      "prediction": "I don't think this is necessary.",
+      "prediction": "I don't think this is needed.",
       "reference": "Local cache of what? What's stored in it?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. The `SortOrder.unsorted().orderId()` should be `SortOrder.unsorted().getOrderId()`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this method in the `DataFiles` class, since it's used by other methods in the `DataFiles` class. I'm not sure if this is the right place to do this, but I think it's a good idea to have this method in the `DataFiles` class, since it's used by other methods in the `DataFiles` class. I'm not sure if this is the right place to do this, but I think it's a good idea to have this method in the `DataFiles` class, since it's used by other methods in the `DataFiles` class. I'm not sure if this is the right place to do this, but I think it's a good idea to have this method in the `DataFiles` class, since it's used by other methods in the `DataFiles` class. I'm not sure if this is the right place to do this, but I think it's a good idea to have this method in the `DataFiles` class, since it's used by other methods in the `DataFiles` class. I'm not sure if this is the right place to",
       "reference": "If the copied `DataFile` returns null, shouldn't the copy also return null? Why not make the builder use `Integer` instead of a primitive here?"
     },
     {
-      "prediction": "I'm not sure what you mean by `dir_exists = os.path.isdir(HTML_FILES_PATH)`. I think you meant to say `dir_exists = os.path.isdir(HTML_FILES_PATH)`",
+      "prediction": "I don't think we need to check for the existence of HTML_FILES_PATH.",
       "reference": "You could just do this test in the `save_html` function above, and then the users of the save html function don't have to worry about it."
     },
     {
-      "prediction": "I don't think it's a good idea to use `errors.New` here. I think it's better to use `fmt.Errorf` here.",
+      "prediction": "I don't think this is the right place to do this. I think it should be done in the test suite.",
       "reference": "I think I'd prefer not using the formatted string when it comes to unit test, since we don't pass in any string variable as params."
     },
     {
-      "prediction": "I think this should be `+build !mimxrt1062` instead of `!mimxrt1062`",
+      "prediction": "I think this should be `+build !mimxrt1062` instead of `+build !mimxrt1062,!mimxrt1062`",
       "reference": "Maybe it would be better to explicitly include devices instead of explicitly excluding devices?"
     },
     {
-      "prediction": "I think this is unnecessary. We don't need to call `clearComputedProps` on atoms and bonds. We can just call `clearComputedProps` on `atoms()` and `bonds()`.",
+      "prediction": "I think this should be `for (auto atom: atoms())` instead of `for (ConstAtomIterator atomIt = this->beginAtoms(); atomIt != this->endAtoms(); ++atomIt)`",
       "reference": "This could be `for (auto bond: bonds()){`, right?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"allowConnectingCards\"",
+      "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `LibraryCardsController` class, since it's not related to the `LibraryCards` model.",
       "reference": "Is $config no longer being used? Can we remove this line?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea.",
       "reference": "can you revert changes to this file."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the role already exists in the database. If it doesn't, then we can add the role to the database. If it does, then we need to update the role in the database.",
+      "prediction": "I don't think we need to do this. The `processRole` method is called by `auditLogSeparator` and `auditLogSeparator` is called by `auditLog` which is called by `auditLogSeparator` which is called by `auditLog` which is called by `auditLog` which is called by `auditLog` which is called by `auditLog` which is called by `auditLog` which is called by `auditLog` which is called by `auditLog` which is called by `auditLog` which is called by `auditLog` which is called by `auditLog` which is called by `auditLog` which is called by `auditLog` which is called by `auditLog` which is called by `auditLog` which is called by `auditLog` which is called by `auditLog` which is called by `auditLog` which is called by `auditLog` which is called by `auditLog` which is called by `auditLog` which is called by `auditLog` which is called by `auditLog` which is called by `auditLog` which is called by `auditLog` which is called by `auditLog` which is called by `auditLog` which is",
       "reference": "I don't believe the change is sufficient to correctly handle variable substitutions in the name. As part of the process command we pass the original role object that was retreived without taking into account the substitution. So while the first template apply command will work fine because the original role does not exist thus it's a new add operation, if you try to re-apply the same template again, we'll pick up and process a wrong original name thus we'll try to execute an add operation again instead of modify. So we need to take into account the substituted name when we retrieve the original role as well. Same change should be applied to both policy and service blocks as well."
     },
     {
-      "prediction": "I think this should be `Task.IsMainThread` instead of `Task.IsOnMainThread`",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "Please add this to IMvxMainThreadDispatcher as well"
     },
     {
@@ -26551,19 +26551,19 @@
       "reference": "Is it possible for opt not to be a string? I couldn't tell if this was a typo or if there is actually a case where it is not a string."
     },
     {
-      "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `className` instead of `className=\"googlesitekit-user-input__notification\"`.",
+      "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use the `className` prop here. I think it's a good idea to use the `className` prop here. I think it's a good idea to use the `className` prop here. I think it's a good idea to use the `className` prop here. I think it's a good idea to use the `className` prop here. I think it's a good idea to use the `className` prop here. I think it's a good idea to use the `className` prop here. I think it's a good idea to use the `className` prop here. I think it's a good idea to use the `className` prop here. I think it's a good idea to use the `className` prop here. I think it's a good idea to use the `className` prop here. I think it's a good idea to use the `className` prop here. I think it's a good idea to use the `className` prop here. I think it's a good idea to use the `className` prop here. I think it's a good idea to use the `className` prop here. I",
       "reference": "Let's move this up next to the `id` as we usually have `className` as one of the first props."
     },
     {
-      "prediction": "I'm not sure what you mean by \"data packages\". Is this the same as `data packages `_?",
+      "prediction": "I'm not sure if this is the right place to add the version number, but I think it's a good idea to include it in the `README.md` file.",
       "reference": "While you're in here, \"build, push and install\"?"
     },
     {
-      "prediction": "I think we should remove the `TagKeys` property as it's not used anywhere.",
+      "prediction": "I think we should remove the `TagKeys` property.",
       "reference": "Unit never made it to spec...so removing."
     },
     {
-      "prediction": "I'm not sure if this is the right place to put it, but I think we should put it in the `ServiceLatency` struct, since it's the same as the `NATSLatency` struct. We could also put it in the `NATSLatency` struct, but I don't think that's the right place to put it.",
+      "prediction": "I think we should remove the `Type` and `ID` fields as they are not used.",
       "reference": "We have RequestStart which seems redundant a bit to this one, WDYT?"
     },
     {
@@ -26571,31 +26571,31 @@
       "reference": "I think we can remove this corresponding export from `preact` now! Double check no other s using though lol"
     },
     {
-      "prediction": "I don't think this is necessary. We don't need to create a new table for this. We can just use the existing `item_traits` table.",
+      "prediction": "I don't think this is necessary. We can just use `t.string` instead of `t.text` for the `name` and `value` fields.",
       "reference": "I'm not sure why this would be in here. Were you working off a branch based off of master? These lines were removed in a previous commit because the table is actually called 'cart_item_traits'."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to set the default endpoint to `https://api.github.com`, but you're not actually using it anywhere in the code.",
+      "prediction": "I think it's a good idea to have a default value for `DEFAULT_GITHUB_ENDPOINT` instead of hardcoding it.",
       "reference": "Maybe `DEFAULT_GITHUB_API_ENDPOINT` would be a better name, since we refer to this as an API endpoint elsewhere?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
+      "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `ecs` package.",
       "reference": "If/when you rebase from `dev`, this is going to cause a merge conflict. I'd suggest that soon after merging this PR as the capabilities code has been moved to \"agent/app/agent_capabilities.go\""
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this test, but I don't think it's a good idea to use `assert.Equal` in this case.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use a fake `statsRecorder` here.",
       "reference": "What is the test case here?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to start the flow aggregator in a separate goroutine so that it doesn't block the main goroutine. This way, the main goroutine can continue to do other things while the flow aggregator is running.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to start the flow aggregator before starting the informer factory. This way, the informer factory will be started before the flow aggregator is started, and the flow aggregator will be started before the informer factory is started.",
       "reference": "You could try moving this closer to the call, where we request label info. We might be doing the check very early.. all the resources may not be present with the informer at this point."
     },
     {
-      "prediction": "I'm not sure if this is the right place to put it, but I think it should be in the `ManifestFile` class, not the `Schema` class. The `ManifestFile` class is the base class for all manifest files, and the `Schema` class is the base class for all schema files.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `ManifestFile` class, not in the `Schema` class. The `ManifestFile` class is the base class for all manifest files, and the `Schema` class is the base class for all schema files.",
       "reference": "Can we add these up by the data files counts?"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to do something like this:\n```javascript\nconst resolve = (list, child, node) => {\n  // callbacks won't get queued in the node anyway.\n  // If revealOrder is 'together' then also do an early exit\n  // if all suspended descendants have not yet been resolved.\n-  if (\n-    !list.props.revealOrder ||\n-    (list.props.revealOrder[0] === 't' && list._map.size)\n-  ) {\n+  if (\n+    !list.props.revealOrder ||\n+    (list.props.revealOrder[0] === 't' && list._map.size)\n+  ) {\n    return;\n  }\n}\n```\nI'm not sure I understand what you're trying to do here. I think you're trying to do something like this:\n```javascript\nconst resolve = (list, child, node) => {\n  // callbacks won't get queued in the node anyway.\n  // If revealOrder is 'together' then also do an early exit\n  // if all suspended descendants have not yet been resolved.\n-  if (\n-    !list.props.re",
+      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to do something like this: `resolve(list, child, node) => { ... }` and then `resolve(list, child, node) => { resolve(list, child, node) => { resolve(list, child, node) => { resolve(list, child, node) => { resolve(list, child, node) => { resolve(list, child, node) => { resolve(list, child, node) => { resolve(list, child, node) => { resolve(list, child, node) => { resolve(list, child, node) => { resolve(list, child, node) => { resolve(list, child, node) => { resolve(list, child, node) => { resolve(list, child, node) => { resolve(list, child, node) => { resolve(list, child, node) => { resolve(list, child, node) => { resolve(list, child, node) => { resolve(list, child, node) => { resolve(list, child, node) => { resolve(list, child, node) => { resolve(list, child, node) => { resolve(list, child, node) => { resolve(list, child, node) =>",
       "reference": "Most of the time assigning won't save bytes unless used 3+ times (var adds 3bytes)"
     },
     {
@@ -26603,7 +26603,7 @@
       "reference": "I would rather find the code that inverts the logic and remove that."
     },
     {
-      "prediction": "I think this should be `socket._GLOBAL_DEFAULT_TIMEOUT` instead of `socket._GLOBAL_DEFAULT_TIMEOUT or socket._GLOBAL_DEFAULT_TIMEOUT`",
+      "prediction": "I think this should be `cls._timeout` instead of `cls._timeout == socket._GLOBAL_DEFAULT_TIMEOUT`",
       "reference": "The else doesn't return anything?"
     },
     {
@@ -26615,11 +26615,11 @@
       "reference": "why not simply `paths = search_path_opts.LibrarySearchPaths` ?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `globalize` module, so that it can be used in other places as well.",
+      "prediction": "I don't think this is needed.",
       "reference": "Are we sure this should be translated by the web client? It was unclear in chat exactly what's getting translated here."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to replace the document with a new one, but you're not sure if the new document has a revision or not. Is that correct?",
+      "prediction": "I'm not sure what you mean by \"if the given document has a revision, use it as the precondition (it implies existence)\". I think you meant to say \"if the given document doesn't have a revision, use it as the precondition (it implies existence)\".",
       "reference": "same oneof issue."
     },
     {
@@ -26631,15 +26631,15 @@
       "reference": "it would be better to change `kds` into a `std::vector` then we don't need to explicitly free it"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to send an email using the `send_email` function, but you're not passing in the `image_png` parameter.",
+      "prediction": "I don't think we need to use `configuration.get_config()` here. We can just use `config` directly.",
       "reference": "Looks like you're also changing logic and not only tests."
     },
     {
-      "prediction": "I think we can remove the `expectedIntervalLimit` and just use `actualIntervalLimit` here.",
+      "prediction": "I think we should be using `expectedIntervalLimit / 1_000` instead of `actualIntervalLimit / 1_000`.",
       "reference": "Is it possible that test failures here are real and that we should improve the rate limiting logic? Or are we ok with rate limits to be exceeded by 15%?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check for `MediaProviderInterface::FORMAT_REFERENCE` to make sure we don't try to use the `picture` option when the `srcset` option is also set.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check here to make sure that the `srcset` and `picture` options are not used at the same time.",
       "reference": "Shouldn't there be some kind of validation somewhere? IMO there should be an exception if `$options['lazy']` is not a boolean."
     },
     {
@@ -26647,15 +26647,15 @@
       "reference": "nit: please move it inside namespace."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don",
+      "prediction": "I'm not sure what you're trying to do here. I don't think this is the right way to do it.",
       "reference": "The inventory schema needs to be regenerated to include these options. Looks like the CI job didn't get triggered since the paths don't include `lib/bolt/transport/**`."
     },
     {
-      "prediction": "I'm not sure what you're trying to do with the `ALT+k` and `ALT+d` keys. I think you want to use the `Alt` key to activate the NVDA menu, right?",
+      "prediction": "I'm not sure what you're trying to do with the `alt+d` option. It's not clear to me what it does.",
       "reference": "This might break if a user runs the system tests with a system language other than English, in which the user default language differs."
     },
     {
-      "prediction": "I'm not sure what you mean by \"have_errors\" in this context. I think you meant \"have_errors?\".",
+      "prediction": "I'm not sure what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's not clear to me what you're trying to achieve with this, but it's",
       "reference": "This was raising intermittent errors, since Lorem ipsum contains the word \"error\""
     },
     {
@@ -26667,15 +26667,15 @@
       "reference": "Are the additional brackets necessary?"
     },
     {
-      "prediction": "I'm not sure what you mean by this, but I think it's a good idea to add a check for `consumerIntf` in the `PojoConsumerOperationMeta` constructor.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check here to make sure that the consumer interface is not null. If it is null, then we should throw an exception.",
       "reference": "consumerMeta only belongs to this invoker instance only relate to this one consumerIntf class seems no need to build a complex key?"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do with this test. It's not clear what you're trying to do with this test. It's not clear what you're trying to do with this test. It's not clear what you're trying to do with this test. It's not clear what you're trying to do with this test. It's not clear what you're trying to do with this test. It's not clear what you're trying to do with this test. It's not clear what you're trying to do with this test. It's not clear what you're trying to do with this test. It's not clear what you're trying to do with this test. It's not clear what you're trying to do with this test. It's not clear what you're trying to do with this test. It's not clear what you're trying to do with this test. It's not clear what you're trying to do with this test. It's not clear what you're trying to do with this test. It's not clear what you're trying to do with this test. It's not clear what you're trying to do with this test. It's not clear what you're trying to do with this test. It's",
+      "prediction": "I'm not sure I understand what you're trying to do here. I'm not sure if this is a good idea or not. I'm not sure if this is a good idea or not. I'm not sure if this is a good idea or not. I'm not sure if this is a good idea or not. I'm not sure if this is a good idea or not. I'm not sure if this is a good idea or not. I'm not sure if this is a good idea or not. I'm not sure if this is a good idea or not. I'm not sure if this is a good idea or not. I'm not sure if this is a good idea or not. I'm not sure if this is a good idea or not. I'm not sure if this is a good idea or not. I'm not sure if this is a good idea or not. I'm not sure if this is a good idea or not. I'm not sure if this is a good idea or not. I'm not sure if this is a good idea or not. I'm not sure if this is a good idea or not. I'm not sure if this is a good idea or not. I'm not sure if this is a",
       "reference": "this one is unrelated right? (Don't mind including it, just making sure I understand)"
     },
     {
-      "prediction": "I think it's better to use `lr_config` for `lr` and `warmup` for `warmup` instead of `lr_config` for `lr` and `warmup_ratio` for `warmup_ratio`.",
+      "prediction": "I think we can remove `lr_config` and `optimizer_config` here.",
       "reference": "8, 11 actually achieves similar performance, we should use our default config if [9,11] is unnecessary."
     },
     {
@@ -26683,131 +26683,131 @@
       "reference": "For a separate PR: Can we make this a JSON/Thrift procedure instead? It could accept the amount of time it needs to sleep as an argument."
     },
     {
-      "prediction": "I'm not sure what you mean by \"Causes segfaults, see #1638\"",
+      "prediction": "I think this is a bug, but I don't know how to fix it.",
       "reference": "Please remove this blank line."
     },
     {
-      "prediction": "I don't think we need to use `Thelia\\Core\\Event\\Cart\\CartEvent` here. We can use `Thelia\\Core\\Event\\Order\\OrderEvent` instead.",
+      "prediction": "I don't think we need to use `Thelia\\Core\\Event\\Cart\\CartEvent` here.",
       "reference": "the cartTrait is not used anymore"
     },
     {
-      "prediction": "I don't think this is needed. The `TracerFactory` is already defined in the `OpenTelemetry.Trace.Configuration` namespace, so we don't need to create a new one.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "Cn you please make the message more human friendly."
     },
     {
-      "prediction": "I'm not sure what you mean by this, but I don't think it's a good idea to import `netrc` and `jinja` in the same file.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to have it in `qutebrowser/config.py` instead of `qutebrowser/utils.py`.",
       "reference": "Please do `import enum` instead, then use `enum.Enum` and `enum.unique` - we do this everywhere to see where things are coming from, except for Qt (everything begins with a `Q` anyways) and typing (mostly used in type annotations, so it's clear without the namespacing)."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `uint` in this way. It's not clear what you're trying to do here, but I don't think it's a good idea to use `uint` in this way. It's not clear what you're trying to do here, but I don't think it's a good idea to use `uint` in this way. It's not clear what you're trying to do here, but I don't think it's a good idea to use `uint` in this way. It's not clear what you're trying to do here, but I don't think it's a good idea to use `uint` in this way. It's not clear what you're trying to do here, but I don't think it's a good idea to use `uint` in this way. It's not clear what you're trying to do here, but I don't think it's a good idea to use `uint` in this way. It's not clear what you're trying to do here, but I don't think it's a good idea to use `uint` in this way. It's not clear what you're trying",
+      "prediction": "I'm not sure what you're trying to do here. I don't think we need to change this.",
       "reference": "Isn't ENCFAIL used in codec.c below? Wouldn't this make it no longer compile?"
     },
     {
-      "prediction": "I don't think this is needed anymore.",
+      "prediction": "Shouldn't this be `getTrue()` instead of `getTrue() { return true; }`?",
       "reference": "this looks very weird"
     },
     {
-      "prediction": "I'm not sure if this is the right place to remove this, but I think it's a good idea to remove it.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a separate class, so that we don't have to worry about it being removed in 7.0.0. Also, I think it would be a good idea to remove the `@Deprecated` annotation from this class.",
       "reference": "So, the culprit was actually this class \"ConsoleLogHandler\", correct? Because it simply wrote to stdout..."
     },
     {
-      "prediction": "I don't think we need to call `LogFactory.CreateConfig(_originalFileName);` here. We already have a `LogFactory` in the `NLog.Config` namespace, so we don't need to create a new `LogFactory` here.",
+      "prediction": "I don't think we need to call `LogFactory.CreateConfig(_originalFileName)` here.",
       "reference": "Still curious why you need to modify this method? Why not in the future just have a method called `LogFactory.ReloadConfiguration()` instead of the config assigning itself?"
     },
     {
-      "prediction": "I don't think this is a good idea.",
+      "prediction": "I don't think this is necessary.",
       "reference": "Should this say \"lint, cleanup, destroy, dependency, syntax, create, prepare, converge, idempotence, side_effect, verify, cleanup, destroy\"?"
     },
     {
-      "prediction": "I think this should be `if err := w.WriteMsgWithContext(ctx, headersP2PToPB(headers)); err != nil {`",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to move this to the `p2p` package.",
       "reference": "I am not sure why these log messages are changed."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me what you're trying to do here. It's not clear to me",
+      "prediction": "I'm not sure what you mean by \"non-pointers\" in this context. I think you mean \"non-pointer types\" or \"non-pointer values\".",
       "reference": "This panic is incorrect - this is a full implementation of a slice equality check. This should be something more like `type x is not comparable` maybe?"
     },
     {
-      "prediction": "I think it's better to use `DR_MAX_OPTIONS_LENGTH - 1` instead of `MIN(DR_MAX_OPTIONS_LENGTH - 1, _tcslen(opt))`",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good place to do this.",
       "reference": "See below: let's use the existing convention _tcsnlen."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to make sure that the `approval_step` has a `user_id` and that the `user_id` is unique to the `proposal_id`. Is that what you're trying to do?",
+      "prediction": "I'm not sure what you mean by \"scoped_to\" in this case. I think you meant to say \"scoped_to: :proposal_id\" or \"scoped_to: :user_id\".",
       "reference": "Why don't we need this any more?"
     },
     {
-      "prediction": "`norm_eval=True` should be `norm_eval=False`",
+      "prediction": "I don't think this is a good idea. We should use `pretrained='torchvision://resnet101'` instead of `pretrained='torchvision://resnet101-20200819.pth'`.",
       "reference": "clean unnecessary comma"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that `vnode` is not `null` before calling `options.vnode(vnode)`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `createVNode` function.",
       "reference": "This is the default value for enumerable."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.",
+      "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use RDKit::MOL_SPTR_VECT::const_iterator instead of RDKit::MOL_SPTR_VECT::const_iterator::begin() and RDKit::MOL_SPTR_VECT::const_iterator::end() because RDKit::MOL_SPTR_VECT::const_iterator::begin() and RDKit::MOL_SPTR_VECT::const_iterator::end() are not const iterators.",
       "reference": "Just above, you have `const auto` for a `RDKit::MOL_SPTR_VECT::const_iterator`, here it is only `auto`. Why is this?"
     },
     {
-      "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `std::move` here.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `std::move` here.",
       "reference": "@djarek just a quick question, wouldn't be `ptr.reset()` here better as it does not memory leak if we do not call delete on the raw pointer aswell? it maybe makes sense to use `ptr.release` if the event is guaranteed to be loaded again but on a reload it would memory leak if for example I removed that script from my files before reloading or not?"
     },
     {
-      "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if it's a good place to put it, but I think it's a good place to put it. I'm not sure if it's a good place to put it, but I think it's a good place to put it. I'm not sure if it's a good place to put it, but I think it's a good place to put it. I'm not sure if it's a good place to put it, but I think it's a good place to put it. I'm not sure if it's a good place to put it, but I think it's a good place to put it. I'm not sure if it's a good place to put it, but I think it's a good place to put it. I'm not sure if it's a good place to put it, but I think it's a good place to put it. I'm not sure if it's a good place to put it, but I think it's a good place to put it. I'm not sure if it's a good place to put it, but I think it's a good place",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.",
       "reference": "Why to `Get()` value twice, while u have it 2 lines before"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `System\\Console` namespace, so that it can be used by other modules as well.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add this to the `System\\Console\\ThemeList` command as well.",
       "reference": "There is a typo here, this needs to state `october.fresh`"
     },
     {
-      "prediction": "I'm not sure what you mean by \"Table name must match\".",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a test for this.",
       "reference": "Metadata tables loaded through `HadoopTables` will have their names as location.type (which is weird as we normally use location#type). I am not sure whether it is a big deal or not."
     },
     {
-      "prediction": "I think it's better to use `this.workspace_.scrollY` instead of `this.workspace_.scrollY + delta`.",
+      "prediction": "I think this should be `pos = -this.workspace_.scrollY + delta;` instead of `pos = -this.workspace_.scrollY + delta;`",
       "reference": "Can you explain why you went from a positive value (metrics.viewTop) to a negative value?"
     },
     {
-      "prediction": "I think we should remove the `@Produces(MediaType.APPLICATION_JSON)` from the `getTopicNames` method.",
+      "prediction": "I think this should be `@Produces(MediaType.APPLICATION_JSON)` instead of `@Produces(MediaType.APPLICATION_OCTET_STREAM)`.",
       "reference": "Let's use a dedicated DTO instead of `List` to remain consistent with all other existing REST API endpoints: * Introduce a new DTO class (e. g. `ExternalTaskTopicNameDto`) located under `org.camunda.bpm.engine.rest.dto.externaltask` * The class should have the attribute `topicName` of type `String` * Introduce a getter & setter for the attribute * Convert the list of strings to a list of `ExternalTaskTopicNameDto`s * Change the method signature to return `List`"
     },
     {
-      "prediction": "I think this should be `getScript(String id)` instead of `getScript(List path)`.",
+      "prediction": "I think this method should be called `getScript(String id)` instead of `getScript(List path)`.",
       "reference": "Do you plan to remove the `ScriptDTO getScript(List path);` method long-term?"
     },
     {
-      "prediction": "I think we can remove the `this.enabledTypes` check and just use `this.allTypes` in this case.",
+      "prediction": "I think this should be `return this.allTypes.filter(function(item) { return self.enabledTypes.some(function(enabledItem) { return enabledItem === item.value; }); });`",
       "reference": "@itsiprikshit I used a custom v-model to app count component because the sourceapps component was not reacting to user app count selection, e.g. whenever user changed app count selection, the source apps selection multiplicity remained the same. As a matter of fact, user was able to select one application only. Please let me know if you have any thoughts on this."
     },
     {
-      "prediction": "I don't think this is a good idea. The `ResLayer` and `SimplifedBasicBlock` should be in the `mmdet.models.utils` package.",
+      "prediction": "`auto_fp16` and `force_fp32` should be in the same line.",
       "reference": "Similarly, we think we may keep `fused_semantic_head.py` unchanged. Then, we could add a new mask head for the desired function."
     },
     {
-      "prediction": "I'm not sure what you mean by \"not supported by PHP\". Is it because PHP doesn't have a `getProto()` method? Or is it because PHP doesn't have a `getTypeNameForTypedResourceName()` method?",
+      "prediction": "I think this should be moved to `ModelTypeNameConverter` instead of `PhpModelTypeNameConverter`.",
       "reference": "Why implement this? It duplicates the value in FeatureConfig."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate method for this.",
+      "prediction": "I'm not sure if this is the right way to do this, but I think we should be able to differentiate between a SparkStreamingScan and a SparkMicroBatchStreamScan by looking at the `caseSensitive` field.",
       "reference": "@aokolnychyi / @RussellSpitzer / @holdenk Spark3 gives ScanBuilder - abstraction - to define all types of Scans (Batch, MicroBatch & Continuous). But, the current implementation / class modelling - has SparkBatchScan as the Scan implementation. Looking at some of the concerns of BatchScan - all the way from the State maintenance of a single SnapshotId to read from, the asOfTimeStamp & features like VectorizedReads - all of these don't seem relevant to Streaming Scans. So, I feel that we need to divide out Streaming Scans into a different class. Does this thought process - make sense? If we go by this route - do you folks know - how to pass different Scan objects to Spark based on Batch vs Streaming?"
     },
     {
-      "prediction": "I think it's better to use `if (mappedClaim != null)` instead of `if (mappedClaim != null && !mappedClaim.equals(claim))`.",
+      "prediction": "I think we can remove the `if (mappedClaim != null)` check.",
       "reference": "Will you please update these files to use a copyright end date of 2021?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this, but I think it's a bit of a red herring. The `axe._audit.checks` and `axe._audit.rules` variables are not used anywhere in this file.",
+      "prediction": "I'm not sure what you mean by \"resetting data and relatedNodes in tests\" but I think this is a good idea.",
       "reference": "Adding fixture to the body as we don't have the `runner.tmpl` anymore"
     },
     {
-      "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to have it in the `controller` package, since it's used by both `controller` and `controller-runtime` packages.",
+      "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to have this in the `controller` package, since it's used by both `controller` and `controller-runtime` packages.",
       "reference": "nit: just for consistency we can move this import block down. Right above openshift/hive imports"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this tuple, but I think it's a good idea to make it more explicit about what it's used for. It's not clear from the docstring what it's used for, so I think we should make it more explicit about what it's used for. Also, I think it's a good idea to make it more explicit about what it's not used for, since it's not clear from the docstring what it's not used for, so I think we should make it more explicit about what it's not used for. Also, I think it's a good idea to make it more explicit about what it's not used for, since it's not clear from the docstring what it's not used for, so I think we should make it more explicit about what it's not used for. Also, I think it's a good idea to make it more explicit about what it's not used for, since it's not clear from the docstring what it's not used for, so I think we should make it more explicit about what it's not used for, since it's not clear from the docstring what it's not used for, so I think we should make it more explicit about what",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `msgid` field in the `ManagedMessage` namedtuple.",
       "reference": "Perhaps clean up the commit history and don't squash?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.",
+      "prediction": "I think this should be `if (responseIndex < previouslySentResponseIndex + 1)` instead of `if (responseIndex == previouslySentResponseIndex + 1)`.",
       "reference": "Just `writeBytes(content.array())` Back to my original, somewhat broken version ;)"
     },
     {
@@ -26815,15 +26815,15 @@
       "reference": "I couldn't tell from reading the test - do we every criss-cross transports in the same test? I want to make sure we aren't breaking the chain..."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this code. It looks like you're trying to generate a SHA-256 hash of a string, but I'm not sure what you're trying to achieve with this code. It looks like you're trying to generate a SHA-256 hash of a string, but I'm not sure what you're trying to achieve with this code. It looks like you're trying to generate a SHA-256 hash of a string, but I'm not sure what you're trying to achieve with this code. It looks like you're trying to generate a SHA-256 hash of a string, but I'm not sure what you're trying to achieve with this code. It looks like you're trying to generate a SHA-256 hash of a string, but I'm not sure what you're trying to achieve with this code. It looks like you're trying to generate a SHA-256 hash of a string, but I'm not sure what you're trying to achieve with this code. It looks like you're trying to generate a SHA-256 hash of a string, but I'm not sure what you're trying to achieve with this code. It looks like you",
+      "prediction": "I'm not sure what you're trying to do here. I don't think we need to use `clock` here.",
       "reference": "File is not `goimports`-ed"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in a separate file.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `callStream` method of the `Outbound` struct. I think it's a good idea to have this in the `callStream` method of the `Outbound` struct. I think it's a good idea to have this in the `callStream` method of the `Outbound` struct. I think it's a good idea to have this in the `callStream` method of the `Outbound` struct. I think it's a good idea to have this in the `callStream` method of the `Outbound` struct. I think it's a good idea to have this in the `callStream` method of the `Outbound` struct. I think it's a good idea to have this in the `callStream` method of the `Outbound` struct. I think it's a good idea to have this in the `callStream` method of the `Outbound` struct. I think it's a good idea to have this in the `callStream` method of the `Outbound` struct. I think it's a good idea to have this in the `callStream`",
       "reference": "do we want to still validate that the context had a nonzero TTL? i suppose it's fine to let clients determine whether or not their streams will timeout (though we still don't have the means to cancel them from the server other than EOF), and they can still cancel their own contexts - so maybe not a huge deal, but thought it was worth bringing up."
     },
     {
-      "prediction": "I'm not sure what you mean by \"throw new UnsupportedOperationException()\". It's not an error, it's just a warning.",
+      "prediction": "I don't think this is a good idea. The `humanName` method should be moved to the `NameFormatter` class, and the `classFileNameBase` method should be moved to the `JavaNameFormatter` class.",
       "reference": "Go ahead and provide the same implementation for all of the languages - I'm not sure there's a reason for it to be different."
     },
     {
@@ -26835,7 +26835,7 @@
       "reference": "I'd love to trim the content of `unformatted` too. Any ideas?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this, but I think it's a bit of a mess. It's not clear what you're trying to do with `getfullargspec` and how you're going to use it. It's also not clear what you're trying to do with `typing.get_type_hints` and how you're going to use it. It's not clear what you're trying to do with `typing.get_args` and how you're going to use it. It's not clear what you're trying to do with `typing.get_origin` and how you're going to use it. It's not clear what you're trying to do with `typing.get_args` and how you're going to use it. It's not clear what you're trying to do with `typing.get_args` and how you're going to use it. It's not clear what you're trying to do with `typing.get_args` and how you're going to use it. It's not clear what you're trying to do with `typing.get_args` and how you're going to use it. It's not clear what you're trying to do with `typing.get_args` and how you're going to use it. It's not",
+      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.",
       "reference": "can you remove this unrelated change?"
     },
     {
@@ -26843,23 +26843,23 @@
       "reference": "Would using `HintLabel` here instead (without `setObjectName`) work?"
     },
     {
-      "prediction": "I think this should be `cloudDNS` instead of `cloudFlare` and `cloudDNS` instead of `cloudFlare`.",
+      "prediction": "I think this should be `cloudDNS` instead of `cloudFlare` and `route53` instead of `route53`.",
       "reference": "From what I can tell, the `serviceAccountFile` is never set to anything except \"\"? It'd be best to remove this altogether, so we don't mislead future developers"
     },
     {
-      "prediction": "I don't think this is a good idea. The `nav` element should be inside the `section` element, not inside the `nav` element.",
+      "prediction": "I don't think we need to use `link_to` here. We can just use `a` directly.",
       "reference": "Why do we remove the Sign in link?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a way to move the item to the top or bottom of the queue. This way, the user doesn't have to scroll to the top or bottom of the screen to see the item.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to move this to the `onItemSelected` method of the `FeedItemMenuHandler` class.",
       "reference": "holy crap, were we really missing a 'break' statement here?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to add this, but I think it would be a good idea to add it to the `logMaker` interface. It's not used in the current implementation, but it could be useful in the future.",
+      "prediction": "I don't think we need this anymore. We can just use `makeLoggerForceEnableDebug` instead of `MakeLoggerForceEnableDebug` for now.",
       "reference": "This doesn't seem to be used anywhere, probably doesn't need to be a new interface."
     },
     {
-      "prediction": "I think this should be `total := getNumBlocksFromSize(uint64(limitBytes))` instead of `total := getNumBlocksFromSize(uint64(limitBytes))`",
+      "prediction": "I don't think we need to ignore the error here.",
       "reference": "This is a good start, but what do you think about just using `libkbfs.GetCurrentSessionIfPossible()` to avoid calling this altogether if there's no session? That way we can avoid continuous RTTs to the server when logged out."
     },
     {
@@ -26867,79 +26867,79 @@
       "reference": "This `aria-labelledby` stuff is all new to me, but my reading of the spec is that the value should be a list of element id values, and `dLabel` doesn't seem to be the id of any element?"
     },
     {
-      "prediction": "I think we should remove the `super` here.",
+      "prediction": "I think it's better to use `Set['upload', 'destination', 'targets']` instead of `Set['source', 'destination', 'upload']`.",
       "reference": "Does this fail validation if you now use the `upload` key instead of `source`?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `NULL` for the second argument to `procFuncsArray_`. It's better to use `NULL` for the second argument to `procFuncsArray_` if you don't know the number of elements in the array.",
+      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create an array of `ProcFuncsStruct` objects, but you're passing `NULL` for the second argument. I think you meant to pass `256` for the second argument.",
       "reference": "Can we use GetCliGlobals(false)->exCollHeap() here instead"
     },
     {
-      "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put this, but I think it's a good place",
+      "prediction": "I don't think we need to wait for all the partitions to be elected. We only need to wait for the first one to be elected.",
       "reference": "I suggest you move the waitUntilAllElected into init::KV() method."
     },
     {
-      "prediction": "I think this should be `DefaultMaxBatchSize = 512;` instead of `DefaultMaxBatchSize = 2048;`",
+      "prediction": "I don't think we need to change the default values for `scheduledDelayMilliseconds` and `exporterTimeoutMilliseconds`.",
       "reference": "no need of pub;lic."
     },
     {
-      "prediction": "I'm not sure what you mean by \"use the old buggy Credential.lowestOutput function\"",
+      "prediction": "I'm not sure if this is a good place to put this, but I think it would be good to add a comment here explaining what this is for.",
       "reference": "Do you think we can name this variable in a less ...negative.. language ? maybe `ProposalTieBreakerEqualizer`"
     },
     {
-      "prediction": "I think this should be `List` instead of `List`.",
+      "prediction": "I think this should be `List fields = spec.fields();` instead of `List fields = spec.fields();`",
       "reference": "Can you add back these newlines? We try to avoid non-functional changes like this because they can cause commit conflicts."
     },
     {
-      "prediction": "I don't think this is a good idea.",
+      "prediction": "I don't think we need to do this.",
       "reference": "Why not just `if (!searches.includes(action.search)) searches.push(action.search)`? That way you don't need to remove then add the element."
     },
     {
-      "prediction": "I'm not sure what you mean by \"fake call number prefix\". It's not a real call number prefix, it's just a random string.",
+      "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea to generate a fake call number prefix.",
       "reference": "@demiankatz I'm not sure that this is very useful. I just did it to get started. If we had a small handful of predetermined prefixes that were randomly chosen, it would be easier to distinguish them from the rest of the call number. Would that be preferable?"
     },
     {
-      "prediction": "I think we can remove the `r.WithContext(ctx)` call here.",
+      "prediction": "I think we can remove the `r.WithContext(ctx)` here.",
       "reference": "Why is this deleted too?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this, but I think it's a bad idea to have an internal class that implements `IApiResponse` and `IDisposable`. It's better to have an external class that implements `IApiResponse` and `IDisposable` and then use `using` to dispose of the internal class.",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to remove the `internal` keyword from `IApiResponse` and `IDisposable`.",
       "reference": "Given that IApiResponse is already made disposable, this is not necessary."
     },
     {
-      "prediction": "I'm not sure what you mean by \"High Level Alchemy\" but I think we should remove it.",
+      "prediction": "I'm not sure what you mean by \"High Level Alchemy\" but I think it should be \"High Level Alchemy\" or \"High level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy\" or \"High Level Alchemy",
       "reference": "client.getSelectedSpellName() can be used for this"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do with the `TIMESTAMP_UTC_OFFSET` variable. Is it for something else?",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a consistent name for this file.",
       "reference": "Please alpha sort these filenames."
     },
     {
-      "prediction": "I think we can remove the `if tsf.GasPrice().Sign() < 0` check.",
+      "prediction": "I think it's better to use `errors.Wrapf(err, \"error when validating recipient's address %s\", tsf.Recipient())` instead of `errors.Wrapf(err, \"error when validating recipient's address %s\", tsf.Recipient())`",
       "reference": "is this already called by actPool.validate()?"
     },
     {
-      "prediction": "I think it's better to use `product->getRingInfo()->numBondRings(pBond->getIdx()) > 0` instead of `product->getRingInfo()->isInitialized()`.",
+      "prediction": "I think this should be `if (product->getRingInfo()->numBondRings(pBond->getIdx()) > 0)`",
       "reference": "It is relatively cheap to tell whether a bond is a ring bond, we don't have to perform an SSSR."
     },
     {
-      "prediction": "I think it's better to use `svcTypeFlag` and `appTypeFlag` instead of `svcFlag` and `appTypeFlag`.",
+      "prediction": "`svcTypeFlag` should be `svcType` instead of `svcTypeFlag`.",
       "reference": "Maybe we should add flag aliases for service as well."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to get rid of the `EPoStInfo` field, but I'm not sure what you're trying to do with it. I think you're trying to get rid of the `EPoStInfo` field, but I'm not sure what you're trying to do with it. I think you're trying to get rid of the `EPoStInfo` field, but I'm not sure what you're trying to do with it. I think you're trying to get rid of the `EPoStInfo` field, but I'm not sure what you're trying to do with it. I think you're trying to get rid of the `EPoStInfo` field, but I'm not sure what you're trying to do with it. I think you're trying to get rid of the `EPoStInfo` field, but I'm not sure what you're trying to do with it. I think you're trying to get rid of the `EPoStInfo` field, but I'm not sure what you're trying to do with it. I think you're trying to get rid of the `EPoStInfo` field, but I",
+      "prediction": "I'm not sure what you're trying to say here. I think you're trying to say that `ElectionProof` and `EPoStInfo` are the same thing. I think you're trying to say that `ElectionProof` and `EPOStInfo` are the same thing. I think you're trying to say that `ElectionProof` and `EPoStInfo` are the same thing. I think you're trying to say that `ElectionProof` and `EPoStInfo` are the same thing. I think you're trying to say that `ElectionProof` and `EPoStInfo` are the same thing. I think you're trying to say that `ElectionProof` and `EPoStInfo` are the same thing. I think you're trying to say that `ElectionProof` and `EPoStInfo` are the same thing. I think you're trying to say that `ElectionProof` and `EPoStInfo` are the same thing. I think you're trying to say that `ElectionProof` and `EPoStInfo` are the same thing. I think you're trying to say that `ElectionProof` and `EPoStInfo",
       "reference": "This LGTM but don't we need a winning PoSts field to fully implement the protocol? No need to add here as I'm working on this in another PR, but curious how we can interop with lotus blocks without post proofs."
     },
     {
-      "prediction": "I don't think this is necessary. We can just use a channel to store the pending blocks and cancel channel to end the handler thread.",
+      "prediction": "I think we can remove the `chan *block.Block` from the `pubSub` struct.",
       "reference": "can you move the [] into pubSub? so Blockchain just contains a pubSub, not []"
     },
     {
-      "prediction": "I think this should be `memoryCircuitBreakerThresholdPct` instead of `memoryCircuitBreakerThreshold`?",
+      "prediction": "I think this should be `memoryCircuitBreakerThresholdPct` instead of `memoryCircuitBreakerThresholdPercent`.",
       "reference": "I don't think 100 is a safe default here, since later we check that the value is between 50-95."
     },
     {
-      "prediction": "I think it's better to use `ThreadAgnostic` instead of `ThreadSafe` in this case.",
+      "prediction": "I think it's better to use `ThreadAgnostic = 2` instead of `ThreadAgnostic = 2 | ThreadSafe`.",
       "reference": "I would be nice if we could describe this without the word \"agnostic\""
     },
     {
@@ -26947,7 +26947,7 @@
       "reference": "Pick more specific exception types for these cases. Not sure what would be best for this one (`ValueError`?) but the next one could be `IndexError`."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to `jest.config.js` as well.",
+      "prediction": "I think this should be `/.stories/?(*.)test.js` instead of `/.storybook/?(*.)test.js`",
       "reference": "This seemed like the easiest solution We need to include this path in `testMatch` to run the test AFAIK *BUT* we don't want this test ran when running them all normally I'm sure there are other ways to do this!"
     },
     {
@@ -26955,15 +26955,15 @@
       "reference": "Most of the following test changes can be avoided if need be."
     },
     {
-      "prediction": "I think it's a good idea to have a separate timer for writing the MLD data, so that we can track how long it takes to write the MLD data.",
+      "prediction": "I think it's a good idea to have a separate timer for writing the MLD data, so that we can see how much time it took to write the MLD data to disk.",
       "reference": "Eventually we might want to move this back as generating this data structure takes some time (for large datasets) and we don't want it in the hot-path of `osrm-customize` runs. Thinking long-term making `osrm-customize` eventually digest `.osrm.cells` will will enable only updating cells selectively and using an earlier customization for the rest."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a separate function.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the dialog and nat service are stopped before killing the server.",
       "reference": "You're not really using named result variable - you can just leave `error`."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to build a sort order based on the partition spec and the sort order spec. Is this what you're trying to do? If so, what is the purpose of the `Multimap sortFieldIndex = Multimaps.index(sortOrder.fields(), SortField::sourceId);` line? What is the purpose of the `Multimap sortFieldIndex = Multimaps.index(sortOrder.fields(), SortField::sourceId);` line? What is the purpose of the `Multimap sortFieldIndex = Multimaps.index(sortOrder.fields(), SortField::sourceId);` line? What is the purpose of the `Multimap sortFieldIndex = Multimaps.index(sortOrder.fields(), SortField::sourceId);` line? What is the purpose of the `Multimap sortFieldIndex = Multimaps.index(sortOrder.fields(), SortField::sourceId);` line? What is the purpose of the `Multimap sortFieldIndex = Multimaps.index(sortOrder.fields(), SortField::sourceId);` line",
+      "prediction": "I'm not sure what you're trying to do here, but I think it's a bad idea to use `Multimaps.index` to build a sort prefix. It's not a good idea to use `Multimaps.index` to build a sort prefix. It's not a good idea to use `Multimaps.index` to build a sort prefix. It's not a good idea to use `Multimaps.index` to build a sort prefix. It's not a good idea to use `Multimaps.index` to build a sort prefix. It's not a good idea to use `Multimaps.index` to build a sort prefix. It's not a good idea to use `Multimaps.index` to build a sort prefix. It's not a good idea to use `Multimaps.index` to build a sort prefix. It's not a good idea to use `Multimaps.index` to build a sort prefix. It's not a good idea to use `Multimaps.index` to build a sort prefix. It's not a good idea to use `Multimaps.index` to build a sort prefix. It's not a good idea to use `Multimaps.index` to build a sort prefix. It's",
       "reference": "It wasn't possible to call this method with `PartitionSpec.unpartitioned()` as the schema in the spec was empty."
     },
     {
@@ -26979,11 +26979,11 @@
       "reference": "Why did we make this a static string?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but it seems to work for now.",
+      "prediction": "I think this should be `item['datasetReference']['datasetId']` instead of `item['datasetReference']['datasetId']['datasetId']`",
       "reference": "Please re-run PYTHONPATH=. python tests/services/inventory/update_cai_dumps.py following the instructions at the top of this file to ensure the test files have the correct CAI asset type."
     },
     {
-      "prediction": "I'm not sure what you mean by `hash.ZeroHash256` in this context. It's not the same as `hash.ZeroHash32` or `hash.ZeroHash64` or `hash.ZeroHash128` or `hash.ZeroHash192` or `hash.ZeroHash256` or `hash.ZeroHash384` or `hash.ZeroHash512` or `hash.ZeroHash1024` or `hash.ZeroHash2048` or `hash.ZeroHash3072` or `hash.ZeroHash4096` or `hash.ZeroHash5120` or `hash.ZeroHash6144` or `hash.ZeroHash7680` or `hash.ZeroHash8192` or `hash.ZeroHash9616` or `hash.ZeroHash10240` or `hash.ZeroHash10241` or `hash.ZeroHash10242` or `hash.ZeroHash10243` or `hash.ZeroHash10244` or `hash.ZeroHash10245` or `hash.ZeroHash10246` or `hash",
+      "prediction": "I'm not sure if this is a good idea, but I don't think we need to use `hash.ZeroHash256` here.",
       "reference": "`stateDB := NewStateDBAdapter(sm, 0, hash.ZeroHash256, NotFixTopicCopyBugOption())`"
     },
     {
@@ -26991,11 +26991,11 @@
       "reference": "There are unneeded parens here, but I'll fix it up when merging."
     },
     {
-      "prediction": "I think this should be `include H2O::ACL` instead of `include H2O::ACL`",
+      "prediction": "I'm not sure if this is necessary, but I think it's better to have a separate `require` and `include` statement for each library, rather than having them all in the same line.",
       "reference": "Just one more thing... How about doing all of the following? 1. renaming h2o.rb to bootstrap.rb 2. require and include the acl code _from_ bootstrap.rb"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to move this into the `cron_entry_run_task` function, so that we don't have to call it every time we want to run a task.",
+      "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to kill a cron task that has been running for a certain amount of time. I'm not sure if this is what you're trying to do, or if you're trying to kill a cron task that has been running for a certain amount of time, or if you're trying to run a cron task that has been running for a certain amount of time. I'm not sure what you're trying to do here, but it looks like you're trying to kill a cron task that has been running for a certain amount of time. I'm not sure if this is what you're trying to do, or if you're trying to kill a cron task that has been running for a certain amount of time, or if you're trying to run a cron task that has been running for a certain amount of time. I'm not sure what you're trying to do here, but it looks like you're trying to kill a cron task that has been running for a certain amount of time. I'm not sure if this is what you're trying to do, or if you're trying to kill a cron task that has been running for a certain amount of time, or if",
       "reference": "Commit message: \"remove\" is misspelled."
     },
     {
@@ -27003,31 +27003,31 @@
       "reference": "This is a pretty idiosyncratic method - I'd move it into the JSON-RPC package rather than adding it to `BytesValue`."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. The `configure_group` method should be called on the `RSpec::Core::Context` object, not on the `RSpec::Core::Context::Group` object.",
+      "prediction": "I think this should be `config` instead of `RSpec.configuration`?",
       "reference": "Is there a way to deduplicate this somehow? Could we roll it into `RSpec.configuration` with a bit of memoization or is there a chicken and egg problem."
     },
     {
-      "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to add a comment here explaining what this property is for.",
+      "prediction": "I don't think we need to change this.",
       "reference": "Generally, I wouldn't say I like the idea of providing properties that return negative/inverted values. It would be more convenient to return whether the update is **in** progress or not."
     },
     {
-      "prediction": "I think we can remove the `options.player` argument from the `runtimeTicks` calculation.",
+      "prediction": "I think this should be `const timeRemainingTicks = runtimeTicks - playbackManager.currentTime(options.player) * 10000;`",
       "reference": "Converting playbackManager to operate in ms (preferred solution, imo) would allow us to completely drop this function."
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear what the purpose of `max_edge_returned_per_vertex` is. I think it should be `max_edges_returned_per_vertex` instead.",
+      "prediction": "I don't think we need to change the default value of `max_edge_returned_per_vertex` to 1000.",
       "reference": "The default value should be a bigger one, I'd like it is the maximum of int32. That means we will not cut-off anything by default. And users would config it with an appropriate value in config-file, such as 1000 or 5000, etc."
     },
     {
-      "prediction": "I think this should be `errChan := make(chan error, 1)` instead of `errChan := make(chan error, 1000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
+      "prediction": "I think this should be `c.config.GetStringByFlag(config.FlagHermesID)` instead of `c.config.GetStringByFlag(config.FlagHermesID)`",
       "reference": "Probably missing return here as well"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this field, but I think we should remove it.",
+      "prediction": "I'm not sure what you mean by \"with a non-zero value\". Is that a typo?",
       "reference": "On second thought... this affects how often the function specified by the `load` property is run. So I wonder if, for consistency, we should call this `LoadInterval` instead. Does that make sense?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this, but it looks like you're trying to use the `countlyCommon` module, but you're not importing it. You should be able to import it like this: `var countlyCommon = require('countlyCommon');`",
+      "prediction": "I don't think we need to do this. We can just use `countlyCommon` directly.",
       "reference": "Now you don't need the localization module here then :)"
     },
     {
@@ -27035,27 +27035,27 @@
       "reference": "This should not convert each value to a literal on every invocation. Instead, this PR can add a `literals` method to `BoundSetPredicate` to access the values as literals. That way, the conversion happens once and can be lazy."
     },
     {
-      "prediction": "I think this should be `if len(lib_path) == 0:` instead of `if len(lib_path) == 0:`",
+      "prediction": "I think this should be `return lib.LGBM_GetLastError()` instead of `lib.LGBM_GetLastError()`.",
       "reference": "I think we still need this exception if doesn't have LIGHTGBM_BUILD_DOC"
     },
     {
-      "prediction": "I think it's better to use `log.Logf` in this case. It's more concise and easier to read.",
+      "prediction": "I think we can remove the `if len(certificate.Status.Conditions) > 0` check.",
       "reference": "Does this make it easier to read? Previously this would have run `kubectl describe certificate` right? In which case it would have included events related to the cert. Will we miss that? Would the old `kubectl describe` output have gone to stderr?"
     },
     {
-      "prediction": "I think we should remove `@SerializedName(value = SERIALIZED_CAMUNDA_INTEGRATION)` from `Internals` class.",
+      "prediction": "I think we should remove the `@SerializedName` annotation for `SERIALIZED_CAMUNDA_INTEGRATION` and `SERIALIZED_APPLICATION_SERVER`.",
       "reference": "Just an understanding question: do we need a map here, would a list/set of Strings be sufficient? we are not adding entries with `false` here, are we? Being in the list already means it's used, right?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in `CentralPlannerScheduler` instead of in `CentralPlanner`.",
+      "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to prune tasks that are no longer needed, and then remove them from the state. Is this what you're trying to do?",
       "reference": "Ah, so the change is that you want the `prune()` side effect before doing the `task.id not in necessary_tasks` membership check? Stupid non-Haskell programming languages :p"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don",
+      "prediction": "I'm not sure if this is a good idea, but I think we should add a test for this.",
       "reference": "This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards."
     },
     {
-      "prediction": "I'm not sure what you mean by \"collation\" in this context. It's not clear to me what you're trying to do here.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `findAndModify` function.",
       "reference": "Do we normally force ReadPreference primary on other write operations? Or is it just that we normally ignore it?"
     },
     {
@@ -27063,7 +27063,7 @@
       "reference": "Instead of returning null here and discarding nulls automatically, I think this should return null (or some other signaling value) and fix the part that consumes the output of the visitor."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the validator provider is null. If it is, we should throw an exception.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the validator provider is null. If it is, then we should just return an empty list.",
       "reference": "Really, we want to be setting the validatorsForPreviousBlock against the yet to be created block, so it might make sense to update the cache once the block is created/imported instead."
     },
     {
@@ -27071,23 +27071,23 @@
       "reference": "It seems to me that the original implementation was correct. Can you share what the scanner was pointing out?"
     },
     {
-      "prediction": "I'm not sure if this is the best place to put it, but I think it would be better to put it in `googlesitekit-bulk-edit.js` instead of `googlesitekit-subscribe-with-google-bulk-edit.js`.",
+      "prediction": "I'm not sure if this is the best place to put it, but I think it would be good to have it in the `googlesitekit-bulk-edit.js` file as well.",
       "reference": "Instead of doing that, please create an `assets/js/googlesitekit-subscribe-with-google-bulk-edit.js` file as entry point - all our entry points should be located in `assets/js`."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to add a new widget to the dashboard. I'm not sure what you're trying to do here, but it looks like you're trying to add a new widget to the dashboard. I'm not sure what you're trying to do here, but it looks like you're trying to add a new widget to the dashboard. I'm not sure what you're trying to do here, but it looks like you're trying to add a new widget to the dashboard. I'm not sure what you're trying to do here, but it looks like you're trying to add a new widget to the dashboard. I'm not sure what you're trying to do here, but it looks like you're trying to add a new widget to the dashboard. I'm not sure what you're trying to do here, but it looks like you're trying to add a new widget to the dashboard. I'm not sure what you're trying to do here, but it looks like you're trying to add a new widget to the dashboard. I'm not sure what you're trying to do here, but it looks like you're trying to add a new widget to the dashboard. I'm not sure",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to move it to the `Dashboard` component.",
       "reference": "This is not valid, a `div` shouldn't be in a `span`. You could apply the `className` attribute to the `span` tag."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to set the value of `fs.Config.TransferredExpireDuration` and `fs.Config.TransferredExpireInterval` to something other than the default value of `fs.Config.RcJobExpireDuration` and `fs.Config.RcJobExpireInterval`.",
+      "prediction": "I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure",
       "reference": "Would it be possible to reuse RcJobExpireDuration and RcJobExpireInterval and auto delete them when job is deleted?"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here, but I think it's a bad idea to use `raise_conflicts=False` in this case. I think it's a good idea to use `raise_conflicts=True` in this case.",
+      "prediction": "I'm not sure what you mean by \"raise_conflicts=False\" in the context of this code. I think you meant to say \"raise_conflicts=True\" or \"raise_conflicts=False\" depending on what you meant.",
       "reference": "Python wants **future** imports to come first."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in `dynamodetach.c` instead of `dynamodetach.h`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `detach_on_permanent_stack` function as well. I think it would be a good idea to do this in the `detach_on_permanent_stack` function as well. I think it would be a good idea to do this in the `detach_on_permanent_stack` function as well. I think it would be a good idea to do this in the `detach_on_permanent_stack` function as well. I think it would be a good idea to do this in the `detach_on_permanent_stack` function as well. I think it would be a good idea to do this in the `detach_on_permanent_stack` function as well. I think it would be a good idea to do this in the `detach_on_permanent_stack` function as well. I think it would be a good idea to do this in the `detach_on_permanent_stack` function as well. I think it would be a good idea to do this in the `detach_on_permanent_stack` function as well. I think it would be a good idea to do this in the `detach_on",
       "reference": "Better to call this before EXITING_DR which is supposed to be last."
     },
     {
@@ -27095,27 +27095,27 @@
       "reference": "Does this work at runtime?"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to have a default value for `maxRetriesOnRecoverableFailures` so that we don't have to specify it every time we create a new session.",
+      "prediction": "I don't think we need to change the default value for maxRetriesOnRecoverableFailures.",
       "reference": "Hmm why do we need to make this change? Like which one requires this change?"
     },
     {
-      "prediction": "I don't think we need to use `require(\"whatwg-fetch\")` here. We can just use `fetch` directly.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "why remove this and other piece?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this test, but I'm not sure how to make it work.",
+      "prediction": "I'm not sure what you mean by \"ignoreAria=true\" in this case. I think it should be `ignoreAria: false` instead.",
       "reference": "Yikes... That was probably me."
     },
     {
-      "prediction": "I don't think we need to use `this` in this case.",
+      "prediction": "I'm not sure what you mean by \"note attachments...\". Is this the same as the \"Notes\" menu item?",
       "reference": "It would be better to move the ... outside of the l8n block. This way it won't need to be translated for each language twice."
     },
     {
-      "prediction": "I don't think you need to include `databasetasks.h` and `events.h` in this file.",
+      "prediction": "I don't think you need to include `databasetasks.h` and `globalevent.h` in this file.",
       "reference": "That's a huge load of new dependencies. I think it's better to create a reload function on ScriptManager and control with enum instead."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to add a new job to the list of available jobs, but you're also trying to add a new command to the list of available commands. Is this what you're trying to do?",
+      "prediction": "I'm not sure if this is a good idea, but I think it's better to have a separate package for this.",
       "reference": "`NewUpgradeTaskJob` -> `NewUpgradeResource`"
     },
     {
@@ -27123,19 +27123,19 @@
       "reference": "Is that the memory usage of the system or the process / awesome?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"currently only the \"change\" or \"schema\" events supported\". I think you meant \"currently only the \"change\" event supported\".",
+      "prediction": "I think it's better to use `schemaChange` and `schema` instead of `change` and `schema`.",
       "reference": "\"change\" *and* \"schema\" events (A bunch of these; not marking them all)."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. The `overrideSequenceNumberForNewDataFiles(long sequenceNumber)` method is not used anywhere in the code. It's only used to override the sequence number of the new manifest of the data files added in this update, which is not related to the `validateFromSnapshot(long snapshotId)` method.",
+      "prediction": "I think this should be `overrideSequenceNumberForNewDataFiles(long sequenceNumber)` instead of `overrideSequenceNumberForNewDataFiles(long snapshotId)`.",
       "reference": "I think there is probably a shorter, more descriptive name for this. Something like `commitAtSequenceNumber`?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to do here, but I'm not sure what you're trying to",
+      "prediction": "I'm not sure what you're trying to do here, but I think we should remove the `allow_nil: false` from `url_name`.",
       "reference": "The `url_name` should definitely be more than just 1 character long at the shortest. How about 3 or 4 characters?"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a page indexer that will index pages used by the Index Queue. Is this what you're trying to achieve? If so, please let me know and I'll be happy to help you further.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the TypoScriptFrontendController.",
       "reference": "Please revert this change"
     },
     {
@@ -27143,67 +27143,67 @@
       "reference": "Nice. I hadn't even heard of presenters in Rails before (learn something new every day) :)"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this. It looks like you're trying to create a pool of securities that can be used to download securities. However, I'm not sure what you're trying to do with this. It looks like you're trying to create a pool of securities that can be used to download securities, but I'm not sure what you're trying to do with this. It looks like you're trying to create a pool of securities that can be used to download securities, but I'm not sure what you're trying to do with this. It looks like you're trying to create a pool of securities that can be used to download securities, but I'm not sure what you're trying to do with this. It looks like you're trying to create a pool of securities that can be used to download securities, but I'm not sure what you're trying to do with this. It looks like you're trying to create a pool of securities that can be used to download securities, but I'm not sure what you're trying to do with this. It looks like you're trying to create a pool of securities that can be used to download securities, but I'm not sure what you're trying to do with this. It looks like you",
+      "prediction": "I don't think this is needed.",
       "reference": "`string[]` ? not sure, can you verify this @core23 ? Thank you"
     },
     {
-      "prediction": "I don't think we need to use `clearTimeout` here. We can just use `playPauseClickTimeout = setTimeout(...);` and `clearTimeout(playPauseClickTimeout);`",
+      "prediction": "I don't think we need to call `releaseCurrentPlayer()` here.",
       "reference": "are we aware that this breaks older browsers like WebOS? :) they don't handle `let`"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to update the TTL value in the object, but I'm not sure what you're trying to do here. I think you're trying to update the TTL value in the object, but I'm not sure what you're trying to do here. I think you're trying to update the TTL value in the object, but I'm not sure what you're trying to do here. I think you're trying to update the TTL value in the object, but I'm not sure what you're trying to do here. I think you're trying to update the TTL value in the object, but I'm not sure what you're trying to do here. I think you're trying to update the TTL value in the object, but I'm not sure what you're trying to do here. I think you're trying to update the TTL value in the object, but I'm not sure what you're trying to do here. I think you're trying to update the TTL value in the object, but I'm not sure what you're trying to do here. I think you're trying to update the TTL value in the object, but I'm not sure what you're trying to do here",
+      "prediction": "I'm not sure I understand what you're trying to do here. Is it that you want to update the TTL value in the object? If that's the case, why not just use `self.set(key, value, ttl=ttl)`?",
       "reference": "This isn't really a Kinto record but a Memcached record. I could kind of go either way on this."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `OAuthWebviewHelper` class as well.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `OAuthWebviewHelper` class, since it will be called by the `OAuthWebview` class as well.",
       "reference": "Kick off the download after login."
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here. I'm not sure if it's a good idea to use `preg_replace_callback` here.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `preg_replace_callback` here.",
       "reference": "I don't think you need to change this, `array` should be accepted whenever `string[]` is expected. (`string[]` is an alias of `array` itself an alias of `array` which is a parent type of `array`"
     },
     {
-      "prediction": "I'm not sure what you mean by `seat->pointer_state.grab_serial` and `seat->touch_state.grab_serial`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the `wlr_seat_client` struct.",
       "reference": "TODO: fix this, probably in another PR"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason you want to start hinting?",
+      "prediction": "I think this should be `if tab is None or tab.tab_id != self._tab_id:`",
       "reference": "Is there any case that tab is None?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `append` here. I think you want to use `append` on `t` here.",
+      "prediction": "I don't think we need to use `append` in this case. We can just use `append` here.",
       "reference": "pls use `err` instead of `e`"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's better to use `addEventListener` instead of `attachGamepadScript` in this case.",
+      "prediction": "I'm not sure why we need to check for `navigator.getGamepads` at all.",
       "reference": "`attachGamepadScript` above can also be placed inside."
     },
     {
-      "prediction": "Shouldn't this be `util.GetAddress` instead of `util.TrimHexPrefix`?",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for signing.",
       "reference": "when we use RegisterWriteCommand,this func should be exported,so we can use this to get signer at the outside action package"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this, but I think it's a bit of a red herring. It's not clear what you're trying to do with this, but I think it's a bit of a red herring. It's not clear what you're trying to do with this, but I think it's a bit of a red herring. It's not clear what you're trying to do with this, but I think it's a bit of a red herring. It's not clear what you're trying to do with this, but I think it's a bit of a red herring. It's not clear what you're trying to do with this, but I think it's a bit of a red herring. It's not clear what you're trying to do with this, but I think it's a bit of a red herring. It's not clear what you're trying to do with this, but I think it's a bit of a red herring. It's not clear what you're trying to do with this, but I think it's a bit of a red herring. It's not clear what you're trying to do with this, but I think it's a bit of a",
+      "prediction": "I'm not sure what you're trying to do with this, but it looks like you're trying to add a new middleware to the `management.middlewares` slice. I'm not sure what you're trying to do with this, but it looks like you're trying to add a new middleware to the `management.middlewares` slice. I'm not sure what you're trying to do with this, but it looks like you're trying to add a new middleware to the `management.middlewares` slice. I'm not sure what you're trying to do with this, but it looks like you're trying to add a new middleware to the `management.middlewares` slice. I'm not sure what you're trying to do with this, but it looks like you're trying to add a new middleware to the `management.middlewares` slice. I'm not sure what you're trying to do with this, but it looks like you're trying to add a new middleware to the `management.middlewares` slice. I'm not sure what you're trying to do with this, but it looks like you're trying to add a new middleware to the `management.middlewares` slice. I'm not sure what you're trying to do with this, but it looks like you",
       "reference": "Dead code - we should remove it or use `log.Trace` for lower logging level. Same applies for change at line 138."
     },
     {
-      "prediction": "I think this should be `boost::optional parseParameters(std::string::iterator &iter, std::string::iterator &end, std::string::iterator &failure);`",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to check for `boost::numeric::bad_numeric_cast` in the `parseParameters` function. It's not clear to me if this is the right place to do this, but I think it would be a good idea to check for `boost::numeric::bad_numeric_cast` in the `parseParameters` function. It's not clear to me if this is the right place to do this, but I think it would be a good idea to check for `boost::numeric::bad_numeric_cast` in the `parseParameters` function. It's not clear to me if this is the right place to do this, but I think it would be a good idea to check for `boost::numeric::bad_numeric_cast` in the `parseParameters` function. It's not clear to me if this is the right place to do this, but I think it would be a good idea to check for `boost::numeric::bad_numeric_cast` in the `parseParameters` function. It's not clear to me if this is the right place to do this, but I think it would be a good idea to check for `boost::numeric::",
       "reference": "How does this make sure invalid coordinates making the parser fail? Relying on the Coordinate type's boost numeric_cast calls in the ctor? Shouldn't we rely on a coordinate's `.IsValid()` member function instead?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"folder within a bucket in Amazon Simple Storage Solution (Amazon S3)\". Is it referring to a folder within a bucket in Amazon Simple Storage Service (Amazon S3)?",
+      "prediction": "I'm not sure what you mean by \"folder\". Is it a folder in the S3 bucket? Or is it a folder in the S3 object? If it's a folder in the S3 bucket, then you need to specify the path to the folder. If it's a folder in the S3 object, then you don't need to specify the path to the folder.",
       "reference": "Simple Storage **Service**"
     },
     {
-      "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to make sure that the cache is enabled before we try to use it. This way, if the cache is disabled, we don't try to use it, and if the cache is enabled, we don't try to use it if it's disabled.",
+      "prediction": "I'm not sure why this is needed, but I think we should remove it.",
       "reference": "Does this line (and the corresponding one in the test bootstrap) actually do anything? I don't see where CACHE_ENABLED is used as a global constant."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have the `DependentStatus` and `SatisfiedStatus` be the same as the `DependencyName` and `DependencyKnown` respectively. This way, we don't have to worry about whether the `DependencyName` and `DependencyKnown` are the same as the `DependencyName` and `DependencyKnown` respectively.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this.",
       "reference": "has this changed? are we testing \"all possible situations\" now?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"no default\"",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to add a `--help` option to the CLI. This will allow the user to see what options are available and how to use them.",
       "reference": "ZK is properly spelled 'ZooKeeper' (capital 'K')."
     },
     {
@@ -27211,71 +27211,71 @@
       "reference": "Guessing this locates the key you get when you run `gcloud auth application-default login`? What was the previous behavior/the behavior for the manual Veneer creds?"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to do something like this:\n\n```\nif (selected[0] < 0 || this.countRows() >= this.getSettings().maxRows || columnSelected) {\n  return false;\n}\n```\n\nBut I'm not sure what you're trying to do here. I think you're trying to do something like this:\n\n```\nif (selected[0] < 0 || this.countRows() >= this.getSettings().maxRows || columnSelected) {\n  return false;\n}\n```\n\nBut I'm not sure what you're trying to do here. I think you're trying to do something like this:\n\n```\nif (selected[0] < 0 || this.countRows() >= this.getSettings().maxRows || columnSelected) {\n  return false;\n}\n```\n\nBut I'm not sure what you're trying to do here. I think you're trying to do something like this:\n\n```\nif (selected[0] < 0 || this.countRows() >= this.getSettings().maxRows || columnSelected) {\n  return false;\n}\n```\n\nBut I'm not sure what you're trying to do here. I think you're trying to",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check for `columnSelected` here, so that we don't try to select more than one column at a time.",
       "reference": "looks good to me, but it would be better if you assigned `this.countRows()` into a variable, so it doesn't trigger twice in the return statement"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a new class, but you're not using the `new` keyword. You should be using the `new` keyword to create a new instance of the class, like this: `new ClassSpec(b)`.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "For now, don't add \"use strict\" to any existing files. That's a separate project that we'll do later. (New files can use \"use strict\".)"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `os.Setenv` to set the environment variable, and `os.Unsetenv` to unset the environment variable. This way, we don't have to use `os.Setenv` and `os.Unsetenv` twice.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `os.Setenv` to set the environment variable, and then use `os.Getenv` to get it back.",
       "reference": "I was confused by this env name variable, assuming it was the value, not the name. Silly nit, but maybe name it noninteractiveEnv?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I think we should remove the `posix='win' not in sys.platform` check.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `posix='win' not in sys.platform'` in this case.",
       "reference": "`sys.platform` could be equal to `darwin` which is posix. Use `not startswith('win')`?"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. The `NewOverrideLookup` function is used to create an `OverrideLookup` object, which is then passed to the `New` function to create a new `svc` object. Is this what you're trying to do here?",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `NewOverrideLookup` function that takes a `config.Overrides` object and returns an `OverrideLookup` object.",
       "reference": "let's move this into `slack_helper.go`"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to set the `ControlPath` option for the `ssh_connection_options` of the `azure` driver. I'm not sure what you're trying to do here, but it looks like you're trying to set the `ControlPath` option for the `ssh_connection_options` of the `azure` driver. I'm not sure what you're trying to do here, but it looks like you're trying to set the `ControlPath` option for the `ssh_connection_options` of the `azure` driver. I'm not sure what you're trying to do here, but it looks like you're trying to set the `ControlPath` option for the `ssh_connection_options` of the `azure` driver. I'm not sure what you're trying to do here, but it looks like you're trying to set the `ControlPath` option for the `ssh_connection_options` of the `azure` driver. I'm not sure what you're trying to do here, but it looks like you're trying to set the `ControlPath` option for the `ssh_connection_options` of the `azure` driver. I'm not sure what you're trying to do",
+      "prediction": "I think this should be `ssh_connection_options` instead of `ssh_connection_options: ...`",
       "reference": "I doubt it will work, but without space between -o and ControlPath it should. Lets see. What I do not understand is why we did not see a failure on CI related to this?"
     },
     {
-      "prediction": "I think this should be `if (shifted_bearing < 0.)` instead of `if (shifted_bearing > 360.)`",
+      "prediction": "I think this should be `if (shifted_bearing >= 360.)` instead of `if (shifted_bearing > 360.)`",
       "reference": "this is the reason we might be seeing 360 as discrete bearing"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to use the `astroid` package to generate a version string from the `astroid` version number and the Python version number. Is this what you're trying to do? If so, I'm not sure I understand what you're trying to do here, but it looks like you're trying to use the `astroid` package to generate a version string from the `astroid` version number and the Python version number. Is this what you're trying to do? If so, I'm not sure I understand what you're trying to do here, but it looks like you're trying to use the `astroid` package to generate a version string from the `astroid` version number and the Python version number. Is this what you're trying to do? If so, I'm not sure I understand what you're trying to do here, but it looks like you're trying to use the `astroid` package to generate a version string from the `astroid` version number and the Python version number. Is this what you're trying to do? If so, I'm not sure I understand what you're trying to do here, but it",
+      "prediction": "I'm not sure I understand what you're trying to do here. The `astroid_version` variable is just a placeholder for the version of `astroid` being used, and it's not used anywhere else in the code. Is there something else you'd like to do with this variable?",
       "reference": "`FULL_VERSION` is available at module level for others to use, but it won't have `%(prog)s` substituted with pylint. Will that be a problem. Also put it here instead of __pkginfo__ with other versions because it isn't pkginfo related."
     },
     {
-      "prediction": "I don't think this is necessary. The `rowPosition` field is only used to track the position of the current row in the iterator, so it's not necessary to store it in the `BaseColumnIterator` class. It can be stored in the `ColumnDescriptor` class instead.",
+      "prediction": "I don't think this is necessary. The `rowPosition` field is only used to track the position of the current row in the iterator, so it doesn't need to be stored in the `BaseColumnIterator` class.",
       "reference": "Is this needed? I don't see any uses."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to use the `Delete` method on the `EventsV1alpha1` resource.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a separate function.",
       "reference": "Shouldn't this be V1beta1?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a method in the `Approval` model.",
       "reference": "I think there's an `approval_for`"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with `transform` here. It's not clear what you're trying to do with `transform` here. It's not clear what you're trying to do with `transform` here. It's not clear what you're trying to do with `transform` here. It's not clear what you're trying to do with `transform` here. It's not clear what you're trying to do with `transform` here. It's not clear what you're trying to do with `transform` here. It's not clear what you're trying to do with `transform` here. It's not clear what you're trying to do with `transform` here. It's not clear what you're trying to do with `transform` here. It's not clear what you're trying to do with `transform` here. It's not clear what you're trying to do with `transform` here. It's not clear what you're trying to do with `transform` here. It's not clear what you're trying to do with `transform` here. It's not clear what you're trying to do with `transform` here. It's not clear what you're trying to do with `transform` here.",
+      "prediction": "I don't think this is necessary. The `takeWhile` method is already defined in the `LinearSeq` interface, so we don't need to define it again.",
       "reference": "Here we should use List in generic"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to get rid of the `javaCompile.getToolChain().getVersion()` call, but I'm not sure what you're trying to do with the `javaCompile.getToolChain().getVersion()` call. I'm not sure what you're trying to do here. I think you're trying to get rid of the `javaCompile.getToolChain().getVersion()` call, but I'm not sure what you're trying to do with the `javaCompile.getToolChain().getVersion()` call. I'm not sure what you're trying to do here. I think you're trying to get rid of the `javaCompile.getToolChain().getVersion()` call, but I'm not sure what you're trying to do with the `javaCompile.getToolChain().getVersion()` call. I'm not sure what you're trying to do here. I think you're trying to get rid of the `javaCompile.getToolChain().getVersion()` call, but I'm not sure what you're trying to do with the `javaCompile.getToolChain().getVersion()` call. I'm not sure what you're trying to do here. I think you're trying to get rid",
+      "prediction": "I'm not sure what you're trying to say here. I think you're trying to say that this is a no-op for `javaCompile.getToolChain().getVersion()` in `BaselineReleaseCompatibility` and `javaCompile.getToolChain().getVersion()` in `BaselineReleaseCompatibility` and `javaCompile.getToolChain().getVersion()` in `BaselineReleaseCompatibility` and `javaCompile.getToolChain().getVersion()` in `BaselineReleaseCompatibility` and `javaCompile.getToolChain().getVersion()` in `BaselineReleaseCompatibility` and `javaCompile.getToolChain().getVersion()` in `BaselineReleaseCompatibility` and `javaCompile.getToolChain().getVersion()` in `BaselineReleaseCompatibility` and `javaCompile.getToolChain().getVersion()` in `BaselineReleaseCompatibility` and `javaCompile.getToolChain().getVersion()` in `BaselineReleaseCompatibility` and `javaCompile.getToolChain().getVersion()` in `BaselineReleaseCompatibility` and `javaCompile.getToolChain().getVersion()` in `BaselineReleaseCompatibility` and `javaCompile.getToolChain().getVersion()` in `BaselineReleaseCompatibility` and `javaCompile.getToolChain().getVersion()` in `BaselineReleaseCompatibility` and `javaCompile.getToolChain().getVersion",
       "reference": "The `JavaCompile#getToolChain` method got removed and I am not sure what a good replacement is. I replaced it with `targetCompat` for now but they are not equivalent. Maybe we can use `JavaVersion#current` here?"
     },
     {
-      "prediction": "I don't think this is necessary. The `fileExists` method is already defined in the `MultimediaId` class, so we don't need to add it to the `MultimediaQueryInterface` interface.",
+      "prediction": "I don't think we need this interface. We already have the `fileExists` method in `MultimediaId`.",
       "reference": "The method name is incorrect. It does not check the existence of the file. I'd suggest deprecating both methods `fileExists` and `findIdByHash` and use findIdByFilename instead of fileExits"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to set `nat_lvl1_drop` to 1, but I'm not sure what you're trying to do here. I think you're trying to set `nat_lvl1_drop` to 1, but I'm not sure what you're trying to do here. I think you're trying to set `nat_lvl1_drop` to 1, but I'm not sure what you're trying to do here. I think you're trying to set `nat_lvl1_drop` to 1, but I'm not sure what you're trying to do here. I think you're trying to set `nat_lvl1_drop` to 1, but I'm not sure what you're trying to do here. I think you're trying to set `nat_lvl1_drop` to 1, but I'm not sure what you're trying to do here. I think you're trying to set `nat_lvl1_drop` to 1, but I'm not sure what you're trying to do here. I think you're trying to set `nat_lvl1_drop` to 1, but I'm not sure what you're trying to do here. I think you're",
+      "prediction": "I'm not sure what you're trying to do here. I don't think we need to do this.",
       "reference": "We have `stdbool` imported, might as well use that for clarity."
     },
     {
-      "prediction": "I don't think this is necessary.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "File is empty, consider removing?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"execute the operations\" in this context. I think you meant to say \"execute the operations in the batch\" or \"execute the operations within the batch\".",
+      "prediction": "I'm not sure what you mean by \"execute the operations\"",
       "reference": "`writeConcernMax` was changed to return a `writeConcern` formatted the new way-- `writeConcern: {w:1, ...}`. Bulk execute takes an actual `WriteConcern` object as its first parameter (this was changed in master), so we have to un-wrap the `writeConcernMax` result here."
     },
     {
@@ -27283,19 +27283,19 @@
       "reference": "How about passing this through the `config`?"
     },
     {
-      "prediction": "I'm not sure why we're skipping this test, but I think we should at least run it for now.",
+      "prediction": "I'm not sure why we're skipping this test, but I think we should at least run it locally to make sure it's working.",
       "reference": "Out of curiosity - did we make this change to allow dynamically assigning a value to `os.environ[\"TEST_TARGET\"]` during test execution? I kind of liked the decorator style `@only_localstack` - makes the condition a bit more explicit. Looks like `skipif` also allows to specify a condition string, e.g. `pytest.mark.skipif('os.environ.get(\"TEST_TARGET\") == \"AWS_CLOUD\"')` - could that be an option? (not sure if that gets lazily evaluated at runtime right before the execution of the annotated test method starts, though..)"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the `domainId` and `name` are always set.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "I noticed (SonarCloud noticed actually) that the implementation of `::edit` method is the same as `__construct` is. Does it make sense to call the `edit` method from the constructor?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"Enable trace log to see the message.\" Could you please clarify?",
+      "prediction": "I don't think we need to do this.",
       "reference": "would you please rename the message prefix to: [in_syslog] ...\""
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. If you want to generate SMARTS, you can use the `generateSMARTS` method. If you want to generate SMARTS and query the MOL, you can use the `generateSMARTSAndQueryMol` method.",
+      "prediction": "I don't think this is a good idea. We should be able to generate SMARTS directly from the result MCS.",
       "reference": "The pointer to a pointer is kind of gross. How about either taking the `ROMOL_SPTR` directly or, preferably, returning an `std::pair`?"
     },
     {
@@ -27307,19 +27307,19 @@
       "reference": "line is 175 characters"
     },
     {
-      "prediction": "I'm not sure what you mean by \"reactActivityDelegate.loadReactAppOnceIfReady(getMainComponentName());\"",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to make sure that `client` is not null before calling `loadReactAppOnceIfReady`.",
       "reference": "@ivanbogdanov Does this fix the first time load gray screen issue that @wmathurin noticed?"
     },
     {
-      "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to remove this warning. I think it's a good idea to remove this warning. I think it's a good idea to remove this warning. I think it's a good idea to remove this warning. I think it's a good idea to remove this warning. I think it's a good idea to remove this warning. I think it's a good idea to remove this warning. I think it's a good idea to remove this warning. I think it's a good idea to remove this warning. I think it's a good idea to remove this warning. I think it's a good idea to remove this warning. I think it's a good idea to remove this warning. I think it's a good idea to remove this warning. I think it's a good idea to remove this warning. I think it's a good idea to remove this warning. I think it's a good idea to remove this warning. I think it's a good idea to remove this warning. I think it's a good idea to remove this warning. I think it's a good idea to remove this warning. I think it's a good idea to remove this warning. I think",
+      "prediction": "I'm not sure if this is a good idea or not, but I think it would be good to remove this warning. It's not a big deal, but I think it would be good to remove this warning.",
       "reference": "Is `2.3.0` version OK?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"switching by name not yet supported by safari\". I'm not sure what you mean by \"switching by name not yet supported by safari\". I'm not sure what you mean by \"switching by name not yet supported by safari\". I'm not sure what you mean by \"switching by name not yet supported by safari\". I'm not sure what you mean by \"switching by name not yet supported by safari\". I'm not sure what you mean by \"switching by name not yet supported by safari\". I'm not sure what you mean by \"switching by name not yet supported by safari\". I'm not sure what you mean by \"switching by name not yet supported by safari\". I'm not sure what you mean by \"switching by name not yet supported by safari\". I'm not sure what you mean by \"switching by name not yet supported by safari\". I'm not sure what you mean by \"switching by name not yet supported by safari\". I'm not sure what you mean by \"switching by name not yet supported by safari\". I'm not sure what you mean by \"switching by name not yet supported by safari\". I'm not sure what you mean by \"",
+      "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's possible to switch to a parent frame without switching to a parent window.",
       "reference": "I tested it only in Firefox (`./go //rb:firefox-test`)"
     },
     {
-      "prediction": "I don't think this is a good idea. It would be better to have a separate test client for each test case.",
+      "prediction": "I don't think we need to do this. We can just use `http.DefaultServeMux` instead of creating a new `http.Handler` for each request.",
       "reference": "separate third party and builtin"
     },
     {
@@ -27331,7 +27331,7 @@
       "reference": "isn't this going to return a timeout error if the context is canceled?"
     },
     {
-      "prediction": "I don't think this is necessary.",
+      "prediction": "I don't think we need to do this.",
       "reference": "`argNameVal.length` will still be !=2, so line 22 will give true and then continue on line 24"
     },
     {
@@ -27339,27 +27339,27 @@
       "reference": "It was `$chars[$i]` I believe."
     },
     {
-      "prediction": "I think this should be `val.to_s` instead of `val.to_s.upcase`?",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `Unix::Exec` module, since it's used by other modules as well.",
       "reference": "This has the likely potential to break existing tests that are relying on the old beaker behavior. If we are going to release this in beaker 3.x, then we need to preserve the old behavior as well (so set both the `upcase` and original values). On Windows, they env variables will overwrite each other, with the same value, so not an issue. On *nix, there will be two env variables, but they will have the same value, so again no issue."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `scope === 'local' || false` in this case.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `createVariable` method.",
       "reference": "Thanks for fixing this! I probably didn't test the playground when making changes here for cloud variables."
     },
     {
-      "prediction": "I think this should be `this.selectedIds = selectedIds;` instead of `this.selectedIds = selectedIds;`",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check here to make sure that `selectedIds` is not null, and if it is null, throw an exception.",
       "reference": "I will also check if `nameMapping` needs a precondition null check."
     },
     {
-      "prediction": "I'm not sure what you mean by \"mkdirs\" in this context. Is it possible that you meant to say \"create\" instead of \"mkdirs\"?",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to move this into the `Files` class.",
       "reference": "Since RuntimeIOException is deprecated and you are touching this code, why not replace it?"
     },
     {
-      "prediction": "I think this test should be moved to a separate test suite.",
+      "prediction": "I think this test should be moved to a separate test case.",
       "reference": "You should also have a test that calls it with tm_cpp and make sure it returns the correct JSON file."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but it seems to work.",
+      "prediction": "I don't think we need to do this.",
       "reference": "One more minor change, the string `ForAdditionalLiveTvOptions` is probably also unused."
     },
     {
@@ -27371,11 +27371,11 @@
       "reference": "Perhaps you want to check if UIAHandler.handler is not None. The current check will break NVDA if you call UIAHandler.terminate() for some reason."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bad idea to have a `replace-partitions` property in the `BaseReplacePartitions` class. It's not clear to me what you're trying to achieve with this property.",
+      "prediction": "I'm not sure what you're trying to do here. I think you're trying to set the `replace-partitions` property to `true` in the `replace-partitions` section of the configuration file, but I'm not sure how you're doing that. I'm not sure what you're trying to do here. I think you're trying to set the `replace-partitions` property to `true` in the `replace-partitions` section of the configuration file, but I'm not sure how you're doing that. I'm not sure what you're trying to do here. I think you're trying to set the `replace-partitions` property to `true` in the `replace-partitions` section of the configuration file, but I'm not sure how you're doing that. I'm not sure what you're trying to do here. I think you're trying to set the `replace-partitions` property to `true` in the `replace-partitions` section of the configuration file, but I'm not sure how you're doing that. I'm not sure what you're trying to do here. I think you're trying to set the `replace-partitions` property to `true` in the `replace-partitions` section of the",
       "reference": "can we make `replace-partitions` property a static variable in `SnaphotSummary.java`?"
     },
     {
-      "prediction": "I think this should be `Selenium::WebDriver::Remote::W3CBridge` instead of `Selenium::WebDriver::Firefox::W3CBridge`.",
+      "prediction": "I think it's better to use `Selenium::WebDriver::Remote::W3CBridge` instead of `Selenium::WebDriver::Firefox::W3CBridge` and `Selenium::WebDriver::Edge::W3CBridge` because `Selenium::WebDriver::Firefox::W3CBridge` and `Selenium::WebDriver::Edge::W3CBridge` are deprecated.",
       "reference": "Maybe call it `WireBridge`?"
     },
     {
@@ -27383,7 +27383,7 @@
       "reference": "Should really be `one()`, not `one_or_none()`"
     },
     {
-      "prediction": "I think we can remove the `if !util.IsControlPlaneMachine(machine.GetMachine())` check.",
+      "prediction": "I think it's better to use `labels` instead of `node-labels` here.",
       "reference": "Should we use strings.Split and strings.Join instead of manual concatenation?"
     },
     {
@@ -27391,7 +27391,7 @@
       "reference": "rough that this needs to exist, but it is what it is"
     },
     {
-      "prediction": "I'm not sure why this is failing, but I'm not sure how to fix it. I think it might be a bug in the test, but I'm not sure how to fix it.",
+      "prediction": "I'm not sure why this test is failing, but I'm not sure how to fix it.",
       "reference": "FYI, I pulled your branch and hacked a little on your test case. This passes for me (you may want to tweak further): 
     it('should not set empty string for null props in custom elements', () => { customElements.define('x-bar', class extends HTMLElement { val; }); // @ts-ignore render(<x-bar val={null} />, scratch); expect(scratch.childNodes).to.have.length(1); expect(scratch.firstChild).to.have.property('nodeName', 'X-BAR'); expect(scratch.firstChild.attributes.length).to.equal(0); expect(scratch.firstChild.val).to.equal(null); }); 
    "
     },
     {
@@ -27399,51 +27399,51 @@
       "reference": "It is the maximum value that the configured emulator can support."
     },
     {
-      "prediction": "I think this should be `session_manager = objreg.get('session-manager')` instead of `session_manager = objreg.get('session-manager').exists('_autosave')`",
+      "prediction": "I think it's better to use `objreg.get('session-manager')` instead of `objreg.get('session-manager').exists('_autosave')`",
       "reference": "Here, I've been giving priority to the session saved by the user. This means, that if the user quits with `:wq`, then restarts `qutebrowser`, and then `qutebrowser` crashes for some reason, next time `qutebrowser` is restarted, the session saved lastly with `wq` will be restored, and not the one autosaved. What do you think?"
     },
     {
-      "prediction": "I'm not sure what you mean by `balanceRound` and `seedRound` being the same thing. I'm not sure what you mean by `balanceRound` and `seedRound` being the same thing. I'm not sure what you mean by `balanceRound` and `seedRound` being the same thing. I'm not sure what you mean by `balanceRound` and `seedRound` being the same thing. I'm not sure what you mean by `balanceRound` and `seedRound` being the same thing. I'm not sure what you mean by `balanceRound` and `seedRound` being the same thing. I'm not sure what you mean by `balanceRound` and `seedRound` being the same thing. I'm not sure what you mean by `balanceRound` and `seedRound` being the same thing. I'm not sure what you mean by `balanceRound` and `seedRound` being the same thing. I'm not sure what you mean by `balanceRound` and `seedRound` being the same thing. I'm not sure what you mean by `balanceRound` and `seedRound` being the same thing. I'm not sure what you mean by `balanceRound` and `",
+      "prediction": "I'm not sure what you mean by `balanceRound` and `seedRound` in this context. I'm not sure what you mean by `balanceRound` and `seedRound` in this context. I'm not sure what you mean by `balanceRound` and `seedRound` in this context. I'm not sure what you mean by `balanceRound` and `seedRound` in this context. I'm not sure what you mean by `balanceRound` and `seedRound` in this context. I'm not sure what you mean by `balanceRound` and `seedRound` in this context. I'm not sure what you mean by `balanceRound` and `seedRound` in this context. I'm not sure what you mean by `balanceRound` and `seedRound` in this context. I'm not sure what you mean by `balanceRound` and `seedRound` in this context. I'm not sure what you mean by `balanceRound` and `seedRound` in this context. I'm not sure what you mean by `balanceRound` and `seedRound` in this context. I'm not sure what you mean by `balanceRound` and `seedRound` in this context. I'm not sure",
       "reference": "this line got me confused for few seconds, as the `AccountData` is both the name of the data structure as well as the function name. I think that `GetAccountData` is a better choice for a name. ( note that the same applies for the previous `BalanceRecord` function name )"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `block_for_at_least_entries` function.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that `mock_consumer->cv().wait(lck, [this, amount] { return mock_consumer->ConsumedEntriesSize_nts() >= amount; });` is called before `mock_consumer->wait_for_at_least_entries(amount);`.",
       "reference": "I think this mutex is only used here. Remove it."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `NewMutableState` function.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `NewMutableState` function, since it will be called by the `NewState` function as well.",
       "reference": "so this is now init to 1?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea. The `WHERE` clause in the `version` condition is redundant, and it's not clear what you're trying to do with it. It's possible that the `version` condition is being used for some other purpose, but I don't have enough context to know what that is.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be better to do this in the `ZoneDatabase::LoadSpawnGroups` function.",
       "reference": "For future note; not prefixing the table in a join can throw an error in the query parser depending on how the query is built I am making an assumption this was tested"
     },
     {
-      "prediction": "I think this should be `fakeClusterUUID` instead of `fe953108-f64c-4166-bb8e-20da7665ba00`",
+      "prediction": "I think we should use `fakeClusterUUID` instead of `fakeClusterMetadata` here.",
       "reference": "Had to bring this up, will abandon this style of testing based on Joel's work soon."
     },
     {
-      "prediction": "I think we should use `log.warn` instead of `logOk` here.",
+      "prediction": "I think it's better to use `log.warn` instead of `logOk` in this case.",
       "reference": "What does our source validation complain about here? Many of the logok/nowarn places look fine to me at a glance but I'm no match for the logging policeman ;-)"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `byteCountCommandTemplate` as a template for the `bytecount` command. This way, we don't have to worry about the exact format of the command.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `byteCount` command in the `stats` package. This way, we don't have to create a separate `bytecount` command in the `stats` package, and we don't have to create a separate `bytecount` command in the `management` package.",
       "reference": "It feels like this dependency should not be here. Some deep internal openvpn package (middleware) knows about one of possible stats consumers. Maybe as an alternative, statistics and state callbacks can be extracted as separate interfaces in top openvpn package and reused by both sides"
     },
     {
-      "prediction": "I think this should be `newTopBlock := topBlock.DeepCopy()` instead of `newTopBlock, err := topBlock.DeepCopy(codec)`",
+      "prediction": "I think this should be `newTopBlock := topBlock.DeepCopy(codec)` instead of `newTopBlock, err := topBlock.DeepCopy(codec)`",
       "reference": "Can you please remove `codec` from the parameters too? I think it's unused now."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. You're creating a new `TypeSolver` instance, but you're not using it anywhere.",
+      "prediction": "I'm not sure what you're trying to do here. I don't think this is the right way to do it.",
       "reference": "mocks needed this change so that it returns the \"right\" thing"
     },
     {
-      "prediction": "I don't think we need to provide `MenuEntrySwapperConfig` here. We can just use `MenuEntrySwapperPlugin`'s `getMenuEntrySwapperConfig()` method.",
+      "prediction": "I don't think we need to provide `MenuEntrySwapperConfig` here. We already have `MenuEntrySwapperConfig` in the `MenuEntrySwapper` class.",
       "reference": "I don't think the getters for this are needed, but looks good other than that"
     },
     {
-      "prediction": "I think we should remove the `data-wistia-id` attribute from the `video-summary` tag.",
+      "prediction": "I think it's better to use `wistia_id` instead of `clip.wistia_id`",
       "reference": ":+1: to inlining this."
     },
     {
@@ -27455,11 +27455,11 @@
       "reference": "I can't recall if there was a fix specific to this in the past?"
     },
     {
-      "prediction": "I think we should remove the `secret` field from the spec, as it is not used to create or delete the subscription, only to poll it.",
+      "prediction": "I think we should remove the `secret` field from `PubSubSourceSpec` as it is not used to create or delete the Subscription, only to poll it. The `secret` field is only used to create or delete the Subscription, not to poll it.",
       "reference": "Not sure what the todo is here? Is it to support some kind of defaulting based off of that?"
     },
     {
-      "prediction": "I think this should be `bool?` instead of `bool`?",
+      "prediction": "I don't think this is needed. The `FlushOnConditionOnly` property is only used to determine if the flush should be done on a condition. If the flush is done on a condition, then the flush should be done on the condition. If the flush is done on a condition, then the flush should be done on the condition. If the flush is done on a condition, then the flush should be done on the condition. If the flush is done on a condition, then the flush should be done on the condition. If the flush is done on a condition, then the flush should be done on the condition. If the flush is done on a condition, then the flush should be done on the condition. If the flush is done on a condition, then the flush should be done on the condition. If the flush is done on a condition, then the flush should be done on the condition. If the flush is done on a condition, then the flush should be done on the condition. If the flush is done on a condition, then the flush should be done on the condition. If the flush is done on a condition, then the flush should be done on the condition. If the flush is done on a condition, then the flush should be done on",
       "reference": "Not sure about this name. I think \"explicit\" is also a bit difficult here (I think it should be implicit then) Proposal: FlushOnEvents. Or, It would be cool if we could split into 2 options, FlushOnShutdown and FlushOnReload, but I expect that's far more difficult to implement?"
     },
     {
@@ -27471,43 +27471,43 @@
       "reference": "We should not include this path."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do with this test. It seems like you're trying to mock the `__init__` method of the `slack_webhook.SlackWebhook` class, but you're not actually doing anything with the `__init__` method. I'm not sure what you're trying to achieve with this test, but it doesn't seem to be working as expected.",
+      "prediction": "I'm not sure I understand what you're trying to do with this test. It seems like you're trying to mock the `__init__` method of the `slack_webhook.SlackWebhook` class, but you're not actually doing anything with the `__init__` method. You're just testing that the `__init__` method is being called and that it returns `None`. Is this what you're trying to test?",
       "reference": "Add newline at end of file"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `onUpgrade` method of the `PodDBAdapter` class.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `onUpgrade` method of the `PodDBAdapter` class.",
       "reference": "This should be done when updating to the next release (2.5). You currently only perform the upgrade when users go from 1.4 to 1.5, so it will lead to crashes for existing users."
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think we should use the `ClusterName` annotation in the pull secret name. This way we don't have to hardcode the `ClusterName` in the pull secret name. We could also use the `ClusterName` in the pull secret name if we don't want to hardcode the `ClusterName` in the pull secret name. But I'm not sure if this is a good idea.",
+      "prediction": "I don't think we need to add this annotation to the pull secret name. We can just use the cluster name in the pull secret name.",
       "reference": "suggest hive.openshift.io/cluster-machine-management or something to make it more obvious what it is."
     },
     {
-      "prediction": "I'm not sure what you mean by \"InitializePlugins\" in this context. It's not clear to me what you're trying to do with this step.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it would make sense to move it to the `InitializePlugins` step, since it's not part of the `InitializeNetwork` step.",
       "reference": "We explicitly don't want to do that. This was a complaint from users before."
     },
     {
-      "prediction": "I don't think this is necessary. The `getExclude` and `getExcludeCode` methods are already defined in `Thelia\\Type\\TypeCollection`.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "Hello, The PHPDoc is `string[]` not `int[]`"
     },
     {
-      "prediction": "I don't think we need to mock the `TcApplyError` here.",
+      "prediction": "I don't think we need to mock the `TcApplyError` here. We can just return an error directly.",
       "reference": "Same issues with parameters order in `ipset_server.go`"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to set a default value for the `SystemNamespaceRetentionDays` field. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set a default value for the `SystemNamespaceRetentionDays` field. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set a default value for the `SystemNamespaceRetentionDays` field. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set a default value for the `SystemNamespaceRetentionDays` field. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set a default value for the `SystemNamespaceRetentionDays` field. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set a default value for the `SystemNamespaceRetentionDays` field. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set a default value for the `SystemNamespaceRetentionDays` field. I'm not sure what you're trying to achieve with",
+      "prediction": "I don't think we need to change this.",
       "reference": "Wow, did it literally mean the retention days is a huge number?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check for `flatbuffers::PosixPath` and `flatbuffers::PosixPath::c_str()` to make sure that `argv[argi]` is a `flatbuffers::PosixPath` and not a `flatbuffers::PosixPath::c_str()`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a `--bfbs-filenames` option to the command line.",
       "reference": "you probably didn't intend to touch those files in `scripts/`"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do with `nproc=4` here.",
+      "prediction": "I don't think we need to use `nproc=4` here. We can just use `nproc=1` for now.",
       "reference": "Similar to `collate_fn`, we may rename it to `tpfp_fn`."
     },
     {
-      "prediction": "I'm not sure what you mean by `this.wot.wtTable.holderOffset.top`. Is this the `top` property of `this.wot.wtTable.holderOffset`?",
+      "prediction": "I'm not sure what you mean by this, but I think it should be `this.wot.wtTable.holderOffset` instead of `this.wot.wtTable.holderOffset.top`.",
       "reference": "Awesome! We may also use negative rule `never` to fix new lines after `return`: `{ blankLine: \"never\", prev: \"return\", next: \"*\" }`"
     },
     {
@@ -27515,59 +27515,59 @@
       "reference": "Why can't this be a function on the `Config` interface like all the others?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `onCreateOptionsMenu` method, so that we don't have to do this in the `onCreateView` method.",
+      "prediction": "I don't think you need to do this. The `MenuItemUtils.setupSearchItem` method is called by the `onCreateOptionsMenu` method, which is called by the `FeedMenuHandler.onCreateOptionsMenu` method, which is called by the `FeedItemlistFragment.onCreateView` method, which is called by the `FeedItemlistFragment.onCreateView` method, which is called by the `FeedItemlistFragment.onCreateView` method, which is called by the `FeedItemlistFragment.onCreateView` method, which is called by the `FeedItemlistFragment.onCreateView` method, which is called by the `FeedItemlistFragment.onCreateView` method, which is called by the `FeedItemlistFragment.onCreateView` method, which is called by the `FeedItemlistFragment.onCreateView` method, which is called by the `FeedItemlistFragment.onCreateView` method, which is called by the `FeedItemlistFragment.onCreateView` method, which is called by the `FeedItemlistFragment.onCreateView` method, which is called by the `FeedItemlistFragment.onCreateView` method, which is called by the `FeedItemlistFragment.onCreateView` method, which is called by the `FeedItemlistFragment.onCreateView` method, which is",
       "reference": "If the feed is null, the menu items should still be setup. Just the feed title can be left out. That prevents possible flickering when menu items are displayed/hidden for some feeds."
     },
     {
-      "prediction": "I think we can remove the `allowIncompatibleChanges()` call here.",
+      "prediction": "I think this should be `if (add.isNullable()) { pendingUpdate.allowIncompatibleChanges().addRequiredColumn(parentName(add.fieldNames()), leafName(add.fieldNames()), type, add.comment()); } else { pendingUpdate.allowIncompatibleChanges().addRequiredColumn(parentName(add.fieldNames()), leafName(add.fieldNames()), type, add.comment()); }`",
       "reference": "I'm not sure that this should call `allowIncompatibleChanges()` because adding a required column when there are no existing values will break reading the new column in any table with data in it. The only time it is safe to add a required column is if there is no data in the table. What about throwing an exception here instead? I agree that the column should not be optional if NOT NULL was specified. Another alternative is to check whether the table has data and allow the incompatible change if it doesn't have any rows."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this widget to the `System\\ReportWidgets\\Status` class.",
       "reference": "Early translation , should be logic-less"
     },
     {
-      "prediction": "I think this should be `nullInterceptor` instead of `null`",
+      "prediction": "I think this should be `null` instead of `nullInterceptor`",
       "reference": "I don't understand why these functions return a request/response, respectively. In all implementations we actually _modify_ the request/response given as a parameter. Do you envisage situations where we'd want to construct completely fresh request/response objects? Even if we do, it's not something needed atm, so I'd favour in keeping the API minimal. Also, the fact that these functions _may_ mutate the request/response should be noted."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate route for the `projects/:id/stacks` route.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the `compares#projects_graph` route as well.",
       "reference": "Wasn't there a subsequent reason why we had to keep the `/p/project_graph` route? Outside references or is the proposed solution to the original proposal we us `/p/g` as the `compares#project_graph` route?"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to have a test like this. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to have a test like this. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to have a test like this. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to have a test like this. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to have a test like this. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to have a test like this. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to have a test like this. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to have a test like this.",
+      "prediction": "I'm not sure what you're trying to do with this test, but I don't think it makes sense.",
       "reference": "Any suggestions on how I would even _approach_ writing tests for arbitrary values...."
     },
     {
-      "prediction": "I don't think we need to use the `active` and `edit` keys. We can just use `active` and `edit` directly.",
+      "prediction": "I don't think we need this. We can just use the `active` and `edit` keys in the `Theme` class.",
       "reference": "Scope declarations for class constants was not added until 7.1, this will not be accepted."
     },
     {
-      "prediction": "I'm not sure what you mean by \"use the outgoing thread to do some maintenance on our dead client backlog\". Is this the same as \"use the incoming thread to do some maintenance on our dead client backlog\"? I'm not sure what you mean by \"use the outgoing thread to do some maintenance on our dead client backlog\". Is this the same as \"use the incoming thread to do some maintenance on our dead client backlog\"? I'm not sure what you mean by \"use the outgoing thread to do some maintenance on our dead client backlog\". Is this the same as \"use the incoming thread to do some maintenance on our dead client backlog\"? I'm not sure what you mean by \"use the outgoing thread to do some maintenance on our dead client backlog\". Is this the same as \"use the incoming thread to do some maintenance on our dead client backlog\"? I'm not sure what you mean by \"use the outgoing thread to do some maintenance on our dead client backlog\". Is this the same as \"use the incoming thread to do some maintenance on our dead client backlog\"? I'm not sure what you mean by \"use the outgoing thread to do some maintenance on our dead client backlog\". Is this the same as \"use the incoming thread to do some maintenance on our dead client",
+      "prediction": "I'm not sure what you mean by \"use the outgoing thread to do some maintenance on our dead client backlog\"",
       "reference": "The assertion here is that find should never return end() because this is the only mechanism that reaps items from the activeClientMap. If it == end something went horribly wrong."
     },
     {
-      "prediction": "I think we should remove the `Document` type from the `Collection` interface. It's not used anywhere in the code.",
+      "prediction": "I think we should remove the `Document` type and just use `interface{}` instead.",
       "reference": "The `unless the collection ...` part reads a little bit hard, maybe separate into its own sentence and explain what it means by `cannot generate a fresh key`?"
     },
     {
-      "prediction": "I think we should remove the `Unimplemented` error code, as it's not used anywhere in the code.",
+      "prediction": "I think this should be `UnimplementedErrorCode` instead of `Unimplemented`",
       "reference": "Doesn't `gcerr_string.go` need to be updated for this?"
     },
     {
-      "prediction": "I think this should be `return c.createRuntimeCall(\"stringToRunes\", []llvm.Value{value}, \"\")`",
+      "prediction": "I think this should be a separate function, so that we don't have to call it multiple times.",
       "reference": "Both cases allowed by the Go spec are now supported, so it's a bug in the compiler if we get here. You can replace the `todo:` error with a panic. (Note: getting here would be a bug because when we get to SSA level the code has long been type checked and has already been verified as being valid Go)."
     },
     {
-      "prediction": "I'm not sure what you mean by \"leave hinting mode when focus changed\"",
+      "prediction": "I'm not sure what you mean by \"leave hinting mode when focus changed\". I think you meant to say \"leave hinting mode when the tab is focused\".",
       "reference": "You can simply do `if tab.history_prepared:` here as empty lists are falsey."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea to have the `certsigningrequest` package in the same directory as the `certmanager` package.",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a separate package for `certsigningrequest` and `install` so that we don't have to change the name of the package when we move to a new version of `cert-manager`.",
       "reference": "Remove this whitespace"
     },
     {
-      "prediction": "`one_img` should be `one_img.unsqueeze(0)` instead of `one_img.transpose(2, 0, 1)`.",
+      "prediction": "`one_img = mmcv.imresize(one_img, input_shape[2:][::-1]).transpose(2, 0, 1)` should be `one_img = mmcv.imresize(one_img, input_shape[2:][::-1]).transpose(1, 2, 0)`",
       "reference": "`show_img` is not normalized while `one_img` is normalized. And line 139 pass `show_img` for pytorch2onnx function. Is this expected behavior?"
     },
     {
@@ -27575,39 +27575,39 @@
       "reference": "Why is this bounded between -30 and 30?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `nvcc` to build the tests. This way, we don't have to use `nvcc` to build the tests, and we don't have to use `nvcc` to run the tests. I think it's a good idea to use `nvcc` to build the tests. This way, we don't have to use `nvcc` to build the tests, and we don't have to use `nvcc` to run the tests. I think it's a good idea to use `nvcc` to build the tests. This way, we don't have to use `nvcc` to build the tests, and we don't have to use `nvcc` to run the tests. I think it's a good idea to use `nvcc` to build the tests. This way, we don't have to use `nvcc` to build the tests, and we don't have to use `nvcc` to run the tests. I think it's a good idea to use `nvcc` to build the tests. This way, we don't have to use `nvcc` to build",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `EXCLUDE_HIP_PLATFORM` flag to exclude the HIP platform from the build.",
       "reference": "I think even you can exclude to run it on nvcc"
     },
     {
-      "prediction": "I think we can remove the `LUN0 Option Unmap Disable` and `LUN0 Option WZero Disable` as they are not needed.",
+      "prediction": "I think we should remove the `LUN0 Option Unmap Disable` and `LUN0 Option WZero Disable` as they are redundant.",
       "reference": "G104: Errors unhandled. (from `gosec`)"
     },
     {
-      "prediction": "I think it's better to use `response['tasks']` instead of `response['failures']` in this case.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `self._task_ids` list in the `run_task` method. This way, we don't need to call `client.run_task` multiple times, and we don't have to worry about the order in which the tasks are run.",
       "reference": "will `failure` always include `arn` and `reason` in its dictionary? If so, :+1:"
     },
     {
-      "prediction": "I think we should remove the `target` argument from the `with_events` method.",
+      "prediction": "I think we can remove the `with_events` method and just use `with_events(target, callback, action)` instead.",
       "reference": "Should this be optional, or default to 'action' as well?"
     },
     {
-      "prediction": "I don't think we need to use `v1` here. We can use `v1beta1` instead.",
+      "prediction": "I'm not sure what you mean by `v1` in this context. Is this the version of the Kubernetes API that you're using? If so, I'm not sure what you mean by `v1` in this context. Is this the version of the Kubernetes API that you're using? If so, I'm not sure what you mean by `v1` in this context. Is this the version of the Kubernetes API that you're using? If so, I'm not sure what you mean by `v1` in this context. Is this the version of the Kubernetes API that you're using? If so, I'm not sure what you mean by `v1` in this context. Is this the version of the Kubernetes API that you're using? If so, I'm not sure what you mean by `v1` in this context. Is this the version of the Kubernetes API that you're using? If so, I'm not sure what you mean by `v1` in this context. Is this the version of the Kubernetes API that you're using? If so, I'm not sure what you mean by `v1` in this context. Is this the version of the Kubernetes API that you're using? If so,",
       "reference": "how about formating this import?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a way to get the current navigator object so that you can use it to navigate around the operating system (with the number pad) with out moving the focus.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a way to get the current navigator object from the review position, so that we can use it to navigate around the operating system (with the number pad) with out moving the focus. If the navigator object is not set, it fetches it from the review position. ```braille.handler.handleReviewMove(shouldAutoTether=not isCaret) ```\n\nI'm not sure if this is the right place to do this, but I think it would be good to have a way to get the current navigator object from the review position, so that we can use it to navigate around the operating system (with the number pad) with out moving the focus. If the navigator object is not set, it fetches it from the review position. ```braille.handler.handleReviewMove(shouldAutoTether=not isCaret) ```\n\nI'm not sure if this is the right place to do this, but I think it would be good to have a way to get the current navigator object from the review position, so that we can use it to navigate around the operating system (with the number pad) with out moving the focus. If the",
       "reference": "Comma police. :) Also, the docstring needs updating."
     },
     {
-      "prediction": "I'm not sure what you're trying to say here, but I think it's a good idea to add a comment at the top of this file to explain the purpose of the `driver` type.",
+      "prediction": "I'm not sure what you mean by \"use up to 60 words\". I think you meant to say \"use 60 words\".",
       "reference": "Implement an in-memory implementation of this in the fake driver."
     },
     {
-      "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea to include this in the spec.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a test for this.",
       "reference": "Same question as the other view spec regarding not actually saving records."
     },
     {
-      "prediction": "I'm not sure if this is the best place to put this, but I think it's a good idea to move it to the `NLog.Config` namespace.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `NLog.Core` assembly.",
       "reference": "Rethrow for `MustBeRethrown()`-exceptions?"
     },
     {
@@ -27615,39 +27615,39 @@
       "reference": "May clean the unnecessary modification."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to use `AC_SUBST` to set the `flux_sec_incdir` variable, but it doesn't seem to be working as expected. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use `AC_SUBST` to set the `flux_sec_incdir` variable, but it doesn't seem to be working as expected. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use `AC_SUBST` to set the `flux_sec_incdir` variable, but it doesn't seem to be working as expected. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use `AC_SUBST` to set the `flux_sec_incdir` variable, but it doesn't seem to be working as expected. I'm not sure what you're trying to achieve with this, but it looks like you're trying to use `AC_SUBST` to set the `flux_sec_incdir` variable, but it doesn't seem to be working as expected. I'm not sure what you're trying to achieve with",
+      "prediction": "I'm not sure why we need to check for `flux_sec_incdir` here. I think we can just use `flux_sec_incdir=flux-security` in the `AC_SUBST` line.",
       "reference": "Should this line set the value to `x` since that is checked below?"
     },
     {
-      "prediction": "I think this should be `null` instead of `null`",
+      "prediction": "I'm not sure what you mean by \"recommended split locations\" here. I think it's more accurate to say that this method returns a list of locations where the file should be split into smaller files.",
       "reference": "I don't particularly love the terminology here. Why not simply add `copy(boolean stats)` or a copy with an enum to indicate what portions of the datafile to include? At some point we may want just some of the values (e.g. CBO may want counts, but not lower/upper bounds). Just a thought."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.",
+      "prediction": "I think this should be `if (ann.indexOf('=') == -1)` instead of `if (ann.indexOf('=') == -1 && ann.indexOf('=') == -1)`.",
       "reference": "you could probably remove keyValue and just compare idx vs ann.length (ex I think the goal here is to ensure it works with a value like `foo=`"
     },
     {
-      "prediction": "I think this should be `if (item.file_type && item.file_type === 'TIMELINE') {`",
+      "prediction": "I don't think this is necessary.",
       "reference": "we do this to differentiate between the multiple cc files for when the recording is stopped / restarted multiple times within a single meeting"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to add a new status to the Koha item status mappings. I'm not sure what you're trying to do here. I think you're trying to add a new status to the Koha item status mappings. I'm not sure what you're trying to do here. I think you're trying to add a new status to the Koha item status mappings. I'm not sure what you're trying to do here. I think you're trying to add a new status to the Koha item status mappings. I'm not sure what you're trying to do here. I think you're trying to add a new status to the Koha item status mappings. I'm not sure what you're trying to do here. I think you're trying to add a new status to the Koha item status mappings. I'm not sure what you're trying to do here. I think you're trying to add a new status to the Koha item status mappings. I'm not sure what you're trying to do here. I think you're trying to add a new status to the Koha item status mappings. I'm not sure what you're trying to do here. I think you're",
+      "prediction": "I'm not sure what you're trying to do here. I think you're trying to add a new mapping to the `itemStatusMappings` array, but you're not actually doing anything with it. I'm not sure what you're trying to do here. I think you're trying to add a new mapping to the `itemStatusMappings` array, but you're not actually doing anything with it. I'm not sure what you're trying to do here. I think you're trying to add a new mapping to the `itemStatusMappings` array, but you're not actually doing anything with it. I'm not sure what you're trying to do here. I think you're trying to add a new mapping to the `itemStatusMappings` array, but you're not actually doing anything with it. I'm not sure what you're trying to do here. I think you're trying to add a new mapping to the `itemStatusMappings` array, but you're not actually doing anything with it. I'm not sure what you're trying to do here. I think you're trying to add a new mapping to the `itemStatusMappings` array, but you're not actually doing anything with it. I'm not sure what you're trying to do",
       "reference": "You've deleted this code but not added it anywhere else. Should this be used as my proposed example in the .ini file? Do we need a mechanism for configuring a global fallback string independent of the numeric codes?"
     },
     {
-      "prediction": "I don't think this is needed anymore. We can remove the `@Nullable` annotation.",
+      "prediction": "I don't think this is necessary. We can just use `ImmutableSet.copyOf()` instead.",
       "reference": "nit: strip away those imports? seems not used in the new code."
     },
     {
-      "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to have it in the `generated` package.",
+      "prediction": "I'm not sure if this is the best place to put this, but I think it would make sense to move it to the `generated` package.",
       "reference": "redundant whitespace :octocat:"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to mock the `SetStackPolicyResult` object, but you're not actually using it in your test. If you want to test that the `SetStackPolicyResult` object is returned correctly, you'll need to mock the `SetStackPolicyResult` object yourself.",
+      "prediction": "I think we should be using `assertDictEqual` instead of `self.assertDictEqual` in this case.",
       "reference": "I don't believe that the `assertDictEqual` call can pass without `api_response` being a `dict`, so this second check isn't needed!"
     },
     {
-      "prediction": "I think this should be `if (len > src_end - *src)` instead of `if (len > src_end - *src - 1)`",
+      "prediction": "I think this should be `if (len > src_end - *src)` instead of `if (len > src_end - *src - 1)`.",
       "reference": "Fuzzer did not like this change. Looks like I misunderstood how the pool works... if allocated from a pool we should never free it manually, right? I think I'll need to drop this patch."
     },
     {
@@ -27659,11 +27659,11 @@
       "reference": "New generators should have version `next`"
     },
     {
-      "prediction": "I think we can remove the `params.add(\"--metrics-push-enabled\")` as it is not used.",
+      "prediction": "I don't think we need to add `--metrics-protocol` here, since we already have `--metrics-protocol` in the `--metrics-category` parameter.",
       "reference": "Wrap these two lines inside an `if (node.isMetricsEnabled() || metricsConfiguration.isPushEnabled()) { ... }`"
     },
     {
-      "prediction": "I don't think we need to check `start_level` and `end_level` in this case. If `start_level == -1` or `end_level == -1`, then `start_level` and `end_level` should be set to `len(inputs)` and `len(in_channels)`, respectively.",
+      "prediction": "I don't think we need to check `start_level` and `end_level` here, since `start_level` is always `0` and `end_level` is always `len(in_channels) - 1`.",
       "reference": "if end_level == -1 or end_level == (self.num_ins - 1): for end_level is the Index of the end input backbone level."
     },
     {
@@ -27675,11 +27675,11 @@
       "reference": "Consider faking the TestClient's GetProject/GetZone/GetMachine methods."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. Is it that you want to create an HTTP outbound that sends requests to peers supplied by the given peer.Chooser? Or is it that you want to create an HTTP outbound that sends requests to peers supplied by the given peer.Chooser and uses the peer.Chooser to obtain peer instances and return those peers to the outbound when it calls Choose?",
+      "prediction": "I'm not sure what you mean by \"peer chooser and outbound must share the same transport\"",
       "reference": "Returning a private type as part of the public API? Isn't this impossible for users to implement?"
     },
     {
-      "prediction": "I'm not sure what you mean by `rankNum` in this context. Is it the rank of the atom in the SMILES string, or the rank of the atom in the canonical SMILES string? If it's the rank of the atom in the canonical SMILES string, then it should be the same as the rank of the atom in the SMILES string. If it's the rank of the atom in the SMILES string, then it should be the same as the rank of the atom in the canonical SMILES string. I'm not sure what you mean by `rankNum` in this context. Is it the rank of the atom in the SMILES string, or the rank of the atom in the canonical SMILES string? If it's the rank of the atom in the canonical SMILES string, then it should be the same as the rank of the atom in the SMILES string. If it's the rank of the atom in the SMILES string, then it should be the same as the rank of the atom in the canonical SMILES string. I'm not sure what you mean by `rankNum` in this context. Is it the rank of the atom in the SMILES string, or the rank of the atom in the canonical SMILES",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `getAtomWithIdx` method.",
       "reference": "prefer common_properties::_canonicalRankingNumber if possible, should be quicker in general."
     },
     {
@@ -27687,19 +27687,19 @@
       "reference": "The meaning of `loss_normalizer` and `loss_normalizer_momentum` should be reflected in docstring."
     },
     {
-      "prediction": "I think this should be `queue->async.read` instead of `queue->async.read->data`.",
+      "prediction": "I'm not sure if this is a good idea, but I don't think we need to use `fcntl` here. We can just use `ioctlsocket` here.",
       "reference": "Call to `cloexec_pipe` (or an equivalent function) is missing. I presume that this is the reason why you are seeing timeout errors."
     },
     {
-      "prediction": "I think we can remove the `@SuppressWarnings(\"unchecked\")` here, as it's not really needed.",
+      "prediction": "I think this should be `import static org.springframework.security.oauth2.jwt.JwtUtils.*` instead of `import org.springframework.security.oauth2.jwt.JwtUtils.*`",
       "reference": "There are no changes in this file. Please reset."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do with this function. It seems like you're trying to calculate the probability of getting samples from a normal distribution that are further from the mean than a given value. Is this what you're trying to do?",
+      "prediction": "I'm not sure I understand what you're trying to do here.",
       "reference": "Should we rename this to tailProbability?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `opnd_get_base_aligned` here.",
       "reference": "Add the issue number too i#4400"
     },
     {
@@ -27711,15 +27711,15 @@
       "reference": "Why this file is changed?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"discard all changes after given timestamp.\" Is this the same as the `revert` capability?",
+      "prediction": "I'm not sure I understand what you're trying to do with the `revert` capability. It seems like you want to be able to revert to a specific point in time, but I'm not sure if that's what you're trying to do.",
       "reference": "I'm not sure that we need this"
     },
     {
-      "prediction": "I think this should be `if (package.Value is JObject)` instead of `if (package.Value is JValue)`.",
+      "prediction": "I'm not sure if this is the right place to add this check, but I think it's a good idea to add this check here.",
       "reference": "Is this going to cause issues in any other places were someone forgets the version? Should we consider also checking for type=project?"
     },
     {
-      "prediction": "I think this should be `secretsmanageriface.SecretsManagerAPI` instead of `secretsmanageriface.SecretsManagerAPI`",
+      "prediction": "I think this should be `secretsmanageriface.SecretsManagerAPI` instead of `secretsmanageriface.SecretsManagerAPIAPI`",
       "reference": "Does this have retries? Is there a possibility that customer would hit throttle errors here?"
     },
     {
@@ -27727,7 +27727,7 @@
       "reference": "i noted that we are inconsistent with when we indent includes (see atomics.h which is rather different) and for example cpu.c which is also different. we seem to have 3 styles."
     },
     {
-      "prediction": "I think this should be `if (fs.existsSync('network-audit-results.json')) { fs.unlinkSync('network-audit-results.json') }`",
+      "prediction": "I think we should remove the `if (fs.existsSync('network-audit-results.json')) { fs.unlinkSync('network-audit-results.json') }` line.",
       "reference": "Deleting the files before starting the audit helps avoid stale results if the new file is not created."
     },
     {
@@ -27739,7 +27739,7 @@
       "reference": "This is... quite unconventional (use a map entry as a key). I would suggest making your own data class for the key."
     },
     {
-      "prediction": "I think we can remove the `background_color` and `color` from the `OutputList` class.",
+      "prediction": "I think it's better to use `background_color` and `color` instead of `color` and `background_color`.",
       "reference": "why are these colors needed to be specified here? when are they used?"
     },
     {
@@ -27747,7 +27747,7 @@
       "reference": "Nit: no need to change this method."
     },
     {
-      "prediction": "I'm not sure if this is a good place to put this, but I think it would be a good place to put it.",
+      "prediction": "I'm not sure if this is a good place to put it, but I think we should move it to the `inventory_summary.py` file.",
       "reference": "Why a blank line?"
     },
     {
@@ -27755,7 +27755,7 @@
       "reference": "Why remove the `.html_safe` here? Should we use `sanitize` or `raw` instead? This info comes off of the org edit page and is entered by users."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to call `dynamorio_app_init()`, but you're passing `attach_case` as a parameter. I'm not sure what you're trying to do here. It looks like you're trying to call `dynamorio_app_init()`, but you're passing `attach_case` as a parameter. I'm not sure what you're trying to do here. It looks like you're trying to call `dynamorio_app_init()`, but you're passing `attach_case` as a parameter. I'm not sure what you're trying to do here. It looks like you're trying to call `dynamorio_app_init()`, but you're passing `attach_case` as a parameter. I'm not sure what you're trying to do here. It looks like you're trying to call `dynamorio_app_init()`, but you're passing `attach_case` as a parameter. I'm not sure what you're trying to do here. It looks like you're trying to call `dynamorio_app_init()`, but you're passing `attach_case` as a parameter. I'm not sure what you're trying to do here. It looks like you",
+      "prediction": "I'm not sure what you're trying to do here. The `attach_case` parameter is only used in the `dynamorio_app_init` function, not in the `dynamorio_app_start` function.",
       "reference": "I think we need some docs about how to set this parameter correctly. Are we OK with changing the public API like this? We probably at least want to make a change notice to the release doc."
     },
     {
@@ -27771,19 +27771,19 @@
       "reference": "All the changes in this commit are mechanical. Produced by the script in the previous commit."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `assert: false, echo: false` here.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `assert: false, echo: false` here. It's a bit of a hack, but I think it's the best way to do this.",
       "reference": "What's the difference between these 2 versions?"
     },
     {
-      "prediction": "I think we can remove the `mock_output_results` call, since it's not used in this test.",
+      "prediction": "I'm not sure if this is the right place to add this test, but I think it would be good to add it to the test suite.",
       "reference": "@red2k18 Are we sure its correct to only have 1 now?"
     },
     {
-      "prediction": "I think it's better to use `newB->setProp(RDKit::common_properties::_unspecifiedOrder, 1);` instead of `newB->setProp(RDKit::common_properties::_unspecifiedOrder, 1); newB->setProp(RDKit::common_properties::_unspecifiedOrder, 1);`",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to make sure that the order of the bonds in the fragment is the same as the order of the bonds in the molecule.",
       "reference": "@greglandrum interesting, is this related to #3307 by any chance?"
     },
     {
-      "prediction": "I don't think this is necessary. We can just use `User.find_or_create_by(email_address: session[:user]['email']) if session[:user] && session[:user]['email']` instead.",
+      "prediction": "I think this should be `if ENV['FORCE_USER_ID'] && !Rails.env.production?` instead of `if ENV['FORCE_USER_ID'] && !Rails.env.production?`",
       "reference": "Minor: how about moving the trailing `if` to an `elsif` above?"
     },
     {
@@ -27791,15 +27791,15 @@
       "reference": "That's only executed when users switch from 2.2 to 2.3. Please create a new block with code `2050000` for the next release :) Please also adapt the version number in PodDbAdapter"
     },
     {
-      "prediction": "I'm not sure what you mean by \"does not make sense to continue here if connection is gone.\"",
+      "prediction": "I think this should be `gacc.mu.RLock()` and `gacc.mu.RUnlock()` instead of `gacc.mu.RLock()` and `gacc.mu.RUnlock()`.",
       "reference": "Safe to reference c.srv without capturing it first under a client lock?"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to add a docstring to this function.",
+      "prediction": "I don't think we need to change anything here, but I'd like to make sure I'm not missing anything.",
       "reference": "@vincepri blame tells me this was you, any objections to the change?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this, but it looks like you're trying to start a server that listens on port 8080, but you're not waiting for all inbounds to be ready before starting the server. I'm not sure what you're trying to do with this, but it looks like you're trying to start a server that listens on port 8080, but you're not waiting for all inbounds to be ready before starting the server. I'm not sure what you're trying to do with this, but it looks like you're trying to start a server that listens on port 8080, but you're not waiting for all inbounds to be ready before starting the server. I'm not sure what you're trying to do with this, but it looks like you're trying to start a server that listens on port 8080, but you're not waiting for all inbounds to be ready before starting the server. I'm not sure what you're trying to do with this, but it looks like you're trying to start a server that listens on port 8080, but you're not waiting for all inbounds to be ready before starting the server. I",
+      "prediction": "I'm not sure what you're trying to do here, but I think it's a bad idea to start the server in a goroutine.",
       "reference": "@abhinav here is where i need to be able to block/wait until the server is started"
     },
     {
@@ -27819,7 +27819,7 @@
       "reference": "For a followup - it is better to use acceptlist/denylist. I realize this is a historical artifact of our codebase."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `FileSizeChecker.bytesToHumanReadable` in this case.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into a separate class.",
       "reference": "Looks like glassfish went a bit nuts doing a refactor"
     },
     {
@@ -27827,15 +27827,15 @@
       "reference": "Couldn't you use position:absolute or float to move inline elements outside their parent? Through clipping an child element can also be outside it's parent. There are probably some other ways to do it too. So I'm not sure the assumption you're making here is right."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `DateTimeUtils.microsToMillis` instead of `DateTimeUtils.toMillis` for the `retainLastNum` parameter.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this",
       "reference": "This could be copied into iceberg code to avoid the spark internal dep? We could use a version check to adjust the method used if needed."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to `flux_subprocess_destroy_finish` as well.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `subprocess_destroy_finish` as well.",
       "reference": "This one had me stumped!"
     },
     {
-      "prediction": "I think it's better to remove the `--nomargin` from the `meta-item` class.",
+      "prediction": "I think it's better to remove the `--nomargin` class.",
       "reference": "Note that this name differs from the name used as default (and thus used now that you removed this). That should be fine, but wanted to flag it."
     },
     {
@@ -27843,19 +27843,19 @@
       "reference": "Why public and not protected?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `current_user` object to determine if the user is a super admin or not.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `current_tab` variable in the template.",
       "reference": "We definitely need to address this duplication after MVP"
     },
     {
-      "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `ref={ ... }` instead of `ref={ keywordsContainer }` in this case. This is because `ref={ ... }` is used to create a reference to a DOM element, while `ref={ keywordsContainer }` is used to create a reference to a DOM element that is a child of another DOM element.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to have it in the `UserInput` component.",
       "reference": "This will always generate a label for the first keyword, which means this will be a label linked to no element after the first keyword is entered. This label should be generated inside the `values.map` next to the `` it is for, because the ID changes based on the index. Also, we have a `VisuallyHidden` component I'd prefer we use over the CSS class. Building as many things out of components is more React-y. Admittedly it's sort of a preference, but it's why we have the `VisuallyHidden` component. So let's use that instead"
     },
     {
-      "prediction": "I'm not sure what you mean by `desktop->xcursor_theme = roots_xcursor_theme_create(\"default\");`. I think you meant to say `desktop->xcursor_theme = wlr_xcursor_theme_create(\"default\");`",
+      "prediction": "I'm not sure what you mean by `desktop->xcursor_theme = roots_xcursor_theme_create(\"default\");`. I think you meant to say `desktop->xcursor_theme = wlr_xcursor_theme_create(\"default\");`.",
       "reference": "Does it make sense for this to be fatal? Could there be an embedded application that does not have xcursor themes at all? For instance, compositors without a pointer (like a touch-screen kiosk) will never show a cursor. I think I'm ok with this assumption since it simplifies the code and rootston is assumed to have desktop features, but we should always make sure xcursor is not required to be used in the library."
     },
     {
-      "prediction": "Shouldn't this be `BloomStructRef` instead of `LogEntryStructRef`?",
+      "prediction": "I think this should be `public abstract bool Matches(ref LogEntryStructRef entry);` instead of `public abstract bool Matches(BloomStructRef bloom);`",
       "reference": "would rename to TopicsFilter and original one to SequenceTopicsFilter"
     },
     {
@@ -27871,15 +27871,15 @@
       "reference": "I'm okay with leaving VCPULimit and MemoryLimit on our internal model"
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear to me what the purpose of `TierIndex` and `maxSupportedTiers` is. I think it would be better to have a `ClusterNetworkPolicy` struct with a `Tiers` field and a `Tier` field.",
+      "prediction": "I don't think we need to use `maxSupportedTiers` here. We can just use `defaultWorkers` and `defaultRulePriority` instead.",
       "reference": "5 or 10?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"live-loop situation\". Is it possible that this code is being executed in the same thread as the activity exporter? If so, I think we should be able to suppress telemetry from the exporter's own code to avoid live-loop situation.",
+      "prediction": "I'm not sure what you mean by \"live-loop situation\" here. Is it possible that this code is being executed in the same thread as the activity exporter itself? If so, I think we should be able to suppress telemetry from the exporter's own code to avoid live-loop situation.",
       "reference": "Should we explain more here?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a new instance, but you're passing in an existing one. I think you want to create a new instance, but you're passing in an existing one. I think you want to create a new instance, but you're passing in an existing one. I think you want to create a new instance, but you're passing in an existing one. I think you want to create a new instance, but you're passing in an existing one. I think you want to create a new instance, but you're passing in an existing one. I think you want to create a new instance, but you're passing in an existing one. I think you want to create a new instance, but you're passing in an existing one. I think you want to create a new instance, but you're passing in an existing one. I think you want to create a new instance, but you're passing in an existing one. I think you want to create a new instance, but you're passing in an existing one. I think you want to create a new instance, but you're passing in an existing one. I think you want to create a new instance, but you're passing in",
+      "prediction": "I'm not sure what you mean by \"this should never need to import the ec2 sdk.\" Is it because it's not used anywhere?",
       "reference": "I've been struggling with this on my cloud-init integration work as well. In addition to info that is currently stored in the cluster providerstatus, we also need some of the info that is available within the base cluster object as well. I think it would make sense to unify the machine and cluster info needed into a consolidated struct rather than continuing to add additional disparate structs."
     },
     {
@@ -27887,31 +27887,31 @@
       "reference": "Why not `@InternalApi`?"
     },
     {
-      "prediction": "I think this should be `from typing import _GenericAlias` instead of `from typing import GenericMeta as _GenericAlias`",
+      "prediction": "I think this should be `from typing import GenericMeta as _GenericAlias` instead of `from typing import _GenericAlias as _GenericAlias`",
       "reference": "FYI: `GenericMeta` is renamed to `_GenericAlias` in Python3.7."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to show the user that they can reorder the sections, but they can only do it if they are the latest version of the template.",
+      "prediction": "I'm not sure if this is the right way to do this, but I think it would be better to use `template.latest?` instead of `phase.latest?` in this case.",
       "reference": "So this hides the link to re-order sections on Historic Templates? Good catch, Just checked on DMPonline and hitting that throws a 404"
     },
     {
-      "prediction": "I think this should be `configuration.reset` instead of `configuration.reset_reporter`?",
+      "prediction": "I think this should be `configuration.reset` instead of `configuration.reset_reporter`.",
       "reference": "Is `Reporter#reset` no longer used? If so, can we remove it?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get the base fee from the header. I'm not sure what you're trying to do here, but it looks like you're trying to get the base fee from the header. I'm not sure what you're trying to do here, but it looks like you're trying to get the base fee from the header. I'm not sure what you're trying to do here, but it looks like you're trying to get the base fee from the header. I'm not sure what you're trying to do here, but it looks like you're trying to get the base fee from the header. I'm not sure what you're trying to do here, but it looks like you're trying to get the base fee from the header. I'm not sure what you're trying to do here, but it looks like you're trying to get the base fee from the header. I'm not sure what you're trying to do here, but it looks like you're trying to get the base fee from the header. I'm not sure what you're trying to do here, but it looks like you're trying to get the base fee from the header. I'm not sure",
+      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get the base fee from the header. I think you should be able to get it from `header.getBaseFee().get()`, but I'm not sure if that's what you're trying to do.",
       "reference": "same concern here about difference in the write scalar implementation. I am not sure if this could present a consensus problem or not"
     },
     {
-      "prediction": "Should this be `IMvxSplitViewController` instead of `IMvxTvosView`?",
+      "prediction": "Should this be `IMvxTvosView` instead of `IMvxSplitViewController`?",
       "reference": "Can we remove this file?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to log the reason for the error.",
+      "prediction": "I think we can remove the `if ok && sErr.ErrStatus.Code == 422 && sErr.ErrStatus.Reason == metav1.StatusReasonInvalid` check.",
       "reference": "Why listing only first error reason (`ErrStatus.Details.Causes[0].Message`)?"
     },
     {
-      "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good place to put it, since it's not part of the `RewriteDataFiles` interface, but rather part of the `SnapshotUpdate` interface.",
+      "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good place to put this in the `RewriteDataFiles` class.",
       "reference": "Now that this is true, do we have to ignore it with V1 Tables?"
     },
     {
@@ -27919,7 +27919,7 @@
       "reference": "prefer if (condition) { stuff; } to if !(condition) { continue; } stuff"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `:display_name` and `:tag` options in the `rss_link_to` helper. This way, we can use the `@display_name` and `@tag` variables to display the display name and tag in the RSS feed.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `:display_name` and `:tag` options in the `rss_link_to` helper.",
       "reference": "Should this section not be converted to a secondary action list?"
     },
     {
@@ -27927,15 +27927,15 @@
       "reference": "This askes a blocking question, which means a local Qt eventloop will be running. While this is unavoidable sometimes, the async functions should be used whenever possible (`message.confirm_async` in this case). This means: - Split everything after this question in a separate private method (you can probably just call it `_tab_close`) - If the tab is not pinned, just call `_tab_close` directly - If it is pinned, call `message.confirm_async` with `yes_action=self._tab_close`"
     },
     {
-      "prediction": "olicy.EnableConversion), $(\"#chkEnableAudioConversion\", page).checked(user.Policy.EnableAudioConversion), $(\"#chkEnableVideoConversion\", page).checked(user.Policy.EnableVideoConversion), $(\"#chkEnableAudioConversion\", page).checked(user.Policy.EnableAudioConversion), $(\"#chkEnableVideoConversion\", page).checked(user.Policy.EnableVideoConversion), $(\"#chkEnableAudioConversion\", page).checked(user.Policy.EnableAudioConversion), $(\"#chkEnableVideoConversion\", page).checked(user.Policy.EnableVideoConversion), $(\"#chkEnableAudioConversion\", page).checked(user.Policy.EnableAudioConversion), $(\"#chkEnableVideoConversion\", page).checked(user.Policy.EnableVideoConversion), $(\"#chkEnableAudioConversion\", page).checked(user.Policy.EnableAudioConversion), $(\"#chkEnableVideoConversion\", page).checked(user.Policy.EnableVideoConversion), $(\"#chkEnableAudioConversion\", page).checked(user.Policy.EnableAudioConversion), $(\"#chkEnableVideoConversion\", page).checked(user.Policy.EnableVideoConversion), $(\"#chkEnableAudioConversion\", page).checked(user.Policy.EnableAudioConversion), $(\"#chkEnableVideoConversion\", page).checked(user.Policy.EnableVideoConversion\"), $(\"#chkEnableAudioConversion\", page).checked(user.Policy.EnableAudioConversion), $(\"#chkEnableVideoConversion\", page).checked(user.Policy",
+      "prediction": "olicy.EnableConversion), $(\"#chkEnableAudioConversion\", page).checked(user.Policy.EnableAudioConversion), $(\"#chkEnableVideoConversion\", page).checked(user.Policy.EnableVideoConversion), $(\"#chkEnableAudioConversion\", page).checked(user.Policy.EnableAudioConversion), $(\"#chkEnableVideoConversion\", page).checked(user.Policy.EnableVideoConversion), $(\"#chkEnableAudioConversion\", page).checked(user.Policy.EnableAudioConversion), $(\"#chkEnableVideoConversion\", page).checked(user.Policy.EnableVideoConversion), $(\"#chkEnableAudioConversion\", page).checked(user.Policy.EnableAudioConversion), $(\"#chkEnableVideoConversion\", page).checked(user.Policy.EnableVideoConversion), $(\"#chkEnableAudioConversion\", page).checked(user.Policy.EnableAudioConversion), $(\"#chkEnableVideoConversion\", page).checked(user.Policy.EnableVideoConversion), $(\"#chkEnableAudioConversion\", page).checked(user.Policy.EnableAudioConversion), $(\"#chkEnableVideoConversion\", page).checked(user.Policy.EnableVideoConversion), $(\"#chkEnableAudioConversion\", page).checked(user.Policy.EnableAudioConversion), $(\"#chkEnableVideoConversion\", page).checked(user.Policy.EnableVideoConversion\"), $(\"#chkEnableAudioConversion\", page).checked(user.Policy.EnableAudioConversion\"), $(\"#chkEnableVideoConversion\", page).checked(user.Policy",
       "reference": "Can we deuglify this?"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. What's the point of `filter` here? What's the point of `map` here? What's the point of `flatMap` here? What's the point of `lift` here? What's the point of `apply` here? What's the point of `lift` here? What's the point of `apply` here? What's the point of `lift` here? What's the point of `apply` here? What's the point of `lift` here? What's the point of `apply` here? What's the point of `lift` here? What's the point of `apply` here? What's the point of `lift` here? What's the point of `apply` here? What's the point of `lift` here? What's the point of `apply` here? What's the point of `lift` here? What's the point of `apply` here? What's the point of `lift` here? What's the point of `apply` here? What's the point of `lift` here? What's the point of `apply` here? What's the point of `lift` here? What",
+      "prediction": "I don't think this is a good idea. The `Option` class is not meant to be used in this way.",
       "reference": "@skestle Just recognized that the `::apply` is not necessary. Does it compile if you leave it away? Could you please check that, I'm on vacation and have no IDE at hand... Thx!"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. Can you please explain what you're trying to achieve?",
+      "prediction": "I'm not sure I understand what you're trying to do here. You're trying to build a new spec using the table's schema, which uses fresh IDs, but you're also trying to build a new spec using the table's schema, which doesn't use fresh IDs. I'm not sure what you're trying to do here. You're trying to build a new spec using the table's schema, which uses fresh IDs, but you're also trying to build a new spec using the table's schema, which doesn't use fresh IDs. I'm not sure what you're trying to do here. You're trying to build a new spec using the table's schema, which uses fresh IDs, but you're also trying to build a new spec using the table's schema, which doesn't use fresh IDs. I'm not sure what you're trying to do here. You're trying to build a new spec using the table's schema, which uses fresh IDs, but you're also trying to build a new spec using the table's schema, which doesn't use fresh IDs. I'm not sure what you're trying to do here. You're trying to build a new spec using the table's schema, which uses fresh IDs, but you're also trying to build",
       "reference": "Looks like this is an unnecessary change."
     },
     {
@@ -27943,55 +27943,55 @@
       "reference": "This one won't change as the resource is not included in the project getting tested with the composite root."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to set `nat_lvl1_drop` to 1, but I'm not sure what you're trying to do here. I think you're trying to set `nat_lvl1_drop` to 1, but I'm not sure what you're trying to do here. I think you're trying to set `nat_lvl1_drop` to 1, but I'm not sure what you're trying to do here. I think you're trying to set `nat_lvl1_drop` to 1, but I'm not sure what you're trying to do here. I think you're trying to set `nat_lvl1_drop` to 1, but I'm not sure what you're trying to do here. I think you're trying to set `nat_lvl1_drop` to 1, but I'm not sure what you're trying to do here. I think you're trying to set `nat_lvl1_drop` to 1, but I'm not sure what you're trying to do here. I think you're trying to set `nat_lvl1_drop` to 1, but I'm not sure what you're trying to do here. I think you're",
+      "prediction": "I'm not sure what you're trying to do here. I don't think we need to do this.",
       "reference": "We have `stdbool` imported, might as well use that for clarity."
     },
     {
-      "prediction": "I think we can remove the `SqlServerIntegration.ServiceName` and `SqlServer-sql-server` from the `Assert.Equal` tests.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `SqlServerIntegration.cs` file.",
       "reference": "Why do we not also have integration tests for postgres?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"skip\" in this case. Is it because you don't want to run this test?",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's the best way to do this. It's a bit of a hack, but I think it's the best way to do it.",
       "reference": "I think its safe to remove this if we're removing `reIndex` outright. The description shows us that the test is \"An example showing how to force a reindex of a collection\""
     },
     {
-      "prediction": "I'm not sure what this is for, but it looks like it should be `EACCES` instead of `EEXIST`.",
+      "prediction": "I'm not sure if this is the right place to change this, but I think it's a good idea to add a new `Errno` for `EINVAL` and `EMFILE`.",
       "reference": "Can you make this hexadecimal to match the other constants?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `check_deprecated_file` method in the `Bolt::Project` class. This way, we don't have to do this in the `Bolt::Logger.warn` method.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `check_deprecated_file` method in the `Bolt::Project` class.",
       "reference": "Can this get moved to `Bolt::Project#validate`?"
     },
     {
-      "prediction": "I think we can remove the `reverse()` call here, as it's not needed.",
+      "prediction": "I think we can remove the `reverse()` call here.",
       "reference": "I'm pretty sure it doesn't harm, but don't we have a second pass here with the reverse() operation?"
     },
     {
-      "prediction": "I think this should be `TAKES_HEAP_SNAPSHOT` instead of `TAKES_HEAP_SNAPSHOT = \"takesHeapSnapshot\"`",
+      "prediction": "I think it's better to use `TAKES_HEAP_SNAPSHOT` and `TAKES_SCREENSHOT` instead of `TAKES_HEAP_SNAPSHOT` and `TAKES_SCREENSHOT`.",
       "reference": "This is not a standard capability and should be hidden behind a vendor prefix: -chromium-takesHeapSnapshot"
     },
     {
-      "prediction": "I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place",
+      "prediction": "I'm not sure if this is the right place to do this, but I think we should move this to the `sgd_execution_context` class.",
       "reference": "This shouldn't work with pointers -- prefer references unless you can meaningfully pass `nullptr`. The address-of operator here is clunky at best."
     },
     {
-      "prediction": "I'm not sure what you mean by \"requires GCC 11.2.0 or above for interface comparison.\"",
+      "prediction": "I'm not sure what you mean by \"requires GCC 11.2.0 or above for interface comparison.\" Is this a typo or is it meant to be \"requires GCC 11.2.0 or above for interface comparison\"?",
       "reference": "Sidenote: some day we'll drop the avr-gcc and avr-libc dependencies so that this case becomes supported."
     },
     {
-      "prediction": "I'm not sure what you mean by \"direct has a different type of limit\". I think it's just that `Memory` has a different type of limit.",
+      "prediction": "I'm not sure what you mean by \"Direct has a different type of limit\". I think it's just that `Memory` has a different type of limit.",
       "reference": "do we still need this method?"
     },
     {
-      "prediction": "I think this should be `if ((getOperatorType() != REL_UNARY_INSERT) || getUpdateCKorUniqueIndexKey() || ((getOperatorType() == REL_UNARY_INSERT) && ((Insert *)this)->isMerge()) || ((getOperatorType() == REL_UNARY_INSERT) && ((Insert *)this)->isUpsert() && (CmpCommon::getDefault(TRAF_UPSERT_TO_EFF_TREE) == DF_ON )))`",
+      "prediction": "I'm not sure if this is a good place to put this, but I think it would be good to add a check here to make sure that we don't try to merge the old and new values if they don't have the same valueid.",
       "reference": "It's better to not leave this old code here... it just clutters things up and makes reading the code more confusing. We can always recover the old code from the repository if needed."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. The `ManagedObject` class is not part of the `org.apache.http.client.methods` package. It's part of the `org.apache.http.impl.client` package, which is not part of the `org.apache.http.client.methods` package. I think it's a good idea to remove the `ManagedObject` class from the `org.apache.http.client.methods` package, as it's not part of the `org.apache.http.client.methods` package.",
+      "prediction": "I don't think this is necessary. The `ManagedObject` class is not used anywhere in this code, so we can remove it.",
       "reference": "Again, you don't want to depend on glassfish."
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here. If you want to create a new post, you should use the `create` method. If you want to update an existing post, you should use the `update` method. If you want to create a new topic, you should use the `create` method. If you want to update an existing topic, you should use the `update` method. If you want to create a new account, you should use the `create` method. If you want to update an existing account, you should use the `update` method. If you want to create a new topic, you should use the `create` method. If you want to update an existing topic, you should use the `update` method. If you want to create a new account, you should use the `create` method. If you want to update an existing account, you should use the `update` method. If you want to create a new topic, you should use the `create` method. If you want to update an existing topic, you should use the `update` method. If you want to create a new account, you should use the `create` method.",
+      "prediction": "I don't think we need to use `factory` here. We can just use `factory(:post)`.",
       "reference": "This shouldn't be required. What was going on here?"
     },
     {
@@ -27999,7 +27999,7 @@
       "reference": "Why add this here?"
     },
     {
-      "prediction": "I think this should be `Microsoft.Rest.HttpOperationResponse` instead of `Microsoft.Rest.HttpOperationHeaderResponse`.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it should go in the `HttpOperationResponse` class.",
       "reference": "nullability does not apply to headers type (that is always an object)"
     },
     {
@@ -28007,11 +28007,11 @@
       "reference": "Do we also need to add the iova, or is that done somewhere else?"
     },
     {
-      "prediction": "I think this should be `UseNew` instead of `UseOrCreate`?",
+      "prediction": "Shouldn't this be `UseNewPassphrase` instead of `UseNewPassphrasePassphrase`?",
       "reference": "why change this?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `h2o_get_timestamp` as well.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `h2o_timestamp_t` struct.",
       "reference": "If there is no guarantee that tv_sec is of type `time_t`, IMO you should copy the value instead of enforcing a pointer typecast."
     },
     {
@@ -28023,7 +28023,7 @@
       "reference": "It feels like we should be working to reduce/eliminate our global vars. I'm not sure it adds much here. Any objection to just removing it?"
     },
     {
-      "prediction": "I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do this, but I'm not sure if this is the right way to do this, but I",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to add a foreign key to the `scheduled_reports` table. This way, we don't need to add a foreign key to the `users` and `reports` tables, and we don't need to add a foreign key to the `scheduled_reports` table at all. We just need to add a foreign key to the `scheduled_reports` table, and then we can use the foreign key to reference the `users` and `reports` tables in the `scheduled_reports` table.",
       "reference": "did you consider using AR enums for this? would give us all the boolean methods (`weekly?` etc) for free"
     },
     {
@@ -28035,35 +28035,35 @@
       "reference": ":+1: That does resolve my security concerns about this feature."
     },
     {
-      "prediction": "I'm not sure what you mean by \"select nonblock\". I think you mean \"select nonblocking\".",
+      "prediction": "I'm not sure what you mean by \"nonblock\" here. I think you mean \"non-blocking\" or \"non-blocking sockets\".",
       "reference": "Could you add a docstring?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"expect error, got none\". I'm not sure what you mean by \"expect error, got none\". I'm not sure what you mean by \"expect error, got none\". I'm not sure what you mean by \"expect error, got none\". I'm not sure what you mean by \"expect error, got none\". I'm not sure what you mean by \"expect error, got none\". I'm not sure what you mean by \"expect error, got none\". I'm not sure what you mean by \"expect error, got none\". I'm not sure what you mean by \"expect error, got none\". I'm not sure what you mean by \"expect error, got none\". I'm not sure what you mean by \"expect error, got none\". I'm not sure what you mean by \"expect error, got none\". I'm not sure what you mean by \"expect error, got none\". I'm not sure what you mean by \"expect error, got none\". I'm not sure what you mean by \"expect error, got none\". I'm not sure what you mean by \"expect error, got none\". I'm not sure what you mean by \"expect error, got none\". I",
+      "prediction": "I'm not sure what you mean by \"expect error, got none\"",
       "reference": "Shouldn't this still be `Region()`?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this signal. It's not used anywhere in the code, so I don't think it's necessary to add it.",
+      "prediction": "I'm not sure what you mean by \"https://github.com/The-Compiler/qutebrowser/issues/117\"",
       "reference": "This shouldn't be here but `self.connected = None` in `__init__` instead, otherwise that'd be an attribute which is set this way in _every_ instance of that class (i.e. a class rather than an instance variable). I'd also say let's make it \"private\" (i.e. `_connected`) and please add a quick note about what it is to the docstring of the class."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here, but I think we should remove the `start_error_message` argument from the constructor.",
+      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to create a new instance of the ChromiumService class, but you're passing arguments to it. What do you want to do with these arguments? I'm not sure I understand what you're trying to do here. I think you're trying to create a new instance of the ChromiumService class, but you're passing arguments to it. What do you want to do with these arguments? I'm not sure I understand what you're trying to do here. I think you're trying to create a new instance of the ChromiumService class, but you're passing arguments to it. What do you want to do with these arguments? I'm not sure I understand what you're trying to do here. I think you're trying to create a new instance of the ChromiumService class, but you're passing arguments to it. What do you want to do with these arguments? I'm not sure I understand what you're trying to do here. I think you're trying to create a new instance of the ChromiumService class, but you're passing arguments to it. What do you want to do with these arguments? I'm not sure I understand what you're trying to do here. I think",
       "reference": "This would be better served as a method/property that is set when people don't want to a window."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to generate descriptors for methods that don't have a page streaming method.",
+      "prediction": "I'm not sure if this is a good place to put this, but I think it would be good to add a check to see if the method is a non-streaming method before adding it to the list.",
       "reference": "I was dubious about putting getNonStreamingMethods in the context, but after some thought, I have decided to embrace the approach. In this particular case, the loop is supposed to be over page streaming methods. So, could you add a getPageStreamingMethods() method in the context, use it here, and remove the isPageStreaming() check below?"
     },
     {
-      "prediction": "I think it's better to use `self.settings.get('version', self.JMETER_VER)` instead of `str(self.settings.get('version', self.JMETER_VER)).split('.')`",
+      "prediction": "I think it's better to use `self.settings.get('version', self.JMETER_VER)` instead of `str(self.settings.get('version', self.JMETER_VER)).split('.')` because `self.settings.get('version', self.JMETER_VER)` will raise `KeyError` if `self.JMETER_VER` is not set.",
       "reference": "LooseVersion class can help here"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think you want to change the default value of `foo.m_AvailableStepsCount` to 0.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to change the default value of `foo.m_AvailableStepsCount` to 0.",
       "reference": "`const Dims zeros(shape.size(), 0);`"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this option, but I'm not sure if it's a good idea to use it. It seems like you're trying to profile the examples, but you're not sure if you want to profile all examples or just the slowest ones. If you don't want to profile all examples, you can remove this option. If you want to profile the slowest examples, you can add this option.",
+      "prediction": "I'm not sure if this is a good idea, but I think it would be better to use `--profile` and `--slowest` instead of `--profile [COUNT]` and `--slowest [COUNT]`.",
       "reference": "Would be good for this not to say `10` anymore..."
     },
     {
@@ -28071,43 +28071,43 @@
       "reference": "See above, we don't need to pass the module name here."
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the GraphController class.",
+      "prediction": "I don't think this is a good idea. The `GraphQLConfigurator` should be a service, not a class. Also, I don't think it's a good idea to have a `GraphController` that extends `GraphController`. It's better to have a `GraphQLController` that extends `GraphController`.",
       "reference": "This is random line :-) overridden String type by custom trimmed - please change that commit message to something like \"introduced custom String type with automatic trimming\""
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea.",
+      "prediction": "I think we should remove this now, since it's not used anymore.",
       "reference": "My personal taste: \"depreciated\" -> \"deprecated\""
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. Is it possible that you're trying to use `destinationServiceName` in a way that is not allowed by the spec? I'm not sure what you're trying to do here. Is it possible that you're trying to use `destinationServiceName` in a way that is not allowed by the spec? I'm not sure what you're trying to do here. Is it possible that you're trying to use `destinationServiceName` in a way that is not allowed by the spec? I'm not sure what you're trying to do here. Is it possible that you're trying to use `destinationServiceName` in a way that is not allowed by the spec? I'm not sure what you're trying to do here. Is it possible that you're trying to use `destinationServiceName` in a way that is not allowed by the spec? I'm not sure what you're trying to do here. Is it possible that you're trying to use `destinationServiceName` in a way that is not allowed by the spec? I'm not sure what you're trying to do here. Is it possible that you're trying to use `destinationServiceName` in a way that is not allowed by",
+      "prediction": "I don't think we need to add `destinationClusterIP` and `destinationServiceName` as they are not used by the client. We can remove them.",
       "reference": "this includes the port as well right? should the name be `destinationServicePortName`?"
     },
     {
-      "prediction": "I think this should be `from urllib.parse import urljoin, urlencode` instead of `from urllib.parse import urljoin, urlencode, urlparse`",
+      "prediction": "I think we should remove the `from urllib.parse` line. It's not used anywhere in the code.",
       "reference": "We can import all of them in one line."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. The `appendAll` method should be called on the `tail` of the stream, not on the `head` of the stream.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `AppendElements` class.",
       "reference": "this was wrong, the rest were just inconsistent :)"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to show the number of completed purchase requests, but I don't think that's what you're trying to do here. I think you're trying to show the number of completed purchase requests, but I don't think that's what you're trying to do here. I think you're trying to show the number of completed purchase requests, but I don't think that's what you're trying to do here. I think you're trying to show the number of completed purchase requests, but I don't think that's what you're trying to do here. I think you're trying to show the number of completed purchase requests, but I don't think that's what you're trying to do here. I think you're trying to show the number of completed purchase requests, but I don't think that's what you're trying to do here. I think you're trying to show the number of completed purchase requests, but I don't think that's what you're trying to do here. I think you're trying to show the number of completed purchase requests, but I don't think that's what you're trying to do here. I think you're trying to show the number of completed purchase",
+      "prediction": "I'm not sure what you mean by \"recently completed purchase requests\". Could you please provide more context?",
       "reference": "I gave them the EXACT SAME NAMES in my branch :)"
     },
     {
-      "prediction": "I think this should be `if _, statErr := os.Stat(dir); os.IsNotExist(statErr)` instead of `os.IsNotExist(statErr)`.",
+      "prediction": "I think this should be `if _, statErr := os.Stat(dir); !os.IsNotExist(statErr) {`",
       "reference": "What would you think stat'ing the directory first before doing the log+mkdirall and only proceeding if the directory does not exist? The logging might be less confusing (I'd be wondering why it was logging that it was creating the directory when I knew it already existed)."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `TraceContext` class, so that we don't have to call `GetKeepRate` every time we want to get the current keep rate.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place",
       "reference": "Sorry about the confusion, I'm trying to address that in the PR follow-up. If we ever have `Span` objects, then accessing their properties is going to be safe. The only question remaining is \"What is the runtime type for Scope.Span?\" and we just have to account for it when it is `Datadog.Trace.Span` and when it is not"
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here.",
+      "prediction": "I don't think this is a good idea. It's not clear what you're trying to test here. If you're trying to test that `JsonPrinter` is able to write to a file, you should test that it can write to a file. If you're trying to test that `JsonPrinter` is able to write to a stream, you should test that it can write to a stream. If you're trying to test that `JsonPrinter` is able to write to a stream, you should test that it can write to a stream. If you're trying to test that `JsonPrinter` is able to write to a stream, you should test that it can write to a stream. If you're trying to test that `JsonPrinter` is able to write to a stream, you should test that it can write to a stream. If you're trying to test that `JsonPrinter` is able to write to a stream, you should test that it can write to a stream. If you're trying to test that `JsonPrinter` is able to write to a stream, you should test that it can write to a stream. If you're trying to test that `JsonPrinter` is able to write to a stream, you should test that it",
       "reference": "I was using this imports for writing the results to file to more easily check that it was valid JSON. You can probably remove these `java.io` imports."
     },
     {
-      "prediction": "I'm not sure what you mean by \"parent, child, err := newPipe()\"",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate test for this.",
       "reference": "You should probably include a `json:...` annotation here."
     },
     {
@@ -28115,7 +28115,7 @@
       "reference": "can container ID > 255 chars? why are we doing this check?"
     },
     {
-      "prediction": "I don't think we need to add `size` to the list of prohibited fields.",
+      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. Is it that you want to make sure that the value of this field matches the one from :other? Or is it that you want to make sure that the value of this field doesn't match the one from :other? I'm not sure what you're trying to do here.",
       "reference": "*\"This **field field** prohibits :other from being present.\"*, **field** word repeated is right?"
     },
     {
@@ -28123,23 +28123,23 @@
       "reference": "nit: no need to add an alias for this case."
     },
     {
-      "prediction": "I'm not sure what you mean by `logEnv`? I think it's just the name of the environment variable that quic-go uses to set the log level.",
+      "prediction": "I don't think we need to change the default value of `logEnv` to `QUIC_GO_LOG_LEVEL`.",
       "reference": "Or `QUIC_LOG_LEVEL`. Which one do you prefer?"
     },
     {
-      "prediction": "I think this should be `if *virtualDiscDesc.CapacityAllocationUnits == \"\"` instead of `if *virtualDiscDesc.CapacityAllocationUnits == nil`",
+      "prediction": "I think this should be `if *virtualDiscDesc.CapacityAllocationUnits == \"\" { allocationUnits = \"byte\" } else { allocationUnits = *virtualDiscDesc.CapacityAllocationUnits }`",
       "reference": "Minor: you can set it to byte here and only set it to *virtualDiscDesc.CapacityAllocationUnits if that's not nil/\"\". Saves two lines"
     },
     {
-      "prediction": "I'm not sure I understand what you mean by \"arbitrary attributes\" in this context. Can you give an example of what you mean by \"arbitrary attributes\"?",
+      "prediction": "I'm not sure I understand what you mean by \"arbitrary attributes\".",
       "reference": "While reading this I found that it makes actually little sense for \"beers\" to have a \"fingerprint\". We might want to do another pass on the examples here to use something that actually makes more sense to the reader. This could be done in another issue."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `asMap()` on a `Multimap` that has been converted to a `Map`.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `asMap()` on a `Multimap`.",
       "reference": "Thank you! That's better, especially the conversion test should not test the mkString method :)"
     },
     {
-      "prediction": "I think it's better to use `watchdog.cancellableSendMessage` instead of `textInfos.offsets.OffsetsTextInfo._getPointFromOffset` because `offsets.OffsetsTextInfo._getPointFromOffset` is not thread safe.",
+      "prediction": "I think this should be `watchdog.cancellableSendMessage(self.obj.windowHandle, SCI_POSITIONFROMPOINT, None, offset)`",
       "reference": "You're basically converting client to screen coordinates here, doing it manually. Is there a specific reason why you aren't using clientToScreen here? Does it fail?"
     },
     {
@@ -28147,7 +28147,7 @@
       "reference": "This needs to be done for server-side copies too, earlier in the function."
     },
     {
-      "prediction": "I'm not sure what you mean by \"offline_access\" is used to request issuance of a refresh_token. I think you meant to say \"offline_access\" is used to request issuance of a refresh_token and the refresh_token is used to request issuance of an access_token.",
+      "prediction": "I think we should remove the `oidc.ScopeOfflineAccess` from the list of scopes.",
       "reference": "Do we want to add in `profile` here as well so we request access to the end user's default profile claims like name?"
     },
     {
@@ -28159,11 +28159,11 @@
       "reference": "Please back out the import changes in files you haven't touched. I think these happen if you run goimports without having the vendor directory populated"
     },
     {
-      "prediction": "I don't think this is a good idea. I think we should be able to do this with a single query.",
+      "prediction": "I don't think this is a good idea. I think it's better to use the `subquery` instead of `dept_ss_dv`",
       "reference": "Many tests in this class seem to have just been fortunate that `SolrIndexSearcher` ignored `fl` and retrieved all fields when not using lazy loading."
     },
     {
-      "prediction": "I don't think we need to change the description here.",
+      "prediction": "I'm not sure if this is the right place for this, but I think we should move this to the `scapy.contrib` module.",
       "reference": "Is this really needed?"
     },
     {
@@ -28175,7 +28175,7 @@
       "reference": "DO we want to have >= here? Or =="
     },
     {
-      "prediction": "I'm not sure what you mean by this, but I think it should be `CoreTags.Env` instead of `Env`.",
+      "prediction": "I think this should be `CoreTags` instead of `CoreTags.Env`.",
       "reference": "Can you also add this `\"version\"` tag to the CoreTags? Now that we're targeting the service/env/version trio"
     },
     {
@@ -28183,7 +28183,7 @@
       "reference": "This entry will be incompatible with the currently implemented formatting rules. Maximum 120 characters per line."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `Beaker::CLI` module.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to move this into the `Beaker::CLI` module.",
       "reference": "Let's call this color_host_output or some such - preserve_host_output makes it sound like you won't get any output without this being set."
     },
     {
@@ -28191,11 +28191,11 @@
       "reference": "suggestion: if we perhaps make `attributes` a getter in `virtualNode`, it does look seamless to access the property, same as what we have done for `isFocusable` or `tabbableElements`. `node.attributes` can become `virtualNode.attributes`"
     },
     {
-      "prediction": "I don't think this is needed anymore.",
+      "prediction": "I don't think this should be here. It's in the Playable interface, so it should be in Playable as well.",
       "reference": "I think a float value fits better."
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.",
+      "prediction": "I don't think we need to do this.",
       "reference": "This should be (POST,DELETE) `/pss/subscribe/{topic}` for subscriptions and there should be `/pss/send/{topic}` for sending."
     },
     {
@@ -28203,11 +28203,11 @@
       "reference": "Closing over the closure arguments is a neat trick :+1: Love it :100:"
     },
     {
-      "prediction": "I think this is a good test, but I'm not sure if it's the best way to do it. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to me what the problem is here. It's not clear to",
+      "prediction": "I'm not sure what you mean by \"case sensitivity is on\" here. Is it referring to the case sensitivity of the field name or the case sensitivity of the field value? If the field name is case sensitive, then the field value should not be case sensitive. If the field value is case sensitive, then the field name should not be case sensitive.",
       "reference": "Does this need to be a block or can it be an expression?"
     },
     {
-      "prediction": "I don't think this is necessary. We can just use `req.getQueryString()` instead of `req.getQueryString()`.",
+      "prediction": "I don't think this is necessary.",
       "reference": "req.getQueryString() != null is not necessary since same check is already done in allowedPostRequest"
     },
     {
@@ -28219,11 +28219,11 @@
       "reference": "here is `:seconds` missing again"
     },
     {
-      "prediction": "I think this is a bit of a mix-up. `Mailer.stubs` and `Mailer.stubs(method_name => mail)` are two different things. `Mailer.stubs(method_name => mail)` is the same as `Mailer.stubs(method_name => Mailer.stubs(method_name => mail))`. `Mailer.stubs(method_name => Mailer.stubs(method_name => mail))` is the same as `Mailer.stubs(method_name => Mailer.stubs(method_name => Mailer.stubs(method_name => mail)))`. `Mailer.stubs(method_name => Mailer.stubs(method_name => Mailer.stubs(method_name => Mailer.stubs(method_name => Mailer.stubs(method_name => Mailer.stubs(method_name => Mailer.stubs(method_name => Mailer.stubs(method_name => Mailer.stubs(method_name => Mailer.stubs(method_name => Mailer.stubs(method_name => Mailer.stubs(method_name => Mailer.stubs(method_name => Mailer.stubs(method_name => Mailer.stubs(method_name => Mailer.stubs(method_name => Mailer.stubs(method_name => Mailer.stubs(method_name => Mailer.stubs(method_name => Mailer.stubs(method_name => Mailer.st",
+      "prediction": "I think this is a bit of a red herring. The `deliver: true` in the `Mailer.stubs` line is just a way to make sure that the `deliver` method is actually called. If you don't call `deliver`, then the `deliver: true` will be ignored.",
       "reference": "Changed this helper to also get class name."
     },
     {
-      "prediction": "I think this should be `ACCEPT_SSL_CERTS` instead of `acceptSslCerts`.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `CapabilityType` interface.",
       "reference": "I think there's another spot for this in DefaultCapabilityMatcher"
     },
     {
@@ -28231,23 +28231,23 @@
       "reference": "Why the rename from PONY_SCHED_BATCH ? ACTOR_DEFAULT_BATCH is less meaningful to me than SCHED_BATCH."
     },
     {
-      "prediction": "I'm not sure what you mean by \"replace this with a queries to pick reasonable gas price and limits.\"",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this",
       "reference": "Let's be sure we have an issue that tracks this, filed against testnet."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `SIN` constructor.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "There should be no space before !Buffer"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to remove the `padding` from the `div` that contains the `p` tag. Is this what you're trying to achieve?",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `storiesOf` function.",
       "reference": "Same here, we need the default padding for this story."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to get the number of bytes that this user's listens take in the dump file, but I'm not sure what you're trying to do with the `offset` and `bytes_written` variables. I think you're trying to get the number of bytes that this user's listens take in the dump file, but I'm not sure what you're trying to do with the `offset` and `bytes_written` variables. I think you're trying to get the number of bytes that this user's listens take in the dump file, but I'm not sure what you're trying to do with the `offset` and `bytes_written` variables. I think you're trying to get the number of bytes that this user's listens take in the dump file, but I'm not sure what you're trying to do with the `offset` and `bytes_written` variables. I think you're trying to get the number of bytes that this user's listens take in the dump file, but I'm not sure what you're trying to do with the `offset` and `bytes_written` variables. I think you're trying to get the number of bytes that this user's listens take",
+      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to get the number of bytes written to the file, but I'm not sure what you're trying to do with the `bytes_written` variable.",
       "reference": "I think this should go away, its noise in the grand scheme of things."
     },
     {
-      "prediction": "I think we should remove the `if repo.IsPrivate` check here.",
+      "prediction": "I think this should be `if err != nil { return fmt.Errorf(\"getRepositoriesByForkID: %v\", err) }`",
       "reference": "Maybe just call `ioutil.WriteFile` with 0 bytes? And Make an error log `log.Error` if any error occurs."
     },
     {
@@ -28255,27 +28255,27 @@
       "reference": "`this.ieService_` should be initialized to null in the constructor."
     },
     {
-      "prediction": "I think this should be `ifaceMatch` instead of `ifacePrefix`?",
+      "prediction": "I think we can remove the `ifaceMatch` field and just use the `prefix` field.",
       "reference": "I just noticed that we use Return here, when we have logically allowed a packet, whereas in the forward chain we use AcceptAction. Do you know why that is?"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. The `getProcucers()` method returns a `Collection` of `PojoProducerMeta` objects, but the `getProducers()` method returns a `Collection` of `PojoProducerMeta` objects as well. Is this what you're trying to do?",
+      "prediction": "I'm not sure I understand what you're trying to do here. Is it that you want to get a list of all the pojo producers? If that's the case, then you should be able to just call `getProcucers()` and it will return a list of all the pojo producers. If you want to get a list of all the pojo producers that have been registered, then you should be able to call `getProducers()` and it will return a list of all the pojo producers that have been registered. If you want to get a list of all the pojo producers that have been created, then you should be able to call `getProducers()` and it will return a list of all the pojo producers that have been created. If you want to get a list of all the pojo producers that have been updated, then you should be able to call `getProducers()` and it will return a list of all the pojo producers that have been updated. If you want to get a list of all the pojo producers that have been deleted, then you should be able to call `getProducers()` and it will return a list of all the pojo producers that have been deleted. If you want to get",
       "reference": "This is public method , we need to deprecated this method first and add new updated method for it."
     },
     {
-      "prediction": "I think this should be `if newNode.NetAddress == \"\"` instead of `if newNode.NetAddress == \"\" {`",
+      "prediction": "I think this should be `if newNode.NetAddress == \"\"` instead of `if newNode.NetAddress == \"\" && newNode.IsRelay`",
       "reference": "I think that you don't want to have these workarounds; you want to make sure that the relayTemplates is configured correctly. If not, we need to fix it there."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `quorumCompatibilityMode` parameter to the `ProtocolScheduleBuilder` constructor.",
+      "prediction": "I'm not sure if this is the best place to put this, but I think it's a good place to put it, since it's the only place where we need to set the `quorumCompatibilityMode`.",
       "reference": "This field is not needed."
     },
     {
-      "prediction": "I don't think this is a good idea. The reason is that it's not clear to the user what they need to do to cancel the subscription.",
+      "prediction": "I don't think we need to do this.",
       "reference": "Put a comma after the last parameter of a multiline method call."
     },
     {
-      "prediction": "I don't think we need to use the `address` package here. We can just use the `big` package.",
+      "prediction": "I don't think we need to use `big` here. We can just use `int64` and `rand.Int63()` to generate a random number.",
       "reference": "move to line 18 below"
     },
     {
@@ -28283,23 +28283,23 @@
       "reference": "Simple Storage **Service**"
     },
     {
-      "prediction": "I think we can remove the `end` from the `it \"strips whitespace for each row\"` test.",
+      "prediction": "I think this should be `root.example(\"example\") {|example| example.reporter.message(\"message\")}` instead of `root.example(\"example\") {|example| example.reporter.message(\"message\")}`",
       "reference": "Thats odd, I'd actually not expect this output at all..."
     },
     {
-      "prediction": "I'm not sure what you mean by \"1.0.x\" and \"1.1.x\"",
+      "prediction": "I think it's better to use `travis_version` instead of `go_version_aliases`",
       "reference": "As a side note, I get why this is up here (sort order), but it'd be easier to not forget to update it if it were down next to `1.x` -- would it be acceptable to make that change the next time I make this sort of PR? :smile: :innocent: (don't want to hold this one up since folks are blocked on getting this one in, it's a pretty superficial change, and I probably won't have cycles again for a few days to update the PR with the change :sweat_smile:)"
     },
     {
-      "prediction": "I'm not sure what you mean by \"createFlexibleConfigWithAccountPermissioningDisabledShouldReturnEmpty\"",
+      "prediction": "I don't think this is a good idea. It would be better to create a `SmartContractPermissioningConfiguration` with `SmartContractAccountAllowlistEnabled` set to `false` and `SmartContractAccountAllowlistDisabled` set to `true` and then create a `PermissioningConfiguration` with `SmartContractAccountAllowlistEnabled` set to `false` and `SmartContractAccountAllowlistDisabled` set to `false` and `SmartContractAccountAllowlistEnabled` set to `true` and `SmartContractAccountAllowlistDisabled` set to `false` and `SmartContractAccountAllowlistEnabled` set to `false` and `SmartContractAccountAllowlistDisabled` set to `false` and `SmartContractAccountAllowlistEnabled` set to `false` and `SmartContractAccountAllowlistDisabled` set to `false` and `SmartContractAccountAllowlistEnabled` set to `false` and `SmartContractAccountAllowlistDisabled` set to `false` and `SmartContractAccountAllowlistEnabled` set to `false` and `SmartContractAccountAllowlistDisabled` set to `false` and `SmartContractAccountAllowlistEnabled` set to `false` and `SmartContractAccountAllowlistDisabled` set to `false",
       "reference": "this class is permissioning so let's keep \"Onchain\" here"
     },
     {
-      "prediction": "I don't think we need to change anything here.",
+      "prediction": "I don't think this is needed.",
       "reference": "we can be more specific to call out the it is \"AutoRest C# code generator\"?"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. The `VirtualNode` class should be a subclass of `axe.AbstractVirtualNode`, not a direct subclass of `axe.AbstractVirtualNode`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `VirtualNode` class that extends `axe.AbstractVirtualNode` and has a `boundingClientRect` property.",
       "reference": "Ditto for not adding this to the axe namespace."
     },
     {
@@ -28311,11 +28311,11 @@
       "reference": "Would it make sense to include an `Untrust` as well? If I were playing around with this on the CLI I wouldn't want to make a change I couldn't undo."
     },
     {
-      "prediction": "I don't think this is needed. The `getSolrRecord` method is already defined in the `AbstractSolrBackendFactory` class.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "It might be better to call this `$createRecordMethod` since it's not a full PHP callback, just a method name for the plugin manager."
     },
     {
-      "prediction": "I don't think we need to use `EventDispatcherInterface` here. We can use `Thelia\\Core\\Event\\Cart\\CartEvent` and `Thelia\\Core\\Event\\Currency\\CurrencyChangeEvent` directly.",
+      "prediction": "I don't think we need to use `EventDispatcherInterface` here. We can use `Thelia\\Core\\Event\\Cart\\CartEvent` directly.",
       "reference": "remove this line"
     },
     {
@@ -28323,23 +28323,23 @@
       "reference": "I've never seen this syntax before, it's still just an array, the difference is that it's an array of MainMenuItems instead of an array of arrays."
     },
     {
-      "prediction": "I think this should be `ole32.dll` instead of `ole32full.dll`?",
+      "prediction": "I think this should be `str_case_prefix(name, \"API-MS-Win-Core-Appinit-L1-1\")` instead of `str_case_prefix(name, \"API-MS-Win-Core-Appinit-L1-1\") || str_case_prefix(name, \"API-MS-Win-Core-Com-L1-1\")`",
       "reference": "nit: to match the others: s/private/Private/"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the number of active peers that are not connected to the network. I think you want to get the number of active peers that are connected to the network, right?",
+      "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bad idea to use `ReadOnlyCollection` in this case.",
       "reference": "Maybe just IEnumerable? Not sure myself."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a `TestIcebergSourceHiveTables.currentIdentifier` property.",
       "reference": "do we need this change?"
     },
     {
-      "prediction": "I think this should be `if acc.Name == globalAccountName { ... }` instead of `if acc.Name == globalAccountName { a = s.gacc; ... }`",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `Account` struct.",
       "reference": "Would want @matthiashanel to have a look since if I recall he had to add the shallowCopy() to fix some bugs during reload. That being said, since I believe the $G account cannot referenced in configurations, this should not be a problem, but Matthias has looked at this in more details in the past."
     },
     {
-      "prediction": "I think we can remove the `GetVolumeStatus` and `GetVolumeNamespace` methods.",
+      "prediction": "I think this should be `if len(volInfo.Volume.Status.Reason) > 0` instead of `if len(volInfo.Volume.Status.Reason) > 0 && len(volInfo.Volume.Status.Reason) > 0`",
       "reference": "The descriptions are incorrect"
     },
     {
@@ -28351,15 +28351,15 @@
       "reference": "Please only indent this by four spaces."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to generate a random string of length `n`, but you're using `rand.Int63()%int64(len(letters))` instead of `rand.Int63()%int64(len(letters))%len(letters)`.",
+      "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `rand.New` here. You can just use `rand.Int63()` to generate a random number between 0 and 63.",
       "reference": "What's the reason behind these characters?"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to send notifications to observers. If you want to send notifications to observers, you should use the `send_notification_email` method instead of the `deliver_new_cart_emails` method. The `deliver_new_cart_emails` method is used to send a new cart notification email to the observers, while the `send_notification_email` method is used to send a cart notification email to the observers.",
+      "prediction": "I'm not sure what you're trying to do here. I think you're trying to mock the `send_notification_email` method, but I'm not sure if that's what you're trying to do here.",
       "reference": "Minor: The name of this specs seems a little off now"
     },
     {
-      "prediction": "I'm not sure what you mean by \"compile time expressions not yet supported\". I think it's more accurate to say that it's not yet supported by the compiler.",
+      "prediction": "I'm not sure what you mean by \"compile time expressions not yet supported\". I think it's more accurate to say \"compile time expressions are not yet supported\" or \"compile time expressions are not supported in this version of the compiler\".",
       "reference": "I'd suggest using `ast_error_continue` here to get the `apply` message in the `Info` part of the error report."
     },
     {
@@ -28371,7 +28371,7 @@
       "reference": "Use const for \"user\", same as below"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `Newsletter` class, since it's used by other classes as well.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate method for setting the `unsubscribed` field.",
       "reference": "->setUnsubscribed(false) would be better :)"
     },
     {
@@ -28379,31 +28379,31 @@
       "reference": "I now think singular `Sport` is better, but I will wait for the first round of feedback before updating."
     },
     {
-      "prediction": "I think it's a good idea to initialize `self.timestamp` as soon as possible.",
+      "prediction": "I think it's better to initialize the timestamp as soon as possible, so that we don't have to wait for it to be set.",
       "reference": "Don't you need = something ?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"required_flags_string.size()\"",
+      "prediction": "I'm not sure what you mean by \"required_flags_string.size()\". I think it should be `required_flags_string.size() == required_flags.size()`.",
       "reference": "Looks like this could be `const` (I realize it wasn't like that before)?"
     },
     {
-      "prediction": "I don't think this is a good idea. The `DatabasePreviewType` enum should be a `Map`, not a `Map`.",
+      "prediction": "I don't think we need to change this. It's the same as before.",
       "reference": "Maybe just `FAILED`. We can't be sure loading was the thing that failed."
     },
     {
-      "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to move it to the top of the file.",
+      "prediction": "I'm not sure what you mean by `params.id` in this context. It looks like you're trying to get the `id` from the `params` object, but I'm not sure what you're trying to do with it. Could you provide more context or clarify what you're trying to achieve with `params.id`?",
       "reference": "You have replaced single quotes with double ones, this fails linting and our current coding style. Please fix this, otherwise it's a whopping of 1200 LoC while in reality it should be rather small."
     },
     {
-      "prediction": "I don't think this is needed.",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to make this a `final` field.",
       "reference": "@danieloeh @TomHennen. Some of these files are using spaces, the others use tabs. Is there a project wide preference? I personally like spaces, because they are consistent across editors"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. What is `@configuration`? What is `@document`? What is `@view_context`? What is `@counter`? What is `@blacklight_config`? What is `@document`? What is `@view_context`? What is `@configuration`? What is `@counter`? What is `@document`? What is `@view_context`? What is `@configuration`? What is `@counter`? What is `@document`? What is `@view_context`? What is `@configuration`? What is `@counter`? What is `@document`? What is `@view_context`? What is `@configuration`? What is `@counter`? What is `@document`? What is `@view_context`? What is `@configuration`? What is `@counter`? What is `@document`? What is `@view_context`? What is `@configuration`? What is `@counter`? What is `@document`? What is `@view_context`? What is `@configuration`? What is `@counter`? What",
+      "prediction": "I'm not sure I understand what you're trying to do here. What is the purpose of the `@counter` variable?",
       "reference": "I guess this is ok for backwards-compatibility? Maybe it'd be better to check arity in the helpers? Or just call it out in the release notes, because there are at least a couple projects on github that overrode `initialize`.."
     },
     {
-      "prediction": "I'm not sure what you mean by \"hack\" here. It's not a hack, it's a good practice to inject the `ServiceProvider` in the constructor.",
+      "prediction": "I'm not sure if this is a good idea, but I don't think it's a good idea to load the trigger manager in the constructor. I think it would be better to load it in the constructor, and then inject it into the `AzkabanWebServer` class.",
       "reference": "At some point, we would like to get rid of these custom injections as well. Looks Ok for now."
     },
     {
@@ -28411,19 +28411,19 @@
       "reference": "nit: Not a fan of \"fix\" in the name, but don't have a better suggestion"
     },
     {
-      "prediction": "I'm not sure what you mean by `???` in this case. I think it should be `??` instead of `???`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a default value for the `protocol` field in the `TabWidget` class. This way, if the user doesn't specify a protocol, it will default to `http` or `https` depending on the current URL.",
       "reference": "Since we're calling `self.tab_url(idx)` a third time here already, can you please add a `url = self.tab_url(idx)` somewhere above (e.g. after all the `fields[...] = ...` assignments) and change the calls here to `url.host()` etc.?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"command line interface installer\". Is that the same as \"CLI installer\"?",
+      "prediction": "I'm not sure if this is the best place to put this, but I think it's a good idea to have a `__init__.py` file in the `forseti_installer` package. This way, we can have a `__init__.py` file in the `forseti_installer` package, and we can have a `__init__.py` file in the `forseti_installer` package, and we can have a `__init__.py` file in the `forseti_installer` package, and we can have a `__init__.py` file in the `forseti_installer` package, and we can have a `__init__.py` file in the `forseti_installer` package, and we can have a `__init__.py` file in the `forseti_installer` package, and we can have a `__init__.py` file in the `forseti_installer` package, and we can have a `__init__.py` file in the `forseti_installer` package, and we can have a `__init__.py` file in the `forseti_installer` package, and we can have",
       "reference": "alphasort this import"
     },
     {
-      "prediction": "This is not a good way to reverse a number. It's better to use `std::reverse` or `std::reverse_copy` instead.",
+      "prediction": "I don't think you need to use `using namespace std;` in this case.",
       "reference": "remove this file!"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure",
+      "prediction": "I'm not sure I understand what you're trying to do here.",
       "reference": "You don't need to say `rune(' ')` - `' '` is already a `rune`."
     },
     {
@@ -28431,11 +28431,11 @@
       "reference": "We can't freeze this and then add something to it in the next line. The `freeze` on line 43 is sufficient. If Rubocop flags this we need to exclude it."
     },
     {
-      "prediction": "I think this should be `public interface Kind, E, T>`",
+      "prediction": "I think this should be `public interface Kind, E, T> {}`",
       "reference": "We call it Kind2 and move out of the `javaslang/control` package into the `javaslang`package. Maybe I will later generate Kind1..Kindn but that's another story."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a `db.capacity` field in the `Options` struct, so that we can set it when we create a new `DB` instance.",
       "reference": "i think it might be nicer to have a message like: `database capacity: %d chunks (%d bytes, %d megabytes)`. counting in bytes is so 90s :)"
     },
     {
@@ -28443,55 +28443,55 @@
       "reference": "The '.' in the key names are used to separate namespaces, NOT to separate words. How about azkaban.external_resources.resource_manager? ---- Why is it better than using the full name in the variable name e.g. RESOURCE_MANAGER_LINK ?"
     },
     {
-      "prediction": "I think this should be `using OpenTelemetry.Trace.Samplers;` instead of `using OpenTelemetry.Trace.Configuration;`",
+      "prediction": "I'm not sure why we need to use `OpenTelemetry.Trace.Samplers` instead of `OpenTelemetry.Samplers`.",
       "reference": "This seems to be duplicated with line 19?"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. I think it's better to use `wxLocale` instead of `xlocale.h` because `xlocale.h` is deprecated and `wxLocale` is the recommended way to get locale information.",
+      "prediction": "I'm not sure if this is necessary, but I think it's better to use `#include ` instead of `#include `. This is because `wx/xlocale.h` is a header file that is included by `wx/wx.h`, and `wx/wx.h` is a header file that is included by `stdwx.h`. If we include `wx/xlocale.h` in `stdwx.h`, then `wx/wx.h` will be included by `stdwx.h`, which means that `wx/wx.h` will be included by `stdwx.h`, which means that `wx/wx.h` will be included by `stdwx.h`, which means that `wx/wx.h` will be included by `stdwx.h`, which means that `wx/wx.h` will be included by `stdwx.h`, which means that `wx/wx.h` will be included by `stdwx.h`, which means that `wx/wx.h` will be included by `stdwx.h`, which means that `wx/wx.h` will be included by `stdwx.h`, which means that `wx/wx.h` will be included by `stdwx.h`, which",
       "reference": "This is wrong. xlocale.h is needed on OSX and maybe elsewhere too. This needs a test in configure to see if xlocale.h and uselocale() are available and an #if test here. Also, the NO_PER_THREAD_LOCALE stuff in configure.ac needs to be updated to include test for uselocale()."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this code snippet. It looks like you're trying to delete an access key from an IAM user, but I'm not sure what you're trying to achieve with this code snippet. Could you please provide more context or explain what you're trying to achieve with this code snippet?",
+      "prediction": "I'm not sure if this is the right place to put this code. I think it should go in the `main` method of the `DeleteAccessKey` class.",
       "reference": "AWS Identity and Access Management (IAM)"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.",
+      "prediction": "I'm not sure if this is the best way to do this, but it seems to work for me.",
       "reference": "Why did you have multiple function calls here instead of having one long array of supported mimeTypes? In line with your PR here, I think we might eventually see inline videos or inline pdf. It would be great to generalize this a bit."
     },
     {
-      "prediction": "I think this should be `from pyspark.sql.types import *` instead of `from pyspark.sql.types import LongType, StringType, TimestampType, NumericType`",
+      "prediction": "I'm not sure what you're trying to do with `NumericType` here. It's not a numeric type, it's just a type that can be used to represent a numeric value. If you want a numeric type, you should use `NumericType` instead of `LongType` or `TimestampType`.",
       "reference": "nit: shall we keep alphabetical order?"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. Can you give an example of what you're trying to do?",
+      "prediction": "I'm not sure what you're trying to do here. I think you're trying to do something like this:\r\n\r\n```javascript\r\nclass Realm {\r\n    constructor() {\r\n        this.objects = {};\r\n    }\r\n\r\n    objectForPrimaryKey(type, ...args) {\r\n        if (typeof type == 'function') {\r\n            type = objects.typeForConstructor(this, type);\r\n        }\r\n\r\n        let method = util.createMethod(objectTypes.REALM, 'objectForPrimaryKey');\r\n        return method.apply(this, [type, ...args]);\r\n    }\r\n}\r\n```",
       "reference": "We could just move the check for function into `typeForConstruction` to make this a one liner every time we need to do this."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I'm not sure if this is the right way to do it.",
+      "prediction": "I'm not sure if this is the right way to do this, but I think it would be better to send the Romaji for \"Tokyo\" and then check that the word is displayed in the IME.",
       "reference": "A correct by unrelated change. We'll slide this one in without another word ;)"
     },
     {
-      "prediction": "I don't think we need to call `Caffe::set_phase(Caffe::SOLVER)` here.",
+      "prediction": "I don't think we need to set the device here.",
       "reference": "I feel that a slightly safer way is to do if (param_.has_device_id()) { Caffe::SetDevice(param_.device_id()); } just in case a user has hard-coded a device id outside the solver and does not specify the device id in the solver param. Currently, if nothing is set, the solver will always use the 0th device, which might not be desired."
     },
     {
-      "prediction": "I'm not sure what you mean by \"rawCode\" in this case. Is it something like this? `rawCode(multi(1)\\n  line(2)\\n    block(33))`?",
+      "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `rawCode` instead of `scriptEval` here.",
       "reference": "let's replace this example with something that won't fail in Python. Like \"for+if+print\""
     },
     {
-      "prediction": "`float2str` should be `str2float`",
+      "prediction": "`float2str` should be `str2float` instead of `float2str`",
       "reference": "Please remove the brackets and use `string_type` from `compat.py` module instead of `str` in `isinstance()`."
     },
     {
-      "prediction": "I think it's better to use `contractAddress` instead of `contractAddress` here.",
+      "prediction": "I don't think it's necessary to add `srcAddr` to the `AbstractAction` struct. The `srcAddr` field is only used by the `AbstractAction` struct, not by the `Execution` struct.",
       "reference": "line is 143 characters (from `lll`)"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `ParseNamespacedName` function.",
+      "prediction": "I don't think we need to check for `objName` here. We can just use `record.Id` here.",
       "reference": "It should follow a `continue`."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to set the working directory for the container to the value of the `WebWorkingDir` environment variable. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set the working directory for the container to the value of the `WebWorkingDir` environment variable. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set the working directory for the container to the value of the `WebWorkingDir` environment variable. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set the working directory for the container to the value of the `WebWorkingDir` environment variable. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set the working directory for the container to the value of the `WebWorkingDir` environment variable. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set the working directory for the container to the value of the `WebWorkingDir` environment variable. I'm not sure what you're trying to achieve",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have the `working_dir` in the `docker-compose.yml` file.",
       "reference": "Should this be DBWorkingDir?"
     },
     {
@@ -28499,7 +28499,7 @@
       "reference": "I think you can remove the whole line."
     },
     {
-      "prediction": "I don't think this is necessary. We don't need to use `clock` here. We can just use `time` instead.",
+      "prediction": "I don't think this is necessary. We don't need to use `clock` here. We can just use `time` here.",
       "reference": "File is not `goimports`-ed (from `goimports`)"
     },
     {
@@ -28507,7 +28507,7 @@
       "reference": "Not a big deal, but what is the value of adding this status condition for a failure to delete a client? It has some value for a dataverse admin, to know that the last attempt to harvest from a certain server resulted in a failure. Is it really useful to know that an attempt to delete a client failed? - should the startup check simply remove the \"delete in progress\" flag quietly instead? After all, seeing how the client is still there makes it somewhat clear that the attempt to get rid of it didn't work out, so they should try again? I may be missing some situation where it could actually be useful - so I'm open to hearing it."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.",
+      "prediction": "I don't think we need to use `MetricsConfig.forTable(table)` here. We can just use `MetricsConfig.fromProperties(properties)`.",
       "reference": "Can we also update the equality delete branch below?"
     },
     {
@@ -28519,11 +28519,11 @@
       "reference": "I also do not see any usages of this import. Is this a fix for a crash?"
     },
     {
-      "prediction": "I think we can remove the `if dependencygraph.ValidDependencies(task, engine.cfg) {` line.",
+      "prediction": "I think this should be `engine.updateTaskENIDependencies(task)` instead of `engine.updateTaskENIDependencies(task, engine.cfg)`.",
       "reference": "Feels like this needs to be invoked in `PostUnmarshalTask` since that's where most of the task setup happens."
     },
     {
-      "prediction": "I'm not sure what you mean by \"coalesce\" in this case. I think you meant to use `coalesce` instead.",
+      "prediction": "I think this should be `coalesce((select auth_db_name from AUTHS where auth_id = object_owner), 'DB__ROOT')` instead of `coalesce((select auth_db_name from AUTHS where auth_id = object_owner), 'DB__ROOT') --granteeName`",
       "reference": "I wonder what would happen if the granteeName becomes DB__ROOT but the granteeID is not DB__ROOT ID (33333) but something else."
     },
     {
@@ -28531,11 +28531,11 @@
       "reference": "Feel like this should probably come into this tool as a flag rather than it just grabbing an env var internally?"
     },
     {
-      "prediction": "I think this should be `setParameter('handle', nameOrHandle)` instead of `setParameter('name', nameOrHandle)`.",
+      "prediction": "I think it's better to use `setParameter('handle', nameOrHandle)` instead of `setParameter('name', nameOrHandle)`.",
       "reference": "This should only be sent if the driver is speaking to a W3C conformant remote, so we need an if-condition check like we have in the Python bindings."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `contact_your_mentor.html.erb` file.",
       "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping."
     },
     {
@@ -28543,7 +28543,7 @@
       "reference": "nit: folders are always a numeric ID, projects as given by CAI use project number for ancestry"
     },
     {
-      "prediction": "I think this should be `ErrBadNetwork` instead of `BadNetwork`?",
+      "prediction": "I don't think this is a good idea. We should have a better way of detecting bad network.",
       "reference": "is this used anywhere?"
     },
     {
@@ -28551,15 +28551,15 @@
       "reference": "change pkg_errors to errors. Keep it consistent across all the files."
     },
     {
-      "prediction": "I'm not sure what you mean by \"unreviewed\", \"confirmed\", \"false_positive\"",
+      "prediction": "I'm not sure what you mean by \"unreviewed\" or \"confirmed\" or \"false_positive\" in this context. I think you meant to say \"unreviewed\" or \"confirmed\" or \"false_positive\" in this context.",
       "reference": "I don't see any test cases which would test that fix dates are set properly on review status changes / storage events. For this reason please create some more test cases and also check my scenarios above."
     },
     {
-      "prediction": "I think this should be `if (method.DefaultResponse != null && method.DefaultResponse is CompositeType)` instead of `if (method.DefaultResponse != null && method.DefaultResponse is CompositeType)`",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add this check to the `NormalizeMethod` method. It's not clear to me if this is the right place to do this, but I think it would be a good idea to add this check to the `NormalizeMethod` method. It's not clear to me if this is the right place to do this, but I think it would be a good idea to add this check to the `NormalizeMethod` method. It's not clear to me if this is the right place to do this, but I think it would be a good idea to add this check to the `NormalizeMethod` method. It's not clear to me if this is the right place to do this, but I think it would be a good idea to add this check to the `NormalizeMethod` method. It's not clear to me if this is the right place to do this, but I think it would be a good idea to add this check to the `NormalizeMethod` method. It's not clear to me if this is the right place to do this, but I think it would be a good idea to add this check to the `NormalizeMethod` method",
       "reference": "This belongs to SwaggerModeler.cs `public override ServiceClient Build()`"
     },
     {
-      "prediction": "I don't think this is a good idea. We should use `autoColumnSize` plugin instead.",
+      "prediction": "I don't think this is a good idea. If you want to set column width on each render, you should use `AutoColumnSize` plugin.",
       "reference": "We could go further and directly give the tips of the `columns` property for someone (like me) who would like to specify some column width and let the others be autosized."
     },
     {
@@ -28567,15 +28567,15 @@
       "reference": "I think a `std::copy` with `std::back_inserter` will get this done in one call."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bad idea to return an error from a function that doesn't return an error. If you want to return an error, you should do so in the function that returns the error, not in the function that creates the error. For example, if you want to return an error, you should do so in the function that creates the error, not in the function that returns the error. For example, if you want to return an error, you should do so in the function that creates the error, not in the function that returns the error. For example, if you want to return an error, you should do so in the function that creates the error, not in the function that returns the error. For example, if you want to return an error, you should do so in the function that creates the error, not in the function that returns the error. For example, if you want to return an error, you should do so in the function that creates the error, not in the function that returns the error. For example, if you want to return an error, you should do so in the function that creates the error, not in the function that returns the error.",
+      "prediction": "I'm not sure if this is the right place to put it, but I think it should be in the `cryptoSetupServer` struct.",
       "reference": "In the future: s/QUIC 36/Version36/ to make grepping easier"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to set the value of a `checkbox` to either `on` or `off` based on the value of the `name` prop. Is this what you're trying to do? If so, I'm not sure what you're trying to do here, but it looks like you're trying to set the value of a `checkbox` to either `on` or `off` based on the value of the `name` prop. Is this what you're trying to do? If so, I'm not sure what you're trying to do here, but it looks like you're trying to set the value of a `checkbox` to either `on` or `off` based on the value of the `name` prop. Is this what you're trying to do? If so, I'm not sure what you're trying to do here, but it looks like you're trying to set the value of a `checkbox` to either `on` or `off` based on the value of the `name` prop. Is this what you're trying to do? If so, I'm not sure what you're trying to do here, but it looks like",
+      "prediction": "I don't think we need to do this.",
       "reference": "This is an example of why I prefer a flexible custom `render()` solution   'on'/'off' may not be the right value for every application. You have to make a lot of decisions even for very simple form fields :("
     },
     {
-      "prediction": "I think we can remove the `false` from the `activeFlowExportTimeout` and `idleFlowExportTimeout` fields.",
+      "prediction": "I think it's better to use `false` for `activeFlowExportTimeout` and `false` for `idleFlowExportTimeout` instead of `true` and `false`.",
       "reference": "we should also skip the e2e flow aggregator tests if the Flow Exporter feature is disabled."
     },
     {
@@ -28583,27 +28583,27 @@
       "reference": "We should initialize the observation in the constructor of the Script class - otherwise, we don't have this feature for mitmdump."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. Is it that you want to create a new `Index` object with a different `index_map` and `index_columns`? If that's the case, why not just use `self._kdf._internal.index_map` and `self._kdf._internal.index_columns` instead?",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a check here to make sure that `names` is a list of tuples.",
       "reference": "I would remove this line. Otherwise looks fine cc @ueshin"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `get_number_of_walked_blocks` here.",
+      "prediction": "I'm not sure what you mean by `get_number_of_walked_blocks`, but I think it should be `ledger_walker.walked_blocks.bucket_count ()`.",
       "reference": "Would it be better to remove that line alltogether if it not directly relevant?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.",
+      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it would be better to just remove the `__asm__ __volatile__(\"movd %%xmm0, %0\" : \"=g\"(rc));` and replace it with `__asm__ __volatile__(\"movd %%xmm0, %0\" : \"=g\"(rc));`",
       "reference": "Does \"FPU\" here include XMM/YMM/ZMM SIMD and not just x87 FPU/MMX?"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason you want to use `pp.MatchFirst` here?",
+      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to create a `TokValue` object from a `TokValueFile` object, but I'm not sure what you're trying to do with it. Could you please provide more context?",
       "reference": "I'm not sure if we need to store path as bytes, and then decode/escape it when printing or just store it as a unicode string (as done here.)"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this test, but I think it's a bit misleading. The `hostname -s` command is used to get the hostname of the system, and the `check_output` function returns the output of the command, which in this case is just the string \"instance\". So the output should be \"instance\" regardless of whether the system has an instance or not.",
+      "prediction": "I'm not sure what you mean by \"instance\" in this context. Is it the name of the instance, or something else? If it's the name of the instance, then it should be `instance1`, `instance2`, etc. If it's something else, then I'm not sure what you mean by \"instance\" in this context. Is it the name of the instance, or something else? If it's the name of the instance, then it should be `instance1`, `instance2`, etc. If it's something else, then I'm not sure what you mean by \"instance\" in this context. Is it the name of the instance, or something else? If it's the name of the instance, then it should be `instance1`, `instance2`, etc. If it's something else, then I'm not sure what you mean by \"instance\" in this context. Is it the name of the instance, or something else? If it's the name of the instance, then it should be `instance1`, `instance2`, etc. If it's something else, then I'm not sure what you mean by \"instance\" in this context. Is it the name of the instance, or something else? If",
       "reference": "Why is this flipped? Looks unrelated and our pattern is `expected == returned`."
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `workshops` section.",
+      "prediction": "I don't think we need to use `online?` in this case. We can just use `is_in_person?` instead.",
       "reference": "Can the `h5` tags be pulled outside of the `if` block?"
     },
     {
@@ -28611,47 +28611,47 @@
       "reference": "From @PetrHeinz review: this should be also aliased (`ImageDirectoryStructureCreator`)"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a new APIServerPort, but you're not passing it to the `NewAPIServerPort` function. I think you should be passing it to the `NewAPIServerPort` function, but I'm not sure what you're trying to do here. I think you're trying to create a new APIServerPort, but you're not passing it to the `NewAPIServerPort` function. I think you should be passing it to the `NewAPIServerPort` function, but I'm not sure what you're trying to do here. I think you're trying to create a new APIServerPort, but you're not passing it to the `NewAPIServerPort` function. I think you should be passing it to the `NewAPIServerPort` function, but I'm not sure what you're trying to do here. I think you're trying to create a new APIServerPort, but you're not passing it to the `NewAPIServerPort` function. I think you should be passing it to the `NewAPIServerPort` function, but I'm not sure what you're trying",
+      "prediction": "I'm not sure what you mean by `DeepCopy` here. I think you meant to use `Copy` instead.",
       "reference": "Isn't AdditionalTags already of `Tags` type? If not, we should make it so, if it's not a breaking change"
     },
     {
-      "prediction": "I don't think this is necessary.",
+      "prediction": "I think this should be `using Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.Parallel;` instead of `using Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.Parallel = Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.Parallel;`",
       "reference": "Add blank line below license header."
     },
     {
-      "prediction": "I think this should be `machine.UART0.Configure(machine.UARTConfig{})` instead of `machine.UART0.Configure(machine.UARTConfig{})`",
+      "prediction": "I think this should be `initPWMClocks()` instead of `initPWMClocks()=initPWMClocks()`",
       "reference": "Perhaps this could be moved into `InitPWM`? I suspect not initializing the clocks will reduce power consumption."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a good idea to have a `first_question` method that returns the first question in the `questions` collection.",
+      "prediction": "Shouldn't this be `has_many :questions, -> { order(position: :asc) }, dependent: :destroy` instead of `has_many :questions, -> { order(position: :asc) }, dependent: :destroy`?",
       "reference": "I believe this `order` isn't tested."
     },
     {
-      "prediction": "I think we can remove the `#ifdef ESP32` and `#include ` from the `handle_metrics` function.",
+      "prediction": "I think we can remove the `#ifdef ESP32` from the `handle_metrics` function, since it's only used in the `esp_partition.h` file.",
       "reference": "No idea why it ended up in the code. You can remove the entire line."
     },
     {
-      "prediction": "I'm not sure what you mean by `iFromPeers` in this context. I think you meant `appliedToGroupNamesForRule`, right?",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `toAntreaPeerForCRD` function, since it will be called by the `toAntreaPeerForCRD` function in the `toAntreaPeerForCRD` function in the `toAntreaPeerForCRD` function in the `toAntreaPeerForCRD` function in the `toAntreaPeerForCRD` function in the `toAntreaPeerForCRD` function in the `toAntreaPeerForCRD` function in the `toAntreaPeerForCRD` function in the `toAntreaPeerForCRD` function in the `toAntreaPeerForCRD` function in the `toAntreaPeerForCRD` function in the `toAntreaPeerForCRD` function in the `toAntreaPeerForCRD` function in the `toAntreaPeerForCRD` function in the `toAntreaPeerForCRD` function in the `toAntreaPeerForCRD` function in the `toAntreaPeerForCRD` function in the `toAntreaPeerForCRD",
       "reference": "\"i\" and \"From\" is a bit duplicate, and should it be singular given the method name? I mean \"fromPeer\" or just \"from\"?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is the right way to do it.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a `scope` parameter to the `OAuth2AuthorizationRequest` constructor.",
       "reference": "Did you verify this isn't going to break any existing test assumptions? We probably shouldn't modify this as we don't know what impact this is having on existing tests. It may invalidate a test that has different expectations of the scopes."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `claims.System == RoleWriter` and `claims.System == RoleAdmin`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if `claims` is nil, and if so, return a `Result{Decision: DecisionDeny}` instead of a `Result{Decision: DecisionAllow}`.",
       "reference": "technically not necessary since reading from a nil dictionary will always return found = false, so this should already be handled"
     },
     {
-      "prediction": "I'm not sure what you mean by \"trigger the purge of RelaxedReclaim queue for a given node\"",
+      "prediction": "I don't think we need to change this.",
       "reference": "This can return bool. RelaxedReclaimPurge(nodeID string) (bool, error)"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure it's a good idea.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a test for this in the `GeneralStateReferenceTest` class.",
       "reference": "Is there something we can do to make this automatic? At the very least, can we add Shanghai, Cancun, etc. here now so that we don't forget them?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"skip-db-cleanup\" in this context. It's not clear to me what you're trying to do here.",
+      "prediction": "I don't think this is necessary. I think we can just use `--skip-db-cleanup` as an argument to the `add_arguments_to_parser` function.",
       "reference": "For boolean values, I'd rather have `argparse.SUPPRESS` as default value. No need to have a `(default: False)` in the help if it's a toggle."
     },
     {
@@ -28663,39 +28663,39 @@
       "reference": "should we do the same for os.Mkdir(criuOpts.WorkDirectory, 0755)?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"Automatically sends usage statistics and crash reports to Google\". I think you meant \"Automatically sends usage statistics and crash reports to Brave\".",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way",
       "reference": "@bbondy Two messages because the label and description differ very slightly in their wording..."
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `get_ymm_caller_saved` function.",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a comment here.",
       "reference": "\"currently\" implies it should and will be changed: so TODO i#?"
     },
     {
-      "prediction": "I'm not sure what you mean by `computed('i18n', () => { ... });`",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `computed` here.",
       "reference": "This should be `computed('i18n.locale'....`"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this test, but I'm not sure if it's a good idea. It's not clear what you're trying to do with this test, but I'm not sure if it's a good idea. It's not clear what you're trying to do with this test, but I'm not sure if it's a good idea. It's not clear what you're trying to do with this test, but I'm not sure if it's a good idea. It's not clear what you're trying to do with this test, but I'm not sure if it's a good idea. It's not clear what you're trying to do with this test, but I'm not sure if it's a good idea. It's not clear what you're trying to do with this test, but I'm not sure if it's a good idea. It's not clear what you're trying to do with this test, but I'm not sure if it's a good idea. It's not clear what you're trying to do with this test, but I'm not sure if it's a good idea. It's not clear what you're trying to do with this test, but I'm not sure if it's",
+      "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea.",
       "reference": "Wait, does this not work if we do `btl.reload`? That seems odd that we have to have the object in the same state."
     },
     {
-      "prediction": "I think it's a good idea to add a check to see if `eventListenerCount` is greater than 0 before adding the event listener.",
+      "prediction": "I think it's a good idea to add a check for `eventListenerCount > 0` in the `on` function.",
       "reference": "I seem to recall this being the cause of a bug at some point."
     },
     {
-      "prediction": "I don't think this is necessary. I think it's better to use `getAlbums().getSelectedCount()` instead of `getAlbums().getSelectedCount() >= 1`.",
+      "prediction": "I don't think we need to do this.",
       "reference": "Can you remove it from the menu instead of setting it hidden? Or are there any other trouble?"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea.",
+      "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure it's a good idea.",
       "reference": "And for \"execution \"."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you",
+      "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bit of a red herring. The `type_files` variable is just a placeholder for the path to the `types` directory, and it's not used anywhere else in the code. It's just there to make the code more readable.",
       "reference": "Do agents usually download these from puppetserver when applying a catalog?"
     },
     {
-      "prediction": "I'm not sure what you mean by `pony_asio_event_get_disposable` and `pony_asio_event_get_writeable`. I'm not sure what `pony_asio_event_fd` is supposed to do.",
+      "prediction": "I think this should be `pony_asio_event_get_writeable` instead of `pony_asio_event_get_disposable`.",
       "reference": "This should be `return (ev->flags == ASIO_DISPOSABLE);` because `ASIO_DISPOSABLE` has a value of `0` as defined in the enum in `asio.h` and because when `ev->flags` is assigned `ASIO_DISPOSABLE` it is assigned as `ev->flags = ASIO_DISPOSABLE` unsetting any other flags previously assigned."
     },
     {
@@ -28703,7 +28703,7 @@
       "reference": "this is not required, right? its the default already..."
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to have a separate error code for this.",
+      "prediction": "I think this should be `StatusCodeServerErrorRequiredLockIsNotHeld` instead of `StatusCodeServerErrorCannotReadFinalizedTLF`.",
       "reference": "\"contingent to\" -> \"contingent on\""
     },
     {
@@ -28711,15 +28711,15 @@
       "reference": "Does pandas throw an exception like this?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. The `pool_state_` and `state_data_` should be shared between the `DescriptorSet` and `DescriptorSetLayout`.",
+      "prediction": "I think this should be `pool_state_ = dev_data->GetDescriptorPoolState(pool);` instead of `pool_state_ = state_data->GetDescriptorPoolState(pool);`",
       "reference": "The point of the exercise has been to eliminate CoreChecks as an object dependency for DescriptorSet et. al."
     },
     {
-      "prediction": "I don't think this is needed.",
+      "prediction": "I don't think this is necessary.",
       "reference": "Why do we need to make so much more of this ScanContext public?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"multiple\" in this case. I think you meant to say `multiple` is `false`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be better to have a `choices` field in the `ProductFilterFormType` class, so that we can use it in the `ProductFilterForm` class as well.",
       "reference": "is choice_name not needed anymore?"
     },
     {
@@ -28731,7 +28731,7 @@
       "reference": "Why is this necessary? Just in order to get an indexed loop?"
     },
     {
-      "prediction": "I'm not sure what you mean by `zpoolListRequestRejectCounter prometheus.Gauge`",
+      "prediction": "I don't think we need to use `prometheus.GaugeVec` here. We can use `prometheus.CounterVec` instead.",
       "reference": "instead of using `prometheus.Gauge`, using `promethus.Counter` will be better."
     },
     {
@@ -28739,7 +28739,7 @@
       "reference": "maybe we should have a unit test for this and then just test one case in `spec/services/ncr/approval_manager_spec.rb` ?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate controller for approvals.",
       "reference": "Why is this necessary?"
     },
     {
@@ -28751,11 +28751,11 @@
       "reference": "This needs a more self-explaining name. Maybe `.is_focused`?"
     },
     {
-      "prediction": "I don't think we need to do this for now. I think we can just use `regenerate:expected:csazure` and `regenerate:expected:csazurefluent` for now.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate `regenerate:expected` task for each of the different types of expected data.",
       "reference": "minor: I'd add a space between `,` & `'paginggroup'`."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to add a `--reupload` flag to the `push` subcommand. This will allow the user to specify if they want to re-upload all the fragments, even if the server already has them.",
+      "prediction": "I'm not sure if this is a good idea, but I think it would be better to add a `--reupload` flag to the `push` command. This would allow the user to specify if they want to re-upload all fragments, even the ones the server already has.",
       "reference": "\"Re-upload all fragments (even if fragment is already in registry)\""
     },
     {
@@ -28763,19 +28763,19 @@
       "reference": "I don't see us ignoring the field. Are we sure Prometheus wouldn't refuse to load the rules?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to call `callSurfaceChanged()` in the `onResume()` method. This way, we don't need to call it in the `onPause()` method, and we don't need to call it in the `onDestroy()` method.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to call `callSurfaceChanged()` in the `onResume()` method.",
       "reference": "I wonder if we can just check if the mSession is active and then only call `setActive(true)` and `callSurfaceChanged()` if it isn't?"
     },
     {
-      "prediction": "I think this should be `EXE_MEMORY_FOR_PROBE_CACHE_IN_MB` and `EXE_MEMORY_FOR_UNPACK_ROWS_IN_MB` instead of `EXE_MEMORY_FOR_PROBE_CACHE_IN_MB` and `EXE_MEMORY_FOR_UNPACK_ROWS_IN_MB`.",
+      "prediction": "I think it's better to use `DDui___(EXE_MEMORY_FOR_UNPACK_ROWS_IN_MB, \"1000\")` instead of `EXE_MEMORY_FOR_UNPACK_ROWS_IN_MB, \"100\"`.",
       "reference": "A default value of 100 MB maybe too small. I understand that this is good for mixed workloads, but do consider than plans with Unpack, especially when used for insert/upsert are simple. Unpack is always serial and part of master exe. Often there is only one in a query. The cost of having a low value here seems to be that queue length from unpack could be limited by this when we are loading a table with wide rows (even if actual data in row is not wide). We know from performance runs that queue length is critical to upsert load performance. This is a hunch on my part and could be misguided. It will be good to performance test for upsert of table with wide rows, if you think that is worthwhile."
     },
     {
-      "prediction": "I'm not sure what you're trying to do with `CreditBucketPool` and `DebitBucketPool`, but I'm not sure what you're trying to do with `CreditBucketPool` and `DebitBucketPool`, but I'm not sure what you're trying to do with `CreditBucketPool` and `DebitBucketPool`, but I'm not sure what you're trying to do with `CreditBucketPool` and `DebitBucketPool`, but I'm not sure what you're trying to do with `CreditBucketPool` and `DebitBucketPool`, but I'm not sure what you're trying to do with `CreditBucketPool` and `DebitBucketPool`, but I'm not sure what you're trying to do with `CreditBucketPool` and `DebitBucketPool`, but I'm not sure what you're trying to do with `CreditBucketPool` and `DebitBucketPool`, but I'm not sure what you're trying to do with `CreditBucketPool` and `DebitBucketPool`, but I'm not sure what you're trying to do with `CreditBucketPool` and `DebitBucketPool`, but I'm not sure what you're trying to do with `CreditBucketPool`",
+      "prediction": "I'm not sure what you mean by `Commit() error` here. I think you meant to say `Commit() error, err`?",
       "reference": "think we should pass in ctx, and use ctx.GreenlandHeight inside bucketPool to determine if create or not"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I'm not sure if this is the right way to do it.",
+      "prediction": "I'm not sure if this is the right way to do this, but I think it would be better to send the Romaji for \"Tokyo\" and then check that the word is displayed in the IME.",
       "reference": "A correct by unrelated change. We'll slide this one in without another word ;)"
     },
     {
@@ -28783,27 +28783,27 @@
       "reference": "Why remove this?"
     },
     {
-      "prediction": "I don't think you need to use `use Twig_Environment;` in this case. You can just use `Twig_Environment::getInstance();` instead.",
+      "prediction": "I don't think we need to use `Twig_Environment` here. We can use `Twig_Environment::getInstance()` instead.",
       "reference": "I still see some usages of not namespaced variants (look for Twig_ in project, about 42 matches). Is it intentional?"
     },
     {
-      "prediction": "I think we can remove the `seelog` import here, as it's not used anywhere.",
+      "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to use the `seelog` package to log messages, but I'm not sure what you're trying to achieve with this change. I'm not sure if it's a good idea to use the `seelog` package to log messages, but I'm not sure if it's a good idea to use the `seelog` package to log messages, but I'm not sure if it's a good idea to use the `seelog` package to log messages, but I'm not sure if it's a good idea to use the `seelog` package to log messages, but I'm not sure if it's a good idea to use the `seelog` package to log messages, but I'm not sure if it's a good idea to use the `seelog` package to log messages, but I'm not sure if it's a good idea to use the `seelog` package to log messages, but I'm not sure if it's a good idea to use the `seelog` package to log messages, but I'm not sure if it's a good idea to use the",
       "reference": "Is this a new dependency? Does this require a dep update?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `Print` function as well.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in a separate function, so that we don't have to call it every time we want to print a float or double.",
       "reference": "> opts.generate_hexfloat_in_json && **IsFloat**(type.base_type)"
     },
     {
-      "prediction": "I don't think this is necessary. The `Manifest` interface already has a `DockerfilePath()` method.",
+      "prediction": "I think this should be `string` instead of `[]byte`.",
       "reference": "As an alternative to this, we could also create a new method, like `Common() *AppManifest` This way we don't have to add a new method to the interface everytime we add a new field to the `AppManifest`. This is a nit though so it's up to you."
     },
     {
-      "prediction": "I'm not sure what you mean by \"harparser\". It's not a library, it's a command-line tool.",
+      "prediction": "I'm not sure if this is a good idea, but I think it's better to use `pip install -r requirements.txt` instead of `pip install -r requirements.txt --use-mirrors`",
       "reference": "As long as we have this feature as an inline script, I'm inclined to remove the dependency here. I'd suggest that we just try to import harparser and pytz and throw an error instructing the user to install the dependencies (catch for `ImportError`). In the long term, we probably want to include that in the mitmproxy core, but we first want to introduce a clean extension interface before that's going to happen. As soon as said interface is there, porting the inline script and adding the dependency again should be a breeze."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to set the base folder of this project. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set the base folder of this project. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set the base folder of this project. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set the base folder of this project. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set the base folder of this project. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set the base folder of this project. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set the base folder of this project. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set the base folder of this project. I'm not sure what you're trying to achieve with this, but it looks like you're trying to set the base",
+      "prediction": "I'm not sure what you're trying to do with this, but I think it's a bad idea to have a global variable like this.",
       "reference": "makes it work nice with vscode. all logic is now in `.gulp/*.iced` files"
     },
     {
@@ -28811,23 +28811,23 @@
       "reference": "should a similar change be done for findElement?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in a separate test.",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a test for `node.stats.count (nano::stat::type::requests, nano::stat::detail::requests_cached_late_votes)`.",
       "reference": "`+` -> ` + ` I guess. Same below"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don",
+      "prediction": "I'm not sure what you're trying to do here. I think you're trying to set `this.givenFeeSat = opts.fee ? opts.fee * util.COIN : opts.feeSat;` but you're not doing anything with it. I'm not sure what you're trying to do here. I think you're trying to set `this.givenFeeSat = opts.fee ? opts.fee * util.COIN : opts.feeSat;` but you're not doing anything with it. I'm not sure what you're trying to do here. I think you're trying to set `this.givenFeeSat = opts.fee ? opts.fee * util.COIN : opts.feeSat;` but you're not doing anything with it. I'm not sure what you're trying to do here. I think you're trying to set `this.givenFeeSat = opts.fee ? opts.fee * util.COIN : opts.feeSat;` but you're not doing anything with it. I'm not sure what you're trying to do here. I think you're trying to set `this.givenFeeSat = opts.fee ? opts.fee * util.COIN : opts.feeSat;`",
       "reference": "`typeof` is not a function - its an operator, and the standard way to use it is as `typeof foo !== ...` (i.e. no parenthesis). Also, I would personally use `opts.fee != null` instead (with a non-strict comparison, which also identifies `undefined` values because `null == undefined`)."
     },
     {
-      "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use the `include` block to replace the file with a warning. This way, we don't have to worry about whether the file exists or not, and we don't have to worry about whether the file is readable or not. I'm not sure if this is the right way to do this, but I think it's a good idea to use the `include` block to replace the file with a warning. This way, we don't have to worry about whether the file exists or not, and we don't have to worry about whether the file is readable or not. I'm not sure if this is the right way to do this, but I think it's a good idea to use the `include` block to replace the file with a warning. This way, we don't have to worry about whether the file exists or not, and we don't have to worry about whether the file is readable or not. I'm not sure if this is the right way to do this, but I think it's a good idea to use the `include` block to replace the file with a warning. This way, we don't have to worry",
+      "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to have a separate test for this. I'm not sure if this is the right way to do this, but I think it's a good idea to have a separate test for this. I'm not sure if this is the right way to do this, but I think it's a good idea to have a separate test for this. I'm not sure if this is the right way to do this, but I think it's a good idea to have a separate test for this. I'm not sure if this is the right way to do this, but I think it's a good idea to have a separate test for this. I'm not sure if this is the right way to do this, but I think it's a good idea to have a separate test for this. I'm not sure if this is the right way to do this, but I think it's a good idea to have a separate test for this. I'm not sure if this is the right way to do this, but I think it's a good idea to have a separate test for this. I'm not sure if this is the right way to do this, but I",
       "reference": "Is there a reason why you're not using Rspec `skip`? It allows to specify message and makes it clearly visible in test results which tests were skipped."
     },
     {
-      "prediction": "I'm not sure what you mean by `selector` and `syncsets` here. I'm not sure what you mean by `selector` and `syncsets` here. I'm not sure what you mean by `selector` and `syncsets` here. I'm not sure what you mean by `selector` and `syncsets` here. I'm not sure what you mean by `selector` and `syncsets` here. I'm not sure what you mean by `selector` and `syncsets` here. I'm not sure what you mean by `selector` and `syncsets` here. I'm not sure what you mean by `selector` and `syncsets` here. I'm not sure what you mean by `selector` and `syncsets` here. I'm not sure what you mean by `selector` and `syncsets` here. I'm not sure what you mean by `selector` and `syncsets` here. I'm not sure what you mean by `selector` and `syncsets` here. I'm not sure what you mean by `selector` and `syncsets` here. I'm not sure what you mean by `selector` and `syncsets` here. I'm not sure",
+      "prediction": "I don't think it's necessary to have a `FirstSyncSetsSuccessTime` field.",
       "reference": "how about \"all matching SyncSets and SelectorSyncSets\""
     },
     {
-      "prediction": "I think this should be `io::FileReader reader(config.geometries_path, io::FileReader::VerifyFingerprint);`",
+      "prediction": "I think it's better to use `VerifyFingerprint` instead of `HasNoFingerprint`.",
       "reference": "What is the logic behind `ReadVectorSize` reading `CountElement64`, then skipping `T` (in this case `unsigned`)? Naming doesn't cover what's actually happening here. Ideally I'd also take this through a `files` layer, any input as to how?"
     },
     {
@@ -28839,11 +28839,11 @@
       "reference": "`RW` means read/write. Why do we have it here, as part of a func name?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but it seems to work for me.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `context.createSocket(SocketType.SUB)` instead of `context.createSocket(SocketType.PUB)`. This is because `context.createSocket(SocketType.PUB)` will create a socket that will be used for both PUB and SUB, which is not what we want here.",
       "reference": "I'd keep this at `info` level..."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `h2o_http2_conn_write` function.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `h2o_http2_conn_write` function, since it's called by the `h2o_http2_conn_read` function.",
       "reference": "I think you missed this."
     },
     {
@@ -28851,11 +28851,11 @@
       "reference": "List all of the current TFMs so we know if this gets outdated. E.g. this breaks if we add 2.2."
     },
     {
-      "prediction": "I think we can remove the `GetXattr` check here.",
+      "prediction": "I think it's better to use `GetXattr` instead of `GetExportSpec` here.",
       "reference": "here, you want to use req.GetXattrOpt() referring to the in line 514 of api.proto. This will be nil if not provided. See the example above on line 801 on this file"
     },
     {
-      "prediction": "I'm not sure what you mean by \"isPlaying\" and \"wasSkipped\"",
+      "prediction": "I don't think this is necessary.",
       "reference": "I think this should be done outside LocalPSMP, but in `getNextInQueue`. The reason is that I want to reduce the dependence of the media players on the preferences and database. Also, it will then probably work on Chromecast."
     },
     {
@@ -28863,7 +28863,7 @@
       "reference": "Please remove it or remove all `std::` namespace prefixes."
     },
     {
-      "prediction": "I think this should be `package nodecontrol` instead of `package nodecontrol`",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "wait! I'm confused - is that an empty file ?!"
     },
     {
@@ -28879,55 +28879,55 @@
       "reference": "Let's keep using the regular expression to make sure that the token is well-formed. I think the regular expression should be altered instead of doing a substring."
     },
     {
-      "prediction": "I think this should be `this.delegate` instead of `this.back`?",
+      "prediction": "I don't think this is necessary. The `Array` constructor takes an `Object[]` as an argument, so we don't need to create a new `Object[]` in the `Array` constructor.",
       "reference": "All the operations are delegated to this entity, hence the rename. `back` can have too many meanings."
     },
     {
-      "prediction": "I think this should be `if skip_msg.nil?` instead of `if skip_msg.nil?`",
+      "prediction": "I think we should remove the `if` block here.",
       "reference": "@trevor-vaughan it looks like the spec failures are caused by the fact that although it was a great idea to put the guard clause here first & get the error case out of the way, the main code path has been erased when I assume it should be just below the guard clause."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a timeout to the `filter` function. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a timeout to the `filter` function. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a timeout to the `filter` function. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a timeout to the `filter` function. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a timeout to the `filter` function. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a timeout to the `filter` function. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a timeout to the `filter` function. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a timeout to the `filter` function. I'm not sure what you're trying",
+      "prediction": "I don't think this is necessary.",
       "reference": "Could you delete this constant?"
     },
     {
-      "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to export the `Disassembler` and `Exporter` parameters.",
+      "prediction": "I don't think this is necessary. We don't need to export the `Disassembler` class. We can just use the `Disassembler` class from the `System.Diagnostics` namespace.",
       "reference": "looks like this snuck in from your other change?"
     },
     {
-      "prediction": "I don't think this is necessary. I think we should just use `:amount` as the column name.",
+      "prediction": "I don't think this is necessary.",
       "reference": "These env vars are not set in any CF environment, on purpose, because we are moving away from using env vars to store role-based information and instead using the database. So in a CF environment, the wrong emails get used (the defaults, rather than what is in the db)."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `template` variable in the partial. This way, we don't have to hardcode the `template` variable in the partial, and we don't have to hardcode the `question` variable in the partial.",
+      "prediction": "I don't think we need to use the `template` variable here. We can just use the `question` variable.",
       "reference": "this partial is used also for previewing a template, did you test if still works?"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to get the user to select an app type. I'm not sure what you're trying to do here, but it looks like you're trying to get the user to select an app type. I'm not sure what you're trying to do here, but it looks like you're trying to get the user to select an app type. I'm not sure what you're trying to do here, but it looks like you're trying to get the user to select an app type. I'm not sure what you're trying to do here, but it looks like you're trying to get the user to select an app type. I'm not sure what you're trying to do here, but it looks like you're trying to get the user to select an app type. I'm not sure what you're trying to do here, but it looks like you're trying to get the user to select an app type. I'm not sure what you're trying to do here, but it looks like you're trying to get the user to select an app type. I'm not sure what you're trying to do here, but it looks like you're trying to get the",
+      "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to get the user to select an app type and then use that to create an ECR repository for the app. Is that correct? If so, how do you want to handle the case where the user selects an app type that doesn't match any of the available options?",
       "reference": "Would it be better to put like `Which Dockerfile would you like to use for %s?`"
     },
     {
-      "prediction": "I'm not sure if this is a good place to put this, but I think it should be in the `updateOne` method, since that's the only place where the `strict` option is used.",
+      "prediction": "I'm not sure what you mean by `strict` here. I think you meant to say `strict: true` or `strict: false`.",
       "reference": "You mistakenly removed `/docs` here, please add it"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I think it's a bad idea to return `null` here.",
+      "prediction": "I'm not sure what you mean by \"only valid after the file is closed\".",
       "reference": "I missed this earlier, but why does this say \"file blocks\"? This should probably be \"recommended split locations\"."
     },
     {
-      "prediction": "I don't think this is necessary.",
+      "prediction": "I don't think this is needed.",
       "reference": "Please change this to non-exported."
     },
     {
-      "prediction": "I think this should be `drstats->num_bbs` instead of `drstats->basic_block_count`.",
+      "prediction": "I think it's better to remove this assert.",
       "reference": "This is ignoring compatibility: it needs to check the size to ensure this field exists in the client."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add this check to the `RoundChangePayloadValidator` as well. It's not clear to me if this is the right place to do this, but I think it would be a good idea to add this check to the `RoundChangePayloadValidator` as well. It's not clear to me if this is the right place to do this, but I think it would be a good idea to add this check to the `RoundChangePayloadValidator` as well. It's not clear to me if this is the right place to do this, but I think it would be a good idea to add this check to the `RoundChangePayloadValidator` as well. It's not clear to me if this is the right place to do this, but I think it would be a good idea to add this check to the `RoundChangePayloadValidator` as well. It's not clear to me if this is the right place to do this, but I think it would be a good idea to add this check to the `RoundChangePayloadValidator` as well. It's not clear to me if this is the right place to do this, but I",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add this check to the `RoundChangePayloadValidator` as well.",
       "reference": "Do all the prepare authors also need to be unique? Or is it enough the we have minimumPrepareMessages. I guess I'm wondering if need a hasDuplicateAuthors check like in the RoundChangeCertificateValidator."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to keep the `_` in front of the package name. It's not a big deal, but it makes it clear that the package is for internal use only.",
+      "prediction": "I'm not sure if this is a good idea, but I think we should have a separate package for `regexp` and `promql`.",
       "reference": "we had some situations where we merged some promql bits then took them out. i'm not sure what's going on here, but unless your code actually needs promql (probably not?) let's remove this line."
     },
     {
@@ -28935,51 +28935,51 @@
       "reference": "Annotations in this hunk should follow PhpDoc style (above the occurrence, type first)"
     },
     {
-      "prediction": "I'm not sure what you mean by \"is not supported\" here. I think it's more accurate to say that it's not supported by the current implementation.",
+      "prediction": "I think this should be `if (type == BoundType.EXTENDS)` instead of `if (type == BoundType.EXTENDS)`",
       "reference": "This is an improvement - thanks! Could we rephrase slightly to not use the phrase \"is not supported\" -- instead stating _WHAT_ isn't valid please? e.g. maybe `String.format(\"Unsupported BoundType provided: %s\" type)` or something like that."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea to have a `procfh` field in this struct. It's not clear what it's used for, and it's not a good idea to have a `procfh` field in this struct.",
+      "prediction": "I don't think this is necessary. The `procfh` field is only used to store the file descriptor of the process, which is already stored in the `procfh` field of the `linuxWatcher` struct.",
       "reference": "nit: `procfd` seems more appropriate now?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `with_for_update()` here.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `with_for_update()` here.",
       "reference": "Let's not call it django. Maybe `auth_provider_headers`? `auth_headers`?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"multiple users\" and \"single user/pass\". Could you please clarify?",
+      "prediction": "I'm not sure what you mean by \"multiple users\" in this context. Is it referring to the number of users that can be authorized at the same time? If so, I'm not sure what you mean by \"token\" in this context. Is it referring to the number of tokens that can be authorized at the same time? If so, I'm not sure what you mean by \"single user/pass\" in this context. Is it referring to the number of users that can be authorized at the same time? If so, I'm not sure what you mean by \"single user/pass\" in this context. Is it referring to the number of users that can be authorized at the same time? If so, I'm not sure what you mean by \"single user/pass\" in this context. Is it referring to the number of users that can be authorized at the same time? If so, I'm not sure what you mean by \"single user/pass\" in this context. Is it referring to the number of users that can be authorized at the same time? If so, I'm not sure what you mean by \"single user/pass\" in this context. Is it referring to the number of users that can be authorized at the same time? If so,",
       "reference": "Should we mention TLS map here?"
     },
     {
-      "prediction": "I think this should be `PlayerIndicators` instead of `PlayerIndicatorsConfig`?",
+      "prediction": "I think this should be `Range` instead of `Color`?",
       "reference": "remove this empty line pl0x"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `Ncr::Dispatcher` class, so that it can be used in other places as well.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this method in the `NcrDispatcher` class, so that it can be called from anywhere in the code.",
       "reference": "Why not have this in the `Dispatcher`? Doesn't seem like NCR-specific functionality."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
+      "prediction": "I'm not sure what you're trying to do here. I don't think you need to create a new `core.ChainPack` for each test case. You can just use the same `core.ChainPack` for all the tests.",
       "reference": "If you need only test db, use `memdb.NewTestDB(t)`"
     },
     {
-      "prediction": "I'm not sure what you mean by \"forZeroContentLength does not complete the reader nor the writer\"",
+      "prediction": "I think this should be `if (!messageBody.IsEmpty && _keepAlive)` instead of `if (!messageBody.IsEmpty && _keepAlive)`.",
       "reference": "I'm not sure I like setting the IsEmpty property true for upgraded connections since it feels a middle misleading. Maybe we can leave the ForUpgrade class as is and change this condition to `if (!messageBody.IsEmpty && !messageBody.RequestUpgrade)` to make things more explicit."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this index, but I think it would be better to have a separate index on `client_data_id` and `client_data_type` rather than on `client_data_id` and `public_id`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a `public_id` column to the `proposals` table. This will allow us to uniquely identify each proposal, even if the `client_data_id` and `client_data_type` are the same.",
       "reference": "git checkout since this is unrelated to this PR? (running migrations also changes this for me -- not sure why it keeps going back and forth"
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `__init__` method of the `Signature` class.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it would make sense to put it in the `__init__` method of `_GenericTLSSessionInheritance` so that it can be used by subclasses of `_GenericTLSSessionInheritance` as well. I'm not sure if this is the right place to put it, but I think it would make sense to put it in the `__init__` method of `_GenericTLSSessionInheritance` so that it can be used by subclasses of `_GenericTLSSessionInheritance` as well. I'm not sure if this is the right place to put it, but I think it would make sense to put it in the `__init__` method of `_GenericTLSSessionInheritance` so that it can be used by subclasses of `_GenericTLSSessionInheritance` as well. I'm not sure if this is the right place to put it, but I think it would make sense to put it in the `__init__` method of `_GenericTLSSessionInheritance` so that it can be used by subclasses of `_GenericTLSSessionInheritance` as well. I'm not sure",
       "reference": "Is this change needed?"
     },
     {
-      "prediction": "I don't think we need to do this. We can just use `getAtomMapNumber` to get the atom map number.",
+      "prediction": "I'm not sure what you mean by `tmpInt >= 0 && tmpInt < 128`. I think you meant `tmpInt >= 0 && tmpInt < 128 && tmpInt % 128 == 0`.",
       "reference": "Isn't the % 128 redundant here?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to do this in a single test. We can do this in a single test if we want to, but I think we should be able to do this in a single test. We can do this in a single test if we want to, but I think we should be able to do this in a single test. We can do this in a single test if we want to, but I think we should be able to do this in a single test. We can do this in a single test if we want to, but I think we should be able to do this in a single test. We can do this in a single test if we want to, but I think we should be able to do this in a single test. We can do this in a single test if we want to, but I think we should be able to do this in a single test. We can do this in a single test if we want to, but I think we should be able to do this in a single test. We can do this in a single test if we want to, but I think we should be able to do this in a single test. We can do",
+      "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to do this in a single test. I think we should be able to do this in a single test. I think we should be able to do this in a single test. I think we should be able to do this in a single test. I think we should be able to do this in a single test. I think we should be able to do this in a single test. I think we should be able to do this in a single test. I think we should be able to do this in a single test. I think we should be able to do this in a single test. I think we should be able to do this in a single test. I think we should be able to do this in a single test. I think we should be able to do this in a single test. I think we should be able to do this in a single test. I think we should be able to do this in a single test. I think we should be able to do this in a single test. I think we should be able to do this in a single test. I think we should be able to do this in a single test. I think we",
       "reference": "Are you testing that the values are always false? I think you should test for setting values to true or false, right? Who is going to take action with these values?"
     },
     {
@@ -28991,47 +28991,47 @@
       "reference": "Why you can't use function here?"
     },
     {
-      "prediction": "I think we should remove the `go run` command.",
+      "prediction": "I think we should remove the `mockgen` call here.",
       "reference": "We should scope this down to only the methods we use."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to do something like this:\n\n```\nHashSet set = new HashSet();\nset.addAll(Arrays.asList(\"a\", \"b\", \"c\"));\n```\n\nIs this what you're trying to do?",
+      "prediction": "I'm not sure what you're trying to do here. I think you're trying to do something like this:\r\n\r\n```java\r\nHashSet set = new HashSet();\r\nset.add(\"a\");\r\nset.add(\"b\");\r\nset.add(\"c\");\r\nset.add(\"d\");\r\nset.add(\"e\");\r\nset.add(\"f\");\r\nset.add(\"g\");\r\nset.add(\"h\");\r\nset.add(\"i\");\r\nset.add(\"j\");\r\nset.add(\"k\");\r\nset.add(\"l\");\r\nset.add(\"m\");\r\nset.add(\"n\");\r\nset.add(\"o\");\r\nset.add(\"p\");\r\nset.add(\"q\");\r\nset.add(\"r\");\r\nset.add(\"s\");\r\nset.add(\"t\");\r\nset.add(\"u\");\r\nset.add(\"v\");\r\nset.add(\"w\");\r\nset.add(\"x\");\r\nset.add(\"y\");\r\nset.add(\"z\");\r\nset.add(\"A\");\r\nset.add(\"B\");\r\nset.add(\"C\");\r\nset.add(\"D\");\r\nset.add(\"E\");\r\nset.add(\"F\");\r\nset.add(\"G\");\r\nset.add(\"H\");\r\nset.add(\"I\");\r\nset.add(\"J\");\r\nset.add(\"K\");\r\nset.add(\"L\");\r\nset.add(\"M\");\r\nset.add(\"N\");\r\nset.add(\"O\");\r\nset.add(\"P\");\r\nset.add(\"Q\");\r\nset.add(\"R\");\r\nset",
       "reference": "Oh, thanks for catching - I thought I've catched all after changing `mkString(infix, prefix, suffix)` to `mkString(prefix, infix, suffix)`."
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `genclient.go` file. I'm not sure if this is the right place to put this, but I think it should be in the `genclient.go` file. I'm not sure if this is the right place to put this, but I think it should be in the `genclient.go` file. I'm not sure if this is the right place to put this, but I think it should be in the `genclient.go` file. I'm not sure if this is the right place to put this, but I think it should be in the `genclient.go` file. I'm not sure if this is the right place to put this, but I think it should be in the `genclient.go` file. I'm not sure if this is the right place to put this, but I think it should be in the `genclient.go` file. I'm not sure if this is the right place to put this, but I think it should be in the `genclient.go` file. I'm not sure if this is the right place to put this, but I think it should be in the `gen",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to add a `CertificateRequestReason` field to the `CertificateRequest` struct.",
       "reference": "Suggestion: `.. the CertificateRequest is ready for signing` - could we perhaps word this differently? I understand that in this case it will be the associated X.509 certificate that can now be signed, so maybe `the certificate is ready for signing` ? (Same with `CertificateRequestReasonDenied`)."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `accountID` in the `isLoading` condition.",
+      "prediction": "I think this should be `isLoading` instead of `accountID`.",
       "reference": "We should use `! isValidAccountID( accountID )` for the `accountID` checks."
     },
     {
-      "prediction": "I'm not sure what you mean by \"threading inventory through the executor to the RemoteTransport\". Could you please provide more context?",
+      "prediction": "I'm not sure what you mean by \"threading inventory through the executor to the RemoteTransport\"",
       "reference": "That alternative does seem better. Did you want to try to do it in this PR? It makes sense to me that the inventory would always be available before creating the executor."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but I think it's better to use `apt-get install -y puppet` instead of `apt-get install -y puppet-common` and `apt-get install -y puppet=#{opts[:version]}-1puppetlabs1`.",
+      "prediction": "I'm not sure what you're trying to do here. I don't think you need to do this. I think you should be able to do this with just `apt-get install -y puppet` and `apt-get install -y puppet-common`.",
       "reference": "Missing the `-y` argument which all other `apt-get install` commands have."
     },
     {
-      "prediction": "I think this should be a warning, not an error.",
+      "prediction": "I think this should be `pPipeline->graphicsPipelineCI.subpass >= pPipeline->rp_state->createInfo.subpassCount`",
       "reference": "So I think we are going to settle on the \"concise and elegant\" `PRI` macros as they are the safest option for now. Even though they make my eyes bleed a little..."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think we need to change anything here.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.",
       "reference": "Interesting, was this needed for a test case to pass? I figured if there is no opening brace, there is definitely no placeholder -- we don't even have to check for a closing one."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to change the return type of `action.ClassifyActions` to `[]*explorer.Transfer`.",
       "reference": "I think we want to provide getAction API instead"
     },
     {
-      "prediction": "I think this should be `if winVersion.winVersion.major >= 10` instead of `if not hasattr(sys, \"frozen\")`.",
+      "prediction": "I think this should be `winVersion.major >= 10` instead of `if not hasattr(sys, \"frozen\"):`",
       "reference": "There is also `winVersion.isWin10`. I think this should be converted to use the helper function. The helper has a note that it doesn't work in source copies, but looking at the implementation it looks equivalent to what you have here."
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `config/environments/development.rb` file. I'm not sure if this is the right place to put this, but I think it should be in the `config/environments/development.rb` file. I'm not sure if this is the right place to put this, but I think it should be in the `config/environments/development.rb` file. I'm not sure if this is the right place to put this, but I think it should be in the `config/environments/development.rb` file. I'm not sure if this is the right place to put this, but I think it should be in the `config/environments/development.rb` file. I'm not sure if this is the right place to put this, but I think it should be in the `config/environments/development.rb` file. I'm not sure if this is the right place to put this, but I think it should be in the `config/environments/development.rb` file. I'm not sure if this is the right place to put this, but I think it should be in the `config/environments/development.rb` file.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `config/initializers` so that it can be used in multiple specs.",
       "reference": "This doesn't seem like it should be part of this pull request."
     },
     {
@@ -29039,11 +29039,11 @@
       "reference": "Is the idea that `@product` (and `@workshop` for `workshops_controller`) would eventually go away here?"
     },
     {
-      "prediction": "I think it's better to use `uint64` instead of `int64` here.",
+      "prediction": "I don't think this is necessary.",
       "reference": "We should add those only once we have successfully synced to the BSC main net, we have a utility to generate those. Please remove for now"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. You're trying to set an environment variable from a file that doesn't exist, but you're returning the original environment variable instead of the new one. Is this what you're trying to do?",
+      "prediction": "I'm not sure I understand what you're trying to do here. You're trying to set an environment variable from a file that doesn't exist, but the `set_env_from_file` function returns the original environment variable. Is this what you're trying to do?",
       "reference": "And how is that related?"
     },
     {
@@ -29055,23 +29055,23 @@
       "reference": "This appears to be unused"
     },
     {
-      "prediction": "I think it's better to return the oldest Snapshot in the range, rather than the oldest Snapshot in the table.",
+      "prediction": "I think it's better to use `SnapshotUtil`'s `oldestSnapshot` method instead of this one.",
       "reference": "I think that \"table's state\" isn't clear enough. How about \"history of the table's current snapshot\" like the one below?"
     },
     {
-      "prediction": "I think this should be `false` instead of `true` in `instr_is_scatter` and `instr_is_gather`.",
+      "prediction": "I think this should be `false` instead of `true`.",
       "reference": "This looks like a bug: pretty sure there are scatter-gather instructions on AArch64. Ditto below."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but it seems to work for me.",
+      "prediction": "I'm not sure I understand what you're trying to do here. The `Inbound` struct has a `transport` field, but the `NewInbound` function doesn't seem to use it at all. Is it supposed to be used somewhere else in the code?",
       "reference": "No need to change this: id love if we changed as a team to unkeyed fields, it ends up catching a lot more at compile time, at minimal cost"
     },
     {
-      "prediction": "I'm not sure what you mean by \"environment passed in does not have any overrides\"",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a default value for the `AppName` field.",
       "reference": "Should this be in the parent struct? `AppManifest` since it's embedded to `LBFargateManifest` it'll get the method as well."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate package for this.",
+      "prediction": "I don't think we need to use `bufio` here. We can just use `io.Reader` and `io.Writer` directly.",
       "reference": "\"Openvpn check\" we could move this to separate prefix."
     },
     {
@@ -29083,47 +29083,47 @@
       "reference": "We don't return now?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in a separate file, so that it can be used in the `install` and `script` methods.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `retry: true` here.",
       "reference": "This might end up not doing exactly what we want (the retry only picks up the `go get`, not the `go build`, due to the `&&`)."
     },
     {
-      "prediction": "I don't think this is a good idea. The `ConsoleExporterOptions` class is not meant to be used directly. It is meant to be used by the `ConsoleExporter` class. If you want to use the `ConsoleExporterOptions` class, you should create a new instance of `ConsoleExporterOptions` and pass it to the `ConsoleExporter` constructor.",
+      "prediction": "I don't think this is a good idea. The `ConsoleExporterOptions` class is not meant to be used directly. It's meant to be used as a base class for other exporters.",
       "reference": "Is there a BOM change?"
     },
     {
-      "prediction": "I think we should remove the `REGISTRY_SERVICE_NAME` and `REGISTRY_VERSION` from the `Const` class.",
+      "prediction": "I think we should remove the `REGISTRY_SERVICE_NAME` and `REGISTRY_VERSION` fields.",
       "reference": "It's not a good practise to delete the public static constant."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `verify.TxnPool` function.",
+      "prediction": "I'm not sure I understand what you mean by \"properly signed\"?",
       "reference": "I deleted this because `WellFormed` is immediately called by `verify.TxnPool` below. Can someone please double check this for me since it's... pretty important"
     },
     {
-      "prediction": "I'm not sure what you mean by \"pyOpenSSL>=17.5,<18.1\". I think you meant \"pyOpenSSL>=17.5, <18.1\"",
+      "prediction": "I'm not sure why we need to use `>=` here. We can just use `<` instead.",
       "reference": "Did you actually test this with ply 3.4? That release is pretty old (2011), so I think we can bump this to at least 3.6 (2015) or even 3.10 (2017)..."
     },
     {
-      "prediction": "I think this should be moved to the `deployHive` function, since it's not part of the `ReconcileHiveConfig` struct.",
+      "prediction": "I think we can remove the `if` block here, as it's not necessary.",
       "reference": "This can be simplified somewhat to `pointer.Int32Ptr(0)`. But it is not necessary."
     },
     {
-      "prediction": "I think this should be `if (b1->getBondType() == Bond::STEREOZ || b1->getBondType() == Bond::STEREOE) && (bs1 == Bond::STEREOZ || bs1 == Bond::STEREOE) && !(bs2 == Bond::STEREOZ || bs2 == Bond::STEREOE)`",
+      "prediction": "I think this should be `if (b1->getBondType() == Bond::STEREOZ || b1->getBondType() == Bond::STEREOE)`",
       "reference": "Clever but perhaps confusing."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a finalizer to the SyncSetInstance so that it can be deleted when the SyncSetInstance is deleted.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the sync set instance is deleted before the sync set secret is deleted.",
       "reference": "@abutcher Is it a safe assumption that secrets are the only objects that need to get attached to syncsets?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `Store` struct, since it's the only place where we need to track the `sseq` and `asflr`.",
+      "prediction": "I think this should be `if err != nil || state == nil` instead of `if err != nil && state == nil`",
       "reference": "Should you capture o.asflr before releasing consumer's lock?"
     },
     {
-      "prediction": "I don't think we need to add `CONFIGURATION_PANE_CSS_CLASS` to the `WinePrefixContainerWineToolsTab` class. The `WinePrefixContainerWineToolsTab` class already has the `CONFIGURATION_PANE_CSS_CLASS`.",
+      "prediction": "I don't think we need to add `CONFIGURATION_PANE_CSS_CLASS` here.",
       "reference": "Just asking: Should this happen, that null is passed? If this is the case I think we should think about passing an `Optional` object to the method."
     },
     {
-      "prediction": "Shouldn't this be `user.first_name` and `user.last_name` instead of `first_name` and `last_name`?",
+      "prediction": "I don't think you need to raise an exception here. You can just redirect to the home page.",
       "reference": "what about making a `ProfilesController` or `UserProfilesController` and having this be a `show` action instead? That would be more Railsy (although that can be considered a compliment or a dis, depending on who you are :hamburger: )"
     },
     {
@@ -29131,11 +29131,11 @@
       "reference": "I'd move the empty assignment and non-null case into the if check directly above (adding an else clause as needed)"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `Lang::get` method to get the language code, rather than hard-coding it in the `Config::get` method. This way, we don't have to hard-code the language code in the `Config::get` method, and we don't have to hard-code the language code in the `Lang::get` method.",
+      "prediction": "I don't think this is necessary. We can just use `Lang::get('system::lang.locale')` instead of `Lang::get('system::lang.locale.' . $locale)`.",
       "reference": "Please remove this extra line of whitespace"
     },
     {
-      "prediction": "I don't think we need to use `setFirstResult` and `setLastProcessedId` in this case. We can just use `setFirstResult` and `setLastProcessedId` directly.",
+      "prediction": "I don't think we need to use `setFirstResult` and `setLastProcessedId` here. We can just use `setFirstResult` and `setLastProcessedId` directly.",
       "reference": "maybe it's time to rename `ProductSearchExportWithFilter` to something better, what do you think?"
     },
     {
@@ -29143,19 +29143,19 @@
       "reference": "Instead of adding new code here - can you move these methods to agent_capability.go, so the same is used for unix and windows as well. this will need removal of these methods from agent_capability_unix.go as well."
     },
     {
-      "prediction": "I don't think we need to do this. We can just use the `push` function from the `quilt` module.",
+      "prediction": "I don't think we need to change this.",
       "reference": "Make it the last parameter, just in case someone uses the API with non-keyword args."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but it seems like it should be in the `GithubClient` class. It's not clear to me what the `GithubRemovalJob` class is supposed to do, so I'm not sure if this is the right place to put it.",
+      "prediction": "I think this should be `github_client.remove_collaborator` instead of `github_client.remove_team_member`.",
       "reference": "Don't extend an instance initialized by `Struct.new`."
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's better to use `pmix_nspace_caddy_t` instead of `pmix_list_caddy_t` in this case.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to remove the `pmix_nspace_caddy_t` from the `pmix_server_trkr_t` structure.",
       "reference": "Just wondering - would it make more sense to simply replace `PMIX_DESTRUCT(&t->nslist)` with `PMIX_LIST_DESTRUCT(&t->nslist)` here, and then add `PMIX_RELEASE(p->jobbkt)` to the `pmix_nspace_caddy_t` destructor on line 154 of src/include/pmix_globals.c? Seems to me like we always want to have these things removed/destructed."
     },
     {
-      "prediction": "I'm not sure what you mean by \"no additional tests\" in this case.",
+      "prediction": "I'm not sure if this is a good idea or not. I think it's a good idea, but I'm not sure if it's the best way to do it. I think it's a good idea, but I'm not sure if it's the best way to do it. I think it's a good idea, but I'm not sure if it's the best way to do it. I think it's a good idea, but I'm not sure if it's the best way to do it. I think it's a good idea, but I'm not sure if it's the best way to do it. I think it's a good idea, but I'm not sure if it's the best way to do it. I think it's a good idea, but I'm not sure if it's the best way to do it. I think it's a good idea, but I'm not sure if it's the best way to do it. I think it's a good idea, but I'm not sure if it's the best way to do it. I think it's a good idea, but I'm not sure if it's the best way to do it. I think it's a good idea, but I'm not sure",
       "reference": "I think, we should fix/improve AbstractRuleSetFactoryTest. I guess, both apex and visualforce rules are now tested, which is unnecessary."
     },
     {
@@ -29163,35 +29163,35 @@
       "reference": "In php8 named parameters were introduced and now it is required to match called method parameter name when setting parameters by array destructing or `call_user_func_array()` etc."
     },
     {
-      "prediction": "I don't think this is a good idea. It's not a good idea to have a field in a class that can be used to create a new instance of that class. It's not a good idea to have a field in a class that can be used to create a new instance of that class. It's not a good idea to have a field in a class that can be used to create a new instance of that class. It's not a good idea to have a field in a class that can be used to create a new instance of that class. It's not a good idea to have a field in a class that can be used to create a new instance of that class. It's not a good idea to have a field in a class that can be used to create a new instance of that class. It's not a good idea to have a field in a class that can be used to create a new instance of that class. It's not a good idea to have a field in a class that can be used to create a new instance of that class. It's not a good idea to have a field in a class that can be used to create a new instance of that class. It's not a good idea to have a field in a",
+      "prediction": "I think this should be `@Test` instead of `@FunctionalInterface`.",
       "reference": "easily possible to get that information without exposing internal information"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to set `found_env_vars[:type]` to either `pe` or `foss` based on the value of `found_env_vars[:is_pe]`, but I'm not sure what you're trying to do with `found_env_vars[:pe_version_file_win]` and `found_env_vars[:answers].delete_if`.",
+      "prediction": "I think this should be `found_env_vars[:type] = found_env_vars[:is_pe] == 'true' || found_env_vars[:is_pe] == 'yes' ? 'pe' : nil` instead of `found_env_vars[:type] = found_env_vars[:is_pe] == 'true' || found_env_vars[:is_pe] == 'yes' ? 'pe' : found_env_vars[:is_pe] == 'false' || found_env_vars[:is_pe] == 'no' ? 'pe' : nil`",
       "reference": "Why do we need tristate logic (pe, foss, nil)?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"make map[string]time.Duration\"",
+      "prediction": "I think we can remove the mutex here as well, since it's only used for testing.",
       "reference": "this change needs to be reverted to what is on `master`"
     },
     {
-      "prediction": "I think this should be `if (this.getVariable(name) != null)` instead of `if (!variableInMap)`?",
+      "prediction": "I think it's better to have `this.refreshToolboxSelection_` in `superClass_` instead of here.",
       "reference": "Do you still need to call the superclass `createVariable` if you've already determined that the variable exists?"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. I don't think this is the right way to do it.",
+      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to filter out packs from the finalized index that have been re-read into the non-finalized index, but I'm not sure how you're going to do that.",
       "reference": "Ignoring the pack entry from an existing entry but using the new entry from a non-finalized index, is subtle enough that it needs explaining."
     },
     {
-      "prediction": "I think this should be `if (it != instants.end())` instead of `if (it != instants.begin())`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to move this to `InstantSpell::getInstantSpellById` so that it can be called from `getInstantSpellCount` as well.",
       "reference": "This is a revert, is it really an issue?"
     },
     {
-      "prediction": "I don't think this is needed anymore. The `SpanBuilder` class is not needed anymore.",
+      "prediction": "I don't think this is needed anymore. The `SpanBuilder` is just a wrapper for `SpanProcessor` and `TracerConfiguration`.",
       "reference": "can we delete this file altogether?"
     },
     {
-      "prediction": "I think this should be `flag.CommandLine.Parse([]string{\"-test.coverprofile\", tempCoveragePath()})` instead of `flag.CommandLine.Parse([]string{\"-test.coverprofile\", tempCoveragePath()})`",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `flag.CommandLine.Parse` method to parse the command line arguments. This way, we don't have to worry about the order in which the arguments are parsed, and we don't have to worry about the order in which the arguments are passed to the `flag.CommandLine.Parse` method.",
       "reference": "Suggestion: log some additional info here so we know where we are i.e 'Failed to prepare coverage framework..'"
     },
     {
@@ -29203,15 +29203,15 @@
       "reference": "Log message should be started with upper-case word."
     },
     {
-      "prediction": "I don't think this is a good idea.",
+      "prediction": "I don't think this is a good idea. It would be better to use the `EventId` property of the `EventLogOptions` class.",
       "reference": "changes for example usage in this class"
     },
     {
-      "prediction": "I think this should be `EmbyButton` instead of `EmbyButtonPrototype`.",
+      "prediction": "I think this should be `EmbyButtonPrototype = Object.create(HTMLDivElement.prototype);` instead of `EmbyButtonPrototype = Object.create(HTMLDivElement.prototype);`",
       "reference": "I know frameworks that support current directory when loading dependencies, is this a limitation of the requirejs loader or can we fix it somehow?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have the `EnableApplication` and `DisableApplication` methods return a `*webservice.EnableApplicationResponse` and `*webservice.DisableApplicationResponse` respectively.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `webapi` package.",
       "reference": "`ctx` is unused in EnableApplication"
     },
     {
@@ -29219,31 +29219,31 @@
       "reference": "@jemc , this is one change needed in `generate_multi_dot_name`. I believe this * will do no harm to working pony code: The new code was added in a place where it is throwing an assert. So no working code will get affected. * is in sync with the rest of the method: if the parent ast node has null `data`, we are supposed to return empty string. That is possible when we have expressions wrapped in braces."
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here.",
+      "prediction": "I don't think we need to change this.",
       "reference": "Should not be a static import."
     },
     {
-      "prediction": "I think we can remove the `if change.Attachment != nil` check.",
+      "prediction": "I think we should use `&change.Attachment.AttachmentARN` instead of `&change.Attachments.AttachmentArn`.",
       "reference": "should we be using `aws.String` here? it seems there are a few other spots we could use `aws.String` in the `if change.Attachment != nil { ...` block."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `DashboardTopEarningPagesWidget` class.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in `DashboardTopEarningPagesWidget` as well. I think it would be good to have this in `DashboardTopEarningPagesWidget` as well. I think it would be good to have this in `DashboardTopEarningPagesWidget` as well. I think it would be good to have this in `DashboardTopEarningPagesWidget` as well. I think it would be good to have this in `DashboardTopEarningPagesWidget` as well. I think it would be good to have this in `DashboardTopEarningPagesWidget` as well. I think it would be good to have this in `DashboardTopEarningPagesWidget` as well. I think it would be good to have this in `DashboardTopEarningPagesWidget` as well. I think it would be good to have this in `DashboardTopEarningPagesWidget` as well. I think it would be good to have this in `DashboardTopEarningPagesWidget` as well. I think it would be good to have this in `DashboardTopEarningPagesWidget` as well. I think it would be good to have this in",
       "reference": "We can't pass raw dates like this because they need to be formatted as `YYYYMMDD` as noted in the IB. We added the `generateDateRangeArgs` utilities to handle this for us, as well as abstracting the relationship between arg name and specific dates which is not obvious just by looking at it. Let's update it to use `generateDateRangeArgs( { startDate, endDate } )` instead   Use care to make sure we're sourcing the utility from Analytics utils though since AdSense has its own version by the same name, which is different."
     },
     {
-      "prediction": "I'm not sure what you mean by \"save data required for execution summary\". Is this related to the `save_summary_data` parameter?",
+      "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `worker.py` file.",
       "reference": "`default=True` shouldn't be used for BoolParameters iirc."
     },
     {
-      "prediction": "I think this should be `if strings.HasPrefix(refStr, \"refs/heads/\")` instead of `if strings.HasPrefix(refStr, \"refs/heads/\") {`",
+      "prediction": "I don't think this is necessary. We can just use `strings.TrimPrefix(refStr, \"refs/heads/\")` directly.",
       "reference": "It would be better to use `return refStr[12:]`. or `11`... I have problem with counting.."
     },
     {
-      "prediction": "I think we can remove the `for` loop here, as it's not necessary.",
+      "prediction": "I think we should remove the `for` loop here, as it's not necessary.",
       "reference": "Pretty sure these should only contribute to the runtime hash."
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.",
+      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
       "reference": "Just verifying: this change doesn't break the 18f layout, right?"
     },
     {
@@ -29251,11 +29251,11 @@
       "reference": "we should keep this counter using the \"isYarpcError\" api"
     },
     {
-      "prediction": "I don't think we need to use `Maps.newHashMap()` here. We can just use `Maps.newHashMap()`, but I'm not sure if that's the best way to do it.",
+      "prediction": "I don't think we need to use `new CaseInsensitiveMap<>` here. We can just use `Maps.newHashMap<>` instead.",
       "reference": "Could we just use case insensitive strings as keys instead of creating a new map implementation? e.g. simply using a treemap with a comparator `Map idToPos = new TreeMap<>(String.CASE_INSENSITIVE_ORDER);` could work I think"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would make sense to have a `RuntimeContextSlot` class that implements `IContextSlot`. This would allow you to use the `GetSlot()` method to get a `RuntimeContextSlot` instance, and then you can use the `Slot()` method to get a `RuntimeContextSlot` instance from a `RuntimeContext`.",
       "reference": "I think this should be a throw. Or the method should be TryGetSlot?"
     },
     {
@@ -29263,47 +29263,47 @@
       "reference": "We don't usually put spaces between ( and [, and I think `path` should be passed by reference."
     },
     {
-      "prediction": "I'm not sure I understand what you mean by \"IsStackable\" and \"sold\". Could you please clarify?",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `SaveMerchantTemp` function.",
       "reference": "Make sure to `snake_case` locally scoped variable names in the future"
     },
     {
-      "prediction": "I don't think it's necessary to have a `HealthCheckPath` in the `LogsConfig` struct. The `HealthCheckPath` can be inferred from the `Path` in the `RoutingRule` struct.",
+      "prediction": "I don't think we need to add a `HealthCheckPath` field to the `RoutingRule` struct. We can just use the `HealthCheckPath` field of the `ServiceConfig` struct.",
       "reference": "Maybe we should use underscores like `health_check` - what do you think?"
     },
     {
-      "prediction": "I think we should use `string(v1alpha1.StorageClassKey)` instead of `string(v1alpha1.StorageClassKey)`",
+      "prediction": "I think we can remove the `if scName != \"\"` check here.",
       "reference": "Do a TrimSpace before setting."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to get a list of ipv4 addresses for the ENI, but I'm not sure what you're trying to do with them. I think you're trying to get a list of ipv4 addresses for the ENI, but I'm not sure what you're trying to do with them. I think you're trying to get a list of ipv4 addresses for the ENI, but I'm not sure what you're trying to do with them. I think you're trying to get a list of ipv4 addresses for the ENI, but I'm not sure what you're trying to do with them. I think you're trying to get a list of ipv4 addresses for the ENI, but I'm not sure what you're trying to do with them. I think you're trying to get a list of ipv4 addresses for the ENI, but I'm not sure what you're trying to do with them. I think you're trying to get a list of ipv4 addresses for the ENI, but I'm not sure what you're trying to do with them. I think you're trying to get a list of ipv4 addresses for the ENI, but I",
+      "prediction": "I'm not sure if this is a good idea, but I think we should be able to get the subnet gateway IPV4 address from the ENI struct as well.",
       "reference": "Are the fields in this struct grouped by IP address family or by function? There are separate fields for IPv4Addresses and IPv6Addresses, but a single field for DomainNameServers. Should this new field be named SubnetGatewayAddress with type array consisting of both IPv4 and IPv6 gateways?"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this test, but I think it's a bit misleading. It's not clear what you're trying to test here. If you're trying to test that a link can't be deleted, you should test that it can't be revived either. If you're trying to test that a link can't be revived, you should test that it can't be deleted either.",
+      "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `new_link.revive_or_create` in this case. If you want to create a new link, you should use `new_link.save` instead of `new_link.revive_or_create`. If you want to update an existing link, you should use `new_link.update_attributes` instead of `new_link.revive_or_create`.",
       "reference": ".find(id) is being deprecated to Rails 5."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to `iris.cube.CubeList` and `iris.coords.DimCoord` instead of `iris.cube.CubeList` and `iris.coords.DimCoord`. This is because `CubeList` and `DimCoord` don't have a `__getitem__` method, and `CubeList` and `DimCoord` don't have a `__len__` method.",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `DimCoord` instead of `CubeList` in this case.",
       "reference": "Will be good to have the iris interface moved to geoviews. Could this be done for 1.10.6?"
     },
     {
-      "prediction": "I think this should be a warning, not an error.",
+      "prediction": "I think this is unnecessary. We don't need to sign the request.",
       "reference": "does this get wrapped in the calling method?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"case insensitive group comparison at authorization.\" I think you're referring to the case insensitivity of the `group` parameter in the `authorize` method.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for the case-insensitive group comparison.",
       "reference": "Do we still need this test case? If your new test cases test this, then we can remove it."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all the roles for a plan, excluding the creator. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all the roles for a plan, excluding the creator. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all the roles for a plan, excluding the creator. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all the roles for a plan, excluding the creator. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all the roles for a plan, excluding the creator. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all the roles for a plan, excluding the creator. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get a list of all the roles for a plan, excluding the creator. I'm not sure",
+      "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a separate method for this.",
       "reference": "If you want to express \"any role that is not creator\" you could use the following statement: Role.where(plan: self).where(Role.not_creator_condition).any? which would be less verbose and a bit more efficient if it is used for Yes/No shared?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"intermediate\" in this context. It's not clear to me what you're trying to do here.",
+      "prediction": "I'm not sure what you mean by \"intermediate\" in this context. It's not clear to me what you mean by \"intermediate\" in this context.",
       "reference": "Do we need any update on the test side?"
     },
     {
-      "prediction": "I think this should be `fbo.config.BlockOps().Prefetcher().CancelPrefetch(ptr.ID)` instead of `fbo.config.BlockOps().Prefetcher().CancelPrefetch(ptr.ID)`?",
+      "prediction": "I think this should be `fbo.config.BlockOps().Prefetcher().CancelPrefetch(ptr.ID)` instead of `fbo.config.BlockOps().Prefetcher().CancelPrefetch(ptr.ID)`.",
       "reference": "There's a few `return nil` cases above this -- we should probably move this above the big switch."
     },
     {
@@ -29311,51 +29311,51 @@
       "reference": "`lile *LeaseInLedgerError` to reduce copying?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate endpoint for the `get` and `delete` methods. This way, we don't have to worry about the order in which the methods are called, and we don't have to worry about the order in which the methods are called.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate endpoint for the `get` and `delete` methods. The `get` method will be used to get the size of the queue, and the `delete` method will be used to delete the queue. The `get` method will be used to get the size of the queue, and the `delete` method will be used to delete the queue. The `get` method will be used to get the size of the queue, and the `delete` method will be used to delete the queue. The `get` method will be used to get the size of the queue, and the `delete` method will be used to delete the queue. The `get` method will be used to get the size of the queue, and the `delete` method will be used to delete the queue. The `get` method will be used to get the size of the queue, and the `delete` method will be used to delete the queue. The `get` method will be used to get the size of the queue, and the `delete` method will be used to delete the queue. The `get` method will be used",
       "reference": "should it be `newsessionqueue` or `newsessionqueuer`? In case we'd like to be consistent"
     },
     {
-      "prediction": "I don't think this is a good idea. We should be able to specify the access mode when creating the stream.",
+      "prediction": "I think this should be `Access` instead of `Access = FileAccess.ReadWrite`.",
       "reference": "We don't have a requirement anywhere in Test Platform for GetStream() with write access. It is ok to directly change `return new FileStream(filePath, mode, FileAccess.Read)`."
     },
     {
-      "prediction": "I'm not sure what you mean by `basedir = os.path.dirname(__file__)`. Is that the same as `basedir = os.path.dirname(os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))))`?",
+      "prediction": "I think we should remove the `basedir` argument from the `collect_tests` function.",
       "reference": "FWIW `from qutebrowser.browser import hints` is okay - it's just things like `from qutebrowser.browser.hints import HintManager` I try to avoid."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but it seems to work.",
+      "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use the same class name for the header grid and the transparent header.",
       "reference": "@preda-bogdan let's use a filter for the header classes, something like, hfg_header_classes where we hook this logic, in neve pro"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use `wait.PollImmediate` to wait for a pod to be ready. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use `wait.PollImmediate` to wait for a pod to be ready. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use `wait.PollImmediate` to wait for a pod to be ready. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use `wait.PollImmediate` to wait for a pod to be ready. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use `wait.PollImmediate` to wait for a pod to be ready. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use `wait.PollImmediate` to wait for a pod to be ready. I'm not sure what you're trying to achieve with this change, but it looks like you're trying to use `wait.PollImmediate",
+      "prediction": "I don't think we need to use `k8s.io/client-go/informers` here. We can just use `k8s.io/client-go/informers/admissionregistration` and `k8s.io/client-go/informers/admissionregistration/v1`.",
       "reference": "Out of curiosity.. is there a rule to determine the package name as prevDirectory+currentDirectory."
     },
     {
-      "prediction": "I think we can remove the `if (YMM_ENABLED())` and `else if (ZMM_ENABLED())` checks.",
+      "prediction": "I think this should be `if (ZMM_ENABLED())` instead of `if (YMM_ENABLED())`.",
       "reference": "It seems this needs to check the lazy cxt switching flag. It is used on the initial thread for early injection and in other places where the lazy switch should apply."
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `utils` package.",
+      "prediction": "I think this should be `const` instead of `undefined`.",
       "reference": "Why not use the JSdoc annotation as it did before?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the version contains `-ee` and if so, set the `edition` property to `Enterprise` instead of `Community`.",
+      "prediction": "I don't think we need to trim the `-ee` suffix.",
       "reference": "Why don't we drop the packageImplementationVersion in general? That way the version will be fetch all that time only from the properties file and it will be consistent."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.",
+      "prediction": "I think this should be `const_cast` instead of `std::vector`.",
       "reference": "Please use the style of the rest of the code, a space between the type and `*`"
     },
     {
-      "prediction": "I don't think we need to mock the `ProcessManager` here. We can just use the `Process` class directly.",
+      "prediction": "I don't think this is necessary.",
       "reference": "nit: remove extra blank lines."
     },
     {
-      "prediction": "I'm not sure if this is the right place to put it, but I think we should move it to the `docker-compose.yml` file as well. I think it's a good idea to have a default task group name in the `docker-compose.yml` file as well, so that we can use it in the `docker-compose.yml` file as well.",
+      "prediction": "I don't think we need to change the default task group name to `copilot-task`.",
       "reference": "nit: What do you think of `copilot-task-group`?"
     },
     {
-      "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to make sure that `this._prevValue` is not `undefined` before calling `this.value = this._prevValue || ''`.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "We should check whether or not the input node has a value since we can just have an onChange on an uncontrolled component as well."
     },
     {
@@ -29363,31 +29363,31 @@
       "reference": "I think there should be some reasoning below this line about the version updating."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to set the `H2O_COMPRESS_HINT_AUTO` to `ON` or `OFF` based on the value of the `H2O_COMPRESS_HINT` field in the `h2o_http1client_header_t` structure. I'm not sure what you're trying to do here, but it looks like you're trying to set the `H2O_COMPRESS_HINT_AUTO` to `ON` or `OFF` based on the value of the `H2O_COMPRESS_HINT` field in the `h2o_http1client_header_t` structure. I'm not sure what you're trying to do here, but it looks like you're trying to set the `H2O_COMPRESS_HINT_AUTO` to `ON` or `OFF` based on the value of the `H2O_COMPRESS_HINT` field in the `h2o_http1client_header_t` structure. I'm not sure what you're trying to do here, but it looks like you're trying to set the `H2O_COMPRESS_HINT_AUTO` to `ON` or `OFF` based on the value of the `H2O_COMPRESS_HINT",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `H2O_COMPRESS_HINT` enum to the `h2o_http1client.h` header.",
       "reference": "Please use `h2o_lcstris` instead of `strncasecmp` so that the comparison would be a complete match (instead of a prefix match; current code would yield true if [val,len] is [\"O\", 1]) and that it would be locale-independent."
     },
     {
-      "prediction": "I think this should be `if config.Mode() != InitMinimal {` instead of `if config.Mode() != InitMinimal { nodeCache = newNodeCacheStandard(fb); } else { nodeCache = newNodeCacheStandard(fb); }`",
+      "prediction": "I think it's better to use `newNodeCache` instead of `newNodeCacheStandard` here.",
       "reference": "I prefer if possible for `if`/`else` statements to have the positive case first."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason you want to create a temp file?",
+      "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason you want to create a temporary file?",
       "reference": "Docstring would be nice"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this, but it looks like you're trying to add a bunch of new checks to the `BaselineErrorProne` plugin. I'm not sure what you're trying to do with this, but it looks like you're trying to add a bunch of new checks to the `BaselineErrorProne` plugin. I'm not sure what you're trying to do with this, but it looks like you're trying to add a bunch of new checks to the `BaselineErrorProne` plugin. I'm not sure what you're trying to do with this, but it looks like you're trying to add a bunch of new checks to the `BaselineErrorProne` plugin. I'm not sure what you're trying to do with this, but it looks like you're trying to add a bunch of new checks to the `BaselineErrorProne` plugin. I'm not sure what you're trying to do with this, but it looks like you're trying to add a bunch of new checks to the `BaselineErrorProne` plugin. I'm not sure what you're trying to do with this, but it looks like you're trying to add a bunch of new checks to the `BaselineErrorProne",
+      "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to have a list of all the checks that we want to catch. This way, we don't have to worry about forgetting to add a check to the list.",
       "reference": "Low risk to fix this by default because existing baseline consumers pass this check. We don't attempt to fix checks that have been opted out of."
     },
     {
-      "prediction": "I think this should be `#if defined(KOKKOS_COMPILER_CLANG) && (KOKKOS_COMPILER_CLANG >= 1300)` instead of `#if defined(KOKKOS_COMPILER_CLANG) && (KOKKOS_COMPILER_CLANG >= 1300) && (KOKKOS_COMPILER_CLANG >= 1400)`",
+      "prediction": "I think this should be `#if defined(KOKKOS_COMPILER_CLANG) && (KOKKOS_COMPILER_CLANG >= 1300)` instead of `#if defined(KOKKOS_COMPILER_CLANG) && (KOKKOS_COMPILER_CLANG >= 1300) && (KOKKOS_COMPILER_CLANG < 1300)`",
       "reference": "What about `VOLTA72`, `TURING75`, `AMPERE80` and `AMPERE86`? We only want to set the number of teams for these two architectures or for all the architectures newer than Maxwell?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"backbone\" in this context. Is it referring to the backbone of the model, or the backbone of the dataset?",
+      "prediction": "I don't think we need to change the `backbone` setting here.",
       "reference": "Since we have specified `load_from`, `pretrained` can be left None."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to parse a log directive, but you're not using the `logParse` function. I'm not sure what you're trying to do here, but it looks like you're trying to parse a log directive, but you're not using the `logParse` function. I'm not sure what you're trying to do here, but it looks like you're trying to parse a log directive, but you're not using the `logParse` function. I'm not sure what you're trying to do here, but it looks like you're trying to parse a log directive, but you're not using the `logParse` function. I'm not sure what you're trying to do here, but it looks like you're trying to parse a log directive, but you're not using the `logParse` function. I'm not sure what you're trying to do here, but it looks like you're trying to parse a log directive, but you're not using the `logParse` function. I'm not sure what you're trying to do here, but it looks like you're trying to parse a log directive, but you're not using the `logParse",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a default value for the number of args in the log directive. This way, if we don't specify a number of args, it defaults to 3.",
       "reference": "I prefer to translate these `else if` into `switch` for more readability."
     },
     {
@@ -29395,39 +29395,39 @@
       "reference": "This can also be a local variable in `create`."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the repo already has a git-daemon-export-ok file. If it doesn't, we should create one.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the repo is private, and if so, remove the file. This way, we don't have to worry about closing a file that isn't open, and we don't have to worry about creating a file that doesn't exist. I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the repo is private, and if so, remove the file. This way, we don't have to worry about closing a file that isn't open, and we don't have to worry about creating a file that doesn't exist. I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the repo is private, and if so, remove the file. This way, we don't have to worry about closing a file that isn't open, and we don't have to worry about creating a file that doesn't exist. I'm not sure if this is the right place to do this, but I think it would be good to add a check to see if the repo is",
       "reference": "Why not use `path.Join`?"
     },
     {
-      "prediction": "I think this should be `global.googlesitekit.api = API;` instead of `global.googlesitekit.api = API; global.googlesitekit.api = API;`",
+      "prediction": "I think it's better to use `global` instead of `global.googlesitekit` in this case.",
       "reference": "Why not `export default API` instead? This ensures we export the same that we export on the global."
     },
     {
-      "prediction": "I think this should be `itk.ImageIOFactory.FileModeType_ReadMode` instead of `itk.ImageIOFactory.ReadMode`",
+      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to set the `FileModeType_ReadMode` to `FileModeType_WriteMode`, which is not supported by `itk.ImageIOFactory`. I'm not sure what you're trying to do here, but it looks like you're trying to set the `FileModeType_ReadMode` to `FileModeType_WriteMode`, which is not supported by `itk.ImageIOFactory`. I'm not sure what you're trying to do here, but it looks like you're trying to set the `FileModeType_ReadMode` to `FileModeType_WriteMode`, which is not supported by `itk.ImageIOFactory`. I'm not sure what you're trying to do here, but it looks like you're trying to set the `FileModeType_ReadMode` to `FileModeType_WriteMode`, which is not supported by `itk.ImageIOFactory`. I'm not sure what you're trying to do here, but it looks like you're trying to set the `FileModeType_ReadMode` to `FileModeType_WriteMode`, which is not supported by `itk.ImageIOFactory`. I'm not sure what you're trying to do here",
       "reference": "This is a good change I think. It greatly helps reduce name conflicts."
     },
     {
-      "prediction": "I think we should remove the `Tags` field from the `Placement` struct.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `jetstream` package.",
       "reference": "cluster not having omitempty, does this imply that cluster is required? seems empty is valid so just checking"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate function for this.",
+      "prediction": "I think this should be merged into the `MergeEnvironmentVariables` method.",
       "reference": "@aws/aws-ecs-agent, @yumex93: how concerned should we be about user provided envvar names clobbering existing envvars? i'm not convinced we should be doing additional validation here."
     },
     {
-      "prediction": "I think this should be `aspects = new Set(aspects);` instead of `aspects = new Set(aspects);`",
+      "prediction": "I think we can remove the `writable: false` from the `defineAspects` function.",
       "reference": "nit: aspects are defined in `OperationBase`, should `defineAspects` live there as well?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"enable in configuration\". Is it possible to enable it in the configuration file? If so, how do I do that?",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `Migrator` class to handle the migration of the database schema.",
       "reference": "Why the `os.path.abspath`? `os.path.dirname` should always give a valid directory path."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to get the path to the wine engines directory, but I don't think that's what you're trying to do here.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "I think we should not consider special engine types on this level. I would prefer to build the specific engine path based on `application.user.engines` later on."
     },
     {
-      "prediction": "I don't think it's necessary to check operatorList_ here. If operatorList_ is not empty, it means there are still fields to filter. If operatorList_ is empty, it means there are no fields to filter.",
+      "prediction": "I don't think it's necessary to check operatorList_ here. If operatorList_ is not empty, it means there are still fields to filter. If operatorList_ is empty, it means there are no more fields to filter. If operatorList_ is empty, it means there are no more fields to filter. If operatorList_ is empty, it means there are no more fields to filter. If operatorList_ is empty, it means there are no more fields to filter. If operatorList_ is empty, it means there are no more fields to filter. If operatorList_ is empty, it means there are no more fields to filter. If operatorList_ is empty, it means there are no more fields to filter. If operatorList_ is empty, it means there are no more fields to filter. If operatorList_ is empty, it means there are no more fields to filter. If operatorList_ is empty, it means there are no more fields to filter. If operatorList_ is empty, it means there are no more fields to filter. If operatorList_ is empty, it means there are no more fields to filter. If operatorList_ is empty, it means there are no more fields to filter. If operatorList_",
       "reference": "Is `rbegin` correct? We can't make sure that the last index column is the `rbegin` of `scanItems`."
     },
     {
@@ -29435,19 +29435,19 @@
       "reference": "check it is != 0, just like `EVMNetworkID` above"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `OpenTelemetrySdkEventSource` class.",
+      "prediction": "I think this should be `OpenTelemetrySdkEventSource.Log.DroppedExportProcessorItems` instead of `OpenTelemetrySdkEventSource.Log.DroppedExportProcessorItems(nameof(BatchExportProcessor), typeof(T).Name, this.exporter.GetType().Name, this.droppedCount);`",
       "reference": "if you just do \"this.GetType().Name\" and \"this.exporter.GetType().Name\", we get what we need."
     },
     {
-      "prediction": "I think we should use `BASE_PATH` instead of `BASE_CHATTER_PATH` for backwards compatibility.",
+      "prediction": "I think this should be `BASE_CHATTER_PATH = BASE_PATH + \"/chatter/\";` instead of `BASE_CHATTER_PATH = BASE_PATH + \"/chatter/\";`",
       "reference": "That's the code that would prevent any SalesforceSDKTest from running. At class loading time, SalesforceSDKManager.getInstance() would throw a RuntimeException because init() had never been called."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. The `VERSION_RULE_LATEST` should be the same as `VERSION_RULE_ALL`, and the `DEFAULT_REVISION` should be the same as `VERSION_RULE_LATEST`.",
+      "prediction": "I don't think we need to change the `VERSION_RULE_ALL` to `0.0.0+`.",
       "reference": "there is no \"DEFAULT_REVISION\" logic, no need to define this."
     },
     {
-      "prediction": "I think it's better to use `loginOptions.setJwt(jwt);` instead of `loginOptions.setJwt(jwt); loginOptions = new LoginOptions(url, getPasscodeHash(), config.getOauthRedirectURI(), config.getRemoteAccessConsumerKey(), config.getOauthScopes(), null, jwt);`",
+      "prediction": "I think we should remove the `null` from the `loginOptions.setJwt(jwt);` line.",
       "reference": "so this is to fix a scenario where the app is first launched normally, then background and foreground through the link, we are not updating loginOption"
     },
     {
@@ -29455,7 +29455,7 @@
       "reference": "It doesn't seem like the right way to implement this, because you add a new element that doesn't really exist (noteTextViewer). Instead you should modify the command handler `if (command.name === 'focusElement' && command.target === 'noteBody') {` in NoteText.jsx. Then focus either the editor or the viewer depending on what's currently visible."
     },
     {
-      "prediction": "I don't think this is needed anymore. The `LogicalType` and `LogicalTypes` classes have been removed from Avro 1.8.0.",
+      "prediction": "I think this should be `List` instead of `List`",
       "reference": "We don't add blank lines in imports."
     },
     {
@@ -29463,23 +29463,23 @@
       "reference": "Please add your name to the copyright list."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that we don't have to do this in the future. If we do this in the future, I think it would be a good idea to make sure that we don't have to do this in the future. If we do this in the future, I think it would be a good idea to make sure that we don't have to do this in the future. If we do this in the future, I think it would be a good idea to make sure that we don't have to do this in the future. If we do this in the future, I think it would be a good idea to make sure that we don't have to do this in the future. If we do this in the future, I think it would be a good idea to make sure that we don't have to do this in the future. If we do this in the future, I think it would be a good idea to make sure that we don't have to do this in the future. If we do this in the future, I think it would be a good idea to make sure that we don't have to do this in the future. If we",
+      "prediction": "I think it's better to use `r.request.URL.Path` instead of `r.request.Context().Value(RequestIDCtxKey).(string)`.",
       "reference": "You can elide the `if` check for empty string, because if it's not a value that is set, the string will be empty anyway."
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way",
       "reference": "Different i18n keys. By mistake or on purpose?"
     },
     {
-      "prediction": "I think this should be `ACMESelfCheckFailurePolicyRetryForever` instead of `ACMESelfCheckFailurePolicyRetryForever ACMESelfCheckFailurePolicy`.",
+      "prediction": "I think this should be `ACMESelfCheckFailurePolicyRetryForever` or `ACMESelfCheckFailurePolicyIgnore` instead of `ACMESelfCheckFailurePolicyRetryForever ACMESelfCheckFailurePolicy`.",
       "reference": "Given the description for this is `// Describes how the ACME challenge self check behaves when it fails.`, perhaps `RetryForever` is better terminology here as when the check fails, we don't just wait, we retry periodically."
     },
     {
-      "prediction": "I think this should be `if (gpg_error == GPG_ERR_NO_ERROR)` instead of `if (gpg_error != GPG_ERR_NO_ERROR)`.",
+      "prediction": "I'm not sure if this is the right place to throw an error here, but I think it's a good idea to throw an error here.",
       "reference": "Nit: let's add a more descriptive prefix in line with the other ones? E.g. `Unable to import key` ?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I think we should remove the `let(:key) { ENV['BOLT_SSH_KEY'] || Dir[\".vagrant/**/private_key\"] }` line.",
+      "prediction": "I think we can remove the `let(:key) { ENV['BOLT_SSH_KEY'] || Dir[\".vagrant/**/private_key\"] }` line.",
       "reference": "This looks like it will pass an array as `:key` in the default case. That doesn't reflect how this will actually work in practice."
     },
     {
@@ -29495,15 +29495,15 @@
       "reference": "In this case we probably meant \"package\"."
     },
     {
-      "prediction": "I think we can remove `makeDir` and `writeFile` as they are not needed anymore.",
+      "prediction": "I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this, but it seems to work for me. I'm not sure if this is the best way to do this,",
       "reference": "Just export `createFile` directly."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to put it in a separate file.",
       "reference": "This probably needs to get shipped with plz; you shouldn't have to redefine it within the user's repo. It should use `defaultPath` like the other things up the top of the file."
     },
     {
-      "prediction": "I don't think this is a good idea. The `network` option is only used in the `run` function, so it shouldn't be used anywhere else. It's also not clear what the purpose of the `testnet` option is.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `network.name` instead of `opts.network.name` in this case.",
       "reference": "interface for bitcoin should not change if possible. i.e: networks.testnet should return networks['btc'].testnet"
     },
     {
@@ -29511,7 +29511,7 @@
       "reference": "File is not `gofmt`-ed with `-s` (from `gofmt`)"
     },
     {
-      "prediction": "I think this should be `wlr_surface_send_frame_done` instead of `wlr_surface_send_leave`?",
+      "prediction": "I think this should be `wlr_surface_send_frame_done(struct wlr_surface *surface, const struct timespec *when)`",
       "reference": "We have this functions in a couple of places. It should probably live in util or something."
     },
     {
@@ -29523,75 +29523,75 @@
       "reference": "Do not import torch in the test function because it will import torch every test iteration and will slow down the testing speed."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to do this in a single line.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `aws.String` method to convert the string to a `string` so that we don't have to worry about the type of the input.",
       "reference": "I think we want to return an error here, not nil."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to have a `userInputState` property in the `core/user` module. It's not clear what you're trying to achieve with this property.",
+      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.",
       "reference": "Nitpicking, but I think it would be more accurate to use an actually supported value, i.e. `completed`."
     },
     {
-      "prediction": "I think this should be `find_project` instead of `find_project_id`?",
+      "prediction": "I think we should remove the `raise ParamRecordNotFound if @project.nil?` line.",
       "reference": "How about renaming the `ApiJob` class to `JobApi`. As per rails convention, get method is to get a single object, not a collection, can we change that to `fetch`/`where`. It would be great if we can move the `get` method to a class method."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be a good idea to have",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the",
       "reference": "assignments should only be cuddled with other assignments (from `wsl`)"
     },
     {
-      "prediction": "I think this should be `nil, cache.ErrUnimplemented` instead of `nil, cache.ErrUnimplemented`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `cache` package.",
       "reference": "`k` is unused in PutHash"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. The `StatementsSource` interface doesn't have a `getCodebase` method, so I'm not sure what you're trying to do here.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "None of the child return null here, plus it was creating an incoherence between interfaces."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
+      "prediction": "I'm not sure what you mean by \"cap it at thread count\". I think you meant to say \"cap it at the number of threads\".",
       "reference": "Should we remove this entirely now then?"
     },
     {
-      "prediction": "I think this is a bit misleading. The `String` method should return the name of the monitor, not the name of the `Monitor` interface.",
+      "prediction": "I think this should be `String()` instead of `String() string`",
       "reference": "That is way too generic a name."
     },
     {
-      "prediction": "I'm not sure what you mean by \"overwrote ids\". I think you meant to say that the `data-testelm` attribute was set to `\"1\"`, but the `id` attribute was set to `\"target\"`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a test for this.",
       "reference": "This might be overkill for test code...but as stewards of accessibility it would be appropriate to have a label in the fixture."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I think it's a bad idea to use `VkCommandBufferInheritanceInfo` here. It's not clear what you're trying to do here.",
+      "prediction": "I'm not sure what you're trying to do here. I think you're trying to clear the color attachment of the main render pass, but you're not doing that in the test. I'm not sure what you're trying to do here. I think you're trying to clear the color attachment of the main render pass, but you're not doing that in the test. I'm not sure what you're trying to do here. I think you're trying to clear the color attachment of the main render pass, but you're not doing that in the test. I'm not sure what you're trying to do here. I think you're trying to clear the color attachment of the main render pass, but you're not doing that in the test. I'm not sure what you're trying to do here. I think you're trying to clear the color attachment of the main render pass, but you're not doing that in the test. I'm not sure what you're trying to do here. I think you're trying to clear the color attachment of the main render pass, but you're not doing that in the test. I'm not sure what you're trying to do here. I think you're trying to clear the color attachment of the main render pass,",
       "reference": "Are these allocations necessary, or can these be instantiated normally (i.e., `VkCommandBufferObj secondary_full_clear(...)`). If the allocations _are_ necessar, I'd vote for using something like `std::unique_ptr` and then remove the associated `delete`s."
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to clear the span cache in order to prevent tests from breaking. I'm not sure if this is a good idea, but I think it's a good idea to clear the span cache in order to prevent tests from breaking. I'm not sure if this is a good idea, but I think it's a good idea to clear the span cache in order to prevent tests from breaking. I'm not sure if this is a good idea, but I think it's a good idea to clear the span cache in order to prevent tests from breaking. I'm not sure if this is a good idea, but I think it's a good idea to clear the span cache in order to prevent tests from breaking. I'm not sure if this is a good idea, but I think it's a good idea to clear the span cache in order to prevent tests from breaking. I'm not sure if this is a good idea, but I think it's a good idea to clear the span cache in order to prevent tests from breaking. I'm not sure if this is a good idea, but I think it's a good idea to clear the span cache in order to prevent tests from breaking.",
+      "prediction": "I'm not sure why we need to flush on writes, but I think it's a good idea.",
       "reference": "es.clear should call this"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this test, but I think it's unnecessary.",
+      "prediction": "I'm not sure what you're trying to do with this test, but I'm not sure how to make it work. I'm not sure what you're trying to do with this test, but I'm not sure how to make it work. I'm not sure what you're trying to do with this test, but I'm not sure how to make it work. I'm not sure what you're trying to do with this test, but I'm not sure how to make it work. I'm not sure what you're trying to do with this test, but I'm not sure how to make it work. I'm not sure what you're trying to do with this test, but I'm not sure how to make it work. I'm not sure what you're trying to do with this test, but I'm not sure how to make it work. I'm not sure what you're trying to do with this test, but I'm not sure how to make it work. I'm not sure what you're trying to do with this test, but I'm not sure how to make it work. I'm not sure what you're trying to do with this test, but I'm not sure how to make it work. I'm not sure what you",
       "reference": "please remove. this is true by the definition of the Python language"
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have the `select-follow` and `select-follow -t` commands be the same as the `select-follow` and `select-follow -t` commands.",
       "reference": "Hmm, I wonder if binding `` is a good idea... this means it wouldn't be passed to webpages anymore, which makes me wonder how many people rely on that... I guess trying it is the only way to find out :wink:"
     },
     {
-      "prediction": "I'm not sure what you mean by \"no tiers\" in this case.",
+      "prediction": "I'm not sure what you mean by \"tests of actions and flow control.\" What do you mean by that?",
       "reference": "Golang naming convention is to use camel case `icmpPktWithTypeCode` Often the linter will complain"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. The `InitializeStreams` method is called by the `FrameResponseHeaders` constructor, so it should not be called from there.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "nit: Probably should renamed to `InitializeBody`"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `computed` for this kind of things.",
+      "prediction": "I don't think we need to use `htmlSafe` here.",
       "reference": "is `settings.icon` always null/undefined when there's no icon or does is it get set to a blank string? It might be worth wrapping it in an `isBlank()` anyway"
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think it would make sense to move it to the `bootstrap` module, since it's used by the `bootstrap` module as well.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `bootstrap` module.",
       "reference": "put invoke to the end of the list, and other module at beginning of the list (line 86)"
     },
     {
-      "prediction": "I think we can remove the `swarm.ChunkSize` and `swarm.MaxParallelUpdateGC` since they are not used anymore.",
+      "prediction": "I think we can remove the `swarm.ChunkSize` and `swarm.MaxParallelUpdateGC` here.",
       "reference": "I think that bytes is too precise. Can we just calculate the approximate value in appropriate units? Something like MB, GB depending on the value, `db capacity: 5000000 chunks (approximately 20GB)` ."
     },
     {
@@ -29603,23 +29603,23 @@
       "reference": "Why did you change the signature of this method ? You can break BC doing that"
     },
     {
-      "prediction": "I think this should be `template := configCNIToml` instead of `template = string(fileBytes[:])`",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a `template` field in the `config.toml` file, so that we don't have to hardcode it.",
       "reference": "can you catch the error here please and return err if it can't read the template"
     },
     {
-      "prediction": "I think this should be `containersController.loadContainers();` instead of `containersController.loadContainers();+libraryController.updateLibrary();`",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to call the `updateLibrary` method after the `loadApps` method is called.",
       "reference": "Is this method called at another location too? I'm just asking because you didn't remove another call to `updateLibrary`"
     },
     {
-      "prediction": "I'm not sure what you mean by `@object.is_default` and `@object.org.funder?`. I think you meant to say `@object.is_default?` and `@object.org.funder?`.",
+      "prediction": "I'm not sure what you mean by `@object.is_default` and `@object.org.funder?`. I think you meant `@object.is_default?` and `@object.org.funder?`.",
       "reference": "Not necessary but you should be able to add a `?` on `is_default?` and `published?`"
     },
     {
-      "prediction": "I think this is a good idea, but I'm not sure if it's the best way to do it. It's not clear to me if this is the best way to do it. It's not clear to me if this is the best way to do it. It's not clear to me if this is the best way to do it. It's not clear to me if this is the best way to do it. It's not clear to me if this is the best way to do it. It's not clear to me if this is the best way to do it. It's not clear to me if this is the best way to do it. It's not clear to me if this is the best way to do it. It's not clear to me if this is the best way to do it. It's not clear to me if this is the best way to do it. It's not clear to me if this is the best way to do it. It's not clear to me if this is the best way to do it. It's not clear to me if this is the best way to do it. It's not clear to me if this is the best way to do it. It's not clear to me if this is",
+      "prediction": "I think we should be able to do this in a single `@Benchmark` statement.",
       "reference": "here is us decoding directly the bytebuffer in benchmarks"
     },
     {
-      "prediction": "I think this should be `else` instead of `else if`.",
+      "prediction": "I think we should remove the `else` block here, since we don't need to set the default values here.",
       "reference": "When the Tracer is first created AND `DD_LOGS_INJECTION=true`, this is invoked and causes the issues described."
     },
     {
@@ -29631,75 +29631,75 @@
       "reference": "This could be made into a function expression, yes?"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to abort the program if the assertion fails. This way, we don't have to wait for the program to finish before aborting.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `release_assert_internal` function, since it's called by the `release_assert` function.",
       "reference": "Oops, I missed this initially."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to add a permission to an existing lambda function, but I'm not sure what you're trying to do here. I think you're trying to add a permission to an existing lambda function, but I'm not sure what you're trying to do here. I think you're trying to add a permission to an existing lambda function, but I'm not sure what you're trying to do here. I think you're trying to add a permission to an existing lambda function, but I'm not sure what you're trying to do here. I think you're trying to add a permission to an existing lambda function, but I'm not sure what you're trying to do here. I think you're trying to add a permission to an existing lambda function, but I'm not sure what you're trying to do here. I think you're trying to add a permission to an existing lambda function, but I'm not sure what you're trying to do here. I think you're trying to add a permission to an existing lambda function, but I'm not sure what you're trying to do here. I think you're trying to add a permission to an existing lambda function, but I'm not sure",
+      "prediction": "I'm not sure I understand what you're trying to do here. Is it that you want to add a permission to the lambda function, or is it that you want to add a permission to the IAM role that is associated with the lambda function? If it's the former, then I'm not sure I understand what you're trying to do here. Is it that you want to add a permission to the lambda function, or is it that you want to add a permission to the IAM role that is associated with the lambda function? If it's the former, then I'm not sure I understand what you're trying to do here. Is it that you want to add a permission to the lambda function, or is it that you want to add a permission to the IAM role that is associated with the lambda function? If it's the former, then I'm not sure I understand what you're trying to do here. Is it that you want to add a permission to the lambda function, or is it that you want to add a permission to the IAM role that is associated with the lambda function? If it's the former, then I'm not sure I understand what you're trying to do here. Is it that you want to add a permission to the lambda function,",
       "reference": "Can we add an assertion here the policy actually contains both statements created above?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in `rocksdb_compression_per_level`.",
+      "prediction": "I'm not sure if this is the right place to add this, but I think it would be a good idea to add this to the `rocksdb_compression_per_level` and `rocksdb_bottommost_compression` options.",
       "reference": "a space after comma?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this.",
+      "prediction": "I think this should be `if (skewFromParent != null && isLocalSpan(node.value())) {` instead of `if (skew != null && isLocalSpan(node.value())) {`",
       "reference": "nit formatting here and below"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to remove the `mock_entry` and `mock_registration` imports, as they are not used in this test suite.",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use the `mock_entry` and `mock_registration` packages.",
       "reference": "I think that there is a general consensus of trying to avoid this kind of mocks in the new tests that we write. I would suggest to have tests using fake service implementations. In this case, we can have a fake entry service. Examples of how tests have been written this way are the tests for the `spire-server agent` and `spire-server bundle` commands. It would be great if we can have that kind of testing here also. What do you think?"
     },
     {
-      "prediction": "I think this should be `false, string, error` instead of `false, string, error, nil`",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate function for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate function for this. It's",
       "reference": "`ctx` is unused in RunQuery"
     },
     {
-      "prediction": "I think we can remove the `if 'location' in event` check.",
+      "prediction": "I think this should be `os.path.basename(report.files[event['location']['file']])` instead of `os.path.basename(report.files[event['location']['file']]) if 'location' in event else 0`",
       "reference": "Couldn't we use type hints to express this?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"isFavorite\" in this context. Is it a property of the button or something else? If it's a property of the button, then I think we should remove the `isFavorite` attribute from the button. If it's something else, then I think we should remove the `isFavorite` attribute from the button.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a `ratingbutton-icon-withrating` class to the `ratingbutton` element.",
       "reference": "why you do `.classList.add()` here but `.replace()` in other places?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `before` block, so that we don't have to wait for the page to load before we can do this.",
+      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get the avatar of the teacher. I think you want to get the avatar of the teacher who is teaching both sections, right?",
       "reference": "What is this sleep here for?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"properly count height\"",
+      "prediction": "I'm not sure if this is the right place for this test, but I think it should be here.",
       "reference": "I think that this test doesn't cover this bug correctly. When I attached the older version of the handsontable to this test it passes, should fail. Can you check that?"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do with this field. It seems to me that this field is only used in the `tlfJournal` struct, not in the `tlfJournalBWDelegate` struct. Could you explain what you're trying to do with this field?",
+      "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason why you want to have a `unflushedReady` channel?",
       "reference": "Maybe this should just be passed in on construction time"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure the backend is destroyed when the multi-backend is destroyed.",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to return a pointer to `primary_drm` in the `wlr_backend_autocreate` function. This way, the `wlr_drm_backend_monitor_create` function doesn't need to return a pointer to `primary_drm`, and the `wlr_drm_backend_destroy` function doesn't need to return a pointer to `primary_drm`.",
       "reference": "We should create the monitor after the `if (!primary_drm)` check."
     },
     {
-      "prediction": "I think it's better to use `yield 'qutebrowser.browser.tab.TabData._initializing'` instead of `yield 'qutebrowser.browser.tab.TabData._initializing'`",
+      "prediction": "I think it's better to use `yield 'qutebrowser.utils.log.QtWarningFilter.filter'` instead of `yield 'qutebrowser.browser.pdfjs.is_available'`.",
       "reference": "Can be removed now that slots are used"
     },
     {
-      "prediction": "I'm not sure what you're trying to say here. I think you're trying to say that the controller should respond with a 404, but I don't think that's the case. I think you're trying to say that the controller should respond with a 401, but I don't think that's the case. I think you're trying to say that the controller should respond with a 403, but I don't think that's the case. I think you're trying to say that the controller should respond with a 404, but I don't think that's the case. I think you're trying to say that the controller should respond with a 401, but I don't think that's the case. I think you're trying to say that the controller should respond with a 403, but I don't think that's the case. I think you're trying to say that the controller should respond with a 404, but I don't think that's the case. I think you're trying to say that the controller should respond with a 401, but I don't think that's the case. I think you're trying to say that the controller should respond",
+      "prediction": "I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure",
       "reference": "The description should match the test"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to make sure that `wl_display` is set before calling `xwayland_start_server()` or `xwayland_start_server_lazy()`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `xwayland` module.",
       "reference": "rootston needs to unset this now"
     },
     {
-      "prediction": "I think this should be `b.blockQueues[height]` instead of `b.blockQueues[height]`",
+      "prediction": "I'm not sure what you're trying to do here. I don't think we need to change anything here.",
       "reference": "why do you rename this function?"
     },
     {
-      "prediction": "I think we can remove the `if` statement here.",
+      "prediction": "I think this should be `if step.status == \"completed\"` instead of `if step.status == \"actionable\"`.",
       "reference": "since we are no longer using these numbered icons can we remove them from source control?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to put this in the `RestProducerInvocation` class.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `RestProducer` class.",
       "reference": "both edge and normal need to set this, so set it to be default action?"
     },
     {
@@ -29707,35 +29707,35 @@
       "reference": "Is doing a straight string compare of the files the right way to determine this? I guess if you expect to be the only one writing this file it could work but it does seem like it might be a large string compare and if we are doing this hundreds of times that might cause some memory issues."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to set the priority of the current process to 3. I'm not sure what you're trying to do here, but it looks like you're trying to set the priority of the current process to 3. I'm not sure what you're trying to do here, but it looks like you're trying to set the priority of the current process to 3. I'm not sure what you're trying to do here, but it looks like you're trying to set the priority of the current process to 3. I'm not sure what you're trying to do here, but it looks like you're trying to set the priority of the current process to 3. I'm not sure what you're trying to do here, but it looks like you're trying to set the priority of the current process to 3. I'm not sure what you're trying to do here, but it looks like you're trying to set the priority of the current process to 3. I'm not sure what you're trying to do here, but it looks like you're trying to set the priority of the current process to 3. I'm not sure what you're trying",
+      "prediction": "I'm not sure if this is a good idea, but I don't think it's a good idea to use `system` here. I think it's better to use `fork` and `waitpid` instead.",
       "reference": "What's the purpose of this change? It basically changes nothing until we want to put smth between curly braces"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `wlr_input_device_destroy` function.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `wlr_input_device_destroy` function, since it will be called by the `wlr_input_device_destroy` function as well.",
       "reference": "Hmm, why is this needed? `wlr_input_device_destroy` should destroy the tablet tool."
     },
     {
-      "prediction": "I'm not sure what you mean by \"is this supported?\"",
+      "prediction": "I think this should be `getAdditionalTypes()` instead of `getInterfaces()`.",
       "reference": "I think it's better to throw `UnsupportedOperationException`"
     },
     {
-      "prediction": "I think it's better to use `v-for` instead of `v-for-of` in this case. `v-for-of` is deprecated and will be removed in the next major version of Vue.",
+      "prediction": "I don't think we need to do this.",
       "reference": "`props.children` is not always guaranteed to be an array. When only one child is passed this will break. We can use `toChildArray()` to turn it into an array :tada:"
     },
     {
-      "prediction": "I'm not sure what you mean by `--mode=release`. Is this the same as `--mode=debug`?",
+      "prediction": "I'm not sure what you mean by `--mode=release`. Is that the same as `--mode=release` in the `configure.py` file?",
       "reference": "Please just remove this line. We have the git history if we want the old version."
     },
     {
-      "prediction": "I don't think we need to spin the script engine resolver here.",
+      "prediction": "I'm not sure if this is a good place to put this, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place",
       "reference": "Can we put some of the code on a new line to make it more readable. The max line length was 120 now, right?"
     },
     {
-      "prediction": "I think we can remove the `if err != nil` here.",
+      "prediction": "I think we can remove the `if err != nil` here, since it's already checked by the `if err != nil` in the `if err != nil { ... }` block.",
       "reference": "Remove the handling here as well."
     },
     {
-      "prediction": "I don't think this is a good idea. We should be able to do this in a single call to `TryAdd` instead.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `OnStart` method as well, so that we don't have to do this in the `OnEnd` method.",
       "reference": "Do we want to make this configurable?"
     },
     {
@@ -29743,7 +29743,7 @@
       "reference": "Prefer adding a second `positive(String, double)` that delegates down to this three-param version. Using `null` in code is generally Not A Great Idea, and it looks ugly."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a column for the approving official name.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this",
       "reference": "Is this going to break things for 18F proposals, or will these fields just be ignored?"
     },
     {
@@ -29755,11 +29755,11 @@
       "reference": "What's the reason for moving this to config from status?"
     },
     {
-      "prediction": "I think this should be `ret = suppress_file_handler.write_to_suppress_file(self.suppress_file, bug_id, file_name, comment)`",
+      "prediction": "I think it's better to use `self.suppress_file` instead of `self.suppress_file_handler` in this case.",
       "reference": "Shouldn't we re validate/update the in memory suppress data here?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"works with default payer\"",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate test for this case. I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate test for this case. I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate test for this case. I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate test for this case. I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate test for this case. I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate test for this case. I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate test for this case. I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate test for this case. I'm not sure if this is the",
       "reference": "curious why the renumbering is required here and elsewhere?"
     },
     {
@@ -29767,43 +29767,43 @@
       "reference": "s/must specify secrets/must specify secrets or Role info/"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `at: \"blazer\"` in this case.",
+      "prediction": "I'm not sure what you're trying to achieve with this, but I think it's better to just use `Blazer::Engine` instead of `Blazer::Engine, at: \"blazer\"`.",
       "reference": "let's leave this as a dev-only feature, and copy prod db to local env when needed. that keeps blazer security issues to a minimum."
     },
     {
-      "prediction": "I'm not sure what you mean by \"AlwaysOffActivitySampler\". Is this the same as \"AlwaysOffSampler\"?",
+      "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `ActivitySampler` base class.",
       "reference": "We'll be renaming ActivitySampler to Sampler anyway, so this change will be non-required. Prefer to avoid changes here to avoid merge conflict with my PR doing the rename."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `mutateHeadersByRules` function, since it's called by the `mutateHeaders` function. I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `mutateHeadersByRules` function, since it's called by the `mutateHeaders` function. I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `mutateHeadersByRules` function, since it's called by the `mutateHeaders` function. I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `mutateHeadersByRules` function, since it's called by the `mutateHeaders` function. I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `mutateHeadersByRules` function, since it's called by the `mutateHeaders` function. I'm not sure if this is the right place to",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I think it's a good way to do it, but I'm not sure if this is the best way to do it. I think it's a good way to do it, but I'm not sure if this is the best way to do it. I think it's a good way to do it, but I'm not sure if this is the best way to do it. I think it's a good way to do it, but I'm not sure if this is the best way to do it. I think it's a good way to do it, but I'm not sure if this is the best way to do it. I think it's a good way to do it, but I'm not sure if this is the best way to do it. I think it's a good way to do it, but I'm not sure if this is the best way to do it. I think it's a good way to do it, but I'm not sure if this is the best way to do it. I think it's a good way to do it, but I'm not sure if this is the best way",
       "reference": "This applies only in the \"set\" headers case, but what about \"adding\" a header (field prefixed with `+`)?"
     },
     {
-      "prediction": "I think this should be `@Deprecated` instead of `@Retention(RetentionPolicy.RUNTIME)`.",
+      "prediction": "I don't think this is a good idea. The `@Deprecation` annotation should be used to indicate that the method is deprecated, not to indicate that the class itself is deprecated.",
       "reference": "I'm not sure we should deprecate this. I kinda like the idea, that we would provide all exceptions (if we throw any) with a common super type. Of course, the exception should be not a checked exception like this one, but rather a runtime exception. We maybe need additionally an internal exception that we would convert into such a public API exception. But that's out of scope of this PR - that's the question of exception handling."
     },
     {
-      "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to have a `tab_index` method that returns the index of the tab in the list of tabs, rather than the index of the tab in the list of tabs.",
+      "prediction": "I'm not sure I understand what you're trying to do with this exception. Is it related to the `TabDeletedError` or the `MarkNotSetError`? If it's related to the `MarkNotSetError`, then I think we should raise that as well. If it's related to the `TabDeletedError`, then I think we should raise that as well.",
       "reference": "You'll need to adjust the docstring :wink:"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. Is it that you want to set the `m_expectsInlineQos` attribute to `true`? Or is it that you want to set the `m_expectsInlineQos` attribute to `false`? I'm not sure what you're trying to do here. Is it that you want to set the `m_expectsInlineQos` attribute to `true`? Or is it that you want to set the `m_expectsInlineQos` attribute to `false`? I'm not sure what you're trying to do here. Is it that you want to set the `m_expectsInlineQos` attribute to `true`? Or is it that you want to set the `m_expectsInlineQos` attribute to `false`? I'm not sure what you're trying to do here. Is it that you want to set the `m_expectsInlineQos` attribute to `true`? Or is it that you want to set the `m_expectsInlineQos` attribute to `false`? I'm not sure what you're trying to do here. Is it that you want to set the `m_expectsInlineQ",
+      "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason you want to set `m_expectsInlineQos` to `false` here?",
       "reference": "Add a TODO explaining why this is being done"
     },
     {
-      "prediction": "I'm not sure what you mean by \"this contains a dictionary data structure with```\n\nI'm not sure what you mean by \"this contains a dictionary data structure with```\n\nI'm not sure what you mean by \"this contains a dictionary data structure with```\n\nI'm not sure what you mean by \"this contains a dictionary data structure with```\n\nI'm not sure what you mean by \"this contains a dictionary data structure with```\n\nI'm not sure what you mean by \"this contains a dictionary data structure with```\n\nI'm not sure what you mean by \"this contains a dictionary data structure with```\n\nI'm not sure what you mean by \"this contains a dictionary data structure with```\n\nI'm not sure what you mean by \"this contains a dictionary data structure with```\n\nI'm not sure what you mean by \"this contains a dictionary data structure with```\n\nI'm not sure what you mean by \"this contains a dictionary data structure with```\n\nI'm not sure what you mean by \"this contains a dictionary data structure with```\n\nI'm not sure what you mean by \"this contains a dictionary data structure with```\n\nI'm not sure what you mean by \"this contains a dictionary data structure with```\n\nI'm not sure",
+      "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to have a separate class for this. It's a bit of a mess, but I think it's a good idea to have a separate class for this.",
       "reference": "This file still uses Blockly.VariableModel..."
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this field, but I think we should remove it.",
+      "prediction": "I'm not sure what you mean by \"public\" in this context. Is it referring to the public IP address of the machine pool? If so, I think we should remove the `Public` field from the `ManagedRemoteAccess` struct.",
       "reference": "Small nit, in the PR description its `publicAccess` but here its `public`. Guessing the preferred naming is public?"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason why you'd want to use a Decoder?",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a separate type for the Decoder.",
       "reference": "Maybe `driver.Watcher` -> provider (2x)? This is the concrete type, this user doesn't really know anything about the driver."
     },
     {
-      "prediction": "I think we can remove the `getDocValues()` method, since it's not used anywhere.",
+      "prediction": "I'm not sure if this is the best place to put this, but I think we should move it to the `DocValuesConsumer` class.",
       "reference": "can we remove this since `getDocValues` already returns an iterator? (we might need to do `T extends DocIdSetIterator` above)"
     },
     {
@@ -29811,71 +29811,71 @@
       "reference": "Don't check this in. This is already implemented in core_extensions/ruby/string.rb"
     },
     {
-      "prediction": "I don't think this is needed anymore. The `writeable` property is not needed anymore.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "This is used for both `id`, and `hash` we may not want these both to be enumerable."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I'm not sure if this is the best way to do it.",
+      "prediction": "I'm not sure what you're trying to do here, but I think it's a bad idea to mutate the `formatters` array.",
       "reference": "Is this necessary? I would expect YARD to treat it as public anyway... (Don't hold off merging on this...I'm mostly just curious)."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the `GetActivityScheduledEvent` method.",
       "reference": "@wxing1292 to double check this is the right version to use?"
     },
     {
-      "prediction": "I think this should be `null` instead of `null && $this->max_bound === null`.",
+      "prediction": "I think this should be `null !== $this->min_bound && $this->min_bound > 0`",
       "reference": "Shouldn't there be another case for when both min and max are specified?"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I don't think it's a good idea.",
+      "prediction": "I don't think this is necessary.",
       "reference": "Don't miss this one `2: I102 copyright year is outdated, expected 2014 but got 2013`. Thanks"
     },
     {
-      "prediction": "I think we can remove the `if (tail_ && tail_->len_ > 0)` check.",
+      "prediction": "I think we can remove the `if (tail_ == 0)` check here.",
       "reference": "the tail_ maybe nullptr?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this.",
+      "prediction": "I don't think we need to do this. The `syncPodEntry` function is the same as the `createPodEntry` function, so we don't need to change anything.",
       "reference": "The PR description mentions that `The controller code is extended to react to \"add\" events`, but I don't see any additional cases added here beyond the existing Create and Delete... is there something I'm missing?"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a `to_h` method in the OpenStruct class.",
+      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
       "reference": "Does it matter that #include changed to #include? ? I think the change makes sense since it aligns with the method name on Hash but unsure if anything called #include that would break with the change."
     },
     {
-      "prediction": "I'm not sure what you mean by \"very small values are unsafe and lead to high failure rate\"",
+      "prediction": "I think this should be `minimumImagePullInactivityTimeout` instead of `minimumTaskCleanupWaitDuration`.",
       "reference": "LGTM, curious though why exactly this is in place, and are there any possible issues from not waiting long enough?"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a good idea to remove the `@network_manager.cleanup` line.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `cleanup` phase of the `Beaker::Run` class.",
       "reference": "?: is unnecessary because we already force preserve_hosts to be a string with to_s."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate endpoint for the `get` and `delete` methods. This way, we don't have to worry about the order in which the methods are called, and we don't have to worry about the order in which the methods are called.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate endpoint for the `get` and `delete` methods. The `get` method will be used to get the size of the queue, and the `delete` method will be used to delete the queue. The `get` method will be used to get the size of the queue, and the `delete` method will be used to delete the queue. The `get` method will be used to get the size of the queue, and the `delete` method will be used to delete the queue. The `get` method will be used to get the size of the queue, and the `delete` method will be used to delete the queue. The `get` method will be used to get the size of the queue, and the `delete` method will be used to delete the queue. The `get` method will be used to get the size of the queue, and the `delete` method will be used to delete the queue. The `get` method will be used to get the size of the queue, and the `delete` method will be used to delete the queue. The `get` method will be used",
       "reference": "should it be `newsessionqueue` or `newsessionqueuer`? In case we'd like to be consistent"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to call `console.warn` multiple times in a single test.",
+      "prediction": "I don't think this is a good idea. I think it's better to just use `console.warn` and `console.error` instead of `console.log` and `console.error`.",
       "reference": "Since lazy is re-rendered when mounting the fallback, these checks get triggered an additional time."
     },
     {
-      "prediction": "I'm not sure what you mean by \"editable\" in this context. Is it referring to the ability to edit the content of the element, or something else? If it refers to the ability to edit the content of the element, then it's not editable. If it refers to the ability to edit the content of the element, then it's editable.",
+      "prediction": "I don't think this is a good idea. The `is_content_editable_prop` method is only called if the element is not editable. If the element is editable, we should not call this method.",
       "reference": "There is a `is_content_editable()` method just above this, what's the difference?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this field, but I think we should remove it.",
+      "prediction": "I think we should remove the `ServiceMonitorSelector` as it's not used anymore.",
       "reference": "Hmm, I'm not sure this is exactly what we want to get across. The behavior of leaving both values unset allowing the entire config to be managed is what is indeed deprecated. It's just that not the entire field is deprecated, just that one behavior."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `output_cb` function as well.",
+      "prediction": "I'm not sure if this is the best place to do this, but I think it's a good idea to do this in the `output_cb` function.",
       "reference": "Given the slightly vague discussion in basename(3) about POSIX basename (modifies arg) vs GNU (doesn't), I always assumed it was advisable to pass a string copy However, I guess you'd get a \"discarding const\" warning promoted to error by our build system here if you were getting the POSIX implementation. Hah! Cool, I probably can go remove some memory copies in other parts of the code where those conditions exist."
     },
     {
-      "prediction": "I think we can remove this test as it's not relevant to the test case.",
+      "prediction": "I think we can remove this test as it's not relevant to the current test.",
       "reference": "Do you know somehow that this was the culprit? Even 1 minute is a lot, so I would expect the bug to lie somewhere else."
     },
     {
-      "prediction": "I don't think this is a good idea. We should be able to do this in a single call to `asyncMultiPut`.",
+      "prediction": "I don't think this is a good idea. We need to make sure that we don't have more than 10000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
       "reference": "what to do if some failed? just logging?"
     },
     {
@@ -29883,23 +29883,23 @@
       "reference": "since these thoughts are all Jack Handey's the generator should probably be called `jack_handey` to reflect that."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to add a new field to the `EnvironmentFiles` map, but I'm not sure what you're trying to do with it. I think you're trying to add a new field to the `EnvironmentFiles` map, but I'm not sure what you're trying to do with it. I think you're trying to add a new field to the `EnvironmentFiles` map, but I'm not sure what you're trying to do with it. I think you're trying to add a new field to the `EnvironmentFiles` map, but I'm not sure what you're trying to do with it. I think you're trying to add a new field to the `EnvironmentFiles` map, but I'm not sure what you're trying to do with it. I think you're trying to add a new field to the `EnvironmentFiles` map, but I'm not sure what you're trying to do with it. I think you're trying to add a new field to the `EnvironmentFiles` map, but I'm not sure what you're trying to do with it. I think you're trying to add a new field to the `EnvironmentFiles` map, but I",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `EnvironmentFiles` section.",
       "reference": "this file is autogenerated. you should edit `model/api/api-2.json` and then go generate this file. otherwise the next people generating api.go will remove the changes you added here"
     },
     {
-      "prediction": "I think this should be `@trail = TrailWithProgress.new(_trail, user: current_user)` instead of `@trail = TrailWithProgress.new(_trail, user: current_user)`",
+      "prediction": "I think this should be `current_user` instead of `current_user`",
       "reference": "Extra empty line detected at class body beginning."
     },
     {
-      "prediction": "I think this should be `exflow.getFlowId()` instead of `exflow.getId()`.",
+      "prediction": "I think it's better to use `exflow.getProjectName()` instead of `exflow.getProjectName().intern()`.",
       "reference": "This is smart but hacky! I would probably prefer an alternate solution that would be more obvious to read/understand."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to update the capacity of a table, but I'm not sure what you're trying to do with the `targetTableRcu` and `targetTableWcu` fields.",
+      "prediction": "I'm not sure what you mean by `targetTableRcu int64, targetTableWcu int64`. Is this the same as `targetIndexRcu int64, targetIndexWcu int64`?",
       "reference": "i would not return a pointer for status here which is an int"
     },
     {
-      "prediction": "I think it's better to use `exclude` instead of `exclude_from` in this case. `exclude_from` is used when you want to exclude a specific function from the list of functions to be excluded. `exclude` is used when you want to exclude all functions from the list of functions to be excluded. `exclude_from` is used when you want to exclude a specific function from the list of functions to be excluded. `exclude` is used when you want to exclude all functions from the list of functions to be excluded.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a list of all the functions that we want to exclude. This way, we don't have to worry about forgetting to add a function to the exclude list when we add a new one.",
       "reference": "Those functions are not currently wrapped, so I don't think it is necessary to exclude them (at least for now)."
     },
     {
@@ -29907,11 +29907,11 @@
       "reference": "Should we specify the name of the folder?"
     },
     {
-      "prediction": "I think this should be `from rdkit.Chem import rdqueries` instead of `from rdkit.Chem import rdqueries`",
+      "prediction": "I think this should be `from rdkit.Chem import rdqueries, rdmolops` instead of `from rdkit.Chem import rdqueries, rdmolops`",
       "reference": "it's not wrong, but you don't technical need `rdmolops` here since it's imported as part of `Chem`"
     },
     {
-      "prediction": "I think this should be `self.log.info('ListenBrainz listen dump done!')` instead of `self.log.info('ListenBrainz listen dump done!')`",
+      "prediction": "I think we should remove the `self.log.info('ListenBrainz listen dump done!')` line.",
       "reference": "I think the absence of this might have been the cause of the dump file corruption. We didn't wait for the pxz command to exit, leading to a race condition between the cp and this, leading to corrupted files in some places. I came across this because the hashes created and printed were different from the hashes of the actual files in dev also."
     },
     {
@@ -29919,11 +29919,11 @@
       "reference": "Out of the scope."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
+      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to simulate a mouse click on the column header, but you're not actually doing anything with it. I'm not sure what you're trying to do here, but it looks like you're trying to simulate a mouse click on the column header, but you're not actually doing anything with it. I'm not sure what you're trying to do here, but it looks like you're trying to simulate a mouse click on the column header, but you're not actually doing anything with it. I'm not sure what you're trying to do here, but it looks like you're trying to simulate a mouse click on the column header, but you're not actually doing anything with it. I'm not sure what you're trying to do here, but it looks like you're trying to simulate a mouse click on the column header, but you're not actually doing anything with it. I'm not sure what you're trying to do here, but it looks like you're trying to simulate a mouse click on the column header, but you're not actually doing anything with it. I'm not sure what you're trying to do here, but it looks like you're trying to simulate a",
       "reference": "Maybe `sortByColumnHeader` would be more precise? The plugin has a method with the same name and it could be confusing."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is the right way to do it.",
+      "prediction": "I don't think this is necessary. We can just use `oldParentVNode != null && oldParentVNode != EMPTY_OBJ && oldParentVNode._children` instead.",
       "reference": "@developit I vaguely remember you mentioning something about some JS engines having an escape analysis feature that makes objects (and arrays?) locally declared that never leave the function essentially free from a GC perspective or something. Do you think we could benefit from that here? Or should we leave this as it is?"
     },
     {
@@ -29931,15 +29931,15 @@
       "reference": "Remind me why this is needed?"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here.",
+      "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason why you want to use a `BooleanClause.Occur.FILTER` instead of a `BooleanClause.Occur.MASK`?",
       "reference": "same as above, can this be null now?"
     },
     {
-      "prediction": "I think this should be `for (long e = 0; e < cv.lengths[rowId]; ++e)` instead of `for (int e = 0; e < cv.lengths[rowId]; ++e)`.",
+      "prediction": "I think this should be `for (int e = 0; e < cv.lengths[rowId]; ++e)`",
       "reference": "This doesn't make sense to me. Should `cv.lengths` be an integer array instead of longs? It looks like they should always be integers since the values are assigned from `ArrayData#numElements()`. That's very likely an int."
     },
     {
-      "prediction": "I think this should be `if (id.StartsWith(MsDataFileImpl.PREFIX_SINGLE))` instead of `if (id.StartsWith(MsDataFileImpl.PREFIX_PRECURSOR))`",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `MsDataFileImpl` class.",
       "reference": "str.Substring(3).Split(' ')[0] would also work and is more concise."
     },
     {
@@ -29947,15 +29947,15 @@
       "reference": "Did you mean to negate the not_a_peer check?"
     },
     {
-      "prediction": "I don't think we need to change anything here. I'm not sure if we need to change anything here. I'm not sure if we need to change anything here. I'm not sure if we need to change anything here. I'm not sure if we need to change anything here. I'm not sure if we need to change anything here. I'm not sure if we need to change anything here. I'm not sure if we need to change anything here. I'm not sure if we need to change anything here. I'm not sure if we need to change anything here. I'm not sure if we need to change anything here. I'm not sure if we need to change anything here. I'm not sure if we need to change anything here. I'm not sure if we need to change anything here. I'm not sure if we need to change anything here. I'm not sure if we need to change anything here. I'm not sure if we need to change anything here. I'm not sure if we need to change anything here. I'm not sure if we need to change anything here. I'm not sure if we need to change anything here. I'm not sure if we need to change anything here. I'm not sure if",
+      "prediction": "I don't think we need to change anything here.",
       "reference": "Copyright (C) 2010-2021 DBeaver Corp and others"
     },
     {
-      "prediction": "I don't think we need to use `QStyleOptionViewItem` here. We can use `QStyledItemDelegate` directly.",
+      "prediction": "I don't think it's necessary to import `QStyleOptionViewItem` and `QStyledItemDelegate` from `PyQt5.QtWidgets`.",
       "reference": "This seems like an unrelated change"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to set the keyring label to the parent process's label, which is not what you want to do.",
+      "prediction": "I think this should be `if err != nil { return err; }` instead of `if !l.config.Config.NoNewKeyring { return err; }`",
       "reference": "Just to double-check -- are you sure this needs to be done *before* we create a new session? (Is `SetKeyLabel` setting what the label will be for all future keys or the label for the current key?)"
     },
     {
@@ -29963,19 +29963,19 @@
       "reference": "I thought we were removing the FAIL policy altogether...."
     },
     {
-      "prediction": "I'm not sure what you mean by \"exists\" in this context. Is it referring to the existence of a file in the current working directory?",
+      "prediction": "I don't think this is necessary. We can just use `txt2tags.exec_command_line([\"--outfile\", str(source[0])[:-3] + \"html\", str(source[0])])`",
       "reference": "Could you elaborate on why you made this change?"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `CHECK_SEMANTIC_VALUE` instead of `CHECK_SEMANTIC_TYPE` and `CHECK_SEMANTIC_VALUE` instead of `CHECK_SEMANTIC_TYPE` and `CHECK_SEMANTIC_VALUE` instead of `CHECK_SEMANTIC_TYPE` and `CHECK_SEMANTIC_VALUE` instead of `CHECK_SEMANTIC_TYPE` and `CHECK_SEMANTIC_VALUE` instead of `CHECK_SEMANTIC_TYPE` and `CHECK_SEMANTIC_VALUE` instead of `CHECK_SEMANTIC_TYPE` and `CHECK_SEMANTIC_VALUE` instead of `CHECK_SEMANTIC_TYPE` and `CHECK_SEMANTIC_VALUE` instead of `CHECK_SEMANTIC_TYPE` and `CHECK_SEMANTIC_VALUE` instead of `CHECK_SEMANTIC_TYPE` and `CHECK_SEMANTIC_VALUE` instead of `CHECK_SEMANTIC_TYPE` and `CHECK_SEMANTIC_VALUE` instead of `CHECK_SEMANTIC_TYPE` and `CHECK_SEMANTIC_VALUE` instead of `CHECK_SEMANTIC_TYPE` and `CHECK_SEMANTIC_VALUE",
+      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. Is it that you want to check that the type is a string, and if it is, that it is a string literal? Or is it that you want to check that the type is a string, and if it is, that it is a string literal? Or is it that you want to check that the type is a string, and if it is, that it is a string literal? Or is it that you want to check that the type is a string, and if it is, that it is a string literal? Or is it that you want to check that the type is a string, and if it is, that it is a string literal? Or is it that you want to check that the type is a string, and if it is, that it is a string literal? Or is it that you want to check that the type is a string, and if it is, that it is a string literal? Or is it that you want to check that the type is a string, and if it is, that it is a string literal? Or is it that you want to check that the type is a string, and if",
       "reference": "before the fix, does this sentence make service crash? My point is can you re-produce the problem. I'm not sure the bug is due to non-asiic code"
     },
     {
-      "prediction": "I don't think we need to check for IsApiToken here.",
+      "prediction": "I don't think we need to check for `IsApiToken` here, since we're already checking for `c.Data[\"IsApiToken\"]` in `reqToken`.",
       "reference": "This comparison looks a bit strange, we should first check existence of key \"IsApiToken\" and then check if it is equal to true. ~~Besdies, s/IsApiToken/IsAuthedByToken/~~"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. Can you please provide more context? I'm not sure I understand what you're trying to do here. Can you please provide more context? I'm not sure I understand what you're trying to do here. Can you please provide more context?",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check here to make sure we don't try to apply a resource that already exists in the cluster.",
       "reference": "This might be working as is, but I'm a bit thrown by the || and then && and how things get evaluated. Testing real quick on the go playground, true || false && false seems to either evaluate the && first, or start on the right side. Anyhow could you group with braces, it looks to me like it should be ( a || b) && c in this case?"
     },
     {
@@ -29983,51 +29983,51 @@
       "reference": "add an entry in makefile to generate binary with diff name?"
     },
     {
-      "prediction": "I think it's better to use `errors.New` instead of `errors.Wrap` here. `errors.New` is more explicit about the error type.",
+      "prediction": "I think it's better to use `errors.Wrapf` instead of `errors.New` here.",
       "reference": "hmm so we didn't validate the HTTP config for all receivers?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the  class.",
+      "prediction": "I'm not sure if this is the best place to put this, but I think it would make sense to move it into the `SpanContext` class.",
       "reference": "ITextFormatActivity had this, can I add to have the same effect?"
     },
     {
-      "prediction": "I think we can remove the `github.com/aws/amazon-ecs-agent/agent/taskresource/status` package.",
+      "prediction": "`containerstatus` and `containerresource` should be in the same package.",
       "reference": "not blocking: can we remove extra lines here?"
     },
     {
-      "prediction": "I think this should be `if (typeof(data) === 'undefined' || data === 'random')` instead of `if (typeof(data) === 'undefined' || data === 'random')`",
+      "prediction": "I don't think this is necessary.",
       "reference": "This just feels weird... can we use some kind of constant here? something like: `if (_.isUndefined(data) || data === PrivateKey.Random)`"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this method to the `CompilerPassInterface` so that it can be used by other passes.",
       "reference": "if does not have a class I guess the exception should be thrown because we cannot recognize the type based on it?"
     },
     {
-      "prediction": "I think we should remove the `true` from the first line of the `createFieldMaskField` method.",
+      "prediction": "I think we should change this to a `Set` instead of a `List`.",
       "reference": "LOL: use your GitHub username?"
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear what you're trying to do with this key. If you want to get rid of the prefix, you can just call `toRawKey(prefixNext(value))`. If you want to get rid of the rid, you can just call `toRawKey(prefixNext(value) + 1)`.",
+      "prediction": "I don't think this is needed.",
       "reference": "any tests for nextPrefix() ?"
     },
     {
-      "prediction": "I'm not sure what you mean by `n.getMaximumCommonType().ifPresent(t -> t.accept(this, arg));` I think you want `n.getMaximumCommonType().ifPresent(t -> t.accept(this, arg));`",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `printModifiers` method as well.",
       "reference": "In general I'm saying \"if there is no common type I'm just going to skip some stuff and fail silently.\""
     },
     {
-      "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to have it in the same package as the other ones.",
+      "prediction": "I'm not sure if this is a good place to put this, but I think we should move it to the `eventing/pkg/apis/messaging` package. It's a bit more general than the `eventing/pkg/apis/configs/gcpauth` package.",
       "reference": "did we move the eventing logging here? Probably the eventing logging was removing and they are now using the pkg logging in eventing. If that is the case, we should do the same here"
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `Handler` struct, since it's not a method of the `Handler` struct.",
+      "prediction": "I'm not sure if this is the right place to put this. I think we should move it to the `http` package, but I'm not sure if that's the right place to put it.",
       "reference": "I think that `Handler` should preserve the `operation` member and the span formatter should receive the operation name string as a parameter too, otherwise the `operation` parameter in the `NewHandler` function becomes useless if we pass a custom span formatter. Also, shouldn't it be called `spanNameFormatter`?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `None` for the `sourceip` field.",
+      "prediction": "I think this should be `IPField(\"sourceip\", \"127.0.0.1\")` instead of `IPField(\"sourceip\", None)`.",
       "reference": "Can you merge #466? That would make the current `None` default value working and more relevant that `\"127.0.0.1\"`."
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. I'm not sure if you're trying to set a value for a reserved field, or if you're trying to set a value for a non-reserved field. If you're trying to set a value for a non-reserved field, you should be able to do that with the `DecodeValue` method. If you're trying to set a value for a reserved field, you should be able to do that with the `SetReservedField` method. If you're trying to set a value for a non-reserved field, you should be able to do that with the `DecodeValue` method. If you're trying to set a value for a reserved field, you should be able to do that with the `SetReservedField` method. If you're trying to set a value for a non-reserved field, you should be able to do that with the `DecodeValue` method. If you're trying to set a value for a reserved field, you should be able to do that with the `SetReservedField` method. If you're trying to set a value for a non-reserved field, you should be able to do that",
+      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. I'm not sure if it's a good idea to check if a field is reserved before setting it as a search attribute.",
       "reference": "is reserved filed name the only possible reason this could fail?"
     },
     {
@@ -30035,23 +30035,23 @@
       "reference": "Would a KBFS_DISABLE_JOURNAL make more sense?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a warning message here.",
+      "prediction": "I don't think this is a good idea.",
       "reference": "BTW. What's the message meaning?..."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to have a separate test for `#numeric?` in this case.",
+      "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to have a separate test for `numeric?` in `Mongoid::Extensions::Object`. I think it's better to have a single test for `numeric?` in `Mongoid::Extensions::Object`.",
       "reference": "this should say false"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think we should just remove the `+build unit` line.",
+      "prediction": "I'm not sure if this is a unit test or not. I think it should be a unit test, but I'm not sure if this is a unit test or not. I think it should be a unit test, but I'm not sure if this is a unit test or not. I think it should be a unit test, but I'm not sure if this is a unit test or not. I think it should be a unit test, but I'm not sure if this is a unit test or not. I think it should be a unit test, but I'm not sure if this is a unit test or not. I think it should be a unit test, but I'm not sure if this is a unit test or not. I think it should be a unit test, but I'm not sure if this is a unit test or not. I think it should be a unit test, but I'm not sure if this is a unit test or not. I think it should be a unit test, but I'm not sure if this is a unit test or not. I think it should be a unit test, but I'm not sure if this is a unit test or not. I think it should be a unit test, but I'm not",
       "reference": "for my understanding - are this line and the next line both necessary? they seem to contain duplicate information. same for the other test files"
     },
     {
-      "prediction": "I think this should be `if config.val.url.open_base_url and term in config.val.url.searchengines.keys():`",
+      "prediction": "I think this should be `if config.val.url.open_base_url and term in config.val.url.searchengines.keys()`, not `if config.val.url.open_base_url and term in config.val.url.searchengines.keys() and term in config.val.url.searchengines.keys()`.",
       "reference": "No need for the `.keys()`, iterating over a dictionary gives you its keys (and thus you can also do `key in some_dict`). With that, it also fits on one line :wink:"
     },
     {
-      "prediction": "I don't think this is needed.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.",
       "reference": "If we want to avoid the user calling constructor and destructor, we should add `= delete` to their declarations. If we just want to avoid writing the default behavior, we should add `= default` to the declarations. I'm more in favor of the second option to avoid an API break."
     },
     {
@@ -30059,27 +30059,27 @@
       "reference": "My preference here is to keep a stricter hierarchy. We should have a mixin or something that is an AssetEvent that Observation and Materialization can both inherit from. That way we can check the type in the frontend if we need to."
     },
     {
-      "prediction": "I think this test should be moved to a separate test class.",
+      "prediction": "I think this test should be moved to a separate test file.",
       "reference": "Can also cast them as `set`s and compare them."
     },
     {
-      "prediction": "I don't think this is necessary.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "Still TODO I guess?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"using namespace eprosima::fastrtps\"",
+      "prediction": "I think this should be `using namespace rtps` instead of `using namespace eprosima::fastrtps`.",
       "reference": "Another cleanup. There are two additional `using namespace std::chrono;` under this one. Should also remove std::chrono:: from the full file. Please do this on a single commit."
     },
     {
-      "prediction": "I'm not sure if this is the right place to add the `scopePropertyMetaModel` to the `fieldAccessExprMetaModel`. I think it's better to add it to the `enclosedExprMetaModel` instead.",
+      "prediction": "I don't think we need to add `scopePropertyMetaModel` here.",
       "reference": "Looking at this list of boolean flags I wonder if we should create enums for all of these options, so that the code becomes much more readable"
     },
     {
-      "prediction": "I think this should be `using namespace eprosima::fastrtps;` instead of `using namespace std;`",
+      "prediction": "I think this should be `using namespace std;` instead of `using namespace eprosima::fastrtps;`",
       "reference": "Is this necessary?"
     },
     {
-      "prediction": "I think this should be `CosmosElement` instead of `CosmosElementType`.",
+      "prediction": "I think this should be `public abstract CosmosElementType Type { get; }`",
       "reference": "How about this NS inside query NS?"
     },
     {
@@ -30087,35 +30087,35 @@
       "reference": "in line 79, sm also can be stateReader"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have this in the `MetaClient` class, since it will be used by other parts of the code.",
+      "prediction": "I'm not sure if this is a good place to put this, but I think we should move it to `MetaClient.cpp` so that we don't have to include it in `MetaClient.h` and `MetaClient.cpp`.",
       "reference": "maybe can not return a map directly, it will be modified by inner thread."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a test for this.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way",
       "reference": "What is the actual change here, why is this test change needed? Now the diff will send back more data?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"mark any wildcards in input molecule:\"",
+      "prediction": "I'm not sure what you mean by \"clean any existing R group numbers\"",
       "reference": "Might be better to use a tag here. I for one have used 1000 isotopes as a tag in the past..."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate test for this. It's",
+      "prediction": "I don't think we need to check for recording here, since it's already set to `false` by default.",
       "reference": "This tests seems it was broken from the start :joy:. It \"worked\" because the old sample chance was small enough that this have always be off. Thanks for fixing this. Could you also change the strings on this test? `\"Recording off\"` and `\"new span is recording events\"`"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason you want to return `false` here?",
+      "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason you want to return `false` here?",
       "reference": "This is not actually the case, you need to modify `toConfiguration` below to prevent a configuration from being produced"
     },
     {
-      "prediction": "I'm not sure what you mean by \"no SVID found\" in this context. I think you meant to say \"no SVID found\" in this context.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check for the existence of the SVID before trying to load it.",
       "reference": "I'm worried about we hide some important log here"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to close the `pool` when we're done with it.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to close the `pool` after the `callback` is called.",
       "reference": "Python 3 will throw an exception for inf, but not providing a timeout will result in no timeout exception."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate handler for the `/bzz-tag/uuid/{uuid}` route.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate handler for the `/bzz-tag/uuid/{uuid}` route. That way, we don't have to duplicate the logic in the `/bzz-tag/name/{name}` and `/bzz-tag/addr/{addr}` routes.",
       "reference": "As this method changes the state, it should be `POST`. Also, maybe to rename it to `createTag`?"
     },
     {
@@ -30123,43 +30123,43 @@
       "reference": "`ctx` is unused in rollbackTraffic"
     },
     {
-      "prediction": "I think this should be `Guids.guidVSPackage` instead of `Guids.guidVSPackageString`",
+      "prediction": "I think this should be `guidVSPackageString` instead of `guidVSPackage`",
       "reference": "Roslyn conventions have const in PascalCase."
     },
     {
-      "prediction": "I'm not sure what you mean by \"different from the 2181\". I think you meant \"different from the 2888:2888\" or \"different from the 2181:2181\" or \"different from the 2888:2888\" or \"different from the 2181:2181\" or \"different from the 2888:2888\" or \"different from the 2181:2181\" or \"different from the 2888:2888\" or \"different from the 2181:2181\" or \"different from the 2888:2888\" or \"different from the 2181:2181\" or \"different from the 2888:2888\" or \"different from the 2181:2181\" or \"different from the 2888:2888\" or \"different from the 2181:2181\" or \"different from the 2888:",
+      "prediction": "I don't think we need to do this.",
       "reference": "This is not bullet proof if e.g. user has `clientPort=1234` in `zoo.cfg` and in zkHost connection string. Then we'll add a warning that dynamic config differs from zkHost, which is not entirely true since we just lack the port part. We have no way from client to read the `clientPort` from server except from connecting to the server with 4LW *ont the clientPort* which is a chicken and egg. This hack will make the comparison work for default port, which is a compromise."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to use the `MessagePack` library, but you're not using the `Datadog.Trace.Vendors.MessagePack.Formatters` namespace.",
+      "prediction": "I think this should be `using Datadog.Trace.Agent.MessagePack.Formatters;` instead of `using MessagePack.Formatters;`",
       "reference": "We can probably delete this entire file. It's not used now and we'll (probably) write a custom serializer before we ever switch to MessagePack 2.1."
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `raw_ssh_args` section of the `playbook.yml` file.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `raw_ssh_args` instead of `raw_ssh_args` and `raw_ssh_args` instead of `raw_ssh_args` and `raw_ssh_args` instead of `raw_ssh_args` and `raw_ssh_args` instead of `raw_ssh_args` and `raw_ssh_args` instead of `raw_ssh_args` and `raw_ssh_args` instead of `raw_ssh_args` and `raw_ssh_args` instead of `raw_ssh_args` and `raw_ssh_args` instead of `raw_ssh_args` and `raw_ssh_args` instead of `raw_ssh_args` and `raw_ssh_args` instead of `raw_ssh_args` and `raw_ssh_args` instead of `raw_ssh_args` and `raw_ssh_args` instead of `raw_ssh_args` and `raw_ssh_args` instead of `raw_ssh_args` and `raw_ssh_args` instead of `raw_ssh_args` and `raw_ssh_args` instead of `raw_ssh_args` and `raw_ssh_args` instead of `raw_ssh_args` and `raw_ssh_args` instead of `raw_ssh_args` and `raw_ssh_args` instead of `raw_ssh_args",
       "reference": "Aren't you duplicating this option?"
     },
     {
-      "prediction": "I think we can remove the `|` from the end of the string.",
+      "prediction": "I think this should be `strings.Join(argument.Type, \"|\")` instead of `argType := strings.Join(argument.Type, \"|\")`",
       "reference": "I'm not sure we should be doing this based on the extension? Calling them `.build_defs` is just a convention"
     },
     {
-      "prediction": "I think this should be `T` instead of `T`",
+      "prediction": "I think this should be `unsupported_property` instead of `T`?",
       "reference": "Should remove in `_MissingPandasLikeMultiIndex:` too"
     },
     {
-      "prediction": "I think we should remove the `Subnets` field. It's not used anywhere.",
+      "prediction": "I'm not sure what you mean by \"subnets\" in this context. Could you please clarify?",
       "reference": "We should scope this down to the bits that we're actually using, otherwise the API is going to be problematic, as it includes references to NAT gateways and public and/or private subnets. Copying the types to be more local to the task in hand is fine."
     },
     {
-      "prediction": "I think we should remove the `json:\"additionalTags,omitempty\"` from the `AWSDNSZoneSpec` struct.",
+      "prediction": "I'm not sure what you mean by \"this defaults to us-east-1\". I think you meant to say \"this defaults to us-east-2\".",
       "reference": "Is it is a hard requirement for this field to be 'cn-northwest-1' when wanting to interact with AWS China? It appears that putting in 'cn-north-1' would also result in using the alternative API endpoint (with the region overridden to use 'cn-northwest-1' for the created AWS client)."
     },
     {
-      "prediction": "I'm not sure if this is a flaky test or not, but I think it's a flaky test. I'm not sure if this is a flaky test or not, but I think it's a flaky test. I'm not sure if this is a flaky test or not, but I think it's a flaky test. I'm not sure if this is a flaky test or not, but I think it's a flaky test. I'm not sure if this is a flaky test or not, but I think it's a flaky test. I'm not sure if this is a flaky test or not, but I think it's a flaky test. I'm not sure if this is a flaky test or not, but I think it's a flaky test. I'm not sure if this is a flaky test or not, but I think it's a flaky test. I'm not sure if this is a flaky test or not, but I think it's a flaky test. I'm not sure if this is a flaky test or not, but I think it's a flaky test. I'm not sure if this is a flaky test or not, but I",
+      "prediction": "I'm not sure if this is a flaky test or not, but I think it's a flaky test. I'm not sure if it's a flaky test or not, but I think it's a flaky test. I'm not sure if it's a flaky test or not, but I think it's a flaky test. I'm not sure if it's a flaky test or not, but I think it's a flaky test. I'm not sure if it's a flaky test or not, but I think it's a flaky test. I'm not sure if it's a flaky test or not, but I think it's a flaky test. I'm not sure if it's a flaky test or not, but I think it's a flaky test. I'm not sure if it's a flaky test or not, but I think it's a flaky test. I'm not sure if it's a flaky test or not, but I think it's a flaky test. I'm not sure if it's a flaky test or not, but I think it's a flaky test. I'm not sure if it's a flaky test or not, but I",
       "reference": "Stephen already fixed this one. Only the OverSize test is flaky now right?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"feedback_url\" in this context. Is this the same as `feedback_url_for(@proposal)`? If so, I think we should just use `t(\"mailer.footer\", feedback_url: feedback_url_for(@proposal))` instead.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.",
       "reference": "if the `activity_mailer` has a layout, should we include the footer in that? Realize there may also be conflicts with work @rememberlenny is working on..."
     },
     {
@@ -30171,27 +30171,27 @@
       "reference": "Is Java smart enough to know the generic type here? Never knew this."
     },
     {
-      "prediction": "I think this should be `BackupRepository` instead of `BackupRepositoryFactory`?",
+      "prediction": "I think this should be `BackupRepositoryFactory.newInstance(repo, BackupRepository.class)` instead of `BackupRepositoryFactory.newInstance(repo, BackupRepository.class)`.",
       "reference": "no thought given to reload"
     },
     {
-      "prediction": "I think we should remove the `isMetricAttributeDisabled(MetricAttribute attribute)` method. It's not needed anymore.",
+      "prediction": "I think this should be `isMetricAttributeDisabled(MetricAttribute attribute)` instead of `isMetricAttributeDisabled(MetricAttribute attribute)`",
       "reference": "Please, don't remove the `getDisabledMetricAttributes` method. All changes must be backward-compatible."
     },
     {
-      "prediction": "I think it's better to use `if (err.message.match(/no such (cmd|command)/) || err.message.match(/Failed to kill on some hosts/) || err.code === 11601)` instead of `if (err.message.match(/no such (cmd|command)/) || err.message.match(/Failed to kill on some hosts/) || err.code === 11601)`",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `prepareDatabaseForSuite` function as well.",
       "reference": "Is this left over from debugging?"
     },
     {
-      "prediction": "I think this is a bad idea. It's not clear to me why we need to close the client here. We don't need to close the client here. We can close the client when we're done with it.",
+      "prediction": "I think this should be `client.close()` instead of `done()`.",
       "reference": "I've fallen for this before myself :) We _do_ call `close` inside of `done` on L65"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think we need to use the `cfg.OpenProject` function here.",
+      "prediction": "I'm not sure if this is the right way to do this, but I think we should be able to do this in a single line of code.",
       "reference": "That looks fine! You could use `\"rclone/\"+fs.Version` too if you wanted. BTW does tardigrade use http under the hood? If you were using rclone's http Client then you'd get a User-Agent and you'd also get support for `-vv --dump bodies` and other nice things."
     },
     {
-      "prediction": "`neg_prob` should be `neg_prob.clamp(min=1e-12)`",
+      "prediction": "`neg_prob` should be `torch.clamp(neg_prob, min=1e-12)` instead of `torch.clamp(neg_prob, min=1e-12)`",
       "reference": "Adding one line `prob = prob.clamp(min=EPS, max=1-EPS)` already works."
     },
     {
@@ -30199,7 +30199,7 @@
       "reference": "another option would be to create a `CreateRequestQueue(bool lockingQeueue)`, and set it only in `InitializeTarget`, isn't? The would prefer having the creation and \"business\" rules for the creation in one region, I think `InitializeTarget` would be the best place."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `wl_list_insert` instead of `wl_list_remove`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea.",
       "reference": "Wait, I think the `subsurface_handle_place_above` code was correct before. `place_above` means \"place it above in rendering order\" right?"
     },
     {
@@ -30207,11 +30207,11 @@
       "reference": "why did this change?"
     },
     {
-      "prediction": "I'm not sure what you mean by `MakeInitialBareRootMetadataV3(tlfID, bh)`. Is this the same as `MakeInitialBareRootMetadata(tlfID, bh)`?",
+      "prediction": "I think we can remove the `tlf.FakeID(1, tlf.Private)` line.",
       "reference": "Do you think we should have some tests here for `tlf.SingleTeam` too?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"consumes\" in this context.",
+      "prediction": "I'm not sure what you mean by \"consumes\"",
       "reference": "No problem with this but might as well revert this file since nothing else changed."
     },
     {
@@ -30219,23 +30219,23 @@
       "reference": "In my changes, I did not create a new `AspNetScopeManager`. I'm not familiar with it enough to know if this is a valid change or not"
     },
     {
-      "prediction": "I think this should be `throw new Error(message);` instead of `throw new Error(message);`",
+      "prediction": "I think this should be `throw` instead of `throw new Error(message)`.",
       "reference": "Not cool with this. I think we talked about it in past. This is a side effect. If we want to introduce the side effect in our functions like `inRange` (which I am for) the side effect (error) should originate in that function and not in some internal `throwError` function. Every stacktract will start at line `2` of `trowError.js`. Been there, done that and falled back to throwing the error from the place where it should be thrown."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to extend `AutoCloseable` and `TraceContext` in this way. It's not clear what you're trying to do here, but I don't think it's a good idea to extend `AutoCloseable` and `TraceContext` in this way. It's not clear what you're trying to do here, but I don't think it's a good idea to extend `AutoCloseable` and `TraceContext` in this way. It's not clear what you're trying to do here, but I don't think it's a good idea to extend `AutoCloseable` and `TraceContext` in this way. It's not clear what you're trying to do here, but I don't think it's a good idea to extend `AutoCloseable` and `TraceContext` in this way. It's not clear what you're trying to do here, but I don't think it's a good idea to extend `AutoCloseable` and `TraceContext` in this way. It's not clear what you're trying to do here, but I don't think it's a good idea to extend `AutoCloseable",
+      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to add a `Status` to the `Span` object. I'm not sure what you're trying to do here, but it looks like you're trying to add a `Status` to the `Span` object. I'm not sure what you're trying to do here, but it looks like you're trying to add a `Status` to the `Span` object. I'm not sure what you're trying to do here, but it looks like you're trying to add a `Status` to the `Span` object. I'm not sure what you're trying to do here, but it looks like you're trying to add a `Status` to the `Span` object. I'm not sure what you're trying to do here, but it looks like you're trying to add a `Status` to the `Span` object. I'm not sure what you're trying to do here, but it looks like you're trying to add a `Status` to the `Span` object. I'm not sure what you're trying to do here, but it looks like you're trying to add a `Status` to the `Span` object.",
       "reference": "We don't need this additional method."
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this test, but I'm not sure if it's a good idea to throw an `IllegalArgumentException` here.",
+      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to mock the `loadUser` method of the `DefaultOAuth2UserService` class, but you're not actually using the `DefaultOAuth2UserService` class at all.",
       "reference": "The purpose of this test is to ensure that the `OAuth2UserRequest` passed into `loadUser` is **not** null else throw `IllegalArgumentException`. Changing the `List` of `OAuth2UserService` mocks to `DefaultOAuth2UserService` doesn't really apply to what is being tested here. Please revert this. Thank you."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to have `stakingV2` in the same package as `stakingProto`.",
+      "prediction": "I don't think we need `stakingV2` here.",
       "reference": "nit: rename to nativeStk? proto might lead to think protobuf"
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear to me what the purpose of this field is.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "Why not `queryUUID` (and reference the same constant as in other places)?"
     },
     {
@@ -30243,15 +30243,15 @@
       "reference": "This is also used to log, of which our convention is leading uppercase..."
     },
     {
-      "prediction": "I'm not sure what you mean by `less_precise=False`",
+      "prediction": "I'm not sure what you mean by `less_precise=False` in this case.",
       "reference": "What about we just name it `check_exact`?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate test for this.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this.",
       "reference": "before, a binary annotation had the same service name as a regular annotation, masking the bug where we weren't querying the latter"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a good idea to make this a class method.",
+      "prediction": "I'm not sure what you're trying to achieve with this, but I think we should remove the `as: :completeable` from the `has_one :step, dependent: :destroy, as: :completeable` line.",
       "reference": "Where does the `7` come from?"
     },
     {
@@ -30259,11 +30259,11 @@
       "reference": "I don't know how we haven't got bugs from some of these! As here this would have had a stale `value`"
     },
     {
-      "prediction": "I'm not sure what you mean by \"reserved table property\". Could you please provide more context?",
+      "prediction": "I don't think this is a good idea.",
       "reference": "One nit here I forgot about this before but we usually structure error messages as \"Cannot X because Y. Then the recommendation goes here\" I would also recommend not using \"it\" in the message since it the pronoun is a bit ambiguous. \"to specify write sort-order\" may be clearer"
     },
     {
-      "prediction": "I don't think we need to import `initialState` here. It's already defined in `initialState` in `feature-tours.js`.",
+      "prediction": "I don't think this is necessary. `initialState` is already defined in `feature-tours.js`, so we don't need to import it again.",
       "reference": "I'm surprised this worked at all! It was importing the default export but `eslint-plugin-import` warned me `warning Using exported name 'initialState' as identifier for default export import/no-named-as-default`"
     },
     {
@@ -30271,31 +30271,31 @@
       "reference": "This was used in `app/views/video_tutorials/_video_tutorial_details.html.erb` how are we handling that now?"
     },
     {
-      "prediction": "I'm not sure why we're using `regexp` here. We could just use `regexp.MustCompile` instead.",
+      "prediction": "I think we can remove the `regexp.MustCompile` calls here.",
       "reference": "Is `\\S+` really the right thing? Anybody know what kind of encoding this is? Perhaps if we know it doesn't have commas, we can just use `[^,]+`. Also, parens around the comma are unnecessary, since we're not using the capture group."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don",
+      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. Is it that you want to run all the tests in the `unittest` module? Or is it that you want to run all the tests in the `unittest` module and its submodules? Or is it that you want to run all the tests in the `unittest` module and its submodules and its submodules and its submodules? Or is it that you want to run all the tests in the `unittest` module and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its submodules and its",
       "reference": "This block of changes looks like you removed tests without replacing them anywhere. Did I miss something?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"n.b. some properties cannot be converted to python types.\"",
+      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to do something like `GetPropsAsDict(self, includePrivate=True, includeComputed=True)`, but I don't think that's what you want to do.",
       "reference": "n.b. private and computed values are now exposed to the API. They were hidden/not exposed before."
     },
     {
-      "prediction": "I think this should be `if self.parent().tagName().lower() == 'a'` instead of `if self._elem.tagName().lower() == 'a'`.",
+      "prediction": "I think this should be `if self._elem.tagName().lower() == 'a'` instead of `if self.parent().tagName().lower() == 'a'`.",
       "reference": "Nitpick: Please add a period after `link` :wink:"
     },
     {
-      "prediction": "I think it's better to use `klog.Warningf` instead of `klog.Errorf` in this case.",
+      "prediction": "I think it's better to use `klog.Errorf` instead of `klog.Warning` in this case.",
       "reference": "we got no chance that `err` is not nil here, need to revisit how `NewUpstreamController` is defined."
     },
     {
-      "prediction": "I'm not sure if this is the right place to put it, but I think it should be in the `HttpCommandExecutor` class, not in the `CommandExecutor` class. The `HttpCommandExecutor` class is the base class for all command executors, so it should have access to the `nameToUrl` object.",
+      "prediction": "I'm not sure if this is the right place to put it, but I think it should be in the `HttpCommandExecutor` class.",
       "reference": "Instead of building in routing for a browser-specific command, could you refactor the HttpCommandExecutor to allow arbitrary commands to be registered?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `__FILE__` and `__LINE__` for this kind of thing. It's not a good idea to use `__FILE__` and `__LINE__` for this kind of thing. It's not a good idea to use `__FILE__` and `__LINE__` for this kind of thing. It's not a good idea to use `__FILE__` and `__LINE__` for this kind of thing. It's not a good idea to use `__FILE__` and `__LINE__` for this kind of thing. It's not a good idea to use `__FILE__` and `__LINE__` for this kind of thing. It's not a good idea to use `__FILE__` and `__LINE__` for this kind of thing. It's not a good idea to use `__FILE__` and `__LINE__` for this kind of thing. It's not a good idea to use `__FILE__` and `__LINE__` for this kind of thing. It's not a good idea to use `__FILE__` and `",
+      "prediction": "I'm not sure what you're trying to do here. It seems like you're trying to deprecate the `its` method, but I don't think that's what you're trying to do here.",
       "reference": "It'd be nice to assert the right deprecation is being raised, just add a third argument of `/\"its\" method/`"
     },
     {
@@ -30307,15 +30307,15 @@
       "reference": "This isn't really related but makes debugging test failures much easier since you see the string representation of the code instead of the integer value."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `UpdateValue` method.",
       "reference": "Because of this new early exit."
     },
     {
-      "prediction": "I think this should be `Selenium::WebDriver::Remote::W3CBridge` instead of `Selenium::WebDriver::Firefox::W3CBridge`.",
+      "prediction": "I think it's better to use `Selenium::WebDriver::Remote::W3CBridge` instead of `Selenium::WebDriver::Firefox::W3CBridge` and `Selenium::WebDriver::Edge::W3CBridge` because `Selenium::WebDriver::Firefox::W3CBridge` and `Selenium::WebDriver::Edge::W3CBridge` are deprecated.",
       "reference": "Maybe call it `WireBridge`?"
     },
     {
-      "prediction": "I think this should be `if (rpcMethod.getName().equals(RpcMethod.PRIV_DISTRIBUTE_RAW_TRANSACTION.getMethodName()))`",
+      "prediction": "I think it's better to use `if (rpcMethod.getName().equals(RpcMethod.ETH_SEND_RAW_PRIVATE_TRANSACTION.getMethodName())) {` instead of `if (rpcMethod.getName().equals(RpcMethod.PRIV_DISTRIBUTE_RAW_TRANSACTION.getMethodName())) {`",
       "reference": "can this be removed now?"
     },
     {
@@ -30323,7 +30323,7 @@
       "reference": "This is going to create a problem - we are already encountering issues with the length of the usock pathname on recent Linux kernels as the temp directory base has moved down to the var directory under a name created by a hash. So adding another field to it is going to add to the problem."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to keep the `AppCfnTemplateNameFormat` and `AppCfnTemplateConfigurationNameFormat` in sync with the `AppCfnTemplateName` and `AppCfnTemplateConfigurationName`.",
+      "prediction": "I think it's better to use `AppCfnTemplateNameFormat` and `AppCfnTemplateConfigurationNameFormat` instead of `AppCfnTemplateName` and `AppCfnTemplateConfigurationName`.",
       "reference": "What do you think about moving this to the `cloudformation` pkg?"
     },
     {
@@ -30331,15 +30331,15 @@
       "reference": "Please make this private by default"
     },
     {
-      "prediction": "I don't think this is needed anymore.",
+      "prediction": "I don't think this is needed anymore. The `ProcessEngineConfigurationImpl` has been replaced by `ProcessEngineConfiguration` and `ProcessEngineLogger` has been replaced by `ProcessEngineLoggerImpl`.",
       "reference": "We can add `@Override` annotations to all of the implementations of this method. I think this is a best practice for us, but it would be nicer in any case."
     },
     {
-      "prediction": "I think we can remove `DetectCountry` and `DetectLocation` from `Detector` interface.",
+      "prediction": "I think it's better to have `DetectCountry` and `DetectLocation` in the same package.",
       "reference": "Most of uses of `RefreshAndGet` seems to be made only for `Refresh` part, result is ignored. We can simplify this method to assigning single responsibility to it - just `Refresh()`."
     },
     {
-      "prediction": "I think this should be `self._maxlevel = max(self._maxlevel, option.level or 0)` instead of `self._maxlevel = max(self._maxlevel, option.level or 0)`",
+      "prediction": "I think it's a good idea to make this a class method instead of an instance method.",
       "reference": "@Pierre-Sassoulas Are we sure this doesn't create problems? Without it for some reason we get an error on `accept-no-param-docs` being a duplicate error. I couldn't figure out why it did this. This solves the issue and passes the tests, but I wonder if this creates other issues.."
     },
     {
@@ -30347,63 +30347,63 @@
       "reference": "Does it make sense to check for \"Created\" here as well? Or should it return an error in such case?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way",
+      "prediction": "I'm not sure I understand what you're trying to do here. You're creating a new `TableMetadata` object and passing it to the `Transactions.createTableTransaction` method, but then you're not using it anywhere else. Is this what you're trying to do? If so, why are you creating a new `TableMetadata` object and passing it to the `Transactions.createTableTransaction` method? Is this what you're trying to do? If so, why are you creating a new `TableMetadata` object and passing it to the `Transactions.createTableTransaction` method? Is this what you're trying to do? If so, why are you creating a new `TableMetadata` object and passing it to the `Transactions.createTableTransaction` method? If so, why are you creating a new `TableMetadata` object and passing it to the `Transactions.createTableTransaction` method? If so, why are you creating a new `TableMetadata` object and passing it to the `Transactions.createTableTransaction` method? If so, why are you creating a new `TableMetadata` object and passing it to the `Transactions.createTableTransaction` method? If so, why are you creating a new `TableMetadata` object and passing it to the `",
       "reference": "Did you mean to use `identifier.toString` here as well?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
+      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.",
       "reference": "interesting! didn't realize this was needed in RSpec 3"
     },
     {
-      "prediction": "I think this should be `self.spark_type` instead of `series.spark_type`",
+      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.",
       "reference": "This is to avoid circular reference"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason why you want to use `JupyterComm` instead of `NbAggJupyterComm`? I'm not sure I understand what you're trying to do here. Is there a specific reason why you want to use `JupyterComm` instead of `NbAggJupyterComm`? I'm not sure I understand what you're trying to do here. Is there a specific reason why you want to use `JupyterComm` instead of `NbAggJupyterComm`? I'm not sure I understand what you're trying to do here. Is there a specific reason why you want to use `JupyterComm` instead of `NbAggJupyterComm`? I'm not sure I understand what you're trying to do here. Is there a specific reason why you want to use `JupyterComm` instead of `NbAggJupyterComm`? I'm not sure I understand what you're trying to do here. Is there a specific reason why you want to use `JupyterComm` instead of `NbAggJupyterComm`? I'm not sure I understand what you're trying to do here. Is there",
+      "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason why you want to use `JupyterComm` here?",
       "reference": "As the bokeh renderer also has a ``load_nb`` classmethod (and notebooks are explicitly mentioned in that method name), I would consider making ``_notebook`` into a constant ``notebook_context`` class parameter. The docstring can say it is set to True if the ``load_nb`` classmethod has been called."
     },
     {
-      "prediction": "I don't think this is needed.",
+      "prediction": "I don't think this is necessary. We can just use the `dropCollection` method of the `Collection` interface.",
       "reference": "Where is the actual command generated here? Shouldn't this be taking in `constructor(db, collectionName, options)` and then constructing the command off of that?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get the size of the library path. I think you want to get the size of the filename, right?",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think this is the right place to do it.",
       "reference": "Mirror the `OPTIONAL OUT` of fullpath"
     },
     {
-      "prediction": "I'm not sure what you mean by \"please update ConsensusCurrentVersion when adding new protocol versions\". It's not like we're going to change ConsensusV17 to ConsensusVNext, right?",
+      "prediction": "I'm not sure if this is the right place to update ConsensusCurrentVersion. I think it's better to update ConsensusV17 and ConsensusVNext.",
       "reference": "Please merge with master and replace with with \"future\" version."
     },
     {
-      "prediction": "I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `render` method of the `VNode` class.",
       "reference": "Nit: Change is not needed for this PR :slightly_smiling_face:"
     },
     {
-      "prediction": "I think this should be `self.raw_vcap_data['application_uris'].min_by(&:length)` instead of `self.vcap_data['application_uris'].min_by(&:length)`.",
+      "prediction": "I think this should be `self.vcap_data['application_uris'].min_by(&:length)` instead of `self.vcap_data['application_uris'].min_by(&:length)`.",
       "reference": "if we are returning `nil` from an `else` I think we can just remove the `else` (and this method will still return `nil`)"
     },
     {
-      "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to have the `Task[]` be the same size as the `Timer[]` so that we don't have to create a new `Task[]` every time we want to add a new `Timer` to the `timers` array.",
+      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.",
       "reference": "side note: this change is ok as of today because we have not exported the results for this new type to BenchView yet. After we to that the namespace, type name and method name should not be changed (they create a benchmark ID which is used in BenchView)."
     },
     {
-      "prediction": "I think this should be `if (!info.Exists)` instead of `if (!info.Exists || info.Length == 0)`",
+      "prediction": "I think this should be `if (!info.Exists || info.Length == 0)` instead of `if (!info.Exists && info.Length == 0)`.",
       "reference": "How exactly are you expecting the user to see issues with their Midas library? It seems like all error information is being swallowed and not clearly reported to the user. Even if the eventual result is to report that loading the file failed, it seems like the exception, in this case, might have more information about why."
     },
     {
-      "prediction": "I think it's better to use `wsc.connection.SetReadDeadline` instead of `wsc.connection.SetWriteDeadline`.",
+      "prediction": "I'm not sure what you mean by \"as JSON object through the connection\". I think you meant to say \"as JSON string through the connection\" or something like that.",
       "reference": "Looks good, but seems `ReadMessage` hadn't used this Deadline in Underlying `WSConnection`?"
     },
     {
-      "prediction": "I don't think this is needed.",
+      "prediction": "I think this should be `AZKABAN_PROJECT_DIR_SIZE_FILE_NAME` instead of `_azkaban_project_dir_size_in_bytes_`",
       "reference": "Make it \"___*\" three underscores to make it even less likely to have a collision? I assume it will be hard to change the file name once this change is deployed..."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a good idea to remove the `final` keyword here.",
+      "prediction": "I'm not sure what you're trying to achieve with this, but I think it would be better to use a `try`/`catch`/`finally` block instead of the `waitBetweenRecoveries` method.",
       "reference": "We don't need this anymore after #2151"
     },
     {
-      "prediction": "I think this should be `private` instead of `internal`.",
+      "prediction": "I think this should be `public class MachineNameLayoutRenderer : LayoutRenderer` instead of `public class MachineNameLayoutRenderer : LayoutRenderer, IStringValueRenderer`.",
       "reference": "this is this removed? I don't understand in the context of this PR"
     },
     {
@@ -30411,51 +30411,51 @@
       "reference": "`isinstance(ip6, Net6)` instead"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `multiGet` function.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.",
       "reference": "Do we really need the param here? If only partial results returned, we could return ResultCode::PARTIAL_RESULTS;"
     },
     {
-      "prediction": "I think we can remove the `if output == target.Label.PackageName` check.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to move this to a separate function.",
       "reference": "this logic seems duplicated from the other new function. I think it should probably be a member function on `BuildTarget`"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `bytes.Compare` here. It's not a good idea to use `bytes.Compare` here.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `bytes.Compare` here. I think you should use `bytes.Equal` instead.",
       "reference": "size reduce to 1/4 of using Gob"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a good idea to add a `hash` field to the `Writer` struct, so that we can use it in the `Write` method of the `Writer` struct as well.",
+      "prediction": "I'm not sure what you're trying to achieve with this, but I think it would be better to just use `io.MultiWriter` instead of `io.MultiWriter(w, h)`. This is because `io.MultiWriter(w, h)` creates a new `io.Writer` for each `io.Writer` that is passed to it, which can lead to memory leaks if you're not careful.",
       "reference": "The Hash interface states that a call to `Write()` never returns an error. Does this also apply to the number of written bytes?"
     },
     {
-      "prediction": "I think this should be `if $(sw_vers -productVersion 2>/dev/null | cut -d . -f 2) -lt 12` instead of `if $(sw_vers -productVersion | cut -d . -f 2) -lt 12`",
+      "prediction": "I think this should be `if $(sw_vers -productVersion 2>/dev/null | cut -d . -f 2) -lt 12` instead of `if $(sw_vers -productVersion | cut -d . -f 2) -lt 12`.",
       "reference": "In my tests, I found that `[[ \"\" -lt 12 ]]` evaluates to true, but `[[ -lt 12 ]]` is an error, which is why the subshell is wrapped in `\"`."
     },
     {
-      "prediction": "I'm not sure what you mean by \"unpublished\" in this case. I think you meant to say \"published_on nil\" instead of \"published_on nil\"",
+      "prediction": "I don't think this is necessary. The `published_on` is already set to `Time.zone.today`.",
       "reference": "I don't see a validation on `published_on`, we generally shouldn't specify it in the base factory unless the model would be invalid without the model. Is there a different way we can handle this?"
     },
     {
-      "prediction": "I don't think this is necessary.",
+      "prediction": "I don't think we need to change this.",
       "reference": "maybe add a `isExhaustive()` method on the enum to avoid these large conditions?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. It looks like you're trying to use the `docker.sock` and `docker.sock.unix` to connect to the Docker daemon, but I'm not sure if that's what you're trying to do or not.",
+      "prediction": "I'm not sure if this is the right place to put it, but I think it should be in the `docker` package.",
       "reference": "so those regexps were wrong previously? e.g. they would match `/v\\/foo`? If so, raise a bug and fix on the 1.0 branch."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bad idea to pass the `source` parameter to the `MultiBackend` constructor.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check here to make sure the source is not null.",
       "reference": "I think with MultiBackend we could have a slightly different logic: return true if there are no configured login targets ( = getLoginDrivers returns an empty array). MultiBackend could also check all configured login targets for loginIsHidden support and verify that at least one of the configured login targets allows login, but I wouldn't go that far without a use case. In a related note, I'm not quite sure if loginIsHidden works with ChoiceAuth at all, but that's a different issue."
     },
     {
-      "prediction": "I'm not sure what you mean by \"generic version for ASCII files that may be compressed\". I think you meant \"generic version for ASCII files that may be compressed or native binary dumps\".",
+      "prediction": "I'm not sure what you mean by \"native binary dumps\". I think you meant \"compressed\" or \"binary\".",
       "reference": "Should we add error info for not supporting the compressed binary?"
     },
     {
-      "prediction": "I'm not sure what you mean by `defaultBackoffPolicy = eventingduckv1beta1.BackoffPolicyExponential`. Is this the same as `defaultBackoffPolicy = eventingv1beta1.BackoffPolicyExponential`?",
+      "prediction": "I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place to put it. I'm not sure if this is a good place to put it, but I think it's a good place",
       "reference": "I suggest injecting this into the reconciler. For this and the others. Have Wire generate it and push it into the controller creation."
     },
     {
-      "prediction": "I don't think this is needed. The `EthereumJsonSerializer` is just a wrapper for the `JsonSerializer`, so we don't need to create a new `JsonConverter` for it.",
+      "prediction": "I don't think this is needed. The `EthereumJsonSerializer` is just a wrapper for `JsonSerializer`, so it doesn't need to have a `BasicConverters` property.",
       "reference": "Can't we just make _serializer static? We use same settings every time. I would also put those fields on top of the class for readability."
     },
     {
@@ -30463,51 +30463,51 @@
       "reference": "Can't we just use `metadata['websocket_flow']` to identify handshake flows and not add another attribute?"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a good idea to remove the `#` from the `separator` string.",
+      "prediction": "I think this should be `#{'-' * 80}'` instead of `#{'-' * 80}`.",
       "reference": "Funny that we were wrapping this with string interpolation before..."
     },
     {
-      "prediction": "I think we can remove the `alias` and just use the `guid` directly.",
+      "prediction": "I think this should be `alias('guid')` instead of `alias('model')`.",
       "reference": "I had an eslint error saying I must \"alias\" my model - so I copied this from controllers/site.js"
     },
     {
-      "prediction": "I think this should be `GetMetricPointsAccessor` instead of `GetMetricPoints`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `MetricPointsAccessor` class.",
       "reference": "unsure if the methodname can still be `GetMetricPoints()` as before..."
     },
     {
-      "prediction": "I'm not sure what you mean by \"rule_name\"",
+      "prediction": "I'm not sure what you mean by `rule_name`",
       "reference": "This file contains the functional changes, the rest is for testing."
     },
     {
-      "prediction": "I don't think we need to use `net/http` at all. We can just use `net/http/httputil` and `net/http/httputil.Discarder` instead.",
+      "prediction": "I don't think this is necessary. We can just use `net/http.ServeFile` instead of `net/http.FileServer`.",
       "reference": "I know you didn't do this, but there's no need for the `nethttp` alias and it was confusing to me - just remove it and s/nethttp/http/ everywhere (it's fine that the package here is http itself, I do the same thing in transport/grpc)"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I'm not sure if this is the right place to do this.",
+      "prediction": "I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure",
       "reference": "I felt that this was the most non-invasive way to fix the test, but this does expose some raw DB queries and knowledge about how SQLite works which may be a code smell. The alternative to getting this to pass is to perform enough writes to trigger a checkpoint, but that threshold is determined in the config stage and this test may not be able to know what that page threshold is set to. This could lead to inconsistent test runs which is why I elected to force the checkpoint regardless of the page threshold."
     },
     {
-      "prediction": "I don't think this is a good idea. The model version should be set in the constructor, not in the DumpModel method.",
+      "prediction": "I don't think we need to use `const std::string` here. We can just use `std::string` here.",
       "reference": "Is new model format backward compatible with current v2?"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `deliveries.clear` here. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `deliveries.clear` here. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `deliveries.clear` here. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `deliveries.clear` here. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `deliveries.clear` here. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `deliveries.clear` here. It's not clear what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `deliveries.clear` here. It's not clear what you're trying to achieve with this test, but I'm not",
+      "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to have a separate test for this. I think it would be better to have a single test that covers both cases.",
       "reference": "should we perhaps write a spec that ensures we don't send a welcome email to a user on login when the user is not new?"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a `DockerStopTimeoutSeconds` field to the `Config` struct. It's not clear to me if this is a good idea, but I think it's a good idea to add a `DockerStopTimeoutSeconds` field to the `Config` struct. It's not clear to me if this is a good idea, but I think it's a good idea to add a `DockerStopTimeoutSeconds` field to the `Config` struct. It's not clear to me if this is a good idea, but I think it's a good idea to add a `DockerStopTimeoutSeconds` field to the `Config` struct. It's not clear to me if this is a good idea, but I think it's a good idea to add a `DockerStopTimeoutSeconds` field to the `Config` struct. It's not clear to me if this is a good idea, but I think it's a good idea to add a `DockerStopTimeoutSeconds` field to the `Config` struct. It's not clear to me if this is a good idea, but I think it's a good idea to add a",
+      "prediction": "I'm not sure if this is a good idea, but I think we should add a `DockerStopTimeoutSeconds` field to the `Config` struct.",
       "reference": "I think my preference would be to have the type be a `time.Duration` and use `time.ParseDuration` for parsing."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea to add a `@ThreadSafe` annotation to a class that is not intended to be used in a thread-safe manner.",
+      "prediction": "I don't think this is necessary. The `ManagedObject` class is not used anywhere in the code. It's just there for the sake of completeness.",
       "reference": "JMX offers normal APIs for this. I don't think you want the glassfish one."
     },
     {
-      "prediction": "I'm not sure what you're trying to say here. I think you're trying to say that the `yamllint` option should be `yamllint` and not `yamllint`, but I'm not sure what you're trying to say here. I think you're trying to say that the `yamllint` option should be `yamllint` and not `yamllint`, but I'm not sure what you're trying to say here. I think you're trying to say that the `yamllint` option should be `yamllint` and not `yamllint`, but I'm not sure what you're trying to say here. I think you're trying to say that the `yamllint` option should be `yamllint` and not `yamllint`, but I'm not sure what you're trying to say here. I think you're trying to say that the `yamllint` option should be `yamllint` and not `yamllint`, but I'm not sure what you're trying to say here. I think you're trying to say that the `yamllint` option should be `",
+      "prediction": "I'm not sure what you mean by \"goss\". Is this a typo?",
       "reference": "We should really leave a TODO or something or else we will forget them ..."
     },
     {
-      "prediction": "I think we should remove the `RuntimeType` from the `inputs` list.",
+      "prediction": "I think we can remove the `RuntimeType` and just use `dagster_type` here.",
       "reference": "This exposes what a bad name `dagster_type` was, but is it crazy to want this to just be `type` -- do we gain usability by being super-explicit that this is a `runtime_type`? If so, would it make sense to rename the `config_field` to be `config_type`?"
     },
     {
@@ -30515,15 +30515,15 @@
       "reference": "It might help here if you give a brief explanation of what you mean with a selection being anchored at the start."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this code, but it looks like you're trying to create a function that takes an address and returns a hash of the address. However, the current implementation doesn't seem to be working as expected. Could you please provide more information on what you're trying to achieve with this code?",
+      "prediction": "I don't think we need to use `big` here. We can just use `int64` and `uint64` instead.",
       "reference": "move cachedStates to handle function"
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here.",
+      "prediction": "I don't think this is necessary.",
       "reference": "I don't think this can just be renamed; it's saying that privacyMode is a BooleanSetting, which it's not."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `Thread.currentThread().getName()` instead of `Thread.currentThread().getId()`. This is because `Thread.currentThread().getId()` is not thread-safe.",
+      "prediction": "I think this should be `coreConcurrencyStages.add(Thread.currentThread().getId() + \".\" + stage.name());` instead of `coreConcurrencyStages.add(Thread.currentThread().getName() + \".\" + stage.name());`",
       "reference": "what was the reason for this change?"
     },
     {
@@ -30531,11 +30531,11 @@
       "reference": "Minor, but these two nullable and the logic around them could be replaced by a Lazy."
     },
     {
-      "prediction": "I'm not sure what you mean by `api \"k8s.io/apimachinery/pkg/apis/meta/v1\"`. Is this the same as `api \"k8s.io/client-go/kubernetes\"`?",
+      "prediction": "I'm not sure why we need to use `api` here. We can just use `k8s.io/client-go/kubernetes` and `k8s.io/client-go/rest` instead.",
       "reference": "I think I would just pass in `len(peers)`, on the principle of minimum information."
     },
     {
-      "prediction": "I think this should be `PARQUET_IN_LIMIT_DEFAULT` instead of `PARQUET_IN_LIMIT`.",
+      "prediction": "I don't think we need to change the default value of `PARQUET_IN_LIMIT` to `200` because it's already set to `200` by default.",
       "reference": "Spark's default value is 10 but it also rewrites IN as OR/EQUALS. We can do better that this because of the way we evaluate IN predicates. On datasets we tested this, we saw performance improvements on IN predicates with up to 200 elements (on sorted column). We may increase the default value a bit but I am very reluctant to make it more than 300 since our jobs were 20% slower with IN predicates that contained 300 elements. That being said, the optimal value still depends on a particular query and table."
     },
     {
@@ -30543,91 +30543,91 @@
       "reference": "Please update copyright year."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. Is it that you want to know the number of nodes and edges per second? If so, I'm not sure I understand what you're trying to do here. Is it that you want to know the number of nodes and edges per second? If so, I'm not sure I understand what you're trying to do here. Is it that you want to know the number of nodes and edges per second? If so, I'm not sure I understand what you're trying to do here. Is it that you want to know the number of nodes and edges per second? If so, I'm not sure I understand what you're trying to do here. Is it that you want to know the number of nodes and edges per second? If so, I'm not sure I understand what you're trying to do here. Is it that you want to know the number of nodes and edges per second? If so, I'm not sure I understand what you're trying to do here. Is it that you want to know the number of nodes and edges per second? If so, I'm not sure I understand what you're trying to do here. Is it that you want to know the number of nodes",
+      "prediction": "I think we can remove the `std::uint64_t` from `nodes_per_second` and `edges_per_second` and just use `std::uint32_t` instead of `std::uint64_t`. This is because `std::uint64_t` is a 64-bit integer, while `std::uint32_t` is a 32-bit integer.",
       "reference": "Same here, could just be `std::setprecision`."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason you want to change the format of the notifications? If so, how do you plan to do that?",
+      "prediction": "I'm not sure I understand what you're trying to do here. Is there a reason you want to change the format of the notifications?",
       "reference": "Do we still want the \"admins\" gate?"
     },
     {
-      "prediction": "I'm not sure what you're trying to accomplish with this snippet. It's not clear what the purpose of this snippet is.",
+      "prediction": "I'm not sure what you mean by \"bucket in Amazon Simple Storage Solution (Amazon S3)\". Is this the same as \"bucket in Amazon Simple Storage Service (Amazon S3)\"?",
       "reference": "Simple Storage **Service**"
     },
     {
-      "prediction": "I think this should be `DisableAutoObservabilityMiddleware` instead of `DisableAutoObservabilityMiddleware bool`",
+      "prediction": "I think this should be `DisableAutoObservabilityMiddleware: bool` instead of `DisableAutoObservabilityMiddleware: bool`",
       "reference": "nit: `it is assumed`"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea to include `http2_internal.h` in a header file. It's not a good idea to include headers that are not part of the public API, and it's not a good idea to include headers that are not part of the public API.",
+      "prediction": "I'm not sure what you mean by this, but I think it's a good idea to remove the `#include \"h2o/http2_internal.h\"`.",
       "reference": "I would appreciate it if you could refrain from using `stdbool.h`. We allow the header files of H2O to be included from C++ (which means that `bool` might be a C++ type), and therefore my preference is to not use `bool` in our code (but instead use `int` or `char` for the purpose) to avoid confusion."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to the `Backend\\Widgets\\Lists` widget.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `manage[searchScope]` option in the widget config.",
       "reference": "@danielbidala What happens if `searchScope` is not defined in `config_relation.yaml` ?"
     },
     {
-      "prediction": "I think this should be `go` instead of `context.Background()`.",
+      "prediction": "I think this should be a `sync.WaitGroup` instead of a `sync.Mutex` here.",
       "reference": "Do we want maybe a 1min timeout?"
     },
     {
-      "prediction": "I don't think this is a good idea. We should be able to use `strings.SplitN` instead of `strings.Split` in this case.",
+      "prediction": "I don't think this is necessary.",
       "reference": "I guess code never reaches this line, you can remove `else` block and just `return a[0], a[1]`. Also, probably rename `a` to `auth` as well."
     },
     {
-      "prediction": "I think we can remove the `new` keyword from the constructor.",
+      "prediction": "I think we can remove the `new` keyword here, as it's not used anywhere else in the code.",
       "reference": "Doesn't this no-arg constructor need to be public for serialization to work?"
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here. If you want to check if a field is already attached, you can use the `isAttached()` method. If you want to check if a field is attached to a specific date, you can use the `isAttachedToDate()` method. If you want to check if a field is attached to a specific date range, you can use the `isAttachedToDateRange()` method.",
+      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.",
       "reference": "Just use the word \"veld\" instead of \"gebied\" here"
     },
     {
-      "prediction": "I'm not sure if this is the right place to put it, but I think it's a good idea to move it to the `org.apache.commons.io.FileUtils` package.",
+      "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to move it to `org.shredzone.flattr4j.model.User` so that it can be used in other places.",
       "reference": "This change (import org.shredzone.flatter4j.model.User;) does not seem relevant to this fix / commit."
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think it's a good idea to have a separate flag for `hydrated-build` so that it can be used in the same way as `build-agent`.",
+      "prediction": "I'm not sure if this is the right place to add this flag, but I think it's a good idea to add it to the list of available flags.",
       "reference": "This should be a Bool() rather than a String(). (See the other PR for an example)"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this test. It seems like you want to make sure that a bucket's rule can guarantee the maximum_retention if its action is 'Delete' and the only condition is an age(<= maximum_retention).",
+      "prediction": "I'm not sure what you mean by \"only condition is an age(<= maximum_retention)\". I think you meant to say \"only condition is an age(>= maximum_retention)\".",
       "reference": "This should be a failure if we don't get the exact number of expected rules. You can use a constant if you don't want to update several lines any time you update the test rule strings."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
+      "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.",
       "reference": "We need to switch from BeamSync to FullSync when we download all the needed headers, blocks, receipts and state"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that `g_value_dup_object` is called before `g_value_set_object`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in `thrift_protocol_set_property` as well.",
       "reference": "Why you duplicate it? The underlaying transport should live as long as the multiplexed one. And must be destroyed after protocol is destroyed. Duplicating the transport may lead to object references hold and maybe memory freeing problems. I think this property must hold a reference to it and not a copy. The copy can lead to memory freeing problems."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change. It seems like you're trying to change the `Status` field from `Experiment.Phase` to `ChaosStatus.Experiment.Phase`, but I'm not sure if that's what you're trying to achieve.",
+      "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `string` for the `Status` field.",
       "reference": "`in.Status.Experiment.Phase`. we can omit `ChaosStatus`"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think we need to change anything here.",
+      "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `exec.Command` here. I'm not sure if it's a good idea to use `exec.Command` here. I'm not sure if it's a good idea to use `exec.Command` here. I'm not sure if it's a good idea to use `exec.Command` here. I'm not sure if it's a good idea to use `exec.Command` here. I'm not sure if it's a good idea to use `exec.Command` here. I'm not sure if it's a good idea to use `exec.Command` here. I'm not sure if it's a good idea to use `exec.Command` here. I'm not sure if it's a good idea to use `exec.Command` here. I'm not sure if it's a good idea to use `exec.Command` here. I'm not sure if it's a good idea to use `exec.Command` here. I'm not sure if it's a good idea to use `exec.Command` here. I'm not sure if it's a good idea to use `exec.Command` here. I'm not sure if it's a good idea",
       "reference": "Just curious... why the alias here?"
     },
     {
-      "prediction": "I don't think you need to use `System.ComponentModel.ComponentResourceManager` here.",
+      "prediction": "I don't think you need to use `System.Windows.Forms.Button` here. You can use `System.Windows.Forms.ButtonBase` instead.",
       "reference": "Seems like this should conflict with changes I made during merging of the 20.2 RESX file translation"
     },
     {
-      "prediction": "I'm not sure what you mean by \"enable_opt_collapse_project_rule\"",
+      "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to have a separate file for this so that we don't have to include it in every file that uses it.",
       "reference": "Why disable this rule?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `replace` method to replace `{}` with `self._filename` in the `args` list.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `replace` method to replace `{}` with `self._filename` in the `args` list. This way, we don't have to worry about escaping `{` and `}` in the `args` list.",
       "reference": "I think you don't need the `... if '{}' in arg else arg` part - if the arg doesn't contain `{}`, `arg.replace('{}', ...)` will return the unchanged string anyways."
     },
     {
-      "prediction": "I think we can remove the `GROUP_CHUNK_SIZE` from the `LoadGroupMembersPipeline` class.",
+      "prediction": "I'm not sure if this is a good place to put this, but I think it would be a good idea to move this to a separate file.",
       "reference": "nit: Should we make this an attribute of the LoadGroupMembersPIpeline class?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to put it in the `JDBCConnection` class.",
       "reference": "need to update this command to use the name field instead of principal_id"
     },
     {
@@ -30635,7 +30635,7 @@
       "reference": "nit: I can't help but think the privateTransactionHandler should be a base-class member ... every Priv Json RPC seems to need it..."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to set the activity flags in the `onPreferenceChange` method.",
+      "prediction": "I don't think this is necessary.",
       "reference": "Why does this start the main activity and not the preferences? With `overridePendingTransition(0, 0)`, this could instantly switch the theme without the user being disrupted"
     },
     {
@@ -30643,11 +30643,11 @@
       "reference": "Prefer a human-readable string rather than querying specific technologies. How would I indicate a session is running on BrowserStack? Or some custom thing?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
+      "prediction": "I'm not sure if this is a good idea, but I think it would be a good idea to have a separate `setup.py` file for this package. It would be a good idea to have a separate `setup.py` file for this package. It would be a good idea to have a separate `setup.py` file for this package. It would be a good idea to have a separate `setup.py` file for this package. It would be a good idea to have a separate `setup.py` file for this package. It would be a good idea to have a separate `setup.py` file for this package. It would be a good idea to have a separate `setup.py` file for this package. It would be a good idea to have a separate `setup.py` file for this package. It would be a good idea to have a separate `setup.py` file for this package. It would be a good idea to have a separate `setup.py` file for this package. It would be a good idea to have a separate `setup.py` file for this package. It would be a good idea to have a separate `setup.py` file for this package. It would be a good idea to have a separate `setup.py`",
       "reference": "It appears as though whoever checked in python changes didn't re-run regenerate:expected. I am modifying these files as a result of running that after a sync and build."
     },
     {
-      "prediction": "I think this should be `hasAnyResourceNameParameter` instead of `hasAnyResourceNameParameter(FlatteningConfig flatteningGroup)`.",
+      "prediction": "I think this should be `hasAnyResourceNameParameter` instead of `hasAnyResourceNameParameter(FlatteningConfig flatteningGroup)`",
       "reference": "This was copied from JavaMethodViewGenerator; only the `public static` method modifiers were added."
     },
     {
@@ -30655,7 +30655,7 @@
       "reference": "this is going to throw for frontier transactions post-london"
     },
     {
-      "prediction": "I'm not sure what you mean by \"release cache generation lock\". I think you meant to say \"release cache generation lock\" or \"release cache generation lock\".",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do it here. I'm not sure if it's the right place to do this, but I think it's a good idea to do it here. I'm not sure if it's the right place to do this, but I think it's a good idea to do it here. I'm not sure if it's the right place to do this, but I think it's a good idea to do it here. I'm not sure if it's the right place to do this, but I think it's a good idea to do it here. I'm not sure if it's the right place to do this, but I think it's a good idea to do it here. I'm not sure if it's the right place to do this, but I think it's a good idea to do it here. I'm not sure if it's the right place to do this, but I think it's a good idea to do it here. I'm not sure if it's the right place to do this, but I think it's a good idea to do it here. I'm not sure if it's the right place to do this",
       "reference": "The catch clause is not needed. The finally clause alone is enough."
     },
     {
@@ -30663,7 +30663,7 @@
       "reference": "Prefer a human-readable string rather than querying specific technologies. How would I indicate a session is running on BrowserStack? Or some custom thing?"
     },
     {
-      "prediction": "I think this should be `isClosed` instead of `isClosed = TRUE`.",
+      "prediction": "I think this should be `isClosed = FALSE;` instead of `isClosed = TRUE;`",
       "reference": "Changing the default value for isClosed from TRUE to FALSE can have other repercussions. We might miss throwing error. Can you please confirm this change."
     },
     {
@@ -30671,19 +30671,19 @@
       "reference": "Please use more meaningful names than `te`here and in other places."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. It seems like you're trying to create a new plugin, but you don't have a catalog yet. Is this what you're trying to do? If so, how are you going to create the catalog?",
+      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it would be better to use the new `Catalog` interface. It's more consistent with the rest of the codebase, and it also makes it easier to add new plugins without having to change the `Catalog` interface.",
       "reference": "Perhaps this would be more idiomatic as `ConfigFor(interface{}) (*PluginConfig, bool)`?"
     },
     {
-      "prediction": "I think we should use `AWS_JSON_CONTENT_TYPE` instead of `application/x-amz-json-1.1`",
+      "prediction": "I think this should be `if 'nextToken' in to_str(data or ''):`",
       "reference": "nit: We could import `APPLICATION_AMZ_JSON_1_1` from `constants.py` here."
     },
     {
-      "prediction": "Should this be `Task` instead of `async Task`?",
+      "prediction": "I think this should be `async Task ExecuteOnMainThreadAsync(Action action, bool maskExceptions = true);`",
       "reference": "Should this not inherit from IMvxMainThreadDispatcher?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.",
+      "prediction": "I'm not sure what you're trying to do here, but I think we should remove the `roundCtx` parameter from the `UpdateRound` function.",
       "reference": "line is 167 characters (from `lll`)"
     },
     {
@@ -30691,27 +30691,27 @@
       "reference": "nit: consider adding a blank line between L15 and L16."
     },
     {
-      "prediction": "I think this should be `const auto number_of_overrides = maneuver_overrides_file.ReadElementCount64();` instead of `const auto number_of_overrides = maneuver_overrides_file.ReadVectorSize();`",
+      "prediction": "I think this should be `const auto number_of_overrides = maneuver_overrides_file.ReadVectorSize();` instead of `const auto number_of_overrides = maneuver_overrides_file.ReadElementCount64();`",
       "reference": "This is another bug fix: Without skipping the bytes of the vector this would read garbage data."
     },
     {
-      "prediction": "I think we should be able to do this in a single step, but I'm not sure how to do it. I'm not sure if we need to do this in a single step or if we need to do it in two steps. I'm not sure if we need to do this in a single step or if we need to do it in two steps. I'm not sure if we need to do this in a single step or if we need to do it in two steps. I'm not sure if we need to do this in a single step or if we need to do it in two steps. I'm not sure if we need to do this in a single step or if we need to do it in two steps. I'm not sure if we need to do this in a single step or if we need to do it in two steps. I'm not sure if we need to do this in a single step or if we need to do it in two steps. I'm not sure if we need to do this in a single step or if we need to do it in two steps. I'm not sure if we need to do this in a single step or if we need to do it in two steps. I'm not sure if we need",
+      "prediction": "I think we can remove the `if startHeight == 0` check here.",
       "reference": "why need this? i don't see Gen.CreatorPubKey being used?"
     },
     {
-      "prediction": "I'm not sure if this is the best place to put it, but I think we should move it to `site#communities` instead of `site#communities/:communities_locale`.",
+      "prediction": "I don't think this is necessary.",
       "reference": "As previously mentioned, best to drop this locale override. It's not something we only provide in exceptional circumstances. Moreover, it doesn't work for this PR anyway, while massively increasing the code complexity!"
     },
     {
-      "prediction": "I think we can remove the `VersionDetailsPatch` as it's not needed anymore. We can just use `VersionDetails` instead.",
+      "prediction": "I think we should remove the `{{.}}` and just use `{{ . }}` in the patch.",
       "reference": "is this supposed to be `Desired`?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"when not all documents in the query have a value\"",
+      "prediction": "I think it's better to use `DocIdSetIterator.all(1).getClass()` instead of `DocIdSetIterator.all(1).getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass().getClass",
       "reference": "The iterator is not wrapped when the score mode is set to `COMPLETE_NO_SCORES` so you don't need to change this assertion anymore ?"
     },
     {
-      "prediction": "I don't think this is a good idea. It would be better to use `os.makedirs()` instead of `os.makedirs()`",
+      "prediction": "I don't think this is necessary. We can just use `os.makedirs` directly.",
       "reference": "Is there too much spaces there? (should be 4 I think)"
     },
     {
@@ -30719,15 +30719,15 @@
       "reference": "IS_FIRST_PULL revision is better to use instance property, not static. When KieClient has only one instance, instance property is better. When KieClient has many instances(not possible), static is not good eitheir."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this. I'm not sure what you're trying to achieve with this. I'm not sure what you're trying to achieve with this. I'm not sure what you're trying to achieve with this. I'm not sure what you're trying to achieve with this. I'm not sure what you're trying to achieve with this. I'm not sure what you're trying to achieve with this. I'm not sure what you're trying to achieve with this. I'm not sure what you're trying to achieve with this. I'm not sure what you're trying to achieve with this. I'm not sure what you're trying to achieve with this. I'm not sure what you're trying to achieve with this. I'm not sure what you're trying to achieve with this. I'm not sure what you're trying to achieve with this. I'm not sure what you're trying to achieve with this. I'm not sure what you're trying to achieve with this. I'm not sure what you're trying to achieve with this. I'm not sure what you're trying to achieve with this. I'm not sure what you're trying to achieve with this. I'm not sure what you're trying to",
+      "prediction": "I don't think we need to mix in `fontawesome5_icon_mixin` as it's already included in `bootstrap3`",
       "reference": "This needs to be removed since we removed the mixin."
     },
     {
-      "prediction": "I don't think we need to use `RaftPart::RaftPart` in this case. We can just use `RaftPart` directly.",
+      "prediction": "I don't think this is necessary. We can just use `raft::RaftPart` instead of `FileBasedWalPolicy` and `RaftPart`.",
       "reference": "Can `weight_` be deleted?"
     },
     {
-      "prediction": "I'm not sure if this is a good idea or not, but I'm not sure if it's a good idea to have this in the `EasyAdminExtension` class. I think it's better to have it in the `EasyAdminConfiguration` class.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in `EasyAdminExtension.php` instead of `EasyAdminExtensionExtension.php`.",
       "reference": "This is fine, but by Symfony convention this part is responsability of the compiler pass class, i.e `DependencyInjection\\Compiler\\?`"
     },
     {
@@ -30735,31 +30735,31 @@
       "reference": "The host object already has a nice way of querying configprint. Try `puppet('master')['user']`"
     },
     {
-      "prediction": "I'm not sure what you mean by \"default_addons()\". It's not defined anywhere in the code.",
+      "prediction": "I don't think we need to add `upload` to `default_addons` as it's already in the `addons.py` file.",
       "reference": "Let's call this `share` and not `upload` - the user wants to share their flows, uploading is just the implementation of that. :)"
     },
     {
-      "prediction": "I think this should be `wx.MiniFrame` instead of `wx.Dialog`.",
+      "prediction": "I don't think it's necessary to call `super(SpeechViewerFrame, self).__init__(...)` in this case.",
       "reference": "It would be better to keep focus on the main text control. But to get around the fact that Dialogs focus their first child on show, even when not active, something like Dialog.isActive should be chcked when appending text, rather than whether the text control has focus."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to add the size of the exit stub to the emitted size of the trace. I'm not sure what you're trying to do here, but it looks like you're trying to add the size of the exit stub to the emitted size of the trace. I'm not sure what you're trying to do here, but it looks like you're trying to add the size of the exit stub to the emitted size of the trace. I'm not sure what you're trying to do here, but it looks like you're trying to add the size of the exit stub to the emitted size of the trace. I'm not sure what you're trying to do here, but it looks like you're trying to add the size of the exit stub to the emitted size of the trace. I'm not sure what you're trying to do here, but it looks like you're trying to add the size of the exit stub to the emitted size of the trace. I'm not sure what you're trying to do here, but it looks like you're trying to add the size of the exit stub to the emitted size of the trace. I'm not sure what you're trying to",
+      "prediction": "I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure I understand what you're trying to do here. I'm not sure",
       "reference": "So is this invoked every time we extend the trace?"
     },
     {
-      "prediction": "I think we can remove the `if (kv.second.getInt() < 0 || kv.second.getInt() > 999)` check.",
+      "prediction": "I think it's better to use `std::numeric_limits::max() / 10000000` instead of `std::numeric_limits::max() / 10000000 / 1000000`",
       "reference": "Why not use switch here?"
     },
     {
-      "prediction": "I don't think this is necessary. The `AuthFree` field is only used in the `AuthFree` case, so it doesn't need to be there.",
+      "prediction": "I don't think this is needed.",
       "reference": "I think `NoAuth` is a better name"
     },
     {
-      "prediction": "I think we should remove the `r.Error` here.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this, so that we don't have to call it from the `waitStreamPartClose` function.",
       "reference": "This does create a minor bifurcation in how closing the InputWriter is done in success vs failure cases. Is there anyway to merge this with the success exit path? This is something that seems like it would be better as a function closure instead of method on the `$esapi.Name` type. Can the `es.Close` not be used instead of this method?"
     },
     {
-      "prediction": "I think we can remove the `__init__` method. It's not needed anymore.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "Please keep this blank line. PEP8 says: > Method definitions inside a class are surrounded by a single blank line."
     },
     {
@@ -30771,35 +30771,35 @@
       "reference": "Probably change \"ovs\" to \"OVS\"."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do it here.",
+      "prediction": "I don't think this is necessary.",
       "reference": "Please linebreak this"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but I'm not sure if this is the best way to do it.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `Blockchain.Data` namespace, since it's not part of the `Nethermind.Blockchain.Data` namespace.",
       "reference": "`= default` is implied here, so having it is redundant. Is it a stylistic choice to include it, or just an oversight?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"Create(projectName string) error\". Could you please provide more context?",
+      "prediction": "I think we should remove the `Create` method from the `wsProjectManager` interface.",
       "reference": "Maybe it's time to fix the param name for this interface?"
     },
     {
-      "prediction": "I think we should remove `map[string]*commonpb.Payload` from the `Memo` field.",
+      "prediction": "I think we can remove the `map[string]*commonpb.Payload` here.",
       "reference": "Why are we removing it? Looks like useful info. Obviously, field names should change."
     },
     {
-      "prediction": "I think it's better to have a constructor that takes a  as a parameter.",
+      "prediction": "I think this should be `private IValueFormatter _valueFormatter;` instead of `private readonly IValueFormatter _valueFormatter;`",
       "reference": "Missing fallback to MessageTemplates.ValueFormatter.Instance"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with `axis=0` and `as_index=True`.",
+      "prediction": "I'm not sure what you mean by `axis=0`",
       "reference": "The parameter in the docstring should be fixed too. Actually, why don't you try to implement the other axis? It wouldn't be impossible to do if we use pandas UDF from a cursory look. We have enough time before the next release currently."
     },
     {
-      "prediction": "I'm not sure if this is a good place to put it, but I think we should move it to the `osconfig` package. It's a bit more general than `osconfig`, but it's still related to the `osconfig` package.",
+      "prediction": "I'm not sure if this is the best place to put this, but I think it would make sense to move it to the `osconfig` package.",
       "reference": "This also runs a patch if its in the middle of one."
     },
     {
-      "prediction": "I think this should be `seelog.Debug(\"Updating task: %s\", task.String())` instead of `seelog.Debugf(\"Updating task: %s\", task.String())`",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to set the status to the minimum of the container's known status and the minimum of the task's known status. If the container's known status is greater than the minimum of the task's known status, then the container's known status will be the minimum of the container's known status and the minimum of the task's known status. If the container's known status is less than the minimum of the task's known status, then the container's known status will be the minimum of the container's known status and the maximum of the task's known status. If the container's known status is equal to the minimum of the task's known status, then the container's known status will be the minimum of the container's known status and the minimum of the task's known status.",
       "reference": "Could we rename this method to `updateKnownStatus` ?"
     },
     {
@@ -30807,71 +30807,71 @@
       "reference": "Maybe it would make sense to move that to DecorateRootSpan? Currently it only has Azure stuff, but given the name of the method I feel like it would be semantically appropriate"
     },
     {
-      "prediction": "I'm not sure what you mean by `extnapi` and `networkingv1` in this context. Could you please provide more context?",
+      "prediction": "I'm not sure if this is a good place to put this, but I think it's a good idea to have a separate package for this, so that we don't have to import it in all the places where we need it.",
       "reference": "nit: these imports were in a separate group to ones from this repo"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate enum for `Push` and `PushContainerized` so that we can distinguish between the two.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate enum for `Push` and `PushContainerized`.",
       "reference": "Is it possible to rename the methods to `isXXXMethod` to keep the usage by the caller generic? The caller could use the result of these methods to verify whether a feature is enabled or to validate an input value for example."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a timeout for the `attemptRm` function. This way, if the `attemptRm` function takes too long to run, it will be retried.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `setTimeout` here.",
       "reference": "Don't penalize everyone with 250ms delay b/c some machines have problems."
     },
     {
-      "prediction": "I think it's better to use `try-with-resources` instead of `catch (Exception e) { log.error(\"Failed parsing config file after update: \" + filename, e); }`",
+      "prediction": "I think it's better to use `try`/`catch` here instead of `try`/`catch`/`finally`.",
       "reference": "This try-catch should be here so that watcher thread doesn't just exit in case of an exception. This change alone would probably be enough to fix the error as well, assuming that there's another `ENTRY_MODIFY` event when the file write is finalized. But of course not a perfect fix because it doesn't protect against possibly reading a non-empty but only partially written file?"
     },
     {
-      "prediction": "I think this should be `if s == nil { return false; }` instead of `if s == nil { return false; }`",
+      "prediction": "I don't think this is necessary. We can just use `s.running` and `s.eventsEnabled` directly.",
       "reference": "Weird that we have to check for `s == nil` here.. I would instead have fixed the call stack to find out when this gets invoked with a nil server."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `Ember.Handlebars.Utils.escapeExpression` instead of `Ember.Handlebars.Utils.format`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a `message` property to the `Invitation` model, so that we can use it in the template.",
       "reference": "The `import` statement for `Ember` is missing in this file."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to update the state of the component, but you're not updating the state of the parent component. I think you should be updating the state of the parent component, not the child component.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `getDerivedStateFromProps` function, since it's called by the `getDerivedStateFromProps` function.",
       "reference": "Awesome :tada: I'd love to have a test case for this so that we don't regress on this feature in any future refactorings :+1:"
     },
     {
-      "prediction": "I think this should be `pd.date_range('2012-1-1 12:45:31', periods=3, freq='W')` instead of `pd.date_range('2012-1-1 12:00:00', periods=3, freq='M')`",
+      "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `pd.date_range` with `freq='W'` and `freq='M'`. I think it's better to use `pd.date_range` with `freq='D'` and `freq='M'`.",
       "reference": "For testing some of the rounding functions"
     },
     {
-      "prediction": "I don't think this is necessary.",
+      "prediction": "I don't think we need to change the rounding type here.",
       "reference": "This should be present in UPGRADE notes. Also on currently running projects you should suggest users to update these settings."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in `backpressureDiskLimiter` instead of `backpressureDiskLimiterTracker`.",
       "reference": "Are you sure you want to do this? This will affect the working set block cache too, such that it'll now be tracking global free space. It throws off the fraction calculation."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use a mutex to protect the attached listener.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to `CompoundReaderListener::getAttachedListener()`.",
       "reference": "Why would the read access need to be mutexed? The caller might still get a wrong answer since the value might change immediately after the mutex is unlocked before the caller receives the value."
     },
     {
-      "prediction": "I think this should be `on_mode_left` instead of `on_mode_entered`?",
+      "prediction": "I think this should be `tab = self.currentWidget()` instead of `tab = self.currentWidget()`.",
       "reference": "This fits on one line without the parentheses :wink:"
     },
     {
-      "prediction": "I don't think this is a good idea. We should be able to specify the number of nodes in the cluster when creating the cluster.",
+      "prediction": "I don't think we need to do this.",
       "reference": "Looks like `TestCloudRecovery` changes are unrelated?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way",
+      "prediction": "I don't think we need to change the table name here.",
       "reference": "Try to separate it to different methods. Invoke is huge :)"
     },
     {
-      "prediction": "I don't think this is a good idea. It would be better to have a unique id for each plan.",
+      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here.",
       "reference": "Looks like another spot that would benefit from `truncate`"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to set the value of a `h2o_token_t` to `mrb_str_new_lit()`. I think you want to set the value of a `h2o_token_t` to `mrb_ary_set()`, but I'm not sure what you're trying to do here. I think you want to set the value of a `h2o_token_t` to `mrb_ary_set()`, but I'm not sure what you're trying to do here. I think you want to set the value of a `h2o_token_t` to `mrb_ary_set()`, but I'm not sure what you're trying to do here. I think you want to set the value of a `h2o_token_t` to `mrb_ary_set()`, but I'm not sure what you're trying to do here. I think you want to set the value of a `h2o_token_t` to `mrb_ary_set()`, but I'm not sure what you're trying to do here. I think you want to set the value of a `h2o_token_t` to `mrb_ary_set()`,",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `mrb_ary_set` to set the value of a `h2o_token_t` in this way. I think it's better to use `mrb_ary_set` to set the value of a `h2o_token_t` and then use `mrb_ary_get` to get the value of a `h2o_token_t` and then use `mrb_ary_set` to set the value of a `h2o_token_t` again.",
       "reference": "This change is not related to what this PR wanted to fix, but undefined behavior sanitizer warns without this parenthesis because `h2o__tokens + i` overflows."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `no_docstring_rgx` config option to check if the function name matches the `no_docstring-rgx` regular expression. This way, we don't have to check every single function in the codebase.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to use the `no_docstring_rgx` config option in the same way that we use the `docstring_min_length` config option. If we do that, we should be able to use the `no_docstring_rgx` config option in the same way that we use the `docstring_min_length` config option. If we do that, we should be able to use the `no_docstring_rgx` config option in the same way that we use the `docstring_min_length` config option. If we do that, we should be able to use the `no_docstring_rgx` config option in the same way that we use the `docstring_min_length` config option. If we do that, we should be able to use the `no_docstring_rgx` config option in the same way that we use the `docstring_min_length` config option. If we do that, we should be able to use the `no_docstring_rgx` config option in the same way that we use the `docstring_min_length` config option. If we do that, we should be able to use the `no_docstring",
       "reference": "This is actually incorrect and should be the other way around. Going to fix this tomorrow. If `no_docstring_rgx == re.compile(\"\")` no function should be checked, since every function matches the pattern. If `no_docstring_rgx == re.compile(\"^$\")` all functions should be checked."
     },
     {
@@ -30879,15 +30879,15 @@
       "reference": "Should this be in a config file?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear what you're trying to do here. It's not clear",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to use `eachAsync` in this context.",
       "reference": "purely preference, but have you considered using parentheses to indicate that a method is being tested? e.g., `describe('eachAsync()')`"
     },
     {
-      "prediction": "I think it's better to use `fs::FileUtils::remove` instead of `fs::FileUtils::exist`.",
+      "prediction": "I don't think we need to remove the parent directory.",
       "reference": "Why not return success?"
     },
     {
-      "prediction": "I don't think we need to use `get_cfg_var` here. We can just use `ini_get` and `strtr` here.",
+      "prediction": "I don't think you need to use `get_cfg_var` here. `ini_get` will do the same thing.",
       "reference": "Please use snake_case for properties to keep it consistent with the rest of the codebase."
     },
     {
@@ -30899,11 +30899,11 @@
       "reference": "Oh, so this test leaks DateTimeUtils offset? It would be safer to place the reset in an `@After` method to not cause side effects even if the test case fails."
     },
     {
-      "prediction": "I don't think we need to use `if` here, we can just use `! footerText`",
+      "prediction": "I don't think we need to use the `tab` prop in this case.",
       "reference": "Kind of a nit-pick, but is there no way to solve this while still not rendering an empty div if `footerText` is empty? We could still use the `Row` to maintain the same layout but then only render the `Cell` for the pagination - I think it's possible to use specific classes to horizontally offset?"
     },
     {
-      "prediction": "I think it's a good idea to make this a `enum` instead of an `enum class`.",
+      "prediction": "I think it's a good idea to have a `DOMAIN` in the `DomainChangeMessage` class.",
       "reference": "Template is also not an object type so I don't expect to notify on templates. Instead when applying templates, we'll be updating roles/policies/services/groups."
     },
     {
@@ -30911,39 +30911,39 @@
       "reference": "Had to fix this to get my tests passing (should have been a new PR sorry)."
     },
     {
-      "prediction": "I'm not sure if this is the right place to add this parameter, but I think it's a good idea to add it to the `VaultIssuer` struct.",
+      "prediction": "I don't think this is needed.",
       "reference": "Small nit, and sorry for not spotting sooner.. this should have `omitempty` on it, else when marshalling nil values into json, it will be `caBundle: null` which trips up some JSON parsers"
     },
     {
-      "prediction": "I think this should be `transposed = param.Boolean(default=False, doc=\"\"\"\n        Whether to transpose the layout when plotting\"\"\")\"\"\", doc=\"\"\"\n        Whether to transpose the layout when plotting\"\"\")\"\"\", doc=\"\"\"\n        Whether to transpose the layout when plotting\"\"\")\"\"\", doc=\"\"\"\n        Whether to transpose the layout when plotting\"\"\")\"\"\", doc=\"\"\"\n        Whether to transpose the layout when plotting\"\"\")\"\"\", doc=\"\"\"\n        Whether to transpose the layout when plotting\"\"\")\"\"\", doc=\"\"\"\n        Whether to transpose the layout when plotting\"\"\")\"\"\", doc=\"\"\"\n        Whether to transpose the layout when plotting\"\"\")\"\"\", doc=\"\"\"\n        Whether to transpose the layout when plotting\"\"\")\"\"\", doc=\"\"\"\n        Whether to transpose the layout when plotting\"\"\")\"\"\", doc=\"\"\"\n        Whether to transpose the layout when plotting\"\"\")\"\"\", doc=\"\"\"\n        Whether to transpose the layout when plotting\"\"\")\"\"\", doc=\"\"\"\n        Whether to transpose the layout when plotting\"\"\")\"\"\", doc=\"\"\"\n        Whether to transpose the layout when plotting\"\"\")\"\"\", doc=\"\"\"\n        Whether to transpose the layout when plotting\"\"\")\"\"\", doc=\"\"\"\n        Whether to transpose the layout when plotting\"\"\")\"\"\", doc=\"\"",
+      "prediction": "I think this should be `transposed = param.Boolean(default=False, doc=\"\"\"\n        Whether to transpose the layout when plotting\"\"\")`",
       "reference": "Would be good to say the normal behavior is scanline order (left to right, top to bottom) and that transposing makes it work top to bottom and left to right."
     },
     {
-      "prediction": "I'm not sure what you mean by \"unexpected consequences\". I think it's more about the fact that this flag may have unexpected consequences when uploading/downloading files. If both this flag and \"--drive-use-created-date\" are set, the created date is used.",
+      "prediction": "I'm not sure what you mean by \"unexpected consequences\". I think it's just that we don't want to use the date from the shared file. If we do use the date from the shared file, we'll have to deal with the fact that the date from the shared file may not be the same as the date from the local file.",
       "reference": "Perhaps note here that `--drive-use-created-date` takes precedence if both set?"
     },
     {
-      "prediction": "I think we can remove the `eps` argument from the `update_hyperparameters` method.",
+      "prediction": "I don't think we need to update the hyperparameters here.",
       "reference": "Use EPS=1e-15 as that in atss_head or FCOS head."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this test, but I'm not sure if it's a good idea to use `repo.NewMasterIndex()` in this case. It's not clear what you're trying to achieve with this test, but I'm not sure what you're trying to achieve with this test, but I'm not sure what you're trying to achieve with this test, but I'm not sure what you're trying to achieve with this test, but I'm not sure what you're trying to achieve with this test, but I'm not sure what you're trying to achieve with this test, but I'm not sure what you're trying to achieve with this test, but I'm not sure what you're trying to achieve with this test, but I'm not sure what you're trying to achieve with this test, but I'm not sure what you're trying to achieve with this test, but I'm not sure what you're trying to achieve with this test, but I'm not sure what you're trying to achieve with this test, but I'm not sure what you're trying to achieve with this test, but I'm not sure what you're trying to achieve with this test, but I'm not sure what you're trying to",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it's a good idea to have a separate test for this. It's",
       "reference": "Is there a need to replace the Index with a MasterIndex?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a test that verifies that the mock ExecCommandAgent is still running after the kill signal is sent to it.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the right place to do this, but I think it would be good to have a separate test for this. It's not clear to me that this is the",
       "reference": "are we adding stop state change in a different PR?"
     },
     {
-      "prediction": "I think this should be `@default_org = current_user.org if @orgs.include?(current_user.org)` instead of `@default_org = current_user.org if @orgs.include?(current_user.org)`",
+      "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.",
       "reference": "How much difference is there between sort and sort_by ?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think we need to change anything here.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to call `opae_api_adapter_table` directly from `opae_plugin_mgr_initialize_all()`. It's better to use `opae_api_adapter_table` from `opae_plugin_mgr_init()`, and then call `opae_api_adapter_table` from `opae_plugin_mgr_initialize_all()`.",
       "reference": "count doesn't seem to be used. Let's remove it."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to clear the query cache. I'm not sure what you're trying to achieve with this, but it looks like you're trying to clear the query cache. I'm not sure what you're trying to achieve with this, but it looks like you're trying to clear the query cache. I'm not sure what you're trying to achieve with this, but it looks like you're trying to clear the query cache. I'm not sure what you're trying to achieve with this, but it looks like you're trying to clear the query cache. I'm not sure what you're trying to achieve with this, but it looks like you're trying to clear the query cache. I'm not sure what you're trying to achieve with this, but it looks like you're trying to clear the query cache. I'm not sure what you're trying to achieve with this, but it looks like you're trying to clear the query cache. I'm not sure what you're trying to achieve with this, but it looks like you're trying to clear the query cache. I'm not sure what you're trying to achieve with this, but it looks like you're trying to clear",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have this in the `mongoid/lib/mongoid/query_cache.rb` file.",
       "reference": "Mongo is a hard dependency for Mongoid. Why do we need an if-statement to if it's defined? We should always use Mongo::QueryCache"
     },
     {
@@ -30951,19 +30951,19 @@
       "reference": "Does this point out at a ROR funder id? If so, could we get rid of the `funder_name` field on the plan and just use the `name` of the funder with id `funder_id`?"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to use `global.flatbuffers = flatbuffers;` in this case. I think it's a good idea to use `flatbuffers = require('flatbuffers').flatbuffers;` in this case.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `fs.readFileSync` instead of `fs.createReadStream`.",
       "reference": "Use !! to cast to bool, rather than the ternary bool antipattern."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this. I think it's a good way to do this",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it.",
       "reference": "why is it in the list twice to begin with?"
     },
     {
-      "prediction": "I think this should be `if (g_creatureEvents->playerLogout(this))` instead of `if (!g_creatureEvents->playerLogout(this))`",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do it here.",
       "reference": "This way you will **never** be kicked while monsters are around you."
     },
     {
-      "prediction": "I don't think this is a good idea. It's not a good idea to change the signature of a method in a way that it doesn't work anymore.",
+      "prediction": "I don't think this is necessary. We can just remove the `@Before` annotation.",
       "reference": "Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC."
     },
     {
@@ -30975,7 +30975,7 @@
       "reference": "This was a bug in KBFS-2071 -- oops."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to do something like this: https://github.com/ethereum/go-ethereum/pull/14385.",
+      "prediction": "I'm not sure if this is a good idea, but I think we should have a separate field for the conditions. I think it would be better to have a separate field for the conditions and the Redeemed flag.",
       "reference": "// Condition is a condition for ... Condition"
     },
     {
@@ -30983,27 +30983,27 @@
       "reference": "Might be good to test that no emails were sent out, either. You should be able to use `deliveries` for this"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this.",
+      "prediction": "I don't think we need to do this. We can just use the `sendText` method to send the serialized object.",
       "reference": "Right now this is experimental and deeply flaky. We left this at `info` to make debugging user reports a lot easier."
     },
     {
-      "prediction": "I don't think this is necessary. The `vendorProjectDirectory` is already set in the `UpdateVendors` class, so we don't need to set it again.",
+      "prediction": "I don't think we need to add this to the list of files to skip.",
       "reference": "Is this new list being consumed yet?"
     },
     {
-      "prediction": "I think we can remove the `weakrand.Seed(time.Now().UnixNano())` line.",
+      "prediction": "I think we should remove the `weakrand.Seed` line.",
       "reference": "moved to `errors.go` which is the only places `math/rand` is used in this package"
     },
     {
-      "prediction": "I don't think this is necessary. We can just use `Symfony\\Component\\HttpFoundation\\Request` instead of `Symfony\\Component\\Filesystem\\Filesystem`.",
+      "prediction": "I don't think this is necessary. The `Environment` class is already defined in the `ShopKernel` class, so we don't need to create a new one.",
       "reference": "This use is wrong, corrent is: `Shopsys\\FrameworkBundle\\Component\\Environment` It is the same in classes below"
     },
     {
-      "prediction": "I'm not sure what you mean by \"fixUpHost\" here. I think you meant to say `pendingRequest.configuration.remoteHost = pendingConfiguration.remoteHost;` or `pendingRequest.configuration.host = pendingConfiguration.host;`?",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the remote host is valid. If the remote host is not valid, then the request will fail.",
       "reference": "This is not really needed, the line added in `GridNodeConfiguration.java` is what really fixes the `remoteHost` regression."
     },
     {
-      "prediction": "I think we can remove the `container.SetKnownExitCode(metadata.ExitCode)` line.",
+      "prediction": "I think we can remove the `if metadata.ExitCode != nil` check.",
       "reference": "For my understanding, why was this removed?"
     },
     {
@@ -31015,51 +31015,51 @@
       "reference": "Can you please set this as an error on the password view, rather than a toast, just to make sure that it is kept consistent. Check out a couple of lines below."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to make sure that the connection status is set to `openvpn` before we try to connect to it.",
+      "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use the `openvpn` provider for this test.",
       "reference": "Shouldn't we pass here a proposal too?"
     },
     {
-      "prediction": "I'm not sure what the problem is here, but I think we should raise an error here. It's not clear to me what the problem is here, but I think we should raise an error here. It's not clear to me what the problem is here, but I think we should raise an error here. It's not clear to me what the problem is here, but I think we should raise an error here. It's not clear to me what the problem is here, but I think we should raise an error here. It's not clear to me what the problem is here, but I think we should raise an error here. It's not clear to me what the problem is here, but I think we should raise an error here. It's not clear to me what the problem is here, but I think we should raise an error here. It's not clear to me what the problem is here, but I think we should raise an error here. It's not clear to me what the problem is here, but I think we should raise an error here. It's not clear to me what the problem is here, but I think we should raise an error here. It's not clear to me what the problem is here, but I think we",
+      "prediction": "I'm not sure if this is the right place to raise an error here, but I think it would be good to raise an error here. It's not clear to me if this is the right place to raise an error here, but I think it would be good to raise an error here. It's not clear to me if this is the right place to raise an error here, but I think it would be good to raise an error here. It's not clear to me if this is the right place to raise an error here, but I think it would be good to raise an error here. It's not clear to me if this is the right place to raise an error here, but I think it would be good to raise an error here. It's not clear to me if this is the right place to raise an error here, but I think it would be good to raise an error here. It's not clear to me if this is the right place to raise an error here, but I think it would be good to raise an error here. It's not clear to me if this is the right place to raise an error here, but I think it would be good to raise an error here. It's not clear to me if this is the",
       "reference": "im not a huge fan of exact text match in these tests, not sure what a good solution is that solves the same problem"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this route. It looks like you're trying to add a handler for the `/stamps/topup/{id}/{amount}` endpoint, but it's not clear what you're trying to do with this route. It looks like you're trying to add a handler for the `/stamps/topup/{id}/{amount}` endpoint, but it's not clear what you're trying to do with this route. It looks like you're trying to add a handler for the `/stamps/topup/{id}/{amount}` endpoint, but it's not clear what you're trying to do with this route. It looks like you're trying to add a handler for the `/stamps/topup/{id}/{amount}` endpoint, but it's not clear what you're trying to do with this route. It looks like you're trying to add a handler for the `/stamps/topup/{id}/{amount}` endpoint, but it's not clear what you're trying to do with this route. It looks like you're trying to add a handler for the `/stamps/topup/{id}/{amount}` endpoint, but it's not clear what you're trying to do with this route. It looks like you're trying to add",
+      "prediction": "I don't think we need to do this.",
       "reference": "this should _not_ be in the api. all postage APIs have moved to the debugAPI"
     },
     {
-      "prediction": "I think this is a bit too strict. I think we can just use `name.replace('_','_')` instead.",
+      "prediction": "I think we can remove this line. It's not needed anymore.",
       "reference": "Including both functions seems like overkill for this PR since only _is_internal_node is ever used. Keep them if you think they'll both be used in the future, but if not, the code will be easier to read if you collapse the logic into a single function."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a certificate with a specific organization and country, but you're not using the `pkix.Name` struct. I think you should be using the `pkix.Name` struct from the `github.com/golang/protobuf/protoc-gen-protobuf/protoc-gen-protobuf` package.",
+      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a certificate with a specific organization and country, but you're also trying to add a DNS name to the certificate. I'm not sure what you're trying to do here, but it looks like you're trying to create a certificate with a specific organization and country, but you're also trying to add a DNS name to the certificate. I'm not sure what you're trying to do here, but it looks like you're trying to create a certificate with a specific organization and country, but you're also trying to add a DNS name to the certificate. I'm not sure what you're trying to do here, but it looks like you're trying to create a certificate with a specific organization and country, but you're also trying to add a DNS name to the certificate. I'm not sure what you're trying to do here, but it looks like you're trying to create a certificate with a specific organization and country, but you're also trying to add a DNS name to the certificate. I'm not sure what you're trying to do here, but it looks like you're trying to create a certificate with a specific organization and country, but you're also trying to",
       "reference": "It seems that the two words mean the same thing."
     },
     {
-      "prediction": "I don't think this is necessary.",
+      "prediction": "I don't think we need to do this.",
       "reference": "Do we need to set lastLogTerm_ to committedLogTerm when `lastLogId_ < committedLogId_`, on line 286"
     },
     {
-      "prediction": "I'm not sure what you mean by \"totalWords.addAndGet(RamUsageTester.sizeOf(dic.wordHashes));\". I think you meant to add `RamUsageTester.sizeOf(dic.wordHashes)` to `totalWords.addAndGet(RamUsageTester.sizeOf(dic.wordHashes));`",
+      "prediction": "I think it's better to use `RamUsageTester.sizeOf()` instead of `RamUsageTester.sizeOf(dic.words) + RamUsageTester.sizeOf(dic.wordHashes)`.",
       "reference": "About ~7% memory usage increase on average, at most 512KB"
     },
     {
-      "prediction": "I'm not sure what you mean by \"Options should not be attached to the ResponseWriter\"",
+      "prediction": "I'm not sure if this is the right place to put this, but I think we should move it to the `ResponseWriter` interface.",
       "reference": "Was this too big of a pain to do now?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"deep copy\" here.",
+      "prediction": "I think we can remove the `const` from `arr_eigvec` and `arr_eigval` and `arr_means` and `arr_vars`.",
       "reference": "Why need to spend time for initializing of array? when will we rewrite the contents anyway? This can take a lot of time in some algorithms. Especially if the filling is in sequential mode."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but I'm not sure if this is the best way to do it.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `workshops.rb` file.",
       "reference": "Can this be `null:false, default: ''` to avoid the nil vs blank issue?"
     },
     {
-      "prediction": "I think this should be `on host, 'echo \"PermitRootLogin yes\" >> /etc/ssh/sshd_config' if ENV['SSH_USER'] == 'root'` instead of `on host, 'echo \"PermitRootLogin yes\" >> /etc/ssh/sshd_config' if ENV['SSH_USER'] == 'root'`",
+      "prediction": "I think this should be `on host, \"passwd #{ENV['SSH_USER']}\", stdin: ENV['SSH_PASSWORD']` instead of `on host, \"dscl . -passwd /Users/#{ENV['SSH_USER']}\", stdin: \"#{ENV['SSH_PASSWORD']}\\n#{ENV['SSH_PASSWORD']}\"`",
       "reference": "Had to add this to get macOS to work."
     },
     {
-      "prediction": "I think this should be `@Rule(TemporaryFolder)` instead of `@Rule(TemporaryFolderRule)`.",
+      "prediction": "I think this should be `@Rule(TemporaryFolder.class)` instead of `@Rule(TemporaryFolder)`",
       "reference": "What is the usage of this class?"
     },
     {
@@ -31067,51 +31067,51 @@
       "reference": "Could we keep the original signatures as well, so we do not have to rewrite the method calls everywhere and add `null, null`? I think this could greatly reduce the changes needed in this patch"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `updateTrieRootsForNewStorage` function.",
       "reference": "Ideally this error should not be swallowed (can do in the next PR)"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `refresh_token` parameter to the `get_registry_url` function. This way, we can make sure that the `refresh_token` parameter is always passed along to the `get_registry_url` function, even if the `refresh_token` parameter is not set.",
+      "prediction": "I'm not sure if this is a good place to put this, but I think it would be good to have it in a separate file. It's a bit of a hack, but I don't think it's a good idea to have it in the same file as the rest of the code.",
       "reference": "Wait a minute... You're passing it as a POST parameter. There's no way that can work."
     },
     {
-      "prediction": "I'm not sure what you mean by \"clean up\" in this context. I think you meant to say \"clean up\" in the context of the `cleanup()` function.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `genName` function.",
       "reference": "minor: to be consistent with other logs, either use \"cleaning up\" (preferred) or \"cleanup\"."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to set the `INFLUX_HOST` environment variable to `influx`, but you're also trying to set `INFLUX_HOST` to `influx` in your code. I'm not sure what you're trying to do here, but it looks like you're trying to set the `INFLUX_HOST` environment variable to `influx`, but you're also trying to set `INFLUX_HOST` to `influx` in your code. I'm not sure what you're trying to do here, but it looks like you're trying to set the `INFLUX_HOST` environment variable to `influx`, but you're also trying to set `INFLUX_HOST` to `influx` in your code. I'm not sure what you're trying to do here, but it looks like you're trying to set the `INFLUX_HOST` environment variable to `influx`, but you're also trying to set `INFLUX_HOST` to `influx` in your code. I'm not sure what you're trying to do here, but it looks like you're trying to set the `INFLUX_HOST`",
+      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to set the `INFLUX_HOST` environment variable to `influx`, but you're also trying to set the `INFLUX_NAMESPACE` environment variable to `listenbrainz`. I'm not sure what you're trying to do here, but it looks like you're trying to set the `INFLUX_HOST` environment variable to `influx`, but you're also trying to set the `INFLUX_NAMESPACE` environment variable to `listenbrainz`. I'm not sure what you're trying to do here, but it looks like you're trying to set the `INFLUX_HOST` environment variable to `influx`, but you're also trying to set the `INFLUX_NAMESPACE` environment variable to `listenbrainz`. I'm not sure what you're trying to do here, but it looks like you're trying to set the `INFLUX_HOST` environment variable to `influx`, but you're also trying to set the `INFLUX_NAMESPACE` environment variable to `listenbrainz`. I'm not sure what you're trying to do here, but it looks like you're trying to set the `INFLUX_HOST`",
       "reference": "Adding the config changes to the consul config template `consul_config.py.ctmpl` would be helpful too."
     },
     {
-      "prediction": "I'm not sure what you mean by \"UNCATEGORIZED\" in this context. It's not clear to me what you're trying to do with this field.",
+      "prediction": "I'm not sure what you mean by \"UNCATEGORIZED\" in this context. I think you meant to say \"RESEARCH_GROUP\" or \"RESEARCH_PROJECTS\" or \"JOURNALS\" or \"ORGANIZATIONS_INSTITUTIONS\" or \"TEACHING_COURSES\" or \"LABORATORY\" or \"RESEARCH_GROUP\" or \"RESEARCH_PROJECTS\" or \"JOURNALS\" or \"ORGANIZATIONS_INSTITUTIONS\" or \"TEACHING_COURSES\" or \"LABORATORY\" or \"RESEARCH_GROUP\" or \"RESEARCH_PROJECTS\" or \"JOURNALS\" or \"ORGANIZATIONS_INSTITUTIONS\" or \"TEACHING_COURSES\" or \"LABORATORY\" or \"RESEARCH_GROUP\" or \"RESEARCH_PROJECTS\" or \"JOURNALS\" or \"ORGANIZATIONS_INSTITUTIONS\" or \"TEACHING_COURSES\" or \"LABORATORY\" or \"RESEARCH_GROUP\" or \"RESEARCH_PROJECTS\" or \"JOURNALS\" or \"ORGANIZATIONS_INSTITUTIONS\" or \"TEACHING_COURSES\" or \"LABORATORY\" or \"RESEARCH",
       "reference": "While we're at it should we add Department? See Dataverse Category: Add Department #2829"
     },
     {
-      "prediction": "I think this should be `accept` instead of `accept`",
+      "prediction": "I think this should be `accept` instead of `accepts`",
       "reference": "Files should have an extra line at the end of them."
     },
     {
-      "prediction": "I'm not sure if this is a good place to put this, but I think it would be a good idea to move this to the `Suspense` component.",
+      "prediction": "I'm not sure if this is a good idea, but I think it's better to have a `Suspense` component than a `Suspense` function.",
       "reference": "TODO: check whether this is needed or not"
     },
     {
-      "prediction": "I don't think we need to change the default value of `ReadConfig.IsInsecure` to `false` because it's already set to `true` by default.",
+      "prediction": "I don't think we need to change the default value of `ReadConfig.IsInsecure` to `true` as it is already set to `false` by default.",
       "reference": "`ReadConfig` is a global variable (from `gochecknoglobals`)"
     },
     {
-      "prediction": "I think this should be `go:build !cgo` instead of `go:build !cgo`",
+      "prediction": "I'm not sure if this is a good idea or not, but I think it's better to have a separate package for this, so that we don't have to change the package name when we switch to cgo.",
       "reference": "This is duplicated with `+build !cgo`?"
     },
     {
-      "prediction": "I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure",
+      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
       "reference": "This should just be `.not_to raise_error` otherwise it potentially hides errors"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to apply a function to each column of the DataFrame, but only on numeric columns. Is this what you're trying to do?",
+      "prediction": "I'm not sure I understand what you're trying to do here. You're trying to apply a function to each column and return a Series with the number of rows equal to the number of columns. Is this what you're trying to do?",
       "reference": "Line 175 needs to be indented so that it's under `sfun`."
     },
     {
-      "prediction": "I think this should be `public override bool Matches(ref BloomStructRef bloom)` instead of `public override bool Matches(Bloom bloom)`",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `AnyTopic` class that can be used for both `AnyTopic` and `AnyTopicRef`.",
       "reference": "It looks strange a bit. What is the reason?"
     },
     {
@@ -31119,19 +31119,19 @@
       "reference": "Is this one of those `LexicalPreservingPrinter` issues?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
+      "prediction": "I don't think we need to do this, we can just use `fmt.Sprintf(\"%v\", v.Len())` instead.",
       "reference": "Can we also add the length of the slice here? Some like ` len %d`"
     },
     {
-      "prediction": "`log` is not used anywhere in this file, so I don't think it's necessary to import it.",
+      "prediction": "`log` should be `zap` instead of `zap`",
       "reference": "move this line together to after line 16, group internal packages together"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new column to the `feedbacks` table. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new column to the `feedbacks` table. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new column to the `feedbacks` table. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new column to the `feedbacks` table. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new column to the `feedbacks` table. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new column to the `feedbacks` table. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new column to the `feedbacks` table. I'm not sure what you're trying to achieve with this, but it looks like you're trying to add a new column",
+      "prediction": "I'm not sure what you mean by \"null: false\"",
       "reference": "How about using a reference(project_id) instead of project name"
     },
     {
-      "prediction": "I don't think we need to use `false` for `UseRDS`.",
+      "prediction": "I don't think we need to change the `UseRDS` value.",
       "reference": "File is not `gofmt`-ed with `-s`"
     },
     {
@@ -31139,11 +31139,11 @@
       "reference": "@qqmyers this looks fine but have you seen any performance issue here? If so, we could right some helper method like doesExternalToolNeedDataset(externalTool). But if there's trivial performance impact, not worth it."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you",
+      "prediction": "I'm not sure what you mean by \"usingLocalPrefs\". Is this a global variable? If so, I think we should make it `static` instead of `const`. If it's a local variable, I think we should make it `static` instead of `const`.",
       "reference": "Make this a member variable instead (move to header inside `class` and rename to `m_bUsingLocalPrefs`)."
     },
     {
-      "prediction": "I'm not sure what you mean by `testSuite.name === 'pin-mongos'`. I think you meant to say `testSuite.name === 'pin-mongos' ? it.skip : it`",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a `skipReason` property to the `testData` object. This way, we can add a `skipReason` property to the `testSuite` object, and then we can use it in the `testSuite.tests.forEach` loop.",
       "reference": "Generally I'd say we should factor this out into something more extensible (check an array of potentially skipped tests, for examples), but since we're likely to remove this soon for scheduled work I think this is fine. What do you think @daprahamian?"
     },
     {
@@ -31151,11 +31151,11 @@
       "reference": "Why are we skipping these tests? they should be passing in HIP-Clang."
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a `__mul__` method to `RandTermString` so that you can use `randstring.RandTermString(10)` instead of `randstring.RandTermString(10, \"\".join(map(chr, range(256))))`.",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a `__mul__` method to `RandTermString` as well. This way, you can use `RandTermString(10)` to create a string of length 10, and `RandTermString(10, \"abc\")` to create a string of length 10 containing the characters \"abc\".",
       "reference": "I think a \"string\" in Scapy's spirit (if such a thing exists) is actually a `bytes` object in Python 3 (see `Str*Field`s). So maybe `RandString._fix()` should return a `bytes` object. What do you think?"
     },
     {
-      "prediction": "I think we should use `require('jsdom')` instead of `require(\"jsdom\")`",
+      "prediction": "I think it's better to use `require('jsdom')` instead of `require('jsdom').jsdom()`.",
       "reference": "This can be combined to 1 line, just tested, seems to work."
     },
     {
@@ -31163,15 +31163,15 @@
       "reference": "what needs to happen if it is not present?"
     },
     {
-      "prediction": "I don't think we need to use `ds.DeploymentConfig.PipedSpec.IsInsecureChartRepository(chartRepoName)` in this case. We can just use `ds.DeploymentConfig.IsInsecureChartRepository(chartRepoName)` instead.",
+      "prediction": "I don't think we need to use `ds.DeploymentConfig.PipedSpec.IsInsecureChartRepository(chartRepoName)` in this case. We can just use `ds.DeploymentConfig.IsInsecureChartRepository(chartRepoName)`.",
       "reference": "`DeploymentConfig` is only for deployment configuration not Piped configuration so `ds.DeploymentConfig.PipedSpec` is always nil. Instead of that, you can have Piped config with `e.PipedConfig` because it is placing inside `executor.Input`."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this code. It's not clear what you're trying to do with this code.",
+      "prediction": "I'm not sure what you're trying to achieve with this code. It seems like you're trying to set the ACL on an object in an Amazon S3 bucket for the given owner, but I'm not sure what you're trying to achieve with this code. Could you please provide more context or clarify your question?",
       "reference": "Simple Storage **Service**"
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `RequestFilter` property of the `InstrumentationContext` class.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "This line doesn't seem to be right?"
     },
     {
@@ -31183,11 +31183,11 @@
       "reference": "I'm curious - is there a way to test these?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to do this in one line.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would make sense to have a `createMetadataTableInstance` method in the `TableOperations` class that takes in the catalog name and the table identifier, and returns a `Table` instance. This way, we don't need to call `createMetadataTableInstance` every time we want to create a new `Table` instance.",
       "reference": "This was broken before as the name of the metadata table started with its type, not catalog."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in `bootstrap.go` instead of `mysterium.go`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add this to `bootstrap.go` as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to `bootstrap.go` as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to `bootstrap.go` as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to `bootstrap.go` as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to `bootstrap.go` as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to `bootstrap.go` as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this to `bootstrap.go` as well. I'm not sure if this is the right place to do this, but I think it's a good idea to add this",
       "reference": "Maybe remake `VersionAsString()` function, so that that we would have build info in all places"
     },
     {
@@ -31195,63 +31195,63 @@
       "reference": "This should probably say something other than SSL_peek?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think we should move this to the `google-site-kit` module.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to move this to the `google-site-kit` module.",
       "reference": "Nitpicking, but this should be capitalized since it's a product name :)"
     },
     {
-      "prediction": "I think we should remove the `time.Time` field from the `TransactionMisc` struct.",
+      "prediction": "I think we should remove the `time` field from the `TransactionMisc` struct.",
       "reference": "Why do we need RawTransactions?"
     },
     {
-      "prediction": "I don't think we need to use `byteutil` here. We can just use `io.ReadCloser` and `io.WriteCloser` directly.",
+      "prediction": "I don't think this is necessary. We can just use `byteutil` directly.",
       "reference": "File is not `gofmt`-ed with `-s` (from `gofmt`)"
     },
     {
-      "prediction": "I think this should be `if (sgv.getMills() > latestDateInReceivedData)` instead of `if (sgv.getMills() > latestDateInReceivedData)/(60 * 1000L) < 15L`",
+      "prediction": "I don't think we need to do this anymore.",
       "reference": "should not be this lessThan15MinAgo ?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"won't run but compiler complains\". I think you meant to say that the `DecodingException` will be caught by the `RejectRequest` method.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this, but I think it would be a good place to do this. I'm not sure if this is the right place to do this",
       "reference": "Would it work if we changed the return type of 'RejectRequest*' methods to Exception and instead did `throw RejectRequest(...` ?"
     },
     {
-      "prediction": "I think this should be `videoTestElement.canPlayType('video/mp4; codecs=\"dts-\"').replace(/no/, '') || videoTestElement.canPlayType('video/mp4; codecs=\"dts+\"').replace(/no/, '')`",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `videoTestElement.canPlayType('video/mp4; codecs=\"dts-\"').replace(/no/, '') || videoTestElement.canPlayType('video/mp4; codecs=\"dts+\"').replace(/no/, '')`.",
       "reference": "It is not a \"perfect\" test, but: webOS 1.2 emulator says `probably`. webOS 3 emulator says \\``. webOS 4 emulator says \\``. Why did you remove `options.supportsDts`?"
     },
     {
-      "prediction": "I don't think we need to change this. It's the same as `hipMemcpy`.",
+      "prediction": "I'm not sure what you mean by \"move to ihip memory copy implementaion.\" Is there a reason for this change?",
       "reference": "This check should be after the HIP_INIT_API to ensure HIP tracing & lazy init works correctly. Also return should be wrapped in ihipLogStatus() so that logging works correctly."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to clear the search index for a specific set of sites and record types. Is this what you're trying to achieve?",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a `clearSearchIndex` option to the `ReIndexTask` class.",
       "reference": "Can't use short array syntax for the 3.1 release branch."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to log this in the `pmix_globals.debug_output` as well.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to do this in the `pmix_output` function, since it will be called from the `pmix_output` function as well.",
       "reference": "@rhc54 Is this intentional or for debug purposes?"
     },
     {
-      "prediction": "I think we should remove the `for_resources` argument from the `ResourceChanged` subscriber.",
+      "prediction": "I think it's better to use `on_resource_changed` instead of `on_resource_changed_for_resources` because `on_resource_changed_for_resources` will be called for every resource, but `on_resource_changed` will only be called for resources that are changed.",
       "reference": "Maybe it should be `plugins.history` here instead of `listeners.X`, since we use those for listeners configured via `.ini` files?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"team_page?\"",
+      "prediction": "I think this should be `@team_plan_quantity_select_attributes` instead of `@team_page?`",
       "reference": "Hmm, I also don't have a better idea here. As a small thing, could you make this `@team_page.present?` or similar to make the intent slightly more clear?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this. It's not clear what you're trying to do with this. It's not clear what you're trying to do with this. It's not clear what you're trying to do with this. It's not clear what you're trying to do with this. It's not clear what you're trying to do with this. It's not clear what you're trying to do with this. It's not clear what you're trying to do with this. It's not clear what you're trying to do with this. It's not clear what you're trying to do with this. It's not clear what you're trying to do with this. It's not clear what you're trying to do with this. It's not clear what you're trying to do with this. It's not clear what you're trying to do with this. It's not clear what you're trying to do with this. It's not clear what you're trying to do with this. It's not clear what you're trying to do with this. It's not clear what you're trying to do with this. It's not clear what you're trying to do with this. It's not clear what you're trying to",
+      "prediction": "Shouldn't this be `if (ivLength != 16 && ivLength != 32)` instead of `if (ivLength != 16 && ivLength != 32 && ivLength != 32)`?",
       "reference": "Without that check it would fail later (probably in the getDecryptingCipher method) but the error could be hard to make sense of."
     },
     {
-      "prediction": "I think this should be `do_restore_snapshot snapshot_name` instead of `do_restore_snapshot snapshot_name: snapshot_name`",
+      "prediction": "I think this should be `:hypervisor` instead of `self[:hypervisor]`.",
       "reference": "I don't think that this belongs in the host code. A host is pretty much unaware of what hypervisor is running it and I don't want them to be so coupled to their hypervisor."
     },
     {
-      "prediction": "I'm not sure why we need `pbr` here. I think we can just use `setuptools>=12` for now.",
+      "prediction": "I'm not sure why we need `pbr` here. I think we can just use `setuptools>=12` and `setuptools` will take care of `pbr` for us.",
       "reference": "I'm here to tell you that this doesn't make sense because of the way it works. `setuptools.setup()` installs this only for setup-time and then discards those. But the problem is that it will not pick up a newer version because the older version is already in runtime and module cannot substitute itself. The proper place for adding build deps nowadays is `pyproject.toml`->`[build-system]`->`requires'."
     },
     {
-      "prediction": "I don't think this is necessary. We can just use `connectionManager` instead of `fakeConnectionManager` in this case.",
+      "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea to expose this interface to the outside world.",
       "reference": "fakeConnectionManager -> mockConnectionManager. We probably should not use the `fake` anymore."
     },
     {
@@ -31259,27 +31259,27 @@
       "reference": "Code style. Btw, it's weird Codacy didn't catch that."
     },
     {
-      "prediction": "I'm not sure what you mean by `NewEthAddress(addr common.Address) *EthAddress`. It seems like you're trying to create a new `EthAddress` from a `common.Address`, but I'm not sure if that's what you want.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate function for `NewEthAddress` and `NewDataSize` so that we don't have to call `NewEthAddress` and `NewDataSize` every time we want to create a new `EthAddress` or `DataSize`.",
       "reference": "no need in BigInt just m.Unwrap().Big().Bitlen() == 0"
     },
     {
-      "prediction": "I think it's better to use `ctx.client.flowOperations.Add` instead of `ctx.client.conjunctiveMatchFlow`.",
+      "prediction": "I think this should be `if err != nil { return err; }` instead of `if err != nil { return err; }`",
       "reference": "I assume you want to change NetworkPolicy to use bundles in a separate PR later?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `localstack-artifacts` repo, since that's where the `stepfunctions-local-patch` artifact is stored.",
+      "prediction": "I think we should remove the `a4adc8f4da9c7ec0d93b50ca5b73dd14df791c0e` from the URL.",
       "reference": "nit: We could parameterize the commit hash, as it's used in multiple places."
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this, but it looks like you're trying to parse a URL and check if it's HTTPS. I'm not sure what you're trying to do with this, but it looks like you're trying to parse a URL and check if it's HTTPS. I'm not sure what you're trying to do with this, but it looks like you're trying to parse a URL and check if it's HTTPS. I'm not sure what you're trying to do with this, but it looks like you're trying to parse a URL and check if it's HTTPS. I'm not sure what you're trying to do with this, but it looks like you're trying to parse a URL and check if it's HTTPS. I'm not sure what you're trying to do with this, but it looks like you're trying to parse a URL and check if it's HTTPS. I'm not sure what you're trying to do with this, but it looks like you're trying to parse a URL and check if it's HTTPS. I'm not sure what you're trying to do with this, but it looks like you're trying to parse a URL and check if it's HTTPS. I'm not sure what you're trying",
+      "prediction": "I don't think we need to use `_.isEqual` here. We can just compare the `scheme` and `host` properties of the `url` object.",
       "reference": "move this above the \"Constants\" as this is 3rd party ones"
     },
     {
-      "prediction": "I'm not sure if this is the right place to add this test, but I think it would be good to add it to the test suite. It's not a big deal, but I think it would be good to add it to the test suite.",
+      "prediction": "I'm not sure what you mean by \"declined\" here. Is it that the capability is not exposed on the homepage? Or is it that the capability is not exposed on the collection page?",
       "reference": "`assert not in`"
     },
     {
-      "prediction": "I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place to do this. I'm not sure if this is the best place to do this, but I think it's a good place",
+      "prediction": "I'm not sure if this is the best place to do this, but I think it's a good place to do this. It's the only place I can think of where we need to do this, and it's the only place I can think of where we need to do this in a way that doesn't cause a race condition.",
       "reference": "just curious, why was this modified?"
     },
     {
@@ -31287,51 +31287,51 @@
       "reference": "I'm curious why the table name is bound at compile time? Is it just to save the table create/drop overhead in a prepare-once-execute-many situation?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this, but I don't think this is a good idea.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to override `getJobId()`.",
       "reference": "quick question, isn't ProcessJob used by all job types? Then why is JOB_ID not found?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think we need to change anything here.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think we should put it in the `AccountSettings` class as well.",
       "reference": "looks like you forgot to actually increase the version"
     },
     {
-      "prediction": "I think it's better to have a separate enum for this, so that we don't have to change the enum when we add a new attribute.",
+      "prediction": "I'm not sure what you mean by \"https://github.com/open-telemetry/opentelemetry-specification/blob/a2758014f408f64ff84728918d671ee3fdab2225/specification/trace/semantic_conventions/http.md#http-server-semantic-conventions.\"",
       "reference": "I think it might be helpful if we add `Default value: False.` on the end of the summary."
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to have a `sync.fullSynchronized` property in the realm constructor. It seems like it could be used to determine if the schema is synced or not, but I'm not sure if it's a good idea to have it in the realm constructor. I'm not sure if it's a good idea to have a `sync.fullSynchronized` property in the realm constructor. It seems like it could be used to determine if the schema is synced or not, but I'm not sure if it's a good idea to have it in the realm constructor. I'm not sure if it's a good idea to have a `sync.fullSynchronized` property in the realm constructor. It seems like it could be used to determine if the schema is synced or not, but I'm not sure if it's a good idea to have it in the realm constructor. I'm not sure if it's a good idea to have a `sync.fullSynchronized` property in the realm constructor. It seems like it could be used to determine if the schema is synced or not, but I'm not sure if it's a good idea to have it in the realm constructor.",
+      "prediction": "I think this should be `if (config.sync.fullSynchronized !== undefined && !config.sync.fullSynchronization && config.schema === undefined)`",
       "reference": "I think the check should be `config.sync.fullSynchronization === false` - otherwise this will get triggered even when full sync is `true`."
     },
     {
-      "prediction": "I think this should be `if se == nil { return nil, status.Error(codes.FailedPrecondition, \"The piped does not contain the encryption configuration\") }` instead of `if se == nil { return nil, status.Error(codes.FailedPrecondition, \"The piped does not contain the encryption configuration\") }`",
+      "prediction": "I think this should be `if se == nil { return nil, status.Error(codes.FailedPrecondition, \"The piped does not contain the encryption configuration\") }`",
       "reference": "this blown my mind"
     },
     {
-      "prediction": "I think we can remove the `ControllerStatusAPILbl` and `ControllerContainerStatusAPILbl` as they are not used anymore.",
+      "prediction": "I think it's better to use `vsm.openebs.io/controller-status` instead of `vsm.openebs.io/replica-cont-status`.",
       "reference": "this should be controller-container-status"
     },
     {
-      "prediction": "I think this should be `Date` instead of `DateTime` and `DateTimeZone` instead of `DateTime`.",
+      "prediction": "I think this should be `Date` instead of `DateTime`?",
       "reference": "Sort import. You can use IDE's organize import feature."
     },
     {
-      "prediction": "I don't think this is a good idea. It's not a good idea to use `URL` in this case. It's better to use `String` or `StringBuffer` instead.",
+      "prediction": "I don't think this is a good idea. It's not a good idea to use `URL` in this case. It's better to use `String` or `StringBuffer` instead of `URL`.",
       "reference": "Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC."
     },
     {
-      "prediction": "I'm not sure why we need to skip this test. It's not a functional test, it's a unit test.",
+      "prediction": "I'm not sure why we need to skip this test.",
       "reference": "This PR is off to a rough start. :)"
     },
     {
-      "prediction": "I think this should be `if ('pac' === config.proxyType)` instead of `if ('pac' === config.proxyType && !config.pacUrl)`.",
+      "prediction": "I think it's better to use `config.proxyAutoconfigUrl` instead of `config.proxyAutoconfigUrl && !config.pacUrl`.",
       "reference": "Actually, it looks like the entire `normalizeProxyConfiguration` function isn't needed anymore"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `link_to` helper instead of the `a` tag.",
+      "prediction": "I don't think we need to use `unless excluded_portal_link` in this case.",
       "reference": "How about `unless current_path == carts_path`?"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I don't think it's a good idea to change the copyright notice in the `pylint.py` file. I think it's better to keep the copyright notice in the `README.md` file.",
+      "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a separate file for this. It's not clear to me what this file should be used for.",
       "reference": "You need to modify the copyrite aliases so it's done automatically."
     },
     {
@@ -31339,23 +31339,23 @@
       "reference": "Quick question: Is this true for all `onAnimation*` and all `onTransition*` events?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a new `Address` object from a `Script` or `PublicKey` object, but you're not actually using the `Script` or `PublicKey` object to create the new `Address` object.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for `Address._transformScript` and `Address._transformString` so that we don't have duplicate code.",
       "reference": "Should sending an address into address error? Since the call isn't needed, and could be fixed easily."
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use `TreeMap` instead of `MultiTerms` in this case. `TreeMap` is more efficient than `MultiTerms` for this use case.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "This is the wrong MDC; see MDCLoggingContext which imports `org.slf4j.MDC`"
     },
     {
-      "prediction": "I'm not sure what you mean by \"only select historic details that were set during the process start\". Is this the same as \"only select historic details that have occurred after the given date (inclusive)\"?",
+      "prediction": "I'm not sure what you mean by \"only select historic details that were set during the process start\". I think you mean \"only select historic details that have occurred after the given date (inclusive)\".",
       "reference": "Maybe we can clarify a bit what that means."
     },
     {
-      "prediction": "I think this should be `tcs2.SetResult(task2.Result);` instead of `tcs2.SetResult(task2.Result); tcs;`",
+      "prediction": "I think this should be `tcs2.SetResult(task2.Result);` instead of `tcs2.SetResult(task2.Result); tcs2.SetResult(task2.Result); tcs2.SetResult(task2.Result); tcs2.SetResult(task2.Result); tcs2.SetResult(task2.Result); tcs2.SetResult(task2.Result); tcs2.SetResult(task2.Result); tcs2.SetResult(task2.Result); tcs2.SetResult(task2.Result); tcs2.SetResult(task2.Result); tcs2.SetResult(task2.Result); tcs2.SetResult(task2.Result); tcs2.SetResult(task2.Result); tcs2.SetResult(task2.Result); tcs2.SetResult(task2.Result); tcs2.SetResult(task2.Result); tcs2.SetResult(task2.Result); tcs2.SetResult(task2.Result); tcs2.SetResult(task2.Result); tcs2.SetResult(task2.Result); tcs2.SetResult(task2.Result); tcs2.SetResult(task2.Result); tcs2.SetResult(task2.Result); tcs2.SetResult(task2.Result); tcs2.SetResult(task2.Result); tcs2.SetResult(task2.Result); tcs2",
       "reference": "This entire method can be deleted; it isn't used and it isn't an override of Stream."
     },
     {
-      "prediction": "I'm not sure what you mean by \"use the Hadoop FileSystem\"",
+      "prediction": "I'm not sure what you mean by \"use the Hadoop FileSystem\". I think it's more accurate to say \"use the Hadoop FileSystem to store metadata and manifests\" or \"use the Hadoop FileSystem to store the metadata and manifests\".",
       "reference": "We avoid static method imports. Can you call `MetadataTableUtils.createMetadataTableInstance` instead?"
     },
     {
@@ -31363,11 +31363,11 @@
       "reference": "No need for this, as pylint already only turns things off for this function and it's needed for the entire function."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to get the `purchaseable` object from the `purchaseable` table, but I'm not sure what you're trying to do with the `purchaseable` object. I think you're trying to get the `purchaseable` object from the `purchaseable` table, but I'm not sure what you're trying to do with the `purchaseable` object. I think you're trying to get the `purchaseable` object from the `purchaseable` table, but I'm not sure what you're trying to do with the `purchaseable` object. I think you're trying to get the `purchaseable` object from the `purchaseable` table, but I'm not sure what you're trying to do with the `purchaseable` object. I think you're trying to get the `purchaseable` object from the `purchaseable` table, but I'm not sure what you're trying to do with the `purchaseable` object. I think you're trying to get the `purchaseable` object from the `purchaseable` table, but I'm not sure what you're trying to do with the `purchaseable` object. I think you're",
+      "prediction": "I'm not sure what you're trying to do here. I think you're trying to get the `purchaseable` object's `fulfilled_with_github?` and `includes_mentor?` and `subscription?` and `terms` methods, but you're not passing them to the `within_range` method.",
       "reference": "I'm actually surprised this is valid Ruby. I thought you'd need either `delegate(...)` or `delegate \\ ...`."
     },
     {
-      "prediction": "I'm not sure what you mean by \"Nullability doesn't match\" here. I think it's more accurate to say that `expectedValue` and `arrowVector.isNull(rowId)` are not equal, not that `expectedValue` is `null` and `arrowVector.isNull(rowId)` is `false`.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.",
       "reference": "Why change this?"
     },
     {
@@ -31379,23 +31379,23 @@
       "reference": "Do we need to drop the remaining items from the batch? Otherwise we might end up with a dead loop. Add @CodeBlanch for awareness."
     },
     {
-      "prediction": "I think this should be `if m.NumCommittedSectors > 0 {` instead of `if m.NumCommittedSectors > 0 {`",
+      "prediction": "I think this should be `if m.NumCommittedSectors > 0 { ... }` instead of `if m.NumCommittedSectors > 0 { return nil, err }`",
       "reference": "Because power is now added during `submitPoSt` this is needed for setting power in the genesis block. Again let me know if this bootstrapping solution is flawed."
     },
     {
-      "prediction": "I don't think this is a good idea. The `ReflectionMethod::getReturnType` and `ReflectionFunctionAbstract::getReturnType` methods should return the same type as `ReflectionMethod::getReturnType` and `ReflectionFunction::getReturnType` respectively.",
+      "prediction": "I don't think we need to add this to the `old` array.",
       "reference": "To be consistent, these should go at the top between `DateTimeZone::listIdentifiers` and `SQLite3::createFunction`."
     },
     {
-      "prediction": "I think this should be `@Override` instead of `@Deprecated`.",
+      "prediction": "I think this should be moved to the `Directory` interface.",
       "reference": "I think we should avoid changing any lucene classes for the moment - fileModified() can probably stay where it is?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"extendedBolusView.setVisibility(View.GONE);\". Is this supposed to be `extendedBolusView.setVisibility(View.GONE);` or `extendedBolusView.setVisibility(View.INVISIBLE);`?",
+      "prediction": "Shouldn't this be `extendedBolusView.setVisibility(View.GONE);` instead of `extendedBolusView.setVisibility(View.INVISIBLE);`?",
       "reference": "GONE breaks formating of \":\". or is it fixed below?"
     },
     {
-      "prediction": "I don't think we need to deprecate these methods.",
+      "prediction": "Should we deprecate all methods from ASTFormalParameter?",
       "reference": "What do you mean with this? Won't the deprecation be inherited?"
     },
     {
@@ -31403,27 +31403,27 @@
       "reference": "line between \" and \" should be <80 chars."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. The `rvm` variable is only used for the `rvm` command, and it's not clear what you're trying to do with it. It's also not clear what the `gemfile` variable is used for, and it's not clear what you're trying to do with it. I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. The `rvm` variable is only used for the `rvm` command, and it's not clear what you're trying to do with it. It's also not clear what the `gemfile` variable is used for, and it's not clear what you're trying to do with it. I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. The `rvm` variable is only used for the `rvm` command, and it's not clear what you're trying to do with it. It's also not clear what the `gemfile` variable is used for, and it's not clear what you're trying to do with it. I'm not sure",
+      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. The `rvm` variable is only used to set the `rvm` environment variable, and it's not used anywhere else in the script. If you want to use `rvm` in the script, you should use the `rvm` variable directly in the script, like this:\n```ruby\nrvm: 'default'\n```\nThis way, the `rvm` variable will be used in the script, and you won't need to use the `rvm` variable directly in the script.",
       "reference": "What will happen if neither `rvm` nor `ruby` is present in the .travis.yml?"
     },
     {
-      "prediction": "I think we can remove the `struct.pack` call here, as it's not needed.",
+      "prediction": "I think it's better to use `struct.pack(\"` instead of just `Long`? Always empty when the BASEFEE isn't relevant? If so the default is `Optional.empty()`"
     },
     {
@@ -31431,31 +31431,31 @@
       "reference": "Minor detail, but let's use the interpolated template string syntax instead."
     },
     {
-      "prediction": "I think we should remove the `ClockIds` field. It's not used in the spec.",
+      "prediction": "I don't think this is needed.",
       "reference": "this line is so long, split it to multi lines."
     },
     {
-      "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea to add this to the list of features that should be enabled by default.",
+      "prediction": "I'm not sure if this is the right place to add this, but I think it's a good idea.",
       "reference": "Looks like this might be one of those \"promoted features\" where you can enable it by _either_ enabling the extension _or_ enabling the feature bit. If that is the case, I think this needs to be: `(device_extensions.vk_ext_scalar_block_layout == kEnabledByCreateinfo) || (enabled_features.core12.scalarBlockLayout == VK_TRUE)`."
     },
     {
-      "prediction": "I think we can remove the `template struct ONEDAL_EXPORT integer_overflow_ops;` and `template struct ONEDAL_EXPORT integer_overflow_ops;` as they are not needed.",
+      "prediction": "I think we can remove the `template struct ONEDAL_EXPORT integer_overflow_ops;` line.",
       "reference": "Why should we define it for v1? This is preserved only for backward compatibility, all further modifications must be done in the latest vX"
     },
     {
-      "prediction": "I think we can remove the `length` method, as it's not needed anymore.",
+      "prediction": "I think we can remove this method, as it's not needed anymore.",
       "reference": "This is a definite improvement! Hardcoding nonzero is vastly better than hardcoding length. Even so, is there no way to determine the actual value of nonzero in a way that doesn't load the entire dataset?"
     },
     {
-      "prediction": "I think we can remove the `string.Concat` call here, as it's not needed.",
+      "prediction": "I think this should be `ConvertHttpMethodToOperationName(HttpMethod method)` instead of `ConvertMethodToOperationName(string method)`.",
       "reference": "do we have a way to avoid the string concats, if there is no username/password in the Uri? if (uri has UsernameInfo) { do what is done in this PR. } else { existing behavior. }"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to do this in the `cb_stackdriver_request` function as well.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to do this in the `cb_http_request` function.",
       "reference": "do not print the payload since it might be corrupted, you can get the data with _debug.http.response_payload configuration property"
     },
     {
-      "prediction": "I'm not sure what you mean by \"new app\" but I think it should be \"new copilot\".",
+      "prediction": "I'm not sure what you mean by \"app ls includes new app\". I think it should be \"app ls includes a new app\".",
       "reference": "maybe \"app init creates an copilot directory and a workspace file\"? since you validate for the file as well."
     },
     {
@@ -31475,7 +31475,7 @@
       "reference": "This entire clause should now be removed. It was only relevant if `accountID` couldn't be parsed from `clientID`, which is now no longer needed."
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `intersphinx_mapping` section of the `MANIFEST.in` file. I'm not sure if this is the right place to put this, but I think it should be in the `intersphinx_mapping` section of the `MANIFEST.in` file. I'm not sure if this is the right place to put this, but I think it should be in the `intersphinx_mapping` section of the `MANIFEST.in` file. I'm not sure if this is the right place to put this, but I think it should be in the `intersphinx_mapping` section of the `MANIFEST.in` file. I'm not sure if this is the right place to put this, but I think it should be in the `intersphinx_mapping` section of the `MANIFEST.in` file. I'm not sure if this is the right place to put this, but I think it should be in the `intersphinx_mapping` section of the `MANIFEST.in` file. I'm not sure if this is the right place to put this, but I think it should be in the `intersphinx_mapping` section of the `MANIFEST.in",
+      "prediction": "I'm not sure if this is a good idea, but I think we should use `intersphinx_mapping` instead of `intersphinx_mapping` in this case.",
       "reference": "FTR: Unlike commonly known practice, `latest` in Ansible docs corresponds to the stable version, not to the latest state of the main Git branch. Is this your intention? Just checking..."
     },
     {
@@ -31483,19 +31483,19 @@
       "reference": "Why do we have || CharInfo::UnknownCharSet here? I do not see it it in neighbouring statements. This is just for my understanding."
     },
     {
-      "prediction": "I don't think this is a good idea. It would be better to have a separate class for this. It would be better to have a separate class for this. It would be better to have a separate class for this. It would be better to have a separate class for this. It would be better to have a separate class for this. It would be better to have a separate class for this. It would be better to have a separate class for this. It would be better to have a separate class for this. It would be better to have a separate class for this. It would be better to have a separate class for this. It would be better to have a separate class for this. It would be better to have a separate class for this. It would be better to have a separate class for this. It would be better to have a separate class for this. It would be better to have a separate class for this. It would be better to have a separate class for this. It would be better to have a separate class for this. It would be better to have a separate class for this. It would be better to have a separate class for this. It would be better to have a separate class for this. It would be better to have",
+      "prediction": "I don't think this is a good idea. It would be better to have a separate class for this.",
       "reference": "isn't `HttpWebRequest` an expensive key value?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to add a new observer to an existing user. Is this what you're trying to do?",
+      "prediction": "I'm not sure what you're trying to do here, but it seems like you're trying to add a new observer to the client. I'm not sure what you're trying to do here, but it seems like you're trying to add a new observer to the client. I'm not sure what you're trying to do here, but it seems like you're trying to add a new observer to the client. I'm not sure what you're trying to do here, but it seems like you're trying to add a new observer to the client. I'm not sure what you're trying to do here, but it seems like you're trying to add a new observer to the client. I'm not sure what you're trying to do here, but it seems like you're trying to add a new observer to the client. I'm not sure what you're trying to do here, but it seems like you're trying to add a new observer to the client. I'm not sure what you're trying to do here, but it seems like you're trying to add a new observer to the client. I'm not sure what you're trying to do here, but it seems like you're trying to add a new observer to the client. I'm not sure",
       "reference": "couldn't we run this query whether there are observations or not?"
     },
     {
-      "prediction": "I think we can remove the `MockTarget.fs.get_all_data()` test.",
+      "prediction": "I'm not sure what you mean by \"AmbiguousClass\". Is it a class that has a `__name__` of `__main__`?",
       "reference": "This shouldn't be needed to change right?"
     },
     {
-      "prediction": "I don't think we need to add `serveStatic` to the `files` array.",
+      "prediction": "I don't think you need to add `serveStatic` to the `files` array.",
       "reference": "This seemed broken to me. Why would browserify only check the (previously `cdn`, now) `bundle` example? And even so, the path is incorrect here. Fixing this is unrelated so should not go into this PR I feel. But when we fix this in master, perhaps that solves the reload issues that you experienced @hedgerh?"
     },
     {
@@ -31507,7 +31507,7 @@
       "reference": "Definitely not required, but it would be better if you had a constexpr for `\"INPUT_DUMMY\"`"
     },
     {
-      "prediction": "I think this should be `if (!string.IsNullOrEmpty(archiveFile)) { this.DoAutoArchive(archiveFile, ev); }` instead of `if (!string.IsNullOrEmpty(archiveFile)) { archiveFile = this.GetArchiveFileName(fileName, ev, upcomingWriteSize); if (!string.IsNullOrEmpty(archiveFile)) { this.DoAutoArchive(archiveFile, ev); } }`",
+      "prediction": "I think this should be `if (!string.IsNullOrEmpty(archiveFile)) { this.DoAutoArchive(archiveFile, ev); }` instead of `if (!string.IsNullOrEmpty(archiveFile)) { this.DoAutoArchive(archiveFile, ev, upcomingWriteSize); }`",
       "reference": "It seems ok. Because already created a file name at line 1815 and already checked if it is null or empty at line 1816. If file name is null, then already this line will not executed."
     },
     {
@@ -31519,15 +31519,15 @@
       "reference": "util.Warning()? Easier to say."
     },
     {
-      "prediction": "I don't think we need this field. It's not used anywhere in the code.",
+      "prediction": "I don't think we need this field. It's not used anywhere in the code. I think we can remove it.",
       "reference": "these 2 no longer needed after refactor"
     },
     {
-      "prediction": "I'm not sure what this is for, but it looks like it's going to be used in the future, so I'm not sure if it's a good idea to keep it in the spec.",
+      "prediction": "I'm not sure what this is for, but it looks like it's going to be used in the future, so I'd like to make sure we're not going to break anything in the future.",
       "reference": "most spec options appear to be snake case - `fa_direct_raw_block`, let's stick to that convention"
     },
     {
-      "prediction": "I think this should be `require('selenium-webdriver/chrome')` instead of `require('selenium-webdriver/chrome/').`",
+      "prediction": "I think this should be `require('selenium-webdriver/chrome')` instead of `require('selenium-webdriver/chrome')`",
       "reference": "Looks like we can then drop this dependency."
     },
     {
@@ -31535,7 +31535,7 @@
       "reference": "3) Subscribe to the script change signal in `FlowMaster.__init__`. The event handler should call `self.masterq.put((\"script_change\", script))`. 4) Add a `handle_script_change` function, that once called, takes the script object and calls `script.reload()`."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this. Is it possible that you're trying to get the body of the email? If so, then you should be able to get it by calling `getBody()` on the `EmailMessage` object. If you're trying to get the subject of the email, then you should be able to get it by calling `getSubject()` on the `EmailMessage` object.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `EmailMessage` class, so that it can be used in other places as well.",
       "reference": "This method is for unit testing only, right? How about making it package private? This way the readers would know that this is not a public API outside this package and would reduce the search space."
     },
     {
@@ -31555,23 +31555,23 @@
       "reference": "Can we just have 2017 here @kmova if possible, as i seen in other projects as well( kubernetes etc..), they mentioned only the year when the file has been created."
     },
     {
-      "prediction": "I'm not sure if this is a good idea or not, but I think it's a good idea to use `std::vector pgm` instead of `std::vector pgm`.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to have a separate function for this.",
       "reference": "@Tony-LunarG I just realized that this differs from the previous behavior in that spirv-opt will run on the byte code if there are any \"group decorations.\" If this is a problem, I can add an additional constructor to keep the pre-existing behavior."
     },
     {
-      "prediction": "I think we can remove the `fromParquetPrimitive` call here.",
+      "prediction": "I think this should be `updateMin` and `updateMax` instead of `updateMin` and `updateMax`?",
       "reference": "Nit: continuation lines should be indented 4 spaces from the start of the statement."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to destroy the `sysfs_format_ptr` here.",
+      "prediction": "I think this should be `sysfs_region_destroy` instead of `sysfs_region_count`.",
       "reference": "Are these protected by any kind of lock?"
     },
     {
-      "prediction": "I'm not sure what you mean by `hierarchical_name`. Is it something related to the hierarchy of the firewall rule? If so, I'm not sure I understand what you're trying to do with it.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `__init__` method to set the `hierarchical_name` and `kind` fields. This way, we can make sure that the `hierarchical_name` and `kind` fields are always set, even if the `name` or `network` fields are not set.",
       "reference": "This should probably default to a string, as get_resource_ancestors is causing the tests to fail due to the rsplit on a None hierarchical_name."
     },
     {
-      "prediction": "I think this should be `IngressClass` instead of `IngressClassRef`.",
+      "prediction": "I think this should be `*string` instead of `*string`",
       "reference": "I prefer not to have markdown here, while it is nice for the site this is also shown for `kubectl explain` where this will look weird"
     },
     {
@@ -31579,7 +31579,7 @@
       "reference": "@durran Was this change intended to be included in this PR?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `null` for the second argument to `GetSmallMoleculeLibraryAttributes()`.",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think this is a good idea.",
       "reference": "Feels like this could have a default null value to remove the need for this explicit \"null\" use."
     },
     {
@@ -31587,55 +31587,55 @@
       "reference": "\"failed to create ...\""
     },
     {
-      "prediction": "I think it's better to use `fakeKubeClient.CoreV1().Pods(\"openebs\")` instead of `fakeKubeClient.CoreV1().Pods(\"openebs\").Create(podObjet)`.",
+      "prediction": "I think this should be `if err != nil { ... }` instead of `if err != nil { ... if err != nil { ... } ... }`",
       "reference": "No formatting directives, `glog.Error` will do just fine."
     },
     {
-      "prediction": "I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure what you're trying to say here. I'm not sure",
+      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
       "reference": "This should just be `.not_to raise_error` otherwise it potentially hides errors"
     },
     {
-      "prediction": "I think this should be `if err != nil` instead of `if err != nil && time.Since(startTime) < 30*time.Second`",
+      "prediction": "I think this should be `log.WithError(err).Error(\"Failed to connect to Typha. Retrying...\")` instead of `log.WithError(err).Debug(\"Retrying to start Typha\")`.",
       "reference": "Need an `if err == nil {break}` above this line so that we don't log/sleep if the retry succeeds."
     },
     {
-      "prediction": "I don't think this is a good idea. The `TABLE` and `TABLE_PARAMETER` should be in the same table.",
+      "prediction": "I don't think we need to change the table name here.",
       "reference": "Separate it to different methods :D Invoke method look's like old fashion portal class :D"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
+      "prediction": "I'm not sure what you're trying to do here, but I think it's a bad idea to use `height` in this way.",
       "reference": "Collapse/expand animation of filter is broken - not smooth."
     },
     {
-      "prediction": "I think this should be `self.elif '-f pom.xml', 'mvn install -B'` instead of `self.elif '-f pom.xml', 'mvn install -B'`",
+      "prediction": "I think this should be `install` instead of `install!`",
       "reference": "so during the `script` stage we run `mvn install`?"
     },
     {
-      "prediction": "I don't think this is necessary. We can just use the `ProtocolID` from the `Protocol` struct.",
+      "prediction": "I don't think we need to use `factory` here. We can just use `state` here.",
       "reference": "we may need to move CandidateNamespace to this protocol as it is only used here."
     },
     {
-      "prediction": "I think this should be `if (exFlow.getStatus() == Status.EXECUTION_STOPPED)` instead of `if (exFlow.getStatus() == Status.EXECUTION_STOPPED)`.",
+      "prediction": "I think it's better to use `if (exFlow.getStatus().equals(Status.EXECUTION_STOPPED))` instead of `if (exFlow.getStatus() == Status.EXECUTION_STOPPED)`.",
       "reference": "Just to confirm, this will take care of all the nodes in graph. right?"
     },
     {
-      "prediction": "I think this test should be moved to a separate unit test.",
+      "prediction": "I think we can remove the `parentProcessId` from the test.",
       "reference": "nit: remove this line. All \"arrange\" may be in one code block."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.",
+      "prediction": "I don't think we need to add `Xattr` to the `Node` struct. The `Xattr` struct is only used to store the `xattrname` and `xattrvalue` fields.",
       "reference": "This name is not a good fit, what about `ExtendedAttribute`? Or even just `Attribute`?"
     },
     {
-      "prediction": "I think this should be `if (strcmp(expval, val) == 0)` instead of `if (strcmp(expval, val) != 0)`.",
+      "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a separate function for this.",
       "reference": "lets keep our \"testing framework\" header only if possible. since there is an `assert(0)` in there, it is intended to halt on the first test failure."
     },
     {
-      "prediction": "`accountutil` and `account` should be in the same package.",
+      "prediction": "`accountutil` should be `accountutilutil`",
       "reference": "File is not `goimports`-ed (from `goimports`)"
     },
     {
-      "prediction": "I think this is a bit of a red herring here. We're not trying to list files in a partition, we're trying to list files in a table. I'm not sure why we'd want to do that.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way to do this. I'm not sure if this is the best way to do this, but I think it's a good way",
       "reference": "I was saving this white-space for my retirement :nit:"
     },
     {
@@ -31643,11 +31643,11 @@
       "reference": "What if you don't want to continue with the behavior, but you just want the deprecation to go away? Should we add `skip_after_action :discard_flash_if_xhr`?"
     },
     {
-      "prediction": "I think this should be `accountutil.AccountStateByHash160(ws, srcAddr)` instead of `accountutil.AccountState(ws, srcAddr)`.",
+      "prediction": "I think this should be `if err != nil { return errors.Wrapf(err, \"failed to get the confirmed nonce of address %s\", srcAddr) }`",
       "reference": "change `accountNonceMap` to map[address.Address][]uint64"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.",
+      "prediction": "I don't think this is necessary. We can just use `MainGapicProviderFactory.CLIENT_CONFIG` instead of `MainGapicProviderFactory.CLIENT_CONFIG_DOC` and `MainGapicProviderFactory.CLIENT_CONFIG_DOC`.",
       "reference": "The `CLIENT_CONFIG` is \"client_config\" with underscore, so we can't reuse it in the second arg."
     },
     {
@@ -31655,7 +31655,7 @@
       "reference": "Does this mean all admins get the default batch size (which is 20) no matter the value of `-sync-batch-size`? It seems the command line flag doesn't do anything then does it?"
     },
     {
-      "prediction": "I don't think this is a good idea. We should use `curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);` instead of `curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);`",
+      "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here. If you want to use `curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);` to set the `Content-Type` header, you can do that. If you want to use `curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);` to set the `Accept` header, you can do that. If you want to use `curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);` to set the `Accept-Charset` header, you can do that. If you want to use `curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);` to set the `Accept-Encoding` header, you can do that. If you want to use `curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);` to set the `Accept-Language` header, you can do that. If you want to use `curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);` to set the `Accept-Ranges` header, you can do that. If you want to use `curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);` to set the `Authorization` header, you can do that. If you want",
       "reference": "Set default value as empty array instead of null"
     },
     {
@@ -31663,43 +31663,43 @@
       "reference": "Would be good to UT this case"
     },
     {
-      "prediction": "I'm not sure what you mean by `directory != \"runtimes\"`. I think you meant to say `directory != \"runtimes\" && directory != \"stEWASMTests\" && directory != \"Specs\" && directory != \"stEWASMTests\" && directory != \"stEWASMTests\" && directory != \"stEWASMTests\" && directory != \"stEWASMTests\" && directory != \"stEWASMTests\" && directory != \"stEWASMTests\" && directory != \"stEWASMTests\" && directory != \"stEWASMTests\" && directory != \"stEWASMTests\" && directory != \"stEWASMTests\" && directory != \"stEWASMTests\" && directory != \"stEWASMTests\" && directory != \"stEWASMTests\" && directory != \"stEWASMTests\" && directory != \"stEWASMTests\" && directory != \"stEWASMTests\" && directory != \"stEWASMTests\" && directory != \"stEWASMTests\" && directory != \"stEWASMTests\" && directory != \"stEWASMTests\" && directory != \"stEWASMTests\" && directory != \"stEWASMTests\" && directory != \"stEWASMTests\" && directory",
+      "prediction": "I'm not sure what you mean by \"runtimes\" in this context. I think it should be \"StewamTests\" or \"StewamTests.Specs\" or \"StewamTests.runtimes\".",
       "reference": "this was updated after linking the latest ethereum/tests after a submodules recursive update"
     },
     {
-      "prediction": "I don't think this is a good idea. The `__data` object is not used anywhere in the component. It's only used to store the state of the component. If you want to store the state of the component, you should store it in the `state` property of the `Component` class.",
+      "prediction": "I don't think we need to do this. The `__data` object is only used to store the `props` and `context` in the `Component` class. We don't need to store it in the `Fragment` class.",
       "reference": "Todo: find a way to only do this in one spot, ideally with defaults for the stuff we use"
     },
     {
-      "prediction": "I'm not sure if this is the best place to put this, but I think it would be good to have a separate file for this.",
+      "prediction": "I don't think we need to add a `@Rule` for this test.",
       "reference": "Imports should not have blank lines. Sorry there isn't a checkstyle rule running for this yet, we still need to update the build for this one."
     },
     {
-      "prediction": "I think it's better to use `self.__get_eval_info` instead of `self.__num_dataset` in this case.",
+      "prediction": "I don't think this is a good idea. It's not clear to me what `feval` is supposed to do. If it's supposed to be a list of functions, then it should be a list of functions. If it's supposed to be a function, then it should be a function. If it's supposed to be a list of functions, then it should be a list of functions. If it's supposed to be a function, then it should be a function. If it's supposed to be a list of functions, then it should be a list of functions. If it's supposed to be a function, then it should be a function. If it's supposed to be a list of functions, then it should be a list of functions. If it's supposed to be a function, then it should be a function. If it's supposed to be a list of functions, then it should be a list of functions. If it's supposed to be a function, then it should be a function. If it's supposed to be a list of functions, then it should be a list of functions. If it's supposed to be a function, then it should be a function. If it's supposed to be a list of functions, then it should",
       "reference": "Please move this to L3115 to group the code logically - all code for `feval` in one place."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a new class that extends the `MainnetEvmRegistries` class, and then add a new method to it that takes a `GasCalculator` as a parameter. However, I'm not sure what you're trying to achieve with this. Could you please provide more context or explain what you're trying to achieve with this code?",
+      "prediction": "I think this should be `final OperationRegistry registry = new OperationRegistry();` instead of `final EVM frontier(final GasCalculator gasCalculator) { final OperationRegistry registry = new OperationRegistry();`",
       "reference": "This was done to wrap the operation so it could be spied upon during testing. Likely needs to be undone once an alternative test is discovered."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a default value of 1 for the batch size.",
+      "prediction": "I think this should be `time.Duration(cr.Expires * time.Millisecond)` instead of `time.Duration(cr.Expires) * time.Millisecond`",
       "reference": "I feel we need to impose a lower limit here maybe? What about a max and default for when none is set?"
     },
     {
-      "prediction": "I think we should be using `vfs.Stat` instead of `cds.cdsObjectToUpnpavObject` here.",
+      "prediction": "I think this should be `if err != nil { return nil, err; }` instead of `if err != nil { return nil, err; }`",
       "reference": "ineffectual assignment to `err` (from `ineffassign`)"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this. It seems like you're trying to create a `Replacer` that will overwrite other `Replacer` instances, but I'm not sure what you're trying to achieve with this. Could you please provide more context or a specific use case for this `Replacer`?",
+      "prediction": "I'm not sure what you mean by \"overwriting other replacements\" in this context. I'm not sure what you mean by \"overwriting other replacements\" in this context. I'm not sure what you mean by \"overwriting other replacements\" in this context. I'm not sure what you mean by \"overwriting other replacements\" in this context. I'm not sure what you mean by \"overwriting other replacements\" in this context. I'm not sure what you mean by \"overwriting other replacements\" in this context. I'm not sure what you mean by \"overwriting other replacements\" in this context. I'm not sure what you mean by \"overwriting other replacements\" in this context. I'm not sure what you mean by \"overwriting other replacements\" in this context. I'm not sure what you mean by \"overwriting other replacements\" in this context. I'm not sure what you mean by \"overwriting other replacements\" in this context. I'm not sure what you mean by \"overwriting other replacements\" in this context. I'm not sure what you mean by \"overwriting other replacements\" in this context. I'm not sure what you mean by \"overwriting other replacements\" in this context. I'm not sure",
       "reference": "Ahhh... this makes sense. Does using functions to defer evaluation of these values have anything to do with #916 (where the `Host: {host}` was 'cached' between different hostnames)? If not, could you help me understand what this change does?"
     },
     {
-      "prediction": "I think this should be `if (listenSocket_ >= 0 && listenSocket_ != THRIFT_INVALID_SOCKET)` instead of `if (0 != ::THRIFT_CLOSESOCKET(listenSocket_))`.",
+      "prediction": "I don't think we need to close the listen socket here.",
       "reference": "Perhaps the only test needed is to see if the socket is not an invalid socket? Is the >= 0 test necessary at this point?"
     },
     {
-      "prediction": "I think we should remove the `semantic_form_for current_user.subscription, url: subscription_path(current_user.subscription) do |form|` line.",
+      "prediction": "I think we should remove the `semantic_form_for current_user.subscription, url: subscription_path(current_user.subscription) do |form| %>` line.",
       "reference": "Could this line use `url: current_user.subscription`?"
     },
     {
@@ -31707,7 +31707,7 @@
       "reference": "I was seeing `Warning: preg_match(): Unknown modifier 'a' in /path/to/project/vendor/vimeo/psalm/src/Psalm/Context.php on line 480` here"
     },
     {
-      "prediction": "I'm not sure what you mean by \"parenting right\" here.",
+      "prediction": "I'm not sure what you mean by \"parenting right\" here. I think it means that the `BlockStmt` is a parent of the `MethodCallExpr` and the `MethodCallExpr` is a parent of the `Expression` in the `MethodCallExpr`.",
       "reference": "The changes in this file are not necessary."
     },
     {
@@ -31715,11 +31715,11 @@
       "reference": "run `make lint` to fix"
     },
     {
-      "prediction": "I'm not sure what you mean by \"unreliable_pipeline\". It's not a pipeline that can't be executed, it's a pipeline that can't be executed reliably.",
+      "prediction": "I think this should be `execute_pipeline` instead of `execute_pipeline_unreliable_pipeline`.",
       "reference": "we will need `assert result.success` instead. result will always be not null because it returns an execution result including several metadata - when the execution fails, it'd return an execution result whose `success` attribute is false."
     },
     {
-      "prediction": "I don't think it's necessary to have a `ZvolWorkers` field in the spec.",
+      "prediction": "I don't think we need this field. It's not used anywhere in the spec.",
       "reference": "Can we mention how can one determine the best value given an infrastructure? Does it default to any value?"
     },
     {
@@ -31727,15 +31727,15 @@
       "reference": "Leave this formatting the way it was please, that's the standard across all of October's files."
     },
     {
-      "prediction": "I don't think this is necessary. We can just use the `selinux` package directly.",
+      "prediction": "I don't think this is necessary.",
       "reference": "@runcom says there is no need to use `selinux` here. `selinux` \"github.com/opencontainers/selinux/go-selinux\" The code should work fine without it."
     },
     {
-      "prediction": "I'm not sure what you mean by `lifecycle_state` being `enum('ACTIVE','DELETE_REQUESTED','DELETE_IN_PROGRESS','DELETED')`. I think it should be `enum('ACTIVE','DELETE_REQUESTED','DELETED')`.",
+      "prediction": "I'm not sure what you mean by `lifecycle_state` being `enum('ACTIVE','DELETE_REQUESTED','DELETED') NOT NULL`",
       "reference": "nit: It might be worth defining these elsewhere as a python-type?"
     },
     {
-      "prediction": "I don't think this is needed anymore.",
+      "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to have it in the `Constants` class, since it's used in multiple places.",
       "reference": "prefix it with azkaban. Maybe azkaban.server.schedule.enable_quartz?"
     },
     {
@@ -31743,19 +31743,19 @@
       "reference": "It'd be nice if we also caught `Unknown variable $trusted / $server_facts / $settings::` here - while I highly doubt anyone is using them (and if they are they're surely misusing them) it'd be crazy-making to have a working plan suddenly start failing with no clue as to why."
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear what it's supposed to do. It's not clear what it's supposed to do. It's not clear what it's supposed to do. It's not clear what it's supposed to do. It's not clear what it's supposed to do. It's not clear what it's supposed to do. It's not clear what it's supposed to do. It's not clear what it's supposed to do. It's not clear what it's supposed to do. It's not clear what it's supposed to do. It's not clear what it's supposed to do. It's not clear what it's supposed to do. It's not clear what it's supposed to do. It's not clear what it's supposed to do. It's not clear what it's supposed to do. It's not clear what it's supposed to do. It's not clear what it's supposed to do. It's not clear what it's supposed to do. It's not clear what it's supposed to do. It's not clear what it's supposed to do. It's not clear what it's supposed to do. It's not clear what it's supposed to do. It's not clear",
+      "prediction": "I don't think this is a good idea. It's not clear what it's supposed to do.",
       "reference": "Probably need to understand/implement this one now."
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this, but I think it's a bit of a red herring. The `FileValidationStatus` class has a method `isNew()` that returns `true` if the validation status is `NEW`, and `false` otherwise. If you want to check if the validation status is `NEW`, you can do something like this:\n\n```java\nif (depValidationStatuses.get(d) == FileValidationStatus.NEW) {\n  // do something\n}\n```\n\nI'm not sure what you're trying to do with this, but I think it's a bit of a red herring. The `FileValidationStatus` class has a method `isNew()` that returns `true` if the validation status is `NEW`, and `false` otherwise. If you want to check if the validation status is `NEW`, you can do something like this:\n\n```java\nif (depValidationStatuses.get(d) == FileValidationStatus.NEW) {\n  // do something\n}\n```\n\nI'm not sure what you're trying to do with this, but I think it's a bit of a red herring. The `FileValidationStatus` class has a method `isNew()` that returns `true",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `remove` method of the `HashMap` to remove the key from the map.",
       "reference": "It will be better to add contains check for key in hashAndFileNameToDep instead of null check over here. All of these should be inside that contains if case."
     },
     {
-      "prediction": "I think this should be `host.exec` instead of `host.exec(Command.new(...))`?",
+      "prediction": "I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure if this is the right place to do this, but it seems like it would be a good place to do this. I'm not sure",
       "reference": "perhaps these magic numbers could go into a Defaults module somewhere? 8140 implies the default is for puppet server. i guess that's somewhat reasonable. but if we're trying to decouple beaker from puppet, maybe this should be 80?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in `dr_prepopulate_cache()`.",
+      "prediction": "I think this should be `GLOBAL_STAT(num_bbs)` instead of `GLOBAL_STAT(num_bbs_count)`.",
       "reference": "style violation: { on own line"
     },
     {
@@ -31763,7 +31763,7 @@
       "reference": "Could we accept caseless strings (e.g. `off`, `on`, `auto`) instead of numbers to indicate the mode? Of course, we should use an enum internally (as we already do)."
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this, but it looks like you're trying to get the tip set and state from the tip set, and then get the state root from the tip set. I'm not sure what you're trying to do with this, but it looks like you're trying to get the tip set and state from the tip set, and then get the state root from the tip set. I'm not sure what you're trying to do with this, but it looks like you're trying to get the tip set and state from the tip set, and then get the state root from the tip set. I'm not sure what you're trying to do with this, but it looks like you're trying to get the tip set and state from the tip set, and then get the state root from the tip set. I'm not sure what you're trying to do with this, but it looks like you're trying to get the tip set and state from the tip set, and then get the state root from the tip set. I'm not sure what you're trying to do with this, but it looks like you're trying to get the tip set and state from the tip set, and then get the state root from the tip",
+      "prediction": "I'm not sure what you mean by `GetTipSetAndState(tsKey types.SortedCidSet) (*chain.TipSetAndState, error)`. I think you meant `GetTipSet(tsKey types.SortedCidSet) (*types.TipSet, error)`.",
       "reference": "The sender doesn't use `GetTipSet`, so please remove it from this interface."
     },
     {
@@ -31771,23 +31771,23 @@
       "reference": "We can get rid of this import then."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.",
+      "prediction": "I'm not sure if this is the best place to put it, but I think we should move it to the `KubernetesContainerizedImpl` class, since it's used by the `KubernetesContainerized` class as well.",
       "reference": "These configurations are currently overwritten in the props we provide in our config files. They need to be overridden there as well after you make this change."
     },
     {
-      "prediction": "I think this should be `if *scratchBucketGcsPath == \"\"` instead of `if *scratchBucketGcsPath == \"\" && mgce.OnGCE()`",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `mgce.OnGCE()` to make sure we don't try to create a scratch bucket in a non-GCE environment.",
       "reference": "Why is error ignored here?"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think we should have a `PartitionFlagLegacy` for legacy boot partitions.",
+      "prediction": "I'm not sure if this is a good idea or not, but I think it would be better to have a `PartitionFlagLegacy` and `PartitionFlagBiosGrubLegacy` instead of `PartitionFlagLegacy` and `PartitionFlagBiosGrubLegacy`.",
       "reference": ">PartitionFlagBiosGrubLegacy PartitionFlag = \"bios-grub\" [](start = 1, length = 55) I presume this is to fix a breaking change...and it's too late to fix the breaking change (since it already escaped into the world?)"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to remove the time filters from the manifest files, but you're also trying to remove the time filters from the table. I'm not sure what you're trying to do here, but it looks like you're trying to remove the time filters from the manifest files, but you're also trying to remove the time filters from the table. I'm not sure what you're trying to do here, but it looks like you're trying to remove the time filters from the manifest files, but you're also trying to remove the time filters from the table. I'm not sure what you're trying to do here, but it looks like you're trying to remove the time filters from the manifest files, but you're also trying to remove the time filters from the table. I'm not sure what you're trying to do here, but it looks like you're trying to remove the time filters from the manifest files, but you're also trying to remove the time filters from the table. I'm not sure what you're trying to do here, but it looks like you're trying to remove the time filters from the manifest files, but you're also trying to remove the time filters from the",
+      "prediction": "I'm not sure what you're trying to do here, but I don't think it's a good idea to remove time filters from a scan summary.",
       "reference": "Is this explicitly ignoring the effect of deleted rows on partition metrics or is it just that you are short circuiting any delete files (as we can't use them anyways)"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. Is it possible that you're trying to set the `toolName` parameter to the value of the `toolName` key in the `osSpecific` dictionary? If that's the case, then you should be able to do something like this: `commandSetting = Tools[toolName].osSpecific[Os][\"toolName\"]`.",
+      "prediction": "I don't think this is necessary. The `toolName` parameter is already set in the `BuildParametersForCommand` method, so we don't need to check for it again.",
       "reference": "I would also check whether or not this \"defaultParameters\" is null or empty to allow for people to omit it from the config file."
     },
     {
@@ -31799,43 +31799,43 @@
       "reference": "Note: `editor` depends on legacy `BibEdit`"
     },
     {
-      "prediction": "I don't think this is a good idea.",
+      "prediction": "I don't think this is necessary. The `create_pause` method is already defined in the `InputDevice` class, so we don't need to create a new one.",
       "reference": "we should probably deprecate (and display a warning) the misspelled keyword arg here rather than removing it... and then add the new one. This changes a public API and will break any code that is currently using the misspelled version."
     },
     {
-      "prediction": "I think this is a duplicate of https://github.com/pandas-dev/pandas/pull/10648",
+      "prediction": "I think this should be `accuracy=1` instead of `accuracy=1.0`?",
       "reference": "I'm wondering if a positive test case is needed here? Then we might compare the result DataFrame with a pre-created Koalas DataFrame."
     },
     {
-      "prediction": "Shouldn't this be `isPresent()` instead of `isEmpty()`?",
+      "prediction": "Shouldn't this be `false` instead of `true`?",
       "reference": "I think it was reversed"
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear what you're trying to do here.",
+      "prediction": "I don't think this is needed. The `name` field is not used anywhere in the AST.",
       "reference": "The setter \"setName\" can be package-private as well"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be better to do this in the `ComputeUpdateValue` function.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be better to do it in the `ComputeUpdateValue` function.",
       "reference": "Not sure if this is intentional or snuck in through find/replace; while this is a correct style fix (and is welcome in another PR), it should not be done here so that the commit maintains a logical changeset."
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this test, but I don't think it's a good idea to allocate 1 GB of memory in 32-bit environments. It's not a good idea to allocate 1 GB of memory in 32-bit environments. It's not a good idea to allocate 1 GB of memory in 32-bit environments. It's not a good idea to allocate 1 GB of memory in 32-bit environments. It's not a good idea to allocate 1 GB of memory in 32-bit environments. It's not a good idea to allocate 1 GB of memory in 32-bit environments. It's not a good idea to allocate 1 GB of memory in 32-bit environments. It's not a good idea to allocate 1 GB of memory in 32-bit environments. It's not a good idea to allocate 1 GB of memory in 32-bit environments. It's not a good idea to allocate 1 GB of memory in 32-bit environments. It's not a good idea to allocate 1 GB of memory in 32-bit environments. It's not a good idea to allocate 1 GB of memory in 32-bit",
+      "prediction": "I'm not sure what you're trying to do with this, but I don't think it's a good idea to allocate 1 GB of memory in 32-bit environments.",
       "reference": "This makes me wonder if the TBufferTransport should have a size limit that is configurable, with a default of INT32_MAX, and then the test can make a smaller one like 4KB, and write 4KB and then one byte more, instead of using up 2GB of memory."
     },
     {
-      "prediction": "I'm not sure what you mean by \"isRequestStreaming\" and \"isResponseStreaming\"",
+      "prediction": "I don't think we need to do this.",
       "reference": "If you use an enum for the streaming type, you wouldn't need to add each boolean as a separate attribute."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a good idea to remove the `from sqlalchemy.exc` import DatabaseError line.",
+      "prediction": "I'm not sure what you're trying to achieve with this change, but I'm not sure if it's a good idea. It seems like you're trying to use `serialize_via_marshal` and `deserialize_via_marshal` in a way that doesn't make sense. I'm not sure what you're trying to achieve with this change. It seems like you're trying to use `serialize_via_marshal` and `deserialize_via_marshal` in a way that doesn't make sense. I'm not sure what you're trying to achieve with this change. It seems like you're trying to use `serialize_via_marshal` and `deserialize_via_marshal` in a way that doesn't make sense. I'm not sure what you're trying to achieve with this change. It seems like you're trying to use `serialize_via_marshal` and `deserialize_via_marshal` in a way that doesn't make sense. I'm not sure what you're trying to achieve with this change. It seems like you're trying to use `serialize_via_marshal` and `deserialize_via_marshal` in a way that doesn't make sense. I'm not sure what you're trying to achieve with this change. It seems like you're trying to use `serialize",
       "reference": "can you check if you can use `sqlalchemy.exc.IntegrityError` instead?"
     },
     {
-      "prediction": "I think it's better to use `std::unique_ptr` instead of `std::unique_ptr`.",
+      "prediction": "I don't think we need to lock the mutex in this function. It's only used in `JobExecutorFactory::createJobExecutor` and `JobExecutor* jobExec = je.get();`.",
       "reference": "Why we need to use recursive_mutex here?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.",
+      "prediction": "I don't think we need to use `testingACMEEmail` and `testingACMEPrivateKey` here. We can just use `testingACMEEmail` and `testingACMEPrivateKey` directly.",
       "reference": "am I correct these changes are related to: > I have removed a bunch of legacy functions for issuer generation ... if so, I can see why that's a valuable change but this is already a pretty huge PR and these changes to use `gen` here feel quite distant from the goal of this specific PR; they should maybe be in their own PR, to make everything easier to review? or have I missed how these changes are linked to this PR?"
     },
     {
@@ -31843,27 +31843,27 @@
       "reference": "I think that this is an unused import"
     },
     {
-      "prediction": "I think this should be `datasetVersionDTO.getReleaseTime().substring(0, 10)` instead of `datasetVersionDTO.getReleaseTime().substring(0, 10).substring(0, 10)`.",
+      "prediction": "I think this should be `datasetVersionDTO.getReleaseTime()` instead of `datasetVersionDTO.getReleaseTime().substring(0, 10)`.",
       "reference": "The string \"DVN_3_0\" appears in `if (!SOURCE_DVN_3_0.equals(xmlr.getAttributeValue(null, \"source\"))) {` in ImportDDIServiceBean. It's not an exact match so I don't *think* this will break dataset import from DDI but I thought I'd at least mention it."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to use the `CompareCommits` method to do this.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to use the `CompareCommits` method to get the commits from the comparison.",
       "reference": "Can you add docstring to this? Also, this might be a nit but I think `CompareCommits` or `CommitRange` might be a better name. What do you think?"
     },
     {
-      "prediction": "I think this should be `apis.IsInUpdate` instead of `apis.IsInUpdate(ctx)`.",
+      "prediction": "I think we should be using `apis.IsInUpdate(ctx)` here instead of `apis.GetBaseline(ctx).(*PullSubscription)`.",
       "reference": "were all these ones missed in the previous PR so you are adding them now? the sources v1 and some of this? Is that right? If so, can you update the PR title"
     },
     {
-      "prediction": "I think it's better to use `VERSION_CURRENT` instead of `VERSION_74` and `VERSION_77`.",
+      "prediction": "I think we should use `VERSION_CURRENT` instead of `VERSION_74` and `VERSION_77`.",
       "reference": "hmm should this be `VERSION_81` instead?"
     },
     {
-      "prediction": "I think this is a typo. `trieRebuildAccountChunkSize` should be `trieRebuildAccountChunkSize` instead of `trieRebuildAccountChunkSize`",
+      "prediction": "I'm not sure what this is for, but I think it should be `trieRebuildAccountChunkSize` instead of `trieRebuildAccountChunkSize`.",
       "reference": "What is the reason for increasing this?"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think we should add `addRequestId: true` to `file.tus` as well.",
+      "prediction": "I'm not sure if this is a good idea or not, but I think it would be better to use `status.tus_url` instead of `file.tus_url` in this case.",
       "reference": "is there any reason we are not adding this to companion as well?   There are no CORS concerns there, so adding probably shouldn't be a problem, no? **One question about the requestId;** Are the request Ids unique to each tus-js-client request, or are they unique to an upload instance instead?"
     },
     {
@@ -31871,7 +31871,7 @@
       "reference": "The formatting is a little off here."
     },
     {
-      "prediction": "I'm not sure if this is the right place to add this test, but I think it should be.",
+      "prediction": "I'm not sure what you mean by \"test that namespaces work with custom expressions.\"",
       "reference": "Perhaps we should import assertj for tests. These assertions are so much cleaner with assertj. Don't know whether hamcrest equivalent exist (maybe it does)."
     },
     {
@@ -31879,23 +31879,23 @@
       "reference": "You should use C++-type casts instead."
     },
     {
-      "prediction": "I think this should be `for _, req := range request.NewWorkflowNewEvents` instead of `for _, req := range request.NewWorkflowNewEvents`",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `UpdateWorkflowExecution` method.",
       "reference": "Looks like each AppendHistoryNodes is its own transaction - what happens if `len(request.NewWorkflowNewEvents) == 5` but we only succeed in writing 3 of them? Will the system be able to pick up from there later? I'm _guessing_ the answer is related to the `ON CONFLICT` and `INSERT IGNORE` changes below? What does Cassandra do?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to use the `telemetry.SVIDStore` field directly in the log message.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `telemetry.SVIDStore` field in the `logrus.Fields` struct.",
       "reference": "why are you replacing log here? it is defined above and contains EntryID and SPIFFEID"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to check the binary before starting the server. This way, if the binary is not available, the server won't be started.",
+      "prediction": "I don't think we need to check for errors here. We can just return an error if the binary is not found.",
       "reference": "Why not `checkOpenvpn` as in client command?"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to use mocha.reporter('base') instead of mocha.reporter('base')._reporter.",
+      "prediction": "I'm not sure if this is a good idea, but I think it's better to use `Base.call(this, runner);` instead of `Base.call(this, runner);` and `Base.call(this, runner);` instead of `Base.call(this, runner);` and `Base.call(this, runner);` instead of `Base.call(this, runner);` and `Base.call(this, runner);` instead of `Base.call(this, runner);` and `Base.call(this, runner);` instead of `Base.call(this, runner);` and `Base.call(this, runner);` instead of `Base.call(this, runner);` and `Base.call(this, runner);` instead of `Base.call(this, runner);` and `Base.call(this, runner);` instead of `Base.call(this, runner);` and `Base.call(this, runner);` instead of `Base.call(this, runner);` and `Base.call(this, runner);` instead of `Base.call(this, runner);` and `Base.call(this, runner);` instead of `Base.call(this, runner);` and `Base.call(this, runner);` instead of `Base.call(this, runner);` and `Base.call(this, runner);` instead",
       "reference": "> Note: Non-headless tests (that run on selenium-webdriver) need to wire up to mocha reporter to collect all the results and report them. (See `test-webdriver.js`). But for other tests this can be skipped."
     },
     {
-      "prediction": "I think this should be `b'CONNECT %s:%d HTTP/1.1\\r\\n' % (connect_to[0].encode(), connect_to[1])`",
+      "prediction": "I think it's better to use `b'CONNECT %s:%d HTTP/1.1\\r\\n' % (connect_to[0].encode(), connect_to[1])",
       "reference": "I think we should apply IDNA encoding for the host here."
     },
     {
@@ -31903,15 +31903,15 @@
       "reference": "No need to use `this->` here"
     },
     {
-      "prediction": "I think this should be `if completed.Status == corev1.ConditionTrue {` instead of `if completed.Status == corev1.ConditionTrue { // the cluster install is complete``",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a condition for the cluster install to be complete. This way, if the cluster install is not complete, we don't try to reconcile the cluster deployment.",
       "reference": "I can't quite tell, is there a reason why we're finding this condition again when it was done a few lines above? Or was this a mistaken paste?"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but I think we should remove the `package namespaceCache_mock.go` and `cache_mock.go` files.",
+      "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's worth the effort to mock the `cache` package.",
       "reference": "doh. My fault, sorry."
     },
     {
-      "prediction": "I think we can remove the `fieldID` and `fieldProviderID` fields from the `ServiceProposal` struct.",
+      "prediction": "I don't think this is necessary. The `fieldID` and `fieldProviderID` fields are already defined in the `market.ServiceProposal` struct, so we don't need to define them again in the `conditionIsProvider1` and `conditionIsStreaming` functions.",
       "reference": "Why do we returning `interface{}` here? Don't we have a predefined type for `ID`?"
     },
     {
@@ -31919,15 +31919,15 @@
       "reference": "`lodash` shouldn't be grouped under WordPress dependencies"
     },
     {
-      "prediction": "I'm not sure if this is a good place to put it, but I think it's a good idea to have it in a separate file, so that it can be used in other places as well. It's also a good idea to have it in the same package as the rest of the code, so that it can be used in other places as well.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate package for this, so that we don't pollute the `rclone` package.",
       "reference": "File is not `goimports`-ed (from `goimports`)"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `==` instead of `===` in this case.",
+      "prediction": "I'm not sure if this is the right way to do this, but I think it's a good idea to use `==` instead of `===` in this case.",
       "reference": "Not sure why you want to make the distinction between null and undefined? And also `null == undefined` anyway so I think you could simply have `!noteIds` here."
     },
     {
-      "prediction": "I think it's better to use `ApplicationHeaderPrefix` and `ContextHeaderPrefix` instead of `ApplicationHeaderPrefix` and `ContextHeaderPrefix`.",
+      "prediction": "I think we can remove `CallerHeader` as it's not used anywhere.",
       "reference": "Almost makes me wonder if this should default to Rpc-Context so everything defaults under Rpc-"
     },
     {
@@ -31935,55 +31935,55 @@
       "reference": "File is not `goimports`-ed (from `goimports`)"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to set a limit on the number of consumers that can be added to the stream. Is this what you're trying to do?",
+      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to set a limit on the number of consumers that can be added to the stream. Is this what you're trying to do here?",
       "reference": "would these require any account lock here?"
     },
     {
-      "prediction": "I think this should be `socket._GLOBAL_DEFAULT_TIMEOUT` instead of `socket._GLOBAL_DEFAULT_TIMEOUT or socket._GLOBAL_DEFAULT_TIMEOUT`",
+      "prediction": "I think this should be `cls._timeout` instead of `cls._timeout == socket._GLOBAL_DEFAULT_TIMEOUT`",
       "reference": "The else doesn't return anything?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don't think this is a good idea. It's not clear what you're trying to do here. I don",
+      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.",
       "reference": "if (typeof (opts.fee) !== 'undefined' || typeof (opts.feeSat) !=='undefined') {"
     },
     {
-      "prediction": "I'm not sure what you mean by \"empty permissions is invalid... causes a write invalid argument error upon saving to cgroups\"",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a `Device` struct that has a `Permissions` field.",
       "reference": "I not sure we need to change this method's logic. Isn't no perms and invalid config?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to set a timeout for a message, but I'm not sure what you're trying to do here. I think you're trying to set a timeout for a message, but I'm not sure what you're trying to do here. I think you're trying to set a timeout for a message, but I'm not sure what you're trying to do here. I think you're trying to set a timeout for a message, but I'm not sure what you're trying to do here. I think you're trying to set a timeout for a message, but I'm not sure what you're trying to do here. I think you're trying to set a timeout for a message, but I'm not sure what you're trying to do here. I think you're trying to set a timeout for a message, but I'm not sure what you're trying to do here. I think you're trying to set a timeout for a message, but I'm not sure what you're trying to do here. I think you're trying to set a timeout for a message, but I'm not sure what you're trying to do here. I think you're trying to set a timeout for",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `messageTimeout` of 1 minute, and a `maxBatchSize` of 50. This way, we don't have to worry about the `messageTimeout` and `maxBatchSize` changing over time.",
       "reference": "this is an abysmal amount of time. can you explain under which circumstances you should wait for a minute for a message?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think we need to do anything here.",
+      "prediction": "I'm not sure what you mean by `AddonsTemplateURL: addonsURL` and `AdditionalTags: tags.Merge(o.targetApp.Tags, o.resourceTags)`",
       "reference": "Can we add this code to `job_package.go` and `svc_package.go`?"
     },
     {
-      "prediction": "I'm not sure what the point of this is, but I think it should be `nodeIDKey` instead of `NextPlanNodeIDKey`.",
+      "prediction": "I think it's better to use `nodeIDKey` instead of `NextPlanNodeIDKey`.",
       "reference": "While you're here, can you change the casing on this so it is unexported? `nextPlanNodeIDKey` instead."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. Is there a specific reason you want to do this?",
+      "prediction": "I'm not sure what you're trying to do here. I don't think we need to change anything here.",
       "reference": "thanks for tidying all these up, as you can tell they've been used pretty arbitrarily in the past to just exclude things from bootstrap..."
     },
     {
-      "prediction": "I think this should be `elif` instead of `else`?",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `unbound_dimensions` in `Renderer` and `HolomapRenderer` so that we don't have to do this every time.",
       "reference": "Again, `no_duplicates=False` would be clearer here..."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to have a separate channel for the `closed` channel, so that we don't have to worry about closing the channel when we're done with it.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use a channel for the `closed` channel.",
       "reference": "shouldnt we stop these routines BEFORE the db closed?"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea. The `SessionId` class is not part of the `org.openqa.selenium.devtools.target.model` package. It's part of the `org.openqa.selenium.remote.http` package, which is not part of the `org.openqa.selenium.devtools.target.model` package.",
+      "prediction": "`org.openqa.selenium.devtools.target.model.SessionId` should be `org.openqa.selenium.remote.http.SessionId`",
       "reference": "It fills me with endless sadness that we can't use Selenium's own `SessionId` here."
     },
     {
-      "prediction": "I think we can remove the `findImage` method and just use the `createImage` method instead.",
+      "prediction": "I'm not sure if this is the best way to do this, but it seems to work for me.",
       "reference": "This will always need to be displayed to users."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but I think it's better to just use `price` instead of `Float(\"%0.02f\" % price)`.",
+      "prediction": "I don't think this is necessary. We can just use `object.total_price` instead.",
       "reference": "Maybe we make an `ORIGINS` constant on the Cart model instead?"
     },
     {
@@ -31991,15 +31991,15 @@
       "reference": "looks like this is not needed anymore with boltdb migration. lets confirm with @fenxiong"
     },
     {
-      "prediction": "I think we can remove the `false` from the `NewWorkingSet` call.",
+      "prediction": "I think it's better to use `require.NoError(t, err)` instead of `require.NoError(t, err)` in this case.",
       "reference": "shadow: declaration of \"err\" shadows declaration at line 408 (from `govet`)"
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here, but it looks like you're trying to move the element by a certain number of ticks in the x and y direction. Is this what you're trying to do? If so, what's the purpose of the `offsetX` and `offsetY` parameters?",
+      "prediction": "I'm not sure I understand what you're trying to do here. I think you're trying to move the element by a certain amount, but you don't know how far it is from the center of the element, so you're trying to move it by a fraction of the element's width or height.",
       "reference": "Again, the existing level is correct --- we're letting users know about something that might cause there tests to fail."
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to have a separate `converter` field in the `ProfileDecoder` struct. This way, we can have a separate `converter` field in the `ProfileDecoder` struct, and we can have a separate `converter` field in the `ProfileDecoder` struct, and we can have a separate `converter` field in the `ProfileDecoder` struct, and we can have a separate `converter` field in the `ProfileDecoder` struct, and we can have a separate `converter` field in the `ProfileDecoder` struct, and we can have a separate `converter` field in the `ProfileDecoder` struct, and we can have a separate `converter` field in the `ProfileDecoder` struct, and we can have a separate `converter` field in the `ProfileDecoder` struct, and we can have a separate `converter` field in the `ProfileDecoder` struct, and we can have a separate `converter` field in the `ProfileDecoder` struct, and we can have a separate `converter` field in the `ProfileDecoder` struct, and we can have a separate `converter` field in the `ProfileDecoder` struct, and we can",
+      "prediction": "I'm not sure if this is a good idea, but I think it would be better to have a separate `ProfileDecoder` struct that implements the `conversion.Converter` interface. This way, we can have a single `conversion.Converter` that can be used by both the `ProfileDecoder` and the `Dispatcher`.",
       "reference": "Required by the libcalico-go changes"
     },
     {
@@ -32007,23 +32007,23 @@
       "reference": "You want \"current_min_count\""
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to get a list of all the files in the media store, but I'm not sure what you're trying to do with the `selection` and `selectionArgs`.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think we should use `MediaStore.Files.FileColumns.BUCKET_DISPLAY_NAME` instead of `MediaStore.Files.FileColumns.PARENT`.",
       "reference": "Why changes in this file?"
     },
     {
-      "prediction": "I think it's a good idea to add a `@Deprecated` annotation to `PROTO_LINK_PATTERN` and `HEADLINE_PATTERN` so that people who don't want to use these patterns will know that they are deprecated.",
+      "prediction": "I think it's better to use `\\\\p{Alpha}` instead of `\\\\p{Alpha}+` in `CLOUD_LINK_PATTERN` and `PROTO_LINK_PATTERN`.",
       "reference": "This doesn't look right. I think what you want here is `\\\\[([^\\\\]]+)\\\\]\\\\[[A-Za-z_][A-Za-z_.0-9]*]*\\\\]`."
     },
     {
-      "prediction": "I think this should be `raise RetryLimitExceeded` instead of `raise RetryLimitExceeded, \"Retry limit exceeded for #{name}\"`",
+      "prediction": "I'm not sure if this is the right place to raise a retry limit exceeded error. I think it's better to raise an exception that is specific to the retry limit exceeded error.",
       "reference": "@AndrewRayCode thanks for contributing   Could you write/modify the specs to make sure that this description is working properly?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"ask the upper level to format the error\"",
+      "prediction": "I'm not sure what you mean by \"ask the upper level to format the error.\" I think you meant to say \"ask the lower level to format the error.\"",
       "reference": "I would have tested 304 only there."
     },
     {
-      "prediction": "I think this should be a test for `FilterLogger.LogTcs` instead of `FilterLogger.LogTcs.TimeoutAfter`.",
+      "prediction": "I think this should be `await loggerFactory.FilterLogger.LogTcs.Task.TimeoutAfter(TimeSpan.FromSeconds(10));` instead of `await loggerFactory.FilterLogger.LogTcs.Task.TimeoutAfter(TimeSpan.FromSeconds(10));`",
       "reference": "`TimeoutAfter` to be safe."
     },
     {
@@ -32031,15 +32031,15 @@
       "reference": "So the 32-bit tests on the new kernel hit this case? Won't they fail in debug build?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to add a `style` attribute to the `` tag, but I don't think that's what you're trying to do here.",
+      "prediction": "I don't think we need to change the `style type='text/css'>` to `style='text/css'` in this case.",
       "reference": "Is there a recommended quote style for attributes? I see single and double here, double further down."
     },
     {
-      "prediction": "I'm not sure I understand what you're trying to do here. What is the point of `CountNotification` and `StartNotification`? What is the point of `ExampleNotification`? What is the point of `CountNotification` and `ExampleNotification`? What is the point of `CountNotification` and `StartNotification`? What is the point of `CountNotification` and `ExampleNotification`? What is the point of `CountNotification` and `StartNotification`? What is the point of `CountNotification` and `ExampleNotification`? What is the point of `CountNotification` and `StartNotification`? What is the point of `CountNotification` and `ExampleNotification`? What is the point of `CountNotification` and `StartNotification`? What is the point of `CountNotification` and `ExampleNotification`? What is the point of `CountNotification` and `StartNotification`? What is the point of `CountNotification` and `ExampleNotification`? What is the point of `CountNotification` and `StartNotification`? What is the point of `CountNotification` and `ExampleNotification`? What is the point of `CountNotification` and `StartNotification`? What is the point of `Count",
+      "prediction": "I'm not sure I understand what you're trying to do here. Can you give an example of what you're trying to do?",
       "reference": "The description of `load_time` here is different from the description below..is that intentional?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"defaultCardImageIcon\"",
+      "prediction": "I think this should be `case 'Playlist'` instead of `case 'BoxSet'`.",
       "reference": "Actually it could also be a video playlist. But music is used more often."
     },
     {
@@ -32051,23 +32051,23 @@
       "reference": "You can simplify this by doing: return (EndTime - StartTime) * 60 / PointsAcrossPeak;"
     },
     {
-      "prediction": "I don't think this is necessary.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be better to do this in `ColorPickerWidget::paintEvent` instead.",
       "reference": "I think it's the time for bumping `REQUIRED_QT_VERSION` to the last LTS, 5.12. `QFontMetrics::horizontalAdvance()` doesn't exist in 5.10."
     },
     {
-      "prediction": "I'm not sure what you mean by \"return_type\" in this context. It's not clear to me what you're trying to do here.",
+      "prediction": "I'm not sure what you're trying to do here. I don't think we need to change the `boltdir_type` to `:cd11`.",
       "reference": "I already set up cd10 for \"inventory_version in google analytics. I've added cd11 for Boltdir Type now"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think you need to use `untaint` here.",
+      "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good idea to move it to the `Build` module.",
       "reference": "@henrikhodne We are lazily skipping `jruby-*` here (assuming that JRuby all of a sudden start using these version numbers)."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. It seems like you're trying to get the value of `y_start_val + ny * d_oy_val` and then use that to get the value of `y_start_val + ny * d_oy_val * 2`. I'm not sure what you're trying to do here. It seems like you're trying to get the value of `y_start_val + ny * d_oy_val` and then use that to get the value of `y_start_val + ny * d_oy_val * 2`. I'm not sure what you're trying to do here. It seems like you're trying to get the value of `y_start_val + ny * d_oy_val` and then use that to get the value of `y_start_val + ny * d_oy_val * 2`. I'm not sure what you're trying to do here. It seems like you're trying to get the value of `y_start_val + ny * d_oy_val` and then use that to get the value of `y_start_val + ny * d_oy_val * 2`. I'm not sure what you're trying to do here. It seems like you're trying to get",
+      "prediction": "I don't think we need to use `wxCoord` here. We can use `wxPoint` instead.",
       "reference": "How does this cope with values like `5.001`? Shouldn't that set precision to 0? Instead it is set to 2."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `query_string` parameter in the `get_listens` method. This way, we don't have to worry about the order of the parameters.",
+      "prediction": "I'm not sure if this is the right way to do it, but I think it's a good idea to remove the `time.sleep(10)` and `time.sleep(15)`.",
       "reference": "Rather than having a sleep here, we should check to see if the service we're waiting for is up yet, using something like dockerize. Not critical this second, but would be nice for later."
     },
     {
@@ -32079,7 +32079,7 @@
       "reference": "It seems like it's too big now: can we remove signal_frame_extra_size from line 537? That should only be needed when placing xstate separately. It seems like it isn't needed at all for pending? Also, if we have special heap align forward for us, we don't need this align here either."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to a separate function.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `Get-ContentAsJson` here.",
       "reference": "Just double checked the `-in` operator. It's PS3 only, so we might want to change `$_ -in $allowedArgs` to `$allowedArgs -contains $_`"
     },
     {
@@ -32091,15 +32091,15 @@
       "reference": "Definitely an improvement as long as the old tests pass (i.e backwards compatible)."
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but I think it's a bad idea to have a `LocalTableOperations` class that extends `TableOperations` and has a `LocalTableOperations` constructor that takes a `TemporaryFolder` as a parameter.",
+      "prediction": "I don't think this is needed.",
       "reference": "nit: non functional change"
     },
     {
-      "prediction": "I'm not sure what you mean by \"setting the burst size higher ensures all events will be recorded and submitted to the API\". I think you meant to say \"setting the burst size lower ensures all events will be recorded and submitted to the API\".",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to set the burst size to 10000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
       "reference": "The file is not required - if you're using an IAM instance profile, for example. I'm not sure we can error 100% of the time if it's missing. @randomvariable any suggestions?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to get the underlying type of the high value. I think you want to get the underlying type of the low value, right?",
+      "prediction": "I'm not sure if this is a good place to put this, but I think it would be good to move it to the `parseExpr` function.",
       "reference": "There is a very similar line `lowType = expr.Low.Type().(*types.Basic)` a few lines above this line. Can you change that in the same way?"
     },
     {
@@ -32111,19 +32111,19 @@
       "reference": "if I give a non-existent script, then I don't get an errors. I would have expected the `copy` method to raise, but maybe `net-sftp` silently exits?"
     },
     {
-      "prediction": "I don't think this is a good idea. We should use `replace` instead of `fillna`.",
+      "prediction": "I don't think this is a good idea.",
       "reference": "@itholic can you also update the parameters in the docs?"
     },
     {
-      "prediction": "I think this should be `SpliteratorProxy` instead of `SpliteratorProxyProxy`.",
+      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to remove the `SpliteratorProxy` from the `IntMap` class. The `SpliteratorProxy` is only used by the `IntMap` class, so it makes sense to remove it from the `IntMap` class as well. This way, the `IntMap` class can be used in other places without having to worry about the `SpliteratorProxy`.",
       "reference": "The super impl Spliterator.getComparator() throws an IllegalStateException by default. Is it really necessary to return null? If null is used somewhere it will throw a NPE, which is roughly the same as throwing an IllegalStateException. I'm just curious - I'm sure there is a reason!"
     },
     {
-      "prediction": "I think we can remove the `MetricsConfig.fromProperties(table.properties());` line.",
+      "prediction": "I think we can remove the `MetricsConfig.forTable(table)` call here.",
       "reference": "Do we need to do the same in Avro `WriteBuilder` too? I don't think we use that method right now but should make sense for consistency. We already handle that for Parquet."
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `--java_primitive_has_method` case.",
+      "prediction": "I don't think this is a good idea. It's not clear to me what the purpose of this option is.",
       "reference": "can you make all the `_` into `-` to be consistent with the other options?"
     },
     {
@@ -32135,11 +32135,11 @@
       "reference": "It isn't a very effective example if it requires access to the internals   I can't tell just looking at the diff why this is needed, can you provide a little context?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not sure I understand what you're trying to do here, but I'm not",
+      "prediction": "I'm not sure what you're trying to do here. I don't think this is a good idea.",
       "reference": "Why does this include `bolt/inventory`?"
     },
     {
-      "prediction": "I think we can remove the `filter` call here, as it's not necessary.",
+      "prediction": "I'm not sure if this is the best way to do this, but it seems to work.",
       "reference": "We called `t._1.equals(...)` where `t._1` potentially could be `null`."
     },
     {
@@ -32147,55 +32147,55 @@
       "reference": "I don't think we should include the `hasAttribute` test here. Even without aria-valuenow, it's still an aria range element. This check is going to make reuse of this function problematic. Better to move the attribute check part outside this function IMO."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `ErgonodeFixture` class.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `--group` option to specify the group that the fixture should be loaded into.",
       "reference": "Shouldn't it be optional?"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it's a bad idea to have the `SigningName` and `SigningRegion` fields in the `ClientInfo` struct. It's not clear to me what the `SigningName` and `SigningRegion` fields are supposed to be used for, and it's not clear to me what the `ServiceName` and `ServiceID` fields are supposed to be used for. I think it would be better to have the `SigningName` and `SigningRegion` fields in the `SigningInfo` struct, and the `ServiceName` and `ServiceID` fields in the `ClientInfo` struct.",
+      "prediction": "I don't think we need to change the `SigningRegion` here.",
       "reference": "would be helpful to make these a package level constant so they are accessible to the user. similar to Service Name. Not directly related note, v2 SDK ServiceName should be renamed to ServiceEndpointPrefix."
     },
     {
-      "prediction": "`include` is not a good option here. `file_exists` is a better option.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `realpath` function to get the real path of the file. This way, we don't have to worry about the path being relative to the current working directory.",
       "reference": "Duplicate call to the method. Better to put in a variable."
     },
     {
-      "prediction": "I'm not sure I fully understand what you're trying to do here, but it looks like you want to be able to shut down the prefetcher idempotently. Is that correct?",
+      "prediction": "I'm not sure what you mean by \"idempotently\" here. I think it's more accurate to say that the prefetcher will return io.EOF if it's called multiple times in a row.",
       "reference": "\"and returns that\" -- it looks like this method has no return value."
     },
     {
-      "prediction": "I think this should be `assert flip_direction in ['horizontal', 'vertical', 'diagonal']` instead of `assert flip_direction in ('horizontal', 'vertical', 'diagonal')`",
+      "prediction": "I think this should be `assert flip_direction in ('horizontal', 'vertical', 'diagonal')` instead of `assert flip_direction in ('horizontal', 'vertical')`",
       "reference": "Modifications are also needed for PolygonMask."
     },
     {
-      "prediction": "I don't think this is necessary. The `KestrelTransport` class is already defined in the `Microsoft.AspNetCore.Server.Kestrel.Core` namespace, so we don't need to create a new one.",
+      "prediction": "I don't think this is needed. The `KestrelTransport` class is already defined in the `Microsoft.AspNetCore.Server.Kestrel.Core` package.",
       "reference": "Does this really make a difference?"
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I'm not sure if we want to do this in a separate test case, or if we want to do this in the same test case. If we want to do this in the same test case, I think it would be a good idea to have a separate test case for this. If we want to do this in a separate test case, I think it would be a good idea to have a separate test case for this. If we want to do this in a separate test case, I think it would be a good idea to have a separate test case for this. If we want to do this in a separate test case, I think it would be a good idea to have a separate test case for this. If we want to do this in a separate test case, I think it would be a good idea to have a separate test case for this. If we want to do this in a separate test case, I think it would be a good idea to have a separate test case for this. If we want to do this in a separate test case, I think it would be a good idea to have a separate test case for this. If we want to do this in a separate test case,",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a separate validator for nested documents.",
       "reference": "Added a validator for _root_, which is now added automatically since the schema used here declares _root_."
     },
     {
-      "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good place to put this in the `RewriteDataFiles` class.",
+      "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good place to put it in the `RewriteDataFiles` class.",
       "reference": "The other properties are `file-open-cost`, not `open-file-cost`."
     },
     {
-      "prediction": "I'm not sure what you mean by \"need this to pass through ccache for xdrpp, libsodium\". I don't think it's necessary to pass through ccache for xdrpp, libsodium.",
+      "prediction": "I'm not sure why this is needed, but I think we should remove it.",
       "reference": "confused by this: what we need here is not libunwind but libunwind-dev right? Why skipping detection?"
     },
     {
-      "prediction": "I think this should be `foreach (var property in properties.Where(p => p.GetSetMethod() != null && !p.GetSetMethod.IsPrivate))`",
+      "prediction": "I don't think you need to do this. You can just use `typeof(JsonSerializer).GetTypeInfo().DeclaredProperties.Where(p => p.SetMethod != null && !p.SetMethod.IsPrivate)`.",
       "reference": "just in case helps, it this related with this PR?"
     },
     {
-      "prediction": "I think we can remove the `data[\"server_conn\"][\"source_address\"]` and `data[\"server_conn\"][\"ip_address\"]` from the `convert_100_200` function. The `data[\"server_conn\"][\"address\"]` is the same as `data[\"server_conn\"][\"source_address\"]` and `data[\"server_conn\"][\"ip_address\"]` is the same as `data[\"server_conn\"][\"address\"]`.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way to do it. I'm not sure if this is the best way to do this, but I think it's a good way",
       "reference": "This is incomplete I think (at least source_address and ip_address are missing)"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have the `handleFastSyncResult` method in the `DefaultSynchronizer` class. This way, we don't need to create a new instance of `DefaultSynchronizer` every time we call `startFullSync()`.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `handleFastSyncResult` method in the `DefaultSynchronizer` class. This way, we don't need to call `start()` on the `fastSyncDownloader` in the `handleFastSyncResult` method, and we don't need to call `start()` on the `blockPropagationManager` in the `handleFastSyncResult` method. This way, the `handleFastSyncResult` method can be called from the `DefaultSynchronizer` class, and the `blockPropagationManager` can be called from the `DefaultSynchronizer` class.",
       "reference": "We have a `stop` method here, we should probably be calling that instead of just exiting. There could be important resources to close or cleanup nicely now or in the future."
     },
     {
-      "prediction": "I think we should remove the `Omit these since we don't want to perform parameter validation` line.",
+      "prediction": "I think we should remove the `Omit` since we don't want to perform parameter validation.",
       "reference": "fixes ArgNullEx when using both `x-ms-parameter-grouping` and media type `application/xml` in the same operation (issue #2236)"
     },
     {
@@ -32203,7 +32203,7 @@
       "reference": "`NotFound` is a generic error code derived from the HTTP response message's status code, and can be returned for any S3 operation that responds with a 404 status code and no other error code present. Due to this the constant `ErrCodeBucketNotFound`. In addition, these constants are generated based on the API model defined by Amazon S3, modifications to the file directly will be lost during regeneration of the API. With that said, we are looking at ways to work with the Amazon S3 team to better represent this error in a way that is more easily consumed."
     },
     {
-      "prediction": "I think we should be able to use `generic_install_dmg` instead of `generic_install_msi` in this case.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way",
       "reference": "@johnduarte I was curious about the case when the operating system was neither `osx` or `win`; in this case, the test will indeed pass, but nothing will have actually really been tested. Should this have a `skip_test` condition at the top?"
     },
     {
@@ -32211,11 +32211,11 @@
       "reference": "I think this example was included by accident? It doesn't seem to belong in this PR (but a separate PR with this would be nice!)."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to create a new `RestRequest` with a `null` `httpEntity` and a `null` `requestEntity`. Is this what you're trying to do? If so, please provide more context so that I can better understand what you're trying to achieve.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check to see if the requestEntity is null, and if it is, then set the requestEntity to null.",
       "reference": "Just fixing a bunch of outdated java docs in this file"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the nonces for a given address. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the nonces for a given address. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the nonces for a given address. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the nonces for a given address. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the nonces for a given address. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the nonces for a given address. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the nonces for a given address. I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the nonces for a given address. I'm not sure what you're trying to achieve with this, but it looks",
+      "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to get the nonces for a given address, but you're not actually using the nonces in any way. If you want to get the nonces for a given address, you'll need to use the `GetNonces` method on the `AddressNonces` class, which will return a `Dictionary` that you can then use to get the nonces for a given address.",
       "reference": "I think it may be safer not to touch Concurrent to normal."
     },
     {
@@ -32223,7 +32223,7 @@
       "reference": "is this for everything, or just legacy?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a `changeStream.isClosed` property to the `ChangeStream` class, so that we can check if the stream is closed or not.",
       "reference": "I think this should be a `MongoError` right?"
     },
     {
@@ -32231,27 +32231,27 @@
       "reference": "This is currently a db.tar.gz with just one .sql file in it. It might be worth another test (or maybe I'll find one) that has more than one sql file in it."
     },
     {
-      "prediction": "I'm not sure what you mean by \"allow-all-egress-normal\". Is this the same as \"allow-all-egress\"?",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a test for this.",
       "reference": "Why these changes to existing tests?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good place to do this.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place to do this. I'm not sure if this is the right place to do this, but I think it's a good place",
       "reference": "It should be `IsNullOrWhitespace` I believe, since we're going to trim the value afterwards (and I just realized the other configuration keys have the same issue)"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think this is the right place to do this.",
+      "prediction": "I think this should be `available_features = target.features + additional_features` instead of `available_features = target.features + provided_features`",
       "reference": "This is just for consistency + searchability with the transports"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to create a fake server that can be used for testing purposes, but I'm not sure what you're trying to do here. I think you're trying to create a fake server that can be used for testing purposes, but I'm not sure what you're trying to do here. I think you're trying to create a fake server that can be used for testing purposes, but I'm not sure what you're trying to do here. I think you're trying to create a fake server that can be used for testing purposes, but I'm not sure what you're trying to do here. I think you're trying to create a fake server that can be used for testing purposes, but I'm not sure what you're trying to do here. I think you're trying to create a fake server that can be used for testing purposes, but I'm not sure what you're trying to do here. I think you're trying to create a fake server that can be used for testing purposes, but I'm not sure what you're trying to do here. I think you're trying to create a fake server that can be used for testing purposes, but I'm not sure what you're trying",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "please run gofmt."
     },
     {
-      "prediction": "I don't think we need to change the package name here.",
+      "prediction": "I don't think we need to change anything here.",
       "reference": "thats kind of a bummer, why do we have to give it full access? if it is just for the private interfaces i'd personally rather have those interfaces pollute the public exported symbols than open the tests up like this."
     },
     {
-      "prediction": "I think we can remove the `if s.apps[appID] == nil` check.",
+      "prediction": "I don't think we need to do this.",
       "reference": "Because this is an unexpected situation so can you add a log here to help us figure out what resource is causing this problem?"
     },
     {
@@ -32263,7 +32263,7 @@
       "reference": "Actually, I do have one question: You mention that each warning is for a different range. Should we add the rowcounts instead of using the max?"
     },
     {
-      "prediction": "I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a `GenesisStateCreator` interface that implements the `ReadState` and `ForceRegister` methods. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a `GenesisStateCreator` interface that implements the `ReadState` and `ForceRegister` methods. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a `GenesisStateCreator` interface that implements the `ReadState` and `ForceRegister` methods. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a `GenesisStateCreator` interface that implements the `ReadState` and `ForceRegister` methods. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a `GenesisStateCreator` interface that implements the `ReadState` and `ForceRegister` methods. I'm not sure what you're trying to achieve with this, but it looks like you're trying to create a `GenesisStateCreator` interface that implements the `ReadState` and `ForceRegister`",
+      "prediction": "I'm not sure what you're trying to achieve with this name, but I think it's better to use a more descriptive name. For example, you could call it `GenesisStateCreator` or `GenesisStateFactory`.",
       "reference": "it is confusing to return ID as Name"
     },
     {
@@ -32271,7 +32271,7 @@
       "reference": "body is being used here for the first time without every being populated. This will error. To run tests do `./go clean test_py` and that will run the Firefox tests"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to set the `trusted_proxies` in the `Request` class.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `Request::setTrustedProxies` instead of `Request::setTrustedProxies(['127.0.0.1'], Request::HEADER_X_FORWARDED_ALL)`.",
       "reference": "commit mesasge: I would append \"...Kernel::loadClassCache() method call\""
     },
     {
@@ -32279,23 +32279,23 @@
       "reference": "Keys.COMMAND seems to be an alias to Keys.META. That isn't mentioned?"
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. Is it that you want to make sure that the log4j.properties file is in the same directory as the test class? Or is it that you want to make sure that the log4j.properties file is in the same directory as the test class? Or is it that you want to make sure that the log4j.properties file is in the same directory as the test class? Or is it that you want to make sure that the log4j.properties file is in the same directory as the test class? Or is it that you want to make sure that the log4j.properties file is in the same directory as the test class? Or is it that you want to make sure that the log4j.properties file is in the same directory as the test class? Or is it that you want to make sure that the log4j.properties file is in the same directory as the test class? Or is it that you want to make sure that the log4j.properties file is in the same directory as the test class? Or is it that you want to make sure that the log4j.properties file is in the same directory as the test class",
+      "prediction": "I don't think this is necessary. We can just use the `org.apache.log4j.Logger` from the `org.apache.log4j` package.",
       "reference": "You can move this import down to before line 8 (import org.junit.Test;)."
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think we should be able to use the `resource_data` field to get the `scanner_index_id` and `inventory_index_id` as well.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use the `scanner_index_id` and `inventory_index_id` as the `resource_id` and `resource_type` respectively. This way, we can get rid of the `resource_id` and `resource_type` from the `violation` object.",
       "reference": "It's okay to add the `scanner_index_id` here. But we still should keep the `inventory_index_id` reference because it will help the user to know right away, which inventory the violation is coming from, without having to do another lookup."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `beforeClickOn` and `afterClickOn` methods, so that we don't have to do this in the `beforeClickOn` and `afterClickOn` methods.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move it to the `beforeClickOn` method.",
       "reference": "this shouldn't be beforeClickOn, but rather beforeSubmit? and added to WebDriverEventListener. Since submit does not synthesize the 'click' events, this isn't accurate."
     },
     {
-      "prediction": "I don't think we need to use `unless current_user_has_active_subscription?` in this case.",
+      "prediction": "I don't think we need to use `unless` here. We can just use `if current_user_has_active_subscription?` instead.",
       "reference": "Should this be I18n'd?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. The `struct` method returns a `List`, but you're passing it a `List`, which is not what you want.",
+      "prediction": "I'm not sure if this is a good place to put this, but I think it would be good to have a separate method for this. It's not clear to me that this is the right place to do this.",
       "reference": "We don't typically use `ImmutableList` to avoid leaking it in methods that are accidentally public or purposely part of the API. I'm +1 for returning `ImmutableList.copyOf(errors)` below, but I don't think we should guarantee the list will be an `ImmutableList`."
     },
     {
@@ -32303,31 +32303,31 @@
       "reference": "@greglandrum Is this test sufficient?"
     },
     {
-      "prediction": "I don't think this is necessary. We can just use `ENV['GITHUB_TOKEN']` instead.",
+      "prediction": "I don't think this is necessary. We can just use `ENV['GITHUB_USER']` and `ENV['GITHUB_PASSWORD']`.",
       "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping."
     },
     {
-      "prediction": "I think this should be `add_column :subscriptions, :plan_type, :string, null: false`",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate migration for this. I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate migration for this. I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate migration for this. I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate migration for this. I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate migration for this. I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate migration for this. I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate migration for this. I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate migration for this. I'm not sure if this is the right place to do this, but I",
       "reference": "I think Rails complains about the `null: false` part if we ever decide to roll this migration back. Might need to split this up into separate `up/down` methods to handle that."
     },
     {
-      "prediction": "I think it's better to use `seelog.Debug` instead of `seelog.Debugf` in this case.",
+      "prediction": "I think it's better to use `seelog.Debugf(\"Managed task [%s]: done transitioning all containers\", mtask.Arn)` instead of `seelog.Debugf(\"Managed task [%s]: wait for container transition done\", mtask.Arn)`.",
       "reference": "I don't think we need this line. You're logging in `waitForContainerTransition()` anyway"
     },
     {
-      "prediction": "I don't think it's necessary to add `accepted_if` in this case.",
+      "prediction": "I don't think it's necessary to add `:other` here. `:other` is already defined in the `accepted_if` message.",
       "reference": "Shouldn't the `:attribute` placeholder appear?"
     },
     {
-      "prediction": "I think we can remove the `this` from `eval(StructLike arg)` since it's not used anywhere.",
+      "prediction": "I think we should remove the `struct` parameter from the `eval` method.",
       "reference": "Could you update this to `structLike` instead of `arg`?"
     },
     {
-      "prediction": "I think this should be `heapStart` and `heapEnd` instead of `heapSize` and `heapEnd`?",
+      "prediction": "I think this should be `heapStart` and `heapEnd` instead of `heapSize` and `heapStart`/`heapEnd`.",
       "reference": "I only now spot this `freebsd,!baremetal` in the code, which doesn't make a lot of sense. The fact that there is `linux,!baremetal` is because baremetal targets pretend to be linux/arm to get the standard library to compile. Such a `!baremetal` exclusion is not necessary for FreeBSD. But this is not something that needs fixing in this PR."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to close the file after we're done with it. I'm not sure if this is the right place to do this, but I think it's a good idea to close the file after we're done with it. I'm not sure if this is the right place to do this, but I think it's a good idea to close the file after we're done with it. I'm not sure if this is the right place to do this, but I think it's a good idea to close the file after we're done with it. I'm not sure if this is the right place to do this, but I think it's a good idea to close the file after we're done with it. I'm not sure if this is the right place to do this, but I think it's a good idea to close the file after we're done with it. I'm not sure if this is the right place to do this, but I think it's a good idea to close the file after we're done with it. I'm not sure if this is the right place to do this, but I think it's a good idea to close the",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `ostree-repo.c` file, since it's not in the `ostree-repo.h` header file.",
       "reference": "Ugh, we were using cwd? =("
     },
     {
@@ -32335,15 +32335,15 @@
       "reference": "This can probably be removed?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this to the `onResult_` callback.",
+      "prediction": "I don't think we need to do this.",
       "reference": "put this sentence in `if (onResult_) { }`"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way to do this. I'm not sure if this is the best way to do this, but I think it's the best way",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to update the `forseti_server_conf` file with the latest `forseti_conf_server.yaml` from GCS.",
       "reference": "Will this always be started up as default? Is there any impact to the VM in terms of load and memory usage?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"qualifiers that are defined AFTER a parameter set will apply only the the parameter set that precedes them.\"",
+      "prediction": "I'm not sure what you mean by \"qualifiers that are defined AFTER a parameter set will apply only the the parameter set that preceeds them.\"",
       "reference": "Thanks for fixing the typo's but given that this is a fork of the other commandline.cs file they will still exist there :( Part of the reason forks suck."
     },
     {
@@ -32351,15 +32351,15 @@
       "reference": "This doesn't seem related to docs? :)"
     },
     {
-      "prediction": "Shouldn't this be `private static boolean notificationDuringQuietTimeEnabled = true;` instead of `private static boolean notificationDuringQuietTimeDisabled = true;`?",
+      "prediction": "I don't think we need to disable the notification during quiet time. It's already disabled by default.",
       "reference": "Having a negative in the variable/method name makes the code harder to read. Also, you inverted the logic but didn't invert the default value. I suggest sticking to the original name."
     },
     {
-      "prediction": "I'm not sure if this is the best place to put this, but I think it would be a good place to put this in the  namespace, since it's not part of the  namespace.",
+      "prediction": "I think this should be `ForceTraceWriteLine` instead of `RawWrite`.",
       "reference": "Think you need to keep `RawWrite` around as obsolete until NLog6 (Property that just assigns `ForceTraceWriteLine`)"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure what you're trying to do here. I'm not sure",
+      "prediction": "I think this should be `set_cache_line_size_using_ctr_el0()` instead of `set_cache_line_size_using_ctr_el0(/* dcache_line_size= */ &cache_line_size, /* icache_line_size= */ NULL);`",
       "reference": "I would expect this to be named *get* not *set*: it's a query; it's not setting some persistent state."
     },
     {
@@ -32371,11 +32371,11 @@
       "reference": "Do we want to add the other write options in this PR or keep the refactor separate?"
     },
     {
-      "prediction": "I'm not sure what you mean by \"refresh_token\" in this context. I think you meant \"refresh_access_token\"",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to have a `refresh_token` field in the `User` model.",
       "reference": "either make this a config or a constant we can define at the top. Burying this in the code is no good."
     },
     {
-      "prediction": "I'm not sure what you're trying to do with `custom_recall` and `custom_precision`, but I don't think it's a good idea to have them in the `sklearn.metrics` module.",
+      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. Is it that you want to create a function that takes a list of predictions and a list of true labels and returns a list of metrics? If so, why not just use `sklearn.metrics.recall_score` and `sklearn.metrics.precision_score` directly?",
       "reference": "Same about new metrics. Can we avoid adding them?"
     },
     {
@@ -32391,31 +32391,31 @@
       "reference": "A C# newbie question here: would it make sense to declare Id as an abstract property so any subclass Must have its own Id?"
     },
     {
-      "prediction": "I don't think we need to return nil here.",
+      "prediction": "I don't think we need to return an error here. We can just return a map[string]int here.",
       "reference": "just looks like you should return an **empty map** with nil error"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `log.NewSyncWriter(os.Stdout)` instead of `log.NewWriter(os.Stdout)`.",
+      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good idea to use `log.NewSyncWriter(os.Stdout)` instead of `log.NewWriter(os.Stdout)`. This is because `log.NewWriter(os.Stdout)` is not thread-safe, and `log.NewSyncWriter(os.Stdout)` is thread-safe.",
       "reference": "could you also update the starting log at L146?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to add a check for `dbusError.Name` in the `isDbusClosed` function. This way, we don't have to check for `dbusError.Name` in the `isUnitExists` function, and we don't have to check for `dbusError.Name` in the `isDbusClosed` function.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a check in the `startUnit` function to make sure that the `dbusConnection` is not `nil`.",
       "reference": "Also this probably should be `error.As()` or something like it."
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's better to have a separate `getCanvasUrl` command than to have a `GET_CANVAS_URL` command.",
+      "prediction": "I'm not sure if this is the right place to add this command, but I think it's a good idea to add it to the list of available commands.",
       "reference": "This is Safari specific and should be defined somewhere in the `safaridriver` namespace"
     },
     {
-      "prediction": "I'm not sure what you mean by \"conflict\" here. It's not a conflict with the ostree-prepare-root file, it's a conflict with the ostree-mount-deployment-var file. The ostree-mount-deployment-var file is used by the ostree-prepare-root script, and the ostree-prepare-root script uses the ostree-mount-deployment-var file.",
+      "prediction": "I'm not sure what you mean by \"conflict\" here. I think it's more accurate to say that this program is trying to use the ostree-mount-deployment-var file, but the ostree-prepare-root script is trying to use the ostree-prepare-root file.",
       "reference": "Let's maybe be nice and `unlinkat()` here in the interest of having `/run` be less littered. Or in addition/alternatively, make the file `/run/ostree/initramfs-mount-var` since we already made `/run/ostree/` for the deployment staging bits."
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I don't think you need to include ``.",
+      "prediction": "I'm not sure what you're trying to achieve with this change, but I think it would be better to use `boost::format` instead of `std::format` in this case.",
       "reference": "Not sure if this doesn't require explicitly adding this library to cmake."
     },
     {
-      "prediction": "I don't think this is a good idea.",
+      "prediction": "I don't think this is necessary. The `create_pause` method is already defined in the `InputDevice` class, so we don't need to create a new one.",
       "reference": "we should probably deprecate (and display a warning) the misspelled keyword arg here rather than removing it... and then add the new one. This changes a public API and will break any code that is currently using the misspelled version."
     },
     {
@@ -32423,7 +32423,7 @@
       "reference": "seems reasonable to also want to include the 'to' location?"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here, but it looks like you're trying to add `sysstat` to the list of packages to be determined at runtime. Is that what you're trying to do? If so, I'm not sure what you're trying to do here, but it looks like you're trying to add `sysstat` to the list of packages to be determined at runtime. Is that what you're trying to do? If so, I'm not sure what you're trying to do here, but it looks like you're trying to add `sysstat` to the list of packages to be determined at runtime. Is that what you're trying to do? If so, I'm not sure what you're trying to do here, but it looks like you're trying to add `sysstat` to the list of packages to be determined at runtime. Is that what you're trying to do? If so, I'm not sure what you're trying to do here, but it looks like you're trying to add `sysstat` to the list of packages to be determined at runtime. Is that what you're trying to do? If so, I'm not sure what you're trying to do here, but it looks like",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a `collect_perf_data` option to the `validate_host` method.",
       "reference": "This `if` statement can be merged with the above `if opts[:collect_perf_data]`."
     },
     {
@@ -32431,11 +32431,11 @@
       "reference": "But won't we do case-insensitive matching for all the drivers? For example, we will get the revision field case-insensitively. Let's make this case-sensitive. I think the way the mongo driver works, by lowercasing field names, will be OK with that."
     },
     {
-      "prediction": "I'm not sure what you mean by \"online workshop\"",
+      "prediction": "I think we should remove the `
    ` and `
    ` tags.",
       "reference": "I believe this should be on `workshops/show` now, not `products/show`"
     },
     {
-      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. Is it that you want to test that the IP is a valid country code? Or is it that you want to test that the IP is a valid country name? Or is it that you want to test that the IP is a valid country code and country name? Or is it that you want to test that the IP is a valid country code, country name, and country name? Or is it that you want to test that the IP is a valid country code, country name, country name, and country name? Or is it that you want to test that the IP is a valid country code, country name, country name, country name, and country name? Or is it that you want to test that the IP is a valid country code, country name, country name, country name, country name, and country name? Or is it that you want to test that the IP is a valid country code, country name, country name, country name, country name, country name, and country name? Or is it that you want to test that the IP is a valid country code, country name, country name, country name, country name,",
+      "prediction": "I don't think this is a good idea. It's not clear to me what you're trying to do here. Is it that you want to test that the IP is a valid country code? Or is it that you want to test that the IP is a valid country name? Or is it that you want to test that the IP is a valid country code and name?",
       "reference": "If we return error when we are unable to found country in database, using country detector would be much easier - if error was not returned, that means country was returned :) This doesn't have to be solved in this PR, but since you're adding such case, we can add a `TODO` just to track this :)"
     },
     {
@@ -32443,31 +32443,31 @@
       "reference": ".NET Framework: Fallback to `DD_INTEGRATIONS` if `DD_DOTNET_TRACER_HOME` was not set."
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to add a check for `authority` and `path_` to make sure they are not `None` and that they are not empty strings.",
+      "prediction": "I'm not sure if this is the right place to do this, but I think it would be a good idea to move this into the `url` module, so that we don't have to import it every time we want to use it.",
       "reference": "Can you use `authority, _, path = rest.partition(b\"/\")` here? That should make stuff a bit cleaner."
     },
     {
-      "prediction": "I'm not sure if this is a good idea, but I think it's a good idea to add a `--stress-test LIMIT` option to the parser.",
+      "prediction": "I'm not sure if this is the right place to add this, but I think it would be good to add it to the `--stress-test` option as well.",
       "reference": "I don't think this needs to be a float if its a number of seconds... :)"
     },
     {
-      "prediction": "I don't think this is a good idea. It would be better to use an array instead of an array of arrays.",
+      "prediction": "I don't think this is needed anymore.",
       "reference": "Please add \"Array\" back, right now it's not a proper sentence."
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `QueryElevationParams` class.",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `QueryElevationComponent` class.",
       "reference": "@tkaessmann when I ran tests I saw this line has a bug. It inverts the SHOULD and MUST. Hopefully I fixed it and merged it without the bug."
     },
     {
-      "prediction": "I think we can remove the `if log.GetTelemetryURI() == \"\"` check.",
+      "prediction": "I think we should remove the `if log.GetTelemetryURI() == \"\"` check.",
       "reference": "There may be another bug, it looks like we're already in a `if telemetryConfig.Enable` block at this point, maybe that block should be unnested?"
     },
     {
-      "prediction": "I'm not sure if this is the best way to do this, but I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it. I think it's a good way to do it",
+      "prediction": "I think this should be `if \"content-type\" not in self.headers:` instead of `if \"content-type\" not in self.headers:`",
       "reference": "This... looks like it plainly didn't work before? Good catch. I would suggest we change the logic here to 1. Check if `self.headers[\"content_type\"].startswith(\"multipart/form-data\")`, and if that's not the case, add a content-type header with a random (?) boundary. The point here is that if someone assigns to `.multipart_form = ` in their addon, the header should be updated accordingly if the request was not multipart before. 2. *After* that, call `self.content = multipart.encode(self.headers, value)` (as we do right now)"
     },
     {
-      "prediction": "I'm not sure what you're trying to do here. I think you're trying to test that the trie file is created, but I'm not sure what you're trying to test here.",
+      "prediction": "I'm not sure what you mean by \"wrong nonce\" here. I think you meant to say \"wrong block number\" or \"wrong block index\" or something like that.",
       "reference": "importShadow: shadow of imported from 'github.com/stretchr/testify/require' package 'require' (from `gocritic`)"
     },
     {
@@ -32475,23 +32475,23 @@
       "reference": "Wouldn't it be enough to change the condition in the for loop to `link_state != IBL_UNLINKED`?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in `glib-compile-symbols` instead of `glib/gi18n.h`. I'm not sure if this is the right place to put this, but I think it should be in `glib-compile-symbols` instead of `glib/gi18n.h`. I'm not sure if this is the right place to put this, but I think it should be in `glib-compile-symbols` instead of `glib/gi18n.h`. I'm not sure if this is the right place to put this, but I think it should be in `glib-compile-symbols` instead of `glib/gi18n.h`. I'm not sure if this is the right place to put this, but I think it should be in `glib-compile-symbols` instead of `glib/gi18n.h`. I'm not sure if this is the right place to put this, but I think it should be in `glib-compile-symbols` instead of `glib/gi18n.h`. I'm not sure if this is the right place",
+      "prediction": "I'm not sure if this is the right place to put this, but I think it should be in the `glib/gi18n.h` header file. It's not in the `glib/gi18n.h` header file because it's not used in the `glib/gi18n.h` header file. It's in the `glib/gi18n.h` header file because it's not used in the `glib/gi18n.h` header file. It's in the `glib/gi18n.h` header file because it's not used in the `glib/gi18n.h` header file. It's in the `glib/gi18n.h` header file because it's not used in the `glib/gi18n.h` header file. It's in the `glib/gi18n.h` header file because it's not used in the `glib/gi18n.h` header file. It's in the `glib/gi18n.h` header file because it's not used in the `glib/gi18n.h` header file. It's in the",
       "reference": "I'm not familiar with signed setups, but this does not seem to offer a way to choose between GPG and signapi verification. Are they usually either both enabled or both disabled? Would this be better suited as a verb with flags for different methods?"
     },
     {
-      "prediction": "I'm not sure if this is the right place to do this, but I think it's a good idea to have a separate function for getting the block value, so that we don't have to call this function every time we want to get the block value.",
+      "prediction": "I think it's better to use `db.Get(blockNS, h[:])` instead of `db.Get(blockNS, h[:])[:]`",
       "reference": "assignments should only be cuddled with other assignments (from `wsl`)"
     },
     {
-      "prediction": "I'm not sure what you're trying to do with this route, but I don't think it makes sense to have a `post \"/auth/:provider/callback\" => \"auth#oauth_callback\", via: [:get]` route. It's not clear what you're trying to do with this route.",
+      "prediction": "I don't think this is necessary. We can just remove the `match` and `post /auth/:provider/callback` routes.",
       "reference": "would it make sense to mock oauth in a way that we direct a user to this endpoint on login (in a test)?"
     },
     {
-      "prediction": ".Id + '\" data-toggle=\"tooltip\" data-placement=\"top\" data-original-title=\"' + entry.Overview + '\">', html += entry.Overview, html += \"\", entry.Overview && (html += '', html += entry.Overview, html += \"\", entry.Overview && (html += '', html += entry.Overview, html += \"\", entry.Overview && (html += '', html += entry.Overview, html += \"\", entry.Overview && (html += '', html += entry.Overview, html += \"\", entry.Overview && (html += '', html += entry.Overview, html += \"\", entry.Overview && (html += '