diff --git "a/qwen25_0.5b_fmft_official_5e-05/complete_results.json" "b/qwen25_0.5b_fmft_official_5e-05/complete_results.json" new file mode 100644--- /dev/null +++ "b/qwen25_0.5b_fmft_official_5e-05/complete_results.json" @@ -0,0 +1,40694 @@ +{ + "test_bleu_4": 0.018908596504347546, + "test_exact_match": 9.833808634083981e-05, + "test_rouge": { + "rouge1": 0.13859125771277808, + "rouge2": 0.01957766609514052, + "rougeL": 0.11310167198360728, + "rougeLsum": 0.11317235766398888 + }, + "test_bertscore": { + "precision": 0.8390011585664932, + "recall": 0.84534054110683, + "f1": 0.8417594840843331 + }, + "test_meteor": 0.10851142872748486, + "raw_data": [ + { + "prediction": "Is there a reason for this change? I think it should be `transport=grpc,java` or `transport=grpc,java,transport=grpc`", + "reference": "can we also test for `transport=rest`?" + }, + { + "prediction": "I think this should be done in the constructor of the `SolrBackendFactory` and not in the `AbstractSolrBackendFactory` class. The `AbstractSolrBackendFactory` is only used by the `SolrBackend`.", + "reference": "If record_batch_size is not set in config.ini, this code will trigger a notice about an undefined value. I would suggest either wrapping the setPageSize() call in an `if (!empty(...)) {` check, or else providing a default value in the set call (i.e. `$config->Index->record_batch_size ?? 100`)." + }, + { + "prediction": "I don't think this is the right place to set the SEGMENT_KEY. I think it should be in the `analytics.js` file in `app/assets/javascripts/` folder.", + "reference": "I didn't realize we were hardcoding this, thanks for moving it to an env value." + }, + { + "prediction": "I think this should be `typeof file.data.size !== 'undefined' ? html`
${prettyBytes(file.data.size)}
` : ''`", + "reference": "We are trying to support IE 10-11, so we'll need a polyfill for this one, I think." + }, + { + "prediction": "nit: `reset_success` -> `reset_success_message`", + "reference": "It looks like there's a new `isNavigatingTo( url )` selector for this very purpose so let's use this here instead. This way we just need to use the one selector rather than two. Let's assign that to a similar-named variable here (e.g. `isNavigatingToPostResetURL`) rather than the prop it's used with." + }, + { + "prediction": "I think this should be `const MatrixType&` instead of `const AbsMat&`.", + "reference": "I think im2col should only accommodate CPUMat." + }, + { + "prediction": "I think we should move this to the top of the file.", + "reference": "alpha sort the imports" + }, + { + "prediction": "I think this should be `sizeof(sysfs_path) - 1` instead of `sizeof(sysfs_path) + sizeof(\"DEVICEID_PATH\") - 1`", + "reference": "Can you explain why is this necessary? Is `snprintf()` with four integer arguments unsafe?" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I could get it to work on Windows 10 21H2. It's also the only way I've been able to get it to work on Ubuntu 20.04. I'm not sure if there is a better way to do this, but it's the only way I've been able to get it to work on Windows 8.1 21H2. I'm not sure if there is a better way to do this, but it's the only way I've been able to get it to work on Ubuntu 18.04. I'm not sure if there is a better way to do this, but it's the only way I've been able to get it to work on Windows 7 64bit. I'm not sure if there is a better way to do this, but it's the only way I've been able to get it to work on Ubuntu 18.04. I'm not sure if there is a better way to do this, but it's the only way I've been able to get it to work on Windows 8.1 21H2", + "reference": "How likely would it be that the keyboard layout for the NVDA main thread differs from the keyboard layout of the currently focused app?" + }, + { + "prediction": "I think this should be `service = getDefaultService() || service.start();`", + "reference": "Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`)" + }, + { + "prediction": "I think this should be `setParameter('text', keys.join('')).`", + "reference": "Also update line 2205 below" + }, + { + "prediction": "I think this should be `volumeConfig.GetSharedStorageMountValue()`", + "reference": "n_: It is a good practice to name the variable to indicate what they contain. In this case since `shared` is supposed to have boolean, calling it: `isShared` can help in the readability of the code." + }, + { + "prediction": "I think we can remove the `@param` here, since we don't need to pass `column` to `freezeColumn()`.", + "reference": "I suppose it's a false-positive error. Maybe there is a way to configure the `eslint-*` package to accept `i.e. .... lower case` syntax" + }, + { + "prediction": "I'm not sure why this is necessary, but it seems like it should be `activity.ParentSpanId.ToHexString() == \"0000000000000000\"`.", + "reference": "this maynot be a perf issue, if ToHexString() is not actually allocating a string, but returns the caches string value. to be confirmed." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `if len(updates) > 0` block above.", + "reference": "`zap.String(\"image-provider\", provider.Name())` should be in a same line." + }, + { + "prediction": "I think we can remove the `|| 300` here.", + "reference": "Why this deletion?" + }, + { + "prediction": "I'm not sure this is the right way to do it. I think it would be better to use `assertIn` to check that the cache control header is present in the remote metadata.", + "reference": "This change looks unrelated to the CL description?" + }, + { + "prediction": "I think this should be `DEDUP_RESULT_CHECK` instead of `DEDUP_RESUTL_CHECK`", + "reference": "I'm not certain that `res`+`utl` isn't a thing." + }, + { + "prediction": "I think this should be `Status.EXECUTION_STOPPED, Status.SUCCEEDED, Status.KILLED, Status.FAILED`", + "reference": "This method can cause bugs. Why don't you use list of finalize statuses and then use join by comma and that will give you correct value. Use Apache Commons Lang library List list = Arrays.asList(1,2,3,4,5,6,7); String str = org.apache.commons.lang.StringUtils.join(list, \",\"); You can use it at multiple places shown in this diff." + }, + { + "prediction": "This should be `return dev->type == WLR_INPUT_DEVICE_TOUCHSCREEN ? dev : NULL;`", + "reference": "Merge with next condition" + }, + { + "prediction": "This is a bit of a nitpick, but I think it would be better to call this `DeleteStack` instead of `DeleteTask`.", + "reference": "Maybe add it when it is used." + }, + { + "prediction": "I think this should be `scanners` instead of `non_exist_scanner`", + "reference": "More clear naming: NONEXISTENT_ENABLED" + }, + { + "prediction": "I think this should be `to.equals(Types.LongType.get())`", + "reference": "why is this change necessary?" + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be moved to `org.apache.gobblin.util.SchemaUtils#getTypeFullName`", + "reference": "make a SchemaTypeNameConverter.getTypeNameForEmptyType() and call that here." + }, + { + "prediction": "I think this should be `$this->locale = $request->getSession() ? $request->getSession()->getLang()->getLocale() : Lang::getDefaultLanguage();`", + "reference": "Use braces on your conditional structures please" + }, + { + "prediction": "This should be `true` by default.", + "reference": "Great God, I have a question. This \".nebula_history\" file is used to save history commands. Is there a file size limit? When the file is large, does it take a long time to start initialization (loadHistory)? How did you think about this? Thx." + }, + { + "prediction": "I don't think this is the right way to check for parentheses. The `isType` check should be done at the top of the function, before the `do-while` loop. The `do-while` loop should only be entered if `isType (token, TOKEN_OPEN_PAREN)` evaluates to `true`.", + "reference": "Isn't this the same check as two lines above?" + }, + { + "prediction": "I think this should be named `CONFIG_PATH` instead of `CONFIG_FILE`.", + "reference": "Don't redefine, just import the existing one in `cmdline.py`. :)" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "why not call `respond_to?(\"#{name}=\")` from the `if` line?" + }, + { + "prediction": "I think this should be `workingDir` instead of `workspaceRootDirectory`", + "reference": "This was properly set above as `.runfiles/` (with a fallback to workspace root dir) but never used past this line." + }, + { + "prediction": "I don't think we need this attribute. We can just use `Page` as the name of the view model.", + "reference": "Are all these namespaces required for this attribute?" + }, + { + "prediction": "Line is too long. [83/80]", + "reference": "Given this may be used and printed in other ways, isn't `debug` more appropriate?" + }, + { + "prediction": "I don't think this is the right place to do this. I think we should move this to `store.go` and then call it from here.", + "reference": "Looks like this is unused? Did you mean to call it when clearing the block journal?" + }, + { + "prediction": "I think it would be better to pass the `alerters` to the `ExecutorManager` constructor instead of creating a new one here.", + "reference": "why named alters? how about this.alerts = alerts?" + }, + { + "prediction": "I think we can remove the `Mirror` field from the `StreamInfo` struct.", + "reference": "not sure if this has to be here or not tbh" + }, + { + "prediction": "I think we should be able to get rid of this line.", + "reference": "There's a better fix for this in #1741, which should replace this." + }, + { + "prediction": "Why is this needed?", + "reference": "Use swarm.Address not []byte as type, and construct it from actual byteslice or use swarm.NewAddress if it is constructed from hex-encoded string." + }, + { + "prediction": "I think this should be `require.NoError(t, fs.RemoveAll(dir))`", + "reference": "It would be worth factoring this out to a function, but you don't have to do that here." + }, + { + "prediction": "I don't think we should have a separate method for linkifying the uri. I think we should have a single method that returns the linkified version of the uri.", + "reference": "There's no need for `final` in interfaces." + }, + { + "prediction": "I think we should use `Span.SetTag` instead of `Span.SetTag` here. The reason is that `Span.SetTag` takes a `string` tag name and a `string` tag value, whereas `Span.SetTag` takes a `string[]` tag name and a `string[]` tag value. In this case, I think we should use `Span.SetTag` instead of `Span.SetTag`.", + "reference": "Isn't this case handled as a custom tag in `Span.SetTag()` below? This switch is only for special tags that actually set `Span` properties." + }, + { + "prediction": "I think this line should be indented 2 spaces.", + "reference": "This shouldn't be changed." + }, + { + "prediction": "I don't think this is the right place for this file.", + "reference": "This one is important `2: I102 copyright year is outdated, expected 2014 but got 2012`" + }, + { + "prediction": "nit: remove unused import `java.util.function.BiConsumer;`", + "reference": "Are these imports needed (BiConsumer and Consumer)? If they are unused imports, then precommit will fail." + }, + { + "prediction": "I'm not sure this is the right place for this job. I think it should go in `lib/rails/mailers/destroyer_mailer.rb`", + "reference": "Why are we catching and logging exceptions? By doing that we make it look like the job has succeeded and it will be removed from the queue - if we didn't do that then it would stay queued..." + }, + { + "prediction": "I think this should be `null` instead of `[]`.", + "reference": "If there are `@param` tags in docblock, there should be `@return` tag also. (applies for a whole file)" + }, + { + "prediction": "I think it would be better to call this `VALIDATOR` instead of `VALIDATORS`.", + "reference": "Is the concept of validators exclusive to IBFT2? I wonder if this category should be more explicitly linked to IBFT2." + }, + { + "prediction": "I think we can remove this import as it is not used in this class.", + "reference": "Spotless is configured to reject star imports. Please replace with explicit imports." + }, + { + "prediction": "I think this should be `std::numeric_limits::max()` instead of `std::numeric_limits::max()`", + "reference": "Remind me why you are using CUDA vocabulary when naming these variables." + }, + { + "prediction": "I'm not sure this is the right place to do this. Feeds are fetched from the DB, and then the feed counters are updated in the DB. I think it would make more sense to update the feed counters after the feeds have been fetched from the DB, rather than after the feeds have been fetched and the counters updated in the DB. This way, the counters will always be updated correctly, regardless of how many feeds are fetched from the DB.", + "reference": "Please turn the iteration order around (instead of `0...size` to `size...0`). The reason is that this sometimes skips indices when removing an item. You can therefore end up with feeds that have counter 0 and are still displayed." + }, + { + "prediction": "I think this should be `if solid_subset is not None` instead of `if not solid_subset`", + "reference": "this is a behavior change. solid_subset=[] represents an empty pipeline where as solid_subset=None is the full pipeline" + }, + { + "prediction": "I'm not sure this is the right place for this warning. I think it should be in the `CustomSettings.Validate` method, since that is the place where we validate the settings.", + "reference": "this is a breaking change, any specific reason you want to do this?" + }, + { + "prediction": "I'm not sure if this is the right place to put this.", + "reference": "Blocking: we still want read write separation. Node functions should absolutely not write to the chain store and the interface should reflect that. Only the syncer should have this capability in production code. It should be no problem to keep casting chainForTest to a read-write interface, or doing other function decomposition and automatic casting tricks." + }, + { + "prediction": "I think this should be `1<<30 - 1` instead of `1<<31 - 1`", + "reference": "The PR description says the lowest on-demand request priority is `2^30`. Why the `-1` here?" + }, + { + "prediction": "This function should be moved to the bottom of the file.", + "reference": "checking health again? I think it is not necessary." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it's the only thing I can come up with.", + "reference": "Need an `if err == nil {break}` above this line so that we don't log/sleep if the retry succeeds." + }, + { + "prediction": "I don't think this is the right place to put this. I think it should be in `lib/promise.js`", + "reference": "to reiterate my point above, this class is not the actual provided Promise, but rather something a user can provide a Promise to/with. I think a name like `PromiseProvider` is more appropriate." + }, + { + "prediction": "I don't think we need this anymore.", + "reference": "I guess we can only call this from a post-build function, but we might need to check that this target is to be built? I guess target A depends on B which has a post build. We `plz build :B` which adds C as a dep of A. Won't we queue C to be built even though it only needs to build if A needs to be built? That's kinda why I approached this the way I did. I trust you've thought about this but would be good to understand this a bit better." + }, + { + "prediction": "I think this should be `if arch.FREEBSD or arch.DARWIN and not (pks.__class__.__name__ == 'StreamSocket')`", + "reference": "You should use `isinstance()` instead of comparing the class name to a string." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I could get it to work.", + "reference": "Why should audio and video elements always return `false` for `isHidden`?" + }, + { + "prediction": "why do we need this?", + "reference": "This obviously won't work for all the other platforms." + }, + { + "prediction": "I'm not sure this is a good idea. I think it would be better to use a `Map state = new HashMap();` in the constructor of the `InjectableStepsFactory`.", + "reference": "Isn't he diamond operator Java7+?" + }, + { + "prediction": "I think this should be `throw new IllegalArgumentException(message, argName, number);` instead of `throw new IllegalArgumentException(message, argName, number);`", + "reference": "Prefer adding a second `positive(String, double)` that delegates down to this three-param version. Using `null` in code is generally Not A Great Idea, and it looks ugly." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `plan/expr`.", + "reference": "This pattern, where we add a new parameter without using it, often indicates to me that we've got a leaky interface or abstraction. I see this pattern _a lot_ in this patch, so wondering you have thoughts about it." + }, + { + "prediction": "This should be `if err = os.MkdirAll(dir, 0755); err != nil {`", + "reference": "This seems like an improved pattern :)" + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "`open_id_authentication` is no longer the name of the function, and it's not OpenID specific" + }, + { + "prediction": "I'm not sure if this is the right place to add this, but it's the only way I could find to make it work.", + "reference": "This didn't require corresponding changes to the test case(s)?" + }, + { + "prediction": "I think it would be better to call this `Env` instead of `EnvFile`.", + "reference": "A question! I think `string` totally works, but what do you think of `*string` for consistency?" + }, + { + "prediction": "I think this should be `aws.cluster.sigs.k8s.io/infrastructure-ready` and `aws.cluster.sigs.k8s.io/control-plane-ready` instead of `aws.cluster.sigs.k8s.io/infrastructure-ready` and `aws.cluster.sigs.k8s.io/control-plane-ready`", + "reference": "Should this be: `aws.infrastructure.cluster.sigs.k8s.io` instead?" + }, + { + "prediction": "I don't think you need to change this line.", + "reference": "Not clear on why this change is correct." + }, + { + "prediction": "I don't think this is the right place to put this method. I think it should go in `IndexIO`.", + "reference": "Hi Simon. Whether this should return true depends on what byte buffers are used? The same applies to ByteBufferIndexInput, actually... I don't think you can generally tell whether the ByteBuffers the input operates on come from a mmap call or from somewhere else (even direct buffers don't have to be a result of mmap)." + }, + { + "prediction": "I think this should be 10px.", + "reference": "All stories in this file also need to have the default padding." + }, + { + "prediction": "I think this should be `parent` instead of `sibling`.", + "reference": "I don't think these asserts are necessary, because `subsurface_find_sibling` already searches in the parent. Or am I missing something?" + }, + { + "prediction": "Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.", + "reference": "Should this be `number` instead of `id`?" + }, + { + "prediction": "I'm not sure this is the right place for this change. I think it should go in the `TrafodionTable` class, not the `BindWA` class. The `TrafodionTable` class is the base class for all Trafodion tables. The `BindWA` class is a subclass of the `TrafodionTable` class. The `TrafodionTable` class has an `isExternalTable()` method that can be used to check if an object is an external Trafodion table. The `BindWA` class has an `isExternalTable()` method that can be used to check if an object is an external BindWA table. The `TrafodionTable` class also has a `allowExternalTables()` method that can be used to check if an object is allowed to be an external Trafodion table. The `BindWA` class also has a `allowExternalTables()` method that can be used to check if an object is allowed to be an external BindWA table.", + "reference": "I have forgotten why we thought this restriction is necessary. A user registers a Hive/HBase table with us but is not able to use the table with the registered name in DML. Will UPDATE STATs will be on the original name too (and update stats code will find out registered name and use it for Table_uid?). This was the registration concept is almost like an internal implementation idea, at some point could even be done by some utility program for all existing Hive/hBase tables, and the user need not be aware of it? I am struggling with a user would want to register a table, if they cannot use it by that name." + }, + { + "prediction": "I don't think this is needed. The app2sim_alloc_rx and app2sim_dealloc_rx variables are only used by the app2sim module. The sim2app_alloc_tx and sim2app_dealloc_tx variables are only used by the sim2app module. The app2sim_mmioreq_rx and app2sim_mmiorsp_tx variables are only used by the app2sim module. The app2sim_umsg_rx and app2sim_portctrl_rsp_tx variables are only used by the app2sim module. The sim2app_dealloc_tx and sim2app_portctrl_rsp_tx variables are only used by the sim2app module. The intr_event_fds[MAX_USR_INTRS] array is only used by the app2sim module.", + "reference": "Should most of these non-globals be static?" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Please do not approve PRs without tests!!!!" + }, + { + "prediction": "I think this should be `win_id=win_id` instead of `win_id=win_id`", + "reference": "Now that you handle this in `webenginetab.py` you can undo all the changes in this file." + }, + { + "prediction": "Why not just `throw new RuntimeException(e);`?", + "reference": "I think we should log the exception to a log file instead of printing it. The current behavior (not catching the exception) should lead to an automatic print of the exception to the terminal/console." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it's the only thing I can come up with right now.", + "reference": "These changes to the resource helpers have some more far-reaching implications as they also affect calls made in hive-operator, I believe. It's probably OK still, though. Ideally, the resource helper would not be the one doing the logging, since it cannot know the severity, but that is well beyond something that we should tackle for this PR. I would rather have the hive-operator log warnings than have the syncsetinstance controller log errors." + }, + { + "prediction": "I think it should be `null, null, 'Exports'`", + "reference": "do you really want to change the behavior on foreign key ?" + }, + { + "prediction": "I'm not sure this is the right thing to do. If the state_trans is set, it means that the event is going to be processed. If the event is going to be processed, it means that the event is going to be published. If the event is going to be published, it means that the event is going to be sent to the client. If the event is going to be sent to the client, it means that the event is going to be processed. If the event is going to be processed, it means that the event is going to be published. If the event is going to be published, it means that the event is going to be sent to the client. If the event is going to be sent to the client, it means that the event is going to be processed. If the event is going to be processed, it means that the event is going to be published. If the event is going to be published, it means that the event is going to be sent to the client. If the event is going to be sent to the client, it means that the event is going to be processed. If the event is going to be processed, it means that the event is going to be published. If the event is going to be published", + "reference": "Looks like my bad. Thanks for fixing!" + }, + { + "prediction": "I think this should be `--replace-variables` instead of `--no-replace-variables`.", + "reference": "I think \"Don't replace variables ...\" would be cleaner." + }, + { + "prediction": "I think this should be `objects=['3d', 'polar']` instead of `objects=['3d', 'polar', None]`", + "reference": "Do you validate the possible strings? I've not read the code below but we should make sure if a string is supplied it is validate..." + }, + { + "prediction": "I think this should be `dataDiskIndex + 1` instead of `dataDiskIndex`", + "reference": "I'd recommend using generateDataDiskName here as well -- might as well benefit from the safety that it gives to protect yourself from future changes to w.ID()." + }, + { + "prediction": "I'm not sure this is the right place to put this method. I think it would be better to put it in the `ContentFileBuilder` interface.", + "reference": "qq: do we want to include anything in the name to indicate that it is a position in the manifest?" + }, + { + "prediction": "Shouldn't this be `Log.d(LOGTAG, \"Compositor resume begin\");` and `Log.d(LOGTAG, \"Compositor resume end\");` ?", + "reference": "These logs should probably use the `LOGTAG`" + }, + { + "prediction": "I think we can remove this file now.", + "reference": "From this, it was clear, that we are using our version of wireguard-go. And now it looks like we are using original packages which is confusing." + }, + { + "prediction": "I think we can remove the `Message` property from the `ResultWrapper`.", + "reference": "Any particular reason for this? This potentially will make harder to investigate users issues" + }, + { + "prediction": "I think this should be `||` instead of `||=`.", + "reference": "Do you also need to check if Blockly.localConnection_ is non-null?" + }, + { + "prediction": "I'm not sure if this is a good or a bad idea. I think it's fine, but I'm not sure what the motivation is for it.", + "reference": "Not really a container, and it's not just about non-config data, not sure of a better description, @myronmarston ?" + }, + { + "prediction": "nit: I think it would be better to have a separate file for this. It's not really part of this PR, but it's something we need to be able to do in the future.", + "reference": "The desktop app will load this fine. on iOS I get `TypeError: undefined is not an object (evaluating '_$$_REQUIRE(_dependencyMap[8], \"stream\").Readable.Readable')` if I change it to `const Readable = require('stream').Readable;` or `const { Readable } = require('stream');` I get undefined errors from the stream on iOS: `[TypeError: stream.on is not a function. (In 'stream.on(\"data\", function (chunk) { return chunks.push(chunk); })', 'stream.on' is undefined)]` What am I missing?" + }, + { + "prediction": "I'm not sure this is the right fix. I think we need to make a copy of `ch.Data()` and store it in `m.store[ch.Address().String()]` instead of `m.store[ch.Address().String()] = b`.", + "reference": "this is needed since the chunk feeder shares memory across calls to the pipeline. this is in order to avoid multiple allocations. this change mimics the behavior of shed and localstore, and copies the data from the call into the in-memory store" + }, + { + "prediction": "Why is this needed?", + "reference": "wut. We can do this at the beginning of tests if we want right? Why are we depending on init?" + }, + { + "prediction": "Why do we need to unlock `srv.mu` here?", + "reference": "Same trick here IMO." + }, + { + "prediction": "I'm not sure if this is a good idea, but I don't have a better suggestion.", + "reference": "Should be `@origin = element || origin || POINTER`" + }, + { + "prediction": "I think this should be `if len(args) != 0 { bulkCstorSPCUpgrade(cmd, args) }`", + "reference": "this example needs a fix?" + }, + { + "prediction": "Shouldn't this be `wlr_xdg_toplevel_destroy`?", + "reference": "Is it safe to assume this surface is a toplevel?" + }, + { + "prediction": "I'm not sure this is the right place for this function. It seems like it should be in `pj_internal.h` but I don't know if that's the right file to put it.", + "reference": "we don't need that function" + }, + { + "prediction": "I think it would be better to have a `WINDOWS10` class extending `WIN10` so that we don't have to repeat `WIN10` everywhere.", + "reference": "we'll also have to think about adding \"Windows Server 2014\" or whatever they come up with later." + }, + { + "prediction": "I think this method should be renamed to `fetchActiveFlowByExecId(int execId) throws ExecutorManagerException;`", + "reference": "curious do we have an API to fetch an inactive flow?" + }, + { + "prediction": "I'm not sure this is the best way to do this, but it's the only way I could come up with at the time of writing.", + "reference": "This branch is not needed anymore because every `vnode` that passes through `h` in compat or core will have the `$$typeof`-property now ." + }, + { + "prediction": "I think this should be called `shouldContainAriaHiddenValue` instead of `ariaHiddenValue`", + "reference": "Did you mean to use `hasAttribute`? You shouldn't. This does not improve performance and it messes with the readability." + }, + { + "prediction": "I don't think this is needed.", + "reference": "Please import modules and not classes (except for Qt stuff)." + }, + { + "prediction": "I don't think we need this method. `super.setImage(image);` is enough to set the image on the `DummyJavaNode` object.", + "reference": "Hm... why do we have a \"DummyJavaNode\" in src/main? Looks like, this should have gone into src/test...." + }, + { + "prediction": "Can you add a license header here?", + "reference": "This seems meaningless. If we cannot add any info let us remove this." + }, + { + "prediction": "I think this should be `GetPortsForContainer`", + "reference": "Can you rename `Ports` to `PortsUnsafe`?" + }, + { + "prediction": "I'm not sure if this is the best name for this method. I think it's a bit confusing because it's not just a return to, but a return to a return to. Maybe something like `make_return_to_path` or `make_return_to_name` would be better.", + "reference": "This feels like it could be moved out to your first gem!" + }, + { + "prediction": "I'm not sure this is the right abstraction for this interface. It seems like we should be able to just return a `CompletableFuture` instead of an `Optional`. This would allow us to remove the need for the `poll` method and the `clear` method, as well as the need for the `offerFirst` and `offerLast` methods.", + "reference": "The expected behaviour for `poll` would be to match what `Deque` does, which is: > Retrieves and removes the head of the queue represented by this deque As such, you shouldn't need the `RequestId` here." + }, + { + "prediction": "I'm not sure this is the right place for this method. I think it should go in `utils.js` since it's only used by `utils.js`.", + "reference": "This is super minor, but it'd be nice if this iterated over an arbitrary number of array inputs." + }, + { + "prediction": "I'm not sure this is the right way to do this. The `readlink` function will return -1 on error, and we don't want to terminate the process when that happens. Instead, we should check the return value of `readlink`, and if it's non-zero, we should print an error message and return -1.", + "reference": "What is the problem here? The commit message has strange wording \"readlink is defined with restrict pointers\": do you mean \"restricted\"? Is that a well-defined language term? I'm not sure what it means." + }, + { + "prediction": "I think this should be `ImmutableSet.of()` instead of `ImmutableList.of()`.", + "reference": "Why are we not wrapping here?" + }, + { + "prediction": "Why do you need this `@var`?", + "reference": "I though that all data objects are being unified in the fashion where all default values are initialized in constructor, are not they?" + }, + { + "prediction": "08929000000000000\",\n \t\"libflux/flux-core/src/ast/struct.rs\": \"92929292929292929292929292929292929292929292929292929292929292929292929292929292929292929292929292929292929292929292929292929292929292929292929292929292929292929292929292929292929292929292929292929292929292929292929292929", + "reference": "Does this file actually need to be committed to git? Having to run `make generate` is rather tedious on each PR and it conflicts easily." + }, + { + "prediction": "I'm not sure this is the best way to do this, but it's the only way I could come up with that worked.", + "reference": "We don't need this anymore, as Google's library handles various auth mechanisms for us. We'll be less explicit about why we're failing but we gain support for several authentication methods- swings and roundabouts!" + }, + { + "prediction": "I think this should default to `/var/lib/docker/volumes/plugins` instead of `/run/docker/plugins`", + "reference": "No need to speficy attribute here. Moreover in yaml it is default to use lowercase names." + }, + { + "prediction": "I think we can remove `using System.Diagnostics.CodeAnalysis;` from `Microsoft.DotNet.Build.CloudTestTasks` as well.", + "reference": "In general I'm a trying to understand the reason behind this PR. Looks like if a blob (name) already exists we check if the contents are identical? In what scenarios this is not the case? When we want to publish a package/asset that has changed but still we want to use the same version?" + }, + { + "prediction": "I'm not sure this is the best way to do this. I think it would be better to use `requests` to make the requests.", + "reference": "Can rename `req` to be `opener`, since that is the object, and it wraps `req` internally?" + }, + { + "prediction": "I don't think it's a good idea to put breakpoint in textList. It's not a good idea to have it in textList. It's not a good idea to have it in textList. It's not a good idea to have it in textList. It's not a good idea to have it in textList. It's not a good idea to have it in textList. It's not a good idea to have it in textList. It's not a good idea to have it in textList. It's not a good idea to have it in textList. It's not a good idea to have it in textList. It's not a good idea to have it in textList. It's not a good idea to have it in textList. It's not a good idea to have it in textList. It's not a good idea to have it in textList. It's not a good idea to have it in textList. It's not a good idea to have it in textList. It's not a good idea to have it in textList. It's not a good idea to have it in textList. It's not a good idea to have it in textList. It's not a good idea", + "reference": "@MichaelDCurran, thoughts on adding a breakpoint format field attribute? It seems almost app specific, but I guess it does seem odd abusing line-prefix. Is there any more generic concept here?" + }, + { + "prediction": "I think this should be `self._execute(Command.GET_ELEMENT_RECT, return_base64=True)`", + "reference": "This would return a tuple of two dictionaries. You need to combine them and return a dictionary" + }, + { + "prediction": "nit: I think it would be better to move these imports to the top of the file.", + "reference": "What do you think of moving the example to the help text of the prompt? and the prompt itself can be \"What is your application's GitHub repository URL?\"" + }, + { + "prediction": "I'm not sure this is the right way to do this. I think we should be able to get the timestamp from the `Span` object itself.", + "reference": "Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs." + }, + { + "prediction": "I think this should be `first + 8` instead of `std::distance(first, last) > 8`", + "reference": "Nice use of std::distance. I'm a bit worried about first += 9 though." + }, + { + "prediction": "I'm not sure this is the right place for this. I think we should move this to the `prometheus-operator` namespace.", + "reference": "Shouldn't this be `app.kubernetes.io/managed-by` as prometheus-operator manages this resource, but this resource isn't a part of prometheus-operator?" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "As long as we're being extra-vigilant about NREs, should we check that `httpMethod` and `requestUri` are not null?" + }, + { + "prediction": "I think it would be better to move this to the `ioctl` package, since it's not specific to xRc20.", + "reference": "No need to have `xrc20` alias" + }, + { + "prediction": "I'm not sure if this is the right place to put this method. I think it should be in the `context_cls_inst` function, since it's only used by that function.", + "reference": "the naming convention I'm been adopting if `_type` for instances of these classes. So maybe `context_config_type` is a better name for this fn" + }, + { + "prediction": "I think this should be `final` instead of `private`.", + "reference": "Don't call it GPU mining, call it `externalMining`, here and throughout." + }, + { + "prediction": "I think it would be better to add a `default: null` value to the `imageMaxWidth`/`imageMaxHeight`/`imageQuality` options and set it to `0` by default.", + "reference": "`within this with` typo, should be `within this width`" + }, + { + "prediction": "This should be `+k8s:openapi-gen=true`", + "reference": "how come this is false?" + }, + { + "prediction": "I think we can remove this function now, since we don't use it anywhere else.", + "reference": "How about `Object.prototype.toString`? Or using the `typeof` operator?" + }, + { + "prediction": "Should this be `context.Background()` instead of `context.Context`?", + "reference": "I know @jzila suggested this, but I disagree: you're really not supposed to save a context in a struct. Can you get by with just saving the `Done()` channel instead? The `ctx` should continue to be passed around explicitly." + }, + { + "prediction": "I think this should be `!IsWindows && !PlatformApis.IsWindows && PlatformApis.IsDarwin;`", + "reference": "This check isn't right though." + }, + { + "prediction": "I think this should be `public abstract String codeGenVersion();`", + "reference": "maybe `toolkitVersion` instead? It doesn't necessarily have to be called that in the generated code, but in the view model classes, I think it makes it clearer that it is the version of toolkit itself." + }, + { + "prediction": "`setFileState` and `emit` don't seem to be used in this file.", + "reference": "the response data was added intentionally in #612, i think we could keep the `setFileState` stuff here as a special case, at least for now" + }, + { + "prediction": "I'm not sure this is the right fix. The problem is that `deadline` is not guaranteed to be known at this point in the code, so we can't be sure that `time.Until(deadline)` will be >= `time.Now`.", + "reference": "This isn't really easy to read." + }, + { + "prediction": "I think this should be `error` instead of `string`", + "reference": "This line changed due to go formatting. Format was not there earlier." + }, + { + "prediction": "I think it would be better to have a `With` method on the `staticUpstream` struct, so that we don't need to pass in `Without` when creating a new `staticUpstream` struct.", + "reference": "The name \"Without\" in code is a little nebulous. Maybe something more descriptive like TrimPrefix or StripPrefix or WithoutPathPrefix or something like that. (Thoughts?)" + }, + { + "prediction": "I'm not sure this is the right place for this test. I think it should be moved to `TestDatasetOperations#linkDataset` and `TestDatasetOperations#unlinkDataset`.", + "reference": "is this test in the move tests? I see what you mean then - it works, but I wonder if we won't lose track that it's being tested here." + }, + { + "prediction": "I think this should be `[]string` instead of `map[string]string`", + "reference": "I'm not sure if this wanted to be `json:\"tags\"` (which I'd set in my PR) or `json:\"tag\"` that someone elses PR had set. Given that the rest of the fields had their JSON field name set to the same as the struct field name, I opted for `tags`." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "since the logic here and in `Proposal` is exactly the same, do you think it makes sense for us to include it elsewhere? I am not opposed to duplicated code when it makes sense, but the reason I first identified this was that I was looking for code in NCR::WorkOrder that was not specific to Work Orders. Seems like fiscal year logic might be helpful for reporting for other clients. In that case, we'd want this scope on those client data classes as well. Might be wrong to include this in the FiscalYear mixin, but it does seem like it should be outside of Proposal and WorkOrder. Does that make sense?" + }, + { + "prediction": "Shouldn't this be `self.log.info('RabbitMQ connection got closed!')`?", + "reference": "there is no static method as a go between -- how does this work?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `lib/`", + "reference": "Can you please change the name of this class to be something else?" + }, + { + "prediction": "I don't think we should change the signature of this function.", + "reference": "I think we might prefer generalizing the interface rather than creating an exception. Current design of `h2o_next_token` assumes the input to be a comma-separated list, and allows the caller to specify a different separator when parsing a nested list. As I understand, what we are trying to attain in this PR is to have a way of parsing a flat list of semicolon-separated list. Assuming that is the case, I think it would be better to change the API of the function to accept two separators (i.e. inner and outer), where for our existing use-cases `outer` would be `,`." + }, + { + "prediction": "I'm not sure if this is a good idea, but I don't have a better idea.", + "reference": "why not recycling? I Lru cache now recycling?" + }, + { + "prediction": "Why is this change needed?", + "reference": "Why it is now called `PaymentVersionV3`?" + }, + { + "prediction": "I think we should use `klog.V(5).Infof` instead of `klog.V(4).Infof` here.", + "reference": "changed for debug purpose?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think we should move this to the base class so that it can be overridden by each specific exporter.", + "reference": "@cijothomas I needed a way to set the Exporter.ParentProvider when the Processor's gets set. Internal to SDK though." + }, + { + "prediction": "I think this should be `node_based_graph.GetEdgeData(eid).flags.road_classification.IsRampClass() || (from_motorway && node_based_graph.GetEdgeData(eid).flags.road_classification.IsLinkClass())` instead of `node_based_graph.GetEdgeData(eid).flags.road_classification.IsRampClass() || (from_motorway && node_based_graph.GetEdgeData(eid).flags.road_classification.IsLinkClass())`", + "reference": "Talking through this scenario with @srividyacb and she's wondering if there should also be a check of `(from_trunk && node_based_graph.GetEdgeData(eid).flags.road_classification.IsLinkClass())` as highways with trunk classifications can also have this scenario." + }, + { + "prediction": "Line is too long. [83/80]", + "reference": "where does `master_certname` come from?" + }, + { + "prediction": "`__all__` is used in `__init__.py` files to indicate what members of a module are intended to be public. In this case, we don't want people to import `hrnet` or `hrnet_v2` or `hrnet_v3` or `hrnet_v4` or `hrnet_v5` or `hrnet_v6` or `hrnet_v7` or `hrnet_v8` or `hrnet_v9` or `hrnet_v10` or `hrnet_v11` or `hrnet_v12` or `hrnet_v13` or `hrnet_v14` or `hrnet_v15` or `hrnet_v16` or `hrnet_v17` or `hrnet_v18` or `hrnet_v19` or `hrnet_v20` or `hrnet_v21` or `hrnet_v22` or `hrnet_v23` or `hrnet_v24` or `hrnet_v25` or `hrnet_v26` or `hrnet_v27` or `hrnet_v28` or `hrnet_v", + "reference": "The line breaking is unnecessary." + }, + { + "prediction": "I think this should be `feature_names_ = Common::Split(first_line.c_str(), \"\\t,\");`", + "reference": "why not enable split by space here ?" + }, + { + "prediction": "Shouldn't this be `FPGA_INTEGRATED_DEVICEID != value`?", + "reference": "Shouldn't the operator be && ?" + }, + { + "prediction": "Line is too long. [83/80]", + "reference": "My best guess is that you want to use host.name in these parts to get the name of the host ?" + }, + { + "prediction": "I think we can remove this line now, since we don't persist the root nodeType when we marshal the manifest, as a result the root nodeType information is lost on Unmarshal.", + "reference": "IMO this edge case handling could remain here, just instead of overwriting the `n.nodeType`, the `makeEdgeType` method of `n` should be called, so `n.nodeType = nodeTypeEdge` -> `n.makeEdge()`" + }, + { + "prediction": "I think this should be `&& showAutoDownloadReport` instead of `&& (UserPreferences.showDownloadReport() || showAutoDownloadReport)`", + "reference": "Just wondering... The two kinds of notifications are now quite different (Channel, text, maybe even icon). Would it make sense to extract the auto download notification to a new class instead of handling everything in the existing `notificationManager`? I have not checked if this will lead to a lot of code duplication, though." + }, + { + "prediction": "This is a bit of a hack, but I think it's the only way to get the features of the call object without having to call `c.ic.req.RequestFeatures()`. I'm not sure if there's a better way to do this, but it seems like it should work.", + "reference": "Do we need to put this on the Call? We only need the API communication between the Encoding and the Transports which is currently done through the Transport.Request. The Call is used by users right?" + }, + { + "prediction": "I'm not sure if this is the best place to put this, but it seems like it would be a good place to start.", + "reference": "`ctx` is unused in GenerateAPIKey" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it's the only thing I could come up with.", + "reference": "Can you judge the type of error?" + }, + { + "prediction": "I think this should be `data[:-1] + (np.diff(data) / 2.)` instead of `data[:-1] + np.diff(data) / 2.`", + "reference": "Much simpler than a weird and confusing ``convolve`` call!" + }, + { + "prediction": "I'm not sure if this is correct, but I think it should be called twice because we have two instances of the `render` method.", + "reference": "Huh, this seems weird to me... Surely the suspenders render was called again in order to get the new `
Hello second 2
` output... Imma take a peak at these tests to understand what's going on" + }, + { + "prediction": "I think this should be called `success_message` instead of `success_message_error`", + "reference": "Since this is just a helper function to create text, perhaps this could live in a helper? I noticed that we have a few other error/message creators in the application controller as well, but I think this type of function should be re-factored to be part of a helper." + }, + { + "prediction": "I don't think this is the right way to do it. It's not a template, it's a single line message.", + "reference": "Will this mess up parsing the messages by other editors? (vscode, vim ...)" + }, + { + "prediction": "Line is too long. [83/80]", + "reference": "Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it's the only way I could get this to work.", + "reference": "Why can the pool be null?" + }, + { + "prediction": "I think this is the only place where `ia2Web.Ia2Web` is used, so I think it should be `ia2Web` instead of `ToggleButton`.", + "reference": "It might be good to have a note here: > work-around for issue #7562 allowing us to differentiate presentational lists from interactive lists (such as of size greater 1 and ARIA list boxes). In firefox, this is possible by the presence of a read-only state, even in content editable." + }, + { + "prediction": "I don't think this is the right place for this change. The `DigraphNode` class is used to represent a node in a directed graph. The `DigraphNode` class is used to represent a node in a directed graph. The `DigraphNode` class is used to represent a node in a directed graph. The `DigraphNode` class is used to represent a node in a directed graph. The `DigraphNode` class is used to represent a node in a directed graph. The `DigraphNode` class is used to represent a node in a directed graph. The `DigraphNode` class is used to represent a node in a directed graph. The `DigraphNode` class is used to represent a node in a directed graph. The `DigraphNode` class is used to represent a node in a directed graph. The `DigraphNode` class is used to represent a node in a directed graph. The `DigraphNode` class is used to represent a node in a directed graph. The `DigraphNode` class is used to represent a node in a directed graph. The `DigraphNode` class is used to represent a node in a directed graph. The `DigraphNode` class is used", + "reference": "This set of changes is the one part of this that I'm not completely sure is valid. Can someone look over this to make sure I got the E's right?" + }, + { + "prediction": "I'm not sure this is the right fix. The problem is that `frontier_pulls` is a `std::list` and `push_back` is a `std::insert`. The latter modifies the list in-place, so the `frontier_pulls` size doesn't change. I think you need to use `std::unique_ptr` and `emplace_back`.", + "reference": "There doesn't seem to be a reason to copy this here." + }, + { + "prediction": "I think this file should be moved to `h2o/common/include/h2o/ebpf.h`", + "reference": "We've avoided including h2o headers in BPF programs because it's a runtime dependency. However, IIRC, this is because h2olog was maintained in the separate repository so that h2olog did not know where h2o was installed. Now h2olog can use `H2O_ROOT`, we should add it to BCC's `cflags` in order to include h2o headers in BPF programs." + }, + { + "prediction": "I think we should rename this to `AlertQueryURL` to be consistent with the rest of the ruler.", + "reference": "I think the docstring here should include the CLI arg `--alert.query-url` just to make it clear to users which setting this uses." + }, + { + "prediction": "I think we can remove the `externalNodeCIDRs` field from the `ipipManager` struct.", + "reference": "Same change just above?" + }, + { + "prediction": "I think this test is not necessary, as we have a test in `syncTables` that checks if notes are synced correctly.", + "reference": "Could you check the result content rather than just the number of search results please? For example with this test if the search engine suddenly starts returning \"latin n\" for both queries, we won't know about it." + }, + { + "prediction": "I think this should be `agentlessID` instead of `agentID`.", + "reference": "nit: I think that `workloadID` should suffice for this test... that's what we'd be issuing anyways" + }, + { + "prediction": "Layout/TrailingWhitespace: Trailing whitespace detected.", + "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." + }, + { + "prediction": "I think it would be better to catch `NoClassDefFoundError` instead of `ClassNotFoundException` as it is more specific.", + "reference": "We should have a rule to detect identical catch branches" + }, + { + "prediction": "I think we can remove the `RetryAttempts`, `RetryDelayInSeconds`, and `MaxClients` properties from this class.", + "reference": "remove these from the targets file." + }, + { + "prediction": "I'm not sure about this change. I think it's fine, but I'm also not sure about the other changes in this file.", + "reference": "now that we have the signature in the hive messages, it might be that this must be drastically reduced, since there are limits on the protobuf reader/writers i believe" + }, + { + "prediction": "I think we can remove `google-auth==1.6.2` now that we are using `google-auth-httplib2==0.0.3`", + "reference": "I recommend that we move this to be optional, as other users might not need it. Can you look at `OPTIONAL_PACKAGES` section, around line 68?" + }, + { + "prediction": "I don't think you need to import `*`. You can just use `Collections.emptyIterator()`, `Collections.emptySet()`, `Collections.emptyMap()`, etc.", + "reference": "I usually set idea to never use wildcard import such as `import java.util.*;` Now i use setting from javaslang standard." + }, + { + "prediction": "Line is too long. [83/80]", + "reference": "Where is host['ips'] coming from?" + }, + { + "prediction": "I think we can remove the `FuzzUIDMap` function now.", + "reference": "oh! missed a `:` here; let me fix that; also can get rid of the intermediate variable" + }, + { + "prediction": "Metrics/LineLength: Line is too long. [122/120]", + "reference": "Is this necessary?" + }, + { + "prediction": "I think we can remove the `header` and `footer` components as they are no longer used.", + "reference": "I'd create a different method for each render section." + }, + { + "prediction": "nit: can we rename this to `wasReverted` or `wasRevoked` or something similar?", + "reference": "Instead of storing the revert flag in the tracer is it possible to use org.hyperledger.besu.ethereum.mainnet.TransactionProcessor.Result#getRevertReason? (via org.hyperledger.besu.ethereum.transaction.TransactionSimulatorResult#getResult)? If a TX reverts without a reason do we get an empty revert reason or a revert reason with zero bytes?" + }, + { + "prediction": "I think we can remove the `SparkOrcReader::new` method and just use `readOrcSchema` in the `SparkOrcReader` constructor.", + "reference": "I think this should test with and without container reuse if that is implemented in this PR. Probably just make this test parameterized." + }, + { + "prediction": "I don't think we need to do this. The `ManifestFile.SPEC_ID` field is only used in the `ManifestFile` constructor, so it should be available there.", + "reference": "These modifications allow BaseFile to translate into a SparkRow with the specID as a column" + }, + { + "prediction": "I think this should be `typeof readPreference === 'object' || readPreference instanceof ReadPreference`", + "reference": "is this something we've been missing this whole time?" + }, + { + "prediction": "I think this should be `*` instead of `allEvents`.", + "reference": "nit: this is a package-wide constant so better to narrow the scope like `allEventsSign`." + }, + { + "prediction": "I think this should be `auth_cmd = ['thrift', '-r', '-I', '.', 'gen', 'py', auth_thrift]` instead of `auth_cmd = ['thrift', '-r', '-I', '.', 'gen', 'py', auth_thrift]`", + "reference": "There seems to be some repetition. Does a local function make this code shorter overall?" + }, + { + "prediction": "I think we can remove the `isHydrating` variable now that we don't need to keep track of whether we're hydrating or not.", + "reference": "Might be cheaper to reuse the `null` assignment of line 313 and set `isHydrating` to null instead WDYT?" + }, + { + "prediction": "Why was this removed?", + "reference": "Revert this blank line" + }, + { + "prediction": "Why are we clearing these here?", + "reference": "This was introduced recently for the Hadoop 3 upgrade. Copy/paste error but definitely causing some of the new test failures." + }, + { + "prediction": "Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.", + "reference": "I think we should only need to do this for `:approve` since we are using `authenticate_user!` for all other actions and that checks for disabled client" + }, + { + "prediction": "I don't think this is the right place to put this test. I think it should go in `test_webapi.py`", + "reference": "I wonder if we should create new tests for header checks; here for instance we're mixing querystring and headers. Thoughts?" + }, + { + "prediction": "I'm not sure this is the right place for this task. I think it should go in `lib/tasks/apply_helpers.rb`.", + "reference": "We should be able to add sensitive by hard-coding the parameters, same as you put into the metadata in apply_helpers." + }, + { + "prediction": "Why do you need this?", + "reference": "Why do you think that it is necessary to create this class?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `aws-sdk-go-amazon-ec2` package, since that's where the `aws-sdk-go` package is.", + "reference": "replacing the `1` with `io.SeekCurrent` may be good here" + }, + { + "prediction": "I'm not sure if this is the right place for this interface. I think it should be in `gopkg.in/square/go-jose.v2/src/jose/rsa.go`", + "reference": "nit: perhaps this file would be better named `jwks_source.go` ?" + }, + { + "prediction": "I think this should be `PARAM_OVERRIDE_FILE_NAME`", + "reference": "It will be helpful to specify the intended priority as well for the properties within this file." + }, + { + "prediction": "I think this should be `Run func(*exec.Cmd) ([]byte, error)`", + "reference": "Make this private and update all the public functions to not take this argument. The variable you set below should also be private, then in the tests instead of passing the variable in to the function just update the variable. We don't want to expose the testing implementation in the public api if it can be avoided." + }, + { + "prediction": "I think this should be `hive/tpcds/trafodion/customer/customer.dat`", + "reference": "Do you now why is it a specific table name is used as a default?" + }, + { + "prediction": "I'm not sure this is the right place to put this. I think it should be in the `if (DirExists(\"/home/DDITAdministrator/myagent/_work/_temp\"))` part of the if statement above.", + "reference": "If all you're doing is checking for the existence of a directory as your \"temp\" directory, why does it matter what OS you're on?" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it's the only way I could get it to work.", + "reference": "nit- would be cleaner to import it once" + }, + { + "prediction": "I don't think this is necessary. The `x-amz-*` headers should be added to the `Access-Control-Allow-Headers` header.", + "reference": "Looks like there is a closing parenthesis `)` missing here." + }, + { + "prediction": "I'm not sure this is the right fix. The problem is that the `error->all(FLERR, str);` is only used to print an error message. It doesn't actually change the value of `error->err` or `error->errstr`.", + "reference": "this one bothers me. There are many places where this one is written to for an error message and just a single callsite is changed." + }, + { + "prediction": "I think we can remove this test now.", + "reference": "You can put this in `kbfsOpsInit()` in you want, so we don't have to call it in every test." + }, + { + "prediction": "I think this should be ARM64 instead of ARM_32.", + "reference": "`ARM_32` is what clients define as an input to DR, and is not always defined internally: we use just `ARM` to mean AArch32." + }, + { + "prediction": "I think this should be `originalSchema` and not `schema`.", + "reference": "s/for use/to use for/" + }, + { + "prediction": "I think this should be `$event->getAvatarId() ? $event->getAvatarId()->getValue() : $event->getAvatarFilename() ? $event->getAvatarFilename()->getValue() : null;`", + "reference": "` $event->getAvatarFilename()` this function return `string` or `null`. In this place ` $event->getAvatarFilename()->getValue()` return `Fatal error `" + }, + { + "prediction": "I think this should be `ErrPersistenceLimitExceeded` and not `ErrPersistenceMaxQPSReached`.", + "reference": "why not creating a new error type for server's own resource limit exceed error and do conversion within rpc interceptor?" + }, + { + "prediction": "I think this should be `Propagators.DefaultTextMapPropagator` and not `Propagators.DefaultTextMapPropagator`", + "reference": "Could be a timing thing here. When options are created they'll copy the ref for the current default propagator. If user sets through SDK the global propagator after that, it won't be reflected. Could leave it null here and then when it is used in instrumentation do `options.Propagator ?? Propagators.DefaultTextMapPropagator`. It would be a slight perf hit but it makes it hot-swappable." + }, + { + "prediction": "I think it's better to remove this empty line.", + "reference": "Unrelated file. Please remove from PR." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `else` branch of the `else` above.", + "reference": "Careful: you only want two newlines after the final header message. (That indicates the end of headers and the start of data.)" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `if flow.request.method == 'GET'` block, since we don't want to force an upgrade if it's a GET request.", + "reference": "This will not work on Python 3 (to which we are transitioning) because `.content` is bytes, not a str. Can you make the pattern a bytes object as well (like so: `b\"pattern\"`)?" + }, + { + "prediction": "`requiredOwned` and `requiredAttrs` should be renamed to `requiredAttributes` and `requiredAttrsList` respectively.", + "reference": "This was to allow the tests to pass when the order of the required was different. Silly, but we don't have an easy way to check for \"equal but order doesn't matter\" in chai." + }, + { + "prediction": "This should be `static const CostMethodHbaseDelete *m = NULL;` instead of `static THREAD_P CostMethodHbaseDelete *m = NULL;`", + "reference": "maybe say \"returns the default cost method that returns an object of cost 1\"." + }, + { + "prediction": "I think we can drop this rule now, since we don't need to support VXLAN traffic anymore.", + "reference": "I believe these rules will be enforced both (1) on egress from a local workload, and (2) on ingress **to** a local workload. Right? I understand that we definitely want (1), but do we really want to enforce (2) as well?" + }, + { + "prediction": "I think this should be `callbackContext.error(response.asString() + \"\\n\" + response.fullResponseAsJSONObject());`", + "reference": "Use `response.asJsonObject()` instead. Also, use `put()` instead of `putOpt()`, `null` as a value is fine." + }, + { + "prediction": "`expect(editor.is(':visible')).toBe(true);` should be `expect(editor.is(':visible')).toBe(true);`", + "reference": "Are you sure? We've changed it during an introduction of the IME support." + }, + { + "prediction": "I think it would be better to use `null !== $dqlFilter` instead of `empty($dqlFilter)`.", + "reference": "I think here we want the use of `empty()` to take care of empty strings. If you put `dql_filter: ''` in your YAML config ... this will add `->andWhere('')` and it will fail, right?" + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think it should be in the `if p2pMsgLatency > 0` block, but I'm not sure if that's the right place to do it.", + "reference": "this is golang's named return, err is defined, `return` is equivalent to `return err` the current code has no problem" + }, + { + "prediction": "I think it would be better to use a `char *` instead of a `char * (out)`.", + "reference": "I don't think this is right; in Rust terms it's like a `&mut String`, in Java `StringBuilder` - it's not a return value from the function which is what `(out)` is for." + }, + { + "prediction": "`>= 0` and `<= label_channels` can be replaced with `torch.clamp(labels, max=0, min=label_channels)`.", + "reference": "If the label is not binary, should we rename this function?" + }, + { + "prediction": "I think it would be better to use `os.path.join` instead of concatenation.", + "reference": "This is very-very bad idea because of its performance impact" + }, + { + "prediction": "I think we can remove this file now.", + "reference": "WHY U NOT SORT IMPORTS?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `sign_up_helper.rb` since it's only used for sign up.", + "reference": "Put a comma after the last item of a multiline hash." + }, + { + "prediction": "I think this should be `Dimension, Dimensioned` to be consistent with the rest of the docstring.", + "reference": "How come we need ``Dimensioned`` in the top-level namespace?" + }, + { + "prediction": "I'm not sure if this is the best tags to use here, but it's the only one I could think of.", + "reference": "excess whitespace through plugin." + }, + { + "prediction": "`std::size_t` should be `unsigned`", + "reference": "What is the problem here? I feel we used this in a lot of places." + }, + { + "prediction": "do you need to return a list here?", + "reference": "Update the docstring." + }, + { + "prediction": "nit: remove empty line", + "reference": "delete the empty line \"github.com/pkg/errors\" should be grouped with other third party packages same for the rest" + }, + { + "prediction": "I think this should be `this.capabilities = capabilities == null ? new ImmutableCapabilities() : capabilities;` instead of `capabilities = capabilities == null ? new ImmutableCapabilities() : capabilities;`", + "reference": "Assigning capabilities to the field here is not the best idea. Semantically this field contains the capabilities returned by the browser after session start. So here we sould better amend capabilities and return them from `init` method to pass later to `startSession` method (that will assign the capabilities returned by the browser to the field)." + }, + { + "prediction": "I'm not sure why this was here in the first place, but I think it's no longer needed.", + "reference": "Is this a breaking change, or is the API private?" + }, + { + "prediction": "I think this should be `import pandas as pd; test_data = pd.read_json(\"./dumps/courseData.json\");`", + "reference": "I don't think we need this dependency in this project right now" + }, + { + "prediction": "I think this should be `cloud-run-events-broker` and not `cloud-run-events`", + "reference": "I don't think this is necessary since `CommonLabels` is a public func and every component name is also public constant." + }, + { + "prediction": "I think this should be `[\"rb\", \"-r\", \"puppet\"]` instead of `[\"/usr/bin/ruby\", \"-r\", \"puppet\"]`", + "reference": "The `_example` field should be updated to include an interpreter with an array value." + }, + { + "prediction": "I'm not sure if we want to do this, but I think it's fine for now. We'll need to update the `supportedProtocols` variable in `caddyhttp/fastcgi/fastcgi.go` as well.", + "reference": "Put this in the godoc of SupportedProtocols instead. Preferably we would just use one map though. Why not just use this one?" + }, + { + "prediction": "I think this should be `DockerID: dockerID,` and not `dockerID: dockerID`", + "reference": "I'd feel a little safer if the first argument were a string, not a *string unless there's a particular reason for making it a pointer." + }, + { + "prediction": "I don't think this is the right place for this test. It should be moved to `org.sonar.plugins.java.api.tree.AssignStmtTree`.", + "reference": "Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC." + }, + { + "prediction": "I think this import should be removed.", + "reference": "You can safely revert changes to this file." + }, + { + "prediction": "I think you can drop the `num_total_samples` from the `loss_single` function.", + "reference": "This deletion is unnecessary." + }, + { + "prediction": "I don't think this is the right way to do this. The problem is that the `img` tag is not an AMP element, so it doesn't have a `alt` attribute. I think we need to find a way to get the `alt` text from the `smallImage` prop and use that instead of the `alt` from the `img` tag.", + "reference": "I'm not a huge fan of this overloading of the prop; accepting very different types of arguments for props like this can be confusing, and wasn't part of the IB. I understand wanting to import the SVG directly, but the IB suggests using `${global._googlesitekitLegacyData.admin.assetsRoot}${userInputSuccessImage}` as the `src`/`smallImage` value here. It'd be great to refactor this to accept components directly in the future, but let's do that all-at-once rather than this hybrid approach that makes the API less clear." + }, + { + "prediction": "nit: remove asterisk imports.", + "reference": "I've had this happen recently with IntelliJ, was this intentional?" + }, + { + "prediction": "I think this should be `std::unordered_map` instead of `std::unordered_map`", + "reference": "Order(1) vs Order(logN) -- not sure it's measurable at the ~200 element size of the table. All of the published comparisons start at ~1000 elements." + }, + { + "prediction": "I think this should be `location_factory` and not `location` factory.", + "reference": "I don't know about this aliasing and 'factory'. Previous version was rather straightforward: `location.CreateLocationResolver`. Perhaps `location.CreateResolver` would be even better? What do we actually gain here from moving DI to a separate sub-package?" + }, + { + "prediction": "This should be `throw std::runtime_error(\"ERROR: Engine bass class \" + func + \"() called. \" + engineType + \" child class is not implementing this function\\n\");`", + "reference": "Use `UpperCamelCase` for function names" + }, + { + "prediction": "I think this should be `value instanceof Date` instead of `typeof value === 'string' && !isNaN(Number(value)) && (Number(value) >= 275761 || Number(value) < 0)`", + "reference": "I'm not 100% sold on this idea but I like it in general. Nice compromise between using the 'Date' constructor where possible and falling back to the pre #5880 behavior when it makes sense. However, instead of `Number(value) < 0`, let's do `Number(value) < MIN_YEAR` because `new Date('-2017')` is perfectly valid in JS and I don't want to break the date behavior." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `ClusterState` class.", + "reference": "Remember to close SOLR-11877 after this" + }, + { + "prediction": "I think this should be `||` instead of `||`", + "reference": "this change should be reverted" + }, + { + "prediction": "Why is this needed? I don't see it being used anywhere.", + "reference": "This function signature is a bit complicated, some parameters are IN type (stopLoop which is modified from outside), others are OUT (registeredEvent channel which is modified inside function) I suggest the following signature -> SubscribeToRegistrationEvent(identityAddress) returns registeredEvent chan of type (RegisteredEvent not int), Unsubscribe func(), error (in case of any error). That way caller can always cance subscription if needed and check for any errors. Also - unsubscribe function hides any internal details how subscribtion is really implemented" + }, + { + "prediction": "I think it would be better to have a separate query for `src/**/*.wav` and `src/**/*.mp3` and `src/**/*.ico` and `src/**/*.gif` and `src/**/*.svg` and `src/**/*.jpg` and `src/**/*.png` and `src/**/*.js` and `src/**/*.css` and `src/**/*.json` and `src/**/*.min.js` and `src/**/*.min.css` and `src/**/*.min.json` and `src/**/*.min.css` and `src/**/*.min.html` and `src/**/*.min.mp3` and `src/**/*.min.webm` and `src/**/*.min.webp` and `src/**/*.min.svg` and `src/**/*.min.wmf` and `src/**/*.min.wmf.gz` and `src/**/*.min.webm` and `src/**/*.min.webp` and `src/**/*.min.mp4` and `src/**/*.min.mp3` and `src/**/*.min.webm` and `src/**/*.min.mp4` and `src/**/*.min.ts` and `src/**/*.ts` and `src/**/*.txt` and `src/**/*.css` and `src/**/*.js` and `src/**/*.html` and `src/**/*.min.js` and `src/**/*.css` and `src", + "reference": "`.wav`?! cannot we use something slightly more modern and compressed instead? :) I dunno, like `.mp3` or `.aac` or `.ogg`..." + }, + { + "prediction": "I don't think this is the right place to emit this. It should be in the `swap` class, not the `client` class.", + "reference": "Wouldn't a single signal call be enough? (without the boolean even)" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "I suspect that this whole block, which is going to be repeated a number of times, should probably be in a helper. I guess it would need to be given the object and the title and could probably figure out everything else from that?" + }, + { + "prediction": "I think this should be `attr_reader :path_resolver`", + "reference": "Should we expose this attribute in the Asciidoctor.js API ?" + }, + { + "prediction": "I'm not sure this is the right place for this method. I think it should go in `Traversable` since it's related to traversal of the multimap.", + "reference": "I think contains on `Multimap` was broken - it should return true if one of the values is associated with the key? It that right" + }, + { + "prediction": "I think this should be `DEF_KV_CONCURRENCY` and `DEF_ISOLATION_READ_ENGINES` should be `DEF_KV_ISOLATION_READ_ENGINES`", + "reference": "delete this line" + }, + { + "prediction": "I think this should be `conn.table_exists? \"test_client_requests\"`, not `return if conn.table_exists? \"test_client_requests\"`", + "reference": "Presumably we no longer need `force: true` here." + }, + { + "prediction": "I'm not sure this is the right place to do this check. I think it should be done in `hipHostAlloc` and `hipHostMalloc`.", + "reference": "HIP runtime is compiled using a C++ compiler. So comparison to both NULL as well as 0 does not make sense. Just comparing to NULL is sufficient." + }, + { + "prediction": "I'm not sure if this is the best place to put this, but it seems like it would be a good place to start.", + "reference": "these urls are still in `a` tags so we should probably include these links separately for a non-HTML version" + }, + { + "prediction": "I think this should be `s.mu.Lock()` instead of `s.mu.Unlock()`", + "reference": "That's fine though, meaning that you can send to this channel under the server lock. The internalSendLoop will pick up the change when the server lock is released (if loop is blocked trying to grab the server lock). Even the way you do it here (releasing the lock, sending, then reacquiring) does not guarantee that the internalSendLoop will have time to refresh in that interval." + }, + { + "prediction": "I think this should be renamed to `ENABLE_CHROMIUM_DOWNLOADING`", + "reference": "The name `enableDownloading` implies this is a boolean capability. How about `downloadDir`?" + }, + { + "prediction": "I think this method should be renamed to `getValidator` or `getValidatorForProject`.", + "reference": "Found one internal team is using this method. Will coordinate with them about the migration solution." + }, + { + "prediction": "I don't think we need to add this to the docs, since it's only used in one place.", + "reference": "The field `HttpServerErrorCodes` should be called `HttpServerErrorStatuses`" + }, + { + "prediction": "nit: I think we should move this to the top of the file, so that it is visible to the user of the file.", + "reference": "Can you please make each of these in a separate line. It will be easier to keep them sorted, and add/remove." + }, + { + "prediction": "I think this should be `req.getParams().getBool(ConfigSetParams.CLEANUP, false)` instead of `req.getParams().getBool(ConfigSetParams.OVERWRITE, false)`", + "reference": "should we error instead of silently ignoring the `cleanup` param? it defaults to `false`, so someone must have explicitly set it to `true`" + }, + { + "prediction": "I think this should be `fmt.Errorf(\"archive root directory missing: expected a 'root' directory but got %q\", archive.File[0].Name)`", + "reference": "There is no specific requirement that the root be called `root`, just that there is a single root directory and that it be the first entry in the zip." + }, + { + "prediction": "I think this should be `!current_page?(user_path) && current_user` instead of `!current_page?(me_path) && current_user`", + "reference": "perhaps we should encapsulate this logic in a helper method w a test?" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Now that we're only using this repo as a Gem you shouldn't need to `require` an expanded local file path like below." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in `Timestamps.java` since it's only used in that class.", + "reference": "This isn't necessarily a year. It may be months, days, or hours. Can we return `intValue()` directly instead?" + }, + { + "prediction": "I think we can remove this too.", + "reference": "this is redundant because it gets logged immediately on entering the handleContainerChange function" + }, + { + "prediction": "I think this should be `e := \"EVENT_\" + v.Event; e == model.NotificationEventType_EVENT_DEPLOYMENT_WAIT_APPROVAL.String() {`", + "reference": "`ds.GenericDeploymentConfig.DeploymentNotification` in L128 is nullable." + }, + { + "prediction": "I think this should be `getProtocolContext()`, not `getProtocolContext().get()`.", + "reference": "this shouldn't be exposed here - this class isn't a carriage for this - its used internally to determine if/how we can mine." + }, + { + "prediction": "I think this should be renamed to `uninstallExtensionAsync`", + "reference": "It's fine to leave these checks in. It'll make the exception come from `FirefoxDriver`, and that's probably clearer to a user." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I've been able to get this to work.", + "reference": "We don't want to include the `IntegrationSpecHelper` for models...mind moving this line out of the loop to be `config.include EnvironmentSpecHelper, type: :model`?" + }, + { + "prediction": "I think this should be `0755` instead of `0666`.", + "reference": "Please check the return on these." + }, + { + "prediction": "I'm not sure this is the right way to do it. I think we need to make sure that the tarball is created in the cache first, and only if it isn't, then add it to the local storage. Otherwise, if the tarball is already in the cache, then the local storage won't be able to find it.", + "reference": "Do we need `==` for true?" + }, + { + "prediction": "I think it should be 0.0001.", + "reference": "Changing the default value may cause BC-breaking. Suggest changing this value in config." + }, + { + "prediction": "I think this should be `int(slider_pos / len(FEE_ETA_TARGETS) + 0.5)`", + "reference": "how does that happen?" + }, + { + "prediction": "doctests are not supposed to be run as part of the unit tests.", + "reference": "This is gross/clever. :-)" + }, + { + "prediction": "Line is too long. [83/80]", + "reference": "Take a look at the name of this file. Definitely copy and" + }, + { + "prediction": "I think we can remove this line.", + "reference": "Can you check with @mahebbar how to work this error. Should be different from 404." + }, + { + "prediction": "I don't think this change is needed.", + "reference": "Do we still need the upper bound `<3.9`?" + }, + { + "prediction": "I think this should be `realpath($input_path) === realpath(dirname(__DIR__, 2) . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'psalm')` and not `realpath($input_path) === realpath(dirname(__DIR__, 3) . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'psalm')`", + "reference": "Does this mean `vendor/bin/psalm` is not a symlink (or whatever equivalent Windows has for symlinks) on Windows?" + }, + { + "prediction": "I think this is a leftover from the previous commit.", + "reference": "@lpabon having a separate package name `aws_test` allows to test the package as if the tester was an external package. If the test package name is the same as the package being tested, the test package can also use methods and variables not exposed to the eventual user." + }, + { + "prediction": "I'm not sure if this is the right place to put this. I think it should be in `test/integration`", + "reference": "The exporter should still be able to test these histogram instrument kinds, right? Is there another reason to remove these?" + }, + { + "prediction": "I think this should be `resetTxnBytes` instead of `ResetTxnBytes`.", + "reference": "should this increment eval.Round somehow?" + }, + { + "prediction": "I'm not sure if this is a good idea, but I don't have a good idea of what the best way to do this is.", + "reference": "Although this change looks good. Maybe there are other inconsistent cases too?" + }, + { + "prediction": "I'm not sure this is the right place for this helper. It's used in `layouts/application.html.erb`, which is the main application template, but this helper is only used in `layouts/teams.html.erb`, which is the template for the teams landing page. I think it would be better to move this helper to the `application_helper.rb` file, which contains all of the common helper methods used throughout the application. What do you think?", + "reference": "This is a way better method name." + }, + { + "prediction": "I think we can remove this notice altogether since we're not using it anywhere else in the codebase.", + "reference": "Prefer single-quoted strings when you don't need string interpolation or special symbols." + }, + { + "prediction": "I think this should be `options = isArray(options) ? options.slice() : [];`", + "reference": "I was wondering if this should allow per role specification, instead of (or in addition to) a generic \"allowed everywhere\". So you could do: `{ separator: ['aria-valuenow', 'aria-valuemin', 'aria-valuemax'] }`. You could still allow the array, and you could add a wildcard option for the \"generic\" case you've got now: `{ '*': ['always-allowed'] }`." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `NABasicObject` since that's where the `NABasicObject` type is defined.", + "reference": "I'm confused by the name. The string was a Hive string but it isn't any longer? Why should we care? (I imagine I'll find the answer later... there is some different semantic that we want downstream...)" + }, + { + "prediction": "I don't think you need to import * here.", + "reference": "Could you please leave the explicit imports?" + }, + { + "prediction": "I think we should rename this package to `proto` instead of `protoproto`", + "reference": "Why need alias?" + }, + { + "prediction": "I think this should be `nil` and the `tlfIDGetter` should be `testTLFJournalConfig.GetTlfID`", + "reference": "Shouldn't this be a `libfs.nullIDGetter` (exported, of course)?" + }, + { + "prediction": "I'm not sure if we should be using these functions here. I think we should be using the ones in `pkg/logicsig` and `pkg/app` instead, but I don't know if we should be using them at all.", + "reference": "I dislike the messages.go pattern; the strings are only used once and make more sense in context. The other two added reportErrorf() calls in clerk.go have inline strings." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in `TagNameSet::add`", + "reference": "Seems we don't need it anymore." + }, + { + "prediction": "I'm not sure this is the right place to validate the `published` field. I think it should be in the `GuidingTopic` model, since that's where the `published` field is set.", + "reference": "This might cause problems with the weird way we publish Guidance and Groups in the UI. We will have to make sure that UAT is thorough." + }, + { + "prediction": "I'm not sure this is the right default. I think it should be `time.Minute` or `time.Second` depending on what you want it to be.", + "reference": "this default needs to be on order 1 minute, I'm not sure why we defaulted to 1 hour below..." + }, + { + "prediction": "I'm not sure if this is the best place to do this. I think it would be better to do this in the `ACMEConfig` module, since that's where the challenges are loaded.", + "reference": "I figure to make `{env.*}` work, right? I can't think of any other placeholder that makes sense here" + }, + { + "prediction": "I think this should be `network::NetworkUtils::getAvailablePort()`, not `network::NetworkUtils::getAvailableLocalPort()`.", + "reference": "Why change the port from 0 to getAvailablePort()?" + }, + { + "prediction": "I think this should be `30.000000000000004`", + "reference": "For me would be great don't repeat timeout sending in every get_locator call. Looks like it should be sent into LocatorsManager init. And possibly it should me non mandatory, something like that: `def __init__ (self, locators, timeout=60):`" + }, + { + "prediction": "nit: I think we can remove the `NewGlobalOpts` constructor and just use the `New` method directly.", + "reference": "I feel like since now we don't initiate the `opts.projectName` with `opts.ProjectName()`, which means `opts.projectName` and `opts.ProjectName()` they don't necessarily equal to each other, we need to also substitute all usage of `opts.ProjectName()` within `Ask()`, `Validate()`, and `Execute()` to `opts.projectName`. Otherwise if `-p` is set, `opts.ProjectName()` will get expired." + }, + { + "prediction": "I don't think we need to check for null here.", + "reference": "why do we thinkg that an empty string is ok to return from this method? I think the null should never be passed in here in the first place" + }, + { + "prediction": "I don't think this is the right way to do it. The idea here is that if there are multiple nodes with the same actual node, we want to return the one that is closest to the node we are looking for.", + "reference": "nit: can remove this `else` since we return from the condition above." + }, + { + "prediction": "I think we can remove the `default(CancellationToken)` argument from the `WriteAsync` method as well.", + "reference": "You missed `Write(...)`! I'm kidding ofc." + }, + { + "prediction": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", + "reference": "Was there a customer who had this set to an empty string?" + }, + { + "prediction": "I'm not sure this is the right place for this method. I think it should be in `Ncr::Approvals::ApprovalsController` since it's only used there.", + "reference": "I know we have the `reporter` spec below, but what about a unit test for this to explain reasoning behind logic? If I were going to update this decorator, I would assume it wasn't covered by tests because there is no unit test." + }, + { + "prediction": "`attach` is not used in this PR, so I think we can remove it.", + "reference": "it's better to be : void attach(String name, Part part);" + }, + { + "prediction": "I don't think we should change the signature of the `initDefinitionLevelsReader` method.", + "reference": "I didn't see where the IOException can get thrown, is this just to match the V1 reader?" + }, + { + "prediction": "I think this should be `bool weightDistMat` instead of `bool forceRDKit)`.", + "reference": "We normally suppress this warning with `RDUSED_PARAM(forceRDKit)`" + }, + { + "prediction": "This should be `auto it = mappedPlayerGuids.find(guid); if (it == mappedPlayerGuids.end()) return nullptr; return it->second;`", + "reference": "What if `Game::getPlayerByNameWildcard` had not been called before. It would not find a player, wouldn't it?" + }, + { + "prediction": "I think this should be `patchRequired` instead of `requiresPatchCheck`.", + "reference": "Why upper case \"R\"?" + }, + { + "prediction": "I think we can remove this function now, since it's no longer used.", + "reference": "Does this need to return an error or could it return `false, nil`?" + }, + { + "prediction": "Why is this protected? It looks like it should be `public` by default.", + "reference": "Can you not change those scopes in public API classes? This applies here and in other places -- protected changed to package-scope for source is not really an API-compatible change." + }, + { + "prediction": "Why do you need this?", + "reference": "this parameter is only used in POST, please use `getRequest()->request->get('...');` Thanks" + }, + { + "prediction": "I think this should be `filename` instead of `filename`", + "reference": "Problem number 1: Scoped packages would have a `/` character here. Changing this to `validatePackage` resolves the 403." + }, + { + "prediction": "I think this should be `except KeyError as e: deep_mapped[k] = e` instead of `except Exception as e: deep_mapped[k] = e`", + "reference": "I don't quite get why there would be key errors: ``deep_mapped`` is a clone of ``self`` and ``k`` comes from ``self.items()`` so why would the key ever be rejected?" + }, + { + "prediction": "I think we can remove the `chainID` parameter from the `withdraw` method, since we don't use it anymore.", + "reference": "this chain ID determines only from which chain to withdraw, therefore your changes do not accomplish what you want them to accomplish. You'll need changes to `func (aps *hermesPromiseSettler) Withdraw(chainID int64, providerID identity.Identity, hermesID, beneficiary common.Address) error`. The method probably has to include two chain ids: to and from. Currently, the method internally uses: `aps.config.L1ChainID` -> the chain to withdraw to `chainID` -> the chainID that was passed as the chain that the withdrawal is originating from." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `trace` package.", + "reference": "If instead we had `TraceContext.extract` return a bool value as a second return value, we could avoid the byte array comparison in `TraceID.IsValid`. Did you consider that alternative?" + }, + { + "prediction": "`paginated` should be a `const bool` parameter.", + "reference": "here shouldn't we use `depotFreeLimit`?" + }, + { + "prediction": "I'm not sure this is a good idea, but I can't think of a better way to do this.", + "reference": "Could we use the Rails application's secret token instead? Do we actually need our own here?" + }, + { + "prediction": "I think it would be better to use `kdf.groupby(['a', 'b'], axis=1)` instead of `kdf.groupby('a', 'b')`", + "reference": "so should be fixed here also" + }, + { + "prediction": "I think this should be `dmc->size == sizeof(dr_mcontext_t) - sizeof(dr_opmask_t) - 1`", + "reference": "I would just remove this assert as it's going to get un-maintainable with a long list of valid sizes. Ditto below." + }, + { + "prediction": "I think this should be `/var/lib/ecs/data/`", + "reference": "`HostDataDir` is misleading. Can we rename it to something more relevant ? The constant should also be moved up and reused as necessary." + }, + { + "prediction": "I think this should be 36. The overhead of the ESP packet is 36 bytes, including the ESP header and trailer.", + "reference": "I still feel like we are double-counting the outer IP header here (once in `defaultMTUGRE` and once in `ipsecESPOverhead`) but I'm not that familiar with IPsec." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `System.Diagnostics.Metrics`", + "reference": "Not sure what benefit we gain by extending BaseProcessor here, as this seems to be defining a new OnEnd method. Could we modify MeasurementItem to have all the things, and then MeasurementProcessor can be simply extending BaseProcessor (not blocking. just noting some observations in the PR :) )" + }, + { + "prediction": "I think this should be `strings.ReplaceAll`, not `strings.Replace`. The latter replaces all occurrences of a pattern with another, whereas `ReplaceAll` replaces all occurrences of a pattern with the same value as the first occurrence.", + "reference": "This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards." + }, + { + "prediction": "I think it would be better to add a note in `New` explaining that a configured `Requestlogger` will not log HealthChecks.", + "reference": "This seems like a more appropriate message under `ListenAndServe`. WDYT?" + }, + { + "prediction": "Why is this needed? I don't see it being used anywhere in the test.", + "reference": "Is this not required?" + }, + { + "prediction": "I think this should be `isset($this->entity['search']['sort']['field'] ?? $this->request->query->get('sortField'));`", + "reference": "We should start thinking of an object that encapsulates this information :) we might need more arguments in the future." + }, + { + "prediction": "Why are these two error messages different?", + "reference": "Given that we are (conceptually) searching across multiple self-dependencies, all we can say is that we didn't have a self dependency in which *both* source and dest masks were correct. Since the spec doesn't imagine this case, the valid usage statement assume we can differentiate only wrong source from only wrong dest within a *single* self-dependency -- which we can't across multiple (at least not meaningfully)... so we always return both the source/dest VUID's if we can't find a self-dependency in with *both* are correct." + }, + { + "prediction": "I think this is the only place where `method.response()` is used.", + "reference": "rename? MiningCoordinator always exists" + }, + { + "prediction": "This should be `true` by default, not `false`.", + "reference": "Here would be the same case you don't need to call `loadConfigs`, but you would need to reread configs using `getConfig` on each getHost function call, not once per file." + }, + { + "prediction": "I think this should be `d.folder.fs.renameAndDeletionLock.Lock()` and `d.folder.fs.renameAndDeletionLock.Unlock()` should be `d.folder.fs.renameAndDeletionLock.Lock()` and `d.folder.fs.renameAndDeletionLock.Unlock()` should be `d.folder.fs.renameAndDeletionLock.Lock()` and `d.folder.fs.renameAndDeletionLock.Unlock()` should be `d.folder.fs.renameAndDeletionLock.Lock()` and `d.folder.fs.renameAndDeletionLock.Unlock()` should be `d.folder.fs.renameAndDeletionLock.Lock()` and `d.folder.fs.renameAndDeletionLock.Unlock()` should be `d.folder.fs.renameAndDeletionLock.Lock()` and `d.folder.fs.renameAndDeletionLock.Unlock()` should be `d.folder.fs.renameAndDeletionLock.Lock()` and `d.folder.fs.renameAndDeletionLock.Unlock()` should be `d.folder.fs.renameAndDeletionLock.Lock()` and `d.folder.fs.renameAndDeletionLock.Unlock()` should be `d.folder.fs.renameAndDeletionLock.Lock()` and `d.folder.fs.renameAndDeletionLock.Unlock()` should be `d.folder.fs.renameAndDeletionLock.Lock()` and `d.folder.fs.renameAndDeletionLock.Unlock()` should be `", + "reference": "Unlocking with defer means that this lock is still held curing the call to forgetNode(), below, which I see attempts to acquire `f.mu`, which looks dangerous to me." + }, + { + "prediction": "I think we can remove the `cst` and `bs` variables now.", + "reference": "Does anyone still use the cst out of this method? If not consider deleting" + }, + { + "prediction": "I'm not sure if this is the right place to put this redirect. I think it should go in the `podcasts` app, since it's about podcasts, but I don't know for sure.", + "reference": "Line is too long. [97/80]" + }, + { + "prediction": "I don't think you need to import `BytesIO` here. You can just use `io.StringIO()` or `io.BytesIO()`.", + "reference": "This seems unused." + }, + { + "prediction": "I think this should be `panic(\"unsupported os-release\")` instead of `panic(\"unsupport os-release\")`", + "reference": "@luguanglong , Thanks for the fix, can you re-phrase it to sound better something like \"This OS version is currently un-supported by keadm\"" + }, + { + "prediction": "I think this should be `delattr(mol, 'fpInfo') if hasattr(mol, '_fpInfo') else None`", + "reference": "should probably be called `_DeleteFpInfoAttr` because it removes it. Cleaning gives the impression it is still there. I would also move this to the end of the function `GetAtomicWeightsForFingerprint`." + }, + { + "prediction": "I think this should be `VUID-vkCmdBindDescriptorSets-pipelineBindPoint-00361` and not `VUID-vkCmdBindDescriptorSets-pipelineBindPoint-00361`", + "reference": "nit, can we use `VK_PIPELINE_BIND_POINT_RAY_TRACING_KHR` here (granted it isn't else where, maybe worth fixing here or in separate PR)" + }, + { + "prediction": "I think this should be `params.require(:workout).permit(:edit_url, :summary, :title, :url)`", + "reference": "This will need to be updated in the upcase-exercises repo as well." + }, + { + "prediction": "Metrics/LineLength: Line is too long. [121/120]", + "reference": "Think it's worth extracting this to `Exercise#complete?`?" + }, + { + "prediction": "Why is this method removed?", + "reference": "This is still a potentially useful public method - should we remove such methods?" + }, + { + "prediction": "I'm not sure this is the right place to put this method. I think it should go in the `ApiDefaultConfig` class, since that's where the rest of the `ApiConfig` class is.", + "reference": "I don't understand this change, what is happening here?" + }, + { + "prediction": "I don't think we need to split here, just use `int(self.obj.excelCellObject.Application.Version.split('.')[0])`", + "reference": "I think its worth stating this is `versionMajor`" + }, + { + "prediction": "I don't think we need this function at all, since we have `SetConsensus` and `GetConsensus` already.", + "reference": "rebuild: say loads and merges" + }, + { + "prediction": "I think we can remove this line.", + "reference": "Why was this removed here (also in the other file)? Shouldn't we import them so that the reference in the docs below is interpreted correctly?" + }, + { + "prediction": "I don't think we need to change this line.", + "reference": "I'd prefer to have a blank line between the class declaration and its first member. Is it possible?" + }, + { + "prediction": "I'm not sure this is the right place for this test. I think it should go in `test/unit/mongodb/test-helper.js`", + "reference": "Is it really LEGACY_HELLO if we are using the most up to date HELLO? Perhaps `MONGOS_HELLO` would work here?" + }, + { + "prediction": "I'm not sure if this is the right place for this, but it seems like it should be.", + "reference": "I am afraid this is going to cause problems on Windows where it is not uncommon to have injected threads (CTRL_SHUTDOWN, CTRL_LOGOFF, etc.) we have no privileges to suspend -- and thus retrying will just fail again, and with the new \"synchall failure is fatal and should kill the process\" approach it turns what used to work for us on Windows into process death." + }, + { + "prediction": "Should this be `--installer-signing-identifier`?", + "reference": "think it should only be in create_dist" + }, + { + "prediction": "I think we can remove the `if int(cport.HostPort) > 0` check here, since it's already handled by the `if int(cport.ContainerPort) > 0` check above.", + "reference": "Do you plan to support Pod spec change? Like hostPort is added/removed later after Pod creation?" + }, + { + "prediction": "I think this should be `0` instead of `-1`", + "reference": "Is this behavior correct? It used to return `true`, which should map to `dokan.ExistingDir`. Was that previously a bug?" + }, + { + "prediction": "I think this should be `osrm::util::Log() << \"No shared memory regions found. Try running osrm-datastore\";`", + "reference": "What about just printing an empty list in this case? That would make the output more predictable." + }, + { + "prediction": "Why is this removed?", + "reference": "I looked and couldn't find any usage of `container` in any of the editor component files (js or hbs), so I assume this was used once and didn't get removed?" + }, + { + "prediction": "Can you add a space after the `if`?", + "reference": "I just updated a number of sites using older versions of Roots onto WP 3.6 and this little function change was required. Multiple search bars were displaying when I used the search widget in a widgetized sidebar. Updated the roots_get_search_form as seen in this change resolved it for me!" + }, + { + "prediction": "I think this should be `type` instead of `typeOfFreeProduct`", + "reference": "Fixes test failed in some cases" + }, + { + "prediction": "I'm not sure if we want to keep this or remove it. I think we want to keep it, but I don't know if it's safe to keep it.", + "reference": "what's the prod url for this? just curious. @amirsaber" + }, + { + "prediction": "I think this should be `azkaban.job.command.args` and not `az_job_command_args`", + "reference": "Can you please change this to azkaban.jobs.java.opts?" + }, + { + "prediction": "I think this should be `__( 'Source:', 'google-site-kit' ) + sprintf( '%2$s', getSiteKitAdminURL( 'googlesitekit-module-analytics' ), _x( 'Analytics', 'Service name', 'google-site-kit' ) )`", + "reference": "Here is another concatenation which should be updated. Even though `Source:` and the link are essentially separate, it isn't RTL friendly. This would be another good use for `createInterpolateElement` I think so that we wouldn't need to include all of the classnames in the translation string (or extract them to a placeholder). That would allow us to use the `Link` component as well, rather than using its resulting HTML as a string which will be a pain to maintain if we were to make changes to the base `Link` component." + }, + { + "prediction": "Why is this needed? `Task.FromCanceled` returns a `Task`, not a `Task`.", + "reference": "I would add an overload `GetCancelledZeroTask()` which calls `GetCancelledZeroTask(CancellationToken.None)`. This is cleaner than requiring the caller to pass `default(CancellationToken)` or `CancellationToken.None`." + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think it would be better to do it in `PreCallRecordDestroySwapchainKHR` as well as `PreCallRecordDestroyImage`.", + "reference": "Would it be equivalent to check if `chain != nullptr` below? Not suggesting a change, just curious." + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think it would be better to do it in `wallet::change_async` instead of `wallet::queue_work_regeneration`.", + "reference": "Should probably do `auto this_l (shared_from_this ());` and pass/use that instead of `this`. Same a few other places. IOW, replace both `shared_from_this()` and `this` with `this_l`" + }, + { + "prediction": "This is a bit of a nitpick, but I think it would be better to have a separate message for the verb case, rather than a separate message for the case where the verb isn't there.", + "reference": "And here. Please, use `'` for apostrophes in changed strings in this file." + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think it should be done in the `ExecuteContractRead` function, but I'm not sure if that's the right place to do it.", + "reference": "assignments should only be cuddled with other assignments (from `wsl`)" + }, + { + "prediction": "I think this should be `DefaultNewBlockDataVersion()`, not `DefaultNewBlockDataVersion(c Config, holes bool)`.", + "reference": "Please move this to `block_types.go`." + }, + { + "prediction": "I think it would be good to have a test for this as well.", + "reference": "So this is not needed anymore for all attributes?" + }, + { + "prediction": "I think we can remove the `Message` parameter from the `Event` event, since it's now part of the exception message.", + "reference": "Happy to get suggestion for better messaging here. Here's what I intended to convey: Something is wrong - the Exception is a hint to what might be the cause The impact of that - tracing wont work." + }, + { + "prediction": "`update_listener` is not used in this function, can you remove it?", + "reference": "I think we can remove this function, right? (duplicate with `ses_starter.py`)" + }, + { + "prediction": "I think this should be renamed to `rename_field` or something.", + "reference": "With this fix, I am not even sure we need to overwrite this function." + }, + { + "prediction": "I think this should be `use_tqdm = os.getenv('QUILT_USE_TQDM').lower() == 'true'`", + "reference": "Why not just import this from `data_transfer`? As a rule copying the same code twice is not a good idea. Also: please run `pylint` on all files in this PR." + }, + { + "prediction": "_server=>\"none\"}}\n+ expect(parser.parse_args(args)).to be === {:hosts_file=>hosts_path, :options_file=>nil, :type=>\"git\", :provision=>true, :preserve_hosts=>false, :root_keys=>false, :quiet=>false, :xml=>false, :color=>true, :debug=>true, :dry_run=>false, :fail_mode=>nil, :timesync=>false, :repo_proxy=>false, :add_el_extras=>false, :consoleport=>443, :pe_dir=>\"/opt/enterprise/dists\", :pe_version_file=>\"LATEST\", :pe_version_file_win=>\"LATEST-win\", :dot_fog=>\"#{home}/.fog\", :ec2_yaml=>\"config/image_templates/ec2.yaml\", :ssh=>{:config=>false, :paranoid=>false, :timeout=>300, :auth_methods=>[\"publickey\"], :port=>22, :forward_agent=>true, :keys=>[\"#{home}/.ssh/id_rsa\"], :user_known_hosts_file=>\"#{home}/.ssh/known_hosts\"}, :install=>[\"git://github.com/puppetlabs/puppet.git#1.0\", \"git://github", + "reference": "You've got an absolute path here referencing your home dir :-)." + }, + { + "prediction": "I think this should be `prefixPropertyMetaModel` instead of `prefixPostfixPropertyMetaModel`.", + "reference": "Maybe I should do some sorting so that these properties don't keep moving around..." + }, + { + "prediction": "I think this test should be moved to `test/unit/mount_test.go`", + "reference": "Can we keep this test anyway, as it's part of the spec?" + }, + { + "prediction": "I think it would be better to have a `MailerStrategyInterfaceCompilerPass` in the `Kernel` class itself, so that it can be used in other modules as well.", + "reference": "Can be removed" + }, + { + "prediction": "I think this should be `use Config as Config;`", + "reference": "It's a minor quibble I know, but I like having the imports ordered by lengt" + }, + { + "prediction": "I don't think this is the right fix. We should not be changing the content type of the response if it is a failure.", + "reference": "It's better to get the charset from context or other setting to let the user override it." + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in the `v1alpha1` part of the informers, but I'm not sure if that's the right place for the informer as well.", + "reference": "this filename as well needs change" + }, + { + "prediction": "I don't think we need to add `SecretAccessKeyRef` here, since we don't have a `SecretKeySelector` for `HostedZoneID`.", + "reference": "I think we want to remove `omitempty` here" + }, + { + "prediction": "I'm not sure this is the best way to do this. I think we should be using the `SignalHandler` from `runtime` instead of creating a new handler.", + "reference": "You cannot move this here because it breaks detach. Just call `tty.Close()` before returning the error from start" + }, + { + "prediction": "I'm not sure if this is the right place for this change.", + "reference": "I updated only the implicit roles who needed a update for this new rule to validate." + }, + { + "prediction": "Why is this change needed?", + "reference": "> // Code generated by protoc-gen-go. DO NOT EDIT." + }, + { + "prediction": "I think we can remove this.", + "reference": "minor: skipOSConfigMetadata, otherwise, the name sounds like a boolean" + }, + { + "prediction": "I think we can remove the `SyndTypeUtils.enclosureTypeValid` method altogether.", + "reference": "~~I think lines 65-67 should be moved into this else clause after `type = ...` Else, it is a bit confusing why we check the enclose type validity a second time~~ Nevermind, will do some refactoring, myself. But thanks for \"fixing\" this!" + }, + { + "prediction": "I don't think we need this function at all. We can just use `client.http.Get(\"sessions\", ...)` directly.", + "reference": "`sessions := endpoints.SessionsDTO{}` and using only `sessions` should be simpler." + }, + { + "prediction": "I'm not sure this is the right place for this check. It seems like it should be in the same place as dcontext->is_exiting, but I'm not sure if that's the right way to do it.", + "reference": "These need to be in the other order to avoid crashing when dcontext == GLOBAL_DCONTEXT (==-1)" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `ConfigureKestrel` method, since it's related to the Kestrel part of the pipeline.", + "reference": "Why not change the other samples?" + }, + { + "prediction": "I'm not sure this is the best way to do this. I think it's better to use the `getAttribute` method to get the value of the `id` attribute and then use `!!document.querySelector` to check if there is a matching element in the DOM.", + "reference": "Indentation is mixed up here due to spaces/tabs, I'm guessing." + }, + { + "prediction": "(style) line over 80 characters", + "reference": "Should we provide a little more context in the error message? Maybe throw in something about what operation was being performed?" + }, + { + "prediction": "Shouldn't this be `array_key_exists('settings', $configuration) ? $configuration['settings'] : null`?", + "reference": "Project standard is spaces, not tabs. Please fix and then we can merge this." + }, + { + "prediction": "Is this needed?", + "reference": "@hgtw is there anything we're worried about with regards to using this cache? Do we want to do staged testing around expeditions before we merge? Curious your thoughts here" + }, + { + "prediction": "I'm not sure this is the right place for this change. It seems like it should be in `ManifestReader` since it's only used by that class, not `Manifest` itself.", + "reference": "The purpose of this was to allow pushing filters into the manifest files if we ever use a format other than Parquet. I think overall this is a good change because we can add it back later. Just wanted to note why the unused argument was there." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "I think BSON::Decimal128 should always be serialized as Decimal128 regardless of config option." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in the `spec/` directory under `spec/models/bolt_spec.rb`.", + "reference": "We should probably just move the `require 'bolt/plan_creator'` in `Bolt::CLI` to `Bolt::Application` so it will already be loaded." + }, + { + "prediction": "I think it would be better to have a constant for this value instead of hardcoding it.", + "reference": ">20 [](start = 45, length = 2) Can we override this at runtime? Maybe it should be a command line option with default." + }, + { + "prediction": "Please remove this empty line.", + "reference": "can just remove it ?" + }, + { + "prediction": "I think we should move this into the `FinishMigrateRepository` function.", + "reference": "Better call it `CleanUpMirrorInfo`?" + }, + { + "prediction": "I think we can remove this.", + "reference": "@shannonwells is there still something missing here?" + }, + { + "prediction": "I think this should be `add_setting :stress_test_duration_in_seconds`", + "reference": "This could be more indicative of what it is... e.g... `stresstest_time_limit`" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think we should move this to the `PDPSimple` constructor where we create the listener.", + "reference": "Shouldn't we do a `reader_payload_pool_.reset()` here?" + }, + { + "prediction": "I'm not sure if this is the right place to put this. I think it should be in the `BeaconChainState` struct, since it's related to the beacon chain.", + "reference": "I'd prefer the nomenclature less tightly coupled to DRAND throughout. I played with renaming the `drand` package to `beacon` but it was too much noise in this change." + }, + { + "prediction": "I don't think this is the right place to put this. It's not a property of the DynamicMap, it's a property of the underlying HoloMap. The DynamicMap should have a `current_key` property, not the underlying HoloMap.", + "reference": "I think I would prefer you declare `self._current_key=None` in the constructor and just return `self._current_key`. That way you can prevent anyone from overwriting `current_key` without needing to use `getattr` here." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `pkg/flux` since that's the package that contains the `flux` runtime package.", + "reference": "I guess I like the name `mode` okay. I can't think of anything better." + }, + { + "prediction": "I think it would be better to have a method `NewStepWithDefaultTimeout` instead of duplicating the code.", + "reference": "I would create a new method (NewStepWithDefaultTimeout?) for this purpose because timeout<=0 looks like a hidden logic" + }, + { + "prediction": "`limit` should be `int` not `int64`", + "reference": "Are these limit changes related?" + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in `scapy.utils` or `scapy.utils6`.", + "reference": "Don't you mean `import scapy.consts`?" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we need to make sure that we don't roll back the primary stage if there are still resources left in the update.", + "reference": "`ctx` is unused in rollbackPrimary" + }, + { + "prediction": "I think this should be -1235 instead of 0.", + "reference": "This is not what title says." + }, + { + "prediction": "I don't think this is the right place for this interface. I think it should be in `org.pmd.lang.ast`", + "reference": "a fix applies several fixes? maybe this should simply be `applyToNode`" + }, + { + "prediction": "I think this is the only place where we use fakeGetClientset and fakeListfn. I think we should remove the fakeGetClientset and use fakeListOk wherever we need it.", + "reference": "U1000: func `fakeGetOk` is unused (from `unused`)" + }, + { + "prediction": "nit: remove empty line", + "reference": "Because there is a \"k8s.io/client-go/tools/cache\" below, we can sort out all the \"imports\" here." + }, + { + "prediction": "I think we can remove this file now.", + "reference": "Nit should be using `goimports` to format the import statements with standard libary imports first, new line, followed by non-standard library imports." + }, + { + "prediction": "I think this should be `return errors.Wrapf(err, \"error deleting pipeline secret %s\", o.PipelineSecret)`", + "reference": "Do we not have tests for pipeline delete" + }, + { + "prediction": "I think this should be `load_hadoop_cmd() + ['fs', '-appendToFile', local_path, destination]`", + "reference": "Good that you mention this constraint in the docstring :)" + }, + { + "prediction": "I think you can remove this line.", + "reference": "remove this blank?" + }, + { + "prediction": "I think this should be computed based on the number of active partitions, not the number of rows.", + "reference": "Partitions is misspelled 8 times in this commit, might make sense to fix the spelling for all of those." + }, + { + "prediction": "I think this should be `from qutebrowser.browser import qutescheme` instead of `from qutebrowser.browser.qutescheme import qutescheme`", + "reference": "Please remove this blank line - those are only used to group Python/third-party/qutebrowser imports." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `cmd/traefik/traefik.go` or `cmd/traefik/traefik.go` and `cmd/traefik/traefik.go` or `cmd/traefik/traefik.go` or `cmd/traefik/traefik.go` or `cmd/traefik/traefik.go` or `cmd/traefik/traefik.go` or `cmd/traefik/traefik.go` or `cmd/traefik/traefik.go` or `cmd/traefik/traefik.go` or `cmd/traefik/traefik.go` or `cmd/traefik/traefik.go` or `cmd/traefik/traefik.go` or `cmd/traefik/traefik.go` or `cmd/traefik/traefik.go` or `cmd/traefik/traefik.go` or `cmd/traefik/traefik.go` or `cmd/traefik/traefik.go` or `cmd/tra", + "reference": "`insecure` is a global variable (from `gochecknoglobals`)" + }, + { + "prediction": "I think we can remove the `setting.Repository.DisableHttpGit` check here.", + "reference": "Same as above (HTTP in upper-case)" + }, + { + "prediction": "I think this test should be moved to the `YouTubeProviderTest` class, since it is specific to the YouTube provider.", + "reference": "This is getting repetitive maybe you could introduce an abstract test case with a `getExpectedUrl($providerReference)` method ?" + }, + { + "prediction": "I think this should be called `MakeFunction` instead of `MakeFunc`.", + "reference": "I do not think returning `Value{}` is correct here. For example, `reflect.MakeFunc(...).Kind()` would return `reflect.Invalid` instead of `reflect.Func`. Therefore, I think this should panic instead." + }, + { + "prediction": "`substring(2)` is unnecessary here, since `name` is already two characters long.", + "reference": "Does this work for Custom Elements? iirc we're lacking test cases for them. /cc @andrewiggins @developit" + }, + { + "prediction": "I think we can remove the `externalNodeCIDRs` field from the `ipipManager` struct.", + "reference": "Same change just above?" + }, + { + "prediction": "I'm not sure about this one, but I think it's fine.", + "reference": "I suppose `apploader.js` isn't used by WebWorkers. So `self` will always be `window` here." + }, + { + "prediction": "I think we can remove this line too.", + "reference": "Since this var is no longer defined we should remove the `if skip_targets.any?` bit below." + }, + { + "prediction": "I think this should be `lambda_function_arn` instead of `lambda_function_arn`", + "reference": "I think we should `return arn` as a fallback at the end of this function (otherwise the `['Resource']` entry below could become `None`)." + }, + { + "prediction": "I'm not sure if this is the right way to handle this. I think we should check if `np.socketProtect` is not nil, and if it's not nil, then we don't need to protect the connection. Otherwise, we need to protect the connection. What do you think?", + "reference": "Why session is started at all, if you need to shut it down e.g. DI should launch noopSession" + }, + { + "prediction": "I think we should rename this to `DeleteWorkspace` instead of `DeleteAll` to be consistent with the rest of the SDK.", + "reference": "nit: can we rename the interface to `wsFileDeleter`" + }, + { + "prediction": "I think we can remove the `FromAddresses` and `ToAddresses` fields from the `CompletedRule` struct.", + "reference": "Why target cannot be external endpoints?" + }, + { + "prediction": "I think this should be `auto_` instead of `AUTO_PREFIX`.", + "reference": "We use a suffix \".AUTOCREATED\" for configsets, maybe we can use the same here?" + }, + { + "prediction": "I think this should be `OpenTelemetrySdk.EnableOpenTelemetry(...)`", + "reference": "This one won't be disposed. Should be (something like) `using var openTelemetry = OpenTelemetrySdk.EnableOpenTelemetry(` no?" + }, + { + "prediction": "I don't think you need to change this line.", + "reference": "Why this is in the diff?" + }, + { + "prediction": "I think we should rename this to `CloudBackupsCreate` to be consistent with the naming used in `CloudBackupCreate` and `CloudBackupGroupCreate`.", + "reference": "How is status determined? When the user calls CloudBackupCreate( src_volume_id ) they can then call CloudBackupStatus( src_volume_id ) Is there something similar for this new API?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in `diffBound`, since it's only called when the diff is happening in the DOM.", + "reference": "We could pass `excessDomChildren` to `options._catchError` and only do this if an error-boundary catches the error. Not entirely sure if that's better." + }, + { + "prediction": "I think this should be `array_merge(..., array_values($this->getFilters()));`", + "reference": "In php8 named parameters were introduced and now it is required to match called method parameter name when setting parameters by array destructing or call_user_func_array() etc." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `b3` package, since that's where `b3` is defined.", + "reference": "If instead we had `B3.extractSingleHeader` and `B3.extract` return a bool value as a second return value, we could avoid the byte array comparison in `TraceID.IsValid`. Did you consider that alternative?" + }, + { + "prediction": "Shouldn't this also be translated?", + "reference": "I think this is more of a semantic difference than a typo - `weiter hinzufgen` is like `continue adding` whereas `weitere hinzufgen` is like `add more`. I think it makes sense to change it though" + }, + { + "prediction": "I think this test should be moved to a separate file, since it's not related to the rest of the tests.", + "reference": "nit: 200 is superfluous" + }, + { + "prediction": "I'm not sure why this test is failing, but I think it's because of this line: `std::string query = \"CREATE TAG upper(name string, EMAIL string, age int, gender string, row_timestamp timestamp)\";`", + "reference": "This is testing `unreserved keyword`" + }, + { + "prediction": "Shouldn't this be PROJ_WKT2_NAME_METHOD_QUADRILATERALIZED_SPHERICAL_CUBE?", + "reference": "paramsNatOrigin doesn't include sUVtoST. I would just remove that definition for now" + }, + { + "prediction": "I think this test should be moved to `testutil/testutil.go` since it's only used by `testutil/blockRetrievalQueue_test.go` which is only used by `initBlockRetrievalQueueTest`", + "reference": "It feels like the test should be waiting for the prefetcher to shut down, but I don't have a great reason why other than that it might be confusing for debugging if there are still goroutines from old prefetchers lying. But I guess since `TogglePrefetcher(false)` doesn't actually set the prefetcher to nil, the queue shutdown method will still end up waiting for the shutdown to finish. If that sounds right, nevermind me." + }, + { + "prediction": "I'm not sure this is the right place to put this snippet. I think it should go in the `aws-identity-v2` package.", + "reference": "AWS Identity and Access Management (IAM)" + }, + { + "prediction": "I think this should be `RESOURCE_NAME_PROJECTS`", + "reference": "As a long term thing, would it make sense to move the resource names as keys under the requirements map?" + }, + { + "prediction": "I think this should be `if (cell.hasAttribute('headers') || tableGrid.hasAttribute('headers'))`", + "reference": "That doesn't fix the whole problem. The issue lays in this line right here, not the one above. There are two problems with this line: 1. It finds things that aren't cells in the table 2. if it doesn't find anything, it shouldn't return empty here, but continue down to look for row/ column headers." + }, + { + "prediction": "Shouldn't this be `BaselineVersions.getResolvedArtifacts(getProject().getArtifacts())`?", + "reference": "I am pretty sure that this is infinite recursion as getAllProjects returns the project itself." + }, + { + "prediction": "I think this should be renamed to `data-lists`", + "reference": "Something I didn't catch before I merged this PR, is the hyphenated constant a problem? E.g. should \"data-lists\" be \"data_lists\"? @paulkaplan" + }, + { + "prediction": "I think this should be `if not conf.use_winpcapy and not conf.use_pcap and not conf.use_dnet:`", + "reference": "Can you write the test as `if not (conf.use_winpcapy or conf.use_pcap or conf.use_dnet):`" + }, + { + "prediction": "I think this should be `ForeignAsset` instead of `ForeignAsset`?", + "reference": "we have to include foreign assets on the repository directly because they don't belong to a job? This seems very awkward... Is this a step towards the job-less assets on the repository? Did you consider having `build_asset_job` take in a set of foreign assets instead? I suppose we would then need to subclass it to be a more special `AssetJobDefinition` that can keep track of them." + }, + { + "prediction": "Why is this change necessary? It looks like this function is only used in one place, and that place already uses `std::unique_ptr` for the lifetime of the `TempDir` object.", + "reference": "`-Wstringop-truncation` is a new kind of error detector introduced in GCC 8. As for this patch, these are two false-positives though." + }, + { + "prediction": "nit: I think it would be better to call this \"only one credential type may be specified per source profile\"", + "reference": "Can we port this error msg to v2 too? This one is better, as it explicitly states what sources are allowed." + }, + { + "prediction": "nit: can you move this import to the top of the file?", + "reference": "The convention so far has been to require directly from the defining file (in this case `../../read_preference') . I think the concern has been mostly about the potential for circular dependency cycles" + }, + { + "prediction": "`color_type` is not used in this module, please remove it.", + "reference": "I suggest expanding dims here to simplify the formatting." + }, + { + "prediction": "I think this should be `config/kinto.ini` instead of `config/kinto.ini`", + "reference": "Why do you need to specify the kinto prefix here?" + }, + { + "prediction": "`!r` -> `r!r`", + "reference": "The `!r` is unnecessary." + }, + { + "prediction": "I think we can remove the `accountKey != \"\"` check here, since it's already handled by the `if` above.", + "reference": "I didn't see existing tests for this `OpenBucketURL`. Not sure if it's easy to do without mocking these `opener` calls." + }, + { + "prediction": "I don't think this should be a property. It should be a constructor parameter.", + "reference": "Should we default to `true` ?" + }, + { + "prediction": "I think this file should be renamed to `consensus.go` and moved to `consensus` package.", + "reference": "File is not `goimports`-ed (from `goimports`)" + }, + { + "prediction": "I'm not sure this is the right place to put this. I think it should be in the `babel-plugin-transform-react-18-00.js` file, since that is where the presets are defined.", + "reference": "Shouldn't these options also include `@babel/preset-env`? Also I see you set `babelrc` to `false`, could we rely on our existing `.babelrc` file? Feels like some duplicate configuration otherwise." + }, + { + "prediction": "I think this should be `reason` instead of `reasonCode`", + "reference": "Nit: We can use `%s` since `disconnectReason` is a string." + }, + { + "prediction": "why do you need to change this?", + "reference": "I think it's better to create a new example" + }, + { + "prediction": "I'm not sure this is the right place for this change. I think it should be in the `resolve_write` function, since it's specific to writing to a color attachment.", + "reference": "The stages are correct, but the more forgiving `kAttachmentRasterOrder` should be used, based on a review of the spec. That should give the same effect of suppressing the false positive conflict between the DEPTH R/W and resolve. > End-of-subpass multisample resolves are treated as color attachment writes for the purposes of synchronization. This applies to resolve operations for both color and depth/stencil attachments. That is, they are considered to execute in the VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT pipeline stage and their writes are synchronized with VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT. Synchronization between rendering within a subpass and any resolve operations at the end of the subpass occurs automatically, without need for explicit dependencies or pipeline barriers." + }, + { + "prediction": "I think this should be `O[SD3](=O)(=O)[O-]` instead of `O[SD3](=O)(=O)[OH]`", + "reference": "To be consistent, I think it should actually just be a single `-`" + }, + { + "prediction": "I don't think we should be using `flask` at all. We should be using `jinja2` and `jinja2_2` (or `jinja2_3`).", + "reference": "this seems extraneous." + }, + { + "prediction": "I think we can remove this feature set from the `Suite` now.", + "reference": "Ah, I see here that 'LongDomain' is defined as something that contains a subdomain segment that is `maxLengthOfDomainSegment` long (which I think is 63 characters) - I don't think any public ACME servers/Let's Encrypt's staging environment has a restriction on this? if it does, and the 'pebble' based ACME server does not, then Pebble needs modifying to also fail in these cases as it aims to replicate the ACME RFC as closely as possible" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be under `ENV['HOME'] + \"/.rvm/bin\"`, since that's where `r-` is installed.", + "reference": "I think you need `-y` here to prevent a user confirmation prompt" + }, + { + "prediction": "This should be `bool dynamo_avx512_code_in_use = false;`", + "reference": "Repeating: I don't think this should be a core-wide global var. This should be isolated to arch/x86 or at least arch/, maybe inside getter/setters as mentioned above." + }, + { + "prediction": "I think it would be better to use `JMeterPlugins` here, as it's the name of the plugin we're looking for. Also, I think it would be better to use `JMeterPlugins140` instead of `1.4.0` as it's the latest version of the plugin.", + "reference": "right URL is like in cmdrunner, using search.maven .org" + }, + { + "prediction": "I think this should be `endpoint` instead of `endpointString`.", + "reference": "The link to valid syntax is not really applicable for NET2_1, right?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `pkg/version` since that's where the versioning code lives.", + "reference": "Shouldn't it be more specific, like \"gcppubsub supports all UTF-8 strings\"?" + }, + { + "prediction": "I think we can remove the `slave` variable from the `CloudJettyRunner` constructor, since it's not used anymore.", + "reference": "Everything in this class is SolrCloud-related, not legacy replication" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in `drbbdup_get_tls_raw_slot_val()`, but I'm not sure why it is called `merge_arith_flags()` instead of `arith_merge_flags()`. Can you explain why it is called `merge_arith_flags()` instead of `arith_merge_flags()`? I think it should be `arith_merge_flags()`, but I'm not sure why it is called `merge_arith_flags()` instead of `arith_merge_flags()`. Can you explain why it is called `merge_arith_flags()` instead of `arith_merge_flags()`?", + "reference": "Could just assign directly and eliminate the `newval` var." + }, + { + "prediction": "I'm not sure if this is a good name for this. I think it's a bit confusing because it's not just about the title, but also about the pull request itself. Maybe `pullRequestTitleRegexp` would be better?", + "reference": "... with the name of the affected package, or \"all\", followed by a colon,..." + }, + { + "prediction": "I think this should be `SynchronizeVersion(\"src/Datadog.Trace.ClrProfiler.Managed.Core/Datadog.Trace.ClrProfiler.Managed.Core.csproj\", NugetVersionReplace);` and not `SynchronizeVersion(\"src/Datadog.Trace.ClrProfiler.Managed.Core/Datadog.Trace.ClrProfiler.Managed.Core.csproj\", NugetVersionReplace);`", + "reference": "We'll want to remove this one if we make the assembly version constant." + }, + { + "prediction": "This should be moved to the `app/Http/Redirects` folder.", + "reference": "Can we have a single function here that uses the same subscribers and just changes meta based on context?" + }, + { + "prediction": "I think this should be called `load_kernels_and_setup_function_symbol_map`", + "reference": "where would ` static startup_kernel_loader skl;` be instantiated? if it's not instantiated anywhere should this be removed?" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to be the only way I could get it to work.", + "reference": "I think we should move those util functions that work with drag-drop to @uppy/utils, so they can be shared (maybe later) with drag-drop plugin? Otherwise it will continue to depend on drag-drop module." + }, + { + "prediction": "I think we can remove the `spec.VolumeLabels` and `spec.ReplicaSet.Nodes` here.", + "reference": "Migrate the spec.Labels to locator.Labels ?" + }, + { + "prediction": "I think this is the only place where `wantErr` is used.", + "reference": "The test case already existed but it never tested properly because of the conditional in the test." + }, + { + "prediction": "I think this should be `return Objects.equals(sourceId, that.sourceId) && name.equals(that.name) && transform.equals(that.transform);`", + "reference": "I'm okay with this, but I don't see a lot of benefit to removing unnecessary parens. If extra parens make something more readable (like this) or clarify order of operations even when matching the default, I would say we should keep them." + }, + { + "prediction": "I think this should be `protected final DynamicField[] dynamicFields = new DynamicField[0];`", + "reference": "@sarowe why was this volatile? It's fishy to see this as the only volatile field." + }, + { + "prediction": "I don't think this is the right package name for this class.", + "reference": "template is not correct?" + }, + { + "prediction": "I think it's better to move this file to `mmdet/sampler/assigner`.", + "reference": "Rename the registies to `BBOX_ASSIGNERS` and `BBOX_SAMPLERS` to avoid ambiguity. There is also a registry for dataset sampler." + }, + { + "prediction": "`FakeFS.activate!` should be moved to the top of the file.", + "reference": "This is no longer stubbed on every test. Perhaps it should be, and should be unstubbed in the single case that it matters." + }, + { + "prediction": "I'm not sure this is the best place to put this, but I don't have a better idea off the top of my head.", + "reference": "This seems much simpler! I'm not sure I follow what you mean by the threading part... Also tests are not liking this constant. Might need a require or to fully qualify this." + }, + { + "prediction": "I'm not sure if this is the right place to put this check. I think it should be in `i#2144`.", + "reference": "Convention is \"FIXME: i#2144\" or \"XXX: i#2144\"" + }, + { + "prediction": "I'm not sure if this is the right place to put this interface. I think it should be in `Datadog.Trace.ClrProfiler.Interfaces`, but I'm not sure if that's the right place to put it.", + "reference": "This should probably be a property instead of a method." + }, + { + "prediction": "I'm not sure if this is the right place to check for the state to be RECONCILED, but it's the only way I could find to check for the state to be RECONCILED.", + "reference": "do we need to consider setting the `state` as well? If so, lot of changes might be required, like, setting to 'Reconciling' in upgrade code, setting to 'error' or 'reconciled' in volumeReconciler functions." + }, + { + "prediction": "Line is too long. [82/80]", + "reference": "Line is too long. [82/80]" + }, + { + "prediction": "I think this should be `MIT License`.", + "reference": "Add blank line below license header." + }, + { + "prediction": "I think it would be better to move this logic to `TableMetadata#buildReplacement`", + "reference": "I'm not clear on whether this really should be the right behavior. Basically we're saying that a replace table will keep the existing location (as opposed to using defaults). I suspect we don't have create or replace with location semantics, but this is making some assumptions that a replacement is somehow the same as the old. If we were to go with id based pathing convention, this wouldn't work. I don't think this is an issue at this point, but it might make sense to push this down to the location provider." + }, + { + "prediction": "I think this should be `github.com/temporalio/temporal/.gen/proto/persistenceblobs` and not `github.com/temporalio/temporal/.gen/proto/replication`", + "reference": "Just run a global replacement for all `executionproto`." + }, + { + "prediction": "I think we can remove the `file_detector` argument from this class.", + "reference": "@AutomatedTester @davehunt thoughts on a new keyword argument?" + }, + { + "prediction": "I'm not sure this is the right error code to return here. It's not an error in the sense that the caller should not have expected it, but it's also not an error in the sense that the caller should not have been expecting it. It's an error in the sense that the device driver should not be able to handle it, and it's also an error in the sense that the caller should not have expected it.", + "reference": "Should line 47 be OPAE_ERR?" + }, + { + "prediction": "Why is this needed? I don't see it being used anywhere.", + "reference": "Not necessary, just write `time.Time{}`" + }, + { + "prediction": "I think this should be `tabbar-size` instead of `tabbar-height`.", + "reference": "As these two strings simply get concatenated for the docs, there's a space missing after the dot here." + }, + { + "prediction": "I think we can remove the `if (IntegrationOptions.IsIntegrationEnabled)` check here, since it's already done in the `return BeginMethodHandler.Invoke(instance);` line above.", + "reference": "What about integrations where we don't plug ourselved on OnMethodBegin?" + }, + { + "prediction": "I don't think this is a good name for this class. It's not just checking that an element is visible, it's checking that an element is visible and interactable. I think something like `expect_any_element_is_interactable` would be better.", + "reference": "shouldn't **call** return a boolean?" + }, + { + "prediction": "I don't think this is necessary. The `Interface` interface is a superset of the `com.google.api.tools.framework.model.Interface` interface, so it should have all of the methods and properties from the `com.google.api.tools.framework.model.Interface` interface. It's not necessary to implement all of the methods and properties from the `com.google.api.tools.framework.model.Interface` interface, but it's not necessary to implement any of the methods and properties from the `com.google.api.tools.framework.model.Interface` interface.", + "reference": "ViewModel classes should not expose any classes from framework.model." + }, + { + "prediction": "I think this test is no longer necessary, but I don't know why it was removed.", + "reference": "how would you feel about keeping these tests to be more explicit and having them `assert not _validate...`? or is your view that that is too duplicative of the tests in `test_evaluator.py`?" + }, + { + "prediction": "I think this should be `--tags` instead of `--format`", + "reference": "Why do we use the `winrm_nodes` variable here and not the string `\"winrm_nodes\"` as we were using before?" + }, + { + "prediction": "I think it's better to use `vesoft` instead of `vesoftinc`", + "reference": "why update Copyright ?" + }, + { + "prediction": "I don't think this is the right place for this check. I think it should be in `Scan`'s `bindNode` method.", + "reference": "Does this mean we cannot update statistics with sampling on a table with LOB columns?" + }, + { + "prediction": "I don't think this is the right place for this. I think it should be in `NLog.LayoutRendererBase`", + "reference": "Look good, but I think a `[flags]` enum would be more future proof? Although i'm not sure if a flags-enum is working from the XML config. What do you think?" + }, + { + "prediction": "I think this should be `if (row.treeLevel > -1 || (row.treeNode.children && row.treeNode.children.length > 0)) {`", + "reference": "Since I believe state will never be anything other than 'expanded' or collapse, you can rewrite this as follows: `return row.treeNode.state === 'expanded' ? 'ui-grid-icon-minus-squared' : 'ui-grid-icon-plus-squared'; `" + }, + { + "prediction": "I'm not sure if we should remove this, but I don't think it's a good idea to change the default behavior of the `SolrClient` in the `SolrHttpClient`. I think it would be better to keep the default behavior of the `SolrClient` in the `SolrHttpClient` and let the `SolrHttpClient` handle the default behavior of the `SolrClient` in the `SolrHttpClient`.", + "reference": "the latter part can go but isn't the first part of this still sound -- that we assume \"id\"?" + }, + { + "prediction": "I don't think this is the right fix. The problem is that `@` and `$` are escaped by the `String.prototype.replace` method, not by the `String.prototype` method. So the `@` and `$` end up in the output. The fix should be to replace the `String.prototype.replace` method with the `String.prototype.replaceAll` method, and then remove the `@` and `$` special characters from the `value` before calling `String.prototype.join`.", + "reference": "Why is the escaping of @ and $ removed?" + }, + { + "prediction": "I'm not sure if this is the right place to put this interface. I think it should be in `Datadog.Trace.Interfaces`.", + "reference": "Nit: `Http` is redundant in this interface's name." + }, + { + "prediction": "I think this should be `store.Put` instead of `store.Exists`?", + "reference": "what if I set SynchronizableEntitiesPrefix to \"a/b/c/d\" in config?" + }, + { + "prediction": "I think this should be `opts.DockerfilePath != \"\"` instead of `opts.DockerfilePath != \"\" && isDir`", + "reference": "nit: This error message doesn't mention that the path is a directory, maybe \"Dockerfile path is a directory:%s, please provide path to file.\"" + }, + { + "prediction": "I don't think this is the right place for this. It's not an issue with the software itself, but with the hardware. We should be looking at the hardware and not the software.", + "reference": "This is done automatically, you can skip it next time ;)" + }, + { + "prediction": "I think this should be `self._elem.dispatchEvent(new Event(event))` instead of `self._elem.evaluateJavaScript(\"this.dispatchEvent(new Event('{}'))\")`", + "reference": "This is needed in `set_value` because of `:open-editor` (you could open an editor, close the tab, then close the editor). I don't think it makes any sense to have it here?" + }, + { + "prediction": "I'm not sure if this should be `profiling_frequency` or `profiling_period` or `profiling_interval` or `profiling_periodic_interval` or `profiling_frequency_periodic_interval` or `profiling_periodic` or `profiling` or `profiling_interval` or `profiling_period` or `profiling` or `profiling_periodic` or `profiling_periodic_interval` or `profiling_interval` or `profiling` or `profiling_periodic` or `profiling_periodic_interval` or `profiling_interval` or `profiling` or `profiling_periodic` or `profiling_periodic_interval` or `profiling_interval` or `profiling` or `profiling_periodic` or `profiling_periodic_interval` or `profiling_interval` or `profiling` or `profiling_periodic` or `profiling_periodic_interval` or `profiling_interval` or `profiling` or `profiling_periodic` or `profiling_periodic_interval` or `profiling_interval` or `profiling` or `profiling_periodic` or `profiling_periodic_interval` or `profiling_interval` or `profiling` or `prof", + "reference": "Perhaps we can assume that profiling is enabled if ProfilingPort is set? And/or configure a default port and frequency, so we don't have to set three config vars every time?" + }, + { + "prediction": "I'm not sure this is the right place for this hack. I think it should go in `lib/beaker/vagrant.rb`", + "reference": "This nil check won't correctly handle the case where forward_ssh_agent is set to false - it won't be nil but it should still not be set." + }, + { + "prediction": "I think this should be `protoVersion` instead of `currentVersion`", + "reference": "We could avoid passing proto since threshold isn't needed." + }, + { + "prediction": "I'm not sure this is the right fix. I think we need to make sure that we don't allow connections from the same IP address to the same service to the same location oracle at the same time. If we don't do that, then we'll end up with multiple connections from the same IP address to the same service to the same location oracle at the same time.", + "reference": "This route excluding needed for reconnect only when one connection is lost and we trying to establish another. I was thinking to make 2 separate flags for killswitch and reconnect enabling. This way we can keep killswitch working, but we don't need these routes excluded." + }, + { + "prediction": "I think we can remove the `LOG(INFO)`.", + "reference": "why can this modification avoid crash?" + }, + { + "prediction": "I think we can remove `current_user` from `@account` since it's no longer needed.", + "reference": "This looks good -- signing out the user if the current user is disabled" + }, + { + "prediction": "I think this should be `The collection of the selection layer levels where the whole row was selected using the row header or the corner header.`", + "reference": "The line exceeds 120 characters." + }, + { + "prediction": "I think this should be `output = output + fmt.Sprint(siteInfo)` instead of `output = output + siteInfo`", + "reference": "Let's go ahead and change \"Site\" to \"Project\", since that's the path we've chosen. One less thing to alter in the other issue." + }, + { + "prediction": "I think we should remove this line too. It's not used anymore.", + "reference": "I am for this change iff we are sure the information is no longer helpful. I think this could still be valuable for certain scenarios, wbu?" + }, + { + "prediction": "I think you can use `Comparator.comparing(ImageRampup::getRampupPercentage, Ordering.natural().reverse())` here instead of `Comparator.comparing(ImageRampup::getRampupPercentage, Ordering.natural().reverse())`", + "reference": "I thought we decided on using the latest active version and not the one which is max ramped up." + }, + { + "prediction": "I think this should be `%s to interrupt, create new public subnets, then rerun %s and import them.`", + "reference": "can we update this to a `log.Warningf`?" + }, + { + "prediction": "I think this should be `subprocess.run` instead of `subprocess.check_call` so we don't fail when trying to disconnect a container from a network that it's not connected to.", + "reference": "can we get something emitted in the logs on non-zero exits to trace back to for problems like this failing on the first invocation?" + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in the `AddVerticesProcessor` class.", + "reference": "Do we need `schema manager` at here ?" + }, + { + "prediction": "I think this should be `\"\"` instead of `C.CString(\"\")`", + "reference": "This won't work because of the permissions on the directory when this is included as a library. But, we may be able to do this. The key would be wrapping this command with either a script or a go binary that ensures the current directory is writable. If the current directory is not writable, it would attempt to make it writable so that we could write out the produced binary. But I'm not sure if that will influence the hash that gets produced for `go.sum` since I am not sure how that is calculated. Alternatively, we can choose a place in `/usr/local` or choose a location that is writable in the go cache and use that. I'll give that a try since it might be needed for the ARM builds if we choose to only include `x86_64` precompiled binaries in the module." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in the `eval` function in `pkg/repl`.", + "reference": "Correct me if I'm wrong, but is this necessary? Why not just use the value returned by `interpreter.Eval` and not mess with the scope? `interpreter.Eval` will return any produced side effects. This means TableObjects as well as any value resulting from any expression statements." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `alertmanager` service.", + "reference": "This service is global per namespace, not per Alertmanager/Prometheus/ThanosRuler instance. So this approach won't work. But maybe I missing out something, can you describe your use case here?" + }, + { + "prediction": "I think this should be `Attestations`, not `CanReattest`.", + "reference": "Do we need this default? Since we aren't using a sql.NullBool or *bool, an unset column will be interpreted as `false` already... We don't set a default on our other bool fields (e.g. entry admin and downstream columns)." + }, + { + "prediction": "I'm not sure this is the right place for this method. I think it should go in `ExportsHelper` since it's only used in `download_plan_page`", + "reference": "thanks for moving these over. makes more sense for them to be in the exports_helper" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `qutebrowser/utils/keyinput.py`", + "reference": "That import now isn't needed anymore" + }, + { + "prediction": "I think this should be `path: full path to the addon that will be installed.`", + "reference": "Can you update the `Usage` to be an absolute path as well? Something like `/path/to/firebug.xpi`" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `UAP` namespace, since it's specific to UAP.", + "reference": "This class is missing the `MvxPlugin` attribute" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the main frame class.", + "reference": "What if `wxLang` is returned `None` from `getWxLang`" + }, + { + "prediction": "I'm not sure about this change. I think it's fine, but I'm not sure I like the fact that we're passing a `std::vector` to the `ingest` function. I think we should pass a `std::vector(size_t size)` instead of a `std::vector` to the `ingest` function. This way, we don't need to pass a `std::vector` to the `ingest` function, and the `ingest` function doesn't have to pass a `std::vector` to the `ingest` function.", + "reference": "Please don't do changing like this unless it _**really**_ cares. BTW. Please look around to infer our naming conventions." + }, + { + "prediction": "I think we should use `log.info` instead of `log.finest` here.", + "reference": "This is in test code: understanding what we're doing is important in this context." + }, + { + "prediction": "I think it would be better to say something like: `Example: if --min-gas-price is in the list and condition is that either --miner-enabled or --goquorum-compatibility-enabled should not be false, we log a warning.`", + "reference": "prob should still have an example that has multiple option names even if you have to make it up. Or maybe we don't need this method?" + }, + { + "prediction": "Layout/ExtraSpacing: Unnecessary spacing detected.
Layout/SpaceBeforeBlockBraces: Space missing to the left of {.
Layout/SpaceInsideBlockBraces: Space between { and | missing.
Layout/SpaceInsideBlockBraces: Space missing inside |.
Layout/SpaceInsideBlockBraces: Space missing inside |.
Layout/SpaceInsideBlockBraces: Space missing inside |.
Layout/SpaceInsideBlockBraces: Space missing inside |.
Layout/SpaceInsideBlockBraces: Space missing inside |.
Layout/SpaceInsideBlockBraces: Space missing inside |.
Layout/SpaceInsideBlockBraces: Space missing inside |.
Layout/SpaceInsideBlockBraces: Space missing inside |.
Layout/SpaceInsideBlockBraces: Space missing inside |.
Layout/SpaceInsideBlockBraces: Space missing inside |.
Layout/SpaceInsideBlockBraces: Space missing inside |.
Layout/SpaceInsideBlockBraces: Space missing inside |.
Layout/SpaceInsideBlockBraces: Space missing inside |.
Layout/SpaceInsideBlockBraces: Space missing inside |.", + "reference": "We could put this implementation in `RTPSWriter::create_change_pool` and avoid an extra function." + }, + { + "prediction": "I think this file should be renamed to `persistencetests_test.go`", + "reference": "should this file ends with _test.go?" + }, + { + "prediction": "I think this should be `inet_pton` instead of `inet_pton`", + "reference": "It's because of this change. `ss` was unused and it made sense in the program. However I haven't read the IPv6 RFC so I'm unsure of what it does" + }, + { + "prediction": "I think this should be `flattenIndex` instead of `flattenIndex`", + "reference": "\"Flatten\" is a verb, so I'd probably go with `flattenedIndex` as a variable name here." + }, + { + "prediction": "I think this should be `valuesToMask.push(...)` instead of `valuesToMask.push(...valuesToMask)`", + "reference": "If it can only be called once, perhaps a more appropriate name is something like `setMaskables`? `addX` sounds like you can add many `X`es by calling it many times" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it's the only thing I can come up with that doesn't break anything.", + "reference": "Nodecfg should be downloading from a private bucket -- these shouldn't be for public consumption. In general these should be generic and expect environment to provide appropriate credentials and bucket." + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in the `appModuleHandler` module, since that's where the `AppModuleHandler` class is defined.", + "reference": "Could you please end the file with an empty line?" + }, + { + "prediction": "I think this should be `LOG.info(String.format(\"Detected dialect: %s\", toReturn.dialect.toString()));`", + "reference": "This is an incorrect change. The dialect spoken is an important part of the handshake and should be communicated to users." + }, + { + "prediction": "I think this should be `bool` instead of `sync.Mutex`.", + "reference": "Can this be non-exported to avoid direct use? It would be a breaking change but using previous package version would work." + }, + { + "prediction": "I think we can just return `gcerrors.InvalidArgument` here, since we don't care if it's an error or not.", + "reference": "Nit: this is just `return gcerrors.Code(err)`, isn't it?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in the `CreatePayments` call, as it is the caller of the `CreatePayments` call that needs to wait for the payment to be mined.", + "reference": "I don't know where this came from, but it's not a good idea. This is actually timing out after 5 rounds, not 5 blocks. 5 consecutive null blocks won't be that uncommon. Also when testing with a short block time, this is a very short duration that can contribute to flaky tests." + }, + { + "prediction": "I think this should be `with open(statePath, \"r\", encoding=\"utf-8\") as f:`", + "reference": "In Python 3 when pickling or unpickling objects, the file needs to be opened as binary so that no text encoding/decoding takes place. So for any open calls around pickle loads or dumps, the mode for reading must be rb and the mode for writing must be wb." + }, + { + "prediction": "I'm not sure this is the right place to do this validation. I think it should be in the `fetchMergedEventGroups` method.", + "reference": "did you remove **params.qstring.method** intentionally? if so why?" + }, + { + "prediction": "I think it would be better to have a constant for this value instead of hardcoding the default value.", + "reference": "What is the current default? Is that inconsistent across uses and that's why this is null?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the `deploy` method of the `CloudFormation` provider, since that's where the `CloudFormation` provider is instantiated.", + "reference": "Why did we make this change? How come it wasn't an issue before" + }, + { + "prediction": "Why is this removed?", + "reference": "Can you tighten scope by moving to of these variables? i.e. Move to ~4372?" + }, + { + "prediction": "I think this should be `System.getProperty(\"dataverse.rserve.password\")` instead of `System.getProperty(\"dataverse.rserve.pwrd\")`", + "reference": "Nice to see this `dataverse.rserve.password` fix rolled in." + }, + { + "prediction": "I think this should be `strnlen_s(tmp_optarg, sizeof(tmp_optarg) - 1)` instead of `strnlen_s(tmp_optarg, sizeof(tmp_optarg))`.", + "reference": "How about the following faster alternative that doesn't need `strlen()` at all: if (*tmp_optarg == '\\0' || *endptr != '\\0') { fprintf(...) ... This would treat the bus argument as invalid if it's either empty (`tmp_optarg` points to '\\0') or invalid (`endptr` points to something other that a '\\0'). Actually, the existing code would accept an empty argument and set the bus to `0`, so if (*endptr != '\\0') { fprintf(...) ... would be enough. The check for an empty argument doesn't hurt, though." + }, + { + "prediction": "I think it would be better to add `bcc: self.class.bcc_email` here.", + "reference": "I could be missing something here, but the `from` and `cc` are the same. On the test email sent to gatewaycommunicator, these values are different." + }, + { + "prediction": "I think this test is still a bit out of date, since it doesn't test that `cleanupFunction` is not called.", + "reference": "I'm honestly scared because act is now a hard requirement for useEffect which it wasn't before... This could break some tests :(" + }, + { + "prediction": "Shouldn't this be `&block_a` instead of `&block_a;`?", + "reference": "Could use election from `info_a.election`, or is this deliberate?" + }, + { + "prediction": "I think this should be `LegacyFormHelper::getType('form')` instead of `[LegacyFormHelper::getType('form')]`", + "reference": "looks like this should be `return array(LegacyFormHelper::getType('form'));`" + }, + { + "prediction": "I think this should be `assert(typeof opt_port !== 'function', `", + "reference": "Maybe it would simpler to ignore opt_port if type !== 'number'?" + }, + { + "prediction": "I think this should be `name = categoryNames[i];` instead of `name = categoryNames[i];`", + "reference": "Where was `name` being declared before?" + }, + { + "prediction": "I think this should be `UnknownDeployment` instead of `Unknown`", + "reference": "nit: use `corev1.ConditionUnknown`" + }, + { + "prediction": "I'm not sure if this is the best way to check for validity, but it's the only one I could come up with.", + "reference": "You also need to add a similar check on line 992, there's another place where we check `length === 24`" + }, + { + "prediction": "I think this should be `validatorProvider.getVoteProviderAfterBlock(parentHeader).get().getVoteAfterBlock(parentHeader, localAddress);`", + "reference": "nit: can extract the voteProvider as a local variable" + }, + { + "prediction": "I think this test is still valid, but I think it would be better to move it to a new test.", + "reference": "[0] Not suggesting you change it here, but....kindof weird that there's just not an `assertFuncNotEquals`" + }, + { + "prediction": "I think it would be better to have a separate function for this.", + "reference": "why are we passing 'registryAddress' here? We probably should construct it together with bc. Registry is not something that change?" + }, + { + "prediction": "I think this should be `RA.spreadPath`", + "reference": "`.` at the end of the sentence" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to be the only way I could get it to work.", + "reference": "wouldn't it be useful to split this into an error metric for the timing?" + }, + { + "prediction": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", + "reference": "Not sure if this is good enough. Each generator will have it's own unit test anyway. Ideally, I think I'd want to test that each generator in the yml is actually a valid generator..." + }, + { + "prediction": "I'm not sure this is the right place to do this.", + "reference": "line is 138 characters" + }, + { + "prediction": "I think it would be better to call this `cleanup` instead of `cleanupFunc`.", + "reference": "Nit: I would leave `Wire` out of the description; if you use this without wire you can still use it." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `com.google.api.tools.codegen.viewmodel`", + "reference": "Nit: each field can be on a separate line to make it visually easier to read." + }, + { + "prediction": "I'm not sure if this is the right place to put this. I think it should be in `compiler_info.json`", + "reference": "Do we still have these files? Shouldn't we remove these?" + }, + { + "prediction": "I think this should be `ErrorRenewBeforeInvalid`", + "reference": "A lot of things to do with constants seemed to move since the original commit, so I stuck this here, Is there a better place for it?" + }, + { + "prediction": "I think we can remove the `BlockChanSize` and `BlockSyncChanSize` and use the `ActionChanSize` and `ActionSyncChanSize` instead.", + "reference": "is 10 too small compared to 1000? consider sync chan is unicast only (vs block chan is broadcast + unicast), i would say use 200~400 for BlockSyncChanSize my concern is that this would potentially slowdown sync speed of full-node" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think we should move this logic into `get_plan_info` so that we don't have to call it every time we want to know if a plan is private.", + "reference": "A full parse of the plan here on listing the plans will be expensive from both a computation and IO perspective." + }, + { + "prediction": "This should be `BUTTON5` and `BUTTON6` instead of `BUTTON4` and `BUTTON3`.", + "reference": "These constants use the `_PIN` suffix, while the other constants don't use it. I'm not sure what is best, but I would prefer to keep this consistent. Do you have an opinion on which it should be (with or without suffix)?" + }, + { + "prediction": "I don't think this is a good idea. This is a command-line parameter, and it should be configurable by the user.", + "reference": "Hmm... this feels like discovery should come first. perhaps `--discovery-dns-url`? @NicolasMassart any opinions on this or ideas on who it should be run by?" + }, + { + "prediction": "Why is this removed?", + "reference": "why is this needed?" + }, + { + "prediction": "I think it would be better to keep the `name` and `type_attributes` as `ConfigType.__cache` attributes, and just add a `key` argument to `ConfigType.__init__`. This way, we don't need to worry about clearing `ConfigType.__cache` when we add a new type, we just need to worry about clearing `ConfigType.__cache` when we remove an existing type.", + "reference": "I wonder if it'd be possible to autogenerate a key from the name within this function if one is not provided explicitly, rather than having all the callsites pass both the name and key (and usually as the same value)? Might give us a good place to implement a `name->key` function that isn't 1:1." + }, + { + "prediction": "I think this should be `TYPE_I64` instead of `TYPE_STRING`.", + "reference": "@adriancole I do not see a change in the thrift file. Are there unit tests verifying that this manual serialization is compatible with the native Thrift serialization done by classes generated from `.thrift` IDL file?" + }, + { + "prediction": "This should be `return RETURNVALUE_PLAYERWITHTHISNAMEISNOTONLINE;`", + "reference": "spelling (variable name, all three changes)" + }, + { + "prediction": "I think this should be `keybase1.LoadTeamPlusKeys`", + "reference": "I believe you meant \"specify `desiredUID` and `desiredRole`\"?" + }, + { + "prediction": "I think we should use `v1beta1` for consistency with the rest of the codebase.", + "reference": "Please follow the import style, move it to its similar group" + }, + { + "prediction": "I think this should be `errors.RouterUnrecognizedEncodingError(want, name)` instead of `errors.RouterUnrecognizedEncodingError(want, string(req.Encoding))`", + "reference": "Do we really need these? This is expanding on an API that we're about to do work on with the error stuff @kriskowal" + }, + { + "prediction": "This method is not used anymore, so I think it should be removed.", + "reference": "passwordModificationTime is no longer used - did the change drop a time check that should be restored? Or should the param get dropped from the methods?" + }, + { + "prediction": "I'm not sure this is the right fix. The problem is that `commandLine` can be empty, so we can't compare it to an empty string. I think we need to do something like `if (string.IsNullOrEmpty(evt.CommandLine) || processName.Equals(evt.ProcessName, StringComparison.OrdinalIgnoreCase) && pids.Contains(evt.ProcessID) && evt.CommandLine.Trim() == commandLine.Trim())`", + "reference": "Would it break here without trim? If so, can we do trim in Startup.cs so we don't need to add this code to every parser?" + }, + { + "prediction": "nit: I think you can remove the `log.Printf` call here.", + "reference": "Since we're using Logrus, probably best to use `Infof` to avoid confusion (Logrus' Printf behaves differently to the built in one)" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `createShadowRoot_` function.", + "reference": "Hm, this looks like a change that should go upstream as well." + }, + { + "prediction": "I think we can remove this function and use `GetActionByActionHash` instead.", + "reference": "let's keep ActionByActionHash and delete getActionByActionHash" + }, + { + "prediction": "Shouldn't this be `PricingGroupInterface`?", + "reference": "please use return type" + }, + { + "prediction": "I think this should be `fine` instead of `fine`", + "reference": "This is deliberately at this level." + }, + { + "prediction": "I think this should be `as msg` instead of `as %s`", + "reference": "I'm going to go ahead and undo this change, I don't think it was intentional." + }, + { + "prediction": "I'm not sure this is the best way to say it, but it's the only way I could think of.", + "reference": "> specialised This isn't a typo in my neck of the woods" + }, + { + "prediction": "I think this should be `github.com/google/knative-gcp/test/cmd/storageTarget/target`", + "reference": "will change to `storage_target`" + }, + { + "prediction": "I think we can remove `cls.securitycenter = securitycenter.SecurityCenterClient(version='v1')` now.", + "reference": "This would be better as `cls.securitycenter_client`, to match what is being instantiated." + }, + { + "prediction": "I don't think this is the right way to do this. I think we should be using the `sys` module to get the path of the native system32 directory, and the `os` module to get the path of the syswow64 directory if it exists on the current system.", + "reference": "Could we have this initialization as part of the initialize method?" + }, + { + "prediction": "This should be `this.controllerFor('patients/edit')`", + "reference": "This line should be removed as editController is not used from this context anymore." + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in `plan/transformations` since it's only used by `plan/transformations.go` and `plan/transformations_test.go`.", + "reference": "This is correct in concept but the method signature doesn't really communicate the same thing. In other words, if the function produces an output table where is it? Its not on the function signature. Can you explain where the output table is created?" + }, + { + "prediction": "`self.pretrained = init_cfg['checkpoint']` --> `self.pretrained = init_cfg.get('checkpoint', None)`", + "reference": "For insurance, it's best not to take it directly" + }, + { + "prediction": "I think this method is not used anywhere, can we remove it?", + "reference": "change 'value' to keysToSend, here and in other references in this commit. 'value' implies the user is getting the value of the element, rather than just the keys we're sending to it." + }, + { + "prediction": "I think this should be `engine.state.AddTaskIPAddress(taskIP, task.Arn)`", + "reference": "is the plan to fully migrate to boltdb and then remove the state save here?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the styles.js file, since it's only used there.", + "reference": "This should be `output.colorBright`. Unless I'm missing some reason for adding a new theme variable." + }, + { + "prediction": "I don't think we need this. We already have a `version.py` file in the root of the repo. You can add the following to `setup.py` in the root of the repo: `python_requires='>=3.5,<3.7'` And then you don't need the `version.py` file in the root of the repo.", + "reference": "nit: I wonder if these should be moved down to where version is defined, just to keep them all in the same place." + }, + { + "prediction": "I think this should be `import java.lang.*;\\nimport java.util.*;\\nimport javax.annotation.*;\\n` and not `import java.lang.*;\\nimport java.util.*;\\nimport javax.annotation.*;\\n`", + "reference": "Is this supported by every implementation of Java (and Android)? Should it be conditional upon `gen_nullable`?" + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "@briri Thanks! I just caught this too updating my feature branch" + }, + { + "prediction": "I think this should be `envpw != \"\"` instead of `envpw != \"\" && len(configKey) == 0`", + "reference": "I think you should move this block (and the `envpw := os.Getenv(\"RCLONE_CONFIG_PASS\")`) right to the start of the function, then we can remove the duplicate code below" + }, + { + "prediction": "I think this test should be moved to `RemoteNodeTest` instead of `NodeTest`", + "reference": "Is this only to set the node to draining? I think we can do that inside `Before` or something?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think we should move this logic to `AppServicesInstrumentation` since it's specific to Asp.Net.", + "reference": "This should have been moved up above this inner `try` because the log message in the `catch` block does not apply to this." + }, + { + "prediction": "I'm not sure if this is a good idea, but I don't have a better suggestion.", + "reference": "Do we expect people to use PlanResult directly?" + }, + { + "prediction": "I think this should be `return wait.ExponentialBackoff(backoff, func() (bool, error) { return condition() })`", + "reference": "Maybe we should call this something like `errToReturn`?" + }, + { + "prediction": "Why do you need to check `epochNum >= fairBankEpochNum+a.foundationBonusLastEpoch`?", + "reference": "should calculate numEpochIn1Year = xxx and <= fairBankEpochNum+numEpochIn1Year a.foundationBonusLastEpoch just happens to be equal to 1 year now, but should not count on that" + }, + { + "prediction": "I think this should be `contentTypes: ['embedded', 'phrasing', 'flow']`", + "reference": "I wasn't sure if the content type needed to be removed from both the `default` and `usemap` objects - I'm not sure how usemap is used." + }, + { + "prediction": "I don't think you need to import `struct` here.", + "reference": "Duplication of line 28 Please refer your tox -e flake8 It seems that XStrField, XShortField, FieldLenField are not used" + }, + { + "prediction": "I think this should be `self._file_view.setRowHidden(index.row(), path, hidden)` instead of `self._file_view.setRowHidden(index.row(), index.parent(), hidden)`", + "reference": "I don't really understand the `self._file_model.index(path)` as parent here - you use `self._root_index` for `rowCount` above, so wouldn't the parent here need to be `self._root_index` as well?" + }, + { + "prediction": "Should this be `maxQueryLength` or `minQueryLength`?", + "reference": "Do we want validation somewhere that max >= min? Or simply treat the max < min case as ignoring max?" + }, + { + "prediction": "I think this should be `ndc:topframes` instead of `${ndc:topframes=1}`", + "reference": ":+1: that's a easier example :)" + }, + { + "prediction": "Why do we need this method?", + "reference": "If an external module decorates this interface, such a change will cause it to generate an error" + }, + { + "prediction": "(style) 'FN' may be misspelled - perhaps 'FN'? (style) 'FN' may be misspelled - perhaps 'FN'?", + "reference": "Oh ha hah, FNM_PERIOD worked out nicely there. Points for co-opting a file system convention." + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in `github.com/elastic/beats/libbeat/cmd/elastic`", + "reference": "wrong grouping. As you can tell from the other files, we put system packages in the first group, the 3rd party packages in the second group, and our own packages in the third group." + }, + { + "prediction": "I think this should be `if _, err := o.configStore.GetJob(o.appName, o.name); err != nil {`", + "reference": "Is `o.name` always set here?" + }, + { + "prediction": "I think this should be `verifyStatusResolvable(target, nameMap, target.SteadyStateDependencies, onSteadyStateCanResolve)` instead of `verifyStatusResolvable(target, nameMap, target.SteadyStateDependencies, onSteadyStateCanResolve)`", + "reference": "Can this line be removed, as `SteadyStateDependencies` isn't updated anywhere? Also do we need to check the `TransitionDependencySet` here?" + }, + { + "prediction": "Metrics/CyclomaticComplexity: Cyclomatic complexity for has_active_subscription is too high. [7/6]
Metrics/PerceivedComplexity: Perceived complexity for has_active_subscription is too high. [8/6]", + "reference": "`plan.present?` and `has_active_subscription?` are equivalent. We can drop this change, while leaving the one on `app/controllers/application_controller.rb`." + }, + { + "prediction": "I think this should be `too-many-arguments`. We don't want to allow more than 29 positional arguments.", + "reference": "No need for this, as pylint already only turns things off for this function and it's needed for the entire function." + }, + { + "prediction": "I'm not sure this is the right fix. I think we need to make sure we don't informer for the `alertmanager` namespace if it's already informer for the `alertmanager_config` namespace.", + "reference": "L171 needs to be modified too?" + }, + { + "prediction": "(style) 'e' may be misspelled - perhaps 'it'? (style) 'e' may be misspelled - perhaps 'it'? (style) 'e' may be misspelled - perhaps 'ith'? (style) 'e' may be misspelled - perhaps 'ith'? (style) 'e' may be misspelled - perhaps 'ith'? (style) 'e' may be misspelled - perhaps 'ith'? (style) 'e' may be misspelled - perhaps 'ith'? (style) 'e' may be misspelled - perhaps 'ith'? (style) 'e' may be misspelled - perhaps 'ith'? (style) 'e' may be misspelled - perhaps 'ith'? (style) 'e' may be misspelled - perhaps 'ith'? (style) 'e' may be misspelled - perhaps 'ith'? (style) 'e' may be misspelled - perhaps 'ith'? (style) 'e' may be misspelled - perhaps 'ith'? (style) 'e' may be misspelled - perhaps 'ith'? (style) 'e' may be misspelled - perhaps 'ith'? (", + "reference": "Why do you compare by nodeid? Simply saying d == e should be enough. Unless we have to objects in memory with the same nodeid. If that is so, something went really wrong." + }, + { + "prediction": "I don't think we need to add `coco_detection` here, since it is not used in RetinaNet.", + "reference": "configs/pvt/retinanet_pvt_t_fpn_1x_coco.py --> configs/pvt/retinanet_pvt-t_fpn_1x_coco.py" + }, + { + "prediction": "I'm not sure if we should have a `DesiredStatus` field here. I think it's fine to have it, but I'm not sure if it makes sense to have it in the `TaskResponse` struct at all.", + "reference": "Nit, this could be json:\",omitempty\"" + }, + { + "prediction": "I think this should be `BuildRequiredFunc` or `BuildRequired`.", + "reference": "It's kinda funny to read `s.Image.Image` I wonder why it resulted to this way. What would it take to refactor to just `s.Image`?" + }, + { + "prediction": "Why is this change needed?", + "reference": "nit: I like the idea! can we instead change the tag to `integration-remote` to be more specific? I feel like it's possible for us to use the `deploy` build tag for possibly another scenario" + }, + { + "prediction": "This should be `int32 param_1 = (int32)SVIV(ST(1));`", + "reference": "Copy and paste error here. Edit: Also missing commas here and in other Perl croaks between some parameters and not others." + }, + { + "prediction": "I don't think we need this interface. We can just use `IPendingTxSelector` in the `PendingTxSelector.cs` file.", + "reference": "stateRoot or maybe ParentHeader would make more sense from API point of view?" + }, + { + "prediction": "Why is this removed? It seems to be the only place where we are calling `callback.setupNotification(false, info);`", + "reference": "Are you sure that this is no longer needed?" + }, + { + "prediction": "I think it would be better to have this list as a static field in `BaseTableScan` instead of adding it to `SCAN_COLUMNS` and `SCAN_WITH_STATS_COLUMNS`. The reason is that `BaseTableScan` is used in multiple places, and having this list as a static field ensures that it is always up-to-date.", + "reference": "Would it help to use SCAN_COLUMNS as base to build SCAN_WITH_STATS_COLUMNS e.g like so `SCAN_WITHSTATS_COLUMNS = ImmutableList.builder().addAll(SCAN_COLUMNS).add(\"value_counts\",....).build()` ?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `piped/monitoring` since it's related to monitoring.", + "reference": "`ctx` is unused in ReportStat" + }, + { + "prediction": "Please don't include `list` and `map` in `boost` headers. They are not standard C++ headers, and should not be used in `boost` headers. Instead, use `boost::list` and `boost::map` from the `boost` header.", + "reference": "We don't want to add boost as a dependency when building the Thrift compiler. Sorry." + }, + { + "prediction": "This should be `int32_t minSpeedChange = 0;` and `int32_t maxSpeedChange = INT32_MAX;`", + "reference": "It's not printing the range. Also I think it's useful to print a warning above stating that the minimum change is -1000." + }, + { + "prediction": "I don't think this is the right place to do this. I think we should move this to `cluster/v1beta1/cluster` or `cluster/v1beta1/internal/cluster`", + "reference": "if name is empty will this become enumerate ? (and cause the unmarshal to fail ?)" + }, + { + "prediction": "Metrics/LineLength: Line is too long. [122/120]", + "reference": "How about including a flash message that explains the exercises are only available to subscribers of X plan?" + }, + { + "prediction": "I'm not sure this is the best way to do this. The problem is that we don't have a way to tell if the key was a backspace or something else, so we can't tell if we should leave the window or not. I'm not sure what the best way to do this is, so I'm not sure this is the best way to do it.", + "reference": "You should also call `e.accept()` and `return` so the key press isn't processed further (as we're leaving insert mode anyways)." + }, + { + "prediction": "I think this should be `ENV.fetch(\"EMAIL_RECIPIENTS\", \"noreply.sendgrid.net\")`", + "reference": "Freeze mutable objects assigned to constants." + }, + { + "prediction": "I think this should be `await expect( page ).toClick( '#googlesitekit-opt-in' );`", + "reference": "Hmm, this feels hacky. Maybe good enough if it makes the test more stable, but why is timing even an aspect here, since below it should wait for these two things anyway?" + }, + { + "prediction": "I'm not sure this is the best place to do this, but I don't have a better suggestion.", + "reference": "Do we want this on by default, or an opt-in (e.g. via some config while add the instrumentation)? I guess a more general question is - what's the bar for the default vs opt-in tags." + }, + { + "prediction": "I think this should be `graph` instead of `status`", + "reference": "`status` is just one of the features, named as status is not suitable." + }, + { + "prediction": "I'm not sure this is the best way to do this. Feeds are filtered by the user, not the system. Feeds are filtered by the system, not the user. Feeds are filtered by the user, not the system. Feeds are filtered by the system, not the user. Feeds are filtered by the user, not the system. Feeds are filtered by the system, not the user. Feeds are filtered by the system, not the user. Feeds are filtered by the system, not the user. Feeds are filtered by the system, not the user. Feeds are filtered by the system, not the user. Feeds are filtered by the system, not the user. Feeds are filtered by the system, not the user. Feeds are filtered by the system, not the user. Feeds are filtered by the system, not the user. Feeds are filtered by the system, not the user. Feeds are filtered by the system, not the user. Feeds are filtered by the system, not the user. Feeds are filtered by the system, not the user. Feeds are filtered by the system, not the user. Feeds are filtered by the system, not the user. Feeds are", + "reference": "There is an option to hide the subscriptions list from the sidebar. If it is hidden, the filter text should not be displayed." + }, + { + "prediction": "I think this should be `memoryCircuitBreakerThreshold` instead of `memoryCircuitBreakerThresholds`", + "reference": "I'd like for all of this to be dynamically configurable at some point, but it doesn't have to be in this PR. Can add it to the future SIP or create a separate JIRA for it, as you think would be appropriate." + }, + { + "prediction": "Why is this removed?", + "reference": "move the constructor to down the `namespace`" + }, + { + "prediction": "I think we should rename this field to `FederatedClusterID` or `FederatedClusterRef`.", + "reference": "Nit: ending with a '.' looks consistent with the fields around it." + }, + { + "prediction": "I'm not sure if this is the right place to add the audit fields. I think it should be done in `svidv1.MintJWTSVIDResponse` constructor.", + "reference": "Audit log will not have a warning about they are using a deprecated path, is it something we must care about?" + }, + { + "prediction": "I think this should be `contract.Visibility != TypeMemberVisibility.FamilyOrAssembly && contract.Visibility != TypeMemberVisibility.Family` instead of `contract.Visibility != TypeMemberVisibility.FamilyAndTypeMemberVisibilityOrAssembly`", + "reference": "I think you also want to update the condition to add ` || impl.Visibility == TypeMemberVisibility.FamilyOrAssembly`." + }, + { + "prediction": "I think this should be `uint64(100000)`", + "reference": "`DepositToRewardingFundBaseGas` is a global variable (from `gochecknoglobals`)" + }, + { + "prediction": "I think it would be better to have this be `Development` instead of `Operational` to be consistent with the rest of the CLI.", + "reference": "What do you think of \"operations\"?? Also what do these emojis look like on Linux??" + }, + { + "prediction": "I think it would be good to have a link to the pricing page in the tagline. I know it's a bit of a stretch, but I think it'll make the tagline a bit more useful.", + "reference": "I like the word \"give\" here. Feels like I'm giving a gift to my team." + }, + { + "prediction": "I don't think you need to import ` randint` and `uniform` here. You can just use `randint(0, 100)` and `uniform(0, 100)`.", + "reference": "Is it possible to use `np.random` module instead?" + }, + { + "prediction": "I think this should be `None` by default. If you want to allow `None` then you need to add `allow_none=True` to the docstring.", + "reference": "``default=None`` implies ``allow_None`` so ``allow_None`` is superfluous here. As a special case, if allow_None=True (which is true by default if the parameter has a default of None when declared) then a value of None is also allowed." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in `system:k3s-controller` instead of `system:k3s-controller`", + "reference": "Is there anything in particular that makes setting up the downstream rolebinding(s) to `system:k3s-controller` burdensome or confusing? This changes looks fine to me but it seems a shame to alias an embedded k3s controller. If we are doing this in other places that I am not aware of then we can dismiss this concern out of hand." + }, + { + "prediction": "I'm not sure if we want to use `go-acd` or `github.com/ncw/go-acd` here.", + "reference": "File is not `goimports`-ed (from `goimports`)" + }, + { + "prediction": "I don't think we need this file at all. We can just use `OS.Name` and `OS.Architecture` from `System.Runtime.InteropServices`.", + "reference": "nit: all other types in this project have full names, so maybe a better name would be `OperatingSystem`?" + }, + { + "prediction": "I think this should be `#include \"MolTransforms.h\"`, not `#include `", + "reference": "Why is this needed here?" + }, + { + "prediction": "I think this should be `throw new UnsupportedOperationException(\"Not yet implemented\");`", + "reference": "mmm, why a method declaration should not have the TypeVariableResolutionCapability? Is this ok?" + }, + { + "prediction": "I think you can remove the `final` here and in the other constructors as well.", + "reference": "nit: any reason you swapped the ordering?" + }, + { + "prediction": "\").dispatchEvent(new CustomEvent(\"change\", {\n dom: page.getElementsByTagName(\"input\")[0]\n }));\n```\nReview comment?", + "reference": "can you de-uglify at least this line?.. hard to tell what changed..." + }, + { + "prediction": "I think we should rename `LoadSockopsAuto` to `LoadSockops`.", + "reference": "Please can you merge master in before making these changes. I just reinstated a bunch of BPF UTs. Possible that the UTs use this code." + }, + { + "prediction": "I don't think this is a regression test.", + "reference": "Do you want to add additional cases for `Bla.__b()` and `self.__c()`? (Just add additional classmethods `__b` and `__c` and the calls to `__init__`)" + }, + { + "prediction": "I think this should be `len(recids)`, not `len(get_current_user_records_that_can_be_displayed(qid))`.", + "reference": "the recids is never changed after. So, it should contains the exact shown results, whatever are the rights for the user (admin or simple user, restricted collections...)" + }, + { + "prediction": "I'm not sure this is the right way to do this. I think we should be able to pass in the md5sum of the file, rather than the md5sum of the entire file.", + "reference": "Shouldn't the docstring mention that the MD5 checksum of `p` is computed each time and verified? Also, could there be use cases where a caller might not want such a check to happen because, eg, a blob storage solution doesn't provide MD5 verification or uses another hash algorithm such as SHA256?" + }, + { + "prediction": "I think this should be `if obj.focusRedirect and (eventName==\"gainFocus\" or eventName==\"releaseFocus\")`", + "reference": "focusRedirect is used in the powerpnt appModule. We might have to make sure that this does not break. Having said that, I really like this being handled on the events level!" + }, + { + "prediction": "I think you can remove this line.", + "reference": "You imports are out of order" + }, + { + "prediction": "I think it would be better to have a constant for this.", + "reference": "This should not be called Flow Trigger. FlowTrigger should has its own flowTrigger job name, for instance, \"flowtrigger\"" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `sql/sqlite3.go`", + "reference": "File is not `goimports`-ed (from `goimports`)" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `Program.cs`, not in `Stress.cs`.", + "reference": "Why do we need `\\n` if we already use `WriteLine`? (and `\\n` is not cross platform)" + }, + { + "prediction": "I think it would be better to have a constant for this.", + "reference": "What is instrumentation name used for? I'm not seeing other classes use it, only a getter, constructor, and builder." + }, + { + "prediction": "I'm not sure if this is a good idea, but I don't see any other way around it.", + "reference": "@kristofgazso could you review these warnings?" + }, + { + "prediction": "This file should not be included in this PR.", + "reference": "will delete this." + }, + { + "prediction": "Layout/TrailingWhitespace: Trailing whitespace detected.", + "reference": "~~Indent 2 lines above~~ Disregard. My fault" + }, + { + "prediction": "I don't think this is the right place for this check. I think we should move this check to `org.mule.runtime.core.api.context.impl.DefaultMuleContext` instead of `org.mule.runtime.core.api.context.impl.DefaultMuleContextConfiguration`.", + "reference": "What was the bug that this is fixing?" + }, + { + "prediction": "I think it would be better to use `urllib.quote_plus` instead of `base64.b64encode`", + "reference": "This will always add the authorization header to the request object. Is this the right scope for these two lines? If username/password are not defined, it will encode 'Basic :'" + }, + { + "prediction": "I think this should be `\"/com_github_google_flatbuffers/tests/\"` instead of ` \"../com_github_google_flatbuffers/tests/\"`", + "reference": "Is this always how Bazel does paths? Would it be nicer to do `-DBAZEL_TEST_DATA_PATH=../com_github_google_flatbuffers/tests/` so this string is not hardcoded in the the source?" + }, + { + "prediction": "I think this should be `date_utc` instead of `date`", + "reference": "Not an expert of ES, so not sure of the impact here." + }, + { + "prediction": "I'm not sure why this change is needed.", + "reference": "Who deletes the memory for the granteeList? (or the roleList for that matter)" + }, + { + "prediction": "I think this should be `ws_listener.decrease_subscription_count (subscriptions.begin (), subscriptions.end ())`", + "reference": "This loop is missing a lock on subscriptions_mutex." + }, + { + "prediction": "Line is too long. [82/80]", + "reference": "shouldn't clearance be setting these up for us?" + }, + { + "prediction": "I think this should be renamed to `noop` instead of `defaultServiceNameDetector`.", + "reference": "Need to update the doc for `TelemetrySDK` and `Host` structs deleting references from removed functions." + }, + { + "prediction": "I think this should be removed as well.", + "reference": "I think we should keep that here and add a new method `isSyntacticallyFinal` that returns `super.isFinal()` (and can be used in UnnecessaryModifier). Otherwise the contract of `isFinal` is not respected" + }, + { + "prediction": "I think this should be `if (gridCol.colDef.enableCellEditOnFocus === true) {` instead of `if (gridCol.colDef.enableCellEditOnFocus === true) {`", + "reference": "Is there a reason why we wouldn't want to check this every time? Why are we only checking for the footer and scroll bar when enableCellEditOnFocus is true?" + }, + { + "prediction": "This import is not needed.", + "reference": "You need to create an API for this class. This class should follow roughly the same dependency structure than RemoteAvailableInstallersPlayOnLinuxImplementation / RemoteAvailableInstallers. Maybe we could use a inner class here?" + }, + { + "prediction": "I think this should be `workflow_id = VALUES(workflow_id)`.", + "reference": "This should not be a case, right? If `run_id` is the same `workflow_id` can't be changed. Actually surprised that it is not part of a key." + }, + { + "prediction": "I don't think this is the right fix. The problem here is that the lock conflict error 8558 is not specific to AQR, it's a general error that occurs during the update process. So disabling AQR here is not going to solve the problem. I think we need to find a way to prevent the error from occurring in the first place. One way to do this is to make sure that the lock is acquired before entering the update loop. Another way is to make sure that the lock is released before exiting the update loop.", + "reference": "How would AQR work for an INSERT/SELECT of one table into another where a LOB column is being copied?" + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be under `github.com/envoyproxy/go-control-plane/envoy/service/discovery/v2`", + "reference": "Since these are ultimately different endpoints, it would be nice if we could move them up one level and nuke the common `sds` directory in order to reduce path stutter" + }, + { + "prediction": "`beforeChangeResult === false || beforeChangeResult[0] === null` -> `beforeChangeResult.length === 0 || beforeChangeResult[0] == null`", + "reference": "Please check also whether `null` occurs in the rest of `beforeChangeResult` array." + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in `transport/unary.go`", + "reference": "Outdated docs. There is no response, there's an ack." + }, + { + "prediction": "I think this should be `return fmt.Errorf(\"cannot start a container that has run and is stopped\")`", + "reference": "I'd rather have the container process remove the FIFO after it unblocks. Then `start` can always `Exec()`, and you can catch the \"FIFO does not exist\" error and translate it to a prettier \"someone must have already started the container\"." + }, + { + "prediction": "I'm not sure if this is the right place to do this check. I think it should be done in the `getTransactionFromActionInfo` function, but I'm not sure if that's the right place to do it.", + "reference": "can you check if there's other similar cases to add nil-check like this?" + }, + { + "prediction": "Shouldn't this be `is_valid_commonname = commonname is not None and len(commonname) < 64`?", + "reference": "`<= 64`? I just picked up what you said in #3981 (\"the CN field is limited to 64 characters\") but maybe there's something I don't know where the 64th character is needed (trailing dot or whatever?) Also this sounds like something that could be beautifully unit tested. Sorry for bugging you :grin:" + }, + { + "prediction": "Line is too long. [83/80]", + "reference": "I understand that this grabs a Licenses objects but what is the autocomplete method used for? What does this do in context of the auto_completes controller?" + }, + { + "prediction": "I think this method should be called `transactionLocation` instead of `transactionLocationByHash`", + "reference": "I don't really like that way of naming methods based on their arguments. But I can see that the other method names are the same ..." + }, + { + "prediction": "I don't think this is the right place to do this. This is only used in one place, and that is in `org.apache.druid.java.util.common.Base64Encoder`. I think it would be better to move this method to `org.apache.druid.java.util.common.Base64Encoder`.", + "reference": "@sekmiller This method correctly strips the leading and trailing slashes (and also \".\" and \"-\"); But I thought the plan was also to replace any multiple slashes between nested folders with a single slash. For example, as implemented now, I can enter \"folder1///folder2\", and it gets saved and displayed like this, with the 3 slashes. I thought we wanted to sanitize it as \"folder1/folder2\"." + }, + { + "prediction": "I think this should be `int64_t pid;`", + "reference": "Looks like the X86 inline assembly is not happy with this type. I will update that" + }, + { + "prediction": "Line is too long. [83/80]", + "reference": "Tabs and a space, again." + }, + { + "prediction": "This should be `return \"\";` instead of `std::string();`", + "reference": "Please just enclose if blocks with brackets; this has created issues in the past so I'd prefer we don't use them" + }, + { + "prediction": "I'm not sure why this was here in the first place, but I'm not sure why it's gone now either.", + "reference": "`version` isn't need anymore because it's built into `approve_proposal_url`, yes?" + }, + { + "prediction": "I don't think this is needed, it's already imported in `scapy.layers.dot11._dbmField`", + "reference": "Moved to the bottom of the file. `CtrlPDU` sits on `BTLE_DATA` so let's put it after" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "This ends up requiring the `json` gem, right? Is there any way we can do this to be implementation agnostic (e.g. to let me use `yajl-ruby` for performance reasons (or because my app already brings in a JSON library)" + }, + { + "prediction": "I don't think this is correct. We should be returning an error if we hit an error.", + "reference": "This seems dangerous. What circumstances lead to the need for a retry? Can that happen more than once? I'm concerned that if we hit the pathological state, this could turn into a CPU spinner. I wonder if we could get the same benefit from just \"trying again\" and failing if it fails the second time." + }, + { + "prediction": "I think this should be called `startingSnapShotId` instead of `startingSnapshotId`", + "reference": "If there is a reference to other fields or methods, please do the initialization in the constructor." + }, + { + "prediction": "I think it would be better to have this in a separate file, so that it can be easily moved to another PR if needed.", + "reference": "These should be importing from `pill-container`" + }, + { + "prediction": "This should be `player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE);`", + "reference": "Why this change? It will now only show on the bottom of the screen as white text, is it correct behaviour?" + }, + { + "prediction": "I'm not sure this is the right place for this method. I think it should be in `view_config.rb` since it's only used there.", + "reference": "Does this need to allocate a string or would a nil value (indicating no header) be a better?" + }, + { + "prediction": "I think this should be `component` instead of `constructor`", + "reference": "Nit: Past tense of `reset` is also `reset`." + }, + { + "prediction": "I think it would be better to have a `get_fee` method in the config module, and have it return the value of `config.fee_per_kb()`. This way, you don't have to pass the config value to the command, and you don't have to pass the command to the config.", + "reference": "Shouldn't this use `'n'` instead?" + }, + { + "prediction": "Shouldn't this be `enumsspb.TASK_TYPE_TIMER_TASK_TIMEOUT`?", + "reference": "revert back to 'TASK_TYPE_ACTIVITY_TIMEOUT'" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `GetBlock` overload.", + "reference": "Shouldn't we prefer passing a pointer by reference T*&, since these are C++ bindings?" + }, + { + "prediction": "I think you can remove the `iFromPeers.IPBlocks = append(iFromPeers.IPBlocks, ipb...)` line here.", + "reference": "nit: Personally I feel that it's cleaner to let `toAntreaPeerForCRD` to take `ingressRule` as a param instead of `ingressRule.From`. It can call `processRefCGs` inside the function and do the ipBlock/AG union within the function itself. It might not be worth the refactor though." + }, + { + "prediction": "I think this should be `api.ReconcilePending` instead of `api.ReconcileRequested`", + "reference": "Pending has been set only for SPC.. why? for other CRs as well, this need to be done.. right?" + }, + { + "prediction": "I think this should be `||` instead of `===`", + "reference": "would use an empty string here as default and then check for emptiness in the twig template. I dont like mixing types @core23 what do you think?" + }, + { + "prediction": "I think this should be `PAGE_TOKEN_NAME` instead of `PAGE_TOKEN_PAGE_TOKEN_NAME`", + "reference": "How come we need case manipulation for the nextPageToken and not for pageToken?" + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "why use these rather than regular named paths?" + }, + { + "prediction": "I think this should be `format` instead of `guide`", + "reference": "Hm, I don't think the extra flags are doing any harm here, but it does seem like `--help` is the only flag you could *actually* use with this command. We might eventually want to separate those out." + }, + { + "prediction": "I think this should be `similar_artists_candidate_set_df` instead of `similar_artist_candidate_set_df`.", + "reference": "We should make this a docstring, so that editors are able to pick it up." + }, + { + "prediction": "I'm not sure this is the right place for this test. I think it should go in `feature/requests/show.html.erb` since that is where the request is being made.", + "reference": "Put a comma after the last parameter of a multiline method call." + }, + { + "prediction": "I think this should be 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024", + "reference": "App cache size is now managed dynamically by the `WebView`. This statement has no effect in the new framework." + }, + { + "prediction": "I think this should be `return typeof virtualNode.attr('alt') === 'string' && (nn === 'img' || nn === 'input' || nn === 'area')`", + "reference": "VirtualNode has a `hasAttr` function, any reason why you're not using it?" + }, + { + "prediction": "I don't think this is the right place to do this. I think it should be done in the `HttpAccess` class itself.", + "reference": "This now throws when running tests (maybe the move to java 11??). Do we want to keep it?" + }, + { + "prediction": "I think we can drop the `[:10]` now, since it's the same as `len(sha1) > 7`", + "reference": "We can allow 7-char SHA, does not mean we want to show with 7-char in default, please change to `if len() > 10`, then cut." + }, + { + "prediction": "I think this should be `noDuplicates: 'Cannot add the duplicate file %{fileName}, it already exists'`, not `noDuplicates: 'Cannot add the duplicate file: %{fileName}, it already exists'`", + "reference": "this one should also have quotes i guess :)" + }, + { + "prediction": "I think this should be `t.Fatalf(\"Test %s failed, expected %v but got %v\", name, mock.expectedName, b.unstruct.Object.GetName())`", + "reference": "Using the variable on range scope `mock` in function literal (from `scopelint`)" + }, + { + "prediction": "I'm not sure this is the right fix. If the workflow is completed, then the dataset has been created, so it should be ok. If the workflow is not completed, then the dataset has not been created, so it should be accepted.", + "reference": "does this result in a 200 when the dataset is still inprogress/publishing not yet finalized? Seems like 202 is the right code for that (as it was) and the test should be watching for a 202?" + }, + { + "prediction": "I think this should be called `smartSqlOrderPath` to be consistent with `smartSql` and `smartSqlQueryType`.", + "reference": "Previously you could only order by the field you were searching by. But for full-text search, you can search across all indexed fields, and it didn't make sense not to have a sorting. For backward compatibility, the javascript code uses indexPath as the orderPath when no orderPath is provided." + }, + { + "prediction": "I think this should be `|` instead of `?`", + "reference": "VIM didn't like your whitespace." + }, + { + "prediction": "Why is this being removed?", + "reference": "Are you sure the namespace should change?" + }, + { + "prediction": "Why is this change necessary? I don't see any callers to `Startup`.", + "reference": "@martijn00 I'm not sure why we're keeping the object parameter and return type since this can be done by using MvxApplication with THint set to object" + }, + { + "prediction": "I think it is better to add `TIME` in `TimeType` class itself, so that we don't need to create a new class `TimeType` when we want to add a new time type.", + "reference": "why do we create a time type here?" + }, + { + "prediction": "This file should be renamed to `components/listview/listview.js`", + "reference": "Does this style actually need to get loaded in all of these components?" + }, + { + "prediction": "I don't think we need to import `DefaultAccessLogPatternParser` and `AccessLogHandlerImpl` here.", + "reference": "import but not used so you did not resolve compile warnings?" + }, + { + "prediction": "This should be `static_cast(std::ceil(armorValue * 0.475));`", + "reference": "This is so much more concise and beautiful than the previous formula" + }, + { + "prediction": "I think this should be `final`", + "reference": "Is there any reason not to have the `static` modifier for the logger? _(that would be in keeping with the reference being uppercase)_" + }, + { + "prediction": "I'm not sure this is the right place for this interface. I think it should be in the `provider` package, since that's the package that contains the `provider.go` file.", + "reference": "It's not about session creation config. It's about passing consumer config parameters to underlying transport - nothing to do with session itself" + }, + { + "prediction": "I think this should be `loggerFn`, not `loggerFnOverride`. The reason is that `loggerFn` is a function that takes no arguments and returns a logger, whereas `loggerFnOverride` is a function that takes two arguments, the prefix and an enable/disable flag.", + "reference": "Why is there an \"enable\" in the param name? Couldn't it just be `overrideDebug`? Here are everywhere else." + }, + { + "prediction": "I'm not sure if this is the right place for this action. I think it should be moved to `Video` controller, but I'm not sure if there is a better place to move it.", + "reference": "`published.recently_published_first` reads a little oddly to me. Is this the same thing as `Video.published.ordered`?" + }, + { + "prediction": "I think this should be `throw new Error('Unable to parse content of ' + file.originalPath);` instead of `throw new Error('Unable to parse content of ' + file.originalPath.replace(extRegex, '.html'));`", + "reference": "Encountered this because I had a stray comma. Figured I'd tweak it a bit." + }, + { + "prediction": "I think this should be `0.5s` instead of `8s`.", + "reference": "qq: Should this include the iptables6-save sim. to the inverse checks above?" + }, + { + "prediction": "I'm not sure this is the best way to do this. I think we should be able to just use `reflect.DeepEqual` here.", + "reference": "im open to explicitly checking NotSet value here but json logic already handles it so kept it this way." + }, + { + "prediction": "This should be moved to the top of the file.", + "reference": "The naming of the include file appears to be unlucky." + }, + { + "prediction": "I'm not sure this is the best way to do this, but I don't have a better suggestion. The problem is that `legend_opts` is a `dict` and `axis` is a `matplotlib.axes.Axes` object, so you can't just pass `axis` to `legend_opts` and expect it to be a `dict`. You need to convert `axis` to a `matplotlib.axes.Axes` object before you pass it to `legend_opts`, and then you can use `axis.get_legend()` to get access to the `Legend` object.", + "reference": "Bit worried about this. At minimum you should make a copy of the dict here to avoid modifying a user supplied variable." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in the `CreateLaunchTemplate` function, since that is the place where `CreateLaunchTemplateVersion` is called.", + "reference": "Is it better to create one before pruning? In case creation fails we don't want to delete the previous one. We create a new one, it is tagged as latest, so the previous can be deleted. `CreateLaunchTemplateVersion` returns the version created, how about directly trying to delete the previous version? Assuming the numbering is strictly increasing." + }, + { + "prediction": "This should be `ContainerDTO` instead of `WinePrefixContainerDTO`", + "reference": "Do we require the specific implementation information here?" + }, + { + "prediction": "I'm not sure this is the best name for this method. It's a bit confusing because we're checking if the email address contains the entire domain, not just the last part of it. Maybe something like `email_banned?(email_address.split(\"@\")[0])` would be better?", + "reference": "How about `exists?(['domain ~* ?', domain.downcase])` ?" + }, + { + "prediction": "I think we can remove the `newContextWithTimeout` function now, since we don't need it anymore.", + "reference": "Is this getting used in other places? Can we switch all the places to use the new API you added?" + }, + { + "prediction": "I'm not sure why this is being removed. It seems to be the only place where it is used.", + "reference": "This need to be checked with linux. AFAIK, we have this file in our bin directory that is a link to the system file." + }, + { + "prediction": "I think we can remove the `/* eslint-disable indent */` from this file.", + "reference": "Shouldn't we import `default`? I can't get here to test." + }, + { + "prediction": "I think this should be `unix_socket` and not `self.unix_socket`.", + "reference": "!!!!!!!!!!!!! @graingert, does this mean that tests haven't been running???" + }, + { + "prediction": "Should this be `type == null` instead of `type != null`?", + "reference": "I've already tried the null-coalescing operator here and got a strange error, so did this the old-fashioned way." + }, + { + "prediction": "I think it would be better to use `!parent.hasAttribute('role') || parent.hasAttribute('role') === 'list'`", + "reference": "This doesn't follow our spacing convention. It's also a little hard to read. Can you reformat?" + }, + { + "prediction": "I think we can remove the `internal` prefix from the package name.", + "reference": "The deploy should come before template? EDIT: I see that in other files, we put a separate line and put deploy at the end. What is the reason for this?" + }, + { + "prediction": "I'm not sure this is the right way to do this. I think we need to add a new configuration type for aggregations that can be dropped.", + "reference": "Consider making a constant (e.g. `MetricStreamConfiguration.Drop`)." + }, + { + "prediction": "I don't think this is necessary.", + "reference": "same question: why not just switch this to range too?" + }, + { + "prediction": "This should be `const Type type(m_IO->InquireVariableType(name));`", + "reference": "@chuckatkins most places used an empty string for \"no type\", but a few used `\"unknown\"`. I've converted both cases to `Type::None`. Do you know why there was a distinction before?" + }, + { + "prediction": "I think this should be `static_cast(std::min(train_data_->FeatureGroupSizesInByte(i), num_data_))`", + "reference": "should we assert for the type for `FeatureGroupData` ? I think it should be 1-Byte type." + }, + { + "prediction": "I think this should be `np.array([[[ 0, 4, 8], [ 1, 5, 9], [ 2, 6, 10], [ 3, 7, 11]], dtype=np.int32])`", + "reference": "As long as you are sure this is definitely correct now... :-)" + }, + { + "prediction": "I think it would be better to keep the text as \"Cancel\" and just add a space between \"Cancel\" and the number.", + "reference": "... so that all action buttons have the same height :-)" + }, + { + "prediction": "I think this should be `DomainParticipantFactory.hpp` and `DomainParticipant.hpp` and `DataReaderQos.hpp` and `DataReader.hpp` and `DataWriter.hpp`", + "reference": "Use correct, alpha sorted, include order. Correct order means: 1. Header corresponding to this source (i.e. `\"LatencyTestPublisher.hpp\"`) 2. C system headers 3. C++ system headers 4. Alpha-sorted external libraries headers 5. Alpha-sorted public headers from this project 6. Alpha-sorted private headers" + }, + { + "prediction": "I think this should be `RequestFactory` and not `OutboundOption`", + "reference": "I hate this name, open to suggestions." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the `StoreTargetMetadata` method.", + "reference": "Does this log line work? We need Warningf or just warning without the format string." + }, + { + "prediction": "Do we need to pass in the processors here? Seems like it should be possible to do this in the `Accumulator` constructor.", + "reference": "The pull controller would need similar updates." + }, + { + "prediction": "I'm not sure if we want to keep the copyright year 2015-2017 or 2015-2018", + "reference": "ignore this.. just didn't want to litter with a commit update to satisfy license plugin" + }, + { + "prediction": "Line is too long. [813/80]", + "reference": "Is this definition needed since it doesn't look like it's being used anywhere?" + }, + { + "prediction": "I think this should be `unless fields.has_key?(self.discriminator_key)` instead of `unless fields.has_key?(self.discriminator_key) || descendants.length == 0`", + "reference": "Can this condition be reworded using `if` please?" + }, + { + "prediction": "I think it would be better to check `inputs != nullptr && !inputs->hasData()` instead of `(inputs != nullptr && !inputs->hasData())`", + "reference": "after ||, no need inputs != nullptr" + }, + { + "prediction": "I think this should be `IntegTestBuildspecPath string` and not `IntegTestBuildspecPath string`", + "reference": "Is it just preference or on purpose that using slice of structs instead of slice of pointers?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it's better to do it in the `newVNode._children` section.", + "reference": "This line always confused me anyway. Good catch!" + }, + { + "prediction": "I think this should be done in `Shutdown` and not in `BlockServer`.", + "reference": "Should we add `ctx` to `BlockServer.Shutdown()` for this purpose? Would be nice, but I don't care too much." + }, + { + "prediction": "Shouldn't this be `period.nanosec * 1000000`?", + "reference": "Duration_t at RTPS level must be serialized using fractions." + }, + { + "prediction": "I think this should be called `NotRunningOutboundError` instead of `NotRunningInboundError`.", + "reference": "\"peer\" has its own meaning within YARPC with its own class of objects. This should probably be \"dispatcher\" too?" + }, + { + "prediction": "I think this should be `experimental-enable-naive-ctu-analysis`", + "reference": "I do not like this line break before `=true`. Maybe starting the list in the next line would help to reduce the indent? This way we could keep this string together." + }, + { + "prediction": "I think it's better to use `flag.StringSliceVarP` instead of `flag.StringVar` and `flag.StringVarP`.", + "reference": "_plugins should be removed too" + }, + { + "prediction": "I think this should be `node.hasAttribute('alt') && (nn === 'img' || nn === 'input' || nn === 'area' || nn === 'amp-img')`", + "reference": "The rule selector will not include `` and `` elements. Why not make this a new, separate rule altogether?" + }, + { + "prediction": "I think this should be `userscripts.NotFoundError` instead of `userscripts.UnsupportedError`", + "reference": "@The-Compiler Is this style okay or would you prefer a common userscript exception base?" + }, + { + "prediction": "I think this should be `value.sub_type || 0x00` instead of `sub_type || 0x00`", + "reference": "we'd need to return a MongooseBuffer here instead of the Binary. lets add the subtype option to the buffer schema type as referenced in #1000 instead." + }, + { + "prediction": "I don't think this change is needed.", + "reference": "Let's remove this change." + }, + { + "prediction": "I think this should be `ROLE_TABLECELL, ROLE_TABLECOLUMNHEADER, ROLE_TABLEROWHEADER` instead of `ROLE_TABLECELL, ROLE_TABLECOLUMNHEADER, ROLE_TABLEROWHEADER,ROLE_TABLEROW`", + "reference": "Could you split this into multiple lines?" + }, + { + "prediction": "I think this should be `__( 'How quickly your page loads, how quickly people can interact with your content, and how stable your content is.', 'google-site-kit' ) `", + "reference": "This technically works, however it may be safer to use both `getCurrentReferenceURL` and `getCurrentEntityURL` and then make this condition `currentReferenceURL === currentEntityURL`. Currently, this code only works based on the internals of `getCurrentReferenceURL`, so by checking both we would decouple that." + }, + { + "prediction": "I don't think this is the best way to format the response. I think it should be something like: `respMsg = fmt.Sprintf(\"Response code: %d, response body: %s\", resp.StatusCode, resp.Body.String())`", + "reference": "It does not recommend capitalization" + }, + { + "prediction": "I think we should use `expect(page).to_not have_content(\"Your credit card was declined\")` instead of `expect(page).to have_content(\"Your credit card was accepted\")`", + "reference": "Minor thing, but can you use 1.9 hash syntax for this?" + }, + { + "prediction": "I think this should be `Util.format_windows_path(os.path.join(lambda_cwd, lambda_cwd_on_host))` instead of `Util.format_windows_path(lambda_cwd)`", + "reference": "I tried to follow the code structure already present." + }, + { + "prediction": "I think this should be a `FileAlreadyExistsException` instead of an `IOException`.", + "reference": "seems reasonable to also want to include the 'to' location?" + }, + { + "prediction": "I don't think this is the right way to do this. I think you should be able to use `os.path.join` to construct the path to the nupic install directory.", + "reference": "Please leave 1 space char between commas here and other places in this PR." + }, + { + "prediction": "I think this should be `0 == pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED)`", + "reference": "hm is this really &&? Not ||? Was it initially correct if any of these things are not set that it needs to recreated?" + }, + { + "prediction": "I think this should be `Collections.EMPTY_LIST` instead of `new String[] {}`.", + "reference": "Please don't use C-style array declarations. IMO our pre-commit ought to be enhanced to not allow this" + }, + { + "prediction": "I think this should be `return (p->data.bo.size == p1->data.bo.size);`", + "reference": "@rhc54 This doesn't look like a comprehensive comparison. For `PMIX_STRING` we seem to actually compare the content of the data while here we only compare meta-information which doesn't ensure that values are the same." + }, + { + "prediction": "I think this should be `boost::system::error_code` instead of `bool`.", + "reference": "I think `bypass_frontier_confirmation` conveys the intention better (default false as well)" + }, + { + "prediction": "I think this file should be renamed to `testutil.go` and moved to `pkg/test`", + "reference": "This looks like it goes beyond the scope of removing `BlockHeight()`, in the future please do this in a separate commit at a minimum -- separate PR is fine too." + }, + { + "prediction": "I think this should be `self._tab.set_muted(muted)`.", + "reference": "You'll also need to adjust `FakeWebTabAudio` in `tests/helpers/stubs.py`." + }, + { + "prediction": "This file should be removed.", + "reference": "@csrwng what should we do here? This one is from origin." + }, + { + "prediction": "Please remove this line.", + "reference": "Follow alphabetical order." + }, + { + "prediction": "I'm not sure this is the right place for this interface. I think it should be in `Diagnostics` or `Tracing` folders.", + "reference": "As far as I can tell, these always get and set the context as an `IReadOnlyDictionary`. Can we use that here instead of `object` and get rid of the `as IReadOnlyDictionary`?" + }, + { + "prediction": "I'm not sure this is the right place for this change. I think it should be in the `else` branch of the `if self._opt.text is not None` condition above.", + "reference": "As you only have `{}` as the format string (without anything else in it), this is the same as doing `self._doc.setHtml(html.escape(self._opt.text))`" + }, + { + "prediction": "I think this should be `azkaban.security.credential.name`", + "reference": "Where would this be configured? In azkaban.properties?" + }, + { + "prediction": "I don't think this is the right place to check for atomic operators. I think it should be in the `update` object itself.", + "reference": "1. Use `const` instead of `var` here. 2. Move the check to after the `if (update == null || typeof update !== 'object')`." + }, + { + "prediction": "I'm not sure if this is the best way to do this. I think it would be better to have a function like `struct st_h2o_multithread_queue_t *st_h2o_multithread_queue_new(void)` that takes a `struct st_h2o_multithread_queue_params_t` and returns a pointer to a `struct st_h2o_multithread_queue_t`. Then you can just call `st_h2o_multithread_queue_new()` from the `st_h2o_multithread_queue_create()` calls below.", + "reference": "Let's assume that on Linux `eventfd` is always available as a wrapper of the eventfd2 system call. It is supported since linux 2.6.27 + glibc 2.9, as well as from the ancient versions of bionic. In other words, it would be fair to argue that the pair would be available on practically all platforms that provide `pipe2`. Therefore switching from using `pipe2` to `eventfd` on linux unconditionally would not cause issues on our users." + }, + { + "prediction": "I think this should be moved to the `DBPReferentialIntegrityController` class.", + "reference": "This field could be `final`." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "would be good to have a test for the case when `shutdown!` raises" + }, + { + "prediction": "I think it would be better to add a `if (t == ComTdbHbaseAccess::INSERT_ || t == ComTdbHbaseAccess::UPSERT_ || t == ComTdbHbaseAccess::REPLACE_ || t == ComTdbHbaseAccess::TRUNCATE_ || t == ComTdbHbaseAccess::RENAME_ || t == ComTdbHbaseAccess::CREATE_ || t == ComTdbHbaseAccess::DROP_ || t == ComTdbHbaseAccess::REINDEX_ || t == ComTdbHbaseAccess::CREATE_INDEX_ || t == ComTdbHbaseAccess::DROP_INDEX_ || t == ComTdbHbaseAccess::CREATE_ALIAS_ || t == ComTdbHbaseAccess::DROP_ALIAS_ || t == ComTdbHbaseAccess::TRUNCATE_ALIAS_ || t == ComTdbHbaseAccess::RENAME_ALIAS_ || t == ComTdbHbaseAccess::CREATE_INDEX_ALIAS_ || t == ComTdbHbaseAccess::DROP_INDEX_ALIAS_ || t == ComTdbHbaseAccess::TRUNCATE_ALIAS_ || t == ComTdbHbaseAccess::RENAME_ALIAS_ || t == ComT", + "reference": "Does upsert pass this check also?" + }, + { + "prediction": "I think this should be `WithField(\"stdout\", \"stderr\", ioStreams.Out.(*bytes.Buffer).String()).Info(\"patch command successful\")`", + "reference": "Apologies reviewers, I did end up pushing another change. I was starting to request SRE-P help to get the apiserver configs from some clusters before and after when I realized I can just log the stdout from the patch command to see if anything was changed or not. Much simpler to verify if my work did or did not make changes to the config during the transition. Also got the spacing issue you mentioned @abhinavdahiya Thanks all." + }, + { + "prediction": "I think this should be `kbfsConfigNameTempDir` or `kbfsConfigNameTemp`", + "reference": "I'm not sure this naming is a good idea; that's the format for macOS xattr metadata files on unsupported filesystems." + }, + { + "prediction": "Line is too long. [83/80]", + "reference": "Metrics/LineLength: Line is too long. [85/80]" + }, + { + "prediction": "nit: remove empty line", + "reference": "Please remove these imports. The project's style is to use `Assert.assertEquals` and not import static methods in general. This also caused a lot of unnecessary changes." + }, + { + "prediction": "(style) code indent should use tabs where possible (style) please, no space before tabs", + "reference": "thanks. Note that returning at this point might leak memory from the allocations above, so the PR will need to take care of that too." + }, + { + "prediction": "I'm not sure this is the best way to do this, but it's the only way I could come up with right now.", + "reference": "If you really want to rename this, you'll also need to adjust the name in `__init__` and in other places it's used (`browser/commands.py`)." + }, + { + "prediction": "I'm not sure this is the right place for this annotation. I think it should be in the `DataFile` class.", + "reference": "As discussed at standup, I gave up on this. Calling `DeleteMapLayerMetadataCommand` felt cleaner anyway because there might be other cleanup that needs to happen. @scolapasta and @matthew-a-dunlap plan to discuss this." + }, + { + "prediction": "I think this should be `fmt.Printf(\"EXP:%+v\\nACT:%+v\\n\", objExp.GetObject(), objAct.GetObject())`", + "reference": "Do we need these changes? If so, can you tidy up the messages? Looks like it might have been your testing/debugging changes" + }, + { + "prediction": "I think this should be `SecretTargetLogDriver` and not `TargetLogDriver`", + "reference": "where is the default being set?" + }, + { + "prediction": "I think this should be `matches[3].start` and `matches[3].length` instead of `matches[2].start` and `matches[2].length`.", + "reference": "these changes should likely be in the next commit instead" + }, + { + "prediction": "I'm not sure this is the right place for these tests. I think they should be in `pkg/addonformatter/test.go` and `pkg/addontransform/test.go`.", + "reference": "Since you have defined this struct, I would suggest to replace all exist literal structs by this." + }, + { + "prediction": "This should be `private static boolean mConfirmMenuDiscard = false;` instead of `private static boolean mConfirmMenuDiscard = true;`", + "reference": "The field name doesn't really capture what this option does. I think `mConfirmDiscardMessage` would be a better choice." + }, + { + "prediction": "Why not using `is_string($media->getBinaryContent())` ?", + "reference": "what if `$media->getBinaryContent() == Symfony\\Component\\HttpFoundation\\File\\File` does `is_string()` return `true`? ping @greg0ire" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do it in the `if (field.nested_flatbuffer)` block above.", + "reference": "maybe rather than `bool` make this field a `StructDef *` ?" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we need to make sure that we don't enqueue blocks to the blocksToDeleteChan more than 10ms after the last time we enqueued blocks to the blocksToDeleteChan. Otherwise, we could end up with blocks in the blocksToDeleteChan that were never actually deleted.", + "reference": "Shall we maybe put this in a `const` like `backgroundTaskTimeout`?" + }, + { + "prediction": "I don't think this is the right fix. The problem is that we're trying to close the response stream before it has been sent to the client. We should be closing the response stream after it has been sent to the client.", + "reference": "CI is complaining about this." + }, + { + "prediction": "I think this method should be called `determineRemovalTime` instead of `determineRemovalTimeTime`", + "reference": "Let's only change a file if it is really necessary. Such a change does not bring much value and makes it harder to find the original commit in which the method was introduced." + }, + { + "prediction": "I think it would be better to use `array_key_exists('class', $attributes)` instead of `array_key_exists('class', $attributes) && $attributes['class'] !== ''`", + "reference": "I would prefer to set up space between classes in format pattern, `%s %s` and then use `trim()` to remove unnecessary whitespaces. This will also solve stripping whitespaces from the beginning and end of a string `$attributes['class']`" + }, + { + "prediction": "I think it would be better to log the error message here, instead of in the `if` statement below.", + "reference": "when Op is illegal should return here?" + }, + { + "prediction": "Why is this removed?", + "reference": "don't we need to remove the project version from installedVersions?" + }, + { + "prediction": "I think this should be `bridge.print_page(*options)`, since it's a method on the bridge object.", + "reference": "the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here." + }, + { + "prediction": "I think this should be `err` and not `err != nil`.", + "reference": "This is intended. Pls revert this." + }, + { + "prediction": "I think we can remove the `T::compareTo` from `ofAll` as well.", + "reference": "Something wrong with cast to `(Comparator<> & Serializable)`, need to be investigated" + }, + { + "prediction": "I'm not sure about this change. I think it's fine, but I'm not sure it's the right thing to do.", + "reference": "I think we need this. Not sure, I'll test." + }, + { + "prediction": "I'm not sure why you removed this line. It seems to be the only place where `disable_*_tables` is used.", + "reference": "I'm going to need to check if google compute requires these steps in this order, or if you can disable iptables after the fact." + }, + { + "prediction": "Why is this needed?", + "reference": "Did go change their tags with the new version?" + }, + { + "prediction": "I think this should be `s.config.Federation.FederatesWith`, not `s.config.Federation.FederatesWith`.", + "reference": "I don't recall what we decided here in terms of which source would get priority. As written, the static configuration will overwrite datastore results." + }, + { + "prediction": "I'm not sure if this is the right place to fix this. I think it should be fixed in `checkAndReplaceLabel`.", + "reference": "I think it should still panic for when there are no outputs; might be nice to special-case that though so the message is more explicit." + }, + { + "prediction": "I think this should be `final`", + "reference": "*NULL_DEREFERENCE:* object `null` is dereferenced by call to `meterSupplier(...)` at line 122." + }, + { + "prediction": "I'm not sure if this is the right place to do this, but it seems like we should be able to do it in the same way as we do for `--op-endpoint` and `--op-endpoint-json`.", + "reference": "switch over to .mode" + }, + { + "prediction": "I'm not sure this is the right place for this test. I think it should go in `test/unit/components/handsontable/handsontable-component.spec.js`", + "reference": "I guess your IDE did some auto-fixing here" + }, + { + "prediction": "I don't think we need to import `PhraseQuery` here.", + "reference": "This is an unused import failing recommit still." + }, + { + "prediction": "Line is too long. [83/80]", + "reference": "I'm concerned that we're conflating multiple things here. There are 2 things that Beaker should really care about: - Network transport - i.e. `ssh` vs `winrm` - Interpreter - i.e. `bash`, `cmd`, `powershell`, etc The problem is that @cowofevil is running Bitvise SSH, and he assumed we should be setting `is_cygwin: false` in node definitions. But that doesn't really accurately convey what we care about, and since Beaker doesn't appear to track network transport apart from interpreter, we end up in a strange state. `is_cygwin: false` appears to end up setting `is_powershell?` to `true`, which IMHO is not accurate or appropriate. Bitvise templates use `ssh` (like Cygwin), but the interpreter used is `cmd`, not `powershell`." + }, + { + "prediction": "`aria-label` should be `role=\"dialog\"` instead of `role=\"dialog\"`.", + "reference": "I think this is ok for now. This ties into the larger issue of the site not having a consistent method for relaying form input errors. Please make sure the focus gets set on the close button when the dialog opens." + }, + { + "prediction": "I think it would be better to add a new option `samplingRatio` instead of `autoColumnSize`.", + "reference": "Should these link be removed?" + }, + { + "prediction": "`add_undo` -> `undo_on_close`?", + "reference": "Please make this a keyword-only argument by adding a `*` argument before `add_undo`." + }, + { + "prediction": "I think this should be `payloadMarshaler := protocol.HandlerPayloadMarshal{...}` instead of `_ = payloadMarshaler`", + "reference": "didn't quite follow what this code block is doing." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in `layoutManager` since it's the one that is responsible for updating the layout.", + "reference": "this doesn't sound pretty... I would rather we have a proper navigation for all modes - AFAIK TV remote navigation is very similar to normal keyboard, but maybe it just uses another key codes - those should be extracted in a single file and defined there depending on context then" + }, + { + "prediction": "I think this should be `checked` instead of `checked` and `value` instead of `value`.", + "reference": "After diffing the children we check whether the value got out of sync, if it did we update it. We also update the `_prevValue` to prepare for the next event hitting our controlled component" + }, + { + "prediction": "I think this should be `// Package node provides the glue-code needed in order to start a Bee node.`", + "reference": "It provides a type called Node which is a fully functional bee client. This package is where the dependencies are injected. It is not just a glue-code, it is concept of node." + }, + { + "prediction": "I think this should be `_get_value_transformer('storage', 'download-directory')`", + "reference": "I think this will change `''` to `'%'` unconditionally, i.e. there'll be no way to set `''` anymore. This should really only be used for values which make no sense anymore." + }, + { + "prediction": "I think this should be `Table#getRowKey()`.", + "reference": "Nit: this table's row key map -> this table's row keys map" + }, + { + "prediction": "I think this should be set to `PJ_LOG_WARNING`", + "reference": "this change should be reverted" + }, + { + "prediction": "I think this should be `appdata_path = os.path.join(os.path.dirname(basedir), \"misc\", \"qutebrowser.appdata.xml\")`", + "reference": "I'm a bit confused about the `os.path.dirname(basedir)` here - is this just to get to the parent directory? Either way, I think I'd prefer just having this in `update_version.py` as it's not needed in qutebrowser itself." + }, + { + "prediction": "I'm not sure why this test is here, but I think it should be removed.", + "reference": "Revert this change and see below why..." + }, + { + "prediction": "I think you can remove `cascade_mask_rcnn_r50_fpn` here.", + "reference": "Should not switch to `lvis_v1_instance` here because that base config uses ClassBalancedDataset to oversample the data." + }, + { + "prediction": "I think we should use `LOG.info(String.format(\"Adding %s %d times\", caps, info.getMaximumSimultaneousSessions()));` instead of `LOG.finest(String.format(\"Adding %s %d times\", caps, info.getMaximumSimultaneousSessions()));`", + "reference": "This is an informational message that allows someone to read the console output and understand how the grid node is configured. Please leave." + }, + { + "prediction": "I'm not sure this is the right place for this method. I think it should be in `pkg/alert/alert.go`", + "reference": "This doesn't make sense to me. What does RaiseSingleton mean? To me it sounds like a single object is being.. raised? Not sure." + }, + { + "prediction": "I think this should be `AllJobExecutorTests.java` instead of `AllJobExecutorTestsTests.java`", + "reference": "What's the benefit of having jobExecutorTests as a member variable? What do you think about making the method static? Afterall, it is a stateless method." + }, + { + "prediction": "I think this should be `dump` and not `check`. I don't think we should have a separate command for `check`.", + "reference": "This looks like it's only downloading things, not really checking their true validity. Especially for the MD object. Should we call `BareRootMetadata.IsValidAndSigned()` in `mdGet`?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do it in `setup`.", + "reference": "Nikoli, I believe that this addresses your concern. One question for you or Jae-Seung is if any allocation from the clone is properly cleaned up when the vector is destroyed. I believe that it should." + }, + { + "prediction": "I think this should be `KindECSApp`", + "reference": "should be `ECSApp`" + }, + { + "prediction": "I'm not sure this is the best way to do this, but it's the only way I could think of.", + "reference": "flake8 is going to fail on this having 2 lines" + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in `podutil` since it's only used by `podman pod delete` and `podman pod rm`.", + "reference": "should we make a dir named controllers/scheduler/podchaos" + }, + { + "prediction": "nit: I think we should rename this to `KeyNodeHostname` to be consistent with the `KeyNode` variable.", + "reference": "there seems to be one KeyNode in kubernetes.go of PV.. would it make sense to use it?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `cmd/` directory.", + "reference": "Im gonna be a little annoying here but did you configure your linter correctly? This empty line should not be here. Maybe go to settings and check if `goimports` is enabled?" + }, + { + "prediction": "I think this should be `MODPRIVATECHATOUT` instead of `MODPRIVATECHAT`", + "reference": "Don't think this belongs in this pr" + }, + { + "prediction": "I'm not sure this is the best name for this. It's a copy of the map of outbounds for this RPC object. The outbounds are already wrapped with middleware.", + "reference": "We can assert on the existence of Outbounds through ClientConfig calls right? Since this is only for tests, do we need this function?" + }, + { + "prediction": "I'm not sure this is the right place for declaring the result. I think it should be in the `IMvxViewModel` interface since that's where the `TParameter` type is defined.", + "reference": "@martijn00 so this PR introduces a new ViewModel lifecyle method? It isn't in the PR description/any new docs" + }, + { + "prediction": "nit: `NOTE the image size is [B, C, H, W]`", + "reference": "Are these modification duplicate? Or should we move it into base detector." + }, + { + "prediction": "I think this should be `private static byte[] dagSeed(long block)`", + "reference": "Since this is private and single use it should be un-wrapped inside of the two-arg dagSeed method." + }, + { + "prediction": "Shouldn't this be `array_merge_recursive_overrule`?", + "reference": "why the order change? Also for the next chunk. (I understand the result will be the same though)" + }, + { + "prediction": "I think this should be `Returns` instead of `Returned`", + "reference": "I wonder if this should just be a single `string`? We don't have any cases where we return different types and it would make the parser simpler to just read a single identifier." + }, + { + "prediction": "I think this should be `getInputFile(task.file().path())`", + "reference": "I don't think this needs to change. Can you go back to the previous implementation?" + }, + { + "prediction": "I think this should be renamed to `Provisioner` instead of `Molecule`", + "reference": "Bump it 2 lines higher, 'c' > 'u'." + }, + { + "prediction": "Please remove this empty line.", + "reference": "Please do not add author here" + }, + { + "prediction": "I think this file should be renamed to `models.go`", + "reference": "Similarly, we should be able to persist action uniformly" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "I think i'd prefer this override to be in the test helper instead, if that's possible?" + }, + { + "prediction": "I'm not sure this is the right fix. I think we need to ensure the directory is created before we try to move the file.", + "reference": "This would be better with context added via wrapping or fmt.errorf()" + }, + { + "prediction": "nit: I think this should be `// Package assert provides convenience functions that help a method or constructor check whether it was invoked correctly (whether its preconditions have been met).`", + "reference": "What's the purpose of this file?" + }, + { + "prediction": "I'm not sure this is the right place to set the passcode length. I think it should be done in the `setPasscode` method, since that's where the user can change the passcode.", + "reference": "@bhariharan Why was passcode length requirement allowed to be lowered?" + }, + { + "prediction": "nit: remove empty line", + "reference": "This file needs a license header, too. Sorry I didn't catch that earlier." + }, + { + "prediction": "Why do we need to pass a string for the genesis text here?", + "reference": "probably don't need `[:]` why not reference into `github.com/algorand/go-algorand/daemon/algod/api/server/lib` here and skip bouncing off daemon/algod/server.go ?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the `compute_reference` function.", + "reference": "Why reference is converted to table?" + }, + { + "prediction": "I think we can remove the `else` case here and just return the `&datastore.ListRegistrationEntriesResponse{Entries: []*common.RegistrationEntry{}, Pagination: req.Pagination}`", + "reference": "should we implement pagination in the fake datastore so the server startup code that paginates entries for trust domain validation can be tested?" + }, + { + "prediction": "I think this should be `if f.Vectorized != nil && f.Vectorized.Type() != nil {`", + "reference": "What mechanism will be exposed so the caller knows they're using the vectorized version?" + }, + { + "prediction": "Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Can we remove respond_to block its not required here" + }, + { + "prediction": "I'm not sure this is the right place for this function. It's only used in `graph_csv_data_source.cpp` and `load_graph.cpp`. I think it would be better to move it to `graph_csv_data_source.cpp` and `load_graph.cpp`.", + "reference": "Do not do that even in example, we demonstrate bad practice" + }, + { + "prediction": "Line is too long. [83/80]", + "reference": "Hm, taking a second look over this, this is why we have the object inheritance structure that we do. This could be divided up by having a custom determine_if_x86_64 in the pswindows/exec hosts and then a default method in hosts.rb. That way all the custom ps windows work is in a single location." + }, + { + "prediction": "I'm not sure this is the right place for this test. I think it would be better to move it to the `KestrelServerTests` assembly.", + "reference": "We have to `.Complete` now because of empty/null string test cases." + }, + { + "prediction": "Line is too long. [83/80]", + "reference": "Is there still a way to specify no recursion?" + }, + { + "prediction": "I think this should be a `string`.", + "reference": "How is this name being URI safe and being used programmatically related?" + }, + { + "prediction": "I'm not sure if this is the best way to handle the case where the `Dashboard` plugin is not loaded.", + "reference": "I think we have to keep this as a fallback for now, else it's a small breaking change :(" + }, + { + "prediction": "I'm not sure if this is a good idea. I think it's fine, but just wanted to make sure we're on the same page.", + "reference": "nit: shouldn't be part of this PR." + }, + { + "prediction": "Why did this need to be changed?", + "reference": "this change looks wrong to me. I think the test is trying to signal that something went wrong by throwing the `Error` here, otherwise the `catch` below will swallow it." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to move this logic into the `LayoutBuilder` class itself.", + "reference": "I'm doubting if this should be `if (_layout.IsThreadAgnostic)`, as ThreadAgnostic stuff could be calculated on every thread. (and thus could be lazy). non-ThreadAgnostic should be calculated on the main thread." + }, + { + "prediction": "This should be `org.slf4j.LoggerFactory.getLogger(LeftListWidgetChooser.class.getName() + \".LOGGER\")`", + "reference": "Please use only `Logger` instead of `org.slf4j.Logger`" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `block_processor` class, since that's where the block processing logic is.", + "reference": "Should this be \"no limiter drop\", since this isn't an absolutely essential activity for the stability of the network?" + }, + { + "prediction": "I think this should be `console.log('Account alias ' + process.argv[2] + ' deleted.')` instead of `console.log(\"Account alias \" + process.argv[2] + ' deleted.\");`", + "reference": "I updated many of the success messages, because most of these operations don't return data if they succeed. This meant many of the operations would print: `Success null` if the script ran successfully." + }, + { + "prediction": "I think this should be `except FileNotFoundError as fnfe: return False`", + "reference": "Could you simply add it to the previous clause ?" + }, + { + "prediction": "`localeCompare` is not supported in IE.", + "reference": "@joshyrobot, I think you can just use localeCompare with only the first argument and leave the other arguments out (here and all the other lines changed). It seems to do the right thing, and then we don't have to worry about these extra options." + }, + { + "prediction": "I think it would be better to check if `slaOptions != null &&slaOptions.size() > 0` instead of `slaOptions.size() > 0`", + "reference": "@chengren311 : where does this logic move to?" + }, + { + "prediction": "I think this should be `s.scope.AllowAdditionalRoles() || len(s.scope.ManagedMachinePool.Spec.RoleAdditionalPolicies) > 0`", + "reference": "Can we have a `nil` exception check at `s.scope.ManagedMachinePool`" + }, + { + "prediction": "I think we can remove this now, since it's not used anymore.", + "reference": "Rather than deleting this, should you just reformat it so it's the `*` settings, so if nothing is configured in facets.ini, the existing default behavior continues to work?" + }, + { + "prediction": "This should be `str_replace(\"_\", \" \", ucfirst($property));`", + "reference": "wrap, single line" + }, + { + "prediction": "I think this should be `getGenericAwareReturnType()` instead of `getReturnType()`.", + "reference": "always use brackets for if statements" + }, + { + "prediction": "Nit: I think it's better to have this as a static field rather than a class field.", + "reference": "`NUnitIntegration` doesn't need to cache this anymore." + }, + { + "prediction": "I'm not sure this is the right fix. I think we should be looking for `gz` in the `ext` field, not the `element_at` field.", + "reference": "Why did you change it to `>=` here?" + }, + { + "prediction": "I think this should be `else if (tableName.startsWith(\"hive.\")) {`", + "reference": "Looks like this needs to be updated. There is no need to remove `hadoop.` if Hadoop tables don't use this code path." + }, + { + "prediction": "I think this should be `digest/sha1` or `digest/sha256` instead of `sha1` or `sha256`", + "reference": "This require isn't need anymore, right?" + }, + { + "prediction": "I think this is the only place where we're using the new crypto package.", + "reference": "a bit weird to see payments crypto package inside connection manager. There probably will be services not having any relation with payments that will use connection manager. Thats why probably ping-ping by itself can be useful without any relation to payments.." + }, + { + "prediction": "I think this should be `BibTeX`, not `Bibliographic`.", + "reference": "I like the overall idea here, but I wonder if it would be more clear to define the property in the trait, and then set it in the constructors of the classes using the trait. Alternatively, at a bare minimum, it may be a good idea to add `?? 'Bibliographic'` here, to account for the possibility of the trait being used in a class that does not define the property at all." + }, + { + "prediction": "I think this should be 10000, not 100", + "reference": "I would prefer to not have a magic number, but construct this value out of other constants we already have." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be under `pyramid_multiauth`, since that's where it's used.", + "reference": "The limitation is if somebody configure another policy with the same name, but it is an edge case we can ignore I guess." + }, + { + "prediction": "nit: I think we can remove the `gocloud.dev/secrets/` prefix here as well.", + "reference": "? The package is named `hashivault`." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I could get it to work.", + "reference": "I don't think this should enable xwayland, because it's convenient to toggle xwayland just by setting `xwayland` to `false`" + }, + { + "prediction": "nit: remove empty line", + "reference": "Remove this line by accident?" + }, + { + "prediction": "I think this should be renamed to `SourceSetContainer`", + "reference": "Calling `.stream()` on a `DomainObjectCollection` is pretty much always a bug, as it doesn't include objects added later (and encourages people to use afterEvaluate). I wonder if we should make this an error prone check?" + }, + { + "prediction": "I think this should be `err != nil && !sigFound`", + "reference": "Thanks for paying attention to other places this might happen. This one is particularly important; I probably never should have gotten in the habit of CheckErr(), since it does a log.Panic() explicitly, which looks like something else until you look closely. It's supposed to be used places where \"can't happen\" but Things Can Happen." + }, + { + "prediction": "I think this should be `dscp & 0x03` instead of `dscp<<2`", + "reference": "What is the different between nw_tos and ip_dscp? Only high 6 bits vs low 6 bits and supported version?" + }, + { + "prediction": "I think this should be `if (cxSmiles)` instead of `if (!cxSmiles)`", + "reference": "I'm assuming that asSmarts & cxSmiles == asSmarts" + }, + { + "prediction": "I don't understand why this is necessary. `super().__init__` is called by `__init__` in `__call__`, so you should be able to call `super().__init__` directly in `__init__`.", + "reference": "Seems like an oversight but I don't think the super would do anything else in this case unless I'm mistaken." + }, + { + "prediction": "I think we can remove the `SampleServer` and `SampleClient` classes and just use `server` and `client` here.", + "reference": "Curious, do we consider this as pedantic for example code?" + }, + { + "prediction": "Why is this change needed?", + "reference": "Should we convert the entity name to snake case using `Doctrine\\Common\\Inflector\\Inflector::tableize` or similar ? Should a `snaked_name` or whatever be part of the entity metadata in order to use it for form names, ids, & other html attributes ?" + }, + { + "prediction": "I think this should be `GetPublicOutboundIP`", + "reference": "Should be `client.outboundIp`" + }, + { + "prediction": "I think this should be `using System.IO; using System.Runtime.InteropServices;` instead of `using System.IO; using System.Runtime.InteropServices; using System.Threading;`", + "reference": "Must these `using` statements not go inside the `namespace` block?" + }, + { + "prediction": "I'm not sure this is the right mutex level. I think it should be `fboHeadWriter` and `fboBlockWriter` and `fboHeadReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `fboBlockReader` and `f", + "reference": "Why? I thought the previous way was idiomatic. (Same with the `MetadataVer` stuff above.)" + }, + { + "prediction": "I don't think this is the right way to do this. We should be using the `require` polyfill here.", + "reference": "shouldn't we `reject` here instead?" + }, + { + "prediction": "I think it would be better to use `action.Core.GasPrice.String()` here instead of `util.StringToIOTX`", + "reference": "check err or use gasPriceUnitIOTX, _ := if we are sure action.Core.GasPrice is correct" + }, + { + "prediction": "I think this should be `watcher` instead of `watcher`", + "reference": "Just curious, was wait not used at all before?" + }, + { + "prediction": "I think we can remove this line.", + "reference": "nit: can we remove this?" + }, + { + "prediction": "I think this should be `synchronized` as well.", + "reference": "is it not a problem when one synchronized function is called by other?" + }, + { + "prediction": "I'm not sure if this is a good idea, but I can't think of anything better right now.", + "reference": "We (even as admins) shouldn't override the User Preference settings like `email_master`, `email_posts`, `email_kudos`, `email_new_followers`. These all would be set by the user of their choice. Please do remove these attributes from editing//updating. Thanks!" + }, + { + "prediction": "This :attribute j\u00e1 est\u00e1 ligado. -> Este :attribute j\u00e1 estiver\u00e1 ligado.", + "reference": "\"Este :attribute j est anexado.\" sounds better." + }, + { + "prediction": "I think this should be `if __name__ == '__main__':` instead of `if __name__ == \"__main__\":`", + "reference": "This line should be repeated for every module that needs testing. One cannot rely on nosetest to automatically discover all the modules. On the bright side, there is no need to change any of the other files." + }, + { + "prediction": "Why is this removed?", + "reference": "This error was unused" + }, + { + "prediction": "I think we should rename this to `CloseShardRequestWithTasks` to make it clear that it's used to notify persistence that we're unloading a shard along with its tasks.", + "reference": "Personally I wish we didn't have a proto for every single little thing we do. RequestShardAction with an enum for the action type would be a lot cleaner imo, but I'm pretty sure that ship has sailed :) Just kvetching." + }, + { + "prediction": "Do we need to do anything to the `incomplete_trail.html.erb` file to make this conditional? It looks like we don't need to do anything, but I wanted to double check.", + "reference": "Does this make more sense as `trails/_trail` now?" + }, + { + "prediction": "I think this should be `OutpostARN` instead of `OutpostARNs`", + "reference": "synced offline. let's move this to `agent_unix.go` to make the IMDS call, since this is not supported in Windows." + }, + { + "prediction": "I think this should be `Python::PythonSetup` instead of `Python::Install`.", + "reference": "Too much indentation here. Should match the lines above, which have four spaces." + }, + { + "prediction": "I think this test should be removed as it is testing the same as the one in `test_osrm.cpp`", + "reference": "Same here we still need this test to make sure the fallback works." + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in `MvvmCross.tvOS.Views.Presenters.Attributes`", + "reference": "I'm wondering if we can actually base this on a `IMvxPresentationAttribute` instead of the base one." + }, + { + "prediction": "I'm not sure this is the right fix. The problem is that `vnode._component` is not guaranteed to be the same as `vnode._vnode._component`. I think we need to do something like `vnode._component = vnode._vnode._component;` in `unmount`.", + "reference": "could we switch to `undefined` here?" + }, + { + "prediction": "I don't think we need to do this cleanup here. The cleanup should be done in the `SmartStore`'s `dispose` method.", + "reference": "The cleanup call" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it's the only way I could think of at the time.", + "reference": "I think \"View artist\" is a bit more standard and expected. Or even \"Go to artist\" to take the Spotify terminology as-is." + }, + { + "prediction": "`unless defined?(Puppet::Pops::Types::PSensitiveType::Sensitive)` -> `unless defined?(Puppet::Pops::Types::PSensitiveType) && defined?(Puppet::Pops::Types::PSensitiveType::Sensitive)`", + "reference": "It might make sense to refactor this later so that we use a Bolt-native type to hide sensitive values." + }, + { + "prediction": "I think it would be better to move this to the top of the file, so that the rest of the tests don't have to jump through hoops to get to it.", + "reference": "We were trying to move away from this to force people to always run tests under py.test." + }, + { + "prediction": "I think this should be done in a separate PR, as it's not related to the other changes.", + "reference": "1 - create browser specific options class: - chromeoptions - firefoxoptions - argsoptions" + }, + { + "prediction": "I don't think this is the right fix. I think we need to fix the `Content-Type` header instead.", + "reference": "should be a case insensitive match though no? DOCTYPE and doctype are both widely used" + }, + { + "prediction": "I'm not sure this is the right place for this action. I think it should go in `WidgetsController` since it's related to widget creation.", + "reference": "We must have a `fail ParamNotFound` here for cases where `@account.nil?`." + }, + { + "prediction": "Why is this needed? I don't see it being used anywhere in the PR.", + "reference": "How come this change was needed?" + }, + { + "prediction": "I think these should be `ADC0 = 3`, `ADC1 = 4`, `ADC2 = 28`, `ADC3 = 29`, `ADC4 = 30`, and `ADC5 = 31`.", + "reference": "Why are there only 6 pins here, while below it appears to have 8 ADC inputs? Are pin 2 and 5 used for something else on this board?" + }, + { + "prediction": "I'm not sure this is the right fix. I think we need to add the `secpRoot` field to `messageReceipts` as well.", + "reference": "I think we need an issue to track that chain sync omits BLS messages, and then to fix and test it!" + }, + { + "prediction": "I think this should be `http://127.0.0.1:5000` and not `http://localhost:5000`", + "reference": "what is this default about? I am not using ngrok atm so would prefer an env var." + }, + { + "prediction": "I don't think this is the right place for this. I think it should be in `config/auth.php` or `config/database.php`", + "reference": "@Samuell1 Might be better to say \"Automatically check for plugin updates on login\"." + }, + { + "prediction": "I think this should be `using System.Diagnostics.Tracing;`", + "reference": "Thanks for the additional Process helper! Can we also cache the first `Process.GetCurrentProcess()` result in a static field so we don't have to repeatedly call it? It means we would also need to dispose it when the static `_runtimeMetricsWriter` instance is disposed" + }, + { + "prediction": "nit: I think this test can be moved to `TelemetrySessionTest.go` since it is testing the same functionality.", + "reference": "just wondering what is the result of breaking the logic we test here? it seems that in that case we will just not return immediately, but i'm not sure whether the test will fail?" + }, + { + "prediction": "I think this should be `pctx := newTestProcessContext(filepath.Join(dir, \"src\"), nil)`", + "reference": "We should fail the test if this returns `err != nil`." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in `controllerutils.SetClusterDeploymentConditionWithChangeCheck`, but I'm not sure why it's called `provisionFailedTerminal` at all.", + "reference": "What is the drawback of not having this flag as a gating condition to report the metric?" + }, + { + "prediction": "I think this should be `fmt.Sprintf(\"Graceful stop, pid=%d\", pid)`", + "reference": "`getProcessName()` will be less ambiguous, since Caddy has \"apps\" that it runs internally." + }, + { + "prediction": "I think this should be `dms` instead of `dps`.", + "reference": "Is there any way to not hardcode this given we know the size in bytes? The public API has the flexibility of being a Span. Should we maybe not do anything printing DML? The runtime allocates the buffer, but it's a \"scratch memory\" area, The delegate gets it passed in and they decide how to use it. Also, how is DML used if the feature is for macOS support?" + }, + { + "prediction": "I think this should be `return r.get_filter();` instead of `return r.filter_ref().get_value();`", + "reference": "How about just override the `buildFilter`? Passing another function here is a little weird." + }, + { + "prediction": "I think this should be `Is this a TestRPM build with all RPMs hydrated?`.", + "reference": "This should just be a `.Bool()` flag I think, we don't encode anything beyond y/n here. See `$(RUN_CHECK)` and `$(STOP_ON_PKG_FAIL)` for examples of how to pass those in." + }, + { + "prediction": "I'm not sure this is the right place for this. It's not a type, it's a function.", + "reference": "Is this needed?" + }, + { + "prediction": "This should be `admin.lookup.titles.deleteLookupValue`, not `admin.lookup.titles.deleteLookupValue`.", + "reference": "This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted." + }, + { + "prediction": "nit: remove empty line", + "reference": "how about moving it under L26" + }, + { + "prediction": "I think this should be `axe._memoizedFns = []` instead of `axe._memoizedFns = [];`", + "reference": "I think this needs to be tested" + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in the `Trail` model, but I don't know if it's the right place for it.", + "reference": "Style/MutableConstant: Freeze mutable objects assigned to constants." + }, + { + "prediction": "I don't think we need to create a new `Deflater` instance for each compression level. We can just use the one we already have.", + "reference": "Just a thought, really. If it's a bug that can be probed for (and it can be - see Adrian's repro) then it could as well be a static initialization of a supplier of Deflater instances; if we probe for a buggy JVM, we return the wrapper. If we don't we return the Deflater. This way on non-affected JVMs nothing happens and if we do use the wrapper, we know the JVM is broken." + }, + { + "prediction": "I think this should be private.", + "reference": "Looks like this should be publicly accessible for tests in any modules?" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it's the only way I could get to load the `.env.local` file.", + "reference": "Allow putenv is necessary to be able to get environment variables with `getenv`?" + }, + { + "prediction": "Indent the first statement one space more than the start of the previous line.", + "reference": "use function to check it. - don't do everything in main" + }, + { + "prediction": "I think this should be `build_rule_book(self, global_configs)`.", + "reference": "Sorry I'm confused. Why not kwarg this like the others?" + }, + { + "prediction": " mrm|vex|reqp,x,END_LIST},\n+ {OP_vgatherdpd,0x66389258,\"vgatherdpd\",Vvd,Hx,MVd,Hx,xx, mrm|vex|reqp,x,END_LIST},\n {OP_vgatherdd,0x66389298,\"vgatherdd\",Vxd,Hx,MVd,Hx,xx, mrm|vex|reqp,x,END_LIST},\n {OP_vgatherdq,0x66389318,\"vgatherdq\",Vxd,Hx,MVq,Hx,xx, mrm|vex|reqp,x,END_LIST},\n {OP_vgatherqq,0x66389358,\"vgatherqq\",Vxd,Hx,MVq,Hx,xx, mrm|vex|reqp,x,END_LIST},\n```\nReview comment?", + "reference": "First, any changes here should be synchronized with instr_compute_VSIB_index(). Second, the original looks correct to me: the first letter of the opcode name suffix is the index size, while the second is the memory size. So \"vpgatherdq\" is a d-sized index and q-sized memory. The operand size we store for memory accesses is always the memory size, not the address size, and for VSIB we store a single memory element size. It looks like we have no inside-opnd_t storage of the index size: that's done by dispatch on opcode it seems. I have a bunch of notes of discussions on how to handle VSIB: we decided to bail on encoding too much inside the opnd_t I guess." + }, + { + "prediction": "I think it would be better to pass the logs output as a parameter to the `run` method. This way, you don't need to pass the logs output to the `run` method every time you call the `ExternalProgramTask` and you also don't need to pass the logs output to the `build_tracking_url` method every time you call the `ExternalProgramTask`. Instead, you can just call the `build_tracking_url` method and pass the logs output as a parameter to the `build_tracking_url` method. This way, you don't need to pass the logs output to the `build_tracking_url` method every time you call the `ExternalProgramTask` and you also don't need to pass the logs output to the `build_tracking_url` method every time you call the `ExternalProgramTask`. Instead, you can just call the `build_tracking_url` method and pass the logs output as a parameter to the `build_tracking_url` method. This way, you don't need to pass the logs output to the `build_tracking_url` method every time you call the `ExternalProgramTask` and you also don't need to pass the logs output to the `build_tracking_url` method every time you call the `ExternalProgramTask`", + "reference": "Sorry for going back and forth. Adding docstring here would be very helpful for others to understand the need of this method." + }, + { + "prediction": "I think this should be `return canSeeInvisibility() && creature->isInvisible();`", + "reference": "You introduced a bug here." + }, + { + "prediction": "I think it would be good to have a unit test for this as well.", + "reference": "Should we log a warning/error if only one is specified and not the other?" + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think it should be in `piped_service_test.go` since this is testing the `piped_service` client.", + "reference": "`ctx` is unused in GetLatestEvent" + }, + { + "prediction": "I think this should be `config.node.peering_port = network_params.network.default_peering_port;`", + "reference": "This looks good to me. Personally, I would have the following for maximum flexibility: * convert peering_port from uint64_t to int. * Set the default value to \"-1\" to specify the value is not set * if the value is -1 then do `config.node.peering_port = network_params.network.default_node_port` That would allow for 0 to mean, select the port number yourself and be more consistent. But I am happy with the change as is, as well." + }, + { + "prediction": "please add license header", + "reference": "The blank line between the summary and detailed description is better to be kept." + }, + { + "prediction": "I think this should be done after `a.setMetadataEndpointsKey()` and before `a.writeShapeNames()` and `a.resolveReferences()`.", + "reference": "Curiously, are these indents intended or should they be aligned?" + }, + { + "prediction": "I think this should be `getSpeechTextForProperties(reason=reason,role=role,keyboardShortcut=keyboardShortcut) if config.conf[\"presentation\"][\"reportKeyboardShortcuts\"] else \"\"`", + "reference": "What if we changed this to this? roleText=attrs.get('roleText', lambda:getSpeechTextForProperties(reason=reason,role=role)) That will prevent the function from ever needing called in the roletext case, and removes that if." + }, + { + "prediction": "I'm not sure if this is the right place to fix the issue. I think it's better to fix it in `libthread.c` instead of `libthread_tls.c`.", + "reference": "This will still result in a safe_read_tls_magic on AMD in tls_thread_preinit()." + }, + { + "prediction": "Why is this removed?", + "reference": "Can you remove this change?" + }, + { + "prediction": "I think this should be `field.Invalid(specPath.Child(\"isCA\"), isCA, \"ACME does not support CA certificates\")`", + "reference": "Oh, was that a bug in the validation?" + }, + { + "prediction": "I think this should be `feedUrl = feedUrl.replaceFirst(\"((www.)?(subscribeonandroid\\\\.com)/)\", \"subscribeonandroid.com\")`", + "reference": "Please use the Google java code style. Basically, add more space characters like in the statements below. Next to method arguments and curly braces. This is currently not checked on CI because it is too inconsistent in the code base but I would prefer new code to be consistent." + }, + { + "prediction": "I'm not sure this is the right way to do this. I think it would be better to have a single `SourcePropertyExpression` object that can be shared across all the tests.", + "reference": "Actually, I don't think we need to create object on heap." + }, + { + "prediction": "Why did you change this? It looks like it should be the other way around.", + "reference": "this is a file we copy from gRPC, sp ideally it be fixed upstream as well.." + }, + { + "prediction": "I think we can remove this import as it is no longer used.", + "reference": "changes like this, just strangle guava usages to be replaced by DelayLimiter into one place" + }, + { + "prediction": "I'm not sure this is the right place for this component. I think it should live in `components` folder.", + "reference": "PropTypes need to be updated accordingly here. Note that the type also needs updating, not just the case. That is, these should both expect a `PropTypes.elementType` now instead of an `element`." + }, + { + "prediction": "I'm not sure this is the right fix. The problem is that `ctest_resource_group_id_name` is not the same as `ctest_resource_id_name`. The former is the name of the group, while the latter is the name of the individual resource. I think the right fix is to change `ctest_resource_id_name` to be the same as `ctest_resource_group_id_name`, and then use `ctest_resource_group_id_name` in the call to `get_ctest_gpu()`.", + "reference": "maybe extra paren around `strncmp(...) != 0`" + }, + { + "prediction": "I think this should be `resetOpenedWindowsCount` instead of `resetOpenedWindowsCountForPrivateWindows`", + "reference": "We should call `Windows.onResume `: - When the app is launched for the first time - When the app is resumed after being paused (home button and resume or device goes to sleep) - After a permission prompt is displayed" + }, + { + "prediction": "I think it would be better to have a `BftForksSchedule`.", + "reference": "Rename to ForksSchedule? Maybe in separate PR." + }, + { + "prediction": "I think this should be `import kinto.core.storage`", + "reference": "Why a blank line here?" + }, + { + "prediction": "I think this should be `active?` instead of ` deactivated_on.nil?`", + "reference": "I have a sense that this will actually eventually change to check the actual date so that subscriptions can be deactivated in the future. But I mention that here just to keep you in the loop. We should not make that change now, because it's not needed functionality." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `Environment` class.", + "reference": "What is the reasoning for using the negation of `isOption()` instead of simply using `isPositional()` to identify a positional param?" + }, + { + "prediction": "This should be `0x01` or `0x00` depending on the vocation.", + "reference": "Why would you add those if client version min is set to 1100?" + }, + { + "prediction": "I don't think we need to change this file.", + "reference": "You can delete this, it will now need to live in `gointerfaces` package" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Okay, I still don't understand why you have to add `html_safe` here, and it still seems like a very bad idea. It will allow html tags in the title, and keep Rails from escaping literal greater-than or less-than chars not intended as HTML tags. It ought to work to just let Rails do HTML-escaing as normal, without any manual `html_safe` or `strip_tags` or whatever. I am not clear on what problem you are trying to solve, why the straightfoward approach does not work." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `MessageAdapter` class, since that's where we set the display mode.", + "reference": "What is is subject when it's not the email subject. Why are we having to do this crap? What's calling this with an empty string?" + }, + { + "prediction": "I'm not sure this is the right default. I think we want to default to AlwaysSample() if we don't specify a sampling probability.", + "reference": "Could you also remove the `defaultSamplingProbability` constant from `sampling.go`? It seems to became unused with this change." + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think it should be done in `apps/v1beta1/constants.go` or `apps/v1/constants.go`", + "reference": "can you delete the `generateDeploymentStrategicPatch` function as well?" + }, + { + "prediction": "I think this should be `LOG.info(String.format(\"Connecting to %s and %s\", publishConnection, subscribeConnection));`", + "reference": "I'd keep this at `info` level..." + }, + { + "prediction": "I think this should be `if (gn->limit() >= 0 && limitRows >= gn->limit()) {`", + "reference": "Don't use DCHECK to debug your code if it's the regular branch you need to handle." + }, + { + "prediction": "I'm not sure this is the right place to move this method. I think it would be better to move it to the `AntlrNode` interface itself.", + "reference": "You should return null here instead. Null is an acceptable default value for the image attribute." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in `componentDidMount` or `componentDidUpdate` since those are the only two places where `component.__hooks` is initialized.", + "reference": "react bails as well?" + }, + { + "prediction": "Why is this constant here? I don't see it used anywhere.", + "reference": "Can you please tell me why you did this?" + }, + { + "prediction": "`this.opts.videoConstraints` should be `this.getOptions().videoConstraints`", + "reference": "Reading this again it should prob prefer the `videoConstraints.facingMode` value over `facingMode` if the former was already set" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "There's a good bit of class-level stuff that's repeated in our various product types. Think it's worth extracting a...dare I say it...module?" + }, + { + "prediction": "I think this should be `if config.Options.WasmAbi != \"\" && config.Target.WasmAbi == \"js\"`", + "reference": "Please do not modify the `config.Target` field, it should contain exactly what is extracted from the JSON files. Instead, you can either: * Add a getter to the `config` variable (`*compileopts.Config`), so you can simply call `config.WasmAbi()` to get the value. * Use a local variable instead. The getter would be slightly cleaner, as it matches the pattern of other configurations (`CGO_ENABLED`, `GC`, `NeedsStackObjects`, etc)." + }, + { + "prediction": "I'm not sure if this is the right place to start the test. I think we should start the test in the middle of the test router, so that we can make sure that the router is running before we try to start the test server.", + "reference": "The nil check is not necessary for these. Append checks both sides for nil." + }, + { + "prediction": "I'm not sure this is the right way to do it. I'm not sure we should be setting the attributes in the `trace` package. I'm not sure we should be setting the attributes in the `trace` package. I'm not sure we should be setting the attributes in the `trace` package. I'm not sure we should be setting the attributes in the `trace` package. I'm not sure we should be setting the attributes in the `trace` package. I'm not sure we should be setting the attributes in the `trace` package. I'm not sure we should be setting the attributes in the `trace` package. I'm not sure we should be setting the attributes in the `trace` package. I'm not sure we should be setting the attributes in the `trace` package. I'm not sure we should be setting the attributes in the `trace` package. I'm not sure we should be setting the attributes in the `trace` package. I'm not sure we should be setting the attributes in the `trace` package. I'm not sure we should be setting the attributes in the `trace` package. I'm not sure we should be setting the attributes in the `trace` package. I'm not sure we", + "reference": "Shouldn't we instead have the SDK apply these, internally? I.e., I would expect to see the dctx entries included in the span as first-class distributed correlations, not as span attributes." + }, + { + "prediction": "I think this should be `nil, errors.New(\"not implemented\")` instead of `nil, errors.New(\"not implemented yet\")`", + "reference": "nit: rename this in proto and update impl to `Search` to avoid stutter" + }, + { + "prediction": "I think it would be better to use `orderBy('s.id', 'ASC')` instead of `orderBy('s.id');`", + "reference": "is it necessary to order by id as a second ordering? this will take place only when several new slider items are created without reordering (position is then null). Wouldn't be better to recalculate position after creating a new item? (right now items with null in position behave differently in administration and on frontend)" + }, + { + "prediction": "I think it should be `uint64(100)` instead of `uint64(10000)`.", + "reference": "`ClaimFromRewardingFundBaseGas` is a global variable (from `gochecknoglobals`)" + }, + { + "prediction": "I'm not sure this is the right place for this function. It seems like it should be in the base class, but I'm not sure what the right place is.", + "reference": "How about modifying the NOGIL definition so that it only does anything if the thread safety flag (RDK_BUILD_THREADSAFE_SSS) is set?" + }, + { + "prediction": "I'm not sure this is the right place for this interface. I think it should go in `pkg/p2p/p2p_interface.go` and `pkg/p2p/p2p_interface_test.go`.", + "reference": "blockheighter would be more clear" + }, + { + "prediction": "I don't think we need this function at all.", + "reference": "This is so weird as a utility function." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I could come up with that didn't make the tests flaky.", + "reference": "Why? What would happen if you did not?" + }, + { + "prediction": "I don't think this is the right way to do it. The `opt` method will return `null` if `o` is `null` or if `pathElement` is not present in `o`. You need to check if `o` is not `null` and `pathElement` is present in `o` before calling `opt` method.", + "reference": "Unrelated bugfix for NPE." + }, + { + "prediction": "I think it would be better to check if the property is writable and only then check if it can be toggled.", + "reference": "What if some extended the `AdminController` and had a check for the old option name? Could that be a valid use case?" + }, + { + "prediction": "`preventRequestAbort` is not used in this function. Can you remove it?", + "reference": "This will be only available when data-manager is enabled, is there a fallback in case data manager is disabled?" + }, + { + "prediction": "nit: I think it would be nice to have a link to the COPILOT-1000 ticket explaining why this is the best way to do it.", + "reference": "Do you think we want to move the call to `generateWorkerServiceRecommendedActions` inside `RecommandedActions()`?" + }, + { + "prediction": "This should be `VUID-vkGetQueryPoolResults-flags-02827` not `VUID-vkGetQueryPoolResults-flags-00815`", + "reference": "The VUIDs in this area are not great, but I think `ValidateQueryPoolStride` should probably be skipped if the query pool was created with type `VK_QUERY_TYPE_PERFORMANCE_QUERY`. VUID-02828 might be a better fit, but again, the existing VUIDs step on each other so it requires a bit of interpretation." + }, + { + "prediction": "I'm not sure if this is the best name for this method. It's not a key, it's a byte array, so maybe `ToDbKeyBytes` would be better?", + "reference": "Iguess you should use ToDbKey here" + }, + { + "prediction": "I don't think this is correct. The counting index is used to count the number of blocks in the bucket, not the number of blocks in the bucket at the given height.", + "reference": "x.tbk is the \"index\" below, and is done in Start()" + }, + { + "prediction": "I think this should be `private const string DD_IsAppInsightKey = \"DD_IsAppInsight\";`", + "reference": "Do we already have a convention for this? If not, would we consider \"DataDog.IsAppInsights\". And then use \"DataDog.\" prefix for all this settings, environment variables etc..? Such settings are, essentially, public APIs because they may conflict with customer data. Regardless of that , AppInsights has an s at the end :)" + }, + { + "prediction": "I think this should be `ctx->log_key && ctx->time_key && ctx->time_key_format && ctx->log_key`", + "reference": "this assignment is not necessary if the offsetof() is used in the configmap" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in the `if` block above.", + "reference": "I'd rather leave a TODO here at least." + }, + { + "prediction": "I'm not sure this is the right fix. I think we need to make sure that the `body` is not `None` in the case of a 404.", + "reference": "Shouldn't this be `resource`?" + }, + { + "prediction": "I'm not sure this is the right way to do it. The problem is that `value` is initialized to `0` before the loop starts, so it will always be `0` even if the loop is not executed.", + "reference": "Why does this become blocking for the CPU path? Shouldn't it remain independent of the GPU path?" + }, + { + "prediction": "I'm not sure this is the right name for this method. `configure` sounds like it's doing more than just setting up the environment.", + "reference": "Do we need to change occurences where `setup` was called before?" + }, + { + "prediction": "I'm not sure this is the best place to put this. I think it would be better to put it in the `resolveReferences()` function above.", + "reference": "Is this TODO still valid? Or are we going to put this somewhere else later?" + }, + { + "prediction": "`timestamp` is not used in this function. Can you remove it?", + "reference": "We generally don't do parantheses in if conditions in Python. :) this could be better written as `if from_ts is None`" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it's better to do it in `tm_process_req_requestregioninfo` since it's the main place where we call `HbaseTM_process_request_regions_info()`, which is called from `HbaseTM_process_req_requestregioninfo()`, which is called from `HbaseTM_process_req_requestregioninfo()`, which is called from `HbaseTM_process_req_requestregioninfo()`, which is called from `HbaseTM_process_req_requestregioninfo()`, which is called from `HbaseTM_process_req_requestregioninfo()`, which is called from `HbaseTM_process_req_requestregioninfo()`, which is called from `HbaseTM_process_req_requestregioninfo()`, which is called from `HbaseTM_process_req_requestregioninfo()`, which is called from `HbaseTM_process_req_requestregioninfo()`, which is called from `HbaseTM_process_req_requestregioninfo()`, which is called from `HbaseTM_process_req_requestregioninfo()`, which is called from `HbaseTM_process_req_requestregioninfo()`, which is called from `HbaseTM_process_req_requestregioninfo()`, which is called from `HbaseTM_process_req_requestregion", + "reference": "Odd that we'd set just element 299 of a 2000-byte buffer to null. But I see that this is the way it was before." + }, + { + "prediction": "I'm not sure if we want to add a new interface for this, but I think it would be good to have a separate interface for this. It would make it clear that we don't want this to be part of the `ClosestPeerer` interface, and it would make it easy to change the implementation if we decide we want to do it in a different way.", + "reference": "ScoreFunc is not used in this PR. Maybe to add it later when needed?" + }, + { + "prediction": "I don't think we should be setting the Location header if the request is not a browser request. If the request is not a browser request, then the Location header should not be set. If the request is not a browser request, then the Location header should not be set. If the request is not a browser request, then the Location header should not be set. If the request is not a browser request, then the Location header should not be set. If the request is not a browser request, then the Location header should not be set. If the request is not a browser request, then the Location header should not be set. If the request is not a browser request, then the Location header should not be set. If the request is not a browser request, then the Location header should not be set. If the request is not a browser request, then the Location header should not be set. If the request is not a browser request, then the Location header should not be set. If the request is not a browser request, then the Location header should not be set. If the request is not a browser request, then the Location header should not be set. If the request is not a browser request, then the Location header should not be set. If the", + "reference": "super nit: I think this might be easier to read as `requestHeadersFromResponseWriter`" + }, + { + "prediction": "Why remove the mutex, thread and atomic?", + "reference": "Need to include \"common/base/Base.h\" in front of this line" + }, + { + "prediction": "nit: I think we can remove `matches` and `native-element-type` now since they are no longer used.", + "reference": "Changes in this file should go into a separate PR." + }, + { + "prediction": "I think this should be `public static String quoted(String text) { return new String(text, StandardCharsets.UTF_8); }`", + "reference": "Please ensure that this will not start putting single quotes where double quotes are expected." + }, + { + "prediction": "I think this should be `pingerPort: pingerPort` and not `pingerPort func(int, int) int`", + "reference": "`ProvideConfig` was changed, looks like it will not compile for windows, and should be changed too." + }, + { + "prediction": "I don't think we need to pass `u` here, since it's already available in `ctx.User`", + "reference": "This does not look right, you're listing all private repositories.." + }, + { + "prediction": "Layout/TrailingWhitespace: Trailing whitespace detected.", + "reference": "An OPTIONS request should respond from _any_ path? Seems weird to me..." + }, + { + "prediction": "This should be `width` and `height` and not `width` and `height` and `max_width` and `max_height`", + "reference": "you need to add the content type" + }, + { + "prediction": "I think this should be `TraceAgentProcess` and `StatsAgentProcess` instead of `traceAgentProcess` and `statsAgentProcess`.", + "reference": "Do we need to distinguish between these two processes? I'm thinking maybe we can have a list of processes and treat them all equally." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in `get_clean_call_switch_stack_size_x64` and `get_clean_call_switch_stack_size_aarch64`.", + "reference": "This is used only for out-of-line -- so yes this seems right to do for x64. Inlined is aligned separately at the end of prepare_for_clean_call(). There the ifdef is x86_64 or MACOS -- no ARM, why not? Also, please add || MACOS here to match the inlined." + }, + { + "prediction": "I'm not sure about this change. It seems to me that we should be able to use `zipkin_span_id` and `zipkin_annotation_span_id` instead of `zipkin_annotated_span_id` and `zipkin_span_id`.", + "reference": "guess I'm wondering if this needs to be refactored to use Schema.joinCondition() or similar?" + }, + { + "prediction": "Use the new Ruby 1.9 hash syntax.
Align the elements of a hash literal if they span more than one line.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", + "reference": "Does it make sense to restrict this option to `exec` only? You could add it specific to that subcommand using the `method_option`...method. There's an example of it for hosts in the `init` function." + }, + { + "prediction": "I'm not sure this is the best way to do this, but it's the only way I could come up with that worked.", + "reference": "This is very expensive (lots of allocations, lots of data copying). Could we do something like check IndexOf('%') and bypass if no hit?" + }, + { + "prediction": "This should be `|| client.getVar(Varbits.IN_WILDERNESS) == 1`", + "reference": "This should be `WorldType.isDeadmanWorld(client.getWorldType())` to be inline with the other WorldType calls." + }, + { + "prediction": "`mlvl` is short for Multi-Level Quantization, which means Multi-level quantization.", + "reference": "do we also need to change `mlvl_confid` -> `mlvl_confidences`>" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work for now.", + "reference": "I feel slightly that InterfaceExclude is not a clear name - bearing in mind that our config names are, to some extent, an external API. From an external point of view, a clearer name might be IPVSInterfaces. Then it would obviously make sense for the value to be something like 'kube-ipvs0', and it would be a matter of Felix's internal implementation that we choose to exclude those interfaces from our monitoring. Alternatively, if we want to keep this at a level that is more general than just IPVS, perhaps 'UnmonitoredInterfaces'? WDYT?" + }, + { + "prediction": "I think this should be `re.match(r'[A-Z][^\\\\]', path, re.IGNORECASE)`", + "reference": "This should be `re.search` with a `^` anchor added to the regex, as what we want here is really any path starting with something like `E:`." + }, + { + "prediction": "I think this should be `determineVirtualService` instead of `determineVirtualServiceHealth`.", + "reference": "Since `IsKubernetesBuiltInResource` at L69 returns false due to lack `networking.istio.io/v1alpha3` in `builtInApiVersions` within `pkg/app/piped/cloudprovider/kubernetes/resourcekey.go`, it will never reach this point." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the otlp-metrics package since it's related to otlp-metrics.", + "reference": "Does codecov not run this test? Not sure how else it would not be covered." + }, + { + "prediction": "I think it would be better to have this as a subcommand of `migrate` instead of a subcommand of `multisend`. The reason is that `migrate` is a general-purpose tool that can be used for many different things, whereas `multisend` is only used for bytecode generation. If we want to make `migrate` more reusable, we could add a `migrate` subcommand that accepts a single argument, which would be the bytecode file to be migrated. This would allow `migrate` to be used for more things, such as generating migration scripts from a database schema or generating migration scripts from a shell script.", + "reference": "can we add some sample of JSON_DATA format in the usage?" + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think it should be in the `ScopeManager` ctor.", + "reference": "Using `Tracer.Instance` in here is problematic for testing It will likely cause some other tests to break I think - that's why we started passing in `IScopeManager` EDIT: I see you used `[TracerRestore]` - maybe that'll be enough!" + }, + { + "prediction": "nit: I think we can remove the `@AutoValue` annotation here as well.", + "reference": "make all of these `static final` fields UPPER_SNAKE - they are constants." + }, + { + "prediction": "This should be `damage * (itembonuses.DoTShielding + itembonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_PERCENT] + aabonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_PERCENT]) / 100`", + "reference": "No possible chance for weird overflows here, right?" + }, + { + "prediction": "I think this should be called `DEF_EXTERNAL_COST` instead of `DEF_COST`.", + "reference": "Or we could use a Float object to more clearly show as user-settable via non-null?" + }, + { + "prediction": "I'm not sure if this is the right place to do this, since the forkchoice was already updated in the forkchoiceUpdated method.", + "reference": "finalizedHeader should be saved in FinalizationManager when we have FinalizationBlockHash != Keccak.Zero" + }, + { + "prediction": "I'm not sure if this is the best name for this step. I think it should be something like `data-disk-importer` or `data-disk-scratch-importer`.", + "reference": "Not using ExactName: true would remove the need for manually adding workflow ID as it would be added automatically by Daisy. E.g. 'disk-importer-2-import-ovf-7mn7h' was created from diskImporterDiskName above even though only 'disk-importer-2' was specified. ExactName: true should be used for resources that shouldn't include any temp prefix/suffix, such as disks that will be permanently attached to a created instance. Scratch disk is not one of them." + }, + { + "prediction": "I don't think this is correct. The `column_scols` is a list of `ColumnSelectorExpr`s, not a single `ColumnSelectorExpr`. You need to do `sdf.select(self._internal.index_scols + [scol_for(sdf, col) for scol, col in zip(column_scols, data_columns)])`", + "reference": "If we support multi-index column later, we need to rename to fit the pandas' requirement." + }, + { + "prediction": "I'm not sure this is the best name for this. It's not a value in a JSON, it's a map. I think `JSONMap` might be better.", + "reference": "I'm not sure this is really needed. JSONValue type can be used the same as a map as far as operators go, including range. I'd leave this out for now unless there is a strong reason to keep it." + }, + { + "prediction": "I think this should be moved to the top of the function, so that it gets executed before the loop below it.", + "reference": "sorry for nitpicking but I would love a new line under this line" + }, + { + "prediction": "I think this should be `AccountingStrategy` instead of `AccountantID`", + "reference": "ChannelImplementation field naming is not clear, is it some kind of standard? Maybe it can be named ChannelID?" + }, + { + "prediction": "I think this method should be called `removeAllFiles` instead of `RemoveFiles`", + "reference": "Looks like there is a typo: `expireSnapshots` -> `removeFiles` or whatever name we go with." + }, + { + "prediction": "I think this should be `values[i] != null` instead of `currentSortOrder == values[i] || currentSortOrder == null`", + "reference": "Thanks for looking into this. I think it looks a bit strange to have this check inside the for loop. Wouldn't it also work to initialize `idxCurrentSort` with 0 instead?" + }, + { + "prediction": "Can we have a constant for this value instead of hardcoding it?", + "reference": "Just a small ordering thing: Could you please bring `IMPORTANCE_HIGH` to the bottom and maybe even have one line between it and the Notification IDs?" + }, + { + "prediction": "I'm not sure this is the right fix. The problem here is that the function `MolOps::Kekulize` doesn't throw an exception, it just returns a `const char*`. So when you try to catch this exception, you get a `const char*` instead of a `std::string`.", + "reference": "Should this be boost logged?" + }, + { + "prediction": "I think this should be called `session` instead of `session_object`", + "reference": "What is the reason for doing expunge here? This method is purely for converting the timestamp." + }, + { + "prediction": "I think this should be `structField.name()` instead of `structField.name().toLowerCase()`.", + "reference": "This calls sanitize twice if the name isn't valid." + }, + { + "prediction": "I'm not sure this is the right place for this method. I think it should go in the `ApprovalGroup` model, since that's where the approval flow is defined.", + "reference": "Is there an equivalent that'd allow zero or one?" + }, + { + "prediction": "I think this is the only place where we check if repetition is based on task object name itself. If it is, then we need to set the task object name.", + "reference": "Is it possible to update/re-evaluate entire metatask object for every repeat? If we decide/need to use a repeatWith resources in let us say labelSelector(bad example) then we would have to add another logic to update those properties." + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it's the only way I could get it to work.", + "reference": "unnecessary conversion (from `unconvert`)" + }, + { + "prediction": "I think you can remove this line too.", + "reference": "typo in commit message `openening`" + }, + { + "prediction": "I don't think you need to include `ADIOS_CPP.h` here.", + "reference": "User-code doesn't see the internal ADIOS headers anymore. This whole include block should just be `#include `" + }, + { + "prediction": "I'm not sure this is the right place for this test. I think it should go in `test_views.py`.", + "reference": "nit: I guess we can omit this (unless you had a reason to specify it)" + }, + { + "prediction": "I think this should be `c.isSpokeLeafNode()`.", + "reference": "Why is Hub public?" + }, + { + "prediction": "I think this is the only place where we call `appendDockerDependentCapabilities` from `ecsAgent`. I think we should move it to `appendDockerCapabilities` so that we don't have to repeat the code in `appendDockerDependentCapabilities` in `appendDockerCapabilities`.", + "reference": "why is this deleted?" + }, + { + "prediction": "I'm not sure this is the best place to put this. I think it would be better to put it in the `before_action :check_prerequisite` in the `Topic` model.", + "reference": "Maybe move that into a partial" + }, + { + "prediction": "I think this should be `require.NoError(t, dao.Start(ctx))` instead of `require.NoError(dao.Start(ctx))`", + "reference": "Error return value of `dao.Stop` is not checked (from `errcheck`)" + }, + { + "prediction": "I think this should be `Warnf` instead of `UserOut.Warnf`.", + "reference": "util.Warning()? Easier to say." + }, + { + "prediction": "I'm not sure this is the right way to do it. I'm not sure we want to log every change to the trie. I think we want to log every change to the trie once every 10000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "reference": "this default is kinda superfluous (although i see it was already there before PR )" + }, + { + "prediction": "I think we can remove the `parentNode` field from the `NodeList` interface and the `NodeList#add` and `NodeList#remove` methods can just call `setParentNode(parent)` and `parentNode = parent`.", + "reference": "How is this related?" + }, + { + "prediction": "I'm not sure if this is the best way to go about it, but it's the only way I could get this test to pass locally.", + "reference": "I'm breaking one of the rules here, it feels like the right thing to do. Open to alternative suggestions." + }, + { + "prediction": "I think this should be `sw_vers -productVersion 2>/dev/null | cut -d . -f 2 -l 1`", + "reference": "The use of `#should` was triggering an rspec depracation warning for me, which is why I switched this to the rspec 3 style." + }, + { + "prediction": "I'm not sure this is the right fix, but it's the only thing I can come up with right now.", + "reference": "Why are you setting the CacheChange as REQUESTED when it is not valid (it was erased from history)?" + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in the `AnalyticsDashboardWidget` component, since that's the parent component for all of these widget types.", + "reference": "`lodash` shouldn't be grouped under WordPress dependencies" + }, + { + "prediction": "I think this should be `org.apache.avro.Schema avroSchema) {`", + "reference": "This needs to be public so that Avro can call it." + }, + { + "prediction": "I think we can get rid of the `import { apiFetch } from 'GoogleComponents/data'` line.", + "reference": "`Google*` shouldn't be under External dependencies - seems like ESlint is not properly recognizing that these are aliases to internal dependencies." + }, + { + "prediction": "I don't think this is correct. If `data` is a `pandas.core.series.Series`, then `data.to_dataframe()` should return a `pandas.core.series.Series` object, not a `pandas.DataFrame` object.", + "reference": "I think he meant the docstring in this constructor. yea we should fix" + }, + { + "prediction": "I don't think this is the right place to put this method. I think it should be in `BinaryDictionary` since it's only used by that class.", + "reference": "so .. this basically follows the pattern from JapaneseTokenizer, I think. .. but somehow I don't see where we defined ResourceScheme? We're not referencing the one in kuromoji, right?" + }, + { + "prediction": "I think we can drop the `Tls11` and `Tls12` flags, since we don't support those versions.", + "reference": "It would probably be better to do: const SecurityProtocolType Tls13 = (SecurityProtocolType)12288" + }, + { + "prediction": "I don't think we should remove this.", + "reference": "Similar to the above, put this setting back but keep the value as `'{}'`" + }, + { + "prediction": "I think this should be moved to the `if __name__ == '__main__'` block, so that it's only run when the script is actually being run.", + "reference": "As discussed in chat - we should run this function within an app context which means that we'd already have a logger configured, and a connection to timescale set up" + }, + { + "prediction": "I'm not sure about this change. I think we should keep the `about` div and add a `#about-content` class to it so that we can use the `collapse` and `collapse-toggle` classes from the `discourse/lib/discourse.js` file.", + "reference": "I'm curious about why this needed to be removed." + }, + { + "prediction": "I don't think we need to import `six` here.", + "reference": "why did you remove `zip`? It is used!" + }, + { + "prediction": "I think this should be `MarkTopicReadyReason`.", + "reference": "Is there any reason that we don't add a similar condition like `ChannelConditionTopic` to the channel?" + }, + { + "prediction": "This file should be renamed to `TestVendor\\Goto\\GotoTest.php`", + "reference": "before php8 \"goto\" was a reserved word and was not allowed as part of the namespace. Now test checks for validity of plugin namespace according to PSR-4" + }, + { + "prediction": "I don't think this is correct. We need to support TLS.", + "reference": "nit: I'm not sure it can be addressed in this diff, but it seems odd that NewOutbound supports TLS but NewSingleOutbound does not. As a somewhat naive user I would expect the only difference between these two APIs is how peers are chosen." + }, + { + "prediction": "I think this should be `yarpcerrors.Newf(yarpcerrors.CodeInternal, err.Error())` instead of `return nil, yarpcerrors.Newf(yarpcerrors.CodeInternal, err.Error())`", + "reference": "I would advise to enhance the test for the method `CallOneway` - we should have a test very similar to `TestCallSuccess`. We should test: - Success with response (even if it is callOneway) - Success with no response and empty payload - Errors" + }, + { + "prediction": "I'm not sure this is a good idea. I think it would be better to use a regular expression that matches what we expect to be an email address, rather than a regex that matches what we don't expect to be an email address. For example, what do you think of: `^\\S+@[a-z\\d-]+(\\.[a-z\\d-]+)*$`?", + "reference": "We're already matching +. Not sure why this changed." + }, + { + "prediction": "I think this should be `sonata.classification.default_category` instead of `sonata.classification.manager.category`", + "reference": "Please add line breaks, so the line doesn't exceed 80 chars." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `Instrumentation\\AspNetCore\\DiagSourceSubscriber`, right?", + "reference": "I initially thought (inccoreclty) this is a breaking change! The public api analyzer is a gift!" + }, + { + "prediction": "I think this should be `g_hash_table_new_full (g_hash_table_hash, g_hash_table_equal, g_free, g_free);`", + "reference": "I'm not sure how this one didn't segfault before." + }, + { + "prediction": "nit: I think it would be better to have a constant for the port number instead of hardcoding it.", + "reference": "Same points as in other test file." + }, + { + "prediction": "These imports are not needed.", + "reference": "Did you run gradlew tidy? Wildcard imports shouldn't be there, hence the question." + }, + { + "prediction": "I'm not sure if this is a good idea, but I don't have a better suggestion.", + "reference": "Put a comma after the last parameter of a multiline method call." + }, + { + "prediction": "Shouldn't this be `ON_FPGAINFO_ERR_GOTO(res, out, \"setting type to FPGA_IFC_DFL\");`?", + "reference": "Is this going to restrict the output to *ONLY* ports that are bound to vfio-pci? That's not what we discussed yesterday." + }, + { + "prediction": "I'm not sure this is the right place to do this. If we're going to do it here, we should do it in a way that's consistent with the rest of the verification code.", + "reference": "Intention is to do the lookup here, I believe (where we can cache it). This would make the call non-pure function though. I'll confirm with lotus. ID addresses are the *only* addresses I expect to actually see here." + }, + { + "prediction": "I think this should be `emr_fs` instead of `emrfs`", + "reference": "electronic medical record file system (EMRFS)" + }, + { + "prediction": "I'm not sure about this one. I think it's better to keep it as it is.", + "reference": "Put this higher in the list, like after \"bind\", since I guess we're considering the max request body size to be kind of a native/fundamental feature, built directly into the vhosts." + }, + { + "prediction": "I think we can remove `ErrInvalidOrderType` and `ErrAskNotFound`, `ErrDeviceNotFound` and `ErrMinerNotFound` can be removed too.", + "reference": "oh come on :(" + }, + { + "prediction": "I think this should be `LOG.info(String.format(\"Detected dialect: %s\", toReturn.dialect.toString()));`", + "reference": "This is an incorrect change. The dialect spoken is an important part of the handshake and should be communicated to users." + }, + { + "prediction": "I think this should be `bool: Whether or not the installer is running as a service account`", + "reference": "Remove as this is not needed anymore." + }, + { + "prediction": "I'm not sure this is a good example of what we want to do here, but I'm not sure we have a better one.", + "reference": "This new class is for checking that #4551 works correctly with PlantUML output too." + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in `certificates.go` since it's only used there.", + "reference": "Will this cause all certificates to be re-issued?" + }, + { + "prediction": "I think this should be `tmp = NULL;` after the `if (FPGA_OK != result)` check.", + "reference": "I think tmp is also leaked at the end of this loop if no error cases are encountered." + }, + { + "prediction": "I think this should be `keyField.name()`, not `keyField.getSchema().name()`.", + "reference": "The previous version didn't use `keyProjection` because the entire key must be projected. If the key is a struct of multiple columns, then projecting a subset of those columns can easily introduce key collisions that aren't in the original data." + }, + { + "prediction": "I think this should be `auto spaceId = ectx()->schemaManager()->toGraphSpaceID(spaceName);` instead of `spaceId = ectx()->schemaManager()->toGraphSpaceID(spaceName);`", + "reference": "Why not use StatusOr ? We can't ensure spaceId is greater than zero, especially when AdHocSchemaManager is used." + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in the `rpc` package, but I'm not sure.", + "reference": "Does it seem we only use that as the json-rpc client? Do we have any other choice? It's a little weird." + }, + { + "prediction": ".ROLE_MENUBUTTON, controlTypes.ROLE_TREEVIEW, controlTypes.ROLE_CHECKMENUITEM, controlTypes.ROLE_RADIOMENUITEM)\n \t\t\tor (role in (controlTypes.ROLE_TABLE, controlTypes.ROLE_TABLECELL, controlTypes.ROLE_TABLEROWHEADER, controlTypes.ROLE_TABLECOLUMNHEADER) and not formatConfig[\"reportTables\"])\n \t\t\tor (role in (controlTypes.ROLE_LIST, controlTypes.ROLE_LISTITEM) and controlTypes.STATE_READONLY in states and not formatConfig[\"reportLists\"])\n \t\t\tor (role in (controlTypes.ROLE_FRAME, controlTypes.ROLE_INTERNALFRAME) and not formatConfig[\"reportFrames\"])\n+\t\t\tor (role in (controlTypes.ROLE_DELETED_CONTENT,controlTypes.ROLE_INSERTED_CONTENT,controlTypes.ROLE_LINK, controlTypes.ROLE_HEADING, controlTypes.ROLE_BUTTON, controlTypes.ROLE_RADIOBUTTON, controlTypes.ROLE_CHECKBOX, controlTypes.ROLE_GRAPHIC, controlTypes.ROLE_CHART, controlTypes.ROLE_MENUITEM, controlTypes.ROLE_TAB, controlTypes.ROLE_COMBOBOX, controlTypes.ROLE_SLIDER, controlTypes.ROLE_SPINBUTTON, controlTypes.ROLE_COMBOBOX, controlTypes.ROLE_PROGRESSBAR, control", + "reference": "Could you split this into multiple lines?" + }, + { + "prediction": "I think this import should be removed.", + "reference": "Doesn't the snapshot ID start off as null? It seems like we don't need to set it here." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it's the only thing I can come up with.", + "reference": "I wondered why `buffer` was passed into `LookupPath`. What is happening here? Is `buffer[:0]` equivalent to `[]V4TrieEntry{}`, and hence `buffer` isn't needed any more?" + }, + { + "prediction": "I think we can remove the `sigValidator` and `powerTable` fields from the `Expected` struct, since they are no longer used.", + "reference": "nit: Ideally we would would use this abstraction everywhere we need this translation. I believe it's needed in the mining worker and the storage and market connectors." + }, + { + "prediction": "I think this should be `UpdateHash(cStorPoolGot, common.CalculateHash(cStorPoolGot.Spec.Disks.DiskList))` and not `UpdateHash(cStorPoolGot, hash)`", + "reference": "need to fix the error message here" + }, + { + "prediction": "Why is this being removed?", + "reference": "Unsure of how to handle this one." + }, + { + "prediction": "I think it would be better to log the reason why the kill is being requested.", + "reference": "Will this.flowFinished verify with every finished state stated in Status.isStatusFinished method? If so, no need to verify isKilled." + }, + { + "prediction": "I'm not sure this is the best name for this. I think it should be something like `MaxRetryAttempts` or `MaxRetryIntervalInSeconds` or something like that.", + "reference": "replace \"Child Workflow\" with \"any workflow\"" + }, + { + "prediction": "I think this should be `data-order=\"-1\"`, not `data-order=\"-2\"`", + "reference": "Instead of showing the words \"symbolic link\" under the \"Size\" column, how about we introduce new icons for symbolic link to file and symbolic link to directory?" + }, + { + "prediction": "I think this should be `@param string $rangeFilter The Lucene query language filter to be used for querying Solr`", + "reference": "Please add back the description of the parameter" + }, + { + "prediction": "Please remove this empty line.", + "reference": "Superfluous space inserted." + }, + { + "prediction": "I'm not sure this is the right way to do it. I think we need to check if the node is an SVG element and only then try to get the attribute.", + "reference": "Didn't fix the problem. `href=\"\"` for SVG will still result in `undefined` getting returned by this function." + }, + { + "prediction": "I think this should be `240` instead of `238`.", + "reference": "This seems like a strange change ... I wouldn't think that a change to access tags in the profiles would result in different bearings in this tests?" + }, + { + "prediction": "I think this should be `api.setNavigatorObject(eventHandler.lastQueuedFocusObject, isCaret=False, isFocus=False)`", + "reference": "As isCaret is False by default, explicitly specifying isCaret=False here is not needed, and is perhaps a little confusing. I'd prefer that anywhere in the codebase that isCaret is only ever specified if it needs to be set to true. Mirroring that of isFocus for setNavigatorObject." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "We can't freeze this and then add something to it in the next line. The `freeze` on line 43 is sufficient. If Rubocop flags this we need to exclude it." + }, + { + "prediction": "I think this should be `sort.Slice(aps[i].Subjects, func(i, j int) bool { return len(aps[i].Subjects[i]) > len(aps[j].Subjects[j]) })`", + "reference": "Why is this needed?" + }, + { + "prediction": "I'm not sure if this is the best place to put it. I think it would be better to put it in `user/repo`.", + "reference": "Why not put two other routes after this line (221)?" + }, + { + "prediction": "I think this should be `std::nullopt`.", + "reference": "If FLAGS_meta_server_addrs is not empty, in which case \"toHosts\" return empty array?" + }, + { + "prediction": "I think this should be `Settings.JSONBoolWithQuotes(DEFAULT_JSON_USE_QUOTES);`", + "reference": "There is a function to output a \"JSONBool\" string. That would be a good start for finding uses. But maybe just have a look at where we decide whether it is a numerical or not, thus wrapping quotes around its value. Then you have it all I guess." + }, + { + "prediction": "I'm not sure this is the right way to do it. I think it should be `data._kdf._internal.copy(sdf=sampled, scol=scol).to_pandas()`", + "reference": "oops, it should be `data._scol` so that it respects the expression stored in Series. Let me fix it quick." + }, + { + "prediction": "Layout/TrailingWhitespace: Trailing whitespace detected.", + "reference": "Thanks for moving this up with the rest of the variables. Much tidier :)" + }, + { + "prediction": "I think this should be `0.0001` instead of `0.001`", + "reference": "I think `Rate` is a more precise and concise term for `PaymentPerTime`." + }, + { + "prediction": "I think this should be `posEnd` instead of `posNext`.", + "reference": "I think this should maybe be: var limit = input.IndexOfAny(new[] { '+', '-', ']' }, **posNext**); You pretty much want to ignore any sign that is before the \"M\". But, if there is a sign somewhere before the M, and also after the M, you'd want to be able to find the sign after the M, right?" + }, + { + "prediction": "I think this should be done in `checkValidDelivery` method, not in `checkCartNotEmpty` method.", + "reference": "if `checkStockNotEmpty` returns a reponse, you must return it or your script will continue its execution." + }, + { + "prediction": "I'm not sure if we want to change the name of this package.", + "reference": "Any specific reason for this change? klog should work correctly here." + }, + { + "prediction": "I think this should be `RETURNING id, as_epoch(last_modified) AS last_modified;`", + "reference": "we don't mention `last_modified` here?" + }, + { + "prediction": "I think we can remove the `inputEl` variable now, since it's not used anymore.", + "reference": "same deal about the global state maybe interfering as in ActionBrowseTagline" + }, + { + "prediction": "I think this should be `throw new ArgumentOutOfRangeException(\"maxCapacity\", string.Format(\"LruCache capacity cannot be less than {0}\", maxCapacity), nameof(maxCapacity));`", + "reference": "so sweet to see a test as the first thing" + }, + { + "prediction": "I think this should be `config->http_proxy = getenv(\"HTTP_PROXY\");`", + "reference": "usually when HTTP_PROXY=\"\" (empty), proxy should be disabled. could you set it to NULL when it's empty string?" + }, + { + "prediction": "I don't think this is correct. If the width is null, then the height should be the same as the width, not the other way around.", + "reference": "Can you throw an exception if width or height are both null" + }, + { + "prediction": "I'm not sure about this change. I think we should keep it as it was before.", + "reference": "This is a breaking change. I guess these might have been intentionally exported." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the same place as `targetSplitSize(ops)`.", + "reference": "I don't think this is necessary. When options are used to set the split size in the Spark reader, it uses `TableProperties.SPLIT_SIZE` to pass it here. That should work for metadata tables as well, right? The situation that we need to handle in this PR is setting the default, like you had before. We just want to use a metadata split size so you can set it and not have the same split size used (by default) for both metadata and data scans." + }, + { + "prediction": "I think it would be better to have a `String()` method on `BinaryOperator` that returns the string representation of the operator. That way, we don't have to duplicate the logic in both `BinaryOperator` and `UnaryOperator` for the string representation.", + "reference": "wait a sec, shouldn't this be `'*'`?" + }, + { + "prediction": "I think this should be `varMap[\"compute_service_account\"] = oi.params.ComputeServiceAccount` instead of `varMap[\"compute_service_account\"] = oi.params.ComputeServiceAccount`", + "reference": "It think you'll want the var for GMI import as well: daisy_workflows/ovf_import/create_gmi.wf.json (Unfortunately there's duplication between the two :/ )" + }, + { + "prediction": "I think it would be better to use `self._commands[\"GET_CONTEXT\"] = (\"GET\", \"/session/$sessionId/moz/context\")` instead of `self._commands[\"GET_CONTEXT\"] = ('GET', '/session/$sessionId/moz/context')`", + "reference": "Nit: Group this with the other commands by moving it down one line." + }, + { + "prediction": "I think this should be `throw new UnsupportedOperationException(\"Unknown encoding: \" + dataEncoding);`", + "reference": "I would like to emphasize that a user can use non-vectorized reads to handle this file so maybe something like \"Cannot perform a vectorized read of ParquetV2 File with encoding %s, disable vectorized reading with $param to read this table/file\"" + }, + { + "prediction": "I think it would be better to call it `parameter_name` instead of `param_name`.", + "reference": "Maybe add `positional=False`. It does not need it more than the other parameters, but one must start somewhere." + }, + { + "prediction": "I think this should be `rsWithPrimaryPath` and `rsWithoutPrimaryPath` should be `f('%s/../spec/max-staleness/ReplicaSetWithPrimary', __dirname);` and `f('%s/../spec/max-staleness/ReplicaSetNoPrimary', __dirname);`", + "reference": "Since we're here, can we use a template?" + }, + { + "prediction": "I think this should be moved to the top of the file.", + "reference": "saw you're also doing this in `test_types.py`: `spark = _spark_context()['test'].resources['spark'].resource_fn(None)` since `_spark_context()` uses `spark_session_local` won't the above break the tests?" + }, + { + "prediction": "I'm not sure this is the right place for this test. I think it should go in `test/testutil/testutil.go` since it's only used by `test/testutil/testutil.go` and `test/testutil/testutil.go` should be the home of unit tests that are not related to each other.", + "reference": "`has(default)` i think is the preferred way of doing this" + }, + { + "prediction": "I don't think we should be using the `force` keyword here.", + "reference": "always put a space after a comma" + }, + { + "prediction": "I don't think this is the right place to do this. It should be done in the `onItemLongSelected` method of the `MediaSelectionMediationActivity`", + "reference": "@angmas1 move the else up, next to the closing bracket of the if block. Also, there is no need for the braces as your else statement contains only a single line. Make your if-else block similar to the block in lines 277-280." + }, + { + "prediction": "I think we can remove the `file_detector` argument from this class.", + "reference": "@AutomatedTester @davehunt thoughts on a new keyword argument?" + }, + { + "prediction": "I think this should be `Integer` instead of `int`", + "reference": "This change shouldn't be necessary for this PR. Please remove it." + }, + { + "prediction": "I think we can remove the `testCtx` variable now, since we don't need it for this test.", + "reference": "This variable is mostly unused, how about we make `NewTestCtx` return a pointer?" + }, + { + "prediction": "I think this should be `maxPayloadLen = 32 * 1 << 20 // 32 Mi`", + "reference": "What is the basis of this value?" + }, + { + "prediction": "Is this file still needed? I don't see it referenced anywhere in the codebase.", + "reference": "Nit: was this extra blank line added intentionally?" + }, + { + "prediction": "I think this should be STATUS_GUARD_PAGE_VIOLATION instead of STATUS_GUARD_PAGE_VIOLATION", + "reference": "nit: inconsistent spacing around =" + }, + { + "prediction": "I think this should be `Sonata\\MediaBundle\\Model\\ClassificationInterface`", + "reference": "We still need this import" + }, + { + "prediction": "Why is this change needed?", + "reference": "We are pulling this because we removed \"groupID\" state and put it into the strategy implementations" + }, + { + "prediction": "I think this should be `#include \"oneapi/dal/algo/kmeans_init/compute.hpp\"`.", + "reference": "Is this file actually related to PCA?" + }, + { + "prediction": "I think this should be `isAdmin`, not `owner`.", + "reference": "See above, this should probably remain `isFirstAdmin`." + }, + { + "prediction": "I think this should be `type Expression` instead of `type MonoType`", + "reference": "Why the change to make it public? The expression interface has the `TypeOf` method?" + }, + { + "prediction": "Should this be `public void SingleArchiveFileRollsCorrectly() {`?", + "reference": "don't mind the snake cases in the test names. If there are in the test cases, it's fine IMO" + }, + { + "prediction": "I'm not sure this is the right place for this. I would expect it to be in `Identity/identity.go` or `Identity/identity_locking.go` but not here.", + "reference": "`Id` defines REST resource address and should not be in payload" + }, + { + "prediction": "`--class_wise` -> `--class-wise`", + "reference": "We can omit the underscore and just use `classwise`." + }, + { + "prediction": "This should be safe as the root category has to exist for a given context but I do not like fatal errors.", + "reference": "Why not throw an exception instead then?" + }, + { + "prediction": "I think this should be `getInputFile(task.file().path().toString())`", + "reference": "Looks like this doesn't need to change. Can you revert this?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `cli/__init__.py` or `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py` in `cli/__init__.py", + "reference": "please import it like `from kinto.config import template`" + }, + { + "prediction": "I think it would be better to have a constant for `false` and `true` instead of `true` and `false`.", + "reference": "There are lots of default value changed, not sure if it break the old behavior." + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in `github.com/elastic/beats/libbeat/common`", + "reference": "File is not `goimports`-ed (from `goimports`)" + }, + { + "prediction": "`addToStaticNodes` is not used anywhere, please remove it.", + "reference": "parameter should be called removeFromStaticNodes" + }, + { + "prediction": "`override` should be `bool`, not `bool | False`.", + "reference": "The handler will have an extra property in the marker to signal the implementation is in the provider, for the cases we want to add functionality, for example, custom implementations not in moto." + }, + { + "prediction": "Do we need this method at all? The `active?` and `deactivate`/`activate` methods seem to be sufficient to determine if a subscription is active.", + "reference": "Is this method actually being used anywhere? If not, I think we should remove it." + }, + { + "prediction": "I think this should be `!= null && (bodyParameterType.ComposedProperties.Count(p => !p.IsConstant) <= Settings.Instance.PayloadFlatteningThreshold || bodyParameterType.ComposedProperties.Count(p => !p.IsReadOnly) <= Settings.Instance.PayloadFlatteningThreshold)`", + "reference": "Thanks! I somehow lost this between my far too many branchs." + }, + { + "prediction": "I think this should be renamed to `SeleniumWebDriver` instead of `RemoteWebDriver`", + "reference": "i think this should get put into its own file. This could start to grow :)" + }, + { + "prediction": "I think this should be `gcr.io/google_containers/pause` instead of `amazon_containers/pause`", + "reference": "Can you add a TODO for loading the tarball of the pause image into Docker?" + }, + { + "prediction": "Why is this removed?", + "reference": "Is there any value in setting the process to null like this?" + }, + { + "prediction": "`softmax_axis_` is a member variable of SoftmaxWithLossLayer. You can access it directly.", + "reference": "This could be a good time to add a check that the prediction and target dimensions (except channel) agree?" + }, + { + "prediction": "I'm not sure what this is supposed to do, but if it is supposed to be here, it should be in a separate commit.", + "reference": "The requirement that OP_isb is bb-final needs to be a rule for clients, just like the rule that syscalls and interrupts must be bb-final: i.e., please add it to the dr_register_bb_event() docs." + }, + { + "prediction": "I think this should be `Globalize.getString(\"ListPaging\").replace(\"{0}\", (totalRecordCount ? startIndex + 1 : 0) + \"-\" + recordsEnd).replace(\"{1}\", totalRecordCount);`", + "reference": "The translate library has a method to replace the variables." + }, + { + "prediction": "I think this test is a bit too specific to the `fillna` method. Can we instead test `fillna` with different values? For example, `fillna(0, method='ffill')` and `fillna(0, method='bfill')`?", + "reference": "i don't think this test case is correct. in both cases inpalce=True returns nothing. We need to compare the ks. Also we probably need to make a copy of it. Otherwise you pollute the following \"ks\" because ks has been changed." + }, + { + "prediction": "I think this should be `tls.TlsHandshakeHook`, not `tls.TlsHandshakeHook`.", + "reference": "Any proposals how to make the naming somehow include the \"completed\" idea of this hook? `TlsHandshakeCompletedHook` or similar? Or using the `...Start/End...` scheme?" + }, + { + "prediction": "I think this should be done in the `SyncReport` class, not in the `_syncReport` class.", + "reference": "it introduces a lot of complexity to the state, can we flush straightaway or create a two level flush store where the questions are read form unflushed data?" + }, + { + "prediction": "I think this should be `preg_replace('/[^a-zA-Z0-9\\-]/', '-', $node->id)`", + "reference": "There are two calls to getUrlFromRouteCache, but you're only urlencoding one of them. Is that intentional? Would it make more sense to do the url-encoding inside the getUrlFromRouteCache function?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in the `getEditedCell` method.", + "reference": "Maybe we can use `this.instance.getCell` with `topMost` flag to get `TD` element?" + }, + { + "prediction": "I think this should be a debug log.", + "reference": "Change this to Debug Level" + }, + { + "prediction": "I'm not sure this is the best way to do it, but I don't have a better idea.", + "reference": "I refactored the Aggregate, those are hard to read" + }, + { + "prediction": "I think this test should be moved to a separate file, since it's not related to the rest of the tests.", + "reference": "This is now done in the after method, so this test won't pass any more." + }, + { + "prediction": "Line is too long. [83/80]", + "reference": "What was the point of creating `user_block` if you're then not going to use it ;-)" + }, + { + "prediction": "Why is this removed?", + "reference": "@ueshin, I thought we can remove this entire file. Does that require some more works?" + }, + { + "prediction": "I think this should be `unicode(tokens.string.strip()[1:-1])` instead of `unicode(tokens.string)[1:-1]`", + "reference": "Just `return tokens.string[1:-1]` is enough" + }, + { + "prediction": "Use the new Ruby 1.9 hash syntax.
Use 2 (not 0) spaces for indentation.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", + "reference": "1 trailing blank lines detected." + }, + { + "prediction": "This should be `setPrefWidth(0)`.", + "reference": "Isn't this the default max width? In any case I would prefer to see these definitions in the css files." + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to be the only way I could get it to work.", + "reference": "Is this thread-safe? (If not, and if the solution is to introduce locking, let's reconsider how we do the scheme changing instead...)" + }, + { + "prediction": "I don't think we need to change anything in this file.", + "reference": "Looks like this file has tabs instead of spaces." + }, + { + "prediction": "I think this should be `seelog.Infow` instead of `seelog.Warnf`.", + "reference": "Hmm should we clean up container resources before task resources here? or the order does not really matter here?" + }, + { + "prediction": "I think this should be reverted.", + "reference": "Please undo this :wink:" + }, + { + "prediction": "Layout/AlignHash: Align the elements of a hash literal if they span more than one line.", + "reference": "thanks for adding this missing association" + }, + { + "prediction": "I think we can remove the `new` keyword here.", + "reference": "Should I remove this in favor of the HttpsConnectionFilterOptions overload?" + }, + { + "prediction": "Why not using `dba::selectMax` here?", + "reference": "This shode be nullable, there alway sholud be at least one status in system , if not exist that mean data problme" + }, + { + "prediction": "I think we should move this to `app/Http/Middleware/UninstallSW` so that it can be used in other controllers as well.", + "reference": "Spaces not tabs" + }, + { + "prediction": "I think this should be `fs.readdirSync(path, {withFileTypes: false}).map(e => e.name);`", + "reference": "To get the files inside a directory, please use `readDirStats()`." + }, + { + "prediction": "I'm not sure if this is a good name for this. I think it's a bit confusing because we have two different Docker and Plz containers. I think we should rename it to something like `ContainerImplementation` or `ContainerType`.", + "reference": "might be worth to call these `Isolation` instead of containers here and when presented to the user -- docker/rkt , in addition to cgroups and namespaces, also provide image discovery and filesystem preparation; there's also the security context and probably 1-2 other small things" + }, + { + "prediction": "Can we add a license header to this file?", + "reference": "File is empty, consider removing?" + }, + { + "prediction": "I'm not sure this is the right place for this method. I think it should go in `auth.py` instead.", + "reference": "This seems to return the registry_url. The more meaningful URL is the catalog URL, which is the URL the user specifies in `quilt3.login`. The username might also be as useful here if not more useful." + }, + { + "prediction": "I think this should be `L1StandardBridgeAddress` and `GasPriceOracleAddress` should be `L2StandardBridgeAddress` and `L2GasPriceOracleAddress`", + "reference": "Was the addition of `GasPriceOracleAddress` here erroneous?" + }, + { + "prediction": "Space inside { missing.
Space inside } missing.", + "reference": "I believe that you are going to have to do some work here to get the env var support for these values to still work correctly, otherwise they will get stored as :department instead of host_tags[:department]." + }, + { + "prediction": "I'm not sure this is the right way to do it. I think it would be better to iterate over `mSessions` instead of `mStoreSubscription.getTabs()`. The reason is that `mStoreSubscription.getTabs()` is a subset of `mSessions`, but `BrowserState.getTabs()` is a superset of `BrowserState.getTabs()`. This means that `BrowserState.getTabs()` will always return all sessions, whereas `mStoreSubscription.getTabs()` may not.", + "reference": "How was this causing the exception?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it would be better to move it to `css` folder.", + "reference": "I still have issues with it loading Simplified Chinese by default over Japanese, since they also share characters and we're not sure if characters are different or not. As-is, this fixes Traditional Chinese and Simplified Chinese, but we're not sure if it'd still screw up Japanese text or not. I maintain that, in my opinion, Japanese should be the only script of this kind loaded by default (Because of Hiragana and Katakana, that aren't shared with any other script) and either variant of Chinese should be loaded only in their respective case." + }, + { + "prediction": "I'm not sure this is the right place for this change. I think it should be moved to `IntervalsSource.java` since it's only used by `MultiTermIntervalsSource.java`, which is also the parent of `MultiTermIntervalsSource.java`.", + "reference": "Isn't it better to stub AtomatonQuery and yield it here. IIRC it resolves simplest MTQ highlighting cases as nobrainer." + }, + { + "prediction": "I think we can remove the `discount_percentage_vs_current_plan_annualized` method and just call `discount_percentage_vs_current_plan` directly.", + "reference": "Line is too long. [96/80]" + }, + { + "prediction": "I think this should be `kubernetes.io/os: linux` instead of `kubernetes.io/os: [linux]`", + "reference": "My only concern with changing the node selector here is that someone else _could_ have built their own images for other platforms and set them to be used using the flag override on the controller, which in turn this change would break. Perhaps not changing the selector for acmesolver pods makes most sense, and then working on actually having support for Windows? wdyt?" + }, + { + "prediction": "Why do we need this change?", + "reference": "Why do we need interface `InnerObjectWithSelector`, I searched the usage with this field, it seems nowhere use `GetSelectorSpecs()` methods provided by `InnerObjectWithSelector`" + }, + { + "prediction": "I think we should move this to `init.go`", + "reference": "Do we need this `init` here? We have already called the `InitContext` in `StartModule` directly." + }, + { + "prediction": "I don't think we need to check for w3c here. We can just do `self.execute(Command.MAXIMIZE_WINDOW)`.", + "reference": "This `if` is not necessary" + }, + { + "prediction": "I think we can remove the `dom.value` and `dom._lastValue` vars now.", + "reference": "should we add a `mangle.json` mapping for this? We could reuse a property name that's only used on component or vnode objects right now, like `__s` (\"next state\")." + }, + { + "prediction": "Line is too long. [83/80]", + "reference": "Please update the yard docs to indicate this new option." + }, + { + "prediction": "Nit: I think we can remove the `Subnets` field from the `AWSClusterSpec` struct now, since it's not used in the `AWSCluster` struct anymore.", + "reference": "Can you provide an example in the godoc section on how to use this? From the implementation it looks like the AvailabilityZone field is required for example, otherwise it can fail / error, is that correct?" + }, + { + "prediction": "I'm not sure if this is the best way to do this. I think we should be able to just do `tx.FirstOrCreate(&Migration{Version: latestSchemaVersion})` and it should work.", + "reference": "It would be great if this could be captured by a test." + }, + { + "prediction": "1*time.Second),\n+\t\tESProcessorAckTimeout: dc.GetDurationProperty(dynamicconfig.WorkerESProcessorAckTimeout, 1*time.Minute),\n \t}\n }\n \n```\nReview comment?", + "reference": "1000 -> 100 maybe too much, 200 ish to 500ish maybe a good option" + }, + { + "prediction": "I think this should be `[]byte(addr.String())` instead of `[]byte(addr.GetChecksumAddress().String())`", + "reference": "Any reason we need to keep this package's `ChecksumAddress` type or can we get rid of it too?" + }, + { + "prediction": "I think this should be `globalize.translate('ButtonRestart', { locale: 'en' })`", + "reference": "Above the one that was picked was the Button* prefix, and here it's the Header* prefix. Maybe the Button prefix is more general." + }, + { + "prediction": "I think this should be `BestSuggestedHeader?.Hash` instead of `Head?.Hash`", + "reference": "I might prefer changing: public Block FindPendingBlock() => FindBlock(PendingHash, BlockTreeLookupOptions.None); public BlockHeader FindPendingHeader() => FindHeader(PendingHash, BlockTreeLookupOptions.None); in IBlockFinder, what do you think?" + }, + { + "prediction": "I think this field should be renamed to `ApplyPolicy` or `Policy` to be consistent with the other fields in this struct.", + "reference": "This is necessary due to a bug in 4.7. Follow HIVE-1561 for getting rid of it." + }, + { + "prediction": "Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
Style/HashSyntax: Use the new Ruby 1.9 hash syntax.", + "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." + }, + { + "prediction": "I think this should be `XKeysymToString()`.", + "reference": "Some day (tm) I will also get rid of that one. But today is not that day..." + }, + { + "prediction": "I think this should be `if (substr($localPath, -1) === '/') {`", + "reference": "Add a space between if and opening parenthesis please (i.e. `if (`)" + }, + { + "prediction": "I think this should be `else:` instead of `scol = self._scol`", + "reference": "nit: `rename` instead of `alias`?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in `BlockDevices` function.", + "reference": "Per AWS docs EC instances have the root mounted at /dev/sda1. This label should be skipped." + }, + { + "prediction": "Why is this removed?", + "reference": "I'm not sure it is a better way to address lose message, if wait here, edge controller cant process message, event from watching api-server will be lost yet, right?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `EAP` class, since it's specific to the EAP protocol.", + "reference": "Please keep the correct alignment, it seems broken now (at least in Github). Can you reverse the test (`if p.value_size is None`)? Also, do you want `6` when `p.value_size is None` or `x + 6`? Maybe, in that case, something like `lambda p, x: x + 6 + (0 if p.value_size is None else p.value_size)` would be easier to read. Or even easier: `lambda p, x: x + 6 + (p.value_size or 0)`." + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be under `NetworkConfig`, but I'm not sure if that's the right place to put it as well.", + "reference": "Can we make sure ECS service treats it as int64 as well?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the UI module.", + "reference": "Please follow the naming convention for variables, i.e. `windowText`." + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in the engine package, but I'm not sure if it's the right package to put it in.", + "reference": "alias can be `cast`" + }, + { + "prediction": "I'm not sure this is the right place to add the memory mmap errors. The memory mmap errors should be added in the `h2o_iovec_t` struct, not in the `h2o_iovec_t` constructor.", + "reference": "Let's use `%zu` instead of casting to `uint64_t` and using `PRIu64`. The alternative is to change the type of `mmap_errors` to `uint64_t`, though I'd prefer not doing that because some 32-bit platforms might not provide atomic operation support for `uint64_t`." + }, + { + "prediction": "I'm not sure about this one. I think it's fine, but I'm not sure I agree with the wording of the warning.", + "reference": "I recall there being a reason we had this one set only to suggeation. @carterkozak do you remember why? or is my memory getting corrupted?" + }, + { + "prediction": "I think this should be `flatbuffers::StripPath` not `flatbuffers::StripExtension`.", + "reference": "This should now be made into `if (it->second.empty())` ?" + }, + { + "prediction": "I think this should be `self.num_of_searches -= 1` instead of `if self.num_of_searches > 0: return`", + "reference": "Do we need to worry about a race condition on this decrement (@The-Compiler)? I'm not sure how the python callbacks work, so this might not need to be something to worry about." + }, + { + "prediction": "I'm not sure this is the right place for this test. I think it should go in `test/testpropagators.go`", + "reference": "Should these assert that the extracted `SpanContext` is remote?" + }, + { + "prediction": "what is the difference between `ignore_wrt_candidates` and `match_low_quality`?", + "reference": "typo: allow low quality matches." + }, + { + "prediction": "I think we can remove the `cfg *cmds.Server` parameter from this function.", + "reference": "At some point we need to condense down and refactor our \"configs\" as we have too many in too many places and we're starting to get more illegible code. No change necessary but calling out for future reference." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `app/assets/javascripts/blacklight/breaking/javascripts/breaking-javascripts.js.erb`", + "reference": "Can we add the `if label` conditional to this please?" + }, + { + "prediction": "I think this should be `mlflow==0.2.0`", + "reference": "@thunterdb, can we increase the minimal version to almost the latest ones? I was thinking people will mostly use the latest version of mlflow" + }, + { + "prediction": "I'm not sure this is the right place for this hook. I think it should go in the `beforeFill` hook.", + "reference": "If the last argument is going to be removed, why would we add it to the API docs? Shouldn't it be private for internal use?" + }, + { + "prediction": "I think this should be `FileSystemIntermediateManager`, `InMemoryIntermediateManager`, and `IntermediatesManager` should be renamed to `FileSystemIntermediatesManager`, `InMemoryIntermediatesManager`, and `IntermediatesManager` should be renamed to `FileSystemIntermediatesManager`.", + "reference": "`Intermediates` or `Intermediate`" + }, + { + "prediction": "I don't think this is the best way to do this. I think it would be better to use `isinstance(element, dict) and 'id' in element and 'id' not in dict.get('id')`", + "reference": "This is not the right exception class. There is an InvalidSelectorException class that covers bad locators." + }, + { + "prediction": "I think this should be a warning, not an info.", + "reference": "If this code isn't needed, it should be removed." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think we should move this to `doUploadMetrics` in `metrics.go` since it's only called from there.", + "reference": "Should the `doRequest` func be a method on the `connection` type instead of passing state from the type?" + }, + { + "prediction": "I think we can remove the `ECS_CLI_ENVIRONMENT_NAME` variable as well.", + "reference": "we'll probably tackle these e2e tests at the end" + }, + { + "prediction": "I think we can remove the `CoreFX` category here.", + "reference": "what is this address pointing to? what are we measuring here? I want to have a better understanding." + }, + { + "prediction": "I don't think you need the `or dep_status = 0 or dep_status = 4` part here. You can just use `or dep_status in (0, 4)`", + "reference": "Would it be better to pass the dependency status as the parameter into the SQL string? In case the enum value is changed in the future, we don't need to change the code here." + }, + { + "prediction": "Is this needed?", + "reference": "Hah I had `gorename` failing without this too." + }, + { + "prediction": "I think we can remove this now, since we don't need it for the `appsec_blocking_enabled` property.", + "reference": "maybe prefix these with `appsec_` for consistency?" + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in `pkg/trace` since it's used in both `trace.go` and `trace.go`.", + "reference": "nit: this should be down further with the other github imports" + }, + { + "prediction": "I think this should be `if ctypes.windll.kernel32.FreeConsole() != 0 or ctypes.windll.kernel32.GetConsoleMode() != 0:`", + "reference": "Why is this change necessary or related to the rest of the PR?" + }, + { + "prediction": "I think this should be ` - see: ` instead of ` - see: `", + "reference": "Hm, I wonder if the `see:` prefix is even necessary?" + }, + { + "prediction": "I'm not sure this is the best way to do this, but it's the only way I could get it to work.", + "reference": "This should be translated." + }, + { + "prediction": "I don't think you need to check for num_class here, since you are checking for \"boosting\" first.", + "reference": "I originally had this PR only changing the R package, but then ran into this error > Error: [LightGBM] [Fatal] Cannot change metric during training This is thrown even if you aren't actually CHANGING `metric`. I think the change here in `c_api` is closer to the desired behavior, only throwing an error if the parameter is being changed." + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "These changes are just to make cli_spec a little more readable for VS Code users, as there's a bug with the Ruby plugin's syntax highlighting when you use multi-line regex literals." + }, + { + "prediction": "I think we should use `controllerutils.GetHiveNamespace()` here instead of `GetHiveNamespace()` in `LoadSecretData`", + "reference": "Shouldn't the global pull secret by in the namespace of the hive-operator? It is part of the operand." + }, + { + "prediction": "I think this should be `sleep(2)` to give the consumer time to start up.", + "reference": "kinesis-mock applies KINESIS_LATENCY to RegisterStreamConsumer actions so I added a sleep here." + }, + { + "prediction": "I think we can remove the `LOG(ERROR)`.", + "reference": "Only V1 or V3 is return from `getMetaVersionFromKV`. So where do we call `updateMetaV2ToV3`?" + }, + { + "prediction": "I'm not sure if this is the right place to put this constraint.", + "reference": "I think that V0 is missing here, which will prevent plugins that haven't been converted to work." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should remove the `sitemap` from the `middleware` section of the config, since it doesn't seem to be doing anything.", + "reference": "Should we remove this?" + }, + { + "prediction": "I'm not sure if this is the right place for this, but it seems like it should be.", + "reference": "Put on top of the import." + }, + { + "prediction": "I think this should be `analytics` instead of `anatlysis`", + "reference": "See above, this shouldn't be added." + }, + { + "prediction": "This should be `ITEM_ANGUISH_ORNAMENT_KIT`.", + "reference": "This'll likely get fixed upstream, we should let them deal with it." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `libp2p/host.go`", + "reference": "Somehow, this field does not seems useful for the exposed package api, only for the tests. Would you consider having an unexported field in `hostFactory func(context.Context, ...libp2p.Option) (host.Host, error)` instead to be set only by a new helper function defined in export_test.go. This is just a suggestion, not a hard requirement for the PR approval." + }, + { + "prediction": "I'm not sure this is the best way to do this. I think it would be better to have a function that takes the time duration in milliseconds and returns the time in seconds since the epoch. Then you can call `goBackInTime` and `goForwardInTime` on the result of this function.", + "reference": "As a first argument to these function, please pass the date that should go forward/backward. Also please clarify what is \"n\" (possible values, unit) and what is timeDuration (possible values, unit, as from your code it seems to be \"day\", \"hours\", etc. but from your example it seems to be milliseconds)." + }, + { + "prediction": "I don't think you need to import `config` here. You can just use `config.conf[\"general\"][\"language\"]` directly.", + "reference": "Are you sure you really need this code here? that script will be certainly run in NVDA's main thread, and core would have already called setLanguage." + }, + { + "prediction": "I think this should be 10256 instead of 10255", + "reference": "why is this changed ?" + }, + { + "prediction": "I think this should say \"except to update the document's revision.\"", + "reference": "Should this be \"the new revision value\"?" + }, + { + "prediction": "I think this should be `Dette feltet m\u00e5akse n\u00e5r :other er :value.`", + "reference": "You have deleted :attribute" + }, + { + "prediction": "I don't think it's a good idea to add copyright notices to the source code.", + "reference": "The license header should be updated to the Apache one." + }, + { + "prediction": "I'm not sure this is the right place for this test. I would expect it to be in `IntegrationTests`, but I don't see it there.", + "reference": "@zacharycmontoya Is there any way to distinguish a `SocketHttpHandler` from another `HttpMessageHandler` request?" + }, + { + "prediction": "I'm not sure this is the right place to put this. I think it should go in `src/InstrBuilder.cpp` under the `instr_is_*` functions.", + "reference": "Not sure about this one -- did you check somehow?" + }, + { + "prediction": "Line is too long. [83/80]", + "reference": "Is there a good reason to keep this at the `pe_ver_win` name now that it's per-host?" + }, + { + "prediction": "I think it's better to use `getResources().getStringArray(R.array.nav_drawer_items_product, getResources().getStringArray(R.array.nav_drawer_items_product, getResources().getStringArray(R.array.nav_drawer_items_product, getResources().getStringArray(R.array.nav_drawer_items_product, getResources().getStringArray(R.array.nav_drawer_items_product, getResources().getStringArray(R.array.nav_drawer_items_product, getResources().getStringArray(R.array.nav_drawer_items_product, getResources().getStringArray(R.array.nav_drawer_items_product, getResources().getStringArray(R.array.nav_drawer_items_product, getResources().getStringArray(R.array.nav_drawer_items_product, getResources().getStringArray(R.array.nav_drawer_items_product, getResources().getStringArray(R.array.nav_drawer_items_product, getResources().getStringArray(R.array.nav_drawer_items_product, getResources().getStringArray(R.array.nav_drawer_items_product, getResources().getStringArray(R.array.nav_drawer_items_product, getResources().getStringArray(R.array.nav_drawer_items_product, getResources().getStringArray(R.array.nav_drawer_items_product, getResources().getStringArray(R.array.nav_drawer_items_product, getResources().getStringArray(R.array.nav_drawer_items_product, getResources().getStringArray(R.array.nav_drawer_items_product, getResources().getStringArray(R.array.nav_drawer_items_product, getResources().getStringArray(R.array.nav_drawer_items_product, getResources().getStringArray(R", + "reference": "Not in the order of display : Front, Ingredient, Nutrition here (which is the right thing), Actually displayed: Front, Nutrition, Ingredients" + }, + { + "prediction": "I think we can remove the `StartTime` field from the `StressInstance` struct as well.", + "reference": "Why delete `StartTime`? This `StartTime` was used to avoid the PID was reused." + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think it should be in the `after_failure` block, but I'm not sure if that's the right place to do it.", + "reference": "My concern here, is that if the dump_puppet_log also throws then we will lose the data about the teardown_exception." + }, + { + "prediction": "I'm not sure this is the right way to do this. The `daal_knn::Parameter` needs to be a `std::vector`, `std::vector`, or `std::vector` depending on the compiler.", + "reference": "Should it be `int64_t`?" + }, + { + "prediction": "I think this should be 1000 * 60 * 60 * 5 = 3000000.", + "reference": "is this value related to something ?" + }, + { + "prediction": "Shouldn't this be `(AddTxResult?,)`?", + "reference": "Add names to tuple elements ValueTask<(Keccak? Hash, AddTxResult? AddResult)>, should they both be nullable?" + }, + { + "prediction": "I think this should be `caseFormat.replaceAcronyms(namePiece)`", + "reference": "I think it might make more sense to do this in Name.upperCamel; it is the entry point for upper camel strings." + }, + { + "prediction": "I'm not sure this is the right fix. The problem is that `t` is an `ArrayType` and `s[0]` is an `ArrayType` as well. I think you need to do something like `type.ifArrayType(t -> s[0] = (ArrayType) t);`", + "reference": "Huh? The point is that a cast isn't necessary" + }, + { + "prediction": "I think we should rename this to `OPENEBS_API_SERVER_INSTALL_CRD` to be consistent with the `OPENEBS_IO_INSTALL_CRD` variable.", + "reference": "can we name it like `InstallV1Alpha1CRDs` ?" + }, + { + "prediction": "I think we can remove this.", + "reference": "I need something to match when creating selectorsyncsets so added this label." + }, + { + "prediction": "I'm not sure why this is here, but it seems like it should be in `spec_helper.rb`.", + "reference": "Isn't `nil` the default return value from an empty `rescue` clause? If that's correct, then we could just remove the `nil` line entirely as it doesn't serve a purpose." + }, + { + "prediction": "I think we should remove this snippet. It's not clear to me what this code is supposed to accomplish.", + "reference": "Simple Storage **Service**" + }, + { + "prediction": "Why do we need to do this? I think we can just do `r.idx.Sub(r.idx.Obsolete())` in `LoadIndex`.", + "reference": "Wouldn't that cause the obsolete indexes to be downloaded over and over again? After all these are still stored in the repository." + }, + { + "prediction": "Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.", + "reference": "We might want to move this logic to a Plain Old Ruby Object down the road. Not a blocker." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it's better to move it to the `updateToolbox` function.", + "reference": "move `this.toolbox_.position();` to just after line 1477. Context: the if statement on line 1472 checks whether this is a toolbox with categories, and if so it populates the toolbox. Positioning the toolbox is a reasonable followup to that, and means you don't need an extra if. You may also need to call `this.flyout_.position()` after line 1483, which is the equivalent for the non-category toolbox." + }, + { + "prediction": "Seems like this should be `if (peptideGroupDocNode != null && sequenceProteinsDict.TryGetValue(peptideDocNode.Peptide.Target.Sequence, out var sequenceProteins))`", + "reference": "Should the function above be .FirstOrDefault() instead? Otherwise, why check for null and tell ReSharper to ignore the fact that it can never be null?" + }, + { + "prediction": "`STATUS_MAP` is not a constant, it is defined in `job.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which is in `jobs.js` which", + "reference": "Let's not create new connection, but rather user `common.db` one" + }, + { + "prediction": "I'm not sure this is the best place to put this. I think it would be better to put it in the `ImageTag` class, since that's where all the image-related logic lives.", + "reference": "Can this use asset_path rather than defining an image_url helper?" + }, + { + "prediction": "This should be `const stubString = () => '';`", + "reference": "Hindley-Milner signatures don't use literal types. They explusively use types. It's deal with that" + }, + { + "prediction": "I think we should rename this to OFPolicyRuleGroup as it is not specific to OpenFlow.", + "reference": "Could we just extend PolicyRule with more fields? It was originally designed as the struct required by openflow client, nested structs seem not helping. And for the name of the fields, initialism should be uppercase, OFID and NPName doesn't look good, then maybe FlowID, PolicyName.." + }, + { + "prediction": "Please add a space after `json_last_error` and before `opcache_reset`.", + "reference": "I really dislike this alignment approach, as it makes identifying individual functions quite hard, but I kept consistent with the previous style. Since no sorting was evident, I pushed it to the end of the block. Meanwhile, is this supposed to be tested or meaningfully testable somehow?" + }, + { + "prediction": "I'm not sure this is the right place to update the state of the `ActiveExecution`. I think it should be in `handle_event`, right?", + "reference": "Could also consider modifying the ActiveExecution..." + }, + { + "prediction": "I think this should be `ValueError` instead of `ValueNotAsConst`.", + "reference": "Does it make sense to change that to a custom error instead of `ValueError`?" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to be the only way I could think of.", + "reference": "I guess this will need to change soon." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in the `http` package.", + "reference": "Restore this spacing - not sure why it has to be removed?" + }, + { + "prediction": "I don't think you need to define _POSIX_C_SOURCE here.", + "reference": "These defines cause issues in base.h leading to failing android builds. Locale independency is now set in multiple spots, in cmake and in base.h. The base.h uses feature test macros wrong. Feature test macros can be used to indicate that a feature should be made available. They do not guarantee that it is available. On the cmake side this is done by the check symbol macros (similar to what autoconf does). On the android side not. I would suggest removing this from base.h and define locale independent in gradle. It is available since android 21 I believe. Is there a way in gradle to set locale independent only if android api >= 21?" + }, + { + "prediction": "nit: `loopBody != getDst` can be simplified to `loopBody != getSrc`", + "reference": "Why not delete these codes?" + }, + { + "prediction": "I think this should be `if (FLAGS_meta_client_retry_times > 0 && !metaClient_->waitForMetadReady(FLAGS_meta_client_retry_times))`", + "reference": "If pull message failed after some reties, we should ensure the storaged exit, otherwise it has risk to loss data." + }, + { + "prediction": "I don't think this is needed, but it's a good habit to get into.", + "reference": "looks like you don't need to import first and count here anymore" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `engine/visibility.go`", + "reference": "FYI, visibility task processing is local only, meaning pushing something to local ES cluster / local archival endpoint" + }, + { + "prediction": "I don't think you need to import `DynamicPropertyFactory` as it is not used in this class.", + "reference": "This import can be removed." + }, + { + "prediction": "I think this should be `InvalidRegionError{Region: a.Region}`, and the error message should say something like \"region not allowed in ARN: fips-xxx or -fipsxxx\".", + "reference": "1. Nit: We can have a general helper to identify if a region is pseudo region. We might already have one somewhere. 2. Does any type of ARN support FIPS? If not, we may just move this check in arn package?" + }, + { + "prediction": "I think this stubber should be renamed to `LambdaStubber` as well.", + "reference": "is this phrase completed in a next line? Or forgot to add... what?" + }, + { + "prediction": "I think it would be better to move this to the `models` subdirectory and rename it to `mask_rcnn_resnet50_fpn_inception_v1_1x.py`", + "reference": "`('train', 5)` and `('train', 1)` are actually the same." + }, + { + "prediction": "I think we should use `float64` here.", + "reference": "Would it be too complicated to refactor `currLimit` to be an `int64`?" + }, + { + "prediction": "I think this should be `RSPEC_SKIP_IMPLEMENTATION` instead of `::RSpec::Core::Pending.instance_method(:skip)`.", + "reference": "Would it be more performant to just `include ::RSpec::Core::Pending` here? /cc @myronmarston" + }, + { + "prediction": "This is a bit of a nitpick, but I think it would be better to have the `ChaosStatus` field be a `map[string]interface{}` rather than a `map[string]int64` so that we don't have to do `fmt.Println(obj.GetChaosStatus().(map[string]interface{}))` in the tests.", + "reference": "Should be podiochaos?" + }, + { + "prediction": "I'm not sure if this is the best way to do this. I think it's better to use `codecs.getcodec` instead of `codecs.register` and `codecs.lookup`.", + "reference": "Is the `codecs.register(lambda name: None)` gracefully handled by codecs? The lambda is expected to return a tuple of functions (encoder, decoder, stream_reader, stream_writer) (or a CodecInfo object), according to the docs. I've only checked python's built-in help, though." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `MeterProviderBuilderSdk` class, since it's related to the `MeterProviderBuilder` class.", + "reference": "in this case, it could be either instrument name or the view name, which could be invalid. might be better if we can offer very specific message. (not blocking this, we can add this as a follow up,if needed)" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `switchTo` command, since that is the command that switches to a different window.", + "reference": "I'd rather just send the parameter twice than break encapsulation here. There's already precedence with webelement IDs" + }, + { + "prediction": "`cascade_rcnn_mask_rcnn_r50_fpn_20e_coco.py` should be renamed to `cascade_rcnn_mask_rcnn_r50_fpn_20e_coco_backbone.py`", + "reference": "You may put 'open-mmlab://res2net101_v1d_26w_4s' here. MMCV will be updated later." + }, + { + "prediction": "I think it would be better to have a constant for this, like `const PAGE_SPEED_REPORT_STRATEGIES = { mobile: STRATEGY_MOBILE, desktop: STRATEGY_DESKTOP };`", + "reference": "May be worth making this more specific, to avoid potential conflicts, maybe `pagespeedDashboardWidget`? Or `webVitalsDashboardWidget`?" + }, + { + "prediction": "I think we can remove the `Error` class altogether. We can just use the `Error` function here.", + "reference": "I guess this assignment is now redundant?" + }, + { + "prediction": "I think we can remove the `blockNum` variable and just use it in the `if err != nil` condition.", + "reference": "See above note re: blockNum synchronization." + }, + { + "prediction": "I think we should use `backoff` from `github.com/cenkalti/backoff/v3` instead of `backoff` from `github.com/spiffe/spire/pkg/agent/backoff`", + "reference": "wonder if we could avoid doing named imports if we type aliased `backoff.Backoff` in the `.../agent/common/backoff` package?" + }, + { + "prediction": "(style) line over 80 characters", + "reference": "Or maybe put into alphabetical order with the other #includes." + }, + { + "prediction": "I think this should be `ticker := time.NewTicker(1 * time.Second) defer ticker.Stop()`", + "reference": "This runs the entire duration of the program; this change is not needed." + }, + { + "prediction": "I think this should be `false`", + "reference": "I don't feel well about the `ALWAYS_UPDATE` option   sounds like a workaround. I can imagine that some of the plugins want to observe all options. Maybe, in that case, we can reuse the `CONFIG_KEYS` that would return an empty array for observing all settings and `false` for disabling observing at all? I just thinking aloud - Like `CONFIG_KEYS` sounds reasonable. We could support and maintain it in the future, even after implementing the \"observability\" to the MetaManager then `ALWAYS_UPDATE` ... I don't know :)" + }, + { + "prediction": "I think clang-format should be removed from this patch.", + "reference": "A \"tab difference\"? As in, there are tab characters somewhere? This disabling of clang-format for all the code here seems like overkill. Are you sure there's not some other solution? I don't really understand the problem though. Do you mean clang-format-diff?" + }, + { + "prediction": "I don't think you need to import * here.", + "reference": "Could you please leave the explicit imports?" + }, + { + "prediction": "I don't think this is the right way to do it. You need to check if `methodConfigMap.get(methodConfigProto.getName())` is not null before adding it to the list. If it is not null, then you can add it to the list. If it is null, then you can skip it.", + "reference": "Can we check for containsKey here?" + }, + { + "prediction": "I think it would be better to use `fmt.Printf` here, rather than `fmt.Fprintln`.", + "reference": "Exit successfully. We served the help the user wanted." + }, + { + "prediction": "I think this should be `InitialWorkingDirPath` and `InitialPackagePath` should be `InitialWorkingDirPath` and `InitialPackagePath` should be `InitialWorkingDirPath`.", + "reference": "Had to rename this because `InitialPackage()` already existed." + }, + { + "prediction": "Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", + "reference": "Can we put this in a different helper?" + }, + { + "prediction": "I'm not sure this is correct. It seems to me that if the number of slots is 8-byte aligned, then the dstack_offs should be 8-byte aligned as well.", + "reference": "I'm not sure where your 31 comes from? I see 15 here and 2 above for pc and flags, for 17 total beyond the SIMD." + }, + { + "prediction": "I don't think this is needed.", + "reference": "If you want, you could change this to `allowCors(response` (like in \"version\", above) to allow Cross-Origin Resource Sharing. I'm sort of wondering what's returned if no API terms of use are set." + }, + { + "prediction": "I don't think this is needed. The `onConfigurationChanged` method is only called when the user switches between portrait and landscape mode. In this case, the screen is already in portrait mode, so there's no need to call `super.onConfigurationChanged(newConfig)` again.", + "reference": "Why do we need to override this if all we're doing is passing it up?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it's better to do it in the control plane.", + "reference": "Just wondering whether it's safe to send all CQDs to the child compiler. As this missing CQD is causing trouble, maybe some other user CQDs that now get sent could also cause the statement to fail? Also, if I have a table with a nullable unique column, should I have to set this CQD to create another table like it, or should the CREATE TABLE LIKE work without the CQD?" + }, + { + "prediction": "I think this should be `DAGSTER_EARLIEST_RELEASE` and not `DAGSTER_FROM_SOURCE`", + "reference": "EARLIEST_TESTED_RELEASE might be slightly more clear" + }, + { + "prediction": "I'm not sure this is the best way to do it, but it's the only way I could find that worked.", + "reference": "I think replacing `.*` with `\\s*` from after the hash makes sense, but not the rest of the changes." + }, + { + "prediction": "I think we should rename this to `EnableLoggingEnabled` or `EnableLoggingFlag` to make it clear that this is a flag.", + "reference": "interesting .. did not know varint tag covered bool as well" + }, + { + "prediction": "I think this should be `uint64_t` instead of `H2O_VECTOR(uint64_t)`", + "reference": "Could you please elaborate the reason for not using `gkc_summary` like the values above? I ask this, because I assume what we want to collect is a histogram of event loop latency, and we use `gkc_summary` for collecting histograms." + }, + { + "prediction": "I think this is the only place where `getTxHashes` is called with an object instead of an instance.", + "reference": "getHash should be a public and without an `_` if used here." + }, + { + "prediction": "I think this should be `uint64(blk.Header().Number.Uint64()) > uint64(now)`", + "reference": "Unrelated to these changes -- we will probably want some special handling for genesis block validation." + }, + { + "prediction": "I think this interface is not needed. We don't need to set the disk block cache fraction in the disk block cache setter. The disk block cache setter will set the disk block cache fraction based on the disk block cache size and the number of blocks in the cache. The disk block cache size is determined by the number of blocks in the cache and the cache block size. The number of blocks in the cache is determined by the number of blocks in the cache and the cache block size. The cache block size is determined by the number of blocks in the cache and the cache block size. The cache block size is determined by the number of blocks in the cache and the cache block size. The cache block size is determined by the number of blocks in the cache and the cache block size. The cache block size is determined by the number of blocks in the cache and the cache block size. The cache block size is determined by the number of blocks in the cache and the cache block size. The cache block size is determined by the number of blocks in the cache and the cache block size. The cache block size is determined by the number of blocks in the cache and the cache block size. The cache block size is determined by the number of blocks in the cache and the cache block", + "reference": "This is probably overkill since we don't actually need to pass this specific interface anywhere, but I don't mind it!" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in `d.p2pService.Peers()`", + "reference": "@janos I moved this back here, to avoid having multiple add peer calls being handled. I think it's either this or a global lock across the whole function. I think this is a better approach, especially since `hive.Broadcast` is blocking . We can remove the map entry on errors if needed. LMKWYT?" + }, + { + "prediction": "I'm not sure if this is the best way to check for this, but it's the only way I could get it to work.", + "reference": "Minor: can we put the conditional outside of the partial?" + }, + { + "prediction": "I'm not sure this is the best way to do this, but it's the only way I could come up with that worked.", + "reference": "We need to find something more efficient than this. We can probably just check the first element and assume the type list is consistent.." + }, + { + "prediction": "I think this should be `A %s is a job which can be programmatically run, either on a schedule or via service code in response to events.`, right?", + "reference": "How \" via service code in response to event.\"? I don't think we'll get in the no schedule option to the release. We should probably wait for some customer feedback first to make sure we're addressing different event-triggers the best way" + }, + { + "prediction": "Please remove this empty line.", + "reference": "Please move unrelated formatting changes to their own PR (same with the resources.py file)." + }, + { + "prediction": "I'm not sure this is the right way to do it. I think we need to check the state of the `window._state_before_fullscreen` and only show the normal window state if it's not focused.", + "reference": "Make this a public attribute (remove the leading `_`) if you want to access it from the outside." + }, + { + "prediction": "I think this should be `if (layoutManager) {`", + "reference": "this conditional is useless now so it should be removed" + }, + { + "prediction": "I think this should be `static_cast(i) + 1` instead of `static_cast(i+1)`.", + "reference": "`vecofstructs->size()` already returns a `uoffset_t`. So if you just change the type of `i`, you don't need any casts." + }, + { + "prediction": "I don't think we should expose a command-line option for toggling proto annotations parsing. It's not something that should be configurable by the user.", + "reference": "Nit: Maybe merge this with the configProto check on line 208? Don't feel that strongly though, please keep separate if you prefer." + }, + { + "prediction": "I think this should be `if (doc.ismaster || doc.hello) {` instead of `if (doc.ismaster || doc.hello) {`", + "reference": "I know we already did this in 4.0 so carry on, but I'm facepalming here we should've made an overrided setMessageHandler that sets ismaster to true when hello is present. Esp in 4.0 where we already have some overrides written. We can keep going here and maybe open a ticket to some effect of that solution" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I could come up with that works.", + "reference": "I believe we could use `link_to` here (although not super important). Also, we should internationalize this value. I'm not 100% sure what our process is for adding new UI strings these days (e.g. skip the specs that will fail if we add a new key to only one language, use Google Translate to translate the value for us, some other option)." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `GetPhysicalDeviceDisplayPropertiesKHR` function, since that is the place where `pProperties` is initialized.", + "reference": "This was already in vkGetPhysicalDeviceDisplayProperties2KHR..." + }, + { + "prediction": "I think we can remove this interface since we don't use it anywhere.", + "reference": "nit: I'd expect a public method called IsDockerEngineRunning to return a boolean yes/no, not the error message. Can we change either the return value or the name? Something like `CallDockerEngine`" + }, + { + "prediction": "I'm not sure about this change. I think it's fine for now, but I'm not sure we'll be able to support all dialects in the future.", + "reference": "If i remembered correctly, type_name is '{RESOURCE_TYPE}/{RESOURCE_NAME}', if type_name is 700 max then name cannot exceed that size" + }, + { + "prediction": "I'm not sure this is the right place for this function. It seems like it should be in the same namespace as the other file_identifier functions, but I can't find where it is used.", + "reference": "When calling functions with keyword arguments: please provide the arguments as keyword arguments, not positional arguments." + }, + { + "prediction": "`None` is not a valid choice for `act_cfg` and `norm_cfg`.", + "reference": "We may follow the argument order: conv_cfg, norm_cfg, act_cfg." + }, + { + "prediction": "I'm not sure this is the best way to do this, but I don't have a better idea. It seems like we should be able to do something like `@capabilities[:chrome_options] = { user_data_dir: \"#{profile_json[:directory]}\", extensions: profile_json[:extensions] }`", + "reference": "`options['binary'] = WebDriver::Chrome.path` if set?" + }, + { + "prediction": "Is there a reason to not include `folly/ssl/Init.h`?", + "reference": "folly library should be put on the top." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I could come up with.", + "reference": "Do we have to restrict this to SVG elements? I think setting namespaced attributes on normal dom elements (while not as common) is still valid, so perhaps we can save some bytes by removing the `isSvg` check?" + }, + { + "prediction": "I think this should be `this.hot.hasHook('hiddenRow') && this.hot.runHooks('hiddenRow', row);`", + "reference": "Please add it to the `REMOVED_HOOKS` constant." + }, + { + "prediction": "nit: can you move this to the top of the file?", + "reference": "This variable needs `.v1` at the end of it, or the tests below need it. There are some test failures as a result" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `Account::Access` class, since it's only used by that class.", + "reference": "Is this access protected so that only admins can access this route?" + }, + { + "prediction": "This should be `0.0f` instead of `DBL_MAX`.", + "reference": "What happens if the minimum x coord is > 0? This will incorrectly set it as zero, right?" + }, + { + "prediction": "I think we can remove the `if o.maxp > 0 && batchSize > o.maxp` check here, since it's already covered by the `if batchSize > o.maxp` check above.", + "reference": "I think you want to look at current pending + batchSize and if that is > o.maxp no?" + }, + { + "prediction": "I think this should be `\"\"` instead of `\"internal\"`?", + "reference": "Should this be `codes.Error`? `codes.Internal` was an error status before." + }, + { + "prediction": "Align the elements of a hash literal if they span more than one line.", + "reference": "I don't think you need these lines." + }, + { + "prediction": "I'm not sure this is the best name for this. It's not a limiter, it's just a limiter of the number of blocks that can be written to the disk at the same time.", + "reference": "You didn't mean to export this, right?" + }, + { + "prediction": "I'm not sure if this is a good idea. The AWS SDK for JavaScript (v3) doesn't support Ruby, so we can't use it in this example. The AWS SDK for Ruby doesn't support Amazon SNS either, so we can't use it in this example either.", + "reference": "Simple Notification **Service** (singular)" + }, + { + "prediction": "I think we should rename this to `egressNetworkConfig` to be consistent with `egressConfig`.", + "reference": "Do we still need this?" + }, + { + "prediction": "I think this should be `LOG.error(\"Failed to create private marker transaction: {}\", privateMarkerTransaction.getHash());`", + "reference": "We do have a disconnect between the privateMarkerTransactionFactory.getSender() call and the createPrivateMarkerTransaction() call. When the plugin receives the call to create the PMT it does not know what the sender was returned by the other call. At a minimum we need to pass in the sender to the second call. I would prefer that the plugin does the locking if that is necessary. If you are using random keys you don't have to lock! Besu could signal to the plugin when a PMT was un- or successfully added to the pool using a callback. Callback could be null if this is not needed. The plugin would have to be able to get the nonce for a certain key from besu. What do you think?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `components/alert.js`", + "reference": "This is a bit inconsistent with the `ErrorStartHourGreaterThanEnd` in the previous file. Wouldn't `ErrorDefault``fit better here?" + }, + { + "prediction": "I think it would be better to move this to `skipIfNetworkPolicyStatsDisabled`", + "reference": "I think it will revert the change @antoninbas did on purpose 05eee251c9c53400277def576f92d614ca234898" + }, + { + "prediction": "I think this should be `ifaceName == \"tunl0\" || ifaceName == \"wireguard.cali\"` instead of `ifaceName == \"tunl0\" || ifaceName == \"wireguard.cali\"`", + "reference": "nit: a switch perhaps?" + }, + { + "prediction": "I think this should be `application_name` instead of `application_name`", + "reference": "Would it make sense for `opensearch_description_tag` to have default values for the title and href attributes?" + }, + { + "prediction": "I'm not sure this is the right place to check for the journal being disabled. I think it should be in `getRangeFromJournal` instead.", + "reference": "Just noticed this while debugging -- it's unlikely to be causing issues in practice." + }, + { + "prediction": "I'm not sure if this is the best timeout value to use here, but I think it's fine.", + "reference": "That seems unrelated - did that fix a random test failure you noticed while working on this issue?" + }, + { + "prediction": "I think we can remove the `base` parameter from `doCommit` as well.", + "reference": "This kind of concern should be handled in the `TableMetadata` update methods. This is similar to `metadata.rollbackTo`, which not only sets the current version, but also updates the table history. I think that all of those methods should add the current object's `file.location()` to the previous metadata location list, if it is non-null. That way, the caller never needs to remember to update it." + }, + { + "prediction": "`mlvl_tensors` should be a list or tuple of tensors.", + "reference": "We need to know why all the tensors are detached in `get_bboxed`." + }, + { + "prediction": "I don't think this is a regression.", + "reference": "Unrelated but shouldn't this raise `attribute-defined-outside-init`?" + }, + { + "prediction": "I think this should be `create_no_window=True`", + "reference": "I would rather no have this as a `kwarg` as it encourages \"growth\" which lead to an unweildy constructor in other classes. Let's add a method or property to take care of this instead as I think it's usage is going to be quite low." + }, + { + "prediction": "I think this should be `plan&.sections.sum { |s| s.num_answered_questions }` instead of `plan&.num_answered_questions.to_i`", + "reference": "You just changed my life :) I grew very attached to this safe nav approach when working with Groovy years ago `obj?.method`. Glad to see its now a part of Ruby!" + }, + { + "prediction": "I'm not sure if this solves the issue, but I think it's a good idea to remove the `clear-fix` class.", + "reference": "do you mean 'clearfix' class?" + }, + { + "prediction": "I don't think we should have a `causalConsistency` option here. It's not something that should be configurable by the client.", + "reference": "`causalConsistency` is already defined on `SessionOptions`. We do not need to duplicate it here." + }, + { + "prediction": "Why is this change needed?", + "reference": "This should not be included since there are no code changes." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it's the only thing I could come up with.", + "reference": "If all we need just response 200, then we could use `c.Status(http.StatusOK)` here." + }, + { + "prediction": "I think we should be able to just do `client.Get(ctx, model.ResourceKey{Kind: apiv2.KindNode, Name: hostname, Namespace: \"\"}, nil)`", + "reference": "Should be checking for error here" + }, + { + "prediction": "Why do you need this?", + "reference": "Put a space between `(array)` and `$this` and I'll merge it" + }, + { + "prediction": "I think this should be `func Stack(buf []byte, all bool) ([]byte, error)`", + "reference": "You could add this to stack.go, which has similar functions (to avoid yet another small file). None of these are likely to be implemented considering what TinyGo is designed for." + }, + { + "prediction": "I think this class should be called `NotificationContentHolder` instead of `NotificationHolder`.", + "reference": "the class names `NotificationHolder` and `NotificationsHolder` are fairly difficult to quickly tell apart, particularly since they are often used close to each other" + }, + { + "prediction": "This import is not needed anymore.", + "reference": "Avoid wildcard imports" + }, + { + "prediction": "I think this should be `[]*Candidate`", + "reference": "Need to do this to unblock mockgen. The interface method needs to be public to be visible in another package. The right fix is to delete this test only interface method" + }, + { + "prediction": "I think this should be `loadbalanced` instead of `loadbalancer`", + "reference": "same question here as I have on the other file regarding doing this check here vs L112 vs not at all" + }, + { + "prediction": "Why is this needed?", + "reference": "Adding `// +build !windows` (as a separate line) will do the same for Windows. So while you are at it we might add it as well." + }, + { + "prediction": "I'm not sure why this was removed.", + "reference": "this is used as important way of mocking for unit tests, FYI" + }, + { + "prediction": "I don't think we need to set the alpha here, since it's the same as `muted_alpha` in `options.Histogram`.", + "reference": "Sorry, should have been clearer, I meant adding this to the ``Histogram`` options one line above." + }, + { + "prediction": "I think this should be `C23NHe2` instead of `C23NHx2`", + "reference": "Just ignorance on my part, but what is the significance of the change from C23NHe2 to C23NHx2?" + }, + { + "prediction": "Can you add a docstring for this new parameter?", + "reference": "What about tuples or pandas series? Do we want to support lots of different types or force a single type?" + }, + { + "prediction": "Why is this removed?", + "reference": "Small thing, without the check above this will throw a NoNodeException if the path doesn't exist. Maybe this can be wrapped in a try/catch just for the NoNodeException, so that the more user-friendly message used above can be thrown instead: `throw new KeeperException.NoNodeException(\"No collection found at path: \" + path);` Just a thought, I'm not even sure it's worth it." + }, + { + "prediction": "Metrics/LineLength: Line is too long. [122/120]", + "reference": "I don't know why this worked before, but we should be explicit on not verifying that a blank string (allowed as a way to remove a url/download_url) is a valid url as it is not." + }, + { + "prediction": "I think we can remove the `support will be removed in Bolt 3.0.` part of the deprecation message.", + "reference": "Do we want to raise an error here instead of warning? Or would it be better to just see if Bolt happens to succeed, and let it fail on it's own if it fails? I'd lean towards raising an error, but that's different from \"removing support\"." + }, + { + "prediction": "I'm not sure if this is the right place to put this method. I think it would be better to put it in the `Bolt::Transport::HTTP` class, since that's where the `options` and `filter_options` methods are defined.", + "reference": "This is kind of confusing with the other `filter_options`." + }, + { + "prediction": "I'm not sure if this is the right place to fix this. I think it should be fixed in the `OpsCantHandleFavorite` case, since that's where the error is thrown.", + "reference": "Could the `deleteFromFavorites` happen when `head == nil` because it's not initialized yet somehow but not because TLF doesn't exist? I was concerned if this would make it possible in any way to have favorites seemingly deleted on a device while it's not actually happened on server." + }, + { + "prediction": "Why not use `std::numeric_limits::max()`?", + "reference": "It doesn't look like this particular \"rowCount\" variable is used anywhere. I suppose we could delete it. The code change is harmless though." + }, + { + "prediction": "Shouldn't this be `w.WriteHeader(http.StatusNoContent)`?", + "reference": "Hmm, probably we should instead write whatever `status` is returned instead of coding a special case." + }, + { + "prediction": "I think this is the only place where we need to set the `HttpMatch` field.", + "reference": "Could using the pointer-to-struct approach here cause confusion later? We've had several problems of that kind in the past. What does it mean if the struct is non-nil but its fields are nil? Is that even allowed? (libcalico-go question) Are there any validation requirements for this new rule addition; should it only be allowed if `Protocol == TCP`, for example?" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.", + "reference": "why this recursive relationship definition?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `Handlers` struct, since that's where the `HandlerSpec` lives.", + "reference": "More sentence, less list please. > Encoding of the handler. This field is optional. We don't need to mention exactly what it's used for because that list can expand (as it has already in this change)." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `gocloud.dev/metrics` or `gocloud.dev/trace` or `gocloud.dev/samples`.", + "reference": "Not part of this PR, but should the section above say what the name of the metric is for each method?" + }, + { + "prediction": "I'm not sure how I feel about this, but I don't think this is the right place for this. I think it should go in the `DoubleGaugeMetric` and `LongGaugeMetric` classes, since they're specific to gauge metrics.", + "reference": "there are changes that are upcoming to this section. For now, this works (to demo the usage of Gauge), and the changes to this section are coming as separate PRs." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `Terminal` struct itself, not in the `Terminal`/`TerminalUI` interface.", + "reference": "This is equivalent to stdout. Why not just replace stdin with stdout in `IsProcessBackground`?" + }, + { + "prediction": "I'm not sure if this is the right place to add the `compress_method` to the man pages. I think it should be in the `zlib` and `deflate` man pages, since those are the ones used by the zlib and zlibdeflate libraries.", + "reference": "Rather than test for nullptr, just treat the pointer as a bool, i.e. `if(p_jmsg[\"compress_method\"])`" + }, + { + "prediction": "Shouldn't this check be done in `createShortcut`?", + "reference": "Can we move the remaining code of this method to a new method? I don't like the `return;` here, we could try to replace it with an `if ... else ...` syntax. What do you think?" + }, + { + "prediction": "I don't think we need to include this capability in the API.", + "reference": "nitpick: _and collections_" + }, + { + "prediction": "I don't think this is needed. The timer is already set up in the `rp_generator_t` struct.", + "reference": "I believe these need to be explicitly initialized in `proxy_send_prepare`" + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in the `run()` method, since that's where the actual work is being done.", + "reference": "This is unnecessary. The declaration of `t0` on line 179 is still in scope inside the `except` block." + }, + { + "prediction": "I don't think this is the right place for this property. It should be in the `request` class.", + "reference": "The `border_color_`... properties don't support solid colors, not only this one. Maybe `@param solid_color` should be used instead of adding this note to every one of them?" + }, + { + "prediction": "I think it would be good to have a test for this file.", + "reference": "We don't need this file, we can use the one that is in the grid-ui directory" + }, + { + "prediction": "I'm not sure this is the right place to check for an empty line. I think it would be better to check if the line is empty using `isEmpty()`.", + "reference": "FYI: inlined this method in the internal review." + }, + { + "prediction": "Why is this change needed?", + "reference": "Werid, the checksum between this file and the one on branch `develop` is the same not sure why it's showing a diff" + }, + { + "prediction": "I think this should be `metric.Meter.Name + \".\" + metric.Name` instead of `metric.Meter.Name + metric.Name`", + "reference": "Prometheus doesn't have concept of Meter (like OTLP does).. Trying to see if this is a good approach to use the meter name as namespace, to avoid name collisions, when same instrument name is used across multiple instruments, from different Meter." + }, + { + "prediction": "Shouldn't this be `&& !$this->getAuthManager()->getAuthMethod() == 'Shibboleth'`?", + "reference": "The formatting of this is a bit strange; I'd suggest collapsing this back to a single line, and moving the `&&` to the beginning of the second line to meet the line length restriction." + }, + { + "prediction": "I think this should be `else if (segments != NULL)`. The `else` should only happen when `else if (segments != NULL)` is true.", + "reference": "One or the other should be non-NULL. If segments is NULL, the alloc above will have size zero, which we do not allow (there's no header): it should assert in debug build. So there should be asserts that one is non-NULL at the top, and if there really needs to be some kind of defensive check down here, it should cover the alloc too." + }, + { + "prediction": "I think this should be `user.update!(first_name: user_data['first_name'], last_name: user_data['last_name'])` instead of `user.update_attributes(first_name: user_data['first_name'], last_name: user_data['last_name'])`", + "reference": "I'm surprised rubocop isn't picking up singe quotes?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `pkg/version.go`", + "reference": "Is this line still needed?" + }, + { + "prediction": "I'm not sure if this is correct. If the initial heartbeat period is set to 0, then the initial heartbeats will never be sent. If the initial heartbeat period is set to 1, then the initial heartbeats will be sent every 1 second. If the initial heartbeat period is set to 10 seconds, then the initial heartbeats will be sent every 10 seconds.", + "reference": "Maybe use specific values for all the watt.times fields? Even better, have a const for it at the top of the file?" + }, + { + "prediction": "I think this should be `tables = [PATTERNS_TABLE]`", + "reference": "nit: UNICODE_BRAILLE_TABLE or something might be a better name for this. IMO, braille-patterns.cti is a terrible name. This table allows Unicode braille characters to be used anywhere to produce raw dots." + }, + { + "prediction": "Why is this removed?", + "reference": "Why are we removing the option to skip machine pool generation?" + }, + { + "prediction": "I think this should be `IHttpHeadersStartLineHandler` instead of `IHttpStartLineHandler`", + "reference": "\"Request line\" here too." + }, + { + "prediction": "This should be `if (entity_list.GetTypeID(ZONE_CONTROLLER))` instead of `if (entity_list.GetNPCByNPCTypeID(ZONE_CONTROLLER))`", + "reference": "Please remove this." + }, + { + "prediction": "Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.", + "reference": "Weird bug. Combining those joins and group calls was triggering AREL to generate the sql cache inside of will_paginate before the final call. This is a harmless workaround, but hints that will_paginate might becoming seriously deprecated." + }, + { + "prediction": "Metrics/LineLength: Line is too long. [121/120]", + "reference": "This can be simplified as discussed before." + }, + { + "prediction": "This is a bit of a hack, but I think it's the only way to make this work. The `table` argument to `NewProcessChunkMsg` is a copy of the `table` argument to `NewProcessMsg`. Since `NewProcessChunkMsg` is a copy of `NewProcessMsg`, `NewProcessChunkMsg`'s `table` will be a copy of `table`, and so `NewProcessChunkMsg`'s `table` will be a copy of `table`, and so on and so forth.", + "reference": "Does `internal` or `test` in the file name actually do anything here? Or is that just to show these functions are only for tests?" + }, + { + "prediction": "I think we should remove the `true` argument here.", + "reference": "does this boolean indicate unsafe serialization?" + }, + { + "prediction": "I think this should be `static copyBundledRealmFilesToAppDefaultFolder()`.", + "reference": "Maybe rewrite to `Is only implemented for React Native`? (I assume that is the case)." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `ProtoPageStreamingTransformer` class, since that's where the paging logic is.", + "reference": "Do we not need this in Java because Java *is* handling map responses?" + }, + { + "prediction": "I think this should be `False` by default, and `True` when you want to receive all messages.", + "reference": "Maybe \"For configuring which scheduler messages can be received.\"?" + }, + { + "prediction": "I think this should be `getEntityManager` instead of `getObjectManager`", + "reference": "It will stop working with orm, so this is not a good fix, Try using some method in a common interface" + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in the `HttpHandlerDiagnosticListener` class, since that's where the `HttpHandler` is defined.", + "reference": "`s` is not necessarily the same as `sampler` - sampler could be null and this crazy lambda underneath falls back to something. So please use `s`" + }, + { + "prediction": "Why do we need to set it to `null` here?", + "reference": "This code is a bit confusing. Should HttpParameterType set to the original one or it is always BODY?" + }, + { + "prediction": "I'm not sure this is the right place for this check. I think it should be in the `VerifyOutputs` function.", + "reference": "Why did this change?" + }, + { + "prediction": "I think it would be better to move this to the `DescribeTable` function, since it's only used in that function.", + "reference": "nit: `status` collides with imported package named `status`" + }, + { + "prediction": "I think this should be `l.accts.txLease` instead of `l.accts.IsWritingCatchpointFile`", + "reference": "\"memory pressure could be decreased\" --> \"to avoid memory pressure\"" + }, + { + "prediction": "I think this test should be moved to `test_store.py`", + "reference": "I think it would make sense to fetch the cache values after deleting the listens and making sure they are what we expect." + }, + { + "prediction": "I think we can remove the `mapState` call here since it's not used anymore.", + "reference": "I'm thinking about covering this change with the test. Can you do that?" + }, + { + "prediction": "I think this should be a `*net.UDPConn` instead of a `*net.UDPConn` pointer.", + "reference": "Not sure if it's a good idea to remove stop channel. If user cancels connection how will you stop pinger?" + }, + { + "prediction": "I think this should be `sdkAuthConfig.User` and `sdkAuthConfig.Password` and `sdkAuthConfig.Email` and `sdkAuthConfig.ServerAddress` and not `authData.Username`, `authData.Password` and `authData.Email` and `authData.ServerAddress`", + "reference": "Could you please add a `TODO` here that we won't need `docker.AuthConfiguration` anymore when we migrate to SDK's pull image?" + }, + { + "prediction": "I think this should be `BlobNames` and not `BlobNames`", + "reference": "Is there a scenario were we want to get an arbitrary set of blobs that don't share a common root?" + }, + { + "prediction": "I'm not sure if this is the right way to do it. I think we need to make sure that we don't generate the topology for any spec that doesn't match `type=regex`.", + "reference": "Can you leave a note about why we are skipping regex tests?" + }, + { + "prediction": "I think this should be `if err != nil { return err }`", + "reference": "This was the only caller of CreateRepo, so I inlined it." + }, + { + "prediction": "I think this should be `AuthPath string ` instead of `AuthPath string `json:\"authPath,omitempty\"`", + "reference": "As this is already a child of `auth`, I think we can shorten this to `path`" + }, + { + "prediction": "I think this should be `elif position in (textInfos.POSITION_FIRSTVISIBLE, textInfos.POSITION_LASTVISIBLE, textInfos.POSITION_ALL):`", + "reference": "This call should use element, not 0 I think." + }, + { + "prediction": "I think this should be `FetchUntilEmptyPageThreshold` to match the rest of the config.", + "reference": "This is missing the definition of `fetch_until_empty_page` - it needs to go in the config section above." + }, + { + "prediction": "Line is too long. [82/80]", + "reference": "I don't think this one needs to be changed since the only previous path is already an absolute one." + }, + { + "prediction": "I think this should be `locationProvider` instead of `this.table.locationProvider()`.", + "reference": "Since we kept the original constructor we might not need this change now." + }, + { + "prediction": "nit: remove the extra space after \"Refreshed\"", + "reference": "There is already a log in `BaseMetastoreTableOperations` for this. It has the location, but not the table name. Maybe just add table name to that one." + }, + { + "prediction": "I think we should move this import to the top of the file.", + "reference": "This should be in the last group." + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in the `try` block above, right?", + "reference": "I believe you should either remove this or rename the PR. You can't change the behavior of the tracer (even to fix a bug) in a PR named \"unit test improvements\"" + }, + { + "prediction": "I think this should be `cert-manager.k8s.io` instead of `certmanager.k8s.io`", + "reference": "I've gone with this group name, however I'm open to suggestions on alternatives!" + }, + { + "prediction": "I think it would be better to have a `QuorumApi` and a `RpcApi` for the quorum api.", + "reference": "should this be GOQUORUM" + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think it should be in the validator, but I'm not sure if there is a better place to do it.", + "reference": "I think checkCoinbase is not skipping checking coinbase. Instead, true-> checking num(coinbase tx) = 1, false -> checking num(coinbase tx) = 0." + }, + { + "prediction": "Why is this needed?", + "reference": "same here, move it out" + }, + { + "prediction": "I think this should be `#if defined(KOKKOS_ENABLE_LIBDL || defined(KOKKOS_TOOLS_INDEPENDENT_BUILD)`", + "reference": "Can you elaborate on why you need different behavior depending on Tools being built independently or not?" + }, + { + "prediction": "Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.", + "reference": "because of the above if statement will requires both ex_save and guid_save to be true, this code will always return 'example answer'. This should be revised with `example_answer.present?` and `guidance.present?`" + }, + { + "prediction": "I think we should use `context` from `golang.org/x/net/context` instead of `structs` from `github.com/stretchr/testify/assert`.", + "reference": "why not context from stdlib?" + }, + { + "prediction": "I'm not sure this is the right place for this. It's not binary, it's a Thrift type.", + "reference": "Just saw this and wasn't able to hold myself from renaming :-)." + }, + { + "prediction": "I'm not sure if this is the right place for this test. I think it would be better to move it to `src/amp-ad/amp-ad-network-adsense/amp-ad-network-adsense.js`", + "reference": "Can we keep the other assertion too? I think it's helpful to ensure that the uninstall function was called too" + }, + { + "prediction": "I'm not sure if this is the best way to handle this, but it's the only way I could come up with that didn't involve a ton of boilerplate.", + "reference": "`warn_with` prefixes the message with `WARNING:`, right? So this will put `WARNING:` twice. It would be good to verify all the warnings look good after this change, given how easy it is to make a simple mistake like this :(." + }, + { + "prediction": "Why not just use `types.BlockTimer`?", + "reference": "FYI In the message queue I use the term \"stamp\" to refer to the time-like mark associated with each message. It's opaque to the queue/pool and should make no difference if the stamps and age limit were converted to seconds. So this could then become `Stamper` with `CurrentStamp()` method, no reference to \"blocks\" or height etc. The wrapper struct could be `StampedMessage. The interpretation as block height is deferred to the user/constructor that hooks things up, the \"business logic\". This is just an observation, take or ignore as you wish." + }, + { + "prediction": "I think this should be `exists, code, body = is_bucket_available(bucket_name)[0]` instead of `exists, code, body = is_bucket_available(bucket_name)`", + "reference": "Can we remove the `TODO` statement here? (as this is actually fixed in this PR)" + }, + { + "prediction": "I think this should be `private final DisplayPreference mDisplayPreference;`", + "reference": "m prefix no longer in code style" + }, + { + "prediction": "I think we can remove this now.", + "reference": "need to filter the entities in buffer as well" + }, + { + "prediction": "I think this should be `public static final String ID = \"de.danoeh.antennapod.core.glide.FastBlurTransformation\";`", + "reference": "Please add spaces before and after the equals sign" + }, + { + "prediction": "Please remove this file.", + "reference": "This file could also be cleaned up/deleted. But lets do this separately after ensuring all the event logging has been ported to the current logmxevent_traf.cpp file completely." + }, + { + "prediction": "I'm not sure if this is a good or a bad thing. I think it's a good thing, but I don't know if it's a good or a bad thing to have a newline at the end of the file. I think it's a good thing to have a newline at the end of the file, but I don't know if it's a good or a bad thing to have a newline at the end of the file. I also don't know if it's a good thing to have a newline at the end of the file. I think it's a good thing to have a newline at the end of the file, but I don't know if it's a good or a bad thing to have a newline at the end of the file. I also don't know if it's a good thing to have a newline at the end of the file. I think it's a good thing to have a newline at the end of the file, but I don't know if it's a good or a bad thing to have a newline at the end of the file. I also don't know if it's a good thing to have a newline at the end of the file. I think it's a good thing to have a newline at the end", + "reference": ":thinking:, the line number here is the line of the example (`example.location`), that's probably why I finally chose to display the example title because it's what can be found on this line, and saying that the error is from there is confusing. But presenting the actual failures is indeed better, so maybe we can get the failure actual line number from the exception backtrace and then output two distinct lines for failures like this one?" + }, + { + "prediction": "I think this should be `chrome_options=None, service=create_no_window=False, keep_alive=True`", + "reference": "We shouldn't add this as a new `kwarg` here. This should all be done on the options class" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Should this be `OS_VOLUME_SUPPORT` to match the symbol key names?" + }, + { + "prediction": "I think this should be `static flux_msg_handler_t *handlers[] = { ... };`", + "reference": "In C, file scope variables are already initialized to 0 so the \"= NULL\" is redundant. Not a big deal." + }, + { + "prediction": "I think this should be `axer.commons.doc.getRootNode(node);`", + "reference": "on line 40, the `relevantNode` can change and therefore the `doc` might change too for the lookup on line 43. I think this code should be moved to where the `doc` is actually being used" + }, + { + "prediction": "I think this should be `throw new ArgumentOutOfRangeException(nameof(milliseconds), milliseconds, string.Format(CultureInfo.InvariantCulture, \"milliseconds must be between {0} and {1}\", MinMilliseconds, MaxMilliseconds));`", + "reference": "nit: just to be similar to others, can you change to interpolation?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `pkg/apis/core/internalclientset/versioned/typed/authorization.k8s.io/v1beta1/internalclientset/versioned/typed/authorization.k8s.io/v1/internalversion`", + "reference": "Would this make more sense as an option on an Issuer resource (specifically on the CA issuer) rather than as a flag? It's not ideal that we have a flag that _looks_ like it could be 'global' but is actually not IMO. Also, if Istio is reading the CSR object, is it possible for it to read the CA from the CSR itself too and append the two instead? Not sure if we ever decided whether to use annotations for this purpose @JoshVanL?" + }, + { + "prediction": "I think this should be `DATE_TIMEF` or `DATE_TIMEFORMAT` to be consistent with the rest of the codebase.", + "reference": "Because this acts as a coordination point between client and server, it should go in core.py instead of const.py (so eventually the server could use it to guarantee that it delivers dates in the expected format)." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it's the only thing I can come up with right now.", + "reference": "expected statement, found 'else' (and 1 more errors)" + }, + { + "prediction": "I think this should be `return MakeRandomID(public).id[0]`", + "reference": "IMO this doesn't need to be in the `kbfs` repo. And I don't like setting the byte. We can always compare with the randomly generated `TlfID`." + }, + { + "prediction": "I think we should rename this to something like `NetworkControllerModuleName` to make it clear that it's not just a device controller but also a network controller.", + "reference": "What's the difference from ModuleName in `pkg/apis/meta/v1alpha1/types.go`?" + }, + { + "prediction": "I don't think we need to use `System.Security.Cryptography` at all. We can just use `System.IO` and `System.Reflection.Metadata` and `System.Reflection.PortableExecutable`.", + "reference": "We shouldn't be changing this task as we are trying to break our dependency on it and switch to using the shipped version." + }, + { + "prediction": "I think it would be better to make this conditional on cci->num_simd_skip > 0", + "reference": "Shouldn't we have a low bar for generating out-of-line context switch, i.e., if we need save more than n (3?) simd or m (4) gprs we should go out-of-line? And it should be || instead &&. It seems the bar is still very high after this change." + }, + { + "prediction": "I think we should move this to `pkg/metric/proxy.go`", + "reference": "Should the API have a dependency on the SDK?" + }, + { + "prediction": "I think this test should be skipped because it's not relevant to the change stream functionality.", + "reference": "Is this a sometimes leaky test?" + }, + { + "prediction": "I think this should be `for _, f := range ftv` instead of `for ftv.contains(f)`.", + "reference": "It should be possible to create a test case that enter the loop. That would be a good enough test case for me. Have a look at the extern type inference test cases that already exist. Since you can just pick the type variables the extern type use, you should be able to create a conflict that requires this loop to fix." + }, + { + "prediction": "I think this should be `if not locale.IsAvailable(wxLang.Language):` instead of `if not locale.IsAvailable(wxLang.Language):`", + "reference": "It might make sense to log this." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I could come up with that works.", + "reference": "Line is too long. [84/80]" + }, + { + "prediction": "I don't think this is a good name for a property. It's not a property of an option, it's a property of the ChromeOptions object itself.", + "reference": "nice touch since Google likes to change things every now and then." + }, + { + "prediction": "I'm not sure if this is the best name for this method. I think it should be something like `load_branding_config` or `get_branding_config` since it's not just fetching a single value but the whole thing.", + "reference": "Thank you this is so much nicer than the old `Rails.configuration.branding['blah']['blah']['blah']` :)" + }, + { + "prediction": "I think this should be `SERVICE` instead of `backend_service` to be consistent with other services.", + "reference": "nit: Would you mind alpha-sorting this?" + }, + { + "prediction": "I think this should be `ManifestContent.DELETE` instead of `DATA`", + "reference": "For my understanding, the DATA manifest & DELETE manifest could share the same read / write path so I think we could use the common reader+writer. Is there any other reason that we need to make them separate paths ?" + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "that change should be sufficient for avoiding the override of contact_us_url helper. The one defined at the .yml it is within a hash so no problem should arise." + }, + { + "prediction": "Shouldn't this be \"hinzuf\u00fcgen\" instead of \"Element\"?", + "reference": "We actually had a discussion about this exactly in #3470, some languages seem to go for one, some for the other" + }, + { + "prediction": "I think this should be renamed to `grpcStreamingDescriptors()`.", + "reference": "Is PHP the first dynamic MVVM language with grpc streaming support?" + }, + { + "prediction": "I think this should be deleted only if tmpStream is not nullptr.", + "reference": "the `if` isn't necessary here; it's safe to call `delete` on `nullptr`" + }, + { + "prediction": "I'm not sure this is the right place for this function. I think it should go in `DataWriterImpl` since it is only used by the `DataWriterImpl::remove_all_changes` function.", + "reference": "Change if the method's name finally changes to `clear_history` as proposed elsewhere" + }, + { + "prediction": "I think this should be `gui.getDocFilePath(\"userGuide.html\")` instead of `documentationUtils.getDocFilePath(\"userGuide.html\")`", + "reference": "can this one also be moved to the top of the file?" + }, + { + "prediction": "I think we should rename this to `Resources` instead of `GroupMembers` to be consistent with the rest of the codebase.", + "reference": "So if I understand this correctly the externalEntities should be computed and stored in GroupMember, while current code usage of GroupMemberPod will be migrated to GroupMember later?" + }, + { + "prediction": "I'm not sure if we want to keep these in the public namespace, or if they should live in `System.Diagnostics.Tracing` or `System.Diagnostics.Tracing.Internal`", + "reference": "Don't we have tests to change after this breaking change? probably we're not using hard coded strings in our tests when we create a `Span`?" + }, + { + "prediction": "I think this should be `os.environ.get(\"GOOGLE_APPLICATION_CREDENTIALS\")` instead of `os.environ['GOOGLE_APPLICATION_CREDENTIALS']`", + "reference": "will this fail if the env variable doesn't exist? Is this the preferred behaviour?" + }, + { + "prediction": "I don't think this is right. The tie-breaker is tied to the pooler, not the pooler to the tie-breaker. The tie-breaker is tied to the pooler, not the pooler to the pooler. The tie-breaker is tied to the pooler, not the pooler to the pooler. The tie-breaker is tied to the pooler, not the pooler to the pooler. The tie-breaker is tied to the pooler, not the pooler to the pooler. The tie-breaker is tied to the pooler, not the pooler to the pooler. The tie-breaker is tied to the pooler, not the pooler to the pooler. The tie-breaker is tied to the pooler, not the pooler to the pooler. The tie-breaker is tied to the pooler, not the pooler to the pooler. The tie-breaker is tied to the pooler, not the pooler to the pooler. The tie-breaker is tied to the pooler, not the pooler to the pooler. The tie-breaker is tied to the pooler, not the pooler to the pooler. The tie-breaker is tied to", + "reference": "bad line wrap" + }, + { + "prediction": "I think this should be `boost::system::error_code` instead of `boost::system::error_code const`.", + "reference": "What does the `8` here represent? Can you give it a name?" + }, + { + "prediction": "I'm not sure this is the right place to put this. I think it should be in `tests/unit_tests/test_materials.py`", + "reference": "`MPRester(os.environ[\"MP_API_KEY\"])` can be left simply as `MPRester()` and it will pick up the API key from the environment. What is the purpose of this file otherwise? Is it better suited for `dev_scripts`, or a test?" + }, + { + "prediction": "Line is too long. [83/80]", + "reference": "Looks like there may be more changes to this file than intended?" + }, + { + "prediction": "I don't think we need to continue here.", + "reference": "when message type is not expected, contine to next loop instead of return to finish infinite loop" + }, + { + "prediction": "I think this file should be renamed to `testutil.go`", + "reference": "This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards." + }, + { + "prediction": "I'm not sure if we want to do this, but I think it's fine to do it here.", + "reference": "instanceID should stay the same for a AWSMachine?" + }, + { + "prediction": "I think this should be set to `True` by default.", + "reference": "Since this is a dict don't you want `False` or do we clean that up elsewhere?" + }, + { + "prediction": "I don't think this is needed. The host is set in `__init__` of the scheduler.", + "reference": "what's the reason you had to add the `host` argument to all `get_work` calls?" + }, + { + "prediction": "I'm not sure this is the right place for this method. I think it should be moved to `AbstractCommand` since it's not specific to a dataverse.", + "reference": "This will never be a dataset so we can simplify the code here" + }, + { + "prediction": "I don't think we need to pass the skipZeroBlockRewards here.", + "reference": "This should be moved into the PrivacyBlockProcessor instead of adding the constructor here." + }, + { + "prediction": "I think we should rename `insightfilestore` to `insightstore`.", + "reference": "nit: Remove \"insightfilestore\". I think \"insightstore\" is good enough and as I see we are using that name at other places too." + }, + { + "prediction": "I'm not sure this is the right place for this method. I think it should go in `Rspec::Core::Formatters::BisectProgressFormatter`.", + "reference": "It looks like you've removed `bisect_round_finished` but kept `bisect_round_started`. Seems a little odd that they aren't paired. Not sure if there's anything to do about that though..." + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it's the only way I could come up with.", + "reference": "I'm not sure how to fix the lint and mypy warnings on this line. I could just ignore them, but I feel like the linter should know this exists." + }, + { + "prediction": "I think this should be `const SKIP_SESSION = Symbol('SKIP_SESSION')`", + "reference": "why remove `Symbol`?" + }, + { + "prediction": "I think this should be `\\u2000-\\u206F\\ud800\\ud801\\ud802\\ud803\\ud804\\ud805\\ud806\\ud807\\ud808\\ud809\\ud80a\\ud80b\\ud80c\\ud80d\\ud80e\\ud80f\\ud810\\ud811\\ud812\\ud813\\ud814\\ud815\\ud816\\ud817\\ud818\\ud819\\ud81a\\ud81b\\ud81c\\ud81d\\ud81e\\ud81f\\ud820\\ud821\\ud822\\ud823\\ud824\\ud825\\ud826\\ud827\\ud828\\ud829\\ud82a\\ud82b\\ud82c\\ud82d\\ud82e\\ud82", + "reference": "Why are currency signs considered punctuation? They technically fall under the BMP range for Currency Symbols `\\u20A0-\\u20CF` (covered in `getUnicodeNonBmpRegExp`, which is itself a misnomer)" + }, + { + "prediction": "I think it would be better to put the maintainer in the `setup.py` and not in the `__init__.py` file.", + "reference": "You have forgotten a coma `,`" + }, + { + "prediction": "`img_meta['filename']` is the filename of the original image. `img_meta['filename']` is not the same as `img_meta['filename'].replace(os.sep, '_')`, which is the filename in the output directory.", + "reference": "For different datasets, we may want to save the images differently. Sometimes the datasets are categorized into several subfolders, and we want to keep it when saving visualization results, and sometimes we just want to save all images in `out_dir`. An argument may be added to control the behavior." + }, + { + "prediction": "I think this should be `return c1 == c2 || (cmp == 0 && bb.get(ia) == '\\0');`", + "reference": "if `other` could have a guaranteed `0` byte in it, this whole `if` could be removed, and above you could just add `|| c2 == '\\0'` to get the same effect?" + }, + { + "prediction": "I think this should be `caseInsensitive` instead of `caseSensitive`", + "reference": "nit: can this be a primitive value?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `browse.go` since it's only used by that function.", + "reference": "This maybe not what we want. If `rewrite` occurred before, `r.URL.Path` contains the result and we should use it. Otherwise `rewrite` middleware will disfunction when combining with `browser`." + }, + { + "prediction": "I think this should be `self.reporters + [self.aggregator]` instead of `self.reporters += [self.aggregator]`", + "reference": "Why change this?" + }, + { + "prediction": "Why not use the `Symfony\\Component\\HttpKernel\\Exception\\NotLogFakeHttpExceptionsExceptionListener`?", + "reference": "_nitpick_ Isn't it now actually NotLogFakeHttpExceptions**Error**Listener ?" + }, + { + "prediction": "I think this should be `JsonSchema.CreateStringEnum(resourceType, apiVersion);`", + "reference": "Why not just look for the \"type\" property instead of creating a ResourceType property?" + }, + { + "prediction": "Why do we need to set the chain id here?", + "reference": "should use `bc.config.Blockchain.ChainID`" + }, + { + "prediction": "I'm not sure this is the right place for this change. I think it should be in the `ElasticsearchStorage` class.", + "reference": "this doesn't need to know about NativeClient" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `Violation` class, under the `rule_name` field.", + "reference": "I know we discussed if we should add in the resource_name to the hash, and I actually don't think it's required. The violation hash was recently updated (not released) to include the violated rule, so when the next release goes out, user's findings will get updated. The resource name doesn't hurt to have here, but not required." + }, + { + "prediction": "I think this should be `surface->texture->height_from_buffer = surface->texture->height * scale;` and `surface->texture->width_from_buffer = surface->texture->width * scale;` instead of `surface->texture->height_from_buffer = surface->texture->height / scale;` and `surface->texture->width_from_buffer = surface->texture->width / scale;`", + "reference": "The variable name is also misleading imo. The width from the buffer comes from `wl_shm_buffer_get_width` (or a similar EGL thing), which is what gets encoded into `surface->texture->width`." + }, + { + "prediction": "I don't think we need to add these to the `tags` here. The `time` tag is already in the `tags` object, and the `artist_name` and `recording_msid` tags are already in the `tags` object. The `time` and `artist_name` tags should be added to the `tags` object. The `recording_msid` and `title` tags should be added to the `tags` object. The `recording_msid` and `title` tags should be added to the `tags` object. The `time` and `title` tags should be added to the `tags` object. The `time` and `title` tags should be added to the `tags` object. The `time` and `title` tags should be added to the `tags` object. The `time` and `title` tags should be added to the `tags` object. The `time` and `title` tags should be added to the `tags` object. The `time` and `title` tags should be added to the `tags` object. The `time` and `title` tags should be added to the `tags` object. The `time` and `", + "reference": "Why are you using these tags to carry these msids?" + }, + { + "prediction": "I'm not sure this is the right fix. The problem is that `flb_sds_len()` returns the number of characters in the string, not the number of bytes. This means that `strncpy()` won't copy the right number of bytes.", + "reference": "flb_strdup() should do the work here. note: use Fluent Bit memory wrappers" + }, + { + "prediction": "I think this should be `go list -f '{{ .Dir }}' -m github.com/gogo/protobuf)/retrieval.proto`", + "reference": "This line should be separated from the package declaration by one line as it is not the package description." + }, + { + "prediction": "why do we need to start a new sf here?", + "reference": "shadow: declaration of \"err\" shadows declaration at line 410 (from `govet`)" + }, + { + "prediction": "I don't think this is the right place for this. I think it should be in the datasize package.", + "reference": "Maybe next time better to make separate PR?" + }, + { + "prediction": "`det_bboxes` is a `List[List[Dict[str, Tensor]]]`, each of which is a `List[Dict[str, Tensor]]`, right?", + "reference": "line 316 also handles this case, need to simplify the logic." + }, + { + "prediction": "I think we can remove the `bucketName == \"\"` check now.", + "reference": "We used to have a simple check for bucket and object names, we then decided to remove it and rely on the backend service to check for the name. Is there any reason to add an empty name check now?" + }, + { + "prediction": "I think this is not the right way to do it. The right way is to calculate the next timeout based on the current time and the max_blocking_time_point. If the current time is greater than the max_blocking_time_point, the next timeout should be the max_blocking_time_point. Otherwise, the next timeout should be the current time plus the max_blocking_time_point.", + "reference": "Line too long" + }, + { + "prediction": "I think this should be `CONST_ME_DODGE` instead of `CONST_ME_FATAL`", + "reference": "This isn't aligned though." + }, + { + "prediction": "I don't think this is the right place for this.", + "reference": "it is mean -> it means PAAHead does not support test-time augmentation." + }, + { + "prediction": "I don't think we need to import `plugins` here, since it's not used in this file.", + "reference": "@lnielsen-cern thanks. I missed it :(" + }, + { + "prediction": "I think this should be `['analytics.pagePath']` instead of `['[]']`", + "reference": "@tofumatt, has it been changed intentionally? It doesn't seem to be required in IB, plus we haven't had `content-drilldown` before... If it has been changed intentionally, then should we update the `AnalyticsDashboardWidget` component to be use `content-drilldown` instead of `content-pages` as well?" + }, + { + "prediction": "nit: remove empty line", + "reference": "nit: don't think an extra line is needed here; as retrying is an installed library and should be grouped with the rest of the installed library." + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in `prometheus/prometheus` package.", + "reference": "This should be a bool" + }, + { + "prediction": "I think this should be `llvm::is_same` instead of `llvm::isa(swift_type)`", + "reference": "`if (llvm::dyn_cast_or_null(GetSwiftType(compiler_type).getPointer())` ?" + }, + { + "prediction": "I think we should rename `canaryManifests` to `canaryConfigMaps`.", + "reference": "The `generateVariantWorkloadManifests` function below relies on the config manifests specified in Git, but it was passed with the newly created canary's manifests where their name was updated." + }, + { + "prediction": "I think this should be `@throws \\UnexpectedValueException`", + "reference": "are this docs neccesary ?" + }, + { + "prediction": "I think this should be `private final String browserStartCommand = null;` and `private final String browserURL = null;` instead of `private String browserStartCommand` and `private String browserURL`", + "reference": "Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC." + }, + { + "prediction": "Why we need to set `clear_loss_weight` here?", + "reference": "This change suppose to resolve issue #2968. `loss_weight` should be of length 2, the second entry is ignored." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `pkg/unversioned/unversioned.go`", + "reference": "Is there an easy way to check for conflict suffix to avoid false positives here?" + }, + { + "prediction": "`@context.get_validated_task` returns `nil` if `opts['task']` is `nil` or `undefined`.", + "reference": "`apply_prep.run_task` also seems like it can just use `@context.run_task`" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `pageLoaded` function.", + "reference": "do you have any idea on how to fix it?" + }, + { + "prediction": "I think this test is a bit too specific to this test class. Can we move it to a separate file?", + "reference": "You don't need to fix this (you've done so many iterations). But for next time, you can make this into a docstring so it'll have a nicer descriptive name when the tests are running." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `ENIAttachment` struct itself, not in the `ENIBaseAttachment` struct.", + "reference": "When does 'expiresAt' change? Do you need this?" + }, + { + "prediction": "This should be `const Outfit*` instead of `const Outfit&`", + "reference": "There are enums for genders + `PLAYERSEX_LAST`." + }, + { + "prediction": "I think this should be `uint64(dataCost) + uint64(onesCost)` instead of `zeroesCost + (96 + ones) * 16`", + "reference": "Should this use the constants as well? Or intentionally covering the fact that the constants may change" + }, + { + "prediction": "I think this should be `if self._size >= 0 and self._size < len(self.best)`", + "reference": "The case of a negative size (= keep all elements) was not handled in this function." + }, + { + "prediction": "I think this should be `system.infiniteTimeout` instead of `system.enableInfiniteTimeout`", + "reference": "I think we should keep this dynamic config knob for operations purpose." + }, + { + "prediction": "I think this should be `self.assertEqual(ti.offsets, (4, 6))`", + "reference": "Was this intentional? Perhaps this could be replaced with another way to check the offsets?" + }, + { + "prediction": "I'm not sure what this is, but it seems like it should be in the manifest.", + "reference": "the buckets are created via the stackset, customers don't need to provide them" + }, + { + "prediction": "I think this should be `qt: blacklight_config.qt` and not `qt: blacklight_config.solr_path`", + "reference": "This doesn't have the same behavior as before. Maybe you want `reverse_merge` (and it either just works or we implement it on `Blacklight::Solr::Request`)" + }, + { + "prediction": "I think this should be `export PATH=/usr/local/ghc/#{ghc_version}/bin:$PATH`, not `export PATH=/usr/local/ghc/#{ghc_version}/bin/:$PATH`", + "reference": "This should be ` /$(ghc_find #{config[:ghc]})/ ` instead of ` /#{ghc_version}/ `, I think." + }, + { + "prediction": "I think this should be `dots-horiz` instead of `dots-horiz`", + "reference": "We should deprecate this at some point." + }, + { + "prediction": "I think it would be better to add `use_sigmoid=False` here as well.", + "reference": "Move these two arguments before `loss_cls`." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in `GenerateSelfSignedX509CA` and then call `GenerateServerX509UsingCA` with the CA as an argument.", + "reference": "[Super NIT]: i := serialNumber if i == 0 { i = mathrand.Int63n(...) }" + }, + { + "prediction": "I think this should be `T` instead of `tool`.", + "reference": "-f short form here collided with --force. :)" + }, + { + "prediction": "I'm not sure why this is removed, but I think it should be added back in.", + "reference": "I think it is better to describe in the release note that `rerender()` was removed." + }, + { + "prediction": "I think this should be `if __name__ == \"__main__\":`", + "reference": "We could also test this easily with `runpy.run_module`, what do you think?" + }, + { + "prediction": "I'm not sure if this is the right way to do it. I think we should check if `val` is an instance of `interface{}` and then call `v.Set(reflect.ValueOf(val))`. If it is not an instance of `interface{}`, then we should just call `v.Set(reflect.ValueOf(val))`.", + "reference": "Is it OK to fall through if it's not assignable? I was kind of surprised when the tests passed. Maybe one of the options below ends up working? For the new tests, this panics because `**not assignable uuid.UUID to []uint8**`. `uuid.UUID` is an array, not a slice." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `BlockAPI` struct.", + "reference": "I know this is after the fact but imo blockAPI should be blockMiningAPI." + }, + { + "prediction": "I think it would be better to use `preg_quote` instead of `self::SYSTEM_ATTRIBUTE_PREFIX`.", + "reference": "it's just a pattern as it was. SystemAttributeCode should have it's own definition and validate by it" + }, + { + "prediction": "`cpp2` should be `cpp2`, and `LookUpIndexRequest` should be `cpp2::LookUpIndexRequest`.", + "reference": "Similar to the code block when we use prefix, maybe we can unify them to base?" + }, + { + "prediction": "I think we can remove the `ValidatePodchaosSchedulerError` from the `ValidateScheduler` error list.", + "reference": "I think `Duration` is useful for this action and we shouldn't ignore it." + }, + { + "prediction": "I don't think we need to return the length of `p` here, since it's the same as the length of `s.dataForWriting`.", + "reference": "Everything below here can be replaced with `return s.err, len(p) - len(s.dataForWriting)`." + }, + { + "prediction": "I think this should be `KOKKOS_ENABLE_IMPL_DESUL_ATOMICS` instead of `KOKKOS_ENABLE_IMPL_DESUL_ATOMICS`", + "reference": "Again, we can also guard `g_host_hip_lock_arrays.atomic`, can't we?" + }, + { + "prediction": "Why do we need to set `$this->commandBus->dispatch($ImportProductAttributesValueCommand, true);` here?", + "reference": "Variable name should start from lowercase latter" + }, + { + "prediction": "I'm not sure if this is the best way to test this. I think it would be better to have a separate test for this.", + "reference": "Why has this timeout doubled?" + }, + { + "prediction": "I think this should be `0` by default.", + "reference": "Should IptablesPostWriteCheckIntervalSecs be set back to its previous smaller value, if use of the iptables lock is disabled?" + }, + { + "prediction": "I don't think this is the right place to do this. This should only happen when the tab is focused, not when the tab is not focused.", + "reference": "You're missing a `return` here, but I'll add it :smile:" + }, + { + "prediction": "I think this should be `wlr_gles2_get_texture(wlr_texture)`", + "reference": "Can you try adding back this assertion? I'd like to assert that the texture has been created in the same context as the renderer." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I could think of to make it work.", + "reference": "This won't work with Python 3 because it will already be a string. In that case we need to use `decode_header` from utils." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in `Mongoid::Fields::Validators::Macro`", + "reference": "Why is the respond_to check here?" + }, + { + "prediction": "Why is this change necessary?", + "reference": "@orklah are you sure it's the same as `$chars[$i]`? It looks like `$i` is changed above, after `$char` assignment." + }, + { + "prediction": "I'm not sure if this is a good idea, but I don't have a better suggestion.", + "reference": "I have a question? How do I construct a indexManager for testcase?" + }, + { + "prediction": "I'm not sure this is the right place for this check. It seems like it should be in the `xfpga_fpgaOpen` function, but I'm not sure what the proper place is.", + "reference": "These checks aren't needed. See pluginmgr.c : opae_plugin_mgr_load_dflt_plugins( )." + }, + { + "prediction": "I'm not sure this is the right fix. I think we need to handle the empty string and whitespaces separately.", + "reference": "Please take a care about prefixing." + }, + { + "prediction": "I'm not sure this is the right place for this method. I think it should go in `EvmAccountUpdater`.", + "reference": "this line doesn't match what the rest says" + }, + { + "prediction": "I think this should be `+build !linux android` instead of `+build windows linux,android`", + "reference": "Since it's not working for linux, maybe leave the !linux in there as well?" + }, + { + "prediction": "I think this should be `continue` instead of `continue with error`.", + "reference": "Should we remove the key-value pair entirely? Same for workflows in general. We have a \"sourceExists\" method that checks if a key is there if I remember correctly." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do it in `ContentSyncManager` where we have access to the `ModificationDate` field.", + "reference": "Unrelated bug fix" + }, + { + "prediction": "This should be `globalize` not `globalize.translate`", + "reference": "We probably want to let the translation library handle the string replacement for these as well." + }, + { + "prediction": "I think it would be better to have a single `--list-db` flag that can be used in conjunction with `--list-memories` and `--list-members`.", + "reference": "should combine these 2 list (list_gossip and list_db) into just one list command, and show the discrepancy between the 2 if any." + }, + { + "prediction": "I'm not sure this is the right place for this method. I think it should be in the `ActionPolicy` class, since it's related to actions on the proposal (approve/reject).", + "reference": "What do you think about prefixing the Policy method names with `can_`?" + }, + { + "prediction": "nit: I think it would be better to use `#define AWS_CREDENTIAL_RESPONSE_EXPIRATION 3600 * 60 * 24 * 30` instead of `3600 * 60 * 24 * 30`", + "reference": "Based on the docs, credential process can return a key `SessionToken`" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I could get it to work. I'm not sure if there is a better way to do this, but it's the only way I could get it to work. I'm not sure if this is the best way to do this, but it's the only way I could get it to work. I'm not sure if there is a better way to do this, but it's the only way I could get it to work. I'm not sure if this is the best way to do this, but it's the only way I could get it to work. I'm not sure if this is the best way to do this, but it's the only way I could get it to work. I'm not sure if this is the best way to do this, but it's the only way I could get it to work. I'm not sure if this is the best way to do this, but it's the only way I could get it to work. I'm not sure if this is the best way to do this, but it's the only way I could get it to work. I'm not sure if this is the best way to do this", + "reference": "I think this if should be removed (see issue)" + }, + { + "prediction": "I think this is the only place where we're using the ipset package.", + "reference": "I would avoid importing `felix/ipsets` package because this package is the windows equivalent and should be at the same level of `felix/ipsets`. We could add linux specific dependencies into `felix/ipsets` later and it will break Windows build." + }, + { + "prediction": "This should be `Optional[Tuple[str, ...]]`", + "reference": "nitpick: Please move this down to the other imports, as it's a Python stdlib import." + }, + { + "prediction": "I think it would be better to have a separate package for blobs. It's not only for GCP, but also for Azure, etc. I think it would be better to have a `blob` package for GCP, Azure, AWS, etc.", + "reference": "\"for getting started guides\" reads a bit weird, like it's missing punctuation. Maybe just \"for a tutorial\"?" + }, + { + "prediction": "`@param bool $enabled is this tab enabled?` -> `@param bool $enabled is this tab enabled?`", + "reference": "This looks like a dead parameter -- maybe a copy and paste error. If it's truly unused, maybe you can open a separate PR to simply delete it, and then it's one less detail to worry about here." + }, + { + "prediction": "I think this should be `bool, int64, uint64, float64, string`", + "reference": "Nit: Should we add support for `int` and `uint` in the `values.New()` function? That would allow us to to handle all of these types in one case. Maybe there's a good reason why we don't do that already, but I'm not sure what it is." + }, + { + "prediction": "I think it would be better to have a `RuleViolationCache` and store all the violations in the cache. This way we can easily check if the cache is full or if there are too many violations in the cache.", + "reference": "if you are not dealing with cache now, please revert these changes. On their own they make little sense" + }, + { + "prediction": "Please remove this empty line.", + "reference": "Wearing my extra-douche-bag hat I would say not spaces on a blank line. Maybe at some point we could have some automated process remove these things. For now I would not bother changing it." + }, + { + "prediction": "Shouldn't this class be called `ShowRemainTimeUpdateListenerEvent`?", + "reference": "I think it would be better to use an `ItemUpdatedEvent` like for the \"prefer streaming\" preference. We already have a ton of events that need to be handled in all list fragments that just do the same everywhere. I think we could even remove some of the existing events in the future." + }, + { + "prediction": "Metrics/LineLength: Line is too long. [131/120]", + "reference": "I think we have to manually write a down for this migration." + }, + { + "prediction": "I think you can remove the `index_map = [(SPARK_INDEX_NAME_FORMAT(0), None)]` line here.", + "reference": "I don't think we still need this check, but I'd leave it as an assertion for now." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Since this may be the case, wondering if we should call the param `updated_at_i` or something so that we don't run into a problem distinguishing them down the road?" + }, + { + "prediction": "I think this should be `Path.Combine(workingDir, appExe, appArgs)`", + "reference": "wondering why we need to join the paths here; seems evt.commandLine only takes whatever appExe is" + }, + { + "prediction": "I don't think this is the best way to fix the issue. I think we need to find a better way to fix the issue.", + "reference": "1.not format code 2.failed but still continue? 3.\"UTF-8\" can changed to java.nio.charset.StandardCharsets.UTF_8.name()" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `src/python/pants/contrib/checks/brain.py`.", + "reference": "I'm wondering if we should add this to a `utils` module in `astroid`. Porting the util to `pylint` doesn't make sense as we would need to duplicate the globals that are being used in the function, but importing from `brain` also feels weird. @Pierre-Sassoulas Do you have an opinion?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `ReceiveAsync` method, since that's where the `ReceiveAsync` is happening.", + "reference": "This seems different than what we do for corrupted request headers. I would like to determine the correct behavior and consolidate this logic." + }, + { + "prediction": "I think this should be `backend.get('resourceGroup')` instead of `backend.get('group')`", + "reference": "Please make the change in the CAI inventory, rather than changing the scanner." + }, + { + "prediction": "Why is this needed? I don't see any usage of this class.", + "reference": "adding this `abstract` is a breaking API change. Even though I agree it makes perfect sense to have it, we can't break this API until PMD 7.0.0. We should revert this particular change. We could make a reminder ticket like we did with #463 for 6.0.0" + }, + { + "prediction": "I'm not sure this is the right place for this test. I think it should go in `spec/models/purchaseable_plan_spec.rb`", + "reference": "This is following the existing convention, but I'm not sure the convention is a good one. I think it would be better to have one shared example group: - It means we don't need to add new example groups twice every time. - If the shared example group looks large, that makes it more obvious that our team models have too much shared behavior. I don't want to do anything about this right now (I'm pretty sure I can wipe out this shared example group when I change team plans), but it's good to keep in mind." + }, + { + "prediction": "I think this should be `|| nano::transport::is_ipv4_or_v4_mapped_address (new_connection->remote.address ())` instead of `|| nano::transport::is_ipv6_address (new_connection->remote.address ())`", + "reference": "I do not think we need to do a source code change to handle this. We could set the subnetwork to default to /32 (/128 for ipv6 ipv4-mapped)" + }, + { + "prediction": "I'm not sure this is the right way to go about it. I think we should be able to remove a cookie from a remote repository without having to know the name of the cookie, and without having to know the name of the remote repository.", + "reference": "It looks good overall! The only issue I have is that the description string is now duplicated twice right? Once in the struct and once in the parameter string? Maybe let's pass the struct to the command so that `ostree_option_context_parse` can set it as the summary? Similar to what we do in rpm-ostree." + }, + { + "prediction": "I think this should be `ChromeDriverCommand` instead of `ChromeDriverCommandExecutor`.", + "reference": "This states very clearly that this is a derivative of Chrome and not Chromium. Do we need to extract an abstract `ChromiumCommandExecutor` and have both Edge and Chrome derive from that?" + }, + { + "prediction": "I'm not sure this is the best way to do this. I think it would be better to check if `type0.getType() == java.lang.Enum.class` and then check if `type0.getType().isEnum() || type0.getType() == java.lang.Enum.class`", + "reference": "it seems to me, the issue lies on `isEnum()` itself, returning false for something that is an enum. I'd rather change it there than here." + }, + { + "prediction": "I don't think this is the right place for this. It should be in `qute_scheme_handler.py`", + "reference": "Please use `{}` instead of `dict()`" + }, + { + "prediction": "`useRef` should be used instead of `useIn` here.", + "reference": "I have concerns about using this in more places before #3278 - I'll take a look at that again shortly." + }, + { + "prediction": "I think you can remove the `log`s from the `testLog` and just test the `Receipt` here.", + "reference": "new field needs to be asserted" + }, + { + "prediction": "I think this should be `self->lastLogIdSent_ = std::max(self->lastLogIdSent_, self->logIdToSend_);` instead of `self->lastLogIdSent_ = self->logIdToSend_;`", + "reference": "when send log failed, why update the last sent log id?" + }, + { + "prediction": "I'm not sure this is the right place for this method. It seems like it should be in the `Appendable` interface, but I can't find where it is used.", + "reference": "what was the problem with the previous order? `prepend` comes conceptually before `append`, i.e. `insert before` should be before `insert after`, I think" + }, + { + "prediction": "I think this should be a `map[string]interface{}`", + "reference": "Why is this necessary? Could you provide some context?" + }, + { + "prediction": "I think you can remove the `type='text/css'` here.", + "reference": "Is there a recommended quote style for attributes? I see single and double here, double further down." + }, + { + "prediction": "I'm not sure if this is the best way to test this, but it seems like it should be.", + "reference": "Please use an atomic bool." + }, + { + "prediction": "I'm not sure this is the right place for this. I think we should move this to `WebSpanExtensions` or `SpanExtensions`", + "reference": "Consider naming this class `SpanExtensions` to follow C# conventions." + }, + { + "prediction": "Why is this removed? I think it's still useful to know what the app domain is.", + "reference": "FYI @lucaspimentel and @colin-higgins since you have already approved, I wanted to point out this required change. By fixing `FrameworkDescription` to use the correct logger, it created a cycle between these two static constructors, so I'm removing this log line and delaying it to when it's actually constructed later in the Tracer. Let me know if you find that acceptable or have any suggestions." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Ah, so we are going to need to update node/host files for this to work?" + }, + { + "prediction": "This should be `LOG.debug`", + "reference": "This code is new and not tested well. While we may drop the log level before we ship 4.0, right now this is extremely helpful to users." + }, + { + "prediction": "Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.", + "reference": "used named path (`proposals_path`) instead?" + }, + { + "prediction": "This should be `AND item_view.suppressed = false;`", + "reference": "Am I misreading something, or is there a mismatched parenthesis here? Please let me know whether or not this is cause for concern -- just wanted to be totally sure before merging, since I can't test this from here. Thanks!" + }, + { + "prediction": "I'm not sure this is the right place to do this validation. I think it should be done in the `response` object, not in the `transport` object. The `response` object contains the headers and the body, and the `transport` object contains the headers and the body, but the `response` object is not the same as the `transport` object. The `response` object contains the headers and the body, and the `transport` object contains the headers and the body, but the `response` object is not the same as the `transport` object. The `response` object contains the headers and the body, and the `transport` object contains the headers and the body, but the `response` object is not the same as the `transport` object. The `response` object contains the headers and the body, and the `transport` object contains the headers and the body, but the `response` object is not the same as the `transport` object. The `response` object contains the headers and the body, and the `transport` object contains the headers and the body, but the `response` object is not the same as the `transport` object. The `response` object contains the headers and the body", + "reference": "Might we want a hook to allow emitting metrics or logs in the case of a permitted empty service header response (or similar UpdateSpanWithErr on empty service header in response if strict enforcement is desired by the caller)?" + }, + { + "prediction": "I think this should be `self.kwargs.setdefault(\"protocol\", \"https\")`", + "reference": "if using dict.get, this could just be `kwargs.get('protocol', 'https')`" + }, + { + "prediction": "I don't think we need this method. We can just use `getGrpcStreamingApiMethodExampleName(Interface interfaze, Method method)`", + "reference": "Add docs to the new methods here" + }, + { + "prediction": "I think this should be `public bool Enabled { get; set; }` instead of `public bool Enabled => true;`", + "reference": "what does it mean enabled?" + }, + { + "prediction": "I don't think this is the right place to do this. It would be better to do it in the `SmartStore` class.", + "reference": "Getting an error when calling with db.execSQL (in sqlcipher 4.3.0, pragma returns ok)." + }, + { + "prediction": "Shouldn't this be `ctx.User.DisplayName()`?", + "reference": "Maybe we could remove `\" \" + ctx.Tr(\"dashboard\")` completely?" + }, + { + "prediction": "I think you can remove the `# Changes the object's server-side encryption state during the copy operation.`", + "reference": "Simple Storage **Service**" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `jsonHandler2` struct, since that's where the `Handle` method is defined.", + "reference": "Let's add some assertions here to ensure we don't panic. Length of results. Conditionally cast second result to error." + }, + { + "prediction": "I think this should be 30 seconds, not 2 minutes.", + "reference": "Where did we take this default from?" + }, + { + "prediction": "I think this should be `options.compareStartDate` and `options.compareEndDate` instead of `options.compareDateRanges` and `options.multiDateRange`", + "reference": "Let's move these down to be after all required arguments rather than in between." + }, + { + "prediction": "I think this should be `if (_sharedStringMap == null) { _sharedStringMap = new Dictionary(); }` instead of `if (_sharedStringMap != null) { _sharedStringMap = new Dictionary(); }`", + "reference": "Should we just null the Map and let the GC handle the memory? Clearing just removes items, but not capacity, so this would leave some memory on the table." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the router.", + "reference": "did you mean to delete this line?" + }, + { + "prediction": "I think it would be better to use `System.out.println` instead of `System.out.print` here.", + "reference": "Should we use logger instead?" + }, + { + "prediction": "I'm not sure this is the right fix, but it's the only way I could get Travis to pass.", + "reference": "I think it would be preferred to do `expect(helper).to be_analytics`" + }, + { + "prediction": "I don't think this is the right fix. We need to keep support for `pd.Index` as well as `str` and `tuple` keys.", + "reference": "Actually, I think it's okay to just change to `if isinstance(key, (str)) or is_list_like(key):` and `key = list(key) if is_list_like(key) else key` for simplicity for now." + }, + { + "prediction": "Why is this needed?", + "reference": "If there any other tests, I would make it optional there also." + }, + { + "prediction": "I'm not sure if we should have a separate route for this or if it should be part of the `my-accounts` route. I think it would be better to keep it separate for now, but let me know if you want me to change that.", + "reference": "This can be removed too, right?" + }, + { + "prediction": "Shouldn't this be `account.getTransportUris(0)`?", + "reference": "If you're going to allow people to specify multiple SMTP servers, you should also properly export/import them." + }, + { + "prediction": "I'm not sure if we want these metrics to be exposed to the public. I think they are only used by the ASP.NET Core runtime itself.", + "reference": "nit: Can we prefix these variables with `AspNetCore`?" + }, + { + "prediction": "I think this test should be `it 'transpiles a YAML plan from a path' do`", + "reference": "Can this also include a quick test for transpiling by name?" + }, + { + "prediction": "I think we can remove this struct now, since we don't need to pass it to `doPostRequest` anymore.", + "reference": "This TODO can be removed" + }, + { + "prediction": "I'm not sure this is the right place for this interface. I think it should go in `MvvmCross.UIElements`", + "reference": "can we make tabAccessibilityIdentifier = null as default?" + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it's the only way I could get it to work.", + "reference": "Should we print this error?" + }, + { + "prediction": "I think this should be `int(multi_scores.size(1) - 1) - 1`", + "reference": "For which reason do we need to convert this to int here?" + }, + { + "prediction": "I think this should return an error.", + "reference": "FWIW, wondering if the error is interesting here (I actually arrived at this code initially to change `supportsFreezer()` to return a `bool`" + }, + { + "prediction": "I'm not sure if this is the best way to display the visibility level.", + "reference": "Does this still need to be a partial? is the intention down the line to move back towards a conditionally different title?" + }, + { + "prediction": "I'm not sure this is the right place for this test. I think it should be in `integration/registry_test.go`", + "reference": "seems like `RegistryURL` is missing? Same for a few other places that create `archer.Environment` below." + }, + { + "prediction": "I think it would be better to move this import to the top of the file.", + "reference": "Are these imports needed?" + }, + { + "prediction": "I'm not sure this is the right place for this test. It seems like it should be in the `text.formControlValue` test suite, but I can't find where it is placed.", + "reference": "I think you can remove the `(isIE11 ? it.skip : it)(` above, if you're going to skip the test this way." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in the `copy` method.", + "reference": "IMO we should instead fix the above call to do `long actualChecksumIn = Long.reverseBytes(in.readLong());` to get the actual checksum value? This way the below error message would also be correct?" + }, + { + "prediction": "I think this should be `obsoleteIndex` instead of `obsoleteIndexes`", + "reference": "I think we also need something similar for `rebuild-index`?" + }, + { + "prediction": "I think this should be `defaultBundleEndpointPort = 443` instead of `defaultBundleEndpointPort = 8080`", + "reference": "I think convention is snake case for import naming?" + }, + { + "prediction": "I think we can remove the `isCommonHandle` check here and just do `indexScanBuilder.addColumns(tableInfo.getColumn(col.getName()).toProto(tableInfo));`", + "reference": "i think haspk is false?" + }, + { + "prediction": "I think this should be `--surefire-dir` instead of `--surefire-dir --dir`", + "reference": "you should add this to the cover command too (but let's have a more general convo about whether it's a flag or config option)" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but it seems like we should be able to do this in the same way we did before.", + "reference": "instead of passing in pointer to empty struct, we should make it optional and support passing nil and use default cfg if it is nil." + }, + { + "prediction": "I think this should be `obj.to_json()`, not `obj.to_csv()`.", + "reference": "A fair bit faster, although still not great, hence also adding a hashkey." + }, + { + "prediction": "I'm not sure if this is the best way to display the progress, but it's the only way I could get to work.", + "reference": "If we're going to leave this in here, how about we at least pull it into partial?" + }, + { + "prediction": "I think we should be able to get away with 20 seconds here.", + "reference": "This `context` is used correctly, there is nothing left TO DO." + }, + { + "prediction": "I'm not sure this is the right way to do it. I think we need to pass the `limit` and `skip` to the `countDocuments` function.", + "reference": "If `docs` is an empty array there will be an error" + }, + { + "prediction": "I think this should be `!strings.HasPrefix(host, \"quic:\")` and not `!strings.HasPrefix(host, \"unix:\")`", + "reference": "Is it really necessary to have the user specify this, or can the reverse proxy infer QUIC from the upstream's Alt-Svc headers?" + }, + { + "prediction": "Why is this needed? I don't see it being used anywhere in the tests.", + "reference": "just remove the entire variable." + }, + { + "prediction": "I think this should be `@options[:modulepath] = modulepath.split(File::PATH_SEPARATOR).map { |moduledir| File.expand_path(moduledir) }`", + "reference": "Maybe we should put that in the option description?" + }, + { + "prediction": "I think it would be better to use `Optional.ofNullable(keyFilePath)` instead of `Optional keyFilePath`", + "reference": "Why do we need to make this optional? Isn't the idea of the builder that if you don't need this value you just don't call the `keyFilePath ` method?" + }, + { + "prediction": "I think it would be better to have a method for this, like `metricsConfigForTable(Table table)`", + "reference": "Shall we do the same for ORC and Avro?" + }, + { + "prediction": "I think this should be `MIT` instead of `Apache License, Version 2.0`.", + "reference": "Should be a space between line" + }, + { + "prediction": "Why not using `SecureRandom` from `System.Security.Cryptography`?", + "reference": "if not behind interface then equally we can use SecureRandom.GetBytes directly, otherwise let us push it behind ISecureRandom so we can test with this class wherever used" + }, + { + "prediction": "I think we can remove the `tile` class now, since we don't need it anymore.", + "reference": "Probably will undo this change for now, as I'm just targeting Weekly Iteration in this PR." + }, + { + "prediction": "Why is this being removed?", + "reference": "Unused parameter warning? How comes we did not catch that before? In any case please open another PR for this." + }, + { + "prediction": "`use_group_of` is not used in this function, can you remove it?", + "reference": "I recommend move all openimage related logic to a new function" + }, + { + "prediction": "I think this should be `ExternalCgroup bool` and not `ExternalCgroup bool ExternalCgroup bool`", + "reference": "We shouldn't have a bool for this. If there is a path passed, then we use it. Resource may or may not be empty." + }, + { + "prediction": "I'm not sure if this is the best way to display the count, but it's the only way I could come up with that worked.", + "reference": "I like how you used the count on the translate call to handle this." + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think it should be done in the `getSearchHandler` method.", + "reference": "Do we need to do this from the outside, or is there a spot in the handler code where we can do this automatically? (I haven't studied it closely yet... just wondering if you've already thought it through or if it's worth taking a closer look)." + }, + { + "prediction": "This is not a test. This is a test of the Sputnik library.", + "reference": "[Checkstyle] INFO: Using the '._' form of import should be avoided - java.util._." + }, + { + "prediction": "I think this should be `settings['cliquet.storage_backend'] = 'cliquet.storage.redis'` instead of `settings['cliquet.storage_backend'] = 'cliquet.storage.redis'`", + "reference": "So, why everything is in memory but the permission backend?" + }, + { + "prediction": "I'm not sure this is a good idea. I think it would be better to have the `UiSetupWizardImplementation` implement `UiSetupWizard` and have the `UiSetupWizardImplementation` call `UiSetupWizard.showBrowseStep` instead of calling `UiSetupWizard.showBrowseStep` directly.", + "reference": "Are you sure it should be null and not an empty List?" + }, + { + "prediction": "I think this should be `Frameworks` and not `AdditionalDependencies`", + "reference": "Unfortunately I think the assumption of \"empty\" means the default dependency section is not correct. For a project.json file the default dependencies section is a shared section between all the different target frameworks and our TargetGroup being empty may map to many different target frameworks so they aren't really equated." + }, + { + "prediction": "I'm not sure if this change is correct. I think it should be `new KeyValuePair(\"host\", new[] { \"localhost\" });` and `new KeyValuePair(\"custom\", new[] { \"value\" });`", + "reference": "This test was verifying the wrong thing." + }, + { + "prediction": "I think this should be `development` instead of `brave`", + "reference": "pls pr a name change fro muon here too separately." + }, + { + "prediction": "I think this should be `opts.envStore.CreateOrUpdateEnvironment(&env)` instead of `opts.envStore.CreateEnvironment(&env)`", + "reference": "nit: we can use `defer opts.spinner.Stop(\"Error!\")` after l.180 to make it slightly neater" + }, + { + "prediction": "(style) 'is' may be misspelled - perhaps 'isn'? (style) 'is' may be misspelled - perhaps 'isn'? (style) 'is' may be misspelled - perhaps 'isha'? (style) 'is' may be misspelled - perhaps 'isha'? (style) 'is' may be misspelled - perhaps 'isha'? (style) 'is' may be misspelled - perhaps 'isha'? (style) 'is' may be misspelled - perhaps 'isha'? (style) 'is' may be misspelled - perhaps 'isha'? (style) 'is' may be misspelled - perhaps 'isha'? (style) 'is' may be misspelled - perhaps 'isha'? (style) 'is' may be misspelled - perhaps 'isha'? (style) 'is' may be misspelled - perhaps 'isha'? (style) 'is' may be misspelled - perhaps 'isha'? (style) 'is' may be misspelled - perhaps 'isha'? (style) 'is' may be misspelled - perhaps 'isha'? (style) 'is' may be misspelled - perhaps 'isha", + "reference": "This is declared in the wrong block" + }, + { + "prediction": "I think it's better to log the message itself, rather than the header and the route.", + "reference": "In fact it would be useful for debug, i prefer combine them into one debug level log." + }, + { + "prediction": "I think it would be better to have a `crashType` or `crashTypeLabel` field in the `alert` object. It would make it easier to distinguish between different types of alerts.", + "reference": "We would need to localize them eventually too, just FYI" + }, + { + "prediction": "I think this should be `set_type()` instead of `set_name()`.", + "reference": "It looks like the proto code needs to change the function name from set_name to set_type to be consistent." + }, + { + "prediction": "I think we should remove this file.", + "reference": "I think we can avoid using this pattern for this use case." + }, + { + "prediction": "I'm not sure why this is needed. It seems like it should be fine to leave out the `#include ` line.", + "reference": "Could you please change this to `#ifndef __linux__`? That's when we use our own implementation instead of `posix_spawnp`." + }, + { + "prediction": "I think we can drop the `!= null` part here.", + "reference": "Nit: put the `&&` on the previous line so that a reader knows that there's more to the statement at a casual glance." + }, + { + "prediction": "I think this should be `tlfTypeToString(t)` instead of `tlfTypeToPath(t)`", + "reference": "Technically the \"right\" variables to use would be the ones in `libgit/autogit_node_wrappers.go\", which define how the tlf types map to subdirs for autogit specifically. (They would have to be exported.) But this is fine too I guess, just a little dirtier." + }, + { + "prediction": "Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.", + "reference": "Should there be a template or something associated with this email? Right now it's identical to `notification_for_approver`" + }, + { + "prediction": "I think this should be `em` and not `$em`", + "reference": "i hope there is some extension in phpstan for this" + }, + { + "prediction": "I don't think this is the right place to do this check. It's not clear to me what the case is when `sep == 0` and what the case is when `sep > 0` and `sep > flagSep`. I think it would be better to move this check into the `if (sep == 0) return 0;` above.", + "reference": "We don't store empty dictionary entries anymore: they bring no benefits, only trouble." + }, + { + "prediction": "I think this should be `IsEnum` instead of `opts_.scoped_enums && IsEnum(type);`", + "reference": "Optional: This function is C++ specific and could be declared as `static`." + }, + { + "prediction": "I think it would be better to have a method `Roles getRoles(String domainName, String tagKey, String tagValue, Boolean members)` instead of adding new parameters to `getRoles(String domainName, Boolean members)`.", + "reference": "we can't remove functions as that would introduce backward compatibility issues in our java client. So we should also have a function with the original arguments: ` public Roles getRoles(String domainName, Boolean members) { return getRoles(domainName, members, null, null); } ` For the Go client we don't have a wrapper so no option but to update your client code as necessary, but for java we have the wrapper thus we always maintain backward compatibility" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think we should move this to `spec_helper.rb` under `RSpec.configure do |config|` so that it can be used in other specs as well.", + "reference": "I'd recommend keeping this in `warn_deprecation` and not adding an override of `warn`." + }, + { + "prediction": "I think this should be `process.argv.push(blitzPath, 'start');` instead of `process.argv.length = 1;process.argv.push(blitzPath, 'start');`", + "reference": "I think we should use a `blitz` bin instead" + }, + { + "prediction": "I think this should be `if not dataset._virtual_vdims:`", + "reference": "Why not make the ``derived_vdims`` flag (or similar, ``validate_vdims`` maybe?) an explicit argument to ``validate``?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think we should move it to `volume.go` since it's only used there.", + "reference": "was it not possible to do this at the filter or porx driver layer? We typically try to avoid driver-specific things in the SDK layer" + }, + { + "prediction": "I don't think we need this file.", + "reference": "please update the year. it can be setup in intellij template." + }, + { + "prediction": "I don't think we should have a test for `log.trace` with no args. I think we should have a test for `log.trace(message, arg1, arg2, arg3, arg4, arg5, arg6, arg7, arg8, arg9, arg10, arg11, arg12, arg13, arg14, arg15, arg16, arg17, arg18, arg19, arg20, arg21, arg22, arg23, arg24, arg25, arg26, arg27, arg28, arg29, arg30, arg31, arg32, arg33, arg34, arg35, arg36, arg37, arg38, arg39, arg40, arg41, arg42, arg43, arg44, arg45, arg46, arg47, arg48, arg49, arg50, arg51, arg52, arg53, arg54, arg55, arg56, arg57, arg58, arg5", + "reference": "what's the use-case for this?" + }, + { + "prediction": "I think this should be `if not isinstance(as_index, bool)`", + "reference": "nit: `as_index must be an boolean` -> `as_index must be a boolean`" + }, + { + "prediction": "Shouldn't this be `updateVersion`?", + "reference": "What is the goal of that method ? And what are `$currentVersion` and `$newVersion` ? Are they Thelia or Module version ? :)" + }, + { + "prediction": "I'm not sure if this is the best version to use, but it's the one we use in the rest of the SDKs, so I'm going to go with it. Let me know what you think of this.", + "reference": "Is there an advantage to this vs setting `this.version` in the constructor? Cleaner this way, at the top?" + }, + { + "prediction": "I think you can use `StringUtils.trimToEmpty` here instead of calling `url` again and again.", + "reference": "Fix for URISyntaxException." + }, + { + "prediction": "I think this should be `if routeUpd.Dst != nil`", + "reference": "Would be good to UT this case" + }, + { + "prediction": "I think this should be `off` instead of `warn`", + "reference": "Why we need to add this?" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in `ClusterInfo`.", + "reference": "This is ok to change since I believe that these were added just in main and not in public release." + }, + { + "prediction": "I think this should be `pubsubServiceAccount` instead of `pubsubServiceAccountName`", + "reference": "Not needed in this PR, just want to make sure people think about this (maybe make an issue)? This is a lot of strings in a row. It will be hard/impossible for someone reading the code to see that everything is in the correct position. I recommend creating a struct instead of passing seven strings in a row. A similar problem exists on most of the `MakeFoo(...)` style methods in this change." + }, + { + "prediction": "I think this should be done in the `OnRunCompleted` event handler of the `SarifDriver` class.", + "reference": "_jaw drops_ I would have sworn I wrote those lines. Good catch." + }, + { + "prediction": "I think this should be done in a `beforeEach` callback. Otherwise, it will be called every time the module is used, which is not what we want.", + "reference": "This needs to be tested." + }, + { + "prediction": "I'm not sure if this is the right place to put this test. I think it should go in `spec/models/building.rb`, but I'm not sure if there's a better place to put it.", + "reference": "I believe you're missing the comparison after 'be'" + }, + { + "prediction": "I'm not sure this is the right place to put this. I think it should be in the `Get` method of the `KVStoreForTrie`", + "reference": "move 103~105 to in front of 97?" + }, + { + "prediction": "Can you remove these imports? They are no longer used.", + "reference": "Lots of unnecessary imports left in this file." + }, + { + "prediction": "I think this should be `descriptor->GetClass() == DescriptorClass::UniformArray`", + "reference": "Does this actually produce different code?" + }, + { + "prediction": "I'm not sure this is the best way to check for the attribute. I think it would be better to check for `onblur` instead of `onfocus` since that is the attribute we want to check for.", + "reference": "This should account for whitespace. Simply putting `.trim()` on the attribute value should do." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I could get it to work.", + "reference": "I don't think we need these. Simpler just to put `routetable.TargetType...` inline below." + }, + { + "prediction": "I think this should be `method == 'PUT' or method == 'DELETE'` instead of `method == 'PUT' or method == 'DELETE' or method == 'PUT'`", + "reference": "Nested if statement. You can merge both statements nested together to create one" + }, + { + "prediction": "I don't think this is the right place for this method. It should be moved to `AbstractTest` class.", + "reference": "Nitpick: add a space after the comma. Also, we should consider that the format of the version could change in the future so we could get something that is not a parsable integer." + }, + { + "prediction": "I'm not sure if this is the right fix. I don't think we want to change the behavior of `get` in this test.", + "reference": "For your reference in future, I sugguest to use the `ASSERT_*` family." + }, + { + "prediction": "This should be `#include \"fmt/format.h\"`, not `#include \"fmt/format.h\"`.", + "reference": "no need to import `fmt/format.h` here since the `KimInit` class is derived from `Pointers`. Any class derived from `Pointers` can assumed that `lmptype.h`, `mpi.h`, `cstddef`, `cstdio`, `string`, `utils.h` and `fmt/format.h` are already included through `pointers.h`." + }, + { + "prediction": "I think this should be `import \"github.com/pkg/errors\"`", + "reference": "Can we have prefix of `OPENEBS_IO` e.g.: `OPENEBS_IO_INSTANCE_NAME`" + }, + { + "prediction": "I think this should be `errors.New(\"GetRootNode is not supported by folderBranchOps\")`", + "reference": "Might as well fix these bare returns by making them `return errors.New(...` directly." + }, + { + "prediction": "why is this needed?", + "reference": "we can use import here" + }, + { + "prediction": "Why is this removed?", + "reference": "thx for removing these" + }, + { + "prediction": "Shouldn't this be `throw new RuntimeException(String.format(\"Failed to parse failures XML: %s\", sourceReport), e);`?", + "reference": "I snuck this one in as well as checkstyle crashing (on files from resources) caused an unfinished xml to be written, and it wasn't obvious where that XML was" + }, + { + "prediction": "I think this test should be renamed to `TestCreateInstanceValidateMachineTypeError` to match the rest of the tests.", + "reference": "How is this different than \"good case\"?" + }, + { + "prediction": "I think we can remove the `string` here and just use `services []string`", + "reference": "the last parameter name should be `serviceName` as is in the implementation" + }, + { + "prediction": "I think this test should be moved to `PrettyPrintVisitorTest` since it is not related to `Javadoc` at all.", + "reference": "@ftomassetti - okay, this is a little meh." + }, + { + "prediction": "This should be `ErrNotImplemented`, not `ErrNotImplemented`.", + "reference": "Note, changed initial capitalisation of this for consistency. Can do it the other way around too if that'd be better. :wink:" + }, + { + "prediction": "`typeof window === 'object' ? window : this` -> `window ? window.document : this`", + "reference": "hey, aren't we supposed to be passing in two parameters here?" + }, + { + "prediction": "I think this should be `bitcore.Unit = require('./lib/unit');`", + "reference": "please keep alphabetical ordering :)" + }, + { + "prediction": "I don't think you need to import `InputStream` and `OutputStream` here. You can just use `Reader` and `Writer` directly.", + "reference": "Selenium must compile against Java 6. Revert this line." + }, + { + "prediction": "I'm not sure if this is the right fix. I think we need to pass in the `resourceGroup` to the `MakePullSubscription` function instead of passing in the entire `resourceGroup` to the `RunClientSet.PubsubV1alpha1().PullSubscriptions` function. This way the `MakePullSubscription` function will be able to pass in the `resourceGroup` and not have to pass in the entire `resourceGroup` to the `MakePullSubscription` function.", + "reference": "what is that `\"\"`, the adapterType? can you add `\"\" /* adapterType */`... in other places as well... might be cleaner if it's a pointer or some varargs at the end but don't have any strong preference.." + }, + { + "prediction": "`pType` can be `undefined` here, right?", + "reference": "This check is a little odd, and will still mess up with empty strings `''` because empty string is falsy. Can we change this to `|| _this.getValue(path) == null`?" + }, + { + "prediction": "I think this should be `if (virtualNode.hasAttribute('tabindex'))` instead of `if (virtualNode.hasAttribute('tabindex') && !isNaN(parseInt(virtualNode.getAttribute('tabindex'), 10))`", + "reference": "Just a minor suggestion: If you `parseInt` when you access the attribute then you shouldn't have to do it twice in the ternary." + }, + { + "prediction": "I think this should be `body[:target]['host-key-check'] = transport == 'ssh'`", + "reference": "This change in particular is strange. I'm not sure why it would now be necessary. The previous default would've been true, and the default behavior without a new net-ssh version should be unchanged." + }, + { + "prediction": "Why is this needed?", + "reference": "Why is that? Should be redundant as the default value exists." + }, + { + "prediction": "I'm not sure if this should be configurable or not. If it should be configurable, then I think we should have a default of `false`. If it shouldn't be configurable, then I think it should be `true` by default.", + "reference": "Are all fields beginning with \"Debug\" automatically `;local` ? (I guess so, but just checking.)" + }, + { + "prediction": "I think it would be better to call this method `createUpdateNameMapping` instead of `updateNameMapping` to be consistent with other methods in this class.", + "reference": "While I think it makes sense to update the mapping programmatically, I don't see much value in exposing it as part of the table API. We want to keep the Table API small, so if we can handle this by using a separate API that consumes and produces JSON, then that is preferred. Also, we may have more than one mapping in the future, so keeping this decoupled also helps out for those use cases. For now, let's build a utility class to perform these updates. We can always add this to the public API later if we choose to." + }, + { + "prediction": "I think this should be `getIpcEnv()->getAllConnections()->waitOnAll(getStatsMergeTimeout() * 10);`", + "reference": "We would want ssmp to wake up every 3 seconds if there are no other requests to it and do some cleanup tasks. So, it is not clear why do you want to set this to 0." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it's better to do it in IRBuilder.", + "reference": "Is this really necessary? I would expect these types to be included with the loop below." + }, + { + "prediction": "I'm not sure this is the right thing to do. If we're going to do it at all, I think we should do it in a way that's consistent with the rest of the Jaeger exporter.", + "reference": "You could do span and it's magic of typecast to int for better efficiency" + }, + { + "prediction": "I think this should be `cssRule.style[webkitTransform] || cssRule.style[transform] || false;`", + "reference": "Looks like you've covered `-webkit-transform`, but what about `-ms-transform`?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `MvxBindingLog.Error`.", + "reference": "Is there something missing from the message here?" + }, + { + "prediction": "I don't think this is needed anymore.", + "reference": "Hmm, what does this syntax mean?" + }, + { + "prediction": "I think we can remove the `callerTypeAPI` variable from the `getOrCreateWorkflowExecution` function.", + "reference": "should this be callerTypeTask?" + }, + { + "prediction": "I think this should be `@plan.administerable_by?(@user.id, :test => true)`", + "reference": "Currently update is set as @plan.editable_by?(@user.id) Which one is the correct behavior? I can see a case for only owners/co-owners to be able to set visibility, test status, and other plan details" + }, + { + "prediction": "I think this should be `MaxQueueSize = 10_000_000` and `BestKnownSearchLimit = 256_000_000`", + "reference": "Maybe make it configurable? Or store the actual level index in DB, making this binary search obsolete?" + }, + { + "prediction": "nit: remove empty line", + "reference": "Nit: this file doesn't need to change. Can you revert this to avoid git conflicts?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `onClick` handler of the `HelpMenu` component.", + "reference": "There's no reason for this to be a callback now technically but as per our tech decision, we want all handlers to use `useCallback` now" + }, + { + "prediction": "I think this should be called \"LO\" instead of \"LOGIC\"", + "reference": "This isn't strictly part of this PR, but could you move `multiSigString` from `crypto/multisig.go` into this list of `HashID` values? Now that we have other things being hashed into addresses (specifically, these new logic addresses), it's important that the hash input for multisig addrs is domain-separated from logic addresses." + }, + { + "prediction": "I think this should be `stop_worker_pool`", + "reference": "nit: you could have named it just \"TestCase\" (if django's TestCase was imported differently)" + }, + { + "prediction": "I think this should be `bridge.print_page(*options)`, since it's a method on the bridge object.", + "reference": "the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here." + }, + { + "prediction": "I think this should be `lldb::eNoDynamicValues` instead of `lldb::eNoSyntheticValue`.", + "reference": "All the callers of `ExtractSomeIfAny`, always pass `true` to `synthetic_value`. Can we get rid of the extra argument?" + }, + { + "prediction": "I think it would be better to move this to the top of the function, so that it's the first thing that gets executed when the script is run.", + "reference": "Better to use the absolute path." + }, + { + "prediction": "I think it should be 100000000 instead of 2000.", + "reference": "this is 16 hours, is that enough?" + }, + { + "prediction": "I think we should use `AddErrorToSpan` instead of `AddErrorEndSpan`.", + "reference": "removing boilerplate. You could also add a `StartSpan` with varargs to inline string attributes." + }, + { + "prediction": "I'm not sure if this is the right place to store the rollup context. I think it's better to store it in the EthSyncService.", + "reference": "Can you replace these single letter variables with full names?" + }, + { + "prediction": "I think this should be `Stream? Connection { get; set; }` and the `PrepareRequest` should be `Func`.", + "reference": "At first I wasn't sure, but now I think I'm sold on making PrepareRequest an action over adding a state object to the context." + }, + { + "prediction": "This should be `preg_match('/^VuFind (\\d+\\.?\\d*)$/', $newConfig['Site']['generator'])`", + "reference": "Would it be too greedy to preg_replace `VuFind (\\d+\\.?)+` with `'VuFind ' . $this->to` anywhere in the string? This would update something like 'Finna (VuFind 7.1.0)' as well. Just a thought, please disregard if you'd like to keep it as is." + }, + { + "prediction": "I think this should be `getZkStateReader().getClusterState().getCollection(collection).getConfigName();`", + "reference": "BTW for brevity, you can remove `getZkStateReader().` here and elsewhere since ZkController has a convenience method for the cluster state." + }, + { + "prediction": "`manifests` is a `Iterable`, not a `CloseableIterable`.", + "reference": "If there are no manifests, then entries should be `CloseableIterable.empty()`, not the manifest iterable. That doesn't need to be closeable." + }, + { + "prediction": "I think it would be better to have a separate test class for this rule. This way you don't have to repeat the same test code in every test class.", + "reference": "this class should be named `ArrayInitializationVerbosenessTest` to work" + }, + { + "prediction": "I'm not sure this is the right place for this validation. I think it should be in the `logstash` gem.", + "reference": "Do we want to allow users to disable `console` as well? The schema currently says that it only permits a hash for `console`." + }, + { + "prediction": "Why is this not working?", + "reference": "It would be very helpful to describe succinctly either inline or by linking to an issue going into depth why each test is not working. If we merge like this your knowledge of what is going on is lost and other people in the code need to do a ton of reading before understanding when/how/if we should unskip." + }, + { + "prediction": "I think we can remove `previousDataLoaded` and `previousError` from the `currentError` and `currentDataLoaded` from the `previousError` and `previousDataLoaded` from the `currentDataLoaded` and `currentError` from the `currentDataLoaded` from the `currentDataLoaded`", + "reference": "As this is a `useEffect` this could be a cause for concern! Note that `useEffect` re-runs when a dependency changes **not** when a dependency is truthy (the previous code does look a bit like it's expecting that)" + }, + { + "prediction": "`delete` is not needed here.", + "reference": "Should we be doing this with `make_unique` or something?" + }, + { + "prediction": "I'm not sure if this is the ideal data to consume.", + "reference": "we don't want to set default values for this. Since it is the actual email, we want to make sure we are always passing in the `user` and `proposal` . we have a default value of `nil` for modifier because sometimes will update a proposal via `rails console` in which case there will be no recorded modifier." + }, + { + "prediction": "nit: remove empty line", + "reference": "Yes this import was in the wrong place, but should ideally be in the first list of imports (among `go/build`, `go/token`, etc.). You may move it there, or just revert this change as it's actually unrelated." + }, + { + "prediction": "I'm not sure about this change. I think it's fine, but I'm not sure why it was changed in the first place.", + "reference": "It's unnecessary to duplicate the `name`." + }, + { + "prediction": "Why is this change needed?", + "reference": "this was a mistake when adding phpstan strict plugin" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but it seems to be the only place I could think of.", + "reference": "Nit: I think it should be `to handle` here." + }, + { + "prediction": "Please revert this change.", + "reference": "Please don't make unrelated changes or let your tools make unrelated changes." + }, + { + "prediction": "I think this should be `uint` instead of `int` since it's an unsigned integer.", + "reference": "`numAccounts` is a global variable (from `gochecknoglobals`)" + }, + { + "prediction": "I think this should be done in the `Plugin::remove()` method.", + "reference": "Is the ID correctly normalized at this point?" + }, + { + "prediction": "I'm not sure if this is the right place to put this.", + "reference": "if 0 is a special constant meaning \"no limit\" let's make it a constant and name it correctly :)" + }, + { + "prediction": "I think this should be done in `runInventory()` instead of here.", + "reference": "Curious about the reason behind this change" + }, + { + "prediction": "I'm not sure if this is the best place to put this. I think it's better to put it in the `cborStore.Put` method.", + "reference": "wait, i thought the cborstore was for state tree?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in `set_materialized_location`", + "reference": "This logic is now duplicated here and in `_delete_temporary_files`... Maybe do it all at once - find temp files, delete them, and fix the logical keys?" + }, + { + "prediction": "I don't think this is the right place to do this. I think this should be done in the `ResponseType` class.", + "reference": "How about name it with NullResponseTypeProcessor" + }, + { + "prediction": "I think this should be `if (config_.max_bin_by_feature[i] == 0)`", + "reference": "Maybe `Log::Fatal` here? `[LightGBM] [Fatal] Check failed: feat_is_unconstrained at ...` (and kernel death in case of Jupyter Notebook) seems to be not so informative and user-friendly." + }, + { + "prediction": "I'm not sure this is the right place for this method. I think it should be in `decimate.py` since it's only used by `decimate.py`.", + "reference": "Not sure I like the name ``_apply``. Even though ``_process`` is supposed to process elements already, how about ``_process_element`` which processes elements, *excluding* Overlays/NdOverlays." + }, + { + "prediction": "I think we can remove NodeRoleTagValue and use `NodeRole` instead.", + "reference": "Let's use this constant when ASG is created as well (currently hardcoded)." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in the `objects.py` file, under the `GROUP BY` section.", + "reference": "Oh is `bucket` actually higher cardinality than `eventname`?" + }, + { + "prediction": "I think this should be `from PyQt5.QtWebEngineWidgets import QWebEngineProfile # pylint: disable=unused-import`", + "reference": "You can't rely on QtWebEngine being available - but why do you need to import this here at all?" + }, + { + "prediction": "I don't think you need to do this. You should be able to do `py2exe --force-includes --onefile --no-py2exe` and it should work.", + "reference": "How did you determine these - and how can we be confident that nothing is missing?" + }, + { + "prediction": "I'm not sure if this is the best place to put this. I think it would be better to put it under the `Workshops` section since it's related to the `Workshops` section.", + "reference": "What is this page going to do that is different than the products index we already have?" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I could come up with that works.", + "reference": "Is this intended to be here? Seems it belongs to a different PR." + }, + { + "prediction": "Why not use `SetConsoleColor`?", + "reference": "These changes, while harmless, were no longer needed with newer versions of System.Console thanks to @ianhays" + }, + { + "prediction": "I'm not sure if this is the best way to handle this, but it's the only way I could find that works.", + "reference": "Umm... this isn't relevant to this PR" + }, + { + "prediction": "I think this should be `0x8000 | 0x1000 | 0x2000 | 0x4000 | 0x4000 | 0x8000`", + "reference": "While All make some sense here it doesn't make a lot of sense in the SkipOnFramework context. I wonder if we really need to expose anything more here. You can just blindly use 0." + }, + { + "prediction": "I think this should be `// Package main provides the Bee binary viper-cobra command definitions.`", + "reference": "Actually, this is not correct. Package `cmd/bee` doe snot have any notion of commands or even libraries used for them. It is as simple as possible, just calling the function from `cmd/bee/cmd` which actually implements commands." + }, + { + "prediction": "I'm not sure if this is the right place for this route. I think it should go in `user` folder.", + "reference": "This change is causing tests to fail because users sits at `/app/users`, not `/app/admin/users`" + }, + { + "prediction": "I think this should be `null, null` instead of `null, strict` and `null, lax`", + "reference": "Could you provide more information on what exactly each of those three options do?" + }, + { + "prediction": "I don't think we need to expose the perfCollect here.", + "reference": "Why this line break?" + }, + { + "prediction": "@deads2k @pgavlin can you review this change?", + "reference": "We're importing this twice with different aliases." + }, + { + "prediction": "I think we can remove `pandera==0.8.0` now.", + "reference": "We should avoid adding a pandera dependency to Dagster itself." + }, + { + "prediction": "I don't think you need to create a new array, you can just do `this.permissions = this.permissions.concat(new ObjectPermission[] { new ObjectPermission(privilegeType, permission.getGrantor(), permission.permissions) });`", + "reference": "Can be replaced with `org.jkiss.utils.ArrayUtils#add`." + }, + { + "prediction": "I'm not sure this is the best way to do this. I think it would be better to do this synchronously, and then close the `ElectionContexts` stream in the `finally` block.", + "reference": "While we're here, this line (and a few others) should be `customThreadPool.submit(() -> IOUtils.closeQuietly(overseer);` I have no idea why we're creating a collection and a stream for a single object." + }, + { + "prediction": "I think we can remove the `clientID` and `clientSecret` fields from the `AzureDNS01` struct as well.", + "reference": "Should these restrictions also be reflected in the API docs?" + }, + { + "prediction": "Why do we need to restore the original request?", + "reference": "What about the request headers if someone uses `request_header`? :thinking:" + }, + { + "prediction": "I think this should be `deployment.Spec.Template.Spec.Containers[0].Args = append(deployment.Spec.Template.Spec.Containers[0].Args, fmt.Sprintf(\"--domain-filter=%s\", instance.Spec.ManagedDomains[0]))`", + "reference": "Verify that external-dns allows setting this parameter multiple times (that it's not \"last one wins\")." + }, + { + "prediction": "I think this should be `host1.example.com` instead of `host2.example.com`", + "reference": "Maybe 2 host/ip values could be used in the example?" + }, + { + "prediction": "I'm not sure this is the right place for this test. I think it would be better to move it to the `RateLimiter` test class.", + "reference": "We're only testing `RateLimiter.Allowed(Span)`, so I think we can use a mock `ITraceContext` instead of a real `Tracer` or `TraceContext`." + }, + { + "prediction": "`trainer->get_name()` should be `trainer->name()`.", + "reference": "IMO, this is the wrong way to associate a model with a trainer... Why the string when you actually have a trainer object?" + }, + { + "prediction": "I think this should be `ledger.store.block_exists (transaction, block_a.type (), hash);`", + "reference": "Wondering if we can directly put types here & for other similar ledger_processor items like rai::block_type::state" + }, + { + "prediction": "I think we should keep the progress bar, but we should not report the errors.", + "reference": "As `DeleteFiles` is not only used for prune this function deserves its own file. Maybe something like `delete_files.go` or `parallel.go`?" + }, + { + "prediction": "I don't think we need this anymore.", + "reference": "It should be simplified character. `` -> ``" + }, + { + "prediction": "This should probably be `int` instead of `-1`.", + "reference": "I am pretty sure it breaks the visitor pattern, visitor should have no knowledge about the structure of what it is visiting or control over visiting mechanism" + }, + { + "prediction": "`HashMap` and `TreeMap` are both `ConcurrentHashMap` implementations. I think it would be clearer to use `ConcurrentHashMap` and `ConcurrentSkipListMap` instead.", + "reference": "'A' instead of 'An' here" + }, + { + "prediction": "I'm not sure we should change this. I think it's fine to leave it as it was, but I'm not sure what the rationale is for changing it.", + "reference": "Can you flip it back (here and in other places)? It is more natural to represent \"10 seconds\" as `10 * time.Second`." + }, + { + "prediction": "I don't think you need to create a new data here, you can just use the existing one.", + "reference": "Why was this necessary? You should just use the `dask_classifier` defined below this. With this change, you'd only be doing the local predict on arrays each time, but we want to test on all of DataFrame, Array, and sparse matrix." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `app/views/shared/_checkouts.html.erb`", + "reference": "To me, this is sort of weird to have a completely separate page for this. Can we extract the different stuff (github, videos, downloads) presentation from the top of `app/views/purchases/show.html.erb` and reuse it on this page. I worry that we'll change things with fulfillment or copy and have to change it in multiple places." + }, + { + "prediction": "This import is not needed.", + "reference": "Please revert the lines above. Not touching unrelated code keeps the git history clean." + }, + { + "prediction": "I think this file should be removed.", + "reference": "`short_version` and `version_info`" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `Task` struct itself.", + "reference": "This is supposed to be `status`. Why did you change this?" + }, + { + "prediction": "I think this is the wrong file. It should be `pkg/apis/core/internalversion.go`", + "reference": "I will change all of these at some point next week." + }, + { + "prediction": "Why is this needed?", + "reference": "I made this change because, while trying to debug, in Visual Studio, the `IntegrationSignatureTests`, this property getter was hit and interfered with my ability to complete the debugging." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `Deployment` resource itself.", + "reference": "nit: `\"Unexpected error while calculating: unable to convert %T to %T: %v\"`" + }, + { + "prediction": "I think this should be renamed to `applicationName` instead of `appName` to be consistent with the rest of the API.", + "reference": "I'd actually recommend not putting this in the `SampleConfig`, it's intended more for properties that are inherent of the discovery format. Add a method `getSampleAppName(String apiTypeName)` to `SampleNamer` and override it in the language specific `SampleNamer`s if needed. Then assign it in the transformer." + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should go in `src/service/url-replacements-service.js`", + "reference": "Do we need to export these new functions? I thought the plan going forward was to keep util imports separated to make circular imports less likely and possibly do better chunk splitting. Since only new code references these files, we can scope the import to the specific files." + }, + { + "prediction": "Layout/TrailingWhitespace: Trailing whitespace detected.", + "reference": "Rails will autorequire `acts_as_editable` once it encounters the constant `ActsAsEditable`. Thus if we move `ActiveRecord::Base.send :include, ActsAsEditable` from _acts_as_editable.rb_ to this file, the require line will not be needed anymore. Instead of requiring the file ourselves, we will let Rails do it for us. This fix will also remove the need to explicitly require `acts_as_editable` in _mock_active_record_base.rb_." + }, + { + "prediction": "I think this should be `public abstract String upperCamelMethodName();`", + "reference": "I think we should name this `grpcMethodName` or similar. That is what this refers to, right? The fact that it is upper camel is an implementation." + }, + { + "prediction": "I'm not sure this is the right place to do this validation. I think it should be done in the `xfpga_fpgaTokenReadObject` function.", + "reference": "What if .. appears, but not as the first character, eg \"errors/../../../../../../../../../../../\"?" + }, + { + "prediction": "I think this should be `owned by an organization, of which the user is a member`", + "reference": "Thanks, this should make things a bit easier for people who pick up the codebase but aren't a `curation center`" + }, + { + "prediction": "I don't think we should be deprecating any of the static fields in this class.", + "reference": "why not removing it?" + }, + { + "prediction": "I think it would be better to use `FlagTLSEnableHostVerification` and `FlagTLSDisableHostVerification` instead of `FlagTLSServerName` and `FlagTLSDisableHostVerification`.", + "reference": "same nit here: maybe word as - \"disables validation of the temporal cluster's server certificate\"" + }, + { + "prediction": "I think this should be `sql(\"SHOW TABLES\")` instead of `sql(\"show tables\")`", + "reference": "Nit: other statements use all caps for SQL reserved words. Should this be `SHOW TABLES`?" + }, + { + "prediction": "I think this should be `|| c == '.' || c == ':'` instead of `|| c == '.' || c == ':' || c == '.' || c == ':'`", + "reference": "Do we need this? isLuaIdentifier() is used not only in extract_next_token() but also in extract_prev_toke(). I wonder whether the change for isLuaIdentifier() has an impact on extract_prev_toke() or not. If you are not sure, keep isLuaIdentifier() as is. If you are sure, could you write your conviction to the commit log." + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in `ConfigureDefaultMTUs` since we're setting `Wireguard.EncryptHostTraffic` and `c.Wireguard.MTU`", + "reference": "This line should actually be: `if c.KubernetesProvider == config.ProviderAKS && c.Wireguard.EncryptHostTraffic {` because we only need to tweak the MTU like this on AKS." + }, + { + "prediction": "I think we should rename this to `serviceFlagDescription` to be consistent with the other flags.", + "reference": "Do we need to change this flag as well?" + }, + { + "prediction": "I think this should be `module.exports = file;`", + "reference": "Including the source twice here makes the filesize jump to 432kb. Is there any way to minimize repeating it?" + }, + { + "prediction": "I think this should be `setParameter('nameOrHandle', nameOrHandle)`", + "reference": "This should only be sent if the driver is speaking to a W3C conformant remote, so we need an if-condition check like we have in the Python bindings." + }, + { + "prediction": "I think this should be `target['variables']` instead of `target['variables']`", + "reference": "Only one line of code? What a simple issue!" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `rateLimiters` section of the config.", + "reference": "Conceptual question: why do history and matching need throttler at all? Shouldn't throttling to be handled on FE only?" + }, + { + "prediction": "I think we can remove the `enqueueAppliedToGroup` parameter from this function.", + "reference": "Would this be possible: `addCNP` has already processed the CNP to an internalNP, just hasn't added this internalNP to the `internalNetworkPolicyStore`. In this case, `reprocessCNP` will skip processing this CNP and `addCNP` will just add the \"old\" internalNP to `internalNetworkPolicyStore`." + }, + { + "prediction": "Metrics/LineLength: Line is too long. [122/120]", + "reference": "Minor: you can access `current_user` in here directly - don't need to pass it in. Unless you prefer passing it explicitly?" + }, + { + "prediction": "I think this should be `attributes = attributes&.to_h if attributes.respond_to?(:keys) && attributes.keys.present?`", + "reference": "What is the purpose of `&` on this line?" + }, + { + "prediction": "I think this should be `^[a-zA-Z0-9][a-zA-Z0-9-]*$` instead of `^[a-zA-Z0-9]+$`", + "reference": "See above, the `isValidWebDataStreamID` implementation from before is actually correct. What we need here instead is a new `isValidMeasurementID` function." + }, + { + "prediction": "I think this should be `if err != nil` instead of `if err != nil && c.flags.isSet(infoReceived)`", + "reference": "Should be an error... it is important for the admin of the server attempting to create the leafnode connection to see the error asap." + }, + { + "prediction": "I'm not sure this is the best way to do this, but it's the only way I could come up with that worked.", + "reference": "Could you split these conditions up over multiple lines please." + }, + { + "prediction": "I think we can remove the `tag` field from the struct now, since it's no longer used.", + "reference": "I think we can just change this to `Split` instead of `SplitN`. I don't think we need to limit the number of parts in the tag." + }, + { + "prediction": "I think we can remove the `{{ .dbaport }}:{{ .dbaport }}` portion of this line.", + "reference": "So this is actually a mistake that I introduced without realizing it, and have known would need to be fixed when we get here . The format of the ports directive is \"host:container\". We only want the host port to change, not the internal container ports. The ports variable probably needs to be a map which maps external -> internal ports." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it's the only thing I can come up with.", + "reference": "An alternate approach would be to always initialize shardInfo with a dummy (non-nil) value, which could protect against other uses before it's initialized (I couldn't find any though). But I can change it to do it that way instead." + }, + { + "prediction": "I think this should be `NodeMetadata struct{ LastWriter keybase1.UID }` and not `NodeMetadata struct{ LastWriter keybase1.UID }`", + "reference": "Maybe we can just put the entire `DirEntry` in here? I can imagine it might be useful for debugging to get the block ID/refnonce, encrypted size, key gen, data version, etc. What do you think?" + }, + { + "prediction": "`c->maximized` is a boolean, so `c->maximized_vertical` and `c->maximized_horizontal` should be `c->maximized_vertical || c->maximized_horizontal`.", + "reference": "For the commit message: The paragraphs seem to be out of order? The `Would not work because` refers to the stuff before, but there is a `This may seem pointless, but` in-between." + }, + { + "prediction": "I think we can remove `influxdata/influxdb` from the `prelude`.", + "reference": "Why did you remove these packages from the prelude, will your new functions not work without this change?" + }, + { + "prediction": "nit: you can use `std::vector`.", + "reference": "We'd better reserve enough space before using kvKeys to avoid extra malloc." + }, + { + "prediction": "I think we can remove this function as it's not being used anywhere.", + "reference": "would it make sense to return empty or error if label doesn't exists?" + }, + { + "prediction": "I think we should use `setTimeout(attemptRm, attemptTimeout);` instead of `attemptRm();`", + "reference": "Don't penalize everyone with 250ms delay b/c some machines have problems." + }, + { + "prediction": "I think this should be `\"\"` instead of `\"{\"`", + "reference": "Probably want a space after the second %s?" + }, + { + "prediction": "I think this should be `Unavailable` instead of `UnavailableError`", + "reference": "This seems like an internal error still?" + }, + { + "prediction": "Block has too many lines. [29/25]", + "reference": "Line is too long. [94/80]" + }, + { + "prediction": "I'm not sure if this is the best name for this. I think it's better to call it `AntreaClusterIdentity` or `AntreaClusterUUID` or something like that.", + "reference": "out of curiosity, why creating another struct to wrap it?" + }, + { + "prediction": "Please use `std::chrono::minutes`, `std::chrono::seconds`, `std::chrono::duration_cast`, `std::chrono::duration_cast`, `std::chrono::duration_cast`, `std::chrono::duration_cast`, `std::chrono::duration_cast`, `std::chrono::duration_cast`, `std::chrono::duration_cast`, `std::chrono::duration_cast`, `std::chrono::duration_cast`, `std::chrono::duration_cast`, `std::chrono::duration_cast`, `std::chrono::duration_cast`, `std::chrono::duration_cast`, `std::chrono::duration_cast`, `std::chrono::duration_cast`, `std::chrono::duration_cast`, `std::chrono::duration_cast(TestUtils::initKV(rootPath.path(), partitions, {0, network::NetworkUtils::getAvailablePort()}))`", + "reference": "You can avoid changing the code if there are parameter defaults. right ?" + }, + { + "prediction": "I'm not sure this is the right place for this test. I think it should go in `test/utils.js`.", + "reference": "I wonder why the newline disappeared here? I guess we'll merge and see how SauceLabs fares across the supported browsers." + }, + { + "prediction": "This should be `if (world_repop > 0)`.", + "reference": "I know this is legal, but I prefer we put brackets on our calls" + }, + { + "prediction": "I'm not sure if this is the right place to put this sample. The `AmazonIamService` class has a `deleteServerCertificate` method, which is used to delete a server certificate. The `AmazonIamClient` class has a `getServerCertificate` method, which is used to retrieve a server certificate. The `AmazonIamPermissionsClient` class has a `getServerCertificatePermissions` method, which is used to retrieve the permissions associated with a server certificate. The `AmazonIamRoleClient` class has a `getRole` method, which is used to retrieve a role associated with a server certificate. The `AmazonIamUserClient` class has a `getUsers` method, which is used to retrieve a list of users associated with a server certificate. The `AmazonIamOrganizationClient` class has a `getOrganizations` method, which is used to retrieve a list of organizations associated with a server certificate. The `AmazonIamPolicyClient` class has a `getPolicy` method, which is used to retrieve a policy associated with a server certificate. The `AmazonIamProgramClient` class has a `getPrograms` method, which is used to retrieve a list of programs associated with a server certificate", + "reference": "AWS Identity and Access Management (IAM)" + }, + { + "prediction": "I think this should be renamed to `NoSuchInterceptingElement` instead of `InterceptingElementException`.", + "reference": "We keep who wrote the code anonymous." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I could come up with that works.", + "reference": "Two things to make the code more error-proof and simplify it: 1. To be safe, this should be: `! isUndefined( decimal ) && ! isUndefined( decimal.value )` 2. The other clause that you changed below can be combined with that since `decimal` isn't used anywhere else, and so there's no point to re-check whether it's not undefined. In other words, this should become: `! isUndefined( decimal ) && ! isUndefined( decimal.value ) && 1000 > number`, and then you can remove the `decimal = decimal.value` assignment and replace it with line 146 (assignment of `readableNumber`)." + }, + { + "prediction": "I think it would be better to have a separate `OutboundOptions` interface, and have the implementation of `Outbound` implement `OutboundOptions` and have the `Options()` method of `OutboundOptions` return the `Outbound` object. This way, we can still use the `Transports()` method to get all the transports used by the outbound, and we can still use the `Options()` method to get all the options used by the outbound.", + "reference": "Wouldn't composite outbounds compose the transport, such that it would still be represented as a single transport?" + }, + { + "prediction": "nit: remove empty line", + "reference": "nit: there is no need for a new line here, usually we tend to put an object creation and its deferred deletion next to each other. It helps not forgetting about the cleanup." + }, + { + "prediction": "Why not using `Symfony\\Component\\HttpKernel\\Event\\GetResponseForRequestEvent`?", + "reference": "Feel free to use the full notation with my email address: `Maxime Steinhausser ` :smile:" + }, + { + "prediction": "I think it's better to use `fmt.Sprintf` instead of `\\r\\n\\r\\n`.", + "reference": "This was unused across the codebase" + }, + { + "prediction": "I'm not sure if we want to log the error here or not. If we want to log it, I think it would be better to log the error in `LookupAccount` and not `processConsumerAssignment`.", + "reference": "Should we put in which account we were trying to look up?" + }, + { + "prediction": "I think this should be `InventoryTypeClass`, not `InventoryIndex`.", + "reference": "either SUPPORTED_TYPECLASS or supported_typeclass. Camelcase only for class names." + }, + { + "prediction": "I think this should be `pinned INT NOT NULL DEFAULT 1`", + "reference": "This is not going to work. You need to add a migration to the database." + }, + { + "prediction": "I'm not sure what this method is supposed to do. It's not clear what it does.", + "reference": "Should these methods be renamed in this PR?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `MeterProviderBuilderSdk` class.", + "reference": "we need to include the `metricStreamName` which is invalid, so users know whats causing the issue." + }, + { + "prediction": "I'm not sure if this is the right approach. I think we should be able to load the pdb without having to specify the full path to the pdb file.", + "reference": "Please run Platform tests `DiaSessionTests`." + }, + { + "prediction": "I'm not sure this is the right way to do it. The problem is that we don't know how many of these prefixes we have, so we can't do a proper count. I think it would be better to do something like `AVX_512_PREFIXES_COUNT` or similar.", + "reference": "This is debug-build-only: we want a release-build notice. SYSLOG takes the name w/o the MSG and no _STRING. Args are via events.mc specifiers." + }, + { + "prediction": "I think this should be `callback(new Error('directConnection not supported with SRV URI'))`", + "reference": "is it possible to have both forms here? I was hoping we wouldn't be introducing more cases where we had to check the upper and lowercase version of URI options." + }, + { + "prediction": "I'm not sure this is the right place for this benchmark. I think it should be in `test/int64_histograms.go`", + "reference": "Does the name suffix hardcode something? Not clear how changing the name fixes this." + }, + { + "prediction": "I think this should be called `getQueueProcessorThreadStates` to be consistent with the other methods.", + "reference": "Is undispatched same as queued? getQueuedFlows?" + }, + { + "prediction": "I think we should keep the `connection info` tests here, but rename them to be `site info` tests. The `connection info` is a bit misleading because it's not really about the connection info itself, but about the site itself.", + "reference": "See above, same for all similar cases below." + }, + { + "prediction": "I'm not sure this is the right place for this test. I think it would be better to move this test to `test/SingleImageImportLoggableBuilder_test.go`", + "reference": "Why is this done twice?" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "This sync can ensure that the condition of the child node is consistent with the parent node, but I still don't understand when the child will be overwritten, and this behavior is not what we expected?" + }, + { + "prediction": "I think this should be `DEBUG_TEST_FAILURE=true` instead of `DEBUG_TEST_FAILURE=true`", + "reference": "This was renamed to avoid any confusion with the more general case of debugging via `plz debug`" + }, + { + "prediction": "I think this should be `Math.min(((String) val).length(), prefixLength)` instead of `Math.min(((byte[]) val).length, prefixLength)`", + "reference": "String valStr = (String)val; valStr.substring(0, Math.min(valStr.length(), prefixLength)) Make it clean." + }, + { + "prediction": "I think it would be better to use `enum_def->type` instead of `BASE_TYPE_NONE` here.", + "reference": "Sorry, this still makes no sense.. the value of any union or enum is simply a name integer constant, it has nothing to do with the `BASE_TYPE_` enum. This value should be `0`. In particular: `Every union has the NONE field, which always has value 0`." + }, + { + "prediction": "I think we should move this method to AzkabanClient.", + "reference": "Looks like getAzkabanURL() is added after concrete Alerter (Emailer)::getAzkabanURL(), so that Override annotation is needed." + }, + { + "prediction": "I think this should be `if mask.dtype == torch.bool:`", + "reference": "The above 3 lines can be written as: `mask = segms[i].astype(bool)`" + }, + { + "prediction": "nit: I think it would be better to move this file to `pkg/` and rename it to `address.go`", + "reference": "File is not `gofmt`-ed with `-s` (from `gofmt`)" + }, + { + "prediction": "I think this should be `logger.always_log (boost::str (boost::format (\"Node started with peering port `%1%`\").format (network.port)));`", + "reference": "Thought it's good to have this logged down so that we can check the used value in the logs." + }, + { + "prediction": "I'm not sure if we want this to be optional or not. If we want it to be optional, I think we should add a `omitempty` so that it doesn't get written to the response if it's not set.", + "reference": "I don't think you can call this optional unless it's a pointer - remove this?" + }, + { + "prediction": "I think you can use `listSaveProduct.isEmpty()` instead of `listSaveProduct.size() == 0`", + "reference": "@naofum please use `isEmpty`method instead" + }, + { + "prediction": "I think this is the only place where `nullable_handle` is used, so I think it should be removed.", + "reference": "i think this is unrelated and needs to be reverted. need to discuss at sync." + }, + { + "prediction": "I think this class should be renamed to `ProcessableBlockHeaderWithParentHash`.", + "reference": "Are we eventually moving those type interfaces from plugin project to datatype project? If not, then we'd have a dependency from core onto plugins, which seems a little counter-intuitive to me." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `models/index.js` file, since that's where the models are defined.", + "reference": "Love how we can finally use async/await in the codebase." + }, + { + "prediction": "This should be `wallet_representative_update_existing_accounts`.", + "reference": "Very minor: this line could be moved to a more narrow scope, inside `if (!representative.decode_account (representative_text))` Other than that, LGTM" + }, + { + "prediction": "I think we should rename this to `Active` or `Present` to be consistent with the other variables.", + "reference": "when is this consumed? I'm probably missing it but I can't find it right now" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we need to make sure we don't generate the wrong cache key for a rollup. I think we need to make sure we don't generate the wrong cache key for a rollup. I think we need to make sure we don't generate the wrong cache key for a groupby. I think we need to make sure we don't generate the wrong cache key for a groupby. I think we need to make sure we don't generate the wrong cache key for a groupby. I think we need to make sure we don't generate the wrong cache key for a groupby. I think we need to make sure we don't generate the wrong cache key for a groupby. I think we need to make sure we don't generate the wrong cache key for a groupby. I think we need to make sure we don't generate the wrong cache key for a groupby. I think we need to make sure we don't generate the wrong cache key for a groupby. I think we need to make sure we don't generate the wrong cache key for a groupby. I think we need to make sure we don't generate the wrong cache key for a groupby. I think we need", + "reference": "I think we also need to add the rollupGroupExprList() to the cache key. If we rebuild the list above from a ValueIdSet on line 418 above, it is probably going to be in the same order, regardless whether it was ROLLUP(a,b) or ROLLUP(b,a)." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `com.google.api.tools.framework.model.Field`", + "reference": "can use `getParamTypeName` instead" + }, + { + "prediction": "I think this should be `&& $this->request->query->has('property') && $this->request->query->get('property') !== ''`", + "reference": "Why send the parameters? They're accessible directly from `$this->request` so there's no need to inject them in the method" + }, + { + "prediction": "I'm not sure this is the right place for this method. I think it should go in `QWebPage`.", + "reference": "Tiny nit: I would prefer `not selected_file` or `len(selected_file) == 0`, as if choose_file starts returning, for example, tuples instead of lists, this won't break." + }, + { + "prediction": "Why do we need to remove the name file if a duplicate node name is used?", + "reference": "How will this code behave with hostnames that contain hyphens?" + }, + { + "prediction": "I'm not sure this is the right place to add this column. I think it should be in the `SmallMoleculeTransitionListColumn` class.", + "reference": "I think this is redundant since \"NullForEmpty\" already calls \"Trim()\"." + }, + { + "prediction": "Should this be a `CloudBackupRestoreRequest` instead?", + "reference": "Change this to IDs too?" + }, + { + "prediction": "I think this should be `ImmutableSet.of(\"SCPFCCSPCF\", \"CSPFCCCSSF\", \"SCFPCSCPCF\", \"PCSFCPCSCF\", \"SCCFCPSCF\", \"SCPFCCCSSF\", \"PCSFCPCSCF\")`", + "reference": "private static final, and it should be located in raidsoverlay, as it's not needed in the plugin. also the name could be a bit better, DC_SCOUT_RAIDS or similiar." + }, + { + "prediction": "I think this should be 126, not 127.", + "reference": "attr_value is 128 bytes?" + }, + { + "prediction": "I think this should be `self.method = self.config.get(\"method\", \"GET\") or self.method.upper()`", + "reference": "if it's unpredictable - why uppercase it at all?" + }, + { + "prediction": "Why do we need this?", + "reference": "Please remove all these debug prints. It doesn't look good." + }, + { + "prediction": "I think this should be called `SampleRandomness` and not `SampleChainRandomness`", + "reference": "Consumers of this interface should not be required to provide `sampleHeight`. This should be an expected consensus parameter." + }, + { + "prediction": "I think you can remove the `if closeTime.Before(startTime)` here.", + "reference": "I don't believe this is the right fix. If startTime comes after closeTime, then it means some other event triggered invocation of this code path like workflow timeout. In this case we should still try to fire the cron on previous value so we should just return start the delta between startTime and closeTime immediately." + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should go in `cloud/backup` since it's a specific type of backup request.", + "reference": "Not sure if we need tag here, it is an implementation detail in portworx that isn't exposed in openstorage" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `SolrFields` class, since that's where the `SolrField` interface is defined.", + "reference": "I wonder if it would be cleaner to refactor all of this similar to the SolrMarc driver, so we have a property with Summon field names associated with types, and we iterate through it in a loop... that way we don't have to repeat the loop code four times with different variable names." + }, + { + "prediction": "I think this should be `getCoreContainer().getSolrClientCache()` instead of `getCore().getCoreContainer().getSolrClientCache()`", + "reference": "Need the `solrClientCache.close();` further down in the method be removed since a shared cache is now used?" + }, + { + "prediction": "I think this should be a `uint64` instead of an `int64`.", + "reference": "according to the PR (schema changes?) these 2 field should be removed?" + }, + { + "prediction": "Can we use the same name for the container name?", + "reference": "Panic here if `exp.Target.StressChaos.CintainerName` is nil." + }, + { + "prediction": "I don't think this is the right place to do this. I think it should be in the scorer iterator itself.", + "reference": "This allows for some hacks like returning an iterator that matches more docs than the scorer. I liked the previous approach that returned an iterator better." + }, + { + "prediction": "nit: remove the `TODO`", + "reference": "Aren't there already logs for this from the underlying file system implementation?" + }, + { + "prediction": "I don't think this is the right place for this change.", + "reference": "It would be good to have a test in here that demonstrates the new munge functionality; I can help set that up if you're not sure how." + }, + { + "prediction": "I think this should be `max_retries_to_get_pods` instead of `max_retrials_to_get_pods`", + "reference": "`retrials` isn't the word you intend. I think you mean `retries` and to that end, can the var name just be `max_retries`?" + }, + { + "prediction": "I think we should add this help message to `ProductMetaTitle` as well.", + "reference": "Value in product should contain 255 characters or less." + }, + { + "prediction": "I think we can remove the `config` variable and use `configs[i].Consensus.RollDPoS.Delay` and `configs[i].Consensus.RollDPoS.ProposerInterval` directly.", + "reference": "line is 133 characters (from `lll`)" + }, + { + "prediction": "I'm not sure if this is the right place for this, but it seems like it should be in `custom_options_file?` and not in `file_options`.", + "reference": "since we're calling the file .rspec-local, I think we should rename local_options to project_options and use local_options for .rspec-local - WDYT?" + }, + { + "prediction": "I think this is the only place where we're using `connection_config.merge(adapter: connection_config[:http_adapter])`", + "reference": "Will we want to refactor this when we drop rsolr 1.x support?" + }, + { + "prediction": "I think we should rename this function to `getNodeNamedCrtFromIP` or `getNodeNamedCrtFromIPString` to be consistent with `getNodeNamedCrtFromNode` and `getNodeNamedCrtFromNodeFile`.", + "reference": "should this really be multiple IPs?" + }, + { + "prediction": "I think this should be a `render_to_string` instead of a `render partial: \"proposal\"`.", + "reference": "Hmm, is that partial used in multiple places? Maybe we can just move that file in here." + }, + { + "prediction": "Nit: I think we can remove this file since we don't need it anymore.", + "reference": "Should be 2014-2016" + }, + { + "prediction": "I'm not sure this is the best way to do this, but it's the only way I could come up with that worked.", + "reference": "Looks like my fault for sure in trying to handle international inputs regardless of locale. I think the correct fix is actually to get rid of TrySplitColumns and use ParseDsvFields instead. It is what gets used in the end, and it already has logic for dealing with quoted fields." + }, + { + "prediction": "I think this should be `done().then(cursors[0].close);`", + "reference": "similarly here, are the these cursors not being closed when the client is closed?" + }, + { + "prediction": "I think this should be `map[string]Policy` instead of `map[string]func(string) Policy`", + "reference": "Or maybe `func(args ...string) Policy` to make it dynamic in case of any future policy that may require more than one args." + }, + { + "prediction": "I think this should be done after the journal server has been created. If journal server is not created, then we won't be able to create the journal server.", + "reference": "Should this happen even if the above failed?" + }, + { + "prediction": "I'm not sure if this is the right place for this file.", + "reference": "Please dont change this ." + }, + { + "prediction": "I'm not sure this is the right place to log the confirmed blocks. The confirmed blocks should be logged in the `confirmed` field of the `Election` object.", + "reference": "There is a strange $b that looks wrong." + }, + { + "prediction": "I think this should be `containerContainsText = _(\"with %s items\") % childControlCount`", + "reference": "Is it still important to have `speakEntry` here? It is checked before this value `containerContainsText` is used in the \"General\" section." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do it in the `Travis::Poller` class.", + "reference": "It is `$JAVA_HOME/bin`, not `$JAVA_HOME`, which should be added." + }, + { + "prediction": "This should be `#include ` instead of both `#include ` and `#include `.", + "reference": "Should move this to within the `#else` block as it's only used there." + }, + { + "prediction": "Shouldn't we wait for the page to be loaded?", + "reference": "is this a common rule to wait one extra second after ajax? I'm thinking about moving this extra wait into waitForAjax method." + }, + { + "prediction": "I'm not sure this is the best way to do it. I think it would be better to have the `logger` object be a property of the `SolrTask` class, so that the `logger` object can be passed into the constructor of the `SolrTask` class. This way, the `logger` object can be passed into the constructor of the `SolrTask` class without having to pass the `logger` object into the constructor of the `SolrTask` class.", + "reference": "Maybe you can correct the typo \"if\" too :)" + }, + { + "prediction": "I think this should be `IdentifyForChat(ctx, uid string, assertion, reason string) (UserInfo, *keybase1.IdentifyTrackBreaks, error)`", + "reference": "I'd prefer a name less chat-specific, since later on we could have other app types that want the same behavior. Maybe `IdentifyAndAllowTrackBreaks`?" + }, + { + "prediction": "I think this should be `MPI_COMM_WORLD` instead of `MPIMPIComm_Get`", + "reference": "I think I was involved in writing that caster, but I never fully understood the `import_mpi4py` thing. Why is importing mpi4py still necessary at that point? I would think if the user is passing a communicator from python code, they must already have imported mpi4py themselves, or does that not propagate through into the wrapping layer?" + }, + { + "prediction": "I'm not sure this is the right way to do this. I think we should just close the body here.", + "reference": "This seems like a more interesting change. Maybe we should re-name the PR" + }, + { + "prediction": "I'm not sure if this is the right place for this feature interface. I think it would be better to move it to the TransportConnection interface.", + "reference": "Nit: implement the methods for these interfaces explicitly in this file for consistency. It can be passthrough." + }, + { + "prediction": "Why is this needed?", + "reference": "Not directly related to your PR, but I think here we should create a Type enum (MAP, ARRAY, PRIMITIVE) instead of having 3 flags." + }, + { + "prediction": "I think it is better to use `std::this_thread::get_id()` instead of `Lng32`", + "reference": "Do you want this to be a stack variable? The work method might return at any time (example: when the parent queue fills up) and then get called again, which would cause this variable to become false again. I'm wondering if this variable should be a member instead?" + }, + { + "prediction": "I think it would be better to use `reinterpret_cast(spaceId)` instead of `static_cast(spaceId)`", + "reference": "You could reserve a const space to save the extra computation." + }, + { + "prediction": "I think this should be `\"/home/user/runtime/src/coreclr/runtime/src/libraries/System.Private.CoreLib/src/System/IO/..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//..//", + "reference": "Did you consider adding rooted paths like `C:\\ProgramData` and paths with flipped separators?" + }, + { + "prediction": "Why do we need this defer?", + "reference": "does this line cause a panic if it is above the if condition ?" + }, + { + "prediction": "I think it would be better to have this enum as a separate file. This way it's easier to see what's going on under the hood.", + "reference": "Maybe `LibraryDetailsPanelType` would be clearer." + }, + { + "prediction": "I think this should be removed.", + "reference": "minor nit - add \"persist-filesystem\" and \"persist-directory\" into commit message, as its something people may search on (maybe applies to a few other commit messages)" + }, + { + "prediction": "Why is this being removed?", + "reference": "I verified offline with @jeremyg-lunarg this should be removed." + }, + { + "prediction": "I think this should be `fmt.Println(\"incldued_wf name:\", i.Workflow.Name, \" timeout:\", i.Workflow.DefaultTimeout)`", + "reference": "This should be removed? If not, typo in incldued_wf" + }, + { + "prediction": "I'm not sure this is the best way to do it, but it's the only way I could get it to work.", + "reference": "Sorry for the delay on this! It looks like Circle CI isn't running tests on some of the PRs, but this doesn't look like it would work I might be missing something, but are the tests all passing locally?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `pkg/caddy/cmd/match/file.go`", + "reference": "Do you think the godoc should mention that all delimiters will be suffixed with `/`?" + }, + { + "prediction": "I think this should be `aURL.startsWith(\"data:\") && SessionStore.get().isCurrentSessionPrivate() && SessionStore.PRIVATE_BROWSING_URI`", + "reference": "what if I want to load my own, a different, data URI in Private Browsing mode? I do this often on desktop (e.g., `data:text/html,×`). admittedly, I wouldn't expect this to be done by a non-developer, but this will certainly cause a minor bug." + }, + { + "prediction": "I think this should be `long.MIN_VALUE` instead of `0L`.", + "reference": "I remember the sequence number 0 is kept for the data files for iceberg v1, so in theory the sequence number from delete files should start from 1. So setting it to 0 as the default value sounds correct." + }, + { + "prediction": "I think this should be `unsigned integer` instead of `integer`", + "reference": "For all these MYSQL queries unsigned is required. I have tested again and without unsigned these queries are failing." + }, + { + "prediction": "I think this should be `MAX_RECENT_HISTORY`, not `MAX_HISTORY`. Also, I think it would be better to call it something other than `stateUtils` since it's not really the responsibility of this file to own it. Maybe `stateCache` or `stateCache_` or something like that?", + "reference": "Are there tests for this? What happens when you get to limit?" + }, + { + "prediction": "I'm not sure this is the right place for this change. I think it should be in `data['config']['transport'] = 'remote' if target.name == 'localhost'`", + "reference": "Whole thing could be collapsed to `data['config']['transport'] ||= 'local' if target.name == 'localhost'`." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do it in the `OpenPGPKeyDialog` class.", + "reference": "maybe throw in `&& mServiceConnection.isBound()`, there are cases where the connection might die" + }, + { + "prediction": "This should be `IsEip1344Enabled => true;`", + "reference": "Can we add Istanbul with this first EIP please? (or as a separate issue)" + }, + { + "prediction": "I think this should be `return usr.Name` instead of `return nil`", + "reference": "I don't understand this change" + }, + { + "prediction": "This should be `self.showWarning(\"Invalid Public Key\")` instead of `self.show_warning(\"Invalid Public Key\")`", + "reference": "Let's allow translators for this string to be translated: `self.show_warning(_('Invalid Public key'))`" + }, + { + "prediction": "I'm not sure this is the best way to do this, but it's the only way I could get it to work.", + "reference": "This needs to work with `role=form` too." + }, + { + "prediction": "I think this should be `&& localConnection.type == 'value' && localConnection.outputType == 'output'`", + "reference": "This should be before the if on line 1028, which should turn into an else if" + }, + { + "prediction": "I think we can remove the `PodSelectorMatchExp` and `NSSelectorMatchExp` fields from the `ACNPRuleAppliedToSpec` struct.", + "reference": "Not really introduced by this PR, but I don't recall why these have to be pointers, while `PodSelector` / `NSSelector` do not. Do you know the reason?" + }, + { + "prediction": "I'm not sure this is correct. If the sendDelta is larger than the ackDelay, then we should be subtracting the ackDelay from the sendDelta, not adding the ackDelay to the sendDelta.", + "reference": "Is there a reason why we are ignoring the ackDelay if it would result in a value smaller than the min? Why not `max(sample - ackDelay, minRTT)`?" + }, + { + "prediction": "I think we can remove the `SarifLogEqualityComparer` class and just use the `IEqualityComparer` interface.", + "reference": "Here's an example of how the files in the `NotYetGenerated` directory drifted out of sync from the generated files. When we made the equality comparers internal, we neglected to fix this one." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `guidance_admins` policy, since it's only applicable to admin users.", + "reference": "nice. we should do this elsewhere too. We have a lot of repeated stuff in the policies" + }, + { + "prediction": "I think this should be `None` instead of `(let y = None; y))`.", + "reference": "Small formatting thing, but can you remove the space before the semicolon?" + }, + { + "prediction": "Why is this change needed?", + "reference": "Not new, but nit: _writeLeng*th*." + }, + { + "prediction": "I think this should be `CheckComposeDockerCompose` to match the name of the function.", + "reference": "Our habit is to go ahead and put a description line (or more) in front of every function, not just non-test or exported functions." + }, + { + "prediction": "I think we can remove this line.", + "reference": "Remove this file from the PR" + }, + { + "prediction": "I think this should be `newName` instead of `newName.replace(Blockly.Variables.CLOUD_PREFIX, '')`", + "reference": "I think that for cloud variables, the default value in the prompt should be the variable name without the cloud prefix; this is slightly different from the scratch 2.0 behavior, but I think would ultimately lead to less confusion. Proposing code changes below:" + }, + { + "prediction": "I think this should be `wlr_pointer_init(wlr_pointer, libinput_device_config_tap_get_finger_count(libinput_dev));`", + "reference": "I think I would rather fish this interface through than use it as the basis for heuristics." + }, + { + "prediction": "I think this should be reverted, as it's not related to this PR.", + "reference": "Probably not worth making this line-ending change, since it is the only change to this file." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in `decode_opnd_memx0` instead of `decode_opnd_memx1`. The reason is that `decode_opnd_memx1` is only used in the `decode_opnd_memx0` function, which is called from `decode_opnd_memx1` and `decode_opnd_memx2`. If we move `decode_opnd_memx0` to `decode_opnd_memx1` and `decode_opnd_memx2`, then the `decode_opnd_memx1` and `decode_opnd_memx2` calls should be moved to `decode_opnd_memx0` instead of `decode_opnd_memx1` and `decode_opnd_memx2` respectively.", + "reference": "Is this the correct place for this assert? Does this routine rely on it being 64, or was this only for testing?" + }, + { + "prediction": "I don't think we should expose this API. It's not exposed in the protocol, and it's not used by the rest of the system.", + "reference": "No pb please" + }, + { + "prediction": "I think this should be `t.integer :subscriber_id, null: false` instead of `t.bigint :subscriber_id, null: false`", + "reference": "We need to add indexes here on both `subscriber_id` and `changeset_id` or things will quickly collapse as we build up subscribers ;-) What I would suggest is a unique index on `[:subscriber_id, :changeset_id]` which will also make duplicate entries impossible, and an ordinary index on `[:changeset_id]` for finding the subscribers to a changeset." + }, + { + "prediction": "I think this should be `return err` instead of `return nil`", + "reference": "use the context versions of everything, e.g. `PostMessageContext` and thread it through the functions. will save you a bunch of refactoring trouble later on." + }, + { + "prediction": "I think it would be better to keep this as it was before, and just add `Tuple[Type[\"Interface\"], ...]` to the docstring.", + "reference": "\"not to be used elsewhere other than\"" + }, + { + "prediction": "I think it would be better to have this as a `SparkParquetWriters` instance and pass it to the `ParquetWriters.buildWriter` method.", + "reference": "Thanks for the contribution, @coolderli ! I also think the newPosDeleteWriter need the properties setting ..." + }, + { + "prediction": "Line is too long. [82/80]", + "reference": "These additions seem unrelated to this change?" + }, + { + "prediction": "I don't think we should have this in the table properties. I think it should be part of the engine configuration.", + "reference": "Could we move this to a class for Hadoop configuration properties, like `org.apache.iceberg.hadoop.ConfigProperties`?" + }, + { + "prediction": "I'm not sure if this is the right thing to do. I think we need to keep the deletion of the experiment related events.", + "reference": "The related statements should also be deleted." + }, + { + "prediction": "I think this should be `self.build_list_params(params, policies, 'PolicyNames.member.%d', 'PolicyName.member.%d')`", + "reference": "Shouldn't this line be removed?" + }, + { + "prediction": "I think this should be `set(['TEAM', 'PUBLIC'])`", + "reference": "Just move this into `const.py`. It already has similar stuff. Also, make it uppercase since it's a const." + }, + { + "prediction": "I'm not sure this is the right place to set the new mode. I think it would be better to set the new mode in the `setPasscode` method of `PasscodeActivity`.", + "reference": "Issue is that `currentMode = newMode;` is called at the end of the method. Passcode screen will come up, but since the activity thinks current mode is biometric check we don't check passcode when submitted." + }, + { + "prediction": "Why 0.2 instead of 1.0?", + "reference": "Need change it back?" + }, + { + "prediction": "I don't think this is a good idea. I'm not saying you have to do anything about it, but I think it's a good idea to make it public.", + "reference": "Didn't we delete this file a while back because it isn't used but people think that it's a security vulnerability that it's checked in?" + }, + { + "prediction": "I think this should be `using Datadog.Trace.Extensions;`", + "reference": "nit: Looks like this can be removed now" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in the `Provision` function in `pkg/caddy/provision.go`", + "reference": "Can probably remove the lines above it too (L60-62), since ProvisionDefaultCA() makes sure the map isn't nil." + }, + { + "prediction": "I'm not sure this is the right way to do it. I think we need to do this in a way that is consistent with the rest of the config system.", + "reference": "Do you think it's worth erroring out? It's likely that this is a configuration error that the user might want to know about?" + }, + { + "prediction": "I think this should be `# FIXME: find out why this is broken`", + "reference": "I think the functional test should not change here, this is probably a test in itself :)" + }, + { + "prediction": "I think we can remove this.", + "reference": "Why this to be a public function?" + }, + { + "prediction": "I'm not sure why this is called `timing` but it's the only option I can think of that makes sense.", + "reference": "I think we can remove the timing for export env vars" + }, + { + "prediction": "Why do we need to remove this?", + "reference": "wrong import grouping" + }, + { + "prediction": "I'm not sure this is the right fix. The problem is that the `PreferenceController` uses the `PreferenceActivity`'s `getResources().getStringArray` method to get the string array, and the `PreferenceActivity`'s `getStringArray` method returns a copy of the same string array. So the `PreferenceActivity`'s `getResources().getStringArray` method will always return the same string array, no matter what the `PreferenceController` uses to get the string array.", + "reference": "There is a doubled semicolon ;)" + }, + { + "prediction": "Shouldn't this be `#include \"openssl/sha.h\"`?", + "reference": "I'm wondering why this isn't . Seems like one would have to copy the md5.h file into the source tree somewhere for this to compile cleanly. Maybe you meant to use angle brackets instead of quotes?" + }, + { + "prediction": "I don't think this is a good name for this class. It's not just checking that an element is visible, it's checking that an element is visible and interactable. I think something like `expect_any_element_is_interactable` would be better.", + "reference": "shouldn't **call** return a boolean?" + }, + { + "prediction": "This should be `static_cast(casting_spell_slot)`, not `static_cast(-1)`.", + "reference": "We don't need to cast to client here. (well, from spell gem not AA etc) We should also make sure the charm is a casted spell before calling SendSpellBarEnable." + }, + { + "prediction": "I think this should be a `DateTime(timezone=True)`.", + "reference": "This is not an `id`. This should either be `invocation_time` or `invocated_at` to be consistent with what we are using elsewhere, and also to better rerflect the column's DateTime type. Also, within the context of this table, there is no idea of what `invocation` is. I know that `scanner` may not be future-proof, but we need to find something more descriptive. Perhaps one possibility is to call this `audit_time`." + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in `types.go` since it's only used there.", + "reference": "should the 'Receiver' be the clawback address in case of clawback transaction?" + }, + { + "prediction": "I think this should be `controllerStatusOk` and `volumeStatusOk` should be `controllerStatus` and `volumeStatus` respectively.", + "reference": "@ashishranjan738 -- Where are these consts used? in which pkg?" + }, + { + "prediction": "I don't think this should be in the autodoc docs.", + "reference": "The only change I would suggest is moving these lines back below the `templates_path` variable to keep the diffs smaller." + }, + { + "prediction": "I think this is the only place where `Info` is used, so I think it's fine to remove this line.", + "reference": "Having it above kept the block info in the cached changes, which could end up confusing things quite a bit." + }, + { + "prediction": "I'm not sure why this was removed, but I'm pretty sure it's because we're now using the `execute_task` method to run the task.", + "reference": "If the execute_task returns an `ExecutionResult`, the passing of a block would be unnecessary. Instead, the `ExecutionResult` could be presented to the user in some standardized way (iterating over the result of each node, etc.)." + }, + { + "prediction": "I think this should be `defer c.bridge.Connect(maxRetryForOFSwitch, make(chan struct{}))` instead of `if err := c.bridge.Connect(maxRetryForOFSwitch); err != nil {`", + "reference": "Not sure why we make a new channel here. If we don't use this channel, how about creating it inside the `Connect`?" + }, + { + "prediction": "I think it would be better to use `raft::raftctl` to set the `lastLogId` instead of using the `raftLock_` here.", + "reference": "There are two question here: 1. If you only modify lastLogId, but the `iter` is not modified, I really don't know whether we can succeed. 2. We will check the if the term has changed in `replicateLogs` (if rollback really happen, the term must have been updated), so I really doubt whether the problem should be fixed in this way. Or you could describe it in more details." + }, + { + "prediction": "Why do we need to do this?", + "reference": "Hello @jDolba, I have reviewed your PR and I found one problem. `$step->getFormType()` can return `FormTypeInterface`. You cannot use interface as key for an array. Can you find some better way to fix this? Thank you." + }, + { + "prediction": "Can you add a newline at the end of this line?", + "reference": "i was confused by keyword \"inventory\" here. my understanding is this starts the osconfig-agent which covers inventory lookup and package-management(correct me if i am wrong)." + }, + { + "prediction": "I don't think we need to add any new capabilities here. We already have them in the existing capabilities.", + "reference": "These are really meant to be the keys in the capabilities, not the keys of values within the capabilities" + }, + { + "prediction": "Nit: `import * as sinon from 'sinon';`", + "reference": "This breaks tests on IE because this will import an `esm` bundle. For that reason `sinon` is available as a global in our test suite and never imported. The global is aliased to the proper `es5` file." + }, + { + "prediction": "I think this should be `maxRTOTimeout` instead of `maxRTOTime`", + "reference": "Maybe move all the Loss Recovery constants to a separate file." + }, + { + "prediction": "I think this should be `diskName`, not `diskName string`.", + "reference": "this field is added so that we can find disk name by device name from attachments" + }, + { + "prediction": "Please remove this empty line.", + "reference": "Unnecessary new line" + }, + { + "prediction": "I think this should be `if _, ok := state.NamespacePaths[nsType]; !ok {` and not `if _, ok := state.NamespacePaths[nsType]; ok {`", + "reference": "First determine if the namespace already exists, so it's clearer that it's handling namespaces that aren't included in the `c.config.Namespaces`" + }, + { + "prediction": "I think we can remove the `class=\"assets-wrapper\"` and `class=\"videos-download-links\"` classes from the HTML as they are no longer needed.", + "reference": "What changed in the styles that means we don't need this?" + }, + { + "prediction": "I think this should be `JObject?` instead of `JObject` since it can be null.", + "reference": "This pattern should be applied to the other instance where NewtonsoftEscapeJProperty is used and you can remove the NewtonsoftEscapeJProperty method." + }, + { + "prediction": "I don't think we should be deprecating this. I think we should just warn the user.", + "reference": "Something to mention in the next changelog/release notes. It will be good to get histogram working consistently with everything else." + }, + { + "prediction": "I think this should be `{{ .Volume.runNamespace }}` and not `[{{.Volume.runNamespace}}]`", + "reference": "What does this contain? Is it PVC namespace or is it openebs?" + }, + { + "prediction": "I don't think we need this interface at all. We can just use `IRequestBodyMinimumDataRateFeature` directly.", + "reference": "Design note: Using local concrete data types on a feature abstraction makes it hard to generalize / replace. This is tolerable so long as this remains a kestrel exclusive feature, but we'd need a different design if this were ever moved to HttpAbstractions." + }, + { + "prediction": "`call_state` is not used in this function, please remove it.", + "reference": "this will break R package, you should update the R files accordingly. BTW, the call state should be in the last argument." + }, + { + "prediction": "I think this should be `array_merge($formats, array_keys($this->mediaPool->getFormatNamesByContext($mediaContext)))`", + "reference": "Shouldn't we throw an exception if the context is null instead ?" + }, + { + "prediction": "I'm not sure if this is the minimum version required by ddev, but I think it should be at least `1.10.0`.", + "reference": "These should both be const, not var right?" + }, + { + "prediction": "I think it's better to put `build_match_cost` in `registry.py` and `build_from_cfg` in `build.py`.", + "reference": "Rename the directory, match_costers -> match_costs" + }, + { + "prediction": "I think this test should be moved to `models_test.py` instead of `delete_model_test.py` since it's not related to the delete model functionality.", + "reference": "I don't think this should go in the model tests, since it is done in the resource. `PaginatedDeleteTest` seems more appropriate" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it's the only thing I can come up with right now.", + "reference": "It would be better to just change RWD to throw IllegalStateException if you attempt to execute a command after quit (unless it's a second call to quit())" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think we should move this to the `prometheus` package.", + "reference": "Could we move this to an example test to allow the compiler to help us ensure it stays up-to-date in the future?" + }, + { + "prediction": "I think we can remove this test now that we have `expect(cli.parse).to include(password: 'opensesame')` in the previous spec.", + "reference": "Maybe we could update these to use $future and then check on stderr? that way when we deprecate stdout we can not have to delete tests." + }, + { + "prediction": "I'm not sure about this change. I think we should keep the `MinAllowedMaxFrameSize` constant and use it for both `MinAllowedMaxFrameSize` and `(_maxFrameSize * 2) + HeaderLength`.", + "reference": "Remove this since it always has to be set afterwards." + }, + { + "prediction": "I think this should be `blockChangeSize(20*1024*1024)`, not `blockChangeSize(20)`", + "reference": "These two tests were causing us to use too many goroutines with `-race` using the default block change size, I think due to prefetching." + }, + { + "prediction": "I don't think this is a good idea. The `requestContext` is used by other methods in this class. If we pass it here, it will be used by all the other methods in this class. I think it would be better to move the `requestContext` into the `fetch` method and pass it as an argument to that method.", + "reference": "Is that `try..except` block really needed? I mean, when it could fail?" + }, + { + "prediction": "I think this should be `suspicious` instead of `suspense`", + "reference": "If you only want to run a specific group of tests you can always use `.only` like `it.only()` or `describe.only()`. It may not speed up the globbing process as much as this change here :)" + }, + { + "prediction": "I think this should be `DEFAULT_BATCH_SIZE = 100`", + "reference": "nit: I'd probably rename this to `BATCH_SIZE_RANGES`, to use a slightly more descriptive name." + }, + { + "prediction": "I think this should be 100, not 90.", + "reference": "aren't these the wrong way around?" + }, + { + "prediction": "I think this should be `getContainerConfigService`", + "reference": "Lets call this getConfigSetService and maybe rename the field now (or later)" + }, + { + "prediction": "I think we can remove `klogr` now, since it's not used anymore.", + "reference": "Could / should we make these constants and give them a type?" + }, + { + "prediction": "I think it would be better to have a `platforms` map instead of a list of strings.", + "reference": "lets stick with lowercase for consistency." + }, + { + "prediction": "I think we can remove this line.", + "reference": "ordering of imports went wrong" + }, + { + "prediction": "I think this should be `TableType.ALL_DATA_FILES` instead of `String.valueOf(MetadataTableType.ALL_DATA_FILES);`", + "reference": "I think these can all be .name() to get the value we are looking for" + }, + { + "prediction": "I think this test should be moved to a new file `FunctionCallTest::testPrintOnlyStringInvalidArgument()`.", + "reference": "Is this a good place for these test cases?" + }, + { + "prediction": "I think this should be `print(response_name, attr_name)`.", + "reference": "Did you mean to leave the print statement?" + }, + { + "prediction": "I think this should be `500000000` and not `500000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "reference": "I would do `new BN(Interpreter.LOCKTIME_THRESHOLD)`" + }, + { + "prediction": "I think this class is not needed anymore.", + "reference": "@ftomassetti I turned the tree walking algorithms into iterators so you don't have to visit every node when you only wanted a few, like for a `findFirst`." + }, + { + "prediction": "I think we can remove the `cadenceInternal:Timeout` prefix here.", + "reference": "Need to add type name here to be compatible with proto string representation." + }, + { + "prediction": "This should be `log.info`, not `log.finest`.", + "reference": "This is to let people know that the tooling is doing something during a build. Please leave." + }, + { + "prediction": "I think this should be `aaedca130273574dd2bd6c3acad57f3545b662a974fa4320236f25fe474676d`", + "reference": "Why is the principal changing here?" + }, + { + "prediction": "I think this should be `blob.core.*` instead of `blob.*`", + "reference": "Naming nit: let's use `AZURE_STORAGE_` prefix for consistency with the other ones." + }, + { + "prediction": "I think we can remove this `install` and `uninstall` methods.", + "reference": "I'm a bit confused. We have an actual `ProgressBar` Uppy React wrapper component that we are testing. Why do we need a mock for it?" + }, + { + "prediction": "I think we can remove this file, it's not used anymore.", + "reference": "can we use `github.com/pkg/errors`?" + }, + { + "prediction": "I think this should be `else if actualType.Kind() == semantic.Var {`", + "reference": "I changed the name of the arguments here just to help make the code clearer." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `ops/dynamic_map.py`, since that's where we want to memoize the return value.", + "reference": "I think either 'avoiding calls to the function' or 'to avoid calling the function ...' would be read better." + }, + { + "prediction": "I think this should be `const std::vector>&` instead of `const std::vector>&`.", + "reference": "@sfricke-samsung -- thanks. saves a few atomic ops which is always good :) The TODO is there to track that this object is storing *both* vectors of shared_ptr and plain pointers to the same data. The shared are to ensure scope, and the plain are for backwards compatibility with existing code that consumed a plain pointer vector (and some code that still does). That should be cleaned up." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `Nethermind.Monitoring.Metrics`", + "reference": "minor: typo (knowMetricsTypes -> knownMetricsTypes)" + }, + { + "prediction": "I'm not sure this is the right place to add this check. I think it would be better to add this check in `QRDescGenerator::typeSupported()` instead.", + "reference": "This adds a case-insensitive flag to the type in the RangeSpec, but I don't think RangeSpecs are written to handle case-insensitive comparisons. Take a look at the methods that deal with comparisons when building RangeSpecs, in file Range.cpp. So, I think you would have to do one of two things: a) disable the RangeSpec transformation for case-insensitive comparison operators (the easy way) or b) change the RangeSpec methods to handle case-insensitive comparisons." + }, + { + "prediction": "I think this should be `public static SymbolReference solveMethodInType(SymbolReference typeRef, String name, List argumentsTypes, boolean staticOnly, TypeSolver typeSolver)`", + "reference": "I would throw an exception if the type is not solved" + }, + { + "prediction": "I'm not sure if this is a good idea, but I don't have a better suggestion.", + "reference": "if remove `dt.skipLoad` - then this tests will run. You probably mean opposite?" + }, + { + "prediction": "Style/MutableConstant: Freeze mutable objects assigned to constants.", + "reference": "I feel like we do this in a lot of places should we move that out into its own PR?" + }, + { + "prediction": "I'm not sure this is the right place for this function. I think it should be moved to `blurhash.js`", + "reference": "Already asked you in Matrix, but I'll do it here again so it can be discussed publicly. Why?" + }, + { + "prediction": "This should be indented by 4 spaces, not 2.", + "reference": "I think here should be a comma before remove, in all the cases" + }, + { + "prediction": "I don't think this is the right way to do it. You need to check if `stages` is set in `context` before calling `self.bbox_roi_extractor = context.bbox_roi_extractor[stages]` and `self.bbox_head = context.bbox_head[stages]`", + "reference": "Single quote is used by default in this project." + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think we should be able to do it in the same way as we do for pods.", + "reference": "S1023: redundant `return` statement (from `gosimple`)" + }, + { + "prediction": "I'm not sure this is a good idea. I think we need to make sure that the webhook is closed before we close the context.", + "reference": "`ctx` is unused in Close" + }, + { + "prediction": "Why not use the parent class instead of creating a new one?", + "reference": "I'm confused. This exception is thrown when `HeurekaCategory` is not found in database. But this exception extends Http exception. Why? What has database search common with http? If the only reason is that it is the same in the whole project, then fine. But then we have even bigger problem - we don't know how to use exceptions." + }, + { + "prediction": "I don't think this is the right place to put this model. I think it should be in `models/`", + "reference": "Is it necessary to add the suffix `on_head`, because it belongs to` bbox_head`?" + }, + { + "prediction": "This should be `AC_DEFINE([WITH_MODERN_GRUB], 1, [Define if we have a GRUB version newer than 2.02])`", + "reference": "Hmm, I wonder if this should just be e.g. `--with-grub-2.02` instead. (Not sure Autoconf supports periods in these switches.) Today's modern GRUB is tomorrow's ancient GRUB. :) Or maybe we should be specific about the feature this is enabling, which might be safer given that each distro carries so many patches. E.g. `--without-grub-efi-16-suffixes`?" + }, + { + "prediction": "I think this should be `Client` instead of `daisyCompute.Client`", + "reference": "Add a GetSerialPortOutput method to Instance that way you don't need to access the client, also it makes the call cleaner as you don't have the odd i.Client and path.Base(i.Project), path.Base(i.Zone)" + }, + { + "prediction": "I'm not sure if this is a good idea, but I can't think of a better way to do this.", + "reference": "Line is too long. [104/80]" + }, + { + "prediction": "I'm not sure if this is the right place for this test. I think it would be better to move it to `testutil/testutil.go` since it's only used by `testutil/testutil.go` and it's not clear why it should be here.", + "reference": "Since CD updates (assignment & power state) are now done in this controller..." + }, + { + "prediction": "I don't think this is the right place to put this. I think it should be in the `Validate` schema option.", + "reference": "Hmm I'd rather not support this option going forward - it seems like a one-off just to work around this particular issue. Would it be fine to just remove the `deepStackTrace` option? The rest of the PR looks great - I love the idea of switching to sets." + }, + { + "prediction": "I'm not sure if this is the best name for this class. I think it should be `CommentCreator` since it's the main class that creates the `Comment` objects, but I'm not sure if there's a better name.", + "reference": "on the one hand I like how little this is doing. On the other hand, `inbound_mail_parser` is doing most of the work here so maybe it's not as helpful as I originally thought" + }, + { + "prediction": "I think we can remove the `eprosima::fastrtps::rtps::RTPSWriterPublishMode::ASYNCHRONOUS_WRITER` instantiation here.", + "reference": "This line is too long" + }, + { + "prediction": "I think this should be `fmt.Errorf`", + "reference": "This isn't a fatal error, we don't want to crash just because we can't set configs, we have sane defaults set" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it's the only thing I can come up with.", + "reference": "I wondered why `buffer` was passed into `LookupPath`. What is happening here? Is `buffer[:0]` equivalent to `[]V4TrieEntry{}`, and hence `buffer` isn't needed any more?" + }, + { + "prediction": "I think this should be `:href => user_url(@user_message_author, :host => SERVER_URL)` instead of `:target => \"_blank\"`", + "reference": "I don't really like the name of this file, especially the encoding of an implementation detail (the fact that it's a table) in the name. Can we just use `_message_body.html.erb` instead maybe?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `security.openshift.io` or `security.openshift.io/v1beta1`", + "reference": "Feel better not to expose our internal implementation in API/CRD, so no need to mention agent here. Consider: EnableLogging indicates whether or not to generate logs when rules are matched. Default to false." + }, + { + "prediction": "I think this should be `status = db->Put(writeOptions, NebulaKeyUtils::dataVersionKey(), \"3.0\");`", + "reference": "use `NebulaKeyUtilsV3::dataVersionValue()` to replace the literal value?" + }, + { + "prediction": "I think this should be `log.url.debug(\"URL contains characters which are not present in the current locale\")`", + "reference": "No need for the `\\` here, inside parentheses whitespace is ignored by Python." + }, + { + "prediction": "I think this test is failing because it doesn't have a valid certificate.", + "reference": "This doesn't seem like the right expected result... it should be the same as the `clientCert` var defined above." + }, + { + "prediction": "Why is this removed?", + "reference": "need to rename this now." + }, + { + "prediction": "I'm not sure why this is the case, but it seems to be the case. I'm not sure why this is the case, but it seems to be the case. I'm not sure why this is the case, but it seems to be the case. I'm not sure why this is the case, but it seems to be the case. I'm not sure why this is the case, but it seems to be the case. I'm not sure why this is the case, but it seems to be the case. I'm not sure why this is the case, but it seems to be the case. I'm not sure why this is the case, but it seems to be the case. I'm not sure why this is the case, but it seems to be the case. I'm not sure why this is the case, but it seems to be the case. I'm not sure why this is the case, but it seems to be the case. I'm not sure why this is the case, but it seems to be the case. I'm not sure why this is the case, but it seems to be the case. I'm not sure why this is the case, but it seems to be the case. I'm not sure", + "reference": "NIT: This shouldn't be a TODO. It is just a note isn't it?" + }, + { + "prediction": "I'm not sure this is the best place to put this, but I don't have a better suggestion.", + "reference": "I changed this to an error, that seems more appropriate than a warning here." + }, + { + "prediction": "I'm not sure if this is the best way to do this. I think we should be able to do something like: `if !l.IsEvmTransfer() && !l.IsEvmSend() && !l.IsEvmRefund() && !l.IsEthTransfer() && !l.IsEthSend() && !l.IsEthRefund() && !l.IsStakingTransfer() && !l.IsStakingSend() && !l.IsStakingRefund() && !l.IsInitiatorTransfer() && !l.IsInitiatorSend() && !l.IsInitiatorRefund() && !l.IsStakingTransfer() && !l.IsStakingSend() && !l.IsStakingRefund() && !l.IsInitiatorTransfer() && !l.IsInitiatorSend() && !l.IsInitiatorRefund() && !l.IsStakingTransfer() && !l.IsStakingSend() && !l.IsStakingRefund() && !l.IsInitiatorTransfer() && !l.IsInitiatorSend() && !l.IsInitiatorRefund() && !l.IsStakingTransfer() && !l.IsStakingSend() && !l.IsStakingRefund() && !l.IsInitiatorTransfer()", + "reference": "This change could mute unit test failure, but it is better to update unit tests" + }, + { + "prediction": "Shouldn't this be `holder.notificationId` instead of `notificationId`?", + "reference": "All other places that access `notificationIdsInUse` are in methods with descriptive names. We should do the same here. Maybe `markNotificationIdAsFree()`?" + }, + { + "prediction": "I think we can remove the `ErrNotFound` and `NotFoundErr` and just use `errors.New(\"tag not found\")` here.", + "reference": "keep as `ErrNotFound`, it is the same convention as in other packages" + }, + { + "prediction": "`offline_mode` is not a valid api parameter. Please remove it.", + "reference": "Same here, we need to call `callback` in else branch" + }, + { + "prediction": "I think this should be `certRecord.getHostName() != null ? certRecord.getHostName() : \"\";`", + "reference": "At this point we already check that the record is valid and so it could never be nulll" + }, + { + "prediction": "I'm not sure this is the right place to set the title. I think it would be better in the `before_action :set_default_title` in `UserController`", + "reference": "Would it not be more sensible just to move setting of the title to later in the method rather than duplicating it here?" + }, + { + "prediction": "`uploadSession` is called by `MetaClient::HeartBeatThread` and `MetaClient::HeartBeatThread` is called by `MetaClient::loadUsersAndRoles`, so this is redundant.", + "reference": "why not do it in `reclaimExpiredSessions`? and `pushSessionToCache` can delete" + }, + { + "prediction": "I don't think this is the right place for this model.", + "reference": "out_channels/num_outs/type are unnecessary" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but it seems like it should be possible to get the length of an object's keys.", + "reference": "You can create an issue for it and put it on the backlog so we don't forget it." + }, + { + "prediction": "I think this is the only place where we're using the container's HostConfig to determine whether or not to start the container in the first place. I think we should be able to get rid of that.", + "reference": "So now we are checking twice, both here and in `weaveCIDRsFromConfig`. Not great. I suggest changing the `ok` return of `weaveCIDRsFromConfig` to a messsage (or error?) instead, which we can then log." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `install` method of the `Package` class, since that's where the `Package` object is created.", + "reference": "An alternative to setting format to the default in Package.__init__ would be to set it in create_package. I think we can assume all packages are created by create_package, but not necessarily by build_package." + }, + { + "prediction": "Why do we need a random here?", + "reference": "Let's add fee recipient as well." + }, + { + "prediction": "I'm not sure what this is for, but it seems like it should be called `self._filename` instead of `self.filename`.", + "reference": "No need for those with `super-init-not-called`, as pylint already only turns things off for this function and it's needed for the entire function." + }, + { + "prediction": "I think this should be called `applicationName` and not `applicationName`", + "reference": "I think there's another spot for this in DefaultCapabilityMatcher" + }, + { + "prediction": "I think this should be `I18n.t(\"decorators.steps.waiting_text\", step: step.decorate.waiting_text)`", + "reference": "this name seems pretty vague -- thoughts on a more descriptive method name?" + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in `System.Net.Http.Headers` since it's related to HTTP headers.", + "reference": "what changed in this line?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it would be better to move it to the `AdminBar` component itself. The `AdminBar` component is the top-level component of the admin bar, and it should have access to the `Data` select component.", + "reference": "Instead of doing this let's add another function similar to `hasZeroData` for selecting the `reportArgs` since this is all sourced from selected values. Then `hasZeroData` can use this internally, as well as the component itself. Since this function would be internal just for the purpose of avoiding duplication, we don't need to expose it on the component the same way though." + }, + { + "prediction": "Why do you need this?", + "reference": "This line was useful for auto-completion, I think it should be re-added with specifying the var name (`$exception`) and simplifying the FQCN." + }, + { + "prediction": "I'm not sure this is the right way to do this. I'm not sure we want to block waiting for the channel to be closed. I think we want to close the channel when we're done writing to the channel.", + "reference": "This looks like you're not collecting everything from the error channel." + }, + { + "prediction": "I think we can remove `to: @checkout.user_email` as we don't have any plans for this user", + "reference": "This currently violates the Law of Demeter. Using `checkout.plan_name` is the quick resolution." + }, + { + "prediction": "Why did you change the type to `string`?", + "reference": "is there any scenario when `$temporaryFilename` can be null?" + }, + { + "prediction": "I think we can remove the `@SuppressWarnings(\"ReferenceEquality\")` here.", + "reference": "this is for the `boolean isRoot = root == rowType` check, which seems to be on purpose, but maybe you could double check whether using ref. equality here is still wanted? Same for `SparkTypeToType`" + }, + { + "prediction": "This should be done in `roots_drag_icon_update_position()`.", + "reference": "No need to damage after `roots_drag_icon_update_position`, this is already done in `roots_drag_icon_update_position`" + }, + { + "prediction": "`one_img` and `one_meta` could be replaced by `image` and `meta`?", + "reference": "Have you tested exporting to ONNX with `device=cuda`?" + }, + { + "prediction": "I think this should be `if o.name != \"\" {`", + "reference": "Do we also need to validate `envName` flag then? `appName` and `envName` are used in `initLogsSvc` which are called by `svc logs` from within `Execute()`" + }, + { + "prediction": "I think this should be `preg_quote($request->getHost(), '')` instead of `parse_url($url, PHP_URL_HOST)`", + "reference": "@LukeTowers I think I would prefer that we don't force it, on the basis that: a) some people would be opting to configure their web server to protect against this kind of attack and would disable this feature in October CMS to get a small performance increase. b) it might be a bit misleading to say that `app.trustedHosts` set to `false` disables the feature entirely, just to have it be overridden here regardless." + }, + { + "prediction": "I think this should be `c.cnpInformer.Informer().GetIndexer().ByIndex(ClusterGroupIndex, cg.Name)`", + "reference": "i like that you are trying to correct the naming, but its making the PR longer :( i guess in future we can do such changes in separate PRs" + }, + { + "prediction": "I'm not sure if this is a good idea to have a test for all browsers. I think it would be better to have a test for Chrome and Firefox, and another one for Safari.", + "reference": "Are we marking what the browser's accessibility tree says or what screen readers with those browsers say?" + }, + { + "prediction": "Why is this needed?", + "reference": "This method should behave as intended, to block until it reads an EOF from the other side." + }, + { + "prediction": "I think it would be better to use `log.Errorf` instead of `log.Warnf`.", + "reference": "I prefer starts with `Failed to xxx`, how about `Failed to perform health check on xxx`?" + }, + { + "prediction": "I'm not sure if this is the right place for this, but it seems like it should be in the same namespace as the rest of the `AzureAppServices` tags.", + "reference": "All these calls make me think we should refactor how traces are started and allow \"source tags\" that we initialize a trace with. I'd like to do this in a follow up." + }, + { + "prediction": "This file should be renamed to `v1_test.go`.", + "reference": "This file shouldn't be in this PR" + }, + { + "prediction": "Why is this one skipped?", + "reference": "This now causes `LessSpecificReturnStatement - src/somefile.php:9:32 - The type 'non-empty-list<5|string>' is more general than the declared return type 'non-empty-list' for takesList`, which seems correct to me. The type `non-empty-list<5|string>` contains the type `non-empty-list`. Thoughts?" + }, + { + "prediction": "I think this should be `LOG.trace(\"Storing private transaction in enclave\", privacyUserId, maybePrivacyGroup);`", + "reference": "Are you going to change that back?" + }, + { + "prediction": "I'm not sure this is the best way to do this. I think it would be better to have a macro for this.", + "reference": "we have a standard format for putting these together elsewhere, it does the filter check first and errors out and then sets based on the value. i think this should be adjusted to do that. there's no logical change, just an approach change." + }, + { + "prediction": "I'm not sure this is the right place for this. It's not a function, it's a property.", + "reference": "Note this should be `delay` instead of `scale` here. I'll fix this in my branch." + }, + { + "prediction": "I think we can remove this now, since it's not used anymore.", + "reference": "`on` likely still needs a bind, similar to `this.resetProgress = this.resetProgress.bind(this)` correct?" + }, + { + "prediction": "Why do we need to import `get_dist_info` here?", + "reference": "Considering the trade-off between training speed and accuracy, multi-scale training is temporarily kept. More elegant implementation will be adopted in the future." + }, + { + "prediction": "nit: remove empty line", + "reference": "Can you move this up along with the other builtin libraries?" + }, + { + "prediction": "This should be `self.allowUsageStatsCheckBox` not `self.allowUsageStatsCheckBox(wx.CheckBox(self, label=_(\"Allow the NVDA project to gather NVDA usage statistics\"))`", + "reference": "I actually think it makes sense to reposition this checkbox after the notifyForPendingUpdateCheckBox. The current order of check boxes is a bit arbitrary now." + }, + { + "prediction": "I think this should be `required:\"true\"`, since it's not always possible to specify a `Changes` object.", + "reference": "Why do we have both `before` and `after`? Naively I would expect this to work as follows: `plz query changed` with no arguments compares the current working directory state to the last commit (i.e. HEAD, i.e. a noop when directly on a git commit). `plz query changed --since [reflike]` compare the current working directory state to the given reflike. So for CI I would expect to run something like `plz query changed --since @{upstream} (or origin/master I guess)`. And on merge I'd either run everything or just `plz query changed --since HEAD^` (given our workflow) - I don't think I'd ever want to do anything else. Either way I think before and after are slightly confusing terms here." + }, + { + "prediction": "I think this should be `self.re.search(f.server_conn.ip_address)` instead of `self.re.search(f.server_conn.ip_address[0])`", + "reference": "Is there a reason why we can't use `~dst`? It feels like that could be good enough.I would like to avoid extending the filter syntax unless there's an urgent need. :)" + }, + { + "prediction": "I think this should be `DateTimeOffset` and not `LocalDateTime`", + "reference": "Why local and not UTC?" + }, + { + "prediction": "I'm not sure this is the best way to do this. I think it would be better to check if `diagArea_` is empty before checking if it contains `-2013` and `-2012`.", + "reference": "2012 is a retryable error. Will avoiding rgenerating it here cause a difference in behavior in createServer() ?" + }, + { + "prediction": "I think this file should be renamed to `factory.go` and moved to `pkg/pki/factory`", + "reference": "move to line 14 below" + }, + { + "prediction": "I think this should be `public boolean intersectsTriangle(Point3D a, Point3D b, Point3D c)`", + "reference": "the method name should match teh docs" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in `makeRootMetadata` since it's the only place where we create a new root metadata.", + "reference": "Won't this happen automatically when we flip the default version in the config?" + }, + { + "prediction": "I think this should be `assert.Contains(out, \"/var/www/html/docroot\")`", + "reference": "This would also change back to /var/www/html/docroot if we go that way." + }, + { + "prediction": "I think this should be `virtualNode` instead of `node`", + "reference": "This still needs to use the new option. We'll need tests for it too." + }, + { + "prediction": "I think this file should be in the `appModules/` subdirectory.", + "reference": "We are no longer including file name in the source files." + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think it should be in `ApplicationController` since it's a common thing that all controllers should have access to.", + "reference": "no need for this. Devise provides us with `current_user` and `user_signed_in?` helpers." + }, + { + "prediction": "nit: can we call this method `isEth66CompatibleWithVersion`?", + "reference": "Would `Object.equals(capability.getName(), NAME)` would be safer, as you wouldn't have to do null checks?" + }, + { + "prediction": "I'm not sure this is the right place to reset mocks. I think it would be better to move this to `describe '#run'` or `describe '#test'` or `describe '#spec'` or `describe '#example'` or `describe '#group'` or `describe '#feature'` or `describe '#context'` or `describe '#setup'` or `describe '#unsetup'` or `describe '#before'` or `describe '#after'` or `describe '#before_context'` or `describe '#after_context'` or `describe '#before_feature'` or `describe '#after_feature'` or `describe '#before_global_context'` or `describe '#after_global_context'` or `describe '#before_each'` or `describe '#after_each'` or `describe 'before'` or `describe 'after'` or `describe 'context'` or `describe 'setup'` or `describe 'unsetup'` or `describe 'before'` or `describe 'after'` or `describe 'before_context'` or `describe 'after_context'` or `describe 'before_each'` or `describe 'after_each'` or `describe 'context'` or", + "reference": "Hmm, I wonder if we should revert #1862 instead? BTW, what failure do you get w/o this line?" + }, + { + "prediction": "I think this should be `errors.Wrapf(err, \"invalid 'apiURL' %s in Slack config\", out.APIURL)`", + "reference": "since there are several places where we do 1) get secret key ref and 2) validate URL, maybe it's worth having a common method? it could also trim spaces as done here (but not at the other places currently)." + }, + { + "prediction": "I think we can drop the `gaz` part of the name here.", + "reference": "TestNormalize... I would also split them" + }, + { + "prediction": "I think this should be `index = indexGen.next()` instead of `index=next(indexGen)`", + "reference": "All changes to this file are going to conflict with #7599. Please revert these as well. They will be addressed during the Python 3 transition." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in `l.m.RLock()` and `l.m.RUnlock()`.", + "reference": "Just thought, using spinlock (busy wait with compare and swap) that generates 2 random numbers inside rlock. We know that collisions are rare and we don't need that \"large\" write lock really but lock namely for \"rand\". Or least use a separate Lock (Mutex), namely for \"rand\" (wrap it into method). Mutex will use some sort of spinlock as well but it may use some linked list to make it more fair." + }, + { + "prediction": "I think this should be `from pkginfo import version` instead of `from astroid.__pkginfo__ import version`", + "reference": "Can we grab it directly from `__pkginfo__` as that is the source of truth for the version?" + }, + { + "prediction": "nit: remove empty line", + "reference": "We can revert this to reduce the diff of the PR." + }, + { + "prediction": "I think this should be `isCloud || protoPkg.contains(\"cloud\") || protoPkg.contains(\"gcp\")`", + "reference": "This looks weird. `isCloud` should define if it is a cloud or no. Here it does it partially, and it can be overriden by protoPkg value (which also an argument to this function). Please make sure that isCloud completely defines the cloud thing. (i.e. it an be as straightforward as moving `protoPkg.contains(\"cloud\")` from here to the place where `assembleGoImportPath` is called." + }, + { + "prediction": "I'm not sure this is the right way to do it. I think you should check for the flags and set the flags appropriately.", + "reference": "Declaring fileflags to be of type LobTgtFileFlags would eliminate the need for all this casting. And would be safer. (Not a show-stopper though.)" + }, + { + "prediction": "I think this should be `LOG.info(String.format(\"Mapping %s to docker image %s %d times\", caps, name,```", + "reference": "This change prevents a user understanding how their server is configured. Best to leave at `info` level." + }, + { + "prediction": "I'm not sure why this is necessary, but it seems like it should be removed.", + "reference": "Typically we would add something to the build system environment to differentiate this; also is there an alternative that can be used with older OpenSSL? Other folks who are committers will need to decide if it is worth supporting an older and likely quite vulnerable (to hacks) OpenSSL library." + }, + { + "prediction": "I'm not sure this is the right place for these tests. I think they should be in `tests/producers_test.go` instead of `tests/read_block_producers_test.go`", + "reference": "`readActiveBlockProducersByHeightTests` is a global variable (from `gochecknoglobals`)" + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think it should be done in the `updateSync` method, since it's the only place where we're saving the records to the smartstore.", + "reference": "Falls back on `Constants.ID` if there's no custom field set." + }, + { + "prediction": "I'm not sure this is the right place to skip the offset. I think it would be better to do it in the constructor.", + "reference": "I believe this is what we want to rearrange: this in.skip() should not be happening here, in the open method, but in the setOffset() method itself. Because we want to be able to change that offset after the initial open. The setOffset() method will need to throw an IOException, if it's called while the InputStream is still null; or if the skip() call itself results in an IOException()" + }, + { + "prediction": "I think this should be `getMethodNameDeclaratorNode().getParent().getResultType().getChild(0).getResultType().getChild(0)` instead of `getMethodNameDeclaratorNode().getParent().getResultType().getChild(0) instanceof ASTPrimitiveType`", + "reference": "In case the method is `void`, there won't be any children and `getChild(0)` throws. We'll need to check with `isVoid()` for that case. I'll update this when I merge." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `yarpc` package.", + "reference": "If the yarpc.Interceptors wrapper will be added to any user interceptor, why not do it transitively. Can save one step for users. Same apply to filter." + }, + { + "prediction": "I think we should rename this function to `removeEtcdDataDir` or something like that.", + "reference": "Is there anything we should do in the event we're unable to renaming the directory?" + }, + { + "prediction": "I think this should be 8081?", + "reference": "How is this env var populated? Can this be retrieved from cluster metadata?" + }, + { + "prediction": "I think this should be `record.Errorf` instead of `record.Warnf`.", + "reference": "Should probably skip the success event here, since it could be a noop." + }, + { + "prediction": "I think this should be `imageBlurHashes: item.ImageBlurHashes,` and not `imageBlurHashes: item.ImageBlurHashes`", + "reference": "I added this here because people cards (which depends on cardBuilder) had this added in blurhash. Not sure when this is used though cc @JustAMan" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the URLOpener package, since that's where the URLOpener lives.", + "reference": "Let's keep this line in the docstring, to let end users know they shouldn't be using this directly." + }, + { + "prediction": "I think we can remove the check for gas price here as it's already checked in the above validation.", + "reference": "can do the same for other validateXXX()" + }, + { + "prediction": "Is there a reason for this change?", + "reference": "Why is this necessary?" + }, + { + "prediction": "I think this should be `import datetime as pd` or `import datetime as pdt` or `from datetime import datetime as pdt` or `from datetime import datetime as pd` or `from datetime import datetime as pdt` or `from datetime import datetime as pdg` or `from datetime import datetime as pdg` or `from datetime import datetime as pdg` or `from datetime import datetime as pdg` or `from datetime import datetime as pdg` or `from datetime import datetime as pdg` or `from datetime import datetime as pdg` or `from datetime import datetime as pdg` or `from datetime import datetime as pdg` or `from datetime import datetime as pdg` or `from datetime import datetime as pdg` or `from datetime import datetime as pdg` or `from datetime import datetime as pdg` or `from datetime import datetime as pdg` or `from datetime import datetime as pdg` or `from datetime import datetime as pdg` or `from datetime import datetime as pdg` or `from datetime import datetime as pdg` or `from datetime import datetime as pdg` or `from datetime import datetime as pdg` or `from datetime import datetime as pd", + "reference": "Please move this import upper to other similar imports" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it's the only thing I can come up with right now.", + "reference": "Include the key word \"translated\". Otherwise the reader will find this confusing." + }, + { + "prediction": "I'm not sure this is the right place to memoize this. I think it should be in the `ElasticsearchStorage` class itself.", + "reference": "why. is this called per request? if so this also adds a lock internally. can we not add this at the moment until analyzed as this assumption isnt carried to the several other impls. the only other consumer of this is the http api and that isnt hit often enough for specializations." + }, + { + "prediction": "`actualNode` is not a property of `option` but of the `amp-selector` component. I think it would be better to use `option.hasAttribute('selected')` instead of `option.hasAttr('selected')`", + "reference": "I believe this means dependent checks can no longer operate on virtual nodes, which is something we've been pushing for lately. We may need to find a different way to solve this issue, as I don't think we want to cause a regression while fixing a bug." + }, + { + "prediction": "I think this should be `os.path.join` instead of `os.path.abspath`", + "reference": "ditto about use of `abspath`" + }, + { + "prediction": "I think this can be simplified to `Math::max`", + "reference": "this reduces the runtime by 50 times" + }, + { + "prediction": "This file should be renamed to `RemoteDistributorTest.java`", + "reference": "Probably best not to have an empty test...." + }, + { + "prediction": "I think this should be `final X exception = exceptionType.getConstructor().newInstance();` instead of `final X exception = exceptionType.newInstance();`", + "reference": "direct `newInstance` call is also deprecated now" + }, + { + "prediction": "I think this should be `k8s.io/kubernetes/pkg/client/informers/informers.go`", + "reference": "We have a bit of a convention where imports are split into three blocks: first Go standard library, then imports from outside the repo, then imports from inside the repo." + }, + { + "prediction": "I think we should keep the `protected` modifier here.", + "reference": "Why was this change needed?" + }, + { + "prediction": "I think this should be `\\0\\0\\0` instead of `\\0\\0\\0\\0`", + "reference": "can you use this opportunity to remove `.readlines()` useless list creation? (`addresses = [l for l in fd if l.find(\"netmask\") >= 0]`)" + }, + { + "prediction": "Line is too long. [83/80]", + "reference": "Why does this check differ from `plan_ssh.rb`?" + }, + { + "prediction": "I think it's better to use `github.com/iotexproject/iotex-core/consensus` as a submodule.", + "reference": "File is not `goimports`-ed (from `goimports`)" + }, + { + "prediction": "I think this should be 64 instead of 3. I'm not sure how many concurrent writes we can have at the same time.", + "reference": "It was @lodejard who initially suggested this pattern. I think that it had something to do about prioritizing future writes even if there was a pending write operation ready to handle the newly requested write. I'm not sure I fully understood the explanation for having up to 3 pending write requests, because only having one queued write at a time still makes sense to me. I'll talk to him about it." + }, + { + "prediction": "I don't think this is a good name for this debug flag. I would suggest something like: `--enable-debug-serialization` or `--debug-serialization` or `--enable-debug-serialization`.", + "reference": "We have cli --online_weight_clear in cli.cpp" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it's the only thing I can come up with that doesn't break anything.", + "reference": "So the request.Headers is a map of []string. Are you sure that the HTTP library doesn't already do this split for us?" + }, + { + "prediction": "Shouldn't this be \"Execution stopped, executor/container crashed\"?", + "reference": "How is this message used? Can we remove the \"crashed executor/container\" part which is an implementation detail?" + }, + { + "prediction": "I don't think this is the right place to put this. It's not a command, it's a property. The heap snapshot is a property of the session, so it should be under the `/session/:sessionId/heap_snapshot` path.", + "reference": "Instead of building in routing for a browser-specific command, could you refactor the HttpCommandExecutor to allow arbitrary commands to be registered?" + }, + { + "prediction": "I'm not sure if this is the best way to display the \"back\" link, but it's the only way I could come up with at the time.", + "reference": "Space after `=`." + }, + { + "prediction": "I don't think this is the right place to do this. I think it should be done in the `afterCreate` handler.", + "reference": "if just need to do something after createInvocation just override and call super first is enough?" + }, + { + "prediction": "I'm not sure why Travis was complaining about this one, but I think it's because of the trailing period at the end of the line.", + "reference": "By the way, I fixed `announce` method (missing `super` call to announce JDK version)" + }, + { + "prediction": "I don't think this is a good idea. I think it's better to use `Object::equals` and `Object::toString` instead.", + "reference": "I'm not sure about that... This line can produce ClassCastException if Comparator do not check this." + }, + { + "prediction": "This is a breaking change. I think it would be better to just return the bare TLF in this case.", + "reference": "There wasn't any special reason for this to return a pointer, right?" + }, + { + "prediction": "I think this should be a `ConcurrentHashMap` instead of a `HashMap`.", + "reference": "Why the need for a `ConcurrentHashMap`?" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it's the only way I could come up with that works.", + "reference": "New code should use strict equality `===`" + }, + { + "prediction": "I'm not sure if this is the right place to put this test. I think it should go in `spec/workers/notify_spec.rb` but I'm not sure if that's the right place to put it.", + "reference": "`expect(resources['Notify[local pid]']['events'][0]['desired_value']).to match(/(\\d+)/)` seems clearer." + }, + { + "prediction": "I think we can remove the `changeMd` variable now.", + "reference": "Removed now-unneeded param." + }, + { + "prediction": "`bitswap` is not a command, it's just a command-line flag.", + "reference": "(NON-blocking, this can be tracked in follow up issue) @anorth @mishmosh is the toplevel getting too crowded? Should we have a `network` grandparent command, or maybe a `stats` command?" + }, + { + "prediction": "I think this should be `_x( 'Analytics', 'Service name', 'google-site-kit' )` instead of `_x( 'Analytics', 'Service name', 'google-site-kit' )`", + "reference": "The `_x` function needs to be imported at the top of the file (in addition to `__`)" + }, + { + "prediction": "I think this should be `WaitForCondition(() => (DetectionsGraphController.Settings.QValueCutoff == 0.003f));`", + "reference": "This is functionally equivalent to the code it replaces." + }, + { + "prediction": "I don't think we should be setting the ENIType here. We should only set it when creating the ENI.", + "reference": "can you change the field name here to \"InterfaceAssociationProtocol\"? same for the Config struct in agent/ecscni/types.go. i think it's better to keep the field name consistent between agent and acs payload" + }, + { + "prediction": "This file should be removed.", + "reference": "See above, same for the other cases." + }, + { + "prediction": "I don't think this method should be marked as `@since 4.2`", + "reference": "Shouldn't line 313 be public \\ SettableGauge\\ **settable**Gauge(String name) { ? It would also be good to call it a few times and with differnet types (Long, Integer, String) in the test as well." + }, + { + "prediction": "I'm not sure this is the right place for this. It seems like it should be in the `infer_call_result` function, but I can't find where it is used.", + "reference": "I would prefer to just fix the occurences of this new check rather than disable them" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think it's better to have a constant for the value of `i` instead of hard-coding it here.", + "reference": "The tests should be fixed in #4841, so this is no longer needed" + }, + { + "prediction": "Shouldn't this be `InvalidArgumentException` instead of `SerializationException`?", + "reference": "I think it should been in `SharedKernel` module." + }, + { + "prediction": "I think it would be better to use `+optional` here.", + "reference": "Can we add some description for this field?" + }, + { + "prediction": "I think this should be `DurationType` instead of `Duration`", + "reference": "Should its name be Time or Duration? I can see them both." + }, + { + "prediction": "I think this should be `[]otlpconfig.GRPCOption` and not `[]*otlpconfig.GRPCOption`", + "reference": "Is this used anywhere?" + }, + { + "prediction": "This is a test for `String()` and `Attributes()`, not for `Merge()`.", + "reference": "I believe that you can use `assert` instead of `require` here and in the following lines" + }, + { + "prediction": "Why do we need to pass a pointer here?", + "reference": "In `storagemarket.go` you used `nil` for an unwanted out parameter. Do something consistent (nil seems fine if supported)." + }, + { + "prediction": "I'm not sure we need this package. I think we can just use `Contains`, `HashBytes`, `PadBytesLeft` and `IsPotential` everywhere.", + "reference": "is this a new pattern we use in bee? interesting" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should just return an error here and not wait for potential failure later.", + "reference": "If you think this PR works, i'll clean this up before resubmitting." + }, + { + "prediction": "I think we can remove these two constants.", + "reference": "are you sure you can read version by this artifactid?" + }, + { + "prediction": "I think we should revert this change.", + "reference": "We can get rid of this import then." + }, + { + "prediction": "I think this should be `switch c.typ` and not `switch c.typ == CLIENT`", + "reference": "Should we do our own vtable?" + }, + { + "prediction": "I'm not sure this is the right fix. I think we need to remove `config.exceptions_app = self.routes` from `config/environment.rb` so that `config.exceptions_app` is always `nil` when `Rails.env` is set to `development` or `test`. Otherwise, when `Rails.env` is set to `production` or `staging`, `config.exceptions_app` will be set to `Rails.application.routes.url_helpers`, which is not what we want.", + "reference": "This is the actual fix." + }, + { + "prediction": "I think this should be `defaultSyncInterval = 30 * time.Second` and not `defaultSyncInterval = 60 * time.Second`", + "reference": "If sync has really a negative impact, this is just moving the issue from 10sec to 60sec. Wonder if you should not expose the (auto)sync params so users can decide." + }, + { + "prediction": "I'm not sure this is the right place for this method. I think it should go in the `Decoder` interface.", + "reference": "should be called => will be called" + }, + { + "prediction": "I think this is not the right place to calculate the height.", + "reference": "not sure whether we should do this. It may cause problem that delegates upgrade their nodes at different time, that they will have different \"last block time\", some use \"commit time\", some use \"block time\". Potential solution: Only use block time after berling, and then delete it in the next version after berling. Open to discussion." + }, + { + "prediction": "I think it would be better to move the call to deleteCollection to the try/catch block above, and wrap the exception in the deleteCollection call. This way, if the exception is thrown by the call to deleteCollection, it will be propagated to the caller, and the caller will be able to decide what to do with the exception.", + "reference": "So one question I have is why is the error coming back from `buildReplicaPositions` not an `Assign.AssignmentException`? Is it because it is wrapped in a `SolrException` from the remote node?" + }, + { + "prediction": "I'm not sure this is the right place for this test. I think it would be better to move this test to `test_logging.py` under the `rbind` section.", + "reference": "`dt` won't work for some reason?" + }, + { + "prediction": "I think this should be `\"\" != os.getenv(\"KOALAS_USAGE_LOGGER\")`", + "reference": "Is this because \"KOALAS_USAGE_LOGGER\" can be `None` ??" + }, + { + "prediction": "Shouldn't this be 500 instead of 1000?", + "reference": "I like it but maybe the better name will be EthGasPriceConstants or EthGasPriceEstimatorConstants? but Constants not Config" + }, + { + "prediction": "nit: I think you can remove this line.", + "reference": "I would inline the constructor as well" + }, + { + "prediction": "nit: I think it would be better to use `nebula::GraphParser::semantic_type` and `nebula::GraphParser::location_type` instead of `dummyyylval` and `dummyyyloc`.", + "reference": "I'm not confident about this..." + }, + { + "prediction": "I think this should be `certificates` instead of `certificateRequest`", + "reference": "There is also `v1alpha1.CertificateRequestKind` I think?" + }, + { + "prediction": "I think we should rename this to `GCPBrokerSenderJob`", + "reference": "Can we rename it to make it less confusing? Instead of \"sender-gcpbroker\", maybe name it to \"retryable-sender\"" + }, + { + "prediction": "I think this should be `literal().value() instanceof Literal` instead of `literal().value().getClass().getName()`", + "reference": "So looking at the definition of the `literal()` function in this class, it seems it's possible for it to return null. I guess it's not a concern as we would get NPE on the above call at line 136 when trying to call `.to` if `literal()` returned `null` before even getting to this part that calls `literal().value()`, but something I thought I'd bring up. Perhaps something we might follow up on in another issue or possibly I just missed the workflow that makes `literal()`'s result non-null by the time this `bindLiteralOperration` is called." + }, + { + "prediction": "I think you can remove this line.", + "reference": "Why did you break the line? It looks like it is under 80 characters without the break and it is inside parens so no need for backslash anyway" + }, + { + "prediction": "I think this should be `from datatable import DataTable` instead of `from datatable import DataTable as DataTable`", + "reference": "@guolinke Don't you mind to rename this variable to `DATATABLE_INSTALLED`, for the consistency with other variables (for example, there are `PANDAS_INSTALLED` but not `PD_INSTALLED`). Also, `DT` is a little bit confusing: sometimes `dt` is used for `datetime`." + }, + { + "prediction": "I'm not sure this is the best way to do this. I think it would be better to have a helper method that does the following: 1. Finds all of the examples in the given profile 2. Finds all of the locations of those examples 3. Loops over all of those locations and formats them into a single string", + "reference": "We're fine with double quotes here. Just for future reference." + }, + { + "prediction": "I don't think we need this function at all. We can just use `yarpcerrors.ErrorCode(err).String()`", + "reference": "can we keep this around? We should make sure we can distinguish between properly wrapped errors and \"unwrapped\" errors" + }, + { + "prediction": "I think this should be `topology_at_rasterizer = graphicsPipelineCI.pInputAssemblyState->topology;` instead of `if (graphicsPipelineCI.pInputAssemblyState) { topology_at_rasterizer = graphicsPipelineCI.pInputAssemblyState->topology; }`", + "reference": "`RecordPipelineShaderStage()` might change `topology_at_rasterizer `, according to shader code, so we should check `pInputAssemblyState `first." + }, + { + "prediction": "I think this should be `assets` not `Assets`", + "reference": "Should we just inline the assets here? I can't think of an advantage to having them in a separate file." + }, + { + "prediction": "I think we can remove the `map[string]k8sproxy.Endpoint` part here.", + "reference": "detectStaleEndpoints to be more specific?" + }, + { + "prediction": "I don't understand why this is here.", + "reference": "Please create a new issue for addressing this (if there isn't one already), so it doesn't get lost." + }, + { + "prediction": "I think we should make this a `sync.WaitGroup` instead of a `chan interface{}`.", + "reference": "Nothing was ever coming out of this channel because its already being consumed. Create a new channel here and feed it in HandleNewHead method." + }, + { + "prediction": "nit: remove `Amazon` from the name since it's no longer AWS terminology.", + "reference": "AWS Identity and Access Management (IAM)" + }, + { + "prediction": "I think this should be `fine` instead of `fine`", + "reference": "This is deliberately at this level." + }, + { + "prediction": "I think this should be `err` and not `hex.DecodeString`", + "reference": "payload entered on command line is in hex-encoded format should use same processing as in ioctl/cmd/action/actiontransfer.go" + }, + { + "prediction": "I'm not sure this is the right place to create demo pricing groups. I think we should move this logic to the `createPricingGroup` method in the `DemoPricingGroupDataFixture` class.", + "reference": "should this be kept in the `else` branch?" + }, + { + "prediction": "nit: remove empty line", + "reference": "Why not put this below \"strings\"?" + }, + { + "prediction": "I think this should be `public int UvPipeCount => _dispatchPipes.Count;`", + "reference": "Make it `internal` if it's just for testing." + }, + { + "prediction": "I don't think you need to disable this one.", + "reference": "What is triggering this message in this file?" + }, + { + "prediction": "I'm not sure if this is the right way to do it. I think we need to make sure that all workers are started before we try to check the results.", + "reference": "Are you sure this should be removed?" + }, + { + "prediction": "I don't think we need this constructor anymore.", + "reference": "What's that good for? The field is initialized in the constructor." + }, + { + "prediction": "I think this should be `if self.wfile and self.wfile.close()`", + "reference": "This shouldn't be necessary (same below). Do you have a traceback for me?" + }, + { + "prediction": "nit: remove empty line", + "reference": "No newline needed here." + }, + { + "prediction": "This file should be renamed to `libkbfs.go`", + "reference": "Why a separate block?" + }, + { + "prediction": "I think this should be `LOG(ANNOTATIONS, 2, \"reg=%d, %s, last reg=%d\\n\", reg, get_register_name(reg), DR_REG_LAST_ENUM);`", + "reference": "Probably better to ask @AssadHashmi or another AArch64 expert for a review rather than me -- @AssadHashmi if you could confirm that these status registers are 64-bit despite having only a few fields?" + }, + { + "prediction": "I think this should be `m/44'/1'/%d'/%d'/%d'` instead of `m/44'/0'/%d'/%d'`", + "reference": "`purpose` and `coin_type` and `account` would mimic the BIP-0044 wording, but it's up to you." + }, + { + "prediction": "I don't think this is the right fix. The problem is that we are setting the `Checked` property of the `rbQValue01` control to `true` when `qValue == .01f`, but we are not setting the `Checked` property of the `rbQValueCustom` control to `true` when `qValue == .01f`. The reason is that the `Checked` property of the `rbQValueCustom` control is being set to `false` when `qValue != .01f`, so the `Checked` property of the `rbQValueCustom` control is being set to `true` when `qValue != .01f` and the `Checked` property of the `rbQValueCustom` control is being set to `false` when `qValue == .01f`, so the `Checked` property of the `rbQValueCustom` control is being set to `true` when `qValue == .01f` and the `Checked` property of the `rbQValueCustom` control is being set to `false` when `qValue != .01f`, so the `Checked` property of the `rbQValueCustom`", + "reference": "Is this the critical change? It does seem wrong to use Select() instead of Checked = true. Not sure why that would pass sometimes and not others, though." + }, + { + "prediction": "I think we can remove the `Spec.Platform.VSphere.NumCoresPerSocket` and `Spec.Platform.VSphere.MemoryMiB` fields from the `MachinePool` struct.", + "reference": "Seems a little low, but is this an installer default?" + }, + { + "prediction": "I'm not sure this is the right place for this hack. I think it should go in `structlog`, since it's used by both `kinto.core.utils` and `kinto.core`.", + "reference": "Maybe we could provide our own `configure` function that includes `logger._logger = None` because I don't see a use case in kinto for using `reset_logger` besides configuring the logger." + }, + { + "prediction": "I think we can remove the `Num` and `Denom` fields as well.", + "reference": "This will cause the same breakage that was caused when we added Proof to Block. Be sure to let people (infra?) know ahead of time" + }, + { + "prediction": "I think this test is still a little bit out of date, since it doesn't check that `ncs.nodes` is empty after the finalizer has been emitted.", + "reference": "Fixed the test; @strib want to validate that this is okay? Seems to be consistent new GC behavior." + }, + { + "prediction": "I think this test is failing because `subdomain` is not a valid key for the `Account` struct.", + "reference": "Afaict, nothing cares" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in `reembedBlockChanges` in `kbfs_internal.go`.", + "reference": "I must be missing something, but why does not having a node cache imply not neededing to re-embed the block changes, in particular? Isn't it just the fact that we don't do any writes?" + }, + { + "prediction": "I think this should be `internal` since it's just a struct.", + "reference": "Are these changes from `class` to `struct` breaking if called from an older version of `Datadog.Trace.ClrProfiler.Managed`?" + }, + { + "prediction": "I think we can remove bloom filter here.", + "reference": "These are just aliases now" + }, + { + "prediction": "I think this should be safe to use plain text.", + "reference": "Does this mean we can remove `raw` from `_head_contents` partial?" + }, + { + "prediction": "I think you can remove the `&& !this.splashWindow.isDestroyed` part here.", + "reference": "`isDestroyed` is a function, not a property. This condition will always return false." + }, + { + "prediction": "I think this should be `Version_1_33` and `Version_1_34` instead of `Version_1_31` and `Version_1_32`", + "reference": "Why are we adding these versions?" + }, + { + "prediction": "I think this should be `logger.info('imported %d listens for %s' % (len(listens), str(user)))`", + "reference": "fyi, you can do this by doing `.info(\"string %s %s\", formatparam, formatparam2)` instead of doing a string format with `\"str\" % (params)` the idea is that it'll only do the string interpolation if logging is enabled for this level, which theoretically is an optimisation, but in this case probably isn't important" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `before_action` callback of the `User` controller, since that's where the login is done.", + "reference": "Would this work, as a one liner? `setTimeout(window.location.reload, 5000);`" + }, + { + "prediction": "I think we can remove the `cipher` package now.", + "reference": "Can you move `crypto/tls` into the block at the top with all the other stdlib imports?" + }, + { + "prediction": "I don't think we need to change this.", + "reference": "What is the motivation for this change?" + }, + { + "prediction": "I'm not sure if this is the right place for this method. I think it should be in the `Subscription` interface, but I'm not sure if there is a better place to put it.", + "reference": "OK, so the concrete implementation will loop? But then it's important that this method waits for a while before it returns no messages. To be specific, a GCP implementation that set `ReturnImmediately` to true or false would both satisfy this requirement, but the first would cause busy-waiting." + }, + { + "prediction": "I'm not sure this is the right place for this check. I think it should be in the `validatePath` function.", + "reference": "The data structure of `MatchClauseContext` may need to be redesigned." + }, + { + "prediction": "I'm not sure this is the right way to do this. I think we need to make sure that the `want` and `got` are the same size, and that they have the same contents.", + "reference": "You say on the issue that something has to be receiving while the messages are being published. But here it's possible that the publish goroutine starts, and maybe even completes, before Receive is ever called." + }, + { + "prediction": "Line is too long. [83/80]", + "reference": "how do we know that the step in question is an approval type step?" + }, + { + "prediction": "I don't think we need to change anything in this file.", + "reference": "JMX offers normal APIs for this. I don't think you want the glassfish one." + }, + { + "prediction": "I think you can remove the `requires io.vavr` line as it is already exported by the `io.vavr` package.", + "reference": "Is this still Java 8 compatible? @danieldietrich do we need a separate, modularized Java 9 release also?" + }, + { + "prediction": "I'm not sure this is the right place to set the filter mode. The filter mode should be set by the user, not the resource type.", + "reference": "Should update the user input address and filter modes and pass those in fillSamplerDescriptor ?" + }, + { + "prediction": "Line is too long. [82/80]", + "reference": "This object should be in `lib/music/show.rb` and you should also wrap this object in the `Faker::Music::Show`." + }, + { + "prediction": "I think this should be `|| (raise Puppet::ParseError, 'Task parameters did not match')` instead of `|| (raise Puppet::ParseError, 'Task parameters did not match')`", + "reference": "I think logic will have to move to bolt since the vague discussions around bolt run plan --noop is that it would just skip any tasks that don't support_noop rather than error. This is fine until we actually elaborate that though." + }, + { + "prediction": "please remove this empty line", + "reference": "File is not `goimports`-ed" + }, + { + "prediction": "I'm not sure this is the right place for this test. I think it should go in `web/testutils.py`.", + "reference": "why should unknown raise a 403?" + }, + { + "prediction": "I think this should be `if (newType.getDerivedStateFromProps!=null) {`", + "reference": "The true clause of your condition, can't this just be c._nextState since `assign({}, c._nextState)` is equal to returning c._nextState, or am I misunderstanding something here?" + }, + { + "prediction": "I think this should be `50000` instead of `500`", + "reference": "nit: align the leftmost quotes" + }, + { + "prediction": "I think this should be `OptionalInt` instead of `OptionalInt64`", + "reference": "Probably \"server port\" -> \"TCP port\"" + }, + { + "prediction": "I think this should be `protected Lucene80Codec(String name, Mode mode) {`", + "reference": "can you use FilterCodec instead?" + }, + { + "prediction": "I'm not sure this is the right place for this setting. I think it should be moved to the `Settings` module.", + "reference": "I know there's only two values but I find it a bit confusing that it's true/false. Could you change it to a string enum with values \"portrait\" and \"landscape\"? Then when calling printToPdf you can just do `landscape: Setting.value('export.pdfPageOrientation') === 'landscape'`" + }, + { + "prediction": "I'm not sure about this one. I think it's fine, but I don't want to make any assumptions.", + "reference": "I think this migration should fail for MDBX if it uses old table names" + }, + { + "prediction": "Line is too long. [83/80]", + "reference": "Should this be negated? `!@options[:hosts_file].nil?` Otherwise it'll enter the `if` statement and `nil` will be passed to `HostsFileParser.parse_hosts_file`, which I'm assuming is bad." + }, + { + "prediction": "I don't think this is the right place for this. I think it should be in the `NLog.Configuration` assembly.", + "reference": "I'm doubting if adding a bool here is a good idea. Maybe it should be an option object? Otherwise it's hard to extend. But an option object is a bit strange in a fluent API? What do you think @snakefoot ?" + }, + { + "prediction": "I think this class should be private.", + "reference": "This is used in o.a.l.sandbox.search.PhraseWildcardQuery." + }, + { + "prediction": "I'm not sure this is the right place to store the protocol view.", + "reference": "view should be loaded on start for both statedb and factory" + }, + { + "prediction": "I'm not sure about this change. I think it's fine, but I'm not sure if it's related to this PR.", + "reference": "Why rename? Just curious..." + }, + { + "prediction": "I think you can remove this line.", + "reference": "Is this needed? I think it calls the super function that already does that." + }, + { + "prediction": "`self.num_classes` should be `num_classes` here.", + "reference": "This might slow down the inference time, are we sure we need to do that?" + }, + { + "prediction": "I think it's better to move this to the top of the file, so it's clear that this is a part of the package.", + "reference": "This would read better if you add \"Skip code/lines\" or (exclude/hide code if you follow my earlier suggestion\")" + }, + { + "prediction": "I think it would be better to use `org.apache.commons.io.IOUtils` instead of `IOUtils`.", + "reference": "Looks like glassfish went a bit nuts doing a refactor" + }, + { + "prediction": "I'm not sure this is the right place for this method. I think it should go in the `OpenTelemetrySdk.Trace` assembly, since it's only used by that assembly.", + "reference": "nit: allocate the list using the number of processors." + }, + { + "prediction": "I think this should be `javaClasses[i]` instead of `initializedClasses[i]`", + "reference": "Was this change triggered by baseline?" + }, + { + "prediction": "I think we can remove this method now, since we don't need it anymore.", + "reference": "This code was doing nothing as far as I can tell and was making the SQL find nothing with the new version of Rails. Remove it unless someone can explain why it is there." + }, + { + "prediction": "I'm not sure this is the right place to set the browser login enabled flag. I think it should be done in the `SafeforceSDKManager` or `SafeforceSDKManagerImpl`", + "reference": "Setting browser based login as the default for `RestAPIExplorer`." + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think it should be done in `DataParallelTreeLearner::FindBestSplitsFromHistograms`.", + "reference": "maybe we can do this in Init function?" + }, + { + "prediction": "Shouldn't this be `errRequestIDTooLong`?", + "reference": "How about if request ID not set, service should generate a random uuid?" + }, + { + "prediction": "I think this is the only change that needs to be made to the test. The rest of the changes are cosmetic.", + "reference": "minor: this is an opportunity for you to split these long lines into multiple lines :)" + }, + { + "prediction": "I'm not sure this is the best way to do this. I think it's better to catch the exception and raise a new one with a more descriptive message.", + "reference": "It would be nice to have exception dumped somewhere (debug logs, info logs)." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `pkg/cloud/internal/structs.go` or `pkg/cloud/internal/structs.go`.", + "reference": "So I don't think this is right, as discussed on #657." + }, + { + "prediction": "I'm not sure this is the right place for this query. I think it should go in `user_groups` table.", + "reference": "should the group_id = \"{0}\" be group_id = %s You'd still keep the {} for the group_members_{} for the tablename but make the filter clause parameterized." + }, + { + "prediction": "I think this should be `file_dict.get('path', path_exc)` instead of `file_dict.get(\"path\", path_exc)`.", + "reference": "Path can contain variable pattern in the middle. Also, `$` is not enough to tell if this is JMeter variable. We have correct variable detecting somewhere in our code." + }, + { + "prediction": "I'm not sure this is the right place to put this method. I think it should be in the `FormTestModel` class, since it's only used for testing the `FormTest` model.", + "reference": "@bennothommo can you revert this section? It shouldn't be required." + }, + { + "prediction": "I think we can remove the `% 100` part here, since `FISCAL_YEARS` is an array of length 10.", + "reference": "Minor: maybe move the above to a `#fiscal_year` method?" + }, + { + "prediction": "I think this should be `assert build.build_package('test_hdf5', 'generated', buildfilepath) in [os.path.join(path, 'test_hdf5'), os.path.join(path, 'generated/test_hdf5.py')]`", + "reference": "You should use the current directory instead - it's a temporary directory that will get removed when the test is done." + }, + { + "prediction": "Why is this change needed?", + "reference": "I think we don't need synchronization here." + }, + { + "prediction": "I don't think we should change the wording of the error message here. I think it's fine to leave it as it was.", + "reference": "I don't think this should be changed since on the reactive side we don't support anonymous users." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `after_save` callback.", + "reference": "Maybe this `if` should be on line 118?" + }, + { + "prediction": "I think this should be `uint64` instead of `int64`.", + "reference": "Cool. (I thought I had fixed this already in #812.)" + }, + { + "prediction": "I'm not sure about this change. I think it's fine to keep the `cacert` and `token-file` defaults in the `BoltTransport` class, but I think it would be better to move the `cacert` and `token-file` defaults to the `Bolt::Transport::HTTP` class.", + "reference": "I intend to do this as soon as I have tests passing." + }, + { + "prediction": "I think this should be `sys.stdin.close()` instead of `sys.stdin.read()`", + "reference": "Please remove the `test_*` from the filename - otherwise pytest will try to collect tests from it." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in `libudev-devd` since that's where the udev stuff lives.", + "reference": "Did you file a bug to follow up on this?" + }, + { + "prediction": "I think it would be better to use `getOrDefault` here instead of `map` and `orElseGet`.", + "reference": "Looks like these 4 lines didn't actually change. Can you revert the whitespace changes here?" + }, + { + "prediction": "Style/ImportOrder: Importing from the same module is better than importing from a different module if the import order is the same.", + "reference": "This can't be merged with any usage of `require 'pathname'` in lib, it's not always available and we don't want false positives for people (where they don't realise they needed to requite it). Its also unnecessary, no other formatter uses it to look up failure locations. See the exception presenter etc for how we format lines." + }, + { + "prediction": "nit: can you move the `publishDataverse` and `publishDatasetViaLinking` assertions into their own `Then` statements?", + "reference": "It would be nice to fix the indentation above." + }, + { + "prediction": "I don't think we should change this.", + "reference": "`short_names` is still optional, so `=` that indicates it has to stay there." + }, + { + "prediction": "nit: I think we should rename this to `appendEFSCapabilites` to be consistent with `appendFirelensFluentbitCapabilities` and `appendFirelensLoggingDriverCapabilities`", + "reference": "missing calling of this method" + }, + { + "prediction": "I think this is the only place where `deploy/cloudFormation` is used.", + "reference": "We could get rid of this dependency being forced on clients by changing the `StackConfiguration` interface abstraction to deal with strings instead of `cloudformation.Parameters` and `cloudformation.Tags`, and internally to the `cloudformation` package translate the input strings into the `service/cloudformation` package specific values hiding that from consumers. I don't think that should be taken on as part of this PR, but I think we should consider doing it at some point." + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be under `chaos/mesh` since it's specific to the mesh.", + "reference": "`StressChaos` does not contains a field .spec.action" + }, + { + "prediction": "I don't think this is the right place for this test. It should be moved to `Test\\IteratorTrait`.", + "reference": "Non-int literal strings are no longer coercible to int, I think this is an improvement. Without this change it now reports `InvalidArgument`." + }, + { + "prediction": "I think this should be `ARRAY_SIZE(a)` instead of `sizeof(a) / sizeof(a[0])`", + "reference": "I this used anyplace?" + }, + { + "prediction": "Why did you change this?", + "reference": "Why was this change required?" + }, + { + "prediction": "I think this should be `protected final boolean missingAdminRole;`", + "reference": "I like that we have this attribute here. However, I think the way we use it right now might be confusing in the future. For example, when only camunda admin is checked, this exception will be instantiated with a message and `missingAdminRole` is `false`. I think that is counter-intuitive. I would expect this exception to have `missingAdminRole` set to `true`. With this explicit information, the exception message could now be generated inside this exception class with the text block that is currently used in the authorization manager. We could maybe generally reuse that text block then also for the case where a user is no admin and also has none of the required permissions. I haven't tried it myself but I think it would be great if we could streamline those things a bit more if we're working on it now. Let me know what you think." + }, + { + "prediction": "This should be `public static int getSizePrefixedRootAsMonster(ByteBuffer _bb);`", + "reference": "Not sure why we're creating a new `ByteBuffer` here, ideally this refers to the existing one?" + }, + { + "prediction": "I think this should be `DATE_RANGE_OFFSET`, not `DATE_RANGE_OFFSETS`.", + "reference": "Same here re: `STORE_NAME` to `MODULES_SEARCH_CONSOLE`." + }, + { + "prediction": "I think we can remove this line now, right?", + "reference": "I could've sworn I got a `403` myself when I got that response locally. Is `200` what the API would send back for a `permission: false` tag?" + }, + { + "prediction": "I think we can remove the `NewIdentityManager` function altogether. It's not used anywhere.", + "reference": "This attribute was intentionally private. - lets force usage of factory `NewIdentityManager()` - lets ramake to `NewIdentityManager(keydir string)` -> `NewIdentityManager(keystore keystoreManager)`" + }, + { + "prediction": "I think this should be 100ms, not 10 * time.Millisecond.", + "reference": "Is this too frequent?" + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in the `models` folder.", + "reference": "will this not make it possible to use a zip file, e.g. on other importers who do not have to support it ?" + }, + { + "prediction": "I don't think we need to import `SocksClientLayer` here.", + "reference": "Needs to be mentioned in `__all__` below." + }, + { + "prediction": "I'm not sure this is the right place to do this check. I think it should be done in the `sigfd_set` function, since that is the place where the `sigfd_table` is initialized.", + "reference": "What if the app's signal handler, executed at pre-syscall for epoll_pwait, executes its own epoll_pwait? For that matter: what happens natively if that happens? I would not expect the kernel to keep a stack -- does that clobber the kernel's stored pre-syscall mask?" + }, + { + "prediction": "I think it would be better to say that the returned list is sorted in ascending order and that it is guaranteed that the returned list is sorted in ascending order. It is important that the returned list is sorted in ascending order. The returned list is sorted in ascending order. It is important that the returned list is sorted in ascending order. The returned list is sorted in ascending order. The returned list is sorted in ascending order. The returned list is sorted in ascending order. The returned list is sorted in ascending order. The returned list is sorted in ascending order. The returned list is sorted in ascending order. The returned list is sorted in ascending order. The returned list is sorted in ascending order. The returned list is sorted in ascending order. The returned list is sorted in ascending order. The returned list is sorted in ascending order. The returned list is sorted in ascending order. The returned list is sorted in ascending order. The returned list is sorted in ascending order. The returned list is sorted in ascending order. The returned list is sorted in ascending order. The returned list is sorted in ascending order. The returned list is sorted in ascending order. The returned list is sorted in ascending order. The returned list is sorted in ascending order. The returned list is sorted in ascending order.", + "reference": "Nit: missing a space. I think we should phrase the new content a little differently. \"It is important\" isn't very clear. I think it should be \"offsets will be returned in sorted order.\"" + }, + { + "prediction": "I don't think we need to import `json` here.", + "reference": "Can you remove this blank line and put the added import in sorted order (likely your editor will do this)" + }, + { + "prediction": "I think it would be better to use `SSL_CONF_UPDATE_INTERVAL` instead of `ocsp_update_interval` to be consistent with the rest of the code.", + "reference": "Even if `pthread_create()` for `ocsp_updater_thread()` fails, `h2o` can continue to serve. But I'm a little worried whether `h2o` should continue to serve in this case. How about you?" + }, + { + "prediction": "I think we should move this to the top of the file, since it's not used anywhere else.", + "reference": "I like introduction of these constants for account/container creation, but the `ACCOUNT_CHOOSE` one isn't needed I think. This should instead be an \"empty\" value (either `''` or `0`), to indicate more clearly that this field is not filled. It should be the same for choosing a container." + }, + { + "prediction": "This should be `0` or `-1` or `1` instead of `-1`, `0`, and `1`.", + "reference": "I noticed that passing in `[]` for the locales argument instead of 'undefined' seems to have the same effect. I think that's preferred over passing in `undefined` as a value, and unfortunately passing in `null` seems to throw an error." + }, + { + "prediction": "I think you can use `DbCfg.Host != \"\"` instead of `!strings.HasSuffix(DbCfg.Host, \"]\")`", + "reference": "1. `0` is redundant. 2. We should save result of `strings.LastIndex(DbCfg.Host, \":\")` to a variable and reuse." + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in the same place as `MaxConn` and `MaxRecvMsgSize`, since they're all related.", + "reference": "Do you envision \"new\" servers not supporting header, or is it more a way to test mix of old and new? If so, we could make it a \"private\" (non exported) option." + }, + { + "prediction": "I think this should be `errors.Wrap(err, fmt.Sprintf(\"failed to unmarshal connection config: %s\", config.Provider))`", + "reference": "For future reference. Try not to do refactoring in the same PR which solves some bug or implements some feature. Not to clutter reading. Do it in separate PR." + }, + { + "prediction": "I think this should be `StringSliceVar` instead of `StringVar`", + "reference": "I'm not sure about changing the flag name. unit is more accurate, but for I think for most people asset is also a fine name to use." + }, + { + "prediction": "I think we can remove this function now.", + "reference": "Which windows gets activated? A random other window?" + }, + { + "prediction": "I think we should be able to get rid of this `if` and just do `event.Context = event.Context.WithVersion(cloudevents.VersionV03)` in the `else if r != nil` block.", + "reference": "Just to make sure, this is totally lossless? If I put a v2 there, then it gets upgraded to v3, but my function expects v2, then this is fine and nothing is lost?" + }, + { + "prediction": "I think it would be better to use `WatermarkField` instead of `WatermarkFieldName`", + "reference": "In the past, we have 3 Flink streaming jobs (1 for each AWS region) writing to the same table. We need to write to 3 different watermark table properties (1 for each region). Watermark consumer then use the min value to determine the overall table watermark. A provider pattern similar to `WRITE_LOCATION_PROVIDER_IMPL` can work. A default impl could be a single property name. not sure if there is a simpler way to achieve this." + }, + { + "prediction": "I think this should be `map[keybase1.UID]keybase1.NormalizedUsername`", + "reference": "Can you change this to `ResolvedUsersMap` and build a new map with both readers/writers? That way, we get the nice side effect of not exposing the internal map of the handle, and simplifying the callers a bit." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I could get it to work.", + "reference": "I typically try to avoid nested ternary expressions. Can we rewrite this as if statements? Worst case, can we break it out into its own function?" + }, + { + "prediction": "I think this should be `tls_start.ssl_conn.set_tlsext_host_name(tls_start.context.client.sni.decode())`", + "reference": "Do we still support handshakes without SNI present?" + }, + { + "prediction": "Line is too long. [82/80]", + "reference": "Maybe it's because I work too much on a centralized logging system but it could be great to add a \"category\" like \"attribute\", \"substitution\", \"include directive\", \"macro\", \"extension\"..." + }, + { + "prediction": "I don't think this is the right fix. The problem is that this function is only used in the `__init__.py` file, which is not the same as the `__init__.py` file that this function is used in. The `__init__.py` file is used by all the other files in the module, so this function should be used in the `__init__.py` file, not in the `__init__.py` file that this function is used in. The `__init__.py` file is used by all the other files in the module, so this function should be used in the `__init__.py` file, not in the `__init__.py` file that this function is used in. The `__init__.py` file is used by all the other files in the module, so this function should be used in the `__init__.py` file, not in the `__init__.py` file that this function is used in. The `__init__.py` file is used by all the other files in the module, so this function should be used in the `__init__.py` file, not in the `__init__.py` file that this function is used", + "reference": "it have no sense in python -> it makes no sense in python" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `pkg/portlayer/portpool.go`", + "reference": "maybe just do a separate implementation of the pool for openvpn case? It's a bit confusing having two methods here." + }, + { + "prediction": "I'm not sure if this is the best way to do this.", + "reference": "how is it possible to have a `topology` that is falsey when we had to call `topology.connect` in order to get here?" + }, + { + "prediction": "I'm not sure if we want to stub the `where` call here or not. If we don't, I think we can remove the `expect(PlanFinder).to receive(:where).with(sku: 'sku')` line below.", + "reference": "Do we need this expectation? If we don't call this method on `PlanFinder` there's no way for the `10` to be returned. Seems somewhat redundant. What do you think?" + }, + { + "prediction": "I'm not sure if this is the right place for this change. I think it should be in `edgeconfig.go`", + "reference": "We need to do the same for edgecore" + }, + { + "prediction": "I don't think we need to wait for the event to be set before calling the callback. We can call the callback right after the event is set.", + "reference": "This fix has nothing to do with the product change. Just a fix I am making for the test issue." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `Exporter` class.", + "reference": "Don't know what should be the default. Lets keep BatchingProcessor for now. And revisit the area after beta." + }, + { + "prediction": "I'm not sure if this is a good or a bad thing, but I think it's a good thing.", + "reference": "Ah that's how it's happening, it's probably using the `require_relative` in the optimised one and that counts as a different require to the bare one." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the `IBindingListView` implementation.", + "reference": "What happens if there is no NIB/XIB with that name?" + }, + { + "prediction": "I think this should be `config.Config` and not `config.API`", + "reference": "this is not necessary?" + }, + { + "prediction": "I think this is the wrong place to put this. It should be in the `aws` package, not the `aws-ecs` package.", + "reference": "typo: `asmsecrets \"github...`" + }, + { + "prediction": "I think this should be `wp_json_encode( $allowed, JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE );` instead of `JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE`.", + "reference": "I think that the JSON encoding should be handled by the control itself, not the sanitization function. This should only confirm that the input is correct, not reformat it" + }, + { + "prediction": "Is this TODO still relevant?", + "reference": "Should we put a TODO here to route the http.Transport through here?" + }, + { + "prediction": "I think this should be `cmd := fmt.Sprintf(\"Get-VMSwitch -Name %s | Set-VMSwitch -AllowManagementOS $false \", networkName)`", + "reference": "Sorry, could you explain more about the issue? Doesn't ComputerName already default to local computer? > -ComputerName Specifies one or more Hyper-V hosts on which the virtual switch is to be configured. NetBIOS names, IP addresses, and fully qualified domain names are allowable. The default is the local computer. Use localhost or a dot (.) to specify the local computer explicitly." + }, + { + "prediction": "I think it would be better to use `logger.Warnf` instead of `logger.Printf`.", + "reference": "`allowError` is a big vague. Does this mean the test case is asserting that an error should occur? If it means \"maybe an error can occur, and that's okay\" -- what's an example of this?" + }, + { + "prediction": "I think this should be `nil, nil` instead of `nil, output.NewError`", + "reference": "return statements should not be cuddled if block has more than two lines (from `wsl`)" + }, + { + "prediction": "I think this should be `public final`", + "reference": "Why does VirtualMachineMetrics have to implement Metric?" + }, + { + "prediction": "I think this should be `require.NoError(m.SignVote(vote))`", + "reference": "line is 121 characters" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I could get it to work.", + "reference": "How's that linked esbench looking with slice?" + }, + { + "prediction": "I think this should be `files = self.conn.nlst(dirname)` instead of `files = self.conn.nlst(path)`", + "reference": "The split and join was probably done to ensure that this still works on Windows because os.path.dirname works differently depending on the os you're running under :(. It would probably be a little better to do `dirname, _, fn = path.rpartition('/')` if you want something cleaner than the split/join." + }, + { + "prediction": "I don't think this is the right place to put this. I think it would be better to put it in `SessionMapImpl` since that is where the implementation of this method is.", + "reference": "This is not the right approach. The `Distributor` maintains a model of the current state of the Grid. That model already contains the information about every active session. We don't need to modify `SessionMap` to expose it further." + }, + { + "prediction": "I think this should be done in the `runLoop` loop, and the `maybeResetTimer` should be done in the `runLoop` loop.", + "reference": "Can you make this a member var as all the other deadlines? Then you can drop the param to resetTimer() and simplify some of the code below iiuc." + }, + { + "prediction": "I'm not sure this is the right fix. The problem is that `canonicalize` is called with a `const` `TautomerData` object, and a `const` `TautomerEnumerator` object, but the `TautomerData` object has a `const` `TautomerCatalog` member. So the `TautomerData` object is passed by `const` reference to `canonicalize`, but the `TautomerData` object itself has a `const` `TautomerCatalog` member.", + "reference": "I don't understand the reason for the changes from unique_ptr to ROMOL_SPTR that you made in this file. The pointers aren't being shared or used elsewhere so I don't think there's any reason to make them shared. Did I miss something?" + }, + { + "prediction": "I'm not sure this is the right name for this. I think it should be `PLUGINS` since it's a collection of plugins.", + "reference": "why change the variable name at all?" + }, + { + "prediction": "`vNode` and `node` are both `ShadowRoot`s, but `vNode` is an actual child of `node` and `node` are both `ShadowRoot`s, why do we need to check if `vNode` is the same as `node`?", + "reference": "Since I'm still trying to keep these straight in my head, can you elaborate on what problem this solves?" + }, + { + "prediction": "I don't think this is the right place to check this. I think it should be in the `onMessageUnboxed` method, since that's where the message view is created.", + "reference": "Prefer TextUtils.isEmpty() which handles getReportSpamRecipient() being null" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `Packaging` assembly, but I'm not sure if that's the best place to put it.", + "reference": "Do we actually use Include anywhere yet or is this just for completion?" + }, + { + "prediction": "I don't think we should add a new setting for this. It's not a setting that should be configurable by the user, and it's not a setting that should be sent in the `Referer` header. It's a setting that should be sent in the `X-Accel-Redirect` header.", + "reference": "It still bugs me this was misspelled in the standard and now the wrong spelling is the commonly used one :wink:" + }, + { + "prediction": "I think we should keep the `secondary` class for the `listItemBodyText` and remove it from the `listItemBody` class.", + "reference": "seems we missed de-uglifying this one" + }, + { + "prediction": "I don't think we need a separate type for this. We can just use the existing `NewWorkflowType` constant.", + "reference": "i guess these types & cron / retry specific belong to a dedicated util / struct" + }, + { + "prediction": "I think this should be `setParameter('text', keys.join('')).`", + "reference": "Also update line 2205 below" + }, + { + "prediction": "I think this should be `default: \"vertical\"`", + "reference": "`direction` is referenced nowhere. Do I miss something?" + }, + { + "prediction": "I think we can remove this now that we have `deparam` imported from `npm:deparam`", + "reference": "The two places this was used have been removed so we can fully remove this dependency." + }, + { + "prediction": "Why is this removed?", + "reference": "This is a duplicate generation of the same file as below." + }, + { + "prediction": "I think it's better to check `gpu_ids` in `MMDataParallel` constructor and pass it to `MMDataParallel(model.cuda(gpu_ids[0]), device_ids=gpu_ids)` in `MMDataParallel(model.cuda(gpu_ids[0]), device_ids=gpu_ids)`.", + "reference": "We may deprecate `gpus` if `gpu_ids` is specified." + }, + { + "prediction": "`LOG.finest` should be used in the `finally` block, otherwise it will not be logged if an exception is thrown.", + "reference": "Right now this is experimental and deeply flaky. We left this at `info` to make debugging user reports a lot easier." + }, + { + "prediction": "I don't think this is the right way to do this. We need to do it in a way that is compatible with the rest of the codebase.", + "reference": "unnecessary spaces here are doubling the size of this otherwise extremely useful addition" + }, + { + "prediction": "I think this should be `CopyDirectoryRecursively(TracerHomeDirectory, DDTracerHomeDirectory, DirectoryExistsPolicy.Merge, FileExistsPolicy.OverwriteIfNewer);`", + "reference": "I think we should use `FileExistsPolicy.Overwrite` instead. Files _should_ always be newer, but in the unlikely case they wouldn't be, I'm afraid some files would be overwritten and other not, leading to inconsistencies that will be hard to figure out." + }, + { + "prediction": "I think this should be `std::cout << \"test3_5\" << std::endl;`", + "reference": "this should probably be removed" + }, + { + "prediction": "I'm not sure this is the right place for this test. I think it should go in `test/integration/test-config-daemon.go`", + "reference": "Nit: I would actually prefer that pretty JSON is the default, with a flag for compressed JSON. Can we acheive that easily?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `NetworkConfig` since that is the place where we configure network settings for the cluster.", + "reference": "Will need to think about this one. `additionalIngressRules` feels a bit opaque in terms of eventual outcome." + }, + { + "prediction": "I think this should be `public static int fieldId(TypeDescription orcType);` instead of `static int fieldId(TypeDescription orcType);`", + "reference": "Can we avoid making this public with the other updates?" + }, + { + "prediction": "I don't think this is correct. The size of `datum_vector` should be equal to the size of `transformed_blob`.", + "reference": "Why did you change this equal instead of less or equal?" + }, + { + "prediction": "I'm not sure this is the right place for this method. I think it should be moved to `MutableWorldState#getMutable()`.", + "reference": "missing final for the blockHash field" + }, + { + "prediction": "I'm not sure if this is a good or a bad thing. I'm not sure if we want people to be able to run `factory_bot` from the command line or not.", + "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." + }, + { + "prediction": "I think it would be better to use `nn.functional.l2_norm` from nn module here.", + "reference": "`x_float` instead of `float_x`." + }, + { + "prediction": "I think it's better to use `import` instead of `import swiper-bundle.esm`", + "reference": "Is this for `No Babel config ...` from ESLint? If so, it will be fixed in my ES6 PR." + }, + { + "prediction": "This should be `return fmt.Errorf(\"expected state %+v to equal %+v\", state, s)`", + "reference": "Not important, but the code used to keep checking other cases even after one of them failed, and now it's not. Fine either way for me, just noticing." + }, + { + "prediction": "I think we can remove this line.", + "reference": "I think I saw this line in last PR, you can update your base branch and rebase to avoid this. And it would be awesome if you can rebase instead of merge each time you push PR to the `moby` branch, that will make the commits history clearer." + }, + { + "prediction": "I think this should be `if (get_thread_id() == tid)` instead of `if (get_thread_id() == tid) {`", + "reference": "If this can change the PC of this thread, it requires handling: we can't blindly execute the syscall and lose control of the thread when the flags include CONTEXT_CONTROL. (Note that most docs imply that setting your own context this way is not supported or has undefined or unpredictable results: any idea how often that's the case, or does it generally work?) We need to handle in a similar fashion to NtContinue or setting another thread's context to ensure we retain control." + }, + { + "prediction": "I don't think we need this method. We already know the total number of products by calling the `/count` endpoint.", + "reference": "@huzaifaiftikhar Changed the endpoint as suggested by Stephane in the latest commit." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `pkg/numbers.go`", + "reference": "There's no core.Number yet. ;)" + }, + { + "prediction": "I think this should be `snapshot revert --volname --snapname --force`", + "reference": "..., ...will be posted." + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think it should be in the `go-filecoin` command, but I'm not sure if that's the right place to do it.", + "reference": "Can you update this function to be `ShowHeader`? There is only one use of it at the moment in `tools/fast/series/get_head_block_height.go`." + }, + { + "prediction": "I think this should be `DISABLE_TQDM = os.getenv('DISABLE_TQDM', False)` instead of `DISABLE_TQDM = os.getenv('QUILT_USE_TQDM', False)`", + "reference": "@akarve, this disables `tqdm` by default, is it intended? Also name `QUILT_USE_TQDM` might be too specific, IMHO `QUILT_INTERACTIVE` or `QUILT_PROGRESS_BARS` or something might be better." + }, + { + "prediction": "I'm not sure this is the right place for this test. I think it should go in `testAccCheckDockerEngineState`.", + "reference": "unrelated but just changing for consistency with code below it" + }, + { + "prediction": "I'm not sure this is the best way to do this. I think we should be able to just do `if (component.shouldComponentUpdate(props, state, context)) { component.componentWillUpdate(props, state, context); }`", + "reference": "This will call `componentWillUpdate()` for mounts because the else clause is removed. It should only be called for updates." + }, + { + "prediction": "I think this should be `['read', 'write']` instead of `['write', 'read']`.", + "reference": "We should add write inheritance too." + }, + { + "prediction": "I think it would be better to use `os.environ.get('JAVA_OPTS', '')` instead of `os.environ.get('JAVA_OPTS', '').strip()`", + "reference": "Please rename this to `LAMBDA_JAVA_OPTS`, and add a short description to the README." + }, + { + "prediction": "I'm not sure if this is the right place for this change. I think it should be in `github.com/pulumi/pulumi/pkg/util/grpc` since that's where the rest of the gRPC code lives, and this file has nothing to do with the Pulumi engine or gRPC at all.", + "reference": "Should be in the same import group." + }, + { + "prediction": "I'm not sure this is the right place to put this check. I think it should be in the `if pkt.tls_session.tls_version > 0x0200 and pkt.type == 23` check above.", + "reference": "Operator precedence is very confusing here. Care to add parentheses? ` ((version or 0x0303) >= 0x0200)` Same below." + }, + { + "prediction": "I think you can remove this import.", + "reference": "javaparser-core has no dependencies and it should stay that way. So no log4j. And even then there would have been a preference for slf4j." + }, + { + "prediction": "I don't think this is the right place to put this. I think it would be better to put it in the `FileUtil` class itself.", + "reference": "Why not just retest all? it's not expensive (I think)." + }, + { + "prediction": "I think this should be `ecr0` instead of `ecr` to match the rest of the code.", + "reference": "ecr and ecr0 aren't deterministically named here. This change will just cause confusion in the git history. Could you either: a) fix this and make it deterministic b) regenerate the mock until it doesn't flip definitions for ecr and ecr0" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be under `ENV['HOME'] + '/.rvm/bin'` since that's where `sudo apt-get install` is done.", + "reference": "This looks like bash... does this work in ruby? Or is the idea to inject the entire script into the subsequent commands?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do it in the `TraceContext` ctor.", + "reference": "I don't understand why this change is in this PR?" + }, + { + "prediction": "I'm not sure if we should deprecate this behavior at all. I think it's fine to leave it as it is for now, but I'm not sure if there's a compelling reason to deprecate it. If we decide to deprecate it, I think we should add a note to the deprecation docs explaining why we decided to deprecate it.", + "reference": "It's a little hard to tell from the diff, but as a result of this PR, the only non-deprecated helpers are: - `has_facet_values?` (probably not long for this world) - `render_facet_partials` (perhaps part of a future component) - `render_facet_limit` (possibly obsolete once components get traction) - `facet_field_in_params` (a little tricky to deprecate at the moment) - `facet_field_presenter`" + }, + { + "prediction": "I'm not sure this is the right fix. The problem is that `PersonObject` is not a subclass of `Realm.Object`, so `PersonObject.prototype` doesn't have `__proto__`. I think we need to do something like `PersonObject.__proto__ = Object.create(Realm.Object.__proto__)`", + "reference": "The right-hand part shouldn't use `__proto__`. Should be just `PersonObject.__proto__ = Realm.Object`." + }, + { + "prediction": "I think this should be `panic(fmt.Sprintf(\"taskManagerImpl encountered MinTaskID >= MaxTaskID: %v vs %v\", request.MinTaskID, request.MaxTaskID))`", + "reference": "the == case might be legit, or not? If there is no task written since last read, but we trigger a new read, would the min == max? Or should the upper layer handle that case?" + }, + { + "prediction": "I think this should be `new_size` instead of `old_size`.", + "reference": "Good catch! But is it guaranteed that `old_size < new_size` here? If not, wouldn't we want to take `min(old_size, new_size)` as the copy length?" + }, + { + "prediction": "I think this should be marked as `MemberHiddenFromStaticInnerTypes` instead of `MemberHidesStaticFromOuterClass`", + "reference": "This is the only one that worries me a bit. It would be good if Brendan signed off on it." + }, + { + "prediction": "Should this be `Optional#hasLongrunningReturnValue()`?", + "reference": "`LongRunningOperationDetailView` already has `isEmptyOperation`." + }, + { + "prediction": "I think it would be better to use `urllib.quote_plus` instead of `base64.b64encode`", + "reference": "This will always add the authorization header to the request object. Is this the right scope for these two lines? If username/password are not defined, it will encode 'Basic :'" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Don't think a scope adds much value for us here. Also, for future reference, you don't need to use the `self.all` it is implied. Could just be: `scope :updated_at_desc, -> { order(updated_at: :desc) }` No need to change this one now though, it works." + }, + { + "prediction": "I think this can be simplified to `return Base.rand(0, 9).round if digits == 1`", + "reference": "I believe `Base.` is unnecessary in this case, as the class already extends `Base`." + }, + { + "prediction": "I'm not sure this is the right place for this function. I think it should be in `ServerConnection` since it's only used by that class.", + "reference": "Couldn't this result in images being scaled too small when the width is less than the height assuming the width is still what is being passed here?" + }, + { + "prediction": "I think we should move this to the top of the file, since it's used in multiple files.", + "reference": "Here also, let's not cache value on top of file, but use `plugins.getConfig(\"api\").offline_mode` directly where it is needed" + }, + { + "prediction": "I think this should be `&& $this->getAuthManager()->getAuthMethod() === 'Shibboleth'` instead of `&& ($this->getAuthManager()->getAuthMethod() == 'Shibboleth')`", + "reference": "You can combine the two checks into a single `!empty()` check." + }, + { + "prediction": "I think this should be `o.MaxPayload > o.MaxPending`, since the former is the max that can be set by the user, and the latter is the max that should be set by the validator.", + "reference": "Should we add a warning for anything over say 8M? Just suggesting that is not recommended?" + }, + { + "prediction": "I think this should be `currentUID` instead of `mergedMasterHead`", + "reference": "Looks like there are no callers left of this function." + }, + { + "prediction": "I think this should be `attachStdin: false` instead of `attach: false`.", + "reference": "Should there still be a ` bool` trailing `showOutput`?" + }, + { + "prediction": "remove this empty line?", + "reference": "Did we can change to v1" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but it seems like we should be able to do it in the `diffChildren` function.", + "reference": "Can you please double check that this won't break anything?" + }, + { + "prediction": "I don't think we need to pass null here.", + "reference": "optionals, shouldn't need to be stated explicitly" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `pkg/version.go`", + "reference": "That seems quite low - why not just 0x5130ffff?" + }, + { + "prediction": "I don't think this is the right way to do it. You should be able to do `__str__` on a `Gen` object and it will return the string representation of the underlying `Net` object.", + "reference": "Why is this needed ?" + }, + { + "prediction": "Do we need this method? I don't see it being used anywhere in the codebase.", + "reference": "`Bolt::Config.user_path` returns `nil` if there's no homedir, so this will still error in that case." + }, + { + "prediction": "I think this should be `a.Tag == protocol.ProposalPayloadTag` and not `a.Tag == protocol.ProposalPayloadTag`", + "reference": "nit: use %s for strings and %v for objects." + }, + { + "prediction": "Why remove these?", + "reference": "Same as before, the properties already exists in parent" + }, + { + "prediction": "I think it would be better to use `nuget_str = f\"\"\"\n+ \n \n LightGBM\n %s\n```", + "reference": "This fix is not quite correct. The `%s` should be replaced with `version` and the `%d` on line 39 should be replaced with `datetime.datetime.now().year`." + }, + { + "prediction": "I think this should be `strcmp(\"gone\", type) != 0`", + "reference": "Maybe we should only set active = false if `strcmp(type, \"pause\") == 0`?" + }, + { + "prediction": "I'm not sure this is the right place for this method. I think it should be in the `Selenium::WebDriver::Chrome` module.", + "reference": "Same here. and all others." + }, + { + "prediction": "I think this should be `github.com/songgao/stacktraces/on/stacktrace`", + "reference": "Intentionally committed? I'm not against it, we already have a way to get goroutines without killing the process: `/keybase/.kbfs_profiles/goroutine`." + }, + { + "prediction": "I'm not sure if this is the right way to do this. I think it's better to have a function that generates a new GuidPrefix_t.", + "reference": "I think this blank line may be removed" + }, + { + "prediction": "I think this should be \"raise an error if it already exists\".", + "reference": "I think this should be a keyword-only argument, i.e. do `def add(self, url, title, *, toggle=False):` and adjust the caller to do `toggle=toggle`." + }, + { + "prediction": "I think this should be `UINT8` instead of `UINT32`.", + "reference": "@aimanrosli23 Judging from the commit description, I do not know why this file got changed so much. Could you help to double confirm if you do not revert the changes brought by commits: SHA-1: 643623147a1feaddd734ddd84604e1d8e9dcebee * MdeModulePkg/SdMmcPciHcDxe: Send SEND_STATUS at lower frequency SHA-1: 49accdedf956f175041040e677163b7cbb746283 * MdeModulePkg/SdMmcPciHcDxe: Hook SwitchClockFreq after SD clock start" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I could come up with that works.", + "reference": "How about YAML.load_file()" + }, + { + "prediction": "nit: can we rename this to `isContainerDispatchFail`?", + "reference": "Maybe make this `volatile` or atomic as this can be set/read from different threads? Also, separately you may want to check if some of the methods here need to be `synchronized`." + }, + { + "prediction": "Shouldn't this be done in `drwrap_exit()`?", + "reference": "Check the return value of the drmgr ones." + }, + { + "prediction": "I think we can remove the `data-cfasync` attribute from `js/fileupload.js` as well.", + "reference": "This should be `'cache'`" + }, + { + "prediction": "I think this should be `error`, not `nil`.", + "reference": "The name \"old\" might cause confusion here. After installation, the \"old\" repo is at an archived path, and the new migrated repo is at the old path. Maybe something like \"target\" or \"canonical\"?" + }, + { + "prediction": "I think this should be done in the `resolveReadPreference` function.", + "reference": "I think this is somewhat definitive proof that this error exists in `core` rather than `native`. We are correctly resolving the `readPreference` in the previous line, but you are able to identify that eventually the command generated in `core` is not decorated with the passed `readPreference`. Did you try to solve this there already?" + }, + { + "prediction": "I think this should be `unwindTo = (to + s.BlockNumber) / 2 + 1`", + "reference": "During genesis sync it can unwind 5M blocks?" + }, + { + "prediction": "I think this test is failing because `s.ticker()` isn't being run in a goroutine. I'm not sure if that's a bug in the engine, or if it's a bug in the test.", + "reference": "was it caused by the removal of removeTaskQueueManager() from this test?" + }, + { + "prediction": "Use %i or %I for an array of symbols.", + "reference": "Wouldn't it just be easier to force search_session to return `with_indifferent_access`? Since you've done the hard work already, I don't think there's a problem doing it this way, but.." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `if (rp->schedule_backoff > gstate.now)` check above.", + "reference": "So, such tasks that could possibly not meet the deadline will never have a chance to run? I think this is not nice behavior, especially for those projects who has sometimes some very small tasks after the big one." + }, + { + "prediction": "This should be `return 0;` instead of `return 1;`", + "reference": "You should add the check above this line instead. If string is empty, don't even call the function." + }, + { + "prediction": "I think it would be better to use `item.getBoolean(KEY_CLIENT_CERT)` instead of `item.getBoolean(KEY_CLIENT_CERT)`", + "reference": "If clientCert attribute doesn't exist for some reason I set it to false." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `if` clause of the `if casher_branch == 'production'` block.", + "reference": "Do we need `app_host_flags` variable? We can directly concat with `flags`. `sh.cmd curl_cmd(unless Travis::Build.config&.ssl&.verify ? flags + ' -k' : flags, location, static_file_location), cmd_opts` right?" + }, + { + "prediction": "This should be done in `stopEventWalk`.", + "reference": "Walk should actually be completed (`onWalkCompleted`) after the event is stopped. This also makes it possible for monster to walk by smaller paths." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the `Get` method of the `SimpleJoiner`.", + "reference": "typo in `weather` (should be `whether`)" + }, + { + "prediction": "This flag is for testing only. Set to true to upgrade with staging windows install media.", + "reference": "Thoughts on having the URI as the param, instead of a boolean? The default value would be the normal prod image, and then your test would override with the staging image." + }, + { + "prediction": "I'm not sure this is the right way to do this. The `fopen` and `fread` should be done in a way that doesn't leak file descriptors.", + "reference": "I'm surprised this is needed, but we should probably assert num_scan == 1 at least, otherwise I expect the file is pretty broken." + }, + { + "prediction": "I think this should be `std::unique_ptr(TestUtils::initKV(rootPath.path(), partitions, {0, network::NetworkUtils::getAvailablePort()})`", + "reference": "Could we set a default value for `partitions` and `{0, network::NetworkUtils::getAvailablePort()}` ?" + }, + { + "prediction": "I think this should be named `RequestBodyTimeout` instead of `RequestBodyTimeouts`", + "reference": "Needs xml docs. The API names alone don't provide enough explanation about what these mean and how to set them. Also, we should provide some validation of inputs, such as MaxTime must be > MinTime, MinimumRate must be >= 0, etc. Consider making the properties readonly and adding a constructor that does these validations." + }, + { + "prediction": "I think this should be `path.Join(os.TempDir(), \"testdata\", name)`", + "reference": "Would it make sense to create an empty file here, perhaps in a tmp dir, instead of checking empty files into Git?" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I've been able to get it to work.", + "reference": "This change is due to `clang_format` and is not related to this PR." + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think it should be done in `sigaction.c` instead of `sigprocmask.c` since that is where `sigaction` is defined.", + "reference": "Why did you not add the signals to the call of block_all_signals_except() and instead baked them into the function? Ok, if you had a good reason for it, otherwise I would add it to the except list of the function call, since that's what it was meant for." + }, + { + "prediction": "I'm not sure if this is the right place for this interface. Feeds are a different thing. Feeds should be able to tell if a file has been downloaded or not. Feeds should be able to tell if a file is in the downloads list or not. Feeds should be able to tell if a file has been downloaded or not. Feeds should be able to tell if a file is in the downloads list or not. Feeds should be able to tell if a file has been downloaded or not. Feeds should be able to tell if a file is in the downloads list or not. Feeds should be able to tell if a file has been downloaded or not. Feeds should be able to tell if a file is in the downloads list or not. Feeds should be able to tell if a file has been downloaded or not. Feeds should be able to tell if a file is in the downloads list or not. Feeds should be able to tell if a file has been downloaded or not. Feeds should be able to tell if a file is in the downloads list or not. Feeds should be able to tell if a file has been downloaded or not. Feeds should be able to tell if a file is in the downloads list", + "reference": "Could this be done by mocking objects instead? I feel like this is changing too much of the actual logic just for the tests." + }, + { + "prediction": "I don't think this is needed.", + "reference": "why not just use `ManifestContent` instead of `Integer`?" + }, + { + "prediction": "I'm not sure this is the right place for this check. I think it should be in the `TxPool.AddTx` method, since that's where the transaction is actually being added to the pool.", + "reference": "can we do that in TxValidator?" + }, + { + "prediction": "I think we can remove this interface and just use the `ServiceName` field in the `Outbound` struct.", + "reference": "We definitely want some detailed and thoughtful docs being added to this type." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `if config.BPFEnabled && config.XDPEnabled {` block.", + "reference": "We would like this code to run, even when `config.XDPEnabled` is false, so that Felix can clean up its own XDP state after a restart." + }, + { + "prediction": "I think we should move this to `space.cpp` since it is not used in `kvstore.cpp` and `kvstore_impl.cpp`.", + "reference": "If the status is `ERR_SPACE_NOT_FOUND` why return `SUCCEEDED` ?" + }, + { + "prediction": "reverse (bool): If it's `True`, the order of input planes will be reversed after passing through this layer. Before passing through this layer, the order of input planes should be: (1, 3, 4, 6, 15). After this layer, the order of planes should be: (1, x, x, x, x). If it's `False`, the order of input planes will not be reversed before being passed to this layer. Otherwise, this layer does not reverse the order of input planes.", + "reference": "It is is more appropriate to use `downsample_first`. If `downsample_first=True`, the downsample block is the first block and it is used for ResNet. If `downsample_first=False`, the downsample block is the last block, which is used by Hourglass network." + }, + { + "prediction": "I think this should be `service = getDefaultService() || service.start();`", + "reference": "Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`)" + }, + { + "prediction": "I think this should be `Consider using sys.exit()` instead of `Consider using the sys.exit()`", + "reference": "I don't know if there are strict conventions about this, but I think the name of the warning should be the diagnosis, not the suggested course of action. In this case, that would mean changing the name of the warning to `interactive-exit` or something like that." + }, + { + "prediction": "I think this should be `pki.CommonNameForCertificate(crt)`", + "reference": "If `crt.Spec.CommonName` is not set, and `cert.Subject.CommonName` *is* set, we are not correctly handling it here." + }, + { + "prediction": "I don't think we should be using `cmdhistory` and `fprompthistory` in tests.", + "reference": "This isn't a test, so it shouldn't be named `test_init`. You could name it `cmdhistory_init` or so." + }, + { + "prediction": "I think this should be `configuration.get_config(self.spark_version, \"pickle-protocol\", default=pickle.DEFAULT_PROTOCOL)`", + "reference": "why is this pulling from `self.spark_version` config section rather than the `spark` config section (`py-packages` appears to pull from a config section called `spark`)" + }, + { + "prediction": "I think this test should be moved to `test/testutil.go`", + "reference": "nit: Think it can be one line.." + }, + { + "prediction": "This import is not used anymore.", + "reference": "please inline imports" + }, + { + "prediction": "I think this should be `p.config.Rootless && len(p.cgroupPaths) > 0`", + "reference": "This check is still correct in some cases, but I guess erroring out is acceptable if someone explicitly asked for an impossible cgroup configuration (now that we could in principle nest things). I would like to see a test for this though." + }, + { + "prediction": "I'm not sure if this is something that should be fixed in this PR, or if it should be a separate PR.", + "reference": "Should we update integral to operate on a single column as well?" + }, + { + "prediction": "Why do we need to call `cuda_get_deep_copy_stream()` here?", + "reference": "Doesn't belong to this PR" + }, + { + "prediction": "Nit: I think we should call this `RegisterContainerInstanceWithRegistrationToken` to be consistent with the rest of the client.", + "reference": "Just for my own understanding, does aws ecs API take this token as a new input attribute? Which version of the aws sdk? I did not find it in the official aws sdk doc." + }, + { + "prediction": "I think this should be called `USER_AUTH_FEATURE_CODE`", + "reference": "Could we shorten this constant to maybe `FEATURE_USER_AUTH`?" + }, + { + "prediction": "I'm not sure this is a good number to start with. If we have 1000s of workers, we could end up with 1000s of concurrent rekey requests.", + "reference": "Any particular reason for 8? I feel like we could probably handle more..." + }, + { + "prediction": "I think this should be `must_not_be` instead of `must_equal`", + "reference": "Try to use factory association declaration for default values, so it could minimal the line length. You may write in fetch_job factory like association :repository, factory: :repository." + }, + { + "prediction": "I'm not sure if this is a good idea, but I don't have a better suggestion.", + "reference": "Should the \"cancelled\" class be added regardless of the proposal's state?" + }, + { + "prediction": "I think we should remove this empty line.", + "reference": "nit: random whitespace change, let's try to keep these out of commits unless there are other useful changes." + }, + { + "prediction": "I think this should be `var models = model.split(' ');` instead of `var models = undefined;`", + "reference": "Seems kinda dangerous - what if models length is different from paths length?" + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think it should be in `stageSenders`, but I'm not sure if it's the right place to do it. I think it should be in `stageSenders`, but I'm not sure if it's the right place to do it. I think it should be in `stageSenders`, but I'm not sure if it's the right place to do it. I think it should be in `stageSenders`, but I'm not sure if it's the right place to do it. I think it should be in `stageSenders`, but I'm not sure if it's the right place to do it. I think it should be in `stageSenders`, but I'm not sure if it's the right place to do it. I think it should be in `stageSenders`, but I'm not sure if it's the right place to do it. I think it should be in `stageSenders`, but I'm not sure if it's the right place to do it. I think it should be in `stageSenders`, but I'm not sure if it's the right place to do it. I think it should be in `stage", + "reference": "set real one plz (get it from DB)." + }, + { + "prediction": "I'm not sure this is the right place to do this. It seems like it would be better to do this in the `fpga_uafu_irq_set_update()` function, since that is the place where the `fpga_port_uafu_irq_set_update()` function is called.", + "reference": "Should this be initialized to zeroes?" + }, + { + "prediction": "I think this should be `fcontext.base.size() == 0` instead of `q == null || fcontext.base.size() == 0`", + "reference": "The query is already built at this point, so I don't think this particular change actually helps wrt SOLR-10732? (and the `base.size()==0` case is already trivially optimized in `SolrIndexSearcher.numDocs(Query, DocSet)`)" + }, + { + "prediction": "I think this should be `@Getter`, not `@Slf4jGetter`", + "reference": "re-add the type in the annotation here" + }, + { + "prediction": "I think this should be `stderr` and not `stderr.String()` because `stderr` is a `bytes.Buffer` and `String()` on a `bytes.Buffer` returns the string representation of the buffer, whereas `stderr.String()` on a `bytes.Buffer` returns the string representation of the underlying buffer.", + "reference": "Could we simpify it as `cmd.Stderr = &bytes.Buffer{}`?" + }, + { + "prediction": "I think this should be called `X509NotBeforeExpired` or something like that.", + "reference": "there's enough \"nots\" in here that while it's correct by my review, I'd like to see a small unit test (just passing in an expired and non-expired cert)" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `pkg/convert/svc`", + "reference": "File is not `goimports`-ed (from `goimports`)" + }, + { + "prediction": "I don't think this is a good name for a parameter. It's not a tolerance, it's a relative error.", + "reference": "The config option should probably have a more specific name. Also it's not for all gridded data but specifically for Images (and its subclasses)." + }, + { + "prediction": "I think this is the right thing to do, but I don't understand why we need to wait for the element to become visible before we click it. Is there a reason we can't just use `clickPreference(otherTheme);` and wait for the element to become visible?", + "reference": "Be careful. This is not a preference but an option in a dialog." + }, + { + "prediction": "I'm not sure if this is the right place to set the cluster name. I think it should be done in the `Deployment` struct, but I'm not sure how to do it.", + "reference": "this will modify the incoming object, which may not be desirable in some cases. i think we should stick with the local var, override it with deployment.ClusterName if deployment.ClusterName not empty" + }, + { + "prediction": "Why is this needed? I don't see it being used anywhere in the test.", + "reference": "Is this not required?" + }, + { + "prediction": "I think this should be `if (input.type === 'value') {`", + "reference": "You're using scare quotes on these terms instead of defining them." + }, + { + "prediction": "I'm not sure if this is the minimum version required by ddev, but I think it should be at least `1.10.0`.", + "reference": "These should both be const, not var right?" + }, + { + "prediction": "I think it would be better to use `Files.newOutputStream()` instead of `FileOutputStream`", + "reference": "Can you catch a more specific exception here? Thanks :-)" + }, + { + "prediction": "I think this should be `return nil, nil` instead of `return ctrl.Result{Requeue: true}, nil`", + "reference": "This is a bug during handling the recover logic in `common chaos` controller, I fixed in this request when I found it." + }, + { + "prediction": "`score_thr` is not used in this function, please remove it.", + "reference": "During testing, we adopt the score threshold specified in the config file. Here the threshold is only used for visualization, and the variable name `score_thr` can be misleading. Renaming it to `show_score_thr` would be better." + }, + { + "prediction": "I think this should be wrapped in a `
`", + "reference": "can you make this `nav-primary` please? i'd like to roll with this since the `
    ` class is `nav`, and primary is the name of the navigation menu" + }, + { + "prediction": "I think this should be `context.calendar.displayname.replace(/\\s+/g, '-').replace(/[^\\w\\-]+/g, '').replace(/\\-\\-+/g, '-').replace(/^-+/, '').replace(/-+$/, '')`", + "reference": "@georgehrke Just out of curiosity. Couldn't you combine at least the combine the regex for '-' and '' with groups?" + }, + { + "prediction": "I'm not sure this is the best place to do this, but I don't have a better suggestion.", + "reference": "I think this is objectively better than looking up the object by name. As a follow-up, I'm going to see whether we do this name-based lookup somewhere else and switch to your method." + }, + { + "prediction": "I'm not sure this is the right fix. The problem is that `statusButtonWidth` is calculated from `flyoutWidth_ - statusButtonWidth - marginX`, so if `statusButtonWidth` is larger than `flyoutWidth_ - marginX`, then `statusButtonX` will be smaller than `marginX - this.flyoutWidth_`. I think we need to calculate `statusButtonX` based on `statusButtonWidth` and `flyoutWidth_ - statusButtonWidth - marginX`, not `flyoutWidth_ - statusButtonWidth - marginX`.", + "reference": "Why are you dividing by scale in the LTR case but not the RTL case?" + }, + { + "prediction": "I don't think we need to add this to the `COMMANDS` list, since it's not really a command. It's more of a `POST` request, right?", + "reference": "Update after command rename" + }, + { + "prediction": "I think this should be `googlesitekit.ModuleSettingsDetails-${ moduleSlug }` instead of `googlesitekit.ModuleSettingsDetails-${ moduleSlug }-${ moduleSlug }`", + "reference": "I added this change to fix a bug with the legacy settings wrapper which was preventing it from working properly with the other modules" + }, + { + "prediction": "I think this should be 1.0, not 2.0. The 2.0 version is for Azkaban v2.0.", + "reference": "isn't AZKABAN_FLOW_VERSION_2_0 more explicit?" + }, + { + "prediction": "I think this should be a warning dialog, not a crash dialog.", + "reference": "Please don't leave an empty default" + }, + { + "prediction": "Please remove this empty line.", + "reference": "This isn't directly related, but the `import React from 'react';` below should be removed. We never import this directly and any modules from it we need are imported through `@wordpress/element`. This was probably added automatically at some point, but we also provide this automatically via `ProvidePlugin`." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think it would be better to use `brew install` with the `--force` and `--with-libs` flags.", + "reference": "You can also use `echo: false` instead. Either is fine; I'm just pointing it out." + }, + { + "prediction": "I'm not sure this is the right fix. The problem is that the `BaseInitializeLayout` is called before `InitializeLayout` is called. This means that the `Delimiter` property will be set to `CsvColumnDelimiterMode.Auto` when the `BaseInitializeLayout` is called, but it will not be set to `CsvColumnDelimiterMode.Auto` when the `InitializeLayout` is called. This means that the `Delimiter` property will be set to `CsvColumnDelimiterMode.Auto` when the `BaseInitializeLayout` is called, but it will not be set to `CsvColumnDelimiterMode.Auto` when the `InitializeLayout` is called. This means that the `Delimiter` property will be set to `CsvColumnDelimiterMode.Auto` when the `BaseInitializeLayout` is called, but it will not be set to `CsvColumnDelimiterMode.Auto` when the `InitializeLayout` is called. This means that the `Delimiter` property will be set to `CsvColumnDelimiterMode.Auto` when the `BaseInitializeLayout` is called, but it will not be set to `CsvColumnDelimiterMode.Auto` when the `InitializeLayout` is called. This means that the `Delimiter` property will be set to `CsvColumnDelimiterMode.Auto", + "reference": "what's the reason for this moved line?" + }, + { + "prediction": "I think we can remove the `showTitle` variable now, since we don't use it anymore.", + "reference": "I don't really follow what is happening here, but it looks like this _could_ conflict with the logic on the lines above... should this be an `else if`?" + }, + { + "prediction": "I don't think this is the right place to do this. I think it should be in the `GetSequencePoints` method.", + "reference": "`s => s.IsHidden == false` What's the purpose of adding this?" + }, + { + "prediction": "I think it would be better to call this `clef-signer-addresses` or `clef-signer-endpoints` to make it clear that it is an array of addresses.", + "reference": "I would name this `clef-ethereum-address`. We already have a bunch of addresses in Bee, and people might wrongly think that this is yet another address" + }, + { + "prediction": "I don't think this should be skipped.", + "reference": "you can just remove this" + }, + { + "prediction": "I think we should rename this to `upgrade-cstor` or `upgrade-cstor-storage` or `upgrade-cstor-volume` or something like that so that it's not confused with the storage pool upgrade task.", + "reference": "I think we should avoid creating a dummy CR in the case of SPC. Please see if we can avoid this since we will not be patching anything in this CR." + }, + { + "prediction": "I'm not sure this is the best place to put this. I think it would be better placed in `app/views/products/_locked_features.html.erb`", + "reference": "Honestly not sure myself, but do you think it makes sense to move this conditional into the partial?" + }, + { + "prediction": "I think this should be `args.basedir = tempfile.mkdtemp(prefix='qutebrowser-prefix-') or tempfile.mkdtemp()`", + "reference": "As discussed in IRC (just so it doesn't get lost): This probably should be `-basedir-`, not `-prefix-`" + }, + { + "prediction": "I think this should be `Path.Combine(directory, basePath, \"Nethermind.Db.DBOnTheRocks\")`", + "reference": "basepath can be absoluta path and this needs to be supported" + }, + { + "prediction": "This should be `const ScreenPosition&`", + "reference": "Didn't get to the commit message" + }, + { + "prediction": "Layout/ExtraSpacing: Unnecessary spacing detected.
    Layout/SpaceBeforeBlockBraces: Space missing to the left of {.
    Layout/SpaceBeforeBlockBraces: Space missing to the left of }.", + "reference": "What about raising `ActionView::MissingTemplate` instead? That's what HighVoltage does." + }, + { + "prediction": "This should be `balance.second.convert_to (balance.second.receivable).convert_to (balance.second.receivable).convert_to (balance.second.receivable).convert_to (balance.second.receivable).convert_to (balance.second.receivable).convert_to (balance.second.receivable).convert_to (balance.second.receivable).convert_to (balance.second.receivable).convert_to (balance.second.receivable).convert_to (balance.second.receivable).convert_to (balance.second.receivable).convert_to (balance.second.receivable).convert_to (balance.second.receivable).convert_to (balance.second.receivable).convert_to (balance.second.receivable).convert_to (balance.second.receivable).convert_to (balance.second.receivable).convert_to (balance.second.receivable).convert_to (balance.second.receivable).convert_tom_Name.copy(name, *size);`", + "reference": "Let's use `if(name != nullptr)` to remove ambiguity" + }, + { + "prediction": "I don't think we should add these methods to `NameFormatterDelegator` as they are not really related to `NameFormatterDelegator`. I think they should be moved to `NameFormatter`.", + "reference": "I wonder if it would make sense to have a separate namer for metadata? Metadata files tend to be expressed in a different language from the repo language, and have mutually exclusive concepts. So, `PackageMetadataNamer`." + }, + { + "prediction": "I think it would be better to have this as a constructor parameter.", + "reference": "This rule is quite specific to qbft and so I don't think it should be part of the common rules. Would rather the common bft code didn't know anything about contract based voting/validator governance." + }, + { + "prediction": "I don't think this is the right place to add this method. I think it would be better to add it to `Traversable` or `Function1`.", + "reference": "This makes our life harder than it needs to be. A Set is unordered by definition. Please remove this method from Set and add it to SortedSet, but with no default implementation. We need to duplicate it then to LinkedHashSet but that's ok, it is the best we can do. Could you please add it also to SortedMap and LinkedHashMap? We are then able to close the original issue." + }, + { + "prediction": "I think this should be `if response_headers is not None and len(response_headers) > 0:`", + "reference": "we can replace `for` with `params.update(response_headers)`" + }, + { + "prediction": "Why is this not needed anymore?", + "reference": "Any chance this is available in .NET Core 2.0 now?" + }, + { + "prediction": "nit: I think it would be better to use `peerstore` instead of `p2p` here.", + "reference": "I wonder if it's necessary to let app pass in the context. What app level context should be sent? If no, is it enough for p2p agent to compose a context with network info there?" + }, + { + "prediction": "Why is this needed? The profiling is already done in `lbann/utils/profiling.hpp`.", + "reference": "Why do we need both includes here?" + }, + { + "prediction": "This should be `cursor.getCount()` instead of `cursor.moveToFirst()`, right?", + "reference": "SmartStoreInspectorTest expected results in a certain order" + }, + { + "prediction": "I think this should be `m_using_random_node.count(m_io_thread_pool->get_local_thread_id())` instead of `m_io_thread_pool != nullptr && m_using_random_node.count(m_io_thread_pool->get_local_thread_id())`", + "reference": "I think that you need something like `m_using_random_node.emplace(m_io_thread_pool->get_local_thread_id());`" + }, + { + "prediction": "I'm not sure if this is the right place to check this. I think it should be in the same place as `isUsedLocalVarWithoutInitializer`.", + "reference": "I don't think we need to maintain a separate set. The problem here is that the \"assignment\" that is killed for this variable is not really an assignment. If we just don't `assign` the variable with the non-existent value, it will not be reported. I pushed a fix." + }, + { + "prediction": "I don't think we need this method. We can just return `null` from `#isCaseSensitive()` and it will automatically return `false` from `#targetSplitSize()`.", + "reference": "Let me know if this is too pervasive. It is currently a private method in `BaseTableScan`. It seems both `SparkBatchQueryScan` and `SparkMergeScan` need to know the scan-specific split size when planning tasks. Therefore, I made it open. Another approach is to move all the `planTasks` logic to scan implementations, but for the combine tasks by partition feature, it requires grouping scan tasks by partition first, instead of returning them in an iterator fashion. I'm not sure if this is OK. `SparkMergeScan` also seems to re-implemented its own plan tasks logic." + }, + { + "prediction": "I'm not sure this is the best way to do it, but it's the only way I could get it to work.", + "reference": "Not sure what is this change doing?" + }, + { + "prediction": "I'm not sure if we should have a default value for `mins`. If we don't have a default value, then it's possible for someone to try to use a magic number like 90 and get a ticket.", + "reference": "this is funky. either don't take` minutes` as keyword arg or take both `minutes` and `days` and pass all of them on to `timedelta`. i'm guessing you're aiming for backwards compatibility, but i don't think it's worth it given how confusing this is. atlernatively, make `mins=60*24*30` the default. and that brings me to another issue, `mins=None` is not a very useful default." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in `AbstractRememberMeServices` since that's the only place where this method is called.", + "reference": "Please use a tab for indentation instead of spaces." + }, + { + "prediction": "Why is this not `final`?", + "reference": "I can't believe we didn't see this typo before :))" + }, + { + "prediction": "I think this should be `LOGGER = logging.getLogger(__name__)` instead of `LOGGER = log_util.get_logger(__name__)`", + "reference": "If the logger isn't used, it probably doesn't need to be added." + }, + { + "prediction": "Why is this needed?", + "reference": "These files should in `/javascript/brython`" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it's the only thing I can come up with that doesn't break anything.", + "reference": "minor, you can squash these into one `if`" + }, + { + "prediction": "I think we can remove this test now, since it's no longer needed.", + "reference": "Used regexes to do most of this, hence different methods of string creation of UUIDs. I plan to follow up with an additional change to remove direct references to google/pborman UUID so `uuid.New()` and `uuid.NewRandom()` will instead use our `primitives.UUID`." + }, + { + "prediction": "I'm not sure this is the right place to make this change. I think it should be moved to the top of the `if` block above.", + "reference": "Add a TODO here to revisit if this was problematic." + }, + { + "prediction": "`reg_decoded_bbox` -> `reg_decoded_bbox`", + "reference": "Note generally it -> It" + }, + { + "prediction": "Please remove this empty line.", + "reference": "Is this relevant to this PR?" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Can we instead ensure that `opts[:run_in_parellel]` will always be a boolean? Otherwise we'll have to account for the case when it's a non-boolean value in multiple places, such as any/every other `if` statement." + }, + { + "prediction": "I'm not sure if we want to make this part of the `HTTP` namespace. I think it would be better to have a separate namespace for `HTTPS` and `HTTP` so that we don't have to repeat the `HTTP` namespace in the `HTTPS` case.", + "reference": "Is this just moved out of the other files? It doesn't seem like this was generated like the other files." + }, + { + "prediction": "I don't think we need this interface. We can just use `HttpContent.CopyTo` and `HttpContent.CopyToAsync` directly.", + "reference": "I started out doing everything `async`, but it was getting in the way of debugging, so I switched back to all synchronous until I got things working. We should probably move everything back to `async` and remove the synchronous versions." + }, + { + "prediction": "I don't think this is needed.", + "reference": "this looks already too complicated..." + }, + { + "prediction": "I think this test can be moved to rocksdb/test/test_rocksdb_compaction_test.cpp", + "reference": "As for the testings, we better to verify the actual effects of the compaction. Of course, you could do it in future." + }, + { + "prediction": "I think we should remove the `isView` check from `loadTables` as well.", + "reference": "should we add a TODO here?" + }, + { + "prediction": "Why is this being removed?", + "reference": "This can be inlined below as `GoogleSitekitDashboardDetails` is an unnecessary wrapper now." + }, + { + "prediction": "I think this should be `NewVHs(versionHistory)`", + "reference": "NewVHS -> NewVersionHistories this one looks better" + }, + { + "prediction": "I think this should be `@executable` instead of `executable_path`", + "reference": "Is this `@missing_text` ?" + }, + { + "prediction": "I think this should be `r\"([\\w-]+/[\\w-]+)(?:/(.+))?$\"`", + "reference": "Minor suggestion, but wouldn't it be cleaner to simply replace PACKAGE_NAME_FORMAT to all the optional path, then check that the path is empty in validate_package_name? We might also want a helper function to pull out the package name and sub-package path." + }, + { + "prediction": "I'm not sure if this is the best way to display the i18n string, but it's the only way I could get to work.", + "reference": "we should have a way to insert components into a i18n string. so that we could define a translation string like `'%{filename} is being edited'`, and inject the filename `` at the right place. I imagine there must be a language where the `Editing` text should come after the file name. we can think about that later tho." + }, + { + "prediction": "I think this should be `if (pglob.gl_pathv[i] == NULL)`", + "reference": "Probably want break instead of continue." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I could get this test to pass.", + "reference": "This was on purpose that I would set logging (NoLog=false) and a dummy logger below. The idea is to have better code coverage and test of debug/trace statements. Any reason you have removed this?" + }, + { + "prediction": "I think this should be `Stream.of(\"\")` instead of `Stream.empty()`.", + "reference": "does adding a `Stream.empty()` help here?" + }, + { + "prediction": "I think this should be `{'name': 'non_exist_scanner', 'enabled': True}` instead of `{'name': 'bigquery', 'enabled': True}`", + "reference": "This is not being used anymore, so can be removed." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to be the only way I could get this to work.", + "reference": "Is it called some where?" + }, + { + "prediction": "Why is this change needed?", + "reference": "Please remove this extra blank line." + }, + { + "prediction": "I think this should be `@Input` and not `@InputFiles`", + "reference": "this is really the key, if you don't set this then gradle doesn't wire up the tasks that produce various files inside these configurations as inputs... I think we were just getting lucky before." + }, + { + "prediction": "I think this should be `\"\"` instead of an empty string.", + "reference": "Sorry if I'm missing something here, but shouldn't this message be about failing to match with an *empty* selector, and/or perhaps even an empty *tag* instead of selector? The message seems a bit disconnected from what we're testing?" + }, + { + "prediction": "I think this should be `using System.IO;` instead of `using Microsoft.TestPlatform.VsTestConsole.TranslationLayer.Payloads;`", + "reference": "nit: please move these inside namespace." + }, + { + "prediction": "I think this flag should be called `payments.enabled` instead of `payments.during-session-debug`", + "reference": "may users try to abuse it?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `put` method of the `ByteBufferFactory`.", + "reference": "why is this space removed?" + }, + { + "prediction": "Why is this file not affected by `go:build windows`?", + "reference": "Can we remove this other line now then?" + }, + { + "prediction": "I think this should be `cmdhistory.py` instead of `cmdhistory.py`", + "reference": "There's a comma missing here at the end :wink:" + }, + { + "prediction": "I think this should be renamed to `PublishFlatContainers` or something similar.", + "reference": "Why is this not required any longer?" + }, + { + "prediction": "I don't think we need to import `github.com/Unknwon/paginater` here.", + "reference": "Indentation seems a bit fucked up here. Run `go fmt`." + }, + { + "prediction": "I think this should be `nil, status.Error(codes.InvalidArgument, \"empty filter\")`", + "reference": "any chance in == nil? same below" + }, + { + "prediction": "I'm not sure about this change. I think we should keep the `listen_fd` and `h2o_sysfn(listen, listen_fd, H2O_SOMAXCONN)` calls in the same order as they were before.", + "reference": "We would change the source code of h2o so that certain syscalls will be invoked through the `h2o_sysfn` macro." + }, + { + "prediction": "I'm not sure if this is the right place to put this check. I think it should be in `GetQueueSubmitVUID`, but I'm not sure if there is a better place to put it.", + "reference": "the name kTimelineCannotBeSignalled is confusing. It's not that a TimelineSemphore cannot be signaled... it's the \"VK_KHR_timeline_semaphore is enabled *variant* of the \"binary cannot be signaled\" message. We should probably have a consistent naming scheme to clarify. kBinaryCannotBeSignalledAltTimeline or hide the complexity in Get*VUID functions as needed somehow (pass in the extension structure?)" + }, + { + "prediction": "I don't think we should add a `describe` method to `pandas` at this point. It's not clear to me why we'd want to do this, and it's not clear to me why we'd want to call it `describe` at all.", + "reference": "Could you add a type hint? `percentiles: Optional[List[float]] = None`" + }, + { + "prediction": "Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.", + "reference": "Maybe putting ones they've used before first would be good, but this is fine for now." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I could get it to work.", + "reference": "I don't think we need these. Simpler just to put `routetable.TargetType...` inline below." + }, + { + "prediction": "I'm not sure what this is supposed to do, but it seems like it should be removed.", + "reference": "Why this instead of the old way?" + }, + { + "prediction": "This should be `if (RuleB(Pets, LivelikeBreakCharmOnInvis) || (!RuleB(Pets, LivelikeBreakCharmOnInvis) && IsInvisible(formerpet))) {`", + "reference": "Just combining the inner if/else blocks like this is what I originally meant (I didn't mean replacing all the invisible checks in the outer if, I realize that would have been a functionality change regarding the rule) This should now be equivalent to `if (RuleB(Pets, LivelikeBreakCharmOnInvis) || IsInvisible(formerpet))` (the second check for the rule being false after the `||` would be implied, anything after the `||` would only be evaluated if the rule was false)" + }, + { + "prediction": "I think this should be `strings.Replace(key, \"_\", \"\", -1)` instead of `strings.ReplaceAll(key, \"_\", \"\")`", + "reference": "We don't want to write this back to the definition do we? Probably just want to create a local variable for it." + }, + { + "prediction": "Shouldn't this be done in the `onPlaybackEnded` method?", + "reference": "Good catch! Could you please move this to `PlaybackService.this.onPlaybackEnded`? I think it's more clean if everything is in one single place." + }, + { + "prediction": "I think this should be done in `LXQtApplication` instead of `LXQtTaskButton`. The `LXQtApplication` is the parent of `LXQtTaskButton`.", + "reference": "We're trying to avoid X.org specific code. So I'm not a fan of this. Can't this be achieved in display server agnostic way?" + }, + { + "prediction": "This file should not be included in this PR.", + "reference": "This class can be removed?" + }, + { + "prediction": "I think we can remove this line.", + "reference": "File is not `goimports`-ed (from `goimports`)" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in the dispatcher.", + "reference": "To minimize the possibility of regret, perhaps we name this `ZapLogger`." + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "This looks a little weird, but it's a feature of the gem we're using. You can give it a symbol representing the method you want called on current_user." + }, + { + "prediction": "I don't think this is the right place for this. It should be in the `anomaly` module.", + "reference": "`Anomaly` imported here, but not used. Please run the changed files through pylint with nupic pylint config and fix pylint findings related to your changes." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I could get it to work.", + "reference": "We needed this testutils file after all" + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it's the only way I could get it to work.", + "reference": "line is 161 characters (from `lll`)" + }, + { + "prediction": "Why is this file changed?", + "reference": "Please re-format/groupimport this line. You might need a little manual work." + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think it should be done in the `ApplyToWorkflow` and `ApplyWorkerCustomizations` methods of the `DaisyWorker` interface.", + "reference": "minor, you can just use `wf` instead of `worker.wf`" + }, + { + "prediction": "I think you can remove the `\"\\n\" + \" \\\"rampStage\\\": 2,\\n\" + \" \\\"lastUpdatedTime\\\": 1566259437000\\n\" + \" }\\n\"`", + "reference": "I would suggest putting this in the resources directory with the same package as of this test class. Then you can utilize the method azkaban.utils.TestUtils#readResource to read it as string." + }, + { + "prediction": "I think we can remove the `upgrade` package now.", + "reference": "could not import github.com/openebs/maya/pkg/upgrade/templates (invalid package name: \"\") (from `typecheck`)" + }, + { + "prediction": "I'm not sure if this is a good idea, but I don't have a strong opinion.", + "reference": "a official -> an official" + }, + { + "prediction": "I think this should be `config.KINESIS_PROVIDER in ('kinesalite', 'kinesis')` instead of `config.KINESIS_PROVIDER == 'kinesalite'`", + "reference": "I only want the proxy request for this to run for kinesalite." + }, + { + "prediction": "I think this should be `this.props.dateFormat` and not `this.props.dateFormat`", + "reference": "White space boya?" + }, + { + "prediction": "Nit: `cloudFormation.StackSummary` is a bit of a mouthful. Maybe `cloudFormation.StackSummary` or `cloudFormation.StackSummaryType` or something?", + "reference": "Maybe ditch these since `StackSummary` is not used anymore." + }, + { + "prediction": "Why do we need to ignore index 255?", + "reference": "suggest to indicate the value range & meaning in docstring" + }, + { + "prediction": "I think this is a good idea, but I'm not sure it's the best way to do it. I think it's better to have a single place where we can define the endpoints of the exporter, so that we don't have to repeat the same code for each endpoint. One option could be to have a struct that defines the endpoints of the exporter, and then have a function that creates an instance of this struct. The function could take the configuration for the exporter as input and return a new instance of the struct. This way, we could have a single place where we can define the endpoints of the exporter, so that we don't have to repeat the same code for each endpoint. One option could be to have a struct that defines the endpoints of the exporter, and then have a function that creates an instance of this struct. The function could take the configuration for the exporter as input and return a new instance of the struct. This way, we could have a single place where we can define the endpoints of the exporter, so that we don't have to repeat the same code for each endpoint. One option could be to have a struct that defines the endpoints of the exporter, and then have a function that creates an instance of this struct. The function could take", + "reference": "not sure if it works with prometheus by default, otherwise we will have to add this into prometheus config also" + }, + { + "prediction": "I think this should be `r.epmm.RemoveEndPointMark(ifaceName)`", + "reference": "The rule renderer isn't meant to be stateful so probably best to move this out of here" + }, + { + "prediction": "I think this should be `findNvidiaContainerRuntimes(nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil, nil", + "reference": "passing in a `nil` here just so that the tests can pass in an alternative implementation seems weird, but I don't know what the convention is for doing something like this - @briandowns?" + }, + { + "prediction": "I think we can remove the `require('html-entities').AllHtmlEntities` import.", + "reference": "IMO `dot` should be preferred. Remember `aXe`?" + }, + { + "prediction": "Why is this being removed?", + "reference": "Not a huge deal but this will block tests, also, don't they stay open by default now?" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should just use the default log level for telemetry.", + "reference": "Could you make it a local constant for now ?" + }, + { + "prediction": "I'm not sure this is the best way to check for `int` vs `str` casts. I think we should be checking for `isinstance(value, (int, six.string_types)`", + "reference": "What is this `collection_id` field here?" + }, + { + "prediction": "I think this should be `if self.interactive:` since we don't want to print debug messages in interactive mode.", + "reference": "Is there a reason why we don't use logging for this?" + }, + { + "prediction": "Why not using the parent class instead of adding a new one?", + "reference": "Exceptions should be placed in application layer -> infrastructure is aware of application - not the other way around" + }, + { + "prediction": "I'm not sure what this is testing, but it seems like it should be `(\"message\", \"Line too long (2/2)\")`.", + "reference": "IIRC issue mentioned reporting _symbolic message_ - so in this case it would be `line-too-long`." + }, + { + "prediction": "This should be `else if` instead of `else if (id == \"feedbackable\") { return spells[spell_id].reflectable; }`", + "reference": "Is this intended to be `spells[spell_id].reflectable` here? Edit: Should be `spells[spell_id].feedbackable`, right?" + }, + { + "prediction": "Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
    Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", + "reference": "How should we set this for existing teams?" + }, + { + "prediction": "I think this test should be moved to `test/install.go` since it's not related to the `InstallManager` portion of the test.", + "reference": "It would be nice if we could verify that this is in fact the error we expected. But that's a latent issue, something for the backlog." + }, + { + "prediction": "I think we can remove this line.", + "reference": "I hate then some internal process specific middleware leaks into connection manager :( todo later." + }, + { + "prediction": "I think this should be `nupic` and not `nupic.support`", + "reference": "Reflects where these files were moved for `pkg_resources`." + }, + { + "prediction": "I think this is the only thing that needs to change in this file. Everything else should remain the same.", + "reference": "This should be computed('i18n.locale'...." + }, + { + "prediction": "I think this should be done in `eth20` instead of `eth0`", + "reference": "Can you explain to me what goes wrong here? Can the test be adjusted to set up working routing instead?" + }, + { + "prediction": "I think we should revert this change.", + "reference": "We can get rid of this import then." + }, + { + "prediction": "I think this should be `mapEventToMetric` and not `mapEventToMetric`", + "reference": "Not sure how useful is unlock event." + }, + { + "prediction": "I think this should be `encoder{lowercaseFields: lowercaseFields}` instead of `e: encoder{lowercaseFields: lowercaseFields}`", + "reference": "Consider make the second argument a `encoderOptions` which includes the `lowercaseFields` just like opening a collection." + }, + { + "prediction": "I think it would be better to move this to the `HiveIcebergOutputCommitter` constructor, so that it can be called from the `HiveIcebergOutputCommitter#commitTask(TaskAttemptContext)` method, instead of the `HiveIcebergOutputCommitter#commitTask(TaskAttemptContext)` method. This way, the `HiveIcebergOutputCommitter#commitTask(TaskAttemptContext)` method can be called from the `HiveIcebergOutputCommitter#commitTask(TaskAttemptContext)` method, instead of the `HiveIcebergOutputCommitter#commitTask(TaskAttemptContext)` method, instead of the `HiveIcebergOutputCommitter#commitTask(TaskAttemptContext)` method, instead of the `HiveIcebergOutputCommitter#commitTask(TaskAttemptContext)` method, instead of the `HiveIcebergOutputCommitter#commitTask(TaskAttemptContext)` method, instead of the `HiveIcebergOutputCommitter#commitTask(TaskAttemptContext)` method, instead of the `HiveIcebergOutputCommitter#commitTask(TaskAttemptContext)` method, instead of the `HiveIcebergOutputCommitter#commitTask(TaskAttemptContext)` method, instead of the `HiveIce", + "reference": "What is the value of renaming this to `ctx`? We generally prefer the longer names because they are easier to read and to type." + }, + { + "prediction": "I'm not sure if this is the right place to fix this, but it seems to be the only place where we check if the tag is uturn.", + "reference": "Hm. This could be a case of left-sided driving, having u-turn lanes on the right side. Good catch, but looks good to me." + }, + { + "prediction": "I think it would be better to have a separate class for `OK` and `Fail` instead of using `Result` as a base class.", + "reference": "There was a [JsonPropertyName(\"success\")] here it did serialize fine for me, so I am not sure what was the matter? Also maybe uppercase?" + }, + { + "prediction": "I think this should be `IAuRaValidatorProcessor`, not `IAuRaAdditionalBlockProcessorFactory`.", + "reference": "we can just use read env here, pretty sure" + }, + { + "prediction": "I think this hook should be called after `onAfterLocalTransformStart`", + "reference": "Could you replace local hook with global hook `afterModifyTransformStart`?" + }, + { + "prediction": "I think this should be `self._files = {}`", + "reference": "You seem to be basing your PRs off an commit, which keeps reintroducing these changes, which makes it harder to review your PRs." + }, + { + "prediction": "I think this should be `assert(typeof opt_port !== 'function', `", + "reference": "Maybe it would simpler to ignore opt_port if type !== 'number'?" + }, + { + "prediction": "I think this should be `IEnumerable>`", + "reference": "As far as I can tell, `IDictionary` implements `IEnumerable>` so we are just making it more generic. From the issue, I understood that we want to maintain sequence/order. I believe `IEnumerable<>` won't fix the issue." + }, + { + "prediction": "I think this should be `LOG.info(String.format(\"Mapping %s to docker image %s %d times\", caps, name,```", + "reference": "This change prevents a user understanding how their server is configured. Best to leave at `info` level." + }, + { + "prediction": "nit: I think we can drop the `api` prefix here since it's not used in the function signature.", + "reference": "I will add the following to the list: - api.SpecScale - api.SpecSticky" + }, + { + "prediction": "I think this should be 10043", + "reference": "As defaultSendPort is being removed, and I don't like TODOs on examples, please remove the whole line" + }, + { + "prediction": "I think this test is still valid, but I think it should be moved to the `resources` folder.", + "reference": "since we are now no longer expecting an input of float to return an empty string, i have removed this test case." + }, + { + "prediction": "I'm not sure this is the right place to register the counter. I think it should be in the `Counter` struct.", + "reference": "It would be cleaner if you were to pack the name&desc in a `MetricName` and pass it to `MakeCounter`" + }, + { + "prediction": "Why is this needed? I don't see it in the PR description.", + "reference": "Do you know why do we need this?" + }, + { + "prediction": "I think this should be `using MvvmCross.Platform.iOS.Presenters;` instead of `using MvvmCross.iOS.Views;`", + "reference": "I guess this using is what causes the build to fail" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in `pony_unregister_thread()`.", + "reference": "I like the explicit unregister approach." + }, + { + "prediction": "I think we can remove `ExponentialHistogram` and `ExponentialHistogramWithMinMax` now, since they are unused.", + "reference": "We should able to use 0x30 as summary, and make 0x80 reserved for future." + }, + { + "prediction": "I'm not sure if this is the best way to do this. I think we should be able to get rid of `HttpBypassHelper.UriContainsAnyOf` and just use `HttpBypassHelper.IsHttpBypassEnabled` instead.", + "reference": "This allows strategic exclusion of http spans." + }, + { + "prediction": "I think it would be better to have this as an optional parameter and set it to `null` by default. This way you don't have to check for it in the constructor.", + "reference": "why not just `string[]` instead of nullable" + }, + { + "prediction": "I think this should be `\"-tags=` + strings.Join(e.BuildContext.BuildTags, \",\")`", + "reference": "How does this work? Why isn't each tag after the first picked up as a new arg/flag?" + }, + { + "prediction": "I think this should be Datadog-AzureAppServicesResourceId.", + "reference": "This key is actually yet to be determined. Meeting with the backend team and Garner to discuss." + }, + { + "prediction": "I think this should be `assert(!!iv_state);` instead of `assert(iv_state);`", + "reference": "Why remove the crash protection? We're just going to get a bug filed on it." + }, + { + "prediction": "I don't think we need to add CSP here.", + "reference": "Maybe be consistent and name it `FRAME_OPTIONS`." + }, + { + "prediction": "I'm not sure why this is here, but I think it should be removed.", + "reference": "This check/exception is a guard for the next few lines of code. It shouldn't be necessary now. In fact, I don't think you need the if (parentConnection.type == Blockly.INPUT_VALUE) branch at all." + }, + { + "prediction": "I think this line should be indented by 4 spaces to match the rest of the file.", + "reference": "Could probably move these constants too?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I don't have a better idea at the moment.", + "reference": "Maybe 'failed' instead of 'missing'. Also do we really need to write ticket numbers here?" + }, + { + "prediction": "This import is unused.", + "reference": "Test used to use old bouncycastle dependency which isn't needed anymore from Hadoop. Switched to use builtin Java split." + }, + { + "prediction": "I think this should be `v.name.encode(\"UTF-8\")` instead of `v.name.decode(\"UTF-8\")`", + "reference": "nit: I think this would be more readable as \"Some language names contain Unicode characters\"." + }, + { + "prediction": "This file is covered by the GNU General Public License. See the file `COPYING` for more details.", + "reference": "Thanks for adding the header, but I don't think 2017 is a very accurate guess here. Could you do a quick search with git blame and change this accordingly?" + }, + { + "prediction": "nit: you can remove the `/* eslint-env browser, mocha */` statements here.", + "reference": "Oh interesting - does web-test-runner not resolve package.json files?" + }, + { + "prediction": "I think this should be `P\u00e4iv\u00e4`, not `P\u00e4iv\u00e4si`.", + "reference": "Is there a way to derive this value from the locale itself? I feel hardcoding the prefix in the props isn't the right approach, but I'm not sure what the locale file contains exactly." + }, + { + "prediction": "I don't think we should warn about this.", + "reference": "I'd much rather see these warnings in our devtools (`debug/index.js`). Strings contribute quite a bit to our file size and moving them there would prevent bloating core." + }, + { + "prediction": "I think this should be `SmartStore.SOUP_NAME_COL, SmartStore.PATH_COL, SmartStore.COLUMN_TYPE_COL, SmartStore.SOUP_INDEX_MAP_TABLE` instead of `SmartStore.SOUP_NAME_COL, SmartStore.PATH_COL, SmartStore.COLUMN_TYPE_COL, SmartStore.SOUP_INDEX_MAP_TABLE`", + "reference": "Use `String.format(Locale.US, ...) to avoid the `Lint` warning." + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in `pkg/apis/core/internalclientset/typed/servicemanagement/v1beta1/internalclientset/typed/servicemanagement/v1beta1/internalversion`", + "reference": "nit: ServiceReference represents a reference to a v1.Service." + }, + { + "prediction": "I think this should be `[]string` instead of `[]string`", + "reference": "since it changes to the array, how about change the name to `DeviceNames`" + }, + { + "prediction": "I don't think we need to have a special property for runtime. We can just use `runtime` as the name of the property.", + "reference": "Can we avoid this. upgrade engine code should take care of this." + }, + { + "prediction": "I think this should be a `dict` and not a `list`", + "reference": "should also be alphabetized or at least grouped and alphabetized within group" + }, + { + "prediction": "I think this should be `# pylint: disable=unused-variable`", + "reference": "No need for this, as pylint already only turns things off for this function and it's needed for the entire function." + }, + { + "prediction": "I think this should be `errUnmarshalBuildOpts` as well.", + "reference": "nit: can we remove \"can't\" from the error message?" + }, + { + "prediction": "Is it possible to have an empty status in the controller? If so, should we set the phase to recreate?", + "reference": "instead of modifying 'Status' which impacts the state diagram, how about using some annotations on CVR? This can probably help for our upgrade as well. Is this possible? cc: @AmitKumarDas" + }, + { + "prediction": "I think we should use `pkg` instead of `yum` here.", + "reference": "Rename this as KubernetesGPGURL - >KubernetesUbuntuGPGURL , Modify it where ever it is used." + }, + { + "prediction": "This should be `var DEFAULT_FEE = 0.00000000000000000000000000000000`", + "reference": "I'm not totally sure I like the idea of putting a default fee here, but I guess so long as we make sure to track the default fee of bitcoin core, we're good. We should really also take a look at the byte size of the transaction, and use that to determine what the fee should be. But that could also be a different PR." + }, + { + "prediction": "small>linearconstlinearlinearlinear\n * \n * \n```\nReview comment?", + "reference": "oh yeah, `tail`, `update`, `prepend`, `append`, `subSequence`, `trim` just became effectively constant (without memory leak) :)" + }, + { + "prediction": "I think it would be better to use `is_array` instead of `is_object` here.", + "reference": "Can you add back a deprecated `destroyLinks` method for backward compatibility? It can simply proxy `destroyResourceLinks`, and we can remove it in the next major release." + }, + { + "prediction": "I think this should be `RegisterGlobalOption(\"servers\", parseServerOptions)` and not `RegisterGlobalOption(\"servers\", servers)`", + "reference": "A reminder that we should discuss whether to rename this to \"sockets\" or \"listeners\"." + }, + { + "prediction": "Is this needed? I don't see it being used anywhere.", + "reference": "Why do you need to include this using declaration?" + }, + { + "prediction": "I think this should be `scan < name.Length`.", + "reference": "@halter73 where is this file generated from?" + }, + { + "prediction": "Why is this needed? I don't see it being used anywhere.", + "reference": "What do these `#if TRUE` accomplish?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the `OnNext` method of the `InstrumentationContext` class.", + "reference": "Probably a good optimization to have this, but I don't think it's strictly required. For \"legacy\" Activity flows we pass them through an ActivitySource for sampling. So the logic below should also catch these?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in the `mailer` module.", + "reference": "@jessieay Intentionally moving away from passing a param?" + }, + { + "prediction": "I think we should remove the `trim` here.", + "reference": "I think you could condense this code considerably by getting rid of the initialization and foreach loop and simply saying: `$firstname = trim(implode(' ', $nameArr));` What do you think?" + }, + { + "prediction": "Why remove this?", + "reference": "hmm, we actually should _add_ `'use strict'` everywhere" + }, + { + "prediction": "I think this should be `logger.warn(\"Project \" + projectId + \" version \" + projectVer + \" property \" + propsName + \" is empty.\", e);`", + "reference": "it's not just fetching override properties here, right?" + }, + { + "prediction": "I think it would be good to log the reason the connection was closed as well.", + "reference": "Is it worth logging the error?" + }, + { + "prediction": "I don't think this is the best way to do this. I think you should be able to do something like `ns[\"foo\"] = {\"bar\": \"baz\", \"qux\": \"boo\"}` and then have `ns[\"foo\"][\"bar\"]` and `ns[\"foo\"][\"qux\"]` without needing to do `ns[\"foo\"][\"bar\"] = \"baz\"` and `ns[\"foo\"][\"qux\"] = \"boo\"`.", + "reference": "What's the point of this class?" + }, + { + "prediction": "Why do we need to check for mixed content? Shouldn't it always be either a movie or a collection?", + "reference": "I'm being picky here, but I think I would prefer `toggle` to be kept here and just change the condition to `contentType !== 'movies' && contentType !== 'mixed'` or `!['movies', 'mixed'].includes(contentType)`." + }, + { + "prediction": "I think we should use `github.com/syndtr/goleveldb/leveldb` instead of `sysPath`.", + "reference": "Please put this down with the other \"github.com\" imports." + }, + { + "prediction": "I think this should be `push_front` instead of `push_front_preference`.", + "reference": "Minor but probably want `push_front_preference` to have a trailing `_a` to be consistent with the other parameter" + }, + { + "prediction": "I think this should be `Projections.inclusive(spec, caseSensitive).project(rowFilter)` instead of `Projections.inclusive(spec).project(rowFilter)`", + "reference": "Nit: the formatting is a bit off. I would expect this to be 2 indentations from `this.expr = ...` but this is 8 spaces, not 4. Also, most places leave the `);` on the last line of the method arguments." + }, + { + "prediction": "I think we can remove the `StaticLangApiMethodView` class altogether, and just use the `SimpleParamDocView` class.", + "reference": "Ack, @chrisdunelm snuck this class extension past me. This is not a pattern I want to have used..." + }, + { + "prediction": "I'm not sure this is the right place for this capability. I think it should be in `kinto/__init__.py` under the `kinto.views` module.", + "reference": "nitpick: I wonder if we should name it `flush` only (?)" + }, + { + "prediction": "I'm not sure if this is the best way to do this. I think it would be better to have a separate metric for the number of currently running tasks and a separate metric for the number of killed tasks. This way we can easily see how many tasks are currently running and how many have been killed.", + "reference": "Why gauges, not counters?" + }, + { + "prediction": "I think we can remove the sysHashLen variable and use `sysHashLen = 6` everywhere.", + "reference": "Just making a note here that this may break pre GWs between pre 2.2.0 and 2.2.0 servers. Not sure, will have to experiment/dig a bit more." + }, + { + "prediction": "I think this should be \"Pod Failed\" instead of \"Pod Failure\".", + "reference": "Shall we rename this status to CONTAINER_FAILED? ^^ cc: @sshardool" + }, + { + "prediction": "I'm not sure if this is the right place to put this interface. I think it should be in `pkg/network/fetcher.go` since it's only used by `pkg/network/fetcher.go`.", + "reference": "Thinking out loud here: I believe the only reason we need `peer.ID` as a parameter to this method is because we are not persisting blocks from pubsub (instead we are refetching them). If nodes persist the blocks they received over pubsub then I think we can guarantee peers we share a connection with (i.e. that are in the peer tracker) will always have the blocks we are fetching (else how would have we gotten the pubsub message). I imagine the concept of an `initialPeer` can go away once #2962 lands since the peers in the tracker will have the block. Although I don't think that covers the case of fetching blocks our peers have deemed semantically invalid and thus not stored..." + }, + { + "prediction": "I think it would be better to add a link to the CEL docs here, rather than the Cel spec.", + "reference": "I know it has no effect but my eyes can't help. Is that line not too long?" + }, + { + "prediction": "Why is this removed?", + "reference": "Does that mean we disable service loop prevention for packet generated by local host?" + }, + { + "prediction": "I think this should be `raise RuntimeError, \"cygwin is not installed on #{host}\" if host.cygwin_installed?`", + "reference": "It seems a little odd to have both `host.is_cygwin?` *and* `host.cygwin_installed?` defined (with a possibility of having `is_cygwin?` be `true`, but `cygwin_installed?` returning `false`). Do the docs clearly explain the difference?" + }, + { + "prediction": "I'm not sure if this is a good idea. If you have a v1 manifest with a sequence number 1 and an app manifest with a sequence number 2, then the app manifest will overwrite the sequence number of the v1 manifest. Is that what you want to do?", + "reference": "Does this mean manifests will be written with the v2 schema (i.e. with sequence numbers) even though `TableMetadata` is v1 and the manifest list is written with v1? And this should work because we do a projection on read and sequence number is optional?" + }, + { + "prediction": "I think this should be called `rewrittenFileScanTaskSetId` instead of `rewrittenFileScanTaskSetID`.", + "reference": "Should we be sharing this property key with the read? Maybe it should be belong to the file-scan-task object itself?" + }, + { + "prediction": "I think this should be `Debug` and not `DebugFields`.", + "reference": "Nice! Good idea to move these out of the main struct." + }, + { + "prediction": "I think this should be `err != nil && !sigFound`", + "reference": "Thanks for paying attention to other places this might happen. This one is particularly important; I probably never should have gotten in the habit of CheckErr(), since it does a log.Panic() explicitly, which looks like something else until you look closely. It's supposed to be used places where \"can't happen\" but Things Can Happen." + }, + { + "prediction": "I don't think this is a good name for this field. It's a bit confusing because IMAP and SMTP are both transport types, and IMAP is the default. I think it would be better to call this `type` or `transportType` or something similar.", + "reference": "Converting this to an enum makes it obvious that I combined things that don't really belong together. It would probably be better to create two enums `StoreType` and `TransportType` (in more appropriate locations). That also makes it necessary to have (at least) two `ServerSettings` classes. `IncomingServerSettings` and `OutgoingServerSettings`. Also, the naming is inconsistent. Maybe it would be better to make the string that is used for import/export explicit, e.g. WEBDAV(\"WebDAV\")." + }, + { + "prediction": "`@memberof axe.commons.utils` should be `@memberof axe`", + "reference": "It's out of scope for this PR, but I don't find this utility's name to be particularly intuitive. It speaks to nothing of what it does. Does it create a token list? Process one? Get one? `tokenListToArray` would be nice." + }, + { + "prediction": "I think this should be `this.data('hasLabel')`", + "reference": "The message for this check used the existence of a label to determine the output, which doesn't work with the current schema. So I updated it since the data only needed to know a label was present and not what it was." + }, + { + "prediction": "I think this should be `app.ProjectId != claims.Role.ProjectId`", + "reference": "nit: \"The current project does not have requested application\"" + }, + { + "prediction": "I think this should be `public const FORBIDDEN_ATTRIBUTES = ['id'];`", + "reference": "Extend Unit test for this class" + }, + { + "prediction": "I think this should be `DD_APPSEC_CUSTOM_IP_HEADER` instead of `DD_APPSEC_IPHEADER`.", + "reference": "This is this a copy / paste error from above." + }, + { + "prediction": "I don't think this class is used anywhere.", + "reference": "this package has to be renamed to `typeinference`" + }, + { + "prediction": "I think we should use `assertIsInstance` and `assertNotNull` instead of `TestCase.assertNotNull` and `TestCase.assertIsNotEmpty`.", + "reference": "This cancels the above null-check I guess." + }, + { + "prediction": "I think this should be `servicecomb.loadbalance.stats.intervalInMillis`", + "reference": "change to timerIntervalInMillis" + }, + { + "prediction": "I don't think we need this.", + "reference": "`any rules` should be `any roles`" + }, + { + "prediction": "`feedItemFilter` is not used in this method.", + "reference": "Why does the method need to be renamed? I would just keep the old name and update the other uses (which are only tests). That way, we can reduce code duplication." + }, + { + "prediction": "I think this should be `conf.get_bindings_for('normal').get('keystring', 'none')`", + "reference": "I'm not sure if this is going to work - I think it's fine to keep them hardcoded here, as the statusbar can still show `:`, `/` and `?` even if the key is rebound." + }, + { + "prediction": "I don't think this is needed anymore.", + "reference": "@tmetzke shouldn't we replace this library with the `2.12.1` instead of removing it?" + }, + { + "prediction": "I think we can remove the `NumCommittedSectors` field from the `Miner` struct.", + "reference": "uint64 seems excessive here. Should we reduce to a uint32 @whyrusleeping ?" + }, + { + "prediction": "I think this is the only place where we're using the `app` field, so I think it should be marked as `deprecated` and removed in the next major.", + "reference": "Hmm, I thought this was getting used. These are used elsewhere as a cached value (in `svc deploy` it's `o.targetApp`) but I guess since storage doesn't actually need to validate that the app exists, just that there are local services, we never used it." + }, + { + "prediction": "I don't think we need to split the host address here. We can just use `r.RemoteAddr` as it is.", + "reference": "To keep it simple, how would you feel about just using r.RemoteAddr? Since every request comes through here I want it to be as lean as possible. Frankly I'm OK with the port showing up in the log; maybe it'd even be useful to someone." + }, + { + "prediction": "Why do we need to check this?", + "reference": "grant bonus depends on both `admin{}` stored in statedb, and `P2Start/End` in local struct, which is kind of weird at Kamchatka height, we add the bonus Start/End epoch into `admin{}`, so it solely depends on `admin{}` stored in statedb" + }, + { + "prediction": "This should be `raise ValueError(f'Invalid flipping direction \"{direction}\".')`", + "reference": "Use single quote to wrap the str." + }, + { + "prediction": "I think this should be renamed to `PERMISSIONING_NOT_ENABLED` or `PERMISSIONING_NOT_SUPPORTED`.", + "reference": "Is the plan to rename this later?" + }, + { + "prediction": "I think this should be `!==` instead of `!`", + "reference": "Is there a reason why we need a special case for Email at this point? Is the idea that other methods can turn into Email even if it's not configured as a top-level option?" + }, + { + "prediction": "I think this should be `panic(\"dir unexpectedly empty\")` instead of `len(dir) == 0`", + "reference": "This wording is a bit ambiguos, I first thought it meant the directory has no entries in it. maybe \"dir\" -> \"dir string\"?" + }, + { + "prediction": "I'm not sure this is necessary. The `m_was_*` variables are only used in the `init_async` function, which is called from the `init` function, which is called from the `main` function, which is called from the `cppunit` function, which is called from the `test` function, which is called from the `cppunit` function, which is called from the `test` function, which is called from the `cppunit` function, which is called from the `test` function, which is called from the `cppunit` function, which is called from the `test` function, which is called from the `cppunit` function, which is called from the `test` function, which is called from the `cppunit` function, which is called from the `test` function, which is called from the `cppunit` function, which is called from the `test` function, which is called from the `cppunit` function, which is called from the `test` function, which is called from the `cppunit` function, which is called from the `test` function, which is called from the `cppunit` function, which is called from the `test` function,", + "reference": "Why do we need both `HPX::m_hpx_initialized` and `HPX:: m_was_initialized`?" + }, + { + "prediction": "I think this should be `info.Enabled && info.RPCAddress != \"\"`.", + "reference": "also check RPCName?" + }, + { + "prediction": "I don't think you need to import `org.springframework.security.oauth2.client.web.server.WebSessionOAuth2ServerAuthorizationRequestRepository`.", + "reference": "Remove unused import" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it's the only way I could think of.", + "reference": "I assume there will never be a scenario where justValidate is expected to be true on a restart" + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think it's better to do it in the `PMDReportListener` class, since it's the only place where the cache is used.", + "reference": "Report listeners are synchronized, even 'though the cache is thread-safe... I've not profiled it, but it may be a cause of contingency. Any better way around this? Also, do listeners **really** need to be synchronized? Can't we just make them thread-safe?" + }, + { + "prediction": "I'm not sure if this is a good or a bad thing. I think it's a good thing, but I don't know if it's a good thing to do in general.", + "reference": "I don't think this is correct. When `compiler` is not given in `.travis.yml`, the announcement will be `--version`, which results in \"`command not found`\" (though not critical), and the cache slug will lack this information (also not critical)." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `callFunction` method, since it's only used there.", + "reference": "Why do this rather than `args = []` in the function signature?" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "I think we probably *should* do validation of whether there is a suitable implementation if local-validation is true. I'm not sure how useful that actually is though" + }, + { + "prediction": "I don't think this is the right place to do this. You need to do it in `__init__` of the target dataset.", + "reference": "@StrikerRUS here may need to concat two data by col." + }, + { + "prediction": "I don't think this is a good idea. I think it would be better to have a `NodeWithJavadoc` that has a `Node#getJavadocComment()` method that returns the string representation of the `JavadocComment` object, and then the `NodeWithJavadoc` would have a `Node#getJavadocComment()` method that returns the string representation of the `NodeWithJavadoc` object. This way, the `NodeWithJavadoc` can just call `Node#getJavadocComment()` and the `Node` will call `NodeWithJavadoc#getJavadocComment()`, and the `NodeWithJavadoc` can just call `NodeWithJavadoc#getJavadocComment()` and the `Node` will call `NodeWithJavadoc#getJavadocComment()` and the `NodeWithJavadoc` can just call `NodeWithJavadoc#getJavadocComment()` and the `Node` will call `Node#getJavadocComment()` and the `NodeWithJavadoc` will call `Node#getJavadocComment()` and the `NodeWithJavadoc` will call `NodeWithJavadoc#getJavadocComment()` and the `NodeWithJavadoc` will call `NodeWithJavadoc#getJavadocComment()` and the `", + "reference": "Why the space?" + }, + { + "prediction": "I don't think we need to add a new section for this. We already have a `zalcanoTitle` property in the `ZalcanoConfig` class, which is used to set the title of the Zalcano UI. This property should be added to the `ZalcanoConfig` class, and then used to set the title of the Zalcano UI. The `zalcanoTitle` property should be added to the `ZalcanoConfig` class, and then used to set the title of the Zalcano UI. The `zalcanoTitle` property should be added to the `ZalcanoConfig` class, and then used to set the title of the Zalcano UI. The `zalcanoTitle` property should be added to the `ZalcanoConfig` class, and then used to set the title of the Zalcano UI. The `zalcanoTitle` property should be added to the `ZalcanoConfig` class, and then used to set the title of the Zalcano UI. The `zalcanoTitle` property should be added to the `ZalcanoConfig` class, and then used to set the title of the Zalcano UI. The `z", + "reference": "please resolve the extra indentation" + }, + { + "prediction": "I think this should be `!ReferenceEquals(document.Settings.PeptideSettings.Libraries, previous.Settings.PeptideSettings.Libraries) && !ReferenceEquals(document.Settings.MeasuredResults, previous.Settings.MeasuredResults) && !ReferenceEquals(document.Id, previous.Id)`", + "reference": "More proof that this check is needed always." + }, + { + "prediction": "I think this should be `std::unordered_map >`", + "reference": "`m_al_comms` now contains smart pointers." + }, + { + "prediction": "I don't think this is the right place to add this check. I think it should be in the `EnumType` constructor.", + "reference": "Did you do a test run with the compare script? I'm nervous about what happens on all the generators..." + }, + { + "prediction": "I don't think we need this. We already have `nc.RemoteAddr()` in `client.go`", + "reference": "For a client, we store host, as string c.host. That is what we use for monitoring and statsz. Not sure if its useful here or not. Looks like probably not." + }, + { + "prediction": "I think this should be 3, since there are 3 partitions in the original table.", + "reference": "This change is suspicious. Why did the number of partitions increase?" + }, + { + "prediction": "I'm not sure this is the right place for this method. I think it should go in `ProposalPolicy`.", + "reference": "I'm still new to this area, so please forgive what may be a stupid question: When would this be false? And do we have a test for that situation?" + }, + { + "prediction": "I think this should be `Settings.Default.TransitionListInsertPeptides = isPeptide && gridViewTransitionList.ColumnCount == 5;` or `Settings.Default.TransitionListInsertPeptides = !(!isPeptide && gridViewTransitionList.ColumnCount == 6);`", + "reference": "Should there be any changes to this file at all?" + }, + { + "prediction": "I'm not sure this is the right place for this. It seems like it should be in `caddytls`, but I don't know if that's the right place to put it.", + "reference": "The only field being used is the KeyType; Instead, we can probably just make a `keyType` variable here." + }, + { + "prediction": "I think we can remove the call to `SwaggerPetstore.baseUri = 'http://localhost:12510/api';``` here.", + "reference": "This should be done by code-gen change happening in the hydra repo. I am tweaking it just to get CI into a 'passing' state" + }, + { + "prediction": "I'm not sure if this is the right place to add the feature flags.", + "reference": "Cleaned up when I originally added support for passing `screenContext` here (and later `viewContext`) but that was removed." + }, + { + "prediction": "I think this should be `#if defined(__MACH__) || defined(__APPLE__) || defined(__WIN32__)` instead of `#if defined(__MACH__) || defined(__APPLE__) || defined(__WIN32__) || defined(_WIN32__)`", + "reference": "This looks like a bunch of whitespace fixing that's unrelated. Can you revert?" + }, + { + "prediction": "Why do you remove this?", + "reference": "should be removed instead" + }, + { + "prediction": "I think this should be `caseSensitive = true;`", + "reference": "should use randomization ?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `volume.go` file.", + "reference": "returning nil because we want to mayactl to exit with 0 status code." + }, + { + "prediction": "I'm not sure if this is the right place to add this change. I think it should be done in the `h2o_add_header` function, as it is the place where the headers are added to the request.", + "reference": "Is this change relevant to the PR? (and I believe we should use `text/plain` considering the fact that it can be displayed using web browsers...)" + }, + { + "prediction": "This is a breaking change, right? I don't think we should be changing the schema in a breaking change like this.", + "reference": "`[Flags]` is now auto-generated by an argument to the `EnumHint`. (The attributes happen to come out in this order. I don't think it's worth controlling the order.) #Resolved" + }, + { + "prediction": "I think this should be `configParams.SetUseResourceUpdates(syncerToValidator.UseResourceUpdates())` instead of `configParams.SetUseResourceUpdates(true)`", + "reference": "I think same here - in general we don't need to use Setters / Getters since configParams isn't a public API." + }, + { + "prediction": "I think this should be `fmt.Sprintf(\"%s\", pdata)`.", + "reference": "Why using `fmt.Sprintf` where `fmt.Sprint` would do the work (notice no `f` in function name)?" + }, + { + "prediction": "I don't think this is necessary. The `IAccessible2::attribute_current` attribute is only used by the `IAccessible` class, which doesn't have a `current` property.", + "reference": "Extraneous blank line." + }, + { + "prediction": "I'm not sure about this error message. I think it would be better to say something like: \"given multisig preimage hashes to neither Sender nor AuthAddr\"", + "reference": "nit: syntax : neither -> nor" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `ActiveScope` or `ActiveSpanContext` classes.", + "reference": "Is it safe to assume that these two keys are always present? `this[string]` will throw a `KeyNotFoundException` if they are not." + }, + { + "prediction": "`exflow.getFlowDefinitionId() > 0 ? exflow.getFlowDefinitionId() : flowId` can be simplified to `exflow.getFlowDefinitionId() > 0 ? exflow.getFlowDefinitionId() : flowId`", + "reference": "Is the `flowDefinitionId` sufficient to uniquely identify the flow or does it need to be the tuple `` ?" + }, + { + "prediction": "I think this should be `DateTimeInterface|bool`", + "reference": "Shouldn't it be in the reverse order? `DateTime::createFromInterface()` returns `self` and accepts `DateTimeInterface`." + }, + { + "prediction": "Why is this removed?", + "reference": "this check is now redundant. The rest of the function downwards basically does the same thing but with safer checks." + }, + { + "prediction": "This should be `array('id', 'id_reverse', 'alpha', 'alpha-reverse', 'alpha_reverse', 'manual', 'manual_reverse')` and not `array('id', 'id_reverse', 'alpha', 'alpha-reverse', 'alpha_reverse')`", + "reference": "Please could you remove the useless space." + }, + { + "prediction": "I don't think we need to check for negative values here. If the target is out of range, it means the target is greater than the max value or it is less than 0. In either case, we should return an error.", + "reference": "What's the point of this block (and isn't it effectively dead code)?" + }, + { + "prediction": "I think this should be `DiscourseSignOn::DEFAULT_SSO_SECRET`", + "reference": "Put a comma after the last parameter of a multiline method call." + }, + { + "prediction": "I'm not sure this is a good example of how to do this. I'm not sure it's a good example of how to do this at all. I'm not sure it's a good example of how to do this at all. I'm not sure it's a good example of how to do this at all. I'm not sure it's a good example of how to do this at all. I'm not sure it's a good example of how to do this at all. I'm not sure it's a good example of how to do this at all. I'm not sure it's a good example of how to do this at all. I'm not sure it's a good example of how to do this at all. I'm not sure it's a good example of how to do this at all. I'm not sure it's a good example of how to do this at all. I'm not sure it's a good example of how to do this at all. I'm not sure it's a good example of how to do this at all. I'm not sure it's a good example of how to do this at all. I'm not sure it's a good example of how to do this at all. I'm not", + "reference": "Newline at end of file plz" + }, + { + "prediction": "nit: I think we can remove the `goimports` import here.", + "reference": "Can this be refactored to avoid including the aws sdk in the types that we expose? I know it's not being exposed directly through the types we expose, but I do worry that it might make it easier to accidentally do that in the future and not realize it as easily." + }, + { + "prediction": "This should be `time()` not `time()()`.", + "reference": "Hi thomas, i would propose to indicate in the name, that only the indextime is updated, otherwise somebody might think the whole items is getting updated. I would propose something like \"updateIndexTimeByItem(Item $item)\"" + }, + { + "prediction": "I don't think this is the best way to do this. I think it would be better to use `isinstance(element, dict) and 'id' in element and 'id' not in dict.get('id')`", + "reference": "This is not the right exception class. There is an InvalidSelectorException class that covers bad locators." + }, + { + "prediction": "These should be `#include ` and `#include `.", + "reference": "I assume this came from format?" + }, + { + "prediction": "I think this should be `@var boolean default(false);` instead of `protected $clearSearchIndex = false;`", + "reference": "I'd suggest a default value of `false` just to make sure existing tasks are ok when they get deserialized after an update to a version containing this code." + }, + { + "prediction": "I think this should be `dumpConfig.CDebugf(ctx, \"Trying to decrypt with keys = %s, index=%d\", dumpConfig.Keys, index)`", + "reference": "Do we really need this? Seems like it would pollute the logs pretty badly." + }, + { + "prediction": "I think this should be `private static readonly int _vectorSpan = Vector.Count;`", + "reference": "`Vector.Count` should Jit to const when intrinsic; not sure when `Vector.IsHardwareAccelerated == false` ; however we know `readonly static int` does Jit to const." + }, + { + "prediction": "I think this should be `if not hasattr(sqlalchemy, 'is_available'): return`", + "reference": "Can we use a skipIf decorator instead?" + }, + { + "prediction": "Line is too long. [82/80]", + "reference": "Missing version tags" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "I think this should also filter out `validate_resolve_reference` hooks." + }, + { + "prediction": "I'm not sure if this is a good idea, but I don't have a great solution either.", + "reference": "unrelated, but required fix as metrics branch got broken with the latest main->metrics merge and conflict resolution." + }, + { + "prediction": "I don't think this is the right place for this file.", + "reference": "Feel free to remove this line" + }, + { + "prediction": "I think this should be `I18n.t(\"shared.subscriptions.single_user.call_to_action\")`", + "reference": "~~Should this match the key updated above?~~ :+1:" + }, + { + "prediction": "I'm not sure this is the best way to do this, but it's the only way I could come up with that worked.", + "reference": "`gofmt` allows a more compact form `defer func() { _ = f.Close() }()` or just add `// nolint:errcheck` before `defer`." + }, + { + "prediction": "I think this should be `big.Int` instead of `types.AttoFIL`", + "reference": "collateral is in FIL" + }, + { + "prediction": "Why do we need to store the channel here?", + "reference": "We should not create channel of node which are not connected." + }, + { + "prediction": "I think this should be `options.source` instead of `options.db`", + "reference": "I think the docstring should say something like \"Alias for the `source` option\" or something similar." + }, + { + "prediction": "I think it would be better to add a `@JsonInclude(JsonInclude.Include.NON_NULL, JsonInclude.Include.ALWAYS)` annotation on these properties.", + "reference": "Please use properties without suffix `_fr` so they can work across different languages as @teolemon mentioned" + }, + { + "prediction": "I think this function should be called `destroy_request(struct st_h2o_http3client_req_t *req)`.", + "reference": "Declaration here is `static` but the definition at the bottom is non-static?" + }, + { + "prediction": "I'm not sure this is a good name for the option. I would have called it `md5` or `md5sum` instead of `ContentMD5` since it's not just the content md5, but also the md5sum of the content.", + "reference": "Hi @myml, thanks for the contribution! `blob` and `blob/driver` are both in the same module, so you shouldn't need to split this change up into multiple Pull Requests. Also, I'd like to see it working, including the implementation for `s3blob` and `gcsblob` (these should be easy, just pass-through to the provider) and `fileblob` (might be trickier...), and a test in `drivertest/drivertest.go`." + }, + { + "prediction": "I think we can remove the `if i.nodeConfig.NodeTransportIPv4Addr != nil` check here.", + "reference": "Was it a bug?" + }, + { + "prediction": "I'm not sure this is the best way to do this, but it's the only way I could come up with that worked.", + "reference": "# `attr_value['string'] is not None` probably not required as `attr_value['string'] == value` check is already being done" + }, + { + "prediction": "I think this should be `lambda: tabbed_browser._now_focused._hovered_link` instead of `tabbed_browser._now_focused._last_hovered_link`", + "reference": "You're accessing private variables here - `last_hovered_link` should be public in `TabData`. As for `tabbed_browser._now_focused`, I think you can use `tabbed_browser.widget.currentWidget()` instead." + }, + { + "prediction": "I'm not sure if this is the best place to put this method. I think it would make more sense to move it to `BaseMailer` since it's a common method used by all the other mailers.", + "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." + }, + { + "prediction": "I don't think we need this partial class. We can just use `Microsoft.Rest.HttpClient` and `Microsoft.Extensions.Primitives` directly.", + "reference": "We should file a bug for this - we don't need the extensions class if there are no operations on the client" + }, + { + "prediction": "I think we should move this to `NewMounter` instead of `NewCsiMounter` since it's not specific to csi.", + "reference": "Is it possible to import from k8s instead of copy in? :)" + }, + { + "prediction": "Why did you change the type of `$start_time`?", + "reference": "`@param float` can be dropped here." + }, + { + "prediction": "I don't think this is needed anymore.", + "reference": "maybe we can leave this change un-reverted." + }, + { + "prediction": "I think this class should be renamed to `ASTMethodDeclaration` instead of `ASTMethodDeclarator`.", + "reference": "I wouldn't make MethodDeclarator an AccessNode, nor an Annotatable. It's the MethodDeclaration that can be annotated, and has info about the modifiers, and is already an AccessNode" + }, + { + "prediction": "I don't think this is needed. The `Player` field is already in the `PlayerHeadIconChanged` constructor.", + "reference": "delete this class" + }, + { + "prediction": "I'm not sure this is the right fix, but I can't think of a better one.", + "reference": "Replacing `+` (1 or more) with `*` (0 or more) would've also done the trick." + }, + { + "prediction": "I'm not sure this is the right fix. The problem is that the writer is still open when the destructor is called, so we need to close it before calling close() on dp_ostream.", + "reference": "I've been meaning to fix this for a while. Thanks." + }, + { + "prediction": "I think this should be A, B, C, A, B, A, B, A, B, A, B, A, B, A, B, A, B, A, B, A, B, A, B, A, B, A, B, A, C, A, B, A, B, A, B, A, B, A, C, A, B, A, B, A, B, A, B, A, C, A, B, A, B, A, B, A, B, A, C, A, B, A, B, A, B, A, B, A, C, A, B, A, B, A, B, A, B, A, C, A, B, A, B, A, B, A, B, A, B, A, C, A, B, A, B, A, B, A, B, A, C, A, B, A, B, A, B, A, B, A, C, A, B, A, B, A, B, A, B, A, C, A, B, A, B, A", + "reference": "This is adding multiple processor pipelines. I guess you wanted to add multiple processors to the same, single pipeline?" + }, + { + "prediction": "I don't think this is a good way to do it. It's not a good way to do it. It's not a good way to do it. It's not a good way to do it. It's not a good way to do it. It's not a good way to do it. It's not a good way to do it. It's not a good way to do it. It's not a good way to do it. It's not a good way to do it. It's not a good way to do it. It's not a good way to do it. It's not a good way to do it. It's not a good way to do it. It's not a good way to do it. It's not a good way to do it. It's not a good way to do it. It's not a good way to do it. It's not a good way to do it. It's not a good way to do it. It's not a good way to do it. It's not a good way to do it. It's not a good way to do it. It's not a good way to do it. It's not a good way to do it. It's not", + "reference": "If you need str(x[0]) here, you'll probably need str(x) the line after that I suppose. Also, shouldn't we use `raw()` here instead of `str()`?" + }, + { + "prediction": "I think it would be better to have a constant for this value instead of hardcoding it.", + "reference": "3.6 seconds? what does it stand for?" + }, + { + "prediction": "Style/MutableConstant: Freeze mutable objects assigned to constants.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "If the command fails, is stdout nil or \"\"?" + }, + { + "prediction": "I'm not sure about this change. I think we should keep the old URL and just change the `apiVersion` parameter to `apiVersion`", + "reference": "Why is api-version now removed in the generated code?" + }, + { + "prediction": "Why do we need to import `Registry` from `mmdet.utils`?", + "reference": "We may register all built-in optimizers of PyTorch here to simplify the builder." + }, + { + "prediction": "I think this should be `for (auto component = ns->components.begin(); component != ns->components.end(); ++component)`", + "reference": "No need for this new variable." + }, + { + "prediction": "I think this should be `if (newType.getDerivedStateFromProps != null) {`", + "reference": "doesn't this enqueue a double render or is that safeguarded somehow" + }, + { + "prediction": "I'm not sure this is the best way to do this, but it's the only way I could come up with.", + "reference": "But now you may get DATA RACE reports because c.acc is sometimes changed. I wonder if we should not rework that whole sending subs through route." + }, + { + "prediction": "I don't think this is the right place to put this check. I think it should be in the `else` part of the `if (type == \"HDF5Reader\")` block.", + "reference": "Use `ADIADIOS2_HAVE_HDF5`, not `ADIOS_HAVE_PHDF5`" + }, + { + "prediction": "I think this should be `expect(group_value_for 'group', Object).to eq('group Object')`", + "reference": "Would be nice to put this in a separate context named `\"with a string and a non-string\"` (since that's what it is -- it's definitely not a non-string and a string!)." + }, + { + "prediction": "I'm not sure about this change. It seems to me that the number of entries in the master and pertable stats tables is the same, so there's no need to increase the number of entries in the pertable stats table.", + "reference": "Should MAX_PERTABLE_ENTRY here be 10 ?" + }, + { + "prediction": "I think we can remove this line.", + "reference": "Should move these out of frame into a static class? Similar to reason phrases?" + }, + { + "prediction": "I'm not sure this is the right place for this check. I think it should be in the `if (steps[last_valid_instruction].mode == step.mode)` check above.", + "reference": "That means we still create `UseLane` instructions but threat them like `Suppressed`? Can we maybe change this in the pre-processing so that we will just emit `Suppress` instructions in these cases?" + }, + { + "prediction": "nit: remove empty line", + "reference": "no need to move here, iotex-proto is outside of iotex-core and considered same as iotex-address, go-pkgs" + }, + { + "prediction": "I'm not sure this is the right place for this test. I think it should go in `app_test.c` under the `malloc_test` function.", + "reference": "Looks like a clang-format style violation: should turn Travis red." + }, + { + "prediction": "I'm not sure about this one. I think it would be better to have a setting for `:colors` instead of `:success_color`, `:pending_color` and `:failure_color`.", + "reference": "I think we need some YARD docs here, particularly to list all the color symbols that are valid. Otherwise users will have to look at the source to discover that." + }, + { + "prediction": "I think we can remove this function now that we have `getSiteInfo()`.", + "reference": "Not sure if this needs a doc block or not since it's completely internal, but for cleaning this up. (@felixarntz docs?)" + }, + { + "prediction": "I'm not sure this is the right place for this change. I think it should go in `libgtest.benchmarks.buildoptions`.", + "reference": "The change here is to address what exactly?" + }, + { + "prediction": "nit: I think it would be better to use `bool` for `IsMSIEnvironment` instead of `bool IsMSIEnvironment`.", + "reference": "Is this really an Option? IIUC, you compute it automatically for the URLOpener case, why would we require a user to fill it in when using the constructor? I.e., can't we drop this and use `adal.MSIAvailable` instead? If that call is expensive, cache it on `bucket`, not `Options`." + }, + { + "prediction": "Why is this needed? It's not used anywhere else in the codebase.", + "reference": "Was this done automatically or by hand?" + }, + { + "prediction": "`current_group.name == desired_group` can be simplified to `current_group.name == desired_group || current_group == desired_group`", + "reference": "This looks like it will only work for the first child, since after that we've overridden `desired_group`. Should we have a separate variable for this?" + }, + { + "prediction": "This should be `std::ios_base::binary` or `std::ios_base::in | std::ios_base::out` instead of `std::ios_base::binary`.", + "reference": "Should this be a constant somewhere?" + }, + { + "prediction": "I think it would be better to use `OpenTelemetry.Instrumentation.Http` and `OpenTelemetry.Instrumentation.GrpcNetClient` instead of `OpenTelemetry.Instrumentation.AspNet` and `OpenTelemetry.Instrumentation.GrpcNetClient`", + "reference": "nit: sort alphabetically." + }, + { + "prediction": "I think this should be `contextKey` instead of `paramsPrefix`.", + "reference": "Now, It's redundant, I suppose." + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in `go.uber.org/yarpc/peer/peerlist/v2`.", + "reference": "nit: The format recognized by tooling is `// Deprecated: [..]` so you likely want this to be, // Deprecated: Use \"go.uber.org/yarpc/peer/peerlist/v2\".Implementation instead." + }, + { + "prediction": "I think this should be `log.Warnf(\"No telemetry entry found for: %s\", bootstrapID)`", + "reference": "nit: 1. when formatting input strings, make sure to place them in quotes so we could identify white space issues. i.e. '%s' 2. If there is untyped, non-nil error, you want to log the error string as well." + }, + { + "prediction": "I think we can remove the `so` prefix from the `Windows` and `Linux` aliases.", + "reference": "I believe this can be fixed with the original code if you just omit the \".dll\" file extension so it reads `[DllImport(\"Datadog.Trace.ClrProfiler.Native\")]`. On Windows it would look for `Datadog.Trace.ClrProfiler.Native.dll` and Linux/Mac it would look for `Datadog.Trace.ClrProfiler.Native.so`." + }, + { + "prediction": "I think this should be `if (oldVersionCode < 1070197 && prefs.getBoolean(UserPreferences.PREF_MOBILE_UPDATE_OLD, false)) {`", + "reference": "couldn't we just read the boolean as a string (I would assume that this return \"true\" or \"false\"), migrate if to its new value and keep using the same pref key?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `input.c` under the `json` and `jx` modules.", + "reference": "If these variables are only used in main function, move these to the beginning of that function. If there is a foreseeable reason to have them as global statics just let me know." + }, + { + "prediction": "I don't think this is the right place for this change. This is an API change and should be done in a separate PR.", + "reference": "This one was wrong." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in `BatchChanges`. The reason is that `BatchChanges` is designed to be a single place for all of the changes that need to be batched together, so it makes sense to put this logic in there.", + "reference": "What happens if nodes throughout a hierarchy are modified (as they would be)? It looks like we're going to `Reset` once for each `NodeID` affected." + }, + { + "prediction": "I'm not sure this change is correct. It looks like it's just a copy-paste of the existing code.", + "reference": "> Note that allocation of vmheap fails upon initializing dynamoRIO 64 on WoW64 processes. Thus, we need to pass -reachable_heap to avoid having to make this allocation. This should be solved by changing the default `vmheap_size` to be much smaller than 8GB for x64 DR inside WOW64." + }, + { + "prediction": "`@exception_presenter.fully_formatted_lines(failure_number, colorizer)` should be `@exception_presenter.fully_formatted_lines(failure_number, colorizer).join(\"\\n\")`", + "reference": "Is it really worth expanding our public API for this? After all, isn't calling this the same as calling `notification.fully_formatted(...).lines`? If so, I'd rather not widen our API (and thus, increase our maintenance burden) when it's so simple to get all the lines already." + }, + { + "prediction": "I think we can remove the `public` modifier from this interface.", + "reference": "Is it necessary to keep this class around just to define this constant? Or can we place it somewhere else?" + }, + { + "prediction": "I think we can remove these two fields from the rule struct, since they are no longer used by the CLI or the API.", + "reference": "Question - do we cache NetworkPolicy itself? If so, here we can point to NetworkPolicy?" + }, + { + "prediction": "Why is this removed?", + "reference": "For my view, `Register` means the process of **insert node resource to etcd through api-server**, which is called by upstream rather than here, how about changing the func name to `OnConnected`?" + }, + { + "prediction": "I think this should be `protected boolean telemetryInitialized = false;` instead of `protected boolean telemetryInitialized = null;`", + "reference": "I would prefer an active verb for this property, e.g. `initializeTelemetry`. The reason is that this property refers to something the engine does once on startup. Other properties that use passive voice (e.g. `authorizationEnabled`) refer to a state of the engine during its lifetime." + }, + { + "prediction": "I don't think we need this property. We can just use the `Contains` method.", + "reference": "please use new line to maintain reasonable line width" + }, + { + "prediction": "I'm not sure if this is the right approach. I think we should check if the tag exists before adding it. If it does not exist, we should add it. Otherwise, we should return an error.", + "reference": "I would skip this check or add an internal server error response." + }, + { + "prediction": "I think this should be `config.notarizeUser` and `config.notarizePassword` instead of `config.notary_user` and `config.notary_password`", + "reference": "missing `{` here (and then `}` after `notary_password = config.notary_password`); it's only going to do the first one" + }, + { + "prediction": "I'm not sure if this is the right place for this test. I think it should be moved to `test/testutil.go` since it's not related to the `ddev import-db` command.", + "reference": "This is odd because it's actually in our generated SiteSettingsPath, not in the SiteLocalSettingsPath (wp-config-ddev.php). Are these two files swapped somehow? I'd expect SiteSettingsPath to be wp-config.php and SiteLocalSettingsPath to be wp-config-ddev.php. BTW, I'm *way* ok with renaming that to SiteDdevSettingsPath." + }, + { + "prediction": "I think this should be `kythe/kythe-extraction-config` instead of `kythe/go/extractors/config/default`.", + "reference": "It seems like this must necessarily be a stopgap. Can you please add a TODO(#xyz) to point to the appropriate issue?" + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think we should move this to `agent.go` and then call `startKubelet` and `startKubeProxy` from there.", + "reference": "Is the return signature necessary since we never actually return if there is a problem (I'm referring to the call to `logrus.Fatalf`). Let's pick a pattern and stick with it." + }, + { + "prediction": "I'm not sure this is the right way to do this. I think it's better to use `this.get('model.name') + ' - ' + this.get('model.id')`", + "reference": "@btecu why is this override needed here? I'm not seeing a `new` being used here." + }, + { + "prediction": "I think it would be better to move this into `initLeafNodeSmapAndSendSubs` so that we don't have to worry about closing the connection in `initLeafNodeSmapAndSendSubs`.", + "reference": "Should it not be more something like: `MaxAccountConnectionsExceeded` here?" + }, + { + "prediction": "I think this should be `assert.Equal(t, \"default\", parseAndValidate(t, \"-compute_service_account\", \" default\t\").ComputeServiceAccount)`, and then the next line should be `assert.Equal(t, \"\", parseAndValidate(t, \"-compute_service_account\", \" \t\").ComputeServiceAccount)`.", + "reference": "minor: use a non-default CE service account for testing (since default is handled in a specific way in the code)" + }, + { + "prediction": "Why do we need to change this?", + "reference": "This is how I ran the 512MiB test. It's probably too much data for a fixture, and makes for longer functional tests (although still less than a minute on my laptop)." + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.", + "reference": "So we weren't able to hide the fact that the file wasn't pre-generated and had to introduce this \"option\" to detect that?" + }, + { + "prediction": "I think it's better to make this a `map[string]int` so that it can be used in other places as well.", + "reference": "Agree that exporting these maps is the best tradeoff, just registering my ongoing discontent with the lack of `const` collections." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do it in `WebKitCaret`'s `onSelectionChanged` method.", + "reference": "This could probably use `const` as well?" + }, + { + "prediction": "I think this should be `tmp`, not `orig`.", + "reference": "it doesn't look like these need to be exported?" + }, + { + "prediction": "I think this should be `fmt.Errorf`", + "reference": "I think you should remove \"fmt\" here. And change `fmt.Errorf` to `errors.Errorf`." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Here's the `resources` attribute @jferris. I'm not against renaming `Product` to `Resource`, and this one... something else." + }, + { + "prediction": "I think this should be `defer wg.Drain()`", + "reference": "If the context is unused, this is equivalent to `var wg errgroup.Group`." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `Highlighter` class, not the `HighlightParams` class.", + "reference": "very minor: I'd prefer these two added rows are switched so that fragsizeIsMinimum directly follows fragsize" + }, + { + "prediction": "I'm not sure this is the best way to check for a loopback address. I think we should be looking for an IPv4 address that doesn't start with 127.0.0.1 or 255.255.255.255. We could also look for an IPv6 address that doesn't start with 00:00:00:00:00:00 or 2001:0db8:85a3:0001:0000:0000:0000:0000. We could also look for an IPv6 address that doesn't start with 00:00:00:00:00:00 or 2001:0db8:85a3:0001:0000:0000:0000:0000. We could also look for an IPv6 address that doesn't start with 00:00:00:00:00:00 or 2001:0db8:85a3:0", + "reference": "Given that 115 returns `True`, why would this be `False` here?" + }, + { + "prediction": "I think this test should be moved to `org.mule.module.oauth2.server.oauth2.server.OAuth2LoginConfigurerTests#oauth2LoginWithOneClientConfiguredAndRequestFaviconNotAuthenticatedThenRedirectDefaultLoginPage`", + "reference": "Please move this test method just below `oauth2LoginWithOneClientConfiguredThenRedirectForAuthorization()`" + }, + { + "prediction": "I think this should be set to 1000 seconds.", + "reference": "Why this new configuration?" + }, + { + "prediction": "I'm not sure this is the right thing to do. If the partition value is not a byte array, then it's not a valid binary type, and we should throw an exception.", + "reference": "I don't think that we need to check `hasArray` here. I think the reason why this didn't previously check `hasArray` is that the array passed to `DataByteArray` must start at offset 0 and be valid through the array length, so a copy was needed in almost every case. It may be simpler to change this to use `ByteBuffers.toByteArray` and pass the result to create `DataByteArray`." + }, + { + "prediction": "I'm not sure if this is the best name for this. I think `SpanContext` and `SpanReference` could be more specific, e.g. `BaggageContext` and `BaggageReference`?", + "reference": "`spanReference` -> `baggage`" + }, + { + "prediction": "I'm not sure if this is the right place to put it. I think it should be in `web` folder, but I'm not sure.", + "reference": "Why the `/-/verdaccio/` ?" + }, + { + "prediction": "I think this is the only place where we need to change the `AppName` and `GlobalOpts` here.", + "reference": "Has been waiting for a million years" + }, + { + "prediction": "Shouldn't these be `min` and `max`?", + "reference": "Minor grammar detail: the 'than' is unnecessary" + }, + { + "prediction": "I think this should be `self._internal._sdf.select(scol).apply(func, axis=0, skipna=skipna)` instead of `self._internal._sdf.select(scol).head(2).apply(func, axis=0, skipna=skipna)`", + "reference": "I think you can just simply fix this line to `self[:2].to_pandas()`" + }, + { + "prediction": "I think this should be `if (debuggerAddress.match(/\\/se\\/cdp\\/ws\\//))` instead of `if (debuggerAddress.match(/\\/se\\/cdp\\/ws\\//))`", + "reference": "if we are returning the `ws` here when passing in `se:cdp` we can just return it straight or do we have to make a request to get the `ws` address?" + }, + { + "prediction": "I think we should move this file to `src/store.js` and rename it to `registerSiteData`", + "reference": "I could add a resolver for this (like above) but it seems more sensible to just change the one reference!" + }, + { + "prediction": "I think this should be `minimumSecondsSinceParent + actualTimeSinceParent` instead of `actualTimeSinceParent`.", + "reference": "not sure \"actual\" adds value - secondsSinceParent is probably closer." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Line is too long. [94/80]" + }, + { + "prediction": "I think it would be better to add this to the `repeater` section.", + "reference": "The error should be `At least :number items are required`" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `HandleBlockPropose` function.", + "reference": "singleCaseSwitch: should rewrite switch statement to if statement (from `gocritic`)" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `KeyManager` interface.", + "reference": "Could combine this with `encryptionKeyGetter` to have a single `keyGetter` interface. I'm not sure which way is better." + }, + { + "prediction": "I think we can remove the deleteInstance() call here.", + "reference": "Is there any security issue here? If we integrate with Hive security (and I don't know if we have or not) is there some notion of re-authentication at connection time?" + }, + { + "prediction": "I think we should keep `writeConcern` as it was before.", + "reference": "Does this mean we do not support writeConcern on `createCollection`?" + }, + { + "prediction": "I think this should be `id` instead of `sid.ID`", + "reference": "I guess `sid` was for `sessionID`, but now it looks strange: `sid.ID`." + }, + { + "prediction": "I think we need to add the source security group ID to the `SourceSecurityGroupIDs` slice above.", + "reference": "We'll need `infrav1.SecurityGroupBastion` as well" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `pkg/fuse/fuse.go`", + "reference": "This `fileName` should probably be `remote` and be relative to the Fs root as per normal rclone usage." + }, + { + "prediction": "I'm not sure this is the right place for this test. I think it would be better to move it to `org.mule.runtime.module.extension.runtime.test`", + "reference": "That way we are back to having just one index on k_0 So we can really compare the execution times with and without re-indexing" + }, + { + "prediction": "I think we should use `StringEscapeUtils` instead of `String.format` to escape the characters.", + "reference": "Expression that uses a negation pattern to exclude all characters that aren't in the expression." + }, + { + "prediction": "I think it would be better to call it `EchoServiceHeader` to be consistent with the name of the header.", + "reference": "Similar to my suggestion for HTTP, let's remove this and use `ServiceHeader` instead." + }, + { + "prediction": "I think this should be `if commandSet == targetGlobalCommandPath {` instead of `if serviceDirOnHost[0:1] == \".\" {`", + "reference": "The serviceDirOnHost[0:1] was completely wrong. It wasn't just Windows, glad you got this fixed!" + }, + { + "prediction": "I'm not sure why we need to change the timeout here?", + "reference": "Would membership take 10+ seconds to detect the failed node?" + }, + { + "prediction": "I think this should be a `RuntimeError` instead of a `ValueError`", + "reference": "hmm, in this case perhaps the whole try-except could be removed altogether? because if the file does not exist, it's already returning `None`. In any other case it should actually probably fail with the exception, no?" + }, + { + "prediction": "I think this should be `\"\"` instead of `filepath.Join(dir, \"..\", filepath.Join(paths...))`", + "reference": "This function does not need to be public" + }, + { + "prediction": "I'm not sure if we want to add a margin-bottom to this, or not. I think it's fine to not add a margin-bottom if we don't want to add it.", + "reference": "Any chance we can get a CSS class for this? I know it's just in one place but feels like a dangerous precedent to set." + }, + { + "prediction": "I don't think we need to check for the next link method here, since we are already checking for the next link method in line 115.", + "reference": "> && this.Extensions.ContainsKey(\"nextMethodName\") [](start = 96, length = 48) From line 124, looks like we don't need `&& this.Extensions.ContainsKey(\"nextMethodName\")` condition or we don't need line 124 #Closed" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `componentWillMount` hook, since that's where the ref is set.", + "reference": "Moving this code from compat to core shaves 47 bytes out of compat and only adds 6 bytes to core so I thought it was worth it." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the base dir of the current process.", + "reference": "Please use \".NET Core 3\" - i'm trying hard to use one form, and this is the one MS advices" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in the `Telemetry` package.", + "reference": "Unrelated to this change, but this is a fix for when TestDoStartCgroupInitHappyPath has a failure after the test goroutine has already exited." + }, + { + "prediction": "I think this should be `check_not_scrolled` instead of `check_scrolled`", + "reference": "Hmm, I'd really expect this to work, and yet it doesn't. I'll investigate later, though it might get Monday until I get the time." + }, + { + "prediction": "I'm not sure this is the right way to do this. I think you should be able to use `std::make_int64_t` instead of `std::int64_t` here.", + "reference": "Does this changes affect process building dynamic libraries anyhow?" + }, + { + "prediction": "I don't think we need to import `addPPIType` from `scapy.contrib.ppi`.", + "reference": "Could you limit what is imported here?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `lambda_handler.py` file, since that's where the lambda handler is defined.", + "reference": "just to clarify - on line 1074 we update `zip_file_content` for non-local lambdas, but never store it, which means lambda never picks it up" + }, + { + "prediction": "I think this should be `packetWithPorts(1, src: \":0\", dst: \":0\")` instead of `packet{protocol: 1, srcAddr: src, srcPort: 0, dstAddr: dst, dstPort: (icmpType << 8) | (icmpCode)}`", + "reference": "Golang naming convention is to use camel case `icmpPktWithTypeCode` Often the linter will complain" + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think it should be in the `catch` block below, but I'm not sure if that's the right place to do it.", + "reference": "We can do away with assigning the response here too." + }, + { + "prediction": "I think this should be `newViewportHeight = naturalHeight + 4;`", + "reference": "Bumping the newViewportHeight" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in the `js-hll` package.", + "reference": "Is this change correct? Looks like a typo and not sure this should be changed?" + }, + { + "prediction": "I think this should be `qname.split('.')[-1]` instead of `astroid.modutils.get_module_part(qname)`.", + "reference": "I checked the tests coverage and strangely it look like those three lines are not covered (?!). Do you have the same result on your side ?" + }, + { + "prediction": "I think it would be better to use `#pragma warning disable CS0618` instead of `#pragma warning restore CS0618` here.", + "reference": "nit: please try to avoid changing end of the file (it adds a noise to the code review, but does not provide too much value)" + }, + { + "prediction": "I'm not sure this is the best way to do it, but it's the only way I could come up with that worked.", + "reference": "I don't see the \"only\" part reflected in the code but maybe I'm missing it. Also, the indentation is misleading: the `.SelectMany` calls are perfectly aligned but are *not* operating on the same \"level\". I'd expect the second `SelectMany` to be on the same height as the inner `Where`, just break `pathObj => pathObj.Where` and lines won't be that long." + }, + { + "prediction": "I think this should be `resources => { type => Optional[Hash[String[1], ResourceInstance]], kind => given_or_derived },` and not `plugin_hooks => { type => Optional[Hash[String[1], Data]], kind => given_or_derived },`", + "reference": "It seems like most of these will never be nil, are they optional just in case?" + }, + { + "prediction": "I don't think we need to pass -1 here.", + "reference": "`.addColumn(\"c1\", IntegerType.INT, true)` means `PkHandle=true`, maybe should add `.setPkHandle(true)` in line 31" + }, + { + "prediction": "I think this should be `throw new TiExpressionException(\"Cannot encode row key with non-long or non-integer type\");`", + "reference": "how about `Cannot encode row key with non-integer type` directly?" + }, + { + "prediction": "I think this method should be renamed to `fetchUnfinishedExecutionsByExecId`", + "reference": "The method names `fetchUnfinishedExecutions` and `fetchUnfinishedFlows` are too similar to each other. Would it be better to use the name `fetchUnfinishedFlowsMetadata` since you are only fetching metadata info about the flow?" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but it's the only way I could get Travis to pass.", + "reference": "Note that `sudo` is not available by default on BSDs; there are a few places in the codebase here where that's explicitly worked around by using `su`." + }, + { + "prediction": "This should be `package importpath` instead of `package importpath is used to implement a test on Go import paths.`", + "reference": "ultra nit: missing Oxford comma :P" + }, + { + "prediction": "I'm not sure if we want to do this in this PR, but I think it would be good to do it in a follow-up PR.", + "reference": "This is not supported in Spark 3.0.0-rc2 yet. I'd skip this for now." + }, + { + "prediction": "I think this should be `Query(ctx context.Context, from, to types.Address, method string, params ...interface{}) ([]byte, *exec.FunctionSignature, error)`", + "reference": "BLOCKING: Why does `Query` return an `*exec.FunctionSignature`?" + }, + { + "prediction": "I'm not sure this is the best way to do this. I think we should be able to do this with a single call to `resetCachesWithShutdown`", + "reference": "please move this down to immediately above the assignment to `c.dirtyBcache`" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `examples/variable`.", + "reference": "Don't need the `, err` part since you've already handled it." + }, + { + "prediction": "nit: you can use `std::string` instead of `std::wstring` here.", + "reference": "Please add two additional SECTIONs that show that this also works if the dative bond is in the reactant (reaction SMARTS `[O:1]->[H+]>>[O:1].[H+]`) or in the agents (reaction SMARTS `[O:1][H]>N->[Cu]>[O:1].[H]`)" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think we should move this to `pkg/configurator/server/configurator.go` since it's only used by that file.", + "reference": "What happens if the certificate rotation fails and we are prematurely removing this file?" + }, + { + "prediction": "I think this should be `s.once.Do(func() { s.introspect() })`", + "reference": "does this change belong here?" + }, + { + "prediction": "I think this should be `workflowDir` and `cwd` should be `workingDir`.", + "reference": "This returns an error" + }, + { + "prediction": "I'm not sure if this is a good place to add this. I think it would be better to move it to `libcalico/common/config.go` since it's only used by `libcalico/common` package.", + "reference": "If we think we might someday write a native nftables backend, do you think it would make sense to just use generic dataplane configuration? e.g, `dataplane = iptables | ebpf | nftables`, but for now selecting `nftables` uses iptables in nft compat mode?" + }, + { + "prediction": "I think we can remove the `require.NoError` as it's already done in the `require.NotNil` above.", + "reference": "Looks like that helper function is general enough that it should reside in testhelpers" + }, + { + "prediction": "I think this should be `return nil, fmt.Errorf(\"drushrc file already exists\")` instead of `return nil`", + "reference": "This isn't incorrect IMO, but I think it would be better to fix this in drupal7PostStartAction and also in drupal6PostStartAction. It seems to me like those were both somehow neglected on this. Use drupal8PostStartAction as example. Congrats on your first golang PR! Please make sure to test it manually." + }, + { + "prediction": "I'm not sure this is the right place for this test. I think it should go in `beaker_test.rb` under the `provision` section.", + "reference": "I'd like to ensure that the error message at least has some reference to the flag that is not allowed. Something like `/ERROR(.+)--hosts/` would work." + }, + { + "prediction": "I think we can remove the `if err == selector.ErrSubnetsNotFound {` part here.", + "reference": "Should we say \"specifying two public subnets\"?" + }, + { + "prediction": "I'm not sure what this TODO is referring to, but it seems like it should be addressed in a separate PR.", + "reference": "Issue number? When? Why?" + }, + { + "prediction": "I don't think you need to import `speech` here. You can just use `import nvwave`.", + "reference": "You should not rely on `PitchCommand` being imported into speech. Please import it from `speech.commands`." + }, + { + "prediction": "nit: I think this should be `authType` instead of `auth_type`", + "reference": "Is this a constant used in the Nessie project itself? If so, perhaps you might consider a follow up for adding `NessieCatalogProperties` class at some point, to help make them more clear to users looking to adopt Nessie coming from the Iceberg repo itself" + }, + { + "prediction": "I think we can remove `ReadLevel` and `MaxReadLevel` fields from the `GetTasks` response.", + "reference": "maybe we should rename: MinTaskID -> MinTaskIDExclusive, MaxTaskID -> MaxTaskIDInclusive," + }, + { + "prediction": "nit: I think this should be `ecs-nvidia` instead of `nvidia`", + "reference": "You may need to make this configurable if we expect people to be able to use the normal Nvidia runtime on other Linux distributions like Ubuntu or Debian." + }, + { + "prediction": "I think this should be `&SubjectPermission{Deny: []string{remote.DenyImports, remote.DenyExports}}`", + "reference": "Originally the DenyExport was a subscribe permission because it meant that if on this LN connection, if we deny export of \"foo\" it means that it would reject a subscription (hence subscribe permission) on \"foo\" from the other side. Now you are changing to simply not allowing this server to publish on \"foo\". I am not saying this is wrong, but we completely flip the meaning." + }, + { + "prediction": "I think this should be `TESTANY(DR_DISASM_ATT | DR_DISASM_INTEL, DYNAMO_OPTION(disasm_mask));`", + "reference": "> k1 src0 src2 -> dst s/src2/src1/ nit: k1 is actually src0 according to instr_get_src(instr, 0) which makes this a little confusing" + }, + { + "prediction": "I think this should be `logging.Base().Errorf(\"%s: kmd data dir exists but is too permissive (%o), please change to (%o)\", kc.kmdDataDir, dataDirStat.Mode()&0777, dataDirStat.Mode()&0077)`.", + "reference": "I believe that you meant to have the following on the second one, right ? `dataDirStat.Mode()^0077`" + }, + { + "prediction": "I'm not sure if this is the right place to make this change. I think it should be in `protocol`, not in `stream`.", + "reference": "The reason a `ByteCount` is used here, is that the H2 mapping in gQUIC requires this layer violation, which is why `CloseRemote` is not part of the public API. This layer violation will be resolved in IETF QUIC" + }, + { + "prediction": "This should be `return !IsEffectInSpell(spell_id, SE_DivineAura);`", + "reference": "I dig the helper function!" + }, + { + "prediction": "This file should not be included in this PR.", + "reference": "Please add the Copyright header." + }, + { + "prediction": "I don't think we need to import FileSystemTarget here, since it's not used in this module.", + "reference": "Is this the best way to import `FileSystemTarget`?" + }, + { + "prediction": "I'm not sure this is the right fix. The problem here is that we're using `thread_id_t` as a pointer, which is 64 bits on x86 and 32 bits on x64. So when we try to cast it to `int32_t`, it doesn't work.", + "reference": "Wait -- os_local_state_t.tid is thread_id_t though, so we need to read a pointer-sized value via READ_TLS_SLOT_IMM, rather than changing these locals to ints. Maybe have a READ_TLS_TIDSZ_SLOT_IMM or sthg." + }, + { + "prediction": ">!clrstack -i is unsupported on this target. The ICorDebug interface cannot be constructed. [](start = 22, length = 34) I think this is the right thing to say.", + "reference": "Don't use ! in the messages because it isn't used on xplat. There is a SOSPrefix define that can be used (blank on xplat and ! on Windows). Do we really need 3 newlines?" + }, + { + "prediction": "I think this should be `os.path.join(dagster_home_path, candidate_run.__class__.__name__)` instead of `os.path.expanduser(dagster_home_path)`", + "reference": "print out what we got here in the error" + }, + { + "prediction": "I don't think this is needed.", + "reference": "Does this need to be global?" + }, + { + "prediction": "I don't think this is the right fix. The problem is that `values()` returns a `Seq`, but `map()` returns a `Seq>`. So you can't just call `map` on the result of `iterator().map(Tuple2::_2)` because it's not a `Seq>`. You need to call `map` on the result of `iterator().map(Tuple2::_2).collect(Collectors.toMap(Tuple2::_2, null, Comparator.comparing(Comparator.comparingInt(o -> o.getKey().compareTo(o.getValue().getKey()))))`", + "reference": "Yep, could be simplified. Now looks like other *Map.values() impls" + }, + { + "prediction": "I think it would be better to use `echo json_encode($this->response->getContent());` instead of `echo $this->response->getBody();`", + "reference": "This method will be for debug?" + }, + { + "prediction": "I think it would be better to have this as a separate interface. It's not clear to me why we need this to be a part of the `Key` interface. It's not clear to me why we need this to be a part of the `Key` interface. It's not clear to me why we need this to be a part of the `Key` interface. It's not clear to me why we need this to be a part of the `Key` interface. It's not clear to me why we need this to be a part of the `Key` interface. It's not clear to me why we need this to be a part of the `Key` interface. It's not clear to me why we need this to be a part of the `Key` interface. It's not clear to me why we need this to be a part of the `Key` interface. It's not clear to me why we need this to be a part of the `Key` interface. It's not clear to me why we need this to be a part of the `Key` interface. It's not clear to me why we need this to be a part of the `Key` interface. It's not clear to me why we need this to", + "reference": "// Key returns the private key for a specified name that was encrypted with the // provided password. If the private key does not exists it creates a new one // with a name and the password, and returns with `created` set to true." + }, + { + "prediction": "I'm not sure if this is the best name for this class. It's not a class in the usual sense, it's a `PackageEntity` that represents a class. I think `Package Class Entity` or `Package Class` would be better names.", + "reference": "Adding the type hints revealed that it was necessary to distinguish between a ``PackageEntity`` and a ``ClassEntity``, because the ``ClassEntity`` has additional attributes that were dynamically added in the previous code, which confused ``mypy``." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `pandas/_frame_base.py`.", + "reference": "These two functions should be available now." + }, + { + "prediction": "I think this should be `if file.o.size != file.fd.Size() || file.o.modTime != file.fd.ModTime()`", + "reference": "`fi` is what the result of Stat is called elsewhere in this file not `finfo`" + }, + { + "prediction": "I'm not sure if this is a good or a bad thing, but I think it's a good thing.", + "reference": "I'm confused; are we just dropping these methods without deprecation?" + }, + { + "prediction": "I think it would be better to use `std::vector>` instead of `std::vector`.", + "reference": "can we use PC's time to version in Distributed Systems?" + }, + { + "prediction": "I'm not sure if this is the best way to check if the user is linked to the current user or not, but it works for now.", + "reference": "is this \"unless\" actually needed?" + }, + { + "prediction": "I think this should be `if (length == 0) { return list; }`", + "reference": "We don't accept empty words for lookup anymore, again" + }, + { + "prediction": "I'm not sure if this is the best way to exit the program, but it's the only way I could get to work.", + "reference": "We'll have to account for CI installations being faster than local ones. Do y'all think we should leave it at < 30 green / < 50 orange | >= 50 red or lower our thresholds?" + }, + { + "prediction": "I don't think we should have a separate command for this. I think we should have a single command that can be used to turn on/off w3c features.", + "reference": "No need for this to be `W3C_` since there is no JWP equivalent" + }, + { + "prediction": "I think this should be `::RSpec::Core::Backports::Random`", + "reference": "As far as I can tell, there's nothing that creates an instance of `Random` or that calls `rand` or `seed`. Am I missing it? If not, let's remove the `Random` class since we don't really need it and we can move the definitions of `shuffle` into `RSpec::Core::Ordering`. One less type :)." + }, + { + "prediction": "I don't think we need the lock here.", + "reference": "Is this ever actually used?" + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in `consensus.ProcessTipSet` since it's the main place where we process the tip set.", + "reference": "this section of the codebase should be noted as a candidate for caching, and as a place where multiple tipsets is making things extra tricky" + }, + { + "prediction": "I'm not sure why this is ARM specific. It seems like it should work on all architectures.", + "reference": "Do we need to save the existing value of the stolen reg somehow?" + }, + { + "prediction": "I think we should be able to set the maxResults parameter to 1000 or 10000 and it should work just fine.", + "reference": "maxResults should come from FLAGS once #244 is submitted." + }, + { + "prediction": "Why is this needed? I don't see it being used anywhere.", + "reference": "is this wanted?" + }, + { + "prediction": "I think this should be `linode-cli` instead of `linode`", + "reference": "What exception is actually happening here? AFAIK `pytest.importorskip` with just return `None` if there's nothing to import. Which means that this check'd always return `True`. `pytest.importorskip` is specifically designed to trigger skipping the current test anyway so I don't know why you would wrap it like this." + }, + { + "prediction": "I'm not sure this is the best way to do this. I think we should be able to do something like: DEFAULT_HEADERS = {'Accept' => 'application/x-www-form-urlencoded', 'Content-Type' => 'application/x-www-form-urlencoded', 'User-Agent' => 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0 Safari/605.1.15', 'Accept-Language' => 'en-US,en-US;q=0.8,en;q=0.5', 'Accept-Encoding' => 'gzip, deflate', 'Connection' => 'keep-alive', 'Accept-Charset' => 'ISO-8859-1,utf-8', 'Keep-Alive' => 100, 'Strict-Transport-Security' => 'max-age=3111111111111111111111111111111111111111111111111111111111111", + "reference": "Does it send requests with urlencoded bodies anywhere? I thought it sends only json. Maybe content-type should be `application/json` by default?" + }, + { + "prediction": "I think this should be renamed to `--ignore-chromium` or `--ignore-chromium` to be consistent with the other flags.", + "reference": "I'm not sure about adding more flags here when we're trying to simplify things, I thought we were going to check for patches changes to decide if we needed to update or not?" + }, + { + "prediction": "I think this should be `testutil.SignedTransfer(ta.Addrinfo[\"charlie\"].String(), ta.Keyinfo[\"producer\"].PriKey, 1, big.NewInt(10), []byte{}, testutil.TestGasLimit, big.NewInt(testutil.TestGasPriceInt64))`", + "reference": "`testExecutionPb` is a global variable (from `gochecknoglobals`)" + }, + { + "prediction": "Why is this removed?", + "reference": "~Method is public and removing it would be a BC Break, you can deprecate it if you want.~" + }, + { + "prediction": "I think this should be `%s`, not `%v`. The former makes it clear it's a debug statement. The latter hides the fact that it's a panic.", + "reference": "this got me a little confused when reading `build.log`. The err is printed with a log.Error later on but that ends up after the stack trace." + }, + { + "prediction": "I think it would be better to add this option to `--flatbuffers-include-prefix` instead of adding it to `--flatbuffers-usage`.", + "reference": "Can we make these more explicitly for Rust only? It seems like JS and Go use flags with their name in them." + }, + { + "prediction": "I think this should be `InvalidQueryParameter` instead of `InvalidQueryParameter %q`", + "reference": "Should unsupported query parameters just be ignored? I think that's more common than error out." + }, + { + "prediction": "I think it would be better to say \"reset to :py:attr:`Register._UNSET_NAMESPACE`.\"", + "reference": "Actually can we avoid mentioning `Register._UNSET_NAMESPACE`. I thought of it as an implementation detail of the simpler concept of \"being unset\". Perhaps the docs become more natural if we remove the \"If called without arguments or with ...\" part and just say \"you have to call this function without arguments at the end of any file it has been used. That is to ensure blah blah\". Something like that. Just a suggestion." + }, + { + "prediction": "I don't think this is the right way to do it. You need to check if the index is in the range before trying to get the item.", + "reference": "I assume it raises COMError? If so perhaps best to just catch that specifically, so as to not hide other more critical errors." + }, + { + "prediction": "I think it's better to use `github.com/hacdias/caddy-minify/minify` instead of `github.com/abiosoft/caddy-git`", + "reference": "Since minify can generate errors, it should at least go after the errors middleware. And you definitely don't want to be minifying after the gzip writer has closed." + }, + { + "prediction": "I think this should be `provider *TracerProvider` and not `*TracerProvider`", + "reference": "nit: we could remove the `config` field as it is a duplicate of the `provider.config` field." + }, + { + "prediction": "I think this should be `forseti-server-allow-grpc-internal` instead of `forseti-server-allow-grpc`", + "reference": "Nit: from the Internet." + }, + { + "prediction": "I'm not sure if this is the right place for this, but it seems to be the only place where this is used, so I figured I'd put it here.", + "reference": "this is internal package, move to bottom and run 'make fmt'" + }, + { + "prediction": "I think we can remove this feature completely.", + "reference": "Why is this better than ApplicationStopping?" + }, + { + "prediction": "Shouldn't this be \"dns01\" and \"http01\" be \"http01\" and \"dns01\"?", + "reference": "Maybe worth expanding that these 2 are supported by cert-manager but other values exist" + }, + { + "prediction": "I think this should be `$options['src'] = $provider->getHelperProperties($media, $format, $options['src'], $options);`", + "reference": "Why was this merged? It should have raised some questions IMO @core23 @OskarStark . It's already in 3 releases now, so we can't revert it can we? How can we fix this? Please have a look at #1065" + }, + { + "prediction": "I think it would be better to use `node.jsonRpcConfiguration().getAuthenticationPublicKeyFile().isPresent()` instead of `node.jsonRpcConfiguration().getAuthenticationPublicKeyFile() != null`", + "reference": "What if `node.jsonRpcConfiguration().getAuthenticationPublicKeyFile()` is empty string, would that cause a problem here?" + }, + { + "prediction": "I think we can remove the `Duration` and `RenewBefore` fields from the `CertificateSpec` struct, since they are not used in the `Certificate` struct anymore.", + "reference": "The `omitempty` struct tag does not do anything for non-pointer structs. I think we may need to consider making both of these fields pointers, so that they are excluded from output when not set, and also to make it easier to compare to the zero value. That said, I'm happy to merge this now and open an issue to verify the behaviour is as we want ahead of cutting v0.6.0." + }, + { + "prediction": "I'm not sure this is the right way to do it. I think it would be better to have a method that does the comparison and returns null if they are the same, and then use that in the iterator.", + "reference": "I think this is should absolutely be `==`, as the interface cannot control the implementation of equals (and it's part of the contract of the enclosing function). Can we add this interface to the exceptions of the rule?" + }, + { + "prediction": "I think we can remove `namespaceUID` and `namespaceLabels` fields from `ns` struct.", + "reference": "It looks like the UID is the only other thing that we use from `namespace`, so I suggest to copy that out and lose `namespace`, so we don't have to worry about setting it to nil." + }, + { + "prediction": "I think this should be `DefaultImage = \"aws/codebuild/amazonlinux2-x86_64-standard:3.0\"`, not `DefaultImage = \"aws/codebuild/amazonlinux2-x86_64-standard:3.0\"`", + "reference": "Can we define this constant in the`deploy` pkg instead? this would allow us to keep it private" + }, + { + "prediction": "I think this should be `toto/mydir/toto`, not `mydir/toto`.", + "reference": "I don't like this fixture name, should be a noun like `initialized_linter` ? But it's outside of the scope of this MR." + }, + { + "prediction": "I think it would be better to move this check to the constructor of `JsonPrinter`, so that it can be called only once.", + "reference": "Could we keep this as a static reference (JsonPrinter.jsonAsDatasetDto(releasedVersion); and perhaps change the constructor line to just be a static set method and use that here instead? (I suspect it was the warning that 'static methods should be accessed in a static manner' from my IDE that caused me to make this change in the first place...) (I can make a PR to your branch if you want.)" + }, + { + "prediction": "I think it would be better to say something like \"If the provided key is none of those, the modifier key cannot be released.\"", + "reference": "Keys.COMMAND seems to be an alias to Keys.META. That isn't mentioned?" + }, + { + "prediction": "Why do we need both of these? I don't think we need either of them.", + "reference": "This should go in `ConfigLocal` (and then re-generate the mocks)." + }, + { + "prediction": "I don't think this is correct. If `release_mbid` is `None` then `release_msid` should be `None` as well.", + "reference": "Nitty but entry.get for the same thing" + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think it should be in `libcontainer/nsenter` since that is where the nsenter process is started.", + "reference": "Might not hurt to mention the function never returns (since this all ends in `execve`) so `main` never actually runs." + }, + { + "prediction": "I think this should be a warning, not an error.", + "reference": "nit: add new line after this block" + }, + { + "prediction": "I'm not sure about this change. I think it's fine, but I'm not sure it's the right thing to do. I'm not sure it's the right thing to do in general, but I'm not sure it's the right thing to do in this case.", + "reference": "I believe there is some javascript that also uses this 60px number for calculations. I think I'd rather keep the number in px instead of rem to make that correspondence easier to see. If 3.25rem != 60px, can you also change the other place where `60` is used to in the JS?" + }, + { + "prediction": "I don't think we should be using `retrying` here. I think we should be using the built-in `retry` from the `retry` module.", + "reference": "retrying is an installed 3rd party library just like jinja and sendgrid; perhaps try grouping all of them together?" + }, + { + "prediction": "I'm not sure this is the right fix. The problem is that `ArrayList` and `Vector` don't have a `prepend` method.", + "reference": "you could always use List.listIterator with previous() and hasPrevious() to traverse all kinds of j.u.List backwards. No need for special cases for ArrayList and Vector." + }, + { + "prediction": "I'm not sure this is the best way to do this. I think we should be able to do this in a more efficient way, like storing only the difference of bitmaps or steps followed to edit.", + "reference": "remove the bitmap of index 1 from the list not the 0th one. because when we keep on undoing, it would be better if we end up with the original image rather than some randomly edited image. I am not sure whether only just removing bitmap from the list would clear memory. I think you should call bitmap.recycle before removing that bitmap from the list." + }, + { + "prediction": "I think this file should be renamed to reflect the copyright year.", + "reference": "this is a existing file so let's keep 2019" + }, + { + "prediction": "I think this should be a `Map`.", + "reference": "can you change this instead to just `type.toString()` and then you wouldn't have to expose the getBitMask in the enum. (Alternatively you could have used `type.hashCode()` but that doesn't feel as nice)" + }, + { + "prediction": "I'm not sure this is the right way to do it, but it's the only way I could get it to work.", + "reference": "AsReadOnly() would be better here" + }, + { + "prediction": "I don't think we need to add `partial_sync` to the `changes` dictionary. We can just use `newModifications` and `deletions` here.", + "reference": "I suggest that we use `query_based_sync` instead of `partial_sync`." + }, + { + "prediction": "I think we should add a note here that these signed URLs will not work unless the PUT request includes a \"x-ms-blob-type\" header set to \"BlockBlob\".", + "reference": "How does the user use this? By converting the type using `As` function and add the header? Maybe add an example on how." + }, + { + "prediction": "I think we can remove the `ApiMethodParamTransformer` from this class as it is not used anymore.", + "reference": "I'm trying to understand the effects of this change. Is setting this to something other than the old default (that is, `initCodeTransformer = new InitCodeTransformer()`) generally necessary, or are we doing this only to support Python?" + }, + { + "prediction": "I don't think this is accurate. The docstore doesn't take a zero-value key, it just doesn't care if it's `nil` or not.", + "reference": "\"Constructor\" isn't a standard term in Go or this project, although we use it informally amongst ourselves. And I think it will confuse people coming from languages like Java. So can we leave this as it was?" + }, + { + "prediction": "I think this should be `ctu_failure` instead of `ctu_on_demand_failure`", + "reference": "Why do we have to change the test dir?" + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in the `TEXTAREA` and `SELECT` cases since they are the only elements that have a `summary` attribute, but I'm not sure if there is a better place.", + "reference": "This should test the flattened tree instead. details > summary works across shadow tree boundaries." + }, + { + "prediction": "I think this should be `MvvmCross.Logging.MvxAndroidLog` instead of `MvvmCross.Logging.MvxAndroid`", + "reference": "Not sure I am a big fan of these duplicated Log classes." + }, + { + "prediction": "I think we should use a more descriptive name for this error. It's not a cleanup error, it's not a clean up error, it's not a clean up error. It's an error in the domain verification process.", + "reference": "It's long-winded, but the convention is to give constants a common prefix which, see `reasonDomainVerified` ." + }, + { + "prediction": "I think this should be `20.0` instead of `20.0`", + "reference": "Using lanes later down, this threshold could be reduced for similar effects. Otherwise we look a bit to far." + }, + { + "prediction": "I'm not sure this is the best name for this struct. It's a bit confusing because it looks like it's a container, but it's not really a container because it doesn't have any container-specific fields. Maybe something like `conda_env` or `conda_env_info` would be better?", + "reference": "Let's get more verbose about names. struct `wq_conda_environment`: if it can really only be used for conda. struct `wq_software_environment`: if it has potential use outside of conda." + }, + { + "prediction": "I think this is the only place where we're using the `lastPageInPaginatedResp` variable. I think it should be removed.", + "reference": "Should we set this back to `false` inside each `t.Run`? so that we can have more than one testcase that can have paginated responses" + }, + { + "prediction": "I think this should be `ImmutableList.of()` instead of `ImmutableList.copyOf()`.", + "reference": "What about using `dataManifests == null || deleteManifests == null`?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `IndexSearcher.java`.", + "reference": "The `HitsThresholdChecker` should be created once and shared within the collectors ? We also don't need to use the `GlobalHitsThresholdChecker` if the executor is null or if there is a single slice." + }, + { + "prediction": "I think this is the only place where we need to use the cookie package. I'm not sure if we need to use it in other places.", + "reference": "move this to below `antrea.io` import section" + }, + { + "prediction": "I'm not sure if this is the best way to express it. I think it's better to say something like: > This extension method should only be used on instances that were created via older means that predate .", + "reference": "Seems likely to confuse people. What if we moved it into ActivitySourceAdapter and made it private?" + }, + { + "prediction": "I'm not sure if this is the right place for this error message. I think it should go in `eth/transaction.go` since that's the place where the error message is actually generated.", + "reference": "gas price don't need to be a multiple cuz we support allll gas prices now" + }, + { + "prediction": "I don't think we need this method. We can just remove it from the interface.", + "reference": "We are exposing implementation details in the interface. What if there is no processes involved in an implementation of `ITestRequestSender`?" + }, + { + "prediction": "I think it would be better to use `traceback.format_exc()` instead of `sys.exc_info()[1]`.", + "reference": "It would be awesome not to handle the broad exception here. Instead, raise a custom exception, something like `ModelNotSetException`, from the `require_model()`, and then handle it here with a nicer message to tell the user to set the model first." + }, + { + "prediction": "Shouldn't this be `customize_theme_page`?", + "reference": "This already exists under the `theme` lang key, please remove this." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `GoogleCloudPlatform` component, since that's where the flag is set.", + "reference": "Let's add a simple inline HOC around the default export below to provide the value as a prop (no need to introduce a reusable function for this yet)." + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "I believe that you end up printing out the result of the assignment here instead of the netmask." + }, + { + "prediction": "Do we need this? I don't see it being used anywhere.", + "reference": "We have to update the filename here." + }, + { + "prediction": "I think this should be `schema snake_case emits snake_case` or `schema snake_case emits snake_case` to be grammatically correct.", + "reference": "The `--cpp-field-case` looks like `--cpp-field-style` instead of `-case`. - 'unchanged' - leave unchanged (default); - 'upper_camel' -upper camel case; - 'lower_camel' - lower camel case." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in the `origin_changed` variable above.", + "reference": "I haven't thought about this a lot yet, but if we were to try this change, we'd still need to keep the code to delete it from the `.origin` file for backcompat." + }, + { + "prediction": "I'm not sure if this is the best place to put this. I think it's better to put it in `org.hyperledger.besu.crypto`", + "reference": "In my opinion I think it is possible to add `private final` here" + }, + { + "prediction": "I'm not sure this is correct. The `exit` instruction should jump to the `exit` label, not the `deny` label. The `exit` label should jump to the `exit` instruction, not the `deny` instruction. The `deny` label should jump to the `exit` label, not the `exit` instruction.", + "reference": "Feel like \"exit\" doesn't convey that the packet will be dropped. \"drop-and-exit\" or \"error-exit\" maybe?" + }, + { + "prediction": "This should be `a Main actor must have a create constructor which takes an Env parameter`", + "reference": "How do you feel about \"The Main actor\" instead of \"A Main actor\", while we're already here changing the message?" + }, + { + "prediction": "I think this should be `ZK_READ_PERM(\"zk-read\", unmodifiableSet(new HashSet<>(asList(\"*\", null)))),` and not `ZK_READ_PERM(\"zk-read\", null)`.", + "reference": "I cannot see that this new permission is used anywhere? And if the new zk handler is covered by `zk-read`, should not also existing `ZookeeperInfoHandler` handler implement PermissionNameProvider and declare the same permission, for consistency?" + }, + { + "prediction": "I'm not sure if this is the best way to do this. I think it would be better to have a function like `isinstance(x, np.ndarray)` that returns `True` if `x` is an instance of `np.ndarray` and `False otherwise`. Then you can call `isinstance(x, np.ndarray) if isinstance(np.ndarray, type(x)) else ...`", + "reference": "Is this reasonable?" + }, + { + "prediction": "We need to add these transforms to the `TRANSFORMS` attribute of the `AutoAugment` class.", + "reference": "We may move this TODO to Line15." + }, + { + "prediction": "Shouldn't this be `ConfigQuery::checkAvailableStock() && return $this->checkStockNotEmpty();` ?", + "reference": "You have to verify the return type. If it's a reponse, return it. Otherwise do nothing." + }, + { + "prediction": "I think this should be `3==int32_t, 4==int64_t` and not `1==float, 2==double, 3==int32_t, 4==int64_t`", + "reference": "No. Keep the header include and do `extern template ...` to skip the instantiation from that compile unit. (I pushed a fix directly to your branch)" + }, + { + "prediction": "I'm not sure if this is a good idea. I think it's fine to leave this as it is for now, but I'm not sure what the best way is to handle this.", + "reference": "these tests are currently somewhat nonsensical. This code expands to `a, b = {}.keys` when it really should be expanding to `a, b = {}.keys()` -- though fixing this causes the test to fail so I suspect something worse is going on here that I don't quite understand?" + }, + { + "prediction": "I think this test is failing because of a bug in the AvroNameMappingTest class. It should be `assertNull`, not `assertNull(\"location.value.long, should not be read\", projectedL1.get(\"long_r2\"));`", + "reference": "Why did this need to change?" + }, + { + "prediction": "I'm not sure if this is the right place for this interface. I think it should be moved to `action/branch` package.", + "reference": "/go/pkg/mod/golang.org/x/xerrors@v0.0.0-20190410155217-1f06c39b4373/adaptor_go1_13.go:16:21: Frame not declared by package errors (from `typecheck`)" + }, + { + "prediction": "I think this should be called \"configName\" and not \"collection.configName\"", + "reference": "Probably doesn't go here because I think it's specific to the HTTP API layer. This class is too internal to declare such a name." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the `zipkin.yml` file.", + "reference": "in preparation of directly writing the /health endpoint one day.. we should have content checks." + }, + { + "prediction": "I think this should be `string` and not `[]string`", + "reference": "question (non-blocking): Is there a benefit from using `%q` instead of `%s`?" + }, + { + "prediction": "Why is this removed?", + "reference": "I would suggest to keep two empty lines between functions in cpp files" + }, + { + "prediction": "I'm not sure about this test. It seems to me that if the other stream synchronizes on the marker, then the other stream should be able to send the marker to the other stream, and then the other stream should be able to receive the marker from the other stream. So I'm not sure why this test is failing.", + "reference": "This change causes the test to fail on both rocm-1.9.x and rocm-head." + }, + { + "prediction": "I think it would be better to have a `Fixer` interface, and have a `RuleViolationFixer` implement that interface. This way, we don't need to add a new interface for each rule violation, and we don't need to change the `RuleViolationFixer` in order to fix a new rule violation.", + "reference": "I'd consider moving all fix related stuff to a distinct package to avoid contaminating the base package" + }, + { + "prediction": "I'm not sure this is the right fix. The original include directory is not guaranteed to be in the same directory as the compiled files.", + "reference": "Use `os.path.join` for path concatenation." + }, + { + "prediction": "I don't think we need to add `YolactProtonet` and `YolactSegmHead` to the `__all__` list.", + "reference": "Use upper case: YOLACTHead, YOLACTProtonet, YOLACTSegmHead" + }, + { + "prediction": "I think this should be a `*crypter` instead of a `crypter`", + "reference": "The driver tests should be updated to use the concrete type instead of the driver directly; right now your test coverage of the concrete type is 0%." + }, + { + "prediction": "I think this should be `throw new DocblockParseException('Badly-formatted @method parameters for ' . $method_entry;`", + "reference": "I would prefer the message to be more actionable. Like 'There should be no space between & and the variable name' or something similar." + }, + { + "prediction": "I don't think this is the right place to do this. The `jjtGetChild` method is only called from within the parser, so it should be called from within the parser, not here.", + "reference": "The image attribute is not supposed to be the text of the node. I'd rather keep it separate (the previous `@Text` attribute was fine). A practical reason for that is in the future, other languages may have a way to get the text of their node, in which case that wouldn't be fetched with `getImage`, for compatibility, but probably with a `getText` method, or `getSourceCode` like in #1728. Also we *may* deprecate or otherwise put `getImage` out of use as soon as 7.0, given its contract is super loose." + }, + { + "prediction": "I think this should be `@system_exclusion_patterns = [] + @system_exclusion_patterns` instead of `@exclusion_patterns = [] + @system_exclusion_patterns`", + "reference": "The `[] +` seems weird to me. Why is it there?" + }, + { + "prediction": "Layout/AlignHash: Align the elements of a hash literal if they span more than one line.", + "reference": "Not sure if this constant is defined at the right place style-wise. Maybe move it up to before 'belongs_to' like DISCOUNT_TYPES in coupon.rb?" + }, + { + "prediction": "I think this should be `return isEmpty || isEmptyYaml([]byte{string(k)})`", + "reference": "What about a line with just spaces/tabs? Or a line with a couple spaces followed by a `#`?" + }, + { + "prediction": "Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside } missing.", + "reference": "if funder_is is not blank (L375) there is not need to check if org_id is not blank (L379) since you will never enter in the if (L374)." + }, + { + "prediction": "I think this should be `auto_fire = !GetTarget()->IsWithinDistance(GetPlayer()->GetMapId(), GetTarget()));`", + "reference": "Don't need this-> here." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `google/cloud/compute/engine/metadata.py`.", + "reference": "I'm a little concerned about relying on a private module, as they could change the implementation at some point, I'd like to have some test to validate this is working as intended." + }, + { + "prediction": "I'm not sure if this is the best way to check for a dict, but it's the only way I could come up with.", + "reference": "There might other values that we don't support here (eg. `[]`). So it might be safer to check for the supported types instead (string or number)." + }, + { + "prediction": "I think this should be `const char*` instead of `std::string`.", + "reference": "FYI, It won't have any benefit to move from trivial types." + }, + { + "prediction": "I think this should be `secrets-ssm-environment-variables` and not `secrets-ssm-environment-variables`", + "reference": "i missed these discussions- but ` \"secrets-ssm-environment-variables\"` is what was agreed upon with cp?" + }, + { + "prediction": "I think we can remove this line.", + "reference": "whats the difference between this package and `github.com/golang/protobuf` ? or did vscode just decided this was the package it wanted to used?" + }, + { + "prediction": "I think this should be done in the constructor of `AddRepositoryDialog` instead of here.", + "reference": "Just asking: What does this line do? Does it add the stylesheet from the parent to the dialog?" + }, + { + "prediction": "I'm not sure if this is the right place to put this. I think it should be in `requirements-dev.txt` because it's not a requirement for everyone to use scikit-learn, but only for people who want to run tests on it.", + "reference": "Including the scikit-learn dependency here would pull in scikit-learn for everyone who depends on Dagster. If you put it in the setup.py under docs_snippets, we'd avoid that problem (although I think it's already there)." + }, + { + "prediction": "I think it would be better to use `std::set` instead of `std::vector`.", + "reference": "Why remove this?" + }, + { + "prediction": "I think you can remove this test now.", + "reference": "Why remove this? It seems like we should keep this around as a regression test, unless we can guarantee this will never be called without a model set (does your new code guarantee that?)" + }, + { + "prediction": "I think this should be `undefined` or `[]` instead of `global._googlesitekitUserData?.permissions || {}`.", + "reference": "Because this defaults to `{}` if `global._googlesitekitUserData?.permissions` is `false`-y, the checks below around `state.capabilities` always result in the `!! capabilities === true` path. This shouldn't have a default value of `{}` if there's the possibility that `global._googlesitekitUserData?.permissions` can be `undefined`/`false`/`null` legitimately." + }, + { + "prediction": "I think this should be `log_handler.change_log_capacity(capacity)`", + "reference": "Please add a space after the comma here (generally, with arguments there's always a space after commas)." + }, + { + "prediction": "I think it would be better to say \"Flags defined in those class must be used with cautiousness, and strictly reserved to experimental EIPs.\"", + "reference": "From the context, should it say \"Flags defined in this class must be used with caution...\" ?" + }, + { + "prediction": "I think it would be good to have a test for this file.", + "reference": "We don't need this file, we can use the one that is in the grid-ui directory" + }, + { + "prediction": "I think this should be `infoImportedKey` instead of `infoImportedKey`", + "reference": "\"Exported key for account\"?" + }, + { + "prediction": "I think this should be `\\n` instead of `\\r\\n`", + "reference": "Normally we use Environment.NewLine unless you really want it to always be \\r\\n" + }, + { + "prediction": "I don't think we need this function, we can just call `c.VerifyHeader(header, uncles)`.", + "reference": "why did you remove `verifyHeaders`?" + }, + { + "prediction": "Line is too long. [82/80]", + "reference": "Thanks for cleaning up these deprecated calls" + }, + { + "prediction": "I'm not sure this is the right place for this validation. I think it should be moved to the `User` model's `__init__` method.", + "reference": "@akarve this breaks error catching logic on the front end, I'll fix this. That's why I prefer to use some machine-friendly error codes that won't change frequently." + }, + { + "prediction": "I think we can remove this function now, it's no longer used.", + "reference": "We support process remoteQuery for Service. Why are we removing it ?" + }, + { + "prediction": "I'm not sure if this is a good idea, but I don't have a better idea. I'm not sure what the best thing to do here is.", + "reference": "This is specifically for testing?" + }, + { + "prediction": "Shouldn't this be `resourcetags` instead of `resourcetags->getStatistics()`?", + "reference": "I think this is related to the social stats and probably does not need to be removed." + }, + { + "prediction": "I think this should be `jsdoc/require-description-completed-sentence`", + "reference": "Yep, jsdoc again .. It seems that when the plugin description is wrapped within `eslint-disable/enable` expression it's not generated at all. After adding the `@class AutoColumnSize` tag right after the `@plugin` tag the plugin appears in the docs. Please review the other plugins." + }, + { + "prediction": "I think we can remove the `len(values) == 0` check here.", + "reference": "This usage of the result doesn't look quite right. I would not expect the first page of values to be empty if there were multiple pages of results. This also obscures the error case when no values are returned (handled in the next `if` block) by returning a more generic error from the Azure SDK from `result.NextWithContext()`." + }, + { + "prediction": "I think we can remove the `err == nil` check here.", + "reference": "unknown field AddressDetails in struct literal (from `typecheck`)" + }, + { + "prediction": "I think it would be better to use `aws.StringValue(region)` instead of `aws.String(region)` here.", + "reference": "Just noticed, are we specifically missing the addition of `SharedConfigState: session.SharedConfigEnable` ?" + }, + { + "prediction": "I think this should be `oldTimeIntensities != null && oldTimeIntensities.NumPoints > 0` instead of `oldTimeIntensities != null`", + "reference": "Not sure what this is. Bad merge?" + }, + { + "prediction": "I think we can remove the `if acc.claimJWT != \"\"` check here.", + "reference": "I think this may be a RW lock." + }, + { + "prediction": "I think this should be `package helpers` as well.", + "reference": "Perhaps we should tuck this away into a dedicated subdir and name it `config` or something similar? Or maybe it would be happy living in `common`?" + }, + { + "prediction": "This should be `spec.must_learn & 0xf` not `(spec.must_learn & 0xf) && !spec.has_learnt`", + "reference": "Doing a select query inside of a loop like this is not ideal. We should fetch recipes once and then loop through it in memory to perform this check" + }, + { + "prediction": "I think this should be `array([1, 2, 3], dtype=object)`.", + "reference": "too long here. (104 > 100)" + }, + { + "prediction": "I don't think this is the right place for this. I think it should be in the `MessageHandlers` section of the `Handle` method.", + "reference": "Use TryGetValue instead of catching exception" + }, + { + "prediction": "I think we can remove the `as: user` param from the `visit` and `click_link` calls below since it's no longer being used.", + "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the `add_submessage_to_cache()` function.", + "reference": "I think this method should be either: - a static method of `RTPSWriter` to avoid a StatelessWriter redefinition of the function. - a setter in the `CacheChange_t` struct." + }, + { + "prediction": "I'm not sure if this is the right place to call this. I think it should be in `Http2ConnectionAbortedException`, but I'm not sure if that's the right place to call it.", + "reference": "You add a stream back reference for trailers, and all of the sudden we have tight coupling!" + }, + { + "prediction": "I think this should be `using System.Linq.Expressions;`", + "reference": "I don't think we use `AspNetAmbientContext` anymore since . We can probably delete this file." + }, + { + "prediction": "I think this should be `__webpack_require__(1)`, not `__webpack_require__(0)`.", + "reference": "Please avoid committing build artifacts, as they produce unnecessary conflicts and noise." + }, + { + "prediction": "`callable` is not a good name for this function. `Callable` is a type, not a function.", + "reference": "this is vendored code so i would hesitate to make random changes to it" + }, + { + "prediction": "I'm not sure if we should expose the EthAddress here. It's not part of the protocol, and we don't want to make it publicly available.", + "reference": "We are using a different style for JSON tags. `ethAddress` - camalCase `referral_code` - snake_case" + }, + { + "prediction": "I'm not sure this is the best name for this. I think it should be something like `DefaultTraceContextTypeName` or `DefaultRequestContextTypeName`.", + "reference": "Should this be `\"Microsoft.AspNetCore.Http.DefaultHttpContext\"`?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in `Object#copyRange` and `Object#lengthOf`.", + "reference": "removed asserts from `Vector` as it's stable enough and it may hinder inlining, even if turned off :/" + }, + { + "prediction": "I think it would be better to have a `get_message_definitions_by_id` method that takes an id and returns the corresponding message definition. This way you don't have to disable the message and you don't have to worry about the size of the class.", + "reference": "Do we want to raise on the function or on the decorator?" + }, + { + "prediction": "I'm not sure if this is the right fix, but it's the only one I could come up with.", + "reference": "How complex is to to replace `album_*` with `release_*` everywhere in the `Listen` class and places that use it?" + }, + { + "prediction": "I'm not sure this is the right way to do this. I think we should be able to do `n.add(t, path)`, and then `n.remove(t, path)`, and then `n.remove(t, path)`, and then `n.remove(t, path)`, and then `n.remove(t, path)`, and then `n.remove(t, path)`, and then `n.remove(t, path)`, and then `n.remove(t, path)`, and then `n.remove(t, path)`, and then `n.remove(t, path)`, and then `n.remove(t, path)`, and then `n.remove(t, path)`, and then `n.remove(t, path)`, and then `n.remove(t, path)`, and then `n.remove(t, path)`, and then `n.remove(t, path)`, and then `n.remove(t, path)`, and then `n.remove(t, path)`, and then `n.remove(t, path)`, and then `n.remove(t, path)`, and then `n.remove(t, path)`, and then `n.remove(t, path)`, and then `n.remove(t, path)`, and then `n.remove(t,", + "reference": "You haven't changed any of the callers of `.Add` to check the return value, so we're now ignoring duplicates. Please fix that." + }, + { + "prediction": "I think this should be `const vNode = getNodeFromTree(el);` instead of `const vNode = axe.utils.getNodeFromTree(el);`", + "reference": "@straker should this not push to `vnode._cache.isHiddenWithCSS`?" + }, + { + "prediction": "I think this is the wrong package for this interface.", + "reference": "\"an interface\" in conceptual sense vs \"interfaces\" or \"set of interfaces\", referring to the Go interfaces - database/sql uses the latter, should we?" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it's the only way I could come up with at the time of writing this.", + "reference": "This now checks nearly all errors that can occur. How about explicitly listing cases where we want it to retry? I think there are not many cases where we want that, as the many added conditions in the last years show :)" + }, + { + "prediction": "I think this should be `PrefetchStatus, err := brq.checkCaches(ctx, kmd, ptr, block)`", + "reference": "Can you make this accept an action instead?" + }, + { + "prediction": "I think we can remove this `Given` statement now, since we already have it in the `Given` statement above.", + "reference": "Tab inconsistency here (3 spaces instead of 2 spaces)" + }, + { + "prediction": "why 12500 and not 12000?", + "reference": "these change means we are changing epoch to 1 hour?" + }, + { + "prediction": "I think this should be `PANEL_DESCRIPTION_WIDTH = 544` instead of `PANEL_DESCRIPTION_WIDTH = 545`", + "reference": "Why this is defined in the middle of imports?" + }, + { + "prediction": "I don't think this should be in this PR.", + "reference": "Could you move this to the original position?" + }, + { + "prediction": "I'm not sure if this is the right place to move this. I think it should be in `pkg/deployment/stage.go` instead of `pkg/deployment/source.go`", + "reference": "Is there a test that'd have caught this?" + }, + { + "prediction": "I think this should be `&visibility.ListWorkflowExecutionsRequest{`", + "reference": "ListWorkflowExecutionsRequest <- this can be nil?" + }, + { + "prediction": "I think this should be `forge api v1 canonical source` and `forge api v3 canonical source`", + "reference": "Do we need to continue to support the old link, or is it dead dead dead?" + }, + { + "prediction": "I think this should be `GlobalTags` instead of `GlobalTags` and `HeaderTags` instead of `HeaderTags`.", + "reference": "Do we need `ConcurrentDictionary`? `Dictionary` can be safely read from multiple threads. See `GlobalTags`." + }, + { + "prediction": "I think this should be `seelog.Infof(\"Server OSFamily: %s\", config.OSType)`", + "reference": "this seems like more of a Debugf statement" + }, + { + "prediction": "I'm not sure this is the right place for this function. I think it should be in the `ValidateConcurrentBarrierAtSubmit` function.", + "reference": "We're capturing cb_state non-const, but the function is const so, safe enough, but after going to reader/writer locks we're all going to have to key a careful eye on anything in this pattern." + }, + { + "prediction": "I think this should be `if req.Config.Endpoint != nil || req.Config.EndpointID != \"\" { return }`", + "reference": "Probably want to wrap the endpoint discovery work that follows in this `if` statement instead of returning early. This will make it easier to add additional request code generation logic in the future. e.g. if we add any code generation after the endpoint discovery block this check will cause it to be skipped." + }, + { + "prediction": "I think this should be `Error` instead of `JSX twice`.", + "reference": "This test was giving a false positive because my change caused it to throw a different error that contained `createElement` when it should've been throwing this error. Caught this by looking at the code coverage and noticing that the line under the condition I changed was no longer covered lol." + }, + { + "prediction": "I don't think we need this function at all.", + "reference": "I think this is added to wrong file. You wanted to add to cmd/agent/, right?" + }, + { + "prediction": "I think this should be `String elementText = element.getAttribute(\"text\");`", + "reference": "Each `ExpectedCondition` implements `java.util.Function` These are expected to be stateless. This condition will leak previous `elementText` on the second usage, which doesn't seem ideal." + }, + { + "prediction": "I think this should be `DeviceID string` and not `DeviceID string`", + "reference": "Could we consider a more explicit name, like `devicePciAddress`?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it's the only thing I can come up with right now.", + "reference": "Why change this from a foreach? I can't see it gaining anything here and code styles shouldn't change just for the sake of it." + }, + { + "prediction": "Why not use `simplexml_load_string($response->getRawResponse(), $parser, true, false, false);` ?", + "reference": "Is this supposed to be part of this PR?" + }, + { + "prediction": "I think we can remove the `actualNode` parameter from this function, since it's not used anywhere else.", + "reference": "DRY, worth extracting this method to axe.utils" + }, + { + "prediction": "I think this should be called `applicationName` and not `applicationName`", + "reference": "I think there's another spot for this in DefaultCapabilityMatcher" + }, + { + "prediction": "This should be `except Exception as e:` instead of `except OSError as e:`", + "reference": "`QtOSError` inherits `OSError`, so I don't think it's needed to list them both here." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in the subscriber.", + "reference": "Instead of patching vendor, let's update the version of sdk-go to a more recent one that doesn't have this line." + }, + { + "prediction": "I think this should be `[]string{\"BUILD\", \"PULUMI_BUILD_FILE_NAME\"}`.", + "reference": "Don't think this should be here. The default is set somewhere else." + }, + { + "prediction": "I think this should be `if self._last_status[\"progress\"] >= 100 or self._last_status[\"status\"] == \"STOPPED\"`", + "reference": "Not really important in this PR, but does BlazeMeter describe \"progress\" values anywhere? It might be nice to have a set of constants like `PROGRESS_DOWNLOADING_IMAGE`, `PROGRESS_BOOTING`, `PROGRESS_RUNNING_TEST`, etc in our BZA client." + }, + { + "prediction": "I'm not sure this is the right place to put this method. I think it would be better to put it in the `ContentFile` interface.", + "reference": "nit: `

    ` after the line" + }, + { + "prediction": "I think this should be `(\"fonts\", glob(\"fonts/*.ttf\"))` and not `(\"fonts\", glob(\"fonts/*.ttf\", recursive=True))`", + "reference": "Should we include the files with otf extension here, too? If not, I wonder why we do allow them in the source but we don't include them as per the setup" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `dequeueAll` function, since that's where the blocks are dequeued from the queue.", + "reference": "i think it's OK to leave this?" + }, + { + "prediction": "I think it would be better to move this to the `org.apache.flink.table.types.logical` package.", + "reference": "Does this need to be public? The only reference to `FlinkTypeVisitor` that I see in this PR is here, so I'm not sure why this is needed." + }, + { + "prediction": "This should be indented 4 spaces, not 2.", + "reference": "No line at end of file warning" + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in the blockchain processor, but I'm not sure if there is a better place.", + "reference": "This looks unused, shouldn't it point to inner processor in any way?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it's better to do it in the scan itself.", + "reference": "There may be a few isolated cases where the FirstN node is added during preCodeGen. Please see GenPreCode.cpp RelRoot::preCodeGen(). The example given there about Order by where sort is added in optimizer, or a FirstN where the N value is to be specified with a param seem to be cases where we would add the FirstN later. Will current change cause such views to marked as updateable? This is minor and could be resolved later, if any change is necessary." + }, + { + "prediction": "I think this should be `public static String getStaticLangStreamingReturnTypeName(Method method, MethodConfig methodConfig)`", + "reference": "I think you should compose the %sClient part using the Name class, and then do the remaining composition with plain concatenation. Side question: why does the return type name look like it is a client type name?" + }, + { + "prediction": "I think this should be `padding: 0, height: 0, width: 0` and not `padding: 0`", + "reference": "All stories in this file also need the default padding." + }, + { + "prediction": "I think this should be `MeterName = \"PrometheusMiddleware.Meter\"`.", + "reference": "Curious - what would be the actual value?" + }, + { + "prediction": "I think it would be better to use `datasets.__version__` here.", + "reference": "Is it necessary to record the palette in the checkpoint? Any reason?" + }, + { + "prediction": "I don't think we need to import `socketio` in this file.", + "reference": "Not sure how to best do this without creating a new connection to the server everytime. Do this in another thread?" + }, + { + "prediction": "I think this test is a bit too specific to this PR. Can we move it to a different PR?", + "reference": "should we have a similar test for gsa18f procurements?" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but it seems like it should be.", + "reference": "change `v.recipient` to address.Address, so can use `AccountState(v,recipient)`" + }, + { + "prediction": "Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.", + "reference": "Open to doing away with this altogether and maybe injecting this logic somehow into `requires_approval_notice?` in LinearDispatcher." + }, + { + "prediction": "I think this should be `int` instead of `int?`", + "reference": "remove this and always enable tracer, just set the default timeout to something higher (20 seconds)" + }, + { + "prediction": "Shouldn't this be a `Optional`?", + "reference": "Can we give this field a more descriptive name? When I use a variable named `icon` I normally expect an `Image` object." + }, + { + "prediction": "I think this should be `Include` and `Exclude` instead of `in` and `ex`.", + "reference": "can't these just use the global `include` and `exclude` flags?" + }, + { + "prediction": "I think this should be `rois = rois.to(dtype=torch.float32)`", + "reference": "Is this still necessary?" + }, + { + "prediction": "I'm not sure if this is the best way to do this. I'm not sure if it works for everyone. I'm not sure if it's the best way to do this. I'm not sure if it works for everyone. I'm not sure if it's the best way to do this. I'm not sure if it works for everyone. I'm not sure if it's the best way to do this. I'm not sure if it works for everyone. I'm not sure if it's the best way to do this. I'm not sure if it works for everyone. I'm not sure if it's the best way to do this. I'm not sure if it works for everyone. I'm not sure if it's the best way to do this. I'm not sure if it works for everyone. I'm not sure if it's the best way to do this. I'm not sure if it works for everyone. I'm not sure if it's the best way to do this. I'm not sure if it works for everyone. I'm not sure if it's the best way to do this. I'm not sure if it works for everyone. I'm not sure if it's the best way to do this. I'm", + "reference": "Interesting! Happen to catch an exception message or anything I can look into?" + }, + { + "prediction": "Shouldn't this be \"when the promise is fully resolved\"?", + "reference": "did this get moved to mpromise? I don't recall if it's in that lib or not." + }, + { + "prediction": "I don't think we need to add `Ports` field here.", + "reference": "json objects should be `camelCase`" + }, + { + "prediction": "I think this should be an `int64` instead of a `uint64`.", + "reference": "QuarterGiBSectorSize? SectorSize265MiB? Spelling out 256 seems overly verbose." + }, + { + "prediction": "I think we can remove the `using OpenTelemetry.Tests;` and `using OpenTelemetry.Trace;`", + "reference": "Maybe with this change we can remove `using OpenTelemetry.Logs`." + }, + { + "prediction": "I'm not sure if this is the best way to do this. I think it would be better to check if the value is either \"on\" or \"off\" instead of \"on\" or \"off\" and \"on\" or \"off\" as the default.", + "reference": "Fix this name too." + }, + { + "prediction": "I think this should be `int(record_get_field_value(self.record, \"001\"))`", + "reference": "why this is an issue?" + }, + { + "prediction": "I think this should be `bool $was_static = false`", + "reference": "The condition should be inverse?" + }, + { + "prediction": "I think this should be `public static final String AZKABAN_FLOW_NODE_TYPE = \"flow\";`", + "reference": "this seems to be a property key name, so should it be a inside configurationkey.java?" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we need to make sure that the volume is fully destroyed before attempting to destroy it. If the volume is not fully destroyed, then we should not be attempting to destroy it.", + "reference": "G204: Subprocess launching should be audited (from `gosec`)" + }, + { + "prediction": "I think this should be `True` by default.", + "reference": "Please add docs here. And also warn users that this mode should be avoided whenever possible, because any blocking IO will make the keep-alive-thread not run." + }, + { + "prediction": "I think this should be `Object.keys( dimensionFilters ).every( (dimension) => typeof dimensionFilters[dimension] === 'string' );` instead of `Object.keys( dimensionFilters ).every( (dimension) => typeof dimensionFilters[dimension] === 'string' );`", + "reference": "We shouldn't require dimension values to be a string. They just need to be scalar values (probably we could check whether it's either a string or a number). Something more important to cover in the validation here though is to ensure that a map of `dimensionName => dimensionValue` is passed. The keys here actually need to be strings. For example someone shouldn't be able to pass an array of values." + }, + { + "prediction": "Why is this needed?", + "reference": "let's do a pointer cast of nil, similar to the `MapRouter` above" + }, + { + "prediction": "I'm not sure this is the right place for this action. I think it should be moved to the `settings.php` file.", + "reference": "action should use a prefix of `hfg` rather than `neve` as we plan to bootstrap this as a standalone library. Moreover, previously filter/actions used in this library was using the same pattern." + }, + { + "prediction": "I'm not sure this is the right place for this change. I think it should be in the `Http2Options` class.", + "reference": "I'm halfway tempted to disable this for all https connections. Do you know of any clients that actually renegotiate for any reason?" + }, + { + "prediction": "I don't think this is a good name for this class. It's not just checking that an element is visible, it's checking that an element is visible and interactable. I think something like `expect_any_element_is_interactable` would be better.", + "reference": "shouldn't **call** return a boolean?" + }, + { + "prediction": "I think it would be better to move this to the `awsdynamodb` package.", + "reference": "I don't think you need the blank import here. This one uses awsdynamodb directly." + }, + { + "prediction": "I'm not sure this is the right place for this method. I think it should be moved to `DeleteFilter.java`.", + "reference": "I think this should be initialized to `null` instead of a predicate. There is no need to run an extra predicate (with an extra method dispatch for each row in a data file. That's a tight loop so we should do more work here to avoid it. Instead of using `isDeleted.or`, this should test whether `isDeleted` is `null` and either initialize `isDeleted` or call `isDeleted.or`." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `build_clangsa.py` under the `--ctu` option.", + "reference": "What is this and the next entry in config_handler used for?" + }, + { + "prediction": "I think this should be `memory.Plugin{}` instead of `memory.Empty`", + "reference": "will your editor integrate `gofmt`, `goimports`, etc...?" + }, + { + "prediction": "I don't think this is the right way to do it. I think you should check if the intent is not null and if it is not null, you should extract the state from the intent and assign it to `mState`", + "reference": "looks like the code is not properly formatted. for example here are some missing spaces in **if** command. please take care and reformat the code using default android formatting." + }, + { + "prediction": "I think this should be `type=str` instead of `type=argparse.SUPPRESS`", + "reference": "Please add some valid examples to help message like `\"4:10\"`, `\"4:\"`, `\":10\"`" + }, + { + "prediction": "Line is too long. [83/80]", + "reference": "Is it only Symbols we're worried about converting? Is it not safe to just call `to_s` anyway?" + }, + { + "prediction": "I think this should be `const BlockTimeTest = time.Millisecond * 500`", + "reference": "Note for those who come across this later: It was moved to `testhelpers.mining.go` so that `testhelpers.NewDaemon` and the `mining/worker_test.go` can share it." + }, + { + "prediction": "I think this should be `select { |trail| trail.incomplete? && !trail.in_progress? }`", + "reference": "What about `sort_by(&:in_progress?)`? Maybe with a `.reverse` thrown in?" + }, + { + "prediction": "I think it would be better to have a `FlagGRPC` and a `FlagGRPCEnabledHostVerification`", + "reference": "Flag is removed because it is only gRPC now." + }, + { + "prediction": "I'm not sure if this is the best name for this option. It's a little confusing because it's not just a template, but it's also not just a cookiecutter template. What about something like `--template-path path` or `--template-dir path`?", + "reference": "Might be better to rephrase to: Please refer to the ``init scenario`` command in order to generate a custom ``molecule`` scenario. Since you aren't customizing the default scenario since it already exists, right?" + }, + { + "prediction": "I'm not sure this is the right place for this check. I think it should be moved to `pathlib.py` since it's only used in that module.", + "reference": "Shall we merge these `if` for `path lib` and then do the `attrname` one. I'm trying to count `if`-calls and its getting late but I think we can reduce the number checks needed to get into L648 from 3 to 2 if you understand what I mean" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `pkg/recovery` since it's related to recovery.", + "reference": "why depend on recovery???" + }, + { + "prediction": "Why do we need this?", + "reference": "the done channel only aims to be closed, so `chan struct{}` is better then `chan interface{}`" + }, + { + "prediction": "This should be wrapped in `if err != nil { return nil, wrapErr(err, \"error creating contract binding\") }`", + "reference": "Do you mean to have gas_oracle changes in this PR?" + }, + { + "prediction": "I think we can remove the partial here as well, since it's not used anymore.", + "reference": "Is this effectively requiring browsers support javascript?" + }, + { + "prediction": "I think this should be `setStyle(R.style.SalesforceSDK_Dialog, (isDarkTheme ? R.style.SalesforceSDK_Dialog_Dark : R.style.SalesforceSDK_Dialog));`", + "reference": "Lowercase `boolean` - use the primitive type." + }, + { + "prediction": "I think this should be `blobExists` instead of `blobExists == true`", + "reference": "This isn't the correct logic. if allowOverride == true and !blobExists then upload. Just don't do the exist check if allowOverride is set to true." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in `wlr_net_wm_state_read()`.", + "reference": "Can you replace these by `else if` please?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `componentDidMount` method of the `Calendar` component, since it's only called when the component is mounted.", + "reference": "Would be nice if the field had a unique class name that could be used to target it, instead of `fromRange` But doesn't seem to be a common thing in the code base." + }, + { + "prediction": "I'm not sure this is the best way to do it. I think it would be better to have a function that returns true if a header is refed or not, and then use that in the `reduce` function.", + "reference": "Does this code fit on one line under 80 characters? It would be more consistent with our existing style." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the same place as the 0.7.0 `RegisteredArtifactsFor070` function, since that is where the 0.7.0 `OpenEBSCRDArtifactsFor070` and `JivaVolumeArtifactsFor070` functions are defined.", + "reference": "Not a requirement here. But i see a change in naming convention. We can rename the function to `CstorSparsePoolArtifactsFor070`." + }, + { + "prediction": "I'm not sure if this pin is used by Pico, but it's better to have it.", + "reference": "Why do you configure the UART like this? It's already configured by default." + }, + { + "prediction": "Please remove this header file. It is not used anywhere in this file.", + "reference": "Wow. Good catch. \"This `#include` was brought to you by the department of redundancy department.\" ;)" + }, + { + "prediction": "I think we can remove this logf import now.", + "reference": "Well it's actually calling `AuthorizeOrder` and this seems like a DebugLevel message to me, maybe it should be dropped entirely." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the device code, but I don't know how to make it work.", + "reference": "Should this be using the `CUDA_SAFE_CALL` macro here?" + }, + { + "prediction": "I'm not sure why we're changing the color here. I think it should stay the same.", + "reference": "What cases do you see as being valid for not having any tests to run? If a test project doesn't have any tests to run we should avoid running it at the project level." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think we need to do this in `processMirrorMsgs()` on the `mset.mirror` object.", + "reference": "and is it possible that mset.mirror.msgs be nil? because if so, then you would get a panic also because of that." + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think it should be done in the `surface_update` function, since it's the only place where we update the opaque region.", + "reference": "`next->opaque` should not be cleared." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in `processClientAuthentication`.", + "reference": "already what? I know what, but seems like smth. is missing in this sentence" + }, + { + "prediction": "I think we can remove the `details` class from the `textarea` as it's not used for anything related to the proposal.", + "reference": "Can you put spaces after the `{`and before the `}`" + }, + { + "prediction": "I think this should be `__version__` and not `__version__str__`", + "reference": "We said we would put `[ ]` around the version. `[forseti-security] [v2.3.0]`" + }, + { + "prediction": "I think this should be `if len(cnb) > 0 && len(cnb[0]) > 0 && n >= int64(len(cnb[0]))`", + "reference": "Seems len(cnb[0]) will be the length after the write since of the *v thing we saw no?" + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should go in `queue.go`", + "reference": "can we make use of storagepoolclaim type rather than the generic interface{} type?" + }, + { + "prediction": "I'm not sure this is the right way to do it. I'm not sure we want to wait for all the peers to connect before we start accepting connections. I think we want to wait until all the peers are connected before we start accepting connections. I'm not sure we want to wait for all the peers to connect before we start accepting connections. I think we want to wait until all the peers are connected before we start accepting connections. I'm not sure we want to wait for all the peers to connect before we start accepting connections. I think we want to wait until all the peers are connected before we start accepting connections. I think we want to wait until all the peers are connected before we start accepting connections. I think we want to wait until all the peers are connected before we start accepting connections. I think we want to wait until all the peers are connected before we start accepting connections. I think we want to wait until all the peers are connected before we start accepting connections. I think we want to wait until all the peers are connected before we start accepting connections. I think we want to wait until all the peers are connected before we start accepting connections. I think we want to wait until all the peers are connected before we start accepting connections. I think we", + "reference": "this should happen before the `go k.manage()`, otherwise the node will always try the bootnodes first" + }, + { + "prediction": "I'm not sure if this is the right fix. I think we need to keep the `%n` and `%b` parts, but remove the `%s` part. The `%s` part should be removed from the `procCode` string, not from the `var procComponents` array.", + "reference": "Is this actually a lint related change?" + }, + { + "prediction": "Do we need this autoload? I don't see it being used anywhere.", + "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." + }, + { + "prediction": "I think this should be `opt_nonempty_str_param` instead of `opt_nonempty_str_param_param_name`", + "reference": "what does this do that str_param does not?" + }, + { + "prediction": "I think this should be `fmt.Sprintf(\"%s/%s-%s\", prefix, api, version)`", + "reference": "For GCP we included the API name (see below) so you can distinguish between uses other than `blob` once they exist, WDYT?" + }, + { + "prediction": "I'm not sure this is necessary, but I'm also not sure we need to check for boto3 and botocore here.", + "reference": "what would you think about doing this include on-demand within S3ObjectStore methods and then failing in a loud way?" + }, + { + "prediction": "I'm not sure this is the right place to do this check. I think it would be better to do this check in the `node` mutex lock above.", + "reference": "May be better make `stopped` atomic, then it can be just `for (auto i (node.store.latest_begin (transaction_a, next_frontier_account)), n (node.store.latest_end ()); i != n && && !stopped && elections_count < max_elections; ++i)`" + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it's the only way I could get it to work.", + "reference": "In `src/storage/InternalStorageServiceHandler.h ` file, the client in `client->future_chainAddEdges ` should be InterStorageServiceAsyncClient?" + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in `pkg/apis/monitoring/v1`", + "reference": "`go.sum` needs to be updated for this. Please run `go mod tidy`" + }, + { + "prediction": "nit: I think this should be `SecretBackendSSMParameterStore` and `SecretBackendSecretsManager` should be `SecretBackendAWSSecretsManager`", + "reference": "Not sure if this was discussed previously, but is there a specific use case in mind for having this as an API field rather than a configuration option on the controller manager? Is there a specific use case in mind where one would want to choose different backends for individual Clusters/Machines vs having it a global configuration for an instance of the infrastructure provider?" + }, + { + "prediction": "I'm not sure this is the right way to do it. I think we need to add the `PeriodicExportingMetricReader` to the `builder`, and then add the `OtlpMetricsExporter` to the `builder.AddMetricReader(...)` call.", + "reference": "Same thing with the OtlpExporter" + }, + { + "prediction": "I'm not sure this is the right place to put this. I think it should go in `jx_print_subexpr.c`", + "reference": "Should not be removed." + }, + { + "prediction": "I think we can remove the `include DSL::InstallUtils::PuppetUtils` line as well.", + "reference": "Not a blocker for anything, but should this be moved to beaker-pe? Is that ticketed anywhere?" + }, + { + "prediction": "Shouldn't this be `afterClickOn(element, driver)`?", + "reference": "this shouldn't be beforeClickOn, but rather beforeSubmit? and added to WebDriverEventListener. Since submit does not synthesize the 'click' events, this isn't accurate." + }, + { + "prediction": "I think this should be `self.approving_official && self.approving_official.email_address || self.system_approver_emails.first` instead of `self.approving_official ? self.approving_official.email_address : self.system_approver_emails.first`", + "reference": "this ternary operator is hiding an `if/else` within an `if/else` - any chance we could move the logic ELSEwhere? (see what I did there -- ?? :100: )" + }, + { + "prediction": "I don't think this is the right place to put this annotation. I think it should be in `org.pmd.lang.java.typeresolution.type`", + "reference": "Is this really internal? Or will the API be different in PMD 7.0.0? Well, the interface doesn't offer much functionality anyway..." + }, + { + "prediction": "I think this should be `ragged` instead of `raggeded`", + "reference": "Does it have to be arrays? Isn't it ragged 'data' (i.e multiple elements of different lengths)?" + }, + { + "prediction": "I'm not sure this is the best way to do this. I think we should be able to set this to `false` by default.", + "reference": "Per my understanding, this flag only impacts \"NoCleanup\" disk. If so, we may name it more clear. The reason of this ask is because I plan to add some other flag to force cleanup for other non-NoCleanup disks." + }, + { + "prediction": "I think this should be `StreamingWrite` instead of `SparkStreamingWrite`", + "reference": "In my changes for `RequiresDistributionAndOrdering`, this class went away and is replaced by an inner class. I think that pattern worked well. Maybe we could do that before this one to reduce the number of changes here." + }, + { + "prediction": "These should probably be `ITEM_PARSE_HITPOINTSLEECHANCE`, `ITEM_PARSE_HITPOINTSLEECHAMOUNT`, `ITEM_PARSE_MANAPOINTSLEECHANCE`, and `ITEM_PARSE_MANAPOINTSLEECHAMOUNT`.", + "reference": "Shouldn't this be called `hp` instead of `life`?" + }, + { + "prediction": "I think it would be better to add this as a constant in `DispatcherConstants.java` and then use `DispatcherConstants.ALLOWED_METHODS` and `DispatcherConstants.ALLOWED_ORIGINS` instead of `DispatcherConstants.CORS_ALLOWED_METHODS` and `DispatcherConstants.CORS_ALLOWED_ORIGINS`", + "reference": "Because the default value of allowedOrigins is * (all origins), so it isn't necessary to set again at all." + }, + { + "prediction": "I think this should be reverted.", + "reference": "Undo this modification" + }, + { + "prediction": ",\"\"boolKey\"\":true,\"\"library.name\"\":\"\"CreateTestActivity\"\"}}}}]\",\n content);\n }\n \n```\nReview comment?", + "reference": "Please check my thoughts here... I changed the test to not `ToString()` attribute values. This was important to test things when `net.peer.port` was both an int or a string, but I was unsure if Zipkin supported non-string attributes." + }, + { + "prediction": "I think this should be `returnBase64NoMetadata(call, exif, bitmapOutputStream);`", + "reference": "Looks like you made changes on `CameraResultType` class, but didn't commit them. And you also have to do the changes on the types in @capacitor/core" + }, + { + "prediction": "I think we can remove the `BootDiskKmsKeyring` and `BootDiskKmsLocation` fields from the `ImportParams` struct as well.", + "reference": "Can you explain the history of the bug a bit, and why this fixes it?" + }, + { + "prediction": "Layout/AlignHash: Align the elements of a hash literal if they span more than one line.", + "reference": "What do you think about `mentor_mail_to` or `mentor_mail_to_link` in order to match Rails' `mail_to` method, which is what this calls? I'm not sure about this suggestion..." + }, + { + "prediction": "`metricPoint.Keys.Length` is `int` and `((metricPoint.Keys == null) ? 0 : metricPoint.Keys.Length)` is `null` when `metricPoint.Keys` is null.", + "reference": "Looks like this will make the check in every loop. Consider extracting the null check." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in the `SharedExampleGroup` module, since that's where the `clear` method is defined. The `SharedExampleGroup` module should contain all of the logic related to shared examples, including resetting the registry.", + "reference": "Maybe `it \"can safely be reset when there are not yet any shared example groups\"`? That's the edge case that wasn't working, right?" + }, + { + "prediction": "I think this file should be renamed to `ssmfactory.go`", + "reference": "naming: please use `asmfactory`" + }, + { + "prediction": "I think we can remove this now that we have the API v2.1 release.", + "reference": "FYI you could use a raw string for this which removes the need for escaping the inner quotes." + }, + { + "prediction": "I think this test should be `@pytest.mark.parametrize('keystr, is_special_key', ...)`", + "reference": "2 blank lines here (between functions)" + }, + { + "prediction": "nit: can we rename this to `BaseRewriteFilesWithPartitionSpec` to make it more clear what this class is?", + "reference": "Nit: we try to avoid whitespace changes because they can easily cause unnecessary commit conflicts." + }, + { + "prediction": "I think this should be `substr($file_contents, $end_pos, 2) === '::'`", + "reference": "As mentioned below, I'm not sure why this is only allowing refs that are tagged with `*` at the start!" + }, + { + "prediction": "I don't think this is the right place to do this. I think it would be better to have a method in `CombinedAppsFilter` that checks if this is equal to another `CombinedAppsFilter` object.", + "reference": "Don't forget the {} symbols, and please use EqualsBuilder and HashcodeBuilder as possible" + }, + { + "prediction": "I'm not sure this is the right place for this test. I think it should go in `testutil/testutil.go`", + "reference": "Allocate buffer once outside loop." + }, + { + "prediction": "This is a bit of a hack, but I don't see a better way to do this.", + "reference": "It would be better to check that system.nodes[1]->network.port is somewhere in the target without specifying its exact position. But it is a very minor point and I have no string opinion on it just thought I'd mention it because our tests in general have too implementation detail." + }, + { + "prediction": "I'm not sure this is the right place for this exception message. I think it should be moved to `org.eclipse.jetty.websocket.WebSocketClientHandler` and `org.eclipse.jetty.websocket.WebSocketServerHandler` instead of `org.eclipse.jetty.websocket.WebSocketClientHandler` and `org.eclipse.jetty.websocket.WebSocketServerHandler`. This is because `org.eclipse.jetty.websocket.WebSocketClientHandler` and `org.eclipse.jetty.websocket.WebSocketServerHandler` are the only two classes that implement the `javax.ws.rs.core.Response` interface. The `org.eclipse.jetty.websocket.WebSocketClientHandler` and `org.eclipse.jetty.websocket.WebSocketServerHandler` classes are the only two classes that implement the `javax.ws.rs.core.Response` interface. The `org.eclipse.jetty.websocket.WebSocketClientHandler` and `org.eclipse.jetty.websocket.WebSocketServerHandler` classes are the only two classes that implement the `javax.ws.rs.core.Response` interface. The `org.eclipse.jetty.websocket.WebSocketClientHandler` and `org.eclipse.jetty.websocket.WebSocketServerHandler` classes are the only two classes that implement the `javax.ws.rs.core.Response` interface. The `org.eclipse.jetty.websocket.WebSocketClientHandler` and `org.eclipse.jetty", + "reference": "Should this be in a bundle?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in `ProcessRequestAsync` since it's a synchronous call.", + "reference": "When Activity is lost (more precisely, ExecutionContext is lost) in the HttpModule we restore the root (HttpIn) Activity. That makes this assert invalid. I tried to fix the HttpModule so that it restores the Activity that was last running, but it is impossible to retrieve do to the way ExecutionContext works. It isn't an issue to remove the assert, but it is unnerving. Any instrumentation running in IIS reliant on Activity.Current could run into trouble." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `RegisterHandlers` function.", + "reference": "what was the point in moving handlers registration into a separate method?" + }, + { + "prediction": "I think this should be `if state.Config.Cache.RetrieveCommand != \"\" && len(mplex.caches) == 0 {`", + "reference": "At this point we probably want to ensure there's a store command set." + }, + { + "prediction": "I'm not sure this is the right way to do it. I think we need to make sure that the indexes are unique, and that we don't have two indexes for the same thing.", + "reference": "This code is way too complicated for what it does. I don't want to be a PITA, but what can you consider rewriting it in a simpler way? I'm talking about the whole `_getDerivationIndexes` function" + }, + { + "prediction": "Shouldn't this be `string result = await _vaultService.Sign(Guid.Parse(vaultId), Guid.Parse(keyId), message.Replace('0x', string.Empty));` ?", + "reference": "Don't throw base exception, specify more precise type" + }, + { + "prediction": "I don't think this is the right place for this function. This function is only used in `tests/unit_tests/functional_tests.py`. I think it should be moved to `tests/unit_tests/functional_tests.py`.", + "reference": "Recursive -> Recursively converted -> convert" + }, + { + "prediction": "I think this should be `num_fields > 0 && num_fields < 127`", + "reference": "why is this object API only? I think the reason why we didn't do this before was because this code was shared with Java which doesn't have value structs." + }, + { + "prediction": "I think we can remove the `DockerVersion: ` portion of the query.", + "reference": "just to confirm, so backend will deal with both old format and new format?" + }, + { + "prediction": "I think this should be `where T : struct, Enum`", + "reference": "huh, look at that, I wasn't aware you could constrain a type by Enum" + }, + { + "prediction": "I don't think this is the right place for this function. It should be in the `adios2_mpi` module, not the `adios2` module. The reason is that the `adios2_mpi` module is for MPI applications, and the `adios2` module is for non-mpi applications. The `adios2_mpi` module should have the functions that are common to both MPI and non-mpi applications, and the `adios2` module should have the functions that are specific to MPI applications.", + "reference": "Even though the debug parameter is effectively ignored, should this default to `false` instead of `true`?" + }, + { + "prediction": "I don't think we need this interface. We can just use `View` directly.", + "reference": "What is the purpose of this interface? Unlike ParamDocView, it doesn't seem to be used anywhere to enable polymorphism" + }, + { + "prediction": "I think this is the only place where we're using caddy. I think we should remove this file and all of its code from this PR.", + "reference": "We added a library to generate a UUID for the request_id directive \"github.com/nu7hatch/gouuid\" can we uses the same one for what you want rather than add another dependency? Or if the google one is better can we remove the nu7hatch library?" + }, + { + "prediction": "I'm not sure this is the best way to do this. I think we should be able to just do `p.pingConfig.Timeout / p.pingConfig.Interval` and avoid the `time.Duration(i)*p.pingConfig.Interval` part.", + "reference": "Shouldn't this be `i * Interval`? You're multiplying nanos with a Duration, I'm not sure what's the result :)" + }, + { + "prediction": "I'm not sure this is the right way to do this. The problem is that `make_unwritable()` is called for every allocation, which means that if the allocation fails, we'll end up allocating again and again. I think we need to find a way to do this in a way that avoids allocating and unprotecting the same page over and over again.", + "reference": "I guess it's not no-access to match Windows where guard pages are readable." + }, + { + "prediction": "I'm not sure this is the right place for this logic. I think it should be in the `before_save` callback of the `Proposal` model, since it's related to the `Proposal` object itself and not to the `NcrJob`.", + "reference": "Not a blocker, but would probably be useful to have a `scope :non_pending_approvers` on the `Proposal` model." + }, + { + "prediction": "I think this should be `TaskState`, not `worker_state`. It's the state of the worker, not the state of the task itself.", + "reference": "Add trailing comma" + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think it should be done in `init.go` and then `GracefulShutdown` should be called when `init` is done.", + "reference": "I see someone say SIGKILL can not be caught by process. The original code here about `SIGKILL` is useless?" + }, + { + "prediction": "I think this should be `output[Setting.THEME_OLED_DARK] = _('OLED dark');` and not `output[Setting.THEME_OLED_DARK] = _('OLED dark');`", + "reference": "As it is a mobile only theme, please make sure the option appears only on mobile" + }, + { + "prediction": "`strip()` is not needed here.", + "reference": "Would like a docstring and type annotations here" + }, + { + "prediction": "I think this should be `self.shard_key_fields = {}`", + "reference": "This is an API change. Why was it made?" + }, + { + "prediction": "I think this should be `using Microsoft.VisualStudio.TestPlatform.Core.Utilities.Tracing;`", + "reference": "Please move using inside namespace." + }, + { + "prediction": "I'm not sure this is the best way to do it, but it's the only way I could get it to work.", + "reference": "shall we create some enum flags for setasmain shouldprocess and pos?" + }, + { + "prediction": "I think this should be `msi_opts['PUPPET_AGENT_STARTUP_MODE'] == \"Automatic\" ? \"Auto\" : msi_opts['PUPPET_AGENT_STARTUP_MODE']` instead of `msi_opts['PUPPET_AGENT_STARTUP_MODE'] == \"Automatic\" ? \"Auto\" : msi_opts['PUPPET_AGENT_STARTUP_MODE']`", + "reference": "Should this `PUPPET_AGENT_STARTUP_MODE` have a corresponding yardoc change?" + }, + { + "prediction": "I think we can remove this file now, it's not used anymore.", + "reference": "Why not simply remove the `pytest` import now that it's not needed anymore? :wink:" + }, + { + "prediction": "This file should be deleted.", + "reference": "Yeah, not filled in yet." + }, + { + "prediction": "I'm not sure this is the best way to do this. I think it would be better to add a `:checked` attribute to the `input` tag and then use `f.check_box :active, checked: true` in the view.", + "reference": "don't use style. Use a class instead. reducing `col-xs-12` down to 8 or 6 or whatever should do the trick" + }, + { + "prediction": "nit: can we use `Objects.requireNonNull(table, \"table is null\");` instead of `Objects.requireNonNull(database, \"database is null\");`?", + "reference": "should we also do `reloadCache` when database is null?" + }, + { + "prediction": "I think this function should be called `getQueryMol` instead of `getQueryMol2`.", + "reference": "Why not just return QueryMol directly? Why require the copy?" + }, + { + "prediction": "I think this should be `os.path.join(os.path.abspath(__file__), '../../', fname)`", + "reference": "Could you add a docstring?" + }, + { + "prediction": "Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.", + "reference": "looks like you added newlines after blocks in a few files - I generally like newlines before/after multi-line blocks _except_ when the end the block is directly nested inside another block (eg: two `end`s next to each other) what do you think?" + }, + { + "prediction": "I don't think this is a good idea. It hides the fact that this visitor is not thread-safe.", + "reference": "@jlerbsc 's fix in #2918 in action - thanks! :smiling_face_with_three_hearts:" + }, + { + "prediction": "I think this should be `self.zero_count = zero_count or not count`", + "reference": "nitpick: Please lower-case `Zero_count` (as it's a literal argument name) and `Argument` here." + }, + { + "prediction": "I think this should be `a.Name != issuer`", + "reference": "change the name of the function to match its functionality? account IsIssuing?" + }, + { + "prediction": "I think this should be `from dask.dataframe import GroupBy`", + "reference": "for later: add docstring (can just copy paste Pandas')" + }, + { + "prediction": "I think we should rename this file to `mocks.go`", + "reference": "nit: @sonofachamp pointed out to me that the idiomatic way is \"archermocks\" (lowercase for package names)" + }, + { + "prediction": "I think we can remove this error now, since it's no longer used.", + "reference": "Ugh I'm stupid, can you change this to `yarpc.InternalErrorf`?" + }, + { + "prediction": "I think this should be `private final String name;` instead of `private final String name = table.name() + \".all_data_files\";`", + "reference": "We instantiate some metadata tables in tests so I kept the old constructor too. Won't harm if someone is using it directly too." + }, + { + "prediction": "I think this should be `throw new Error('Can not use `limit` and `perDocumentLimit` at the same time. Model `' + mod.model.modelName + '`; limit: ' + queryOptions.limit + ' perDocumentLimit: ' + queryOptions.perDocumentLimit)`", + "reference": "I think the better place to put this might be `lib/options/PopulateOptions.js`. That should make it easier - checking options in `populate()` can get confusing." + }, + { + "prediction": "nit: `params` -> `Config`?", + "reference": "Lets have simple function arguments here, because now struct `traversal.Params` started to have 2 purposes: 1. used as contract in DTO between consumer-provider 2. as function parameters for internal code calls" + }, + { + "prediction": "This file should be renamed to `RemoteDistributorTest.java`", + "reference": "Probably best not to have an empty test...." + }, + { + "prediction": "I think it would be better to have a link to the website where you can learn more about upcase.", + "reference": "`image_tag` in the `testimonials` files?" + }, + { + "prediction": "I don't think this is the right place to do this. This is only used for debugging, right? I think we should move it to the `FlowController` or `FlowManager` class.", + "reference": "I believe flow.toObject() method is throwing NPE if SLA option list (i.e. this.executionOptions.getSlaOptions()) is null or one of the value in the list (i.e. this.executionOptions.getSlaOptions()) is null. If that is the case we could fix root cause of NPE in the ExecutableFlow.toObject() method. The corresponding code to populate SLA options can be modified as follows. final List> slaOptions = Optional.ofNullable(this.executionOptions.getSlaOptions()).orElse(Collections.emptyList()).stream() .filter(Objects::nonNull) .map(slaOption -> slaOption.toObject()) .collect(Collectors.toList());" + }, + { + "prediction": "I'm not sure if this is a good idea, but it's the only thing I can come up with that doesn't break anything.", + "reference": "So I haven't tested this - but since the icon location is just directly dumped into the img _src_ attribute, won't this cause issues with Ghost blogs in a subdirectory? If I'm misunderstanding what the purpose of the default is then let me know" + }, + { + "prediction": "I'm not sure this is the right way to do this. I think it would be better to use `::testing::AssertionResult` instead of `int result = RUN_ALL_TESTS();` and then use `::testing::AssertionStatus` instead of `int result = RUN_ALL_TESTS();`", + "reference": "Why swallow the exception here rather than propagate it?" + }, + { + "prediction": "I think this should be `Optional[List[Tuple[str, str]]]` and not `Optional[List[str]]`", + "reference": "How about `column_index_names`? `column_names` sounds ambiguous." + }, + { + "prediction": "I think we should rename this to `WRITE_METRICS_MODE_DEFAULT` to be consistent with the others.", + "reference": "+1 on this. Do we want to have it as `WRITE_METRICS_MODE_COLUMN_CONF_PREFIX` to be consistent with defaults? Is there a possibility we will have `READ_METRICS_MODE_COLUMN_CONF_PREFIX`? Not sure." + }, + { + "prediction": "I think this test should be moved to `test_cumprod.py`", + "reference": "Shall we use different inputs for `PySpark < 2.4` where `transpose` won't work with different data types." + }, + { + "prediction": "I don't think we need to add this here, since it's only used in `pyspark.sql`, which is only used in `dask`", + "reference": "we should sort the headers like in spark: public packages, then pyspark, then internal" + }, + { + "prediction": "Why do we need to check for clientTLSConfig and not just clientTLS?", + "reference": "looks like we should drop this var from the transport options struct" + }, + { + "prediction": "I think this is the only test that needs to be changed. The rest of the tests pass.", + "reference": "Ah, yeah, this is the test for the validation that I mentioned in a remark above about relaxing the validation." + }, + { + "prediction": "I don't think this is the right place to put this function. I think it should be in `transformations` or `transforms.py`", + "reference": "For tensors, it is better to illustrate the shape." + }, + { + "prediction": "I'm not sure this is the right place for this test. I think it would be better to move this test to `test/unit/admin/components/site-kit/index.js` since it's only used in that file.", + "reference": "This was removed in a recent PR for the admin bar, but should have been kept. It's been restored in the other admin bar PR but I've added it here to for completeness." + }, + { + "prediction": "I'm not sure if this is the right place for this test. I think it would be better to move it to `InstrumentationTests` or `InstrumentationCoreTests`.", + "reference": "nit: probably swap the if condition and `if/else` and check `NETCOREAPP2_1` which looks more natural." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in `account.go` since it's only used there.", + "reference": "for the tag, should it be `requestor_rtt` since the other is `responder_rtt`?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do it in `MutateInventory` instead of in `Monster` itself.", + "reference": "The one sad part of this is that is will generate a lot of overhead if you loop through a vector, since it obtains the vector every time. But with the current API there is no alternative I guess, and it is better to have the option than not." + }, + { + "prediction": "I think this should be `github.com/ipfs/go-ipfs-files` instead of `github.com/filecoin-project/go-filecoin`", + "reference": "nit: there should be a newline between `types` and `go-ipfs-files`." + }, + { + "prediction": "I think we can remove this file and just use the `Duration` from the `retryAfter` struct.", + "reference": "would be nice to have this as a parameter (Options), re: technical debt discussions" + }, + { + "prediction": "This import is not needed.", + "reference": "complete ignorance here but is it ok to import this from `com.sun`? can it break under non-oracle JREs?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think we should move it to `span_processor.go` since it's only used there.", + "reference": "Is this some way of saying that the span is going to be sampled? I'm basing this question on the condition I saw for the `OnEnd` to be called - `mustExport := s.spanContext.IsSampled() && )`. Shouldn't the condition be `s.spanContext.IsSampled()` to match the condition for calling the `OnEnd`?" + }, + { + "prediction": "I think we can remove the `volumereplica.GetAndUpdateSnapshotInfo(c.clientset, cvr)` call here.", + "reference": "just calling UpdateSnapshotInfo() should be fine" + }, + { + "prediction": "I'm not sure this is the right place for this change. I think it should be in `GlobalConfiguration` since it's a global setting that affects all traces.", + "reference": "Was `DefaultLogMessageRateLimit` not configurable anywhere?" + }, + { + "prediction": "I think this test should be moved to `docker_test.go` since it is not related to the pull image functionality.", + "reference": "Please use the `assert` instead. Same below." + }, + { + "prediction": "Please add a space after the comma.", + "reference": "Owww, I think I found a typo. `suche`" + }, + { + "prediction": "I don't understand why this is removed.", + "reference": "This can happen because we could get `PhantomNodes` that are not admissible as source/target right?" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but it seems like it should be.", + "reference": "Should we add a note here to file a bug if this ever happens?" + }, + { + "prediction": "I think this should be `return 0, errors.Wrap(err, \"benchmarks quantity overflows int64\")`", + "reference": "overflow is still possible, isn't it?" + }, + { + "prediction": "I'm not sure if this is a good idea, but I don't have a better suggestion.", + "reference": "This seems more like a personal preference, so maybe this should be in your `~/.rspec`?" + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in `scapy.error` since it's a superclass of all exceptions raised by `scapy`.", + "reference": "To avoid a circular import between pcapdnet and automaton" + }, + { + "prediction": "I think this should be indented 4 spaces instead of 2.", + "reference": "Please remove this blank line." + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think it should be done in the `Reconcile` method of the `CloudAuditLogger`.", + "reference": "it feels that the WorkloadIdentityCondition should be added to this Status... And if you have workload identity enabled, but not working, then you can mark that condition failed, and also Mark the ready false... not entirely sure though" + }, + { + "prediction": "I'm not sure this is the right place for this check. I think it should be in the `if (pPipeline->graphicsPipelineCI.pRasterizationState->pNext)` check above.", + "reference": "I think these got refactored to `LvlFindInChain` to better conform with the coding guidelines. I think MarkL left these in for backwards compatibility." + }, + { + "prediction": "I don't think we need this extra line.", + "reference": "It's fine for this PR, but in the future try to minimize unrelated changes." + }, + { + "prediction": "I think this should be `:$HOME/.ansible/roles:$HOME/.ansible/plugins/roles:$project_directory/roles`", + "reference": "The library -> modules and filters -> filter path changes are breaking changes or?" + }, + { + "prediction": "I don't think we should be importing `boto3` and `botocore.config` at all. We should just use `google-cloud-storage` and `google-auth`.", + "reference": "Can we encapsulate this check (`os.environ.get(\"TEST_TARGET\") == \"AWS_CLOUD\"`) into a small config/util function? (and also use it in `integration/conftest.py`) (I'd generally try to avoid accessing `os.environ` directly across the codebase. I'm aware that we're already doing this in a few places, but maybe we can start pulling things out - this will also help us create more systematic config/environment abstractions as we go...)" + }, + { + "prediction": "`[].concat(child).reverse().forEach((item) => {` should be `[].concat(child).reverse().forEach(item => {`", + "reference": "An `if` statement would be better here. Functions, concat and reverse are all very expensive." + }, + { + "prediction": "I think this should be `goerli` instead of `go`", + "reference": "`Log here: connect to default factory for goerli network

    `" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `DeploymentConfig` struct.", + "reference": "nits, should add `break` to avoid redundant iterations." + }, + { + "prediction": "I think this test should be moved to the `EIP_158` folder.", + "reference": "I think we want an exception here, there should never be a transfer to a nonexisting account." + }, + { + "prediction": "This should be `LOG.debug`", + "reference": "This code is new and not tested well. While we may drop the log level before we ship 4.0, right now this is extremely helpful to users." + }, + { + "prediction": "why not 10?", + "reference": "Can we make these asserts more strict/precise? I remember this test helped to spot the issue of inconsistent results on different platforms due to using `sort` instead of `stable_sort`." + }, + { + "prediction": "I think this should be `select_interpreter(executable, interpreters || {})` instead of `select_interpreter(executable, interpreters)`", + "reference": "I thought about adjusting for case here as well? For example `.rb,rb,.RB,.rb` would all map to ruby interpreter specified? Is that too much \"magic\"? Is there a sane workflow that someone would choose to map `.rb` to one interpreter and `.RB` to another?" + }, + { + "prediction": "`ostree_sysroot_get_booted_deployment` is called from `ostree_sysroot_get_subbootversion` which is called from `ostree_sysroot_load` which is called from `ostree_main` which is called from `ostree_daemon` which is called from `ostree` which is called from `lib/ostree/ostree` which is called from `lib/ostree/ostree` which is called from `lib/ostree/ostree` which is called from `lib/ostree/ostree` which is called from `lib/ostree/ostree` which is called from `lib/ostree/ostree` which is called from `lib/ostree/ostree` which is called from `lib/ostree/ostree` which is called from `lib/ostree/ostree` which is called from `lib/ostree/ostree` which is called from `lib/ostree/ostree` which is called from `lib/ostree/ostree` which is called from `lib/ostree/ostree` which is called from `lib/ostree/ostree` which is called from `lib/ostree/ostree", + "reference": "In this and the one below, should we assert `self != NULL` first?" + }, + { + "prediction": "Why did you change the status code to 200?", + "reference": "Why this is needed?" + }, + { + "prediction": "I don't think this is the right place for this method. It should be moved to `Package`.", + "reference": "we already have .meta() so I don't think we want get_meta() for PackageEntry" + }, + { + "prediction": "I'm not sure this is the right place to get the start timestamp. I think it should be in the `coprocessor-config.properties` file.", + "reference": "question: can we always get the startts from dagrequest?" + }, + { + "prediction": "I think it would be better to use `accountID` instead of `propertyID` here.", + "reference": "Nit-picking, but this can be simplified to reference `properties[ 0 ]` since that is already retrieved 2 lines above." + }, + { + "prediction": "I think this should be `delete` instead of `delete!`", + "reference": "This technically works because we call `get_targets` before we remove the target, so it's bound to have been resolved. But I'm not sure I would like to rely on that assumption. Should we also remove it from `@unresolved_targets` to be safe?" + }, + { + "prediction": "I don't think this is correct. If the contract is null, then the code should be empty, not new Code().", + "reference": "So what happens if I try to get code on a EOA?" + }, + { + "prediction": "I think this should be `values = [i for i in inferred.values() if isinstance(i, astroid.Assign)]`", + "reference": "Can't we return an empty list and then just compare the lengths? Thereby removing this `if`." + }, + { + "prediction": "I'm not sure if this is a good or bad thing. I think it's a good thing, but I'm also not sure if it's a good thing to throttle at 500ms. I think it's a good thing to throttle, but I'm also not sure if it's a good thing to throttle at 500ms. I think it's a good thing to throttle, but I'm also not sure if it's a good thing to throttle at 500ms. I think it's a good thing to throttle, but I'm also not sure if it's a good thing to throttle at 500ms. I think it's a good thing to throttle, but I'm also not sure if it's a good thing to throttle at 500ms. I think it's a good thing to throttle, but I'm also not sure if it's a good thing to throttle at 500ms. I think it's a good thing to throttle, but I'm also not sure if it's a good thing to throttle at 500ms. I think it's a good thing to throttle, but I'm also not sure if it's a good thing to throttle at 50", + "reference": "Mb change it to 'doesPassRestrictions()'? Doesn't sound enough like a boolean-returning method to me." + }, + { + "prediction": "I'm not sure this is the right place for this interface. I think it should go in `pkg/feeds` since it's a part of the feeds package.", + "reference": "TODO: in fact At when used with noncurrent time should not return a next index. only latest should.." + }, + { + "prediction": "I think this should be `isTopLevelFragment ? Array.isArray(tmp) ? tmp : [tmp] : tmp`", + "reference": "There are scenario's where we skip an update with a placeholder, in this case tmp returns null with render, this is not an array so we `[null]` it" + }, + { + "prediction": "I'm not sure if this is the right place to move this, but it seems like it should be in `java.util.stream.Stream`?", + "reference": "@danieldietrich, this wasn't tested so I presumed it wasn't working before either :p" + }, + { + "prediction": "This should be `use Typo3\\Core\\Utility\\GeneralUtility;` instead of `use ApacheSolrForTypo3\\Solr\\Facet\\Facet;`", + "reference": "Please leave two empty lines after the `use` statement" + }, + { + "prediction": "nit: remove empty line", + "reference": "Please move this import in the 3rd group which is for external dependencies" + }, + { + "prediction": "I think this should be `not node or isinstance(node.get(RESERVED['file']), (str, bytes))`", + "reference": "So what exactly is this fixing? The unit test is passing with or without this change." + }, + { + "prediction": "I think this should be `fs::path` instead of `folly::stringPrintf`", + "reference": "auto targetFile = fs::FileUtils::joinPath(newPath, folly::stringPrintf(\"%019ld.wal\", it->first));" + }, + { + "prediction": "I think we can remove this method and use `snapshotIdsBetween` instead.", + "reference": "I don't see any place that checks whether the from snapshot is an ancestor of the to snapshot. That seems like a requirement for this to work correctly to me." + }, + { + "prediction": "I think it would be better to use `isset($functionConfig['helpText'])` instead of `isset($functionConfig['helpText'] ?? '')`", + "reference": "Other calls to getHelpText() are wrapped in an `isset()` check. Would it make sense to be consistent, and either restore that here or remove it elsewhere?" + }, + { + "prediction": "I think this should be `@configuration.output_stream = out || stdout`", + "reference": "Why the change? If `output_stream` is set to something non-nil, it seems odd (and potentially wrong) to overwrite it...." + }, + { + "prediction": "Align the parameters of a method call if they span more than one line.", + "reference": "Thinking this should have an underscore." + }, + { + "prediction": "I think this should be `assert MSG_STATE_SCOPE_MODULE == linter._get_message_state_scope(\"W0102\", 3)` instead of `assert MSG_STATE_SCOPE_MODULE == linter._get_message_state_scope(\"W0101\", 3)`", + "reference": "To accommodate the change to the method being private." + }, + { + "prediction": "I think this should be `CollectionRule` and not `PropertiesNamesCamelCase`", + "reference": "Shouldn't we traverse all definitions and apply this rule over all model definitions in the doc" + }, + { + "prediction": "I think it would be better to have this as a separate file, so that it's clear that it's not part of this file.", + "reference": "Please rename this class that it ends with the suffix \"Test\" - otherwise the tests won't be executed." + }, + { + "prediction": "I'm not sure this is the best approach. I think we should be able to tell if a file has a Prettier config by looking at the `prettierignore` file, which is located in the root of the project. I don't think we should be able to tell if a file has a Prettier config by looking at the `prettier-config.js` file, which is located in the root of the project.", + "reference": "As a JS file, this should also receive our standard file header." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in the same place as `numBMOsInFrag` and `numStreams`.", + "reference": "I take it memQuotaRatio is an \"out\" parameter at line 1810? Also, why use MIN_QUOTA in both the cases of memQuota being too low and too high? Contrast this code with RelRoot::codeGen where we set MIN_QUOTA only in the too low case." + }, + { + "prediction": "I think we can remove this line now, since we don't need it anymore.", + "reference": "It looks like for newpullsubscription, we have two functions. One for pullsubscription with default, one for pullsubscription without default. If you remove setdefault here, then there is no differences between these two functions." + }, + { + "prediction": "I think this should be `uint32` instead of `uint64`", + "reference": "not dramatic, but why 32bits if we allow a range that is smaller than 8?" + }, + { + "prediction": "I don't think we should add a new field to the existing DTOs.", + "reference": "- Use type from `service_discovery/dto/price.go` - Rename `Price` -> `Money`" + }, + { + "prediction": "I think it would be better to use `System.out` instead of `System.out.println`.", + "reference": "one space missing at the beginning" + }, + { + "prediction": "Should this be `yaml:\"platform\"` or `yaml:\"platform,omitempty\"`?", + "reference": "I worry that having `Platform` as `string` instead of `*string` would result in it getting overriden with `\"\"` if the environment manifest config doesn't specify `platform` . If it gets overridden as `\"\"`, that could be a problem for users that are not using `linux/amd64` right? If this indeed is a potential impact, could we double check in `ApplyEnv`'s unit test? Same with the `Platform` in `TaskConfig`. Sorry for not seeing this in my previous review!!!" + }, + { + "prediction": "I think this should be `'<%= connect.test.options.port %>/test/integration/api/rules/'`", + "reference": "I like the new directory `/api`, what is the thinking behind `/external`?" + }, + { + "prediction": "Why do we need to sort here?", + "reference": "staticcheck flags this: replace with `for k := ..`" + }, + { + "prediction": "I'm not sure this is the right way to do this. I think we should be using `GMLAN_PM` to enable programming mode, not `GMLAN` itself.", + "reference": "There's already a sleep right above" + }, + { + "prediction": "I think this should be `$var_id = $thisClass->name . '::' . substr($assertion->var_id, 6);`", + "reference": "This feels hacky, is there a better way?" + }, + { + "prediction": "I don't think this is necessary. `collections.OrderedDict` should be available by default.", + "reference": "Can we move this logic into the `boto.compat` module? Then it's just `from boto.compat import OrderedDict` instead. Also, this is introducing a new dependency. What about users on 2.6.x that don't have the OrderedDict module installed? We may need to fall back to an ordinary `dict` so that existing code in the wild does not break." + }, + { + "prediction": "I think this should be `SerializationSettings` and `DeserializationSettings` should be `JsonSerializerSettings`", + "reference": "\"Gets the JSON serialization settings.\" would be better?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `server/file`.", + "reference": "The endpoint should be in plural `/files`." + }, + { + "prediction": "I'm not sure if this is a good idea, but I don't have a better suggestion.", + "reference": "??? Why do we need to have a different API in Python? Oh, wait, I see what you did. It's to fake the namespaces. Given that I don't think the namespaces are necessary, and that less of these should be exposed anyway, I think these should go." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `pkg/context.go`", + "reference": "I think this line is gofmt issue? @daixiang0" + }, + { + "prediction": "I think this test should be renamed to `TestParseSubrepoLabelParts`.", + "reference": "probably better to assert the values directly; technically you could pass this test with an implementation that always returned \"\" for the subrepo for example." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in the `addTestingTsfBlocks` function.", + "reference": "line is 161 characters (from `lll`)" + }, + { + "prediction": "I think this should be a `@Immutable` interface.", + "reference": "Are these changes needed?" + }, + { + "prediction": "I don't think this is the right place to do this. I think this should be done in `org.apache.gobblin.util.FileSystemUtils` instead of `UserUtils`", + "reference": "It seems like reducing the sensitivity would make the test failure less likely to occur, but not fix the issue?" + }, + { + "prediction": "This should be `use Thelia\\Model\\Tools\\I18nTimestampableTrait as I18nTimestampableTrait`.", + "reference": "missing use statement for importing the full namespace" + }, + { + "prediction": "I think this should be `ErrIncorrectAddressFormatForService`", + "reference": "Generally error messages in Go shouldn't start with capital letter. I see this rule is broken in many places here. Why?" + }, + { + "prediction": "I'm not sure this is the right place for this test. I think it should be in `testSelection.js` under the `selection` section.", + "reference": "These test checks if selection coordinates don't return negative values in that edge cases. Please revert the changes and set `autoWrapCol` and `autoWrapRow` to `false` to the Handsontable instance. This change applies to the entire Core_selection.spec.js file." + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it's the only way I could come up with right now.", + "reference": "I would prefer flag SkipGasPricingValidation" + }, + { + "prediction": "This should be `auto exists = blocks.find (root_a);`", + "reference": "could be `const &` ?" + }, + { + "prediction": "I think we can remove `hideProgressAfterFinish` as it is not used anywhere.", + "reference": "The docs should also be updated with the new option." + }, + { + "prediction": "I don't think we should be importing boto. We should be using `sqs` or `smtplib` or `sentry` or `sentry-python` or `jose` or `josepy` or `sentry` or `sentry-python` or `jose` or `josepy` or `sentry` or `sentry-python` or `jose` or `josepy` or `sentry` or `sentry-python` or `jose` or `josepy` or `sentry` or `sentry-python` or `jose` or `josepy` or `sentry` or `sentry-python` or `jose` or `josepy` or `sentry` or `sentry-python` or `jose` or `josepy` or `sentry` or `sentry-python` or `jose` or `josepy` or `sentry` or `sentry-python` or `jose` or `josepy` or `sentry` or `sentry-python` or `jose` or `josepy` or `sentry` or `sentry-python` or", + "reference": "Name is _way_ to generic for this patch to be accepted I think. Can you rename it to maybe `send_sns_notification` or something else you find suitable?" + }, + { + "prediction": "I'm not sure this is the best way to do this. I think we should be able to pass in the config directly, but I'm not sure how to do that.", + "reference": "Out of the scope." + }, + { + "prediction": "`callback` can be `undefined` in this case.", + "reference": "I think we need an if block to check that if this API is really missing. We wouldn't want to override the browser's implementation." + }, + { + "prediction": "I don't think this is the right way to do it. I think we should check if `editorClass` is an instance of `Editor` and then use `editorClass.EDITOR_TYPE` if it is, or `Editor.EDITOR_TYPE` if it isn't.", + "reference": "I was wondering, things like EDITOR_TYPE, VALIDATOR_TYPE, RENDERER_TYPE are not obligatory. Therefore if the custom editor will be registered with this method, `name` will be set to `undefined`. Should we handle this scenario?" + }, + { + "prediction": "nit: remove empty line", + "reference": "This line should not be removed, as it is not the description of the package, but a copyright header." + }, + { + "prediction": "I think this should be called `LastPrefetchTag` or `LastPrefetchTime`.", + "reference": "Wouldn't it be more space efficient to make this a `byte` enum or bitfield?" + }, + { + "prediction": "I think this should be `\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"\"", + "reference": "Flake8 doesn't like the assignment, but non-use of `e` here. I think we can just remove the try/except here for `cursor.execute(sql)`." + }, + { + "prediction": "I think this interface should be removed. It is not used anywhere.", + "reference": "Maybe add short example list: .... type body declarations, such as AnnotationMembers, Methods, Fields" + }, + { + "prediction": "I don't think we need to add any new capabilities here. We already have them in the existing capabilities.", + "reference": "These are really meant to be the keys in the capabilities, not the keys of values within the capabilities" + }, + { + "prediction": "I think this should be `@return the full name for this table`", + "reference": "It is debatable whether we have to default this. I did this to avoid breaking custom implementations." + }, + { + "prediction": "I'm not sure this is the best way to do this, but it's the only way I could come up with that worked.", + "reference": "# `attr_value['string'] is not None` probably not required as `attr_value['string'] == value` check is already being done" + }, + { + "prediction": "I think this file should be renamed to reflect the fact that it is an addon, not a package.", + "reference": "we shouldn't need the \"addon\" rename" + }, + { + "prediction": "I think this should be `before_filter :must_be_admin_user`", + "reference": "These are covered by routing constraints." + }, + { + "prediction": "I think this should be `aws.String([]string{*instanceID})`", + "reference": "Could we use just a normal string here?" + }, + { + "prediction": "nit: can we move this to the top of the file?", + "reference": "`isFunction(Symbol)` triggers a `ReferenceError` if Symbol is undefined. Using `typeof Symbol === 'function'` is OK however." + }, + { + "prediction": "I'm not sure this is the right way to do it. The problem is that this will cause the election thread to run in a race condition. The election thread may transition to the active state before the lock is unlocked. In that case, the election thread will try to acquire the lock, which will fail because the lock is held by some other thread. The election thread will then try to transition back to the active state, which will fail because the lock is still held by some other thread. The election thread will then try to transition back to the active state, which will fail because the lock is still held by some other thread. The election thread will then try to transition back to the active state, which will fail because the lock is still held by some other thread. The election thread will then try to transition back to the active state, which will fail because the lock is still held by some other thread. The election thread will then try to transition back to the active state, which will fail because the lock is still held by some other thread. The election thread will then try to transition back to the active state, which will fail because the lock is still held by some other thread. The election thread will then try to transition back to the active state, which will", + "reference": "Is there an else clause (with a lock.unlock ()) missing here as well? If we think we do not need an else clause then lets add an else clause containing assert zero." + }, + { + "prediction": "I'm not sure this is the right way to do it. I think we need to make sure we have enough balance to pay for the transaction.", + "reference": "do we foresee `32` ever changing? (as well as its use in error checking in `clerk.go`) if \"no\" this is fine, if \"yes\" it's probably still fine" + }, + { + "prediction": "nit: remove trailing whitespaces", + "reference": "you don't need to create a enum for this, java allows you to switch on a string ;) (since java 7?)" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it's the only way I could get it to work.", + "reference": "This should be `modelPromises.roles = this.get('store').query('role', ...` and the promise body should just `return roles;`. This is because the `model()` hook will pause for the returned promises to be resolved before continuing so when returning `RSVP.hash` you end up with a hash containing the values returned from the promises so the controller and everything else relying on the `model` object doesn't need to worry about things being async." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I could get it to work.", + "reference": "This is basically a repeat of `main-is-top-level.js`. I suggest having these 3 checks point to the same evaluate file. You can change what element they test through the rule selector as well as the check.json options property. So you would have `main-is-top-level.json`, `banner-is-top-level.json` and `contentinfo-is-top-level.json` each point to `landmark-is-top-level.js`, and pass in a different `options` object which tells it what element you're trying to test." + }, + { + "prediction": "I'm not sure this is the best way to do this. I think we should be able to do this in a more efficient way, but I don't know how to do that.", + "reference": "Why do we need this check? setCore already handles nulls." + }, + { + "prediction": "I think this should be `__dir__` instead of `__getitem__`.", + "reference": "good catch, thanks. This is going to make the user experience much better." + }, + { + "prediction": "I'm not sure if this is a good idea, but I don't have a great solution either.", + "reference": "TODO: remove this unused import" + }, + { + "prediction": "I think this should be \"compact JWS format must have two parts\"", + "reference": "Hmm leaking the library name out in the Workload API doesn't seem great. Do we want to catch these errors and return a canned \"could not parse token\" or something instead?" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I could get Travis to pass locally.", + "reference": "I think `-f gradlew` is better for code unity" + }, + { + "prediction": "I think it should be 1024 here.", + "reference": "Is there precedent for this config key? What other keys are similar? The others in this file start with `table.exec.iceberg`. Is there a reason for not continuing with that convention?" + }, + { + "prediction": "This file should be reverted.", + "reference": "Can we avoid no-change changes being committed - they make it harder to distinguish actual changes from code editor changes" + }, + { + "prediction": "I'm not sure if we want to remove the `UpdateServerCertificate.java` sample, as it's still useful to demonstrate how to update the name of an AWS Identity and Access Management (AWS IAM) server certificate. I think we should keep the `UpdateServerCertificate.java` sample, as it's still useful to demonstrate how to update the name of an AWS Identity and Access Management (AWS IAM) server certificate.", + "reference": "AWS Identity and Access Management (IAM)" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `tequilapi` command.", + "reference": "You dont use this dependency anymore" + }, + { + "prediction": "I think this should be `assertNotContains` instead of `assertNotContains`.", + "reference": "Here is the test that checks that the sqlcipher in use was compiled with the right flags" + }, + { + "prediction": "I think this should be `if (mdmLoginServers == null || mdmLoginServers.isEmpty()) {`", + "reference": "Turns out that if the hosts are not in an `array`, an `Exception` is not thrown anymore :-( It simply returns `null`. So, we need to attempt to parse a `string` outside the `catch` block for it to work." + }, + { + "prediction": "I don't think you need to import `URI` here.", + "reference": "this test only covers the happy path. what about no acceptable rest template found?" + }, + { + "prediction": "nit: `LOG.info(String.format(\"Firefox Session %d assigned to %s\", i, chromeSession.getUri()));` `LOG.finer(String.format(\"Firefox Session %d assigned to %s\", i, chromeSession.getUri()));`", + "reference": "Since this is in a test, I imagine that the choice of `info` level was deliberate." + }, + { + "prediction": "This file should be renamed to `langserver_test.go` and this file should be renamed to `langserver_test_test.go`", + "reference": "this should probably be named somewhere if you want to reuse it." + }, + { + "prediction": "I think this should be `BoundServiceAccountSigningKeyFileEnvVar`.", + "reference": "needs a rename to not include AWS" + }, + { + "prediction": "I think it would be better to move this header to the top of the file, so that it is only included once.", + "reference": "Isn't sigma have `double` type?" + }, + { + "prediction": "Why is this needed? I don't see it being used anywhere.", + "reference": "May be better use nano::keypair that generates ramdom value?" + }, + { + "prediction": "I think we can remove this check now, since we don't know what the user selected for BSON options here.", + "reference": "I think the more complete solution will save off a `ignoreUndefined` in the base class for the bulk operation (with a default of `false`), and use that for calculations. Was there a reason you didn't want to support the option from the operation level?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the logout code path.", + "reference": "The catch (Exception e) block that follows does an updateSync, which will get a SmartStore instance (while logging out is taking place) - and then terrible things will happen - a database gets created for the outgoing user that won't be openable by the returning user causing the app to crash at logout. This is a somewhat superficial fix - SmartStore should not return an instance for an outgoing user." + }, + { + "prediction": "I think this test should be moved to `integration/test/integration_test.go` since it's not related to the PR.", + "reference": "huh does this work without a `Return`?" + }, + { + "prediction": "I think this is the only place where `set_exception` is used, so I think it's safe to remove it.", + "reference": "Don't think we want this line, right? (Plus \"failing\" is spelled wrong)." + }, + { + "prediction": "I think this should be `setItemVisibility(menu, R.id.share_item, !selectedItem.getFeed().isLocalFeed());` and not `setItemVisibility(menu, R.id.share_item, selectedItem.getFeed().isLocalFeed());`", + "reference": "I think it would be more clear to have local-feed-hiding all in one place (bottom of this method?). Further up the method, there already is some code that hides the website icon, for example." + }, + { + "prediction": "This should be removed as well.", + "reference": "Why remove this one? It doesn't work yet, but we'll add it sooner or later." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `models`.", + "reference": "Why did you remove the struct tags?" + }, + { + "prediction": "I don't think this is the best way to do it. I think it would be better to have a function that takes the data points and returns a dict with the key being the name of the report and the value being a list of tuples containing the link and the name of the report.", + "reference": "Let's be neutral with tag names. Let's just have \"ReportURL\"" + }, + { + "prediction": "I'm not sure this is the right place for this test. I think it should go in `test/integration/test_span_data.go`", + "reference": "Use an explicit time to ensure conversion is not copy-paste and wrong." + }, + { + "prediction": "I'm not sure this is the best way to do this, but I don't have a better suggestion.", + "reference": "The logic now is to look for ``. This `` output is also not consistent with the other two functions you mentioned. Do the other two RPCs not report an error?" + }, + { + "prediction": "Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.", + "reference": "Use nested module/class definitions instead of compact style." + }, + { + "prediction": "Why is this here? I don't see it being used anywhere in this file.", + "reference": "Do you think we need to keep this in, or is it just leftover personal debugging? Seems like it wouldn't be too useful most of the time, but I don't care too much if you want to keep it." + }, + { + "prediction": "I think this should be `config.showPlayers() | config.showNpcs() | config.FreezeTimers() | config.Veng() | config.TB()`.", + "reference": "showNPCs is not needed" + }, + { + "prediction": "I think this should be `ErrParameterConflict` instead of `ErrParameterAlreadyExists`", + "reference": "Docstring for public function pls" + }, + { + "prediction": "I think this test should be more specific about the error message it's expecting to be trimmed. I think it should be something like `expected error message to be unchanged` instead of `expected temporary file to be trimmed from error message`", + "reference": "This should use `t.Errorf` instead. You want the second part of the test to run even when the first part fails." + }, + { + "prediction": "I don't think we need to check for `ratio.http3 > 0` here, since it's already checked in `if (ctx.protocol_selector.ratio.http3 > 0) {`", + "reference": "Should this if block better be changed to `#if H2O_USE_LIBUV \\n #else ... #endif`? The reason I wonder is because that's the way the QUIC context is being initilaized at the beginning of this function. Though I would not expect practical difference between the two approaches, because ATM the only case where we create QUIC connections is when the protocol selector is set to non-zero, and because when it is set to non-zero `h2o_quiy_close_all_connections` becomes a no-op." + }, + { + "prediction": "I think it would be better to use `Object.assign` instead of `Object.is` here.", + "reference": "`Object.is` is an ES6 feature of JS so I don't think we can use it here (or we have to change our browser support matrix or specify that an Object.is polyfill is pre-req of `preact/hooks`). Should we just do an `===` check in `preact/hooks` and provide a `Object.is` polyfill and version of `useReducer` in `preact/compat`?" + }, + { + "prediction": "I'm not sure if this is the right way to handle this. I think we should check if `options.roles` is an array, and if it is, we should just return it. If it's not, we should throw an error telling the user to provide an array of roles.", + "reference": "This was a bug I picked up by using the TS interface as a guide, this seems like it was / is the intention, also is a bug in master (needs port)" + }, + { + "prediction": "I think this should be `COLLECTION_WITH` instead of `COLLECTION_WITH_COLLECTION`.", + "reference": "It would be helpful to explicit here what this really means and assumes." + }, + { + "prediction": "I think this should be `map[string]*big.Int` instead of `map[string]map[string]*big.Int`", + "reference": "`ExpectedBalances` is a global variable (from `gochecknoglobals`)" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `spec/formatters`.", + "reference": "This is another place where I'd feel more comfortable with declaring the class private. We can always make it public in the future if someone makes a case for that, but I prefer to err on the side of privateness for things like this that 99% of RSpec users won't have a reason to use." + }, + { + "prediction": "I think this should be `nuk.IssuerAccount = optIssuerAccount`", + "reference": "Feels like this should be left as is and add a new createClientWithIssuers or something like that. Avoid all the \"\"" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `SPRequestHandler` class, since it's only responsible for handling the success case.", + "reference": "Minor unrelated bug in the IDP flow where the error wasn't getting displayed as a `Toast`." + }, + { + "prediction": "This should be `const mongoErrorContextSymbol = require('../../lib/core').mongoErrorContextSymbol;`", + "reference": "I thought we got rid of this thing?" + }, + { + "prediction": "I think this should be `@param string $file_name` and `@param string $file_path` instead of `@param string $file_name` and `@param string $file_path`", + "reference": "Please convert int params as well." + }, + { + "prediction": "I think this should be `{0}{1} {2} {3}: {4}`", + "reference": "Fixed bug in implementation. Now I can run the validator from the VS Tools menu, double-click on an output line, and navigate to the site of the issue." + }, + { + "prediction": "I don't think we need to add this to the docs.", + "reference": "Can we rename this field to `HttpServerErrorCodes` or `HttpServerErrorStatuses`? It will contain a list of status _codes_, not a list of _errors_. (Personally I prefer \"codes\" over \"statuses\", but we can't change `DD_HTTP_SERVER_ERROR_CODES`.)" + }, + { + "prediction": "I think this should be `strncasecmp(tmp, \"false\", 3) == 0` instead of `strcasecmp(tmp, \"true\") == 0`", + "reference": "would you please use: flb_utils_bool(...) here ?, that function wraps the on/off/true/false stuff." + }, + { + "prediction": "Should this be nullable?", + "reference": "`invocationInfoTokensToRedact: null` (I really like the convention of using a named parameter whenever the value doesn't communicate the meaning, such as for literal values.)" + }, + { + "prediction": "I think this should be renamed to `async_test` to be consistent with other modules.", + "reference": "maybe renamed to `async_simple_test` if we consider supporting aug test later on?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `Document`.", + "reference": "So where is default_attributes now? Is it used anywhere else still? If not, can it be removed along with any tests of it?" + }, + { + "prediction": "I'm not sure this is the right fix. I think we need to make sure that the `StartTimestamp` and `Timestamp` are always in the same timezone.", + "reference": "We could move this to the base class and remove all these changes. What do you think?" + }, + { + "prediction": "I'm not sure if this is the right thing to do here, but I couldn't come up with a better idea.", + "reference": "While we're doing some translation work, could you extract this button text and the other static text from the view?" + }, + { + "prediction": "I think you can remove the `if(headersValue != null)`.", + "reference": "Nit: Please fix indentation (note: Azkaban uses 2 spaces and not tabs)." + }, + { + "prediction": "I think this should be `schema: []` instead of `schemaVersion: 1, schema: []`", + "reference": "This change is necessary because the schema version is ignored unless a schema is specified. I think that has always been the intent." + }, + { + "prediction": "This should be `case WINDOWS_VERSION_10_1803: info->version = DR_WINDOWS_VERSION_10_1803; break;`", + "reference": "The api/docs/release.dox changelog message is missing: maybe you planned to add it once NtAllocateVirtualMemoryEx and NtMapViewOfSectionEx support is in? I would say, add it here in the same diff that raises max_supported_os_version." + }, + { + "prediction": "I'm not sure this is the best way to do this, but it's the only way I could get it to work.", + "reference": "Just do: `return node.hasAttribute('aria-hidden')`" + }, + { + "prediction": "I'm not sure if this is the right place for this test. I think it should go in `spec/views/catalog/search_controller_spec.rb` since it's a controller spec.", + "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." + }, + { + "prediction": "I think this should be `private static int _currentProcessId;`", + "reference": "Do we need `_processDataPoisoned`? Can the name or the id of the current process ever change? Or the machine name?" + }, + { + "prediction": "I'm not sure why we need to set the environment variable here.", + "reference": "Did it not work out to wait until after containerd and kubelet are started?" + }, + { + "prediction": "This should be `ITEM_PARSE_COOLDOWNREDUCTION`, not `ITEM_PARSE_COOLDOWN`.", + "reference": "variable names suggestions from me: - damageboost, ITEM_PARSE_DAMAGEBOOST, \"damage boost +x%\" - healingboost, ITEM_PARSE_HEALINGBOOST, \"healing power +y%\" - managainboost, ITEM_PARSE_MANAGAINBOOST, \"mana restoration +z%\" alternatively the other names can stay, because \"increase\" convention isn't that bad, just change mana values to: - \"increasemanarestored\", ITEM_PARSE_INCREASEMANARESTORED, \"mana restoration +z%\"" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `data` table, since that's where the data is stored.", + "reference": "Why can't this be determined by 'PARTIAL_SUCCESS' in the `status` field?" + }, + { + "prediction": "Shouldn't this be `sprintf('%s/%04s/%02s', $media->getContext() ?? '', $repFirstLevel + 1, $repSecondLevel + 1)`?", + "reference": "Does it make sense to generate a Exception here? Maybe yes, because it wouldn't make sense to generate a path without the id of the media right?" + }, + { + "prediction": "I think you can remove the `INSTANCE` variable and just call `getInstance()` in the caller.", + "reference": "This should be made private." + }, + { + "prediction": "I think this should be `BaseSVIDPath: a.getBaseSVIDPath(),` and not `BaseSVIDPath: a.getBaseSVIDPath(),`", + "reference": "perhaps this is better modeled as a pkg-level var?" + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in the same place as the other constants.", + "reference": "I don't think there is a maximum scale, neither for Hive nor for Trafodion. The only condition right now is that the scale can't exceed the precision. Example of a valid scale: DECIMAL(18,18). The maximum of 6 digits applies only to TIMESTAMP columns, where we don't support resolution below microseconds." + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in `FakeOAuthServer` since it's related to OAuth.", + "reference": "`ctx` is unused in UpdateProjectStaticUser" + }, + { + "prediction": "I think this should be `String.format(\"https://content.googleapis.com/discovery/v1/apis/%s/%s/rest\", apiName, apiVersion);`", + "reference": "Why is this not the default, and why only for JS?" + }, + { + "prediction": "Align the parameters of a method call if they span more than one line.", + "reference": "A repository has many badges so we should also add type column in scope." + }, + { + "prediction": "I think this should be `result.CodeFlows[0].Should().Equal(new[] { new AnnotatedCodeLocation {`", + "reference": "Now a hash set, so can't index into it." + }, + { + "prediction": "I think this should be `!!ENV['PSModulePath']` instead of `!!ENV['PSYTHON_MODULE_PATH']`", + "reference": "@jpogran Does this seem like a reasonable way to know if we're in powershell vs. CMD or *sh?" + }, + { + "prediction": "I don't think this is the right fix. The problem is that `contentType` can be `null` in this case.", + "reference": "1.toLowerCase(Locale.US)? 2.where is accept bug fix?" + }, + { + "prediction": "I think this should be `KeyError` instead of `SystemExit`", + "reference": "We should still be providing something to the user in the case of a `KeyError` instead of a stack trace!?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `MarketplaceContractResolver` class.", + "reference": "check Lukasz's fix with NonceReserving - is that not better?" + }, + { + "prediction": "I think this should be `this.colour_ = colour;` instead of `this.colour_ = colour || this.colour_;`", + "reference": "Would you explain why here please? E.g. from the PR description > the renderer expects to be able to use the secondary color as the fill for a shadow." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in the `hd.lock.RLock()` and `hd.lock.RUnlock()` calls below.", + "reference": "Lock needs to go to `RecoverFromDb` instead. Here it may cause deadlocks. My convention was that un-exported functions do not lock, only exported ones (with name starting with a capital letter)" + }, + { + "prediction": "I think this should be `public String[] getDomains(String... domains)` and not `public String[] getDomains(String domain)`", + "reference": "German keyboard would also be used in Austria and Switzerland, so this should have included `.at` and `.ch`." + }, + { + "prediction": "I'm not sure why we're removing these. I think they're still useful. I'm not sure why we're removing them. I think they're still useful. I'm not sure why we're removing them. I'm not sure why we're removing them. I'm not sure why we're removing them. I'm not sure why we're removing them. I'm not sure why we're removing them. I'm not sure why we're removing them. I'm not sure why we're removing them. I'm not sure why we're removing them. I'm not sure why we're removing them. I'm not sure why we're removing them. I'm not sure why we're removing them. I'm not sure why we're removing them. I'm not sure why we're removing them. I'm not sure why we're removing them. I'm not sure why we're removing them. I'm not sure why we're removing them. I'm not sure why we're removing them. I'm not sure why we're removing them. I'm not sure why we're removing them. I'm not sure why we're removing them. I'm not sure why we're removing them. I'm not sure why we're removing them. I'm", + "reference": "since this makes the indexer thing really only used for a single table, now, you can put in a TODO for me to cleanup and simplify this" + }, + { + "prediction": "I think this should be named `NSCD_SOCKET_VOLUME_MOUNT_PATH` instead of `NSCD_SOCKET_VOLUME_NAME`", + "reference": "Should we have this path passed from the Azkaban properties? If this is the standard path for nscd even outside LinkedIn, then we can keep it." + }, + { + "prediction": "I'm not sure if this is the best way to do this. I think we should be able to just do `cfg.StreamConfig.AllowNoSubject = mqttStreamName != \"\"`", + "reference": "Could be a non-public field. `allowNoSubject`" + }, + { + "prediction": "I think it would be better to have a `ForceRebuild` flag here, so that we don't have to keep track of the `ForceRerun` flag and the `ForceRebuild` flag at the same time. I think it would be better to have a `ForceRebuild` flag and a `ForceRerun` flag, so that we don't have to keep track of the `ForceRerun` flag and the `ForceRebuild` flag at the same time. I think it would be better to have a `ForceRebuild` flag and a `ForceRerun` flag, so that we don't have to keep track of the `ForceRerun` flag and the `ForceRebuild` flag at the same time. I think it would be better to have a `ForceRebuild` flag and a `ForceRerun` flag, so that we don't have to keep track of the `ForceRerun` flag and the `ForceRebuild` flag at the same time. I think it would be better to have a `ForceRebuild` flag and a `ForceRerun` flag, so that we don't have to keep track of the `ForceRer", + "reference": "Don't think this is quite right - think the build one also needs an `IsOriginalTarget` (c.f. code in `src/build`)" + }, + { + "prediction": "I think this should be `array('results' => $this->processResults($paginator->getCurrentPageResults(), $targetEntityConfig));` and not `return array('results' => $this->processResults($paginator->getCurrentPageResults(), $targetEntityConfig));`", + "reference": "what about adding typehints instead? I don't think we need to add docblocks for every private methods." + }, + { + "prediction": "I think we need to add `-o` for `cStorVolumeReplica.Spec.VolumeType == \"pd-shard\"` and `cStorVolumeReplica.Spec.VolumeType == \"pd-shard-shard\"`", + "reference": "Is it fine to pass the \"-o compression=on\" in the middle instead of at the end ?" + }, + { + "prediction": "I'm not sure this is the best way to do this. I'm not sure we want to mix in `load_config` into the `Bolt::Analytics::NoopClient` class. I'm not sure we want to mix in `load_config` into the `Bolt::Analytics::BundledContent` class. I'm not sure we want to mix in `load_config` into the `Bolt::BundledContent` class. I'm not sure we want to mix in `load_config` into the `Bolt::BundledContent` class. I'm not sure we want to mix in `load_config` into the `Bolt::BundledContent` class. I'm not sure we want to mix in `load_config` into the `Bolt::BundledContent` class. I'm not sure we want to mix in `load_config` into the `Bolt::BundledContent` class. I'm not sure we want to mix in `load_config` into the `Bolt::BundledContent` class. I'm not sure we want to mix in `load_config` into the `Bolt::BundledContent` class. I'm not sure we want", + "reference": "Probably make them all keyword arguments." + }, + { + "prediction": "I think this is the only place where `backdrop.setBackdrops([item])` is used. I think it should be removed.", + "reference": "Why not just check the backdrop setting here as well for the time being? We can combine the code later but at least then it would be configurable if people like the backgrounds." + }, + { + "prediction": "I think this should be `Warning` instead of `Info`", + "reference": "why are we turning this one into a Warning?" + }, + { + "prediction": "I think this should be `String.valueOf(sourceIDs.size() + 1)`", + "reference": "Wouldn't it be better to use double quotes for the opening parenthesis ?" + }, + { + "prediction": "`blessings` is a `uint32_t` so this should be `static_cast(player->blessings);`", + "reference": "Remove the cast" + }, + { + "prediction": "I'm not sure if we want to include this file in the release?", + "reference": "What criteria do we use to bump the copyright years? An update to the module?" + }, + { + "prediction": "I don't think this is the right place to do this. I think it should be in the `transforms.py` file, under the `Resize` class. The reason is that the `Resize` class is the base class for all image transforms, so it should have access to all the transforms defined in the `transforms.py` file. For example, it should have access to the `ResizeWithDilations` class defined in the `transforms.py` file.", + "reference": "should we rm line 269?" + }, + { + "prediction": "I think this should be `setattr(self, \"_isNvdaStartupComplete\", True)` instead of `setattr(self, \"_isNvdaStartupComplete\", lambda: setattr(self, \"_isNvdaStartupComplete\", True))`", + "reference": "Perhaps the code at `source/core.py:564: postNvdaStartup.notify()` should be queued instead? If we are saying the loop must have started before NVDA's startup is complete, then the `postNvdaStartup` action is incorrect." + }, + { + "prediction": "Layout/AlignHash: Align the elements of a hash literal if they span more than one line.", + "reference": "Needed this for testing locally with mail view but not used for any tests. Might be nice to have some seed scripts at some point." + }, + { + "prediction": "I'm not sure if this is the best way to handle the case where we don't have an `AcceptResponseError` in the response header.", + "reference": "wait, if we only do this for successful status codes won't we miss a whole slew of responses? We should be checking this for all codes right?" + }, + { + "prediction": "I think this should be `new String[] { \"library.yaml\" }` instead of `new String[] {\"library.yaml\"}`", + "reference": "Adding in the service yaml `library.yaml` here." + }, + { + "prediction": "I don't think this is the right way to do it. The problem is that the `RemoteUserCtxKey` is a key, not a value.", + "reference": "Why is this dereference needed?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `pkg/repo`.", + "reference": "Might want to add that this only happens if you have write permissions to the folder." + }, + { + "prediction": "I think it would be better to make this a `bool` and set it to `true` by default.", + "reference": "Adding a small blurb about why someone would want to enable this flag would help clarify what it is for. Such as something about when providing a custom retry handler and how`ShouldRetry` will be handled with and without the flag enabled." + }, + { + "prediction": "I'm not sure about this change. I think we should keep the old format for backwards compatibility.", + "reference": "assume the user will be able to register for a custom service name in future?" + }, + { + "prediction": "This file should be renamed to `GraphUtilities.cs`", + "reference": "The extra two empty lines seem unnecessary. Please review your diffs more carefully." + }, + { + "prediction": "I think we should rename this to `EthAPI` instead of `OracleAPI` to be consistent with the naming of the other API interfaces.", + "reference": "What the reason to embed the Oracle?" + }, + { + "prediction": "I'm not sure if this is the best place to put this route. I think it should be under `workshops`, since it's related to the `Workshop` controller. But I don't know if it's better to put it under `pages`, since it's related to the `Pages` controller. Can you help me decide?", + "reference": "Shouldn't this happen automatically with High Voltage?" + }, + { + "prediction": "I think this should be `entityValue = context.getNamer().varReference(Name.from(initValue.getValue()));`", + "reference": "This is changed because we need `projectId` to be printed as `$projectId` in PHP." + }, + { + "prediction": "I think this should be `customization_of` instead of `customization_of_template`", + "reference": "This title change seems more accurate to me however not sure if this will confuse users." + }, + { + "prediction": "I think this should be `^(?:.*:)*wikipedia$` and not `if key =~ /^(?:.*:)*wikipedia$```", + "reference": "Here (and on line 158 as well), would it be more efficient to use the String end_with() method? Not tested" + }, + { + "prediction": "I think this should be `ram_handler = RAMHandler(capacity=capacity)` instead of `ram_handler = RAMHandler(capacity=self.capacity)`", + "reference": "Why are you creating a new (second) `RAMHandler` here? Is this just an oversight from deleting the previous code?" + }, + { + "prediction": "I think this should be `resp_.set_code(req.get_if_not_exists() ? cpp2::ErrorCode::SUCCEEDED : cpp2::ErrorCode::E_EXISTED);`", + "reference": "Move the line 27 to line 31 is better?" + }, + { + "prediction": "I think this should be `fbo.rekeyFSM.Event(NewRekeyEvent(rmd.IsRekeySet()))` instead of `fbo.rekeyFSM.Event(NewRekeyNotNeededEvent())`", + "reference": "In slack I mentioned we should only do this if the update is from some other device, to make sure our own updates don't cause issues. Maybe the revision check above is good enough to prevent this, but I just want to make sure you thought about it." + }, + { + "prediction": "I think this should be `--seed 1234` and not `--seed 123456789`", + "reference": "I would instead explain that random is the default, but you can switch back to defined, or another ordering scheme." + }, + { + "prediction": "I think this should be `<= 1` instead of `<= 0`", + "reference": "Is there a reason you left this at 0?" + }, + { + "prediction": "I'm not sure if this is the right place to do this. I think it should be done in the `AbstractRememberMeServices` constructor.", + "reference": "The value of `key` will never be `null` at this point, because `getKey()` will generate a value if it is `null`." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I could come up with at the time of writing.", + "reference": "NIT: You should first check if AdoNetExcludedTypes.Count is greater than 0 before calling Contains (fast-path)" + }, + { + "prediction": "Can you remove this empty line?", + "reference": "should rearrange so as to follow import ordering." + }, + { + "prediction": "Why is this change needed?", + "reference": "what is the use case for create workflow with completed state?" + }, + { + "prediction": "This file should be renamed to `RemoteDistributorTest.java`", + "reference": "Probably best not to have an empty test...." + }, + { + "prediction": "I'm not sure this is the right place to push the region.", + "reference": "Missing the license" + }, + { + "prediction": "I think it would be better to use `p.logger.Errorw` instead of `p.logger.Error` to be consistent with the rest of the code.", + "reference": "Looks like this was previously guarded by `EnableCleanupReplicationTask` flag. Now looks like this is always needed. Just want to confirm the intention is if `GlobalNamespace` is enabled then we want run cleanupReplicationTasks in all cases?" + }, + { + "prediction": "This is not needed anymore.", + "reference": "Potentially it'll be good to remove all of them excluding \"tbb/tbb.h\" But let's do it next time" + }, + { + "prediction": "I don't think this is the right place for this function. It's not about finding the range, it's about determining if the range is large enough to be considered bounded by the data.", + "reference": "I would just mention which tolerance - namely as reported by ``sys.float_info``" + }, + { + "prediction": "Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.", + "reference": ":+1: Ideally this'll become something you could pass in to the config" + }, + { + "prediction": "I'm not sure this is the right way to do it. I think we need to pass the executor to `RaftIterator` and then call `RaftIterator::replicateLogs` instead of `RaftPart::replicateLogs`.", + "reference": "Should using `thenValue` to replace `then` ?" + }, + { + "prediction": "I'm not sure this is the best way to do this. I think we should be able to get the context from the `TraceContext` in the `OnError` event handler.", + "reference": "This follows the convention of each callback starting with the `IsIntegrationEnabled` check." + }, + { + "prediction": "I'm not sure if this is the right place for these properties. I think they should be in the `Meter` class.", + "reference": "this is not required to be part of this PR right? (With UpDownCounter being absent in .NET, we can make this hardcoded for now, i think)" + }, + { + "prediction": "I'm not sure if this is the right place for this interface. I think it would be better to move it to `KestrelTransportHandler` or `TransportHandler` interface.", + "reference": "Add the PipeFactory here" + }, + { + "prediction": "I think this is the wrong place to put this. It should be in `common.ChaosImpl`, not in `Delegate`.", + "reference": "please add `var _ impltypes.ChaosImpl = (*Delegate)(nil)`" + }, + { + "prediction": "I don't think this is the right place to put this. I think it should go in the `Snapshot` interface.", + "reference": "nit: is this added deliberately?" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Given the number of tests which need this (I think I counted seven) should we maybe just install this one globally? Is there even a place to do that? Something in `test_helper` maybe?" + }, + { + "prediction": "I think we can remove this function and use `typeof maybePromise.then === 'function'` directly.", + "reference": "we don't use this anymore, so we can delete it." + }, + { + "prediction": "I think this should be `fmt.Fprintln(os.Stdout, \"algoh telemetry configured from file:\", telemetryConfig.FilePath)`", + "reference": "nit: change to \"Telemetry configuration loaded from '%s'\"" + }, + { + "prediction": "896da21682d925964ece3a0601024704010402040304\")\n \tif err := assert.Equal(t, expected, expected); err != nil {\n \t\tt.Errorf(\"Expected: %v, Got: %v\", expected, err)\n \t}\n```\nReview comment?", + "reference": "Why did this value change?" + }, + { + "prediction": "I think we can remove `gcpduckv1alpha1` now that we have `gcp.pubsub.v1alpha1`", + "reference": "maybe `duckpubsubv1alpha1` ?" + }, + { + "prediction": "I'm not sure this is the right place for this function. It seems like it should be in `extensions/manifest.json`, but I don't see it being used there.", + "reference": "The id is not mandatory for web extensions. Could you update this to support a web extension without an id?" + }, + { + "prediction": "I think this should be `serviceName = \"pubsub.googleapis.com\"`", + "reference": "I actually prefer them to be defined here. Client who calls `lib` should define the args, not `lib` itself." + }, + { + "prediction": "I think this should be done in `epollConsole.Close()`", + "reference": "I think this should've been done with the `defer`-named-return trick. I'll submit a PR for it." + }, + { + "prediction": "I think it would be better to use `boost::asio::ip::tcp::socket` instead of `nlohmann::tcp::Endpoint`.", + "reference": "The bind address should be configurable." + }, + { + "prediction": "This method is not used anywhere, so I think it can be removed.", + "reference": "Maybe the empty `delete()` should be implemented as default in the interface." + }, + { + "prediction": "Please use `CMAKE_CURRENT_LIST_DIR` instead of `CMAKE_SOURCE_DIR`.", + "reference": "How to ensure CMAKE_SOURCE_DIR is set correctly?" + }, + { + "prediction": "I'm not sure this is the right way to do it. I think we need to make sure that the `Balance` and `VotingWeight` are both set to `0` before we create the account state.", + "reference": "safer to make a copy of incoming *big.Int" + }, + { + "prediction": "I think we should use `pullImageTimeout` instead of `ListImagesTimeout`", + "reference": "how did we choose this value? does this hold good for Windows too?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `libcontainer/storage` or `libcontainer/network` or `libcontainer/image` or `libcontainer/registry` or `libcontainer/network` or `libcontainer/storage` or `libcontainer/image` or `libcontainer/registry` or `libcontainer/network` or `libcontainer/storage` or `libcontainer/image` or `libcontainer/registry` or `libcontainer/network` or `libcontainer/storage` or `libcontainer/image` or `libcontainer/registry` or `libcontainer/network` or `libcontainer/storage` or `libcontainer/image` or `libcontainer/registry` or `libcontainer/network` or `libcontainer/storage` or `libcontainer/image` or `libcontainer/registry` or `libcontainer/network` or `libcontainer/storage` or `libcontainer/image` or `libcontainer/registry` or `libcontainer/network` or `libcontainer/storage` or `libcontainer/image` or `libcontainer/registry` or `libcontainer/network` or `libcontainer/storage` or `libcontainer/image` or `libcontainer/registry` or `libcontainer/network` or `libcontainer/storage` or `", + "reference": "To follow the other build tags, maybe we can call it `criu`?" + }, + { + "prediction": "I think this should be `timeout` instead of `connect_timeout` to be consistent with the rest of the gem.", + "reference": "Should we load this from the config file too?" + }, + { + "prediction": "I'm not sure if this is the best way to do it.", + "reference": "Can you file an issue for this?" + }, + { + "prediction": "I think we can remove the `this[kIsMaster] == null` check here.", + "reference": "@nbbeeken what were the cases where `!!this[kIsMaster]` was yielding an incorrect value? we should try to cover them in the tests" + }, + { + "prediction": "I'm not sure this is the right place for this method. It seems like it should be in the `Bolt::Inventory` class, not the `Bolt::Catalog` class. The `setup_inventory` method is only called in the `Bolt::Catalog` class, and it seems like it should be moved to the `Bolt::Inventory` class as well. Can you move this method to the `Bolt::Inventory` class?", + "reference": "This whole function feels messy. I don't have a better idea at the moment though." + }, + { + "prediction": "I think you can remove the `typeMap.get(\"airplaneMode\").toString()` line as well.", + "reference": "should use Number instead of Long" + }, + { + "prediction": "I think this should be `func (m MockProvider) WriterForFn(ctx context.Context, conf influxdb.Config) (influxdb.Writer, error)`", + "reference": "Can you rename this and the file `InfluxDBProvider` and `influxdb_provider.go` respectively?" + }, + { + "prediction": "I think this should be `!== 0`", + "reference": "This is the real culprit, as now vlen will always be a Number (and known to the compiler as such). You could probably go one step further and avoid the ToBoolean on `vchildren` as well by writing something like `vlen = (vchildren !== undefined) ? vchildren.length : 0` if that matches the contract." + }, + { + "prediction": "I think you can remove the `txtNoDataString` view here.", + "reference": "missing space before `TextView`" + }, + { + "prediction": "This should be `break;` instead of `return`.", + "reference": "so this attribute is used as u8 in code, but saves as int32? Why?" + }, + { + "prediction": "I don't think we need to change this, but I think it would be good to keep the old name for backwards compatibility.", + "reference": "can RDSE be added to the list? It has its capnp files." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in `client` since it's the client that's going to be making the API calls.", + "reference": "These functions only ever read from the API and should always be reading from a cache, so I have made that explicit by expecting a Reader here and supplying a `cache.Cache` as the client." + }, + { + "prediction": "I'm not sure what this is supposed to accomplish, but it seems like it should be removed.", + "reference": "No, we can't skip any of the mangling after the suspend point: this should follow the other mangling and undo its push." + }, + { + "prediction": "I don't think this is needed.", + "reference": "this is generated code.. these changes will need to be made in the code generator to have them stick." + }, + { + "prediction": "I'm not sure this is the best way to test shadow support, but I don't have a better idea.", + "reference": "Should we abstract this into a reusable utility so it doesn't have to get repeated in every test file needing Shadow DOM support?" + }, + { + "prediction": "nit: can you move this to the top of the file?", + "reference": "Maybe we rename this to `command_monitoring.test.js` to match the directory name change? Or would you rather do that as part of the greater test cleanup? I'm fine either way." + }, + { + "prediction": "I'm not sure if this is the right way to fix it, but it's the only way I could get it to work.", + "reference": "Why is this change necessary? `handleSingle()` will cast it to a string, no?" + }, + { + "prediction": "I think this should be `default String name() { return \"table(\" + hashCode() + \")\"; }`", + "reference": "This newly added method should be well defined, should it return `TableIdentifier` or just `String`?" + }, + { + "prediction": "Shouldn't this be \"Multimedia has %count% relations with %relations%\"?", + "reference": "have a relation with a product" + }, + { + "prediction": "I'm not sure if this is the right thing to do. I think we need to make sure that the pod is actually gone before we try to delete it. If the pod is still there, then we should not be able to delete it. If the pod is not there, then we should be able to delete it.", + "reference": "I guess that there is still a window here, because the GC could happen between the `PodExist` and `Delete` calls. Would it be better instead to check `err` and allow it if it says \"pod has already been deleted\"?" + }, + { + "prediction": "I'm not sure this is the best way to do this. I think we should be using `transaction.commit()` and `transaction.rollback()` instead of `session.commit()` and `session.rollback()`. This is because `transaction.commit()` and `transaction.rollback()` should be called in a transaction, and `transaction.commit()` and `transaction.rollback()` should only be called if the transaction is in a consistent state (i.e. all operations have completed and no errors have occurred). If we call `transaction.commit()` and `transaction.rollback()` here, it means that if there was an error while committing or rolling back the transaction, then the entire transaction will be rolled back, which may not be what we want.", + "reference": "SQLAlchemy's session management does magic to make sure that if the rollback fails you still get the original exception that caused the rollback. Also it looks nicer." + }, + { + "prediction": "Why do we need to convert from actionPb to transferPb?", + "reference": "This switch statement can be removed. Just return q.items[act.Nonce] != nil" + }, + { + "prediction": "nit: I think you can simplify this to `n.equals(n.getParent().getChild(1))`", + "reference": "I think `==` for nodes is more readable than equals. An equals calls looks like it could be recursing, because intuitively two nodes are equal if their subtree are the equal. But everywhere you replaced, we don't want to test whether the subtrees are structurally equal, we want to know whether they're the same. Only `==` captures this intent, using equals obscures this. Not to mention that equals may NPE and is in that sense less ergonomic. I think we should enhance the rule with a list of types for which `==` is correct. Edit: in the meantime i think we could suppress those new violations..." + }, + { + "prediction": "This should be renamed to `BenchmarkFilters` or something similar.", + "reference": "What's the scenario for passing multiple filters?" + }, + { + "prediction": "I think this should be `iter->logEntry()` instead of `std::get<3>(logEntry)`", + "reference": "move to after check log.empty()" + }, + { + "prediction": "I don't think we should be using `docutils` for this. We should be using `jinja2` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils` or `jinja2_docutils`", + "reference": "This line needs to be removed" + }, + { + "prediction": "I'm not sure this is the right name for this. I think it should be something like `cloud.build.source.buildId` or `cloud.build.source.buildStatus`?", + "reference": "Can we delete such const like `CloudBuildSourceEvent` and `CloudBuildSourceBuildId` since all those are contained under schemas/v1?" + }, + { + "prediction": "Is this package used anywhere? I don't see it referenced anywhere in this PR.", + "reference": "This is unused." + }, + { + "prediction": "I think this should be `ITextFormatBaggage` instead of `ITextFormat`", + "reference": "Any reason not to put `using System.Collections.Generic` (guess there shouldn't be naming conflicts)?" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the easiest I could come up with at the time of writing.", + "reference": "Could the name of this controller just be shortened to `TwitterCardsController`? Is the `Player` there adding information?" + }, + { + "prediction": "I'm not sure if this is the best way to check if the host is healthy. I'm not sure if we should be checking if the host is healthy or if we should be checking if the upstream is healthy. If we should be checking if the upstream is healthy, I'm not sure if we should be checking if the host is healthy or if we should be checking if the upstream is healthy. I'm not sure if we should be checking if the host is healthy or if we should be checking if the upstream is healthy. I'm not sure if we should be checking if the host is healthy or if we should be checking if the upstream is healthy. I'm not sure if we should be checking if the host is healthy or if we should be checking if the upstream is healthy. I'm not sure if we should be checking if the host is healthy or if we should be checking if the upstream is healthy. I'm not sure if we should be checking if the host is healthy or if we should be checking if the upstream is healthy. I'm not sure if we should be checking if the host is healthy or if we should be checking if the upstream is healthy. I'm not sure if we should be checking if the host is healthy or if we should be", + "reference": "Backends with hostnames that depend on the request are always up?" + }, + { + "prediction": "I don't think we should be using `pyramid_exceptions` here. I think we should be using `jsonpatch` and `jsonpointer` from `pytz`.", + "reference": "I'd rather catch those to `utils.py` and raise a simple ValueError from them. From the resource point of view, these are details of implementation" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "make this 1.0 ? I don't think all that many people do `language: julia` without any `julia:` specifiers, but may as well keep that possible?" + }, + { + "prediction": "I think we can remove this line.", + "reference": "nit: `AZURE_KEYVAULT_AUTH_VIA_CLI` is defined by us, so it might be helpful to differentiate it from azure's env names. Maybe starts with `GOCDK`." + }, + { + "prediction": "I think we should use `storage.SessionStorage` instead of `storage.Storage` here.", + "reference": "Depend on interfaces not on structures" + }, + { + "prediction": "I'm not sure about this change. The `stop()` function is called by the `StorageServerThread` and the `notifyStop()` function is called by the `StorageServerThread` and the `stop()` function. I think it would be better to call `stop()` in `StorageServerThread::stop()` and `notifyStop()` in `StorageServerThread::notifyStop()`.", + "reference": "This fix looks good. My concern, don't forget to fix metad too!" + }, + { + "prediction": "I'm not sure this is the right way to do it. I'm not sure we should be relying on the fact that the latest branch is a squash branch to know that we should use the earliest branch as the journal branch ID. I'm not sure we should be relying on the fact that the earliest branch is a local branch to know that we should use the latest branch as the journal branch ID. I'm not sure we should be relying on the fact that the latest branch is a squash branch to know that we should use the earliest branch as the journal branch ID. I'm not sure we should be relying on the fact that the earliest branch is a local branch to know that we should use the latest branch as the journal branch ID. I'm not sure we should be relying on the fact that the latest branch is a squash branch to know that we should use the earliest branch as the journal branch ID. I'm not sure we should be relying on the fact that the earliest branch is a local branch to know that we should use the latest branch as the journal branch ID. I'm not sure we should be relying on the fact that the latest branch is a squash branch to know that we should use the earliest branch as the journal branch ID. I'm not sure we", + "reference": "Just noticed this nil context. Perhaps plumb through ctx too, or change to `Debug`?" + }, + { + "prediction": "I'm not sure this is the best way to do this. I think we should be able to do something like: DEFAULT_HEADERS = {'Accept' => 'application/x-www-form-urlencoded', 'Content-Type' => 'application/x-www-form-urlencoded', 'User-Agent' => 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0 Safari/605.1.15', 'Accept-Language' => 'en-US,en-US;q=0.8,en;q=0.5', 'Accept-Encoding' => 'gzip, deflate', 'Connection' => 'keep-alive', 'Accept-Charset' => 'ISO-8859-1,utf-8', 'Keep-Alive' => 100, 'Strict-Transport-Security' => 'max-age=3111111111111111111111111111111111111111111111111111111111111", + "reference": "Does it send requests with urlencoded bodies anywhere? I thought it sends only json. Maybe content-type should be `application/json` by default?" + }, + { + "prediction": "I think this should be 11810.", + "reference": "Again use of `constexpr` is recomended." + }, + { + "prediction": "I don't think it's necessary to import LayoutAlgorithm as ds_layout = None here, since it's not used in this function.", + "reference": "Minor point but I would call this ``redim_graph`` instead." + }, + { + "prediction": "I think we can remove `apis/cluster/v1alpha2` and `apis/infrastructure/v1alpha2` from `apis/cluster/v1` and `apis/infrastructure/v1`", + "reference": "As I was trying to figure out how the error messages are written out, since they are returned from `getOrCreate` and `reconcile`, it looks like we are using plain `klog` to write them out instead of using the logger from the scope above" + }, + { + "prediction": "I think this should be `log.Warnf` instead of `log.Warnn`", + "reference": "Now it's double logging, is not it? Because `service.ipForward.Enable()` logs extra `warning`" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Whatever the decision is about the request type to use, this should only match what is needed and not the other one." + }, + { + "prediction": "I'm not sure if this is the right place to do this, but it seems like it should be.", + "reference": "...and in turn, this should probably be var updatePreviews = true; if (!(localConnection && localConnection.type == Blockly.OUTPUT_VALUE) && (Blockly.localConnection_ && Blockly.highlightedConnection_)) { since the first clause is a no-op. If you want to leave it this way for clarity, that's fine too." + }, + { + "prediction": "I think we should rename this method to `find_violations` as well.", + "reference": "Please remove this TODO, since they will not apply anymore after you are done. :) Can you please remove this everywhere else in this PR?" + }, + { + "prediction": "I don't think this is a valid test. `enum` and `enum clashes with datatype`. `enum` and `enum` and `enum clashes with datatype`. `enum` and `enum` and `enum` and `enum clashes with datatype`. `enum` and `enum` and `enum` and `enum` and `enum clashes with datatype`. `enum` and `enum` and `enum` and `enum` and `enum` and `enum clashes with datatype`. `enum` and `enum` and `enum` and `enum` and `enum` and `enum` and `enum clashes with datatype`. `enum` and `enum` and `enum` and `enum` and `enum` and `enum` and `enum` and `enum clashes with datatype`. `enum` and `enum` and `enum` and `enum` and `enum` and `enum` and `enum` and `enum` and `enum clashes with datatype`. `enum` and `enum` and `enum` and `enum` and `enum` and `enum` and `enum` and `enum` and `enum` and `enum clashes with datatype`. `enum` and `enum` and `enum` and", + "reference": "This seems like an incomplete schema definition. will that have any effect on the tests?" + }, + { + "prediction": "why do you need this check?", + "reference": "The testing cases are failing because `SetHeader` does not only handle cases where input are from files. It also reads categorical feature indices from the config parameters (see the part outside the `if (filename != nullptr) { ... }`). Skipping `SetHeader` directly here will cause errors when we load data from numpy or pandas arrays (where `filename == nullptr`) and use categorical features. So I think we should move the the check `filename != nullptr && CheckCanLoadFromBin(filename) == \"\"` into `SetHeader`. That is, we change `if (filename != nullptr) { ... }` into `if (filename != nullptr && CheckCanLoadFromBin(filename) == \"\") { ... }`" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in the `cmd.Wait()` method, since that is the place where the process is started.", + "reference": "I think we should change the variable name of `err` in `if err, ok := err.(*exec.ExitError); ok `, this re-assignment of `err` still affects the next `else` branch" + }, + { + "prediction": "nit: I think it would be nice to have a `folly::Future> MetaClient::dropSpace(std::string const& name)` method that does the same thing as the `folly::Future> MetaClient::dropSpace(std::string name)` method above.", + "reference": "`Status` has identical semantics with `StatusOr`." + }, + { + "prediction": "I think this should be `\"/readyz/addlabels\"`.", + "reference": "why is this named in a different style from other paths?" + }, + { + "prediction": "I'm not sure if this is the right place to do this check. I think it should be done in the `Cluster` controller, but I'm not sure if that's the right place to do it.", + "reference": "Swapped these to ensure that we aren't passing a nil cluster in to util.IsPaused" + }, + { + "prediction": "I think it would be better to use a map[string]platformPkgManagerTuple instead of a list of tuples.", + "reference": "I don't see pkgManager used anywhere, is there a reason we need this?" + }, + { + "prediction": "Shouldn't this be `instanceDir.toPath()`?", + "reference": "A bit late, but I don't think this is necessary, as all callers will send absolute paths. And if you ever get a relative path, resolving it with `toAbsolutePath()` leads to it being relative to whatever CWD the app is started with, while the typical resolving of relative `instanceDir` is to resolve it relative to CoreContainer#coreRootDirectory." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `modelSchema.paths[localField]`", + "reference": "There's an awful lot of test failures here because `localFieldPathType.schema` may not contain a `getters` array." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Mysql allows for `||` concatenation (e.g. `firstname||' '||surname`) if you enable it: `set sql_mode=PIPES_AS_CONCAT;`. I think this check is safer though" + }, + { + "prediction": "I think this file should be renamed to `ens.go`", + "reference": "NOTE: this is the default ENS registry address. If the ENS suite is deployed from the current builds to any chain, it will always be found at this address." + }, + { + "prediction": "Layout/AlignParameters: Align the parameters of a method call if they span more than one line.", + "reference": "I'm curious why you are using `draw` in this route file?" + }, + { + "prediction": "I don't think we need to panic here.", + "reference": "Those variables are only been used once, I think we don't need to create them at all, just pass values to the `GetRawDiff` directly." + }, + { + "prediction": "Why is this change needed?", + "reference": "I like the idea of replacing all the `#if NET461` with `#if NETFRAMEWORK`... is that worth doing now? Means fewer changes if we go to 4.7.2 at some point" + }, + { + "prediction": "I think this should be `clutchProviderName` instead of `clutchProvider`", + "reference": "to fix the docs build failure, make this const var named without the suffix `Name`" + }, + { + "prediction": "I'm not sure this is the right place to move the fallthrough. I think it should be moved to the top of the function where it's first used.", + "reference": "This bugfix also included, in case a subjectAlternativeName was present in the cert, then URIs (e.g SVID SPIFFE auth) would not have been attempted." + }, + { + "prediction": "I don't think we need this interface. We can just use `Uri.fromFile(file)`", + "reference": "Same here. Feels like the wrong location." + }, + { + "prediction": "I don't think this should be in this PR.", + "reference": "Please make `_path_suggestion` public (i.e. remove the `_`) in `downloads.py`." + }, + { + "prediction": "I think this should be `external-port-443-is-local-port` instead of `external-port-80-is-local-port`", + "reference": "Woah, these flag names gotta get shorter. (Edit: I'll try to suggest some if needed, will think on it.)" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Is this the code that's supposed to use the Rails app's only when in Rails4? What's the point of the first `if app.respond_to?(:secrets)`, both the `if` and the `elsif` have the same body, is only the second one needed? If `app.config` has a `secret_key_base`, then use it, the end. Is there a need for first checking if `app.respond_to?(:secrets)`?" + }, + { + "prediction": "I think this should be `enum_decl->isObjC() || (enum_decl->isObjCProxy() && !m_is_objc_enum);`", + "reference": "Does this not apply to C enums on Linux?" + }, + { + "prediction": "I'm not sure this is the right place for this check. I think it should be in the `if (isRetryableWriteError(err)) {` block.", + "reference": "Should this check if the error is `RetryableWriteError` before adding the label?" + }, + { + "prediction": "I'm not sure why we need to import `get-form-data` from `rollup-plugin-commonjs` here. Can't we just import it from `get-form-data` in `rollup-plugin-commonjs`?", + "reference": "Oh wow, that's one complicated require :)" + }, + { + "prediction": "I'm not sure if this is the right place to put this snippet. It's in the `aws-sdk-go` package, which is the Go SDK for AWS, but the snippet is about using `context.Context` with SDK requests, which is the Go SDK for Golang. Should it be in `aws-sdk-golang` or `aws-sdk-go`?", + "reference": "do you mean how to \"use\"" + }, + { + "prediction": "I'm not sure this is the right place to put this test. I think it should go in `test/utils.js` since it's only testing a specific case.", + "reference": "We can't really test this anymore since ref and props.ref are at the backing node level now" + }, + { + "prediction": "I don't think this is necessary. The iterator is initialized in the constructor.", + "reference": "Did you intend to set this in the constructor?" + }, + { + "prediction": "I think this should be `err = s.defaultAMILookup(\"ubuntu\", \"18.04\", machine.Machine.Spec.Versions.Kubelet)`", + "reference": "This looks fine as a first approach, and can we put a TODO here about ubuntu 18.04 being hardcoded?" + }, + { + "prediction": "I think this should be `#if defined(USE_OPENCV) && !defined(OPENCV_NO_DEPRECATED_6_0)`", + "reference": "This isn't strictly needed since lmdb / leveldb data that is unencoded does not require OpenCV IO. I think `DataLayer` should only require lmdb / leveldb. If one tries to use encoded data without OpenCV the `DataTransformer` guards will report the dependency failure." + }, + { + "prediction": "I think this should be `hLog.WithError(err).Errorf(\"unable to apply hiveapi cluster role binding: %s\", err.Error())`", + "reference": "Should we take out this change? This was only in there to try to brute force the start of the apiserver yesterday." + }, + { + "prediction": "I'm not sure about this change. I think it's fine, but I don't have a strong opinion. I just wanted to make sure I'm doing the right thing.", + "reference": "I worry that this association name is a bit confusing. Yoz was asking me about the concept of completion yesterday, which is why I think of it. It wasn't clear to him exactly what it was. what about calling this a `step_completer` ? we know that a proposal has many steps, so I think that might be clearer. in the future, we also might want the rename the `approver` relation because a step is not always an approval these days." + }, + { + "prediction": "I think we can remove the `ApiVersion` field from the `OperationParametersValidation` class.", + "reference": "Just add a to-do saying we need to add api-version in the check some time in the future when we enable the single-swagger spec mode for validation." + }, + { + "prediction": "I think this should be `Propel\\ConnectionManager::DEFAULT_DATOSRC`", + "reference": "@lunika Please see this. It allows us to do `Propel::getConnection()` easily, as we have only one database." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do it in `AspNetWebApi2Integration.UpdateSpan` since that's the only place where we have access to the `AspNetTags` instance.", + "reference": "Not related to this particular cast but I wonder if we shouldn't have a cast helper that would log if null to gain visibility." + }, + { + "prediction": "I think this should be `nextPageToken` instead of `incompleteSearch`.", + "reference": "why do we need to explicitly declare these fields?" + }, + { + "prediction": "I think this should be done in the `AbstractOaiController` and not in this `OaiController`. The `AbstractOaiController` is the base class for all oai controllers.", + "reference": "Note that there are multiple OAI servers -- that's why `$serverClass` is a variable here. You'll want to fetch `$serverClass` from the service manager rather than a hard-coded value, and also set up a module.config.php for the authority record version, `VuFind\\OAI\\Server\\Auth`. Should be easy enough since it can share the same factory." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "This is no longer needed and should be removed." + }, + { + "prediction": "Why is this change needed?", + "reference": "could use named return params here to avoid declaring the opts, and using naked returns instead." + }, + { + "prediction": " \n > 2 << 5);\n+ ASSERT(off + 0x40000 < 0x80000);\n+ *pc_writable = (enc & 0xfff8001f) | (0x00ffffe0 & (off >> 2 << 5));\n } else if ((enc & 0x7e000000) == 0x36000000) { /* TBNZ, TBZ */\n- ASSERT(off + 0x2000 < 0x4000);\n- *pc_writable = (enc & 0xfff8001f) | (0x00ffffe0 & off >> 2 << 5);\n+ ASSERT(off + 0x40000 < 0x80000);\n+ *pc_writable = (enc & 0xfff8001f) | (0x00ffffe0 & (off >> 2 << 5));\n } else if ((enc & 0x7e00000", + "reference": "Wait -- where did this change come from? This seems unrelated to trace building and seems like it could affect basic execution, unlike the rest of this PR which is all under the off-by-default trace option. Please separate this into its own PR and probably ask @AssadHashmi to review." + }, + { + "prediction": "I think this file should be removed.", + "reference": "seems to be redundant (mention `docusaurus` )" + }, + { + "prediction": "I think we should rename this method to `cherryPick` instead of `cherrypick`.", + "reference": "Can we combine this with the Rollback API? We could still support the `rollback` method here, but combine `Rollback` and `CherryPick` into something like `ManageSnapshots`. Then we could reuse logic for enforcing checks of the current snapshot. What do you think?" + }, + { + "prediction": "I think this should be `const char*`", + "reference": "Maybe just `env_prefix`, I don't think this is referring to the WQ manager." + }, + { + "prediction": "I think this file should be removed as it is not used anymore.", + "reference": "Unrelated line change :)" + }, + { + "prediction": "I think we can remove this file.", + "reference": "I raised an eyebrow at making `net` depend on `k8s.io`, but it seems we're already doing that." + }, + { + "prediction": "I think this should be `if (countlyGlobal && countlyGlobal.company) {`", + "reference": "I think ticket meant, not applying replacement in this method, but rather applying encodeSomeHtml to each and every localization string" + }, + { + "prediction": "I'm not sure if this is the right place to do this check. I think it should be in the `catch` block of the `try/catch` below.", + "reference": "ticket for the 4.0 epic?" + }, + { + "prediction": "I think you can use `cfg.model.neck.pretrained = None` instead of `if cfg.model.neck.rfp_backbone.get('pretrained', False):`", + "reference": "`cfg.model.get('neck')` will return None if neck does not exist, thus we can omit the default value." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Trailing whitespace detected." + }, + { + "prediction": "I think this should be `CXXFLAGS`, not `CXXFLAGS`.", + "reference": "I don't see why a `cxxflags` key is necessary? C flags are important in the target file because they define things like the float ABI. But these flags are also used for C++. I can't think of a reason why you would want to configure C++ flags in a target file." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the same place as the other instrumentation code.", + "reference": "Update year range in Copyright notice, and elsewhere too." + }, + { + "prediction": "I don't think we need to expose the `SecretKeySelector` here.", + "reference": "Can we update this PR to not be a breaking change? i.e. if a user specifies `accessKeyID`, it is still used. But if a user specifies `accessKeyIDSecretRef`, it takes precedence?" + }, + { + "prediction": "I think this should be `nil` or `\"\"` instead of `1` or `0`.", + "reference": "You don't actually need both tests here as \"truthiness\" means that `\"0\"` is false and hence the first test will be true..." + }, + { + "prediction": "Do we need to wait for the page to load before clicking this link?", + "reference": "Everything else in here is using `I18n`. Should we do that here to be consistent?" + }, + { + "prediction": "/0:tcp:2379,0.0.0.0/0:tcp:2380,0.0.0.0/0:tcp:5473,0.0.0.0/0:tcp:6443,0.0.0.0/0:tcp:6666,0.0.0.0/0:tcp:6667;die-on-fail\"`\n }\n \n // Validate validates the config\n```\nReview comment?", + "reference": "What do you think about changing the ordering to be `::`? I think it matches the most with what we previously had so that it doesn't change too much for our users." + }, + { + "prediction": "I think this should be `static_cast(rootedAtAtom) < mol.getNumAtoms()`", + "reference": "I'm fairly sure this precondition is always true due to the mod (%)" + }, + { + "prediction": "I don't think we should be changing the semantics of the `noDups()` method here. If we do, we should do it in a way that doesn't change the semantics of the `noDups()` method. For example, we could change the semantics of the `noDups()` method so that it returns `false` if there are duplicates.", + "reference": "I love seeing diffs like this one, adding a `String` message to an otherwise cryptic `assert`! It makes me realize you must have had a hellacious debugging session!" + }, + { + "prediction": "I think this should be `if c.version == 0` instead of `if a config file does not have version, it is assumed to be zero. All fields listed in migrate() might be changed if an actual value matches to default value from a previous version.`", + "reference": "1. No logger exists to produce a message 2. Can't assume the latest version because missed version means 0." + }, + { + "prediction": "Shouldn't this be `sha1($this->hash . ':' . $this->level) . ':' . $this->hash` ?", + "reference": "I saw a wrong reuse of the cache between a partial analysis of a single file and a full run where errors due to lack of context on the first partial run was reported on the full run. Shouldn't we use a hash that is composer.lock + psalm.xml + command line to be safe?" + }, + { + "prediction": "I think this should be `if not isinstance(self.index, (ks.DatetimeIndex, pd.DatetimeIndex)):`", + "reference": "Could you also update it in `at_time`?" + }, + { + "prediction": "I think it would be better to use `Boolean.parseBoolean(options.get(\"locality\").orElse(false))` instead of `Boolean.parseBoolean(localityFallback)`", + "reference": "Because schema is non-final we can't just switch this to a lambda" + }, + { + "prediction": "I'm not sure this is the best way to handle this. I think it would be better to have a separate method for this, something like `ThrowExceptionIfMustBeRethrown(string message, Exception exception)` or something like that.", + "reference": "proposal: **always** add the exception to the end of the message. So no need to to pass exception twice (implicit and explicit). Need a lot of changes." + }, + { + "prediction": "I think it would be better to move this logic to the `Producer` and `Consumer` classes themselves, so that we don't have to duplicate the logic here.", + "reference": "why? event.getInvocationType is not you want?" + }, + { + "prediction": "I think we can remove the `ID` and `Version` fields from the `Info` struct. They are no longer used.", + "reference": "nit: how about `GitSHA`?" + }, + { + "prediction": "I think this should be `FAIL_DIR_NAME` and not `makeflow.failed.%d`", + "reference": "If you move the other functions, this should also be moved to `makeflow_gc.h`." + }, + { + "prediction": "I think this should be `listen['track_metadata']['additional_info'].get('duration_ms', current_app.config['PLAYING_NOW_MAX_DURATION'])` instead of `listen['track_metadata']['additional_info']['duration'] // 1000`", + "reference": "This whole block bugs me. Expire_time to me suggest that an absolute time of when something happens and duration is an interval of time. While the code looks correct, it feels awkward to read." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in `coerceToVNode` since it's the only place where `possibleVNode._dom` is set.", + "reference": "Can we add `_dom` as an argument to createVNode here? I think it might be shorter (could totally be wrong!)" + }, + { + "prediction": "I don't think this is the right place to do this. It's too late to do it now. It's too late to do it now. It's too late to do it now. It's too late to do it now. It's too late to do it now. It's too late to do it now. It's too late to do it now. It's too late to do it now. It's too late to do it now. It's too late to do it now. It's too late to do it now. It's too late to do it now. It's too late to do it now. It's too late to do it now. It's too late to do it now. It's too late to do it now. It's too late to do it now. It's too late to do it now. It's too late to do it now. It's too late to do it now. It's too late to do it now. It's too late to do it now. It's too late to do it now. It's too late to do it now. It's too late to do it now. It's too late to do it now. It's too late to do it now.", + "reference": "I think that the iret handling is not yet good." + }, + { + "prediction": "I'm not sure this is the right way to do it. I think we need to pass in the `tabIndex` to the `Tab` component and then set the `tabIndex` of the `TabBar` component to the value of the `tabIndex` of the `Tab` component. This way the `Tab` component will always be the last child of the `TabBar` component and the `TabBar` component will always be the first child of the screen.", + "reference": "Huh, that's kinda weird. I get it, but it's unexpected to me..." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the `Tag` struct itself. The reason is that we don't want this to happen in the `Tag` struct itself. It should only happen in the `Splitter` struct.", + "reference": "why is this removed? it is important when you upload from stream of unknown size" + }, + { + "prediction": "Style/ClassAndModuleChildren: Use parentheses to call a method defined in a module instead of parentheses to call a method defined in the class.", + "reference": "Out of curiosity, why is this needed? Does it enforce what class can be assigned?" + }, + { + "prediction": "I think this should be `os.Setgid(os.Getgid())` and `os.Setuid(os.Getuid())` instead of `os.Chmod` and `os.WchMod`.", + "reference": "non-blocking: Now that we have a handful of statements which deal with creating a listener, it may make sense to introduce a `createListener` method or something similar" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `LastExecutor` field of the `MevBlockProductionTransactionsExecutor` class.", + "reference": "factory should be stateless if possible, looks like much complexity added" + }, + { + "prediction": "I think this should be `project_id` instead of `project_id`.", + "reference": "Could you please add short description for the default value as well?" + }, + { + "prediction": "I'm not sure if this is the right place to log the error. I think it's better to log the error in the `CommitStateChanges` function.", + "reference": "Leave a TODO message to say we will fix the log level in the future, once committing the block and the state become a transaction" + }, + { + "prediction": "I think this should be `write.parquet.row-group-check.max-record-count`", + "reference": "this can be integer" + }, + { + "prediction": "I think this should be `font: {{ font['completion.category'] }};` and not `font: {{ font['completion.category.border.top'] }};`", + "reference": "nitpick: Please remove the blank line here" + }, + { + "prediction": "Style/InverseOf: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", + "reference": "What is this for? The only methods I can see by that name in the rails doc are generating a foreign key name from a model class name but you seem to be giving a key name as argument?" + }, + { + "prediction": "I think it would be better to move this logic into the `AuthenticationPlugin` and `PkiAuthenticationPlugin` classes. The `AuthenticationPlugin` and `PkiAuthenticationPlugin` classes should be responsible for initializing their respective metrics. The `AuthenticationPlugin` and `PkiAuthenticationPlugin` classes should also be responsible for registering their respective metrics with the `SolrMetrics` class.", + "reference": "Is this second check necessary? we know that just after the plugin was created its metricRegistry is null, it's set only after `initializeMetrics` has been called." + }, + { + "prediction": "This should be `return TALKACTION_CONTINUE;` instead of `return TALKACTION_BREAK;`", + "reference": "shouldn't this be `return TALKACTION_BREAK;` as the player does not meet the required group access?" + }, + { + "prediction": "I'm not sure if this is the right place to check the block is created by the proposer.", + "reference": "does this still work if minerNode1 has already proposed a block before 2 & 3 are stopped?" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `Reconcile` method of the `Reconciler` interface. The `Reconcile` method is where the actual work is done.", + "reference": "I am wondering if we can either make this a feature or have a way to turn it off in production. My concern is that we might be adding more of these kind of code in the future." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be in the same place as `kdf = kdf.stack(level=1)`, but with the `reset_index` and `reset_index(level=1)` in between.", + "reference": "We can just use `.stack()` here? Then I guess we can reuse when supporting multi-index columns." + }, + { + "prediction": "I think we can remove the `#if NETSTANDARD2_0` from this file.", + "reference": "What are the possibilities here? Since we plan on supporting .net standard 2.0 from day 1, we might as well tackle that now." + }, + { + "prediction": "I'm not sure this is the best name for this. I think it should be something like `Add(in SpanContext context, T value)` or `Add(in SpanReference context, T value)`.", + "reference": "should the parameters be called reference or context?" + }, + { + "prediction": "I think this should be `in_buffer.byteslice(index, in_buffer.length)` instead of `in_buffer.slice(index, in_buffer.length)`.", + "reference": "Do we need to also change `length` here (and below) to `bytesize`? Perhaps we ought to make a copy of `in_buffer` encoded as binary and then the existing algorithm should work." + }, + { + "prediction": "I think this should be `url.toString()`, not `url.toDisplayString()`.", + "reference": "This should be `toDisplayString()` to not contain e.g. passwords." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Can we just say that having a non-nil `autocomplete_path` implies that autocomplete is enabled?" + }, + { + "prediction": "I think this is the only place where `proto` is used in this PR.", + "reference": "Note that the package github.com/golang/protobuf/proto is deprecated. We're instructed to use the \"google.golang.org/protobuf/proto\" package instead. I didn't want to change it now to avoid intrusive changes whose consequences are, currently, unknown." + }, + { + "prediction": "I don't think we should be removing these", + "reference": "Are these gone routes? Do we need to 301 them?" + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in `pkg/apis/networking/v1beta1` since it's only for v1beta1.", + "reference": "move them to internal group of imports" + }, + { + "prediction": "I think we can remove this line.", + "reference": "can we rewrite this as: `ignored event '%s' for cstor pool '%s'`" + }, + { + "prediction": "I think this belongs to the `ApprovingOfficial` model, not the `ClientRequest` model.", + "reference": "not all client data types have an approving official (eg: 18F does not). do we still want to include the relation here?" + }, + { + "prediction": "I think this method should be renamed to `findElementsByXPath` or `findElementsByXPathInWebDriver` or something like that.", + "reference": "This change should also probably go into the corresponding method of the abstract By class?" + }, + { + "prediction": "I'm not sure this is the best way to do this. I think it would be better to use `req.protocol` and `req.hostname` instead of `req.get('host')` and `req.get('host')`", + "reference": "why this remove?" + }, + { + "prediction": "I think this should be `FileReaderReader` or `FileReaderReader` to be consistent with the rest of the package.", + "reference": "As the test failures indicate, making this change is going to mean changing everything which currently implements this interface." + }, + { + "prediction": "I think this should be `http` instead of `http://`", + "reference": "Do we want to redirect this to the forum or something in case people have it linked/bookmarked?" + }, + { + "prediction": "I think it would be better to use a ternary operator instead of `||` here.", + "reference": "@peterzimon came up with this 'NM' piece as a placeholder for New Member initials, without this the screen looks broken. It changes to normal initials calculation once email or name is entered. Lmk if you'd like to put something different here ;)" + }, + { + "prediction": "I'm not sure if this is a good or a bad thing, but I think it's a good thing. The `member-subscription` is a bit of a mouthful, and I don't think we should be using it in the UI.", + "reference": "@kevinansfield Would be cool if you can take a if this is the best way to add `subscriptions` info on member model. This uses the transform + separate model definition way which seemed to be the right way from other references in Admin" + }, + { + "prediction": "I'm not sure if this is the best way to handle this. I'm not sure if we want to suppress the warning in all cases, but also don't want to make it impossible to plot without Matplotlib.", + "reference": "This is the common way of dealing with optional dependencies" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should go in `testhelpers.go`", + "reference": "nit: we can replace all `kr` in this file with like `src`." + }, + { + "prediction": "I think this should be `const mode = readPreference.mode || 0;` instead of `const mode = readPreference.mode;` since `0` is the default value for `typeof readPreference.mode === 'object' && readPreference.mode !== null && typeof readPreference.mode === 'object'`", + "reference": "same concern here as above" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `Mongoid::Search::Base` since it's a base class for all search engines, not just Mongoid.", + "reference": "Thank you for this, I gather this repairs failures that I've seen in another PR." + }, + { + "prediction": "I think it would be better to use `distinct().withColumn(\"file_path\", from_json(\"file_path\", new StructType().add(\"file_path\", new StructType().add(\"file_path\", jsonType(table.getSchema())))))` instead of `distinct().flatMap(...).toDF(\"file_path\").distinct()`", + "reference": "This place probably makes sense to me. We can consider exposing an argument to make the dedup step optional (I am not sure it is a good idea but I want to think this through together). The dedup step we are adding is going to trigger a shuffle. Technically, we are fine in the existing expire snapshots action as it does the dedup in `except`. The question is what kind of performance impact deduplicating here will have. We only have duplicates if multiple manifests reference the same files. In `rewrite_manifests` procedure, we rewrite all manifests, meaning we produce a snapshot with new manifests where entries are old data files. Also, there are updates and deletes that may rewrite manifests. I think deduplicating here makes sense to me in all cases. Thoughts, @rdblue @flyrain @RussellSpitzer @karuppayya?" + }, + { + "prediction": "I think we need to log the error here as well.", + "reference": "can we move the code before deleteNodeFromDB ? this way even if the node crashes after remove config we can still re-run decommission again ?" + }, + { + "prediction": "`var_name` is not used in this function. I think it should be removed.", + "reference": "Seems the default value of `melt`'s `var_name` at namespace.py should be changed as well." + }, + { + "prediction": "I think this is the only test that needs to be updated. The rest of the tests pass locally and I don't see any regressions.", + "reference": "I think botocore's serializer should already create the correct headers. However, they are currently not used in `_botocore_parser_integration_test`(line #217). Maybe we could remove the headers here and just use a fallback in the `_botocore_parser_integration_test` (i.e. use the given headers if they are set, otherwise use the headers generated by botocore's serializer)?" + }, + { + "prediction": "I think it would be better to use the singular form of the name here instead of the plural one.", + "reference": "This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `AuthProvider` class, since that's where the `authorize` method is.", + "reference": "in case you want to rename one of the plugins when instantiating, from options?" + }, + { + "prediction": "I think this should be `ctu_func_mapping`", + "reference": "This default variable should be moved into a config variable, created by `package_context`, and read from `config\\package_layout.json`." + }, + { + "prediction": "I think this test should be more specific and test the case where `visibleCalc.startColumn` is not equal to `visibleCalc.endColumn`.", + "reference": "Can I ask you to add a new line after `const` assignment? I believe that this increases the code readability by encapsulating assignment and logic (expecting) blocks." + }, + { + "prediction": "I don't think this is the right place to do this. This is not the place where we initialize the host space. This is the place where we initialize the device space. The device space should be initialized before the host space is initialized. I think this should be done in the device space initialization function.", + "reference": "So the intention is you configure with `-CMAKE_CXX_FLAGS=\"-D KOKKOS_IMPL_TURN_OFF_CUDA_HOST_INIT_CHECK\"`?" + }, + { + "prediction": "why is this 1.0 and 0.0?", + "reference": "This was a bug." + }, + { + "prediction": "I think we can remove the `class` attribute from the `image.html.twig` template as well.", + "reference": "Is OK that we don't have some placeholder?" + }, + { + "prediction": "I think we should set it to 2.", + "reference": "Sectorbuilder behaves differently depending on whether it's given 1 or more threads. It won't seal if only given 1." + }, + { + "prediction": "nit: you can use `import com.google.inject.Inject;` instead of `import static azkaban.ServiceProvider.SERVICE_PROVIDER;`", + "reference": "Sort of believe We should put MetricManager in constructor parameter given this case." + }, + { + "prediction": "I think it would be better to make `sourceId` and `fieldId` fields of type `Integer` instead of `int`. This will allow us to avoid boxing and unboxing when serializing and deserializing the object.", + "reference": "Do we need to check `fieldId` is larger than 1000?" + }, + { + "prediction": "I'm not sure this is the right place to check for acked status. I think it should be in the listener's `onWriterChangeReceivedByAll` method.", + "reference": "I think this should be called after the if below (the one for disable positive acks)" + }, + { + "prediction": "I think it is better to use `URI` instead of `URI`", + "reference": "I'd like to avoid changing this method since it is public and using a URI will probably change behavior for users passing strings (String -> URI -> Path instead of String -> Path)." + }, + { + "prediction": "I think this should be done in a separate PR.", + "reference": "Should these restore the stashed env after the test runs?" + }, + { + "prediction": "I don't think this is the right way to do it. The reason is that `kw_defaults` can contain `None` values, which means that we should not consider them as defaults. Instead, we should check whether a given default node is not `None` before trying to access its `name` attribute. This can be done by checking if the node is not `None` before trying to access its `name` attribute. For example: `for default_node in scope.args.defaults: ... if default_node is not None: ... for default_name_node in default_node.nodes_of_class(nodes.Name): ... if default_name_node is not None: ... if default_name_node.name is not None: ... return True`", + "reference": "We're calculating the full list of kwargs here (even if the first element of the list would return True) so we could improve performance by using a generator line 408 in ``for default_node in all_defaults:``." + }, + { + "prediction": "I think this should be `accountDeltaCount` instead of `accountDelta`", + "reference": "Can ndelta differ depending on when the deltas are compacted? That is, when intermediate updates are dropped?" + }, + { + "prediction": "I think it would be better to add a `@since TODO` to the `XPathRule` class.", + "reference": "Our checkstyle config likes it better when the `

    ` is before the first word of the next paragraph, and not on a blank line" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but it seems like it should be.", + "reference": "This looks to be the only place where we return early before the close below, so if the \"double close\" is bothering people, closing manually here (and removing the `defer`) could be an option" + }, + { + "prediction": "I think this should be `execSync( 'npm run qunit', { stdio: [ 0, 1, 2 ] } );`", + "reference": "This task can probably be deleted since we don't need gulp to run Jest." + }, + { + "prediction": "I don't think we need to check for `Errno::ECONNREFUSED` since it's the most commonly used error code.", + "reference": "Doesn't this need to include `Errno::ECONNRESET` to fix the issue?" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.", + "reference": "never heard of a qirector... what's their role again? (also should be 'for a movie')" + }, + { + "prediction": "nit: I think it would be better to move this into the `else if` block above.", + "reference": "Implement the \"collect all props for one vertex\" logic inside QueryVertexPropsProcessor" + }, + { + "prediction": "This should be `break` instead of `result = true;`", + "reference": "This is to prevent parsing things like \"1.1\" as \"1\" until we implement it properly." + }, + { + "prediction": "I think this should be `runExperiment(..., _getCheckpointParentDir(...))` instead of `runExperiment(..., _getCheckpointParentDir(...))`", + "reference": "Can we change `_getCheckpointParentDir` to be a public function explicitly? It seems like something that clients of experiment runner may wish to use." + }, + { + "prediction": "I think this should be `self.ConsoleUIACheckBox.SetValue(config.conf[\"UIA\"][\"consoleUIA\"])` and not `self.ConsoleUIACheckBox.defaultValue = self._getDefaultValue([\"UIA\", \"consoleUIA\"])`", + "reference": "Why is a restart necessary?" + }, + { + "prediction": "I think this should be `if !cfg.External.Enabled() && !cfg.Internal.Enabled() {`", + "reference": "Should setting the task runtime also go under the above if condition?" + }, + { + "prediction": "I think this should be 100, not 50.", + "reference": "SPIRE uses the leadingLowerCase convention for unexported constants" + }, + { + "prediction": "I don't think this is needed. The `Sarif` namespace is only used by `SarifReader` and `SarifWriter`, which are only used by `Microsoft.CodeAnalysis.Sarif.Readers`.", + "reference": "The newest JSchema code generator orders `System` usings first." + }, + { + "prediction": "I think it would be better to move this logic into `IcebergObjectInspector.create` and `IcebergObjectInspector.createCaseInsensitive`", + "reference": "I understand that we want to have a possibility to configure the IcebergInputFormat to be case sensitive or case insensitive since it can be used by other MR jobs as well. Do we want to allow the users of Hive to shot themselves on the foot and enable case sensitivity? My first guess would be that we should not use the configuration here, just go with `false`, but if you have some specific use-case in your mind I can be easily convinced" + }, + { + "prediction": "I think we can remove the `pool.PoolAddEventHandled = true` line here.", + "reference": "Will the above call to cStorPoolAddEventHandler() get executed in the same thread as this line?" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but it seems like it makes sense to me.", + "reference": "I don't think alloca instructions are always at the start of the entry block. I think it would be safer to check the entire entry block for alloca instructions, just in case some are not the first instruction. (Technically they can be anywhere in the function but we check in other places that this isn't possible)." + }, + { + "prediction": "I'm not sure if this is the right place for this. I think it should be in the `ifaces` package, but I'm not sure if that's the best place to put it.", + "reference": "Why isn't this 4789 (which I think is the Felix default)?" + }, + { + "prediction": "I think we should use `FailureImport` instead of `FailureImported` here.", + "reference": "Can this be `Import operations failure`? In addition, is this the right time to change the variable names? e.g. `ReasonImportOperationsFailure`, `ReasonImportFailure`, `ReasonImportSuccessful`, `ReasonCreateResourceFailure`, `ReasonImportResourceSuccessful` Naming convention that i have assumed here is as follows: `Reason`" + }, + { + "prediction": "I think this should be `rb_define_singleton_method` instead of `rb_define_global_variable`.", + "reference": "I suspect this isn't needed because I think `rb_intern` gets marked already." + }, + { + "prediction": "I think this should be `log.finest(\"In development mode. Copying required files in case we're using a WebDriver-backed Selenium\");`", + "reference": "This change is incorrect: the current log level is correct." + }, + { + "prediction": "I don't think this is correct. I think we want VERSION_SELECTIVE_INDEXING to be the highest.", + "reference": "Can you add a space before the equal sign? There are a couple other places where spaces are missing in this PR." + }, + { + "prediction": "I think it is better to remove the `flow.getUpdateTime() >= updateTime` condition and just use `flow.getUpdateTime()` in `updateList.add(flow.toUpdateObject(updateTime))`", + "reference": "Please follow the todo naming convention." + }, + { + "prediction": "I think we can remove this.", + "reference": "These are no longer used and changes should instead be made directly to the files in `deploy/chart/crds` /assign @JoshVanL /unassign" + }, + { + "prediction": "`xy` -> `x`, `xywh` -> `xwh`, `pred_map[..., 2:4]` -> `wh`, `multi_lvl_anchors[i]` -> `anchor`, `self.num_attrib` -> `num_attrib`", + "reference": "Is this really necessary to work around this way? The old version works fine with me when converting to ONNX." + }, + { + "prediction": "I think this should be `return 0, fmt.Errorf(\"Blob already closed\")`", + "reference": "Same as above: don't start error strings with a capital letter, and don't fix unneeded things in an unrelated commit ;)" + }, + { + "prediction": "Line is too long. [83/80]", + "reference": "Is this a testing debug statement?" + }, + { + "prediction": "I'm not sure this is the right way to do it. I think we need to pass the `options` to the `parse` function and have the `parse` function return the connectionStringObject. This way we don't need to pass `options` to the `createUnifiedOptions` function, and we don't need to pass `options` to the `mergeOptions` function.", + "reference": "you'll need to wrap the _whole thing_ within this async call (or refactor it so everything below is in a new temporary function). The code below this section depends on a value for `object` after the parsing occurs, but what you're doing here is kicking off a race condition where `object` is null, but _might_ parse quickly enough to assign it the parsed parts. Instead, you need to do everything that depends on the parsed object in the callback of `parse`." + }, + { + "prediction": "I think this should be `std::unique_lock lk (mutex);`", + "reference": "This is now going to be protecting `stopped` when it doesn't need to. If you are going to do this then can you make `stopped` non-atomic and protect it in `stop`. It's cheap to make a `unique_lock` fyi, it's just a pointer to a mutex and a `bool`. The `lk.lock ()` in the loop is superfluous so probably shouldn't have been there to begin with." + }, + { + "prediction": "I think we can remove this line.", + "reference": "Lets not give packages names if we dont have to. If a package requires a rename, we should change the actual name while/if we can." + }, + { + "prediction": "I think this should be `TEST(1U << 31, enc) && TEST(1U << 15, enc)` instead of `TEST(1U << 31, enc) && TEST(1U << 15, enc)`", + "reference": "Not sure I see where this is coming from. This is a bug fix? Should be mentioned in the commit message? Same below." + }, + { + "prediction": "I'm not sure this is the right place to do this cleanup. I think it should be in the `afterEach` callback of the `cleanupAfterSuite` function.", + "reference": "I reverted this change in the last commit, I think we should revert it here. I know this leads to confusing test output for skipped tests, but I would prefer to tackle that in a separate PR specifically focused on that problem. In fact, I think the issue might really be with the leak checker, and not how this test runner is defined. Please make a ticket for this (if it doesn't already exist) and revert this change" + }, + { + "prediction": "I don't think we need to add normed_bbox to the public API.", + "reference": "Can this part be done in `dataset.get_ann_info`? Just like CocoDataset converts xywh to xyxy in `_parse_ann_info`" + }, + { + "prediction": "I think this is the only change that should be in this file. The rest of the changes are unrelated to this PR.", + "reference": "Should we change the name of this test struct to be `testTracerProvider` as well?" + }, + { + "prediction": "I think we can remove the `iotexapi` package and use `github.com/iotexproject/iotex-api` instead.", + "reference": "\"google.golang.org/grpc\" should be together with \"go.uber.org/zap\" all \"\"github.com/iotexproject/iotex-core/*\" stay together" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in `WebEngineTab.__init__`, since that's the place where the WebEngine is initialized.", + "reference": "No need for a separate variable here - just call `utils.read_file` directly below." + }, + { + "prediction": "I think this should be a warning, not an error. I don't think we want to log every message that gets sent to the anon channel.", + "reference": "Thanks for the fixing, small question, Here the message just be written to the channel, will it be blocked?" + }, + { + "prediction": "I'm not sure if this is the right name for this. I think it's more accurate to call it `ReconstructedBlock` or `ReconstructedBlockHash` or something like that.", + "reference": "maybe we will have something like `Bodies []byte(\"bodies\")` instead of them being a number? with numbers we are making it harder to insert stages mid-process." + }, + { + "prediction": "I think we can remove the `Pod` field from the `GroupMember` struct and the `PodReference` field from the `ExternalEntityReference` struct. The `Pod` field is only used in the `PodReference` field, and the `PodReference` field is only used in the `ExternalEntityReference` field, so we can remove the `Pod` field from the `GroupMember` struct and the `PodReference` field from the `ExternalEntityReference` struct. The `PodReference` and `ExternalEntityReference` structs are only used in the `GroupMember` struct, so we can remove the `PodReference` and `ExternalEntityReference` structs from the `GroupMember` struct. The `PodReference` and `ExternalEntityReference` structs are only used in the `GroupMember` struct, so we can remove the `PodReference` and `ExternalEntityReference` structs from the `GroupMember` struct. The `PodReference` and `ExternalEntityReference` structs are only used in the `GroupMember` struct, so we can remove the `PodReference` and `ExternalEntityReference` structs from the `GroupMember` struct. The `PodReference` and `ExternalEntityReference` structs are only used", + "reference": "out of curiosity, why making this change? If no real reason, could you restore to avoid unnecessary changes of several generated files?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the `manager.Connect()` function.", + "reference": "Could we public events if `manager.serStatus()`?" + }, + { + "prediction": "I think this should be `Please make sure that the element exists on the page, or that the plugin you are targeting has not been installed. Check that the