diff --git "a/qwen25_lora_official_rank_4_1e-05/complete_results.json" "b/qwen25_lora_official_rank_4_1e-05/complete_results.json" new file mode 100644--- /dev/null +++ "b/qwen25_lora_official_rank_4_1e-05/complete_results.json" @@ -0,0 +1,40694 @@ +{ + "test_bleu_4": 0.026722299341944283, + "test_exact_match": 0.00019667617268167962, + "test_rouge": { + "rouge1": 0.14729236978584792, + "rouge2": 0.025702118262249128, + "rougeL": 0.12220512653363477, + "rougeLsum": 0.12222192011639979 + }, + "test_bertscore": { + "precision": 0.8427995183918255, + "recall": 0.8462318667257438, + "f1": 0.8440955590329605 + }, + "test_meteor": 0.11341991042079051, + "raw_data": [ + { + "prediction": "I think this should be `language=java;transport=grpc`", + "reference": "can we also test for `transport=rest`?" + }, + { + "prediction": "I think this should be `$this->config->get($this->mainConfig)->Index->record_batch_size`", + "reference": "If record_batch_size is not set in config.ini, this code will trigger a notice about an undefined value. I would suggest either wrapping the setPageSize() call in an `if (!empty(...)) {` check, or else providing a default value in the set call (i.e. `$config->Index->record_batch_size ?? 100`)." + }, + { + "prediction": "I think this should be `window.analytics.load(\"<%= ENV['SEGMENT_KEY'] %>\");`", + "reference": "I didn't realize we were hardcoding this, thanks for moving it to an env value." + }, + { + "prediction": "I think this should be `file.data.size === undefined` instead of `isNaN(file.data.size)`. `file.data.size` can be `null` or `undefined` and `isNaN` will return `false` in those cases.", + "reference": "We are trying to support IE 10-11, so we'll need a polyfill for this one, I think." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work for now.", + "reference": "It looks like there's a new `isNavigatingTo( url )` selector for this very purpose so let's use this here instead. This way we just need to use the one selector rather than two. Let's assign that to a similar-named variable here (e.g. `isNavigatingToPostResetURL`) rather than the prop it's used with." + }, + { + "prediction": "I think this should be `const AbsDistMat& im` and `AbsDistMat& col`.", + "reference": "I think im2col should only accommodate CPUMat." + }, + { + "prediction": "I think we should move this to `google.cloud.forseti.notifier.notifiers.email_violations`", + "reference": "alpha sort the imports" + }, + { + "prediction": "(style) line over 80 characters", + "reference": "Can you explain why is this necessary? Is `snprintf()` with four integer arguments unsafe?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to work for me. I'm not sure if this is the right thing to do, but it seems to work for me. I'm not sure if this is the right thing to do, but it seems to work for me. I'm not sure if this is the right thing to do, but it seems to work for me. I'm not sure if this is the right thing to do, but it seems to work for me. I'm not sure if this is the right thing to do, but it seems to work for me. I'm not sure if this is the right thing to do, but it seems to work for me. I'm not sure if this is the right thing to do, but it seems to work for me. I'm not sure if this is the right thing to do, but it seems to work for me. I'm not sure if this is the right thing to do, but it seems to work for me. I'm not sure if this is the right thing to do, but it seems to work for me. I'm not sure if this is the right thing to do, but it seems to work for me. I'm not sure", + "reference": "How likely would it be that the keyboard layout for the NVDA main thread differs from the keyboard layout of the currently focused app?" + }, + { + "prediction": "nit: remove the empty line", + "reference": "Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`)" + }, + { + "prediction": "I don't think we need to join the keys here. The server will do that for us.", + "reference": "Also update line 2205 below" + }, + { + "prediction": "I think this should be `shared := volumeConfig.GetSharedMountValue() == \"true\"`", + "reference": "n_: It is a good practice to name the variable to indicate what they contain. In this case since `shared` is supposed to have boolean, calling it: `isShared` can help in the readability of the code." + }, + { + "prediction": "I don't think this is correct. `freezeColumn()` does re-render the table.", + "reference": "I suppose it's a false-positive error. Maybe there is a way to configure the `eslint-*` package to accept `i.e. .... lower case` syntax" + }, + { + "prediction": "I think this should be `string.IsNullOrEmpty(activity.ParentId) || activity.ParentSpanId == ActivityTraceId.Invalid`", + "reference": "this maynot be a perf issue, if ToHexString() is not actually allocating a string, but returns the caches string value. to be confirmed." + }, + { + "prediction": "I don't think we need to log the name of the image provider here.", + "reference": "`zap.String(\"image-provider\", provider.Name())` should be in a same line." + }, + { + "prediction": "Please remove this line. It's not needed.", + "reference": "Why this deletion?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get the tests to pass on Python 3.", + "reference": "This change looks unrelated to the CL description?" + }, + { + "prediction": "`DEDUP_RESUTL_CHECK` -> `DEDUP_RESULT_CHECK`", + "reference": "I'm not certain that `res`+`utl` isn't a thing." + }, + { + "prediction": "I think we should use `Status` enum instead of `Status.getNumVal()`.", + "reference": "This method can cause bugs. Why don't you use list of finalize statuses and then use join by comma and that will give you correct value. Use Apache Commons Lang library List list = Arrays.asList(1,2,3,4,5,6,7); String str = org.apache.commons.lang.StringUtils.join(list, \",\"); You can use it at multiple places shown in this diff." + }, + { + "prediction": "Please remove this empty line.", + "reference": "Merge with next condition" + }, + { + "prediction": "I think this should be `DeleteTask(task deploy.TaskStackInfo, opts ...cloudformation.StackOption) error` so that we can pass in the stack options.", + "reference": "Maybe add it when it is used." + }, + { + "prediction": "I think this should be `{'name': 'non_exist_scanner', 'enabled': False}`", + "reference": "More clear naming: NONEXISTENT_ENABLED" + }, + { + "prediction": "I don't think we need to do this for `from` and `to` since they are not nullable.", + "reference": "why is this change necessary?" + }, + { + "prediction": "I don't think this is the right thing to do. If we have a null response type, we should return `null` as the full name.", + "reference": "make a SchemaTypeNameConverter.getTypeNameForEmptyType() and call that here." + }, + { + "prediction": "This is not the correct way to check if a session exists. You should use `if ($request->hasSession()) { ... }` instead.", + "reference": "Use braces on your conditional structures please" + }, + { + "prediction": "I don't think we need to force saving the command history. We can just save the command history by default.", + "reference": "Great God, I have a question. This \".nebula_history\" file is used to save history commands. Is there a file size limit? When the file is large, does it take a long time to start initialization (loadHistory)? How did you think about this? Thx." + }, + { + "prediction": "nit: extra space after `if`", + "reference": "Isn't this the same check as two lines above?" + }, + { + "prediction": "I think this should be `os.path.join(options.CA_DIR, 'mitmproxy', 'config.yaml')`", + "reference": "Don't redefine, just import the existing one in `cmdline.py`. :)" + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.", + "reference": "why not call `respond_to?(\"#{name}=\")` from the `if` line?" + }, + { + "prediction": "I think this should be `commandLine.setWorkDirectory(workingDir);` instead of `commandLine.withWorkDirectory(workingDir);`. `withWorkDirectory` returns a new `GeneralCommandLine` instance, but `setWorkDirectory` modifies the current instance.", + "reference": "This was properly set above as `.runfiles/` (with a fallback to workspace root dir) but never used past this line." + }, + { + "prediction": "I think this should be `MvxBasePresentationAttribute` instead of `MvxPresentationAttribute`", + "reference": "Are all these namespaces required for this attribute?" + }, + { + "prediction": "I'm not sure this is the right place to log the output. I think it should be logged in the `Beaker::Test::Result#to_s` method.", + "reference": "Given this may be used and printed in other ways, isn't `debug` more appropriate?" + }, + { + "prediction": "I think this should return `nil` if the directory doesn't exist.", + "reference": "Looks like this is unused? Did you mean to call it when clearing the block journal?" + }, + { + "prediction": "I think we can remove the `alerters` field and just use `this.alerters` instead.", + "reference": "why named alters? how about this.alerts = alerts?" + }, + { + "prediction": "I think this should be `mset.sourcesInfo()` and `mset.mirrorInfo()` instead of `mset.sourcesInfo()` and `mset.mirrorInfo()`.", + "reference": "not sure if this has to be here or not tbh" + }, + { + "prediction": "I'm not sure this is the right thing to do. If the topic name is too long, it will fail to create the topic. I think we should just return an error if the topic name is too long.", + "reference": "There's a better fix for this in #1741, which should replace this." + }, + { + "prediction": "I think this should be `[]byte(\"node1\")` instead of `[]byte{110, 111, 100, 101, 53}`", + "reference": "Use swarm.Address not []byte as type, and construct it from actual byteslice or use swarm.NewAddress if it is constructed from hex-encoded string." + }, + { + "prediction": "I think this should be `os.RemoveAll(dir)` instead of `require.NoError(t, os.RemoveAll(dir))`", + "reference": "It would be worth factoring this out to a function, but you don't have to do that here." + }, + { + "prediction": "I'm not sure about the name of this interface. I think it should be `UriHandler` or something like that.", + "reference": "There's no need for `final` in interfaces." + }, + { + "prediction": "I think this should be `Span.SetTag(Tags.Version, value);` instead of `Span.SetTag(DatadogTags.ServiceVersion, value);`", + "reference": "Isn't this case handled as a custom tag in `Span.SetTag()` below? This switch is only for special tags that actually set `Span` properties." + }, + { + "prediction": "I think we should keep the empty line here, as it separates the docstring from the function body.", + "reference": "This shouldn't be changed." + }, + { + "prediction": "I think this should be 2014, 2015, 2016, 2017, 2018, 2019, 2020, 2021, 2022, 2023, 2024, 2025, 2026, 2027, 2028, 2029, 2030, 2031, 2032, 2033, 2034, 2035, 2036, 2037, 2038, 2039, 2040, 2041, 2042, 2043, 2044, 2045, 2046, 2047, 2048, 2049, 2050, 2051, 2052, 2053, 2054, 2055", + "reference": "This one is important `2: I102 copyright year is outdated, expected 2014 but got 2012`" + }, + { + "prediction": "I don't think these imports are needed.", + "reference": "Are these imports needed (BiConsumer and Consumer)? If they are unused imports, then precommit will fail." + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "Why are we catching and logging exceptions? By doing that we make it look like the job has succeeded and it will be removed from the queue - if we didn't do that then it would stay queued..." + }, + { + "prediction": "`$cartItems = $cart === null ? [] : $cart->getItems();` should be `$cartItems = $cart === null ? [] : $cart->getItems()->toArray();`", + "reference": "If there are `@param` tags in docblock, there should be `@return` tag also. (applies for a whole file)" + }, + { + "prediction": "I think this should be \"validator\" not \"validators\"", + "reference": "Is the concept of validators exclusive to IBFT2? I wonder if this category should be more explicitly linked to IBFT2." + }, + { + "prediction": "I think we can remove the import of `org.hyperledger.besu.crypto.SECP256K1.*`", + "reference": "Spotless is configured to reject star imports. Please replace with explicit imports." + }, + { + "prediction": "This should be `sycl::info::device::local_mem_size` instead of `sycl::info::device::local_memory_size`.", + "reference": "Remind me why you are using CUDA vocabulary when naming these variables." + }, + { + "prediction": "I don't think this is the right place to do this. I think it should be done in `DBReader.getFeeds()`. The reason is that `DBReader.getFeeds()` is used by `DBReader.getAllFeeds()` which is used by `DBReader.getFeedsByGroup()` which is used by `DBReader.getFeedsByGroup()` which is used by `DBReader.getFeedsByGroup()` which is used by `DBReader.getFeedsByGroup()` which is used by `DBReader.getFeedsByGroup()` which is used by `DBReader.getFeedsByGroup()` which is used by `DBReader.getFeedsByGroup()` which is used by `DBReader.getFeedsByGroup()` which is used by `DBReader.getFeedsByGroup()` which is used by `DBReader.getFeedsByGroup()` which is used by `DBReader.getFeedsByGroup()` which is used by `DBReader.getFeedsByGroup()` which is used by `DBReader.getFeedsByGroup()` which is used by `DBReader.getFeedsByGroup()` which is used by `DBReader.getFeedsByGroup()` which is used by `DBReader.getFeedsByGroup", + "reference": "Please turn the iteration order around (instead of `0...size` to `size...0`). The reason is that this sometimes skips indices when removing an item. You can therefore end up with feeds that have counter 0 and are still displayed." + }, + { + "prediction": "I think this should be `not solid_subset is None` or `solid_subset is not None`", + "reference": "this is a behavior change. solid_subset=[] represents an empty pipeline where as solid_subset=None is the full pipeline" + }, + { + "prediction": "I think this should be an error, not a warning.", + "reference": "this is a breaking change, any specific reason you want to do this?" + }, + { + "prediction": "I don't think we need to add these methods to the interface. They are only used in the `nodeChainReader` implementation.", + "reference": "Blocking: we still want read write separation. Node functions should absolutely not write to the chain store and the interface should reflect that. Only the syncer should have this capability in production code. It should be no problem to keep casting chainForTest to a read-write interface, or doing other function decomposition and automatic casting tricks." + }, + { + "prediction": "I think this should be `1<<30 - 1` instead of `1<<31 - 1`.", + "reference": "The PR description says the lowest on-demand request priority is `2^30`. Why the `-1` here?" + }, + { + "prediction": "I think this should be `if (creature && !creature->isRemoved() && creature->getHealth() <= 0) {`", + "reference": "checking health again? I think it is not necessary." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think it's better to fail fast and let the pod be restarted by k8s. If we want to retry, I think we should do it in the `Start` method of `typhaConnection` and not here.", + "reference": "Need an `if err == nil {break}` above this line so that we don't log/sleep if the retry succeeds." + }, + { + "prediction": "I don't think we need to check for `typeof lib === 'function'` here. If `lib` is not a function, `new lib()` will throw an error anyway.", + "reference": "to reiterate my point above, this class is not the actual provided Promise, but rather something a user can provide a Promise to/with. I think a name like `PromiseProvider` is more appropriate." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should only queue the target if it's not already queued.", + "reference": "I guess we can only call this from a post-build function, but we might need to check that this target is to be built? I guess target A depends on B which has a post build. We `plz build :B` which adds C as a dep of A. Won't we queue C to be built even though it only needs to build if A needs to be built? That's kinda why I approached this the way I did. I trust you've thought about this but would be good to understand this a bit better." + }, + { + "prediction": "I don't think this is the right way to do this. I think you want to do `if not isinstance(pks, StreamSocket) and (arch.FREEBSD or arch.DARWIN):`", + "reference": "You should use `isinstance()` instead of comparing the class name to a string." + }, + { + "prediction": "I don't think we need to check for `AUDIO` as well, since `isHidden` is only called for `VIDEO` elements.", + "reference": "Why should audio and video elements always return `false` for `isHidden`?" + }, + { + "prediction": "Why is this commented out?", + "reference": "This obviously won't work for all the other platforms." + }, + { + "prediction": "I don't think you need to change this.", + "reference": "Isn't he diamond operator Java7+?" + }, + { + "prediction": "I think this should be `> 0` instead of `>= 0`.", + "reference": "Prefer adding a second `positive(String, double)` that delegates down to this three-param version. Using `null` in code is generally Not A Great Idea, and it looks ugly." + }, + { + "prediction": "I'm not sure why we need to pass in a pointer to an int here. I think we can just pass in an `int` and return an `int` from the `Rewrite` function.", + "reference": "This pattern, where we add a new parameter without using it, often indicates to me that we've got a leaky interface or abstraction. I see this pattern _a lot_ in this patch, so wondering you have thoughts about it." + }, + { + "prediction": "I think this should be `0700` instead of `0755`.", + "reference": "This seems like an improved pattern :)" + }, + { + "prediction": "Align the parameters of a method call if they span more than one line.", + "reference": "`open_id_authentication` is no longer the name of the function, and it's not OpenID specific" + }, + { + "prediction": "I'm not sure about this change. I think it should be `Wallet balance (XRB): ` and `Wallet pending (XRB): `", + "reference": "This didn't require corresponding changes to the test case(s)?" + }, + { + "prediction": "I think this should be `map[string]string` instead of `string` so that we can support multiple env files.", + "reference": "A question! I think `string` totally works, but what do you think of `*string` for consistency?" + }, + { + "prediction": "I think this should be `aws.cluster.x-k8s.io/infrastructure-ready` and `aws.cluster.x-k8s.io/control-plane-ready`", + "reference": "Should this be: `aws.infrastructure.cluster.sigs.k8s.io` instead?" + }, + { + "prediction": "I think this should be `zprd` and not `xprd`", + "reference": "Not clear on why this change is correct." + }, + { + "prediction": "nit: please add a blank line between the `if` and the `return`", + "reference": "Hi Simon. Whether this should return true depends on what byte buffers are used? The same applies to ByteBufferIndexInput, actually... I don't think you can generally tell whether the ByteBuffers the input operates on come from a mmap call or from somewhere else (even direct buffers don't have to be a result of mmap)." + }, + { + "prediction": "I think this should be `padding: 20` to match the other stories.", + "reference": "All stories in this file also need to have the default padding." + }, + { + "prediction": "I think we should assert that sibling->parent == subsurface->parent here.", + "reference": "I don't think these asserts are necessary, because `subsurface_find_sibling` already searches in the parent. Or am I missing something?" + }, + { + "prediction": "Use the new Ruby 1.9 hash syntax.
Space inside { missing.
Space inside } missing.
Space inside ( missing.
Space inside ) missing.
Space inside { missing.
Space inside } missing.
Space inside ( missing.
Space inside ) missing.
Space inside { missing.
Space inside } missing.
Space inside ( missing.
Space inside ) missing.
Space inside { missing.
Space inside } missing.
Space inside ( missing.
Space inside ) missing.
Space inside { missing.
Space inside } missing.
Space inside ( missing.
Space inside ) missing.
Space inside { missing.
Space inside } missing.
Space inside ( missing.
Space inside ) missing.
Space inside { missing.
Space inside } missing.
Space inside ( missing.
Space inside ) missing.
Space inside { missing.
Space inside } missing.
Space inside ( missing.
Space inside ) missing.
Space inside { missing.
Space inside } missing.
Space inside ( missing.<", + "reference": "Should this be `number` instead of `id`?" + }, + { + "prediction": "Shouldn't this be `table->isNativeExternalTable()`?", + "reference": "I have forgotten why we thought this restriction is necessary. A user registers a Hive/HBase table with us but is not able to use the table with the registered name in DML. Will UPDATE STATs will be on the original name too (and update stats code will find out registered name and use it for Table_uid?). This was the registration concept is almost like an internal implementation idea, at some point could even be done by some utility program for all existing Hive/hBase tables, and the user need not be aware of it? I am struggling with a user would want to register a table, if they cannot use it by that name." + }, + { + "prediction": "I think this should be `app2sim_alloc_tx` and `sim2app_alloc_rx`", + "reference": "Should most of these non-globals be static?" + }, + { + "prediction": "Metrics/BlockLength: Block has too many lines. [31/25]", + "reference": "Please do not approve PRs without tests!!!!" + }, + { + "prediction": "I don't think we need to pass `win_id` to `WebEnginePage` anymore.", + "reference": "Now that you handle this in `webenginetab.py` you can undo all the changes in this file." + }, + { + "prediction": "I don't think it's a good idea to catch all exceptions here. It would be better to catch only `RuntimeException` and rethrow all other exceptions.", + "reference": "I think we should log the exception to a log file instead of printing it. The current behavior (not catching the exception) should lead to an automatic print of the exception to the terminal/console." + }, + { + "prediction": "I think this should be an error, not a warning.", + "reference": "These changes to the resource helpers have some more far-reaching implications as they also affect calls made in hive-operator, I believe. It's probably OK still, though. Ideally, the resource helper would not be the one doing the logging, since it cannot know the severity, but that is well beyond something that we should tackle for this PR. I would rather have the hive-operator log warnings than have the syncsetinstance controller log errors." + }, + { + "prediction": "I don't understand why this change is needed. Can you explain please ?", + "reference": "do you really want to change the behavior on foreign key ?" + }, + { + "prediction": "I think this should be `if (json_array_size (batch->state_trans) > 0) { event_publish_state (batch->event, batch->state_trans); json_decref (batch->state_trans); batch->state_trans = NULL; } else { json_decref (batch->state_trans); batch->state_trans = NULL; }`", + "reference": "Looks like my bad. Thanks for fixing!" + }, + { + "prediction": "I think this should be called `replace_variables` instead of `no_replace_variables` to be consistent with the rest of the codebase.", + "reference": "I think \"Don't replace variables ...\" would be cleaner." + }, + { + "prediction": "I think this should be a `param.Selector` instead of a `param.Parameter` since it has a fixed set of possible values.", + "reference": "Do you validate the possible strings? I've not read the code below but we should make sure if a string is supplied it is validate..." + }, + { + "prediction": "I don't think we need the `w.Vars[\"instance_name\"].Value` here anymore.", + "reference": "I'd recommend using generateDataDiskName here as well -- might as well benefit from the safety that it gives to protect yourself from future changes to w.ID()." + }, + { + "prediction": "I don't think we need to expose this to the public API. It's only used internally.", + "reference": "qq: do we want to include anything in the name to indicate that it is a position in the manifest?" + }, + { + "prediction": "I'm not sure if this is the right place to put this, but I think it would be good to add a `Log.d(LOGTAG, \"Compositor pause begin\");` before the `mWindows.pauseCompositor();` call in the `onPause()` method.", + "reference": "These logs should probably use the `LOGTAG`" + }, + { + "prediction": "I'm not sure if we want to use `golang.zx2c4.com/wireguard` instead of `github.com/mysteriumnetwork/wireguard-go`", + "reference": "From this, it was clear, that we are using our version of wireguard-go. And now it looks like we are using original packages which is confusing." + }, + { + "prediction": "I don't think it's a good idea to show the exception message to the user. I think it's better to show a generic error message like \"Internal server error\" or something like that.", + "reference": "Any particular reason for this? This potentially will make harder to investigate users issues" + }, + { + "prediction": "I think this should be `Blockly.highlightedConnection_ != closestConnection && Blockly.localConnection_ != localConnection`", + "reference": "Do you also need to check if Blockly.localConnection_ is non-null?" + }, + { + "prediction": "I'm not sure I like the name `World` for this class. I think it would be better to rename it to `GlobalData` or something like that.", + "reference": "Not really a container, and it's not just about non-config data, not sure of a better description, @myronmarston ?" + }, + { + "prediction": "I'm not sure this is the right way to do it. I think it's better to use `require(\"@aws-sdk/client-s3\").GetObjectCommand` instead of `require(\"@aws-sdk/client-s3\").default.GetObjectCommand`", + "reference": "The desktop app will load this fine. on iOS I get `TypeError: undefined is not an object (evaluating '_$$_REQUIRE(_dependencyMap[8], \"stream\").Readable.Readable')` if I change it to `const Readable = require('stream').Readable;` or `const { Readable } = require('stream');` I get undefined errors from the stream on iOS: `[TypeError: stream.on is not a function. (In 'stream.on(\"data\", function (chunk) { return chunks.push(chunk); })', 'stream.on' is undefined)]` What am I missing?" + }, + { + "prediction": "Why do we need to make a copy here?", + "reference": "this is needed since the chunk feeder shares memory across calls to the pipeline. this is in order to avoid multiple allocations. this change mimics the behavior of shed and localstore, and copies the data from the call into the in-memory store" + }, + { + "prediction": "nit: I think this should be in the `init` function of the package, not the `init` function of this test file.", + "reference": "wut. We can do this at the beginning of tests if we want right? Why are we depending on init?" + }, + { + "prediction": "I'm not sure if this is the right place to put the lock, but I think we need to make sure that we don't have a race condition where two clients connect at the same time and both try to set `c.acc` to `srv.gacc` at the same time. I'm not sure if this is the right place to put the lock, but I think we need to make sure that we don't have a race condition where two clients connect at the same time and both try to set `c.acc` to `srv.gacc` at the same time. I'm not sure if this is the right place to put the lock, but I think we need to make sure that we don't have a race condition where two clients connect at the same time and both try to set `c.acc` to `srv.gacc` at the same time. I'm not sure if this is the right place to put the lock, but I think we need to make sure that we don't have a race condition where two clients connect at the same time and both try to set `c.acc` to `srv.gacc` at the same time. I'm not sure if this is the right place to put the lock, but I think we need", + "reference": "Same trick here IMO." + }, + { + "prediction": "I think this should be `POINTER` instead of `nil`", + "reference": "Should be `@origin = element || origin || POINTER`" + }, + { + "prediction": "I think we need to check if `options.cstorSPC.spcName != \"\"` and `len(args) != 0` and throw an error.", + "reference": "this example needs a fix?" + }, + { + "prediction": "I think this should be `wlr_xdg_toplevel_send_close(surface);`", + "reference": "Is it safe to assume this surface is a toplevel?" + }, + { + "prediction": "This should be `projCtx pj_ctx_clone( projCtx ctx )`", + "reference": "we don't need that function" + }, + { + "prediction": "I don't think we need to add a new platform for this. We should be able to use the existing `WINDOWS` platform.", + "reference": "we'll also have to think about adding \"Windows Server 2014\" or whatever they come up with later." + }, + { + "prediction": "This method is not used in this PR. Can we remove it?", + "reference": "curious do we have an API to fetch an inactive flow?" + }, + { + "prediction": "I'm not sure why this was here, but it seems like it should be removed.", + "reference": "This branch is not needed anymore because every `vnode` that passes through `h` in compat or core will have the `$$typeof`-property now ." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work for the cases I've tested.", + "reference": "Did you mean to use `hasAttribute`? You shouldn't. This does not improve performance and it messes with the readability." + }, + { + "prediction": "I don't think you need to import `pyqtSignal` anymore.", + "reference": "Please import modules and not classes (except for Qt stuff)." + }, + { + "prediction": "Why is this needed?", + "reference": "Hm... why do we have a \"DummyJavaNode\" in src/main? Looks like, this should have gone into src/test...." + }, + { + "prediction": "nit: I think this should be `// Package v1alpha1` instead of `// Package v1alpha1`", + "reference": "This seems meaningless. If we cannot add any info let us remove this." + }, + { + "prediction": "I think this should be `GetPortBindings` to be consistent with the other getters.", + "reference": "Can you rename `Ports` to `PortsUnsafe`?" + }, + { + "prediction": "Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.", + "reference": "This feels like it could be moved out to your first gem!" + }, + { + "prediction": "Why do we need the `requestId` here?", + "reference": "The expected behaviour for `poll` would be to match what `Deque` does, which is: > Retrieves and removes the head of the queue represented by this deque As such, you shouldn't need the `RequestId` here." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "This is super minor, but it'd be nice if this iterated over an arbitrary number of array inputs." + }, + { + "prediction": "I think this should be `MAX_PATH` instead of `MAXIMUM_PATH`.", + "reference": "What is the problem here? The commit message has strange wording \"readlink is defined with restrict pointers\": do you mean \"restricted\"? Is that a well-defined language term? I'm not sure what it means." + }, + { + "prediction": "This import is not used.", + "reference": "Why are we not wrapping here?" + }, + { + "prediction": "`ParameterFilterData::parameter` can be `null` only if `ParameterFilterData::value` is `null`.", + "reference": "I though that all data objects are being unified in the fashion where all default values are initialized in constructor, are not they?" + }, + { + "prediction": "46508508008000000\",\n \t\"libflux/flux-core/src/ast/visitor.rs\": \"8888888888888888888888888888888888888888888888888888888888888888\",\n \t\"libflux/flux-core/src/ast/walk.rs\": \"8888888888888888888888888888888888888888888888888888888888888888\",\n \t\"libflux/flux-core/src/ast/walk_mut.rs\": \"88888888888888888888888888888888888888888888888888888888", + "reference": "Does this file actually need to be committed to git? Having to run `make generate` is rather tedious on each PR and it conflicts easily." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think we should remove the `GOOGLE_APPLICATION_CREDENTIALS` environment variable from the list of required environment variables in the error message below.", + "reference": "We don't need this anymore, as Google's library handles various auth mechanisms for us. We'll be less explicit about why we're failing but we gain support for several authentication methods- swings and roundabouts!" + }, + { + "prediction": "I think this should be `default:\"/var/lib/kubelet/volumes\"`", + "reference": "No need to speficy attribute here. Moreover in yaml it is default to use lowercase names." + }, + { + "prediction": "nit: I think we can remove this empty line.", + "reference": "In general I'm a trying to understand the reason behind this PR. Looks like if a blob (name) already exists we check if the contents are identical? In what scenarios this is not the case? When we want to publish a package/asset that has changed but still we want to use the same version?" + }, + { + "prediction": "I think we should use `urllib2.Request` instead of `urllib2.build_opener` and `urllib2.urlopen`.", + "reference": "Can rename `req` to be `opener`, since that is the object, and it wraps `req` internally?" + }, + { + "prediction": "This should be `if \"breakpoint\" in attrs:`", + "reference": "@MichaelDCurran, thoughts on adding a breakpoint format field attribute? It seems almost app specific, but I guess it does seem odd abusing line-prefix. Is there any more generic concept here?" + }, + { + "prediction": "I don't think this is correct. `self._execute(Command.GET_ELEMENT_RECT)['value']` returns a dictionary with `x`, `y`, `width` and `height` keys. `self.size` and `self.location` return dictionaries with `x` and `y` keys.", + "reference": "This would return a tuple of two dictionaries. You need to combine them and return a dictionary" + }, + { + "prediction": "nit: can we move this to the top of the file?", + "reference": "What do you think of moving the example to the help text of the prompt? and the prompt itself can be \"What is your application's GitHub repository URL?\"" + }, + { + "prediction": "I think this should be `1593493828_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000_000", + "reference": "Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs." + }, + { + "prediction": "I think this should be `std::distance(first, last) >= 9`", + "reference": "Nice use of std::distance. I'm a bit worried about first += 9 though." + }, + { + "prediction": "I don't think we need to add this label.", + "reference": "Shouldn't this be `app.kubernetes.io/managed-by` as prometheus-operator manages this resource, but this resource isn't a part of prometheus-operator?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the only way to make this work. The problem is that `parent.GetTag(Tags.InstrumentationName)` will return `null` if the parent span was not created by the profiler. In that case, we don't know if the parent span was created by the profiler or not, so we don't know if we should ignore it or not. If we don't ignore it, we will create a new span that will be a child of a span that was not created by the profiler, which is not what we want. If we ignore it, we will not create a new span that will be a child of a span that was created by the profiler, which is also not what we want. So, I think the only way to make this work is to ignore the parent span if it was not created by the profiler. I'm not sure if this is the right thing to do, but I think it's the only way to make this work.", + "reference": "As long as we're being extra-vigilant about NREs, should we check that `httpMethod` and `requestUri` are not null?" + }, + { + "prediction": "I don't think we need to add xrc20 here. xrc20 is a subcommand of transfer.", + "reference": "No need to have `xrc20` alias" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `SystemNamedDict` class itself.", + "reference": "the naming convention I'm been adopting if `_type` for instances of these classes. So maybe `context_config_type` is a better name for this fn" + }, + { + "prediction": "I think this should be `private final Boolean gpuMining = false;` so that it can't be changed after construction.", + "reference": "Don't call it GPU mining, call it `externalMining`, here and throughout." + }, + { + "prediction": "I think this should be `imageMaxHeight` and `imageMaxWidth` instead of `imageMaxWidth` and `imageMaxHeight`.", + "reference": "`within this with` typo, should be `within this width`" + }, + { + "prediction": "I don't think we need to disable openapi-gen for this field.", + "reference": "how come this is false?" + }, + { + "prediction": "I don't think this is necessary.", + "reference": "How about `Object.prototype.toString`? Or using the `typeof` operator?" + }, + { + "prediction": "I think this should be `ctx context.Context` and `cancel context.CancelFunc`.", + "reference": "I know @jzila suggested this, but I disagree: you're really not supposed to save a context in a struct. Can you get by with just saving the `Done()` channel instead? The `ctx` should continue to be passed around explicitly." + }, + { + "prediction": "I don't think this is correct. `PlatformApis.IsDarwin` will be true for both Mono and CoreCLR on Darwin.", + "reference": "This check isn't right though." + }, + { + "prediction": "I think this should be `public abstract String getCodeGenVersion();`", + "reference": "maybe `toolkitVersion` instead? It doesn't necessarily have to be called that in the generated code, but in the view model classes, I think it makes it clearer that it is the version of toolkit itself." + }, + { + "prediction": "`uploadResp` should be renamed to `response`", + "reference": "the response data was added intentionally in #612, i think we could keep the `setFileState` stuff here as a special case, at least for now" + }, + { + "prediction": "I'm not sure about this change. `time.Until(deadline)` will return a negative value if `deadline` is in the past, and `time.After` will block forever in that case.", + "reference": "This isn't really easy to read." + }, + { + "prediction": "nit: can we use `fmt.Errorf` instead of `glog.Errorf` here?", + "reference": "This line changed due to go formatting. Format was not there earlier." + }, + { + "prediction": "I think this should be `upstream.Without` instead of `staticUpstream.Without`.", + "reference": "The name \"Without\" in code is a little nebulous. Maybe something more descriptive like TrimPrefix or StripPrefix or WithoutPathPrefix or something like that. (Thoughts?)" + }, + { + "prediction": "Shouldn't this be a 409 Conflict?", + "reference": "is this test in the move tests? I see what you mean then - it works, but I wonder if we won't lose track that it's being tested here." + }, + { + "prediction": "I think this should be `[]string` instead of `map[string]string`.", + "reference": "I'm not sure if this wanted to be `json:\"tags\"` (which I'd set in my PR) or `json:\"tag\"` that someone elses PR had set. Given that the rest of the fields had their JSON field name set to the same as the struct field name, I opted for `tags`." + }, + { + "prediction": "Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.", + "reference": "since the logic here and in `Proposal` is exactly the same, do you think it makes sense for us to include it elsewhere? I am not opposed to duplicated code when it makes sense, but the reason I first identified this was that I was looking for code in NCR::WorkOrder that was not specific to Work Orders. Seems like fiscal year logic might be helpful for reporting for other clients. In that case, we'd want this scope on those client data classes as well. Might be wrong to include this in the FiscalYear mixin, but it does seem like it should be outside of Proposal and WorkOrder. Does that make sense?" + }, + { + "prediction": "I think it would be better to use `self.connection.add_timeout(5, self.connect_to_rabbitmq)` instead of `connection.add_timeout(5, self.connect_to_rabbitmq)`.", + "reference": "there is no static method as a go between -- how does this work?" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Can you please change the name of this class to be something else?" + }, + { + "prediction": "nitpick: I think it would be better to rename `h2o_next_token` to `h2o_next_comma_separated_token` or `h2o_next_token_with_comma_separator`.", + "reference": "I think we might prefer generalizing the interface rather than creating an exception. Current design of `h2o_next_token` assumes the input to be a comma-separated list, and allows the caller to specify a different separator when parsing a nested list. As I understand, what we are trying to attain in this PR is to have a way of parsing a flat list of semicolon-separated list. Assuming that is the case, I think it would be better to change the API of the function to accept two separators (i.e. inner and outer), where for our existing use-cases `outer` would be `,`." + }, + { + "prediction": "Why do we need this change?", + "reference": "why not recycling? I Lru cache now recycling?" + }, + { + "prediction": "I think this should be `PaymentVersionV2`", + "reference": "Why it is now called `PaymentVersionV3`?" + }, + { + "prediction": "I don't think we need to log all the nodes here.", + "reference": "changed for debug purpose?" + }, + { + "prediction": "Why is this needed? `BaseProvider` already has a `SetParentProvider` method, which is called by `OpenTelemetrySdk.SetParentProvider`.", + "reference": "@cijothomas I needed a way to set the Exporter.ParentProvider when the Processor's gets set. Internal to SDK though." + }, + { + "prediction": "I don't think this is correct. If you are on a motorway and you enter a ramp, you are still on a motorway.", + "reference": "Talking through this scenario with @srividyacb and she's wondering if there should also be a check of `(from_trunk && node_based_graph.GetEdgeData(eid).flags.road_classification.IsLinkClass())` as highways with trunk classifications can also have this scenario." + }, + { + "prediction": "I think this should be `:q_puppetagent_server => master_certname, :q_puppetagent_certname => host_certname,`", + "reference": "where does `master_certname` come from?" + }, + { + "prediction": "Please add a blank line between `SSDVGG` and `HRNet`.", + "reference": "The line breaking is unnecessary." + }, + { + "prediction": "I think we should keep the old behavior, i.e. `\"\\t ,\"`", + "reference": "why not enable split by space here ?" + }, + { + "prediction": "(style) 'value' may be misspelled - perhaps 'val' ?", + "reference": "Shouldn't the operator be && ?" + }, + { + "prediction": "I'm not sure this is the right place to put these methods. I think they should be part of the `Vagrant` class, not the `Beaker::Vagrant` class. The `Beaker::Vagrant` class is just a wrapper around the `Vagrant` class, so it shouldn't have any of its own methods.", + "reference": "My best guess is that you want to use host.name in these parts to get the name of the host ?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the right thing to do. We don't need to know the nodeType when we're unmarshalling the manifest. We only need to know the nodeType when we're marshalling the manifest, and we don't need to know the nodeType when we're marshalling the manifest because we don't need to know the nodeType when we're marshalling the manifest because we don't need to know the nodeType when we're marshalling the manifest because we don't need to know the nodeType when we're marshalling the manifest because we don't need to know the nodeType when we're marshalling the manifest because we don't need to know the nodeType when we're marshalling the manifest because we don't need to know the nodeType when we're marshalling the manifest because we don't need to know the nodeType when we're marshalling the manifest because we don't need to know the nodeType when we're marshalling the manifest because we don't need to know the nodeType when we're marshalling the manifest because we don't need to know the nodeType when we're marshalling the manifest because we don't need to know the nodeType when", + "reference": "IMO this edge case handling could remain here, just instead of overwriting the `n.nodeType`, the `makeEdgeType` method of `n` should be called, so `n.nodeType = nodeTypeEdge` -> `n.makeEdge()`" + }, + { + "prediction": "I think this should be `showAutoDownloadReport || UserPreferences.showDownloadReport()`", + "reference": "Just wondering... The two kinds of notifications are now quite different (Channel, text, maybe even icon). Would it make sense to extract the auto download notification to a new class instead of handling everything in the existing `notificationManager`? I have not checked if this will lead to a lot of code duplication, though." + }, + { + "prediction": "I think this should be `c.ic.req.Features.Clone()`.", + "reference": "Do we need to put this on the Call? We only need the API communication between the Encoding and the Transports which is currently done through the Transport.Request. The Call is used by users right?" + }, + { + "prediction": "I think this should be `status.Errorf(codes.Unimplemented, \"GenerateAPIKey is not implemented\")`", + "reference": "`ctx` is unused in GenerateAPIKey" + }, + { + "prediction": "I don't think this is the right place to log fatal error. I think it should be in the caller of `NewBlockDAO`.", + "reference": "Can you judge the type of error?" + }, + { + "prediction": "I don't think this is correct. `np.convolve(data, [0.5, 0.5], 'valid')` is equivalent to `np.convolve(data, [0.5, 0.5], 'same')[:-1]`", + "reference": "Much simpler than a weird and confusing ``convolve`` call!" + }, + { + "prediction": "I'm not sure if this is a bug or not, but it looks like the Suspender1 and Suspender2 render methods are being called 3 times instead of 2 times.", + "reference": "Huh, this seems weird to me... Surely the suspenders render was called again in order to get the new `
Hello second 2
` output... Imma take a peak at these tests to understand what's going on" + }, + { + "prediction": "Trailing whitespace detected.", + "reference": "Since this is just a helper function to create text, perhaps this could live in a helper? I noticed that we have a few other error/message creators in the application controller as well, but I think this type of function should be re-factored to be part of a helper." + }, + { + "prediction": "I don't think this should be changed.", + "reference": "Will this mess up parsing the messages by other editors? (vscode, vim ...)" + }, + { + "prediction": "Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", + "reference": "Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." + }, + { + "prediction": "I'm not sure if this is the right place to return the block to the pool, but it seems to be the only place where we can guarantee that the block is no longer in use.", + "reference": "Why can the pool be null?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to add a `readonly` attribute to the `List` class, and then override `_get_states` to add `controlTypes.STATE_READONLY` if `readonly` is `True`.", + "reference": "It might be good to have a note here: > work-around for issue #7562 allowing us to differentiate presentational lists from interactive lists (such as of size greater 1 and ARIA list boxes). In firefox, this is possible by the presence of a read-only state, even in content editable." + }, + { + "prediction": "This should be `Set>`", + "reference": "This set of changes is the one part of this that I'm not completely sure is valid. Can someone look over this to make sure I got the E's right?" + }, + { + "prediction": "I think this should be `pull.frontier.is_zero ()` instead of `pull.head.is_zero ()`", + "reference": "There doesn't seem to be a reason to copy this here." + }, + { + "prediction": "I don't think we need to include `h2o/ebpf.h` here.", + "reference": "We've avoided including h2o headers in BPF programs because it's a runtime dependency. However, IIRC, this is because h2olog was maintained in the separate repository so that h2olog did not know where h2o was installed. Now h2olog can use `H2O_ROOT`, we should add it to BCC's `cflags` in order to include h2o headers in BPF programs." + }, + { + "prediction": "I think this should be `AlertQueryURL` to be consistent with the rest of the struct.", + "reference": "I think the docstring here should include the CLI arg `--alert.query-url` just to make it clear to users which setting this uses." + }, + { + "prediction": "nit: I think we can remove the `m.externalNodeCIDRs` field from the `ipipManager` struct, since it's only used here.", + "reference": "Same change just above?" + }, + { + "prediction": "I'm not sure about this test. I think it should be `expect((await engine.search('n')).length).toBe(2);` and `expect((await engine.search('\u043b')).length).toBe(2);`", + "reference": "Could you check the result content rather than just the number of search results please? For example with this test if the search engine suddenly starts returning \"latin n\" for both queries, we won't know about it." + }, + { + "prediction": "nit: I think it would be nice to have a constant for the `example.org` domain. It's used in a few places in this file.", + "reference": "nit: I think that `workloadID` should suffice for this test... that's what we'd be issuing anyways" + }, + { + "prediction": "Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.", + "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." + }, + { + "prediction": "I don't think we should catch `NoClassDefFoundError` here. It's a subclass of `LinkageError` which is a subclass of `Error` which is a subclass of `Throwable` which is a subclass of `Exception` which is a subclass of `Throwable` which is a subclass of `Object` which is a subclass of `Serializable` which is a subclass of `Cloneable` which is a subclass of `Runnable` which is a subclass of `Thread` which is a subclass of `Object` which is a subclass of `Serializable` which is a subclass of `Cloneable` which is a subclass of `Runnable` which is a subclass of `Thread` which is a subclass of `Object` which is a subclass of `Serializable` which is a subclass of `Cloneable` which is a subclass of `Runnable` which is a subclass of `Thread` which is a subclass of `Object` which is a subclass of `Serializable` which is a subclass of `Cloneable` which is a subclass of `Runnable` which is a subclass of `Thread` which is a subclass of `Object` which is a subclass of `Serializable` which is a subclass of `Cloneable` which is a subclass of `Runnable` which", + "reference": "We should have a rule to detect identical catch branches" + }, + { + "prediction": "Why are these removed?", + "reference": "remove these from the targets file." + }, + { + "prediction": "why is this removed?", + "reference": "now that we have the signature in the hive messages, it might be that this must be drastically reduced, since there are limits on the protobuf reader/writers i believe" + }, + { + "prediction": "Can you update the version of `google-auth-httplib2` to `0.0.4` as well?", + "reference": "I recommend that we move this to be optional, as other users might not need it. Can you look at `OPTIONAL_PACKAGES` section, around line 68?" + }, + { + "prediction": "Please revert this change.", + "reference": "I usually set idea to never use wildcard import such as `import java.util.*;` Now i use setting from javaslang standard." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Where is host['ips'] coming from?" + }, + { + "prediction": "I don't think we need to return anything here.", + "reference": "oh! missed a `:` here; let me fix that; also can get rid of the intermediate variable" + }, + { + "prediction": "Line is too long. [84/80]", + "reference": "Is this necessary?" + }, + { + "prediction": "I don't think we need to import `makeLogin` and `isTokenExpire` here.", + "reference": "I'd create a different method for each render section." + }, + { + "prediction": "I think it would be better to make this a field of the `OperationTracer` interface, and have all implementations set it to `false` by default, and then override it in `EstimateGasOperationTracer` to be `true`.", + "reference": "Instead of storing the revert flag in the tracer is it possible to use org.hyperledger.besu.ethereum.mainnet.TransactionProcessor.Result#getRevertReason? (via org.hyperledger.besu.ethereum.transaction.TransactionSimulatorResult#getResult)? If a TX reverts without a reason do we get an empty revert reason or a revert reason with zero bytes?" + }, + { + "prediction": "I think we can remove the `readOrcSchema` parameter from the `SparkOrcReader` constructor.", + "reference": "I think this should test with and without container reuse if that is implemented in this PR. Probably just make this test parameterized." + }, + { + "prediction": "I think this should be `fromProjectionPos[i] = 13;`", + "reference": "These modifications allow BaseFile to translate into a SparkRow with the specID as a column" + }, + { + "prediction": "I think we can remove the `typeof` check and just do `return new ReadPreference(readPreference);`", + "reference": "is this something we've been missing this whole time?" + }, + { + "prediction": "I think this should be `allEvents` instead of `AllEvents`", + "reference": "nit: this is a package-wide constant so better to narrow the scope like `allEventsSign`." + }, + { + "prediction": "I think this should be `auth_thrift = os.path.join(thrift_files_dir, 'authentication.thrift')`", + "reference": "There seems to be some repetition. Does a local function make this code shorter overall?" + }, + { + "prediction": "I think this should be `isHydrating = true;`", + "reference": "Might be cheaper to reuse the `null` assignment of line 313 and set `isHydrating` to null instead WDYT?" + }, + { + "prediction": "nit: remove empty line", + "reference": "Revert this blank line" + }, + { + "prediction": "I don't think we need to clear the properties here.", + "reference": "This was introduced recently for the Hadoop 3 upgrade. Copy/paste error but definitely causing some of the new test failures." + }, + { + "prediction": "Metrics/LineLength: Line is too long. [118/100]", + "reference": "I think we should only need to do this for `:approve` since we are using `authenticate_user!` for all other actions and that checks for disabled client" + }, + { + "prediction": "I don't think this is a good test. If you want to test that the response has a `Content-Length` header, you should use `resp.headers.get('Content-Length')` and assert that it is not `None`.", + "reference": "I wonder if we should create new tests for header checks; here for instance we're mixing querystring and headers. Thoughts?" + }, + { + "prediction": "I think this should be `apply::helpers::custom_facts`", + "reference": "We should be able to add sensitive by hard-coding the parameters, same as you put into the metadata in apply_helpers." + }, + { + "prediction": "This file is empty, so it can be removed.", + "reference": "Why do you think that it is necessary to create this class?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I don't think we should ignore errors here.", + "reference": "replacing the `1` with `io.SeekCurrent` may be good here" + }, + { + "prediction": "I'm not sure this is the right place for this interface. I think it would be better to have it in the `jwks` package and have the `jwks` package implement this interface.", + "reference": "nit: perhaps this file would be better named `jwks_source.go` ?" + }, + { + "prediction": "I think this should be moved to `AzkabanCommonConfigurationKeys`.", + "reference": "It will be helpful to specify the intended priority as well for the properties within this file." + }, + { + "prediction": "nit: I think we can just use `func(*exec.Cmd) ([]byte, error)` instead of defining a new type.", + "reference": "Make this private and update all the public functions to not take this argument. The variable you set below should also be private, then in the tests instead of passing the variable in to the function just update the variable. We don't want to expose the testing implementation in the public api if it can be avoided." + }, + { + "prediction": "I think this should be \"/user/trafodion/hive/tpcds/customer/customer.dat\" instead of \"/user/trafodion/hive/tpcds/customer/customer.dat\"", + "reference": "Do you now why is it a specific table name is used as a default?" + }, + { + "prediction": "I think this should be `Path.Combine(Environment.GetEnvironmentVariable(\"HOME\"), \"myagent/_work/_temp\")`", + "reference": "If all you're doing is checking for the existence of a directory as your \"temp\" directory, why does it matter what OS you're on?" + }, + { + "prediction": "I think we can remove the `v2` import here and just use `generated` everywhere.", + "reference": "nit- would be cleaner to import it once" + }, + { + "prediction": "I think this should be `x-amz-user-agent, x-amz-date, x-amz-security-token, x-amz-content-sha256, authorization`", + "reference": "Looks like there is a closing parenthesis `)` missing here." + }, + { + "prediction": "I don't think you need the `128` here. The `str` array is already declared as `char str[128]`.", + "reference": "this one bothers me. There are many places where this one is written to for an error message and just a single callsite is changed." + }, + { + "prediction": "I don't think this is necessary.", + "reference": "You can put this in `kbfsOpsInit()` in you want, so we don't have to call it in every test." + }, + { + "prediction": "I don't think we need the `#ifdef ARM_32` here. The `#ifdef ARM_32` is already in the `#if defined(AARCHXX)` block.", + "reference": "`ARM_32` is what clients define as an input to DR, and is not always defined internally: we use just `ARM` to mean AArch32." + }, + { + "prediction": "I think we can remove this field. It's only used in the `toString()` method, which is only used for debugging, so we can just use `schema` instead.", + "reference": "s/for use/to use for/" + }, + { + "prediction": "Shouldn't this be `avatar_id` instead of `avatar_filename`?", + "reference": "` $event->getAvatarFilename()` this function return `string` or `null`. In this place ` $event->getAvatarFilename()->getValue()` return `Fatal error `" + }, + { + "prediction": "I don't think we should change this to unavailable. This is not a transient error, it's a permanent one.", + "reference": "why not creating a new error type for server's own resource limit exceed error and do conversion within rpc interceptor?" + }, + { + "prediction": "I think this should be `Propagators.DefaultTextMapPropagator.Value`", + "reference": "Could be a timing thing here. When options are created they'll copy the ref for the current default propagator. If user sets through SDK the global propagator after that, it won't be reflected. Could leave it null here and then when it is used in instrumentation do `options.Propagator ?? Propagators.DefaultTextMapPropagator`. It would be a slight perf hit but it makes it hot-swappable." + }, + { + "prediction": "I think this line is not needed anymore.", + "reference": "Unrelated file. Please remove from PR." + }, + { + "prediction": "I think this should be `send_worker_msg(q, w, \"Access-Control-Allow-Origin: *\\n\\n\");`", + "reference": "Careful: you only want two newlines after the final header message. (That indicates the end of headers and the start of data.)" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in `mitmproxy/proxy/protocol/http.py` in the `handle_request` method.", + "reference": "This will not work on Python 3 (to which we are transitioning) because `.content` is bytes, not a str. Can you make the pattern a bytes object as well (like so: `b\"pattern\"`)?" + }, + { + "prediction": "I think this should be `requiredOwned: ['textbox', 'listbox', 'tree', 'grid', 'dialog'],`", + "reference": "This was to allow the tests to pass when the order of the required was different. Silly, but we don't have an easy way to check for \"equal but order doesn't matter\" in chai." + }, + { + "prediction": "I don't think you need to create a new CostMethodHbaseDelete for each HbaseDelete. I think you can just create it once and reuse it.", + "reference": "maybe say \"returns the default cost method that returns an object of cost 1\"." + }, + { + "prediction": "@danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship @danwinship", + "reference": "I believe these rules will be enforced both (1) on egress from a local workload, and (2) on ingress **to** a local workload. Right? I understand that we definitely want (1), but do we really want to enforce (2) as well?" + }, + { + "prediction": "I think this should be `response.asString()` instead of `response.fullResponseAsJSONObject()`.", + "reference": "Use `response.asJsonObject()` instead. Also, use `put()` instead of `putOpt()`, `null` as a value is fine." + }, + { + "prediction": "Why is this change needed?", + "reference": "Are you sure? We've changed it during an introduction of the IME support." + }, + { + "prediction": "I think this should be `!empty($dqlFilter)`", + "reference": "I think here we want the use of `empty()` to take care of empty strings. If you put `dql_filter: ''` in your YAML config ... this will add `->andWhere('')` and it will fail, right?" + }, + { + "prediction": "I think we should keep the `err` variable here, and return `err` at the end of the function.", + "reference": "this is golang's named return, err is defined, `return` is equivalent to `return err` the current code has no problem" + }, + { + "prediction": "I think this should be `(nullable)` instead of `(allow-none)`.", + "reference": "I don't think this is right; in Rust terms it's like a `&mut String`, in Java `StringBuilder` - it's not a return value from the function which is what `(out)` is for." + }, + { + "prediction": "I think it should be `(labels >= 1) & (labels < label_channels)`", + "reference": "If the label is not binary, should we rename this function?" + }, + { + "prediction": "I don't think you need to use BeanShell for this. You can just use `${__BeanShell(File.separator, )}`.", + "reference": "This is very-very bad idea because of its performance impact" + }, + { + "prediction": "Please remove empty line.", + "reference": "WHY U NOT SORT IMPORTS?" + }, + { + "prediction": "I'm not sure if this is the right place to put this helper method, but I think it makes sense to have it in the `SignInRequestHelpers` module since it's related to the sign in request.", + "reference": "Put a comma after the last item of a multiline hash." + }, + { + "prediction": "I think this should be `from .core.dimension import Dimension, Dimensioned`", + "reference": "How come we need ``Dimensioned`` in the top-level namespace?" + }, + { + "prediction": "Please revert this change. It's unrelated to the PR.", + "reference": "excess whitespace through plugin." + }, + { + "prediction": "Why is this change necessary?", + "reference": "What is the problem here? I feel we used this in a lot of places." + }, + { + "prediction": "I think it is better to use `torch.stack(proposal_list).cpu().numpy()` instead of `[proposal.cpu().numpy() for proposal in proposal_list]`", + "reference": "Update the docstring." + }, + { + "prediction": "I think we can remove this import.", + "reference": "delete the empty line \"github.com/pkg/errors\" should be grouped with other third party packages same for the rest" + }, + { + "prediction": "I think this should be `this.capabilities = capabilities == null ? new ImmutableCapabilities() : new ImmutableCapabilities(capabilities);`", + "reference": "Assigning capabilities to the field here is not the best idea. Semantically this field contains the capabilities returned by the browser after session start. So here we sould better amend capabilities and return them from `init` method to pass later to `startSession` method (that will assign the capabilities returned by the browser to the field)." + }, + { + "prediction": "I'm not sure why this alias was added in the first place. I don't see it being used anywhere.", + "reference": "Is this a breaking change, or is the API private?" + }, + { + "prediction": "I don't think you need to do this. You can just do `test_data = pd.read_json(\"./dumps/courseData.json\").groupby('model').apply(lambda x: x.groupby('pk')['fields'].apply(list).apply(lambda x: x[0]).to_dict())`", + "reference": "I don't think we need this dependency in this project right now" + }, + { + "prediction": "I think this should be `knative-eventing` instead of `cloud-run-events`", + "reference": "I don't think this is necessary since `CommonLabels` is a public func and every component name is also public constant." + }, + { + "prediction": "I don't think we need to add the `-r puppet` to the example.", + "reference": "The `_example` field should be updated to include an interpreter with an array value." + }, + { + "prediction": "I don't think we need to do this.", + "reference": "Put this in the godoc of SupportedProtocols instead. Preferably we would just use one map though. Why not just use this one?" + }, + { + "prediction": "Why is this change necessary?", + "reference": "I'd feel a little safer if the first argument were a string, not a *string unless there's a particular reason for making it a pointer." + }, + { + "prediction": "This import is not used.", + "reference": "Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC." + }, + { + "prediction": "This import is not used.", + "reference": "You can safely revert changes to this file." + }, + { + "prediction": "This is a syntax error.", + "reference": "This deletion is unnecessary." + }, + { + "prediction": "I think this should be `smallImage && typeof smallImage === 'string'`", + "reference": "I'm not a huge fan of this overloading of the prop; accepting very different types of arguments for props like this can be confusing, and wasn't part of the IB. I understand wanting to import the SVG directly, but the IB suggests using `${global._googlesitekitLegacyData.admin.assetsRoot}${userInputSuccessImage}` as the `src`/`smallImage` value here. It'd be great to refactor this to accept components directly in the future, but let's do that all-at-once rather than this hybrid approach that makes the API less clear." + }, + { + "prediction": "I think we should avoid importing `java.util.*` and instead import only the classes we need.", + "reference": "I've had this happen recently with IntelliJ, was this intentional?" + }, + { + "prediction": "I don't think you need to include hash_util.h here. You can just use std::hash.", + "reference": "Order(1) vs Order(logN) -- not sure it's measurable at the ~200 element size of the table. All of the published comparisons start at ~1000 elements." + }, + { + "prediction": "I think it's better to use `github.com/mysteriumnetwork/node/core/location/factory` instead of `github.com/mysteriumnetwork/node/core/location/factory/factory`", + "reference": "I don't know about this aliasing and 'factory'. Previous version was rather straightforward: `location.CreateLocationResolver`. Perhaps `location.CreateResolver` would be even better? What do we actually gain here from moving DI to a separate sub-package?" + }, + { + "prediction": "I think this should be `engineType + \" child class is not implementing this function\\n\");`", + "reference": "Use `UpperCamelCase` for function names" + }, + { + "prediction": "I think this should be `Number(value) <= 275761`", + "reference": "I'm not 100% sold on this idea but I like it in general. Nice compromise between using the 'Date' constructor where possible and falling back to the pre #5880 behavior when it makes sense. However, instead of `Number(value) < 0`, let's do `Number(value) < MIN_YEAR` because `new Date('-2017')` is perfectly valid in JS and I don't want to break the date behavior." + }, + { + "prediction": "I don't think we need to do this. The `ZkStateReader.CLUSTER_STATE` constant is only used in `ZkStateReader` and `SolrZkClient`, both of which have been removed from the codebase.", + "reference": "Remember to close SOLR-11877 after this" + }, + { + "prediction": "I'm not sure about this change. I don't think we want to remove the `.` and `,` from the list of ignored characters.", + "reference": "this change should be reverted" + }, + { + "prediction": "I don't think we need this method at all. I think we can just remove it from the interface.", + "reference": "This function signature is a bit complicated, some parameters are IN type (stopLoop which is modified from outside), others are OUT (registeredEvent channel which is modified inside function) I suggest the following signature -> SubscribeToRegistrationEvent(identityAddress) returns registeredEvent chan of type (RegisteredEvent not int), Unsubscribe func(), error (in case of any error). That way caller can always cance subscription if needed and check for any errors. Also - unsubscribe function hides any internal details how subscribtion is really implemented" + }, + { + "prediction": "I don't think we should add this here. This is only used for the e2e tests, and we don't want to include this file in the e2e tests.", + "reference": "`.wav`?! cannot we use something slightly more modern and compressed instead? :) I dunno, like `.mp3` or `.aac` or `.ogg`..." + }, + { + "prediction": "This should be `luaA_object_push(L, swap);`", + "reference": "Wouldn't a single signal call be enough? (without the boolean even)" + }, + { + "prediction": "I don't think we need the ` ` here.", + "reference": "I suspect that this whole block, which is going to be repeated a number of times, should probably be in a helper. I guess it would need to be given the object and the title and could probably figure out everything else from that?" + }, + { + "prediction": "Style/TrailingWhitespace: Trailing whitespace detected.
Metrics/LineLength: Line is too long. [114/100]", + "reference": "Should we expose this attribute in the Asciidoctor.js API ?" + }, + { + "prediction": "I think this should be `Objects.equals(v, element._2)`.", + "reference": "I think contains on `Multimap` was broken - it should return true if one of the values is associated with the key? It that right" + }, + { + "prediction": "I think the default value should be 10.", + "reference": "delete this line" + }, + { + "prediction": "Metrics/LineLength: Line is too long. [85/80]", + "reference": "Presumably we no longer need `force: true` here." + }, + { + "prediction": "I don't think you need to check for `NULL` here. `ptr` is a pointer to a pointer, so it will never be `NULL` or `0`.", + "reference": "HIP runtime is compiled using a C++ compiler. So comparison to both NULL as well as 0 does not make sense. Just comparing to NULL is sufficient." + }, + { + "prediction": "I don't think we need to pass in `help_url('')` here, it will default to `help_url` without an argument.", + "reference": "these urls are still in `a` tags so we should probably include these links separately for a non-HTML version" + }, + { + "prediction": "I don't think we need to release the lock before calling `addSystemAccountExports` and `sys.resetCh <- struct{}{}`.", + "reference": "That's fine though, meaning that you can send to this channel under the server lock. The internalSendLoop will pick up the change when the server lock is released (if loop is blocked trying to grab the server lock). Even the way you do it here (releasing the lock, sending, then reacquiring) does not guarantee that the internalSendLoop will have time to refresh in that interval." + }, + { + "prediction": "This should be `CHROMIUM_ENABLE_DOWNLOADING`", + "reference": "The name `enableDownloading` implies this is a boolean capability. How about `downloadDir`?" + }, + { + "prediction": "I don't think we should deprecate this method.", + "reference": "Found one internal team is using this method. Will coordinate with them about the migration solution." + }, + { + "prediction": "I think this should be `DD_TRACE_HTTP_SERVER_ERROR_STATUSES` and `DD_TRACE_HTTP_CLIENT_ERROR_STATUSES`", + "reference": "The field `HttpServerErrorCodes` should be called `HttpServerErrorStatuses`" + }, + { + "prediction": "I think this should be `FORSETI_V2_RULE_FILES` and `FORSETI_V1_RULE_FILES` should be renamed to `FORSETI_RULE_FILES`.", + "reference": "Can you please make each of these in a separate line. It will be easier to keep them sorted, and add/remove." + }, + { + "prediction": "I don't think this is correct. The cleanup flag should be passed to the `createBaseZnode` method, not to the `createConfigSet` method.", + "reference": "should we error instead of silently ignoring the `cleanup` param? it defaults to `false`, so someone must have explicitly set it to `true`" + }, + { + "prediction": "I think this should be `archive.File[0].FileInfo().Name()` instead of `archive.File[0].Name`", + "reference": "There is no specific requirement that the root be called `root`, just that there is a single root directory and that it be the first entry in the zip." + }, + { + "prediction": "I'm not sure if this is the right place to put this, but I think it makes sense to show the profile warning on all pages except the user's own profile page.", + "reference": "perhaps we should encapsulate this logic in a helper method w a test?" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Now that we're only using this repo as a Gem you shouldn't need to `require` an expanded local file path like below." + }, + { + "prediction": "I don't think you need to cast to `Long` and then back to `Integer`.", + "reference": "This isn't necessarily a year. It may be months, days, or hours. Can we return `intValue()` directly instead?" + }, + { + "prediction": "Why remove this log statement?", + "reference": "this is redundant because it gets logged immediately on entering the handleContainerChange function" + }, + { + "prediction": "I think this should be `e == model.NotificationEventType_EVENT_DEPLOYMENT_WAIT_APPROVAL.String()`", + "reference": "`ds.GenericDeploymentConfig.DeploymentNotification` in L128 is nullable." + }, + { + "prediction": "Why do we need this?", + "reference": "this shouldn't be exposed here - this class isn't a carriage for this - its used internally to determine if/how we can mine." + }, + { + "prediction": "I'm not sure if we want to do this, but I think it's a good idea to make sure we don't accidentally pass `null` to `installExtension` or `uninstallExtension`.", + "reference": "It's fine to leave these checks in. It'll make the exception come from `FirefoxDriver`, and that's probably clearer to a user." + }, + { + "prediction": "Style/EachWithObject: Use `each_with_object` instead of `each` with a `result = {}` initializer.", + "reference": "We don't want to include the `IntegrationSpecHelper` for models...mind moving this line out of the loop to be `config.include EnvironmentSpecHelper, type: :model`?" + }, + { + "prediction": "I'm not sure why this is necessary, but it seems to be required for the test to pass.", + "reference": "Please check the return on these." + }, + { + "prediction": "I think this should be `if (uplink && uplink.config && uplink.config.cache) {`", + "reference": "Do we need `==` for true?" + }, + { + "prediction": "I think we should keep the default value as 0.0002.", + "reference": "Changing the default value may cause BC-breaking. Suggest changing this value in config." + }, + { + "prediction": "I don't think this is correct. `slider_pos` is a `float`, so `int(slider_pos)` will always be `0`.", + "reference": "how does that happen?" + }, + { + "prediction": "I don't think you need to import `doctest` here.", + "reference": "This is gross/clever. :-)" + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "Take a look at the name of this file. Definitely copy and" + }, + { + "prediction": "nit: can we use `return err` instead of `return` here?", + "reference": "Can you check with @mahebbar how to work this error. Should be different from 404." + }, + { + "prediction": "I don't think we need to remove the upper bound here. I think it should be `>=3.5,<3.9`", + "reference": "Do we still need the upper bound `<3.9`?" + }, + { + "prediction": "I don't think we need to check for `psalter` here.", + "reference": "Does this mean `vendor/bin/psalm` is not a symlink (or whatever equivalent Windows has for symlinks) on Windows?" + }, + { + "prediction": "I think we can remove this file.", + "reference": "@lpabon having a separate package name `aws_test` allows to test the package as if the tester was an external package. If the test package name is the same as the package being tested, the test package can also use methods and variables not exposed to the eventual user." + }, + { + "prediction": "Why are these removed?", + "reference": "The exporter should still be able to test these histogram instrument kinds, right? Is there another reason to remove these?" + }, + { + "prediction": "I don't think we need the `validateTxnBytes` parameter here.", + "reference": "should this increment eval.Round somehow?" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Although this change looks good. Maybe there are other inconsistent cases too?" + }, + { + "prediction": "Style/AccessorSyntacticSugar: Use attr_reader instead of a class method with only a getter.", + "reference": "This is a way better method name." + }, + { + "prediction": "I'm not sure if this is the right place to put this, but I think it would be nice to have a `t(\"marketing.show.language_flash\")` in the `marketing.en.yml` file.", + "reference": "Prefer single-quoted strings when you don't need string interpolation or special symbols." + }, + { + "prediction": "I don't think this is necessary. `Array.isArray` will return `false` if `options` is `null` or `undefined`.", + "reference": "I was wondering if this should allow per role specification, instead of (or in addition to) a generic \"allowed everywhere\". So you could do: `{ separator: ['aria-valuenow', 'aria-valuemin', 'aria-valuemax'] }`. You could still allow the array, and you could add a wildcard option for the \"generic\" case you've got now: `{ '*': ['always-allowed'] }`." + }, + { + "prediction": "I don't think we need to set this to FALSE here. It will be set to FALSE in the constructor of the base class.", + "reference": "I'm confused by the name. The string was a Hive string but it isn't any longer? Why should we care? (I imagine I'll find the answer later... there is some different semantic that we want downstream...)" + }, + { + "prediction": "I don't think we should be importing `org.openqa.selenium.remote.tracing.*` here.", + "reference": "Could you please leave the explicit imports?" + }, + { + "prediction": "why change the import name?", + "reference": "Why need alias?" + }, + { + "prediction": "I think this should be `return c.tlfIDGetter`", + "reference": "Shouldn't this be a `libfs.nullIDGetter` (exported, of course)?" + }, + { + "prediction": "I don't think we should be showing the size of the program in the error message. The user doesn't need to know the size of the program, they just need to know that the program is too large.", + "reference": "I dislike the messages.go pattern; the strings are only used once and make more sense in context. The other two added reportErrorf() calls in clerk.go have inline strings." + }, + { + "prediction": "why remove these two lines?", + "reference": "Seems we don't need it anymore." + }, + { + "prediction": "I think this should be `if: :published?` instead of `unless: :published?` since we want to validate the presence of `themes` only when `published` is true.", + "reference": "This might cause problems with the weird way we publish Guidance and Groups in the UI. We will have to make sure that UAT is thorough." + }, + { + "prediction": "I don't think this is a good default. I think it should be 10s or 30s.", + "reference": "this default needs to be on order 1 minute, I'm not sure why we defaulted to 1 hour below..." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in `caddy/caddy.go` in the `caddy.NewReplacer()` function.", + "reference": "I figure to make `{env.*}` work, right? I can't think of any other placeholder that makes sense here" + }, + { + "prediction": "Why do you need to change the port?", + "reference": "Why change the port from 0 to getAvailablePort()?" + }, + { + "prediction": "I don't think this is the right way to do it. I think we need to add a `timeout` parameter to the `get_locator` method and use that instead of hardcoding 30.0.", + "reference": "For me would be great don't repeat timeout sending in every get_locator call. Looks like it should be sent into LocatorsManager init. And possibly it should me non mandatory, something like that: `def __init__ (self, locators, timeout=60):`" + }, + { + "prediction": "I think we can remove the `projectName` field from the `GlobalOpts` struct. We don't use it anywhere.", + "reference": "I feel like since now we don't initiate the `opts.projectName` with `opts.ProjectName()`, which means `opts.projectName` and `opts.ProjectName()` they don't necessarily equal to each other, we need to also substitute all usage of `opts.ProjectName()` within `Ask()`, `Validate()`, and `Execute()` to `opts.projectName`. Otherwise if `-p` is set, `opts.ProjectName()` will get expired." + }, + { + "prediction": "I don't think we need to check for `null` here. If `bytes` is `null` then `bytes.Length` will throw `NullReferenceException`.", + "reference": "why do we thinkg that an empty string is ok to return from this method? I think the null should never be passed in here in the first place" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "nit: can remove this `else` since we return from the condition above." + }, + { + "prediction": "Why is this removed?", + "reference": "You missed `Write(...)`! I'm kidding ofc." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but I think it's better to be explicit about the fact that we don't want to do anything if `subscription.stripe_customer_id` is `nil` or an empty string.", + "reference": "Was there a customer who had this set to an empty string?" + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.", + "reference": "I know we have the `reporter` spec below, but what about a unit test for this to explain reasoning behind logic? If I were going to update this decorator, I would assume it wasn't covered by tests because there is no unit test." + }, + { + "prediction": "I don't think we should add this method to this interface. I think it should be added to the `RestClientRequestImpl` class.", + "reference": "it's better to be : void attach(String name, Part part);" + }, + { + "prediction": "Please add throws IOException to this method as well.", + "reference": "I didn't see where the IOException can get thrown, is this just to match the V1 reader?" + }, + { + "prediction": "Why is this parameter not used anymore?", + "reference": "We normally suppress this warning with `RDUSED_PARAM(forceRDKit)`" + }, + { + "prediction": "I think this should be `auto it = mappedPlayerGuids.find(guid); if (it == mappedPlayerGuids.end()) { return nullptr; } return it->second;`", + "reference": "What if `Game::getPlayerByNameWildcard` had not been called before. It would not find a player, wouldn't it?" + }, + { + "prediction": "I think this should be \"Requires Patch\" instead of \"Patch Required\".", + "reference": "Why upper case \"R\"?" + }, + { + "prediction": "nit: I think we can remove the `required` variable and just return `mf.BuildRequired()`.", + "reference": "Does this need to return an error or could it return `false, nil`?" + }, + { + "prediction": "I don't think we need to make this protected.", + "reference": "Can you not change those scopes in public API classes? This applies here and in other places -- protected changed to package-scope for source is not really an API-compatible change." + }, + { + "prediction": "I don't think we should remove the default value here. If the parameter is not set in the URL, it should default to 1.", + "reference": "this parameter is only used in POST, please use `getRequest()->request->get('...');` Thanks" + }, + { + "prediction": "I don't think this is correct. `validatePackage` expects a package name, not a filename.", + "reference": "Problem number 1: Scoped packages would have a `/` character here. Changing this to `validatePackage` resolves the 403." + }, + { + "prediction": "I'm not sure this is the right thing to do. If the key is not valid, it should raise an error, not silently ignore it.", + "reference": "I don't quite get why there would be key errors: ``deep_mapped`` is a clone of ``self`` and ``k`` comes from ``self.items()`` so why would the key ever be rejected?" + }, + { + "prediction": "I think this should be `if req.ChainID != 0 && _, ok := registry.Chains()[req.ChainID]; !ok {`", + "reference": "this chain ID determines only from which chain to withdraw, therefore your changes do not accomplish what you want them to accomplish. You'll need changes to `func (aps *hermesPromiseSettler) Withdraw(chainID int64, providerID identity.Identity, hermesID, beneficiary common.Address) error`. The method probably has to include two chain ids: to and from. Currently, the method internally uses: `aps.config.L1ChainID` -> the chain to withdraw to `chainID` -> the chainID that was passed as the chain that the withdrawal is originating from." + }, + { + "prediction": "I think this should be `return ctx` instead of `return ContextWithRemoteSpanContext(ctx, sc)`.", + "reference": "If instead we had `TraceContext.extract` return a bool value as a second return value, we could avoid the byte array comparison in `TraceID.IsValid`. Did you consider that alternative?" + }, + { + "prediction": "I think this should be `paginated = false` by default.", + "reference": "here shouldn't we use `depotFreeLimit`?" + }, + { + "prediction": "Line is too long. [82/80]", + "reference": "Could we use the Rails application's secret token instead? Do we actually need our own here?" + }, + { + "prediction": "`lambda: kdf.a.groupby(kdf.a, kdf.b))` -> `lambda: kdf.a.groupby(kdf.a, kdf.b)`", + "reference": "so should be fixed here also" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think it would be better to just return false and let the caller know that the mcontext isn't fully filled in.", + "reference": "I would just remove this assert as it's going to get un-maintainable with a long list of valid sizes. Ditto below." + }, + { + "prediction": "I think this should be `/var/lib/ecs/` instead of `/var/lib/ecs`", + "reference": "`HostDataDir` is misleading. Can we rename it to something more relevant ? The constant should also be moved up and reused as necessary." + }, + { + "prediction": "I think this should be `ipsecESPHeaderOverhead` and `ipsecESPTrailerOverhead`.", + "reference": "I still feel like we are double-counting the outer IP header here (once in `defaultMTUGRE` and once in `ipsecESPOverhead`) but I'm not that familiar with IPsec." + }, + { + "prediction": "I think this should be `where T : unmanaged` instead of `where T : struct`.", + "reference": "Not sure what benefit we gain by extending BaseProcessor here, as this seems to be defining a new OnEnd method. Could we modify MeasurementItem to have all the things, and then MeasurementProcessor can be simply extending BaseProcessor (not blocking. just noting some observations in the PR :) )" + }, + { + "prediction": "I think we can remove this empty line.", + "reference": "This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards." + }, + { + "prediction": "I don't think this is correct. If you configure a request logger, it will log all requests, including health checks. If you don't want to log health checks, you need to configure a request logger that doesn't log health checks.", + "reference": "This seems like a more appropriate message under `ListenAndServe`. WDYT?" + }, + { + "prediction": "Why is this not needed anymore?", + "reference": "Is this not required?" + }, + { + "prediction": "Missing backtick at the end of the line.", + "reference": "We should start thinking of an object that encapsulates this information :) we might need more arguments in the future." + }, + { + "prediction": "This should be `01173` and `01174`, not `01174` and `01173`.", + "reference": "Given that we are (conceptually) searching across multiple self-dependencies, all we can say is that we didn't have a self dependency in which *both* source and dest masks were correct. Since the spec doesn't imagine this case, the valid usage statement assume we can differentiate only wrong source from only wrong dest within a *single* self-dependency -- which we can't across multiple (at least not meaningfully)... so we always return both the source/dest VUID's if we can't find a self-dependency in with *both* are correct." + }, + { + "prediction": "`isMining` is not the same as `isRunning`. `isMining` means that the node is actively mining a block, while `isRunning` means that the node is configured to mine blocks. I think we should rename `isMining` to `isMiningActive` and `isRunning` to `isMiningEnabled` or something like that.", + "reference": "rename? MiningCoordinator always exists" + }, + { + "prediction": "This is not the correct way to get the config. You need to use the `config` object that is passed to the `init` function of the plugin.", + "reference": "Here would be the same case you don't need to call `loadConfigs`, but you would need to reread configs using `getConfig` on each getHost function call, not once per file." + }, + { + "prediction": "I don't think we need to lock here, since we already have a lock on the folder.", + "reference": "Unlocking with defer means that this lock is still held curing the call to forgetNode(), below, which I see attempts to acquire `f.mu`, which looks dangerous to me." + }, + { + "prediction": "I think we can remove the `cst` argument from `sharedSetup` now that it's not used.", + "reference": "Does anyone still use the cst out of this method? If not consider deleting" + }, + { + "prediction": "I'm not sure if this is the right place to put this, but I think we should also add a redirect for `/videos/vim-for-rails-developers` to `https://www.youtube.com/watch?v=9J2OjH8Ao_A`", + "reference": "Line is too long. [97/80]" + }, + { + "prediction": "I think we can remove the `ANY` import now that we're not using it.", + "reference": "This seems unused." + }, + { + "prediction": "I don't think we should panic here. We should return an error and let the caller handle it.", + "reference": "@luguanglong , Thanks for the fix, can you re-phrase it to sound better something like \"This OS version is currently un-supported by keadm\"" + }, + { + "prediction": "I'm not sure this is the right place for this function.", + "reference": "should probably be called `_DeleteFpInfoAttr` because it removes it. Cleaning gives the impression it is still there. I would also move this to the end of the function `GetAtomicWeightsForFingerprint`." + }, + { + "prediction": "This should be `VUID-vkCmdBindDescriptorSets-pipelineBindPoint-00362`", + "reference": "nit, can we use `VK_PIPELINE_BIND_POINT_RAY_TRACING_KHR` here (granted it isn't else where, maybe worth fixing here or in separate PR)" + }, + { + "prediction": "I think this should be `:title` instead of `:name`.", + "reference": "This will need to be updated in the upcase-exercises repo as well." + }, + { + "prediction": "I think this should be `Status::SUBMITTED` instead of `Status::COMPLETE`.", + "reference": "Think it's worth extracting this to `Exercise#complete?`?" + }, + { + "prediction": "Why is this removed?", + "reference": "This is still a potentially useful public method - should we remove such methods?" + }, + { + "prediction": "I don't think this is a good default. I think it should be `UNSET_RELEASE_LEVEL`.", + "reference": "I don't understand this change, what is happening here?" + }, + { + "prediction": "I don't think you need to split the version here. You can just do `version = int(self.obj.excelCellObject.Application.Version)`.", + "reference": "I think its worth stating this is `versionMajor`" + }, + { + "prediction": "I don't think we need this. We can just call `config.PreloadConfigurableConsensusProtocols(nc.algodDataDir)` in the `NodeController` constructor.", + "reference": "rebuild: say loads and merges" + }, + { + "prediction": "I think we can remove this import as well.", + "reference": "Why was this removed here (also in the other file)? Shouldn't we import them so that the reference in the docs below is interpreted correctly?" + }, + { + "prediction": "I don't think we need to change this to `local[4]`.", + "reference": "I'd prefer to have a blank line between the class declaration and its first member. Is it possible?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think we should be using `mock.HELLO` instead of `mock.DEFAULT_ISMASTER_36` here. `mock.DEFAULT_ISMASTER_36` is not a valid `ismaster` response.", + "reference": "Is it really LEGACY_HELLO if we are using the most up to date HELLO? Perhaps `MONGOS_HELLO` would work here?" + }, + { + "prediction": "I'm not sure this is the right thing to do. If we fail to suspend a thread, should we just give up and not detach at all?", + "reference": "I am afraid this is going to cause problems on Windows where it is not uncommon to have injected threads (CTRL_SHUTDOWN, CTRL_LOGOFF, etc.) we have no privileges to suspend -- and thus retrying will just fail again, and with the new \"synchall failure is fatal and should kill the process\" approach it turns what used to work for us on Windows into process death." + }, + { + "prediction": "I think this should be `--mac_installer_signing_identifier `, not `--mac_installer_signing_identifier `.", + "reference": "think it should only be in create_dist" + }, + { + "prediction": "nit: extra space after `if int(cport.HostPort) > 0 {`", + "reference": "Do you plan to support Pod spec change? Like hostPort is added/removed later after Pod creation?" + }, + { + "prediction": "I think this should be `dokan.ExistingFile` instead of `dokan.ExistingDir`.", + "reference": "Is this behavior correct? It used to return `true`, which should map to `dokan.ExistingDir`. Was that previously a bug?" + }, + { + "prediction": "I think this should be `osrm::util::Log() << \"No shared memory regions found. Try running osrm-datastore\" << std::endl;`", + "reference": "What about just printing an empty list in this case? That would make the output more predictable." + }, + { + "prediction": "I think we can remove this line as well.", + "reference": "I looked and couldn't find any usage of `container` in any of the editor component files (js or hbs), so I assume this was used once and didn't get removed?" + }, + { + "prediction": "I think this should be `return locate_template('/templates/searchform.php', true, false);` instead of `locate_template('/templates/searchform.php', true, false); $form = ''; return $form;`", + "reference": "I just updated a number of sites using older versions of Roots onto WP 3.6 and this little function change was required. Multiple search bars were displaying when I used the search widget in a widgetized sidebar. Updated the roots_get_search_form as seen in this change resolved it for me!" + }, + { + "prediction": "Please remove this unused use statement.", + "reference": "Fixes test failed in some cases" + }, + { + "prediction": "I'm not sure why this was removed, but I think it should be added back in.", + "reference": "what's the prod url for this? just curious. @amirsaber" + }, + { + "prediction": "I think this should be `azkaban.job.ignore.jvm.args` instead of `ignore.jvm.args`.", + "reference": "Can you please change this to azkaban.jobs.java.opts?" + }, + { + "prediction": "I'm not sure about this change. I think it's better to keep the `sprintf` as it is, and just add the `Source:` string before it.", + "reference": "Here is another concatenation which should be updated. Even though `Source:` and the link are essentially separate, it isn't RTL friendly. This would be another good use for `createInterpolateElement` I think so that we wouldn't need to include all of the classnames in the translation string (or extract them to a placeholder). That would allow us to use the `Link` component as well, rather than using its resulting HTML as a string which will be a pain to maintain if we were to make changes to the base `Link` component." + }, + { + "prediction": "I don't think we need the `cancellationToken` parameter here.", + "reference": "I would add an overload `GetCancelledZeroTask()` which calls `GetCancelledZeroTask(CancellationToken.None)`. This is cleaner than requiring the caller to pass `default(CancellationToken)` or `CancellationToken.None`." + }, + { + "prediction": "Why is this check needed?", + "reference": "Would it be equivalent to check if `chain != nullptr` below? Not suggesting a change, just curious." + }, + { + "prediction": "I think this should be `this->wallets.queue_work_regeneration (std::chrono::steady_clock::now () + std::chrono::seconds (1), block);`", + "reference": "Should probably do `auto this_l (shared_from_this ());` and pass/use that instead of `this`. Same a few other places. IOW, replace both `shared_from_this()` and `this` with `this_l`" + }, + { + "prediction": "I'm not sure about this change. I don't think we need to escape the single quote here.", + "reference": "And here. Please, use `'` for apostrophes in changed strings in this file." + }, + { + "prediction": "I don't think we should use `SimulateExecution` here. We should use `ExecuteContractRead` instead. `SimulateExecution` is used to simulate the execution of a transaction on the blockchain. `ExecuteContractRead` is used to simulate the execution of a read-only function on a smart contract.", + "reference": "assignments should only be cuddled with other assignments (from `wsl`)" + }, + { + "prediction": "I think this should be `DefaultNewBlockDataVersion(c Config, holes bool) DataVer` instead of `DefaultNewBlockDataVersion(c Config, holes bool) DataVer`.", + "reference": "Please move this to `block_types.go`." + }, + { + "prediction": "I don't think these attributes are needed anymore.", + "reference": "So this is not needed anymore for all attributes?" + }, + { + "prediction": "Shouldn't this be `Failed to get OpenTelemetry Tracer from Service Provider: '{0}'. OpenTelemetry tracing will not work.`?", + "reference": "Happy to get suggestion for better messaging here. Here's what I intended to convey: Something is wrong - the Exception is a hint to what might be the cause The impact of that - tracing wont work." + }, + { + "prediction": "I think this should be `update_listener=update_listener` instead of `update_listener=update_listener`", + "reference": "I think we can remove this function, right? (duplicate with `ses_starter.py`)" + }, + { + "prediction": "`alias` is not a pandas method, it's a spark method. I think it should be renamed to `spark_alias` or something like that.", + "reference": "With this fix, I am not even sure we need to overwrite this function." + }, + { + "prediction": "I think this should be `os.getenv('QUILT_USE_TQDM', 'false').lower() == 'true'` so that it defaults to `false` if the environment variable isn't set.", + "reference": "Why not just import this from `data_transfer`? As a rule copying the same code twice is not a good idea. Also: please run `pylint` on all files in this PR." + }, + { + "prediction": "_server_port=>8140, :puppet_agent_port=>8140, :puppet_server_certname=>\"pe-ubuntu-lucid\", :puppet_agent_certname=>\"pe-centos6\"}}\n+ expect(parser.parse_args(args)).to be === {:hosts_file=>hosts_path, :options_file=>nil, :type=>\"git\", :provision=>true, :preserve_hosts=>false, :root_keys=>false, :quiet=>false, :xml=>false, :color=>true, :debug=>true, :dry_run=>false, :fail_mode=>nil, :timesync=>false, :repo_proxy=>false, :add_el_extras=>false, :consoleport=>443, :pe_dir=>\"/opt/enterprise/dists\", :pe_version_file=>\"LATEST\", :pe_version_file_win=>\"LATEST-win\", :dot_fog=>\"#{home}/.fog\", :ec2_yaml=>\"config/image_templates/ec2.yaml\", :ssh=>{:config=>false, :paranoid=>false, :timeout=>300, :auth_methods=>[\"publickey\"], :port=>22, :forward_agent=>true, :keys=>[\"#{home}/.ssh/id", + "reference": "You've got an absolute path here referencing your home dir :-)." + }, + { + "prediction": "I don't understand why this change is needed.", + "reference": "Maybe I should do some sorting so that these properties don't keep moving around..." + }, + { + "prediction": "I think this test should be kept, but it should check that the error returned is the one we expect.", + "reference": "Can we keep this test anyway, as it's part of the spec?" + }, + { + "prediction": "Please remove empty line at the end of the file.", + "reference": "Can be removed" + }, + { + "prediction": "This should be `use Config\\Config;` and `use Request\\Request;`", + "reference": "It's a minor quibble I know, but I like having the imports ordered by lengt" + }, + { + "prediction": "I don't think this is the right place to set the charset. The charset should be set in the Content-Type header of the response, not in the Content-Type header of the request.", + "reference": "It's better to get the charset from context or other setting to let the user override it." + }, + { + "prediction": "Why is this change required?", + "reference": "this filename as well needs change" + }, + { + "prediction": "Shouldn't this be `AccessKeyIDSecretRef` instead of `AccessKeyIDRef`?", + "reference": "I think we want to remove `omitempty` here" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but I think we need to make sure that the signal handler is closed before we return from this function.", + "reference": "You cannot move this here because it breaks detach. Just call `tty.Close()` before returning the error from start" + }, + { + "prediction": "I'm not sure if we should remove the implicit role here. I think we should keep it, but I'm not 100% sure. @elrumordelaluz, do you have any thoughts on this?", + "reference": "I updated only the implicit roles who needed a update for this new rule to validate." + }, + { + "prediction": "I think we can remove these two lines.", + "reference": "> // Code generated by protoc-gen-go. DO NOT EDIT." + }, + { + "prediction": "I think this should be `skipOSConfig = map[string]string{\"osconfig-not-supported\": \"true\"}`", + "reference": "minor: skipOSConfigMetadata, otherwise, the name sounds like a boolean" + }, + { + "prediction": "I don't think this is correct. `SyndTypeUtils.enclosureTypeValid` returns `false` if the type is `null`.", + "reference": "~~I think lines 65-67 should be moved into this else clause after `type = ...` Else, it is a bit confusing why we check the enclose type validity a second time~~ Nevermind, will do some refactoring, myself. But thanks for \"fixing\" this!" + }, + { + "prediction": "I think it would be better to return an empty slice if there are no sessions, instead of returning an error.", + "reference": "`sessions := endpoints.SessionsDTO{}` and using only `sessions` should be simpler." + }, + { + "prediction": "I don't think we need the `|| dcontext->is_exiting` here. I think we can just assert that `dcontext != NULL`.", + "reference": "These need to be in the other order to avoid crashing when dcontext == GLOBAL_DCONTEXT (==-1)" + }, + { + "prediction": "Why is this change necessary? I don't see it in the PR description.", + "reference": "Why not change the other samples?" + }, + { + "prediction": "I'm not sure if we need to escape the `id` here, since it's not being used in a `querySelector` or `querySelectorAll` call.", + "reference": "Indentation is mixed up here due to spaces/tabs, I'm guessing." + }, + { + "prediction": "I think this should be `if (bytes_read != sizeof(count))`", + "reference": "Should we provide a little more context in the error message? Maybe throw in something about what operation was being performed?" + }, + { + "prediction": "This should be `if (isset($configuration['settings'])) {`", + "reference": "Project standard is spaces, not tabs. Please fix and then we can merge this." + }, + { + "prediction": "I don't think this is needed anymore.", + "reference": "@hgtw is there anything we're worried about with regards to using this cache? Do we want to do staged testing around expeditions before we merge? Curious your thoughts here" + }, + { + "prediction": "I think we should keep the `partFilter` argument here. It is used in `PartialManifest` to filter out partitions that don't match the partition spec.", + "reference": "The purpose of this was to allow pushing filters into the manifest files if we ever use a format other than Parquet. I think overall this is a good change because we can add it back later. Just wanted to note why the unused argument was there." + }, + { + "prediction": "Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/IfUnlessModifier: Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
", + "reference": "I think BSON::Decimal128 should always be serialized as Decimal128 regardless of config option." + }, + { + "prediction": "I think this should be `require_relative 'bolt/plan_creator'` since it's in the same directory as this file.", + "reference": "We should probably just move the `require 'bolt/plan_creator'` in `Bolt::CLI` to `Bolt::Application` so it will already be loaded." + }, + { + "prediction": "I'm not sure if this is the right place to do this, but I think it would be nice to have a way to specify the number of warmup iterations and the number of target iterations in the `Options` class.", + "reference": ">20 [](start = 45, length = 2) Can we override this at runtime? Maybe it should be a command line option with default." + }, + { + "prediction": "Please remove this empty line.", + "reference": "can just remove it ?" + }, + { + "prediction": "I think this function should be renamed to `FinishMigrateRepositoryWithUpdateHook` or something like that.", + "reference": "Better call it `CleanUpMirrorInfo`?" + }, + { + "prediction": "I think this should be `node.RetrievalProtocol.RetrievalProvider.Start(ctx)`", + "reference": "@shannonwells is there still something missing here?" + }, + { + "prediction": "Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.", + "reference": "This could be more indicative of what it is... e.g... `stresstest_time_limit`" + }, + { + "prediction": "Why is this not needed anymore?", + "reference": "Shouldn't we do a `reader_payload_pool_.reset()` here?" + }, + { + "prediction": "I think this should be `BeaconEntries` instead of `DrandEntries`", + "reference": "I'd prefer the nomenclature less tightly coupled to DRAND throughout. I played with renaming the `drand` package to `beacon` but it was too much noise in this change." + }, + { + "prediction": "I think this should be `self._current_key` instead of `getattr(self, '_current_key', None)`", + "reference": "I think I would prefer you declare `self._current_key=None` in the constructor and just return `self._current_key`. That way you can prevent anyone from overwriting `current_key` without needing to use `getattr` here." + }, + { + "prediction": "I don't think these need to be constants. They are only used in this file.", + "reference": "I guess I like the name `mode` okay. I can't think of anything better." + }, + { + "prediction": "I don't think this is correct. If timeout is less than or equal to zero, we should not use the default timeout.", + "reference": "I would create a new method (NewStepWithDefaultTimeout?) for this purpose because timeout<=0 looks like a hidden logic" + }, + { + "prediction": "`limit` should be `int` instead of `string`.", + "reference": "Are these limit changes related?" + }, + { + "prediction": "This import is not used in this file.", + "reference": "Don't you mean `import scapy.consts`?" + }, + { + "prediction": "I think this should be `model.StageStatus_STAGE_FAILURE`?", + "reference": "`ctx` is unused in rollbackPrimary" + }, + { + "prediction": "Why is this change needed?", + "reference": "This is not what title says." + }, + { + "prediction": "I'm not sure about the name of this interface. Maybe `RuleViolationFixer` or `RuleViolationOperation` would be better?", + "reference": "a fix applies several fixes? maybe this should simply be `applyToNode`" + }, + { + "prediction": "nit: `fakeListOk` -> `fakeListFnOk` or `fakeListOkFn`", + "reference": "U1000: func `fakeGetOk` is unused (from `unused`)" + }, + { + "prediction": "nit: I think we can remove the empty line here.", + "reference": "Because there is a \"k8s.io/client-go/tools/cache\" below, we can sort out all the \"imports\" here." + }, + { + "prediction": "nit: please remove the extra blank line", + "reference": "Nit should be using `goimports` to format the import statements with standard libary imports first, new line, followed by non-standard library imports." + }, + { + "prediction": "I think this should be `if o.PipelineSecret != \"\" && o.PipelineStack != \"\"`", + "reference": "Do we not have tests for pipeline delete" + }, + { + "prediction": "Should this be `call_check` instead of `self.call_check`?", + "reference": "Good that you mention this constraint in the docstring :)" + }, + { + "prediction": "remove empty line", + "reference": "remove this blank?" + }, + { + "prediction": "I think this should be set to 0, not -1. -1 is not a valid number of active partitions.", + "reference": "Partitions is misspelled 8 times in this commit, might make sense to fix the spelling for all of those." + }, + { + "prediction": "I think this should be `from qutebrowser.browser.qutescheme import QuteScheme`", + "reference": "Please remove this blank line - those are only used to group Python/third-party/qutebrowser imports." + }, + { + "prediction": "I think this should be `var insecure bool = false` to make it explicit that the default value is `false`.", + "reference": "`insecure` is a global variable (from `gochecknoglobals`)" + }, + { + "prediction": "Shouldn't this be `if setting.Repository.DisableHTTPGit`?", + "reference": "Same as above (HTTP in upper-case)" + }, + { + "prediction": "I think this should be `https://www.youtube.com/watch?v=123456`", + "reference": "This is getting repetitive maybe you could introduce an abstract test case with a `getExpectedUrl($providerReference)` method ?" + }, + { + "prediction": "I think this should return a `reflect.Value` instead of an empty `reflect.Value`.", + "reference": "I do not think returning `Value{}` is correct here. For example, `reflect.MakeFunc(...).Kind()` would return `reflect.Invalid` instead of `reflect.Func`. Therefore, I think this should panic instead." + }, + { + "prediction": "I don't think this is correct. `nameLower` is not guaranteed to be in `window`. `nameLower` is the lowercased version of `name`. `name` is the original name. `nameLower` is the lowercased version of `name`. `name` is the original name. `nameLower` is the lowercased version of `name`. `name` is the original name. `nameLower` is the lowercased version of `name`. `name` is the original name. `nameLower` is the lowercased version of `name`. `name` is the original name. `nameLower` is the lowercased version of `name`. `name` is the original name. `nameLower` is the lowercased version of `name`. `name` is the original name. `nameLower` is the lowercased version of `name`. `name` is the original name. `nameLower` is the lowercased version of `name`. `name` is the original name. `nameLower` is the lowercased version of `name`. `name` is the original name. `nameLower` is the lowercased version of `name`. `name` is the original name. `nameLower`", + "reference": "Does this work for Custom Elements? iirc we're lacking test cases for them. /cc @andrewiggins @developit" + }, + { + "prediction": "nit: I think we can remove the `m.externalNodeCIDRs` field from the `ipipManager` struct, since it's only used here.", + "reference": "Same change just above?" + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to be the only way to get this to work in IE11.", + "reference": "I suppose `apploader.js` isn't used by WebWorkers. So `self` will always be `window` here." + }, + { + "prediction": "I'm not sure this is the best way to do this, but I think it's better than what we had before.", + "reference": "Since this var is no longer defined we should remove the `if skip_targets.any?` bit below." + }, + { + "prediction": "I think this should be `ARN_TO_LAMBDA.get(arn).qualifier_exists(qualifier)`", + "reference": "I think we should `return arn` as a fallback at the end of this function (otherwise the `['Resource']` entry below could become `None`)." + }, + { + "prediction": "I'm not sure this is the right thing to do here. I think we should be able to remove the NATProxy altogether if we don't need it, but I'm not sure how to do that.", + "reference": "Why session is started at all, if you need to shut it down e.g. DI should launch noopSession" + }, + { + "prediction": "I think this should be `DeleteWorkspaceFile() error` instead of `DeleteAll() error`", + "reference": "nit: can we rename the interface to `wsFileDeleter`" + }, + { + "prediction": "I'm not sure if this is a good idea to change the type of `FromAddresses` and `ToAddresses` from `v1beta1.GroupMemberPodSet` to `v1beta1.GroupMemberSet`. I think we should keep the type of `FromAddresses` and `ToAddresses` as `v1beta1.GroupMemberPodSet` and only change the type of `Pods` from `v1beta1.GroupMemberPodSet` to `v1beta1.GroupMemberSet`.", + "reference": "Why target cannot be external endpoints?" + }, + { + "prediction": "I think this should be in `CollectionConfig` instead of `CollectionAdminParams`.", + "reference": "We use a suffix \".AUTOCREATED\" for configsets, maybe we can use the same here?" + }, + { + "prediction": "I think we should keep the `Default` in the name of the method to make it clear that this is the default instance of `OpenTelemetrySdk`.", + "reference": "This one won't be disposed. Should be (something like) `using var openTelemetry = OpenTelemetrySdk.EnableOpenTelemetry(` no?" + }, + { + "prediction": "I'm not sure about this change. I don't think it's necessary and it makes the code harder to read.", + "reference": "Why this is in the diff?" + }, + { + "prediction": "I don't think we need to add this to the driver interface. We can just call `CloudBackupCreate` in a loop for each volume in the group.", + "reference": "How is status determined? When the user calls CloudBackupCreate( src_volume_id ) they can then call CloudBackupStatus( src_volume_id ) Is there something similar for this new API?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the `diff` function itself. The reason is that the `excessDomChildren` array is only used in the `diff` function, so it doesn't make sense to pass it to the `options.diffed` function. Also, the `excessDomChildren` array is only used in the `diff` function, so it doesn't make sense to pass it to the `options._catchError` function. Also, the `excessDomChildren` array is only used in the `diff` function, so it doesn't make sense to pass it to the `options._catchError` function. Also, the `excessDomChildren` array is only used in the `diff` function, so it doesn't make sense to pass it to the `options._catchError` function. Also, the `excessDomChildren` array is only used in the `diff` function, so it doesn't make sense to pass it to the `options._catchError` function. Also, the `excessDomChildren` array is only used in the `diff` function, so it doesn't make sense to pass it to", + "reference": "We could pass `excessDomChildren` to `options._catchError` and only do this if an error-boundary catches the error. Not entirely sure if that's better." + }, + { + "prediction": "`array_merge(...array_values($this->getFilters()));` should be `call_user_func_array('array_merge', array_values($this->getFilters()));` or `call_user_func_array('array_merge', $this->getFilters());`", + "reference": "In php8 named parameters were introduced and now it is required to match called method parameter name when setting parameters by array destructing or call_user_func_array() etc." + }, + { + "prediction": "I think this should be `if !sc.IsValid() && !sc.IsSampled() { return ctx }`", + "reference": "If instead we had `B3.extractSingleHeader` and `B3.extract` return a bool value as a second return value, we could avoid the byte array comparison in `TraceID.IsValid`. Did you consider that alternative?" + }, + { + "prediction": "I think it should be \"weitere\" instead of \"weitere\"", + "reference": "I think this is more of a semantic difference than a typo - `weiter hinzufgen` is like `continue adding` whereas `weitere hinzufgen` is like `add more`. I think it makes sense to change it though" + }, + { + "prediction": "Shouldn't this be `status=200`?", + "reference": "nit: 200 is superfluous" + }, + { + "prediction": "why change EMAIL to email?", + "reference": "This is testing `unreserved keyword`" + }, + { + "prediction": "Please remove the extra blank line.", + "reference": "paramsNatOrigin doesn't include sUVtoST. I would just remove that definition for now" + }, + { + "prediction": "I think this should be `t.Fatal` instead of `t.Log`.", + "reference": "It feels like the test should be waiting for the prefetcher to shut down, but I don't have a great reason why other than that it might be confusing for debugging if there are still goroutines from old prefetchers lying. But I guess since `TogglePrefetcher(false)` doesn't actually set the prefetcher to nil, the queue shutdown method will still end up waiting for the shutdown to finish. If that sounds right, nevermind me." + }, + { + "prediction": "`AWS IAM` -> `AWS Identity and Access Management`", + "reference": "AWS Identity and Access Management (IAM)" + }, + { + "prediction": "I think this should be `RESOURCE_NAME` instead of `RESOURCE_NAME_INSTANCES`.", + "reference": "As a long term thing, would it make sense to move the resource names as keys under the requirements map?" + }, + { + "prediction": "I think this should be `if (cell.getAttribute('headers')) {` instead of `if (cell.getAttribute('headers')) {` because `getAttribute` returns `null` if the attribute doesn't exist.", + "reference": "That doesn't fix the whole problem. The issue lays in this line right here, not the one above. There are two problems with this line: 1. It finds things that aren't cells in the table 2. if it doesn't find anything, it shouldn't return empty here, but continue down to look for row/ column headers." + }, + { + "prediction": "I don't think this is correct. `getProject()` returns the project where the task is defined, not the project where the task is executed.", + "reference": "I am pretty sure that this is infinite recursion as getAllProjects returns the project itself." + }, + { + "prediction": "I think this should be `dataLists` instead of `data-lists`.", + "reference": "Something I didn't catch before I merged this PR, is the hyphenated constant a problem? E.g. should \"data-lists\" be \"data_lists\"? @paulkaplan" + }, + { + "prediction": "I don't think this is the right way to do it. I think it would be better to have a `scapy.arch.windows.disable_sendrecv` module that is imported by `scapy/arch/windows.py` and `scapy/arch/unix.py`. This way, you don't have to change anything in `scapy/arch/windows.py` and `scapy/arch/unix.py`.", + "reference": "Can you write the test as `if not (conf.use_winpcapy or conf.use_pcap or conf.use_dnet):`" + }, + { + "prediction": "I think this import should be moved to the top of the file.", + "reference": "we have to include foreign assets on the repository directly because they don't belong to a job? This seems very awkward... Is this a step towards the job-less assets on the repository? Did you consider having `build_asset_job` take in a set of foreign assets instead? I suppose we would then need to subclass it to be a more special `AssetJobDefinition` that can keep track of them." + }, + { + "prediction": "I don't think this change is correct. `strncpy` will not null-terminate the string if the source string is longer than `len`. `strcpy` will always null-terminate the string.", + "reference": "`-Wstringop-truncation` is a new kind of error detector introduced in GCC 8. As for this patch, these are two false-positives though." + }, + { + "prediction": "I'm not sure if this is a breaking change or not, but I think it should be.", + "reference": "Can we port this error msg to v2 too? This one is better, as it explicitly states what sources are allowed." + }, + { + "prediction": "I think this should be `const { ReadPreference } = require('mongodb');`", + "reference": "The convention so far has been to require directly from the defining file (in this case `../../read_preference') . I think the concern has been mostly about the potential for circular dependency cycles" + }, + { + "prediction": "`color_type` can be `color`, `grayscale` or `unchanged`.", + "reference": "I suggest expanding dims here to simplify the formatting." + }, + { + "prediction": "I don't think we need to change this.", + "reference": "Why do you need to specify the kinto prefix here?" + }, + { + "prediction": "Please use `!s` instead of `!r`", + "reference": "The `!r` is unnecessary." + }, + { + "prediction": "I think this should be `if accountKey != \"\" || sasToken != \"\" || sasURL != \"\"`", + "reference": "I didn't see existing tests for this `OpenBucketURL`. Not sure if it's easy to do without mocking these `opener` calls." + }, + { + "prediction": "I think this should be `public bool IsPreparerNeeded { get; private set; }`", + "reference": "Should we default to `true` ?" + }, + { + "prediction": "I think we don't need to import `fsm` here.", + "reference": "File is not `goimports`-ed (from `goimports`)" + }, + { + "prediction": "I'm not sure if this is the right place for this, but I think we should also add `@babel/preset-typescript` here.", + "reference": "Shouldn't these options also include `@babel/preset-env`? Also I see you set `babelrc` to `false`, could we rely on our existing `.babelrc` file? Feels like some duplicate configuration otherwise." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should log the error that caused the disconnection.", + "reference": "Nit: We can use `%s` since `disconnectReason` is a string." + }, + { + "prediction": "`boosting_type` should be `boosting_type='rf'` or `boosting_type='gbdt'`", + "reference": "I think it's better to create a new example" + }, + { + "prediction": "I think this should be `kDepthStencilAttachmentRasterOrder` instead of `kAttachmentRasterOrder`.", + "reference": "The stages are correct, but the more forgiving `kAttachmentRasterOrder` should be used, based on a review of the spec. That should give the same effect of suppressing the false positive conflict between the DEPTH R/W and resolve. > End-of-subpass multisample resolves are treated as color attachment writes for the purposes of synchronization. This applies to resolve operations for both color and depth/stencil attachments. That is, they are considered to execute in the VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT pipeline stage and their writes are synchronized with VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT. Synchronization between rendering within a subpass and any resolve operations at the end of the subpass occurs automatically, without need for explicit dependencies or pipeline barriers." + }, + { + "prediction": "Is this a typo? Shouldn't it be `--SO3H`?", + "reference": "To be consistent, I think it should actually just be a single `-`" + }, + { + "prediction": "This import is not used anywhere in this file.", + "reference": "this seems extraneous." + }, + { + "prediction": "I don't think we need to run this test with the long domain feature set.", + "reference": "Ah, I see here that 'LongDomain' is defined as something that contains a subdomain segment that is `maxLengthOfDomainSegment` long (which I think is 63 characters) - I don't think any public ACME servers/Let's Encrypt's staging environment has a restriction on this? if it does, and the 'pebble' based ACME server does not, then Pebble needs modifying to also fail in these cases as it aims to replicate the ACME RFC as closely as possible" + }, + { + "prediction": "I don't think we need to use `gdebi` here. We can just use `dpkg -i` and `apt-get install -f`.", + "reference": "I think you need `-y` here to prevent a user confirmation prompt" + }, + { + "prediction": "I think this should be `dynamo_avx512_code_in_use` instead of `dynamo_avx512_code_in_use`.", + "reference": "Repeating: I don't think this should be a core-wide global var. This should be isolated to arch/x86 or at least arch/, maybe inside getter/setters as mentioned above." + }, + { + "prediction": "I think it would be better to make this a list of tuples, where the first element is the name of the plugin and the second element is the version of the plugin.", + "reference": "right URL is like in cmdrunner, using search.maven .org" + }, + { + "prediction": "I don't think we should change the type of this property. It should be `Uri` and we should validate that it starts with `http` or `https` in the constructor.", + "reference": "The link to valid syntax is not really applicable for NET2_1, right?" + }, + { + "prediction": "I don't think we need to say anything about escaping here.", + "reference": "Shouldn't it be more specific, like \"gcppubsub supports all UTF-8 strings\"?" + }, + { + "prediction": "I think this test should be renamed to `testFullReplicationFromSecondary`.", + "reference": "Everything in this class is SolrCloud-related, not legacy replication" + }, + { + "prediction": "I think you can remove the `if (!manager->is_scratch_reg_dead) {` check here as well.", + "reference": "Could just assign directly and eliminate the `newval` var." + }, + { + "prediction": "I think this should be `^[a-z0-9/]+: [a-z0-9/]+: .*$`", + "reference": "... with the name of the affected package, or \"all\", followed by a colon,..." + }, + { + "prediction": "I think we can remove this line, it's not used anymore.", + "reference": "We'll want to remove this one if we make the assembly version constant." + }, + { + "prediction": "I think this should be `setup_single_post_and_page_style()` to be consistent with `setup_single_post_style()`.", + "reference": "Can we have a single function here that uses the same subscribers and just changes meta based on context?" + }, + { + "prediction": "I don't think we need to change the name of this class. I think it's fine to keep it as `startup_kernel_loader`.", + "reference": "where would ` static startup_kernel_loader skl;` be instantiated? if it's not instantiated anywhere should this be removed?" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "I think we should move those util functions that work with drag-drop to @uppy/utils, so they can be shared (maybe later) with drag-drop plugin? Otherwise it will continue to depend on drag-drop module." + }, + { + "prediction": "Why is this removed?", + "reference": "Migrate the spec.Labels to locator.Labels ?" + }, + { + "prediction": "I think this should be `if gotErr != tc.wantErr {`", + "reference": "The test case already existed but it never tested properly because of the conditional in the test." + }, + { + "prediction": "nit: add a space after `return`", + "reference": "I'm okay with this, but I don't see a lot of benefit to removing unnecessary parens. If extra parens make something more readable (like this) or clarify order of operations even when matching the default, I would say we should keep them." + }, + { + "prediction": "I don't think we need to initialize this to an empty array.", + "reference": "@sarowe why was this volatile? It's fishy to see this as the only volatile field." + }, + { + "prediction": "please remove this empty class.", + "reference": "template is not correct?" + }, + { + "prediction": "I think we can merge these two registries into one.", + "reference": "Rename the registies to `BBOX_ASSIGNERS` and `BBOX_SAMPLERS` to avoid ambiguity. There is also a registry for dataset sampler." + }, + { + "prediction": "Line is too long. [83/80]", + "reference": "This is no longer stubbed on every test. Perhaps it should be, and should be unstubbed in the single case that it matters." + }, + { + "prediction": "I think this should be `Puma.stats_hash` instead of `Puma.stats` since `Puma.stats` returns a string.", + "reference": "This seems much simpler! I'm not sure I follow what you mean by the threading part... Also tests are not liking this constant. Might need a require or to fully qualify this." + }, + { + "prediction": "I don't think we need to do anything for single step.", + "reference": "Convention is \"FIXME: i#2144\" or \"XXX: i#2144\"" + }, + { + "prediction": "I think this should be `IHttpMethod` instead of `IHasHttpMethod`", + "reference": "This should probably be a property instead of a method." + }, + { + "prediction": "I am not sure if this is the right place to set the state to `RECONCILED`. I think this should be set to `RECONCILED` only when the upgrade is successful. If the upgrade fails, then the state should be set to `RECONCILING_FAILED`. What do you think?", + "reference": "do we need to consider setting the `state` as well? If so, lot of changes might be required, like, setting to 'Reconciling' in upgrade code, setting to 'error' or 'reconciled' in volumeReconciler functions." + }, + { + "prediction": "Metrics/LineLength: Line is too long. [114/100]", + "reference": "Line is too long. [82/80]" + }, + { + "prediction": "This file is auto-generated. Please don't make changes to this file.", + "reference": "Add blank line below license header." + }, + { + "prediction": "I think we can remove the `if (ops.current() != null) { ... } else { ... }` and just do `String baseLocation = location != null ? location : ops.current().location();` and `TableMetadata metadata = ops.current().buildReplacement(schema, spec, baseLocation, tableProperties);`", + "reference": "I'm not clear on whether this really should be the right behavior. Basically we're saying that a replace table will keep the existing location (as opposed to using defaults). I suspect we don't have create or replace with location semantics, but this is making some assumptions that a replacement is somehow the same as the old. If we were to go with id based pathing convention, this wouldn't work. I don't think this is an issue at this point, but it might make sense to push this down to the location provider." + }, + { + "prediction": "nit: remove empty line", + "reference": "Just run a global replacement for all `executionproto`." + }, + { + "prediction": "I don't think we need to add `options` to the `__init__` method. We can add it to the `start_session` method instead.", + "reference": "@AutomatedTester @davehunt thoughts on a new keyword argument?" + }, + { + "prediction": "I think this should be `FPGA_NOT_FOUND`", + "reference": "Should line 47 be OPAE_ERR?" + }, + { + "prediction": "nit: `var zeroTime = time.Time{}`", + "reference": "Not necessary, just write `time.Time{}`" + }, + { + "prediction": "I think this should be `SettingValue(typ.PercOrInt(minperc=0, maxperc=100, minint=1, maxint=1000), '12')`", + "reference": "As these two strings simply get concatenated for the docs, there's a space missing after the dot here." + }, + { + "prediction": "I think this should be moved to the `BeginMethodHandler.Invoke` method.", + "reference": "What about integrations where we don't plug ourselved on OnMethodBegin?" + }, + { + "prediction": "`visibility_of_any_element_located`?", + "reference": "shouldn't **call** return a boolean?" + }, + { + "prediction": "I think this should be `com.google.api.tools.framework.model.Method` instead of `com.google.api.tools.framework.model.Interface`.", + "reference": "ViewModel classes should not expose any classes from framework.model." + }, + { + "prediction": "I think we should keep this test, but change the expected output to `{'string_field': None}`", + "reference": "how would you feel about keeping these tests to be more explicit and having them `assert not _validate...`? or is your view that that is too duplicative of the tests in `test_evaluator.py`?" + }, + { + "prediction": "I think this should be `--targets` instead of `-t`", + "reference": "Why do we use the `winrm_nodes` variable here and not the string `\"winrm_nodes\"` as we were using before?" + }, + { + "prediction": "copyright year should be 2018-2019", + "reference": "why update Copyright ?" + }, + { + "prediction": "nit: extra space after `isSampleScan()`", + "reference": "Does this mean we cannot update statistics with sampling on a table with LOB columns?" + }, + { + "prediction": "I think it would be better to have a `ClearCacheOnInitialize` property instead of `ClearCacheOption` enum.", + "reference": "Look good, but I think a `[flags]` enum would be more future proof? Although i'm not sure if a flags-enum is working from the XML config. What do you think?" + }, + { + "prediction": "I think this should be `row.treeNode.state === 'expanded'` and `row.treeNode.state === 'collapsed'` instead of `row.treeNode.state === 'expanded'` and `row.treeNode.state === 'collapsed'`", + "reference": "Since I believe state will never be anything other than 'expanded' or collapse, you can rewrite this as follows: `return row.treeNode.state === 'expanded' ? 'ui-grid-icon-minus-squared' : 'ui-grid-icon-plus-squared'; `" + }, + { + "prediction": "I don't think we need to remove this.", + "reference": "the latter part can go but isn't the first part of this still sound -- that we assume \"id\"?" + }, + { + "prediction": "I don't think this is correct. I think it should be `\\'` instead of `\\\\\\'`", + "reference": "Why is the escaping of @ and $ removed?" + }, + { + "prediction": "I think this should be `IHasHttpUrl` where `T` is the type of the `HttpUrl` property.", + "reference": "Nit: `Http` is redundant in this interface's name." + }, + { + "prediction": "I think this should be a warning, not an error. If the prefix doesn't exist, that's fine, we just need to create it.", + "reference": "what if I set SynchronizableEntitiesPrefix to \"a/b/c/d\" in config?" + }, + { + "prediction": "I think this should be `!isDir` instead of `isDir`.", + "reference": "nit: This error message doesn't mention that the path is a directory, maybe \"Dockerfile path is a directory:%s, please provide path to file.\"" + }, + { + "prediction": "Please remove this line, it's not needed.", + "reference": "This is done automatically, you can skip it next time ;)" + }, + { + "prediction": "I'm not sure this is the right thing to do here. If the tab is deleted, then the element is gone too, so I don't think it makes sense to raise an error here.", + "reference": "This is needed in `set_value` because of `:open-editor` (you could open an editor, close the tab, then close the editor). I don't think it makes any sense to have it here?" + }, + { + "prediction": "I think this should be a `bool` rather than a `string`.", + "reference": "Perhaps we can assume that profiling is enabled if ProfilingPort is set? And/or configure a default port and frequency, so we don't have to set three config vars every time?" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "This nil check won't correctly handle the case where forward_ssh_agent is set to false - it won't be nil but it should still not be set." + }, + { + "prediction": "Why is this needed? I don't see it being used anywhere.", + "reference": "We could avoid passing proto since threshold isn't needed." + }, + { + "prediction": "Why is this disabled?", + "reference": "This route excluding needed for reconnect only when one connection is lost and we trying to establish another. I was thinking to make 2 separate flags for killswitch and reconnect enabling. This way we can keep killswitch working, but we don't need these routes excluded." + }, + { + "prediction": "why move this line here?", + "reference": "why can this modification avoid crash?" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if there's a better way to check if the current user is the same as the account we're redirecting to.", + "reference": "This looks good -- signing out the user if the current user is disabled" + }, + { + "prediction": "I think it would be better to use the term \"corner\" instead of \"corner header\".", + "reference": "The line exceeds 120 characters." + }, + { + "prediction": "I think this should be `desc[\"php_version\"].(string)`", + "reference": "Let's go ahead and change \"Site\" to \"Project\", since that's the path we've chosen. One less thing to alter in the other issue." + }, + { + "prediction": "Why remove this?", + "reference": "I am for this change iff we are sure the information is no longer helpful. I think this could still be valuable for certain scenarios, wbu?" + }, + { + "prediction": "I think we can use `maxImageRampup.getImageVersion()` instead of `firstImageRampup.getImageVersion()`.", + "reference": "I thought we decided on using the latest active version and not the one which is max ramped up." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's better to have the user interrupt and rerun `copilot env init` instead of failing here.", + "reference": "can we update this to a `log.Warningf`?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to make this work.", + "reference": "can we get something emitted in the logs on non-zero exits to trace back to for problems like this failing on the first invocation?" + }, + { + "prediction": "`schemaMan` is not used in `AddVerticesProcessor::instance`?", + "reference": "Do we need `schema manager` at here ?" + }, + { + "prediction": "I think this should be `#cgo LDFLAGS: -L${SRCDIR}/target/release -ldl -Wl,-Bstatic -lflux_parser -Wl,-Bdynamic`", + "reference": "This won't work because of the permissions on the directory when this is included as a library. But, we may be able to do this. The key would be wrapping this command with either a script or a go binary that ensures the current directory is writable. If the current directory is not writable, it would attempt to make it writable so that we could write out the produced binary. But I'm not sure if that will influence the hash that gets produced for `go.sum` since I am not sure how that is calculated. Alternatively, we can choose a place in `/usr/local` or choose a location that is writable in the go cache and use that. I'll give that a try since it might be needed for the ARM builds if we choose to only include `x86_64` precompiled binaries in the module." + }, + { + "prediction": "I'm not sure this is the right place to do this, but it seems to work.", + "reference": "Correct me if I'm wrong, but is this necessary? Why not just use the value returned by `interpreter.Eval` and not mess with the scope? `interpreter.Eval` will return any produced side effects. This means TableObjects as well as any value resulting from any expression statements." + }, + { + "prediction": "I think this should be `config.Labels.Merge(p.Spec.ServiceMetadata.Labels).Merge(map[string]string{\"operated-alertmanager\": \"true\"})`", + "reference": "This service is global per namespace, not per Alertmanager/Prometheus/ThanosRuler instance. So this approach won't work. But maybe I missing out something, can you describe your use case here?" + }, + { + "prediction": "I think this should be a nullable bool, so that we don't have to change the schema if we want to change the default value in the future.", + "reference": "Do we need this default? Since we aren't using a sql.NullBool or *bool, an unset column will be interpreted as `false` already... We don't set a default on our other bool fields (e.g. entry admin and downstream columns)." + }, + { + "prediction": "Metrics/CyclomaticComplexity: Cyclomatic complexity for download_plan_page_title is too high. [7/6]", + "reference": "thanks for moving these over. makes more sense for them to be in the exports_helper" + }, + { + "prediction": "Please remove this empty line.", + "reference": "That import now isn't needed anymore" + }, + { + "prediction": "I don't think we need to change the docstring here.", + "reference": "Can you update the `Usage` to be an absolute path as well? Something like `/path/to/firebug.xpi`" + }, + { + "prediction": "I think this should be `Mvx.RegisterSingleton(new MvxWindowsUapAccelerometer());`", + "reference": "This class is missing the `MvxPlugin` attribute" + }, + { + "prediction": "This should be `wxLang.LayoutDirection`, not `wxLang.LayoutDirection`.", + "reference": "What if `wxLang` is returned `None` from `getWxLang`" + }, + { + "prediction": "why change this?", + "reference": "Please don't do changing like this unless it _**really**_ cares. BTW. Please look around to infer our naming conventions." + }, + { + "prediction": "I don't think we should be using `finest` here. `finer` seems more appropriate.", + "reference": "This is in test code: understanding what we're doing is important in this context." + }, + { + "prediction": "I think this should be `--miner-enabled should not be true`", + "reference": "prob should still have an example that has multiple option names even if you have to make it up. Or maybe we don't need this method?" + }, + { + "prediction": "Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.", + "reference": "I believe respond_to whitelists the formats passed to the block so if we don't want to display html, we can just remove the line format.html..." + }, + { + "prediction": "I don't think this will work. You need to use `util.Failed(\"Failed to stop containers for %s. Run `ddev list` to ensure your site exists. error=%v\", app.ContainerName(), err)`", + "reference": "stylistic nitpick: I _feel_ like we've largely shown errors like this as \"error: \" vs. \"error=\". IMO colon/space reads better." + }, + { + "prediction": "I think this should be `#include `", + "reference": "We could put this implementation in `RTPSWriter::create_change_pool` and avoid an extra function." + }, + { + "prediction": "nit: please remove this empty line", + "reference": "should this file ends with _test.go?" + }, + { + "prediction": "I think this should be `ss = inet_pton(socket.AF_INET6, self.src)`", + "reference": "It's because of this change. `ss` was unused and it made sense in the program. However I haven't read the IPv6 RFC so I'm unsure of what it does" + }, + { + "prediction": "nit: `let flattenIndex = index;`", + "reference": "\"Flatten\" is a verb, so I'd probably go with `flattenedIndex` as a variable name here." + }, + { + "prediction": "I don't think we need to freeze this.", + "reference": "If it can only be called once, perhaps a more appropriate name is something like `setMaskables`? `addX` sounds like you can add many `X`es by calling it many times" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the right thing to do for now.", + "reference": "Nodecfg should be downloading from a private bucket -- these shouldn't be for public consumption. In general these should be generic and expect environment to provide appropriate credentials and bucket." + }, + { + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in `appModules\\microsoftEdge.py` instead of `appModules\\microsoftEdge\\__init__.py`.", + "reference": "Could you please end the file with an empty line?" + }, + { + "prediction": "I don't think we need to log this at `finest` level. I think `info` is fine.", + "reference": "This is an incorrect change. The dialect spoken is an important part of the handshake and should be communicated to users." + }, + { + "prediction": "nit: I think we can remove the `isCanceledMx` and just do `isCanceled := v.isCanceled` in the `IsCanceled` method.", + "reference": "Can this be non-exported to avoid direct use? It would be a breaking change but using previous package version would work." + }, + { + "prediction": "I think this should be `return gcerrors.Code(err)`", + "reference": "Nit: this is just `return gcerrors.Code(err)`, isn't it?" + }, + { + "prediction": "I'm not sure this is the right thing to do, but I'm not sure what else to do either.", + "reference": "I don't know where this came from, but it's not a good idea. This is actually timing out after 5 rounds, not 5 blocks. 5 consecutive null blocks won't be that uncommon. Also when testing with a short block time, this is a very short duration that can contribute to flaky tests." + }, + { + "prediction": "I'm not sure about this change. I don't think we should be using `cPickle` anymore, but I don't think we should be using `pickle` either. I think we should be using `json` instead.", + "reference": "In Python 3 when pickling or unpickling objects, the file needs to be opened as binary so that no text encoding/decoding takes place. So for any open calls around pickle loads or dumps, the mode for reading must be rb and the mode for writing must be wb." + }, + { + "prediction": "I think we need to pass `params.qstring.method` to `fetchMergedEventGroups` as well.", + "reference": "did you remove **params.qstring.method** intentionally? if so why?" + }, + { + "prediction": "I think we should have a default value for this property.", + "reference": "What is the current default? Is that inconsistent across uses and that's why this is null?" + }, + { + "prediction": "Why is this needed? I don't see it being used anywhere.", + "reference": "Why did we make this change? How come it wasn't an issue before" + }, + { + "prediction": "Why is this removed?", + "reference": "Can you tighten scope by moving to of these variables? i.e. Move to ~4372?" + }, + { + "prediction": "I think this should be `dataverse.rserve.password` instead of `dataverse.rserve.pwrd`.", + "reference": "Nice to see this `dataverse.rserve.password` fix rolled in." + }, + { + "prediction": "(style) code indent should use tabs where possible", + "reference": "How about the following faster alternative that doesn't need `strlen()` at all: if (*tmp_optarg == '\\0' || *endptr != '\\0') { fprintf(...) ... This would treat the bus argument as invalid if it's either empty (`tmp_optarg` points to '\\0') or invalid (`endptr` points to something other that a '\\0'). Actually, the existing code would accept an empty argument and set the bus to `0`, so if (*endptr != '\\0') { fprintf(...) ... would be enough. The check for an empty argument doesn't hurt, though." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it makes sense to cc the user who submitted the feedback so they can follow up with us if they need to.", + "reference": "I could be missing something here, but the `from` and `cc` are the same. On the test email sent to gatewaycommunicator, these values are different." + }, + { + "prediction": "I'm not sure why we need to wrap this in an `act` block. I don't think it should be necessary.", + "reference": "I'm honestly scared because act is now a hard requirement for useEffect which it wasn't before... This could break some tests :(" + }, + { + "prediction": "Why is this needed? `election->blocks[block_a->hash ()] = block_a;` should be enough.", + "reference": "Could use election from `info_a.election`, or is this deliberate?" + }, + { + "prediction": "I don't understand why this is needed. Can you explain?", + "reference": "looks like this should be `return array(LegacyFormHelper::getType('form'));`" + }, + { + "prediction": "I think this should be `if (typeof opt_port === 'function')` instead of `if (typeof opt_port !== 'function')`", + "reference": "Maybe it would simpler to ignore opt_port if type !== 'number'?" + }, + { + "prediction": "I think this should be `for (var i = 0; i < categoryNames.length; i++) { name = categoryNames[i];`", + "reference": "Where was `name` being declared before?" + }, + { + "prediction": "I think this should be `False` instead of `Unknown`.", + "reference": "nit: use `corev1.ConditionUnknown`" + }, + { + "prediction": "I don't think we need to check for `v.length === 12` here. If `v.length === 12` then `v.length === 24` must be `false`.", + "reference": "You also need to add a similar check on line 992, there's another place where we check `length === 24`" + }, + { + "prediction": "nit: I think it would be better to have a method `getVoteProviderAfterBlock` instead of `getVoteProviderAfterBlock` and `getVoteProviderAfterBlock`", + "reference": "nit: can extract the voteProvider as a local variable" + }, + { + "prediction": "nit: `expected error, functions are not equal` -> `expected error, functions are not equal: eq(foo_i,2) != lt(foo_i,2)`", + "reference": "[0] Not suggesting you change it here, but....kindof weird that there's just not an `assertFuncNotEquals`" + }, + { + "prediction": "I don't think we need to wrap the error here. The caller of this function will handle the error.", + "reference": "why are we passing 'registryAddress' here? We probably should construct it together with bc. Registry is not something that change?" + }, + { + "prediction": "It's like `RA.spreadPath|spreadPath`, but preserves object under property path", + "reference": "`.` at the end of the sentence" + }, + { + "prediction": "I think it's better to measure the time from the start of the function, not from the start of the ping.", + "reference": "wouldn't it be useful to split this into an error metric for the timing?" + }, + { + "prediction": "Use 2 spaces for indenting an expression spanning multiple lines.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Not sure if this is good enough. Each generator will have it's own unit test anyway. Ideally, I think I'd want to test that each generator in the yml is actually a valid generator..." + }, + { + "prediction": "I think this should be `AnyTimes()` as well.", + "reference": "line is 138 characters" + }, + { + "prediction": "I'm not sure I like the name \"Wire\" for this function. It's not really about the wire at all, it's about cleaning up the database connection. I'd prefer to call it `Cleanup` or `Close` or something like that. What do you think?", + "reference": "Nit: I would leave `Wire` out of the description; if you use this without wire you can still use it." + }, + { + "prediction": "I think we can remove this import.", + "reference": "Nit: each field can be on a separate line to make it visually easier to read." + }, + { + "prediction": "I don't think we need to add this file to the list of files to be sent to the server.", + "reference": "Do we still have these files? Shouldn't we remove these?" + }, + { + "prediction": "This should be `ErrorDurationInvalidReason`", + "reference": "A lot of things to do with constants seemed to move since the original commit, so I stuck this here, Is there a better place for it?" + }, + { + "prediction": "I think it's better to set it to 10000.", + "reference": "is 10 too small compared to 1000? consider sync chan is unicast only (vs block chan is broadcast + unicast), i would say use 200~400 for BlockSyncChanSize my concern is that this would potentially slowdown sync speed of full-node" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in `Bolt::Puppetfile::Plan`.", + "reference": "A full parse of the plan here on listing the plans will be expensive from both a computation and IO perspective." + }, + { + "prediction": "This should be in `machine_nrf52840_dk.go`.", + "reference": "These constants use the `_PIN` suffix, while the other constants don't use it. I'm not sure what is best, but I would prefer to keep this consistent. Do you have an opinion on which it should be (with or without suffix)?" + }, + { + "prediction": "I think this should be `final`.", + "reference": "Hmm... this feels like discovery should come first. perhaps `--discovery-dns-url`? @NicolasMassart any opinions on this or ideas on who it should be run by?" + }, + { + "prediction": "I'm not sure if this is the right way to do this, but it seems to work.", + "reference": "why is this needed?" + }, + { + "prediction": "`key` is not used in this class.", + "reference": "I wonder if it'd be possible to autogenerate a key from the name within this function if one is not provided explicitly, rather than having all the callsites pass both the name and key (and usually as the same value)? Might give us a good place to implement a `name->key` function that isn't 1:1." + }, + { + "prediction": "I think this should be `TYPE_I32` instead of `TYPE_STRING`.", + "reference": "@adriancole I do not see a change in the thrift file. Are there unit tests verifying that this manual serialization is compatible with the native Thrift serialization done by classes generated from `.thrift` IDL file?" + }, + { + "prediction": "`strlen > PLAYER_NAME_LENGHT` should be `strlen > PLAYER_NAME_LENGTH`", + "reference": "spelling (variable name, all three changes)" + }, + { + "prediction": "`desiredRole` should be `desiredRole keybase1.TeamRole`", + "reference": "I believe you meant \"specify `desiredUID` and `desiredRole`\"?" + }, + { + "prediction": "This import is not used.", + "reference": "Please follow the import style, move it to its similar group" + }, + { + "prediction": "I think this should be `errors.UnrecognizedEncodingError` instead of `errors.RouterUnrecognizedEncodingError`.", + "reference": "Do we really need these? This is expanding on an API that we're about to do work on with the error stuff @kriskowal" + }, + { + "prediction": "I don't think we should remove the `passwordModificationTime` from the `validate` method.", + "reference": "passwordModificationTime is no longer used - did the change drop a time check that should be restored? Or should the param get dropped from the methods?" + }, + { + "prediction": "I think this should be `evt.CommandLine.Trim().Equals(commandLine.Trim(), StringComparison.OrdinalIgnoreCase)` instead of `evt.CommandLine.Trim() == commandLine.Trim()`.", + "reference": "Would it break here without trim? If so, can we do trim in Startup.cs so we don't need to add this code to every parser?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to make the test pass.", + "reference": "Since we're using Logrus, probably best to use `Infof` to avoid confusion (Logrus' Printf behaves differently to the built in one)" + }, + { + "prediction": "I'm not sure why we need to add the margin here, but it seems to be necessary for the flyout button to line up with the flyout.", + "reference": "Hm, this looks like a change that should go upstream as well." + }, + { + "prediction": "why remove this?", + "reference": "let's keep ActionByActionHash and delete getActionByActionHash" + }, + { + "prediction": "I think it would be better to return `PricingGroupInterface` instead of `PricingGroup`.", + "reference": "please use return type" + }, + { + "prediction": "I don't think we need to log this at `FINE` level. I think `INFO` is fine.", + "reference": "This is deliberately at this level." + }, + { + "prediction": "I think this should be `msg: %s, exception: %s`", + "reference": "I'm going to go ahead and undo this change, I don't think it was intentional." + }, + { + "prediction": "I don't think this is a typo, it should be `current` instead of `currnent`", + "reference": "> specialised This isn't a typo in my neck of the woods" + }, + { + "prediction": "I think this should be `github.com/google/knative-gcp/test/cmd/target/storageTarget`", + "reference": "will change to `storage_target`" + }, + { + "prediction": "Why is this change needed?", + "reference": "This would be better as `cls.securitycenter_client`, to match what is being instantiated." + }, + { + "prediction": "I think this should be `nativeSys32 != Syswow64Sys32 and Syswow64Sys32 is not None`", + "reference": "Could we have this initialization as part of the initialize method?" + }, + { + "prediction": "I don't think we need this anymore.", + "reference": "This line should be removed as editController is not used from this context anymore." + }, + { + "prediction": "I don't think this is accurate. The `Process` method is called for each table, not for the entire transformation.", + "reference": "This is correct in concept but the method signature doesn't really communicate the same thing. In other words, if the function produces an output table where is it? Its not on the function signature. Can you explain where the output table is created?" + }, + { + "prediction": "`init_cfg is not allowed to be set` -> `init_cfg is not allowed to be set when pretrained is not None`", + "reference": "For insurance, it's best not to take it directly" + }, + { + "prediction": "I don't think we need to pass `CharSequence[] value` to `beforeChangeValueOf` and `afterChangeValueOf`.", + "reference": "change 'value' to keysToSend, here and in other references in this commit. 'value' implies the user is getting the value of the element, rather than just the keys we're sending to it." + }, + { + "prediction": "I think this should be done in the `provisionContainerResources` method, not in the `startContainer` method.", + "reference": "is the plan to fully migrate to boltdb and then remove the state save here?" + }, + { + "prediction": "This should be `rgb(255, 255, 255)`", + "reference": "This should be `output.colorBright`. Unless I'm missing some reason for adding a new theme variable." + }, + { + "prediction": "This should be `2017` and `3.1.0`", + "reference": "nit: I wonder if these should be moved down to where version is defined, just to keep them all in the same place." + }, + { + "prediction": "I think this should be `import javax.annotation.Nonnull;` instead of `import javax.annotation.*;`", + "reference": "Is this supported by every implementation of Java (and Android)? Should it be conditional upon `gen_nullable`?" + }, + { + "prediction": "Layout/TrailingWhitespace: Trailing whitespace detected.", + "reference": "@briri Thanks! I just caught this too updating my feature branch" + }, + { + "prediction": "I think this should be `if len(configKey) == 0 && envpw != \"\" { fs.Debugf(nil, \"Using RCLONE_CONFIG_PASS password.\") err := setConfigPassword(envpw) if err != nil { fmt.Println(\"Using RCLONE_CONFIG_PASS returned:\", err) } return nil, err }`", + "reference": "I think you should move this block (and the `envpw := os.Getenv(\"RCLONE_CONFIG_PASS\")`) right to the start of the function, then we can remove the duplicate code below" + }, + { + "prediction": "I think this should be `@Ignore` for now. We don't have a good way to test this yet.", + "reference": "Is this only to set the node to draining? I think we can do that inside `Before` or something?" + }, + { + "prediction": "I think this should be `if (AzureAppServices.Metadata.IsRelevant && !string.IsNullOrEmpty(AzureAppServices.Metadata.SiteName)) { return AzureAppServices.Metadata.SiteName; }`", + "reference": "This should have been moved up above this inner `try` because the log message in the `catch` block does not apply to this." + }, + { + "prediction": "I think this should be `type PlanResult = Bolt::PlanResult`", + "reference": "Do we expect people to use PlanResult directly?" + }, + { + "prediction": "nit: `actualErr` -> `err`?", + "reference": "Maybe we should call this something like `errToReturn`?" + }, + { + "prediction": "I'm not sure if this is the right way to do it, but I think it should be `epochNum <= fairBankEpochNum + a.foundationBonusLastEpoch` instead of `epochNum >= fairBankEpochNum && epochNum <= fairBankEpochNum + a.foundationBonusLastEpoch`", + "reference": "should calculate numEpochIn1Year = xxx and <= fairBankEpochNum+numEpochIn1Year a.foundationBonusLastEpoch just happens to be equal to 1 year now, but should not count on that" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it makes the most sense. If we don't count `img` as phrasing, then we don't have to worry about the space between the `img`'s accessible name and other elements' accessible names.", + "reference": "I wasn't sure if the content type needed to be removed from both the `default` and `usemap` objects - I'm not sure how usemap is used." + }, + { + "prediction": "I think we can remove this line.", + "reference": "Duplication of line 28 Please refer your tox -e flake8 It seems that XStrField, XShortField, FieldLenField are not used" + }, + { + "prediction": "I think this should be `except FileNotFoundError as e:` so that we can log the error.", + "reference": "I don't really understand the `self._file_model.index(path)` as parent here - you use `self._root_index` for `rowCount` above, so wouldn't the parent here need to be `self._root_index` as well?" + }, + { + "prediction": "I think this should be `maxQueryLength = 1000000000;` instead of `maxQueryLength = 0;`", + "reference": "Do we want validation somewhere that max >= min? Or simply treat the max < min case as ignoring max?" + }, + { + "prediction": "This change is not related to this PR, but I think it should be reverted.", + "reference": ":+1: that's a easier example :)" + }, + { + "prediction": "I think this should be `findProductIdsWithBoundAttributeByAttributeId(AggregateId $attributeId): array;`", + "reference": "If an external module decorates this interface, such a change will cause it to generate an error" + }, + { + "prediction": "I think this should be `FNM_PATHNAME` instead of `FNM_PERIOD`.", + "reference": "Oh ha hah, FNM_PERIOD worked out nicely there. Points for co-opting a file system convention." + }, + { + "prediction": "remove empty line", + "reference": "wrong grouping. As you can tell from the other files, we put system packages in the first group, the 3rd party packages in the second group, and our own packages in the third group." + }, + { + "prediction": "I think this should be `if _, err := o.configStore.GetJob(o.appName, o.name); err != nil { return err }`", + "reference": "Is `o.name` always set here?" + }, + { + "prediction": "I think this should be `steadyStateDependencies` instead of `steadyStateDependencies`.", + "reference": "Can this line be removed, as `SteadyStateDependencies` isn't updated anywhere? Also do we need to check the `TransitionDependencySet` here?" + }, + { + "prediction": "I'm not sure if this is the best place to put this logic, but I think it makes sense to have it in the `User` model since it's related to the `User`'s `plan`.", + "reference": "`plan.present?` and `has_active_subscription?` are equivalent. We can drop this change, while leaving the one on `app/controllers/application_controller.rb`." + }, + { + "prediction": "I don't think we need to disable this rule here.", + "reference": "No need for this, as pylint already only turns things off for this function and it's needed for the entire function." + }, + { + "prediction": "I think this should be `c.config.Namespaces.AlertmanagerConfigAllowList`", + "reference": "L171 needs to be modified too?" + }, + { + "prediction": "I think this should return -1 if d->nodeid < e->nodeid and 1 if d->nodeid > e->nodeid.", + "reference": "Why do you compare by nodeid? Simply saying d == e should be enough. Unless we have to objects in memory with the same nodeid. If that is so, something went really wrong." + }, + { + "prediction": "Please remove `_base_` and `model` in this file.", + "reference": "configs/pvt/retinanet_pvt_t_fpn_1x_coco.py --> configs/pvt/retinanet_pvt-t_fpn_1x_coco.py" + }, + { + "prediction": "I think this should be `json:\"desiredStatus,omitempty\"`", + "reference": "Nit, this could be json:\",omitempty\"" + }, + { + "prediction": "I think this should be `BuildRequired() (bool, error) { return buildRequired(s.Image.Image) }`", + "reference": "It's kinda funny to read `s.Image.Image` I wonder why it resulted to this way. What would it take to refactor to just `s.Image`?" + }, + { + "prediction": "Why do we need both `integration` and `integration,deploy`?", + "reference": "nit: I like the idea! can we instead change the tag to `integration-remote` to be more specific? I feel like it's possible for us to use the `deploy` build tag for possibly another scenario" + }, + { + "prediction": "`ground2` should be `ground3`", + "reference": "Copy and paste error here. Edit: Also missing commas here and in other Perl croaks between some parameters and not others." + }, + { + "prediction": "Why do we need `stateRoot` here?", + "reference": "stateRoot or maybe ParentHeader would make more sense from API point of view?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get rid of the notification.", + "reference": "Are you sure that this is no longer needed?" + }, + { + "prediction": "nit: I think we can remove `SNAPSHOT_COLUMNS` and use `SCAN_COLUMNS` instead.", + "reference": "Would it help to use SCAN_COLUMNS as base to build SCAN_WITH_STATS_COLUMNS e.g like so `SCAN_WITHSTATS_COLUMNS = ImmutableList.builder().addAll(SCAN_COLUMNS).add(\"value_counts\",....).build()` ?" + }, + { + "prediction": "I think we should remove this method from the proto file as well.", + "reference": "`ctx` is unused in ReportStat" + }, + { + "prediction": "This is not needed.", + "reference": "We don't want to add boost as a dependency when building the Thrift compiler. Sorry." + }, + { + "prediction": "I think this should be `int32_t speedChange = 0;` instead of `int32_t minSpeedChange = 0; int32_t maxSpeedChange = 0;`", + "reference": "It's not printing the range. Also I think it's useful to print a warning above stating that the minimum change is -1000." + }, + { + "prediction": "Why do we need this function? I think we can use `SchedPolicyList` to get the policy by name.", + "reference": "if name is empty will this become enumerate ? (and cause the unmarshal to fail ?)" + }, + { + "prediction": "Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.", + "reference": "How about including a flash message that explains the exercises are only available to subscribers of X plan?" + }, + { + "prediction": "Shouldn't this be `if text in modeparsers.STARTCHARS and e.key() == Qt.Key_Backspace:`?", + "reference": "You should also call `e.accept()` and `return` so the key press isn't processed further (as we're leaving insert mode anyways)." + }, + { + "prediction": "I'm not sure if this is the right place to put this, but I think it should be in `config/environments/production.rb` instead of `config/environments/development.rb`.", + "reference": "Freeze mutable objects assigned to constants." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "Hmm, this feels hacky. Maybe good enough if it makes the test more stable, but why is timing even an aspect here, since below it should wait for these two things anyway?" + }, + { + "prediction": "I think this should be `activity.SetTag(SemanticConventions.AttributeHttpServerIP, xForwardedFor.Split(',').First().Trim());`", + "reference": "Do we want this on by default, or an opt-in (e.g. via some config while add the instrumentation)? I guess a more general question is - what's the bar for the default vs opt-in tags." + }, + { + "prediction": "I think we should keep `/graph` as the path for the graph service.", + "reference": "`status` is just one of the features, named as status is not suitable." + }, + { + "prediction": "I don't think this is the right place to add the icon. It should be done in the layout file.", + "reference": "There is an option to hide the subscriptions list from the sidebar. If it is hidden, the filter text should not be displayed." + }, + { + "prediction": "I think this should default to `true`", + "reference": "I'd like for all of this to be dynamically configurable at some point, but it doesn't have to be in this PR. Can add it to the future SIP or create a separate JIRA for it, as you think would be appropriate." + }, + { + "prediction": "I think this should be reverted.", + "reference": "move the constructor to down the `namespace`" + }, + { + "prediction": "I think this should be a `corev1.ObjectReference` instead of a `corev1.LocalObjectReference`.", + "reference": "Nit: ending with a '.' looks consistent with the fields around it." + }, + { + "prediction": "nit: I think we can remove the `ctx` parameter from `s.fieldsFromJWTSvidParams` now.", + "reference": "Audit log will not have a warning about they are using a deprecated path, is it something we must care about?" + }, + { + "prediction": "Why is this change necessary?", + "reference": "I think you also want to update the condition to add ` || impl.Visibility == TypeMemberVisibility.FamilyOrAssembly`." + }, + { + "prediction": "I don't think we need to change the base gas for this. We can just increase the `DepositToRewardingFundGasPerByte` to `1000` or `10000` and keep the base gas as `10000`.", + "reference": "`DepositToRewardingFundBaseGas` is a global variable (from `gochecknoglobals`)" + }, + { + "prediction": "I think this should be \"Getting Started \ud83c\udf31\"", + "reference": "What do you think of \"operations\"?? Also what do these emojis look like on Linux??" + }, + { + "prediction": "I'm not sure if this is the right place to put this, but I think it would be nice to have a link to the blog post that explains what a team is, and how it works.", + "reference": "I like the word \"give\" here. Feels like I'm giving a gift to my team." + }, + { + "prediction": "I don't think we need to import `make_multilabel_classification` from `sklearn.datasets`.", + "reference": "Is it possible to use `np.random` module instead?" + }, + { + "prediction": "I think this should be `allow_None=False` and `default='white'`", + "reference": "``default=None`` implies ``allow_None`` so ``allow_None`` is superfluous here. As a special case, if allow_None=True (which is true by default if the parameter has a default of None when declared) then a value of None is also allowed." + }, + { + "prediction": "I think this should be `system:k3s-controller` and not `system:k3s-controller-`", + "reference": "Is there anything in particular that makes setting up the downstream rolebinding(s) to `system:k3s-controller` burdensome or confusing? This changes looks fine to me but it seems a shame to alias an embedded k3s controller. If we are doing this in other places that I am not aware of then we can dismiss this concern out of hand." + }, + { + "prediction": "This should be `import \"github.com/ncw/go-acd\"` not `import \"github.com/ncw/go-acd\"`", + "reference": "File is not `goimports`-ed (from `goimports`)" + }, + { + "prediction": "Should this be `OperatingSystem` instead of `Os`?", + "reference": "nit: all other types in this project have full names, so maybe a better name would be `OperatingSystem`?" + }, + { + "prediction": "This should be `#include `", + "reference": "Why is this needed here?" + }, + { + "prediction": "I don't think this is the right thing to do. If the method is not a type variable resolution method, then we should return an empty optional. If it is a type variable resolution method, then we should return an empty optional if the type variables cannot be resolved.", + "reference": "mmm, why a method declaration should not have the TypeVariableResolutionCapability? Is this ok?" + }, + { + "prediction": "I don't think we need to change the order of the parameters here.", + "reference": "nit: any reason you swapped the ordering?" + }, + { + "prediction": "\").dispatchEvent(new CustomEvent(\"change\", {\n bubbles: !0\n }));\n }\n```\nReview comment?", + "reference": "can you de-uglify at least this line?.. hard to tell what changed..." + }, + { + "prediction": "nit: I think we can remove the `GetBPFCalicoDir` method as well.", + "reference": "Please can you merge master in before making these changes. I just reinstated a bunch of BPF UTs. Possible that the UTs use this code." + }, + { + "prediction": "I don't think we need this test.", + "reference": "Do you want to add additional cases for `Bla.__b()` and `self.__c()`? (Just add additional classmethods `__b` and `__c` and the calls to `__init__`)" + }, + { + "prediction": "I don't think this is the right place to do this. I think it should be done in the `search` view, not in the `search.html` template.", + "reference": "the recids is never changed after. So, it should contains the exact shown results, whatever are the rights for the user (admin or simple user, restricted collections...)" + }, + { + "prediction": "I think it would be better to do this in `NewWriter` rather than here.", + "reference": "Shouldn't the docstring mention that the MD5 checksum of `p` is computed each time and verified? Also, could there be use cases where a caller might not want such a check to happen because, eg, a blob storage solution doesn't provide MD5 verification or uses another hash algorithm such as SHA256?" + }, + { + "prediction": "I think it would be better to do this in the `doPreGainFocus` function, rather than in the `executeEvent` function. That way, we don't have to worry about `focusRedirect` being set to `None`, and we don't have to worry about `doPreGainFocus` returning `False` if `focusRedirect` is set to something other than `None`.", + "reference": "focusRedirect is used in the powerpnt appModule. We might have to make sure that this does not break. Having said that, I really like this being handled on the events level!" + }, + { + "prediction": "This should be `github.com/GoogleCloudPlatform/compute-image-tools/osconfig_tests/config` and `github.com/GoogleCloudPlatform/compute-image-tools/osconfig_tests/gcp_clients`", + "reference": "You imports are out of order" + }, + { + "prediction": "I don't think we need to make this public. It's only used in this class.", + "reference": "This should not be called Flow Trigger. FlowTrigger should has its own flowTrigger job name, for instance, \"flowtrigger\"" + }, + { + "prediction": "I don't think we need to create a new package for sqlite3. We can just use `db.NewSQLBase(\"sqlite3\", cfg.SQLite3File)` directly.", + "reference": "File is not `goimports`-ed (from `goimports`)" + }, + { + "prediction": "I think this should be `#if DEBUG && !NETCOREAPP2_1`", + "reference": "Why do we need `\\n` if we already use `WriteLine`? (and `\\n` is not cross platform)" + }, + { + "prediction": "I think this should be `private final String protocol;` instead of `private static final String DEFAULT_METRICS_PROTOCOL = \"prometheus\";` and `private final String protocol;` instead of `private static final String DEFAULT_METRICS_PROTOCOL = \"prometheus\";` and `private final String protocol;` instead of `private static final String DEFAULT_METRICS_PROTOCOL = \"prometheus\";` and `private final String protocol;` instead of `private static final String DEFAULT_METRICS_PROTOCOL = \"prometheus\";` and `private final String protocol;` instead of `private static final String DEFAULT_METRICS_PROTOCOL = \"prometheus\";` and `private final String protocol;` instead of `private static final String DEFAULT_METRICS_PROTOCOL = \"prometheus\";` and `private final String protocol;` instead of `private static final String DEFAULT_METRICS_PROTOCOL = \"prometheus\";` and `private final String protocol;` instead of `private static final String DEFAULT_METRICS_PROTOCOL = \"prometheus\";` and `private final String protocol;` instead of `private static final String DEFAULT_METRICS_PROTOCOL = \"prometheus\";` and `private final String protocol;` instead of `private static final String DEFAULT_METRICS_PROTOCOL = \"prometheus\";` and `", + "reference": "What is instrumentation name used for? I'm not seeing other classes use it, only a getter, constructor, and builder." + }, + { + "prediction": "Why do we need to disable this warning?", + "reference": "@kristofgazso could you review these warnings?" + }, + { + "prediction": "This file should be deleted.", + "reference": "will delete this." + }, + { + "prediction": "I think we can remove the `.html_safe` here, since we're using `I18n.t` with the `html: true` option.", + "reference": "~~Indent 2 lines above~~ Disregard. My fault" + }, + { + "prediction": "Why is this change necessary? I don't think it's related to this PR.", + "reference": "What was the bug that this is fixing?" + }, + { + "prediction": "I don't think this is the right way to do it. The `base64.b64encode` function returns a `bytes` object, not a `str` object, so you need to decode it to a `str` before you can concatenate it with the `Basic ` string.", + "reference": "This will always add the authorization header to the request object. Is this the right scope for these two lines? If username/password are not defined, it will encode 'Basic :'" + }, + { + "prediction": "I think this should be `bazel-bin/com_github_google_flatbuffers/tests/` instead of `../com_github_google_flatbuffers/tests/`", + "reference": "Is this always how Bazel does paths? Would it be nicer to do `-DBAZEL_TEST_DATA_PATH=../com_github_google_flatbuffers/tests/` so this string is not hardcoded in the the source?" + }, + { + "prediction": "`date_utc` added so we can be sure to get the actual date and time based upon UTC and not the client date and time based on the client machine. `date_utc` added so we can be sure to get the actual date and time based upon UTC and not the client date and time based on the client machine.", + "reference": "Not an expert of ES, so not sure of the impact here." + }, + { + "prediction": "I don't think you need to declare granteeList here. You can just pass NULL to getRoleList.", + "reference": "Who deletes the memory for the granteeList? (or the roleList for that matter)" + }, + { + "prediction": "Shouldn't this be done in the destructor of `listener`?", + "reference": "This loop is missing a lock on subscriptions_mutex." + }, + { + "prediction": "Line is too long. [101/80]", + "reference": "shouldn't clearance be setting these up for us?" + }, + { + "prediction": "I'm not sure I like the name \"noOp\" here. I think it would be better to call it something like \"disabled\" or \"noop\" or \"null\" or something like that. \"noOp\" makes me think of a function that does nothing, but that's not what this is.", + "reference": "Need to update the doc for `TelemetrySDK` and `Host` structs deleting references from removed functions." + }, + { + "prediction": "Why is this not needed anymore?", + "reference": "I think we should keep that here and add a new method `isSyntacticallyFinal` that returns `super.isFinal()` (and can be used in UnnecessaryModifier). Otherwise the contract of `isFinal` is not respected" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the `scrollIfNecessary` function.", + "reference": "Is there a reason why we wouldn't want to check this every time? Why are we only checking for the footer and scroll bar when enableCellEditOnFocus is true?" + }, + { + "prediction": "I don't think this import should be here.", + "reference": "You need to create an API for this class. This class should follow roughly the same dependency structure than RemoteAvailableInstallersPlayOnLinuxImplementation / RemoteAvailableInstallers. Maybe we could use a inner class here?" + }, + { + "prediction": "Why do we need to update `workflow_id` here?", + "reference": "This should not be a case, right? If `run_id` is the same `workflow_id` can't be changed. Actually surprised that it is not part of a key." + }, + { + "prediction": "Why is this disabled?", + "reference": "How would AQR work for an INSERT/SELECT of one table into another where a LOB column is being copied?" + }, + { + "prediction": "I'm not sure if this is a good idea, but I think it would be nice to have a single `sds` package that contains both the v2 and v3 implementations. That way, we don't have to worry about which version of the SDS API we're using, and we don't have to worry about which version of the SDS implementation we're using. I'm not sure if this is a good idea, but I think it would be nice to have a single `sds` package that contains both the v2 and v3 implementations. That way, we don't have to worry about which version of the SDS API we're using, and we don't have to worry about which version of the SDS implementation we're using. I'm not sure if this is a good idea, but I think it would be nice to have a single `sds` package that contains both the v2 and v3 implementations. That way, we don't have to worry about which version of the SDS API we're using, and we don't have to worry about which version of the SDS implementation we're using. I'm not sure if this is a good idea, but I think it would be nice to have a single `sds` package that", + "reference": "Since these are ultimately different endpoints, it would be nice if we could move them up one level and nuke the common `sds` directory in order to reduce path stutter" + }, + { + "prediction": "I don't think we need to check `beforeChangeResult[0] === null` here. `beforeChangeResult.length === 0` should be enough.", + "reference": "Please check also whether `null` occurs in the rest of `beforeChangeResult` array." + }, + { + "prediction": "I don't think we need to mention that this is client-side.", + "reference": "Outdated docs. There is no response, there's an ack." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the right thing to do.", + "reference": "I'd rather have the container process remove the FIFO after it unblocks. Then `start` can always `Exec()`, and you can catch the \"FIFO does not exist\" error and translate it to a prettier \"someone must have already started the container\"." + }, + { + "prediction": "Why do we need to check `tx == nil` here?", + "reference": "can you check if there's other similar cases to add nil-check like this?" + }, + { + "prediction": "I think this should be `is_valid_commonname = commonname is not None and len(commonname) < 64`", + "reference": "`<= 64`? I just picked up what you said in #3981 (\"the CN field is limited to 64 characters\") but maybe there's something I don't know where the 64th character is needed (trailing dot or whatever?) Also this sounds like something that could be beautifully unit tested. Sorry for bugging you :grin:" + }, + { + "prediction": "Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
Line is too long. [81/80]", + "reference": "I understand that this grabs a Licenses objects but what is the autocomplete method used for? What does this do in context of the auto_completes controller?" + }, + { + "prediction": "I think this should be called `getTransactionLocationByHash` to be consistent with the other methods in this class.", + "reference": "I don't really like that way of naming methods based on their arguments. But I can see that the other method names are the same ..." + }, + { + "prediction": "I think this should be `value.endsWith(\"\\\\\") || value.endsWith(\"/\") || value.endsWith(\"-\") || value.endsWith(\".\") || value.endsWith(\":\") || value.endsWith(\"*\") || value.endsWith(\"?\") || value.endsWith(\"\\\"\") || value.endsWith(\"<\") || value.endsWith(\">\") || value.endsWith(\"|\") || value.endsWith(\" \") || value.endsWith(\"\\t\") || value.endsWith(\"\\n\") || value.endsWith(\"\\r\") || value.endsWith(\"\\b\") || value.endsWith(\"\\f\") || value.endsWith(\"\\u000B\") || value.endsWith(\"\\u000C\") || value.endsWith(\"\\u000E\") || value.endsWith(\"\\u000F\") || value.endsWith(\"\\u0010\") || value.endsWith(\"\\u0011\") || value.endsWith(\"\\u0012\") || value.endsWith(\"\\u0013\") || value.endsWith(\"\\u0014\") || value.endsWith(\"\\u0015\") || value.endsWith(\"\\u0016\") || value.endsWith(\"\\u0017\") || value.endsWith(\"\\u0018\") || value.endsWith(\"\\u0019\") || value.endsWith(\"\\u001A\") || value.endsWith(\"\\u001B\") || value.endsWith", + "reference": "@sekmiller This method correctly strips the leading and trailing slashes (and also \".\" and \"-\"); But I thought the plan was also to replace any multiple slashes between nested folders with a single slash. For example, as implemented now, I can enter \"folder1///folder2\", and it gets saved and displayed like this, with the 3 slashes. I thought we wanted to sanitize it as \"folder1/folder2\"." + }, + { + "prediction": "This should be `pid_t` instead of `int64_t`.", + "reference": "Looks like the X86 inline assembly is not happy with this type. I will update that" + }, + { + "prediction": "I don't think we need the ` ` here.", + "reference": "Tabs and a space, again." + }, + { + "prediction": "I'm not sure this is the best way to do this. I think it would be better to have a `QuestManager::GetTaskName()` function that returns a `std::optional`. Then you can do something like `if (auto task_name = quest_manager->GetTaskName(task_id)) { ... }`", + "reference": "Please just enclose if blocks with brackets; this has created issues in the past so I'd prefer we don't use them" + }, + { + "prediction": "I'm not sure about this change. I think it should be `@proposal.cart_id` instead of `@proposal.cart.id` because `@proposal.cart` is a `Cart` object and not a `CartDecorator` object.", + "reference": "`version` isn't need anymore because it's built into `approve_proposal_url`, yes?" + }, + { + "prediction": "I don't think we need to import `_dbmField` from `dot11`.", + "reference": "Moved to the bottom of the file. `CtrlPDU` sits on `BTLE_DATA` so let's put it after" + }, + { + "prediction": "Trailing whitespace detected.", + "reference": "This ends up requiring the `json` gem, right? Is there any way we can do this to be implementation agnostic (e.g. to let me use `yajl-ruby` for performance reasons (or because my app already brings in a JSON library)" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should return an error if we read 0 bytes and the error is not EOF.", + "reference": "This seems dangerous. What circumstances lead to the need for a retry? Can that happen more than once? I'm concerned that if we hit the pathological state, this could turn into a CPU spinner. I wonder if we could get the same benefit from just \"trying again\" and failing if it fails the second time." + }, + { + "prediction": "nit: I think it would be better to use `Optional` instead of `null` here.", + "reference": "If there is a reference to other fields or methods, please do the initialization in the constructor." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it works for now.", + "reference": "These should be importing from `pill-container`" + }, + { + "prediction": "I think this should be `RETURNVALUE_NOTPOSSIBLE` as well.", + "reference": "Why this change? It will now only show on the bottom of the screen as white text, is it correct behaviour?" + }, + { + "prediction": "I'm not sure if this is the best way to handle this, but it seems to work.", + "reference": "Does this need to allocate a string or would a nil value (indicating no header) be a better?" + }, + { + "prediction": "I don't think this is needed. `this.constructor` is already set to `Component` in the constructor.", + "reference": "Nit: Past tense of `reset` is also `reset`." + }, + { + "prediction": "I think it would be better to have this in the `wallet.py` file, not in the `commands.py` file.", + "reference": "Shouldn't this use `'n'` instead?" + }, + { + "prediction": "I don't think we need to change the timer task type here. I think we can keep it as `enumsspb.TASK_TYPE_ACTIVITY_TIMEOUT` and `enumsspb.TASK_TYPE_DECISION_TIMEOUT` and just change the timer task type in `timerTaskBase` to `enumsspb.TASK_TYPE_ACTIVITY_TASK_TIMEOUT` and `enumsspb.TASK_TYPE_WORKFLOW_TASK_TIMEOUT`", + "reference": "revert back to 'TASK_TYPE_ACTIVITY_TIMEOUT'" + }, + { + "prediction": "I think this should be `template void Engine::GetBlock(const std::string &, T **, const Mode);` instead of `template void Engine::GetBlock(Variable, T **, const Mode);`", + "reference": "Shouldn't we prefer passing a pointer by reference T*&, since these are C++ bindings?" + }, + { + "prediction": "I think we can remove the `cgExists` variable and just use `len(ingressRule.SourceGroups) > 0`.", + "reference": "nit: Personally I feel that it's cleaner to let `toAntreaPeerForCRD` to take `ingressRule` as a param instead of `ingressRule.From`. It can call `processRefCGs` inside the function and do the ipBlock/AG union within the function itself. It might not be worth the refactor though." + }, + { + "prediction": "Should this be `apis.ReconcilePending` or `apis.ReconcileInProgress`?", + "reference": "Pending has been set only for SPC.. why? for other CRs as well, this need to be done.. right?" + }, + { + "prediction": "I don't think we need to set this to `false` by default, it should be `true` by default.", + "reference": "would use an empty string here as default and then check for emptiness in the twig template. I dont like mixing types @core23 what do you think?" + }, + { + "prediction": "I think this should be `methodInfo.responsePageTokenName()` instead of `methodInfo.responsePageTokenName().toUpperCamel()`.", + "reference": "How come we need case manipulation for the nextPageToken and not for pageToken?" + }, + { + "prediction": "I think this should be `put` instead of `post`.", + "reference": "why use these rather than regular named paths?" + }, + { + "prediction": "Should this be `OPTIONS[:global] + %w[format]`?", + "reference": "Hm, I don't think the extra flags are doing any harm here, but it does seem like `--help` is the only flag you could *actually* use with this command. We might eventually want to separate those out." + }, + { + "prediction": "I'm not sure if this is the right place to put this docstring. I think it would be better to put it in the docstring of the `create_candidate_sets_for_all_users` function.", + "reference": "We should make this a docstring, so that editors are able to pick it up." + }, + { + "prediction": "I'm not sure if this is the best way to test this, but it seems to be the only way I could get it to work.", + "reference": "Put a comma after the last parameter of a multiline method call." + }, + { + "prediction": "Why is this removed?", + "reference": "App cache size is now managed dynamically by the `WebView`. This statement has no effect in the new framework." + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "VirtualNode has a `hasAttr` function, any reason why you're not using it?" + }, + { + "prediction": "I don't think we need this anymore.", + "reference": "This now throws when running tests (maybe the move to java 11??). Do we want to keep it?" + }, + { + "prediction": "I think this should be `if len(sha1) >= 7`", + "reference": "We can allow 7-char SHA, does not mean we want to show with 7-char in default, please change to `if len() > 10`, then cut." + }, + { + "prediction": "`Cannot add the duplicate file %{fileName}, it already exists` -> `Cannot add the duplicate file %{fileName}. It already exists.`", + "reference": "this one should also have quotes i guess :)" + }, + { + "prediction": "I'm not sure this is the right fix. I think we should be using `b.unstruct.object.GetName()` instead of `b.unstruct.Object.GetName()`.", + "reference": "Using the variable on range scope `mock` in function literal (from `scopelint`)" + }, + { + "prediction": "I think this should be `res.isCompleted() ? ok(json(res.getDataset())) : accepted(json(res.getDataset()));`", + "reference": "does this result in a 200 when the dataset is still inprogress/publishing not yet finalized? Seems like 202 is the right code for that (as it was) and the test should be watching for a 202?" + }, + { + "prediction": "I think this should be `ORDER_BY` instead of `ORDER_PATH`.", + "reference": "Previously you could only order by the field you were searching by. But for full-text search, you can search across all indexed fields, and it didn't make sense not to have a sorting. For backward compatibility, the javascript code uses indexPath as the orderPath when no orderPath is provided." + }, + { + "prediction": "nit: I think we can remove the extra backticks here.", + "reference": "VIM didn't like your whitespace." + }, + { + "prediction": "I think we can remove the `using Datadog.Trace.ClrProfiler;` as well.", + "reference": "Are you sure the namespace should change?" + }, + { + "prediction": "I don't think we should change the return type of this method. I think it should remain `void` and the `object` parameter should be renamed to `startupHint` or something like that.", + "reference": "@martijn00 I'm not sure why we're keeping the object parameter and return type since this can be done by using MvxApplication with THint set to object" + }, + { + "prediction": "I think it's better to use `new TimeType(MySQLType.TypeDuration)` instead of `new TimeType(MySQLType.TypeDuration)`.", + "reference": "why do we create a time type here?" + }, + { + "prediction": "I don't think you need to include the css file here. The css file is already included in the html file.", + "reference": "Does this style actually need to get loaded in all of these components?" + }, + { + "prediction": "remove unused import", + "reference": "import but not used so you did not resolve compile warnings?" + }, + { + "prediction": "I don't think this is correct. If armor is 1, then the damage should be reduced by 1. If armor is 2, then the damage should be reduced by 1 or 2. If armor is 3, then the damage should be reduced by 1, 2, or 3. If armor is 4, then the damage should be reduced by 2, 3, or 4. If armor is 5, then the damage should be reduced by 2, 3, 4, or 5. If armor is 6, then the damage should be reduced by 3, 4, 5, or 6. If armor is 7, then the damage should be reduced by 3, 4, 5, 6, or 7. If armor is 8, then the damage should be reduced by 4, 5, 6, 7, or 8. If armor is 9, then the damage should be reduced by 4, 5, 6, 7, 8, or 9. If armor is 10, then the damage should be reduced by 5, 6, 7, 8", + "reference": "This is so much more concise and beautiful than the previous formula" + }, + { + "prediction": "This should be `private final Logger LOG = LogManager.getLogger(AcceptanceTestBase.class);`", + "reference": "Is there any reason not to have the `static` modifier for the logger? _(that would be in keeping with the reference being uppercase)_" + }, + { + "prediction": "I don't think we need this interface. We can just use `map[string]interface{}`.", + "reference": "It's not about session creation config. It's about passing consumer config parameters to underlying transport - nothing to do with session itself" + }, + { + "prediction": "I think this should be `overrideEnableDebug bool` instead of `overrideEnableDebug *bool`.", + "reference": "Why is there an \"enable\" in the param name? Couldn't it just be `overrideDebug`? Here are everywhere else." + }, + { + "prediction": "Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.", + "reference": "`published.recently_published_first` reads a little oddly to me. Is this the same thing as `Video.published.ordered`?" + }, + { + "prediction": "`throw new Error('Unable to parse content of ' + file.originalPath)` -> `throw new Error('Unable to parse content of ' + file.originalPath + ': ' + e.message)`", + "reference": "Encountered this because I had a stray comma. Figured I'd tweak it a bit." + }, + { + "prediction": "I think this should be `Eventually(getCIDRBlockRules(felix, \"ip6tables-save\"), \"8s\", \"0.5s\").Should(BeEmpty())`", + "reference": "qq: Should this include the iptables6-save sim. to the inverse checks above?" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "im open to explicitly checking NotSet value here but json logic already handles it so kept it this way." + }, + { + "prediction": "This should be `#include \"Util/Lua.h\"`", + "reference": "The naming of the include file appears to be unlucky." + }, + { + "prediction": "I think this should be `self.legend_opts.update(leg_spec)`", + "reference": "Bit worried about this. At minimum you should make a copy of the dict here to avoid modifying a user supplied variable." + }, + { + "prediction": "nit: I think it would be good to add a log message here to indicate that we are pruning the launch template versions.", + "reference": "Is it better to create one before pruning? In case creation fails we don't want to delete the previous one. We create a new one, it is tagged as latest, so the previous can be deleted. `CreateLaunchTemplateVersion` returns the version created, how about directly trying to delete the previous version? Assuming the numbering is strictly increasing." + }, + { + "prediction": "I don't think this is a good idea. The `ContainerInformationTab` should be able to handle any kind of container, not just `WinePrefixContainerDTO`.", + "reference": "Do we require the specific implementation information here?" + }, + { + "prediction": "Style/PercentLiteralDelimiters: Use %q unless you need interpolation or special jobbing (such as newlines).", + "reference": "How about `exists?(['domain ~* ?', domain.downcase])` ?" + }, + { + "prediction": "I think this should be `c.IsSet(FlagContextTimeout)` instead of `c.GlobalIsSet(FlagContextTimeout)`.", + "reference": "Is this getting used in other places? Can we switch all the places to use the new API you added?" + }, + { + "prediction": "I don't think we need this anymore.", + "reference": "This need to be checked with linux. AFAIK, we have this file in our bin directory that is a link to the system file." + }, + { + "prediction": "I don't think we need to disable indent here.", + "reference": "Shouldn't we import `default`? I can't get here to test." + }, + { + "prediction": "`ParseResult` should be backticks, not backticks.", + "reference": "!!!!!!!!!!!!! @graingert, does this mean that tests haven't been running???" + }, + { + "prediction": "Why is this change necessary?", + "reference": "I've already tried the null-coalescing operator here and got a strange error, so did this the old-fashioned way." + }, + { + "prediction": "`parentRole === 'list'` should be `parentRole === 'list' || parentRole === 'listitem'`", + "reference": "This doesn't follow our spacing convention. It's also a little hard to read. Can you reformat?" + }, + { + "prediction": "nit: I think we can remove the `internal/pkg/deploy` import and just use `deploy` here.", + "reference": "The deploy should come before template? EDIT: I see that in other files, we put a separate line and put deploy at the end. What is the reason for this?" + }, + { + "prediction": "I'm not sure this is the right thing to do here. I think we should keep the `DropAggregationConfig` as the default, and just add the `MetricStreamConfiguration` to the `AddConsoleExporter` method.", + "reference": "Consider making a constant (e.g. `MetricStreamConfiguration.Drop`)." + }, + { + "prediction": "I think this should be `from rdkit.six import xrange`", + "reference": "same question: why not just switch this to range too?" + }, + { + "prediction": "I think this should be `if (type == Type::Unknown)`", + "reference": "@chuckatkins most places used an empty string for \"no type\", but a few used `\"unknown\"`. I've converted both cases to `Type::None`. Do you know why there was a distinction before?" + }, + { + "prediction": "Why do we need to do this?", + "reference": "should we assert for the type for `FeatureGroupData` ? I think it should be 1-Byte type." + }, + { + "prediction": "I think this should be `np.flipud(...)`.", + "reference": "As long as you are sure this is definitely correct now... :-)" + }, + { + "prediction": "I think this should be `tempBasalCancel.setText(MainApp.instance().getString(R.string.cancel) + \": \" + activeTemp.toStringShort());`", + "reference": "... so that all action buttons have the same height :-)" + }, + { + "prediction": "This file is not used in this PR. Please remove it.", + "reference": "Use correct, alpha sorted, include order. Correct order means: 1. Header corresponding to this source (i.e. `\"LatencyTestPublisher.hpp\"`) 2. C system headers 3. C++ system headers 4. Alpha-sorted external libraries headers 5. Alpha-sorted public headers from this project 6. Alpha-sorted private headers" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `http` package.", + "reference": "I hate this name, open to suggestions." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should just return an error and let the caller handle it.", + "reference": "Does this log line work? We need Warningf or just warning without the format string." + }, + { + "prediction": "I think this should be `c.MetricsProcessors` instead of `c.MetricsProcessors...`", + "reference": "The pull controller would need similar updates." + }, + { + "prediction": "I think this should be 2016-2018", + "reference": "ignore this.. just didn't want to litter with a commit update to satisfy license plugin" + }, + { + "prediction": "I'm not sure why this change was made, but I think it should be reverted.", + "reference": "Is this definition needed since it doesn't look like it's being used anywhere?" + }, + { + "prediction": "Trailing whitespace detected.", + "reference": "Can this condition be reworded using `if` please?" + }, + { + "prediction": "`inputs != nullptr && !inputs->hasData()` -> `!inputs->hasData()`", + "reference": "after ||, no need inputs != nullptr" + }, + { + "prediction": "I think this should be `IntegrationTestBuildspecPath` instead of `IntegTestBuildspecPath` to be consistent with the rest of the codebase.", + "reference": "Is it just preference or on purpose that using slice of structs instead of slice of pointers?" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think it should be `newVNode._dom = oldDom!=null ? oldDom!==oldVNode._dom ? oldDom : oldVNode._dom : null;`", + "reference": "This line always confused me anyway. Good catch!" + }, + { + "prediction": "I think this should be `j.jServer.shutdown(context.Background())`", + "reference": "Should we add `ctx` to `BlockServer.Shutdown()` for this purpose? Would be nice, but I don't care too much." + }, + { + "prediction": "I think this should be `period.nanosec / 1000000000`", + "reference": "Duration_t at RTPS level must be serialized using fractions." + }, + { + "prediction": "I think this should be `yarpcerrors.InvalidArgumentErrorf(msgInboundDispatcherNotRunning, service)`", + "reference": "\"peer\" has its own meaning within YARPC with its own class of objects. This should probably be \"dispatcher\" too?" + }, + { + "prediction": "I don't think we need to do this for clang 5.0, right? It should work out of the box with clang 5.0, right?", + "reference": "I do not like this line break before `=true`. Maybe starting the list in the next line would help to reduce the indent? This way we could keep this string together." + }, + { + "prediction": "why remove these flags?", + "reference": "_plugins should be removed too" + }, + { + "prediction": "I think this should be `!validAttrValue`", + "reference": "The rule selector will not include `` and `` elements. Why not make this a new, separate rule altogether?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it makes sense.", + "reference": "@The-Compiler Is this style okay or would you prefer a common userscript exception base?" + }, + { + "prediction": "I don't think we need to pass `sub_type` to `toObject`", + "reference": "we'd need to return a MongooseBuffer here instead of the Binary. lets add the subtype option to the buffer schema type as referenced in #1000 instead." + }, + { + "prediction": "Please remove this empty line.", + "reference": "Let's remove this change." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get \"not selected\" to be spoken for table cells.", + "reference": "Could you split this into multiple lines?" + }, + { + "prediction": "I think this should be `currentEntityURL || global.googlesitekit.permaLink` instead of `currentEntityURL ? ... : global.googlesitekit.permaLink` so we don't fall back to `global.googlesitekit.permaLink` if `currentEntityURL` is falsy.", + "reference": "This technically works, however it may be safer to use both `getCurrentReferenceURL` and `getCurrentEntityURL` and then make this condition `currentReferenceURL === currentEntityURL`. Currently, this code only works based on the internals of `getCurrentReferenceURL`, so by checking both we would decouple that." + }, + { + "prediction": "I'm not sure about this change. I don't think we should change the case of the first letter of the word \"response\".", + "reference": "It does not recommend capitalization" + }, + { + "prediction": "I'm not sure if this is the best way to test this, but it works for now.", + "reference": "Minor thing, but can you use 1.9 hash syntax for this?" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but it seems to be the only place where `lambda_cwd_on_host` is used.", + "reference": "I tried to follow the code structure already present." + }, + { + "prediction": "I think this should be `from.toPath().toString()`.", + "reference": "seems reasonable to also want to include the 'to' location?" + }, + { + "prediction": "I think this should be `resource_filename(\"nupic.core\",\"\")`", + "reference": "Please leave 1 space char between commas here and other places in this PR." + }, + { + "prediction": "I think this should be `||` instead of `&&`.", + "reference": "hm is this really &&? Not ||? Was it initially correct if any of these things are not set that it needs to recreated?" + }, + { + "prediction": "I think this should be `cli.hasOption(\"collections\")` instead of `cli.hasOption(\"cluster\")`", + "reference": "Please don't use C-style array declarations. IMO our pre-commit ought to be enhanced to not allow this" + }, + { + "prediction": "I think this should be `strcmp(p->data.compressed_string, p1->data.compressed_string) == 0`", + "reference": "@rhc54 This doesn't look like a comprehensive comparison. For `PMIX_STRING` we seem to actually compare the content of the data while here we only compare meta-information which doesn't ensure that values are the same." + }, + { + "prediction": "This should be `const bool confirmed_frontiers = request.get (\"confirmed_frontiers\", false);`", + "reference": "I think `bypass_frontier_confirmation` conveys the intention better (default false as well)" + }, + { + "prediction": "I think we can remove the `require` import here as well.", + "reference": "This looks like it goes beyond the scope of removing `BlockHeight()`, in the future please do this in a separate commit at a minimum -- separate PR is fine too." + }, + { + "prediction": "I don't think we need to pass the `tab` to the `AbstractAudio` class. The `AbstractAudio` class should be able to get the `tab` from the `self._widget`.", + "reference": "You'll also need to adjust `FakeWebTabAudio` in `tests/helpers/stubs.py`." + }, + { + "prediction": "I think we should keep the license header.", + "reference": "@csrwng what should we do here? This one is from origin." + }, + { + "prediction": "I don't think we need to include LocaleContext here.", + "reference": "Follow alphabetical order." + }, + { + "prediction": "I don't think we need this interface. We can just use `IAutomaticTracer` directly.", + "reference": "As far as I can tell, these always get and set the context as an `IReadOnlyDictionary`. Can we use that here instead of `object` and get rid of the `as IReadOnlyDictionary`?" + }, + { + "prediction": "I don't think this change is correct. The `` tag is used to highlight the matching text. Without it, the matching text will not be highlighted.", + "reference": "As you only have `{}` as the format string (without anything else in it), this is the same as doing `self._doc.setHtml(html.escape(self._opt.text))`" + }, + { + "prediction": "I think this should be `AZKABAN_SECURITY_CREDENTIAL`", + "reference": "Where would this be configured? In azkaban.properties?" + }, + { + "prediction": "Shouldn't this be `checkForAtomicOperators(update.$set || {})`?", + "reference": "1. Use `const` instead of `var` here. 2. Move the check to after the `if (update == null || typeof update !== 'object')`." + }, + { + "prediction": "nitpick: I think it would be better to use `#if defined(__linux__) && LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 27)` instead of `#if defined(__linux__) && LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 27)`", + "reference": "Let's assume that on Linux `eventfd` is always available as a wrapper of the eventfd2 system call. It is supported since linux 2.6.27 + glibc 2.9, as well as from the ancient versions of bionic. In other words, it would be fair to argue that the pair would be available on practically all platforms that provide `pipe2`. Therefore switching from using `pipe2` to `eventfd` on linux unconditionally would not cause issues on our users." + }, + { + "prediction": "I think it's better to initialize it in the constructor.", + "reference": "This field could be `final`." + }, + { + "prediction": "Metrics/LineLength: Line is too long. [137/120]", + "reference": "would be good to have a test for the case when `shutdown!` raises" + }, + { + "prediction": "I think this should be `if (CmpCommon::getDefault(HBASE_ASYNC_OPERATIONS) == DF_ON && (t == ComTdbHbaseAccess::INSERT_ || t == ComTdbHbaseAccess::UPDATE_ || t == ComTdbHbaseAccess::DELETE_)) { hbasescan_tdb->setAsyncOperations(TRUE); } else { hbasescan_tdb->setAsyncOperations(FALSE); }`", + "reference": "Does upsert pass this check also?" + }, + { + "prediction": "I'm not sure this is the right place to log the output of the patch command. I think it would be better to log the output of the `kubectl patch` command.", + "reference": "Apologies reviewers, I did end up pushing another change. I was starting to request SRE-P help to get the apiserver configs from some clusters before and after when I realized I can just log the stdout from the patch command to see if anything was changed or not. Much simpler to verify if my work did or did not make changes to the config during the transition. Also got the spacing issue you mentioned @abhinavdahiya Thanks all." + }, + { + "prediction": "I think this should be `kbfsConfigName + \".DS_Store\"`", + "reference": "I'm not sure this naming is a good idea; that's the format for macOS xattr metadata files on unsupported filesystems." + }, + { + "prediction": "Metrics/LineLength: Line is too long. [83/80]", + "reference": "Metrics/LineLength: Line is too long. [85/80]" + }, + { + "prediction": "I think we can remove this import.", + "reference": "Please remove these imports. The project's style is to use `Assert.assertEquals` and not import static methods in general. This also caused a lot of unnecessary changes." + }, + { + "prediction": "I think this should be `FLB_ERROR` instead of `FLB_RETRY`.", + "reference": "thanks. Note that returning at this point might leak memory from the allocations above, so the PR will need to take care of that too." + }, + { + "prediction": "I think this should be `self.config_state_before_fullscreen` instead of `config.val.content.desktop_fullscreen`", + "reference": "If you really want to rename this, you'll also need to adjust the name in `__init__` and in other places it's used (`browser/commands.py`)." + }, + { + "prediction": "I'm not sure why this doesn't work, but it's not a big deal for now.", + "reference": "As discussed at standup, I gave up on this. Calling `DeleteMapLayerMetadataCommand` felt cleaner anyway because there might be other cleanup that needs to happen. @scolapasta and @matthew-a-dunlap plan to discuss this." + }, + { + "prediction": "This should be removed before merging.", + "reference": "Do we need these changes? If so, can you tidy up the messages? Looks like it might have been your testing/debugging changes" + }, + { + "prediction": "I don't think we need to expose this to the user. I think we should just use `CONTAINER` as the default and not allow the user to change it.", + "reference": "where is the default being set?" + }, + { + "prediction": "I think this should be `matches[1].start` and `matches[1].length` instead of `matches[2].start` and `matches[2].length`.", + "reference": "these changes should likely be in the next commit instead" + }, + { + "prediction": "I think we can remove this now that the table formatter is implemented.", + "reference": "Since you have defined this struct, I would suggest to replace all exist literal structs by this." + }, + { + "prediction": "I think this should default to `false` instead of `true`.", + "reference": "The field name doesn't really capture what this option does. I think `mConfirmDiscardMessage` would be a better choice." + }, + { + "prediction": "I don't think this is the right place to do this check. I think it should be done in the `setBinaryContent` method of the `Media` class.", + "reference": "what if `$media->getBinaryContent() == Symfony\\Component\\HttpFoundation\\File\\File` does `is_string()` return `true`? ping @greg0ire" + }, + { + "prediction": "I think this should be `if (field.nested_flatbuffer && field.nested_flatbuffer->type.struct_def) {`", + "reference": "maybe rather than `bool` make this field a `StructDef *` ?" + }, + { + "prediction": "I don't think we need to add to the waitgroup here, since we're not waiting for the blocks to be deleted.", + "reference": "Shall we maybe put this in a `const` like `backgroundTaskTimeout`?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get the tests to pass.", + "reference": "CI is complaining about this." + }, + { + "prediction": "I think this method should be moved to the `HistoryRemovalTimeProvider` interface, so that it can be used by the `DefaultHistoryRemovalTimeProvider` as well as by any custom implementation of the `HistoryRemovalTimeProvider` interface.", + "reference": "Let's only change a file if it is really necessary. Such a change does not bring much value and makes it harder to find the original commit in which the method was introduced." + }, + { + "prediction": "`sprintf('%s%s', $useLazyLoading ? 'lazy' : '', $isAttributeClassExistsAndNotEmpty ? ' ' . $attributes['class'] : '')` can be simplified to `sprintf('%slazy%s', $useLazyLoading ? '' : ' ', $isAttributeClassExistsAndNotEmpty ? ' ' . $attributes['class'] : '')`", + "reference": "I would prefer to set up space between classes in format pattern, `%s %s` and then use `trim()` to remove unnecessary whitespaces. This will also solve stripping whitespaces from the beginning and end of a string `$attributes['class']`" + }, + { + "prediction": "`LOG(ERROR) << \"unknown setence type[\" << sentence_->getType() <<\"]\";` -> `LOG(ERROR) << \"unknown sentence type[\" << sentence_->getType() <<\"]\";`", + "reference": "when Op is illegal should return here?" + }, + { + "prediction": "Why is this removed?", + "reference": "don't we need to remove the project version from installedVersions?" + }, + { + "prediction": "I don't think we need the `&&=` here. We can just do `options[:page_ranges] = Array(options[:page_ranges])`", + "reference": "the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here." + }, + { + "prediction": "I think this should be `if err != nil { s.IPSetLocker.Unlock(ipset.Name) return nil, err }`", + "reference": "This is intended. Pls revert this." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the least bad option.", + "reference": "Something wrong with cast to `(Comparator<> & Serializable)`, need to be investigated" + }, + { + "prediction": "I don't think we need this anymore.", + "reference": "I think we need this. Not sure, I'll test." + }, + { + "prediction": "I'm not sure why this was removed, but it seems like it should still be there.", + "reference": "I'm going to need to check if google compute requires these steps in this order, or if you can disable iptables after the fact." + }, + { + "prediction": "I don't think we need this anymore.", + "reference": "Did go change their tags with the new version?" + }, + { + "prediction": "I'm not sure this is the right thing to do, but I think it's the best we can do for now. We need to be able to get the trust domain config from the data store, but we also need to be able to get the federates with config from the config file. I think this is the best we can do for now, but I'm open to suggestions.", + "reference": "I don't recall what we decided here in terms of which source would get priority. As written, the static configuration will overwrite datastore results." + }, + { + "prediction": "I think this should be `len(dep.Outputs()) > 0` instead of `len(dep.Outputs()) > 1`.", + "reference": "I think it should still panic for when there are no outputs; might be nice to special-case that though so the message is more explicit." + }, + { + "prediction": "I think this should be `new MetricsConfig.MetricsConfigBuilder().build()`", + "reference": "*NULL_DEREFERENCE:* object `null` is dereferenced by call to `meterSupplier(...)` at line 122." + }, + { + "prediction": "I think this should be `readPreference.mode !== 'primaryPreferred'`", + "reference": "switch over to .mode" + }, + { + "prediction": "Please revert this change. It's not needed.", + "reference": "I guess your IDE did some auto-fixing here" + }, + { + "prediction": "nit: remove the empty line", + "reference": "This is an unused import failing recommit still." + }, + { + "prediction": "Line is too long. [84/80]", + "reference": "I'm concerned that we're conflating multiple things here. There are 2 things that Beaker should really care about: - Network transport - i.e. `ssh` vs `winrm` - Interpreter - i.e. `bash`, `cmd`, `powershell`, etc The problem is that @cowofevil is running Bitvise SSH, and he assumed we should be setting `is_cygwin: false` in node definitions. But that doesn't really accurately convey what we care about, and since Beaker doesn't appear to track network transport apart from interpreter, we end up in a strange state. `is_cygwin: false` appears to end up setting `is_powershell?` to `true`, which IMHO is not accurate or appropriate. Bitvise templates use `ssh` (like Cygwin), but the interpreter used is `cmd`, not `powershell`." + }, + { + "prediction": "I don't think we need to add `aria-label` here.", + "reference": "I think this is ok for now. This ties into the larger issue of the site not having a consistent method for relaying form input errors. Please make sure the focus gets set on the close button when the dialog opens." + }, + { + "prediction": "I don't think we need to mention GhostTable and SamplesGenerator here.", + "reference": "Should these link be removed?" + }, + { + "prediction": "I don't think we need to pass `add_undo` to this method. We can just call `self.undo_stack.push(CloseTabCommand(self, tab))` in the `close_tab` method of `TabbedBrowser`.", + "reference": "Please make this a keyword-only argument by adding a `*` argument before `add_undo`." + }, + { + "prediction": "I think we can get rid of this now.", + "reference": "didn't quite follow what this code block is doing." + }, + { + "prediction": "I'm not sure if this is the best solution, but it seems to work for now.", + "reference": "this doesn't sound pretty... I would rather we have a proper navigation for all modes - AFAIK TV remote navigation is very similar to normal keyboard, but maybe it just uses another key codes - those should be extracted in a single file and defined there depending on context then" + }, + { + "prediction": "Shouldn't this be `if (dom._isControlled && ('value' in newProps || 'checked' in newProps))`?", + "reference": "After diffing the children we check whether the value got out of sync, if it did we update it. We also update the `_prevValue` to prepare for the next event hitting our controlled component" + }, + { + "prediction": "I think this should be `node provides the glue-code needed in order to start a Bee node.`", + "reference": "It provides a type called Node which is a fully functional bee client. This package is where the dependencies are injected. It is not just a glue-code, it is concept of node." + }, + { + "prediction": "I think this should be `None` instead of an empty string. `%` is not a valid directory name.", + "reference": "I think this will change `''` to `'%'` unconditionally, i.e. there'll be no way to set `''` anymore. This should really only be used for values which make no sense anymore." + }, + { + "prediction": "I think this should be `RowKeySchema` instead of `RowKey`.", + "reference": "Nit: this table's row key map -> this table's row keys map" + }, + { + "prediction": "I think this should be `PJ_LOG_WARN` or `PJ_LOG_DEBUG` instead of `PJ_LOG_NONE`.", + "reference": "this change should be reverted" + }, + { + "prediction": "I think this should be `os.path.join(basedir, \"misc\", \"qutebrowser.appdata.xml\")`", + "reference": "I'm a bit confused about the `os.path.dirname(basedir)` here - is this just to get to the parent directory? Either way, I think I'd prefer just having this in `update_version.py` as it's not needed in qutebrowser itself." + }, + { + "prediction": "I'm not sure why the line number changed, but I think it's correct. The error is now on line 5, column 19, which is the start of the `accounts` block.", + "reference": "Revert this change and see below why..." + }, + { + "prediction": "Why not use `coco_instance.py`?", + "reference": "Should not switch to `lvis_v1_instance` here because that base config uses ClassBalancedDataset to oversample the data." + }, + { + "prediction": "I think this should be `info.getMaximumSimultaneousSessions()` instead of `builder.getMaximumSimultaneousSessions()`.", + "reference": "This is an informational message that allows someone to read the console output and understand how the grid node is configured. Please leave." + }, + { + "prediction": "I don't think we need this method. We can just call `Raise` with the `singleton` flag set to `true`.", + "reference": "This doesn't make sense to me. What does RaiseSingleton mean? To me it sounds like a single object is being.. raised? Not sure." + }, + { + "prediction": "This is not used in this class.", + "reference": "What's the benefit of having jobExecutorTests as a member variable? What do you think about making the method static? Afterall, it is a stateless method." + }, + { + "prediction": "I think this should be \"Check metadata objects and their associated blocks for errors.\"", + "reference": "This looks like it's only downloading things, not really checking their true validity. Especially for the MD object. Should we call `BareRootMetadata.IsValidAndSigned()` in `mdGet`?" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if there is a better way to do this.", + "reference": "Nikoli, I believe that this addresses your concern. One question for you or Jae-Seung is if any allocation from the clone is properly cleaned up when the vector is destroyed. I believe that it should." + }, + { + "prediction": "I think this should be `KindAwsEcsApp` to be consistent with the other kinds.", + "reference": "should be `ECSApp`" + }, + { + "prediction": "I don't think this is correct. `self.size` and `self.location` are not defined for non-W3C elements.", + "reference": "flake8 is going to fail on this having 2 lines" + }, + { + "prediction": "Why was this removed?", + "reference": "should we make a dir named controllers/scheduler/podchaos" + }, + { + "prediction": "I don't think we need to change this.", + "reference": "there seems to be one KeyNode in kubernetes.go of PV.. would it make sense to use it?" + }, + { + "prediction": "I think it's better to keep `clicontext` as it is used in other commands.", + "reference": "Im gonna be a little annoying here but did you configure your linter correctly? This empty line should not be here. Maybe go to settings and check if `goimports` is enabled?" + }, + { + "prediction": "This should be `case MODPRIVATECHATOUT:`", + "reference": "Don't think this belongs in this pr" + }, + { + "prediction": "I think this should return a copy of the map, not the map itself.", + "reference": "We can assert on the existence of Outbounds through ClientConfig calls right? Since this is only for tests, do we need this function?" + }, + { + "prediction": "I'm not sure about this change. I think it should be `TaskCompletionSource CloseCompletionSource { get; set; }` instead of `TaskCompletionSource CloseCompletionSource { get; set; }`", + "reference": "@martijn00 so this PR introduces a new ViewModel lifecyle method? It isn't in the PR description/any new docs" + }, + { + "prediction": "I think it is better to add this information to `img_metas[0]` instead of all `img_metas`, because `img_metas[0]` is the meta information of the first image in the batch.", + "reference": "Are these modification duplicate? Or should we move it into base detector." + }, + { + "prediction": "I think this should be `public static byte[] dagSeed(final long block) {`", + "reference": "Since this is private and single use it should be un-wrapped inside of the two-arg dagSeed method." + }, + { + "prediction": "I think this should be `$GLOBALS['TSFE']->tmpl->setup['plugin.']['tx_solr.'], $configuration` instead of `$configuration, $GLOBALS['TSFE']->tmpl->setup['plugin.']['tx_solr.']`", + "reference": "why the order change? Also for the next chunk. (I understand the result will be the same though)" + }, + { + "prediction": "I think this should be a `map[string]struct{}` so that we don't have to iterate over it to check if a return type is allowed.", + "reference": "I wonder if this should just be a single `string`? We don't have any cases where we return different types and it would make the parser simpler to just read a single identifier." + }, + { + "prediction": "I think we can remove this method and use `getInputFile(FileScanTask task)` instead.", + "reference": "I don't think this needs to change. Can you go back to the previous implementation?" + }, + { + "prediction": "This should be `from molecule import Molecule`", + "reference": "Bump it 2 lines higher, 'c' > 'u'." + }, + { + "prediction": "Please remove this empty line.", + "reference": "Please do not add author here" + }, + { + "prediction": "remove empty line", + "reference": "Similarly, we should be able to persist action uniformly" + }, + { + "prediction": "Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "I think i'd prefer this override to be in the test helper instead, if that's possible?" + }, + { + "prediction": "I think this should be `0755` instead of `0777`.", + "reference": "This would be better with context added via wrapping or fmt.errorf()" + }, + { + "prediction": "I don't think we need this package. We can just use the `assert` package from `github.com/google/go-cmp/cmp` directly.", + "reference": "What's the purpose of this file?" + }, + { + "prediction": "I'm not sure if this is the right fix, but it seems to be the only way to get the passcodeLengthKnown flag to be set to true when the passcode length is changed.", + "reference": "@bhariharan Why was passcode length requirement allowed to be lowered?" + }, + { + "prediction": "I think we should keep these imports.", + "reference": "This file needs a license header, too. Sorry I didn't catch that earlier." + }, + { + "prediction": "I think this should be `string(genesisText)` instead of `string(genesisText[:])`", + "reference": "probably don't need `[:]` why not reference into `github.com/algorand/go-algorand/daemon/algod/api/server/lib` here and skip bouncing off daemon/algod/server.go ?" + }, + { + "prediction": "Why do we need to use `homogen_table_builder` instead of `homogen_table`?", + "reference": "Why reference is converted to table?" + }, + { + "prediction": "I don't think this is correct. If the token is not 0, we should return an error.", + "reference": "should we implement pagination in the fake datastore so the server startup code that paginates entries for trust domain validation can be tested?" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but I think it makes sense to do it here. The reason is that we don't want to vectorize the function if it's already vectorized, and we don't want to vectorize the function if it's not vectorized, but we do want to vectorize the function if it's not vectorized but has a vectorized version.", + "reference": "What mechanism will be exposed so the caller knows they're using the vectorized version?" + }, + { + "prediction": "I think this should be `flash: { error: t('.error') }` instead of `redirect_to forum_path(@forum), notice: t('.success')`", + "reference": "Can we remove respond_to block its not required here" + }, + { + "prediction": "I think it would be better to use `dal::io::read` instead of `dal::io::csv::read`.", + "reference": "Do not do that even in example, we demonstrate bad practice" + }, + { + "prediction": "Line is too long. [85/80]", + "reference": "Hm, taking a second look over this, this is why we have the object inheritance structure that we do. This could be divided up by having a custom determine_if_x86_64 in the pswindows/exec hosts and then a default method in hosts.rb. That way all the custom ps windows work is in a single location." + }, + { + "prediction": "Why is this needed? `writer.Commit()` should be enough.", + "reference": "We have to `.Complete` now because of empty/null string test cases." + }, + { + "prediction": "Line is too long. [82/80]", + "reference": "Is there still a way to specify no recursion?" + }, + { + "prediction": "I don't think we need this struct. I think we can just pass in the `HumanReadableName` and `URISafeName` to the functions that need them.", + "reference": "How is this name being URI safe and being used programmatically related?" + }, + { + "prediction": "I don't think we should be using `this.plugin.uppy.i18n` here. We should be using `this.uppy.i18n` instead.", + "reference": "I think we have to keep this as a fallback for now, else it's a small breaking change :(" + }, + { + "prediction": "I'm not sure what this test is testing, but it seems to be testing that `OpDocExtra` returns an empty string for `-`?", + "reference": "nit: shouldn't be part of this PR." + }, + { + "prediction": "I think this should be `expect(e).to.be.an.instanceOf(MongoError);`", + "reference": "this change looks wrong to me. I think the test is trying to signal that something went wrong by throwing the `Error` here, otherwise the `catch` below will swallow it." + }, + { + "prediction": "Shouldn't this be `if (!_layout.IsThreadAgnostic && _cachedPrevRawFileName != null && _cachedPrevRawFileName.Length == reusableBuilder.Length)` ?", + "reference": "I'm doubting if this should be `if (_layout.IsThreadAgnostic)`, as ThreadAgnostic stuff could be calculated on every thread. (and thus could be lazy). non-ThreadAgnostic should be calculated on the main thread." + }, + { + "prediction": "Please use `LoggerFactory.getLogger(LeftListWidgetChooser.class)` instead of `org.slf4j.LoggerFactory.getLogger(LeftListWidgetChooser.class)`", + "reference": "Please use only `Logger` instead of `org.slf4j.Logger`" + }, + { + "prediction": "I think this should be `if (!node.flags.disable_block_processor_republishing && !node.flags.disable_republishing)`", + "reference": "Should this be \"no limiter drop\", since this isn't an absolutely essential activity for the stability of the network?" + }, + { + "prediction": "This should be `process.argv[2]` instead of `process.argv[1]`.", + "reference": "I updated many of the success messages, because most of these operations don't return data if they succeed. This meant many of the operations would print: `Success null` if the script ran successfully." + }, + { + "prediction": "I think this should be `except FileNotFoundError: return False`", + "reference": "Could you simply add it to the previous clause ?" + }, + { + "prediction": "`localeCompare` is not supported in IE11. We should use `Blockly.utils.string.numericalCompare` instead.", + "reference": "@joshyrobot, I think you can just use localeCompare with only the first argument and leave the other arguments out (here and all the other lines changed). It seems to do the right thing, and then we don't have to worry about these extra options." + }, + { + "prediction": "Shouldn't this be `if (slaOptions != null && !slaOptions.isEmpty())`?", + "reference": "@chengren311 : where does this logic move to?" + }, + { + "prediction": "I think this should be `if len(s.scope.ManagedMachinePool.Spec.RoleAdditionalPolicies) > 0 && !s.scope.AllowAdditionalRoles() { return ErrCannotUseAdditionalRoles }`", + "reference": "Can we have a `nil` exception check at `s.scope.ManagedMachinePool`" + }, + { + "prediction": "I'm not sure why this was removed, but it seems like it should still be here.", + "reference": "Rather than deleting this, should you just reformat it so it's the `*` settings, so if nothing is configured in facets.ini, the existing default behavior continues to work?" + }, + { + "prediction": "I don't think this is the right way to go about this. You should use `t()` on the property name, not `t()` on the result of `str_replace(\"_\", \" \", $property)` and `ucfirst()` on the result of `t()` on the result of `str_replace(\"_\", \" \", $property)` and `ucfirst()` on the result of `t()` on the result of `str_replace(\"_\", \" \", $property)` and `ucfirst()` on the result of `t()` on the result of `str_replace(\"_\", \" \", $property)` and `ucfirst()` on the result of `t()` on the result of `str_replace(\"_\", \" \", $property)` and `ucfirst()` on the result of `t()` on the result of `str_replace(\"_\", \" \", $property)` and `ucfirst()` on the result of `t()` on the result of `str_replace(\"_\", \" \", $property)` and `ucfirst()` on the result of `t()` on the result of `str_replace(\"_\", \" \", $property)` and `ucfirst()` on the result of `t()` on the result of `str_replace(\"_\", \" \", $property)` and `ucfirst()`", + "reference": "wrap, single line" + }, + { + "prediction": "I don't think this is correct. If the return type is `void`, then the generic aware return type should also be `void`, not `Void`.", + "reference": "always use brackets for if statements" + }, + { + "prediction": "I'm not sure if this is the right place to do it, but I think we should move the `CIEnvironmentValues.DecorateSpan(null);` call to the `Initialize` method of the `NUnitIntegration` class. The reason is that the `Initialize` method is called when the profiler attaches to the process, so it's a good place to set the environment variables.", + "reference": "`NUnitIntegration` doesn't need to cache this anymore." + }, + { + "prediction": "I think this should be `WHEN cardinality(parts) > 1 AND lower(element_at(parts, -1)) = 'gz'`", + "reference": "Why did you change it to `>=` here?" + }, + { + "prediction": "I think we can remove the `else if (tableName.startsWith(\"hive.\"))` part.", + "reference": "Looks like this needs to be updated. There is no need to remove `hadoop.` if Hadoop tables don't use this code path." + }, + { + "prediction": "Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.", + "reference": "This require isn't need anymore, right?" + }, + { + "prediction": "I think it's better to move this import to the top of the file.", + "reference": "a bit weird to see payments crypto package inside connection manager. There probably will be services not having any relation with payments that will use connection manager. Thats why probably ping-ping by itself can be useful without any relation to payments.." + }, + { + "prediction": "Shouldn't this be `$xml->record->addAttribute('type', $this->xmlType);`?", + "reference": "I like the overall idea here, but I wonder if it would be more clear to define the property in the trait, and then set it in the constructors of the classes using the trait. Alternatively, at a bare minimum, it may be a good idea to add `?? 'Bibliographic'` here, to account for the possibility of the trait being used in a class that does not define the property at all." + }, + { + "prediction": "I think this should be 100, not 50.", + "reference": "I would prefer to not have a magic number, but construct this value out of other constants we already have." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the `kinto` package.", + "reference": "The limitation is if somebody configure another policy with the same name, but it is an edge case we can ignore I guess." + }, + { + "prediction": "I think we can remove the `hashivault` import here.", + "reference": "? The package is named `hashivault`." + }, + { + "prediction": "I think this should be `config->xwayland = false;`", + "reference": "I don't think this should enable xwayland, because it's convenient to toggle xwayland just by setting `xwayland` to `false`" + }, + { + "prediction": "nit: please add a blank line here", + "reference": "Remove this line by accident?" + }, + { + "prediction": "I think we can remove the `import org.gradle.api.plugins.JavaPluginConvention;` as well.", + "reference": "Calling `.stream()` on a `DomainObjectCollection` is pretty much always a bug, as it doesn't include objects added later (and encourages people to use afterEvaluate). I wonder if we should make this an error prone check?" + }, + { + "prediction": "This should be `if err != nil && !sigFound {`", + "reference": "Thanks for paying attention to other places this might happen. This one is particularly important; I probably never should have gotten in the habit of CheckErr(), since it does a log.Panic() explicitly, which looks like something else until you look closely. It's supposed to be used places where \"can't happen\" but Things Can Happen." + }, + { + "prediction": "I think this should be `ip_dscp` instead of `nw_tos`.", + "reference": "What is the different between nw_tos and ip_dscp? Only high 6 bits vs low 6 bits and supported version?" + }, + { + "prediction": "Shouldn't this be `StringData = MolToCXSmiles(*mol);`?", + "reference": "I'm assuming that asSmarts & cxSmiles == asSmarts" + }, + { + "prediction": "I'm not sure what's going on here, but it seems like the `param` attribute is not being restored by the `__setstate__` method of `LabelledData`.", + "reference": "Seems like an oversight but I don't think the super would do anything else in this case unless I'm mistaken." + }, + { + "prediction": "I think we can remove the `internal` access modifier here.", + "reference": "Curious, do we consider this as pedantic for example code?" + }, + { + "prediction": "I don't know if it's a good idea to use the entity name as the form name. What if there are two entities with the same name?", + "reference": "Should we convert the entity name to snake case using `Doctrine\\Common\\Inflector\\Inflector::tableize` or similar ? Should a `snaked_name` or whatever be part of the entity metadata in order to use it for form names, ids, & other html attributes ?" + }, + { + "prediction": "Shouldn't this return `client.outboundIp` instead of `client.ip`?", + "reference": "Should be `client.outboundIp`" + }, + { + "prediction": "Please remove unused usings.", + "reference": "Must these `using` statements not go inside the `namespace` block?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think we should be able to get rid of the `fboMutexLevel` type and just use `mutexLevel` instead.", + "reference": "Why? I thought the previous way was idiomatic. (Same with the `MetadataVer` stuff above.)" + }, + { + "prediction": "I'm not sure why this was removed. It looks like it should still be here.", + "reference": "shouldn't we `reject` here instead?" + }, + { + "prediction": "`gasPriceUnitIOTX, err := util.StringToIOTX(action.Core.GasPrice)` -> `gasPriceUnitIOTX := util.StringToIOTX(action.Core.GasPrice)`", + "reference": "check err or use gasPriceUnitIOTX, _ := if we are sure action.Core.GasPrice is correct" + }, + { + "prediction": "nit: I think we can remove the `wait` parameter from this method.", + "reference": "Just curious, was wait not used at all before?" + }, + { + "prediction": "Why did you remove this?", + "reference": "nit: can we remove this?" + }, + { + "prediction": "I don't think this is necessary.", + "reference": "is it not a problem when one synchronized function is called by other?" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I could get it to work.", + "reference": "We (even as admins) shouldn't override the User Preference settings like `email_master`, `email_posts`, `email_kudos`, `email_new_followers`. These all would be set by the user of their choice. Please do remove these attributes from editing//updating. Thanks!" + }, + { + "prediction": "`Este :attribute j\u00e1 est\u00e1 ligado.` -> `Este :attribute j\u00e1 foi ligado.`", + "reference": "\"Este :attribute j est anexado.\" sounds better." + }, + { + "prediction": "I don't think we need to import `frame` and `series` here.", + "reference": "This line should be repeated for every module that needs testing. One cannot rely on nosetest to automatically discover all the modules. On the bright side, there is no need to change any of the other files." + }, + { + "prediction": "I think this should be `var errNoCert = errors.New(\"no certificate available\")`", + "reference": "This error was unused" + }, + { + "prediction": "I don't think we need this struct. We can just use `CloseShardRequest{ShardID: shardID}`.", + "reference": "Personally I wish we didn't have a proto for every single little thing we do. RequestShardAction with an enum for the action type would be a lot cleaner imo, but I'm pretty sure that ship has sailed :) Just kvetching." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it works for now.", + "reference": "Does this make more sense as `trails/_trail` now?" + }, + { + "prediction": "I think this should be `outpostARN, err := agent.ec2MetadataClient.OutpostARN()` instead of `outpostARN, err := agent.ec2MetadataClient.GetOutpostARN()`", + "reference": "synced offline. let's move this to `agent_unix.go` to make the IMDS call, since this is not supported in Windows." + }, + { + "prediction": "Please remove these empty lines.", + "reference": "Too much indentation here. Should match the lines above, which have four spaces." + }, + { + "prediction": "I think this test should be kept.", + "reference": "Same here we still need this test to make sure the fallback works." + }, + { + "prediction": "I'm not sure about the name of this interface. I think it should be `MvxOverridePresentationAttribute` instead of `IMvxOverridePresentationAttribute`.", + "reference": "I'm wondering if we can actually base this on a `IMvxPresentationAttribute` instead of the base one." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to fix the issue for me.", + "reference": "could we switch to `undefined` here?" + }, + { + "prediction": "I think this should be `SyncState.setupSyncsSoupIfNeeded(smartStore);` instead of `SyncState.cleanupSyncsSoupIfNeeded(smartStore);`", + "reference": "The cleanup call" + }, + { + "prediction": "I don't think this is a good idea. Albums can have multiple artists, and we want to be able to view all of them. If you want to view a specific artist, you should be able to do so by clicking on the artist's name in the album view.", + "reference": "I think \"View artist\" is a bit more standard and expected. Or even \"Go to artist\" to take the Spotify terminology as-is." + }, + { + "prediction": "I think this should be `defined?(Puppet::Pops::Types::PSensitiveType::Sensitive) && Puppet::Pops::Types::PSensitiveType::Sensitive`", + "reference": "It might make sense to refactor this later so that we use a Bolt-native type to hide sensitive values." + }, + { + "prediction": "This is not needed. You can just run `python test_temporal_memory.py` from the command line.", + "reference": "We were trying to move away from this to force people to always run tests under py.test." + }, + { + "prediction": "I think this should be `body.append(self._get_selenium_options())` instead of `body.extend(self._get_selenium_options())` because `self._get_selenium_options()` returns a list.", + "reference": "1 - create browser specific options class: - chromeoptions - firefoxoptions - argsoptions" + }, + { + "prediction": "I'm not sure if this is the best way to fix this issue, but it seems to work for me.", + "reference": "should be a case insensitive match though no? DOCTYPE and doctype are both widely used" + }, + { + "prediction": "I'm not sure this is the right place for this method. I think it would be better to have it in the `Account` model.", + "reference": "We must have a `fail ParamNotFound` here for cases where `@account.nil?`." + }, + { + "prediction": "I think we can remove this `#if` now that we're targeting .NET Standard 2.0.", + "reference": "How come this change was needed?" + }, + { + "prediction": "I don't think we need to expose these. They are only used internally by the ADC driver.", + "reference": "Why are there only 6 pins here, while below it appears to have 8 ADC inputs? Are pin 2 and 5 used for something else on this board?" + }, + { + "prediction": "I think this should be `gsf.ssb.Matcher()` instead of `gsf.ssb.ExploreFields(func(messagesSelector selectorbuilder.ExploreFieldsSpecBuilder) { messagesSelector.Insert(\"secpRoot\", gsf.ssb.Matcher()) })`", + "reference": "I think we need an issue to track that chain sync omits BLS messages, and then to fix and test it!" + }, + { + "prediction": "I think this should be `config.action_mailer.asset_host = \"http://localhost:5000\" || \"http://2c429f18.ngrok.io\"`", + "reference": "what is this default about? I am not using ngrok atm so would prefer an env var." + }, + { + "prediction": "I think this should be `false` by default.", + "reference": "@Samuell1 Might be better to say \"Automatically check for plugin updates on login\"." + }, + { + "prediction": "I think we can remove this line.", + "reference": "Thanks for the additional Process helper! Can we also cache the first `Process.GetCurrentProcess()` result in a static field so we don't have to repeatedly call it? It means we would also need to dispose it when the static `_runtimeMetricsWriter` instance is disposed" + }, + { + "prediction": "nit: I think we can remove the `DisableDockerHealthCheck` from this test.", + "reference": "just wondering what is the result of breaking the logic we test here? it seems that in that case we will just not return immediately, but i'm not sure whether the test will fail?" + }, + { + "prediction": "I think we should be able to just use `dir` instead of `srcDir` here. I don't think we need to create a `src` directory.", + "reference": "We should fail the test if this returns `err != nil`." + }, + { + "prediction": "nit: I think it would be clearer to call this `shouldIncrementProvisionFailedTerminal` or something like that.", + "reference": "What is the drawback of not having this flag as a gating condition to report the metric?" + }, + { + "prediction": "I don't think we need this. We can just use `os.Args[0]` directly.", + "reference": "`getProcessName()` will be less ambiguous, since Caddy has \"apps\" that it runs internally." + }, + { + "prediction": "Is there a way to get the size of a pointer from the debugger?", + "reference": "Is there any way to not hardcode this given we know the size in bytes? The public API has the flexibility of being a Span. Should we maybe not do anything printing DML? The runtime allocates the buffer, but it's a \"scratch memory\" area, The delegate gets it passed in and they decide how to use it. Also, how is DML used if the feature is for macOS support?" + }, + { + "prediction": "Why do we need a lambda here? Why can't we just call `buildFilter(req.filter_ref())`?", + "reference": "How about just override the `buildFilter`? Passing another function here is a little weird." + }, + { + "prediction": "I think this should be a boolean flag, not a string.", + "reference": "This should just be a `.Bool()` flag I think, we don't encode anything beyond y/n here. See `$(RUN_CHECK)` and `$(STOP_ON_PKG_FAIL)` for examples of how to pass those in." + }, + { + "prediction": "I think this should be `case swift::MetadataKind::Function:`", + "reference": "Is this needed?" + }, + { + "prediction": "I think this should be `name: value` instead of `name: value.concat(' value')`", + "reference": "This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted." + }, + { + "prediction": "I think we should move this package to `chaos-mesh/pkg/selector/generic`", + "reference": "how about moving it under L26" + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in `utils.js` and not `utils/memoize.js`", + "reference": "I think this needs to be tested" + }, + { + "prediction": "I'm not sure if this is the best place for this constant, but it's the only place I could think of.", + "reference": "Style/MutableConstant: Freeze mutable objects assigned to constants." + }, + { + "prediction": "I don't think we need this field anymore.", + "reference": "Just a thought, really. If it's a bug that can be probed for (and it can be - see Adrian's repro) then it could as well be a static initialization of a supplier of Deflater instances; if we probe for a buggy JVM, we return the wrapper. If we don't we return the Deflater. This way on non-affected JVMs nothing happens and if we do use the wrapper, we know the JVM is broken." + }, + { + "prediction": "I don't think this should be public.", + "reference": "Looks like this should be publicly accessible for tests in any modules?" + }, + { + "prediction": "I don't think this is a good idea. If the `.env.local.php` file is not found, we should not try to load the `.env` file.", + "reference": "Allow putenv is necessary to be able to get environment variables with `getenv`?" + }, + { + "prediction": "Please add a newline at the end of the file.", + "reference": "use function to check it. - don't do everything in main" + }, + { + "prediction": "I think we can remove the `global_configs` parameter from this method. It's only used in `BaseRulesEngine.build_rule_book`, which is only called by `BaseRulesEngine.build_rule_book`, which is only called by `BaseRulesEngine.build_rule_book`, which is only called by `BaseRulesEngine.build_rule_book`, which is only called by `BaseRulesEngine.build_rule_book`, which is only called by `BaseRulesEngine.build_rule_book`, which is only called by `BaseRulesEngine.build_rule_book`, which is only called by `BaseRulesEngine.build_rule_book`, which is only called by `BaseRulesEngine.build_rule_book`, which is only called by `BaseRulesEngine.build_rule_book`, which is only called by `BaseRulesEngine.build_rule_book`, which is only called by `BaseRulesEngine.build_rule_book`, which is only called by `BaseRulesEngine.build_rule_book`, which is only called by `BaseRulesEngine.build_rule_book`, which is only called by `BaseRulesEngine.build_rule_book`, which is only called by `BaseRulesEngine.build_rule_book`, which is only called by `BaseRulesEngine.build_rule_book`, which is only called by `BaseRulesEngine.build_rule_book`, which is only called by `Base", + "reference": "Sorry I'm confused. Why not kwarg this like the others?" + }, + { + "prediction": " mrm|vex|reqp,x,END_LIST},\n+ {OP_vgatherdpd,0x66389258,\"vgatherdpd\",Vvd,Hx,MVd,Hx,xx, mrm|vex|reqp,x,END_LIST},\n }, { /* vex_W_ext 69 */\n- {OP_vgatherqps,0x66389318,\"vgatherqps\",Vvs,Hx,MVd,Hx,xx, mrm|vex|reqp,x,END_LIST},\n+ {OP_vgatherqps,0x66389318,\"vgatherqps\",Vvs,Hx,MVq,Hx,xx, mrm|vex|reqp,x,END_LIST},\n {OP_vgatherqpd,0x66389358,\"vgatherqpd\",Vvd,Hx,MVq,Hx,xx, mrm|vex|reqp,x,END_LIST},\n }, { /* vex_W_ext 70 */\n {OP_vfmadd132ps,0x6638C1C0,\"", + "reference": "First, any changes here should be synchronized with instr_compute_VSIB_index(). Second, the original looks correct to me: the first letter of the opcode name suffix is the index size, while the second is the memory size. So \"vpgatherdq\" is a d-sized index and q-sized memory. The operand size we store for memory accesses is always the memory size, not the address size, and for VSIB we store a single memory element size. It looks like we have no inside-opnd_t storage of the index size: that's done by dispatch on opcode it seems. I have a bunch of notes of discussions on how to handle VSIB: we decided to bail on encoding too much inside the opnd_t I guess." + }, + { + "prediction": "Should this be `self.build_tracking_url(logs_output)`?", + "reference": "Sorry for going back and forth. Adding docstring here would be very helpful for others to understand the need of this method." + }, + { + "prediction": "I think this should be `!canSeeInvisibility() && creature->isInvisible()`", + "reference": "You introduced a bug here." + }, + { + "prediction": "Shouldn't this be `string.IsNullOrEmpty(oldValue) && !string.IsNullOrEmpty(newValue)`?", + "reference": "Should we log a warning/error if only one is specified and not the other?" + }, + { + "prediction": "I don't think we need to implement this method in the fake client.", + "reference": "`ctx` is unused in GetLatestEvent" + }, + { + "prediction": "I think this should be `if (config.node.peering_port == 0)`", + "reference": "This looks good to me. Personally, I would have the following for maximum flexibility: * convert peering_port from uint64_t to int. * Set the default value to \"-1\" to specify the value is not set * if the value is -1 then do `config.node.peering_port = network_params.network.default_node_port` That would allow for 0 to mean, select the port number yourself and be more consistent. But I am happy with the change as is, as well." + }, + { + "prediction": "remove empty line", + "reference": "The blank line between the summary and detailed description is better to be kept." + }, + { + "prediction": "I think this should be `if a.RemoveUnusedShapes`", + "reference": "Curiously, are these indents intended or should they be aligned?" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "What if we changed this to this? roleText=attrs.get('roleText', lambda:getSpeechTextForProperties(reason=reason,role=role)) That will prevent the function from ever needing called in the roletext case, and removes that if." + }, + { + "prediction": "I'm not sure I understand why we can't use `safe_read_tls_magic` here. If the thread has already lost its TLS, shouldn't `safe_read_tls_magic` return `NULL`?", + "reference": "This will still result in a safe_read_tls_magic on AMD in tls_thread_preinit()." + }, + { + "prediction": "nit: remove empty line", + "reference": "Can you remove this change?" + }, + { + "prediction": "I think this should be `field.Invalid(specPath.Child(\"isCA\"), crt.IsCA, \"ACME does not support CA certificates\")`", + "reference": "Oh, was that a bug in the validation?" + }, + { + "prediction": "I think this should be `startsWith` instead of `contains` so that we don't accidentally remove the wrong part of the URL.", + "reference": "Please use the Google java code style. Basically, add more space characters like in the statements below. Next to method arguments and curly braces. This is currently not checked on CI because it is too inconsistent in the code base but I would prefer new code to be consistent." + }, + { + "prediction": "I don't think you need to delete `val1` and `val2` here.", + "reference": "Actually, I don't think we need to create object on heap." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get the generated code to compile.", + "reference": "this is a file we copy from gRPC, sp ideally it be fixed upstream as well.." + }, + { + "prediction": "I don't think we need this anymore.", + "reference": "changes like this, just strangle guava usages to be replaced by DelayLimiter into one place" + }, + { + "prediction": "I'm not sure about this change. The `Header` and `Footer` props are used to render the header and footer of the widget. If you remove the `Header` and `Footer` props, the header and footer won't be rendered anymore.", + "reference": "PropTypes need to be updated accordingly here. Note that the type also needs updating, not just the case. That is, these should both expect a `PropTypes.elementType` now instead of an `element`." + }, + { + "prediction": "I think this should be `strncmp(resource_str, \"id:\", 3) != 0`", + "reference": "maybe extra paren around `strncmp(...) != 0`" + }, + { + "prediction": "I'm not sure if this is the right place to call this, but it seems like a good place to me.", + "reference": "We should call `Windows.onResume `: - When the app is launched for the first time - When the app is resumed after being paused (home button and resume or device goes to sleep) - After a permission prompt is displayed" + }, + { + "prediction": "I don't think we need to make this generic. It's only used in `BftConsensus` where `C` is `BftConfigOptions`, so we can just make it `BftForksSchedule`.", + "reference": "Rename to ForksSchedule? Maybe in separate PR." + }, + { + "prediction": "I think we can remove the `from kinto.core.cache import heartbeat` line.", + "reference": "Why a blank line here?" + }, + { + "prediction": "I think this should be `deactivated_at.nil?`", + "reference": "I have a sense that this will actually eventually change to check the actual date so that subscriptions can be deactivated in the future. But I mention that here just to keep you in the loop. We should not make that change now, because it's not needed functionality." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it makes sense to skip the default value for positional parameters.", + "reference": "What is the reasoning for using the negation of `isOption()` instead of simply using `isPositional()` to identify a positional param?" + }, + { + "prediction": "This should be `msg.addByte(player->getVocation()->getId() != VOCATION_NONE ? 0x01 : 0x00);` instead of `msg.addByte(player->getVocation()->getId() != VOCATION_NONE ? 0x01 : 0x00);`", + "reference": "Why would you add those if client version min is set to 1100?" + }, + { + "prediction": "Why is this needed?", + "reference": "You can delete this, it will now need to live in `gointerfaces` package" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get the title to render as HTML.", + "reference": "Okay, I still don't understand why you have to add `html_safe` here, and it still seems like a very bad idea. It will allow html tags in the title, and keep Rails from escaping literal greater-than or less-than chars not intended as HTML tags. It ought to work to just let Rails do HTML-escaing as normal, without any manual `html_safe` or `strip_tags` or whatever. I am not clear on what problem you are trying to solve, why the straightfoward approach does not work." + }, + { + "prediction": "I think this should be `mActionBarSubject.setText(subject);` instead of `mActionBarSubject.showSubjectInMessageHeader();`", + "reference": "What is is subject when it's not the email subject. Why are we having to do this crap? What's calling this with an empty string?" + }, + { + "prediction": "I think we should keep the default sampler as `ProbabilitySampler(defaultSamplingProbability)`.", + "reference": "Could you also remove the `defaultSamplingProbability` constant from `sampling.go`? It seems to became unused with this change." + }, + { + "prediction": "I think we can remove the `appsv1.Deployment{}` argument here and in the `GenerateStrategicPatch` function.", + "reference": "can you delete the `generateDeploymentStrategicPatch` function as well?" + }, + { + "prediction": "I don't think we need to log this at `finest` level.", + "reference": "I'd keep this at `info` level..." + }, + { + "prediction": "Why do we need this check?", + "reference": "Don't use DCHECK to debug your code if it's the regular branch you need to handle." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should keep the `getImage` and `setImage` methods, and have them throw an `UnsupportedOperationException` if the node is not an `AntlrNode`.", + "reference": "You should return null here instead. Null is an acceptable default value for the image attribute." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in `invokeCleanup` and `invokeEffect`.", + "reference": "react bails as well?" + }, + { + "prediction": "This constant is not used anymore, so it can be removed.", + "reference": "Can you please tell me why you did this?" + }, + { + "prediction": "I think this should be `videoConstraints.facingMode = this.opts.facingMode || videoConstraints.facingMode`", + "reference": "Reading this again it should prob prefer the `videoConstraints.facingMode` value over `facingMode` if the former was already set" + }, + { + "prediction": "Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.", + "reference": "There's a good bit of class-level stuff that's repeated in our various product types. Think it's worth extracting a...dare I say it...module?" + }, + { + "prediction": "I think this should be `if config.Target.WasmAbi == \"js\" && strings.HasPrefix(config.Triple(), \"wasm\") {`", + "reference": "Please do not modify the `config.Target` field, it should contain exactly what is extracted from the JSON files. Instead, you can either: * Add a getter to the `config` variable (`*compileopts.Config`), so you can simply call `config.WasmAbi()` to get the value. * Use a local variable instead. The getter would be slightly cleaner, as it matches the pattern of other configurations (`CGO_ENABLED`, `GC`, `NeedsStackObjects`, etc)." + }, + { + "prediction": "I don't think we need to defer the stop here. We can just call it at the end of the function.", + "reference": "The nil check is not necessary for these. Append checks both sides for nil." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should only set the attributes if they are not already set.", + "reference": "Shouldn't we instead have the SDK apply these, internally? I.e., I would expect to see the dctx entries included in the span as first-class distributed correlations, not as span attributes." + }, + { + "prediction": "I think we should return an error here.", + "reference": "nit: rename this in proto and update impl to `Search` to avoid stutter" + }, + { + "prediction": "Why do we need this?", + "reference": "is it necessary to order by id as a second ordering? this will take place only when several new slider items are created without reordering (position is then null). Wouldn't be better to recalculate position after creating a new item? (right now items with null in position behave differently in administration and on frontend)" + }, + { + "prediction": "I don't think we need to make these constants public. They are only used in this file.", + "reference": "`ClaimFromRewardingFundBaseGas` is a global variable (from `gochecknoglobals`)" + }, + { + "prediction": "I don't think you need the NOGIL here.", + "reference": "How about modifying the NOGIL definition so that it only does anything if the thread safety flag (RDK_BUILD_THREADSAFE_SSS) is set?" + }, + { + "prediction": "I don't think we need this interface. We can just pass in the `BlockTimer` directly to the `Sender`.", + "reference": "blockheighter would be more clear" + }, + { + "prediction": "I think it's better to use `std::min` and `std::max` instead of `std::swap`.", + "reference": "This is so weird as a utility function." + }, + { + "prediction": "I think we should be able to use `cmpopts.IgnoreUnexported` instead of `cmp.AllowUnexported` here.", + "reference": "Why? What would happen if you did not?" + }, + { + "prediction": "I don't think this is necessary. If `o` is `null` then `((JSONObject) o).opt(pathElement)` will return `null`.", + "reference": "Unrelated bugfix for NPE." + }, + { + "prediction": "I don't think we should change the exception message here.", + "reference": "What if some extended the `AdminController` and had a check for the old option name? Could that be a valid use case?" + }, + { + "prediction": "I think we should use `countlyCommon.API_PARTS.data.r + '/data-manager/event-segment'` instead of `countlyCommon.API_PARTS.data.r + '/data-manager/event-segment'`", + "reference": "This will be only available when data-manager is enabled, is there a fallback in case data manager is disabled?" + }, + { + "prediction": "I think this should be `In JavaScript you can write %s.`", + "reference": "Do you think we want to move the call to `generateWorkerServiceRecommendedActions` inside `RecommandedActions()`?" + }, + { + "prediction": "This should be `VUID-vkGetQueryPoolResults-flags-00814` and `VUID-vkGetQueryPoolResults-flags-00815`", + "reference": "The VUIDs in this area are not great, but I think `ValidateQueryPoolStride` should probably be skipped if the query pool was created with type `VK_QUERY_TYPE_PERFORMANCE_QUERY`. VUID-02828 might be a better fit, but again, the existing VUIDs step on each other so it requires a bit of interpretation." + }, + { + "prediction": "I think it's better to have `ToDbKey` as an extension method for `long` and `Keccak`.", + "reference": "Iguess you should use ToDbKey here" + }, + { + "prediction": "Why do we need to subtract 1 here?", + "reference": "x.tbk is the \"index\" below, and is done in Start()" + }, + { + "prediction": "I think this should be `DD_APPINSIGHTS_INSTRUMENTATIONKEY` instead of `DD_IsAppInsight`", + "reference": "Do we already have a convention for this? If not, would we consider \"DataDog.IsAppInsights\". And then use \"DataDog.\" prefix for all this settings, environment variables etc..? Such settings are, essentially, public APIs because they may conflict with customer data. Regardless of that , AppInsights has an s at the end :)" + }, + { + "prediction": "I think it would be better to check if `ctx->log_key` and `ctx->time_key` are not `NULL` instead of checking if they are not `NULL` and not empty.", + "reference": "this assignment is not necessary if the offsetof() is used in the configmap" + }, + { + "prediction": "Why is this change necessary?", + "reference": "I'd rather leave a TODO here at least." + }, + { + "prediction": "I think this should be `\"\"`, not ````", + "reference": "Shouldn't this be `resource`?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think we can remove the `req` argument from this function. It's only used in the GPU implementation.", + "reference": "Why does this become blocking for the CPU path? Shouldn't it remain independent of the GPU path?" + }, + { + "prediction": "I'm not sure if this is a good idea, but I think it would be better to rename this method to `configure_rvm` or something like that. `setup_rvm` sounds like it's setting up RVM, but it's actually just exporting the `TRAVIS_RUBY_VERSION` environment variable.", + "reference": "Do we need to change occurences where `setup` was called before?" + }, + { + "prediction": "I'm not sure this is the right place to do this, but it's the only place I could think of.", + "reference": "Is this TODO still valid? Or are we going to put this somewhere else later?" + }, + { + "prediction": "I think this should be `if from_ts is None:`", + "reference": "We generally don't do parantheses in if conditions in Python. :) this could be better written as `if from_ts is None`" + }, + { + "prediction": "(style) line over 80 characters", + "reference": "Odd that we'd set just element 299 of a 2000-byte buffer to null. But I see that this is the way it was before." + }, + { + "prediction": "I don't think we need a `ScoreFunc` interface. We can just pass a `func(swarm.Address) float32` to the `ForEachPeer` method.", + "reference": "ScoreFunc is not used in this PR. Maybe to add it later when needed?" + }, + { + "prediction": "I think this should be `if len(redirects) > 0 && !isXHR(copyRequestHeadersFromResponseWriter(w))`", + "reference": "super nit: I think this might be easier to read as `requestHeadersFromResponseWriter`" + }, + { + "prediction": "Please remove the empty line.", + "reference": "Need to include \"common/base/Base.h\" in front of this line" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work. I'm not sure if there's a better way to do this, or if this is the best way to do this.", + "reference": "Changes in this file should go into a separate PR." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should be using double quotes here.", + "reference": "Please ensure that this will not start putting single quotes where double quotes are expected." + }, + { + "prediction": "I'm not sure why we need to change the signature of this function. I think we can keep it as it is.", + "reference": "`ProvideConfig` was changed, looks like it will not compile for windows, and should be changed too." + }, + { + "prediction": "I think this should be `models.GetUserRepositories(u.ID, true, 1, u.NumRepos, models.ListOptions{Page: ctx.QueryInt(\"page\"), PageSize: ctx.QueryInt(\"limit\")})`", + "reference": "This does not look right, you're listing all private repositories.." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "An OPTIONS request should respond from _any_ path? Seems weird to me..." + }, + { + "prediction": "I don't think we should add these fields to the media admin. The media admin is only used to manage media, not to edit them. If you want to add these fields, you should add them to the media edit form in the media bundle.", + "reference": "you need to add the content type" + }, + { + "prediction": "I think it would be better to have a `StopSubProcesses` method in the `ProcessHelper` class and call it from here.", + "reference": "Do we need to distinguish between these two processes? I'm thinking maybe we can have a list of processes and treat them all equally." + }, + { + "prediction": "I think this should be `#if defined(AARCH64) || defined(X64) || defined(IA32)`", + "reference": "This is used only for out-of-line -- so yes this seems right to do for x64. Inlined is aligned separately at the end of prepare_for_clean_call(). There the ifdef is x86_64 or MACOS -- no ARM, why not? Also, please add || MACOS here to match the inlined." + }, + { + "prediction": "I think this should be `ZIPKIN_SPANS.TRACE_ID_HIGH.eq(ZIPKIN_ANNOTATIONS.TRACE_ID_HIGH).and(ZIPKIN_SPANS.TRACE_ID.eq(ZIPKIN_ANNOTATIONS.TRACE_ID))`", + "reference": "guess I'm wondering if this needs to be refactored to use Schema.joinCondition() or similar?" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Does it make sense to restrict this option to `exec` only? You could add it specific to that subcommand using the `method_option`...method. There's an example of it for hosts in the `init` function." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get this to work.", + "reference": "This is very expensive (lots of allocations, lots of data copying). Could we do something like check IndexOf('%') and bypass if no hit?" + }, + { + "prediction": "I don't think this is correct. If you're in deadman, you should be able to attack people in the wilderness.", + "reference": "This should be `WorldType.isDeadmanWorld(client.getWorldType())` to be inline with the other WorldType calls." + }, + { + "prediction": "`mlvl_confids` -> `mlvl_confidences`", + "reference": "do we also need to change `mlvl_confid` -> `mlvl_confidences`>" + }, + { + "prediction": "I think this should be `config:\"oneof(kube-ipvs0,none);none;non-zero,die-on-fail\"`", + "reference": "I feel slightly that InterfaceExclude is not a clear name - bearing in mind that our config names are, to some extent, an external API. From an external point of view, a clearer name might be IPVSInterfaces. Then it would obviously make sense for the value to be something like 'kube-ipvs0', and it would be a matter of Felix's internal implementation that we choose to exclude those interfaces from our monitoring. Alternatively, if we want to keep this at a level that is more general than just IPVS, perhaps 'UnmonitoredInterfaces'? WDYT?" + }, + { + "prediction": "I don't think we need `re.fullmatch` here. `re.match` should be enough.", + "reference": "This should be `re.search` with a `^` anchor added to the regex, as what we want here is really any path starting with something like `E:`." + }, + { + "prediction": "I'm not sure if this is the right place to do this, but I think it would be good to add a check for `obj == nil` here and return an error if it is.", + "reference": "Since `IsKubernetesBuiltInResource` at L69 returns false due to lack `networking.istio.io/v1alpha3` in `builtInApiVersions` within `pkg/app/piped/cloudprovider/kubernetes/resourcekey.go`, it will never reach this point." + }, + { + "prediction": "Why is this change needed?", + "reference": "Does codecov not run this test? Not sure how else it would not be covered." + }, + { + "prediction": "`multisend 'JSON_DATA'` -> `multisend JSON_DATA`", + "reference": "can we add some sample of JSON_DATA format in the usage?" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should keep the `scopeManager` and use it to get the `DistributedSpanContext` from the `Active` `IScope`.", + "reference": "Using `Tracer.Instance` in here is problematic for testing It will likely cause some other tests to break I think - that's why we started passing in `IScopeManager` EDIT: I see you used `[TracerRestore]` - maybe that'll be enough!" + }, + { + "prediction": "I think this should be `projectIdVariableName` instead of `projectIdToken`.", + "reference": "make all of these `static final` fields UPPER_SNAKE - they are constants." + }, + { + "prediction": "I'm not sure if this is the right way to do it, but I think it should be `total_dotshielding = itembonuses.DoTShielding + itembonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_PERCENT] + aabonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_PERCENT] + spellbonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_PERCENT];`", + "reference": "No possible chance for weird overflows here, right?" + }, + { + "prediction": "I'm not sure this is the right place to put this constant. I think it should be in the `TwoPhaseIterator` class.", + "reference": "Or we could use a Float object to more clearly show as user-settable via non-null?" + }, + { + "prediction": "Why do we need to pass `finalizedHeader` to `ForkchoiceUpdated`?", + "reference": "finalizedHeader should be saved in FinalizationManager when we have FinalizationBlockHash != Keccak.Zero" + }, + { + "prediction": "I think we should use `dataDiskIndex` instead of `dataDiskIndex` in the scratch disk name.", + "reference": "Not using ExactName: true would remove the need for manually adding workflow ID as it would be added automatically by Daisy. E.g. 'disk-importer-2-import-ovf-7mn7h' was created from diskImporterDiskName above even though only 'disk-importer-2' was specified. ExactName: true should be used for resources that shouldn't include any temp prefix/suffix, such as disks that will be permanently attached to a created instance. Scratch disk is not one of them." + }, + { + "prediction": "Why do we need to select all columns here?", + "reference": "If we support multi-index column later, we need to rename to fit the pandas' requirement." + }, + { + "prediction": "I think this should be `map[string]interface{}` instead of `map[string]interface{}`.", + "reference": "I'm not sure this is really needed. JSONValue type can be used the same as a map as far as operators go, including range. I'd leave this out for now unless there is a strong reason to keep it." + }, + { + "prediction": "I think this should be `Container::startDecaying()` instead of `Item::startDecaying()`.", + "reference": "sorry for nitpicking but I would love a new line under this line" + }, + { + "prediction": "I think this should be renamed to `ChannelType` or `ChannelImplementationType` or something like that.", + "reference": "ChannelImplementation field naming is not clear, is it some kind of standard? Maybe it can be named ChannelID?" + }, + { + "prediction": "I think this should be `default RemoveFiles removeFiles(String metadataLocation) { throw new UnsupportedOperationException(this.getClass().getName() + \" does not implement removeFiles\"); }`", + "reference": "Looks like there is a typo: `expireSnapshots` -> `removeFiles` or whatever name we go with." + }, + { + "prediction": "I'm not sure this is the right thing to do. If the current sort order is null, then we should not be showing the sort dialog at all.", + "reference": "Thanks for looking into this. I think it looks a bit strange to have this check inside the for loop. Wouldn't it also work to initialize `idxCurrentSort` with 0 instead?" + }, + { + "prediction": "I don't think we need to add new constants for these. We can just use the existing ones.", + "reference": "Just a small ordering thing: Could you please bring `IMPORTANCE_HIGH` to the bottom and maybe even have one line between it and the Notification IDs?" + }, + { + "prediction": "I'm not sure if this is a good idea, but I think it is better to catch the exception and print the error message than to let the program crash.", + "reference": "Should this be boost logged?" + }, + { + "prediction": "session is not used in this function.", + "reference": "What is the reason for doing expunge here? This method is purely for converting the timestamp." + }, + { + "prediction": "I think it would be better to add the original field name as a property on the schema itself, rather than on each field. That way, we don't have to iterate over all the fields to get the original field name.", + "reference": "This calls sanitize twice if the name isn't valid." + }, + { + "prediction": "Use 2 (not 0) spaces for indenting an expression spanning multiple lines.", + "reference": "Is there an equivalent that'd allow zero or one?" + }, + { + "prediction": "I think this should be `rwExec.IsTaskObjectNameRepeat()` instead of `rwExec.isTaskObjectNameRepeat()`. This is because `rwExec.IsTaskObjectNameRepeat()` is a public method, while `rwExec.isTaskObjectNameRepeat()` is a private method.", + "reference": "Is it possible to update/re-evaluate entire metatask object for every repeat? If we decide/need to use a repeatWith resources in let us say labelSelector(bad example) then we would have to add another logic to update those properties." + }, + { + "prediction": "Why is this change needed?", + "reference": "unnecessary conversion (from `unconvert`)" + }, + { + "prediction": "I don't think you need to remove this.", + "reference": "typo in commit message `openening`" + }, + { + "prediction": "I don't think this is needed anymore.", + "reference": "User-code doesn't see the internal ADIOS headers anymore. This whole include block should just be `#include `" + }, + { + "prediction": "I don't understand why this change is needed.", + "reference": "nit: I guess we can omit this (unless you had a reason to specify it)" + }, + { + "prediction": "I think this should be `c.leaf.remote != nil && !c.leaf.remote.Hub`", + "reference": "Why is Hub public?" + }, + { + "prediction": "Why is this removed?", + "reference": "why is this deleted?" + }, + { + "prediction": "I'm not sure this is the right place to put this, but I think it should be here.", + "reference": "Maybe move that into a partial" + }, + { + "prediction": "I don't think we need to check the error here.", + "reference": "Error return value of `dao.Stop` is not checked (from `errcheck`)" + }, + { + "prediction": "I think this should be an error, not a warning.", + "reference": "util.Warning()? Easier to say." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in `UnmarshalTrieNode` instead.", + "reference": "this default is kinda superfluous (although i see it was already there before PR )" + }, + { + "prediction": "I don't think this change is necessary. `parent` is not used in the constructor.", + "reference": "How is this related?" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but I think it makes sense to have all the plans on the same page.", + "reference": "I'm breaking one of the rules here, it feels like the right thing to do. Open to alternative suggestions." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "The use of `#should` was triggering an rspec depracation warning for me, which is why I switched this to the rspec 3 style." + }, + { + "prediction": "I think this should be `if (chit != m_changesForReader.end() && chit->isValid())`", + "reference": "Why are you setting the CacheChange as REQUESTED when it is not valid (it was erased from history)?" + }, + { + "prediction": "This should be `import { isEmpty } from 'lodash-es';`", + "reference": "`lodash` shouldn't be grouped under WordPress dependencies" + }, + { + "prediction": "Why is this constructor public?", + "reference": "This needs to be public so that Avro can call it." + }, + { + "prediction": "I think we can remove the `map` and `isNull` imports here.", + "reference": "`Google*` shouldn't be under External dependencies - seems like ESlint is not properly recognizing that these are aliases to internal dependencies." + }, + { + "prediction": "Why do we need `assert index is None` here?", + "reference": "I think he meant the docstring in this constructor. yea we should fix" + }, + { + "prediction": "I don't think we need this method. It's only used in one place, and it's only used in one place in a way that can be replaced with `Files.newInputStream(Paths.get(path))`.", + "reference": "so .. this basically follows the pattern from JapaneseTokenizer, I think. .. but somehow I don't see where we defined ResourceScheme? We're not referencing the one in kuromoji, right?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get this to work on Windows 10.", + "reference": "It would probably be better to do: const SecurityProtocolType Tls13 = (SecurityProtocolType)12288" + }, + { + "prediction": "Why is this removed?", + "reference": "Similar to the above, put this setting back but keep the value as `'{}'`" + }, + { + "prediction": "I'm not sure this is the right place to log this. I think it should be logged in the `refresh_continuous_aggregates` function.", + "reference": "As discussed in chat - we should run this function within an app context which means that we'd already have a logger configured, and a connection to timescale set up" + }, + { + "prediction": "I'm not sure this is the best way to do this, but it works for now.", + "reference": "I'm curious about why this needed to be removed." + }, + { + "prediction": "I don't think we should import `plt` from `scapy.extlib` here. We should import it from `scapy.extlib` only when `scapy.extlib.MATPLOTLIB_INLINED` is `True`. Otherwise, we should import it from `scapy.extlib` only when `scapy.extlib.MATPLOTLIB_INLINED` is `False`.", + "reference": "why did you remove `zip`? It is used!" + }, + { + "prediction": "Why remove the reason?", + "reference": "Is there any reason that we don't add a similar condition like `ChannelConditionTopic` to the channel?" + }, + { + "prediction": "This should be `namespace TestVendor\\Goto;`", + "reference": "before php8 \"goto\" was a reserved word and was not allowed as part of the namespace. Now test checks for validity of plugin namespace according to PSR-4" + }, + { + "prediction": "I think this should be `NewSingleOutboundTLS` or `NewSingleOutboundTLSConfig` or something like that.", + "reference": "nit: I'm not sure it can be addressed in this diff, but it seems odd that NewOutbound supports TLS but NewSingleOutbound does not. As a somewhat naive user I would expect the only difference between these two APIs is how peers are chosen." + }, + { + "prediction": "I'm not sure this is the right thing to do. If the response body is empty, we don't need to close it. If the response body is not empty, we should be able to read from it and then close it.", + "reference": "I would advise to enhance the test for the method `CallOneway` - we should have a test very similar to `TestCallSuccess`. We should test: - Success with response (even if it is callOneway) - Success with no response and empty payload - Errors" + }, + { + "prediction": "I'm not sure why this change was made. I don't think it should be removed.", + "reference": "We're already matching +. Not sure why this changed." + }, + { + "prediction": "I don't think this is the right way to do it. If you want to use your own category manager, you should be able to do it without having to change the configuration.", + "reference": "Please add line breaks, so the line doesn't exceed 80 chars." + }, + { + "prediction": "I think we should keep the `ActivitySourceAdapter` in the constructor and pass it to the `HttpInListener` instead of creating a new `ActivitySourceAdapter` in the `HttpInListener` constructor.", + "reference": "I initially thought (inccoreclty) this is a breaking change! The public api analyzer is a gift!" + }, + { + "prediction": "I don't think we need to free the `GPtrArray` here, do we? I don't think we need to free the `GPtrArray` here, do we? I don't think we need to free the `GPtrArray` here, do we? I don't think we need to free the `GPtrArray` here, do we? I don't think we need to free the `GPtrArray` here, do we? I don't think we need to free the `GPtrArray` here, do we? I don't think we need to free the `GPtrArray` here, do we? I don't think we need to free the `GPtrArray` here, do we? I don't think we need to free the `GPtrArray` here, do we? I don't think we need to free the `GPtrArray` here, do we? I don't think we need to free the `GPtrArray` here, do we? I don't think we need to free the `GPtrArray` here, do we? I don't think we need to free the `GPtrArray` here, do we? I don't think we need to free the", + "reference": "I'm not sure how this one didn't segfault before." + }, + { + "prediction": "I don't think these are used anywhere.", + "reference": "Same points as in other test file." + }, + { + "prediction": "Please use `import java.nio.charset.*;` instead of `import java.nio.charset.*;` and `import java.io.*;` instead of `import java.io.*;`", + "reference": "Did you run gradlew tidy? Wildcard imports shouldn't be there, hence the question." + }, + { + "prediction": "I'm not sure why we need to pass in a `StatusFinder` here. I think we should be able to use the `StatusFinder` from the `TrailWithProgress` instance itself.", + "reference": "Put a comma after the last parameter of a multiline method call." + }, + { + "prediction": "I think this should be `FPGA_IFC_OPAE` instead of `FPGA_IFC_DFL`.", + "reference": "Is this going to restrict the output to *ONLY* ports that are bound to vfio-pci? That's not what we discussed yesterday." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in the VM.", + "reference": "Intention is to do the lookup here, I believe (where we can cache it). This would make the call non-pure function though. I'll confirm with lotus. ID addresses are the *only* addresses I expect to actually see here." + }, + { + "prediction": "`EMRFS` -> `EMRFS`", + "reference": "electronic medical record file system (EMRFS)" + }, + { + "prediction": "I think this should be `maxrequestbody` instead of `maxrequestbody`", + "reference": "Put this higher in the list, like after \"bind\", since I guess we're considering the max request body size to be kind of a native/fundamental feature, built directly into the vhosts." + }, + { + "prediction": "I don't think we need to remove these errors. They are used in other places.", + "reference": "oh come on :(" + }, + { + "prediction": "I don't think we need to log this at `finest` level. I think `info` is fine.", + "reference": "This is an incorrect change. The dialect spoken is an important part of the handshake and should be communicated to users." + }, + { + "prediction": "I think this should be `bool: Whether or not the authenticated user is a service account`", + "reference": "Remove as this is not needed anymore." + }, + { + "prediction": "This should be `int` not `Optional[int]`.", + "reference": "This new class is for checking that #4551 works correctly with PlantUML output too." + }, + { + "prediction": "I'm not sure if this is the right place to add this. I think it should be added to the `Certificate` struct in `pkg/apis/certmanager/v1alpha1/certificate_types.go` and then used in the `buildCertificate` function in `pkg/controller/certificates.go`.", + "reference": "Will this cause all certificates to be re-issued?" + }, + { + "prediction": "(style) trailing whitespace", + "reference": "I think tmp is also leaked at the end of this loop if no error cases are encountered." + }, + { + "prediction": "I think this should be `keyProjection != null && keyProjection.schema() != keyField.schema() || valueProjection.schema() != valueField.schema()`", + "reference": "The previous version didn't use `keyProjection` because the entire key must be projected. If the key is a struct of multiple columns, then projecting a subset of those columns can easily introduce key collisions that aren't in the original data." + }, + { + "prediction": "`spaceId < 0` -> `spaceId == -1`", + "reference": "Why not use StatusOr ? We can't ensure spaceId is greater than zero, especially when AdHocSchemaManager is used." + }, + { + "prediction": "why we need to import `github.com/chaos-mesh/chaos-mesh/pkg/chaosdaemon/pb` here?", + "reference": "Does it seem we only use that as the json-rpc client? Do we have any other choice? It's a little weird." + }, + { + "prediction": ".ROLE_MENUBUTTON, controlTypes.ROLE_TREEVIEW, controlTypes.ROLE_CHECKMENUITEM, controlTypes.ROLE_RADIOMENUITEM)\n \t\t\tor (role in (controlTypes.ROLE_TABLE, controlTypes.ROLE_TABLECELL, controlTypes.ROLE_TABLEROWHEADER, controlTypes.ROLE_TABLECOLUMNHEADER) and formatConfig[\"reportTables\"])\n \t\t\tor (role in (controlTypes.ROLE_LIST, controlTypes.ROLE_LISTITEM) and not controlTypes.STATE_READONLY in states and formatConfig[\"reportLists\"])\n \t\t\tor (role in (controlTypes.ROLE_FRAME, controlTypes.ROLE_INTERNALFRAME) and formatConfig[\"reportFrames\"])\n```\nReview comment?", + "reference": "Could you split this into multiple lines?" + }, + { + "prediction": "nit: remove unused imports", + "reference": "Doesn't the snapshot ID start off as null? It seems like we don't need to set it here." + }, + { + "prediction": "I'm not sure why this change is necessary, but it seems like it should be.", + "reference": "I wondered why `buffer` was passed into `LookupPath`. What is happening here? Is `buffer[:0]` equivalent to `[]V4TrieEntry{}`, and hence `buffer` isn't needed any more?" + }, + { + "prediction": "I don't think we need to create a new state view here. We already have one in `c.state.StateView(parentStateRoot)`.", + "reference": "nit: Ideally we would would use this abstraction everywhere we need this translation. I believe it's needed in the mining worker and the storage and market connectors." + }, + { + "prediction": "I think we need to check if the hash is empty or not. If it is empty then only we need to calculate the hash and update it.", + "reference": "need to fix the error message here" + }, + { + "prediction": "Why is this not fixed?", + "reference": "Unsure of how to handle this one." + }, + { + "prediction": "I think this should be `if (this.isKilled() || this.flowFinished) {` instead of `if (isKilled() || this.flowFinished) {`", + "reference": "Will this.flowFinished verify with every finished state stated in Status.isStatusFinished method? If so, no need to verify isKilled." + }, + { + "prediction": "I don't think we need this struct. We can just use the `RetryPolicy` struct directly.", + "reference": "replace \"Child Workflow\" with \"any workflow\"" + }, + { + "prediction": "I think this should be `{{- if or .IsSymlink .IsDir}}`", + "reference": "Instead of showing the words \"symbolic link\" under the \"Size\" column, how about we introduce new icons for symbolic link to file and symbolic link to directory?" + }, + { + "prediction": "I don't think we need to keep the `@internal` tag here.", + "reference": "Please add back the description of the parameter" + }, + { + "prediction": "Please remove this empty line.", + "reference": "Superfluous space inserted." + }, + { + "prediction": "I'm not sure if this is the best way to do this. I think it would be better to use `getAttribute` in all cases, and only use `node[attribute]` if `getAttribute` returns `null` or `undefined`. That way we don't have to worry about `ownerSVGElement` at all, and we don't have to worry about `getAttribute` returning `null` or `undefined` when `ownerSVGElement` is `false`.", + "reference": "Didn't fix the problem. `href=\"\"` for SVG will still result in `undefined` getting returned by this function." + }, + { + "prediction": "I'm not sure why the bearing changed, but I think this is correct.", + "reference": "This seems like a strange change ... I wouldn't think that a change to access tags in the profiles would result in different bearings in this tests?" + }, + { + "prediction": "I think this should be `isCaret=True`.", + "reference": "As isCaret is False by default, explicitly specifying isCaret=False here is not needed, and is perhaps a little confusing. I'd prefer that anywhere in the codebase that isCaret is only ever specified if it needs to be set to true. Mirroring that of isFocus for setNavigatorObject." + }, + { + "prediction": "I think we can remove the `.freeze` here as well.", + "reference": "We can't freeze this and then add something to it in the next line. The `freeze` on line 43 is sufficient. If Rubocop flags this we need to exclude it." + }, + { + "prediction": "I'm not sure this is the right place to sort the subjects. I think we should sort them when we create the `AutomationPolicy` in the first place. That way, we don't have to sort them every time we consolidate the automation policies. What do you think?", + "reference": "Why is this needed?" + }, + { + "prediction": "I think this should be `/users/:username/repos` and `/orgs/:org/repos`", + "reference": "Why not put two other routes after this line (221)?" + }, + { + "prediction": "`addrs.value().empty()` should be `addrs.value().size() == 0`", + "reference": "If FLAGS_meta_server_addrs is not empty, in which case \"toHosts\" return empty array?" + }, + { + "prediction": "This should be `Settings.JSONBoolWithQuotes(DEFAULT_JSON_USE_QUOTES);` instead of `Settings.JSONBoolWithQuotes = DEFAULT_JSON_USE_QUOTES;`", + "reference": "There is a function to output a \"JSONBool\" string. That would be a good start for finding uses. But maybe just have a look at where we decide whether it is a numerical or not, thus wrapping quotes around its value. Then you have it all I guess." + }, + { + "prediction": "I think we need to update `copy` method in `InternalFrame` to take `scol` as an argument.", + "reference": "oops, it should be `data._scol` so that it respects the expression stored in Series. Let me fix it quick." + }, + { + "prediction": "Line is too long. [101/80]", + "reference": "Thanks for moving this up with the rest of the variables. Much tidier :)" + }, + { + "prediction": "I think this should be `0.001 * money.Myst` instead of `money.NewMoney(0.001, money.CurrencyMyst)`", + "reference": "I think `Rate` is a more precise and concise term for `PaymentPerTime`." + }, + { + "prediction": "I think this should be `if (limit < 0 || limit < posNext)`. If `limit < 0` then `limit < posNext` will always be true.", + "reference": "I think this should maybe be: var limit = input.IndexOfAny(new[] { '+', '-', ']' }, **posNext**); You pretty much want to ignore any sign that is before the \"M\". But, if there is a sign somewhere before the M, and also after the M, you'd want to be able to find the sign after the M, right?" + }, + { + "prediction": "This should be `if (true === ConfigQuery::checkAvailableStock()) {`", + "reference": "if `checkStockNotEmpty` returns a reponse, you must return it or your script will continue its execution." + }, + { + "prediction": "I think we can remove the `v2` from the import here.", + "reference": "Any specific reason for this change? klog should work correctly here." + }, + { + "prediction": "I think this should be `ON CONFLICT (id, parent_id, collection_id) DO UPDATE SET data = EXCLUDED.data, last_modified = from_epoch(:last_modified) RETURNING id, as_epoch(last_modified) AS last_modified;`", + "reference": "we don't mention `last_modified` here?" + }, + { + "prediction": "I don't think we need to use `hyperx` here. `preact-compat` should be enough.", + "reference": "same deal about the global state maybe interfering as in ActionBrowseTagline" + }, + { + "prediction": "I think it would be better to use `Assert.Throws(() => new LruCache(maxCapacity, \"test\"));` instead of `Assert.Throws(() => { new LruCache(maxCapacity, \"test\"); });`", + "reference": "so sweet to see a test as the first thing" + }, + { + "prediction": "I think this should be `if (config->http_proxy != NULL && strcmp(config->http_proxy, \"\") == 0) {`", + "reference": "usually when HTTP_PROXY=\"\" (empty), proxy should be disabled. could you set it to NULL when it's empty string?" + }, + { + "prediction": "I don't think this is the right way to do it. If the width is not set, the height should not be used to calculate the width.", + "reference": "Can you throw an exception if width or height are both null" + }, + { + "prediction": "I think these should be `httpSchemeHTTP` and `httpSchemeHTTPS` instead of `HTTPSchemeHTTP` and `HTTPSchemeHTTPS`.", + "reference": "This is a breaking change. I guess these might have been intentionally exported." + }, + { + "prediction": "I think this should be `else if (options.containsKey(TableProperties.SPLIT_SIZE) || options.containsKey(TableProperties.METADATA_SPLIT_SIZE))`", + "reference": "I don't think this is necessary. When options are used to set the split size in the Spark reader, it uses `TableProperties.SPLIT_SIZE` to pass it here. That should work for metadata tables as well, right? The situation that we need to handle in this PR is setting the default, like you had before. We just want to use a metadata split size so you can set it and not have the same split size used (by default) for both metadata and data scans." + }, + { + "prediction": "I think this should be `*` instead of `\u00d7` and `//` instead of `\u00f7`", + "reference": "wait a sec, shouldn't this be `'*'`?" + }, + { + "prediction": "I think this should be `varMap[\"compute_service_account\"] = oi.params.ComputeServiceAccount` instead of `varMap[\"compute_service_account\"] = oi.params.ComputeServiceAccount`", + "reference": "It think you'll want the var for GMI import as well: daisy_workflows/ovf_import/create_gmi.wf.json (Unfortunately there's duplication between the two :/ )" + }, + { + "prediction": "I think this should be `self._commands[\"GET_CONTEXT\"] = ('GET', '/session/$sessionId/moz/context')` instead of `self._commands[\"GET_CONTEXT\"] = ('GET', '/session/$sessionId/moz/context')`", + "reference": "Nit: Group this with the other commands by moving it down one line." + }, + { + "prediction": "I think this should be `throw new UnsupportedOperationException(\"Unsupported encoding: \" + dataEncoding + \" for column \" + desc);`", + "reference": "I would like to emphasize that a user can use non-vectorized reads to handle this file so maybe something like \"Cannot perform a vectorized read of ParquetV2 File with encoding %s, disable vectorized reading with $param to read this table/file\"" + }, + { + "prediction": "I think this should be `positional=False, default=None, description=\"parameter name used to pass in parameterized value. Defaults to None, meaning use first positional parameter\"`", + "reference": "Maybe add `positional=False`. It does not need it more than the other parameters, but one must start somewhere." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get the tests to pass.", + "reference": "Since we're here, can we use a template?" + }, + { + "prediction": "I'm not sure this is the best way to do this, but it works for now.", + "reference": "saw you're also doing this in `test_types.py`: `spark = _spark_context()['test'].resources['spark'].resource_fn(None)` since `_spark_context()` uses `spark_session_local` won't the above break the tests?" + }, + { + "prediction": "I think this should be `Selector: \"default == ''\"` instead of `Tag: \"default\"`.", + "reference": "`has(default)` i think is the preferred way of doing this" + }, + { + "prediction": "nitpick: I think it would be better to use the same variable names as in the docstring, i.e. `w`, `minval`, `maxval`, `n`, `radius`, `resolution`, `name`, `verbosity`, `clipInput`, `space`", + "reference": "always put a space after a comma" + }, + { + "prediction": "I don't think this is the right place to call this method. It should be called in `selectAllPhotosUpToFav(int position)` method.", + "reference": "@angmas1 move the else up, next to the closing bracket of the if block. Also, there is no need for the braces as your else statement contains only a single line. Make your if-else block similar to the block in lines 277-280." + }, + { + "prediction": "I don't think we need to add `options` to the `__init__` method. We can add it to the `start_session` method instead.", + "reference": "@AutomatedTester @davehunt thoughts on a new keyword argument?" + }, + { + "prediction": "Why is this change needed?", + "reference": "This change shouldn't be necessary for this PR. Please remove it." + }, + { + "prediction": "nit: `testCtx` -> `ctx`", + "reference": "This variable is mostly unused, how about we make `NewTestCtx` return a pointer?" + }, + { + "prediction": "I think this should be 16 MiB. 32 MiB is a lot of data to send over the wire.", + "reference": "What is the basis of this value?" + }, + { + "prediction": "This should be `#include \"gce_metadata/gce_metadata.h\"`.", + "reference": "Nit: was this extra blank line added intentionally?" + }, + { + "prediction": "I think this should be `STATUS_GUARD_PAGE_VIOLATION`, not `EXCEPTION_GUARD_PAGE_VIOLATION`.", + "reference": "nit: inconsistent spacing around =" + }, + { + "prediction": "I don't think we should remove the `LegacyExecutionContextInterface` import here.", + "reference": "We still need this import" + }, + { + "prediction": "I think we can remove the `groupId` parameter from the `rewriteFiles` method in the `BinPackStrategy` class.", + "reference": "We are pulling this because we removed \"groupID\" state and put it into the strategy implementations" + }, + { + "prediction": "I think it's better to use `oneapi::dal::kmeans_init::compute` instead of `oneapi::dal::kmeans_init::compute`", + "reference": "Is this file actually related to PCA?" + }, + { + "prediction": "I think we should keep `isFirstAdmin` as well. It's used in `createEnableTracking` and `createTrackEvent`.", + "reference": "See above, this should probably remain `isFirstAdmin`." + }, + { + "prediction": "I think this should be `Type` instead of `MonoType`.", + "reference": "Why the change to make it public? The expression interface has the `TypeOf` method?" + }, + { + "prediction": "I think this should be `Single_Archive_File_Rolls_Correctly`", + "reference": "don't mind the snake cases in the test names. If there are in the test cases, it's fine IMO" + }, + { + "prediction": "I think it would be better to have a separate DTO for unlocking, instead of reusing `identityRegistrationDto`. This way we can have different validation rules for registration and unlocking.", + "reference": "`Id` defines REST resource address and should not be in payload" + }, + { + "prediction": "I think it's better to use `--class_wise` instead of `--class_wise`", + "reference": "We can omit the underscore and just use `classwise`." + }, + { + "prediction": "I think you can remove the `!empty($rootCategory) ? $rootCategory->getId() : null;` and just use `$rootCategory->getId();`", + "reference": "Why not throw an exception instead then?" + }, + { + "prediction": "I think we can remove this method now.", + "reference": "Looks like this doesn't need to change. Can you revert this?" + }, + { + "prediction": "I don't think we need to import `template` here.", + "reference": "please import it like `from kinto.config import template`" + }, + { + "prediction": "I don't think we should change the default value here.", + "reference": "There are lots of default value changed, not sure if it break the old behavior." + }, + { + "prediction": "remove empty line", + "reference": "File is not `goimports`-ed (from `goimports`)" + }, + { + "prediction": "I don't think we need to add `addToStaticNodes` to `RemovePeer` method.", + "reference": "parameter should be called removeFromStaticNodes" + }, + { + "prediction": "I think this should be `override: Optional[bool] = False`", + "reference": "The handler will have an extra property in the marker to signal the implementation is in the provider, for the cases we want to add functionality, for example, custom implementations not in moto." + }, + { + "prediction": "I think this should be `deactivated_at` instead of `deactivated_on` to be consistent with the rest of the codebase.", + "reference": "Is this method actually being used anywhere? If not, I think we should remove it." + }, + { + "prediction": "I think this should be `!p.IsConstant && !p.IsReadOnly && !p.IsRequired`", + "reference": "Thanks! I somehow lost this between my far too many branchs." + }, + { + "prediction": "I don't think we need to import `FirefoxWebElement` here. It's only used in the `find_element` and `find_elements` methods, which are defined in the `RemoteWebDriver` class.", + "reference": "i think this should get put into its own file. This could start to grow :)" + }, + { + "prediction": "I think this should be `gcr.io/google_containers/pause-amd64:3.0` or `gcr.io/google_containers/pause-amd64:3.1`", + "reference": "Can you add a TODO for loading the tarball of the pause image into Docker?" + }, + { + "prediction": "Why is this being removed?", + "reference": "Is there any value in setting the process to null like this?" + }, + { + "prediction": "`softmax_axis_ = this->layer_param_.softmax_param().axis(); outer_num_ = bottom[0]->count(0, softmax_axis_); inner_num_ = bottom[0]->count(softmax_axis_ + 1); CHECK_EQ(outer_num_ * inner_num_, bottom[1]->count()) << \"Number of labels must match number of predictions; \" << \"e.g., if softmax axis == 1 and prediction shape is (N, C, H, W), \" << \"label count (number of labels) must be N*H*W, \" << \"with integer values in {0, 1, ..., C-1}.\");`", + "reference": "This could be a good time to add a check that the prediction and target dimensions (except channel) agree?" + }, + { + "prediction": "I think this should be `else if (instr_get_opcode(bb->instr) == OP_isb || instr_get_opcode(bb->instr) == OP_misb || instr_get_opcode(bb->instr) == OP_mrsb)`", + "reference": "The requirement that OP_isb is bb-final needs to be a rule for clients, just like the rule that syscalls and interrupts must be bb-final: i.e., please add it to the dr_register_bb_event() docs." + }, + { + "prediction": "I don't think we need to replace {0} and {1} here. We can just do `Globalize.translate(\"ListPaging\", (totalRecordCount ? startIndex + 1 : 0) + \"-\" + recordsEnd, totalRecordCount);`", + "reference": "The translate library has a method to replace the variables." + }, + { + "prediction": "Can you add a test for `inplace=True`?", + "reference": "i don't think this test case is correct. in both cases inpalce=True returns nothing. We need to compare the ks. Also we probably need to make a copy of it. Otherwise you pollute the following \"ks\" because ks has been changed." + }, + { + "prediction": "I think this should be `tls.TlsHandshakeHook`", + "reference": "Any proposals how to make the naming somehow include the \"completed\" idea of this hook? `TlsHandshakeCompletedHook` or similar? Or using the `...Start/End...` scheme?" + }, + { + "prediction": "Why do we need to flush here?", + "reference": "it introduces a lot of complexity to the state, can we flush straightaway or create a two level flush store where the questions are read form unflushed data?" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but I think it should be done in `getUrlFromRouteCache` instead.", + "reference": "There are two calls to getUrlFromRouteCache, but you're only urlencoding one of them. Is that intentional? Would it make more sense to do the url-encoding inside the getUrlFromRouteCache function?" + }, + { + "prediction": "I don't think we need to do this. The `getEditedCell` method is only used in the `prepare` method, which is only called when `editorClass` is not null.", + "reference": "Maybe we can use `this.instance.getCell` with `topMost` flag to get `TD` element?" + }, + { + "prediction": "Why do we need to log the error here?", + "reference": "Change this to Debug Level" + }, + { + "prediction": "I think this should be `StackTraceUsage = _allLayouts.DefaultIfEmpty().Aggregate(StackTraceUsage.None, (seed,layout) => seed | (layout?.StackTraceUsage ?? StackTraceUsage.None));` instead of `StackTraceUsage |= _allLayouts.DefaultIfEmpty().Aggregate(StackTraceUsage.None, (seed,layout) => seed | (layout?.StackTraceUsage ?? StackTraceUsage.None));`", + "reference": "I refactored the Aggregate, those are hard to read" + }, + { + "prediction": "I think we should keep this test, but change the iframe to a div with role=\"main\".", + "reference": "This is now done in the after method, so this test won't pass any more." + }, + { + "prediction": "Trailing whitespace detected.", + "reference": "What was the point of creating `user_block` if you're then not going to use it ;-)" + }, + { + "prediction": "I don't think we need to remove these imports.", + "reference": "@ueshin, I thought we can remove this entire file. Does that require some more works?" + }, + { + "prediction": "I think this should be `unicode(tokens.string.value)[1:-1]`", + "reference": "Just `return tokens.string[1:-1]` is enough" + }, + { + "prediction": "Style/SymbolArray: Use %i or %I for an array of symbols.", + "reference": "1 trailing blank lines detected." + }, + { + "prediction": "I'm not sure why this was set to `Double.MAX_VALUE` in the first place, but I think it should be `Double.MAX_VALUE - 100` or something like that.", + "reference": "Isn't this the default max width? In any case I would prefer to see these definitions in the css files." + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work. I'm not sure if there's a more idiomatic way to do this in Go.", + "reference": "Is this thread-safe? (If not, and if the solution is to introduce locking, let's reconsider how we do the scheme changing instead...)" + }, + { + "prediction": "I don't think we need to move `Ftrl` to the top of the list.", + "reference": "Looks like this file has tabs instead of spaces." + }, + { + "prediction": "I think this should be `if err := resource.Cleanup(); err != nil {`", + "reference": "Hmm should we clean up container resources before task resources here? or the order does not really matter here?" + }, + { + "prediction": "Please remove this empty line.", + "reference": "Please undo this :wink:" + }, + { + "prediction": "Align the elements of a hash literal if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "thanks for adding this missing association" + }, + { + "prediction": "I think this should be `UseHttps` instead of `UseKestrelHttps` since it's not specific to Kestrel.", + "reference": "Should I remove this in favor of the HttpsConnectionFilterOptions overload?" + }, + { + "prediction": "`max(index)` should be `MAX(index)`", + "reference": "This shode be nullable, there alway sholud be at least one status in system , if not exist that mean data problme" + }, + { + "prediction": "This should be added in the `__construct` method of the `BackendController` class.", + "reference": "Spaces not tabs" + }, + { + "prediction": "I think this should be `fs.readdirSync(path, {withFileTypes: true}).map(e => e.name);`", + "reference": "To get the files inside a directory, please use `readDirStats()`." + }, + { + "prediction": "I'm not sure this is the right place for these constants. I think they should be in the `container` package.", + "reference": "might be worth to call these `Isolation` instead of containers here and when presented to the user -- docker/rkt , in addition to cgroups and namespaces, also provide image discovery and filesystem preparation; there's also the security context and probably 1-2 other small things" + }, + { + "prediction": "this file is empty", + "reference": "File is empty, consider removing?" + }, + { + "prediction": "I think this should be `return url is not None`", + "reference": "This seems to return the registry_url. The more meaningful URL is the catalog URL, which is the URL the user specifies in `quilt3.login`. The username might also be as useful here if not more useful." + }, + { + "prediction": "I think this should be `L1ERC20GatewayAddress` and `L1ERC721GatewayAddress`", + "reference": "Was the addition of `GasPriceOracleAddress` here erroneous?" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "I believe that you are going to have to do some work here to get the env var support for these values to still work correctly, otherwise they will get stored as :department instead of host_tags[:department]." + }, + { + "prediction": "I'm not sure this is the best way to do this, but it's the only way I could think of to get the `SessionStore` and `BrowserStore` logs to be in the same order.", + "reference": "How was this causing the exception?" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it works for now.", + "reference": "I still have issues with it loading Simplified Chinese by default over Japanese, since they also share characters and we're not sure if characters are different or not. As-is, this fixes Traditional Chinese and Simplified Chinese, but we're not sure if it'd still screw up Japanese text or not. I maintain that, in my opinion, Japanese should be the only script of this kind loaded by default (Because of Hiragana and Katakana, that aren't shared with any other script) and either variant of Chinese should be loaded only in their respective case." + }, + { + "prediction": "I think this should be `new MultiTermIntervalsQuery(field, this)`.", + "reference": "Isn't it better to stub AtomatonQuery and yield it here. IIRC it resolves simplest MTQ highlighting cases as nobrainer." + }, + { + "prediction": "I'm not sure why we're multiplying by 12.0 here, but it seems like we should be using `price_in_dollars` instead of `price`.", + "reference": "Line is too long. [96/80]" + }, + { + "prediction": "I think this should be `kubernetes.io/arch: amd64`", + "reference": "My only concern with changing the node selector here is that someone else _could_ have built their own images for other platforms and set them to be used using the flag override on the controller, which in turn this change would break. Perhaps not changing the selector for acmesolver pods makes most sense, and then working on actually having support for Windows? wdyt?" + }, + { + "prediction": "I don't think we need to change this to `InnerObjectWithSelector`. We can just keep it as `InnerObject` and add the `selector` field to the `Object` struct.", + "reference": "Why do we need interface `InnerObjectWithSelector`, I searched the usage with this field, it seems nowhere use `GetSelectorSpecs()` methods provided by `InnerObjectWithSelector`" + }, + { + "prediction": "nit: `InitContext(MsgCtxTypeChannel)` -> `InitContext(MsgCtxTypeChannel)`", + "reference": "Do we need this `init` here? We have already called the `InitContext` in `StartModule` directly." + }, + { + "prediction": "I'm not sure if this is the right place to put this, but I think we should also add a `minimize_window` method to the `Remote` class in `webdriver/remote/remote_connection.py`.", + "reference": "This `if` is not necessary" + }, + { + "prediction": "I'm not sure if this is the right place to put this, but it seems to be the only place where we have access to `dom.value` and `newProps.value` at the same time.", + "reference": "should we add a `mangle.json` mapping for this? We could reuse a property name that's only used on component or vnode objects right now, like `__s` (\"next state\")." + }, + { + "prediction": "I think this should be `opts[:modulepath].join(File::PATH_SEPARATOR) if opts[:modulepath]`", + "reference": "Please update the yard docs to indicate this new option." + }, + { + "prediction": "I think this should be `+kubebuilder:validation:MinItems=1`", + "reference": "Can you provide an example in the godoc section on how to use this? From the implementation it looks like the AvailabilityZone field is required for example, otherwise it can fail / error, is that correct?" + }, + { + "prediction": "I'm not sure if we want to store the code version in the migration table or not. I think it's fine to store it, but I'm not sure if we want to store it in the same table as the schema version.", + "reference": "It would be great if this could be captured by a test." + }, + { + "prediction": "10*time.Second),\n+\t\tESProcessorAckTimeout: dc.GetDurationProperty(dynamicconfig.WorkerESProcessorAckTimeout, 1*time.Minute),\n \t\tESProcessorMaxGoroutines: dc.GetIntProperty(dynamicconfig.WorkerESProcessorMaxGoroutines, 1000),\n \t\tESProcessorMaxQueueSize: dc.GetIntProperty(dynamicconfig.WorkerESProcessorMaxQueueSize, 10000),\n \t\tESProcessorEnableMetrics: dc.GetBoolProperty(dynamicconfig.WorkerESProcessorEnableMetrics, false),\n```\nReview comment?", + "reference": "1000 -> 100 maybe too much, 200 ish to 500ish maybe a good option" + }, + { + "prediction": "Why is this change necessary?", + "reference": "Any reason we need to keep this package's `ChecksumAddress` type or can we get rid of it too?" + }, + { + "prediction": "I don't think this is the right translation. I think it should be `globalize.translate('ButtonRestartServer')`", + "reference": "Above the one that was picked was the Button* prefix, and here it's the Header* prefix. Maybe the Button prefix is more general." + }, + { + "prediction": "Pending hash is not the same as head hash. Pending hash is the hash of the best suggested block, while head hash is the hash of the last block in the chain.", + "reference": "I might prefer changing: public Block FindPendingBlock() => FindBlock(PendingHash, BlockTreeLookupOptions.None); public BlockHeader FindPendingHeader() => FindHeader(PendingHash, BlockTreeLookupOptions.None); in IBlockFinder, what do you think?" + }, + { + "prediction": "I don't think we need to preserve unknown fields here. We should be able to remove the `// +kubebuilder:pruning:PreserveUnknownFields` line.", + "reference": "This is necessary due to a bug in 4.7. Follow HIVE-1561 for getting rid of it." + }, + { + "prediction": "Style/HashSyntax: Use the new Ruby 1.9 hash syntax.", + "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." + }, + { + "prediction": "I don't think you need to include xkbcommon.h here.", + "reference": "Some day (tm) I will also get rid of that one. But today is not that day..." + }, + { + "prediction": "I think this should be `if (substr($localPath, -1) !== '/') { $localPath = rtrim($localPath, '/') . '/'; }`", + "reference": "Add a space between if and opening parenthesis please (i.e. `if (`)" + }, + { + "prediction": "I think it's better to use `if index is not None` instead of `if index`.", + "reference": "nit: `rename` instead of `alias`?" + }, + { + "prediction": "I think this should be `if devName == \"/dev/sda1\" || devName == \"/dev/nvme0n1p1\"`", + "reference": "Per AWS docs EC instances have the root mounted at /dev/sda1. This label should be skipped." + }, + { + "prediction": "Why is this removed?", + "reference": "I'm not sure it is a better way to address lose message, if wait here, edge controller cant process message, event from watching api-server will be lost yet, right?" + }, + { + "prediction": "I don't think this is correct. If `value_size` is `None` then `p.len - p.value_size - 6` will be `p.len - None - 6` which is `None - 6` which is `None`.", + "reference": "Please keep the correct alignment, it seems broken now (at least in Github). Can you reverse the test (`if p.value_size is None`)? Also, do you want `6` when `p.value_size is None` or `x + 6`? Maybe, in that case, something like `lambda p, x: x + 6 + (0 if p.value_size is None else p.value_size)` would be easier to read. Or even easier: `lambda p, x: x + 6 + (p.value_size or 0)`." + }, + { + "prediction": "I think this should be `type:\"integer\" minimum:\"0\" maximum:\"2147483647\"`", + "reference": "Can we make sure ECS service treats it as int64 as well?" + }, + { + "prediction": "I'm not sure this is the right place for this class.", + "reference": "Please follow the naming convention for variables, i.e. `windowText`." + }, + { + "prediction": "This import is not used. Please remove it.", + "reference": "alias can be `cast`" + }, + { + "prediction": "nitpick: I think it would be better to have `mmap_errors` as a `uint64_t` instead of a `size_t` so that we don't have to cast it to `uint64_t` in the format string.", + "reference": "Let's use `%zu` instead of casting to `uint64_t` and using `PRIu64`. The alternative is to change the type of `mmap_errors` to `uint64_t`, though I'd prefer not doing that because some 32-bit platforms might not provide atomic operation support for `uint64_t`." + }, + { + "prediction": "I think this should be `ERROR` instead of `WARNING`.", + "reference": "I recall there being a reason we had this one set only to suggeation. @carterkozak do you remember why? or is my memory getting corrupted?" + }, + { + "prediction": "I think this should be `it->first` instead of `it->second`.", + "reference": "This should now be made into `if (it->second.empty())` ?" + }, + { + "prediction": "I don't think you need the backticks around `QWebEnginePage.FindFlags` here.", + "reference": "Do we need to worry about a race condition on this decrement (@The-Compiler)? I'm not sure how the python callbacks work, so this might not need to be something to worry about." + }, + { + "prediction": "I think this should be `sc := trace.SpanContextFromContext(ctx)`", + "reference": "Should these assert that the extracted `SpanContext` is remote?" + }, + { + "prediction": "`match_low_quality` -> `allow_low_quality_matches`", + "reference": "typo: allow low quality matches." + }, + { + "prediction": "nit: I think we can remove the `cfg *cmds.Server` argument and just use `config.ControlConfig` instead.", + "reference": "At some point we need to condense down and refactor our \"configs\" as we have too many in too many places and we're starting to get more illegible code. No change necessary but calling out for future reference." + }, + { + "prediction": "I think this should be `aria_label` instead of `aria-label`", + "reference": "Can we add the `if label` conditional to this please?" + }, + { + "prediction": "I think this should be `mlflow>=0.2.0,<1.0.0`", + "reference": "@thunterdb, can we increase the minimal version to almost the latest ones? I was thinking people will mostly use the latest version of mlflow" + }, + { + "prediction": "Nit: I think it would be better to call this `isFillDataChanged` or something similar. `hasFillDataChanged` sounds like it's a boolean, but it's not.", + "reference": "If the last argument is going to be removed, why would we add it to the API docs? Shouldn't it be private for internal use?" + }, + { + "prediction": "nit: I think we can remove the `IntermediatesManager` import here and just use `FileSystemIntermediateManager` and `InMemoryIntermediatesManager` directly.", + "reference": "`Intermediates` or `Intermediate`" + }, + { + "prediction": "I don't think this is the right way to do this. I think we should be raising an exception if the element is stale.", + "reference": "This is not the right exception class. There is an InvalidSelectorException class that covers bad locators." + }, + { + "prediction": "Why is this line removed?", + "reference": "If this code isn't needed, it should be removed." + }, + { + "prediction": "I'm not sure this is the right thing to do here. If the connection is disconnected, we don't want to try to reconnect, we want to return an error and let the caller decide what to do.", + "reference": "Should the `doRequest` func be a method on the `connection` type instead of passing state from the type?" + }, + { + "prediction": "I think this should be `COPILOT_ENVIRONMENT_NAME` and `COPILOT_LB_DNS` instead of `ECS_CLI_ENVIRONMENT_NAME` and `ECS_CLI_LB_DNS`", + "reference": "we'll probably tackle these e2e tests at the end" + }, + { + "prediction": "Shouldn't this be `Dns.GetHostEntryAsync(\"34.206.253.53\").GetAwaiter().GetResult()`?", + "reference": "what is this address pointing to? what are we measuring here? I want to have a better understanding." + }, + { + "prediction": "Shouldn't this be `dep_status = 3 or dep_status = 4` instead of `dep_status = 0 or dep_status = 3`?", + "reference": "Would it be better to pass the dependency status as the parameter into the SQL string? In case the enum value is changed in the future, we don't need to change the code here." + }, + { + "prediction": "I think this should be `// +build !linux,!darwin,!freebsd,!netbsd,!openbsd,!plan9,!solaris`", + "reference": "Hah I had `gorename` failing without this too." + }, + { + "prediction": "I think it would be better to use `string.Empty` instead of `\"(none)\"`", + "reference": "maybe prefix these with `appsec_` for consistency?" + }, + { + "prediction": "I think we should remove this. We don't want to expose the pprof endpoint by default.", + "reference": "nit: this should be down further with the other github imports" + }, + { + "prediction": "I think this should be moved to `__init__.py` so that it is done as soon as NVDA starts.", + "reference": "Why is this change necessary or related to the rest of the PR?" + }, + { + "prediction": "I think this should be `'- see: ' . $issue_data->link` instead of `' - see: ' . $issue_data->link`", + "reference": "Hm, I wonder if the `see:` prefix is even necessary?" + }, + { + "prediction": "Shouldn't this be `remainingMinutes = remainingMinutes || 0;`?", + "reference": "This should be translated." + }, + { + "prediction": "I don't think we need to check `num_class` and `boosting` and `metric` here.", + "reference": "I originally had this PR only changing the R package, but then ran into this error > Error: [LightGBM] [Fatal] Cannot change metric during training This is thrown even if you aren't actually CHANGING `metric`. I think the change here in `c_api` is closer to the desired behavior, only throwing an error if the parameter is being changed." + }, + { + "prediction": "I'm not sure about this change. I don't think we should be using a regex here, and I don't think we should be escaping the newlines in the string.", + "reference": "These changes are just to make cli_spec a little more readable for VS Code users, as there's a bug with the Ruby plugin's syntax highlighting when you use multi-line regex literals." + }, + { + "prediction": "I think this should be `constants.HiveNamespace` instead of `controllerutils.GetHiveNamespace()`.", + "reference": "Shouldn't the global pull secret by in the namespace of the hive-operator? It is part of the operand." + }, + { + "prediction": "I think we can remove these sleeps now that we're using `wait_until_stream_exists` and `wait_until_stream_has_1_shard`.", + "reference": "kinesis-mock applies KINESIS_LATENCY to RegisterStreamConsumer actions so I added a sleep here." + }, + { + "prediction": "Why can't we upgrade from V1 to V3?", + "reference": "Only V1 or V3 is return from `getMetaVersionFromKV`. So where do we call `updateMetaV2ToV3`?" + }, + { + "prediction": "I think this should be `return []catalog.Version{nodeAttestorV0{}, nodeAttestorV1{}}`", + "reference": "I think that V0 is missing here, which will prevent plugins that haven't been converted to work." + }, + { + "prediction": "I don't think we need this anymore.", + "reference": "Should we remove this?" + }, + { + "prediction": "Please remove this empty line.", + "reference": "Put on top of the import." + }, + { + "prediction": "I think this should be \"Google Analytics\".", + "reference": "See above, this shouldn't be added." + }, + { + "prediction": "I'm not sure about this change. I think it should be `ITEM_AMULET_OF_FURY` and `ITEM_FURY_ORNAMENT_KIT`.", + "reference": "This'll likely get fixed upstream, we should let them deal with it." + }, + { + "prediction": "I think this should be a `libp2p.Host` instead of a `host.Host`.", + "reference": "Somehow, this field does not seems useful for the exposed package api, only for the tests. Would you consider having an unexported field in `hostFactory func(context.Context, ...libp2p.Option) (host.Host, error)` instead to be set only by a new helper function defined in export_test.go. This is just a suggestion, not a hard requirement for the PR approval." + }, + { + "prediction": "I think it would be better to use `moment().startOf(timeDuration).subtract(n, timeDuration).valueOf()` instead of `moment().startOf(timeDuration).subtract(n, timeDuration).format('x')` because `valueOf()` returns the number of milliseconds since 1970-01-01T00:00:00.000Z and `format('x')` returns the number of milliseconds since 1970-01-01T00:00:00.000Z as a string.", + "reference": "As a first argument to these function, please pass the date that should go forward/backward. Also please clarify what is \"n\" (possible values, unit) and what is timeDuration (possible values, unit, as from your code it seems to be \"day\", \"hours\", etc. but from your example it seems to be milliseconds)." + }, + { + "prediction": "I don't think this is the right place to set the language. It should be done in the `__init__` method of the app module.", + "reference": "Are you sure you really need this code here? that script will be certainly run in NVDA's main thread, and core would have already called setLanguage." + }, + { + "prediction": "Why change the port number from 10255 to 10256?", + "reference": "why is this changed ?" + }, + { + "prediction": "I don't think we need to test this.", + "reference": "Should this be \"the new revision value\"?" + }, + { + "prediction": "`Dette feltet m\u00e5 aksepteres n\u00e5r :other er :value.` -> `Dette feltet m\u00e5 aksepteres n\u00e5r :other er lik :value.`", + "reference": "You have deleted :attribute" + }, + { + "prediction": "Please remove this line.", + "reference": "The license header should be updated to the Apache one." + }, + { + "prediction": "I think we can remove the `expectedOperationName` and `expectedServiceName` as they are not used.", + "reference": "@zacharycmontoya Is there any way to distinguish a `SocketHttpHandler` from another `HttpMessageHandler` request?" + }, + { + "prediction": "I don't think we need to implement these.", + "reference": "Not sure about this one -- did you check somehow?" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Is there a good reason to keep this at the `pe_ver_win` name now that it's per-host?" + }, + { + "prediction": "I don't think you need to create a new instance here. You can just use `new SummaryProductFragment()`.", + "reference": "Not in the order of display : Front, Ingredient, Nutrition here (which is the right thing), Actually displayed: Front, Nutrition, Ingredients" + }, + { + "prediction": "why remove this field?", + "reference": "Why delete `StartTime`? This `StartTime` was used to avoid the PID was reused." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in the `teardown` method of the `Host` class. The `teardown` method of the `Host` class is called by the `teardown` method of the `HostGroup` class. The `teardown` method of the `HostGroup` class is called by the `teardown` method of the `Beaker::Test` class. The `teardown` method of the `Beaker::Test` class is called by the `teardown` method of the `Beaker::TestCase` class. The `teardown` method of the `Beaker::TestCase` class is called by the `teardown` method of the `Beaker::TestSuite` class. The `teardown` method of the `Beaker::TestSuite` class is called by the `teardown` method of the `Beaker::TestRunner` class. The `teardown` method of the `Beaker::TestRunner` class is called by the `run` method of the `Beaker::TestRunner` class. The `run` method of the `Beaker::TestRunner` class is called by the `run`", + "reference": "My concern here, is that if the dump_puppet_log also throws then we will lose the data about the teardown_exception." + }, + { + "prediction": "Why do we need to cast `size_t` to `int` here?", + "reference": "Should it be `int64_t`?" + }, + { + "prediction": "I think this should be 1000 * 60 * 60 * 24 * 365 * 10", + "reference": "is this value related to something ?" + }, + { + "prediction": "Why do we need to return `Keccak?` and `AddTxResult?`? Why not just `Keccak` and `AddTxResult`?", + "reference": "Add names to tuple elements ValueTask<(Keccak? Hash, AddTxResult? AddResult)>, should they both be nullable?" + }, + { + "prediction": "I think it would be better to do this replacement in the constructor, so that we don't have to do it every time `toUnderscore` is called.", + "reference": "I think it might make more sense to do this in Name.upperCamel; it is the entry point for upper camel strings." + }, + { + "prediction": "I don't understand why this is needed.", + "reference": "Huh? The point is that a cast isn't necessary" + }, + { + "prediction": "I think this should be `OPENEBS_IO_INSTALL_CRDS` to be consistent with `OPENEBS_IO_CREATE_DEFAULT_STORAGE_CONFIG` and `OPENEBS_IO_CREATE_DEFAULT_STORAGE_CLASS`.", + "reference": "can we name it like `InstallV1Alpha1CRDs` ?" + }, + { + "prediction": "I think this should be `hive.openshift.io/hiveutil-created` instead of `hive.openshift.io/hiveutil-created`", + "reference": "I need something to match when creating selectorsyncsets so added this label." + }, + { + "prediction": "I think we can remove the `# :nocov:` here as well.", + "reference": "Isn't `nil` the default return value from an empty `rescue` clause? If that's correct, then we could just remove the `nil` line entirely as it doesn't serve a purpose." + }, + { + "prediction": "I think this should be \"This code example demonstrates how to add a cross-origin resource sharing (CORS) configuration containing a single rule to an Amazon Simple Storage Service (Amazon S3) bucket.\"", + "reference": "Simple Storage **Service**" + }, + { + "prediction": "Shouldn't this be `r.idx.Obsolete().Sub(validIndex)`?", + "reference": "Wouldn't that cause the obsolete indexes to be downloaded over and over again? After all these are still stored in the repository." + }, + { + "prediction": "Line is too long. [81/80]", + "reference": "We might want to move this logic to a Plain Old Ruby Object down the road. Not a blocker." + }, + { + "prediction": "I think we can remove the `if (this.toolbox_)` check here.", + "reference": "move `this.toolbox_.position();` to just after line 1477. Context: the if statement on line 1472 checks whether this is a toolbox with categories, and if so it populates the toolbox. Positioning the toolbox is a reasonable followup to that, and means you don't need an extra if. You may also need to call `this.flyout_.position()` after line 1483, which is the equivalent for the non-category toolbox." + }, + { + "prediction": "I don't see how this can ever be false.", + "reference": "Should the function above be .FirstOrDefault() instead? Otherwise, why check for null and tell ReSharper to ignore the fact that it can never be null?" + }, + { + "prediction": "why do we need this?", + "reference": "Let's not create new connection, but rather user `common.db` one" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it works for now.", + "reference": "Can this use asset_path rather than defining an image_url helper?" + }, + { + "prediction": "I think it would be better to use `constant` instead of `always` here.", + "reference": "Hindley-Milner signatures don't use literal types. They explusively use types. It's deal with that" + }, + { + "prediction": "I don't think we need to store the name and namespace of the network policy here. We can just store the UID of the network policy.", + "reference": "Could we just extend PolicyRule with more fields? It was originally designed as the struct required by openflow client, nested structs seem not helping. And for the name of the fields, initialism should be uppercase, OFID and NPName doesn't look good, then maybe FlowID, PolicyName.." + }, + { + "prediction": "Please add a space after the comma.", + "reference": "I really dislike this alignment approach, as it makes identifying individual functions quite hard, but I kept consistent with the previous style. Since no sorting was evident, I pushed it to the end of the block. Meanwhile, is this supposed to be tested or meaningfully testable somehow?" + }, + { + "prediction": "I'm not sure I follow this. If `is_complete` is called before `get_steps_to_execute`, shouldn't `is_complete` return `False` because `get_steps_to_execute` hasn't been called yet?", + "reference": "Could also consider modifying the ActiveExecution..." + }, + { + "prediction": "I think it would be better to raise a `TypeError` here, since this function is supposed to return an `astroid.Const`, not an `astroid.Const` or `None`.", + "reference": "Does it make sense to change that to a custom error instead of `ValueError`?" + }, + { + "prediction": "I'm not sure this is the right thing to do, but I think it's the best we can do for now.", + "reference": "I guess this will need to change soon." + }, + { + "prediction": "I'm not sure why this is here. I don't think it should be.", + "reference": "Restore this spacing - not sure why it has to be removed?" + }, + { + "prediction": "I don't think we need to define `_XOPEN_SOURCE` if we're already defining `_POSIX_C_SOURCE`.", + "reference": "These defines cause issues in base.h leading to failing android builds. Locale independency is now set in multiple spots, in cmake and in base.h. The base.h uses feature test macros wrong. Feature test macros can be used to indicate that a feature should be made available. They do not guarantee that it is available. On the cmake side this is done by the check symbol macros (similar to what autoconf does). On the android side not. I would suggest removing this from base.h and define locale independent in gradle. It is available since android 21 I believe. Is there a way in gradle to set locale independent only if android api >= 21?" + }, + { + "prediction": "`loopBody != getDst` -> `loopBody != dst`", + "reference": "Why not delete these codes?" + }, + { + "prediction": "`FLAGS_meta_client_retry_times` is not used in `waitForMetadReady`.", + "reference": "If pull message failed after some reties, we should ensure the storaged exit, otherwise it has risk to loss data." + }, + { + "prediction": "`first` and `count` are not used in this file.", + "reference": "looks like you don't need to import first and count here anymore" + }, + { + "prediction": "I think we can just remove this method for now. We can add it back later if we need it.", + "reference": "FYI, visibility task processing is local only, meaning pushing something to local ES cluster / local archival endpoint" + }, + { + "prediction": "This import should be removed.", + "reference": "This import can be removed." + }, + { + "prediction": "I think this should be `strings.HasPrefix(a.Region, \"fips-\") || strings.HasSuffix(a.Region, \"-fips\") || strings.Contains(a.Region, \"-fips-\")`", + "reference": "1. Nit: We can have a general helper to identify if a region is pseudo region. We might already have one somewhere. 2. Does any type of ARN support FIPS? If not, we may just move this check in arn package?" + }, + { + "prediction": "I think we can remove this exception now.", + "reference": "is this phrase completed in a next line? Or forgot to add... what?" + }, + { + "prediction": "Please remove the `total_epochs` and `workflow` in this file.", + "reference": "`('train', 5)` and `('train', 1)` are actually the same." + }, + { + "prediction": "I think this should be `limit float64` instead of `limit int64`.", + "reference": "Would it be too complicated to refactor `currLimit` to be an `int64`?" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "Would it be more performant to just `include ::RSpec::Core::Pending` here? /cc @myronmarston" + }, + { + "prediction": "`+optional` is not needed here.", + "reference": "Should be podiochaos?" + }, + { + "prediction": "I'm not sure if this is the right place to put this, but it seems to work.", + "reference": "Is the `codecs.register(lambda name: None)` gracefully handled by codecs? The lambda is expected to return a tuple of functions (encoder, decoder, stream_reader, stream_writer) (or a CodecInfo object), according to the docs. I've only checked python's built-in help, though." + }, + { + "prediction": "I think it would be better to throw an `ArgumentException` here. This will make it easier for users to understand why their instrument is not being exported.", + "reference": "in this case, it could be either instrument name or the view name, which could be invalid. might be better if we can offer very specific message. (not blocking this, we can add this as a follow up,if needed)" + }, + { + "prediction": "I think it would be better to use `this.driver_.getExecutor().w3c ? 'handle' : 'name'` instead of `this.driver_.getExecutor().w3c ? 'handle' : 'name'`.", + "reference": "I'd rather just send the parameter twice than break encapsulation here. There's already precedence with webelement IDs" + }, + { + "prediction": "Please remove the `# NOQA` and `# NOQA`", + "reference": "You may put 'open-mmlab://res2net101_v1d_26w_4s' here. MMCV will be updated later." + }, + { + "prediction": "nit: I think it would be better to have these constants in a separate file (e.g. `constants.js`) so that they can be used in other files as well (e.g. `pagespeed-insights.js` and `pagespeed-insights-reducer.js`).", + "reference": "May be worth making this more specific, to avoid potential conflicts, maybe `pagespeedDashboardWidget`? Or `webVitalsDashboardWidget`?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get rid of the `Failed because:` part of the error message.", + "reference": "I guess this assignment is now redundant?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in the `Forward` method of each backend.", + "reference": "See above note re: blockNum synchronization." + }, + { + "prediction": "nit: I think it's better to use `github.com/spiffe/spire/pkg/agent/common/backoff` instead of `github.com/spiffe/spire/pkg/agent/common/backoff/backoff`", + "reference": "wonder if we could avoid doing named imports if we type aliased `backoff.Backoff` in the `.../agent/common/backoff` package?" + }, + { + "prediction": "nit: please remove this empty line", + "reference": "Or maybe put into alphabetical order with the other #includes." + }, + { + "prediction": "Why not use `time.Sleep` here?", + "reference": "This runs the entire duration of the program; this change is not needed." + }, + { + "prediction": "Why do we need this?", + "reference": "I don't feel well about the `ALWAYS_UPDATE` option   sounds like a workaround. I can imagine that some of the plugins want to observe all options. Maybe, in that case, we can reuse the `CONFIG_KEYS` that would return an empty array for observing all settings and `false` for disabling observing at all? I just thinking aloud - Like `CONFIG_KEYS` sounds reasonable. We could support and maintain it in the future, even after implementing the \"observability\" to the MetaManager then `ALWAYS_UPDATE` ... I don't know :)" + }, + { + "prediction": "I don't think this is a clang-format bug. The `clang-format on` line is indented by 4 spaces, and the `clang-format off` line is indented by 8 spaces. That's a difference of 4 spaces, not a tab.", + "reference": "A \"tab difference\"? As in, there are tab characters somewhere? This disabling of clang-format for all the code here seems like overkill. Are you sure there's not some other solution? I don't really understand the problem though. Do you mean clang-format-diff?" + }, + { + "prediction": "I don't think we should be importing `org.openqa.selenium.remote.tracing.*` here.", + "reference": "Could you please leave the explicit imports?" + }, + { + "prediction": "Why do we need this? If the method config is not in the map, it means that the method does not exist in the interface.", + "reference": "Can we check for containsKey here?" + }, + { + "prediction": "I think this should be `os.Args[1] == \"help\" || os.Args[1] == \"-h\" || os.Args[1] == \"-help\" || os.Args[1] == \"--help\"`", + "reference": "Exit successfully. We served the help the user wanted." + }, + { + "prediction": "I think this should be `InitialWorkingDirPath` to be consistent with `InitialPackagePath`.", + "reference": "Had to rename this because `InitialPackage()` already existed." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it works for now.", + "reference": "Can we put this in a different helper?" + }, + { + "prediction": "I don't think we need to do this. We should be able to just use `dstack_offs += XSP_SZ * 2;` instead of `dstack_offs += 15 * XSP_SZ;` and `dstack_offs += XSP_SZ;` at the end.", + "reference": "I'm not sure where your 31 comes from? I see 15 here and 2 above for pc and flags, for 17 total beyond the SIMD." + }, + { + "prediction": "I think this should be `@Path(\"/apiTermsOfUse\")` and `@Path(\"/api/termsOfUse\")`", + "reference": "If you want, you could change this to `allowCors(response` (like in \"version\", above) to allow Cross-Origin Resource Sharing. I'm sort of wondering what's returned if no API terms of use are set." + }, + { + "prediction": "Why is this needed?", + "reference": "Why do we need to override this if all we're doing is passing it up?" + }, + { + "prediction": "I don't think this is the right place to send the controls. The controls should be sent after the table is created and before any data is inserted into the table.", + "reference": "Just wondering whether it's safe to send all CQDs to the child compiler. As this missing CQD is causing trouble, maybe some other user CQDs that now get sent could also cause the statement to fail? Also, if I have a table with a nullable unique column, should I have to set this CQD to create another table like it, or should the CREATE TABLE LIKE work without the CQD?" + }, + { + "prediction": "I think this should be `DAGSTER_EARLIEST_RELEASE = packaging.version.parse(\"0.12.4\")` so that we can use `DAGSTER_EARLIEST_RELEASE > packaging.version.parse(\"0.12.4\")` later on.", + "reference": "EARLIEST_TESTED_RELEASE might be slightly more clear" + }, + { + "prediction": "I don't think this is correct. The `.*` at the start of the regex will match the entire line, and the `.*` at the end of the regex will match the entire line again. I think you want `.*#.*pylint:\\s*([^;#]+)[;#]?.*` instead.", + "reference": "I think replacing `.*` with `\\s*` from after the hash makes sense, but not the rest of the changes." + }, + { + "prediction": "I think this should be `omitempty` as well.", + "reference": "interesting .. did not know varint tag covered bool as well" + }, + { + "prediction": "nit: I think it would be better to use `uint64_t` instead of `int64_t` here.", + "reference": "Could you please elaborate the reason for not using `gkc_summary` like the values above? I ask this, because I assume what we want to collect is a histogram of event loop latency, and we use `gkc_summary` for collecting histograms." + }, + { + "prediction": "I don't think we need to change this method. It's only used in `getTransactionHashes` which is only used in `getTransactionHashes` which is only used in `getTransactionHashes` which is only used in `getTransactionHashes` which is only used in `getTransactionHashes` which is only used in `getTransactionHashes` which is only used in `getTransactionHashes` which is only used in `getTransactionHashes` which is only used in `getTransactionHashes` which is only used in `getTransactionHashes` which is only used in `getTransactionHashes` which is only used in `getTransactionHashes` which is only used in `getTransactionHashes` which is only used in `getTransactionHashes` which is only used in `getTransactionHashes` which is only used in `getTransactionHashes` which is only used in `getTransactionHashes` which is only used in `getTransactionHashes` which is only used in `getTransactionHashes` which is only used in `getTransactionHashes` which is only used in `getTransactionHashes` which is only used in `getTransactionHashes` which is only", + "reference": "getHash should be a public and without an `_` if used here." + }, + { + "prediction": "I don't think this is a good idea. The genesis block is a special case and should be handled separately.", + "reference": "Unrelated to these changes -- we will probably want some special handling for genesis block validation." + }, + { + "prediction": "nit: I think it would be better to call this `DiskBlockCacheFractionSetter` to make it more obvious that it's a setter.", + "reference": "This is probably overkill since we don't actually need to pass this specific interface anywhere, but I don't mind it!" + }, + { + "prediction": "I'm not sure this is the right place to add the peer to the `receivedPeers` map. I think it should be done in the `AddPeer` method of the `p2pService`.", + "reference": "@janos I moved this back here, to avoid having multiple add peer calls being handled. I think it's either this or a global lock across the whole function. I think this is a better approach, especially since `hive.Broadcast` is blocking . We can remove the map entry on errors if needed. LMKWYT?" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work for now.", + "reference": "Minor: can we put the conditional outside of the partial?" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "We need to find something more efficient than this. We can probably just check the first element and assume the type list is consistent.." + }, + { + "prediction": "I think this should be `A %s is a task which can be programmatically run, either on a schedule or via service code in response to events.`", + "reference": "How \" via service code in response to event.\"? I don't think we'll get in the no schedule option to the release. We should probably wait for some customer feedback first to make sure we're addressing different event-triggers the best way" + }, + { + "prediction": "Please revert this change.", + "reference": "Please move unrelated formatting changes to their own PR (same with the resources.py file)." + }, + { + "prediction": "I think this should be `window._state_before_fullscreen = window.windowState() & ~Qt.WindowFullScreen` instead of `window._state_before_fullscreen = window.windowState() & ~Qt.WindowFullScreen`", + "reference": "Make this a public attribute (remove the leading `_`) if you want to access it from the outside." + }, + { + "prediction": "Why is this change necessary?", + "reference": "this conditional is useless now so it should be removed" + }, + { + "prediction": "I'm not sure why this is needed, but it seems like a good idea to be explicit about the type of `i` and `i+1`.", + "reference": "`vecofstructs->size()` already returns a `uoffset_t`. So if you just change the type of `i`, you don't need any casts." + }, + { + "prediction": "I think this should be `if (configProto == null || configProto.getEnableProtoAnnotations() == null) {`", + "reference": "Nit: Maybe merge this with the configProto check on line 208? Don't feel that strongly though, please keep separate if you prefer." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get the tests to pass.", + "reference": "I know we already did this in 4.0 so carry on, but I'm facepalming here we should've made an overrided setMessageHandler that sets ismaster to true when hello is present. Esp in 4.0 where we already have some overrides written. We can keep going here and maybe open a ticket to some effect of that solution" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think we want to use `data-turbolinks=\"false\"` here so that the skip link doesn't trigger a turbolink page load.", + "reference": "I believe we could use `link_to` here (although not super important). Also, we should internationalize this value. I'm not 100% sure what our process is for adding new UI strings these days (e.g. skip the specs that will fail if we add a new key to only one language, use Google Translate to translate the value for us, some other option)." + }, + { + "prediction": "I think this should be `if (result == VK_SUCCESS && pProperties) {`", + "reference": "This was already in vkGetPhysicalDeviceDisplayProperties2KHR..." + }, + { + "prediction": "nit: I think this should be `DockerEngineValidator` to be consistent with the rest of the codebase.", + "reference": "nit: I'd expect a public method called IsDockerEngineRunning to return a boolean yes/no, not the error message. Can we change either the return value or the name? Something like `CallDockerEngine`" + }, + { + "prediction": "I think we can keep this at 512. 700 seems like a lot for a type name.", + "reference": "If i remembered correctly, type_name is '{RESOURCE_TYPE}/{RESOURCE_NAME}', if type_name is 700 max then name cannot exceed that size" + }, + { + "prediction": "I think this should be `GetBufferIdentifier` instead of `BufferHasIdentifier`.", + "reference": "When calling functions with keyword arguments: please provide the arguments as keyword arguments, not positional arguments." + }, + { + "prediction": "Why not use `act_cfg` here?", + "reference": "We may follow the argument order: conv_cfg, norm_cfg, act_cfg." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "`options['binary'] = WebDriver::Chrome.path` if set?" + }, + { + "prediction": "I think this should be `#include \"folly/ssl/Init.h\"`", + "reference": "folly library should be put on the top." + }, + { + "prediction": "I don't think we need the `isSvg` check here. `ns` will always be `false` if `isSvg` is `false`.", + "reference": "Do we have to restrict this to SVG elements? I think setting namespaced attributes on normal dom elements (while not as common) is still valid, so perhaps we can save some bytes by removing the `isSvg` check?" + }, + { + "prediction": "I think it would be better to use `row` instead of `this.hot.toPhysicalRow(row)` here.", + "reference": "Please add it to the `REMOVED_HOOKS` constant." + }, + { + "prediction": "I think we can remove this line, it's not being used.", + "reference": "This variable needs `.v1` at the end of it, or the tests below need it. There are some test failures as a result" + }, + { + "prediction": "I think it would be better to have this method in the `Account::Access` class.", + "reference": "Is this access protected so that only admins can access this route?" + }, + { + "prediction": "I think this should be `FLT_MAX` instead of `DBL_MAX`.", + "reference": "What happens if the minimum x coord is > 0? This will incorrectly set it as zero, right?" + }, + { + "prediction": "Shouldn't this be `o.maxAckPending`?", + "reference": "I think you want to look at current pending + batchSize and if that is > o.maxp no?" + }, + { + "prediction": "Why is this change necessary?", + "reference": "Should this be `codes.Error`? `codes.Internal` was an error status before." + }, + { + "prediction": "Align the parameters of a method call if they span more than one line.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", + "reference": "I don't think you need these lines." + }, + { + "prediction": "I think this should be `DiskLimiter` instead of `DiskLimiter`.", + "reference": "You didn't mean to export this, right?" + }, + { + "prediction": "Nitpick: I think this should be \"the AWS SDK for Ruby (v3)\".", + "reference": "Simple Notification **Service** (singular)" + }, + { + "prediction": "I think this should be `egressConfig *config.EgressConfig` instead of `egressConfig *config.EgressConfig`.", + "reference": "Do we still need this?" + }, + { + "prediction": "Is this debug code? If so, please remove it.", + "reference": "We do have a disconnect between the privateMarkerTransactionFactory.getSender() call and the createPrivateMarkerTransaction() call. When the plugin receives the call to create the PMT it does not know what the sender was returned by the other call. At a minimum we need to pass in the sender to the second call. I would prefer that the plugin does the locking if that is necessary. If you are using random keys you don't have to lock! Besu could signal to the plugin when a PMT was un- or successfully added to the pool using a callback. Callback could be null if this is not needed. The plugin would have to be able to get the nonce for a certain key from besu. What do you think?" + }, + { + "prediction": "I don't think this is the right translation key. I think it should be something like `MessageImageEditorLoadError`.", + "reference": "This is a bit inconsistent with the `ErrorStartHourGreaterThanEnd` in the previous file. Wouldn't `ErrorDefault``fit better here?" + }, + { + "prediction": "I don't think we need to skip this test for IPv6 cluster.", + "reference": "I think it will revert the change @antoninbas did on purpose 05eee251c9c53400277def576f92d614ca234898" + }, + { + "prediction": "I think this should be `if ifaceName == \"wireguard.cali\" || ifaceName == \"wg-quick.cali\"`", + "reference": "nit: a switch perhaps?" + }, + { + "prediction": "Line is too long. [117/80]", + "reference": "Would it make sense for `opensearch_description_tag` to have default values for the title and href attributes?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it makes sense to return an empty list of ImmutableRootMetadata if the TLF journal is disabled.", + "reference": "Just noticed this while debugging -- it's unlikely to be causing issues in practice." + }, + { + "prediction": "I'm not sure why this needs to be longer than the default 500ms.", + "reference": "That seems unrelated - did that fix a random test failure you noticed while working on this issue?" + }, + { + "prediction": "nit: I think we can simplify this to `metadata = base != null && base.file() != null ? metadata.addPreviousMetadata(base.file().location(), base.lastUpdatedMillis()) : metadata;`", + "reference": "This kind of concern should be handled in the `TableMetadata` update methods. This is similar to `metadata.rollbackTo`, which not only sets the current version, but also updates the table history. I think that all of those methods should add the current object's `file.location()` to the previous metadata location list, if it is non-null. That way, the caller never needs to remember to update it." + }, + { + "prediction": "`mlvl_tensor_list = [mlvl_tensors[i][batch_id].detach() if detach else mlvl_tensors[i][batch_id] for i in range(num_levels)]`", + "reference": "We need to know why all the tensors are detached in `get_bboxed`." + }, + { + "prediction": "I think this should be `type(self).__a = ''`", + "reference": "Unrelated but shouldn't this raise `attribute-defined-outside-init`?" + }, + { + "prediction": "I think this should be `create_no_window=True` by default.", + "reference": "I would rather no have this as a `kwarg` as it encourages \"growth\" which lead to an unweildy constructor in other classes. Let's add a method or property to take care of this instead as I think it's usage is going to be quite low." + }, + { + "prediction": "Metrics/LineLength: Line is too long. [123/120]", + "reference": "You just changed my life :) I grew very attached to this safe nav approach when working with Groovy years ago `obj?.method`. Glad to see its now a part of Ruby!" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I added a `clear-fix` class to the submit button and the cancel button so that they don't float next to each other on the page.", + "reference": "do you mean 'clearfix' class?" + }, + { + "prediction": "I don't think we need to mention causal consistency here.", + "reference": "`causalConsistency` is already defined on `SessionOptions`. We do not need to duplicate it here." + }, + { + "prediction": "I don't think we should use `static import` for `any`, `anyString` and `eq`", + "reference": "This should not be included since there are no code changes." + }, + { + "prediction": "Shouldn't we also set `Access-Control-Allow-Credentials` to `true`?", + "reference": "If all we need just response 200, then we could use `c.Status(http.StatusOK)` here." + }, + { + "prediction": "I think we can remove the `if _, ok := err.(errors2.ErrorResourceDoesNotExist); err != nil && !ok {` check and just do `if err != nil { return }`", + "reference": "Should be checking for error here" + }, + { + "prediction": "I think this should be `FormTabs::SECTION_OUTSIDE, $this->config`", + "reference": "Put a space between `(array)` and `$this` and I'll merge it" + }, + { + "prediction": "I think this should return `runtime.Stack(buf, all)`.", + "reference": "You could add this to stack.go, which has similar functions (to avoid yet another small file). None of these are likely to be implemented considering what TinyGo is designed for." + }, + { + "prediction": "This class is not needed. The `notificationId` and `content` can be accessed directly from the `NotificationContent` object.", + "reference": "the class names `NotificationHolder` and `NotificationsHolder` are fairly difficult to quickly tell apart, particularly since they are often used close to each other" + }, + { + "prediction": "This should be `import java.util.*;` instead of `import java.util.*;`", + "reference": "Avoid wildcard imports" + }, + { + "prediction": "I think this should be `CandidatesByHeight(height uint64) ([]*Candidate, error)` instead of `CandidatesByHeight(uint64) ([]*Candidate, error)`", + "reference": "Need to do this to unblock mockgen. The interface method needs to be public to be visible in another package. The right fix is to delete this test only interface method" + }, + { + "prediction": "Shouldn't this be `Object.keys(items).map(k => k.toLowerCase()).indexOf('loadbalanced') !== -1`?", + "reference": "same question here as I have on the other file regarding doing this check here vs L112 vs not at all" + }, + { + "prediction": "I think this should be `!linux` instead of `!openbsd`.", + "reference": "Adding `// +build !windows` (as a separate line) will do the same for Windows. So while you are at it we might add it as well." + }, + { + "prediction": "I don't think we need this anymore.", + "reference": "this is used as important way of mocking for unit tests, FYI" + }, + { + "prediction": "I think this should be `muted_alpha=0.5`", + "reference": "Sorry, should have been clearer, I meant adding this to the ``Histogram`` options one line above." + }, + { + "prediction": "I'm not sure why this change is necessary, but I don't think it's related to this PR, so I'm okay with it.", + "reference": "Just ignorance on my part, but what is the significance of the change from C23NHe2 to C23NHx2?" + }, + { + "prediction": "I think this should be `param.Array` instead of `param.ClassSelector`.", + "reference": "What about tuples or pandas series? Do we want to support lots of different types or force a single type?" + }, + { + "prediction": "I don't think we should be throwing an exception here. I think we should just log a warning and return an empty map.", + "reference": "Small thing, without the check above this will throw a NoNodeException if the path doesn't exist. Maybe this can be wrapped in a try/catch just for the NoNodeException, so that the more user-friendly message used above can be thrown instead: `throw new KeeperException.NoNodeException(\"No collection found at path: \" + path);` Just a thought, I'm not even sure it's worth it." + }, + { + "prediction": "Line is too long. [101/80]", + "reference": "I don't know why this worked before, but we should be explicit on not verifying that a blank string (allowed as a way to remove a url/download_url) is a valid url as it is not." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I don't think we want to warn about this anymore.", + "reference": "Do we want to raise an error here instead of warning? Or would it be better to just see if Bolt happens to succeed, and let it fail on it's own if it fails? I'd lean towards raising an error, but that's different from \"removing support\"." + }, + { + "prediction": "I think this should be `self.filter_options(unfiltered) must be implemented by the transport class` instead of `self.filter_options(unfiltered) or self.filter_options(unfiltered) must be implemented by the transport class`", + "reference": "This is kind of confusing with the other `filter_options`." + }, + { + "prediction": "I think this should be `if err == nil || _, ok := err.(OpsCantHandleFavorite) {`", + "reference": "Could the `deleteFromFavorites` happen when `head == nil` because it's not initialized yet somehow but not because TLF doesn't exist? I was concerned if this would make it possible in any way to have favorites seemingly deleted on a device while it's not actually happened on server." + }, + { + "prediction": "Why is this changed to Int64?", + "reference": "It doesn't look like this particular \"rowCount\" variable is used anywhere. I suppose we could delete it. The code change is harmless though." + }, + { + "prediction": "I think this should be `if status == 204 || status == 205 {`", + "reference": "Hmm, probably we should instead write whatever `status` is returned instead of coding a special case." + }, + { + "prediction": "nit: I think it would be better to use `in.HTTPMatch.Methods == nil` instead of `in.HTTPMatch != nil`.", + "reference": "Could using the pointer-to-struct approach here cause confusion later? We've had several problems of that kind in the past. What does it mean if the struct is non-nil but its fields are nil? Is that even allowed? (libcalico-go question) Are there any validation requirements for this new rule addition; should it only be allowed if `Protocol == TCP`, for example?" + }, + { + "prediction": "Line is too long. [101/80]", + "reference": "why this recursive relationship definition?" + }, + { + "prediction": "I'm not sure I understand the difference between `Encoding` and `Signature` here.", + "reference": "More sentence, less list please. > Encoding of the handler. This field is optional. We don't need to mention exactly what it's used for because that list can expand (as it has already in this change)." + }, + { + "prediction": "I think it would be good to mention that these metrics are only collected if the `trace.Exporter` and `stats.Exporter` are set.", + "reference": "Not part of this PR, but should the section above say what the name of the metric is for each method?" + }, + { + "prediction": "I think this should be `valueDisplay = (metric as IGaugeMetric).LastValue.Value.ToString(CultureInfo.InvariantCulture);`", + "reference": "there are changes that are upcoming to this section. For now, this works (to demo the usage of Gauge), and the changes to this section are coming as separate PRs." + }, + { + "prediction": "I'm not sure this is the right thing to do. If we are in the background process group, we should not be reading from the terminal at all.", + "reference": "This is equivalent to stdout. Why not just replace stdin with stdout in `IsProcessBackground`?" + }, + { + "prediction": "Shouldn't this be `if (p_jmsg[\"compress_method\"] != nullptr && p_jmsg[\"compress_method\"] == \"zfp\")`?", + "reference": "Rather than test for nullptr, just treat the pointer as a bool, i.e. `if(p_jmsg[\"compress_method\"])`" + }, + { + "prediction": "I don't think this is the right place to show the error dialog. I think it should be done in the `createShortcut` method of the `LibraryFeaturePanel` class.", + "reference": "Can we move the remaining code of this method to a new method? I don't like the `return;` here, we could try to replace it with an `if ... else ...` syntax. What do you think?" + }, + { + "prediction": "I don't think we need to listen to every resources. I think we only need to listen to `bucket` and `collection` resources.", + "reference": "nitpick: _and collections_" + }, + { + "prediction": "nitpick: I think it would be better to use `unsigned int` instead of `unsigned`.", + "reference": "I believe these need to be explicitly initialized in `proxy_send_prepare`" + }, + { + "prediction": "I think this should be `t0 = time.time()` instead of `t0 = time.time() # Failed task start time`", + "reference": "This is unnecessary. The declaration of `t0` on line 179 is still in scope inside the `except` block." + }, + { + "prediction": "I don't think we need to mention that only solid colors are supported.", + "reference": "The `border_color_`... properties don't support solid colors, not only this one. Maybe `@param solid_color` should be used instead of adding this note to every one of them?" + }, + { + "prediction": "Do we need this? I don't think we do.", + "reference": "We don't need this file, we can use the one that is in the grid-ui directory" + }, + { + "prediction": "I think this should be `if (isEmptyLine(path)) { continue; }`", + "reference": "FYI: inlined this method in the internal review." + }, + { + "prediction": "I don't think this import is needed anymore.", + "reference": "Werid, the checksum between this file and the one on branch `develop` is the same not sure why it's showing a diff" + }, + { + "prediction": "I think this should be `metric.Meter.Name + \"/\" + metric.Name` instead of `metric.Meter.Name + metric.Name`", + "reference": "Prometheus doesn't have concept of Meter (like OTLP does).. Trying to see if this is a good approach to use the meter name as namespace, to avoid name collisions, when same instrument name is used across multiple instruments, from different Meter." + }, + { + "prediction": "I'm not sure this is the best way to do this. I think it would be better to have a method in the `ILS` class that checks if the auth method is `Shibboleth` and if the `auth_based_library_cards` config is enabled.", + "reference": "The formatting of this is a bit strange; I'd suggest collapsing this back to a single line, and moving the `&&` to the beginning of the second line to meet the line length restriction." + }, + { + "prediction": "I think this should be `else if (segments != NULL && num_segments > 0)`", + "reference": "One or the other should be non-NULL. If segments is NULL, the alloc above will have size zero, which we do not allow (there's no header): it should assert in debug build. So there should be asserts that one is non-NULL at the top, and if there really needs to be some kind of defensive check down here, it should cover the alloc too." + }, + { + "prediction": "Line is too long. [101/80]", + "reference": "I'm surprised rubocop isn't picking up singe quotes?" + }, + { + "prediction": "I think we can remove this now that we don't use `parseTime` anymore.", + "reference": "Is this line still needed?" + }, + { + "prediction": "I don't think we should change the default heartbeat period for the SEDP endpoints.", + "reference": "Maybe use specific values for all the watt.times fields? Even better, have a const for it at the top of the file?" + }, + { + "prediction": "I think this should be `brailleTables` or `braille_tables` to be consistent with the rest of the codebase.", + "reference": "nit: UNICODE_BRAILLE_TABLE or something might be a better name for this. IMO, braille-patterns.cti is a terrible name. This table allows Unicode braille characters to be used anywhere to produce raw dots." + }, + { + "prediction": "I don't think we need this anymore.", + "reference": "Why are we removing the option to skip machine pool generation?" + }, + { + "prediction": "Should this be `IHttpStartLineHandler` where `T` is the type of the `HttpStartLineContext`?", + "reference": "\"Request line\" here too." + }, + { + "prediction": "I'm not sure this is the best way to do this. I think it would be better to have the zone controller check if the loot is allowed, and if it isn't, send the message to the client.", + "reference": "Please remove this." + }, + { + "prediction": "I'm not sure why we need this.", + "reference": "Weird bug. Combining those joins and group calls was triggering AREL to generate the sql cache inside of will_paginate before the final call. This is a harmless workaround, but hints that will_paginate might becoming seriously deprecated." + }, + { + "prediction": "Metrics/LineLength: Line is too long. [101/80]", + "reference": "This can be simplified as discussed before." + }, + { + "prediction": "I'm not sure this is the right place for this. I think it should be in the `execute` package, but I'm not sure if it should be in the `execute/table` package or the `execute` package.", + "reference": "Does `internal` or `test` in the file name actually do anything here? Or is that just to show these functions are only for tests?" + }, + { + "prediction": "Why is this change necessary?", + "reference": "does this boolean indicate unsafe serialization?" + }, + { + "prediction": "I don't think we need to throw an error here. We can just return an empty array.", + "reference": "Maybe rewrite to `Is only implemented for React Native`? (I assume that is the case)." + }, + { + "prediction": "I think we can remove the `if (language == TargetLanguage.PHP)` check here, since the `resourcesField` will always be non-null in that case.", + "reference": "Do we not need this in Java because Java *is* handling map responses?" + }, + { + "prediction": "I think this should be `True` by default.", + "reference": "Maybe \"For configuring which scheduler messages can be received.\"?" + }, + { + "prediction": "`$this->getMediaManager()->getEntityManager()->clear();` should be `$this->getMediaManager()->getObjectManager()->clear();`", + "reference": "It will stop working with orm, so this is not a good fix, Try using some method in a common interface" + }, + { + "prediction": "I think we should have a single `Azure.Sdk` listener that listens to both `Azure.Clients` and `Azure.Pipeline`.", + "reference": "`s` is not necessarily the same as `sampler` - sampler could be null and this crazy lambda underneath falls back to something. So please use `s`" + }, + { + "prediction": "I don't think we need to set it to null here. It will be set to `null` in the constructor of `ParameterGenerator`.", + "reference": "This code is a bit confusing. Should HttpParameterType set to the original one or it is always BODY?" + }, + { + "prediction": "I think this should be `!isTest && c.state.Config.Remote.VerifyOutputs` since we don't want to verify outputs for tests.", + "reference": "Why did this change?" + }, + { + "prediction": "I think this should be `newProtoForTableStatus(result.Table.TableStatus)`", + "reference": "nit: `status` collides with imported package named `status`" + }, + { + "prediction": "nit: `IsWritingCatchpointFile returns true when a catchpoint file is being generated. The function is used by the catchup service so that the memory pressure could be decreased until the catchpoint file writing is complete.`", + "reference": "\"memory pressure could be decreased\" --> \"to avoid memory pressure\"" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to be the only way to create a user that doesn't already exist in the database.", + "reference": "I think it would make sense to fetch the cache values after deleting the listens and making sure they are what we expect." + }, + { + "prediction": "I'm not sure if this is the right place to do this, but it seems like a good place to me. We want to make sure that the collapsible state is set to `false` before we merge the new state with the existing state.", + "reference": "I'm thinking about covering this change with the test. Can you do that?" + }, + { + "prediction": "I don't think we need to change the signature of this method. I think we can keep it as it is and just add a new method `PingProviderWithPorts` with the new signature. This way we don't have to change the implementation of `NATProviderPinger` in `nat_pinger.go`.", + "reference": "Not sure if it's a good idea to remove stop channel. If user cancels connection how will you stop pinger?" + }, + { + "prediction": "I think we can remove the `sdkAuthConfig` variable and just use `authConfig` directly.", + "reference": "Could you please add a `TODO` here that we won't need `docker.AuthConfiguration` anymore when we migrate to SDK's pull image?" + }, + { + "prediction": "Why is this a task item array and not just a string array?", + "reference": "Is there a scenario were we want to get an arbitrary set of blobs that don't share a common root?" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it works for now.", + "reference": "Can you leave a note about why we are skipping regex tests?" + }, + { + "prediction": "I think this should be `repo.OpenRepo(repoDir, newConfig)` instead of `repo.OpenFSRepo(repoDir)`.", + "reference": "This was the only caller of CreateRepo, so I inlined it." + }, + { + "prediction": "I think this should be `AuthMountPath` to be consistent with the other fields in this struct.", + "reference": "As this is already a child of `auth`, I think we can shorten this to `path`" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get the first visible range.", + "reference": "This call should use element, not 0 I think." + }, + { + "prediction": "I think it would be better to call this `PartialPageFetchThresholdBytes` to make it clear that it's in bytes.", + "reference": "This is missing the definition of `fetch_until_empty_page` - it needs to go in the config section above." + }, + { + "prediction": "`File.expand_path?(path)` should be `File.expand_path(path)`", + "reference": "I don't think this one needs to be changed since the only previous path is already an absolute one." + }, + { + "prediction": "I think we can remove the `table.locationProvider()` here and just pass `null` to the `newStaticTable` method.", + "reference": "Since we kept the original constructor we might not need this change now." + }, + { + "prediction": "I think this should be `LOG.debug(\"Refreshed table [{}] from metadata location [{}]\", fullName, metadataLocation);`", + "reference": "There is already a log in `BaseMetastoreTableOperations` for this. It has the location, but not the table name. Maybe just add table name to that one." + }, + { + "prediction": "I think we should move this package to `pkg/filestore/minio` instead of `pkg/filestore/minio`.", + "reference": "This should be in the last group." + }, + { + "prediction": "I don't think this is the right place to send the statsd. I think it should be in the `SendTracesAsync` method, right after the `await _tracesSender.SendAsync(traces);` line.", + "reference": "I believe you should either remove this or rename the PR. You can't change the behavior of the tracer (even to fix a bug) in a PR named \"unit test improvements\"" + }, + { + "prediction": "I think this should be `certmanager.k8s.io/v1alpha1`", + "reference": "I've gone with this group name, however I'm open to suggestions on alternatives!" + }, + { + "prediction": "I think this should be `public static final RpcApi QUORUM_RPC = new RpcApi(\"QUORUM_RPC\");`", + "reference": "should this be GOQUORUM" + }, + { + "prediction": "Why do we need to pass in `checkCoinbase` here?", + "reference": "I think checkCoinbase is not skipping checking coinbase. Instead, true-> checking num(coinbase tx) = 1, false -> checking num(coinbase tx) = 0." + }, + { + "prediction": "`protocol.StateManager` should be `factory.WorkingSet`", + "reference": "same here, move it out" + }, + { + "prediction": "I think this should be `#if defined(KOKKOS_ENABLE_LIBDL) || defined(KOKKOS_TOOLS_INDEPENDENT_BUILD)`", + "reference": "Can you elaborate on why you need different behavior depending on Tools being built independently or not?" + }, + { + "prediction": "Metrics/LineLength: Line is too long. [123/120]", + "reference": "because of the above if statement will requires both ex_save and guid_save to be true, this code will always return 'example answer'. This should be revised with `example_answer.present?` and `guidance.present?`" + }, + { + "prediction": "I think it's better to use `context.Context` instead of `golang.org/x/net/context.Context`.", + "reference": "why not context from stdlib?" + }, + { + "prediction": "I'm not sure this is the right thing to do, but I don't know what else to do.", + "reference": "Just saw this and wasn't able to hold myself from renaming :-)." + }, + { + "prediction": "`Object.keys(core.plugins)[0]` should be `Object.keys(core.plugins)[0]` or `Object.keys(core.plugins)[0]`", + "reference": "Can we keep the other assertion too? I think it's helpful to ensure that the uninstall function was called too" + }, + { + "prediction": "I think we should use `Kernel.warn` instead of `RSpec.warn_with` here.", + "reference": "`warn_with` prefixes the message with `WARNING:`, right? So this will put `WARNING:` twice. It would be good to verify all the warnings look good after this change, given how easy it is to make a simple mistake like this :(." + }, + { + "prediction": "I think this should be `MessageTimeout` to be consistent with the rest of the codebase.", + "reference": "FYI In the message queue I use the term \"stamp\" to refer to the time-like mark associated with each message. It's opaque to the queue/pool and should make no difference if the stamps and age limit were converted to seconds. So this could then become `Stamper` with `CurrentStamp()` method, no reference to \"blocks\" or height etc. The wrapper struct could be `StampedMessage. The interpretation as block height is deferred to the user/constructor that hooks things up, the \"business logic\". This is just an observation, take or ignore as you wish." + }, + { + "prediction": "I don't think this is correct. If the bucket doesn't exist, we should return a 404.", + "reference": "Can we remove the `TODO` statement here? (as this is actually fixed in this PR)" + }, + { + "prediction": "I think this should be `private DisplayPreference mDisplayPreference = DisplayPreference.DEFAULT;`", + "reference": "m prefix no longer in code style" + }, + { + "prediction": "I think this should be `return kvb.store.Filter(ns, c, kvb.buffer)`", + "reference": "need to filter the entities in buffer as well" + }, + { + "prediction": "This should be `ID = \"de.danoeh.antennapod.core.glide.FastBlurTransformation\";`", + "reference": "Please add spaces before and after the equals sign" + }, + { + "prediction": "Why is this line commented out?", + "reference": "This file could also be cleaned up/deleted. But lets do this separately after ensuring all the event logging has been ported to the current logmxevent_traf.cpp file completely." + }, + { + "prediction": "I'm not sure about this change. I think it's better to keep the output the same as it was before.", + "reference": ":thinking:, the line number here is the line of the example (`example.location`), that's probably why I finally chose to display the example title because it's what can be found on this line, and saying that the error is from there is confusing. But presenting the actual failures is indeed better, so maybe we can get the failure actual line number from the exception backtrace and then output two distinct lines for failures like this one?" + }, + { + "prediction": "I don't think we need to add this to the `__init__` method. We can just add it to the `start` method.", + "reference": "We shouldn't add this as a new `kwarg` here. This should all be done on the options class" + }, + { + "prediction": "Should this be `ENV['OS_VOL_SUPPORT'] || 'true'`?", + "reference": "Should this be `OS_VOLUME_SUPPORT` to match the symbol key names?" + }, + { + "prediction": "I think this should be `static flux_msg_handler_t **handlers = NULL;`", + "reference": "In C, file scope variables are already initialized to 0 so the \"= NULL\" is redundant. Not a big deal." + }, + { + "prediction": "`getRootNode` returns `null` if `node` is not attached to the DOM. This will cause `doc` to be `null` in this case, which will cause a `TypeError` on the next line.", + "reference": "on line 40, the `relevantNode` can change and therefore the `doc` might change too for the lookup on line 43. I think this code should be moved to where the `doc` is actually being used" + }, + { + "prediction": "I think this is a bug. It should be `nameof(value)`, not `nameof(milliseconds)`. `nameof(milliseconds)` is the name of the parameter, not the name of the value being validated.", + "reference": "nit: just to be similar to others, can you change to interpolation?" + }, + { + "prediction": "I think this should be `IncludeRootCert` or something like that. `FullCertChain` is a bit ambiguous.", + "reference": "Would this make more sense as an option on an Issuer resource (specifically on the CA issuer) rather than as a flag? It's not ideal that we have a flag that _looks_ like it could be 'global' but is actually not IMO. Also, if Istio is reading the CSR object, is it possible for it to read the CA from the CSR itself too and append the two instead? Not sure if we ever decided whether to use annotations for this purpose @JoshVanL?" + }, + { + "prediction": "Is this used anywhere? If not, can we remove it?", + "reference": "Because this acts as a coordination point between client and server, it should go in core.py instead of const.py (so eventually the server could use it to guarantee that it delivers dates in the expected format)." + }, + { + "prediction": "I think this is the only place where we need to handle the case where the resource is not found. All the other places where we call `Get` should return an error if the resource is not found, so we don't need to handle that case here.", + "reference": "expected statement, found 'else' (and 1 more errors)" + }, + { + "prediction": "I think this should be called `FakeIDRandomOrPanic` or something like that.", + "reference": "IMO this doesn't need to be in the `kbfs` repo. And I don't like setting the byte. We can always compare with the randomly generated `TlfID`." + }, + { + "prediction": "I don't think we need to have these constants in a separate file. We can just have them in the `controller.go` file.", + "reference": "What's the difference from ModuleName in `pkg/apis/meta/v1alpha1/types.go`?" + }, + { + "prediction": "I think we can remove these two using statements now.", + "reference": "We shouldn't be changing this task as we are trying to break our dependency on it and switch to using the shipped version." + }, + { + "prediction": "I'm not sure this is the right thing to do here. I think we want to be able to skip XSP and XBP even if we don't skip any other registers. I'm not sure what happens if we skip XSP and XBP but not any other registers, but I think we should be able to do that.", + "reference": "Shouldn't we have a low bar for generating out-of-line context switch, i.e., if we need save more than n (3?) simd or m (4) gprs we should go out-of-line? And it should be || instead &&. It seems the bar is still very high after this change." + }, + { + "prediction": "nit: I think we can remove this empty line.", + "reference": "Should the API have a dependency on the SDK?" + }, + { + "prediction": "Why is this skipped?", + "reference": "Is this a sometimes leaky test?" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "It should be possible to create a test case that enter the loop. That would be a good enough test case for me. Have a look at the extern type inference test cases that already exist. Since you can just pick the type variables the extern type use, you should be able to create a conflict that requires this loop to fix." + }, + { + "prediction": "I think this should be `if not locale.IsAvailable(wxLang.Language) or not locale.IsAvailable(wxLang.Language + '_' + wxLang.Country):`", + "reference": "It might make sense to log this." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "Line is too long. [84/80]" + }, + { + "prediction": "I think this should be `goog:chromeOptions` instead of `goog:chromeoptions`.", + "reference": "nice touch since Google likes to change things every now and then." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but I think it's better than having a bunch of `if`/`elsif`/`else` statements.", + "reference": "Thank you this is so much nicer than the old `Rails.configuration.branding['blah']['blah']['blah']` :)" + }, + { + "prediction": "I think this should be `BACKEND_SERVICES` (plural).", + "reference": "nit: Would you mind alpha-sorting this?" + }, + { + "prediction": "I think this should be `ManifestContent.PARTITION` instead of `ManifestContent.DATA`", + "reference": "For my understanding, the DATA manifest & DELETE manifest could share the same read / write path so I think we could use the common reader+writer. Is there any other reason that we need to make them separate paths ?" + }, + { + "prediction": "Shouldn't this be `Rails.configuration.branding[:organisation][:contact_us_url] || contact_us`?", + "reference": "that change should be sufficient for avoiding the override of contact_us_url helper. The one defined at the .yml it is within a hash so no problem should arise." + }, + { + "prediction": "I think this should be `Erstellen und weiteres Element hinzuf\u00fcgen`", + "reference": "We actually had a discussion about this exactly in #3470, some languages seem to go for one, some for the other" + }, + { + "prediction": "I think this should be `List grpcStreamingDescriptors();` instead of `List grpcStreamingDescriptors();`", + "reference": "Is PHP the first dynamic MVVM language with grpc streaming support?" + }, + { + "prediction": "I don't think this is necessary. If `tmpStream` is `nullptr`, then `tmpStream->bad()` will throw an exception.", + "reference": "the `if` isn't necessary here; it's safe to call `delete` on `nullptr`" + }, + { + "prediction": "I think this should return a `ReturnCode_t` instead of a `bool`.", + "reference": "Change if the method's name finally changes to `clear_history` as proposed elsewhere" + }, + { + "prediction": "I think this should be `import docUtils` and `helpFile = docUtils.getDocFilePath(\"userGuide.html\")`", + "reference": "can this one also be moved to the top of the file?" + }, + { + "prediction": "I think we should call this `Resources` instead of `GroupMembers` to avoid confusion with the `GroupMember` type.", + "reference": "So if I understand this correctly the externalEntities should be computed and stored in GroupMember, while current code usage of GroupMemberPod will be migrated to GroupMember later?" + }, + { + "prediction": "I don't think we need to change the names of these constants.", + "reference": "Don't we have tests to change after this breaking change? probably we're not using hard coded strings in our tests when we create a `Span`?" + }, + { + "prediction": "I think this should be `os.environ.get('GOOGLE_APPLICATION_CREDENTIALS', 'bigquery-credentials.json')`", + "reference": "will this fail if the env variable doesn't exist? Is this the preferred behaviour?" + }, + { + "prediction": "I think this should be `self._random.getReal64()` instead of `0.01 * self._random.getReal64()`.", + "reference": "bad line wrap" + }, + { + "prediction": "This should be `sizeof (rai::uint256_union) + sizeof (rai::uint256_union) + sizeof (bulk_pull_blocks_mode) + sizeof (uint32_t) + sizeof (rai::uint256_union) + sizeof (rai::uint256_union) + sizeof (rai::uint256_union) + sizeof (rai::uint256_union) + sizeof (rai::uint256_union) + sizeof (rai::uint256_union) + sizeof (rai::uint256_union) + sizeof (rai::uint256_union) + sizeof (rai::uint256_union) + sizeof (rai::uint256_union) + sizeof (rai::uint256_union) + sizeof (rai::uint256_union) + sizeof (rai::uint256_union) + sizeof (rai::uint256_union) + sizeof (rai::uint256_union) + sizeof (rai::uint256_union) + sizeof (rai::uint256_union) + sizeof (rai::uint256_union) + sizeof (rai::uint256_union) + sizeof (rai::uint", + "reference": "What does the `8` here represent? Can you give it a name?" + }, + { + "prediction": "I think this should be `os.environ.get(\"MP_API_KEY\")` so that it doesn't raise an error if the environment variable is not set.", + "reference": "`MPRester(os.environ[\"MP_API_KEY\"])` can be left simply as `MPRester()` and it will pick up the API key from the environment. What is the purpose of this file otherwise? Is it better suited for `dev_scripts`, or a test?" + }, + { + "prediction": "Line is too long. [91/80]", + "reference": "Looks like there may be more changes to this file than intended?" + }, + { + "prediction": "I don't think this is the right fix. I think we need to make sure that `accessInfo.GetContent()` returns a `map[string]interface{}` and not a `map[interface{}]interface{}`.", + "reference": "when message type is not expected, contine to next loop instead of return to finish infinite loop" + }, + { + "prediction": "nit: extra blank line", + "reference": "This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards." + }, + { + "prediction": "I don't think we should allow changes to `instanceID`. I think we should only allow changes to `providerID` and `additionalTags`. `instanceID` should be immutable.", + "reference": "instanceID should stay the same for a AWSMachine?" + }, + { + "prediction": "I think this should be `NO_DOWNLOAD=\"true\"`", + "reference": "Since this is a dict don't you want `False` or do we clean that up elsewhere?" + }, + { + "prediction": "I think this should be `127.0.0.1` instead of `localhost`.", + "reference": "what's the reason you had to add the `host` argument to all `get_work` calls?" + }, + { + "prediction": "I don't think this will ever be an instance of `Dataset`, will it?", + "reference": "This will never be a dataset so we can simplify the code here" + }, + { + "prediction": "I think it would be better to have a `copy()` method on `AbstractBlockProcessor` that returns a new instance of `AbstractBlockProcessor` with the same parameters.", + "reference": "This should be moved into the PrivacyBlockProcessor instead of adding the constructor here." + }, + { + "prediction": "I think we should rename this package to `insightstore` instead of `insightfilestore`.", + "reference": "nit: Remove \"insightfilestore\". I think \"insightstore\" is good enough and as I see we are using that name at other places too." + }, + { + "prediction": "I think this should be `@round_count = 3` instead of `@round_count == 3`.", + "reference": "It looks like you've removed `bisect_round_finished` but kept `bisect_round_started`. Seems a little odd that they aren't paired. Not sure if there's anything to do about that though..." + }, + { + "prediction": "I don't think this is necessary. The `throttle_set` is called in the `__init__` of the `Percentage` class, so it should already be set to `-1` at this point.", + "reference": "I'm not sure how to fix the lint and mypy warnings on this line. I could just ignore them, but I feel like the linter should know this exists." + }, + { + "prediction": "I don't think we need to change this to a string.", + "reference": "why remove `Symbol`?" + }, + { + "prediction": "Shouldn't this be `\\u00A3` instead of `\u00a3`?", + "reference": "Why are currency signs considered punctuation? They technically fall under the BMP range for Currency Symbols `\\u20A0-\\u20CF` (covered in `getUnicodeNonBmpRegExp`, which is itself a misnomer)" + }, + { + "prediction": "I don't think it's a good idea to add maintainers here.", + "reference": "You have forgotten a coma `,`" + }, + { + "prediction": "`osp.join(out_dir, osp.basename(img_meta['filename']))` -> `osp.join(out_dir, img_meta['filename'])`", + "reference": "For different datasets, we may want to save the images differently. Sometimes the datasets are categorized into several subfolders, and we want to keep it when saving visualization results, and sometimes we just want to save all images in `out_dir`. An argument may be added to control the behavior." + }, + { + "prediction": "I'm not sure I understand the logic here. If `c1 == c2` and `bb.get(ia) == '\\0'` then `c1 - c2 == 0` and `bb.get(ia) - '\\0' == 0` so `cmp == 0` and `cmp != 0 || bb.get(ia) == '\\0'` should be `0 || 0` which is `0`.", + "reference": "if `other` could have a guaranteed `0` byte in it, this whole `if` could be removed, and above you could just add `|| c2 == '\\0'` to get the same effect?" + }, + { + "prediction": "I don't think we need to make this configurable. I think it should always be `true`.", + "reference": "nit: can this be a primitive value?" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should just return `http.StatusNotFound` if the path doesn't end in `/`.", + "reference": "This maybe not what we want. If `rewrite` occurred before, `r.URL.Path` contains the result and we should use it. Otherwise `rewrite` middleware will disfunction when combining with `browser`." + }, + { + "prediction": "I'm not sure about this change. I think it's better to keep the order of the modules as they are defined in the config file.", + "reference": "Why change this?" + }, + { + "prediction": "`ErrorListener` is deprecated in Symfony 4.4 and removed in Symfony 5.0. We should use `ExceptionListener` instead.", + "reference": "_nitpick_ Isn't it now actually NotLogFakeHttpExceptions**Error**Listener ?" + }, + { + "prediction": "I think this should be `resourceDefinition.ResourceType = resourceType;` instead of `resourceDefinition.AddProperty(\"type\", JsonSchema.CreateStringEnum(resourceType), true);`", + "reference": "Why not just look for the \"type\" property instead of creating a ResourceType property?" + }, + { + "prediction": "I don't think we need to pass the chain ID here.", + "reference": "should use `bc.config.Blockchain.ChainID`" + }, + { + "prediction": "I don't think we need to change the `@see` here.", + "reference": "this doesn't need to know about NativeClient" + }, + { + "prediction": "I don't think we need the backticks here.", + "reference": "I know we discussed if we should add in the resource_name to the hash, and I actually don't think it's required. The violation hash was recently updated (not released) to include the violated rule, so when the next release goes out, user's findings will get updated. The resource name doesn't hurt to have here, but not required." + }, + { + "prediction": "I think this should be `surface->texture->height_from_buffer = surface->texture->height / surface->current.scale;`", + "reference": "The variable name is also misleading imo. The width from the buffer comes from `wl_shm_buffer_get_width` (or a similar EGL thing), which is what gets encoded into `surface->texture->width`." + }, + { + "prediction": "I don't think we need to escape these.", + "reference": "Why are you using these tags to carry these msids?" + }, + { + "prediction": "I don't think we need the +1 here. `strncpy` will null-terminate the string for us.", + "reference": "flb_strdup() should do the work here. note: use Fluent Bit memory wrappers" + }, + { + "prediction": "why do we need this?", + "reference": "This line should be separated from the package declaration by one line as it is not the package description." + }, + { + "prediction": "Why is this change needed?", + "reference": "shadow: declaration of \"err\" shadows declaration at line 410 (from `govet`)" + }, + { + "prediction": "I think it's better to use `github.com/sonm-io/core/proto` instead of `github.com/sonm-io/core/proto`", + "reference": "Maybe next time better to make separate PR?" + }, + { + "prediction": "I don't think we need to raise an error here. We can just return `segm_results` directly.", + "reference": "line 316 also handles this case, need to simplify the logic." + }, + { + "prediction": "I think this should be `errors.New(\"gcsblob.OpenBucket: bucketName is required\")`", + "reference": "We used to have a simple check for bucket and object names, we then decided to remove it and rely on the backend service to check for the name. Is there any reason to add an empty name check now?" + }, + { + "prediction": "I don't think we need to calculate the timeout here. We can just pass `std::chrono::microseconds::max()`.", + "reference": "Line too long" + }, + { + "prediction": "I don't think these should be added to the magic effect list.", + "reference": "This isn't aligned though." + }, + { + "prediction": "`PAAHead does not support test-time augmentation` -> `PAA does not support test-time augmentation`", + "reference": "it is mean -> it means PAAHead does not support test-time augmentation." + }, + { + "prediction": "This import is not used.", + "reference": "@lnielsen-cern thanks. I missed it :(" + }, + { + "prediction": "I think this should be `content-pages` instead of `content-drilldown`.", + "reference": "@tofumatt, has it been changed intentionally? It doesn't seem to be required in IB, plus we haven't had `content-drilldown` before... If it has been changed intentionally, then should we update the `AnalyticsDashboardWidget` component to be use `content-drilldown` instead of `content-pages` as well?" + }, + { + "prediction": "Please remove this empty line.", + "reference": "nit: don't think an extra line is needed here; as retrying is an installed library and should be grouped with the rest of the installed library." + }, + { + "prediction": "I think this should be a `bool`, not a `string`.", + "reference": "This should be a bool" + }, + { + "prediction": "I think this should be `if (swift_typebase && llvm::isa(swift_typebase))`", + "reference": "`if (llvm::dyn_cast_or_null(GetSwiftType(compiler_type).getPointer())` ?" + }, + { + "prediction": "nit: `canaryManifests = append(canaryManifests, canaryConfigMaps, canarySecrets)`", + "reference": "The `generateVariantWorkloadManifests` function below relies on the config manifests specified in Git, but it was passed with the newly created canary's manifests where their name was updated." + }, + { + "prediction": "Why do you need this exception here?", + "reference": "are this docs neccesary ?" + }, + { + "prediction": "I don't think you need to make these final. They are only set in the constructor.", + "reference": "Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC." + }, + { + "prediction": "I don't think you need to do this. If you don't set the loss weight, it will default to 1.0, which is what you want.", + "reference": "This change suppose to resolve issue #2968. `loss_weight` should be of length 2, the second entry is ignored." + }, + { + "prediction": "I think this should be `strings.HasSuffix(base, prefix)` instead of `strings.HasPrefix(base, prefix)`.", + "reference": "Is there an easy way to check for conflict suffix to avoid false positives here?" + }, + { + "prediction": "I think this should be `@context.get_validated_task`, not `@context.get_validated_task`.", + "reference": "`apply_prep.run_task` also seems like it can just use `@context.run_task`" + }, + { + "prediction": "I don't think this is the right fix. I think we should be able to call `autoFocus` without waiting for all sections to load.", + "reference": "do you have any idea on how to fix it?" + }, + { + "prediction": "I think it would be good to add a test for `GCSTarget` as well, to make sure that the `delete_on_close` flag is respected.", + "reference": "You don't need to fix this (you've done so many iterations). But for next time, you can make this into a docstring so it'll have a nicer descriptive name when the tests are running." + }, + { + "prediction": "I think this should be `time.Now().Before(eni.ExpiresAt)`.", + "reference": "When does 'expiresAt' change? Do you need this?" + }, + { + "prediction": "This should be a `const Outfit* const`", + "reference": "There are enums for genders + `PLAYERSEX_LAST`." + }, + { + "prediction": "I think this should be `int64(dataCost) * int64(tt.dataPrice)`", + "reference": "Should this use the constants as well? Or intentionally covering the fact that the constants may change" + }, + { + "prediction": "I think this should be `return self._size if self._size >= 0 else len(self.best)`", + "reference": "The case of a negative size (= keep all elements) was not handled in this function." + }, + { + "prediction": "I think this should be `system.enableInfiniteTimeout` instead of `worker.enableInfiniteTimeout`", + "reference": "I think we should keep this dynamic config knob for operations purpose." + }, + { + "prediction": "I'm not sure if this is a bug or not, but I think it should be `(3, 5)` instead of `(2, 4)`.", + "reference": "Was this intentional? Perhaps this could be replaced with another way to check the offsets?" + }, + { + "prediction": "Should this be `ArtifactBuckets`?", + "reference": "the buckets are created via the stackset, customers don't need to provide them" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to be the only way to ensure that the `qt` parameter is always included in the request.", + "reference": "This doesn't have the same behavior as before. Maybe you want `reverse_merge` (and it either just works or we implement it on `Blacklight::Solr::Request`)" + }, + { + "prediction": "I don't think we need to export the path here, since we're already doing it in the `before_install` section.", + "reference": "This should be ` /$(ghc_find #{config[:ghc]})/ ` instead of ` /#{ghc_version}/ `, I think." + }, + { + "prediction": "I think this should be `more_vert` for both Android and Chrome.", + "reference": "We should deprecate this at some point." + }, + { + "prediction": "I think the default value of `center_sampling` should be `True`.", + "reference": "Move these two arguments before `loss_cls`." + }, + { + "prediction": "I think this should be `i = serialNumber + mathrand.Int63n(100000000000000000)`", + "reference": "[Super NIT]: i := serialNumber if i == 0 { i = mathrand.Int63n(...) }" + }, + { + "prediction": "I think this should be `--tool-format` instead of `--tool` to be consistent with the rest of the options.", + "reference": "-f short form here collided with --force. :)" + }, + { + "prediction": "Why did you remove this?", + "reference": "I think it is better to describe in the release note that `rerender()` was removed." + }, + { + "prediction": "I don't think we need to cover this.", + "reference": "We could also test this easily with `runpy.run_module`, what do you think?" + }, + { + "prediction": "I think this should be `v.Type().ConvertibleTo(reflect.TypeOf(val))`", + "reference": "Is it OK to fall through if it's not assignable? I was kind of surprised when the tests passed. Maybe one of the options below ends up working? For the new tests, this panics because `**not assignable uuid.UUID to []uint8**`. `uuid.UUID` is an array, not a slice." + }, + { + "prediction": "I think we can remove `porcelainAPI` and `retrievalAPI` from this struct.", + "reference": "I know this is after the fact but imo blockAPI should be blockMiningAPI." + }, + { + "prediction": "I don't think we need this constant. We can use `self::SYSTEM_ATTRIBUTE_PREFIX` directly.", + "reference": "it's just a pattern as it was. SystemAttributeCode should have it's own definition and validate by it" + }, + { + "prediction": "remove this file?", + "reference": "Similar to the code block when we use prefix, maybe we can unify them to base?" + }, + { + "prediction": "I think it's better to use `schedulerField.Child(\"duration\")` instead of `schedulerField.Child(\"duration\").Child(\"duration\")`", + "reference": "I think `Duration` is useful for this action and we shouldn't ignore it." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it makes sense to return an error if the stream has already been closed.", + "reference": "Everything below here can be replaced with `return s.err, len(p) - len(s.dataForWriting)`." + }, + { + "prediction": "I think this should be `KOKKOS_ENABLE_IMPL_DESUL_ATOMICS && KOKKOS_ENABLE_HIP_ATOMICS`", + "reference": "Again, we can also guard `g_host_hip_lock_arrays.atomic`, can't we?" + }, + { + "prediction": "I don't think we need to pass `true` here.", + "reference": "Variable name should start from lowercase latter" + }, + { + "prediction": "I'm not sure why this needs to be 40 seconds. I think 20 seconds should be enough.", + "reference": "Why has this timeout doubled?" + }, + { + "prediction": "I'm not sure about this change. I think we should keep the default timeout of 30s.", + "reference": "Should IptablesPostWriteCheckIntervalSecs be set back to its previous smaller value, if use of the iptables lock is disabled?" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think it should be `self._tab.key_press(Qt.Key_Enter, modifier=Qt.NoModifier)` or `self._tab.key_press(Qt.Key_Enter, modifier=Qt.ControlModifier)` depending on whether the focused element is an input field or not.", + "reference": "You're missing a `return` here, but I'll add it :smile:" + }, + { + "prediction": "I think this should be `gles2_get_texture_in_context(wlr_texture);`", + "reference": "Can you try adding back this assertion? I'd like to assert that the texture has been created in the same context as the renderer." + }, + { + "prediction": "I'm not sure why this is necessary. The `format` method should be able to handle unicode strings just fine.", + "reference": "This won't work with Python 3 because it will already be a string. In that case we need to use `decode_header` from utils." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in `Mongoid::Criteria::Queryable::Extensions::ClassMethods#where`.", + "reference": "Why is the respond_to check here?" + }, + { + "prediction": "`$char === '\\\\'` should be `$char === '\\\\' || ctype_alnum($char)`", + "reference": "@orklah are you sure it's the same as `$chars[$i]`? It looks like `$i` is changed above, after `$char` assignment." + }, + { + "prediction": "why nullptr here?", + "reference": "I have a question? How do I construct a indexManager for testcase?" + }, + { + "prediction": "I'm not sure this is the right thing to do here. If the plugin is not loaded, we should return an error.", + "reference": "These checks aren't needed. See pluginmgr.c : opae_plugin_mgr_load_dflt_plugins( )." + }, + { + "prediction": "I don't think this change is correct. If the `q` parameter is not set, it should return `true`.", + "reference": "Please take a care about prefixing." + }, + { + "prediction": "I think it would be better to rename this method to `getOrCreateAccountForSender` or something like that.", + "reference": "this line doesn't match what the rest says" + }, + { + "prediction": "Why do we need `linux,android` here?", + "reference": "Since it's not working for linux, maybe leave the !linux in there as well?" + }, + { + "prediction": "I think this should be `if len(v) == 0 {` instead of `if v == \"\" {` because `v` is a `string`.", + "reference": "Should we remove the key-value pair entirely? Same for workflows in general. We have a \"sourceExists\" method that checks if a key is there if I remember correctly." + }, + { + "prediction": "I think this should be `getModificationDateFieldName()` instead of `modificationDateFieldName`", + "reference": "Unrelated bug fix" + }, + { + "prediction": "I don't think we need to concatenate the name and version here. We can just pass it as an array of strings.", + "reference": "We probably want to let the translation library handle the string replacement for these as well." + }, + { + "prediction": "I think we can remove the `getDBFlags` function now.", + "reference": "should combine these 2 list (list_gossip and list_db) into just one list command, and show the discrepancy between the 2 if any." + }, + { + "prediction": "Metrics/MethodLength: Method has too many lines. [31/25]", + "reference": "What do you think about prefixing the Policy method names with `can_`?" + }, + { + "prediction": "I'm not sure if this change is intentional, but it seems like it should be `AWS_CREDENTIAL_RESPONSE_EXPIRATION` instead of `AWS_HTTP_RESPONSE_EXPIRATION`.", + "reference": "Based on the docs, credential process can return a key `SessionToken`" + }, + { + "prediction": "I think this should be `today.setHours(0, 0, 0, 0);`", + "reference": "I think this if should be removed (see issue)" + }, + { + "prediction": "nit: I think this should be `github.com/projectcalico/libcalico-go/lib/backend/api`", + "reference": "I would avoid importing `felix/ipsets` package because this package is the windows equivalent and should be at the same level of `felix/ipsets`. We could add linux specific dependencies into `felix/ipsets` later and it will break Windows build." + }, + { + "prediction": "This should be `Tuple[str, str]`.", + "reference": "nitpick: Please move this down to the other imports, as it's a Python stdlib import." + }, + { + "prediction": "I don't think we need to link to the how-to guide here.", + "reference": "\"for getting started guides\" reads a bit weird, like it's missing punctuation. Maybe just \"for a tutorial\"?" + }, + { + "prediction": "I think this should be `$useCaptcha = false` instead of `$uc = false`", + "reference": "This looks like a dead parameter -- maybe a copy and paste error. If it's truly unused, maybe you can open a separate PR to simply delete it, and then it's one less detail to worry about here." + }, + { + "prediction": "I think we should use `int64` instead of `int` and `uint64` instead of `uint`.", + "reference": "Nit: Should we add support for `int` and `uint` in the `values.New()` function? That would allow us to to handle all of these types in one case. Maybe there's a good reason why we don't do that already, but I'm not sure what it is." + }, + { + "prediction": "I'm not sure about this change. I think it's better to keep the class final.", + "reference": "if you are not dealing with cache now, please revert these changes. On their own they make little sense" + }, + { + "prediction": "Please remove this empty line.", + "reference": "Wearing my extra-douche-bag hat I would say not spaces on a blank line. Maybe at some point we could have some automated process remove these things. For now I would not bother changing it." + }, + { + "prediction": "This class is not needed. You can just use `new Object()` as the event object.", + "reference": "I think it would be better to use an `ItemUpdatedEvent` like for the \"prefer streaming\" preference. We already have a ton of events that need to be handled in all list fragments that just do the same everywhere. I think we could even remove some of the existing events in the future." + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "I think we have to manually write a down for this migration." + }, + { + "prediction": "I don't think we need to check this here. We can check this in `_InternalFrame.attach_default_index` and raise an error there.", + "reference": "I don't think we still need this check, but I'd leave it as an assertion for now." + }, + { + "prediction": "I'm not sure this is the best way to do this, but it works for now.", + "reference": "Since this may be the case, wondering if we should call the param `updated_at_i` or something so that we don't run into a problem distinguishing them down the road?" + }, + { + "prediction": "I think this should be `appExe = Path.Combine(workingDir, appExe);` instead of `appExe = Path.Join(workingDir, appExe);`", + "reference": "wondering why we need to join the paths here; seems evt.commandLine only takes whatever appExe is" + }, + { + "prediction": "`encodeServiceName` is not used, remove it.", + "reference": "1.not format code 2.failed but still continue? 3.\"UTF-8\" can changed to java.nio.charset.StandardCharsets.UTF_8.name()" + }, + { + "prediction": "This import is unused.", + "reference": "I'm wondering if we should add this to a `utils` module in `astroid`. Porting the util to `pylint` doesn't make sense as we would need to duplicate the globals that are being used in the function, but importing from `brain` also feels weird. @Pierre-Sassoulas Do you have an opinion?" + }, + { + "prediction": "I think this should be `if (_corruptedRequest && !SocketInput.RemoteIntakeFin)` so that we don't call `ProduceEnd` if the remote side has already closed the connection.", + "reference": "This seems different than what we do for corrupted request headers. I would like to determine the correct behavior and consolidate this logic." + }, + { + "prediction": "I think this should be `backend.get('instanceGroup')`", + "reference": "Please make the change in the CAI inventory, rather than changing the scanner." + }, + { + "prediction": "I don't think this should be abstract.", + "reference": "adding this `abstract` is a breaking API change. Even though I agree it makes perfect sense to have it, we can't break this API until PMD 7.0.0. We should revert this particular change. We could make a reminder ticket like we did with #463 for 6.0.0" + }, + { + "prediction": "I think we can remove the `it_behaves_like 'a Plan with countable subscriptions'` and `it_behaves_like 'a Plan for public listing'` from this file.", + "reference": "This is following the existing convention, but I'm not sure the convention is a good one. I think it would be better to have one shared example group: - It means we don't need to add new example groups twice every time. - If the shared example group looks large, that makes it more obvious that our team models have too much shared behavior. I don't want to do anything about this right now (I'm pretty sure I can wipe out this shared example group when I change team plans), but it's good to keep in mind." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the right thing to do for now. We don't want to limit the number of connections from IPv4 addresses, because the address space isn't as big as IPv6 /64, and we don't want to limit the number of connections from IPv6 /64 addresses, because the address space is too big.", + "reference": "I do not think we need to do a source code change to handle this. We could set the subnetwork to default to /32 (/128 for ipv6 ipv4-mapped)" + }, + { + "prediction": "\"Remove one cookie from remote\" -> \"Remove a cookie from a remote\"", + "reference": "It looks good overall! The only issue I have is that the description string is now duplicated twice right? Once in the struct and once in the parameter string? Maybe let's pass the struct to the command so that `ostree_option_context_parse` can set it as the summary? Similar to what we do in rpm-ostree." + }, + { + "prediction": "I don't think we need to make this public.", + "reference": "This states very clearly that this is a derivative of Chrome and not Chromium. Do we need to extract an abstract `ChromiumCommandExecutor` and have both Edge and Chrome derive from that?" + }, + { + "prediction": "I don't think we need to check for `type0.getType() == java.lang.Enum.class` because `type0.getType().isEnum()` will return `false` if `type0.getType()` is `java.lang.Enum.class`.", + "reference": "it seems to me, the issue lies on `isEnum()` itself, returning false for something that is an enum. I'd rather change it there than here." + }, + { + "prediction": "I think it would be better to have a `QuteSchemeHandler.register_handler(name, function)` method, so that we don't have to use a decorator at all.", + "reference": "Please use `{}` instead of `dict()`" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "I have concerns about using this in more places before #3278 - I'll take a look at that again shortly." + }, + { + "prediction": "Why do we need to set `TxIndex` to 1 here?", + "reference": "new field needs to be asserted" + }, + { + "prediction": "I think this should be `self->logIdToSend_ + 1`", + "reference": "when send log failed, why update the last sent log id?" + }, + { + "prediction": "I think this should be `prepend` instead of `append`.", + "reference": "what was the problem with the previous order? `prepend` comes conceptually before `append`, i.e. `insert before` should be before `insert after`, I think" + }, + { + "prediction": "I think this should be a `map[string]interface{}` so that we can store any type of metadata.", + "reference": "Why is this necessary? Could you provide some context?" + }, + { + "prediction": "I don't think this is necessary. The default charset is already UTF-8.", + "reference": "Is there a recommended quote style for attributes? I see single and double here, double further down." + }, + { + "prediction": "I think this should be `Eventually(returned).Should(BeClosed())` instead of `Eventually(returned).ShouldNot(BeClosed())`", + "reference": "Please use an atomic bool." + }, + { + "prediction": "I think this should be in `WebHelpers.cs` in the `Datadog.Trace.ClrProfiler.Managed` project.", + "reference": "Consider naming this class `SpanExtensions` to follow C# conventions." + }, + { + "prediction": "I don't think we should remove this. It's useful to know which app domain we're running in.", + "reference": "FYI @lucaspimentel and @colin-higgins since you have already approved, I wanted to point out this required change. By fixing `FrameworkDescription` to use the correct logger, it created a cycle between these two static constructors, so I'm removing this log line and delaying it to when it's actually constructed later in the Tracer. Let me know if you find that acceptable or have any suggestions." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Ah, so we are going to need to update node/host files for this to work?" + }, + { + "prediction": "I don't think we need to log the creation of the container.", + "reference": "This code is new and not tested well. While we may drop the log level before we ship 4.0, right now this is extremely helpful to users." + }, + { + "prediction": "Redundant `self` detected.", + "reference": "used named path (`proposals_path`) instead?" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "Am I misreading something, or is there a mismatched parenthesis here? Please let me know whether or not this is cause for concern -- just wanted to be totally sure before merging, since I can't test this from here. Thanks!" + }, + { + "prediction": "I think this should be `yarpcerrors.InvalidArgumentErrorf` instead of `yarpcerrors.InternalErrorf`.", + "reference": "Might we want a hook to allow emitting metrics or logs in the case of a permitted empty service header response (or similar UpdateSpanWithErr on empty service header in response if strict enforcement is desired by the caller)?" + }, + { + "prediction": "I think this should be `kwargs[\"protocol\"] = kwargs.get(\"protocol\", \"https\")`", + "reference": "if using dict.get, this could just be `kwargs.get('protocol', 'https')`" + }, + { + "prediction": "I think this should be `getGrpcStreamingApiMethodExampleName` instead of `getGrpcStreamingApiMethodName`.", + "reference": "Add docs to the new methods here" + }, + { + "prediction": "Why is this always true?", + "reference": "what does it mean enabled?" + }, + { + "prediction": "I think this should be `db.execSQL(\"PRAGMA rekey = '\" + newKey + \"'\");`", + "reference": "Getting an error when calling with db.execSQL (in sqlcipher 4.3.0, pragma returns ok)." + }, + { + "prediction": "Please add a space between `ctxUser.DisplayName()` and `ctx.Tr(\"dashboard\")`", + "reference": "Maybe we could remove `\" \" + ctx.Tr(\"dashboard\")` completely?" + }, + { + "prediction": "Please remove the extra blank line here.", + "reference": "Simple Storage **Service**" + }, + { + "prediction": "I'm not sure if this is the right place to put this, but I think it would be nice to have a `jsonHandler3` that takes a `yarpc.Request` instead of a `context.Context` and a `reqBody`.", + "reference": "Let's add some assertions here to ensure we don't panic. Length of results. Conditionally cast second result to error." + }, + { + "prediction": "I think this should be `TimeSpan.FromMinutes(2)` to match the default http.sys connectionTimeout.", + "reference": "Where did we take this default from?" + }, + { + "prediction": "I think it would be better to use `compareStartDate` and `compareEndDate` instead of `startDate` and `endDate`.", + "reference": "Let's move these down to be after all required arguments rather than in between." + }, + { + "prediction": "I think this should be `if (_sharedStringMap != null && _sharedStringMap.Count > 0) { _sharedStringMap.Clear(); }`", + "reference": "Should we just null the Map and let the GC handle the memory? Clearing just removes items, but not capacity, so this would leave some memory on the table." + }, + { + "prediction": "I think we can remove this line.", + "reference": "did you mean to delete this line?" + }, + { + "prediction": "This should be removed.", + "reference": "Should we use logger instead?" + }, + { + "prediction": "nitpick: `expect(analytics?).to be true` is the same as `expect(analytics?).to be_truthy`", + "reference": "I think it would be preferred to do `expect(helper).to be_analytics`" + }, + { + "prediction": "I don't think we need to add `pd.Index` here. `loc` should only accept `str`, `tuple`, `list` and `slice`. `pd.Index` can be converted to `list` or `tuple` before passing to `loc`.", + "reference": "Actually, I think it's okay to just change to `if isinstance(key, (str)) or is_list_like(key):` and `key = list(key) if is_list_like(key) else key` for simplicity for now." + }, + { + "prediction": "Why do we need to set this to empty string?", + "reference": "If there any other tests, I would make it optional there also." + }, + { + "prediction": "This should be `match '/my-accounts' => 'high_voltage/pages#show', as: :my_accounts, id: 'my-accounts'`", + "reference": "This can be removed too, right?" + }, + { + "prediction": "I think this should be `account.getTransportUris().get(0)`", + "reference": "If you're going to allow people to specify multiple SMTP servers, you should also properly export/import them." + }, + { + "prediction": "Shouldn't this be `runtime.dotnet.connections.queue_length`?", + "reference": "nit: Can we prefix these variables with `AspNetCore`?" + }, + { + "prediction": "I think this should be `yaml::conversion.yaml` instead of `yaml::conversion`", + "reference": "Can this also include a quick test for transpiling by name?" + }, + { + "prediction": "I'm not sure about this. I think we should keep the `SessionStatsDeprecated` struct for now, and add a new `SessionStats` struct for the new format. This way we can still support the old format for a while.", + "reference": "This TODO can be removed" + }, + { + "prediction": "I think this should be `string tabAccessibilityIdentifier = null`", + "reference": "can we make tabAccessibilityIdentifier = null as default?" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should return an error from `initProvider` and let the caller decide what to do with it.", + "reference": "Should we print this error?" + }, + { + "prediction": "`int(multi_scores.size(1) - 1)` -> `multi_scores.size(1) - 1`", + "reference": "For which reason do we need to convert this to int here?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it is. If the freezer cgroup isn't supported, we don't want to return an error, because that will cause the container to fail to start. Instead, we want to return `nil` so that the container starts normally.", + "reference": "FWIW, wondering if the error is interesting here (I actually arrived at this code initially to change `supportsFreezer()` to return a `bool`" + }, + { + "prediction": "I'm not sure about this change. I think it's better to keep the test plan info.", + "reference": "Does this still need to be a partial? is the intention down the line to move back towards a conditionally different title?" + }, + { + "prediction": "I think this is the only thing that needs to be updated.", + "reference": "seems like `RegistryURL` is missing? Same for a few other places that create `archer.Environment` below." + }, + { + "prediction": "Please remove unused import.", + "reference": "Are these imports needed?" + }, + { + "prediction": "I think it would be better to use `if (target.actualNode.type === 'color') { return; }` instead of `if (target.actualNode.type === 'text') { return; }`", + "reference": "I think you can remove the `(isIE11 ? it.skip : it)(` above, if you're going to skip the test this way." + }, + { + "prediction": "I think this should be `Long.reverseBytes(actualChecksumIn)`.", + "reference": "IMO we should instead fix the above call to do `long actualChecksumIn = Long.reverseBytes(in.readLong());` to get the actual checksum value? This way the below error message would also be correct?" + }, + { + "prediction": "Shouldn't this be `DeleteFiles(gopts, repo, removePacksFirst, restic.IndexFile)`?", + "reference": "I think we also need something similar for `rebuild-index`?" + }, + { + "prediction": "I think this should be 50051.", + "reference": "I think convention is snake case for import naming?" + }, + { + "prediction": "I think it's better to use `tableInfo.getPrimaryKey().getColumns()` instead of `tableInfo.getPrimaryKey().getIndexColumns()`.", + "reference": "i think haspk is false?" + }, + { + "prediction": "I think this should be `surefire_dir` to be consistent with the other flags.", + "reference": "you should add this to the cover command too (but let's have a more general convo about whether it's a flag or config option)" + }, + { + "prediction": "I think we can remove the `&metrics.ClientConfig{}` here and just pass `nil`.", + "reference": "instead of passing in pointer to empty struct, we should make it optional and support passing nil and use default cfg if it is nil." + }, + { + "prediction": "I'm not sure this is the right thing to do, but I think it's better than before.", + "reference": "A fair bit faster, although still not great, hence also adding a hashkey." + }, + { + "prediction": "I'm not sure if this is the right place to put this, but I think it would be nice to have a link to the user's profile page in the top right corner of the trail page.", + "reference": "If we're going to leave this in here, how about we at least pull it into partial?" + }, + { + "prediction": "Why is this timeout increased?", + "reference": "This `context` is used correctly, there is nothing left TO DO." + }, + { + "prediction": "I'm not sure this is the right thing to do here. I think we should be passing the `result` object to the callback and let the user decide what they want to do with it.", + "reference": "If `docs` is an empty array there will be an error" + }, + { + "prediction": "I think this should be `!strings.HasPrefix(host, \"quic://\")` instead of `!strings.HasPrefix(host, \"quic:\")`", + "reference": "Is it really necessary to have the user specify this, or can the reverse proxy infer QUIC from the upstream's Alt-Svc headers?" + }, + { + "prediction": "Why is this commented out?", + "reference": "just remove the entire variable." + }, + { + "prediction": "I think this should be `File.expand_path(File.join(pwd, moduledir))`", + "reference": "Maybe we should put that in the option description?" + }, + { + "prediction": "I don't think we need to change this to an `Optional`. The `keyFilePath` field is already an `Optional`, so we don't need to wrap it in another `Optional`.", + "reference": "Why do we need to make this optional? Isn't the idea of the builder that if you don't need this value you just don't call the `keyFilePath ` method?" + }, + { + "prediction": "I think this should be `MetricsConfig.forTable(table.schema(), table.properties())`", + "reference": "Shall we do the same for ORC and Avro?" + }, + { + "prediction": "Why is this change needed?", + "reference": "Should be a space between line" + }, + { + "prediction": "I think this should be `SecureRandom.GetBytes(bytes, 0, bytes.Length);`", + "reference": "if not behind interface then equally we can use SecureRandom.GetBytes directly, otherwise let us push it behind ISecureRandom so we can test with this class wherever used" + }, + { + "prediction": "I think this should be `video_tutorial.tile` instead of `video_tutorial.card`", + "reference": "Probably will undo this change for now, as I'm just targeting Weekly Iteration in this PR." + }, + { + "prediction": "I don't think we need this anymore.", + "reference": "Unused parameter warning? How comes we did not catch that before? In any case please open another PR for this." + }, + { + "prediction": "`use_group_of` -> `group_of`", + "reference": "I recommend move all openimage related logic to a new function" + }, + { + "prediction": "I'm not sure this is the right place to put this. I think it should be in the `CgroupManager` struct.", + "reference": "We shouldn't have a bool for this. If there is a path passed, then we use it. Resource may or may not be empty." + }, + { + "prediction": "I'm not sure about this, but I think it would be better to use `t` instead of `raw` here.", + "reference": "I like how you used the count on the translate call to handle this." + }, + { + "prediction": "Shouldn't this be `if ($handler->hasDismax() || $handler->hasExtendedDismax())`?", + "reference": "Do we need to do this from the outside, or is there a spot in the handler code where we can do this automatically? (I haven't studied it closely yet... just wondering if you've already thought it through or if it's worth taking a closer look)." + }, + { + "prediction": "Please remove this file.", + "reference": "[Checkstyle] INFO: Using the '._' form of import should be avoided - java.util._." + }, + { + "prediction": "I don't think we need to override the default cache/storage/permission backends here.", + "reference": "So, why everything is in memory but the permission backend?" + }, + { + "prediction": "I don't think we need to copy the list here. The `allowedExtensions` parameter is only used in the `showBrowseStep` method, which doesn't modify the list.", + "reference": "Are you sure it should be null and not an empty List?" + }, + { + "prediction": "I think this should be an `ITaskItem[]` instead of a `string[]`.", + "reference": "Unfortunately I think the assumption of \"empty\" means the default dependency section is not correct. For a project.json file the default dependencies section is a shared section between all the different target frameworks and our TargetGroup being empty may map to many different target frameworks so they aren't really equated." + }, + { + "prediction": "I think these should be `not-localhost` and `not-value` instead of `localhost` and `value`.", + "reference": "This test was verifying the wrong thing." + }, + { + "prediction": "I think this should be `util.buildMuon('brave', buildConfig, options)` so that we can pass in the buildConfig and options.", + "reference": "pls pr a name change fro muon here too separately." + }, + { + "prediction": "I think this should be `opts.spinner.Stop(\"Error!\")`", + "reference": "nit: we can use `defer opts.spinner.Stop(\"Error!\")` after l.180 to make it slightly neater" + }, + { + "prediction": "I'm not sure this is the right place to set this flag. I think it should be set in `make_executable()`, which is called by `make_executable_from_file()` and `make_executable_from_memory()`. I think it should be set in `make_executable_from_memory()` because that's the only place that calls `make_executable()` with a non-`NULL` `vmlist`.", + "reference": "This is declared in the wrong block" + }, + { + "prediction": "`msg.Header:{%v},msg.Route:{%v}` -> `msg.Header:{%+v},msg.Route:{%+v}`", + "reference": "In fact it would be useful for debug, i prefer combine them into one debug level log." + }, + { + "prediction": "I don't think we need to add \"per session\" here.", + "reference": "We would need to localize them eventually too, just FYI" + }, + { + "prediction": "I think this should be `proto->set_type(type());`", + "reference": "It looks like the proto code needs to change the function name from set_name to set_type to be consistent." + }, + { + "prediction": "I don't think we need to generate mocks for this package.", + "reference": "I think we can avoid using this pattern for this use case." + }, + { + "prediction": "I think this should be `#if !defined(__ANDROID__) && !defined(_WIN32)`", + "reference": "Could you please change this to `#ifndef __linux__`? That's when we use our own implementation instead of `posix_spawnp`." + }, + { + "prediction": "I don't think we need to filter out the slots that already have a session. We can just check if the count is less than `maxSessionCount` and then check if there is a free slot that supports the capability.", + "reference": "Nit: put the `&&` on the previous line so that a reader knows that there's more to the statement at a casual glance." + }, + { + "prediction": "I think this should be `string(libkbfs.TLFPathType(t))`", + "reference": "Technically the \"right\" variables to use would be the ones in `libgit/autogit_node_wrappers.go\", which define how the tlf types map to subdirs for autogit specifically. (They would have to be exported.) But this is fine too I guess, just a little dirtier." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "Should there be a template or something associated with this email? Right now it's identical to `notification_for_approver`" + }, + { + "prediction": "I think we should use `EntityManagerInterface` instead of `EntityManager` here.", + "reference": "i hope there is some extension in phpstan for this" + }, + { + "prediction": "I think this should be `if (sep <= 0) return 0;`", + "reference": "We don't store empty dictionary entries anymore: they bring no benefits, only trouble." + }, + { + "prediction": "I think this should be `opts_.scoped_enums && opts_.g_cpp_std >= cpp::CPP_STD_17 && IsEnum(type);`", + "reference": "Optional: This function is C++ specific and could be declared as `static`." + }, + { + "prediction": "I think this should be `getRoles(String domainName, Boolean members, Optional tagKey, Optional tagValue)`", + "reference": "we can't remove functions as that would introduce backward compatibility issues in our java client. So we should also have a function with the original arguments: ` public Roles getRoles(String domainName, Boolean members) { return getRoles(domainName, members, null, null); } ` For the Go client we don't have a wrapper so no option but to update your client code as necessary, but for java we have the wrapper thus we always maintain backward compatibility" + }, + { + "prediction": "I think this should be `warn_deprecation` instead of `warn`.", + "reference": "I'd recommend keeping this in `warn_deprecation` and not adding an override of `warn`." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "I think we should use a `blitz` bin instead" + }, + { + "prediction": "I think this should be `if dataset._virtual_kdims:`", + "reference": "Why not make the ``derived_vdims`` flag (or similar, ``validate_vdims`` maybe?) an explicit argument to ``validate``?" + }, + { + "prediction": "I think this should be `if spec.IsPureVolume() && spec.IsSnapshot() {` so that we don't try to create snapshots for non-Pure volumes.", + "reference": "was it not possible to do this at the filter or porx driver layer? We typically try to avoid driver-specific things in the SDK layer" + }, + { + "prediction": "Please remove the extra space between `*` and `Copyright`.", + "reference": "please update the year. it can be setup in intellij template." + }, + { + "prediction": "Shouldn't this be `passSlf4j(\"log.debug(null);\");`?", + "reference": "what's the use-case for this?" + }, + { + "prediction": "I think this should be `isinstance(as_index, bool)`, not `not isinstance(as_index, bool)`.", + "reference": "nit: `as_index must be an boolean` -> `as_index must be a boolean`" + }, + { + "prediction": "I think this should be `public function upgrade($currentVersion, $newVersion, ConnectionInterface $con = null);`", + "reference": "What is the goal of that method ? And what are `$currentVersion` and `$newVersion` ? Are they Thelia or Module version ? :)" + }, + { + "prediction": "I don't think we need this.", + "reference": "Is there an advantage to this vs setting `this.version` in the constructor? Cleaner this way, at the top?" + }, + { + "prediction": "I think this should be `trim()` instead of `trim()`.", + "reference": "Fix for URISyntaxException." + }, + { + "prediction": "I think this should be `if routeUpd.Dst == nil || routeUpd.Gw == nil {`", + "reference": "Would be good to UT this case" + }, + { + "prediction": "Why do we need to disable these rules?", + "reference": "Why we need to add this?" + }, + { + "prediction": "Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
", + "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." + }, + { + "prediction": "I think this should be `int64` to be consistent with the rest of the API.", + "reference": "This is ok to change since I believe that these were added just in main and not in public release." + }, + { + "prediction": "I think this should be `pubsubServiceAccount` instead of `pubsubServiceAccountName`.", + "reference": "Not needed in this PR, just want to make sure people think about this (maybe make an issue)? This is a lot of strings in a row. It will be hard/impossible for someone reading the code to see that everything is in the correct position. I recommend creating a struct instead of passing seven strings in a row. A similar problem exists on most of the `MakeFoo(...)` style methods in this change." + }, + { + "prediction": "I think this should be `if (_run.ConfigurationNotifications != null && _run.ConfigurationNotifications.Count > 0) { _issueLogJsonWriter.WriteConfigurationNotifications(_run.ConfigurationNotifications); }`", + "reference": "_jaw drops_ I would have sworn I wrote those lines. Good catch." + }, + { + "prediction": "I'm not sure this is the right place to clear the memoized fns. I think it should be done in the axe._cache.clear() method.", + "reference": "This needs to be tested." + }, + { + "prediction": "Line is too long. [85/80]
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Use the new Ruby 1.9 hash syntax.
Space inside { missing.
Space inside } missing.", + "reference": "I believe you're missing the comparison after 'be'" + }, + { + "prediction": "I don't think this is correct. If the key is deleted, we should return ErrNotExist. If the key is not found, we should return ErrNotExist. If the key is found, we should return the value. If the key is found, but the value is deleted, we should return ErrNotExist. If the key is found, but the value is deleted, but the key is not found in the cache, we should return ErrNotExist. If the key is found, but the value is deleted, but the key is not found in the cache, but the key is found in the dao, we should return the value. If the key is found, but the value is deleted, but the key is not found in the cache, but the key is found in the dao, but the value is deleted, we should return ErrNotExist. If the key is found, but the value is deleted, but the key is not found in the cache, but the key is found in the dao, but the value is deleted, but the key is not found in the dao, we should return ErrNotExist. If the key is found, but the value is deleted, but the key is not found in the cache, but the key is found in the dao, but", + "reference": "move 103~105 to in front of 97?" + }, + { + "prediction": "This import is not used.", + "reference": "Lots of unnecessary imports left in this file." + }, + { + "prediction": "I don't think we need to do this. We can just use `descriptor->GetClass() == DescriptorClass::InlineUniform` here.", + "reference": "Does this actually produce different code?" + }, + { + "prediction": "I think this should be `node.getAttribute('onfocus')` instead of `node.getAttribute('onFocus')`.", + "reference": "This should account for whitespace. Simply putting `.trim()` on the attribute value should do." + }, + { + "prediction": "nit: I think it would be nice to have a `routetable.BlackholeTarget` and `routetable.NoEncapTarget` instead of creating them every time.", + "reference": "I don't think we need these. Simpler just to put `routetable.TargetType...` inline below." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "Nested if statement. You can merge both statements nested together to create one" + }, + { + "prediction": "Shouldn't this be `Integer.parseInt(jdkVersion.substring(0,jdkVersion.indexOf('.'))) >= 10` ?", + "reference": "Nitpick: add a space after the comma. Also, we should consider that the format of the version could change in the future so we could get something that is not a parsable integer." + }, + { + "prediction": "`EXPECT_EQ(ResultCode::SUCCESSED, engine->get(\"key\", &result));` -> `ASSERT_EQ(ResultCode::SUCCESSED, engine->get(\"key\", &result));`", + "reference": "For your reference in future, I sugguest to use the `ASSERT_*` family." + }, + { + "prediction": "This should be `#include `.", + "reference": "no need to import `fmt/format.h` here since the `KimInit` class is derived from `Pointers`. Any class derived from `Pointers` can assumed that `lmptype.h`, `mpi.h`, `cstddef`, `cstdio`, `string`, `utils.h` and `fmt/format.h` are already included through `pointers.h`." + }, + { + "prediction": "This import is not used. Please remove it.", + "reference": "Can we have prefix of `OPENEBS_IO` e.g.: `OPENEBS_IO_INSTANCE_NAME`" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I don't think we need to implement this method for `folderBranchOps`.", + "reference": "Might as well fix these bare returns by making them `return errors.New(...` directly." + }, + { + "prediction": "I think this should be `org.hyperledger.besu.datatypes.Hash.EMPTY`", + "reference": "we can use import here" + }, + { + "prediction": "I'm not sure why this was removed, but I think it should be added back in.", + "reference": "thx for removing these" + }, + { + "prediction": "I think this should be an `IOException` instead of a `RuntimeException`.", + "reference": "I snuck this one in as well as checkstyle crashing (on files from resources) caused an unfinished xml to be written, and it wasn't obvious where that XML was" + }, + { + "prediction": "Is this a typo? Should it be `testMachineType` instead of `testMachineType2`?", + "reference": "How is this different than \"good case\"?" + }, + { + "prediction": "I don't think we should change the API here. I think it's better to keep it as `services []string` so that we can support multiple services in the future.", + "reference": "the last parameter name should be `serviceName` as is in the implementation" + }, + { + "prediction": "I don't understand why this change is needed.", + "reference": "@ftomassetti - okay, this is a little meh." + }, + { + "prediction": "I think this should be `errors.New(\"os: not implemented\")`", + "reference": "Note, changed initial capitalisation of this for consistency. Can do it the other way around too if that'd be better. :wink:" + }, + { + "prediction": "I think we can remove the `typeof window === \"object\" ? window : this` and just use `window` here.", + "reference": "hey, aren't we supposed to be passing in two parameters here?" + }, + { + "prediction": "I think this should be `bitcore.Unit = require('./lib/unit').Unit;`", + "reference": "please keep alphabetical ordering :)" + }, + { + "prediction": "I think we should use `StandardCharsets.UTF_8` instead of `Charset.forName(\"UTF-8\")`", + "reference": "Selenium must compile against Java 6. Revert this line." + }, + { + "prediction": "I think we can remove the `resourceGroup` parameter from the `MakePullSubscription` function as well.", + "reference": "what is that `\"\"`, the adapterType? can you add `\"\" /* adapterType */`... in other places as well... might be cleaner if it's a pointer or some varargs at the end but don't have any strong preference.." + }, + { + "prediction": "I think this should be `pType !== 'boolean' && pType !== 'undefined'`", + "reference": "This check is a little odd, and will still mess up with empty strings `''` because empty string is falsy. Can we change this to `|| _this.getValue(path) == null`?" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "Just a minor suggestion: If you `parseInt` when you access the attribute then you shouldn't have to do it twice in the ternary." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in `BoltServer::Transport::SSH#connect` and pass the `host-key-check` option to `Net::SSH.start`.", + "reference": "This change in particular is strange. I'm not sure why it would now be necessary. The previous default would've been true, and the default behavior without a new net-ssh version should be unchanged." + }, + { + "prediction": "I think this should be `null` instead of `true` by default.", + "reference": "Why is that? Should be redundant as the default value exists." + }, + { + "prediction": "I think this should be `DebugSimulateDataRace` instead of `DebugSimulateDataRace`.", + "reference": "Are all fields beginning with \"Debug\" automatically `;local` ? (I guess so, but just checking.)" + }, + { + "prediction": "I think this should be `UpdateNameMapping updateNameMapping()` instead of `UpdateNameMapping updateNameMapping()`.", + "reference": "While I think it makes sense to update the mapping programmatically, I don't see much value in exposing it as part of the table API. We want to keep the Table API small, so if we can handle this by using a separate API that consumes and produces JSON, then that is preferred. Also, we may have more than one mapping in the future, so keeping this decoupled also helps out for those use cases. For now, let's build a utility class to perform these updates. We can always add this to the public API later if we choose to." + }, + { + "prediction": "Why is this change necessary?", + "reference": "We would want ssmp to wake up every 3 seconds if there are no other requests to it and do some cleanup tasks. So, it is not clear why do you want to set this to 0." + }, + { + "prediction": "I think we can remove this now that we have `getLLVMRuntimeType`.", + "reference": "Is this really necessary? I would expect these types to be included with the loop below." + }, + { + "prediction": "I think we should use `BitConverter.ToInt64(bytes.Reverse().ToArray(), 0)` instead of `Array.Reverse(bytes); BitConverter.ToInt64(bytes, 0);`", + "reference": "You could do span and it's magic of typecast to int for better efficiency" + }, + { + "prediction": "I'm not sure this is the right way to do it. I think we should use `cssRule.style.getPropertyValue('transform')` instead of `cssRule.style.transform` and `cssRule.style.webkitTransform`. This way we can be sure that we're getting the value of the `transform` property and not the value of the `transform` property prefixed with `-webkit-`.", + "reference": "Looks like you've covered `-webkit-transform`, but what about `-ms-transform`?" + }, + { + "prediction": "I'm not sure this is the right thing to do here. I think it should be a warning, not an error.", + "reference": "Is there something missing from the message here?" + }, + { + "prediction": "I don't think we need to expose `rpc` and `RemoteScheduler` in the public API.", + "reference": "Hmm, what does this syntax mean?" + }, + { + "prediction": "nit: I think it's better to put `callerTypeAPI` as the first argument.", + "reference": "should this be callerTypeTask?" + }, + { + "prediction": "Metrics/LineLength: Line is too long. [83/80]", + "reference": "Currently update is set as @plan.editable_by?(@user.id) Which one is the correct behavior? I can see a case for only owners/co-owners to be able to set visibility, test status, and other plan details" + }, + { + "prediction": "I think it's better to make it configurable.", + "reference": "Maybe make it configurable? Or store the actual level index in DB, making this binary search obsolete?" + }, + { + "prediction": "nit: please remove this empty line", + "reference": "Nit: this file doesn't need to change. Can you revert this to avoid git conflicts?" + }, + { + "prediction": "I think we should add `handleMenuSelected` to the dependency array here.", + "reference": "There's no reason for this to be a callback now technically but as per our tech decision, we want all handlers to use `useCallback` now" + }, + { + "prediction": "I don't think we need a new type for this. We can just use the `Message` type.", + "reference": "This isn't strictly part of this PR, but could you move `multiSigString` from `crypto/multisig.go` into this list of `HashID` values? Now that we have other things being hashed into addresses (specifically, these new logic addresses), it's important that the hash input for multisig addrs is domain-separated from logic addresses." + }, + { + "prediction": "I think this should be `tearDownClass` instead of `tearDown` so that it only runs once per test class instead of once per test method.", + "reference": "nit: you could have named it just \"TestCase\" (if django's TestCase was imported differently)" + }, + { + "prediction": "I don't think we need the `&&=` here. We can just do `options[:page_ranges] = Array(options[:page_ranges])`", + "reference": "the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here." + }, + { + "prediction": "I don't think this change is correct. `dynamic_value` should be `lldb::eNoDynamicValues` by default, and `synthetic_value` should be `true` by default.", + "reference": "All the callers of `ExtractSomeIfAny`, always pass `true` to `synthetic_value`. Can we get rid of the extra argument?" + }, + { + "prediction": "I don't think we need to log the config file path.", + "reference": "Better to use the absolute path." + }, + { + "prediction": "I think this should be `ChannelExpiryBuffer` instead of `ChannelExpiryInterval`", + "reference": "this is 16 hours, is that enough?" + }, + { + "prediction": "I don't think we need to pass in a pointer to `err` here. I think we can just pass in `err`.", + "reference": "removing boilerplate. You could also add a `StartSpan` with varargs to inline string attributes." + }, + { + "prediction": "I think this should be `uint64` instead of `uint32`", + "reference": "Can you replace these single letter variables with full names?" + }, + { + "prediction": "This should be `public Action PrepareRequest { get; set; }`", + "reference": "At first I wasn't sure, but now I think I'm sold on making PrepareRequest an action over adding a state object to the context." + }, + { + "prediction": "I think this should be `preg_match('/^VuFind \\d+(\\.\\d+)*$/', $newConfig['Site']['generator'])`", + "reference": "Would it be too greedy to preg_replace `VuFind (\\d+\\.?)+` with `'VuFind ' . $this->to` anywhere in the string? This would update something like 'Finna (VuFind 7.1.0)' as well. Just a thought, please disregard if you'd like to keep it as is." + }, + { + "prediction": "I think this should be `getZkController().getZkStateReader().getClusterState().getCollection(collection).getConfigName();`", + "reference": "BTW for brevity, you can remove `getZkStateReader().` here and elsewhere since ZkController has a convenience method for the cluster state." + }, + { + "prediction": "nit: I think we can use `Iterables.empty()` instead of `CloseableIterable.empty()`.", + "reference": "If there are no manifests, then entries should be `CloseableIterable.empty()`, not the manifest iterable. That doesn't need to be closeable." + }, + { + "prediction": "I think we should have at least one unit test here.", + "reference": "this class should be named `ArrayInitializationVerbosenessTest` to work" + }, + { + "prediction": "I think this should be an `else` to the `if val == 'disable'` above.", + "reference": "Do we want to allow users to disable `console` as well? The schema currently says that it only permits a hash for `console`." + }, + { + "prediction": "Can we remove this? It looks like it was left in by accident.", + "reference": "It would be very helpful to describe succinctly either inline or by linking to an issue going into depth why each test is not working. If we merge like this your knowledge of what is going on is lost and other people in the code need to do a ton of reading before understanding when/how/if we should unskip." + }, + { + "prediction": "I don't think we need to pass `handleDataError` and `handleDataSuccess` to the `useEffect` hook.", + "reference": "As this is a `useEffect` this could be a cause for concern! Note that `useEffect` re-runs when a dependency changes **not** when a dependency is truthy (the previous code does look a bit like it's expecting that)" + }, + { + "prediction": "I think this should be `world_comm_ptr{new lbann_comm(0), lbann::finalize }`.", + "reference": "Should we be doing this with `make_unique` or something?" + }, + { + "prediction": "Metrics/LineLength: Line is too long. [121/120]", + "reference": "we don't want to set default values for this. Since it is the actual email, we want to make sure we are always passing in the `user` and `proposal` . we have a default value of `nil` for modifier because sometimes will update a proposal via `rails console` in which case there will be no recorded modifier." + }, + { + "prediction": "This import is not needed anymore.", + "reference": "Yes this import was in the wrong place, but should ideally be in the first list of imports (among `go/build`, `go/token`, etc.). You may move it there, or just revert this change as it's actually unrelated." + }, + { + "prediction": "I think we should keep `StrictUnusedVariable` as the primary name, and add `UnusedVariable` as an alias.", + "reference": "It's unnecessary to duplicate the `name`." + }, + { + "prediction": "I don't think this change is necessary. The `unlink` field is a checkbox, so its value will always be `true` or `false`, not `null`.", + "reference": "this was a mistake when adding phpstan strict plugin" + }, + { + "prediction": "I'm not sure if this is the best way to handle this. I think it would be better to have a flag on the `oldVNode` to indicate that it is a placeholder. Then we can just check for that flag instead of having to check for `oldDom` and `oldVNode._dom` and `oldDom.parentNode != parentDom` all at the same time.", + "reference": "Nit: I think it should be `to handle` here." + }, + { + "prediction": "I don't think this change is correct. It should be `|| message.getId() <= 0`", + "reference": "Please don't make unrelated changes or let your tools make unrelated changes." + }, + { + "prediction": "I think we should keep the `numAccounts` as `int`.", + "reference": "`numAccounts` is a global variable (from `gochecknoglobals`)" + }, + { + "prediction": "I think this should be `unset($this->plugins[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($this->loaded[$id]); unset($", + "reference": "Is the ID correctly normalized at this point?" + }, + { + "prediction": "I don't think you need to pass `0` to `NodeInfo` here.", + "reference": "if 0 is a special constant meaning \"no limit\" let's make it a constant and name it correctly :)" + }, + { + "prediction": "Why is this moved here? It seems like it should still be after the `setPatchPolicies` call.", + "reference": "Curious about the reason behind this change" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think we should be using the `cborStore` instead of the `onlineStore` here. The `onlineStore` is only used for blocks that have been fetched from the network, while the `cborStore` is used for blocks that have been created locally.", + "reference": "wait, i thought the cborstore was for state tree?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done after the `pkg.build` call, but before the `pkg.save` call. That way, if the build fails, we don't have to worry about cleaning up the temp files.", + "reference": "This logic is now duplicated here and in `_delete_temporary_files`... Maybe do it all at once - find temp files, delete them, and fix the logical keys?" + }, + { + "prediction": "I don't think we need this method at all. We can just remove it from the interface.", + "reference": "How about name it with NullResponseTypeProcessor" + }, + { + "prediction": "I don't think this check is necessary.", + "reference": "Maybe `Log::Fatal` here? `[LightGBM] [Fatal] Check failed: feat_is_unconstrained at ...` (and kernel death in case of Jupyter Notebook) seems to be not so informative and user-friendly." + }, + { + "prediction": "I think this should be `_process` instead of `_apply`.", + "reference": "Not sure I like the name ``_apply``. Even though ``_process`` is supposed to process elements already, how about ``_process_element`` which processes elements, *excluding* Overlays/NdOverlays." + }, + { + "prediction": "I don't think we need this constant. We can just use the string `\"node\"` directly.", + "reference": "Let's use this constant when ASG is created as well (currently hardcoded)." + }, + { + "prediction": "I'm not sure what you mean by \"most unique values to least unique\". Can you give an example?", + "reference": "Oh is `bucket` actually higher cardinality than `eventname`?" + }, + { + "prediction": "I don't think this import is needed.", + "reference": "You can't rely on QtWebEngine being available - but why do you need to import this here at all?" + }, + { + "prediction": "I don't think we need to list all of these. I think it's enough to just list `NVDAObjects`.", + "reference": "How did you determine these - and how can we be confident that nothing is missing?" + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it works for now.", + "reference": "What is this page going to do that is different than the products index we already have?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's better to return `nil` if we can't find the extension id, rather than raising an exception.", + "reference": "Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else." + }, + { + "prediction": "I think this should be `attr_accessor :script, :hash_config, :config, :allow_failure, :versioned_runtimes`", + "reference": "Is this intended to be here? Seems it belongs to a different PR." + }, + { + "prediction": "I think this should be `Console.ResetColor();` instead of `Console.ForegroundColor = ConsoleColor.White;`", + "reference": "These changes, while harmless, were no longer needed with newer versions of System.Console thanks to @ianhays" + }, + { + "prediction": "I think this should be an error, not a warning.", + "reference": "Umm... this isn't relevant to this PR" + }, + { + "prediction": "I think this should be `0x0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_0000_000", + "reference": "While All make some sense here it doesn't make a lot of sense in the SkipOnFramework context. I wonder if we really need to expose anything more here. You can just blindly use 0." + }, + { + "prediction": "I think we can remove this file.", + "reference": "Actually, this is not correct. Package `cmd/bee` doe snot have any notion of commands or even libraries used for them. It is as simple as possible, just calling the function from `cmd/bee/cmd` which actually implements commands." + }, + { + "prediction": "I think we should keep the `resetNamespace: true` here and in the `users` route.", + "reference": "This change is causing tests to fail because users sits at `/app/users`, not `/app/admin/users`" + }, + { + "prediction": "This should be `null` by default.", + "reference": "Could you provide more information on what exactly each of those three options do?" + }, + { + "prediction": "nit: extra space after `get {`", + "reference": "Why this line break?" + }, + { + "prediction": "I think we can remove the `apiextensionsv1` import and just use `v1` everywhere.", + "reference": "We're importing this twice with different aliases." + }, + { + "prediction": "I'm not sure if we want to pin this to a specific version. I think it's fine to have it as `pandera>=0.7.0,<0.8.0` or even `pandera>=0.7.0,<0.9.0`.", + "reference": "We should avoid adding a pandera dependency to Dagster itself." + }, + { + "prediction": "I don't think you need to create a new array here. You can just do `this.permissions = Arrays.copyOf(this.permissions, this.permissions.length + 1);` and then add the new permission to the end of the array.", + "reference": "Can be replaced with `org.jkiss.utils.ArrayUtils#add`." + }, + { + "prediction": "I don't think we need to do this. `electionContexts` is a `ConcurrentHashMap`, so it's already thread-safe.", + "reference": "While we're here, this line (and a few others) should be `customThreadPool.submit(() -> IOUtils.closeQuietly(overseer);` I have no idea why we're creating a collection and a stream for a single object." + }, + { + "prediction": "I think this should be `if len(p.AzureDNS.ManagedIdentityClientID) > 0 || len(p.AzureDNS.ManagedIdentityResourceID) > 0 {`", + "reference": "Should these restrictions also be reflected in the API docs?" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but it seems to be the only place where we have access to the original request.", + "reference": "What about the request headers if someone uses `request_header`? :thinking:" + }, + { + "prediction": "I think this should be `--domain-filter=%s` instead of `--domain-filter=%v`", + "reference": "Verify that external-dns allows setting this parameter multiple times (that it's not \"last one wins\")." + }, + { + "prediction": "I think this should be `etc_hosts: {'host1.example.com': '10.3.1.5'}`", + "reference": "Maybe 2 host/ip values could be used in the example?" + }, + { + "prediction": "I don't think we need to create a new `Tracer` instance here. We can just use `Tracer.Instance`.", + "reference": "We're only testing `RateLimiter.Allowed(Span)`, so I think we can use a mock `ITraceContext` instead of a real `Tracer` or `TraceContext`." + }, + { + "prediction": "I think this should be `trainer->get_name()` instead of `pb_trainer->get_name()`. `pb_trainer` is a pointer to a `lbann_data::Trainer`, not a pointer to a `lbann::Trainer`.", + "reference": "IMO, this is the wrong way to associate a model with a trainer... Why the string when you actually have a trainer object?" + }, + { + "prediction": "I think this should be `block_a.type () == rai::block_type::state` instead of `block_a.type ()`", + "reference": "Wondering if we can directly put types here & for other similar ledger_processor items like rai::block_type::state" + }, + { + "prediction": "I think it would be nice to have a progress bar here, too.", + "reference": "As `DeleteFiles` is not only used for prune this function deserves its own file. Maybe something like `delete_files.go` or `parallel.go`?" + }, + { + "prediction": "I think this should be `:attribute \u5df2\u7ecf\u88ab\u4f7f\u7528\u3002`", + "reference": "It should be simplified character. `` -> ``" + }, + { + "prediction": "I don't think we need to have this here. We can just have `ParallelLevels` in `TrieVisitContext` and set it to `-1` by default.", + "reference": "I am pretty sure it breaks the visitor pattern, visitor should have no knowledge about the structure of what it is visiting or control over visiting mechanism" + }, + { + "prediction": "I think this should be `TreeMap` instead of `TreeMap`.", + "reference": "'A' instead of 'An' here" + }, + { + "prediction": "I think this should be `time.Second * 10`", + "reference": "Can you flip it back (here and in other places)? It is more natural to represent \"10 seconds\" as `10 * time.Second`." + }, + { + "prediction": "I think it would be better to use the same data as in `test_regressor`.", + "reference": "Why was this necessary? You should just use the `dask_classifier` defined below this. With this change, you'd only be doing the local predict on arrays each time, but we want to test on all of DataFrame, Array, and sparse matrix." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's better to use `link_to` instead of `link_to raw(@purchaseable.github_url)`.", + "reference": "To me, this is sort of weird to have a completely separate page for this. Can we extract the different stuff (github, videos, downloads) presentation from the top of `app/views/purchases/show.html.erb` and reuse it on this page. I worry that we'll change things with fulfillment or copy and have to change it in multiple places." + }, + { + "prediction": "This import is not used.", + "reference": "Please revert the lines above. Not touching unrelated code keeps the git history clean." + }, + { + "prediction": "Please update the version to 2.4.0rc0.", + "reference": "`short_version` and `version_info`" + }, + { + "prediction": "`stats` -> `status`", + "reference": "This is supposed to be `status`. Why did you change this?" + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to work for me.", + "reference": "I will change all of these at some point next week." + }, + { + "prediction": "I don't think we need to throw a `NotSupportedException` here. We can just return an empty string.", + "reference": "I made this change because, while trying to debug, in Visual Studio, the `IntegrationSignatureTests`, this property getter was hit and interfered with my ability to complete the debugging." + }, + { + "prediction": "I think this should be `model.KubernetesResourceState_ERROR` instead of `model.KubernetesResourceState_OTHER`.", + "reference": "nit: `\"Unexpected error while calculating: unable to convert %T to %T: %v\"`" + }, + { + "prediction": "I think this should be `applicationName` instead of `appName` to be consistent with the rest of the codebase.", + "reference": "I'd actually recommend not putting this in the `SampleConfig`, it's intended more for properties that are inherent of the discovery format. Add a method `getSampleAppName(String apiTypeName)` to `SampleNamer` and override it in the language specific `SampleNamer`s if needed. Then assign it in the transformer." + }, + { + "prediction": "I don't think we need to export this. It's only used in one place.", + "reference": "Do we need to export these new functions? I thought the plan going forward was to keep util imports separated to make circular imports less likely and possibly do better chunk splitting. Since only new code references these files, we can scope the import to the specific files." + }, + { + "prediction": "Trailing whitespace detected.", + "reference": "Rails will autorequire `acts_as_editable` once it encounters the constant `ActsAsEditable`. Thus if we move `ActiveRecord::Base.send :include, ActsAsEditable` from _acts_as_editable.rb_ to this file, the require line will not be needed anymore. Instead of requiring the file ourselves, we will let Rails do it for us. This fix will also remove the need to explicitly require `acts_as_editable` in _mock_active_record_base.rb_." + }, + { + "prediction": "I think this should be `public abstract String getUpperCamelMethodName();`", + "reference": "I think we should name this `grpcMethodName` or similar. That is what this refers to, right? The fact that it is upper camel is an implementation." + }, + { + "prediction": "I don't think we need to check for '/' here. I think we should only check for '.' as that is not a valid character in a file name.", + "reference": "What if .. appears, but not as the first character, eg \"errors/../../../../../../../../../../../\"?" + }, + { + "prediction": "Metrics/LineLength: Line is too long. [82/80]", + "reference": "Thanks, this should make things a bit easier for people who pick up the codebase but aren't a `curation center`" + }, + { + "prediction": "Can we remove this?", + "reference": "why not removing it?" + }, + { + "prediction": "I think this should be `disable` instead of `disableHostVerification`", + "reference": "same nit here: maybe word as - \"disables validation of the temporal cluster's server certificate\"" + }, + { + "prediction": "why do we need this?", + "reference": "Nit: other statements use all caps for SQL reserved words. Should this be `SHOW TABLES`?" + }, + { + "prediction": "I think this should be `c == '.' || c == ':' || c == '_'`", + "reference": "Do we need this? isLuaIdentifier() is used not only in extract_next_token() but also in extract_prev_toke(). I wonder whether the change for isLuaIdentifier() has an impact on extract_prev_toke() or not. If you are not sure, keep isLuaIdentifier() as is. If you are sure, could you write your conviction to the commit log." + }, + { + "prediction": "I think this should be `if c.Wireguard.EncryptHostTraffic && c.KubernetesProvider == config.ProviderAKS && c.RouteSource == \"WorkloadIPs\"`", + "reference": "This line should actually be: `if c.KubernetesProvider == config.ProviderAKS && c.Wireguard.EncryptHostTraffic {` because we only need to tweak the MTU like this on AKS." + }, + { + "prediction": "I think this should be \"Name of the service.\"", + "reference": "Do we need to change this flag as well?" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "Including the source twice here makes the filesize jump to 432kb. Is there any way to minimize repeating it?" + }, + { + "prediction": "I think this should be `nameOrHandle` instead of `handle`.", + "reference": "This should only be sent if the driver is speaking to a W3C conformant remote, so we need an if-condition check like we have in the Python bindings." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "Only one line of code? What a simple issue!" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we want to use the `NewDefaultIncomingDynamicRateLimiter` for the outgoing rate limiter, and the `NewDefaultOutgoingDynamicRateLimiter` for the incoming rate limiter.", + "reference": "Conceptual question: why do history and matching need throttler at all? Shouldn't throttling to be handled on FE only?" + }, + { + "prediction": "nit: I think it would be clearer to say \"The internal NetworkPolicy may not have been created yet. It's fine to skip processing this CNP as addCNP will create it eventually.\"", + "reference": "Would this be possible: `addCNP` has already processed the CNP to an internalNP, just hasn't added this internalNP to the `internalNetworkPolicyStore`. In this case, `reprocessCNP` will skip processing this CNP and `addCNP` will just add the \"old\" internalNP to `internalNetworkPolicyStore`." + }, + { + "prediction": "Metrics/MethodLength: Method has too many lines. [31/25]", + "reference": "Minor: you can access `current_user` in here directly - don't need to pass it in. Unless you prefer passing it explicitly?" + }, + { + "prediction": "Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", + "reference": "What is the purpose of `&` on this line?" + }, + { + "prediction": "Shouldn't this be `^[a-zA-Z0-9-]+$`?", + "reference": "See above, the `isValidWebDataStreamID` implementation from before is actually correct. What we need here instead is a new `isValidMeasurementID` function." + }, + { + "prediction": "I think we should close the connection here.", + "reference": "Should be an error... it is important for the admin of the server attempting to create the leafnode connection to see the error asap." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in `getSpeechTextForProperties`.", + "reference": "Could you split these conditions up over multiple lines please." + }, + { + "prediction": "I'm not sure why we need 3 here. I think 2 should be enough.", + "reference": "I think we can just change this to `Split` instead of `SplitN`. I don't think we need to limit the number of parts in the tag." + }, + { + "prediction": "I think this should be `{{ range $port := .ports }} - \"{{ $port }}:{{ $port }}\" {{ end }}`", + "reference": "So this is actually a mistake that I introduced without realizing it, and have known would need to be fixed when we get here . The format of the ports directive is \"host:container\". We only want the host port to change, not the internal container ports. The ports variable probably needs to be a map which maps external -> internal ports." + }, + { + "prediction": "nit: I think we can remove the `if s.shardInfo != nil` check here.", + "reference": "An alternate approach would be to always initialize shardInfo with a dummy (non-nil) value, which could protect against other uses before it's initialized (I couldn't find any though). But I can change it to do it that way instead." + }, + { + "prediction": "I think this should be `LastWriter keybase1.UID` instead of `LastWriter keybase1.UID`", + "reference": "Maybe we can just put the entire `DirEntry` in here? I can imagine it might be useful for debugging to get the block ID/refnonce, encrypted size, key gen, data version, etc. What do you think?" + }, + { + "prediction": "I think this should be `c->maximized` instead of `c->maximized_horizontal || c->maximized`.", + "reference": "For the commit message: The paragraphs seem to be out of order? The `Would not work because` refers to the stuff before, but there is a `This may seem pointless, but` in-between." + }, + { + "prediction": "I'm not sure why these were removed, but I think they should be added back in.", + "reference": "Why did you remove these packages from the prelude, will your new functions not work without this change?" + }, + { + "prediction": "`kvKeys` should be passed by value, not by reference.", + "reference": "We'd better reserve enough space before using kvKeys to avoid extra malloc." + }, + { + "prediction": "I think this should be called `GetNodeName` since it returns the name of the node.", + "reference": "would it make sense to return empty or error if label doesn't exists?" + }, + { + "prediction": "I think this should be `numAttempts < maxAttempts` instead of `numAttempts <= maxAttempts`.", + "reference": "Don't penalize everyone with 250ms delay b/c some machines have problems." + }, + { + "prediction": "I think this should be `out = fmt.Sprintf(\"%s, %s\", out, it.Value().String())`", + "reference": "Probably want a space after the second %s?" + }, + { + "prediction": "I think this should be `serviceerror.NewUnavailable(archiver.ErrHistoryNotExist.Error())`", + "reference": "This seems like an internal error still?" + }, + { + "prediction": "Metrics/LineLength: Line is too long. [101/80]", + "reference": "Line is too long. [94/80]" + }, + { + "prediction": "Nit: I think it would be better to use `time.Time` instead of `int64` for the creation time.", + "reference": "out of curiosity, why creating another struct to wrap it?" + }, + { + "prediction": "I don't think you need to use `fmt::format` here, you can just use `fmt::format_to` to write to a `std::string` and then call `GetOwner()->Message` with that string.", + "reference": "discipline vs. Discipline? Not sure of which is correct. Also not sure if there is already an existing string const." + }, + { + "prediction": "I think this should be `setProtoFile(protoFile)` instead of `setAssignedProtoFile(protoFile)`.", + "reference": "I believe this will break common resources, as they are defined in a common file, but must generate classes in service-specific namespace, so using protoFile to determine package of the generated class would not work, because common_resources namespace does not match service namespace." + }, + { + "prediction": "I think this should be `0` instead of `\"0\"`.", + "reference": "How about `SPARK_DEFAULT_SERIES_NAME`?" + }, + { + "prediction": "I think this should be `COMMIT_STATUS_CHECKS_TOTAL_WAIT_MS`", + "reference": "The other properties are in `commit.status-check`, not `commit.status-checks`. Could you remove the extra `s`?" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but I think it should be done in `setupDatabase` rather than here.", + "reference": "Side note: I'd love to see more of these fields exposed on configuration." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think we can remove the `@resource.is_a?(User)` check and just use `@resource.invited_by.name` in both cases.", + "reference": "In the case of accounts generated by API clients, what name gets put for the `inviter_name` or `invited_by` record?" + }, + { + "prediction": "I don't think you need to implement it here. The `getStartBlock` method in `MutableBftConfigOptions` will return `Optional.empty()` if `startBlock` is not set.", + "reference": "I think this class is only relevant for updating the QbftConfigOptions based on the transitions config, so probably not." + }, + { + "prediction": "I think it should be `TracerTimeoutExceeded` or `TracerTimeoutExceededError`", + "reference": "what is the number thrown by Geth?" + }, + { + "prediction": "Why do we need to split on `?` here?", + "reference": "This would still crash on malformed database connection string like \"test\"" + }, + { + "prediction": "I'm not sure this is the right place to put this. I think it should be in the `plugin` package.", + "reference": "it is not an interface, maybe we can move to another package?" + }, + { + "prediction": "`tableMeta` -> `meta`", + "reference": "Same here. Can we use `this.instance.getSettings()` to get `tableMeta`?" + }, + { + "prediction": "I think this should be `cgroup.Resources.CpuWeight != 0 || cgroup.Resources.CpuShares != 0 || cgroup.Resources.CpuQuota != 0 || cgroup.Resources.CpuPeriod != 0 || cgroup.Resources.CpuRealtimePeriod != 0 || cgroup.Resources.CpuRealtimeRuntime != 0 || cgroup.Resources.CpuCfsQuotaMicros != 0 || cgroup.Resources.CpuCfsPeriodMicros != 0 || cgroup.Resources.CpuShares != 0 || cgroup.Resources.CpuQuota != 0 || cgroup.Resources.CpuPeriod != 0 || cgroup.Resources.CpuRealtimePeriod != 0 || cgroup.Resources.CpuRealtimeRuntime != 0 || cgroup.Resources.CpuCfsQuotaMicros != 0 || cgroup.Resources.CpuCfsPeriodMicros != 0 || cgroup.Resources.CpuShares != 0 || cgroup.Resources.CpuQuota != 0 || cgroup.Resources.CpuPeriod != 0 || cgroup.Resources.CpuRealtimePeriod != 0 || cgroup.Resources.CpuRealtimeRuntime != 0 || cgroup.Resources.CpuCfsQuotaMicros != 0 || cgroup", + "reference": "Not sure whether this validation is useful." + }, + { + "prediction": "I think it would be better to use `message.info(\"Yanked download URL to clipboard: {}\".format(question.yank_text))` instead of `message.info(\"Yanked download URL to clipboard: {}\".format(s))`.", + "reference": "Various things to note here: - Why would `question` ever be falsey (or `None`) here, i.e. why the `if question`? - Why would `question` ever not have that attribute? You set it in `Question.__init__`, so that check does nothing at all (and generally, `hasattr()` should be avoided if possible). - Why do you want to yank `None` (what does that do?) rather than e.g. show an error if there's nothing to yank?" + }, + { + "prediction": "This should be removed.", + "reference": "If this is needed for testing, you should use `pytest --log-cli-level=INFO` instead." + }, + { + "prediction": "I think this should be `https://testnet2-location.mysterium.network/api/v1/location`", + "reference": "We should drop ipify in all places i guess" + }, + { + "prediction": "I don't think we should change the names of the consensus params. I think it's better to keep them as they are.", + "reference": "Add explanations around these variables - what do they mean, how they should be configured, etc." + }, + { + "prediction": "Metrics/BlockLength: Block has too many lines. [31/25]", + "reference": "One thing tho - I would really appreciate any advice on where to move this to, so that it's called on initialisation of the website." + }, + { + "prediction": "I think this should be `displayGatheredResources` instead of `displayResources`", + "reference": "To much tabs here (1 tab)" + }, + { + "prediction": "nit: I think we can use `String.format` instead of `+` here.", + "reference": "This is not maintaining retention time for logs as we are deleting only 1000 entries and we might end up with huge number of rows spanning over multiple months over a period of time if the cluster generates more rows as we are restricting ourselves to delete only 24k rows/day. Like I pointed out earlier a better would be to probably run this clean up every hour with some batch_size in a loop while there are records to be deleted(i.e older than 12 weeks) and committing each batch." + }, + { + "prediction": "I don't think we need to override the retry policy for this test. We can just use the default one.", + "reference": "I don't like this helper func :-). Yeah, definitely don't like." + }, + { + "prediction": "I think we can remove the `else if` here as well.", + "reference": "Same here. This should remain unchanged. Please, add it back." + }, + { + "prediction": "Shouldn't this be `options.ignoreUndefined = this.s.options.ignoreUndefined;`?", + "reference": "@kvwalker should this method have `ignoreUndefined` supported as an `option`?" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but I think it would be nice to have a `NewLogger` function that takes a `zap.Logger` and returns a `*zap.SugaredLogger`. That way we don't have to do this everywhere.", + "reference": "we dont use a `sugaredlogger` anywhere else in clutch, just curious why were using it here?" + }, + { + "prediction": "Why is this line removed?", + "reference": "Not evident from looking at this diff but the queue is already being cleared four lines below." + }, + { + "prediction": "I think this should be `t.Sender == transactions.CompactCertSender` instead of `t.Sender == transactions.CompactCertSender.String()`.", + "reference": "Why is this a 'transaction' and not in the block header?" + }, + { + "prediction": "I think this should be `X509Certificate` instead of `X509Certificate2`. `X509Certificate2` is a subclass of `X509Certificate`.", + "reference": "This doesn't fit the abstraction level. Should we have a property bag for extra stuff?" + }, + { + "prediction": "I don't think we need to include `ci/gendoc.py` in the sdist.", + "reference": "Looks like it is pretty easy to miss it when adding new files under `ci`. Hopefully, this doesn't happen too often." + }, + { + "prediction": "I don't think we need to defer this. The p2p service will be stopped when the bee is stopped, which will stop the p2p service, which will stop the p2p service, which will stop the p2p service, which will stop the p2p service, which will stop the p2p service, which will stop the p2p service, which will stop the p2p service, which will stop the p2p service, which will stop the p2p service, which will stop the p2p service, which will stop the p2p service, which will stop the p2p service, which will stop the p2p service, which will stop the p2p service, which will stop the p2p service, which will stop the p2p service, which will stop the p2p service, which will stop the p2p service, which will stop the p2p service, which will stop the p2p service, which will stop the p2p service, which will stop the p2p service, which will stop the p2p service, which will stop the p2p service, which will stop the p2p service, which will stop the p2p", + "reference": "do we really need the `Ready` call if startup fails midway?" + }, + { + "prediction": "Why do we need to specify the port here?", + "reference": "You can avoid changing the code if there are parameter defaults. right ?" + }, + { + "prediction": "I'm not sure if this is a change in behavior or not, but it seems like it should be a change in behavior.", + "reference": "I wonder why the newline disappeared here? I guess we'll merge and see how SauceLabs fares across the supported browsers." + }, + { + "prediction": "This should be `atoi(sep->arg[1]) == 0`", + "reference": "I know this is legal, but I prefer we put brackets on our calls" + }, + { + "prediction": "`AWS IAM` -> `AWS Identity and Access Management`", + "reference": "AWS Identity and Access Management (IAM)" + }, + { + "prediction": "I don't think we need to create a new exception for this. Let's just use `InvalidElementStateException`.", + "reference": "We keep who wrote the code anonymous." + }, + { + "prediction": "I'm not sure if this is the best way to do it, but it seems to work.", + "reference": "Two things to make the code more error-proof and simplify it: 1. To be safe, this should be: `! isUndefined( decimal ) && ! isUndefined( decimal.value )` 2. The other clause that you changed below can be combined with that since `decimal` isn't used anywhere else, and so there's no point to re-check whether it's not undefined. In other words, this should become: `! isUndefined( decimal ) && ! isUndefined( decimal.value ) && 1000 > number`, and then you can remove the `decimal = decimal.value` assignment and replace it with line 146 (assignment of `readableNumber`)." + }, + { + "prediction": "I'm not sure this is the right place to put this. I think it should be in the `Transport` interface.", + "reference": "Wouldn't composite outbounds compose the transport, such that it would still be represented as a single transport?" + }, + { + "prediction": "nit: remove empty line", + "reference": "nit: there is no need for a new line here, usually we tend to put an object creation and its deferred deletion next to each other. It helps not forgetting about the cleanup." + }, + { + "prediction": "I don't think it's necessary to mention the author here.", + "reference": "Feel free to use the full notation with my email address: `Maxime Steinhausser ` :smile:" + }, + { + "prediction": "Why is this removed?", + "reference": "This was unused across the codebase" + }, + { + "prediction": "I think this should be an error, not a warning.", + "reference": "Should we put in which account we were trying to look up?" + }, + { + "prediction": "I think this should be `InventoryTypeClass.Supported_TypeClass`", + "reference": "either SUPPORTED_TYPECLASS or supported_typeclass. Camelcase only for class names." + }, + { + "prediction": "I'm not sure if this is the right place to add this column. I think it would be better to add it to the `notes` table in the `notes` schema.", + "reference": "This is not going to work. You need to add a migration to the database." + }, + { + "prediction": "I think this method should be renamed to something like `resumePlayback` or `resumeGroupPlayback`.", + "reference": "Should these methods be renamed in this PR?" + }, + { + "prediction": "I think it would be better to throw an `ArgumentException` here.", + "reference": "we need to include the `metricStreamName` which is invalid, so users know whats causing the issue." + }, + { + "prediction": "I think we need to use `AssemblyLoadContext.Default.LoadFromAssemblyPath(binaryPath);` instead of `Assembly.Load(AssemblyLoadContext.GetAssemblyName(binaryPath));`", + "reference": "Please run Platform tests `DiaSessionTests`." + }, + { + "prediction": "I think this should be `MSG_AVX_512_SUPPORT_INCOMPLETE` instead of `MSG_AVX_512_SUPPORT_INCOMPLETE_STRING`.", + "reference": "This is debug-build-only: we want a release-build notice. SYSLOG takes the name w/o the MSG and no _STRING. Args are via events.mc specifiers." + }, + { + "prediction": "Shouldn't this be `if (!options.directConnection && !options.directconnection)`?", + "reference": "is it possible to have both forms here? I was hoping we wouldn't be introducing more cases where we had to check the upper and lowercase version of URI options." + }, + { + "prediction": "I don't think we should use the same name for all benchmarks.", + "reference": "Does the name suffix hardcode something? Not clear how changing the name fixes this." + }, + { + "prediction": "Should this be a `List` instead of a `String`?", + "reference": "Is undispatched same as queued? getQueuedFlows?" + }, + { + "prediction": "I think this should be `Core Site data store: connection info tests`.", + "reference": "See above, same for all similar cases below." + }, + { + "prediction": "I'm not sure why we need to append the trace logs twice here, but it seems to be the only way to get the test to pass.", + "reference": "Why is this done twice?" + }, + { + "prediction": "I don't think we need to propagate the deadline to the children nodes. If the deadline is already exceeded, we should not propagate it to the children nodes.", + "reference": "This sync can ensure that the condition of the child node is consistent with the parent node, but I still don't understand when the child will be overwritten, and this behavior is not what we expected?" + }, + { + "prediction": "I think this should be `DEBUG_TEST_FAILURE=true` instead of `DEBUG=true`.", + "reference": "This was renamed to avoid any confusion with the more general case of debugging via `plz debug`" + }, + { + "prediction": "I don't think this is correct. If the length of the string is less than `prefixLength`, this will throw `StringIndexOutOfBoundsException`.", + "reference": "String valStr = (String)val; valStr.substring(0, Math.min(valStr.length(), prefixLength)) Make it clean." + }, + { + "prediction": "I think this should be `evb.CreateEnumerator(\"NONE\", BASE_TYPE_NONE);` instead of `evb.CreateEnumerator(\"NONE\", 0);`", + "reference": "Sorry, this still makes no sense.. the value of any union or enum is simply a name integer constant, it has nothing to do with the `BASE_TYPE_` enum. This value should be `0`. In particular: `Every union has the NONE field, which always has value 0`." + }, + { + "prediction": "I think we can remove this method from the Alerter interface. It is only used by the email alerter.", + "reference": "Looks like getAzkabanURL() is added after concrete Alerter (Emailer)::getAzkabanURL(), so that Override annotation is needed." + }, + { + "prediction": "Why do we need this? `segms[i]` is already a boolean mask.", + "reference": "The above 3 lines can be written as: `mask = segms[i].astype(bool)`" + }, + { + "prediction": "I think we don't need to import `address` here.", + "reference": "File is not `gofmt`-ed with `-s` (from `gofmt`)" + }, + { + "prediction": "I don't think we need to log this every time the node starts.", + "reference": "Thought it's good to have this logged down so that we can check the used value in the logs." + }, + { + "prediction": "I don't think we need to make this optional.", + "reference": "I don't think you can call this optional unless it's a pointer - remove this?" + }, + { + "prediction": "I think it would be better to show a toast when there are no products to send, not when there are no products saved.", + "reference": "@naofum please use `isEmpty`method instead" + }, + { + "prediction": "I think you can remove the `auto` here.", + "reference": "i think this is unrelated and needs to be reverted. need to discuss at sync." + }, + { + "prediction": "I think this should be `org.hyperledger.besu.plugin.data.BlockHeader` instead of `org.hyperledger.besu.plugin.data.BlockHeader`", + "reference": "Are we eventually moving those type interfaces from plugin project to datatype project? If not, then we'd have a dependency from core onto plugins, which seems a little counter-intuitive to me." + }, + { + "prediction": "I don't think we need to return an array of results here. We can just return the result of the last one.", + "reference": "Love how we can finally use async/await in the codebase." + }, + { + "prediction": "I think this should default to `true`", + "reference": "Very minor: this line could be moved to a more narrow scope, inside `if (!representative.decode_account (representative_text))` Other than that, LGTM" + }, + { + "prediction": "Why do we need this field?", + "reference": "when is this consumed? I'm probably missing it but I can't find it right now" + }, + { + "prediction": "I think this should be `if (isRollup() || isGroupingSet())`", + "reference": "I think we also need to add the rollupGroupExprList() to the cache key. If we rebuild the list above from a ValueIdSet on line 418 above, it is probably going to be in the same order, regardless whether it was ROLLUP(a,b) or ROLLUP(b,a)." + }, + { + "prediction": "I don't think you need to import `com.google.api.codegen.viewmodel.SimpleParamDocView` here.", + "reference": "can use `getParamTypeName` instead" + }, + { + "prediction": "I don't think this is the right place to put this code. It should be in the `toggleBooleanProperty` method.", + "reference": "Why send the parameters? They're accessible directly from `$this->request` so there's no need to inject them in the method" + }, + { + "prediction": "I think this should be `if selected_file is None:` or `if not selected_file:` or `if len(selected_file) == 0:` or `if not selected_file:`", + "reference": "Tiny nit: I would prefer `not selected_file` or `len(selected_file) == 0`, as if choose_file starts returning, for example, tuples instead of lists, this won't break." + }, + { + "prediction": "I think it would be better to return an error here and not remove the name file. The name file should only be removed when the server is started for the first time.", + "reference": "How will this code behave with hostnames that contain hyphens?" + }, + { + "prediction": "I think this should be `if (kegg != null && !string.IsNullOrWhiteSpace(kegg))`", + "reference": "I think this is redundant since \"NullForEmpty\" already calls \"Trim()\"." + }, + { + "prediction": "I think this should be `CloudBackupGroupID` instead of `GroupCloudBackupID`.", + "reference": "Change this to IDs too?" + }, + { + "prediction": "This should be a `Set` not an `ImmutableSet`.", + "reference": "private static final, and it should be located in raidsoverlay, as it's not needed in the plugin. also the name could be a bit better, DC_SCOUT_RAIDS or similiar." + }, + { + "prediction": "I'm not sure why we need to limit the size of the buffer to 127 bytes here. I don't see anything in the man page for fscanf that would limit the size of the buffer.", + "reference": "attr_value is 128 bytes?" + }, + { + "prediction": "shouldn't it be `self.method = self.method.upper() if not has_variable_pattern(self.method) else self.method`?", + "reference": "if it's unpredictable - why uppercase it at all?" + }, + { + "prediction": "I think this should be removed.", + "reference": "Please remove all these debug prints. It doesn't look good." + }, + { + "prediction": "I think this should be `SampleChainRandomness(height *types.BlockHeight) ([]byte, error)`", + "reference": "Consumers of this interface should not be required to provide `sampleHeight`. This should be an expected consensus parameter." + }, + { + "prediction": "I think this should be `if closeTime.Before(startTime) || closeTime.Equal(startTime) {`", + "reference": "I don't believe this is the right fix. If startTime comes after closeTime, then it means some other event triggered invocation of this code path like workflow timeout. In this case we should still try to fire the cron on previous value so we should just return start the delta between startTime and closeTime immediately." + }, + { + "prediction": "I think this should be a `map[string]string` instead of a `string` so that we can filter on multiple tags.", + "reference": "Not sure if we need tag here, it is an implementation detail in portworx that isn't exposed in openstorage" + }, + { + "prediction": "I don't think we need the backticks here.", + "reference": "I wonder if it would be cleaner to refactor all of this similar to the SolrMarc driver, so we have a property with Summon field names associated with types, and we iterate through it in a loop... that way we don't have to repeat the loop code four times with different variable names." + }, + { + "prediction": "I think we should use `searcher.getCore().getCoreContainer().getSolrClientCache()` instead of `new SolrClientCache()`.", + "reference": "Need the `solrClientCache.close();` further down in the method be removed since a shared cache is now used?" + }, + { + "prediction": "nit: I think we should call this `MutableData` and `MutableDataEncoding` to make it clear that it's not immutable.", + "reference": "according to the PR (schema changes?) these 2 field should be removed?" + }, + { + "prediction": "I think we can remove the `ContainerNames` field from `Target.StressChaos` and use `ContainerName` instead.", + "reference": "Panic here if `exp.Target.StressChaos.CintainerName` is nil." + }, + { + "prediction": "Shouldn't this be `DocIdSetIterator filterIterator(DocIdSetIterator scorerIterator)`?", + "reference": "This allows for some hacks like returning an iterator that matches more docs than the scorer. I liked the previous approach that returned an iterator better." + }, + { + "prediction": "I think we can remove this debug log.", + "reference": "Aren't there already logs for this from the underlying file system implementation?" + }, + { + "prediction": "I think this should be `['DismaxMunge' => []]` instead of `['DismaxMunge' => null]`.", + "reference": "It would be good to have a test in here that demonstrates the new munge functionality; I can help set that up if you're not sure how." + }, + { + "prediction": "I think this should be `max_retries_to_get_pods`", + "reference": "`retrials` isn't the word you intend. I think you mean `retries` and to that end, can the var name just be `max_retries`?" + }, + { + "prediction": "I think it would be better to add this help text to the `AttributeProductMetaTitleType` instead of the `AttributeIdType`. This way the help text is only shown when the `AttributeProductMetaTitleType` is used and not when the `AttributeIdType` is used.", + "reference": "Value in product should contain 255 characters or less." + }, + { + "prediction": "I don't think we need to do this. We can just use the `ProposerInterval` from the FSM config.", + "reference": "line is 133 characters (from `lll`)" + }, + { + "prediction": "I think this should be `personal_options` instead of `personal_options_file`.", + "reference": "since we're calling the file .rspec-local, I think we should rename local_options to project_options and use local_options for .rspec-local - WDYT?" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "Will we want to refactor this when we drop rsolr 1.x support?" + }, + { + "prediction": "I'm not sure this is the right thing to do, but I'm not sure what else to do either. We don't have a way to get the IP address of the node, and we don't have a way to get the name of the node, so I'm not sure what else to do. I think this is the best we can do for now.", + "reference": "should this really be multiple IPs?" + }, + { + "prediction": "Extra empty line at the end of a file.", + "reference": "Hmm, is that partial used in multiple places? Maybe we can just move that file in here." + }, + { + "prediction": "I don't think we need to generate mocks for this package.", + "reference": "Should be 2014-2016" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but it seems like a good place to me.", + "reference": "Looks like my fault for sure in trying to handle international inputs regardless of locale. I think the correct fix is actually to get rid of TrySplitColumns and use ParseDsvFields instead. It is what gets used in the end, and it already has logic for dealing with quoted fields." + }, + { + "prediction": "I'm not sure if this is necessary, but it doesn't hurt to close the cursor.", + "reference": "similarly here, are the these cursors not being closed when the client is closed?" + }, + { + "prediction": "I think we can remove the `string` parameter from the `Policy` interface.", + "reference": "Or maybe `func(args ...string) Policy` to make it dynamic in case of any future policy that may require more than one args." + }, + { + "prediction": "I'm not sure this is the right place to call this. I think it should be called in `serviceLoggedIn` after `config.MakeDiskBlockCacheIfNotExists()` is called. This is because `MakeFBOsForExistingJournals` will create FBOs for existing journals, and `MakeDiskBlockCacheIfNotExists` will create FBOs for new journals. If we call `MakeFBOsForExistingJournals` before `MakeDiskBlockCacheIfNotExists`, then we will create FBOs for new journals twice.", + "reference": "Should this happen even if the above failed?" + }, + { + "prediction": "copyright year should be 2017-2018", + "reference": "Please dont change this ." + }, + { + "prediction": "I'm not sure this is the right place to log this. I think it should be logged in the `erase` method of `nano::active_transactions`.", + "reference": "There is a strange $b that looks wrong." + }, + { + "prediction": "I think this should be `containerContainsText = _(\"with %s items\") % childControlCount`", + "reference": "Is it still important to have `speakEntry` here? It is checked before this value `containerContainsText` is used in the \"General\" section." + }, + { + "prediction": "I think this should be `sh.export 'PATH', '$JAVA_HOME/bin:$PATH'` instead of `sh.export 'PATH', '$JAVA_HOME:$PATH'`", + "reference": "It is `$JAVA_HOME/bin`, not `$JAVA_HOME`, which should be added." + }, + { + "prediction": "This should be `#include `.", + "reference": "Should move this to within the `#else` block as it's only used there." + }, + { + "prediction": "Why do you need to wait for AJAX and then wait for 1 second?", + "reference": "is this a common rule to wait one extra second after ajax? I'm thinking about moving this extra wait into waitForAjax method." + }, + { + "prediction": "I think this should be `unset($properties['site'], $properties['logger'], $properties['solr']);`", + "reference": "Maybe you can correct the typo \"if\" too :)" + }, + { + "prediction": "I think this should be `IdentifyChat` instead of `IdentifyForChat`", + "reference": "I'd prefer a name less chat-specific, since later on we could have other app types that want the same behavior. Maybe `IdentifyAndAllowTrackBreaks`?" + }, + { + "prediction": "This should be `if (PyMPIComm_Get == nullptr) {`", + "reference": "I think I was involved in writing that caster, but I never fully understood the `import_mpi4py` thing. Why is importing mpi4py still necessary at that point? I would think if the user is passing a communicator from python code, they must already have imported mpi4py themselves, or does that not propagate through into the wrapping layer?" + }, + { + "prediction": "I'm not sure this is correct. The `defer resp.Body.Close()` is in the `else` clause, so it won't be called if the `resp.StatusCode == http.StatusNotFound` condition is true.", + "reference": "This seems like a more interesting change. Maybe we should re-name the PR" + }, + { + "prediction": "I'm not sure if this is the right place to add these features. I think they should be added to the `IConnection` interface instead.", + "reference": "Nit: implement the methods for these interfaces explicitly in this file for consistency. It can be passthrough." + }, + { + "prediction": "I don't think you need to add `getCallName(\"\")` here.", + "reference": "Not directly related to your PR, but I think here we should create a Type enum (MAP, ARRAY, PRIMITIVE) instead of having 3 flags." + }, + { + "prediction": "I think this should be `NABoolean isFirstBatch = true;`", + "reference": "Do you want this to be a stack variable? The work method might return at any time (example: when the parent queue fills up) and then get called again, which would cause this variable to become false again. I'm wondering if this variable should be a member instead?" + }, + { + "prediction": "I think it's better to use `folly::toAppend` instead of `std::string::reserve` and `std::string::append`.", + "reference": "You could reserve a const space to save the extra computation." + }, + { + "prediction": "I think it would be good to have a test case with a path that has a mix of redundant and non-redundant segments. Something like `/home/user/runtime/src/coreclr/runtime/src/libraries/System.Private.CoreLib/src/../System/IO/..//./Path.cs`", + "reference": "Did you consider adding rooted paths like `C:\\ProgramData` and paths with flipped separators?" + }, + { + "prediction": "I don't think this is correct. The defer should be after the `if err != nil {` block.", + "reference": "does this line cause a panic if it is above the if condition ?" + }, + { + "prediction": "I think it would be better to name this enum `LibraryDetailsPanel` instead of `LibraryDetailsPanels` as it is not a collection of panels but a single panel.", + "reference": "Maybe `LibraryDetailsPanelType` would be clearer." + }, + { + "prediction": "I think this function is unused now.", + "reference": "minor nit - add \"persist-filesystem\" and \"persist-directory\" into commit message, as its something people may search on (maybe applies to a few other commit messages)" + }, + { + "prediction": "Why is this removed?", + "reference": "I verified offline with @jeremyg-lunarg this should be removed." + }, + { + "prediction": "This should be removed.", + "reference": "This should be removed? If not, typo in incldued_wf" + }, + { + "prediction": "I'm not sure if this is the best way to do this. I think it's a bit of a hack, but I couldn't think of a better way to do it.", + "reference": "Sorry for the delay on this! It looks like Circle CI isn't running tests on some of the PRs, but this doesn't look like it would work I might be missing something, but are the tests all passing locally?" + }, + { + "prediction": "I think this should be `SplitPaths` to be consistent with the rest of the codebase.", + "reference": "Do you think the godoc should mention that all delimiters will be suffixed with `/`?" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but I think it should be done here. If the user is in private browsing mode and they try to navigate to a `data:` URL, we should redirect them to the private browsing page.", + "reference": "what if I want to load my own, a different, data URI in Private Browsing mode? I do this often on desktop (e.g., `data:text/html,×`). admittedly, I wouldn't expect this to be done by a non-developer, but this will certainly cause a minor bug." + }, + { + "prediction": "I think this should be `private long minSequenceNumber = Long.MAX_VALUE;`", + "reference": "I remember the sequence number 0 is kept for the data files for iceberg v1, so in theory the sequence number from delete files should start from 1. So setting it to 0 as the default value sounds correct." + }, + { + "prediction": "I don't think we should change this to `integer` as it will not work for versions like 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0", + "reference": "For all these MYSQL queries unsigned is required. I have tested again and without unsigned these queries are failing." + }, + { + "prediction": "I think this should be `MAX_HISTORY_LENGTH` or `MAX_HISTORY_SIZE` or something like that. `MAX_HISTORY` is too vague.", + "reference": "Are there tests for this? What happens when you get to limit?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think we should be able to set the transport to `nil` and have it default to `local` if the target is `localhost`.", + "reference": "Whole thing could be collapsed to `data['config']['transport'] ||= 'local' if target.name == 'localhost'`." + }, + { + "prediction": "I think you can remove this method and call `getSignKeyId(data)` directly from `onClick()`.", + "reference": "maybe throw in `&& mServiceConnection.isBound()`, there are cases where the connection might die" + }, + { + "prediction": "I don't think this is correct. EIP-1344 should be enabled in MuirGlacier.", + "reference": "Can we add Istanbul with this first EIP please? (or as a separate issue)" + }, + { + "prediction": "I think this should be `return errors.Wrap(err, \"failed to get current user\")`", + "reference": "I don't understand this change" + }, + { + "prediction": "\"Invalid Public key\" should be \"Invalid public key\"", + "reference": "Let's allow translators for this string to be translated: `self.show_warning(_('Invalid Public key'))`" + }, + { + "prediction": "I think this should be `if (!role && (parent.tagName.toLowerCase() !== 'form' && parent.tagName.toLowerCase() !== 'body'))`", + "reference": "This needs to work with `role=form` too." + }, + { + "prediction": "I think this should be `if (localConnection && localConnection.type == Blockly.OUTPUT_VALUE) {` instead of `if (localConnection && localConnection.type == Blockly.OUTPUT_VALUE) {`", + "reference": "This should be before the if on line 1028, which should turn into an else if" + }, + { + "prediction": "nit: I think we should use `[]metav1.LabelSelectorRequirement` instead of `*[]metav1.LabelSelectorRequirement`", + "reference": "Not really introduced by this PR, but I don't recall why these have to be pointers, while `PodSelector` / `NSSelector` do not. Do you know the reason?" + }, + { + "prediction": "I think this should be `sample-r.minRTT > ackDelay` instead of `sample-r.minRTT >= ackDelay`.", + "reference": "Is there a reason why we are ignoring the ackDelay if it would result in a value smaller than the min? Why not `max(sample - ackDelay, minRTT)`?" + }, + { + "prediction": "Why is this `internal`?", + "reference": "Here's an example of how the files in the `NotYetGenerated` directory drifted out of sync from the generated files. When we made the equality comparers internal, we neglected to fix this one." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it works for now.", + "reference": "nice. we should do this elsewhere too. We have a lot of repeated stuff in the policies" + }, + { + "prediction": "I think this should be `TEST_ERRORS_1(src, \"can't find declaration of 'y'\")`", + "reference": "Small formatting thing, but can you remove the space before the semicolon?" + }, + { + "prediction": "I think this should be `long remaining = InnerLoopCount * (long)_writeLenght;`", + "reference": "Not new, but nit: _writeLeng*th*." + }, + { + "prediction": "I think this should be `assert.NoError(checkDockerCompose())` instead of `assert.NoError(checkDockerCompose)`.", + "reference": "Our habit is to go ahead and put a description line (or more) in front of every function, not just non-test or exported functions." + }, + { + "prediction": "nit: please remove the empty line", + "reference": "Remove this file from the PR" + }, + { + "prediction": "I think this should be `Blockly.Variables.nameValidator_.bind(null, varType, variable.name)`.", + "reference": "I think that for cloud variables, the default value in the prompt should be the variable name without the cloud prefix; this is slightly different from the scratch 2.0 behavior, but I think would ultimately lead to less confusion. Proposing code changes below:" + }, + { + "prediction": "I think this should be `libinput_device_config_tap_get_finger_count(libinput_dev) > 1`", + "reference": "I think I would rather fish this interface through than use it as the basis for heuristics." + }, + { + "prediction": "Remove the extra space at the end of this line.", + "reference": "Probably not worth making this line-ending change, since it is the only change to this file." + }, + { + "prediction": "I don't think we need to assert anything here. If the size is not 64, then we will fail to decode the instruction, which is the right thing to do.", + "reference": "Is this the correct place for this assert? Does this routine rely on it being 64, or was this only for testing?" + }, + { + "prediction": "I don't think it's a good idea to use `proto` as a package name. It's too generic.", + "reference": "No pb please" + }, + { + "prediction": "Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.", + "reference": "We need to add indexes here on both `subscriber_id` and `changeset_id` or things will quickly collapse as we build up subscribers ;-) What I would suggest is a unique index on `[:subscriber_id, :changeset_id]` which will also make duplicate entries impossible, and an ordinary index on `[:changeset_id]` for finding the subscribers to a changeset." + }, + { + "prediction": "I'm not sure if this is the right place to put this function. I think it should be in the slackbot package, but I'm not sure if it should be in the slackbot/slackbot.go or slackbot/slackbot_test.go file.", + "reference": "use the context versions of everything, e.g. `PostMessageContext` and thread it through the functions. will save you a bunch of refactoring trouble later on." + }, + { + "prediction": "I'm not sure about this change. I think it's better to keep the docstring as it was.", + "reference": "\"not to be used elsewhere other than\"" + }, + { + "prediction": "I think we need to set the `spark.sql.parquet.output.committer.class` property here as well.", + "reference": "Thanks for the contribution, @coolderli ! I also think the newPosDeleteWriter need the properties setting ..." + }, + { + "prediction": "I'm not sure if we need to add an index on `plan_type` as well, but I think it doesn't hurt to have it.", + "reference": "These additions seem unrelated to this change?" + }, + { + "prediction": "I think this should be `iceberg.engine.hive.enabled` instead of `engine.hive.enabled`", + "reference": "Could we move this to a class for Hadoop configuration properties, like `org.apache.iceberg.hadoop.ConfigProperties`?" + }, + { + "prediction": "why remove this?", + "reference": "The related statements should also be deleted." + }, + { + "prediction": "Shouldn't this be `params[\"PolicyNames\"] = None`?", + "reference": "Shouldn't this line be removed?" + }, + { + "prediction": "I don't think we need this function. We can just call `username in bad_names` directly.", + "reference": "Just move this into `const.py`. It already has similar stuff. Also, make it uppercase since it's a const." + }, + { + "prediction": "I'm not sure why this is needed, but it seems like it should be removed.", + "reference": "Issue is that `currentMode = newMode;` is called at the end of the method. Passcode screen will come up, but since the activity thinks current mode is biometric check we don't check passcode when submitted." + }, + { + "prediction": "why change this value?", + "reference": "Need change it back?" + }, + { + "prediction": "Trailing whitespace detected.", + "reference": "Didn't we delete this file a while back because it isn't used but people think that it's a security vulnerability that it's checked in?" + }, + { + "prediction": "I think we can remove this line.", + "reference": "nit: Looks like this can be removed now" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it is. If the user doesn't specify any CAs, then we should create a default one for them. If they do specify CAs, then we don't want to create a default one.", + "reference": "Can probably remove the lines above it too (L60-62), since ProvisionDefaultCA() makes sure the map isn't nil." + }, + { + "prediction": "nitpick: `static int handler_registered = 0;` should be `static int handler_registered = 1;`", + "reference": "Do you think it's worth erroring out? It's likely that this is a configuration error that the user might want to know about?" + }, + { + "prediction": "I don't think this is the right fix. I think it should be `# +1: [fixme]`", + "reference": "I think the functional test should not change here, this is probably a test in itself :)" + }, + { + "prediction": "I think it's better to use `var Sanitizer = bluemonday.UGCPolicy().AllowAttrs(\"class\").Matching(regexp.MustCompile(`[\\p{L}\\p{N}\\s\\-_',:\\[\\]!\\./\\\\\\(\\)&]*`)).OnElements(\"code\").AllowAttrs(\"type\").Matching(regexp.MustCompile(`^checkbox$`)).OnElements(\"input\").AllowAttrs(\"checked\", \"disabled\").OnElements(\"input\")`", + "reference": "Why this to be a public function?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it makes sense to not log the timing of the `export` command.", + "reference": "I think we can remove the timing for export env vars" + }, + { + "prediction": "I think it's better to keep `config.EndpointSliceHandler` and `config.NodeHandler` in the `Provider` interface, and add `Run()` and `GetServiceByIP()` to the `Provider` interface.", + "reference": "wrong import grouping" + }, + { + "prediction": "I don't think this is the right fix. I think it should be `UserPreferences.getBackButtonGoToPage()` instead of `context.getResources().getStringArray(R.array.back_button_go_to_pages_tags)`.", + "reference": "There is a doubled semicolon ;)" + }, + { + "prediction": "This should be `#include `", + "reference": "I'm wondering why this isn't . Seems like one would have to copy the md5.h file into the source tree somewhere for this to compile cleanly. Maybe you meant to use angle brackets instead of quotes?" + }, + { + "prediction": "`visibility_of_any_element_located`?", + "reference": "shouldn't **call** return a boolean?" + }, + { + "prediction": "I don't think this is the right place to do this. I think it should be done in the `CastSpell` function of the `NPC` class.", + "reference": "We don't need to cast to client here. (well, from spell gem not AA etc) We should also make sure the charm is a casted spell before calling SendSpellBarEnable." + }, + { + "prediction": "This should be `String(256)`", + "reference": "This is not an `id`. This should either be `invocation_time` or `invocated_at` to be consistent with what we are using elsewhere, and also to better rerflect the column's DateTime type. Also, within the context of this table, there is no idea of what `invocation` is. I know that `scanner` may not be future-proof, but we need to find something more descriptive. Perhaps one possibility is to call this `audit_time`." + }, + { + "prediction": "I think this should be called `GetDestinationAddress` or `GetRecipientAddress` or something like that. `GetReceiverAddress` sounds like it's the receiver of the transaction, not the destination of the transaction.", + "reference": "should the 'Receiver' be the clawback address in case of clawback transaction?" + }, + { + "prediction": "I don't think we need these constants. They are not used anywhere.", + "reference": "@ashishranjan738 -- Where are these consts used? in which pkg?" + }, + { + "prediction": "I don't think this is needed anymore.", + "reference": "The only change I would suggest is moving these lines back below the `templates_path` variable to keep the diffs smaller." + }, + { + "prediction": "I'm not sure why this is necessary. `changes` is a pointer, so `changes.Info = info` should modify the original `changes` object.", + "reference": "Having it above kept the block info in the cached changes, which could end up confusing things quite a bit." + }, + { + "prediction": "I think we can remove the `task_name = options[:object]` line here as well.", + "reference": "If the execute_task returns an `ExecutionResult`, the passing of a block would be unnecessary. Instead, the `ExecutionResult` could be presented to the user in some standardized way (iterating over the result of each node, etc.)." + }, + { + "prediction": "Why do we need to pass a channel here?", + "reference": "Not sure why we make a new channel here. If we don't use this channel, how about creating it inside the `Connect`?" + }, + { + "prediction": "I don't think we need to do this. If the wal has been rolled back, we will get E_RAFT_NO_WAL_FOUND anyway.", + "reference": "There are two question here: 1. If you only modify lastLogId, but the `iter` is not modified, I really don't know whether we can succeed. 2. We will check the if the term has changed in `replicateLogs` (if rollback really happen, the term must have been updated), so I really doubt whether the problem should be fixed in this way. Or you could describe it in more details." + }, + { + "prediction": "I don't think this is correct. The form type name should be used here, not the form type class.", + "reference": "Hello @jDolba, I have reviewed your PR and I found one problem. `$step->getFormType()` can return `FormTypeInterface`. You cannot use interface as key for an array. Can you find some better way to fix this? Thank you." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think we need to add the `rpm-package-key.gpg` key to the yum repo for EL6 as well.", + "reference": "i was confused by keyword \"inventory\" here. my understanding is this starts the osconfig-agent which covers inventory lookup and package-management(correct me if i am wrong)." + }, + { + "prediction": "I don't think we need to add these here. They are already defined in `org.openqa.selenium.remote.CapabilityType` and `org.openqa.selenium.remote.Timeouts`.", + "reference": "These are really meant to be the keys in the capabilities, not the keys of values within the capabilities" + }, + { + "prediction": "I'm not sure why this is needed, but it seems to be required for the tests to pass.", + "reference": "This breaks tests on IE because this will import an `esm` bundle. For that reason `sinon` is available as a global in our test suite and never imported. The global is aliased to the proper `es5` file." + }, + { + "prediction": "I think this should be `1.0 / 4`", + "reference": "Maybe move all the Loss Recovery constants to a separate file." + }, + { + "prediction": "I think we should rename this to `name` to be consistent with the rest of the codebase.", + "reference": "this field is added so that we can find disk name by device name from attachments" + }, + { + "prediction": "Please remove this empty line.", + "reference": "Unnecessary new line" + }, + { + "prediction": "I think this should be `if _, ok := state.NamespacePaths[nsType]; ok { continue }`", + "reference": "First determine if the namespace already exists, so it's clearer that it's handling namespaces that aren't included in the `c.config.Namespaces`" + }, + { + "prediction": "I'm not sure about this change. I think it's better to keep the same structure as the other pages.", + "reference": "What changed in the styles that means we don't need this?" + }, + { + "prediction": "I think this should be `projectJsonRoot[\"frameworks\"][framework][\"dependencies\"] as JObject;`", + "reference": "This pattern should be applied to the other instance where NewtonsoftEscapeJProperty is used and you can remove the NewtonsoftEscapeJProperty method." + }, + { + "prediction": "This should be a deprecation warning, not a warning.", + "reference": "Something to mention in the next changelog/release notes. It will be good to get histogram working consistently with everything else." + }, + { + "prediction": "I don't think we need to add this here. This is only used in the `initContainers` section, and we don't have any `initContainers` in this template.", + "reference": "What does this contain? Is it PVC namespace or is it openebs?" + }, + { + "prediction": "I think this should be `IHttpBodyMinimumDataRateFeature`", + "reference": "Design note: Using local concrete data types on a feature abstraction makes it hard to generalize / replace. This is tolerable so long as this remains a kestrel exclusive feature, but we'd need a different design if this were ever moved to HttpAbstractions." + }, + { + "prediction": "I think this should be `R_AS_INT(data_idx) - 1` since R is 1-indexed and C++ is 0-indexed.", + "reference": "this will break R package, you should update the R files accordingly. BTW, the call state should be in the last argument." + }, + { + "prediction": "`$mediaContext` should be `$media->getContext()`", + "reference": "Shouldn't we throw an exception if the context is null instead ?" + }, + { + "prediction": "This should be `>= 1.12.0`", + "reference": "These should both be const, not var right?" + }, + { + "prediction": "`build_match_cost` -> `build_match_cost_calculator`", + "reference": "Rename the directory, match_costers -> match_costs" + }, + { + "prediction": "I think this should be `self.assertEqual(int(count), 2)`", + "reference": "I don't think this should go in the model tests, since it is done in the resource. `PaginatedDeleteTest` seems more appropriate" + }, + { + "prediction": "I don't think this is the right message. It should be something like \"Session ID is null. Did you call quit()?\" or \"Session ID is null. Did you call close()?\" or \"Session ID is null. Did you call shutdown()?\" or \"Session ID is null. Did you call stop()?\" or \"Session ID is null. Did you call destroy()?\" or \"Session ID is null. Did you call terminate()?\" or \"Session ID is null. Did you call exit()?\" or \"Session ID is null. Did you call kill()?\" or \"Session ID is null. Did you call stopServer()?\" or \"Session ID is null. Did you call stopWebDriver()?\" or \"Session ID is null. Did you call stopDriver()?\" or \"Session ID is null. Did you call stopBrowser()?\" or \"Session ID is null. Did you call stopApplication()?\" or \"Session ID is null. Did you call stopProcess()?\" or \"Session ID is null. Did you call stopService()?\" or \"Session ID is null. Did you call stopApplicationServer()?\" or \"Session ID is null. Did you call stopApplicationDriver()?\" or \"Session ID is null. Did you call", + "reference": "It would be better to just change RWD to throw IllegalStateException if you attempt to execute a command after quit (unless it's a second call to quit())" + }, + { + "prediction": "I think this should be `exporter.Controller().Stop(context.Background())` instead of `exporter.Controller().Stop(context.TODO())`.", + "reference": "Could we move this to an example test to allow the compiler to help us ensure it stays up-to-date in the future?" + }, + { + "prediction": "I think we should keep this test, but change it to use `expect(STDOUT).to receive(:print).with('Please enter your password: ')` instead of `allow(STDOUT).to receive(:print).with('Please enter your password: ')`", + "reference": "Maybe we could update these to use $future and then check on stderr? that way when we deprecate stdout we can not have to delete tests." + }, + { + "prediction": "I think this should be `MaxAllowedMaxFrameSize` instead of `_maxFrameSize`. `_maxFrameSize` can be less than `MaxAllowedMaxFrameSize`.", + "reference": "Remove this since it always has to be set afterwards." + }, + { + "prediction": "I think this should be `blockChangeSize(20*1024*1024)`?", + "reference": "These two tests were causing us to use too many goroutines with `-race` using the default block change size, I think due to prefetching." + }, + { + "prediction": "I think we can remove the `now` and `requestContext` parameters from the `fetch` method in the `LeafNode` class. The `now` parameter is not used in the `LeafNode` class, and the `requestContext` parameter is not used in the `fetch` method of the `LeafNode` class.", + "reference": "Is that `try..except` block really needed? I mean, when it could fail?" + }, + { + "prediction": "I think this should be `**/suspense.test.js` so that we don't have to update this file every time we add a new test file.", + "reference": "If you only want to run a specific group of tests you can always use `.only` like `it.only()` or `describe.only()`. It may not speed up the globbing process as much as this change here :)" + }, + { + "prediction": "I don't think we need to hardcode these values here. We can get them from the `boto3` SDK.", + "reference": "nit: I'd probably rename this to `BATCH_SIZE_RANGES`, to use a slightly more descriptive name." + }, + { + "prediction": "This should be `90` and `100`", + "reference": "aren't these the wrong way around?" + }, + { + "prediction": "This is not used in this PR. Can you please remove it?", + "reference": "Lets call this getConfigSetService and maybe rename the field now (or later)" + }, + { + "prediction": "I think we can remove the `klogr` import now?", + "reference": "Could / should we make these constants and give them a type?" + }, + { + "prediction": "I don't think we need to hardcode the platform names here. We can get them from the `Platform` field of the `ClusterDeployment` object.", + "reference": "lets stick with lowercase for consistency." + }, + { + "prediction": "I don't think we need to change the order of the imports here.", + "reference": "ordering of imports went wrong" + }, + { + "prediction": "I think this should be `return MetadataTableType.ALL_DATA_FILES.name();`", + "reference": "I think these can all be .name() to get the value we are looking for" + }, + { + "prediction": "I think this should be `(print \"test\") === 1;` instead of `(print \"test\") === 2;`", + "reference": "Is this a good place for these test cases?" + }, + { + "prediction": "Please remove this print statement.", + "reference": "Did you mean to leave the print statement?" + }, + { + "prediction": "This should be `new BN(500000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "reference": "I would do `new BN(Interpreter.LOCKTIME_THRESHOLD)`" + }, + { + "prediction": "I think we should keep the imports as they were before.", + "reference": "@ftomassetti I turned the tree walking algorithms into iterators so you don't have to visit every node when you only wanted a few, like for a `findFirst`." + }, + { + "prediction": "I think this should be `TimeoutType%v` instead of `TimeoutTimeoutType%v`", + "reference": "Need to add type name here to be compatible with proto string representation." + }, + { + "prediction": "I think this should be `log.info`", + "reference": "This is to let people know that the tooling is doing something during a build. Please leave." + }, + { + "prediction": "I'm not sure if this is a good idea, but I think it's better to use a real user principal here rather than a fake one.", + "reference": "Why is the principal changing here?" + }, + { + "prediction": "I think this should be `AZURE_STORAGE_DOMAIN` instead of `AZURE_BLOB_DOMAIN`.", + "reference": "Naming nit: let's use `AZURE_STORAGE_` prefix for consistency with the other ones." + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to work.", + "reference": "I'm a bit confused. We have an actual `ProgressBar` Uppy React wrapper component that we are testing. Why do we need a mock for it?" + }, + { + "prediction": "I don't think we need to import `errors` in this file.", + "reference": "can we use `github.com/pkg/errors`?" + }, + { + "prediction": "I think this should be `actualType` instead of `inferredType`.", + "reference": "I changed the name of the arguments here just to help make the code clearer." + }, + { + "prediction": "I think this should be \"unnecessarily\" instead of \"unncessarily\".", + "reference": "I think either 'avoiding calls to the function' or 'to avoid calling the function ...' would be read better." + }, + { + "prediction": "I think this should be `const auto &attachment : shared_attachments_` instead of `const auto attachment : shared_attachments_`.", + "reference": "@sfricke-samsung -- thanks. saves a few atomic ops which is always good :) The TODO is there to track that this object is storing *both* vectors of shared_ptr and plain pointers to the same data. The shared are to ensure scope, and the plain are for backwards compatibility with existing code that consumed a plain pointer vector (and some code that still does). That should be cleaned up." + }, + { + "prediction": "I don't think we need to use `Nethermind.Monitoring.Metrics` namespace here. We can use `Nethermind.Monitoring` instead.", + "reference": "minor: typo (knowMetricsTypes -> knownMetricsTypes)" + }, + { + "prediction": "I think this should be `((CharType*)getType())->setCaseinsensitive(((CharType *)(((ConstValue*)(right))->getType()))->isCaseinsensitive() || ((CharType *)(((ConstValue*)(right))->getType()))->isCaseinsensitive());`", + "reference": "This adds a case-insensitive flag to the type in the RangeSpec, but I don't think RangeSpecs are written to handle case-insensitive comparisons. Take a look at the methods that deal with comparisons when building RangeSpecs, in file Range.cpp. So, I think you would have to do one of two things: a) disable the RangeSpec transformation for case-insensitive comparison operators (the easy way) or b) change the RangeSpec methods to handle case-insensitive comparisons." + }, + { + "prediction": "I don't think this is the right place for this method. It should be in `TypeSolver` or `TypeSolverFactory`.", + "reference": "I would throw an exception if the type is not solved" + }, + { + "prediction": "I don't think we need to skip these anymore.", + "reference": "if remove `dt.skipLoad` - then this tests will run. You probably mean opposite?" + }, + { + "prediction": "Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.", + "reference": "I feel like we do this in a lot of places should we move that out into its own PR?" + }, + { + "prediction": "Why is this async now?", + "reference": "Already asked you in Matrix, but I'll do it here again so it can be discussed publicly. Why?" + }, + { + "prediction": "I think it would be better to say \"de-indent all the code inside it\" instead of \"de-indent all the code inside it and de-indent all the code inside it\".", + "reference": "I think here should be a comma before remove, in all the cases" + }, + { + "prediction": "why do we need `stages` here?", + "reference": "Single quote is used by default in this project." + }, + { + "prediction": "Why don't we want to reconcile on spc?", + "reference": "S1023: redundant `return` statement (from `gosimple`)" + }, + { + "prediction": "Why do we need to implement `Close`?", + "reference": "`ctx` is unused in Close" + }, + { + "prediction": "I think this class is not needed. You can throw `NotFoundHttpException` directly.", + "reference": "I'm confused. This exception is thrown when `HeurekaCategory` is not found in database. But this exception extends Http exception. Why? What has database search common with http? If the only reason is that it is the same in the whole project, then fine. But then we have even bigger problem - we don't know how to use exceptions." + }, + { + "prediction": "Please add `type='DCNv2'`", + "reference": "Is it necessary to add the suffix `on_head`, because it belongs to` bbox_head`?" + }, + { + "prediction": "This should be `AS_IF([test x$with_modern_grub = xyes], [AC_DEFINE([WITH_MODERN_GRUB], 1, [Define if we have a GRUB version newer than 2.02])])`", + "reference": "Hmm, I wonder if this should just be e.g. `--with-grub-2.02` instead. (Not sure Autoconf supports periods in these switches.) Today's modern GRUB is tomorrow's ancient GRUB. :) Or maybe we should be specific about the feature this is enabling, which might be safer given that each distro carries so many patches. E.g. `--without-grub-efi-16-suffixes`?" + }, + { + "prediction": "I think this should be `DeleteInstance` instead of `Delete`.", + "reference": "Add a GetSerialPortOutput method to Instance that way you don't need to access the client, also it makes the call cleaner as you don't have the odd i.Client and path.Base(i.Project), path.Base(i.Zone)" + }, + { + "prediction": "Line is too long. [101/80]", + "reference": "Line is too long. [104/80]" + }, + { + "prediction": "I think this should be `expectedAssignedCDs` instead of `expectedAssignedCDS`", + "reference": "Since CD updates (assignment & power state) are now done in this controller..." + }, + { + "prediction": "I think this should be `opts && opts.conflictStack && opts.conflictStack.join('\\n\\n')`", + "reference": "Hmm I'd rather not support this option going forward - it seems like a one-off just to work around this particular issue. Would it be fine to just remove the `deepStackTrace` option? The rest of the PR looks great - I love the idea of switching to sets." + }, + { + "prediction": "Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.", + "reference": "on the one hand I like how little this is doing. On the other hand, `inbound_mail_parser` is doing most of the work here so maybe it's not as helpful as I originally thought" + }, + { + "prediction": "I think this should be a separate test case.", + "reference": "This line is too long" + }, + { + "prediction": "I'm not sure this is the right thing to do. I think we should just log the error and keep going.", + "reference": "This isn't a fatal error, we don't want to crash just because we can't set configs, we have sane defaults set" + }, + { + "prediction": "I'm not sure why this change is necessary, but it seems like it should be.", + "reference": "I wondered why `buffer` was passed into `LookupPath`. What is happening here? Is `buffer[:0]` equivalent to `[]V4TrieEntry{}`, and hence `buffer` isn't needed any more?" + }, + { + "prediction": "I'm not sure about the `:host => SERVER_URL` here. I think it should be `:host => request.host_with_port` or something like that.", + "reference": "I don't really like the name of this file, especially the encoding of an implementation detail (the fact that it's a table) in the name. Can we just use `_message_body.html.erb` instead maybe?" + }, + { + "prediction": "I think this should be `EnableLogging *bool` to be consistent with the other fields.", + "reference": "Feel better not to expose our internal implementation in API/CRD, so no need to mention agent here. Consider: EnableLogging indicates whether or not to generate logs when rules are matched. Default to false." + }, + { + "prediction": "why we need to set the data version to 3.0 here?", + "reference": "use `NebulaKeyUtilsV3::dataVersionValue()` to replace the literal value?" + }, + { + "prediction": "I don't think this is the right thing to do. I think we should be raising an exception here.", + "reference": "No need for the `\\` here, inside parentheses whitespace is ignored by Python." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it makes sense to return an empty string if the certificate is not present.", + "reference": "This doesn't seem like the right expected result... it should be the same as the `clientCert` var defined above." + }, + { + "prediction": "I'm not sure why this was removed, but I think it should be restored.", + "reference": "need to rename this now." + }, + { + "prediction": "I'm not sure this is the right thing to do. I think it would be better to add the missing fields to the `PrivateTransactionReceipt` class in the `org.web3j.protocol.besu.response.privacy` package.", + "reference": "NIT: This shouldn't be a TODO. It is just a note isn't it?" + }, + { + "prediction": "I'm not sure this is the right place to put this warning. I think it should be in the `set_value` method of the `webelem` module.", + "reference": "I changed this to an error, that seems more appropriate than a warning here." + }, + { + "prediction": "I don't think we need to change this part, since we still need to check if the log is a system log or not.", + "reference": "This change could mute unit test failure, but it is better to update unit tests" + }, + { + "prediction": "I think this should be `notificationIdsInUse.remove(notificationId);` instead of `notificationIdsInUse.delete(notificationId);`", + "reference": "All other places that access `notificationIdsInUse` are in methods with descriptive names. We should do the same here. Maybe `markNotificationIdAsFree()`?" + }, + { + "prediction": "I think this should be `NotFoundErr` instead of `ErrNotFound`", + "reference": "keep as `ErrNotFound`, it is the same convention as in other packages" + }, + { + "prediction": "I think this should be `if (offlineMode === true) {` instead of `if (offlineMode) {`", + "reference": "Same here, we need to call `callback` in else branch" + }, + { + "prediction": "I think this is a bug fix. If the host name is null, it should be an empty string, not null.", + "reference": "At this point we already check that the record is valid and so it could never be nulll" + }, + { + "prediction": "Layout/TrailingWhitespace: Trailing whitespace detected.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Layout/Space", + "reference": "Would it not be more sensible just to move setting of the title to later in the method rather than duplicating it here?" + }, + { + "prediction": "uploadSession() should be called in the end of heartBeatThreadFunc()", + "reference": "why not do it in `reclaimExpiredSessions`? and `pushSessionToCache` can delete" + }, + { + "prediction": "Please remove `_base_` and `model` in this file.", + "reference": "out_channels/num_outs/type are unnecessary" + }, + { + "prediction": "I'm not sure what you're trying to do here. `Object.keys(dict).length` is always going to be 0 because `dict` is an empty object.", + "reference": "You can create an issue for it and put it on the backlog so we don't forget it." + }, + { + "prediction": "Shouldn't this be `if validNetworkMode(container.HostConfig)`?", + "reference": "So now we are checking twice, both here and in `weaveCIDRsFromConfig`. Not great. I suggest changing the `ok` return of `weaveCIDRsFromConfig` to a messsage (or error?) instead, which we can then log." + }, + { + "prediction": "I'm not sure this is the right thing to do here. I think we should keep the contents of the package in the database even if we fail to install it, so that we don't have to download it again.", + "reference": "An alternative to setting format to the default in Package.__init__ would be to set it in create_package. I think we can assume all packages are created by create_package, but not necessarily by build_package." + }, + { + "prediction": "I don't think we need this struct. We can just pass the fields directly to the `ProposeBlock` method.", + "reference": "Let's add fee recipient as well." + }, + { + "prediction": "I don't think this is necessary.", + "reference": "No need for those with `super-init-not-called`, as pylint already only turns things off for this function and it's needed for the entire function." + }, + { + "prediction": "I think this should be `APPLICATION_NAME` instead of `applicationName`.", + "reference": "I think there's another spot for this in DefaultCapabilityMatcher" + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "this name seems pretty vague -- thoughts on a more descriptive method name?" + }, + { + "prediction": "I think we should keep the copyright year as 2020.", + "reference": "what changed in this line?" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it's the only way I could think of to get the `reportArgs` object into the `hasData` function.", + "reference": "Instead of doing this let's add another function similar to `hasZeroData` for selecting the `reportArgs` since this is all sourced from selected values. Then `hasZeroData` can use this internally, as well as the component itself. Since this function would be internal just for the purpose of avoiding duplication, we don't need to expose it on the component the same way though." + }, + { + "prediction": "I don't think this is needed anymore.", + "reference": "This line was useful for auto-completion, I think it should be re-added with specifying the var name (`$exception`) and simplifying the FQCN." + }, + { + "prediction": "Why do we need a channel here? Why can't we just return the error from the goroutine?", + "reference": "This looks like you're not collecting everything from the error channel." + }, + { + "prediction": "I'm not sure if we want to use the plan name here. I think we should use the product name instead.", + "reference": "This currently violates the Law of Demeter. Using `checkout.plan_name` is the quick resolution." + }, + { + "prediction": "I don't think this change is necessary.", + "reference": "is there any scenario when `$temporaryFilename` can be null?" + }, + { + "prediction": "Why do we need `@SuppressWarnings(\"ReferenceEquality\")` here?", + "reference": "this is for the `boolean isRoot = root == rowType` check, which seems to be on purpose, but maybe you could double check whether using ref. equality here is still wanted? Same for `SparkTypeToType`" + }, + { + "prediction": "I think this should be done in `roots_drag_icon_update_position` instead of duplicating the code.", + "reference": "No need to damage after `roots_drag_icon_update_position`, this is already done in `roots_drag_icon_update_position`" + }, + { + "prediction": "`device` is not used in this function, please remove it.", + "reference": "Have you tested exporting to ONNX with `device=cuda`?" + }, + { + "prediction": "I think this should be `if o.name != \"\" && o.since != 0 && o.humanStartTime != \"\" {`", + "reference": "Do we also need to validate `envName` flag then? `appName` and `envName` are used in `initLogsSvc` which are called by `svc logs` from within `Execute()`" + }, + { + "prediction": "Shouldn't this be `Request::setTrustedHosts(['^(.+\\.)?' . preg_quote(parse_url($url, PHP_URL_HOST)) . '$']);`?", + "reference": "@LukeTowers I think I would prefer that we don't force it, on the basis that: a) some people would be opting to configure their web server to protect against this kind of attack and would disable this feature in October CMS to get a small performance increase. b) it might be a bit misleading to say that `app.trustedHosts` set to `false` disables the feature entirely, just to have it be overridden here regardless." + }, + { + "prediction": "Shouldn't this be `c.cnpInformer.Informer().GetIndexer().ByIndex(ClusterGroupIndex, cg.Name)`?", + "reference": "i like that you are trying to correct the naming, but its making the PR longer :( i guess in future we can do such changes in separate PRs" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's better to have the test fail than to have it pass with the wrong value.", + "reference": "Are we marking what the browser's accessibility tree says or what screen readers with those browsers say?" + }, + { + "prediction": "Why do we need this?", + "reference": "This method should behave as intended, to block until it reads an EOF from the other side." + }, + { + "prediction": "`Fail to health check repository '%s': %v` -> `Health check failed on repository '%s': %v`", + "reference": "I prefer starts with `Failed to xxx`, how about `Failed to perform health check on xxx`?" + }, + { + "prediction": "I think it would be better to have a single `Tags.AzureAppServicesMetadata` tag that contains all the metadata as a JSON string. That way we don't have to add a new tag every time we add a new metadata field.", + "reference": "All these calls make me think we should refactor how traces are started and allow \"source tags\" that we initialize a trace with. I'd like to do this in a follow up." + }, + { + "prediction": "I'm not sure if this is a bug or not, but I think this should be `v1` instead of `v1_test`.", + "reference": "This file shouldn't be in this PR" + }, + { + "prediction": "I don't think this should be skipped.", + "reference": "This now causes `LessSpecificReturnStatement - src/somefile.php:9:32 - The type 'non-empty-list<5|string>' is more general than the declared return type 'non-empty-list' for takesList`, which seems correct to me. The type `non-empty-list<5|string>` contains the type `non-empty-list`. Thoughts?" + }, + { + "prediction": "I think this should be debug level.", + "reference": "Are you going to change that back?" + }, + { + "prediction": "I think this should be `ifeq (true,$(staticbuild))`", + "reference": "we have a standard format for putting these together elsewhere, it does the filter check first and errors out and then sets based on the value. i think this should be adjusted to do that. there's no logical change, just an approach change." + }, + { + "prediction": "I think this should be `delay` instead of `scale`", + "reference": "Note this should be `delay` instead of `scale` here. I'll fix this in my branch." + }, + { + "prediction": "I think we should keep `this.on` and `this.off` here.", + "reference": "`on` likely still needs a bind, similar to `this.resetProgress = this.resetProgress.bind(this)` correct?" + }, + { + "prediction": "Please remove this line.", + "reference": "Considering the trade-off between training speed and accuracy, multi-scale training is temporarily kept. More elegant implementation will be adopted in the future." + }, + { + "prediction": "nit: please remove this extra blank line", + "reference": "Can you move this up along with the other builtin libraries?" + }, + { + "prediction": "I think it would be better to put this checkbox in the update settings panel, as it is related to the update process.", + "reference": "I actually think it makes sense to reposition this checkbox after the notifyForPendingUpdateCheckBox. The current order of check boxes is a bit arbitrary now." + }, + { + "prediction": "I'm not sure if this is the right place to put this, but I think it would be useful to have a `--help` for the `--checkout_command` flag that explains that the `%s` will be replaced with the revision to check out.", + "reference": "Why do we have both `before` and `after`? Naively I would expect this to work as follows: `plz query changed` with no arguments compares the current working directory state to the last commit (i.e. HEAD, i.e. a noop when directly on a git commit). `plz query changed --since [reflike]` compare the current working directory state to the given reflike. So for CI I would expect to run something like `plz query changed --since @{upstream} (or origin/master I guess)`. And on merge I'd either run everything or just `plz query changed --since HEAD^` (given our workflow) - I don't think I'd ever want to do anything else. Either way I think before and after are slightly confusing terms here." + }, + { + "prediction": "I think this should be `f.server_conn.ip_address and self.re.search(f.server_conn.ip_address[0])`", + "reference": "Is there a reason why we can't use `~dst`? It feels like that could be good enough.I would like to avoid extending the filter syntax unless there's an urgent need. :)" + }, + { + "prediction": "I think it should be `UtcDateTime` instead of `LocalDateTime`", + "reference": "Why local and not UTC?" + }, + { + "prediction": "I don't think this is the right thing to do. If the error code is -2013 or -2012, then the error message should not be generated. If the error code is not -2013 or -2012, then the error message should be generated.", + "reference": "2012 is a retryable error. Will avoiding rgenerating it here cause a difference in behavior in createServer() ?" + }, + { + "prediction": "remove empty line", + "reference": "move to line 14 below" + }, + { + "prediction": "I think \"crosses\" is not the right word here. I think \"intersects\" is the right word here.", + "reference": "the method name should match teh docs" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the right thing to do for now. We don't have any tests for MDv3 yet, and we don't have any tests that use `createNewRMD`, so I don't think this will break anything.", + "reference": "Won't this happen automatically when we flip the default version in the config?" + }, + { + "prediction": "I'm not sure why this changed, but I think it should be reverted.", + "reference": "This would also change back to /var/www/html/docroot if we go that way." + }, + { + "prediction": "I think this should be `hasImplicitRole` instead of `hasImplicitChromiumRoleMatches`", + "reference": "This still needs to use the new option. We'll need tests for it too." + }, + { + "prediction": "I don't think you need to set `shouldAllowIAccessibleFocusEvent` to `True` here. It's already `True` by default.", + "reference": "We are no longer including file name in the source files." + }, + { + "prediction": "Use 2 (not 0) spaces for indenting an expression spanning multiple lines.", + "reference": "no need for this. Devise provides us with `current_user` and `user_signed_in?` helpers." + }, + { + "prediction": "I don't think we need this method. We can just use `capability.getVersion() >= ETH66.getVersion()` directly.", + "reference": "Would `Object.equals(capability.getName(), NAME)` would be safer, as you wouldn't have to do null checks?" + }, + { + "prediction": "Line is too long. [84/80]", + "reference": "Hmm, I wonder if we should revert #1862 instead? BTW, what failure do you get w/o this line?" + }, + { + "prediction": "I think this should be `errors.Wrapf(err, \"invalid 'apiURL' %q in slack config\", out.APIURL)`", + "reference": "since there are several places where we do 1) get secret key ref and 2) validate URL, maybe it's worth having a common method? it could also trim spaces as done here (but not at the other places currently)." + }, + { + "prediction": "I think this test should be updated to use `normalizeToPartialURL` instead of `extendPartialURL`.", + "reference": "TestNormalize... I would also split them" + }, + { + "prediction": "`next()` is a built-in function, not a method of `generator` objects.", + "reference": "All changes to this file are going to conflict with #7599. Please revert these as well. They will be addressed during the Python 3 transition." + }, + { + "prediction": "I'm not sure this is the right fix. I think we should be using `rand.Intn` instead of `r.random.Intn`.", + "reference": "Just thought, using spinlock (busy wait with compare and swap) that generates 2 random numbers inside rlock. We know that collisions are rare and we don't need that \"large\" write lock really but lock namely for \"rand\". Or least use a separate Lock (Mutex), namely for \"rand\" (wrap it into method). Mutex will use some sort of spinlock as well but it may use some linked list to make it more fair." + }, + { + "prediction": "I don't think you need to import `astroid_version` and `pylint_version` here.", + "reference": "Can we grab it directly from `__pkginfo__` as that is the source of truth for the version?" + }, + { + "prediction": "Please remove this empty line.", + "reference": "We can revert this to reduce the diff of the PR." + }, + { + "prediction": "I think this should be `if (isCloud && !protoPkg.contains(\"cloud\")) {`", + "reference": "This looks weird. `isCloud` should define if it is a cloud or no. Here it does it partially, and it can be overriden by protoPkg value (which also an argument to this function). Please make sure that isCloud completely defines the cloud thing. (i.e. it an be as straightforward as moving `protoPkg.contains(\"cloud\")` from here to the place where `assembleGoImportPath` is called." + }, + { + "prediction": "nit: I think it would be better to use `==` instead of `== Lob_Append_Or_Error`.", + "reference": "Declaring fileflags to be of type LobTgtFileFlags would eliminate the need for all this casting. And would be safer. (Not a show-stopper though.)" + }, + { + "prediction": "I think this should be `finest` instead of `info`.", + "reference": "This change prevents a user understanding how their server is configured. Best to leave at `info` level." + }, + { + "prediction": "I think this should be `#if defined(SSL_set_tlsext_host_name) && OPENSSL_VERSION_NUMBER < 0x009080FFL`", + "reference": "Typically we would add something to the build system environment to differentiate this; also is there an alternative that can be used with older OpenSSL? Other folks who are committers will need to decide if it is worth supporting an older and likely quite vulnerable (to hacks) OpenSSL library." + }, + { + "prediction": "I think we should rename this variable to `readActiveBlockProducersByHeightTests`", + "reference": "`readActiveBlockProducersByHeightTests` is a global variable (from `gochecknoglobals`)" + }, + { + "prediction": "I don't think we need to pass `idField` to `saveRecordsToSmartStore`", + "reference": "Falls back on `Constants.ID` if there's no custom field set." + }, + { + "prediction": "I think this should be `in.skipNBytes(this.getOffset());`", + "reference": "I believe this is what we want to rearrange: this in.skip() should not be happening here, in the open method, but in the setOffset() method itself. Because we want to be able to change that offset after the initial open. The setOffset() method will need to throw an IOException, if it's called while the InputStream is still null; or if the skip() call itself results in an IOException()" + }, + { + "prediction": "I think this should be `getReturnType().isPrimitiveType()`", + "reference": "In case the method is `void`, there won't be any children and `getChild(0)` throws. We'll need to check with `isVoid()` for that case. I'll update this when I merge." + }, + { + "prediction": "I think this should be `yarpc.Interceptors{yarpc.InboundInterceptor{requestLogInterceptor{}}}`", + "reference": "If the yarpc.Interceptors wrapper will be added to any user interceptor, why not do it transitively. Can save one step for users. Same apply to filter." + }, + { + "prediction": "I'm not sure if this is the right place to do this, but it seems like a good place to me.", + "reference": "Is there anything we should do in the event we're unable to renaming the directory?" + }, + { + "prediction": "nit: I think it would be good to add a `TODO` here to remove the `TODO` in `pkg/broker/ingress/ingress.go` as well.", + "reference": "How is this env var populated? Can this be retrieved from cluster metadata?" + }, + { + "prediction": "I think this should be `SuccessfulTagInternetGateways` (plural) since we're tagging multiple gateways.", + "reference": "Should probably skip the success event here, since it could be a noop." + }, + { + "prediction": "This should be `item.ImageBlurHashes || {}`", + "reference": "I added this here because people cards (which depends on cardBuilder) had this added in blurhash. Not sure when this is used though cc @JustAMan" + }, + { + "prediction": "I'm not sure why this was removed, but I think it should be restored.", + "reference": "Let's keep this line in the docstring, to let end users know they shouldn't be using this directly." + }, + { + "prediction": "why remove this check?", + "reference": "can do the same for other validateXXX()" + }, + { + "prediction": "I don't think you need to cast away the const here. `participant_` is already a pointer to a `const DomainParticipantImpl`.", + "reference": "Why is this necessary?" + }, + { + "prediction": "This import is not used in this file.", + "reference": "Please move this import upper to other similar imports" + }, + { + "prediction": "I think this should be `IF_ARM(ASSERT_NOT_TESTED(dcontext));` so we know which dcontext is not tested.", + "reference": "Include the key word \"translated\". Otherwise the reader will find this confusing." + }, + { + "prediction": "I'm not sure I understand why this is needed. The `ElasticsearchSpanStore` is not a singleton, it's created for each request.", + "reference": "why. is this called per request? if so this also adds a lock internally. can we not add this at the moment until analyzed as this assumption isnt carried to the several other impls. the only other consumer of this is the http api and that isnt hit often enough for specializations." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to be the only way to get the selected option. The `selected` attribute doesn't seem to be set on the `option` element.", + "reference": "I believe this means dependent checks can no longer operate on virtual nodes, which is something we've been pushing for lately. We may need to find a different way to solve this issue, as I don't think we want to cause a regression while fixing a bug." + }, + { + "prediction": "I don't think it's a good idea to have a `Migrator` as a base class for the storage. It's not a storage, it's a migration tool. I'd rather have a `Migrator` as a separate class that can be used by the storage, but not as a base class.", + "reference": "ditto about use of `abspath`" + }, + { + "prediction": "I'm not sure about this change. I think it makes the code harder to understand, and I don't think it's worth it.", + "reference": "this reduces the runtime by 50 times" + }, + { + "prediction": "I don't think we need a test for this class.", + "reference": "Probably best not to have an empty test...." + }, + { + "prediction": "I'm not sure this is the right thing to do here. I think it would be better to throw an `IllegalStateException` with a message that includes the stack trace of the exception that was thrown when trying to instantiate the exception type.", + "reference": "direct `newInstance` call is also deprecated now" + }, + { + "prediction": "nit: please remove empty line", + "reference": "We have a bit of a convention where imports are split into three blocks: first Go standard library, then imports from outside the repo, then imports from inside the repo." + }, + { + "prediction": "I think this should be `final` to prevent subclasses from overriding it.", + "reference": "Why was this change needed?" + }, + { + "prediction": "I don't think this should be a warning, it should be an exception.", + "reference": "can you use this opportunity to remove `.readlines()` useless list creation? (`addresses = [l for l in fd if l.find(\"netmask\") >= 0]`)" + }, + { + "prediction": "Metrics/LineLength: Line is too long. [123/120]", + "reference": "Why does this check differ from `plan_ssh.rb`?" + }, + { + "prediction": "why remove this import?", + "reference": "File is not `goimports`-ed (from `goimports`)" + }, + { + "prediction": "Why is this removed?", + "reference": "It was @lodejard who initially suggested this pattern. I think that it had something to do about prioritizing future writes even if there was a pending write operation ready to handle the newly requested write. I'm not sure I fully understood the explanation for having up to 3 pending write requests, because only having one queued write at a time still makes sense to me. I'll talk to him about it." + }, + { + "prediction": "I don't think we should have debug options in the command line.", + "reference": "We have cli --online_weight_clear in cli.cpp" + }, + { + "prediction": "I think this should be `strings.SplitN(values[0], \",\", 2)[0]` in case there are multiple addresses in the `X-Forwarded-For` header.", + "reference": "So the request.Headers is a map of []string. Are you sure that the HTTP library doesn't already do this split for us?" + }, + { + "prediction": "I think this should be \"Execution stopped, crashed executor/container\" instead of \"Execution stopped, crashed executor/container\"", + "reference": "How is this message used? Can we remove the \"crashed executor/container\" part which is an implementation detail?" + }, + { + "prediction": "I don't think we need to add this to the `nameToUrl` map. It's only used in the `execute` method, which doesn't seem to use the `nameToUrl` map at all.", + "reference": "Instead of building in routing for a browser-specific command, could you refactor the HttpCommandExecutor to allow arbitrary commands to be registered?" + }, + { + "prediction": "I'm not sure this is the right place for this link. I think it should be in the `watch_video` partial.", + "reference": "Space after `=`." + }, + { + "prediction": "I don't think this is the right place to put the invocation context. The context should be set when the invocation is created, not when it is invoked.", + "reference": "if just need to do something after createInvocation just override and call super first is enough?" + }, + { + "prediction": "I think this should be `it_behaves_like 'a jvm build'`", + "reference": "By the way, I fixed `announce` method (missing `super` call to announce JDK version)" + }, + { + "prediction": "I don't think we need to suppress the warning here. The `contains` method of `SortedSet` takes an `Object` as parameter.", + "reference": "I'm not sure about that... This line can produce ClassCastException if Comparator do not check this." + }, + { + "prediction": "I think this should be `*BareTlfHandle`", + "reference": "There wasn't any special reason for this to return a pointer, right?" + }, + { + "prediction": "I'm not sure if this is the best solution, but it seems to be the only way to make this thread-safe.", + "reference": "Why the need for a `ConcurrentHashMap`?" + }, + { + "prediction": "I think this should be `if (order.by === 'title' && Setting.value('titleNaturalSort')) {`", + "reference": "New code should use strict equality `===`" + }, + { + "prediction": "I'm not sure if this is the best way to test this, but it seems to work.", + "reference": "`expect(resources['Notify[local pid]']['events'][0]['desired_value']).to match(/(\\d+)/)` seems clearer." + }, + { + "prediction": "I don't think we need to pass in `changeMd` anymore.", + "reference": "Removed now-unneeded param." + }, + { + "prediction": "I think this should be `go-filecoin bitswap --help` or `go-filecoin bitswap help`", + "reference": "(NON-blocking, this can be tracked in follow up issue) @anorth @mishmosh is the toplevel getting too crowded? Should we have a `network` grandparent command, or maybe a `stats` command?" + }, + { + "prediction": "I think this should be `Google Analytics` instead of just `Analytics`.", + "reference": "The `_x` function needs to be imported at the top of the file (in addition to `__`)" + }, + { + "prediction": "Why is this change necessary?", + "reference": "This is functionally equivalent to the code it replaces." + }, + { + "prediction": "nit: `ENIType` -> `Type`", + "reference": "can you change the field name here to \"InterfaceAssociationProtocol\"? same for the Config struct in agent/ecscni/types.go. i think it's better to keep the field name consistent between agent and acs payload" + }, + { + "prediction": "I think this should be `Widgets data store: widget tests`.", + "reference": "See above, same for the other cases." + }, + { + "prediction": "I don't think we need to suppress the unchecked warning here.", + "reference": "Shouldn't line 313 be public \\ SettableGauge\\ **settable**Gauge(String name) { ? It would also be good to call it a few times and with differnet types (Long, Integer, String) in the test as well." + }, + { + "prediction": "I don't think we need to disable this.", + "reference": "I would prefer to just fix the occurences of this new check rather than disable them" + }, + { + "prediction": "I think this should be `https://news.google.com/rss?hl=en-US&gl=US&ceid=US:en` instead of `https://news.google.com/news/rss?`", + "reference": "The tests should be fixed in #4841, so this is no longer needed" + }, + { + "prediction": "Why do you need this class?", + "reference": "I think it should been in `SharedKernel` module." + }, + { + "prediction": "I don't think we need to add a new field for this. We can just use the `nginx.ingress.kubernetes.io/whitelist-source-range` annotation.", + "reference": "Can we add some description for this field?" + }, + { + "prediction": "I think this should be `DurationType.class` instead of `TimeType.class`.", + "reference": "Should its name be Time or Duration? I can see them both." + }, + { + "prediction": "nit: I think it would be better to call this `toGRPCOptions` or something like that. `asGRPCOptions` sounds like it's converting something to GRPC options, but it's not. It's creating a slice of `otlpconfig.GRPCOption`s from a slice of `Option`s.", + "reference": "Is this used anywhere?" + }, + { + "prediction": "I think it would be good to add a test for `resource.Empty()` as well.", + "reference": "I believe that you can use `assert` instead of `require` here and in the following lines" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the right thing to do. We don't want to return an error if we find the channel, we want to return an error if we don't find the channel.", + "reference": "In `storagemarket.go` you used `nil` for an unwanted out parameter. Do something consistent (nil seems fine if supported)." + }, + { + "prediction": "Why do we need to export these functions?", + "reference": "is this a new pattern we use in bee? interesting" + }, + { + "prediction": "I'm not sure this is the right thing to do. If the bucket already exists, we should probably return an error.", + "reference": "If you think this PR works, i'll clean this up before resubmitting." + }, + { + "prediction": "what is the meaning of GROUPID and ARTIFACTID?", + "reference": "are you sure you can read version by this artifactid?" + }, + { + "prediction": "I don't think we need this import.", + "reference": "We can get rid of this import then." + }, + { + "prediction": "I don't think we need the `case ROUTER` anymore.", + "reference": "Should we do our own vtable?" + }, + { + "prediction": "Metrics/LineLength: Line is too long. [115/100]", + "reference": "This is the actual fix." + }, + { + "prediction": "I think this should be 30s", + "reference": "If sync has really a negative impact, this is just moving the issue from 10sec to 60sec. Wonder if you should not expose the (auto)sync params so users can decide." + }, + { + "prediction": "I'm not sure this is the right way to do this. I think it would be better to have a `DecodeMapExact` and `DecodeMapCaseInsensitive` method on the `Decoder` interface, and then have the `DecodeMap` method just call `DecodeMapCaseInsensitive` by default.", + "reference": "should be called => will be called" + }, + { + "prediction": "`lastBlockTime.Add(lastBlock.Timestamp().Sub(lastBlockTime) / c.blockInterval * c.blockInterval)` can be simplified to `lastBlockTime.Add(lastBlock.Timestamp().Sub(lastBlockTime) % c.blockInterval)`", + "reference": "not sure whether we should do this. It may cause problem that delegates upgrade their nodes at different time, that they will have different \"last block time\", some use \"commit time\", some use \"block time\". Potential solution: Only use block time after berling, and then delete it in the next version after berling. Open to discussion." + }, + { + "prediction": "I'm not sure this is the right thing to do. If the exception is a `SolrException`, then it's already wrapped in a `SolrException`, so we don't need to wrap it in another `SolrException`.", + "reference": "So one question I have is why is the error coming back from `buildReplicaPositions` not an `Assign.AssignmentException`? Is it because it is wrapped in a `SolrException` from the remote node?" + }, + { + "prediction": "I don't think it's a good idea to hardcode the name of the module here. I think it would be better to use `logger.msg.startswith(\"datatable.rbind(...) {\")` or something like that.", + "reference": "`dt` won't work for some reason?" + }, + { + "prediction": "I don't think we need this change. `os.getenv(\"KOALAS_USAGE_LOGGER\", \"\") != \"\"` is equivalent to `os.getenv(\"KOALAS_USAGE_LOGGER\", None) is not None`.", + "reference": "Is this because \"KOALAS_USAGE_LOGGER\" can be `None` ??" + }, + { + "prediction": "I think it would be better to have these constants in the `EthGasPriceOracle` class, as they are related to it.", + "reference": "I like it but maybe the better name will be EthGasPriceConstants or EthGasPriceEstimatorConstants? but Constants not Config" + }, + { + "prediction": "nit: I think it would be nice to have a `NewController` function that takes a `Constructor` as an argument, so that we don't have to create a `Constructor` just to pass it to `NewController`.", + "reference": "I would inline the constructor as well" + }, + { + "prediction": "`dummyyylval` -> `dummyyylval`", + "reference": "I'm not confident about this..." + }, + { + "prediction": "I think this should be `v1alpha2.SchemeGroupVersion.WithKind(\"CertificateRequest\")`?", + "reference": "There is also `v1alpha1.CertificateRequestKind` I think?" + }, + { + "prediction": "I think this should be `gcpbroker_sender` instead of `sender_gcpbroker`", + "reference": "Can we rename it to make it less confusing? Instead of \"sender-gcpbroker\", maybe name it to \"retryable-sender\"" + }, + { + "prediction": "nit: I think this should be `literal().value().getClass().getSimpleName()` instead of `literal().value().getClass().getName()`.", + "reference": "So looking at the definition of the `literal()` function in this class, it seems it's possible for it to return null. I guess it's not a concern as we would get NPE on the above call at line 136 when trying to call `.to` if `literal()` returned `null` before even getting to this part that calls `literal().value()`, but something I thought I'd bring up. Perhaps something we might follow up on in another issue or possibly I just missed the workflow that makes `literal()`'s result non-null by the time this `bindLiteralOperration` is called." + }, + { + "prediction": "I think this should be `abs(nrmse.getMetric()[\"value\"] - target) < OPFMetricsTest.DELTA`", + "reference": "Why did you break the line? It looks like it is under 80 characters without the break and it is inside parens so no need for backslash anyway" + }, + { + "prediction": "I think it would be better to raise an error here, so that the user knows that they need to install `datatable` in order to use it.", + "reference": "@guolinke Don't you mind to rename this variable to `DATATABLE_INSTALLED`, for the consistency with other variables (for example, there are `PANDAS_INSTALLED` but not `PD_INSTALLED`). Also, `DT` is a little bit confusing: sometimes `dt` is used for `datetime`." + }, + { + "prediction": "I think we can remove the `bold` call here as well.", + "reference": "We're fine with double quotes here. Just for future reference." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's better to return `unknown_internal_yarpc` if the error code is `OK` than to return `OK`.", + "reference": "can we keep this around? We should make sure we can distinguish between properly wrapped errors and \"unwrapped\" errors" + }, + { + "prediction": "I think this should be `if (graphicsPipelineCI.pInputAssemblyState && graphicsPipelineCI.pInputAssemblyState->topology != VK_PRIMITIVE_TOPOLOGY_MAX_ENUM)`", + "reference": "`RecordPipelineShaderStage()` might change `topology_at_rasterizer `, according to shader code, so we should check `pInputAssemblyState `first." + }, + { + "prediction": "I think this should be `const Assets = require('./assets').default;`", + "reference": "Should we just inline the assets here? I can't think of an advantage to having them in a separate file." + }, + { + "prediction": "I'm not sure about the name of this function. `detectStale` sounds like it's going to do something more than just detect stale endpoints. Maybe `detectStaleEndpoints` or `detectStaleEndpointsAndServices`?", + "reference": "detectStaleEndpoints to be more specific?" + }, + { + "prediction": "I'm not sure why this is commented out. Is it because it's not implemented in C++ yet?", + "reference": "Please create a new issue for addressing this (if there isn't one already), so it doesn't get lost." + }, + { + "prediction": "I'm not sure why this is needed, but it seems like it should be fixed in a separate PR.", + "reference": "Nothing was ever coming out of this channel because its already being consumed. Create a new channel here and feed it in HandleNewHead method." + }, + { + "prediction": "`AWS IAM` -> `AWS Identity and Access Management`", + "reference": "AWS Identity and Access Management (IAM)" + }, + { + "prediction": "I don't think we need to log this at `FINE` level. I think `INFO` is fine.", + "reference": "This is deliberately at this level." + }, + { + "prediction": "I don't think we need to do this here. We can just pass `args[2]` to the `hex.DecodeString` function.", + "reference": "payload entered on command line is in hex-encoded format should use same processing as in ioctl/cmd/action/actiontransfer.go" + }, + { + "prediction": "I think it would be better to create a new method `getPricingGroupByDomainIdAndName` in `PricingGroupFacade` and use it instead of `getByDomainId` and `reset`.", + "reference": "should this be kept in the `else` branch?" + }, + { + "prediction": "Can you move this to the top of the file?", + "reference": "Why not put this below \"strings\"?" + }, + { + "prediction": "I think this should be `public int UvPipeCount => _dispatchPipes.Count;`", + "reference": "Make it `internal` if it's just for testing." + }, + { + "prediction": "I don't think we need this anymore.", + "reference": "What is triggering this message in this file?" + }, + { + "prediction": "Why is this change needed? I don't think it's related to this PR.", + "reference": "Are you sure this should be removed?" + }, + { + "prediction": "I don't think this is a good idea to have a default value here. I think it should be `null` and we should check for `null` in the `createSocket` method.", + "reference": "What's that good for? The field is initialized in the constructor." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to fix the issue for me. I'm not sure if there's a better way to do this.", + "reference": "This shouldn't be necessary (same below). Do you have a traceback for me?" + }, + { + "prediction": "nit: please remove the empty line.", + "reference": "No newline needed here." + }, + { + "prediction": "nit: remove extra blank line", + "reference": "Why a separate block?" + }, + { + "prediction": "I don't think this is needed.", + "reference": "Probably better to ask @AssadHashmi or another AArch64 expert for a review rather than me -- @AssadHashmi if you could confirm that these status registers are 64-bit despite having only a few fields?" + }, + { + "prediction": "I don't think we need to pass `segwit` to this function, it's always going to be `False` for us.", + "reference": "`purpose` and `coin_type` and `account` would mimic the BIP-0044 wording, but it's up to you." + }, + { + "prediction": "I think this should be `rbQValue01.Checked = true;` instead of `rbQValue01.Select();`", + "reference": "Is this the critical change? It does seem wrong to use Select() instead of Checked = true. Not sure why that would pass sometimes and not others, though." + }, + { + "prediction": "I think this should be 4, 2, and 16 respectively.", + "reference": "Seems a little low, but is this an installer default?" + }, + { + "prediction": "I don't understand why this is needed. Can you explain a bit more?", + "reference": "Maybe we could provide our own `configure` function that includes `logger._logger = None` because I don't see a use case in kinto for using `reset_logger` besides configuring the logger." + }, + { + "prediction": "I'm not sure if this is a good idea, but I think we should be able to get rid of `ParentWeightNum` and `ParentWeightDenom` and just use `ParentWeight`.", + "reference": "This will cause the same breakage that was caused when we added Proof to Block. Be sure to let people (infra?) know ahead of time" + }, + { + "prediction": "I'm not sure why this was changed. I don't think it should be removed.", + "reference": "Fixed the test; @strib want to validate that this is okay? Seems to be consistent new GC behavior." + }, + { + "prediction": "Shouldn't this be `subdom` instead of `subdoom`?", + "reference": "Afaict, nothing cares" + }, + { + "prediction": "I'm not sure this is true. I think we still need to re-embed the block changes in minimal mode, because we don't have a node cache, so we don't know if the block changes are already embedded or not.", + "reference": "I must be missing something, but why does not having a node cache imply not neededing to re-embed the block changes, in particular? Isn't it just the fact that we don't do any writes?" + }, + { + "prediction": "I think this should be `readonly` as well.", + "reference": "Are these changes from `class` to `struct` breaking if called from an older version of `Datadog.Trace.ClrProfiler.Managed`?" + }, + { + "prediction": "This import is not used.", + "reference": "These are just aliases now" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the right thing to do.", + "reference": "Does this mean we can remove `raw` from `_head_contents` partial?" + }, + { + "prediction": "I think you can just use `!this.splashWindow.isDestroyed`", + "reference": "`isDestroyed` is a function, not a property. This condition will always return false." + }, + { + "prediction": "I think this should be `Version_2_0_0` and `Version_2_1_0`", + "reference": "Why are we adding these versions?" + }, + { + "prediction": "I think this should be `str(user.user_id)` instead of `str(user)`.", + "reference": "fyi, you can do this by doing `.info(\"string %s %s\", formatparam, formatparam2)` instead of doing a string format with `\"str\" % (params)` the idea is that it'll only do the string interpolation if logging is enabled for this level, which theoretically is an optimisation, but in this case probably isn't important" + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it seems to work.", + "reference": "Would this work, as a one liner? `setTimeout(window.location.reload, 5000);`" + }, + { + "prediction": "I think we can remove the empty line here.", + "reference": "Can you move `crypto/tls` into the block at the top with all the other stdlib imports?" + }, + { + "prediction": "I think this should be `inferenceElement='multiStepBestPredictions'`", + "reference": "What is the motivation for this change?" + }, + { + "prediction": "I'm not sure I understand the difference between \"transient failure\" and \"service returns no messages for some other reason\". Can you give an example of each?", + "reference": "OK, so the concrete implementation will loop? But then it's important that this method waits for a while before it returns no messages. To be specific, a GCP implementation that set `ReturnImmediately` to true or false would both satisfy this requirement, but the first would cause busy-waiting." + }, + { + "prediction": "I think this should be `if (matchClause->path()->pathSize() > 0) { return Status::SemanticError(\"Multi paths not supported.\"); }`", + "reference": "The data structure of `MatchClauseContext` may need to be redesigned." + }, + { + "prediction": "I'm not sure this is the best way to do this, but it seems to work.", + "reference": "You say on the issue that something has to be receiving while the messages are being published. But here it's possible that the publish goroutine starts, and maybe even completes, before Receive is ever called." + }, + { + "prediction": "Metrics/LineLength: Line is too long. [123/120]", + "reference": "how do we know that the step in question is an approval type step?" + }, + { + "prediction": "I don't think this import is needed.", + "reference": "JMX offers normal APIs for this. I don't think you want the glassfish one." + }, + { + "prediction": "Why do we need to export `io.vavr.control`?", + "reference": "Is this still Java 8 compatible? @danieldietrich do we need a separate, modularized Java 9 release also?" + }, + { + "prediction": "I don't think this is correct. If the texture is not normalized, then the address mode should be CLAMP_TO_EDGE. If the texture is normalized, then the address mode should be CLAMP_TO_BORDER.", + "reference": "Should update the user input address and filter modes and pass those in fillSamplerDescriptor ?" + }, + { + "prediction": "Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.", + "reference": "This object should be in `lib/music/show.rb` and you should also wrap this object in the `Faker::Music::Show`." + }, + { + "prediction": "I think this should be `if task.supports_noop && executor.noop` so that we don't set `_noop` if the task doesn't support it.", + "reference": "I think logic will have to move to bolt since the vague discussions around bolt run plan --noop is that it would just skip any tasks that don't support_noop rather than error. This is fine until we actually elaborate that though." + }, + { + "prediction": "remove empty line", + "reference": "File is not `goimports`-ed" + }, + { + "prediction": "Shouldn't this be a 403 as well?", + "reference": "why should unknown raise a 403?" + }, + { + "prediction": "`c._nextState == c.state` should be `c._nextState === c.state`", + "reference": "The true clause of your condition, can't this just be c._nextState since `assign({}, c._nextState)` is equal to returning c._nextState, or am I misunderstanding something here?" + }, + { + "prediction": "nit: missing space after `+`", + "reference": "nit: align the leftmost quotes" + }, + { + "prediction": "I think this should be `ClusterMembershipPort` instead of `ClusterPort`.", + "reference": "Probably \"server port\" -> \"TCP port\"" + }, + { + "prediction": "I don't think we need to change the name of the codec here.", + "reference": "can you use FilterCodec instead?" + }, + { + "prediction": "I think this should be `true` instead of `false`.", + "reference": "I know there's only two values but I find it a bit confusing that it's true/false. Could you change it to a string enum with values \"portrait\" and \"landscape\"? Then when calling printToPdf you can just do `landscape: Setting.value('export.pdfPageOrientation') === 'landscape'`" + }, + { + "prediction": "This migration is no-op, but it forces the migration mechanism to apply it and thus write the DB schema version info.", + "reference": "I think this migration should fail for MDBX if it uses old table names" + }, + { + "prediction": "Shouldn't this be `@options[:hosts_file].nil? || File.exist?(@options[:hosts_file])`?", + "reference": "Should this be negated? `!@options[:hosts_file].nil?` Otherwise it'll enter the `if` statement and `nil` will be passed to `HostsFileParser.parse_hosts_file`, which I'm assuming is bad." + }, + { + "prediction": "I think this should be `public static ISetupBuilder LoadConfiguration(this ISetupBuilder setupBuilder, bool applyOnReload = true, Action configBuilder)`", + "reference": "I'm doubting if adding a bool here is a good idea. Maybe it should be an option object? Otherwise it's hard to extend. But an option object is a bit strange in a fluent API? What do you think @snakefoot ?" + }, + { + "prediction": "I don't think we need to make this public.", + "reference": "This is used in o.a.l.sandbox.search.PhraseWildcardQuery." + }, + { + "prediction": "I don't think we need to pass the protocol view to the stateDB. The stateDB should be able to get the protocol view from the blockchain.", + "reference": "view should be loaded on start for both statedb and factory" + }, + { + "prediction": "I think this should be `private Task _readInputTask;` instead of `private Task _readInputTask;`", + "reference": "Why rename? Just curious..." + }, + { + "prediction": "I don't think we need to do this here. The `onStopTrackingTouch` is called when the user releases the seekbar, so the controls should already be visible at that point.", + "reference": "Is this needed? I think it calls the super function that already does that." + }, + { + "prediction": "Why do we need to repeat bboxes here?", + "reference": "This might slow down the inference time, are we sure we need to do that?" + }, + { + "prediction": "I'm not sure if this is the right way to do it, but it seems to work.", + "reference": "This would read better if you add \"Skip code/lines\" or (exclude/hide code if you follow my earlier suggestion\")" + }, + { + "prediction": "Looks like this is a copy-paste error.", + "reference": "Looks like glassfish went a bit nuts doing a refactor" + }, + { + "prediction": "I think this should be `public override Task ForceFlushAsync(CancellationToken cancellationToken) => Task.CompletedTask;`", + "reference": "nit: allocate the list using the number of processors." + }, + { + "prediction": "nit: `initializedClasses` -> `javaClasses`", + "reference": "Was this change triggered by baseline?" + }, + { + "prediction": "`arel_table[:thirty_day_commit_count].gt(0).and(arel_table[:affiliate_count].gt(0))`", + "reference": "This code was doing nothing as far as I can tell and was making the SQL find nothing with the new version of Rails. Remove it unless someone can explain why it is there." + }, + { + "prediction": "Why is this needed? I don't think it should be enabled by default.", + "reference": "Setting browser based login as the default for `RestAPIExplorer`." + }, + { + "prediction": "I don't think we need to resize the buffer every time. We can resize it once at the beginning of `FindBestSplitsFromHistograms` and reuse it.", + "reference": "maybe we can do this in Init function?" + }, + { + "prediction": "I think this should be `errRequestIDTooLong` instead of `errRequestIDNotSet`.", + "reference": "How about if request ID not set, service should generate a random uuid?" + }, + { + "prediction": "nit: I think we can remove the `nil` arguments here.", + "reference": "minor: this is an opportunity for you to split these long lines into multiple lines :)" + }, + { + "prediction": "why not `except Exception as e: raise TaurusConfigError(\"Wrong request:\\n %s\" % req) from e`?", + "reference": "It would be nice to have exception dumped somewhere (debug logs, info logs)." + }, + { + "prediction": "I think this should be `MessageAs(m *Message, i interface{}) bool` instead of `MessageAs(m Message, i interface{}) bool`.", + "reference": "So I don't think this is right, as discussed on #657." + }, + { + "prediction": "I think this should be `WHERE group_id = \"{0}\" and member_status = \"ACTIVE\"`", + "reference": "should the group_id = \"{0}\" be group_id = %s You'd still keep the {} for the group_members_{} for the tablename but make the filter clause parameterized." + }, + { + "prediction": "I don't think it's a good idea to add this check here. I think it should be done in `get_full_path` instead.", + "reference": "Path can contain variable pattern in the middle. Also, `$` is not enough to tell if this is JMeter variable. We have correct variable detecting somewhere in our code." + }, + { + "prediction": "This should be `staticMethodOptions`", + "reference": "@bennothommo can you revert this section? It shouldn't be required." + }, + { + "prediction": "Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", + "reference": "Minor: maybe move the above to a `#fiscal_year` method?" + }, + { + "prediction": "I think it would be good to have a test that checks the contents of the `build.yml` file to make sure it's what we expect it to be.", + "reference": "You should use the current directory instead - it's a temporary directory that will get removed when the test is done." + }, + { + "prediction": "I'm not sure why this was changed, but I don't think it should have been.", + "reference": "I think we don't need synchronization here." + }, + { + "prediction": "I don't think this is correct. If the user is not authenticated, then the `registrationId` will be `null` and the error message should reflect that.", + "reference": "I don't think this should be changed since on the reactive side we don't support anonymous users." + }, + { + "prediction": "Style/UnlessElse: Favor unless over negated if with a negating operator.", + "reference": "Maybe this `if` should be on line 118?" + }, + { + "prediction": "Why is this a float64 and not an int64?", + "reference": "Cool. (I thought I had fixed this already in #812.)" + }, + { + "prediction": "I think this should be `interpreters: []` instead of `interpreters: nil`.", + "reference": "I intend to do this as soon as I have tests passing." + }, + { + "prediction": "I think this should be `sys.stdin.close()` instead of `sys.stdin.read()`.", + "reference": "Please remove the `test_*` from the filename - otherwise pytest will try to collect tests from it." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but it seems to work for me.", + "reference": "Did you file a bug to follow up on this?" + }, + { + "prediction": "nit: I think we can remove the `!batchReadsSparkSessionConf ? false :` part and just do `batchReadsEnabledTableProp`.", + "reference": "Looks like these 4 lines didn't actually change. Can you revert the whitespace changes here?" + }, + { + "prediction": "Trailing whitespace detected.", + "reference": "This can't be merged with any usage of `require 'pathname'` in lib, it's not always available and we don't want false positives for people (where they don't realise they needed to requite it). Its also unnecessary, no other formatter uses it to look up failure locations. See the exception presenter etc for how we format lines." + }, + { + "prediction": "I think this should be a separate test, not part of this one.", + "reference": "It would be nice to fix the indentation above." + }, + { + "prediction": "`short_names` is optional, so it should be `bool|null`.", + "reference": "`short_names` is still optional, so `=` that indicates it has to stay there." + }, + { + "prediction": "I think this should be `appendNameOnlyAttribute(capabilities, attributePrefix+capabilityEFS)` instead of `appendNameOnlyAttribute(capabilities, attributePrefix+capabilityEFS)`", + "reference": "missing calling of this method" + }, + { + "prediction": "nit: can we rename this to `archer` to be consistent with the rest of the package?", + "reference": "We could get rid of this dependency being forced on clients by changing the `StackConfiguration` interface abstraction to deal with strings instead of `cloudformation.Parameters` and `cloudformation.Tags`, and internally to the `cloudformation` package translate the input strings into the `service/cloudformation` package specific values hiding that from consumers. I don't think that should be taken on as part of this PR, but I think we should consider doing it at some point." + }, + { + "prediction": "I don't think we need to add `action` and `duration` here.", + "reference": "`StressChaos` does not contains a field .spec.action" + }, + { + "prediction": "I think it would be good to add a test case for this as well.", + "reference": "Non-int literal strings are no longer coercible to int, I think this is an improvement. Without this change it now reports `InvalidArgument`." + }, + { + "prediction": "This macro is already defined in layer_validation_tests.h.", + "reference": "I this used anyplace?" + }, + { + "prediction": "Why is this change needed?", + "reference": "Why was this change required?" + }, + { + "prediction": "`missingAdminRole` -> `isMissingAdminRole`", + "reference": "I like that we have this attribute here. However, I think the way we use it right now might be confusing in the future. For example, when only camunda admin is checked, this exception will be instantiated with a message and `missingAdminRole` is `false`. I think that is counter-intuitive. I would expect this exception to have `missingAdminRole` set to `true`. With this explicit information, the exception message could now be generated inside this exception class with the text block that is currently used in the authorization manager. We could maybe generally reuse that text block then also for the case where a user is no admin and also has none of the required permissions. I haven't tried it myself but I think it would be great if we could streamline those things a bit more if we're working on it now. Let me know what you think." + }, + { + "prediction": "I think this should be `getSizePrefixedRootAsMonster(ByteBuffer _psbb, Monster obj) { ByteBuffer _bb = _psbb.slice(); _bb.order(ByteOrder.LITTLE_ENDIAN); _bb.position(4); return getRootAsMonster(_bb, obj); }`", + "reference": "Not sure why we're creating a new `ByteBuffer` here, ideally this refers to the existing one?" + }, + { + "prediction": "I think we can remove `DATE_RANGE_OFFSET` from `constants.js` as it's only used here.", + "reference": "Same here re: `STORE_NAME` to `MODULES_SEARCH_CONSOLE`." + }, + { + "prediction": "I think this should be `999` instead of `9999`.", + "reference": "I could've sworn I got a `403` myself when I got that response locally. Is `200` what the API would send back for a `permission: false` tag?" + }, + { + "prediction": "I think this should be `KeyStoreManager` instead of `KeystoreManager`", + "reference": "This attribute was intentionally private. - lets force usage of factory `NewIdentityManager()` - lets ramake to `NewIdentityManager(keydir string)` -> `NewIdentityManager(keystore keystoreManager)`" + }, + { + "prediction": "I think we should make this configurable.", + "reference": "Is this too frequent?" + }, + { + "prediction": "I think this should be `['csv', 'zip']` to be consistent with the rest of the code.", + "reference": "will this not make it possible to use a zip file, e.g. on other importers who do not have to support it ?" + }, + { + "prediction": "nit: please remove the extra blank line here.", + "reference": "Needs to be mentioned in `__all__` below." + }, + { + "prediction": "I'm not sure this is the right place for this function. I think it should be in signal.c, but I'm not sure if it should be public or not.", + "reference": "What if the app's signal handler, executed at pre-syscall for epoll_pwait, executes its own epoll_pwait? For that matter: what happens natively if that happens? I would not expect the kernel to keep a stack -- does that clobber the kernel's stored pre-syscall mask?" + }, + { + "prediction": "It is important that the returned list is sorted in ascending order. -> It is important that the returned list is sorted in ascending order.", + "reference": "Nit: missing a space. I think we should phrase the new content a little differently. \"It is important\" isn't very clear. I think it should be \"offsets will be returned in sorted order.\"" + }, + { + "prediction": "I think we can remove this import.", + "reference": "Can you remove this blank line and put the added import in sorted order (likely your editor will do this)" + }, + { + "prediction": "nitpick: `pthread_create` returns `0` on success, so this should be `if (err != 0) { ... } else { ... }`", + "reference": "Even if `pthread_create()` for `ocsp_updater_thread()` fails, `h2o` can continue to serve. But I'm a little worried whether `h2o` should continue to serve in this case. How about you?" + }, + { + "prediction": "I think it would be better to move these constants to `constants.js` and export them from there. That way they can be used in other files as well.", + "reference": "I like introduction of these constants for account/container creation, but the `ACCOUNT_CHOOSE` one isn't needed I think. This should instead be an \"empty\" value (either `''` or `0`), to indicate more clearly that this field is not filled. It should be the same for choosing a container." + }, + { + "prediction": "I think this should be called `localeCompare` instead of `compareStrings` since that's what it is doing.", + "reference": "I noticed that passing in `[]` for the locales argument instead of 'undefined' seems to have the same effect. I think that's preferred over passing in `undefined` as a value, and unfortunately passing in `null` seems to throw an error." + }, + { + "prediction": "I think you can use `strings.SplitN(DbCfg.Host, \":\", 2)` instead of `strings.Contains(DbCfg.Host, \":\") && !strings.HasSuffix(DbCfg.Host, \"]\")`", + "reference": "1. `0` is redundant. 2. We should save result of `strings.LastIndex(DbCfg.Host, \":\")` to a variable and reuse." + }, + { + "prediction": "I'm not sure this is the right place to put this flag. I think it would be better to have it in the `ServerOptions` struct.", + "reference": "Do you envision \"new\" servers not supporting header, or is it more a way to test mix of old and new? If so, we could make it a \"private\" (non exported) option." + }, + { + "prediction": "I think this should be `failed to unmarshal session config`", + "reference": "For future reference. Try not to do refactoring in the same PR which solves some bug or implements some feature. Not to clutter reading. Do it in separate PR." + }, + { + "prediction": "I think we should keep `asset` as the flag name, and just update the help text to say \"Unit name of the asset to look up\"", + "reference": "I'm not sure about changing the flag name. unit is more accurate, but for I think for most people asset is also a fine name to use." + }, + { + "prediction": "I'm not sure this is the right way to do this, but it seems to work for me.", + "reference": "Which windows gets activated? A random other window?" + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in the `Send` method of the transport.", + "reference": "Just to make sure, this is totally lossless? If I put a v2 there, then it gets upgraded to v3, but my function expects v2, then this is fine and nothing is lost?" + }, + { + "prediction": "I think this should be `long WATERMARK_VALUE_DEFAULT = -1L;`", + "reference": "In the past, we have 3 Flink streaming jobs (1 for each AWS region) writing to the same table. We need to write to 3 different watermark table properties (1 for each region). Watermark consumer then use the min value to determine the overall table watermark. A provider pattern similar to `WRITE_LOCATION_PROVIDER_IMPL` can work. A default impl could be a single property name. not sure if there is a simpler way to achieve this." + }, + { + "prediction": "I think this should be `map[keybase1.UID]keybase1.NormalizedUsername`", + "reference": "Can you change this to `ResolvedUsersMap` and build a new map with both readers/writers? That way, we get the nice side effect of not exposing the internal map of the handle, and simplifying the callers a bit." + }, + { + "prediction": "I think this should be `||` instead of `!= null`", + "reference": "I typically try to avoid nested ternary expressions. Can we rewrite this as if statements? Worst case, can we break it out into its own function?" + }, + { + "prediction": "I think this should be `tls_start.ssl_conn.set_tlsext_host_name(tls_start.context.client.sni.encode('utf-8'))`", + "reference": "Do we still support handshakes without SNI present?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I don't think we should be using `warn` here. I think we should be using `logger.warn` instead.", + "reference": "Maybe it's because I work too much on a centralized logging system but it could be great to add a \"category\" like \"attribute\", \"substitution\", \"include directive\", \"macro\", \"extension\"..." + }, + { + "prediction": "I think this should be \"it has no sense in python\"", + "reference": "it have no sense in python -> it makes no sense in python" + }, + { + "prediction": "I don't think we need to add this method to the interface. It's only used in one place, so we can just add it to the implementation of `ServicePortSupplier` in this file.", + "reference": "maybe just do a separate implementation of the pool for openvpn case? It's a bit confusing having two methods here." + }, + { + "prediction": "I'm not sure if this is the right thing to do. I think we should be able to call `topology.close()` even if `topology` is `null` or `undefined`.", + "reference": "how is it possible to have a `topology` that is falsey when we had to call `topology.connect` in order to get here?" + }, + { + "prediction": "Use the new Ruby 1.9 hash syntax.", + "reference": "Do we need this expectation? If we don't call this method on `PlanFinder` there's no way for the `10` to be returned. Seems somewhat redundant. What do you think?" + }, + { + "prediction": "I think we should keep the `DriverName` and `AliasName` in the `DataBase` struct.", + "reference": "We need to do the same for edgecore" + }, + { + "prediction": "Can we use `Task.Delay` instead of `AutoResetEvent`?", + "reference": "This fix has nothing to do with the product change. Just a fix I am making for the test issue." + }, + { + "prediction": "I don't think we should do this yet. We need to make sure that the BatchingActivityProcessor is ready for production use before we enable it by default.", + "reference": "Don't know what should be the default. Lets keep BatchingProcessor for now. And revisit the area after beta." + }, + { + "prediction": "I think we can remove the `require 'rspec/support/reentrant_mutex'` from `lib/rspec/core/example_group.rb` and `lib/rspec/core/example.rb` as well.", + "reference": "Ah that's how it's happening, it's probably using the `require_relative` in the optimised one and that counts as a different require to the bare one." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it should be done in the `RegisterNibForCellReuse` method of the `MvxSimpleTableViewSource` class.", + "reference": "What happens if there is no NIB/XIB with that name?" + }, + { + "prediction": "I think we should rename `cfg` to `apiCfg` to make it clear that this is the config for the API server.", + "reference": "this is not necessary?" + }, + { + "prediction": "nit: I think it's better to put asmsecretres before ssmsecretres.", + "reference": "typo: `asmsecrets \"github...`" + }, + { + "prediction": "Shouldn't this be `wp_json_encode( $decoded )`?", + "reference": "I think that the JSON encoding should be handled by the control itself, not the sanitization function. This should only confirm that the input is correct, not reformat it" + }, + { + "prediction": "I don't think we need this method.", + "reference": "Should we put a TODO here to route the http.Transport through here?" + }, + { + "prediction": "Why do we need to specify the computer name here?", + "reference": "Sorry, could you explain more about the issue? Doesn't ComputerName already default to local computer? > -ComputerName Specifies one or more Hyper-V hosts on which the virtual switch is to be configured. NetBIOS names, IP addresses, and fully qualified domain names are allowable. The default is the local computer. Use localhost or a dot (.) to specify the local computer explicitly." + }, + { + "prediction": "I think this should be `if err != nil && !allowError {` instead of `if err != nil && allowError {`", + "reference": "`allowError` is a big vague. Does this mean the test case is asserting that an error should occur? If it means \"maybe an error can occur, and that's okay\" -- what's an example of this?" + }, + { + "prediction": "I don't think this is the right place to put this error. I think it should be in the `xrc20Contract` function.", + "reference": "return statements should not be cuddled if block has more than two lines (from `wsl`)" + }, + { + "prediction": "I don't think we need to implement `Metric` for this class.", + "reference": "Why does VirtualMachineMetrics have to implement Metric?" + }, + { + "prediction": "I think this test should be updated to use the new `SignVote` method.", + "reference": "line is 121 characters" + }, + { + "prediction": "I think this should be `name[0] === 'o' && name[1] === 'n' && name[2] !== 'c'`", + "reference": "How's that linked esbench looking with slice?" + }, + { + "prediction": "I'm not sure this is correct. `nlst` returns the list of files in the given directory, not the list of directories in the given directory. If you want to get the list of directories in the given directory, you should use `listdir` instead of `nlst`.", + "reference": "The split and join was probably done to ensure that this still works on Windows because os.path.dirname works differently depending on the os you're running under :(. It would probably be a little better to do `dirname, _, fn = path.rpartition('/')` if you want something cleaner than the split/join." + }, + { + "prediction": "I think this should be `return sessions.size();`", + "reference": "This is not the right approach. The `Distributor` maintains a model of the current state of the Grid. That model already contains the information about every active session. We don't need to modify `SessionMap` to expose it further." + }, + { + "prediction": "I think this should be `s.maybeResetTimer(time.Time{})` instead of `s.maybeResetTimer(pacingDeadline)`.", + "reference": "Can you make this a member var as all the other deadlines? Then you can drop the param to resetTimer() and simplify some of the code below iiuc." + }, + { + "prediction": "I'm not sure about this change. I think it should be `std::unique_ptr res{te.canonicalize(std::move(*mol))};` or `std::unique_ptr res{te.canonicalize(std::move(mol))};`", + "reference": "I don't understand the reason for the changes from unique_ptr to ROMOL_SPTR that you made in this file. The pointers aren't being shared or used elsewhere so I don't think there's any reason to make them shared. Did I miss something?" + }, + { + "prediction": "I think this should be `PLUGINS` instead of `PLUGIN`", + "reference": "why change the variable name at all?" + }, + { + "prediction": "I think this should be `if (vNode.actualNode === node) { return vNode; }` instead of `if (vNode.actualNode === node) { return vNode; }`", + "reference": "Since I'm still trying to keep these straight in my head, can you elaborate on what problem this solves?" + }, + { + "prediction": "I don't think we need this try/catch. If `mAccount` is null, then `mAccount.getReportSpamRecipient()` will throw an NPE.", + "reference": "Prefer TextUtils.isEmpty() which handles getReportSpamRecipient() being null" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's better to return `nil` if we can't find the extension id, rather than raising an exception.", + "reference": "Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else." + }, + { + "prediction": "I think this should be `d.GetValues(\"Include\")` and `d.GetValues(\"Exclude\")` instead of `d.GetValueList(\"Include\")` and `d.GetValueList(\"Exclude\")`.", + "reference": "Do we actually use Include anywhere yet or is this just for completion?" + }, + { + "prediction": "I think this should be `SettingValue(typ.Referer(none_ok=True), 'same-domain')`", + "reference": "It still bugs me this was misspelled in the standard and now the wrong spelling is the commonly used one :wink:" + }, + { + "prediction": "I'm not sure why this change is necessary.", + "reference": "seems we missed de-uglifying this one" + }, + { + "prediction": "I think this should be `NewWorkflow` instead of `NewWorkflowType`.", + "reference": "i guess these types & cron / retry specific belong to a dedicated util / struct" + }, + { + "prediction": "I don't think we need to join the keys here. The server will do that for us.", + "reference": "Also update line 2205 below" + }, + { + "prediction": "I think this should be `default: \"horizontal\"`", + "reference": "`direction` is referenced nowhere. Do I miss something?" + }, + { + "prediction": "I think we can remove this now that we're not using `deparam` anymore.", + "reference": "The two places this was used have been removed so we can fully remove this dependency." + }, + { + "prediction": "I don't think we need to generate this file anymore.", + "reference": "This is a duplicate generation of the same file as below." + }, + { + "prediction": "`cfg.gpus` should be `len(gpu_ids)`", + "reference": "We may deprecate `gpus` if `gpu_ids` is specified." + }, + { + "prediction": "I think this should be `finer` instead of `finest`.", + "reference": "Right now this is experimental and deeply flaky. We left this at `info` to make debugging user reports a lot easier." + }, + { + "prediction": "I'm not sure what this is doing. Can you explain?", + "reference": "unnecessary spaces here are doubling the size of this otherwise extremely useful addition" + }, + { + "prediction": "I'm not sure if this is the right thing to do. I think we want to overwrite if newer, but I don't think we want to overwrite if newer if it's the same file. I think we want to overwrite if newer if it's the same file, but not overwrite if newer if it's a different file. I think we want to overwrite if newer if it's a different file, but not overwrite if newer if it's the same file. I think we want to overwrite if newer if it's the same file, but not overwrite if newer if it's a different file. I think we want to overwrite if newer if it's a different file, but not overwrite if newer if it's the same file. I think we want to overwrite if newer if it's a different file, but not overwrite if newer if it's the same file. I think we want to overwrite if newer if it's a different file, but not overwrite if newer if it's the same file. I think we want to overwrite if newer if it's a different file, but not overwrite if newer if it's the same file. I think we want to overwrite if newer if it's a different file, but not overwrite if newer if it's the same file.", + "reference": "I think we should use `FileExistsPolicy.Overwrite` instead. Files _should_ always be newer, but in the unlikely case they wouldn't be, I'm afraid some files would be overwritten and other not, leading to inconsistencies that will be hard to figure out." + }, + { + "prediction": "I think this should be `test3_6`", + "reference": "this should probably be removed" + }, + { + "prediction": "I'm not sure why this change is necessary. I don't see any changes to the output of `json.MarshalIndent` in the diff.", + "reference": "Nit: I would actually prefer that pretty JSON is the default, with a flag for compressed JSON. Can we acheive that easily?" + }, + { + "prediction": "I think this should be a `map[SecurityGroupRole]map[string]IngressRules` so that we can have multiple ingress rules for each role.", + "reference": "Will need to think about this one. `additionalIngressRules` feels a bit opaque in terms of eventual outcome." + }, + { + "prediction": "I think this should be `private static int fieldId(TypeDescription orcType) {`", + "reference": "Can we avoid making this public with the other updates?" + }, + { + "prediction": "I think this should be `CHECK_GE` instead of `CHECK_EQ`.", + "reference": "Why did you change this equal instead of less or equal?" + }, + { + "prediction": "I don't think we need to pass `blockHash` to `isWorldStateAvailable` and `getMutable`", + "reference": "missing final for the blockHash field" + }, + { + "prediction": "Metrics/LineLength: Line is too long. [121/120]", + "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." + }, + { + "prediction": "`expand_as` should be FP32 as well.", + "reference": "`x_float` instead of `float_x`." + }, + { + "prediction": "I don't think this is needed.", + "reference": "Is this for `No Babel config ...` from ESLint? If so, it will be fixed in my ES6 PR." + }, + { + "prediction": "I think this should be `t.Fatal(err)`, not `t.Fatal(err.Error())`.", + "reference": "Not important, but the code used to keep checking other cases even after one of them failed, and now it's not. Fine either way for me, just noticing." + }, + { + "prediction": "nit: I think this should be `import \"github.com/docker/docker/api/types\"` instead of `import \"github.com/docker/docker/api/types\"`", + "reference": "I think I saw this line in last PR, you can update your base branch and rebase to avoid this. And it would be awesome if you can rebase instead of merge each time you push PR to the `moby` branch, that will make the commits history clearer." + }, + { + "prediction": "nit: I think this should be `LOG(THREAD, LOG_SYSCALLS|LOG_THREADS, IF_DGCDIAG_ELSE(1, 2), \"syscall: NtSetContextThread handle=\"PFX\" tid=%d cxt->Xip=\"PFX\" flags=\"PFX\"\\n\", thread_handle, tid, cxt->CXT_XIP, cxt->ContextFlags);`", + "reference": "If this can change the PC of this thread, it requires handling: we can't blindly execute the syscall and lose control of the thread when the flags include CONTEXT_CONTROL. (Note that most docs imply that setting your own context this way is not supported or has undefined or unpredictable results: any idea how often that's the case, or does it generally work?) We need to handle in a similar fashion to NtContinue or setting another thread's context to ensure we retain control." + }, + { + "prediction": "I don't think we need this endpoint. We already have the total count of products in the `Search` object returned by the `getProducts` endpoint.", + "reference": "@huzaifaiftikhar Changed the endpoint as suggested by Stephane in the latest commit." + }, + { + "prediction": "I don't think this is a good idea. We want to keep the size of `Value` as small as possible, so that we can store lots of them in memory and send them over the network. If we add a `Number` to `Value`, we'll double the size of `Value`.", + "reference": "There's no core.Number yet. ;)" + }, + { + "prediction": "I think this should be `This command rolls back the volume data to the specified snapshot. Once the roll back to snapshot is successful, all the data changes made after the snapshot was taken will be lost. This command should be used cautiously and only when there is an issue with the current state of the data.`", + "reference": "..., ...will be posted." + }, + { + "prediction": "I think this should be `go-filecoin show block --header`", + "reference": "Can you update this function to be `ShowHeader`? There is only one use of it at the moment in `tools/fast/series/get_head_block_height.go`." + }, + { + "prediction": "I think this should be `os.getenv('QUILT_USE_TQDM', 'false').lower() == 'true'`", + "reference": "@akarve, this disables `tqdm` by default, is it intended? Also name `QUILT_USE_TQDM` might be too specific, IMHO `QUILT_INTERACTIVE` or `QUILT_PROGRESS_BARS` or something might be better." + }, + { + "prediction": "nit: `time.Millisecond * waitTimeoutMillis` can be simplified to `time.Duration(waitTimeoutMillis) * time.Millisecond`", + "reference": "unrelated but just changing for consistency with code below it" + }, + { + "prediction": "I'm not sure about this change. If `shouldComponentUpdate` returns `false` then we should skip the render, right?", + "reference": "This will call `componentWillUpdate()` for mounts because the else clause is removed. It should only be called for updates." + }, + { + "prediction": "Shouldn't this be `read` instead of `write`?", + "reference": "We should add write inheritance too." + }, + { + "prediction": "I think this should be `JAVA_OPTS = os.environ.get('JAVA_OPTS', '').strip().split(' ')`", + "reference": "Please rename this to `LAMBDA_JAVA_OPTS`, and add a short description to the README." + }, + { + "prediction": "I think we should use `github.com/google/uuid` instead of `github.com/satori/go.uuid`.", + "reference": "Should be in the same import group." + }, + { + "prediction": "I don't think we need the `or 0x0303` here. I think we can just use `pkt.tls_session.tls_version > 0x0200`.", + "reference": "Operator precedence is very confusing here. Care to add parentheses? ` ((version or 0x0303) >= 0x0200)` Same below." + }, + { + "prediction": "Please remove this line.", + "reference": "javaparser-core has no dependencies and it should stay that way. So no log4j. And even then there would have been a preference for slf4j." + }, + { + "prediction": "I think it would be better to use a `Set` instead of an array here.", + "reference": "Why not just retest all? it's not expensive (I think)." + }, + { + "prediction": "I don't think we need to change the import order here.", + "reference": "ecr and ecr0 aren't deterministically named here. This change will just cause confusion in the git history. Could you either: a) fix this and make it deterministic b) regenerate the mock until it doesn't flip definitions for ecr and ecr0" + }, + { + "prediction": "I don't think we need to use `gdebi-core` here. `gdebi` should be enough.", + "reference": "This looks like bash... does this work in ruby? Or is the idea to inject the entire script into the subsequent commands?" + }, + { + "prediction": "I think we should throw if traceparentCollection is null. I don't think it's possible for it to be null.", + "reference": "I don't understand why this change is in this PR?" + }, + { + "prediction": "I think this should be `blacklight 7.0` since we're deprecating this in 7.0 and removing it in 8.0.", + "reference": "It's a little hard to tell from the diff, but as a result of this PR, the only non-deprecated helpers are: - `has_facet_values?` (probably not long for this world) - `render_facet_partials` (perhaps part of a future component) - `render_facet_limit` (possibly obsolete once components get traction) - `facet_field_in_params` (a little tricky to deprecate at the moment) - `facet_field_presenter`" + }, + { + "prediction": "I think you can just use `PersonObject.__proto__ = Realm.Object.__proto__` instead of `PersonObject.__proto__ = Realm.Object.__proto__.__proto__`.", + "reference": "The right-hand part shouldn't use `__proto__`. Should be just `PersonObject.__proto__ = Realm.Object`." + }, + { + "prediction": "I think we should return an error here instead of panicking.", + "reference": "the == case might be legit, or not? If there is no task written since last read, but we trigger a new read, would the min == max? Or should the upper layer handle that case?" + }, + { + "prediction": "I think this should be `memcpy(new_p, p, old_size < new_size ? old_size : new_size);`", + "reference": "Good catch! But is it guaranteed that `old_size < new_size` here? If not, wouldn't we want to take `min(old_size, new_size)` as the copy length?" + }, + { + "prediction": "I don't think this is necessary.", + "reference": "This is the only one that worries me a bit. It would be good if Brendan signed off on it." + }, + { + "prediction": "I think this should be called `isLongRunningOperation` to be consistent with `isLongrunningOperation` above.", + "reference": "`LongRunningOperationDetailView` already has `isEmptyOperation`." + }, + { + "prediction": "I don't think this is the right way to do it. The `base64.b64encode` function returns a `bytes` object, not a `str` object, so you need to decode it to a `str` before you can concatenate it with the `Basic ` string.", + "reference": "This will always add the authorization header to the request object. Is this the right scope for these two lines? If username/password are not defined, it will encode 'Basic :'" + }, + { + "prediction": "Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", + "reference": "Don't think a scope adds much value for us here. Also, for future reference, you don't need to use the `self.all` it is implied. Could just be: `scope :updated_at_desc, -> { order(updated_at: :desc) }` No need to change this one now though, it works." + }, + { + "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", + "reference": "I believe `Base.` is unnecessary in this case, as the class already extends `Base`." + }, + { + "prediction": "`fillWidth` and `fillHeight` should be `maxWidth` and `maxHeight`.", + "reference": "Couldn't this result in images being scaled too small when the width is less than the height assuming the width is still what is being passed here?" + }, + { + "prediction": "I think it would be better to use `plugins.getConfig(\"api\", \"offline_mode\")` instead of `plugins.getConfig(\"api\").offline_mode`", + "reference": "Here also, let's not cache value on top of file, but use `plugins.getConfig(\"api\").offline_mode` directly where it is needed" + }, + { + "prediction": "I think this should be `isset($config->Catalog->shibboleth_library_cards) && $config->Catalog->shibboleth_library_cards && ($this->getAuthManager()->getAuthMethod() == 'Shibboleth')`", + "reference": "You can combine the two checks into a single `!empty()` check." + }, + { + "prediction": "I think this should be `>=` instead of `>`.", + "reference": "Should we add a warning for anything over say 8M? Just suggesting that is not recommended?" + }, + { + "prediction": "I think you can remove the `currentUID` arg now.", + "reference": "Looks like there are no callers left of this function." + }, + { + "prediction": "I think this should be `attachStdin bool` instead of `attachStdin, _ bool`", + "reference": "Should there still be a ` bool` trailing `showOutput`?" + }, + { + "prediction": "I think we can remove this import.", + "reference": "Did we can change to v1" + }, + { + "prediction": "I'm not sure if this is the right place to do this, but I think we need to set `_ancestorComponent` to `null` at the end of the `outer` block. Otherwise, if we have a `Fragment` with a `Suspense` inside of it, the `Suspense`'s `_ancestorComponent` will be the `Fragment`'s `_ancestorComponent`, which is not what we want.", + "reference": "Can you please double check that this won't break anything?" + }, + { + "prediction": "I don't think it's a good idea to pass `null` here. I think it's better to create a new instance of `JsonRpcLocalStats` and pass it to the `JsonRpcService` and `JsonRpcProcessor`.", + "reference": "optionals, shouldn't need to be stated explicitly" + }, + { + "prediction": "I don't think this is correct. 0x51303030 is 0x51303030, 0x51303439 is 0x51303439, and 0x51303439 - 0x51303030 = 0x00000400.", + "reference": "That seems quite low - why not just 0x5130ffff?" + }, + { + "prediction": "I think this should be `__repr__` instead of `__str__`. `__str__` is supposed to return a user-friendly string representation of the object, while `__repr__` is supposed to return a string representation that can be used to recreate the object.", + "reference": "Why is this needed ?" + }, + { + "prediction": "I think this should be `File.exist?(Bolt::Config.user_path) && !File.exist?(first_runs_free)`", + "reference": "`Bolt::Config.user_path` returns `nil` if there's no homedir, so this will still error in that case." + }, + { + "prediction": "I think this should be `a.CompoundMessage.Proposal.value().String()`", + "reference": "nit: use %s for strings and %v for objects." + }, + { + "prediction": "I don't think we need this anymore.", + "reference": "Same as before, the properties already exists in parent" + }, + { + "prediction": "`datetime.datetime.now().year` -> `datetime.datetime.now().strftime('%Y')`", + "reference": "This fix is not quite correct. The `%s` should be replaced with `version` and the `%d` on line 39 should be replaced with `datetime.datetime.now().year`." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it makes sense to ignore the \"gone\" event for the DRM device.", + "reference": "Maybe we should only set active = false if `strcmp(type, \"pause\") == 0`?" + }, + { + "prediction": "I think this should be `options[:page_ranges] = Array(options[:page_ranges])` instead of `options[:page_ranges] &&= Array(options[:page_ranges])`", + "reference": "Same here. and all others." + }, + { + "prediction": "I think this should be in the `libkbfs` package, not here.", + "reference": "Intentionally committed? I'm not against it, we already have a way to get goroutines without killing the process: `/keybase/.kbfs_profiles/goroutine`." + }, + { + "prediction": "I don't think this is correct. If `PParam.prefix` is `c_GuidPrefix_Unknown`, then `guidP` will be `c_GuidPrefix_Unknown` as well, and the `if (guidP == c_GuidPrefix_Unknown)` condition will be true.", + "reference": "I think this blank line may be removed" + }, + { + "prediction": "I think it would be better to raise an error if `toggle` is True and the bookmark already exists.", + "reference": "I think this should be a keyword-only argument, i.e. do `def add(self, url, title, *, toggle=False):` and adjust the caller to do `toggle=toggle`." + }, + { + "prediction": "This should be `UINT32 DevStatus;` instead of `UINT32 DevStatus;`", + "reference": "@aimanrosli23 Judging from the commit description, I do not know why this file got changed so much. Could you help to double confirm if you do not revert the changes brought by commits: SHA-1: 643623147a1feaddd734ddd84604e1d8e9dcebee * MdeModulePkg/SdMmcPciHcDxe: Send SEND_STATUS at lower frequency SHA-1: 49accdedf956f175041040e677163b7cbb746283 * MdeModulePkg/SdMmcPciHcDxe: Hook SwitchClockFreq after SD clock start" + }, + { + "prediction": "Style/RedundantSelf: Redundant self detected.", + "reference": "How about YAML.load_file()" + }, + { + "prediction": "Why do we need this?", + "reference": "Maybe make this `volatile` or atomic as this can be set/read from different threads? Also, separately you may want to check if some of the methods here need to be `synchronized`." + }, + { + "prediction": "I don't think we need to unregister the module unload event.", + "reference": "Check the return value of the drmgr ones." + }, + { + "prediction": "I don't think we need to add `data-cfasync` here.", + "reference": "This should be `'cache'`" + }, + { + "prediction": "I think this should be `(*os.File, error)`", + "reference": "The name \"old\" might cause confusion here. After installation, the \"old\" repo is at an archived path, and the new migrated repo is at the old path. Maybe something like \"target\" or \"canonical\"?" + }, + { + "prediction": "This should be `command.readPreference = resolveReadPreference(options, { db: this.s.db, collection: this });`", + "reference": "I think this is somewhat definitive proof that this error exists in `core` rather than `native`. We are correctly resolving the `readPreference` in the previous line, but you are able to identify that eventually the command generated in `core` is not decorated with the passed `readPreference`. Did you try to solve this there already?" + }, + { + "prediction": "I think this should be `to-1` instead of `(to + s.BlockNumber) / 2`", + "reference": "During genesis sync it can unwind 5M blocks?" + }, + { + "prediction": "I think we should keep this test, but just remove the `Skip`", + "reference": "was it caused by the removal of removeTaskQueueManager() from this test?" + }, + { + "prediction": "Line is too long. [114/80]", + "reference": "Wouldn't it just be easier to force search_session to return `with_indifferent_access`? Since you've done the hard work already, I don't think there's a problem doing it this way, but.." + }, + { + "prediction": "I think this should be `if (!rp->rr_sim_misses_deadline) return false;`", + "reference": "So, such tasks that could possibly not meet the deadline will never have a chance to run? I think this is not nice behavior, especially for those projects who has sometimes some very small tasks after the big one." + }, + { + "prediction": "This should be `if (id == 0 || !Item::items[id].blockPickup) {`", + "reference": "You should add the check above this line instead. If string is empty, don't even call the function." + }, + { + "prediction": "I think it would be better to throw an exception in this case. If the item doesn't have the `clientCert` attribute, then it's not a valid item and shouldn't be processed.", + "reference": "If clientCert attribute doesn't exist for some reason I set it to false." + }, + { + "prediction": "I think this should be `app_host_flags += ' -k'`", + "reference": "Do we need `app_host_flags` variable? We can directly concat with `flags`. `sh.cmd curl_cmd(unless Travis::Build.config&.ssl&.verify ? flags + ' -k' : flags, location, static_file_location), cmd_opts` right?" + }, + { + "prediction": "I don't think this should be here. It's already done in `onWalkComplete()`", + "reference": "Walk should actually be completed (`onWalkCompleted`) after the event is stopped. This also makes it possible for monster to walk by smaller paths." + }, + { + "prediction": "I don't think this is the right place to do this. This is a joiner, not a decryptor. The decryptor should be responsible for decrypting the root chunk. The joiner should only be responsible for joining the chunks together.", + "reference": "typo in `weather` (should be `whether`)" + }, + { + "prediction": "I think this should be `--use-staging-install-media` instead of `--use-staging-install-media`.", + "reference": "Thoughts on having the URI as the param, instead of a boolean? The default value would be the normal prod image, and then your test would override with the staging image." + }, + { + "prediction": "Why not just remove this line?", + "reference": "I'm surprised this is needed, but we should probably assert num_scan == 1 at least, otherwise I expect the file is pretty broken." + }, + { + "prediction": "Why do we need to specify the port here?", + "reference": "Could we set a default value for `partitions` and `{0, network::NetworkUtils::getAvailablePort()}` ?" + }, + { + "prediction": "I think this should be `public TimeSpan MinimumTime { get; set; } = TimeSpan.FromSeconds(30);`", + "reference": "Needs xml docs. The API names alone don't provide enough explanation about what these mean and how to set them. Also, we should provide some validation of inputs, such as MaxTime must be > MinTime, MinimumRate must be >= 0, etc. Consider making the properties readonly and adding a constructor that does these validations." + }, + { + "prediction": "I'm not sure if this is the best way to do this, but it works for now.", + "reference": "Would it make sense to create an empty file here, perhaps in a tmp dir, instead of checking empty files into Git?" + }, + { + "prediction": "I think this should be `code += \"}\";` instead of `code += \"}\";`", + "reference": "This change is due to `clang_format` and is not related to this PR." + }, + { + "prediction": "I'm not sure this is the right place to do this. I think it would be better to do this in `sigprocmask_syscall` itself, so that we don't have to remember to do it in every place we call `sigprocmask_syscall`, and so that we don't have to remember to do it in every place we call `sigprocmask_syscall`, and so that we don't have to remember to do it in every place we call `sigprocmask_syscall`, and so that we don't have to remember to do it in every place we call `sigprocmask_syscall`, and so that we don't have to remember to do it in every place we call `sigprocmask_syscall`, and so that we don't have to remember to do it in every place we call `sigprocmask_syscall`, and so that we don't have to remember to do it in every place we call `sigprocmask_syscall`, and so that we don't have to remember to do it in every place we call `sigprocmask_syscall`, and so that we don't have to remember to do it in every place we call `sigprocmask_syscall", + "reference": "Why did you not add the signals to the call of block_all_signals_except() and instead baked them into the function? Ok, if you had a good reason for it, otherwise I would add it to the except list of the function call, since that's what it was meant for." + }, + { + "prediction": "I think this should be `FeedFile` instead of `FeedFileDownloadStatusRequesterInterface`.", + "reference": "Could this be done by mocking objects instead? I feel like this is changing too much of the actual logic just for the tests." + }, + { + "prediction": "nit: `content` -> `contentFile`", + "reference": "why not just use `ManifestContent` instead of `Integer`?" + }, + { + "prediction": "I think it would be better to move this check to the `IsWellFormed` method.", + "reference": "can we do that in TxValidator?" + }, + { + "prediction": "Why do we need this field?", + "reference": "We definitely want some detailed and thoughtful docs being added to this type." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think we should be able to enable XDP even if BPF is not enabled.", + "reference": "We would like this code to run, even when `config.XDPEnabled` is false, so that Felix can clean up its own XDP state after a restart." + }, + { + "prediction": "`if (spaceRet.left() == ResultCode::ERR_SPACE_NOT_FOUND)` -> `if (spaceRet.left() == ResultCode::ERR_SPACE_NOT_FOUND || spaceRet.left() == ResultCode::SUCCEEDED)`", + "reference": "If the status is `ERR_SPACE_NOT_FOUND` why return `SUCCEEDED` ?" + }, + { + "prediction": "`reverse (bool): Reverse the order of planes in layer sequence. False for ResNet, True for Houglass. Default: False` -> `reverse (bool): Reverse the order of planes in layer sequence. False for ResNet, True for Hourglass. Default: False`", + "reference": "It is is more appropriate to use `downsample_first`. If `downsample_first=True`, the downsample block is the first block and it is used for ResNet. If `downsample_first=False`, the downsample block is the last block, which is used by Hourglass network." + }, + { + "prediction": "nit: remove the empty line", + "reference": "Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`)" + }, + { + "prediction": "I think it would be better to say \"Instead of using `exit()` or `quit()`, consider using the `sys.exit()` function.\"", + "reference": "I don't know if there are strict conventions about this, but I think the name of the warning should be the diagnosis, not the suggested course of action. In this case, that would mean changing the name of the warning to `interactive-exit` or something like that." + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think we should be using `crt.Spec.CommonName` instead of `pki.CommonNameForCertificate(crt)`.", + "reference": "If `crt.Spec.CommonName` is not set, and `cert.Subject.CommonName` *is* set, we are not correctly handling it here." + }, + { + "prediction": "I don't think this is necessary. `cmdhistory.init()` should be called in `conftest.py`.", + "reference": "This isn't a test, so it shouldn't be named `test_init`. You could name it `cmdhistory_init` or so." + }, + { + "prediction": "I think this should be `getint(self.spark_version, \"pickle-protocol\", pickle.HIGHEST_PROTOCOL)`", + "reference": "why is this pulling from `self.spark_version` config section rather than the `spark` config section (`py-packages` appears to pull from a config section called `spark`)" + }, + { + "prediction": "I'm not sure if this is the best way to test this, but I think it will do for now.", + "reference": "nit: Think it can be one line.." + }, + { + "prediction": "I don't think we should use `import *` in this case.", + "reference": "please inline imports" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think we should be able to join cgroups even if we're in a rootless container.", + "reference": "This check is still correct in some cases, but I guess erroring out is acceptable if someone explicitly asked for an impossible cgroup configuration (now that we could in principle nest things). I would like to see a test for this though." + }, + { + "prediction": "I think this should be `aggregates changed to operate on just a single column.`", + "reference": "Should we update integral to operate on a single column as well?" + }, + { + "prediction": "I think this should be `cuda_get_deep_copy_stream(instance)`.", + "reference": "Doesn't belong to this PR" + }, + { + "prediction": "I think this should be `registrationToken *string` so that we can pass in `nil` instead of an empty string.", + "reference": "Just for my own understanding, does aws ecs API take this token as a new input attribute? Which version of the aws sdk? I did not find it in the official aws sdk doc." + }, + { + "prediction": "I think this should be a constant in the `UserAccount` class.", + "reference": "Could we shorten this constant to maybe `FEATURE_USER_AUTH`?" + }, + { + "prediction": "I think this should be `numRekeyQueueWorkers` or something like that.", + "reference": "Any particular reason for 8? I feel like we could probably handle more..." + }, + { + "prediction": "Layout/AlignParameters: Align the parameters of a method call if they span more than one line.
Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
Layout/AlignArray: Align the elements of an array literal if they span more than one line.
Layout/AlignHash: Align the elements of a hash literal if they span more than one line.", + "reference": "Try to use factory association declaration for default values, so it could minimal the line length. You may write in fetch_job factory like association :repository, factory: :repository." + }, + { + "prediction": "I'm not sure this is the best way to do this, but it's the only way I could think of to add a class to the `status-header-container`", + "reference": "Should the \"cancelled\" class be added regardless of the proposal's state?" + }, + { + "prediction": "I think we should keep the empty line here.", + "reference": "nit: random whitespace change, let's try to keep these out of commits unless there are other useful changes." + }, + { + "prediction": "I don't think we need to do this. If `model` is a string, then `models` will be `undefined` and `i < models.length` will always be `false` so `models[i]` will always be `undefined`.", + "reference": "Seems kinda dangerous - what if models length is different from paths length?" + }, + { + "prediction": "I don't think we need to pass `prune.Mode{}` here.", + "reference": "set real one plz (get it from DB)." + }, + { + "prediction": "I don't think you need to cast this to (struct fpga_port_uafu_irq_set *). The compiler should be able to figure this out.", + "reference": "Should this be initialized to zeroes?" + }, + { + "prediction": "I'm not sure if this is the right thing to do, but I think it's the right thing to do. If there are no base docs, then there are no facet results.", + "reference": "The query is already built at this point, so I don't think this particular change actually helps wrt SOLR-10732? (and the `base.size()==0` case is already trivially optimized in `SolrIndexSearcher.numDocs(Query, DocSet)`)" + }, + { + "prediction": "This import is not used.", + "reference": "re-add the type in the annotation here" + }, + { + "prediction": "`stderr.String()` should be `string(stderr.Bytes())` as `stderr` is a `bytes.Buffer` and not a `string`.", + "reference": "Could we simpify it as `cmd.Stderr = &bytes.Buffer{}`?" + }, + { + "prediction": "I think this should be `return now.After(cert.NotAfter)`", + "reference": "there's enough \"nots\" in here that while it's correct by my review, I'd like to see a small unit test (just passing in an expired and non-expired cert)" + }, + { + "prediction": "I think this should be `github.com/fortio/fortio/log`", + "reference": "File is not `goimports`-ed (from `goimports`)" + }, + { + "prediction": "I think this should be 1e-6", + "reference": "The config option should probably have a more specific name. Also it's not for all gridded data but specifically for Images (and its subclasses)." + }, + { + "prediction": "I'm not sure if this is the best way to test this, but it seems to work.", + "reference": "Be careful. This is not a preference but an option in a dialog." + }, + { + "prediction": "I think this should be `if deployment.ClusterName == \"\" { deployment.ClusterName = cluster } else { deployment.ClusterName = deployment.ClusterName }`", + "reference": "this will modify the incoming object, which may not be desirable in some cases. i think we should stick with the local var, override it with deployment.ClusterName if deployment.ClusterName not empty" + }, + { + "prediction": "Why is this not needed anymore?", + "reference": "Is this not required?" + }, + { + "prediction": "I think this should be `if (input.type === Blockly.INPUT_VALUE || input.type === Blockly.INPUT_STATEMENT)`", + "reference": "You're using scare quotes on these terms instead of defining them." + }, + { + "prediction": "This should be `>= 1.12.0`", + "reference": "These should both be const, not var right?" + }, + { + "prediction": "I don't think you need the `try-with-resources` here. The `FileOutputStream` is closed by the `persister.store` method.", + "reference": "Can you catch a more specific exception here? Thanks :-)" + }, + { + "prediction": "Why do we need to return `ctrl.Result{Requeue: true}` here?", + "reference": "This is a bug during handling the recover logic in `common chaos` controller, I fixed in this request when I found it." + }, + { + "prediction": "I think it is better to add `score_thr` as an argument of `single_gpu_test` and `multi_gpu_test` instead of adding it as an argument of `inference_detector`.", + "reference": "During testing, we adopt the score threshold specified in the config file. Here the threshold is only used for visualization, and the variable name `score_thr` can be misleading. Renaming it to `show_score_thr` would be better." + }, + { + "prediction": "I think we should keep the `role=\"navigation\"` on the `