{ "test_bleu_4": 0.023617207333692627, "test_exact_match": 0.0, "test_rouge": { "rouge1": 0.11593094026037254, "rouge2": 0.017896913856857377, "rougeL": 0.10025242654214725, "rougeLsum": 0.10028929269385953 }, "test_bertscore": { "precision": 0.8360642830593324, "recall": 0.8402432925359539, "f1": 0.8376621647809082 }, "test_meteor": 0.08482402861713305, "raw_data": [ { "prediction": "I think it would be better to add a new parameter to the `protoc_gapic_plugin_generator_test.java`.", "reference": "can we also test for `transport=rest`?" }, { "prediction": "I think this is not a good idea, but it's not a good idea to do this. It's not a good idea to do this.", "reference": "If record_batch_size is not set in config.ini, this code will trigger a notice about an undefined value. I would suggest either wrapping the setPageSize() call in an `if (!empty(...)) {` check, or else providing a default value in the set call (i.e. `$config->Index->record_batch_size ?? 100`)." }, { "prediction": "I don't think this is needed anymore.", "reference": "I didn't realize we were hardcoding this, thanks for moving it to an env value." }, { "prediction": "`isNaN(file.data.size) ? '' : html`", "reference": "We are trying to support IE 10-11, so we'll need a polyfill for this one, I think." }, { "prediction": "I think this should be `useSelect( (select) => select( CORE_LOCATION).getNavigatingURL() );`", "reference": "It looks like there's a new `isNavigatingTo( url )` selector for this very purpose so let's use this here instead. This way we just need to use the one selector rather than two. Let's assign that to a similar-named variable here (e.g. `isNavigatingToPostResetURL`) rather than the prop it's used with." }, { "prediction": "I think it would be better to use `absMat` instead of `absMat`.", "reference": "I think im2col should only accommodate CPUMat." }, { "prediction": "I think we should remove the import from google.cloud.forseti.notifier.notifiers import email_violations # pylint: disable=line-too-long", "reference": "alpha sort the imports" }, { "prediction": "(style) line over 80 characters", "reference": "Can you explain why is this necessary? Is `snprintf()` with four integer arguments unsafe?" }, { "prediction": "I don't think this is a good idea, but I think it would be better to use `getattr(api.getForegroundObject(), '_lastDetectedKeyboardLayoutChange', 0)` instead of `getattr(api.getForegroundObject(), '_lastDetectedKeyboardLayoutChange', 0)`", "reference": "How likely would it be that the keyboard layout for the NVDA main thread differs from the keyboard layout of the currently focused app?" }, { "prediction": "Why not just `getDefaultService()` here?", "reference": "Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`)" }, { "prediction": "`keys.join('')` should be `keys.map(keys => keys.join('')`", "reference": "Also update line 2205 below" }, { "prediction": "I think this should be `shared := volumeConfig.GetSharedMountValue()`", "reference": "n_: It is a good practice to name the variable to indicate what they contain. In this case since `shared` is supposed to have boolean, calling it: `isShared` can help in the readability of the code." }, { "prediction": "I think this is a bit confusing, but I'm not sure if it's worth it.", "reference": "I suppose it's a false-positive error. Maybe there is a way to configure the `eslint-*` package to accept `i.e. .... lower case` syntax " }, { "prediction": "I think this should be `activity.ParentSpanId.ToHexString()` instead of `activity.ParentSpanId.Equals(\"0000000000000000\")`", "reference": "this maynot be a perf issue, if ToHexString() is not actually allocating a string, but returns the caches string value. to be confirmed." }, { "prediction": "I think this should be `zap.Error(\"failed to update image\", zap.String(\"image-provider\", provider.Name()), zap.Error(\"failed to update image\", zap.Error(\"failed to update image\", zap.Error(\"failed to update image\", zap.Error(\"failed to update image\", zap.Error(\"failed to update image\", zap.Error(\"failed to update image\", zap.Error(\"failed to update image\", zap.Error(\"failed to update image\")))`", "reference": "`zap.String(\"image-provider\", provider.Name())` should be in a same line." }, { "prediction": "Why is this removed?", "reference": "Why this deletion?" }, { "prediction": "I think it would be better to use `assertEqual(remote_metadata['cache-control'], 'public', max-age=500)` instead of `assertEqual(remote_metadata['cache-control'], 'public', max-age=500)`", "reference": "This change looks unrelated to the CL description?" }, { "prediction": "I think this should be `#define DEDUP_RESUTL_CHECK(inputName, outputName, sentence, expected)`", "reference": "I'm not certain that `res`+`utl` isn't a thing." }, { "prediction": "I think this should be `STATUS_STOPPED.getNumVal()` instead of `STATUS_KILLED.getNumVal()` and `STATUS_KILLED.getNumVal()`", "reference": "This method can cause bugs. Why don't you use list of finalize statuses and then use join by comma and that will give you correct value. Use Apache Commons Lang library List list = Arrays.asList(1,2,3,4,5,6,7); String str = org.apache.commons.lang.StringUtils.join(list, \",\"); You can use it at multiple places shown in this diff." }, { "prediction": "(style) line over 80 characters", "reference": "Merge with next condition" }, { "prediction": "I think this should be `deploy.DeleteTask` instead of `deploy.DeleteTask`.", "reference": "Maybe add it when it is used." }, { "prediction": "I don't think this is a good idea. I think it would be better to add a `enabled: True` to the list of scanners.", "reference": "More clear naming: NONEXISTENT_ENABLED" }, { "prediction": "I think this should be `to.equals(Types.LongType.get());` instead of `to.equals(Types.LongType.get());`", "reference": "why is this change necessary?" }, { "prediction": "I think we should remove this hack when null response types are implemented.", "reference": "make a SchemaTypeNameConverter.getTypeNameForEmptyType() and call that here." }, { "prediction": "I think it would be better to use `Lang::getDefaultLanguage()->getLocale()` instead of `Lang::getDefaultLanguage()->getLocale()`", "reference": "Use braces on your conditional structures please" }, { "prediction": "I think this should be `true` instead of `false`", "reference": "Great God, I have a question. This \".nebula_history\" file is used to save history commands. Is there a file size limit? When the file is large, does it take a long time to start initialization (loadHistory)? How did you think about this? Thx." }, { "prediction": "I think this should be `assert(isType(token, TOKEN_OPEN_PAREN));`", "reference": "Isn't this the same check as two lines above?" }, { "prediction": "I don't think we should use `os.path.join(options.CA_DIR, 'config.yaml')` here.", "reference": "Don't redefine, just import the existing one in `cmdline.py`. :)" }, { "prediction": "Line is too long. [89/80]", "reference": "why not call `respond_to?(\"#{name}=\")` from the `if` line?" }, { "prediction": "Why do we need to do this here?", "reference": "This was properly set above as `.runfiles/` (with a fallback to workspace root dir) but never used past this line." }, { "prediction": "I think this should be `public MvxPagePresentationAttribute(MvxBasePresentationAttribute mvxPagePresentationAttribute) {`", "reference": "Are all these namespaces required for this attribute?" }, { "prediction": "Style/StringLiterals: Prefer single-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", "reference": "Given this may be used and printed in other ways, isn't `debug` more appropriate?" }, { "prediction": "I think this should be `s.clear(id)` instead of `s.clear(id)`", "reference": "Looks like this is unused? Did you mean to call it when clearing the block journal?" }, { "prediction": "I think this should be in the constructor, not in the constructor.", "reference": "why named alters? how about this.alerts = alerts?" }, { "prediction": "I think this should be `mset.sourcesInfo()` instead of `mset.mirrorInfo()`", "reference": "not sure if this has to be here or not tbh" }, { "prediction": "Why is this needed?", "reference": "There's a better fix for this in #1741, which should replace this." }, { "prediction": "I think this should be `[]byte(\"node1\")` instead of `[]byte(\"node1\")`", "reference": "Use swarm.Address not []byte as type, and construct it from actual byteslice or use swarm.NewAddress if it is constructed from hex-encoded string." }, { "prediction": "I think this should be `require.NoError(t, os.RemoveAll(dir))`", "reference": "It would be worth factoring this out to a function, but you don't have to do that here." }, { "prediction": "I think this interface should be `StringBuffer` instead of `StringBuffer`", "reference": "There's no need for `final` in interfaces." }, { "prediction": "I think this should be `case DatadogTags.ServiceVersion: case DatadogTags.ServiceVersion: case DatadogTags.ServiceVersion: case DatadogTags.ServiceVersion: case DatadogTags.ServiceVersion: case DatadogTags.ServiceVersion: case DatadogTags.ServiceVersion: case DatadogTags.ServiceVersion: case DatadogTags.ServiceVersion: case DatadogTags.ServiceVersion: case DatadogTags.Version: Span.SetTag(Tags.Version, value); break; default: case DatadogTags.ServiceVersion: case DatadogTags.ServiceVersion: case DatadogTags.ServiceVersion: case DatadogTags.ServiceVersion: case DatadogTags.ServiceVersion: case DatadogTags.ServiceVersion: case DatadogTags.ServiceVersion: case DatadogTags.ServiceVersion: case DatadogTags.ServiceVersion: case DatadogTags.Version: Span.SetTag(Tags.Version: Span.SetTag(Tags.Version, value); break; default: case DatadogTags.ServiceVersion: case DatadogTags.ServiceVersion: case DatadogTags", "reference": "Isn't this case handled as a custom tag in `Span.SetTag()` below? This switch is only for special tags that actually set `Span` properties." }, { "prediction": "Why did you remove this?", "reference": "This shouldn't be changed." }, { "prediction": "This file is not part of Invenio. It is not part of Invenio.", "reference": "This one is important `2: I102 copyright year is outdated, expected 2014 but got 2012`" }, { "prediction": "I think this should be `BiConsumer` instead of `BiConsumer`.", "reference": "Are these imports needed (BiConsumer and Consumer)? If they are unused imports, then precommit will fail." }, { "prediction": "Line is too long. [82/80]", "reference": "Why are we catching and logging exceptions? By doing that we make it look like the job has succeeded and it will be removed from the queue - if we didn't do that then it would stay queued..." }, { "prediction": "Can you please add a space after the `if`?", "reference": "If there are `@param` tags in docblock, there should be `@return` tag also. (applies for a whole file)" }, { "prediction": "I think this should be `VALIDATORS(\"transaction_pool\")`", "reference": "Is the concept of validators exclusive to IBFT2? I wonder if this category should be more explicitly linked to IBFT2." }, { "prediction": "This file is not used anymore.", "reference": "Spotless is configured to reject star imports. Please replace with explicit imports." }, { "prediction": "I think this should be `sycl::info::device::local_mem_size` instead of `sycl::info::device::local_mem_size`.", "reference": "Remind me why you are using CUDA vocabulary when naming these variables." }, { "prediction": "I think it would be better to use `UserPreferences.FEED_FILTER_COUNTER_COUNTER_ZERO` instead of `UserPreferences.FEED_FILTER_COUNTER_COUNTER_ZERO`.", "reference": "Please turn the iteration order around (instead of `0...size` to `size...0`). The reason is that this sometimes skips indices when removing an item. You can therefore end up with feeds that have counter 0 and are still displayed." }, { "prediction": "Why is this removed?", "reference": "this is a behavior change. solid_subset=[] represents an empty pipeline where as solid_subset=None is the full pipeline" }, { "prediction": "I think this is not a good idea, but I think it would be better to use `Logger.LogWarning(Resources.ParameterIsNotValid, unmatchedSetting);` instead of `Logger.LogWarning(Resources.ParameterIsNotValid, unmatchedSetting);`", "reference": "this is a breaking change, any specific reason you want to do this?" }, { "prediction": "I think this should be `SetHead(context.Context, *chain.TipSetAndState)` instead of `PutTipSetAndState(context.Context, *chain.TipSetAndState)`", "reference": "Blocking: we still want read write separation. Node functions should absolutely not write to the chain store and the interface should reflect that. Only the syncer should have this capability in production code. It should be no problem to keep casting chainForTest to a read-write interface, or doing other function decomposition and automatic casting tricks." }, { "prediction": "Why is this change needed?", "reference": "The PR description says the lowest on-demand request priority is `2^30`. Why the `-1` here?" }, { "prediction": "I don't think we need to do this.", "reference": "checking health again? I think it is not necessary." }, { "prediction": "I think we should use `time.Sleep(1 * time.Second)` instead of `time.Sleep(1 * time.Second)`", "reference": "Need an `if err == nil {break}` above this line so that we don't log/sleep if the retry succeeds." }, { "prediction": "`assert.ok(typeof lib === 'function', 'mongodb.Promise must be a function, got ${lib}`); `assert.ok(typeof lib === 'function', 'mongodb.Promise must be a function, got ${lib}`); `assert.ok(typeof lib === 'function', 'mongodb.Promise must be a function, got ${lib}`); `assert.ok(typeof lib === 'function', 'mongodb.Promise must be a function, got ${lib}`);", "reference": "to reiterate my point above, this class is not the actual provided Promise, but rather something a user can provide a Promise to/with. I think a name like `PromiseProvider` is more appropriate." }, { "prediction": "I think this should be `s.state.QueueTarget(dep, target.Label, true, false)` instead of `s.state.QueueTarget(dep, target.Label, true, false)`", "reference": "I guess we can only call this from a post-build function, but we might need to check that this target is to be built? I guess target A depends on B which has a post build. We `plz build :B` which adds C as a dep of A. Won't we queue C to be built even though it only needs to build if A needs to be built? That's kinda why I approached this the way I did. I trust you've thought about this but would be good to understand this a bit better." }, { "prediction": "I think it would be better to use `if not (pks.__class__.__name__ == 'StreamSocket')` instead of `if not (pks.__class__.__name__ == 'StreamSocket')`", "reference": "You should use `isinstance()` instead of comparing the class name to a string." }, { "prediction": "I don't think we should use `el.nodeName.toUpperCase()` here. I think it would be better to use `el.nodeName.toLowerCase()` instead of `el.nodeName.toLowerCase()`.", "reference": "Why should audio and video elements always return `false` for `isHidden`?" }, { "prediction": "Why did you remove this?", "reference": "This obviously won't work for all the other platforms." }, { "prediction": "Why is this removed?", "reference": "Isn't he diamond operator Java7+?" }, { "prediction": "Shouldn't this be `throw new IllegalArgumentException(argName + \" must be greater than 0`?", "reference": "Prefer adding a second `positive(String, double)` that delegates down to this three-param version. Using `null` in code is generally Not A Great Idea, and it looks ugly." }, { "prediction": "I think this should be `node.Predecessors()[0]` instead of `node.Predecessors()[0]`.", "reference": "This pattern, where we add a new parameter without using it, often indicates to me that we've got a leaky interface or abstraction. I see this pattern _a lot_ in this patch, so wondering you have thoughts about it." }, { "prediction": "I think this should be `os.MkdirAll(dir, 0755)`", "reference": "This seems like an improved pattern :)" }, { "prediction": "Line is too long. [82/80]", "reference": "`open_id_authentication` is no longer the name of the function, and it's not OpenID specific" }, { "prediction": "I don't think this is correct, but I think it would be better to use `wallet_balance_label->setText(QString(final_text.c_str()) + std::chrono::system_clock::now() + std::chrono::seconds(60));`", "reference": "This didn't require corresponding changes to the test case(s)?" }, { "prediction": "I think this should be `env_file` or something like `env_file`", "reference": "A question! I think `string` totally works, but what do you think of `*string` for consistency?" }, { "prediction": "I think this should be a constant, not a constant.", "reference": "Should this be: `aws.infrastructure.cluster.sigs.k8s.io` instead?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Not clear on why this change is correct." }, { "prediction": "I think this should be `isMapped` instead of `isMapped`", "reference": "Hi Simon. Whether this should return true depends on what byte buffers are used? The same applies to ByteBufferIndexInput, actually... I don't think you can generally tell whether the ByteBuffers the input operates on come from a mmap call or from somewhere else (even direct buffers don't have to be a result of mmap)." }, { "prediction": "I don't think this is needed anymore.", "reference": "All stories in this file also need to have the default padding." }, { "prediction": "(style) line over 80 characters", "reference": "I don't think these asserts are necessary, because `subsurface_find_sibling` already searches in the parent. Or am I missing something?" }, { "prediction": "Line is too long. [82/80]", "reference": "Should this be `number` instead of `id`?" }, { "prediction": "I don't think we need to do this.", "reference": "I have forgotten why we thought this restriction is necessary. A user registers a Hive/HBase table with us but is not able to use the table with the registered name in DML. Will UPDATE STATs will be on the original name too (and update stats code will find out registered name and use it for Table_uid?). This was the registration concept is almost like an internal implementation idea, at some point could even be done by some utility program for all existing Hive/hBase tables, and the user need not be aware of it? I am struggling with a user would want to register a table, if they cannot use it by that name." }, { "prediction": "(style) line over 80 characters", "reference": "Should most of these non-globals be static?" }, { "prediction": "Line is too long. [82/80]", "reference": "Please do not approve PRs without tests!!!!" }, { "prediction": "I don't think we need to pass the win_id here.", "reference": "Now that you handle this in `webenginetab.py` you can undo all the changes in this file." }, { "prediction": "I think this should be `catch(Exception e) {`", "reference": "I think we should log the exception to a log file instead of printing it. The current behavior (not catching the exception) should lead to an automatic print of the exception to the terminal/console." }, { "prediction": "I think this should be `warn` instead of `warn`.", "reference": "These changes to the resource helpers have some more far-reaching implications as they also affect calls made in hive-operator, I believe. It's probably OK still, though. Ideally, the resource helper would not be the one doing the logging, since it cannot know the severity, but that is well beyond something that we should tackle for this PR. I would rather have the hive-operator log warnings than have the syncsetinstance controller log errors." }, { "prediction": "I think this should be `null, null, null, null, null, null, null, null, null, 'ExportCategoryI18ns'`", "reference": "do you really want to change the behavior on foreign key ?" }, { "prediction": "(style) line over 80 characters", "reference": "Looks like my bad. Thanks for fixing!" }, { "prediction": "I don't think this is a good idea.", "reference": "I think \"Don't replace variables ...\" would be cleaner." }, { "prediction": "I don't think you need to change the doc to something like `doc=\"\"\"`", "reference": "Do you validate the possible strings? I've not read the code below but we should make sure if a string is supplied it is validate..." }, { "prediction": "I think this should be `generateDataDiskName(w.Vars[\"instance_name\"].Value, dataDiskIndex)` instead of `generateDataDiskName(w.Vars[\"instance_name\"].Value, dataDiskIndex)`", "reference": "I'd recommend using generateDataDiskName here as well -- might as well benefit from the safety that it gives to protect yourself from future changes to w.ID()." }, { "prediction": "I think this should be an interface, not an interface.", "reference": "qq: do we want to include anything in the name to indicate that it is a position in the manifest?" }, { "prediction": "I think this should be `if (!mWindows.isPaused()) {`", "reference": "These logs should probably use the `LOGTAG`" }, { "prediction": "Why is this removed?", "reference": "From this, it was clear, that we are using our version of wireguard-go. And now it looks like we are using original packages which is confusing." }, { "prediction": "I think this should be `String.Format(e.Message, \"UTF-8\")`", "reference": "Any particular reason for this? This potentially will make harder to investigate users issues" }, { "prediction": "Why do we need to check for `Blockly.highlightedConnection_ != closestConnection` instead of `Blockly.localConnection_ != localConnection`?", "reference": "Do you also need to check if Blockly.localConnection_ is non-null?" }, { "prediction": "I think this should be `RSpec::Core::Hooks::GlobalNonConfigurationData`", "reference": "Not really a container, and it's not just about non-config data, not sure of a better description, @myronmarston ?" }, { "prediction": "I think we should use `require('stream').Readable` instead of `require('stream').Readable`", "reference": "The desktop app will load this fine. on iOS I get `TypeError: undefined is not an object (evaluating '_$$_REQUIRE(_dependencyMap[8], \"stream\").Readable.Readable')` if I change it to `const Readable = require('stream').Readable;` or `const { Readable } = require('stream');` I get undefined errors from the stream on iOS: `[TypeError: stream.on is not a function. (In 'stream.on(\"data\", function (chunk) { return chunks.push(chunk); })', 'stream.on' is undefined)]` What am I missing?" }, { "prediction": "I think this should be `b := make([]byte, len(ch.Data()), len(ch.Data()), len(ch.Data()), len(ch.Data()), len(ch.Data()), len(ch.Data()), len(ch.Data()), len(ch.Data()), len(ch.Data()), len(ch.Data()), len(ch.Data()), len(ch.Data()), len(ch.Data()))`", "reference": "this is needed since the chunk feeder shares memory across calls to the pipeline. this is in order to avoid multiple allocations. this change mimics the behavior of shed and localstore, and copies the data from the call into the in-memory store" }, { "prediction": "I think this should be `opentracing.SetGlobalTracer(nil)` instead of `opentracing.SetGlobalTracer(nil)`", "reference": "wut. We can do this at the beginning of tests if we want right? Why are we depending on init?" }, { "prediction": "I think this should be `c.mu.Unlock()`", "reference": "Same trick here IMO." }, { "prediction": "I think this should be `element` instead of `origin`", "reference": "Should be `@origin = element || origin || POINTER`" }, { "prediction": "Why do we need to do this here?", "reference": "this example needs a fix?" }, { "prediction": "(style) line over 80 characters", "reference": "Is it safe to assume this surface is a toplevel?" }, { "prediction": "(style) line over 80 characters", "reference": "we don't need that function" }, { "prediction": "I think this should be `WINDOWS_PLATFORM` instead of `WINDOWS_PLATFORM_WINDOWS_PLATFORM_WINDOWS_PLATFORM_WINDOWS_PLATFORM_WINDOWS_PLATFORM_WINDOWS_PLATFORM_WINDOWS_PLATFORM_WINDOWS_PLATFORM_WINDOWS_PLATFORM_WINDOWS_PLATFORM_WINDOWS_PLATFORM_WINDOWS_PLATFORM_WINDOWS_PLATFORM_WINDOWS_WINDOWS_WINDOWS`", "reference": "we'll also have to think about adding \"Windows Server 2014\" or whatever they come up with later." }, { "prediction": "I think this should be called `fetchActiveFlowsByExecId` instead of `fetchActiveFlowByExecId`", "reference": "curious do we have an API to fetch an inactive flow?" }, { "prediction": "I think this should be `if (obj.props && obj.type && obj.props.children != null && obj.text != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj.props.children != null && obj", "reference": "This branch is not needed anymore because every `vnode` that passes through `h` in compat or core will have the `$$typeof`-property now ." }, { "prediction": "I think this should be `return ariaHiddenValue !== null`", "reference": "Did you mean to use `hasAttribute`? You shouldn't. This does not improve performance and it messes with the readability." }, { "prediction": "I think we should remove the `callbackchecker` from `qutebrowser.utils` from `qutebrowser.utils` and `qutebrowser.utils` from `qutebrowser.utils` from `qutebrowser.utils` from `qutebrowser.utils` from `qutebrowser.utils` from `qutebrowser.utils` to `qutebrowser.utils`", "reference": "Please import modules and not classes (except for Qt stuff)." }, { "prediction": "I think this is not a good idea, but I'm not sure if this is a good idea.", "reference": "Hm... why do we have a \"DummyJavaNode\" in src/main? Looks like, this should have gone into src/test...." }, { "prediction": "I think this should be `package v1alpha1` instead of `package v1alpha1`", "reference": "This seems meaningless. If we cannot add any info let us remove this." }, { "prediction": "I think this should be `c.lock.RLock()` instead of `c.lock.RUnlock()`", "reference": "Can you rename `Ports` to `PortsUnsafe`?" }, { "prediction": "I think we should use `Base64.urlsafe_encode64` instead of `Base64.urlsafe_encode64`.", "reference": "This feels like it could be moved out to your first gem!" }, { "prediction": "Why do we need to remove this abstract?", "reference": "The expected behaviour for `poll` would be to match what `Deque` does, which is: > Retrieves and removes the head of the queue represented by this deque As such, you shouldn't need the `RequestId` here." }, { "prediction": "I don't think we should use `Array.from(arr1, arr2) => arr1.concat(arr2).filter(elem => arr.indexOf(elem) === pos);`", "reference": "This is super minor, but it'd be nice if this iterated over an arbitrary number of array inputs." }, { "prediction": "(style) line over 80 characters", "reference": "What is the problem here? The commit message has strange wording \"readlink is defined with restrict pointers\": do you mean \"restricted\"? Is that a well-defined language term? I'm not sure what it means." }, { "prediction": "I think this should be `import com.google.common.collect.ImmutableSet;`", "reference": "Why are we not wrapping here?" }, { "prediction": "I think this should be `@var \\Shopsys\\FrameworkBundle\\Model\\Product\\Parameter\\Parameter`", "reference": "I though that all data objects are being unified in the fashion where all default values are initialized in constructor, are not they?" }, { "prediction": "I think this should be `libflux/flux-core/src/ast/walk/mod.rs` instead of `libflux/flux-core/src/ast/walk/mod.rs`", "reference": "Does this file actually need to be committed to git? Having to run `make generate` is rather tedious on each PR and it conflicts easily." }, { "prediction": "I think this should be removed.", "reference": "We don't need this anymore, as Google's library handles various auth mechanisms for us. We'll be less explicit about why we're failing but we gain support for several authentication methods- swings and roundabouts!" }, { "prediction": "I think this should be `/var/lib/docker-volumes` instead of `/var/lib/docker-volumes`.", "reference": "No need to speficy attribute here. Moreover in yaml it is default to use lowercase names." }, { "prediction": "I think this should be `using System.Threading.Tasks` instead of `using System.Threading.Tasks.Task`", "reference": "In general I'm a trying to understand the reason behind this PR. Looks like if a blob (name) already exists we check if the contents are identical? In what scenarios this is not the case? When we want to publish a package/asset that has changed but still we want to use the same version?" }, { "prediction": "I don't think we should use `urllib2.urlopen` here.", "reference": "Can rename `req` to be `opener`, since that is the object, and it wraps `req` internally?" }, { "prediction": "I think this should be `if breakpoint is not None: textList.append(breakpoint)`", "reference": "@MichaelDCurran, thoughts on adding a breakpoint format field attribute? It seems almost app specific, but I guess it does seem odd abusing line-prefix. Is there any more generic concept here?" }, { "prediction": "I think this should be `if self._w3c` instead of `if self._w3c`", "reference": "This would return a tuple of two dictionaries. You need to combine them and return a dictionary" }, { "prediction": "I think we should remove this line.", "reference": "What do you think of moving the example to the help text of the prompt? and the prompt itself can be \"What is your application's GitHub repository URL?\"" }, { "prediction": "I think this should be `1593493828L` instead of `1593493828L`", "reference": "Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs." }, { "prediction": "I think this should be `std::distance(first, last) > 9 && std::string(first, first + 9) == \"atomProp:\"`", "reference": "Nice use of std::distance. I'm a bit worried about first += 9 though." }, { "prediction": "I think this should be `app.kubernetes.io/part-of: \"prometheus-operator\"`", "reference": "Shouldn't this be `app.kubernetes.io/managed-by` as prometheus-operator manages this resource, but this resource isn't a part of prometheus-operator?" }, { "prediction": "I think this should be `parent.GetTag(Tags.InstrumentationName).Equals(parent.GetTag(Tags.InstrumentationName), StringComparison.OrdinalIgnoreCase)`", "reference": "As long as we're being extra-vigilant about NREs, should we check that `httpMethod` and `requestUri` are not null?" }, { "prediction": "I think this should be `xrc20` instead of `xrc20`", "reference": "No need to have `xrc20` alias" }, { "prediction": "I don't think we need to do this. I think it's better to use `define_context_context_cls(pipeline_name, pipeline_def.context_definitions)` instead of `define_maybe_optional_selector_field(pipeline_name, pipeline_def.context_definitions)`", "reference": "the naming convention I'm been adopting if `_type` for instances of these classes. So maybe `context_config_type` is a better name for this fn" }, { "prediction": "I think this should be `gpuMining`", "reference": "Don't call it GPU mining, call it `externalMining`, here and throughout." }, { "prediction": "`imageMaxWidth`, `imageMaxHeight`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `imageQuality`, `", "reference": "`within this with` typo, should be `within this width`" }, { "prediction": "I think this should be `k8s:openapi-gen=true` instead of `k8s:openapi-gen=false`", "reference": "how come this is false?" }, { "prediction": "I don't think we need to check the type of the argument.", "reference": "How about `Object.prototype.toString`? Or using the `typeof` operator?" }, { "prediction": "I think this should be `context.Background()`, not `context.Background()`.", "reference": "I know @jzila suggested this, but I disagree: you're really not supposed to save a context in a struct. Can you get by with just saving the `Done()` channel instead? The `ctx` should continue to be passed around explicitly." }, { "prediction": "I think this should be `#if DNX451 && PlatformApis.IsDarwin;`", "reference": "This check isn't right though." }, { "prediction": "I think this should be `codeGenVersion` as well.", "reference": "maybe `toolkitVersion` instead? It doesn't necessarily have to be called that in the generated code, but in the view model classes, I think it makes it clearer that it is the version of toolkit itself." }, { "prediction": "I think this is a bit confusing, but I'm not sure if this is the right thing to do here.", "reference": "the response data was added intentionally in #612, i think we could keep the `setFileState` stuff here as a special case, at least for now " }, { "prediction": "I think this should be `time.After(time.Now())` instead of `time.Until(deadline)`", "reference": "This isn't really easy to read." }, { "prediction": "I think this should be `glog.Errorf(\"Error in deleting volume %s: %s\", cVR.ObjectMeta.Name, err)`", "reference": "This line changed due to go formatting. Format was not there earlier." }, { "prediction": "I think this should be removed.", "reference": "The name \"Without\" in code is a little nebulous. Maybe something more descriptive like TrimPrefix or StripPrefix or WithoutPathPrefix or something like that. (Thoughts?)" }, { "prediction": "I think it would be better to use `tryToLinkAgain.then().assertThat(FORBIDDEN.getStatusCode());` instead of `tryToLinkAgain.then().assertThat(FORBIDDEN.getStatusCode());`", "reference": "is this test in the move tests? I see what you mean then - it works, but I wonder if we won't lose track that it's being tested here." }, { "prediction": "Why is this needed?", "reference": "I'm not sure if this wanted to be `json:\"tags\"` (which I'd set in my PR) or `json:\"tag\"` that someone elses PR had set. Given that the rest of the fields had their JSON field name set to the same as the struct field name, I opted for `tags`." }, { "prediction": "I don't think we should use `scope:for_fiscal_year, lambda { |year| range = self.class.range_for_fiscal_year(year)` here.", "reference": "since the logic here and in `Proposal` is exactly the same, do you think it makes sense for us to include it elsewhere? I am not opposed to duplicated code when it makes sense, but the reason I first identified this was that I was looking for code in NCR::WorkOrder that was not specific to Work Orders. Seems like fiscal year logic might be helpful for reporting for other clients. In that case, we'd want this scope on those client data classes as well. Might be wrong to include this in the FiscalYear mixin, but it does seem like it should be outside of Proposal and WorkOrder. Does that make sense?" }, { "prediction": "I think this should be `self.connection.add_timeout(5, self.connect_to_rabbitmq)`", "reference": "there is no static method as a go between -- how does this work?" }, { "prediction": "Line is too long. [89/80]", "reference": "Can you please change the name of this class to be something else?" }, { "prediction": "(style) line over 80 characters", "reference": "I think we might prefer generalizing the interface rather than creating an exception. Current design of `h2o_next_token` assumes the input to be a comma-separated list, and allows the caller to specify a different separator when parsing a nested list. As I understand, what we are trying to attain in this PR is to have a way of parsing a flat list of semicolon-separated list. Assuming that is the case, I think it would be better to change the API of the function to accept two separators (i.e. inner and outer), where for our existing use-cases `outer` would be `,`." }, { "prediction": "Why is this needed?", "reference": "why not recycling? I Lru cache now recycling?" }, { "prediction": "I think this should be `if request.ConsumerInfo.PaymentVersion == PaymentVersionV3 {`", "reference": "Why it is now called `PaymentVersionV3`?" }, { "prediction": "I think this should be `klog.V(4).Infof(\"there are %d nodes need to sync secret, operation: %s\", len(nodes), e.Type)`", "reference": "changed for debug purpose?" }, { "prediction": "I think this should be `this.exporter.ParentProvider = this.exporter.ParentProvider;`", "reference": "@cijothomas I needed a way to set the Exporter.ParentProvider when the Processor's gets set. Internal to SDK though." }, { "prediction": "I don't think we need to do this here, but I think it would be better to use `!from_motorway` instead of `from_motorway` here.", "reference": "Talking through this scenario with @srividyacb and she's wondering if there should also be a check of `(from_trunk && node_based_graph.GetEdgeData(eid).flags.road_classification.IsLinkClass())` as highways with trunk classifications can also have this scenario." }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Space inside } missing.", "reference": "where does `master_certname` come from?" }, { "prediction": "I think it would be better to use `hrnet` instead of `hrnet`.", "reference": "The line breaking is unnecessary." }, { "prediction": "I don't think this is needed anymore.", "reference": "why not enable split by space here ?" }, { "prediction": "(style) line over 80 characters", "reference": "Shouldn't the operator be && ?" }, { "prediction": "I think this should be `vagrant_cmd` instead of `vagrant_cmd`", "reference": "My best guess is that you want to use host.name in these parts to get the name of the host ?" }, { "prediction": "Why did you remove this?", "reference": "IMO this edge case handling could remain here, just instead of overwriting the `n.nodeType`, the `makeEdgeType` method of `n` should be called, so `n.nodeType = nodeTypeEdge` -> `n.makeEdge()`" }, { "prediction": "Shouldn't this be `UserPreferences.showDownloadReport() || showAutoDownloadReport`?", "reference": "Just wondering... The two kinds of notifications are now quite different (Channel, text, maybe even icon). Would it make sense to extract the auto download notification to a new class instead of handling everything in the existing `notificationManager`? I have not checked if this will lead to a lot of code duplication, though." }, { "prediction": "I think this should be `return transport.RequestFeatures{}` instead of `return transport.RequestFeatures{}`", "reference": "Do we need to put this on the Call? We only need the API communication between the Encoding and the Transports which is currently done through the Transport.Request. The Call is used by users right?" }, { "prediction": "I think this should be `ListAPIKeys` instead of `ListAPIKeys`", "reference": "`ctx` is unused in GenerateAPIKey" }, { "prediction": "I think this should be log.L().Fatal(err.Error(), zap.Any(\"cfg\", cfg))", "reference": "Can you judge the type of error?" }, { "prediction": "`np.diff(data) / 2.` is a bit confusing. I think it would be better to use `np.diff(data[:-1])` instead of `np.diff(data[:-1] + np.diff(data[:-1] + np.diff(data[:-1] + np.diff(data[:-1] + np.diff(data[:-1] + np.diff(data[:-1]))`", "reference": "Much simpler than a weird and confusing ``convolve`` call!" }, { "prediction": "Why did you remove this?", "reference": "Huh, this seems weird to me... Surely the suspenders render was called again in order to get the new `
Hello second 2
` output... Imma take a peak at these tests to understand what's going on" }, { "prediction": "Line is too long. [82/80]", "reference": "Since this is just a helper function to create text, perhaps this could live in a helper? I noticed that we have a few other error/message creators in the application controller as well, but I think this type of function should be re-factored to be part of a helper." }, { "prediction": "Why did you remove this?", "reference": "Will this mess up parsing the messages by other editors? (vscode, vim ...)" }, { "prediction": "Line is too long. [89/80]", "reference": "Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I think this should be `block.Pool` instead of `block.Pool`", "reference": "Why can the pool be null?" }, { "prediction": "I think this is a bit confusing, but I don't think it's a good idea to do this.", "reference": "It might be good to have a note here: > work-around for issue #7562 allowing us to differentiate presentational lists from interactive lists (such as of size greater 1 and ARIA list boxes). In firefox, this is possible by the presence of a read-only state, even in content editable." }, { "prediction": "`Set> outNodes = new HashSet<>();` -> `Set> outNodes = new HashSet<>();` -> `Set> outNodes = new HashSet<>();` -> `Set> outNodes = new HashSet<>();` -> `Set> outNodes = new HashSet<>();`", "reference": "This set of changes is the one part of this that I'm not completely sure is valid. Can someone look over this to make sure I got the E's right?" }, { "prediction": "I don't think we need to check if the frontier is zero.", "reference": "There doesn't seem to be a reason to copy this here." }, { "prediction": "I think this should be `include/h2o/ebpf.h`", "reference": "We've avoided including h2o headers in BPF programs because it's a runtime dependency. However, IIRC, this is because h2olog was maintained in the separate repository so that h2olog did not know where h2o was installed. Now h2olog can use `H2O_ROOT`, we should add it to BCC's `cflags` in order to include h2o headers in BPF programs." }, { "prediction": "I think this should be `alert.query-url` instead of `alert.query-url`", "reference": "I think the docstring here should include the CLI arg `--alert.query-url` just to make it clear to users which setting this uses." }, { "prediction": "I think this should be `m.ipsetsDataplane.AddOrReplaceIPSet(m.ipSetMetadata, m.externalNodeCIDRs)`", "reference": "Same change just above?" }, { "prediction": "`asyncTest` is not needed anymore.", "reference": "Could you check the result content rather than just the number of search results please? For example with this test if the search engine suddenly starts returning \"latin n\" for both queries, we won't know about it." }, { "prediction": "I think this should be `spiffe://example.org/spire/agent/test/id`", "reference": "nit: I think that `workloadID` should suffice for this test... that's what we'd be issuing anyways" }, { "prediction": "Line is too long. [89/80]", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I think this should be `ClassNotFoundException | NoClassDefFoundError` instead of `NoClassDefFoundError`", "reference": "We should have a rule to detect identical catch branches" }, { "prediction": "Why is this removed?", "reference": "remove these from the targets file." }, { "prediction": "I think we should remove the `bzz` package from the `bzz` package.", "reference": "now that we have the signature in the hive messages, it might be that this must be drastically reduced, since there are limits on the protobuf reader/writers i believe" }, { "prediction": "I think it would be better to use `google-auth-httplib2==1.6.3` instead of `mailjet-rest==1.3.3`.", "reference": "I recommend that we move this to be optional, as other users might not need it. Can you look at `OPTIONAL_PACKAGES` section, around line 68?" }, { "prediction": "I think we should remove the import from `java.util.Iterator`.", "reference": "I usually set idea to never use wildcard import such as `import java.util.*;` Now i use setting from javaslang standard." }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Space inside } missing.", "reference": "Where is host['ips'] coming from?" }, { "prediction": "I think this is a bit confusing, but I think it would be better to use `strings.NewReader(string(data))` instead of `strings.NewReader(strings.NewReader(string(data))` instead of `strings.NewReader(string(data))`", "reference": "oh! missed a `:` here; let me fix that; also can get rid of the intermediate variable" }, { "prediction": "Line is too long. [82/80]", "reference": "Is this necessary?" }, { "prediction": "I don't think we need to do this. I think it's better to use `isTokenExpire` instead of `isTokenExpire` here.", "reference": "I'd create a different method for each render section." }, { "prediction": "I think this should be `isReverted`", "reference": "Instead of storing the revert flag in the tracer is it possible to use org.hyperledger.besu.ethereum.mainnet.TransactionProcessor.Result#getRevertReason? (via org.hyperledger.besu.ethereum.transaction.TransactionSimulatorResult#getResult)? If a TX reverts without a reason do we get an empty revert reason or a revert reason with zero bytes?" }, { "prediction": "I think we should use `SparkOrcReader::new` instead of `SparkOrcReader::new`", "reference": "I think this should test with and without container reuse if that is implemented in this PR. Probably just make this test parameterized." }, { "prediction": "I think this should be `if (fields.get(i).fieldId() == ManifestFile.SPEC_ID.fieldId()) { found = true; }`", "reference": "These modifications allow BaseFile to translate into a SparkRow with the specID as a column" }, { "prediction": "`readPreference` should be a `ReadPreference` instead of a `ReadPreference`", "reference": "is this something we've been missing this whole time?" }, { "prediction": "I think this should be `allEvents` instead of `allEvents`", "reference": "nit: this is a package-wide constant so better to narrow the scope like `allEventsSign`." }, { "prediction": "I don't think this is a good idea. I think it would be better to use `os.path.join(thrift_files_dir, 'authentication.thrift.py')` instead of `os.path.join(thrift_files_dir, 'authentication.thrift.py')`", "reference": "There seems to be some repetition. Does a local function make this code shorter overall?" }, { "prediction": "I think this should be `isHydrating = true;` instead of `isHydrating = false;`", "reference": "Might be cheaper to reuse the `null` assignment of line 313 and set `isHydrating` to null instead WDYT?" }, { "prediction": "Why is this removed?", "reference": "Revert this blank line" }, { "prediction": "I think this should be `System.setProperty(\"solr.hdfs.blockcache.blocksperbank\", \"512\");` or `System.setProperty(\"solr.hdfs.blockcache.blocksperbank\", \"512\");`", "reference": "This was introduced recently for the Hadoop 3 upgrade. Copy/paste error but definitely causing some of the new test failures." }, { "prediction": "Line is too long. [82/80]", "reference": "I think we should only need to do this for `:approve` since we are using `authenticate_user!` for all other actions and that checks for disabled client" }, { "prediction": "I think this test is not related to this PR, but it's not related to this PR.", "reference": "I wonder if we should create new tests for header checks; here for instance we're mixing querystring and headers. Thoughts?" }, { "prediction": "Line is too long. [82/80]", "reference": "We should be able to add sensitive by hard-coding the parameters, same as you put into the metadata in apply_helpers." }, { "prediction": "Why do we need this namespace?", "reference": "Why do you think that it is necessary to create this class?" }, { "prediction": "I think this should be `r.Seek(0, 1)`", "reference": "replacing the `1` with `io.SeekCurrent` may be good here" }, { "prediction": "I think this should be `FetchKeySet` instead of `FetchKeySet`", "reference": "nit: perhaps this file would be better named `jwks_source.go` ?" }, { "prediction": "I think this should be `param_override.properties` instead of `param_override.properties`", "reference": "It will be helpful to specify the intended priority as well for the properties within this file." }, { "prediction": "I think this should be `func RunFunc(*exec.Cmd) ([]byte, error)`", "reference": "Make this private and update all the public functions to not take this argument. The variable you set below should also be private, then in the tests instead of passing the variable in to the function just update the variable. We don't want to expose the testing implementation in the public api if it can be avoided." }, { "prediction": "I think it would be better to use `user/trafodion/hive/tpcds/customer.dat` instead of `user/trafodion/hive/tpcds/customer.dat`", "reference": "Do you now why is it a specific table name is used as a default?" }, { "prediction": "I think this should be `Path.Combine(Environment.GetEnvironmentVariable(\"HOME\"), \"myagent/_work/_temp\")`", "reference": "If all you're doing is checking for the existence of a directory as your \"temp\" directory, why does it matter what OS you're on?" }, { "prediction": "I think this should be `github.com/labstack/echo/v4`", "reference": "nit- would be cleaner to import it once" }, { "prediction": "I don't think this is a good idea. I think it would be better to use `headers.get('Access-Control-Allow-Headers', '*')` instead of `headers.get('Access-Control-Allow-Headers', '*')`", "reference": "Looks like there is a closing parenthesis `)` missing here." }, { "prediction": "I think it would be better to use `snprintf(str, 128, \"unknown *KEYWORD: %s\", arg[ioffset]);`", "reference": "this one bothers me. There are many places where this one is written to for an error message and just a single callsite is changed." }, { "prediction": "I think this should be `config.mockMdserv.EXPECT().FastForwardBackoff().AnyTimes()`", "reference": "You can put this in `kbfsOpsInit()` in you want, so we don't have to call it in every test." }, { "prediction": "(style) line over 80 characters", "reference": "`ARM_32` is what clients define as an input to DR, and is not always defined internally: we use just `ARM` to mean AArch32." }, { "prediction": "I don't think we need to do this in the `disco-api-schema.java` file.", "reference": "s/for use/to use for/" }, { "prediction": "I think this should be `event->getAvatarFilename()` instead of `event->getAvatarFilename()`", "reference": "` $event->getAvatarFilename()` this function return `string` or `null`. In this place ` $event->getAvatarFilename()->getValue()` return `Fatal error `" }, { "prediction": "I think it would be better to use `serviceerror.NewUnavailable(\"Persistence Max QPS Reached.\")` instead of `serviceerror.NewResourceExhausted(\"Persistence Max QPS Reached.\")` instead of `serviceerror.NewUnavailable(\"Persistence Max QPS Reached.\")`", "reference": "why not creating a new error type for server's own resource limit exceed error and do conversion within rpc interceptor?" }, { "prediction": "I think this should be `Propagators.DefaultCompositeTextMapPropagator`.", "reference": "Could be a timing thing here. When options are created they'll copy the ref for the current default propagator. If user sets through SDK the global propagator after that, it won't be reflected. Could leave it null here and then when it is used in instrumentation do `options.Propagator ?? Propagators.DefaultTextMapPropagator`. It would be a slight perf hit but it makes it hot-swappable." }, { "prediction": "Why is this removed from the `transactionValidationParams.isAllowExceedingBalance()` method?", "reference": "Unrelated file. Please remove from PR." }, { "prediction": "(style) line over 80 characters", "reference": "Careful: you only want two newlines after the final header message. (That indicates the end of headers and the start of data.)" }, { "prediction": "I don't think we need to do this here.", "reference": "This will not work on Python 3 (to which we are transitioning) because `.content` is bytes, not a str. Can you make the pattern a bytes object as well (like so: `b\"pattern\"`)?" }, { "prediction": "Why is this removed?", "reference": "This was to allow the tests to pass when the order of the required was different. Silly, but we don't have an easy way to check for \"equal but order doesn't matter\" in chai." }, { "prediction": "I think this should be done in a separate PR.", "reference": "maybe say \"returns the default cost method that returns an object of cost 1\"." }, { "prediction": "I think this should be `VXLANVNI(uint32(r.Config.VXLANVNI))` instead of `VXLANVNI(uint32(r.Config.VXLANVNI))`", "reference": "I believe these rules will be enforced both (1) on egress from a local workload, and (2) on ingress **to** a local workload. Right? I understand that we definitely want (1), but do we really want to enforce (2) as well?" }, { "prediction": "I think this should be `response.fullResponseAsJSONObject()` instead of `response.fullResponseAsJSONObject()`", "reference": "Use `response.asJsonObject()` instead. Also, use `put()` instead of `putOpt()`, `null` as a value is fine." }, { "prediction": "I think it would be better to use `parseInt(editorHolder.css('z-index')).toBeGreaterThan(0)` instead of `parseInt(editorHolder.css('z-index')).toBeGreaterThan(0)`", "reference": "Are you sure? We've changed it during an introduction of the IME support." }, { "prediction": "Why is this needed?", "reference": "I think here we want the use of `empty()` to take care of empty strings. If you put `dql_filter: ''` in your YAML config ... this will add `->andWhere('')` and it will fail, right?" }, { "prediction": "I think this should be `err := errors.Wrap(err, \"error when marshaling broadcast message\")`", "reference": "this is golang's named return, err is defined, `return` is equivalent to `return err` the current code has no problem" }, { "prediction": "This should be `out_buffer: a #GString to hold the description`", "reference": "I don't think this is right; in Rust terms it's like a `&mut String`, in Java `StringBuilder` - it's not a return value from the function which is what `(out)` is for." }, { "prediction": "I think it would be better to use `labels.size(0) > label_channels` instead of `labels.size(0) > label_channels`", "reference": "If the label is not binary, should we rename this function?" }, { "prediction": "I don't think we should use `__BeanShell(import org.apache.jmeter.services.FileServer; FileServer.getBaseDir()` here.", "reference": "This is very-very bad idea because of its performance impact" }, { "prediction": "I think we should remove this import.", "reference": "WHY U NOT SORT IMPORTS?" }, { "prediction": "I don't think we need to do this here. I think it's better to use `post` instead of `post` here.", "reference": "Put a comma after the last item of a multiline hash." }, { "prediction": "I don't think this is needed anymore.", "reference": "How come we need ``Dimensioned`` in the top-level namespace?" }, { "prediction": "Why is this removed?", "reference": "excess whitespace through plugin." }, { "prediction": "I think it would be better to use `std::size_t{ 0 }` instead of `std::size_t{ 0 }`.", "reference": "What is the problem here? I feel we used this in a lot of places." }, { "prediction": "I don't think this is necessary.", "reference": "Update the docstring." }, { "prediction": "I think we should remove this import.", "reference": "delete the empty line \"github.com/pkg/errors\" should be grouped with other third party packages same for the rest" }, { "prediction": "I think this should be `this.capabilities = capabilities == null ? new ImmutableCapabilities() : capabilities;`", "reference": "Assigning capabilities to the field here is not the best idea. Semantically this field contains the capabilities returned by the browser after session start. So here we sould better amend capabilities and return them from `init` method to pass later to `startSession` method (that will assign the capabilities returned by the browser to the field)." }, { "prediction": "Line is too long. [82/80]", "reference": "Is this a breaking change, or is the API private?" }, { "prediction": "I think it would be better to use `pd.read_json` instead of `pd.read_json`", "reference": "I don't think we need this dependency in this project right now" }, { "prediction": "I think we should use `BrokerSystemNamespace` instead of `cloud-run-events` here.", "reference": "I don't think this is necessary since `CommonLabels` is a public func and every component name is also public constant." }, { "prediction": "I think this should be `_example: { \"rb\" => [\"/usr/bin/ruby\", \"-r\", \"puppet\"], \"puppet\" => [\"/usr/bin/ruby\", \"-r\", \"puppet\"], \"puppet\"], \"puppet\" => [\"/usr/bin/ruby\", \"-r\", \"puppet\"], \"puppet\" => [\"/usr/bin/ruby\", \"-r\", \"puppet\"], \"puppet\" => [\"/usr/bin/python3\", \"puppet\"], \"puppet\" => [\"/usr/bin/ruby\", \"-r\", \"puppet\"], \"puppet\" => [\"/usr/bin/ruby\", \"-r\", \"puppet\"], \"puppet\" => [\"/usr/bin/ruby\", \"-r\", \"puppet\"], \"puppet\" => [\"/usr/bin/ruby\", \"-r\", \"puppet\", \"puppet\"], \"puppet\" => [\"/usr/bin/python3\", \"puppet\"], \"puppet\" => [\"/usr/bin/ruby\", \"-r\", \"puppet\", \"puppet\", \"puppet\", \"puppet", "reference": "The `_example` field should be updated to include an interpreter with an array value." }, { "prediction": "I think this should be `sslProtocolToStringMap` instead of `sslProtocolToStringMap`", "reference": "Put this in the godoc of SupportedProtocols instead. Preferably we would just use one map though. Why not just use this one?" }, { "prediction": "I think this should be `name` and `dockerGraphPath` as well.", "reference": "I'd feel a little safer if the first argument were a string, not a *string unless there's a particular reason for making it a pointer." }, { "prediction": "I think this should be `java.lang.reflect.InvocationTargetException`.", "reference": "Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC." }, { "prediction": "I think this should be `org.openqa.selenium.grid.sessionmap.SessionMap` instead of `org.openqa.selenium.grid.sessionmap.SessionMap`", "reference": "You can safely revert changes to this file." }, { "prediction": "I think it would be better to remove the `loss_single` function.", "reference": "This deletion is unnecessary." }, { "prediction": "I think this should be `typeof smallImage === 'string'` instead of `typeof smallImage === 'string'`", "reference": "I'm not a huge fan of this overloading of the prop; accepting very different types of arguments for props like this can be confusing, and wasn't part of the IB. I understand wanting to import the SVG directly, but the IB suggests using `${global._googlesitekitLegacyData.admin.assetsRoot}${userInputSuccessImage}` as the `src`/`smallImage` value here. It'd be great to refactor this to accept components directly in the future, but let's do that all-at-once rather than this hybrid approach that makes the API less clear." }, { "prediction": "This import is not needed anymore.", "reference": "I've had this happen recently with IntelliJ, was this intentional?" }, { "prediction": "(style) line over 80 characters", "reference": "Order(1) vs Order(logN) -- not sure it's measurable at the ~200 element size of the table. All of the published comparisons start at ~1000 elements." }, { "prediction": "I don't think this is needed anymore.", "reference": "I don't know about this aliasing and 'factory'. Previous version was rather straightforward: `location.CreateLocationResolver`. Perhaps `location.CreateResolver` would be even better? What do we actually gain here from moving DI to a separate sub-package?" }, { "prediction": "(style) line over 80 characters", "reference": "Use `UpperCamelCase` for function names" }, { "prediction": "`Number(value) >= 275761 || Number(value) < 0`", "reference": "I'm not 100% sold on this idea but I like it in general. Nice compromise between using the 'Date' constructor where possible and falling back to the pre #5880 behavior when it makes sense. However, instead of `Number(value) < 0`, let's do `Number(value) < MIN_YEAR` because `new Date('-2017')` is perfectly valid in JS and I don't want to break the date behavior." }, { "prediction": "Why did you remove this?", "reference": "Remember to close SOLR-11877 after this" }, { "prediction": "Why is this needed?", "reference": "this change should be reverted" }, { "prediction": "Why do we need to call `WaitForRegistrationEvent` here?", "reference": "This function signature is a bit complicated, some parameters are IN type (stopLoop which is modified from outside), others are OUT (registeredEvent channel which is modified inside function) I suggest the following signature -> SubscribeToRegistrationEvent(identityAddress) returns registeredEvent chan of type (RegisteredEvent not int), Unsubscribe func(), error (in case of any error). That way caller can always cance subscription if needed and check for any errors. Also - unsubscribe function hides any internal details how subscribtion is really implemented" }, { "prediction": "I think this should be `src/**/*.wav` instead of `src/**/*.json`", "reference": "`.wav`?! cannot we use something slightly more modern and compressed instead? :) I dunno, like `.mp3` or `.aac` or `.ogg`..." }, { "prediction": "(style) line over 80 characters", "reference": "Wouldn't a single signal call be enough? (without the boolean even)" }, { "prediction": "Line is too long. [89/80]", "reference": "I suspect that this whole block, which is going to be repeated a number of times, should probably be in a helper. I guess it would need to be given the object and the title and could probably figure out everything else from that?" }, { "prediction": "Line is too long. [89/80]", "reference": "Should we expose this attribute in the Asciidoctor.js API ?" }, { "prediction": "I think this should be `v.contains(element._2)` instead of `v.contains(element._3)`", "reference": "I think contains on `Multimap` was broken - it should return true if one of the values is associated with the key? It that right" }, { "prediction": "I think this should be 20.", "reference": "delete this line" }, { "prediction": "Line is too long. [82/80]", "reference": "Presumably we no longer need `force: true` here." }, { "prediction": "(style) line over 80 characters", "reference": "HIP runtime is compiled using a C++ compiler. So comparison to both NULL as well as 0 does not make sense. Just comparing to NULL is sufficient." }, { "prediction": "I don't think we should use `help_url('')` here. I think it's better to use `help_url('')` instead of `help_url('')`", "reference": "these urls are still in `a` tags so we should probably include these links separately for a non-HTML version" }, { "prediction": "I think it would be better to use `s.sys.resetCh` instead of `s.sys.resetCh` here.", "reference": "That's fine though, meaning that you can send to this channel under the server lock. The internalSendLoop will pick up the change when the server lock is released (if loop is blocked trying to grab the server lock). Even the way you do it here (releasing the lock, sending, then reacquiring) does not guarantee that the internalSendLoop will have time to refresh in that interval." }, { "prediction": "I think this should be `chromium:enableDownloading`.", "reference": "The name `enableDownloading` implies this is a boolean capability. How about `downloadDir`?" }, { "prediction": "Why is this removed?", "reference": "Found one internal team is using this method. Will coordinate with them about the migration solution." }, { "prediction": "I think this should be \"DD_HTTP_SERVER_ERROR_STATUSES\" instead of \"DD_HTTP_CLIENT_ERROR_STATUSES\".", "reference": "The field `HttpServerErrorCodes` should be called `HttpServerErrorStatuses`" }, { "prediction": "I don't think we need to add this to the list of rules.yaml files.", "reference": "Can you please make each of these in a separate line. It will be easier to keep them sorted, and add/remove." }, { "prediction": "Why do we need to check if the file path is empty?", "reference": "should we error instead of silently ignoring the `cleanup` param? it defaults to `false`, so someone must have explicitly set it to `true`" }, { "prediction": "I think this should be `err := fmt.Errorf(\"archive root directory missing: expected a 'root' directory but got %s\", archive.File[0].Name)`", "reference": "There is no specific requirement that the root be called `root`, just that there is a single root directory and that it be the first entry in the zip." }, { "prediction": "I think this should be `if current_page?(me_path) && current_user && current_user.requires_profile_attention?`", "reference": "perhaps we should encapsulate this logic in a helper method w a test?" }, { "prediction": "Line is too long. [82/80]", "reference": "Now that we're only using this repo as a Gem you shouldn't need to `require` an expanded local file path like below." }, { "prediction": "I think we should use `Long.valueOf(granularity.between(EPOCH, timestamp))` instead of `Long.valueOf(granularity.between(EPOCH, timestamp).intValue());`", "reference": "This isn't necessarily a year. It may be months, days, or hours. Can we return `intValue()` directly instead?" }, { "prediction": "Why did you remove this?", "reference": "this is redundant because it gets logged immediately on entering the handleContainerChange function" }, { "prediction": "I think this should be \"EVENT_\" + v.Event.String()", "reference": "`ds.GenericDeploymentConfig.DeploymentNotification` in L128 is nullable." }, { "prediction": "I think this should be `ProtocolContext.getProtocolContext()` instead of `ProtocolContext.getProtocolContext()`", "reference": "this shouldn't be exposed here - this class isn't a carriage for this - its used internally to determine if/how we can mine." }, { "prediction": "Why is this removed?", "reference": "It's fine to leave these checks in. It'll make the exception come from `FirefoxDriver`, and that's probably clearer to a user." }, { "prediction": "Line is too long. [82/80]", "reference": "We don't want to include the `IntegrationSpecHelper` for models...mind moving this line out of the loop to be `config.include EnvironmentSpecHelper, type: :model`?" }, { "prediction": "I think this test is not related to this PR, but I think it would be better to use `os.Chmod(file.Name(), 0666)` instead of `os.Chmod(file.Name(), 0666)` instead of `os.Chmod(file.Name(), 0666)` instead of `os.Chmod(file.Name(), 0666)`", "reference": "Please check the return on these." }, { "prediction": "I think this should be `uplink.config.cache` or `uplink.config.cache`", "reference": "Do we need `==` for true?" }, { "prediction": "I think this should be `0.0001`.", "reference": "Changing the default value may cause BC-breaking. Suggest changing this value in config." }, { "prediction": "I think it would be better to use `int(slider_pos)` instead of `int(slider_pos)` instead of `int(slider_pos)`", "reference": "how does that happen?" }, { "prediction": "I think it would be better to use `import doctest as doctest` instead of `import doctest as doctest`", "reference": "This is gross/clever. :-)" }, { "prediction": "Line is too long. [82/80]", "reference": "Take a look at the name of this file. Definitely copy and " }, { "prediction": "I think this should be `util.PageNotFound`", "reference": "Can you check with @mahebbar how to work this error. Should be different from 404." }, { "prediction": "I don't think this is needed anymore.", "reference": "Do we still need the upper bound `<3.9`?" }, { "prediction": "I think this should be `realpath(dirname(__DIR__, 3) . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'psalm')`", "reference": "Does this mean `vendor/bin/psalm` is not a symlink (or whatever equivalent Windows has for symlinks) on Windows?" }, { "prediction": "I think it would be better to use `aws_test.py` instead of `aws_test.py`", "reference": "@lpabon having a separate package name `aws_test` allows to test the package as if the tester was an external package. If the test package name is the same as the package being tested, the test package can also use methods and variables not exposed to the eventual user." }, { "prediction": "Why did you remove this?", "reference": "The exporter should still be able to test these histogram instrument kinds, right? Is there another reason to remove these?" }, { "prediction": "I think this should be `resetTxBytes` instead of `resetTxBytes`", "reference": "should this increment eval.Round somehow?" }, { "prediction": "Style/StringLiterals: Prefer single-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", "reference": "Although this change looks good. Maybe there are other inconsistent cases too?" }, { "prediction": "Line is too long. [82/80]", "reference": "This is a way better method name." }, { "prediction": "Line is too long. [82/80]", "reference": "Prefer single-quoted strings when you don't need string interpolation or special symbols." }, { "prediction": "`options` is not an array, so it should be an array, not an array.", "reference": "I was wondering if this should allow per role specification, instead of (or in addition to) a generic \"allowed everywhere\". So you could do: `{ separator: ['aria-valuenow', 'aria-valuemin', 'aria-valuemax'] }`. You could still allow the array, and you could add a wildcard option for the \"generic\" case you've got now: `{ '*': ['always-allowed'] }`." }, { "prediction": "I think this should be `wasHiveString_(FALSE)` instead of `wasHiveString_(FALSE)`", "reference": "I'm confused by the name. The string was a Hive string but it isn't any longer? Why should we care? (I imagine I'll find the answer later... there is some different semantic that we want downstream...)" }, { "prediction": "Why is this removed?", "reference": "Could you please leave the explicit imports?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Why need alias?" }, { "prediction": "I think this should be `c.tlfIDGetter` instead of `c.tlfIDGetter`", "reference": "Shouldn't this be a `libfs.nullIDGetter` (exported, of course)?" }, { "prediction": "I think this should be \"logicsig program size too large\" or \"app program size too large\"", "reference": "I dislike the messages.go pattern; the strings are only used once and make more sense in context. The other two added reportErrorf() calls in clerk.go have inline strings." }, { "prediction": "I think we should remove the `tagIdStatus` from the `tagNames_` and `tagIds_` functions.", "reference": "Seems we don't need it anymore." }, { "prediction": "Line is too long. [81/80]", "reference": "This might cause problems with the weird way we publish Guidance and Groups in the UI. We will have to make sure that UAT is thorough." }, { "prediction": "I think this should be `time.Hour`", "reference": "this default needs to be on order 1 minute, I'm not sure why we defaulted to 1 hour below..." }, { "prediction": "I think this should be `if iss.Email != \"\" {`", "reference": "I figure to make `{env.*}` work, right? I can't think of any other placeholder that makes sense here" }, { "prediction": "Why not just `network::NetworkUtils::getAvailablePort()` here?", "reference": "Why change the port from 0 to getAvailablePort()?" }, { "prediction": "I think we should remove this line.", "reference": "For me would be great don't repeat timeout sending in every get_locator call. Looks like it should be sent into LocatorsManager init. And possibly it should me non mandatory, something like that: `def __init__ (self, locators, timeout=60):`" }, { "prediction": "I think we should remove the `prompt.New()` here.", "reference": "I feel like since now we don't initiate the `opts.projectName` with `opts.ProjectName()`, which means `opts.projectName` and `opts.ProjectName()` they don't necessarily equal to each other, we need to also substitute all usage of `opts.ProjectName()` within `Ask()`, `Validate()`, and `Execute()` to `opts.projectName`. Otherwise if `-p` is set, `opts.ProjectName()` will get expired." }, { "prediction": "I think this should be `if (bytes != null && bytes.Length != 0) {`", "reference": "why do we thinkg that an empty string is ok to return from this method? I think the null should never be passed in here in the first place" }, { "prediction": "I think this should be `if (found) { return; }`", "reference": "nit: can remove this `else` since we return from the condition above." }, { "prediction": "Why is this removed?", "reference": "You missed `Write(...)`! I'm kidding ofc." }, { "prediction": "Line is too long. [82/80]", "reference": "Was there a customer who had this set to an empty string?" }, { "prediction": "I think this is a bit confusing, but I'm not sure if it's a good idea to do this, but I'm not sure if it's a good idea to do this.", "reference": "I know we have the `reporter` spec below, but what about a unit test for this to explain reasoning behind logic? If I were going to update this decorator, I would assume it wasn't covered by tests because there is no unit test." }, { "prediction": "I think this should be moved to `addForm(String name, String filename);`", "reference": "it's better to be : void attach(String name, Part part);" }, { "prediction": "I think this should be `throw new IOException();`", "reference": "I didn't see where the IOException can get thrown, is this just to match the V1 reader?" }, { "prediction": "I think this should be `forceRDKit = forceRDKit || forceRDKit;` instead of `forceRDKit = forceRDKit || forceRDKit;`", "reference": "We normally suppress this warning with `RDUSED_PARAM(forceRDKit)`" }, { "prediction": "I think this should be `mapPlayerGuids.find(guid)` instead of `mapPlayerGuids.find(guid)`", "reference": "What if `Game::getPlayerByNameWildcard` had not been called before. It would not find a player, wouldn't it?" }, { "prediction": "I don't think we need to add this to the sidebar.", "reference": "Why upper case \"R\"?" }, { "prediction": "I think this should be `return mf.BuildRequired()`.", "reference": "Does this need to return an error or could it return `false, nil`?" }, { "prediction": "Why is this needed?", "reference": "Can you not change those scopes in public API classes? This applies here and in other places -- protected changed to package-scope for source is not really an API-compatible change." }, { "prediction": "I think this should be `view_missing_traductions_only` instead of `view_missing_traductions_only`", "reference": "this parameter is only used in POST, please use `getRequest()->request->get('...');` Thanks" }, { "prediction": "Why is this removed?", "reference": "Problem number 1: Scoped packages would have a `/` character here. Changing this to `validatePackage` resolves the 403." }, { "prediction": "I don't think this is a good idea, but I think it would be better to use `deep_mapped[k] = v.map(map_fn, specs, clone)` instead of `deep_mapped[k] = v.map(map_fn, specs, clone)`", "reference": "I don't quite get why there would be key errors: ``deep_mapped`` is a clone of ``self`` and ``k`` comes from ``self.items()`` so why would the key ever be rejected?" }, { "prediction": "I think this should be `if req.ChainID != 0 {`", "reference": "this chain ID determines only from which chain to withdraw, therefore your changes do not accomplish what you want them to accomplish. You'll need changes to `func (aps *hermesPromiseSettler) Withdraw(chainID int64, providerID identity.Identity, hermesID, beneficiary common.Address) error`. The method probably has to include two chain ids: to and from. Currently, the method internally uses: `aps.config.L1ChainID` -> the chain to withdraw to `chainID` -> the chainID that was passed as the chain that the withdrawal is originating from." }, { "prediction": "I think this should be `if !sc.IsValid() { return ctx }`", "reference": "If instead we had `TraceContext.extract` return a bool value as a second return value, we could avoid the byte array comparison in `TraceID.IsValid`. Did you consider that alternative?" }, { "prediction": "I don't think we need to do this, but I think it's better to use `items[type].maxItems` instead of `items[type].maxItems`.", "reference": "here shouldn't we use `depotFreeLimit`?" }, { "prediction": "I think we should use `Rails.application.config.blacklight_export_secret_token = '<%= SecureRandom.hex(64)` here.", "reference": "Could we use the Rails application's secret token instead? Do we actually need our own here?" }, { "prediction": "I think this is a bit confusing, but I think it would be better to use `assertRaises(KeyError, lambda: kdf.a.groupby(by=['a', 'b'])` instead of `assertRaises(KeyError, lambda: kdf.a.groupby(by=['a', 'b']))`", "reference": "so should be fixed here also" }, { "prediction": "(style) line over 80 characters", "reference": "I would just remove this assert as it's going to get un-maintainable with a long list of valid sizes. Ditto below." }, { "prediction": "I think this should be `/var/lib/ecs/`", "reference": "`HostDataDir` is misleading. Can we rename it to something more relevant ? The constant should also be moved up and reused as necessary." }, { "prediction": "I think it would be better to use `ipsecESPOverhead` instead of `ipsecESPOverhead`", "reference": "I still feel like we are double-counting the outer IP header here (once in `defaultMTUGRE` and once in `ipsecESPOverhead`) but I'm not that familiar with IPsec." }, { "prediction": "I think this should be `ref DateTimeOffset dt; ref T value; ref ReadOnlySpan> tags;` instead of `ref DateTimeOffset dt; ref T value; ref ReadOnlySpan> tags;`", "reference": "Not sure what benefit we gain by extending BaseProcessor here, as this seems to be defining a new OnEnd method. Could we modify MeasurementItem to have all the things, and then MeasurementProcessor can be simply extending BaseProcessor (not blocking. just noting some observations in the PR :) )" }, { "prediction": "I think this should be `os.Path` or something like `os.Getenv(\"PATH\", \"os.Getenv(\"PATH\", \"os.Getenv(\"PATH\", \"os.Getenv(\"PATH\", \"os.Getenv(\"PATH\", \"os.Getenv(\"PATH\", \"os.Getenv(\"PATH\", \"os.Getenv(\"PATH\", \"os.Getenv(\"PATH\", \"os.Getenv(\"PATH\", \"os.Getenv\")))`", "reference": "This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards." }, { "prediction": "I think this should be `Requestlogger` instead of `Requestlogger`", "reference": "This seems like a more appropriate message under `ListenAndServe`. WDYT?" }, { "prediction": "Why did you remove the `await server.stop()` here?", "reference": "Is this not required?" }, { "prediction": "I think we should use `isset($this->entity['search']['sort']['field']) ? $this->entity['search']['sort']['field'] : $this->entity['search']['sort']['direction'] : $this->entity['search']['sort']['field'] : $this->entity['search']['sort']['field']`", "reference": "We should start thinking of an object that encapsulates this information :) we might need more arguments in the future." }, { "prediction": "I think it would be better to use `VK_DEBUG_REPORT_ERROR_BIT_EXT` instead of `VK_DEBUG_REPORT_ERROR_BIT_EXT`", "reference": "Given that we are (conceptually) searching across multiple self-dependencies, all we can say is that we didn't have a self dependency in which *both* source and dest masks were correct. Since the spec doesn't imagine this case, the valid usage statement assume we can differentiate only wrong source from only wrong dest within a *single* self-dependency -- which we can't across multiple (at least not meaningfully)... so we always return both the source/dest VUID's if we can't find a self-dependency in with *both* are correct." }, { "prediction": "Why did you remove the `when(miningCoordinator.isMining()).thenReturn(true);`?", "reference": "rename? MiningCoordinator always exists" }, { "prediction": "I think this should be `pluginManager.getConfig(\"api\").offline_mode` instead of `pluginManager.getConfig(\"api\").offline_mode`", "reference": "Here would be the same case you don't need to call `loadConfigs`, but you would need to reread configs using `getConfig` on each getHost function call, not once per file." }, { "prediction": "I think this should be `d.folder.fs.renameAndDeletionLock.Lock()`", "reference": "Unlocking with defer means that this lock is still held curing the call to forgetNode(), below, which I see attempts to acquire `f.mu`, which looks dangerous to me." }, { "prediction": "Why did you remove the `cst` here?", "reference": "Does anyone still use the cst out of this method? If not consider deleting" }, { "prediction": "I don't think we need to add the `vim-for-rails-developers` url here.", "reference": "Line is too long. [97/80]" }, { "prediction": "I don't think we need to import `io.BytesIO` here.", "reference": "This seems unused." }, { "prediction": "I think this should be `panic(\"unsupport os-release\")` instead of `panic(\"unsupport os-release\")`", "reference": "@luguanglong , Thanks for the fix, can you re-phrase it to sound better something like \"This OS version is currently un-supported by keadm\"" }, { "prediction": "I don't think we need to do this in a separate PR.", "reference": "should probably be called `_DeleteFpInfoAttr` because it removes it. Cleaning gives the impression it is still there. I would also move this to the end of the function `GetAtomicWeightsForFingerprint`." }, { "prediction": "I think this should be `std::map` instead of `std::map`", "reference": "nit, can we use `VK_PIPELINE_BIND_POINT_RAY_TRACING_KHR` here (granted it isn't else where, maybe worth fixing here or in separate PR)" }, { "prediction": "Line is too long. [82/80]", "reference": "This will need to be updated in the upcase-exercises repo as well." }, { "prediction": "Line is too long. [82/80]", "reference": "Think it's worth extracting this to `Exercise#complete?`?" }, { "prediction": "Why is this removed?", "reference": "This is still a potentially useful public method - should we remove such methods?" }, { "prediction": "Why is this removed?", "reference": "I don't understand this change, what is happening here?" }, { "prediction": "I think this should be `int(self.obj.excelCellObject.Application.Version.split('.')[0])` instead of `int(self.obj.excelCellObject.Application.Version.split('.')[0])`", "reference": "I think its worth stating this is `versionMajor`" }, { "prediction": "I think this should be `config.PreloadConfigurableConsensusProtocols(nc.algodDataDir)`", "reference": "rebuild: say loads and merges" }, { "prediction": "Why is this removed from `expect-puppeteer`?", "reference": "Why was this removed here (also in the other file)? Shouldn't we import them so that the reference in the docs below is interpreted correctly?" }, { "prediction": "Why is this removed?", "reference": "I'd prefer to have a blank line between the class declaration and its first member. Is it possible?" }, { "prediction": "I think this is not related to this PR, but I think it would be better to use `mock.DEFAULT_ISMASTER_36` instead of `mock.HELLO`.", "reference": "Is it really LEGACY_HELLO if we are using the most up to date HELLO? Perhaps `MONGOS_HELLO` would work here?" }, { "prediction": "(style) line over 80 characters", "reference": "I am afraid this is going to cause problems on Windows where it is not uncommon to have injected threads (CTRL_SHUTDOWN, CTRL_LOGOFF, etc.) we have no privileges to suspend -- and thus retrying will just fail again, and with the new \"synchall failure is fatal and should kill the process\" approach it turns what used to work for us on Windows into process death." }, { "prediction": "I don't think this is a good idea, but I'm not sure if this is a good idea. I think it would be better to use `--mac_installer_signing_identifier '` instead of `--mac_signing_keychain '` instead of `--mac_signing_keychain '` instead of `--mac_signing_keychain '`", "reference": "think it should only be in create_dist" }, { "prediction": "I think this should be `klog.V(4).Infof(\"Host Port is defined for Container %s in Pod %s, thus extra NPL port is not allocated\", container.Name, key)`", "reference": "Do you plan to support Pod spec change? Like hostPort is added/removed later after Pod creation?" }, { "prediction": "I think this should be `dokan.ExistingDir` instead of `dokan.CreateStatus`", "reference": "Is this behavior correct? It used to return `true`, which should map to `dokan.ExistingDir`. Was that previously a bug?" }, { "prediction": "I think this should be `if (!storage::SharedMonitor::exists()) {`", "reference": "What about just printing an empty list in this case? That would make the output more predictable." }, { "prediction": "I think this should be `this.container = document.querySelector('.gh-editor-container');`", "reference": "I looked and couldn't find any usage of `container` in any of the editor component files (js or hbs), so I assume this was used once and didn't get removed?" }, { "prediction": "I think we should remove the `if ($argument === '' && $form === '') {` here.", "reference": "I just updated a number of sites using older versions of Roots onto WP 3.6 and this little function change was required. Multiple search bars were displaying when I used the search widget in a widgetized sidebar. Updated the roots_get_search_form as seen in this change resolved it for me!" }, { "prediction": "I think this should be `use Thelia\\Coupon\\Type\\FreeProduct`", "reference": "Fixes test failed in some cases" }, { "prediction": "I think this should be removed from the `ads-serve.bravesoftware.com` section.", "reference": "what's the prod url for this? just curious. @amirsaber" }, { "prediction": "I think this should be `azkaban.jvm.cmd.args` instead of `azkaban.jvm.cmd.args`.", "reference": "Can you please change this to azkaban.jobs.java.opts?" }, { "prediction": "I think this should be `_x( 'Analytics', 'Service name', 'google-site-kit' )`", "reference": "Here is another concatenation which should be updated. Even though `Source:` and the link are essentially separate, it isn't RTL friendly. This would be another good use for `createInterpolateElement` I think so that we wouldn't need to include all of the classnames in the translation string (or extract them to a placeholder). That would allow us to use the `Link` component as well, rather than using its resulting HTML as a string which will be a pain to maintain if we were to make changes to the base `Link` component." }, { "prediction": "I think it would be better to use `Task.FromCanceled(cancellationToken)` instead of `Task.FromCanceled(cancellationToken)`", "reference": "I would add an overload `GetCancelledZeroTask()` which calls `GetCancelledZeroTask(CancellationToken.None)`. This is cleaner than requiring the caller to pass `default(CancellationToken)` or `CancellationToken.None`." }, { "prediction": "I think this should be `if (VK_NULL_HANDLE != swapchain) {`", "reference": "Would it be equivalent to check if `chain != nullptr` below? Not suggesting a change, just curious." }, { "prediction": "(style) line over 80 characters", "reference": "Should probably do `auto this_l (shared_from_this ());` and pass/use that instead of `this`. Same a few other places. IOW, replace both `shared_from_this()` and `this` with `this_l`" }, { "prediction": "I don't think this is a good idea. I think it would be better to use `message: `The first word in a function\\'s description should be a third-person verb (eg \"runs\" not \"run\")`.", "reference": "And here. Please, use `'` for apostrophes in changed strings in this file." }, { "prediction": "Why do we need to call `ExecuteContractRead` here instead of `SimulateExecution`?", "reference": "assignments should only be cuddled with other assignments (from `wsl`)" }, { "prediction": "I think this should be `DefaultNewBlockDataVersion(c Config, holes bool)` instead of `DefaultNewBlockDataVersion(c Config, holes bool)`", "reference": "Please move this to `block_types.go`." }, { "prediction": "Why is this removed?", "reference": "So this is not needed anymore for all attributes?" }, { "prediction": "I think this should be `FailedToGetOpenTelemetrySDK` instead of `FailedToGetOpenTelemetrySDK`.", "reference": "Happy to get suggestion for better messaging here. Here's what I intended to convey: Something is wrong - the Exception is a hint to what might be the cause The impact of that - tracing wont work." }, { "prediction": "I think we should move this to es_starter.py?", "reference": "I think we can remove this function, right? (duplicate with `ses_starter.py`)" }, { "prediction": "I think this should be `self._spark_getField(name)` instead of `self._spark_getField(name)`", "reference": "With this fix, I am not even sure we need to overwrite this function." }, { "prediction": "I think this should be `os.getenv('QUILT_USE_TQDM') == 'true'`", "reference": "Why not just import this from `data_transfer`? As a rule copying the same code twice is not a good idea. Also: please run `pylint` on all files in this PR." }, { "prediction": "Align the parameters of a method call if they span more than one line.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", "reference": "You've got an absolute path here referencing your home dir :-)." }, { "prediction": "I think this should be `unaryExprMetaModel.prefixPropertyMetaModel = new PropertyMetaModel(unaryExprMetaModel, \"prefix\", boolean.class, Optional.empty(), false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false, false);`", "reference": "Maybe I should do some sorting so that these properties don't keep moving around..." }, { "prediction": "I think we should remove this test.", "reference": "Can we keep this test anyway, as it's part of the spec?" }, { "prediction": "I think this should be `use Ergonode\\Mailer\\Application\\DependencyInjection\\CompilerPass\\MailerStrategyInterfaceCompilerPass`", "reference": "Can be removed" }, { "prediction": "I think this should be `use Config;`", "reference": "It's a minor quibble I know, but I like having the imports ordered by lengt" }, { "prediction": "I think this should be `responseEx.setContentType(produceProcessor.getName());` or `responseEx.setContentType(produceProcessor.getName());` or `responseEx.setContentType(produceProcessor.getName());` or `responseEx.setContentType(produceProcessor.getName());` or `responseEx.setContentType(produceProcessor.getName());`", "reference": "It's better to get the charset from context or other setting to let the user override it." }, { "prediction": "Why is this needed? I think it would be better to use `NewTestCStorPools` instead of `NewTestCStorPools`", "reference": "this filename as well needs change" }, { "prediction": "I think this should be `AccessKeyIDRef` instead of `AccessKeyIDSecretRef`", "reference": "I think we want to remove `omitempty` here" }, { "prediction": "I think this should be `handler.Close()` instead of `handler.Close()`", "reference": "You cannot move this here because it breaks detach. Just call `tty.Close()` before returning the error from start" }, { "prediction": "Why is this removed?", "reference": "I updated only the implicit roles who needed a update for this new rule to validate." }, { "prediction": "I think we should remove the `protoimpl` from `proto` and `protoreflect` from `proto` and `protoreflect` from `proto`", "reference": "> // Code generated by protoc-gen-go. DO NOT EDIT." }, { "prediction": "I think this should be `osconfig_not_supported` instead of `osconfig_not_supported`", "reference": "minor: skipOSConfigMetadata, otherwise, the name sounds like a boolean" }, { "prediction": "I think this should be `SyndTypeUtils.isEnclosureTypeValid(type);` instead of `SyndTypeUtils.isEnclosureTypeValid(type);`", "reference": "~~I think lines 65-67 should be moved into this else clause after `type = ...` Else, it is a bit confusing why we check the enclose type validity a second time~~ Nevermind, will do some refactoring, myself. But thanks for \"fixing\" this!" }, { "prediction": "I think this should be called `GetSessions` instead of `GetSessions`", "reference": "`sessions := endpoints.SessionsDTO{}` and using only `sessions` should be simpler." }, { "prediction": "(style) line over 80 characters", "reference": "These need to be in the other order to avoid crashing when dcontext == GLOBAL_DCONTEXT (==-1)" }, { "prediction": "Why do we need this?", "reference": "Why not change the other samples?" }, { "prediction": "`cell.getAttribute('id')` should be `cell.getAttribute('id')` instead of `cell.getAttribute('id')`", "reference": "Indentation is mixed up here due to spaces/tabs, I'm guessing." }, { "prediction": "(style) line over 80 characters", "reference": "Should we provide a little more context in the error message? Maybe throw in something about what operation was being performed?" }, { "prediction": "Why do we need to return an empty array here?", "reference": "Project standard is spaces, not tabs. Please fix and then we can merge this." }, { "prediction": "I think this should be `client_list.h`", "reference": "@hgtw is there anything we're worried about with regards to using this cache? Do we want to do staged testing around expeditions before we merge? Curious your thoughts here" }, { "prediction": "I think this should be `alwaysTrue(partFilter)` instead of `alwaysTrue(partFilter)`", "reference": "The purpose of this was to allow pushing filters into the manifest files if we ever use a format other than Parquet. I think overall this is a good change because we can add it back later. Just wanted to note why the unused argument was there." }, { "prediction": "Line is too long. [89/80]", "reference": "I think BSON::Decimal128 should always be serialized as Decimal128 regardless of config option." }, { "prediction": "Line is too long. [89/80]", "reference": "We should probably just move the `require 'bolt/plan_creator'` in `Bolt::CLI` to `Bolt::Application` so it will already be loaded." }, { "prediction": "I don't think this is a good idea.", "reference": ">20 [](start = 45, length = 2) Can we override this at runtime? Maybe it should be a command line option with default." }, { "prediction": "I don't think this is needed anymore.", "reference": "can just remove it ?" }, { "prediction": "I think this should be `CreateUpdateHook(repoPath, false)`", "reference": "Better call it `CleanUpMirrorInfo`?" }, { "prediction": "I think this should be `node.StorageMining.Start()` instead of `node.StorageProtocol.StorageProvider.Start()`", "reference": "@shannonwells is there still something missing here?" }, { "prediction": "Line is too long. [89/80]", "reference": "This could be more indicative of what it is... e.g... `stresstest_time_limit`" }, { "prediction": "Why is this removed?", "reference": "Shouldn't we do a `reader_payload_pool_.reset()` here?" }, { "prediction": "I think this is a bit confusing, but I'm not sure if we want to do this.", "reference": "I'd prefer the nomenclature less tightly coupled to DRAND throughout. I played with renaming the `drand` package to `beacon` but it was too much noise in this change." }, { "prediction": "I don't think this is a good idea, but I think it would be better to use `getattr(self, '_current_key', None)` instead of `getattr(self, '_current_key', None)` instead of `getattr(self, '_current_key', None)` and use `getattr(self, '_current_key', None)` instead of `getattr(self, '_current_key', None)` instead of `getattr(self, '_current_key', None)`.", "reference": "I think I would prefer you declare `self._current_key=None` in the constructor and just return `self._current_key`. That way you can prevent anyone from overwriting `current_key` without needing to use `getattr` here." }, { "prediction": "I think this should be `annotationMode` or `rawMode`", "reference": "I guess I like the name `mode` okay. I can't think of anything better." }, { "prediction": "I think this should be `w.DefaultTimeout`", "reference": "I would create a new method (NewStepWithDefaultTimeout?) for this purpose because timeout<=0 looks like a hidden logic" }, { "prediction": "`limit` is a bit confusing to me. I think it would be better to use `limit` instead of `limit` as well.", "reference": "Are these limit changes related?" }, { "prediction": "I think it would be better to use `from scapy.consts import LOOPBACK_INTERFACE` instead of `from scapy.consts import LOOPBACK_INTERFACE`", "reference": "Don't you mean `import scapy.consts`?" }, { "prediction": "I think this should be `e.rollbackPrimary()` instead of `e.rollbackPrimary()`", "reference": "`ctx` is unused in rollbackPrimary" }, { "prediction": "Why did you remove this?", "reference": "This is not what title says." }, { "prediction": "I think this interface should be `RuleViolationFix` instead of `RuleViolationFix`", "reference": "a fix applies several fixes? maybe this should simply be `applyToNode`" }, { "prediction": "I think this should be `fakeListOk(cli *clientset.Clientset, namespace string, opts metav1.ListOptions)` and `fakeListOk(cli *clientset.Clientset, namespace string, opts metav1.ListOptions)`", "reference": "U1000: func `fakeGetOk` is unused (from `unused`)" }, { "prediction": "I think we should use `k8s.io/client-go/util/retry.go` instead of `k8s.io/client-go/util/retry.go`.", "reference": "Because there is a \"k8s.io/client-go/tools/cache\" below, we can sort out all the \"imports\" here." }, { "prediction": "I don't think we should use `fmt` here.", "reference": "Nit should be using `goimports` to format the import statements with standard libary imports first, new line, followed by non-standard library imports." }, { "prediction": "I think it would be better to use `o.PipelineSecret != \"\"` instead of `o.PipelineStack != \"\"`", "reference": "Do we not have tests for pipeline delete " }, { "prediction": "I think this should be `requires Hadoop >= 2.3.0` or `requires Hadoop >= 2.3.0`.", "reference": "Good that you mention this constraint in the docstring :)" }, { "prediction": "I don't think we need to add the `ctrl` package here.", "reference": "remove this blank?" }, { "prediction": "Why not just `computedNumOfActivePartiions_(-1)`?", "reference": "Partitions is misspelled 8 times in this commit, might make sense to fix the spelling for all of those." }, { "prediction": "I think this should be `qutebrowser.browser` instead of `qutebrowser.browser`.", "reference": "Please remove this blank line - those are only used to group Python/third-party/qutebrowser imports." }, { "prediction": "I think this should be `cobra.Command` instead of `cobra.Command`", "reference": "`insecure` is a global variable (from `gochecknoglobals`)" }, { "prediction": "I think this should be `if setting.Repository.DisableHttpGit {` instead of `if setting.Repository.DisableHttpGit {`", "reference": "Same as above (HTTP in upper-case)" }, { "prediction": "I think we should use the `getReferenceUrl` method instead of the `getReferenceUrl` method.", "reference": "This is getting repetitive maybe you could introduce an abstract test case with a `getExpectedUrl($providerReference)` method ?" }, { "prediction": "I think this is a bit confusing, but I don't think it's worth it.", "reference": "I do not think returning `Value{}` is correct here. For example, `reflect.MakeFunc(...).Kind()` would return `reflect.Invalid` instead of `reflect.Func`. Therefore, I think this should panic instead." }, { "prediction": "`name = name.substring(2);`", "reference": "Does this work for Custom Elements? iirc we're lacking test cases for them. /cc @andrewiggins @developit" }, { "prediction": "I think this should be `m.ipsetsDataplane.AddOrReplaceIPSet(m.ipSetMetadata, m.externalNodeCIDRs)`", "reference": "Same change just above?" }, { "prediction": "Why not just `self.Promise = undefined;`?", "reference": "I suppose `apploader.js` isn't used by WebWorkers. So `self` will always be `window` here." }, { "prediction": "Line is too long. [82/80]", "reference": "Since this var is no longer defined we should remove the `if skip_targets.any?` bit below." }, { "prediction": "I don't think this is a good idea. I think it would be better to use `lambda function_qualifier_exists(function_name, qualifier=None)` instead of `lambda function_qualifier_exists(function_name, qualifier=None)`", "reference": "I think we should `return arn` as a fallback at the end of this function (otherwise the `['Resource']` entry below could become `None`)." }, { "prediction": "I think this should be `np.socketProtect = nil`", "reference": "Why session is started at all, if you need to shut it down e.g. DI should launch noopSession" }, { "prediction": "I think this should be `deleteWorkspaceFile` instead of `deleteAll`", "reference": "nit: can we rename the interface to `wsFileDeleter`" }, { "prediction": "I think this should be `ToAddresses` instead of `FromAddresses` and `ToAddresses`", "reference": "Why target cannot be external endpoints?" }, { "prediction": "I think this should be `.auto_`", "reference": "We use a suffix \".AUTOCREATED\" for configsets, maybe we can use the same here?" }, { "prediction": "I think this should be `OpenTelemetrySdk.Default.EnableOpenTelemetry`", "reference": "This one won't be disposed. Should be (something like) `using var openTelemetry = OpenTelemetrySdk.EnableOpenTelemetry(` no?" }, { "prediction": "I think we should remove this line.", "reference": "Why this is in the diff?" }, { "prediction": "I think this should be `CloudBackupGroupCreate(input *api.CloudBackupGroupCreateRequest) (*api.CloudBackupGroupCreateResponse, error)`", "reference": "How is status determined? When the user calls CloudBackupCreate( src_volume_id ) they can then call CloudBackupStatus( src_volume_id ) Is there something similar for this new API?" }, { "prediction": "I don't think this is a good idea, but I'm not sure if this is the right place for this PR.", "reference": "We could pass `excessDomChildren` to `options._catchError` and only do this if an error-boundary catches the error. Not entirely sure if that's better." }, { "prediction": "I think we should use `call_user_func_array('array_values', $this->getFilters()));` instead of `call_user_func_array('array_merge', $this->getFilters());`", "reference": "In php8 named parameters were introduced and now it is required to match called method parameter name when setting parameters by array destructing or call_user_func_array() etc." }, { "prediction": "I think this should be `if !sc.IsValid() { return ctx }`", "reference": "If instead we had `B3.extractSingleHeader` and `B3.extract` return a bool value as a second return value, we could avoid the byte array comparison in `TraceID.IsValid`. Did you consider that alternative?" }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Space inside } missing.", "reference": "I think this is more of a semantic difference than a typo - `weiter hinzufgen` is like `continue adding` whereas `weitere hinzufgen` is like `add more`. I think it makes sense to change it though " }, { "prediction": "I think this test is not related to this PR, but it's not related to this PR.", "reference": "nit: 200 is superfluous" }, { "prediction": "I think this test is not related to this PR, but it's not related to this PR.", "reference": "This is testing `unreserved keyword`" }, { "prediction": "I think this should be `projectionMethodMappings[0] = {PROJ_WKT2_NAME_METHOD_S2, 0, \"s2\", nullptr, paramsNatOrigin}, projectionMethodMappings[1] = {PROJ_WKT2_NAME_METHOD_S2, 0, \"s2\", nullptr, paramsNatOrigin}, projectionMethodMappings[2] = {PROJ_WKT2_NAME_METHOD_S2, 0, nullptr, paramsNatOrigin, nullptr, nullptr, paramsNatOrigin}, projectionMethodMappings[1] = {PROJ_WKT2_NAME_METHOD_S2, 0, nullptr, paramsNatOrigin, projectionMethodMappings[2] = {PROJ_WKT2_NAME_METHOD_S2, 0, nullptr, paramsNatOrigin, projectionMethodMappings[3] = {PROJ_WKT2_NAME_METHOD_S2, 0, nullptr, paramsNatOrigin, nullptr, paramsNatOrigin}, projectionMethodMappings[2] = {PROJ_WKT2_NAME_METHOD_METHOD_S2, 0, nullptr, nullptr, paramsNatOrigin, nullptr", "reference": "paramsNatOrigin doesn't include sUVtoST. I would just remove that definition for now" }, { "prediction": "I think this test is not related to this PR.", "reference": "It feels like the test should be waiting for the prefetcher to shut down, but I don't have a great reason why other than that it might be confusing for debugging if there are still goroutines from old prefetchers lying. But I guess since `TogglePrefetcher(false)` doesn't actually set the prefetcher to nil, the queue shutdown method will still end up waiting for the shutdown to finish. If that sounds right, nevermind me." }, { "prediction": "I think we should remove the `snippet-service: [AWS IAM]` here.", "reference": "AWS Identity and Access Management (IAM)" }, { "prediction": "I think this should be `cloudsql_cloudsql`", "reference": "As a long term thing, would it make sense to move the resource names as keys under the requirements map?" }, { "prediction": "I don't think we need to do this in the `traverseForHeaders` function. I think it would be better to use `traverseForHeaders(cell, headerType, position, tableGrid);` instead of `traverseForHeaders(cell, headerType, position, tableGrid);` instead of `traverseForHeaders(cell, headerType, position, tableGrid);`", "reference": "That doesn't fix the whole problem. The issue lays in this line right here, not the one above. There are two problems with this line: 1. It finds things that aren't cells in the table 2. if it doesn't find anything, it shouldn't return empty here, but continue down to look for row/ column headers." }, { "prediction": "Why do we need to use `getProject().getAllprojects()` instead of `getProject().getAllprojects()` here?", "reference": "I am pretty sure that this is infinite recursion as getAllProjects returns the project itself." }, { "prediction": "Why not just `data-lists`?", "reference": "Something I didn't catch before I merged this PR, is the hyphenated constant a problem? E.g. should \"data-lists\" be \"data_lists\"? @paulkaplan" }, { "prediction": "I don't think this is needed anymore.", "reference": "Can you write the test as `if not (conf.use_winpcapy or conf.use_pcap or conf.use_dnet):`" }, { "prediction": "I don't think we need to import this from dagster.core.asset_defs. ForeignAsset", "reference": "we have to include foreign assets on the repository directly because they don't belong to a job? This seems very awkward... Is this a step towards the job-less assets on the repository? Did you consider having `build_asset_job` take in a set of foreign assets instead? I suppose we would then need to subclass it to be a more special `AssetJobDefinition` that can keep track of them." }, { "prediction": "I think this should be `strncpy(name.get(), pathTemplate, len);`", "reference": "`-Wstringop-truncation` is a new kind of error detector introduced in GCC 8. As for this patch, these are two false-positives though." }, { "prediction": "I think this is a bit confusing, but I think it's better to use `credential_type` instead of `credential_process` and `credential_source` as well.", "reference": "Can we port this error msg to v2 too? This one is better, as it explicitly states what sources are allowed." }, { "prediction": "I think we should use `readPreference` instead of `readPreference`.", "reference": "The convention so far has been to require directly from the defining file (in this case `../../read_preference') . I think the concern has been mostly about the potential for circular dependency cycles" }, { "prediction": "I think it would be better to use `self.color_type = color_type` instead of `self.color_type = color_type`", "reference": "I suggest expanding dims here to simplify the formatting." }, { "prediction": "I think this file should be `kinto/config/kinto.ini.py`", "reference": "Why do you need to specify the kinto prefix here?" }, { "prediction": "I don't think this is a good idea, but it's not a good idea to use `print` here.", "reference": "The `!r` is unnecessary." }, { "prediction": "I think this should be `if accountKey != \"\" || sasToken != \"\"`", "reference": "I didn't see existing tests for this `OpenBucketURL`. Not sure if it's easy to do without mocking these `opener` calls." }, { "prediction": "I think this should be `public bool PreparerNeeded`", "reference": "Should we default to `true` ?" }, { "prediction": "I think this should be `fsm` instead of `fsm`", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I think this should be `babelrc: false, cacheDirectory: true`", "reference": "Shouldn't these options also include `@babel/preset-env`? Also I see you set `babelrc` to `false`, could we rely on our existing `.babelrc` file? Feels like some duplicate configuration otherwise." }, { "prediction": "I think this should be `wn.log.Infof(\"Peer %s disconnected: %s\", peer.rootURL, reason)`", "reference": "Nit: We can use `%s` since `disconnectReason` is a string." }, { "prediction": "why not use `boosting_type='rgf'` instead of `boosting_type='rgf'`?", "reference": "I think it's better to create a new example" }, { "prediction": "Why is this needed?", "reference": "The stages are correct, but the more forgiving `kAttachmentRasterOrder` should be used, based on a review of the spec. That should give the same effect of suppressing the false positive conflict between the DEPTH R/W and resolve. > End-of-subpass multisample resolves are treated as color attachment writes for the purposes of synchronization. This applies to resolve operations for both color and depth/stencil attachments. That is, they are considered to execute in the VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT pipeline stage and their writes are synchronized with VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT. Synchronization between rendering within a subpass and any resolve operations at the end of the subpass occurs automatically, without need for explicit dependencies or pipeline barriers." }, { "prediction": "I think it would be better to use `[!O]S(=O)[O-]` instead of `[!O]S(=O)[O-]` instead of `[!O]S(=O)[O-]`.", "reference": "To be consistent, I think it should actually just be a single `-`" }, { "prediction": "I don't think we need to import `flask.current_app` here.", "reference": "this seems extraneous." }, { "prediction": "I think this should be `featureset.LongDomainFeatureSet` instead of `featureset.LongDomainFeatureSet`", "reference": "Ah, I see here that 'LongDomain' is defined as something that contains a subdomain segment that is `maxLengthOfDomainSegment` long (which I think is 63 characters) - I don't think any public ACME servers/Let's Encrypt's staging environment has a restriction on this? if it does, and the 'pebble' based ACME server does not, then Pebble needs modifying to also fail in these cases as it aims to replicate the ACME RFC as closely as possible" }, { "prediction": "I think this is a bit confusing, but I'm not sure if this is the right place for this PR.", "reference": "I think you need `-y` here to prevent a user confirmation prompt" }, { "prediction": "I think this should be `#ifdef WINDOWS` instead of `#ifdef WINDOWS`", "reference": "Repeating: I don't think this should be a core-wide global var. This should be isolated to arch/x86 or at least arch/, maybe inside getter/setters as mentioned above." }, { "prediction": "I don't think we need to add this to the `jmeter-plugins-manager.py` file.", "reference": "right URL is like in cmdrunner, using search.maven .org" }, { "prediction": "The endpoint value should start with http or https.", "reference": "The link to valid syntax is not really applicable for NET2_1, right?" }, { "prediction": "I don't think we need to do this.", "reference": "Shouldn't it be more specific, like \"gcppubsub supports all UTF-8 strings\"?" }, { "prediction": "This test is not related to this PR, but it's not related to this PR.", "reference": "Everything in this class is SolrCloud-related, not legacy replication" }, { "prediction": "(style) line over 80 characters", "reference": "Could just assign directly and eliminate the `newval` var." }, { "prediction": "I don't think we should use `pullRequestTitleRegexp` here.", "reference": "... with the name of the affected package, or \"all\", followed by a colon,..." }, { "prediction": "I think this should be `synchronizeVersion(src/Datadog.Trace.ClrProfiler.Managed.Core/Datadog.Trace.ClrProfiler.Managed.Core.csproj`, not `synchronizeVersion(src/Datadog.Trace.ClrProfiler.Native/CMakeLists.txt, \".\")`", "reference": "We'll want to remove this one if we make the assembly version constant." }, { "prediction": "I think this should be `setup_single_page_post_style()` instead of `setup_single_page_page_style()`", "reference": "Can we have a single function here that uses the same subscribers and just changes meta based on context?" }, { "prediction": "(style) line over 80 characters", "reference": "where would ` static startup_kernel_loader skl;` be instantiated? if it's not instantiated anywhere should this be removed?" }, { "prediction": "I think we should use `getFilesAndDirectoriesApi` instead of `getFilesAndDirectoriesApi`", "reference": "I think we should move those util functions that work with drag-drop to @uppy/utils, so they can be shared (maybe later) with drag-drop plugin? Otherwise it will continue to depend on drag-drop module." }, { "prediction": "I think we should remove the `if s.VolumeLabels != nil` here.", "reference": "Migrate the spec.Labels to locator.Labels ?" }, { "prediction": "I think this test is not related to this PR, but it's not related to this PR.", "reference": "The test case already existed but it never tested properly because of the conditional in the test." }, { "prediction": "I think this should be `that.sourceId == that.sourceId && transform.equals(that.transform);`", "reference": "I'm okay with this, but I don't see a lot of benefit to removing unnecessary parens. If extra parens make something more readable (like this) or clarify order of operations even when matching the default, I would say we should keep them." }, { "prediction": "I think this should be `public static final DynamicField[] getDynamicFields() { return dynamicFields; }`", "reference": "@sarowe why was this volatile? It's fishy to see this as the only volatile field." }, { "prediction": "I don't think this is a good idea. I think it would be better to use `@since [\u4ea7\u54c1/\u6a21\u5757\u7248\u672c]` instead of `@since [\u4ea7\u54c1/\u6a21\u5757\u7248\u672c]`", "reference": "template is not correct?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Rename the registies to `BBOX_ASSIGNERS` and `BBOX_SAMPLERS` to avoid ambiguity. There is also a registry for dataset sampler." }, { "prediction": "Line is too long. [89/80]", "reference": "This is no longer stubbed on every test. Perhaps it should be, and should be unstubbed in the single case that it matters." }, { "prediction": "Line is too long. [105/80]", "reference": "This seems much simpler! I'm not sure I follow what you mean by the threading part... Also tests are not liking this constant. Might need a require or to fully qualify this." }, { "prediction": "(style) 'cf i#2144' may be misspelled - (style) 'cf i#2144' may be misspelled - (style) 'cf i#2144' - (style) 'cf i#2144' - (style) 'cf i#2144' - (style) 'cf i#2144' - (style) 'cf i#2144' - (style) 'cf i#2144'", "reference": "Convention is \"FIXME: i#2144\" or \"XXX: i#2144\"" }, { "prediction": "I think this interface should be `IHasHttpMethod`", "reference": "This should probably be a property instead of a method." }, { "prediction": "I think it would be better to keep the `state: RECONCILED` as well.", "reference": "do we need to consider setting the `state` as well? If so, lot of changes might be required, like, setting to 'Reconciling' in upgrade code, setting to 'error' or 'reconciled' in volumeReconciler functions." }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Space inside } missing.", "reference": "Line is too long. [82/80]" }, { "prediction": "This file is not used anymore.", "reference": "Add blank line below license header." }, { "prediction": "I think this should be `ops.current().buildReplacement(schema, spec, baseLocation, tableProperties);` or `ops.current().buildReplacement(schema, spec, baseLocation, tableProperties);`", "reference": "I'm not clear on whether this really should be the right behavior. Basically we're saying that a replace table will keep the existing location (as opposed to using defaults). I suspect we don't have create or replace with location semantics, but this is making some assumptions that a replacement is somehow the same as the old. If we were to go with id based pathing convention, this wouldn't work. I don't think this is an issue at this point, but it might make sense to push this down to the location provider." }, { "prediction": "I think we should move this import to `go.temporal.io/temporal-proto/execution.go`", "reference": "Just run a global replacement for all `executionproto`." }, { "prediction": "I think this should be `options=None` instead of `options=None`", "reference": "@AutomatedTester @davehunt thoughts on a new keyword argument?" }, { "prediction": "(style) line over 80 characters", "reference": "Should line 47 be OPAE_ERR?" }, { "prediction": "I think this should be `time.Now()` instead of `time.Now()`", "reference": "Not necessary, just write `time.Time{}`" }, { "prediction": "I don't think we need to do this in a separate PR, but I think it would be better to use `SettingValue(typ.PercOrInt(minperc=0, maxperc=100, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minval=8, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1, minint=1", "reference": "As these two strings simply get concatenated for the docs, there's a space missing after the dot here." }, { "prediction": "I think this should be `IntegrationOptions.RecordTelemetry()`", "reference": "What about integrations where we don't plug ourselved on OnMethodBegin?" }, { "prediction": "I think this should be `visibility_of_all_elements_located_any` instead of `visibility_of_all_elements_located_any`.", "reference": "shouldn't **call** return a boolean?" }, { "prediction": "I think this should be `@AutoValue` instead of `@AutoValue`", "reference": "ViewModel classes should not expose any classes from framework.model." }, { "prediction": "Why is this removed?", "reference": "how would you feel about keeping these tests to be more explicit and having them `assert not _validate...`? or is your view that that is too duplicative of the tests in `test_evaluator.py`?" }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", "reference": "Why do we use the `winrm_nodes` variable here and not the string `\"winrm_nodes\"` as we were using before?" }, { "prediction": "I think we should remove this line.", "reference": "why update Copyright ?" }, { "prediction": "I think this should be `if (naTable->isHbaseTable() && isSampleScan()) {`", "reference": "Does this mean we cannot update statistics with sampling on a table with LOB columns?" }, { "prediction": "I think this should be `OnInitialize` instead of `OnInitialize`.", "reference": "Look good, but I think a `[flags]` enum would be more future proof? Although i'm not sure if a flags-enum is working from the XML config. What do you think?" }, { "prediction": "I don't think we should use `ui-grid-icon-plus-squared` here. I think we should use `ui-grid-icon-minus-squared` instead of `ui-grid-icon-plus-squared`.", "reference": "Since I believe state will never be anything other than 'expanded' or collapse, you can rewrite this as follows: `return row.treeNode.state === 'expanded' ? 'ui-grid-icon-minus-squared' : 'ui-grid-icon-plus-squared'; `" }, { "prediction": "Why is this removed?", "reference": "the latter part can go but isn't the first part of this still sound -- that we assume \"id\"?" }, { "prediction": "I think this should be `value = value.replace(/\\'/g, '\\\\\\'');`", "reference": "Why is the escaping of @ and $ removed?" }, { "prediction": "I think this interface should be `IHasHttpUrl` instead of `GetRawUrl`", "reference": "Nit: `Http` is redundant in this interface's name." }, { "prediction": "I think this should be `if !exists {` or `if !exists {`", "reference": "what if I set SynchronizableEntitiesPrefix to \"a/b/c/d\" in config?" }, { "prediction": "I think this should be `if opts.DockerfilePath != \"\" {`", "reference": "nit: This error message doesn't mention that the path is a directory, maybe \"Dockerfile path is a directory:%s, please provide path to file.\"" }, { "prediction": "I think this is not a good idea, but it's not a good idea.", "reference": "This is done automatically, you can skip it next time ;)" }, { "prediction": "I think this should be `log.webelem.debug(\"Firing event on {!r}\".format(self, event))`", "reference": "This is needed in `set_value` because of `:open-editor` (you could open an editor, close the tab, then close the editor). I don't think it makes any sense to have it here?" }, { "prediction": "I think this is a bit confusing to me, but I think it would be better to use `hcl:\"profiling_enabled\"` instead of `hcl:\"profiling_enabled\"`", "reference": "Perhaps we can assume that profiling is enabled if ProfilingPort is set? And/or configure a default port and frequency, so we don't have to set three config vars every time?" }, { "prediction": "I think this should be `c.ssh.forward_agent = options['forward_ssh_agent'].nil?`", "reference": "This nil check won't correctly handle the case where forward_ssh_agent is set to false - it won't be nil but it should still not be set." }, { "prediction": "I think this should be `protocol.ConsensusCurrentVersion` instead of `protocol.ConsensusCurrentVersion`", "reference": "We could avoid passing proto since threshold isn't needed." }, { "prediction": "I think this should be `config.GetBool(config.FlagKeepConnectedOnFail)` instead of `config.GetBool(config.FlagKeepConnectedOnFail)`", "reference": "This route excluding needed for reconnect only when one connection is lost and we trying to establish another. I was thinking to make 2 separate flags for killswitch and reconnect enabling. This way we can keep killswitch working, but we don't need these routes excluded." }, { "prediction": "I think this should be `sizeof(PartitionID) + vIdLen`", "reference": "why can this modification avoid crash?" }, { "prediction": "Line is too long. [82/80]", "reference": "This looks good -- signing out the user if the current user is disabled" }, { "prediction": "I don't think we need to do this.", "reference": "The line exceeds 120 characters." }, { "prediction": "I think this should be `fmt.Sprintf(siteInfo, \"PHP version:\", desc[\"php_version\"])`", "reference": "Let's go ahead and change \"Site\" to \"Project\", since that's the path we've chosen. One less thing to alter in the other issue." }, { "prediction": "I think this should be removed.", "reference": "I am for this change iff we are sure the information is no longer helpful. I think this could still be valuable for certain scenarios, wbu?" }, { "prediction": "I think this should be `firstImageRampup.getRampupPercentage()` instead of `maxImageRampup.getRampupPercentage()`.", "reference": "I thought we decided on using the latest active version and not the one which is max ramped up." }, { "prediction": "I think we should use `color.HighlightCode(\"copilot env init\")` instead of `color.HighlightCode(\"copilot env init\")`", "reference": "can we update this to a `log.Warningf`?" }, { "prediction": "I don't think this is a good idea, but I think it would be better to use `# pylint: disable=subprocess-run-check` instead of `# pylint: disable=subprocess-run-check` instead of `# pylint: disable=subprocess-run-check`", "reference": "can we get something emitted in the logs on non-zero exits to trace back to for problems like this failing on the first invocation?" }, { "prediction": "Why not just use `schemaMan.get()` instead of `schemaMan.get()`?", "reference": "Do we need `schema manager` at here ?" }, { "prediction": "I think it would be better to use `C.CString(input)` instead of `C.CString(cstr)` instead of `C.CString(cstr)`", "reference": "This won't work because of the permissions on the directory when this is included as a library. But, we may be able to do this. The key would be wrapping this command with either a script or a go binary that ensures the current directory is writable. If the current directory is not writable, it would attempt to make it writable so that we could write out the produced binary. But I'm not sure if that will influence the hash that gets produced for `go.sum` since I am not sure how that is calculated. Alternatively, we can choose a place in `/usr/local` or choose a location that is writable in the go cache and use that. I'll give that a try since it might be needed for the ARM builds if we choose to only include `x86_64` precompiled binaries in the module." }, { "prediction": "I think this should be `r.interpreter.Eval(semPkg, r.scope, flux.StdLib())`", "reference": "Correct me if I'm wrong, but is this necessary? Why not just use the value returned by `interpreter.Eval` and not mess with the scope? `interpreter.Eval` will return any produced side effects. This means TableObjects as well as any value resulting from any expression statements." }, { "prediction": "I think this should be `labels[\"operated-alertmanager\"] = \"true\"`", "reference": "This service is global per namespace, not per Alertmanager/Prometheus/ThanosRuler instance. So this approach won't work. But maybe I missing out something, can you describe your use case here?" }, { "prediction": "I think this should be `gorm:\"default:false\"` instead of `gorm:\"default:false\"`", "reference": "Do we need this default? Since we aren't using a sql.NullBool or *bool, an unset column will be interpreted as `false` already... We don't set a default on our other bool fields (e.g. entry admin and downstream columns)." }, { "prediction": "I think this should be `show_custom_sections` instead of `show_custom_sections`", "reference": "thanks for moving these over. makes more sense for them to be in the exports_helper" }, { "prediction": "I think this should be `keyconf.startchars`", "reference": "That import now isn't needed anymore" }, { "prediction": "I think this should be `path` instead of `path`", "reference": "Can you update the `Usage` to be an absolute path as well? Something like `/path/to/firebug.xpi`" }, { "prediction": "Why is this removed?", "reference": "This class is missing the `MvxPlugin` attribute" }, { "prediction": "I think we should use `wx.GetApp().SetLayoutDirection(wxLang.LayoutDirection)` instead of `wx.GetApp().SetLayoutDirection(wxLang.LayoutDirection)`", "reference": "What if `wxLang` is returned `None` from `getWxLang`" }, { "prediction": "I don't think this is a good idea, but I think it would be better to use `return engine->ingest(std::vector({file}));` instead of `return engine->ingest(std::vector({file}));` instead of `return engine->ingest(std::vector({file}));`", "reference": "Please don't do changing like this unless it _**really**_ cares. BTW. Please look around to infer our naming conventions." }, { "prediction": "I think this should be `log.info(\"Preparing test environment\");`", "reference": "This is in test code: understanding what we're doing is important in this context." }, { "prediction": "I don't think this is a good idea, but I think it would be better to use `--goquorum-compatibility-enabled` instead of `--goquorum-compatibility-enabled`.", "reference": "prob should still have an example that has multiple option names even if you have to make it up. Or maybe we don't need this method?" }, { "prediction": "Line is too long. [89/80]", "reference": "I believe respond_to whitelists the formats passed to the block so if we don't want to display html, we can just remove the line format.html..." }, { "prediction": "I think this should be `err` instead of `err`", "reference": "stylistic nitpick: I _feel_ like we've largely shown errors like this as \"error: \" vs. \"error=\". IMO colon/space reads better." }, { "prediction": "I think this should be `rtps/history/BasicPayloadPool.hpp` instead of `rtps/history/CacheChangePool.hpp`", "reference": "We could put this implementation in `RTPSWriter::create_change_pool` and avoid an extra function." }, { "prediction": "I think we should remove this import.", "reference": "should this file ends with _test.go?" }, { "prediction": "I don't think this is needed anymore.", "reference": "It's because of this change. `ss` was unused and it made sense in the program. However I haven't read the IPv6 RFC so I'm unsure of what it does" }, { "prediction": "`flattenIndex` should be `index` instead of `index`", "reference": "\"Flatten\" is a verb, so I'd probably go with `flattenedIndex` as a variable name here." }, { "prediction": "I don't think this is needed anymore.", "reference": "If it can only be called once, perhaps a more appropriate name is something like `setMaskables`? `addX` sounds like you can add many `X`es by calling it many times" }, { "prediction": "I think this should be `s3.MakePublicS3SessionForDownload`", "reference": "Nodecfg should be downloading from a private bucket -- these shouldn't be for public consumption. In general these should be generic and expect environment to provide appropriate credentials and bucket." }, { "prediction": "I think this should be `appModuleHandler.AppModule`", "reference": "Could you please end the file with an empty line?" }, { "prediction": "I think this should be `LOG.finest(String.format(\"Detected dialect: %s\", toReturn.dialect));` or `LOG.info(String.format(\"Detected dialect: %s\", toReturn.dialect));`", "reference": "This is an incorrect change. The dialect spoken is an important part of the handshake and should be communicated to users." }, { "prediction": "I think this should be `isCanceledMx`", "reference": "Can this be non-exported to avoid direct use? It would be a breaking change but using previous package version would work." }, { "prediction": "I think it would be better to use `err.Code() == gcerrors.NotFound` instead of `err.Code() == gcerrors.Unknown`", "reference": "Nit: this is just `return gcerrors.Code(err)`, isn't it?" }, { "prediction": "I think we should remove the timeout here.", "reference": "I don't know where this came from, but it's not a good idea. This is actually timing out after 5 rounds, not 5 blocks. 5 consecutive null blocks won't be that uncommon. Also when testing with a short block time, this is a very short duration that can contribute to flaky tests." }, { "prediction": "I don't think we should use `file(statePath, \"r\")` instead of `open(statePath, \"r\")`", "reference": "In Python 3 when pickling or unpickling objects, the file needs to be opened as binary so that no text encoding/decoding takes place. So for any open calls around pickle loads or dumps, the mode for reading must be rb and the mode for writing must be wb." }, { "prediction": "Why do we need to pass the method to the `validateRead` function?", "reference": "did you remove **params.qstring.method** intentionally? if so why?" }, { "prediction": "I think this should be `read.locality.task.initialize.threads` or `read.locality.task.initialize.threads_default`", "reference": "What is the current default? Is that inconsistent across uses and that's why this is null?" }, { "prediction": "I think this should be `previouslyDeployedConfig.App = appConfig.Name` instead of `previouslyDeployedConfig.App = appConfig.Name`", "reference": "Why did we make this change? How come it wasn't an issue before" }, { "prediction": "(style) line over 80 characters", "reference": "Can you tighten scope by moving to of these variables? i.e. Move to ~4372?" }, { "prediction": "I think this should be `private static String RSERVE_PASSWORD = System.getProperty(\"dataverse.rserve.password\");`", "reference": "Nice to see this `dataverse.rserve.password` fix rolled in." }, { "prediction": "(style) line over 80 characters", "reference": "How about the following faster alternative that doesn't need `strlen()` at all: if (*tmp_optarg == '\\0' || *endptr != '\\0') { fprintf(...) ... This would treat the bus argument as invalid if it's either empty (`tmp_optarg` points to '\\0') or invalid (`endptr` points to something other that a '\\0'). Actually, the existing code would accept an empty argument and set the bus to `0`, so if (*endptr != '\\0') { fprintf(...) ... would be enough. The check for an empty argument doesn't hurt, though." }, { "prediction": "Line is too long. [82/80]", "reference": "I could be missing something here, but the `from` and `cc` are the same. On the test email sent to gatewaycommunicator, these values are different." }, { "prediction": "Why did you remove this?", "reference": "I'm honestly scared because act is now a hard requirement for useEffect which it wasn't before... This could break some tests :(" }, { "prediction": "(style) line over 80 characters", "reference": "Could use election from `info_a.election`, or is this deliberate?" }, { "prediction": "I think this should be `public static $getExtendedTypes() { return [LegacyFormHelper::getType('form')];`", "reference": "looks like this should be `return array(LegacyFormHelper::getType('form'));`" }, { "prediction": "I think this should be `assert(typeof opt_port === 'function' || typeof opt_port === 'function')`", "reference": "Maybe it would simpler to ignore opt_port if type !== 'number'?" }, { "prediction": "Why is this removed?", "reference": "Where was `name` being declared before?" }, { "prediction": "I think this should be `*appsv1.Deployment{Type: appsv1.DeploymentAvailable, Status: appsv1.DeploymentAvailable, Status: appsv1.DeploymentAvailable, Status: appsv1.DeploymentAvailable, Status: appsv1.DeploymentAvailable, Status: appsv1.DeploymentAvailable, Status: appsv1.DeploymentAvailable, Status: appsv1.DeploymentAvailable, Status: appsv1.DeploymentAvailable, Status: appsv1.DeploymentAvailable, Status: appsv1.DeploymentAvailable, Status: appsv1.DeploymentCondition{Type: appsv1.DeploymentAvailable, Status: appsv1.DeploymentAvailable, Status: appsv1.DeploymentAvailable, Status: appsv1.DeploymentAvailable, Status: appsv1.DeploymentAvailable, Status: appsv1.DeploymentAvailable, Status: appsv1.DeploymentAvailable, Status: appsv1.DeploymentAvailable, Status: appsv1.DeploymentAvailable, Status: appsv1.DeploymentAvailable, Status: appsv1.DeploymentAvailable, Status: appsv1.DeploymentCondition{Type: appsv1.DeploymentAvailable, Status: appsv1.DeploymentAvailable, Status: appsv1.DeploymentAvailable", "reference": "nit: use `corev1.ConditionUnknown`" }, { "prediction": "I think we should use `/^[a-f0-9]*$/.test(v)` instead of `/^[a-f0-9]*$/.test(v)`", "reference": "You also need to add a similar check on line 992, there's another place where we check `length === 24`" }, { "prediction": "Shouldn't this be `checkState(validatorProvider.getVoteProviderAfterBlock(parentHeader), \"Bft requires a vote provider\");`?", "reference": "nit: can extract the voteProvider as a local variable" }, { "prediction": "Why did you remove this?", "reference": "[0] Not suggesting you change it here, but....kindof weird that there's just not an `assertFuncNotEquals`" }, { "prediction": "I think we should use `context.WithTimeout(context.Background(), bc.bcTimeout)` instead of `context.WithTimeout(context.Background(), bc.bcTimeout)`", "reference": "why are we passing 'registryAddress' here? We probably should construct it together with bc. Registry is not something that change?" }, { "prediction": "I think it's better to use `{@link RA.spreadPath|spreadPath}` instead of `{@link RA.spreadPath|spreadPath}`", "reference": "`.` at the end of the sentence" }, { "prediction": "I think this should be `time.Now()` instead of `time.Now()`", "reference": "wouldn't it be useful to split this into an error metric for the timing?" }, { "prediction": "Line is too long. [89/80]", "reference": "Not sure if this is good enough. Each generator will have it's own unit test anyway. Ideally, I think I'd want to test that each generator in the yml is actually a valid generator..." }, { "prediction": "I think this should be `MintNewBlockWithActionIterator(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(blkToMint, nil).AnyTimes()`", "reference": "line is 138 characters" }, { "prediction": "I think this should be `func Close(ctx context.Context, certSource proxy.CertSource, params *Params) (context.Context, certSource proxy.CertSource, params *Params) (context.Context, certSource proxy.CertSource, params *Params) (context.Context, certSource proxy.CertSource, params *Params) (context.Context, certSource proxy.CertSource, params *Params) Close(ctx context.Context, certSource proxy.CertSource, params *Params) Close(ctx context.Context, certSource proxy.CertSource, params *Params) Close(ctx context.Context, certSource proxy.CertSource, params *Params) Close(ctx context.Context, certSource proxy.CertSource, params *Params) Close(ctx context.Context, certSource proxy.CertSource, params *Params) Close(ctx context.Context, certSource proxy.CertSource, params *Params) Close(ctx context.Context, certSource proxy.CertSource, params) Close(ctx context.Context, certSource proxy.CertSource, params) Close(ctx context.Context, certSource proxy.CertSource, params) Close(ctx context.Context, certSource proxy", "reference": "Nit: I would leave `Wire` out of the description; if you use this without wire you can still use it." }, { "prediction": "I think this should be `com.google.api.tools.framework.model.Field`", "reference": "Nit: each field can be on a separate line to make it visually easier to read." }, { "prediction": "I think this should be `compiler_info.json` instead of `compiler_info.json`.", "reference": "Do we still have these files? Shouldn't we remove these?" }, { "prediction": "I think this should be `ErrDurationInvalid`", "reference": "A lot of things to do with constants seemed to move since the original commit, so I stuck this here, Is there a better place for it?" }, { "prediction": "I think this is a bit confusing, but I think it's a bit confusing to me.", "reference": "is 10 too small compared to 1000? consider sync chan is unicast only (vs block chan is broadcast + unicast), i would say use 200~400 for BlockSyncChanSize my concern is that this would potentially slowdown sync speed of full-node" }, { "prediction": "I think this is a bit confusing, but I'm not sure if we want to keep the `plans.reject { |plan| get_plan_info(plan.first)['private']}`.", "reference": "A full parse of the plan here on listing the plans will be expensive from both a computation and IO perspective." }, { "prediction": "I don't think we need to do this. I think it's a bit confusing to me.", "reference": "These constants use the `_PIN` suffix, while the other constants don't use it. I'm not sure what is best, but I would prefer to keep this consistent. Do you have an opinion on which it should be (with or without suffix)?" }, { "prediction": "I don't think we need to add this to the `PicoCLI` class.", "reference": "Hmm... this feels like discovery should come first. perhaps `--discovery-dns-url`? @NicolasMassart any opinions on this or ideas on who it should be run by?" }, { "prediction": "I think this should be `go:build!ignore_autogenerated` instead of `go:build!ignore_autogenerated`.", "reference": "why is this needed?" }, { "prediction": "I think this should be `key` instead of `key`", "reference": "I wonder if it'd be possible to autogenerate a key from the name within this function if one is not provided explicitly, rather than having all the callsites pass both the name and key (and usually as the same value)? Might give us a good place to implement a `name->key` function that isn't 1:1." }, { "prediction": "I think this is a bit confusing, but I don't think it's worth it.", "reference": "@adriancole I do not see a change in the thrift file. Are there unit tests verifying that this manual serialization is compatible with the native Thrift serialization done by classes generated from `.thrift` IDL file?" }, { "prediction": "(style) line over 80 characters", "reference": "spelling (variable name, all three changes)" }, { "prediction": "I think this is a bit confusing, but I don't think it's a good idea to do this.", "reference": "I believe you meant \"specify `desiredUID` and `desiredRole`\"?" }, { "prediction": "I think this should be removed.", "reference": "Please follow the import style, move it to its similar group" }, { "prediction": "I think this should be `router.Choose(want, string(req.Encoding))` instead of `router.Choose(want, string(req.Encoding))`", "reference": "Do we really need these? This is expanding on an API that we're about to do work on with the error stuff @kriskowal" }, { "prediction": "Why is this needed?", "reference": "passwordModificationTime is no longer used - did the change drop a time check that should be restored? Or should the param get dropped from the methods?" }, { "prediction": "I think this should be `evt.CommandLine.Trim()` instead of `evt.CommandLine.Trim()`", "reference": "Would it break here without trim? If so, can we do trim in Startup.cs so we don't need to add this code to every parser?" }, { "prediction": "I think this should be `log.Printf(\"iptables output='%s', out=%v\", string(out))`", "reference": "Since we're using Logrus, probably best to use `Infof` to avoid confusion (Logrus' Printf behaves differently to the built in one)" }, { "prediction": "I think this should be `svgText.getComputedTextLength(this.isLabel_);`", "reference": "Hm, this looks like a change that should go upstream as well." }, { "prediction": "I think we should remove the `hasActionIndex` check here.", "reference": "let's keep ActionByActionHash and delete getActionByActionHash" }, { "prediction": "Why not just return `$this->pricingGroup`?", "reference": "please use return type" }, { "prediction": "I think this should be `LOG.info(\"edgedriver will log to \" + logFile);`", "reference": "This is deliberately at this level." }, { "prediction": "`as msg: %s` should be `as msg: %s` instead of `as msg: %s`", "reference": "I'm going to go ahead and undo this change, I don't think it was intentional." }, { "prediction": "I think this should be `AppDomain` instead of `AppDomain`", "reference": "> specialised This isn't a typo in my neck of the woods " }, { "prediction": "I think it would be better to use `knative-gcp/test/cmd/storageTarget` instead of `knative-gcp/test/cmd/storageTarget`.", "reference": "will change to `storage_target`" }, { "prediction": "I think this should be `v1beta1` instead of `v1`", "reference": "This would be better as `cls.securitycenter_client`, to match what is being instantiated." }, { "prediction": "I think this should be `hasSeparateSyswow32` instead of `hasSeparateSyswow64`.", "reference": "Could we have this initialization as part of the initialize method?" }, { "prediction": "I think this should be `editController: inject.controller('patients/edit-controller')` or `editController: inject.controller('patients/edit-controller')` or `editController: inject.controller('patients/edit-controller')` or `editController: inject.controller('patients/edit-controller')` or `editController: inject.controller('patients/edit-controller')`", "reference": "This line should be removed as editController is not used from this context anymore." }, { "prediction": "I think this should be `RetractTable(id DatasetID, key flux.GroupKey, tbl flux.Table)`", "reference": "This is correct in concept but the method signature doesn't really communicate the same thing. In other words, if the function produces an output table where is it? Its not on the function signature. Can you explain where the output table is created?" }, { "prediction": "I don't think this is a good idea, but I think it would be better to use `self.init_cfg = init_cfg['checkpoint']` instead of `self.init_cfg = init_cfg['checkpoint']`", "reference": "For insurance, it's best not to take it directly" }, { "prediction": "Why do we need to change the method name to `beforeChangeValueOf(WebElement element, WebDriver driver, CharSequence[] value)`?", "reference": "change 'value' to keysToSend, here and in other references in this commit. 'value' implies the user is getting the value of the element, rather than just the keys we're sending to it." }, { "prediction": "I think this should be `engine.state.AddTaskIPAddress(taskIP, task.Arn)`", "reference": "is the plan to fully migrate to boltdb and then remove the state save here?" }, { "prediction": "I think this should be `output.colorUrl = '#7B81FF';`", "reference": "This should be `output.colorBright`. Unless I'm missing some reason for adding a new theme variable." }, { "prediction": "I think this should be `version_major=0` and `version_minor=0`", "reference": "nit: I wonder if these should be moved down to where version is defined, just to keep them all in the same place." }, { "prediction": "I don't think this is needed anymore.", "reference": "Is this supported by every implementation of Java (and Android)? Should it be conditional upon `gen_nullable`?" }, { "prediction": "Line is too long. [81/80]", "reference": "@briri Thanks! I just caught this too updating my feature branch" }, { "prediction": "I think this should be `if len(configKey) > 0 && envpw != \"\" {`", "reference": "I think you should move this block (and the `envpw := os.Getenv(\"RCLONE_CONFIG_PASS\")`) right to the start of the function, then we can remove the duplicate code below" }, { "prediction": "This test is not related to this PR.", "reference": "Is this only to set the node to draining? I think we can do that inside `Before` or something?" }, { "prediction": "I think this should be `if (AzureAppServices.Metadata.IsRelevant) { return AzureAppServices.Metadata.SiteName; }`", "reference": "This should have been moved up above this inner `try` because the log message in the `catch` block does not apply to this." }, { "prediction": "Line is too long. [82/80]", "reference": "Do we expect people to use PlanResult directly?" }, { "prediction": "Why do we need to use `actualErr` here?", "reference": "Maybe we should call this something like `errToReturn`?" }, { "prediction": "I don't think we need to do this in the future.", "reference": "should calculate numEpochIn1Year = xxx and <= fairBankEpochNum+numEpochIn1Year a.foundationBonusLastEpoch just happens to be equal to 1 year now, but should not count on that" }, { "prediction": "I think it would be better to use `phrasing: 'none'` instead of `phrasing: 'none'`", "reference": "I wasn't sure if the content type needed to be removed from both the `default` and `usemap` objects - I'm not sure how usemap is used." }, { "prediction": "I think it would be better to use `StructField` instead of `StrField`", "reference": "Duplication of line 28 Please refer your tox -e flake8 It seems that XStrField, XShortField, FieldLenField are not used" }, { "prediction": "I think this should be `self._file_view.setRowHidden(self._root_index, self._file_model.index(path))`", "reference": "I don't really understand the `self._file_model.index(path)` as parent here - you use `self._root_index` for `rowCount` above, so wouldn't the parent here need to be `self._root_index` as well?" }, { "prediction": "I think this should be `maxQueryLength` instead of `minQueryLength`", "reference": "Do we want validation somewhere that max >= min? Or simply treat the max < min case as ignoring max?" }, { "prediction": "I think this should be `when:when='${ndc:topframes=1}' == '':inner=:else=${ndc}| }`", "reference": ":+1: that's a easier example :)" }, { "prediction": "I think this should be `findProductIdsWithBoundAttributeByAttributeId` instead of `findProductIdsWithBoundAttributeByAttributeId`", "reference": "If an external module decorates this interface, such a change will cause it to generate an error" }, { "prediction": "(style) line over 80 characters", "reference": "Oh ha hah, FNM_PERIOD worked out nicely there. Points for co-opting a file system convention." }, { "prediction": "I think it would be better to use `go.uber.org/zap` instead of `go.uber.org/zap`.", "reference": "wrong grouping. As you can tell from the other files, we put system packages in the first group, the 3rd party packages in the second group, and our own packages in the third group." }, { "prediction": "I think this should be `if o.appName != \"\" {`", "reference": "Is `o.name` always set here?" }, { "prediction": "I think it would be better to use `target.SteadyStateDependencies` instead of `target.SteadyStateDependencies`.", "reference": "Can this line be removed, as `SteadyStateDependencies` isn't updated anywhere? Also do we need to check the `TransitionDependencySet` here?" }, { "prediction": "I think this should be `has_active_subscription? && plan.present? && plan.has_annual_plan?` instead of `has_active_subscription?`", "reference": "`plan.present?` and `has_active_subscription?` are equivalent. We can drop this change, while leaving the one on `app/controllers/application_controller.rb`." }, { "prediction": "I think this should be `# pylint: disable=too-many-locals` instead of `# pylint: disable=too-many-locals`", "reference": "No need for this, as pylint already only turns things off for this function and it's needed for the entire function." }, { "prediction": "Why is this needed?", "reference": "L171 needs to be modified too?" }, { "prediction": "(style) line over 80 characters", "reference": "Why do you compare by nodeid? Simply saying d == e should be enough. Unless we have to objects in memory with the same nodeid. If that is so, something went really wrong." }, { "prediction": "I think it would be better to use `_delete_=True` instead of `_delete_=True`", "reference": "configs/pvt/retinanet_pvt_t_fpn_1x_coco.py --> configs/pvt/retinanet_pvt-t_fpn_1x_coco.py" }, { "prediction": "I think this should be `json:\"DesiredStatus\"` instead of `json:\"DesiredStatus\"`", "reference": "Nit, this could be json:\",omitempty\"" }, { "prediction": "I think this should be `BuildRequired` or something like `BuildRequiredFromDockerfile` or something like `BuildRequiredFromDockerfile` or something like `BuildRequiredFromDockerfile` or something like `BuildRequiredFromDockerfile` or something like `BuildRequiredFromDockerfile` or something like `BuildRequiredFromDockerfile` or something like `BuildRequiredFromDockerfile` or something like `BuildRequiredFromDockerfile` or something like `BuildRequiredFromDockerfile` or something like `BuildRequiredFromDockerfile` or something like `BuildRequiredFromDockerfile` or something like `BuildRequiredFromDockerfile` or something like `BuildRequiredFromDockerfile` or something like `BuildRequiredFromDockerfile` or something like `BuildRequiredFromDockerfile` or something like `BuildRequiredFromDockerfile` or something like `BuildRequiredFromDockerfile` or something like `BuildRequiredFromDockerfile` or something like `BuildRequiredFromDockerfile` or something like `BuildRequiredFromDockerfile` or something like `BuildRequiredFromDockerfile` or something like `BuildRequiredFromDockerfile` or something like `BuildRequiredFromDockerfile` or something like `BuildRequiredFromDockerfile` or something like `BuildRequired", "reference": "It's kinda funny to read `s.Image.Image` I wonder why it resulted to this way. What would it take to refactor to just `s.Image`?" }, { "prediction": "I think this should be `deploy` instead of `deploy`.", "reference": "nit: I like the idea! can we instead change the tag to `integration-remote` to be more specific? I feel like it's possible for us to use the `deploy` build tag for possibly another scenario" }, { "prediction": "(style) line over 80 characters", "reference": "Copy and paste error here. Edit: Also missing commas here and in other Perl croaks between some parameters and not others." }, { "prediction": "Why do we need to use `KeccakStateRoot` instead of `KeccakStateRoot`?", "reference": "stateRoot or maybe ParentHeader would make more sense from API point of view?" }, { "prediction": "Why is this removed?", "reference": "Are you sure that this is no longer needed?" }, { "prediction": "I think this should be `SCAN_COLUMNS_WITH_STATS_COLUMNS` instead of `SCAN_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_COLUMNS_WITH_STATS_", "reference": "Would it help to use SCAN_COLUMNS as base to build SCAN_WITH_STATS_COLUMNS e.g like so `SCAN_WITHSTATS_COLUMNS = ImmutableList.builder().addAll(SCAN_COLUMNS).add(\"value_counts\",....).build()` ?" }, { "prediction": "I think we should remove the deprecated service.", "reference": "`ctx` is unused in ReportStat" }, { "prediction": "I think this should be `#include \"t_generator.h\"`.", "reference": "We don't want to add boost as a dependency when building the Thrift compiler. Sorry." }, { "prediction": "(style) line over 80 characters", "reference": "It's not printing the range. Also I think it's useful to print a warning above stating that the minimum change is -1000." }, { "prediction": "I think it would be better to just return a `*sched.SchedPolicy` and return a `*sched.SchedPolicy`", "reference": "if name is empty will this become enumerate ? (and cause the unmarshal to fail ?)" }, { "prediction": "Style/StringLiterals: Prefer single-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", "reference": "How about including a flash message that explains the exercises are only available to subscribers of X plan?" }, { "prediction": "I think this should be `modeman.leave(self._win_id, usertypes.KeyMode.command, usertypes.KeyMode.command, 'prefix deleted')`", "reference": "You should also call `e.accept()` and `return` so the key press isn't processed further (as we're leaving insert mode anyways)." }, { "prediction": "I think this should be `ENV[\"EMAIL_RECIPIENTS\"]` or `ENV[\"EMAIL_RECIPIENTS\"]`", "reference": "Freeze mutable objects assigned to constants." }, { "prediction": "Why did you remove the `pageWait` here?", "reference": "Hmm, this feels hacky. Maybe good enough if it makes the test more stable, but why is timing even an aspect here, since below it should wait for these two things anyway?" }, { "prediction": "I think this should be `if (!string.IsNullOrEmpty(xForwardedFor)) {`", "reference": "Do we want this on by default, or an opt-in (e.g. via some config while add the instrumentation)? I guess a more general question is - what's the bar for the default vs opt-in tags." }, { "prediction": "Why did you remove this?", "reference": "`status` is just one of the features, named as status is not suitable." }, { "prediction": "I think this should be `if (UserPreferences.getFeedFilter() != UserPreferences.FEED_FILTER_NONE) { Iconify.addIcon(feedsFilteredMsg);`", "reference": "There is an option to hide the subscriptions list from the sidebar. If it is hidden, the filter text should not be displayed." }, { "prediction": "I think this should be `getInt(\"query/memoryCircuitBreakerThreshold\", 100);`", "reference": "I'd like for all of this to be dynamically configurable at some point, but it doesn't have to be in this PR. Can add it to the future SIP or create a separate JIRA for it, as you think would be appropriate." }, { "prediction": "Why is this removed?", "reference": "move the constructor to down the `namespace`" }, { "prediction": "I think this should be `*corev1.ObjectReference` instead of `*corev1.ObjectReference`.", "reference": "Nit: ending with a '.' looks consistent with the fields around it." }, { "prediction": "I think this is a bit confusing, but I don't think it's worth it.", "reference": "Audit log will not have a warning about they are using a deprecated path, is it something we must care about?" }, { "prediction": "I think this should be `TypeMemberVisibility.FamilyOrAssembly` instead of `TypeMemberVisibility.FamilyOrAssembly`.", "reference": "I think you also want to update the condition to add ` || impl.Visibility == TypeMemberVisibility.FamilyOrAssembly`." }, { "prediction": "I don't think this is needed anymore.", "reference": "`DepositToRewardingFundBaseGas` is a global variable (from `gochecknoglobals`)" }, { "prediction": "I think this should be `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop` or something like `Develop`?", "reference": "What do you think of \"operations\"?? Also what do these emojis look like on Linux??" }, { "prediction": "I don't think we need to add the `tagline` here.", "reference": "I like the word \"give\" here. Feels like I'm giving a gift to my team." }, { "prediction": "I don't think this is needed anymore.", "reference": "Is it possible to use `np.random` module instead?" }, { "prediction": "I think it would be better to use `default=None, allow_None=True, doc=\"\"\"` instead of `allow_None=True`", "reference": "``default=None`` implies ``allow_None`` so ``allow_None`` is superfluous here. As a special case, if allow_None=True (which is true by default if the parameter has a default of None when declared) then a value of None is also allowed." }, { "prediction": "I think this should be hardcoded to k3s-controller because it's hard coded in the rolebindings.yaml", "reference": "Is there anything in particular that makes setting up the downstream rolebinding(s) to `system:k3s-controller` burdensome or confusing? This changes looks fine to me but it seems a shame to alias an embedded k3s controller. If we are doing this in other places that I am not aware of then we can dismiss this concern out of hand." }, { "prediction": "I think it would be better to use `acd` instead of `acd` as well.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I think this class is not used anywhere else.", "reference": "nit: all other types in this project have full names, so maybe a better name would be `OperatingSystem`?" }, { "prediction": "I think this should be `#include `", "reference": "Why is this needed here?" }, { "prediction": "I think this should be `return Optional.of(methodUsage)` instead of `return Optional.empty()`", "reference": "mmm, why a method declaration should not have the TypeVariableResolutionCapability? Is this ok?" }, { "prediction": "I think we should remove the `privateTransactionHandler` from the constructor and add the `privateTransactionHandler` to the constructor.", "reference": "nit: any reason you swapped the ordering?" }, { "prediction": "Why do we need to do this here?", "reference": "can you de-uglify at least this line?.. hard to tell what changed..." }, { "prediction": "I think we should remove the `LoadSockopsAuto` function.", "reference": "Please can you merge master in before making these changes. I just reinstated a bunch of BPF UTs. Possible that the UTs use this code." }, { "prediction": "I think it would be better to use `type(self).__a(cls)` instead of `type(cls).__a(cls)` instead of `type(cls).__a(cls)`", "reference": "Do you want to add additional cases for `Bla.__b()` and `self.__c()`? (Just add additional classmethods `__b` and `__c` and the calls to `__init__`)" }, { "prediction": "I don't think we need to do this here.", "reference": "the recids is never changed after. So, it should contains the exact shown results, whatever are the rights for the user (admin or simple user, restricted collections...)" }, { "prediction": "I think this should be `if len(realOpts.ContentMD5) == 0 {`", "reference": "Shouldn't the docstring mention that the MD5 checksum of `p` is computed each time and verified? Also, could there be use cases where a caller might not want such a check to happen because, eg, a blob storage solution doesn't provide MD5 verification or uses another hash algorithm such as SHA256?" }, { "prediction": "I don't think we need to do this here. I think it would be better to use `obj.focusRedirect = obj.focusRedirect` instead of `obj.focusRedirect = obj.focusRedirect` instead of `obj.focusRedirect = obj.focusRedirect`", "reference": "focusRedirect is used in the powerpnt appModule. We might have to make sure that this does not break. Having said that, I really like this being handled on the events level!" }, { "prediction": "I think we should remove this file.", "reference": "You imports are out of order" }, { "prediction": "Why is this needed?", "reference": "This should not be called Flow Trigger. FlowTrigger should has its own flowTrigger job name, for instance, \"flowtrigger\"" }, { "prediction": "I think it would be better to use `config.SQLite3File` instead of `config.SQLite3File`.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I think this should be `#if DEBUG` instead of `#if DEBUG`", "reference": "Why do we need `\\n` if we already use `WriteLine`? (and `\\n` is not cross platform)" }, { "prediction": "I think this should be \"besu\" instead of \"prometheus\".", "reference": "What is instrumentation name used for? I'm not seeing other classes use it, only a getter, constructor, and builder." }, { "prediction": "Why did you remove this?", "reference": "@kristofgazso could you review these warnings?" }, { "prediction": "I think this should be `console.log(\"hi\")`", "reference": "will delete this." }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Space inside } missing.", "reference": "~~Indent 2 lines above~~ Disregard. My fault" }, { "prediction": "I think this should be `!item.getType().isRepeated()` instead of `item.getType().isRepeated()`", "reference": "What was the bug that this is fixing?" }, { "prediction": "I don't think we should use `base64.b64encode('%s:%s', parsed_url.username, parsed_url.password)` here.", "reference": "This will always add the authorization header to the request object. Is this the right scope for these two lines? If username/password are not defined, it will encode 'Basic :'" }, { "prediction": "(style) line over 80 characters", "reference": "Is this always how Bazel does paths? Would it be nicer to do `-DBAZEL_TEST_DATA_PATH=../com_github_google_flatbuffers/tests/` so this string is not hardcoded in the the source?" }, { "prediction": "I don't think we should use `date_utc` here.", "reference": "Not an expert of ES, so not sure of the impact here." }, { "prediction": "Why not just `granteeList = currContext->getRoleList(numRoles, roleList, granteeList);`?", "reference": "Who deletes the memory for the granteeList? (or the roleList for that matter)" }, { "prediction": "Why do we need to do this here?", "reference": "This loop is missing a lock on subscriptions_mutex." }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Space inside } missing.", "reference": "shouldn't clearance be setting these up for us?" }, { "prediction": "I think this should be `noOp` instead of `noOp`", "reference": "Need to update the doc for `TelemetrySDK` and `Host` structs deleting references from removed functions." }, { "prediction": "I think this should be removed.", "reference": "I think we should keep that here and add a new method `isSyntacticallyFinal` that returns `super.isFinal()` (and can be used in UnnecessaryModifier). Otherwise the contract of `isFinal` is not respected" }, { "prediction": "`scrollIfNecessary` is a bit confusing, but I'm not sure if this is the right thing to do here.", "reference": "Is there a reason why we wouldn't want to check this every time? Why are we only checking for the footer and scroll bar when enableCellEditOnFocus is true?" }, { "prediction": "I think this should be `com.playonlinux.ui.api.InstallerFilter` instead of `com.playonlinux.ui.api.InstallerFilter`", "reference": "You need to create an API for this class. This class should follow roughly the same dependency structure than RemoteAvailableInstallersPlayOnLinuxImplementation / RemoteAvailableInstallers. Maybe we could use a inner class here?" }, { "prediction": "I don't think this is needed anymore.", "reference": "This should not be a case, right? If `run_id` is the same `workflow_id` can't be changed. Actually surprised that it is not part of a key." }, { "prediction": "I think it would be better to use `generator->setAqrEnabled(FALSE);` instead of `generator->setAqrEnabled(FALSE);`", "reference": "How would AQR work for an INSERT/SELECT of one table into another where a LOB column is being copied?" }, { "prediction": "I think this should be `sds_v3` instead of `secret_v3`", "reference": "Since these are ultimately different endpoints, it would be nice if we could move them up one level and nuke the common `sds` directory in order to reduce path stutter" }, { "prediction": "I think this should be `if (beforeChangeResult === false || beforeChangeResult.length === 0 || beforeChangeResult[0] === null)`", "reference": "Please check also whether `null` occurs in the rest of `beforeChangeResult` array." }, { "prediction": "I don't think this is client side.", "reference": "Outdated docs. There is no response, there's an ack." }, { "prediction": "I think this should be `libcontainer.Exec(libcontainer.InitContinueSignal)` instead of `libcontainer.Exec(libcontainer.InitContinueSignal)`", "reference": "I'd rather have the container process remove the FIFO after it unblocks. Then `start` can always `Exec()`, and you can catch the \"FIFO does not exist\" error and translate it to a prettier \"someone must have already started the container\"." }, { "prediction": "I think this should be `if err != nil || tx == nil {`", "reference": "can you check if there's other similar cases to add nil-check like this?" }, { "prediction": "I think it would be better to use `is_valid_commonname = (commonname is not None and len(commonname) < 64)` instead of `is_valid_commonname = (commonname is not None and len(commonname) < 64)`", "reference": "`<= 64`? I just picked up what you said in #3981 (\"the CN field is limited to 64 characters\") but maybe there's something I don't know where the 64th character is needed (trailing dot or whatever?) Also this sounds like something that could be beautifully unit tested. Sorry for bugging you :grin:" }, { "prediction": "Line is too long. [82/80]", "reference": "I understand that this grabs a Licenses objects but what is the autocomplete method used for? What does this do in context of the auto_completes controller?" }, { "prediction": "I think it would be better to use `blockchain.getTransactionLocationByHash(transactionHash)` instead of `blockchain.getTransactionLocation(transactionHash)`", "reference": "I don't really like that way of naming methods based on their arguments. But I can see that the other method names are the same ..." }, { "prediction": "I think it would be better to use `value.substring(0, value.length() - 1)`.", "reference": "@sekmiller This method correctly strips the leading and trailing slashes (and also \".\" and \"-\"); But I thought the plan was also to replace any multiple slashes between nested folders with a single slash. For example, as implemented now, I can enter \"folder1///folder2\", and it gets saved and displayed like this, with the 3 slashes. I thought we wanted to sanitize it as \"folder1/folder2\"." }, { "prediction": "(style) line over 80 characters", "reference": "Looks like the X86 inline assembly is not happy with this type. I will update that" }, { "prediction": "Line is too long. [89/80]", "reference": "Tabs and a space, again." }, { "prediction": "I think this should be `if (RuleB(TaskSystem, EnableTaskSystem)) { return taskmanager->GetTaskName(task_id); }`", "reference": "Please just enclose if blocks with brackets; this has created issues in the past so I'd prefer we don't use them" }, { "prediction": "I think we should remove the `approver_response_path` from `approve_proposal_url` and `approve_proposal_response_path` from `approve_proposal_url` and `approve_proposal_response_path` from `approve_proposal_url`", "reference": "`version` isn't need anymore because it's built into `approve_proposal_url`, yes?" }, { "prediction": "I think it would be better to use `DLT_BLUETOOTH_LE_LL_WITH_PHDR` instead of `DLT_BLUETOOTH_LE_LL_WITH_PHDR`", "reference": "Moved to the bottom of the file. `CtrlPDU` sits on `BTLE_DATA` so let's put it after" }, { "prediction": "Line is too long. [89/80]", "reference": "This ends up requiring the `json` gem, right? Is there any way we can do this to be implementation agnostic (e.g. to let me use `yajl-ruby` for performance reasons (or because my app already brings in a JSON library)" }, { "prediction": "I think this should be `if n == 0 && err == nil`", "reference": "This seems dangerous. What circumstances lead to the need for a retry? Can that happen more than once? I'm concerned that if we hit the pathological state, this could turn into a CPU spinner. I wonder if we could get the same benefit from just \"trying again\" and failing if it fails the second time." }, { "prediction": "I think this should be a `final` instead of a `final`.", "reference": "If there is a reference to other fields or methods, please do the initialization in the constructor." }, { "prediction": "I think this is a bit confusing, but I'm not sure if this is the right place for this PR.", "reference": "These should be importing from `pill-container`" }, { "prediction": "(style) line over 80 characters", "reference": "Why this change? It will now only show on the bottom of the screen as white text, is it correct behaviour?" }, { "prediction": "Line is too long. [81/80]", "reference": "Does this need to allocate a string or would a nil value (indicating no header) be a better?" }, { "prediction": "I think this should be `this.constructor = this.constructor;`", "reference": "Nit: Past tense of `reset` is also `reset`." }, { "prediction": "I think this should be `self.config.fee_per_kb` instead of `self.config.fee_per_kilobyte`", "reference": "Shouldn't this use `'n'` instead?" }, { "prediction": "I think this should be `ActivityTaskTimeout` or something like `WorkflowTaskTimeout` or something like `ActivityTaskTimeout` or something like `ActivityTaskTimeout` or something like `ActivityTaskTimeout` or something like `ActivityTaskTimeout` or something like `ActivityTaskTimeout` or something like `ActivityTaskTimeout` or something like `ActivityTaskTimeout` or something like `ActivityTaskTimeout` or something like `ActivityTaskTimeout` or something like `ActivityTaskTimeout` or something like `ActivityTaskTimeout` or something like `ActivityTaskTimeout`?", "reference": "revert back to 'TASK_TYPE_ACTIVITY_TIMEOUT'" }, { "prediction": "I don't think this is needed anymore.", "reference": "Shouldn't we prefer passing a pointer by reference T*&, since these are C++ bindings?" }, { "prediction": "I think it would be better to have a separate function for the `processRefCGs` function. I think it would be better to have a separate function for the `toAntreaPeerForCRD` and `toAntreaPeerForCRD` and `toAntreaPeerForCRD` and `toAntreaPeerForCRD` and `toAntreaPeerForCRD` functions.", "reference": "nit: Personally I feel that it's cleaner to let `toAntreaPeerForCRD` to take `ingressRule` as a param instead of `ingressRule.From`. It can call `processRefCGs` inside the function and do the ipBlock/AG union within the function itself. It might not be worth the refactor though." }, { "prediction": "I think this should be `Status.State = apis.ReconcilePending` or `Status.State = apis.ReconcilePending`", "reference": "Pending has been set only for SPC.. why? for other CRs as well, this need to be done.. right?" }, { "prediction": "I think this should be `isset($options['allow_fullscreen']) ? $options['allow_fullscreen'] : false`", "reference": "would use an empty string here as default and then check for emptiness in the twig template. I dont like mixing types @core23 what do you think?" }, { "prediction": "I think this should be `nextPageTokenName(methodInfo.requestPageTokenName());`", "reference": "How come we need case manipulation for the nextPageToken and not for pageToken?" }, { "prediction": "Line is too long. [89/80]", "reference": "why use these rather than regular named paths?" }, { "prediction": "Style/StringLiterals: Prefer single-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", "reference": "Hm, I don't think the extra flags are doing any harm here, but it does seem like `--help` is the only flag you could *actually* use with this command. We might eventually want to separate those out." }, { "prediction": "I don't think we need to do this, but I don't think we need to do this in a separate PR.", "reference": "We should make this a docstring, so that editors are able to pick it up." }, { "prediction": "Line is too long. [82/80]", "reference": "Put a comma after the last parameter of a multiline method call." }, { "prediction": "Why is this removed?", "reference": "App cache size is now managed dynamically by the `WebView`. This statement has no effect in the new framework." }, { "prediction": "I think it would be better to use `node.hasAttribute('alt')` instead of `node.hasAttribute('alt')`", "reference": "VirtualNode has a `hasAttr` function, any reason why you're not using it?" }, { "prediction": "Why is this removed?", "reference": "This now throws when running tests (maybe the move to java 11??). Do we want to keep it?" }, { "prediction": "I think this should be `if len(sha1) > 40 { return sha1[:10] }`", "reference": "We can allow 7-char SHA, does not mean we want to show with 7-char in default, please change to `if len() > 10`, then cut." }, { "prediction": "I don't think this is a good idea, but I'm not sure if this is a good idea.", "reference": "this one should also have quotes i guess :)" }, { "prediction": "I think this should be `mock.unstruct.Object.GetName()` instead of `mock.unstruct.Object.GetName()`", "reference": "Using the variable on range scope `mock` in function literal (from `scopelint`)" }, { "prediction": "I think this should be `res.isWorkflow()` instead of `res.isCompleted()`", "reference": "does this result in a 200 when the dataset is still inprogress/publishing not yet finalized? Seems like 202 is the right code for that (as it was) and the test should be watching for a 202?" }, { "prediction": "I think this should be `orderPath` as well.", "reference": "Previously you could only order by the field you were searching by. But for full-text search, you can search across all indexed fields, and it didn't make sense not to have a sorting. For backward compatibility, the javascript code uses indexPath as the orderPath when no orderPath is provided." }, { "prediction": "I don't think we need to do this, but I think it would be better to use `vnode` instead of `vnode` as well.", "reference": "VIM didn't like your whitespace." }, { "prediction": "Why is this removed?", "reference": "Are you sure the namespace should change?" }, { "prediction": "I think this should be `void Startup(object hint)`", "reference": "@martijn00 I'm not sure why we're keeping the object parameter and return type since this can be done by using MvxApplication with THint set to object" }, { "prediction": "I think this is a bit confusing, but I'm not sure if this is a good idea.", "reference": "why do we create a time type here?" }, { "prediction": "I think this should be `css!components/listview/listview.css`", "reference": "Does this style actually need to get loaded in all of these components?" }, { "prediction": "I don't think this is needed anymore.", "reference": "import but not used so you did not resolve compile warnings?" }, { "prediction": "(style) line over 80 characters", "reference": "This is so much more concise and beautiful than the previous formula " }, { "prediction": "I don't think this is needed anymore.", "reference": "Is there any reason not to have the `static` modifier for the logger? _(that would be in keeping with the reference being uppercase)_" }, { "prediction": "I think this should be `GetSessionConfig` and `GetConsumerConfig`", "reference": "It's not about session creation config. It's about passing consumer config parameters to underlying transport - nothing to do with session itself" }, { "prediction": "I think this should be `overrideEnableDebug` instead of `overrideEnableDebug`", "reference": "Why is there an \"enable\" in the param name? Couldn't it just be `overrideDebug`? Here are everywhere else." }, { "prediction": "Line is too long. [82/80]", "reference": "`published.recently_published_first` reads a little oddly to me. Is this the same thing as `Video.published.ordered`?" }, { "prediction": "I think this should be `throw new Error('Unable to parse content of ' + file.originalPath);` or `throw new Error('Unable to parse content of ' + file.originalPath);`", "reference": "Encountered this because I had a stray comma. Figured I'd tweak it a bit." }, { "prediction": "Why do we need to do this?", "reference": "qq: Should this include the iptables6-save sim. to the inverse checks above?" }, { "prediction": "I think this should be `if string(str) == \"null\" {` or `if string(str) == \"null\" {`", "reference": "im open to explicitly checking NotSet value here but json logic already handles it so kept it this way." }, { "prediction": "I think this should be `#include \"../Util/Lua.h\"`.", "reference": "The naming of the include file appears to be unlucky." }, { "prediction": "`legend_opts` should be a `dict` instead of a `dict`", "reference": "Bit worried about this. At minimum you should make a copy of the dict here to avoid modifying a user supplied variable." }, { "prediction": "I think it would be better to use `PruneLaunchTemplateVersions(machinePoolScope.AWSMachinePool.Status.LaunchTemplateID)` instead of `PruneLaunchTemplateVersions(machinePoolScope.AWSMachinePool.Status.LaunchTemplateID)`", "reference": "Is it better to create one before pruning? In case creation fails we don't want to delete the previous one. We create a new one, it is tagged as latest, so the previous can be deleted. `CreateLaunchTemplateVersion` returns the version created, how about directly trying to delete the previous version? Assuming the numbering is strictly increasing." }, { "prediction": "I think this should be a `WinePrefixContainerDTO` instead of a `WinePrefixContainerDTO`", "reference": "Do we require the specific implementation information here?" }, { "prediction": "I think this should be `email_banned_by_email_address` or something like `email_banned_by_email_address` or something like `email_banned_by_email_address` or something like `email_banned_by_email_address` or something like `email_banned_by_email` or something like `email_banned_by_email_address` or something like `email_banned_by_email_banned_by_email_banned_by_email_address` or something like `email_banned_by_email_address` or something like `email_banned_by_email_address` or something like `email_banned_by_email_address` or something like `email_banned_by_email_banned_by_email` or something like `email_banned_by_email_banned_by_email_banned_by_email_banned_by_email_address` or something like `email_banned_by_email_address` or something like `email_by_email_banned_by_email_banned_", "reference": "How about `exists?(['domain ~* ?', domain.downcase])` ?" }, { "prediction": "I think this should be `c.GlobalIsSet(FlagContextTimeout)` instead of `c.GlobalInt(FlagContextTimeout)`", "reference": "Is this getting used in other places? Can we switch all the places to use the new API you added?" }, { "prediction": "(style) line over 80 characters", "reference": "This need to be checked with linux. AFAIK, we have this file in our bin directory that is a link to the system file." }, { "prediction": "I think this should be `let controllerUrl = view.getAttribute('data-controller');`", "reference": "Shouldn't we import `default`? I can't get here to test." }, { "prediction": "I think this should be `self.unix_socket` instead of `self.unix_socket`", "reference": "!!!!!!!!!!!!! @graingert, does this mean that tests haven't been running???" }, { "prediction": "I think this should be `if (type != null && type.Equals(\"passThrough\") && type != RunToolSettingValueTypeReservedKeyword)`", "reference": "I've already tried the null-coalescing operator here and got a strange error, so did this the old-fashioned way." }, { "prediction": "I think it would be better to use `parent.getAttribute('role') || ''` instead of `parent.getAttribute('role') || ''` instead of `parent.getAttribute('role') || ''`", "reference": "This doesn't follow our spacing convention. It's also a little hard to read. Can you reformat?" }, { "prediction": "I think we should remove this import.", "reference": "The deploy should come before template? EDIT: I see that in other files, we put a separate line and put deploy at the end. What is the reason for this?" }, { "prediction": "I think this should be `MetricStreamConfiguration.Aggregation = Aggregation.Drop` instead of `MetricStreamConfiguration.Aggregation`.", "reference": "Consider making a constant (e.g. `MetricStreamConfiguration.Drop`)." }, { "prediction": "I don't think we need to import `rdkit.six.moves` here.", "reference": "same question: why not just switch this to range too?" }, { "prediction": "I think this should be `const std::string type(m_IO->InquireVariableType(name));` instead of `const std::string type(m_IO->InquireVariableType(name));`", "reference": "@chuckatkins most places used an empty string for \"no type\", but a few used `\"unknown\"`. I've converted both cases to `Type::None`. Do you know why there was a distinction before?" }, { "prediction": "I think this should be `std::min(train_data_->FeatureGroupSizesInByte(i), static_cast(num_data_));`", "reference": "should we assert for the type for `FeatureGroupData` ? I think it should be 1-Byte type." }, { "prediction": "I think this test is not related to this PR, but it's not related to this PR.", "reference": "As long as you are sure this is definitely correct now... :-)" }, { "prediction": "I think this should be `String.format(R.string.cancel, activeTemp.toStringShort());`", "reference": "... so that all action buttons have the same height :-)" }, { "prediction": "I think this should be `#include `", "reference": "Use correct, alpha sorted, include order. Correct order means: 1. Header corresponding to this source (i.e. `\"LatencyTestPublisher.hpp\"`) 2. C system headers 3. C++ system headers 4. Alpha-sorted external libraries headers 5. Alpha-sorted public headers from this project 6. Alpha-sorted private headers" }, { "prediction": "I think this should be `*transport.Request` instead of `*transport.Request`", "reference": "I hate this name, open to suggestions." }, { "prediction": "I think this should be `c.localCacheKey(digest, []string{target.TargetBuildMetadataFileName()})` instead of `c.localCacheKey(digest, []string{target.TargetBuildMetadataFileName()})`", "reference": "Does this log line work? We need Warningf or just warning without the format string." }, { "prediction": "I think this should be `c.MetricsProcessors` or `c.MetricsProcessors`", "reference": "The pull controller would need similar updates." }, { "prediction": "I think we should remove this file.", "reference": "ignore this.. just didn't want to litter with a commit update to satisfy license plugin" }, { "prediction": "Line is too long. [82/80]", "reference": "Is this definition needed since it doesn't look like it's being used anywhere?" }, { "prediction": "I think this should be `if fields.has_key?(self.discriminator_key) || descendants.length == 0` instead of `if fields.has_key?(self.discriminator_key) || descendants.length == 0`", "reference": "Can this condition be reworded using `if` please?" }, { "prediction": "I think it would be better to use `if (inputs != nullptr && !inputs->hasData()) {` instead of `if (inputs != nullptr && !inputs->hasData()) {`", "reference": "after ||, no need inputs != nullptr" }, { "prediction": "I think this is a bit confusing, but I think it would be better to have a separate function for this.", "reference": "Is it just preference or on purpose that using slice of structs instead of slice of pointers?" }, { "prediction": "Why do we need to check for null here?", "reference": "This line always confused me anyway. Good catch!" }, { "prediction": "Why do we need to call `j.BlockServer.Shutdown()` here?", "reference": "Should we add `ctx` to `BlockServer.Shutdown()` for this purpose? Would be nice, but I don't care too much." }, { "prediction": "I think this should be `CDRMessage::addUInt32(msg, period.nanosec);` instead of `CDRMessage::addUInt32(msg, period.nanosec);`", "reference": "Duration_t at RTPS level must be serialized using fractions." }, { "prediction": "I think this should be \"peer for service %s is not running\" instead of \"peer for service %s is not running\"", "reference": "\"peer\" has its own meaning within YARPC with its own class of objects. This should probably be \"dispatcher\" too?" }, { "prediction": "I think it would be better to use `self.get_ctu_dir()` instead of `self.get_ctu_dir()`.", "reference": "I do not like this line break before `=true`. Maybe starting the list in the next line would help to reduce the indent? This way we could keep this string together." }, { "prediction": "I think we should remove this.", "reference": "_plugins should be removed too" }, { "prediction": "I think it would be better to use `node.hasAttribute('alt') && (nn === 'img' || nn === 'input' || nn === 'area')`", "reference": "The rule selector will not include `` and `` elements. Why not make this a new, separate rule altogether?" }, { "prediction": "I think this should be `userscripts.NotFoundError` instead of `userscripts.UnsupportedError`.", "reference": "@The-Compiler Is this style okay or would you prefer a common userscript exception base?" }, { "prediction": "I think this should be `value.sub_type || 0x00` instead of `value.sub_type || 0x00`", "reference": "we'd need to return a MongooseBuffer here instead of the Binary. lets add the subtype option to the buffer schema type as referenced in #1000 instead." }, { "prediction": "Why did you remove this?", "reference": "Let's remove this change." }, { "prediction": "I think it would be better to use `STATE_HALFCHECKED in states` instead of `STATE_HALFCHECKED in states`", "reference": "Could you split this into multiple lines?" }, { "prediction": "`useSelect( (select) => select( STORE_NAME ).getCurrentEntityURL());`", "reference": "This technically works, however it may be safer to use both `getCurrentReferenceURL` and `getCurrentEntityURL` and then make this condition `currentReferenceURL === currentEntityURL`. Currently, this code only works based on the internals of `getCurrentReferenceURL`, so by checking both we would decouple that." }, { "prediction": "I think this should be `fmt.Sprintf(\"response code: %d, response body: %s\", resp.StatusCode, string(body))`", "reference": "It does not recommend capitalization" }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Space inside } missing.", "reference": "Minor thing, but can you use 1.9 hash syntax for this?" }, { "prediction": "I think this should be `Util.format_windows_path(lambda_cwd)` instead of `Util.format_windows_path(lambda_cwd_on_host, lambda_cwd_on_host, lambda_cwd_on_host, lambda_cwd_on_host, lambda_cwd_on_host, lambda_cwd_on_host, lambda_cwd_on_host, lambda_cwd_on_host, lambda_cwd_on_host, lambda_cwd_on_host, lambda_cwd_on_host, lambda_cwd_on_host, lambda_cwd_on_host, lambda_cwd_on_host, lambda_cwd_on_host, lambda_cwd_on_host, lambda_cwd_on_host_on_host, lambda_cwd_on_host, lambda_cwd_on_host, lambda_cwd_on_host, lambda_cwd_on_host, lambda_cwd_on_host, lambda_cwd_on_host, lambda_cwd_on_host, lambda_cwd_on_host, lambda_cwd_on_host, lambda_cwd_on_host, lambda_cwd_on_", "reference": "I tried to follow the code structure already present." }, { "prediction": "I think this should be `from.toPath()` instead of `from.toPath()`", "reference": "seems reasonable to also want to include the 'to' location?" }, { "prediction": "I think this should be `os.environ['NUPIC']` instead of `os.environ['NUPIC']`", "reference": "Please leave 1 space char between commas here and other places in this PR." }, { "prediction": "(style) line over 80 characters", "reference": "hm is this really &&? Not ||? Was it initially correct if any of these things are not set that it needs to recreated?" }, { "prediction": "I think it would be better to use `cli.hasOption(\"cluster\") ? cli.getOptionValue(\"cluster\") : new String[]{}`", "reference": "Please don't use C-style array declarations. IMO our pre-commit ought to be enhanced to not allow this" }, { "prediction": "(style) line over 80 characters", "reference": "@rhc54 This doesn't look like a comprehensive comparison. For `PMIX_STRING` we seem to actually compare the content of the data while here we only compare meta-information which doesn't ensure that values are the same." }, { "prediction": "I don't think this is a good idea, but I think it would be better to use `request.get(\"confirmed_frontiers\", false);` instead of `request.get(\"confirmed_frontiers\", false);`", "reference": "I think `bypass_frontier_confirmation` conveys the intention better (default false as well)" }, { "prediction": "I think this should be `go-filecoin-address` instead of `go-filecoin/chain`", "reference": "This looks like it goes beyond the scope of removing `BlockHeight()`, in the future please do this in a separate commit at a minimum -- separate PR is fine too." }, { "prediction": "Why not just `tab` here?", "reference": "You'll also need to adjust `FakeWebTabAudio` in `tests/helpers/stubs.py`." }, { "prediction": "Why did you remove this?", "reference": "@csrwng what should we do here? This one is from origin." }, { "prediction": "I think this should be `#include `", "reference": "Follow alphabetical order." }, { "prediction": "This interface is not used anymore.", "reference": "As far as I can tell, these always get and set the context as an `IReadOnlyDictionary`. Can we use that here instead of `object` and get rid of the `as IReadOnlyDictionary`?" }, { "prediction": "I think this should be `html.escape(html.escape(self._opt.text))`", "reference": "As you only have `{}` as the format string (without anything else in it), this is the same as doing `self._doc.setHtml(html.escape(self._opt.text))`" }, { "prediction": "I think this should be `azkaban.security.credential_name`", "reference": "Where would this be configured? In azkaban.properties?" }, { "prediction": "I don't think we need to check for atomic operators here.", "reference": "1. Use `const` instead of `var` here. 2. Move the check to after the `if (update == null || typeof update !== 'object')`." }, { "prediction": "(style) line over 80 characters", "reference": "Let's assume that on Linux `eventfd` is always available as a wrapper of the eventfd2 system call. It is supported since linux 2.6.27 + glibc 2.9, as well as from the ancient versions of bionic. In other words, it would be fair to argue that the pair would be available on practically all platforms that provide `pipe2`. Therefore switching from using `pipe2` to `eventfd` on linux unconditionally would not cause issues on our users." }, { "prediction": "I think this should be a static variable, not a static variable.", "reference": "This field could be `final`." }, { "prediction": "Line is too long. [82/80]", "reference": "would be good to have a test for the case when `shutdown!` raises" }, { "prediction": "I think this should be `if (t == ComTdbHbaseAccess::INSERT_ && t == ComTdbHbaseAccess::INSERT_)`", "reference": "Does upsert pass this check also?" }, { "prediction": "I think this should be `logger.Info(fmt.Sprintf(\"running the patch command failed\")`", "reference": "Apologies reviewers, I did end up pushing another change. I was starting to request SRE-P help to get the apiserver configs from some clusters before and after when I realized I can just log the stdout from the patch command to see if anything was changed or not. Much simpler to verify if my work did or did not make changes to the config during the transition. Also got the spacing issue you mentioned @abhinavdahiya Thanks all." }, { "prediction": "I think this should be `kbfs_config_name_temp`", "reference": "I'm not sure this naming is a good idea; that's the format for macOS xattr metadata files on unsupported filesystems." }, { "prediction": "Line is too long. [82/80]", "reference": "Metrics/LineLength: Line is too long. [85/80]" }, { "prediction": "Why is this removed?", "reference": "Please remove these imports. The project's style is to use `Assert.assertEquals` and not import static methods in general. This also caused a lot of unnecessary changes." }, { "prediction": "(style) line over 80 characters", "reference": "thanks. Note that returning at this point might leak memory from the allocations above, so the PR will need to take care of that too." }, { "prediction": "I think this should be `if config.val.content.desktop_fullscreen or self.config_state_before_fullscreen` or `if config.val.content.desktop_fullscreen or self.config_state_before_fullscreen`", "reference": "If you really want to rename this, you'll also need to adjust the name in `__init__` and in other places it's used (`browser/commands.py`)." }, { "prediction": "I think this should be `cascade = {CascadeType.REMOVE, CascadeType.MERGE, CascadeType.PERSIST}`", "reference": "As discussed at standup, I gave up on this. Calling `DeleteMapLayerMetadataCommand` felt cleaner anyway because there might be other cleanup that needs to happen. @scolapasta and @matthew-a-dunlap plan to discuss this." }, { "prediction": "I think this should be `EXP:%+v\\n` instead of `ACT:%+v\\n`", "reference": "Do we need these changes? If so, can you tidy up the messages? Looks like it might have been your testing/debugging changes " }, { "prediction": "I think this should be \"LOG_DRIVER\", the default will be \"LOG_DRIVER\", the default will be \"LOG_DRIVER\", the default will be \"LOG_DRIVER\", the default will be \"LOG_DRIVER\", the default will be \"LOG_DRIVER\", the default will be \"CONTAINER\", the default will be \"LOG_DRIVER\", the default will be \"LOG_DRIVER\", the default will be \"LOG_DRIVER\", the default will be \"LOG_DRIVER\", the default will be \"LOG_DRIVER\", the default will be \"LOG_DRIVER\", the default will be \"LOG_DRIVER\", the default will be \"LOG_DRIVER\", the default will be \"LOG_DRIVER\", the default will be \"LOG_DRIVER\", the default will be \"LOG_DRIVER\", the default will be \"CONTAINER\", the default will be \"LOG_DRIVER\", the default will be \"LOG_DRIVER\", the default will be \"LOG_DRIVER\", the default will be \"LOG_DRIVER\", the default will be \"LOG_DRIVER\", the default will be \"LOG_DRIVER\", the default will be \"LOG_DRIVER\"", "reference": "where is the default being set?" }, { "prediction": "(style) line over 80 characters", "reference": "these changes should likely be in the next commit instead" }, { "prediction": "I think this should be `Foobar` instead of `Foo`", "reference": "Since you have defined this struct, I would suggest to replace all exist literal structs by this." }, { "prediction": "I think this is a bit confusing, but I'm not sure if this is a good idea.", "reference": "The field name doesn't really capture what this option does. I think `mConfirmDiscardMessage` would be a better choice." }, { "prediction": "I think this should be `is_file` instead of `is_string`", "reference": "what if `$media->getBinaryContent() == Symfony\\Component\\HttpFoundation\\File\\File` does `is_string()` return `true`? ping @greg0ire" }, { "prediction": "I think this is a bit confusing, but I don't think it's worth keeping the `nested_flatbuffer` variable in the `struct_def` variable.", "reference": "maybe rather than `bool` make this field a `StructDef *` ?" }, { "prediction": "I think we should use `time.After(10*time.Millisecond)` instead of `time.Sleep(10*time.Millisecond)`", "reference": "Shall we maybe put this in a `const` like `backgroundTaskTimeout`?" }, { "prediction": "I think this should be `catch (InvalidOperationException) {`", "reference": "CI is complaining about this." }, { "prediction": "I think this method should be called `calculateRemovalTime(Date initTime, Integer timeToLive)` instead of `calculateRemovalTime(Date initTime, Integer timeToLive)`", "reference": "Let's only change a file if it is really necessary. Such a change does not bring much value and makes it harder to find the original commit in which the method was introduced." }, { "prediction": "I think this should be `array_key_exists('lazy', $attributes) ? (bool)$attributes['lazy'] : true;`", "reference": "I would prefer to set up space between classes in format pattern, `%s %s` and then use `trim()` to remove unnecessary whitespaces. This will also solve stripping whitespaces from the beginning and end of a string `$attributes['class']`" }, { "prediction": "I think this should be `optOpEnum = toAdminJobOp(sentence_->getType());` or `optOpEnum = toAdminJobOp(sentence_->getType());` or `optOpEnum = toAdminJobOp(sentence_->getType());` or `optOpEnum = toAdminJobOp(sentence_->getType());` or `optOpEnum = toAdminJobOp(sentence_->getType());` or `optOpEnum = toAdminJobOp(sentence_->getType());`", "reference": "when Op is illegal should return here?" }, { "prediction": "Why did you remove this?", "reference": "don't we need to remove the project version from installedVersions?" }, { "prediction": "I think this is a bit confusing, but I'm not sure if it's worth it.", "reference": "the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here." }, { "prediction": "I think this should be `s.IPSetLocker.Lock(ipset.Name)`", "reference": "This is intended. Pls revert this." }, { "prediction": "I think this should be `Comparators.naturalComparator()` instead of `Comparators.naturalComparator()`", "reference": "Something wrong with cast to `(Comparator<> & Serializable)`, need to be investigated" }, { "prediction": "Why did you remove this?", "reference": "I think we need this. Not sure, I'll test." }, { "prediction": "I don't think this is needed anymore.", "reference": "I'm going to need to check if google compute requires these steps in this order, or if you can disable iptables after the fact." }, { "prediction": "I think this should be `go:build!no_stage` instead of `go:build!no_stage`", "reference": "Did go change their tags with the new version?" }, { "prediction": "I think this should be `log := s.config.Log.WithField(telemetry.SubsystemName, \"bundle_client\")`", "reference": "I don't recall what we decided here in terms of which source would get priority. As written, the static configuration will overwrite datastore results." }, { "prediction": "I think this should be `len(dep.Outputs()) > 1` instead of `len(dep.Outputs()) > 1`", "reference": "I think it should still panic for when there are no outputs; might be nice to special-case that though so the message is more explicit." }, { "prediction": "I think this should be `MetricsConfig.MetricsConfigBuilder.build()` instead of `MetricsConfig.MetricsConfigBuilder.build()`", "reference": "*NULL_DEREFERENCE:* object `null` is dereferenced by call to `meterSupplier(...)` at line 122." }, { "prediction": "Why is this removed?", "reference": "switch over to .mode" }, { "prediction": "I think it would be better to add a test for this to be consistent with other tests.", "reference": "I guess your IDE did some auto-fixing here " }, { "prediction": "Why not use `org.apache.lucene.search.PhraseQuery` instead of `org.apache.lucene.search.TermQuery`?", "reference": "This is an unused import failing recommit still." }, { "prediction": "Line is too long. [89/80]", "reference": "I'm concerned that we're conflating multiple things here. There are 2 things that Beaker should really care about: - Network transport - i.e. `ssh` vs `winrm` - Interpreter - i.e. `bash`, `cmd`, `powershell`, etc The problem is that @cowofevil is running Bitvise SSH, and he assumed we should be setting `is_cygwin: false` in node definitions. But that doesn't really accurately convey what we care about, and since Beaker doesn't appear to track network transport apart from interpreter, we end up in a strange state. `is_cygwin: false` appears to end up setting `is_powershell?` to `true`, which IMHO is not accurate or appropriate. Bitvise templates use `ssh` (like Cygwin), but the interpreter used is `cmd`, not `powershell`." }, { "prediction": "I think this should be `<%= _(\"Missing Fields Alert\")%>` instead of `<%= _(\"Missing Fields Alert\")%>`", "reference": "I think this is ok for now. This ties into the larger issue of the site not having a consistent method for relaying form input errors. Please make sure the focus gets set on the close button when the dialog opens." }, { "prediction": "I don't think this is correct. It's a bit confusing to me.", "reference": "Should these link be removed?" }, { "prediction": "`add_undo` should be `add_undo` instead of `add_undo`", "reference": "Please make this a keyword-only argument by adding a `*` argument before `add_undo`." }, { "prediction": "I think this should be `marshalers.PushBackNamed({{ $.API.ProtocolPackage }}.BuildHandler)`", "reference": "didn't quite follow what this code block is doing." }, { "prediction": "I think this should be `if (layoutManager.tv) { return void showOsd(); }`", "reference": "this doesn't sound pretty... I would rather we have a proper navigation for all modes - AFAIK TV remote navigation is very similar to normal keyboard, but maybe it just uses another key codes - those should be extracted in a single file and defined there depending on context then" }, { "prediction": "I don't think we need to do this in a separate PR.", "reference": "After diffing the children we check whether the value got out of sync, if it did we update it. We also update the `_prevValue` to prepare for the next event hitting our controlled component" }, { "prediction": "I think it would be better to use `glue-code` instead of `glue-code`.", "reference": "It provides a type called Node which is a fully functional bee client. This package is where the dependencies are injected. It is not just a glue-code, it is concept of node." }, { "prediction": "`download-directory` should be `_get_value_transformer('storage', 'download-directory')`", "reference": "I think this will change `''` to `'%'` unconditionally, i.e. there'll be no way to set `''` anymore. This should really only be used for values which make no sense anymore." }, { "prediction": "I think this should be `rowKey()` instead of `rowKey()`", "reference": "Nit: this table's row key map -> this table's row keys map" }, { "prediction": "(style) line over 80 characters", "reference": "this change should be reverted" }, { "prediction": "I think this should be `version_info__ = (1, 5, 0) for part in __version__.split('.') if part in __version__.split('.') else [int(part) for part in __version__.split('.')]", "reference": "I'm a bit confused about the `os.path.dirname(basedir)` here - is this just to get to the parent directory? Either way, I think I'd prefer just having this in `update_version.py` as it's not needed in qutebrowser itself." }, { "prediction": "I think it's better to use `errorPos: 19` instead of `errorPos: 5`", "reference": "Revert this change and see below why..." }, { "prediction": "I think this should be `lvis_v1_instance.py` instead of `lvis_v1_instance.py`.", "reference": "Should not switch to `lvis_v1_instance` here because that base config uses ClassBalancedDataset to oversample the data." }, { "prediction": "I think this should be `LOG.finest(String.format(\"Adding %s times\", caps, info.getMaximumSimultaneousSessions()));`", "reference": "This is an informational message that allows someone to read the console output and understand how the grid node is configured. Please leave." }, { "prediction": "I think this should be `RaiseSingleton(alert *api.Alert)` instead of `RaiseSingleton(alert *api.Alert)`", "reference": "This doesn't make sense to me. What does RaiseSingleton mean? To me it sounds like a single object is being.. raised? Not sure." }, { "prediction": "I think this should be `AllJobExecutorTests` instead of `AllJobExecutorTests`.", "reference": "What's the benefit of having jobExecutorTests as a member variable? What do you think about making the method static? Afterall, it is a stateless method." }, { "prediction": "I think it would be better to use `check` instead of `check`.", "reference": "This looks like it's only downloading things, not really checking their true validity. Especially for the MD object. Should we call `BareRootMetadata.IsValidAndSigned()` in `mdGet`?" }, { "prediction": "(style) line over 80 characters", "reference": "Nikoli, I believe that this addresses your concern. One question for you or Jae-Seung is if any allocation from the clone is properly cleaned up when the vector is destroyed. I believe that it should." }, { "prediction": "I think this should be `KindEcsApp` instead of `KindCloudRunApp`", "reference": "should be `ECSApp` " }, { "prediction": "I think this should be `if self._w3c` instead of `if self._w3c`", "reference": "flake8 is going to fail on this having 2 lines" }, { "prediction": "Why did you remove this?", "reference": "should we make a dir named controllers/scheduler/podchaos" }, { "prediction": "Why not just `KeyNodeHostname`?", "reference": "there seems to be one KeyNode in kubernetes.go of PV.. would it make sense to use it?" }, { "prediction": "I don't think we need to add this to the `node/config/urfavecli/clicontext` package.", "reference": "Im gonna be a little annoying here but did you configure your linter correctly? This empty line should not be here. Maybe go to settings and check if `goimports` is enabled?" }, { "prediction": "I think this should be `MODPRIVATECHAT` instead of `MODPRIVATECHATOUT`", "reference": "Don't think this belongs in this pr" }, { "prediction": "I think this should be `d.outbounds` instead of `d.outbounds`", "reference": "We can assert on the existence of Outbounds through ClientConfig calls right? Since this is only for tests, do we need this function?" }, { "prediction": "I think this should be `TaskCompletionSource CloseCompletionSource` instead of `TaskCompletionSource`", "reference": "@martijn00 so this PR introduces a new ViewModel lifecyle method? It isn't in the PR description/any new docs " }, { "prediction": "I don't think this is necessary.", "reference": "Are these modification duplicate? Or should we move it into base detector." }, { "prediction": "Why is this needed?", "reference": "Since this is private and single use it should be un-wrapped inside of the two-arg dagSeed method." }, { "prediction": "I think we should remove the `t3lib_div::array_merge_recursive_overrule()` here.", "reference": "why the order change? Also for the next chunk. (I understand the result will be the same though)" }, { "prediction": "I think this should be `[]string` instead of `[string]string`", "reference": "I wonder if this should just be a single `string`? We don't have any cases where we return different types and it would make the parser simpler to just read a single identifier." }, { "prediction": "I don't think this is correct, but I think it would be better to use `inputFiles.get(task.file().path().toString());` instead of `inputFiles.get(task.file().path().toString());`", "reference": "I don't think this needs to change. Can you go back to the previous implementation?" }, { "prediction": "I think it would be better to use `molecule.core` instead of `molecule.core`.", "reference": "Bump it 2 lines higher, 'c' > 'u'." }, { "prediction": "I think this should be `parser/AstTypes.h` instead of `parser/AstTypes.h`.", "reference": "Please do not add author here" }, { "prediction": "I don't think we need to add this to the `iotex-core` package.", "reference": "Similarly, we should be able to persist action uniformly" }, { "prediction": "I don't think this is needed anymore.", "reference": "I think i'd prefer this override to be in the test helper instead, if that's possible?" }, { "prediction": "I think this should be `os.MkdirAll(fullPathDir, 0755)`", "reference": "This would be better with context added via wrapping or fmt.errorf()" }, { "prediction": "I think it would be better to use `package assert` instead of `assert`", "reference": "What's the purpose of this file?" }, { "prediction": "I think it would be better to use `passcodeChangeRequired` instead of `hasStoredPasscode(ctx)` here.", "reference": "@bhariharan Why was passcode length requirement allowed to be lowered?" }, { "prediction": "Why is this removed?", "reference": "This file needs a license header, too. Sorry I didn't catch that earlier." }, { "prediction": "I think it would be better to use `string(genesisText[:])` instead of `string(genesisText[:])`", "reference": "probably don't need `[:]` why not reference into `github.com/algorand/go-algorand/daemon/algod/api/server/lib` here and skip bouncing off daemon/algod/server.go ?" }, { "prediction": "`reference_table = dal::detail::homogen_table_builder{}`", "reference": "Why reference is converted to table?" }, { "prediction": "I think we should just return a `listRegistrationEntriesResponse` instead of a `listRegistrationEntriesResponse`", "reference": "should we implement pagination in the fake datastore so the server startup code that paginates entries for trust domain validation can be tested?" }, { "prediction": "I think it would be better to use `f.Vectorized` instead of `f.Vectorized`.", "reference": "What mechanism will be exposed so the caller knows they're using the vectorized version?" }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", "reference": "Can we remove respond_to block its not required here" }, { "prediction": "Why is this needed?", "reference": "Do not do that even in example, we demonstrate bad practice" }, { "prediction": "Line is too long. [82/80]", "reference": "Hm, taking a second look over this, this is why we have the object inheritance structure that we do. This could be divided up by having a custom determine_if_x86_64 in the pswindows/exec hosts and then a default method in hosts.rb. That way all the custom ps windows work is in a single location." }, { "prediction": "Why did you remove this?", "reference": "We have to `.Complete` now because of empty/null string test cases." }, { "prediction": "Line is too long. [81/80]", "reference": "Is there still a way to specify no recursion?" }, { "prediction": "I think we should use `humanReadableName` instead of `URISafeName`.", "reference": "How is this name being URI safe and being used programmatically related?" }, { "prediction": "I think this should be `this.plugin.uppy.i18n('folderAdded', {smart_count: files.length, folder: folder.name })`", "reference": "I think we have to keep this as a fallback for now, else it's a small breaking change :(" }, { "prediction": "I think this test is not related to this PR, but it's not related to this PR.", "reference": "nit: shouldn't be part of this PR." }, { "prediction": "I think it would be better to use `throw new MongoError('expected closing the cursor to break iteration');`", "reference": "this change looks wrong to me. I think the test is trying to signal that something went wrong by throwing the `Error` here, otherwise the `catch` below will swallow it." }, { "prediction": "I think this should be `_layout.RenderAppendBuilder(logEvent, reusableBuilder);`", "reference": "I'm doubting if this should be `if (_layout.IsThreadAgnostic)`, as ThreadAgnostic stuff could be calculated on every thread. (and thus could be lazy). non-ThreadAgnostic should be calculated on the main thread." }, { "prediction": "I think this should be `org.slf4j.LoggerFactory.getLogger(LeftListWidgetChooser.class);`", "reference": "Please use only `Logger` instead of `org.slf4j.Logger`" }, { "prediction": "I don't think we need to do this.", "reference": "Should this be \"no limiter drop\", since this isn't an absolutely essential activity for the stability of the network?" }, { "prediction": "I think this should be `console.log(\"Account alias \" + process.argv[2] + ' deleted.');`", "reference": "I updated many of the success messages, because most of these operations don't return data if they succeed. This meant many of the operations would print: `Success null` if the script ran successfully." }, { "prediction": "I think this should be `except FileNotFoundError as fnfe`", "reference": "Could you simply add it to the previous clause ?" }, { "prediction": "I think this should be `return procCodeA.localeCompare(procCodeB, undefined, {sensitivity: 'base', numeric: true });`", "reference": "@joshyrobot, I think you can just use localeCompare with only the first argument and leave the other arguments out (here and all the other lines changed). It seems to do the right thing, and then we don't have to worry about these extra options." }, { "prediction": "I think this should be `if (slaOptions != null && slaOptions.size() > 0) {`", "reference": "@chengren311 : where does this logic move to?" }, { "prediction": "I think this should be `if !s.scope.AllowAdditionalRoles() { return ErrCannotUseAdditionalRoles() }`", "reference": "Can we have a `nil` exception check at `s.scope.ManagedMachinePool`" }, { "prediction": "Why is this removed?", "reference": "Rather than deleting this, should you just reformat it so it's the `*` settings, so if nothing is configured in facets.ini, the existing default behavior continues to work?" }, { "prediction": "Can you please add a space after the `_`?", "reference": "wrap, single line" }, { "prediction": "I think this should be `returnType == null || returnType.isEmpty()`", "reference": "always use brackets for if statements" }, { "prediction": "I think this should be `_runtimeDescription = FrameworkDescription.Instance;` instead of `_runtimeDescription = FrameworkDescription.Instance;`", "reference": "`NUnitIntegration` doesn't need to cache this anymore." }, { "prediction": "I think it would be better to use `element_at(parts, -1) = 'gz'` instead of `element_at(parts, -1) = 'gz'`", "reference": "Why did you change it to `>=` here?" }, { "prediction": "I think it would be better to use `tableName.replaceFirst(\"(hadoop\\\\.)|(hive\\\\.)\", \"\");` instead of `tableName.replaceFirst(\"(hadoop\\\\.)|(hive\\\\.)\", \"\");` instead of `tableName.replaceFirst(\"(hadoop\\\\.)|(hive\\\\.)\", \"\");`", "reference": "Looks like this needs to be updated. There is no need to remove `hadoop.` if Hadoop tables don't use this code path." }, { "prediction": "I think it would be better to use `require('digest')` instead of `require('fileutils')`", "reference": "This require isn't need anymore, right?" }, { "prediction": "I don't think we need to import `payments/crypto` here.", "reference": "a bit weird to see payments crypto package inside connection manager. There probably will be services not having any relation with payments that will use connection manager. Thats why probably ping-ping by itself can be useful without any relation to payments.." }, { "prediction": "Why is this needed?", "reference": "I like the overall idea here, but I wonder if it would be more clear to define the property in the trait, and then set it in the constructors of the classes using the trait. Alternatively, at a bare minimum, it may be a good idea to add `?? 'Bibliographic'` here, to account for the possibility of the trait being used in a class that does not define the property at all." }, { "prediction": "I think this is a bit confusing to me.", "reference": "I would prefer to not have a magic number, but construct this value out of other constants we already have." }, { "prediction": "I think this should be `if 'basicauth' in policies: config.add_api_capability('basicauth', url='http://kinto.readthedocs.io/en/stable/api/1.x/authentication.html', description='Very basic authentication sessions. Not for production use.', url='http://kinto.readthedocs.io/en/stable/api/1.x/authentication.html', url='http://kinto.readthedocs.io/en/stable/api/1.x/authentication.html', url='http://kinto.readthedocs.io/en/stable/api/1.x/authentication.html', url='http://kinto.readthedocs.io/en/stable/api/1.x/authentication.html', url='http://kinto.readthedocs.io/en/stable/api/1.x/authentication.html', url='http://kinto.readthedocs.io/en/stable/api/1.x/authentication.html', url='http://kinto.readthedocs.io/en/stable/api/1.x/authentication.html',", "reference": "The limitation is if somebody configure another policy with the same name, but it is an edge case we can ignore I guess." }, { "prediction": "I think this should be `gocloud.dev/secrets/hashivault` and `gocloud.dev/secrets/localsecrets` and `gocloud.dev/secrets/gcpkms`", "reference": "? The package is named `hashivault`." }, { "prediction": "(style) line over 80 characters", "reference": "I don't think this should enable xwayland, because it's convenient to toggle xwayland just by setting `xwayland` to `false`" }, { "prediction": "Why did you remove this?", "reference": "Remove this line by accident?" }, { "prediction": "I think we should remove the `org.gradle.api.plugins.JavaPluginConvention` from the `org.gradle.api.plugins.JavaPluginConvention` class.", "reference": "Calling `.stream()` on a `DomainObjectCollection` is pretty much always a bug, as it doesn't include objects added later (and encourages people to use afterEvaluate). I wonder if we should make this an error prone check?" }, { "prediction": "I think this should be `if err != nil { return err }`", "reference": "Thanks for paying attention to other places this might happen. This one is particularly important; I probably never should have gotten in the habit of CheckErr(), since it does a log.Panic() explicitly, which looks like something else until you look closely. It's supposed to be used places where \"can't happen\" but Things Can Happen." }, { "prediction": "I think it would be better to use `fmt.Sprintf(\"nw_tos=%d\", dscp<<2)` instead of `fmt.Sprintf(\"nw_tos=%d\", dscp<<2)` instead of `fmt.Sprintf(\"nw_tos=%d\", dscp<<2)`", "reference": "What is the different between nw_tos and ip_dscp? Only high 6 bits vs low 6 bits and supported version?" }, { "prediction": "I don't think this is necessary.", "reference": "I'm assuming that asSmarts & cxSmiles == asSmarts" }, { "prediction": "I think this should be `super.setstate(self.param)` instead of `super.setstate(self.param, self=self)`.", "reference": "Seems like an oversight but I don't think the super would do anything else in this case unless I'm mistaken." }, { "prediction": "I think this should be `readonly`", "reference": "Curious, do we consider this as pedantic for example code?" }, { "prediction": "Why is this removed?", "reference": "Should we convert the entity name to snake case using `Doctrine\\Common\\Inflector\\Inflector::tableize` or similar ? Should a `snaked_name` or whatever be part of the entity metadata in order to use it for form names, ids, & other html attributes ?" }, { "prediction": "I think this should be `GetOutboundIP` instead of `GetPublicIP`", "reference": "Should be `client.outboundIp`" }, { "prediction": "I think this is not needed anymore.", "reference": "Must these `using` statements not go inside the `namespace` block?" }, { "prediction": "Why is this needed?", "reference": "Why? I thought the previous way was idiomatic. (Same with the `MetadataVer` stuff above.)" }, { "prediction": "Why did you remove this?", "reference": "shouldn't we `reject` here instead?" }, { "prediction": "I think we should use `fmt.Sprintf(\"gasPrice: %s Rau\\n\", action.Core.GasPrice)` here.", "reference": "check err or use gasPriceUnitIOTX, _ := if we are sure action.Core.GasPrice is correct" }, { "prediction": "I think this should be `waittime.Duration` instead of `waittime.Duration`", "reference": "Just curious, was wait not used at all before?" }, { "prediction": "I think this should be `gopkg.in/yaml.v3.go`", "reference": "nit: can we remove this?" }, { "prediction": "Why do we need to synchronize here?", "reference": "is it not a problem when one synchronized function is called by other?" }, { "prediction": "Align the parameters of a method call if they span more than one line.
Prefer single-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", "reference": "We (even as admins) shouldn't override the User Preference settings like `email_master`, `email_posts`, `email_kudos`, `email_new_followers`. These all would be set by the user of their choice. Please do remove these attributes from editing//updating. Thanks!" }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Prefer single-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", "reference": "\"Este :attribute j est anexado.\" sounds better." }, { "prediction": "I think it would be better to use `__name__ == \"__main__\"` instead of `__name__ == \"__main__\"`.", "reference": "This line should be repeated for every module that needs testing. One cannot rely on nosetest to automatically discover all the modules. On the bright side, there is no need to change any of the other files." }, { "prediction": "I think we should remove the `errNoCert` here.", "reference": "This error was unused" }, { "prediction": "I think this should be `CloseShardRequest` instead of `AddTasksRequest`", "reference": "Personally I wish we didn't have a proto for every single little thing we do. RequestShardAction with an enum for the action type would be a lot cleaner imo, but I'm pretty sure that ship has sailed :) Just kvetching." }, { "prediction": "I think this should be `if trail.complete` instead of `if trail.complete`", "reference": "Does this make more sense as `trails/_trail` now?" }, { "prediction": "I think this should be `agent.ec2MetadataClient.GetOutpostARN()`", "reference": "synced offline. let's move this to `agent_unix.go` to make the IMDS call, since this is not supported in Windows." }, { "prediction": "I think this should be `py_install_prep` and `py_prep_prep`", "reference": "Too much indentation here. Should match the lines above, which have four spaces." }, { "prediction": "I think we should remove the `OSRM_TEST_DATA_DIR` from the `OSRM_TEST_DATA_DIR` and remove the `OSRM_TEST_DATA_DIR` from the `OSRM_TEST_DATA_DIR` and remove the `OSRM_TEST_DATA_DIR` from the `OSRM_TEST_DATA_DIR` and remove the `OSRM_TEST_DATA_DIR` from the `OSRM_TEST_DATA_DIR` from the `OSRM_TEST_DATA_DIR` and `OSRM_TEST_DATA_DIR` from the `OSRM_TEST_DATA_DIR` and remove the `OSRM_TEST_DATA_DIR` from the `OSRM_TEST_DATA_DIR` and remove the `OSRM_TEST_DATA_DIR` from the `OSRM_TEST_DATA_DIR` and remove the `OSRM_TEST_DATA_DIR` from the `OSRM_TEST_DATA_DIR` from the `OSRM_TEST_DATA_DIR` and `OSRM_TEST_DATA_DIR` from the `OSRM_TEST_DATA_DIR` from `OSRM_TEST_", "reference": "Same here we still need this test to make sure the fallback works." }, { "prediction": "I think this interface should be `MvxBasePresentationAttribute` instead of `MvxBasePresentationAttribute`", "reference": "I'm wondering if we can actually base this on a `IMvxPresentationAttribute` instead of the base one." }, { "prediction": "`_vnode = vnode._component = null;`", "reference": "could we switch to `undefined` here?" }, { "prediction": "Why do we need to do this here?", "reference": "The cleanup call" }, { "prediction": "I think it's better to use `options.openArtist !== false && item.ArtistItems && item.ArtistItems.length` instead of `item.ArtistItems.length`", "reference": "I think \"View artist\" is a bit more standard and expected. Or even \"Go to artist\" to take the Spotify terminology as-is." }, { "prediction": "I don't think we need to check if Puppet is loaded.", "reference": "It might make sense to refactor this later so that we use a Bolt-native type to hide sensitive values." }, { "prediction": "I think this should be `if __name__ == \"__main__\":`", "reference": "We were trying to move away from this to force people to always run tests under py.test." }, { "prediction": "I don't think we need to add the `self._get_selenium_options()` here.", "reference": "1 - create browser specific options class: - chromeoptions - firefoxoptions - argsoptions" }, { "prediction": "I think this should be `if not response_content_str.startswith('isInvisible()) { return canSeeInvisibility() && creature->isInvisible(); }`", "reference": "You introduced a bug here." }, { "prediction": "I think this should be `if (!string.IsNullOrEmpty(oldValue)) { updater.ReplacementTransform = v => v.Replace(oldValue, newValue); }`", "reference": "Should we log a warning/error if only one is specified and not the other?" }, { "prediction": "I think this should be `GetLatestEventRequest` instead of `GetLatestEventResponse`", "reference": "`ctx` is unused in GetLatestEvent" }, { "prediction": "`config.node.peering_port = network_params.network.default_node_port;`", "reference": "This looks good to me. Personally, I would have the following for maximum flexibility: * convert peering_port from uint64_t to int. * Set the default value to \"-1\" to specify the value is not set * if the value is -1 then do `config.node.peering_port = network_params.network.default_node_port` That would allow for 0 to mean, select the port number yourself and be more consistent. But I am happy with the change as is, as well." }, { "prediction": "I think we should remove this line.", "reference": "The blank line between the summary and detailed description is better to be kept." }, { "prediction": "I think this should be `if !a.NoRemoveUnusedShapes {` instead of `if !a.NoRemoveUnusedShapes {`", "reference": "Curiously, are these indents intended or should they be aligned?" }, { "prediction": "I think this should be `if not roleText: roleText = attrs.get('roleText') if not roleText: roleText = attrs.get('roleText') if not roleText: roleText = attrs.get('roleText') if not roleText: roleText = attrs.get('roleText') if not roleText: roleText = attrs.get('roleText') if not roleText: roleText = attrs.get('roleText') if not roleText: roleText = getSpeechTextForProperties(reason=reason,states=states,_role=role) if roleText: roleText = getSpeechTextForProperties(reason=reason,states=states,_role=role) if not roleText: roleText = getSpeechTextForProperties(reason=reason,states=states,_role=role) if not roleText: roleText = getSpeechTextForProperties(reason=reason,states=states,_role=role) if not roleText: roleText = getSpeechTextForProperties(reason=reason,states=states,_role=role) if roleText: roleText = getSpeechTextForProperties(reason=reason,states=states,_role=role", "reference": "What if we changed this to this? roleText=attrs.get('roleText', lambda:getSpeechTextForProperties(reason=reason,role=role)) That will prevent the function from ever needing called in the roletext case, and removes that if." }, { "prediction": "(style) line over 80 characters", "reference": "This will still result in a safe_read_tls_magic on AMD in tls_thread_preinit()." }, { "prediction": "Why is this removed?", "reference": "Can you remove this change?" }, { "prediction": "I think this should be `crt.KeyAlgorithm` and `crt.IsCA`", "reference": "Oh, was that a bug in the validation?" }, { "prediction": "I think this should be `feedUrl.replaceFirst(\"((www.)?(subscribeonandroid.com/))\", \"\");`", "reference": "Please use the Google java code style. Basically, add more space characters like in the statements below. Next to method arguments and curly braces. This is currently not checked on CI because it is too inconsistent in the code base but I would prefer new code to be consistent." }, { "prediction": "Can you please add a space after the `&`?", "reference": "Actually, I don't think we need to create object on heap." }, { "prediction": "Why is this removed?", "reference": "this is a file we copy from gRPC, sp ideally it be fixed upstream as well.." }, { "prediction": "Why is this removed?", "reference": "changes like this, just strangle guava usages to be replaced by DelayLimiter into one place" }, { "prediction": "I think this should be `header: Header, footer: Footer, noPadding: noPadding`", "reference": "PropTypes need to be updated accordingly here. Note that the type also needs updating, not just the case. That is, these should both expect a `PropTypes.elementType` now instead of an `element`." }, { "prediction": "(style) line over 80 characters", "reference": "maybe extra paren around `strncmp(...) != 0`" }, { "prediction": "I think this is a bit confusing, but I'm not sure if this is the right place for this PR.", "reference": "We should call `Windows.onResume `: - When the app is launched for the first time - When the app is resumed after being paused (home button and resume or device goes to sleep) - After a permission prompt is displayed" }, { "prediction": "I think this class is not used anymore.", "reference": "Rename to ForksSchedule? Maybe in separate PR." }, { "prediction": "I think it would be better to use `from kinto.core.storage import heartbeat` instead of `from kinto.core.cache import heartbeat`", "reference": "Why a blank line here?" }, { "prediction": "I think this should be `deactivated_on.nil?` instead of `deactivated_on.nil?`", "reference": "I have a sense that this will actually eventually change to check the actual date so that subscriptions can be deactivated in the future. But I mention that here just to keep you in the loop. We should not make that change now, because it's not needed functionality." }, { "prediction": "I think this should be `if (argSpec.isOption()) { return envVarNames(argSpec.getOptionSpec()); }`", "reference": "What is the reasoning for using the negation of `isOption()` instead of simply using `isPositional()` to identify a positional param?" }, { "prediction": "I think this should be `if (version >= 1100 && version <= 1100) {`", "reference": "Why would you add those if client version min is set to 1100?" }, { "prediction": "I think we should remove this import.", "reference": "You can delete this, it will now need to live in `gointerfaces` package" }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Space inside } missing.", "reference": "Okay, I still don't understand why you have to add `html_safe` here, and it still seems like a very bad idea. It will allow html tags in the title, and keep Rails from escaping literal greater-than or less-than chars not intended as HTML tags. It ought to work to just let Rails do HTML-escaing as normal, without any manual `html_safe` or `strip_tags` or whatever. I am not clear on what problem you are trying to solve, why the straightfoward approach does not work." }, { "prediction": "I think this should be `showSubjectInHeader` instead of `showSubjectInMessageHeader`", "reference": "What is is subject when it's not the email subject. Why are we having to do this crap? What's calling this with an empty string?" }, { "prediction": "I think this should be `DefaultSamplingProbability` instead of `DefaultSampler`.", "reference": "Could you also remove the `defaultSamplingProbability` constant from `sampling.go`? It seems to became unused with this change." }, { "prediction": "I think this is a bit confusing, but I think it would be better to use a `deepcopy` function that returns a copy of the `appsv1.Deployment` object, not a copy of the `appsv1.Deployment` object. I think it would be better to use a `deepcopy` function that returns a copy of the `appsv1.Deployment` object. I think it would be better to use a `deepcopy` function that returns a copy of the `appsv1.Deployment` and `appsv1.Deployment` as a `deepcopy` function that returns a copy of the `appsv1.Deployment` object, not a copy of the `appsv1.Deployment` object.", "reference": "can you delete the `generateDeploymentStrategicPatch` function as well?" }, { "prediction": "I think we should log the message as well.", "reference": "I'd keep this at `info` level..." }, { "prediction": "I think it would be better to use `DCHECK(graph::ExpressionUtils::isEvaluableExpr(limit->countExpr()));` instead of `DCHECK(graph::ExpressionUtils::isEvaluableExpr(limit->countExpr()));`", "reference": "Don't use DCHECK to debug your code if it's the regular branch you need to handle." }, { "prediction": "I don't think this is needed anymore.", "reference": "You should return null here instead. Null is an acceptable default value for the image attribute." }, { "prediction": "I think this should be `options._catchError(e, component._vnode);` instead of `options._catchError(e, component._vnode);`", "reference": "react bails as well?" }, { "prediction": "Why is this removed?", "reference": "Can you please tell me why you did this?" }, { "prediction": "I think this should be `this.opts.videoConstraints` or something like `this.opts.videoConstraints.facingMode = this.opts.facingMode ? this.opts.facingMode : this.opts.facingMode : this.opts.facingMode`", "reference": "Reading this again it should prob prefer the `videoConstraints.facingMode` value over `facingMode` if the former was already set" }, { "prediction": "Line is too long. [89/80]", "reference": "There's a good bit of class-level stuff that's repeated in our various product types. Think it's worth extracting a...dare I say it...module?" }, { "prediction": "I think this should be `config.Target.WasmAbi = config.Options.WasmAbi` instead of `config.Target.WasmAbi = config.Options.WasmAbi`", "reference": "Please do not modify the `config.Target` field, it should contain exactly what is extracted from the JSON files. Instead, you can either: * Add a getter to the `config` variable (`*compileopts.Config`), so you can simply call `config.WasmAbi()` to get the value. * Use a local variable instead. The getter would be slightly cleaner, as it matches the pattern of other configurations (`CGO_ENABLED`, `GC`, `NeedsStackObjects`, etc)." }, { "prediction": "I think this should be `defer t.Stop()`", "reference": "The nil check is not necessary for these. Append checks both sides for nil." }, { "prediction": "I think this should be `span.SetAttributes(entries)`", "reference": "Shouldn't we instead have the SDK apply these, internally? I.e., I would expect to see the dctx entries included in the span as first-class distributed correlations, not as span attributes." }, { "prediction": "I think this should be `errors.New(\"not implemented\")`", "reference": "nit: rename this in proto and update impl to `Search` to avoid stutter" }, { "prediction": "Why do you need to add the `addOrderBy('s.position', 'asc')` to the `addOrderBy('s.id', 'asc')` method?", "reference": "is it necessary to order by id as a second ordering? this will take place only when several new slider items are created without reordering (position is then null). Wouldn't be better to recalculate position after creating a new item? (right now items with null in position behave differently in administration and on frontend)" }, { "prediction": "I don't think this is needed anymore.", "reference": "`ClaimFromRewardingFundBaseGas` is a global variable (from `gochecknoglobals`)" }, { "prediction": "I think this should be `if (useChirality && useQueryQueryMatches) return convertMatches(matches);` instead of `if (useChirality && useQueryQueryMatches) return convertMatches(matches);`", "reference": "How about modifying the NOGIL definition so that it only does anything if the thread safety flag (RDK_BUILD_THREADSAFE_SSS) is set?" }, { "prediction": "I think this should be `BlockHeight` instead of `BlockHeight`", "reference": "blockheighter would be more clear" }, { "prediction": "I don't think this is a good idea, but I think it would be better to use `compareAndSwapBound(std::pair& a, std::pair& b)` instead of `compareAndSwapBound(std::pair& b, std::pair& a, std::pair& b, std::pair& a, std::pair& b, std::swap(a, b, std::swap(a, b, std::swap(a, b, std::pair(a, b, std::pair(a, b, std::pair(a, b, std::swap(a, b, std::pair(a, b, std::pair(a, b, std::pair(a, std::pair(a, b, std::pair(a, std::pair(a, std::pair(a, b, std::swap(a, b, std::swap(a, b, std::swap(a, b, std::pair(a, std::pair(a, std::pair(a, b, std::", "reference": "This is so weird as a utility function." }, { "prediction": "I think this should be `cmp.FilterPath(cmp.FilterPath(cmp.FilterPath(cmp.FilterPath(cmp.FilterPath(cmp.FilterPath(cmp.FilterPath(cmp.FilterPath(cmp.FilterPath(cmp.FilterPath(cmp.FilterPath(cmp.FilterPath(cmp.FilterPath(cmp.FilterPath(cmp.FilterPath(cmp.FilterPath(cmp.FilterPath(cmp.FilterPath)))))))`", "reference": "Why? What would happen if you did not?" }, { "prediction": "I think this should be `o = (JSONObject) o.opt(pathElement);` or `o = (JSONObject) o.opt(pathElement);` or `o = (JSONObject) o.opt(pathElement);` or `o = (JSONObject) o.opt(pathElement);` or `o = (JSONObject) o.opt(pathElement);` or `o = (JSONObject) o.opt(pathElement);`", "reference": "Unrelated bugfix for NPE." }, { "prediction": "I think this should be `!$propertyMetadata['canBeSet'] && !$propertyMetadata['isWritable']`", "reference": "What if some extended the `AdminController` and had a check for the old option name? Could that be a valid use case?" }, { "prediction": "I think this should be `data: { app_id: countlyCommon.ACTIVE_APP_ID, preventRequestAbort: true }`", "reference": "This will be only available when data-manager is enabled, is there a fallback in case data manager is disabled?" }, { "prediction": "I think this is a bit confusing, but I'm not sure if it's worth it.", "reference": "Do you think we want to move the call to `generateWorkerServiceRecommendedActions` inside `RecommandedActions()`?" }, { "prediction": "I think this should be `VUID-vkGetQueryPoolResults-flags-00814`", "reference": "The VUIDs in this area are not great, but I think `ValidateQueryPoolStride` should probably be skipped if the query pool was created with type `VK_QUERY_TYPE_PERFORMANCE_QUERY`. VUID-02828 might be a better fit, but again, the existing VUIDs step on each other so it requires a bit of interpretation." }, { "prediction": "Why do we need to use `key.Bytes` instead of `key.ToBigEndianByteArrayWithoutLeadingZeros()`?", "reference": "Iguess you should use ToDbKey here" }, { "prediction": "I think we should remove the `deleteTipBlock` function.", "reference": "x.tbk is the \"index\" below, and is done in Start()" }, { "prediction": "I think we should use `DD_IsAppInsightKey` instead of `DD_IsAppInsightKey`.", "reference": "Do we already have a convention for this? If not, would we consider \"DataDog.IsAppInsights\". And then use \"DataDog.\" prefix for all this settings, environment variables etc..? Such settings are, essentially, public APIs because they may conflict with customer data. Regardless of that , AppInsights has an s at the end :)" }, { "prediction": "(style) line over 80 characters", "reference": "this assignment is not necessary if the offsetof() is used in the configmap" }, { "prediction": "I think we should remove the `if balance.Cmp(big.NewInt(0)) == 0 {` here.", "reference": "I'd rather leave a TODO here at least." }, { "prediction": "I think this test is not related to this PR, but it's not related to this PR.", "reference": "Shouldn't this be `resource`?" }, { "prediction": "(style) line over 80 characters", "reference": "Why does this become blocking for the CPU path? Shouldn't it remain independent of the GPU path?" }, { "prediction": "I think this should be `setup_rvm` instead of `setup_rvm`", "reference": "Do we need to change occurences where `setup` was called before?" }, { "prediction": "I think this should be `list` or `map`", "reference": "Is this TODO still valid? Or are we going to put this somewhere else later?" }, { "prediction": "`from_ts = datetime.utcfromtimestamp(from_ts) if from_ts is not None else datetime.utcfromtimestamp(from_ts)`", "reference": "We generally don't do parantheses in if conditions in Python. :) this could be better written as `if from_ts is None`" }, { "prediction": "(style) line over 80 characters", "reference": "Odd that we'd set just element 299 of a 2000-byte buffer to null. But I see that this is the way it was before." }, { "prediction": "I think this is a bit confusing, but I don't think it's a good idea to do this.", "reference": "ScoreFunc is not used in this PR. Maybe to add it later when needed?" }, { "prediction": "I think this should be `if isBrowser(copyRequestHeadersFromResponseWriter(w)) {`", "reference": "super nit: I think this might be easier to read as `requestHeadersFromResponseWriter`" }, { "prediction": "Why is this removed?", "reference": "Need to include \"common/base/Base.h\" in front of this line" }, { "prediction": "I don't think this is needed anymore.", "reference": "Changes in this file should go into a separate PR." }, { "prediction": "I think this should be `quoted(token)` instead of `quoted(token)`", "reference": "Please ensure that this will not start putting single quotes where double quotes are expected." }, { "prediction": "I think this should be `pingerPort` or `pingerPort` instead of `pingerPort`", "reference": "`ProvideConfig` was changed, looks like it will not compile for windows, and should be changed too." }, { "prediction": "Why is this needed?", "reference": "This does not look right, you're listing all private repositories.." }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Space inside } missing.", "reference": "An OPTIONS request should respond from _any_ path? Seems weird to me..." }, { "prediction": "Can you please add a space after `width` and `height`?", "reference": "you need to add the content type" }, { "prediction": "I think this should be \"Failed to halt the sub-process trace agent\" and \"Failed to halt the sub-process stats agent\"", "reference": "Do we need to distinguish between these two processes? I'm thinking maybe we can have a list of processes and treat them all equally." }, { "prediction": "(style) line over 80 characters", "reference": "This is used only for out-of-line -- so yes this seems right to do for x64. Inlined is aligned separately at the end of prepare_for_clean_call(). There the ifdef is x86_64 or MACOS -- no ARM, why not? Also, please add || MACOS here to match the inlined." }, { "prediction": "I think this should be `ZIPKIN_ANNOTATIONS.TRACE_ID_LOW.eq(ZIPKIN_ANNOTATIONS.TRACE_ID_LOW)`", "reference": "guess I'm wondering if this needs to be refactored to use Schema.joinCondition() or similar?" }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Space inside } missing.", "reference": "Does it make sense to restrict this option to `exec` only? You could add it specific to that subcommand using the `method_option`...method. There's an example of it for hosts in the `init` function." }, { "prediction": "I think it would be better to use `string.Join()` instead of `string.Join()` instead of `string.Join()` instead of `string.Join()`", "reference": "This is very expensive (lots of allocations, lots of data copying). Could we do something like check IndexOf('%') and bypass if no hit?" }, { "prediction": "I think this should be `if (client.getVar(Varbits.IN_WILDERNESS) == 1 || worldType.isPvpWorld(client.getWorldType())) { return true; }`", "reference": "This should be `WorldType.isDeadmanWorld(client.getWorldType())` to be inline with the other WorldType calls." }, { "prediction": "`bbox_preds` and `confidences` are not used anymore.", "reference": "do we also need to change `mlvl_confid` -> `mlvl_confidences`>" }, { "prediction": "I think this should be `iface-list;kube-ipvs0` instead of `iface-list;kube-ipvs0`", "reference": "I feel slightly that InterfaceExclude is not a clear name - bearing in mind that our config names are, to some extent, an external API. From an external point of view, a clearer name might be IPVSInterfaces. Then it would obviously make sense for the value to be something like 'kube-ipvs0', and it would be a matter of Felix's internal implementation that we choose to exclude those interfaces from our monitoring. Alternatively, if we want to keep this at a level that is more general than just IPVS, perhaps 'UnmonitoredInterfaces'? WDYT?" }, { "prediction": "I think it would be better to use `re.fullmatch(r'[A-Z]:[^\\\\]', path, re.IGNORECASE)` instead of `re.match(r'[A-Z]:[^\\\\]', path, re.IGNORECASE)`", "reference": "This should be `re.search` with a `^` anchor added to the regex, as what we want here is really any path starting with something like `E:`." }, { "prediction": "I think this should be `determineServiceEntry` instead of `determineServiceEntry`", "reference": "Since `IsKubernetesBuiltInResource` at L69 returns false due to lack `networking.istio.io/v1alpha3` in `builtInApiVersions` within `pkg/app/piped/cloudprovider/kubernetes/resourcekey.go`, it will never reach this point." }, { "prediction": "I think this should be `processor.NewFactory(selector, exportmetric.StatelessExportKindSelector)` instead of `processor.NewFactory(selector, exportmetric.StatelessExportKindSelector)`", "reference": "Does codecov not run this test? Not sure how else it would not be covered." }, { "prediction": "I think this should be `JSON_DATA` instead of `JSON_DATA`", "reference": "can we add some sample of JSON_DATA format in the usage?" }, { "prediction": "I think this should be `Tracer.Instance.DistributedSpanContext[HttpHeaderNames.ParentId]`", "reference": "Using `Tracer.Instance` in here is problematic for testing It will likely cause some other tests to break I think - that's why we started passing in `IScopeManager` EDIT: I see you used `[TracerRestore]` - maybe that'll be enough!" }, { "prediction": "I think this should be \"project_id_variable\".", "reference": "make all of these `static final` fields UPPER_SNAKE - they are constants." }, { "prediction": "I think it would be better to use `aabonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_PERCENT] + aabonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_PERCENT] + aabonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_PERCENT] + aabonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_PERCENT] + aabonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_PERCENT] + aabonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_PERCENT] + aabonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_PERCENT] + aabonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_PERCENT] + aabonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_PERCENT] + aabonuses.MitigateDotRune[", "reference": "No possible chance for weird overflows here, right?" }, { "prediction": "I think this should be a static constant.", "reference": "Or we could use a Float object to more clearly show as user-settable via non-null?" }, { "prediction": "I think this should be `_poSSwitcher.ForkchoiceUpdated(newHeadBlock!.Header, finalizedHeader);`", "reference": "finalizedHeader should be saved in FinalizationManager when we have FinalizationBlockHash != Keccak.Zero" }, { "prediction": "I think this should be `disk-importer-scratch-%d`", "reference": "Not using ExactName: true would remove the need for manually adding workflow ID as it would be added automatically by Daisy. E.g. 'disk-importer-2-import-ovf-7mn7h' was created from diskImporterDiskName above even though only 'disk-importer-2' was specified. ExactName: true should be used for resources that shouldn't include any temp prefix/suffix, such as disks that will be permanently attached to a created instance. Scratch disk is not one of them." }, { "prediction": "I don't think we should use `self._internal.column_scols` here. I think we should use `self._internal.column_scols` instead of `self._internal.column_scols`.", "reference": "If we support multi-index column later, we need to rename to fit the pandas' requirement." }, { "prediction": "I think this should be `type JSONValue map[string]interface{}` instead of `type JSONValue map[string]interface{}`", "reference": "I'm not sure this is really needed. JSONValue type can be used the same as a map as far as operators go, including range. I'd leave this out for now unless there is a strong reason to keep it." }, { "prediction": "I don't think we need to call `Item::startDecaying()` here.", "reference": "sorry for nitpicking but I would love a new line under this line" }, { "prediction": "Why is this removed?", "reference": "ChannelImplementation field naming is not clear, is it some kind of standard? Maybe it can be named ChannelID?" }, { "prediction": "I think this should be `removeFiles(String metadataLocation)`", "reference": "Looks like there is a typo: `expireSnapshots` -> `removeFiles` or whatever name we go with." }, { "prediction": "I think this should be `currentSortOrder != null`", "reference": "Thanks for looking into this. I think it looks a bit strange to have this check inside the for loop. Wouldn't it also work to initialize `idxCurrentSort` with 0 instead?" }, { "prediction": "I think it would be better to use the same name as `OMNIPOD_POD_ALERTS_UPDATED` instead of `OMNIPOD_POD_ALERTS_SUSPENDED`", "reference": "Just a small ordering thing: Could you please bring `IMPORTANCE_HIGH` to the bottom and maybe even have one line between it and the Notification IDs?" }, { "prediction": "Why do you need to keep the aromatic flags?", "reference": "Should this be boost logged?" }, { "prediction": "`session` is not used anymore.", "reference": "What is the reason for doing expunge here? This method is purely for converting the timestamp." }, { "prediction": "I think this should be `fieldSchemas.get(i).name()` instead of `fieldSchemas.get(i).name()`", "reference": "This calls sanitize twice if the name isn't valid." }, { "prediction": "Line is too long. [82/80]", "reference": "Is there an equivalent that'd allow zero or one?" }, { "prediction": "I think this should be `m.metaTaskExec.setObjectName(resource)` instead of `m.metaTaskExec.setObjectName(resource)`", "reference": "Is it possible to update/re-evaluate entire metatask object for every repeat? If we decide/need to use a repeatWith resources in let us say labelSelector(bad example) then we would have to add another logic to update those properties." }, { "prediction": "I think it would be better to use `int(syscall.Stdin)` instead of `int(syscall.Stdin)`", "reference": "unnecessary conversion (from `unconvert`)" }, { "prediction": "Why did you remove this?", "reference": "typo in commit message `openening`" }, { "prediction": "Why do we need to include the `adios2/engine/hdf5/HDF5ReaderP.h` file?", "reference": "User-code doesn't see the internal ADIOS headers anymore. This whole include block should just be `#include `" }, { "prediction": "Why did you remove this?", "reference": "nit: I guess we can omit this (unless you had a reason to specify it)" }, { "prediction": "I think this should be `c.leaf.remote != nil && !c.leaf.remote.Hub` instead of `c.leaf.remote.Hub`", "reference": "Why is Hub public?" }, { "prediction": "Why is this removed?", "reference": "why is this deleted?" }, { "prediction": "I think it would be better to use `

Hey, before you start this...Have you done the tutorial?

`", "reference": "Maybe move that into a partial" }, { "prediction": "I think this should be `os.TempDir(os.TempDir(os.TempDir(), \"db\")`", "reference": "Error return value of `dao.Stop` is not checked (from `errcheck`)" }, { "prediction": "I think this should be `util.Warnf(\"The provided docroot at %s does not currently exist.\", docrootRelPath)`", "reference": "util.Warning()? Easier to say." }, { "prediction": "I think this should be `logEvery.C` instead of `logEvery.C`", "reference": "this default is kinda superfluous (although i see it was already there before PR )" }, { "prediction": "Why is this removed?", "reference": "How is this related?" }, { "prediction": "I think this should be `TeamPlan.active.ordered` instead of `IndividualPlan.featured.ordered`.", "reference": "I'm breaking one of the rules here, it feels like the right thing to do. Open to alternative suggestions." }, { "prediction": "Line is too long. [82/80]", "reference": "The use of `#should` was triggering an rspec depracation warning for me, which is why I switched this to the rspec 3 style." }, { "prediction": "Why do we need to check if `chit->isValid()` is true?", "reference": "Why are you setting the CacheChange as REQUESTED when it is not valid (it was erased from history)?" }, { "prediction": "I don't think we need to do this, but I think we should use `wp.i18n = wp.i18n;` instead of `wp.i18n = wp.i18n;`", "reference": "`lodash` shouldn't be grouped under WordPress dependencies" }, { "prediction": "I think we should remove this method.", "reference": "This needs to be public so that Avro can call it." }, { "prediction": "Why is this removed?", "reference": "`Google*` shouldn't be under External dependencies - seems like ESlint is not properly recognizing that these are aliases to internal dependencies." }, { "prediction": "I think this should be `if isinstance(data, pd.DataFrame):` or `if isinstance(data, pd.DataFrame):`", "reference": "I think he meant the docstring in this constructor. yea we should fix" }, { "prediction": "I think this should be `getClassResource(String path)` instead of `getClassResource(String path)`", "reference": "so .. this basically follows the pattern from JapaneseTokenizer, I think. .. but somehow I don't see where we defined ResourceScheme? We're not referencing the one in kuromoji, right?" }, { "prediction": "I think this should be `SecurityProtocolType.Tls12` instead of `SecurityProtocolType.Tls11`", "reference": "It would probably be better to do: const SecurityProtocolType Tls13 = (SecurityProtocolType)12288" }, { "prediction": "I think we should remove the `created_at` and `updated_by` from the `created_at` and `updated_by` from the `created_at` and `updated_by` variables.", "reference": "Similar to the above, put this setting back but keep the value as `'{}'`" }, { "prediction": "I think this should be `logger.info` instead of `logger.info`", "reference": "As discussed in chat - we should run this function within an app context which means that we'd already have a logger configured, and a connection to timescale set up" }, { "prediction": "Why is this removed?", "reference": "I'm curious about why this needed to be removed." }, { "prediction": "I think it would be better to use `scapy.extlib` instead of `scapy.consts`.", "reference": "why did you remove `zip`? It is used!" }, { "prediction": "Why is this needed?", "reference": "Is there any reason that we don't add a similar condition like `ChannelConditionTopic` to the channel?" }, { "prediction": "I think this should be `_Goto` instead of `_Goto`.", "reference": "before php8 \"goto\" was a reserved word and was not allowed as part of the namespace. Now test checks for validity of plugin namespace according to PSR-4" }, { "prediction": "I think it would be better to use `tls.DefaultTransport` instead of `tls.DefaultTransport`.", "reference": "nit: I'm not sure it can be addressed in this diff, but it seems odd that NewOutbound supports TLS but NewSingleOutbound does not. As a somewhat naive user I would expect the only difference between these two APIs is how peers are chosen." }, { "prediction": "I think this should be `defer res.Body.Close()` instead of `defer res.Body.Close()`", "reference": "I would advise to enhance the test for the method `CallOneway` - we should have a test very similar to `TestCallSuccess`. We should test: - Success with response (even if it is callOneway) - Success with no response and empty payload - Errors" }, { "prediction": "I think this should be `[a-zA-Z0-9][a-zA-Z0-9\\\\-\\\\-]{1,256}`", "reference": "We're already matching +. Not sure why this changed." }, { "prediction": "I think this should be `if you really really want to disable the relation with category`", "reference": "Please add line breaks, so the line doesn't exceed 80 chars." }, { "prediction": "I think we should remove the `ActivitySourceAdapter` as well.", "reference": "I initially thought (inccoreclty) this is a breaking change! The public api analyzer is a gift!" }, { "prediction": "(style) line over 80 characters", "reference": "I'm not sure how this one didn't segfault before." }, { "prediction": "I think this should be `VXLANVNI` instead of `VXLANVNI`", "reference": "Same points as in other test file." }, { "prediction": "This file is not used anymore.", "reference": "Did you run gradlew tidy? Wildcard imports shouldn't be there, hence the question." }, { "prediction": "Line is too long. [89/80]", "reference": "Put a comma after the last parameter of a multiline method call." }, { "prediction": "(style) line over 80 characters", "reference": "Is this going to restrict the output to *ONLY* ports that are bound to vfio-pci? That's not what we discussed yesterday." }, { "prediction": "I think this should be `if signer.Protocol() == address.ID`", "reference": "Intention is to do the lookup here, I believe (where we can cache it). This would make the call non-pure function though. I'll confirm with lotus. ID addresses are the *only* addresses I expect to actually see here." }, { "prediction": "I think it would be better to use `EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMRFS_EMR", "reference": "electronic medical record file system (EMRFS)" }, { "prediction": "Why is this needed?", "reference": "Put this higher in the list, like after \"bind\", since I guess we're considering the max request body size to be kind of a native/fundamental feature, built directly into the vhosts." }, { "prediction": "I think we should remove the `errImageForbidden` from the error message.", "reference": "oh come on :(" }, { "prediction": "I think this should be `LOG.finest(String.format(\"Detected dialect: %s\", toReturn.dialect));` or `LOG.info(String.format(\"Detected dialect: %s\", toReturn.dialect));`", "reference": "This is an incorrect change. The dialect spoken is an important part of the handshake and should be communicated to users." }, { "prediction": "I think this should be `user_is_service_account` instead of `user_is_service_account`", "reference": "Remove as this is not needed anymore." }, { "prediction": "I don't think this is necessary.", "reference": "This new class is for checking that #4551 works correctly with PlantUML output too." }, { "prediction": "I think this should be `cmapi.UsageServerAuth` and `cmapi.UsageDigitalSignature` as per https://support.apple.com/en-us/HT210176`", "reference": "Will this cause all certificates to be re-issued?" }, { "prediction": "(style) line over 80 characters", "reference": "I think tmp is also leaked at the end of this loop if no error cases are encountered." }, { "prediction": "I think this should be `if (keyProjection.schema() != keyField.schema() || valueProjection.schema() != valueField.schema()) { return AvroSchemaUtil.createProjectionMap(keyValueSchema.getFullName(), keyProjection.schema()); } else if (keyProjection.schema() != keyField.schema()) { return AvroSchemaUtil.createProjectionMap(keyValueSchema.getFullName(), keyProjection.schema()); } else if (keyProjection.schema() != valueField.schema()) { return AvroSchemaUtil.createProjectionMap(keyValueSchema.getFullName(), keyProjection.schema()); } else if (valueProjection.schema() != valueField.schema()) { return AvroSchemaUtil.createProjectionMap(keyValueSchema.getFullName(), valueProjection.schema()); } else if (valueProjection.schema() != valueField.schema()) { return AvroSchemaUtil.createProjectionMap(keyValueSchema.getFullName(), valueProjection.schema()); } else if (valueProjection.schema() != valueProjection.schema()); return AvroSchemaUtil.createProjectionMap(keyValueSchema.getFullName(), valueProjection.schema()); return AvroSchemaUtil.createProjectionMap(keyValueSchema.createProjectionMap(key", "reference": "The previous version didn't use `keyProjection` because the entire key must be projected. If the key is a struct of multiple columns, then projecting a subset of those columns can easily introduce key collisions that aren't in the original data." }, { "prediction": "I think this should be `if (spaceId < 0) {`", "reference": "Why not use StatusOr ? We can't ensure spaceId is greater than zero, especially when AdHocSchemaManager is used." }, { "prediction": "I think we should use `go-ethereum/rpc` instead of `go-ethereum/rpc`.", "reference": "Does it seem we only use that as the json-rpc client? Do we have any other choice? It's a little weird." }, { "prediction": "I think this should be `or (role in (controlTypes.ROLE_DELETED_CONTENT, controlTypes.ROLE_INSERTED_CONTENT, controlTypes.ROLE_DELETED_CONTENT, controlTypes.ROLE_INSERTED_CONTENT, controlTypes.ROLE_TREEVIEW, controlTypes.ROLE_CHECKMENUITEM, controlTypes.ROLE_RADIOMENUITEM, controlTypes.ROLE_TREEVIEW, controlTypes.ROLE_TREEVIEW, controlTypes.ROLE_TREEVIEW, controlTypes.ROLE_REVISION, controlTypes.ROLE_REVISION, controlTypes.ROLE_REVISION, controlTypes.ROLE_REVISION, controlTypes.ROLE_REVISION, controlTypes.ROLE_REVISION, controlTypes.ROLE_REVISION, controlTypes.ROLE_REVISION, controlTypes.ROLE_REVISION, controlTypes.ROLE_REVISION, controlTypes.ROLE_REVISION, controlTypes.ROLE_REVISION, controlTypes.ROLE_REVISION, controlTypes.ROLE_REVISION, controlTypes.ROLE_REVISION, controlTypes.ROLE_REVISION, controlTypes.ROLE_REVISION, controlTypes.ROLE_REVISION, controlTypes.ROLE_REVISION, control", "reference": "Could you split this into multiple lines?" }, { "prediction": "Why is this removed?", "reference": "Doesn't the snapshot ID start off as null? It seems like we don't need to set it here." }, { "prediction": "Why do we need to use `buffer[:0]` here instead of `buffer[:0]`?", "reference": "I wondered why `buffer` was passed into `LookupPath`. What is happening here? Is `buffer[:0]` equivalent to `[]V4TrieEntry{}`, and hence `buffer` isn't needed any more?" }, { "prediction": "I think this should be `NewSignatureValidator(parentStateRoot)` instead of `NewSignatureValidator(parentStateRoot)`", "reference": "nit: Ideally we would would use this abstraction everywhere we need this translation. I believe it's needed in the mining worker and the storage and market connectors." }, { "prediction": "I think this should be `GetHash(cStorPoolGot.Spec.Disks.DiskList)`", "reference": "need to fix the error message here" }, { "prediction": "I think this should be removed.", "reference": "Unsure of how to handle this one." }, { "prediction": "I think this should be `if (isKilled() || this.flowFinished)`", "reference": "Will this.flowFinished verify with every finished state stated in Status.isStatusFinished method? If so, no need to verify isKilled." }, { "prediction": "I think this should be `DefaultRetryPolicy` instead of `DefaultRetryPolicy`.", "reference": "replace \"Child Workflow\" with \"any workflow\"" }, { "prediction": "Why is this removed?", "reference": "Instead of showing the words \"symbolic link\" under the \"Size\" column, how about we introduce new icons for symbolic link to file and symbolic link to directory?" }, { "prediction": "I think this should be `internal` instead of `internal`.", "reference": "Please add back the description of the parameter" }, { "prediction": "Why is this removed?", "reference": "Superfluous space inserted." }, { "prediction": "I think this should be `node.ownerSVGElement.getAttribute(attribute)` instead of `node.getAttribute(attribute)`", "reference": "Didn't fix the problem. `href=\"\"` for SVG will still result in `undefined` getting returned by this function." }, { "prediction": "I think it would be better to use `json::Array{{58,238}}` instead of `json::Array{{238}}` instead of `json::Array{{238}}` instead of `json::Array{{238}}`.", "reference": "This seems like a strange change ... I wouldn't think that a change to access tags in the profiles would result in different bearings in this tests?" }, { "prediction": "I think this should be `self._oldReviewPos = api.getReviewPosition(self._oldReviewPos, isCaret=False)`", "reference": "As isCaret is False by default, explicitly specifying isCaret=False here is not needed, and is perhaps a little confusing. I'd prefer that anywhere in the codebase that isCaret is only ever specified if it needs to be set to true. Mirroring that of isFocus for setNavigatorObject." }, { "prediction": "Line is too long. [82/80]", "reference": "We can't freeze this and then add something to it in the next line. The `freeze` on line 43 is sufficient. If Rubocop flags this we need to exclude it." }, { "prediction": "Why do we need to sort here?", "reference": "Why is this needed?" }, { "prediction": "Why do we need this?", "reference": "Why not put two other routes after this line (221)?" }, { "prediction": "I think it would be better to use `if (addrs.value().isEmpty() || addrs.value().value().isEmpty() || addrs.value().value().isEmpty()) {` instead of `if (addrs.ok() || addrs.value().value().isEmpty() || addrs.value().value().isEmpty() || addrs.value().value().isEmpty() || addrs.value().value().isEmpty() || addrs.value().value().isEmpty() || addrs.value().ok() || addrs.value() || addrs.value().value().isEmpty()) { return addrs.status(); }`", "reference": "If FLAGS_meta_server_addrs is not empty, in which case \"toHosts\" return empty array?" }, { "prediction": "I think this should be `JSONBoolWithQuotes(DEFAULT_JSON_USE_QUOTES)` instead of `JSONBoolWithQuotes(DEFAULT_JSON_USE_QUOTES)`", "reference": "There is a function to output a \"JSONBool\" string. That would be a good start for finding uses. But maybe just have a look at where we decide whether it is a numerical or not, thus wrapping quotes around its value. Then you have it all I guess." }, { "prediction": "`scol = data._internal.data_scols[0]`", "reference": "oops, it should be `data._scol` so that it respects the expression stored in Series. Let me fix it quick." }, { "prediction": "I don't think we need to check if the user is administerable by the current user.", "reference": "Thanks for moving this up with the rest of the variables. Much tidier :)" }, { "prediction": "I think this should be `dto.PaymentPerTime{Price: money.NewMoney(0.001, money.CurrencyMyst),Duration: 1 * time.Minute, }`", "reference": "I think `Rate` is a more precise and concise term for `PaymentPerTime`." }, { "prediction": "I think it would be better to use `posNext = input.IndexOfAny(new[] { '+', '-', ']' });` instead of `posNext = input.IndexOfAny(new[] { '+', '-', ']' });`", "reference": "I think this should maybe be: var limit = input.IndexOfAny(new[] { '+', '-', ']' }, **posNext**); You pretty much want to ignore any sign that is before the \"M\". But, if there is a sign somewhere before the M, and also after the M, you'd want to be able to find the sign after the M, right?" }, { "prediction": "I think it would be better to use `ConfigQuery::checkAvailableStock()` instead of `ConfigQuery::checkAvailableStock()`.", "reference": "if `checkStockNotEmpty` returns a reponse, you must return it or your script will continue its execution." }, { "prediction": "I think this should be `klogv1` instead of `klogv2`", "reference": "Any specific reason for this change? klog should work correctly here." }, { "prediction": "I think it would be better to use `set_last_modified` instead of `set_last_modified` here.", "reference": "we don't mention `last_modified` here?" }, { "prediction": "I don't think we should use `preact` here.", "reference": "same deal about the global state maybe interfering as in ActionBrowseTagline" }, { "prediction": "I think this should be `Assert.Throws` instead of `Assert.Throws`", "reference": "so sweet to see a test as the first thing" }, { "prediction": "(style) line over 80 characters", "reference": "usually when HTTP_PROXY=\"\" (empty), proxy should be disabled. could you set it to NULL when it's empty string?" }, { "prediction": "Why do you need this?", "reference": "Can you throw an exception if width or height are both null" }, { "prediction": "I think it would be better to use `HTTPSchemeKey.String(\"http\")` instead of `HTTPSchemeKey.String(\"https\")`", "reference": "This is a breaking change. I guess these might have been intentionally exported." }, { "prediction": "I think this should be `options.get(TableProperties.METADATA_SPLIT_SIZE)`", "reference": "I don't think this is necessary. When options are used to set the split size in the Spark reader, it uses `TableProperties.SPLIT_SIZE` to pass it here. That should work for metadata tables as well, right? The situation that we need to handle in this PR is setting the default, like you had before. We just want to use a metadata split size so you can set it and not have the same split size used (by default) for both metadata and data scans." }, { "prediction": "I think this should be `Divide` instead of `Divide`", "reference": "wait a sec, shouldn't this be `'*'`?" }, { "prediction": "I think this should be `varMap[\"compute_service_account\"] = oi.params.ComputeServiceAccount if oi.params.ComputeServiceAccount != \"\" { varMap[\"compute_service_account\"] = oi.params.ComputeServiceAccount if oi.params.ComputeServiceAccount != \"\" { varMap[\"compute_service_account\"] = oi.params.ComputeServiceAccount if oi.params.ComputeServiceAccount != \"\" { varMap[\"compute_service_account\"] = oi.params.ComputeServiceAccount if oi.params.ComputeServiceAccount != \"\" {varMap[\"compute_service_account\"] = oi.params.ComputeServiceAccount if oi.params.ComputeServiceAccount != \"\" { varMap[\"compute_service_account\"] = oi.params.ComputeServiceAccount if oi.params.ComputeServiceAccount != \"\" { varMap[\"compute_service_account\"] = oi.params.ComputeServiceAccount if oi.params.ComputeServiceAccount != \"\" { varMap[\"compute_service_account\"] = oi.params.ComputeServiceAccount if oi.params.ComputeServiceAccount != \"\" {varMap[\"compute_service_account\"] = oi.params.ComputeServiceAccount if oi.params.ComputeServiceAccount != \"\" { varMap[\"compute_service_account\"] = oi.params.Compute", "reference": "It think you'll want the var for GMI import as well: daisy_workflows/ovf_import/create_gmi.wf.json (Unfortunately there's duplication between the two :/ )" }, { "prediction": "I think this should be `GET_CONTEXT` instead of `SET_CONTEXT`.", "reference": "Nit: Group this with the other commands by moving it down one line." }, { "prediction": "I think this should be `if (dataEncoding != Encoding.PLAIN) { throw new UnsupportedOperationException(\"Unsupported encoding: \" + dataEncoding); } else { throw new UnsupportedOperationException(\"Unsupported encoding: \" + dataEncoding); }`", "reference": "I would like to emphasize that a user can use non-vectorized reads to handle this file so maybe something like \"Cannot perform a vectorized read of ParquetV2 File with encoding %s, disable vectorized reading with $param to read this table/file\"" }, { "prediction": "I don't think we should use `default=None` here as well. I think it would be better to use `default=None` instead of `default=None`.", "reference": "Maybe add `positional=False`. It does not need it more than the other parameters, but one must start somewhere." }, { "prediction": "I think it would be better to use `f('../../spec/max-staleness/ReplicaSetWithPrimary', __dirname);` instead of `f('../../spec/max-staleness/ReplicaSetWithPrimary', __dirname);`", "reference": "Since we're here, can we use a template?" }, { "prediction": "I don't think we need this hack anymore.", "reference": "saw you're also doing this in `test_types.py`: `spark = _spark_context()['test'].resources['spark'].resource_fn(None)` since `_spark_context()` uses `spark_session_local` won't the above break the tests?" }, { "prediction": "I think this should be `default == ''` instead of `default == ''`", "reference": "`has(default)` i think is the preferred way of doing this" }, { "prediction": "why not just use `sse.isDelta()` here?", "reference": "always put a space after a comma" }, { "prediction": "I think this should be `selectAllPhotosUpToFav` instead of `selectAllPhotosUpToFav`.", "reference": "@angmas1 move the else up, next to the closing bracket of the if block. Also, there is no need for the braces as your else statement contains only a single line. Make your if-else block similar to the block in lines 277-280." }, { "prediction": "I think this should be `options=None` instead of `options=None`", "reference": "@AutomatedTester @davehunt thoughts on a new keyword argument?" }, { "prediction": "I don't think we need to do this.", "reference": "This change shouldn't be necessary for this PR. Please remove it." }, { "prediction": "I think this should be `*testContext`", "reference": "This variable is mostly unused, how about we make `NewTestCtx` return a pointer?" }, { "prediction": "I think this should be 32Mi.", "reference": "What is the basis of this value?" }, { "prediction": "I think this should be `gce_metadata.h` or `gce_metadata_conf.h`.", "reference": "Nit: was this extra blank line added intentionally?" }, { "prediction": "(style) line over 80 characters", "reference": "nit: inconsistent spacing around =" }, { "prediction": "Why is this removed?", "reference": "We still need this import" }, { "prediction": "I think this should be removed.", "reference": "We are pulling this because we removed \"groupID\" state and put it into the strategy implementations" }, { "prediction": "Why did you remove this?", "reference": "Is this file actually related to PCA?" }, { "prediction": "I think this should be `isFirstAdmin` instead of `isOwner`.", "reference": "See above, this should probably remain `isFirstAdmin`." }, { "prediction": "Why is this removed?", "reference": "Why the change to make it public? The expression interface has the `TypeOf` method?" }, { "prediction": "I think this should be `Single_Archive_File_Rolls_Correctly` instead of `Single_Archive_File_Rolls_Correctly`.", "reference": "don't mind the snake cases in the test names. If there are in the test cases, it's fine IMO" }, { "prediction": "I think this should be `id` and `passphrase`", "reference": "`Id` defines REST resource address and should not be in payload" }, { "prediction": "I don't think this is a good idea, but I think it would be better to add a `--class-wise` argument to the `coco_eval` function. I think it would be better to add a `help='whether eval class wise ap'` argument to the `coco_eval` function. I think it would be better to add a `help='whether eval class wise ap'` argument to the `coco_eval` function `coco_eval` function `coco_eval_class_wise_ap_ap_ap_ap_ap_ap_ap_ap_ap_ap` function.", "reference": "We can omit the underscore and just use `classwise`." }, { "prediction": "I don't think this should be safe as the root category has to exist for a given context but I do not like fatal errors.", "reference": "Why not throw an exception instead then?" }, { "prediction": "Why is this removed?", "reference": "Looks like this doesn't need to change. Can you revert this?" }, { "prediction": "I don't think this is needed anymore.", "reference": "please import it like `from kinto.config import template`" }, { "prediction": "I think this should be `getStringProperty(\"true\", \"false\");`", "reference": "There are lots of default value changed, not sure if it break the old behavior." }, { "prediction": "I think we should remove the `go.uber.org/grpc/reflection` from the `go.uber.org/grpc` package.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "Why do we need to pass `addToStaticNodes` to `NodeManager.Post`?", "reference": "parameter should be called removeFromStaticNodes" }, { "prediction": "I think it would be better to use `override: bool = False` instead of `override: bool = False`", "reference": "The handler will have an extra property in the marker to signal the implementation is in the provider, for the cases we want to add functionality, for example, custom implementations not in moto." }, { "prediction": "I think this should be `deactivated_on.nil?` instead of `deactivated_on.nil?`", "reference": "Is this method actually being used anywhere? If not, I think we should remove it." }, { "prediction": "I think this should be `!p.IsConstant && !p.IsReadOnly` or `!p.IsReadOnly`", "reference": "Thanks! I somehow lost this between my far too many branchs." }, { "prediction": "I don't think this is needed anymore.", "reference": "i think this should get put into its own file. This could start to grow :)" }, { "prediction": "I think this should be `gcr.io/google_containers/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/gcr.io/", "reference": "Can you add a TODO for loading the tarball of the pause image into Docker?" }, { "prediction": "Why did you remove the `this.process = null;` here?", "reference": "Is there any value in setting the process to null like this?" }, { "prediction": "I don't think this is a good idea, but I think it would be better to use `CHECK_EQ(outer_num_ * inner_num_, bottom[1]->count(0, softmax_axis_ + 1));` instead of `CHECK_EQ(outer_num_ * inner_num_, bottom[1]->count(0, softmax_axis_ + 1));`", "reference": "This could be a good time to add a check that the prediction and target dimensions (except channel) agree?" }, { "prediction": "(style) line over 80 characters", "reference": "The requirement that OP_isb is bb-final needs to be a rule for clients, just like the rule that syscalls and interrupts must be bb-final: i.e., please add it to the dr_register_bb_event() docs." }, { "prediction": "I don't think we should use `Globalize.translate(\"ListPaging\").replace(\"{0}\", totalRecordCount);` here.", "reference": "The translate library has a method to replace the variables." }, { "prediction": "This test is not related to this PR, but it's not related to this PR.", "reference": "i don't think this test case is correct. in both cases inpalce=True returns nothing. We need to compare the ks. Also we probably need to make a copy of it. Otherwise you pollute the following \"ks\" because ks has been changed." }, { "prediction": "Why do we need to remove this?", "reference": "Any proposals how to make the naming somehow include the \"completed\" idea of this hook? `TlsHandshakeCompletedHook` or similar? Or using the `...Start/End...` scheme?" }, { "prediction": "I think this should be `_syncReport.FullSyncBlocksKnown = bestPeer.HeadNumber;`", "reference": "it introduces a lot of complexity to the state, can we flush straightaway or create a two level flush store where the questions are read form unflushed data?" }, { "prediction": "I think it would be better to use `urlencode($node->id);` instead of `urlencode($node->id);`", "reference": "There are two calls to getUrlFromRouteCache, but you're only urlencoding one of them. Is that intentional? Would it make more sense to do the url-encoding inside the getUrlFromRouteCache function?" }, { "prediction": "I think this is a bit confusing, but I'm not sure if we want to do this in a separate PR.", "reference": "Maybe we can use `this.instance.getCell` with `topMost` flag to get `TD` element?" }, { "prediction": "I think this should be `log.L().Info(err.Error())` or `log.L().Warn(err.Error())`", "reference": "Change this to Debug Level" }, { "prediction": "Why do we need to do this?", "reference": "I refactored the Aggregate, those are hard to read" }, { "prediction": "Why did you remove this?", "reference": "This is now done in the after method, so this test won't pass any more." }, { "prediction": "Line is too long. [89/80]", "reference": "What was the point of creating `user_block` if you're then not going to use it ;-)" }, { "prediction": "Why is this removed?", "reference": "@ueshin, I thought we can remove this entire file. Does that require some more works?" }, { "prediction": "I think it would be better to use `str(tokens.string)[1:-1]` instead of `unicode(tokens.string)[1:-1]`.", "reference": "Just `return tokens.string[1:-1]` is enough" }, { "prediction": "I think this should be `resources:quizzes, only: [:show]`", "reference": "1 trailing blank lines detected." }, { "prediction": "I think this should be `this.setPrefWidth(Double.MAX_VALUE);`", "reference": "Isn't this the default max width? In any case I would prefer to see these definitions in the css files." }, { "prediction": "I think this should be `func() string { return \"https\" }`", "reference": "Is this thread-safe? (If not, and if the solution is to introduce locking, let's reconsider how we do the scheme changing instead...)" }, { "prediction": "I think we should remove the `aggregate` here.", "reference": "Looks like this file has tabs instead of spaces." }, { "prediction": "I think this should be `TaskEngine[%s]/[%s]` instead of `TaskEngine[%s]`", "reference": "Hmm should we clean up container resources before task resources here? or the order does not really matter here?" }, { "prediction": "Why did you remove the `clean_old_downloads` function?", "reference": "Please undo this :wink:" }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Prefer single-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", "reference": "thanks for adding this missing association" }, { "prediction": "I think this should be `app.UseKestrelHttps(new HttpsConnectionFilterOptions({ServerCertificate = cert});`", "reference": "Should I remove this in favor of the HttpsConnectionFilterOptions overload?" }, { "prediction": "I think this should be `max(index)` instead of `max(index)`", "reference": "This shode be nullable, there alway sholud be at least one status in system , if not exist that mean data problme" }, { "prediction": "I think this should be `addJs('../../../modules/backend/assets/js/auth/unistall-sw.js');`", "reference": "Spaces not tabs" }, { "prediction": "I think this should be `fs.readdirSync(path, {withFileTypes: true}).map(e => e.name);`", "reference": "To get the files inside a directory, please use `readDirStats()`." }, { "prediction": "I think this should be `ContainerImplementationPlz` instead of `ContainerImplementationDocker`.", "reference": "might be worth to call these `Isolation` instead of containers here and when presented to the user -- docker/rkt , in addition to cgroups and namespaces, also provide image discovery and filesystem preparation; there's also the security context and probably 1-2 other small things" }, { "prediction": "I think it would be better to have a separate PR for this.", "reference": "File is empty, consider removing?" }, { "prediction": "I think this should be `get_registry_url` instead of `get_registry_url`", "reference": "This seems to return the registry_url. The more meaningful URL is the catalog URL, which is the URL the user specifies in `quilt3.login`. The username might also be as useful here if not more useful." }, { "prediction": "I think this should be `L1StandardBridgeAddress` instead of `L1StandardBridgeAddress`.", "reference": "Was the addition of `GasPriceOracleAddress` here erroneous?" }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Space inside } missing.", "reference": "I believe that you are going to have to do some work here to get the env var support for these values to still work correctly, otherwise they will get stored as :department instead of host_tags[:department]." }, { "prediction": "Why do we need to do this here?", "reference": "How was this causing the exception?" }, { "prediction": "I think this should be `if (currentCulture == 'zh-tw' || currentCulture == 'zh-hk')` or `if (currentCulture == 'zh-tw' || currentCulture == 'zh-hk')` or `if (currentCulture == 'zh-tw' || currentCulture == 'zh-hk')` or `if (currentCulture == 'zh-tw' || currentCulture == 'zh-hk')`", "reference": "I still have issues with it loading Simplified Chinese by default over Japanese, since they also share characters and we're not sure if characters are different or not. As-is, this fixes Traditional Chinese and Simplified Chinese, but we're not sure if it'd still screw up Japanese text or not. I maintain that, in my opinion, Japanese should be the only script of this kind loaded by default (Because of Hiragana and Katakana, that aren't shared with any other script) and either variant of Chinese should be loaded only in their respective case." }, { "prediction": "I think this should be `visitIntervalQuery(field, this);`", "reference": "Isn't it better to stub AtomatonQuery and yield it here. IIRC it resolves simplest MTQ highlighting cases as nobrainer." }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", "reference": "Line is too long. [96/80]" }, { "prediction": "I think this should be `kubernetes.io/os: \"linux\",`", "reference": "My only concern with changing the node selector here is that someone else _could_ have built their own images for other platforms and set them to be used using the flag override on the controller, which in turn this change would break. Perhaps not changing the selector for acmesolver pods makes most sense, and then working on actually having support for Windows? wdyt?" }, { "prediction": "I think this should be `v1alpha1.InnerObjectWithSelector` instead of `v1alpha1.InnerObjectWithSelector`", "reference": "Why do we need interface `InnerObjectWithSelector`, I searched the usage with this field, it seems nowhere use `GetSelectorSpecs()` methods provided by `InnerObjectWithSelector`" }, { "prediction": "I think this should be called `InitContext(MsgCtxTypeChannel)`, not `InitContext(MsgCtxTypeChannel)`", "reference": "Do we need this `init` here? We have already called the `InitContext` in `StartModule` directly." }, { "prediction": "I don't think we should use `self.execute(Command.W3C_MINIMIZE_WINDOW, {\"windowHandle\": \"current\"})` here.", "reference": "This `if` is not necessary" }, { "prediction": "I don't think we need this value for input masking.", "reference": "should we add a `mangle.json` mapping for this? We could reuse a property name that's only used on component or vnode objects right now, like `__s` (\"next state\")." }, { "prediction": "I don't think this is needed anymore.", "reference": "Please update the yard docs to indicate this new option." }, { "prediction": "I think this should be `CIDRs` instead of `CIDRs`", "reference": "Can you provide an example in the godoc section on how to use this? From the implementation it looks like the AvailabilityZone field is required for example, otherwise it can fail / error, is that correct?" }, { "prediction": "I think it would be better to use `codeVersion.String()` instead of `codeVersion.String()` instead of `codeVersion.String()`", "reference": "It would be great if this could be captured by a test." }, { "prediction": "I think this should be `dc.GetIntProperty(dynamicconfig.WorkerESProcessorBulkSize, 16*1024*1024)` instead of `dc.GetIntProperty(dynamicconfig.WorkerESProcessorBulkSize, 16*1024*1024)`", "reference": "1000 -> 100 maybe too much, 200 ish to 500ish maybe a good option" }, { "prediction": "I think this should be `addr.GetChecksumAddress().String()` instead of `addr.GetChecksumAddress().String()`", "reference": "Any reason we need to keep this package's `ChecksumAddress` type or can we get rid of it too?" }, { "prediction": "I think this should be `buttonRestart` and `headerRestart`", "reference": "Above the one that was picked was the Button* prefix, and here it's the Header* prefix. Maybe the Button prefix is more general." }, { "prediction": "Why is this needed?", "reference": "I might prefer changing: public Block FindPendingBlock() => FindBlock(PendingHash, BlockTreeLookupOptions.None); public BlockHeader FindPendingHeader() => FindHeader(PendingHash, BlockTreeLookupOptions.None); in IBlockFinder, what do you think?" }, { "prediction": "Why do we need to add this to the `kubebuilder:pruning:PreserveUnknownFields` field?", "reference": "This is necessary due to a bug in 4.7. Follow HIVE-1561 for getting rid of it." }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Prefer single-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I think this should be `XKeysymToString` instead of `XKeysymToString`", "reference": "Some day (tm) I will also get rid of that one. But today is not that day..." }, { "prediction": "I think we should use `substr($localPath, 0, 1)` instead of `substr($localPath, -1) !== '/'`", "reference": "Add a space between if and opening parenthesis please (i.e. `if (`)" }, { "prediction": "I don't think this is necessary.", "reference": "nit: `rename` instead of `alias`?" }, { "prediction": "I think this should be `if devName == \"/dev/sd\" {`", "reference": "Per AWS docs EC instances have the root mounted at /dev/sda1. This label should be skipped." }, { "prediction": "Why did you remove this?", "reference": "I'm not sure it is a better way to address lose message, if wait here, edge controller cant process message, event from watching api-server will be lost yet, right?" }, { "prediction": "I think this should be `if p.len is not None and p.value_size is not None else 0`", "reference": "Please keep the correct alignment, it seems broken now (at least in Github). Can you reverse the test (`if p.value_size is None`)? Also, do you want `6` when `p.value_size is None` or `x + 6`? Maybe, in that case, something like `lambda p, x: x + 6 + (0 if p.value_size is None else p.value_size)` would be easier to read. Or even easier: `lambda p, x: x + 6 + (p.value_size or 0)`." }, { "prediction": "I think this should be `int64` instead of `int64`", "reference": "Can we make sure ECS service treats it as int64 as well?" }, { "prediction": "I don't think we should use `self.windowText` here.", "reference": "Please follow the naming convention for variables, i.e. `windowText`." }, { "prediction": "I think this should be `m_casttemplate_v1alpha1` instead of `castv1alpha1`", "reference": "alias can be `cast`" }, { "prediction": "(style) line over 80 characters", "reference": "Let's use `%zu` instead of casting to `uint64_t` and using `PRIu64`. The alternative is to change the type of `mmap_errors` to `uint64_t`, though I'd prefer not doing that because some 32-bit platforms might not provide atomic operation support for `uint64_t`." }, { "prediction": "I think this should be `WARNING` instead of `SUGGESTION`.", "reference": "I recall there being a reason we had this one set only to suggeation. @carterkozak do you remember why? or is my memory getting corrupted?" }, { "prediction": "Why do we need to do this here?", "reference": "This should now be made into `if (it->second.empty())` ?" }, { "prediction": "I think this should be `self.num_of_searches = 0`", "reference": "Do we need to worry about a race condition on this decrement (@The-Compiler)? I'm not sure how the python callbacks work, so this might not need to be something to worry about." }, { "prediction": "I think this test is not related to this PR, but I think it's not related to this PR.", "reference": "Should these assert that the extracted `SpanContext` is remote?" }, { "prediction": "I think this should be `match_high_quality` instead of `match_low_quality`.", "reference": "typo: allow low quality matches." }, { "prediction": "I think this should be `*cmds.Server` instead of `*cmds.Server`.", "reference": "At some point we need to condense down and refactor our \"configs\" as we have too many in too many places and we're starting to get more illegible code. No change necessary but calling out for future reference." }, { "prediction": "Style/StringLiterals: Prefer single-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", "reference": "Can we add the `if label` conditional to this please?" }, { "prediction": "I think this should be `mlflow>=0.2.0`", "reference": "@thunterdb, can we increase the minimal version to almost the latest ones? I was thinking people will mostly use the latest version of mlflow" }, { "prediction": "`hasFillDataChanged` -> `hasFillDataChanged` -> `hasFillDataChanged` -> `hasFillDataChanged` -> `hasFillDataChanged` -> `hasFillDataChanged` -> `hasFillDataChanged` -> `hasFillDataChanged` -> `hasFillDataChanged` -> `hasFillDataChanged` -> `hasFillDataChanged` -> `hasFillDataChanged` -> `hasFillDataChanged` -> `hasFillDataChanged`", "reference": "If the last argument is going to be removed, why would we add it to the API docs? Shouldn't it be private for internal use?" }, { "prediction": "I think it would be better to use `IntermediatesManager` instead of `FileSystemIntermediateManager`.", "reference": "`Intermediates` or `Intermediate`" }, { "prediction": "I think this should be `isinstance(element, str) or isinstance(element, dict)`", "reference": "This is not the right exception class. There is an InvalidSelectorException class that covers bad locators." }, { "prediction": "I think this should be `c.config.JoinURL != \"\" && c.config.Token != \"\"` or `c.config.Token != \"\"`", "reference": "If this code isn't needed, it should be removed." }, { "prediction": "I think this should be done in the `metricsClient.Export` function.", "reference": "Should the `doRequest` func be a method on the `connection` type instead of passing state from the type?" }, { "prediction": "I think this should be `ECS_CLI_ENVIRONMENT_NAME` and `ECS_CLI_LB_DNS` and `ECS_CLI_PROJECT_NAME`", "reference": "we'll probably tackle these e2e tests at the end" }, { "prediction": "I think it would be better to use `GetHostName` instead of `GetHostEntry`.", "reference": "what is this address pointing to? what are we measuring here? I want to have a better understanding." }, { "prediction": "I think it would be better to use `SELECT distinct(trigger_instance_id) FROM execution_dependencies WHERE dep_status IN (0 or dep_status = 3)` instead of `SELECT distinct(trigger_instance_id) FROM execution_dependencies WHERE dep_status IN (0 or dep_status = 4)`", "reference": "Would it be better to pass the dependency status as the parameter into the SQL string? In case the enum value is changed in the future, we don't need to change the code here." }, { "prediction": "I think it would be better to use `libdokan.libdokan_build_windows` instead of `libdokan.libdokan_build_windows`", "reference": "Hah I had `gorename` failing without this too." }, { "prediction": "I think this should be `writer.WriteValue(Security.Instance.DdlibWafVersion?.ToString() ?? \"(none)\")`", "reference": "maybe prefix these with `appsec_` for consistency?" }, { "prediction": "I think this should be `golang.org/x/net/trace`", "reference": "nit: this should be down further with the other github imports" }, { "prediction": "I think this should be `if ctypes.windll.kernel32.FreeConsole() != 0`", "reference": "Why is this change necessary or related to the rest of the PR?" }, { "prediction": "Why is this needed?", "reference": "Hm, I wonder if the `see:` prefix is even necessary?" }, { "prediction": "I think it would be better to use `item.UserData.PlaybackPositionTicks = item.RunTimeTicks || item.UserData.PlaybackPositionTicks;` instead of `item.UserData.PlaybackPositionTicks = item.RunTimeTicks || item.UserData.PlaybackPositionTicks;` instead of `item.UserData.PlaybackPositionTicks = item.RunTimeTicks || item.UserData.PlaybackPositionTicks;`", "reference": "This should be translated." }, { "prediction": "I think this should be `if (param.count(\"num_class\") && new_config.num_class != config_.num_class) { Log::Fatal(\"Cannot change num_class during training\"); }`", "reference": "I originally had this PR only changing the R package, but then ran into this error > Error: [LightGBM] [Fatal] Cannot change metric during training This is thrown even if you aren't actually CHANGING `metric`. I think the change here in `c_api` is closer to the desired behavior, only throwing an error if the parameter is being changed." }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Prefer single-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", "reference": "These changes are just to make cli_spec a little more readable for VS Code users, as there's a bug with the Ruby plugin's syntax highlighting when you use multi-line regex literals." }, { "prediction": "I think this should be `constants.GlobalPullSecretName` instead of `constants.GlobalPullSecretName`", "reference": "Shouldn't the global pull secret by in the namespace of the hive-operator? It is part of the operand." }, { "prediction": "I think it would be better to use `assert_consumers(0)` instead of `assert_consumers(1)`", "reference": "kinesis-mock applies KINESIS_LATENCY to RegisterStreamConsumer actions so I added a sleep here." }, { "prediction": "I think this should be `LOG(ERROR) << \"Can't upgrade meta from V1 to V3\"`", "reference": "Only V1 or V3 is return from `getMetaVersionFromKV`. So where do we call `updateMetaV2ToV3`?" }, { "prediction": "I think this should be `nodeAttestorV1` instead of `nodeAttestorV0`", "reference": "I think that V0 is missing here, which will prevent plugins that haven't been converted to work." }, { "prediction": "I don't think we need to do this in a separate PR.", "reference": "Should we remove this?" }, { "prediction": "I think this should be `github.com/docker/distribution/reference`", "reference": "Put on top of the import." }, { "prediction": "I think this is not a good idea, but I'm not sure if it's a good idea to add a name to this module.", "reference": "See above, this shouldn't be added." }, { "prediction": "I think it would be better to use `ITEM_FURY_ORNAMENT_KIT(FURY_ORNAMENT_KIT, AMULET_OF_FURY_OR)` instead of `ITEM_FURY_ORNAMENT_KIT(FURY_ORNAMENT_KIT, AMULET_OF_FURY_OR, AMULET_OF_FURY_OR, AMULE", "reference": "This'll likely get fixed upstream, we should let them deal with it." }, { "prediction": "I think this should be `libp2p.HostFactory` instead of `libp2p.HostFactory`", "reference": "Somehow, this field does not seems useful for the exposed package api, only for the tests. Would you consider having an unexported field in `hostFactory func(context.Context, ...libp2p.Option) (host.Host, error)` instead to be set only by a new helper function defined in export_test.go. This is just a suggestion, not a hard requirement for the PR approval." }, { "prediction": "I think it would be better to use `moment().startOf(timeDuration).add(n, timeDuration).format('x')` instead of `moment().startOf(timeDuration).subtract(n, timeDuration).format('x')`", "reference": "As a first argument to these function, please pass the date that should go forward/backward. Also please clarify what is \"n\" (possible values, unit) and what is timeDuration (possible values, unit, as from your code it seems to be \"day\", \"hours\", etc. but from your example it seems to be milliseconds)." }, { "prediction": "I don't think we need to do this, but I think it would be better to use `config.conf[\"general\"][\"language\"]` instead of `config.conf[\"general\"][\"language\"]`", "reference": "Are you sure you really need this code here? that script will be certainly run in NVDA's main thread, and core would have already called setLanguage." }, { "prediction": "I think this should be `10256` instead of `10256`", "reference": "why is this changed ?" }, { "prediction": "I think this should be `doc.revision` instead of `doc.revision`", "reference": "Should this be \"the new revision value\"?" }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Space inside } missing.", "reference": "You have deleted :attribute" }, { "prediction": "I think we should remove this line.", "reference": "The license header should be updated to the Apache one." }, { "prediction": "I think this should be \"Samples.HttpMessageHandler-http-client\" instead of \"Samples.HttpMessageHandler-http-client\".", "reference": "@zacharycmontoya Is there any way to distinguish a `SocketHttpHandler` from another `HttpMessageHandler` request?" }, { "prediction": "(style) line over 80 characters", "reference": "Not sure about this one -- did you check somehow?" }, { "prediction": "Line is too long. [89/80]", "reference": "Is there a good reason to keep this at the `pe_ver_win` name now that it's per-host?" }, { "prediction": "I think this should be `new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment())))), menuTitles[0)))`", "reference": "Not in the order of display : Front, Ingredient, Nutrition here (which is the right thing), Actually displayed: Front, Nutrition, Ingredients" }, { "prediction": "I think we should remove the `json:\"startTime\"` here.", "reference": "Why delete `StartTime`? This `StartTime` was used to avoid the PID was reused." }, { "prediction": "Line is too long. [82/80]", "reference": "My concern here, is that if the dump_puppet_log also throws then we will lose the data about the teardown_exception." }, { "prediction": "(style) line over 80 characters", "reference": "Should it be `int64_t`?" }, { "prediction": "I think this is a bit confusing to me.", "reference": "is this value related to something ?" }, { "prediction": "I think it would be better to use `ValueTask` instead of `ValueTask`.", "reference": "Add names to tuple elements ValueTask<(Keccak? Hash, AddTxResult? AddResult)>, should they both be nullable?" }, { "prediction": "I think it would be better to use `replaceAcronyms(namePiece);` instead of `replaceAcronyms(namePiece);`", "reference": "I think it might make more sense to do this in Name.upperCamel; it is the entry point for upper camel strings." }, { "prediction": "Why not just cast to `ArrayType`?", "reference": "Huh? The point is that a cast isn't necessary" }, { "prediction": "I think this should be `InstallCRD` instead of `InstallCRD`", "reference": "can we name it like `InstallV1Alpha1CRDs` ?" }, { "prediction": "I think this should be \"hiveutil-created-label\".", "reference": "I need something to match when creating selectorsyncsets so added this label." }, { "prediction": "Why do we need this?", "reference": "Isn't `nil` the default return value from an empty `rescue` clause? If that's correct, then we could just remove the `nil` line entirely as it doesn't serve a purpose." }, { "prediction": "I think it would be better to use `s3.s3_ruby_bucket_cors.rb` instead of `s3.s3_ruby_bucket_cors.rb`.", "reference": "Simple Storage **Service**" }, { "prediction": "I think this should be `validIndex.Sub(r.idx.Obsolete())` instead of `validIndex.Sub(r.idx.Obsolete())`", "reference": "Wouldn't that cause the obsolete indexes to be downloaded over and over again? After all these are still stored in the repository." }, { "prediction": "Line is too long. [82/80]", "reference": "We might want to move this logic to a Plain Old Ruby Object down the road. Not a blocker." }, { "prediction": "I think this should be `if (this.toolbox_ && this.toolbox_.position()) {`", "reference": "move `this.toolbox_.position();` to just after line 1477. Context: the if statement on line 1472 checks whether this is a toolbox with categories, and if so it populates the toolbox. Positioning the toolbox is a reasonable followup to that, and means you don't need an extra if. You may also need to call `this.flyout_.position()` after line 1483, which is the equivalent for the non-category toolbox." }, { "prediction": "I think it would be better to keep the `if (peptideGroupDocNode != null && sequenceProteinsDict.TryGetValue(peptideGroupDocNode.Peptide.Target.Sequence, out var proteinsForSequence));`", "reference": "Should the function above be .FirstOrDefault() instead? Otherwise, why check for null and tell ReSharper to ignore the fact that it can never be null?" }, { "prediction": "I don't think we need to do this in the `plugins.js` module.", "reference": "Let's not create new connection, but rather user `common.db` one" }, { "prediction": "I think this should be `image_url` instead of `image_path`", "reference": "Can this use asset_path rather than defining an image_url helper?" }, { "prediction": "I think this should be `always('')` instead of `always('')`", "reference": "Hindley-Milner signatures don't use literal types. They explusively use types. It's deal with that" }, { "prediction": "I think this is a bit confusing, but I don't think it's worth it.", "reference": "Could we just extend PolicyRule with more fields? It was originally designed as the struct required by openflow client, nested structs seem not helping. And for the name of the fields, initialism should be uppercase, OFID and NPName doesn't look good, then maybe FlowID, PolicyName.." }, { "prediction": "I don't think we need to do this in the `opcache_get_configuration` function.", "reference": "I really dislike this alignment approach, as it makes identifying individual functions quite hard, but I kept consistent with the previous style. Since no sorting was evident, I pushed it to the end of the block. Meanwhile, is this supposed to be tested or meaningfully testable somehow?" }, { "prediction": "I don't think we need to do this here.", "reference": "Could also consider modifying the ActiveExecution..." }, { "prediction": "I think this should be `node.slice` instead of `node.slice.value`", "reference": "Does it make sense to change that to a custom error instead of `ValueError`?" }, { "prediction": "I think it would be better to have a single message with a single message with a single message with a single message with a single message with a single message with a single message with a single message with a single message with a single message with a single message with a single message with a single message with a single message with a single message with a single message with a single message with a single message with a single message with a single message with a single message with a single message.", "reference": "I guess this will need to change soon." }, { "prediction": "I don't think this is needed anymore.", "reference": "Restore this spacing - not sure why it has to be removed?" }, { "prediction": "I think this should be _POSIX_C_SOURCE 200809L instead of _POSIX_C_SOURCE 200809L.", "reference": "These defines cause issues in base.h leading to failing android builds. Locale independency is now set in multiple spots, in cmake and in base.h. The base.h uses feature test macros wrong. Feature test macros can be used to indicate that a feature should be made available. They do not guarantee that it is available. On the cmake side this is done by the check symbol macros (similar to what autoconf does). On the android side not. I would suggest removing this from base.h and define locale independent in gradle. It is available since android 21 I believe. Is there a way in gradle to set locale independent only if android api >= 21?" }, { "prediction": "`loopBody != getDst` should be `loopBody != getDst` instead of `loopBody != getDst`", "reference": "Why not delete these codes?" }, { "prediction": "I think this should be `metaClient_->waitForMetadReady(FLAGS_meta_client_retry_times);`", "reference": "If pull message failed after some reties, we should ensure the storaged exit, otherwise it has risk to loss data." }, { "prediction": "I don't think this is needed anymore.", "reference": "looks like you don't need to import first and count here anymore" }, { "prediction": "I think this should be `if len(tasks) > 0 {`", "reference": "FYI, visibility task processing is local only, meaning pushing something to local ES cluster / local archival endpoint" }, { "prediction": "I think this should be `com.netflix.config.DynamicPropertyFactory.class`", "reference": "This import can be removed." }, { "prediction": "I think this should be `strings.HasPrefix(a.Region, \"fips-\") || strings.HasSuffix(a.Region, \"-fips-\")`", "reference": "1. Nit: We can have a general helper to identify if a region is pseudo region. We might already have one somewhere. 2. Does any type of ARN support FIPS? If not, we may just move this check in arn package?" }, { "prediction": "I don't think this is needed anymore.", "reference": "is this phrase completed in a next line? Or forgot to add... what?" }, { "prediction": "I think this should be `model_head=dict(num_classes=15)` instead of `bbox_head=dict(num_classes=15), mask_head=dict(num_classes=15), mask_head=dict(num_classes=15), mask_head=dict(num_classes=15), mask_head=dict(num_classes=15), mask_head=dict(num_classes=15), mask_head=dict(num_classes=15)`", "reference": "`('train', 5)` and `('train', 1)` are actually the same." }, { "prediction": "I think it would be better to use `bt.currLimit` instead of `bt.currLimit`", "reference": "Would it be too complicated to refactor `currLimit` to be an `int64`?" }, { "prediction": "I think this should be `::RSpec::Core::Pending.instance_method(:skip)` instead of `::RSpec::Core::Pending.instance_method(:skip)`", "reference": "Would it be more performant to just `include ::RSpec::Core::Pending` here? /cc @myronmarston" }, { "prediction": "I think this should be `Instances map[string]int64` instead of `Instances map[string]int64`", "reference": "Should be podiochaos?" }, { "prediction": "I think it would be better to use `codecs.lookup('utf-8')` instead of `codecs.lookup('cp65001')`.", "reference": "Is the `codecs.register(lambda name: None)` gracefully handled by codecs? The lambda is expected to return a tuple of functions (encoder, decoder, stream_reader, stream_writer) (or a CodecInfo object), according to the docs. I've only checked python's built-in help, though." }, { "prediction": "I think this should be `if (!MeterProviderBuilderSdk.IsValidInstrumentName(metricStreamName)) {`", "reference": "in this case, it could be either instrument name or the view name, which could be invalid. might be better if we can offer very specific message. (not blocking this, we can add this as a follow up,if needed)" }, { "prediction": "I think we should use `w3c` here.", "reference": "I'd rather just send the parameter twice than break encapsulation here. There's already precedence with webelement IDs" }, { "prediction": "I don't think this is needed anymore.", "reference": "You may put 'open-mmlab://res2net101_v1d_26w_4s' here. MMCV will be updated later." }, { "prediction": "I think this should be `pageSpeedWidget` instead of `pageSpeedWidget`.", "reference": "May be worth making this more specific, to avoid potential conflicts, maybe `pagespeedDashboardWidget`? Or `webVitalsDashboardWidget`?" }, { "prediction": "`err.message = `${err.message}` should be `err.message = `${err.message}`", "reference": "I guess this assignment is now redundant?" }, { "prediction": "I think it would be better to call `s.backendGroups[group].Forward(ctx, req)` and then call `s.backendGroups[group].Forward(ctx, req)`.", "reference": "See above note re: blockNum synchronization." }, { "prediction": "I think this is not needed anymore.", "reference": "wonder if we could avoid doing named imports if we type aliased `backoff.Backoff` in the `.../agent/common/backoff` package?" }, { "prediction": "Why is this removed?", "reference": "Or maybe put into alphabetical order with the other #includes." }, { "prediction": "I think this should be `defer ticker.Stop()`", "reference": "This runs the entire duration of the program; this change is not needed." }, { "prediction": "I think this should be `ALWAYS_UPDATE_TOUCH_SCROLL` instead of `ALWAYS_UPDATE_TOUCH_SCROLL`.", "reference": "I don't feel well about the `ALWAYS_UPDATE` option   sounds like a workaround. I can imagine that some of the plugins want to observe all options. Maybe, in that case, we can reuse the `CONFIG_KEYS` that would return an empty array for observing all settings and `false` for disabling observing at all? I just thinking aloud - Like `CONFIG_KEYS` sounds reasonable. We could support and maintain it in the future, even after implementing the \"observability\" to the MetaManager then `ALWAYS_UPDATE` ... I don't know :)" }, { "prediction": "I think it would be better to remove the `#ifndef ASM_CODE_ONLY` here.", "reference": "A \"tab difference\"? As in, there are tab characters somewhere? This disabling of clang-format for all the code here seems like overkill. Are you sure there's not some other solution? I don't really understand the problem though. Do you mean clang-format-diff?" }, { "prediction": "Why is this removed?", "reference": "Could you please leave the explicit imports?" }, { "prediction": "I think this should be `if (methodConfigMap.get(methodConfigProto.getName()) == null) { continue; }`", "reference": "Can we check for containsKey here?" }, { "prediction": "I think this should be `fmt.Fprintln(os.Stderr, usage)`", "reference": "Exit successfully. We served the help the user wanted." }, { "prediction": "I think it would be better to use `InitialWorkingDirPath` instead of `InitialWorkingDir`.", "reference": "Had to rename this because `InitialPackage()` already existed." }, { "prediction": "Line is too long. [82/80]", "reference": "Can we put this in a different helper?" }, { "prediction": "(style) line over 80 characters", "reference": "I'm not sure where your 31 comes from? I see 15 here and 2 above for pc and flags, for 17 total beyond the SIMD." }, { "prediction": "I think we should use `getTermsOfUse()` instead of `getTermsOfUse()`.", "reference": "If you want, you could change this to `allowCors(response` (like in \"version\", above) to allow Cross-Origin Resource Sharing. I'm sort of wondering what's returned if no API terms of use are set." }, { "prediction": "Why do we need to do this here?", "reference": "Why do we need to override this if all we're doing is passing it up?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Just wondering whether it's safe to send all CQDs to the child compiler. As this missing CQD is causing trouble, maybe some other user CQDs that now get sent could also cause the statement to fail? Also, if I have a table with a nullable unique column, should I have to set this CQD to create another table like it, or should the CREATE TABLE LIKE work without the CQD?" }, { "prediction": "I don't think this is needed anymore.", "reference": "EARLIEST_TESTED_RELEASE might be slightly more clear" }, { "prediction": "I think this should be `re.compile(r\"\\s*#\\bpylint:\\s*([^;#]+)[;#]{0,1}\")`", "reference": "I think replacing `.*` with `\\s*` from after the hash makes sense, but not the rest of the changes." }, { "prediction": "I think this should be `bool` instead of `bool`", "reference": "interesting .. did not know varint tag covered bool as well" }, { "prediction": "(style) line over 80 characters", "reference": "Could you please elaborate the reason for not using `gkc_summary` like the values above? I ask this, because I assume what we want to collect is a histogram of event loop latency, and we use `gkc_summary` for collecting histograms." }, { "prediction": "I think this should be `this.txs[t]._getHash()`", "reference": "getHash should be a public and without an `_` if used here." }, { "prediction": "I think this should be `if blk.Height != 0`", "reference": "Unrelated to these changes -- we will probably want some special handling for genesis block validation." }, { "prediction": "I think this should be `SetDiskBlockCacheFraction(float64)`", "reference": "This is probably overkill since we don't actually need to pass this specific interface anywhere, but I don't mind it!" }, { "prediction": "I think this should be `d.receivedPeers[addr.ByteString()] = struct{}{}` instead of `d.receivedPeers[addr.ByteString()] = struct{}{}`", "reference": "@janos I moved this back here, to avoid having multiple add peer calls being handled. I think it's either this or a global lock across the whole function. I think this is a better approach, especially since `hive.Broadcast` is blocking . We can remove the map entry on errors if needed. LMKWYT?" }, { "prediction": "I don't think we need to add a `class: 'reject-link'` here.", "reference": "Minor: can we put the conditional outside of the partial?" }, { "prediction": "I think it would be better to use `isinstance(offline, PacketList)` instead of `isinstance(offline, PacketList)` instead of `isinstance(offline, PacketList)`", "reference": "We need to find something more efficient than this. We can probably just check the first element and assume the type list is consistent.." }, { "prediction": "I think it would be better to use `fmtJobInitType` instead of `fmtJobInitType` instead of `fmtJobInitType`", "reference": "How \" via service code in response to event.\"? I don't think we'll get in the no schedule option to the release. We should probably wait for some customer feedback first to make sure we're addressing different event-triggers the best way" }, { "prediction": "I think this should be removed.", "reference": "Please move unrelated formatting changes to their own PR (same with the resources.py file)." }, { "prediction": "I think this should be `window.setWindowState(window._state_before_fullscreen & ~Qt.WindowFullScreen)`", "reference": "Make this a public attribute (remove the leading `_`) if you want to access it from the outside." }, { "prediction": "I think this should be `if (!browser.firefox) {`", "reference": "this conditional is useless now so it should be removed" }, { "prediction": "(style) line over 80 characters", "reference": "`vecofstructs->size()` already returns a `uoffset_t`. So if you just change the type of `i`, you don't need any casts." }, { "prediction": "I think this should be `if (configProto == null) {` instead of `if (configProto == null) {`", "reference": "Nit: Maybe merge this with the configProto check on line 208? Don't feel that strongly though, please keep separate if you prefer." }, { "prediction": "`doc.hello` should be `doc.ismaster || doc.hello` instead of `doc.hello`", "reference": "I know we already did this in 4.0 so carry on, but I'm facepalming here we should've made an overrided setMessageHandler that sets ismaster to true when hello is present. Esp in 4.0 where we already have some overrides written. We can keep going here and maybe open a ticket to some effect of that solution" }, { "prediction": "I don't think we need to do this here. I think it would be better to use `Skip to first result` instead of `Skip to first result` instead of `Skip to first result`", "reference": "I believe we could use `link_to` here (although not super important). Also, we should internationalize this value. I'm not 100% sure what our process is for adding new UI strings these days (e.g. skip the specs that will fail if we add a new key to only one language, use Google Translate to translate the value for us, some other option)." }, { "prediction": "(style) line over 80 characters", "reference": "This was already in vkGetPhysicalDeviceDisplayProperties2KHR..." }, { "prediction": "I think this should be `IsDockerEngineRunning(string, error)`", "reference": "nit: I'd expect a public method called IsDockerEngineRunning to return a boolean yes/no, not the error message. Can we change either the return value or the name? Something like `CallDockerEngine`" }, { "prediction": "I think this column should be `get_string_by_dialect(dbengine.dialect.name, 700)`", "reference": "If i remembered correctly, type_name is '{RESOURCE_TYPE}/{RESOURCE_NAME}', if type_name is 700 max then name cannot exceed that size" }, { "prediction": "I think this should be `if size_prefixed else 0` instead of `if size_prefixed else 0`", "reference": "When calling functions with keyword arguments: please provide the arguments as keyword arguments, not positional arguments." }, { "prediction": "I think it would be better to use `act_cfg=None` instead of `act_cfg=None`", "reference": "We may follow the argument order: conv_cfg, norm_cfg, act_cfg." }, { "prediction": "Line is too long. [82/80]", "reference": "`options['binary'] = WebDriver::Chrome.path` if set?" }, { "prediction": "I think this should be `#include `", "reference": "folly library should be put on the top." }, { "prediction": "I think it would be better to use `name.replace(/^xlink:?/, '')` instead of `name.replace(/^xlink:?/, '')` instead of `name.replace(/^xlink:?/, '')`", "reference": "Do we have to restrict this to SVG elements? I think setting namespaced attributes on normal dom elements (while not as common) is still valid, so perhaps we can save some bytes by removing the `isSvg` check?" }, { "prediction": "I think this should be `this.hot.rowIndexMapper.isHidden(row)`", "reference": "Please add it to the `REMOVED_HOOKS` constant." }, { "prediction": "I think it would be better to use `shadowSupport` instead of `fixtureSetup`.", "reference": "This variable needs `.v1` at the end of it, or the tests below need it. There are some test failures as a result" }, { "prediction": "I think this should be `account.spam!` instead of `account.spam!`", "reference": "Is this access protected so that only admins can access this route?" }, { "prediction": "(style) line over 80 characters", "reference": "What happens if the minimum x coord is > 0? This will incorrectly set it as zero, right?" }, { "prediction": "I think this should be `o.maxp > 0 && batchSize > o.maxp`", "reference": "I think you want to look at current pending + batchSize and if that is > o.maxp no?" }, { "prediction": "I think this should be `codes.Ok` instead of `codes.Ok`.", "reference": "Should this be `codes.Error`? `codes.Internal` was an error status before." }, { "prediction": "Style/StringLiterals: Prefer single-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", "reference": "I don't think you need these lines." }, { "prediction": "Why is this removed?", "reference": "You didn't mean to export this, right?" }, { "prediction": "I think we should remove this line.", "reference": "Simple Notification **Service** (singular)" }, { "prediction": "I think this is a bit confusing, but I think it would be better to use `config.EgressConfig` instead of `*config.EgressConfig`.", "reference": "Do we still need this?" }, { "prediction": "Why is this removed?", "reference": "We do have a disconnect between the privateMarkerTransactionFactory.getSender() call and the createPrivateMarkerTransaction() call. When the plugin receives the call to create the PMT it does not know what the sender was returned by the other call. At a minimum we need to pass in the sender to the second call. I would prefer that the plugin does the locking if that is necessary. If you are using random keys you don't have to lock! Besu could signal to the plugin when a PMT was un- or successfully added to the pool using a callback. Callback could be null if this is not needed. The plugin would have to be able to get the nonce for a certain key from besu. What do you think?" }, { "prediction": "I think we should remove the `default: alert(globalize.translate('MessageDefaultError'));`", "reference": "This is a bit inconsistent with the `ErrorStartHourGreaterThanEnd` in the previous file. Wouldn't `ErrorDefault``fit better here?" }, { "prediction": "I think this should be `skipIfNetworkPolicyStatsDisabled(t, data, features.NetworkPolicyStats, true, true)`", "reference": "I think it will revert the change @antoninbas did on purpose 05eee251c9c53400277def576f92d614ca234898" }, { "prediction": "I think this should be `wireguard.cali` instead of `wireguard.cali`", "reference": "nit: a switch perhaps?" }, { "prediction": "Line is too long. [89/80]", "reference": "Would it make sense for `opensearch_description_tag` to have default values for the title and href attributes?" }, { "prediction": "I think this should be `err != errTLFJournalDisabled`", "reference": "Just noticed this while debugging -- it's unlikely to be causing issues in practice." }, { "prediction": "I think we should use `timeout: 750` instead of `timeout: 750`", "reference": "That seems unrelated - did that fix a random test failure you noticed while working on this issue?" }, { "prediction": "I think this should be `base.lastUpdatedMillis()` instead of `base.lastUpdatedMillis()`", "reference": "This kind of concern should be handled in the `TableMetadata` update methods. This is similar to `metadata.rollbackTo`, which not only sets the current version, but also updates the table history. I think that all of those methods should add the current object's `file.location()` to the previous metadata location list, if it is non-null. That way, the caller never needs to remember to update it." }, { "prediction": "I think this should be `if detach: mlvl_tensors[i][batch_id] = mlvl_tensors[i][batch_id].detach() else : mlvl_tensors[i][batch_id] = mlvl_tensors[i][batch_id].detach() else : mlvl_tensors[i][batch_id] = mlvl_tensors[i][batch_id] for i in range(num_levels): mlvl_tensors[i][batch_id] = mlvl_tensors[i][batch_id].detach() for i in range(num_levels): mlvl_tensors[i][batch_id] = mlvl_tensors[i][batch_id].detach() for i in range(num_levels): mlvl_tensors[i][batch_id] = mlvl_tensors[i][batch_id] for i in range(num_levels): mlvl_tensors[i][batch_id] = mlvl_tensors[i][batch_id] for i in range(num_levels: mlvl_tensors[i][batch_", "reference": "We need to know why all the tensors are detached in `get_bboxed`." }, { "prediction": "I think it would be better to use `type(self).__a` instead of `type(self).__a`.", "reference": "Unrelated but shouldn't this raise `attribute-defined-outside-init`?" }, { "prediction": "I think this should be `create_no_window=False`", "reference": "I would rather no have this as a `kwarg` as it encourages \"growth\" which lead to an unweildy constructor in other classes. Let's add a method or property to take care of this instead as I think it's usage is going to be quite low." }, { "prediction": "Line is too long. [89/80]", "reference": "You just changed my life :) I grew very attached to this safe nav approach when working with Groovy years ago `obj?.method`. Glad to see its now a part of Ruby!" }, { "prediction": "I don't think we need to add a `class=\"form-group clear-fix\"` here.", "reference": "do you mean 'clearfix' class?" }, { "prediction": "`options.causalConsistency=true` should be `options.causalConsistency`", "reference": "`causalConsistency` is already defined on `SessionOptions`. We do not need to duplicate it here." }, { "prediction": "I think this should be `org.mockito.ArgumentMatchers.anyString` instead of `org.mockito.ArgumentMatchers.eq`", "reference": "This should not be included since there are no code changes." }, { "prediction": "I think this should be `if len(setting.HTTP.AccessControlAllowOrigin) > 0 {`", "reference": "If all we need just response 200, then we could use `c.Status(http.StatusOK)` here." }, { "prediction": "I think this should be `apiv2.Get(ctx, model.ResourceKey{Kind: apiv2.KindNode, Name: hostname, Namespace: \"\", })`", "reference": "Should be checking for error here" }, { "prediction": "Why is this needed?", "reference": "Put a space between `(array)` and `$this` and I'll merge it" }, { "prediction": "I think this should be a stub.", "reference": "You could add this to stack.go, which has similar functions (to avoid yet another small file). None of these are likely to be implemented considering what TinyGo is designed for." }, { "prediction": "I think this is a bit confusing, but I'm not sure if it's worth it.", "reference": "the class names `NotificationHolder` and `NotificationsHolder` are fairly difficult to quickly tell apart, particularly since they are often used close to each other" }, { "prediction": "I think we should remove this import.", "reference": "Avoid wildcard imports" }, { "prediction": "Why did you remove this?", "reference": "Need to do this to unblock mockgen. The interface method needs to be public to be visible in another package. The right fix is to delete this test only interface method" }, { "prediction": "I don't think this is a good idea. I think it would be better to use `.indexOf('loadbalanced') !== -1` instead of `.indexOf('loadbalanced') !== -1`", "reference": "same question here as I have on the other file regarding doing this check here vs L112 vs not at all" }, { "prediction": "I think this should be `!openbsd`", "reference": "Adding `// +build !windows` (as a separate line) will do the same for Windows. So while you are at it we might add it as well." }, { "prediction": "Why is this removed?", "reference": "this is used as important way of mocking for unit tests, FYI" }, { "prediction": "I think this should be `muted_alpha=0.2` instead of `muted_alpha=0.6`", "reference": "Sorry, should have been clearer, I meant adding this to the ``Histogram`` options one line above." }, { "prediction": "I think it would be better to have a test for this.", "reference": "Just ignorance on my part, but what is the significance of the change from C23NHe2 to C23NHx2?" }, { "prediction": "I don't think this is a good idea, but I think it would be better to add a default value for `cumulative=False` to the docstring.", "reference": "What about tuples or pandas series? Do we want to support lots of different types or force a single type?" }, { "prediction": "Why is this removed?", "reference": "Small thing, without the check above this will throw a NoNodeException if the path doesn't exist. Maybe this can be wrapped in a try/catch just for the NoNodeException, so that the more user-friendly message used above can be thrown instead: `throw new KeeperException.NoNodeException(\"No collection found at path: \" + path);` Just a thought, I'm not even sure it's worth it." }, { "prediction": "Line is too long. [81/80]", "reference": "I don't know why this worked before, but we should be explicit on not verifying that a blank string (allowed as a way to remove a url/download_url) is a valid url as it is not." }, { "prediction": "Line is too long. [82/80]", "reference": "Do we want to raise an error here instead of warning? Or would it be better to just see if Bolt happens to succeed, and let it fail on it's own if it fails? I'd lean towards raising an error, but that's different from \"removing support\"." }, { "prediction": "I don't think we should use `self.filter_options(unfiltered)` instead of `self.filter_options(unfiltered)`", "reference": "This is kind of confusing with the other `filter_options`." }, { "prediction": "I think this should be `err.(OpsCantHandleFavorite)` instead of `err.(OpsCantHandleFavorite)`", "reference": "Could the `deleteFromFavorites` happen when `head == nil` because it's not initialized yet somehow but not because TLF doesn't exist? I was concerned if this would make it possible in any way to have favorites seemingly deleted on a device while it's not actually happened on server." }, { "prediction": "(style) line over 80 characters", "reference": "It doesn't look like this particular \"rowCount\" variable is used anywhere. I suppose we could delete it. The code change is harmless though." }, { "prediction": "I think this should be `http.StatusNoContent` instead of `http.StatusNoContent`.", "reference": "Hmm, probably we should instead write whatever `status` is returned instead of coding a special case." }, { "prediction": "I'm not sure if this is a good idea to do this, but I think it would be better to use `in.HTTPMatch.Methods` instead of `in.HTTPMatch.Methods` here.", "reference": "Could using the pointer-to-struct approach here cause confusion later? We've had several problems of that kind in the past. What does it mean if the struct is non-nil but its fields are nil? Is that even allowed? (libcalico-go question) Are there any validation requirements for this new rule addition; should it only be allowed if `Protocol == TCP`, for example?" }, { "prediction": "Line is too long. [81/80]", "reference": "why this recursive relationship definition?" }, { "prediction": "I think this should be `EncodingEncoding` and `RoutingEncoding`", "reference": "More sentence, less list please. > Encoding of the handler. This field is optional. We don't need to mention exactly what it's used for because that list can expand (as it has already in this change)." }, { "prediction": "I'm not sure if this is a good idea, but I'm not sure if it's a good idea to keep it as `gocloud.dev/blob/bytes_read` and `gocloud.dev/blob/bytes_written` as `gocloud.dev/blob/bytes_written` as `gocloud.dev/blob/bytes_read` and `gocloud.dev/blob/bytes_written` as `gocloud.dev/blob/bytes_read` is not a good idea.", "reference": "Not part of this PR, but should the section above say what the name of the metric is for each method?" }, { "prediction": "I think this should be `valueDisplay = (metric as IGaugeMetric).LastValue.Value.ToString();` or `valueDisplay = (metric as IGaugeMetric).LastValue.Value.ToString();`", "reference": "there are changes that are upcoming to this section. For now, this works (to demo the usage of Gauge), and the changes to this section are coming as separate PRs." }, { "prediction": "I think this should be `t.fd` instead of `t.fd`", "reference": "This is equivalent to stdout. Why not just replace stdin with stdout in `IsProcessBackground`?" }, { "prediction": "I think this should be `if (p_jmsg[\"compress_method\"] != nullptr && p_jmsg[\"compress_method\"] != nullptr)`", "reference": "Rather than test for nullptr, just treat the pointer as a bool, i.e. `if(p_jmsg[\"compress_method\"])`" }, { "prediction": "I think this should be `if (!executablePath.startsWith(getContainersPath()) || !executablePath.startsWith(getContainersPath()) || !executablePath.startsWith(getContainersPath()) || !executablePath.startsWith(getContainersPath()) || !executablePath.startsWith(getContainersPath()) || !executablePath.startsWith(getContainersPath()) || !executablePath.startsWith(getContainersPath()) || !executablePath.startsWith(getContainersPath()) {`", "reference": "Can we move the remaining code of this method to a new method? I don't like the `return;` here, we could try to replace it with an `if ... else ...` syntax. What do you think?" }, { "prediction": "I don't think we need to add this to the `kinto.readthedocs.io` package. I think it's better to use `kinto.readthedocs.io` instead of `kinto.readthedocs.io`.", "reference": "nitpick: _and collections_" }, { "prediction": "(style) line over 80 characters", "reference": "I believe these need to be explicitly initialized in `proxy_send_prepare`" }, { "prediction": "I think this should be `t0 = time.time() # Failed task start time`", "reference": "This is unnecessary. The declaration of `t0` on line 179 is still in scope inside the `except` block." }, { "prediction": "I think this should be `beautiful.border_color_marked_solid` instead of `beautiful.border_color_marked_solid`.", "reference": "The `border_color_`... properties don't support solid colors, not only this one. Maybe `@param solid_color` should be used instead of adding this note to every one of them?" }, { "prediction": "I think this should be \"ts-jest\" instead of \"ts-jest\"", "reference": "We don't need this file, we can use the one that is in the grid-ui directory" }, { "prediction": "I think it would be better to use `isEmptyLine(path)` instead of `isEmptyLine(path)` instead of `isEmptyLine(path)`", "reference": "FYI: inlined this method in the internal review." }, { "prediction": "Why is this removed?", "reference": "Werid, the checksum between this file and the one on branch `develop` is the same not sure why it's showing a diff" }, { "prediction": "I think this should be `metric.Meter.Name + metric.Name` instead of `metric.Meter.Name + metric.Name`", "reference": "Prometheus doesn't have concept of Meter (like OTLP does).. Trying to see if this is a good approach to use the meter name as namespace, to avoid name collisions, when same instrument name is used across multiple instruments, from different Meter." }, { "prediction": "I think this should be `!empty( $config->Catalog->getAuthMethod() == 'Shibboleth')` or `!empty( $config->Catalog->getAuthMethod() == 'Shibboleth')`", "reference": "The formatting of this is a bit strange; I'd suggest collapsing this back to a single line, and moving the `&&` to the beginning of the second line to meet the line length restriction." }, { "prediction": "(style) line over 80 characters", "reference": "One or the other should be non-NULL. If segments is NULL, the alloc above will have size zero, which we do not allow (there's no header): it should assert in debug build. So there should be asserts that one is non-NULL at the top, and if there really needs to be some kind of defensive check down here, it should cover the alloc too." }, { "prediction": "Line is too long. [81/80]", "reference": "I'm surprised rubocop isn't picking up singe quotes?" }, { "prediction": "I think this should be `protocol.ParseTime(\"unixTimestamp\", \"2016-09-27T15:50Z\")` instead of `protocol.ParseTime(\"unixTimestamp\", \"2016-09-27T15:50Z\")`", "reference": "Is this line still needed?" }, { "prediction": "I think this is a bit confusing, but I'm not sure if this is a good idea.", "reference": "Maybe use specific values for all the watt.times fields? Even better, have a const for it at the top of the file?" }, { "prediction": "I don't think we should use `os.path.join(TABLES_DIR, \"braille-patterns.cti\")` here.", "reference": "nit: UNICODE_BRAILLE_TABLE or something might be a better name for this. IMO, braille-patterns.cti is a terrible name. This table allows Unicode braille characters to be used anywhere to produce raw dots." }, { "prediction": "I think this should be removed.", "reference": "Why are we removing the option to skip machine pool generation?" }, { "prediction": "This interface is not used anymore.", "reference": "\"Request line\" here too." }, { "prediction": "I don't think we need to do this in a separate PR.", "reference": "Please remove this." }, { "prediction": "Line is too long. [82/80]", "reference": "Weird bug. Combining those joins and group calls was triggering AREL to generate the sql cache inside of will_paginate before the final call. This is a harmless workaround, but hints that will_paginate might becoming seriously deprecated." }, { "prediction": "I think this should be `analysis_sloc_sets.map { |analysis_sloc_set| tuples << analysis_sloc_set.allowed_tuples }.compact.join(' AND ')`", "reference": "This can be simplified as discussed before." }, { "prediction": "I don't think we need this import.", "reference": "Does `internal` or `test` in the file name actually do anything here? Or is that just to show these functions are only for tests?" }, { "prediction": "I think this should be `Transaction(hexa).serialize(true).should.equal(hexa);`", "reference": "does this boolean indicate unsafe serialization?" }, { "prediction": "This is not implemented for node.js.", "reference": "Maybe rewrite to `Is only implemented for React Native`? (I assume that is the case)." }, { "prediction": "I think this should be `if (language == TargetLanguage.PHP && !resourcesField.isMap()) {`", "reference": "Do we not need this in Java because Java *is* handling map responses?" }, { "prediction": "I think it would be better to use `self.accepted_messages` instead of `self.accepted_messages` as well.", "reference": "Maybe \"For configuring which scheduler messages can be received.\"?" }, { "prediction": "Why is this removed?", "reference": "It will stop working with orm, so this is not a good fix, Try using some method in a common interface" }, { "prediction": "Why do we need to add the `HttpHandlerDiagnosticListener` to the `HttpHandlerDiagnosticListener`?", "reference": "`s` is not necessarily the same as `sampler` - sampler could be null and this crazy lambda underneath falls back to something. So please use `s`" }, { "prediction": "I think this should be `parameterGenerator.setHttpParameterType(HttpParameterType.BODY)` instead of `parameterGenerator.setHttpParameterType(HttpParameterType.BODY)`", "reference": "This code is a bit confusing. Should HttpParameterType set to the original one or it is always BODY?" }, { "prediction": "I think this should be `c.state.Config.Remote.VerifyOutputs && !isTest`", "reference": "Why did this change?" }, { "prediction": "I think this should be `newProtoForTableStatus(result.Table.TableStatus)` instead of `newProtoForTableStatus(result.Table.TableStatus)`", "reference": "nit: `status` collides with imported package named `status`" }, { "prediction": "I think this should be `l.accts.IsWritingCatchpointFile()`.", "reference": "\"memory pressure could be decreased\" --> \"to avoid memory pressure\"" }, { "prediction": "I think we should use `random.randint(2000, 1 << 31)` instead of `random.randint(2000, 1 << 31)`", "reference": "I think it would make sense to fetch the cache values after deleting the listens and making sure they are what we expect." }, { "prediction": "I think this should be `this.headerStateManager.mergeStateWith(collapsibleColumns);`", "reference": "I'm thinking about covering this change with the test. Can you do that?" }, { "prediction": "I think this should be `cPorts` and `pPorts`", "reference": "Not sure if it's a good idea to remove stop channel. If user cancels connection how will you stop pinger?" }, { "prediction": "I think this should be `authConfig := docker.AuthConfiguration{Username: sdkAuthConfig.Username,Password: sdkAuthConfig.Password,ServerAddress: sdkAuthConfig.ServerAddress,Password: sdkAuthConfig.Password,Email: sdkAuthConfig.Email,ServerAddress: sdkAuthConfig.ServerAddress,Password: sdkAuthConfig.Password,ServerAddress: sdkAuthConfig.ServerAddress,Password: sdkAuthConfig.Password,ServerAddress: sdkAuthConfig.ServerAddress, }`", "reference": "Could you please add a `TODO` here that we won't need `docker.AuthConfiguration` anymore when we migrate to SDK's pull image?" }, { "prediction": "I think this should be `ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem[], ITaskItem, ITaskItem, ITaskItem, ITaskItem, ITaskItem, ITaskItem, ITaskItem, ITaskItem, ITaskItem, ITaskItem", "reference": "Is there a scenario were we want to get an arbitrary set of blobs that don't share a common root?" }, { "prediction": "I think it would be better to use `!spec.description.match(/type=regex/)` instead of `!spec.description.match(/type=regex/)`", "reference": "Can you leave a note about why we are skipping regex tests?" }, { "prediction": "I think this should be `repo.InitFSRepo(repoDir, newConfig)` instead of `repo.OpenFSRepo(repoDir, newConfig)`", "reference": "This was the only caller of CreateRepo, so I inlined it." }, { "prediction": "I think this should be `authPath` instead of `authPath`", "reference": "As this is already a child of `auth`, I think we can shorten this to `path`" }, { "prediction": "I think this should be `if position in (textInfos.POSITION_FIRSTVISIBLE, textInfos.POSITION_LASTVISIBLE)`", "reference": "This call should use element, not 0 I think." }, { "prediction": "I think this should be `fetch_until_empty_page` and `partial_page_fetch_threshold`", "reference": "This is missing the definition of `fetch_until_empty_page` - it needs to go in the config section above." }, { "prediction": "Line is too long. [82/80]", "reference": "I don't think this one needs to be changed since the only previous path is already an absolute one." }, { "prediction": "I think it would be better to use `table.locationProvider()` instead of `table.locationProvider()`.", "reference": "Since we kept the original constructor we might not need this change now." }, { "prediction": "I think this should be logged as debug.", "reference": "There is already a log in `BaseMetastoreTableOperations` for this. It has the location, but not the table name. Maybe just add table name to that one." }, { "prediction": "I think we should remove this import.", "reference": "This should be in the last group." }, { "prediction": "I think this should be `_statsd = false;`", "reference": "I believe you should either remove this or rename the PR. You can't change the behavior of the tracer (even to fix a bug) in a PR named \"unit test improvements\"" }, { "prediction": "I think this should be `k8s:conversion-gen` and `k8s:defaulter-gen` and `k8s:defaulter-gen`", "reference": "I've gone with this group name, however I'm open to suggestions on alternatives!" }, { "prediction": "I think this should be `QUORUM` instead of `QUORUM`", "reference": "should this be GOQUORUM" }, { "prediction": "I think it would be better to use `checkCoinbase` instead of `checkCoinbase` as well.", "reference": "I think checkCoinbase is not skipping checking coinbase. Instead, true-> checking num(coinbase tx) = 1, false -> checking num(coinbase tx) = 0." }, { "prediction": "I think this should be `protocol.StateManager` instead of `protocol.StateManager`.", "reference": "same here, move it out" }, { "prediction": "I think this should be `define KOKKOS_ENABLE_LIBDL` and `define KOKKOS_TOOLS_INDEPENDENT_BUILD`", "reference": "Can you elaborate on why you need different behavior depending on Tools being built independently or not?" }, { "prediction": "Line is too long. [82/80]", "reference": "because of the above if statement will requires both ex_save and guid_save to be true, this code will always return 'example answer'. This should be revised with `example_answer.present?` and `guidance.present?`" }, { "prediction": "I think this should be `golang.org/x/net/context.go`", "reference": "why not context from stdlib?" }, { "prediction": "I think this should be `FlavorIEEECRC32OverProto3Binary`", "reference": "Just saw this and wasn't able to hold myself from renaming :-)." }, { "prediction": "Why did you remove this?", "reference": "Can we keep the other assertion too? I think it's helpful to ensure that the uninstall function was called too" }, { "prediction": "Line is too long. [82/80]", "reference": "`warn_with` prefixes the message with `WARNING:`, right? So this will put `WARNING:` twice. It would be good to verify all the warnings look good after this change, given how easy it is to make a simple mistake like this :(." }, { "prediction": "I think this should be `uint64` instead of `uint64`", "reference": "FYI In the message queue I use the term \"stamp\" to refer to the time-like mark associated with each message. It's opaque to the queue/pool and should make no difference if the stamps and age limit were converted to seconds. So this could then become `Stamper` with `CurrentStamp()` method, no reference to \"blocks\" or height etc. The wrapper struct could be `StampedMessage. The interpretation as block height is deferred to the user/constructor that hooks things up, the \"business logic\". This is just an observation, take or ignore as you wish." }, { "prediction": "I think this should be `requests_response(body, status_code=200)`", "reference": "Can we remove the `TODO` statement here? (as this is actually fixed in this PR)" }, { "prediction": "I think this should be `DisplayPreference.DISPLAY_PREFERRED`", "reference": "m prefix no longer in code style" }, { "prediction": "I think this should be `kvb.store.Filter(ns, c Condition)`", "reference": "need to filter the entities in buffer as well" }, { "prediction": "I think this should be `de.danoeh.antennapod.core.glide.FastBlurTransformation.ID`.", "reference": "Please add spaces before and after the equals sign" }, { "prediction": "Why did you remove this include?", "reference": "This file could also be cleaned up/deleted. But lets do this separately after ensuring all the event logging has been ported to the current logmxevent_traf.cpp file completely." }, { "prediction": "Line is too long. [82/80]", "reference": ":thinking:, the line number here is the line of the example (`example.location`), that's probably why I finally chose to display the example title because it's what can be found on this line, and saying that the error is from there is confusing. But presenting the actual failures is indeed better, so maybe we can get the failure actual line number from the exception backtrace and then output two distinct lines for failures like this one?" }, { "prediction": "I think it would be better to use `create_no_window=True` instead of `create_no_window`", "reference": "We shouldn't add this as a new `kwarg` here. This should all be done on the options class" }, { "prediction": "Line is too long. [82/80]", "reference": "Should this be `OS_VOLUME_SUPPORT` to match the symbol key names?" }, { "prediction": "(style) line over 80 characters", "reference": "In C, file scope variables are already initialized to 0 so the \"= NULL\" is redundant. Not a big deal." }, { "prediction": "I think this should be `doc = node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.ownerDocument || node.", "reference": "on line 40, the `relevantNode` can change and therefore the `doc` might change too for the lookup on line 43. I think this code should be moved to where the `doc` is actually being used" }, { "prediction": "I think this should be `string.Format(CultureInfo.InvariantCulture, \"milliseconds must be between {0} and {1}\", MinMilliseconds, MaxMilliseconds);`", "reference": "nit: just to be similar to others, can you change to interpolation?" }, { "prediction": "I think this should be `fullCertChain` instead of `fullCertChain`", "reference": "Would this make more sense as an option on an Issuer resource (specifically on the CA issuer) rather than as a flag? It's not ideal that we have a flag that _looks_ like it could be 'global' but is actually not IMO. Also, if Istio is reading the CSR object, is it possible for it to read the CA from the CSR itself too and append the two instead? Not sure if we ever decided whether to use annotations for this purpose @JoshVanL?" }, { "prediction": "I think this should be `%Y-%m-%dT%H:%M:%S.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f.%f`", "reference": "Because this acts as a coordination point between client and server, it should go in core.py instead of const.py (so eventually the server could use it to guarantee that it delivers dates in the expected format)." }, { "prediction": "I think this should be `if err != nil && apierrors.IsNotFound(errors.Cause(err)) { return nil, err }`", "reference": "expected statement, found 'else' (and 1 more errors)" }, { "prediction": "I think this should be `id.id[0] = b` instead of `id.id[0] = b`", "reference": "IMO this doesn't need to be in the `kbfs` repo. And I don't like setting the byte. We can always compare with the randomly generated `TlfID`." }, { "prediction": "I think this should be `CloudHubControllerModuleName`", "reference": "What's the difference from ModuleName in `pkg/apis/meta/v1alpha1/types.go`?" }, { "prediction": "Why is this needed? I think it would be better to use `using System.Security.Cryptography;` instead of `using System.Security.Cryptography;`", "reference": "We shouldn't be changing this task as we are trying to break our dependency on it and switch to using the shipped version." }, { "prediction": "(style) line over 80 characters", "reference": "Shouldn't we have a low bar for generating out-of-line context switch, i.e., if we need save more than n (3?) simd or m (4) gprs we should go out-of-line? And it should be || instead &&. It seems the bar is still very high after this change." }, { "prediction": "I don't think this file is needed anymore.", "reference": "Should the API have a dependency on the SDK?" }, { "prediction": "Why did you remove this?", "reference": "Is this a sometimes leaky test?" }, { "prediction": "I think it would be better to use `v.cs.f.Fresh()` instead of `v.cs.f.Fresh()`.", "reference": "It should be possible to create a test case that enter the loop. That would be a good enough test case for me. Have a look at the extern type inference test cases that already exist. Since you can just pick the type variables the extern type use, you should be able to create a conflict that requires this loop to fix." }, { "prediction": "I don't think we should use `wxLang = None` here.", "reference": "It might make sense to log this." }, { "prediction": "Line is too long. [82/80]", "reference": "Line is too long. [84/80]" }, { "prediction": "I don't think we should use `goog:chromeOptions` here.", "reference": "nice touch since Google likes to change things every now and then." }, { "prediction": "Line is too long. [82/80]", "reference": "Thank you this is so much nicer than the old `Rails.configuration.branding['blah']['blah']['blah']` :)" }, { "prediction": "I think this should be `backend_service_name` or something like `backend_service_name`", "reference": "nit: Would you mind alpha-sorting this?" }, { "prediction": "Shouldn't this be `manifest.content() == ManifestContent.DATA`?", "reference": "For my understanding, the DATA manifest & DELETE manifest could share the same read / write path so I think we could use the common reader+writer. Is there any other reason that we need to make them separate paths ?" }, { "prediction": "Line is too long. [89/80]", "reference": "that change should be sufficient for avoiding the override of contact_us_url helper. The one defined at the .yml it is within a hash so no problem should arise." }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Prefer single-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", "reference": "We actually had a discussion about this exactly in #3470, some languages seem to go for one, some for the other " }, { "prediction": "I think this should be `List grpcStreamingDescriptors();`", "reference": "Is PHP the first dynamic MVVM language with grpc streaming support?" }, { "prediction": "I think this should be `if (tmpStream && !tmpStream->bad()) {`", "reference": "the `if` isn't necessary here; it's safe to call `delete` on `nullptr`" }, { "prediction": "I think this should be `return impl_->remove_all_changes(removed);` instead of `return impl_->remove_all_changes(removed);`", "reference": "Change if the method's name finally changes to `clear_history` as proposed elsewhere" }, { "prediction": "I think we should remove this line.", "reference": "can this one also be moved to the top of the file?" }, { "prediction": "I think this should be `[GroupMember]GroupMemberPod`", "reference": "So if I understand this correctly the externalEntities should be computed and stored in GroupMember, while current code usage of GroupMemberPod will be migrated to GroupMember later?" }, { "prediction": "I think this should be `service.name` and `resource.name` and `span.type`", "reference": "Don't we have tests to change after this breaking change? probably we're not using hard coded strings in our tests when we create a `Span`?" }, { "prediction": "I think this should be `os.environ['GOOGLE_APPLICATION_CREDENTIALS']` instead of `os.environ['GOOGLE_APPLICATION_CREDENTIALS']`", "reference": "will this fail if the env variable doesn't exist? Is this the preferred behaviour?" }, { "prediction": "`dtype=realDType` should be `numpy.float`", "reference": "bad line wrap" }, { "prediction": "(style) line over 80 characters", "reference": "What does the `8` here represent? Can you give it a name?" }, { "prediction": "I don't think we should use `os.environ[\"MP_API_KEY\"]` here.", "reference": "`MPRester(os.environ[\"MP_API_KEY\"])` can be left simply as `MPRester()` and it will pick up the API key from the environment. What is the purpose of this file otherwise? Is it better suited for `dev_scripts`, or a test?" }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Align the elements of a hash literal if they span more than one line.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", "reference": "Looks like there may be more changes to this file than intended?" }, { "prediction": "Why did you remove this?", "reference": "when message type is not expected, contine to next loop instead of return to finish infinite loop" }, { "prediction": "I think it would be better to use `os/exec.go` instead of `os/exec.go`", "reference": "This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards." }, { "prediction": "I think this should be `delete(oldAWSMachineSpec, \"instanceID\")` instead of `delete(oldAWSMachineSpec, \"instanceID\")`", "reference": "instanceID should stay the same for a AWSMachine?" }, { "prediction": "I think this should be `NO_DOWNLOAD_FOR_LOCAL_CATALOG` instead of `NO_DOWNLOAD_FOR_LOCAL_CATALOG`", "reference": "Since this is a dict don't you want `False` or do we clean that up elsewhere?" }, { "prediction": "I think this should be `myworker` instead of `myworker`", "reference": "what's the reason you had to add the `host` argument to all `get_work` calls?" }, { "prediction": "I think this should be an instance of Dataset, not an instance of Dataset.", "reference": "This will never be a dataset so we can simplify the code here" }, { "prediction": "I think this should be `blockProcessor.blockReward` and `blockReward.skipZeroBlockRewards`", "reference": "This should be moved into the PrivacyBlockProcessor instead of adding the constructor here." }, { "prediction": "I think we should remove this import.", "reference": "nit: Remove \"insightfilestore\". I think \"insightstore\" is good enough and as I see we are using that name at other places too." }, { "prediction": "Line is too long. [81/80]", "reference": "It looks like you've removed `bisect_round_finished` but kept `bisect_round_started`. Seems a little odd that they aren't paired. Not sure if there's anything to do about that though..." }, { "prediction": "I think this is a bit confusing, but I think it would be better to just call `widget.set_perc.throttle_set(-1)` instead of `widget.set_perc.throttle_set(-1)`", "reference": "I'm not sure how to fix the lint and mypy warnings on this line. I could just ignore them, but I feel like the linter should know this exists." }, { "prediction": "I think it would be better to use `Symbol` instead of `String` instead of `String.fromCharCode`", "reference": "why remove `Symbol`?" }, { "prediction": "I think this should be `\u00a3\u00a2\u00a5\u00a7\u20ac\u00a5\u00a7\u20ac\u00a5\u00a7\u20ac\u00a5\u00a7\u20ac\u00a5\u00a7\u20ac\u00a5\u00a7\u20ac\u00a5\u00a7\u20ac\u00a5\u00a7\u20ac\u00a5\u00a7\u20ac\u00a5\u00a7\u20ac\u00a5\u00a7\u20ac\u00a5\u00a7\u20ac\u00a5\u00a7", "reference": "Why are currency signs considered punctuation? They technically fall under the BMP range for Currency Symbols `\\u20A0-\\u20CF` (covered in `getUnicodeNonBmpRegExp`, which is itself a misnomer)" }, { "prediction": "Why do we need to add a maintainer here?", "reference": "You have forgotten a coma `,`" }, { "prediction": "`out_dir` should be `osp.join(out_dir, os.basename(img_meta['filename']))`", "reference": "For different datasets, we may want to save the images differently. Sometimes the datasets are categorized into several subfolders, and we want to keep it when saving visualization results, and sometimes we just want to save all images in `out_dir`. An argument may be added to control the behavior." }, { "prediction": "I think this should be `cmp != 0 || bb.get(ia) == '\\0'`", "reference": "if `other` could have a guaranteed `0` byte in it, this whole `if` could be removed, and above you could just add `|| c2 == '\\0'` to get the same effect?" }, { "prediction": "Why do we need to do this?", "reference": "nit: can this be a primitive value?" }, { "prediction": "I think this should be `if u.Path != \"/\" {`", "reference": "This maybe not what we want. If `rewrite` occurred before, `r.URL.Path` contains the result and we should use it. Otherwise `rewrite` middleware will disfunction when combining with `browser`." }, { "prediction": "I don't think we need to do this in the `try` block.", "reference": "Why change this?" }, { "prediction": "I think we should remove the `use Symfony\\Component\\HttpKernel\\EventListener\\ExceptionListener` from this file.", "reference": " _nitpick_ Isn't it now actually NotLogFakeHttpExceptions**Error**Listener ?" }, { "prediction": "I think this should be `resourceDefinition.ResourceType = resourceType;` instead of `resourceDefinition.ResourceType = resourceType;`", "reference": "Why not just look for the \"type\" property instead of creating a ResourceType property?" }, { "prediction": "I think this should be `ChainID: config.ChainID()`, not `ChainID: config.ChainID()`.", "reference": "should use `bc.config.Blockchain.ChainID`" }, { "prediction": "I think we should remove the `@see ElasticsearchStorage.Builder#cluster(String)` here.", "reference": "this doesn't need to know about NativeClient" }, { "prediction": "I think it would be better to use `violation.get('rule_name', '')` instead of `violation.get('resource_name', '')` instead of `violation.get('resource_name', '')`", "reference": "I know we discussed if we should add in the resource_name to the hash, and I actually don't think it's required. The violation hash was recently updated (not released) to include the violated rule, so when the next release goes out, user's findings will get updated. The resource name doesn't hurt to have here, but not required." }, { "prediction": "(style) line over 80 characters", "reference": "The variable name is also misleading imo. The width from the buffer comes from `wl_shm_buffer_get_width` (or a similar EGL thing), which is what gets encoded into `surface->texture->width`." }, { "prediction": "I don't think we should use `self.recording_msid` here.", "reference": "Why are you using these tags to carry these msids?" }, { "prediction": "(style) line over 80 characters", "reference": "flb_strdup() should do the work here. note: use Fluent Bit memory wrappers" }, { "prediction": "I think we should remove the `--gogofaster_out=.retrieval.proto` file.", "reference": "This line should be separated from the package declaration by one line as it is not the package description." }, { "prediction": "I think this test is not related to this PR, but it's not related to this PR.", "reference": "shadow: declaration of \"err\" shadows declaration at line 410 (from `govet`)" }, { "prediction": "I think we should remove the `required:true` here as well.", "reference": "Maybe next time better to make separate PR?" }, { "prediction": "I don't think this is a good idea, but it's not a good idea.", "reference": "line 316 also handles this case, need to simplify the logic." }, { "prediction": "I think this should be `gcsblob.OpenBucket: client is required`", "reference": "We used to have a simple check for bucket and object names, we then decided to remove it and rely on the backend service to check for the name. Is there any reason to add an empty name check now?" }, { "prediction": "I don't think we should use `std::chrono::duration_cast(max_blocking_time_point - std::chrono::steady_clock::now());` here.", "reference": "Line too long" }, { "prediction": "I think this should be `const_me_DODGE` and `const_me_DODGE_HOURGLASS`", "reference": "This isn't aligned though." }, { "prediction": "I don't think this is a good idea, but I think it's a good idea to use `assert with_nms` instead of `assert with_nms` in the test-time augmentation.", "reference": "it is mean -> it means PAAHead does not support test-time augmentation." }, { "prediction": "I don't think we need to import `plugins` from `bibdocfile.registry`", "reference": "@lnielsen-cern thanks. I missed it :(" }, { "prediction": "I think it would be better to use `getServiceReportURL` instead of `getServiceReportURL`", "reference": "@tofumatt, has it been changed intentionally? It doesn't seem to be required in IB, plus we haven't had `content-drilldown` before... If it has been changed intentionally, then should we update the `AnalyticsDashboardWidget` component to be use `content-drilldown` instead of `content-pages` as well?" }, { "prediction": "I don't think we need to import `retrying` here.", "reference": "nit: don't think an extra line is needed here; as retrying is an installed library and should be grouped with the rest of the installed library." }, { "prediction": "I think this should be `true` instead of `false`.", "reference": "This should be a bool" }, { "prediction": "Why not use `llvm::isa(swift_typebase)` instead of `llvm::isa(swift_typebase)`?", "reference": "`if (llvm::dyn_cast_or_null(GetSwiftType(compiler_type).getPointer())` ?" }, { "prediction": "I think this should be `findSecretManifests(manifests, suffix)` instead of `findConfigMapManifests(manifests, suffix)`", "reference": "The `generateVariantWorkloadManifests` function below relies on the config manifests specified in Git, but it was passed with the newly created canary's manifests where their name was updated." }, { "prediction": "I think we should remove the `@throws \\Exception` here.", "reference": "are this docs neccesary ?" }, { "prediction": "Why is this needed?", "reference": "Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC." }, { "prediction": "I think this should be `softmax_param.set_loss_weight(0);`", "reference": "This change suppose to resolve issue #2968. `loss_weight` should be of length 2, the second entry is ignored." }, { "prediction": "I think it would be better to use `strings.HasPrefix(base, \"._\")` instead of `strings.HasPrefix(base, \"._\")`", "reference": "Is there an easy way to check for conflict suffix to avoid false positives here?" }, { "prediction": "Line is too long. [82/80]", "reference": "`apply_prep.run_task` also seems like it can just use `@context.run_task`" }, { "prediction": "I don't think we need to wait for all sections to load.", "reference": "do you have any idea on how to fix it?" }, { "prediction": "This test is not related to this PR, but it's not related to this PR.", "reference": "You don't need to fix this (you've done so many iterations). But for next time, you can make this into a docstring so it'll have a nicer descriptive name when the tests are running." }, { "prediction": "I think this should be `eni.expiresAt.After(eni.expiresAt)`", "reference": "When does 'expiresAt' change? Do you need this?" }, { "prediction": "(style) line over 80 characters", "reference": "There are enums for genders + `PLAYERSEX_LAST`." }, { "prediction": "I think it would be better to use `RollupBaseTxSize + len(data)` instead of `RollupBaseTxSize + len(data)` instead of `RollupBaseTxSize + len(data)`", "reference": "Should this use the constants as well? Or intentionally covering the fact that the constants may change" }, { "prediction": "I think this should be `len(self.best)`", "reference": "The case of a negative size (= keep all elements) was not handled in this function." }, { "prediction": "I think this should be `system.enableInfiniteTimeout` instead of `system.enableInfiniteTimeout`.", "reference": "I think we should keep this dynamic config knob for operations purpose." }, { "prediction": "Why is this removed?", "reference": "Was this intentional? Perhaps this could be replaced with another way to check the offsets?" }, { "prediction": "I think this is a bit confusing, but I don't think it's worth it.", "reference": "the buckets are created via the stackset, customers don't need to provide them" }, { "prediction": "Align the parameters of a method call if they span more than one line.
Prefer single-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", "reference": "This doesn't have the same behavior as before. Maybe you want `reverse_merge` (and it either just works or we implement it on `Blacklight::Solr::Request`)" }, { "prediction": "I think this should be `export PATH=/usr/local/ghc/#{ghc_version}/bin/:PATH`", "reference": "This should be ` /$(ghc_find #{config[:ghc]})/ ` instead of ` /#{ghc_version}/ `, I think." }, { "prediction": "I think this should be `dots-vert` or `more_horiz`", "reference": "We should deprecate this at some point." }, { "prediction": "I think this should be `center_sampling_radius=1.5` instead of `center_sample_radius=1.5`", "reference": "Move these two arguments before `loss_cls`." }, { "prediction": "I think this should be `serialNumber` as well.", "reference": "[Super NIT]: i := serialNumber if i == 0 { i = mathrand.Int63n(...) }" }, { "prediction": "I think this should be `tool` or something like `tool_format` or something like `tool_format_tool`.", "reference": "-f short form here collided with --force. :)" }, { "prediction": "Why is this removed?", "reference": "I think it is better to describe in the release note that `rerender()` was removed." }, { "prediction": "I think this should be `if __name__ == \"__main__\":` or `if __name__ == \"__main__\":`", "reference": "We could also test this easily with `runpy.run_module`, what do you think?" }, { "prediction": "I think this should be `if v.Type().AssignableTo(reflect.TypeOf(val)) {`", "reference": "Is it OK to fall through if it's not assignable? I was kind of surprised when the tests passed. Maybe one of the options below ends up working? For the new tests, this panics because `**not assignable uuid.UUID to []uint8**`. `uuid.UUID` is an array, not a slice." }, { "prediction": "I think this should be `blockpAPI` and `retrievalAPI` as well.", "reference": "I know this is after the fact but imo blockAPI should be blockMiningAPI." }, { "prediction": "I think we should use `self::SYSTEM_ATTRIBUTE_PREFIX` instead of `self::SYSTEM_ATTRIBUTE_PREFIX`.", "reference": "it's just a pattern as it was. SystemAttributeCode should have it's own definition and validate by it" }, { "prediction": "I don't think this is needed anymore.", "reference": "Similar to the code block when we use prefix, maybe we can unify them to base?" }, { "prediction": "I think this should be `if in.Spec.Scheduler != nil && in.Spec.Scheduler.Cron != nil && in.Spec.Scheduler.Cron != nil {`", "reference": "I think `Duration` is useful for this action and we shouldn't ignore it." }, { "prediction": "I think this should be `err = s.err` instead of `err = s.err`", "reference": "Everything below here can be replaced with `return s.err, len(p) - len(s.dataForWriting)`." }, { "prediction": "(style) line over 80 characters", "reference": "Again, we can also guard `g_host_hip_lock_arrays.atomic`, can't we?" }, { "prediction": "Why do we need to do this here?", "reference": "Variable name should start from lowercase latter" }, { "prediction": "I think this should be `context.WithTimeout(context.Background(), time.Second*20)` instead of `context.WithTimeout(context.Background(), time.Second*40)`", "reference": "Why has this timeout doubled?" }, { "prediction": "I think this should be `time.Duration` instead of `time.Duration`", "reference": "Should IptablesPostWriteCheckIntervalSecs be set back to its previous smaller value, if use of the iptables lock is disabled?" }, { "prediction": "I don't think we should use `self._tab.key_press(Qt.Key_Enter, modifier=Qt.ControlModifier)` instead of `self._tab.key_press(Qt.Key_Enter, modifier=Qt.ControlModifier)`", "reference": "You're missing a `return` here, but I'll add it :smile:" }, { "prediction": "(style) line over 80 characters", "reference": "Can you try adding back this assertion? I'd like to assert that the texture has been created in the same context as the renderer." }, { "prediction": "I don't think we need to decode the `utf-8` here.", "reference": "This won't work with Python 3 because it will already be a string. In that case we need to use `decode_header` from utils." }, { "prediction": "I think this should be `if self._clear_types` instead of `if self.respond_to?(:_clear_types)`", "reference": "Why is the respond_to check here?" }, { "prediction": "Why do you need to check `$chars[$i] === '\\\\'` here?", "reference": "@orklah are you sure it's the same as `$chars[$i]`? It looks like `$i` is changed above, after `$char` assignment." }, { "prediction": "I think it would be better to use `cpp2::AddVerticesProcessor::instance(kv.get(), nullptr, nullptr, nullptr);` instead of `cpp2::AddVerticesProcessor::instance(kv.get(), nullptr, nullptr, nullptr);`", "reference": "I have a question? How do I construct a indexManager for testcase?" }, { "prediction": "(style) line over 80 characters", "reference": "These checks aren't needed. See pluginmgr.c : opae_plugin_mgr_load_dflt_plugins( )." }, { "prediction": "I think it would be better to use `$this->argumentsAccessor->get($path, null)` instead of `$this->getRawUserQuery()`.", "reference": "Please take a care about prefixing." }, { "prediction": "I don't think we should use `getOrCreateSenderAccount` here.", "reference": "this line doesn't match what the rest says" }, { "prediction": "I think this should be `!linux` or `!windows`", "reference": "Since it's not working for linux, maybe leave the !linux in there as well?" }, { "prediction": "I think this should be `if v != \"\"`", "reference": "Should we remove the key-value pair entirely? Same for workflows in general. We have a \"sourceExists\" method that checks if a key is there if I remember correctly." }, { "prediction": "I don't think we should use `getModificationDateFieldName()` here.", "reference": "Unrelated bug fix" }, { "prediction": "I think this should be `globalize.translate('InstallingPackage', installation.Name + ' ' + installation.Version);`", "reference": "We probably want to let the translation library handle the string replacement for these as well." }, { "prediction": "I think we should remove this line.", "reference": "should combine these 2 list (list_gossip and list_db) into just one list command, and show the discrepancy between the 2 if any." }, { "prediction": "I think this should be `@proposal.currently_awaiting_approvers.include?(@user)`", "reference": "What do you think about prefixing the Policy method names with `can_`?" }, { "prediction": "Why is this removed?", "reference": "Based on the docs, credential process can return a key `SessionToken`" }, { "prediction": "I don't think we should use `moment(birthDate, 'l')` instead of `moment(birthDate, 'LLL')`", "reference": "I think this if should be removed (see issue)" }, { "prediction": "I don't think this is needed anymore.", "reference": "I would avoid importing `felix/ipsets` package because this package is the windows equivalent and should be at the same level of `felix/ipsets`. We could add linux specific dependencies into `felix/ipsets` later and it will break Windows build." }, { "prediction": "I don't think we need to import `List` and `Tuple` here.", "reference": "nitpick: Please move this down to the other imports, as it's a Python stdlib import." }, { "prediction": "I think this is a bit confusing, but I'm not sure if it's worth it.", "reference": "\"for getting started guides\" reads a bit weird, like it's missing punctuation. Maybe just \"for a tutorial\"?" }, { "prediction": "Why is this needed?", "reference": "This looks like a dead parameter -- maybe a copy and paste error. If it's truly unused, maybe you can open a separate PR to simply delete it, and then it's one less detail to worry about here." }, { "prediction": "I think this should be `int64` instead of `uint64`", "reference": "Nit: Should we add support for `int` and `uint` in the `values.New()` function? That would allow us to to handle all of these types in one case. Maybe there's a good reason why we don't do that already, but I'm not sure what it is." }, { "prediction": "Why is this needed?", "reference": "if you are not dealing with cache now, please revert these changes. On their own they make little sense" }, { "prediction": "Why is this removed?", "reference": "Wearing my extra-douche-bag hat I would say not spaces on a blank line. Maybe at some point we could have some automated process remove these things. For now I would not bother changing it." }, { "prediction": "I think this class should be renamed to ShowRemainTimeUpdateEvent.", "reference": "I think it would be better to use an `ItemUpdatedEvent` like for the \"prefer streaming\" preference. We already have a ton of events that need to be handled in all list fragments that just do the same everywhere. I think we could even remove some of the existing events in the future." }, { "prediction": "Line is too long. [82/80]", "reference": "I think we have to manually write a down for this migration." }, { "prediction": "`SPARK_INDEX_NAME_FORMAT(0, None)` should be `SPARK_INDEX_NAME_FORMAT(1, None)`", "reference": "I don't think we still need this check, but I'd leave it as an assertion for now." }, { "prediction": "I think this should be `updated_at.to_i` instead of `updated_at.to_i`", "reference": "Since this may be the case, wondering if we should call the param `updated_at_i` or something so that we don't run into a problem distinguishing them down the road?" }, { "prediction": "I think this should be `appExe = Path.Join(workingDir, appExe);` or `appExe = Path.Join(workingDir, appExe);`", "reference": "wondering why we need to join the paths here; seems evt.commandLine only takes whatever appExe is" }, { "prediction": "I think this should be `StringUtils.deleteWhitespace(serviceName, \"UTF-8\");` or `StringUtils.deleteWhitespace(serviceName, \"UTF-8\");`", "reference": "1.not format code 2.failed but still continue? 3.\"UTF-8\" can changed to java.nio.charset.StandardCharsets.UTF_8.name()" }, { "prediction": "I don't think we need to import `astroid.brain.dataclasses` from `astroid.brain.dataclasses`", "reference": "I'm wondering if we should add this to a `utils` module in `astroid`. Porting the util to `pylint` doesn't make sense as we would need to duplicate the globals that are being used in the function, but importing from `brain` also feels weird. @Pierre-Sassoulas Do you have an opinion?" }, { "prediction": "I think this should be `await ProduceEnd(SocketInput, FrameRequestHeaders);` instead of `await ProduceEnd(SocketInput, FrameRequestHeaders);`", "reference": "This seems different than what we do for corrupted request headers. I would like to determine the correct behavior and consolidate this logic." }, { "prediction": "I don't think we need to do this here.", "reference": "Please make the change in the CAI inventory, rather than changing the scanner." }, { "prediction": "Why is this needed?", "reference": "adding this `abstract` is a breaking API change. Even though I agree it makes perfect sense to have it, we can't break this API until PMD 7.0.0. We should revert this particular change. We could make a reminder ticket like we did with #463 for 6.0.0" }, { "prediction": "Line is too long. [82/80]", "reference": "This is following the existing convention, but I'm not sure the convention is a good one. I think it would be better to have one shared example group: - It means we don't need to add new example groups twice every time. - If the shared example group looks large, that makes it more obvious that our team models have too much shared behavior. I don't want to do anything about this right now (I'm pretty sure I can wipe out this shared example group when I change team plans), but it's good to keep in mind." }, { "prediction": "(style) line over 80 characters", "reference": "I do not think we need to do a source code change to handle this. We could set the subnetwork to default to /32 (/128 for ipv6 ipv4-mapped)" }, { "prediction": "(style) line over 80 characters", "reference": "It looks good overall! The only issue I have is that the description string is now duplicated twice right? Once in the struct and once in the parameter string? Maybe let's pass the struct to the command so that `ostree_option_context_parse` can set it as the summary? Similar to what we do in rpm-ostree." }, { "prediction": "Why is this needed?", "reference": "This states very clearly that this is a derivative of Chrome and not Chromium. Do we need to extract an abstract `ChromiumCommandExecutor` and have both Edge and Chrome derive from that?" }, { "prediction": "I think it would be better to use `type0.getType().equals(type1.getType());` instead of `type0.getType().equals(type1.getType());`", "reference": "it seems to me, the issue lies on `isEnum()` itself, returning false for something that is an enum. I'd rather change it there than here." }, { "prediction": "I think this is a bit confusing, but I'm not sure if it's worth it.", "reference": "Please use `{}` instead of `dict()`" }, { "prediction": "`useEffect` should be `useEffect`", "reference": "I have concerns about using this in more places before #3278 - I'll take a look at that again shortly." }, { "prediction": "I think this should be \"balance not enough\" instead of \"balance not enough\"", "reference": "new field needs to be asserted" }, { "prediction": "I think this should be `self->lastLogIdSent_ = self->logIdToSend_;`", "reference": "when send log failed, why update the last sent log id?" }, { "prediction": "I think this should be `@Override` instead of `@Override`", "reference": "what was the problem with the previous order? `prepend` comes conceptually before `append`, i.e. `insert before` should be before `insert after`, I think" }, { "prediction": "I think this should be a `map[string]string` instead of a `map[string]string`", "reference": "Why is this necessary? Could you provide some context?" }, { "prediction": "I think this should be `