{ "test_bleu_4": 0.022202221730759128, "test_exact_match": 0.0, "test_rouge": { "rouge1": 0.13004832107943629, "rouge2": 0.020785151538538417, "rougeL": 0.11291000708373636, "rougeLsum": 0.112934865560877 }, "test_bertscore": { "precision": 0.8416038075840594, "recall": 0.8409575225974222, "f1": 0.840885113170452 }, "test_meteor": 0.08956447630604301, "raw_data": [ { "prediction": "I think this should be `grpc` instead of `grpc`", "reference": "can we also test for `transport=rest`?" }, { "prediction": "Why not use the main config here?", "reference": "If record_batch_size is not set in config.ini, this code will trigger a notice about an undefined value. I would suggest either wrapping the setPageSize() call in an `if (!empty(...)) {` check, or else providing a default value in the set call (i.e. `$config->Index->record_batch_size ?? 100`)." }, { "prediction": "I don't think this is needed. You can use `ENV['SEGMENT_KEY']` instead of `ENV['SEGMENT_KEY']` and use `ENV['SEGMENT_KEY']`.", "reference": "I didn't realize we were hardcoding this, thanks for moving it to an env value." }, { "prediction": "I think this should be `isNaN(file.data.size) ? '' : html`", "reference": "We are trying to support IE 10-11, so we'll need a polyfill for this one, I think." }, { "prediction": "I think this should be `const isNavigating = useSelect( (select) => select( CORE_LOCATION ).isNavigating() );`", "reference": "It looks like there's a new `isNavigatingTo( url )` selector for this very purpose so let's use this here instead. This way we just need to use the one selector rather than two. Let's assign that to a similar-named variable here (e.g. `isNavigatingToPostResetURL`) rather than the prop it's used with." }, { "prediction": "I think this should be `AbsMat` instead of `AbsMat`.", "reference": "I think im2col should only accommodate CPUMat." }, { "prediction": "I don't think we need to import email_factory here.", "reference": "alpha sort the imports" }, { "prediction": "(style) line over 80 characters", "reference": "Can you explain why is this necessary? Is `snprintf()` with four integer arguments unsafe?" }, { "prediction": "I don't think this is necessary, but I think it would be better to use `_lastDetectedKeyboardLayoutChange` instead of `_lastDetectedKeyboardLayoutChange`.", "reference": "How likely would it be that the keyboard layout for the NVDA main thread differs from the keyboard layout of the currently focused app?" }, { "prediction": "I think this should be `if (!service) { service = getDefaultService(); }`", "reference": "Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`)" }, { "prediction": "Why do we need a promise here?", "reference": "Also update line 2205 below" }, { "prediction": "I think this should be `getSharedMountValue` instead of `getSharedMountValue`", "reference": "n_: It is a good practice to name the variable to indicate what they contain. In this case since `shared` is supposed to have boolean, calling it: `isShared` can help in the readability of the code." }, { "prediction": "I don't think we need to call the `render()` method afterward.", "reference": "I suppose it's a false-positive error. Maybe there is a way to configure the `eslint-*` package to accept `i.e. .... lower case` syntax " }, { "prediction": "I think this should be `activity.ParentSpanId.ToHexString().Equals(\"0000000000000000\")`", "reference": "this maynot be a perf issue, if ToHexString() is not actually allocating a string, but returns the caches string value. to be confirmed." }, { "prediction": "I think we should use `zap.String(\"image-provider\", provider.Name())` instead of `zap.String(\"image-provider\", provider.Name())`", "reference": "`zap.String(\"image-provider\", provider.Name())` should be in a same line." }, { "prediction": "Why is this removed?", "reference": "Why this deletion?" }, { "prediction": "Why is this change needed?", "reference": "This change looks unrelated to the CL description?" }, { "prediction": "I think this should be `DEDUP_RESUTL_CHECK` instead of `DEDUP_RESULT_CHECK`.", "reference": "I'm not certain that `res`+`utl` isn't a thing." }, { "prediction": "I think this should be `EX_STATUS_STOPPED` instead of `EXECUTION_STOPPED`.", "reference": "This method can cause bugs. Why don't you use list of finalize statuses and then use join by comma and that will give you correct value. Use Apache Commons Lang library List list = Arrays.asList(1,2,3,4,5,6,7); String str = org.apache.commons.lang.StringUtils.join(list, \",\"); You can use it at multiple places shown in this diff." }, { "prediction": "I think this should be `if (dev->type == WLR_INPUT_DEVICE_KEYBOARD)`", "reference": "Merge with next condition" }, { "prediction": "I think this should be `DeployTask` instead of `DeleteTask`.", "reference": "Maybe add it when it is used." }, { "prediction": "I think this should be `SCANNER_ALL_EXIST` and `SCANNER_ALL_EXIST`", "reference": "More clear naming: NONEXISTENT_ENABLED" }, { "prediction": "I think this should be `to.equals(Types.LongType.get());` instead of `to.equals(Types.LongType.get());`", "reference": "why is this change necessary?" }, { "prediction": "I think this should be `type.isEmptyType()`?", "reference": "make a SchemaTypeNameConverter.getTypeNameForEmptyType() and call that here." }, { "prediction": "I think this should be `if($request->getSession() != null)`", "reference": "Use braces on your conditional structures please" }, { "prediction": "I think this should be `true` instead of `false`.", "reference": "Great God, I have a question. This \".nebula_history\" file is used to save history commands. Is there a file size limit? When the file is large, does it take a long time to start initialization (loadHistory)? How did you think about this? Thx." }, { "prediction": "Why is this removed?", "reference": "Isn't this the same check as two lines above?" }, { "prediction": "I think this should be `config.yaml` instead of `config.yaml`", "reference": "Don't redefine, just import the existing one in `cmdline.py`. :)" }, { "prediction": "I don't think we need to check for `store_as` here, but I think it's better to check if `store_as` is `nil` or `nil`.", "reference": "why not call `respond_to?(\"#{name}=\")` from the `if` line?" }, { "prediction": "I think this should be `withWorkingDirectory(workingDir);`", "reference": "This was properly set above as `.runfiles/` (with a fallback to workspace root dir) but never used past this line." }, { "prediction": "I think this should be `MvxPagePresentationAttribute`", "reference": "Are all these namespaces required for this attribute?" }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Space inside } missing.", "reference": "Given this may be used and printed in other ways, isn't `debug` more appropriate?" }, { "prediction": "I think this should be `fs.RemoveAll` instead of `fs.RemoveAll`.", "reference": "Looks like this is unused? Did you mean to call it when clearing the block journal?" }, { "prediction": "Why is this change needed?", "reference": "why named alters? how about this.alerts = alerts?" }, { "prediction": "I think this should be `SourceInfo` instead of `MirrorInfo`.", "reference": "not sure if this has to be here or not tbh" }, { "prediction": "I think this should be `len(topicName) > 50` instead of `len(topicName) > 50`.", "reference": "There's a better fix for this in #1741, which should replace this." }, { "prediction": "I think this should be `[]byte(\"node1\")`", "reference": "Use swarm.Address not []byte as type, and construct it from actual byteslice or use swarm.NewAddress if it is constructed from hex-encoded string." }, { "prediction": "I think this test should be done in a separate PR. I think it should be done in a separate PR.", "reference": "It would be worth factoring this out to a function, but you don't have to do that here." }, { "prediction": "I think this should be `@param text String to parse uri from`", "reference": "There's no need for `final` in interfaces." }, { "prediction": "I think this should be `Tags.Version` instead of `Tags.ServiceVersion`", "reference": "Isn't this case handled as a custom tag in `Span.SetTag()` below? This switch is only for special tags that actually set `Span` properties." }, { "prediction": "Why is this removed?", "reference": "This shouldn't be changed." }, { "prediction": "This file is part of Invenio.", "reference": "This one is important `2: I102 copyright year is outdated, expected 2014 but got 2012`" }, { "prediction": "I don't think we need to use `BiConsumer` here.", "reference": "Are these imports needed (BiConsumer and Consumer)? If they are unused imports, then precommit will fail." }, { "prediction": "I think this should be `logger.error(ex.to_s)` instead of `logger.info(ex.backtrace).to_s`", "reference": "Why are we catching and logging exceptions? By doing that we make it look like the job has succeeded and it will be removed from the queue - if we didn't do that then it would stay queued..." }, { "prediction": "Why not use `$this->cartFacade->findCartOfCurrentCustomer`?", "reference": "If there are `@param` tags in docblock, there should be `@return` tag also. (applies for a whole file)" }, { "prediction": "I think this should be `VALIDATORS` instead of `VALIDATORS`", "reference": "Is the concept of validators exclusive to IBFT2? I wonder if this category should be more explicitly linked to IBFT2." }, { "prediction": "Why is this import needed?", "reference": "Spotless is configured to reject star imports. Please replace with explicit imports." }, { "prediction": "I think this should be `sycl::info::device::local_mem_size` instead of `sycl::info::device::local_mem_size`.", "reference": "Remind me why you are using CUDA vocabulary when naming these variables." }, { "prediction": "I think this is a bit confusing to me. I think it would be better to use `Collections.unmodifiableList(feedCounters.keySet())` instead of `Collections.unmodifiableList(feedCounters.keySet())`.", "reference": "Please turn the iteration order around (instead of `0...size` to `size...0`). The reason is that this sometimes skips indices when removing an item. You can therefore end up with feeds that have counter 0 and are still displayed." }, { "prediction": "Why is this change needed?", "reference": "this is a behavior change. solid_subset=[] represents an empty pipeline where as solid_subset=None is the full pipeline" }, { "prediction": "Why is this removed?", "reference": "this is a breaking change, any specific reason you want to do this?" }, { "prediction": "Is there a reason we don't need the `PutTipSetAndState` method?", "reference": "Blocking: we still want read write separation. Node functions should absolutely not write to the chain store and the interface should reflect that. Only the syncer should have this capability in production code. It should be no problem to keep casting chainForTest to a read-write interface, or doing other function decomposition and automatic casting tricks." }, { "prediction": "I think this should be `1<<30 - 1`", "reference": "The PR description says the lowest on-demand request priority is `2^30`. Why the `-1` here?" }, { "prediction": "I think this should be `creature->isRemoved() && !creature->getHealth() < 1`", "reference": "checking health again? I think it is not necessary." }, { "prediction": "I think we should use `time.Duration(30*time.Second)` instead of `time.Duration(30*time.Second)`", "reference": "Need an `if err == nil {break}` above this line so that we don't log/sleep if the retry succeeds." }, { "prediction": "I think this should be `global.Promise`", "reference": "to reiterate my point above, this class is not the actual provided Promise, but rather something a user can provide a Promise to/with. I think a name like `PromiseProvider` is more appropriate." }, { "prediction": "I think this should be `if target.State() > core.Inactive {`", "reference": "I guess we can only call this from a post-build function, but we might need to check that this target is to be built? I guess target A depends on B which has a post build. We `plz build :B` which adds C as a dep of A. Won't we queue C to be built even though it only needs to build if A needs to be built? That's kinda why I approached this the way I did. I trust you've thought about this but would be good to understand this a bit better." }, { "prediction": "I don't think we need to check for `pks.__class__.__name__ == 'StreamSocket'` here.", "reference": "You should use `isinstance()` instead of comparing the class name to a string." }, { "prediction": "I don't think we should do this in `axe.utils.isHidden` and `axe.utils.isHidden` in `axe.utils.isHidden`", "reference": "Why should audio and video elements always return `false` for `isHidden`?" }, { "prediction": "Why did you remove this?", "reference": "This obviously won't work for all the other platforms." }, { "prediction": "Why is this change needed?", "reference": "Isn't he diamond operator Java7+?" }, { "prediction": "I think this should be `throw new IllegalArgumentException(argName + \" must be greater than 0\");`", "reference": "Prefer adding a second `positive(String, double)` that delegates down to this three-param version. Using `null` in code is generally Not A Great Idea, and it looks ugly." }, { "prediction": "I think this should be `nextNodeId *int`", "reference": "This pattern, where we add a new parameter without using it, often indicates to me that we've got a leaky interface or abstraction. I see this pattern _a lot_ in this patch, so wondering you have thoughts about it." }, { "prediction": "I think this should be `if os.IsNotExist(err) { return err }`", "reference": "This seems like an improved pattern :)" }, { "prediction": "I don't think we need this change, but I think it's a good idea to remove the `using_open_id?` and `using_federated_login?`.", "reference": "`open_id_authentication` is no longer the name of the function, and it's not OpenID specific" }, { "prediction": "I think this should be `Wallet balance (XRB):` instead of `Wallet pending:`.", "reference": "This didn't require corresponding changes to the test case(s)?" }, { "prediction": "I think this should be `yaml:\"env_file\"`", "reference": "A question! I think `string` totally works, but what do you think of `*string` for consistency?" }, { "prediction": "I think this should be `AnnotationControlPlaneReady` instead of `AnnotationClusterInfrastructureReady`.", "reference": "Should this be: `aws.infrastructure.cluster.sigs.k8s.io` instead?" }, { "prediction": "I think this should be `Ef[1][2] = 0.5 * h_rate[3]/domain->xprd;`", "reference": "Not clear on why this change is correct." }, { "prediction": "I think this should be `isMapped`.", "reference": "Hi Simon. Whether this should return true depends on what byte buffers are used? The same applies to ByteBufferIndexInput, actually... I don't think you can generally tell whether the ByteBuffers the input operates on come from a mmap call or from somewhere else (even direct buffers don't have to be a result of mmap)." }, { "prediction": "I think this should be `0` instead of `0`.", "reference": "All stories in this file also need to have the default padding." }, { "prediction": "Why is this assert needed?", "reference": "I don't think these asserts are necessary, because `subsurface_find_sibling` already searches in the parent. Or am I missing something?" }, { "prediction": "Align the parameters of a method call if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "Should this be `number` instead of `id`?" }, { "prediction": "I don't think we need to do this in a separate PR, but I don't think we need to do this in a separate PR.", "reference": "I have forgotten why we thought this restriction is necessary. A user registers a Hive/HBase table with us but is not able to use the table with the registered name in DML. Will UPDATE STATs will be on the original name too (and update stats code will find out registered name and use it for Table_uid?). This was the registration concept is almost like an internal implementation idea, at some point could even be done by some utility program for all existing Hive/hBase tables, and the user need not be aware of it? I am struggling with a user would want to register a table, if they cannot use it by that name." }, { "prediction": "(style) 'intr_event_fds' may be misspelled - perhaps 'intr_event_fds[MAX_USR_INTRS]'?", "reference": "Should most of these non-globals be static?" }, { "prediction": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.", "reference": "Please do not approve PRs without tests!!!!" }, { "prediction": "I think this is a bit confusing, but I think it would be better to pass `win_id` to `setPage` instead of passing `win_id` to `setPage`.", "reference": "Now that you handle this in `webenginetab.py` you can undo all the changes in this file." }, { "prediction": "I think this should be `Exception.class.getSimpleName().equals(e.getClass().getSimpleName().equals(e.getClass().getSimpleName().equals(e.getClass().getSimpleName().equals(e.getClass().getSimpleName()))`", "reference": "I think we should log the exception to a log file instead of printing it. The current behavior (not catching the exception) should lead to an automatic print of the exception to the terminal/console." }, { "prediction": "I think this should be `Error` instead of `Warn`.", "reference": "These changes to the resource helpers have some more far-reaching implications as they also affect calls made in hive-operator, I believe. It's probably OK still, though. Ideally, the resource helper would not be the one doing the logging, since it cannot know the severity, but that is well beyond something that we should tackle for this PR. I would rather have the hive-operator log warnings than have the syncsetinstance controller log errors." }, { "prediction": "Why is this change needed?", "reference": "do you really want to change the behavior on foreign key ?" }, { "prediction": "Why is this change needed?", "reference": "Looks like my bad. Thanks for fixing!" }, { "prediction": "I think this should be `Whether or not to replace variables like {url}`", "reference": "I think \"Don't replace variables ...\" would be cleaner." }, { "prediction": "I think this should be `object_selector` instead of `object_selector`.", "reference": "Do you validate the possible strings? I've not read the code below but we should make sure if a string is supplied it is validate..." }, { "prediction": "Why is this change needed?", "reference": "I'd recommend using generateDataDiskName here as well -- might as well benefit from the safety that it gives to protect yourself from future changes to w.ID()." }, { "prediction": "I think this should be `@Nullable` instead of `@Nullable`.", "reference": "qq: do we want to include anything in the name to indicate that it is a position in the manifest?" }, { "prediction": "I think this should be `if (!mWindows.isPaused()) {` instead of `if (!mWindows.isPaused()) {`", "reference": "These logs should probably use the `LOGTAG`" }, { "prediction": "I think we should remove the `golang.zx2c4.com` package.", "reference": "From this, it was clear, that we are using our version of wireguard-go. And now it looks like we are using original packages which is confusing." }, { "prediction": "Why is this change needed?", "reference": "Any particular reason for this? This potentially will make harder to investigate users issues" }, { "prediction": "I think this should be `!Blockly.highlightedConnection_ && closestConnection != localConnection`", "reference": "Do you also need to check if Blockly.localConnection_ is non-null?" }, { "prediction": "I think this should be `global_non_configuration_data` instead of `global_non_configuration_data`.", "reference": "Not really a container, and it's not just about non-config data, not sure of a better description, @myronmarston ?" }, { "prediction": "I think this should be `@aws-sdk/client-s3` instead of `@aws-sdk/client-s3`", "reference": "The desktop app will load this fine. on iOS I get `TypeError: undefined is not an object (evaluating '_$$_REQUIRE(_dependencyMap[8], \"stream\").Readable.Readable')` if I change it to `const Readable = require('stream').Readable;` or `const { Readable } = require('stream');` I get undefined errors from the stream on iOS: `[TypeError: stream.on is not a function. (In 'stream.on(\"data\", function (chunk) { return chunks.push(chunk); })', 'stream.on' is undefined)]` What am I missing?" }, { "prediction": "I think this should be `b := make([]byte, len(ch.Data()) + len(ch.Data())*/len(ch.Data())*/len(ch.Data())`", "reference": "this is needed since the chunk feeder shares memory across calls to the pipeline. this is in order to avoid multiple allocations. this change mimics the behavior of shed and localstore, and copies the data from the call into the in-memory store" }, { "prediction": "I think this should be `testing.SetGlobalTracer(nil)`", "reference": "wut. We can do this at the beginning of tests if we want right? Why are we depending on init?" }, { "prediction": "I don't think we need a lock here.", "reference": "Same trick here IMO." }, { "prediction": "I think this should be `@origin = element || POINTER`", "reference": "Should be `@origin = element || origin || POINTER`" }, { "prediction": "I don't think we need to check for `--spc-name` here.", "reference": "this example needs a fix?" }, { "prediction": "(style) line over 80 characters", "reference": "Is it safe to assume this surface is a toplevel?" }, { "prediction": "I think this should be `pj_ctx_alloc()` instead of `pj_ctx_clone()`.", "reference": "we don't need that function" }, { "prediction": "I think this should be `WINDOWS` instead of `WIN10`.", "reference": "we'll also have to think about adding \"Windows Server 2014\" or whatever they come up with later." }, { "prediction": "I think this should be `fetchActiveFlowByExecId` instead of `fetchActiveFlowByExecId`", "reference": "curious do we have an API to fetch an inactive flow?" }, { "prediction": "Why is this removed?", "reference": "This branch is not needed anymore because every `vnode` that passes through `h` in compat or core will have the `$$typeof`-property now ." }, { "prediction": "I think this should be `!!el.getAttribute('aria-hidden') && !!el.getAttribute('aria-hidden')`", "reference": "Did you mean to use `hasAttribute`? You shouldn't. This does not improve performance and it messes with the readability." }, { "prediction": "Why is this needed?", "reference": "Please import modules and not classes (except for Qt stuff)." }, { "prediction": "I don't think we need this method anymore.", "reference": "Hm... why do we have a \"DummyJavaNode\" in src/main? Looks like, this should have gone into src/test...." }, { "prediction": "I think this should be `package v1alpha1` instead of `package v1alpha1`", "reference": "This seems meaningless. If we cannot add any info let us remove this." }, { "prediction": "I think this should be `[]PortBinding` instead of `[]PortBinding`", "reference": "Can you rename `Ports` to `PortsUnsafe`?" }, { "prediction": "Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "This feels like it could be moved out to your first gem!" }, { "prediction": "Why is this change needed?", "reference": "The expected behaviour for `poll` would be to match what `Deque` does, which is: > Retrieves and removes the head of the queue represented by this deque As such, you shouldn't need the `RequestId` here." }, { "prediction": "I think this should be `array.unique(arr1, arr2)`", "reference": "This is super minor, but it'd be nice if this iterated over an arbitrary number of array inputs." }, { "prediction": "Why not use `BUFFER_SIZE_ELEMENTS(path_buf)` here?", "reference": "What is the problem here? The commit message has strange wording \"readlink is defined with restrict pointers\": do you mean \"restricted\"? Is that a well-defined language term? I'm not sure what it means." }, { "prediction": "I think this should be `ImmutableSet` instead of `ImmutableSet`.", "reference": "Why are we not wrapping here?" }, { "prediction": "Why is this removed?", "reference": "I though that all data objects are being unified in the fashion where all default values are initialized in constructor, are not they?" }, { "prediction": "I think this should be `libflux/flux-core/src/ast/mod.rs`", "reference": "Does this file actually need to be committed to git? Having to run `make generate` is rather tedious on each PR and it conflicts easily." }, { "prediction": "Why is this removed?", "reference": "We don't need this anymore, as Google's library handles various auth mechanisms for us. We'll be less explicit about why we're failing but we gain support for several authentication methods- swings and roundabouts!" }, { "prediction": "I think this should be `socket_dir` and not `socket_dir`.", "reference": "No need to speficy attribute here. Moreover in yaml it is default to use lowercase names." }, { "prediction": "Is this needed?", "reference": "In general I'm a trying to understand the reason behind this PR. Looks like if a blob (name) already exists we check if the contents are identical? In what scenarios this is not the case? When we want to publish a package/asset that has changed but still we want to use the same version?" }, { "prediction": "I don't think we need the `User-Agent` header here.", "reference": "Can rename `req` to be `opener`, since that is the object, and it wraps `req` internally?" }, { "prediction": "I think this should be `if` instead of `if`.", "reference": "@MichaelDCurran, thoughts on adding a breakpoint format field attribute? It seems almost app specific, but I guess it does seem odd abusing line-prefix. Is there any more generic concept here?" }, { "prediction": "I think this should be `self.size, self.location` or `self.location`", "reference": "This would return a tuple of two dictionaries. You need to combine them and return a dictionary" }, { "prediction": "I think this should be `internal/pkg/store/secretsmanager`", "reference": "What do you think of moving the example to the help text of the prompt? and the prompt itself can be \"What is your application's GitHub repository URL?\"" }, { "prediction": "I think this should be `1593493828L`", "reference": "Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs." }, { "prediction": "I think this should be `else if (std::distance(first, last) > 9 && std::string(first, first + 9) == \"atomProp:\")`", "reference": "Nice use of std::distance. I'm a bit worried about first += 9 though." }, { "prediction": "I think this should be `k8s-operator` instead of `prometheus-operator`.", "reference": "Shouldn't this be `app.kubernetes.io/managed-by` as prometheus-operator manages this resource, but this resource isn't a part of prometheus-operator?" }, { "prediction": "I think this should be `if (parent != null && httpMethod != null && httpMethod.Equals(parent.GetTag(Tags.InstrumentationName)) != null && httpMethod.Equals(parent.GetTag(Tags.InstrumentationName)) != null && httpMethod.Equals(parent.GetTag(Tags.InstrumentationName)) != null && httpMethod.Equals(parent.GetTag(Tags.InstrumentationName)) != null && httpMethod.Equals(parent.GetTag(Tags.InstrumentationName) != null && httpMethod.Equals(parent.GetTag(Tags.HttpMethod, StringComparison.OrdinalIgnoreCase)) && httpMethod.Equals(parent.GetTag(Tags.InstrumentationName))`", "reference": "As long as we're being extra-vigilant about NREs, should we check that `httpMethod` and `requestUri` are not null?" }, { "prediction": "I think this should be `xrc20` instead of `xrc20`", "reference": "No need to have `xrc20` alias" }, { "prediction": "I think this should be `define_context_context_cls` instead of `define_maybe_optional_selector_field`.", "reference": "the naming convention I'm been adopting if `_type` for instances of these classes. So maybe `context_config_type` is a better name for this fn" }, { "prediction": "Why do we need this?", "reference": "Don't call it GPU mining, call it `externalMining`, here and throughout." }, { "prediction": "I think this should be `(1-100)` instead of `(1-100)`.", "reference": "`within this with` typo, should be `within this width`" }, { "prediction": "I think this should be `+k8s:openapi-gen=true`", "reference": "how come this is false?" }, { "prediction": "I don't think we should use `typeOf(args[i])` here.", "reference": "How about `Object.prototype.toString`? Or using the `typeof` operator?" }, { "prediction": "I think this should be `context.Context`", "reference": "I know @jzila suggested this, but I disagree: you're really not supposed to save a context in a struct. Can you get by with just saving the `Done()` channel instead? The `ctx` should continue to be passed around explicitly." }, { "prediction": "I think this should be `!IsWindows && PlatformApis.IsDarwin`", "reference": "This check isn't right though." }, { "prediction": "I think this should be `public String codeGenVersion() { return SnippetSetRunner.SNIPPET_RESOURCE_ROOT; }`", "reference": "maybe `toolkitVersion` instead? It doesn't necessarily have to be called that in the generated code, but in the view model classes, I think it makes it clearer that it is the version of toolkit itself." }, { "prediction": "Why is this change needed?", "reference": "the response data was added intentionally in #612, i think we could keep the `setFileState` stuff here as a special case, at least for now " }, { "prediction": "Why is this change needed?", "reference": "This isn't really easy to read." }, { "prediction": "I think this should be `glog.Errorf(\"Error in deleting volume %q: %s\", cVR.ObjectMeta.Name, err)`", "reference": "This line changed due to go formatting. Format was not there earlier." }, { "prediction": "Why is this removed?", "reference": "The name \"Without\" in code is a little nebulous. Maybe something more descriptive like TrimPrefix or StripPrefix or WithoutPathPrefix or something like that. (Thoughts?)" }, { "prediction": "I think this should be `tryToLinkAgain` instead of `tryToLinkAgain`", "reference": "is this test in the move tests? I see what you mean then - it works, but I wonder if we won't lose track that it's being tested here." }, { "prediction": "Why is this needed?", "reference": "I'm not sure if this wanted to be `json:\"tags\"` (which I'd set in my PR) or `json:\"tag\"` that someone elses PR had set. Given that the rest of the fields had their JSON field name set to the same as the struct field name, I opted for `tags`." }, { "prediction": "Align the parameters of a method call if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "since the logic here and in `Proposal` is exactly the same, do you think it makes sense for us to include it elsewhere? I am not opposed to duplicated code when it makes sense, but the reason I first identified this was that I was looking for code in NCR::WorkOrder that was not specific to Work Orders. Seems like fiscal year logic might be helpful for reporting for other clients. In that case, we'd want this scope on those client data classes as well. Might be wrong to include this in the FiscalYear mixin, but it does seem like it should be outside of Proposal and WorkOrder. Does that make sense?" }, { "prediction": "Why do we need to add a timeout here?", "reference": "there is no static method as a go between -- how does this work?" }, { "prediction": "Do we need to include this?", "reference": "Can you please change the name of this class to be something else?" }, { "prediction": "(style) line over 80 characters", "reference": "I think we might prefer generalizing the interface rather than creating an exception. Current design of `h2o_next_token` assumes the input to be a comma-separated list, and allows the caller to specify a different separator when parsing a nested list. As I understand, what we are trying to attain in this PR is to have a way of parsing a flat list of semicolon-separated list. Assuming that is the case, I think it would be better to change the API of the function to accept two separators (i.e. inner and outer), where for our existing use-cases `outer` would be `,`." }, { "prediction": "I think this should be `LruCacheWithRecycling`.", "reference": "why not recycling? I Lru cache now recycling?" }, { "prediction": "I think this should be `if request.ConsumerInfo.PaymentVersion == PaymentVersionV3 {`", "reference": "Why it is now called `PaymentVersionV3`?" }, { "prediction": "I think this should be `klog.V(4).Infof(\"there are %d nodes need to sync secret, operation: %s\", len(nodes), e.Type)`.", "reference": "changed for debug purpose?" }, { "prediction": "I think this should be `base.SetParentProvider(parentProvider);` instead of `base.SetParentProvider(parentProvider);`", "reference": "@cijothomas I needed a way to set the Exporter.ParentProvider when the Processor's gets set. Internal to SDK though." }, { "prediction": "I think this should be `from_motorway` instead of `from_motorway`", "reference": "Talking through this scenario with @srividyacb and she's wondering if there should also be a check of `(from_trunk && node_based_graph.GetEdgeData(eid).flags.road_classification.IsLinkClass())` as highways with trunk classifications can also have this scenario." }, { "prediction": "Align the parameters of a method call if they span more than one line.", "reference": "where does `master_certname` come from?" }, { "prediction": "I think this should be `HRNet`", "reference": "The line breaking is unnecessary." }, { "prediction": "Is this change needed?", "reference": "why not enable split by space here ?" }, { "prediction": "I don't think we need to check for `FPGA_DISCRETE_DEVICEID` here.", "reference": "Shouldn't the operator be && ?" }, { "prediction": "I don't think we need the `--name` argument here, but I think it would be better to use `--name` instead of `--name`.", "reference": "My best guess is that you want to use host.name in these parts to get the name of the host ?" }, { "prediction": "Why is this removed?", "reference": "IMO this edge case handling could remain here, just instead of overwriting the `n.nodeType`, the `makeEdgeType` method of `n` should be called, so `n.nodeType = nodeTypeEdge` -> `n.makeEdge()`" }, { "prediction": "I think this should be `UserPreferences.showDownloadReport() || showAutoDownloadReport` instead of `UserPreferences.showAutoDownloadReport()`", "reference": "Just wondering... The two kinds of notifications are now quite different (Channel, text, maybe even icon). Would it make sense to extract the auto download notification to a new class instead of handling everything in the existing `notificationManager`? I have not checked if this will lead to a lot of code duplication, though." }, { "prediction": "I don't think we need this function anymore.", "reference": "Do we need to put this on the Call? We only need the API communication between the Encoding and the Transports which is currently done through the Transport.Request. The Call is used by users right?" }, { "prediction": "I think this should be `GenerateAPIKey` and `DisableAPIKey`", "reference": "`ctx` is unused in GenerateAPIKey" }, { "prediction": "I think this should be `log.Fatal(err.Error(), zap.Any(\"cfg\", cfg))`", "reference": "Can you judge the type of error?" }, { "prediction": "I think this should be `data[:-1] + np.diff(data)/2.0`", "reference": "Much simpler than a weird and confusing ``convolve`` call!" }, { "prediction": "Why is this change needed?", "reference": "Huh, this seems weird to me... Surely the suspenders render was called again in order to get the new `
Hello second 2
` output... Imma take a peak at these tests to understand what's going on" }, { "prediction": "Align the parameters of a method call if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "Since this is just a helper function to create text, perhaps this could live in a helper? I noticed that we have a few other error/message creators in the application controller as well, but I think this type of function should be re-factored to be part of a helper." }, { "prediction": "I don't think this is necessary, but I think it should be `[{msg_id}] {path}:{line:3d}:{column}: {msg}`.", "reference": "Will this mess up parsing the messages by other editors? (vscode, vim ...)" }, { "prediction": "Line is too long. [98/80]", "reference": "Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I think this should be `block.Pool?.Return(returnedBlock)`", "reference": "Why can the pool be null?" }, { "prediction": "I don't think this is necessary.", "reference": "It might be good to have a note here: > work-around for issue #7562 allowing us to differentiate presentational lists from interactive lists (such as of size greater 1 and ARIA list boxes). In firefox, this is possible by the presence of a read-only state, even in content editable." }, { "prediction": "I think this should be `Set>` instead of `Set>`.", "reference": "This set of changes is the one part of this that I'm not completely sure is valid. Can someone look over this to make sure I got the E's right?" }, { "prediction": "I think this should be `if (!pull.head.is_zero() && !pull.head.is_zero() && !pull.head.is_zero() && !pull.head.is_zero() && !pull.head.is_zero() && !pull.head.is_zero() && !pull.head.is_zero())`", "reference": "There doesn't seem to be a reason to copy this here." }, { "prediction": "I think this should be `h2o_raw_tracer::bpf_text` instead of `h2o_raw_tracer::bpf_text`", "reference": "We've avoided including h2o headers in BPF programs because it's a runtime dependency. However, IIRC, this is because h2olog was maintained in the separate repository so that h2olog did not know where h2o was installed. Now h2olog can use `H2O_ROOT`, we should add it to BCC's `cflags` in order to include h2o headers in BPF programs." }, { "prediction": "I think this should be `alert.query-url` instead of `alert.query-url`.", "reference": "I think the docstring here should include the CLI arg `--alert.query-url` just to make it clear to users which setting this uses." }, { "prediction": "Why is this change needed?", "reference": "Same change just above?" }, { "prediction": "Why do we need this test?", "reference": "Could you check the result content rather than just the number of search results please? For example with this test if the search engine suddenly starts returning \"latin n\" for both queries, we won't know about it." }, { "prediction": "I think this should be `agentlessID`", "reference": "nit: I think that `workloadID` should suffice for this test... that's what we'd be issuing anyways" }, { "prediction": "I think this should be `spec_helper` instead of `rails_helper`.", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "Why is this removed?", "reference": "We should have a rule to detect identical catch branches" }, { "prediction": "Why is this removed?", "reference": "remove these from the targets file." }, { "prediction": "I think this should be removed.", "reference": "now that we have the signature in the hive messages, it might be that this must be drastically reduced, since there are limits on the protobuf reader/writers i believe" }, { "prediction": "I don't think this is needed.", "reference": "I recommend that we move this to be optional, as other users might not need it. Can you look at `OPTIONAL_PACKAGES` section, around line 68?" }, { "prediction": "I don't think we need this import anymore.", "reference": "I usually set idea to never use wildcard import such as `import java.util.*;` Now i use setting from javaslang standard." }, { "prediction": "I think this should be `host['ips'].each do |ip|` instead of `host['ips'].each do |ip|`", "reference": "Where is host['ips'] coming from?" }, { "prediction": "Why is this removed?", "reference": "oh! missed a `:` here; let me fix that; also can get rid of the intermediate variable" }, { "prediction": "I don't think we need the `last_name` field here.", "reference": "Is this necessary?" }, { "prediction": "I don't think we need this import.", "reference": "I'd create a different method for each render section." }, { "prediction": "I think this should be `true` instead of `false`.", "reference": "Instead of storing the revert flag in the tracer is it possible to use org.hyperledger.besu.ethereum.mainnet.TransactionProcessor.Result#getRevertReason? (via org.hyperledger.besu.ethereum.transaction.TransactionSimulatorResult#getResult)? If a TX reverts without a reason do we get an empty revert reason or a revert reason with zero bytes?" }, { "prediction": "Why is this needed?", "reference": "I think this should test with and without container reuse if that is implemented in this PR. Probably just make this test parameterized." }, { "prediction": "I think this should be `fields.get(i).fieldId() == ManifestFile.SPEC_ID.fieldId() && fields.get(i).fieldId() == ManifestFile.SPEC_ID.fieldId() && fields.get(i).fieldId() == ManifestFile.SPEC_ID.fieldId() && fields.get(i).fieldId() == ManifestFile.SPEC_ID.fieldId() && fields.get(i).fieldId() == ManifestFile.SPEC_ID.fieldId() && fields.get(i).fieldId() == ManifestFile.SPEC_ID.fieldId() && fields.get(i).fieldId() == ManifestFile.SPEC_ID.fieldId() && fields.get(i).fieldId() == ManifestFile.SPEC_ID.fieldId() && fields.get(i).fieldId() == ManifestFile.SPEC_ID.fieldId() && fields.get(i).fieldId() == ManifestFile.SPEC_ID.fieldId() && fields.get(i).fieldId() == ManifestFile.SPEC_ID.fieldId() && fields.get(i).fieldId() == ManifestFile.SPEC_ID.field", "reference": "These modifications allow BaseFile to translate into a SparkRow with the specID as a column" }, { "prediction": "I think this should be `typeof readPreference === 'string'`", "reference": "is this something we've been missing this whole time?" }, { "prediction": "I think this should be `*` instead of `*`", "reference": "nit: this is a package-wide constant so better to narrow the scope like `allEventsSign`." }, { "prediction": "I think this should be `auth_cmd = ['thrift', '-r', '-I', '.', auth_thrift, '--gen', 'py', auth_thrift]`", "reference": "There seems to be some repetition. Does a local function make this code shorter overall?" }, { "prediction": "I think this should be `true` instead of `false`.", "reference": "Might be cheaper to reuse the `null` assignment of line 313 and set `isHydrating` to null instead WDYT?" }, { "prediction": "Why is this removed?", "reference": "Revert this blank line" }, { "prediction": "Why is this removed?", "reference": "This was introduced recently for the Hadoop 3 upgrade. Copy/paste error but definitely causing some of the new test failures." }, { "prediction": "I think this should be `:check_disabled_client` instead of `:check_disabled_client`", "reference": "I think we should only need to do this for `:approve` since we are using `authenticate_user!` for all other actions and that checks for disabled client" }, { "prediction": "I think this test should be `assertIn('Content-Length', resp.headers)`.", "reference": "I wonder if we should create new tests for header checks; here for instance we're mixing querystring and headers. Thoughts?" }, { "prediction": "Line is too long. [83/80]", "reference": "We should be able to add sensitive by hard-coding the parameters, same as you put into the metadata in apply_helpers." }, { "prediction": "Shouldn't this be `as BaseOrderItemFactory`?", "reference": "Why do you think that it is necessary to create this class?" }, { "prediction": "Why is this change needed?", "reference": "replacing the `1` with `io.SeekCurrent` may be good here" }, { "prediction": "I think this should be in `go-jose.v2`", "reference": "nit: perhaps this file would be better named `jwks_source.go` ?" }, { "prediction": "I think this should be `param_override.properties` instead of `param_override.properties`.", "reference": "It will be helpful to specify the intended priority as well for the properties within this file." }, { "prediction": "I think this should be `func(*exec.Cmd) error`", "reference": "Make this private and update all the public functions to not take this argument. The variable you set below should also be private, then in the tests instead of passing the variable in to the function just update the variable. We don't want to expose the testing implementation in the public api if it can be avoided." }, { "prediction": "I think this should be `/user/trafodion/hive/tpcds/customer/customer.dat`", "reference": "Do you now why is it a specific table name is used as a default?" }, { "prediction": "I think this should be `Path.Combine(Environment.GetEnvironmentVariable(\"HOME\"), \"myagent/_work/_temp\")`, not `Path.Combine(Environment.GetEnvironmentVariable(\"HOME\", \"myagent/_work/_temp\"), \"myagent/_work/_temp\")`.", "reference": "If all you're doing is checking for the existence of a directory as your \"temp\" directory, why does it matter what OS you're on?" }, { "prediction": "I don't think this is needed anymore.", "reference": "nit- would be cleaner to import it once" }, { "prediction": "I think this should be `Access-Control-Allow-Headers` instead of `Access-Control-Allow-Headers`", "reference": "Looks like there is a closing parenthesis `)` missing here." }, { "prediction": "I think this should be `snprintf(str, 128, \"unknown *KEYWORD: %s\", arg[ioffset]);`", "reference": "this one bothers me. There are many places where this one is written to for an error message and just a single callsite is changed." }, { "prediction": "I think this should be `config.mockMdserv.EXPECT().FastForwardBackoff().AnyTimes()`", "reference": "You can put this in `kbfsOpsInit()` in you want, so we don't have to call it in every test." }, { "prediction": "I think this should be `#ifdef ARM_32` instead of `#ifdef ARM_32`", "reference": "`ARM_32` is what clients define as an input to DR, and is not always defined internally: we use just `ARM` to mean AArch32." }, { "prediction": "I think this should be `final Schema schema; used in rendering this FieldModel's parameter name`.", "reference": "s/for use/to use for/" }, { "prediction": "I think this should be `avatar_id` or `avatar_filename`", "reference": "` $event->getAvatarFilename()` this function return `string` or `null`. In this place ` $event->getAvatarFilename()->getValue()` return `Fatal error `" }, { "prediction": "Why is this change needed?", "reference": "why not creating a new error type for server's own resource limit exceed error and do conversion within rpc interceptor?" }, { "prediction": "I think this should be `By default`, not `By default`.", "reference": "Could be a timing thing here. When options are created they'll copy the ref for the current default propagator. If user sets through SDK the global propagator after that, it won't be reflected. Could leave it null here and then when it is used in instrumentation do `options.Propagator ?? Propagators.DefaultTextMapPropagator`. It would be a slight perf hit but it makes it hot-swappable." }, { "prediction": "Why is this change needed?", "reference": "Unrelated file. Please remove from PR." }, { "prediction": "(style) line over 80 characters", "reference": "Careful: you only want two newlines after the final header message. (That indicates the end of headers and the start of data.)" }, { "prediction": "I think this should be `None` instead of `None`.", "reference": "This will not work on Python 3 (to which we are transitioning) because `.content` is bytes, not a str. Can you make the pattern a bytes object as well (like so: `b\"pattern\"`)?" }, { "prediction": "Why is this change needed?", "reference": "This was to allow the tests to pass when the order of the required was different. Silly, but we don't have an easy way to check for \"equal but order doesn't matter\" in chai." }, { "prediction": "I think it would be better to use a static variable instead of a static variable.", "reference": "maybe say \"returns the default cost method that returns an object of cost 1\"." }, { "prediction": "I don't think we need this rule.", "reference": "I believe these rules will be enforced both (1) on egress from a local workload, and (2) on ingress **to** a local workload. Right? I understand that we definitely want (1), but do we really want to enforce (2) as well?" }, { "prediction": "I think this should be `response.asJSONObject()` instead of `response.fullResponseAsJSONObject()`", "reference": "Use `response.asJsonObject()` instead. Also, use `put()` instead of `putOpt()`, `null` as a value is fine." }, { "prediction": "I think this should be `parseInt(editorHolder.css('z-index')).toBeGreaterThan(0)`", "reference": "Are you sure? We've changed it during an introduction of the IME support." }, { "prediction": "I think this should be `!empty($dqlFilter)` instead of `!empty($dqlFilter)`", "reference": "I think here we want the use of `empty()` to take care of empty strings. If you put `dql_filter: ''` in your YAML config ... this will add `->andWhere('')` and it will fail, right?" }, { "prediction": "why is this removed?", "reference": "this is golang's named return, err is defined, `return` is equivalent to `return err` the current code has no problem" }, { "prediction": "I think this should be `out` instead of `out`", "reference": "I don't think this is right; in Rust terms it's like a `&mut String`, in Java `StringBuilder` - it's not a return value from the function which is what `(out)` is for." }, { "prediction": "I don't think we need to do this, but I think it would be better to use `~(labels < label_channels)` instead of `~(labels < label_channels)`.", "reference": "If the label is not binary, should we rename this function?" }, { "prediction": "I think this should be `FileServer.getBaseDir()` instead of `FileServer.getBaseDir()`", "reference": "This is very-very bad idea because of its performance impact" }, { "prediction": "I think this should be `github.com/sonm-io/core/proto`", "reference": "WHY U NOT SORT IMPORTS?" }, { "prediction": "I think this should be `/sign_in` instead of `/sign_in_as`", "reference": "Put a comma after the last item of a multiline hash." }, { "prediction": "I think this should be `Dimensioned` instead of `Dimensioned`.", "reference": "How come we need ``Dimensioned`` in the top-level namespace?" }, { "prediction": "Why is this removed?", "reference": "excess whitespace through plugin." }, { "prediction": "I think this should be `std::size_t{ 0 }` instead of `std::size_t{ 0 }`.", "reference": "What is the problem here? I feel we used this in a lot of places." }, { "prediction": "I think we should remove this TODO.", "reference": "Update the docstring." }, { "prediction": "I think this should be `github.com/pkg/errors`", "reference": "delete the empty line \"github.com/pkg/errors\" should be grouped with other third party packages same for the rest" }, { "prediction": "Why is this change needed?", "reference": "Assigning capabilities to the field here is not the best idea. Semantically this field contains the capabilities returned by the browser after session start. So here we sould better amend capabilities and return them from `init` method to pass later to `startSession` method (that will assign the capabilities returned by the browser to the field)." }, { "prediction": "I think this should be `abort` instead of `finish`.", "reference": "Is this a breaking change, or is the API private?" }, { "prediction": "I think this should be `test_data = pd.read_json(\"./dumps/courseData.json\")`", "reference": "I don't think we need this dependency in this project right now" }, { "prediction": "I think this should be `cloud-run-events` instead of `cloud-run-events`", "reference": "I don't think this is necessary since `CommonLabels` is a public func and every component name is also public constant." }, { "prediction": "I think this should be `[String, Array]` instead of `[String, Array]`.", "reference": "The `_example` field should be updated to include an interpreter with an array value." }, { "prediction": "I think this should be in `caddyhttp/fastcgi/fastcgi.go` and not in `caddyhttp/fastcgi/fastcgi.go`.", "reference": "Put this in the godoc of SupportedProtocols instead. Preferably we would just use one map though. Why not just use this one?" }, { "prediction": "Why is this change needed?", "reference": "I'd feel a little safer if the first argument were a string, not a *string unless there's a particular reason for making it a pointer." }, { "prediction": "I think this should be `java.lang.reflect.InvocationTargetException`.", "reference": "Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC." }, { "prediction": "I don't think we need this import anymore.", "reference": "You can safely revert changes to this file." }, { "prediction": "Why is this removed?", "reference": "This deletion is unnecessary." }, { "prediction": "I think this should be `typeof smallImage === 'string'`", "reference": "I'm not a huge fan of this overloading of the prop; accepting very different types of arguments for props like this can be confusing, and wasn't part of the IB. I understand wanting to import the SVG directly, but the IB suggests using `${global._googlesitekitLegacyData.admin.assetsRoot}${userInputSuccessImage}` as the `src`/`smallImage` value here. It'd be great to refactor this to accept components directly in the future, but let's do that all-at-once rather than this hybrid approach that makes the API less clear." }, { "prediction": "I don't think we need this import.", "reference": "I've had this happen recently with IntelliJ, was this intentional?" }, { "prediction": "I think this should be ``.", "reference": "Order(1) vs Order(logN) -- not sure it's measurable at the ~200 element size of the table. All of the published comparisons start at ~1000 elements." }, { "prediction": "I think this should be `location_factory_factory` instead of `location_factory_factory`", "reference": "I don't know about this aliasing and 'factory'. Previous version was rather straightforward: `location.CreateLocationResolver`. Perhaps `location.CreateResolver` would be even better? What do we actually gain here from moving DI to a separate sub-package?" }, { "prediction": "I think this should be `engineThrowUp` instead of `engineThrowUp`", "reference": "Use `UpperCamelCase` for function names" }, { "prediction": "I think this should be `Number.isNaN(Number(value)) && Number(Number(value) >= 275761 || Number(value) < 0)`", "reference": "I'm not 100% sold on this idea but I like it in general. Nice compromise between using the 'Date' constructor where possible and falling back to the pre #5880 behavior when it makes sense. However, instead of `Number(value) < 0`, let's do `Number(value) < MIN_YEAR` because `new Date('-2017')` is perfectly valid in JS and I don't want to break the date behavior." }, { "prediction": "Why is this needed?", "reference": "Remember to close SOLR-11877 after this" }, { "prediction": "Why is this needed?", "reference": "this change should be reverted" }, { "prediction": "I don't think we need this mock anymore.", "reference": "This function signature is a bit complicated, some parameters are IN type (stopLoop which is modified from outside), others are OUT (registeredEvent channel which is modified inside function) I suggest the following signature -> SubscribeToRegistrationEvent(identityAddress) returns registeredEvent chan of type (RegisteredEvent not int), Unsubscribe func(), error (in case of any error). That way caller can always cance subscription if needed and check for any errors. Also - unsubscribe function hides any internal details how subscribtion is really implemented" }, { "prediction": "I don't think this is necessary.", "reference": "`.wav`?! cannot we use something slightly more modern and compressed instead? :) I dunno, like `.mp3` or `.aac` or `.ogg`..." }, { "prediction": "I think this should be `luaA_object_push(L, -4, \"swapped\", 2);`", "reference": "Wouldn't a single signal call be enough? (without the boolean even)" }, { "prediction": "I think this should be `if current_user && @note.author != @note.author %>`.", "reference": "I suspect that this whole block, which is going to be repeated a number of times, should probably be in a helper. I guess it would need to be given the object and the title and could probably figure out everything else from that?" }, { "prediction": "Do we need this?", "reference": "Should we expose this attribute in the Asciidoctor.js API ?" }, { "prediction": "I think this should be `Objects.equals(v, element._2)`", "reference": "I think contains on `Multimap` was broken - it should return true if one of the values is associated with the key? It that right" }, { "prediction": "I think this should be 20?", "reference": "delete this line" }, { "prediction": "Metrics/LineLength: Line is too long. [101/120]", "reference": "Presumably we no longer need `force: true` here." }, { "prediction": "I don't think we need to check if the pointer is non-NULL.", "reference": "HIP runtime is compiled using a C++ compiler. So comparison to both NULL as well as 0 does not make sense. Just comparing to NULL is sufficient." }, { "prediction": "I don't think we need to add the `help_url` here.", "reference": "these urls are still in `a` tags so we should probably include these links separately for a non-HTML version" }, { "prediction": "I don't think we need this lock anymore.", "reference": "That's fine though, meaning that you can send to this channel under the server lock. The internalSendLoop will pick up the change when the server lock is released (if loop is blocked trying to grab the server lock). Even the way you do it here (releasing the lock, sending, then reacquiring) does not guarantee that the internalSendLoop will have time to refresh in that interval." }, { "prediction": "I think this should be `chromium:enableDownloading` instead of `chromium:enableDownloading`.", "reference": "The name `enableDownloading` implies this is a boolean capability. How about `downloadDir`?" }, { "prediction": "Why is this deprecated?", "reference": "Found one internal team is using this method. Will coordinate with them about the migration solution." }, { "prediction": "I think this should be `DD_HTTP_SERVER_ERROR_STATUSES` instead of `DD_HTTP_CLIENT_ERROR_STATUSES`.", "reference": "The field `HttpServerErrorCodes` should be called `HttpServerErrorStatuses`" }, { "prediction": "I think this should be `rules.yaml` instead of `rules.yaml`.", "reference": "Can you please make each of these in a separate line. It will be easier to keep them sorted, and add/remove." }, { "prediction": "I think this should be `allowOverwrite` and not `allowOverwrite`.", "reference": "should we error instead of silently ignoring the `cleanup` param? it defaults to `false`, so someone must have explicitly set it to `true`" }, { "prediction": "I think this should be `archive root directory missing: expected a 'root' directory but got `archive.File[0].Name`", "reference": "There is no specific requirement that the root be called `root`, just that there is a single root directory and that it be the first entry in the zip." }, { "prediction": "I think this should be `current_page?(me_path) && current_user && current_user.requires_profile_attention?`", "reference": "perhaps we should encapsulate this logic in a helper method w a test?" }, { "prediction": "I think this should be `beaker/options/#{file}` instead of `beaker/options/`", "reference": "Now that we're only using this repo as a Gem you shouldn't need to `require` an expanded local file path like below." }, { "prediction": "I don't think we need to use `Long.valueOf(granularity.between(EPOCH, timestamp)).intValue()` here.", "reference": "This isn't necessarily a year. It may be months, days, or hours. Can we return `intValue()` directly instead?" }, { "prediction": "Why is this removed?", "reference": "this is redundant because it gets logged immediately on entering the handleContainerChange function" }, { "prediction": "I think we should use `model.NotificationEventType_EVENT_DEPLOYMENT_WAIT_APPROVAL.String()` instead of `model.NotificationEventType_EVENT_DEPLOYMENT_WAIT_APPROVAL`.", "reference": "`ds.GenericDeploymentConfig.DeploymentNotification` in L128 is nullable." }, { "prediction": "I think this should be `final ProtocolContext protocolContext = CliqueHelpers.getProtocolContext(blockCreatedLocally, header);`", "reference": "this shouldn't be exposed here - this class isn't a carriage for this - its used internally to determine if/how we can mine." }, { "prediction": "Why is this removed?", "reference": "It's fine to leave these checks in. It'll make the exception come from `FirefoxDriver`, and that's probably clearer to a user." }, { "prediction": "Use 2 (not 4) spaces for indentation.", "reference": "We don't want to include the `IntegrationSpecHelper` for models...mind moving this line out of the loop to be `config.include EnvironmentSpecHelper, type: :model`?" }, { "prediction": "I think this should be `os.Chmod(file.Name(), 0666)`", "reference": "Please check the return on these." }, { "prediction": "I think this should be `self.local.add_tarball(name, filename);`", "reference": "Do we need `==` for true?" }, { "prediction": "I think this should be `cur_param` instead of `momentum`.", "reference": "Changing the default value may cause BC-breaking. Suggest changing this value in config." }, { "prediction": "I think this should be `int(slider_pos)` instead of `int(slider_pos)`", "reference": "how does that happen?" }, { "prediction": "Why is this needed?", "reference": "This is gross/clever. :-)" }, { "prediction": "Align the parameters of a method call if they span more than one line.
Space inside } missing.", "reference": "Take a look at the name of this file. Definitely copy and " }, { "prediction": "I think this should be `resp.StatusCode == 503`.", "reference": "Can you check with @mahebbar how to work this error. Should be different from 404." }, { "prediction": "Why is this change needed?", "reference": "Do we still need the upper bound `<3.9`?" }, { "prediction": "Why not use `dirname(__DIR__, 3)` instead of `realpath(dirname(__DIR__, 3) . DIRECTORY_SEPARATOR. 'bin' . DIRECTORY_SEPARATOR. 'psalm')`?", "reference": "Does this mean `vendor/bin/psalm` is not a symlink (or whatever equivalent Windows has for symlinks) on Windows?" }, { "prediction": "I think this should be `aws_test` instead of `aws_test`.", "reference": "@lpabon having a separate package name `aws_test` allows to test the package as if the tester was an external package. If the test package name is the same as the package being tested, the test package can also use methods and variables not exposed to the eventual user." }, { "prediction": "Why is this removed?", "reference": "The exporter should still be able to test these histogram instrument kinds, right? Is there another reason to remove these?" }, { "prediction": "I think this should be `eval.totalTxBytes = 0` instead of `eval.totalTxBytes = 0`", "reference": "should this increment eval.Round somehow?" }, { "prediction": "Line is too long. [89/80]", "reference": "Although this change looks good. Maybe there are other inconsistent cases too?" }, { "prediction": "Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.", "reference": "This is a way better method name." }, { "prediction": "I think this should be `t(\"marketing.show.language_flash\", language: params[:language])` instead of `t(\"marketing.show.language_flash\", language: params[:language])`", "reference": "Prefer single-quoted strings when you don't need string interpolation or special symbols." }, { "prediction": "I think this should be `Array.isArray(options)` instead of `Array.isArray(options)`", "reference": "I was wondering if this should allow per role specification, instead of (or in addition to) a generic \"allowed everywhere\". So you could do: `{ separator: ['aria-valuenow', 'aria-valuemin', 'aria-valuemax'] }`. You could still allow the array, and you could add a wildcard option for the \"generic\" case you've got now: `{ '*': ['always-allowed'] }`." }, { "prediction": "I think we should be able to use `wasHiveString_(FALSE)` instead of `wasHiveString_(FALSE)` here.", "reference": "I'm confused by the name. The string was a Hive string but it isn't any longer? Why should we care? (I imagine I'll find the answer later... there is some different semantic that we want downstream...)" }, { "prediction": "I don't think this is needed.", "reference": "Could you please leave the explicit imports?" }, { "prediction": "I think this should be `iproto` instead of `iproto`", "reference": "Why need alias?" }, { "prediction": "I think this should be `tlf.GetTLFID`?", "reference": "Shouldn't this be a `libfs.nullIDGetter` (exported, of course)?" }, { "prediction": "I think this should be `tealLogicSigSizeTooLarge` instead of `tealAppSizeTooLarge`", "reference": "I dislike the messages.go pattern; the strings are only used once and make more sense in context. The other two added reportErrorf() calls in clerk.go have inline strings." }, { "prediction": "Why did you remove this line?", "reference": "Seems we don't need it anymore." }, { "prediction": "Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "This might cause problems with the weird way we publish Guidance and Groups in the UI. We will have to make sure that UAT is thorough." }, { "prediction": "Why is this change needed?", "reference": "this default needs to be on order 1 minute, I'm not sure why we defaulted to 1 hour below..." }, { "prediction": "I think this should be `if iss.Email != \"\" && iss.Email != \"\" {`", "reference": "I figure to make `{env.*}` work, right? I can't think of any other placeholder that makes sense here" }, { "prediction": "Why is this needed?", "reference": "Why change the port from 0 to getAvailablePort()?" }, { "prediction": "Why is this change needed?", "reference": "For me would be great don't repeat timeout sending in every get_locator call. Looks like it should be sent into LocatorsManager init. And possibly it should me non mandatory, something like that: `def __init__ (self, locators, timeout=60):`" }, { "prediction": "I think this should be `projectName` instead of `projectFlag`.", "reference": "I feel like since now we don't initiate the `opts.projectName` with `opts.ProjectName()`, which means `opts.projectName` and `opts.ProjectName()` they don't necessarily equal to each other, we need to also substitute all usage of `opts.ProjectName()` within `Ask()`, `Validate()`, and `Execute()` to `opts.projectName`. Otherwise if `-p` is set, `opts.ProjectName()` will get expired." }, { "prediction": "I think this should be `bytes.Length == 0` instead of `bytes?.Length == 0`", "reference": "why do we thinkg that an empty string is ok to return from this method? I think the null should never be passed in here in the first place" }, { "prediction": "Why is this removed?", "reference": "nit: can remove this `else` since we return from the condition above." }, { "prediction": "Why is this removed?", "reference": "You missed `Write(...)`! I'm kidding ofc." }, { "prediction": "I don't think we need to check if `subscription.stripe_customer_id` is present?", "reference": "Was there a customer who had this set to an empty string?" }, { "prediction": "I think this should be `current_approver_email_address` instead of `current_approver_email_address`", "reference": "I know we have the `reporter` spec below, but what about a unit test for this to explain reasoning behind logic? If I were going to update this decorator, I would assume it wasn't covered by tests because there is no unit test." }, { "prediction": "I don't think we need this interface.", "reference": "it's better to be : void attach(String name, Part part);" }, { "prediction": "Why is this change needed?", "reference": "I didn't see where the IOException can get thrown, is this just to match the V1 reader?" }, { "prediction": "I think this should be `const bool forceRDKit = false;`", "reference": "We normally suppress this warning with `RDUSED_PARAM(forceRDKit)`" }, { "prediction": "I don't think this is a good idea, but I think it's better to use `map` instead of `map` here.", "reference": "What if `Game::getPlayerByNameWildcard` had not been called before. It would not find a player, wouldn't it?" }, { "prediction": "I think this should be \"Patch Required\" instead of \"Patch Required\"", "reference": "Why upper case \"R\"?" }, { "prediction": "I think this should be `return false, fmt.Errorf(\"check if service requires building from local Dockerfile: %w\", err)`.", "reference": "Does this need to return an error or could it return `false, nil`?" }, { "prediction": "Why is this protected?", "reference": "Can you not change those scopes in public API classes? This applies here and in other places -- protected changed to package-scope for source is not really an API-compatible change." }, { "prediction": "Why is this change needed?", "reference": "this parameter is only used in POST, please use `getRequest()->request->get('...');` Thanks" }, { "prediction": "I don't think we need to add the `filename` parameter here.", "reference": "Problem number 1: Scoped packages would have a `/` character here. Changing this to `validatePackage` resolves the 403." }, { "prediction": "I think this should be `try: raise KeyError` instead of `except KeyError`", "reference": "I don't quite get why there would be key errors: ``deep_mapped`` is a clone of ``self`` and ``k`` comes from ``self.items()`` so why would the key ever be rejected?" }, { "prediction": "I think this should be `req.ChainID != 0`", "reference": "this chain ID determines only from which chain to withdraw, therefore your changes do not accomplish what you want them to accomplish. You'll need changes to `func (aps *hermesPromiseSettler) Withdraw(chainID int64, providerID identity.Identity, hermesID, beneficiary common.Address) error`. The method probably has to include two chain ids: to and from. Currently, the method internally uses: `aps.config.L1ChainID` -> the chain to withdraw to `chainID` -> the chainID that was passed as the chain that the withdrawal is originating from." }, { "prediction": "I think this should be `ContextWithRemoteSpanContext(ctx, tc.extract(supplier))`", "reference": "If instead we had `TraceContext.extract` return a bool value as a second return value, we could avoid the byte array comparison in `TraceID.IsValid`. Did you consider that alternative?" }, { "prediction": "I think this should be `items[type].maxItems` instead of `items[type].maxItems`", "reference": "here shouldn't we use `depotFreeLimit`?" }, { "prediction": "I think this should be `<%= SecureRandom.hex(64)`", "reference": "Could we use the Rails application's secret token instead? Do we actually need our own here?" }, { "prediction": "I think this test should be `assertRaises(TypeError, lambda: kdf.a.groupby('a', axis=1))`", "reference": "so should be fixed here also" }, { "prediction": "I don't think this should be `sizeof(dr_mcontext_t)`", "reference": "I would just remove this assert as it's going to get un-maintainable with a long list of valid sizes. Ditto below." }, { "prediction": "I think this should be `/var/lib/ecs` instead of `/var/lib/ecs`", "reference": "`HostDataDir` is misleading. Can we rename it to something more relevant ? The constant should also be moved up and reused as necessary." }, { "prediction": "I think this should be a constant.", "reference": "I still feel like we are double-counting the outer IP header here (once in `defaultMTUGRE` and once in `ipsecESPOverhead`) but I'm not that familiar with IPsec." }, { "prediction": "I think this should be `T` instead of `T`", "reference": "Not sure what benefit we gain by extending BaseProcessor here, as this seems to be defining a new OnEnd method. Could we modify MeasurementItem to have all the things, and then MeasurementProcessor can be simply extending BaseProcessor (not blocking. just noting some observations in the PR :) )" }, { "prediction": "I think this should be `os.Path` or `os.Path`", "reference": "This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards." }, { "prediction": "I don't think this is a good idea.", "reference": "This seems like a more appropriate message under `ListenAndServe`. WDYT?" }, { "prediction": "Why is this removed?", "reference": "Is this not required?" }, { "prediction": "I think this should be `isset($this->entity['search']['sort']['field']) ? $this->entity['search']['sort']['field'] : $this->request->query->get('sortField') : $this->request->query->get('sortDirection')`", "reference": "We should start thinking of an object that encapsulates this information :) we might need more arguments in the future." }, { "prediction": "I don't think this is necessary.", "reference": "Given that we are (conceptually) searching across multiple self-dependencies, all we can say is that we didn't have a self dependency in which *both* source and dest masks were correct. Since the spec doesn't imagine this case, the valid usage statement assume we can differentiate only wrong source from only wrong dest within a *single* self-dependency -- which we can't across multiple (at least not meaningfully)... so we always return both the source/dest VUID's if we can't find a self-dependency in with *both* are correct." }, { "prediction": "Why is this change needed?", "reference": "rename? MiningCoordinator always exists" }, { "prediction": "I think this should be `api.offline_mode = plugins.getConfig(\"api\").offline_mode;`", "reference": "Here would be the same case you don't need to call `loadConfigs`, but you would need to reread configs using `getConfig` on each getHost function call, not once per file." }, { "prediction": "I think this should be `d.folder.renameAndDeletionLock.Lock()`", "reference": "Unlocking with defer means that this lock is still held curing the call to forgetNode(), below, which I see attempts to acquire `f.mu`, which looks dangerous to me." }, { "prediction": "Why is this change needed?", "reference": "Does anyone still use the cst out of this method? If not consider deleting" }, { "prediction": "I think this should be `https://www.youtube.com/watch?v=9J2OjH8Ao_A` instead of `https://www.youtube.com/watch?v=9J2OjH8Ao_A`", "reference": "Line is too long. [97/80]" }, { "prediction": "I think this should be `io.BytesIO` instead of `io.BytesIO`", "reference": "This seems unused." }, { "prediction": "I think this should be `panic(\"unsupport os-release\")`", "reference": "@luguanglong , Thanks for the fix, can you re-phrase it to sound better something like \"This OS version is currently un-supported by keadm\"" }, { "prediction": "Why do you need this?", "reference": "should probably be called `_DeleteFpInfoAttr` because it removes it. Cleaning gives the impression it is still there. I would also move this to the end of the function `GetAtomicWeightsForFingerprint`." }, { "prediction": "I think this should be `VK_PIPELINE_BIND_POINT_GRAPHICS` and `VK_PIPELINE_BIND_POINT_COMPUTE` and `VK_PIPELINE_BIND_POINT_RAY_TRACING_NV`", "reference": "nit, can we use `VK_PIPELINE_BIND_POINT_RAY_TRACING_KHR` here (granted it isn't else where, maybe worth fixing here or in separate PR)" }, { "prediction": "Align the parameters of a method call if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "This will need to be updated in the upcase-exercises repo as well." }, { "prediction": "Line is too long. [98/80]", "reference": "Think it's worth extracting this to `Exercise#complete?`?" }, { "prediction": "Why is this removed?", "reference": "This is still a potentially useful public method - should we remove such methods?" }, { "prediction": "Why not just use `alpha` instead of `UNSET_RELEASE_LEVEL`?", "reference": "I don't understand this change, what is happening here?" }, { "prediction": "I think this should be `version=int(self.obj.excelCellObject.Application.Version.split('.')[0])` instead of `version=int(self.obj.excelCellObject.Application.Version.split('.')[0])`", "reference": "I think its worth stating this is `versionMajor`" }, { "prediction": "I think this should be `SetConfigurableConsensus` or something like `SetConfigurableConsensus`", "reference": "rebuild: say loads and merges" }, { "prediction": "Why is this removed?", "reference": "Why was this removed here (also in the other file)? Shouldn't we import them so that the reference in the docs below is interpreted correctly?" }, { "prediction": "Why is this removed?", "reference": "I'd prefer to have a blank line between the class declaration and its first member. Is it possible?" }, { "prediction": "Why is this change needed?", "reference": "Is it really LEGACY_HELLO if we are using the most up to date HELLO? Perhaps `MONGOS_HELLO` would work here?" }, { "prediction": "(style) line over 80 characters", "reference": "I am afraid this is going to cause problems on Windows where it is not uncommon to have injected threads (CTRL_SHUTDOWN, CTRL_LOGOFF, etc.) we have no privileges to suspend -- and thus retrying will just fail again, and with the new \"synchall failure is fatal and should kill the process\" approach it turns what used to work for us on Windows into process death." }, { "prediction": "I think this should be `--mac_installer_signing_identifier `", "reference": "think it should only be in create_dist" }, { "prediction": "I think this should be `if int(cport.HostPort) > 0 {`", "reference": "Do you plan to support Pod spec change? Like hostPort is added/removed later after Pod creation?" }, { "prediction": "I think this should be `dokan.CreateStatus` instead of `dokan.ExistingDir`", "reference": "Is this behavior correct? It used to return `true`, which should map to `dokan.ExistingDir`. Was that previously a bug?" }, { "prediction": "I think this should be `osrm::util::Log() << \"No shared memory regions found. Try running osrm-datastore\"`.", "reference": "What about just printing an empty list in this case? That would make the output more predictable." }, { "prediction": "I think this should be `this.container = document.querySelector('.gh-editor-container')[0];`", "reference": "I looked and couldn't find any usage of `container` in any of the editor component files (js or hbs), so I assume this was used once and didn't get removed?" }, { "prediction": "Why is this needed?", "reference": "I just updated a number of sites using older versions of Roots onto WP 3.6 and this little function change was required. Multiple search bars were displaying when I used the search widget in a widgetized sidebar. Updated the roots_get_search_form as seen in this change resolved it for me!" }, { "prediction": "Why is this needed?", "reference": "Fixes test failed in some cases" }, { "prediction": "I don't think we should remove this.", "reference": "what's the prod url for this? just curious. @amirsaber" }, { "prediction": "I think this should be `azkaban.jvm.cmd.args` instead of `azkaban.jvm.cmd.args`.", "reference": "Can you please change this to azkaban.jobs.java.opts?" }, { "prediction": "I think this should be `__( 'Source:', 'google-site-kit' )`", "reference": "Here is another concatenation which should be updated. Even though `Source:` and the link are essentially separate, it isn't RTL friendly. This would be another good use for `createInterpolateElement` I think so that we wouldn't need to include all of the classnames in the translation string (or extract them to a placeholder). That would allow us to use the `Link` component as well, rather than using its resulting HTML as a string which will be a pain to maintain if we were to make changes to the base `Link` component." }, { "prediction": "I think this should be `#if NETSTANDARD1_3`", "reference": "I would add an overload `GetCancelledZeroTask()` which calls `GetCancelledZeroTask(CancellationToken.None)`. This is cleaner than requiring the caller to pass `default(CancellationToken)` or `CancellationToken.None`." }, { "prediction": "I don't think you need to check for NULL here.", "reference": "Would it be equivalent to check if `chain != nullptr` below? Not suggesting a change, just curious." }, { "prediction": "Why is this change needed?", "reference": "Should probably do `auto this_l (shared_from_this ());` and pass/use that instead of `this`. Same a few other places. IOW, replace both `shared_from_this()` and `this` with `this_l`" }, { "prediction": "I don't think we need to change the message to `The first word in a function's description should be a third-person verb (eg \"runs\" not \"run\")`.", "reference": "And here. Please, use `'` for apostrophes in changed strings in this file." }, { "prediction": "Why do we need to simulate execution?", "reference": "assignments should only be cuddled with other assignments (from `wsl`)" }, { "prediction": "I think this should be `DefaultNewBlockDataVersion` instead of `DefaultNewBlockDataVersion`", "reference": "Please move this to `block_types.go`." }, { "prediction": "Why is this removed?", "reference": "So this is not needed anymore for all attributes?" }, { "prediction": "I think this should be \"Failed to add OpenTelemetry Tracing to ServiceCollection. OpenTelemetry Tracing to ServiceCollection. OpenTelemetry Tracing will not work.\"", "reference": "Happy to get suggestion for better messaging here. Here's what I intended to convey: Something is wrong - the Exception is a hint to what might be the cause The impact of that - tracing wont work." }, { "prediction": "I think this should be `start_moto_server` instead of `start_moto_server`.", "reference": "I think we can remove this function, right? (duplicate with `ses_starter.py`)" }, { "prediction": "Why do we need this?", "reference": "With this fix, I am not even sure we need to overwrite this function." }, { "prediction": "I don't think we need to do this in the `package_entry.py` file.", "reference": "Why not just import this from `data_transfer`? As a rule copying the same code twice is not a good idea. Also: please run `pylint` on all files in this PR." }, { "prediction": "I think this should be `expect(parser.parse_args(args))`", "reference": "You've got an absolute path here referencing your home dir :-)." }, { "prediction": "Why is this change needed?", "reference": "Maybe I should do some sorting so that these properties don't keep moving around..." }, { "prediction": "Why is this removed?", "reference": "Can we keep this test anyway, as it's part of the spec?" }, { "prediction": "I think this should be `class ErgonodeMailerBundle` instead of `AbstractModule`.", "reference": "Can be removed" }, { "prediction": "Why is this needed?", "reference": "It's a minor quibble I know, but I like having the imports ordered by lengt" }, { "prediction": "I think this should be `responseEx.setContentType(produceProcessor.getName() + \"; charset=utf-8\");`", "reference": "It's better to get the charset from context or other setting to let the user override it." }, { "prediction": "Why is this change needed?", "reference": "this filename as well needs change" }, { "prediction": "I think this should be `AccessKeyID` and `SecretAccessKeySelector`", "reference": "I think we want to remove `omitempty` here" }, { "prediction": "I think this should be a `defer handler.Close()`", "reference": "You cannot move this here because it breaks detach. Just call `tty.Close()` before returning the error from start" }, { "prediction": "I think this should be `implicit: ['table']` instead of `implicit: ['table']`", "reference": "I updated only the implicit roles who needed a update for this new rule to validate." }, { "prediction": "I think this should be `reflect` and `sync`", "reference": "> // Code generated by protoc-gen-go. DO NOT EDIT." }, { "prediction": "I think this should be `skipOSConfig` instead of `osconfig_not_supported`.", "reference": "minor: skipOSConfigMetadata, otherwise, the name sounds like a boolean" }, { "prediction": "I think this should be `SyndTypeUtils.enclosureTypeValid(type)`", "reference": "~~I think lines 65-67 should be moved into this else clause after `type = ...` Else, it is a bit confusing why we check the enclose type validity a second time~~ Nevermind, will do some refactoring, myself. But thanks for \"fixing\" this!" }, { "prediction": "I think this should be a `defer response.Body.Close()`", "reference": "`sessions := endpoints.SessionsDTO{}` and using only `sessions` should be simpler." }, { "prediction": "(style) line over 80 characters", "reference": "These need to be in the other order to avoid crashing when dcontext == GLOBAL_DCONTEXT (==-1)" }, { "prediction": "I think this should be `ConfigureKestrel` instead of `ConfigureKestrel`", "reference": "Why not change the other samples?" }, { "prediction": "I think this should be `[headers~=\"${id}\"]` instead of `[headers~=\"${id}\"]`", "reference": "Indentation is mixed up here due to spaces/tabs, I'm guessing." }, { "prediction": "(style) line over 80 characters", "reference": "Should we provide a little more context in the error message? Maybe throw in something about what operation was being performed?" }, { "prediction": "I think this should be `array_key_exists('settings', $configuration);`", "reference": "Project standard is spaces, not tabs. Please fix and then we can merge this." }, { "prediction": "I think this should be `clientlist.h` instead of `clientlist.h`.", "reference": "@hgtw is there anything we're worried about with regards to using this cache? Do we want to do staged testing around expeditions before we merge? Curious your thoughts here" }, { "prediction": "Why is this change needed?", "reference": "The purpose of this was to allow pushing filters into the manifest files if we ever use a format other than Parquet. I think overall this is a good change because we can add it back later. Just wanted to note why the unused argument was there." }, { "prediction": "I think this should be `obj.is_a?(::BigDecimal) && Mongoid.map_big_decimal_to_decimal128.new(obj)`", "reference": "I think BSON::Decimal128 should always be serialized as Decimal128 regardless of config option." }, { "prediction": "Line is too long. [89/80]", "reference": "We should probably just move the `require 'bolt/plan_creator'` in `Bolt::CLI` to `Bolt::Application` so it will already be loaded." }, { "prediction": "I don't think we want to run more than 20 iterations, but I don't think we want to run more than 20 iterations. I don't think we want to run more than 20 iterations, but I don't think we want to run more than 20 iterations.", "reference": ">20 [](start = 45, length = 2) Can we override this at runtime? Maybe it should be a command line option with default." }, { "prediction": "Why is this removed?", "reference": "can just remove it ?" }, { "prediction": "I think this should be done for mirrors, not for mirrors.", "reference": "Better call it `CleanUpMirrorInfo`?" }, { "prediction": "I think this should be `Start` instead of `Start`?", "reference": "@shannonwells is there still something missing here?" }, { "prediction": "I don't think this is a good idea to add a time limit for stress testing, but I think it would be better to add a time limit for stress testing, if any (default: nil).", "reference": "This could be more indicative of what it is... e.g... `stresstest_time_limit`" }, { "prediction": "Why is this removed?", "reference": "Shouldn't we do a `reader_payload_pool_.reset()` here?" }, { "prediction": "Why is this change needed?", "reference": "I'd prefer the nomenclature less tightly coupled to DRAND throughout. I played with renaming the `drand` package to `beacon` but it was too much noise in this change." }, { "prediction": "I think this should be `self._current_key`?", "reference": "I think I would prefer you declare `self._current_key=None` in the constructor and just return `self._current_key`. That way you can prevent anyone from overwriting `current_key` without needing to use `getattr` here." }, { "prediction": "I think this should be `annotationMode` or `rawMode`.", "reference": "I guess I like the name `mode` okay. I can't think of anything better." }, { "prediction": "Shouldn't this be `if timeout <= 0`?", "reference": "I would create a new method (NewStepWithDefaultTimeout?) for this purpose because timeout<=0 looks like a hidden logic" }, { "prediction": "I think this should be `max_length` instead of `max_length`", "reference": "Are these limit changes related?" }, { "prediction": "I think this should be `from scapy.consts import LOOPBACK_INTERFACE`", "reference": "Don't you mean `import scapy.consts`?" }, { "prediction": "I think this should be `rollbackPrimary` instead of `rollbackPrimary`", "reference": "`ctx` is unused in rollbackPrimary" }, { "prediction": "Why is this change needed?", "reference": "This is not what title says." }, { "prediction": "I don't think we need this interface. It is used when it is used to make one or more operations to the AST.", "reference": "a fix applies several fixes? maybe this should simply be `applyToNode`" }, { "prediction": "I think this should be `fakeGetClientset`", "reference": "U1000: func `fakeGetOk` is unused (from `unused`)" }, { "prediction": "I think this should be `k8s.io/client-go/util/retry`", "reference": "Because there is a \"k8s.io/client-go/tools/cache\" below, we can sort out all the \"imports\" here." }, { "prediction": "I think this should be `github.com/aws/aws-sdk-go/aws` or `github.com/aws/aws-sdk-go/aws`", "reference": "Nit should be using `goimports` to format the import statements with standard libary imports first, new line, followed by non-standard library imports." }, { "prediction": "I think this should be `if o.PipelineSecret != \"\" && o.PipelineSecret != \"\" {`", "reference": "Do we not have tests for pipeline delete " }, { "prediction": "I think this should be `-appendToFile`", "reference": "Good that you mention this constraint in the docstring :)" }, { "prediction": "I think we should move this to the top of the file. I think we should move it to the top of the file.", "reference": "remove this blank?" }, { "prediction": "I think this should be `computedNumOfActivePartiions_(-1)` instead of `computedNumOfActivePartiions_(-1)`", "reference": "Partitions is misspelled 8 times in this commit, might make sense to fix the spelling for all of those." }, { "prediction": "I don't think you need to use `objreg` here, but I think it would be better to use `qutescheme` instead of `qutescheme`.", "reference": "Please remove this blank line - those are only used to group Python/third-party/qutebrowser imports." }, { "prediction": "I think this should be `false` instead of `true`.", "reference": "`insecure` is a global variable (from `gochecknoglobals`)" }, { "prediction": "I think this should be `if setting.Repository.DisableHttpGit {` or `if setting.Repository.DisableHttpGit {`", "reference": "Same as above (HTTP in upper-case)" }, { "prediction": "Shouldn't this be `getReferenceUrl`?", "reference": "This is getting repetitive maybe you could introduce an abstract test case with a `getExpectedUrl($providerReference)` method ?" }, { "prediction": "I think this should be `MakeFunc(typ Type, fn func(args []Value, results []Value) []Value)`", "reference": "I do not think returning `Value{}` is correct here. For example, `reflect.MakeFunc(...).Kind()` would return `reflect.Invalid` instead of `reflect.Func`. Therefore, I think this should panic instead." }, { "prediction": "Why is this change needed?", "reference": "Does this work for Custom Elements? iirc we're lacking test cases for them. /cc @andrewiggins @developit" }, { "prediction": "Why is this change needed?", "reference": "Same change just above?" }, { "prediction": "I think this should be `self.Promise = undefined;` instead of `self.Promise = undefined;`", "reference": "I suppose `apploader.js` isn't used by WebWorkers. So `self` will always be `window` here." }, { "prediction": "I think we should remove the `skip_targets` check here.", "reference": "Since this var is no longer defined we should remove the `if skip_targets.any?` bit below." }, { "prediction": "I think this should be `if ARN_TO_LAMBDA.get(arn).qualifier_exists(qualifier): return '{}:{}'.format(arn, qualifier)`", "reference": "I think we should `return arn` as a fallback at the end of this function (otherwise the `['Resource']` entry below could become `None`)." }, { "prediction": "I think this should be `if np.socketProtect == nil {`", "reference": "Why session is started at all, if you need to shut it down e.g. DI should launch noopSession" }, { "prediction": "Why is this removed?", "reference": "nit: can we rename the interface to `wsFileDeleter`" }, { "prediction": "I think this should be `GroupMemberSet` instead of `GroupMemberPodSet`.", "reference": "Why target cannot be external endpoints?" }, { "prediction": "I think this should be `.auto_`", "reference": "We use a suffix \".AUTOCREATED\" for configsets, maybe we can use the same here?" }, { "prediction": "Why is this change needed?", "reference": "This one won't be disposed. Should be (something like) `using var openTelemetry = OpenTelemetrySdk.EnableOpenTelemetry(` no?" }, { "prediction": "Why is this removed?", "reference": "Why this is in the diff?" }, { "prediction": "I think this should be `VolumeGroupCreate` instead of `VolumeGroupCreate`.", "reference": "How is status determined? When the user calls CloudBackupCreate( src_volume_id ) they can then call CloudBackupStatus( src_volume_id ) Is there something similar for this new API?" }, { "prediction": "Is there a reason we don't know the _children this VNode should receive so it's safer to unmount them?", "reference": "We could pass `excessDomChildren` to `options._catchError` and only do this if an error-boundary catches the error. Not entirely sure if that's better." }, { "prediction": "Why is this change needed?", "reference": "In php8 named parameters were introduced and now it is required to match called method parameter name when setting parameters by array destructing or call_user_func_array() etc." }, { "prediction": "I think this should be `if !sc.IsValid() { return ctx }`", "reference": "If instead we had `B3.extractSingleHeader` and `B3.extract` return a bool value as a second return value, we could avoid the byte array comparison in `TraceID.IsValid`. Did you consider that alternative?" }, { "prediction": "Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "I think this is more of a semantic difference than a typo - `weiter hinzufgen` is like `continue adding` whereas `weitere hinzufgen` is like `add more`. I think it makes sense to change it though " }, { "prediction": "I think this should be `test_records_can_be_created_after_deletion`", "reference": "nit: 200 is superfluous" }, { "prediction": "Why is this change needed?", "reference": "This is testing `unreserved keyword`" }, { "prediction": "I think this should be `S2` instead of `S2`.", "reference": "paramsNatOrigin doesn't include sUVtoST. I would just remove that definition for now" }, { "prediction": "I think this should be `initBlockRetrievalQueueTest` instead of `initBlockRetrievalQueueTest`.", "reference": "It feels like the test should be waiting for the prefetcher to shut down, but I don't have a great reason why other than that it might be confusing for debugging if there are still goroutines from old prefetchers lying. But I guess since `TogglePrefetcher(false)` doesn't actually set the prefetcher to nil, the queue shutdown method will still end up waiting for the shutdown to finish. If that sounds right, nevermind me." }, { "prediction": "I think this should be `ListAccessKeys.java` and `ListAccessKeys.java`", "reference": "AWS Identity and Access Management (IAM)" }, { "prediction": "I think this should be `cloudsql_project_resource_name`", "reference": "As a long term thing, would it make sense to move the resource names as keys under the requirements map?" }, { "prediction": "Why is this change needed?", "reference": "That doesn't fix the whole problem. The issue lays in this line right here, not the one above. There are two problems with this line: 1. It finds things that aren't cells in the table 2. if it doesn't find anything, it shouldn't return empty here, but continue down to look for row/ column headers." }, { "prediction": "I think this should be `project.getAllprojects().stream()` instead of `project.getAllprojects().collect(Collectors.toSet());`", "reference": "I am pretty sure that this is infinite recursion as getAllProjects returns the project itself." }, { "prediction": "This should be `data-lists` instead of `data-lists`.", "reference": "Something I didn't catch before I merged this PR, is the hyphenated constant a problem? E.g. should \"data-lists\" be \"data_lists\"? @paulkaplan" }, { "prediction": "I don't think we need to do this in a separate PR, but I think it would be better to use `conf.use_winpcapy` and `conf.use_dnet` and `conf.use_dnet` as well.", "reference": "Can you write the test as `if not (conf.use_winpcapy or conf.use_pcap or conf.use_dnet):`" }, { "prediction": "I think this should be `ForeignAsset`?", "reference": "we have to include foreign assets on the repository directly because they don't belong to a job? This seems very awkward... Is this a step towards the job-less assets on the repository? Did you consider having `build_asset_job` take in a set of foreign assets instead? I suppose we would then need to subclass it to be a more special `AssetJobDefinition` that can keep track of them." }, { "prediction": "Why is this change needed?", "reference": "`-Wstringop-truncation` is a new kind of error detector introduced in GCC 8. As for this patch, these are two false-positives though." }, { "prediction": "I think this is a bit confusing to me, but I don't think it's a good idea to add a `credential_type` field to the error message.", "reference": "Can we port this error msg to v2 too? This one is better, as it explicitly states what sources are allowed." }, { "prediction": "I think this should be `const { ReadPreference } = require('../..');`", "reference": "The convention so far has been to require directly from the defining file (in this case `../../read_preference') . I think the concern has been mostly about the potential for circular dependency cycles" }, { "prediction": "I think this should be `self.to_float32 = to_float32` and `self.color_type = color_type`", "reference": "I suggest expanding dims here to simplify the formatting." }, { "prediction": "I think this should be `kinto/config/kinto.ini`", "reference": "Why do you need to specify the kinto prefix here?" }, { "prediction": "Why is this change needed?", "reference": "The `!r` is unnecessary." }, { "prediction": "I don't think we need to check if sasToken is not empty?", "reference": "I didn't see existing tests for this `OpenBucketURL`. Not sure if it's easy to do without mocking these `opener` calls." }, { "prediction": "I think this should be `public bool PreparerNeeded;`", "reference": "Should we default to `true` ?" }, { "prediction": "I think this should be `consensus/fsm` instead of `consensus/fsm`", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I think this should be `@wordpress/default` instead of `@wordpress/default`.", "reference": "Shouldn't these options also include `@babel/preset-env`? Also I see you set `babelrc` to `false`, could we rely on our existing `.babelrc` file? Feels like some duplicate configuration otherwise." }, { "prediction": "Why is this change needed?", "reference": "Nit: We can use `%s` since `disconnectReason` is a string." }, { "prediction": "why not use `boosting_type='rgf'`?", "reference": "I think it's better to create a new example" }, { "prediction": "Why is this change needed?", "reference": "The stages are correct, but the more forgiving `kAttachmentRasterOrder` should be used, based on a review of the spec. That should give the same effect of suppressing the false positive conflict between the DEPTH R/W and resolve. > End-of-subpass multisample resolves are treated as color attachment writes for the purposes of synchronization. This applies to resolve operations for both color and depth/stencil attachments. That is, they are considered to execute in the VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT pipeline stage and their writes are synchronized with VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT. Synchronization between rendering within a subpass and any resolve operations at the end of the subpass occurs automatically, without need for explicit dependencies or pipeline barriers." }, { "prediction": "I think this should be `--SO3H` instead of `--SO3H`", "reference": "To be consistent, I think it should actually just be a single `-`" }, { "prediction": "I don't think we need to import `flask` here.", "reference": "this seems extraneous." }, { "prediction": "Why is this change needed?", "reference": "Ah, I see here that 'LongDomain' is defined as something that contains a subdomain segment that is `maxLengthOfDomainSegment` long (which I think is 63 characters) - I don't think any public ACME servers/Let's Encrypt's staging environment has a restriction on this? if it does, and the 'pebble' based ACME server does not, then Pebble needs modifying to also fail in these cases as it aims to replicate the ACME RFC as closely as possible" }, { "prediction": "I think this should be `r-#{r_version}_1_amd64.deb` instead of `r-#{r_version}_1_amd64.deb`", "reference": "I think you need `-y` here to prevent a user confirmation prompt" }, { "prediction": "I think this should be `dynamo_avx512_code_in_use` instead of `dynamo_avx512_code_in_use`", "reference": "Repeating: I don't think this should be a core-wide global var. This should be isolated to arch/x86 or at least arch/, maybe inside getter/setters as mentioned above." }, { "prediction": "I don't think this is necessary.", "reference": "right URL is like in cmdrunner, using search.maven .org" }, { "prediction": "I think this should be `public Uri Endpoint { get; set; } = new Uri(\"http://localhost:4317\");`", "reference": "The link to valid syntax is not really applicable for NET2_1, right?" }, { "prediction": "I think this should be `Metadata keys: No escaping required`.", "reference": "Shouldn't it be more specific, like \"gcppubsub supports all UTF-8 strings\"?" }, { "prediction": "why not use `slave` instead of `secondary`?", "reference": "Everything in this class is SolrCloud-related, not legacy replication" }, { "prediction": "I think this should be `mcontext->xflags = dr_merge_arith_flags(mcontext->xflags, val);` instead of `mcontext->xflags = dr_merge_arith_flags(mcontext->xflags, val);`", "reference": "Could just assign directly and eliminate the `newval` var." }, { "prediction": "I don't think we need the `improved comments` here, but I think it would be better to use `improved comments` instead of `improved comments` instead of `improved comments`.", "reference": "... with the name of the affected package, or \"all\", followed by a colon,..." }, { "prediction": "I think this should be `SynchronizeVersion(src/Datadog.Trace.ClrProfiler.Managed.Core/Datadog.Trace.ClrProfiler.Managed.Core.csproj, \".\")`", "reference": "We'll want to remove this one if we make the assembly version constant." }, { "prediction": "I think this should be `setup_single_page_style()` instead of `setup_single_post_style()`", "reference": "Can we have a single function here that uses the same subscribers and just changes meta based on context?" }, { "prediction": "I don't think we need to add the `HIP_STARTUP_LOADER` flag to the `HIP_STARTUP_LOADER` class.", "reference": "where would ` static startup_kernel_loader skl;` be instantiated? if it's not instantiated anywhere should this be removed?" }, { "prediction": "I think this should be `dataTransfer.items[0] && 'webkitGetAsEntry' in dataTransfer.items[0]`", "reference": "I think we should move those util functions that work with drag-drop to @uppy/utils, so they can be shared (maybe later) with drag-drop plugin? Otherwise it will continue to depend on drag-drop module." }, { "prediction": "Why is this removed?", "reference": "Migrate the spec.Labels to locator.Labels ?" }, { "prediction": "I think this test should be done in a separate PR.", "reference": "The test case already existed but it never tested properly because of the conditional in the test." }, { "prediction": "Why is this change needed?", "reference": "I'm okay with this, but I don't see a lot of benefit to removing unnecessary parens. If extra parens make something more readable (like this) or clarify order of operations even when matching the default, I would say we should keep them." }, { "prediction": "Why is this needed?", "reference": "@sarowe why was this volatile? It's fishy to see this as the only volatile field." }, { "prediction": "I think this should be `@since [\u4ea7\u54c1/\u6a21\u5757]`, not `@since [\u4ea7\u54c1/\u6a21\u5757]`.", "reference": "template is not correct?" }, { "prediction": "Why is this needed?", "reference": "Rename the registies to `BBOX_ASSIGNERS` and `BBOX_SAMPLERS` to avoid ambiguity. There is also a registry for dataset sampler." }, { "prediction": "I don't think we need the `FakeFS.activate!` here, but I think it's better to use `FakeFS.activate!` instead of `FakeFS.activate!`.", "reference": "This is no longer stubbed on every test. Perhaps it should be, and should be unstubbed in the single case that it matters." }, { "prediction": "I think this should be `[200, Puma.stats.to_json]` instead of `[200, Puma.stats.to_json]`.", "reference": "This seems much simpler! I'm not sure I follow what you mean by the threading part... Also tests are not liking this constant. Might need a require or to fully qualify this." }, { "prediction": "I think this should be `ASSERT_NOT_IMPLEMENTED(false);` instead of `ASSERT_NOT_IMPLEMENTED(false);`", "reference": "Convention is \"FIXME: i#2144\" or \"XXX: i#2144\"" }, { "prediction": "I think this interface should be `IHasHttpMethod` instead of `IHasHttpMethod`", "reference": "This should probably be a property instead of a method." }, { "prediction": "I think this should be `state: RECONCILED`.", "reference": "do we need to consider setting the `state` as well? If so, lot of changes might be required, like, setting to 'Reconciling' in upgrade code, setting to 'error' or 'reconciled' in volumeReconciler functions." }, { "prediction": "Align the parameters of a method call if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Space inside } missing.", "reference": "Line is too long. [82/80]" }, { "prediction": "This file should be in the project root, not in the project root.", "reference": "Add blank line below license header." }, { "prediction": "I think this should be `if (ops.current() != null && ops.current().location() != null && ops.current().buildReplacement(schema, spec, baseLocation, tableProperties)) {`", "reference": "I'm not clear on whether this really should be the right behavior. Basically we're saying that a replace table will keep the existing location (as opposed to using defaults). I suspect we don't have create or replace with location semantics, but this is making some assumptions that a replacement is somehow the same as the old. If we were to go with id based pathing convention, this wouldn't work. I don't think this is an issue at this point, but it might make sense to push this down to the location provider." }, { "prediction": "I think this should be `github.com/temporalio/temporal/.gen/proto/execution`", "reference": "Just run a global replacement for all `executionproto`." }, { "prediction": "Why is this change needed?", "reference": "@AutomatedTester @davehunt thoughts on a new keyword argument?" }, { "prediction": "I don't think we need to add the `case EOPNOTSUP:` case here.", "reference": "Should line 47 be OPAE_ERR?" }, { "prediction": "I think this should be `time.Time` or `time.Duration`", "reference": "Not necessary, just write `time.Time{}`" }, { "prediction": "I think this should be `tabbar-width` instead of `tabbar-height`.", "reference": "As these two strings simply get concatenated for the docs, there's a space missing after the dot here." }, { "prediction": "Why is this needed?", "reference": "What about integrations where we don't plug ourselved on OnMethodBegin?" }, { "prediction": "I think this should be `visibility_of_any_elements_located`", "reference": "shouldn't **call** return a boolean?" }, { "prediction": "I think this should be `@AutoValue` instead of `@AutoValue`", "reference": "ViewModel classes should not expose any classes from framework.model." }, { "prediction": "Why is this removed?", "reference": "how would you feel about keeping these tests to be more explicit and having them `assert not _validate...`? or is your view that that is too duplicative of the tests in `test_evaluator.py`?" }, { "prediction": "Line is too long. [89/80]", "reference": "Why do we use the `winrm_nodes` variable here and not the string `\"winrm_nodes\"` as we were using before?" }, { "prediction": "Why is this changed?", "reference": "why update Copyright ?" }, { "prediction": "I think this should be `DgSqlCode(-4322)` instead of `DgTableName(naTable->getTableName().getQualifiedNameAsAnsiString())`.", "reference": "Does this mean we cannot update statistics with sampling on a table with LOB columns?" }, { "prediction": "I think this should be `OnInitialize` instead of `OnInitialize`.", "reference": "Look good, but I think a `[flags]` enum would be more future proof? Although i'm not sure if a flags-enum is working from the XML config. What do you think?" }, { "prediction": "I don't think we need this function anymore. I think it should be `if (row.treeNode && row.treeNode.children && row.treeNode.children.length > 0) { return 'ui-grid-icon-minus-squared'; }`", "reference": "Since I believe state will never be anything other than 'expanded' or collapse, you can rewrite this as follows: `return row.treeNode.state === 'expanded' ? 'ui-grid-icon-minus-squared' : 'ui-grid-icon-plus-squared'; `" }, { "prediction": "Why is this removed?", "reference": "the latter part can go but isn't the first part of this still sound -- that we assume \"id\"?" }, { "prediction": "I think this should be `value = value.replace(/\\s/g, '\\\\s');`", "reference": "Why is the escaping of @ and $ removed?" }, { "prediction": "I think this interface should be `IHasHttpUrl` instead of `IHasRawUrl`.", "reference": "Nit: `Http` is redundant in this interface's name." }, { "prediction": "I think this should be `store.Put(cfg.SynchronizableEntitiesPrefix, []byte{}, nil)`", "reference": "what if I set SynchronizableEntitiesPrefix to \"a/b/c/d\" in config?" }, { "prediction": "I think this should be `opts.DockerfilePath != \"\"`", "reference": "nit: This error message doesn't mention that the path is a directory, maybe \"Dockerfile path is a directory:%s, please provide path to file.\"" }, { "prediction": "I don't think you need to add the copyright header here.", "reference": "This is done automatically, you can skip it next time ;)" }, { "prediction": "I think this should be `self._tab.is_deleted()` instead of `self._tab.is_deleted()`", "reference": "This is needed in `set_value` because of `:open-editor` (you could open an editor, close the tab, then close the editor). I don't think it makes any sense to have it here?" }, { "prediction": "I think this should be `hcl:\"profiling_enabled\"`", "reference": "Perhaps we can assume that profiling is enabled if ProfilingPort is set? And/or configure a default port and frequency, so we don't have to set three config vars every time?" }, { "prediction": "I think this should be `c.ssh.forward_agent = options['forward_ssh_agent']` instead of `c.ssh.forward_agent = options['forward_ssh_agent']`", "reference": "This nil check won't correctly handle the case where forward_ssh_agent is set to false - it won't be nil but it should still not be set." }, { "prediction": "why is this needed?", "reference": "We could avoid passing proto since threshold isn't needed." }, { "prediction": "I don't think we need to check for `false` here.", "reference": "This route excluding needed for reconnect only when one connection is lost and we trying to establish another. I was thinking to make 2 separate flags for killswitch and reconnect enabling. This way we can keep killswitch working, but we don't need these routes excluded." }, { "prediction": "I think this should be `allParts().size()` instead of `allParts().size()`", "reference": "why can this modification avoid crash?" }, { "prediction": "I think this should be `@account.id == current_user.id`", "reference": "This looks good -- signing out the user if the current user is disabled" }, { "prediction": "This should be `cornerHeader` instead of `rowHeader`.", "reference": "The line exceeds 120 characters." }, { "prediction": "I think this should be `siteInfo.AddRow(\"PHP version:\", desc[\"php_version\"]);`", "reference": "Let's go ahead and change \"Site\" to \"Project\", since that's the path we've chosen. One less thing to alter in the other issue." }, { "prediction": "I think this should be `GoPath: \\t%s\\n`", "reference": "I am for this change iff we are sure the information is no longer helpful. I think this could still be valuable for certain scenarios, wbu?" }, { "prediction": "I think this should be `.orElseGet(() -> firstImageRampup);`", "reference": "I thought we decided on using the latest active version and not the one which is max ramped up." }, { "prediction": "I don't think we should use `color.HighlightUserInput(\"ctrl-c\")` here, but I think we should use `color.HighlightCode(\"ctrl-c\")` instead of `color.HighlightCode(\"ctrl-c\")`.", "reference": "can we update this to a `log.Warningf`?" }, { "prediction": "I think this should be `# pylint: disable=subprocess-run-check`", "reference": "can we get something emitted in the logs on non-zero exits to trace back to for problems like this failing on the first invocation?" }, { "prediction": "Why do we need to mock the schemaMan here?", "reference": "Do we need `schema manager` at here ?" }, { "prediction": "I don't think we need to do this, but I think it would be better to use `C.CString()` instead of `unsafe.Pointer`.", "reference": "This won't work because of the permissions on the directory when this is included as a library. But, we may be able to do this. The key would be wrapping this command with either a script or a go binary that ensures the current directory is writable. If the current directory is not writable, it would attempt to make it writable so that we could write out the produced binary. But I'm not sure if that will influence the hash that gets produced for `go.sum` since I am not sure how that is calculated. Alternatively, we can choose a place in `/usr/local` or choose a location that is writable in the go cache and use that. I'll give that a try since it might be needed for the ARM builds if we choose to only include `x86_64` precompiled binaries in the module." }, { "prediction": "I think this should be `r.scope.SetReturn(r.interpreter.Eval(semPkg, r.scope, flux.StdLib()))`", "reference": "Correct me if I'm wrong, but is this necessary? Why not just use the value returned by `interpreter.Eval` and not mess with the scope? `interpreter.Eval` will return any produced side effects. This means TableObjects as well as any value resulting from any expression statements." }, { "prediction": "I think this should be `true` instead of `false`?", "reference": "This service is global per namespace, not per Alertmanager/Prometheus/ThanosRuler instance. So this approach won't work. But maybe I missing out something, can you describe your use case here?" }, { "prediction": "I think this should be `default:false` instead of `default:false`.", "reference": "Do we need this default? Since we aren't using a sql.NullBool or *bool, an unset column will be interpreted as `false` already... We don't set a default on our other bool fields (e.g. entry admin and downstream columns)." }, { "prediction": "I think this should be `hash[:phases].any?` instead of `hash[:phases].any?`", "reference": "thanks for moving these over. makes more sense for them to be in the exports_helper" }, { "prediction": "I think this should be `:/?\"` instead of `:/?\"`.", "reference": "That import now isn't needed anymore" }, { "prediction": "I think this should be `:param path: Full path to the addon that will be installed`.", "reference": "Can you update the `Usage` to be an absolute path as well? Something like `/path/to/firebug.xpi`" }, { "prediction": "I think this should be `MvxWindowsCommonAccelerometer`", "reference": "This class is missing the `MvxPlugin` attribute" }, { "prediction": "Why not use core.getWxLang here?", "reference": "What if `wxLang` is returned `None` from `getWxLang`" }, { "prediction": "I don't think we need to check for `ret_code` here.", "reference": "Please don't do changing like this unless it _**really**_ cares. BTW. Please look around to infer our naming conventions." }, { "prediction": "I think this should be `log.info(\"Preparing test environment\");` and `log.finest(\"Preparing test environment\");`", "reference": "This is in test code: understanding what we're doing is important in this context." }, { "prediction": "I think this should be `--goquorum-compatibility-enabled` instead of `--goquorum-compatibility-enabled`.", "reference": "prob should still have an example that has multiple option names even if you have to make it up. Or maybe we don't need this method?" }, { "prediction": "Align the parameters of a method call if they span more than one line.", "reference": "I believe respond_to whitelists the formats passed to the block so if we don't want to display html, we can just remove the line format.html..." }, { "prediction": "I think this should be `error=\"` instead of `error=\"`.", "reference": "stylistic nitpick: I _feel_ like we've largely shown errors like this as \"error: \" vs. \"error=\". IMO colon/space reads better." }, { "prediction": "I think this should be `#include `.", "reference": "We could put this implementation in `RTPSWriter::create_change_pool` and avoid an extra function." }, { "prediction": "I think this is a good idea to use `fmt.Sprintf` instead of `fmt.Sprintf`.", "reference": "should this file ends with _test.go?" }, { "prediction": "Why is this change needed?", "reference": "It's because of this change. `ss` was unused and it made sense in the program. However I haven't read the IPv6 RFC so I'm unsure of what it does" }, { "prediction": "I think this should be `index` instead of `flattenIndex`.", "reference": "\"Flatten\" is a verb, so I'd probably go with `flattenedIndex` as a variable name here." }, { "prediction": "I don't think we need to freeze here.", "reference": "If it can only be called once, perhaps a more appropriate name is something like `setMaskables`? `addX` sounds like you can add many `X`es by calling it many times" }, { "prediction": "I think this should be `s3.MakePublicS3SessionForDownload`", "reference": "Nodecfg should be downloading from a private bucket -- these shouldn't be for public consumption. In general these should be generic and expect environment to provide appropriate credentials and bucket." }, { "prediction": "I don't think you need to add this line to the file.", "reference": "Could you please end the file with an empty line?" }, { "prediction": "I think this should be `LOG.info(String.format(\"Detected dialect: %s\", toReturn.dialect));` or `LOG.finest(String.format(\"Detected dialect: %s\", toReturn.dialect));`", "reference": "This is an incorrect change. The dialect spoken is an important part of the handshake and should be communicated to users." }, { "prediction": "I think this should be `isCanceled` and not `isCanceledMx`.", "reference": "Can this be non-exported to avoid direct use? It would be a breaking change but using previous package version would work." }, { "prediction": "I think this should be `c := gcerrors.Code(err); c != gcerrors.NotFound`", "reference": "Nit: this is just `return gcerrors.Code(err)`, isn't it?" }, { "prediction": "Why is this removed?", "reference": "I don't know where this came from, but it's not a good idea. This is actually timing out after 5 rounds, not 5 blocks. 5 consecutive null blocks won't be that uncommon. Also when testing with a short block time, this is a very short duration that can contribute to flaky tests." }, { "prediction": "Why is this change needed?", "reference": "In Python 3 when pickling or unpickling objects, the file needs to be opened as binary so that no text encoding/decoding takes place. So for any open calls around pickle loads or dumps, the mode for reading must be rb and the mode for writing must be wb." }, { "prediction": "I don't think we need the `method` parameter here. I think it's better to use `params.qstring.method` instead of `params.qstring.method`.", "reference": "did you remove **params.qstring.method** intentionally? if so why?" }, { "prediction": "I think this should be `read.locality.task.initialize.threads`.", "reference": "What is the current default? Is that inconsistent across uses and that's why this is null?" }, { "prediction": "I think this should be `previouslyDeployedConfig.App = appConfig.Name`", "reference": "Why did we make this change? How come it wasn't an issue before" }, { "prediction": "I think this should be `ASSERT_NO_FATAL_FAILURE(Init());`", "reference": "Can you tighten scope by moving to of these variables? i.e. Move to ~4372?" }, { "prediction": "Why is this change needed?", "reference": "Nice to see this `dataverse.rserve.password` fix rolled in." }, { "prediction": "(style) line over 80 characters", "reference": "How about the following faster alternative that doesn't need `strlen()` at all: if (*tmp_optarg == '\\0' || *endptr != '\\0') { fprintf(...) ... This would treat the bus argument as invalid if it's either empty (`tmp_optarg` points to '\\0') or invalid (`endptr` points to something other that a '\\0'). Actually, the existing code would accept an empty argument and set the bus to `0`, so if (*endptr != '\\0') { fprintf(...) ... would be enough. The check for an empty argument doesn't hurt, though." }, { "prediction": "I don't think we need to add the `from` parameter here.", "reference": "I could be missing something here, but the `from` and `cc` are the same. On the test email sent to gatewaycommunicator, these values are different." }, { "prediction": "Why is this removed?", "reference": "I'm honestly scared because act is now a hard requirement for useEffect which it wasn't before... This could break some tests :(" }, { "prediction": "I think this should be `election->blocks[block_a->hash()] = block_a;` instead of `election->status.winner = block_a;`", "reference": "Could use election from `info_a.election`, or is this deliberate?" }, { "prediction": "I think this should be `@deprecated` instead of `@deprecated`", "reference": "looks like this should be `return array(LegacyFormHelper::getType('form'));`" }, { "prediction": "I think this should be `assert(typeof opt_port === 'function')`", "reference": "Maybe it would simpler to ignore opt_port if type !== 'number'?" }, { "prediction": "Why is this change needed?", "reference": "Where was `name` being declared before?" }, { "prediction": "I think this should be `UnknownDeployment` instead of `UnknownDeployment`", "reference": "nit: use `corev1.ConditionUnknown`" }, { "prediction": "I think this should be `/^[a-f0-9]*$/.test(v)`", "reference": "You also need to add a similar check on line 992, there's another place where we check `length === 24`" }, { "prediction": "I think this should be `validatorProvider.getVoteProviderAfterBlock(parentHeader, localAddress)`", "reference": "nit: can extract the voteProvider as a local variable" }, { "prediction": "I think this test should not fail if the functions are not equal.", "reference": "[0] Not suggesting you change it here, but....kindof weird that there's just not an `assertFuncNotEquals`" }, { "prediction": "I think this should be called `isRegistered` instead of `isRegistered`?", "reference": "why are we passing 'registryAddress' here? We probably should construct it together with bc. Registry is not something that change?" }, { "prediction": "I don't think this is necessary. It's like {@link RA.spreadPath|spreadPath}, but preserves object under property path.", "reference": "`.` at the end of the sentence" }, { "prediction": "I think this should be `time.Since(start).Milliseconds()`", "reference": "wouldn't it be useful to split this into an error metric for the timing?" }, { "prediction": "Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "Not sure if this is good enough. Each generator will have it's own unit test anyway. Ideally, I think I'd want to test that each generator in the yml is actually a valid generator..." }, { "prediction": "I think this should be `MintNewSecretBlockWithActionIterator` instead of `MintNewBlockWithActionIterator`", "reference": "line is 138 characters" }, { "prediction": "Why is this needed?", "reference": "Nit: I would leave `Wire` out of the description; if you use this without wire you can still use it." }, { "prediction": "I don't think this is needed anymore.", "reference": "Nit: each field can be on a separate line to make it visually easier to read." }, { "prediction": "I think this should be `compiler_info.json` instead of `compiler_target.json`", "reference": "Do we still have these files? Shouldn't we remove these?" }, { "prediction": "I think this should be `ErrDurationInvalid` instead of `ErrDurationInvalid`.", "reference": "A lot of things to do with constants seemed to move since the original commit, so I stuck this here, Is there a better place for it?" }, { "prediction": "I think this should be `100` instead of `1000`.", "reference": "is 10 too small compared to 1000? consider sync chan is unicast only (vs block chan is broadcast + unicast), i would say use 200~400 for BlockSyncChanSize my concern is that this would potentially slowdown sync speed of full-node" }, { "prediction": "I think this should be `plans.reject { |plan| get_plan_info(plan.first)['private'] }`", "reference": "A full parse of the plan here on listing the plans will be expensive from both a computation and IO perspective." }, { "prediction": "I don't think we need these pins for NRF52840-DK, but I think it would be better to use `UART_TX_PIN` and `UART_RX_PIN` for NRF52840-DK.", "reference": "These constants use the `_PIN` suffix, while the other constants don't use it. I'm not sure what is best, but I would prefer to keep this consistent. Do you have an opinion on which it should be (with or without suffix)?" }, { "prediction": "I think this should be `@SuppressWarnings({\"FieldCanBeFinal\", \"FieldMayBeFinal\"})`.", "reference": "Hmm... this feels like discovery should come first. perhaps `--discovery-dns-url`? @NicolasMassart any opinions on this or ideas on who it should be run by?" }, { "prediction": "I think this should be `go:build !ignore_autogenerated`", "reference": "why is this needed?" }, { "prediction": "I think this should be `key` instead of `name`.", "reference": "I wonder if it'd be possible to autogenerate a key from the name within this function if one is not provided explicitly, rather than having all the callsites pass both the name and key (and usually as the same value)? Might give us a good place to implement a `name->key` function that isn't 1:1." }, { "prediction": "I think this should be `TYPE_STRING`", "reference": "@adriancole I do not see a change in the thrift file. Are there unit tests verifying that this manual serialization is compatible with the native Thrift serialization done by classes generated from `.thrift` IDL file?" }, { "prediction": "Why is this change needed?", "reference": "spelling (variable name, all three changes)" }, { "prediction": "I think this should be `desiredUID` or `desiredUserVersion`.", "reference": "I believe you meant \"specify `desiredUID` and `desiredRole`\"?" }, { "prediction": "I don't think this is needed anymore.", "reference": "Please follow the import style, move it to its similar group" }, { "prediction": "I think this should be `RouterUnrecognizedEncodingError` instead of `RouterUnrecognizedEncodingError`.", "reference": "Do we really need these? This is expanding on an API that we're about to do work on with the error stuff @kriskowal" }, { "prediction": "Why is this change needed?", "reference": "passwordModificationTime is no longer used - did the change drop a time check that should be restored? Or should the param get dropped from the methods?" }, { "prediction": "I think this should be `String.Equals(evt.ProcessName, StringComparison.OrdinalIgnoreCase)` instead of `String.Equals(evt.ProcessName, StringComparison.OrdinalIgnoreCase)`", "reference": "Would it break here without trim? If so, can we do trim in Startup.cs so we don't need to add this code to every parser?" }, { "prediction": "I think this should be `log.Printf(\"iptables output='%s', err='%s', out=%s\", out, err)`.", "reference": "Since we're using Logrus, probably best to use `Infof` to avoid confusion (Logrus' Printf behaves differently to the built in one)" }, { "prediction": "I think this should be `Math.max(2 * Blockly.FlyoutButton.MARGIN, svgText.getComputedTextLength()) + 2 * Blockly.FlyoutButton.MARGIN;`", "reference": "Hm, this looks like a change that should go upstream as well." }, { "prediction": "Why is this removed?", "reference": "let's keep ActionByActionHash and delete getActionByActionHash" }, { "prediction": "I think this should be `PricingGroup` instead of `PricingGroup`", "reference": "please use return type" }, { "prediction": "I think this should be `LOG.info(\"edgedriver will log to \" + logFile);`", "reference": "This is deliberately at this level." }, { "prediction": "I think this should be `as msg` instead of `as msg`", "reference": "I'm going to go ahead and undo this change, I don't think it was intentional." }, { "prediction": "Why is this removed?", "reference": "> specialised This isn't a typo in my neck of the woods " }, { "prediction": "I think this should be `storageTarget` instead of `storageTarget`.", "reference": "will change to `storage_target`" }, { "prediction": "Why is this needed?", "reference": "This would be better as `cls.securitycenter_client`, to match what is being instantiated." }, { "prediction": "I think this should be `hasSeparateSyswow32: bool = nativeSys32 != Syswow64Sys32`", "reference": "Could we have this initialization as part of the initialize method?" }, { "prediction": "Why is this needed?", "reference": "This line should be removed as editController is not used from this context anymore." }, { "prediction": "I don't think we need this interface, but I think it would be better to use `RetractTable` instead of `RetractTable`.", "reference": "This is correct in concept but the method signature doesn't really communicate the same thing. In other words, if the function produces an output table where is it? Its not on the function signature. Can you explain where the output table is created?" }, { "prediction": "I don't think this is necessary.", "reference": "For insurance, it's best not to take it directly" }, { "prediction": "Why is this change needed?", "reference": "change 'value' to keysToSend, here and in other references in this commit. 'value' implies the user is getting the value of the element, rather than just the keys we're sending to it." }, { "prediction": "I think this should be `task.SetLocalIPAddress(taskIP)`", "reference": "is the plan to fully migrate to boltdb and then remove the state save here?" }, { "prediction": "I think this should be `rgb(220,220,220)` instead of `rgb(220,220,220)`", "reference": "This should be `output.colorBright`. Unless I'm missing some reason for adding a new theme variable." }, { "prediction": "I don't think we need to add the `version_major` and `version_minor` to the `_updateVersionFromVCS` function.", "reference": "nit: I wonder if these should be moved down to where version is defined, just to keep them all in the same place." }, { "prediction": "I don't think we need to add `javax.annotation.*` here.", "reference": "Is this supported by every implementation of Java (and Android)? Should it be conditional upon `gen_nullable`?" }, { "prediction": "Line is too long. [82/80]", "reference": "@briri Thanks! I just caught this too updating my feature branch" }, { "prediction": "I think this should be `if len(configKey) > 0 && envpw != \"\" {`", "reference": "I think you should move this block (and the `envpw := os.Getenv(\"RCLONE_CONFIG_PASS\")`) right to the start of the function, then we can remove the duplicate code below" }, { "prediction": "I don't think this test is necessary.", "reference": "Is this only to set the node to draining? I think we can do that inside `Before` or something?" }, { "prediction": "I think this should be `try { return AzureAppServices.Metadata.SiteName; } catch (Exception e) { return AzureAppServices.Metadata.SiteName; } } catch (Exception e) { return AzureAppServices.Metadata.SiteName; } catch (Exception e) { return AzureAppServices.Metadata.SiteName; } catch (Exception e) { return AzureAppServices.Metadata.SiteName; } catch (Exception e) { return AzureAppServices.Metadata.SiteName; } catch (Exception e) { return AzureAppServices.Metadata.SiteName; } catch (Exception e) { return AzureAppServices.Metadata.SiteName; } catch (Exception e) { return AzureAppServices.Metadata.SiteName; } catch (Exception e) { return AzureAppServices.Metadata.SiteName; } catch (Exception e) { return AzureAppServices.Metadata.SiteName; } catch (Exception e) { return AzureAppServices.Metadata.SiteName; } catch (Exception e) { return AzureAppServices.Metadata.SiteName; } catch (Exception e) { return AzureAppServices.Metadata.SiteName; } catch (Exception e) { return AzureAppServices.Metadata.Site", "reference": "This should have been moved up above this inner `try` because the log message in the `catch` block does not apply to this." }, { "prediction": "I think this should be `alias_types` instead of `alias_types`", "reference": "Do we expect people to use PlanResult directly?" }, { "prediction": "Why not just return `actualErr`?", "reference": "Maybe we should call this something like `errToReturn`?" }, { "prediction": "why is this needed?", "reference": "should calculate numEpochIn1Year = xxx and <= fairBankEpochNum+numEpochIn1Year a.foundationBonusLastEpoch just happens to be equal to 1 year now, but should not count on that" }, { "prediction": "I don't think we need this change.", "reference": "I wasn't sure if the content type needed to be removed from both the `default` and `usemap` objects - I'm not sure how usemap is used." }, { "prediction": "Why is this needed?", "reference": "Duplication of line 28 Please refer your tox -e flake8 It seems that XStrField, XShortField, FieldLenField are not used" }, { "prediction": "I think this should be `self._to_complete not in self._file_model.index(path, 0, self._file_model.index(path))` instead of `self._file_model.index(path, 0, self._file_model.index(path))`", "reference": "I don't really understand the `self._file_model.index(path)` as parent here - you use `self._root_index` for `rowCount` above, so wouldn't the parent here need to be `self._root_index` as well?" }, { "prediction": "I think this should be `maxQueryLength`", "reference": "Do we want validation somewhere that max >= min? Or simply treat the max < min case as ignoring max?" }, { "prediction": "I think this should be `when:when='${ndc:topframes=1}'`", "reference": ":+1: that's a easier example :)" }, { "prediction": "Shouldn't this be `AggregateId[]`?", "reference": "If an external module decorates this interface, such a change will cause it to generate an error" }, { "prediction": "I don't think we need to use `fnm_period` here.", "reference": "Oh ha hah, FNM_PERIOD worked out nicely there. Points for co-opting a file system convention." }, { "prediction": "I think this should be `go.uber.org/zap`", "reference": "wrong grouping. As you can tell from the other files, we put system packages in the first group, the 3rd party packages in the second group, and our own packages in the third group." }, { "prediction": "I think this should be `o.appName != \"\"`", "reference": "Is `o.name` always set here?" }, { "prediction": "Is there a reason we don't need the `SteadyStateDependencies` field?", "reference": "Can this line be removed, as `SteadyStateDependencies` isn't updated anywhere? Also do we need to check the `TransitionDependencySet` here?" }, { "prediction": "I think this should be `has_active_subscription? && plan.has_annual_plan?`", "reference": "`plan.present?` and `has_active_subscription?` are equivalent. We can drop this change, while leaving the one on `app/controllers/application_controller.rb`." }, { "prediction": "I think this should be `# pylint: disable=too-many-locals` instead of `# pylint: enable=too-many-locals`", "reference": "No need for this, as pylint already only turns things off for this function and it's needed for the entire function." }, { "prediction": "Why is this change needed?", "reference": "L171 needs to be modified too?" }, { "prediction": "(style) line over 80 characters", "reference": "Why do you compare by nodeid? Simply saying d == e should be enough. Unless we have to objects in memory with the same nodeid. If that is so, something went really wrong." }, { "prediction": "I think this should be `_delete_=True` instead of `_delete_=True`", "reference": "configs/pvt/retinanet_pvt_t_fpn_1x_coco.py --> configs/pvt/retinanet_pvt-t_fpn_1x_coco.py" }, { "prediction": "I think this should be `json:\"DesiredStatus,omitempty\"`", "reference": "Nit, this could be json:\",omitempty\"" }, { "prediction": "I think this should be `BuildRequired` instead of `BuildRequired`?", "reference": "It's kinda funny to read `s.Image.Image` I wonder why it resulted to this way. What would it take to refactor to just `s.Image`?" }, { "prediction": "I don't think you need to add `deploy` here.", "reference": "nit: I like the idea! can we instead change the tag to `integration-remote` to be more specific? I feel like it's possible for us to use the `deploy` build tag for possibly another scenario" }, { "prediction": "I don't think we need the `@categories Script Utility` here. The `@categories Script Utility` should be `Perl_croak(aTHX_ \"Usage: Mob::SendAppearanceEffect(THIS, int32, int32, int32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint32, uint", "reference": "Copy and paste error here. Edit: Also missing commas here and in other Perl croaks between some parameters and not others." }, { "prediction": "Why is this needed?", "reference": "stateRoot or maybe ParentHeader would make more sense from API point of view?" }, { "prediction": "Why is this removed?", "reference": "Are you sure that this is no longer needed?" }, { "prediction": "I think this should be `SCAN_COLUMNS` instead of `SCAN_WITH_STATS_COLUMNS`.", "reference": "Would it help to use SCAN_COLUMNS as base to build SCAN_WITH_STATS_COLUMNS e.g like so `SCAN_WITHSTATS_COLUMNS = ImmutableList.builder().addAll(SCAN_COLUMNS).add(\"value_counts\",....).build()` ?" }, { "prediction": "I don't think this is a good idea, but I think it's a good idea to add a `ReportStat` method to `PipedAPI`.", "reference": "`ctx` is unused in ReportStat" }, { "prediction": "I think this should be `#include ` instead of `#include `", "reference": "We don't want to add boost as a dependency when building the Thrift compiler. Sorry." }, { "prediction": "I think this should be `int32_t minSpeedChange = 0;` or `int32_t maxSpeedChange = 0;`", "reference": "It's not printing the range. Also I think it's useful to print a warning above stating that the minimum change is -1000." }, { "prediction": "I don't think we need to do this.", "reference": "if name is empty will this become enumerate ? (and cause the unmarshal to fail ?)" }, { "prediction": "Line is too long. [89/80]", "reference": "How about including a flash message that explains the exercises are only available to subscribers of X plan?" }, { "prediction": "I think this should be `modeman.leave(self._win_id, usertypes.KeyMode.command, 'prefix deleted')` instead of `modeman.leave(self._win_id, usertypes.KeyMode.command, 'prefix deleted')`", "reference": "You should also call `e.accept()` and `return` so the key press isn't processed further (as we're leaving insert mode anyways)." }, { "prediction": "I don't think we need to do this in a separate PR.", "reference": "Freeze mutable objects assigned to constants." }, { "prediction": "I think this should be `Promise.all(...).then((res) => res.url().match( 'wp/v2/users/me'))`", "reference": "Hmm, this feels hacky. Maybe good enough if it makes the test more stable, but why is timing even an aspect here, since below it should wait for these two things anyway?" }, { "prediction": "I think this should be `if (!string.IsNullOrEmpty(xForwardedFor))`", "reference": "Do we want this on by default, or an opt-in (e.g. via some config while add the instrumentation)? I guess a more general question is - what's the bar for the default vs opt-in tags." }, { "prediction": "Why not just `/status`?", "reference": "`status` is just one of the features, named as status is not suitable." }, { "prediction": "I think this should be `View.VISIBLE` instead of `View.GONE`.", "reference": "There is an option to hide the subscriptions list from the sidebar. If it is hidden, the filter text should not be displayed." }, { "prediction": "I think this should be `Integer.MAX_VALUE`.", "reference": "I'd like for all of this to be dynamically configurable at some point, but it doesn't have to be in this PR. Can add it to the future SIP or create a separate JIRA for it, as you think would be appropriate." }, { "prediction": "Why is this removed?", "reference": "move the constructor to down the `namespace`" }, { "prediction": "I think this should be `*corev1.ObjectReference`", "reference": "Nit: ending with a '.' looks consistent with the fields around it." }, { "prediction": "Why is this change needed?", "reference": "Audit log will not have a warning about they are using a deprecated path, is it something we must care about?" }, { "prediction": "I think this should be `contract.Visibility != TypeMemberVisibility.FamilyOrAssembly`", "reference": "I think you also want to update the condition to add ` || impl.Visibility == TypeMemberVisibility.FamilyOrAssembly`." }, { "prediction": "I think this should be `depositToRewardingFundGasPerByte`", "reference": "`DepositToRewardingFundBaseGas` is a global variable (from `gochecknoglobals`)" }, { "prediction": "I think this should be `GettingStarted` and `Develop`.", "reference": "What do you think of \"operations\"?? Also what do these emojis look like on Linux??" }, { "prediction": "I don't think we need to add a tagline here.", "reference": "I like the word \"give\" here. Feels like I'm giving a gift to my team." }, { "prediction": "I don't think you need to import `RandomizedSearchCV` here.", "reference": "Is it possible to use `np.random` module instead?" }, { "prediction": "I think we should add `allow_None=True` to `ElementPlot` as well.", "reference": "``default=None`` implies ``allow_None`` so ``allow_None`` is superfluous here. As a special case, if allow_None=True (which is true by default if the parameter has a default of None when declared) then a value of None is also allowed." }, { "prediction": "I don't think we need to do this, but I don't think we need to do this.", "reference": "Is there anything in particular that makes setting up the downstream rolebinding(s) to `system:k3s-controller` burdensome or confusing? This changes looks fine to me but it seems a shame to alias an embedded k3s controller. If we are doing this in other places that I am not aware of then we can dismiss this concern out of hand." }, { "prediction": "I think this should be `go-acd` instead of `go-acd`.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I think this should be `Architecture` or `Name`.", "reference": "nit: all other types in this project have full names, so maybe a better name would be `OperatingSystem`?" }, { "prediction": "Why is this removed?", "reference": "Why is this needed here?" }, { "prediction": "I think this should be `Optional.empty()` instead of `Optional.empty().orElse(Optional.empty()).orElse(Optional.empty()).orElse(Optional.empty()).orElse(Optional.empty()).orElse(Optional.empty()).orElse(Optional.empty()).orElse(Optional.empty()).orElse(Optional.empty()).orElse(Optional.empty()).orElse(Optional.empty());`", "reference": "mmm, why a method declaration should not have the TypeVariableResolutionCapability? Is this ok?" }, { "prediction": "Why is this change needed?", "reference": "nit: any reason you swapped the ordering?" }, { "prediction": "I don't think we need this change.", "reference": "can you de-uglify at least this line?.. hard to tell what changed..." }, { "prediction": "Why is this removed?", "reference": "Please can you merge master in before making these changes. I just reinstated a bunch of BPF UTs. Possible that the UTs use this code." }, { "prediction": "I think this is a good idea to add a `__init__` method to the class.", "reference": "Do you want to add additional cases for `Bla.__b()` and `self.__c()`? (Just add additional classmethods `__b` and `__c` and the calls to `__init__`)" }, { "prediction": "I think this should be `get_current_user_records_that_can_be_displayed` instead of `get_current_user_records_that_can_be_displayed`", "reference": "the recids is never changed after. So, it should contains the exact shown results, whatever are the rights for the user (admin or simple user, restricted collections...)" }, { "prediction": "Is there a reason we don't need the `*realOpts` here?", "reference": "Shouldn't the docstring mention that the MD5 checksum of `p` is computed each time and verified? Also, could there be use cases where a caller might not want such a check to happen because, eg, a blob storage solution doesn't provide MD5 verification or uses another hash algorithm such as SHA256?" }, { "prediction": "I think this should be `if eventName == \"gainFocus\" and not doPreGainFocus(obj,sleepMode=sleepMode)` or `if eventName == \"gainFocus\" and not doPreGainFocus(obj,sleepMode=sleepMode)`", "reference": "focusRedirect is used in the powerpnt appModule. We might have to make sure that this does not break. Having said that, I really like this being handled on the events level!" }, { "prediction": "I think this should be `github.com/GoogleCloudPlatform/compute-image-tools/osconfig_tests/gcp_clients`", "reference": "You imports are out of order" }, { "prediction": "Why is this public?", "reference": "This should not be called Flow Trigger. FlowTrigger should has its own flowTrigger job name, for instance, \"flowtrigger\"" }, { "prediction": "I don't think you need to add this to the package.", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I think this should be `#if DEBUG` instead of `#endif`", "reference": "Why do we need `\\n` if we already use `WriteLine`? (and `\\n` is not cross platform)" }, { "prediction": "I think this should be `DEFAULT_INSTRUMENTATION_NAME`", "reference": "What is instrumentation name used for? I'm not seeing other classes use it, only a getter, constructor, and builder." }, { "prediction": "Why is this needed?", "reference": "@kristofgazso could you review these warnings?" }, { "prediction": "I think this should be `console.log(\"hi\");`", "reference": "will delete this." }, { "prediction": "Align the parameters of a method call if they span more than one line.
Space inside } missing.", "reference": "~~Indent 2 lines above~~ Disregard. My fault" }, { "prediction": "I think this should be `item.getType().isRepeated()` instead of `item.getType().isRepeated()`", "reference": "What was the bug that this is fixing?" }, { "prediction": "I think this should be `base64.b64encode('%s:%s' % (parsed_url.username, parsed_url.password))`", "reference": "This will always add the authorization header to the request object. Is this the right scope for these two lines? If username/password are not defined, it will encode 'Basic :'" }, { "prediction": "I think this should be `#ifdef BAZEL_TEST_DATA_PATH`", "reference": "Is this always how Bazel does paths? Would it be nicer to do `-DBAZEL_TEST_DATA_PATH=../com_github_google_flatbuffers/tests/` so this string is not hardcoded in the the source?" }, { "prediction": "I think we should be sure to get the actual date and time based on the client machine and not the client date and time based on the client machine.", "reference": "Not an expert of ES, so not sure of the impact here." }, { "prediction": "Why is this change needed?", "reference": "Who deletes the memory for the granteeList? (or the roleList for that matter)" }, { "prediction": "Why is this needed?", "reference": "This loop is missing a lock on subscriptions_mutex." }, { "prediction": "Line is too long. [89/80]", "reference": "shouldn't clearance be setting these up for us?" }, { "prediction": "I think this should be `emptyResource` instead of `emptyResource`.", "reference": "Need to update the doc for `TelemetrySDK` and `Host` structs deleting references from removed functions." }, { "prediction": "I think this should be removed.", "reference": "I think we should keep that here and add a new method `isSyntacticallyFinal` that returns `super.isFinal()` (and can be used in UnnecessaryModifier). Otherwise the contract of `isFinal` is not respected" }, { "prediction": "I don't think we need to do this in `gridCol.colDef.enableCellEditOnFocus`", "reference": "Is there a reason why we wouldn't want to check this every time? Why are we only checking for the footer and scroll bar when enableCellEditOnFocus is true?" }, { "prediction": "I think this should be `com.playonlinux.ui.api.InstallerFilter`", "reference": "You need to create an API for this class. This class should follow roughly the same dependency structure than RemoteAvailableInstallersPlayOnLinuxImplementation / RemoteAvailableInstallers. Maybe we could use a inner class here?" }, { "prediction": "I think this should be `INSERT INTO executions_visibility (namespace_id, workflow_id, start_time, execution_time, workflow_type_name, start_time, execution_time, status, history_length, memo, encoding)`", "reference": "This should not be a case, right? If `run_id` is the same `workflow_id` can't be changed. Actually surprised that it is not part of a key." }, { "prediction": "I don't think we need this.", "reference": "How would AQR work for an INSERT/SELECT of one table into another where a LOB column is being copied?" }, { "prediction": "I think this should be `secret_v3`", "reference": "Since these are ultimately different endpoints, it would be nice if we could move them up one level and nuke the common `sds` directory in order to reduce path stutter" }, { "prediction": "Why is this change needed?", "reference": "Please check also whether `null` occurs in the rest of `beforeChangeResult` array." }, { "prediction": "I think this should be `Filter` instead of `UnaryOutbound`?", "reference": "Outdated docs. There is no response, there's an ack." }, { "prediction": "Why is this needed?", "reference": "I'd rather have the container process remove the FIFO after it unblocks. Then `start` can always `Exec()`, and you can catch the \"FIFO does not exist\" error and translate it to a prettier \"someone must have already started the container\"." }, { "prediction": "Is there a reason we don't need to check if tx is nil?", "reference": "can you check if there's other similar cases to add nil-check like this?" }, { "prediction": "I think this should be `is_valid_commonname = (commonname is not None and len(commonname) < 64)`", "reference": "`<= 64`? I just picked up what you said in #3981 (\"the CN field is limited to 64 characters\") but maybe there's something I don't know where the 64th character is needed (trailing dot or whatever?) Also this sounds like something that could be beautifully unit tested. Sorry for bugging you :grin:" }, { "prediction": "I don't think this is a good idea, but I'm not sure if it's a good idea to do this, but I'm not sure if it's a good idea to do it.", "reference": "I understand that this grabs a Licenses objects but what is the autocomplete method used for? What does this do in context of the auto_completes controller?" }, { "prediction": "I think this should be `Optional transactionLocationByHash(final Hash transactionHash)`", "reference": "I don't really like that way of naming methods based on their arguments. But I can see that the other method names are the same ..." }, { "prediction": "I think this should be `value.endsWith(\"/\")`", "reference": "@sekmiller This method correctly strips the leading and trailing slashes (and also \".\" and \"-\"); But I thought the plan was also to replace any multiple slashes between nested folders with a single slash. For example, as implemented now, I can enter \"folder1///folder2\", and it gets saved and displayed like this, with the 3 slashes. I thought we wanted to sanitize it as \"folder1/folder2\"." }, { "prediction": "I don't think we need the `int64_t` here. I think it's better to use `int64_t` instead of `int64_t`.", "reference": "Looks like the X86 inline assembly is not happy with this type. I will update that" }, { "prediction": "Line is too long. [98/80]", "reference": "Tabs and a space, again." }, { "prediction": "I think this should be `std::string`", "reference": "Please just enclose if blocks with brackets; this has created issues in the past so I'd prefer we don't use them" }, { "prediction": "I think we should remove the `approver_action` field from the `approve_response_path`.", "reference": "`version` isn't need anymore because it's built into `approve_proposal_url`, yes?" }, { "prediction": "I don't think this is needed.", "reference": "Moved to the bottom of the file. `CtrlPDU` sits on `BTLE_DATA` so let's put it after" }, { "prediction": "I don't think we need this file anymore.", "reference": "This ends up requiring the `json` gem, right? Is there any way we can do this to be implementation agnostic (e.g. to let me use `yajl-ruby` for performance reasons (or because my app already brings in a JSON library)" }, { "prediction": "I think this should be `if n == 0 && err == nil {`", "reference": "This seems dangerous. What circumstances lead to the need for a retry? Can that happen more than once? I'm concerned that if we hit the pathological state, this could turn into a CPU spinner. I wonder if we could get the same benefit from just \"trying again\" and failing if it fails the second time." }, { "prediction": "I think this should be set to `null` instead of `null`.", "reference": "If there is a reference to other fields or methods, please do the initialization in the constructor." }, { "prediction": "I think this should be `@salesforce/design-system-react/components/pill/__examples__/base.jsx`", "reference": "These should be importing from `pill-container`" }, { "prediction": "I think this should be `RETURNVALUE_DESTINATIONOUTOFREACH`", "reference": "Why this change? It will now only show on the bottom of the screen as white text, is it correct behaviour?" }, { "prediction": "I think this should be `field_value(f, except_operations: [Rendering::HelperMethod])` instead of `field_value(f, except_operations: [Rendering::HelperMethod])`", "reference": "Does this need to allocate a string or would a nil value (indicating no header) be a better?" }, { "prediction": "I think this should be `this.constructor = Component;`", "reference": "Nit: Past tense of `reset` is also `reset`." }, { "prediction": "I think this should be `return self.config.fee_per_kb()`.", "reference": "Shouldn't this use `'n'` instead?" }, { "prediction": "I think this should be \"DecisionTimeout\" or \"TaskTimeout\"", "reference": "revert back to 'TASK_TYPE_ACTIVITY_TIMEOUT'" }, { "prediction": "I think this should be `const std::string &` instead of `const std::string &`.", "reference": "Shouldn't we prefer passing a pointer by reference T*&, since these are C++ bindings?" }, { "prediction": "I think this should be `if len(ingressRule.SourceGroups) > 0`", "reference": "nit: Personally I feel that it's cleaner to let `toAntreaPeerForCRD` to take `ingressRule` as a param instead of `ingressRule.From`. It can call `processRefCGs` inside the function and do the ipBlock/AG union within the function itself. It might not be worth the refactor though." }, { "prediction": "I think this should be `apis.ReconcilePending` instead of `ReconcilePending`.", "reference": "Pending has been set only for SPC.. why? for other CRs as well, this need to be done.. right?" }, { "prediction": "I think this should be `true` instead of `false`.", "reference": "would use an empty string here as default and then check for emptiness in the twig template. I dont like mixing types @core23 what do you think?" }, { "prediction": "I don't think we need to use `Name.lowerCamel(methodInfo.requestPageTokenName()).toUpperCamel()` here.", "reference": "How come we need case manipulation for the nextPageToken and not for pageToken?" }, { "prediction": "I think this should be `/profile/show` instead of `/profile#update`", "reference": "why use these rather than regular named paths?" }, { "prediction": "I don't think we need to add the `format` option here.", "reference": "Hm, I don't think the extra flags are doing any harm here, but it does seem like `--help` is the only flag you could *actually* use with this command. We might eventually want to separate those out." }, { "prediction": "This script is responsible to create candidate sets for all users.", "reference": "We should make this a docstring, so that editors are able to pick it up." }, { "prediction": "I think this should be `expect(analytics).to have_tracked(\"Authed to Access\").with_properties(video_name: video.name, watchable_name: video.watchable_name, watchable_name: video.watchable_name, watchable_name: video.watchable_name, watchable_name: video.watchable_name, watchable_name: video.watchable_name)`", "reference": "Put a comma after the last parameter of a multiline method call." }, { "prediction": "Why is this needed?", "reference": "App cache size is now managed dynamically by the `WebView`. This statement has no effect in the new framework." }, { "prediction": "I don't think we need to check `node.hasAttribute('alt')` here.", "reference": "VirtualNode has a `hasAttr` function, any reason why you're not using it?" }, { "prediction": "I think this should be `assert DEFAULT == null`", "reference": "This now throws when running tests (maybe the move to java 11??). Do we want to keep it?" }, { "prediction": "I think this should be `len(sha1) > 40`", "reference": "We can allow 7-char SHA, does not mean we want to show with 7-char in default, please change to `if len() > 10`, then cut." }, { "prediction": "I don't think we need this string, but I think it should be `noDuplicateFilesFound` and `noNewAlreadyUploading`", "reference": "this one should also have quotes i guess :)" }, { "prediction": "Why is this change needed?", "reference": "Using the variable on range scope `mock` in function literal (from `scopelint`)" }, { "prediction": "I think this should be `res.isWorkflow() ? accepted(json(res.getDataset())) : accepted(json(res.getDataset()))`", "reference": "does this result in a 200 when the dataset is still inprogress/publishing not yet finalized? Seems like 202 is the right code for that (as it was) and the test should be watching for a 202?" }, { "prediction": "I think this should be `ORDER_PATH` instead of `ORDER_PATH`.", "reference": "Previously you could only order by the field you were searching by. But for full-text search, you can search across all indexed fields, and it didn't make sense not to have a sorting. For backward compatibility, the javascript code uses indexPath as the orderPath when no orderPath is provided." }, { "prediction": "I think this should be `VNode` instead of `VNode`.", "reference": "VIM didn't like your whitespace." }, { "prediction": "I think this should be removed.", "reference": "Are you sure the namespace should change?" }, { "prediction": "Why is this change needed?", "reference": "@martijn00 I'm not sure why we're keeping the object parameter and return type since this can be done by using MvxApplication with THint set to object" }, { "prediction": "Why is this needed?", "reference": "why do we create a time type here?" }, { "prediction": "I think this should be `css!components/listview/listview` instead of `css!components/listview/listview`", "reference": "Does this style actually need to get loaded in all of these components?" }, { "prediction": "I don't think you need to add the `AccessLogHandlerImpl` to the `transport.rest.accesslog.impl` class.", "reference": "import but not used so you did not resolve compile warnings?" }, { "prediction": "Why is this change needed?", "reference": "This is so much more concise and beautiful than the previous formula " }, { "prediction": "I think this should be `org.apache.logging.log4j.Logger` and not `org.apache.logging.log4j.Logger`", "reference": "Is there any reason not to have the `static` modifier for the logger? _(that would be in keeping with the reference being uppercase)_" }, { "prediction": "I don't think we need to add the `Start` and `GetSessionConfig` methods here.", "reference": "It's not about session creation config. It's about passing consumer config parameters to underlying transport - nothing to do with session itself" }, { "prediction": "Why is this needed?", "reference": "Why is there an \"enable\" in the param name? Couldn't it just be `overrideDebug`? Here are everywhere else." }, { "prediction": "I think this should be `@videos = Video.published.recently_published_first` instead of `@videos = Video.published.recently_published_first`", "reference": "`published.recently_published_first` reads a little oddly to me. Is this the same thing as `Video.published.ordered`?" }, { "prediction": "I think this should be `throw new Error('Unable to parse content of ' + file.originalPath);`", "reference": "Encountered this because I had a stray comma. Figured I'd tweak it a bit." }, { "prediction": "I don't think we need this test.", "reference": "qq: Should this include the iptables6-save sim. to the inverse checks above?" }, { "prediction": "I think this should be `if string(str) == \"null\" {`", "reference": "im open to explicitly checking NotSet value here but json logic already handles it so kept it this way." }, { "prediction": "I think this should be `#include \"../Util/Lua.h\"`.", "reference": "The naming of the include file appears to be unlucky." }, { "prediction": "Why do we need to update `self.legend_opts` here?", "reference": "Bit worried about this. At minimum you should make a copy of the dict here to avoid modifying a user supplied variable." }, { "prediction": "I think this should be `PruneLaunchTemplateVersions` instead of `PruneLaunchTemplateVersions`", "reference": "Is it better to create one before pruning? In case creation fails we don't want to delete the previous one. We create a new one, it is tagged as latest, so the previous can be deleted. `CreateLaunchTemplateVersion` returns the version created, how about directly trying to delete the previous version? Assuming the numbering is strictly increasing." }, { "prediction": "Why is this needed?", "reference": "Do we require the specific implementation information here?" }, { "prediction": "I don't think we need the `lower` case here.", "reference": "How about `exists?(['domain ~* ?', domain.downcase])` ?" }, { "prediction": "I think this should be `c.GlobalInt(FlagContextTimeout) * time.Second`", "reference": "Is this getting used in other places? Can we switch all the places to use the new API you added?" }, { "prediction": "Why is this removed?", "reference": "This need to be checked with linux. AFAIK, we have this file in our bin directory that is a link to the system file." }, { "prediction": "Is this needed?", "reference": "Shouldn't we import `default`? I can't get here to test." }, { "prediction": "I think this should be `self.unix_socket = os.path.join(self.temp_dir, 'luigid.sock')`", "reference": "!!!!!!!!!!!!! @graingert, does this mean that tests haven't been running???" }, { "prediction": "I think this should be `if (type != null && type.Equals(\"passThrough\") && type.Equals(\"console\") && value != null) {`", "reference": "I've already tried the null-coalescing operator here and got a strange error, so did this the old-fashioned way." }, { "prediction": "I don't think we need to check if the role is list or not.", "reference": "This doesn't follow our spacing convention. It's also a little hard to read. Can you reformat?" }, { "prediction": "I think this should be `aws/copilot-cli/internal/pkg/deploy` instead of `aws/amazon-ecs-cli-v2/internal/pkg/template`.", "reference": "The deploy should come before template? EDIT: I see that in other files, we put a separate line and put deploy at the end. What is the reason for this?" }, { "prediction": "I think this should be `MetricStreamConfiguration.Aggregation.Drop` instead of `MetricStreamConfiguration.Aggregation.Drop`.", "reference": "Consider making a constant (e.g. `MetricStreamConfiguration.Drop`)." }, { "prediction": "I don't think we need to import `rdkit.six.moves` here, but I think it would be better to use `rdkit.six.moves.xrange` instead of `rdkit.six.moves.xrange`", "reference": "same question: why not just switch this to range too?" }, { "prediction": "I think this should be `std::string type(std::string &name);`", "reference": "@chuckatkins most places used an empty string for \"no type\", but a few used `\"unknown\"`. I've converted both cases to `Type::None`. Do you know why there was a distinction before?" }, { "prediction": "I don't think you need static_cast here.", "reference": "should we assert for the type for `FeatureGroupData` ? I think it should be 1-Byte type." }, { "prediction": "Why is this change needed?", "reference": "As long as you are sure this is definitely correct now... :-)" }, { "prediction": "Why is this change needed?", "reference": "... so that all action buttons have the same height :-)" }, { "prediction": "I think this should be `#include `.", "reference": "Use correct, alpha sorted, include order. Correct order means: 1. Header corresponding to this source (i.e. `\"LatencyTestPublisher.hpp\"`) 2. C system headers 3. C++ system headers 4. Alpha-sorted external libraries headers 5. Alpha-sorted public headers from this project 6. Alpha-sorted private headers" }, { "prediction": "I don't think we need this.", "reference": "I hate this name, open to suggestions." }, { "prediction": "I think this should be `log.Warning` instead of `log.Warning`", "reference": "Does this log line work? We need Warningf or just warning without the format string." }, { "prediction": "I think this should be `sdk.WithMetricsProcessors(c.MetricsProcessors...)`", "reference": "The pull controller would need similar updates." }, { "prediction": "Why is this changed?", "reference": "ignore this.. just didn't want to litter with a commit update to satisfy license plugin" }, { "prediction": "I think this should be `/cygdrive/c/Windows/Temp/{host['dist']}.msi` instead of `/cygdrive/c/Windows/Temp/{host['dist']}.msi`", "reference": "Is this definition needed since it doesn't look like it's being used anywhere?" }, { "prediction": "I think this should be `descendants.length == 0` instead of `fields.has_key?(self.discriminator_key)`", "reference": "Can this condition be reworded using `if` please?" }, { "prediction": "I think this should be `if (inputs != nullptr && !inputs->hasData()) {`", "reference": "after ||, no need inputs != nullptr" }, { "prediction": "I think this should be `IntegTestBuildspecPath`", "reference": "Is it just preference or on purpose that using slice of structs instead of slice of pointers?" }, { "prediction": "Why is this change needed?", "reference": "This line always confused me anyway. Good catch!" }, { "prediction": "I think this should be `context.Background()` instead of `context.Background()`", "reference": "Should we add `ctx` to `BlockServer.Shutdown()` for this purpose? Would be nice, but I don't care too much." }, { "prediction": "Why is this needed?", "reference": "Duration_t at RTPS level must be serialized using fractions." }, { "prediction": "I think this should be `msgInboundDispatcherNotRunning` instead of `msgInboundDispatcherNotRunning`", "reference": "\"peer\" has its own meaning within YARPC with its own class of objects. This should probably be \"dispatcher\" too?" }, { "prediction": "I think this should be `ctu-clang6` instead of `experimental-enable-naive-ctu-analysis`.", "reference": "I do not like this line break before `=true`. Maybe starting the list in the next line would help to reduce the indent? This way we could keep this string together." }, { "prediction": "I think we should remove the `overwritePath` and `sub-config-path` from `config-path` and `sub-config-path` from `config-path` and `sub-config-path` from `config-path` and `secret-path` from `config-path` and `sub-config-path` from `config-path` and `sub-config-path` from `config-path` to `config-path`.", "reference": "_plugins should be removed too" }, { "prediction": "I don't think we need to check for `img` or `input` or `area`.", "reference": "The rule selector will not include `` and `` elements. Why not make this a new, separate rule altogether?" }, { "prediction": "Why is this change needed?", "reference": "@The-Compiler Is this style okay or would you prefer a common userscript exception base?" }, { "prediction": "I think this should be `value.sub_type || 0x00`", "reference": "we'd need to return a MongooseBuffer here instead of the Binary. lets add the subtype option to the buffer schema type as referenced in #1000 instead." }, { "prediction": "Why is this removed?", "reference": "Let's remove this change." }, { "prediction": "I think this should be `ROLE_TABLECELL` or `ROLE_TABLECOLUMNHEADER`", "reference": "Could you split this into multiple lines?" }, { "prediction": "I think this should be `useSelect` instead of `useSelect`", "reference": "This technically works, however it may be safer to use both `getCurrentReferenceURL` and `getCurrentEntityURL` and then make this condition `currentReferenceURL === currentEntityURL`. Currently, this code only works based on the internals of `getCurrentReferenceURL`, so by checking both we would decouple that." }, { "prediction": "Why is this change needed?", "reference": "It does not recommend capitalization" }, { "prediction": "Line is too long. [98/80]", "reference": "Minor thing, but can you use 1.9 hash syntax for this?" }, { "prediction": "Why do we need this?", "reference": "I tried to follow the code structure already present." }, { "prediction": "I think this should be `from.toPath()` instead of `from.toPath()`.", "reference": "seems reasonable to also want to include the 'to' location?" }, { "prediction": "I think this should be `resource_filename(\"nupic\", \"\")`", "reference": "Please leave 1 space char between commas here and other places in this PR." }, { "prediction": "Why is this needed?", "reference": "hm is this really &&? Not ||? Was it initially correct if any of these things are not set that it needs to recreated?" }, { "prediction": "I think this should be `cli.hasOption(\"cluster\") ? PackageUtils.validateCollections(cli.getOptionValue(\"collections\").split(\",\")): new String[] {};`", "reference": "Please don't use C-style array declarations. IMO our pre-commit ought to be enhanced to not allow this" }, { "prediction": "I think this should be `if (p->data.bo.size != p1->data.bo.size)`", "reference": "@rhc54 This doesn't look like a comprehensive comparison. For `PMIX_STRING` we seem to actually compare the content of the data while here we only compare meta-information which doesn't ensure that values are the same." }, { "prediction": "This should be `const bool confirmed_frontiers = request.get(\"confirmed_frontiers\", false);`", "reference": "I think `bypass_frontier_confirmation` conveys the intention better (default false as well)" }, { "prediction": "I think this should be `go-filecoin/address` instead of `go-filecoin/address`", "reference": "This looks like it goes beyond the scope of removing `BlockHeight()`, in the future please do this in a separate commit at a minimum -- separate PR is fine too." }, { "prediction": "I think this should be `self._tab = tab`", "reference": "You'll also need to adjust `FakeWebTabAudio` in `tests/helpers/stubs.py`." }, { "prediction": "Why is this removed?", "reference": "@csrwng what should we do here? This one is from origin." }, { "prediction": "I think this should be `#include `.", "reference": "Follow alphabetical order." }, { "prediction": "I don't think we need this interface.", "reference": "As far as I can tell, these always get and set the context as an `IReadOnlyDictionary`. Can we use that here instead of `object` and get rid of the `as IReadOnlyDictionary`?" }, { "prediction": "Why do we need to escape `{}`?", "reference": "As you only have `{}` as the format string (without anything else in it), this is the same as doing `self._doc.setHtml(html.escape(self._opt.text))`" }, { "prediction": "This should be `azkaban.security.credential.name`", "reference": "Where would this be configured? In azkaban.properties?" }, { "prediction": "I don't think we need to check for atomic operators here.", "reference": "1. Use `const` instead of `var` here. 2. Move the check to after the `if (update == null || typeof update !== 'object')`." }, { "prediction": "I think this should be `#if defined(__linux__) && LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 27)`", "reference": "Let's assume that on Linux `eventfd` is always available as a wrapper of the eventfd2 system call. It is supported since linux 2.6.27 + glibc 2.9, as well as from the ancient versions of bionic. In other words, it would be fair to argue that the pair would be available on practically all platforms that provide `pipe2`. Therefore switching from using `pipe2` to `eventfd` on linux unconditionally would not cause issues on our users." }, { "prediction": "I think this should be `final`", "reference": "This field could be `final`." }, { "prediction": "I think this should be `@logger.warn` instead of `@logger.warn`", "reference": "would be good to have a test for the case when `shutdown!` raises" }, { "prediction": "I think this should be `t == ComTdbHbaseAccess::INSERT_` instead of `t == ComTdbHbaseAccess::INSERT_`", "reference": "Does upsert pass this check also?" }, { "prediction": "I think this should be `WithField(\"stdout\", ioStreams.Out.(*bytes.Buffer).String()).Info(\"running the patch command successful\")`", "reference": "Apologies reviewers, I did end up pushing another change. I was starting to request SRE-P help to get the apiserver configs from some clusters before and after when I realized I can just log the stdout from the patch command to see if anything was changed or not. Much simpler to verify if my work did or did not make changes to the config during the transition. Also got the spacing issue you mentioned @abhinavdahiya Thanks all." }, { "prediction": "I think this should be `kbfs_config_temp`", "reference": "I'm not sure this naming is a good idea; that's the format for macOS xattr metadata files on unsupported filesystems." }, { "prediction": "Align the parameters of a method call if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "Metrics/LineLength: Line is too long. [85/80]" }, { "prediction": "Why is this change needed?", "reference": "Please remove these imports. The project's style is to use `Assert.assertEquals` and not import static methods in general. This also caused a lot of unnecessary changes." }, { "prediction": "I don't think we need to check if `c` is NULL.", "reference": "thanks. Note that returning at this point might leak memory from the allocations above, so the PR will need to take care of that too." }, { "prediction": "I think this should be `if config.val.content.desktop_fullscreen or self.config_state_before_fullscreen`", "reference": "If you really want to rename this, you'll also need to adjust the name in `__init__` and in other places it's used (`browser/commands.py`)." }, { "prediction": "I don't think we need to add a `@OneToOne` to the `MapLayerMetadata` class.", "reference": "As discussed at standup, I gave up on this. Calling `DeleteMapLayerMetadataCommand` felt cleaner anyway because there might be other cleanup that needs to happen. @scolapasta and @matthew-a-dunlap plan to discuss this." }, { "prediction": "I think we should use `fmt.Sprintf` instead of `fmt.Printf`", "reference": "Do we need these changes? If so, can you tidy up the messages? Looks like it might have been your testing/debugging changes " }, { "prediction": "I think this should be \"CONTAINER\" instead of \"LOG_DRIVER\"", "reference": "where is the default being set?" }, { "prediction": "I think this should be `vStringNCopyS(name, line + matches[1].start, matches[1].length);`", "reference": "these changes should likely be in the next commit instead" }, { "prediction": "I think this should be `Foo` instead of `Foo`", "reference": "Since you have defined this struct, I would suggest to replace all exist literal structs by this." }, { "prediction": "I think this should be `mConfirmMenuDiscard` or `mConfirmDeleteStarred`", "reference": "The field name doesn't really capture what this option does. I think `mConfirmDiscardMessage` would be a better choice." }, { "prediction": "I think this should be `is_string` instead of `is_string`.", "reference": "what if `$media->getBinaryContent() == Symfony\\Component\\HttpFoundation\\File\\File` does `is_string()` return `true`? ping @greg0ire" }, { "prediction": "Why is this change needed?", "reference": "maybe rather than `bool` make this field a `StructDef *` ?" }, { "prediction": "I think this should be `enqueueBlocksToDeleteAfterShortDelay` or something like `enqueueBlocksToDeleteAfterShortDelay`", "reference": "Shall we maybe put this in a `const` like `backgroundTaskTimeout`?" }, { "prediction": "I don't think we need this.", "reference": "CI is complaining about this." }, { "prediction": "Shouldn't this be `calculateRemovalTime(Date initTime, Integer timeToLive)`?", "reference": "Let's only change a file if it is really necessary. Such a change does not bring much value and makes it harder to find the original commit in which the method was introduced." }, { "prediction": "I think this should be `!empty($attributes['class']) && $attributes['class'] !== ''`", "reference": "I would prefer to set up space between classes in format pattern, `%s %s` and then use `trim()` to remove unnecessary whitespaces. This will also solve stripping whitespaces from the beginning and end of a string `$attributes['class']`" }, { "prediction": "I don't think this is a good idea, but I think it would be better to use `toAdminJobOp(sentence_->getType())` instead of `toAdminJobOp(sentence_->getType())`.", "reference": "when Op is illegal should return here?" }, { "prediction": "Why is this removed?", "reference": "don't we need to remove the project version from installedVersions?" }, { "prediction": "I don't think we need this method anymore, but I think it's a good idea to add a `@bridge.print_page` method to the bridge.", "reference": "the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here." }, { "prediction": "I think this should be `FlushIPSets`", "reference": "This is intended. Pls revert this." }, { "prediction": "I think this should be `Comparators.naturalComparator(Comparators.naturalComparator(Comparators.naturalComparator(Comparators.naturalComparator(Comparators.naturalComparator(Comparators.naturalComparator(Comparators.naturalComparator(Comparators.naturalComparator(values))))`", "reference": "Something wrong with cast to `(Comparator<> & Serializable)`, need to be investigated" }, { "prediction": "Why is this removed?", "reference": "I think we need this. Not sure, I'll test." }, { "prediction": "Why is this removed?", "reference": "I'm going to need to check if google compute requires these steps in this order, or if you can disable iptables after the fact." }, { "prediction": "I think this should be `go:build !no_stage`", "reference": "Did go change their tags with the new version?" }, { "prediction": "I think this should be `Log: s.config.Log.WithField(telemetry.SubsystemName, \"bundle_client\")`", "reference": "I don't recall what we decided here in terms of which source would get priority. As written, the static configuration will overwrite datastore results." }, { "prediction": "I think this should be `len(dep.Outputs()) > 1` instead of `len(dep.Outputs()) > 1`.", "reference": "I think it should still panic for when there are no outputs; might be nice to special-case that though so the message is more explicit." }, { "prediction": "I think this should be `new MetricsConfig.MetricsConfigBuilder()`.", "reference": "*NULL_DEREFERENCE:* object `null` is dereferenced by call to `meterSupplier(...)` at line 122." }, { "prediction": "Why is this change needed?", "reference": "switch over to .mode" }, { "prediction": "nit: I think this should be `(force desync between physical and visual indexes)`, not `(force desync between physical and visual indexes)`.", "reference": "I guess your IDE did some auto-fixing here " }, { "prediction": "I don't think we need to add the `PhraseQuery` class to the `TestRamUsageEstimator` class, but I think it's better to add it to the `TestRamUsageEstimator` class.", "reference": "This is an unused import failing recommit still." }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Space inside } missing.", "reference": "I'm concerned that we're conflating multiple things here. There are 2 things that Beaker should really care about: - Network transport - i.e. `ssh` vs `winrm` - Interpreter - i.e. `bash`, `cmd`, `powershell`, etc The problem is that @cowofevil is running Bitvise SSH, and he assumed we should be setting `is_cygwin: false` in node definitions. But that doesn't really accurately convey what we care about, and since Beaker doesn't appear to track network transport apart from interpreter, we end up in a strange state. `is_cygwin: false` appears to end up setting `is_powershell?` to `true`, which IMHO is not accurate or appropriate. Bitvise templates use `ssh` (like Cygwin), but the interpreter used is `cmd`, not `powershell`." }, { "prediction": "I don't think this is a good idea, but I'm not sure if it's a good idea to use `role=\"dialog\"` here.", "reference": "I think this is ok for now. This ties into the larger issue of the site not having a consistent method for relaying form input errors. Please make sure the focus gets set on the close button when the dialog opens." }, { "prediction": "Why is this removed?", "reference": "Should these link be removed?" }, { "prediction": "`add_undo` should be `True`", "reference": "Please make this a keyword-only argument by adding a `*` argument before `add_undo`." }, { "prediction": "I think this should be `marshalers.PushBackNamed({{ $.API.ProtocolPackage }}.BuildHandler)`", "reference": "didn't quite follow what this code block is doing." }, { "prediction": "I think this should be `layoutManager.tv` instead of `layoutManager.tv`", "reference": "this doesn't sound pretty... I would rather we have a proper navigation for all modes - AFAIK TV remote navigation is very similar to normal keyboard, but maybe it just uses another key codes - those should be extracted in a single file and defined there depending on context then" }, { "prediction": "I think this should be `if ('value' in newProps && dom._isControlled)`", "reference": "After diffing the children we check whether the value got out of sync, if it did we update it. We also update the `_prevValue` to prepare for the next event hitting our controlled component" }, { "prediction": "I think this should be `glue-code` instead of `glue-code`.", "reference": "It provides a type called Node which is a fully functional bee client. This package is where the dependencies are injected. It is not just a glue-code, it is concept of node." }, { "prediction": "I think this should be `default` instead of `download-directory`.", "reference": "I think this will change `''` to `'%'` unconditionally, i.e. there'll be no way to set `''` anymore. This should really only be used for values which make no sense anymore." }, { "prediction": "I think this should be `@return` instead of `@return`.", "reference": "Nit: this table's row key map -> this table's row keys map" }, { "prediction": "I think this should be `PJ_LOG_NONE`.", "reference": "this change should be reverted" }, { "prediction": "I think this should be `[int(part) for part in __version__.split('.')]` instead of `[int(part) for part in __version__.split('.')]`", "reference": "I'm a bit confused about the `os.path.dirname(basedir)` here - is this just to get to the parent directory? Either way, I think I'd prefer just having this in `update_version.py` as it's not needed in qutebrowser itself." }, { "prediction": "Why is this change needed?", "reference": "Revert this change and see below why..." }, { "prediction": "I think this should be `lvis_v1_instance.py`", "reference": "Should not switch to `lvis_v1_instance` here because that base config uses ClassBalancedDataset to oversample the data." }, { "prediction": "I think this should be `LOG.info(String.format(\"Adding %s %d times\", caps, info.getMaximumSimultaneousSessions()));`", "reference": "This is an informational message that allows someone to read the console output and understand how the grid node is configured. Please leave." }, { "prediction": "Why is this needed?", "reference": "This doesn't make sense to me. What does RaiseSingleton mean? To me it sounds like a single object is being.. raised? Not sure." }, { "prediction": "This should be `AllJobExecutorTests`", "reference": "What's the benefit of having jobExecutorTests as a member variable? What do you think about making the method static? Afterall, it is a stateless method." }, { "prediction": "I think this should be `check` instead of `check`.", "reference": "This looks like it's only downloading things, not really checking their true validity. Especially for the MD object. Should we call `BareRootMetadata.IsValidAndSigned()` in `mdGet`?" }, { "prediction": "I think this should be `m_thread_cv_buffer.resize(omp_get_max_threads());` or `m_thread_cv_buffer.resize(omp_get_max_threads());`", "reference": "Nikoli, I believe that this addresses your concern. One question for you or Jae-Seung is if any allocation from the clone is properly cleaned up when the vector is destroyed. I believe that it should." }, { "prediction": "I think this should be `EcsApp` instead of `EcsApp`.", "reference": "should be `ECSApp` " }, { "prediction": "I think this should be `self.size.copy()` instead of `self.location.copy()`", "reference": "flake8 is going to fail on this having 2 lines" }, { "prediction": "Why is this removed?", "reference": "should we make a dir named controllers/scheduler/podchaos" }, { "prediction": "I think this should be `KeyNodeHostname` instead of `KeyNodeHostname`.", "reference": "there seems to be one KeyNode in kubernetes.go of PV.. would it make sense to use it?" }, { "prediction": "remove empty line", "reference": "Im gonna be a little annoying here but did you configure your linter correctly? This empty line should not be here. Maybe go to settings and check if `goimports` is enabled?" }, { "prediction": "I think this should be `PRIVATECHATOUT` instead of `MODPRIVATECHAT`.", "reference": "Don't think this belongs in this pr" }, { "prediction": "Why not just use `d.outbounds`?", "reference": "We can assert on the existence of Outbounds through ClientConfig calls right? Since this is only for tests, do we need this function?" }, { "prediction": "I think this should be `TaskCompletionSource` instead of `TaskCompletionSource`.", "reference": "@martijn00 so this PR introduces a new ViewModel lifecyle method? It isn't in the PR description/any new docs " }, { "prediction": "I think this should be `tuple(img.size()[-2:])` instead of `tuple(img.size()[-2:])`.", "reference": "Are these modification duplicate? Or should we move it into base detector." }, { "prediction": "Why is this change needed?", "reference": "Since this is private and single use it should be un-wrapped inside of the two-arg dagSeed method." }, { "prediction": "Why is this change needed?", "reference": "why the order change? Also for the next chunk. (I understand the result will be the same though)" }, { "prediction": "I think this should be `[string]string` instead of `[string]string`", "reference": "I wonder if this should just be a single `string`? We don't have any cases where we return different types and it would make the parser simpler to just read a single identifier." }, { "prediction": "I think this should be `inputFiles.get(task.file().path().toString());`", "reference": "I don't think this needs to change. Can you go back to the previous implementation?" }, { "prediction": "I think this should be `molecule.core`", "reference": "Bump it 2 lines higher, 'c' > 'u'." }, { "prediction": "I think this should be `parser/AstTypes.h`", "reference": "Please do not add author here" }, { "prediction": "Why is this needed?", "reference": "Similarly, we should be able to persist action uniformly" }, { "prediction": "Line is too long. [98/80]", "reference": "I think i'd prefer this override to be in the test helper instead, if that's possible?" }, { "prediction": "I think this should be `os.MkdirAll(fullPathDir, 0755)`", "reference": "This would be better with context added via wrapping or fmt.errorf()" }, { "prediction": "I think this should be `assert` instead of `assert`.", "reference": "What's the purpose of this file?" }, { "prediction": "I think this should be `if (hasStoredPasscode(ctx) && passcodeLengthKnown) {`", "reference": "@bhariharan Why was passcode length requirement allowed to be lowered?" }, { "prediction": "Why is this removed?", "reference": "This file needs a license header, too. Sorry I didn't catch that earlier." }, { "prediction": "Why is this needed?", "reference": "probably don't need `[:]` why not reference into `github.com/algorand/go-algorand/daemon/algod/api/server/lib` here and skip bouncing off daemon/algod/server.go ?" }, { "prediction": "I think this should be `dal::detail::homogen_table_builder{}`", "reference": "Why reference is converted to table?" }, { "prediction": "I think this should be `if req.Pagination.Token == 0 {`", "reference": "should we implement pagination in the fake datastore so the server startup code that paginates entries for trust domain validation can be tested?" }, { "prediction": "I think this should be `if f.Vectorized != nil`", "reference": "What mechanism will be exposed so the caller knows they're using the vectorized version?" }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Space inside } missing.", "reference": "Can we remove respond_to block its not required here" }, { "prediction": "Why do you need this?", "reference": "Do not do that even in example, we demonstrate bad practice" }, { "prediction": "I don't think we need this, but I think it would be better to use `self['is_cygwin'].nil?` instead of `self['is_cygwin']`", "reference": "Hm, taking a second look over this, this is why we have the object inheritance structure that we do. This could be divided up by having a custom determine_if_x86_64 in the pswindows/exec hosts and then a default method in hosts.rb. That way all the custom ps windows work is in a single location." }, { "prediction": "Why is this needed?", "reference": "We have to `.Complete` now because of empty/null string test cases." }, { "prediction": "Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "Is there still a way to specify no recursion?" }, { "prediction": "I think this should be \"image-import\" instead of \"image-import\".", "reference": "How is this name being URI safe and being used programmatically related?" }, { "prediction": "I think this should be `folder.name` instead of `folder.name`", "reference": "I think we have to keep this as a fallback for now, else it's a small breaking change :(" }, { "prediction": "I think this is a good idea, but I don't think we need to change it.", "reference": "nit: shouldn't be part of this PR." }, { "prediction": "Why is this change needed?", "reference": "this change looks wrong to me. I think the test is trying to signal that something went wrong by throwing the `Error` here, otherwise the `catch` below will swallow it." }, { "prediction": "I think this should be `if (logEvent.TryGetCachedLayoutValue(_layout, out)) { return cachedResult; }`", "reference": "I'm doubting if this should be `if (_layout.IsThreadAgnostic)`, as ThreadAgnostic stuff could be calculated on every thread. (and thus could be lazy). non-ThreadAgnostic should be calculated on the main thread." }, { "prediction": "I think this should be `LoggerFactory.getLogger(LeftListWidgetChooser.class);`", "reference": "Please use only `Logger` instead of `org.slf4j.Logger`" }, { "prediction": "I think this should be `if (!node.flags.disable_block_processor_republishing) {`", "reference": "Should this be \"no limiter drop\", since this isn't an absolutely essential activity for the stability of the network?" }, { "prediction": "I think this should be `console.log(\"Error\", err);`", "reference": "I updated many of the success messages, because most of these operations don't return data if they succeed. This meant many of the operations would print: `Success null` if the script ran successfully." }, { "prediction": "I think this should be `subprocess.CalledProcessError` instead of `os.path.exists`", "reference": "Could you simply add it to the previous clause ?" }, { "prediction": "I think this should be `undefined` instead of `undefined`.", "reference": "@joshyrobot, I think you can just use localeCompare with only the first argument and leave the other arguments out (here and all the other lines changed). It seems to do the right thing, and then we don't have to worry about these extra options." }, { "prediction": "I think this should be `if (slaOptions != null && slaOptions.size() > 0) {`", "reference": "@chengren311 : where does this logic move to?" }, { "prediction": "I think this should be `policies = append(policies, s.scope.ManagedMachinePool.Spec.RoleAdditionalPolicies...)`", "reference": "Can we have a `nil` exception check at `s.scope.ManagedMachinePool`" }, { "prediction": "Why is this removed?", "reference": "Rather than deleting this, should you just reformat it so it's the `*` settings, so if nothing is configured in facets.ini, the existing default behavior continues to work?" }, { "prediction": "Why not use `ucfirst` here?", "reference": "wrap, single line" }, { "prediction": "I think this should be `returnType.isEmpty() ? \"Void\" : returnType;`", "reference": "always use brackets for if statements" }, { "prediction": "I think this should be `FrameworkDescription.Instance`", "reference": "`NUnitIntegration` doesn't need to cache this anymore." }, { "prediction": "I think this should be `lower(element_at(parts, -1)) = 'gz'`", "reference": "Why did you change it to `>=` here?" }, { "prediction": "How about `HadoopTables` instead of `HadoopCatalog`?", "reference": "Looks like this needs to be updated. There is no need to remove `hadoop.` if Hadoop tables don't use this code path." }, { "prediction": "I think this should be `require 'fileutils'`", "reference": "This require isn't need anymore, right?" }, { "prediction": "I don't think we need this import anymore.", "reference": "a bit weird to see payments crypto package inside connection manager. There probably will be services not having any relation with payments that will use connection manager. Thats why probably ping-ping by itself can be useful without any relation to payments.." }, { "prediction": "I think this should be `Bibliographic` instead of `Bibliographic`", "reference": "I like the overall idea here, but I wonder if it would be more clear to define the property in the trait, and then set it in the constructors of the classes using the trait. Alternatively, at a bare minimum, it may be a good idea to add `?? 'Bibliographic'` here, to account for the possibility of the trait being used in a class that does not define the property at all." }, { "prediction": "I think this should be `50` instead of `50`", "reference": "I would prefer to not have a magic number, but construct this value out of other constants we already have." }, { "prediction": "I think this should be `config.add_api_capability(settings['multiauth.policies'], description=\"Very basic authentication sessions. Not for production use.\", url=\"http://kinto.readthedocs.io/en/stable/api/1.x/authentication.html\", url=\"http://kinto.readthedocs.io/en/stable/api/1.x/authentication.html\", url=\"http://kinto.readthedocs.io/en/api/1.x.x/authentication.html\", description=\"Very basic authentication sessions. Not for production use.\", description=\"Very basic authentication sessions. Not for production use.\", url=\"http://kinto.readthedocs.io/en/stable/api/1.x/authentication.html\", url=\"http://kinto.readthedocs.io/en/stable/api/1.x/authentication.html\", url=\"http://kinto.readthedocs.io/en/stable/api/1.x/authentication.html\", description=\"Very basic authentication sessions.html\", description=\"Very basic authentication sessions. Not for production use.\", url=\"http://k", "reference": "The limitation is if somebody configure another policy with the same name, but it is an edge case we can ignore I guess." }, { "prediction": "I think this should be `hashivault` instead of `vault`.", "reference": "? The package is named `hashivault`." }, { "prediction": "I think this should be `config->xwayland_lazy = true;` instead of `config->xwayland_lazy = false;`", "reference": "I don't think this should enable xwayland, because it's convenient to toggle xwayland just by setting `xwayland` to `false`" }, { "prediction": "Why is this removed?", "reference": "Remove this line by accident?" }, { "prediction": "I don't think this is needed.", "reference": "Calling `.stream()` on a `DomainObjectCollection` is pretty much always a bug, as it doesn't include objects added later (and encourages people to use afterEvaluate). I wonder if we should make this an error prone check?" }, { "prediction": "I think this should be `if err != nil { return err }`", "reference": "Thanks for paying attention to other places this might happen. This one is particularly important; I probably never should have gotten in the habit of CheckErr(), since it does a log.Panic() explicitly, which looks like something else until you look closely. It's supposed to be used places where \"can't happen\" but Things Can Happen." }, { "prediction": "I think this should be `fmt.Sprintf(\"nw_tos=%d\", dscp<<2)`", "reference": "What is the different between nw_tos and ip_dscp? Only high 6 bits vs low 6 bits and supported version?" }, { "prediction": "I think this should be `if (!cxSmiles) {` instead of `else {`", "reference": "I'm assuming that asSmarts & cxSmiles == asSmarts" }, { "prediction": "I don't think we need to do this here.", "reference": "Seems like an oversight but I don't think the super would do anything else in this case unless I'm mistaken." }, { "prediction": "I think this should be `readonly` instead of `readonly`", "reference": "Curious, do we consider this as pedantic for example code?" }, { "prediction": "Why is this change needed?", "reference": "Should we convert the entity name to snake case using `Doctrine\\Common\\Inflector\\Inflector::tableize` or similar ? Should a `snaked_name` or whatever be part of the entity metadata in order to use it for form names, ids, & other html attributes ?" }, { "prediction": "I think this should be `GetPublicIP` and `GetOutboundIP`", "reference": "Should be `client.outboundIp`" }, { "prediction": "I think this should be `using System.IO;` instead of `using System.Threading.Tasks;`", "reference": "Must these `using` statements not go inside the `namespace` block?" }, { "prediction": "Why is this changed?", "reference": "Why? I thought the previous way was idiomatic. (Same with the `MetadataVer` stuff above.)" }, { "prediction": "Why is this needed?", "reference": "shouldn't we `reject` here instead?" }, { "prediction": "I don't think we need to print the gas price in the output. I think it would be better to just print the gas price in the output.", "reference": "check err or use gasPriceUnitIOTX, _ := if we are sure action.Core.GasPrice is correct" }, { "prediction": "Why is this change needed?", "reference": "Just curious, was wait not used at all before?" }, { "prediction": "I think this should be `github.com/google/shlex`", "reference": "nit: can we remove this?" }, { "prediction": "Why is this synchronized?", "reference": "is it not a problem when one synchronized function is called by other?" }, { "prediction": "I think this is a bit confusing, but I don't think it's necessary to add the `admin_account` controller to the `admin_account` controller. I think it would be better to add the `admin_account` controller to the `admin_account` controller and add the `admin_account` controller to the `admin_account` controller and add the `admin_account` controller to the `admin_account` controller.", "reference": "We (even as admins) shouldn't override the User Preference settings like `email_master`, `email_posts`, `email_kudos`, `email_new_followers`. These all would be set by the user of their choice. Please do remove these attributes from editing//updating. Thanks!" }, { "prediction": "Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "\"Este :attribute j est anexado.\" sounds better." }, { "prediction": "I think this should be `__main__` instead of `__main__`.", "reference": "This line should be repeated for every module that needs testing. One cannot rely on nosetest to automatically discover all the modules. On the bright side, there is no need to change any of the other files." }, { "prediction": "Why is this removed?", "reference": "This error was unused" }, { "prediction": "I think this should be `int32` instead of `int32`.", "reference": "Personally I wish we didn't have a proto for every single little thing we do. RequestShardAction with an enum for the action type would be a lot cleaner imo, but I'm pretty sure that ship has sailed :) Just kvetching." }, { "prediction": "I think this should be `trail.completed?` or `trail.incomplete?`", "reference": "Does this make more sense as `trails/_trail` now?" }, { "prediction": "I think this should be `err := agent.ec2MetadataClient.GetOutpostARN()`", "reference": "synced offline. let's move this to `agent_unix.go` to make the IMDS call, since this is not supported in Windows." }, { "prediction": "I think this should be `py_install` and `py_prep`", "reference": "Too much indentation here. Should match the lines above, which have four spaces." }, { "prediction": "Why is this removed?", "reference": "Same here we still need this test to make sure the fallback works." }, { "prediction": "I think this should be `MvxBasePresentationAttribute`", "reference": "I'm wondering if we can actually base this on a `IMvxPresentationAttribute` instead of the base one." }, { "prediction": "Why is this change needed?", "reference": "could we switch to `undefined` here?" }, { "prediction": "Why do we need this?", "reference": "The cleanup call" }, { "prediction": "I don't think this is a good idea, but it's not as common as songs, but it's not as common as songs. It's not as common as songs.", "reference": "I think \"View artist\" is a bit more standard and expected. Or even \"Go to artist\" to take the Spotify terminology as-is." }, { "prediction": "I think this should be `return arguments unless defined?(Puppet::Pops::Types::PSensitiveType::Sensitive)`", "reference": "It might make sense to refactor this later so that we use a Bolt-native type to hide sensitive values." }, { "prediction": "I think this should be `if __name__ == \"__main__\":`", "reference": "We were trying to move away from this to force people to always run tests under py.test." }, { "prediction": "I think this should be `body.extend(self._get_selenium_options() + self._get_firefox_profile() + [self._get_firefox_webdriver()])`", "reference": "1 - create browser specific options class: - chromeoptions - firefoxoptions - argsoptions" }, { "prediction": "I think this should be `response_content_str.startswith('isInvisible()` instead of `creature->isInvisible()`.", "reference": "You introduced a bug here." }, { "prediction": "I think this should be `if (!string.IsNullOrEmpty(oldValue))`", "reference": "Should we log a warning/error if only one is specified and not the other?" }, { "prediction": "I think this should be `GetLatestEventRequest` instead of `GetLatestEventRequest`.", "reference": "`ctx` is unused in GetLatestEvent" }, { "prediction": "I don't think we need to set the default port for the daemon.", "reference": "This looks good to me. Personally, I would have the following for maximum flexibility: * convert peering_port from uint64_t to int. * Set the default value to \"-1\" to specify the value is not set * if the value is -1 then do `config.node.peering_port = network_params.network.default_node_port` That would allow for 0 to mean, select the port number yourself and be more consistent. But I am happy with the change as is, as well." }, { "prediction": "Why is this removed?", "reference": "The blank line between the summary and detailed description is better to be kept." }, { "prediction": "Why do we need this?", "reference": "Curiously, are these indents intended or should they be aligned?" }, { "prediction": "I think this should be `if not roleText: roleText = attrs.get('roleText')`", "reference": "What if we changed this to this? roleText=attrs.get('roleText', lambda:getSpeechTextForProperties(reason=reason,role=role)) That will prevent the function from ever needing called in the roletext case, and removes that if." }, { "prediction": "(style) line over 80 characters", "reference": "This will still result in a safe_read_tls_magic on AMD in tls_thread_preinit()." }, { "prediction": "Why is this change removed?", "reference": "Can you remove this change?" }, { "prediction": "Why is this change needed?", "reference": "Oh, was that a bug in the validation?" }, { "prediction": "I don't think we need to remove the `www.` prefix here.", "reference": "Please use the Google java code style. Basically, add more space characters like in the statements below. Next to method arguments and curly braces. This is currently not checked on CI because it is too inconsistent in the code base but I would prefer new code to be consistent." }, { "prediction": "I think this test should be removed.", "reference": "Actually, I don't think we need to create object on heap." }, { "prediction": "Why is this change needed?", "reference": "this is a file we copy from gRPC, sp ideally it be fixed upstream as well.." }, { "prediction": "Why is this removed?", "reference": "changes like this, just strangle guava usages to be replaced by DelayLimiter into one place" }, { "prediction": "Why is this change needed?", "reference": "PropTypes need to be updated accordingly here. Note that the type also needs updating, not just the case. That is, these should both expect a `PropTypes.elementType` now instead of an `element`." }, { "prediction": "(style) line over 80 characters", "reference": "maybe extra paren around `strncmp(...) != 0`" }, { "prediction": "I think this should be `resetOpenedWindowsCount(mRegularWindows.size(), false);`", "reference": "We should call `Windows.onResume `: - When the app is launched for the first time - When the app is resumed after being paused (home button and resume or device goes to sleep) - After a permission prompt is displayed" }, { "prediction": "Why is this change needed?", "reference": "Rename to ForksSchedule? Maybe in separate PR." }, { "prediction": "Why is this needed?", "reference": "Why a blank line here?" }, { "prediction": "I think this should be `active?` instead of `deactivated?`.", "reference": "I have a sense that this will actually eventually change to check the actual date so that subscriptions can be deactivated in the future. But I mention that here just to keep you in the loop. We should not make that change now, because it's not needed functionality." }, { "prediction": "I think this should be `if (!argSpec.isOption()) { return null; // skip default for positional params }`", "reference": "What is the reasoning for using the negation of `isOption()` instead of simply using `isPositional()` to identify a positional param?" }, { "prediction": "I think this should be `msg.addByte(player->getVocation()->getId() != VOCATION_NONE ? 0x01 : 0x00);`", "reference": "Why would you add those if client version min is set to 1100?" }, { "prediction": "Why is this removed?", "reference": "You can delete this, it will now need to live in `gointerfaces` package" }, { "prediction": "Use the new Ruby 1.9 hash syntax.", "reference": "Okay, I still don't understand why you have to add `html_safe` here, and it still seems like a very bad idea. It will allow html tags in the title, and keep Rails from escaping literal greater-than or less-than chars not intended as HTML tags. It ought to work to just let Rails do HTML-escaing as normal, without any manual `html_safe` or `strip_tags` or whatever. I am not clear on what problem you are trying to solve, why the straightfoward approach does not work." }, { "prediction": "I think this should be `if (mDisplayMode == DisplayMode.MESSAGE_VIEW) {`", "reference": "What is is subject when it's not the email subject. Why are we having to do this crap? What's calling this with an empty string?" }, { "prediction": "I think this should be `DefaultSamplingProbability` instead of `AlwaysSample`.", "reference": "Could you also remove the `defaultSamplingProbability` constant from `sampling.go`? It seems to became unused with this change." }, { "prediction": "Why is this change needed?", "reference": "can you delete the `generateDeploymentStrategicPatch` function as well?" }, { "prediction": "I think this should be `LOG.info(String.format(\"Connecting to %s and %s\", publishConnection, subscribeConnection));`", "reference": "I'd keep this at `info` level..." }, { "prediction": "I think this should be `DCHECK(!graph::ExpressionUtils::isEvaluableExpr(limit->countExpr()))` instead of `DCHECK(!graph::ExpressionUtils::isEvaluableExpr(limit->countExpr()));`", "reference": "Don't use DCHECK to debug your code if it's the regular branch you need to handle." }, { "prediction": "Why is this removed?", "reference": "You should return null here instead. Null is an acceptable default value for the image attribute." }, { "prediction": "I don't think we need to catch the error here.", "reference": "react bails as well?" }, { "prediction": "Why is this removed?", "reference": "Can you please tell me why you did this?" }, { "prediction": "I think this should be `videoConstraints.facingMode = this.opts.facingMode || this.opts.videoConstraints.facingMode || this.opts.videoConstraints.facingMode || this.opts.videoConstraints.facingMode || this.opts.videoConstraints.facingMode || this.opts.videoConstraints.facingMode || this.opts.videoConstraints.facingMode || this.opts.videoConstraints.facingMode || false`", "reference": "Reading this again it should prob prefer the `videoConstraints.facingMode` value over `facingMode` if the former was already set" }, { "prediction": "I don't think we need to add this to the model.", "reference": "There's a good bit of class-level stuff that's repeated in our various product types. Think it's worth extracting a...dare I say it...module?" }, { "prediction": "I think this should be `config.Target.WasmAbi = config.Options.WasmAbi`", "reference": "Please do not modify the `config.Target` field, it should contain exactly what is extracted from the JSON files. Instead, you can either: * Add a getter to the `config` variable (`*compileopts.Config`), so you can simply call `config.WasmAbi()` to get the value. * Use a local variable instead. The getter would be slightly cleaner, as it matches the pattern of other configurations (`CGO_ENABLED`, `GC`, `NeedsStackObjects`, etc)." }, { "prediction": "I think this should be `defer t.Stop()` instead of `defer t.Stop()`", "reference": "The nil check is not necessary for these. Append checks both sides for nil." }, { "prediction": "I think this should be `span.SetAttributes(entries...)`.", "reference": "Shouldn't we instead have the SDK apply these, internally? I.e., I would expect to see the dctx entries included in the span as first-class distributed correlations, not as span attributes." }, { "prediction": "I think this should be `errors.New(\"not implemented\")`", "reference": "nit: rename this in proto and update impl to `Search` to avoid stutter" }, { "prediction": "I think this should be `addOrderBy('s.id', 'ASC');`", "reference": "is it necessary to order by id as a second ordering? this will take place only when several new slider items are created without reordering (position is then null). Wouldn't be better to recalculate position after creating a new item? (right now items with null in position behave differently in administration and on frontend)" }, { "prediction": "I think this should be `ClaimFromRewardingFundPayloadGasPerByte`", "reference": "`ClaimFromRewardingFundBaseGas` is a global variable (from `gochecknoglobals`)" }, { "prediction": "Why is this change needed?", "reference": "How about modifying the NOGIL definition so that it only does anything if the thread safety flag (RDK_BUILD_THREADSAFE_SSS) is set?" }, { "prediction": "I think this should be `uint64` instead of `uint64`.", "reference": "blockheighter would be more clear" }, { "prediction": "I think this should be `if (a.first < b.first) {` or `if (a.first < b.first) {`", "reference": "This is so weird as a utility function." }, { "prediction": "I think this should be `cmp.FilterPath(func(p cmp.Path) bool { return p.Last().String() == \".ConsistentRead\" })`", "reference": "Why? What would happen if you did not?" }, { "prediction": "I think this should be `o = (JSONObject) o.opt(pathElement);` instead of `o = (JSONObject) o.opt(pathElement);`", "reference": "Unrelated bugfix for NPE." }, { "prediction": "Why is this change needed?", "reference": "What if some extended the `AdminController` and had a check for the old option name? Could that be a valid use case?" }, { "prediction": "I think this should be `fetchSegmentMap` instead of `fetchSegmentMap`", "reference": "This will be only available when data-manager is enabled, is there a fallback in case data manager is disabled?" }, { "prediction": "I think this should be `const eventsQueueURI = process.env.COPILOT_QUEUE_URI`", "reference": "Do you think we want to move the call to `generateWorkerServiceRecommendedActions` inside `RecommandedActions()`?" }, { "prediction": "I think this should be `VUID-vkGetQueryPoolResults-flags-02827`", "reference": "The VUIDs in this area are not great, but I think `ValidateQueryPoolStride` should probably be skipped if the query pool was created with type `VK_QUERY_TYPE_PERFORMANCE_QUERY`. VUID-02828 might be a better fit, but again, the existing VUIDs step on each other so it requires a bit of interpretation." }, { "prediction": "I think this should be `key.ToBigEndianByteArrayWithoutLeadingZeros()`", "reference": "Iguess you should use ToDbKey here" }, { "prediction": "Why is this removed?", "reference": "x.tbk is the \"index\" below, and is done in Start()" }, { "prediction": "I think this should be `DD_IsAppInsightKey`.", "reference": "Do we already have a convention for this? If not, would we consider \"DataDog.IsAppInsights\". And then use \"DataDog.\" prefix for all this settings, environment variables etc..? Such settings are, essentially, public APIs because they may conflict with customer data. Regardless of that , AppInsights has an s at the end :)" }, { "prediction": "I don't think we need to check if `ctx->log_key` and `ctx->time_key` are set.", "reference": "this assignment is not necessary if the offsetof() is used in the configmap" }, { "prediction": "Why is this removed?", "reference": "I'd rather leave a TODO here at least." }, { "prediction": "Why is this change needed?", "reference": "Shouldn't this be `resource`?" }, { "prediction": "I think this should be `#pragma omp parallel for reduction`", "reference": "Why does this become blocking for the CPU path? Shouldn't it remain independent of the GPU path?" }, { "prediction": "I think this should be `super` instead of `super`.", "reference": "Do we need to change occurences where `setup` was called before?" }, { "prediction": "I think this should be `case \"list\":` or `map`?", "reference": "Is this TODO still valid? Or are we going to put this somewhere else later?" }, { "prediction": "I think this should be `from_ts = datetime.utcfromtimestamp(from_ts)`", "reference": "We generally don't do parantheses in if conditions in Python. :) this could be better written as `if from_ts is None`" }, { "prediction": "(style) line over 80 characters", "reference": "Odd that we'd set just element 299 of a 2000-byte buffer to null. But I see that this is the way it was before." }, { "prediction": "I think this should be `ScoreFunc` instead of `ScoreFunc`.", "reference": "ScoreFunc is not used in this PR. Maybe to add it later when needed?" }, { "prediction": "I think this should be `if len(redirects) > 0 && isBrowser(copyRequestHeadersFromResponseWriter(w)) {`", "reference": "super nit: I think this might be easier to read as `requestHeadersFromResponseWriter`" }, { "prediction": "I think this should be `thread/GenericThreadPool.h` instead of `concurrent`", "reference": "Need to include \"common/base/Base.h\" in front of this line" }, { "prediction": "I think this should be `standards/get-element-spec`", "reference": "Changes in this file should go into a separate PR." }, { "prediction": "I think this should be `StringUtils.quote(text, \"\\'\");`", "reference": "Please ensure that this will not start putting single quotes where double quotes are expected." }, { "prediction": "Why is this change needed?", "reference": "`ProvideConfig` was changed, looks like it will not compile for windows, and should be changed too." }, { "prediction": "Why is this change needed?", "reference": "This does not look right, you're listing all private repositories.." }, { "prediction": "Align the parameters of a method call if they span more than one line.
Space inside } missing.", "reference": "An OPTIONS request should respond from _any_ path? Seems weird to me..." }, { "prediction": "Why is this needed?", "reference": "you need to add the content type" }, { "prediction": "Shouldn't this be `_dogStatsDMonitor` or `_traceAgentProcess`?", "reference": "Do we need to distinguish between these two processes? I'm thinking maybe we can have a list of processes and treat them all equally." }, { "prediction": "I don't think this is necessary. The stack size is 16 byte aligned on ARM and x64. The stack size is 16 byte aligned on ARM and x64. The stack size is 16 byte aligned on ARM and x64. The stack size is 16 byte aligned on ARM and x64. The stack size needs to be 16 byte aligned on ARM and x64. The stack size needs to be 16 byte aligned on ARM and x64. The stack size needs to be 16 byte aligned on ARM and x64. The stack size needs to be 16 byte aligned on ARM and x64. The stack size needs to be 16 byte aligned on ARM and x64. The stack size needs to be 16 byte aligned on ARM and x64. The stack size needs to be 16 byte aligned on ARM and x64. The stack size needs to be 16 byte aligned on ARM and x64. The stack size needs to be 16 byte aligned on ARM and x64. The stack size needs to be 16 byte aligned on ARM and x64. The stack size needs to be 16 byte aligned on ARM and x64.", "reference": "This is used only for out-of-line -- so yes this seems right to do for x64. Inlined is aligned separately at the end of prepare_for_clean_call(). There the ifdef is x86_64 or MACOS -- no ARM, why not? Also, please add || MACOS here to match the inlined." }, { "prediction": "I think this should be `and(ZIPKIN_ANNOTATIONS.TRACE_ID_HIGH.eq(ZIPKIN_ANNOTATIONS.TRACE_ID_HIGH))`", "reference": "guess I'm wondering if this needs to be refactored to use Schema.joinCondition() or similar?" }, { "prediction": "Align the parameters of a method call if they span more than one line.", "reference": "Does it make sense to restrict this option to `exec` only? You could add it specific to that subcommand using the `method_option`...method. There's an example of it for hosts in the `init` function." }, { "prediction": "I think this should be `string.Join(\"=\", decodedPair.Select(Uri.EscapeDataString));`", "reference": "This is very expensive (lots of allocations, lots of data copying). Could we do something like check IndexOf('%') and bypass if no hit?" }, { "prediction": "I think this should be `if (WorldType.isPvpWorld(client.getWorldType())) { return true; }`", "reference": "This should be `WorldType.isDeadmanWorld(client.getWorldType())` to be inline with the other WorldType calls." }, { "prediction": "I think this should be `bbox_preds` instead of `bbox_preds`.", "reference": "do we also need to change `mlvl_confid` -> `mlvl_confidences`>" }, { "prediction": "I think this should be `config:\"iface-list;cali;non-zero,die-on-fail\"`", "reference": "I feel slightly that InterfaceExclude is not a clear name - bearing in mind that our config names are, to some extent, an external API. From an external point of view, a clearer name might be IPVSInterfaces. Then it would obviously make sense for the value to be something like 'kube-ipvs0', and it would be a matter of Felix's internal implementation that we choose to exclude those interfaces from our monitoring. Alternatively, if we want to keep this at a level that is more general than just IPVS, perhaps 'UnmonitoredInterfaces'? WDYT?" }, { "prediction": "I think this should be `re.fullmatch(r'[A-Z]:[^\\\\]', path, re.IGNORECASE)`", "reference": "This should be `re.search` with a `^` anchor added to the regex, as what we want here is really any path starting with something like `E:`." }, { "prediction": "I think this should be `KindServiceEntry` instead of `KindGateway`.", "reference": "Since `IsKubernetesBuiltInResource` at L69 returns false due to lack `networking.istio.io/v1alpha3` in `builtInApiVersions` within `pkg/app/piped/cloudprovider/kubernetes/resourcekey.go`, it will never reach this point." }, { "prediction": "Why is this change needed?", "reference": "Does codecov not run this test? Not sure how else it would not be covered." }, { "prediction": "I think this should be \"multiend bytecode generator\"", "reference": "can we add some sample of JSON_DATA format in the usage?" }, { "prediction": "I think this should be `traceId` and `spanId` as well.", "reference": "Using `Tracer.Instance` in here is problematic for testing It will likely cause some other tests to break I think - that's why we started passing in `IScopeManager` EDIT: I see you used `[TracerRestore]` - maybe that'll be enough!" }, { "prediction": "I think this should be `projectIdVariableName` and `projectIdToken`.", "reference": "make all of these `static final` fields UPPER_SNAKE - they are constants." }, { "prediction": "I think this should be `aabonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_PERCENT] + aabonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_PERCENT];`", "reference": "No possible chance for weird overflows here, right?" }, { "prediction": "I think this should be a constant, not a constant.", "reference": "Or we could use a Float object to more clearly show as user-settable via non-null?" }, { "prediction": "I don't think we need to pass `finalizedHeader` to the `ForkchoiceUpdated` function.", "reference": "finalizedHeader should be saved in FinalizationManager when we have FinalizationBlockHash != Keccak.Zero" }, { "prediction": "I think this should be `disk-importer-scratch-%v` instead of `scratch`", "reference": "Not using ExactName: true would remove the need for manually adding workflow ID as it would be added automatically by Daisy. E.g. 'disk-importer-2-import-ovf-7mn7h' was created from diskImporterDiskName above even though only 'disk-importer-2' was specified. ExactName: true should be used for resources that shouldn't include any temp prefix/suffix, such as disks that will be permanently attached to a created instance. Scratch disk is not one of them." }, { "prediction": "I think this should be `[scol.alias(col) for scol in zip(self._internal.column_scols, data_columns) for scol in zip(self._internal.column_scols, data_columns))`", "reference": "If we support multi-index column later, we need to rename to fit the pandas' requirement." }, { "prediction": "I think this should be `map[string]interface{}` instead of `map[string]interface{}`", "reference": "I'm not sure this is really needed. JSONValue type can be used the same as a map as far as operators go, including range. I'd leave this out for now unless there is a strong reason to keep it." }, { "prediction": "Why is this needed?", "reference": "sorry for nitpicking but I would love a new line under this line" }, { "prediction": "Why is this needed?", "reference": "ChannelImplementation field naming is not clear, is it some kind of standard? Maybe it can be named ChannelID?" }, { "prediction": "I think this should be `removeFiles` instead of `removeFiles`.", "reference": "Looks like there is a typo: `expireSnapshots` -> `removeFiles` or whatever name we go with." }, { "prediction": "Why is this change needed?", "reference": "Thanks for looking into this. I think it looks a bit strange to have this check inside the for loop. Wouldn't it also work to initialize `idxCurrentSort` with 0 instead?" }, { "prediction": "I think this should be `OMNIPOD_POD_ALERTS_UPDATED`", "reference": "Just a small ordering thing: Could you please bring `IMPORTANCE_HIGH` to the bottom and maybe even have one line between it and the Notification IDs?" }, { "prediction": "Why is this change needed?", "reference": "Should this be boost logged?" }, { "prediction": "I think this should be `session`?", "reference": "What is the reason for doing expunge here? This method is purely for converting the timestamp." }, { "prediction": "I think this should be `field.addProp(AvroSchemaUtil.ORIGINAL_FIELD_NAME_PROP, origFieldName);`", "reference": "This calls sanitize twice if the name isn't valid." }, { "prediction": "Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.", "reference": "Is there an equivalent that'd allow zero or one?" }, { "prediction": "I think this should be `if rwExec.isTaskObjectNameRepeat() {` instead of `if m.metaTaskExec.isTaskObjectNameRepeat() {`", "reference": "Is it possible to update/re-evaluate entire metatask object for every repeat? If we decide/need to use a repeatWith resources in let us say labelSelector(bad example) then we would have to add another logic to update those properties." }, { "prediction": "Why is this int here?", "reference": "unnecessary conversion (from `unconvert`)" }, { "prediction": "(style) code indent should use tabs where possible", "reference": "typo in commit message `openening`" }, { "prediction": "I don't think we need to include `ADIOS_HAVE_PHDF5` here.", "reference": "User-code doesn't see the internal ADIOS headers anymore. This whole include block should just be `#include `" }, { "prediction": "Why is this change needed?", "reference": "nit: I guess we can omit this (unless you had a reason to specify it)" }, { "prediction": "I think this should be `isSpokeLeafNode` instead of `isUnsolicitedLeafNode`.", "reference": "Why is Hub public?" }, { "prediction": "Why is this removed?", "reference": "why is this deleted?" }, { "prediction": "I don't think we need a `

Hey, before you start this...Have you done the Intro to Rails tutorial?

", "reference": "Maybe move that into a partial" }, { "prediction": "I think this should be `testDBFile.Name()`?", "reference": "Error return value of `dao.Stop` is not checked (from `errcheck`)" }, { "prediction": "I think this should be `Warning: the provided docroot at %s does not exist.`", "reference": "util.Warning()? Easier to say." }, { "prediction": "I think this should be `log.Info(\"trie account integrity\", \"key\", fmt.Sprintf(\"%x\", k))`", "reference": "this default is kinda superfluous (although i see it was already there before PR )" }, { "prediction": "Why is this removed?", "reference": "How is this related?" }, { "prediction": "I think this should be `@team_plans = TeamPlan.featured.ordered` instead of `@team_plans = TeamPlan.featured.ordered`.", "reference": "I'm breaking one of the rules here, it feels like the right thing to do. Open to alternative suggestions." }, { "prediction": "I don't think this is necessary.", "reference": "The use of `#should` was triggering an rspec depracation warning for me, which is why I switched this to the rspec 3 style." }, { "prediction": "Why is this change needed?", "reference": "Why are you setting the CacheChange as REQUESTED when it is not valid (it was erased from history)?" }, { "prediction": "I don't think we need to import `wordpress/i18n` from `wordpress/element`.", "reference": "`lodash` shouldn't be grouped under WordPress dependencies" }, { "prediction": "Why is this change needed?", "reference": "This needs to be public so that Avro can call it." }, { "prediction": "I think we should remove the `apiFetch` from `GoogleComponents/data` and remove the `apiFetch` from `GoogleComponents/data` from `GoogleUtil/data` from `GoogleUtil/hooks` from `GoogleComponents/hooks`.", "reference": "`Google*` shouldn't be under External dependencies - seems like ESlint is not properly recognizing that these are aliases to internal dependencies." }, { "prediction": "I think this should be `if isinstance(data, ks.Series):`", "reference": "I think he meant the docstring in this constructor. yea we should fix" }, { "prediction": "I think this should be `getResource(ResourceScheme scheme, String path)` instead of `getResource(ResourceScheme scheme, String path)`", "reference": "so .. this basically follows the pattern from JapaneseTokenizer, I think. .. but somehow I don't see where we defined ResourceScheme? We're not referencing the one in kuromoji, right?" }, { "prediction": "I think this should be `var Tls13 = (SecurityProtocolType)12288;` or `var Tls13 = (SecurityProtocolType)12288;`", "reference": "It would probably be better to do: const SecurityProtocolType Tls13 = (SecurityProtocolType)12288" }, { "prediction": "I think this should be removed.", "reference": "Similar to the above, put this setting back but keep the value as `'{}'`" }, { "prediction": "I think this should be `logger.info(\"Starting to refresh continuous aggregates:\")`", "reference": "As discussed in chat - we should run this function within an app context which means that we'd already have a logger configured, and a connection to timescale set up" }, { "prediction": "Why is this removed?", "reference": "I'm curious about why this needed to be removed." }, { "prediction": "I think this should be `scapy.extlib import plt`", "reference": "why did you remove `zip`? It is used!" }, { "prediction": "Why is this change needed?", "reference": "Is there any reason that we don't add a similar condition like `ChannelConditionTopic` to the channel?" }, { "prediction": "Why is this needed?", "reference": "before php8 \"goto\" was a reserved word and was not allowed as part of the namespace. Now test checks for validity of plugin namespace according to PSR-4" }, { "prediction": "I think it's better to add a note to the doc.go file.", "reference": "nit: I'm not sure it can be addressed in this diff, but it seems odd that NewOutbound supports TLS but NewSingleOutbound does not. As a somewhat naive user I would expect the only difference between these two APIs is how peers are chosen." }, { "prediction": "I think this should be `res.Body.Close()` instead of `res.Body.Close()`", "reference": "I would advise to enhance the test for the method `CallOneway` - we should have a test very similar to `TestCallSuccess`. We should test: - Success with response (even if it is callOneway) - Success with no response and empty payload - Errors" }, { "prediction": "I think this should be `[a-zA-Z0-9\\\\+\\\\.\\\\-]{1,256}`", "reference": "We're already matching +. Not sure why this changed." }, { "prediction": "I don't think we need to set the service name here.", "reference": "Please add line breaks, so the line doesn't exceed 80 chars." }, { "prediction": "Why is this change needed?", "reference": "I initially thought (inccoreclty) this is a breaking change! The public api analyzer is a gift!" }, { "prediction": "(style) line over 80 characters", "reference": "I'm not sure how this one didn't segfault before." }, { "prediction": "I don't think we need this constant.", "reference": "Same points as in other test file." }, { "prediction": "I don't think this is needed.", "reference": "Did you run gradlew tidy? Wildcard imports shouldn't be there, hence the question." }, { "prediction": "Line is too long. [98/80]", "reference": "Put a comma after the last parameter of a multiline method call." }, { "prediction": "(style) line over 80 characters", "reference": "Is this going to restrict the output to *ONLY* ports that are bound to vfio-pci? That's not what we discussed yesterday." }, { "prediction": "I think this should be `if signer.Protocol() == address.ID {` or `if signer.Protocol() == address.ID {`", "reference": "Intention is to do the lookup here, I believe (where we can cache it). This would make the call non-pure function though. I'll confirm with lotus. ID addresses are the *only* addresses I expect to actually see here." }, { "prediction": "Why is this removed?", "reference": "electronic medical record file system (EMRFS)" }, { "prediction": "I think this should be `maxrequestbody` instead of `maxrequestbody`", "reference": "Put this higher in the list, like after \"bind\", since I guess we're considering the max request body size to be kind of a native/fundamental feature, built directly into the vhosts." }, { "prediction": "Why is this removed?", "reference": "oh come on :(" }, { "prediction": "I think this should be `LOG.info(String.format(\"Detected dialect: %s\", toReturn.dialect));` or `LOG.finest(String.format(\"Detected dialect: %s\", toReturn.dialect));`", "reference": "This is an incorrect change. The dialect spoken is an important part of the handshake and should be communicated to users." }, { "prediction": "I think this should be `bool: Whether or not authenticated user is a service account`", "reference": "Remove as this is not needed anymore." }, { "prediction": "I think this should be `do_it` or `do_it2`.", "reference": "This new class is for checking that #4551 works correctly with PlantUML output too." }, { "prediction": "I think this should be `cmapi.UsageKeyEncipherment` instead of `cmapi.UsageServerAuth`", "reference": "Will this cause all certificates to be re-issued?" }, { "prediction": "(style) line over 80 characters", "reference": "I think tmp is also leaked at the end of this loop if no error cases are encountered." }, { "prediction": "Why is this change needed?", "reference": "The previous version didn't use `keyProjection` because the entire key must be projected. If the key is a struct of multiple columns, then projecting a subset of those columns can easily introduce key collisions that aren't in the original data." }, { "prediction": "I think this should be `spaceId < 0` instead of `spaceId`.", "reference": "Why not use StatusOr ? We can't ensure spaceId is greater than zero, especially when AdHocSchemaManager is used." }, { "prediction": "I think this should be `github.com/ethereum/go-ethereum/rpc` instead of `github.com/ethereum/go-ethereum/rpc`", "reference": "Does it seem we only use that as the json-rpc client? Do we have any other choice? It's a little weird." }, { "prediction": "I think this should be `or (role in (controlTypes.ROLE_DELETED_CONTENT, controlTypes.ROLE_INSERTED_CONTENT, controlTypes.ROLE_INSERTED_CONTENT))`", "reference": "Could you split this into multiple lines?" }, { "prediction": "Why is this change removed?", "reference": "Doesn't the snapshot ID start off as null? It seems like we don't need to set it here." }, { "prediction": "Why is this change needed?", "reference": "I wondered why `buffer` was passed into `LookupPath`. What is happening here? Is `buffer[:0]` equivalent to `[]V4TrieEntry{}`, and hence `buffer` isn't needed any more?" }, { "prediction": "Why is this needed?", "reference": "nit: Ideally we would would use this abstraction everywhere we need this translation. I believe it's needed in the mining worker and the storage and market connectors." }, { "prediction": "I think this should be `if len(cStorPoolGot.Spec.Disks.DiskList) > 0 {`", "reference": "need to fix the error message here" }, { "prediction": "I think this should be removed as well.", "reference": "Unsure of how to handle this one." }, { "prediction": "I think this should be `if (isKilled() || this.flowFinished) {` or `if (isKilled() || this.flowFinished) {`", "reference": "Will this.flowFinished verify with every finished state stated in Status.isStatusFinished method? If so, no need to verify isKilled." }, { "prediction": "I think this should be `DefaultRetrySettings`", "reference": "replace \"Child Workflow\" with \"any workflow\"" }, { "prediction": "I think this should be `if .IsSymlink` instead of `else if`.", "reference": "Instead of showing the words \"symbolic link\" under the \"Size\" column, how about we introduce new icons for symbolic link to file and symbolic link to directory?" }, { "prediction": "I think this should be `@internal` instead of `@internal`.", "reference": "Please add back the description of the parameter" }, { "prediction": "Why is this change needed?", "reference": "Superfluous space inserted." }, { "prediction": "I don't think we need to check for `node.ownerSVGElement` here.", "reference": "Didn't fix the problem. `href=\"\"` for SVG will still result in `undefined` getting returned by this function." }, { "prediction": "I think this should be `json::Array{{json::True()}}` instead of `json::Array{{json::True()}}`.", "reference": "This seems like a strange change ... I wouldn't think that a change to access tags in the profiles would result in different bearings in this tests?" }, { "prediction": "I think this should be `isFocus=True` instead of `isFocus=False`.", "reference": "As isCaret is False by default, explicitly specifying isCaret=False here is not needed, and is perhaps a little confusing. I'd prefer that anywhere in the codebase that isCaret is only ever specified if it needs to be set to true. Mirroring that of isFocus for setNavigatorObject." }, { "prediction": "I think this should be `[Errno::EADDRNOTAVAIL]` instead of `[Errno::EBADF]`.", "reference": "We can't freeze this and then add something to it in the next line. The `freeze` on line 43 is sufficient. If Rubocop flags this we need to exclude it." }, { "prediction": "Why do we need to sort here?", "reference": "Why is this needed?" }, { "prediction": "I don't think we need to add the `/users/:username/repos` route to the `/orgs/:org/repos` route.", "reference": "Why not put two other routes after this line (221)?" }, { "prediction": "I think this should be `if (addrs.value().isEmpty()) { return addrs.status(); }`", "reference": "If FLAGS_meta_server_addrs is not empty, in which case \"toHosts\" return empty array?" }, { "prediction": "I think this should be `Settings.JSONBoolWithQuotes(DEFAULT_JSON_USE_QUOTES);`", "reference": "There is a function to output a \"JSONBool\" string. That would be a good start for finding uses. But maybe just have a look at where we decide whether it is a numerical or not, thus wrapping quotes around its value. Then you have it all I guess." }, { "prediction": "I think this should be `data._internal.data_scols[0]` instead of `data._internal.data_scols[0]`", "reference": "oops, it should be `data._scol` so that it respects the expression stored in Series. Let me fix it quick." }, { "prediction": "I don't think we need to check if `current_user` is a valid user.", "reference": "Thanks for moving this up with the rest of the variables. Much tidier :)" }, { "prediction": "I think this should be `dto.PaymentPerTime` and not `dto.PaymentPerTime`", "reference": "I think `Rate` is a more precise and concise term for `PaymentPerTime`." }, { "prediction": "Why is this change needed?", "reference": "I think this should maybe be: var limit = input.IndexOfAny(new[] { '+', '-', ']' }, **posNext**); You pretty much want to ignore any sign that is before the \"M\". But, if there is a sign somewhere before the M, and also after the M, you'd want to be able to find the sign after the M, right?" }, { "prediction": "Shouldn't this be `if(true === ConfigQuery::checkAvailableStock()) {`?", "reference": "if `checkStockNotEmpty` returns a reponse, you must return it or your script will continue its execution." }, { "prediction": "Why is this changed?", "reference": "Any specific reason for this change? klog should work correctly here." }, { "prediction": "I don't think we need to do this, but I think it would be better to do `SET data = (:data)::JSONB` instead of `SET data = (:data)::JSONB`.", "reference": "we don't mention `last_modified` here?" }, { "prediction": "I don't think we need the `h` variable here.", "reference": "same deal about the global state maybe interfering as in ActionBrowseTagline" }, { "prediction": "I think this should be `Assert.Throws(() => new LruCache(maxCapacity, \"test\");`", "reference": "so sweet to see a test as the first thing" }, { "prediction": "I don't think this is necessary.", "reference": "usually when HTTP_PROXY=\"\" (empty), proxy should be disabled. could you set it to NULL when it's empty string?" }, { "prediction": "Why is this change needed?", "reference": "Can you throw an exception if width or height are both null" }, { "prediction": "Why is this change needed?", "reference": "This is a breaking change. I guess these might have been intentionally exported." }, { "prediction": "I think this should be `TableProperties.METADATA_SPLIT_SIZE` instead of `TableProperties.SPLIT_SIZE`.", "reference": "I don't think this is necessary. When options are used to set the split size in the Spark reader, it uses `TableProperties.SPLIT_SIZE` to pass it here. That should work for metadata tables as well, right? The situation that we need to handle in this PR is setting the default, like you had before. We just want to use a metadata split size so you can set it and not have the same split size used (by default) for both metadata and data scans." }, { "prediction": "I think this should be `divide` instead of `divide`.", "reference": "wait a sec, shouldn't this be `'*'`?" }, { "prediction": "I think this should be `varMap[\"compute_service_account\"] = oi.params.ComputeServiceAccount if oi.params.ComputeServiceAccount != \"\" {`", "reference": "It think you'll want the var for GMI import as well: daisy_workflows/ovf_import/create_gmi.wf.json (Unfortunately there's duplication between the two :/ )" }, { "prediction": "I think this should be `/session/$sessionId/moz/context` instead of `/session/$sessionId/moz/context`", "reference": "Nit: Group this with the other commands by moving it down one line." }, { "prediction": "I think this should be `UnsupportedOperationException` instead of `UnsupportedOperationException`.", "reference": "I would like to emphasize that a user can use non-vectorized reads to handle this file so maybe something like \"Cannot perform a vectorized read of ParquetV2 File with encoding %s, disable vectorized reading with $param to read this table/file\"" }, { "prediction": "I think this should be `param_name`?", "reference": "Maybe add `positional=False`. It does not need it more than the other parameters, but one must start somewhere." }, { "prediction": "I think this should be `../../spec/max-staleness/ReplicaSetWithPrimary` and `../../spec/max-staleness/ReplicaSetNoPrimary`", "reference": "Since we're here, can we use a template?" }, { "prediction": "I think this should be `spark_session_local.resource_fn(None)`", "reference": "saw you're also doing this in `test_types.py`: `spark = _spark_context()['test'].resources['spark'].resource_fn(None)` since `_spark_context()` uses `spark_session_local` won't the above break the tests?" }, { "prediction": "Why is this change needed?", "reference": "`has(default)` i think is the preferred way of doing this" }, { "prediction": "why is this needed?", "reference": "always put a space after a comma" }, { "prediction": "I think this should be `selectAllPhotosUpToFav(getImagePosition(m.getPath()));`", "reference": "@angmas1 move the else up, next to the closing bracket of the if block. Also, there is no need for the braces as your else statement contains only a single line. Make your if-else block similar to the block in lines 277-280." }, { "prediction": "Why is this change needed?", "reference": "@AutomatedTester @davehunt thoughts on a new keyword argument?" }, { "prediction": "Shouldn't this be `int maxSessionCount`?", "reference": "This change shouldn't be necessary for this PR. Please remove it." }, { "prediction": "Why is this change needed?", "reference": "This variable is mostly unused, how about we make `NewTestCtx` return a pointer?" }, { "prediction": "I think this should be `32 * 1 << 20`", "reference": "What is the basis of this value?" }, { "prediction": "I think this should be `gce_metadata.h` instead of `gce_metadata.h`.", "reference": "Nit: was this extra blank line added intentionally?" }, { "prediction": "I don't think we need to set the exception code here.", "reference": "nit: inconsistent spacing around =" }, { "prediction": "Why is this removed?", "reference": "We still need this import" }, { "prediction": "Why is this change needed?", "reference": "We are pulling this because we removed \"groupID\" state and put it into the strategy implementations" }, { "prediction": "I think this should be `#define ONEAPI_DAL_DATA_PARALLEL`", "reference": "Is this file actually related to PCA?" }, { "prediction": "I think this should be `isOwner` instead of `isFirstAdmin`.", "reference": "See above, this should probably remain `isFirstAdmin`." }, { "prediction": "Why is this change needed?", "reference": "Why the change to make it public? The expression interface has the `TypeOf` method?" }, { "prediction": "Why is this change removed?", "reference": "don't mind the snake cases in the test names. If there are in the test cases, it's fine IMO" }, { "prediction": "I think this should be `IdentityUnlocking` instead of `IdentityUnlocking`", "reference": "`Id` defines REST resource address and should not be in payload" }, { "prediction": "I think this should be `--class-wise` or `--class-wise`.", "reference": "We can omit the underscore and just use `classwise`." }, { "prediction": "I don't think we need to check if the root category exists for a given context.", "reference": "Why not throw an exception instead then?" }, { "prediction": "I think this should be `inputFiles.get(task.file().path().toString());`", "reference": "Looks like this doesn't need to change. Can you revert this?" }, { "prediction": "I think this should be `from config import template` instead of `from config import template`", "reference": "please import it like `from kinto.config import template`" }, { "prediction": "I think this should be `Boolean.parseBoolean(p)` instead of `Boolean.parseBoolean(p)`", "reference": "There are lots of default value changed, not sure if it break the old behavior." }, { "prediction": "I think this should be `go.golang.org/grpc/reflection`", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I think this should be `bool addToStaticNodes = false` instead of `bool`", "reference": "parameter should be called removeFromStaticNodes" }, { "prediction": "I think this should be `override: bool=False`", "reference": "The handler will have an extra property in the marker to signal the implementation is in the provider, for the cases we want to add functionality, for example, custom implementations not in moto." }, { "prediction": "I think this should be `active?` instead of `deactivated?`.", "reference": "Is this method actually being used anywhere? If not, I think we should remove it." }, { "prediction": "I think this should be `!p.IsReadOnly` instead of `!p.IsReadOnly`", "reference": "Thanks! I somehow lost this between my far too many branchs." }, { "prediction": "I don't think we need to import the `WebElement` class here.", "reference": "i think this should get put into its own file. This could start to grow :)" }, { "prediction": "I think this should be `~internal~ecs~pause` instead of `~internal~ecs~pause`.", "reference": "Can you add a TODO for loading the tarball of the pause image into Docker?" }, { "prediction": "I think this should be `this.process = null;`", "reference": "Is there any value in setting the process to null like this?" }, { "prediction": "I think you can use `CHECK_EQ(outer_num_ * inner_num_, bottom[1]->count())` instead of `CHECK_EQ(outer_num_ * inner_num_, bottom[1]->count())`.", "reference": "This could be a good time to add a check that the prediction and target dimensions (except channel) agree?" }, { "prediction": "I think it would be better to use `OP_isb` instead of `OP_getsec`.", "reference": "The requirement that OP_isb is bb-final needs to be a rule for clients, just like the rule that syscalls and interrupts must be bb-final: i.e., please add it to the dr_register_bb_event() docs." }, { "prediction": "I don't think we should use `Globalize.translate(\"ListPaging\").replace(\"{0}\", totalRecordCount).replace(\"{1}\", totalRecordCount).replace(\"{1}\", totalRecordCount).replace(\"{0}\", totalRecordCount).replace(\"{1}\", totalRecordCount).replace(\"{0}\", startIndex).replace(\"{1}\", totalRecordCount).replace(\"{0}\", startIndex).replace(\"{1}\", totalRecordCount);", "reference": "The translate library has a method to replace the variables." }, { "prediction": "I think this should be `assert_eq(ks.fillna(0, inplace=True), ps.fillna(0, inplace=True), ps.fillna(0, inplace=True))`", "reference": "i don't think this test case is correct. in both cases inpalce=True returns nothing. We need to compare the ks. Also we probably need to make a copy of it. Otherwise you pollute the following \"ks\" because ks has been changed." }, { "prediction": "I think this should be `tls.TlsHandshakeHook` instead of `tls.TlsClienthelloHook`", "reference": "Any proposals how to make the naming somehow include the \"completed\" idea of this hook? `TlsHandshakeCompletedHook` or similar? Or using the `...Start/End...` scheme?" }, { "prediction": "Why do we need to flush the tree?", "reference": "it introduces a lot of complexity to the state, can we flush straightaway or create a two level flush store where the questions are read form unflushed data?" }, { "prediction": "I think this should be `urlencode($node->id);` instead of `urlencode($node->id);`", "reference": "There are two calls to getUrlFromRouteCache, but you're only urlencoding one of them. Is that intentional? Would it make more sense to do the url-encoding inside the getUrlFromRouteCache function?" }, { "prediction": "I don't think we need this.activeEditor.row and this.activeEditor.col here.", "reference": "Maybe we can use `this.instance.getCell` with `topMost` flag to get `TD` element?" }, { "prediction": "I think this should be `log.L().Info(err.Error())`.", "reference": "Change this to Debug Level" }, { "prediction": "Why do we need this?", "reference": "I refactored the Aggregate, those are hard to read" }, { "prediction": "I think we should remove the `` tag.", "reference": "This is now done in the after method, so this test won't pass any more." }, { "prediction": "I think this should be `@user.blocks.active.take.zero_hour?` instead of `@user.blocks.active.take.zero_hour?`.", "reference": "What was the point of creating `user_block` if you're then not going to use it ;-)" }, { "prediction": "Why is this removed?", "reference": "@ueshin, I thought we can remove this entire file. Does that require some more works?" }, { "prediction": "I think this should be `unicode(tokens.string)[1:-1]`", "reference": "Just `return tokens.string[1:-1]` is enough" }, { "prediction": "I think this should be `resources:quizzes, only: [:show] do`", "reference": "1 trailing blank lines detected." }, { "prediction": "I think this should be `Double.MAX_VALUE` instead of `Double.MAX_VALUE`.", "reference": "Isn't this the default max width? In any case I would prefer to see these definitions in the css files." }, { "prediction": "Why is this change needed?", "reference": "Is this thread-safe? (If not, and if the solution is to introduce locking, let's reconsider how we do the scheme changing instead...)" }, { "prediction": "Why is this removed?", "reference": "Looks like this file has tabs instead of spaces." }, { "prediction": "I think this should be `if err != nil {`", "reference": "Hmm should we clean up container resources before task resources here? or the order does not really matter here?" }, { "prediction": "Why is this removed?", "reference": "Please undo this :wink:" }, { "prediction": "Align the parameters of a method call if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Space inside } missing.", "reference": "thanks for adding this missing association" }, { "prediction": "I think this should be `app.UseKestrelHttps(new HttpsConnectionFilterOptions(ServerCertificate = cert));`", "reference": "Should I remove this in favor of the HttpsConnectionFilterOptions overload?" }, { "prediction": "Shouldn't this be `max(index)` instead of `max(index)`?", "reference": "This shode be nullable, there alway sholud be at least one status in system , if not exist that mean data problme" }, { "prediction": "I don't think we need to add JS file to unistall-sw.js.", "reference": "Spaces not tabs" }, { "prediction": "I think this should be `this.fsErrorToJsError_(error, path);`", "reference": "To get the files inside a directory, please use `readDirStats()`." }, { "prediction": "I think this should be `TestContainerPlz` or `TestContainerPlz`", "reference": "might be worth to call these `Isolation` instead of containers here and when presented to the user -- docker/rkt , in addition to cgroups and namespaces, also provide image discovery and filesystem preparation; there's also the security context and probably 1-2 other small things" }, { "prediction": "I think this should be `batchstore_test.py` and not `batchstore_test.py`.", "reference": "File is empty, consider removing?" }, { "prediction": "I think this should be `_load_auth` instead of `_load_auth`.", "reference": "This seems to return the registry_url. The more meaningful URL is the catalog URL, which is the URL the user specifies in `quilt3.login`. The username might also be as useful here if not more useful." }, { "prediction": "I think this should be `L1StandardBridgeAddress`", "reference": "Was the addition of `GasPriceOracleAddress` here erroneous?" }, { "prediction": "Align the parameters of a method call if they span more than one line.", "reference": "I believe that you are going to have to do some work here to get the env var support for these values to still work correctly, otherwise they will get stored as :department instead of host_tags[:department]." }, { "prediction": "Why do you need this?", "reference": "How was this causing the exception?" }, { "prediction": "I think this should be `if (currentCulture == 'zh-tw' || currentCulture == 'zh-hk') {`", "reference": "I still have issues with it loading Simplified Chinese by default over Japanese, since they also share characters and we're not sure if characters are different or not. As-is, this fixes Traditional Chinese and Simplified Chinese, but we're not sure if it'd still screw up Japanese text or not. I maintain that, in my opinion, Japanese should be the only script of this kind loaded by default (Because of Hiragana and Katakana, that aren't shared with any other script) and either variant of Chinese should be loaded only in their respective case." }, { "prediction": "I think this should be `new IntervalQuery(field, this);`", "reference": "Isn't it better to stub AtomatonQuery and yield it here. IIRC it resolves simplest MTQ highlighting cases as nobrainer." }, { "prediction": "I think this should be `@discounted_plan.price_in_dollars / (12.0 * 12.0)`", "reference": "Line is too long. [96/80]" }, { "prediction": "I think this should be `kubernetes.io/os/linux`", "reference": "My only concern with changing the node selector here is that someone else _could_ have built their own images for other platforms and set them to be used using the flag override on the controller, which in turn this change would break. Perhaps not changing the selector for acmesolver pods makes most sense, and then working on actually having support for Windows? wdyt?" }, { "prediction": "I think this should be `InnerObjectWithSelector` instead of `InnerObjectWithSelector`.", "reference": "Why do we need interface `InnerObjectWithSelector`, I searched the usage with this field, it seems nowhere use `GetSelectorSpecs()` methods provided by `InnerObjectWithSelector`" }, { "prediction": "Why is this needed?", "reference": "Do we need this `init` here? We have already called the `InitContext` in `StartModule` directly." }, { "prediction": "I think this should be `self.execute(Command.W3C_MINIMIZE_WINDOW, {\"windowHandle\": \"current\"})`", "reference": "This `if` is not necessary" }, { "prediction": "I don't think we need this value for input masking.", "reference": "should we add a `mangle.json` mapping for this? We could reuse a property name that's only used on component or vnode objects right now, like `__s` (\"next state\")." }, { "prediction": "I think this should be `--modulepath` or something like `--module-path`", "reference": "Please update the yard docs to indicate this new option." }, { "prediction": "I think this should be `*Subnets` instead of `*Subnets`.", "reference": "Can you provide an example in the godoc section on how to use this? From the implementation it looks like the AvailabilityZone field is required for example, otherwise it can fail / error, is that correct?" }, { "prediction": "I think this should be `latestSchemaVersion.String()` instead of `codeVersion.String()`", "reference": "It would be great if this could be captured by a test." }, { "prediction": "I don't think we need this property.", "reference": "1000 -> 100 maybe too much, 200 ish to 500ish maybe a good option" }, { "prediction": "I think this should be `GetChecksumAddress()` instead of `GetChecksumAddress().String()`", "reference": "Any reason we need to keep this package's `ChecksumAddress` type or can we get rid of it too?" }, { "prediction": "Why is this changed?", "reference": "Above the one that was picked was the Button* prefix, and here it's the Header* prefix. Maybe the Button prefix is more general." }, { "prediction": "Why is this change needed?", "reference": "I might prefer changing: public Block FindPendingBlock() => FindBlock(PendingHash, BlockTreeLookupOptions.None); public BlockHeader FindPendingHeader() => FindHeader(PendingHash, BlockTreeLookupOptions.None); in IBlockFinder, what do you think?" }, { "prediction": "I think this should be `+kubebuilder:pruning:PreserveUnknownFields`.", "reference": "This is necessary due to a bug in 4.7. Follow HIVE-1561 for getting rid of it." }, { "prediction": "Line is too long. [98/80]", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "Why is this change needed?", "reference": "Some day (tm) I will also get rid of that one. But today is not that day..." }, { "prediction": "I think this should be `array_map` instead of `array_map`.", "reference": "Add a space between if and opening parenthesis please (i.e. `if (`)" }, { "prediction": "Why is this change needed?", "reference": "nit: `rename` instead of `alias`?" }, { "prediction": "I think this should be `if devName == \"/dev/sda1\" {` instead of `if devName == \"/dev/sda1\" { continue }`", "reference": "Per AWS docs EC instances have the root mounted at /dev/sda1. This label should be skipped." }, { "prediction": "Why is this removed?", "reference": "I'm not sure it is a better way to address lose message, if wait here, edge controller cant process message, event from watching api-server will be lost yet, right?" }, { "prediction": "I don't think we need this change, but I think it would be better to use `len` instead of `value_size` here.", "reference": "Please keep the correct alignment, it seems broken now (at least in Github). Can you reverse the test (`if p.value_size is None`)? Also, do you want `6` when `p.value_size is None` or `x + 6`? Maybe, in that case, something like `lambda p, x: x + 6 + (0 if p.value_size is None else p.value_size)` would be easier to read. Or even easier: `lambda p, x: x + 6 + (p.value_size or 0)`." }, { "prediction": "I think this should be `*int64` or `*int64`", "reference": "Can we make sure ECS service treats it as int64 as well?" }, { "prediction": "I think this should be `_get_window_text` instead of `_get_window_text`", "reference": "Please follow the naming convention for variables, i.e. `windowText`." }, { "prediction": "I don't think this is needed.", "reference": "alias can be `cast`" }, { "prediction": "I don't think this is necessary, but I think it should be `uint64_t` instead of `(uint64_t)mmap_errors`.", "reference": "Let's use `%zu` instead of casting to `uint64_t` and using `PRIu64`. The alternative is to change the type of `mmap_errors` to `uint64_t`, though I'd prefer not doing that because some 32-bit platforms might not provide atomic operation support for `uint64_t`." }, { "prediction": "Why is this changed?", "reference": "I recall there being a reason we had this one set only to suggeation. @carterkozak do you remember why? or is my memory getting corrupted?" }, { "prediction": "Why is this change needed?", "reference": "This should now be made into `if (it->second.empty())` ?" }, { "prediction": "I think this should be `self.num_of_searches += 1`", "reference": "Do we need to worry about a race condition on this decrement (@The-Compiler)? I'm not sure how the python callbacks work, so this might not need to be something to worry about." }, { "prediction": "Why is this change needed?", "reference": "Should these assert that the extracted `SpanContext` is remote?" }, { "prediction": "I think this should be `match_low_quality` or `match_high_quality`.", "reference": "typo: allow low quality matches." }, { "prediction": "Why is this change needed?", "reference": "At some point we need to condense down and refactor our \"configs\" as we have too many in too many places and we're starting to get more illegible code. No change necessary but calling out for future reference." }, { "prediction": "I think this should be `icon_label` instead of `icon_label`.", "reference": "Can we add the `if label` conditional to this please?" }, { "prediction": "I think this should be `0.2.0` instead of `0.2.0`.", "reference": "@thunterdb, can we increase the minimal version to almost the latest ones? I was thinking people will mostly use the latest version of mlflow" }, { "prediction": "I think this should be `true` instead of `false`.", "reference": "If the last argument is going to be removed, why would we add it to the API docs? Shouldn't it be private for internal use?" }, { "prediction": "I think this should be `IntermediatesManager` instead of `FileSystemIntermediateManager`.", "reference": "`Intermediates` or `Intermediate`" }, { "prediction": "I think this should be `isinstance(element, str)` instead of `isinstance(element, dict)`", "reference": "This is not the right exception class. There is an InvalidSelectorException class that covers bad locators." }, { "prediction": "I think this should be `if isInitialized && c.config.JoinURL != \"\" && c.config.Token != \"\" {`", "reference": "If this code isn't needed, it should be removed." }, { "prediction": "I think this should be `req := md.metricsClient.Export(ctx, &colmetricpb.ExportMetricsServiceRequest{ResourceMetrics: protoMetrics, RetrySettings: md.connection.cfg.RetrySettings, stopCh: md.connection.stopCh})`", "reference": "Should the `doRequest` func be a method on the `connection` type instead of passing state from the type?" }, { "prediction": "I think this should be `COPILOT_ENVIRONMENT_NAME` instead of `COPILOT_ENVIRONMENT_NAME`.", "reference": "we'll probably tackle these e2e tests at the end" }, { "prediction": "I think this should be `[BenchmarkCategory(Categories.CoreFX)]` instead of `[BenchmarkCategory(Categories.CoreFX)]`", "reference": "what is this address pointing to? what are we measuring here? I want to have a better understanding." }, { "prediction": "I think this should be `SELECT DISTINCT(trigger_instance_id) FROM execution_dependencies WHERE trigger_instance_id not in (\\n`)", "reference": "Would it be better to pass the dependency status as the parameter into the SQL string? In case the enum value is changed in the future, we don't need to change the code here." }, { "prediction": "I think this should be in `libdokan/libdokan/libdokan.go`", "reference": "Hah I had `gorename` failing without this too." }, { "prediction": "I think this should be `Security.Instance.DdlibWafVersion?.ToString() ?? \"(none)\"`", "reference": "maybe prefix these with `appsec_` for consistency?" }, { "prediction": "I think this should be `golang.org/x/net/trace`", "reference": "nit: this should be down further with the other github imports" }, { "prediction": "I think this should be `if ctypes.windll.kernel32.FreeConsole() != 0` instead of `if ctypes.windll.kernel32.FreeConsole() != 0`", "reference": "Why is this change necessary or related to the rest of the PR?" }, { "prediction": "I think this should be `- see: ' . $issue_data->link`", "reference": "Hm, I wonder if the `see:` prefix is even necessary?" }, { "prediction": "I think this should be `0` instead of `1`.", "reference": "This should be translated." }, { "prediction": "I don't think we need to do this, but I think it's better to do `if (param.count(\"num_class\") && new_config.num_class != config_.num_class) {`", "reference": "I originally had this PR only changing the R package, but then ran into this error > Error: [LightGBM] [Fatal] Cannot change metric during training This is thrown even if you aren't actually CHANGING `metric`. I think the change here in `c_api` is closer to the desired behavior, only throwing an error if the parameter is being changed." }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "These changes are just to make cli_spec a little more readable for VS Code users, as there's a bug with the Ruby plugin's syntax highlighting when you use multi-line regex literals." }, { "prediction": "I don't think we need the global pull secret name here.", "reference": "Shouldn't the global pull secret by in the namespace of the hive-operator? It is part of the operand." }, { "prediction": "I think this should be `assert_consumers(0)`", "reference": "kinesis-mock applies KINESIS_LATENCY to RegisterStreamConsumer actions so I added a sleep here." }, { "prediction": "I think this should be `LOG(ERROR) << \"Can't upgrade meta from V1 to V2\".", "reference": "Only V1 or V3 is return from `getMetaVersionFromKV`. So where do we call `updateMetaV2ToV3`?" }, { "prediction": "Why is this change needed?", "reference": "I think that V0 is missing here, which will prevent plugins that haven't been converted to work." }, { "prediction": "I think this should be `/wow/index.html` instead of `/wow/index.html`", "reference": "Should we remove this?" }, { "prediction": "I think we should move this to the top of the file.", "reference": "Put on top of the import." }, { "prediction": "I think this should be `analytics`", "reference": "See above, this shouldn't be added." }, { "prediction": "Why is this change needed?", "reference": "This'll likely get fixed upstream, we should let them deal with it." }, { "prediction": "I think this should be `host.HostFactory` instead of `host.HostFactory`", "reference": "Somehow, this field does not seems useful for the exposed package api, only for the tests. Would you consider having an unexported field in `hostFactory func(context.Context, ...libp2p.Option) (host.Host, error)` instead to be set only by a new helper function defined in export_test.go. This is just a suggestion, not a hard requirement for the PR approval." }, { "prediction": "I think this should be `goBackInTime(n, timeDuration)` instead of `goForwardInTime(n, timeDuration)`", "reference": "As a first argument to these function, please pass the date that should go forward/backward. Also please clarify what is \"n\" (possible values, unit) and what is timeDuration (possible values, unit, as from your code it seems to be \"day\", \"hours\", etc. but from your example it seems to be milliseconds)." }, { "prediction": "I don't think we need to do this in a separate PR.", "reference": "Are you sure you really need this code here? that script will be certainly run in NVDA's main thread, and core would have already called setLanguage." }, { "prediction": "I think this should be `10256` instead of `10256`", "reference": "why is this changed ?" }, { "prediction": "I don't think we need a TODO here, but I think we should be able to test that doc's revision field is updated.", "reference": "Should this be \"the new revision value\"?" }, { "prediction": "Align the parameters of a method call if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "You have deleted :attribute" }, { "prediction": "I think this should be `http://www.apache.org/licenses/LICENSE-2.0` and not `http://www.apache.org/licenses/LICENSE-2.0`.", "reference": "The license header should be updated to the Apache one." }, { "prediction": "I think this should be `expectedSpanCount = EnvironmentHelper.IsCoreClr() ? 2 : 1;`", "reference": "@zacharycmontoya Is there any way to distinguish a `SocketHttpHandler` from another `HttpMessageHandler` request?" }, { "prediction": "I don't think this is needed.", "reference": "Not sure about this one -- did you check somehow?" }, { "prediction": "I don't think we need the `if` here. I think it's better to do `if @options['HOSTS'][name]['platform'] =~ /windows/`", "reference": "Is there a good reason to keep this at the `pe_ver_win` name now that it's per-host?" }, { "prediction": "I think this should be `new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new SummaryProductFragment(new Summary))))))));`)`)`)`)", "reference": "Not in the order of display : Front, Ingredient, Nutrition here (which is the right thing), Actually displayed: Front, Nutrition, Ingredients" }, { "prediction": "I think this should be `*metav1.Time` and not `*metav1.Time`", "reference": "Why delete `StartTime`? This `StartTime` was used to avoid the PID was reused." }, { "prediction": "I think this should be `if !host.is_pe?` instead of `if !host.is_pe?`", "reference": "My concern here, is that if the dump_puppet_log also throws then we will lose the data about the teardown_exception." }, { "prediction": "I think this should be `dal::detail::integral_cast(desc.get_class_count()),`", "reference": "Should it be `int64_t`?" }, { "prediction": "I think this should be `DEFAULT_POW_JOB_TTL`?", "reference": "is this value related to something ?" }, { "prediction": "I think this should be `AddTxResult?` instead of `AddTxResult?`.", "reference": "Add names to tuple elements ValueTask<(Keccak? Hash, AddTxResult? AddResult)>, should they both be nullable?" }, { "prediction": "I think this should be `namePiece = replaceAcronyms(namePiece, replaceAcronyms(namePiece, replaceAcronyms(namePiece, replaceAcronyms(namePiece, replaceAcronyms(namePiece));`", "reference": "I think it might make more sense to do this in Name.upperCamel; it is the entry point for upper camel strings." }, { "prediction": "I think this should be `type.asArrayType(ArrayType)` instead of `type.asArrayType(ArrayType)`", "reference": "Huh? The point is that a cast isn't necessary" }, { "prediction": "I think this should be `menv.ENVKey = \"OPENEBS_IO_INSTALL_CRD\"`", "reference": "can we name it like `InstallV1Alpha1CRDs` ?" }, { "prediction": "I think this should be `hiveutilCreatedLabel`", "reference": "I need something to match when creating selectorsyncsets so added this label." }, { "prediction": "I don't think this is necessary.", "reference": "Isn't `nil` the default return value from an empty `rescue` clause? If that's correct, then we could just remove the `nil` line entirely as it doesn't serve a purpose." }, { "prediction": "I think this should be `s3.s3_ruby_bucket_cors.rb`", "reference": "Simple Storage **Service**" }, { "prediction": "I don't think this is necessary.", "reference": "Wouldn't that cause the obsolete indexes to be downloaded over and over again? After all these are still stored in the repository." }, { "prediction": "I don't think this is necessary.", "reference": "We might want to move this logic to a Plain Old Ruby Object down the road. Not a blocker." }, { "prediction": "I think this should be `if (this.toolbox_ && !this.toolbox_)`", "reference": "move `this.toolbox_.position();` to just after line 1477. Context: the if statement on line 1472 checks whether this is a toolbox with categories, and if so it populates the toolbox. Positioning the toolbox is a reasonable followup to that, and means you don't need an extra if. You may also need to call `this.flyout_.position()` after line 1483, which is the equivalent for the non-category toolbox." }, { "prediction": "I think this should be `if (peptideGroupDocNode != null && sequenceProteinsDict.TryGetValue(peptideDocNode.Peptide.Target.Sequence, out var proteinsForSequence))`", "reference": "Should the function above be .FirstOrDefault() instead? Otherwise, why check for null and tell ReSharper to ignore the fact that it can never be null?" }, { "prediction": "I think this should be `require('../jobs/job').STATUS_MAP`, not `require('../jobs/job').STATUS_MAP`", "reference": "Let's not create new connection, but rather user `common.db` one" }, { "prediction": "I think this should be `image_url` instead of `image_path`", "reference": "Can this use asset_path rather than defining an image_url helper?" }, { "prediction": "I think this should be `always('');` instead of `always('');`", "reference": "Hindley-Milner signatures don't use literal types. They explusively use types. It's deal with that" }, { "prediction": "I think this should be `*PolicyRule`", "reference": "Could we just extend PolicyRule with more fields? It was originally designed as the struct required by openflow client, nested structs seem not helping. And for the name of the fields, initialism should be uppercase, OFID and NPName doesn't look good, then maybe FlowID, PolicyName.." }, { "prediction": "I think this should be `opcache_get_configuration` and `opcache_get_status`", "reference": "I really dislike this alignment approach, as it makes identifying individual functions quite hard, but I kept consistent with the previous style. Since no sorting was evident, I pushed it to the end of the block. Meanwhile, is this supposed to be tested or meaningfully testable somehow?" }, { "prediction": "I don't think we need the `handle_event` here.", "reference": "Could also consider modifying the ActiveExecution..." }, { "prediction": "I think this should be `astroid.Const` instead of `astroid.Const`.", "reference": "Does it make sense to change that to a custom error instead of `ValueError`?" }, { "prediction": "Why is this change needed?", "reference": "I guess this will need to change soon." }, { "prediction": "Why is this removed?", "reference": "Restore this spacing - not sure why it has to be removed?" }, { "prediction": "I think this should be `#define _XOPEN_SOURCE 700L #define _POSIX_C_SOURCE 200809L #define _POSIX_C_SOURCE 200809L #define _POSIX_C_SOURCE 200809L #define _POSIX_C_SOURCE 200809L #define _POSIX_C_SOURCE 200809L #define _POSIX_C_SOURCE 200809L #define _POSIX_C_SOURCE 200809L #define _XOPEN_SOURCE 200809L #define _POSIX_C_SOURCE 200809L #define _POSIX_C_SOURCE 200809L #define _POSIX_C_SOURCE 200809L #define _POSIX_C_SOURCE 200809L #define _POSIX_C_SOURCE 200809L #define _POSIX_C_SOURCE 200809L #define _POSIX_C_SOURCE 200809L #define _XOPEN_SOURCE 200809L #define _POSIX_C_SOURCE 200809L #define _POSIX_C_SOURCE 200809L #define _POSIX_C_SOURCE", "reference": "These defines cause issues in base.h leading to failing android builds. Locale independency is now set in multiple spots, in cmake and in base.h. The base.h uses feature test macros wrong. Feature test macros can be used to indicate that a feature should be made available. They do not guarantee that it is available. On the cmake side this is done by the check symbol macros (similar to what autoconf does). On the android side not. I would suggest removing this from base.h and define locale independent in gradle. It is available since android 21 I believe. Is there a way in gradle to set locale independent only if android api >= 21?" }, { "prediction": "I don't think we need to check for joinInput or getDst here.", "reference": "Why not delete these codes?" }, { "prediction": "I think this should be `FLAGS_meta_client_retry_times` instead of `FLAGS_meta_client_retry_times`", "reference": "If pull message failed after some reties, we should ensure the storaged exit, otherwise it has risk to loss data." }, { "prediction": "why is this change needed?", "reference": "looks like you don't need to import first and count here anymore" }, { "prediction": "I think this should be `if len(tasks) > 0 {`", "reference": "FYI, visibility task processing is local only, meaning pushing something to local ES cluster / local archival endpoint" }, { "prediction": "Why is this needed?", "reference": "This import can be removed." }, { "prediction": "I don't think we need to check if the region is FIPS or FIPS.", "reference": "1. Nit: We can have a general helper to identify if a region is pseudo region. We might already have one somewhere. 2. Does any type of ARN support FIPS? If not, we may just move this check in arn package?" }, { "prediction": "I don't think this is needed.", "reference": "is this phrase completed in a next line? Or forgot to add... what?" }, { "prediction": "why do you need this?", "reference": "`('train', 5)` and `('train', 1)` are actually the same." }, { "prediction": "I don't think we need to change the `currLimit` value here.", "reference": "Would it be too complicated to refactor `currLimit` to be an `int64`?" }, { "prediction": "I think this should be `::RSpec::Core::Pending#skip` instead of `::RSpec::Core::Pending#skip`.", "reference": "Would it be more performant to just `include ::RSpec::Core::Pending` here? /cc @myronmarston" }, { "prediction": "I don't think we need to add this to the `IoChaosStatus` struct, but I think we should add it to the `IoChaosStatus` struct.", "reference": "Should be podiochaos?" }, { "prediction": "I think this should be `codecs.register(lambda name: codecs.lookup('utf-8') if name == 'cp65001' else None)`", "reference": "Is the `codecs.register(lambda name: None)` gracefully handled by codecs? The lambda is expected to return a tuple of functions (encoder, decoder, stream_reader, stream_writer) (or a CodecInfo object), according to the docs. I've only checked python's built-in help, though." }, { "prediction": "I think this should be `this.metricStreamNames.ContainsKey(metricStreamName)`", "reference": "in this case, it could be either instrument name or the view name, which could be invalid. might be better if we can offer very specific message. (not blocking this, we can add this as a follow up,if needed)" }, { "prediction": "I think this should be `nameOrHandle` instead of `handle`?", "reference": "I'd rather just send the parameter twice than break encapsulation here. There's already precedence with webelement IDs" }, { "prediction": "I think this should be `backbone` instead of `backbone`.", "reference": "You may put 'open-mmlab://res2net101_v1d_26w_4s' here. MMCV will be updated later." }, { "prediction": "I think this should be `DATA_SRC` or `DATA_SRC_FIELD`.", "reference": "May be worth making this more specific, to avoid potential conflicts, maybe `pagespeedDashboardWidget`? Or `webVitalsDashboardWidget`?" }, { "prediction": "I think this should be `${err.message}` instead of `${err.message}`", "reference": "I guess this assignment is now redundant?" }, { "prediction": "I think this should be `var blockNum uint64` instead of `var blockNum uint64`", "reference": "See above note re: blockNum synchronization." }, { "prediction": "I think this should be `spire_backoff` instead of `spire_backoff`", "reference": "wonder if we could avoid doing named imports if we type aliased `backoff.Backoff` in the `.../agent/common/backoff` package?" }, { "prediction": "Why is this removed?", "reference": "Or maybe put into alphabetical order with the other #includes." }, { "prediction": "Why is this needed?", "reference": "This runs the entire duration of the program; this change is not needed." }, { "prediction": "I don't think we need this property.", "reference": "I don't feel well about the `ALWAYS_UPDATE` option   sounds like a workaround. I can imagine that some of the plugins want to observe all options. Maybe, in that case, we can reuse the `CONFIG_KEYS` that would return an empty array for observing all settings and `false` for disabling observing at all? I just thinking aloud - Like `CONFIG_KEYS` sounds reasonable. We could support and maintain it in the future, even after implementing the \"observability\" to the MetaManager then `ALWAYS_UPDATE` ... I don't know :)" }, { "prediction": "I think this should be `clang-format on` instead of `clang-format on`.", "reference": "A \"tab difference\"? As in, there are tab characters somewhere? This disabling of clang-format for all the code here seems like overkill. Are you sure there's not some other solution? I don't really understand the problem though. Do you mean clang-format-diff?" }, { "prediction": "I don't think this is needed.", "reference": "Could you please leave the explicit imports?" }, { "prediction": "I think this should be `methodConfigs.add(methodConfigMap.get(methodConfigProto.getName()))`", "reference": "Can we check for containsKey here?" }, { "prediction": "I think this should be `fmt.Fprintln(os.Stderr, usage)`", "reference": "Exit successfully. We served the help the user wanted." }, { "prediction": "I think this should be `InitialWorkingDir` instead of `InitialPackagePath`.", "reference": "Had to rename this because `InitialPackage()` already existed." }, { "prediction": "Line is too long. [98/80]", "reference": "Can we put this in a different helper?" }, { "prediction": "(style) code indent should use tabs where possible (style) code indent should use tabs where possible", "reference": "I'm not sure where your 31 comes from? I see 15 here and 2 above for pc and flags, for 17 total beyond the SIMD." }, { "prediction": "I think this should be `getTermsOfUse` instead of `getTermsOfUse`", "reference": "If you want, you could change this to `allowCors(response` (like in \"version\", above) to allow Cross-Origin Resource Sharing. I'm sort of wondering what's returned if no API terms of use are set." }, { "prediction": "I think this should be `onConfigurationChanged` instead of `onConfigurationChanged`.", "reference": "Why do we need to override this if all we're doing is passing it up?" }, { "prediction": "I don't think we need to send all controls here.", "reference": "Just wondering whether it's safe to send all CQDs to the child compiler. As this missing CQD is causing trouble, maybe some other user CQDs that now get sent could also cause the statement to fail? Also, if I have a table with a nullable unique column, should I have to set this CQD to create another table like it, or should the CREATE TABLE LIKE work without the CQD?" }, { "prediction": "I think this should be `DAGSTER_EARLIEST_RELEASE`", "reference": "EARLIEST_TESTED_RELEASE might be slightly more clear" }, { "prediction": "I think this should be `\\bpylint:\\s*([^;#]+)[;#]{0,1}`", "reference": "I think replacing `.*` with `\\s*` from after the hash makes sense, but not the rest of the changes." }, { "prediction": "I think this should be `bool` instead of `bool`.", "reference": "interesting .. did not know varint tag covered bool as well" }, { "prediction": "I think this should be `evloop_latency_ms` instead of `evloop_latency_ms`", "reference": "Could you please elaborate the reason for not using `gkc_summary` like the values above? I ask this, because I assume what we want to collect is a histogram of event loop latency, and we use `gkc_summary` for collecting histograms." }, { "prediction": "I think this should be `this.txs[t]._getHash()` instead of `this.txs[t]._getHash()`", "reference": "getHash should be a public and without an `_` if used here." }, { "prediction": "I think this should be `if blk.Height == 0 { return nil }`", "reference": "Unrelated to these changes -- we will probably want some special handling for genesis block validation." }, { "prediction": "I think this should be `SetDiskBlockCacheFraction(float64)` instead of `SetDiskBlockCacheFraction(float64)`", "reference": "This is probably overkill since we don't actually need to pass this specific interface anywhere, but I don't mind it!" }, { "prediction": "I think this should be `addr.ByteString()` instead of `addr.ByteString()`", "reference": "@janos I moved this back here, to avoid having multiple add peer calls being handled. I think it's either this or a global lock across the whole function. I think this is a better approach, especially since `hive.Broadcast` is blocking . We can remove the map entry on errors if needed. LMKWYT?" }, { "prediction": "I don't think we need the `form-button` tag here, but I think it would be better to use `form-button` instead of `form-button`.", "reference": "Minor: can we put the conditional outside of the partial?" }, { "prediction": "I think this should be `isinstance(offline, PacketList)` instead of `isinstance(offline, list)`", "reference": "We need to find something more efficient than this. We can probably just check the first element and assume the type list is consistent.." }, { "prediction": "I don't think we need this.", "reference": "How \" via service code in response to event.\"? I don't think we'll get in the no schedule option to the release. We should probably wait for some customer feedback first to make sure we're addressing different event-triggers the best way" }, { "prediction": "Why is this removed?", "reference": "Please move unrelated formatting changes to their own PR (same with the resources.py file)." }, { "prediction": "Why do you need to set window state to `Qt.WindowFullScreen` instead of `Qt.WindowFullScreen`?", "reference": "Make this a public attribute (remove the leading `_`) if you want to access it from the outside." }, { "prediction": "Why is this needed?", "reference": "this conditional is useless now so it should be removed" }, { "prediction": "I think this should be `static_cast(i+1)`", "reference": "`vecofstructs->size()` already returns a `uoffset_t`. So if you just change the type of `i`, you don't need any casts." }, { "prediction": "I think we should be able to do this in a separate PR. I think we should be able to do something like `if (configProto == null) { protoParser = new ProtoParser(true); } else { protoParser = new ProtoParser(true); }`", "reference": "Nit: Maybe merge this with the configProto check on line 208? Don't feel that strongly though, please keep separate if you prefer." }, { "prediction": "Why is this change needed?", "reference": "I know we already did this in 4.0 so carry on, but I'm facepalming here we should've made an overrided setMessageHandler that sets ismaster to true when hello is present. Esp in 4.0 where we already have some overrides written. We can keep going here and maybe open a ticket to some effect of that solution" }, { "prediction": "I think this should be `Skip to first result`", "reference": "I believe we could use `link_to` here (although not super important). Also, we should internationalize this value. I'm not 100% sure what our process is for adding new UI strings these days (e.g. skip the specs that will fail if we add a new key to only one language, use Google Translate to translate the value for us, some other option)." }, { "prediction": "I think this should be `result == VK_SUCCESS || result == VK_INCOMPLETE` instead of `result == VK_INCOMPLETE`", "reference": "This was already in vkGetPhysicalDeviceDisplayProperties2KHR..." }, { "prediction": "I think this should be `IsDockerEngineRunning` instead of `IsDockerEngineRunning`", "reference": "nit: I'd expect a public method called IsDockerEngineRunning to return a boolean yes/no, not the error message. Can we change either the return value or the name? Something like `CallDockerEngine`" }, { "prediction": "Why is this needed?", "reference": "If i remembered correctly, type_name is '{RESOURCE_TYPE}/{RESOURCE_NAME}', if type_name is 700 max then name cannot exceed that size" }, { "prediction": "I think this should be `if size_prefixed else 0` instead of `if not size_prefixed else 0`", "reference": "When calling functions with keyword arguments: please provide the arguments as keyword arguments, not positional arguments." }, { "prediction": "I think this should be `None` instead of `None`.", "reference": "We may follow the argument order: conv_cfg, norm_cfg, act_cfg." }, { "prediction": "I don't think we need this method anymore, but I think it would be better to use `profile_json` instead of `profile.as_json`.", "reference": "`options['binary'] = WebDriver::Chrome.path` if set?" }, { "prediction": "I think this should be `#include `.", "reference": "folly library should be put on the top." }, { "prediction": "I don't think we need to do this, but it's a good idea to do this.", "reference": "Do we have to restrict this to SVG elements? I think setting namespaced attributes on normal dom elements (while not as common) is still valid, so perhaps we can save some bytes by removing the `isSvg` check?" }, { "prediction": "Why do we need this hook?", "reference": "Please add it to the `REMOVED_HOOKS` constant." }, { "prediction": "I think this should be `var shadowSupport = axe.testUtils.shadowSupport;` instead of `var shadowSupport = axe.testUtils.shadowSupport;`", "reference": "This variable needs `.v1` at the end of it, or the tests below need it. There are some test failures as a result" }, { "prediction": "I think this should be `@account = Account.find_by(id: params[:id])` instead of `@account = Account.find_by(id: params[:id])`.", "reference": "Is this access protected so that only admins can access this route?" }, { "prediction": "(style) line over 80 characters", "reference": "What happens if the minimum x coord is > 0? This will incorrectly set it as zero, right?" }, { "prediction": "I think this should be `if o.maxp > 0 && batchSize > o.maxp {`", "reference": "I think you want to look at current pending + batchSize and if that is > o.maxp no?" }, { "prediction": "I think this should be `ok` instead of `internal`.", "reference": "Should this be `codes.Error`? `codes.Internal` was an error status before." }, { "prediction": "Align the parameters of a method call if they span more than one line.
Space inside } missing.", "reference": "I don't think you need these lines." }, { "prediction": "Why is this change needed?", "reference": "You didn't mean to export this, right?" }, { "prediction": "I think this should be `v3` instead of `v3`.", "reference": "Simple Notification **Service** (singular)" }, { "prediction": "why not just `egressConfig *config.EgressConfig`?", "reference": "Do we still need this?" }, { "prediction": "Why is this removed?", "reference": "We do have a disconnect between the privateMarkerTransactionFactory.getSender() call and the createPrivateMarkerTransaction() call. When the plugin receives the call to create the PMT it does not know what the sender was returned by the other call. At a minimum we need to pass in the sender to the second call. I would prefer that the plugin does the locking if that is necessary. If you are using random keys you don't have to lock! Besu could signal to the plugin when a PMT was un- or successfully added to the pool using a callback. Callback could be null if this is not needed. The plugin would have to be able to get the nonce for a certain key from besu. What do you think?" }, { "prediction": "Why is this change needed?", "reference": "This is a bit inconsistent with the `ErrorStartHourGreaterThanEnd` in the previous file. Wouldn't `ErrorDefault``fit better here?" }, { "prediction": "I think this should be `testing.TB`", "reference": "I think it will revert the change @antoninbas did on purpose 05eee251c9c53400277def576f92d614ca234898" }, { "prediction": "why is this needed?", "reference": "nit: a switch perhaps?" }, { "prediction": "I think this should be `type=\"application/opensearchdescription+xml\" rel=\"search\"`", "reference": "Would it make sense for `opensearch_description_tag` to have default values for the title and href attributes?" }, { "prediction": "I think this should be `errTLFJournalDisabled` instead of `errTLFJournalDisabled`.", "reference": "Just noticed this while debugging -- it's unlikely to be causing issues in practice." }, { "prediction": "I don't think we need a timeout here, but I think it's better to use `timeout: 750` instead of `timeout: 750`.", "reference": "That seems unrelated - did that fix a random test failure you noticed while working on this issue?" }, { "prediction": "I think this should be `base != null && base.lastUpdatedMillis() != null`", "reference": "This kind of concern should be handled in the `TableMetadata` update methods. This is similar to `metadata.rollbackTo`, which not only sets the current version, but also updates the table history. I think that all of those methods should add the current object's `file.location()` to the previous metadata location list, if it is non-null. That way, the caller never needs to remember to update it." }, { "prediction": "I think this should be `collect_mlvl_tensor_multi` instead of `collect_mlvl_tensor_multi`.", "reference": "We need to know why all the tensors are detached in `get_bboxed`." }, { "prediction": "I think this test should be removed.", "reference": "Unrelated but shouldn't this raise `attribute-defined-outside-init`?" }, { "prediction": "Why is this set to `True` instead of `False`?", "reference": "I would rather no have this as a `kwarg` as it encourages \"growth\" which lead to an unweildy constructor in other classes. Let's add a method or property to take care of this instead as I think it's usage is going to be quite low." }, { "prediction": "Line is too long. [98/80]
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "You just changed my life :) I grew very attached to this safe nav approach when working with Groovy years ago `obj?.method`. Glad to see its now a part of Ruby!" }, { "prediction": "I don't think we need to add the `clear-fix` class here.", "reference": "do you mean 'clearfix' class?" }, { "prediction": "I think this should be `options.causalConsistency = true` instead of `options.causalConsistency = true`", "reference": "`causalConsistency` is already defined on `SessionOptions`. We do not need to duplicate it here." }, { "prediction": "Why is this change needed?", "reference": "This should not be included since there are no code changes." }, { "prediction": "I think this should be `if len(setting.HTTP.AccessControlAllowOrigin) > 0`", "reference": "If all we need just response 200, then we could use `c.Status(http.StatusOK)` here." }, { "prediction": "I think this should be `node.Get(ctx, model.ResourceKey{Kind: apiv2.KindNode, Name: hostname, Namespace: \"\"})`", "reference": "Should be checking for error here" }, { "prediction": "Why is this change needed?", "reference": "Put a space between `(array)` and `$this` and I'll merge it" }, { "prediction": "I think this is a good idea, but I don't think it's a good idea to make it a stub, but I'm not sure if it's a good idea to make it a stub.", "reference": "You could add this to stack.go, which has similar functions (to avoid yet another small file). None of these are likely to be implemented considering what TinyGo is designed for." }, { "prediction": "I think this class should be `NotificationHolder` instead of `NotificationContent`", "reference": "the class names `NotificationHolder` and `NotificationsHolder` are fairly difficult to quickly tell apart, particularly since they are often used close to each other" }, { "prediction": "I don't think this is needed.", "reference": "Avoid wildcard imports" }, { "prediction": "Why is this change needed?", "reference": "Need to do this to unblock mockgen. The interface method needs to be public to be visible in another package. The right fix is to delete this test only interface method" }, { "prediction": "I think this should be `items.some(k => k !== 'loadbalanced' && k !== 'authSource' && k !== 'replicaSet')`", "reference": "same question here as I have on the other file regarding doing this check here vs L112 vs not at all" }, { "prediction": "I think this should be `build!openbsd`", "reference": "Adding `// +build !windows` (as a separate line) will do the same for Windows. So while you are at it we might add it as well." }, { "prediction": "Why is this removed?", "reference": "this is used as important way of mocking for unit tests, FYI" }, { "prediction": "I think this should be `muted_alpha=0.2` instead of `muted_alpha=0.2`", "reference": "Sorry, should have been clearer, I meant adding this to the ``Histogram`` options one line above." }, { "prediction": "Why is this change needed?", "reference": "Just ignorance on my part, but what is the significance of the change from C23NHe2 to C23NHx2?" }, { "prediction": "I think this should be `Optional[np.ndarray]` instead of `Optional[np.ndarray]`.", "reference": "What about tuples or pandas series? Do we want to support lots of different types or force a single type?" }, { "prediction": "Why is this removed?", "reference": "Small thing, without the check above this will throw a NoNodeException if the path doesn't exist. Maybe this can be wrapped in a try/catch just for the NoNodeException, so that the more user-friendly message used above can be thrown instead: `throw new KeeperException.NoNodeException(\"No collection found at path: \" + path);` Just a thought, I'm not even sure it's worth it." }, { "prediction": "Align the parameters of a method call if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "I don't know why this worked before, but we should be explicit on not verifying that a blank string (allowed as a way to remove a url/download_url) is a valid url as it is not." }, { "prediction": "I think this should be `support` instead of `support`.", "reference": "Do we want to raise an error here instead of warning? Or would it be better to just see if Bolt happens to succeed, and let it fail on it's own if it fails? I'd lean towards raising an error, but that's different from \"removing support\"." }, { "prediction": "I don't think we need this method anymore, but I think it's better to use `self.filter_options` instead of `self.filter_options(unfiltered)` instead of `self.filter_options(unfiltered)`", "reference": "This is kind of confusing with the other `filter_options`." }, { "prediction": "I think this should be `ops.deleteFromFavorites(ctx, fs.favs)`", "reference": "Could the `deleteFromFavorites` happen when `head == nil` because it's not initialized yet somehow but not because TLF doesn't exist? I was concerned if this would make it possible in any way to have favorites seemingly deleted on a device while it's not actually happened on server." }, { "prediction": "I think this should be `int64_t rowCount = 0;`", "reference": "It doesn't look like this particular \"rowCount\" variable is used anywhere. I suppose we could delete it. The code change is harmless though." }, { "prediction": "I think this should be `http.StatusOK` instead of `http.StatusNoContent`.", "reference": "Hmm, probably we should instead write whatever `status` is returned instead of coding a special case." }, { "prediction": "I think this should be `out.HTTPMatch = &proto.HTTPMatch{Methods: in.HTTPMatch.Methods}`", "reference": "Could using the pointer-to-struct approach here cause confusion later? We've had several problems of that kind in the past. What does it mean if the struct is non-nil but its fields are nil? Is that even allowed? (libcalico-go question) Are there any validation requirements for this new rule addition; should it only be allowed if `Protocol == TCP`, for example?" }, { "prediction": "Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
Layout/Align the elements of a hash literal if they span more than one line.", "reference": "why this recursive relationship definition?" }, { "prediction": "I think this should be `optional` and `used for introspection`.", "reference": "More sentence, less list please. > Encoding of the handler. This field is optional. We don't need to mention exactly what it's used for because that list can expand (as it has already in this change)." }, { "prediction": "I think this should be `gocloud.dev/blob/bytes_read` and `gocloud.dev/blob/bytes_written`", "reference": "Not part of this PR, but should the section above say what the name of the metric is for each method?" }, { "prediction": "Why is this needed?", "reference": "there are changes that are upcoming to this section. For now, this works (to demo the usage of Gauge), and the changes to this section are coming as separate PRs." }, { "prediction": "Why is this change needed?", "reference": "This is equivalent to stdout. Why not just replace stdin with stdout in `IsProcessBackground`?" }, { "prediction": "I think this should be `if (p_jmsg[\"compress_method\"] != nullptr)`", "reference": "Rather than test for nullptr, just treat the pointer as a bool, i.e. `if(p_jmsg[\"compress_method\"])`" }, { "prediction": "I think this should be `if (!executablePath.startsWith(getContainersPath()) && !executablePath.startsWith(getContainersPath()) {`", "reference": "Can we move the remaining code of this method to a new method? I don't like the `return;` here, we could try to replace it with an `if ... else ...` syntax. What do you think?" }, { "prediction": "I think this should be `for_resource_changed` instead of `for_resource_changed`.", "reference": "nitpick: _and collections_" }, { "prediction": "I don't think this is needed.", "reference": "I believe these need to be explicitly initialized in `proxy_send_prepare`" }, { "prediction": "I think this should be `time.time()` instead of `time.time()`", "reference": "This is unnecessary. The declaration of `t0` on line 179 is still in scope inside the `except` block." }, { "prediction": "I don't think this is a good idea, but I think it would be better to use `@beautiful.border_color_marked` instead of `@beautiful.border_color_marked`.", "reference": "The `border_color_`... properties don't support solid colors, not only this one. Maybe `@param solid_color` should be used instead of adding this note to every one of them?" }, { "prediction": "I think this should be `/javascript/grid-ui/src/tests/**/*.test.tsx` instead of `/javascript/grid-ui/src/tests/**/*.test.tsx`", "reference": "We don't need this file, we can use the one that is in the grid-ui directory" }, { "prediction": "I think this should be `if (!isEmptyLine(path)) { continue; }`", "reference": "FYI: inlined this method in the internal review." }, { "prediction": "Why is this removed?", "reference": "Werid, the checksum between this file and the one on branch `develop` is the same not sure why it's showing a diff" }, { "prediction": "I think this should be `metric.Meter.Name + metric.Name` instead of `metric.Meter.Name + metric.Name`", "reference": "Prometheus doesn't have concept of Meter (like OTLP does).. Trying to see if this is a good approach to use the meter name as namespace, to avoid name collisions, when same instrument name is used across multiple instruments, from different Meter." }, { "prediction": "Why is this needed?", "reference": "The formatting of this is a bit strange; I'd suggest collapsing this back to a single line, and moving the `&&` to the beginning of the second line to meet the line length restriction." }, { "prediction": "I think this should be `if (segments != NULL && segments != NULL)`", "reference": "One or the other should be non-NULL. If segments is NULL, the alloc above will have size zero, which we do not allow (there's no header): it should assert in debug build. So there should be asserts that one is non-NULL at the top, and if there really needs to be some kind of defensive check down here, it should cover the alloc too." }, { "prediction": "I think this should be `user.find_or_create_by(email_address: user_data['email'])`", "reference": "I'm surprised rubocop isn't picking up singe quotes?" }, { "prediction": "I think this should be `unixTimestamp` instead of `unixTimestamp`", "reference": "Is this line still needed?" }, { "prediction": "Why is this needed?", "reference": "Maybe use specific values for all the watt.times fields? Even better, have a const for it at the top of the file?" }, { "prediction": "I think we should use `os.path.join(TABLES_DIR, \"braille-patterns.cti\")` instead of `os.path.join(TABLES_DIR, \"braille-patterns.cti\")`", "reference": "nit: UNICODE_BRAILLE_TABLE or something might be a better name for this. IMO, braille-patterns.cti is a terrible name. This table allows Unicode braille characters to be used anywhere to produce raw dots." }, { "prediction": "Why is this removed?", "reference": "Why are we removing the option to skip machine pool generation?" }, { "prediction": "I think this should be `public static void OnStartLine(HttpMethod method, HttpVersion version, Span target, Span path, Span query, Span query, Span query, Span query, Span query, Span query, Span customMethod)`", "reference": "\"Request line\" here too." }, { "prediction": "I think this should be `if (parse->EventPlayer(EVENT_LOOT_ZONE, entity_list.GetNPCByNPCTypeID(ZONE_CONTROLLER_NPC_ID)) != 0`", "reference": "Please remove this." }, { "prediction": "Use 2 (not 3) spaces for indentation.", "reference": "Weird bug. Combining those joins and group calls was triggering AREL to generate the sql cache inside of will_paginate before the final call. This is a harmless workaround, but hints that will_paginate might becoming seriously deprecated." }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "This can be simplified as discussed before." }, { "prediction": "I think this should be `table.Table`", "reference": "Does `internal` or `test` in the file name actually do anything here? Or is that just to show these functions are only for tests?" }, { "prediction": "Why is this change needed?", "reference": "does this boolean indicate unsafe serialization?" }, { "prediction": "This is not implemented for node.js.", "reference": "Maybe rewrite to `Is only implemented for React Native`? (I assume that is the case)." }, { "prediction": "I don't think we need to check if the resources field is a map.", "reference": "Do we not need this in Java because Java *is* handling map responses?" }, { "prediction": "I think this should be `True` instead of `False`.", "reference": "Maybe \"For configuring which scheduler messages can be received.\"?" }, { "prediction": "I think this should be `getObjectManager`", "reference": "It will stop working with orm, so this is not a good fix, Try using some method in a common interface" }, { "prediction": "Why is this needed?", "reference": "`s` is not necessarily the same as `sampler` - sampler could be null and this crazy lambda underneath falls back to something. So please use `s`" }, { "prediction": "I think this should be set to `HttpParameterType.BODY` instead of `HttpParameterType.BODY`.", "reference": "This code is a bit confusing. Should HttpParameterType set to the original one or it is always BODY?" }, { "prediction": "I think this should be `!isTest` instead of `!c.state.Config.Remote.VerifyOutputs && !isTest`", "reference": "Why did this change?" }, { "prediction": "I think this should be `newProtoForTableStatus(result.Table.TableStatus)`", "reference": "nit: `status` collides with imported package named `status`" }, { "prediction": "I think this should be `l.accts.IsWritingCatchpointFile()`?", "reference": "\"memory pressure could be decreased\" --> \"to avoid memory pressure\"" }, { "prediction": "I think this should be `random.randint(2000, 1 << 31)`", "reference": "I think it would make sense to fetch the cache values after deleting the listens and making sure they are what we expect." }, { "prediction": "I think this should be `collapsibleColumns` instead of `collapsibleColumns`", "reference": "I'm thinking about covering this change with the test. Can you do that?" }, { "prediction": "I don't think we need to pass the `cPorts` and `pPorts` to the `PingProvider` interface.", "reference": "Not sure if it's a good idea to remove stop channel. If user cancels connection how will you stop pinger?" }, { "prediction": "I think this should be `docker.AuthConfiguration{Username: sdkAuthConfig.Username, Password: sdkAuthConfig.Password, ServerAddress: sdkAuthConfig.ServerAddress, Email: sdkAuthConfig.Email, ServerAddress: sdkAuthConfig.ServerAddress, }`", "reference": "Could you please add a `TODO` here that we won't need `docker.AuthConfiguration` anymore when we migrate to SDK's pull image?" }, { "prediction": "I think this should be `public ITaskItem[] BlobNames { get; set; }`", "reference": "Is there a scenario were we want to get an arbitrary set of blobs that don't share a common root?" }, { "prediction": "I think this should be `!spec.description.match(/type=regex/);`", "reference": "Can you leave a note about why we are skipping regex tests?" }, { "prediction": "I think this should be `InitFSRepo` instead of `InitFSRepo`.", "reference": "This was the only caller of CreateRepo, so I inlined it." }, { "prediction": "I think this should be `authPath`", "reference": "As this is already a child of `auth`, I think we can shorten this to `path`" }, { "prediction": "I think this should be `textInfos.POSITION_FIRSTVISIBLE` instead of `textInfos.POSITION_LASTVISIBLE`.", "reference": "This call should use element, not 0 I think." }, { "prediction": "I think this should be `config:\"fetch_until_empty_page\"`", "reference": "This is missing the definition of `fetch_until_empty_page` - it needs to go in the config section above." }, { "prediction": "Line is too long. [98/80]", "reference": "I don't think this one needs to be changed since the only previous path is already an absolute one." }, { "prediction": "I think this should be `table.locationProvider()` instead of `table.locationProvider`", "reference": "Since we kept the original constructor we might not need this change now." }, { "prediction": "I don't think we need to log the full name here.", "reference": "There is already a log in `BaseMetastoreTableOperations` for this. It has the location, but not the table name. Maybe just add table name to that one." }, { "prediction": "I think this should be `github.com/pipe-cd/pipe/pkg/filestore/minio`", "reference": "This should be in the last group." }, { "prediction": "I think this should be `_statsd?.Send()` instead of `_statsd?.Send()`", "reference": "I believe you should either remove this or rename the PR. You can't change the behavior of the tracer (even to fix a bug) in a PR named \"unit test improvements\"" }, { "prediction": "I think this should be `certmanager.k8s.io`", "reference": "I've gone with this group name, however I'm open to suggestions on alternatives!" }, { "prediction": "I think this should be `QUORUM`", "reference": "should this be GOQUORUM" }, { "prediction": "I think this should be `checkCoinbase` instead of `checkCoinbase`", "reference": "I think checkCoinbase is not skipping checking coinbase. Instead, true-> checking num(coinbase tx) = 1, false -> checking num(coinbase tx) = 0." }, { "prediction": "Why is this change needed?", "reference": "same here, move it out" }, { "prediction": "I think this should be `#if defined(KOKKOS_ENABLE_LIBDL) || defined(KOKKOS_TOOLS_INDEPENDENT_BUILD)`", "reference": "Can you elaborate on why you need different behavior depending on Tools being built independently or not?" }, { "prediction": "Align the parameters of a method call if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "because of the above if statement will requires both ex_save and guid_save to be true, this code will always return 'example answer'. This should be revised with `example_answer.present?` and `guidance.present?`" }, { "prediction": "I think this should be `golang.org/x/net/context`", "reference": "why not context from stdlib?" }, { "prediction": "Why is this change needed?", "reference": "Just saw this and wasn't able to hold myself from renaming :-)." }, { "prediction": "Why is this change needed?", "reference": "Can we keep the other assertion too? I think it's helpful to ensure that the uninstall function was called too" }, { "prediction": "I think this should be `RSpec.warn_with <<-WARNING.gsub(/^ +\\|/, '')`.", "reference": "`warn_with` prefixes the message with `WARNING:`, right? So this will put `WARNING:` twice. It would be good to verify all the warnings look good after this change, given how easy it is to make a simple mistake like this :(." }, { "prediction": "I think this should be `MessageTimeOut` instead of `MessageTimeOut`.", "reference": "FYI In the message queue I use the term \"stamp\" to refer to the time-like mark associated with each message. It's opaque to the queue/pool and should make no difference if the stamps and age limit were converted to seconds. So this could then become `Stamper` with `CurrentStamp()` method, no reference to \"blocks\" or height etc. The wrapper struct could be `StampedMessage. The interpretation as block height is deferred to the user/constructor that hooks things up, the \"business logic\". This is just an observation, take or ignore as you wish." }, { "prediction": "I don't think we need to check if the bucket exists.", "reference": "Can we remove the `TODO` statement here? (as this is actually fixed in this PR)" }, { "prediction": "I think this should be `mDisplayPreference`", "reference": "m prefix no longer in code style" }, { "prediction": "I think this should be `[][]byte` instead of `[][]byte`.", "reference": "need to filter the entities in buffer as well" }, { "prediction": "I think this should be `de.danoeh.antennapod.core.glide.FastBlurTransformation`", "reference": "Please add spaces before and after the equals sign" }, { "prediction": "I think this should be `#include \"common/sql.error_event.pb.h\"`.", "reference": "This file could also be cleaned up/deleted. But lets do this separately after ensuring all the event logging has been ported to the current logmxevent_traf.cpp file completely." }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": ":thinking:, the line number here is the line of the example (`example.location`), that's probably why I finally chose to display the example title because it's what can be found on this line, and saying that the error is from there is confusing. But presenting the actual failures is indeed better, so maybe we can get the failure actual line number from the exception backtrace and then output two distinct lines for failures like this one?" }, { "prediction": "I think this is a bit confusing to me, but I think it would be better to add a `create_no_window` argument to the constructor.", "reference": "We shouldn't add this as a new `kwarg` here. This should all be done on the options class" }, { "prediction": "I think this should be `true` instead of `false`.", "reference": "Should this be `OS_VOLUME_SUPPORT` to match the symbol key names?" }, { "prediction": "Why is this needed?", "reference": "In C, file scope variables are already initialized to 0 so the \"= NULL\" is redundant. Not a big deal." }, { "prediction": "Why is this change needed?", "reference": "on line 40, the `relevantNode` can change and therefore the `doc` might change too for the lookup on line 43. I think this code should be moved to where the `doc` is actually being used" }, { "prediction": "I think this should be `string.Format(CultureInfo.InvariantCulture, \"milliseconds must be between {0} and {1}\", MinMilliseconds, MaxMilliseconds);`", "reference": "nit: just to be similar to others, can you change to interpolation?" }, { "prediction": "I think this should be `true` instead of `false`.", "reference": "Would this make more sense as an option on an Issuer resource (specifically on the CA issuer) rather than as a flag? It's not ideal that we have a flag that _looks_ like it could be 'global' but is actually not IMO. Also, if Istio is reading the CSR object, is it possible for it to read the CA from the CSR itself too and append the two instead? Not sure if we ever decided whether to use annotations for this purpose @JoshVanL?" }, { "prediction": "I don't think this is necessary.", "reference": "Because this acts as a coordination point between client and server, it should go in core.py instead of const.py (so eventually the server could use it to guarantee that it delivers dates in the expected format)." }, { "prediction": "I think this should be `return nil, err`", "reference": "expected statement, found 'else' (and 1 more errors)" }, { "prediction": "I think this should be called `MakeRandomID` instead of `MakeRandomID`", "reference": "IMO this doesn't need to be in the `kbfs` repo. And I don't like setting the byte. We can always compare with the randomly generated `TlfID`." }, { "prediction": "I think this should be `EdgeControllerModuleName`", "reference": "What's the difference from ModuleName in `pkg/apis/meta/v1alpha1/types.go`?" }, { "prediction": "I think we should remove the `System.Security.Cryptography` class from the `System.Security.Cryptography` class.", "reference": "We shouldn't be changing this task as we are trying to break our dependency on it and switch to using the shipped version." }, { "prediction": "(style) line over 80 characters", "reference": "Shouldn't we have a low bar for generating out-of-line context switch, i.e., if we need save more than n (3?) simd or m (4) gprs we should go out-of-line? And it should be || instead &&. It seems the bar is still very high after this change." }, { "prediction": "I think this should be `go.opentelemetry.io/otel/sdk/instrumentation`", "reference": "Should the API have a dependency on the SDK?" }, { "prediction": "I think this should be `it.skip` instead of `it.skip`", "reference": "Is this a sometimes leaky test?" }, { "prediction": "I think this should be `for _, f := range ftv { f := v.cs.f.Fresh() if ftv.contains(f) { f = v.cs.f.Fresh() if ftv.contains(f) { f = v.cs.f.Fresh() if ftv.contains(f) { f = v.cs.f.Fresh() if ftv.contains(f) { f = v.cs.f.Fresh() } }`", "reference": "It should be possible to create a test case that enter the loop. That would be a good enough test case for me. Have a look at the extern type inference test cases that already exist. Since you can just pick the type variables the extern type use, you should be able to create a conflict that requires this loop to fix." }, { "prediction": "I don't think we need to do this, but I think we should be able to use `locale.FindLanguageInfo` instead of `locale.IsAvailable` here.", "reference": "It might make sense to log this." }, { "prediction": "I don't think we need to do this, but I don't think we need to do it in the `deep_dup` method.", "reference": "Line is too long. [84/80]" }, { "prediction": "I think this should be `goog:chromeOptions` instead of `goog:chromeOptions`", "reference": "nice touch since Google likes to change things every now and then." }, { "prediction": "I don't think we need to do this in a separate PR.", "reference": "Thank you this is so much nicer than the old `Rails.configuration.branding['blah']['blah']['blah']` :)" }, { "prediction": "I think this should be `BACKEND_SERVICE_NAME` instead of `BACKEND_SERVICE_NAME`.", "reference": "nit: Would you mind alpha-sorting this?" }, { "prediction": "I think this should be `manifest.content() == ManifestContent.DELETE`", "reference": "For my understanding, the DATA manifest & DELETE manifest could share the same read / write path so I think we could use the common reader+writer. Is there any other reason that we need to make them separate paths ?" }, { "prediction": "Align the parameters of a method call if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Space inside } missing.", "reference": "that change should be sufficient for avoiding the override of contact_us_url helper. The one defined at the .yml it is within a hash so no problem should arise." }, { "prediction": "Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "We actually had a discussion about this exactly in #3470, some languages seem to go for one, some for the other " }, { "prediction": "I think this should be `GrpcStreamingDetailView` instead of `GrpcStreamingDetailView`.", "reference": "Is PHP the first dynamic MVVM language with grpc streaming support?" }, { "prediction": "I think this should be `if (tmpStream) { delete tmpStream; }`", "reference": "the `if` isn't necessary here; it's safe to call `delete` on `nullptr`" }, { "prediction": "I think this should be `return impl_->remove_all_changes(removed);`", "reference": "Change if the method's name finally changes to `clear_history` as proposed elsewhere" }, { "prediction": "I think this should be `documentationUtils.getDocFilePath(\"userGuide.html\")`", "reference": "can this one also be moved to the top of the file?" }, { "prediction": "Why is this needed?", "reference": "So if I understand this correctly the externalEntities should be computed and stored in GroupMember, while current code usage of GroupMemberPod will be migrated to GroupMember later?" }, { "prediction": "I think this should be `Datadog.SpanType`", "reference": "Don't we have tests to change after this breaking change? probably we're not using hard coded strings in our tests when we create a `Span`?" }, { "prediction": "I don't think we need to change the environment variable to `GOOGLE_APPLICATION_CREDENTIALS`.", "reference": "will this fail if the env variable doesn't exist? Is this the preferred behaviour?" }, { "prediction": "I think this should be `numpy.array([0.01 * self._random.getReal64() for i in xrange(self._numColumns)], dtype=realDType)`.", "reference": "bad line wrap" }, { "prediction": "Why is this needed?", "reference": "What does the `8` here represent? Can you give it a name?" }, { "prediction": "I don't think we need to use `os.environ[\"MP_API_KEY\"]` here, but I think it would be better to use `os.environ[\"MP_API_KEY\"]` instead of `os.environ[\"MP_API_KEY\"]`.", "reference": "`MPRester(os.environ[\"MP_API_KEY\"])` can be left simply as `MPRester()` and it will pick up the API key from the environment. What is the purpose of this file otherwise? Is it better suited for `dev_scripts`, or a test?" }, { "prediction": "Line is too long. [103/80]", "reference": "Looks like there may be more changes to this file than intended?" }, { "prediction": "I think this should be `continue` instead of `continue`", "reference": "when message type is not expected, contine to next loop instead of return to finish infinite loop" }, { "prediction": "I think this should be `testing`", "reference": "This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards." }, { "prediction": "I think this should be `delete(oldAWSMachineSpec, \"instanceID\")`", "reference": "instanceID should stay the same for a AWSMachine?" }, { "prediction": "I think this should be `NO_DOWNLOAD=false`", "reference": "Since this is a dict don't you want `False` or do we clean that up elsewhere?" }, { "prediction": "Why is this needed?", "reference": "what's the reason you had to add the `host` argument to all `get_work` calls?" }, { "prediction": "I think this should be an instance of Dataset, not an instance of Dataset.", "reference": "This will never be a dataset so we can simplify the code here" }, { "prediction": "I think this should be `final` instead of `final`.", "reference": "This should be moved into the PrivacyBlockProcessor instead of adding the constructor here." }, { "prediction": "I don't think we need this import.", "reference": "nit: Remove \"insightfilestore\". I think \"insightstore\" is good enough and as I see we are using that name at other places too." }, { "prediction": "I think this should be `@round_count == 3` instead of `@round_count == 3`.", "reference": "It looks like you've removed `bisect_round_finished` but kept `bisect_round_started`. Seems a little odd that they aren't paired. Not sure if there's anything to do about that though..." }, { "prediction": "Why do you need this?", "reference": "I'm not sure how to fix the lint and mypy warnings on this line. I could just ignore them, but I feel like the linter should know this exists." }, { "prediction": "Why is this removed?", "reference": "why remove `Symbol`?" }, { "prediction": "I think this should be `\u00a3\u00a2\u00a5\u00a7\u20ac`", "reference": "Why are currency signs considered punctuation? They technically fall under the BMP range for Currency Symbols `\\u20A0-\\u20CF` (covered in `getUnicodeNonBmpRegExp`, which is itself a misnomer)" }, { "prediction": "I don't think we need to add the maintainer here.", "reference": "You have forgotten a coma `,`" }, { "prediction": "I think this should be `os.path.basename(img_meta['filename'])`", "reference": "For different datasets, we may want to save the images differently. Sometimes the datasets are categorized into several subfolders, and we want to keep it when saving visualization results, and sometimes we just want to save all images in `out_dir`. An argument may be added to control the behavior." }, { "prediction": "I think this should be `if (cmp != 0 || bb.get(ia) != '\\0') {`", "reference": "if `other` could have a guaranteed `0` byte in it, this whole `if` could be removed, and above you could just add `|| c2 == '\\0'` to get the same effect?" }, { "prediction": "I don't think we need to change the method name to `wrapCaseSensitive`", "reference": "nit: can this be a primitive value?" }, { "prediction": "I think this should be `u.Path[len(u.Path)-1] != '/'`", "reference": "This maybe not what we want. If `rewrite` occurred before, `r.URL.Path` contains the result and we should use it. Otherwise `rewrite` middleware will disfunction when combining with `browser`." }, { "prediction": "why is this change needed?", "reference": "Why change this?" }, { "prediction": "Why is this change needed?", "reference": " _nitpick_ Isn't it now actually NotLogFakeHttpExceptions**Error**Listener ?" }, { "prediction": "I think this should be `resourceType` instead of `resourceType`.", "reference": "Why not just look for the \"type\" property instead of creating a ResourceType property?" }, { "prediction": "Why is this needed?", "reference": "should use `bc.config.Blockchain.ChainID`" }, { "prediction": "Why is this removed?", "reference": "this doesn't need to know about NativeClient" }, { "prediction": "I think this should be `violation.get('rule_name', '')`", "reference": "I know we discussed if we should add in the resource_name to the hash, and I actually don't think it's required. The violation hash was recently updated (not released) to include the violated rule, so when the next release goes out, user's findings will get updated. The resource name doesn't hurt to have here, but not required." }, { "prediction": "I think this should be `int scale = surface->current.scale;` instead of `int scale = surface->current.scale;`", "reference": "The variable name is also misleading imo. The width from the buffer comes from `wl_shm_buffer_get_width` (or a similar EGL thing), which is what gets encoded into `surface->texture->width`." }, { "prediction": "I think this should be `self.data['recording_msid']` instead of `self.recording_msid`.", "reference": "Why are you using these tags to carry these msids?" }, { "prediction": "I think this should be `malloc(flb_sds_len(tmp) * sizeof(char)) + 1`", "reference": "flb_strdup() should do the work here. note: use Fluent Bit memory wrappers" }, { "prediction": "I think this should be `protoc` instead of `protoc`", "reference": "This line should be separated from the package declaration by one line as it is not the package description." }, { "prediction": "Why is this change needed?", "reference": "shadow: declaration of \"err\" shadows declaration at line 410 (from `govet`)" }, { "prediction": "Why is this removed?", "reference": "Maybe next time better to make separate PR?" }, { "prediction": "I think this should be `if not torch.onnx.is_in_onnx_export():`", "reference": "line 316 also handles this case, need to simplify the logic." }, { "prediction": "I think this should be `gcsblob.OpenBucket: bucketName is required`", "reference": "We used to have a simple check for bucket and object names, we then decided to remove it and rely on the backend service to check for the name. Is there any reason to add an empty name check now?" }, { "prediction": "I don't think you need to use `std::chrono::duration_cast` here.", "reference": "Line too long" }, { "prediction": "I think this should be `dodge` or `hourglass`.", "reference": "This isn't aligned though." }, { "prediction": "I think this should be `assert with_nms, 'PAA only supports \"with_nms=True\" now'`", "reference": "it is mean -> it means PAAHead does not support test-time augmentation." }, { "prediction": "I don't think we need to import `plugins` from `bibdocfile.registry`.", "reference": "@lnielsen-cern thanks. I missed it :(" }, { "prediction": "Why is this change needed?", "reference": "@tofumatt, has it been changed intentionally? It doesn't seem to be required in IB, plus we haven't had `content-drilldown` before... If it has been changed intentionally, then should we update the `AnalyticsDashboardWidget` component to be use `content-drilldown` instead of `content-pages` as well?" }, { "prediction": "I think this should be `retrying` instead of `retrying`.", "reference": "nit: don't think an extra line is needed here; as retrying is an installed library and should be grouped with the rest of the installed library." }, { "prediction": "I think this should be `true` instead of `false`.", "reference": "This should be a bool" }, { "prediction": "Why is this change needed?", "reference": "`if (llvm::dyn_cast_or_null(GetSwiftType(compiler_type).getPointer())` ?" }, { "prediction": "Why is this change needed?", "reference": "The `generateVariantWorkloadManifests` function below relies on the config manifests specified in Git, but it was passed with the newly created canary's manifests where their name was updated." }, { "prediction": "Why is this removed?", "reference": "are this docs neccesary ?" }, { "prediction": "Why is this change needed?", "reference": "Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC." }, { "prediction": "I think this should be `softmax_param.clear_loss_weight();`", "reference": "This change suppose to resolve issue #2968. `loss_weight` should be of length 2, the second entry is ignored." }, { "prediction": "I think this should be `return filesToIgnore[base] || strings.HasPrefix(base, \"._\")`", "reference": "Is there an easy way to check for conflict suffix to avoid false positives here?" }, { "prediction": "I don't think we need to do this in the `apply_prep` method, but I think it's better to do it in the `get_validated_task` method.", "reference": "`apply_prep.run_task` also seems like it can just use `@context.run_task`" }, { "prediction": "I don't think we need to wait for all sections to load.", "reference": "do you have any idea on how to fix it?" }, { "prediction": "I think this should be `assert dst.closed`", "reference": "You don't need to fix this (you've done so many iterations). But for next time, you can make this into a docstring so it'll have a nicer descriptive name when the tests are running." }, { "prediction": "I think this should be `HasExpired` instead of `HasExpired`.", "reference": "When does 'expiresAt' change? Do you need this?" }, { "prediction": "I don't think this is a good idea, but I think it would be better to use `const Outfit[] outfits = Outfits::getOutfitByLookType(PlayerSex_t sex, uint16_t lookType);` instead of `const Outfit[] outfits = Outfits::getOutfitByLookType(PlayerSex_t sex, uint16_t lookType);`", "reference": "There are enums for genders + `PLAYERSEX_LAST`." }, { "prediction": "I think this should be `RollupBaseTxSize + len(data)`", "reference": "Should this use the constants as well? Or intentionally covering the fact that the constants may change" }, { "prediction": "I think this should be `if len(self.best) >= 0`", "reference": "The case of a negative size (= keep all elements) was not handled in this function." }, { "prediction": "I think this should be `system.enableInfiniteTimeout`", "reference": "I think we should keep this dynamic config knob for operations purpose." }, { "prediction": "Why is this removed?", "reference": "Was this intentional? Perhaps this could be replaced with another way to check the offsets?" }, { "prediction": "I think this should be `artifacts.Bucket` instead of `artifacts.Bucket`.", "reference": "the buckets are created via the stackset, customers don't need to provide them" }, { "prediction": "I think this should be `params.merge(blacklight_config.qt)` instead of `params.merge(blacklight_config.qt)`", "reference": "This doesn't have the same behavior as before. Maybe you want `reverse_merge` (and it either just works or we implement it on `Blacklight::Solr::Request`)" }, { "prediction": "I think this should be `export PATH=/usr/local/ghc/bin/ghc/#{ghc_version}/bin/:PATH` instead of `export PATH=/usr/local/ghc/bin/ghc/#{ghc_version}/bin/:PATH`", "reference": "This should be ` /$(ghc_find #{config[:ghc]})/ ` instead of ` /#{ghc_version}/ `, I think." }, { "prediction": "I think this should be `dots-horiz` instead of `dots-vert`.", "reference": "We should deprecate this at some point." }, { "prediction": "I think this should be `1.5` instead of `1.5`.", "reference": "Move these two arguments before `loss_cls`." }, { "prediction": "I think this should be `if serialNumber == 0 {`", "reference": "[Super NIT]: i := serialNumber if i == 0 { i = mathrand.Int63n(...) }" }, { "prediction": "I think this option should be `tool` instead of `format`.", "reference": "-f short form here collided with --force. :)" }, { "prediction": "Why is this removed?", "reference": "I think it is better to describe in the release note that `rerender()` was removed." }, { "prediction": "I think this should be `# pragma: no cover`", "reference": "We could also test this easily with `runpy.run_module`, what do you think?" }, { "prediction": "I think this should be `if v.Type().AssignableTo(reflect.TypeOf(val)) {`", "reference": "Is it OK to fall through if it's not assignable? I was kind of surprised when the tests passed. Maybe one of the options below ends up working? For the new tests, this panics because `**not assignable uuid.UUID to []uint8**`. `uuid.UUID` is an array, not a slice." }, { "prediction": "I think this should be `retrievalAPI` instead of `blockpAPI`", "reference": "I know this is after the fact but imo blockAPI should be blockMiningAPI." }, { "prediction": "Shouldn't this be `ESA_`?", "reference": "it's just a pattern as it was. SystemAttributeCode should have it's own definition and validate by it" }, { "prediction": "I don't think we need this file anymore.", "reference": "Similar to the code block when we use prefix, maybe we can unify them to base?" }, { "prediction": "I think this should be `ValidatePodchaosSchedulerError` instead of `ValidatePodchaosSchedulerError`.", "reference": "I think `Duration` is useful for this action and we shouldn't ignore it." }, { "prediction": "Why is this removed?", "reference": "Everything below here can be replaced with `return s.err, len(p) - len(s.dataForWriting)`." }, { "prediction": "I think this should be `DESUL_ENSURE_HIP_LOCK_ARRAYS_ON_DEVICE();`", "reference": "Again, we can also guard `g_host_hip_lock_arrays.atomic`, can't we?" }, { "prediction": "Why is this change needed?", "reference": "Variable name should start from lowercase latter" }, { "prediction": "I think this should be `20` and `40`?", "reference": "Why has this timeout doubled?" }, { "prediction": "Why is this change needed?", "reference": "Should IptablesPostWriteCheckIntervalSecs be set back to its previous smaller value, if use of the iptables lock is disabled?" }, { "prediction": "I think this should be `self._tab.key_press(Qt.Key_Enter, modifier=Qt.ControlModifier)` instead of `self._tab.key_press(Qt.Key_Enter, modifier=Qt.ControlModifier)`", "reference": "You're missing a `return` here, but I'll add it :smile:" }, { "prediction": "I think this should be `get_gles2_texture_in_context` instead of `get_gles2_texture_in_context`.", "reference": "Can you try adding back this assertion? I'd like to assert that the texture has been created in the same context as the renderer." }, { "prediction": "I think this should be `decode('utf-8')` instead of `decode('utf-8')`.", "reference": "This won't work with Python 3 because it will already be a string. In that case we need to use `decode_header` from utils." }, { "prediction": "I think this should be `self.respond_to?(:_clear_types)` instead of `self.respond_to?(:_clear_types)`", "reference": "Why is the respond_to check here?" }, { "prediction": "Why is this change needed?", "reference": "@orklah are you sure it's the same as `$chars[$i]`? It looks like `$i` is changed above, after `$char` assignment." }, { "prediction": "Why is this change needed?", "reference": "I have a question? How do I construct a indexManager for testcase?" }, { "prediction": "I don't think we need to check for NULL here.", "reference": "These checks aren't needed. See pluginmgr.c : opae_plugin_mgr_load_dflt_plugins( )." }, { "prediction": "I think this method should be `getRawUserQuery` instead of `getRawUserQuery`", "reference": "Please take a care about prefixing." }, { "prediction": "I think this should be `defaultEvmAccount`", "reference": "this line doesn't match what the rest says" }, { "prediction": "I think this should be `!linux` or `!windows`", "reference": "Since it's not working for linux, maybe leave the !linux in there as well?" }, { "prediction": "I think this should be `if v == \"\" {`", "reference": "Should we remove the key-value pair entirely? Same for workflows in general. We have a \"sourceExists\" method that checks if a key is there if I remember correctly." }, { "prediction": "I don't think we need to use `getModificationDateFieldName` here.", "reference": "Unrelated bug fix" }, { "prediction": "I think this should be `completed` instead of `cancelled`.", "reference": "We probably want to let the translation library handle the string replacement for these as well." }, { "prediction": "Why is this removed?", "reference": "should combine these 2 list (list_gossip and list_db) into just one list command, and show the discrepancy between the 2 if any." }, { "prediction": "I think this should be `@proposal.currently_awaiting_approvers.include? @user`", "reference": "What do you think about prefixing the Policy method names with `can_`?" }, { "prediction": "I think this should be `#define AWS_CREDENTIAL_RESPONSE_ACCESS_KEY` and `#define AWS_CREDENTIAL_RESPONSE_SECRET_KEY`", "reference": "Based on the docs, credential process can return a key `SessionToken`" }, { "prediction": "I don't think we need to use `moment` here.", "reference": "I think this if should be removed (see issue)" }, { "prediction": "I don't think we need this import.", "reference": "I would avoid importing `felix/ipsets` package because this package is the windows equivalent and should be at the same level of `felix/ipsets`. We could add linux specific dependencies into `felix/ipsets` later and it will break Windows build." }, { "prediction": "I think this should be `from typing import List, Tuple`", "reference": "nitpick: Please move this down to the other imports, as it's a Python stdlib import." }, { "prediction": "I think this should be `https://gocloud.dev/howto/blob/ for getting started guides`.", "reference": "\"for getting started guides\" reads a bit weird, like it's missing punctuation. Maybe just \"for a tutorial\"?" }, { "prediction": "Why not use `$urc` and `$uc`?", "reference": "This looks like a dead parameter -- maybe a copy and paste error. If it's truly unused, maybe you can open a separate PR to simply delete it, and then it's one less detail to worry about here." }, { "prediction": "I think this should be `uint` instead of `int`?", "reference": "Nit: Should we add support for `int` and `uint` in the `values.New()` function? That would allow us to to handle all of these types in one case. Maybe there's a good reason why we don't do that already, but I'm not sure what it is." }, { "prediction": "Why is this change necessary?", "reference": "if you are not dealing with cache now, please revert these changes. On their own they make little sense" }, { "prediction": "Why is this change needed?", "reference": "Wearing my extra-douche-bag hat I would say not spaces on a blank line. Maybe at some point we could have some automated process remove these things. For now I would not bother changing it." }, { "prediction": "I don't think we need this class anymore.", "reference": "I think it would be better to use an `ItemUpdatedEvent` like for the \"prefer streaming\" preference. We already have a ton of events that need to be handled in all list fragments that just do the same everywhere. I think we could even remove some of the existing events in the future." }, { "prediction": "I think this should be `SELECT id FROM products WHERE slug='#{product[\"name\"].parameterize}'`", "reference": "I think we have to manually write a down for this migration." }, { "prediction": "Why is this change needed?", "reference": "I don't think we still need this check, but I'd leave it as an assertion for now." }, { "prediction": "Do we need this? I think it's better to have `updated_at` and `updated_at_time` as well?", "reference": "Since this may be the case, wondering if we should call the param `updated_at_i` or something so that we don't run into a problem distinguishing them down the road?" }, { "prediction": "I think this should be `appExe = Path.Join(workingDir, appExe);` instead of `appExe = Path.Join(workingDir, appExe);`", "reference": "wondering why we need to join the paths here; seems evt.commandLine only takes whatever appExe is" }, { "prediction": "I don't think we should use `StringUtils.deleteWhitespace(serviceName, \"UTF-8\");` here. I think it would be better to use `StringUtils.deleteWhitespace(serviceName, \"UTF-8\");` instead of `StringUtils.deleteWhitespace(serviceName, \"UTF-8\");`", "reference": "1.not format code 2.failed but still continue? 3.\"UTF-8\" can changed to java.nio.charset.StandardCharsets.UTF_8.name()" }, { "prediction": "I think this should be `brain_dataclasses` instead of `brain_dataclasses`", "reference": "I'm wondering if we should add this to a `utils` module in `astroid`. Porting the util to `pylint` doesn't make sense as we would need to duplicate the globals that are being used in the function, but importing from `brain` also feels weird. @Pierre-Sassoulas Do you have an opinion?" }, { "prediction": "I think this should be `await ProduceEnd();` instead of `await ProduceEnd();`", "reference": "This seems different than what we do for corrupted request headers. I would like to determine the correct behavior and consolidate this logic." }, { "prediction": "I think this should be `backend.get('resourceGroup')` instead of `backend.get('resourceGroup')`.", "reference": "Please make the change in the CAI inventory, rather than changing the scanner." }, { "prediction": "Why is this change needed?", "reference": "adding this `abstract` is a breaking API change. Even though I agree it makes perfect sense to have it, we can't break this API until PMD 7.0.0. We should revert this particular change. We could make a reminder ticket like we did with #463 for 6.0.0" }, { "prediction": "I think this should be `PurchaseablePlan` instead of `PurchaseablePlan`", "reference": "This is following the existing convention, but I'm not sure the convention is a good one. I think it would be better to have one shared example group: - It means we don't need to add new example groups twice every time. - If the shared example group looks large, that makes it more obvious that our team models have too much shared behavior. I don't want to do anything about this right now (I'm pretty sure I can wipe out this shared example group when I change team plans), but it's good to keep in mind." }, { "prediction": "I think this should be `if (node.flags.disable_max_peers_per_subnetwork || nano::transport::is_ipv4_or_v4_mapped_address(new_connection->remote.address()) && nano::transport::is_ipv4_or_v4_mapped_address(new_connection->remote.address()))`", "reference": "I do not think we need to do a source code change to handle this. We could set the subnetwork to default to /32 (/128 for ipv6 ipv4-mapped)" }, { "prediction": "(style) line over 80 characters", "reference": "It looks good overall! The only issue I have is that the description string is now duplicated twice right? Once in the struct and once in the parameter string? Maybe let's pass the struct to the command so that `ostree_option_context_parse` can set it as the summary? Similar to what we do in rpm-ostree." }, { "prediction": "Why is this class public?", "reference": "This states very clearly that this is a derivative of Chrome and not Chromium. Do we need to extract an abstract `ChromiumCommandExecutor` and have both Edge and Chrome derive from that?" }, { "prediction": "I think this should be `type0.getType().equals(type1.getType()) && type0.getType().isEnum() && type0.getType().equals(java.lang.Enum.class)`", "reference": "it seems to me, the issue lies on `isEnum()` itself, returning false for something that is an enum. I'd rather change it there than here." }, { "prediction": "Why not just use `cls.handlers[name] = function`?", "reference": "Please use `{}` instead of `dict()`" }, { "prediction": "I think this should be `useEffect`", "reference": "I have concerns about using this in more places before #3278 - I'll take a look at that again shortly." }, { "prediction": "Why is this change needed?", "reference": "new field needs to be asserted" }, { "prediction": "I think this should be `self->lastLogIdSent_` instead of `self->logIdToSend_`.", "reference": "when send log failed, why update the last sent log id?" }, { "prediction": "Why is this change needed?", "reference": "what was the problem with the previous order? `prepend` comes conceptually before `append`, i.e. `insert before` should be before `insert after`, I think" }, { "prediction": "I think this should be `metadata map[string]string` and not `metadata map[string]string`", "reference": "Why is this necessary? Could you provide some context?" }, { "prediction": "I think this should be `\\n`", "reference": "Is there a recommended quote style for attributes? I see single and double here, double further down." }, { "prediction": "Is there a reason we don't need to wait until the run loop is closed?", "reference": "Please use an atomic bool." }, { "prediction": "I think this should be `public static void DecorateWebSpan(Span span, string resourceName, string method, string host, string httpUrl, string method, string resourceName, string method, string host, string httpUrl)`", "reference": "Consider naming this class `SpanExtensions` to follow C# conventions." }, { "prediction": "Why is this removed?", "reference": "FYI @lucaspimentel and @colin-higgins since you have already approved, I wanted to point out this required change. By fixing `FrameworkDescription` to use the correct logger, it created a cycle between these two static constructors, so I'm removing this log line and delaying it to when it's actually constructed later in the Tracer. Let me know if you find that acceptable or have any suggestions." }, { "prediction": "I think this should be `Beaker::AwsSdk` instead of `Beaker::AwsSdk`", "reference": "Ah, so we are going to need to update node/host files for this to work?" }, { "prediction": "I think this should be `info` or `finest`.", "reference": "This code is new and not tested well. While we may drop the log level before we ship 4.0, right now this is extremely helpful to users." }, { "prediction": "Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.", "reference": "used named path (`proposals_path`) instead?" }, { "prediction": "I think this should be `item_view.is_suppressed = false` instead of `bib_record_item_record_link.bib_record_id`.", "reference": "Am I misreading something, or is there a mismatched parenthesis here? Please let me know whether or not this is cause for concern -- just wanted to be totally sure before merging, since I can't test this from here. Thanks!" }, { "prediction": "I don't think we need to check the service name against the response.", "reference": "Might we want a hook to allow emitting metrics or logs in the case of a permitted empty service header response (or similar UpdateSpanWithErr on empty service header in response if strict enforcement is desired by the caller)?" }, { "prediction": "I don't think we need to set protocol to \"https\" if it's not set.", "reference": "if using dict.get, this could just be `kwargs.get('protocol', 'https')`" }, { "prediction": "I don't think we need this method.", "reference": "Add docs to the new methods here" }, { "prediction": "Why is this needed?", "reference": "what does it mean enabled?" }, { "prediction": "Why not use `query` instead of `query`?", "reference": "Getting an error when calling with db.execSQL (in sqlcipher 4.3.0, pragma returns ok)." }, { "prediction": "Why is this change needed?", "reference": "Maybe we could remove `\" \" + ctx.Tr(\"dashboard\")` completely?" }, { "prediction": "Line is too long. [89/80]", "reference": "Simple Storage **Service**" }, { "prediction": "I think this should be `h.handler.Call([]reflect.Value{reflect.ValueOf(ctx), reflect.ValueOf(reqBody))`", "reference": "Let's add some assertions here to ensure we don't panic. Length of results. Conditionally cast second result to error." }, { "prediction": "I think this should be `TimeSpan.FromSeconds(30)` instead of `TimeSpan.FromSeconds(30)`", "reference": "Where did we take this default from?" }, { "prediction": "I think this should be `Optional. Start date to compare report data for as YYYY-mm-dd`.", "reference": "Let's move these down to be after all required arguments rather than in between." }, { "prediction": "I think this should be `if (_sharedStringMap != null && _sharedStringMap != null)`", "reference": "Should we just null the Map and let the GC handle the memory? Clearing just removes items, but not capacity, so this would leave some memory on the table." }, { "prediction": "why is this change needed?", "reference": "did you mean to delete this line?" }, { "prediction": "I think this should be \"getDataverseException Compound\" or \"getDataverseException Regular\".", "reference": "Should we use logger instead?" }, { "prediction": "I think this test should be `expect(analytics?).to be_true`", "reference": "I think it would be preferred to do `expect(helper).to be_analytics`" }, { "prediction": "I don't think `pd.Index` is necessary here.", "reference": "Actually, I think it's okay to just change to `if isinstance(key, (str)) or is_list_like(key):` and `key = list(key) if is_list_like(key) else key` for simplicity for now." }, { "prediction": "Why is this change needed?", "reference": "If there any other tests, I would make it optional there also." }, { "prediction": "I think this should be `my_accounts` instead of `watch`", "reference": "This can be removed too, right?" }, { "prediction": "Why is this change needed?", "reference": "If you're going to allow people to specify multiple SMTP servers, you should also properly export/import them." }, { "prediction": "I think this should be \"runtime.dotnet.aspnetcore.requests.current\" and \"runtime.dotnet.aspnetcore.connections.total\"", "reference": "nit: Can we prefix these variables with `AspNetCore`?" }, { "prediction": "I don't think we need the `modulepath` argument here, but I think it would be better to use `plan_path` instead of `plan_name`.", "reference": "Can this also include a quick test for transpiling by name?" }, { "prediction": "I think this should be `SessionStatsDeprecated` instead of `SessionStats`", "reference": "This TODO can be removed" }, { "prediction": "Why is this change needed?", "reference": "can we make tabAccessibilityIdentifier = null as default?" }, { "prediction": "Why do we need this?", "reference": "Should we print this error?" }, { "prediction": "I think this should be `num_classes = int(multi_scores.size(1) - 1)`", "reference": "For which reason do we need to convert this to int here?" }, { "prediction": "I think this should be `err = errors.Wrap(err, \"freezer not supported\")`", "reference": "FWIW, wondering if the error is interesting here (I actually arrived at this code initially to change `supportsFreezer()` to return a `bool`" }, { "prediction": "I think this should be `is_test`", "reference": "Does this still need to be a partial? is the intention down the line to move back towards a conditionally different title?" }, { "prediction": "I think this should be `publicLoadBalancer: true`", "reference": "seems like `RegistryURL` is missing? Same for a few other places that create `archer.Environment` below." }, { "prediction": "I don't think we need this import.", "reference": "Are these imports needed?" }, { "prediction": "I don't think we need this test anymore, but I think it should be `if (target.actualNode.type === 'text') { return; }`", "reference": "I think you can remove the `(isIE11 ? it.skip : it)(` above, if you're going to skip the test this way." }, { "prediction": "I think this should be `Long.reverseBytes(checksum)` instead of `Long.reverseBytes(checksum)`", "reference": "IMO we should instead fix the above call to do `long actualChecksumIn = Long.reverseBytes(in.readLong());` to get the actual checksum value? This way the below error message would also be correct?" }, { "prediction": "I think this should be `if len(obsoleteIndexes) != 0 {`", "reference": "I think we also need something similar for `rebuild-index`?" }, { "prediction": "I think this should be `defaultBundleEndpointPort = 443`", "reference": "I think convention is snake case for import naming?" }, { "prediction": "I don't think we need to add the handle column to the index scan.", "reference": "i think haspk is false?" }, { "prediction": "I think this should be `surefire_reports` instead of `surefire_reports`.", "reference": "you should add this to the cover command too (but let's have a more general convo about whether it's a flag or config option)" }, { "prediction": "Why is this change needed?", "reference": "instead of passing in pointer to empty struct, we should make it optional and support passing nil and use default cfg if it is nil." }, { "prediction": "I think this should be `repr(sorted(obj.to_dict().items()))`", "reference": "A fair bit faster, although still not great, hence also adding a hashkey." }, { "prediction": "I think this should be `trail.steps_remaining_for(current_user)`", "reference": "If we're going to leave this in here, how about we at least pull it into partial?" }, { "prediction": "I think this should be `20` and not `40`?", "reference": "This `context` is used correctly, there is nothing left TO DO." }, { "prediction": "Why is this change needed?", "reference": "If `docs` is an empty array there will be an error" }, { "prediction": "I think this should be `!strings.HasPrefix(host, \"quic:\") && !strings.HasPrefix(host, \"unix:\") && !strings.HasPrefix(host, \"quic:\")`", "reference": "Is it really necessary to have the user specify this, or can the reverse proxy infer QUIC from the upstream's Alt-Svc headers?" }, { "prediction": "Why is this change needed?", "reference": "just remove the entire variable." }, { "prediction": "I don't think we need to do this in a separate PR, but I think it's better to use `File.expand_path` instead of `File.expand_path`.", "reference": "Maybe we should put that in the option description?" }, { "prediction": "I think this should be `Optional.of(keyFilePath)`", "reference": "Why do we need to make this optional? Isn't the idea of the builder that if you don't need this value you just don't call the `keyFilePath ` method?" }, { "prediction": "Why is this change needed?", "reference": "Shall we do the same for ORC and Avro?" }, { "prediction": "This file should be moved to the top of the file.", "reference": "Should be a space between line" }, { "prediction": "I think this should be `public static byte[] GenerateRandomBytes(int lenght) { return SecureRandom.GetBytes(lenght); }`", "reference": "if not behind interface then equally we can use SecureRandom.GetBytes directly, otherwise let us push it behind ISecureRandom so we can test with this class wherever used" }, { "prediction": "I think this should be `video_tutorial_tile`", "reference": "Probably will undo this change for now, as I'm just targeting Weekly Iteration in this PR." }, { "prediction": "I think this should be `std::unordered_map`.", "reference": "Unused parameter warning? How comes we did not catch that before? In any case please open another PR for this." }, { "prediction": "I don't think we need to change the default value of `gt_bboxes_group_of` to `default_iou_thr`.", "reference": "I recommend move all openimage related logic to a new function" }, { "prediction": "I think this should be a `bool` instead of a `bool`.", "reference": "We shouldn't have a bool for this. If there is a path passed, then we use it. Resource may or may not be empty." }, { "prediction": "I think this should be `section_teacher.teacher.name`", "reference": "I like how you used the count on the translate call to handle this." }, { "prediction": "I think this should be `if ($handler->hasDismax()) {`", "reference": "Do we need to do this from the outside, or is there a spot in the handler code where we can do this automatically? (I haven't studied it closely yet... just wondering if you've already thought it through or if it's worth taking a closer look)." }, { "prediction": "I think this should be `public static void sputnikTest() { ... }`", "reference": "[Checkstyle] INFO: Using the '._' form of import should be avoided - java.util._." }, { "prediction": "I think this should be `cliquet_support.DEFAULT_SETTINGS['cliquet.cache_backend'] = 'cliquet.cache.memory'`", "reference": "So, why everything is in memory but the permission backend?" }, { "prediction": "I think this should be `copiedAllowedExtensions = allowedExtensions != null ? allowedExtensions : null;`", "reference": "Are you sure it should be null and not an empty List?" }, { "prediction": "I think this should be `[Required]` instead of `[Required]`.", "reference": "Unfortunately I think the assumption of \"empty\" means the default dependency section is not correct. For a project.json file the default dependencies section is a shared section between all the different target frameworks and our TargetGroup being empty may map to many different target frameworks so they aren't really equated." }, { "prediction": "I think this should be `not-localhost` instead of `not-value`.", "reference": "This test was verifying the wrong thing." }, { "prediction": "Why is this needed?", "reference": "pls pr a name change fro muon here too separately." }, { "prediction": "I think this should be `err := opts.envStore.CreateEnvironment(&env); err != nil`", "reference": "nit: we can use `defer opts.spinner.Stop(\"Error!\")` after l.180 to make it slightly neater" }, { "prediction": "(style) line over 80 characters", "reference": "This is declared in the wrong block" }, { "prediction": "I think this should be `klog.Warningf(\"Get a sync-msg when use beehive.Send(),msg.Header:{%v},msg.Route:{%v}\", message.Header, message.Router)`.", "reference": "In fact it would be useful for debug, i prefer combine them into one debug level log." }, { "prediction": "I think this should be `None fatal crash per session`", "reference": "We would need to localize them eventually too, just FYI" }, { "prediction": "Why is this change needed?", "reference": "It looks like the proto code needs to change the function name from set_name to set_type to be consistent." }, { "prediction": "This file should be moved to the `generate` package.", "reference": "I think we can avoid using this pattern for this use case." }, { "prediction": "I think this should be `#ifdef __ANDROID__` instead of `#ifndef __ANDROID__`", "reference": "Could you please change this to `#ifndef __linux__`? That's when we use our own implementation instead of `posix_spawnp`." }, { "prediction": "I think this should be `slots.stream().anyMatch(slot -> slot.getSession() != null).anyMatch(slot -> slot.getSession() != null).count() < maxSessionCount`", "reference": "Nit: put the `&&` on the previous line so that a reader knows that there's more to the statement at a casual glance." }, { "prediction": "I think this should be `tlfTypeToPath`", "reference": "Technically the \"right\" variables to use would be the ones in `libgit/autogit_node_wrappers.go\", which define how the tlf types map to subdirs for autogit specifically. (They would have to be exported.) But this is fine too I guess, just a little dirtier." }, { "prediction": "Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "Should there be a template or something associated with this email? Right now it's identical to `notification_for_approver`" }, { "prediction": "Why is this needed?", "reference": "i hope there is some extension in phpstan for this" }, { "prediction": "I think this should be `return 0;`", "reference": "We don't store empty dictionary entries anymore: they bring no benefits, only trouble." }, { "prediction": "I think this should be `const` instead of `const`.", "reference": "Optional: This function is C++ specific and could be declared as `static`." }, { "prediction": "I think this method should be called `getRoles(String domainName, boolean members, String tagKey, String tagValue)`", "reference": "we can't remove functions as that would introduce backward compatibility issues in our java client. So we should also have a function with the original arguments: ` public Roles getRoles(String domainName, Boolean members) { return getRoles(domainName, members, null, null); } ` For the Go client we don't have a wrapper so no option but to update your client code as necessary, but for java we have the wrapper thus we always maintain backward compatibility" }, { "prediction": "I think this should be `RSpec::Configuration.deprecation_io.puts(message)` instead of `RSpec::Configuration.deprecation_io.puts(message)`", "reference": "I'd recommend keeping this in `warn_deprecation` and not adding an override of `warn`." }, { "prediction": "I think this should be `blitz build` instead of `blitz build`", "reference": "I think we should use a `blitz` bin instead" }, { "prediction": "I think this should be `dataset.dimensions('key', label='name')` instead of `dataset.dimensions('key', label='name')`", "reference": "Why not make the ``derived_vdims`` flag (or similar, ``validate_vdims`` maybe?) an explicit argument to ``validate``?" }, { "prediction": "I think this should be `err := s.driver(ctx).Create(locator, source, spec)`", "reference": "was it not possible to do this at the filter or porx driver layer? We typically try to avoid driver-specific things in the SDK layer" }, { "prediction": "This file is not used.", "reference": "please update the year. it can be setup in intellij template." }, { "prediction": "I think this should be `log.trace(message, arg1, null);` or `log.trace(message, arg1, null);`", "reference": "what's the use-case for this?" }, { "prediction": "`as_index` should be `bool`", "reference": "nit: `as_index must be an boolean` -> `as_index must be a boolean`" }, { "prediction": "I think this should be `update` instead of `update`", "reference": "What is the goal of that method ? And what are `$currentVersion` and `$newVersion` ? Are they Thelia or Module version ? :)" }, { "prediction": "I think this should be `require('../package.json').version`", "reference": "Is there an advantage to this vs setting `this.version` in the constructor? Cleaner this way, at the top?" }, { "prediction": "I think this should be `String.valueOf(String.valueOf(String.valueOf(String.valueOf(String.valueOf(String.valueOf(String.valueOf(String.valueOf(String.valueOf(String.valueOf(String.valueOf(String.value)))));`", "reference": "Fix for URISyntaxException." }, { "prediction": "I think this should be `if routeUpd.Dst == nil {`", "reference": "Would be good to UT this case" }, { "prediction": "I think this should be `off` instead of `off`.", "reference": "Why we need to add this?" }, { "prediction": "Line is too long. [82/80]", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I think this should be `current_api_calls`", "reference": "This is ok to change since I believe that these were added just in main and not in public release." }, { "prediction": "I think this should be `pubsubServiceAccount` instead of `pubsubServiceAccount`", "reference": "Not needed in this PR, just want to make sure people think about this (maybe make an issue)? This is a lot of strings in a row. It will be hard/impossible for someone reading the code to see that everything is in the correct position. I recommend creating a struct instead of passing seven strings in a row. A similar problem exists on most of the `MakeFoo(...)` style methods in this change." }, { "prediction": "I think this should be `if (_run.ConfigurationNotifications != null && _run.ToolNotifications != null) {` or `if (_run.ToolNotifications != null && _run.ConfigurationNotifications != null && _run.ToolNotifications != null) {`", "reference": "_jaw drops_ I would have sworn I wrote those lines. Good catch." }, { "prediction": "Why do we need to clear the memoizedFns?", "reference": "This needs to be tested." }, { "prediction": "I don't think we need this test anymore.", "reference": "I believe you're missing the comparison after 'be'" }, { "prediction": "I think this should be `ErrAlreadyDeleted`.", "reference": "move 103~105 to in front of 97?" }, { "prediction": "I don't think we need to use `FileOutputStream` here.", "reference": "Lots of unnecessary imports left in this file." }, { "prediction": "Why is this change needed?", "reference": "Does this actually produce different code?" }, { "prediction": "I think this should be `.indexOf('this.blur()') > -1`", "reference": "This should account for whitespace. Simply putting `.trim()` on the attribute value should do." }, { "prediction": "I think this should be `noenc` or `bh`", "reference": "I don't think we need these. Simpler just to put `routetable.TargetType...` inline below." }, { "prediction": "I think this should be `if method == 'PUT'`", "reference": "Nested if statement. You can merge both statements nested together to create one" }, { "prediction": "I think this should be `java.version.startsWith(\"10.\")`", "reference": "Nitpick: add a space after the comma. Also, we should consider that the format of the version could change in the future so we could get something that is not a parsable integer." }, { "prediction": "Why is this change needed?", "reference": "For your reference in future, I sugguest to use the `ASSERT_*` family." }, { "prediction": "I think this should be `fmt/format.h`", "reference": "no need to import `fmt/format.h` here since the `KimInit` class is derived from `Pointers`. Any class derived from `Pointers` can assumed that `lmptype.h`, `mpi.h`, `cstddef`, `cstdio`, `string`, `utils.h` and `fmt/format.h` are already included through `pointers.h`." }, { "prediction": "I think this should be `pkg/types`", "reference": "Can we have prefix of `OPENEBS_IO` e.g.: `OPENEBS_IO_INSTANCE_NAME`" }, { "prediction": "I think this should be `folderBranchOps`", "reference": "Might as well fix these bare returns by making them `return errors.New(...` directly." }, { "prediction": "I think this should be `org.hyperledger.besu.datatypes.Hash.EMPTY` instead of `org.hyperledger.besu.datatypes.Hash.EMPTY`", "reference": "we can use import here" }, { "prediction": "Why is this removed?", "reference": "thx for removing these" }, { "prediction": "Shouldn't this be `RuntimeException` instead of `RuntimeException`?", "reference": "I snuck this one in as well as checkstyle crashing (on files from resources) caused an unfinished xml to be written, and it wasn't obvious where that XML was" }, { "prediction": "I think this should be `good case2` instead of `good case`", "reference": "How is this different than \"good case\"?" }, { "prediction": "Why is this change needed?", "reference": "the last parameter name should be `serviceName` as is in the implementation " }, { "prediction": "Why is this change removed?", "reference": "@ftomassetti - okay, this is a little meh." }, { "prediction": "I think this should be `os: not implemented` instead of `os: not implemented`", "reference": "Note, changed initial capitalisation of this for consistency. Can do it the other way around too if that'd be better. :wink:" }, { "prediction": "I think this should be `typeof window === 'object' ? window : this.document`", "reference": "hey, aren't we supposed to be passing in two parameters here?" }, { "prediction": "I think this should be `bitcore.Unit = require('./lib/unit');`", "reference": "please keep alphabetical ordering :)" }, { "prediction": "I don't think we need to use `java.nio.charset.StandardCharsets` here.", "reference": "Selenium must compile against Java 6. Revert this line." }, { "prediction": "Why is this change needed?", "reference": "what is that `\"\"`, the adapterType? can you add `\"\" /* adapterType */`... in other places as well... might be cleaner if it's a pointer or some varargs at the end but don't have any strong preference.." }, { "prediction": "I think this should be `typeof _this.getValue(path) === 'boolean'`", "reference": "This check is a little odd, and will still mess up with empty strings `''` because empty string is falsy. Can we change this to `|| _this.getValue(path) == null`?" }, { "prediction": "I don't think we need to check `isFocusable` here.", "reference": "Just a minor suggestion: If you `parseInt` when you access the attribute then you shouldn't have to do it twice in the ternary." }, { "prediction": "I think this should be `body[:target]['host-key-check'] = false` instead of `body[:target]['host-key-check'] = transport == 'ssh'`", "reference": "This change in particular is strange. I'm not sure why it would now be necessary. The previous default would've been true, and the default behavior without a new net-ssh version should be unchanged." }, { "prediction": "I think this should be `?bool`", "reference": "Why is that? Should be redundant as the default value exists." }, { "prediction": "I think this should be `bool` instead of `bool`.", "reference": "Are all fields beginning with \"Debug\" automatically `;local` ? (I guess so, but just checking.)" }, { "prediction": "I think this should be `@return` instead of `@return`.", "reference": "While I think it makes sense to update the mapping programmatically, I don't see much value in exposing it as part of the table API. We want to keep the Table API small, so if we can handle this by using a separate API that consumes and produces JSON, then that is preferred. Also, we may have more than one mapping in the future, so keeping this decoupled also helps out for those use cases. For now, let's build a utility class to perform these updates. We can always add this to the public API later if we choose to." }, { "prediction": "Why is this change needed?", "reference": "We would want ssmp to wake up every 3 seconds if there are no other requests to it and do some cleanup tasks. So, it is not clear why do you want to set this to 0." }, { "prediction": "I think this should be `getLLVMRuntimeType(runtimePkg.Type(\"_interface\").Type())`", "reference": "Is this really necessary? I would expect these types to be included with the loop below." }, { "prediction": "I think we should use `BitConverter.IsLittleEndian` instead of `Array.Reverse` here.", "reference": "You could do span and it's magic of typecast to int for better efficiency" }, { "prediction": "I don't think we need vendor prefixes here.", "reference": "Looks like you've covered `-webkit-transform`, but what about `-ms-transform`?" }, { "prediction": "I think this should be `if (Looper.MainLooper != Looper.MyLooper()) {`", "reference": "Is there something missing from the message here?" }, { "prediction": "I don't think we need to add these to the list of tool classes.", "reference": "Hmm, what does this syntax mean?" }, { "prediction": "Why is this needed?", "reference": "should this be callerTypeTask?" }, { "prediction": "I think this should be `@plan.administerable_by?(@user.id)` instead of `@plan.administerable_by?(@user.id)`", "reference": "Currently update is set as @plan.editable_by?(@user.id) Which one is the correct behavior? I can see a case for only owners/co-owners to be able to set visibility, test status, and other plan details" }, { "prediction": "I think this should be `10_000_000`.", "reference": "Maybe make it configurable? Or store the actual level index in DB, making this binary search obsolete?" }, { "prediction": "Why is this change needed?", "reference": "Nit: this file doesn't need to change. Can you revert this to avoid git conflicts?" }, { "prediction": "Why is this needed?", "reference": "There's no reason for this to be a callback now technically but as per our tech decision, we want all handlers to use `useCallback` now" }, { "prediction": "I think this should be `HashID = \"LO\"`", "reference": "This isn't strictly part of this PR, but could you move `multiSigString` from `crypto/multisig.go` into this list of `HashID` values? Now that we have other things being hashed into addresses (specifically, these new logic addresses), it's important that the hash input for multisig addrs is domain-separated from logic addresses." }, { "prediction": "Why is this needed?", "reference": "nit: you could have named it just \"TestCase\" (if django's TestCase was imported differently)" }, { "prediction": "I don't think we need this method anymore, but I think it's a good idea to add a `@bridge.print_page` method to the bridge.", "reference": "the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here." }, { "prediction": "Why is this removed?", "reference": "All the callers of `ExtractSomeIfAny`, always pass `true` to `synthetic_value`. Can we get rid of the extra argument?" }, { "prediction": "I think this should be `meta['config_dict'] = dict(cfg)`", "reference": "Better to use the absolute path." }, { "prediction": "Why is this changed?", "reference": "this is 16 hours, is that enough?" }, { "prediction": "I think this should be a `go.opencensus.io/trace` package, not a `go.opencensus.io` package.", "reference": " removing boilerplate. You could also add a `StartSpan` with varargs to inline string attributes." }, { "prediction": "I think this should be `i := uint64(0) v := uint64(0) if b.eth.syncService.GetLatestIndex() != nil { return i, v }`", "reference": "Can you replace these single letter variables with full names?" }, { "prediction": "I think this should be `public Action PrepareRequest{ get; set; }`", "reference": "At first I wasn't sure, but now I think I'm sold on making PrepareRequest an action over adding a state object to the context." }, { "prediction": "I think we should use `preg_match('/^VuFind (\\d+\\.?)+$/', $newConfig['Site']['generator'])` instead of `preg_match('/^VuFind (\\d+\\.?)+$/', $newConfig['Site']['generator'])`", "reference": "Would it be too greedy to preg_replace `VuFind (\\d+\\.?)+` with `'VuFind ' . $this->to` anywhere in the string? This would update something like 'Finna (VuFind 7.1.0)' as well. Just a thought, please disregard if you'd like to keep it as is." }, { "prediction": "I think this should be `getClusterState().getCollection(collection).getConfigName()`", "reference": "BTW for brevity, you can remove `getZkStateReader().` here and elsewhere since ZkController has a convenience method for the cluster state." }, { "prediction": "I think this should be `CloseableIterable manifests = (snapshot != null) ? snapshot.manifests() : CloseableIterable.empty();`", "reference": "If there are no manifests, then entries should be `CloseableIterable.empty()`, not the manifest iterable. That doesn't need to be closeable." }, { "prediction": "I think this should be in `pmd.testframework.PmdRuleTst`", "reference": "this class should be named `ArrayInitializationVerbosenessTest` to work" }, { "prediction": "I think this should be `next if val.is_a?(Hash)` instead of `next if val.is_a?(Hash)`", "reference": "Do we want to allow users to disable `console` as well? The schema currently says that it only permits a hash for `console`." }, { "prediction": "I think this should be `TestWalletBalance` instead of `TestWalletBalance`", "reference": "It would be very helpful to describe succinctly either inline or by linking to an issue going into depth why each test is not working. If we merge like this your knowledge of what is going on is lost and other people in the code need to do a ton of reading before understanding when/how/if we should unskip." }, { "prediction": "I think this should be `handleDataError` and `handleDataSuccess`.", "reference": "As this is a `useEffect` this could be a cause for concern! Note that `useEffect` re-runs when a dependency changes **not** when a dependency is truthy (the previous code does look a bit like it's expecting that)" }, { "prediction": "I think this should be `world_comm_ptr{new lbann_comm(0, &lbann::finalize)}`.", "reference": "Should we be doing this with `make_unique` or something?" }, { "prediction": "Line is too long. [89/80]", "reference": "we don't want to set default values for this. Since it is the actual email, we want to make sure we are always passing in the `user` and `proposal` . we have a default value of `nil` for modifier because sometimes will update a proposal via `rails console` in which case there will be no recorded modifier." }, { "prediction": "I think this should be `go/parser.go`", "reference": "Yes this import was in the wrong place, but should ideally be in the first list of imports (among `go/build`, `go/token`, etc.). You may move it there, or just revert this change as it's actually unrelated." }, { "prediction": "Why is this removed?", "reference": "It's unnecessary to duplicate the `name`." }, { "prediction": "I think this should be `true === $event->getForm()->get('unlink')->getData()`", "reference": "this was a mistake when adding phpstan strict plugin" }, { "prediction": "I think this should be `if (oldVNode._dom == oldDom && oldVNode._parentNode != parentDom)`", "reference": "Nit: I think it should be `to handle` here." }, { "prediction": "Why is this change needed?", "reference": "Please don't make unrelated changes or let your tools make unrelated changes." }, { "prediction": "Why is this change needed?", "reference": "`numAccounts` is a global variable (from `gochecknoglobals`)" }, { "prediction": "I think this should be `unset($this->plugins[$id])` instead of `unset($this->instance()->getPluginPath($id));`", "reference": "Is the ID correctly normalized at this point?" }, { "prediction": "I don't think we need this package anymore.", "reference": "if 0 is a special constant meaning \"no limit\" let's make it a constant and name it correctly :)" }, { "prediction": "Why is this change needed?", "reference": "Curious about the reason behind this change" }, { "prediction": "why is this change needed?", "reference": "wait, i thought the cborstore was for state tree?" }, { "prediction": "I think this should be `self.set(lk, pkg[lk])` instead of `self.set(lk, pkg[lk])`", "reference": "This logic is now duplicated here and in `_delete_temporary_files`... Maybe do it all at once - find temp files, delete them, and fix the logical keys?" }, { "prediction": "Why is this needed?", "reference": "How about name it with NullResponseTypeProcessor" }, { "prediction": "I think this should be `config_.monotone_constraints.size() == 0` instead of `config_.monotone_constraints.size() == 0`", "reference": "Maybe `Log::Fatal` here? `[LightGBM] [Fatal] Check failed: feat_is_unconstrained at ...` (and kernel death in case of Jupyter Notebook) seems to be not so informative and user-friendly." }, { "prediction": "why do we need this?", "reference": "Not sure I like the name ``_apply``. Even though ``_process`` is supposed to process elements already, how about ``_process_element`` which processes elements, *excluding* Overlays/NdOverlays." }, { "prediction": "I think this should be `NodeRoleTagKey`.", "reference": "Let's use this constant when ASG is created as well (currently hardcoded)." }, { "prediction": "I think this should be `GROUP BY` instead of `GROUP BY`.", "reference": "Oh is `bucket` actually higher cardinality than `eventname`?" }, { "prediction": "I think this should be `QWebEngineProfile`", "reference": "You can't rely on QtWebEngine being available - but why do you need to import this here at all?" }, { "prediction": "I think this should be `NVDAObjects.JAB` and `NVDAObjects.UIA`", "reference": "How did you determine these - and how can we be confident that nothing is missing?" }, { "prediction": "I don't think this is a good idea, but I don't think it's a good idea to add the `

Workshops

`, but I don't think it's a good idea to add the `

Videos

`, but I don't think it's a good idea to add the `

Workshops

`, but I think it would be better to add the `

Workshops

` and `

Videos

` to the `

Books

`.", "reference": "What is this page going to do that is different than the products index we already have?" }, { "prediction": "I think this should be `manifest['application']['gecko']['id']` instead of `manifest['application']['gecko']['id']`", "reference": "Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else." }, { "prediction": "I think this should be `HASH_CONFIG_KEYS` instead of `HASH_CONFIG_KEYS`", "reference": "Is this intended to be here? Seems it belongs to a different PR." }, { "prediction": "Why is this change needed?", "reference": "These changes, while harmless, were no longer needed with newer versions of System.Console thanks to @ianhays" }, { "prediction": "I think this should be `except botocore.exceptions.NoRegionError:`", "reference": "Umm... this isn't relevant to this PR" }, { "prediction": "Why is this needed?", "reference": "While All make some sense here it doesn't make a lot of sense in the SkipOnFramework context. I wonder if we really need to expose anything more here. You can just blindly use 0." }, { "prediction": "I think this is a bit confusing, but I don't think it's necessary to add this to the package.", "reference": "Actually, this is not correct. Package `cmd/bee` doe snot have any notion of commands or even libraries used for them. It is as simple as possible, just calling the function from `cmd/bee/cmd` which actually implements commands." }, { "prediction": "Why is this removed?", "reference": "This change is causing tests to fail because users sits at `/app/users`, not `/app/admin/users`" }, { "prediction": "I don't think we need this option.", "reference": "Could you provide more information on what exactly each of those three options do?" }, { "prediction": "I think this should be `public string TraceFilePath { get { return perfCollect.TraceFilePath; }`", "reference": "Why this line break?" }, { "prediction": "I don't think we need to add `k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/install` here.", "reference": "We're importing this twice with different aliases." }, { "prediction": "I don't think we need to change the version of `pandera` to `pandera<0.8.0`.", "reference": "We should avoid adding a pandera dependency to Dagster itself." }, { "prediction": "Why is this change needed?", "reference": "Can be replaced with `org.jkiss.utils.ArrayUtils#add`." }, { "prediction": "Why is this synchronized?", "reference": "While we're here, this line (and a few others) should be `customThreadPool.submit(() -> IOUtils.closeQuietly(overseer);` I have no idea why we're creating a collection and a stream for a single object." }, { "prediction": "I don't think we need to check for `managedIdentityClientID` and `managedIdentityResourceID` here.", "reference": "Should these restrictions also be reflected in the API docs?" }, { "prediction": "I think this should be `r.RequestURI = cloneURL(origReq.URL, r.URL)`", "reference": "What about the request headers if someone uses `request_header`? :thinking:" }, { "prediction": "I think this should be `for _, domain := range instance.Spec.ManagedDomains { args = append(deployment.Spec.Template.Spec.Containers[0].Args, fmt.Sprintf(\"--domain-filter=%s\", domain))`", "reference": "Verify that external-dns allows setting this parameter multiple times (that it's not \"last one wins\")." }, { "prediction": "I think this should be `host1.example.com: '10.3.1.5'` or `host1.example.com: '10.3.1.5'`", "reference": "Maybe 2 host/ip values could be used in the example?" }, { "prediction": "Why is this needed?", "reference": "We're only testing `RateLimiter.Allowed(Span)`, so I think we can use a mock `ITraceContext` instead of a real `Tracer` or `TraceContext`." }, { "prediction": "(style) line over 80 characters", "reference": "IMO, this is the wrong way to associate a model with a trainer... Why the string when you actually have a trainer object?" }, { "prediction": "Why is this change needed?", "reference": "Wondering if we can directly put types here & for other similar ledger_processor items like rai::block_type::state" }, { "prediction": "Why remove this?", "reference": "As `DeleteFiles` is not only used for prune this function deserves its own file. Maybe something like `delete_files.go` or `parallel.go`?" }, { "prediction": "I think this should be `:attribute \u5df2\u7ecf\u5b58\u5728\u3002`", "reference": "It should be simplified character. `` -> ``" }, { "prediction": "I think this should be `int ParallelLevels => -1;`", "reference": "I am pretty sure it breaks the visitor pattern, visitor should have no knowledge about the structure of what it is visiting or control over visiting mechanism" }, { "prediction": "Why is this change needed?", "reference": "'A' instead of 'An' here" }, { "prediction": "Why is this change needed?", "reference": "Can you flip it back (here and in other places)? It is more natural to represent \"10 seconds\" as `10 * time.Second`." }, { "prediction": "I think this should be `output='array'` instead of `output='array'`", "reference": "Why was this necessary? You should just use the `dask_classifier` defined below this. With this change, you'd only be doing the local predict on arrays each time, but we want to test on all of DataFrame, Array, and sparse matrix." }, { "prediction": "I think this should be `t('.added_to_github_repo') %>` instead of `t('.added_to_github_repo') %`", "reference": "To me, this is sort of weird to have a completely separate page for this. Can we extract the different stuff (github, videos, downloads) presentation from the top of `app/views/purchases/show.html.erb` and reuse it on this page. I worry that we'll change things with fulfillment or copy and have to change it in multiple places." }, { "prediction": "I don't think this is needed.", "reference": "Please revert the lines above. Not touching unrelated code keeps the git history clean." }, { "prediction": "I think this should be `2.3.0rc0` instead of `2.3.0rc0`", "reference": "`short_version` and `version_info`" }, { "prediction": "I think this should be `stats` instead of `status`.", "reference": "This is supposed to be `status`. Why did you change this?" }, { "prediction": "I think this should be `Apcera` and `Synadia Communications`", "reference": "I will change all of these at some point next week." }, { "prediction": "I think this should be `TargetAssemblies = null` instead of `TargetAssemblies = null`", "reference": "I made this change because, while trying to debug, in Visual Studio, the `IntegrationSignatureTests`, this property getter was hit and interfered with my ability to complete the debugging." }, { "prediction": "I think this should be `status = model.KubernetesResourceState_FAILED` instead of `status = model.KubernetesResourceState_UNKNOWN`", "reference": "nit: `\"Unexpected error while calculating: unable to convert %T to %T: %v\"`" }, { "prediction": "I think this should be `appName`", "reference": "I'd actually recommend not putting this in the `SampleConfig`, it's intended more for properties that are inherent of the discovery format. Add a method `getSampleAppName(String apiTypeName)` to `SampleNamer` and override it in the language specific `SampleNamer`s if needed. Then assign it in the transformer." }, { "prediction": "I think this should be `convert-array-to-keyed-object-map`", "reference": "Do we need to export these new functions? I thought the plan going forward was to keep util imports separated to make circular imports less likely and possibly do better chunk splitting. Since only new code references these files, we can scope the import to the specific files." }, { "prediction": "Align the parameters of a method call if they span more than one line.", "reference": "Rails will autorequire `acts_as_editable` once it encounters the constant `ActsAsEditable`. Thus if we move `ActiveRecord::Base.send :include, ActsAsEditable` from _acts_as_editable.rb_ to this file, the require line will not be needed anymore. Instead of requiring the file ourselves, we will let Rails do it for us. This fix will also remove the need to explicitly require `acts_as_editable` in _mock_active_record_base.rb_." }, { "prediction": "I think this should be `methodName` or `upperCamelMethodName`", "reference": "I think we should name this `grpcMethodName` or similar. That is what this refers to, right? The fact that it is upper camel is an implementation." }, { "prediction": "(style) code indent should use tabs where possible", "reference": "What if .. appears, but not as the first character, eg \"errors/../../../../../../../../../../../\"?" }, { "prediction": "I think this should be `owned by the curation center`", "reference": "Thanks, this should make things a bit easier for people who pick up the codebase but aren't a `curation center`" }, { "prediction": "Why is this deprecated?", "reference": "why not removing it?" }, { "prediction": "I don't think we need this flag anymore.", "reference": "same nit here: maybe word as - \"disables validation of the temporal cluster's server certificate\"" }, { "prediction": "I think this should be `SHOW TABLES` instead of `SHOW TABLES`", "reference": "Nit: other statements use all caps for SQL reserved words. Should this be `SHOW TABLES`?" }, { "prediction": "I think this should be `c == '.'` instead of `c == ':'`.", "reference": "Do we need this? isLuaIdentifier() is used not only in extract_next_token() but also in extract_prev_toke(). I wonder whether the change for isLuaIdentifier() has an impact on extract_prev_toke() or not. If you are not sure, keep isLuaIdentifier() as is. If you are sure, could you write your conviction to the commit log." }, { "prediction": "Why is this change needed?", "reference": "This line should actually be: `if c.KubernetesProvider == config.ProviderAKS && c.Wireguard.EncryptHostTraffic {` because we only need to tweak the MTU like this on AKS." }, { "prediction": "I think this should be \"Name of the application.\"", "reference": "Do we need to change this flag as well?" }, { "prediction": "I think this should be `var file = fileset.dest + 'module.exports.source = ' + JSON.stringify(source);`", "reference": "Including the source twice here makes the filesize jump to 432kb. Is there any way to minimize repeating it?" }, { "prediction": "I think this should be `nameOrHandle` instead of `handle`.", "reference": "This should only be sent if the driver is speaking to a W3C conformant remote, so we need an if-condition check like we have in the Python bindings." }, { "prediction": "Line is too long. [82/80]", "reference": "Only one line of code? What a simple issue!" }, { "prediction": "I think this should be `NewDefaultIncomingRateLimiter`", "reference": "Conceptual question: why do history and matching need throttler at all? Shouldn't throttling to be handled on FE only?" }, { "prediction": "I think this should be `enqueueAppliedToGroup`?", "reference": "Would this be possible: `addCNP` has already processed the CNP to an internalNP, just hasn't added this internalNP to the `internalNetworkPolicyStore`. In this case, `reprocessCNP` will skip processing this CNP and `addCNP` will just add the \"old\" internalNP to `internalNetworkPolicyStore`." }, { "prediction": "I don't think this is necessary.", "reference": "Minor: you can access `current_user` in here directly - don't need to pass it in. Unless you prefer passing it explicitly?" }, { "prediction": "I don't think we need to do this here, but I think we should do `attributes.respond_to?(:keys)` instead of `attributes.respond_to?(:to_h)`", "reference": "What is the purpose of `&` on this line?" }, { "prediction": "I don't think we need to check for `\\d+` here.", "reference": "See above, the `isValidWebDataStreamID` implementation from before is actually correct. What we need here instead is a new `isValidMeasurementID` function." }, { "prediction": "I think this should be `if err != nil {` instead of `if err != nil {`", "reference": "Should be an error... it is important for the admin of the server attempting to create the leafnode connection to see the error asap." }, { "prediction": "I think this should be `states` instead of `states`?", "reference": "Could you split these conditions up over multiple lines please." }, { "prediction": "Why is this change needed?", "reference": "I think we can just change this to `Split` instead of `SplitN`. I don't think we need to limit the number of parts in the tag." }, { "prediction": "I think this should be `{{ range $port }}`", "reference": "So this is actually a mistake that I introduced without realizing it, and have known would need to be fixed when we get here . The format of the ports directive is \"host:container\". We only want the host port to change, not the internal container ports. The ports variable probably needs to be a map which maps external -> internal ports." }, { "prediction": "Why is this change needed?", "reference": "An alternate approach would be to always initialize shardInfo with a dummy (non-nil) value, which could protect against other uses before it's initialized (I couldn't find any though). But I can change it to do it that way instead." }, { "prediction": "I think this should be `LastWriter`?", "reference": "Maybe we can just put the entire `DirEntry` in here? I can imagine it might be useful for debugging to get the block ID/refnonce, encrypted size, key gen, data version, etc. What do you think?" }, { "prediction": "I don't think this is necessary.", "reference": "For the commit message: The paragraphs seem to be out of order? The `Would not work because` refers to the stuff before, but there is a `This may seem pointless, but` in-between." }, { "prediction": "Why is this removed?", "reference": "Why did you remove these packages from the prelude, will your new functions not work without this change?" }, { "prediction": "I think this should be `std::back_inserter(keys.begin(), keys.end(), std::back_inserter(kvKeys))`", "reference": "We'd better reserve enough space before using kvKeys to avoid extra malloc." }, { "prediction": "I think this should be `GetNodeHostname` instead of `GetNodeName`.", "reference": "would it make sense to return empty or error if label doesn't exists?" }, { "prediction": "I don't think we need to use `setTimeout(attemptRm, attemptTimeout);` here. I think we should use `setTimeout(attemptRm, attemptTimeout);` instead of `setTimeout(attemptRm, attemptTimeout);`", "reference": "Don't penalize everyone with 250ms delay b/c some machines have problems." }, { "prediction": "I think this should be `fmt.Sprintf(\"%s %s\", out, s.Value().String())`", "reference": "Probably want a space after the second %s?" }, { "prediction": "I think this should be `Unavailable` instead of `Internal`.", "reference": "This seems like an internal error still?" }, { "prediction": "Line is too long. [89/80]", "reference": "Line is too long. [94/80]" }, { "prediction": "I think this should be `time.Time` instead of `time.Time`.", "reference": "out of curiosity, why creating another struct to wrap it?" }, { "prediction": "I think this should be `fmt::format(fmt::format(fmt::format(fmt::format(fmt::format(fmt::format(fmt::format(fmt::format(fmt::format(fmt::format(fmt::format(fmt::format(fmt::format(fmt::format(fmt.format(fmt.format(fmt.format(fmt.format(fmt.format(fmt.format(fmt.format(fmt.format(fmt.format())))),remain)))));`", "reference": "discipline vs. Discipline? Not sure of which is correct. Also not sure if there is already an existing string const." }, { "prediction": "I think this should be `overrideConfig.getAssignedProtoFile()` instead of `overrideConfig.getAssignedProtoFile()`.", "reference": "I believe this will break common resources, as they are defined in a common file, but must generate classes in service-specific namespace, so using protoFile to determine package of the generated class would not work, because common_resources namespace does not match service namespace." }, { "prediction": "I think this should be `SERIES_DEFAULT_NAME`", "reference": "How about `SPARK_DEFAULT_SERIES_NAME`?" }, { "prediction": "I think this should be `commit.status-check.max-wait-ms`", "reference": "The other properties are in `commit.status-check`, not `commit.status-checks`. Could you remove the extra `s`?" }, { "prediction": "I think this should be `this.skip()` instead of `this.skip()`", "reference": "Side note: I'd love to see more of these fields exposed on configuration." }, { "prediction": "Line is too long. [89/80]", "reference": "In the case of accounts generated by API clients, what name gets put for the `inviter_name` or `invited_by` record?" }, { "prediction": "I think it would be better to add a TODO for this.", "reference": "I think this class is only relevant for updating the QbftConfigOptions based on the transitions config, so probably not." }, { "prediction": "I think this should be `-32015` instead of `-32016`.", "reference": "what is the number thrown by Geth?" }, { "prediction": "I don't think we need to use `.split('?')[0]` here, but I think it would be better to use `.split('?')[0]` instead of `.split('?')[0]`.", "reference": "This would still crash on malformed database connection string like \"test\"" }, { "prediction": "I think this should be `PluginNameFromHostServiceContext(ctx context.Context, name string)`", "reference": "it is not an interface, maybe we can move to another package?" }, { "prediction": "I think this should be `getParentWindow` instead of `getParentWindow`.", "reference": "Same here. Can we use `this.instance.getSettings()` to get `tableMeta`?" }, { "prediction": "I don't think we need to check for `cgroup.Resources.CpuWeight != 0` here, but I think it's better to check for `cgroup.Resources.CpuMax != \"\"` here.", "reference": "Not sure whether this validation is useful." }, { "prediction": "I think this should be `utils.set_clipboard(None)` instead of `utils.set_clipboard(None)`", "reference": "Various things to note here: - Why would `question` ever be falsey (or `None`) here, i.e. why the `if question`? - Why would `question` ever not have that attribute? You set it in `Question.__init__`, so that check does nothing at all (and generally, `hasattr()` should be avoided if possible). - Why do you want to yank `None` (what does that do?) rather than e.g. show an error if there's nothing to yank?" }, { "prediction": "I think this should be `print(event['Progress'].get('Details'))`", "reference": "If this is needed for testing, you should use `pytest --log-cli-level=INFO` instead." }, { "prediction": "I think this should be `https://testnet2-location.mysterium.network/api/v1/location`", "reference": "We should drop ipify in all places i guess" }, { "prediction": "I think this should be `time.Duration`", "reference": "Add explanations around these variables - what do they mean, how they should be configured, etc." }, { "prediction": "this should be called on app init", "reference": "One thing tho - I would really appreciate any advice on where to move this to, so that it's called on initialisation of the website." }, { "prediction": "I think this should be `true` instead of `false`.", "reference": "To much tabs here (1 tab)" }, { "prediction": "I think we should use `limit` instead of `recordCleanupLimit`", "reference": "This is not maintaining retention time for logs as we are deleting only 1000 entries and we might end up with huge number of rows spanning over multiple months over a period of time if the cluster generates more rows as we are restricting ourselves to delete only 24k rows/day. Like I pointed out earlier a better would be to probably run this clean up every hour with some batch_size in a loop while there are records to be deleted(i.e older than 12 weeks) and committing each batch." }, { "prediction": "Why is this change needed?", "reference": "I don't like this helper func :-). Yeah, definitely don't like." }, { "prediction": "Why is this removed?", "reference": "Same here. This should remain unchanged. Please, add it back." }, { "prediction": "I think this should be `options.ignoreUndefined = this.s.options.ignoreUndefined || this.s.options.ignoreUndefined || this.s.options.ignoreUndefined || this.s.options.ignoreUndefined || this.s.options.ignoreUndefined || this.s.options.ignoreUndefined || this.s.options.ignoreUndefined || this.s.options.ignoreUndefined || this.s.options.ignoreUndefined || this.s.options.ignoreUndefined || this.s.options.ignoreUndefined;", "reference": "@kvwalker should this method have `ignoreUndefined` supported as an `option`?" }, { "prediction": "I think this is a good idea to use `logger.Sugar()` instead of `logger.Sugar()`.", "reference": "we dont use a `sugaredlogger` anywhere else in clutch, just curious why were using it here?" }, { "prediction": "Why is this removed?", "reference": "Not evident from looking at this diff but the queue is already being cleared four lines below." }, { "prediction": "I think this should be `t.Type == protocol.CompactCertTx && t.Sender == transactions.CompactCertSender`", "reference": "Why is this a 'transaction' and not in the block header?" }, { "prediction": "I think this should be `public X509Certificate2 ClientCertificate { get; set; }`", "reference": "This doesn't fit the abstraction level. Should we have a property bag for extra stuff?" }, { "prediction": "I don't think we need to add `gendoc.py` here.", "reference": "Looks like it is pretty easy to miss it when adding new files under `ci`. Hopefully, this doesn't happen too often." }, { "prediction": "I think this should be `b.p2pService = p2ps`", "reference": "do we really need the `Ready` call if startup fails midway?" }, { "prediction": "I think this should be `constexpr int32_t partitions = 6;`", "reference": "You can avoid changing the code if there are parameter defaults. right ?" }, { "prediction": "Why is this change needed?", "reference": "I wonder why the newline disappeared here? I guess we'll merge and see how SauceLabs fares across the supported browsers." }, { "prediction": "I don't think this is a good idea, but I think it would be better to use `atoi(sep->arg[1])` instead of `atoi(atoi(sep->arg[1]) == 0)`", "reference": "I know this is legal, but I prefer we put brackets on our calls" }, { "prediction": "I think this should be `AWS Identity and Access Management (AWS IAM) server certificate`.", "reference": "AWS Identity and Access Management (IAM)" }, { "prediction": "I don't think we need this class anymore.", "reference": "We keep who wrote the code anonymous." }, { "prediction": "I think this should be `!isUndefined(decimal)` instead of `!isUndefined(decimal)`", "reference": "Two things to make the code more error-proof and simplify it: 1. To be safe, this should be: `! isUndefined( decimal ) && ! isUndefined( decimal.value )` 2. The other clause that you changed below can be combined with that since `decimal` isn't used anywhere else, and so there's no point to re-check whether it's not undefined. In other words, this should become: `! isUndefined( decimal ) && ! isUndefined( decimal.value ) && 1000 > number`, and then you can remove the `decimal = decimal.value` assignment and replace it with line 146 (assignment of `readableNumber`)." }, { "prediction": "I don't think we need this interface.", "reference": "Wouldn't composite outbounds compose the transport, such that it would still be represented as a single transport?" }, { "prediction": "Why is this needed?", "reference": "nit: there is no need for a new line here, usually we tend to put an object creation and its deferred deletion next to each other. It helps not forgetting about the cleanup." }, { "prediction": "I think this should be `@author Maxime Steinhausser`", "reference": "Feel free to use the full notation with my email address: `Maxime Steinhausser ` :smile:" }, { "prediction": "I think this should be `const doubleCRLF = \"\\r\\n\\r\\n\";`", "reference": "This was unused across the codebase" }, { "prediction": "I think this should be `s.mu.Lock()`", "reference": "Should we put in which account we were trying to look up?" }, { "prediction": "I think this should be `supported_types` instead of `supported_types`", "reference": "either SUPPORTED_TYPECLASS or supported_typeclass. Camelcase only for class names." }, { "prediction": "I think this table should be `todo_pinned` and `todo_completed` as well.", "reference": "This is not going to work. You need to add a migration to the database." }, { "prediction": "I think this method should be renamed to `resumeGroupPlayback`", "reference": "Should these methods be renamed in this PR?" }, { "prediction": "I think this should be `this.metricStreamNames.ContainsKey(metricStreamName)`", "reference": "we need to include the `metricStreamName` which is invalid, so users know whats causing the issue." }, { "prediction": "I think this should be `AssemblyLoadContext.Default.LoadFromAssemblyPath(binaryPath)` instead of `AssemblyLoadContext.Default.LoadFromAssemblyName(binaryPath)`", "reference": "Please run Platform tests `DiaSessionTests`." }, { "prediction": "I think this should be `MSG_AVX_512_SUPPORT_INCOMPLETE_STRING` instead of `MSG_AVX_512_SUPPORT_INCOMPLETE_STRING`", "reference": "This is debug-build-only: we want a release-build notice. SYSLOG takes the name w/o the MSG and no _STRING. Args are via events.mc specifiers." }, { "prediction": "Is there a reason we don't need to check for `options.directconnection`?", "reference": "is it possible to have both forms here? I was hoping we wouldn't be introducing more cases where we had to check the upper and lowercase version of URI options." }, { "prediction": "I think this should be `int64.histogram` instead of `int64.histogram`", "reference": "Does the name suffix hardcode something? Not clear how changing the name fixes this." }, { "prediction": "I think this should be `@DisplayName(\"OPERATION: getUndispatchedFlows\")`.", "reference": "Is undispatched same as queued? getQueuedFlows?" }, { "prediction": "Why is this change needed?", "reference": "See above, same for all similar cases below." }, { "prediction": "Why is this needed?", "reference": "Why is this done twice?" }, { "prediction": "I think this should be `if ConditionEqualsTo(node.Status, v1alpha1.ConditionDeadlineExceed, corev1.ConditionTrue)`", "reference": "This sync can ensure that the condition of the child node is consistent with the parent node, but I still don't understand when the child will be overwritten, and this behavior is not what we expected?" }, { "prediction": "I think this should be `DEBUG_TEST_FAILURE` instead of `DEBUG_TEST_FAILURE`.", "reference": "This was renamed to avoid any confusion with the more general case of debugging via `plz debug`" }, { "prediction": "I think this should be `((String) val).substring(0, prefixLength).getBytes(StandardCharsets.UTF_8);`", "reference": "String valStr = (String)val; valStr.substring(0, Math.min(valStr.length(), prefixLength)) Make it clean." }, { "prediction": "Is there a reason we don't need this?", "reference": "Sorry, this still makes no sense.. the value of any union or enum is simply a name integer constant, it has nothing to do with the `BASE_TYPE_` enum. This value should be `0`. In particular: `Every union has the NONE field, which always has value 0`." }, { "prediction": "I think this should be `Alerter.getAzkabanURL()`", "reference": "Looks like getAzkabanURL() is added after concrete Alerter (Emailer)::getAzkabanURL(), so that Override annotation is needed." }, { "prediction": "I think this should be `np.bool` instead of `np.array`.", "reference": "The above 3 lines can be written as: `mask = segms[i].astype(bool)`" }, { "prediction": "I think this should be `github.com/iotexproject/iotex-address/address`", "reference": "File is not `gofmt`-ed with `-s` (from `gofmt`)" }, { "prediction": "I think this should be `logger.always_log(boost::format(\"Node started with peering port `%1%`.\", network.port));`", "reference": "Thought it's good to have this logged down so that we can check the used value in the logs." }, { "prediction": "I think this should be `*bool` instead of `*bool`.", "reference": "I don't think you can call this optional unless it's a pointer - remove this?" }, { "prediction": "I think this should be `List listSaveProduct = SendProduct.listAll(SendProduct.class);`", "reference": "@naofum please use `isEmpty`method instead" }, { "prediction": "I think this should be `if(!nullable_handle) return false;`", "reference": "i think this is unrelated and needs to be reverted. need to discuss at sync." }, { "prediction": "Why is this needed?", "reference": "Are we eventually moving those type interfaces from plugin project to datatype project? If not, then we'd have a dependency from core onto plugins, which seems a little counter-intuitive to me." }, { "prediction": "I don't think we need this function anymore.", "reference": "Love how we can finally use async/await in the codebase." }, { "prediction": "I think this should be `bool update_existing_accounts(request.get(\"update_existing_accounts\", false));`", "reference": "Very minor: this line could be moved to a more narrow scope, inside `if (!representative.decode_account (representative_text))` Other than that, LGTM" }, { "prediction": "I think this should be `IsPresent` instead of `IsActive`.", "reference": "when is this consumed? I'm probably missing it but I can't find it right now" }, { "prediction": "I think this should be `if (isRollup()) {`", "reference": "I think we also need to add the rollupGroupExprList() to the cache key. If we rebuild the list above from a ValueIdSet on line 418 above, it is probably going to be in the same order, regardless whether it was ROLLUP(a,b) or ROLLUP(b,a)." }, { "prediction": "I don't think this is needed.", "reference": "can use `getParamTypeName` instead" }, { "prediction": "I think we should use `$this->request->query->get('property')` instead of `$this->request->query->get('newValue')`", "reference": "Why send the parameters? They're accessible directly from `$this->request` so there's no need to inject them in the method" }, { "prediction": "I think this should be `shared.choose_file(multiple=False)` instead of `shared.choose_file(multiple=False)`", "reference": "Tiny nit: I would prefer `not selected_file` or `len(selected_file) == 0`, as if choose_file starts returning, for example, tuples instead of lists, this won't break." }, { "prediction": "I think this should be `if memberNodeName == e.config.ServerNodeName {`", "reference": "How will this code behave with hostnames that contain hyphens?" }, { "prediction": "I think this should be `kegg = NullForEmpty(row.GetCell(keggCol));`", "reference": "I think this is redundant since \"NullForEmpty\" already calls \"Trim()\"." }, { "prediction": "I think this should be `GroupCloudBackupID` or `GroupCloudBackupID`", "reference": "Change this to IDs too?" }, { "prediction": "I think this should be `list_of_DC_SCOUT_RAIDS` instead of `list_of_DC_SCOUT_RAIDS`.", "reference": "private static final, and it should be located in raidsoverlay, as it's not needed in the plugin. also the name could be a bit better, DC_SCOUT_RAIDS or similiar." }, { "prediction": "(style) line over 80 characters", "reference": "attr_value is 128 bytes?" }, { "prediction": "Why is this change needed?", "reference": "if it's unpredictable - why uppercase it at all?" }, { "prediction": "I think this should be `beforeinstallkubeedge` instead of `beforeinstallkubeedge`", "reference": "Please remove all these debug prints. It doesn't look good." }, { "prediction": "I think this should be `*types.BlockHeight` instead of `*types.BlockHeight`", "reference": "Consumers of this interface should not be required to provide `sampleHeight`. This should be an expected consensus parameter." }, { "prediction": "I think this should be `if startTime.Before(closeTi) {` instead of `if closeTime.Before(startTime) {`", "reference": "I don't believe this is the right fix. If startTime comes after closeTime, then it means some other event triggered invocation of this code path like workflow timeout. In this case we should still try to fire the cron on previous value so we should just return start the delta between startTime and closeTime immediately." }, { "prediction": "I think this should be `CloudBackupStatusType` and `CloudBackupTagType`.", "reference": "Not sure if we need tag here, it is an implementation detail in portworx that isn't exposed in openstorage" }, { "prediction": "I think this should be `@param bool $extended Whether to return a keyed array with the following keys.", "reference": "I wonder if it would be cleaner to refactor all of this similar to the SolrMarc driver, so we have a property with Summon field names associated with types, and we iterate through it in a loop... that way we don't have to repeat the loop code four times with different variable names." }, { "prediction": "Why not use `getCoreContainer().getSolrClientCache()` instead of `searcher.getCore().getCoreContainer().getSolrClientCache()`?", "reference": "Need the `solrClientCache.close();` further down in the method be removed since a shared cache is now used?" }, { "prediction": "I think this should be `Version`?", "reference": "according to the PR (schema changes?) these 2 field should be removed?" }, { "prediction": "Why is this removed?", "reference": "Panic here if `exp.Target.StressChaos.CintainerName` is nil." }, { "prediction": "I think this should be an interface, not an interface.", "reference": "This allows for some hacks like returning an iterator that matches more docs than the scorer. I liked the previous approach that returned an iterator better." }, { "prediction": "I think this should be `LOG.debug(\"Opening [{}] for read\", file);`", "reference": "Aren't there already logs for this from the underlying file system implementation?" }, { "prediction": "Why did you remove the `DismaxMunge` option?", "reference": "It would be good to have a test in here that demonstrates the new munge functionality; I can help set that up if you're not sure how." }, { "prediction": "I think this should be `max_retrials_to_get_pods` or `max_retrials_to_get_retrials`", "reference": "`retrials` isn't the word you intend. I think you mean `retries` and to that end, can the var name just be `max_retries`?" }, { "prediction": "I don't think this is a good idea, but I think it would be better to add a `help_text` to the list.", "reference": "Value in product should contain 255 characters or less." }, { "prediction": "why is this change needed?", "reference": "line is 133 characters (from `lll`)" }, { "prediction": "Line is too long. [83/80]", "reference": "since we're calling the file .rspec-local, I think we should rename local_options to project_options and use local_options for .rspec-local - WDYT?" }, { "prediction": "I think this should be `connection_config[:http_adapter]` instead of `connection_config[:http_adapter]`.", "reference": "Will we want to refactor this when we drop rsolr 1.x support?" }, { "prediction": "Why is this change needed?", "reference": "should this really be multiple IPs?" }, { "prediction": "I think this should be `@proposal` instead of `@proposal`", "reference": "Hmm, is that partial used in multiple places? Maybe we can just move that file in here." }, { "prediction": "This file is not used anymore.", "reference": "Should be 2014-2016" }, { "prediction": "I think this should be `value.StartsWith(quote) && value.EndsWith(quote)`", "reference": "Looks like my fault for sure in trying to handle international inputs regardless of locale. I think the correct fix is actually to get rid of TrySplitColumns and use ParseDsvFields instead. It is what gets used in the end, and it already has logic for dealing with quoted fields." }, { "prediction": "I think this should be `cursors[0].close();` instead of `client.close();`", "reference": "similarly here, are the these cursors not being closed when the client is closed?" }, { "prediction": "Why is this change needed?", "reference": "Or maybe `func(args ...string) Policy` to make it dynamic in case of any future policy that may require more than one args." }, { "prediction": "I think this should be `MakeFBOsForExistingJournals` instead of `MakeFBOsForExistingJournals`", "reference": "Should this happen even if the above failed?" }, { "prediction": "I think this file should be updated to be `2017`", "reference": "Please dont change this ." }, { "prediction": "I think this should be `%2$b` instead of `%2$b`", "reference": "There is a strange $b that looks wrong." }, { "prediction": "I think this should be `containerContainsText` instead of `containerContainsText`.", "reference": "Is it still important to have `speakEntry` here? It is checked before this value `containerContainsText` is used in the \"General\" section." }, { "prediction": "I think this should be in `lib/travis/lib/travis/lib/travis/lib/travis/lib/travis/lib/travis/lib/travis/lib/travis/lib/travis/lib/travis/lib/travis/lib/travis/lib/travis/lib/travis/lib/travis_lib.rb`", "reference": "It is `$JAVA_HOME/bin`, not `$JAVA_HOME`, which should be added." }, { "prediction": "I think this should be `#include `.", "reference": "Should move this to within the `#else` block as it's only used there." }, { "prediction": "Why not use `waitForAjax` here?", "reference": "is this a common rule to wait one extra second after ajax? I'm thinking about moving this extra wait into waitForAjax method." }, { "prediction": "I think this should be `unset($properties['site'], $properties['logger']);`", "reference": "Maybe you can correct the typo \"if\" too :)" }, { "prediction": "I think this should be `IdentifyForChat` instead of `IdentifyForChat`", "reference": "I'd prefer a name less chat-specific, since later on we could have other app types that want the same behavior. Maybe `IdentifyAndAllowTrackBreaks`?" }, { "prediction": "I think this should be `if (import_mpi4py() < 0) {`", "reference": "I think I was involved in writing that caster, but I never fully understood the `import_mpi4py` thing. Why is importing mpi4py still necessary at that point? I would think if the user is passing a communicator from python code, they must already have imported mpi4py themselves, or does that not propagate through into the wrapping layer?" }, { "prediction": "I think this should be `if resp.StatusCode == http.StatusNotFound {`", "reference": "This seems like a more interesting change. Maybe we should re-name the PR" }, { "prediction": "I think this should be `IConnectionLifetimeNotificationFeature` instead of `IConnectionLifetimeNotificationFeature`.", "reference": "Nit: implement the methods for these interfaces explicitly in this file for consistency. It can be passthrough." }, { "prediction": "I think this should be `addCallName(\"\")`.", "reference": "Not directly related to your PR, but I think here we should create a Type enum (MAP, ARRAY, PRIMITIVE) instead of having 3 flags." }, { "prediction": "I think this should be `NABoolean` instead of `NABoolean`.", "reference": "Do you want this to be a stack variable? The work method might return at any time (example: when the parent queue fills up) and then get called again, which would cause this variable to become false again. I'm wondering if this variable should be a member instead?" }, { "prediction": "I don't think we need to do this in a separate PR, but I think it would be better to use `reinterpret_cast` instead of `reinterpret_cast`.", "reference": "You could reserve a const space to save the extra computation." }, { "prediction": "I think this should be `_testPathNoRedundantSegments` instead of `_testPathWithRedundantSegments`.", "reference": "Did you consider adding rooted paths like `C:\\ProgramData` and paths with flipped separators?" }, { "prediction": "I think this should be `if err != nil {`", "reference": "does this line cause a panic if it is above the if condition ?" }, { "prediction": "I think this should be `LibraryDetailsPanels`", "reference": "Maybe `LibraryDetailsPanelType` would be clearer." }, { "prediction": "Why is this removed?", "reference": "minor nit - add \"persist-filesystem\" and \"persist-directory\" into commit message, as its something people may search on (maybe applies to a few other commit messages)" }, { "prediction": "I think this should be `const VkQueueFlagBits kQueueFlags[] = {VK_QUEUE_COMPUTE_BIT, VK_QUEUE_TRANSFER_BIT};`", "reference": "I verified offline with @jeremyg-lunarg this should be removed." }, { "prediction": "I think this should be `fmt.Println(\"incldued_wf name:\", i.Workflow.Name, \" timeout:\", i.Workflow.DefaultTimeout)`", "reference": "This should be removed? If not, typo in incldued_wf" }, { "prediction": "I don't think we need the `buttonStyles` property here, but I think it would be better to use `variant({ key: 'buttonStyles' })` instead of `variant({ key: 'buttons' })`.", "reference": "Sorry for the delay on this! It looks like Circle CI isn't running tests on some of the PRs, but this doesn't look like it would work I might be missing something, but are the tests all passing locally?" }, { "prediction": "I think this should be `[]string` instead of `[]string`", "reference": "Do you think the godoc should mention that all delimiters will be suffixed with `/`?" }, { "prediction": "I think this should be `aURL.startsWith(\"data:\") && SessionStore.get().isCurrentSessionPrivate()`", "reference": "what if I want to load my own, a different, data URI in Private Browsing mode? I do this often on desktop (e.g., `data:text/html,×`). admittedly, I wouldn't expect this to be done by a non-developer, but this will certainly cause a minor bug." }, { "prediction": "I think this should be `0L`.", "reference": "I remember the sequence number 0 is kept for the data files for iceberg v1, so in theory the sequence number from delete files should start from 1. So setting it to 0 as the default value sounds correct." }, { "prediction": "I think this should be `int_version` instead of `int_version`.", "reference": "For all these MYSQL queries unsigned is required. I have tested again and without unsigned these queries are failing." }, { "prediction": "I think this should be `MAX_HISTORY_HISTORY`", "reference": "Are there tests for this? What happens when you get to limit?" }, { "prediction": "I don't think we need this check anymore.", "reference": "Whole thing could be collapsed to `data['config']['transport'] ||= 'local' if target.name == 'localhost'`." }, { "prediction": "I think this should be called `bindServiceAndGetSignKeyId` instead of `bindServiceAndGetSignKeyId`", "reference": "maybe throw in `&& mServiceConnection.isBound()`, there are cases where the connection might die" }, { "prediction": "I think this should be `true` instead of `false`.", "reference": "Can we add Istanbul with this first EIP please? (or as a separate issue)" }, { "prediction": "I think this should be `nil` instead of `nil`", "reference": "I don't understand this change" }, { "prediction": "I think this should be \"Invalid public key\"", "reference": "Let's allow translators for this string to be translated: `self.show_warning(_('Invalid Public key'))`" }, { "prediction": "I think this should be `if (!role && !landmarks.includes(role)) { return false; }`", "reference": "This needs to work with `role=form` too." }, { "prediction": "I think this should be `if (localConnection && localConnection.type == Blockly.OUTPUT_VALUE)` instead of `if (localConnection && localConnection.type == Blockly.OUTPUT_VALUE) {`", "reference": "This should be before the if on line 1028, which should turn into an else if" }, { "prediction": "I think this should be `*[metav1.LabelSelectorRequirement]string`", "reference": "Not really introduced by this PR, but I don't recall why these have to be pointers, while `PodSelector` / `NSSelector` do not. Do you know the reason?" }, { "prediction": "I think this should be `sample-r.minRTT >= ackDelay`.", "reference": "Is there a reason why we are ignoring the ackDelay if it would result in a value smaller than the min? Why not `max(sample - ackDelay, minRTT)`?" }, { "prediction": "I think this should be `public` instead of `internal`.", "reference": "Here's an example of how the files in the `NotYetGenerated` directory drifted out of sync from the generated files. When we made the equality comparers internal, we neglected to fix this one." }, { "prediction": "I think this should be `admin_index?` instead of `admin_index?`.", "reference": "nice. we should do this elsewhere too. We have a lot of repeated stuff in the policies" }, { "prediction": "I think this should be `const char* src = \"actor A\\n\";`", "reference": "Small formatting thing, but can you remove the space before the semicolon?" }, { "prediction": "Why is this change needed?", "reference": "Not new, but nit: _writeLeng*th*." }, { "prediction": "I think this test should be in `TestComposeCmd`", "reference": "Our habit is to go ahead and put a description line (or more) in front of every function, not just non-test or exported functions." }, { "prediction": "Why is this change needed?", "reference": "Remove this file from the PR" }, { "prediction": "Why is this change needed?", "reference": "I think that for cloud variables, the default value in the prompt should be the variable name without the cloud prefix; this is slightly different from the scratch 2.0 behavior, but I think would ultimately lead to less confusion. Proposing code changes below:" }, { "prediction": "I think this should be `if (libinput_device_config_tap_get_finger_count(libinput_dev) > 0) {`", "reference": "I think I would rather fish this interface through than use it as the basis for heuristics." }, { "prediction": "Why is this change needed?", "reference": "Probably not worth making this line-ending change, since it is the only change to this file." }, { "prediction": "I think this should be `opnd_set_base_aligned(opnd, true);`", "reference": "Is this the correct place for this assert? Does this routine rely on it being 64, or was this only for testing?" }, { "prediction": "I think this should be `pb` instead of `pb`", "reference": "No pb please" }, { "prediction": "Line is too long. [89/80]", "reference": "We need to add indexes here on both `subscriber_id` and `changeset_id` or things will quickly collapse as we build up subscribers ;-) What I would suggest is a unique index on `[:subscriber_id, :changeset_id]` which will also make duplicate entries impossible, and an ordinary index on `[:changeset_id]` for finding the subscribers to a changeset." }, { "prediction": "I think this should be `if err != nil { return err }`", "reference": "use the context versions of everything, e.g. `PostMessageContext` and thread it through the functions. will save you a bunch of refactoring trouble later on." }, { "prediction": "I don't think this is a good idea, but I think it would be better to return `True` instead of `False`.", "reference": "\"not to be used elsewhere other than\"" }, { "prediction": "Why is this needed?", "reference": "Thanks for the contribution, @coolderli ! I also think the newPosDeleteWriter need the properties setting ..." }, { "prediction": "I think this should be `[:user_id, :team_id, :plan_type, :plan_id, :plan_type, :plan_id, :plan_type, :plan_id, :plan_type, :plan_id, :plan_type, :plan_id, :plan_type, :plan_id, :plan_type, :plan_id, :plan_type, :plan_id, :plan_type, :plan_type, :plan_type, :plan_type, :plan_type, :plan_id, :plan_type, :plan_type, :plan_id, :plan_type, :plan_type, :plan_type, :plan_id, :plan_type, :plan_type, :plan_type, :plan_type, :plan_type, :plan_type, :plan_type, :plan_type, :plan_id, :plan_type, :plan_type, :plan_type, :plan_type, :plan_type, :plan_type, :plan_type, :plan_type, :plan_type, :plan_", "reference": "These additions seem unrelated to this change?" }, { "prediction": "I think this should be `iceberg.engine.hive.enabled` or `iceberg.engine.hive.hive.hive.conf`.", "reference": "Could we move this to a class for Hadoop configuration properties, like `org.apache.iceberg.hadoop.ConfigProperties`?" }, { "prediction": "Why is this removed?", "reference": "The related statements should also be deleted." }, { "prediction": "I think this should be `params[\"PolicyNames\"] = \"\"` instead of `self.build_list_params(params, policies, 'PolicyNames.member.%d')`", "reference": "Shouldn't this line be removed?" }, { "prediction": "I think this should be `whitelisted_name` instead of `whitelisted_name`.", "reference": "Just move this into `const.py`. It already has similar stuff. Also, make it uppercase since it's a const." }, { "prediction": "I think this should be setMode(PasscodeMode.Check); if (newMode == PasscodeMode.Check) { setMode(PasscodeMode.Check); } else if (newMode == PasscodeMode.Check) { setMode(PasscodeMode.Check); } else if (newMode == PasscodeMode.Check) { setMode(PasscodeMode.Check); } else { setMode(PasscodeMode.Check); } else { setMode(PasscodeMode.Check; } else { setMode(PasscodeMode.Check); } else { setMode(PasscodeMode.Check); setMode(PasscodeMode.Check); }", "reference": "Issue is that `currentMode = newMode;` is called at the end of the method. Passcode screen will come up, but since the activity thinks current mode is biometric check we don't check passcode when submitted." }, { "prediction": "Why is this change needed?", "reference": "Need change it back?" }, { "prediction": "I don't think you need to change the secret_key_base here.", "reference": "Didn't we delete this file a while back because it isn't used but people think that it's a security vulnerability that it's checked in?" }, { "prediction": "Is this needed?", "reference": "nit: Looks like this can be removed now" }, { "prediction": "Why is this removed?", "reference": "Can probably remove the lines above it too (L60-62), since ProvisionDefaultCA() makes sure the map isn't nil." }, { "prediction": "I think this should be `h2o_config_register_status_handler(conf->global, requests_status_handler, durations_status_handler);` or `h2o_config_register_status_handler(conf->global, events_status_handler, durations_status_handler);`", "reference": "Do you think it's worth erroring out? It's likely that this is a configuration error that the user might want to know about?" }, { "prediction": "I think this is a bug.", "reference": "I think the functional test should not change here, this is probably a test in itself :)" }, { "prediction": "I think this should be `p.AllowAttrs(\"type\").Matching(regexp.MustCompile(\"^checkbox$\")).OnElements(\"input\").OnElements(\"checked\").OnElements(\"disabled\")`", "reference": "Why this to be a public function?" }, { "prediction": "I think this should be `timing: false` instead of `timing: false`", "reference": "I think we can remove the timing for export env vars" }, { "prediction": "I think this should be `Provider` instead of `Provider`", "reference": "wrong import grouping" }, { "prediction": "I think this should be `System.arraycopy(MainActivity.NAV_DRAWER_TAGS, 0, navTags, 0, 3);`", "reference": "There is a doubled semicolon ;)" }, { "prediction": "I think this should be `openssl/md5.h` instead of `openssl/sha.h`.", "reference": "I'm wondering why this isn't . Seems like one would have to copy the md5.h file into the source tree somewhere for this to compile cleanly. Maybe you meant to use angle brackets instead of quotes?" }, { "prediction": "I think this should be `visibility_of_any_elements_located`", "reference": "shouldn't **call** return a boolean?" }, { "prediction": "Isn't this the right thing to do here?", "reference": "We don't need to cast to client here. (well, from spell gem not AA etc) We should also make sure the charm is a casted spell before calling SendSpellBarEnable." }, { "prediction": "I think this column should be `invocation_id`.", "reference": "This is not an `id`. This should either be `invocation_time` or `invocated_at` to be consistent with what we are using elsewhere, and also to better rerflect the column's DateTime type. Also, within the context of this table, there is no idea of what `invocation` is. I know that `scanner` may not be future-proof, but we need to find something more descriptive. Perhaps one possibility is to call this `audit_time`." }, { "prediction": "I think this should be `tx.Receiver` or `tx.AssetTransferTxnFields.Receiver`", "reference": "should the 'Receiver' be the clawback address in case of clawback transaction?" }, { "prediction": "I think this should be `volumeAPIPath`", "reference": "@ashishranjan738 -- Where are these consts used? in which pkg?" }, { "prediction": "I think this should be set with: `:toctree: Python-API.rst` or `:toctree: Python-API.md`", "reference": "The only change I would suggest is moving these lines back below the `templates_path` variable to keep the diffs smaller." }, { "prediction": "Why is this change needed?", "reference": "Having it above kept the block info in the cached changes, which could end up confusing things quite a bit." }, { "prediction": "I think this should be `options[:task_options]` instead of `options[:task_options]`.", "reference": "If the execute_task returns an `ExecutionResult`, the passing of a block would be unnecessary. Instead, the `ExecutionResult` could be presented to the user in some standardized way (iterating over the result of each node, etc.)." }, { "prediction": "Why is this needed?", "reference": "Not sure why we make a new channel here. If we don't use this channel, how about creating it inside the `Connect`?" }, { "prediction": "why not use `lastLogId` here?", "reference": "There are two question here: 1. If you only modify lastLogId, but the `iter` is not modified, I really don't know whether we can succeed. 2. We will check the if the term has changed in `replicateLogs` (if rollback really happen, the term must have been updated), so I really doubt whether the problem should be fixed in this way. Or you could describe it in more details." }, { "prediction": "Why is this change needed?", "reference": "Hello @jDolba, I have reviewed your PR and I found one problem. `$step->getFormType()` can return `FormTypeInterface`. You cannot use interface as key for an array. Can you find some better way to fix this? Thank you." }, { "prediction": "I think this should be `installInventoryYumEL6`", "reference": "i was confused by keyword \"inventory\" here. my understanding is this starts the osconfig-agent which covers inventory lookup and package-management(correct me if i am wrong)." }, { "prediction": "I don't think we need to add the `timeouts` and `timeouts` as well.", "reference": "These are really meant to be the keys in the capabilities, not the keys of values within the capabilities" }, { "prediction": "I don't think we need to import sinon here. I think it's better to use `sinon.sinon` instead of `sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sinon.sin", "reference": "This breaks tests on IE because this will import an `esm` bundle. For that reason `sinon` is available as a global in our test suite and never imported. The global is aliased to the proper `es5` file." }, { "prediction": "I think this should be `timeReorderingFraction = 1.0 / 8`", "reference": "Maybe move all the Loss Recovery constants to a separate file." }, { "prediction": "I think this should be `diskName`", "reference": "this field is added so that we can find disk name by device name from attachments" }, { "prediction": "I don't think we need this package anymore.", "reference": "Unnecessary new line" }, { "prediction": "I think this should be `state.NamespacePaths[nsType] = ns.GetPath(pid)`", "reference": "First determine if the namespace already exists, so it's clearer that it's handling namespaces that aren't included in the `c.config.Namespaces`" }, { "prediction": "Why is this removed?", "reference": "What changed in the styles that means we don't need this?" }, { "prediction": "I think this should be `projectJsonRoot[\"frameworks\"][framework][\"dependencies\"]` instead of `projectJsonRoot[\"frameworks\"][framework][\"dependencies\"]`", "reference": "This pattern should be applied to the other instance where NewtonsoftEscapeJProperty is used and you can remove the NewtonsoftEscapeJProperty method." }, { "prediction": "I think this should be `warning` instead of `warning`.", "reference": "Something to mention in the next changelog/release notes. It will be good to get histogram working consistently with everything else." }, { "prediction": "I think this should be `[{{.Volume.runNamespace}}]` instead of `[{{.Volume.runNamespace}}]`", "reference": "What does this contain? Is it PVC namespace or is it openebs?" }, { "prediction": "I don't think we need this interface, but I think it should be `IHttpRequestBodyMinimumDataRateFeature`?", "reference": "Design note: Using local concrete data types on a feature abstraction makes it hard to generalize / replace. This is tolerable so long as this remains a kestrel exclusive feature, but we'd need a different design if this were ever moved to HttpAbstractions." }, { "prediction": "Why is this change needed?", "reference": "this will break R package, you should update the R files accordingly. BTW, the call state should be in the last argument." }, { "prediction": "I think this should be `if (null !== $mediaContext) {` instead of `if (null !== $mediaContext) {`", "reference": "Shouldn't we throw an exception if the context is null instead ?" }, { "prediction": "I think this should be `>= 1.10.0`", "reference": "These should both be const, not var right?" }, { "prediction": "I think this should be `registry_match_cost`?", "reference": "Rename the directory, match_costers -> match_costs" }, { "prediction": "I think this test should be `test_delete_collection_gives_number_of_deletable_records_in_headers` and `test_delete_collection_gives_number_of_deletable_records_in_headers`", "reference": "I don't think this should go in the model tests, since it is done in the resource. `PaginatedDeleteTest` seems more appropriate" }, { "prediction": "I think this should be `SessionNotFoundException` instead of `SessionNotFoundException`.", "reference": "It would be better to just change RWD to throw IllegalStateException if you attempt to execute a command after quit (unless it's a second call to quit())" }, { "prediction": "Why is this needed?", "reference": "Could we move this to an example test to allow the compiler to help us ensure it stays up-to-date in the future?" }, { "prediction": "I think this test should be removed.", "reference": "Maybe we could update these to use $future and then check on stderr? that way when we deprecate stdout we can not have to delete tests." }, { "prediction": "I think this should be `(int) _maxFrameSize;` instead of `(int) _maxFrameSize`.", "reference": "Remove this since it always has to be set afterwards." }, { "prediction": "Why is this needed?", "reference": "These two tests were causing us to use too many goroutines with `-race` using the default block change size, I think due to prefetching." }, { "prediction": "Shouldn't this be `raise TypeError` instead of `TypeError`?", "reference": "Is that `try..except` block really needed? I mean, when it could fail?" }, { "prediction": "I think this should be `**.test.js` instead of `**.test.js`.", "reference": "If you only want to run a specific group of tests you can always use `.only` like `it.only()` or `describe.only()`. It may not speed up the globbing process as much as this change here :)" }, { "prediction": "I think this should be `DEFAULT_BATCH_SIZE = 10`", "reference": "nit: I'd probably rename this to `BATCH_SIZE_RANGES`, to use a slightly more descriptive name." }, { "prediction": "Why is this change needed?", "reference": "aren't these the wrong way around?" }, { "prediction": "Why not just return `this.coreConfigService`?", "reference": "Lets call this getConfigSetService and maybe rename the field now (or later)" }, { "prediction": "Why is this removed?", "reference": "Could / should we make these constants and give them a type?" }, { "prediction": "I think this should be `hive.openshift.io/platform-unknown`", "reference": "lets stick with lowercase for consistency." }, { "prediction": "Why is this removed?", "reference": "ordering of imports went wrong" }, { "prediction": "I don't think we need this method anymore.", "reference": "I think these can all be .name() to get the value we are looking for" }, { "prediction": "I think this should be `printOnlyString` instead of `printOnlyString`", "reference": "Is this a good place for these test cases?" }, { "prediction": "Why is this printed?", "reference": "Did you mean to leave the print statement?" }, { "prediction": "I think this should be `new BN(500000000);`", "reference": "I would do `new BN(Interpreter.LOCKTIME_THRESHOLD)`" }, { "prediction": "I don't think we need this import anymore.", "reference": "@ftomassetti I turned the tree walking algorithms into iterators so you don't have to visit every node when you only wanted a few, like for a `findFirst`." }, { "prediction": "Why is this change needed?", "reference": "Need to add type name here to be compatible with proto string representation." }, { "prediction": "I think this should be `log.info(\"Building \" + target + \" ...\");`", "reference": "This is to let people know that the tooling is doing something during a build. Please leave." }, { "prediction": "Why is this changed?", "reference": "Why is the principal changing here?" }, { "prediction": "I think this should be `AZURE_BLOB_DOMAIN`.", "reference": "Naming nit: let's use `AZURE_STORAGE_` prefix for consistency with the other ones." }, { "prediction": "I think this should be `progressIndicator` instead of `progressIndicator`", "reference": "I'm a bit confused. We have an actual `ProgressBar` Uppy React wrapper component that we are testing. Why do we need a mock for it?" }, { "prediction": "I don't think this is needed.", "reference": "can we use `github.com/pkg/errors`?" }, { "prediction": "I think this should be `inType.Nature()` instead of `inType.Nature()`", "reference": "I changed the name of the arguments here just to help make the code clearer." }, { "prediction": "I think this should be `DynamicMap` instead of `DynamicMap`.", "reference": "I think either 'avoiding calls to the function' or 'to avoid calling the function ...' would be read better." }, { "prediction": "Why is this change needed?", "reference": "@sfricke-samsung -- thanks. saves a few atomic ops which is always good :) The TODO is there to track that this object is storing *both* vectors of shared_ptr and plain pointers to the same data. The shared are to ensure scope, and the plain are for backwards compatibility with existing code that consumed a plain pointer vector (and some code that still does). That should be cleaned up." }, { "prediction": "I think this should be `using Nethermind.Monitoring;`", "reference": "minor: typo (knowMetricsTypes -> knownMetricsTypes)" }, { "prediction": "I think this should be `static_cast(right)` instead of `static_cast(right)`", "reference": "This adds a case-insensitive flag to the type in the RangeSpec, but I don't think RangeSpecs are written to handle case-insensitive comparisons. Take a look at the methods that deal with comparisons when building RangeSpecs, in file Range.cpp. So, I think you would have to do one of two things: a) disable the RangeSpec transformation for case-insensitive comparison operators (the easy way) or b) change the RangeSpec methods to handle case-insensitive comparisons." }, { "prediction": "I think this method should be called `solveMethodInType` instead of `solveMethodInType`.", "reference": "I would throw an exception if the type is not solved" }, { "prediction": "why remove this?", "reference": "if remove `dt.skipLoad` - then this tests will run. You probably mean opposite?" }, { "prediction": "Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.", "reference": "I feel like we do this in a lot of places should we move that out into its own PR?" }, { "prediction": "Why is this change needed?", "reference": "Already asked you in Matrix, but I'll do it here again so it can be discussed publicly. Why?" }, { "prediction": "I don't think we need this line.", "reference": "I think here should be a comma before remove, in all the cases" }, { "prediction": "I think this should be `if not hasattr(context, \"num_stages\"):` or `if not hasattr(context, \"num_stages\"):`", "reference": "Single quote is used by default in this project." }, { "prediction": "Why is this removed?", "reference": "S1023: redundant `return` statement (from `gosimple`)" }, { "prediction": "Why is this needed?", "reference": "`ctx` is unused in Close" }, { "prediction": "I think this should be `HttpKernel\\Exception\\NotFoundHttpException`.", "reference": "I'm confused. This exception is thrown when `HeurekaCategory` is not found in database. But this exception extends Http exception. Why? What has database search common with http? If the only reason is that it is the same in the whole project, then fine. But then we have even bigger problem - we don't know how to use exceptions." }, { "prediction": "I think this should be `backbone_head` or `bbox_head`", "reference": "Is it necessary to add the suffix `on_head`, because it belongs to` bbox_head`?" }, { "prediction": "I think this should be `[Omit grub linux and initrd suffixes for EFI/BIOS booting on GRUB >2.02 (default: no)]`, not `[Omit grub linux and initrd suffixes for EFI/BIOS booting on GRUB >2.02 (default: no)]`.", "reference": "Hmm, I wonder if this should just be e.g. `--with-grub-2.02` instead. (Not sure Autoconf supports periods in these switches.) Today's modern GRUB is tomorrow's ancient GRUB. :) Or maybe we should be specific about the feature this is enabling, which might be safer given that each distro carries so many patches. E.g. `--without-grub-efi-16-suffixes`?" }, { "prediction": "Why is this change needed?", "reference": "Add a GetSerialPortOutput method to Instance that way you don't need to access the client, also it makes the call cleaner as you don't have the odd i.Client and path.Base(i.Project), path.Base(i.Zone)" }, { "prediction": "Line is too long. [82/80]", "reference": "Line is too long. [104/80]" }, { "prediction": "I think this should be `expectedAssignedCds` or `expectedRunningCDs`", "reference": "Since CD updates (assignment & power state) are now done in this controller..." }, { "prediction": "I don't think we need this.parentStack.join('\\n\\n')", "reference": "Hmm I'd rather not support this option going forward - it seems like a one-off just to work around this particular issue. Would it be fine to just remove the `deepStackTrace` option? The rest of the PR looks great - I love the idea of switching to sets." }, { "prediction": "I don't think we need this method anymore, but I think it would be better to just call it `comment_creator`?", "reference": "on the one hand I like how little this is doing. On the other hand, `inbound_mail_parser` is doing most of the work here so maybe it's not as helpful as I originally thought" }, { "prediction": "I think this should be `history_depth(10).asynchronously(eprosima::fastrtps::rtps::RTPSWriterPublishMode::ASYNCHRONOUS_WRITER).init();`", "reference": "This line is too long" }, { "prediction": "Why is this changed?", "reference": "This isn't a fatal error, we don't want to crash just because we can't set configs, we have sane defaults set" }, { "prediction": "Why is this change needed?", "reference": "I wondered why `buffer` was passed into `LookupPath`. What is happening here? Is `buffer[:0]` equivalent to `[]V4TrieEntry{}`, and hence `buffer` isn't needed any more?" }, { "prediction": "I don't think we need the `` tag here. I think it would be better to use `` instead of `` instead of ``", "reference": "I don't really like the name of this file, especially the encoding of an implementation detail (the fact that it's a table) in the name. Can we just use `_message_body.html.erb` instead maybe?" }, { "prediction": "I think this should be `bool` instead of `bool`.", "reference": "Feel better not to expose our internal implementation in API/CRD, so no need to mention agent here. Consider: EnableLogging indicates whether or not to generate logs when rules are matched. Default to false." }, { "prediction": "I think this should be `readonly && spaceId_ != 0` instead of `spaceId_ != 0`", "reference": "use `NebulaKeyUtilsV3::dataVersionValue()` to replace the literal value?" }, { "prediction": "I think this should be `try: if os.path.isfile(path): path = os.path.join(path, os.path.basename(path)) else: path = os.path.join(path, os.path.join(path, os.path.join(path, os.path.dirname(path)))`", "reference": "No need for the `\\` here, inside parentheses whitespace is ignored by Python." }, { "prediction": "I think this should be `` instead of ``", "reference": "This doesn't seem like the right expected result... it should be the same as the `clientCert` var defined above." }, { "prediction": "Why is this removed?", "reference": "need to rename this now." }, { "prediction": "I think it would be better to use `ignoringFields(\"commitmentHash\", \"logs\", \"blockNumber\", \"logsBloom\", \"transactionIndex\")` instead of `ignoringFields(\"commitmentHash\", \"logs\", \"transactionIndex\")`.", "reference": "NIT: This shouldn't be a TODO. It is just a note isn't it?" }, { "prediction": "I don't think this is a good idea, but I think it would be better to use `message.warning('Edited element vanished')` instead of `message.warning`", "reference": "I changed this to an error, that seems more appropriate than a warning here." }, { "prediction": "Why is this change needed?", "reference": "This change could mute unit test failure, but it is better to update unit tests" }, { "prediction": "Why is this removed from the list?", "reference": "All other places that access `notificationIdsInUse` are in methods with descriptive names. We should do the same here. Maybe `markNotificationIdAsFree()`?" }, { "prediction": "Why is this removed?", "reference": "keep as `ErrNotFound`, it is the same convention as in other packages" }, { "prediction": "I don't think we need to do this in `ifconfig.me`", "reference": "Same here, we need to call `callback` in else branch" }, { "prediction": "I think this should be `String.valueOf(certRecord.getHostName())`", "reference": "At this point we already check that the record is valid and so it could never be nulll" }, { "prediction": "I think this should be `@title = t(\"user.account.title\", current_user.account.title)`", "reference": "Would it not be more sensible just to move setting of the title to later in the method rather than duplicating it here?" }, { "prediction": "I don't think this is needed.", "reference": "why not do it in `reclaimExpiredSessions`? and `pushSessionToCache` can delete" }, { "prediction": "why do you need this?", "reference": "out_channels/num_outs/type are unnecessary" }, { "prediction": "Is there a reason to use `Object.keys(dict)` instead of `Object.keys(dict)`?", "reference": "You can create an issue for it and put it on the backlog so we don't forget it." }, { "prediction": "I think this should be `debug.Print(\"Ignoring container %s with --net=%s\", container.ID, networkMode(container.HostConfig))` instead of `debug.Print(\"Ignoring container %s with --net=%s\", container.ID, networkMode(container.HostConfig))`", "reference": "So now we are checking twice, both here and in `weaveCIDRsFromConfig`. Not great. I suggest changing the `ok` return of `weaveCIDRsFromConfig` to a messsage (or error?) instead, which we can then log." }, { "prediction": "I think this should be `store.create_package(owner, pkg, PackageFormat.HDF5)`", "reference": "An alternative to setting format to the default in Package.__init__ would be to set it in create_package. I think we can assume all packages are created by create_package, but not necessarily by build_package." }, { "prediction": "I think this should be `Hash` instead of `Hash`.", "reference": "Let's add fee recipient as well." }, { "prediction": "I think this should be `# pylint: disable=super-init-not-called`.", "reference": "No need for those with `super-init-not-called`, as pylint already only turns things off for this function and it's needed for the entire function." }, { "prediction": "I think this should be `APPLICATION_NAME` instead of `APPLICATION_NAME`", "reference": "I think there's another spot for this in DefaultCapabilityMatcher" }, { "prediction": "I don't think we need to use `currently_awaiting_steps.first` here.", "reference": "this name seems pretty vague -- thoughts on a more descriptive method name?" }, { "prediction": "I think this should be `` or ``", "reference": "what changed in this line?" }, { "prediction": "I don't think we need this variable anymore.", "reference": "Instead of doing this let's add another function similar to `hasZeroData` for selecting the `reportArgs` since this is all sourced from selected values. Then `hasZeroData` can use this internally, as well as the component itself. Since this function would be internal just for the purpose of avoiding duplication, we don't need to expose it on the component the same way though." }, { "prediction": "Why is this removed?", "reference": "This line was useful for auto-completion, I think it should be re-added with specifying the var name (`$exception`) and simplifying the FQCN." }, { "prediction": "I think this should be `errCh := make(chan error, 1)`", "reference": "This looks like you're not collecting everything from the error channel." }, { "prediction": "I think this should be `@plan = checkout.plan`", "reference": "This currently violates the Law of Demeter. Using `checkout.plan_name` is the quick resolution." }, { "prediction": "Why is this change needed?", "reference": "is there any scenario when `$temporaryFilename` can be null?" }, { "prediction": "I think this should be `@SuppressWarnings(\"ReferenceEquality\")` instead of `@SuppressWarnings(\"ReferenceEquality\")`.", "reference": "this is for the `boolean isRoot = root == rowType` check, which seems to be on purpose, but maybe you could double check whether using ref. equality here is still wanted? Same for `SparkTypeToType`" }, { "prediction": "I think this should be called after the root_drag_icon_handle_surface_commit() is called.", "reference": "No need to damage after `roots_drag_icon_update_position`, this is already done in `roots_drag_icon_update_position`" }, { "prediction": "`device` should be `'`", "reference": "Have you tested exporting to ONNX with `device=cuda`?" }, { "prediction": "I think this should be `o.name != \"\"`", "reference": "Do we also need to validate `envName` flag then? `appName` and `envName` are used in `initLogsSvc` which are called by `svc logs` from within `Execute()`" }, { "prediction": "I don't think we need the `!empty($trustedHosts)` check here.", "reference": "@LukeTowers I think I would prefer that we don't force it, on the basis that: a) some people would be opting to configure their web server to protect against this kind of attack and would disable this feature in October CMS to get a small performance increase. b) it might be a bit misleading to say that `app.trustedHosts` set to `false` disables the feature entirely, just to have it be overridden here regardless." }, { "prediction": "I think this should be `c.acnpInformer.Indexer().ByIndex(ClusterGroupIndex, cg.Name)`", "reference": "i like that you are trying to correct the naming, but its making the PR longer :( i guess in future we can do such changes in separate PRs" }, { "prediction": "I think this should be `Safari 14.0`", "reference": "Are we marking what the browser's accessibility tree says or what screen readers with those browsers say?" }, { "prediction": "I think this should be `FullClose` instead of `FullClose`.", "reference": "This method should behave as intended, to block until it reads an EOF from the other side." }, { "prediction": "I think this should be `Fail to health check` instead of `Health check failed`", "reference": "I prefer starts with `Failed to xxx`, how about `Failed to perform health check on xxx`?" }, { "prediction": "I think this should be `Tags.AzureAppServicesSiteKind` or `Tags.AzureAppServicesSiteType`.", "reference": "All these calls make me think we should refactor how traces are started and allow \"source tags\" that we initialize a trace with. I'd like to do this in a follow up." }, { "prediction": "I think this should be `v1_test`", "reference": "This file shouldn't be in this PR" }, { "prediction": "I think this should be `SKIPPED-nonEmptyAssignmentToListElementChangeType`", "reference": "This now causes `LessSpecificReturnStatement - src/somefile.php:9:32 - The type 'non-empty-list<5|string>' is more general than the declared return type 'non-empty-list' for takesList`, which seems correct to me. The type `non-empty-list<5|string>` contains the type `non-empty-list`. Thoughts?" }, { "prediction": "I think this should be `LOG.info(\"Storing private transaction in enclave\");`", "reference": "Are you going to change that back?" }, { "prediction": "I think this should be `ifneq(false, $(staticbuild))`", "reference": "we have a standard format for putting these together elsewhere, it does the filter check first and errors out and then sets based on the value. i think this should be adjusted to do that. there's no logical change, just an approach change." }, { "prediction": "Please enter the number of steps to delay.", "reference": "Note this should be `delay` instead of `scale` here. I'll fix this in my branch." }, { "prediction": "Why is this removed?", "reference": "`on` likely still needs a bind, similar to `this.resetProgress = this.resetProgress.bind(this)` correct?" }, { "prediction": "I don't think you need to import `get_dist_info` here.", "reference": "Considering the trade-off between training speed and accuracy, multi-scale training is temporarily kept. More elegant implementation will be adopted in the future." }, { "prediction": "I think this should be `context.Context`", "reference": "Can you move this up along with the other builtin libraries?" }, { "prediction": "I think this should be `if globalVars.appArgs.secure`", "reference": "I actually think it makes sense to reposition this checkbox after the notifyForPendingUpdateCheckBox. The current order of check boxes is a bit arbitrary now." }, { "prediction": "I think this should be `CheckoutCommand` or `CheckoutCommand`?", "reference": "Why do we have both `before` and `after`? Naively I would expect this to work as follows: `plz query changed` with no arguments compares the current working directory state to the last commit (i.e. HEAD, i.e. a noop when directly on a git commit). `plz query changed --since [reflike]` compare the current working directory state to the given reflike. So for CI I would expect to run something like `plz query changed --since @{upstream} (or origin/master I guess)`. And on merge I'd either run everything or just `plz query changed --since HEAD^` (given our workflow) - I don't think I'd ever want to do anything else. Either way I think before and after are slightly confusing terms here." }, { "prediction": "I think this should be `is_binary = False` instead of `is_binary = True`", "reference": "Is there a reason why we can't use `~dst`? It feels like that could be good enough.I would like to avoid extending the filter syntax unless there's an urgent need. :)" }, { "prediction": "Why is this change needed?", "reference": "Why local and not UTC?" }, { "prediction": "Is there a reason we don't need to check for `diagArea_->contains(-2013)`?", "reference": "2012 is a retryable error. Will avoiding rgenerating it here cause a difference in behavior in createServer() ?" }, { "prediction": "I think this should be `github.com/iotexproject/iotex-address/address`", "reference": "move to line 14 below" }, { "prediction": "I think this should be `intersectsTriangle` instead of `crossesTriangle`.", "reference": "the method name should match teh docs" }, { "prediction": "I think this should be `newRootMetadataOrBust(config.MetadataVersion(), id, h)`", "reference": "Won't this happen automatically when we flip the default version in the config?" }, { "prediction": "I think this is a good idea to remove the `docroot` prefix.", "reference": "This would also change back to /var/www/html/docroot if we go that way." }, { "prediction": "I think this should be `hasImplicitRole` instead of `hasImplicitRoleMatches`", "reference": "This still needs to use the new option. We'll need tests for it too." }, { "prediction": "I think this should be `if obj.name == obj.value:`", "reference": "We are no longer including file name in the source files." }, { "prediction": "Align the parameters of a method call if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "no need for this. Devise provides us with `current_user` and `user_signed_in?` helpers." }, { "prediction": "I think this should be `capability.getName().equals(NAME) && capability.getVersion() >= ETH66.getVersion();`", "reference": "Would `Object.equals(capability.getName(), NAME)` would be safer, as you wouldn't have to do null checks?" }, { "prediction": "Line is too long. [98/80]", "reference": "Hmm, I wonder if we should revert #1862 instead? BTW, what failure do you get w/o this line?" }, { "prediction": "I think this should be `errors.Wrapf(err, \"invalid 'apiURL' %s in slack config\", out.APIURL)`.", "reference": "since there are several places where we do 1) get secret key ref and 2) validate URL, maybe it's worth having a common method? it could also trim spaces as done here (but not at the other places currently)." }, { "prediction": "Why is this change needed?", "reference": "TestNormalize... I would also split them" }, { "prediction": "Why is this change needed?", "reference": "All changes to this file are going to conflict with #7599. Please revert these as well. They will be addressed during the Python 3 transition." }, { "prediction": "I think this should be `r.random.Intn` instead of `r.random.Intn`", "reference": "Just thought, using spinlock (busy wait with compare and swap) that generates 2 random numbers inside rlock. We know that collisions are rare and we don't need that \"large\" write lock really but lock namely for \"rand\". Or least use a separate Lock (Mutex), namely for \"rand\" (wrap it into method). Mutex will use some sort of spinlock as well but it may use some linked list to make it more fair." }, { "prediction": "I think this should be `astroid_version` instead of `pylint_version`.", "reference": "Can we grab it directly from `__pkginfo__` as that is the source of truth for the version?" }, { "prediction": "I think this should be `org.openqa.selenium.grid.distributor.Distributor`", "reference": "We can revert this to reduce the diff of the PR." }, { "prediction": "I think this should be `protoPkg.contains(\"cloud\")`", "reference": "This looks weird. `isCloud` should define if it is a cloud or no. Here it does it partially, and it can be overriden by protoPkg value (which also an argument to this function). Please make sure that isCloud completely defines the cloud thing. (i.e. it an be as straightforward as moving `protoPkg.contains(\"cloud\")` from here to the place where `assembleGoImportPath` is called." }, { "prediction": "I think this should be `(LobTgtFileFlags)fileflags == Lob_Error_Or_Create`", "reference": "Declaring fileflags to be of type LobTgtFileFlags would eliminate the need for all this casting. And would be safer. (Not a show-stopper though.)" }, { "prediction": "I think this should be `LOG.info(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String)))))))))))))))))))))))))))))))))))))))))))))))))))))", "reference": "This change prevents a user understanding how their server is configured. Best to leave at `info` level." }, { "prediction": "I think this should be `if defined(SSL_set_tlsext_host_name)` instead of `#if defined(SSL_set_tlsext_host_name)`", "reference": "Typically we would add something to the build system environment to differentiate this; also is there an alternative that can be used with older OpenSSL? Other folks who are committers will need to decide if it is worth supporting an older and likely quite vulnerable (to hacks) OpenSSL library." }, { "prediction": "Why is this change needed?", "reference": "`readActiveBlockProducersByHeightTests` is a global variable (from `gochecknoglobals`)" }, { "prediction": "I think this should be `sync.getTarget().getIdFieldName()` instead of `sync.getTarget().getIdFieldName()`", "reference": "Falls back on `Constants.ID` if there's no custom field set." }, { "prediction": "I think this should be `in.skip(this.getOffset());` instead of `in.skip(this.getOffset());`", "reference": "I believe this is what we want to rearrange: this in.skip() should not be happening here, in the open method, but in the setOffset() method itself. Because we want to be able to change that offset after the initial open. The setOffset() method will need to throw an IOException, if it's called while the InputStream is still null; or if the skip() call itself results in an IOException()" }, { "prediction": "I think this should be `isPrimitiveReturnType`?", "reference": "In case the method is `void`, there won't be any children and `getChild(0)` throws. We'll need to check with `isVoid()` for that case. I'll update this when I merge." }, { "prediction": "I think this should be `yarpc.Interceptors{requestLogInterceptor{}}`", "reference": "If the yarpc.Interceptors wrapper will be added to any user interceptor, why not do it transitively. Can save one step for users. Same apply to filter." }, { "prediction": "I think this should be `etcdDBDir(e.config) + \"-old-\" + strconv.Itoa(int(time.Now().Unix()));` or `etcdDBDir(e.config) + \"-old-\" + strconv.Itoa(int(time.Now().Unix()));`", "reference": "Is there anything we should do in the event we're unable to renaming the directory?" }, { "prediction": "I think this should be `go.uber.org/zap` instead of `go.uber.org/zap`.", "reference": "How is this env var populated? Can this be retrieved from cluster metadata?" }, { "prediction": "I think this should be `FailedTagInternetGateway` instead of `FailedTagInternetGateway`", "reference": "Should probably skip the success event here, since it could be a noop." }, { "prediction": "I think this should be `imageBlurHashes` instead of `imageBlurHashes`.", "reference": "I added this here because people cards (which depends on cardBuilder) had this added in blurhash. Not sure when this is used though cc @JustAMan" }, { "prediction": "Why is this removed?", "reference": "Let's keep this line in the docstring, to let end users know they shouldn't be using this directly." }, { "prediction": "Why not just return `act.AbstractAction.SelfCheck()`?", "reference": "can do the same for other validateXXX()" }, { "prediction": "I think this should be `const_cast(participant_)`", "reference": "Why is this necessary?" }, { "prediction": "I think this should be `from datetime import datetime`", "reference": "Please move this import upper to other similar imports" }, { "prediction": "I think this should be `IF_ARM(ASSERT_NOT_TESTED);`", "reference": "Include the key word \"translated\". Otherwise the reader will find this confusing." }, { "prediction": "I think this should be `@SuppressWarnings(\"unused\")` instead of `@SuppressWarnings(\"unused\")`.", "reference": "why. is this called per request? if so this also adds a lock internally. can we not add this at the moment until analyzed as this assumption isnt carried to the several other impls. the only other consumer of this is the http api and that isnt hit often enough for specializations." }, { "prediction": "Why is this change needed?", "reference": "I believe this means dependent checks can no longer operate on virtual nodes, which is something we've been pushing for lately. We may need to find a different way to solve this issue, as I don't think we want to cause a regression while fixing a bug." }, { "prediction": "I think this should be `os.path.abspath(__file__)` instead of `os.path.dirname(__file__)`", "reference": "ditto about use of `abspath`" }, { "prediction": "I think this should be `Stream.map(PrimeNumbers::factorization) -> Stream.map(PrimeNumbers::factorization) -> Stream.map(PrimeNumbers::factorization) -> Stream.map(PrimeNumbers::factorization) -> Stream.map(PrimeNumbers::factorization) -> Stream.map(PrimeNumbers::factorization) -> Stream.map(PrimeNumbers::factorization) -> Stream.map(PrimeNumbers::factorization, Math::max);", "reference": "this reduces the runtime by 50 times" }, { "prediction": "I think this should be `RemoteDistributorTest`", "reference": "Probably best not to have an empty test...." }, { "prediction": "Why is this change needed?", "reference": "direct `newInstance` call is also deprecated now" }, { "prediction": "I think we should remove the `netlink` package from the list.", "reference": "We have a bit of a convention where imports are split into three blocks: first Go standard library, then imports from outside the repo, then imports from inside the repo." }, { "prediction": "Why is this protected?", "reference": "Why was this change needed?" }, { "prediction": "I think this should be `warning(\"No IPv4 address found on %s !\" % ifname)`.", "reference": "can you use this opportunity to remove `.readlines()` useless list creation? (`addresses = [l for l in fd if l.find(\"netmask\") >= 0]`)" }, { "prediction": "Align the elements of a hash literal if they span more than one line.
Space inside } missing.", "reference": "Why does this check differ from `plan_ssh.rb`?" }, { "prediction": "I think this import should be moved to `go-fsm`", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "Why is this removed?", "reference": "It was @lodejard who initially suggested this pattern. I think that it had something to do about prioritizing future writes even if there was a pending write operation ready to handle the newly requested write. I'm not sure I fully understood the explanation for having up to 3 pending write requests, because only having one queued write at a time still makes sense to me. I'll talk to him about it." }, { "prediction": "(style) line over 80 characters", "reference": "We have cli --online_weight_clear in cli.cpp" }, { "prediction": "I think this should be `strings.Split(values[0], \",\")` instead of `strings.Split(values[0], \",\")`", "reference": "So the request.Headers is a map of []string. Are you sure that the HTTP library doesn't already do this split for us?" }, { "prediction": "I think this should be `EXECUTION_STOPPED`", "reference": "How is this message used? Can we remove the \"crashed executor/container\" part which is an implementation detail?" }, { "prediction": "I think this should be `GET_HEAP_SNAPSHOT` instead of `HEAP_SNAPSHOT`", "reference": "Instead of building in routing for a browser-specific command, could you refactor the HttpCommandExecutor to allow arbitrary commands to be registered?" }, { "prediction": "I don't think we need the `

Watch or Download Video

", "reference": "Space after `=`." }, { "prediction": "I think this should be `setAfterCreateInvocationHandler(invocation -> context.put(RestConst.REST_INVOCATION_CONTEXT, invocation));`", "reference": "if just need to do something after createInvocation just override and call super first is enough?" }, { "prediction": "Line is too long. [98/80]", "reference": "By the way, I fixed `announce` method (missing `super` call to announce JDK version)" }, { "prediction": "I think this should be `@SuppressWarnings(\"unchecked\")` instead of `@SuppressWarnings(\"unchecked\")`.", "reference": "I'm not sure about that... This line can produce ClassCastException if Comparator do not check this." }, { "prediction": "Why is this change needed?", "reference": "There wasn't any special reason for this to return a pointer, right?" }, { "prediction": "I think this should be `ConcurrentHashMap`.", "reference": "Why the need for a `ConcurrentHashMap`?" }, { "prediction": "I think this should be `if (order.by == 'title' && Setting.value('titleNaturalSort')) {`", "reference": "New code should use strict equality `===`" }, { "prediction": "Line is too long. [82/80]", "reference": "`expect(resources['Notify[local pid]']['events'][0]['desired_value']).to match(/(\\d+)/)` seems clearer." }, { "prediction": "Why is this change md flag needed?", "reference": "Removed now-unneeded param." }, { "prediction": "I think this should be `bitswap` instead of `bitswap`", "reference": "(NON-blocking, this can be tracked in follow up issue) @anorth @mishmosh is the toplevel getting too crowded? Should we have a `network` grandparent command, or maybe a `stats` command?" }, { "prediction": "I don't think we need to add the `service` label here, but I think it's a good idea to add the `service` label to the `headerCtaLabel` and `footerCtaLabel` to the `mdc-layout-grid` as well.", "reference": "The `_x` function needs to be imported at the top of the file (in addition to `__`)" }, { "prediction": "Why is this needed?", "reference": "This is functionally equivalent to the code it replaces." }, { "prediction": "I think this should be `json:\"eniType\"`", "reference": "can you change the field name here to \"InterfaceAssociationProtocol\"? same for the Config struct in agent/ecscni/types.go. i think it's better to keep the field name consistent between agent and acs payload" }, { "prediction": "I think this should be `widgets` instead of `core/widgets`.", "reference": "See above, same for the other cases." }, { "prediction": "I think this should be `@since 4.2`", "reference": "Shouldn't line 313 be public \\ SettableGauge\\ **settable**Gauge(String name) { ? It would also be good to call it a few times and with differnet types (Long, Integer, String) in the test as well." }, { "prediction": "Why is this removed?", "reference": "I would prefer to just fix the occurences of this new check rather than disable them" }, { "prediction": "I don't think we need to use `feedDataHosted` here.", "reference": "The tests should be fixed in #4841, so this is no longer needed" }, { "prediction": "Why is this needed?", "reference": "I think it should been in `SharedKernel` module." }, { "prediction": "I don't think we need to add the `omitempty` here.", "reference": "Can we add some description for this field? " }, { "prediction": "I think this should be `DurationType` instead of `TimeType`.", "reference": "Should its name be Time or Duration? I can see them both." }, { "prediction": "I think this should be a `slice` instead of a `slice`", "reference": "Is this used anywhere?" }, { "prediction": "I think this should be `require.Equal(t, []attribute.KeyValue(nil), res.Attributes())`", "reference": "I believe that you can use `assert` instead of `require` here and in the following lines" }, { "prediction": "Why is this change needed?", "reference": "In `storagemarket.go` you used `nil` for an unwanted out parameter. Do something consistent (nil seems fine if supported)." }, { "prediction": "I think this should be `hashBytes` and `padBytesLeft`", "reference": "is this a new pattern we use in bee? interesting" }, { "prediction": "I think this should be `err.Code == \"BucketAlreadyOwnedByYou\"`.", "reference": "If you think this PR works, i'll clean this up before resubmitting." }, { "prediction": "I think this should be `org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.chassis.org.org.org.chassis.org.org.org.org.chassis.org.org.org.chassis.org.org.org.org.chassis.org.org.org.org.org.org.chassis.org.org.org.org.org.org.org.org.org.org.org.org.", "reference": "are you sure you can read version by this artifactid?" }, { "prediction": "I think this should be `java.util.Objects`", "reference": "We can get rid of this import then." }, { "prediction": "Why is this change needed?", "reference": "Should we do our own vtable?" }, { "prediction": "I think this should be `self.routes` instead of `self.routes`", "reference": "This is the actual fix." }, { "prediction": "I think this should be `60 * time.Second`", "reference": "If sync has really a negative impact, this is just moving the issue from 10sec to 60sec. Wonder if you should not expose the (auto)sync params so users can decide." }, { "prediction": "I think this should be `DecodeMap(func(string, Decoder, bool)) bool` instead of `DecodeMap(func(string, Decoder, bool)) bool`", "reference": "should be called => will be called" }, { "prediction": "Why is this change needed?", "reference": "not sure whether we should do this. It may cause problem that delegates upgrade their nodes at different time, that they will have different \"last block time\", some use \"commit time\", some use \"block time\". Potential solution: Only use block time after berling, and then delete it in the next version after berling. Open to discussion." }, { "prediction": "I don't think we need to wrap the exception in a try/catch block. I think we should be able to wrap the exception in a try/catch block.", "reference": "So one question I have is why is the error coming back from `buildReplicaPositions` not an `Assign.AssignmentException`? Is it because it is wrapped in a `SolrException` from the remote node?" }, { "prediction": "I think this test should be moved to `datatable.rbind(4)`", "reference": "`dt` won't work for some reason?" }, { "prediction": "Why is this change needed?", "reference": "Is this because \"KOALAS_USAGE_LOGGER\" can be `None` ??" }, { "prediction": "I think this should be `SoftTxLimitFromABlock` instead of `SoftTxLimitFromABlock`.", "reference": "I like it but maybe the better name will be EthGasPriceConstants or EthGasPriceEstimatorConstants? but Constants not Config" }, { "prediction": "Why is this needed?", "reference": "I would inline the constructor as well" }, { "prediction": "Why is this change needed?", "reference": "I'm not confident about this..." }, { "prediction": "I think this should be `certificateRequestGvk` instead of `certificateRequestGvk`", "reference": "There is also `v1alpha1.CertificateRequestKind` I think?" }, { "prediction": "I think this should be `sender_gcpbroker`", "reference": "Can we rename it to make it less confusing? Instead of \"sender-gcpbroker\", maybe name it to \"retryable-sender\"" }, { "prediction": "I think this should be `String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(literal.value())))), literal().value().getClass().getName()));`", "reference": "So looking at the definition of the `literal()` function in this class, it seems it's possible for it to return null. I guess it's not a concern as we would get NPE on the above call at line 136 when trying to call `.to` if `literal()` returned `null` before even getting to this part that calls `literal().value()`, but something I thought I'd bring up. Perhaps something we might follow up on in another issue or possibly I just missed the workflow that makes `literal()`'s result non-null by the time this `bindLiteralOperration` is called." }, { "prediction": "I think this test should be `assertTrue(abs(nrmse.getMetric()[\"value\"]-target) < OPFMetricsTest.DELTA)`", "reference": "Why did you break the line? It looks like it is under 80 characters without the break and it is inside parens so no need for backslash anyway" }, { "prediction": "I think this is a good idea to have a `DataTable` class, but I don't think it's a good idea to have a `Dummy` class. I think it's a good idea to have a `Dummy` class, but I don't think it's a good idea to add a `Dummy` class to the `DataTable` class.", "reference": "@guolinke Don't you mind to rename this variable to `DATATABLE_INSTALLED`, for the consistency with other variables (for example, there are `PANDAS_INSTALLED` but not `PD_INSTALLED`). Also, `DT` is a little bit confusing: sometimes `dt` is used for `datetime`." }, { "prediction": "Align the parameters of a method call if they span more than one line.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Space inside } missing.", "reference": "We're fine with double quotes here. Just for future reference." }, { "prediction": "Why is this removed?", "reference": "can we keep this around? We should make sure we can distinguish between properly wrapped errors and \"unwrapped\" errors" }, { "prediction": "I think this should be `if (graphicsPipelineCI.pInputAssemblyState) {` instead of `if (graphicsPipelineCI.pInputAssemblyState) {`", "reference": "`RecordPipelineShaderStage()` might change `topology_at_rasterizer `, according to shader code, so we should check `pInputAssemblyState `first." }, { "prediction": "I think this should be `assets.js` instead of `assets.js`.", "reference": "Should we just inline the assets here? I can't think of an advantage to having them in a separate file." }, { "prediction": "Why is this change needed?", "reference": "detectStaleEndpoints to be more specific?" }, { "prediction": "I think this test should be done in C++ too.", "reference": "Please create a new issue for addressing this (if there isn't one already), so it doesn't get lost." }, { "prediction": "Why is this change needed?", "reference": "Nothing was ever coming out of this channel because its already being consumed. Create a new channel here and feed it in HandleNewHead method." }, { "prediction": "I think this should be `GetPolicy.java demonstrates how to get the details for an AWS Identity and Access Management (AWS IAM) policy`.", "reference": "AWS Identity and Access Management (IAM)" }, { "prediction": "I think this should be `LOG.info(\"edgedriver will log to \" + logFile);`", "reference": "This is deliberately at this level." }, { "prediction": "I think this should be `err := output.NewError(output.ConvertError, \"failed to decode data\", err)`.", "reference": "payload entered on command line is in hex-encoded format should use same processing as in ioctl/cmd/action/actiontransfer.go" }, { "prediction": "Why do you need this?", "reference": "should this be kept in the `else` branch?" }, { "prediction": "Why is this needed?", "reference": "Why not put this below \"strings\"?" }, { "prediction": "I think this should be `private int _dispatchPipes.Count;` instead of `private int _dispatchPipes.Count;`", "reference": "Make it `internal` if it's just for testing." }, { "prediction": "I think this should be `logical-tautology`", "reference": "What is triggering this message in this file?" }, { "prediction": "Why is this change needed?", "reference": "Are you sure this should be removed?" }, { "prediction": "Why is this change needed?", "reference": "What's that good for? The field is initialized in the constructor." }, { "prediction": "Why do we need this?", "reference": "This shouldn't be necessary (same below). Do you have a traceback for me?" }, { "prediction": "I think this should be `github.com/opencontainers/runc/libcontainer/logs` instead of `github.com/opencontainers/runc/libcontainer/logs`", "reference": "No newline needed here." }, { "prediction": "I think this should be `github.com/keybase/client/go/logger`", "reference": "Why a separate block?" }, { "prediction": "I don't think this is necessary, but I think it should be `DR_REG_CNTVCT_EL0` or `DR_REG_FPSR`", "reference": "Probably better to ask @AssadHashmi or another AArch64 expert for a review rather than me -- @AssadHashmi if you could confirm that these status registers are 64-bit despite having only a few fields?" }, { "prediction": "I think this should be `bip` instead of `bip44_derivation(account_id, segwit=False)`", "reference": "`purpose` and `coin_type` and `account` would mimic the BIP-0044 wording, but it's up to you." }, { "prediction": "I think this should be `rbQValue01.Checked = false;`", "reference": "Is this the critical change? It does seem wrong to use Select() instead of Checked = true. Not sure why that would pass sometimes and not others, though." }, { "prediction": "I think this should be `numCoresPerSocket`?", "reference": "Seems a little low, but is this an installer default?" }, { "prediction": "I don't think we need this function anymore.", "reference": "Maybe we could provide our own `configure` function that includes `logger._logger = None` because I don't see a use case in kinto for using `reset_logger` besides configuring the logger." }, { "prediction": "Why is this removed?", "reference": "This will cause the same breakage that was caused when we added Proof to Block. Be sure to let people (infra?) know ahead of time" }, { "prediction": "I think this should be `require.Len(t, ncs.nodes, 1)`", "reference": "Fixed the test; @strib want to validate that this is okay? Seems to be consistent new GC behavior." }, { "prediction": "Why is this change needed?", "reference": "Afaict, nothing cares" }, { "prediction": "I think this should be `KBFS-2026`.", "reference": "I must be missing something, but why does not having a node cache imply not neededing to re-embed the block changes, in particular? Isn't it just the fact that we don't do any writes?" }, { "prediction": "I think this should be `readonly` instead of `internal`", "reference": "Are these changes from `class` to `struct` breaking if called from an older version of `Datadog.Trace.ClrProfiler.Managed`?" }, { "prediction": "I think this should be `org.hyperledger.besu.ethereum.core.LogsBloomFilter`", "reference": "These are just aliases now" }, { "prediction": "I think this should be `@video.title.html_safe` instead of `@video.title.html_safe`", "reference": "Does this mean we can remove `raw` from `_head_contents` partial?" }, { "prediction": "I think this should be `if (this.splashWindow && !this.splashWindow.isDestroyed)`", "reference": "`isDestroyed` is a function, not a property. This condition will always return false." }, { "prediction": "I think this should be `1.30` and `1.31`", "reference": "Why are we adding these versions?" }, { "prediction": "I think this should be `len(listens)` instead of `len(listens)`.", "reference": "fyi, you can do this by doing `.info(\"string %s %s\", formatparam, formatparam2)` instead of doing a string format with `\"str\" % (params)` the idea is that it'll only do the string interpolation if logging is enabled for this level, which theoretically is an optimisation, but in this case probably isn't important" }, { "prediction": "I don't think we need a `window.location.reload` function anymore.", "reference": "Would this work, as a one liner? `setTimeout(window.location.reload, 5000);`" }, { "prediction": "I think this should be `utils/tls`", "reference": "Can you move `crypto/tls` into the block at the top with all the other stdlib imports?" }, { "prediction": "I think this should be `anomalyScore` instead of `multiStepBestPredictions`.", "reference": "What is the motivation for this change?" }, { "prediction": "I don't think we should retry if there is a transient failure. I think we should retry if there is a transient failure.", "reference": "OK, so the concrete implementation will loop? But then it's important that this method waits for a while before it returns no messages. To be specific, a GCP implementation that set `ReturnImmediately` to true or false would both satisfy this requirement, but the first would cause busy-waiting." }, { "prediction": "I think this should be `matchClause->path()->pathSize() > 1` instead of `matchClause->path()->path(0)`", "reference": "The data structure of `MatchClauseContext` may need to be redesigned." }, { "prediction": "I think this should be `n := len(want) - len(got) - len(want) - len(got) - len(want) - len(got) - len(got) - len(got) - len(want) - len(got) - len(got) - len(got) - len(got) - len(got) - len(got) - len(got) - len(got) - len(got) - len(got)", "reference": "You say on the issue that something has to be receiving while the messages are being published. But here it's possible that the publish goroutine starts, and maybe even completes, before Receive is ever called." }, { "prediction": "Metrics/LineLength: Line is too long. [98/80]", "reference": "how do we know that the step in question is an approval type step?" }, { "prediction": "I don't think this is needed.", "reference": "JMX offers normal APIs for this. I don't think you want the glassfish one." }, { "prediction": "I think this should be `exports io.vavr.collection.concurrent; exports io.vavr.control.concurrent; exports io.vavr.concurrent.collection; exports io.vavr.concurrent.collection; exports io.vavr.concurrent; exports io.vavr.concurrent; exports io.vavr.concurrent; exports io.vavr.concurrent; exports io.vavr.concurrent; exports io.vavr.concurrent; exports io.vavr.collection.concurrent; exports io.vavr.concurrent; exports io.vavr.concurrent.collection; exports io.vavr.concurrent.collection; exports io.vavr.concurrent; exports io.vavr.concurrent; exports io.vavr.concurrent; exports io.vavr.concurrent; exports io.vavr.concurrent; exports io.vavr.concurrent;", "reference": "Is this still Java 8 compatible? @danieldietrich do we need a separate, modularized Java 9 release also?" }, { "prediction": "I think this should be `if(hipResourceTypeLinear == pResDesc->resType && !pTexDesc->normalizedCoords) {`", "reference": "Should update the user input address and filter modes and pass those in fillSamplerDescriptor ?" }, { "prediction": "I don't think we need this, but I think it's a good idea to have a `show.adult_musical` and `show.kids_musical` method, but I think it would be better to have a `show.kids_musical` method.", "reference": "This object should be in `lib/music/show.rb` and you should also wrap this object in the `Faker::Music::Show`." }, { "prediction": "I think this should be `use_args['_noop'] = true` instead of `use_args['_noop'] = true`", "reference": "I think logic will have to move to bolt since the vague discussions around bolt run plan --noop is that it would just skip any tasks that don't support_noop rather than error. This is fine until we actually elaborate that though." }, { "prediction": "Why is this needed?", "reference": "File is not `goimports`-ed" }, { "prediction": "I think this test should be `test_collections_are_isolated_by_bucket` instead of `test_unknown_bucket_raises_403`.", "reference": "why should unknown raise a 403?" }, { "prediction": "I think this should be `s = c._nextState || c.state;`", "reference": "The true clause of your condition, can't this just be c._nextState since `assign({}, c._nextState)` is equal to returning c._nextState, or am I misunderstanding something here?" }, { "prediction": "Shouldn't this be `max_admin_api_calls_per_day` or `max_results_admin_api`?", "reference": "nit: align the leftmost quotes" }, { "prediction": "I think this should be `10351`.", "reference": "Probably \"server port\" -> \"TCP port\"" }, { "prediction": "Why is this change needed?", "reference": "can you use FilterCodec instead?" }, { "prediction": "I think this should be `A4` instead of `Letter`.", "reference": "I know there's only two values but I find it a bit confusing that it's true/false. Could you change it to a string enum with values \"portrait\" and \"landscape\"? Then when calling printToPdf you can just do `landscape: Setting.value('export.pdfPageOrientation') === 'landscape'`" }, { "prediction": "I think this should be `db_schema_version`", "reference": "I think this migration should fail for MDBX if it uses old table names" }, { "prediction": "Line is too long. [98/80]", "reference": "Should this be negated? `!@options[:hosts_file].nil?` Otherwise it'll enter the `if` statement and `nil` will be passed to `HostsFileParser.parse_hosts_file`, which I'm assuming is bad." }, { "prediction": "I don't think we need this method.", "reference": "I'm doubting if adding a bool here is a good idea. Maybe it should be an option object? Otherwise it's hard to extend. But an option object is a bit strange in a fluent API? What do you think @snakefoot ?" }, { "prediction": "Why is this public?", "reference": "This is used in o.a.l.sandbox.search.PhraseWildcardQuery." }, { "prediction": "I think this should be `protocol.Dock` instead of `protocol.Dock`.", "reference": "view should be loaded on start for both statedb and factory" }, { "prediction": "I think this should be `_readInputContinuationTask`.", "reference": "Why rename? Just curious..." }, { "prediction": "I think this should be `View.VISIBLE` instead of `View.GONE`.", "reference": "Is this needed? I think it calls the super function that already does that." }, { "prediction": "Why do you need this?", "reference": "This might slow down the inference time, are we sure we need to do that?" }, { "prediction": "I think this is a good idea to add a blank line to the top of the file.", "reference": "This would read better if you add \"Skip code/lines\" or (exclude/hide code if you follow my earlier suggestion\")" }, { "prediction": "I don't think this is needed.", "reference": "Looks like glassfish went a bit nuts doing a refactor" }, { "prediction": "I think this should be `Task.WhenAll(tasks).Add(processor.ForceFlushAsync(cancellationToken));` instead of `Task.WhenAll(tasks).Add(processor.ForceFlushAsync(cancellationToken));`", "reference": "nit: allocate the list using the number of processors." }, { "prediction": "I think this should be `javaClasses` instead of `initializedClasses`.", "reference": "Was this change triggered by baseline?" }, { "prediction": "Metrics/LineLength: Line is too long. [101/120]", "reference": "This code was doing nothing as far as I can tell and was making the SQL find nothing with the new version of Rails. Remove it unless someone can explain why it is there." }, { "prediction": "Why is this needed?", "reference": "Setting browser based login as the default for `RestAPIExplorer`." }, { "prediction": "why do you need this?", "reference": "maybe we can do this in Init function?" }, { "prediction": "I think this should be `if len(request.GetRequestId()) > wh.config.MaxIDLengthLimit() { return nil, errRequestIDTooLong}`", "reference": "How about if request ID not set, service should generate a random uuid?" }, { "prediction": "Why is this change needed?", "reference": "minor: this is an opportunity for you to split these long lines into multiple lines :)" }, { "prediction": "Why is this needed?", "reference": "It would be nice to have exception dumped somewhere (debug logs, info logs)." }, { "prediction": "I think this should be `MessageAs` instead of `MessageAs`.", "reference": "So I don't think this is right, as discussed on #657." }, { "prediction": "I think this should be `GROUP_USERS` instead of `GROUP_MEMBERS`.", "reference": "should the group_id = \"{0}\" be group_id = %s You'd still keep the {} for the group_members_{} for the tablename but make the filter clause parameterized." }, { "prediction": "I don't think we need to check if the path starts with `$` or not.", "reference": "Path can contain variable pattern in the middle. Also, `$` is not enough to tell if this is JMeter variable. We have correct variable detecting somewhere in our code." }, { "prediction": "I think this should be `staticMethodOptions` instead of `staticMethodOptions`", "reference": "@bennothommo can you revert this section? It shouldn't be required." }, { "prediction": "I think we should use `self.created_at.year` instead of `self.created_at.month`.", "reference": "Minor: maybe move the above to a `#fiscal_year` method?" }, { "prediction": "I think this should be `assert not os.path.exists(buildfilepath)`", "reference": "You should use the current directory instead - it's a temporary directory that will get removed when the test is done." }, { "prediction": "Why is this needed?", "reference": "I think we don't need synchronization here." }, { "prediction": "I don't think we need to add `session` to the message as well.", "reference": "I don't think this should be changed since on the reactive side we don't support anonymous users." }, { "prediction": "I don't think we need this change.", "reference": "Maybe this `if` should be on line 118?" }, { "prediction": "I think this should be `int64` instead of `int64`.", "reference": "Cool. (I thought I had fixed this already in #812.)" }, { "prediction": "I don't think we need this, but I think it's a good idea to use `interpreters` instead of `interpreters`.", "reference": "I intend to do this as soon as I have tests passing." }, { "prediction": "I think this should be `os.environ['QUTE_FIFO'] = os.environ['QUTE_FIFO'] or os.environ['QUTE_FIFO'] = os.environ['QUTE_FIFO'] or os.environ['QUTE_FIFO'] = os.environ['QUTE_FIFO'] or os.environ['QUTE_FIFO'] = os.environ['QUTE_FIFO'] or os.environ['", "reference": "Please remove the `test_*` from the filename - otherwise pytest will try to collect tests from it." }, { "prediction": "I think this should be `explicit_find_gpus(session, ret_len, ret, \"/dev/drm/0\");`", "reference": "Did you file a bug to follow up on this?" }, { "prediction": "I don't think we need to do this, but I think it's a good idea to have a `read.parquet.vectorization.enabled` property.", "reference": "Looks like these 4 lines didn't actually change. Can you revert the whitespace changes here?" }, { "prediction": "I think this should be `require 'pathname'` instead of `require 'path'`.", "reference": "This can't be merged with any usage of `require 'pathname'` in lib, it's not always available and we don't want false positives for people (where they don't realise they needed to requite it). Its also unnecessary, no other formatter uses it to look up failure locations. See the exception presenter etc for how we format lines." }, { "prediction": "I think this should be `UtilIT.publishDataverseViaNativeApi(datasetId, dataverseAlias, apiToken)`", "reference": "It would be nice to fix the indentation above." }, { "prediction": "I think this should be `array|false` instead of `resource`", "reference": "`short_names` is still optional, so `=` that indicates it has to stay there." }, { "prediction": "I think this should be `EFS` instead of `FirelensFluentbit`?", "reference": "missing calling of this method" }, { "prediction": "I think this should be `service/cloudformation`", "reference": "We could get rid of this dependency being forced on clients by changing the `StackConfiguration` interface abstraction to deal with strings instead of `cloudformation.Parameters` and `cloudformation.Tags`, and internally to the `cloudformation` package translate the input strings into the `service/cloudformation` package specific values hiding that from consumers. I don't think that should be taken on as part of this PR, but I think we should consider doing it at some point." }, { "prediction": "I think this should be `+kubebuilder:object:root=true`", "reference": "`StressChaos` does not contains a field .spec.action" }, { "prediction": "I think this should be `a([\"a\" => b(\"hello\")]);`", "reference": "Non-int literal strings are no longer coercible to int, I think this is an improvement. Without this change it now reports `InvalidArgument`." }, { "prediction": "I think this should be `sizeof(a) / sizeof(a[0])`", "reference": "I this used anyplace?" }, { "prediction": "Why is this needed?", "reference": "Why was this change required?" }, { "prediction": "I think this is a bit confusing, but I think it would be better to use `missingAdminRole` instead of `missingAdminRole`.", "reference": "I like that we have this attribute here. However, I think the way we use it right now might be confusing in the future. For example, when only camunda admin is checked, this exception will be instantiated with a message and `missingAdminRole` is `false`. I think that is counter-intuitive. I would expect this exception to have `missingAdminRole` set to `true`. With this explicit information, the exception message could now be generated inside this exception class with the text block that is currently used in the authorization manager. We could maybe generally reuse that text block then also for the case where a user is no admin and also has none of the required permissions. I haven't tried it myself but I think it would be great if we could streamline those things a bit more if we're working on it now. Let me know what you think. " }, { "prediction": "Why not use `getSizePrefixedRootAsMonster` instead of `getSizePrefixedRootAsMonster`?", "reference": "Not sure why we're creating a new `ByteBuffer` here, ideally this refers to the existing one?" }, { "prediction": "I think this should be `DATE_RANGE_OFFSET` instead of `DATE_RANGE_OFFSET`", "reference": "Same here re: `STORE_NAME` to `MODULES_SEARCH_CONSOLE`." }, { "prediction": "I think this should be `UA-00000001-1` instead of `UA-999-9`.", "reference": "I could've sworn I got a `403` myself when I got that response locally. Is `200` what the API would send back for a `permission: false` tag?" }, { "prediction": "Why is this change needed?", "reference": "This attribute was intentionally private. - lets force usage of factory `NewIdentityManager()` - lets ramake to `NewIdentityManager(keydir string)` -> `NewIdentityManager(keystore keystoreManager)`" }, { "prediction": "I don't think we need this. I think it's better to use `time.Millisecond` instead of `10 * time.Millisecond`.", "reference": "Is this too frequent?" }, { "prediction": "I think this should be `zip` instead of `csv`.", "reference": "will this not make it possible to use a zip file, e.g. on other importers who do not have to support it ?" }, { "prediction": "I don't think we need to import the `SocksClientLayer` class anymore.", "reference": "Needs to be mentioned in `__all__` below." }, { "prediction": "I don't think we need this function anymore, but I think it should be called `is_repeat_handle_pre_extended_syscall_sigmasks`.", "reference": "What if the app's signal handler, executed at pre-syscall for epoll_pwait, executes its own epoll_pwait? For that matter: what happens natively if that happens? I would not expect the kernel to keep a stack -- does that clobber the kernel's stored pre-syscall mask?" }, { "prediction": "I think this should be `List` instead of `List`", "reference": "Nit: missing a space. I think we should phrase the new content a little differently. \"It is important\" isn't very clear. I think it should be \"offsets will be returned in sorted order.\"" }, { "prediction": "I think this should be `encoding/json`", "reference": "Can you remove this blank line and put the added import in sorted order (likely your editor will do this)" }, { "prediction": "I don't think we need this line.", "reference": "Even if `pthread_create()` for `ocsp_updater_thread()` fails, `h2o` can continue to serve. But I'm a little worried whether `h2o` should continue to serve in this case. How about you?" }, { "prediction": "I think this should be `account_create` and `account_choose`", "reference": "I like introduction of these constants for account/container creation, but the `ACCOUNT_CHOOSE` one isn't needed I think. This should instead be an \"empty\" value (either `''` or `0`), to indicate more clearly that this field is not filled. It should be the same for choosing a container." }, { "prediction": "I think this should be `string.compare(str1, str2, undefined, {sensitivity: 'base', numeric: true });`", "reference": "I noticed that passing in `[]` for the locales argument instead of 'undefined' seems to have the same effect. I think that's preferred over passing in `undefined` as a value, and unfortunately passing in `null` seems to throw an error." }, { "prediction": "I think this should be `if strings.Contains(DbCfg.Host, \":\") && !strings.HasSuffix(DbCfg.Host, \"]\")`", "reference": "1. `0` is redundant. 2. We should save result of `strings.LastIndex(DbCfg.Host, \":\")` to a variable and reuse." }, { "prediction": "I think this should be `NoHeaderSupport` instead of `NoHeaderSupport`.", "reference": "Do you envision \"new\" servers not supporting header, or is it more a way to test mix of old and new? If so, we could make it a \"private\" (non exported) option." }, { "prediction": "I think this should be `errors.Wrap(err, \"failed to unmarshal connection config\")`.", "reference": "For future reference. Try not to do refactoring in the same PR which solves some bug or implements some feature. Not to clutter reading. Do it in separate PR." }, { "prediction": "I think this should be `asset` or `unit`?", "reference": "I'm not sure about changing the flag name. unit is more accurate, but for I think for most people asset is also a fine name to use." }, { "prediction": "I think this should be `if showWindow.Find() == nil {`", "reference": "Which windows gets activated? A random other window?" }, { "prediction": "I think this should be `if event.SpecVersion() != cloudevents.VersionV03 {`", "reference": "Just to make sure, this is totally lossless? If I put a v2 there, then it gets upgraded to v3, but my function expects v2, then this is fine and nothing is lost?" }, { "prediction": "I think this should be `write.watermark.field` or `write.watermark.value`", "reference": "In the past, we have 3 Flink streaming jobs (1 for each AWS region) writing to the same table. We need to write to 3 different watermark table properties (1 for each region). Watermark consumer then use the min value to determine the overall table watermark. A provider pattern similar to `WRITE_LOCATION_PROVIDER_IMPL` can work. A default impl could be a single property name. not sure if there is a simpler way to achieve this." }, { "prediction": "I think this should be `unsortedResolvedReaders`?", "reference": "Can you change this to `ResolvedUsersMap` and build a new map with both readers/writers? That way, we get the nice side effect of not exposing the internal map of the handle, and simplifying the callers a bit." }, { "prediction": "I think this should be `mongoClient.s.options.cryptdConnectionString`", "reference": "I typically try to avoid nested ternary expressions. Can we rewrite this as if statements? Worst case, can we break it out into its own function?" }, { "prediction": "Why is this necessary? I think it's better to do `tls_start.ssl_conn.set_tlsext_host_name(tls_start.context.client.sni.encode())`", "reference": "Do we still support handshakes without SNI present?" }, { "prediction": "I think this should be `logger.warn` instead of `logger.warn`", "reference": "Maybe it's because I work too much on a centralized logging system but it could be great to add a \"category\" like \"attribute\", \"substitution\", \"include directive\", \"macro\", \"extension\"..." }, { "prediction": "I think this should be `(it have no sense in python)`", "reference": "it have no sense in python -> it makes no sense in python" }, { "prediction": "I think this should be `openvpnPort` or something like `openvpnPort`", "reference": "maybe just do a separate implementation of the pool for openvpn case? It's a bit confusing having two methods here." }, { "prediction": "Why do we need to close `topology` here?", "reference": "how is it possible to have a `topology` that is falsey when we had to call `topology.connect` in order to get here?" }, { "prediction": "I think this should be `expect(PlanFinder).to have_received(:where).to_not_have_received(:where).to_not_have_received(:where).to_not_have_received(:where).to_not_have_received(:where).to_not_have_received(:where).to_not_have_received(:where).to_not_have_received(:where).to eq 10", "reference": "Do we need this expectation? If we don't call this method on `PlanFinder` there's no way for the `10` to be returned. Seems somewhat redundant. What do you think?" }, { "prediction": "Why is this removed?", "reference": "We need to do the same for edgecore" }, { "prediction": "Is there a reason we don't need the `AutoResetEvent` here?", "reference": "This fix has nothing to do with the product change. Just a fix I am making for the test issue." }, { "prediction": "Why is this TODO removed?", "reference": "Don't know what should be the default. Lets keep BatchingProcessor for now. And revisit the area after beta." }, { "prediction": "I think this should be `RSpec::Support.require_rspec_support` instead of `RSpec::Support.require_rspec_support`", "reference": "Ah that's how it's happening, it's probably using the `require_relative` in the optimised one and that counts as a different require to the bare one." }, { "prediction": "Why is this needed?", "reference": "What happens if there is no NIB/XIB with that name?" }, { "prediction": "Why is this change needed?", "reference": "this is not necessary?" }, { "prediction": "I think this should be `asmauthres` and `asmsecretres`", "reference": "typo: `asmsecrets \"github...`" }, { "prediction": "Why is this change needed?", "reference": "I think that the JSON encoding should be handled by the control itself, not the sanitization function. This should only confirm that the input is correct, not reformat it " }, { "prediction": "I think this should be `Transports`?", "reference": "Should we put a TODO here to route the http.Transport through here?" }, { "prediction": "I think this should be `Get-VMSwitch -ComputerName $(hostname) -Name $(hostname) -AllowManagementOS $false`", "reference": "Sorry, could you explain more about the issue? Doesn't ComputerName already default to local computer? > -ComputerName Specifies one or more Hyper-V hosts on which the virtual switch is to be configured. NetBIOS names, IP addresses, and fully qualified domain names are allowable. The default is the local computer. Use localhost or a dot (.) to specify the local computer explicitly." }, { "prediction": "I think this should be `if allowError {`", "reference": "`allowError` is a big vague. Does this mean the test case is asserting that an error should occur? If it means \"maybe an error can occur, and that's okay\" -- what's an example of this?" }, { "prediction": "I think this should be `return alias.IOAddress(xrc20ContractAddress)`", "reference": "return statements should not be cuddled if block has more than two lines (from `wsl`)" }, { "prediction": "I think this should be `java.lang.reflect.reflectiveObjects.NotImplementedException`.", "reference": "Why does VirtualMachineMetrics have to implement Metric?" }, { "prediction": "Why is this change needed?", "reference": "line is 121 characters" }, { "prediction": "I don't think we need to use `name.slice(0, 2) === 'on'` here.", "reference": "How's that linked esbench looking with slice?" }, { "prediction": "I think this should be `os.path.dirname(path)` instead of `os.path.dirname(path)`", "reference": "The split and join was probably done to ensure that this still works on Windows because os.path.dirname works differently depending on the os you're running under :(. It would probably be a little better to do `dirname, _, fn = path.rpartition('/')` if you want something cleaner than the split/join." }, { "prediction": "I think this should be `-1`.", "reference": "This is not the right approach. The `Distributor` maintains a model of the current state of the Grid. That model already contains the information about every active session. We don't need to modify `SessionMap` to expose it further." }, { "prediction": "I think this should be `time.Time{}` instead of `time.Time{}`", "reference": "Can you make this a member var as all the other deadlines? Then you can drop the param to resetTimer() and simplify some of the code below iiuc." }, { "prediction": "Why not use ROMOL_SPTR instead of ROMOL_SPTR?", "reference": "I don't understand the reason for the changes from unique_ptr to ROMOL_SPTR that you made in this file. The pointers aren't being shared or used elsewhere so I don't think there's any reason to make them shared. Did I miss something?" }, { "prediction": "Why is this change needed?", "reference": "why change the variable name at all?" }, { "prediction": "I think this should be `if (vNode.actualNode === node) { return vNode; }`", "reference": "Since I'm still trying to keep these straight in my head, can you elaborate on what problem this solves?" }, { "prediction": "Shouldn't this be `!mAccount.getReportSpamRecipient().isEmpty() && !mAccount.getReportSpamRecipient().isEmpty() && !mAccount.getReportSpamRecipient().isEmpty() && !mAccount.getReportSpamRecipient().isEmpty() && mAccount.getReportSpamRecipient().isEmpty() && mAccount.getReportSpamRecipient().isEmpty() && mAccount.getReportSpamRecipient().isEmpty() || mAccount.getReportSpamRecipient.isEmpty() || mAccount.getReportSpamRecipient.isEmpty() && !mAccount.getReportSpamRecipient.isEmpty() && !mAccount.getReportSpamRecipient.isEmpty() && !mAccount.getReportSpamRecipient.isEmpty() && mAccount.getReportSpamRecipient.isEmpty() && mAccount.getReportSpamRecipient.isEmpty() && mAccount.getReportSpamRecipient.isEmpty()", "reference": "Prefer TextUtils.isEmpty() which handles getReportSpamRecipient() being null" }, { "prediction": "I think this should be `manifest['application']['gecko']['id']` instead of `manifest['application']['gecko']['id']`", "reference": "Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else." }, { "prediction": "I think this should be `d.GetValueList(\"Include\")`, not `d.GetValueList(\"Exclude\")`.", "reference": "Do we actually use Include anywhere yet or is this just for completion?" }, { "prediction": "I think this should be `Referer` instead of `same-domain`.", "reference": "It still bugs me this was misspelled in the standard and now the wrong spelling is the commonly used one :wink:" }, { "prediction": "I don't think we need the `md-icon` class here, but I think it would be better to use `md-icon` instead of `material-icon`.", "reference": "seems we missed de-uglifying this one" }, { "prediction": "I don't think we need this constant.", "reference": "i guess these types & cron / retry specific belong to a dedicated util / struct" }, { "prediction": "Why do we need a promise here?", "reference": "Also update line 2205 below" }, { "prediction": "I think this should be `horizontal` or `vertical`.", "reference": "`direction` is referenced nowhere. Do I miss something?" }, { "prediction": "I don't think we need this file anymore.", "reference": "The two places this was used have been removed so we can fully remove this dependency." }, { "prediction": "I think we should remove the `agreeInstall.go` from the `agreeInstall.go` file.", "reference": "This is a duplicate generation of the same file as below." }, { "prediction": "I think this should be `if cfg.gpu_ids is not None else cfg.gpu_ids`", "reference": "We may deprecate `gpus` if `gpu_ids` is specified." }, { "prediction": "I think this should be `LOG.info(JSON.toJson(serialized.build()));`", "reference": "Right now this is experimental and deeply flaky. We left this at `info` to make debugging user reports a lot easier." }, { "prediction": "I don't think you need to add a `c.d[85,1,-1]` here.", "reference": "unnecessary spaces here are doubling the size of this otherwise extremely useful addition" }, { "prediction": "I don't think we need the `OverwriteIfNewer` policy here, but I think it would be better to use `DirectoryExistsPolicy.OverwriteIfNewer` instead of `FileExistsPolicy.OverwriteIfNewer`.", "reference": "I think we should use `FileExistsPolicy.Overwrite` instead. Files _should_ always be newer, but in the unlikely case they wouldn't be, I'm afraid some files would be overwritten and other not, leading to inconsistencies that will be hard to figure out." }, { "prediction": "I think this should be `std::cout << \"test3_5\" << std::endl;`", "reference": "this should probably be removed" }, { "prediction": "Why is this change needed?", "reference": "Nit: I would actually prefer that pretty JSON is the default, with a flag for compressed JSON. Can we acheive that easily?" }, { "prediction": "I think this should be `securityGroupOverrides`?", "reference": "Will need to think about this one. `additionalIngressRules` feels a bit opaque in terms of eventual outcome." }, { "prediction": "Why is this change needed?", "reference": "Can we avoid making this public with the other updates?" }, { "prediction": "I think this should be `CHECK_LT(datum_num, num)`", "reference": "Why did you change this equal instead of less or equal?" }, { "prediction": "Why is this change needed?", "reference": "missing final for the blockHash field" }, { "prediction": "Line is too long. [98/80]", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I don't think this is necessary, but I think it's better to use `tf.nn.L2Norm` instead of `tf.nn.L2Norm`", "reference": "`x_float` instead of `float_x`." }, { "prediction": "I don't think we need to import `swiper/swiper-bundle.esm` and `swiper/swiper-bundle.css`", "reference": "Is this for `No Babel config ...` from ESLint? If so, it will be fixed in my ES6 PR." }, { "prediction": "I think this should be `t.Fatal(err)`", "reference": "Not important, but the code used to keep checking other cases even after one of them failed, and now it's not. Fine either way for me, just noticing." }, { "prediction": "I think this should be `docker/api/types/volume`", "reference": "I think I saw this line in last PR, you can update your base branch and rebase to avoid this. And it would be awesome if you can rebase instead of merge each time you push PR to the `moby` branch, that will make the commits history clearer." }, { "prediction": "(style) code indent should use tabs where possible (style) code indent should use tabs where possible", "reference": "If this can change the PC of this thread, it requires handling: we can't blindly execute the syscall and lose control of the thread when the flags include CONTEXT_CONTROL. (Note that most docs imply that setting your own context this way is not supported or has undefined or unpredictable results: any idea how often that's the case, or does it generally work?) We need to handle in a similar fashion to NtContinue or setting another thread's context to ensure we retain control." }, { "prediction": "I don't think we need to use `/` here.", "reference": "@huzaifaiftikhar Changed the endpoint as suggested by Stephane in the latest commit." }, { "prediction": "I think this should be `core.Number` or `core.Number`", "reference": "There's no core.Number yet. ;)" }, { "prediction": "I don't think we need to add the `--volname` and `--snapname` to the command line.", "reference": "..., ...will be posted." }, { "prediction": "I think this should be `header` instead of `block`.", "reference": "Can you update this function to be `ShowHeader`? There is only one use of it at the moment in `tools/fast/series/get_head_block_height.go`." }, { "prediction": "I don't think this is a good idea, but I think it would be better to use `QUILT_USE_TQDM = os.getenv('QUILT_USE_TQDM', '').lower() != 'true'` instead of `QUILT_USE_TQDM`", "reference": "@akarve, this disables `tqdm` by default, is it intended? Also name `QUILT_USE_TQDM` might be too specific, IMHO `QUILT_INTERACTIVE` or `QUILT_PROGRESS_BARS` or something might be better." }, { "prediction": "Why is this change needed?", "reference": "unrelated but just changing for consistency with code below it" }, { "prediction": "I think this is the only place where the component will update. I think it should be `skip = opts !==FORCE_RENDER && component.shouldComponentUpdate(props, state, context);` or `skip = opts !==FORCE_RENDER && component.shouldComponentUpdate(props, state, context);` or `skip = opts !==FORCE_RENDER && component.shouldComponentUpdate(props, state, context);`", "reference": "This will call `componentWillUpdate()` for mounts because the else clause is removed. It should only be called for updates." }, { "prediction": "I think this should be `bucket: ['write', 'read']`", "reference": "We should add write inheritance too." }, { "prediction": "I don't think this is necessary.", "reference": "Please rename this to `LAMBDA_JAVA_OPTS`, and add a short description to the README." }, { "prediction": "I don't think we need this import anymore. I think it should be `github.com/pipe-cd/pipe/pkg/app/api/analysisresultstore` and `github.com/pipe-cd/pipe/pkg/app/api/applicationlivestatestore`", "reference": "Should be in the same import group." }, { "prediction": "I think this should be `pkt.tls_session.tls_version or 0x0303 > 0x0200` instead of `pkt.tls_session.tls_version or 0x0303 > 0x0200`", "reference": "Operator precedence is very confusing here. Care to add parentheses? ` ((version or 0x0303) >= 0x0200)` Same below." }, { "prediction": "Why is this change needed?", "reference": "javaparser-core has no dependencies and it should stay that way. So no log4j. And even then there would have been a preference for slf4j." }, { "prediction": "I think this should be `RETEST` instead of `TABULAR_DATA_FORMATS_RETEST`.", "reference": "Why not just retest all? it's not expensive (I think)." }, { "prediction": "I think this should be `ecr0` instead of `ecr0`", "reference": "ecr and ecr0 aren't deterministically named here. This change will just cause confusion in the git history. Could you either: a) fix this and make it deterministic b) regenerate the mock until it doesn't flip definitions for ecr and ecr0" }, { "prediction": "I think this should be `r-#{r_version}_1_amd64.deb` instead of `r-#{r_version}_1_amd64.deb`", "reference": "This looks like bash... does this work in ruby? Or is the idea to inject the entire script into the subsequent commands?" }, { "prediction": "I think this should be `traceparentCollection.IsEmpty()`?", "reference": "I don't understand why this change is in this PR?" }, { "prediction": "I don't think this is needed anymore.", "reference": "It's a little hard to tell from the diff, but as a result of this PR, the only non-deprecated helpers are: - `has_facet_values?` (probably not long for this world) - `render_facet_partials` (perhaps part of a future component) - `render_facet_limit` (possibly obsolete once components get traction) - `facet_field_in_params` (a little tricky to deprecate at the moment) - `facet_field_presenter`" }, { "prediction": "I think this should be `PersonObject.prototype.__proto__ = Realm.Object.prototype.__proto__;`", "reference": "The right-hand part shouldn't use `__proto__`. Should be just `PersonObject.__proto__ = Realm.Object`." }, { "prediction": "I think this should be `panic(fmt.Sprintf(\"taskManagerImpl encountered MinTaskID >= MaxTaskID: %v vs %v\", request.MinTaskID, request.MaxTaskID, request.MaxTaskID))`", "reference": "the == case might be legit, or not? If there is no task written since last read, but we trigger a new read, would the min == max? Or should the upper layer handle that case?" }, { "prediction": "I think this should be `memcpy(new_p, p, old_size);`", "reference": "Good catch! But is it guaranteed that `old_size < new_size` here? If not, wouldn't we want to take `min(old_size, new_size)` as the copy length?" }, { "prediction": "I think this should be `MemberHidesStaticFromOuterClass` instead of `MemberHidesStaticFromOuterClass`.", "reference": "This is the only one that worries me a bit. It would be good if Brendan signed off on it." }, { "prediction": "I think this should be `isLongRunningReturnValue` or `hasLongRunningReturnValue`", "reference": "`LongRunningOperationDetailView` already has `isEmptyOperation`." }, { "prediction": "I think this should be `base64.b64encode('%s:%s' % (parsed_url.username, parsed_url.password))`", "reference": "This will always add the authorization header to the request object. Is this the right scope for these two lines? If username/password are not defined, it will encode 'Basic :'" }, { "prediction": "Line is too long. [89/80]", "reference": "Don't think a scope adds much value for us here. Also, for future reference, you don't need to use the `self.all` it is implied. Could just be: `scope :updated_at_desc, -> { order(updated_at: :desc) }` No need to change this one now though, it works." }, { "prediction": "I think this should be `return Base.rand(0..9).round if digits == 1`", "reference": "I believe `Base.` is unnecessary in this case, as the class already extends `Base`." }, { "prediction": "I think this should be `width` and `height`", "reference": "Couldn't this result in images being scaled too small when the width is less than the height assuming the width is still what is being passed here?" }, { "prediction": "I think we should use `plugins.getConfig(\"api\").offline_mode` instead of `plugins.getConfig(\"api\").offline_mode`", "reference": "Here also, let's not cache value on top of file, but use `plugins.getConfig(\"api\").offline_mode` directly where it is needed" }, { "prediction": "I think this should be `isset($config->Catalog->shibboleth_library_cards) && $config->Catalog->shibboleth_library_cards`", "reference": "You can combine the two checks into a single `!empty()` check." }, { "prediction": "I think this should be `max_payload (%v) cannot be higher than max_pending (%v)`", "reference": "Should we add a warning for anything over say 8M? Just suggesting that is not recommended?" }, { "prediction": "Why is this change needed?", "reference": "Looks like there are no callers left of this function." }, { "prediction": "I think this should be `attachStdin`", "reference": "Should there still be a ` bool` trailing `showOutput`?" }, { "prediction": "I don't think this is needed.", "reference": "Did we can change to v1" }, { "prediction": "I don't think this is needed for fragment types.", "reference": "Can you please double check that this won't break anything?" }, { "prediction": "I think this should be `RpcEndpoint.IPC` instead of `RpcEndpoint.IPC`", "reference": "optionals, shouldn't need to be stated explicitly" }, { "prediction": "I don't think we need this.", "reference": "That seems quite low - why not just 0x5130ffff?" }, { "prediction": "Why is this needed?", "reference": "Why is this needed ?" }, { "prediction": "I think this should be `!File.exist?(first_runs_free)` instead of `!File.exist?(first_runs_free)`", "reference": "`Bolt::Config.user_path` returns `nil` if there's no homedir, so this will still error in that case." }, { "prediction": "I think this should be `a.CompoundMessage.Proposal.value()`", "reference": "nit: use %s for strings and %v for objects." }, { "prediction": "Why is this removed?", "reference": "Same as before, the properties already exists in parent" }, { "prediction": "I don't think we should use `f` here.", "reference": "This fix is not quite correct. The `%s` should be replaced with `version` and the `%d` on line 39 should be replaced with `datetime.datetime.now().year`." }, { "prediction": "I don't think this is a good idea, but I think it's better to check if the type is \"gone\" or \"gone\" or \"gone\".", "reference": "Maybe we should only set active = false if `strcmp(type, \"pause\") == 0`?" }, { "prediction": "I don't think we need this method anymore, but I think it's better to just call it `bridge.print_page(options)`", "reference": "Same here. and all others." }, { "prediction": "I think this should be `stacktraces/on/SIGUSR2`", "reference": "Intentionally committed? I'm not against it, we already have a way to get goroutines without killing the process: `/keybase/.kbfs_profiles/goroutine`." }, { "prediction": "Why is this change needed?", "reference": "I think this blank line may be removed" }, { "prediction": "I think this should be `toggle=False` instead of `toggle=False`.", "reference": "I think this should be a keyword-only argument, i.e. do `def add(self, url, title, *, toggle=False):` and adjust the caller to do `toggle=toggle`." }, { "prediction": "I think this should be `UINT32` instead of `UINT32`", "reference": "@aimanrosli23 Judging from the commit description, I do not know why this file got changed so much. Could you help to double confirm if you do not revert the changes brought by commits: SHA-1: 643623147a1feaddd734ddd84604e1d8e9dcebee * MdeModulePkg/SdMmcPciHcDxe: Send SEND_STATUS at lower frequency SHA-1: 49accdedf956f175041040e677163b7cbb746283 * MdeModulePkg/SdMmcPciHcDxe: Hook SwitchClockFreq after SD clock start" }, { "prediction": "I don't think we need to do this in a separate PR, but I don't think we need to do this in a separate PR.", "reference": "How about YAML.load_file()" }, { "prediction": "I think this should be `isInitialized` instead of `isInitialized`.", "reference": "Maybe make this `volatile` or atomic as this can be set/read from different threads? Also, separately you may want to check if some of the methods here need to be `synchronized`." }, { "prediction": "I don't think we need this.", "reference": "Check the return value of the drmgr ones." }, { "prediction": "I think this should be `false` instead of `true`", "reference": "This should be `'cache'`" }, { "prediction": "Why is this change needed?", "reference": "The name \"old\" might cause confusion here. After installation, the \"old\" repo is at an archived path, and the new migrated repo is at the old path. Maybe something like \"target\" or \"canonical\"?" }, { "prediction": "I think this should be `command.readPreference = resolveReadPreference(options, {db: this.s.db, collection: this });`", "reference": "I think this is somewhat definitive proof that this error exists in `core` rather than `native`. We are correctly resolving the `readPreference` in the previous line, but you are able to identify that eventually the command generated in `core` is not decorated with the passed `readPreference`. Did you try to solve this there already?" }, { "prediction": "I think this should be `unwindTo := to + s.BlockNumber`", "reference": "During genesis sync it can unwind 5M blocks?" }, { "prediction": "I think this should be `Racy - times out ~50% of the time running locally with --race`", "reference": "was it caused by the removal of removeTaskQueueManager() from this test?" }, { "prediction": "Align the parameters of a method call if they span more than one line.
Space inside } missing.", "reference": "Wouldn't it just be easier to force search_session to return `with_indifferent_access`? Since you've done the hard work already, I don't think there's a problem doing it this way, but.." }, { "prediction": "I think this should be `if (rp->rr_sim_misses_deadline && rp->schedule_backoff > gstate.now)`", "reference": "So, such tasks that could possibly not meet the deadline will never have a chance to run? I think this is not nice behavior, especially for those projects who has sometimes some very small tasks after the big one." }, { "prediction": "I think this should be `lua_pushnil(L);` instead of `lua_pushnil(L);`", "reference": "You should add the check above this line instead. If string is empty, don't even call the function." }, { "prediction": "I don't think we need to log the exception here.", "reference": "If clientCert attribute doesn't exist for some reason I set it to false." }, { "prediction": "I don't think we need to add a `-k` flag here.", "reference": "Do we need `app_host_flags` variable? We can directly concat with `flags`. `sh.cmd curl_cmd(unless Travis::Build.config&.ssl&.verify ? flags + ' -k' : flags, location, static_file_location), cmd_opts` right?" }, { "prediction": "I think this should be `if (listWalkDir.isEmpty()) {`", "reference": "Walk should actually be completed (`onWalkCompleted`) after the event is stopped. This also makes it possible for monster to walk by smaller paths." }, { "prediction": "I think this should be `toDecrypt := len(address.Bytes()) == swarm.EncryptedReferenceSize`", "reference": "typo in `weather` (should be `whether`)" }, { "prediction": "This flag is for testing only. Set to true to upgrade with staging windows install media. Set to true to upgrade with staging windows install media. Set to true to upgrade with staging windows install media. Set to true to upgrade with staging windows install media. Set to true to upgrade with staging windows install media. Set to true to upgrade with staging windows install media. Set to true to upgrade with staging windows install media. Set to true to upgrade with staging windows install media. Set to true to upgrade with staging windows install media. Set to true to upgrade with staging windows install media. Set to true to upgrade with staging windows install media. Set to true to upgrade with staging windows install media. Set to true to upgrade with staging windows install media. Set to true to upgrade with staging windows install media. Set to true to upgrade with staging windows install media. Set to true to upgrade with staging windows install media. Set to true to upgrade with staging windows install media. Set to true to upgrade with staging windows install media. Set to true to upgrade with staging windows install media. Set to true to upgrade with staging windows install media. Set to true to upgrade with staging windows install media. Set to true to upgrade with staging windows install media. Set to true to upgrade with", "reference": "Thoughts on having the URI as the param, instead of a boolean? The default value would be the normal prod image, and then your test would override with the staging image." }, { "prediction": "I think this should be `num_scan = fscanf(fp, \"%d\", &n);`", "reference": "I'm surprised this is needed, but we should probably assert num_scan == 1 at least, otherwise I expect the file is pretty broken." }, { "prediction": "I think this should be `constexpr int32_t partitions = 6;`", "reference": "Could we set a default value for `partitions` and `{0, network::NetworkUtils::getAvailablePort()}` ?" }, { "prediction": "I think this should be `TimeSpan` or `TimeSpan?`.", "reference": "Needs xml docs. The API names alone don't provide enough explanation about what these mean and how to set them. Also, we should provide some validation of inputs, such as MaxTime must be > MinTime, MinimumRate must be >= 0, etc. Consider making the properties readonly and adding a constructor that does these validations." }, { "prediction": "I think we should use `path.Join` instead of `path.Join`", "reference": "Would it make sense to create an empty file here, perhaps in a tmp dir, instead of checking empty files into Git?" }, { "prediction": "I think this should be `for (size_t i = 0; i < array_only_lengths.size(); ++i) {`", "reference": "This change is due to `clang_format` and is not related to this PR." }, { "prediction": "I don't think we need to block SIGBUS here.", "reference": "Why did you not add the signals to the call of block_all_signals_except() and instead baked them into the function? Ok, if you had a good reason for it, otherwise I would add it to the except list of the function call, since that's what it was meant for." }, { "prediction": "I think this interface should be `FeedFileDownloadStatusRequesterInterface`", "reference": "Could this be done by mocking objects instead? I feel like this is changing too much of the actual logic just for the tests." }, { "prediction": "I think this should be `null`.", "reference": "why not just use `ManifestContent` instead of `Integer`?" }, { "prediction": "I think this should be `if (!_validator.IsWellFormed(tx, _specProvider.GetSpec()) && !releaseSpec.IsEip2930Enabled) { Metrics.PendingTransactionsDiscarded++; return AddTxResult.Invalid; }`", "reference": "can we do that in TxValidator?" }, { "prediction": "I think this should be `ServiceName`", "reference": "We definitely want some detailed and thoughtful docs being added to this type." }, { "prediction": "Why is this change needed?", "reference": "We would like this code to run, even when `config.XDPEnabled` is false, so that Felix can clean up its own XDP state after a restart." }, { "prediction": "This should be `__VA_ARGS__`.", "reference": "If the status is `ERR_SPACE_NOT_FOUND` why return `SUCCEEDED` ?" }, { "prediction": "Should this be `True for ResNet, False for Houglass`?", "reference": "It is is more appropriate to use `downsample_first`. If `downsample_first=True`, the downsample block is the first block and it is used for ResNet. If `downsample_first=False`, the downsample block is the last block, which is used by Hourglass network." }, { "prediction": "I think this should be `if (!service) { service = getDefaultService(); }`", "reference": "Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`)" }, { "prediction": "I think this should be `consider-using-sys-exit` instead of `consider-using-sys-exit`.", "reference": "I don't know if there are strict conventions about this, but I think the name of the warning should be the diagnosis, not the suggested course of action. In this case, that would mean changing the name of the warning to `interactive-exit` or something like that." }, { "prediction": "Why is this change needed?", "reference": "If `crt.Spec.CommonName` is not set, and `cert.Subject.CommonName` *is* set, we are not correctly handling it here." }, { "prediction": "I think this should be `cmdhistory.init()`", "reference": "This isn't a test, so it shouldn't be named `test_init`. You could name it `cmdhistory_init` or so." }, { "prediction": "I think this should be `self.spark_version`?", "reference": "why is this pulling from `self.spark_version` config section rather than the `spark` config section (`py-packages` appears to pull from a config section called `spark`)" }, { "prediction": "I think this should be `assert.Equal(0, opts.Port)`", "reference": "nit: Think it can be one line.." }, { "prediction": "I don't think this is needed.", "reference": "please inline imports" }, { "prediction": "I think this should be `!p.config.Rootless && len(p.cgroupPaths) > 0`", "reference": "This check is still correct in some cases, but I guess erroring out is acceptable if someone explicitly asked for an impossible cgroup configuration (now that we could in principle nest things). I would like to see a test for this though." }, { "prediction": "I think this should be `aggregates changed to operate on just a single columnm`.", "reference": "Should we update integral to operate on a single column as well?" }, { "prediction": "I think this should be `cuda_get_deep_copy_stream()` instead of `cuda_get_deep_copy_stream()`", "reference": "Doesn't belong to this PR" }, { "prediction": "I think this should be `registrationToken` instead of `registrationToken`", "reference": "Just for my own understanding, does aws ecs API take this token as a new input attribute? Which version of the aws sdk? I did not find it in the official aws sdk doc." }, { "prediction": "I think this should be `SF_APP_FEATURE_CODE_USER_AUTH`.", "reference": "Could we shorten this constant to maybe `FEATURE_USER_AUTH`?" }, { "prediction": "I think this should be `numRekeyWorkers`?", "reference": "Any particular reason for 8? I feel like we could probably handle more..." }, { "prediction": "Line is too long. [91/80]", "reference": "Try to use factory association declaration for default values, so it could minimal the line length. You may write in fetch_job factory like association :repository, factory: :repository." }, { "prediction": "I think this should be `cancelled` instead of `cancelled`.", "reference": "Should the \"cancelled\" class be added regardless of the proposal's state?" }, { "prediction": "Why is this removed?", "reference": "nit: random whitespace change, let's try to keep these out of commits unless there are other useful changes." }, { "prediction": "I don't think we need to use `model.split('')` here.", "reference": "Seems kinda dangerous - what if models length is different from paths length?" }, { "prediction": "Why not use `prune.Mode` here?", "reference": "set real one plz (get it from DB)." }, { "prediction": "I don't think we need to use `sizeof(int32_t)` here. I think we should use `sizeof(int32_t)` instead of `sizeof(int32_t)` here.", "reference": "Should this be initialized to zeroes?" }, { "prediction": "I think this should be `if (q == null || fcontext.searcher.numDocs(q, fcontext.base.size() == 0) && fcontext.searcher.numDocs(q, fcontext.base.size() == 0) && fcontext.searcher.numDocs(q, fcontext.base.size() == 0) && fcontext.searcher.numDocs(q, fcontext.base.size() == 0) { count = fcontext.searcher.numDocs(q, fcontext.searcher.numDocs(q, fcontext.base.size())) { count = fcontext.searcher.numDocs(q, fcontext.base.size()); }`", "reference": "The query is already built at this point, so I don't think this particular change actually helps wrt SOLR-10732? (and the `base.size()==0` case is already trivially optimized in `SolrIndexSearcher.numDocs(Query, DocSet)`)" }, { "prediction": "Why is this needed?", "reference": "re-add the type in the annotation here" }, { "prediction": "I think this should be `fmt.Errorf(\"%v:%v\", err, stderr.String())`, not `fmt.Errorf(\"%v:%v\", err, stderr.String())`.", "reference": "Could we simpify it as `cmd.Stderr = &bytes.Buffer{}`?" }, { "prediction": "I think this should be `cert.NotBefore` and `cert.NotAfter`", "reference": "there's enough \"nots\" in here that while it's correct by my review, I'd like to see a small unit test (just passing in an expired and non-expired cert)" }, { "prediction": "I think this should be `fortio.org/fortio/log`", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "I think this should be `rtol = param.Number(default=10e-6, doc=\"\"\"\")`", "reference": "The config option should probably have a more specific name. Also it's not for all gridded data but specifically for Images (and its subclasses)." }, { "prediction": "Why is this change needed?", "reference": "Be careful. This is not a preference but an option in a dialog." }, { "prediction": "Why is this change needed?", "reference": "this will modify the incoming object, which may not be desirable in some cases. i think we should stick with the local var, override it with deployment.ClusterName if deployment.ClusterName not empty" }, { "prediction": "Why is this removed?", "reference": "Is this not required?" }, { "prediction": "I think this should be `this.inputShapes_ = {};` instead of `this.inputShapes_ = {};`", "reference": "You're using scare quotes on these terms instead of defining them." }, { "prediction": "I think this should be `>= 1.10.0`", "reference": "These should both be const, not var right?" }, { "prediction": "Why is this change needed?", "reference": "Can you catch a more specific exception here? Thanks :-)" }, { "prediction": "I think we should return a `ctrl.Result{Requeue: true}, nil` instead of a `ctrl.Result{}`", "reference": "This is a bug during handling the recover logic in `common chaos` controller, I fixed in this request when I found it." }, { "prediction": "I think this should be `score_thr=0.3`", "reference": "During testing, we adopt the score threshold specified in the config file. Here the threshold is only used for visualization, and the variable name `score_thr` can be misleading. Renaming it to `show_score_thr` would be better." }, { "prediction": "I think this should be `role=\"site-nav\"` instead of `site-nav`.", "reference": "can you make this `nav-primary` please? i'd like to roll with this since the `
    ` class is `nav`, and primary is the name of the navigation menu" }, { "prediction": "I don't think we need to use `.replace(/\\s+/g, '-').replace(/[^\\w\\-]+/g, '-').replace(/^-+/, '');`", "reference": "@georgehrke Just out of curiosity. Couldn't you combine at least the combine the regex for '-' and '' with groups?" }, { "prediction": "I think this should be `GetAnyObjectType` instead of `GetAnyObjectType`.", "reference": "I think this is objectively better than looking up the object by name. As a follow-up, I'm going to see whether we do this name-based lookup somewhere else and switch to your method." }, { "prediction": "I think this should be `(marginX - this.flyoutWidth_ + statusButtonWidth) / this.workspace_.scale`", "reference": "Why are you dividing by scale in the LTR case but not the RTL case?" }, { "prediction": "I don't think we need to add the `W3C_MINIMIZE_WINDOW` command here.", "reference": "Update after command rename" }, { "prediction": "I think this should be `TagManagerModuleSettings` instead of `TagManagerModuleSettings`.", "reference": "I added this change to fix a bug with the legacy settings wrapper which was preventing it from working properly with the other modules " }, { "prediction": "I think this should be `final` instead of `final`.", "reference": "isn't AZKABAN_FLOW_VERSION_2_0 more explicit?" }, { "prediction": "I think this should be `R.string.feature_not_present`.", "reference": "Please don't leave an empty default" }, { "prediction": "I think we should remove this line.", "reference": "This isn't directly related, but the `import React from 'react';` below should be removed. We never import this directly and any modules from it we need are imported through `@wordpress/element`. This was probably added automatically at some point, but we also provide this automatically via `ProvidePlugin`." }, { "prediction": "I don't think we need the 800 lines of the output.", "reference": "You can also use `echo: false` instead. Either is fine; I'm just pointing it out." }, { "prediction": "Why is this needed?", "reference": "what's the reason for this moved line?" }, { "prediction": "I think this is a bit confusing to me, but I think it would be better to use `getCardTextLines` instead of `getCardTextLines` if `showTitle` is true. I think it would be better to use `getCardTextLines` if `showTitle` is true.", "reference": "I don't really follow what is happening here, but it looks like this _could_ conflict with the logic on the lines above... should this be an `else if`?" }, { "prediction": "Why is this change needed?", "reference": "`s => s.IsHidden == false` What's the purpose of adding this?" }, { "prediction": "I think this should be `clef-signer-address` instead of `clef-signer-address`", "reference": "I would name this `clef-ethereum-address`. We already have a bunch of addresses in Bee, and people might wrongly think that this is yet another address" }, { "prediction": "Why is this needed?", "reference": "you can just remove this" }, { "prediction": "I think this should be `upgrade-cstor-pool-spc`", "reference": "I think we should avoid creating a dummy CR in the case of SPC. Please see if we can avoid this since we will not be patching anything in this CR." }, { "prediction": "I think this should be `if locked_features.any?`", "reference": "Honestly not sure myself, but do you think it makes sense to move this conditional into the partial?" }, { "prediction": "I think this should be `qutebrowser-prefix-` instead of `qutebrowser-prefix-`.", "reference": "As discussed in IRC (just so it doesn't get lost): This probably should be `-basedir-`, not `-prefix-`" }, { "prediction": "I think this should be `PathUtils.GetExecutingDirectory` instead of `PathUtils.GetExecutingDirectory`", "reference": "basepath can be absoluta path and this needs to be supported" }, { "prediction": "Why is this change needed?", "reference": "Didn't get to the commit message" }, { "prediction": "Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.", "reference": "What about raising `ActionView::MissingTemplate` instead? That's what HighVoltage does." }, { "prediction": "I think this should be `balance.first.convert_to()`.", "reference": "Is it kept for compatibility?" }, { "prediction": "I think this should be `account_signer_address` instead of `account_signer_address`.", "reference": "I would find it pretty reasonable to add a MinerSigner method on the state view that puts these together." }, { "prediction": "I think we should add a new column to the table.", "reference": "It's stored in `PodDBAdapter.VERSION`. I usually use the expected release version code for that change. As this will be released in AntennaPod 2.2.0, the code would be `2020000`." }, { "prediction": "Why is this change needed?", "reference": "What about method name itself? Do we run this for SQL too?" }, { "prediction": "Why is this change needed?", "reference": "`instanceUrl` should be `cs1.salesforce.com`. `communityUrl` would be `mobilesdk.cs1.my.salesforce.com`." }, { "prediction": "I think this should be `if (name) { ... }`", "reference": "Let's use `if(name != nullptr)` to remove ambiguity" }, { "prediction": "I think this should be `getNotImplementedString(\"SurfaceNamer.getMetadataIdentifier\")`, not `getNotImplementedString(\"SurfaceNamer.getMetadataName\")`.", "reference": "I wonder if it would make sense to have a separate namer for metadata? Metadata files tend to be expressed in a different language from the repo language, and have mutually exclusive concepts. So, `PackageMetadataNamer`." }, { "prediction": "I think this is a bit confusing, but I think it would be better to use `BftValidatorsValidationRule.extraDataValidatorsAndVoteMustBeEmpty` instead of `BftValidatorsValidationRule.extraDataValidatorsAndVoteMustBeEmpty`.", "reference": "This rule is quite specific to qbft and so I don't think it should be part of the common rules. Would rather the common bft code didn't know anything about contract based voting/validator governance." }, { "prediction": "I think this should be `@param Set elements`", "reference": "This makes our life harder than it needs to be. A Set is unordered by definition. Please remove this method from Set and add it to SortedSet, but with no default implementation. We need to duplicate it then to LinkedHashSet but that's ok, it is the best we can do. Could you please add it also to SortedMap and LinkedHashMap? We are then able to close the original issue." }, { "prediction": "I don't think we need to do this in the `build_base_http_request` function.", "reference": "we can replace `for` with `params.update(response_headers)`" }, { "prediction": "I think we should remove the `#if NETSTANDARD1_3` check here.", "reference": "Any chance this is available in .NET Core 2.0 now?" }, { "prediction": "I think this should be `go-peerstore`", "reference": "I wonder if it's necessary to let app pass in the context. What app level context should be sent? If no, is it enough for p2p agent to compose a context with network info there?" }, { "prediction": "I think this should be `lbann/execution_contexts/sgd_execution_context.hpp`", "reference": "Why do we need both includes here?" }, { "prediction": "Why is this change needed?", "reference": "SmartStoreInspectorTest expected results in a certain order" }, { "prediction": "I don't think we need to check for `nullptr` here.", "reference": "I think that you need something like `m_using_random_node.emplace(m_io_thread_pool->get_local_thread_id());`" }, { "prediction": "I think this should be `if (isUsedLocalVarWithoutInitializer(entry, result.usedVariables)) { continue; }`", "reference": "I don't think we need to maintain a separate set. The problem here is that the \"assignment\" that is killed for this variable is not really an assignment. If we just don't `assign` the variable with the non-existent value, it will not be reported. I pushed a fix." }, { "prediction": "I think this should be `long` instead of `long`.", "reference": "Let me know if this is too pervasive. It is currently a private method in `BaseTableScan`. It seems both `SparkBatchQueryScan` and `SparkMergeScan` need to know the scan-specific split size when planning tasks. Therefore, I made it open. Another approach is to move all the `planTasks` logic to scan implementations, but for the combine tasks by partition feature, it requires grouping scan tasks by partition first, instead of returning them in an iterator fashion. I'm not sure if this is OK. `SparkMergeScan` also seems to re-implemented its own plan tasks logic." }, { "prediction": "I think this should be `fmt.Sprintf(\"%q\", msg[:maxTrace])`", "reference": "Not sure what is this change doing?" }, { "prediction": "I think this should be `delta = timedelta(days=30) if mins is not None else timedelta(days=90) if mins is not None else timedelta(days=90) if mins is not None else timedelta(days=30) if mins is not None else timedelta(days=90) if mins is not None else timedelta(days=30) if mins is not None else timedelta(days=90) if mins is not None else timedelta(days=30)", "reference": "this is funky. either don't take` minutes` as keyword arg or take both `minutes` and `days` and pass all of them on to `timedelta`. i'm guessing you're aiming for backwards compatibility, but i don't think it's worth it given how confusing this is. atlernatively, make `mins=60*24*30` the default. and that brings me to another issue, `mins=None` is not a very useful default." }, { "prediction": "I think this should be `if (rememberMeServices instanceof AbstractRememberMeServices)` instead of `if (key == null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null) { if (rememberMeServices instanceof AbstractRememberMeServices) { rememberMeServices = getRememberMeServices(http, key); if (rememberMeServices != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null", "reference": "Please use a tab for indentation instead of spaces." }, { "prediction": "Why is this change removed?", "reference": "I can't believe we didn't see this typo before :))" }, { "prediction": "I think this should be `logging.getLogger(__name__)` instead of `logging.getLogger(__name__)`", "reference": "If the logger isn't used, it probably doesn't need to be added." }, { "prediction": "I think this should be `script.type = 'text/javascript'`", "reference": "These files should in `/javascript/brython`" }, { "prediction": "I don't think we need to check `imageAlpha.Deprecated.StateOverride.DefaultRolloutTime` and `imageAlpha.Deprecated.StateOverride.DefaultRolloutTime` in the `if imageAlpha != nil && imageAlpha.Deprecated.StateOverride.DefaultRolloutTime > 0 { return true }`", "reference": "minor, you can squash these into one `if`" }, { "prediction": "Why is this change needed?", "reference": "Used regexes to do most of this, hence different methods of string creation of UUIDs. I plan to follow up with an additional change to remove direct references to google/pborman UUID so `uuid.New()` and `uuid.NewRandom()` will instead use our `primitives.UUID`." }, { "prediction": "I think this should be `!GraphSummary.Disposing` instead of `!GraphSummary.Disposing`.", "reference": "Add a TODO here to revisit if this was problematic." }, { "prediction": "I think this should be set to `True` when using `IoULoss`, `GIoULoss`, or `DIoULoss`.", "reference": "Note generally it -> It" }, { "prediction": "I think this should be `if (type == \"directed_acyclic_graph_model\") {`", "reference": "Is this relevant to this PR?" }, { "prediction": "I think this should be `opts[:run_in_parallel] == true` instead of `opts[:run_in_parallel] == true`", "reference": "Can we instead ensure that `opts[:run_in_parellel]` will always be a boolean? Otherwise we'll have to account for the case when it's a non-boolean value in multiple places, such as any/every other `if` statement." }, { "prediction": "I think this should be `HTTPSchemeHTTP` or `HTTPSchemeHTTPS`", "reference": "Is this just moved out of the other files? It doesn't seem like this was generated like the other files." }, { "prediction": "I think this interface should be `IHttpContent`", "reference": "I started out doing everything `async`, but it was getting in the way of debugging, so I switched back to all synchronous until I got things working. We should probably move everything back to `async` and remove the synchronous versions." }, { "prediction": "I think this should be `mevExecutorFactory = new(SpecProvider, LogManager);`", "reference": "this looks already too complicated..." }, { "prediction": "I think this test should be in a separate PR, and not in a separate PR.", "reference": "As for the testings, we better to verify the actual effects of the compaction. Of course, you could do it in future." }, { "prediction": "I think this should be `ImmutableList.copyOf(tableMap.values());`", "reference": "should we add a TODO here?" }, { "prediction": "I think this should be `Root` instead of `Root`.", "reference": "This can be inlined below as `GoogleSitekitDashboardDetails` is an unnecessary wrapper now." }, { "prediction": "Why is this change needed?", "reference": "NewVHS -> NewVersionHistories this one looks better" }, { "prediction": "I don't think this is necessary.", "reference": "Is this `@missing_text` ?" }, { "prediction": "I don't think we need the `/` prefix here.", "reference": "Minor suggestion, but wouldn't it be cleaner to simply replace PACKAGE_NAME_FORMAT to all the optional path, then check that the path is empty in validate_package_name? We might also want a helper function to pull out the package name and sub-package path." }, { "prediction": "I don't think we need to use `i18n` here, but I think it would be better to use `i18n` instead of `i18n`", "reference": "we should have a way to insert components into a i18n string. so that we could define a translation string like `'%{filename} is being edited'`, and inject the filename `` at the right place. I imagine there must be a language where the `Editing` text should come after the file name. we can think about that later tho." }, { "prediction": "This should be `if (!pglob.gl_pathv) continue;`", "reference": "Probably want break instead of continue." }, { "prediction": "Why is this change needed?", "reference": "This was on purpose that I would set logging (NoLog=false) and a dummy logger below. The idea is to have better code coverage and test of debug/trace statements. Any reason you have removed this?" }, { "prediction": "I think this should be `Stream.empty()` instead of `Stream.empty()`.", "reference": "does adding a `Stream.empty()` help here?" }, { "prediction": "I think this should be `SCANNERS_ENABLED` instead of `SCANNERS_ALL_EXIST`", "reference": "This is not being used anymore, so can be removed." }, { "prediction": "I think this should be `fmt.Sprintf(\"IPv4: %s, %s\", p.ipv4.String(), p.ipv6.String())`", "reference": "Is it called some where?" }, { "prediction": "I think this should be `reflect` instead of `reflect`", "reference": "Please remove this extra blank line." }, { "prediction": "I think this should be `@InputFiles` instead of `@InputFiles`.", "reference": "this is really the key, if you don't set this then gradle doesn't wire up the tasks that produce various files inside these configurations as inputs... I think we were just getting lucky before." }, { "prediction": "I think this should be `r := sn.HasTags(tags)`", "reference": "Sorry if I'm missing something here, but shouldn't this message be about failing to match with an *empty* selector, and/or perhaps even an empty *tag* instead of selector? The message seems a bit disconnected from what we're testing?" }, { "prediction": "I think this is a good idea to use `using System.IO;` instead of `using System.IO;`", "reference": "nit: please move these inside namespace." }, { "prediction": "I don't think we need this flag anymore.", "reference": "may users try to abuse it?" }, { "prediction": "Why is this needed?", "reference": "why is this space removed?" }, { "prediction": "I think this should be `go:build!windows`", "reference": "Can we remove this other line now then?" }, { "prediction": "I don't think we need this file anymore.", "reference": "There's a comma missing here at the end :wink:" }, { "prediction": "Why is this removed?", "reference": "Why is this not required any longer?" }, { "prediction": "I think this should be `paginater` and not `paginater`", "reference": "Indentation seems a bit fucked up here. Run `go fmt`." }, { "prediction": "I don't think we need to check for `nil` here.", "reference": "any chance in == nil? same below" }, { "prediction": "I think this should be `h2o_sysfn(socket, AF_UNIX, SOCK_STREAM, 0)` instead of `h2o_sysfn(socket, AF_UNIX, SOCK_STREAM, 0)`", "reference": "We would change the source code of h2o so that certain syscalls will be invoked through the `h2o_sysfn` macro." }, { "prediction": "I think this should be `const auto &error = core->device_extensions.vk_khr_timeline_semaphore ? SubmitError::kTimelineCannotBeSignalled : SubmitError::kBinaryCannotBeSignalled;`", "reference": "the name kTimelineCannotBeSignalled is confusing. It's not that a TimelineSemphore cannot be signaled... it's the \"VK_KHR_timeline_semaphore is enabled *variant* of the \"binary cannot be signaled\" message. We should probably have a consistent naming scheme to clarify. kBinaryCannotBeSignalledAltTimeline or hide the complexity in Get*VUID functions as needed somehow (pass in the extension structure?)" }, { "prediction": "I think this should be `percentiles=None` instead of `percentiles=None`.", "reference": "Could you add a type hint? `percentiles: Optional[List[float]] = None`" }, { "prediction": "Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.", "reference": "Maybe putting ones they've used before first would be good, but this is fine for now." }, { "prediction": "I think this should be `noenc` or `bh`", "reference": "I don't think we need these. Simpler just to put `routetable.TargetType...` inline below." }, { "prediction": "I think this should be `if cart.proposal.client_data_legacy.client == \"ncr\"`", "reference": "Why this instead of the old way?" }, { "prediction": "I don't think you need to check if `IsInvisible(formerpet)` is true.", "reference": "Just combining the inner if/else blocks like this is what I originally meant (I didn't mean replacing all the invisible checks in the outer if, I realize that would have been a functionality change regarding the rule) This should now be equivalent to `if (RuleB(Pets, LivelikeBreakCharmOnInvis) || IsInvisible(formerpet))` (the second check for the rule being false after the `||` would be implied, anything after the `||` would only be evaluated if the rule was false)" }, { "prediction": "Why do we need this?", "reference": "We don't want to write this back to the definition do we? Probably just want to create a local variable for it." }, { "prediction": "I think this should be called after `onPlaybackEnded`.", "reference": "Good catch! Could you please move this to `PlaybackService.this.onPlaybackEnded`? I think it's more clean if everything is in one single place." }, { "prediction": "I think this should be `xcb_flush(QX11Info::connection());` instead of `xcb_flush(QX11Info::connection());`", "reference": "We're trying to avoid X.org specific code. So I'm not a fan of this. Can't this be achieved in display server agnostic way?" }, { "prediction": "I think this should be `public static class Class1 { ... }` instead of `public static class Class2 { ... }`", "reference": "This class can be removed?" }, { "prediction": "I think this should be `github.com/iotexproject/iotex-core/action/protocol`", "reference": "File is not `goimports`-ed (from `goimports`)" }, { "prediction": "Why is this TODO removed?", "reference": "To minimize the possibility of regret, perhaps we name this `ZapLogger`." }, { "prediction": "Align the parameters of a method call if they span more than one line.", "reference": "This looks a little weird, but it's a feature of the gem we're using. You can give it a symbol representing the method you want called on current_user." }, { "prediction": "I think this should be `anomaly_hotgym.py`", "reference": "`Anomaly` imported here, but not used. Please run the changed files through pylint with nupic pylint config and fix pylint findings related to your changes." }, { "prediction": "I think this should be `typeof target === 'string'` instead of `typeof target === 'string'`", "reference": "We needed this testutils file after all " }, { "prediction": "Why is this change needed?", "reference": "line is 161 characters (from `lll`)" }, { "prediction": "I don't think we need this import.", "reference": "Please re-format/groupimport this line. You might need a little manual work." }, { "prediction": "I think this should be `worker.env.ApplyWorkerCustomizations(worker.wf, worker.env.NoExternalIP)` and not `worker.env.ApplyWorkerCustomizations(worker.wf, worker.env.NoExternalIP)`", "reference": "minor, you can just use `wf` instead of `worker.wf`" }, { "prediction": "Why is this change needed?", "reference": "I would suggest putting this in the resources directory with the same package as of this test class. Then you can utilize the method azkaban.utils.TestUtils#readResource to read it as string." }, { "prediction": "I think this should be `upgrade/templates` instead of `upgrade/templates`", "reference": "could not import github.com/openebs/maya/pkg/upgrade/templates (invalid package name: \"\") (from `typecheck`)" }, { "prediction": "I think it's better to keep the `OTel Exporter` as well.", "reference": "a official -> an official" }, { "prediction": "Why is this change needed?", "reference": "I only want the proxy request for this to run for kinesalite." }, { "prediction": "Why is this change needed?", "reference": "White space boya?" }, { "prediction": "I think this should be `StackSummary`.", "reference": "Maybe ditch these since `StackSummary` is not used anymore." }, { "prediction": "I don't think we need to change the default value of `ignore_index` to `255`.", "reference": "suggest to indicate the value range & meaning in docstring" }, { "prediction": "why change this?", "reference": "not sure if it works with prometheus by default, otherwise we will have to add this into prometheus config also" }, { "prediction": "I think this should be `CleanupEndpointMark` instead of `RemoveEndPointMark`", "reference": "The rule renderer isn't meant to be stateful so probably best to move this out of here" }, { "prediction": "I think this should be `findNvidiaContainerRuntimes` instead of `findNvidiaContainerRuntimes`", "reference": "passing in a `nil` here just so that the tests can pass in an alternative implementation seems weird, but I don't know what the convention is for doing something like this - @briandowns?" }, { "prediction": "I think this should be `@deque/doT`", "reference": "IMO `dot` should be preferred. Remember `aXe`?" }, { "prediction": "I think this should be `Console.ReadLine()` instead of `Console.ReadKey()`", "reference": "Not a huge deal but this will block tests, also, don't they stay open by default now?" }, { "prediction": "Why is this change needed?", "reference": "Could you make it a local constant for now ?" }, { "prediction": "I think this should be `field in ('id', 'collection_id')` instead of `field in ('id', 'collection_id')`.", "reference": "What is this `collection_id` field here?" }, { "prediction": "I think this should be `if conf.interactive: print(msg)`", "reference": "Is there a reason why we don't use logging for this?" }, { "prediction": "Why is this needed?", "reference": "Exceptions should be placed in application layer -> infrastructure is aware of application - not the other way around" }, { "prediction": "I think this should be \"C0301\"", "reference": "IIRC issue mentioned reporting _symbolic message_ - so in this case it would be `line-too-long`." }, { "prediction": "I think this should be `else if (id == \"feedbackable\") { return spells[spell_id].feedbackable; } else if (id == \"reflectable\") { return spells[spell_id].reflectable; } else if (id == \"reflectable\") { return spells[spell_id].reflectable; } else if (id == \"reflectable\") { return spells[spell_id].reflectable; } else if (id == \"reflectable\") { return spells[spell_id].reflectable; } else if (id == \"reflectable\") { return spells[spell_id].reflectable; } else if (id == \"reflectable\") { return spells[spell_id].reflectable; } else if (id == \"reflectable\") { return spells[spell_id].reflectable; } else if (id == \"reflectable\") { return spells[spell_id].reflectable; } else if (id == \"reflectable\") { return spells[spell_id].reflectable; } else", "reference": "Is this intended to be `spells[spell_id].reflectable` here? Edit: Should be `spells[spell_id].feedbackable`, right?" }, { "prediction": "I think this migration should be moved to `add_column` or `remove_column`.", "reference": "How should we set this for existing teams?" }, { "prediction": "I think this should be `testClusterProvisionWithInfraIDSet()`?", "reference": "It would be nice if we could verify that this is in fact the error we expected. But that's a latent issue, something for the backlog." }, { "prediction": "I think this should be `go-openvpn/openvpn/middlewares/state`", "reference": "I hate then some internal process specific middleware leaks into connection manager :( todo later." }, { "prediction": "I don't think you need to add this to the `nupic.support.configuration_base` here.", "reference": "Reflects where these files were moved for `pkg_resources`." }, { "prediction": "Why is this needed?", "reference": "This should be computed('i18n.locale'...." }, { "prediction": "I think this should be `net.ipv4.conf.eth0.rp_filter=2` instead of `net.ipv4.conf.eth20.rp_filter=2`", "reference": "Can you explain to me what goes wrong here? Can the test be adjusted to set up working routing instead?" }, { "prediction": "I think this should be `java.util.Objects`", "reference": "We can get rid of this import then." }, { "prediction": "I think this should be `id` instead of `id`", "reference": "Not sure how useful is unlock event." }, { "prediction": "I think this should be `lowercaseFields`?", "reference": "Consider make the second argument a `encoderOptions` which includes the `lowercaseFields` just like opening a collection." }, { "prediction": "I think this should be `TezUtil.enrichContextWithAttemptWrapper(ctx)`", "reference": "What is the value of renaming this to `ctx`? We generally prefer the longer names because they are easier to read and to type." }, { "prediction": "I think this should be `if (lane_data.front().tag == TurnLaneType::uturn)` instead of `if (lane_data.front().tag == TurnLaneType::uturn).tag == TurnLaneType::uturn)`", "reference": "Hm. This could be a case of left-sided driving, having u-turn lanes on the right side. Good catch, but looks good to me." }, { "prediction": "I think this should be `Success` instead of `Fail`.", "reference": "There was a [JsonPropertyName(\"success\")] here it did serialize fine for me, so I am not sure what was the matter? Also maybe uppercase?" }, { "prediction": "Why is this needed?", "reference": "we can just use read env here, pretty sure" }, { "prediction": "I think this should be `this.hot.selection.transformation.addLocalHook('afterTransformStart', (...args) => this.onAfterLocalTransformStart(...args));`", "reference": "Could you replace local hook with global hook `afterModifyTransformStart`?" }, { "prediction": "I don't think we need this function anymore.", "reference": "You seem to be basing your PRs off an commit, which keeps reintroducing these changes, which makes it harder to review your PRs." }, { "prediction": "I think this should be `assert(typeof opt_port === 'function')`", "reference": "Maybe it would simpler to ignore opt_port if type !== 'number'?" }, { "prediction": "Why is this change needed?", "reference": "As far as I can tell, `IDictionary` implements `IEnumerable>` so we are just making it more generic. From the issue, I understood that we want to maintain sequence/order. I believe `IEnumerable<>` won't fix the issue." }, { "prediction": "I think this should be `LOG.info(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String)))))))))))))))))))))))))))))))))))))))))))))))))))))", "reference": "This change prevents a user understanding how their server is configured. Best to leave at `info` level." }, { "prediction": "I think this should be `ephemeralDenyList` instead of `ephemeralDenyList`", "reference": "I will add the following to the list: - api.SpecScale - api.SpecSticky" }, { "prediction": "Why is this needed?", "reference": "As defaultSendPort is being removed, and I don't like TODOs on examples, please remove the whole line" }, { "prediction": "Why is this removed?", "reference": "since we are now no longer expecting an input of float to return an empty string, i have removed this test case." }, { "prediction": "I think this should be `newCounter`?", "reference": "It would be cleaner if you were to pack the name&desc in a `MetricName` and pass it to `MakeCounter`" }, { "prediction": "Why is this removed?", "reference": "Do you know why do we need this?" }, { "prediction": "I think this should be `MvvmCross.iOS.Views` instead of `MvvmCross.iOS.ViewModels`.", "reference": "I guess this using is what causes the build to fail" }, { "prediction": "I think this should be `pony_unregister_thread()` instead of `pony_unregister_thread()`", "reference": "I like the explicit unregister approach." }, { "prediction": "I think this should be `0x30: HistogramWithMinMax(reserved)` and `0x40: ExponentialHistogramWithMinMax(reserved)`", "reference": "We should able to use 0x30 as summary, and make 0x80 reserved for future." }, { "prediction": "I think this should be `PlatformHelpers.PlatformStrategy.ShouldSkipClientSpan(tracer.ActiveScope)`", "reference": "This allows strategic exclusion of http spans." }, { "prediction": "Shouldn't this be `@var string[]|null`?", "reference": "why not just `string[]` instead of nullable" }, { "prediction": "I think this should be `\",\"` instead of `\",\"`", "reference": "How does this work? Why isn't each tag after the first picked up as a new arg/flag?" }, { "prediction": "I think this should be `Datadog-AzureAppServices-Resource-ID`.", "reference": "This key is actually yet to be determined. Meeting with the backend team and Garner to discuss." }, { "prediction": "I think this should be `assert(!iv_state);`", "reference": "Why remove the crash protection? We're just going to get a bug filed on it." }, { "prediction": "I think this should be `X-Frame-Options` instead of `X-Content-Type-Options`.", "reference": "Maybe be consistent and name it `FRAME_OPTIONS`." }, { "prediction": "I think this should be `if (orphanBlock && orphanBlock.outputConnection) {` instead of `if (orphanBlock && orphanBlock.outputConnection.connect(orphanBlock));`", "reference": "This check/exception is a guard for the next few lines of code. It shouldn't be necessary now. In fact, I don't think you need the if (parentConnection.type == Blockly.INPUT_VALUE) branch at all." }, { "prediction": "Why is this change needed?", "reference": "Could probably move these constants too?" }, { "prediction": "I think this should be `cmd.Kill()` instead of `cmd.Kill()`", "reference": "Maybe 'failed' instead of 'missing'. Also do we really need to write ticket numbers here?" }, { "prediction": "Why is this removed?", "reference": "Test used to use old bouncycastle dependency which isn't needed anymore from Hadoop. Switched to use builtin Java split." }, { "prediction": "Why not use `unicode` here?", "reference": "nit: I think this would be more readable as \"Some language names contain Unicode characters\"." }, { "prediction": "This file is not used anymore.", "reference": "Thanks for adding the header, but I don't think 2017 is a very accurate guess here. Could you do a quick search with git blame and change this accordingly?" }, { "prediction": "I think this should be `../../src/index.js`", "reference": "Oh interesting - does web-test-runner not resolve package.json files?" }, { "prediction": "I think this should be `ariaDayPrefix=\"P\u00e4iv\u00e4\"`", "reference": "Is there a way to derive this value from the locale itself? I feel hardcoding the prefix in the props isn't the right approach, but I'm not sure what the locale file contains exactly." }, { "prediction": "I don't think this is a good idea, but I think it would be better to just call `component.setState(component.getDerivedStateFromProps(props, context));` instead of `component.setState(component.getDerivedStateFromProps(props, context));` and `component.setState(component.getDerivedStateFromProps(props, context));` and `component.setState(component.getDerivedStateFromProps(props, context));` and `component.setState(component.getDerivedStateFromProps(props, context));` and `component.setState(component.getDerivedStateFromProps(props, component.getDerivedStateFromProps(props, context));`", "reference": "I'd much rather see these warnings in our devtools (`debug/index.js`). Strings contribute quite a bit to our file size and moving them there would prevent bloating core." }, { "prediction": "I think this should be `SELECT %s from %s` instead of `SELECT %s from %s`", "reference": "Use `String.format(Locale.US, ...) to avoid the `Lint` warning." }, { "prediction": "I think this should be `ServiceReference`.", "reference": "nit: ServiceReference represents a reference to a v1.Service." }, { "prediction": "I think this should be `*string[]string`", "reference": "since it changes to the array, how about change the name to `DeviceNames`" }, { "prediction": "I think this should be \"RuntimeTLP\"", "reference": "Can we avoid this. upgrade engine code should take care of this." }, { "prediction": "I think this should be `DEFAULT_TOKEN_EXP_DAYS`", "reference": "should also be alphabetized or at least grouped and alphabetized within group" }, { "prediction": "I think this should be `pylint: disable=unused-variable` instead of `pylint: enable=unused-variable`.", "reference": "No need for this, as pylint already only turns things off for this function and it's needed for the entire function." }, { "prediction": "I think this should be `errUnmarshalCountOpts` instead of `errUnmarshalBuildOpts`.", "reference": "nit: can we remove \"can't\" from the error message?" }, { "prediction": "I think this should be `cVR.Status.Phase = apis.CVRStatusPending` instead of `cVR.Status.Phase = apis.CVRStatusRecreate`", "reference": "instead of modifying 'Status' which impacts the state diagram, how about using some annotations on CVR? This can probably help for our upgrade as well. Is this possible? cc: @AmitKumarDas" }, { "prediction": "I think this should be `https://packages.cloud.google.com/yum/repos/kubernetes-el7-x86_64`", "reference": "Rename this as KubernetesGPGURL - >KubernetesUbuntuGPGURL , Modify it where ever it is used." }, { "prediction": "I think this should be `const DEFAULT_FEE = 0.0001;`", "reference": "I'm not totally sure I like the idea of putting a default fee here, but I guess so long as we make sure to track the default fee of bitcoin core, we're good. We should really also take a look at the byte size of the transaction, and use that to determine what the fee should be. But that could also be a different PR." }, { "prediction": "Why did you change this to `@linkplain javaslang.collection.Iterator`?", "reference": "oh yeah, `tail`, `update`, `prepend`, `append`, `subSequence`, `trim` just became effectively constant (without memory leak) :)" }, { "prediction": "I think this should be `(array)$resource`", "reference": "Can you add back a deprecated `destroyLinks` method for backward compatibility? It can simply proxy `destroyResourceLinks`, and we can remove it in the next major release." }, { "prediction": "I think this should be `parseOptServerOptions` instead of `parseOptSingleString`.", "reference": "A reminder that we should discuss whether to rename this to \"sockets\" or \"listeners\"." }, { "prediction": "Why is this needed?", "reference": "Why do you need to include this using declaration?" }, { "prediction": "Why is this change needed?", "reference": "@halter73 where is this file generated from?" }, { "prediction": "I think this should be `#if TRUE` instead of `#if FALSE`.", "reference": "What do these `#if TRUE` accomplish?" }, { "prediction": "I think this should be `if (Sdk.SuppressInstrumentation) { return; }`", "reference": "Probably a good optimization to have this, but I don't think it's strictly required. For \"legacy\" Activity flows we pass them through an ActivitySource for sampling. So the logic below should also catch these?" }, { "prediction": "I think this should be `view_request_cta`", "reference": "@jessieay Intentionally moving away from passing a param?" }, { "prediction": "Why is this removed?", "reference": "I think you could condense this code considerably by getting rid of the initialization and foreach loop and simply saying: `$firstname = trim(implode(' ', $nameArr));` What do you think?" }, { "prediction": "Why is this removed?", "reference": "hmm, we actually should _add_ `'use strict'` everywhere " }, { "prediction": "I think this should be `logger.warn(\"Project \" + projectId + \" version \" + projectVer + \" property \" + propsName);`", "reference": "it's not just fetching override properties here, right?" }, { "prediction": "I think this should be a log message.", "reference": "Is it worth logging the error?" }, { "prediction": "I think this should be `self.__dict__[\"ns\"]`", "reference": "What's the point of this class?" }, { "prediction": "I don't think we need this change, but I think it would be better to use `contentType !== 'movies' && contentType !== 'mixed'` instead of `contentType !== 'movies'`", "reference": "I'm being picky here, but I think I would prefer `toggle` to be kept here and just change the condition to `contentType !== 'movies' && contentType !== 'mixed'` or `!['movies', 'mixed'].includes(contentType)`." }, { "prediction": "I think this should be `libkbfs` and not `libkbfs/leveldb`", "reference": "Please put this down with the other \"github.com\" imports." }, { "prediction": "I think this should be `bool push_front_preference` instead of `bool`.", "reference": "Minor but probably want `push_front_preference` to have a trailing `_a` to be consistent with the other parameter" }, { "prediction": "I think this should be `rewriteNot(Projections.inclusive(spec, caseSensitive).project(rowFilter))`", "reference": "Nit: the formatting is a bit off. I would expect this to be 2 indentations from `this.expr = ...` but this is 8 spaces, not 4. Also, most places leave the `);` on the last line of the method arguments." }, { "prediction": "I don't think this is needed.", "reference": "Ack, @chrisdunelm snuck this class extension past me. This is not a pattern I want to have used..." }, { "prediction": "I don't think we need to add the endpoint here.", "reference": "nitpick: I wonder if we should name it `flush` only (?)" }, { "prediction": "I think this should be `tasks_current` and `deals_current`.", "reference": "Why gauges, not counters?" }, { "prediction": "why is this needed?", "reference": "Just making a note here that this may break pre GWs between pre 2.2.0 and 2.2.0 servers. Not sure, will have to experiment/dig a bit more." }, { "prediction": "I think this should be `POD_FAILED`.", "reference": "Shall we rename this status to CONTAINER_FAILED? ^^ cc: @sshardool" }, { "prediction": "I think this should be `FetchTipSets` instead of `FetchTipSets`.", "reference": "Thinking out loud here: I believe the only reason we need `peer.ID` as a parameter to this method is because we are not persisting blocks from pubsub (instead we are refetching them). If nodes persist the blocks they received over pubsub then I think we can guarantee peers we share a connection with (i.e. that are in the peer tracker) will always have the blocks we are fetching (else how would have we gotten the pubsub message). I imagine the concept of an `initialPeer` can go away once #2962 lands since the peers in the tracker will have the block. Although I don't think that covers the case of fetching blocks our peers have deemed semantically invalid and thus not stored..." }, { "prediction": "I think this should be `[here](https://github.com/google/cel-spec/blob/master/doc/langdef.md#standard-definitions)`.", "reference": "I know it has no effect but my eyes can't help. Is that line not too long?" }, { "prediction": "Why is this removed?", "reference": "Does that mean we disable service loop prevention for packet generated by local host?" }, { "prediction": "I don't think we need to check if the host is cygwin installed.", "reference": "It seems a little odd to have both `host.is_cygwin?` *and* `host.cygwin_installed?` defined (with a possibility of having `is_cygwin?` be `true`, but `cygwin_installed?` returning `false`). Do the docs clearly explain the difference?" }, { "prediction": "I think this should be `v2` instead of `v1`", "reference": "Does this mean manifests will be written with the v2 schema (i.e. with sequence numbers) even though `TableMetadata` is v1 and the manifest list is written with v1? And this should work because we do a projection on read and sequence number is optional?" }, { "prediction": "I think this should be `REWRITTEN_FILE_SCAN_TASK_SET_ID`", "reference": "Should we be sharing this property key with the read? Maybe it should be belong to the file-scan-task object itself?" }, { "prediction": "I think this should be `debug_cmd` and `debug_tools`", "reference": "Nice! Good idea to move these out of the main struct." }, { "prediction": "I think this should be `if err != nil { return err }`", "reference": "Thanks for paying attention to other places this might happen. This one is particularly important; I probably never should have gotten in the habit of CheckErr(), since it does a log.Panic() explicitly, which looks like something else until you look closely. It's supposed to be used places where \"can't happen\" but Things Can Happen." }, { "prediction": "I think this should be `Type` instead of `String`.", "reference": "Converting this to an enum makes it obvious that I combined things that don't really belong together. It would probably be better to create two enums `StoreType` and `TransportType` (in more appropriate locations). That also makes it necessary to have (at least) two `ServerSettings` classes. `IncomingServerSettings` and `OutgoingServerSettings`. Also, the naming is inconsistent. Maybe it would be better to make the string that is used for import/export explicit, e.g. WEBDAV(\"WebDAV\")." }, { "prediction": "I think this should be `@memberof axe.commons.utils`", "reference": "It's out of scope for this PR, but I don't find this utility's name to be particularly intuitive. It speaks to nothing of what it does. Does it create a token list? Process one? Get one? `tokenListToArray` would be nice." }, { "prediction": "I don't think we need to check for `has-label` here.", "reference": "The message for this check used the existence of a label to determine the output, which doesn't work with the current schema. So I updated it since the data only needed to know a label was present and not what it was." }, { "prediction": "I think this should be `app.ProjectId != claims.Role.ProjectId`", "reference": "nit: \"The current project does not have requested application\"" }, { "prediction": "I think this should be `[id]` instead of `[id]`.", "reference": "Extend Unit test for this class" }, { "prediction": "I think this should be `DD_APPSEC_IPHEADER`", "reference": "This is this a copy / paste error from above." }, { "prediction": "I think this class should be `Variable` instead of `TypeInterference`.", "reference": "this package has to be renamed to `typeinference`" }, { "prediction": "I think this should be `TestCase.assertEqual(user.providerType, \"anon-user\");`", "reference": "This cancels the above null-check I guess." }, { "prediction": "I think this should be `RPOP_TIMER_INTERVAL_IN_MINIS` and `RPOP_TIMER_INTERVAL_IN_MILLIS`", "reference": "change to timerIntervalInMillis" }, { "prediction": "I think this should be `role_none` or `role_none_comment`.", "reference": "`any rules` should be `any roles`" }, { "prediction": "Why is this change needed?", "reference": "Why does the method need to be renamed? I would just keep the old name and update the other uses (which are only tests). That way, we can reduce code duplication." }, { "prediction": "Why not use `keyconf.KeyConfigParser(None, None)`?", "reference": "I'm not sure if this is going to work - I think it's fine to keep them hardcoded here, as the statusbar can still show `:`, `/` and `?` even if the key is rebound." }, { "prediction": "I don't think this is needed.", "reference": "@tmetzke shouldn't we replace this library with the `2.12.1` instead of removing it?" }, { "prediction": "I think this should be `NumTotalSectors` or `NumTotalSectors`?", "reference": "uint64 seems excessive here. Should we reduce to a uint32 @whyrusleeping ?" }, { "prediction": "Why is this removed?", "reference": "Hmm, I thought this was getting used. These are used elsewhere as a cached value (in `svc deploy` it's `o.targetApp`) but I guess since storage doesn't actually need to validate that the app exists, just that there are local services, we never used it." }, { "prediction": "I think this should be `r.RemoteAddr` instead of `r.RemoteAddr`.", "reference": "To keep it simple, how would you feel about just using r.RemoteAddr? Since every request comes through here I want it to be as lean as possible. Frankly I'm OK with the port showing up in the log; maybe it'd even be useful to someone." }, { "prediction": "I think this should be `a.grantFoundationBonus(epochNum)`", "reference": "grant bonus depends on both `admin{}` stored in statedb, and `P2Start/End` in local struct, which is kind of weird at Kamchatka height, we add the bonus Start/End epoch into `admin{}`, so it solely depends on `admin{}` stored in statedb" }, { "prediction": "Why is this change needed?", "reference": "Use single quote to wrap the str." }, { "prediction": "I think this error should be `permission_getAccountsWhitelist` and `perm_getNodesAllowlist`", "reference": "Is the plan to rename this later?" }, { "prediction": "I think this should be `!in_array($this->strategy, $this->strategies) && !in_array($this->strategy, $this->strategies) {`", "reference": "Is there a reason why we need a special case for Email at this point? Is the idea that other methods can turn into Email even if it's not configured as a top-level option?" }, { "prediction": "I think this should be `panic(\"dir unexpectedly empty\")`", "reference": "This wording is a bit ambiguos, I first thought it meant the directory has no entries in it. maybe \"dir\" -> \"dir string\"?" }, { "prediction": "I think this should be `bool` instead of `bool`.", "reference": "Why do we need both `HPX::m_hpx_initialized` and `HPX:: m_was_initialized`?" }, { "prediction": "I think this should be `len(info.RPCName) == 0` instead of `len(info.RPCAddress) == 0`", "reference": "also check RPCName?" }, { "prediction": "I think this should be `WebSessionOAuth2ServerAuthorizationRequestRepository` instead of `WebSessionOAuth2ServerAuthorizationRequestRepository`", "reference": "Remove unused import" }, { "prediction": "I think this should be `true` instead of `false`.", "reference": "I assume there will never be a scenario where justValidate is expected to be true on a restart" }, { "prediction": "I think this should be done in a separate PR.", "reference": "Report listeners are synchronized, even 'though the cache is thread-safe... I've not profiled it, but it may be a cause of contingency. Any better way around this? Also, do listeners **really** need to be synchronized? Can't we just make them thread-safe?" }, { "prediction": "I think this should be `compiler: 'gcc'`", "reference": "I don't think this is correct. When `compiler` is not given in `.travis.yml`, the announcement will be `--version`, which results in \"`command not found`\" (though not critical), and the cache slug will lack this information (also not critical)." }, { "prediction": "I think this should be `args = []` instead of `args = []`", "reference": "Why do this rather than `args = []` in the function signature?" }, { "prediction": "I don't think we need to freeze here.", "reference": "I think we probably *should* do validation of whether there is a suitable implementation if local-validation is true. I'm not sure how useful that actually is though" }, { "prediction": "I don't think we need to do this.", "reference": "@StrikerRUS here may need to concat two data by col." }, { "prediction": "Why is this change needed?", "reference": "Why the space?" }, { "prediction": "I think this should be `@ConfigTitleSection(keyName = \"zalcanoTitle\", description = \"\", position = 0);`", "reference": "please resolve the extra indentation" }, { "prediction": "I think this should be `!ReferenceEquals(document.Id, previous.Id);`", "reference": "More proof that this check is needed always." }, { "prediction": "I think this should be `m_al_comms.clear();` instead of `m_al_comms.clear();`", "reference": "`m_al_comms` now contains smart pointers." }, { "prediction": "I think this should be `Instance.QuoteValue(defaultValue);` instead of `Instance.QuoteValue(defaultValue);`", "reference": "Did you do a test run with the compare script? I'm nervous about what happens on all the generators..." }, { "prediction": "I think this should be `c.nc.RemoteAddr()`?", "reference": "For a client, we store host, as string c.host. That is what we use for monitoring and statsz. Not sure if its useful here or not. Looks like probably not." }, { "prediction": "Why is this change needed?", "reference": "This change is suspicious. Why did the number of partitions increase?" }, { "prediction": "I don't think we need to check if the user is admin or not.", "reference": "I'm still new to this area, so please forgive what may be a stupid question: When would this be false? And do we have a test for that situation?" }, { "prediction": "I don't think we need this change.", "reference": "Should there be any changes to this file at all?" }, { "prediction": "I think this should be `automationPolicy` instead of `autoPolicy`.", "reference": "The only field being used is the KeyType; Instead, we can probably just make a `keyType` variable here." }, { "prediction": "I think this should be `options.credentials = options || {};`", "reference": "This should be done by code-gen change happening in the hydra repo. I am tweaking it just to get CI into a 'passing' state" }, { "prediction": "I think this should be `Optional. Render options`.", "reference": "Cleaned up when I originally added support for passing `screenContext` here (and later `viewContext`) but that was removed." }, { "prediction": "I think this should be `const char *name = nullptr;`", "reference": "This looks like a bunch of whitespace fixing that's unrelated. Can you revert?" }, { "prediction": "Why is this removed?", "reference": "should be removed instead" }, { "prediction": "I think this should be `true` instead of `false`.", "reference": "should use randomization ?" }, { "prediction": "I think this should be `nil`", "reference": "returning nil because we want to mayactl to exit with 0 status code." }, { "prediction": "I think this should be `application/json; charset=utf-8` instead of `text/plain`.", "reference": "Is this change relevant to the PR? (and I believe we should use `text/plain` considering the fact that it can be displayed using web browsers...)" }, { "prediction": "I think this should be `[Flags]` instead of `[Flags]`", "reference": "`[Flags]` is now auto-generated by an argument to the `EnumHint`. (The attributes happen to come out in this order. I don't think it's worth controlling the order.) #Resolved" }, { "prediction": "I think this should be `log.Info(\"using resource updates where applicable\")`", "reference": "I think same here - in general we don't need to use Setters / Getters since configParams isn't a public API." }, { "prediction": "I think this should be `fmt.Sprintf(\"%s\", pdata)`", "reference": "Why using `fmt.Sprintf` where `fmt.Sprint` would do the work (notice no `f` in function name)?" }, { "prediction": "I think this should be `if ariaCurrent != None: attrs['current'] = ariaCurrent else: attrs['current'] = ariaCurrent if ariaCurrent != None else attrs['current']`", "reference": "Extraneous blank line." }, { "prediction": "I don't think we need to change the error message.", "reference": "nit: syntax : neither -> nor" }, { "prediction": "Is there a reason we don't have a spanContext?", "reference": "Is it safe to assume that these two keys are always present? `this[string]` will throw a `KeyNotFoundException` if they are not." }, { "prediction": "I think this should be `exflow.getFlowDefinitionId() > 0 ? exflow.getFlowDefinitionId() : flowId`", "reference": "Is the `flowDefinitionId` sufficient to uniquely identify the flow or does it need to be the tuple `` ?" }, { "prediction": "I think this should be `self` instead of `self`.", "reference": "Shouldn't it be in the reverse order? `DateTime::createFromInterface()` returns `self` and accepts `DateTimeInterface`." }, { "prediction": "I don't think we need to check if the file type is set in the file object.", "reference": "this check is now redundant. The rest of the function downwards basically does the same thing but with safer checks." }, { "prediction": "Why is this change needed?", "reference": "Please could you remove the useless space." }, { "prediction": "I think this should be `assert(arc.target >= 0 || arc.target < Integer.MAX_VALUE)`", "reference": "What's the point of this block (and isn't it effectively dead code)?" }, { "prediction": "I think this should be `ENV[\"DISCOURSE_SSO_SECRET\"]`", "reference": "Put a comma after the last parameter of a multiline method call." }, { "prediction": "I think this should be `@job(version_strategy=SourceHashVersionStrategy)`", "reference": "Newline at end of file plz" }, { "prediction": "I think this should be `clusterv1alpha3` instead of `clusterv1alpha3`", "reference": "Can this be refactored to avoid including the aws sdk in the types that we expose? I know it's not being exposed directly through the types we expose, but I do worry that it might make it easier to accidentally do that in the future and not realize it as easily." }, { "prediction": "I think this should be `time()` instead of `time()`.", "reference": "Hi thomas, i would propose to indicate in the name, that only the indextime is updated, otherwise somebody might think the whole items is getting updated. I would propose something like \"updateIndexTimeByItem(Item $item)\"" }, { "prediction": "I think this should be `isinstance(element, str)` instead of `isinstance(element, dict)`", "reference": "This is not the right exception class. There is an InvalidSelectorException class that covers bad locators." }, { "prediction": "I think this should be `#include `.", "reference": "I assume this came from format?" }, { "prediction": "I think this should be `boolean` instead of `boolean`.", "reference": "I'd suggest a default value of `false` just to make sure existing tasks are ok when they get deserialized after an update to a version containing this code." }, { "prediction": "I think this should be `log.CDebugf(ctx, \"Trying to decrypt with keys = %s\", dumpConfig().Sdump(keys))`", "reference": "Do we really need this? Seems like it would pollute the logs pretty badly." }, { "prediction": "I think this should be `Vector.Count` instead of `Vector.Count`.", "reference": "`Vector.Count` should Jit to const when intrinsic; not sure when `Vector.IsHardwareAccelerated == false` ; however we know `readonly static int` does Jit to const." }, { "prediction": "I think this should be `from kinto.core.utils import sqlalchemy` instead of `from kinto.core.utils import sqlalchemy`", "reference": "Can we use a skipIf decorator instead?" }, { "prediction": "Line is too long. [103/80]", "reference": "Missing version tags" }, { "prediction": "I think this should be `plugins.delete(:validate_resolve_reference)` instead of `plugins.delete(:validate_resolve_reference)`", "reference": "I think this should also filter out `validate_resolve_reference` hooks." }, { "prediction": "Why is this change needed?", "reference": "unrelated, but required fix as metrics branch got broken with the latest main->metrics merge and conflict resolution." }, { "prediction": "Why is this changed?", "reference": "Feel free to remove this line" }, { "prediction": "I don't think we need this link anymore, but I think it's better to use `I18n.t(\"shared.subscriptions.single_user\")` instead of `I18n.t(\"shared.subscriptions.single_user\")`.", "reference": "~~Should this match the key updated above?~~ :+1:" }, { "prediction": "I think this should be `defer f.Close()`", "reference": "`gofmt` allows a more compact form `defer func() { _ = f.Close() }()` or just add `// nolint:errcheck` before `defer`." }, { "prediction": "Why is this change needed?", "reference": "collateral is in FIL" }, { "prediction": "I think this should be `LoadOrStore(nodeID, rChanBufSize)` instead of `LoadOrStore(nodeID, rChanBufSize)`", "reference": "We should not create channel of node which are not connected." }, { "prediction": "Why is this needed?", "reference": "I think the docstring should say something like \"Alias for the `source` option\" or something similar." }, { "prediction": "I think this should be `@JsonProperty(\"recycling_instructions_to_discard_fr\")` or `@JsonProperty(\"recycling_instructions_to_recycle_fr\")`.", "reference": "Please use properties without suffix `_fr` so they can work across different languages as @teolemon mentioned" }, { "prediction": "I think this should be called `destroy_request` instead of `start_request`.", "reference": "Declaration here is `static` but the definition at the bottom is non-static?" }, { "prediction": "I think this should be `Content-MD5` or `Content-MD5`", "reference": "Hi @myml, thanks for the contribution! `blob` and `blob/driver` are both in the same module, so you shouldn't need to split this change up into multiple Pull Requests. Also, I'd like to see it working, including the implementation for `s3blob` and `gcsblob` (these should be easy, just pass-through to the provider) and `fileblob` (might be trickier...), and a test in `drivertest/drivertest.go`." }, { "prediction": "I don't think we need to change the `NodeIPv4Addr` and `NodeTransportIPv6Addr` here.", "reference": "Was it a bug?" }, { "prediction": "Why is this removed?", "reference": "# `attr_value['string'] is not None` probably not required as `attr_value['string'] == value` check is already being done" }, { "prediction": "I think this should be `_last_hovered_link` instead of `_last_hovered_link`.", "reference": "You're accessing private variables here - `last_hovered_link` should be public in `TabData`. As for `tabbed_browser._now_focused`, I think you can use `tabbed_browser.widget.currentWidget()` instead." }, { "prediction": "I think this should be `@invitation = Invitation.find(invitation_id)` instead of `@invitation.email`", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "Is this needed?", "reference": "We should file a bug for this - we don't need the extensions class if there are no operations on the client" }, { "prediction": "I think this should be `mounter.MetricsProvider = newMetricsCsi(volumeHandle, dir, csiDriverName(driverName))`", "reference": "Is it possible to import from k8s instead of copy in? :)" }, { "prediction": "Why is this change needed?", "reference": "`@param float` can be dropped here." }, { "prediction": "Why is this change needed?", "reference": "maybe we can leave this change un-reverted." }, { "prediction": "Why is this change needed?", "reference": "I wouldn't make MethodDeclarator an AccessNode, nor an Annotatable. It's the MethodDeclaration that can be annotated, and has info about the modifiers, and is already an AccessNode" }, { "prediction": "I think this class should be `@Override`.", "reference": "delete this class" }, { "prediction": "I think this should be `[1-9][0-9]+|0[1-9]` instead of `[1-9][0-9]+|0[1-9]`", "reference": "Replacing `+` (1 or more) with `*` (0 or more) would've also done the trick." }, { "prediction": "Why is this needed?", "reference": "I've been meaning to fix this for a while. Thanks." }, { "prediction": "Why is this needed?", "reference": "This is adding multiple processor pipelines. I guess you wanted to add multiple processors to the same, single pipeline?" }, { "prediction": "I think this should be `scapy.compat import *`", "reference": "If you need str(x[0]) here, you'll probably need str(x) the line after that I suppose. Also, shouldn't we use `raw()` here instead of `str()`?" }, { "prediction": "I think this should be `3600000`.", "reference": "3.6 seconds? what does it stand for?" }, { "prediction": "I don't think we need a `@return` here.", "reference": "If the command fails, is stdout nil or \"\"?" }, { "prediction": "I think this should be `/fakepath/{subscriptionId}/{resourceGroupName}/{id}?api-version={apiVersion}`", "reference": "Why is api-version now removed in the generated code?" }, { "prediction": "I think this should be in `mmdet.utils.registry`", "reference": "We may register all built-in optimizers of PyTorch here to simplify the builder." }, { "prediction": "I think this should be `&components = ns->components;`", "reference": "No need for this new variable." }, { "prediction": "I think this should be `c.setState(c.state, c._nextState);`", "reference": "doesn't this enqueue a double render or is that safeguarded somehow" }, { "prediction": "Why is this change needed?", "reference": "But now you may get DATA RACE reports because c.acc is sometimes changed. I wonder if we should not rework that whole sending subs through route." }, { "prediction": "I think this should be `#ifdef ADIOS_HAVE_PHDF5`", "reference": "Use `ADIADIOS2_HAVE_HDF5`, not `ADIOS_HAVE_PHDF5`" }, { "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "Would be nice to put this in a separate context named `\"with a string and a non-string\"` (since that's what it is -- it's definitely not a non-string and a string!)." }, { "prediction": "Why is this change needed?", "reference": "Should MAX_PERTABLE_ENTRY here be 10 ?" }, { "prediction": "I think this should be `Encoding.ASCII.GetBytes(\"\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n\")`", "reference": "Should move these out of frame into a static class? Similar to reason phrases?" }, { "prediction": "I don't think we need to check for `UseLane` here, but I think it's better to check if `instruction.type == TurnType::UseLane`", "reference": "That means we still create `UseLane` instructions but threat them like `Suppressed`? Can we maybe change this in the pre-processing so that we will just emit `Suppress` instructions in these cases?" }, { "prediction": "Why is this removed?", "reference": "no need to move here, iotex-proto is outside of iotex-core and considered same as iotex-address, go-pkgs" }, { "prediction": "I think this should be `#if defined(LINUX) && defined(X86_64)`", "reference": "Looks like a clang-format style violation: should turn Travis red." }, { "prediction": "I don't think we need this setting anymore.", "reference": "I think we need some YARD docs here, particularly to list all the color symbols that are valid. Otherwise users will have to look at the source to discover that." }, { "prediction": "I think this should be `const siteInfo = select( STORE_NAME).getSiteInfo() || {};`", "reference": "Not sure if this needs a doc block or not since it's completely internal, but for cleaning this up. (@felixarntz docs?)" }, { "prediction": "I think this should be `-Wno-deprecated-declarations -Wno-invalid-offsetof -Wno-invalid-offsetof -Wno-deprecated-declarations -Wno-invalid-offsetof -Wno-deprecated-declarations -Wno-invalid-offsetof -Wno-deprecated-declarations -Wno-invalid-offsetof -Wno-deprecated-declarations -Wno-invalid-offsetof -Wno-deprecated-declarations`", "reference": "The change here is to address what exactly?" }, { "prediction": "I think this should be `SignedURL` instead of `SignedURL`.", "reference": "Is this really an Option? IIUC, you compute it automatically for the URLOpener case, why would we require a user to fill it in when using the constructor? I.e., can't we drop this and use `adal.MSIAvailable` instead? If that call is expensive, cache it on `bucket`, not `Options`." }, { "prediction": "I think this should be `d_size = 0;` instead of `d_numOnBits = 0;`", "reference": "Was this done automatically or by hand?" }, { "prediction": "I think this should be `current_group.remove_target(target, desired_group)` instead of `current_group.remove_target(target, desired_group)`", "reference": "This looks like it will only work for the first child, since after that we've overridden `desired_group`. Should we have a separate variable for this?" }, { "prediction": "I think this should be \"UNASSIGNED-cache-file-error\" instead of \"UNASSIGNED-cache-file-error\".", "reference": "Should this be a constant somewhere?" }, { "prediction": "I think this should be `InternalsVisibleTo(\"OpenTelemetry.Instrumentation.GrpcNetClient\" + AssemblyInfo.PublicKey)`", "reference": "nit: sort alphabetically." }, { "prediction": "I think this should be `paramsPrefix`", "reference": "Now, It's redundant, I suppose." }, { "prediction": "I think this should be `go.uber.org/yarpc/peer/peerlist/v2.Implementation`.", "reference": "nit: The format recognized by tooling is `// Deprecated: [..]` so you likely want this to be, // Deprecated: Use \"go.uber.org/yarpc/peer/peerlist/v2\".Implementation instead." }, { "prediction": "I think this should be `log.Infof(\"An issue occurred reading telemetry entry for: %s\", bootstrapID)`", "reference": "nit: 1. when formatting input strings, make sure to place them in quotes so we could identify white space issues. i.e. '%s' 2. If there is untyped, non-nil error, you want to log the error string as well." }, { "prediction": "I think this should be `[DllImport(\"Datadog.Trace.ClrProfiler.Native.dll\")]` instead of `[DllImport(\"Datadog.Trace.ClrProfiler.Native.dll\")]`", "reference": "I believe this can be fixed with the original code if you just omit the \".dll\" file extension so it reads `[DllImport(\"Datadog.Trace.ClrProfiler.Native\")]`. On Windows it would look for `Datadog.Trace.ClrProfiler.Native.dll` and Linux/Mac it would look for `Datadog.Trace.ClrProfiler.Native.so`." }, { "prediction": "I think this should be `prefs.getBoolean(UserPreferences.PREF_MOBILE_UPDATE_OLD, false)`", "reference": "couldn't we just read the boolean as a string (I would assume that this return \"true\" or \"false\"), migrate if to its new value and keep using the same pref key?" }, { "prediction": "I don't think this is needed.", "reference": "If these variables are only used in main function, move these to the beginning of that function. If there is a foreseeable reason to have them as global statics just let me know." }, { "prediction": "I think this should be `nameof(serviceProvider)` instead of `nameof(region)`", "reference": "This one was wrong." }, { "prediction": "I don't think this is a good idea, but I think it would be better to use `NodeChange` instead of `NodeChange`.", "reference": "What happens if nodes throughout a hierarchy are modified (as they would be)? It looks like we're going to `Reset` once for each `NodeID` affected." }, { "prediction": "Why is this removed?", "reference": "> Note that allocation of vmheap fails upon initializing dynamoRIO 64 on WoW64 processes. Thus, we need to pass -reachable_heap to avoid having to make this allocation. This should be solved by changing the default `vmheap_size` to be much smaller than 8GB for x64 DR inside WOW64." }, { "prediction": "Use the new Ruby 1.9 hash syntax.
    Space inside { missing.
    Space inside } missing.", "reference": "Is it really worth expanding our public API for this? After all, isn't calling this the same as calling `notification.fully_formatted(...).lines`? If so, I'd rather not widen our API (and thus, increase our maintenance burden) when it's so simple to get all the lines already." }, { "prediction": "I think this should be `SnippetSetRunner.SNIPPET_RESOURCE_ROOT`.", "reference": "Is it necessary to keep this class around just to define this constant? Or can we place it somewhere else?" }, { "prediction": "I think this should be `PolicyName` and `PolicyNamespace`", "reference": "Question - do we cache NetworkPolicy itself? If so, here we can point to NetworkPolicy?" }, { "prediction": "Why is this removed?", "reference": "For my view, `Register` means the process of **insert node resource to etcd through api-server**, which is called by upstream rather than here, how about changing the func name to `OnConnected`?" }, { "prediction": "I think this should be `true` instead of `false`.", "reference": "I would prefer an active verb for this property, e.g. `initializeTelemetry`. The reason is that this property refers to something the engine does once on startup. Other properties that use passive voice (e.g. `authorizationEnabled`) refer to a state of the engine during its lifetime." }, { "prediction": "I think this should be `Method.ContainsTimeSpan` instead of `Method.ContainsTimeSpan`.", "reference": "please use new line to maintain reasonable line width" }, { "prediction": "I think this should be `if ta == nil { return }`", "reference": "I would skip this check or add an internal server error response." }, { "prediction": "I don't think we need to do this in `create_dist` and `create_build_dist`", "reference": "missing `{` here (and then `}` after `notary_password = config.notary_password`); it's only going to do the first one" }, { "prediction": "Why is this change needed?", "reference": "This is odd because it's actually in our generated SiteSettingsPath, not in the SiteLocalSettingsPath (wp-config-ddev.php). Are these two files swapped somehow? I'd expect SiteSettingsPath to be wp-config.php and SiteLocalSettingsPath to be wp-config-ddev.php. BTW, I'm *way* ok with renaming that to SiteDdevSettingsPath." }, { "prediction": "I think this should be `kythe.io/kythe/proto/extraction_config_go_proto`", "reference": "It seems like this must necessarily be a stopgap. Can you please add a TODO(#xyz) to point to the appropriate issue?" }, { "prediction": "why is this needed?", "reference": "Is the return signature necessary since we never actually return if there is a problem (I'm referring to the call to `logrus.Fatalf`). Let's pick a pattern and stick with it." }, { "prediction": "I think this should be `capIsNew: false`", "reference": "@btecu why is this override needed here? I'm not seeing a `new` being used here." }, { "prediction": "I think this should be `if err != nil {`", "reference": "Should it not be more something like: `MaxAccountConnectionsExceeded` here?" }, { "prediction": "I think this should be `ParseAndValidate(t, \"-compute_service_account\", \" default\").ComputeServiceAccount`", "reference": "minor: use a non-default CE service account for testing (since default is handled in a specific way in the code)" }, { "prediction": "I think this should be `./512` instead of `./512`", "reference": "This is how I ran the 512MiB test. It's probably too much data for a fixture, and makes for longer functional tests (although still less than a minute on my laptop)." }, { "prediction": "Line is too long. [98/80]", "reference": "So we weren't able to hide the fact that the file wasn't pre-generated and had to introduce this \"option\" to detect that?" }, { "prediction": "Why is this needed?", "reference": "Agree that exporting these maps is the best tradeoff, just registering my ongoing discontent with the lack of `const` collections." }, { "prediction": "I think this should be `self._tab.run_js_async(\"\"\" { ... }\")`", "reference": "This could probably use `const` as well?" }, { "prediction": "Why is this changed?", "reference": "it doesn't look like these need to be exported?" }, { "prediction": "I think this should be `fmt`", "reference": "I think you should remove \"fmt\" here. And change `fmt.Errorf` to `errors.Errorf`." }, { "prediction": "I think we should add a `default: \"\", null: false` column to ensure that we don't have a `default: \"\", null: false` column.", "reference": "Here's the `resources` attribute @jferris. I'm not against renaming `Product` to `Resource`, and this one... something else." }, { "prediction": "Why do we need this?", "reference": "If the context is unused, this is equivalent to `var wg errgroup.Group`." }, { "prediction": "I think this should be `FRAGALIGNRATIO` instead of `FRAGALIGNRATIO`", "reference": "very minor: I'd prefer these two added rows are switched so that fragsizeIsMinimum directly follows fragsize" }, { "prediction": "I don't think we need to check for `localhost` or `127.0.0.1` here.", "reference": "Given that 115 returns `True`, why would this be `False` here?" }, { "prediction": "I think this test should be removed.", "reference": "Please move this test method just below `oauth2LoginWithOneClientConfiguredThenRedirectForAuthorization()`" }, { "prediction": "I think this should be `c_TimeInfinite` instead of `c_TimeInfinite`.", "reference": "Why this new configuration?" }, { "prediction": "I think this should be `dupe.duplicate()` instead of `dupe.get(new byte[dupe.remaining()])`", "reference": "I don't think that we need to check `hasArray` here. I think the reason why this didn't previously check `hasArray` is that the array passed to `DataByteArray` must start at offset 0 and be valid through the array length, so a copy was needed in almost every case. It may be simpler to change this to use `ByteBuffers.toByteArray` and pass the result to create `DataByteArray`." }, { "prediction": "Why is this change needed?", "reference": "`spanReference` -> `baggage` " }, { "prediction": "I think this should be `/-/verdaccio/logo.png` instead of `/-/verdaccio/logo.png`", "reference": "Why the `/-/verdaccio/` ?" }, { "prediction": "I think this should be `enableAddons: true` instead of `enableAddons: true`", "reference": "Has been waiting for a million years " }, { "prediction": "I don't think we need to add `Date` to the message.", "reference": "Minor grammar detail: the 'than' is unnecessary" }, { "prediction": "I think this should be `self._internal._sdf.select(scol).head(2)`", "reference": "I think you can just simply fix this line to `self[:2].to_pandas()`" }, { "prediction": "I think this should be `/se/cdp/` instead of `/se/cdp/`", "reference": "if we are returning the `ws` here when passing in `se:cdp` we can just return it straight or do we have to make a request to get the `ws` address?" }, { "prediction": "I think this should be `assets/js/googlesitekit/datastore/site`", "reference": "I could add a resolver for this (like above) but it seems more sensible to just change the one reference!" }, { "prediction": "I think this should be `final long actualTimeSinceParent = timestamp - parentTimestamp;` and not `final long actualTimeSinceParent = timestamp - parentTimestamp;`", "reference": "not sure \"actual\" adds value - secondsSinceParent is probably closer." }, { "prediction": "I think this should be `search_builder.with(user_params).facet(facet_field).merge(extra_controller_params)` instead of `search_builder.with(user_params).facet(facet_field).merge(extra_controller_params)`", "reference": "Line is too long. [94/80]" }, { "prediction": "I think this should be `min_items_error` instead of `min_items_error`.", "reference": "The error should be `At least :number items are required`" }, { "prediction": "I think this should be `HandleBlockPropose` instead of `HandleConsensusMsg`.", "reference": "singleCaseSwitch: should rewrite switch statement to if statement (from `gocritic`)" }, { "prediction": "I think this should be `mdDecryptionKeyGetter`", "reference": "Could combine this with `encryptionKeyGetter` to have a single `keyGetter` interface. I'm not sure which way is better." }, { "prediction": "Why is this needed?", "reference": "Is there any security issue here? If we integrate with Hive security (and I don't know if we have or not) is there some notion of re-authentication at connection time?" }, { "prediction": "Why is this removed?", "reference": "Does this mean we do not support writeConcern on `createCollection`?" }, { "prediction": "I think this is a bug, but I don't think we need to change it.", "reference": "I guess `sid` was for `sessionID`, but now it looks strange: `sid.ID`." }, { "prediction": "I think this should be `s.scope.SecurityGroups()[infrav1.SecurityGroupAPIServerLB].ID` instead of `s.scope.SecurityGroups()[infrav1.SecurityGroupControlPlane].ID`", "reference": "We'll need `infrav1.SecurityGroupBastion` as well" }, { "prediction": "I think this should be `f.Features().PublicLink`?", "reference": "This `fileName` should probably be `remote` and be relative to the Fs root as per normal rclone usage." }, { "prediction": "Why is this change needed?", "reference": "That way we are back to having just one index on k_0 So we can really compare the execution times with and without re-indexing" }, { "prediction": "I think this should be `[a-zA-Z0-9]`", "reference": "Expression that uses a negation pattern to exclude all characters that aren't in the expression." }, { "prediction": "I think this should be `Rpc-Request-Header` instead of `Rpc-Respond-Request-Header`.", "reference": "Similar to my suggestion for HTTP, let's remove this and use `ServiceHeader` instead." }, { "prediction": "I think this should be `if commandSet == targetGlobalCommandPath && commandSet == targetGlobalCommandPath`", "reference": "The serviceDirOnHost[0:1] was completely wrong. It wasn't just Windows, glad you got this fixed!" }, { "prediction": "I think this should be `5 * time.Second`", "reference": "Would membership take 10+ seconds to detect the failed node?" }, { "prediction": "I think this should be `os.path.exists(path)`", "reference": "hmm, in this case perhaps the whole try-except could be removed altogether? because if the file does not exist, it's already returning `None`. In any other case it should actually probably fail with the exception, no?" }, { "prediction": "I think this should be `.mysterium` instead of `.mysterium`", "reference": "This function does not need to be public" }, { "prediction": "I think this should be `hasExistingTag`?", "reference": " Any chance we can get a CSS class for this? I know it's just in one place but feels like a dangerous precedent to set." }, { "prediction": "I think this should be `if (this.Extensions.ContainsKey(\"nextMethodName\") && this.Extensions.ContainsKey(\"nextLinkMethod\") && this.Extensions.ContainsKey(\"nextMethodName\") && this.Extensions.ContainsKey(\"nextMethodName\") && this.Extensions.ContainsKey(\"nextMethodName\") && this.Extensions.ContainsKey(\"nextMethodName\") && this.Extensions.ContainsKey(\"nextMethodName\") && this.Extensions.ContainsKey(\"nextMethodName\") && this.Extensions.ContainsKey(\"nextMethodName\")", "reference": "> && this.Extensions.ContainsKey(\"nextMethodName\") [](start = 96, length = 48) From line 124, looks like we don't need `&& this.Extensions.ContainsKey(\"nextMethodName\")` condition or we don't need line 124 #Closed" }, { "prediction": "Why is this removed?", "reference": "Moving this code from compat to core shaves 47 bytes out of compat and only adds 6 bytes to core so I thought it was worth it." }, { "prediction": "Why is this removed?", "reference": "Please use \".NET Core 3\" - i'm trying hard to use one form, and this is the one MS advices" }, { "prediction": "I think this should be `params.Ctx.Done()` instead of `params.ctx.Done()`", "reference": "Unrelated to this change, but this is a fix for when TestDoStartCgroupInitHappyPath has a failure after the test goroutine has already exited." }, { "prediction": "I think this should be `check_scrolled` and `check_not_scrolled`", "reference": "Hmm, I'd really expect this to work, and yet it doesn't. I'll investigate later, though it might get Monday until I get the time." }, { "prediction": "I think this should be `const std::int64_t i = 0; i < support_indices.get_count(); i++) {`", "reference": "Does this changes affect process building dynamic libraries anyhow?" }, { "prediction": "I don't think we need to add the `PPIGenericFldHdr` here.", "reference": "Could you limit what is imported here?" }, { "prediction": "I think this should be `save_file(tmp_file, zip_file_content)` instead of `save_file(tmp_file, zip_file_content)`", "reference": "just to clarify - on line 1074 we update `zip_file_content` for non-local lambdas, but never store it, which means lambda never picks it up" }, { "prediction": "I don't think we need to add the type code here.", "reference": "Golang naming convention is to use camel case `icmpPktWithTypeCode` Often the linter will complain" }, { "prediction": "Why is this removed?", "reference": "We can do away with assigning the response here too." }, { "prediction": "I don't think we need to change this to `naturalHeight + 3`", "reference": "Bumping the newViewportHeight" }, { "prediction": "I don't think we need to add the `secondaryy` link here.", "reference": "Is this change correct? Looks like a typo and not sure this should be changed?" }, { "prediction": "I think this should be `_load_reporter_from_class`", "reference": "I checked the tests coverage and strangely it look like those three lines are not covered (?!). Do you have the same result on your side ?" }, { "prediction": "Why is this removed?", "reference": "nit: please try to avoid changing end of the file (it adds a noise to the code review, but does not provide too much value)" }, { "prediction": "I think this should be `modelsAllOfOnXmsAzureResources` instead of `modelsAllOfOnXmsAzureResources`.", "reference": "I don't see the \"only\" part reflected in the code but maybe I'm missing it. Also, the indentation is misleading: the `.SelectMany` calls are perfectly aligned but are *not* operating on the same \"level\". I'd expect the second `SelectMany` to be on the same height as the inner `Where`, just break `pathObj => pathObj.Where` and lines won't be that long." }, { "prediction": "Line is too long. [89/80]", "reference": "It seems like most of these will never be nil, are they optional just in case?" }, { "prediction": "Why is this change needed?", "reference": "`.addColumn(\"c1\", IntegerType.INT, true)` means `PkHandle=true`, maybe should add `.setPkHandle(true)` in line 31" }, { "prediction": "I think this should be `(Long) obj.longValue()`", "reference": "how about `Cannot encode row key with non-integer type` directly?" }, { "prediction": "I think this method should be called `fetchUnfinishedExecutions` instead of `fetchUnfinishedExecutions`.", "reference": "The method names `fetchUnfinishedExecutions` and `fetchUnfinishedFlows` are too similar to each other. Would it be better to use the name `fetchUnfinishedFlowsMetadata` since you are only fetching metadata info about the flow?" }, { "prediction": "I think this should be `pkg install -y libevent msgpack libssh`", "reference": "Note that `sudo` is not available by default on BSDs; there are a few places in the codebase here where that's explicitly worked around by using `su`." }, { "prediction": "I think this should be a constant.", "reference": "ultra nit: missing Oxford comma :P" }, { "prediction": "I think this should be `# doctest: +SKIP` instead of `# doctest: +SKIP`", "reference": "This is not supported in Spark 3.0.0-rc2 yet. I'd skip this for now." }, { "prediction": "I think this should be `Query` instead of `Query`?", "reference": "BLOCKING: Why does `Query` return an `*exec.FunctionSignature`?" }, { "prediction": "I think this should be `resetCachesWithoutShutdown`", "reference": "please move this down to immediately above the assignment to `c.dirtyBcache`" }, { "prediction": "I think this should be `watch` instead of `watch`?", "reference": "Don't need the `, err` part since you've already handled it." }, { "prediction": "I think this is a bug, but I don't think it's a good idea to do this.", "reference": "Please add two additional SECTIONs that show that this also works if the dative bond is in the reactant (reaction SMARTS `[O:1]->[H+]>>[O:1].[H+]`) or in the agents (reaction SMARTS `[O:1][H]>N->[Cu]>[O:1].[H]`)" }, { "prediction": "I think this should be `return false`", "reference": "What happens if the certificate rotation fails and we are prematurely removing this file?" }, { "prediction": "I think this should be `s.once.IsRunning()`?", "reference": "does this change belong here?" }, { "prediction": "I think this should be `w.workflowDir`, not `w.workflowDir`.", "reference": "This returns an error" }, { "prediction": "I think this should be `oneof(legacy,nft);legacy;local`", "reference": "If we think we might someday write a native nftables backend, do you think it would make sense to just use generic dataplane configuration? e.g, `dataplane = iptables | ebpf | nftables`, but for now selecting `nftables` uses iptables in nft compat mode?" }, { "prediction": "why not use `headTipSetAndState.TipSet` instead of `headTipSetAndState.TipSet`?", "reference": "Looks like that helper function is general enough that it should reside in testhelpers" }, { "prediction": "I think this should be `if app.DisableSettingsManagement { return nil }`", "reference": "This isn't incorrect IMO, but I think it would be better to fix this in drupal7PostStartAction and also in drupal6PostStartAction. It seems to me like those were both somehow neglected on this. Use drupal8PostStartAction as example. Congrats on your first golang PR! Please make sure to test it manually." }, { "prediction": "Line is too long. [98/80]", "reference": "I'd like to ensure that the error message at least has some reference to the flag that is not allowed. Something like `/ERROR(.+)--hosts/` would work." }, { "prediction": "I don't think we need this change.", "reference": "Should we say \"specifying two public subnets\"?" }, { "prediction": "I think this should be `CheckImmutableFields` instead of `CheckImmutableFields`.", "reference": "Issue number? When? Why?" }, { "prediction": "I don't think we need to import speech here.", "reference": "You should not rely on `PitchCommand` being imported into speech. Please import it from `speech.commands`." }, { "prediction": "Why is this change needed?", "reference": "Is this a constant used in the Nessie project itself? If so, perhaps you might consider a follow up for adding `NessieCatalogProperties` class at some point, to help make them more clear to users looking to adopt Nessie coming from the Iceberg repo itself " }, { "prediction": "Why is this needed?", "reference": "maybe we should rename: MinTaskID -> MinTaskIDExclusive, MaxTaskID -> MaxTaskIDInclusive," }, { "prediction": "I don't think we need to change this to `ecs-nvidia`", "reference": "You may need to make this configurable if we expect people to be able to use the normal Nvidia runtime on other Linux distributions like Ubuntu or Debian." }, { "prediction": "Why is this change needed?", "reference": "Originally the DenyExport was a subscribe permission because it meant that if on this LN connection, if we deny export of \"foo\" it means that it would reject a subscription (hence subscribe permission) on \"foo\" from the other side. Now you are changing to simply not allowing this server to publish on \"foo\". I am not saying this is wrong, but we completely flip the meaning." }, { "prediction": "I think this should be `opmask_with_dsts(void)` instead of `opmask_with_dsts(void)`", "reference": "> k1 src0 src2 -> dst s/src2/src1/ nit: k1 is actually src0 according to instr_get_src(instr, 0) which makes this a little confusing" }, { "prediction": "I don't think we need to change to `0077` here.", "reference": "I believe that you meant to have the following on the second one, right ? `dataDirStat.Mode()^0077`" }, { "prediction": "Why is this change needed?", "reference": "The reason a `ByteCount` is used here, is that the H2 mapping in gQUIC requires this layer violation, which is why `CloseRemote` is not part of the public API. This layer violation will be resolved in IETF QUIC" }, { "prediction": "I think this should be `IsInvisSpell(spell_id, SE_InvisVsUndead) || IsEffectInSpell(spell_id, SE_InvisVsUndead2) || IsInvulnerabilitySpell(spell_id, SE_InvisVsAnimals) || IsInvulnerabilitySpell(spell_id, SE_InvisVsUndead) || IsInvulnerabilitySpell(spell_id, SE_InvisVsUndead2) || IsInvulnerabilitySpell(spell_id, SE_InvisVsUndead) || IsEffectInSpell(spell_id, SE_InvisVsUndead2) || IsInvulnerabilitySpell(spell_id, SE_InvisVsAnimals) || IsInvulnerabilitySpell(spell_id, SE_InvisVsUndead2) || IsInvulnerabilitySpell(spell_id, SE_InvisVsUndead) || IsInvulnerabilitySpell(spell_id, SE_InvisVsUndead) || IsInvulnerabilitySpell(spell_id, SE_InvisVsUndead) || IsInvulnerabilitySpell", "reference": "I dig the helper function!" }, { "prediction": "I think this should be `package_samples` instead of `package_samples`.", "reference": "Please add the Copyright header." }, { "prediction": "I think this should be `from ..target import FileSystemTarget` instead of `from ..target import FileSystemTarget`", "reference": "Is this the best way to import `FileSystemTarget`?" }, { "prediction": "I don't think we need to cast to `int32_t` here.", "reference": "Wait -- os_local_state_t.tid is thread_id_t though, so we need to read a pointer-sized value via READ_TLS_SLOT_IMM, rather than changing these locals to ints. Maybe have a READ_TLS_TIDSZ_SLOT_IMM or sthg." }, { "prediction": "I don't think this is a problem, but I think it should be `if (FAILED(Status)) {` or `if (FAILED(Status)) {` or `if (FAILED(Status)) { if (FAILED(Status)) { if (FAILED(Status)) { if (FAILED(Status)) { if (FAILED(Status)) { if (FAILED(Status)) { if (FAILED(Status)) { if (FAILED(Status)) { if (FAILED(Status)) { if (FAILED(Status)) { if (FAILED(Status)) { if (FAILED(Status)) { if (FAILED(Status)) { ExtOut(\"!clrstack -i is unsupported on this target.\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n\\n", "reference": "Don't use ! in the messages because it isn't used on xplat. There is a SOSPrefix define that can be used (blank on xplat and ! on Windows). Do we really need 3 newlines?" }, { "prediction": "I think this should be `os.path.isabs(dagster_home_path)`", "reference": "print out what we got here in the error" }, { "prediction": "(style) line over 80 characters", "reference": "Does this need to be global?" }, { "prediction": "Why is this change needed?", "reference": "Yep, could be simplified. Now looks like other *Map.values() impls" }, { "prediction": "I think this should be `requireResponse` instead of `requireResponse`.", "reference": "This method will be for debug?" }, { "prediction": "I think this should be `Key` instead of `Key`?", "reference": "// Key returns the private key for a specified name that was encrypted with the // provided password. If the private key does not exists it creates a new one // with a name and the password, and returns with `created` set to true." }, { "prediction": "I think this should be `self.attrs` and `self.methods`", "reference": "Adding the type hints revealed that it was necessary to distinguish between a ``PackageEntity`` and a ``ClassEntity``, because the ``ClassEntity`` has additional attributes that were dynamically added in the previous code, which confused ``mypy``." }, { "prediction": "I don't think we need this function anymore.", "reference": "These two functions should be available now." }, { "prediction": "I think this should be `file.o.size != fi.Size() || file.o.modTime != fi.ModTime()`.", "reference": "`fi` is what the result of Stat is called elsewhere in this file not `finfo`" }, { "prediction": "I don't think we need this test anymore.", "reference": "I'm confused; are we just dropping these methods without deprecation?" }, { "prediction": "I think this should be `version = folly::Endian::big(version);` instead of `version = folly::Endian::big(version);`", "reference": "can we use PC's time to version in Distributed Systems?" }, { "prediction": "I don't think we need to check for `c.user.nil?` here.", "reference": "is this \"unless\" actually needed?" }, { "prediction": "I think this should be `if (length == 0) { return list; }`", "reference": "We don't accept empty words for lookup anymore, again" }, { "prediction": "I think this should be `const installTime = Number(installTimeString.replace(/\\d+\\.\\d+(?=s\\.$)/m, installTimeString.replace(/\\d+\\.\\d+(?=s\\.$)/m, installTimeString.replace(/\\d+\\.\\d+(?=s\\.$)/m, installTimeString.replace(/\\d+\\.\\d+(?=s\\.$)/m, installTimeString))`", "reference": "We'll have to account for CI installations being faster than local ones. Do y'all think we should leave it at < 30 green / < 50 orange | >= 50 red or lower our thresholds?" }, { "prediction": "I think this should be `W3C_MINIMIZE_WINDOW` or `W3C_MAXIMIZE_WINDOW`.", "reference": "No need for this to be `W3C_` since there is no JWP equivalent" }, { "prediction": "I don't think we need to use `require 'rspec/core/backport_random'` here.", "reference": "As far as I can tell, there's nothing that creates an instance of `Random` or that calls `rand` or `seed`. Am I missing it? If not, let's remove the `Random` class since we don't really need it and we can move the definitions of `shuffle` into `RSpec::Core::Ordering`. One less type :)." }, { "prediction": "I think this should be `s.listener.Addr()`?", "reference": "Is this ever actually used?" }, { "prediction": "Why is this change needed?", "reference": "this section of the codebase should be noted as a candidate for caching, and as a place where multiple tipsets is making things extra tricky" }, { "prediction": "(style) code indent should use tabs where possible (style) code indent should use tabs where possible", "reference": "Do we need to save the existing value of the stolen reg somehow?" }, { "prediction": "Why is this needed?", "reference": "maxResults should come from FLAGS once #244 is submitted." }, { "prediction": "I think this should be `#if NETCOREAPP` instead of `#if NETCOREAPP`", "reference": "is this wanted?" }, { "prediction": "I think this should be `pytest.importorskip('linode')` instead of `pytest.importorskip('linode')`.", "reference": "What exception is actually happening here? AFAIK `pytest.importorskip` with just return `None` if there's nothing to import. Which means that this check'd always return `True`. `pytest.importorskip` is specifically designed to trigger skipping the current test anyway so I don't know why you would wrap it like this." }, { "prediction": "Line is too long. [98/80]", "reference": "Does it send requests with urlencoded bodies anywhere? I thought it sends only json. Maybe content-type should be `application/json` by default?" }, { "prediction": "I don't think this is a good idea, but I think it would be better to use `--ignore_chromium` instead of `--ignore_chromium`.", "reference": "I'm not sure about adding more flags here when we're trying to simplify things, I thought we were going to check for patches changes to decide if we needed to update or not?" }, { "prediction": "Why is this change needed?", "reference": "`testExecutionPb` is a global variable (from `gochecknoglobals`)" }, { "prediction": "Why is this removed?", "reference": "~Method is public and removing it would be a BC Break, you can deprecate it if you want.~" }, { "prediction": "I think this should be `err := fmt.Errorf(\"%v\\n %s\", err, debug.Stack())`", "reference": "this got me a little confused when reading `build.log`. The err is printed with a log.Error later on but that ends up after the stack trace." }, { "prediction": "I think this should be `--keep-namespaces` instead of `--keep-namespaces`.", "reference": "Can we make these more explicitly for Rust only? It seems like JS and Go use flags with their name in them." }, { "prediction": "I think this should be `fmt.Errorf(\"open bucket %q: invalid query parameter %q\", u, param)`.", "reference": "Should unsupported query parameters just be ignored? I think that's more common than error out." }, { "prediction": "I think this should be `:py:attr:` instead of `:py:attr:`", "reference": "Actually can we avoid mentioning `Register._UNSET_NAMESPACE`. I thought of it as an implementation detail of the simpler concept of \"being unset\". Perhaps the docs become more natural if we remove the \"If called without arguments or with ...\" part and just say \"you have to call this function without arguments at the end of any file it has been used. That is to ensure blah blah\". Something like that. Just a suggestion." }, { "prediction": "I think this should be `except Exception`?", "reference": "I assume it raises COMError? If so perhaps best to just catch that specifically, so as to not hide other more critical errors." }, { "prediction": "I think this should be `minify`.", "reference": "Since minify can generate errors, it should at least go after the errors middleware. And you definitely don't want to be minifying after the gzip writer has closed." }, { "prediction": "Why is this needed?", "reference": "nit: we could remove the `config` field as it is a duplicate of the `provider.config` field." }, { "prediction": "I think this should be `forseti-server-allow-grpc-internal`", "reference": "Nit: from the Internet." }, { "prediction": "I think this should be `github.com/miguelmota/go-ethereum-hdwallet`", "reference": "this is internal package, move to bottom and run 'make fmt'" }, { "prediction": "I think this should be `IConnectionLifetimeNotificationFeature` instead of `IConnectionLifetimeNotificationFeature`.", "reference": "Why is this better than ApplicationStopping?" }, { "prediction": "I think this should be \"http01\" or \"dns01\".", "reference": "Maybe worth expanding that these 2 are supported by cert-manager but other values exist" }, { "prediction": "I think this should be `getHelperProperties($media, $format, $options);`", "reference": "Why was this merged? It should have raised some questions IMO @core23 @OskarStark . It's already in 3 releases now, so we can't revert it can we? How can we fix this? Please have a look at #1065" }, { "prediction": "I think this should be `Optional.ofNullable(node.jsonRpcConfiguration().getAuthenticationPublicKeyFile().getAbsolutePath());`", "reference": "What if `node.jsonRpcConfiguration().getAuthenticationPublicKeyFile()` is empty string, would that cause a problem here?" }, { "prediction": "I think this should be `Duration` or `RenewBeforeDuration`.", "reference": "The `omitempty` struct tag does not do anything for non-pointer structs. I think we may need to consider making both of these fields pointers, so that they are excluded from output when not set, and also to make it easier to compare to the zero value. That said, I'm happy to merge this now and open an issue to verify the behaviour is as we want ahead of cutting v0.6.0." }, { "prediction": "Why is this change needed?", "reference": "I think this is should absolutely be `==`, as the interface cannot control the implementation of equals (and it's part of the contract of the enclosing function). Can we add this interface to the exceptions of the rule?" }, { "prediction": "I think this should be `namespaceLabels map[string]string`", "reference": "It looks like the UID is the only other thing that we use from `namespace`, so I suggest to copy that out and lose `namespace`, so we don't have to worry about setting it to nil." }, { "prediction": "I think this should be `aws/codebuild/amazonlinux2-x86_64-standard:3.0`", "reference": "Can we define this constant in the`deploy` pkg instead? this would allow us to keep it private" }, { "prediction": "I think this should be `mydir/toto` instead of `mydir/toto`", "reference": "I don't like this fixture name, should be a noun like `initialized_linter` ? But it's outside of the scope of this MR." }, { "prediction": "I think this should be `SettingsService` instead of `SettingsService`.", "reference": "Could we keep this as a static reference (JsonPrinter.jsonAsDatasetDto(releasedVersion); and perhaps change the constructor line to just be a static set method and use that here instead? (I suspect it was the warning that 'static methods should be accessed in a static manner' from my IDE that caused me to make this change in the first place...) (I can make a PR to your branch if you want.)" }, { "prediction": "I think this should be `Keys#COMMAND` instead of `Keys#SHIFT`.", "reference": "Keys.COMMAND seems to be an alias to Keys.META. That isn't mentioned?" }, { "prediction": "I think this should be `SetDiskBlockCacheFraction`", "reference": "This should go in `ConfigLocal` (and then re-generate the mocks)." }, { "prediction": "Why is this change needed?", "reference": "Nitty but entry.get for the same thing" }, { "prediction": "I think this should be `init` instead of `nsenter`.", "reference": "Might not hurt to mention the function never returns (since this all ends in `execve`) so `main` never actually runs." }, { "prediction": "I think this should be `if (!Constants.ECONNRESET.HasValue) { _logger.LogWarning(\"Unable to determine ECONNRESET value on this platform.\");`", "reference": "nit: add new line after this block" }, { "prediction": "I think this should be `3.25rem` instead of `3.25rem`.", "reference": "I believe there is some javascript that also uses this 60px number for calculations. I think I'd rather keep the number in px instead of rem to make that correspondence easier to see. If 3.25rem != 60px, can you also change the other place where `60` is used to in the JS?" }, { "prediction": "Why is this needed?", "reference": "retrying is an installed 3rd party library just like jinja and sendgrid; perhaps try grouping all of them together?" }, { "prediction": "I think this should be `java.util.List` instead of `java.util.List`", "reference": "you could always use List.listIterator with previous() and hasPrevious() to traverse all kinds of j.u.List backwards. No need for special cases for ArrayList and Vector." }, { "prediction": "I don't think we need to do this, but I think it would be better to use `Bitmap.empty()` instead of `Bitmap.empty()`.", "reference": "remove the bitmap of index 1 from the list not the 0th one. because when we keep on undoing, it would be better if we end up with the original image rather than some randomly edited image. I am not sure whether only just removing bitmap from the list would clear memory. I think you should call bitmap.recycle before removing that bitmap from the list." }, { "prediction": "I think this should be `2010`", "reference": "this is a existing file so let's keep 2019" }, { "prediction": "Why is this change needed?", "reference": "can you change this instead to just `type.toString()` and then you wouldn't have to expose the getBitMask in the enum. (Alternatively you could have used `type.hashCode()` but that doesn't feel as nice)" }, { "prediction": "Why is this change needed?", "reference": "AsReadOnly() would be better here" }, { "prediction": "`newModifications` and `oldModifications` are indices in the collection before the change happened, while `insertions` and `newModifications` are indices in the new version of the collection.", "reference": "I suggest that we use `query_based_sync` instead of `partial_sync`." }, { "prediction": "I think this should be `put-on-sas-blob-url-without-specifying-x-ms-blob-type-header`.", "reference": "How does the user use this? By converting the type using `As` function and add the header? Maybe add an example on how." }, { "prediction": "I think this should be `@Nullable` instead of `@Nullable`", "reference": "I'm trying to understand the effects of this change. Is setting this to something other than the old default (that is, `initCodeTransformer = new InitCodeTransformer()`) generally necessary, or are we doing this only to support Python?" }, { "prediction": "Is there a reason we don't need the `ZeroValueKey` here?", "reference": "\"Constructor\" isn't a standard term in Go or this project, although we use it informally amongst ourselves. And I think it will confuse people coming from languages like Java. So can we leave this as it was?" }, { "prediction": "I think this should be `ctu_on_demand_failure` instead of `ctu_failure`.", "reference": "Why do we have to change the test dir?" }, { "prediction": "I think this should be `!el.querySelector('summary')`", "reference": "This should test the flattened tree instead. details > summary works across shadow tree boundaries." }, { "prediction": "I think this should be `internal` instead of `internal`", "reference": "Not sure I am a big fan of these duplicated Log classes." }, { "prediction": "I don't think we need this, but I think it would be better to use `Error` instead of `Error`.", "reference": "It's long-winded, but the convention is to give constants a common prefix which, see `reasonDomainVerified` ." }, { "prediction": "Why is this change needed?", "reference": "Using lanes later down, this threshold could be reduced for similar effects. Otherwise we look a bit to far." }, { "prediction": "(style) line over 80 characters", "reference": "Let's get more verbose about names. struct `wq_conda_environment`: if it can really only be used for conda. struct `wq_software_environment`: if it has potential use outside of conda." }, { "prediction": "Why do we need this?", "reference": "Should we set this back to `false` inside each `t.Run`? so that we can have more than one testcase that can have paginated responses" }, { "prediction": "I think this should be `if (deleteManifests == null && allManifests.size() > 0) {`", "reference": "What about using `dataManifests == null || deleteManifests == null`?" }, { "prediction": "I think this should be `GlobalHitsThresholdChecker`", "reference": "The `HitsThresholdChecker` should be created once and shared within the collectors ? We also don't need to use the `GlobalHitsThresholdChecker` if the executor is null or if there is a single slice." }, { "prediction": "I don't think this is needed anymore.", "reference": "move this to below `antrea.io` import section" }, { "prediction": "This extension method should only be used on instances that were created.", "reference": "Seems likely to confuse people. What if we moved it into ActivitySourceAdapter and made it private?" }, { "prediction": "I think this should be `new(big.Int).Mod(signedTx.GasPrice(), big.NewInt(1e6)).Cmp(common.Big0)`", "reference": "gas price don't need to be a multiple cuz we support allll gas prices now" }, { "prediction": "This should be `void OnClientProcessExit()`.", "reference": "We are exposing implementation details in the interface. What if there is no processes involved in an implementation of `ITestRequestSender`?" }, { "prediction": "I think this should be `# pylint: disable=broad-except` instead of `# pylint: disable=broad-except`.", "reference": "It would be awesome not to handle the broad exception here. Instead, raise a custom exception, something like `ModelNotSetException`, from the `require_model()`, and then handle it here with a nicer message to tell the user to set the model first." }, { "prediction": "I think this should be `customize_theme` instead of `customize_theme`", "reference": "This already exists under the `theme` lang key, please remove this." }, { "prediction": "I don't think we should render the HelpMenu here.", "reference": "Let's add a simple inline HOC around the default export below to provide the value as a prop (no need to introduce a reusable function for this yet)." }, { "prediction": "I think this should be `host['netmask'] ||= \"255.255.0.0\"`", "reference": "I believe that you end up printing out the result of the assignment here instead of the netmask." }, { "prediction": "I think this should be `tarball-blahblah-file.name` and not `tarball-blahblah-file.name`", "reference": "We have to update the filename here." }, { "prediction": "I don't think we need to add the `--cpp-field-case` option here.", "reference": "The `--cpp-field-case` looks like `--cpp-field-style` instead of `-case`. - 'unchanged' - leave unchanged (default); - 'upper_camel' -upper camel case; - 'lower_camel' - lower camel case." }, { "prediction": "Why is this removed?", "reference": "I haven't thought about this a lot yet, but if we were to try this change, we'd still need to keep the code to delete it from the `.origin` file for backcompat." }, { "prediction": "I don't think this is needed.", "reference": "In my opinion I think it is possible to add `private final` here" }, { "prediction": "I think this should be `deny` instead of `exit`.", "reference": "Feel like \"exit\" doesn't convey that the packet will be dropped. \"drop-and-exit\" or \"error-exit\" maybe?" }, { "prediction": "(style) line over 80 characters", "reference": "How do you feel about \"The Main actor\" instead of \"A Main actor\", while we're already here changing the message?" }, { "prediction": "I think this should be `zk-read` instead of `zk-read`", "reference": "I cannot see that this new permission is used anywhere? And if the new zk handler is covered by `zk-read`, should not also existing `ZookeeperInfoHandler` handler implement PermissionNameProvider and declare the same permission, for consistency?" }, { "prediction": "Why is this change needed?", "reference": "Is this reasonable?" }, { "prediction": "I think this should be `TODO: Implement 'Shear', 'Sharpness' and 'Rotate' transforms`.", "reference": "We may move this TODO to Line15." }, { "prediction": "Shouldn't this be `if(true === ConfigQuery::checkAvailableStock()) { return $this->checkStockNotEmpty(); }`?", "reference": "You have to verify the return type. If it's a reponse, return it. Otherwise do nothing." }, { "prediction": "I don't think you need to add the `int32_t` to the `int64_t` type.", "reference": "No. Keep the header include and do `extern template ...` to skip the instantiation from that compile unit. (I pushed a fix directly to your branch)" }, { "prediction": "I think this should be `max({}())` instead of `min({}())`.", "reference": "these tests are currently somewhat nonsensical. This code expands to `a, b = {}.keys` when it really should be expanding to `a, b = {}.keys()` -- though fixing this causes the test to fail so I suspect something worse is going on here that I don't quite understand?" }, { "prediction": "I think this should be `location.value.long, should not be read`", "reference": "Why did this need to change?" }, { "prediction": "I think this should be `BranchState`?", "reference": "/go/pkg/mod/golang.org/x/xerrors@v0.0.0-20190410155217-1f06c39b4373/adaptor_go1_13.go:16:21: Frame not declared by package errors (from `typecheck`)" }, { "prediction": "I think this should be `collection.configName`", "reference": "Probably doesn't go here because I think it's specific to the HTTP API layer. This class is too internal to declare such a name." }, { "prediction": "I think this test should be `assertThat(check.body().string()).isEqualTo(\"{\\\"status\\\":\\\"UP\\\",\\\"zipkin\\\":{\\\"status\\\":\\\"UP\\\",\\\"details\\\":{\\\"InMemoryStorage{}\\\":{\\\"status\\\":\\\"UP\\\"}}}\");`", "reference": "in preparation of directly writing the /health endpoint one day.. we should have content checks." }, { "prediction": "I think this should be `fmt.Sprintf(\"multiple IDs with prefix %q found\", e.prefix)`", "reference": "question (non-blocking): Is there a benefit from using `%q` instead of `%s`?" }, { "prediction": "Why is this removed?", "reference": "I would suggest to keep two empty lines between functions in cpp files" }, { "prediction": "Why is this change needed?", "reference": "This change causes the test to fail on both rocm-1.9.x and rocm-head." }, { "prediction": "I don't think we need this interface, but I think it should be `AutoFixableRuleViolationFixer`.", "reference": "I'd consider moving all fix related stuff to a distinct package to avoid contaminating the base package" }, { "prediction": "I think this should be `if not opt.startswith('-I') or not os.path.isdir(opt[2:].strip())`", "reference": "Use `os.path.join` for path concatenation." }, { "prediction": "I think this should be `YolactHead` or `YolactSegmHead`", "reference": "Use upper case: YOLACTHead, YOLACTProtonet, YOLACTSegmHead" }, { "prediction": "Why is this change needed?", "reference": "The driver tests should be updated to use the concrete type instead of the driver directly; right now your test coverage of the concrete type is 0%." }, { "prediction": "I think this should be `Type::getTypeFromTree($method_tree_child->children[0], $codebase);` or `Type::getTypeFromTree($method_tree_child->children[0], $codebase);`", "reference": "I would prefer the message to be more actionable. Like 'There should be no space between & and the variable name' or something similar." }, { "prediction": "I think this should be `jjtGetChild(int index)` instead of `jjtGetChild(int index)`", "reference": "The image attribute is not supposed to be the text of the node. I'd rather keep it separate (the previous `@Text` attribute was fine). A practical reason for that is in the future, other languages may have a way to get the text of their node, in which case that wouldn't be fetched with `getImage`, for compatibility, but probably with a `getText` method, or `getSourceCode` like in #1728. Also we *may* deprecate or otherwise put `getImage` out of use as soon as 7.0, given its contract is super loose." }, { "prediction": "I think this should be `@exclusion_patterns = []` instead of `@system_exclusion_patterns`", "reference": "The `[] +` seems weird to me. Why is it there?" }, { "prediction": "Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "Not sure if this constant is defined at the right place style-wise. Maybe move it up to before 'belongs_to' like DISCOUNT_TYPES in coupon.rb?" }, { "prediction": "I think this should be `bytes.HasPrefix(k, []byte(\"#\"))`", "reference": "What about a line with just spaces/tabs? Or a line with a couple spaces followed by a `#`?" }, { "prediction": "Line is too long. [89/80]", "reference": "if funder_is is not blank (L375) there is not need to check if org_id is not blank (L379) since you will never enter in the if (L374)." }, { "prediction": "I think this should be `this->MessageString(Chat::TooFarAway, TRY_ATTACKING_SOMEONE);` instead of `this->MessageString(Chat::TooFarAway, TRY_ATTACKING_SOMEONE);` and not `this->MessageString(Chat::TooFarAway, TRY_ATTACKING_SOMEONE);`", "reference": "Don't need this-> here." }, { "prediction": "I don't think we need to import `_metadata` here.", "reference": "I'm a little concerned about relying on a private module, as they could change the implementation at some point, I'd like to have some test to validate this is working as intended." }, { "prediction": "I don't think we need to check if `value` is a dict.", "reference": "There might other values that we don't support here (eg. `[]`). So it might be safer to check for the supported types instead (string or number)." }, { "prediction": "I think this should be `static_cast(expr)` instead of `static_cast`.", "reference": "FYI, It won't have any benefit to move from trivial types." }, { "prediction": "I think this should be `secrets-ssm-environment-variables`", "reference": "i missed these discussions- but ` \"secrets-ssm-environment-variables\"` is what was agreed upon with cp?" }, { "prediction": "I think this import should be `gogo.org/gogo/protobuf/jsonpb` instead of `github.com/gogo/protobuf/jsonpb`", "reference": "whats the difference between this package and `github.com/golang/protobuf` ? or did vscode just decided this was the package it wanted to used?" }, { "prediction": "Why is this needed?", "reference": "Just asking: What does this line do? Does it add the stylesheet from the parent to the dialog?" }, { "prediction": "I think this should be `scikit-learn<1.0.0`", "reference": "Including the scikit-learn dependency here would pull in scikit-learn for everyone who depends on Dagster. If you put it in the setup.py under docs_snippets, we'd avoid that problem (although I think it's already there)." }, { "prediction": "Why is this removed?", "reference": "Why remove this?" }, { "prediction": "I think this test should be removed.", "reference": "Why remove this? It seems like we should keep this around as a regression test, unless we can guarantee this will never be called without a model set (does your new code guarantee that?)" }, { "prediction": "I think this should be `global._googlesitekitUserData?.permissions || {}`", "reference": "Because this defaults to `{}` if `global._googlesitekitUserData?.permissions` is `false`-y, the checks below around `state.capabilities` always result in the `!! capabilities === true` path. This shouldn't have a default value of `{}` if there's the possibility that `global._googlesitekitUserData?.permissions` can be `undefined`/`false`/`null` legitimately." }, { "prediction": "I think this should be `log.ram_handler.change_log_capacity(0)`", "reference": "Please add a space after the comma here (generally, with arguments there's always a space after commas)." }, { "prediction": "Why is this change needed?", "reference": "From the context, should it say \"Flags defined in this class must be used with caution...\" ?" }, { "prediction": "I think this should be `/javascript/grid-ui/src/tests/**/*.test.tsx` instead of `/javascript/grid-ui/src/tests/**/*.test.tsx`", "reference": "We don't need this file, we can use the one that is in the grid-ui directory" }, { "prediction": "I think this should be \"Imported key for account %s\"", "reference": "\"Exported key for account\"?" }, { "prediction": "I think this should be `// Not L10N` instead of `// Not L10N`", "reference": "Normally we use Environment.NewLine unless you really want it to always be \\r\\n" }, { "prediction": "Why is this removed?", "reference": "why did you remove `verifyHeaders`?" }, { "prediction": "I think this should be `params[:user][:org_id] = other_org.id` instead of `params[:user][:org_id] = other_org.id`", "reference": "Thanks for cleaning up these deprecated calls" }, { "prediction": "Why is this change needed?", "reference": "@akarve this breaks error catching logic on the front end, I'll fix this. That's why I prefer to use some machine-friendly error codes that won't change frequently." }, { "prediction": "I don't think we need to check for service resource type here.", "reference": "We support process remoteQuery for Service. Why are we removing it ?" }, { "prediction": "I don't think this is necessary.", "reference": "This is specifically for testing?" }, { "prediction": "Why is this needed?", "reference": "I think this is related to the social stats and probably does not need to be removed." }, { "prediction": "I think this should be `jsdoc/require-description-complete-sentence`", "reference": "Yep, jsdoc again .. It seems that when the plugin description is wrapped within `eslint-disable/enable` expression it's not generated at all. After adding the `@class AutoColumnSize` tag right after the `@plugin` tag the plugin appears in the docs. Please review the other plugins." }, { "prediction": "I think this should be `errs.New(\"principal %q not found\", principalID)`.", "reference": "This usage of the result doesn't look quite right. I would not expect the first page of values to be empty if there were multiple pages of results. This also obscures the error case when no values are returned (handled in the next `if` block) by returning a more generic error from the Azure SDK from `result.NextWithContext()`." }, { "prediction": "I think this should be `exp.GetAddressDetails(hashStr)`", "reference": "unknown field AddressDetails in struct literal (from `typecheck`)" }, { "prediction": "I think we should use `aws.Config` instead of `aws.Config` here.", "reference": "Just noticed, are we specifically missing the addition of `SharedConfigState: session.SharedConfigEnable` ?" }, { "prediction": "I think this should be `oldTimeIntensities != null && oldTimeIntensities.NumPoints > 0`", "reference": "Not sure what this is. Bad merge?" }, { "prediction": "I don't think we need to lock here.", "reference": "I think this may be a RW lock." }, { "prediction": "Why is this changed?", "reference": "Perhaps we should tuck this away into a dedicated subdir and name it `config` or something similar? Or maybe it would be happy living in `common`?" }, { "prediction": "I think this is not a good idea, but I think it would be better to use `spec.must_learn & 0xf` instead of `spec.has_learnt`", "reference": "Doing a select query inside of a loop like this is not ideal. We should fetch recipes once and then loop through it in memory to perform this check" }, { "prediction": "I think this should be `copy=True` instead of `copy=True`.", "reference": "too long here. (104 > 100)" }, { "prediction": "I think this should be `Logger.Error(\"$There is no handler registered for this message\");`", "reference": "Use TryGetValue instead of catching exception" }, { "prediction": "Line is too long. [98/80]", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I think this should be `num_sent_submessages += num_locators;` instead of `num_sent_submessages`", "reference": "I think this method should be either: - a static method of `RTPSWriter` to avoid a StatelessWriter redefinition of the function. - a setter in the `CacheChange_t` struct." }, { "prediction": "I think this should be `_stream.ResetAndAbort(abortReason, Http2ErrorCode.INTERNAL_ERROR);`", "reference": "You add a stream back reference for trailers, and all of the sudden we have tight coupling! " }, { "prediction": "Is this needed?", "reference": "I don't think we use `AspNetAmbientContext` anymore since . We can probably delete this file." }, { "prediction": "I think this should be `module.exports = __webpack_require__(1);`", "reference": "Please avoid committing build artifacts, as they produce unnecessary conflicts and noise." }, { "prediction": "Why is this removed?", "reference": "this is vendored code so i would hesitate to make random changes to it" }, { "prediction": "I think this should be `referralInfoDTO`", "reference": "We are using a different style for JSON tags. `ethAddress` - camalCase `referral_code` - snake_case" }, { "prediction": "I think this should be `DefaultHttpContextTypeName`", "reference": "Should this be `\"Microsoft.AspNetCore.Http.DefaultHttpContext\"`?" }, { "prediction": "Why is this assert needed?", "reference": "removed asserts from `Vector` as it's stable enough and it may hinder inlining, even if turned off :/" }, { "prediction": "I don't think we need to disable the cache here.", "reference": "Do we want to raise on the function or on the decorator?" }, { "prediction": "I don't think we need this change, but I think it's a good idea to add a `release_msid` field to the `track_metadata` dict, but I think it would be better to add a `release_msid` field to the `track_metadata` dict. I don't think it's a good idea to add a `release_msid` field to the `track_metadata` dict.", "reference": "How complex is to to replace `album_*` with `release_*` everywhere in the `Listen` class and places that use it?" }, { "prediction": "Why is this change needed?", "reference": "You haven't changed any of the callers of `.Add` to check the return value, so we're now ignoring duplicates. Please fix that." }, { "prediction": "I think this should be `const vNode = axe.utils.getNodeFromTree(el, descendentVisibilityValue);` or `const vNode = axe.utils.getNodeFromTree(el, descendentVisibilityValue);`", "reference": "@straker should this not push to `vnode._cache.isHiddenWithCSS`?" }, { "prediction": "I think this should be `provider.ProviderInterface` instead of `provider.ProviderInterface`.", "reference": "\"an interface\" in conceptual sense vs \"interfaces\" or \"set of interfaces\", referring to the Go interfaces - database/sql uses the latter, should we?" }, { "prediction": "I don't think we need to check for `ioError` and `connectError` here.", "reference": "This now checks nearly all errors that can occur. How about explicitly listing cases where we want it to retry? I think there are not many cases where we want that, as the many added conditions in the last years show :)" }, { "prediction": "Why doSync is set to `true` instead of `false`?", "reference": "Can you make this accept an action instead?" }, { "prediction": "I don't think we need a `download` or `video` here.", "reference": "Tab inconsistency here (3 spaces instead of 2 spaces)" }, { "prediction": "Why is this needed?", "reference": "these change means we are changing epoch to 1 hour?" }, { "prediction": "I think this should be `544` instead of `544`.", "reference": "Why this is defined in the middle of imports?" }, { "prediction": "I don't think we need this.", "reference": "Could you move this to the original position?" }, { "prediction": "I think this should be `oAndR.repo` or `oAndR.owner`", "reference": "Is there a test that'd have caught this?" }, { "prediction": "Why is this change needed?", "reference": "ListWorkflowExecutionsRequest <- this can be nil?" }, { "prediction": "Align the parameters of a method call if they span more than one line.
    Space inside } missing.", "reference": "Do we need to continue to support the old link, or is it dead dead dead?" }, { "prediction": "I think this should be `HeaderTags = source?.GetDictionary(ConfigurationKeys.HeaderTags) ?? new ConcurrentDictionary();`", "reference": "Do we need `ConcurrentDictionary`? `Dictionary` can be safely read from multiple threads. See `GlobalTags`." }, { "prediction": "I think this should be `config.GetOSFamilyType()` instead of `config.GetOSFamilyType()`", "reference": "this seems like more of a Debugf statement" }, { "prediction": "I think this should be `const ValidationStateTracker *device_data` instead of `const QUEUE_STATE *queue_state`", "reference": "We're capturing cb_state non-const, but the function is const so, safe enough, but after going to reader/writer locks we're all going to have to key a careful eye on anything in this pattern." }, { "prediction": "I think this should be `if req.Config.Endpoint != nil`", "reference": "Probably want to wrap the endpoint discovery work that follows in this `if` statement instead of returning early. This will make it easier to add additional request code generation logic in the future. e.g. if we add any code generation after the endpoint discovery block this check will cause it to be skipped." }, { "prediction": "I think this test should be `expect(fn).to.throw(/JSX twice/);`", "reference": "This test was giving a false positive because my change caused it to throw a different error that contained `createElement` when it should've been throwing this error. Caught this by looking at the code coverage and noticing that the line under the condition I changed was no longer covered lol." }, { "prediction": "I think this should be `return nil`", "reference": "I think this is added to wrong file. You wanted to add to cmd/agent/, right?" }, { "prediction": "Why is this needed?", "reference": "Each `ExpectedCondition` implements `java.util.Function` These are expected to be stateless. This condition will leak previous `elementText` on the second usage, which doesn't seem ideal." }, { "prediction": "I think this should be `DeviceID` instead of `DeviceID`", "reference": "Could we consider a more explicit name, like `devicePciAddress`?" }, { "prediction": "I think this should be `if (!execName.endsWith(\".exe\") && !execName.endsWith(\".exe\") {`", "reference": "Why change this from a foreach? I can't see it gaining anything here and code styles shouldn't change just for the sake of it." }, { "prediction": "Why not use `getRawResponse()` here?", "reference": "Is this supposed to be part of this PR?" }, { "prediction": "I think we should use `getComputedStyle` instead of `getComputedStyle`", "reference": "DRY, worth extracting this method to axe.utils" }, { "prediction": "I think this should be `APPLICATION_NAME` instead of `APPLICATION_NAME`", "reference": "I think there's another spot for this in DefaultCapabilityMatcher" }, { "prediction": "I don't think this is necessary, but I think it would be better to use `os.path.exists(self._configfile)` instead of `os.path.exists(self._configfile)`.", "reference": "`QtOSError` inherits `OSError`, so I don't think it's needed to list them both here." }, { "prediction": "Why is this removed?", "reference": "Instead of patching vendor, let's update the version of sdk-go to a more recent one that doesn't have this line." }, { "prediction": "I think this should be `BuildFileName`", "reference": "Don't think this should be here. The default is set somewhere else." }, { "prediction": "Shouldn't this be `if not self._last_status[\"progress\"] >= 100: self.master.terminate()`?", "reference": "Not really important in this PR, but does BlazeMeter describe \"progress\" values anywhere? It might be nice to have a set of constants like `PROGRESS_DOWNLOADING_IMAGE`, `PROGRESS_BOOTING`, `PROGRESS_RUNNING_TEST`, etc in our BZA client." }, { "prediction": "I think this should be `null`?", "reference": "nit: `

    ` after the line" }, { "prediction": "I think this should be `glob(\"fonts/*.ttf\")` instead of `glob(\"fonts/*.ttf\")`.", "reference": "Should we include the files with otf extension here, too? If not, I wonder why we do allow them in the source but we don't include them as per the setup" }, { "prediction": "Why is this removed?", "reference": "i think it's OK to leave this?" }, { "prediction": "Why is this change needed?", "reference": "Does this need to be public? The only reference to `FlinkTypeVisitor` that I see in this PR is here, so I'm not sure why this is needed." }, { "prediction": "I don't think this is necessary.", "reference": "No line at end of file warning" }, { "prediction": "I think this should be `CompositeBlockTracerFactory`", "reference": "This looks unused, shouldn't it point to inner processor in any way?" }, { "prediction": "Why is this removed?", "reference": "There may be a few isolated cases where the FirstN node is added during preCodeGen. Please see GenPreCode.cpp RelRoot::preCodeGen(). The example given there about Order by where sort is added in optimizer, or a FirstN where the N value is to be specified with a param seem to be cases where we would add the FirstN later. Will current change cause such views to marked as updateable? This is minor and could be resolved later, if any change is necessary." }, { "prediction": "I think this should be `getStaticLangStreamingReturnTypeName` instead of `getStaticLangStreamingReturnTypeName`", "reference": "I think you should compose the %sClient part using the Name class, and then do the remaining composition with plain concatenation. Side question: why does the return type name look like it is a client type name?" }, { "prediction": "I think this should be `0`", "reference": "All stories in this file also need the default padding." }, { "prediction": "I think this should be `public static readonly string MeterName = Utils.GetCurrentMethodName();`", "reference": "Curious - what would be the actual value? " }, { "prediction": "I think this should be `PALETTE=datasets[0].PALETTE`", "reference": "Is it necessary to record the palette in the checkpoint? Any reason?" }, { "prediction": "Why is this needed?", "reference": "Not sure how to best do this without creating a new connection to the server everytime. Do this in another thread?" }, { "prediction": "Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "should we have a similar test for gsa18f procurements?" }, { "prediction": "Why is this change needed?", "reference": "change `v.recipient` to address.Address, so can use `AccountState(v,recipient)`" }, { "prediction": "I don't think we need this method anymore, but I think it would be better to use `approval.cart_approvals.order('position ASC').last == approval.cart_approvals.order('position ASC').last == approval.cart_approvals.order('position ASC').last == approval.cart_approvals.order('position ASC').last` instead of `approval.cart_approvals.order('position ASC').last == approval.cart_approvals.order('position ASC').last == approval.cart_approvals.order('position ASC').last == approval.cart_approvals.order('position ASC').last`", "reference": "Open to doing away with this altogether and maybe injecting this logic somehow into `requires_approval_notice?` in LinearDispatcher." }, { "prediction": "I think this should be `int` instead of `int`.", "reference": "remove this and always enable tracer, just set the default timeout to something higher (20 seconds)" }, { "prediction": "I think this should be `final`", "reference": "Can we give this field a more descriptive name? When I use a variable named `icon` I normally expect an `Image` object." }, { "prediction": "I think this should be `targets` instead of `targets`?", "reference": "can't these just use the global `include` and `exclude` flags?" }, { "prediction": "I think this should be `deltas.cuda()`.", "reference": "Is this still necessary?" }, { "prediction": "Why is this change needed?", "reference": "Interesting! Happen to catch an exception message or anything I can look into?" }, { "prediction": "Why is this removed?", "reference": "did this get moved to mpromise? I don't recall if it's in that lib or not." }, { "prediction": "I think this should be `[]int` instead of `int`", "reference": "json objects should be `camelCase`" }, { "prediction": "I think this should be `OneKiBSectorSize`", "reference": "QuarterGiBSectorSize? SectorSize265MiB? Spelling out 256 seems overly verbose." }, { "prediction": "Why is this change needed?", "reference": "Maybe with this change we can remove `using OpenTelemetry.Logs`." }, { "prediction": "Why is this needed?", "reference": "Fix this name too." }, { "prediction": "I think this should be `recID = record_get_field_value(self.record, \"001\") or None`", "reference": "why this is an issue?" }, { "prediction": "I think this should be `is_static`?", "reference": "The condition should be inverse?" }, { "prediction": "I think this should be `Azkaban-Flow-Version` instead of `Azkaban-Flow-Version`.", "reference": "this seems to be a property key name, so should it be a inside configurationkey.java?" }, { "prediction": "I think this should be `v.Command.CombinedOutput()`.", "reference": "G204: Subprocess launching should be audited (from `gosec`)" }, { "prediction": "I think this should be `run_on_main_process` instead of `run_on_main_process`.", "reference": "Please add docs here. And also warn users that this mode should be avoided whenever possible, because any blocking IO will make the keep-alive-thread not run." }, { "prediction": "I think this should be `Object.keys(dimensionFilters).every(function(dimension) { return dimensionFilters.hasOwnProperty(dimension) && dimensionFilters.hasOwnProperty(dimension)`", "reference": "We shouldn't require dimension values to be a string. They just need to be scalar values (probably we could check whether it's either a string or a number). Something more important to cover in the validation here though is to ensure that a map of `dimensionName => dimensionValue` is passed. The keys here actually need to be strings. For example someone shouldn't be able to pass an array of values." }, { "prediction": "Why is this needed?", "reference": "let's do a pointer cast of nil, similar to the `MapRouter` above" }, { "prediction": "Why do we need this action?", "reference": "action should use a prefix of `hfg` rather than `neve` as we plan to bootstrap this as a standalone library. Moreover, previously filter/actions used in this library was using the same pattern." }, { "prediction": "I think this should be `true` instead of `false`.", "reference": "I'm halfway tempted to disable this for all https connections. Do you know of any clients that actually renegotiate for any reason?" }, { "prediction": "I think this should be `visibility_of_any_elements_located`", "reference": "shouldn't **call** return a boolean?" }, { "prediction": "I think this is a good idea to add a blank import to the `gocloud.dev/docstore/awsdynamodb` package.", "reference": "I don't think you need the blank import here. This one uses awsdynamodb directly." }, { "prediction": "I think this should be a `Predicate` instead of a `Predicate`", "reference": "I think this should be initialized to `null` instead of a predicate. There is no need to run an extra predicate (with an extra method dispatch for each row in a data file. That's a tight loop so we should do more work here to avoid it. Instead of using `isDeleted.or`, this should test whether `isDeleted` is `null` and either initialize `isDeleted` or call `isDeleted.or`." }, { "prediction": "I think this should be `if 'ctu_phases' in args:`", "reference": "What is this and the next entry in config_handler used for?" }, { "prediction": "Why is this needed?", "reference": "will your editor integrate `gofmt`, `goimports`, etc...?" }, { "prediction": "I don't think we need to check `intent.getExtras().getSerializable(\"state\")!=null` here.", "reference": "looks like the code is not properly formatted. for example here are some missing spaces in **if** command. please take care and reformat the code using default android formatting." }, { "prediction": "I think this should be `--bug-path-length` instead of `--bug-path-length`.", "reference": "Please add some valid examples to help message like `\"4:10\"`, `\"4:\"`, `\":10\"`" }, { "prediction": "I don't think we need to use `Symbol.to_s` here.", "reference": "Is it only Symbols we're worried about converting? Is it not safe to just call `to_s` anyway?" }, { "prediction": "Why is this removed?", "reference": "Note for those who come across this later: It was moved to `testhelpers.mining.go` so that `testhelpers.NewDaemon` and the `mining/worker_test.go` can share it." }, { "prediction": "I think this should be `incomplete_trails.select(&:in_progress?).flatten`", "reference": "What about `sort_by(&:in_progress?)`? Maybe with a `.reverse` thrown in?" }, { "prediction": "I think this should be `grpc` instead of `grpc`", "reference": "Flag is removed because it is only gRPC now." }, { "prediction": "I think this is a bit confusing, but I think it would be better to add a `--template` argument to the `init` command. I think it would be better to add a `--template` argument to the `init` command.", "reference": "Might be better to rephrase to: Please refer to the ``init scenario`` command in order to generate a custom ``molecule`` scenario. Since you aren't customizing the default scenario since it already exists, right?" }, { "prediction": "I think this should be `if open_module == \"pathlib\" and node.func.attrname == \"write_text\":`", "reference": "Shall we merge these `if` for `path lib` and then do the `attrname` one. I'm trying to count `if`-calls and its getting late but I think we can reduce the number checks needed to get into L648 from 3 to 2 if you understand what I mean " }, { "prediction": "I think this should be `recovery` instead of `recovery`.", "reference": "why depend on recovery???" }, { "prediction": "Why is this change needed?", "reference": "the done channel only aims to be closed, so `chan struct{}` is better then `chan interface{}`" }, { "prediction": "Why is this error being wrapped in a `wrapErr`?", "reference": "Do you mean to have gas_oracle changes in this PR?" }, { "prediction": "I don't think this is necessary, but I think it's a good idea to remove the `action=\"append\" target=\"main-flashes\"` tag.", "reference": "Is this effectively requiring browsers support javascript?" }, { "prediction": "I think this should be `android.R.style.SalesforceSDK_Dialog_Dark` instead of `android.R.style.SalesforceSDK_Dialog_Dark`.", "reference": "Lowercase `boolean` - use the primitive type." }, { "prediction": "I think this should be `await feed.CheckIfBlobExists(relativeBlobPath);`", "reference": "This isn't the correct logic. if allowOverride == true and !blobExists then upload. Just don't do the exist check if allowOverride is set to true." }, { "prediction": "I think this should be `if (atom[i] == xwm->atoms[_NET_WM_STATE_MAXIMIZED_VERT]) {`", "reference": "Can you replace these by `else if` please?" }, { "prediction": "I think this should be `.mdc-select__selected-text` instead of `.mdc-menu-surface--open.mdc-list-item`.", "reference": "Would be nice if the field had a unique class name that could be used to target it, instead of `fromRange` But doesn't seem to be a common thing in the code base." }, { "prediction": "I don't think we need to check `header.getAttribute('id')` here, but I think it would be better to use `header.getAttribute('id')` instead of `header.getAttribute('id')`.", "reference": "Does this code fit on one line under 80 characters? It would be more consistent with our existing style." }, { "prediction": "I think this should be `list.Items = append(list.Items, OpenEBSCRDArtifactsFor070().Items...)`, not `list.Items = append(list.Items, JivaPoolArtifactsFor070().Items...)`", "reference": "Not a requirement here. But i see a change in naming convention. We can rename the function to `CstorSparsePoolArtifactsFor070`." }, { "prediction": "I think this should be `interruptsPin = machine.GP10`", "reference": "Why do you configure the UART like this? It's already configured by default." }, { "prediction": "I think this should be `opae/enum.h` instead of `opae/properties.h`.", "reference": "Wow. Good catch. \"This `#include` was brought to you by the department of redundancy department.\" ;)" }, { "prediction": "I think this should be `go-logr/logr`", "reference": "Well it's actually calling `AuthorizeOrder` and this seems like a DebugLevel message to me, maybe it should be dropped entirely." }, { "prediction": "I think this should be `if (ptr == NULLptr || (bytes == 0)) return;`", "reference": "Should this be using the `CUDA_SAFE_CALL` macro here?" }, { "prediction": "I think this should be `Warning: {0} has no tests to run`.", "reference": "What cases do you see as being valid for not having any tests to run? If a test project doesn't have any tests to run we should avoid running it at the project level." }, { "prediction": "I think this should be `if mset.mirror == nil {`", "reference": "and is it possible that mset.mirror.msgs be nil? because if so, then you would get a panic also because of that." }, { "prediction": "I think this should be `pixman_region32_copy(&state->opaque, &next->opaque);` instead of `pixman_region32_clear(&next->opaque);`", "reference": "`next->opaque` should not be cleared." }, { "prediction": "I don't think we need to do this in the `processClientOrLeafAuthentication` function, but I think it would be better to do `if !acc.hasIssuer(juc.IssuerAccount) && !acc.hasIssuer(juc.IssuerAccount)`", "reference": "already what? I know what, but seems like smth. is missing in this sentence" }, { "prediction": "I think this should be `window.c2.activityCardController.update('<%=j render partial: 'proposals/details/activity', locals: {events: @events } %>');`", "reference": "Can you put spaces after the `{`and before the `}`" }, { "prediction": "I think this should be `forseti-security` instead of `forseti-security`.", "reference": "We said we would put `[ ]` around the version. `[forseti-security] [v2.3.0]`" }, { "prediction": "Why is this change needed?", "reference": "Seems len(cnb[0]) will be the length after the write since of the *v thing we saw no?" }, { "prediction": "I think this should be `Object`", "reference": "can we make use of storagepoolclaim type rather than the generic interface{} type?" }, { "prediction": "I think this should be `k.AddPeers(k.previouslyConnected()...)` instead of `k.AddPeers(k.previouslyConnected()...)`.", "reference": "this should happen before the `go k.manage()`, otherwise the node will always try the bootnodes first" }, { "prediction": "Is this change needed?", "reference": "Is this actually a lint related change?" }, { "prediction": "I think this should be `cache_key` instead of `cache_key`", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "I think this should be `opt_nonempty_str_param` instead of `opt_nonempty_str_param`", "reference": "what does this do that str_param does not?" }, { "prediction": "I think we should use `fmt.Sprintf(\"%s/%s/%s\", prefix, api, version)` instead of `fmt.Sprintf(\"%s/%s/%s\", prefix, api, version)`", "reference": "For GCP we included the API name (see below) so you can distinguish between uses other than `blob` once they exist, WDYT?" }, { "prediction": "I don't think we need to import `botocore` here.", "reference": "what would you think about doing this include on-demand within S3ObjectStore methods and then failing in a loud way?" }, { "prediction": "I think this should be `if (stopped) { break; }`", "reference": "May be better make `stopped` atomic, then it can be just `for (auto i (node.store.latest_begin (transaction_a, next_frontier_account)), n (node.store.latest_end ()); i != n && && !stopped && elections_count < max_elections; ++i)`" }, { "prediction": "I think this should be `future_chainAddEdges(r)` instead of `future_chainAddEdges(r)`", "reference": "In `src/storage/InternalStorageServiceHandler.h ` file, the client in `client->future_chainAddEdges ` should be InterStorageServiceAsyncClient?" }, { "prediction": "I think this should be `pkg/store/storepb` instead of `pkg/store/storepb`", "reference": "`go.sum` needs to be updated for this. Please run `go mod tidy`" }, { "prediction": "I think this should be `secrets-manager` instead of `secrets-manager`.", "reference": "Not sure if this was discussed previously, but is there a specific use case in mind for having this as an API field rather than a configuration option on the controller manager? Is there a specific use case in mind where one would want to choose different backends for individual Clusters/Machines vs having it a global configuration for an instance of the infrastructure provider?" }, { "prediction": "I think this should be `builder.AddMetricReader(new PeriodicExportingMetricReader(options.MetricExportIntervalMilliseconds, options.MetricExportIntervalMilliseconds));`", "reference": "Same thing with the OtlpExporter" }, { "prediction": "I think this should be `case JX_OP_CALL:` instead of `case JX_OP_SLICE:`", "reference": "Should not be removed." }, { "prediction": "I think this should be `beaker/dsl/install_utils/pe_defaults` instead of `beaker-puppet`", "reference": "Not a blocker for anything, but should this be moved to beaker-pe? Is that ticketed anywhere?" }, { "prediction": "I think this should be `beforeClickOn` instead of `afterClickOn`.", "reference": "this shouldn't be beforeClickOn, but rather beforeSubmit? and added to WebDriverEventListener. Since submit does not synthesize the 'click' events, this isn't accurate." }, { "prediction": "I think this should be `self.system_approver_emails.first` or `self.currently_awaiting_approvers.first`", "reference": "this ternary operator is hiding an `if/else` within an `if/else` - any chance we could move the logic ELSEwhere? (see what I did there -- ?? :100: )" }, { "prediction": "I think this should be `@InternalApi` instead of `@InternalApi`.", "reference": "Is this really internal? Or will the API be different in PMD 7.0.0? Well, the interface doesn't offer much functionality anyway..." }, { "prediction": "I think this should be `multiple_ragged` instead of `multiple_ragged`", "reference": "Does it have to be arrays? Isn't it ragged 'data' (i.e multiple elements of different lengths)?" }, { "prediction": "I think this should be `workflow.ForceCleanupOnError = true` instead of `workflow.ForceCleanupOnError = true`", "reference": "Per my understanding, this flag only impacts \"NoCleanup\" disk. If so, we may name it more clear. The reason of this ask is because I plan to add some other flag to force cleanup for other non-NoCleanup disks." }, { "prediction": "Why is this public?", "reference": "In my changes for `RequiresDistributionAndOrdering`, this class went away and is replaced by an inner class. I think that pattern worked well. Maybe we could do that before this one to reduce the number of changes here." }, { "prediction": "I think this should be `manaleechchance` and `lifeleechamount`", "reference": "Shouldn't this be called `hp` instead of `life`?" }, { "prediction": "I think this should be `allowedMethods`", "reference": "Because the default value of allowedOrigins is * (all origins), so it isn't necessary to set again at all." }, { "prediction": "Why is this removed?", "reference": "Undo this modification" }, { "prediction": "Why did you remove this?", "reference": "Please check my thoughts here... I changed the test to not `ToString()` attribute values. This was important to test things when `net.peer.port` was both an int or a string, but I was unsure if Zipkin supported non-string attributes." }, { "prediction": "I don't think we need to add the `Base64NoMetadata` to the `CameraResultType` class.", "reference": "Looks like you made changes on `CameraResultType` class, but didn't commit them. And you also have to do the changes on the types in @capacitor/core" }, { "prediction": "I think this should be `*bootDiskKmsProject` instead of `*bootDiskKmsProject`.", "reference": "Can you explain the history of the bug a bit, and why this fixes it?" }, { "prediction": "Use 2 (not 3) spaces for indentation.
    Use 2 (not 4) spaces for indentation.
    Space inside } missing.", "reference": "What do you think about `mentor_mail_to` or `mentor_mail_to_link` in order to match Rails' `mail_to` method, which is what this calls? I'm not sure about this suggestion..." }, { "prediction": "I think this should be `(metricPoint.Keys == null) ? 0 : metricPoint.Keys.Length`", "reference": "Looks like this will make the check in every loop. Consider extracting the null check." }, { "prediction": "I don't think we need to do this.", "reference": "Maybe `it \"can safely be reset when there are not yet any shared example groups\"`? That's the edge case that wasn't working, right?" }, { "prediction": "I think this should be `factory` or `ssmfactory`", "reference": "naming: please use `asmfactory`" }, { "prediction": "I think this should be `if len(target.Outputs()) == 1 {`", "reference": "FYI you could use a raw string for this which removes the need for escaping the inner quotes." }, { "prediction": "I think this should be `test_is_special_key`?", "reference": "2 blank lines here (between functions)" }, { "prediction": "Why is this change needed?", "reference": "Nit: we try to avoid whitespace changes because they can easily cause unnecessary commit conflicts." }, { "prediction": "I think this is a bit confusing, but I think it would be better to use `substr($file_contents, $end_pos, 2) === '::'` instead of `substr($file_contents, $end_pos, 2) === '::'`.", "reference": "As mentioned below, I'm not sure why this is only allowing refs that are tagged with `*` at the start!" }, { "prediction": "I think this should be `equals(Object o)` instead of `equals(Object o)`", "reference": "Don't forget the {} symbols, and please use EqualsBuilder and HashcodeBuilder as possible" }, { "prediction": "I think this should be `ch := make(chan string, 1024)`", "reference": "Allocate buffer once outside loop." }, { "prediction": "I think this should be `ASSERT_TRUE(target[2].port() == system.nodes[1]->network.port());`", "reference": "It would be better to check that system.nodes[1]->network.port is somewhere in the target without specifying its exact position. But it is a very minor point and I have no string opinion on it just thought I'd mention it because our tests in general have too implementation detail." }, { "prediction": "I don't think we need to check for `access.api.exception.metadata.not.available.for.nontabular.file` here, but I think it would be better to use `access.api.exception.metadata.not.available.for.nontabular.file` instead of `access.api.exception.metadata.not.available.for.nontabular.file`", "reference": "Should this be in a bundle?" }, { "prediction": "I think this should be `Debug.Assert(Activity.Current == null || Activity.Current == activity, \"There was an unexpected active Activity on the result thread.\");`", "reference": "When Activity is lost (more precisely, ExecutionContext is lost) in the HttpModule we restore the root (HttpIn) Activity. That makes this assert invalid. I tried to fix the HttpModule so that it restores the Activity that was last running, but it is impossible to retrieve do to the way ExecutionContext works. It isn't an issue to remove the assert, but it is unnerving. Any instrumentation running in IIS reliant on Activity.Current could run into trouble." }, { "prediction": "Why is this needed?", "reference": "what was the point in moving handlers registration into a separate method?" }, { "prediction": "I think this should be `mplex.caches = append(mplex.caches, newCmdCache(state.Config))`", "reference": "At this point we probably want to ensure there's a store command set." }, { "prediction": "I don't think we need to check for `step.length-1` here.", "reference": "This code is way too complicated for what it does. I don't want to be a PITA, but what can you consider rewriting it in a simpler way? I'm talking about the whole `_getDerivationIndexes` function" }, { "prediction": "I think this should be `message.StartsWith(\"0x\")` instead of `message.StartsWith(\"0x\")`.", "reference": "Don't throw base exception, specify more precise type" }, { "prediction": "I think this should be `inputs.to(src_type)`", "reference": "Recursive -> Recursively converted -> convert" }, { "prediction": "I think this should be `has_no_struct_fields || opts.generate_object_based_api` instead of `opts.generate_object_based_api`", "reference": "why is this object API only? I think the reason why we didn't do this before was because this code was shared with Java which doesn't have value structs." }, { "prediction": "I think this should be `dockerVersion: \" + dockerVersion\"`", "reference": "just to confirm, so backend will deal with both old format and new format?" }, { "prediction": "I think this should be `T? ParseEnum(IHeadersCollection headers, string headerName)`", "reference": "huh, look at that, I wasn't aware you could constrain a type by Enum" }, { "prediction": "I think this should be `const std::string &` instead of `std::string &`", "reference": "Even though the debug parameter is effectively ignored, should this default to `false` instead of `true`?" }, { "prediction": "I think this interface should not be used anymore.", "reference": "What is the purpose of this interface? Unlike ParamDocView, it doesn't seem to be used anywhere to enable polymorphism" }, { "prediction": "I think this should be `github.com/google/uuid` or `github.com/google/caddy/onevent/hook`", "reference": "We added a library to generate a UUID for the request_id directive \"github.com/nu7hatch/gouuid\" can we uses the same one for what you want rather than add another dependency? Or if the google one is better can we remove the nu7hatch library?" }, { "prediction": "I think this should be `for i := 1; time.Duration(i)*p.pingConfig.Interval < time.Duration(i)*p.pingConfig.Timeout; i++ {`", "reference": "Shouldn't this be `i * Interval`? You're multiplying nanos with a Duration, I'm not sure what's the result :)" }, { "prediction": "I think this should be `set_protection(guard, MEMPROT_READ, MEMPROT_WRITE);`", "reference": "I guess it's not no-access to match Windows where guard pages are readable." }, { "prediction": "I think this is a bit confusing, but I don't think we need to check if the approvers are non pending.", "reference": "Not a blocker, but would probably be useful to have a `scope :non_pending_approvers` on the `Proposal` model." }, { "prediction": "Shouldn't this be `task_id` or `n_unique_pending`?", "reference": "Add trailing comma" }, { "prediction": "Why is this change needed?", "reference": "I see someone say SIGKILL can not be caught by process. The original code here about `SIGKILL` is useless?" }, { "prediction": "I think this should be `THEME_OLED_DARK`", "reference": "As it is a mobile only theme, please make sure the option appears only on mobile" }, { "prediction": "I think this should be `param_list = param.split(\",\")`", "reference": "Would like a docstring and type annotations here" }, { "prediction": "Line is too long. [98/80]", "reference": "This is an API change. Why was it made?" }, { "prediction": "I think this should be `using Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Discovery;`", "reference": "Please move using inside namespace." }, { "prediction": "I think this should be `bool? poSEnabled = false`", "reference": "shall we create some enum flags for setasmain shouldprocess and pos?" }, { "prediction": "I don't think we need this command anymore, but I think it would be better to use `findstr` instead of `findstr` here.", "reference": "Should this `PUPPET_AGENT_STARTUP_MODE` have a corresponding yardoc change?" }, { "prediction": "Why is this removed?", "reference": "Why not simply remove the `pytest` import now that it's not needed anymore? :wink:" }, { "prediction": "I think this should be `[TestClass]` instead of `[TestClass]`", "reference": "Yeah, not filled in yet." }, { "prediction": "I think this should be `col-xs-12` instead of `col-xs-12`", "reference": "don't use style. Use a class instead. reducing `col-xs-12` down to 8 or 6 or whatever should do the trick" }, { "prediction": "I think this should be `if (table != null && table != metaCache.getTable(database, tableName)) {`", "reference": "should we also do `reloadCache` when database is null?" }, { "prediction": "I don't think we need this method.", "reference": "Why not just return QueryMol directly? Why require the copy?" }, { "prediction": "I think this should be `os.path.join(os.path.dirname(__file__), '../../', fname)`", "reference": "Could you add a docstring?" }, { "prediction": "Metrics/LineLength: Line is too long. [101/120]", "reference": "looks like you added newlines after blocks in a few files - I generally like newlines before/after multi-line blocks _except_ when the end the block is directly nested inside another block (eg: two `end`s next to each other) what do you think?" }, { "prediction": "Why is this change needed?", "reference": "@jlerbsc 's fix in #2918 in action - thanks! :smiling_face_with_three_hearts:" }, { "prediction": "I think this should be `if not zero_count and not count:`", "reference": "nitpick: Please lower-case `Zero_count` (as it's a literal argument name) and `Argument` here." }, { "prediction": "Why is this change needed?", "reference": "change the name of the function to match its functionality? account IsIssuing?" }, { "prediction": "I don't think we need to do this, but I think it's better to do `by = [...]` instead of `by = [...]`", "reference": "for later: add docstring (can just copy paste Pandas')" }, { "prediction": "I think this should be `archerMocks` instead of `climocks`.", "reference": "nit: @sonofachamp pointed out to me that the idiomatic way is \"archermocks\" (lowercase for package names)" }, { "prediction": "Why is this removed?", "reference": "Ugh I'm stupid, can you change this to `yarpc.InternalErrorf`?" }, { "prediction": "I think this should be `table.name() + \".all_data_files`", "reference": "We instantiate some metadata tables in tests so I kept the old constructor too. Won't harm if someone is using it directly too." }, { "prediction": "I think this should be `if (queryOptions.limit != null && queryOptions.perDocumentLimit != null)`", "reference": "I think the better place to put this might be `lib/options/PopulateOptions.js`. That should make it easier - checking options in `populate()` can get confusing." }, { "prediction": "I think this should be `*net.UDPConn` instead of `*net.UDPConn`.", "reference": "Lets have simple function arguments here, because now struct `traversal.Params` started to have 2 purposes: 1. used as contract in DTO between consumer-provider 2. as function parameters for internal code calls" }, { "prediction": "I think this should be `RemoteDistributorTest`", "reference": "Probably best not to have an empty test...." }, { "prediction": "I don't think we need this blockquote.", "reference": "`image_tag` in the `testimonials` files?" }, { "prediction": "I think this should be `if (this action fails, the execution must be failed)`", "reference": "I believe flow.toObject() method is throwing NPE if SLA option list (i.e. this.executionOptions.getSlaOptions()) is null or one of the value in the list (i.e. this.executionOptions.getSlaOptions()) is null. If that is the case we could fix root cause of NPE in the ExecutableFlow.toObject() method. The corresponding code to populate SLA options can be modified as follows. final List> slaOptions = Optional.ofNullable(this.executionOptions.getSlaOptions()).orElse(Collections.emptyList()).stream() .filter(Objects::nonNull) .map(slaOption -> slaOption.toObject()) .collect(Collectors.toList());" }, { "prediction": "I think this should be `favicon.ico` instead of `/favicon.ico`", "reference": "So I haven't tested this - but since the icon location is just directly dumped into the img _src_ attribute, won't this cause issues with Ghost blogs in a subdirectory? If I'm misunderstanding what the purpose of the default is then let me know " }, { "prediction": "I think this should be `int result = RUN_ALL_TESTS();` instead of `int result = RUN_ALL_TESTS();`", "reference": "Why swallow the exception here rather than propagate it?" }, { "prediction": "I think this should be `column_names` instead of `column_names`.", "reference": "How about `column_index_names`? `column_names` sounds ambiguous." }, { "prediction": "I think this should be `write.metadata.metrics.column.conf.prefix`", "reference": "+1 on this. Do we want to have it as `WRITE_METRICS_MODE_COLUMN_CONF_PREFIX` to be consistent with defaults? Is there a possibility we will have `READ_METRICS_MODE_COLUMN_CONF_PREFIX`? Not sure." }, { "prediction": "Why is this change needed?", "reference": "Shall we use different inputs for `PySpark < 2.4` where `transpose` won't work with different data types." }, { "prediction": "I think we should move this to `_dask_stubs.compat`", "reference": "we should sort the headers like in spark: public packages, then pyspark, then internal" }, { "prediction": "I think this should be `if t.options.clientTLSConfig != nil {`", "reference": "looks like we should drop this var from the transport options struct" }, { "prediction": "Why is this removed?", "reference": "Ah, yeah, this is the test for the validation that I mentioned in a remark above about relaxing the validation." }, { "prediction": "I think this should be `valid_border`?", "reference": "For tensors, it is better to illustrate the shape." }, { "prediction": "I think this should be `request.url().match( 'google-site-kit/v1/data/')` instead of `request.url().match( 'google-site-kit/v1/data/')`", "reference": "This was removed in a recent PR for the admin bar, but should have been kept. It's been restored in the other admin bar PR but I've added it here to for completeness." }, { "prediction": "I think this should be `Assert.Equal(\"Microsoft.AspNetCore.Hosting.HttpRequestIn\", activity.OperationName);` or `Assert.Equal(\"Microsoft.AspNetCore.Hosting.HttpRequestIn\", activity.OperationName);`", "reference": "nit: probably swap the if condition and `if/else` and check `NETCOREAPP2_1` which looks more natural." }, { "prediction": "I think this should be `return ea != nil && ea.latency != nil`", "reference": "for the tag, should it be `requestor_rtt` since the other is `responder_rtt`?" }, { "prediction": "I think this should be `return rcv._tab.MutateByte(a + flatbuffers.UOffsetT(j*1), n)`", "reference": "The one sad part of this is that is will generate a lot of overhead if you loop through a vector, since it obtains the vector every time. But with the current API there is no alternative I guess, and it is better to have the option than not." }, { "prediction": "I think this should be `github.com/ipfs/go-ipfs-files`", "reference": "nit: there should be a newline between `types` and `go-ipfs-files`." }, { "prediction": "I don't think we need to add a `RetryAfterDuration` variable to the `reacher` package.", "reference": "would be nice to have this as a parameter (Options), re: technical debt discussions" }, { "prediction": "I think this should be `org.apache.commons.lang3.ArrayUtils`", "reference": "complete ignorance here but is it ok to import this from `com.sun`? can it break under non-oracle JREs?" }, { "prediction": "I think this should be `spanProcessors.Load().(spanProcessorMap)` instead of `spanProcessors.Load().(spanProcessorMap)`", "reference": "Is this some way of saying that the span is going to be sampled? I'm basing this question on the condition I saw for the `OnEnd` to be called - `mustExport := s.spanContext.IsSampled() && )`. Shouldn't the condition be `s.spanContext.IsSampled()` to match the condition for calling the `OnEnd`?" }, { "prediction": "I think this should be `err := volumereplica.GetAndUpdateSnapshotInfo(c.clientset, cvr)`", "reference": "just calling UpdateSnapshotInfo() should be fine" }, { "prediction": "I think this should be `DefaultLogMessageRateLimit` instead of `DefaultLogMessageRateLimit`.", "reference": "Was `DefaultLogMessageRateLimit` not configurable anywhere?" }, { "prediction": "I think this should be `testTime.EXPECT().After(gomock.Any()).AnyTimes()`", "reference": "Please use the `assert` instead. Same below." }, { "prediction": "I think it would be better to use `suche as Europe or Overseas` instead of `suche as Europe or Overseas`", "reference": "Owww, I think I found a typo. `suche`" }, { "prediction": "Why is this removed?", "reference": "This can happen because we could get `PhantomNodes` that are not admissible as source/target right?" }, { "prediction": "I think this should be `structsEqual(&tls.ClientSessionState{}, &tls.ClientSessionState{})`", "reference": "Should we add a note here to file a bug if this ever happens?" }, { "prediction": "I think this should be `return NumCurrentBenchmarks, nil`", "reference": "overflow is still possible, isn't it?" }, { "prediction": "I think this should be `false` instead of `false`.", "reference": "This seems more like a personal preference, so maybe this should be in your `~/.rspec`?" }, { "prediction": "Why is this needed?", "reference": "To avoid a circular import between pcapdnet and automaton" }, { "prediction": "I think this should be `# pylint: disable=no-member`", "reference": "Please remove this blank line." }, { "prediction": "I think this should be `InitWorkloadIdentityStatus` instead of `InitWorkloadIdentityStatus`", "reference": "it feels that the WorkloadIdentityCondition should be added to this Status... And if you have workload identity enabled, but not working, then you can mark that condition failed, and also Mark the ready false... not entirely sure though" }, { "prediction": "I think this should be `if (provoking_vertex_state_ci && !enabled_features.provoking_vertex_features.provoking_vertex_last)`", "reference": "I think these got refactored to `LvlFindInChain` to better conform with the coding guidelines. I think MarkL left these in for backwards compatibility." }, { "prediction": "Why is this removed?", "reference": "It's fine for this PR, but in the future try to minimize unrelated changes." }, { "prediction": "I think this should be `ansible/plugins/modules` instead of `ansible/plugins/modules`", "reference": "The library -> modules and filters -> filter path changes are breaking changes or?" }, { "prediction": "Why is this import needed?", "reference": "Can we encapsulate this check (`os.environ.get(\"TEST_TARGET\") == \"AWS_CLOUD\"`) into a small config/util function? (and also use it in `integration/conftest.py`) (I'd generally try to avoid accessing `os.environ` directly across the codebase. I'm aware that we're already doing this in a few places, but maybe we can start pulling things out - this will also help us create more systematic config/environment abstractions as we go...)" }, { "prediction": "Why is this needed?", "reference": "An `if` statement would be better here. Functions, concat and reverse are all very expensive." }, { "prediction": "I think this should be `GetCanonicalFactoryAddress(chainID int64)` instead of `GetCanonicalFactoryAddress(chainID int64)`", "reference": "`Log here: connect to default factory for goerli network

    `" }, { "prediction": "Why is this change needed?", "reference": "nits, should add `break` to avoid redundant iterations." }, { "prediction": "I think this should be `Assert.False(provider.AccountExists(_address1).Should().BeFalse());`", "reference": "I think we want an exception here, there should never be a transfer to a nonexisting account." }, { "prediction": "I think this should be `info` or `finest`.", "reference": "This code is new and not tested well. While we may drop the log level before we ship 4.0, right now this is extremely helpful to users." }, { "prediction": "Why is this change needed?", "reference": "Can we make these asserts more strict/precise? I remember this test helped to spot the issue of inconsistent results on different platforms due to using `sort` instead of `stable_sort`." }, { "prediction": "I don't think we need this method anymore, but I think it would be better to use `Pathname(executable).extname` instead of `Pathname(executable).extname` instead of `Pathname(executable).extname`", "reference": "I thought about adjusting for case here as well? For example `.rb,rb,.RB,.rb` would all map to ruby interpreter specified? Is that too much \"magic\"? Is there a sane workflow that someone would choose to map `.rb` to one interpreter and `.RB` to another?" }, { "prediction": "I think this should be `g_return_val_if_fail(self, NULL);`", "reference": "In this and the one below, should we assert `self != NULL` first?" }, { "prediction": "Why is this change needed?", "reference": "Why this is needed?" }, { "prediction": "I think this should be `self.meta or None`", "reference": "we already have .meta() so I don't think we want get_meta() for PackageEntry" }, { "prediction": "Why is this change needed?", "reference": "question: can we always get the startts from dagrequest?" }, { "prediction": "I think this should be `const propertyID = fixtures.accountsPropertiesProfiles.properties[0].id;`", "reference": "Nit-picking, but this can be simplified to reference `properties[ 0 ]` since that is already retrieved 2 lines above." }, { "prediction": "I think this should be `@unresolved_targets.delete(target.name)` instead of `@resolved_targets.delete(target.name)`", "reference": "This technically works because we call `get_targets` before we remove the target, so it's bound to have been resolved. But I'm not sure I would like to rely on that assumption. Should we also remove it from `@unresolved_targets` to be safe?" }, { "prediction": "I think this should be `orElse(new Code()).orElse(new Code()).orElse(new Code()).orElse(new Code()).orElse(new Code()).orElse(new Code()).orElse(new Code()).orElse(new Code()).orElse(new Code()).orElse(new Code()).orElse(new Code()).orElse(new Code()).orElse(new Code()))`", "reference": "So what happens if I try to get code on a EOA?" }, { "prediction": "I think this should be `isinstance(inferred, astroid.NamedTuple)` instead of `isinstance(inferred, astroid.NamedTuple)`", "reference": "Can't we return an empty list and then just compare the lengths? Thereby removing this `if`." }, { "prediction": "I think this should be `this.passesRestrictions = this.passesRestrictions.bind(this)`.", "reference": "Mb change it to 'doesPassRestrictions()'? Doesn't sound enough like a boolean-returning method to me." }, { "prediction": "I don't think we need the `Index` argument here.", "reference": "TODO: in fact At when used with noncurrent time should not return a next index. only latest should.." }, { "prediction": "`Array.isArray(tmp)` should be `Array.isArray(tmp)` and `Array.isArray(tmp)` should be `Array.isArray(tmp)`", "reference": "There are scenario's where we skip an update with a placeholder, in this case tmp returns null with render, this is not an array so we `[null]` it" }, { "prediction": "I think this should be `Tuple2> List(List.Nil nil)`", "reference": "@danieldietrich, this wasn't tested so I presumed it wasn't working before either :p" }, { "prediction": "Why is this needed?", "reference": "Please leave two empty lines after the `use` statement" }, { "prediction": "I think this should be `k8s.io/kubernetes/pkg/kubelet/cm`", "reference": "Please move this import in the 3rd group which is for external dependencies" }, { "prediction": "I think this should be `isinstance(node.get(RESERVED['file'], str))`", "reference": "So what exactly is this fixing? The unit test is passing with or without this change." }, { "prediction": "I think this should be `std::string(it->second->path()).rfind('/') + 1`", "reference": "auto targetFile = fs::FileUtils::joinPath(newPath, folly::stringPrintf(\"%019ld.wal\", it->first));" }, { "prediction": "I think this method should be called `snapshotIdsBetween(Table table, long fromSnapshotId, long toSnapshotId)` instead of `snapshotIdsBetween(Table table, long fromSnapshotId, long toSnapshotId)`", "reference": "I don't see any place that checks whether the from snapshot is an ancestor of the to snapshot. That seems like a requirement for this to work correctly to me." }, { "prediction": "I think this should be `if (isset($functionConfig['helpText']) && $functionConfig['helpText'] !== null) {`", "reference": "Other calls to getHelpText() are wrapped in an `isset()` check. Would it make sense to be consistent, and either restore that here or remove it elsewhere?" }, { "prediction": "I think this should be `@configuration.output_stream ||= out`", "reference": "Why the change? If `output_stream` is set to something non-nil, it seems odd (and potentially wrong) to overwrite it...." }, { "prediction": "Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body beginning.", "reference": "Thinking this should have an underscore." }, { "prediction": "Why is this change needed?", "reference": "To accommodate the change to the method being private." }, { "prediction": "I think this should be `PropertyNamesCamelCase` instead of `PropertiesNamesCamelCase`", "reference": "Shouldn't we traverse all definitions and apply this rule over all model definitions in the doc" }, { "prediction": "I think this should be `public static`", "reference": "Please rename this class that it ends with the suffix \"Test\" - otherwise the tests won't be executed." }, { "prediction": "I don't think we need this file anymore, but I think it would be better to add `@wordpress/prettier-config.js` to this file.", "reference": "As a JS file, this should also receive our standard file header." }, { "prediction": "I think this should be `numBMOsInFrag` instead of `numBMOsInFrag`.", "reference": "I take it memQuotaRatio is an \"out\" parameter at line 1810? Also, why use MIN_QUOTA in both the cases of memQuota being too low and too high? Contrast this code with RelRoot::codeGen where we set MIN_QUOTA only in the too low case." }, { "prediction": "I think this should be `s.SetDefaults(gcpauthtesthelper.ContextWithDefaults())`", "reference": "It looks like for newpullsubscription, we have two functions. One for pullsubscription with default, one for pullsubscription without default. If you remove setdefault here, then there is no differences between these two functions." }, { "prediction": "I think this should be `Decimal` or `DecimalDecimal`.", "reference": "not dramatic, but why 32bits if we allow a range that is smaller than 8?" }, { "prediction": "I don't think we need to add this field to the `ClientPromise` struct.", "reference": "- Use type from `service_discovery/dto/price.go` - Rename `Price` -> `Money`" }, { "prediction": "I think this should be `Either success = Either.right(new AtomicInteger(42));` and `Either failure = Either.left(new Exception(\"error\"));`", "reference": "one space missing at the beginning" }, { "prediction": "I think this should be `*string` or `*string`", "reference": "I worry that having `Platform` as `string` instead of `*string` would result in it getting overriden with `\"\"` if the environment manifest config doesn't specify `platform` . If it gets overridden as `\"\"`, that could be a problem for users that are not using `linux/amd64` right? If this indeed is a potential impact, could we double check in `ApplyEnv`'s unit test? Same with the `Platform` in `TaskConfig`. Sorry for not seeing this in my previous review!!! " }, { "prediction": "shouldn't this be `host + '/api/external/'`?", "reference": "I like the new directory `/api`, what is the thinking behind `/external`?" }, { "prediction": "Why is this change needed?", "reference": "staticcheck flags this: replace with `for k := ..`" }, { "prediction": "Why do you need this?", "reference": "There's already a sleep right above" }, { "prediction": "I think this should be `if (strpos($var_id, 'self::') === 0) {`", "reference": "This feels hacky, is there a better way?" }, { "prediction": "I don't think we need to import `collections.OrderedDict` here.", "reference": "Can we move this logic into the `boto.compat` module? Then it's just `from boto.compat import OrderedDict` instead. Also, this is introducing a new dependency. What about users on 2.6.x that don't have the OrderedDict module installed? We may need to fall back to an ordinary `dict` so that existing code in the wild does not break." }, { "prediction": "I think this should be `public JsonSerializerSettings SerializationSettings { get; private set; }`.", "reference": "\"Gets the JSON serialization settings.\" would be better?" }, { "prediction": "I don't think we need the `/file/{addr}` route here.", "reference": "The endpoint should be in plural `/files`." }, { "prediction": "I think this should be `struct MDLDummy{};`", "reference": "??? Why do we need to have a different API in Python? Oh, wait, I see what you did. It's to fake the namespaces. Given that I don't think the namespaces are necessary, and that less of these should be exposed anyway, I think these should go." }, { "prediction": "Why is this change needed?", "reference": "I think this line is gofmt issue? @daixiang0" }, { "prediction": "I think this should be `assert.Equal(t, pkg, pkg2)`", "reference": "probably better to assert the values directly; technically you could pass this test with an implementation that always returned \"\" for the subrepo for example." }, { "prediction": "Why is this change needed?", "reference": "line is 161 characters (from `lll`)" }, { "prediction": "I think this should be `java.io.Serializable`.", "reference": "Are these changes needed?" }, { "prediction": "Why is this change needed?", "reference": "It seems like reducing the sensitivity would make the test failure less likely to occur, but not fix the issue?" }, { "prediction": "Why not use `Tools\\I18nTimestampableTrait`?", "reference": "missing use statement for importing the full namespace" }, { "prediction": "I think this error should be `ErrIncorrectAddressFormat`", "reference": "Generally error messages in Go shouldn't start with capital letter. I see this rule is broken in many places here. Why?" }, { "prediction": "Why is this change needed?", "reference": "These test checks if selection coordinates don't return negative values in that edge cases. Please revert the changes and set `autoWrapCol` and `autoWrapRow` to `false` to the Handsontable instance. This change applies to the entire Core_selection.spec.js file." }, { "prediction": "I think this should be `CommitAndRestoreWithZeroGasPrice = CommitAndRestore | ZeroGasPrice,`", "reference": "I would prefer flag SkipGasPricingValidation" }, { "prediction": "I think this should be `blocks.find(root_a)` instead of `blocks.end()`.", "reference": "could be `const &` ?" }, { "prediction": "I think this should be `hideProgressAfterFinish` instead of `hideUploadButton`", "reference": "The docs should also be updated with the new option." }, { "prediction": "I think this should be `aws_access_key_id` and `aws_secret_access_key`", "reference": "Name is _way_ to generic for this patch to be accepted I think. Can you rename it to maybe `send_sns_notification` or something else you find suitable?" }, { "prediction": "Why is this change needed?", "reference": "Out of the scope." }, { "prediction": "I think this should be `forEach` instead of `forEach`.", "reference": "I think we need an if block to check that if this API is really missing. We wouldn't want to override the browser's implementation." }, { "prediction": "I think this should be `typeof name === 'string'`", "reference": "I was wondering, things like EDITOR_TYPE, VALIDATOR_TYPE, RENDERER_TYPE are not obligatory. Therefore if the custom editor will be registered with this method, `name` will be set to `undefined`. Should we handle this scenario?" }, { "prediction": "Why is this removed?", "reference": "This line should not be removed, as it is not the description of the package, but a copyright header." }, { "prediction": "I think this should be `Tag`?", "reference": "Wouldn't it be more space efficient to make this a `byte` enum or bitfield?" }, { "prediction": "Why is this change needed?", "reference": "Flake8 doesn't like the assignment, but non-use of `e` here. I think we can just remove the try/except here for `cursor.execute(sql)`." }, { "prediction": "I think this interface should be `ASTAnyTypeBodyDeclaration`", "reference": "Maybe add short example list: .... type body declarations, such as AnnotationMembers, Methods, Fields" }, { "prediction": "I don't think we need to add the `timeouts` and `timeouts` as well.", "reference": "These are really meant to be the keys in the capabilities, not the keys of values within the capabilities" }, { "prediction": "I think this should be `String.valueOf(this.table.getName())`.", "reference": "It is debatable whether we have to default this. I did this to avoid breaking custom implementations." }, { "prediction": "Why is this removed?", "reference": "# `attr_value['string'] is not None` probably not required as `attr_value['string'] == value` check is already being done" }, { "prediction": "I think this should be `addon` instead of `addon`", "reference": "we shouldn't need the \"addon\" rename" }, { "prediction": "Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.", "reference": "These are covered by routing constraints." }, { "prediction": "Why is this change needed?", "reference": "Could we use just a normal string here?" }, { "prediction": "I think this should be `hasSymbolSupport = isFunction(Symbol) && Symbol.iterator;` or `hasSymbolSupport = isFunction(Symbol) && Symbol.iterator;`", "reference": "`isFunction(Symbol)` triggers a `ReferenceError` if Symbol is undefined. Using `typeof Symbol === 'function'` is OK however." }, { "prediction": "I think this should be `else` instead of `else`", "reference": "Is there an else clause (with a lock.unlock ()) missing here as well? If we think we do not need an else clause then lets add an else clause containing assert zero." }, { "prediction": "Why is this change needed?", "reference": "do we foresee `32` ever changing? (as well as its use in error checking in `clerk.go`) if \"no\" this is fine, if \"yes\" it's probably still fine" }, { "prediction": "Why is this needed?", "reference": "you don't need to create a enum for this, java allows you to switch on a string ;) (since java 7?)" }, { "prediction": "I don't think we need to load the roles in the ember cache.", "reference": "This should be `modelPromises.roles = this.get('store').query('role', ...` and the promise body should just `return roles;`. This is because the `model()` hook will pause for the returned promises to be resolved before continuing so when returning `RSVP.hash` you end up with a hash containing the values returned from the promises so the controller and everything else relying on the `model` object doesn't need to worry about things being async." }, { "prediction": "I think this should be `nodeIsHeader && nodeIsHeader && !parent.tagName.toLowerCase() === 'header'`", "reference": "This is basically a repeat of `main-is-top-level.js`. I suggest having these 3 checks point to the same evaluate file. You can change what element they test through the rule selector as well as the check.json options property. So you would have `main-is-top-level.json`, `banner-is-top-level.json` and `contentinfo-is-top-level.json` each point to `landmark-is-top-level.js`, and pass in a different `options` object which tells it what element you're trying to test." }, { "prediction": "I think this should be `if (core != null) MDCLoggingContext.setCore(core);`", "reference": "Why do we need this check? setCore already handles nulls." }, { "prediction": "I think this should be `__dir__` instead of `__dir__`.", "reference": "good catch, thanks. This is going to make the user experience much better." }, { "prediction": "Why is this needed?", "reference": "TODO: remove this unused import" }, { "prediction": "I think this should be `square/go-jose: compact JWS format must have three parts` or `square/go-jose: compact JWS format must have three parts`", "reference": "Hmm leaking the library name out in the Workload API doesn't seem great. Do we want to catch these errors and return a canned \"could not parse token\" or something instead?" }, { "prediction": "I think this should be `./gradlew` instead of `./gradlew`", "reference": "I think `-f gradlew` is better for code unity" }, { "prediction": "I think this should be `source.iceberg.reader.fetch-record-batch-size`.", "reference": "Is there precedent for this config key? What other keys are similar? The others in this file start with `table.exec.iceberg`. Is there a reason for not continuing with that convention?" }, { "prediction": "Is this needed?", "reference": "Can we avoid no-change changes being committed - they make it harder to distinguish actual changes from code editor changes" }, { "prediction": "I think this should be `AWS Identity and Access Management (AWS IAM) server certificate`.", "reference": "AWS Identity and Access Management (IAM)" }, { "prediction": "Why is this removed?", "reference": "You dont use this dependency anymore" }, { "prediction": "I think this should be `assertTrue(\"ENABLE_JSON1 flag not found in compile options\", compileOptions.contains(\"ENABLE_JSON1\"));`", "reference": "Here is the test that checks that the sqlcipher in use was compiled with the right flags" }, { "prediction": "Why is this change needed?", "reference": "Turns out that if the hosts are not in an `array`, an `Exception` is not thrown anymore :-( It simply returns `null`. So, we need to attempt to parse a `string` outside the `catch` block for it to work." }, { "prediction": "I don't think we need to add this to the `TestRestTemplateBuilder` class, but I think it's better to add it to the `TestRestTemplateBuilder` class.", "reference": "this test only covers the happy path. what about no acceptable rest template found?" }, { "prediction": "I think this should be `LOG.info(String.format(\"Firefox Session %d assigned to %s\", i, chromeSession.getUri()));`", "reference": "Since this is in a test, I imagine that the choice of `info` level was deliberate." }, { "prediction": "I think this should be `testing`", "reference": "this should probably be named somewhere if you want to reuse it." }, { "prediction": "I think this should be `bound-service-account-signing-key.key`", "reference": "needs a rename to not include AWS" }, { "prediction": "I think this should be `oneapi/dal/backend/primitives/reduction.hpp` instead of `oneapi/dal/backend/primitives/blas.hpp`.", "reference": "Isn't sigma have `double` type?" }, { "prediction": "Why is this changed?", "reference": "May be better use nano::keypair that generates ramdom value?" }, { "prediction": "I don't think we should check the size on the safe side, but I think we should check the size on the safe side and check the size on the safe side.", "reference": "I think the more complete solution will save off a `ignoreUndefined` in the base class for the bulk operation (with a default of `false`), and use that for calculations. Was there a reason you didn't want to support the option from the operation level?" }, { "prediction": "I think this should be `logger.e(this, \"runSync\", re);` or `logger.e(this, \"runSync\", re);`", "reference": "The catch (Exception e) block that follows does an updateSync, which will get a SmartStore instance (while logging out is taking place) - and then terrible things will happen - a database gets created for the outgoing user that won't be openable by the returning user causing the app to crash at logout. This is a somewhat superficial fix - SmartStore should not return an instance for an outgoing user." }, { "prediction": "Why do we need this?", "reference": "huh does this work without a `Return`?" }, { "prediction": "I think this should be `metadata[:execution_result][:pending_exception] = e` instead of `metadata[:execution_result][:pending_exception] = nil`", "reference": "Don't think we want this line, right? (Plus \"failing\" is spelled wrong)." }, { "prediction": "I think this should be `isLocalFeed` instead of `isLocalFeed`.", "reference": "I think it would be more clear to have local-feed-hiding all in one place (bottom of this method?). Further up the method, there already is some code that hides the website icon, for example." }, { "prediction": "Why did you remove this?", "reference": "Why remove this one? It doesn't work yet, but we'll add it sooner or later." }, { "prediction": "Why is this needed?", "reference": "Why did you remove the struct tags?" }, { "prediction": "I think this should be `get_bza_report_info` instead of `get_bza_report_info`", "reference": "Let's be neutral with tag names. Let's just have \"ReportURL\"" }, { "prediction": "I think this should be `time.Unix(1585674086, 1234)`.", "reference": "Use an explicit time to ensure conversion is not copy-paste and wrong." }, { "prediction": "I don't think we need to use `strstr` here.", "reference": "The logic now is to look for ``. This `` output is also not consistent with the other two functions you mentioned. Do the other two RPCs not report an error?" }, { "prediction": "Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.", "reference": "Use nested module/class definitions instead of compact style." }, { "prediction": "I think this should be `t.Log(\"Init KBFSOps\")`", "reference": "Do you think we need to keep this in, or is it just leftover personal debugging? Seems like it wouldn't be too useful most of the time, but I don't care too much if you want to keep it." }, { "prediction": "I think this should be `config.TB()` instead of `config.TB()`.", "reference": "showNPCs is not needed" }, { "prediction": "I think this should be `fmt.Sprintf(\"parameter %s already exists\", e.name)`", "reference": "Docstring for public function pls" }, { "prediction": "I think this should be `error when creating \\\"/tmp/apply-475927931\\\": namespaces \\\"openshift-am-config\\\" not found\\\"", "reference": "This should use `t.Errorf` instead. You want the second part of the test to run even when the first part fails." }, { "prediction": "I think this should be `if (ctx.protocol_selector.ratio.http3 > 0) {`", "reference": "Should this if block better be changed to `#if H2O_USE_LIBUV \\n #else ... #endif`? The reason I wonder is because that's the way the QUIC context is being initilaized at the beginning of this function. Though I would not expect practical difference between the two approaches, because ATM the only case where we create QUIC connections is when the protocol selector is set to non-zero, and because when it is set to non-zero `h2o_quiy_close_all_connections` becomes a no-op." }, { "prediction": "I think this should be `Object.is(hookState._value[0], nextValue)` instead of `Object.is(hookState._value[0], nextValue)`", "reference": "`Object.is` is an ES6 feature of JS so I don't think we can use it here (or we have to change our browser support matrix or specify that an Object.is polyfill is pre-req of `preact/hooks`). Should we just do an `===` check in `preact/hooks` and provide a `Object.is` polyfill and version of `useReducer` in `preact/compat`?" }, { "prediction": "I don't think we need to check for `typeof options.roles === 'string'` here.", "reference": "This was a bug I picked up by using the TS interface as a guide, this seems like it was / is the intention, also is a bug in master (needs port)" }, { "prediction": "I think this should be `WITH_COLLECTION` or `COLOCATED_WITH`.", "reference": "It would be helpful to explicit here what this really means and assumes." }, { "prediction": "I think this should be a `map[string]*big.Int` instead of a `map[string]*big.Int`", "reference": "`ExpectedBalances` is a global variable (from `gochecknoglobals`)" }, { "prediction": "I think this class should be `SynaxSnippetExtractor` instead of `SnippetExtractor`", "reference": "This is another place where I'd feel more comfortable with declaring the class private. We can always make it public in the future if someone makes a case for that, but I prefer to err on the side of privateness for things like this that 99% of RSpec users won't have a reason to use." }, { "prediction": "I think this should be `if optIssuerAccount != \"\" {`", "reference": "Feels like this should be left as is and add a new createClientWithIssuers or something like that. Avoid all the \"\"" }, { "prediction": "I think this should be `if (authCallback != null && authCallback.receivedErrorResponse(error)) {`", "reference": "Minor unrelated bug in the IDP flow where the error wasn't getting displayed as a `Toast`." }, { "prediction": "I think this should be `mongoErrorContextSymbol` instead of `mongoErrorContextSymbol`", "reference": "I thought we got rid of this thing?" }, { "prediction": "Why is this removed?", "reference": "Please convert int params as well." }, { "prediction": "Why is this change needed?", "reference": "Fixed bug in implementation. Now I can run the validator from the VS Tools menu, double-click on an output line, and navigate to the site of the issue." }, { "prediction": "I think this should be `DD_HTTP_SERVER_ERROR_STATUSES` and `DD_HTTP_CLIENT_ERROR_STATUSES`", "reference": "Can we rename this field to `HttpServerErrorCodes` or `HttpServerErrorStatuses`? It will contain a list of status _codes_, not a list of _errors_. (Personally I prefer \"codes\" over \"statuses\", but we can't change `DD_HTTP_SERVER_ERROR_CODES`.)" }, { "prediction": "(style) line over 80 characters", "reference": "would you please use: flb_utils_bool(...) here ?, that function wraps the on/off/true/false stuff." }, { "prediction": "I think this should be `(ex)` instead of `(ex)`", "reference": "`invocationInfoTokensToRedact: null` (I really like the convention of using a named parameter whenever the value doesn't communicate the meaning, such as for literal values.)" }, { "prediction": "Why do we need this?", "reference": "maybe renamed to `async_simple_test` if we consider supporting aug test later on?" }, { "prediction": "I think this should be `apply_default_attributes` instead of `apply_default_attributes`.", "reference": "So where is default_attributes now? Is it used anywhere else still? If not, can it be removed along with any tests of it?" }, { "prediction": "Why is this change needed?", "reference": "We could move this to the base class and remove all these changes. What do you think?" }, { "prediction": "Line is too long. [98/80]", "reference": "While we're doing some translation work, could you extract this button text and the other static text from the view?" }, { "prediction": "I think this should be `if (headersValue != null && replaceTokens(headersValue, contextInfo, false)) {`", "reference": "Nit: Please fix indentation (note: Azkaban uses 2 spaces and not tabs)." }, { "prediction": "Why is this change needed?", "reference": "This change is necessary because the schema version is ignored unless a schema is specified. I think that has always been the intent." }, { "prediction": "I think this should be `DR_WINDOWS_VERSION_10_1803` instead of `DR_WINDOWS_VERSION_10_1803`", "reference": "The api/docs/release.dox changelog message is missing: maybe you planned to add it once NtAllocateVirtualMemoryEx and NtMapViewOfSectionEx support is in? I would say, add it here in the same diff that raises max_supported_os_version." }, { "prediction": "I don't think we need to check the `aria-hidden` attribute here.", "reference": "Just do: `return node.hasAttribute('aria-hidden')`" }, { "prediction": "I don't think we need the `forgotten` button here.", "reference": "Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping." }, { "prediction": "Shouldn't this be `_processId` or `_processMachineName`?", "reference": "Do we need `_processDataPoisoned`? Can the name or the id of the current process ever change? Or the machine name?" }, { "prediction": "I think this should be `os.Unsetenv(\"NOTIFY_SOCKET\")`", "reference": "Did it not work out to wait until after containerd and kubelet are started?" }, { "prediction": "I think this should be `increasedamage` or `increasedmanaget`", "reference": "variable names suggestions from me: - damageboost, ITEM_PARSE_DAMAGEBOOST, \"damage boost +x%\" - healingboost, ITEM_PARSE_HEALINGBOOST, \"healing power +y%\" - managainboost, ITEM_PARSE_MANAGAINBOOST, \"mana restoration +z%\" alternatively the other names can stay, because \"increase\" convention isn't that bad, just change mana values to: - \"increasemanarestored\", ITEM_PARSE_INCREASEMANARESTORED, \"mana restoration +z%\"" }, { "prediction": "I think this should be `bool` instead of `bool`.", "reference": "Why can't this be determined by 'PARTIAL_SUCCESS' in the `status` field?" }, { "prediction": "I think this should be `!is_numeric($id) && !is_numeric($mediaId)) {`", "reference": "Does it make sense to generate a Exception here? Maybe yes, because it wouldn't make sense to generate a path without the id of the media right?" }, { "prediction": "Why is this needed? I think it's better to use `SSLSocketFactory.getInstance(null, null)` instead of `SSLSocketFactory.getInstance(null, null)`", "reference": "This should be made private." }, { "prediction": "I think this should be `a.getBaseSVIDPath()`", "reference": "perhaps this is better modeled as a pkg-level var?" }, { "prediction": "I think this should be `#define MAX_PRECISION_ALLOWED` and `#define MAX_SCALE_ALLOWED`", "reference": "I don't think there is a maximum scale, neither for Hive nor for Trafodion. The only condition right now is that the scale can't exceed the precision. Example of a valid scale: DECIMAL(18,18). The maximum of 6 digits applies only to TIMESTAMP columns, where we don't support resolution below microseconds." }, { "prediction": "I don't think we need this function anymore, but I think it should be `UpdateProjectStaticUser` and `UpdateProjectSingleSignOn`", "reference": "`ctx` is unused in UpdateProjectStaticUser" }, { "prediction": "I think this should be `String.format(String.format(\"https://content.googleapis.com/discovery/v1/apis/%s/%s/rest\", apiName, apiVersion));`", "reference": "Why is this not the default, and why only for JS?" }, { "prediction": "Align the parameters of a method call if they span more than one line.
    Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "A repository has many badges so we should also add type column in scope." }, { "prediction": "I think this should be `result.CodeFlows[0].Locations.ToArray().Should().Equal(new []());`", "reference": "Now a hash set, so can't index into it." }, { "prediction": "I think this should be `!!ENV['PSModulePath']`", "reference": "@jpogran Does this seem like a reasonable way to know if we're in powershell vs. CMD or *sh?" }, { "prediction": "Please use `String#startsWith(String, StringComparison)`", "reference": "1.toLowerCase(Locale.US)? 2.where is accept bug fix?" }, { "prediction": "Why is this removed?", "reference": "We should still be providing something to the user in the case of a `KeyError` instead of a stack trace!?" }, { "prediction": "Why not use `await _blockchainBridge.GetNonceAsync(onBehalfOf)`?", "reference": "check Lukasz's fix with NonceReserving - is that not better?" }, { "prediction": "I think this should be `this.sourceBlock_.setColour(colour, colour, colour);`", "reference": "Would you explain why here please? E.g. from the PR description > the renderer expects to be able to use the secondary color as the fill for a shadow." }, { "prediction": "I think this should be a `defer`", "reference": "Lock needs to go to `RecoverFromDb` instead. Here it may cause deadlocks. My convention was that un-exported functions do not lock, only exported ones (with name starting with a capital letter)" }, { "prediction": "I think this should be `super.getDomains(\".de\");`", "reference": "German keyboard would also be used in Austria and Switzerland, so this should have included `.at` and `.ch`." }, { "prediction": "Why is this removed?", "reference": "since this makes the indexer thing really only used for a single table, now, you can put in a TODO for me to cleanup and simplify this" }, { "prediction": "I think this should be `NSCD_SOCKET_VOLUME_NAME` and `NSCD_SOCKET_VOLUME_MOUNT_PATH`", "reference": "Should we have this path passed from the Azkaban properties? If this is the standard path for nscd even outside LinkedIn, then we can keep it." }, { "prediction": "I think we should not rely on the stream name.", "reference": "Could be a non-public field. `allowNoSubject`" }, { "prediction": "I don't think we need the `skipCacheLookup` argument here, but I think it would be better to pass `skipCacheLookup` to `reallyExecute`.", "reference": "Don't think this is quite right - think the build one also needs an `IsOriginalTarget` (c.f. code in `src/build`)" }, { "prediction": "I think this should be `@param array $targetEntityConfig` instead of `@return array`", "reference": "what about adding typehints instead? I don't think we need to add docblocks for every private methods." }, { "prediction": "I think this should be \"compression=on\" instead of \"compression=on\"", "reference": "Is it fine to pass the \"-o compression=on\" in the middle instead of at the end ?" }, { "prediction": "I don't think we need the `load_config` option here.", "reference": "Probably make them all keyword arguments." }, { "prediction": "Why is this removed?", "reference": "Why not just check the backdrop setting here as well for the time being? We can combine the code later but at least then it would be configurable if people like the backgrounds." }, { "prediction": "Why is this change needed?", "reference": "why are we turning this one into a Warning?" }, { "prediction": "I think this should be `String.valueOf(sourceIDs.size()) + \" separate files\"", "reference": "Wouldn't it be better to use double quotes for the opening parenthesis ?" }, { "prediction": "I think this should be `static_cast(player->blessings.to_ulong());` or `static_cast(player->blessings.to_ulong());`", "reference": "Remove the cast" }, { "prediction": "Why is this changed?", "reference": "What criteria do we use to bump the copyright years? An update to the module?" }, { "prediction": "I think this should be `results['gt_semantic_seg'] = gt_seg` instead of `results['gt_semantic_seg']`", "reference": "should we rm line 269?" }, { "prediction": "I think this should be `self._isNvdaStartupComplete = True` instead of `self._isNvdaStartupComplete`", "reference": "Perhaps the code at `source/core.py:564: postNvdaStartup.notify()` should be queued instead? If we are saying the loop must have started before NVDA's startup is complete, then the `postNvdaStartup` action is incorrect." }, { "prediction": "I think this should be `after :create` instead of `after :create`.", "reference": "Needed this for testing locally with mail view but not used for any tests. Might be nice to have some seed scripts at some point." }, { "prediction": "I think this should be `fromApplicationStatusValue(response.Header.Get(ApplicationStatusHeader))`", "reference": "wait, if we only do this for successful status codes won't we miss a whole slew of responses? We should be checking this for all codes right?" }, { "prediction": "I think this should be `library.yaml` instead of `library.yaml`", "reference": "Adding in the service yaml `library.yaml` here." }, { "prediction": "Why is this change needed?", "reference": "Why is this dereference needed?" }, { "prediction": "I think this should be `RemoveDir` instead of `RemoveDir`.", "reference": "Might want to add that this only happens if you have write permissions to the folder." }, { "prediction": "I don't think we need a `*bool` here.", "reference": "Adding a small blurb about why someone would want to enable this flag would help clarify what it is for. Such as something about when providing a custom retry handler and how`ShouldRetry` will be handled with and without the flag enabled." }, { "prediction": "Why is this change needed?", "reference": "assume the user will be able to register for a custom service name in future?" }, { "prediction": "Why is this needed?", "reference": "The extra two empty lines seem unnecessary. Please review your diffs more carefully." }, { "prediction": "Why is this needed?", "reference": "What the reason to embed the Oracle?" }, { "prediction": "I don't think we need this route anymore.", "reference": "Shouldn't this happen automatically with High Voltage?" }, { "prediction": "I think this should be `varReference` instead of `localVarName`.", "reference": "This is changed because we need `projectId` to be printed as `$projectId` in PHP." }, { "prediction": "I don't think we need this change, but I think it would be better to use `templates.first.customization_of.present? ? _('Template Customisation History') : _('Template Customisation History')`", "reference": "This title change seems more accurate to me however not sure if this will confuse users." }, { "prediction": "I don't think we need this regex anymore, but I think it should be `^(?:wikipedia|xxxx):wikipedia$/i`", "reference": "Here (and on line 158 as well), would it be more efficient to use the String end_with() method? Not tested" }, { "prediction": "I think this should be `self._data = collections.deque(self._data, maxlen=capacity)`.", "reference": "Why are you creating a new (second) `RAMHandler` here? Is this just an oversight from deleting the previous code?" }, { "prediction": "I think this should be `if (req.get_if_not_exists() || req.get_if_not_exists() || req.get_if_not_exists() || req.get_if_not_exists() || req.get_if_not_exists() || req.get_if_not_exists()) {`", "reference": "Move the line 27 to line 31 is better?" }, { "prediction": "I think this should be `NewRekeyRequestEvent` instead of `NewRekeyNotNeededEvent`.", "reference": "In slack I mentioned we should only do this if the update is from some other device, to make sure our own updates don't cause issues. Maybe the revision check above is good enough to prevent this, but I just want to make sure you thought about it." }, { "prediction": "I think this is a good idea to remove the `--seed` option.", "reference": "I would instead explain that random is the default, but you can switch back to defined, or another ordering scheme." }, { "prediction": "I don't think we need to check for `height` and `width` here.", "reference": "Is there a reason you left this at 0?" }, { "prediction": "I think this should be `if (rememberMeServices instanceof AbstractRememberMeServices)` instead of `if (key == null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null) { if (rememberMeServices instanceof AbstractRememberMeServices) { rememberMeServices = getRememberMeServices(http, key); if (rememberMeServices != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null && this.logoutHandler != null", "reference": "The value of `key` will never be `null` at this point, because `getKey()` will generate a value if it is `null`." }, { "prediction": "I think this should be `if (tracer.Settings.AdoNetExcludedTypes.Contains(commandType.FullName))`", "reference": "NIT: You should first check if AdoNetExcludedTypes.Count is greater than 0 before calling Contains (fast-path)" }, { "prediction": "I think this should be `strings` instead of `strings`", "reference": "should rearrange so as to follow import ordering." }, { "prediction": "I think this should be `true` instead of `false`.", "reference": "what is the use case for create workflow with completed state?" }, { "prediction": "I think this should be `RemoteDistributorTest`", "reference": "Probably best not to have an empty test...." }, { "prediction": "I don't think you need this line.", "reference": "Missing the license" }, { "prediction": "Why is this removed?", "reference": "Looks like this was previously guarded by `EnableCleanupReplicationTask` flag. Now looks like this is always needed. Just want to confirm the intention is if `GlobalNamespace` is enabled then we want run cleanupReplicationTasks in all cases?" }, { "prediction": "Why is this removed?", "reference": "Potentially it'll be good to remove all of them excluding \"tbb/tbb.h\" But let's do it next time " }, { "prediction": "I think this should be `if not density:`", "reference": "I would just mention which tolerance - namely as reported by ``sys.float_info``" }, { "prediction": "I think this should be `alter_query` instead of `alter_query`", "reference": ":+1: Ideally this'll become something you could pass in to the config" }, { "prediction": "Why is this change needed?", "reference": "Should using `thenValue` to replace `then` ?" }, { "prediction": "I think this should be `if (!Tracer.Instance.Settings.IsIntegrationEnabled(IntegrationName)) { return; }`", "reference": "This follows the convention of each callback starting with the `IsIntegrationEnabled` check." }, { "prediction": "I think this should be `bool` instead of `bool`.", "reference": "this is not required to be part of this PR right? (With UpDownCounter being absent in .NET, we can make this hardcoded for now, i think)" }, { "prediction": "I think this should be `IConnectionContext`", "reference": "Add the PipeFactory here" }, { "prediction": "Why is this removed?", "reference": "please add `var _ impltypes.ChaosImpl = (*Delegate)(nil)`" }, { "prediction": "I don't think we need to add a `@param clean = true` parameter here.", "reference": "nit: is this added deliberately?" }, { "prediction": "Use 2 (not 0.0.0.0) spaces for indenting an expression spanning multiple lines.
    Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Prefer single-quoted strings when you don't need string interpolation or special symbols.", "reference": "Given the number of tests which need this (I think I counted seven) should we maybe just install this one globally? Is there even a place to do that? Something in `test_helper` maybe?" }, { "prediction": "I don't think this is a good idea, but I think it would be better to use `typeof maybePromise === 'function'` instead of `typeof maybePromise.then === 'function'`.", "reference": "we don't use this anymore, so we can delete it." }, { "prediction": "I think this should be `fmt.Fprintln(os.Stdout, \"algoh telemetry configured from file:\", telemetryConfig.FilePath)`.", "reference": "nit: change to \"Telemetry configuration loaded from '%s'\"" }, { "prediction": "Why is this change needed?", "reference": "Why did this value change?" }, { "prediction": "I don't think we need to add the `gcpduckv1alpha1` package here.", "reference": "maybe `duckpubsubv1alpha1` ?" }, { "prediction": "I think this should be `manifest.json` instead of `manifest.json`.", "reference": "The id is not mandatory for web extensions. Could you update this to support a web extension without an id?" }, { "prediction": "Why remove this?", "reference": "I actually prefer them to be defined here. Client who calls `lib` should define the args, not `lib` itself." }, { "prediction": "I think this should be `epollConsole.Close()` instead of `epollConsole.Close()`", "reference": "I think this should've been done with the `defer`-named-return trick. I'll submit a PR for it." }, { "prediction": "Why not use `std::make_shared(*this, nano::tcp_endpoint(*this, config.websocket_config.port));`?", "reference": "The bind address should be configurable." }, { "prediction": "Why do we need this?", "reference": "Maybe the empty `delete()` should be implemented as default in the interface." }, { "prediction": "I think this should be `src/caffe/test/test_data/sample_data.h5` instead of `src/caffe/test/test_data/sample_data.h5`", "reference": "How to ensure CMAKE_SOURCE_DIR is set correctly?" }, { "prediction": "I think this should be `init.Bytes()` instead of `init.Bytes()`", "reference": "safer to make a copy of incoming *big.Int" }, { "prediction": "Why is this changed?", "reference": "how did we choose this value? does this hold good for Windows too?" }, { "prediction": "I think this should be `errors.New(\"Checkpoint/restore not supported\")`", "reference": "To follow the other build tags, maybe we can call it `criu`?" }, { "prediction": "I don't think we need this.", "reference": "Should we load this from the config file too?" }, { "prediction": "I think this should be `@every 5s` instead of `@every 5s`", "reference": "Can you file an issue for this?" }, { "prediction": "Why is this change needed?", "reference": "@nbbeeken what were the cases where `!!this[kIsMaster]` was yielding an incorrect value? we should try to cover them in the tests" }, { "prediction": "I think this should be `config.merge_transport_data(inventory['config']['transport'], inventory['target_hash'])`", "reference": "This whole function feels messy. I don't have a better idea at the moment though." }, { "prediction": "I think this should be `@Nullable` instead of `@Nullable`.", "reference": "should use Number instead of Long" }, { "prediction": "I think this should be `mock.Provider`.", "reference": "Can you rename this and the file `InfluxDBProvider` and `influxdb_provider.go` respectively?" }, { "prediction": "I think this should be `vlen = vchildren ? vchildren.length : 0`", "reference": "This is the real culprit, as now vlen will always be a Number (and known to the compiler as such). You could probably go one step further and avoid the ToBoolean on `vchildren` as well by writing something like `vlen = (vchildren !== undefined) ? vchildren.length : 0` if that matches the contract." }, { "prediction": "I think this should be `textNoDataString`", "reference": "missing space before `TextView`" }, { "prediction": "I think this should be `if (!propStream.read(openContainer)) { return ATTR_READ_ERROR; }` instead of `if (!propStream.read(openContainer)) { return ATTR_READ_ERROR; }`", "reference": "so this attribute is used as u8 in code, but saves as int32? Why?" }, { "prediction": "I don't think we need to add `adaptivescalar` to the `_CLASS_ATTR_MAP` dict.", "reference": "can RDSE be added to the list? It has its capnp files." }, { "prediction": "Why is this change needed?", "reference": "These functions only ever read from the API and should always be reading from a cache, so I have made that explicit by expecting a Reader here and supplying a `cache.Cache` as the client." }, { "prediction": "(style) line over 80 characters", "reference": "No, we can't skip any of the mangling after the suspend point: this should follow the other mangling and undo its push." }, { "prediction": "Why is this needed?", "reference": "this is generated code.. these changes will need to be made in the code generator to have them stick." }, { "prediction": "I think this should be `typeof document.body.attachShadow === 'function'`", "reference": "Should we abstract this into a reusable utility so it doesn't have to get repeated in every test file needing Shadow DOM support?" }, { "prediction": "I think this should be `const runUnifiedTest = require('./unified-spec-runner/runner');`", "reference": "Maybe we rename this to `command_monitoring.test.js` to match the directory name change? Or would you rather do that as part of the greater test cleanup? I'm fine either way." }, { "prediction": "I think this should be `String` instead of `String`", "reference": "Why is this change necessary? `handleSingle()` will cast it to a string, no?" }, { "prediction": "I think this should be `String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(String.format(table))))))`)));`)`));`)`)", "reference": "This newly added method should be well defined, should it return `TableIdentifier` or just `String`?" }, { "prediction": "I think this should be `MULTIPLE_MESSAGE`.", "reference": "have a relation with a product" }, { "prediction": "I think this should be `podExists` instead of `podExist`?", "reference": "I guess that there is still a window here, because the GC could happen between the `PodExist` and `Delete` calls. Would it be better instead to check `err` and allow it if it says \"pod has already been deleted\"?" }, { "prediction": "Why is this removed?", "reference": "SQLAlchemy's session management does magic to make sure that if the rollback fails you still get the original exception that caused the rollback. Also it looks nicer." }, { "prediction": "Why is this change needed?", "reference": "This switch statement can be removed. Just return q.items[act.Nonce] != nil" }, { "prediction": "I think this should be `n.equals(n.getParent().getChild(1))` instead of `n.equals(n.getParent().getChild(1))`", "reference": "I think `==` for nodes is more readable than equals. An equals calls looks like it could be recursing, because intuitively two nodes are equal if their subtree are the equal. But everywhere you replaced, we don't want to test whether the subtrees are structurally equal, we want to know whether they're the same. Only `==` captures this intent, using equals obscures this. Not to mention that equals may NPE and is in that sense less ergonomic. I think we should enhance the rule with a list of types for which `==` is correct. Edit: in the meantime i think we could suppress those new violations..." }, { "prediction": "I think this should be `Filter the benchmarks by name using glob pattern(s). Optional.`", "reference": "What's the scenario for passing multiple filters?" }, { "prediction": "I don't think we need to use `std::get<0>` here. I think it would be better to use `std::get<1>(logEntry)` instead of `std::get<3>(logEntry);`", "reference": "move to after check log.empty()" }, { "prediction": "I think this should be `note` instead of `note`", "reference": "This line needs to be removed" }, { "prediction": "I think this should be `com.google.cloud.build.event.statusChanged`", "reference": "Can we delete such const like `CloudBuildSourceEvent` and `CloudBuildSourceBuildId` since all those are contained under schemas/v1?" }, { "prediction": "I think this should be `vsphere-platform-name` instead of `vsphere-platform-name`.", "reference": "This is unused." }, { "prediction": "I think this should be `new CompositePropagator(new System.Collections.Generic.List()`, not `new CompositePropagator(new System.Collections.Generic.List());`", "reference": "Any reason not to put `using System.Collections.Generic` (guess there shouldn't be naming conflicts)?" }, { "prediction": "Use 2 (not 3) spaces for indentation.
    Use 2 (not 4) spaces for indentation.
    Use 2 (not 4) spaces for indentation.
    Use 2 (not 4) spaces for indentation.
    Use 2 (not 4) spaces for indentation.
    Use 2 (not 4) spaces for indentation.
    Use 2 (not 4) spaces for indentation.
    Use 2 (not 4) spaces for indentation.
    Use 2 (2) spaces for indentation. Use 2 (2) spaces for indentation.
    Use 2 (not 4) spaces for indentation.
    Use 2 (not 4) spaces for indentation.
    Use 2 (not 4) spaces for indentation.
    Use 2 (not 4) spaces for indentation.
    Use 2 (not 4) spaces for indentation.
    Use 2 (not 4) spaces for indentation.
    Use 2 (not 4) spaces for indentation.
    Use 2 (not (1) spaces for indentation).", "reference": "Could the name of this controller just be shortened to `TwitterCardsController`? Is the `Player` there adding information?" }, { "prediction": "I think this should be `uh.Dynamic == false`", "reference": "Backends with hostnames that depend on the request are always up?" }, { "prediction": "I think this should be `JsonPointerException` instead of `JsonPointerException`.", "reference": "I'd rather catch those to `utils.py` and raise a simple ValueError from them. From the resource point of view, these are details of implementation" }, { "prediction": "Why is this removed?", "reference": "make this 1.0 ? I don't think all that many people do `language: julia` without any `julia:` specifiers, but may as well keep that possible?" }, { "prediction": "I think this should be `AZURE_KEYVAULT_AUTH_VIA_CLI`", "reference": "nit: `AZURE_KEYVAULT_AUTH_VIA_CLI` is defined by us, so it might be helpful to differentiate it from azure's env names. Maybe starts with `GOCDK`." }, { "prediction": "Why is this needed?", "reference": "Depend on interfaces not on structures" }, { "prediction": "Why not just call `notifyStop` here?", "reference": "This fix looks good. My concern, don't forget to fix metad too!" }, { "prediction": "I think this should be `!(earliest.BID() == NullBranchID && latest.BID() == LocalSquashBranchID)`", "reference": "Just noticed this nil context. Perhaps plumb through ctx too, or change to `Debug`?" }, { "prediction": "Line is too long. [98/80]", "reference": "Does it send requests with urlencoded bodies anywhere? I thought it sends only json. Maybe content-type should be `application/json` by default?" }, { "prediction": "I think this should be `const uint16_t DEFAULT_ROS2_SERVER_PORT = 11811;`", "reference": "Again use of `constexpr` is recomended." }, { "prediction": "I don't think we need to import the layout algorithm here.", "reference": "Minor point but I would call this ``redim_graph`` instead." }, { "prediction": "I think this should be `sigs.k8s.io/cluster-api/pkg/controller/noderefutil`", "reference": "As I was trying to figure out how the error messages are written out, since they are returned from `getOrCreate` and `reconcile`, it looks like we are using plain `klog` to write them out instead of using the logger from the scope above" }, { "prediction": "I think this should be `log.Warn(natLogPrefix, \"Failed to enable IP forwarding: \", err)`", "reference": "Now it's double logging, is not it? Because `service.ipForward.Enable()` logs extra `warning`" }, { "prediction": "Line is too long. [103/80]", "reference": "Whatever the decision is about the request type to use, this should only match what is needed and not the other one." }, { "prediction": "I think this should be `if (localConnection && localConnection.type == Blockly.OUTPUT_VALUE)` instead of `if (localConnection && localConnection.type == Blockly.OUTPUT_VALUE) {`", "reference": "...and in turn, this should probably be var updatePreviews = true; if (!(localConnection && localConnection.type == Blockly.OUTPUT_VALUE) && (Blockly.localConnection_ && Blockly.highlightedConnection_)) { since the first clause is a no-op. If you want to leave it this way for clarity, that's fine too." }, { "prediction": "Why is this removed?", "reference": "Please remove this TODO, since they will not apply anymore after you are done. :) Can you please remove this everywhere else in this PR?" }, { "prediction": "I think this test should be removed.", "reference": "This seems like an incomplete schema definition. will that have any effect on the tests?" }, { "prediction": "I don't think we need to check if `filename != nullptr && CheckCanLoadFromBin(filename) == \"\"`", "reference": "The testing cases are failing because `SetHeader` does not only handle cases where input are from files. It also reads categorical feature indices from the config parameters (see the part outside the `if (filename != nullptr) { ... }`). Skipping `SetHeader` directly here will cause errors when we load data from numpy or pandas arrays (where `filename == nullptr`) and use categorical features. So I think we should move the the check `filename != nullptr && CheckCanLoadFromBin(filename) == \"\"` into `SetHeader`. That is, we change `if (filename != nullptr) { ... }` into `if (filename != nullptr && CheckCanLoadFromBin(filename) == \"\") { ... }`" }, { "prediction": "I think this should be `if err != nil && err.Sys().(syscall.WaitStatus) == syscall.SIGTERM {`", "reference": "I think we should change the variable name of `err` in `if err, ok := err.(*exec.ExitError); ok `, this re-assignment of `err` still affects the next `else` branch" }, { "prediction": "I don't think we need to do this in the future, but I think it would be better to use `std::string` instead of `std::string`.", "reference": "`Status` has identical semantics with `StatusOr`." }, { "prediction": "I think this should be `/mutate/addlabels` instead of `/mutate/addlabels`.", "reference": "why is this named in a different style from other paths?" }, { "prediction": "I think this should be `util.IsPaused(cluster, awsCluster)` instead of `util.IsPaused(cluster, awsCluster)`", "reference": "Swapped these to ensure that we aren't passing a nil cluster in to util.IsPaused" }, { "prediction": "I think this should be `platformPkgManagerTuple` instead of `platformPkgManagerTuple`.", "reference": "I don't see pkgManager used anywhere, is there a reason we need this?" }, { "prediction": "I think this should be `instanceDir.toAbsolutePath()` instead of `instanceDir.toAbsolutePath()`.", "reference": "A bit late, but I don't think this is necessary, as all callers will send absolute paths. And if you ever get a relative path, resolving it with `toAbsolutePath()` leads to it being relative to whatever CWD the app is started with, while the typical resolving of relative `instanceDir` is to resolve it relative to CoreContainer#coreRootDirectory." }, { "prediction": "I think this should be `modelSchema.paths[localField] = modelSchema.paths[localField] || modelSchema.paths[localField]`", "reference": "There's an awful lot of test failures here because `localFieldPathType.schema` may not contain a `getters` array." }, { "prediction": "Line is too long. [82/80]", "reference": "Mysql allows for `||` concatenation (e.g. `firstname||' '||surname`) if you enable it: `set sql_mode=PIPES_AS_CONCAT;`. I think this check is safer though" }, { "prediction": "Why is this changed?", "reference": "NOTE: this is the default ENS registry address. If the ENS suite is deployed from the current builds to any chain, it will always be found at this address." }, { "prediction": "I think this should be `draw:vanity` instead of `draw:vanity`", "reference": "I'm curious why you are using `draw` in this route file?" }, { "prediction": "I think this should be `ctx.Handle(404, \"GetRawDiff\", err)`.", "reference": "Those variables are only been used once, I think we don't need to create them at all, just pass values to the `GetRawDiff` directly." }, { "prediction": "Why is NET452 removed?", "reference": "I like the idea of replacing all the `#if NET461` with `#if NETFRAMEWORK`... is that worth doing now? Means fewer changes if we go to 4.7.2 at some point " }, { "prediction": "I think this should be `clutchProvider`", "reference": "to fix the docs build failure, make this const var named without the suffix `Name`" }, { "prediction": "I think this should be `fallthrough` instead of `fallthrough`", "reference": "This bugfix also included, in case a subjectAlternativeName was present in the cert, then URIs (e.g SVID SPIFFE auth) would not have been attempted." }, { "prediction": "I think this interface should be `FileProvider` instead of `FileProvider`.", "reference": "Same here. Feels like the wrong location." }, { "prediction": "I think this should be `download_path_suggestion` instead of `download_path_suggestion`", "reference": "Please make `_path_suggestion` public (i.e. remove the `_`) in `downloads.py`." }, { "prediction": "I think this should be `external-port-443-is-local-port`", "reference": "Woah, these flag names gotta get shorter. (Edit: I'll try to suggest some if needed, will think on it.)" }, { "prediction": "I think this should be `app.secrets.secret_key_base` instead of `app.config.secret_key_base`", "reference": "Is this the code that's supposed to use the Rails app's only when in Rails4? What's the point of the first `if app.respond_to?(:secrets)`, both the `if` and the `elsif` have the same body, is only the second one needed? If `app.config` has a `secret_key_base`, then use it, the end. Is there a need for first checking if `app.respond_to?(:secrets)`?" }, { "prediction": "I think this should be `m_is_objc_enum = enum_decl->isObjC();` instead of `m_is_objc_enum = enum_decl->isObjC();`", "reference": "Does this not apply to C enums on Linux?" }, { "prediction": "I think this should be `isRetryableWriteError` instead of `isRetryableWriteError`", "reference": "Should this check if the error is `RetryableWriteError` before adding the label?" }, { "prediction": "I think this is a bit confusing, but I don't think it's a good idea to have a `.default` property in the `rollup-plugin-commonjs` package.", "reference": "Oh wow, that's one complicated require :)" }, { "prediction": "I don't think we need the `Go` tag here.", "reference": "do you mean how to \"use\"" }, { "prediction": "Is there a reason we don't have a `ref` property on the backing node?", "reference": "We can't really test this anymore since ref and props.ref are at the backing node level now" }, { "prediction": "I think this should be `FileScanTask` instead of `FileScanTask`.", "reference": "Did you intend to set this in the constructor?" }, { "prediction": "I think this should be `if err != nil { return s.defaultAMILookup(\"ubuntu\", \"18.04\", machine.Machine.Spec.Versions.Kubelet)`", "reference": "This looks fine as a first approach, and can we put a TODO here about ubuntu 18.04 being hardcoded?" }, { "prediction": "I think this should be `#ifdef USE_OPENCV` instead of `#ifdef USE_OPENCV`", "reference": "This isn't strictly needed since lmdb / leveldb data that is unencoded does not require OpenCV IO. I think `DataLayer` should only require lmdb / leveldb. If one tries to use encoded data without OpenCV the `DataTransformer` guards will report the dependency failure." }, { "prediction": "I think this should be \"unable to apply hiveapi cluster role binding\" instead of \"unable to apply hiveapi cluster role binding\"", "reference": "Should we take out this change? This was only in there to try to brute force the start of the apiserver yesterday." }, { "prediction": "Align the parameters of a method call if they span more than one line.
    Space inside } missing.", "reference": "I worry that this association name is a bit confusing. Yoz was asking me about the concept of completion yesterday, which is why I think of it. It wasn't clear to him exactly what it was. what about calling this a `step_completer` ? we know that a proposal has many steps, so I think that might be clearer. in the future, we also might want the rename the `approver` relation because a step is not always an approval these days." }, { "prediction": "Why is this removed?", "reference": "Just add a to-do saying we need to add api-version in the check some time in the future when we enable the single-swagger spec mode for validation." }, { "prediction": "I think this should be `setDefaultDatasource('thelia');`", "reference": "@lunika Please see this. It allows us to do `Propel::getConnection()` easily, as we have only one database." }, { "prediction": "Why is this change needed?", "reference": "Not related to this particular cast but I wonder if we shouldn't have a cast helper that would log if null to gain visibility." }, { "prediction": "I think this should be `files(${DRIVE_FILE_FIELDS})`, not `files(${DRIVE_FILE_FIELDS})`.", "reference": "why do we need to explicitly declare these fields?" }, { "prediction": "I think this should be `VuFind\\OAI\\Server` instead of `VuFind\\OAI\\Server`", "reference": "Note that there are multiple OAI servers -- that's why `$serverClass` is a variable here. You'll want to fetch `$serverClass` from the service manager rather than a hard-coded value, and also set up a module.config.php for the authority record version, `VuFind\\OAI\\Server\\Auth`. Should be easy enough since it can share the same factory." }, { "prediction": "Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
    Layout/SpaceInsideHashLiteralBraces: Space inside } missing.", "reference": "This is no longer needed and should be removed." }, { "prediction": "I think this should be `*json.RawMessage` instead of `*json.RawMessage`.", "reference": "could use named return params here to avoid declaring the opts, and using naked returns instead." }, { "prediction": "I think this should be ``", "reference": "this is an unrelated fix. I noticed when an instagram carousel post is mixed with images and videos, the videos don't come with thumbnails, so I am adding a fallback thumbnail for this case." }, { "prediction": "Why is this needed?", "reference": "\"... after protocol version 1\"?" }, { "prediction": "I think this should be `OBJECT` instead of `OBJECT`", "reference": "Is there a unit test that covers this regexp? I am afraid that changing it might break things =/" }, { "prediction": "I think this should be `@var` instead of `@`", "reference": "This change is okay IMO because an `@` variable in Ruby is not a reference -- `@` variables are instance variables. Also, it's never used by the Ruby transformers." }, { "prediction": "Why is this change needed?", "reference": "Why this change was needed? Because in `po` files it's with curly braces?" }, { "prediction": "I think this should be `(off + 0x100000 < 0x200000)`", "reference": "Wait -- where did this change come from? This seems unrelated to trace building and seems like it could affect basic execution, unlike the rest of this PR which is all under the off-by-default trace option. Please separate this into its own PR and probably ask @AssadHashmi to review." }, { "prediction": "I think this should be `@docusaurus/core/lib/babel/preset` instead of `@docusaurus/core/lib/babel/preset`.", "reference": "seems to be redundant (mention `docusaurus` )" }, { "prediction": "I don't think we need this interface.", "reference": "Can we combine this with the Rollback API? We could still support the `rollback` method here, but combine `Rollback` and `CherryPick` into something like `ManageSnapshots`. Then we could reuse logic for enforcing checks of the current snapshot. What do you think?" }, { "prediction": "(style) please, no space before tabs", "reference": "Maybe just `env_prefix`, I don't think this is referring to the WQ manager." }, { "prediction": "Why is this removed?", "reference": "Unrelated line change :)" }, { "prediction": "I think this should be `utilwait`", "reference": "I raised an eyebrow at making `net` depend on `k8s.io`, but it seems we're already doing that." }, { "prediction": "I think this should be `html.replace(\"Countly\", countlyGlobal.company);` or `html.replace(\"Countly\", countlyGlobal.company.replace(\"Countly\", countlyGlobal.company.replace(\"Countly\", countlyGlobal.company.replace(\"Countly\", countlyGlobal.company.replace(\"Countly\", countlyGlobal.company.replace(\"Countly\", countlyGlobal.company.replace(\"Countly\", countlyGlobal.company));`", "reference": "I think ticket meant, not applying replacement in this method, but rather applying encodeSomeHtml to each and every localization string" }, { "prediction": "I don't think we need to check for `error == null` here.", "reference": "ticket for the 4.0 epic?" }, { "prediction": "I think this should be `cfg.model.neck.rfp_backbone.pretrained = None`", "reference": "`cfg.model.get('neck')` will return None if neck does not exist, thus we can omit the default value." }, { "prediction": "I don't think we need to use `Blacklight::Solr::FacetPaginator` here, but I think it's better to use `Blacklight::Solr::FacetPaginator` instead of `Blacklight::Solr::FacetPaginator`.", "reference": "Trailing whitespace detected." }, { "prediction": "I think this should be `cxx-flags` instead of `cxx-flags`.", "reference": "I don't see why a `cxxflags` key is necessary? C flags are important in the target file because they define things like the float ABI. But these flags are also used for C++. I can't think of a reason why you would want to configure C++ flags in a target file." }, { "prediction": "(style) line over 80 characters", "reference": "Update year range in Copyright notice, and elsewhere too." }, { "prediction": "I think this should be `AccessKeyID` or `SecretAccessKeyRef`.", "reference": "Can we update this PR to not be a breaking change? i.e. if a user specifies `accessKeyID`, it is still used. But if a user specifies `accessKeyIDSecretRef`, it takes precedence?" }, { "prediction": "I think this should be `params[:decline] || params[:read_tou] == \"0\"` instead of `params[:read_tou] == \"0\"`", "reference": "You don't actually need both tests here as \"truthiness\" means that `\"0\"` is false and hence the first test will be true..." }, { "prediction": "I don't think we need this link anymore.", "reference": "Everything else in here is using `I18n`. Should we do that here to be consistent?" }, { "prediction": "I think this should be `tcp:22` instead of `tcp:22`", "reference": "What do you think about changing the ordering to be `::`? I think it matches the most with what we previously had so that it doesn't change too much for our users." }, { "prediction": "Why is this change needed?", "reference": "I'm fairly sure this precondition is always true due to the mod (%)" }, { "prediction": "I think this should be `assert !seen.contains(info.info.name)`", "reference": "I love seeing diffs like this one, adding a `String` message to an otherwise cryptic `assert`! It makes me realize you must have had a hellacious debugging session!" }, { "prediction": "I don't think this is a good idea.", "reference": "1. No logger exists to produce a message 2. Can't assume the latest version because missed version means 0." }, { "prediction": "I think this should be `sha1($this->level);`", "reference": "I saw a wrong reuse of the cache between a partial analysis of a single file and a full run where errors due to lack of context on the first partial run was reported on the full run. Shouldn't we use a hash that is composer.lock + psalm.xml + command line to be safe?" }, { "prediction": "I think this should be `isinstance(self.index, ks.DatetimeIndex)`", "reference": "Could you also update it in `at_time`?" }, { "prediction": "I don't think we need to use `Boolean.parseBoolean` here. I think we should use `Boolean.isNullOrEmpty(LOCALITY_WHITELIST_FS.contains(scheme))` instead of `Boolean.isNullOrEmpty(LOCALITY_WHITELIST_FS.contains(scheme));`", "reference": "Because schema is non-final we can't just switch this to a lambda" }, { "prediction": "I think this should be \"While resolving function '{0}' follwing exception occured: {1}\"", "reference": "proposal: **always** add the exception to the end of the message. So no need to to pass exception twice (implicit and explicit). Need a lot of changes." }, { "prediction": "I think this should be `monitor.getLifeTimeInQueue().increment(event.getInQueueNanoTime());` or `monitor.getConsumerCall().increment(event.getInQueueNanoTime());`", "reference": "why? event.getInvocationType is not you want?" }, { "prediction": "I think this should be `git_hash_hash` or `git_hash_hash`", "reference": "nit: how about `GitSHA`?" }, { "prediction": "This should be `#define FAIL_DIR \"makeflow.failed.%d\"`.", "reference": "If you move the other functions, this should also be moved to `makeflow_gc.h`." }, { "prediction": "I think this should be `if 'duration' in listen['track_metadata']['additional_info'] :`", "reference": "This whole block bugs me. Expire_time to me suggest that an absolute time of when something happens and duration is an interval of time. While the code looks correct, it feels awkward to read." }, { "prediction": "I don't think we need to clone the vnode here.", "reference": "Can we add `_dom` as an argument to createVNode here? I think it might be shorter (could totally be wrong!)" }, { "prediction": "(style) line over 80 characters", "reference": "I think that the iret handling is not yet good." }, { "prediction": "Why is this change needed?", "reference": "Huh, that's kinda weird. I get it, but it's unexpected to me..." }, { "prediction": "Why is this removed?", "reference": "why is this removed? it is important when you upload from stream of unknown size" }, { "prediction": "Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
    Layout/SpaceInsideHashLiteralBraces: Space inside } missing.", "reference": "Out of curiosity, why is this needed? Does it enforce what class can be assigned?" }, { "prediction": "I think this should be `if addr.Network() == \"unix\" {`", "reference": "non-blocking: Now that we have a handful of statements which deal with creating a listener, it may make sense to introduce a `createListener` method or something similar" }, { "prediction": "Why is this needed?", "reference": "factory should be stateless if possible, looks like much complexity added" }, { "prediction": "I think this should be `self.output().table.project_id` or `self.output().table.project_id`", "reference": "Could you please add short description for the default value as well?" }, { "prediction": "I think this should be `logger.Fatal().Err(err).Msgf(\"Failed to commit state changes on height %d\", blk.Height())`.", "reference": "Leave a TODO message to say we will fix the log level in the future, once committing the block and the state become a transaction" }, { "prediction": "I think this should be `write.delete.parquet.row-group-check-min-record-count` or `write.delete.parquet.row-group-check-max-record-count`", "reference": "this can be integer" }, { "prediction": "This should be `font: {{ font['completion.category'] }}`", "reference": "nitpick: Please remove the blank line here" }, { "prediction": "Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body beginning.", "reference": "What is this for? The only methods I can see by that name in the rails doc are generating a foreign key name from a model class name but you seem to be giving a key name as argument?" }, { "prediction": "I think this should be `if (pkiAuthenticationPlugin != null && authenticationPlugin.plugin.getMetricRegistry() == null) {`", "reference": "Is this second check necessary? we know that just after the plugin was created its metricRegistry is null, it's set only after `initializeMetrics` has been called." }, { "prediction": "I don't think we need to check for `fromLua` here, but I think it would be better to check for `fromLua` here.", "reference": "shouldn't this be `return TALKACTION_BREAK;` as the player does not meet the required group access?" }, { "prediction": "I think this should be `minerNode1.verify(clique.blockIsCreatedByProposer(minerNode1));`", "reference": "does this still work if minerNode1 has already proposed a block before 2 & 3 are stopped?" }, { "prediction": "I think we should add a `desugar.Error(\"Adding log line for the TestCloudLogging E2E tests\", zap.String(v1.LoggingE2EFieldName, v))` to the message.", "reference": "I am wondering if we can either make this a feature or have a way to turn it off in production. My concern is that we might be adding more of these kind of code in the future." }, { "prediction": "I think this should be `pdf.index = kdf.to_pandas().stack(level=1).reset_index('level_0')`", "reference": "We can just use `.stack()` here? Then I guess we can reuse when supporting multi-index columns." }, { "prediction": "I think this should be `bool.TrueString` instead of `bool.FalseString`.", "reference": "What are the possibilities here? Since we plan on supporting .net standard 2.0 from day 1, we might as well tackle that now." }, { "prediction": "Why is this change needed?", "reference": "should the parameters be called reference or context?" }, { "prediction": "Line is too long. [89/80]", "reference": "Do we need to also change `length` here (and below) to `bytesize`? Perhaps we ought to make a copy of `in_buffer` encoded as binary and then the existing algorithm should work." }, { "prediction": "I think this should be `q.text = \"Please enter a location for {}\".format(url.toDisplayString())`.", "reference": "This should be `toDisplayString()` to not contain e.g. passwords." }, { "prediction": "I don't think we need this config anymore, but I think it would be better to add a `config.autocomplete_enabled = true` option to the controller.", "reference": "Can we just say that having a non-nil `autocomplete_path` implies that autocomplete is enabled?" }, { "prediction": "I think this should be `github.com/gogo/protobuf/proto` instead of `github.com/gogo/protobuf/proto`", "reference": "Note that the package github.com/golang/protobuf/proto is deprecated. We're instructed to use the \"google.golang.org/protobuf/proto\" package instead. I didn't want to change it now to avoid intrusive changes whose consequences are, currently, unknown." }, { "prediction": "Why is this removed?", "reference": "Are these gone routes? Do we need to 301 them?" }, { "prediction": "I think this should be `github.com/vmware-tanzu/antrea/pkg/controller/networkpolicy`", "reference": "move them to internal group of imports" }, { "prediction": "I think this should be `cStorPoolGot.ObjectMeta.Name` instead of `cStorPoolGot.ObjectMeta.Name`", "reference": "can we rewrite this as: `ignored event '%s' for cstor pool '%s'`" }, { "prediction": "I don't think we need to add a `belongs_to` here.", "reference": "not all client data types have an approving official (eg: 18F does not). do we still want to include the relation here?" }, { "prediction": "I think this should be `List findElements(By by);`", "reference": "This change should also probably go into the corresponding method of the abstract By class?" }, { "prediction": "Why is this removed?", "reference": "why this remove?" }, { "prediction": "Why is this change needed?", "reference": "As the test failures indicate, making this change is going to mean changing everything which currently implements this interface." }, { "prediction": "I think this should be `https://forum.upcase.com`", "reference": "Do we want to redirect this to the forum or something in case people have it linked/bookmarked?" }, { "prediction": "I don't think we need the `email` property here.", "reference": "@peterzimon came up with this 'NM' piece as a placeholder for New Member initials, without this the screen looks broken. It changes to normal initials calculation once email or name is entered. Lmk if you'd like to put something different here ;)" }, { "prediction": "I think this should be `subscriptions: attr('member-subscription')`.", "reference": "@kevinansfield Would be cool if you can take a if this is the best way to add `subscriptions` info on member model. This uses the transform + separate model definition way which seemed to be the right way from other references in Admin " }, { "prediction": "I don't think this is necessary.", "reference": "This is the common way of dealing with optional dependencies" }, { "prediction": "Why is this change needed?", "reference": "nit: we can replace all `kr` in this file with like `src`." }, { "prediction": "Why is this change needed?", "reference": "same concern here as above" }, { "prediction": "I think this should be `criteria.options.fetch(:read)` instead of `criteria.options.fetch(:read)`", "reference": "Thank you for this, I gather this repairs failures that I've seen in another PR." }, { "prediction": "I think this should be `allManifests.flatMap(new ReadManifest(ioBroadcast, Encoders.STRING()).toDF(\"file_path\").distinct());`", "reference": "This place probably makes sense to me. We can consider exposing an argument to make the dedup step optional (I am not sure it is a good idea but I want to think this through together). The dedup step we are adding is going to trigger a shuffle. Technically, we are fine in the existing expire snapshots action as it does the dedup in `except`. The question is what kind of performance impact deduplicating here will have. We only have duplicates if multiple manifests reference the same files. In `rewrite_manifests` procedure, we rewrite all manifests, meaning we produce a snapshot with new manifests where entries are old data files. Also, there are updates and deletes that may rewrite manifests. I think deduplicating here makes sense to me in all cases. Thoughts, @rdblue @flyrain @RussellSpitzer @karuppayya?" }, { "prediction": "I think this should be `logrus.Warn(\"error removing node from osdconfig:\", err)`", "reference": "can we move the code before deleteNodeFromDB ? this way even if the node crashes after remove config we can still re-run decommission again ?" }, { "prediction": "I think this should be `var_name='variable'`", "reference": "Seems the default value of `melt`'s `var_name` at namespace.py should be changed as well." }, { "prediction": "I think this test should be `test_parse_cloudtrail_with_botocore_integration_test`", "reference": "I think botocore's serializer should already create the correct headers. However, they are currently not used in `_botocore_parser_integration_test`(line #217). Maybe we could remove the headers here and just use a fallback in the `_botocore_parser_integration_test` (i.e. use the given headers if they are set, otherwise use the headers generated by botocore's serializer)?" }, { "prediction": "I don't think we need to change the name of the message to `delete_medication_used`.", "reference": "This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted." }, { "prediction": "I don't think we need the `id` parameter here.", "reference": "in case you want to rename one of the plugins when instantiating, from options?" }, { "prediction": "I think this should be `clang-func-mapping` instead of `clang-func-mapping`.", "reference": "This default variable should be moved into a config variable, created by `package_context`, and read from `config\\package_layout.json`." }, { "prediction": "I think this should be `(void 0 + 1)` instead of `(void 0 + 1)`", "reference": "Can I ask you to add a new line after `const` assignment? I believe that this increases the code readability by encapsulating assignment and logic (expecting) blocks." }, { "prediction": "I think this should be `#ifdef KOKKOS_IMPL_TURN_OFF_CUDA_HOST_INIT_CHECK` instead of `#ifdef KOKKOS_IMPL_TURN_OFF_CUDA_HOST_INIT_CHECK`", "reference": "So the intention is you configure with `-CMAKE_CXX_FLAGS=\"-D KOKKOS_IMPL_TURN_OFF_CUDA_HOST_INIT_CHECK\"`?" }, { "prediction": "Why is this change needed?", "reference": "This was a bug." }, { "prediction": "I think this should be `!empty($attributes['class']) && $attributes['class'] !== ''`", "reference": "Is OK that we don't have some placeholder?" }, { "prediction": "Why is this needed?", "reference": "Sectorbuilder behaves differently depending on whether it's given 1 or more threads. It won't seal if only given 1." }, { "prediction": "I don't think this is needed anymore.", "reference": "Sort of believe We should put MetricManager in constructor parameter given this case." }, { "prediction": "Why is this change needed?", "reference": "Do we need to check `fieldId` is larger than 1000?" }, { "prediction": "Why is this removed?", "reference": "I think this should be called after the if below (the one for disable positive acks)" }, { "prediction": "I don't think we need to change the method name to `listAvroPartition`.", "reference": "I'd like to avoid changing this method since it is public and using a URI will probably change behavior for users passing strings (String -> URI -> Path instead of String -> Path)." }, { "prediction": "I think this should be `os.Cleararenv()`.", "reference": "Should these restore the stashed env after the test runs?" }, { "prediction": "I think this should be `all_defaults = scope.args.defaults + [d for d in scope.args.kw_defaults if d is not None ]`", "reference": "We're calculating the full list of kwargs here (even if the first element of the list would return True) so we could improve performance by using a generator line 408 in ``for default_node in all_defaults:``." }, { "prediction": "I don't think we need this field. It's used by the commitRound function for counting the number of changes we've made per account. The ndeltas field is used by the commitRound function for counting the number of changes we've made per account. The ndeltas field is used by the commitRound function for counting the number of changes we've made per account. The ndeltas field is used by the commitRound function for counting the number of changes we've made per account. The ndeltas field is used by the commitRound function for counting the number of changes we've made per account. The ndeltas field is used by the commitRound function for counting the number of changes we've made per account. The number of changes we've made per account is used by the commitRound function for counting the number of changes we've made per account. The ndeltas field is used by the commitRound function for counting the number of changes we've made per account. The ndeltas field is used by the commitRound function for counting the number of changes we've made per account. The ndeltas field is used by the commitRound function for counting the number of changes we've made per account. The number of changes we've", "reference": "Can ndelta differ depending on when the deltas are compacted? That is, when intermediate updates are dropped?" }, { "prediction": "I think this should be `

    This rule needs a \"xpath\" property value in order to function.

    `", "reference": "Our checkstyle config likes it better when the `

    ` is before the first word of the next paragraph, and not on a blank line" }, { "prediction": "I think this should be `criuServer.Close()` instead of `criuServer.Close()`", "reference": "This looks to be the only place where we return early before the close below, so if the \"double close\" is bothering people, closing manually here (and removing the `defer`) could be an option" }, { "prediction": "I think this task should be `jest` instead of `qunit`.", "reference": "This task can probably be deleted since we don't need gulp to run Jest." }, { "prediction": "I don't think we need to use `Errno::EPERM` here, but I think it would be better to use `Errno::EPERM` instead of `Errno::EPERM`.", "reference": "Doesn't this need to include `Errno::ECONNRESET` to fix the issue?" }, { "prediction": "Use the new Ruby 1.9 hash syntax.
    Space inside { missing.
    Space inside } missing.", "reference": "never heard of a qirector... what's their role again? (also should be 'for a movie')" }, { "prediction": "I think this should be `if (tagContexts_.empty() && onlyVertexProps_) {` instead of `if (tagContexts_.empty() && onlyVertexProps_) {`", "reference": "Implement the \"collect all props for one vertex\" logic inside QueryVertexPropsProcessor" }, { "prediction": "I think this should be `stream.eof() && !stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof() && stream.eof", "reference": "This is to prevent parsing things like \"1.1\" as \"1\" until we implement it properly." }, { "prediction": "I think this should be `_getCheckpointParentDir` instead of `_getCheckpointParentDir`.", "reference": "Can we change `_getCheckpointParentDir` to be a public function explicitly? It seems like something that clients of experiment runner may wish to use." }, { "prediction": "I think this should be \"Use UI Automation to access the Windows Console (restart NVDA for changes to take effect)\"", "reference": "Why is a restart necessary?" }, { "prediction": "I think this should be `if !cfg.External.Enabled() {` instead of `if !cfg.Internal.Enabled() {`", "reference": "Should setting the task runtime also go under the above if condition?" }, { "prediction": "I think this should be `defaultListEntriesPageSize = 50`", "reference": "SPIRE uses the leadingLowerCase convention for unexported constants" }, { "prediction": "Is this needed?", "reference": "The newest JSchema code generator orders `System` usings first." }, { "prediction": "I think this should be `boolean caseSensitive = configuration.getBoolean(InputFormatConfig.CASE_SENSITIVE, InputFormatConfig.CASE_SENSITIVE_DEFAULT);`", "reference": "I understand that we want to have a possibility to configure the IcebergInputFormat to be case sensitive or case insensitive since it can be used by other MR jobs as well. Do we want to allow the users of Hive to shot themselves on the foot and enable case sensitivity? My first guess would be that we should not use the configuration here, just go with `false`, but if you have some specific use-case in your mind I can be easily convinced " }, { "prediction": "I think this should be `pool.PoolAddEventHandled = true`", "reference": "Will the above call to cStorPoolAddEventHandler() get executed in the same thread as this line?" }, { "prediction": "I think this should be `if len(fn.normalCalls) == 0 && fn.fn.FirstBasicBlock().FirstInstruction().IsNil() {`", "reference": "I don't think alloca instructions are always at the start of the entry block. I think it would be safer to check the entire entry block for alloca instructions, just in case some are not the first instruction. (Technically they can be anywhere in the function but we check in other places that this isn't possible)." }, { "prediction": "I think this should be `VXLANPort` or `VXLANVNI`", "reference": "Why isn't this 4789 (which I think is the Felix default)?" }, { "prediction": "I think this should be `FailureImported` instead of `FailureImportOperations`.", "reference": "Can this be `Import operations failure`? In addition, is this the right time to change the variable names? e.g. `ReasonImportOperationsFailure`, `ReasonImportFailure`, `ReasonImportSuccessful`, `ReasonCreateResourceFailure`, `ReasonImportResourceSuccessful` Naming convention that i have assumed here is as follows: `Reason`" }, { "prediction": "I think this should be `rb_global_variable(&rbuf_ivar_id);`", "reference": "I suspect this isn't needed because I think `rb_intern` gets marked already." }, { "prediction": "I think this should be `log.info(\"In dev mode. Copying required files in case we're using a WebDriver-backed Selenium\");` or `log.finest(\"In dev mode. Copying required files in case we're using a WebDriver-backed Selenium\");` or `log.finest(\"In dev mode. Copying required files in case we're using a WebDriver-backed Selenium\");`", "reference": "This change is incorrect: the current log level is correct." }, { "prediction": "Why is this needed?", "reference": "Can you add a space before the equal sign? There are a couple other places where spaces are missing in this PR." }, { "prediction": "I don't think we should remove this TODO.", "reference": "Please follow the todo naming convention." }, { "prediction": "I don't think we need to add a description here.", "reference": "These are no longer used and changes should instead be made directly to the files in `deploy/chart/crds` /assign @JoshVanL /unassign" }, { "prediction": "I think this should be `bbox_pred = self.bbox_coder.decode(multi_lvl_anchors[i], xywh, axis=-1)` instead of `bbox_pred = self.bbox_coder.decode(multi_lvl_anchors[i], xywh, axis=-1)`", "reference": "Is this really necessary to work around this way? The old version works fine with me when converting to ONNX." }, { "prediction": "Why is this change needed?", "reference": "Same as above: don't start error strings with a capital letter, and don't fix unneeded things in an unrelated commit ;)" }, { "prediction": "I think this should be `@logger.debug` instead of `@logger.debug`", "reference": "Is this a testing debug statement?" }, { "prediction": "I think this should be `var object = parse(url, options, function(err, connectionStringObject) { console.log(err, connectionStringObject); });`", "reference": "you'll need to wrap the _whole thing_ within this async call (or refactor it so everything below is in a new temporary function). The code below this section depends on a value for `object` after the parsing occurs, but what you're doing here is kicking off a race condition where `object` is null, but _might_ parse quickly enough to assign it the parsed parts. Instead, you need to do everything that depends on the parsed object in the callback of `parse`." }, { "prediction": "Why is this needed?", "reference": "This is now going to be protecting `stopped` when it doesn't need to. If you are going to do this then can you make `stopped` non-atomic and protect it in `stop`. It's cheap to make a `unique_lock` fyi, it's just a pointer to a mutex and a `bool`. The `lk.lock ()` in the loop is superfluous so probably shouldn't have been there to begin with." }, { "prediction": "I don't think we need to add the `remote_config` here.", "reference": "Lets not give packages names if we dont have to. If a package requires a rename, we should change the actual name while/if we can." }, { "prediction": "I don't think we need to check for `TEST(1U << 31, enc) && TEST(1U << 15, enc)`", "reference": "Not sure I see where this is coming from. This is a bug fix? Should be mentioned in the commit message? Same below." }, { "prediction": "Why is this removed?", "reference": "I reverted this change in the last commit, I think we should revert it here. I know this leads to confusing test output for skipped tests, but I would prefer to tackle that in a separate PR specifically focused on that problem. In fact, I think the issue might really be with the leak checker, and not how this test runner is defined. Please make a ticket for this (if it doesn't already exist) and revert this change" }, { "prediction": "I think this should be `True` instead of `False`.", "reference": "Can this part be done in `dataset.get_ann_info`? Just like CocoDataset converts xywh to xyxy in `_parse_ann_info`" }, { "prediction": "I think this should be `global.NoopProvider`", "reference": "Should we change the name of this test struct to be `testTracerProvider` as well?" }, { "prediction": "I think this should be `github.com/iotexproject/iotex-core/protogen/iotexapi`", "reference": "\"google.golang.org/grpc\" should be together with \"go.uber.org/zap\" all \"\"github.com/iotexproject/iotex-core/*\" stay together" }, { "prediction": "I think this should be `self._inject_early_js('js', js_code_print, subframes=True, world=QWebEngineScript.MainWorld)`", "reference": "No need for a separate variable here - just call `utils.read_file` directly below." }, { "prediction": "I think this should be `time.Now().Add(MessageTimeoutDefault)`", "reference": "Thanks for the fixing, small question, Here the message just be written to the channel, will it be blocked?" }, { "prediction": "I think this is a bit confusing to me, but I think it would be better to add a `Senders` field to the `SyncStage` type. I think it would be better to add a `Senders` field to the `SyncStage` type, and then add a `Senders` field to the `SyncStage` type.", "reference": "maybe we will have something like `Bodies []byte(\"bodies\")` instead of them being a number? with numbers we are making it harder to insert stages mid-process." }, { "prediction": "Why is this removed?", "reference": "out of curiosity, why making this change? If no real reason, could you restore to avoid unnecessary changes of several generated files?" }, { "prediction": "I think this is a bit confusing to me, but I think it would be better to use `State` instead of `State` here.", "reference": "Could we public events if `manager.serStatus()`?" }, { "prediction": "I think this should be `